Timeline
Mar 11, 2013:
- 11:52 PM Changeset in webkit [145490] by
-
- 3 edits in trunk/LayoutTests
Unreviewed test flakiness fix.
- inspector/debugger/xhr-breakpoints.html:
- platform/chromium/TestExpectations:
- 11:43 PM Changeset in webkit [145489] by
-
- 16 edits8 adds in trunk
DFG overflow check elimination is too smart for its own good
https://bugs.webkit.org/show_bug.cgi?id=111832
Source/JavaScriptCore:
Reviewed by Oliver Hunt and Gavin Barraclough.
Rolling this back in after fixing accidental misuse of JSValue. The code was doing value < someInt
rather than value.asInt32() < someInt. This "worked" when isWithinPowerOfTwo wasn't templatized.
It worked by always being false and always disabling the relvant optimization.
This improves overflow check elimination in three ways:
1) It reduces the amount of time the compiler will spend doing it.
2) It fixes bugs where overflow check elimination was overzealous. Precisely, for a binary operation
over @a and @b where both @a and @b will type check that their inputs (@a->children, @b->children)
are int32's and then perform a possibly-overflowing operation, we must be careful not to assume
that @a's non-int32 parts don't matter if at the point that @a runs we have as yet not proved that
@b->children are int32's and that hence @b might produce a large enough result that doubles would
start chopping low bits. The specific implication of this is that for a binary operation to not
propagate that it cares about non-int32 parts (NodeUsedAsNumber), we must prove that at least one
of the inputs is guaranteed to produce a result within 232 and that there won't be a tower of such
operations large enough to ultimately produce a double greater than 252 (roughly). We achieve the
latter by disabling this optimization for very large basic blocks. It's noteworthy that blocks that
large won't even make it into the DFG currently.
3) It makes the overflow check elimination more precise for cases where the inputs to an Add or Sub
are the outputs of a bit-op. For example in (@a + (@b | 0)) | 0, we don't need to propagate
NodeUsedAsNumber to either @a or @b.
This is neutral on V8v7 and a slight speed-up on compile time benchmarks.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine):
- dfg/DFGBackwardsPropagationPhase.cpp: Added.
(DFG):
(BackwardsPropagationPhase):
(JSC::DFG::BackwardsPropagationPhase::BackwardsPropagationPhase):
(JSC::DFG::BackwardsPropagationPhase::run):
(JSC::DFG::BackwardsPropagationPhase::isNotNegZero):
(JSC::DFG::BackwardsPropagationPhase::isNotZero):
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwoForConstant):
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwoNonRecursive):
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::BackwardsPropagationPhase::mergeDefaultFlags):
(JSC::DFG::BackwardsPropagationPhase::propagate):
(JSC::DFG::performBackwardsPropagation):
- dfg/DFGBackwardsPropagationPhase.h: Added.
(DFG):
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::clearIsLoadedFrom):
(CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::dumpNodeFlags):
(DFG):
- dfg/DFGNodeFlags.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGUnificationPhase.cpp:
(JSC::DFG::UnificationPhase::run):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsLoadedFrom):
(VariableAccessData):
(JSC::DFG::VariableAccessData::setIsLoadedFrom):
(JSC::DFG::VariableAccessData::isLoadedFrom):
LayoutTests:
Reviewed by Oliver Hunt and Gavin Barraclough.
- fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int-expected.txt: Added.
- fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.html: Added.
- fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers-expected.txt: Added.
- fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js: Added.
(foo):
(bar):
- fast/js/script-tests/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.js: Added.
(foo):
(bar):
- 11:26 PM Changeset in webkit [145488] by
-
- 3 edits2 deletes in trunk/LayoutTests
Not reviewed: Chromium expectations updated.
- platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
- platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Removed.
- platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.txt:
- platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:
- 11:20 PM Changeset in webkit [145487] by
-
- 3 edits in trunk/LayoutTests
Not reviewed: Chromium expectations updated.
- platform/chromium-mac/fast/borders/border-radius-with-box-shadow-expected.png:
- platform/chromium-win/fast/borders/border-radius-with-box-shadow-expected.png:
- 11:20 PM Changeset in webkit [145486] by
-
- 2 edits in trunk/Source/WebCore
We'll get there eventually.
- platform/graphics/ca/win/PlatformCAFiltersWin.cpp:
- 11:12 PM Changeset in webkit [145485] by
-
- 7 edits in trunk/Source/WebKit2
Loads are never canceled in the NetworkProcess
<rdar://problem/12890500> and https://bugs.webkit.org/show_bug.cgi?id=112103
Reviewed by Alexey Proskuryakov.
If a connection to a WebProcess is closed (gracefully or by crashing) then:
- All scheduled loads for that connection should be forgotten.
- All in-progress loads for that connection should be aborted asap.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::requestsToCleanupMutex): The "request to stop" mechanism is now called "request to cleanup"
(WebKit::requestsToCleanup):
(WebKit::NetworkResourceLoader::scheduleCleanupOnMainThread):
(WebKit::NetworkResourceLoader::performCleanups):
(WebKit::NetworkResourceLoader::cleanup):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::didFail):
(WebKit::NetworkResourceLoader::connectionToWebProcessDidClose): If there is a resource handle, let
the loading thread notice the connection is invalid. Otherwise request to cleanup the loader.
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
(WebKit::NetworkResourceLoader::sendSyncAbortingOnFailure):
(WebKit::NetworkResourceLoader::abortInProgressLoad): Cancel the resource handle and schedule main thread cleanup.
(WebKit::NetworkResourceLoader::didReceiveResponse): Use sendAbortingOnFailure instead of send.
(WebKit::NetworkResourceLoader::didReceiveData): Ditto.
(WebKit::NetworkResourceLoader::willSendRequest): Call abortInProgressLoad if the sync message failed.
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpace): Ditto.
- NetworkProcess/NetworkResourceLoader.h:
Make connectionToWebProcessDidClose() pure virtual, moving its implementation to the subclasses:
- NetworkProcess/SchedulableLoader.cpp:
- NetworkProcess/SchedulableLoader.h:
- NetworkProcess/SyncNetworkResourceLoader.cpp:
(WebKit::SyncNetworkResourceLoader::start): Call cleanup().
(WebKit::SyncNetworkResourceLoader::connectionToWebProcessDidClose): Call cleanup().
(WebKit::SyncNetworkResourceLoader::cleanup): Factor out the sync loader cleanup code.
- NetworkProcess/SyncNetworkResourceLoader.h:
- 11:10 PM Changeset in webkit [145484] by
-
- 2 edits in trunk/Source/WebCore
Fumbled adding new files to the vcproj. Fixing.
- WebCore.vcproj/WebCore.vcproj:
- 10:51 PM Changeset in webkit [145483] by
-
- 3 edits1 copy in trunk/Source/WebCore
Fix the Windows build by providing implementations of PlatformCAFilters::setFiltersOnLayer(),
PlatformCAFilters::numAnimatedFilterProperties() and PlatformCAFilters::animatedFilterPropertyName(),
adding PlatformCAFiltersWin.cpp to the vcproj.
- WebCore.vcproj/WebCore.vcproj:
- platform/graphics/ca/PlatformCAFilters.h:
(PlatformCAFilters):
- platform/graphics/ca/win/PlatformCAFiltersWin.cpp: Copied from Source/WebCore/platform/graphics/ca/PlatformCAFilters.h.
(PlatformCAFilters::setFiltersOnLayer):
(PlatformCAFilters::numAnimatedFilterProperties):
(PlatformCAFilters::animatedFilterPropertyName):
- 10:51 PM Changeset in webkit [145482] by
-
- 3 edits in trunk/Source/JavaScriptCore
Harden JSStringJoiner
https://bugs.webkit.org/show_bug.cgi?id=112093
Reviewed by Filip Pizlo.
Harden JSStringJoiner, make it use our CheckedArithmetic
class to simplify everything.
- runtime/JSStringJoiner.cpp:
(JSC::JSStringJoiner::build):
- runtime/JSStringJoiner.h:
(JSStringJoiner):
(JSC::JSStringJoiner::JSStringJoiner):
(JSC::JSStringJoiner::append):
- 10:45 PM Changeset in webkit [145481] by
-
- 5 edits2 adds in trunk
Don't create multiple user gesture indicators when forwarding events to sub frames
https://bugs.webkit.org/show_bug.cgi?id=111923
Reviewed by Adam Barth.
Ports that implement consumable user gestures depend on a single user
gesture indicator being created in response to a single user gesture.
Source/WebCore:
Test: platform/chromium/fast/events/popup-allowed-from-gesture-only-once-iframes.html
- dom/UserGestureIndicator.cpp:
(WebCore::isDefinite):
(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::processingUserGesture):
- dom/UserGestureIndicator.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTouchEvent):
LayoutTests:
- platform/chromium/fast/events/popup-allowed-from-gesture-only-once-iframes-expected.txt: Added.
- platform/chromium/fast/events/popup-allowed-from-gesture-only-once-iframes.html: Added.
- 10:37 PM Changeset in webkit [145480] by
-
- 2 edits in trunk/Source/WebCore
Fix Windows build.
- platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
- 10:23 PM Changeset in webkit [145479] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: Chromium expectations updated.
- platform/chromium/TestExpectations:
- 10:10 PM Changeset in webkit [145478] by
-
- 1 edit2 moves10 deletes in trunk/LayoutTests
Not reviewed: Chromium rebaselines.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Removed.
- platform/chromium-mac-lion/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed.
- platform/chromium-mac-lion/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Removed.
- platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed.
- platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Removed.
- platform/chromium-mac/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed.
- platform/chromium-mac/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Removed.
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed.
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Removed.
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Renamed from LayoutTests/platform/chromium-linux/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt.
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Renamed from LayoutTests/platform/chromium-linux/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt.
- 10:10 PM Changeset in webkit [145477] by
-
- 16 edits in trunk/Source/WebKit2
PDFPlugin: Return PDFKit's data instead of the original resource data for save/etc.
https://bugs.webkit.org/show_bug.cgi?id=111956
<rdar://problem/13352282>
Reviewed by Alexey Proskuryakov.
If we return the original resource data, we lose changes made to annotations.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::pdfDocumentDidLoad): Adopt the renamed rawData().
(WebKit::PDFPlugin::saveToPDF): Use liveData so that "Save to PDF" persists changes to annotations.
(WebKit::PDFPlugin::openWithNativeApplication): Use liveData so that "Open With [native application]" persists changes to annotations.
- WebProcess/Plugins/PDF/PDFPluginAnnotation.h:
- WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
(WebKit::PDFPluginAnnotation::commit): Added, inform PDFPlugin that we're mutating the document.
- WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:
(WebKit::PDFPluginChoiceAnnotation::commit): Let PDFPluginAnnotation do what it needs to inform PDFPlugin that we're going to mutate the document.
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::commit): Let PDFPluginAnnotation do what it needs to inform PDFPlugin that we're going to mutate the document.
- WebProcess/Plugins/PDF/SimplePDFPlugin.h:
(WebKit::SimplePDFPlugin::didMutatePDFDocument): Added.
(WebKit::SimplePDFPlugin::liveData): Added.
(WebKit::SimplePDFPlugin::rawData): Renamed from data(). Return NSData for consistency.
(WebKit::SimplePDFPlugin::pdfDocumentWasMutated): Added.
- WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
(WebKit::SimplePDFPlugin::liveData): Return PDFKit's data if the user has mutated the
document, otherwise the raw data. This way, PDFs that PDFKit can't process will still
be downloadable as long as the user doesn't interact with annotations.
(WebKit::SimplePDFPlugin::liveResourceData): Return a SharedData wrapping the PDFDocument's data.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/PDF/SimplePDFPlugin.h:
- WebProcess/Plugins/Plugin.h:
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/Plugins/PluginView.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getMainResourceDataOfFrame):
Use a SharedData instead of raw data for getResourceData, and rename it liveResourceData().
- 10:00 PM Changeset in webkit [145476] by
-
- 4 edits in trunk/LayoutTests
Not reviewed: Chromium rebaselines.
- platform/chromium/compositing/overflow/composited-scrolling-paint-phases-expected.txt:
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt:
- 9:58 PM Changeset in webkit [145475] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after http://trac.webkit.org/changeset/145472.
- platform/graphics/ca/mac/PlatformCAFiltersMac.mm:
(PlatformCAFilters::colorMatrixValueForFilter):
- 9:55 PM Changeset in webkit [145474] by
-
- 4 edits2 adds in trunk
[CSS] shadow from radius has wrong render in webkit
https://bugs.webkit.org/show_bug.cgi?id=99928
Reviewed by Simon Fraser.
Source/WebCore:
No rounded cornder should be expanded in the mixed case, i.e. some
corners are rounded, but others are not rounded.
Need to look at each corner independently,
i.e. top-left, top-right, bottom-left and bottom-right, and
to expand corners whose width and height are larger than 0.
Test: fast/box-shadow/box-shadow-with-zero-radius.html
- platform/graphics/RoundedRect.cpp:
(WebCore::RoundedRect::Radii::expand):
LayoutTests:
- fast/box-shadow/box-shadow-with-zero-radius-expected.html: Added.
- fast/box-shadow/box-shadow-with-zero-radius.html: Added.
- platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png:
Rebaselined. Comparing the old one with the new one, both ones look almost
the same.
- 9:22 PM Changeset in webkit [145473] by
-
- 2 edits in trunk/LayoutTests
[chromium] Fix flaky timeouts in platform/chromium/events/fast/events/intercept-postmessage.html
https://bugs.webkit.org/show_bug.cgi?id=112089
Patch by James Robinson <jamesr@chromium.org> on 2013-03-11
Reviewed by Adam Barth.
This test had a few problems. The most serious is it raced a window.postMessage() from an inline <script> in the
<head> with the HTML parser processing the rest of the testcase. If the HTML parser yielded before parsing out
the <pre id="console">, function recvMsg1 would generate an error accessing the undefined pre. The test also
set up a setTimeout with a timeout of 50ms to run after a postMessage handler. There's no need to wait after
yielding for a timeout, these events are processed in order.
- platform/chromium/fast/events/intercept-postmessage.html:
- 9:02 PM Changeset in webkit [145472] by
-
- 8 edits2 adds in trunk/Source/WebCore
[CA] Animations of CSS filters don't work correctly
https://bugs.webkit.org/show_bug.cgi?id=111905
Reviewed by Dean Jackson.
Fix various issues with transitions of composited filters on Mac,
most of which stemmed from the conversion to use CAFilter.
Put the Mac CA filter-related code into a new file, PlatformCAFilters,
to group code that creates filter properties into a single place.
Animations of CIFilters using multiple values never worked correctly,
because we would clobber all but the last property for each filter,
so fix that.
Changes in the moved filter code:
- Made use of sepiaFullConstants in the CIFilter and CAFilter code.
- For CI, return CIVectors instead of NSArrays of NSNumbers.
- Fudge the inputColor for the CI grayscale filter to better match software filters.
- fix some cases where the behavior was wrong in the isDefault() case.
- WebCore.xcodeproj/project.pbxproj: Add PlatformCAFilters.h, PlatformCAFiltersMac.mm.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::animationNameForTransition): This function was creating a string
containing non-ASCII characters.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::animationIdentifier): To handle CIFilter animations, we need to tack another
index onto the animation identifier, since some animations require animating multiple
properties of the same CIFilter. Add "subIndex" for this.
(WebCore::GraphicsLayerCA::moveOrCopyAnimations): Ditto.
(WebCore::GraphicsLayerCA::updateAnimations): Ditto.
(WebCore::GraphicsLayerCA::setAnimationOnLayer): Ditto.
(WebCore::GraphicsLayerCA::removeCAAnimationFromLayer): Ditto.
(WebCore::GraphicsLayerCA::pauseCAAnimationOnLayer): Ditto.
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes): Ditto.
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations): Ditto.
- platform/graphics/ca/GraphicsLayerCA.h: Ditto.
(WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation):
(LayerPropertyAnimation):
- platform/graphics/ca/PlatformCAAnimation.h:
(PlatformCAAnimation): Functions moved.
- platform/graphics/ca/PlatformCAFilters.h: Added.
(PlatformCAFilters):
- platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
(PlatformCAAnimation::setFromValue):
(PlatformCAAnimation::setToValue):
(PlatformCAAnimation::setValues):
- platform/graphics/ca/mac/PlatformCAFiltersMac.mm: Added.
(PlatformCAFilters::filterValueForOperation):
(PlatformCAFilters::colorMatrixValueForFilter):
(PlatformCAFilters::numAnimatedFilterProperties):
(PlatformCAFilters::animatedFilterPropertyName):
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::PlatformCALayer):
(PlatformCALayer::addAnimationForKey):
(PlatformCALayer::setFilters):
(PlatformCALayer::filtersCanBeComposited):
- 8:00 PM Changeset in webkit [145471] by
-
- 29 edits in trunk/Source
Unreviewed, rolling out r145462.
http://trac.webkit.org/changeset/145462
https://bugs.webkit.org/show_bug.cgi?id=112097
Compilation failure in PluginView.cpp (Requested by jamesr_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-11
Source/WebCore:
- accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::canSetFocusAttribute):
- bindings/objc/DOM.mm:
(kitClass):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- editing/ApplyStyleCommand.cpp:
(WebCore::isLegacyAppleStyleSpan):
(WebCore::isEmptyFontTag):
(WebCore::ApplyStyleCommand::applyBlockStyle):
- editing/FormatBlockCommand.cpp:
(WebCore::isElementForFormatBlock):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::isMailPasteAsQuotationNode):
(WebCore::haveSameTagName):
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):
- history/CachedPage.cpp:
(WebCore::CachedPage::restore):
- html/ColorInputType.cpp:
(WebCore::ColorInputType::suggestions):
- html/HTMLTableRowsCollection.cpp:
(WebCore::isInHead):
(WebCore::isInBody):
(WebCore::isInFoot):
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::innerPatchNode):
- page/PageSerializer.cpp:
(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):
- plugins/PluginView.cpp:
(WebCore::PluginView::getValue):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintContents):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::name):
- rendering/RenderMedia.cpp:
(WebCore::RenderMedia::mediaElement):
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::autosaveName):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::textFormControlElement):
(WebCore::updateUserModifyProperty):
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement):
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::updateFromElement):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::endElementNs):
Source/WebKit/chromium:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::focusedNodeChanged):
- src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- src/DOMUtilitiesPrivate.cpp:
(WebCore::toHTMLElement):
- src/WebSearchableFormData.cpp:
(HTMLNames::IsSelectInDefaultState):
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _enterFullscreenForNode:WebCore::]):
- 7:52 PM Changeset in webkit [145470] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 144713
BUG=174846
Review URL: https://codereview.chromium.org/12518025
- 7:48 PM Changeset in webkit [145469] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 144400
BUG=173654
- 7:38 PM Changeset in webkit [145468] by
-
- 2 edits in trunk/Tools
[Mac][WK1] Add support for alert() in MiniBrowser.
<http://webkit.org/b/112090>
Reviewed by Anders Carlsson.
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
- 7:31 PM Changeset in webkit [145467] by
-
- 2 edits in branches/chromium/1410/Source/WebCore/html/parser
Merge 144128
BUG=178003
Review URL: https://codereview.chromium.org/12518024
- 7:24 PM Changeset in webkit [145466] by
-
- 9 edits1 add in trunk/Source/WebCore
Move SharedWorkerRepository functions out of DefaultSharedWorkerRepository
https://bugs.webkit.org/show_bug.cgi?id=100418
Reviewed by Sam Weinig.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Added SharedWorkerRepository.cpp.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
Chromium uses WebKit/chromium/src/SharedWorkerRepository.cpp instead of
WebCore/workers/DefaultSharedWorkerRepository.cpp. Not sure why it's added and
then excluded, but did the same with the new SharedWorkerRepository.cpp, which
just contains some code moved from that file.
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::load): Removed a PLATFORM(CHROMIUM) clause,
chromium doesn't compile this file.
(WebCore::DefaultSharedWorkerRepository::connectToWorker): Added a FIXME about
seemingly wrong code.
- workers/SharedWorkerRepository.cpp: Added.
(WebCore::SharedWorkerRepository::isAvailable):
(WebCore::SharedWorkerRepository::connect):
(WebCore::SharedWorkerRepository::documentDetached):
(WebCore::SharedWorkerRepository::hasSharedWorkers):
Moved from DefaultSharedWorkerRepository.cpp, because this is part of SharedWorkerRepository.
- 7:18 PM Changeset in webkit [145465] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 144790
BUG=179287
Review URL: https://codereview.chromium.org/12518023
- 7:09 PM Changeset in webkit [145464] by
-
- 10 edits2 adds in trunk
Make BackgroundHTMLParser work with doc.writes that enter or leave foreign content
https://bugs.webkit.org/show_bug.cgi?id=109764
Reviewed by Eric Seidel.
Source/WebCore:
Previously, we were not reseting the state of the
HTMLTreeBuilderSimulator when we failed speculative parsing. This had a
number of observable consequences, including not parsing CDATA sections
correctly when document.write caused us to enter foreign content.
Test: fast/parser/document-write-svg-cdata.html
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::resumeFrom):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
- html/parser/BackgroundHTMLParser.h:
(Checkpoint):
(BackgroundHTMLParser):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::validateSpeculations):
(WebCore::HTMLDocumentParser::didFailSpeculation):
- html/parser/HTMLDocumentParser.h:
(ParsedChunk):
- html/parser/HTMLElementStack.h:
(WebCore::HTMLElementStack::ElementRecord::namespaceURI):
- html/parser/HTMLTreeBuilder.h:
(WebCore::HTMLTreeBuilder::options):
(WebCore::HTMLTreeBuilder::openElements):
(HTMLTreeBuilder):
- html/parser/HTMLTreeBuilderSimulator.cpp:
(WebCore::HTMLTreeBuilderSimulator::stateFor):
(WebCore):
- html/parser/HTMLTreeBuilderSimulator.h:
(WebCore):
(WebCore::HTMLTreeBuilderSimulator::state):
(WebCore::HTMLTreeBuilderSimulator::setState):
(HTMLTreeBuilderSimulator):
LayoutTests:
- fast/parser/document-write-svg-cdata-expected.txt: Added.
- fast/parser/document-write-svg-cdata.html: Added.
- 7:04 PM Changeset in webkit [145463] by
-
- 2 edits2 copies in branches/chromium/1410
Merge 144825
BUG=177932
- 6:59 PM Changeset in webkit [145462] by
-
- 29 edits in trunk/Source
Replace static_casts with to* functions.
https://bugs.webkit.org/show_bug.cgi?id=112072
Reviewed by Philip Rogers.
to* functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.
Source/WebCore:
- accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::canSetFocusAttribute):
- bindings/objc/DOM.mm:
(kitClass):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- editing/ApplyStyleCommand.cpp:
(WebCore::isLegacyAppleStyleSpan):
(WebCore::isEmptyFontTag):
(WebCore::ApplyStyleCommand::applyBlockStyle):
- editing/FormatBlockCommand.cpp:
(WebCore::isElementForFormatBlock):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::isMailPasteAsQuotationNode):
(WebCore::haveSameTagName):
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):
- history/CachedPage.cpp:
(WebCore::CachedPage::restore):
- html/ColorInputType.cpp:
(WebCore::ColorInputType::suggestions):
- html/HTMLTableRowsCollection.cpp:
(WebCore::isInHead):
(WebCore::isInBody):
(WebCore::isInFoot):
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::innerPatchNode):
- page/PageSerializer.cpp:
(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):
- plugins/PluginView.cpp:
(WebCore::PluginView::getValue):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintContents):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::name):
- rendering/RenderMedia.cpp:
(WebCore::RenderMedia::mediaElement):
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::autosaveName):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::textFormControlElement):
(WebCore::updateUserModifyProperty):
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement):
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::updateFromElement):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::endElementNs):
Source/WebKit/chromium:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::focusedNodeChanged):
- src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- src/DOMUtilitiesPrivate.cpp:
(WebCore::toHTMLElement):
- src/WebSearchableFormData.cpp:
(HTMLNames::IsSelectInDefaultState):
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _enterFullscreenForNode:WebCore::]):
- 6:56 PM Changeset in webkit [145461] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r187216. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-11
- DEPS:
- 6:55 PM Changeset in webkit [145460] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 144338
BUG=178797
Review URL: https://codereview.chromium.org/12638027
- 6:50 PM Changeset in webkit [145459] by
-
- 10 edits in trunk/Source/WebCore
Replace static_casts for SVGSVGElement and SVGStopElement
https://bugs.webkit.org/show_bug.cgi?id=111651
Reviewed by Stephen Chenney.
toSVGSVGElement and toSVGStopElement are preferred over static_casts because bad casts
can be caught on our testing infrastructure. This patches replaces all static_casts for
SVGSVGElement and SVGStopElement with toSVGSVGElement and toSVGStopElement, respectively.
Additionaly, this patch renames SVGElement::isSVG to SVGElement::isSVGSVGElement to
remove ambiguity for callers who may confuse this with isSVGElement.
No new tests as this is covered with existing tests.
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::buildLocalToBorderBoxTransform):
(WebCore::RenderSVGRoot::hasRelativeDimensions):
(WebCore::RenderSVGRoot::hasRelativeIntrinsicLogicalWidth):
(WebCore::RenderSVGRoot::hasRelativeLogicalHeight):
- rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::determineIfLayoutSizeChanged):
(WebCore::RenderSVGViewportContainer::calcViewport):
(WebCore::RenderSVGViewportContainer::viewportTransform):
- svg/SVGDocument.cpp:
(WebCore::SVGDocument::rootElement):
(WebCore::SVGDocument::childShouldCreateRenderer):
- svg/SVGElement.cpp:
(WebCore::SVGElement::ownerSVGElement):
- svg/SVGElement.h:
(WebCore::SVGElement::isSVGSVGElement):
- svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::buildStops):
- svg/SVGLengthContext.cpp:
(WebCore::SVGLengthContext::determineViewport):
- svg/SVGSVGElement.h:
(WebCore):
(WebCore::toSVGSVGElement):
- svg/SVGStopElement.h:
(WebCore::toSVGStopElement):
(WebCore):
- 6:42 PM Changeset in webkit [145458] by
-
- 4 edits in trunk/Source/WebKit2
[wk2] WebProcess and WebContentService don't respect system localization
https://bugs.webkit.org/show_bug.cgi?id=112091
<rdar://problem/13233590>
Reviewed by Dan Bernstein.
Allow CFBundle to use localizations that don't exist in the main bundle,
so that, for example, injected bundles can load and use strings from localized frameworks.
- WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
- 6:39 PM Changeset in webkit [145457] by
-
- 3 edits in trunk/Source/WebCore
Small code cleanup in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=112076
Reviewed by Ojan Vafai.
No new tests, this is a refactor and existing tests in css3/flexbox should pass.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Remove unused param from repositionLogicalHeightDependentFlexItems.
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems): Remove unused param from repositionLogicalHeightDependentFlexItems.
The clientLogicalBottom can't have changed in this time (the only thing we've done is align children).
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Just call layout() if we marked the flexitem as needing layout.
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): Just call layout() if we marked the flexitem as needing layout.
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox): Remove unused param from repositionLogicalHeightDependentFlexItems.
- 6:25 PM Changeset in webkit [145456] by
-
- 2 edits in branches/chromium/1410/Source/WebCore/Modules/webaudio
Merge 144417
BUG=172342
Review URL: https://codereview.chromium.org/12543030
- 6:19 PM Changeset in webkit [145455] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 143859
BUG=177933
Review URL: https://codereview.chromium.org/12637021
- 6:17 PM Changeset in webkit [145454] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
Merge 144241
BUG=177873
Review URL: https://codereview.chromium.org/12667022
- 6:15 PM Changeset in webkit [145453] by
-
- 33 edits in trunk/Source
Rename DefinitelyProcessingUserGesture to DefinitelyProcessingNewUserGesture
https://bugs.webkit.org/show_bug.cgi?id=111959
Reviewed by Alexey Proskuryakov.
Source/WebCore:
The rationale is that the UserGestureIndicator will increase the number
of consumable user gestures when it's invoked with what is now
DefinitelyProcessingNewUserGesture.
In a follow-up change I will reintroduce DefinitelyProcessingUserGesture
which will only increase the consumable user gesture count if we are
not already processing a user gesture.
No new tests, no change in functionality.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::increment):
(WebCore::AccessibilityNodeObject::decrement):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press):
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeScript):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeScriptInWorld):
- bindings/v8/NPV8Object.cpp:
(_NPN_EvaluateHelper):
- dom/UserGestureIndicator.cpp:
(WebCore::isDefinite):
(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::processingUserGesture):
- dom/UserGestureIndicator.h:
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::openInNewTab):
- inspector/InspectorFrontendHost.cpp:
(WebCore::FrontendMenuProvider::contextMenuItemSelected):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::navigate):
- loader/NavigationScheduler.cpp:
(WebCore::ScheduledURLNavigation::fire):
(WebCore::ScheduledURLNavigation::didStartTimer):
(WebCore::ScheduledRedirect::fire):
(WebCore::ScheduledRefresh::fire):
(WebCore::ScheduledHistoryNavigation::fire):
(WebCore::ScheduledFormSubmission::fire):
(WebCore::ScheduledFormSubmission::didStartTimer):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTouchEvent):
- platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::handleMouseDownEvent):
(WebCore::PopupContainer::handleMouseMoveEvent):
(WebCore::PopupContainer::handleMouseReleaseEvent):
(WebCore::PopupContainer::handleWheelEvent):
(WebCore::PopupContainer::handleKeyEvent):
Source/WebKit/blackberry:
- WebKitSupport/NotificationManager.cpp:
(BlackBerry::WebKit::NotificationManager::notificationClicked):
Source/WebKit/chromium:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::executeScriptAndReturnValue):
- src/WebNotification.cpp:
(WebKit::WebNotification::dispatchClickEvent):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleEvent):
(WebKit::WebPluginContainerImpl::loadFrameRequest):
- src/WebScopedUserGesture.cpp:
(WebKit::WebScopedUserGesture::initialize):
- tests/WebUserGestureTokenTest.cpp:
(WebCore::TEST):
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::evaluate):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView sendEvent:isDrawRect:]):
Source/WebKit/qt:
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::notificationClicked):
Source/WebKit/win:
- WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
Source/WebKit2:
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::didClickNotification):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::evaluate):
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle):
- 6:13 PM Changeset in webkit [145452] by
-
- 18 edits3 copies in trunk/Source
[Chromium] Move WebFileSystemCallbacks to Platform/
https://bugs.webkit.org/show_bug.cgi?id=112049
Reviewed by Adam Barth.
In preparation for moving filesystem-related methods from
WebFrameClient to Platform.
Source/Platform:
- Platform.gypi:
- chromium/public/WebFileError.h: Copied from Source/WebKit/chromium/public/WebFileError.h.
(WebKit):
- chromium/public/WebFileSystemCallbacks.h: Copied from Source/WebKit/chromium/public/WebFileSystemCallbacks.h.
(WebKit):
(WebFileSystemCallbacks):
(WebKit::WebFileSystemCallbacks::didCreateSnapshotFile):
(WebKit::WebFileSystemCallbacks::~WebFileSystemCallbacks):
- chromium/public/WebFileSystemEntry.h: Copied from Source/WebKit/chromium/public/WebFileSystemEntry.h.
(WebKit):
(WebKit::WebFileSystemEntry::WebFileSystemEntry):
(WebFileSystemEntry):
Source/WebKit/chromium:
- WebKit.gyp:
- public/WebFileError.h:
- public/WebFileSystemCallbacks.h:
- public/WebFileSystemEntry.h:
- public/WebFileWriterClient.h:
- src/AssertMatchingEnums.cpp:
- src/AsyncFileWriterChromium.h:
- src/LocalFileSystemChromium.cpp:
- src/WebFileSystemCallbacksImpl.cpp:
- src/WebFileSystemCallbacksImpl.h:
- src/WebSharedWorkerImpl.cpp:
- src/WebWorkerClientImpl.cpp:
- src/WorkerFileSystemCallbacksBridge.cpp:
- src/WorkerFileSystemCallbacksBridge.h:
- src/WorkerFileWriterCallbacksBridge.h:
- 6:12 PM Changeset in webkit [145451] by
-
- 3 edits2 adds in trunk
Ruby text is incorrectly positioned when its writing-mode is changed to vertical after layout is done
https://bugs.webkit.org/show_bug.cgi?id=96592
Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-03-11
Reviewed by Hajime Morrita.
Source/WebCore:
Fixed logical left of RenderRubyText is not cleared.
This causes trouble when RenderRubyTest is laid out vertically after horizontally.
Horizontal layout set logical top(== y).
Vertical layout don't set logical left(== y).
RenderRubyText::y remain old one.
We clear old RenderRubyText::y at the first part of layout().
Test: fast/writing-mode/ruby-text-logical-left.html
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::layout): Reset logicalLeft not to reuse old one.
LayoutTests:
- fast/writing-mode/ruby-text-logical-left-expected.html: Added.
- fast/writing-mode/ruby-text-logical-left.html: Added.
- 6:10 PM Changeset in webkit [145450] by
-
- 16 edits3 adds in trunk
[css3-text] Add partial parsing support for text-underline-position property from CSS3 Text
https://bugs.webkit.org/show_bug.cgi?id=102491
Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-03-11
Reviewed by Julien Chaffraix.
Source/WebCore:
This patch extends the existing parsing to support 'auto', 'alphabetic' and 'under'. We don't fully match
the specification as we don't support [ left | right ] and this is left for another implementation
as the rendering will need to be added.
Test: fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTextUnderlinePosition):
- css/CSSParser.h:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextUnderlinePosition):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
Added parsing-related checks for text-underline-position property.
- css/CSSPropertyNames.in: Added '-webkit-underline-position' property.
- css/CSSValueKeywords.in:
- css/SVGCSSValueKeywords.in:
- css/StyleBuilder.cpp:
(ApplyPropertyTextUnderlinePosition):
(WebCore::ApplyPropertyTextUnderlinePosition::applyValue):
(WebCore::ApplyPropertyTextUnderlinePosition::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
Set property handler for text-underline-position.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
Added support for m_textUnderlinePosition on copy constructor and operator
assignment functions.
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData): Added m_textUnderlinePosition here as it won't be used regularly.
LayoutTests:
Added getComputedStyle layout tests for 'text-underline-position' CSS3
property, with 'webkit' prefix.
- fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt: Added.
- fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position.html: Added.
- fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js: Added.
(testElementStyle):
(testComputedStyle):
- 6:10 PM Changeset in webkit [145449] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 142631
BUG=175343
Review URL: https://codereview.chromium.org/12543029
- 6:08 PM Changeset in webkit [145448] by
-
- 4 edits in trunk
Hit testing should use ancestorInThisScope to get the non-shadow ancestor
https://bugs.webkit.org/show_bug.cgi?id=112068
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-11
Reviewed by Dimitri Glazkov.
Source/WebCore:
Tests: media/nodesFromRect-shadowContent.html
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::setToNonShadowAncestor):
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
Use ancestorInThisScope which is not deprecated and which produces
correct results for nested shadow trees (e.g. in case of <video>,
which contains <input> elements for the controls, which themselves
have shadow trees)
LayoutTests:
- media/nodesFromRect-shadowContent.html: Extend the hit testing rect
to guarantee reaching a nested shadow tree.
- 6:07 PM Changeset in webkit [145447] by
-
- 6 edits in trunk/Tools
Dashboard cleanup: Create ui.Errors
https://bugs.webkit.org/show_bug.cgi?id=111785
Reviewed by Ojan Vafai.
Create ui.Errors for handling errors the dashboards
encounter. Loader now has a Error object that it can add to,
and individual dashboards can show errors when desired.
Currently, only flakiness_db shows errors, but this is
generic and there is no reason why other dbs wouldn't want to
show errors.
- TestResultServer/static-dashboards/dashboard_base.js:
(resourceLoadingComplete):
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(generatePage):
- TestResultServer/static-dashboards/loader.js:
(.):
- TestResultServer/static-dashboards/ui.js:
(.):
- 6:05 PM Changeset in webkit [145446] by
-
- 12 edits in branches/chromium/1410/Source/WebCore
Merge 143840
BUG=173050
Review URL: https://codereview.chromium.org/12518022
- 5:53 PM Changeset in webkit [145445] by
-
- 3 edits8 copies3 adds in trunk/LayoutTests
More chromium layer tree rebaselines for r145422
- platform/chromium-mac-lion/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt.
- platform/chromium-mac-lion/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt.
- platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt.
- platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt.
- platform/chromium-mac/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt.
- platform/chromium-mac/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt.
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt.
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt.
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- 5:50 PM Changeset in webkit [145444] by
-
- 22 edits in trunk/Source
Replace static_cast with to* helper functions.
https://bugs.webkit.org/show_bug.cgi?id=112045
Reviewed by Eric Seidel.
Source/WebCore:
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::removeMethodCustom):
(WebCore::V8HTMLOptionsCollection::indexedPropertySetter):
- bindings/v8/custom/V8NamedNodesCollection.cpp:
(WebCore::V8NamedNodesCollection::namedItem):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::wrap):
- editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::insertNodeAt):
(WebCore::CompositeEditCommand::pushAnchorElementDown):
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
(WebCore::CompositeEditCommand::splitTreeToNode):
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage):
- platform/mac/HTMLConverter.mm:
(+[WebHTMLConverter editingAttributedStringFromRange:]):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameContentsCompositor):
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::plugInImageElement):
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateFromElement):
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::idChanged):
Source/WebKit/chromium:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::findChildByExpression):
(WebKit::WebFrameImpl::fromFrameOwnerElement):
- src/WebHelperPluginImpl.cpp:
(WebKit::WebHelperPluginImpl::getPlugin):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::create):
- src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
(WebKit::WebPageSerializerImpl::endTagToString):
(WebKit::WebPageSerializerImpl::buildContentForNode):
(WebKit::WebPageSerializerImpl::collectTargetFrames):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::autocompleteHandleKeyEvent):
(WebKit::WebViewImpl::enterFullScreenForElement):
Source/WebKit/mac:
- WebView/WebRenderLayer.mm:
(+[WebRenderLayer nameForLayer:]):
- 5:48 PM Changeset in webkit [145443] by
-
- 2 edits1 copy in branches/chromium/1410
Merge 142760
BUG=172993
Review URL: https://codereview.chromium.org/12558011
- 5:45 PM Changeset in webkit [145442] by
-
- 10 edits2 copies in trunk/Source
[chromium] Use SkMatrix44 instead of WebTransformationMatrix in animation APIs
https://bugs.webkit.org/show_bug.cgi?id=111791
Patch by James Robinson <jamesr@chromium.org> on 2013-03-11
Reviewed by Adrienne Walker.
Source/Platform:
This adds SkMatrix44 overrides for animation APIs that deal with matrices and slims the interface
down for WebTransformationMatrix to the minimum needed to compile. With this patch, there are no
live codepaths that use WebTransformationMatrix but some downstream code still needs a type and a
few functions to compile. After the downstream code is patched this type can go away completely.
- chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
- chromium/public/WebTransformAnimationCurve.h:
(WebTransformAnimationCurve):
- chromium/public/WebTransformOperations.h:
(WebTransformOperations):
- chromium/public/WebTransformationMatrix.h:
(WebTransformationMatrix):
Source/WebCore:
Adds a new utility function to convert a TransformationMatrix to an SkMatrix44 and
uses it in AnimationTranslationUtil and GraphicsLayerChromium.
- WebCore.gypi:
- platform/chromium/support/WebTransformationMatrix.cpp:
(WebKit::WebTransformationMatrix::WebTransformationMatrix):
- platform/graphics/chromium/AnimationTranslationUtil.cpp:
(WebCore::toWebTransformOperations):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
- platform/graphics/chromium/TransformSkMatrix44Conversions.cpp:
(WebCore::TransformSkMatrix44Conversions::convert):
- platform/graphics/chromium/TransformSkMatrix44Conversions.h:
(TransformSkMatrix44Conversions):
- 5:16 PM Changeset in webkit [145441] by
-
- 11 edits in trunk/Source
Unreviewed, rolling out r145435.
http://trac.webkit.org/changeset/145435
https://bugs.webkit.org/show_bug.cgi?id=112082
Still does not compile (Requested by jamesr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-11
Source/WebCore:
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::getObjectStores):
(WebCore::IDBBackingStore::createObjectStore):
(WebCore::IDBBackingStore::deleteObjectStore):
(WebCore::IDBBackingStore::getRecord):
(WebCore::IDBBackingStore::putRecord):
(WebCore::IDBBackingStore::clearObjectStore):
(WebCore::IDBBackingStore::deleteRecord):
(WebCore::IDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBBackingStore::getIndexes):
(WebCore::IDBBackingStore::createIndex):
(WebCore::IDBBackingStore::deleteIndex):
(WebCore::IDBBackingStore::putIndexDataForRecord):
(WebCore::IDBBackingStore::findKeyInIndex):
(WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStore::keyExistsInIndex):
(WebCore::indexCursorOptions):
- Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexOperation::DeleteIndexOperation):
(DeleteIndexOperation):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::deleteIndex):
(WebCore::DeleteIndexOperation::perform):
(WebCore::DeleteRangeOperation::perform):
(WebCore::ClearOperation::perform):
- Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
(WebCore::IDBLevelDBCoding::KeyPrefix::encode):
(WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
(WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
(WebCore::IDBLevelDBCoding::DataVersionKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
- Modules/indexeddb/IDBLevelDBCoding.h:
(IDBLevelDBCoding):
(KeyPrefix):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::IndexWriter::writeIndexKeys):
Source/WebKit/chromium:
- tests/IDBBackingStoreTest.cpp:
(WebCore::IDBBackingStoreTest::SetUp):
(IDBBackingStoreTest):
(WebCore::TEST_F):
- tests/IDBFakeBackingStore.h:
- tests/IDBLevelDBCodingTest.cpp:
(IDBLevelDBCoding):
(IDBLevelDBCoding::TEST):
- 5:15 PM Changeset in webkit [145440] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 5:14 PM Changeset in webkit [145439] by
-
- 1 copy in tags/Safari-536.29.8
New Tag.
- 5:12 PM Changeset in webkit [145438] by
-
- 5 edits in branches/safari-534.59-branch/Source
Versioning.
- 5:09 PM Changeset in webkit [145437] by
-
- 1 copy in tags/Safari-534.59.4
New Tag.
- 5:07 PM Changeset in webkit [145436] by
-
- 33 edits1 copy7 adds in trunk/LayoutTests
First (of probably many) layer tree rebaselines for r145422
- platform/chromium-linux-x86/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/composited-scrolling-paint-phases-expected.txt.
- platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt:
- platform/chromium-linux/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/chromium-linux/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/chromium-linux/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/chromium-linux/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/chromium-linux/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/chromium-linux/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/chromium-linux/compositing/iframes/iframe-resize-expected.txt:
- platform/chromium-linux/compositing/iframes/iframe-size-from-zero-expected.txt:
- platform/chromium-linux/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/chromium-linux/compositing/iframes/overlapped-iframe-expected.txt:
- platform/chromium-linux/compositing/iframes/resizer-expected.txt:
- platform/chromium-linux/compositing/iframes/scrolling-iframe-expected.txt:
- platform/chromium-linux/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Added.
- platform/chromium-linux/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Added.
- platform/chromium-linux/compositing/overflow/composited-scrolling-paint-phases-expected.txt:
- platform/chromium-linux/compositing/overflow/textarea-scroll-touch-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/become-overlapped-iframe-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/composited-parent-iframe-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/enter-compositing-iframe-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/iframe-resize-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/iframe-size-from-zero-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/overlapped-iframe-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/resizer-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/scrolling-iframe-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt:
- 4:57 PM Changeset in webkit [145435] by
-
- 11 edits in trunk/Source
IndexedDB: Protect against key prefix overflows
https://bugs.webkit.org/show_bug.cgi?id=111138
Reviewed by Tony Chang.
Source/WebCore:
This reworks the boundary checking for all databaseId,
objectStoreId, and indexId, including negative and
zero-based ids. All entrypoints into IDBLevelDBCoding
are protected with explicit checks and all internal
uses of KeyPrefix are protected with ASSERTs in the
various constructors.
Tests: WebKit unit tests IDBBackingStoreTest.cpp in WebKit/chromium
- Modules/indexeddb/IDBBackingStore.h: Make all public methods boolean-based for errors.
- Modules/indexeddb/IDBLevelDBCoding.h: Add methods for checking databaseId, objectStoreId, and indexId.
Source/WebKit/chromium:
Add tests for invalid indexIds in basic get/put operations.
- 4:54 PM Changeset in webkit [145434] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/css/RuleSet.h
Merge 145034 "Make RuleData support up to 8191 selectors"
Make RuleData support up to 8191 selectors
https://bugs.webkit.org/show_bug.cgi?id=111663
Patch by Philippe Liard <pliard@chromium.org> on 2013-03-06
Reviewed by Andreas Kling.
r125294 made RuleData consume less memory by replacing a pointer with
an index encoded on 12 bits.
This unfortunately breaks Chrome for Android (and others) when a lot of
CSS is used or more precisely when selectorIndex cannot be stored on 12
bits.
Threfore this change decreases the number of bits used to store
m_position by 1 (from 19 to 18) and adds this extra bit to
m_selectorIndex so that values up to 8191 can be stored safely without
overflowing.
- css/RuleSet.h:
(RuleData):
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12755018
- 4:48 PM Changeset in webkit [145433] by
-
- 16 edits in trunk/Source/WebCore
Replace static_cast<SVGStyledElement> with toSVGStyledElement()
https://bugs.webkit.org/show_bug.cgi?id=111651
Reviewed by Abhishek Arya.
toSVGStyledElement is preferred over static_cast<SVGStyledElement*> because bad casts
can be caught on our testing infrastructure. This patch replaces all
static_cast<SVGStyledElement> instances with toSVGStyledElement.
Additionally, this patch renames SVGElement::isStyled to SVGElement::isSVGStyledElement to
remove a confusing overlap with html styled elements. This name differs slighly from the
other is*() functions in SVGElement but this will be resolved up with webkit.org/b/107386.
No new tests as this is covered with existing tests.
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::getElementCTM):
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
(WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect):
(WebCore::RenderSVGResourceClipper::hitTestClipContent):
- rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
(WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect):
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::createTileImage):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::layoutChildren):
- rendering/svg/SVGResources.cpp:
(WebCore::registerPendingResource):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::isTargetAttributeCSSProperty):
(WebCore::SVGAnimationElement::computeCSSPropertyValue):
(WebCore::SVGAnimationElement::adjustForInheritance):
(WebCore::inheritsFromProperty):
- svg/SVGElement.cpp:
(WebCore::collectInstancesForSVGElement):
(WebCore::SVGElement::isAnimatableAttribute):
- svg/SVGElement.h:
(WebCore::SVGElement::isSVGStyledElement):
- svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
(WebCore::SVGElementInstance::InstanceUpdateBlocker::InstanceUpdateBlocker):
- svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::computeCTM):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::updateRelativeLengthsInformation):
- svg/SVGStyledElement.h:
(WebCore::SVGStyledElement::isSVGStyledElement):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::selfHasRelativeLengths):
- svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::platformApplySoftware):
- 4:47 PM Changeset in webkit [145432] by
-
- 6 edits in trunk/Source
PDFPlugin: Make scrolling between pages in non-continuous modes work
https://bugs.webkit.org/show_bug.cgi?id=111415
<rdar://problem/12555320>
Reviewed by Alexey Proskuryakov.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h:
Add some more PDFLayerController SPI.
- WebProcess/Plugins/PDF/PDFPlugin.h:
(PDFPlugin): Override handleWheelEvent.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::handleWheelEvent):
If PDFLayerController is in non-continuous mode, allow scrolling between
pages by intercepting scroll events, and checking whether we're at the
top or bottom of a page. If we are, and a single event exceeds the threshold
of 20px (0px for legacy scroll wheels), we jump to the next or previous
page and scroll to the right place. Do not allow momentum scrolling to
switch pages.
- WebCore.exp.in: Export ScrollableArea::scrollToOffsetWithoutAnimation.
- 4:44 PM Changeset in webkit [145431] by
-
- 3 edits in trunk/Source/WebCore
Remove the use of the quotaMap cache in DatabaseTracker.
https://bugs.webkit.org/show_bug.cgi?id=111805.
Reviewed by Geoffrey Garen.
This change is needed because using the quotaMap cache can result in
an inaccurate read (in a multi-process system) on what database files
are actually present on the filesystem. Instead of using the quotaMap
cache, we rely on the tracker database and query it every time we need
the origin/quota information.
No new tests.
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::hasAdequateQuotaForOrigin):
(WebCore::DatabaseTracker::hasEntryForOriginNoLock):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::quotaForOriginNoLock):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::addDatabase):
(WebCore::DatabaseTracker::deleteOrigin):
- Modules/webdatabase/DatabaseTracker.h:
- 4:40 PM Changeset in webkit [145430] by
-
- 4 edits1 copy in branches/chromium/1410
Merge 144522 "Don't leak Documents when using MutationObserver f..."
Don't leak Documents when using MutationObserver from extensions
https://bugs.webkit.org/show_bug.cgi?id=111234
Patch by Elliott Sprehn <Elliott Sprehn> on 2013-03-01
Reviewed by Adam Barth.
.:
- ManualTests/leak-observer-nonmain-world.html: Added.
Source/WebCore:
MutationObserverCallback holds a WorldContextHandle which secretly isn't
a handle to anything when it's for the main world. When it's for a non-main
world though, like those used in extensions, it becomes a strong reference
to the v8::Context which results in leaks by creating cycles:
MutationObserver -> Callback -> World -> Document -> Node -> MutationObserver.
Instead we should keep a RefPtr to a DOMWrapperWorld in the callback and then
get the v8::Context from that inside handleEvent.
Tests: ManualTests/leak-observer-nonmain-world.html
- bindings/v8/V8Binding.cpp:
(WebCore::toV8Context): Added overload that takes a DOMWrapperWorld.
- bindings/v8/V8Binding.h:
- bindings/v8/V8MutationCallback.cpp:
(WebCore::V8MutationCallback::V8MutationCallback):
(WebCore::V8MutationCallback::handleEvent):
- bindings/v8/V8MutationCallback.h:
(V8MutationCallback):
- 4:40 PM Changeset in webkit [145429] by
-
- 3 edits in trunk/LayoutTests
De-flake fast/dom/title-directionality.html
https://bugs.webkit.org/show_bug.cgi?id=112075
Reviewed by Adam Barth.
This moves the test logic from an inline script to an onload handler. Otherwise, the whitespace collapsing logic
creates a race between the style recalc timer and the HTML parser which sometimes produces an extra newline at
the end of the text output.
- fast/dom/title-directionality-expected.txt:
- fast/dom/title-directionality.html:
- 4:40 PM Changeset in webkit [145428] by
-
- 2 edits in trunk/Source/WebCore
Don't rely on the fact that StaticPosition happens to be defined as 0
https://bugs.webkit.org/show_bug.cgi?id=110123
Also made the expression slightly less convoluted.
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-03-11
Reviewed by Alexey Proskuryakov.
No new tests. This is just code cleanup.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
- 4:39 PM Changeset in webkit [145427] by
-
- 2 edits in trunk
[Autotools] Set ENABLE_GTK_DOC to false if gtk-doc is not installed
https://bugs.webkit.org/show_bug.cgi?id=111980
Patch by Tobias Mueller <tobiasmue@gnome.org> on 2013-03-11
Reviewed by Martin Robinson.
WebKit did not configure if gtk-doc-am was not installed with the error:
Tools/GNUmakefile.am:419: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
- Source/autotools/FindDependencies.m4:
- 4:36 PM Changeset in webkit [145426] by
-
- 3 edits in trunk/Source/WebKit2
Fix some WebDatabaseManagerProxy methods to only send to one WebProcsess
instead of broadcasting to all WebProcesses.
https://bugs.webkit.org/show_bug.cgi?id=112074.
Reviewed by Alexey Proskuryakov.
The reason for this is because the intent of these messages is to act on
the tracker database that is shared between all WebProcesses. It is
redundant and inefficient for multiple WebProcesses to service the same
request/message. And because of multi-process contention on accessing
the tracker database, the results returned to the UIProcess may also be
erroneous.
For example, if getDatabaseOrigins() is broadcasted to all WebProcesses,
they will contend to open the tracker database at the same time. If one
of these processes fails because the database is already in use, then
it may return with an empty list when it should not be empty.
With this fix, only one WebProcess gets the message and will perform the
requested query/action on behalf of all WebProcesses.
- UIProcess/WebContext.h:
(WebKit::WebContext::sendToOneProcess):
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteAllDatabases):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
- 4:25 PM Changeset in webkit [145425] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed attempt to fix build after http://trac.webkit.org/changeset/145421.
- html/HTMLPlugInImageElement.cpp:
- 4:20 PM Changeset in webkit [145424] by
-
- 6 edits4 adds in trunk
Intrinsic width keyword values don't work for tables
https://bugs.webkit.org/show_bug.cgi?id=111515
Reviewed by Julien Chaffraix.
Source/WebCore:
Tests: fast/css-intrinsic-dimensions/css-tables.html
fast/css-intrinsic-dimensions/tables.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeIntrinsicLogicalWidthUsing):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
- rendering/RenderBox.h:
Pass in the border and padding as an argument since RenderTable needs
to pass in a different value. Unfortunately, the math doesn't work out right
in the positioned/replaced cases if we just pass 0. We need to pass in the correct
border and padding and then subtract it from the result.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::updateLogicalWidth):
Compute intrinsic widths as well as specified ones. Down the road
we may want to consider having intrinsic width values return true for
isSpecified.
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
Compute intrinsic widths as well.
(WebCore::RenderTable::computeIntrinsicLogicalWidths):
Implement this method so that the RenderBox::computeIntrinsicLogicalWidthUsing
gets the right intrinsic values instead of the preferred values.
(WebCore::RenderTable::computePreferredLogicalWidths):
- rendering/RenderTable.h:
LayoutTests:
- fast/css-intrinsic-dimensions/css-tables-expected.txt: Added.
- fast/css-intrinsic-dimensions/css-tables.html: Added.
- fast/css-intrinsic-dimensions/tables-expected.txt: Added.
- fast/css-intrinsic-dimensions/tables.html: Added.
- 4:18 PM Changeset in webkit [145423] by
-
- 8 edits2 adds in trunk
HTMLInputElement can delete an ImageLoader while it's still needed
https://bugs.webkit.org/show_bug.cgi?id=110621
Reviewed by Darin Adler.
Source/WebCore:
ImageLoader objects may fire events for HTMLInputElements that are of
type ImageInputType that own the loader. These events may cause script
to run that changes the type of the input element and hence causes the
ImageLoader to be deleted, while the image loader is still processing
the event dispatch. Bad things ensue.
This change moves ownership of the ImageLoader from the ImageInputType
onto the HTMLImageElement which is already protected from deletion during
event processing.
Test: fast/forms/image/image-error-event-modifies-type-crash.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::imageLoader): Method to return the
ImageLoader, creating it if not already created.
- html/HTMLInputElement.h:
(WebCore::HTMLInputElement::hasImageLoader): Return true if the
ImageLoader has been created.
(HTMLInputElement): Define ImageLoader access methods and the OwnPtr
for the HTMLImageLoader.
- html/ImageInputType.cpp:
(WebCore::ImageInputType::srcAttributeChanged): Use the element's ImageLoader.
(WebCore::ImageInputType::attach): Use the element's ImageLoader.
(WebCore::ImageInputType::willMoveToNewOwnerDocument): Use the element's ImageLoader.
(WebCore::ImageInputType::height): Use the element's ImageLoader.
(WebCore::ImageInputType::width): Use the element's ImageLoader.
- html/ImageInputType.h:
(ImageInputType): Remove the declaration of the ImageLoader.
LayoutTests:
- fast/forms/image/image-error-event-modifies-type-crash-expected.txt: Added.
- fast/forms/image/image-error-event-modifies-type-crash.html: Added.
- 4:02 PM WebKitGTK/2.0.x edited by
- (diff)
- 3:59 PM Changeset in webkit [145422] by
-
- 303 edits8 deletes in trunk
Revert "Mark GraphicsLayers as opaque when possible"
This reverts commit 0a4d3c2d8a0373aa9e5bd9209885137a13a7f0e0.
REGRESSION (r143626): http://chainlove.com shows garbage tiles on Mac
https://bugs.webkit.org/show_bug.cgi?id=112043
Unreviewed, rolling out r143626.
Source/WebCore:
- rendering/RenderBox.cpp:
- rendering/RenderBox.h:
(RenderBox):
- rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
- rendering/RenderLayer.cpp:
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderLayerModelObject.h:
(RenderLayerModelObject):
LayoutTests:
- compositing/absolute-inside-out-of-view-fixed-expected.txt:
- compositing/backing/no-backing-for-clip-expected.txt:
- compositing/backing/no-backing-for-clip-overlap-expected.txt:
- compositing/backing/no-backing-for-perspective-expected.txt:
- compositing/clip-child-by-non-stacking-ancestor-expected.txt:
- compositing/columns/composited-in-paginated-expected.txt:
- compositing/contents-opaque/contents-opaque-background-clip-expected.txt: Removed.
- compositing/contents-opaque/contents-opaque-background-clip.html: Removed.
- compositing/contents-opaque/contents-opaque-background-color-expected.txt: Removed.
- compositing/contents-opaque/contents-opaque-background-color.html: Removed.
- compositing/contents-opaque/contents-opaque-layer-opacity-expected.txt: Removed.
- compositing/contents-opaque/contents-opaque-layer-opacity.html: Removed.
- compositing/contents-opaque/contents-opaque-layer-transform-expected.txt: Removed.
- compositing/contents-opaque/contents-opaque-layer-transform.html: Removed.
- compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt:
- compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- compositing/geometry/bounds-ignores-hidden-expected.txt:
- compositing/geometry/clip-expected.txt:
- compositing/geometry/clip-inside-expected.txt:
- compositing/geometry/fixed-position-composited-switch-expected.txt:
- compositing/geometry/flipped-writing-mode-expected.txt:
- compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
- compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
- compositing/geometry/limit-layer-bounds-fixed-expected.txt:
- compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
- compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- compositing/geometry/limit-layer-bounds-positioned-expected.txt:
- compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
- compositing/geometry/limit-layer-bounds-transformed-expected.txt:
- compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
- compositing/geometry/preserve-3d-switching-expected.txt:
- compositing/iframes/become-composited-nested-iframes-expected.txt:
- compositing/iframes/become-overlapped-iframe-expected.txt:
- compositing/iframes/composited-parent-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- compositing/iframes/connect-compositing-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe2-expected.txt:
- compositing/iframes/connect-compositing-iframe3-expected.txt:
- compositing/iframes/enter-compositing-iframe-expected.txt:
- compositing/iframes/iframe-resize-expected.txt:
- compositing/iframes/invisible-nested-iframe-hide-expected.txt:
- compositing/iframes/invisible-nested-iframe-show-expected.txt:
- compositing/iframes/overlapped-iframe-expected.txt:
- compositing/iframes/overlapped-iframe-iframe-expected.txt:
- compositing/iframes/overlapped-nested-iframes-expected.txt:
- compositing/iframes/page-cache-layer-tree-expected.txt:
- compositing/iframes/scrolling-iframe-expected.txt:
- compositing/layer-creation/animation-overlap-with-children-expected.txt:
- compositing/layer-creation/fixed-position-and-transform-expected.txt:
- compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- compositing/layer-creation/fixed-position-under-transform-expected.txt:
- compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- compositing/layer-creation/overflow-scroll-overlap-expected.txt:
- compositing/layer-creation/overlap-animation-clipping-expected.txt:
- compositing/layer-creation/overlap-animation-expected.txt:
- compositing/layer-creation/overlap-child-layer-expected.txt:
- compositing/layer-creation/overlap-clipping-expected.txt:
- compositing/layer-creation/overlap-transformed-3d-expected.txt:
- compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
- compositing/layer-creation/overlap-transformed-layer-expected.txt:
- compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
- compositing/layer-creation/overlap-transforms-expected.txt:
- compositing/layer-creation/spanOverlapsCanvas-expected.txt:
- compositing/layer-creation/stacking-context-overlap-expected.txt:
- compositing/layer-creation/translatez-overlap-expected.txt:
- compositing/masks/mask-layer-size-expected.txt:
- compositing/overflow-trumps-transform-style-expected.txt:
- compositing/overflow/clip-descendents-expected.txt:
- compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- compositing/overflow/textarea-scroll-touch-expected.txt:
- compositing/plugins/no-backing-store-expected.txt:
- compositing/repaint/invalidations-on-composited-layers-expected.txt:
- compositing/rtl/rtl-absolute-expected.txt:
- compositing/rtl/rtl-absolute-overflow-expected.txt:
- compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-fixed-expected.txt:
- compositing/rtl/rtl-fixed-overflow-expected.txt:
- compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-iframe-absolute-expected.txt:
- compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
- compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-iframe-fixed-expected.txt:
- compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
- compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-iframe-relative-expected.txt:
- compositing/rtl/rtl-relative-expected.txt:
- compositing/tiled-layers-hidpi-expected.txt:
- compositing/tiling/backface-preserve-3d-tiled-expected.txt:
- compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- compositing/tiling/huge-layer-add-remove-child-expected.txt:
- compositing/tiling/huge-layer-with-layer-children-expected.txt:
- compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- compositing/tiling/rotated-tiled-clamped-expected.txt:
- compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- compositing/tiling/tile-cache-zoomed-expected.txt:
- compositing/tiling/tiled-layer-resize-expected.txt:
- compositing/visible-rect/2d-transformed-expected.txt:
- compositing/visible-rect/3d-transform-style-expected.txt:
- compositing/visible-rect/3d-transformed-expected.txt:
- compositing/visible-rect/animated-expected.txt:
- compositing/visible-rect/animated-from-none-expected.txt:
- compositing/visible-rect/clipped-by-viewport-expected.txt:
- compositing/visible-rect/clipped-visible-rect-expected.txt:
- compositing/visible-rect/iframe-and-layers-expected.txt:
- compositing/visible-rect/iframe-no-layers-expected.txt:
- compositing/visible-rect/nested-transform-expected.txt:
- compositing/visible-rect/scrolled-expected.txt:
- css3/filters/filtered-compositing-descendant-expected.txt:
- platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/chromium-mac/compositing/overflow/textarea-scroll-touch-expected.txt:
- platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt:
- platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
- platform/chromium-win/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- platform/chromium-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
- platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/chromium-win/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/backing/no-backing-for-clip-expected.txt:
- platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt:
- platform/chromium/compositing/columns/composited-in-paginated-expected.txt:
- platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium/compositing/geometry/clip-expected.txt:
- platform/chromium/compositing/geometry/clip-inside-expected.txt:
- platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt:
- platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt:
- platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
- platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/chromium/compositing/iframes/become-composited-nested-iframes-expected.txt:
- platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
- platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/chromium/compositing/iframes/iframe-resize-expected.txt:
- platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
- platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt:
- platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
- platform/chromium/compositing/iframes/overlapped-iframe-iframe-expected.txt:
- platform/chromium/compositing/iframes/overlapped-nested-iframes-expected.txt:
- platform/chromium/compositing/iframes/resizer-expected.txt:
- platform/chromium/compositing/iframes/scrolling-iframe-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt:
- platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-animation-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-3d-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
- platform/chromium/compositing/layer-creation/spanOverlapsCanvas-expected.txt:
- platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt:
- platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt:
- platform/chromium/compositing/overflow-trumps-transform-style-expected.txt:
- platform/chromium/compositing/overflow/clip-descendents-expected.txt:
- platform/chromium/compositing/rtl/rtl-absolute-expected.txt:
- platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt:
- platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
- platform/chromium/compositing/rtl/rtl-fixed-expected.txt:
- platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/chromium/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium/compositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium/compositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium/compositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium/compositing/rtl/rtl-relative-expected.txt:
- platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- platform/efl/TestExpectations:
- platform/efl/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
- platform/mac/compositing/iframes/resizer-expected.txt:
- platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt:
- platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
- platform/mac/compositing/tiling/tiled-layer-resize-expected.txt:
- platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
- platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
- platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/qt/TestExpectations:
- platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
- platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
- platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/qt/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/qt/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
- platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- 3:51 PM Changeset in webkit [145421] by
-
- 6 edits in trunk/Source/WebCore
Plugins created during user gestures (or soon after) should not be snapshotted
https://bugs.webkit.org/show_bug.cgi?id=111975
Reviewed by Tim Horton.
There are sites which create plugins in response to user actions, such as clicking
on an image that is acting like a poster frame. In those cases we should never snapshot.
There are some other sites which also create plugins in response to user actions,
but don't necessarily create the content themselves. Instead they run some script
that injects an iframe, and the frame loads a plugin. In order to make sure we don't
snapshot in those cases, we're adding the concept of a blessed plugin. Anything that
is created soon after a *handled* user gesture is not snapshotted. To do this we
mark a timestamp in the document when we've called an event listener for a user
gesture. The plugin element then compares its creation time with the most recent
user action time.
- dom/Document.cpp:
(WebCore::Document::Document): Initialise new timestamp.
(WebCore::Document::resetLastHandledUserGestureTimestamp): Sets the member variable
to the current time.
- dom/Document.h:
(WebCore::Document::lastHandledUserGestureTimestamp): Getter.
- dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners): If there were some event listeners and
we were processing a user gesture, then reset the timestamp in the document.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Remember if we were created
during a user gesture.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Start the plugin
if we were created during a user gesture, or if we are close enough in time
to a listener that fired in relation to a user gesture.
- html/HTMLPlugInImageElement.h: New private member flag indicating if we were
in a user gesture when constructed.
- 3:45 PM Changeset in webkit [145420] by
-
- 2 edits in trunk/Source/WTF
Unreviewed build fix. Rolling out inadvertent setting of DATA_LOG_TO_FILE.
- 3:38 PM Changeset in webkit [145419] by
-
- 4 edits in trunk/Source
List cache partitions as units instead of as their contents
https://bugs.webkit.org/show_bug.cgi?id=111909
Reviewed by Maciej Stachowiak.
Source/WebCore:
Not possible to test with current automated test tools, must be tested manually.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::getOriginsWithCache): List a cache item as a member of a partition, if possible
Source/WebKit2:
- WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
(WebKit::WebResourceCacheManager::cfURLCacheHostNames): Attempt to enumerate cache partitions based on information we have
- 3:37 PM Changeset in webkit [145418] by
-
- 4 edits2 adds in trunk/LayoutTests
Update chromium render tree baselines for track cue changes in r145397.
- platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Added.
- platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Added.
- platform/chromium-mac-lion/media/track/track-cue-rendering-vertical-expected.txt:
- platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt:
- platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.txt:
- 3:36 PM Changeset in webkit [145417] by
-
- 3 edits in trunk/Source
Crash beneath operationCreateInlinedArguments running fast/js/dfg-create-inlined-arguments-in-closure-inline.html (32-bit only)
https://bugs.webkit.org/show_bug.cgi?id=112067
Reviewed by Geoffrey Garen.
We weren't setting the tag in SetCallee. Therefore set it to CellTag.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 3:32 PM Changeset in webkit [145416] by
-
- 2 edits in trunk/Source/WebCore
Chromium build fix. Forked files strike again.
- platform/network/chromium/ResourceHandle.cpp: (WebCore::ResourceHandle::firstRequest):
- 3:25 PM Changeset in webkit [145415] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Add a method to find the ScrollView for a text selection.
https://bugs.webkit.org/show_bug.cgi?id=112061
Patch by Genevieve Mak <gmak@rim.com> on 2013-03-11
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton and Jakob Petsovits.
PR #278490
Refactor the code in InRegionScroller so that we can add a method to find
the InRegionScrollableArea for a text selection.
- Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::clipToRect):
- Pull out recursive clipping code into its own function.
(WebKit):
(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
(BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
- This new method allows us to get just the first scrollable region instead of looking for more nested ones. We may want to refactor in the future because some of the code is very similar to calculateInRegionScrollableAreasForPoint.
(BlackBerry::WebKit::InRegionScrollerPrivate::clipAndCreateInRegionScrollableArea):
- Add a convenience method for the previous function
- Api/InRegionScroller.h:
(WebKit):
- Api/InRegionScroller_p.h:
(InRegionScrollerPrivate):
- 3:22 PM Changeset in webkit [145414] by
-
- 2 edits in trunk/Source/WebKit/mac
Unreviewed build fix. Remove stray brace which crept into r145409.
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController performClose:]):
- 3:18 PM Changeset in webkit [145413] by
-
- 2 edits in trunk/Source/WebCore
Fix typo from r145399. Rubber stamped by Abhishek Arya.
- rendering/svg/RenderSVGViewportContainer.h:
(WebCore::toRenderSVGViewportContainer):
- 3:15 PM Changeset in webkit [145412] by
-
- 2 edits in trunk/Tools
Some StringHasher tests are broken because of missing null termination
https://bugs.webkit.org/show_bug.cgi?id=111284
Reviewed by Darin Adler.
- TestWebKitAPI/Tests/WTF/StringHasher.cpp:
(TestWebKitAPI): Added null termination since C strings are null-terminated.
(TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
the bug caught by it is now fixed.
- 3:12 PM Changeset in webkit [145411] by
-
- 9 edits1 copy1 add in trunk/Source/WebCore
[CSS Exclusions] Refactor the ExclusionPolygon class to enable storing multiple boundaries
https://bugs.webkit.org/show_bug.cgi?id=111766
Reviewed by Dirk Schulze.
Refactored the ExclusionPolygon class to enable adding support for shape-margin and shape-padding.
Extracted a new FloatPolygon class which is now used by ExclusionPolygon to represent the shape's
boundary. It will be used to add m_paddedPolygon and m_marginPolygon members to ExclusionPolygon
in a subsequent patch.
No new tests. This is strictly a refactoring of the existing code.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/FloatPolygon.cpp: Factored out of Source/WebCore/rendering/ExclusionPolygon.cpp.
(WebCore::determinant):
(WebCore::areCollinearPoints):
(WebCore::areCoincidentPoints):
(WebCore::isPointOnLineSegment):
(WebCore::nextVertexIndex):
(WebCore::FloatPolygon::FloatPolygon):
(WebCore::FloatPolygon::findNextEdgeVertexIndex):
(WebCore::FloatPolygon::overlappingEdges):
(WebCore::leftSide):
(WebCore::FloatPolygon::contains):
(WebCore::VertexPair::overlapsRect):
(WebCore::VertexPair::intersection):
- platform/graphics/FloatPolygon.h: Factored out of Source/WebCore/rendering/ExclusionPolygon.h.
(FloatPolygon):
(WebCore::FloatPolygon::vertexAt):
(WebCore::FloatPolygon::numberOfVertices):
(WebCore::FloatPolygon::fillRule):
(WebCore::FloatPolygon::edgeAt):
(WebCore::FloatPolygon::numberOfEdges):
(WebCore::FloatPolygon::boundingBox):
(WebCore::FloatPolygon::isEmpty):
(VertexPair):
(WebCore::VertexPair::~VertexPair):
(WebCore::VertexPair::minX):
(WebCore::VertexPair::minY):
(WebCore::VertexPair::maxX):
(WebCore::VertexPair::maxY):
(FloatPolygonEdge):
(WebCore::FloatPolygonEdge::previousEdge):
(WebCore::FloatPolygonEdge::nextEdge):
(WebCore::FloatPolygonEdge::polygon):
(WebCore::FloatPolygonEdge::vertexIndex1):
(WebCore::FloatPolygonEdge::vertexIndex2):
(WebCore::FloatPolygonEdge::edgeIndex):
- rendering/ExclusionPolygon.cpp: Now depends on FloatPolygon.
(EdgeIntersection):
(WebCore::leftSide):
(WebCore::computeXIntersection):
(WebCore::getVertexIntersectionVertices):
(WebCore::computeXIntersections):
(WebCore::computeOverlappingEdgeXProjections):
(WebCore::ExclusionPolygon::getExcludedIntervals):
(WebCore::ExclusionPolygon::getIncludedIntervals):
(WebCore::firstFitRectInPolygon):
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop):
- rendering/ExclusionPolygon.h: Now depends on FloatPolygon.
(WebCore::OffsetPolygonEdge::OffsetPolygonEdge):
(ExclusionPolygon):
(WebCore::ExclusionPolygon::ExclusionPolygon):
- 2:53 PM Changeset in webkit [145410] by
-
- 3 edits in trunk/Source/WebCore
Roll out part of r144671.
ResourceHandle::firstRequest() should not be const(), because it returns a
non-const reference.
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::firstRequest):
- platform/network/ResourceHandle.h:
- 2:51 PM Changeset in webkit [145409] by
-
- 6 edits in trunk/Source
Source/WebCore: Mac: Cmd-w should close full screen window.
https://bugs.webkit.org/show_bug.cgi?id=108406
Reviewed by Darin Adler.
Pass performClose: requests on to the owning window controller.
- platform/mac/WebCoreFullScreenWindow.mm:
(-[WebCoreFullScreenWindow performClose:]):
Source/WebKit/mac: Mac: Cmd-w should close full screen window.
https://bugs.webkit.org/show_bug.cgi?id=108406
Reviewed by Darin Adler.
Allow the user to close the full screen window with Cmd-w by making the full screen window
closable, and by intercepting performClose:.
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController init]): Create a closable full screen window.
(-[WebFullScreenController performClose:]): When we receive a close request in full screen mode,
animate out of full screen.
Source/WebKit2: Full screen mode should not exit when application resigns active state.
https://bugs.webkit.org/show_bug.cgi?id=106129
Reviewed by Darin Adler.
Allow the user to close the full screen window with Cmd-w by making the full screen window
closable, and by intercepting performClose:.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController init]): Create a closable full screen window.
(-[WKFullScreenWindowController performClose:]): When we receive a close request in full screen mode,
animate out of full screen.
- 2:48 PM Changeset in webkit [145408] by
-
- 3 edits1 add12 deletes in trunk/LayoutTests
Modernize the test visited-link-background-color.html
https://bugs.webkit.org/show_bug.cgi?id=111931
Reviewed by Sam Weinig.
Make the test a ref-test instead of a pixel test.
Use Internals' computedStyleIncludingVisitedInfo to make the test reliable
on platforms where the visited link list is updated asynchronously.
- fast/history/visited-link-background-color-expected.html: Copied from LayoutTests/fast/history/visited-link-background-color.html.
- fast/history/visited-link-background-color.html:
- platform/chromium-linux/fast/history/visited-link-background-color-expected.png: Removed.
- platform/chromium-win/fast/history/visited-link-background-color-expected.png: Removed.
- platform/chromium/TestExpectations:
- platform/chromium/fast/history/visited-link-background-color-expected.png: Removed.
- platform/chromium/fast/history/visited-link-background-color-expected.txt: Removed.
- platform/efl-wk1/fast/history/visited-link-background-color-expected.png: Removed.
- platform/efl/fast/history/visited-link-background-color-expected.png: Removed.
- platform/efl/fast/history/visited-link-background-color-expected.txt: Removed.
- platform/gtk/fast/history/visited-link-background-color-expected.png: Removed.
- platform/gtk/fast/history/visited-link-background-color-expected.txt: Removed.
- platform/mac-wk2/fast/history/visited-link-background-color-expected.png: Removed.
- platform/mac-wk2/fast/history/visited-link-background-color-expected.txt: Removed.
- platform/mac/fast/history/visited-link-background-color-expected.png: Removed.
- platform/mac/fast/history/visited-link-background-color-expected.txt: Removed.
- platform/qt/fast/history/visited-link-background-color-expected.png: Removed.
- platform/qt/fast/history/visited-link-background-color-expected.txt: Removed.
- 2:37 PM Changeset in webkit [145407] by
-
- 2 edits in trunk
[GTK] Bump version
https://bugs.webkit.org/show_bug.cgi?id=112055
Reviewed by Martin Robinson.
- Source/autotools/Versions.m4: Bump to 2.1.0
- 2:35 PM Changeset in webkit [145406] by
-
- 10 edits in trunk/Source
[Chromium] chromium/linux breaks expectation of select popup background due to bad UA css rules
https://bugs.webkit.org/show_bug.cgi?id=111873
Patch by Xiyuan Xia <xiyuan@chromium.org> on 2013-03-11
Reviewed by Tony Chang.
Source/WebCore:
On linux the default <select> background color is too dark to use as the
popup background color. Last fixes:
https://bugs.webkit.org/show_bug.cgi?id=54115 and
https://bugs.webkit.org/show_bug.cgi?id=56023
attempt to fix the problem by applying a lighter background using
special <option> selector. This breaks expectations of some websites.
This CL reverts the bad UA css rules above and provides the lighter
background color if <select> and <option> elements are using the default
background.
No new tests, this tests <select> popups and can be verified by ManualTests/select-scroll.html.
- css/themeChromiumLinux.css:
(select):
- platform/PopupMenuStyle.h:
(WebCore::PopupMenuStyle::PopupMenuStyle):
(WebCore::PopupMenuStyle::backgroundColorType):
(PopupMenuStyle):
- platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::paintRow):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemStyle):
(WebCore::RenderMenuList::getItemBackgroundColor):
- rendering/RenderMenuList.h:
(RenderMenuList):
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::menuStyle):
- rendering/RenderThemeChromiumDefault.cpp:
(WebCore::RenderThemeChromiumDefault::systemColor):
Source/WebKit/chromium:
Update PopupMenuStyle constructor call sites.
- src/AutofillPopupMenuClient.cpp:
(WebKit::AutofillPopupMenuClient::initialize):
- 2:26 PM Changeset in webkit [145405] by
-
- 2 edits in trunk/Source/WebCore
Compile fix. Rubber-stamp by Eric Seidel.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
- 2:20 PM Changeset in webkit [145404] by
-
- 2 edits in trunk/Source/WebCore
Fix build for r145397 (part 2)
Unreviewed.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::getDisplayTree):
- 2:06 PM Changeset in webkit [145403] by
-
- 4 edits in trunk/Source/WebCore
Fix build for r145397
Unreviewed.
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::createTextTrackDisplay):
- html/shadow/MediaControlsChromium.cpp:
(WebCore::MediaControlsChromium::createTextTrackDisplay):
- html/shadow/MediaControlsGtk.cpp:
(WebCore::MediaControlsGtk::createTextTrackDisplay):
- 2:03 PM Changeset in webkit [145402] by
-
- 11 edits2 moves3 deletes in trunk/LayoutTests
Unreviewed, rolling out r144818.
http://trac.webkit.org/changeset/144818
https://bugs.webkit.org/show_bug.cgi?id=112062
Preparing to rollout r143626, which broke a few websites on
Mac (Requested by alokp on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-11
- compositing/contents-opaque/contents-opaque-background-color-expected.txt:
- compositing/contents-opaque/contents-opaque-layer-opacity-expected.txt:
- compositing/contents-opaque/contents-opaque-layer-transform-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/contents-opaque/contents-opaque-background-color-expected.txt: Removed.
- platform/chromium/compositing/contents-opaque/contents-opaque-layer-opacity-expected.txt: Removed.
- platform/chromium/compositing/contents-opaque/contents-opaque-layer-transform-expected.txt: Removed.
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Renamed from LayoutTests/platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt.
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Renamed from LayoutTests/platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt.
- platform/efl/TestExpectations:
- platform/efl/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 2:02 PM Changeset in webkit [145401] by
-
- 7 edits in trunk/Source
Make SegmentedVector Noncopyable
https://bugs.webkit.org/show_bug.cgi?id=112059
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Copying a SegmentedVector is very expensive, and really shouldn't
be necessary. So I've taken the one place where we currently copy
and replaced it with a regular Vector, and replaced the address
dependent logic with a indexing ref instead.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::newLabelScope):
(JSC::BytecodeGenerator::emitComplexJumpScopes):
- bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
- bytecompiler/LabelScope.h:
(JSC):
(JSC::LabelScopePtr::LabelScopePtr):
(LabelScopePtr):
(JSC::LabelScopePtr::operator=):
(JSC::LabelScopePtr::~LabelScopePtr):
(JSC::LabelScopePtr::operator*):
(JSC::LabelScopePtr::operator->):
- bytecompiler/NodesCodegen.cpp:
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
Source/WTF:
Copying a SegmentedVector can be extraordinarily expensive, so we beat
it with the Noncopyable stick - that way we can ensure that if anyone
wants an actual copy they know what they're doing.
- wtf/SegmentedVector.h:
(SegmentedVector):
- 2:01 PM Changeset in webkit [145400] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r145200.
http://trac.webkit.org/changeset/145200
https://bugs.webkit.org/show_bug.cgi?id=112063
Broke a couple of unit tests (Requested by zdobersek on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-11
- Scripts/webkitperl/FeatureList.pm:
- 1:57 PM Changeset in webkit [145399] by
-
- 36 edits in trunk/Source
Add ASSERT_WITH_SECURITY_IMPLICATION to catch bad casts.
https://bugs.webkit.org/show_bug.cgi?id=112060
Reviewed by Eric Seidel.
Source/WebCore:
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::document):
- accessibility/AccessibilityMenuList.h:
(WebCore::toAccessibilityMenuList):
- accessibility/AccessibilityNodeObject.h:
(WebCore::toAccessibilityNodeObject):
- accessibility/AccessibilityRenderObject.h:
(WebCore::toAccessibilityRenderObject):
- accessibility/AccessibilitySVGRoot.h:
(WebCore::toAccessibilitySVGRoot):
- accessibility/AccessibilitySpinButton.h:
(WebCore::toAccessibilitySpinButton):
(WebCore::toAccessibilitySpinButtonPart):
- accessibility/AccessibilityTable.h:
(WebCore::toAccessibilityTable):
- css/StyleRule.h:
(WebCore::toStyleRuleMedia):
(WebCore::toStyleRuleSupports):
(WebCore::toStyleRuleRegion):
- dom/EventContext.h:
(WebCore::toTouchEventContext):
- fileapi/File.h:
(WebCore::toFile):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::insertAdjacentElement):
(WebCore::contextElementForInsertion):
- html/HTMLMediaElement.h:
(WebCore::toMediaElement):
- html/HTMLMeterElement.h:
(WebCore::toHTMLMeterElement):
- html/HTMLOptionElement.cpp:
(WebCore::toHTMLOptionElement):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::renderProgress):
- html/HTMLProgressElement.h:
(WebCore::toHTMLProgressElement):
- html/HTMLSelectElement.h:
(WebCore::toHTMLSelectElement):
- html/HTMLTableCellElement.cpp:
(WebCore::toHTMLTableCellElement):
- html/HTMLTextFormControlElement.h:
(WebCore::toHTMLTextFormControlElement):
- html/PluginDocument.h:
(WebCore::toPluginDocument):
- html/shadow/DetailsMarkerControl.cpp:
(WebCore::DetailsMarkerControl::summaryElement):
- html/shadow/HTMLContentElement.h:
(WebCore::toHTMLContentElement):
- html/shadow/HTMLShadowElement.h:
(WebCore::toHTMLShadowElement):
- html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::hostInput):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::document):
- rendering/InlineTextBox.h:
(WebCore::toInlineTextBox):
- rendering/RenderHTMLCanvas.h:
(WebCore::toRenderHTMLCanvas):
- rendering/RenderScrollbar.h:
(WebCore::toRenderScrollbar):
- rendering/RenderTextFragment.h:
(WebCore::toRenderTextFragment):
- rendering/mathml/RenderMathMLOperator.h:
(WebCore::toRenderMathMLOperator):
- rendering/svg/RenderSVGTextPath.h:
(WebCore::toRenderSVGTextPath):
- rendering/svg/RenderSVGViewportContainer.h:
(WebCore::toRenderSVGViewportContainer):
- svg/graphics/SVGImageChromeClient.h:
(WebCore::toSVGImageChromeClient):
Source/WebKit/chromium:
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::redirectDataToPlugin):
- 1:53 PM Changeset in webkit [145398] by
-
- 8 edits2 adds in trunk/Source/WebCore
Factor HTMLTreeBuilderSimulator out of BackgroundHTMLParser
https://bugs.webkit.org/show_bug.cgi?id=112057
Reviewed by Eric Seidel.
Simulating the HTML tree builder is a separate concern from parsing on
the background thread. We plan to re-use the tree builder simulator for
the view-source parser, for example. Also, having the simulator as a
separate object will make it easier to fix
https://bugs.webkit.org/show_bug.cgi?id=109764.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- html/parser/BackgroundHTMLParser.cpp:
(WebCore):
(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
- html/parser/BackgroundHTMLParser.h:
(BackgroundHTMLParser):
- 1:43 PM Changeset in webkit [145397] by
-
- 24 edits in trunk
Not all properties apply to the '::cue' pseudo-element
https://bugs.webkit.org/show_bug.cgi?id=110705
Reviewed by Eric Carlson.
Source/WebCore:
Background properties are not inherited and they were not applied to right elements.
Now we apply all ::cue properties to WebVTT cue background box, which -webkit-media-text-track-all-nodes
container was corresponding to. Now it has 'cue' pseudoId instead of '-webkit-media-text-track-all-nodes'.
Property filtering is turned off for user agent rules so that we are still able to apply filtered rules
to this container internally. m_cueContainer is removed because it is no longer needed.
m_allDocumentNodes container was renamed to m_cueBackgroundBox.
Existing tests modified to cover this case.
- css/RuleSet.h:
(WebCore::RuleData::propertyWhitelistType): disable filtering for UA rules.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::sortAndTransferMatchedRules): pass the UA scope to propertyWhitelistType().
- css/mediaControls.css: rename -webkit-media-text-track-all-nodes to 'cue'
(video::cue):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
- html/shadow/MediaControlElements.h:
(MediaControlTextTrackContainerElement):
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::createTextTrackDisplay):
- html/shadow/MediaControlsChromium.cpp:
(WebCore::MediaControlsChromium::createTextTrackDisplay):
- html/shadow/MediaControlsGtk.cpp:
(WebCore::MediaControlsGtk::createTextTrackDisplay):
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::updateDisplayTree):
(WebCore::TextTrackCue::getDisplayTree):
- html/track/TextTrackCue.h:
(WebCore::TextTrackCue::element):
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride):
LayoutTests:
- media/media-controls.js:
(textTrackDisplayElement):
- media/track/track-css-all-cues-expected.txt:
- media/track/track-css-all-cues.html:
- media/track/track-css-cue-lifetime.html:
- media/track/track-css-matching-default.html:
- media/track/track-css-matching-lang.html:
- media/track/track-css-matching-timestamps.html:
- media/track/track-css-matching.html:
- media/track/track-css-property-whitelist.html:
- media/track/track-in-band-style.html:
- platform/mac/media/track/track-cue-rendering-horizontal-expected.txt:
- 1:40 PM Changeset in webkit [145396] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Set the documentViewportRect and viewport size.
https://bugs.webkit.org/show_bug.cgi?id=112056
Patch by Genevieve Mak <gmak@rim.com> on 2013-03-11
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton and Jakob Petsovits.
PR #278490
- WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 1:22 PM Changeset in webkit [145395] by
-
- 5 edits in trunk
[GTK] WebKit2-only build fails
https://bugs.webkit.org/show_bug.cgi?id=112033
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
- GNUmakefile.am: Introduce the artifical dependency of libwebkit2gtk on libwebkitgtk only
if building WebKit1 as well. Similarly with the WebKitPluginProcess, depend on libwebkitgtk
only if building WebKit1, the dependency is otherwise not necessary.
Tools:
- GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
generic part, WebKit1-specific part and WebKit2-specific part.
- TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
directly.
- 1:17 PM Changeset in webkit [145394] by
-
- 2 edits in trunk/LayoutTests
Update chromium expectations.
- platform/chromium/TestExpectations:
- 1:03 PM Changeset in webkit [145393] by
-
- 2 edits in trunk/Source/WebCore
ChromeClient.h doesn’t need to include RenderSnapshottedPlugIn
https://bugs.webkit.org/show_bug.cgi?id=111981
Reviewed by Kentaro Hara.
- page/ChromeClient.h: Remove the extraneous #include.
- 1:01 PM Changeset in webkit [145392] by
-
- 20 edits5 copies in branches/chromium/1410
Merge 144236
Plugin in iframe may not display
https://bugs.webkit.org/show_bug.cgi?id=109879
Patch by John Bauman <jbauman@chromium.org> on 2013-02-27
Reviewed by Simon Fraser.
Source/WebCore:
Changing the cliprect on a layer containing an iframe may change the
cliprect of plugins inside the iframe, so recursively tell all plugins
in iframes that their cliprect has changed after doing layout on the
outer frame.
Test: plugins/plugin-clip-subframe.html
- platform/ScrollView.cpp:
(WebCore::ScrollView::clipRectChanged):
- platform/ScrollView.h:
- platform/Widget.h:
(WebCore::Widget::clipRectChanged):
- plugins/PluginView.cpp:
(WebCore::PluginView::clipRectChanged):
- plugins/PluginView.h:
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
Source/WebKit/chromium:
Use clipRectChanged to update the geometry.
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::clipRectChanged):
- src/WebPluginContainerImpl.h:
Source/WebKit/mac:
Ensure NetscapePluginWidget informs the plugin view of the cliprect change directly.
- Plugins/WebBaseNetscapePluginView.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(NetscapePluginWidget::clipRectChanged):
Source/WebKit2:
Update geometry when cliprect changes.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::clipRectChanged):
- WebProcess/Plugins/PluginView.h:
Tools:
LogNPPSetWindow will be used with other ports as well.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
LayoutTests:
Use log-npp-set-window to ensure plugin clip changes correctly.
- platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt: Added.
- platform/mac/plugins/plugin-clip-subframe-expected.txt: Added.
- plugins/plugin-clip-subframe-expected.txt: Added.
- plugins/plugin-clip-subframe.html: Added.
- plugins/resources/plugin-clip-subframe-iframe.html: Added.
TBR=jbauman@chromium.org
BUG=168900
Review URL: https://codereview.chromium.org/12408009
- 1:00 PM Changeset in webkit [145391] by
-
- 11 edits in trunk/Source/WebCore
Vertical writing doesn't work with form controls.
https://bugs.webkit.org/show_bug.cgi?id=70211
Reviewed by Simon Fraser.
This is just some basic plumbing work to make textfields and
textareas work with vertical writing modes. This patch leaves the
html.css override alone, so authors can't enable vertical
writing yet.
The changes consist of converting uses of x/y/width/height to
logicalLeft/Top/Width/Height.
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::paddingLogicalLeft):
(WebCore::RenderBoxModelObject::paddingLogicalRight):
(RenderBoxModelObject):
(WebCore::RenderBoxModelObject::marginLogicalHeight):
(WebCore::RenderBoxModelObject::marginLogicalWidth):
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::computeControlLogicalHeight):
(WebCore::RenderSearchField::computeLogicalHeightLimit):
(WebCore::RenderSearchField::centerContainerIfNeeded):
- rendering/RenderSearchField.h:
(RenderSearchField):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::textBlockLogicalHeight):
(WebCore::RenderTextControl::textBlockLogicalWidth):
(WebCore::RenderTextControl::computeLogicalHeight):
(WebCore::RenderTextControl::computeIntrinsicLogicalWidths):
(WebCore::RenderTextControl::computePreferredLogicalWidths):
- rendering/RenderTextControl.h:
(RenderTextControl):
- rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::preferredContentLogicalWidth):
(WebCore::RenderTextControlMultiLine::computeControlLogicalHeight):
(WebCore::RenderTextControlMultiLine::layoutSpecialExcludedChild):
- rendering/RenderTextControlMultiLine.h:
(RenderTextControlMultiLine):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::paint):
(WebCore::RenderTextControlSingleLine::computeLogicalHeightLimit):
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::styleDidChange):
(WebCore::RenderTextControlSingleLine::preferredContentLogicalWidth):
(WebCore::RenderTextControlSingleLine::computeControlLogicalHeight):
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
- rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine):
- rendering/style/RenderStyle.h:
- 12:59 PM Changeset in webkit [145390] by
-
- 8 edits in trunk/Source/WebKit2
[wk2] Search With [your search provider here] should use NSPerformService in WebKit2/Mac
https://bugs.webkit.org/show_bug.cgi?id=111995
<rdar://problem/12975669>
Reviewed by Sam Weinig.
- UIProcess/WebPageProxy.h:
(WebPageProxy): Add searchTheWeb().
- UIProcess/WebPageProxy.messages.in: Add SearchTheWeb message.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::searchTheWeb): Added. Call out to NSPerformService to search with the system default
search provider, in the browser.
- WebProcess/Plugins/PDF/PDFPlugin.h:
(PDFPlugin): Add performWebSearch().
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate performWebSearch:]): Added, forward the delegate callback to PDFPlugin.
(WebKit::PDFPlugin::performWebSearch): Added, forward the search string to WebPageProxy.
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle): Don't build the old load-Google-in-the-main-frame code on Mac.
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::searchWithGoogle): Instead, send the search string to WebPageProxy.
- 12:57 PM Changeset in webkit [145389] by
-
- 4 edits in trunk/Source/WebCore
TiledBacking scrolling coverage can be unfairly limited for clients who do scrolling outside the web view
https://bugs.webkit.org/show_bug.cgi?id=111958
<rdar://problem/13356896>
Reviewed by Darin Adler.
Don't limit TiledBacking coverage if the client has opted into using
its exposed rect to allow scrolling above the web view.
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/mac/TileController.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::adjustTiledBackingCoverage):
- 12:54 PM Changeset in webkit [145388] by
-
- 2 edits in trunk/Tools
Adding myself to the committers.py
- 12:49 PM Changeset in webkit [145387] by
-
- 2 edits in trunk/Source/WebCore
GetnUniform*vEXT (Robustness extension) passed incorrect parameter in WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=111450
Patch by Rajeev Sarvaria <rsarvaria@blackberry.com> on 2013-03-11
Reviewed by Rob Buis.
Bufsize argument corrected to size in bytes instead of number of integers or floats.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::getUniform):
- 12:48 PM Changeset in webkit [145386] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Add C API preference: accelerated compositing for overflow scroll
https://bugs.webkit.org/show_bug.cgi?id=111916
Patch by Helder Correia <Helder Correia> on 2013-03-11
Reviewed by Simon Fraser.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAcceleratedCompositingForOverflowScrollEnabled):
(WKPreferencesGetAcceleratedCompositingForOverflowScrollEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
- 12:42 PM Changeset in webkit [145385] by
-
- 10 edits in trunk/Source
Unreviewed, rolling out r145375.
http://trac.webkit.org/changeset/145375
https://bugs.webkit.org/show_bug.cgi?id=112050
Does not compile (Requested by jamesr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-11
Source/WebCore:
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::getObjectStores):
(WebCore::IDBBackingStore::createObjectStore):
(WebCore::IDBBackingStore::deleteObjectStore):
(WebCore::IDBBackingStore::getRecord):
(WebCore::IDBBackingStore::putRecord):
(WebCore::IDBBackingStore::clearObjectStore):
(WebCore::IDBBackingStore::deleteRecord):
(WebCore::IDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBBackingStore::getIndexes):
(WebCore::IDBBackingStore::createIndex):
(WebCore::IDBBackingStore::deleteIndex):
(WebCore::IDBBackingStore::putIndexDataForRecord):
(WebCore::IDBBackingStore::findKeyInIndex):
(WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStore::keyExistsInIndex):
(WebCore::indexCursorOptions):
- Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexOperation::DeleteIndexOperation):
(DeleteIndexOperation):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::deleteIndex):
(WebCore::DeleteIndexOperation::perform):
(WebCore::DeleteRangeOperation::perform):
(WebCore::ClearOperation::perform):
- Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
(WebCore::IDBLevelDBCoding::KeyPrefix::encode):
(WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
(WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
(WebCore::IDBLevelDBCoding::DataVersionKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
- Modules/indexeddb/IDBLevelDBCoding.h:
(IDBLevelDBCoding):
(KeyPrefix):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::IndexWriter::writeIndexKeys):
Source/WebKit/chromium:
- tests/IDBBackingStoreTest.cpp:
(WebCore::IDBBackingStoreTest::SetUp):
(IDBBackingStoreTest):
(WebCore::TEST_F):
- tests/IDBFakeBackingStore.h:
- 12:41 PM Changeset in webkit [145384] by
-
- 5 edits in branches/safari-534.59-branch/Source
Versioning
- 12:40 PM Changeset in webkit [145383] by
-
- 1 copy in tags/Safari-534.59.3
New Tag.
- 12:39 PM Changeset in webkit [145382] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning
- 12:38 PM Changeset in webkit [145381] by
-
- 1 copy in tags/Safari-536.29.7
New Tag.
- 12:24 PM Changeset in webkit [145380] by
-
- 2 edits in trunk/Source/WebKit2
CoreIPC crash in NetworkProcess after WebProcess crash.
<rdar://problem/13124146> and https://bugs.webkit.org/show_bug.cgi?id=112046
Reviewed by Alexey Proskuryakov.
- NetworkProcess/SchedulableLoader.cpp:
(WebKit::SchedulableLoader::connectionToWebProcessDidClose): Don't null out the connection backpointer on crash.
- 12:16 PM Changeset in webkit [145379] by
-
- 12 edits in trunk
MutationCallback should be a WebIDL 'callback', not a [Callback] interface
https://bugs.webkit.org/show_bug.cgi?id=91406
Reviewed by Adam Barth.
Source/WebCore:
Spec: http://dom.spec.whatwg.org/#mutationcallback
Besides no longer calling handleEvent methods on passed-in objects,
throw a TypeError if a non-function is passed to the MutationObserver constructor.
This is per WebIDL: http://www.w3.org/TR/WebIDL/#es-callback-function
Updated MutationObserver constructor tests to exercise TypeError-throwing behavior.
- bindings/js/JSMutationCallback.cpp:
(WebCore::JSMutationCallback::call): Call the callback directly instead of handing off to JSCallbackData; make return value void.
Use jsArray() to convert from WTF::Vector -> JSArray.
- bindings/js/JSMutationCallback.h:
(JSMutationCallback): Rename handleEvent() to call(), make it void.
- bindings/js/JSMutationObserverCustom.cpp:
(WebCore::JSMutationObserverConstructor::constructJSMutationObserver): Throw if passed a non-function.
- bindings/v8/V8MutationCallback.cpp:
(WebCore::V8MutationCallback::V8MutationCallback): Take a v8::Function instead of a v8::Object.
(WebCore::V8MutationCallback::call): Call the callback directly instead of handing off to invokeCallback(); make return value void.
Use v8Array() to convert form WTF::Vector -> JSArray.
- bindings/v8/V8MutationCallback.h:
(WebCore::V8MutationCallback::create): Take a v8::Function instead of a v8::Object.
(V8MutationCallback): ditto
- bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCustom): Throw if passed a non-function, cast to a v8::Function when constructing callback.
- dom/MutationCallback.h:
(WebCore): Remove unnecessary typedef.
(MutationCallback): Rename handleEvent() to call(), make it void.
- dom/MutationObserver.cpp:
(WebCore::MutationObserver::deliver): Update MutationCallback method name.
LayoutTests:
- fast/dom/MutationObserver/mutation-observer-constructor-expected.txt:
- fast/dom/MutationObserver/mutation-observer-constructor.html: Add test for TypeError-throwing.
Note that the Number and String cases already threw before this patch.
- 12:07 PM Changeset in webkit [145378] by
-
- 5 edits in trunk
[CSS Grid Layout] Handle spanning grid items over specified grid tracks
https://bugs.webkit.org/show_bug.cgi?id=111918
Reviewed by Tony Chang.
Source/WebCore:
This change updates the containing block override logic to handle multiple
spanned tracks. This makes the multiple specified grid tracks case work and
will enable us to handle the minmax case once the computation logic has been
updated.
Test: fast/css-grid-layout/grid-item-spanning-resolution.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::logicalContentHeightForChild):
(WebCore::RenderGrid::layoutGridItems):
Updated these functions to use gridAreaBreadthForChild.
(WebCore::RenderGrid::gridAreaBreadthForChild):
Added this helper function to handle multiple spanned grid tracks.
- rendering/RenderGrid.h: Added the previous function.
LayoutTests:
- fast/css-grid-layout/grid-item-spanning-resolution-expected.txt:
We now pass all the tests.
- 11:43 AM Changeset in webkit [145377] by
-
- 33 edits in trunk/Source/WebCore
Replace SVG's static_cast<SVGElement> with toSVGElement()
https://bugs.webkit.org/show_bug.cgi?id=111651
Reviewed by Abhishek Arya.
toSVGElement is preferred over static_cast because bad casts can be caught on
our testing infrastructure. This patch replaces all static_cast<SVGElement>
instances with toSVGElement.
No new tests as this is just a refactoring.
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
- dom/Element.cpp:
(WebCore::Element::synchronizeAllAttributes):
(WebCore::Element::synchronizeAttribute):
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::getElementCTM):
(WebCore::RenderSVGModelObject::checkIntersection):
(WebCore::RenderSVGModelObject::checkEnclosure):
- rendering/svg/RenderSVGResource.cpp:
(WebCore::removeFromCacheAndInvalidateDependencies):
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::pathOnlyClipping):
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
(WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect):
(WebCore::RenderSVGResourceClipper::hitTestClipContent):
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::buildPrimitives):
- rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
(WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect):
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::createTileImage):
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::strokeWidth):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::strokeBoundingBox):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::layoutChildren):
(WebCore::SVGRenderSupport::applyStrokeStyleToContext):
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGPaintingResource):
(WebCore::writeStyle):
(WebCore::operator<<):
- rendering/svg/SVGResources.cpp:
(WebCore::SVGResources::buildCachedResources):
- rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::createRenderer):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::adjustForInheritance):
- svg/SVGElement.cpp:
(WebCore::SVGElement::viewportElement):
(WebCore::SVGElement::haveLoadedRequiredResources):
(WebCore::SVGElement::sendSVGLoadEventIfPossible):
(WebCore::SVGElement::childShouldCreateRenderer):
- svg/SVGElement.h:
(WebCore::toSVGElement):
(WebCore):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::buildPendingResource):
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::childShouldCreateRenderer):
- svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::buildStops):
- svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::nearestViewportElement):
(WebCore::SVGLocatable::farthestViewportElement):
(WebCore::SVGLocatable::computeCTM):
- svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::buildPendingResource):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::collectIntersectionOrEnclosureList):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::updateRelativeLengthsInformation):
- svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::childShouldCreateRenderer):
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::buildPendingResource):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::toClipPath):
(WebCore::SVGUseElement::rendererClipChild):
(WebCore::SVGUseElement::buildInstanceTree):
(WebCore::SVGUseElement::hasCycleUseReferencing):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
(WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::viewTarget):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::buildPendingResource):
- svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::platformApplySoftware):
- 11:24 AM Changeset in webkit [145376] by
-
- 2 edits in trunk/Source/WebCore
[SOUP] ResourceRequest::updateSoupMessage doesn't update the URI of the soup message
https://bugs.webkit.org/show_bug.cgi?id=112040
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-11
Reviewed by Gustavo Noronha Silva.
- platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupMessage): Update the soup
message URI with the ResourceRequest URL.
- 11:08 AM WebKitGTK/2.0.x edited by
- (diff)
- 10:37 AM Changeset in webkit [145375] by
-
- 10 edits in trunk/Source
IndexedDB: Protect against key prefix overflows
https://bugs.webkit.org/show_bug.cgi?id=111138
Reviewed by Tony Chang.
Source/WebCore:
This reworks the boundary checking for all databaseId,
objectStoreId, and indexId, including negative and
zero-based ids. All entrypoints into IDBLevelDBCoding
are protected with explicit checks and all internal
uses of KeyPrefix are protected with ASSERTs in the
various constructors.
Tests: WebKit unit tests IDBBackingStoreTest.cpp in WebKit/chromium
- Modules/indexeddb/IDBBackingStore.h: Make all public methods boolean-based for errors.
- Modules/indexeddb/IDBLevelDBCoding.h: Add methods for checking databaseId, objectStoreId, and indexId.
Source/WebKit/chromium:
Add tests for invalid indexIds in basic get/put operations.
- 10:32 AM Changeset in webkit [145374] by
-
- 15 edits14 deletes in branches/chromium/1410
Merge 145296
Unreviewed, rolling out r142015.
http://trac.webkit.org/changeset/142015
https://bugs.webkit.org/show_bug.cgi?id=111904
The change caused 2 major regressions (bug 111091 and bug
111595) and Pravin doesn't have time to investigate them
(Requested by jchaffraix on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-08
Source/WebCore:
- dom/Node.cpp:
(WebCore::Node::diff):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::childBecameNonInline):
(WebCore):
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::childBecameNonInline):
(RenderBoxModelObject):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::childBecameNonInline):
(WebCore):
- rendering/RenderInline.h:
(RenderInline):
- rendering/RenderObject.cpp:
(WebCore):
(WebCore::RenderObject::handleDynamicFloatPositionChange):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::styleDidChange):
- rendering/RenderObject.h:
(RenderObject):
LayoutTests:
- fast/css/first-letter-removed-added-expected.txt:
- fast/dynamic/absolute-positioned-to-static-positioned-expected.txt: Removed.
- fast/dynamic/absolute-positioned-to-static-positioned.html: Removed.
- fast/dynamic/floating-to-non-floating-expected.txt: Removed.
- fast/dynamic/floating-to-non-floating.html: Removed.
- fast/dynamic/non-floating-to-floating-expected.txt: Removed.
- fast/dynamic/non-floating-to-floating.html: Removed.
- fast/dynamic/resources/helper-bug91665.js: Removed.
- fast/dynamic/resources/style-bug91665.css: Removed.
- fast/dynamic/static-positioned-to-absolute-positioned-expected.txt: Removed.
- fast/dynamic/static-positioned-to-absolute-positioned.html: Removed.
- fullscreen/full-screen-fixed-pos-parent-expected.txt:
- platform/chromium-mac/fast/repaint/absolute-position-change-containing-block-expected.png:
- platform/chromium-mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png:
- platform/chromium-win/fast/dynamic/002-expected.txt:
- platform/chromium/fast/dynamic/002-expected.txt:
- platform/chromium/fast/repaint/absolute-position-change-containing-block-expected.png: Removed.
- platform/chromium/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Removed.
- platform/mac/fast/dynamic/002-expected.txt:
- platform/mac/fast/repaint/absolute-position-change-containing-block-expected.png: Removed.
- platform/mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Removed.
- 10:17 AM Changeset in webkit [145373] by
-
- 4 edits in trunk
[BlackBerry] Disable MathML support
https://bugs.webkit.org/show_bug.cgi?id=111929
Patch by Jeff Rogers <jrogers@rim.com> on 2013-03-11
Reviewed by Rob Buis.
.:
- Source/cmake/OptionsBlackBerry.cmake:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 10:07 AM Changeset in webkit [145372] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] PlatformBlackBerry.cmake: create thin AR archives
https://bugs.webkit.org/show_bug.cgi?id=110580
Patch by Xan Lopez <xlopez@igalia.com> on 2013-03-11
Reviewed by Rob Buis.
Otherwise libwebcore.a goes beyond the 4Gb file size limit and the
link phase fails.
- PlatformBlackBerry.cmake:
- 9:07 AM Changeset in webkit [145371] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix styles toolbar in the vertical mode.
Not reviewed: swapped two lines.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._splitVertically):
- 8:59 AM QtWebKitBuildBots edited by
- (diff)
- 8:59 AM Changeset in webkit [145370] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] add token highlight feature
https://bugs.webkit.org/show_bug.cgi?id=112009
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-11
Reviewed by Pavel Feldman.
Handle CodeMirror's "cursorActivity" event, check selection for being
a word and highlight all its occurrences via CodeMirror.addOverlay method.
No new tests.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.TokenHighlighter):
(WebInspector.CodeMirrorTextEditor.TokenHighlighter.prototype._cursorChange):
(WebInspector.CodeMirrorTextEditor.TokenHighlighter.prototype._isWord):
(WebInspector.CodeMirrorTextEditor.TokenHighlighter.prototype._removeHighlight):
(WebInspector.CodeMirrorTextEditor.TokenHighlighter.prototype._addHighlight.nextToken):
(WebInspector.CodeMirrorTextEditor.TokenHighlighter.prototype._addHighlight):
- inspector/front-end/cm/cmdevtools.css:
(.cm-token-highlight):
- 8:51 AM Changeset in webkit [145369] by
-
- 7 edits in trunk/Source/WebKit2
Make it possible to reuse sandbox extensions
https://bugs.webkit.org/show_bug.cgi?id=111883
Reviewed by Anders Carlsson.
This allows for properly keeping extensions in NetworkBlobRegistry for as long as
they are needed.
The patch also fixes a bug where extensions would leak when navigating between
file:// pages.
- NetworkProcess/SchedulableLoader.cpp:
Revoke the extensions, but don't invalidate - we may need them later.
- Shared/Downloads/Download.cpp:
(WebKit::Download::didFinish):
(WebKit::Download::didFail):
(WebKit::Download::didCancel):
Replaced invalidate() with revoke() and clearing out. SandboxExtension destructor
now requires revocations wto be balanced, as otherwise understanding dual reference
counting in SandboxExtension would be too difficult.
- Shared/SandboxExtension.h: We now keep track of how many times the extension
was consumed. Eventually, we should refactor the class to not have such duplicate
reference counting.
- Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::SandboxExtension): Initialize use count.
(WebKit::SandboxExtension::~SandboxExtension): We now require consume/revoke calls
to be balanced. This is not hard to do in existing usage, and makes the design much
more reliable.
(WebKit::SandboxExtension::revoke): Don't permanently destroy the extension when
invalidatid, we may need it in the future.
(WebKit::SandboxExtension::consume): Added use counting.
- Shared/WebMemorySampler.cpp: (WebKit::WebMemorySampler::stop): This extension
is not going to be reused.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction): Pending extensions are not consumed,
so there is no need to revoke.
(WebKit::WebPage::SandboxExtensionTracker::invalidate): Pending extension is not
consumed, and the other two always are.
(WebKit::WebPage::SandboxExtensionTracker::setPendingProvisionalSandboxExtension):
Pending extension is never consumed in place, no need to revoke.
(WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad): Do not unset
reused committed extension yet - we may need it later if provisional load fails.
Thanks to use counting, we can now consume the same extension as both committed
and provisional.
(WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad): Now the
committed extension can be revoked and replaced.
(WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad): Just revoke
provisional extension, committed one is still in place.
- 8:49 AM Changeset in webkit [145368] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] set indentation size according to devtools settings
https://bugs.webkit.org/show_bug.cgi?id=111717
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-11
Reviewed by Pavel Feldman.
Set up codemirror indent size according to devtools settings.
No new tests.
- inspector/front-end/CodeMirrorTextEditor.js:
(.get if):
(WebInspector.CodeMirrorTextEditor):
- 8:47 AM Changeset in webkit [145367] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: add per image statistics to the native memory snapshot
https://bugs.webkit.org/show_bug.cgi?id=112011
Reviewed by Pavel Feldman.
Added per-image statistics to the native memory distribution table.
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotWorker.prototype.createLoader):
(WebInspector.HeapSnapshotWorker.prototype.wrapCallback):
(WebInspector.HeapSnapshotWorker.prototype.callFactoryMethod):
(WebInspector.HeapSnapshotProxyObject.prototype.callFactoryMethod): the method now accepts
proxy constructor function instead of its name. This eliminates unnecessary function lookup.
(WebInspector.HeapSnapshotLoaderProxy):
(WebInspector.HeapSnapshotLoaderProxy.prototype.close):
(WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createRetainingEdgesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createAddedNodesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createDeletedNodesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createNodesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForClass):
(WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForDominator):
(WebInspector.NativeHeapSnapshotProxy):
(WebInspector.NativeHeapSnapshotProxy.prototype.images):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapProfileHeader.prototype.snapshotProxyConstructor):
(WebInspector.HeapProfileHeader.prototype._setupWorker):
- inspector/front-end/NativeHeapSnapshot.js:
(WebInspector.NativeHeapSnapshot.prototype.images):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotNode):
(WebInspector.NativeSnapshotNode.prototype._createSizeCell):
(WebInspector.NativeSnapshotNode.prototype._populate):
(WebInspector.NativeSnapshotNode.prototype._addChildrenFromGraph):
(WebInspector.NativeSnapshotNode.prototype._addImageDetails.didLoad.didReceiveImages):
(WebInspector.NativeSnapshotNode.prototype._addImageDetails):
(WebInspector.NativeSnapshotProfileHeader.prototype.snapshotProxyConstructor):
- 8:43 AM Changeset in webkit [145366] by
-
- 4 edits in trunk/Source/WebCore
[Qt] Enable tiled shadow blur for inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=111736
Reviewed by Noam Rosenthal.
Paint inset box-shadows using the optimized tiled shadow blur, instead of
applying shadow blur to the entire painted rect.
This optimizes the default CSS on common pastebin sites.
Tested by existing tests.
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
Must set fill color before calling clearShadow, as that might clear m_color.
(WebCore::ShadowBlur::drawLayerPieces):
Ditto.
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
- 8:33 AM Changeset in webkit [145365] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] SelectionHandler: bring back m_lastSelection attribute
https://bugs.webkit.org/show_bug.cgi?id=111972
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-11
Reviewed by Rob Buis.
This was removed in r144515 but is still needed by
SelectionHandler::selectionPositionChanged().
- WebKitSupport/SelectionHandler.h:
(SelectionHandler):
- 8:31 AM Changeset in webkit [145364] by
-
- 2 edits in trunk/LayoutTests
(tests) make nodesFromRect.js print a list of nodes that were found
https://bugs.webkit.org/show_bug.cgi?id=111793
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-11
Reviewed by Allan Sandfeld Jensen.
- fast/dom/nodesFromRect/resources/nodesFromRect.js:
(nodeToString):
(nodeListToString):
(check):
(nodesFromRectAsString):
Move node prettyprinting code from nodesFromRectAsString to new
functions nodeToString and nodeListToString, and make use of it in
check().
I've also converted the nodeType checks to use the constants on Node
instead of using magic numbers.
- 8:26 AM Changeset in webkit [145363] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] GraphicsLayer: rename notifySyncRequired to notifyFlushRequired
https://bugs.webkit.org/show_bug.cgi?id=111997
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-11
Reviewed by Rob Buis.
This changed in r130439 but the old name was introduced again by
mistake in r144465.
- platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
(WebCore::GraphicsLayerBlackBerry::notifyFlushRequired):
- platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::setNeedsCommit):
- 7:43 AM Changeset in webkit [145362] by
-
- 6 edits in trunk
Inappropriate validation message for required number/date input elements
https://bugs.webkit.org/show_bug.cgi?id=111982
Reviewed by Kentaro Hara.
Source/WebCore:
For validation message, badInput messages should take precedence
over valueMissing messages because users already filled out the
field with a bad value.
Tests: Update fast/forms/validationMessage.html
- html/InputType.cpp:
(WebCore::InputType::validationMessage):
Check badInput first.
LayoutTests:
- fast/forms/validationMessage-expected.txt:
- fast/forms/validationMessage.html:
- platform/chromium/fast/forms/validationMessage-expected.txt:
- 7:19 AM Changeset in webkit [145361] by
-
- 2 edits in trunk/Tools
[EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
https://bugs.webkit.org/show_bug.cgi?id=111970
Reviewed by Chris Fleizach.
Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
undefined symbol.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::supportedActions):
(WTR):
- 6:54 AM Changeset in webkit [145360] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Build fix after r143192 when SPELLCHECK is off
Unreviewed build fix when SPELLCHECK macro is off.
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit):
- 6:15 AM Changeset in webkit [145359] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
WebKitWebPage::document-loaded signal emitted multiple times
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-11
Reviewed by Carlos Garcia Campos.
This happens in websites with multiple frames, because the signal
is emitted for every frame.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(didFinishDocumentLoadForFrame): Add an early return to make sure
the WebKitWebPage::document-loaded signal is only emitted for the
main frame.
- 6:09 AM WebKitGTK/2.0.x edited by
- (diff)
- 6:07 AM Changeset in webkit [145358] by
-
- 13 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK][WK2] Add API to retrieve a snapshot from a webview
https://bugs.webkit.org/show_bug.cgi?id=98270
Patch by Claudio Saavedra <Claudio Saavedra> on 2013-03-10
Reviewed by Carlos Garcia Campos.
This adds the GTK+ API necessary to retrieve a snapshot from a
webview asynchronously. The API uses the injected bundle
internally to get the snapshot from the WebProcess.
- UIProcess/API/gtk/WebKitError.cpp:
(webkit_snapshot_error_quark): Add snapshot API related error
quark.
- UIProcess/API/gtk/WebKitError.h: Add snapshot error handling.
- UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
(didReceiveWebViewMessageFromInjectedBundle): Handle the new
"DidGetSnapshot" message.
- UIProcess/API/gtk/WebKitPrivate.h: Add SnapshotRegion enum.
- UIProcess/API/gtk/WebKitWebView.cpp:
(_WebKitWebViewPrivate): Add a map for the snapshot results.
(GetSnapshotAsyncData):
(webKitWebViewDidReceiveSnapshot):
(webKitSnapshotRegionToSnapshotRegion): Helper method for casting
the region option enumeration.
(generateSnapshotCallbackID): Method to generate unique callback
ids.
(webkit_web_view_get_snapshot):
(webkit_web_view_get_snapshot_finish): New snapshotting API.
- UIProcess/API/gtk/WebKitWebView.h: Ditto.
- UIProcess/API/gtk/WebKitWebViewPrivate.h: Add the private method
to handle a received snapshot.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add the new API
bits.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(cairoSurfacesEqual): Add helper to compare cairo_surface_t
structs.
(testWebViewSnapshot): New test.
(beforeAll): Add the new test.
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::selectAll): Add method to help test snapshots
including selection.
- UIProcess/API/gtk/tests/WebViewTest.h: Ditto
- WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
(webkitWebExtensionDidReceiveMessageToPage): Add this method. It
handles the new message "GetSnapshot".
(didReceiveMessageToPage): Ditto.
(webkitWebExtensionCreate): Register method above.
- 5:43 AM Changeset in webkit [145357] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: extract common parts of native profiles
https://bugs.webkit.org/show_bug.cgi?id=111965
Reviewed by Alexander Pavlov.
Extracted common parts of native profiles into NativeProfileTypeBase. Memory
domain dispatcher is now a separate class as it is shared by two native memory
profile types.
Both native memory profile types now capture native heap graph.
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryAgentDispatcher.instance):
(WebInspector.NativeProfileTypeBase.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeProfileTypeBase.prototype.buttonClicked):
(WebInspector.NativeSnapshotProfileType):
(WebInspector.NativeSnapshotProfileHeader.prototype._didReceiveMemorySnapshot):
(WebInspector.NativeMemoryProfileType):
(WebInspector.NativeMemoryProfileHeader.prototype._updateSnapshotStatus):
(WebInspector.NativeMemoryProfileHeader.prototype._didReceiveMemorySnapshot):
- 5:06 AM Changeset in webkit [145356] by
-
- 4 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip most of the websocket hybi test cases on EFL port as they
are passing nowadays.
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 4:48 AM WebKitGTK/2.0.x edited by
- Add new proposed merge (diff)
- 4:11 AM Changeset in webkit [145355] by
-
- 5 edits in trunk
[chromium] Android apk targets should depend directly on Java library targets
https://bugs.webkit.org/show_bug.cgi?id=111746
Patch by Chris Hopman <cjhopman@chromium.org> on 2013-03-11
Reviewed by Eric Seidel.
Source/WebKit/chromium:
- WebKitUnitTests.gyp:
Make webkit_unit_tests_apk depend directly on base_java and net_java.
Tools:
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
Make DumpRenderTree_apk depend directly on base_java and net_java.
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
Make TestWebKitAPI_apk depend directly on base_java.
- 3:56 AM Changeset in webkit [145354] by
-
- 15 edits4 deletes in trunk/Source/WebCore
Unreviewed, rolling out r145349.
http://trac.webkit.org/changeset/145349
https://bugs.webkit.org/show_bug.cgi?id=111966
Missing code history of Element,PageRuleCollector. (Requested
by tasak on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-11
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/DocumentRuleSets.cpp:
(WebCore::ShadowDistributedRules::collectMatchRequests):
- css/DocumentRuleSets.h:
- css/ElementRuleCollector.cpp: Removed.
- css/ElementRuleCollector.h: Removed.
- css/PageRuleCollector.cpp: Removed.
- css/PageRuleCollector.h: Removed.
- css/StyleResolver.cpp:
(WebCore::leftToRightDeclaration):
(WebCore):
(WebCore::rightToLeftDeclaration):
(WebCore::StyleResolver::State::ensureRuleList):
(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::addMatchedProperties):
(WebCore::StyleResolver::addElementStyleProperties):
(MatchingUARulesScope):
(WebCore::MatchingUARulesScope::MatchingUARulesScope):
(WebCore::MatchingUARulesScope::~MatchingUARulesScope):
(WebCore::MatchingUARulesScope::isMatchingUARules):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::compareRules):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::State::initForStyleResolve):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::comparePageRules):
(WebCore::StyleResolver::matchPageRules):
(WebCore::checkPageSelectorComponents):
(WebCore::StyleResolver::matchPageRulesForList):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::isFirstPage):
(WebCore::StyleResolver::pageName):
- css/StyleResolver.h:
(WebCore::MatchRequest::MatchRequest):
(MatchRequest):
(StyleResolver):
(MatchResult):
(WebCore::StyleResolver::State::State):
(State):
(WebCore::StyleResolver::State::takeRuleList):
(WebCore::StyleResolver::State::setSameOriginOnly):
(WebCore::StyleResolver::State::isSameOriginOnly):
(WebCore::StyleResolver::State::pseudoStyleRequest):
(WebCore::StyleResolver::State::setMode):
(WebCore::StyleResolver::State::mode):
(WebCore::StyleResolver::State::matchedRules):
(WebCore::StyleResolver::State::addMatchedRule):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willMatchRule):
- inspector/InspectorCSSAgent.h:
(WebCore):
(InspectorCSSAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willMatchRuleImpl):
- inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willMatchRule):
- 3:44 AM Changeset in webkit [145353] by
-
- 2 edits in trunk/Source/WebCore
[V8] Fix V8InjectedScriptManager
https://bugs.webkit.org/show_bug.cgi?id=111968
Patch by Marja Hölttä <marja@chromium.org> on 2013-03-11
Reviewed by Kentaro Hara.
This is needed to make the inspector work after templates for main world
and non-main worlds are separated (bug 111724).
No new tests (no changes in functionality).
- bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
- 3:36 AM Changeset in webkit [145352] by
-
- 2 edits in trunk/Source/WebCore
Make sure that CSSSelector::setValue() is never called after parsing its pseudoType.
https://bugs.webkit.org/show_bug.cgi?id=111957
Reviewed by Hajime Morrita.
It'd be nice to have an assertion here since
CSSSelector::pseudoType() will never parse a new value after it
parses a value and m_pseudoType is set to non-PseudoNotParsed.
No new tests (no change in behaviour).
- css/CSSSelector.h:
(WebCore::CSSSelector::setValue):
- 2:55 AM Changeset in webkit [145351] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Mark LayoutTests/html5lib/generated/run-tests16-data.html as slow
https://bugs.webkit.org/show_bug.cgi?id=111960
Patch by Alan Cutter <alancutter@chromium.org> on 2013-03-11
Reviewed by Eric Seidel.
Related to V8 performance issue: https://code.google.com/p/v8/issues/detail?id=2567
- platform/chromium/TestExpectations:
- 2:53 AM Changeset in webkit [145350] by
-
- 6 edits in trunk/LayoutTests
[Qt] Unrewieved gardening. Cleaning up some skip.
- 2:50 AM Changeset in webkit [145349] by
-
- 15 edits4 adds in trunk/Source/WebCore
[Refactoring] Implement RuleCollector
https://bugs.webkit.org/show_bug.cgi?id=109916
Reviewed by Antti Koivisto.
Implemented rule collector for an element and collector for a page.
Not all members in class State are required entire while resolving
a style.
No new tests, because just refactoring.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
Added ElementRuleCollector and PageRuleCollector.
- css/DocumentRuleSets.cpp:
(WebCore::ShadowDistributedRules::collectMatchRequests):
Since behaviorAtBoundary is a state owned by ElementRuleCollector,
removed from here.
- css/DocumentRuleSets.h:
(WebCore::ShadowDistributedRules::isEmpty):
Added to quickly check whether there exist any ShadowDistributedRules
or not.
- css/ElementRuleCollector.cpp: Copied from Source/WebCore/css/StyleResolver.cpp.
(WebCore):
(WebCore::ElementRuleCollector::matchedResult):
(WebCore::ElementRuleCollector::matchedRuleList):
(WebCore::ElementRuleCollector::addMatchedRule):
(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::ensureRuleList):
(WebCore::ElementRuleCollector::addElementStyleProperties):
(WebCore::ElementRuleCollector::collectMatchingRules):
(WebCore::ElementRuleCollector::collectMatchingRulesForRegion):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::matchScopedAuthorRules):
(WebCore::ElementRuleCollector::matchHostRules):
(WebCore::ElementRuleCollector::matchShadowDistributedRules):
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchUserRules):
(WebCore::ElementRuleCollector::matchUARules):
(WebCore::ElementRuleCollector::ruleMatches):
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
(WebCore::ElementRuleCollector::sortMatchedRules):
(WebCore::ElementRuleCollector::matchAllRules):
Moved these methods from StyleResolver to this class.
(WebCore::ElementRuleCollector::hasAnyMatchingRules):
This method is used for checking whether a given element can share
a cache.
- css/ElementRuleCollector.h: Copied from Source/WebCore/css/StyleResolver.h.
(WebCore):
(WebCore::ElementRuleCollector::ElementRuleCollector):
Use styleResolver instance to initialize its member variables, i.e.
SelectorFilter, RuleSets, InspectorCSSOMWrappers, and
StyleScopedResolver.
(ElementRuleCollector):
(WebCore::ElementRuleCollector::setMode):
(WebCore::ElementRuleCollector::setPseudoStyleRequest):
(WebCore::ElementRuleCollector::setSameOriginOnly):
(WebCore::ElementRuleCollector::setRegionForStyling):
Mode, SameOriginOnly, RegionForStyling are only used while collecting
matched rules.
(WebCore::ElementRuleCollector::setMedium):
Need to know which default stylesheet should be looked up.
(WebCore::ElementRuleCollector::document):
- css/PageRuleCollector.cpp: Copied from Source/WebCore/css/StyleResolver.cpp.
(WebCore::comparePageRules):
(WebCore::PageRuleCollector::isLeftPage):
(WebCore::PageRuleCollector::isFirstPage):
(WebCore::PageRuleCollector::pageName):
(WebCore::PageRuleCollector::matchAllPageRules):
(WebCore::PageRuleCollector::matchPageRules):
(WebCore::checkPageSelectorComponents):
(WebCore::PageRuleCollector::matchPageRulesForList):
Moved from StyleResolver.
- css/PageRuleCollector.h: Copied from Source/WebCore/css/StyleResolver.h.
(WebCore):
(WebCore::PageRuleCollector::PageRuleCollector):
(PageRuleCollector):
(WebCore::PageRuleCollector::matchedResult):
- css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::MatchResult::addMatchedProperties):
(WebCore::StyleResolver::State::initForStyleResolve):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::applyMatchedProperties):
- css/StyleResolver.h:
(WebCore::MatchRequest::MatchRequest):
Removed behaviorAtBoundary. Instead, ElementRuleCollector have the
state.
(MatchRequest):
(WebCore::StyleResolver::selectorFilter):
Added to obtain SelectorFilter in ElementRuleCollector's constructor.
(StyleResolver):
(MatchResult):
(WebCore::StyleResolver::State::State):
To pass ASSERT in StyleResolver::applyProperties, need to keep
m_regionForStyling.
(State):
(WebCore::StyleResolver::State::regionForStyling):
(WebCore::StyleResolver::State::useSVGZoomRules):
(WebCore::StyleResolver::hasSelectorForId):
(WebCore):
(WebCore::checkRegionSelector):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willMatchRule):
Removed StyleResolver from its parameter list. Instead, added
InspectorCSSOMWrappers and DocumentStyleSheetCollection.
- inspector/InspectorCSSAgent.h:
(WebCore):
(InspectorCSSAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willMatchRuleImpl):
- inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willMatchRule):
- 2:48 AM Changeset in webkit [145348] by
-
- 5 edits in trunk/Source/WebCore
XSSAuditor doesn't need a copy of the original document's body.
https://bugs.webkit.org/show_bug.cgi?id=111946
Reviewed by Darin Adler.
The XSSAuditor currently copies the original HTTP body of the document
that's being audited in order to include it into a violation report if
reflected XSS is detected. We don't actually need to do this, as we
have access to the original request information from inside the
XSSAuditorDelegate where the report is generated.
XSSAuditorDelegate::didBlockScript ASSERTs that it's running on the
main thread, so it should be safe to reach through the document's
loader to get that information directly, rather than passing it from
thread to thread via XSSInfo object properties.
- html/parser/XSSAuditor.h:
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::isSafeToSendToAnotherThread):
- html/parser/XSSAuditorDelegate.h:
(WebCore::XSSInfo::create):
(WebCore::XSSInfo::XSSInfo):
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSInfo::isSafeToSendToAnotherThread):
Drop the XSSInfo and XSSAuditor properties that held an
isolatedCopy of the the original HTTP body. Depending on the
document's size, this could be a significant savings.
(WebCore::XSSAuditorDelegate::didBlockScript):
Reach into the document's loader's original request in order to
grab the body as a String, and feed that into the violation report
object.
As a drive-by, this patch creates a FrameLoader* temporary
variable to minimize repetition in this area of the code. We use
the loader a few times, but should only have to grab it once.
- 2:40 AM Changeset in webkit [145347] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] REGRESSION: Closed Captions button not showing properly
https://bugs.webkit.org/show_bug.cgi?id=109871
Reviewed by Jer Noble.
No new tests - covered by existing tests.
Most of the patch was in the meantime covered by a patch to
https://bugs.webkit.org/show_bug.cgi?id=111109 .
This changes a static Chromium-only function name to be consistent with
parent class function names.
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaToggleClosedCaptionsButton):
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
Rename paintMediaClosedCaptionsButton to paintMediaToggleClosedCaptionsButton.
- 1:43 AM Changeset in webkit [145346] by
-
- 2 edits in trunk/Source/WebCore
RenderSnapshottedPlugIn paints in PaintPhaseBlockBackground instead of PaintPhaseForeground
https://bugs.webkit.org/show_bug.cgi?id=111962
<rdar://problem/13289335>
Reviewed by Dean Jackson.
RenderSnapshottedPlugIn should paint its snapshot during the foreground
painting phase, instead of BlockBackground, to match normal plugin painting.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::paint):
- 1:32 AM Changeset in webkit [145345] by
-
- 8 edits in trunk
[chromium] remove obsolete user gesture methods from WebFrame
https://bugs.webkit.org/show_bug.cgi?id=111696
Reviewed by Adam Barth.
Source/WebKit/chromium:
- public/WebFrame.h:
(WebFrame):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
- src/WebFrameImpl.cpp:
- src/WebFrameImpl.h:
(WebFrameImpl):
Tools:
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::handleInputEvent):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
- 1:30 AM Changeset in webkit [145344] by
-
- 13 edits in branches/chromium/1410
Merge 144626
transition properties can't be found in CSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=110011
Reviewed by Antti Koivisto.
Source/WebCore:
The previous approach for handling the unprefixing was to alias the
unprefixed properties with the prefixed ones in CSSPropertyNames.in.
Unfortunately it will alias the properties in the parsing code which will just
identically parse the two versions. This means that when we populate StylePropertySet
we do not have information whether we just parsed the prefixed, the
unprefixed properties or we parsed both. The patch takes another
approach by creating two distinct sets of properties (unprefixed and
prefixed). Each properties have their own id and we now handle them in
the parsing code as disctints properties and add both versions to the
declared style. In order to avoid properties getting out of sync,
this patch adds few facilities to StylePropertySet to update the
prefixed and the unprefixed entries. Finally the style resolution
happens only for the prefixed version (to limit the size of this patch)
and the unprefixed versions are not resolved. This is to avoid creating
the animation objects twice for the resolved style.
Test : transitions/transitions-parsing.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::addPropertyWithPrefixingVariant): Always add the
prefixed and the unprefixed property even if only one is specified.
(WebCore):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTransitionShorthand): Add both prefixed and
unprefixed longhands to the declarated style.
(WebCore::CSSParser::parseAnimationProperty):
- css/CSSParser.h:
(CSSParser):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSProperty.h:
(WebCore:: prefixingVariantForPropertyId): This function takes a given
property id and returns its prefixed or unprefixed id if it exists. If
not it returns the same id.
(WebCore):
- css/CSSPropertyNames.in:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::removeProperty): Remove
also the prefixed or unprefixed shorthand if it exists.
(WebCore):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet:: appendPrefixingVariantProperty):
(WebCore::StylePropertySet::setPrefixingVariantProperty): If it
exists a unprefixed or prefixed counterpart of the property we're
trying to set, then we update the other one.
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::mergeAndOverrideOnConflict):
- css/StylePropertySet.h:
(StylePropertySet):
- css/StylePropertyShorthand.cpp:
(WebCore::transitionShorthand):
(WebCore):
(WebCore::shorthandForProperty): Define the transitions unprefixed
longhands.
- css/StylePropertyShorthand.h:
(WebCore):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty): StyleBuilder will handle the
resolution and the creation of the animations for the style. As the
declarated style now contains declarations for the prefixed and
unprefixed property we do not want to resolve two times and create duplicate animations.
Therefore when we try to resolve the unprefixed version we just bail out.
LayoutTests:
Updated layout test to cover the bug.
- transitions/transitions-parsing-expected.txt:
- transitions/transitions-parsing.html:
TBR=alexis@webkit.org
Review URL: https://codereview.chromium.org/12470005
- 12:49 AM Changeset in webkit [145343] by
-
- 4 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- 12:16 AM Changeset in webkit [145342] by
-
- 7 edits3 adds in trunk
Web Inspector: [Elements] XSLT transformation result from the xml-stylesheet PI not rendered
https://bugs.webkit.org/show_bug.cgi?id=111313
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Frame document update upon XSL transformation was never instrumented.
This change instruments the Document::applyXSLTransform() method to that end.
Test: http/tests/inspector/styles/xsl-transformed.xml
- dom/Document.cpp:
(WebCore::Document::applyXSLTransform): Instrumented.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::frameDocumentUpdated): Invoked upon applyXSLTransform().
- inspector/InspectorDOMAgent.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::frameDocumentUpdatedImpl): Added.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didCommitLoad): Drive-by: simplified.
(WebCore::InspectorInstrumentation::frameDocumentUpdated): Added.
LayoutTests:
- http/tests/inspector/styles/resources/xsl-transformed.xsl: Added.
- http/tests/inspector/styles/xsl-transformed-expected.txt: Added.
- http/tests/inspector/styles/xsl-transformed.xml: Added.
Mar 10, 2013:
- 1:20 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:18 AM Changeset in webkit [145324] by
-
- 7 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK] When the WebProcess crashes, a signal should be emitted
https://bugs.webkit.org/show_bug.cgi?id=105180
Emit a "web-process-crashed" signal when the WebProcess crashes. This
is useful, for example, to show an error page in a web browser
like Chrome does.
Reviewed Carlos Garcia Campos.
Patch by Xan Lopez <Xan Lopez> on 2013-03-10
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
(processDidCrash):
(attachLoaderClientToView):
- UIProcess/API/gtk/WebKitWebContextPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init):
(webkitWebViewWebProcessCrashed):
- UIProcess/API/gtk/tests/TestWebExtensions.cpp:
(testWebExtensionGetTitle):
(webProcessCrashedCallback):
(testWebKitWebViewProcessCrashed):
(beforeAll):
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(methodCallCallback):
Mar 9, 2013:
- 11:29 PM Changeset in webkit [145341] by
-
- 2 edits in trunk/Source/WebKit2
WebPage::scaledSnapshotWithOptions returns a corrupt snapshot if you request a rect larger than the FrameView’s size
https://bugs.webkit.org/show_bug.cgi?id=111820
<rdar://problem/13375785>
Reviewed by Simon Fraser.
We have to clear the image - there could be area that won’t be painted by the FrameView,
or the FrameView could have a transparent background.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scaledSnapshotWithOptions):
- 11:13 PM Changeset in webkit [145340] by
-
- 6 edits6 adds in trunk
Implement inert subtrees needed for modal <dialog>
https://bugs.webkit.org/show_bug.cgi?id=110952
Reviewed by Hajime Morrita.
Source/WebCore:
This changes Node::disabled() to return true when a modal dialog is
open and the node is not in the dialog.
Reusing disabled for inertness is useful because then event
targeting and focus control automatically have the desired behavior:
inert nodes are skipped over.
Tests: fast/dom/HTMLDialogElement/closed-dialog-does-not-block-mouse-events.html
fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events.html
fast/dom/HTMLDialogElement/non-modal-dialog-does-not-block-mouse-events.html
- dom/Document.h:
(WebCore::Document::activeModalDialog): Returns the topmost element in the top layer.
Since now the only elements in the top layer are modal dialogs, it is the active modal dialog.
- dom/Node.cpp:
(WebCore):
(WebCore::Node::isInert): As per the spec, a node that is not an ancestor or descendant of the modal dialog is inert.
(WebCore::Node::disabled): Return false when inert.
- dom/Node.h:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::disabled): Fall back to the superclass so inert is taken into account.
LayoutTests:
- fast/dom/HTMLDialogElement/closed-dialog-does-not-block-mouse-events-expected.txt: Added.
- fast/dom/HTMLDialogElement/closed-dialog-does-not-block-mouse-events.html: Added.
- fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events-expected.txt: Added.
- fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events.html: Added.
- fast/dom/HTMLDialogElement/non-modal-dialog-does-not-block-mouse-events-expected.txt: Added.
- fast/dom/HTMLDialogElement/non-modal-dialog-does-not-block-mouse-events.html: Added.
- 10:42 PM Changeset in webkit [145339] by
-
- 2 edits in trunk/Tools
Add myself to committers.py
- 8:30 PM Changeset in webkit [145338] by
-
- 5 edits2 adds in trunk
Line breaking opportunities at the end of a text node are missed
https://bugs.webkit.org/show_bug.cgi?id=17427
Reviewed by Darin Adler.
Source/WebCore:
When initializing context for determining next break position,
reuse last two characters from previous text node(s) within block.
This additional state is stored in the current LazyLineBreakIterator
as an optimization to prevent having to add two new parameters to
isBreakable().
At present, this fixes only the ASCII shortcut code path, but
does not yet handle the non-ASCII path. Since the ASCII path is
the most performant critical, the handling of this latter path
will be addressed by webkit.org/b/105692.
Additionally test for case where last two characters context
is derived from distinct nodes, possibly with intervening empty
inline node(s).
Test: fast/text/line-break-between-text-nodes.html
- platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::lastCharacter):
(WebCore::LazyLineBreakIterator::secondToLastCharacter):
(WebCore::LazyLineBreakIterator::setLastTwoCharacters):
(WebCore::LazyLineBreakIterator::resetLastTwoCharacters):
(WebCore::LazyLineBreakIterator::updateLastTwoCharacters):
(LazyLineBreakIterator):
Add state variables to retain last two characters of previous text node(s)
for reuse when initializing nextBreakPosition<>() context.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
Record and reset retained last two characters of previous text node(s) as
appropriate.
- rendering/break_lines.cpp:
(WebCore::nextBreakablePosition):
Use state variables holding retained last two characters of previous text node(s)
for when initializing nextBreakPosition<>() context.
LayoutTests:
- fast/text/line-break-between-text-nodes-expected.html: Added.
- fast/text/line-break-between-text-nodes.html: Added.
- 6:21 PM Changeset in webkit [145337] by
-
- 2 edits in trunk/Source/WebKit2
Fix a typo in http://trac.webkit.org/changeset/145332.
Unreviewed.
ENABLE() doesn't use the WTF_ prefix.
- WebProcess/WebPage/WebPage.h:
- 6:19 PM Changeset in webkit [145336] by
-
- 3 edits in trunk/Source/WebCore
NetworkStorageSession leaks its CFURLStorageSessionRef
https://bugs.webkit.org/show_bug.cgi?id=111950
<rdar://problem/13384134>
Reviewed by Sam Weinig.
- platform/network/NetworkStorageSession.h:
Change the argument type of the constructor to a RetainPtr.
- platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::NetworkStorageSession): Changed
the argument type to a RetainPtr.
(WebCore::NetworkStorageSession::switchToNewTestingSession): Added
calls to adoptCF to adopt the value returned by wkCreatePrivateStorageSession.
(WebCore::NetworkStorageSession::createPrivateBrowsingSession): Ditto.
(WebCore::NetworkStorageSession::cookieStorage): Changed to use adoptCF
instead of the RetainPtr constructor with AdoptCF since the former is
far easier to read.
- 4:36 PM WebKit Team edited by
- (diff)
- 4:12 PM Changeset in webkit [145335] by
-
- 5 edits in trunk/Source/WebKit2
Add bundle API to get the current selection as a WKDOMRange
https://bugs.webkit.org/show_bug.cgi?id=111947
<rdar://problem/13205460>
Reviewed by Gavin Barraclough.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController selectedRange]):
Add new selectedRange property.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::frameWithSelection):
(WebKit::WebPage::currentSelectionAsRange):
- WebProcess/WebPage/WebPage.h:
Get the range by finding the frame that has a selection, and then normalizing it.
- 3:37 PM Changeset in webkit [145334] by
-
- 2 edits in trunk/Source/WebCore
Conformance Test 1.0.3 (Beta) function: bufferData undefined value failed.
https://bugs.webkit.org/show_bug.cgi?id=111641
Patch by Jason Anderssen <janderssen@gmail.com> on 2013-03-10
Reviewed by Dean Jackson.
The WebGL specification requires that a size of 0 is not valid. In javascript, passing in undefined
as a parameter to a long long is the same as passing in 0, so we must check for this incorrect
value and fail.
The test suite in Kronos 1.0.3 failed, test to verify conformance is as follows:
https://www.khronos.org/registry/webgl/sdk/tests/conformance/more/functions/bufferDataBadArgs.html.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::bufferData):
Synthesize error and returned if size is 0.
- 2:00 PM Changeset in webkit [145333] by
-
- 3 edits in trunk/Source/WebCore
SVGDocumentExtensions should use OwnPtr for pending resource maps.
<http://webkit.org/b/111943>
Reviewed by Anders Carlsson.
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removePendingResource):
(WebCore::SVGDocumentExtensions::removePendingResourceForRemoval):
(WebCore::SVGDocumentExtensions::markPendingResourcesForRemoval):
- svg/SVGDocumentExtensions.h:
(SVGDocumentExtensions):
- 1:40 PM Changeset in webkit [145332] by
-
- 8 edits in trunk/Source
Add a heuristic to determine the “primary” snapshotted plugin
https://bugs.webkit.org/show_bug.cgi?id=111932
<rdar://problem/13270208>
Reviewed by Dean Jackson.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
Forward didCommitLoad to WebPage. Move existing code that manipulated WebPage
itself during didCommitLoad into WebPage, where it belongs.
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad): Forward didFinishLoad to WebPage.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Initialize m_didFindPrimarySnapshottedPlugin to false.
(WebKit::WebPage::didCommitLoad): Move code from WebPageFrameLoaderClient.
Reset the flag that says we've already found a snapshotted plugin.
(WebKit::WebPage::didFinishLoad):
Call determinePrimarySnapshottedPlugIn when any frame finishes loading. We call this for subframes,
not just the main frame, in case the main frame loads with no "primary" plugins, but a subframe later loads with one.
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):
Attempt to find the primary snapshotted plugin on the page, by hit-testing a grid of points spaced 200px apart.
A plugin is considered if it is snapshotted and > 450x300. We scan vertically and left-to-right, only discarding
a previous candidate if another candidate is at least 110% the size of the previous candidate.
This tends to select plugins near the top left of the page, unless there is a significantly larger plugin elsewhere.
(WebKit::WebPage::resetPrimarySnapshottedPlugIn):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebCore.exp.in: Export a few things.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::classNameForShadowRoot): If we've been informed that we are the primary snapshotted plugin, add the 'primary' class.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Added
(WebCore::HTMLPlugInImageElement::updateSnapshotInfo): Hand classNameForShadowRoot our primary-ness.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): Add storage for m_isPrimarySnapshottedPlugIn.
- 12:57 PM Changeset in webkit [145331] by
-
- 5 edits in trunk/Source/WebCore
XSSAuditor doesn't need a copy of the original document URL.
https://bugs.webkit.org/show_bug.cgi?id=111944
Reviewed by Adam Barth.
When creating an XSSInfo object in response to detecting reflected XSS
on a page, the Auditor was passing in a copy of the document's
original URL for reporting. It doesn't look like we need this, as
XSSInfo's only consumer, XSSAuditorDelegate, runs on the main thread
with access to the document. We can obtain access to the same
information by reading the URL directly from the delegate's Document
object if and when we need it.
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
Read the document's URL directly in order to create a violation
report.
(WebCore::XSSInfo::isSafeToSendToAnotherThread):
- html/parser/XSSAuditorDelegate.h:
(WebCore::XSSInfo::create):
(WebCore::XSSInfo::XSSInfo):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::isSafeToSendToAnotherThread):
- html/parser/XSSAuditor.h:
Remove the copied original URL from both XSSInfo objects and the
XSSAuditor.
- 12:30 PM Changeset in webkit [145330] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r145039 and r145096.
http://trac.webkit.org/changeset/145039
http://trac.webkit.org/changeset/145096
https://bugs.webkit.org/show_bug.cgi?id=111945
broke find indicator updates with scrolling subframes
(Requested by thorton on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-10
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scroll):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
- 12:16 PM Changeset in webkit [145329] by
-
- 3 edits in trunk/Source/JavaScriptCore
SpeculativeJIT should use OwnPtr<SlowPathGenerator>.
<http://webkit.org/b/111942>
Reviewed by Anders Carlsson.
There's no need to include DFGSlowPathGenerator.h from the header as long as the destructor is out-of-line,
so let's use OwnPtr instead of raw pointers + deleteAllValues().
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::~SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::addSlowPathGenerator):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- 11:30 AM WebKitGTK/2.0.x edited by
- (diff)
- 10:41 AM Changeset in webkit [145328] by
-
- 3 edits in trunk/Source/WebKit2
WebPluginSiteDataManager should use OwnPtr.
<http://webkit.org/b/111940>
Reviewed by Anders Carlsson.
- UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::invalidate):
(WebKit::WebPluginSiteDataManager::getSitesWithData):
(WebKit::WebPluginSiteDataManager::clearSiteData):
(WebKit::WebPluginSiteDataManager::didGetSitesWithDataForAllPlugins):
(WebKit::WebPluginSiteDataManager::didClearSiteDataForAllPlugins):
- UIProcess/Plugins/WebPluginSiteDataManager.h:
(WebPluginSiteDataManager):
- 9:46 AM Changeset in webkit [145327] by
-
- 2 edits in trunk/Source/WebCore
GlyphMetricsMap should use OwnPtr.
<http://webkit.org/b/111937>
Reviewed by Anders Carlsson.
Use OwnPtr instead of raw pointer + deleteAllValues().
- platform/graphics/GlyphMetricsMap.h:
(GlyphMetricsMap):
(WebCore::::locatePageSlowCase):
- 9:09 AM Changeset in webkit [145326] by
-
- 3 edits in trunk/Source/WebCore
Allow iOS port to use InbandTextTrackPrivateAVF
https://bugs.webkit.org/show_bug.cgi?id=111933
Reviewed by Dean Jackson.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCue): Drive-by cleanup.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- 8:46 AM Changeset in webkit [145325] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0
Merge r144765 - Unreviewed build fix.
.:
- GNUmakefile.am: remove bad path for generate-feature-defines-files from EXTRA_DIST.
Tools:
- GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
- 8:38 AM WebKitGTK/2.0.x edited by
- (diff)
- 8:37 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:18 AM WebKit Team edited by
- Add myself to committers list (diff)
Mar 9, 2013:
- 2:48 PM Changeset in webkit [145323] by
-
- 16 edits8 deletes in trunk
Unreviewed, rolling out r145299.
http://trac.webkit.org/changeset/145299
https://bugs.webkit.org/show_bug.cgi?id=111928
compilation failure with recent clang
(DFGBackwardsPropagationPhase.cpp:132:35: error: comparison of
constant 10 with expression of type 'bool' is always false)
(Requested by thorton on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-09
Source/JavaScriptCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine):
- dfg/DFGBackwardsPropagationPhase.cpp: Removed.
- dfg/DFGBackwardsPropagationPhase.h: Removed.
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::run):
(CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::nodeFlagsAsString):
(DFG):
- dfg/DFGNodeFlags.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::isNotNegZero):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::isNotZero):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoForConstant):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoNonRecursive):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):
- dfg/DFGUnificationPhase.cpp:
(JSC::DFG::UnificationPhase::run):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(VariableAccessData):
LayoutTests:
- fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int-expected.txt: Removed.
- fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.html: Removed.
- fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers-expected.txt: Removed.
- fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.html: Removed.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js: Removed.
- fast/js/script-tests/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.js: Removed.
- 1:29 PM Changeset in webkit [145322] by
-
- 11 edits2 adds in trunk/Source/WebCore
Enable platform code to implement text track menu
https://bugs.webkit.org/show_bug.cgi?id=111924
Reviewed by Dean Jackson.
No new tests, the new code isn't enabled in any ports yet.
- WebCore.xcodeproj/project.pbxproj: Add PlatformTextTrack.h and PlatformTextTrackMenu.h.
- html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::createForJSConstructor): scheduleLoad -> scheduleDelayedAction.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Deal with scheduleLoad to scheduleDelayedAction rename.
(WebCore::HTMLMediaElement::parseAttribute): Ditto.
(WebCore::HTMLMediaElement::finishParsingChildren): Ditto.
(WebCore::HTMLMediaElement::insertedInto): Ditto.
(WebCore::HTMLMediaElement::scheduleDelayedAction): Ditto.
(WebCore::HTMLMediaElement::scheduleNextSourceChild): Ditto.
(WebCore::HTMLMediaElement::loadTimerFired): Ditto.
(WebCore::HTMLMediaElement::textTrackModeChanged): Notify platform menu of track change.
(WebCore::HTMLMediaElement::playInternal): Deal with scheduleLoad to scheduleDelayedAction rename.
(WebCore::HTMLMediaElement::pauseInternal): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerDidAddTrack): Ditto. Call addTrack() instead of appending
the track directly.
(WebCore::HTMLMediaElement::setSelectedTextTrack): Deal with platform menu changing the
selected track.
(WebCore::HTMLMediaElement::platformTextTracks): Return an array of PlatformTracks representing
the current text tracks.
(WebCore::HTMLMediaElement::notifyMediaPlayerOfTextTrackChanges): Notify the platform menu
that the list of text tracks has changed.
(WebCore::HTMLMediaElement::platformTextTrackMenu): Return the platform track menu, if any.
(WebCore::HTMLMediaElement::closeCaptionTracksChanged):
(WebCore::HTMLMediaElement::addTrack): Call addTrack() instead of appending the track directly.
(WebCore::HTMLMediaElement::removeTrack): Call closeCaptionTracksChanged.
(WebCore::HTMLMediaElement::addTextTrack): Call addTrack() instead of appending the track directly.
(WebCore::HTMLMediaElement::didAddTrack): Ditto.
(WebCore::HTMLMediaElement::didRemoveTrack): Deal with scheduleLoad to scheduleDelayedAction rename.
(WebCore::HTMLMediaElement::sourceWasAdded): Ditto.
(WebCore::HTMLMediaElement::clearMediaPlayer): Forget the platform track menu.
(WebCore::HTMLMediaElement::resume): Deal with scheduleLoad to scheduleDelayedAction rename.
- html/HTMLMediaElement.h:
- html/track/InbandTextTrack.h: scheduleLoad -> scheduleDelayedAction.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::platformTextTrack): Create a PlatformTextTrack.
- html/track/TextTrack.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::implementsTextTrackControls): New, player private passthrough.
(WebCore::MediaPlayer::textTrackMenu): Ditto.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
- platform/graphics/PlatformTextTrack.h: Added.
- platform/graphics/PlatformTextTrackMenu.h: Added.
- 1:27 PM Changeset in webkit [145321] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove deprecated flingStart.sourceDevice from WebGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=111866
Reviewed by James Robinson.
- public/WebInputEvent.h:
- 11:43 AM Changeset in webkit [145320] by
-
- 2 edits in trunk/Source/WebCore
Video size calculated incorrectly when PLUGIN_PROXY_FOR_VIDEO
https://bugs.webkit.org/show_bug.cgi?id=111912
Reviewed by Dean Jackson.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateSizes): We use RenderPart when
PLUGIN_PROXY_FOR_VIDEO is defined, not RenderVideo.
- 8:54 AM Changeset in webkit [145319] by
-
- 6 edits in trunk/Source/WebKit/chromium
[chromium] Set the Helper Plugin's URL to that of the host document.
https://bugs.webkit.org/show_bug.cgi?id=111913
This allows content settings, etc. to be based on the document hosting
the element that requested the Helper Plugin.
Patch by David Dorwin <ddorwin@chromium.org> on 2013-03-09
Reviewed by Adam Barth.
- src/WebHelperPluginImpl.cpp:
(WebKit::writeDocument):
(WebKit::WebHelperPluginImpl::initialize):
(WebKit::WebHelperPluginImpl::initializePage):
- src/WebHelperPluginImpl.h:
(WebKit):
(WebHelperPluginImpl):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::createHelperPlugin):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::createHelperPlugin):
- src/WebViewImpl.h:
(WebViewImpl):
- 8:34 AM Changeset in webkit [145318] by
-
- 2 edits in trunk/Source/WebCore
Fix offset handling in GStreamer WebKitWebSource.
https://bugs.webkit.org/show_bug.cgi?id=111888
Patch by Sebastian Dröge <sebastian.droege@collabora.co.uk> on 2013-03-09
Reviewed by Philippe Normand.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcSeekDataCb):
(StreamingClient::didReceiveData):
The offset handling in WebKitWebSource was completely wrong
before and caused wrong offsets to be set on the GStreamer buffers
after a seek.
Apart from that there was also a race condition that happens
when a downstream element causes seeks in very short succession
and is switching between two different parts of the stream.
- 4:45 AM Changeset in webkit [145317] by
-
- 1 edit9 adds in trunk/LayoutTests
Add tests for opening the picker with the f4 key
https://bugs.webkit.org/show_bug.cgi?id=111811
Reviewed by Kent Tamura.
- platform/chromium-win/fast/forms/calendar-picker/date-open-picker-with-f4-key-expected.txt: Added.
- platform/chromium-win/fast/forms/calendar-picker/date-open-picker-with-f4-key.html: Added.
- platform/chromium-win/fast/forms/calendar-picker/datetimelocal-open-picker-with-f4-key-expected.txt: Added.
- platform/chromium-win/fast/forms/calendar-picker/datetimelocal-open-picker-with-f4-key.html: Added.
- platform/chromium-win/fast/forms/calendar-picker/month-open-picker-with-f4-key-expected.txt: Added.
- platform/chromium-win/fast/forms/calendar-picker/month-open-picker-with-f4-key.html: Added.
- platform/chromium-win/fast/forms/calendar-picker/week-open-picker-with-f4-key-expected.txt: Added.
- platform/chromium-win/fast/forms/calendar-picker/week-open-picker-with-f4-key.html: Added.
- 4:43 AM Changeset in webkit [145316] by
-
- 10 edits in trunk
Month transition animation is missing in some places
https://bugs.webkit.org/show_bug.cgi?id=111908
Reviewed by Kent Tamura.
Source/WebCore:
Month transition animation was missing when navigating using keyboard
shortcuts and when navigation was trigger by selecting.
Added tests to calendar-picker/*-picker-key-operations.html.
- Resources/pagepopups/calendarPicker.js:
(Animator): Added annotations.
(Animator.prototype.isRunning): Returns true of the animation is running. Used by test.
(ScrollView.prototype.scrollAnimator): Returns the scroll animator. Used by test.
(CalendarPicker):
(CalendarPicker.prototype.onYearListViewDidSelectMonth): Use CalendarPicker.NavigationBehavior enum instead of bool.
(CalendarPicker.prototype.setSelection): Ditto.
(CalendarPicker.prototype._moveHighlight): Ditto.
(CalendarPicker.prototype.onCalendarTableKeyDown): Ditto.
(CalendarPicker.prototype.onBodyKeyDown): Ditto.
LayoutTests:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
(isCalendarTableScrollingWithAnimation):
- platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html:
- 3:27 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:25 AM Changeset in webkit [145315] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk
Merge r144055 - REGRESSION (r143619): Crashes in three layout tests
https://bugs.webkit.org/show_bug.cgi?id=110588
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-26
Reviewed by Gustavo Noronha Silva.
Source/WebKit/gtk:
Guard against null main resource identifiers. The main resource
identifier can be null at various times during the load. A null
identifier is never equal to the ones we are looking to remove.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidFinishLoading): Use the new webkitWebViewRemoveSubresource helper.
(WebKit::FrameLoaderClient::dispatchDidFailLoading): ditto.
- webkit/webkitwebview.cpp:
(webkitWebViewRemoveSubresource): Added this helper which removes a subresource, but
never touches the main resource. This is adapted from the old method, for which the
main resource branch was dead code.
- webkit/webkitwebviewprivate.h: Update the method list.
- 3:20 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:19 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:17 AM Changeset in webkit [145314] by
-
- 5 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r145244 - [WK2][GTK] Invalid request returned by webkit_download_get_request if called before download starts
https://bugs.webkit.org/show_bug.cgi?id=111574
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-08
Reviewed by Alexey Proskuryakov.
webkit_download_get_request() creates the WebKitURIRequest object
on demand using the ResourceRequest from the DownloadProxy. The
ResourceRequest of the DownloadProxy is set in
DownloadProxy::didStart(), so if we call
webkit_download_get_request() before didStart we return an invalid
WebKitURIRequest created from a NULL ResourceRequest. This is not
a problem for downloads started in the web process, because we
create the WebKitDownload after DownloadProxy::didStart(). For
downloads started manually with webkit_web_context_download_uri()
we need to create download object with the ResourceRequest passed
to the DownloadProxy.
- UIProcess/API/gtk/WebKitDownload.cpp:
(webkitDownloadCreateForRequest): New helper function for
downloads started manually to created them with a given
ResourceRequest.
- UIProcess/API/gtk/WebKitDownloadPrivate.h:
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextStartDownload): Use
webkitDownloadCreateForRequest().
- UIProcess/API/gtk/tests/TestDownloads.cpp:
(testDownloadLocalFile):
(testDownloadLocalFileError):
(testDownloadRemoteFile):
(testDownloadRemoteFileError):
(testPolicyResponseDownload):
- 3:10 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:09 AM Changeset in webkit [145313] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r145202 - [GTK] Memory leak in webkit_web_view_load_request() in WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=111160
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-08
Reviewed by Benjamin Poulain.
leakRef() is used for the returned PassRefPtr without taking the
ownership of the leaked ref.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_request): Use RefPtr local variable.
- 3:08 AM Changeset in webkit [145312] by
-
- 2 edits in trunk/Source/WebCore
Can't build w/o accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=111891
Patch originally came from Tobias Mueller <tobiasmue@gnome.org>
Unreviewed build fix for platforms without ACCELERATED_COMPOSITING enabled, which
broke in r145057.
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::~PseudoElement): Wrap the call to pseudoElementDestroyed in
USE(ACCELERATED_COMPOSITING)
- 3:05 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:04 AM Changeset in webkit [145311] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Merge r145307 - [GTK] Versions.m4 is missing some key dependencies version definitions
https://bugs.webkit.org/show_bug.cgi?id=111903
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-09
Reviewed by Carlos Garcia Campos.
- Source/autotools/Versions.m4: Add missing required version
definitions.
- 3:00 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:58 AM Changeset in webkit [145310] by
-
- 5 edits in releases/WebKitGTK/webkit-2.0
Merge r145199 - [GTK] Remove media stream support from the configuration options
https://bugs.webkit.org/show_bug.cgi?id=111813
Reviewed by Philippe Normand.
Remove the media-stream configuration flag. The feature is incomplete and
thus unsupported, so it really shouldn't be possible to enable it.
- Source/autotools/PrintBuildConfiguration.m4:
- Source/autotools/ReadCommandLineArguments.m4:
- Source/autotools/SetupAutomake.m4:
- Source/autotools/SetupWebKitFeatures.m4:
- 2:54 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:52 AM Changeset in webkit [145309] by
-
- 10 edits in releases/WebKitGTK/webkit-2.0
Merge r145084 - [GTK] Limit the supported compilers to GCC >= 4.7 and Clang >= 3.0
https://bugs.webkit.org/show_bug.cgi?id=109932
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-03-07
Reviewed by Martin Robinson.
.:
- Source/autotools/CheckSystemAndBasicDependencies.m4: Strictly check for one of the two compilers.
- Source/autotools/SetupCompilerFlags.m4: Set up C++11-specific compiler flags. Force the C99 standard for the C code.
Use the -Qunused-arguments flag when using Clang, it reduces irrelevant errors when using ccache.
Source/WebCore:
- GNUmakefile.am: Replace references to SYMBOL_VISIBILITY_INLINES and SYMBOL_VISIBILITY variables with the actual flags.
They are now available by default due to the limited set of supported compilers.
- bindings/gobject/GNUmakefile.am: Ditto.
Source/WebKit/gtk:
- GNUmakefile.am: Replace references to SYMBOL_VISIBILITY_INLINES and SYMBOL_VISIBILITY variables with the actual flags.
They are now available by default due to the limited set of supported compilers.
Source/WebKit2:
- GNUmakefile.am: Replace references to SYMBOL_VISIBILITY_INLINES and SYMBOL_VISIBILITY variables with the actual flags.
They are now available by default due to the limited set of supported compilers.
- 1:50 AM Changeset in webkit [145308] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][WK2] Fix compilation warning missing-field-initializers in webkit-2.0 stable branch
https://bugs.webkit.org/show_bug.cgi?id=111863
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-09
Reviewed by Benjamin Poulain.
- UIProcess/API/gtk/WebKitUIClient.cpp:
(attachUIClientToView): Include missing initializer for pluginLoadPolicy.
- 1:37 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:31 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:30 AM Changeset in webkit [145307] by
-
- 2 edits in trunk
[GTK] Versions.m4 is missing some key dependencies version definitions
https://bugs.webkit.org/show_bug.cgi?id=111903
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-09
Reviewed by Carlos Garcia Campos.
- Source/autotools/Versions.m4: Add missing required version
definitions.
- 1:30 AM Changeset in webkit [145306] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Merge r144222 - [GTK] Disable MathML support in release builds
https://bugs.webkit.org/show_bug.cgi?id=110981
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-02-27
Reviewed by Martin Robinson.
- Source/autotools/SetupWebKitFeatures.m4: Disable the MathML support in release builds
as the code is not yet deemed production-ready.
Mar 8, 2013:
- 10:40 PM Changeset in webkit [145305] by
-
- 5 edits8 adds in trunk
REGRESSION(r140907): Incorrect baseline for cells with media content during load
https://bugs.webkit.org/show_bug.cgi?id=108357
Reviewed by Julien Chaffraix.
Source/WebCore:
If a cell has replaced content, the intrinsic height of its content can change between layouts. If that's the case then the intrinsic padding we used
for layout (the padding required to push the contents of the cell down to the row's baseline) is included in the new height and baseline and makes both
of them wrong. So if a cell's content's intrinsic height has changed push the new content up into the intrinsic padding and relayout so that the rest of
table and row layout can use the correct baseline and height for this cell.
Tests: fast/css/vertical-align-baseline-rowspan-012.html
http/tests/css/vertical-align-baseline-after-image-load-2.html
http/tests/css/vertical-align-baseline-after-image-load-3.html
http/tests/css/vertical-align-baseline-after-image-load.html
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::layout):
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::isBaselineAligned):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
LayoutTests:
- fast/css/vertical-align-baseline-rowspan-012-expected.html: Added.
- fast/css/vertical-align-baseline-rowspan-012.html: Added.
- http/tests/css/vertical-align-baseline-after-image-load-2-expected.html: Added.
- http/tests/css/vertical-align-baseline-after-image-load-2.html: Added.
- http/tests/css/vertical-align-baseline-after-image-load-3-expected.html: Added.
- http/tests/css/vertical-align-baseline-after-image-load-3.html: Added.
- http/tests/css/vertical-align-baseline-after-image-load-expected.html: Added.
- http/tests/css/vertical-align-baseline-after-image-load.html: Added.
- 10:37 PM Changeset in webkit [145304] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION: Intermittent crash in SpeechSynthesis::didFinishSpeaking
https://bugs.webkit.org/show_bug.cgi?id=111613
Reviewed by Ryosuke Niwa.
This crash happens when the mock synthesizer utterance variable gets cleared
before the speakingFinished timer happens. I don't see how that could happen
but I was able to make a similar problem happen when cancel is called twice.
This adds in a few more asserts and common sense checks. I'm hoping it will
illuminate the problem further.
- platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):
(WebCore::PlatformSpeechSynthesizerMock::cancel):
- 9:54 PM Changeset in webkit [145303] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX: Make WebCore link for iOS
- WebCore.exp.in:
- Add ENABLE(RUBBER_BAND) for FrameView::setWantsLayerForTopOverHangArea(bool) and FrameView::setWantsLayerForBottomOverHangArea(bool).
- Move FloatPoint::FloatPoint(_NSPoint const&) to !PLATFORM(IOS) section.
- 9:54 PM Changeset in webkit [145302] by
-
- 5 edits in trunk/Websites/bugs.webkit.org
(CVE-2013-0786) [SECURITY] build_subselect() leaks the existence of products and components you cannot access
<https://bugzilla.mozilla.org/show_bug.cgi?id=824399>
<exp2://Ticket/14465628>
Applied "v5 patch, 3.6" to bugs.webkit.org.
- Bugzilla/Config/GroupSecurity.pm:
(get_param_list):
- buglist.cgi:
- report.cgi:
- template/en/default/admin/params/groupsecurity.html.tmpl:
- 9:54 PM Changeset in webkit [145301] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
(CVE-2013-0785) [SECURITY] XSS in show_bug.cgi when using an invalid page format
<https://bugzilla.mozilla.org/show_bug.cgi?id=842038>
<exp2://Ticket/14465628>
Applied "patch for 3.6 and 4.0, v1" to bugs.webkit.org.
- Bugzilla/Template.pm:
(get_format):
- show_bug.cgi:
- 9:20 PM May 2013 Meeting edited by
- Add myself to pixel->ref test conversion Hackathon; also add an option … (diff)
- 9:11 PM May 2013 Meeting edited by
- Rename a topic. (diff)
- 9:04 PM May 2013 Meeting edited by
- Added "Reduce the amount of knowledge you need in order to contribute … (diff)
- 8:50 PM May 2013 Meeting edited by
- (diff)
- 8:31 PM Changeset in webkit [145300] by
-
- 9 edits in trunk
Unreviewed, rolling out r145254, r145264, and r145288.
http://trac.webkit.org/changeset/145254
http://trac.webkit.org/changeset/145264
http://trac.webkit.org/changeset/145288
https://bugs.webkit.org/show_bug.cgi?id=111917
Test breakage hints at conceptual unsoundness (Requested by ap
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-08
Source/WebKit2:
- NetworkProcess/SchedulableLoader.cpp:
(WebKit::SchedulableLoader::invalidateSandboxExtensions):
- Shared/Downloads/Download.cpp:
(WebKit::Download::didFinish):
(WebKit::Download::didFail):
(WebKit::Download::didCancel):
- Shared/SandboxExtension.h:
(SandboxExtension):
(WebKit::SandboxExtension::invalidate):
- Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::stop):
- Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::SandboxExtension):
(WebKit::SandboxExtension::invalidate):
(WebKit::SandboxExtension::consume):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
(WebKit::WebPage::SandboxExtensionTracker::invalidate):
(WebKit::WebPage::SandboxExtensionTracker::setPendingProvisionalSandboxExtension):
(WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad):
(WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):
LayoutTests:
- platform/mac-wk2/TestExpectations:
- 6:51 PM Changeset in webkit [145299] by
-
- 16 edits8 adds in trunk
DFG overflow check elimination is too smart for its own good
https://bugs.webkit.org/show_bug.cgi?id=111832
Source/JavaScriptCore:
Reviewed by Oliver Hunt and Gavin Barraclough.
This improves overflow check elimination in three ways:
1) It reduces the amount of time the compiler will spend doing it.
2) It fixes bugs where overflow check elimination was overzealous. Precisely, for a binary operation
over @a and @b where both @a and @b will type check that their inputs (@a->children, @b->children)
are int32's and then perform a possibly-overflowing operation, we must be careful not to assume
that @a's non-int32 parts don't matter if at the point that @a runs we have as yet not proved that
@b->children are int32's and that hence @b might produce a large enough result that doubles would
start chopping low bits. The specific implication of this is that for a binary operation to not
propagate that it cares about non-int32 parts (NodeUsedAsNumber), we must prove that at least one
of the inputs is guaranteed to produce a result within 232 and that there won't be a tower of such
operations large enough to ultimately produce a double greater than 252 (roughly). We achieve the
latter by disabling this optimization for very large basic blocks. It's noteworthy that blocks that
large won't even make it into the DFG currently.
3) It makes the overflow check elimination more precise for cases where the inputs to an Add or Sub
are the outputs of a bit-op. For example in (@a + (@b | 0)) | 0, we don't need to propagate
NodeUsedAsNumber to either @a or @b.
This is neutral on V8v7 and a slight speed-up on compile time benchmarks.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine):
- dfg/DFGBackwardsPropagationPhase.cpp: Added.
(DFG):
(BackwardsPropagationPhase):
(JSC::DFG::BackwardsPropagationPhase::BackwardsPropagationPhase):
(JSC::DFG::BackwardsPropagationPhase::run):
(JSC::DFG::BackwardsPropagationPhase::isNotNegZero):
(JSC::DFG::BackwardsPropagationPhase::isNotZero):
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwoForConstant):
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwoNonRecursive):
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::BackwardsPropagationPhase::mergeDefaultFlags):
(JSC::DFG::BackwardsPropagationPhase::propagate):
(JSC::DFG::performBackwardsPropagation):
- dfg/DFGBackwardsPropagationPhase.h: Added.
(DFG):
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::clearIsLoadedFrom):
(CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::dumpNodeFlags):
(DFG):
- dfg/DFGNodeFlags.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGUnificationPhase.cpp:
(JSC::DFG::UnificationPhase::run):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsLoadedFrom):
(VariableAccessData):
(JSC::DFG::VariableAccessData::setIsLoadedFrom):
(JSC::DFG::VariableAccessData::isLoadedFrom):
LayoutTests:
Reviewed by Oliver Hunt and Gavin Barraclough.
- fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int-expected.txt: Added.
- fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.html: Added.
- fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers-expected.txt: Added.
- fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js: Added.
(foo):
(bar):
- fast/js/script-tests/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.js: Added.
(foo):
(bar):
- 6:29 PM Changeset in webkit [145298] by
-
- 13 edits16 adds2 deletes in trunk/LayoutTests
Update chromium baselines for transforms/3d/point-mapping
- platform/chromium-linux-x86/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png:
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
- platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
- platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
- platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
- platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png:
- platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
- platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
- platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- platform/chromium-win-xp/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png:
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Removed.
- platform/chromium/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Removed.
- 5:48 PM Changeset in webkit [145297] by
-
- 5 edits in trunk
[CSS Grid Layout] Resolve grid-{end|after} integer against the end|after edge
https://bugs.webkit.org/show_bug.cgi?id=111885
Reviewed by Tony Chang.
Source/WebCore:
The current code resolves grid-end (resp. grid-after) <integer>'s format against the start
(resp. before) axis. The specification changed so that they are resolved against their matching
axis.
Test: fast/css-grid-layout/grid-auto-flow-resolution.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::maximumIndexInDirection):
Updated the code to do the grid sizing measurement without resolveGridPositionsFromStyle. That's required
as resolveGridPositionsFromStyle requires the grid to be sized.
(WebCore::RenderGrid::placeItemsOnGrid):
Added a comment about not recomputing after grid growth. This issue was raised to www-style
(http://lists.w3.org/Archives/Public/www-style/2013Mar/0182.html).
(WebCore::RenderGrid::resolveGridPositionsFromStyle):
Added an ASSERT now that we don't call it during grid construction. Also added some code to pass
the side of the GridPosition we give to resolveGridPositionFromStyle.
(WebCore::RenderGrid::resolveGridPositionFromStyle):
Updated the code to resolve the grid position against the right side.
- rendering/RenderGrid.h:
Added GridPositionSide and updated resolveGridPositionFromStyle's signature.
LayoutTests:
- fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
Moar passing tests!
- 5:37 PM Changeset in webkit [145296] by
-
- 17 edits14 deletes in trunk
Unreviewed, rolling out r142015.
http://trac.webkit.org/changeset/142015
https://bugs.webkit.org/show_bug.cgi?id=111904
The change caused 2 major regressions (bug 111091 and bug
111595) and Pravin doesn't have time to investigate them
(Requested by jchaffraix on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-08
Source/WebCore:
- dom/Node.cpp:
(WebCore::Node::diff):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::childBecameNonInline):
(WebCore):
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::childBecameNonInline):
(RenderBoxModelObject):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::childBecameNonInline):
(WebCore):
- rendering/RenderInline.h:
(RenderInline):
- rendering/RenderObject.cpp:
(WebCore):
(WebCore::RenderObject::handleDynamicFloatPositionChange):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::styleDidChange):
- rendering/RenderObject.h:
(RenderObject):
LayoutTests:
- fast/css/first-letter-removed-added-expected.txt:
- fast/dynamic/absolute-positioned-to-static-positioned-expected.txt: Removed.
- fast/dynamic/absolute-positioned-to-static-positioned.html: Removed.
- fast/dynamic/floating-to-non-floating-expected.txt: Removed.
- fast/dynamic/floating-to-non-floating.html: Removed.
- fast/dynamic/non-floating-to-floating-expected.txt: Removed.
- fast/dynamic/non-floating-to-floating.html: Removed.
- fast/dynamic/resources/helper-bug91665.js: Removed.
- fast/dynamic/resources/style-bug91665.css: Removed.
- fast/dynamic/static-positioned-to-absolute-positioned-expected.txt: Removed.
- fast/dynamic/static-positioned-to-absolute-positioned.html: Removed.
- fullscreen/full-screen-fixed-pos-parent-expected.txt:
- platform/chromium-mac/fast/repaint/absolute-position-change-containing-block-expected.png:
- platform/chromium-mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png:
- platform/chromium-win/fast/dynamic/002-expected.txt:
- platform/chromium/fast/dynamic/002-expected.txt:
- platform/chromium/fast/repaint/absolute-position-change-containing-block-expected.png: Removed.
- platform/chromium/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Removed.
- platform/mac/fast/dynamic/002-expected.txt:
- platform/mac/fast/repaint/absolute-position-change-containing-block-expected.png: Removed.
- platform/mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Removed.
- 5:31 PM Changeset in webkit [145295] by
-
- 6 edits in trunk
Don't snapshot Java plugins
https://bugs.webkit.org/show_bug.cgi?id=111899
Reviewed by Tim Horton.
Top-level:
Export MIMETypeRegistry::isJavaAppletMIMEType symbol.
- Source/autotools/symbols.filter:
Source/WebCore:
Export MIMETypeRegistry::isJavaAppletMIMEType symbol.
- WebCore.exp.in:
Source/WebKit2:
If the plugin is Java, return true from shouldAlwaysAutoStart.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::shouldAlwaysAutoStart): Check the mimetype for Java.
- 5:31 PM Changeset in webkit [145294] by
-
- 2 edits in trunk/Tools
Cleanup: Remove dead code.
https://bugs.webkit.org/show_bug.cgi?id=111900
Reviewed by Dirk Pranke.
Treemap overrides a global function that used to be in
dashboard_base, but was removed months ago in
https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
no caller.
- TestResultServer/static-dashboards/treemap.html:
- 5:29 PM Changeset in webkit [145293] by
-
- 4 edits in trunk
[HTMLTemplateElement] processTemplateEndTag() needs to check for template in html scope
https://bugs.webkit.org/show_bug.cgi?id=111880
Reviewed by Eric Seidel.
Source/WebCore:
Currently, </template> handling exits with an error if there is not a template tag "in scope"
which will be true if there is a table (for instance) below a template. This makes it so that
the search (correctly) examines the entire element stack.
Tests added to html5lib testing library.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processTemplateEndTag):
LayoutTests:
- html5lib/resources/template.dat:
- 5:06 PM Changeset in webkit [145292] by
-
- 19 edits2 adds in trunk/Source/WebCore
BackgroundHTMLParser should be able to atomize well-known strings
https://bugs.webkit.org/show_bug.cgi?id=107337
Reviewed by Adam Barth.
Testing this patch easily requires applying bug 107236 locally
to remove all the rendering noise from Parser/html-threaded-parser.html.
This patch adds a new class HTMLIdentifier which allows us to avoid
allocating strings for known tag/attribute names from HTMLNames.
There is still a lot of meat on this bone, but I think it's important to
land something "smallish" to start and iterate from there.
This took Parser/html-threaded-parser.html from:
median= 443.726500002 ms, stdev= 7.25002679952 ms, min= 430.244000047 ms, max= 455.511000007 ms
to:
median= 427.849500004 ms, stdev= 9.96967058292 ms, min= 417.914000049 ms, max= 461.528000014 ms
on my MBP.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- html/parser/AtomicHTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::tokenExitsForeignContent):
(WebCore::tokenExitsSVG):
(WebCore::tokenExitsMath):
(WebCore::BackgroundHTMLParser::simulateTreeBuilder):
- html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::scan):
- html/parser/CSSPreloadScanner.h:
(WebCore):
(CSSPreloadScanner):
- html/parser/CompactHTMLToken.cpp:
(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::CompactHTMLToken):
- html/parser/CompactHTMLToken.h:
(WebCore::CompactHTMLToken::Attribute::Attribute):
(Attribute):
(WebCore::CompactHTMLToken::data):
(WebCore::CompactHTMLToken::publicIdentifier):
(CompactHTMLToken):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::startBackgroundParser):
- html/parser/HTMLIdentifier.cpp: Added.
(WebCore):
(WebCore::identifierTable):
(WebCore::HTMLIdentifier::hasIndex):
(WebCore::HTMLIdentifier::findIndex):
(WebCore::nameForIndex):
(WebCore::HTMLIdentifier::asString):
(WebCore::HTMLIdentifier::asStringImpl):
(WebCore::HTMLIdentifier::addNames):
(WebCore::HTMLIdentifier::init):
- html/parser/HTMLIdentifier.h: Added.
(WebCore):
(HTMLIdentifier):
(WebCore::HTMLIdentifier::HTMLIdentifier):
(WebCore::HTMLIdentifier::isSafeToSendToAnotherThread):
- html/parser/HTMLParserIdioms.cpp:
(WebCore::threadSafeEqual):
(WebCore::threadSafeMatch):
- html/parser/HTMLParserIdioms.h:
(WebCore):
(WebCore::threadSafeHTMLNamesMatch):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::tagIdFor):
(WebCore::TokenPreloadScanner::StartTagScanner::match):
(TokenPreloadScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
- html/parser/HTMLPreloadScanner.h:
- 4:56 PM Changeset in webkit [145291] by
-
- 6 edits in tags/Safari-537.33.2/Source
Merged r145247. <rdar://problem/13383659>
- 4:53 PM Changeset in webkit [145290] by
-
- 4 edits in tags/Safari-537.33.2/Source
Versioning.
- 4:49 PM Changeset in webkit [145289] by
-
- 1 copy in tags/Safari-537.33.2
New Tag.
- 4:42 PM Changeset in webkit [145288] by
-
- 2 edits in trunk/LayoutTests
Add a failing test expectation per bug 111901.
- platform/mac-wk2/TestExpectations:
- 4:29 PM Changeset in webkit [145287] by
-
- 3 edits3 copies in trunk/LayoutTests
Update a few more chromium baselines.
- platform/chromium-mac-lion/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
- platform/chromium-mac/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
- platform/chromium-win-xp/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
- platform/chromium-win-xp/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt:
- 4:17 PM Changeset in webkit [145286] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 4:15 PM Changeset in webkit [145285] by
-
- 1 copy in tags/Safari-536.29.6
New Tag.
- 4:15 PM Changeset in webkit [145284] by
-
- 5 edits in branches/safari-534.59-branch/Source
Versioning.
- 4:14 PM Changeset in webkit [145283] by
-
- 1 copy in tags/Safari-534.59.2
New Tag.
- 4:10 PM Changeset in webkit [145282] by
-
- 3 edits in branches/safari-536.29-branch/Source/WebKit2
Windows build fix #2.
<rdar://problem/13380471> REGRESSION: Debussy Windows broken after merging http://trac.webkit.org/changeset/144831
Reviewed by Roger Fong.
- win/WebKit2.def:
- win/WebKit2.vcproj:
- 3:57 PM Changeset in webkit [145281] by
-
- 2 edits in branches/safari-536.29-branch/Source/WebKit2
Windows build fix.
<rdar://problem/13380471> REGRESSION: Debussy Windows broken after merging http://trac.webkit.org/changeset/144831
Reviewed by Roger Fong.
- win/WebKit2.def:
- 3:47 PM Changeset in webkit [145280] by
-
- 3 edits in trunk/Source/WebCore
Check to ensure MultisampleRenderbuffer creation succeeds
https://bugs.webkit.org/show_bug.cgi?id=111780
Patch by Brandon Jones <bajones@google.com> on 2013-03-08
Reviewed by Dean Jackson.
On OSX systems using AMD graphics chips the allocation of large
Multisample Renderbuffers in Chromium would fail without any indication
of failure. Attempting to draw to the buffer resulted in garbage being
rendered onscreen. This could be reproduced by opening a full-page
WebGL app and pressing (Command + "-") several times. This patch adds an
additional check during DrawingBuffer resize to verify that the resized
buffer is valid.
- platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore):
(WebCore::DrawingBuffer::checkBufferIntegrity):
(WebCore::DrawingBuffer::reset):
- platform/graphics/gpu/DrawingBuffer.h:
(DrawingBuffer):
- 3:45 PM Changeset in webkit [145279] by
-
- 19 edits3 deletes in trunk
Implemented new API for RTCStatsReport object.
https://bugs.webkit.org/show_bug.cgi?id=110333
Source/Platform:
Patch by Harald Alvestrand <hta@chromium.org> on 2013-03-08
Reviewed by Adam Barth.
- chromium/public/WebRTCStatsResponse.h:
(WebKit::WebRTCStatsResponse::WebRTCStatsResponse):
(WebRTCStatsResponse):
Source/WebCore:
Removed RTCStatsElement object, moved its interface to
RTCStatsReport. Preserved some interfaces for
backwards compatibility; will be removed in a later patch.
Patch by Harald Alvestrand <hta@chromium.org> on 2013-03-08
Reviewed by Adam Barth.
Tested by extensions to RTCPeerConnection-stats test.
- Modules/mediastream/RTCStatsElement.cpp: Removed.
- Modules/mediastream/RTCStatsElement.h: Removed.
- Modules/mediastream/RTCStatsElement.idl: Removed.
- Modules/mediastream/RTCStatsReport.cpp:
(WebCore::RTCStatsReport::create):
(WebCore::RTCStatsReport::RTCStatsReport):
(WebCore):
(WebCore::RTCStatsReport::names):
(WebCore::RTCStatsReport::local):
(WebCore::RTCStatsReport::remote):
(WebCore::RTCStatsReport::addStatistic):
(WebCore::RTCStatsReport::addElement):
- Modules/mediastream/RTCStatsReport.h:
(RTCStatsReport):
(WebCore::RTCStatsReport::timestamp):
(WebCore::RTCStatsReport::id):
(WebCore::RTCStatsReport::stat):
- Modules/mediastream/RTCStatsReport.idl:
- Modules/mediastream/RTCStatsResponse.cpp:
(WebCore::RTCStatsResponse::namedItem):
(WebCore):
(WebCore::RTCStatsResponse::addReport):
(WebCore::RTCStatsResponse::addStatistic):
- Modules/mediastream/RTCStatsResponse.h:
(RTCStatsResponse):
- Modules/mediastream/RTCStatsResponse.idl:
- WebCore.gypi:
- platform/chromium/support/WebRTCStatsResponse.cpp:
(WebKit::WebRTCStatsResponse::addReport):
(WebKit):
(WebKit::WebRTCStatsResponse::addStatistic):
(WebKit::WebRTCStatsResponse::addElement):
- platform/mediastream/RTCStatsResponseBase.h:
(RTCStatsResponseBase):
Tools:
Patch by Harald Alvestrand <hta@chromium.org> on 2013-03-08
Reviewed by Adam Barth.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
(WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
LayoutTests:
Patch by Harald Alvestrand <hta@chromium.org> on 2013-03-08
Reviewed by Adam Barth.
- fast/mediastream/RTCPeerConnection-stats-expected.txt:
- fast/mediastream/RTCPeerConnection-stats.html:
- 3:40 PM Changeset in webkit [145278] by
-
- 4 edits7 copies36 adds in trunk/LayoutTests
Chromium rebaselines and expectations updates.
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium-linux/compositing/tiling/rotated-tiled-clamped-expected.png: Added.
- platform/chromium-linux/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac/compositing/tiling/rotated-tiled-clamped-expected.png: Added.
- platform/chromium-mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Added.
- platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.png: Added.
- platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.png: Added.
- platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.png: Added.
- platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.png: Added.
- platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-scroll-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium-win/compositing/tiling/rotated-tiled-clamped-expected.png: Added.
- platform/chromium-win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-scroll-expected.txt: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.
- 3:39 PM Changeset in webkit [145277] by
-
- 6 edits in trunk/Source/WebCore
Free up background parser's checkpoints when speculation succeeds
https://bugs.webkit.org/show_bug.cgi?id=110547
Reviewed by Adam Barth.
This should be a memory (and possible perf) win while parsing
pages, as we will no longer hold multiple copies of every
source byte during the whole parse.
Many LayoutTests exercise this code path, and I've manually (debugger and printf)
that we're hitting this code, but we'll have to wait for the memory/perf bots
to tell us if this shows up as a win.
We only bother to message the parser at the end of a speculation chain, so as not
to send too many messages to the background parser.
- html/parser/BackgroundHTMLInputStream.cpp:
(WebCore::BackgroundHTMLInputStream::BackgroundHTMLInputStream):
(WebCore::BackgroundHTMLInputStream::invalidateCheckpointsUpThrough):
(WebCore):
(WebCore::BackgroundHTMLInputStream::rewindTo):
- html/parser/BackgroundHTMLInputStream.h:
(BackgroundHTMLInputStream):
(Checkpoint):
(WebCore::BackgroundHTMLInputStream::Checkpoint::isNull):
(WebCore::BackgroundHTMLInputStream::Checkpoint::clear):
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::passedCheckpoint):
(WebCore):
- html/parser/BackgroundHTMLParser.h:
(BackgroundHTMLParser):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
- 3:27 PM Changeset in webkit [145276] by
-
- 3 edits1 add in trunk
[chromium] Keydown event for 'shift+alt' returns win keycode instead of 'alt'
https://bugs.webkit.org/show_bug.cgi?id=111112
Patch by Chandra Shekar Vallala <brk376@motorola.com> on 2013-03-08
Reviewed by Tony Chang.
.:
Return windows keycode of Alt incase of GDK_META_L, GDK_META_R.
Try press Shift then alt key. The test passes if the shiftKey, altKey values
of JSKeyEvent are true and keycode/which is 18.
- ManualTests/shift-alt-key-event.html: Added.
Source/WebCore:
Return windows keycode of Alt incase of GDK_META_L, GDK_META_R. This matches
the firefox behaviour in linux platform.
Added Manual Test : ManualTests/shift-alt-key-event.html
Try press Shift then alt key. The test passes if the shiftKey, altKey values
of JSKeyEvent are true and keycode/which is 18.
- platform/chromium/KeyCodeConversionGtk.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
- 3:11 PM Changeset in webkit [145275] by
-
- 20 edits5 copies in branches/chromium/1364
Merge 144236
Plugin in iframe may not display
https://bugs.webkit.org/show_bug.cgi?id=109879
Patch by John Bauman <jbauman@chromium.org> on 2013-02-27
Reviewed by Simon Fraser.
Source/WebCore:
Changing the cliprect on a layer containing an iframe may change the
cliprect of plugins inside the iframe, so recursively tell all plugins
in iframes that their cliprect has changed after doing layout on the
outer frame.
Test: plugins/plugin-clip-subframe.html
- platform/ScrollView.cpp:
(WebCore::ScrollView::clipRectChanged):
- platform/ScrollView.h:
- platform/Widget.h:
(WebCore::Widget::clipRectChanged):
- plugins/PluginView.cpp:
(WebCore::PluginView::clipRectChanged):
- plugins/PluginView.h:
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
Source/WebKit/chromium:
Use clipRectChanged to update the geometry.
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::clipRectChanged):
- src/WebPluginContainerImpl.h:
Source/WebKit/mac:
Ensure NetscapePluginWidget informs the plugin view of the cliprect change directly.
- Plugins/WebBaseNetscapePluginView.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(NetscapePluginWidget::clipRectChanged):
Source/WebKit2:
Update geometry when cliprect changes.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::clipRectChanged):
- WebProcess/Plugins/PluginView.h:
Tools:
LogNPPSetWindow will be used with other ports as well.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
LayoutTests:
Use log-npp-set-window to ensure plugin clip changes correctly.
- platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt: Added.
- platform/mac/plugins/plugin-clip-subframe-expected.txt: Added.
- plugins/plugin-clip-subframe-expected.txt: Added.
- plugins/plugin-clip-subframe.html: Added.
- plugins/resources/plugin-clip-subframe-iframe.html: Added.
BUG=168900
TBR=jbauman@chromium.org
Review URL: https://codereview.chromium.org/12475008
- 2:57 PM Changeset in webkit [145274] by
-
- 18 edits1 copy1 move14 adds in trunk/LayoutTests
Update some more chromium compositor pixel baselines.
- platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-linux/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/chromium-linux/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-linux/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-linux/compositing/reflections/load-video-in-reflection-expected.png:
- platform/chromium-linux/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium-mac-lion/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-mac-lion/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac-lion/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-mac-lion/compositing/reflections/load-video-in-reflection-expected.png:
- platform/chromium-mac-lion/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium-mac-snowleopard/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-mac-snowleopard/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png:
- platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium-mac/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-mac/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-mac/compositing/reflections/load-video-in-reflection-expected.png:
- platform/chromium-mac/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium-win/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-win/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-win/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-win/compositing/reflections/load-video-in-reflection-expected.png:
- platform/chromium-win/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.
- platform/chromium/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.txt: Added.
- platform/efl-wk2/compositing/reflections/nested-reflection-anchor-point-expected.png: Renamed from LayoutTests/platform/efl/compositing/reflections/nested-reflection-anchor-point-expected.png.
- 2:45 PM Changeset in webkit [145273] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r187037. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-08
- DEPS:
- 2:41 PM Changeset in webkit [145272] by
-
- 2 edits in trunk/Tools
[chromium] use custom freetype on linux asan builds again
https://bugs.webkit.org/show_bug.cgi?id=111884
Reviewed by Tony Chang.
We no longer need the workaround after chromium r186540.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 2:38 PM Changeset in webkit [145271] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. AppleWin port.
- platform/win/TestExpectations:
- 2:36 PM Changeset in webkit [145270] by
-
- 2 edits in trunk/Tools
Warning about the user not having edit rights on Bugzilla is confusing new contributors
https://bugs.webkit.org/show_bug.cgi?id=111798
Reviewed by Dirk Pranke.
Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
- 2:32 PM May 2013 Meeting edited by
- Add a new topic (diff)
- 2:26 PM Changeset in webkit [145269] by
-
- 6 edits3 deletes in trunk/LayoutTests
Update baselines for a few chromium compositor tests.
- platform/chromium-linux/compositing/checkerboard-expected.png: Removed.
- platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-mac-lion/compositing/checkerboard-expected.png: Removed.
- platform/chromium-mac/compositing/checkerboard-expected.png:
- platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-win/compositing/checkerboard-expected.png: Removed.
- platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium/TestExpectations:
- 2:19 PM Changeset in webkit [145268] by
-
- 3 edits2 adds in trunk
CSP: 'eval()' is blocked in report-only mode.
https://bugs.webkit.org/show_bug.cgi?id=111867
Reviewed by Adam Barth.
Source/WebCore:
Setting a 'Content-Security-Policy-Report-Only' header should not have
any effect on what a page actually executes. Currently, however, setting
a 'script-src' directive that doesn't whitelist 'unsafe-eval' actually
blocks 'eval()' on the page. This patch fixes that by checking whether
we're in report-only mode before turning 'eval()' off inside the script
engine.
This leaves us in a weird state, however. We don't currently have any
mechanism of explaining to the VM that we just want to be notified of
'eval()' usage. I've filed http://wkbug.com/111869 to cover this
aspect.
Test: http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode.html
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didReceiveHeader):
For each policy we parse, check that we're only turning off eval in
the VM when we're in enforce mode. If we're in report-only mode,
skip it.
LayoutTests:
- http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode.html: Added.
- 2:09 PM Changeset in webkit [145267] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13338743> Fix sandbox profile preprocessor flags for compatibility with new clang.
Reviewed by Alexey Proskuryakov.
Patch by Bob Wilson.
- DerivedSources.make: Only use -traditional when we have to work around old behavior of -std=c89.
- 1:47 PM Changeset in webkit [145266] by
-
- 3 edits1 delete in trunk/LayoutTests
Update baselines for string prototypes fixed by v8-i18n roll 164:171
- platform/chromium/fast/js/kde/function_length-expected.txt: Removed.
- platform/chromium/fast/js/kde/inbuilt_function_tostring-expected.txt:
- platform/chromium/fast/js/string-prototype-properties-expected.txt:
- 1:45 PM Changeset in webkit [145265] by
-
- 3 edits2 adds in trunk
REGRESSION (r143643): <button> should support ::first-line and ::first-letter
https://bugs.webkit.org/show_bug.cgi?id=111782
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-08
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/forms/button-first-line-first-letter.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::firstLineBlock):
(WebCore::findFirstLetterBlock):
Add isRenderButton to the first-line and first-letter checks that
don't allow ::first-* styles for flexbox.
LayoutTests:
- fast/forms/button-first-line-first-letter-expected.html: Added.
- fast/forms/button-first-line-first-letter.html: Added.
- 1:25 PM Changeset in webkit [145264] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix for EFL, GTK and Qt after r145254.
- Shared/SandboxExtension.h:
(WebKit::SandboxExtension::revoke):
- 1:20 PM Changeset in webkit [145263] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/dom/HTMLMeterElement/meter-element-crash.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88131
Reviewed by Tony Chang.
This test was calling setTimeout(..., 0) in a <script> block before the end of the document.
The timeout sometimes fired before parsing the rest of the document and sometimes after,
depending on when the parser yielded. This moves the <script> block to the end of the document
so it always runs after parsing the rest of the test, which is the more common and expected
behavior.
- fast/dom/HTMLMeterElement/meter-element-crash.html:
- 1:14 PM Changeset in webkit [145262] by
-
- 2 edits in trunk/Source/WebKit
Build fix for AppleWin VS2010.
- WebKit.vcxproj/FeatureDefines.props:
- 1:11 PM Changeset in webkit [145261] by
-
- 1 edit3 adds in trunk/LayoutTests
Added a regression test for raw parsing speed
https://bugs.webkit.org/show_bug.cgi?id=111808
Reviewed by Oliver Hunt.
- fast/js/regress/nested-function-parsing-random.html: Added.
- fast/js/regress/script-tests/nested-function-parsing-random.js: Added.
(randomIdent): Use randomness to defeat caching.
- 1:11 PM Changeset in webkit [145260] by
-
- 3 edits in trunk/Source/WebCore
Removed an out-of-date comment from SharedTimer
https://bugs.webkit.org/show_bug.cgi?id=111875
Reviewed by Mark Hahnenberg.
Even if we surround each call to an ObjC interface with an autorelease
pool, it's still nice to have one at top-level entry points like
timers, to avoid turning a single mistake into a long-term leak.
- platform/ios/SharedTimerIOS.mm:
(WebCore::timerFired):
- platform/mac/SharedTimerMac.mm:
(WebCore::timerFired):
- 1:04 PM Changeset in webkit [145259] by
-
- 2 edits6 adds in trunk/LayoutTests
Chromium gardening.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/paste-text-016-expected.txt: Added.
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-016-expected.txt: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
- platform/chromium/TestExpectations:
- 1:02 PM Changeset in webkit [145258] by
-
- 12 edits1 delete in trunk
[chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
https://bugs.webkit.org/show_bug.cgi?id=111632
Patch by James Robinson <jamesr@chromium.org> on 2013-03-08
Reviewed by Adrienne Walker.
Source/Platform:
Neither of these are used any more. All callbacks from the compositor are handled by
the embedder and plumbed (where appropriate) through the WebWidget/WebView APIs. All
settings are handled by the embedder.
- Platform.gypi:
- chromium/public/WebLayerTreeView.h:
(WebKit):
- chromium/public/WebLayerTreeViewClient.h: Removed.
- chromium/public/WebUnitTestSupport.h:
(WebKit):
Source/WebKit/chromium:
- public/WebWidgetClient.h:
(WebWidgetClient):
(WebKit::WebWidgetClient::initializeLayerTreeView):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
- tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::FakeWebViewClient::initializeLayerTreeView):
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::initializeLayerTreeView):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 12:56 PM Changeset in webkit [145257] by
-
- 9 edits13 adds in trunk/LayoutTests
Mac rebaseline after r145242. I'm really hoping that the optimization didn't mess this up.
- css1/box_properties/margin_bottom-expected.txt: Replaced.
- css1/box_properties/margin_top-expected.txt: Replaced.
- css1/box_properties/padding_bottom-expected.txt: Replaced.
- css1/box_properties/padding_top-expected.txt: Replaced.
- css1/color_and_background/background_attachment-expected.txt: Replaced.
- platform/mac/css1/formatting_model/vertical_formatting-expected.txt:
- platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/mac/css3/flexbox/flexbox-baseline-expected.txt:
- platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- platform/mac/tables/mozilla/bugs/bug126742-expected.txt:
- platform/mac/tables/mozilla/bugs/bug69187-expected.txt:
- platform/win-future/css1: Added.
- platform/win-future/css1/box_properties: Added.
- platform/win-future/css1/box_properties/margin_bottom-expected.txt: Added.
- platform/win-future/css1/box_properties/margin_top-expected.txt: Added.
- platform/win-future/css1/box_properties/padding_bottom-expected.txt: Added.
- platform/win-future/css1/box_properties/padding_top-expected.txt: Added.
- platform/win-future/css1/color_and_background: Added.
- platform/win-future/css1/color_and_background/background_attachment-expected.txt: Added.
- 12:47 PM Changeset in webkit [145256] by
-
- 2 edits in trunk/Source/WebKit2
non-Mac ports build fix after r145235.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup):
- 12:40 PM Changeset in webkit [145255] by
-
- 31 edits in trunk
[Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
https://bugs.webkit.org/show_bug.cgi?id=111297
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
The 'view-mode' Media Feature spec is implemented in WebCore but
there is no WebKit support for it on Mac.
Because of this, we always lie and report a windowed view mode.
This patch add a feature flag for the feature and disable it on
Mac so that we stop reporting incorrect default values.
- WebCore.exp.in:
- css/CSSValueKeywords.in:
- css/MediaFeatureNames.h:
(MediaFeatureNames):
- css/MediaQueryEvaluator.cpp:
- css/MediaQueryExp.cpp:
(WebCore::featureWithCSSValueID):
(WebCore::featureWithoutValue):
- page/Page.cpp:
(WebCore::Page::Page):
- page/Page.h:
(Page):
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
Source/WTF:
- wtf/FeatureDefines.h: Add a new feature flag for the view-mode
CSS media: ENABLE_VIEW_MODE_CSS_MEDIA.
Tools:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setViewModeMediaFeature):
LayoutTests:
- platform/mac/TestExpectations:
Mark the view-mode tests as failing to track any regression
or crash in this area.
- 12:25 PM Changeset in webkit [145254] by
-
- 7 edits in trunk/Source/WebKit2
Make it possible to reuse sandbox extensions
https://bugs.webkit.org/show_bug.cgi?id=111883
Reviewed by Anders Carlsson.
Replaced invalidate() with revoke().
We now count how many times consume() was called, and keep the extension active
for as long as revoke() hasn't been called as many times. Also, we only permanently
destroy the extension in destructor.
This allows for properly keeping extensions in NetworkBlobRegistry for as long as
they are needed.
- NetworkProcess/SchedulableLoader.cpp: (WebKit::SchedulableLoader::invalidateSandboxExtensions):
- Shared/Downloads/Download.cpp: (WebKit::Download::didFinish): (WebKit::Download::didFail): (WebKit::Download::didCancel):
- Shared/SandboxExtension.h: (SandboxExtension):
- Shared/WebMemorySampler.cpp: (WebKit::WebMemorySampler::stop):
- Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::SandboxExtension): (WebKit::SandboxExtension::revoke): (WebKit::SandboxExtension::consume):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::performDragControllerAction): (WebKit::WebPage::SandboxExtensionTracker::invalidate): (WebKit::WebPage::SandboxExtensionTracker::setPendingProvisionalSandboxExtension): (WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad): (WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):
- 12:11 PM Changeset in webkit [145253] by
-
- 9 edits4 adds in trunk
After sending message, Mail changes formatting
https://bugs.webkit.org/show_bug.cgi?id=111360
Reviewed by Enrica Casucci.
Source/WebCore:
Added makeInsertedContentRoundTrippableWithHTMLTreeBuilder to move prohibited children (e.g. p, h1, etc...)
out of paragraph elements to run immediately after the fragment insertion. This function splits trees and
moves prohibited children out of paragraph elements to keep the tree isomorphic under HTML serialization and
parsing. Unfortunately, there are many other DOM tree constructs we need to fix to make the subtree truly
isomorphic but this is a step forward.
Test: editing/pasteboard/pasting-into-p-should-not-nest-p.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::isProhibitedParagraphChild): Added. Matches the list at
https://dvcs.w3.org/hg/editing/raw-file/57abe6d3cb60/editing.html#prohibited-paragraph-child
except main element, which is currently missing in the specification.
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder): Added.
(WebCore::ReplaceSelectionCommand::moveNodeOutOfAncestor): Added.
(WebCore::ReplaceSelectionCommand::doApply): Call moveProhibitedChildrenOutOfParagraphElements.
- editing/ReplaceSelectionCommand.h:
(ReplaceSelectionCommand):
LayoutTests:
Added a regression test, demonstrating that a paragraph element is not nested after a paste.
Also rebaselined multiple tests that had been exhibiting this bug in their expected results.
- editing/pasteboard/block-wrappers-necessary-expected.txt:
- editing/pasteboard/paste-table-001-expected.txt:
- editing/pasteboard/paste-text-011-expected.txt:
- editing/pasteboard/paste-text-015-expected.txt:
- editing/pasteboard/pasting-into-p-should-not-nest-p-expected.txt: Added.
- editing/pasteboard/pasting-into-p-should-not-nest-p.html: Added.
- editing/pasteboard/pasting-into-h6-should-not-nest-h6-expected.txt: Added.
- editing/pasteboard/pasting-into-h6-should-not-nest-h6.html: Added.
- platform/mac/editing/pasteboard/paste-text-016-expected.txt:
- 11:58 AM Changeset in webkit [145252] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r186991. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-08
- DEPS:
- 11:34 AM Changeset in webkit [145251] by
-
- 58 edits18 adds20 deletes in trunk/LayoutTests
Unreviewed chromium mac/win rebaselines for r145242.
- css1/basic/inheritance-expected.txt: Added.
- css1/box_properties/clear_float-expected.txt: Added.
- css1/box_properties/margin-expected.txt: Added.
- css1/box_properties/padding-expected.txt: Added.
- css1/font_properties/font_weight-expected.txt: Added.
- fast/css-generated-content/015-expected.txt: Added.
- fast/css/h1-in-section-elements-expected.txt: Added.
- platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
- platform/chromium-mac-lion/css1/box_properties/clear_float-expected.png:
- platform/chromium-mac-lion/css1/box_properties/padding-expected.png:
- platform/chromium-mac-lion/css1/font_properties/font_weight-expected.png:
- platform/chromium-mac-lion/css3/flexbox/flexbox-baseline-expected.png:
- platform/chromium-mac-lion/fast/css/h1-in-section-elements-expected.png:
- platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
- platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug126742-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug69187-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug73321-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug73321-expected.txt: Added.
- platform/chromium-mac-snowleopard/css1/basic/inheritance-expected.png:
- platform/chromium-mac-snowleopard/css1/box_properties/padding-expected.png:
- platform/chromium-mac-snowleopard/css1/color_and_background/background_attachment-expected.png:
- platform/chromium-mac-snowleopard/css1/font_properties/font_weight-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
- platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png:
- platform/chromium-mac-snowleopard/fast/css/h1-in-section-elements-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug126742-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug69187-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.txt: Added.
- platform/chromium-mac/css1/basic/inheritance-expected.txt: Removed.
- platform/chromium-mac/css1/box_properties/clear_float-expected.png:
- platform/chromium-mac/css1/box_properties/clear_float-expected.txt: Removed.
- platform/chromium-mac/css1/box_properties/margin-expected.txt: Removed.
- platform/chromium-mac/css1/box_properties/margin_bottom-expected.txt: Added.
- platform/chromium-mac/css1/box_properties/margin_top-expected.txt: Added.
- platform/chromium-mac/css1/box_properties/padding-expected.png:
- platform/chromium-mac/css1/box_properties/padding-expected.txt: Removed.
- platform/chromium-mac/css1/box_properties/padding_bottom-expected.txt: Added.
- platform/chromium-mac/css1/box_properties/padding_top-expected.txt: Added.
- platform/chromium-mac/css1/color_and_background/background_attachment-expected.txt: Added.
- platform/chromium-mac/css1/font_properties/font_weight-expected.png:
- platform/chromium-mac/css1/font_properties/font_weight-expected.txt: Removed.
- platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.txt:
- platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png:
- platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt:
- platform/chromium-mac/fast/css-generated-content/015-expected.txt: Removed.
- platform/chromium-mac/fast/css/h1-in-section-elements-expected.png:
- platform/chromium-mac/fast/css/h1-in-section-elements-expected.txt: Removed.
- platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug126742-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug126742-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug69187-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug69187-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.txt: Added.
- platform/chromium-win/css1/basic/inheritance-expected.png:
- platform/chromium-win/css1/box_properties/clear_float-expected.png:
- platform/chromium-win/css1/box_properties/margin_top-expected.png:
- platform/chromium-win/css1/font_properties/font_weight-expected.png:
- platform/chromium-win/css3/flexbox/flexbox-baseline-expected.png:
- platform/chromium-win/fast/css/h1-in-section-elements-expected.png:
- platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
- platform/chromium-win/tables/mozilla/bugs/bug126742-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug69187-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug73321-expected.png:
- platform/chromium/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Removed.
- platform/chromium/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
- platform/chromium/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
- platform/mac/css1/basic/inheritance-expected.txt: Removed.
- platform/mac/css1/box_properties/clear_float-expected.txt: Removed.
- platform/mac/css1/box_properties/margin-expected.txt: Removed.
- platform/mac/css1/box_properties/padding-expected.txt: Removed.
- platform/mac/css1/font_properties/font_weight-expected.txt: Removed.
- platform/mac/fast/css-generated-content/015-expected.txt: Removed.
- platform/mac/fast/css/h1-in-section-elements-expected.txt: Removed.
- 11:28 AM Changeset in webkit [145250] by
-
- 10 edits7 adds14 deletes in trunk/LayoutTests
Unreviewed apple rebaselines for r145242.
- css1/box_properties/margin_bottom-expected.txt: Added.
- css1/box_properties/margin_top-expected.txt: Added.
- css1/box_properties/padding_bottom-expected.txt: Added.
- css1/box_properties/padding_top-expected.txt: Added.
- css1/color_and_background/background_attachment-expected.txt: Added.
- platform/chromium-mac/css1/box_properties/margin_bottom-expected.txt: Removed.
- platform/chromium-mac/css1/box_properties/margin_top-expected.txt: Removed.
- platform/chromium-mac/css1/box_properties/padding_bottom-expected.txt: Removed.
- platform/chromium-mac/css1/box_properties/padding_top-expected.txt: Removed.
- platform/chromium-mac/css1/color_and_background/background_attachment-expected.txt: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.txt: Removed.
- platform/chromium/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug73321-expected.txt: Removed.
- platform/mac-lion/css1/box_properties: Removed.
- platform/mac/css1/basic/inheritance-expected.txt:
- platform/mac/css1/box_properties/clear_float-expected.txt:
- platform/mac/css1/box_properties/margin-expected.txt:
- platform/mac/css1/box_properties/margin_bottom-expected.txt: Removed.
- platform/mac/css1/box_properties/margin_top-expected.txt: Removed.
- platform/mac/css1/box_properties/padding-expected.txt:
- platform/mac/css1/box_properties/padding_bottom-expected.txt: Removed.
- platform/mac/css1/box_properties/padding_top-expected.txt: Removed.
- platform/mac/css1/color_and_background/background_attachment-expected.txt: Removed.
- platform/mac/css1/font_properties/font_weight-expected.txt:
- platform/mac/fast/css-generated-content/015-expected.txt:
- platform/mac/fast/css/h1-in-section-elements-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/mac/tables/mozilla/bugs/bug73321-expected.txt:
- tables/mozilla/bugs/bug73321-expected.txt: Added.
- 11:28 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:26 AM Changeset in webkit [145249] by
-
- 9 edits2 adds3 deletes in releases/WebKitGTK/webkit-2.0
Merge r143604 - [GTK] Move feature overriding to the configure phase
https://bugs.webkit.org/show_bug.cgi?id=110293
Reviewed by Gustavo Noronha Silva.
.:
Rework the feature overrides logic so all feature defines go into a
header rather than the command line. This has a few benefits. Most
notably, we can reuse the header in the gyp build. Another nice result
is that changes to the configuration automatically result in a full
rebuild and Debug and Release builds can have different configurations.
All feature define processing happens now during the configuration phase,
instead of when running autogen.sh. This means that we need to distribute
the feature processing script.
- GNUmakefile.am: Read feature defines from WebKitFeatures.txt when kicking
off a build. Also include generate-feature-defines-files in the distribution.
- Source/autotools/SetupAutoconfHeader.m4: Remove an extra ENABLE_3D_RENDERING
from the autoconf header, as it is already provided by the feature configuration.
- Source/autotools/SetupWebKitFeatures.m4: Added.
- Source/autotools/webkitfeature.m4: Removed. The functionality has been moved
to SetupWebKitFeatures.m4.
- autogen.sh: Remove the call to override-feature-defines.
- configure.ac: Now include SetupWebKitFeatures.
Source/WebCore:
- GNUmakefile.am: No longer include GNUmakefile.features.am. We don't
have to process the result of this file or do any modification of
feature_defines_override, because this variable is gone.
Tools:
- Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
WebKitFeatureOverrides.txt to better match the other filenames used in
the new feature processing.
- gtk/generate-feature-defines-files: Added. A script which takes as an argument
the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
and writes WebKitFeatures.txt and WebKitFeatures.h.
- gtk/override-feature-defines: Removed.
- 11:15 AM Changeset in webkit [145248] by
-
- 9 edits in trunk/Source/WebCore
AtomicHTMLToken should not be heap allocated or RefCounted
https://bugs.webkit.org/show_bug.cgi?id=111250
Reviewed by Adam Barth.
It was clearly an oversight on our part to ever make AtomicHTMLToken ref-counted.
We don't need the actual "token" saved, just enough of it to recreate a fake token.
This removed many more mallocs than I thought it would, for a nice little speed win.
Before:
median= 450.482999993 ms, stdev= 7.2381436538 ms, min= 436.084999994 ms, max= 464.968999964 ms
After:
median= 436.41600004 ms, stdev= 5.71435647554 ms, min= 427.160999971 ms, max= 446.753000026 ms
- html/parser/AtomicHTMLToken.h:
(AtomicHTMLToken):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createElementFromSavedToken):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken):
(WebCore::HTMLDocumentParser::constructTreeFromCompactHTMLToken):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::isHTMLIntegrationPoint):
- html/parser/HTMLFormattingElementList.cpp:
(WebCore):
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition):
- html/parser/HTMLStackItem.h:
(WebCore::HTMLStackItem::create):
(WebCore::HTMLStackItem::localName):
(WebCore::HTMLStackItem::attributes):
(WebCore::HTMLStackItem::getAttributeItem):
(HTMLStackItem):
(WebCore::HTMLStackItem::hasLocalName):
(WebCore::HTMLStackItem::hasTagName):
(WebCore::HTMLStackItem::HTMLStackItem):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
- 10:57 AM Changeset in webkit [145247] by
-
- 6 edits in trunk/Source
Makefile fixes.
- WTF.vcxproj/WTF.make:
- JavaScriptCore.vcxproj/JavaScriptCore.make:
- WebCore.vcxproj/WebCore.make:
- 10:53 AM Changeset in webkit [145246] by
-
- 4 edits in tags/Safari-537.33.1/Source
Versioning.
- 10:49 AM WebKitGTK/2.0.x edited by
- (diff)
- 10:43 AM Changeset in webkit [145245] by
-
- 1 copy in tags/Safari-537.33.1
New Tag.
- 10:42 AM Changeset in webkit [145244] by
-
- 5 edits in trunk/Source/WebKit2
[WK2][GTK] Invalid request returned by webkit_download_get_request if called before download starts
https://bugs.webkit.org/show_bug.cgi?id=111574
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-08
Reviewed by Alexey Proskuryakov.
webkit_download_get_request() creates the WebKitURIRequest object
on demand using the ResourceRequest from the DownloadProxy. The
ResourceRequest of the DownloadProxy is set in
DownloadProxy::didStart(), so if we call
webkit_download_get_request() before didStart we return an invalid
WebKitURIRequest created from a NULL ResourceRequest. This is not
a problem for downloads started in the web process, because we
create the WebKitDownload after DownloadProxy::didStart(). For
downloads started manually with webkit_web_context_download_uri()
we need to create download object with the ResourceRequest passed
to the DownloadProxy.
- UIProcess/API/gtk/WebKitDownload.cpp:
(webkitDownloadCreateForRequest): New helper function for
downloads started manually to created them with a given
ResourceRequest.
- UIProcess/API/gtk/WebKitDownloadPrivate.h:
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextStartDownload): Use
webkitDownloadCreateForRequest().
- UIProcess/API/gtk/tests/TestDownloads.cpp:
(testDownloadLocalFile):
(testDownloadLocalFileError):
(testDownloadRemoteFile):
(testDownloadRemoteFileError):
(testPolicyResponseDownload):
- 10:33 AM Changeset in webkit [145243] by
-
- 2 edits in trunk/LayoutTests
Skip editing/selection/drag-list-item.html on Mac WebKit2 since drag and drop is not supported
in WebKitTestRunner yet.
- platform/mac-wk2/TestExpectations:
- 10:30 AM Changeset in webkit [145242] by
-
- 34 edits2 adds in trunk
[sub-pixel] Rounding error in table cell height calculation causes unnecessary scrollbar
https://bugs.webkit.org/show_bug.cgi?id=111794
Source/WebCore:
Reviewed by Levi Weintraub.
In RenderTableCell::logicalHeightForRowSizing the
adjustedLogicalHeight is calculated from the logicalHeight and
intrinsic padding and is then returned and floored. This can
cause cause the cell to be slightly smaller (0.5px) than the
element it contains.
Test: fast/sub-pixel/table-cell-height.html
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::logicalHeightForRowSizing):
Change to use pixelSnapped version of logicalHeight method and
change signature to return int as the only caller immediately
down-casts the result to an int.
LayoutTests:
Reviewed by Levi Weintraub.
Add test for zoomed-in table containing block child.
- fast/sub-pixel/table-cell-height-expected.html: Added.
- fast/sub-pixel/table-cell-height.html: Added.
- 10:27 AM Changeset in webkit [145241] by
-
- 3 edits2 adds in trunk
RenderFullScreen needs to clear override sizes when exiting full screen
https://bugs.webkit.org/show_bug.cgi?id=111775
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-08
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fullscreen/full-screen-with-flex-item.html
- rendering/RenderFullScreen.cpp:
(RenderFullScreen::unwrapRenderer):
RenderFullScreen is a flexbox, so it will potentially set override
sizes on its children while in fullscreen mode. When we exit
fullscreen mode, we need to clear this override size, otherwise the
the leftover override size may affect layout. See the testcase for an
example.
LayoutTests:
- fullscreen/full-screen-with-flex-item-expected.txt: Added.
- fullscreen/full-screen-with-flex-item.html: Added.
- 10:26 AM LayoutUnit edited by
- Removed note about FractionalLayoutUnit typedef as it has since been … (diff)
- 10:25 AM Changeset in webkit [145240] by
-
- 7 edits2 adds in trunk
[CSS Grid Layout] Handle 2 positions with one 'auto' properly
https://bugs.webkit.org/show_bug.cgi?id=111653
Reviewed by Tony Chang.
Source/WebCore:
The rendering code was making the assumption that we have one position.
Thus it couldn't fully match what the specification wants as the 2 opposite
positions are required to resolve either position in several cases (e.g.
1 / span 2, auto / 'c').
This change introduces resolveGridPositionsFromStyle to do both opposite
positions resolution in one pass and thus handling more cases.
Test: fast/css-grid-layout/grid-item-spanning-resolution.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
Updated the above functions to rely on resolveGridPositionsFromStyle.
(WebCore::RenderGrid::resolveGridPositionsFromStyle):
Added this new function that handle the correct resolution.
(WebCore::RenderGrid::resolveGridPositionFromStyle):
Updated the ASSERT to match the new code flow.
- rendering/RenderGrid.h:
(WebCore::RenderGrid::GridSpan::GridSpan):
Introduced this new struct to hold the 2 positions along one axis.
LayoutTests:
- fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
- fast/css-grid-layout/grid-auto-flow-resolution.html:
- fast/css-grid-layout/grid-item-spanning-resolution-expected.txt: Added.
- fast/css-grid-layout/grid-item-spanning-resolution.html: Added.
Extended and added a new test. Most of the new testing is failing as it
requires other changes to land. This will help us track our progress
towards fully supporting the new syntax and padding.
- fast/css-grid-layout/resources/grid.css:
Added the 2 new classes.
- 10:12 AM Changeset in webkit [145239] by
-
- 3 edits6 adds in trunk
RenderTextControlSingleLine should not assume that its text element has a renderer
https://bugs.webkit.org/show_bug.cgi?id=111826
Reviewed by Ojan Vafai.
Source/WebCore:
Tests: fast/forms/search/search-autoscroll-hidden-decoration-container-crash.html
fast/forms/search/search-hide-decoration-container-crash.html
fast/forms/search/search-scroll-hidden-decoration-container-crash.html
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::controlClipRect):
(WebCore::RenderTextControlSingleLine::autoscroll):
(WebCore::RenderTextControlSingleLine::scroll):
LayoutTests:
- fast/forms/search/search-autoscroll-hidden-decoration-container-crash-expected.txt: Added.
- fast/forms/search/search-autoscroll-hidden-decoration-container-crash.html: Added.
- fast/forms/search/search-hide-decoration-container-crash-expected.txt: Added.
- fast/forms/search/search-hide-decoration-container-crash.html: Added.
- fast/forms/search/search-scroll-hidden-decoration-container-crash-expected.txt: Added.
- fast/forms/search/search-scroll-hidden-decoration-container-crash.html: Added.
- 10:06 AM Changeset in webkit [145238] by
-
- 9 edits in trunk/Source
IndexedDB: Use WeakPtr for Factory-to-BackingStore reference
https://bugs.webkit.org/show_bug.cgi?id=111459
Reviewed by Adam Barth.
Source/WebCore:
IDBFactoryBackendImpl maintains a map of backing stores - if another database in the same
origin is opened, the backing store instance must be re-used). This was a map to raw
pointers so that the backing store can be collected when all database references are
dropped. The map was maintained manually by passing the factory to the IDBBackingStore which
would add/remove itself on creation/destruction.
Replace this with a HashMap<WeakPtr<T>>. This simplifies the plumbing; map entries
"leak" but are purged on subsequent opens.
Added webkit_unit_test (Chromium port) to verify refcounts.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore): No need to notify factory of lifetime.
(WebCore::IDBBackingStore::~IDBBackingStore): Ditto.
(WebCore::IDBBackingStore::open): Ditto.
- Modules/indexeddb/IDBBackingStore.h: No reference to the factory, but...
(WebCore::IDBBackingStore::createWeakPtr): Do need to expose weak pointers for the factory to hold.
- Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::cleanWeakMap): Helper function to scrub a HashMap<WeakPtr<T>> of empty pointers.
May move to WTF when we've learned how general it is, or come up with a dedicated WeakPtrHashMap type.
(WebCore::IDBFactoryBackendImpl::openBackingStore): WeakPtr fu.
- Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl): Remove plumbing methods.
Source/WebKit/chromium:
Add new test that verifies refcounts.
- WebKit.gyp: Don't include files depending on webkit_support.
- tests/IDBBackingStoreTest.cpp:
(WebCore::IDBBackingStoreTest::SetUp): No need for dummy factory.
(MockIDBFactoryBackend): Allow access to protected openBackingStore method.
(WebCore::TEST): Add new test that verifies refcounts.
- tests/IDBCleanupOnIOErrorTest.cpp:
(WebCore::TEST): No need for dummy factory.
- 9:42 AM Changeset in webkit [145237] by
-
- 3 edits3 copies in branches/chromium/1410
Merge 144894
Crash during middle mouse click when page is removed
https://bugs.webkit.org/show_bug.cgi?id=111489
Reviewed by Hajime Morrita.
Source/WebCore:
Check for a null page that can happen if we remove the document from the DOM.
The other methods in EventHandler also check for a null page.
Test: editing/pasteboard/selection-paste-crash.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handlePasteGlobalSelection):
LayoutTests:
- editing/pasteboard/resources/selection-paste-crash.html: Added.
- editing/pasteboard/selection-paste-crash-expected.txt: Added.
- editing/pasteboard/selection-paste-crash.html: Added.
TBR=tony@chromium.org
Review URL: https://codereview.chromium.org/12510009
- 9:38 AM Changeset in webkit [145236] by
-
- 4 edits in trunk/Source/WebKit2
<rdar://problem/13363499> Blobs are not cleaned up when WebProcess terminates
https://bugs.webkit.org/show_bug.cgi?id=111803
Reviewed by Brady Eidson.
Track which blobs were created for each connection, and unregister them when
the connection closes.
Normally, this happens when a document is destroyed through PublicURLManager
in WebProcess. But we don't get there when the web process crashes, or is terminated
without waiting for document destruction.
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp: (WebKit::NetworkBlobRegistry::registerBlobURL): (WebKit::NetworkBlobRegistry::unregisterBlobURL): (WebKit::NetworkBlobRegistry::connectionToWebProcessDidClose):
- NetworkProcess/FileAPI/NetworkBlobRegistry.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::didClose): (WebKit::NetworkConnectionToWebProcess::registerBlobURL): (WebKit::NetworkConnectionToWebProcess::registerBlobURLFromURL): (WebKit::NetworkConnectionToWebProcess::unregisterBlobURL):
- 9:35 AM WebKitGTK/2.0.x edited by
- (diff)
- 9:33 AM WebKitGTK/2.0.x edited by
- (diff)
- 9:30 AM Changeset in webkit [145235] by
-
- 3 edits in trunk/Source/WebKit2
Make the WebKit2 Web Inspector use tiled drawing and accelerated drawing.
<rdar://problem/12676223>
Reviewed by David Kilzer.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup): Call setAcceleratedDrawingEnabled with true on 10.8+.
- UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorWKView _shouldUseTiledDrawingArea]): Added. Return YES on 10.8+.
- 9:29 AM Changeset in webkit [145234] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK][WK2] Fix compilation warning missing-field-initializers in webkit-2.0 stable branch
https://bugs.webkit.org/show_bug.cgi?id=111863
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-08
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitUIClient.cpp:
(attachUIClientToView): Include missing initializer for pluginLoadPolicy.
- 9:19 AM Changeset in webkit [145233] by
-
- 3 edits2 adds in trunk
@media queries do not take zooming into account
https://bugs.webkit.org/show_bug.cgi?id=53186
Patch by John Mellor <johnme@chromium.org> on 2013-03-08
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Fixes @media width and height to take into account full page zoom, by
adding code to MediaQueryEvaluator's width/heightMediaFeatureEval,
corresponding to the existing code in Element::clientWidth which makes
document.documentElement.clientWidth take into account page zoom.
Test: fast/media/mq-width-pagezoom.html
- css/MediaQueryEvaluator.cpp:
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
LayoutTests:
- fast/media/mq-width-pagezoom-expected.html: Added.
- fast/media/mq-width-pagezoom.html: Added.
- 9:12 AM Changeset in webkit [145232] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Add stubs for DNSResolveQueue platform specific methods
https://bugs.webkit.org/show_bug.cgi?id=111841
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.
Add empty implementations of
DNSResolveQueue::platformProxyIsEnabledInSystemPreferences() and
DNSResolveQueue::platformResolve() to DNSBlackBerry.cpp to make it
build.
- platform/network/blackberry/DNSBlackBerry.cpp:
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::DNSResolveQueue::platformResolve):
- 8:59 AM Changeset in webkit [145231] by
-
- 7 edits in trunk
[Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
https://bugs.webkit.org/show_bug.cgi?id=111814
Reviewed by Ryosuke Niwa.
Tools:
Add the needed supportedActions() attribute to WKTestRunner.
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::supportedActions):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::supportedActions):
LayoutTests:
- platform/mac-wk2/TestExpectations:
- 8:55 AM WebKitGTK/2.0.x edited by
- Add new change on track (diff)
- 8:33 AM Changeset in webkit [145230] by
-
- 3 edits in trunk/Source/WebKit2
Coordinated Graphics: Handle scrolling correctly.
https://bugs.webkit.org/show_bug.cgi?id=111406
Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-08
Reviewed by Simon Fraser.
Coordinated Graphics deals with fast scrolling and slow scrolling in the same
routine, so WebChromeClient::invalidateContentsForSlowScroll() should call
DrawingArea:scroll().
When CoordinatedLayerTreeHost::scrollNonCompositedContents() is called, we
should call scheduleLayerFlush() to notify to UI Process. In addition, when we
don't use fixed layout, we should call setNonCompositedContentsNeedDisplay() to
update non composited contents.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::invalidateContentsForSlowScroll):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):
- 8:28 AM Changeset in webkit [145229] by
-
- 2 edits in trunk/Source/WebCore
Adding a hook to collect data for a Google UMA histogram to track when
m_needsCompositedScrolling is turned on and off.
https://bugs.webkit.org/show_bug.cgi?id=111725
Reviewed by Julien Chaffraix.
We want to keep track of this information to quantify the effects of a
few patches that will cause us to opt in to composited scrolling.
Specifically, we want to measure the effects of
https://bugs.webkit.org/show_bug.cgi?id=109302,
https://bugs.webkit.org/show_bug.cgi?id=109966,
https://bugs.webkit.org/show_bug.cgi?id=109591, and
https://bugs.webkit.org/show_bug.cgi?id=107618.
We do this by measuring a per-layer boolean value, and comparing the
ratio between number of layers opted in and number of layers that remain
uncomposited. We hope the relative number of layers opting in will
increase after the relevant patches land and are enabled.
Unfortunately implementing extra statistics is impractical at the
moment since most of the actionable relevant data is expensive to
compute. For example, it would be useful to know if the layers that opt
out do so because of invisible or non-overlapping layers that cause a
potential stacking container's children to be discontiguous, because we
would potentially be able to mitigate the problem. However, this would
add considerable overhead to perform overlap testing just to gather
data.
No new tests (no change in behaviour).
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateNeedsCompositedScrolling):
Patch by Glenn Hartmann <hartmanng@chromium.org> on 2013-03-08
- 8:28 AM Changeset in webkit [145228] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed EFL gardening.
Update platform expectations for failing tests after r145024 and r145067.
- platform/efl/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- platform/efl/fast/forms/datalist/input-list-expected.txt:
- platform/efl/fast/forms/validationMessage-expected.txt: Added.
- 8:06 AM Changeset in webkit [145227] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip failing tests on EFL bots.
- platform/efl/TestExpectations:
- 8:00 AM Changeset in webkit [145226] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] GraphicsContext: rename addRoundedRectClip to clipRoundedRect
https://bugs.webkit.org/show_bug.cgi?id=111852
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.
This changed in r139353.
- platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
(WebCore::GraphicsContext::clipRoundedRect):
- 7:59 AM Changeset in webkit [145225] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Add BlendMode parameter to GraphicsContext::setPlatformCompositeOperation
https://bugs.webkit.org/show_bug.cgi?id=111840
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.
This parameter was added in r137011.
- platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
(WebCore::GraphicsContext::setPlatformCompositeOperation):
- 7:57 AM Changeset in webkit [145224] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Remove unused GraphicsContext::addInnerRoundedRectClip()
https://bugs.webkit.org/show_bug.cgi?id=111838
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.
This was removed in r139138.
- platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
- 7:56 AM Changeset in webkit [145223] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] GraphicsContext: add fillRule parameter to clip() and canvasClip()
https://bugs.webkit.org/show_bug.cgi?id=111836
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.
This parameter was added in r139967.
- platform/graphics/blackberry/PathBlackBerry.cpp:
(WebCore):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
- 7:51 AM Changeset in webkit [145222] by
-
- 3 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskip now passing compositing tests.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt/TestExpectations:
- platform/qt/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
- 7:39 AM Changeset in webkit [145221] by
-
- 12 edits in trunk
Web Inspector: Get rid of file system ids and use file pathes as uri for file based uiSourceCodes.
https://bugs.webkit.org/show_bug.cgi?id=111753
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/FileSystemMapping.js:
(WebInspector.FileSystemMappingImpl):
(WebInspector.FileSystemMappingImpl.prototype._loadFromSettings.get this):
(WebInspector.FileSystemMappingImpl.prototype._loadFromSettings):
(WebInspector.FileSystemMappingImpl.prototype._saveToSettings):
(WebInspector.FileSystemMappingImpl.prototype.set addFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.removeFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPaths):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPathForPrefix):
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate.projectId):
(WebInspector.FileSystemProjectDelegate.prototype.id):
(WebInspector.FileSystemProjectDelegate.prototype.fileSystemPath):
(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemRemoved):
(WebInspector.FileSystemWorkspaceProvider.prototype.fileSystemPath):
- inspector/front-end/IsolatedFileSystemManager.js:
(WebInspector.IsolatedFileSystemManager.prototype._innerAddFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemRemoved):
- inspector/front-end/Workspace.js:
(WebInspector.Workspace.prototype.uiSourceCodeForURL):
LayoutTests:
- inspector/file-system-mapping-expected.txt:
- inspector/file-system-mapping.html:
- inspector/file-system-project-expected.txt:
- inspector/workspace-mapping-expected.txt:
- inspector/workspace-mapping.html:
- 7:25 AM Changeset in webkit [145220] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Polish TabbedEditorContaner and ScriptsNavigator behavior.
https://bugs.webkit.org/show_bug.cgi?id=111732
Reviewed by Pavel Feldman.
Resources matching inspectedPageURL are always expanded in NavigatorView now.
Snippets tab in scripts navigator is not automatically opened anymore.
Cleared saved TabbedEditorContainer history because it might have been corrupted due to errors in earlier versions.
Snippets are not revealed in TabbedEditorContainer anymore unless they were actually selected by user or there is no other tabs opened.
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype.addUISourceCode):
(WebInspector.NavigatorView.prototype._inspectedURLChanged):
(WebInspector.NavigatorView.prototype.revealUISourceCode):
(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.uiSourceCode):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.reveal):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._showFile):
- inspector/front-end/Settings.js:
(WebInspector.VersionController.prototype._updateVersionFrom1To2):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.addUISourceCode.tabId.this._tabIds.get this):
(WebInspector.TabbedEditorContainer.prototype.addUISourceCode):
(WebInspector.TabbedEditorContainer.History.prototype._rebuildItemIndex):
- 7:14 AM Changeset in webkit [145219] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/TestExpectations: Skip test after r145195.
- 7:11 AM Changeset in webkit [145218] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Add shortcut for running a snippet.
https://bugs.webkit.org/show_bug.cgi?id=111680
Reviewed by Pavel Feldman.
Added Ctrl/Cmd+Enter as a shortcut for running a snippet.
- inspector/front-end/SnippetJavaScriptSourceFrame.js:
(WebInspector.SnippetJavaScriptSourceFrame):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._runButtonClicked):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._runSnippet):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._onKeyDown):
- 7:05 AM Changeset in webkit [145217] by
-
- 2 edits in trunk/Tools
[EFL] Memory leak at WKViewClientWebProcessCallbacks API test
https://bugs.webkit.org/show_bug.cgi?id=111851
Reviewed by Kenneth Rohde Christiansen.
- TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
(TestWebKitAPI::TEST):
Fixed WKURLRef instance leaking.
- 6:37 AM Changeset in webkit [145216] by
-
- 3 edits2 adds in trunk
Prevent infinite loop in SVG use cycle detection
https://bugs.webkit.org/show_bug.cgi?id=111822
Reviewed by Stephen Chenney.
Source/WebCore:
SVG use cycle detection depended on idForStyleResolution() which differs from
getIdAttribute() in quirks mode. During use tree cycle detection, this difference
resulted in an infinite loop because idForStyleResolution() used lower-cased id
attributes. This patch removes an existing fixme for this and switches to using
getIdAttribute().
Test: svg/custom/use-cycle-detection.html
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::hasCycleUseReferencing):
LayoutTests:
- svg/custom/use-cycle-detection-expected.html: Added.
- svg/custom/use-cycle-detection.html: Added.
- 6:32 AM Changeset in webkit [145215] by
-
- 3 edits2 adds in trunk
When we set word-wrap: break-word and xml:space="preserve" to svg text element, the text is collapsed.
https://bugs.webkit.org/show_bug.cgi?id=111675
Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-03-08
Reviewed by Stephen Chenney.
Source/WebCore:
RenderSVGText define its size when it laid out its first line at SVGRootInlineBox::computePerCharacterLayoutInformation().
In the following spec, SVG don't perform automatic line break or word wrapping.
http://www.w3.org/TR/SVG/text.html#Introduction
SVG performs no automatic line breaking or word wrapping.
However, when we set word-wrap: break-word and xml:space="preserve" to svg text element, RenderBlock::LineBreaker::nextLineBreak() breaks the text.
This make single character lines and make RenderSVGText narrow.
We must ignore word-wrap property to make the text a single line.
We always disable break words and break all in nextLineBreak() when the object is SVGInlineText.
Test: svg/text/preserve-break-word.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Disable break words and break all when we process SVG Text.
LayoutTests:
Test combination of xml:space="preserve" and word-wrap: break-word to SVG Text.
These text should not be collapsed.
- svg/text/preserve-break-word-expected.html: Added.
- svg/text/preserve-break-word.html: Added.
- 6:23 AM Changeset in webkit [145214] by
-
- 2 edits in trunk/Source/WebCore
[Qt] HTML5 video - sound volume bar out of widget
https://bugs.webkit.org/show_bug.cgi?id=108213
Reviewed by Jocelyn Turcotte.
Since we use Safari shadow DOM for media controls, follow
the overall layout of Safari media control CSS.
- css/mediaControlsQt.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
(audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
(audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
- 6:13 AM Changeset in webkit [145213] by
-
- 4 edits in trunk/Source/WebKit2
[WK2][EFL] Remove EwkView::setImageData()
https://bugs.webkit.org/show_bug.cgi?id=111849
Reviewed by Andreas Kling.
EwkView::setImageData() removed as it is not used at the moment
(it used to be part of eliminated non coord graphics code path).
- UIProcess/API/efl/EwkView.cpp:
- UIProcess/API/efl/EwkView.h:
(EwkView):
- UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::BackingStore::incorporateUpdate):
- 6:12 AM Changeset in webkit [145212] by
-
- 3 edits1 copy in trunk/LayoutTests
Allow platform-dependent strings for validationMessage property
https://bugs.webkit.org/show_bug.cgi?id=111846
Reviewed by Kentaro Hara.
Do not check matching with fixed strings in validationMessage.html
test. We print validationMessage values in the test instead.
We'd like to change user-visible strings at our own discretion.
- fast/forms/validationMessage-expected.txt:
Note that many platforms don't have a dedicated message for
badInput and uses the same message as typeMismatch for now.
- fast/forms/validationMessage.html:
- platform/chromium/fast/forms/validationMessage-expected.txt:
Chromium has a dedicated one for badInput.
- 5:43 AM Changeset in webkit [145211] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] QWebSettings::clearMemoryCaches should release FastMalloc's free pages to OS
https://bugs.webkit.org/show_bug.cgi?id=111605
Patch by Arunprasad Rajkumar <arunprasadr@nds.com> on 2013-03-08
Reviewed by Jocelyn Turcotte.
- Api/qwebsettings.cpp:
(QWebSettings::clearMemoryCaches):
- 5:24 AM Changeset in webkit [145210] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Doesn't build with QtMultimedia
https://bugs.webkit.org/show_bug.cgi?id=111847
Reviewed by Jocelyn Turcotte.
Fix include.
- platform/graphics/qt/MediaPlayerPrivateQt.h:
- 5:18 AM Changeset in webkit [145209] by
-
- 4 edits1 add in trunk
[EFL] [WK2] Some authentication tests fail in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=106407
Reviewed by Kenneth Rohde Christiansen.
Tools:
Add patch from upstream for libsoup 2.40 to fix several authentication
test cases.
- efl/jhbuild.modules:
- efl/patches/libsoup-2.40-auth-fix.patch: Added.
LayoutTests:
Unskip several authentication test cases now that we cherry-picked
the needed libsoup fix from upstream.
- platform/efl-wk2/TestExpectations:
- 4:12 AM Changeset in webkit [145208] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r145200.
- 3:36 AM May 2013 Meeting edited by
- (diff)
- 3:25 AM Changeset in webkit [145207] by
-
- 4 edits in trunk/Source/WebCore
[EFL][Qt] REGRESSION(r144787): A fixed element lags when scrolling and wheeling.
https://bugs.webkit.org/show_bug.cgi?id=111829
Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-08
Reviewed by Noam Rosenthal.
Currently, flagsChanged deals with all boolean flags. It introduces this bug
because when another flag (i.e. preserves3D) is changed, fixedToViewport is set
to false. So this patch updates all flags when at least one flag is changed.
In addition, this patch amends isScrollable code to match other flags.
This patch can only be tested manually since there is no automated
testing facilities for in-motion touch.
Test: ManualTests/fixed-position.html
ManualTests/nested-fixed-position.html
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setScrollableArea):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerState):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):
- 3:20 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:19 AM Changeset in webkit [145206] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r144982 - [GTK][WK2] Implement WebInspector::localizedStringsURL() to return the file URL of localizedStrings.js
https://bugs.webkit.org/show_bug.cgi?id=111448
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-06
Reviewed by Alexey Proskuryakov.
Implement WebInspector::localizedStringsURL() method to return the
file URL of the localizedStrings.js.
This prevents printing warnings about "Localized string not found" in
the console.
- WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspector::localizedStringsURL):
- 3:09 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:08 AM Changeset in webkit [145205] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk
Merge r144943 - Link the webkit_tests to XRENDER_LIBS.
This solves the linking failure when building against gtk2 like:
usr/lib/gcc/i586-suse-linux/4.7/../../../../i586-suse-linux/bin/ld:
Source/WebCore/platform/gtk/Programs_unittests_testcopyandpaste-GtkVersioning.o:
undefined reference to symbol 'XFree'
/usr/lib/gcc/i586-suse-linux/4.7/../../../../i586-suse-linux/bin/ld:
note: 'XFree' is defined in DSO /usr/lib/libX11.so.6 so try adding it
to the linker command line
/usr/lib/libX11.so.6: could not read symbols: Invalid operation
https://bugs.webkit.org/show_bug.cgi?id=111572
Patch by Dominique Leuenberger <dimstar@opensuse.org> on 2013-03-06
Reviewed by Gustavo Noronha Silva.
- GNUmakefile.am:
- 3:01 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:00 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:00 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:58 AM Changeset in webkit [145204] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r144936 - [soup] session cookies are not correctly reported in getRawCookies()
https://bugs.webkit.org/show_bug.cgi?id=111584
Reviewed by Martin Robinson.
As per libsoup documentation, SoupCookie->expires is NULL for session cookies.
However, the soup implementation for getRawCookies() does not check for NULL
case before passing the value to soup_date_to_time_t(), which leads to run time
warnings.
We should also pass true for WebCore::Cookie's session argument if
SoupCookie->expires is NULL. The current implementation reports the cookie as a
session one if soup_cookie_jar_is_persistent(jar) returns true, which is
inaccurate.
No new tests, no behavior change for layout tests as Web Inspector currently
ignores the "session" member and uses expires/max-age instead to deduce it.
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::getRawCookies):
- 2:55 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:54 AM Changeset in webkit [145203] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0
Merge r144969 - [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
https://bugs.webkit.org/show_bug.cgi?id=82866
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-06
Reviewed by Martin Robinson.
Source/WebKit2:
Test was failing because of new media controls needs more space to be
painted than just 10x10 pixels. This is similar to r144070.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewMouseTarget): Modified HTML in order to give more space to the media controls.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
it is passing now.
- 2:40 AM Changeset in webkit [145202] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Memory leak in webkit_web_view_load_request() in WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=111160
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-08
Reviewed by Benjamin Poulain.
leakRef() is used for the returned PassRefPtr without taking the
ownership of the leaked ref.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_request): Use RefPtr local variable.
- 2:29 AM Changeset in webkit [145201] by
-
- 2 edits in trunk
[Autotools] Remove definitions of unnecessary Automake conditionals
https://bugs.webkit.org/show_bug.cgi?id=111830
Reviewed by Philippe Normand.
The following Automake conditionals are not used anywhere and should have their
definitions in SetupAutomake.m4 removed:
ENABLE_GAMEPAD, ENABLE_XSLT, ENABLE_GEOLOCATION, ENABLE_SVG_FONTS,
ENABLE_OPCODE_STATS, ENABLE_CSS_FILTERS, ENABLE_CSS_SHADERS.
- Source/autotools/SetupAutomake.m4:
- 2:08 AM Changeset in webkit [145200] by
-
- 2 edits in trunk/Tools
[GTK] Enable Web Audio in development builds
https://bugs.webkit.org/show_bug.cgi?id=111831
Reviewed by Philippe Normand.
Web Audio is already quite well supported on the GTK port but still has a few issues
that must be addressed before it is enabled by default. Despite that it should be enabled
in development builds just so we are up-to-date with future feature infrastructure changes.
The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
that's an obvious goal before enabling the feature in release builds.
- Scripts/webkitperl/FeatureList.pm:
- 2:06 AM Changeset in webkit [145199] by
-
- 5 edits in trunk
[GTK] Remove media stream support from the configuration options
https://bugs.webkit.org/show_bug.cgi?id=111813
Reviewed by Philippe Normand.
Remove the media-stream configuration flag. The feature is incomplete and
thus unsupported, so it really shouldn't be possible to enable it.
- Source/autotools/PrintBuildConfiguration.m4:
- Source/autotools/ReadCommandLineArguments.m4:
- Source/autotools/SetupAutomake.m4:
- Source/autotools/SetupWebKitFeatures.m4:
- 2:04 AM Changeset in webkit [145198] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Skipping the tests in inspector-protocol/layers as they rely on compositing support
which is not available on the GTK builders.
Adding failure expectations for tests that regressed with r145100.
- platform/gtk/TestExpectations:
- 2:01 AM Changeset in webkit [145197] by
-
- 3 edits in trunk/Source/WebCore
Remove dead label code in snapshotted plugin
https://bugs.webkit.org/show_bug.cgi?id=111781
Reviewed by Tim Horton.
Since ports can use the shadow tree to do label display,
there is no need for the hardcoded timers in RenderSnapshottedPlugin.
- rendering/RenderSnapshottedPlugIn.cpp: Remove label flags and timers.
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::~RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::updateSnapshot):
(WebCore::RenderSnapshottedPlugIn::handleEvent):
- rendering/RenderSnapshottedPlugIn.h:
(RenderSnapshottedPlugIn):
Conflicts:
Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp
- 2:01 AM Changeset in webkit [145196] by
-
- 13 edits2 adds in trunk
Implement a custom appearance for the snapshotted plugin background
https://bugs.webkit.org/show_bug.cgi?id=108368
Reviewed by NOBODY (OOPS!).
Source/WebCore:
After https://bugs.webkit.org/show_bug.cgi?id=108284 (r142507), a
snapshotted plugin was no longer drawing the background of the
label blurred. Since the snapshot content was now a shadow tree,
it wasn't feasible to pre-blur a region of the snapshot: the label
could be any size and in any location, with ports being able to
override the appearance through their UA style sheet.
Instead we now use one of the elements in the tree, the snapshot-overlay,
as a hook where ports can add any effect they want. This could be simply
a border, or a transparent mask, or even a CSS filter. We introduce a custom
CSS appearance "snapshotted-plugin-overlay", which could be added to the
element in the injected UA stylesheet. This calls into RenderTheme in
the same way that custom controls do.
Meanwhile, in RenderThemeMac, we implement the appearance by drawing the
content of the plugin snapshot into the background of the element. That
way we can add effects in CSS.
Test: plugins/snapshot-appearance.html
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Handle SnapshottedPluginOverlayPart.
- css/CSSValueKeywords.in: New appearance value snapshotted-plugin-overlay.
- platform/ThemeTypes.h: New value SnapshottedPluginOverlayPart.
- html/HTMLPlugInElement.h:
(WebCore::toHTMLPlugInElement): Add safer casting helpers.
- html/HTMLPlugInImageElement.h:
(WebCore::toHTMLPlugInImageElement): Ditto.
- rendering/RenderSnapshottedPlugIn.cpp: Remove the code for handling
the blur directly in the renderer.
(WebCore::RenderSnapshottedPlugIn::paint): Simplify the paint logic since we're
no longer trying to blur here.
(WebCore::RenderSnapshottedPlugIn::paintSnapshot): Ditto.
- rendering/RenderSnapshottedPlugIn.h: Remove the methods that were trying
to blur the image directly.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint): Call paintSnapshottedPluginOverlay.
- rendering/RenderTheme.h:
(WebCore::RenderTheme::paintSnapshottedPluginOverlay): New virtual method with default implementation.
- rendering/RenderThemeMacShared.h:
(RenderThemeMacShared): Override paintSnapshottedPluginOverlay.
- rendering/RenderThemeMacShared.mm:
(WebCore::RenderThemeMacShared::paintSnapshottedPluginOverlay): Implement a custom render path
that takes the snapshot image from the node's parent, and draws it into the background.
Along the way make sure we're actually using the right type of element (an HTMLPlugInImageElement).
LayoutTests:
Toggles our new snapshotted-plugin-overlay appearance, to make sure it
isn't getting applied to non-plugins.
- plugins/snapshot-appearance-expected.html: Added.
- plugins/snapshot-appearance.html: Added.
- 1:58 AM Changeset in webkit [145195] by
-
- 5 edits2 adds in trunk
Improve drag&drop of list items in contentEditable divs
https://bugs.webkit.org/show_bug.cgi?id=111556
Reviewed by Ryosuke Niwa.
Source/WebCore:
A single fully selected <li> should generate the same markup as if
we were selecting some of them, i.e., we should preserve the list
structure and appearance.
Test: editing/selection/drag-list-item.html
- editing/htmlediting.cpp:
(WebCore::isListItem): modified constness.
- editing/htmlediting.h:
(WebCore): ditto.
- editing/markup.cpp:
(WebCore::highestAncestorToWrapMarkup):
LayoutTests:
Added a new test case. The test performs 2 drag&drops, first of
all a selection of a single list item, and secondly a selection of
two list items. It checks that both behave the same way, i.e, the
whole <li> is moved and not only the text.
- editing/selection/drag-list-item-expected.txt: Added.
- editing/selection/drag-list-item.html: Added.
- 1:44 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:27 AM Changeset in webkit [145194] by
-
- 4 edits in trunk/Source
Cache flush problem on ARMv7 JSC
https://bugs.webkit.org/show_bug.cgi?id=111441
Reviewed by Zoltan Herczeg.
Not proper cache flush causing random crashes on ARMv7 Linux with V8 tests.
The problem is similar to https://bugs.webkit.org/show_bug.cgi?id=77712.
Change the cache fulsh mechanism similar to ARM traditinal and revert the
temporary fix.
Source/JavaScriptCore:
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::cacheFlush):
Source/WTF:
- wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::decommit):
- 1:21 AM Changeset in webkit [145193] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] LayerTiler: rename currentFrameHasAlpha as currentFrameKnownToBeOpaque
https://bugs.webkit.org/show_bug.cgi?id=111828
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-08
Reviewed by Carlos Garcia Campos.
This changed in r141637.
- platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
- 1:17 AM Changeset in webkit [145192] by
-
- 2 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening.
- 12:56 AM Changeset in webkit [145191] by
-
- 2 edits in trunk/Source/WebCore
Fix a couple of typos, unreviewed.
- 12:29 AM Changeset in webkit [145190] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Use OwnPtr for CredentialBackingStore members
https://bugs.webkit.org/show_bug.cgi?id=111737
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.
It simplifies the code a bit.
- platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::~CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::certMgrWrapper):
- platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):
- 12:00 AM Changeset in webkit [145189] by
-
- 2 edits in trunk/Tools
[chromium] delay clearing the TestRunners until the main view was deleted
https://bugs.webkit.org/show_bug.cgi?id=111823
Reviewed by Eric Seidel.
During WebViewHost::shutdown, we navigate the WebView to about:blank.
This may call into the test runners which assume that the delegate is
always non-NULL.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::~TestShell):
Mar 7, 2013:
- 11:57 PM Changeset in webkit [145188] by
-
- 2 edits in trunk/Source/WebCore
MemoryPressureHandler should fully flush the WebCore & NS URL caches
https://bugs.webkit.org/show_bug.cgi?id=111827
Rubber Stamped by Geoff Garen
When the handler is fired we should free as much memory as possible.
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::releaseMemory):
- fully flush the WebCore & NS URL caches
- 11:55 PM Changeset in webkit [145187] by
-
- 3 edits in trunk/Tools
Sheriffbot whois command can't search by full name
https://bugs.webkit.org/show_bug.cgi?id=111825
Patch by Alan Cutter <alancutter@chromium.org> on 2013-03-07
Reviewed by Eric Seidel.
Allowed multiple arguments to Sheriffbot's whois command.
Updated test expectations.
- Scripts/webkitpy/tool/bot/irc_command.py:
(Whois.execute):
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois):
- 11:52 PM WebKitGTK/2.0.x edited by
- (diff)
- 11:46 PM WebKitGTK/2.0.x edited by
- (diff)
- 11:41 PM WebKitGTK/2.0.x edited by
- (diff)
- 11:37 PM Changeset in webkit [145186] by
-
- 58 edits1 copy3 adds2 deletes in trunk
Update calendar picker UI
https://bugs.webkit.org/show_bug.cgi?id=109439
Reviewed by Kent Tamura.
.:
- ManualTests/forms/calendar-picker.html: New test file with more options.
- ManualTests/forms/date-suggestion-picker.html: Copied from ManualTests/forms/calendar-picker.html. Old one kept for dat/time suggestion picker testing.
Source/WebCore:
This patch changes the calendar picker UI.
Added tests to existing calendar picker tests.
Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html
- Resources/pagepopups/calendarPicker.css:
(body):
(.rtl):
(.scroll-view):
(.scroll-view-content):
(.list-cell):
(.list-cell.hidden):
(.day-cell):
(.week-number-cell):
(.day-cell.today):
(.day-cell.highlighted):
(.day-cell.highlighted.disabled):
(.day-cell.selected):
(.day-cell.disabled):
(.day-cell.current-month):
(.calendar-table-view):
(.preparing .calendar-table-view:focus):
(.week-day-label):
(.week-number-label):
(.calendar-table-header-view):
(.calendar-picker):
(.calendar-header-view):
(.calendar-title):
(.rtl .calendar-title):
(.month-popup-button:disabled):
(.month-popup-button):
(.month-popup-button .disclosure-triangle):
(.month-popup-button .disclosure-triangle svg):
(.today-button::after):
(.calendar-navigation-button):
(.year-list-view):
(.year-list-cell):
(.year-list-cell .label):
(.year-list-cell .month-chooser):
(.month-buttons-row):
(.month-button):
(.month-button.highlighted):
(.scrubby-scroll-bar):
(.scrubby-scroll-thumb):
(.month-popup-view):
(.year-list-view .scrubby-scroll-bar):
(.rtl .year-list-view .scrubby-scroll-bar):
- Resources/pagepopups/calendarPicker.js:
(setGlobalParams): Sets the global params.
(initialize):
(openCalendarPicker):
(CalendarHeaderView.prototype.onNavigationButtonClick): Fix typo.
(CalendarPicker):
(CalendarPicker.prototype.onWindowResize): We want to have the "preparing" class applied
to cancel css transitions while setting up the calendar picker so we can avoid flaky pixel tests.
(CalendarPicker.prototype.onYearListViewDidHide): The user clicked on a month so hide the month popup.
(CalendarPicker.prototype.onYearListViewDidSelectMonth): Change the current month in response to the month popup.
(CalendarPicker.prototype.attachTo): We want the calendar table focused when the calendar picker first opens.
(CalendarPicker.prototype.cleanup): Clean up any event listeners or elements attached to nodes outside of this.element.
(CalendarPicker.prototype.onMonthPopupButtonClick): Open the month popup in response to the month popup button being clicked.
(CalendarPicker.prototype._setConfig): Configures the calendar picker.
(CalendarPicker.prototype.currentMonth): The currently shown month.
(CalendarPicker.prototype.setCurrentMonth): Scrolls the calendar table to the given month. Use the navigation behavior param to specify if you want a transition animation.
(CalendarPicker.prototype.adjustHeight): Adjusts the height so its just tall enough to fit the current month. If the month picker is open, fit that.
(CalendarPicker.prototype.selection): Currently selected date range.
(CalendarPicker.prototype.highlight): Currently highlighted date range.
(CalendarPicker.prototype.firstVisibleDay): Returns the first visible day ignoring scroll animation (i.e. this is the first visible day when the scroll animation is done).
(CalendarPicker.prototype.lastVisibleDay): Returns the last visible day ignoring scroll animation.
(CalendarPicker.prototype.selectRangeContainingDay): Sets the selection to the date range containing the given day.
(CalendarPicker.prototype.highlightRangeContainingDay): Sets the highlight to the date range containing the given day.
(CalendarPicker.prototype.setSelection): Sets the selection to the given date range.
(CalendarPicker.prototype._setHighlight): Sets the highlight to the given date range.
(CalendarPicker.prototype._stepMismatch): Just moving.
(CalendarPicker.prototype._outOfRange): Ditto.
(CalendarPicker.prototype.isValid): Returns true if the given date range is a valid selection.
(CalendarPicker.prototype.isValidDay): Returns true if the day is part of a valid selection.
(CalendarPicker.prototype._moveHighlight): Moves the highlight to the given date range if possible. Returns true if it succeeds.
(CalendarPicker.prototype.onCalendarTableKeyDown): Handles the arrow keys, etc.
(CalendarPicker.prototype.width):
(CalendarPicker.prototype.height):
(CalendarPicker.prototype.setHeight):
(CalendarPicker.prototype.onBodyKeyDown): Handles esc/m/y/d.
- Resources/pagepopups/chromium/calendarPickerChromium.css:
(.calendar-table-view:focus):
(.preparing .calendar-table-view:focus):
Source/WebKit/chromium:
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): Adding shortMonthLabels property.
LayoutTests:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt: Removed.
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt: Removed.
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations-expected.txt:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-key-operations-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-datetimelocal-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-datetimelocal.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-pre-100-year-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-pre-100-year.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-with-step-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-with-step.html:
- platform/chromium/fast/forms/calendar-picker/date-picker-events-expected.txt:
- platform/chromium/fast/forms/calendar-picker/date-picker-events.html:
- platform/chromium/fast/forms/calendar-picker/datetimelocal-picker-events-expected.txt:
- platform/chromium/fast/forms/calendar-picker/datetimelocal-picker-events.html:
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations.html:
- platform/chromium/fast/forms/calendar-picker/month-picker-with-step-expected.txt:
- platform/chromium/fast/forms/calendar-picker/month-picker-with-step.html:
- platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
(currentMonth):
(highlightedValue):
(selectedValue):
(skipAnimation):
(hoverOverDayCellAt):
(clickDayCellAt):
- platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations.html:
- platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html:
- platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations.html:
- platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-key-operations.html:
- 11:30 PM Changeset in webkit [145185] by
-
- 3 edits in trunk/Source/WebKit2
[EFL] EwkView should keep css position instead of scroll position in device pixel.
https://bugs.webkit.org/show_bug.cgi?id=110847
Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-07
Reviewed by Kenneth Rohde Christiansen.
Signed off for WebKit2 by Benjamin Poulain.
There are bugs that some code expect that EwkView::pagePosition() returns css
position while others expect that it returns scroll position in device pixel.
In addition, some code call EwkView::setPagePosition() with css position while
others call it with scroll position in device pixel.
This patch makes all code use setPagePosition() and pagePosition() with
UI pixels (a.k.a Density Independent Pixel).
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::setViewportPosition):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::paintToCairoSurface):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::transformToScene):
(WebKit::WebView::pageDidRequestScroll):
- 11:17 PM Changeset in webkit [145184] by
-
- 10 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=111801
https://bugs.webkit.org/show_bug.cgi?id=111801
Reviewed by Geoff Garen.
Move unnecessary includes out of headers.
- NetworkProcess/HostRecord.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
- NetworkProcess/NetworkProcess.cpp:
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
- NetworkProcess/NetworkResourceLoadScheduler.h:
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/SchedulableLoader.cpp:
- NetworkProcess/SchedulableLoader.h:
- NetworkProcess/SyncNetworkResourceLoader.cpp:
- 11:10 PM Changeset in webkit [145183] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Remove unused return value after r122962
https://bugs.webkit.org/show_bug.cgi?id=111821
Patch by Seokju Kwon <Seokju Kwon> on 2013-03-07
Reviewed by Pavel Feldman.
No new tests.
- inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel.prototype.jumpToPreviousSearchResult):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
- 11:02 PM Changeset in webkit [145182] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: compositing/rtl/rtl-iframe-absolute-overflow.html
- 10:29 PM Changeset in webkit [145181] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: fast/js/exception-sequencing-binops2.html
- 9:51 PM Changeset in webkit [145180] by
-
- 8 edits in trunk/Source
Unreviewed, rolling out r145166.
http://trac.webkit.org/changeset/145166
https://bugs.webkit.org/show_bug.cgi?id=111819
build break - no symbol
webkit_support::CreateScopedTempDirectory() (Requested by
hayato on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-07
Source/WebCore:
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore):
(WebCore::IDBBackingStore::~IDBBackingStore):
(WebCore::IDBBackingStore::open):
- Modules/indexeddb/IDBBackingStore.h:
(WebCore):
(IDBBackingStore):
- Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::addIDBBackingStore):
(WebCore):
(WebCore::IDBFactoryBackendImpl::removeIDBBackingStore):
(WebCore::IDBFactoryBackendImpl::openBackingStore):
- Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl):
Source/WebKit/chromium:
- tests/IDBBackingStoreTest.cpp:
(WebCore::IDBBackingStoreTest::SetUp):
(IDBBackingStoreTest):
- tests/IDBCleanupOnIOErrorTest.cpp:
(WebCore::TEST):
- 9:49 PM Changeset in webkit [145179] by
-
- 6 edits1 delete in trunk/Source
Source/ThirdParty: Replace Mersenne Twister RNG with a simple but fast RNG
https://bugs.webkit.org/show_bug.cgi?id=111533
Patch by Andrew Bortz <andrew@abortz.net> on 2013-03-07
Reviewed by Adam Barth.
This code is no longer used.
- mt19937ar.c: Removed.
Source/WTF: Replace Mersenne Twister random number generator with a simpler one.
https://bugs.webkit.org/show_bug.cgi?id=111533
Patch by Andrew Bortz <andrew@abortz.net> on 2013-03-07
Reviewed by Adam Barth.
The new generator is only a single line long, but passes all the Diehard
statistical tests and runs ~3x faster than the Mersenne Twister, with a
guaranteed cycle length of 264 and only 8 bytes of state.
- wtf/Platform.h: Mersenne Twister defines are no longer needed
- wtf/RandomNumber.cpp:
(WTF::Internal::initializeRandomNumber): State initialization
(WTF::Internal::randomNumber): Actual implementation
(WTF::randomNumber): We don't need to fall back on rand()-based generator anymore,
so this code is greatly simplified.
- wtf/RandomNumber.h:
- wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator): This code is no longer needed.
Additionally, the code had an error, since rand() returns 32-bits, so each
initializationBuffer's upper 16-bits has more bits set than random.
- 8:48 PM Changeset in webkit [145178] by
-
- 2 edits in trunk/LayoutTests
Add Mac WebKit2 test expectations per bugs 111814 and 111815.
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2013-03-07
- platform/mac-wk2/TestExpectations:
- 8:31 PM Changeset in webkit [145177] by
-
- 2 edits in trunk/LayoutTests
Add Mac WebKit2 test expectations per bugs 111814 and 111815.
- platform/mac-wk2/TestExpectations:
- 8:29 PM Changeset in webkit [145176] by
-
- 2 edits in trunk/Tools
Add Nils Barth and Koji Hara to committers.py
https://bugs.webkit.org/show_bug.cgi?id=111806
Patch by Nils Barth <nbarth@chromium.org> on 2013-03-07
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/config/committers.py:
- 8:25 PM Changeset in webkit [145175] by
-
- 5 edits in trunk
Custom Elements: CustomElement constructor shouldn't share function instance
https://bugs.webkit.org/show_bug.cgi?id=111807
Reviewed by Kentaro Hara.
Source/WebCore:
Adaptor functions of custom elements unintentionally share the instance.
This fix gives new one for each.
Test: Updated fast/dom/custom/document-register-basic.html
- bindings/v8/V8AdaptorFunction.cpp:
(WebCore::V8AdaptorFunction::wrap):
LayoutTests:
- fast/dom/custom/document-register-basic-expected.txt:
- fast/dom/custom/document-register-basic.html:
- 8:24 PM Changeset in webkit [145174] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/win/TestExpectations: Remove duplication of svg/custom/foreign-object-skew.svg.
- 8:11 PM Changeset in webkit [145173] by
-
- 5 edits in trunk/Tools
run-pert-tests should have a --test-runner-count option
https://bugs.webkit.org/show_bug.cgi?id=111726
Reviewed by Ryosuke Niwa.
Add --test-runner-count option to run-perf-tests, with default value of 4.
This option allows command line configuration of the number of times to invoke
the test runner (serially, not in parallel) when running a specific test in
a test set.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
(PerfTest.init): Rename process_run_count to test_runner_count (throughout).
(PerfTest.run): Rename process_run_count to test_runner_count.
(SingleProcessPerfTest.init): Add test_runner_count optional argument.
(ChromiumStylePerfTest.init): Add test_runner_count optional argument.
(ReplayPerfTest.init): Add test_runner_count optional argument.
(PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args): Add '--test-runner-count' option.
(PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(MainTest._test_run_with_json_output): Add optional compare_logs argument.
(MainTest.test_run_with_repeat):
(MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_default_args): Add test for default option argument values.
(MainTest.test_parse_args): Add test for test-runner-count option parsing.
- 7:52 PM Changeset in webkit [145172] by
-
- 6 edits in trunk
Reading border radius from style property returns in wrong order.
https://bugs.webkit.org/show_bug.cgi?id=110853
Source/WebCore:
Patch by Jared Wyles <wyles@adobe.com> on 2013-03-07
Reviewed by Ryosuke Niwa
Updating the order of border-radius to return in the order specified
in http://www.w3.org/TR/css3-background/#the-border-radius
Tests updated in LayoutTests/fast/borders/border-radius-parsing.html
Changed the expectations in LayoutTests/inspector/elements/elements-panel-styles-expected.txt
Compat information -
jQuery's css function favours using getComputedStyle for elements so that should not be impacted.
Zepto does check for the element on style first so may be a slight concern there.
- css/StylePropertyShorthand.cpp:
(WebCore::borderRadiusShorthand):
LayoutTests:
Patch by Jared Wyles <wyles@adobe.com> on 2013-03-07
Reviewed by Ryosuke Niwa
- fast/borders/border-radius-parsing-expected.txt:
- fast/borders/border-radius-parsing.html:
- inspector/elements/elements-panel-styles-expected.txt:
- 7:01 PM Changeset in webkit [145171] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION (r143759): 40% JSBench regression, 20% Octane/closure regression, 40% Octane/jquery regression, 2% Octane regression
https://bugs.webkit.org/show_bug.cgi?id=111797
Reviewed by Oliver Hunt.
The bot's testing configuration stresses the cache's starting guess
of 1MB.
This patch removes any starting guess, and just uses wall clock time
to discover the initial working set size of an app, in code size.
- runtime/CodeCache.cpp:
(JSC::CodeCacheMap::pruneSlowCase): Update our timer as we go.
Also fixed a bug where pruning from 0 to 0 would hang -- that case is
a possibility now that we start with a capacity of 0.
- runtime/CodeCache.h:
(CodeCacheMap):
(JSC::CodeCacheMap::CodeCacheMap):
(JSC::CodeCacheMap::add):
(JSC::CodeCacheMap::prune): Don't prune if we're in the middle of
discovering the working set size of an app, in code size.
- 6:29 PM Changeset in webkit [145170] by
-
- 4 edits in trunk/Source/WebKit/mac
Add didFocusTextField:inFrame to WebFormDelegate
https://bugs.webkit.org/show_bug.cgi?id=111804
Reviewed by Dan Bernstein.
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::focusedNodeChanged):
- WebView/WebFormDelegate.h:
- WebView/WebFormDelegate.m:
(-[WebFormDelegate didFocusTextField:inFrame:]):
- 6:24 PM Changeset in webkit [145169] by
-
- 13 edits in trunk/Source
Resizing Cappuccino is very laggy on WebKit since Safari 5.1
<http://webkit.org/b/71354>
<rdar://problem/10565998>
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.exp.in: Export FloatPoint(const NSPoint&)
Source/WebKit2:
On Mac, we already cache the window rect through the WindowAndViewFramesChanged
message, so simply return that in WebChromeClient::windowRect() instead of
sending a synchronous query to the UIProcess.
If a programmatic resize is requested, we bypass the cache until we've received
a new WindowAndViewFramesChanged message. This compromise allows us to return
cached rects in the common case, and handles creating a new window and immediately
resizing it gracefully.
Changed WindowAndViewFramesChanged to pass FloatRect/FloatPoint rather than
IntRect/IntPoint to match the ChromeClient::windowRect() return type.
- UIProcess/API/mac/WKView.mm:
(-[WKView _updateWindowAndViewFrames]):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::windowAndViewFramesChanged):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::windowAndViewFramesChanged):
- WebProcess/Plugins/PluginView.h:
(PluginView):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setWindowRect):
(WebKit::WebChromeClient::windowRect):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::sendSetWindowFrame):
(WebKit::WebPage::windowAndViewFramesChanged):
- WebProcess/WebPage/WebPage.h:
(WebPage):
(WebKit::WebPage::windowFrameInScreenCoordinates):
(WebKit::WebPage::viewFrameInWindowCoordinates):
(WebKit::WebPage::hasCachedWindowFrame):
(WebKit::WebPage::accessibilityPosition):
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):
- 6:08 PM Changeset in webkit [145168] by
-
- 27 edits8 deletes in trunk
Remove desktop version of -webkit-text-size-adjust property.
<http://webkit.org/b/56543>
<rdar://problem/9150203>
Reviewed by Simon Fraser.
Source/WebCore:
This property existed to support a number of Apple-internal clients of WebKit.
We no longer need this property, and since it's clashing with a mobile version of the
same property with different meaning, let's remove it altogether from the desktop build.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyLineHeight::applyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyProperty):
- css/StyleResolver.h:
(StyleResolver):
- css/svg.css:
- editing/EditingStyle.cpp:
- inspector/front-end/inspector.css:
(#console-messages):
- inspector/front-end/resourcesPanel.css:
(.storage-view.query):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
LayoutTests:
- editing/pasteboard/5078739.html:
- editing/pasteboard/data-transfer-items-expected.txt:
- editing/pasteboard/onpaste-text-html-expected.txt:
- fast/css/font-size-nan.svg:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/getComputedStyle/resources/property-names.js:
- fast/css/ignore-text-zoom.html: Removed.
- fast/css/text-rendering-priority.html:
- fast/events/ondrop-text-html-expected.txt:
- platform/chromium-linux/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/chromium-mac-lion/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/chromium-mac/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/chromium-win/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/chromium-win/fast/css/ignore-text-zoom-expected.txt: Removed.
- platform/chromium/fast/css/ignore-text-zoom-expected.txt: Removed.
- platform/efl/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/efl/fast/css/ignore-text-zoom-expected.txt: Removed.
- platform/gtk/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/gtk/fast/css/ignore-text-zoom-expected.txt: Removed.
- platform/mac/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/mac/fast/css/ignore-text-zoom-expected.txt: Removed.
- platform/qt/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/qt/fast/css/ignore-text-zoom-expected.txt: Removed.
- 5:47 PM Changeset in webkit [145167] by
-
- 2 edits in trunk/Source/WebKit2
Don't try to create a sandbox extension when path is empty
https://bugs.webkit.org/show_bug.cgi?id=111788
Reviewed by Anders Carlsson.
- Shared/FileAPI/BlobRegistrationData.cpp:
(WebKit::BlobRegistrationData::BlobRegistrationData): Skip File objects with empty
paths to avoid logging an error to console.
- 5:42 PM Changeset in webkit [145166] by
-
- 8 edits in trunk/Source
IndexedDB: Use WeakPtr for Factory-to-BackingStore reference
https://bugs.webkit.org/show_bug.cgi?id=111459
Reviewed by Adam Barth.
Source/WebCore:
IDBFactoryBackendImpl maintains a map of backing stores - if another database in the same
origin is opened, the backing store instance must be re-used). This was a map to raw
pointers so that the backing store can be collected when all database references are
dropped. The map was maintained manually by passing the factory to the IDBBackingStore which
would add/remove itself on creation/destruction.
Replace this with a HashMap<WeakPtr<>>. This simplifies the plumbing; map entries
"leak" but are purged on subsequent opens.
Added webkit_unit_test (Chromium port) to verify refcounts.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore): No need to notify factory of lifetime.
(WebCore::IDBBackingStore::~IDBBackingStore): Ditto.
(WebCore::IDBBackingStore::open): Ditto.
- Modules/indexeddb/IDBBackingStore.h: No reference to the factory, but...
(WebCore::IDBBackingStore::createWeakPtr): Do need to expose weak pointers for the factory to hold.
- Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::cleanWeakMap): Helper function to scrub a HashMap<WeakPtr<T>> of empty pointers.
May move to WTF when we've learned how general it is, or come up with a dedicated WeakPtrHashMap type.
(WebCore::IDBFactoryBackendImpl::openBackingStore): WeakPtr fu.
- Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl): Remove plumbing methods.
Source/WebKit/chromium:
Added tests to verify refcounts on backing stores, update method signatures.
- tests/IDBBackingStoreTest.cpp:
(WebCore::IDBBackingStoreTest::SetUp): No dummy factory needed.
(MockIDBFactoryBackend): Expose protected method to tests.
(WebCore::TEST): Added BackingStoreLifetime test.
- tests/IDBCleanupOnIOErrorTest.cpp: No dummy factory needed.
- 5:36 PM Changeset in webkit [145165] by
-
- 2 edits in trunk/LayoutTests
Fix commented out code in LayoutTests/http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html
https://bugs.webkit.org/show_bug.cgi?id=111800
Unreviewed.
- http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html:
- 5:31 PM Changeset in webkit [145164] by
-
- 5 edits in trunk/Source/WebKit2
WebPageProxy::exceededDatabaseQuota() needs to be serialized.
https://bugs.webkit.org/show_bug.cgi?id=111631.
Reviewed by Geoffrey Garen.
Previously, WebPageProxy::exceededDatabaseQuota() is called synchronously
with script execution in the WebProcess. Hence, it is never called in a
recursive manner.
In webkit2, we can have multiple WebProcesses concurrently triggering a
call to this function. While the function is waiting on feedback from a
UI dialog, the wait loop may re-enter the function to service a second
request to call this function from another WebProcess. This results in
problems where some of the WebProcesses will not get a proper reply, and
therefore hangs perpetually waiting for a non-forthcoming reply.
This changeset changes the function to queue the requests and ensure
that we do not recursively callback to the UI client.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
- UIProcess/WebPageProxy.cpp:
(ExceededDatabaseQuotaRecords):
(Record):
(WebKit::ExceededDatabaseQuotaRecords::areBeingProcessed):
(WebKit::ExceededDatabaseQuotaRecords::ExceededDatabaseQuotaRecords):
(WebKit::ExceededDatabaseQuotaRecords::~ExceededDatabaseQuotaRecords):
(WebKit::ExceededDatabaseQuotaRecords::shared):
(WebKit::ExceededDatabaseQuotaRecords::createRecord):
(WebKit::ExceededDatabaseQuotaRecords::add):
(WebKit::ExceededDatabaseQuotaRecords::next):
(WebKit::WebPageProxy::exceededDatabaseQuota):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- 5:31 PM Changeset in webkit [145163] by
-
- 14 edits in trunk/Source
[BlackBerry] RefCounting ParsedCookie to avoid SegFaults
https://bugs.webkit.org/show_bug.cgi?id=111761
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-03-07
Reviewed by Rob Buis.
Source/WebCore:
Making necessary changes to ref count the ParsedCookie object.
Tested using the opera cookie test suite and the BB Browser cookie test suite.
Tested using the browser, visiting popular sites such as facebook, reddit, google etc
to ensure cookie functionality isn't changed.
- loader/blackberry/CookieJarBlackBerry.cpp:
(WebCore::getRawCookies):
- platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore::CookieDatabaseBackingStore::insert):
(WebCore::CookieDatabaseBackingStore::update):
(WebCore::CookieDatabaseBackingStore::remove):
(WebCore::CookieDatabaseBackingStore::getCookiesFromDatabase):
(WebCore::CookieDatabaseBackingStore::invokeGetCookiesWithLimit):
(WebCore::CookieDatabaseBackingStore::invokeSendChangesToDatabase):
(WebCore::CookieDatabaseBackingStore::addToChangeQueue):
- platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
(CookieDatabaseBackingStore):
- platform/blackberry/CookieManager.cpp:
(WebCore::cookieSorter):
(WebCore::CookieManager::setCookies):
(WebCore::CookieManager::getCookie):
(WebCore::CookieManager::generateHtmlFragmentForCookies):
(WebCore::CookieManager::getRawCookies):
(WebCore::CookieManager::checkAndTreatCookie):
(WebCore::CookieManager::addCookieToMap):
(WebCore::CookieManager::getBackingStoreCookies):
(WebCore::CookieManager::findOrCreateCookieMap):
(WebCore::CookieManager::removeCookieWithName):
(WebCore::CookieManager::cookieLimitCleanUp):
- platform/blackberry/CookieManager.h:
- platform/blackberry/CookieMap.cpp:
(WebCore::CookieMap::addOrReplaceCookie):
(WebCore::CookieMap::removeCookieAtIndex):
(WebCore::CookieMap::removeCookie):
(WebCore::CookieMap::getAllCookies):
(WebCore::CookieMap::removeOldestCookie):
(WebCore::CookieMap::deleteAllCookiesAndDomains):
(WebCore::CookieMap::getAllChildCookies):
- platform/blackberry/CookieMap.h:
(CookieMap):
- platform/blackberry/CookieParser.cpp:
(WebCore):
(WebCore::CookieParser::parse):
(WebCore::CookieParser::parseOneCookie):
- platform/blackberry/CookieParser.h:
(CookieParser):
- platform/blackberry/ParsedCookie.cpp:
- platform/blackberry/ParsedCookie.h:
(ParsedCookie):
(WebCore::ParsedCookie::create):
Source/WebKit/blackberry:
Making necessary changes to ref-count the ParsedCookie object.
- Api/WebCookieJar.cpp:
(BlackBerry::WebKit::WebCookieJar::cookies):
- 5:12 PM Changeset in webkit [145162] by
-
- 7 edits3 adds in trunk
Heap-use-after-free in WebCore::HTMLMediaElement::~HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=110623
Reviewed by Kentaro Hara.
Source/WebCore:
Test: http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html
- bindings/v8/V8GCController.cpp: Fix MinorGCWrapperVisitor so it doesn't collect ActiveDOMObjects
that have pending activity.
- html/HTMLAudioElement.h:
(HTMLAudioElement): Removed hasPendingActivity() now that this is handled by the base class.
- html/HTMLAudioElement.idl: Removed ActiveDOMObject annotation since HTMLMediaElement now has it.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::hasPendingActivity): Update implementation to return true if the media
has audio and is playing. This brings the code into
compliance with the detached element behavior outlined
in the HTML5 spec.
- html/HTMLMediaElement.idl: Added ActiveDOMObject annotation so that all derived classes are
considered ActiveDOMObjects.
LayoutTests:
- http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal-expected.txt: Added.
- http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html: Added.
- http/tests/misc/resources/delete-frame-during-readystatechange-frame-with-gc-after-video-removal.html: Added.
- 5:10 PM Changeset in webkit [145161] by
-
- 7 edits in trunk/Source
CFNetwork cache partitioning does not work properly on subdomains
https://bugs.webkit.org/show_bug.cgi?id=111772
Reviewed by David Kilzer.
Source/WebCore:
Ensure that the cache partitioning is done over the top privately-controlled domain for the NSURLRequest.
Not possible to test with current automated test tools, must be tested manually.
- loader/cache/MemoryCache.cpp: Remove extraneous calls to partitionName
(WebCore):
(WebCore::MemoryCache::add):
(WebCore::MemoryCache::revalidationSucceeded):
(WebCore::MemoryCache::resourceForRequest):
(WebCore::MemoryCache::evict):
(WebCore::MemoryCache::removeResourcesWithOrigin):
- platform/network/cf/ResourceRequest.h: Put top privately-controlled domain reduction code into ResourceRequest::partitionName
(ResourceRequest):
(WebCore::ResourceRequest::cachePartition):
(WebCore::ResourceRequest::setCachePartition): Pre-process the partition name
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore):
(WebCore::ResourceRequest::partitionName):
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdatePlatformRequest): Use a UTF-8 version of the cache partition name
Source/WebKit2:
Ensure that the CFString is UTF-8 so that WKCFURLCacheCopyAllHostNamesInPersistentStoreForPartition will always work.
- WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
(WebKit::partitionName): Create a UTF-8 CFString explicitly
- 5:06 PM Changeset in webkit [145160] by
-
- 2 edits in trunk/LayoutTests
Roll out an accidentally committed change I made for local testing.
- http/tests/misc/empty-file-formdata.html:
- 5:06 PM Changeset in webkit [145159] by
-
- 2 edits in trunk/Source/WebCore
Compute WebGL context attributes from DrawingBuffer when it is used
https://bugs.webkit.org/show_bug.cgi?id=111666
Reviewed by James Robinson.
Fixed computation of antialias flag when DrawingBuffer is used.
No new tests; covered by existing tests. Ran WebGL conformance
tests on desktop Linux and Android to test.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::getContextAttributes):
Query DrawingBuffer, when used, for antialias flag.
- 4:59 PM Changeset in webkit [145158] by
-
- 2 edits in trunk/Tools
Add myself to reviewers.py
https://bugs.webkit.org/show_bug.cgi?id=111757
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-07
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/config/committers.py:
- 4:59 PM Changeset in webkit [145157] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: fast/events/before-unload-adopt-subframe-to-outside.html
- 4:57 PM Changeset in webkit [145156] by
-
- 11 edits in trunk/Source
Need API to draw custom overhang area
https://bugs.webkit.org/show_bug.cgi?id=111679
-and corresponding-
<rdar://problem/13291415>
Reviewed by Simon Fraser.
Source/WebCore:
This will allow clients to put custom images into the top or bottom overhang area.
New FrameView API takes a bool indicating whether the client wants a top/bottom
overhang layer. If the bool is true, the overhang layer will be returned.
- WebCore.exp.in:
- page/FrameView.cpp:
(WebCore::FrameView::setWantsLayerForTopOverHangArea):
(WebCore::FrameView::setWantsLayerForBottomOverHangArea):
- page/FrameView.h:
(FrameView):
Keep member variables for the top and bottom overhang layers. Create them if
necessary, and update them if the root layer changes.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::RenderLayerCompositor::updateLayerForTopOverhangArea):
(WebCore::RenderLayerCompositor::updateLayerForBottomOverhangArea):
(WebCore::RenderLayerCompositor::reportMemoryUsage):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
Source/WebKit2:
The new API is WKBundlePageSetTopOverhangImage() and
WKBundlePageSetBottomOverhangImage(). When the API is called, WebPage will get
GraphicsLayers for the appropriate area from FrameView, and then set the image as
the contents of the layer.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetTopOverhangImage):
(WKBundlePageSetBottomOverhangImage):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::setTopOverhangImage):
(WebKit):
(WebKit::WebPage::setBottomOverhangImage):
- 4:54 PM Changeset in webkit [145155] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium-linux/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- 4:53 PM Changeset in webkit [145154] by
-
- 4 edits in trunk/Source
Reduce page cache size on Mac
https://bugs.webkit.org/show_bug.cgi?id=111795
Rubber stamped by Geoff Garen
5 entries is unnecessarily large; research show 3 should suffice.
On a low memory warning we should clear this completely.
Source/WebCore:
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::releaseMemory):
- clear the page cache completely
Source/WebKit2:
- Shared/CacheModel.cpp:
(WebKit::calculateCacheSizes):
- reduce maximum to 3.
- 4:44 PM Changeset in webkit [145153] by
-
- 3 edits in trunk/LayoutTests
Adding id attribute test for MediaStream
https://bugs.webkit.org/show_bug.cgi?id=111526
Reviewed by Kentaro Hara.
Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#widl-MediaStream-id
The id strings must only use characters in the ranges U+0021, U+0023 to U+0027,
U+002A to U+002B, U+002D to U+002E, U+0030 to U+0039, U+0041 to U+005A,
U+005E to U+007E, and must be 36 characters long.
- fast/mediastream/MediaStreamConstructor-expected.txt:
- fast/mediastream/MediaStreamConstructor.html:
- 4:38 PM Changeset in webkit [145152] by
-
- 4 edits in trunk/Tools
run-perf-tests should have a --repeat option
https://bugs.webkit.org/show_bug.cgi?id=100030
Reviewed by Ryosuke Niwa.
Add --repeat option to run-perf-tests, with default value of 1. When greater
than 1, runs test set specified number of times. Note that multiple runs are
not aggregated for statistical purposes.
Incidentally fixed typo: s/suceeds/succeeds/.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args): Add repeat option.
(PerfTestsRunner.run): Add outer repeat loop.
(PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
(PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
(MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
(MainTest.test_run_with_json_output): Fix typo.
(MainTest.test_run_with_description): Fix typo.
(MainTest.test_run_respects_no_results): Fix typo.
(MainTest.test_run_with_slave_config_json): Fix typo.
(MainTest.test_run_with_multiple_repositories): Fix typo.
(MainTest.test_run_with_upload_json): Fix typo.
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
(MainTest.test_run_with_repeat): Added new test for repeat count semantics.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_parse_args): Add test for repeat option parsing.
- 4:26 PM Changeset in webkit [145151] by
-
- 2 edits in trunk/LayoutTests
border-fit should happen at layout time rather than paint time
https://bugs.webkit.org/show_bug.cgi?id=111606
Unreviewed. Skipping some broken tests.
- platform/mac/TestExpectations:
- 4:19 PM Changeset in webkit [145150] by
-
- 3 edits in trunk/Source/JavaScriptCore
Crash when updating predictions below JSC::arrayProtoFuncForEach on tuaw.com article
https://bugs.webkit.org/show_bug.cgi?id=111777
Reviewed by Filip Pizlo.
Moved register allocations to be above any generated control flow so that any
resulting spill would be visible to all subsequently generated code.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):
- 3:54 PM Changeset in webkit [145149] by
-
- 5 edits in branches/safari-534.59-branch/Source
Versioning.
- 3:54 PM Changeset in webkit [145148] by
-
- 14 edits4 moves in trunk/Source/WebCore
Rename Mac's TileCache to TileController, and WebTileCacheLayer to WebTiledBackingLayer
https://bugs.webkit.org/show_bug.cgi?id=111779
Reviewed by Tim Horton.
"TileCache" was a name conflict in downstream code, so rename it to TileController.
The layer that has a TileController is now a WebTiledBackingLayer (which fits with
the TiledBacking API that TileController exposes).
Also renamed the flags in PlatformCALayer to match.
Rename only, no behavior change.
- WebCore.xcodeproj/project.pbxproj:
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::logExposedUnfilledArea):
- platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::shouldUseTiledBacking):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter):
(WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
(WebCore::GraphicsLayerCA::updateVisibleRect):
(WebCore::GraphicsLayerCA::getDebugBorderInfo):
(WebCore::GraphicsLayerCA::requiresTiledLayer):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::usesTiledBackingLayer):
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::PlatformCALayer):
(PlatformCALayer::~PlatformCALayer):
(PlatformCALayer::tiledBacking):
- platform/graphics/ca/mac/TileController.h: Renamed from Source/WebCore/platform/graphics/ca/mac/TileCache.h.
- platform/graphics/ca/mac/WebTileLayer.h:
(TileController):
- platform/graphics/ca/mac/WebTileLayer.mm:
(-[WebTileLayer drawInContext:]):
(-[WebTileLayer setTileController:WebCore::]):
(-[WebTileLayer logFilledFreshTile]):
- platform/graphics/ca/mac/WebTiledBackingLayer.h: Renamed from Source/WebCore/platform/graphics/ca/mac/WebTileCacheLayer.h.
- platform/graphics/ca/mac/WebTiledBackingLayer.mm: Renamed from Source/WebCore/platform/graphics/ca/mac/WebTileCacheLayer.mm.
- platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::shouldUseTiledBacking):
(WebCore::RenderLayerBacking::adjustTiledBackingCoverage):
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
- rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::usingTiledBacking):
(RenderLayerBacking):
(WebCore::RenderLayerBacking::hasTiledBackingFlatteningLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidLayout):
(WebCore::RenderLayerCompositor::rootFixedBackgroundsChanged):
(WebCore::RenderLayerCompositor::supportsFixedRootBackgroundCompositing):
- 3:52 PM Changeset in webkit [145147] by
-
- 1 copy in tags/Safari-534.59.1
New Tag.
- 3:48 PM Changeset in webkit [145146] by
-
- 2 edits in trunk/Tools
showAllRuns checkbox no longer works on the stats dashboard
https://bugs.webkit.org/show_bug.cgi?id=111673
Reviewed by Ojan Vafai.
Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
so we were trying to index into an undefined object.
- TestResultServer/static-dashboards/dashboard_base.js:
(invalidateQueryParameters):
- 3:45 PM Changeset in webkit [145145] by
-
- 4 edits3 adds in trunk
DFG should not get corrupted IR in the case of code that is dead, unreachable, and contains a chain of nodes that use each other in an untyped way
https://bugs.webkit.org/show_bug.cgi?id=111783
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Unreachable code is not touched by CFA and so thinks that even untyped uses are checked.
But dead untyped uses don't need checks and hence don't need to be Phantom'd. The DCE knew
this in findTypeCheckRoot() but not in eliminateIrrelevantPhantomChildren(), leading to a
Phantom node that had another Phantom node as one of its kids.
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::eliminateIrrelevantPhantomChildren):
LayoutTests:
Reviewed by Mark Hahnenberg.
- fast/js/dfg-dead-unreachable-code-with-chain-of-dead-unchecked-nodes-expected.txt: Added.
- fast/js/dfg-dead-unreachable-code-with-chain-of-dead-unchecked-nodes.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-dead-unreachable-code-with-chain-of-dead-unchecked-nodes.js: Added.
(foo.bar):
(foo):
- 3:42 PM Changeset in webkit [145144] by
-
- 2 edits in trunk/Tools
[Chromium] Update #include for WebStorageNamespace.h
https://bugs.webkit.org/show_bug.cgi?id=111748
Reviewed by Adam Barth.
In anticipation of removing
WK/chromium/public/WebStorageNamespace.h (once downstream
references have been updated)
- DumpRenderTree/chromium/WebViewHost.cpp:
- 3:11 PM Changeset in webkit [145143] by
-
- 2 edits in trunk/Source/JavaScriptCore
The DFG fixpoint is not strictly profitable, and should be straight-lined
https://bugs.webkit.org/show_bug.cgi?id=111764
Reviewed by Oliver Hunt and Geoffrey Garen.
The DFG previously ran optimizations to fixpoint because there exists a circular dependency:
CSE depends on CFG simplification: CFG simplification merges blocks, and CSE is block-local.
CFG simplification depends on CFA and constant folding: constant folding reveals branches on
constants.
CFA depends on CSE: CSE reveals must-alias relationships by proving that two operations
always produce identical values.
Arguments simplification also depends on CSE, but it ought not depend on anything else.
Hence we get a cycle like: CFA -> folding -> CFG -> CSE -> CFA.
Note that before we had sparse conditional CFA, we also had CFA depending on CFG. This ought
not be the case anymore: CFG simplification should not by itself lead to better CFA results.
My guess is that the weakest link in this cycle is CFG -> CSE. CSE cuts both ways: if you
CSE too much then you increase register pressure. Hence it's not clear that you always want
to CSE after simplifying control flow. This leads to an order of optimization as follows:
CSE -> arguments -> CFA -> folding -> CFG
This is a 2.5% speed-up on SunSpider, a 4% speed-up on V8Spider, a possible 0.3% slow-down
on V8v7, nothing on Kraken, and 1.2% speed-up in the JSRegress geomean. I'll take a 2.5%
speed-up over a 0.3% V8v7 speed-up.
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- 2:52 PM Changeset in webkit [145142] by
-
- 5 edits5 adds in trunk
FormData should allow setting filename to empty
https://bugs.webkit.org/show_bug.cgi?id=111687
Reviewed by Brady Eidson.
Tests: http/tests/local/formdata/send-form-data-with-empty-blob-filename.html
http/tests/local/formdata/send-form-data-with-empty-file-filename.html
- platform/network/FormData.cpp: (WebCore::FormData::appendKeyValuePairItems): Missing value is a null string. If the string is empty, we should treat is as authoritative.
- 2:40 PM Changeset in webkit [145141] by
-
- 8 edits in trunk/Tools
run-perf-tests fails due to svn_revision not working on a pure git clone
https://bugs.webkit.org/show_bug.cgi?id=110839
Reviewed by Ryosuke Niwa.
Previously we would call git svn find-rev to look up the commit for
a given revision, and that'll hang in a pure git checkout.
This patch changes the way we look up svn revisions in a git
repository to use git log --grep 'git-svn-id', which is much faster
than grepping ourselves. It also renames timestamp_of_latest_commit()
to timestamp_of_revision() in order to accurately reflect what
the method is doing. Note that this patch only changes the logic
inside latest_revision() and svn_revision(). I'll file a separate
bug to change git_commit_from_svn_revision().
This patch also contains some fixes to unit tests that had bit-rotted
or were otherwise fragile, so that test-webkitpy --all would pass
cleanly, and a fix to outputcapture so that
test-webkitpy -p would work correctly again.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.svn_revision):
(Git.timestamp_of_revision):
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.svn_revision):
(SCM.timestamp_of_revision):
- Scripts/webkitpy/common/checkout/scm/scm_mock.py:
(MockSCM.timestamp_of_revision):
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(_shared_test_commit_with_message):
(test_commit_without_authorization):
(test_timestamp_of_revision):
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.timestamp_of_revision):
- Scripts/webkitpy/common/system/outputcapture.py: Importing unittest2 directly may not be safe if this module is imported before the autoinstaller gets a chance to set things up properly. We don't actually need unittest2 here.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_results_dict):
- 2:37 PM Changeset in webkit [145140] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening AppleWin port.
- platform/win/TestExpectations:
- 2:33 PM Changeset in webkit [145139] by
-
- 5 edits in trunk
REGRESSION: fast/border/border-fit-2.html needs updating
https://bugs.webkit.org/show_bug.cgi?id=111776
Reviewed by Simon Fraser.
Source/WebCore:
This test is incorrectly shrinking the border image now.
We need to apply some clamping to the border-fit like the
old code did. The pixel results *are* still changing though,
since a layout-time shrinkage will not result in right-aligned
boxes in an LTR block when the left edge gets chopped. We'll
have to see if this behavioral change ends up being a problem,
but for now we'll rebaseline and assume it will be ok.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::fitBorderToLinesIfNeeded):
LayoutTests:
- platform/mac/fast/borders/border-fit-2-expected.png:
- platform/mac/fast/borders/border-fit-2-expected.txt:
- 2:32 PM Changeset in webkit [145138] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 2:31 PM Changeset in webkit [145137] by
-
- 1 copy in tags/Safari-536.29.5
New Tag.
- 2:21 PM Changeset in webkit [145136] by
-
- 5 edits2 adds in trunk
Web Inspector: provide reasons why a layer was composited in the LayerTreeAgent
https://bugs.webkit.org/show_bug.cgi?id=111703
Source/WebCore:
Introduce a new LayerTree.reasonsForCompositingLayer(layerId) method which returns
the list of reasons why the provided layer was composited as an object with an
optional property for each possible reason. The RenderLayerCompositor already knows
how to provide this information via its own reasonsForCompositing() method, and we
process the returned bitmask to populate the object sent to the front-end.
Reviewed by Timothy Hatcher.
Test: inspector-protocol/layers/layers-compositing-reasons.html
- inspector/Inspector.json:
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
(WebCore):
- inspector/InspectorLayerTreeAgent.h:
(InspectorLayerTreeAgent):
LayoutTests:
New test for LayerTree.reasonsForCompositingLayer(layerId).
Reviewed by Timothy Hatcher.
- inspector-protocol/layers/layers-compositing-reasons-expected.txt: Added.
- inspector-protocol/layers/layers-compositing-reasons.html: Added.
- 2:13 PM Changeset in webkit [145135] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: http/tests/security/cross-origin-css.html
- 2:07 PM Changeset in webkit [145134] by
-
- 2 edits1 move in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium-mac/fast/repaint/border-fit-lines-expected.txt: Renamed from LayoutTests/platform/chromium/fast/repaint/border-fit-lines-expected.txt.
- platform/chromium-win/fast/repaint/border-fit-lines-expected.txt:
- 2:02 PM Changeset in webkit [145133] by
-
- 9 edits in trunk/Source
Add a didFocusTextField callback to the injected bundle form client
https://bugs.webkit.org/show_bug.cgi?id=111771
Reviewed by Andreas Kling.
Source/WebCore:
Export a symbol needed by WebKit2.
- WebCore.exp.in:
Source/WebKit2:
Add a new client callback that's invoked whenever a text input field is focused.
- Shared/APIClientTraits.cpp:
(WebKit):
- Shared/APIClientTraits.h:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::didFocusTextField):
(WebKit):
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
(InjectedBundlePageFormClient):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focusedNodeChanged):
- 2:01 PM Changeset in webkit [145132] by
-
- 2 edits2 moves2 deletes in trunk/LayoutTests
Unreviewed gardening.
- fast/borders/border-fit-expected.txt: Renamed from LayoutTests/platform/chromium/fast/borders/border-fit-expected.txt.
- platform/chromium-mac/fast/borders/border-fit-expected.txt: Renamed from LayoutTests/platform/mac/fast/borders/border-fit-expected.txt.
- platform/chromium-win/fast/borders/border-fit-expected.txt:
- platform/efl/fast/borders/border-fit-expected.txt: Removed.
- platform/gtk/fast/borders/border-fit-expected.txt: Removed.
- 1:53 PM Changeset in webkit [145131] by
-
- 6 edits in trunk/Source
[chromium] Stop using WebTransformationMatrix on WebLayer
https://bugs.webkit.org/show_bug.cgi?id=111635
Reviewed by Adrienne Walker.
Source/Platform:
WebLayer supports setting transforms by using either SkMatrix44 or WebTransformationMatrix,
both of which are wrappers around 16 doubles. There's no need to have both.
- chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
Source/WebCore:
Switches over to the SkMatrix44 transform setters.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::transformToSkMatrix44):
Utility for convering a WebCore::TransformationMatrix to an SkMatrix44.
Will move to a more common location once it gets more callers.
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
Source/WebKit/chromium:
- src/LinkHighlight.cpp:
(WebKit::LinkHighlight::computeEnclosingCompositingLayer):
- tests/GraphicsLayerChromiumTest.cpp:
(GraphicsLayerChromiumTest):
- 1:50 PM Changeset in webkit [145130] by
-
- 6 edits in trunk
[EFL] Bump libsoup dependency to 2.40.3 to fix regressions
https://bugs.webkit.org/show_bug.cgi?id=111756
Reviewed by Kenneth Rohde Christiansen.
.:
Update libsoup required version to v2.40.3 for EFL port.
- Source/cmake/OptionsEfl.cmake:
Tools:
Bump libsoup to v2.40.3 to fix the regressions introduced by
previous v2.40.0 bump.
- efl/jhbuild.modules:
LayoutTests:
Unskip several tests that are passing after the libsoup dependency
bump to 2.40.3.
- platform/efl/TestExpectations:
- 1:40 PM Changeset in webkit [145129] by
-
- 3 edits in trunk/Source/JavaScriptCore
Build fix for AppleWin VS2010.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- 1:29 PM Changeset in webkit [145128] by
-
- 2 edits in trunk/Tools
Re-enable Win EWS tests.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 1:27 PM Changeset in webkit [145127] by
-
- 3 edits in trunk/Source/WebCore
[Mac] allow iOS to use CaptionUserPreferencesMac
https://bugs.webkit.org/show_bug.cgi?id=111770
Reviewed by Dean Jackson.
No new tests, covered by existing tests.
- page/CaptionUserPreferencesMac.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::userCaptionPreferencesChangedNotificationCallback): Respond to notifications on
the web thread.
- 1:24 PM Changeset in webkit [145126] by
-
- 5 edits in trunk/Source/WebCore
Move side-effects on hover/active state out of hit-testing
https://bugs.webkit.org/show_bug.cgi?id=98168
Reviewed by Julien Chaffraix.
Original patch by Allan Sandfeld Jensen; I'm just tweaking things.
Document::updateHoverActiveState is currently called during hit testing
to update the hover and active states of elements effected by mouse
movements (or their keyboard equivalents). This conflates the hit test
algorithm itself with side-effects associated with specific use-cases.
This conflation makes it very difficult to reuse the hover/active logic
for things other than hit testing. 'mouseenter'/'mouseleave' events[1]
are one example of a feature that would be simple to implement on top of
this existing logic if we split it out from the hit testing path, and
instead call it explicitly when necessary. An explicit split between
hit testing and its side-effects will also enable us to simplify the
logic in future patches with well-named parameters, rather than relying
on stuffing properties into HitTestRequest.
This patch drops the call to Document::updateHoverActiveState from
RenderView::hitTest, and adjusts the three call-sites in EventHandler
to explicitly call out to it rather than Document::updateStyleIfNeeded.
The latter call is still necessary but has been folded into
updateHoverActiveState, as the former is never called without calling
the latter.
- dom/Document.h:
- dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
First, this function must now only be called from contexts that were
performing a read/write hit-test: the code asserts this
precondition.
Second, rather than accepting a HitTestResult, the function accepts
an Element* from which to begin the hover/active chain changes.
Third, we have to explicitly update the hover/active states for
documents between the updated element and the top-level document.
The hit-testing logic was taking care of this for us, now we need to
take care of it ourselves.
Fourth, call out to updateStyleIfNeeded rather than making our
caller do so. The calls were always paired; now that's explicit.
(WebCore::Document::prepareMouseEvent):
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::hoverTimerFired):
Call out to updateHoverActiveState rather than updateStyleIfNeeded.
- rendering/RenderView.cpp:
(WebCore::RenderView::hitTest):
Drop the call to updateHoverActiveState.
- 1:18 PM Changeset in webkit [145125] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] Update some #includes for WebMessagePortChannel.h
https://bugs.webkit.org/show_bug.cgi?id=111752
Reviewed by James Robinson.
In anticipation of removing
WK/chromium/public/WebMessagePortChannel.h (once all downstream
references have been updated)
- public/WebDOMMessageEvent.h:
- public/WebFrame.h:
- public/WebSharedWorkerClient.h:
- 1:08 PM Changeset in webkit [145124] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- 12:59 PM Changeset in webkit [145123] by
-
- 5 edits5 deletes in trunk
Unreviewed, rolling out r145097.
http://trac.webkit.org/changeset/145097
https://bugs.webkit.org/show_bug.cgi?id=111765
Triggers an ASSERT in the Chromium port (Requested by abarth
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-07
Source/WebCore:
- html/FileInputType.cpp:
(WebCore::FileInputType::appendFormData):
- platform/network/FormData.cpp:
(WebCore::FormData::appendKeyValuePairItems):
LayoutTests:
- http/tests/local/formdata/send-form-data-with-empty-blob-filename-expected.txt: Removed.
- http/tests/local/formdata/send-form-data-with-empty-blob-filename.html: Removed.
- http/tests/local/formdata/send-form-data-with-empty-file-filename-expected.txt: Removed.
- http/tests/local/formdata/send-form-data-with-empty-file-filename.html: Removed.
- http/tests/xmlhttprequest/resources/multipart-post-echo-filenames.php: Removed.
- platform/wk2/TestExpectations:
- 12:58 PM Changeset in webkit [145122] by
-
- 2 edits1 add in trunk/Tools
[nrwt] handle corrupt http server pid files cleanly
https://bugs.webkit.org/show_bug.cgi?id=111628
Reviewed by Eric Seidel.
If the pid file from a previous http server is corrupt for some
reason, NRWT will just raise errors and not clean it up or recover.
This patch fixes that to at least delete the pid file and
not throw; not that we may still have stale http servers left on
the system, since there's no way to know which pid to kill if
the file was corrupted.
- Scripts/webkitpy/layout_tests/servers/http_server_base.py:
(HttpServerBase.start):
(HttpServerBase.stop):
(HttpServerBase._remove_pid_file):
- Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
(TestHttpServerBase):
(TestHttpServerBase.test_corrupt_pid_file):
- 12:55 PM Changeset in webkit [145121] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Prevent text selection inside Colour and Date/Time input fields
https://bugs.webkit.org/show_bug.cgi?id=111733
Reviewed by Rob Buis.
PR 305194.
Prevent selection for popup input fields as they are buttons.
Informally Reviewed Gen Mak.
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
- 12:49 PM Changeset in webkit [145120] by
-
- 2 edits in branches/safari-536.29-branch/Source/WebCore
Merged r145013. <rdar://problem/13370880>
- 12:43 PM Changeset in webkit [145119] by
-
- 20 edits4 adds in trunk/Source/JavaScriptCore
Objective-C API: Need a good way to reference event handlers without causing cycles
https://bugs.webkit.org/show_bug.cgi?id=111088
Reviewed by Geoffrey Garen.
JSManagedValue is like a special kind of weak value. When you create a JSManagedValue, you can
supply an Objective-C object as its "owner". As long as the Objective-C owner object remains
alive and its wrapper remains accessible to the JSC garbage collector (e.g. by being marked by
the global object), the reference to the JavaScript value is strong. As soon as the Objective-C
owner is deallocated or its wrapper becomes inaccessible to the garbage collector, the reference
becomes weak.
If you do not supply an owner or you use the weakValueWithValue: convenience class method, the
returned JSManagedValue behaves as a normal weak reference.
This new class allows clients to maintain references to JavaScript values in the Objective-C
heap without creating reference cycles/leaking memory.
- API/JSAPIWrapperObject.cpp: Added.
(JSC):
(JSC::::createStructure):
(JSC::JSAPIWrapperObject::JSAPIWrapperObject): This is a special JSObject for the Objective-C API that knows
for the purposes of garbage collection/marking that it wraps an opaque Objective-C object.
(JSC::JSAPIWrapperObject::visitChildren): We add the pointer to the wrapped Objective-C object to the set of
opaque roots so that the weak handle owner for JSManagedValues can find it later.
- API/JSAPIWrapperObject.h: Added.
(JSC):
(JSAPIWrapperObject):
(JSC::JSAPIWrapperObject::wrappedObject):
(JSC::JSAPIWrapperObject::setWrappedObject):
- API/JSBase.cpp:
(JSSynchronousGarbageCollect):
- API/JSBasePrivate.h:
- API/JSCallbackObject.cpp:
(JSC):
- API/JSCallbackObject.h:
(JSC::JSCallbackObject::destroy): Moved this to the header so that we don't get link errors with JSAPIWrapperObject.
- API/JSContext.mm:
(-[JSContext initWithVirtualMachine:]): We weren't adding manually allocated/initialized JSVirtualMachine objects to
the global cache of virtual machines. The init methods handle this now rather than contextWithGlobalContextRef, since
not everyone is guaranteed to use the latter.
(-[JSContext initWithGlobalContextRef:]):
(+[JSContext contextWithGlobalContextRef:]):
- API/JSManagedValue.h: Added.
- API/JSManagedValue.mm: Added.
(JSManagedValueHandleOwner):
(managedValueHandleOwner):
(+[JSManagedValue weakValueWithValue:]):
(+[JSManagedValue managedValueWithValue:owner:]):
(-[JSManagedValue init]): We explicitly call the ARC entrypoints to initialize/get the weak owner field since we don't
use ARC when building our framework.
(-[JSManagedValue initWithValue:]):
(-[JSManagedValue initWithValue:owner:]):
(-[JSManagedValue dealloc]):
(-[JSManagedValue value]):
(-[JSManagedValue weakOwner]):
(JSManagedValueHandleOwner::isReachableFromOpaqueRoots): If the Objective-C owner is still alive (i.e. loading the weak field
returns non-nil) and that value was added to the set of opaque roots by the wrapper for that Objective-C owner, then the the
JSObject to which the JSManagedObject refers is still alive.
- API/JSObjectRef.cpp: We have to add explicit checks for the JSAPIWrapperObject, just like the other types of JSCallbackObjects.
(JSObjectGetPrivate):
(JSObjectSetPrivate):
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):
- API/JSValue.mm:
(objectToValueWithoutCopy):
- API/JSValueRef.cpp:
(JSValueIsObjectOfClass):
- API/JSVirtualMachine.mm:
(-[JSVirtualMachine initWithContextGroupRef:]):
(+[JSVirtualMachine virtualMachineWithContextGroupRef:]):
- API/JSWrapperMap.mm:
(wrapperFinalize):
(makeWrapper): This is our own internal version of JSObjectMake which creates JSAPIWrapperObjects, the Obj-C API
version of JSCallbackObjects.
(createObjectWithCustomBrand):
(-[JSObjCClassInfo wrapperForObject:]):
(tryUnwrapObjcObject):
- API/JavaScriptCore.h:
- API/tests/testapi.mm: Added new tests for the strong and weak uses of JSManagedValue in the context of an
onclick handler for an Objective-C object inserted into a JSContext.
(-[TextXYZ setWeakOnclick:]):
(-[TextXYZ setOnclick:]):
(-[TextXYZ weakOnclick]):
(-[TextXYZ onclick]):
(-[TextXYZ click]):
- CMakeLists.txt: Various build system additions.
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/JSGlobalObject.cpp: Added the new canonical Structure for the JSAPIWrapperObject class.
(JSC::JSGlobalObject::reset):
(JSC):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSGlobalObject):
(JSC::JSGlobalObject::objcWrapperObjectStructure):
- 12:18 PM Changeset in webkit [145118] by
-
- 26 edits2 copies in branches/chromium/1410
Merge 144350
Focus ring for a child layer is incorrectly offset by ancestor composited layer's position
https://bugs.webkit.org/show_bug.cgi?id=110895
Reviewed by Simon Fraser.
Source/WebCore:
Test: compositing/sub-layer-focus-ring.html
The problem occurs in RenderBlock::addFocusRingRects() where the absolute position of a sub-layer is used to calculate the focus ring rect of the layer.
Should use the relative position to the current paintContainer instead.
To fix the issue:
- RenderLayer passes LayerPaintingInfo.rootLayer to PaintInfo.paintContainer
- Let RenderObject::paintFocusRing() and RenderObject::paintOutline() take PaintInfo instead of GraphicsContext* so that the paintContainer can be passed
- RenderBlock::addFocusRingRects() uses localToContainerPoint(FloatPoint(), paintContainer) instead of localToAbsolute() to calculate the focus ring rect of a sublayer.
- rendering/PaintInfo.h:
(WebCore):
(WebCore::PaintInfo::PaintInfo): Add a field paintContainer (the RenderLayerModelObject which originates the current painting)
(PaintInfo):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::addFocusRingRects): Use the added paintContainer parameter to calculate the relative offset of the child layer.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintBackgroundForFragments): Pass LayerPaintingInfo.rootLayer to PaintInfo.paintContainer.
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase): Ditto.
(WebCore::RenderLayer::paintOutlineForFragments): Ditto.
(WebCore::RenderLayer::paintMaskForFragments): Ditto.
- rendering/RenderLayer.cpp:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing): Now takes PaintInfo instead of GraphicsContext*. Pass paintInfo.paintContainer to addFocusRingRects().
(WebCore::RenderObject::paintOutline): Now takes PaintInfo instead of GraphicsContext*.
(WebCore::RenderObject::absoluteFocusRingQuads):
- rendering/RenderObject.h:
(WebCore::RenderObject::addFocusRingRects): Add paintContainer parameter.
LayoutTests:
New ref test for the bug.
- compositing/sub-layer-focus-ring-expected.html: Added.
- compositing/sub-layer-focus-ring.html: Added.
TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/12641003
- 12:08 PM Changeset in webkit [145117] by
-
- 3 edits in trunk/LayoutTests
Image rebaselines after r145104.
- platform/chromium-mac/fast/table/border-collapsing/cached-change-row-border-width-expected.png:
- platform/chromium-mac/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png:
- 12:04 PM Changeset in webkit [145116] by
-
- 7 edits2 adds in trunk
AX: Can't activate links with VoiceOver in Safari
https://bugs.webkit.org/show_bug.cgi?id=111755
Reviewed by Tim Horton.
Source/WebCore:
VoiceOver is relying on the press action being the first action in the list. We changed
that order inadvertently recently, which confuses VoiceOver.
Test: platform/mac/accessibility/press-action-is-first.html
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
Tools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(supportedActionsCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::supportedActions):
LayoutTests:
- platform/mac/accessibility/press-action-is-first-expected.txt: Added.
- platform/mac/accessibility/press-action-is-first.html: Added.
- 12:03 PM Changeset in webkit [145115] by
-
- 208 edits in trunk
Unreviewed, rolling out r145083.
http://trac.webkit.org/changeset/145083
https://bugs.webkit.org/show_bug.cgi?id=110733
caused lots crashes in http/tests/security/xssAuditor/* tests
Source/WebCore:
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
- html/parser/XSSAuditor.h:
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
- html/parser/XSSAuditorDelegate.h:
(WebCore::XSSInfo::create):
(XSSInfo):
(WebCore::XSSInfo::XSSInfo):
LayoutTests:
- fast/frames/xss-auditor-handles-file-urls-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
- http/tests/security/xssAuditor/base-href-control-char-expected.txt:
- http/tests/security/xssAuditor/base-href-expected.txt:
- http/tests/security/xssAuditor/base-href-null-char-expected.txt:
- http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt:
- http/tests/security/xssAuditor/cached-frame-expected.txt:
- http/tests/security/xssAuditor/cookie-injection-expected.txt:
- http/tests/security/xssAuditor/dom-write-URL-expected.txt:
- http/tests/security/xssAuditor/dom-write-location-expected.txt:
- http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:
- http/tests/security/xssAuditor/dom-write-location-javascript-URL-expected.txt:
- http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
- http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
- http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/embed-tag-expected.txt:
- http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
- http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/form-action-expected.txt:
- http/tests/security/xssAuditor/formaction-on-button-expected.txt:
- http/tests/security/xssAuditor/formaction-on-input-expected.txt:
- http/tests/security/xssAuditor/full-block-base-href-expected.txt:
- http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
- http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
- http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
- http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
- http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
- http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
- http/tests/security/xssAuditor/get-from-iframe-expected.txt:
- http/tests/security/xssAuditor/iframe-injection-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
- http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt:
- http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt:
- http/tests/security/xssAuditor/iframe-srcdoc-expected.txt:
- http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt:
- http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
- http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
- http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
- http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
- http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
- http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
- http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
- http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
- http/tests/security/xssAuditor/javascript-link-expected.txt:
- http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
- http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
- http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
- http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
- http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
- http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
- http/tests/security/xssAuditor/link-onclick-expected.txt:
- http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
- http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
- http/tests/security/xssAuditor/malformed-HTML-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt:
- http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/object-tag-expected.txt:
- http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
- http/tests/security/xssAuditor/open-attribute-body-expected.txt:
- http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
- http/tests/security/xssAuditor/open-iframe-src-01-expected.txt:
- http/tests/security/xssAuditor/open-iframe-src-02-expected.txt:
- http/tests/security/xssAuditor/open-iframe-src-03-expected.txt:
- http/tests/security/xssAuditor/open-script-src-01-expected.txt:
- http/tests/security/xssAuditor/open-script-src-02-expected.txt:
- http/tests/security/xssAuditor/open-script-src-03-expected.txt:
- http/tests/security/xssAuditor/open-script-src-04-expected.txt:
- http/tests/security/xssAuditor/post-from-iframe-expected.txt:
- http/tests/security/xssAuditor/property-escape-comment-01-expected.txt:
- http/tests/security/xssAuditor/property-escape-comment-02-expected.txt:
- http/tests/security/xssAuditor/property-escape-comment-03-expected.txt:
- http/tests/security/xssAuditor/property-escape-entity-01-expected.txt:
- http/tests/security/xssAuditor/property-escape-entity-02-expected.txt:
- http/tests/security/xssAuditor/property-escape-entity-03-expected.txt:
- http/tests/security/xssAuditor/property-escape-expected.txt:
- http/tests/security/xssAuditor/property-escape-long-expected.txt:
- http/tests/security/xssAuditor/property-escape-quote-01-expected.txt:
- http/tests/security/xssAuditor/property-escape-quote-02-expected.txt:
- http/tests/security/xssAuditor/property-escape-quote-03-expected.txt:
- http/tests/security/xssAuditor/report-script-tag-expected.txt:
- http/tests/security/xssAuditor/report-script-tag-full-block-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt:
- http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
- http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
- http/tests/security/xssAuditor/script-tag-entities-expected.txt:
- http/tests/security/xssAuditor/script-tag-expected.txt:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt:
- http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
- http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-post-expected.txt:
- http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-comma-01-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-comma-02-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-data-url2-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-data-url3-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-01-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-02-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-03-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment5-expected.txt:
- http/tests/security/xssAuditor/svg-animate-expected.txt:
- http/tests/security/xssAuditor/svg-script-tag-expected.txt:
- http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
- http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
- http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
- platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt:
- 12:00 PM Changeset in webkit [145114] by
-
- 4 edits4 adds in trunk
[CSS Shaders] Implement hue and saturation non-separable blend modes
https://bugs.webkit.org/show_bug.cgi?id=109464
Source/WebCore:
Added the following GLSL helper functions to the CustomFilterValidatedProgram:
- css_Sat(C): returns the saturation for the color C
- css_SetSat(C, s): sets the saturation s on the color C
- css_SetSatHelper(Cmin, Cmid, Cmax, s): helper function for css_SetSat
The above functions are being used for the "hue" and "saturation" non-separable
blend modes, the relevant spec for such modes is at URL:
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blendingnonseparable
Reviewed by Dean Jackson.
Tests: css3/filters/custom/custom-filter-nonseparable-blend-mode-hue.html
css3/filters/custom/custom-filter-nonseparable-blend-mode-saturation.html
- platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::blendFunctionString):
LayoutTests:
Added relevant tests for the "hue" and "saturation" non-separable blend modes.
These tests are currently skipped on Mac due to a slight color difference; please see relevant bug: http://webkit.org/b/107487.
Reviewed by Dean Jackson.
- css3/filters/custom/custom-filter-nonseparable-blend-mode-hue-expected.html: Added.
- css3/filters/custom/custom-filter-nonseparable-blend-mode-hue.html: Added.
- css3/filters/custom/custom-filter-nonseparable-blend-mode-saturation-expected.html: Added.
- css3/filters/custom/custom-filter-nonseparable-blend-mode-saturation.html: Added.
- platform/mac/TestExpectations:
- 11:53 AM Changeset in webkit [145113] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium-mac/fast/borders/border-radius-with-box-shadow-01-expected.png: Added.
- platform/chromium-win/fast/borders/border-radius-with-box-shadow-01-expected.png: Added.
- 11:43 AM Changeset in webkit [145112] by
-
- 26 edits2 deletes in branches/chromium/1410
Revert 145087
Merge 144350
Focus ring for a child layer is incorrectly offset by ancestor composited layer's position
https://bugs.webkit.org/show_bug.cgi?id=110895
Reviewed by Simon Fraser.
Source/WebCore:
Test: compositing/sub-layer-focus-ring.html
The problem occurs in RenderBlock::addFocusRingRects() where the absolute position of a sub-layer is used to calculate the focus ring rect of the layer.
Should use the relative position to the current paintContainer instead.
To fix the issue:
- RenderLayer passes LayerPaintingInfo.rootLayer to PaintInfo.paintContainer
- Let RenderObject::paintFocusRing() and RenderObject::paintOutline() take PaintInfo instead of GraphicsContext* so that the paintContainer can be passed
- RenderBlock::addFocusRingRects() uses localToContainerPoint(FloatPoint(), paintContainer) instead of localToAbsolute() to calculate the focus ring rect of a sublayer.
- rendering/PaintInfo.h:
(WebCore):
(WebCore::PaintInfo::PaintInfo): Add a field paintContainer (the RenderLayerModelObject which originates the current painting)
(PaintInfo):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::addFocusRingRects): Use the added paintContainer parameter to calculate the relative offset of the child layer.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintBackgroundForFragments): Pass LayerPaintingInfo.rootLayer to PaintInfo.paintContainer.
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase): Ditto.
(WebCore::RenderLayer::paintOutlineForFragments): Ditto.
(WebCore::RenderLayer::paintMaskForFragments): Ditto.
- rendering/RenderLayer.cpp:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing): Now takes PaintInfo instead of GraphicsContext*. Pass paintInfo.paintContainer to addFocusRingRects().
(WebCore::RenderObject::paintOutline): Now takes PaintInfo instead of GraphicsContext*.
(WebCore::RenderObject::absoluteFocusRingQuads):
- rendering/RenderObject.h:
(WebCore::RenderObject::addFocusRingRects): Add paintContainer parameter.
LayoutTests:
New ref test for the bug.
- compositing/sub-layer-focus-ring-expected.html: Added.
- compositing/sub-layer-focus-ring.html: Added.
TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/12616003
TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/12545020
- 11:40 AM Changeset in webkit [145111] by
-
- 2 edits in trunk/LayoutTests
IndexedDB: Make test behavior deterministic in multiprocess ports
https://bugs.webkit.org/show_bug.cgi?id=111643
Reviewed by Tony Chang.
Root cause is documented in wkbug.com/111642 but as a stop-gap - ensure
that this test doesn't fail flakily in multiprocess ports by moving the
last part of the test out of a limbo zone.
- storage/indexeddb/resources/index-multientry.js: Run subsequent part of
test in open's "success" handler rather than transaction's "complete" handler.
- 11:20 AM Changeset in webkit [145110] by
-
- 2 edits in trunk/Tools
Windows debug layout tests are crashing like crazy again.
Disable tests on Win EWS bots temporarily.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 11:18 AM Changeset in webkit [145109] by
-
- 1 edit1 delete in trunk/Source/WebKit/chromium
[Chromium] Remove WK/chromium/public/WebStorageArea.h
https://bugs.webkit.org/show_bug.cgi?id=111744
Reviewed by James Robinson.
File moved to new Platform/ directory. All references have already
been updated (including downstream).
- public/WebStorageArea.h: Removed.
- 11:13 AM Changeset in webkit [145108] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Update some #includes for WebFileInfo.h in WK/chromium/src/
https://bugs.webkit.org/show_bug.cgi?id=111741
Reviewed by James Robinson.
In preparation for removing WK/chromium/public/WebFileInfo.h.
- src/AssertMatchingEnums.cpp:
- 11:07 AM Changeset in webkit [145107] by
-
- 3 edits in trunk/Tools
Make EWS bots build and test in release.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- 11:03 AM Changeset in webkit [145106] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [ACE] set correct font
https://bugs.webkit.org/show_bug.cgi?id=111747
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-07
Reviewed by Pavel Feldman.
No new tests.
Set class "source-code" for the ace editor element.
- inspector/front-end/AceTextEditor.js:
(WebInspector.AceTextEditor):
- 11:03 AM Changeset in webkit [145105] by
-
- 10 edits14 moves30 adds29 deletes in releases/WebKitGTK/webkit-2.0
Merge 145081 - [GTK] Enable translations for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=111398
Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2013-03-07.
Reviewed by Martin Robinson.
- GNUmakefile.am: adjust path for i18n GNUmakefile.am.
- configure.ac: generate the i18n makefile unconditionally, the translations are
used by both WebKitGTK+ and WebKit2GTK+.
Source/WebCore:
- GNUmakefile.am: distribute po files.
- platform/gtk/po/POTFILES.in: adjust paths for translatable files.
Source/WebCore/platform/gtk/po:
- GNUmakefile.am: Renamed from Source/WebKit/gtk/po/GNUmakefile.am.
- POTFILES.in: Renamed from Source/WebKit/gtk/po/POTFILES.in.
- README: Renamed from Source/WebKit/gtk/po/README.
- ar.po: Renamed from Source/WebKit/gtk/po/ar.po.
- as.po: Renamed from Source/WebKit/gtk/po/as.po.
- bg.po: Renamed from Source/WebKit/gtk/po/bg.po.
- cs.po: Renamed from Source/WebKit/gtk/po/cs.po.
- de.po: Renamed from Source/WebKit/gtk/po/de.po.
- el.po: Renamed from Source/WebKit/gtk/po/el.po.
- en_CA.po: Renamed from Source/WebKit/gtk/po/en_CA.po.
- en_GB.po: Renamed from Source/WebKit/gtk/po/en_GB.po.
- eo.po: Renamed from Source/WebKit/gtk/po/eo.po.
- es.po: Renamed from Source/WebKit/gtk/po/es.po.
- et.po: Renamed from Source/WebKit/gtk/po/et.po.
- eu.po: Renamed from Source/WebKit/gtk/po/eu.po.
- fr.po: Renamed from Source/WebKit/gtk/po/fr.po.
- gl.po: Renamed from Source/WebKit/gtk/po/gl.po.
- gu.po: Renamed from Source/WebKit/gtk/po/gu.po.
- he.po: Renamed from Source/WebKit/gtk/po/he.po.
- hi.po: Renamed from Source/WebKit/gtk/po/hi.po.
- hu.po: Renamed from Source/WebKit/gtk/po/hu.po.
- id.po: Renamed from Source/WebKit/gtk/po/id.po.
- it.po: Renamed from Source/WebKit/gtk/po/it.po.
- ko.po: Renamed from Source/WebKit/gtk/po/ko.po.
- lt.po: Renamed from Source/WebKit/gtk/po/lt.po.
- lv.po: Renamed from Source/WebKit/gtk/po/lv.po.
- mr.po: Renamed from Source/WebKit/gtk/po/mr.po.
- nb.po: Renamed from Source/WebKit/gtk/po/nb.po.
- nl.po: Renamed from Source/WebKit/gtk/po/nl.po.
- pa.po: Renamed from Source/WebKit/gtk/po/pa.po.
- pl.po: Renamed from Source/WebKit/gtk/po/pl.po.
- pt.po: Renamed from Source/WebKit/gtk/po/pt.po.
- pt_BR.po: Renamed from Source/WebKit/gtk/po/pt_BR.po.
- ro.po: Renamed from Source/WebKit/gtk/po/ro.po.
- ru.po: Renamed from Source/WebKit/gtk/po/ru.po.
- sl.po: Renamed from Source/WebKit/gtk/po/sl.po.
- sr.po: Renamed from Source/WebKit/gtk/po/sr.po.
- sr@latin.po: Renamed from Source/WebKit/gtk/po/sr@latin.po.
- sv.po: Renamed from Source/WebKit/gtk/po/sv.po.
- uk.po: Renamed from Source/WebKit/gtk/po/uk.po.
- vi.po: Renamed from Source/WebKit/gtk/po/vi.po.
- zh_CN.po: Renamed from Source/WebKit/gtk/po/zh_CN.po.
Source/WebKit2:
- GNUmakefile.am: define PACKAGE_LOCALE_DIR when building WebProcess's main module.
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk): register the i18n domain name, and prefer UTF-8, since
we're GTK+; at the moment we're just using the same name as WebKitGTK+, pro: the
translation module can be reused, con: you can't have different versions of
WebKitGTK+ and WebKit2GTK+ installed, because the module would not be fit for reuse
in that case.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::childSetupFunction): do not set LC_ALL environment variable explicitly,
the child process will already inherit the environment of the parent, which should
have all the variables set properly.
Conflicts:
configure.ac
- 11:02 AM WebKitGTK/2.0.x edited by
- (diff)
- 10:59 AM Changeset in webkit [145104] by
-
- 7 edits in trunk
Recalculate borders at the beginning of table layout
https://bugs.webkit.org/show_bug.cgi?id=111634
Reviewed by Julien Chaffraix.
Source/WebCore:
Doing it in convertStyleLogicalWidthToComputedWidth missed some dynamic
relayout cases. I confirmed that the new results match the results we
would get if we set the border width initially instead of dynamically.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::layout):
LayoutTests:
- fast/table/border-collapsing/cached-change-row-border-width-expected.png:
- fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
- fast/table/border-collapsing/cached-change-tbody-border-width-expected.png:
- fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt:
- 10:57 AM Changeset in webkit [145103] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: http/tests/css/shared-stylesheet-mutation-preconstruct.html
- 10:47 AM Changeset in webkit [145102] by
-
- 1 edit1 delete in trunk/Source/WebKit/chromium
[Chromium] Remove WK/chromium/public/WebWorkerRunLoop.h
https://bugs.webkit.org/show_bug.cgi?id=111740
Reviewed by James Robinson.
No longer needed; all references have been updated to new version
in top-level Platform/ directory.
- public/WebWorkerRunLoop.h: Removed.
- 10:45 AM Changeset in webkit [145101] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r186592. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-07
- DEPS:
- 10:41 AM Changeset in webkit [145100] by
-
- 6 edits2 adds in trunk
Source/WebCore: border-fit-adjust should happen at layout time rather than paint time
https://bugs.webkit.org/show_bug.cgi?id=111606
<rdar://problem/13101714>
Reviewed by Antti Koivisto.
In order for border-fit-adjust to be accurate in more cases, it needs
to be a layout-time adjustment rather than a paint-time adjustment.
Specifically there are cases where an LTR adjusted box was right-aligned
by its container, and without genuinely shrinking the size of the box,
we end up chopping off the right edge but not shifting the box to the
right to compensate.
This patch changes border-fit-adjust to now do the adjustment using
the override width mechanism and a second layout pass instead of just
hacking painting.
Test: fast/block/border-fit-with-right-alignment.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
Calls fitBorderToLinesIfNeeded at the end of layout to do a second
layout pass if the adjustment needs to be made.
(WebCore::RenderBlock::fitBorderToLinesIfNeeded):
Renamed borderFitAdjust to fitBorderToLinesIfNeeded and made it
non-virtual, since it's no longer called from RenderBox code. Changed it
to do a relayout using override widths if an adjustment is needed.
- rendering/RenderBlock.h:
(RenderBlock):
Renamed borderFitAdjust to fitBorderToLinesIfNeeded and made it
non-virtual.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintMask):
Removed the paint-time border-fit adjustment.
(WebCore::RenderBox::computeLogicalWidthInRegion):
Use the override width when border-fit is set to lines.
- rendering/RenderBox.h:
(RenderBox):
Remove the virtual borderFitAdjust method.
LayoutTests: border-fit should happen at layout time rather than paint time
https://bugs.webkit.org/show_bug.cgi?id=111606
<rdar://problem/13101714>
Reviewed by Antti Koivisto.
- fast/block/border-fit-with-right-alignment-expected.html: Added.
- fast/block/border-fit-with-right-alignment.html: Added.
- 10:37 AM Changeset in webkit [145099] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Update some #includes for WebVideoFrame.h
https://bugs.webkit.org/show_bug.cgi?id=111739
Reviewed by James Robinson.
In anticipation of removing WebVideoFrame.h from WK/chromium/public/.
- public/WebMediaPlayer.h:
- 10:35 AM Changeset in webkit [145098] by
-
- 7 edits2 adds in trunk
REGRESSION(r143727): Clicking / selecting inside an <embed> is broken
https://bugs.webkit.org/show_bug.cgi?id=111217
Reviewed by Julien Chaffraix.
Source/WebCore:
Hit-testing into child frames need to happen in RenderPart, otherwise
we will miss frame views in <embed> and <object> elements.
Test: fast/dom/nodesFromRect/nodesFromRect-embedded-frame-content.html
- rendering/RenderFrameBase.cpp:
- rendering/RenderFrameBase.h:
(RenderFrameBase):
- rendering/RenderPart.cpp:
(WebCore::RenderPart::nodeAtPoint):
- rendering/RenderPart.h:
(RenderPart):
LayoutTests:
Test rect and point based hit-testing inside embed and object child frames.
- fast/dom/nodesFromRect/nodesFromRect-embedded-frame-content-expected.txt: Added.
- fast/dom/nodesFromRect/nodesFromRect-embedded-frame-content.html: Added.
- fast/dom/nodesFromRect/resources/nodesFromRect.js:
(checkPoint):
- 10:25 AM Changeset in webkit [145097] by
-
- 5 edits5 adds in trunk
FormData should allow setting filename to empty
https://bugs.webkit.org/show_bug.cgi?id=111687
Reviewed by Brady Eidson.
Tests: http/tests/local/formdata/send-form-data-with-empty-blob-filename.html
http/tests/local/formdata/send-form-data-with-empty-file-filename.html
- html/FileInputType.cpp: (WebCore::FileInputType::appendFormData): Use a Blob for empty file input, not a hacky File with empty path.
- platform/network/FormData.cpp: (WebCore::FormData::appendKeyValuePairItems): Missing value is a null string. If the string is empty, we should treat is as authoritative.
- 10:23 AM Changeset in webkit [145096] by
-
- 2 edits in trunk/Source/WebKit2
Null-check the page overlay before trying to use it.
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scroll):
- 10:17 AM Changeset in webkit [145095] by
-
- 2 edits in trunk/LayoutTests
inspector/debugger/debugger-expand-scope.html sometimes fails on Apple MountainLion Release WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=111754
Skipping this test so that Mac EWS can catch up.
- platform/mac/TestExpectations:
- 10:15 AM Changeset in webkit [145094] by
-
- 2 edits in branches/safari-534.59-branch/Source/WebKit2
<rdar://problem/13368674> - Bogus MESSAGE_CHECK in WebPageProxy::unavailablePluginButtonClicked
Rubberstamped by Alexey Proskuryakov.
I also checked all of my recent merges to make sure I didn't include any other MESSAGE_CHECKs in
lieu of MESSAGE_CHECK_URL.
I didn't.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
- 10:12 AM Changeset in webkit [145093] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] dublicated horizontal scroll
https://bugs.webkit.org/show_bug.cgi?id=111712
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-07
Reviewed by Pavel Feldman.
Set a box-sizing css property on all codemirror elements to
"content-box".
No new tests.
- inspector/front-end/cm/cmdevtools.css:
(.CodeMirror *):
- 10:03 AM Changeset in webkit [145092] by
-
- 2 edits in trunk/LayoutTests
Chromium, mac-wk2 and mac need new baselines after fixing paint phases for composited scrolling.
https://bugs.webkit.org/show_bug.cgi?id=107952
New baseline for Mac.
- platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- 9:58 AM Changeset in webkit [145091] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Remove WebView's sharedGraphicsContext3D method.
https://bugs.webkit.org/show_bug.cgi?id=111499
Reviewed by James Robinson.
- public/WebView.h:
(WebView):
- src/WebViewImpl.cpp:
- src/WebViewImpl.h:
(WebViewImpl):
- 9:39 AM Changeset in webkit [145090] by
-
- 14 edits in trunk/LayoutTests
Remove GC code duplication in http/tests LayoutTests.
https://bugs.webkit.org/show_bug.cgi?id=111589
Reviewed by Kentaro Hara, Alexey Proskuryakov.
Replaced duplicated GC logic in various tests with a function call to the implementation
in /js-test-resources/js-test-pre.js
- http/tests/appcache/destroyed-frame.html:
- http/tests/media/media-source/video-media-source-sourcebufferlist-crash.html:
- http/tests/misc/async-script.html:
- http/tests/misc/embed-image-load-outlives-gc-without-crashing.html:
- http/tests/misc/image-input-type-outlives-gc-without-crashing.html:
- http/tests/misc/image-load-outlives-gc-without-crashing.html:
- http/tests/misc/javascript-url-stop-loaders.html:
- http/tests/misc/object-image-load-outlives-gc-without-crashing.html:
- http/tests/misc/svg-image-load-outlives-gc-without-crashing.html:
- http/tests/misc/video-poster-image-load-outlives-gc-without-crashing.html:
- http/tests/security/detached-sandboxed-frame-access.html:
- http/tests/websocket/tests/hybi/websocket-pending-activity.html:
- http/tests/xmlhttprequest/event-listener-gc.html:
- 9:28 AM Changeset in webkit [145089] by
-
- 5 edits in branches/chromium/1410
Merge 144463
Web Inspector: [Regression] Snippets renaming is broken.
https://bugs.webkit.org/show_bug.cgi?id=111181
Reviewed by Alexander Pavlov.
Source/WebCore:
- inspector/front-end/NavigatorView.js:
- inspector/front-end/ScriptSnippetModel.js:
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.rename):
LayoutTests:
- inspector/debugger/script-snippet-model.html:
TBR=vsevik@chromium.org
BUG=179368
Review URL: https://codereview.chromium.org/12622003
- 9:23 AM Changeset in webkit [145088] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/inspector/front-end/CPUProfileView.js
Merge 143438
Web Inspector: [Regression] Search in ProfilesPanel is broken
https://bugs.webkit.org/show_bug.cgi?id=110312
Reviewed by Pavel Feldman.
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.prototype.matchesQuery):
(WebInspector.CPUProfileView.prototype.performSearch):
TBR=vsevik@chromium.org
BUG=179316
Review URL: https://codereview.chromium.org/12626002
- 9:19 AM Changeset in webkit [145087] by
-
- 26 edits2 copies in branches/chromium/1410
Merge 144350
Focus ring for a child layer is incorrectly offset by ancestor composited layer's position
https://bugs.webkit.org/show_bug.cgi?id=110895
Reviewed by Simon Fraser.
Source/WebCore:
Test: compositing/sub-layer-focus-ring.html
The problem occurs in RenderBlock::addFocusRingRects() where the absolute position of a sub-layer is used to calculate the focus ring rect of the layer.
Should use the relative position to the current paintContainer instead.
To fix the issue:
- RenderLayer passes LayerPaintingInfo.rootLayer to PaintInfo.paintContainer
- Let RenderObject::paintFocusRing() and RenderObject::paintOutline() take PaintInfo instead of GraphicsContext* so that the paintContainer can be passed
- RenderBlock::addFocusRingRects() uses localToContainerPoint(FloatPoint(), paintContainer) instead of localToAbsolute() to calculate the focus ring rect of a sublayer.
- rendering/PaintInfo.h:
(WebCore):
(WebCore::PaintInfo::PaintInfo): Add a field paintContainer (the RenderLayerModelObject which originates the current painting)
(PaintInfo):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::addFocusRingRects): Use the added paintContainer parameter to calculate the relative offset of the child layer.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintBackgroundForFragments): Pass LayerPaintingInfo.rootLayer to PaintInfo.paintContainer.
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase): Ditto.
(WebCore::RenderLayer::paintOutlineForFragments): Ditto.
(WebCore::RenderLayer::paintMaskForFragments): Ditto.
- rendering/RenderLayer.cpp:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing): Now takes PaintInfo instead of GraphicsContext*. Pass paintInfo.paintContainer to addFocusRingRects().
(WebCore::RenderObject::paintOutline): Now takes PaintInfo instead of GraphicsContext*.
(WebCore::RenderObject::absoluteFocusRingQuads):
- rendering/RenderObject.h:
(WebCore::RenderObject::addFocusRingRects): Add paintContainer parameter.
LayoutTests:
New ref test for the bug.
- compositing/sub-layer-focus-ring-expected.html: Added.
- compositing/sub-layer-focus-ring.html: Added.
TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/12616003
- 9:15 AM Changeset in webkit [145086] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Styles sidebar pane toolbar disappears in horizontal split mode.
https://bugs.webkit.org/show_bug.cgi?id=111735
Reviewed by Pavel Feldman.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._splitVertically):
- inspector/front-end/elementsPanel.css:
(.sidebar-pane.composite .metrics-and-computed .sidebar-pane-toolbar):
- 9:11 AM Changeset in webkit [145085] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] QWebSettings::clearMemoryCaches should clear JS garbage
https://bugs.webkit.org/show_bug.cgi?id=111094
Patch by Arunprasad Rajkumar <arunprasadr@nds.com> on 2013-03-07
Reviewed by Jocelyn Turcotte.
- Api/qwebsettings.cpp:
(QWebSettings::clearMemoryCaches):
- 8:58 AM Changeset in webkit [145084] by
-
- 10 edits in trunk
[GTK] Limit the supported compilers to GCC >= 4.7 and Clang >= 3.0
https://bugs.webkit.org/show_bug.cgi?id=109932
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-03-07
Reviewed by Martin Robinson.
.:
- Source/autotools/CheckSystemAndBasicDependencies.m4: Strictly check for one of the two compilers.
- Source/autotools/SetupCompilerFlags.m4: Set up C++11-specific compiler flags. Force the C99 standard for the C code.
Use the -Qunused-arguments flag when using Clang, it reduces irrelevant errors when using ccache.
Source/WebCore:
- GNUmakefile.am: Replace references to SYMBOL_VISIBILITY_INLINES and SYMBOL_VISIBILITY variables with the actual flags.
They are now available by default due to the limited set of supported compilers.
- bindings/gobject/GNUmakefile.am: Ditto.
Source/WebKit/gtk:
- GNUmakefile.am: Replace references to SYMBOL_VISIBILITY_INLINES and SYMBOL_VISIBILITY variables with the actual flags.
They are now available by default due to the limited set of supported compilers.
Source/WebKit2:
- GNUmakefile.am: Replace references to SYMBOL_VISIBILITY_INLINES and SYMBOL_VISIBILITY variables with the actual flags.
They are now available by default due to the limited set of supported compilers.
- 8:39 AM Changeset in webkit [145083] by
-
- 208 edits in trunk
XSSAuditor should send only one console error when blocking a page.
https://bugs.webkit.org/show_bug.cgi?id=110733
Reviewed by Daniel Bates.
Source/WebCore:
Currently, we send two console errors when XSSAuditor blocks a page:
"Refused to execute a JavaScript script. Source code of script found
within request.\n", and "Entire page will be blocked.".
We should only send one message, tuning it properly for the context, and
including the URL of the page effected by the XSSAuditor's work.
Covered by rebaselines of all the XSSAuditor and 'reflected-xss' tests.
- html/parser/XSSAuditor.cpp:
- html/parser/XSSAuditor.h:
(WebCore::XSSAuditor::XSSAuditor):
Add two booleans to track the headers used to set the XSSAuditor state.
(WebCore::XSSAuditor::init):
Save a copy of the document's URL even if we're not generating a
report upon violation: we'll need it for the console messages. Also
populate the didSendValidXXXHeader booleans for use later.
(WebCore::XSSAuditor::filterToken):
Add detail about the header status to the constructed XSSInfo object.
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::buildConsoleError):
Move message construction out into a separate inlined function, as
it's becoming complex.
(WebCore::XSSAuditorDelegate::didBlockScript):
Fold the "Entire page will be blocked" message into the main console
error.
- html/parser/XSSAuditorDelegate.h:
(WebCore::XSSInfo::create):
(WebCore::XSSInfo::XSSInfo):
Add detail about header status to XSSInfo in order to correctly
construct the console error.
LayoutTests:
- fast/frames/xss-auditor-handles-file-urls-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
- http/tests/security/xssAuditor/base-href-control-char-expected.txt:
- http/tests/security/xssAuditor/base-href-expected.txt:
- http/tests/security/xssAuditor/base-href-null-char-expected.txt:
- http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt:
- http/tests/security/xssAuditor/cached-frame-expected.txt:
- http/tests/security/xssAuditor/cookie-injection-expected.txt:
- http/tests/security/xssAuditor/dom-write-URL-expected.txt:
- http/tests/security/xssAuditor/dom-write-location-expected.txt:
- http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:
- http/tests/security/xssAuditor/dom-write-location-javascript-URL-expected.txt:
- http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
- http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
- http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/embed-tag-expected.txt:
- http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
- http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/formaction-on-button-expected.txt:
- http/tests/security/xssAuditor/formaction-on-input-expected.txt:
- http/tests/security/xssAuditor/form-action-expected.txt:
- http/tests/security/xssAuditor/full-block-base-href-expected.txt:
- http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
- http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
- http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
- http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
- http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
- http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
- http/tests/security/xssAuditor/get-from-iframe-expected.txt:
- http/tests/security/xssAuditor/iframe-injection-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
- http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt:
- http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt:
- http/tests/security/xssAuditor/iframe-srcdoc-expected.txt:
- http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt:
- http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
- http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
- http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
- http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
- http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
- http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
- http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
- http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
- http/tests/security/xssAuditor/javascript-link-expected.txt:
- http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
- http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
- http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
- http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
- http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
- http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
- http/tests/security/xssAuditor/link-onclick-expected.txt:
- http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
- http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
- http/tests/security/xssAuditor/malformed-HTML-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt:
- http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/object-tag-expected.txt:
- http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
- http/tests/security/xssAuditor/open-attribute-body-expected.txt:
- http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
- http/tests/security/xssAuditor/open-iframe-src-01-expected.txt:
- http/tests/security/xssAuditor/open-iframe-src-02-expected.txt:
- http/tests/security/xssAuditor/open-script-src-01-expected.txt:
- http/tests/security/xssAuditor/open-script-src-02-expected.txt:
- http/tests/security/xssAuditor/open-script-src-03-expected.txt:
- http/tests/security/xssAuditor/open-script-src-04-expected.txt:
- http/tests/security/xssAuditor/post-from-iframe-expected.txt:
- http/tests/security/xssAuditor/property-escape-comment-01-expected.txt:
- http/tests/security/xssAuditor/property-escape-comment-02-expected.txt:
- http/tests/security/xssAuditor/property-escape-comment-03-expected.txt:
- http/tests/security/xssAuditor/property-escape-entity-01-expected.txt:
- http/tests/security/xssAuditor/property-escape-entity-02-expected.txt:
- http/tests/security/xssAuditor/property-escape-entity-03-expected.txt:
- http/tests/security/xssAuditor/property-escape-expected.txt:
- http/tests/security/xssAuditor/property-escape-long-expected.txt:
- http/tests/security/xssAuditor/property-escape-quote-01-expected.txt:
- http/tests/security/xssAuditor/property-escape-quote-02-expected.txt:
- http/tests/security/xssAuditor/property-escape-quote-03-expected.txt:
- http/tests/security/xssAuditor/report-script-tag-expected.txt:
- http/tests/security/xssAuditor/report-script-tag-full-block-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt:
- http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
- http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
- http/tests/security/xssAuditor/script-tag-entities-expected.txt:
- http/tests/security/xssAuditor/script-tag-expected.txt:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt:
- http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
- http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-post-expected.txt:
- http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-comma-01-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-comma-02-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-data-url2-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-data-url3-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-01-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-02-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-03-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment5-expected.txt:
- http/tests/security/xssAuditor/svg-script-tag-expected.txt:
- http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
- http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
- http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
- platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt:
- 8:28 AM Changeset in webkit [145082] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Add some more compilation annotations to NavigatorView
https://bugs.webkit.org/show_bug.cgi?id=111730
Reviewed by Alexander Pavlov.
- inspector/front-end/NavigatorView.js:
- 8:25 AM Changeset in webkit [145081] by
-
- 10 edits14 moves30 adds29 deletes in trunk
[GTK] Enable translations for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=111398
Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2013-03-07.
Reviewed by Martin Robinson.
- GNUmakefile.am: adjust path for i18n GNUmakefile.am.
- configure.ac: generate the i18n makefile unconditionally, the translations are
used by both WebKitGTK+ and WebKit2GTK+.
Source/WebCore:
- GNUmakefile.am: distribute po files.
- platform/gtk/po/POTFILES.in: adjust paths for translatable files.
Source/WebCore/platform/gtk/po:
- GNUmakefile.am: Renamed from Source/WebKit/gtk/po/GNUmakefile.am.
- POTFILES.in: Renamed from Source/WebKit/gtk/po/POTFILES.in.
- README: Renamed from Source/WebKit/gtk/po/README.
- ar.po: Renamed from Source/WebKit/gtk/po/ar.po.
- as.po: Renamed from Source/WebKit/gtk/po/as.po.
- bg.po: Renamed from Source/WebKit/gtk/po/bg.po.
- cs.po: Renamed from Source/WebKit/gtk/po/cs.po.
- de.po: Renamed from Source/WebKit/gtk/po/de.po.
- el.po: Renamed from Source/WebKit/gtk/po/el.po.
- en_CA.po: Renamed from Source/WebKit/gtk/po/en_CA.po.
- en_GB.po: Renamed from Source/WebKit/gtk/po/en_GB.po.
- eo.po: Renamed from Source/WebKit/gtk/po/eo.po.
- es.po: Renamed from Source/WebKit/gtk/po/es.po.
- et.po: Renamed from Source/WebKit/gtk/po/et.po.
- eu.po: Renamed from Source/WebKit/gtk/po/eu.po.
- fr.po: Renamed from Source/WebKit/gtk/po/fr.po.
- gl.po: Renamed from Source/WebKit/gtk/po/gl.po.
- gu.po: Renamed from Source/WebKit/gtk/po/gu.po.
- he.po: Renamed from Source/WebKit/gtk/po/he.po.
- hi.po: Renamed from Source/WebKit/gtk/po/hi.po.
- hu.po: Renamed from Source/WebKit/gtk/po/hu.po.
- id.po: Renamed from Source/WebKit/gtk/po/id.po.
- it.po: Renamed from Source/WebKit/gtk/po/it.po.
- ko.po: Renamed from Source/WebKit/gtk/po/ko.po.
- lt.po: Renamed from Source/WebKit/gtk/po/lt.po.
- lv.po: Renamed from Source/WebKit/gtk/po/lv.po.
- mr.po: Renamed from Source/WebKit/gtk/po/mr.po.
- nb.po: Renamed from Source/WebKit/gtk/po/nb.po.
- nl.po: Renamed from Source/WebKit/gtk/po/nl.po.
- pa.po: Renamed from Source/WebKit/gtk/po/pa.po.
- pl.po: Renamed from Source/WebKit/gtk/po/pl.po.
- pt.po: Renamed from Source/WebKit/gtk/po/pt.po.
- pt_BR.po: Renamed from Source/WebKit/gtk/po/pt_BR.po.
- ro.po: Renamed from Source/WebKit/gtk/po/ro.po.
- ru.po: Renamed from Source/WebKit/gtk/po/ru.po.
- sl.po: Renamed from Source/WebKit/gtk/po/sl.po.
- sr.po: Renamed from Source/WebKit/gtk/po/sr.po.
- sr@latin.po: Renamed from Source/WebKit/gtk/po/sr@latin.po.
- sv.po: Renamed from Source/WebKit/gtk/po/sv.po.
- uk.po: Renamed from Source/WebKit/gtk/po/uk.po.
- vi.po: Renamed from Source/WebKit/gtk/po/vi.po.
- zh_CN.po: Renamed from Source/WebKit/gtk/po/zh_CN.po.
Source/WebKit2:
- GNUmakefile.am: define PACKAGE_LOCALE_DIR when building WebProcess's main module.
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk): register the i18n domain name, and prefer UTF-8, since
we're GTK+; at the moment we're just using the same name as WebKitGTK+, pro: the
translation module can be reused, con: you can't have different versions of
WebKitGTK+ and WebKit2GTK+ installed, because the module would not be fit for reuse
in that case.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::childSetupFunction): do not set LC_ALL environment variable explicitly,
the child process will already inherit the environment of the parent, which should
have all the variables set properly.
- 8:09 AM Changeset in webkit [145080] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] update codemirror to version 3.1
https://bugs.webkit.org/show_bug.cgi?id=111711
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-07
Reviewed by Vsevolod Vlasov.
Update code mirror experimental editor to version 3.1
No new tests.
- inspector/front-end/cm/codemirror.css:
(.CodeMirror div.CodeMirror-cursor):
(.CodeMirror div.CodeMirror-secondarycursor):
(.CodeMirror.cm-keymap-fat-cursor div.CodeMirror-cursor):
(.CodeMirror.cm-keymap-fat-cursor div.CodeMirror-cursor:not(#nonsense_id)):
(.CodeMirror div.CodeMirror-cursor.CodeMirror-overwrite):
(.CodeMirror-gutters):
(.CodeMirror-linewidget):
(.CodeMirror-widget):
(.CodeMirror-focused div.CodeMirror-cursor):
(@media print):
- inspector/front-end/cm/codemirror.js:
(window.CodeMirror):
(window.CodeMirror.):
- 7:54 AM Changeset in webkit [145079] by
-
- 2 edits in trunk/Source/WebCore
OpenGLShims: fix check for ANGLE GLES2 extensions
https://bugs.webkit.org/show_bug.cgi?id=111656
Patch by Sergio Correia <Sergio Correia> on 2013-03-07
Reviewed by Simon Hausmann.
The check for ANGLE GLES2 extensions is currently being overriden
with checks for APPLE extensions in lookupOpenGLFunctionAddress().
No new tests. No user visible behavior changed.
- platform/graphics/OpenGLShims.cpp:
(WebCore::lookupOpenGLFunctionAddress):
- 7:43 AM Changeset in webkit [145078] by
-
- 2 edits in trunk/Source/WebCore
Rename visible_units.h to VisibleUnits.h in WebCore.vcxproj.filters
<http://webkit.org/b/111426>
- WebCore.vcxproj/WebCore.vcxproj.filters: Rename visible_units.h
to VisibleUnits.h and re-sort.
- 7:36 AM Changeset in webkit [145077] by
-
- 5 edits in trunk/Source
Web Inspector: Support a shortcut for reloading front-end in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=111709
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/buildSystemOnly.js:
- inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
Source/WebKit/chromium:
- src/js/DevTools.js:
- 7:35 AM Changeset in webkit [145076] by
-
- 11 edits in trunk/Source/WebCore
Web Inspector: Support setting up file system mappings from scripts panel context menu.
https://bugs.webkit.org/show_bug.cgi?id=111583
Reviewed by Pavel Feldman.
Added context menu items to set up network - file system mappings from sources panel.
Implemented mapping add/remove methods on Workspace.
Added a dialog suggesting to reload front-end after making such changes.
- English.lproj/localizedStrings.js:
- inspector/front-end/FileSystemMapping.js:
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPath):
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemRemoved):
(WebInspector.FileSystemWorkspaceProvider.prototype.fileSystemPath):
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype.onEnter):
(WebInspector.FilteredItemSelectionDialog.prototype.setQuery):
(WebInspector.SelectUISourceCodeDialog):
(WebInspector.SelectUISourceCodeDialog.prototype.uiSourceCodeSelected):
(WebInspector.SelectUISourceCodeDialog.prototype.filterProject):
(WebInspector.SelectUISourceCodeDialog.prototype.filterUISourceCode):
(WebInspector.SelectUISourceCodeDialog.prototype.selectItem):
(WebInspector.SelectUISourceCodeDialog.prototype._uiSourceCodeAdded):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.uiSourceCodeSelected):
(WebInspector.OpenResourceDialog.prototype.filterProject):
(WebInspector.SelectUISourceCodeForProjectTypeDialog):
(WebInspector.SelectUISourceCodeForProjectTypeDialog.prototype.uiSourceCodeSelected):
(WebInspector.SelectUISourceCodeForProjectTypeDialog.prototype.filterProject):
(WebInspector.SelectUISourceCodeForProjectTypeDialog.show):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._mapFileSystemToNetwork.mapFileSystemToNetwork):
(WebInspector.ScriptsPanel.prototype._mapFileSystemToNetwork):
(WebInspector.ScriptsPanel.prototype._removeNetworkMapping):
(WebInspector.ScriptsPanel.prototype._mapNetworkToFileSystem.mapNetworkToFileSystem):
(WebInspector.ScriptsPanel.prototype._mapNetworkToFileSystem):
(WebInspector.ScriptsPanel.prototype.):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeMappingItems):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
- inspector/front-end/SettingsScreen.js:
(WebInspector.WorkspaceSettingsTab):
(WebInspector.WorkspaceSettingsTab.prototype.wasShown):
(WebInspector.WorkspaceSettingsTab.prototype._reset):
- inspector/front-end/ViewportControl.js:
(WebInspector.ViewportControl.prototype.refresh):
- inspector/front-end/Workspace.js:
(WebInspector.Workspace.prototype.addMapping):
(WebInspector.Workspace.prototype.removeMapping):
- inspector/front-end/externs.js:
(WebInspector.suggestReload):
- inspector/front-end/inspector.js:
(WebInspector.suggestReload):
- 7:32 AM Changeset in webkit [145075] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Add support for frontend reloading
https://bugs.webkit.org/show_bug.cgi?id=111727
Reviewed by Pavel Feldman.
This patch adds support for frontend reloading including:
- making sure no messages are sent to backend once frontend started reloading
- updating frontend url with up-to-date dockSide query parameter value.
- inspector/front-end/InspectorBackend.js:
(InspectorBackendClass.prototype.sendMessageObjectToBackend):
(InspectorBackendClass.prototype.disconnect):
- inspector/front-end/externs.js:
(WebInspector.reload):
- inspector/front-end/inspector.js:
(WebInspector.reload):
- 7:28 AM Changeset in webkit [145074] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Change profile start button caption depending on profile type.
https://bugs.webkit.org/show_bug.cgi?id=111698
Change the start profiling button caption to "Snapshot" for
snapshot-like profile types, e.g. JS heap snapshot, native memory snapshot.
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-07
Reviewed by Yury Semikhatsky.
- English.lproj/localizedStrings.js:
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.isInstantProfile):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotProfileType.prototype.isInstantProfile):
(WebInspector.NativeMemoryProfileType.prototype.isInstantProfile):
- inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView):
(WebInspector.ProfileLauncherView.prototype.addProfileType):
(WebInspector.ProfileLauncherView.prototype._updateControls):
(WebInspector.MultiProfileLauncherView.prototype._updateControls):
(WebInspector.MultiProfileLauncherView.prototype._profileTypeChanged):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType.prototype.isInstantProfile):
- 7:25 AM Changeset in webkit [145073] by
-
- 3 edits in trunk/Source/WebCore
[texmap] Remove direct access to clip state from clip stack
https://bugs.webkit.org/show_bug.cgi?id=111630
Reviewed by Allan Sandfeld Jensen.
As we are now monitoring the clip state from
TextureMapperGL/BitmapTextureGL, have direct access to clip state object
would eventually make it dirty without properly setting the
'clipStateDirty' flag. This bug intends to substitute direct access with
auxiliary functions which would set the clip state dirty when necessary.
No new tests. No user visible behavior changed.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::ClipStack::intersect):
(WebCore::TextureMapperGL::ClipStack::setStencilIndex):
(WebCore::TextureMapperGL::drawBorder):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::beginClip):
Replaced direct access with auxiliary functions.
- platform/graphics/texmap/TextureMapperGL.h:
(ClipStack): Removed ClipStack::current() function.
(WebCore::TextureMapperGL::ClipStack::getStencilIndex): Added.
(WebCore::TextureMapperGL::ClipStack::isCurrentScissorBoxEmpty): Added.
- 7:20 AM Changeset in webkit [145072] by
-
- 2 edits in trunk/Tools
[chromium] don't track the top loading frame if no layout test is currently running
https://bugs.webkit.org/show_bug.cgi?id=111716
Reviewed by Kentaro Hara.
In DRT, we synchronously stop the test and start loading the next test
URL. However, in content_shell, this happens asynchronously. It's
important that the top loading frame is not changed due to stray
navigation events before the next test starts.
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::setTopLoadingFrame):
- 6:23 AM Changeset in webkit [145071] by
-
- 3 edits in trunk/Source/WebCore
[Texturemapper] transform-style 'flat' value is broken
https://bugs.webkit.org/show_bug.cgi?id=111566
Reviewed by Allan Sandfeld Jensen.
After changes from r144290, the CSS3 'transform-styles' property, when
used with 'flat' value, resulted in non-stenciled rendering inside
clipped area - vide example from Surfin' Safari blog:
https://www.webkit.org/blog-files/3d-transforms/transform-style.html
This patch forces the clip state to be applied when binding the default
surface.
No new tests. No user visible behavior changed.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::ClipStack::apply):
(WebCore::TextureMapperGL::ClipStack::applyIfNeeded): Added.
Moved state cache check from apply() to applyIfNeeded().
(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::bind):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::endClip):
- platform/graphics/texmap/TextureMapperGL.h:
(ClipStack):
Use applyIfNeeded() to check for clip state before clipping.
- 6:22 AM Changeset in webkit [145070] by
-
- 4 edits in trunk/Source/WebKit/gtk
[GTK] Expose "ShouldRespectImageOrientation" setting into WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=111414
Patch by Tomas Popela <tpopela@redhat.com> on 2013-03-07
Reviewed by Carlos Garcia Campos.
We should expose ShouldRespectImageOrientation setting into
WebKitWebSettings. When it is enabled, the images are shown with right
orientation regarding to images EXIF data.
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
- webkit/webkitwebsettingsprivate.h:
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
- 6:22 AM Changeset in webkit [145069] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: refactoring: move TextEditorModel.Indent enum into TextUtils
https://bugs.webkit.org/show_bug.cgi?id=111715
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-07
Reviewed by Pavel Feldman.
Move WebInspector.TextEditorModel.Indent into WebInspector.TextUtils namespace.
No new tests: no change in behaviour.
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
- inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
- inspector/front-end/TextUtils.js:
- 6:17 AM Changeset in webkit [145068] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: Add more diagnostics output to testRendererProcessNativeMemorySize
https://bugs.webkit.org/show_bug.cgi?id=111599
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-07
Reviewed by Yury Semikhatsky.
Add the process size to the test output.
- src/js/Tests.js:
- 6:00 AM Changeset in webkit [145067] by
-
- 16 edits5 adds in trunk
Fix painting phases for composited scrolling
https://bugs.webkit.org/show_bug.cgi?id=107618
Reviewed by Simon Fraser.
With composited scrolling, the scrolling contents layer paints the
foreground and the main graphics layer paints the background. This
causes a few problems:
1) If we create a foreground layer, we end up with two layers painting
the foreground phase.
2) Focus rings / outlines paint into the foreground layer, so they end
up moving around with the scrolling contents.
3) Neg z-order descendants paint in the the main graphics layer and
will therefore not scroll.
To deal with 1) we need to stop painting the foreground into both the
foreground and scrolling contents layers. We also need to ensure that
the foreground layer is the right size and has the right offset from
renderer if we're on the composited scrolling path.
To deal with 2) and 3), I have added a new graphics layer painting phase
flag -- GraphicsLayerPaintCompositedScroll -- and applied it to two
layers in the subtree created by RenderLayerBacking. This ultimately
affects the paint phase passed to RenderLayer::paintLayerContents and
allows us to paint the focus rings, outlines and negative z-order
descendants into the proper layers.
Source/WebCore:
Tests: compositing/overflow/composited-scrolling-paint-phases.html
compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html
compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer.html
- page/Frame.h: Added a flag for including painting phases in the layer tree dump.
(WebCore::GraphicsLayer::dumpProperties):
Can now dump painting phase information, but only if requested.
- platform/graphics/GraphicsLayerClient.h: Added a new entry to GraphicsLayerPaintingPhaseFlags for comp-scroll.
(WebCore::RenderLayer::paintLayerContents):
Updated the logic to account for the new comp-scroll-related paint
phase flag.
- rendering/RenderLayer.h: Added the RenderLayer painting phase counterpart to GraphicsLayerPaintCompositedScroll.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
Ensures that the foreground layer is sized correctly for comp-scroll.
(WebCore::RenderLayerBacking::updateScrollingLayers):
If we have a foreground layer, the scrolling contents layer no
longer gets assigned the foreground painting phase.
(WebCore::RenderLayerBacking::paintingPhaseForPrimaryLayer):
If we're comp-scrolling, then the primary layer gets the new phase.
(WebCore::RenderLayerBacking::paintIntoLayer):
Simply translates the new graphics layer painting phase to its
render layer counterpart.
(WebCore::RenderLayerCompositor::layerTreeAsText):
- testing/Internals.cpp:
(WebCore::Internals::layerTreeAsText):
- testing/Internals.h:
- testing/Internals.idl: The above changes are solely plumbing to allow layout tests to request that paint phase information be included in the layer tree dump.
LayoutTests:
- compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- compositing/overflow/composited-scrolling-paint-phases.html: Added.
- platform/mac/compositing/overflom/composited-scrolling-paint-phases-expected.txt: Added. This is a text-based test that checks that the graphics layer painting phases are correct with composited scrolling + foreground layers.
- compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html: Added.
- compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer.html: Added. These tests cover cases 2) and 3) above.
- platform/chromium/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations: These have been updated to reflect the missing baselines.
- 5:52 AM Changeset in webkit [145066] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Use Qt5.1 supportedMimeTypes methods.
https://bugs.webkit.org/show_bug.cgi?id=111185
Reviewed by Jocelyn Turcotte.
Uses the supportedMimeTypes() methods from QImageReader and QImageWriter when available.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):
- 5:36 AM Changeset in webkit [145065] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Flame Chart. Stick item color to the function.
https://bugs.webkit.org/show_bug.cgi?id=111697
Reviewed by Yury Semikhatsky.
Different nodes associated with a single function have to use the same color.
Minor polish: do not filter out (idle) and (program) items. They were big due to an error on v8 side.
Set minimum width to 0 for more precise picture.
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._rootNodes):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._drawNode):
(WebInspector.FlameChart.prototype._drawBar):
- 4:55 AM Changeset in webkit [145064] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [ACE] gutter size should be fixed.
https://bugs.webkit.org/show_bug.cgi?id=111576
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-07
Reviewed by Pavel Feldman.
Add a custom ace editor build that supports setFixedGutterWidth configuration
parameter and switch this setting on.
No new tests.
- inspector/front-end/AceTextEditor.js:
(WebInspector.AceTextEditor): Switch fixedGutterWidth setting on.
- inspector/front-end/ace/ace.js:
(.):
- 4:34 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:15 AM Changeset in webkit [145063] by
-
- 1 copy in releases/WebKitGTK/webkit-1.11.91
Tagging the WebKitGTK+ 1.11.91 release
- 3:52 AM Changeset in webkit [145062] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0
Unreviewed. Update NEWS and Versions.m4 for 1.11.91 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 1.11.91.
- 3:49 AM Changeset in webkit [145061] by
-
- 15 edits4 deletes in trunk/Source/WebCore
Unreviewed, rolling out r145059.
http://trac.webkit.org/changeset/145059
https://bugs.webkit.org/show_bug.cgi?id=111707
crash webkit build (Requested by tasak on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-07
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/DocumentRuleSets.cpp:
(WebCore::ShadowDistributedRules::collectMatchRequests):
- css/DocumentRuleSets.h:
- css/ElementRuleCollector.cpp: Removed.
- css/ElementRuleCollector.h: Removed.
- css/PageRuleCollector.cpp: Removed.
- css/PageRuleCollector.h: Removed.
- css/StyleResolver.cpp:
(WebCore::leftToRightDeclaration):
(WebCore):
(WebCore::rightToLeftDeclaration):
(WebCore::StyleResolver::State::ensureRuleList):
(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::addMatchedProperties):
(WebCore::StyleResolver::addElementStyleProperties):
(MatchingUARulesScope):
(WebCore::MatchingUARulesScope::MatchingUARulesScope):
(WebCore::MatchingUARulesScope::~MatchingUARulesScope):
(WebCore::MatchingUARulesScope::isMatchingUARules):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::compareRules):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::State::initForStyleResolve):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::comparePageRules):
(WebCore::StyleResolver::matchPageRules):
(WebCore::checkPageSelectorComponents):
(WebCore::StyleResolver::matchPageRulesForList):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::isFirstPage):
(WebCore::StyleResolver::pageName):
- css/StyleResolver.h:
(WebCore::MatchRequest::MatchRequest):
(MatchRequest):
(StyleResolver):
(MatchResult):
(WebCore::StyleResolver::State::State):
(State):
(WebCore::StyleResolver::State::takeRuleList):
(WebCore::StyleResolver::State::setSameOriginOnly):
(WebCore::StyleResolver::State::isSameOriginOnly):
(WebCore::StyleResolver::State::pseudoStyleRequest):
(WebCore::StyleResolver::State::setMode):
(WebCore::StyleResolver::State::mode):
(WebCore::StyleResolver::State::matchedRules):
(WebCore::StyleResolver::State::addMatchedRule):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willMatchRule):
- inspector/InspectorCSSAgent.h:
(WebCore):
(InspectorCSSAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willMatchRuleImpl):
- inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willMatchRule):
- 3:43 AM Changeset in webkit [145060] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Rebaselined run-bindings-tests.
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
- 3:19 AM Changeset in webkit [145059] by
-
- 15 edits4 copies in trunk/Source/WebCore
[Refactoring] Implement RuleCollector
https://bugs.webkit.org/show_bug.cgi?id=109916
Reviewed by Antti Koivisto.
Implemented rule collector for an element and collector for a page.
Not all members in class State are required entire while resolving
a style.
No new tests, because just refactoring.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
Added ElementRuleCollector and PageRuleCollector.
- css/DocumentRuleSets.cpp:
(WebCore::ShadowDistributedRules::collectMatchRequests):
Since behaviorAtBoundary is a state owned by ElementRuleCollector,
removed from here.
- css/DocumentRuleSets.h:
(WebCore::ShadowDistributedRules::isEmpty):
Added to quickly check whether there exist any ShadowDistributedRules
or not.
- css/ElementRuleCollector.cpp: Copied from Source/WebCore/css/StyleResolver.cpp.
(WebCore):
(WebCore::ElementRuleCollector::matchedResult):
(WebCore::ElementRuleCollector::matchedRuleList):
(WebCore::ElementRuleCollector::addMatchedRule):
(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::ensureRuleList):
(WebCore::ElementRuleCollector::addElementStyleProperties):
(WebCore::ElementRuleCollector::collectMatchingRules):
(WebCore::ElementRuleCollector::collectMatchingRulesForRegion):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::matchScopedAuthorRules):
(WebCore::ElementRuleCollector::matchHostRules):
(WebCore::ElementRuleCollector::matchShadowDistributedRules):
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchUserRules):
(WebCore::ElementRuleCollector::matchUARules):
(WebCore::ElementRuleCollector::ruleMatches):
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
(WebCore::ElementRuleCollector::sortMatchedRules):
(WebCore::ElementRuleCollector::matchAllRules):
Moved these methods from StyleResolver to this class.
(WebCore::ElementRuleCollector::hasAnyMatchingRules):
This method is used for checking whether a given element can share
a cache.
- css/ElementRuleCollector.h: Copied from Source/WebCore/css/StyleResolver.h.
(WebCore):
(WebCore::ElementRuleCollector::ElementRuleCollector):
Use styleResolver instance to initialize its member variables, i.e.
SelectorFilter, RuleSets, InspectorCSSOMWrappers, and
StyleScopedResolver.
(ElementRuleCollector):
(WebCore::ElementRuleCollector::setMode):
(WebCore::ElementRuleCollector::setPseudoStyleRequest):
(WebCore::ElementRuleCollector::setSameOriginOnly):
(WebCore::ElementRuleCollector::setRegionForStyling):
Mode, SameOriginOnly, RegionForStyling are only used while collecting
matched rules.
(WebCore::ElementRuleCollector::setMedium):
Need to know which default stylesheet should be looked up.
(WebCore::ElementRuleCollector::document):
- css/PageRuleCollector.cpp: Copied from Source/WebCore/css/StyleResolver.cpp.
(WebCore::comparePageRules):
(WebCore::PageRuleCollector::isLeftPage):
(WebCore::PageRuleCollector::isFirstPage):
(WebCore::PageRuleCollector::pageName):
(WebCore::PageRuleCollector::matchAllPageRules):
(WebCore::PageRuleCollector::matchPageRules):
(WebCore::checkPageSelectorComponents):
(WebCore::PageRuleCollector::matchPageRulesForList):
Moved from StyleResolver.
- css/PageRuleCollector.h: Copied from Source/WebCore/css/StyleResolver.h.
(WebCore):
(WebCore::PageRuleCollector::PageRuleCollector):
(PageRuleCollector):
(WebCore::PageRuleCollector::matchedResult):
- css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::MatchResult::addMatchedProperties):
(WebCore::StyleResolver::State::initForStyleResolve):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::applyMatchedProperties):
- css/StyleResolver.h:
(WebCore::MatchRequest::MatchRequest):
Removed behaviorAtBoundary. Instead, ElementRuleCollector have the
state.
(MatchRequest):
(WebCore::StyleResolver::selectorFilter):
Added to obtain SelectorFilter in ElementRuleCollector's constructor.
(StyleResolver):
(MatchResult):
(WebCore::StyleResolver::State::State):
To pass ASSERT in StyleResolver::applyProperties, need to keep
m_regionForStyling.
(State):
(WebCore::StyleResolver::State::regionForStyling):
(WebCore::StyleResolver::State::useSVGZoomRules):
(WebCore::StyleResolver::hasSelectorForId):
(WebCore):
(WebCore::checkRegionSelector):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willMatchRule):
Removed StyleResolver from its parameter list. Instead, added
InspectorCSSOMWrappers and DocumentStyleSheetCollection.
- inspector/InspectorCSSAgent.h:
(WebCore):
(InspectorCSSAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willMatchRuleImpl):
- inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willMatchRule):
- 2:41 AM Changeset in webkit [145058] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [ACE] add experimental breakpoint support
https://bugs.webkit.org/show_bug.cgi?id=111573
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-07
Reviewed by Pavel Feldman.
No new tests.
- Implement attributes model for ace editor. Update attribute
locations by handling onTextChange event from editor.
- Implement breakpoints atop of attributes model.
- inspector/front-end/AceTextEditor.js:
(WebInspector.AceTextEditor):
(WebInspector.AceTextEditor.prototype._updateBreakpoints):
(WebInspector.AceTextEditor.prototype._updateLineAttributes):
(WebInspector.AceTextEditor.prototype._onTextChange):
(WebInspector.AceTextEditor.prototype.addBreakpoint):
(WebInspector.AceTextEditor.prototype.removeBreakpoint):
(WebInspector.AceTextEditor.prototype.getAttribute):
(WebInspector.AceTextEditor.prototype.setAttribute):
(WebInspector.AceTextEditor.prototype.removeAttribute):
- inspector/front-end/ace/acedevtools.css:
(.ace-editor-container):
(.ace_gutter-cell.webkit-breakpoint):
(.ace_gutter-cell.webkit-breakpoint-conditional):
(.ace_gutter-cell.webkit-breakpoint-disabled):
(.ace_gutter-cell):
- 2:39 AM Changeset in webkit [145057] by
-
- 9 edits2 adds in trunk
Web Inspector: identify layers for CSS generated content in LayerTreeAgent
https://bugs.webkit.org/show_bug.cgi?id=111551
Source/WebCore:
Layers can be associated with pseudo elements, elements that are generated
when ::before or ::after pseudo-classes are used to style an element and
provide additional rendering using the CSS "content" property. In order to
identify that a layer is associated to a pseudo element, we add a new set of
optional properties on the Layer object: "isGeneratedContent", "pseudoElementId"
and "pseudoClass".
We need to provide the "pseudoElementId" for the same reason we provide a
"nodeId" for the Layer. This is so that the front-end can identify that a
layer whose "layerId" may have changed between two layer tree updates is
used to render content for the same pseudo element.
In the instance that a layer is rendering generated content, we also set
the "nodeId" to be the generating node's id. The generating node is the
node in the DOM that the user styled using ::before or ::after pseudo-classes.
We also add the pseudo-class used as the "pseudoClass" property such that the
front-end may provide useful information to the user about what type of
pseudo-class yielded the generation of this layer. We also deal with the
possibility that the layer is a reflection for a pseudo element.
Since pseudo elements are not part of the user-visible DOM, and thus can't be
pushed to the front-end, we maintain a special ID hash map in the LayerTreeAgent.
In order to be able to unbind a pseudo element id and a pseudo element, we add a
destructor method to PseudoElement and provide a new instrumentation call so that
the LayerTreeAgent may be notified of a PseudoElement being destroyed. This
reflects the principle we use to update the RenderLayer bindings when a
RenderLayer is destroyed, as notified by the RenderLayerCompositor.
Reviewed by Simon Fraser.
Test: inspector-protocol/layers/layers-generated-content.html
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::~PseudoElement): New destructor used to notify
InspectorInstrumentation of a PseudoElement being destroyed, such that
it can eventually be relayed to the InspectorLayerTreeAgent.
(WebCore):
- dom/PseudoElement.h:
(PseudoElement):
- inspector/Inspector.json: Add the new PseudoElementId type used for
the new "pseudoElementId" property on Layer, to which we also add the
"isGeneratedContent" and "pseudoClass" properties.
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::pseudoElementDestroyedImpl):
- inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::pseudoElementDestroyed): New method
called in the PseudoElement destructor used to relay the fact that a
PseudoElement was destroyed to the InspectorLayerTreeAgent.
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::reset): Clear the new PseudoElement
identifier maps.
(WebCore::InspectorLayerTreeAgent::pseudoElementDestroyed): Remove any
identifier binding for the provided PseudoElement being destroyed.
(WebCore):
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer): Set the new
"isGeneratedContent", "pseudoElementId" and "pseudoClass" properties on
the Layer object for layers associated with a pseudo element.
(WebCore::InspectorLayerTreeAgent::bind): Use emptyString() instead of "".
(WebCore::InspectorLayerTreeAgent::unbind): Use an iterator instead of a
get() and remove() combination in order to reduce lookups and mimick the
code written for unbindPseudoElement().
(WebCore::InspectorLayerTreeAgent::bindPseudoElement): Binds the provided
PseudoElement to a unique identifier.
(WebCore::InspectorLayerTreeAgent::unbindPseudoElement): Unbinds the
provided PseudoElement from its unique identifier.
- inspector/InspectorLayerTreeAgent.h:
(InspectorLayerTreeAgent):
LayoutTests:
New tests for layers associated with pseudo elements.
Reviewed by Simon Fraser.
- inspector-protocol/layers/layers-generated-content-expected.txt: Added.
- inspector-protocol/layers/layers-generated-content.html: Added.
- 2:08 AM Changeset in webkit [145056] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardneing. Skipped some failing tests.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt/TestExpectations:
- 2:06 AM Changeset in webkit [145055] by
-
- 29 edits13 adds in trunk
Add clear button to date/time input types
https://bugs.webkit.org/show_bug.cgi?id=111319
Reviewed by Kent Tamura.
Source/WebCore:
We want to remove the clear button from the calendar picker (Bug 109439)
so we are adding the clear button to the right side of the input element.
Tests: fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events.html
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events.html
fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events.html
fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events.html
fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events.html
- CMakeLists.txt: Added ClearButtonElement.cpp
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/html.css:
(input::-webkit-clear-button): Styles for the clear button.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::editControlValueChanged):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::~BaseMultipleFieldsDateAndTimeInputType):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::destroyShadowSubtree):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::disabledAttributeChanged):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::requiredAttributeChanged): Hide clear button if the value is required.
(WebCore):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::readonlyAttributeChanged):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::focusAndSelectClearButtonOwner): Called on mouse down on clear button.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldClearButtonRespondToMouseEvents):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::clearValue):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateClearButtonVisibility): We want to hide the clear button if the value is required or the value is empty.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateClearButtonVisibility):
(WebCore):
(WebCore::HTMLInputElement::requiredAttributeChanged):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/InputType.cpp:
(WebCore::InputType::requiredAttributeChanged): Notifies the InputType that the required attribute has changed.
(WebCore):
(WebCore::InputType::updateClearButtonVisibility):
- html/InputType.h:
(InputType):
- html/shadow/ClearButtonElement.cpp: Added.
(WebCore):
(WebCore::ClearButtonElement::ClearButtonElement):
(WebCore::ClearButtonElement::create):
(WebCore::ClearButtonElement::detach):
(WebCore::ClearButtonElement::releaseCapture): Stop capturing mouse events.
(WebCore::ClearButtonElement::defaultEventHandler):
- html/shadow/ClearButtonElement.h: Added.
(WebCore):
(ClearButtonElement):
(ClearButtonOwner):
(WebCore::ClearButtonElement::ClearButtonOwner::~ClearButtonOwner):
(WebCore::ClearButtonElement::removeClearButtonOwner):
(WebCore::ClearButtonElement::isMouseFocusable):
LayoutTests:
- fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events-expected.txt: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events.html: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-mouse-events-expected.txt:
- fast/forms/date-multiple-fields/date-multiple-fields-mouse-events.html:
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events-expected.txt: Added.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events.html: Added.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events-expected.txt:
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html:
- fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events-expected.txt: Added.
- fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events.html: Added.
- fast/forms/month-multiple-fields/month-multiple-fields-mouse-events-expected.txt:
- fast/forms/month-multiple-fields/month-multiple-fields-mouse-events.html:
- fast/forms/resources/common-clearbutton-change-and-input-events.js: Added.
(.testInput.onchange):
(.testInput.oninput):
(testClearButtonChangeAndInputEvents):
- fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-mouse-events-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html:
- fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html:
- fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events-expected.txt: Added.
- fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events.html: Added.
- fast/forms/week-multiple-fields/week-multiple-fields-mouse-events-expected.txt:
- fast/forms/week-multiple-fields/week-multiple-fields-mouse-events.html:
- platform/chromium/TestExpectations:
- 1:49 AM Changeset in webkit [145054] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Refactorings: Prepare SuggestBox for reuse.
https://bugs.webkit.org/show_bug.cgi?id=111301
Reviewed by Alexander Pavlov.
1) Remove userEnteredText from delegate interface.
Pass prefix to updateSuggestions instead.
2) Clarify that suggestions array is never null.
- inspector/front-end/SuggestBox.js:
(WebInspector.SuggestBox): Renamed parameter/member.
(WebInspector.SuggestBox.prototype._updateItems):
Minor readability changes.
(WebInspector.SuggestBox.prototype._canShowBox):
Use userEnteredText parameter.
(WebInspector.SuggestBox.prototype.updateSuggestions):
Pass userEnteredText to _canShowBox.
- inspector/front-end/DatabaseQueryView.js: Fix JSDocs.
- inspector/front-end/RuntimeModel.js: Ditto.
- inspector/front-end/TextPrompt.js: Ditto.
(WebInspector.TextPrompt.prototype._completionsReady):
Pass userEnteredText to updateSuggestions.
- 1:29 AM Changeset in webkit [145053] by
-
- 5 edits6 adds in trunk
TextTrackRegion Constructor
https://bugs.webkit.org/show_bug.cgi?id=110511
Reviewed by Adam Barth.
Source/WebCore:
This is an initial patch for implementing the TextTrackRegion
defined in the "WebVTT Extension: Regions for rendering cue groups":
https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/region.html
The feature components are hidden behind the WEBVTT_REGIONS flag
and is currently disabled by default in all ports and tests skipped.
Test: media/track/regions-webvtt/text-track-region-constructor.html
- WebCore.gypi: Added files to be included for building Chromium with
feature enabled (it is disabled by default).
- html/track/TextTrackRegion.cpp: Added.
(WebCore):
(WebCore::TextTrackRegion::TextTrackRegion):
(WebCore::TextTrackRegion::~TextTrackRegion):
(WebCore::TextTrackRegion::setId): Setter.
(WebCore::TextTrackRegion::setWidth): Setter.
(WebCore::TextTrackRegion::setHeight): Setter.
(WebCore::TextTrackRegion::setRegionAnchorX): Setter.
(WebCore::TextTrackRegion::setRegionAnchorY): Setter.
(WebCore::TextTrackRegion::setViewportAnchorX): Setter.
(WebCore::TextTrackRegion::setViewportAnchorY): Setter.
(WebCore::TextTrackRegion::scroll): Getter. Internally, the scroll
value is stored as a boolean, but when returned is converted to either
the empty string or "up".
(WebCore::TextTrackRegion::setScroll): Setter.
(WebCore::TextTrackRegion::setRegionSettings): Not used yet (see b/109818)
- html/track/TextTrackRegion.h: Added.
(WebCore):
(TextTrackRegion):
(WebCore::TextTrackRegion::create):
(WebCore::TextTrackRegion::track): Getter.
(WebCore::TextTrackRegion::id): Getter.
(WebCore::TextTrackRegion::width): Getter.
(WebCore::TextTrackRegion::height): Getter.
(WebCore::TextTrackRegion::regionAnchorX): Getter.
(WebCore::TextTrackRegion::regionAnchorY): Getter.
(WebCore::TextTrackRegion::viewportAnchorX): Getter.
(WebCore::TextTrackRegion::viewportAnchorY): Getter.
(WebCore::TextTrackRegion::regionSettings): Getter, used only internally (see b/109818).
- html/track/TextTrackRegion.idl: Added.
- page/DOMWindow.idl: Constructor support.
LayoutTests:
- TestExpectations:
- media/track/regions-webvtt/text-track-region-constructor-expected.txt: Added.
- media/track/regions-webvtt/text-track-region-constructor.html: Added.
- 1:05 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:04 AM Changeset in webkit [145052] by
-
- 11 edits12 adds in trunk
ConvertThis should be turned into Identity based on predictions in Fixup, rather than based on proofs in ConstantFolding
https://bugs.webkit.org/show_bug.cgi?id=111674
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
This gets rid of the speculated forms of ConvertThis in the backend, and has Fixup
convert them to either Identity(Object:@child) if the child is predicted object, or
Phantom(Other:@child) ; WeakJSConstant(global this object) if it's predicted Other.
The goal of this is to ensure that the optimization fixpoint doesn't create
Identity's, since doing so requires a rerun of CSE. So far this isn't a speed-up
but I'm hoping this will be a step towards reducing the need to rerun the fixpoint
so as to ultimately reduce compile times.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGAssemblyHelpers.h:
(AssemblyHelpers):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(FixupPhase):
(JSC::DFG::FixupPhase::observeUseKindOnNode):
(JSC::DFG::FixupPhase::setUseKindAndUnboxIfProfitable):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::globalThisObjectFor):
(Graph):
- dfg/DFGNode.h:
(Node):
(JSC::DFG::Node::convertToIdentity):
(JSC::DFG::Node::convertToWeakConstant):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
LayoutTests:
Reviewed by Oliver Hunt.
- fast/js/dfg-convert-this-object-then-exit-on-other-expected.txt: Added.
- fast/js/dfg-convert-this-object-then-exit-on-other.html: Added.
- fast/js/dfg-convert-this-other-then-exit-on-object-expected.txt: Added.
- fast/js/dfg-convert-this-other-then-exit-on-object.html: Added.
- fast/js/dfg-convert-this-polymorphic-object-then-exit-on-other-expected.txt: Added.
- fast/js/dfg-convert-this-polymorphic-object-then-exit-on-other.html: Added.
- fast/js/dfg-convert-this-polymorphic-object-then-exit-on-string-expected.txt: Added.
- fast/js/dfg-convert-this-polymorphic-object-then-exit-on-string.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-convert-this-object-then-exit-on-other.js: Added.
(foo):
- fast/js/script-tests/dfg-convert-this-other-then-exit-on-object.js: Added.
(foo):
- fast/js/script-tests/dfg-convert-this-polymorphic-object-then-exit-on-other.js: Added.
(foo):
- fast/js/script-tests/dfg-convert-this-polymorphic-object-then-exit-on-string.js: Added.
(foo):
- 1:03 AM Changeset in webkit [145051] by
-
- 6 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Revert "[GTK] When the WebProcess crashes, a signal should be emitted"
This reverts commit r144902. The API is problematic.
- 12:52 AM Changeset in webkit [145050] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- 12:51 AM Changeset in webkit [145049] by
-
- 2 edits in trunk/Source/WebCore
[v8] remove latin-1 transition flag
https://bugs.webkit.org/show_bug.cgi?id=111692
Patch by Dan Carney <dcarney@google.com> on 2013-03-07
Reviewed by Jochen Eisinger.
No new tests. No change in functionality.
- bindings/v8/V8ValueCache.cpp:
(WebCore::makeExternalString):
- 12:27 AM Changeset in webkit [145048] by
-
- 5 edits in trunk
Web Inspector: NavigatorView should show (program) for uiSourceCodes with empty name.
https://bugs.webkit.org/show_bug.cgi?id=111691
Reviewed by Alexander Pavlov.
Source/WebCore:
Made String.prototype methods return string literal, not String object.
- inspector/front-end/utilities.js:
(String.prototype.escapeCharacters):
LayoutTests:
- inspector/debugger/navigator-view-expected.txt:
- inspector/debugger/navigator-view.html:
- 12:18 AM Changeset in webkit [145047] by
-
- 2 edits in trunk/Source/JavaScriptCore
Children method in LLINT AST Not class should return [@child]
https://bugs.webkit.org/show_bug.cgi?id=90740
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-03-07
Reviewed by Filip Pizlo.
- offlineasm/ast.rb: Fixed the return value of the children method in the Not AST class.
- 12:15 AM WebKitGTK/2.0.x edited by
- Move landed patch to proposed merges (diff)
- 12:12 AM Changeset in webkit [145046] by
-
- 7 edits3 copies in trunk/Source/WebKit/chromium
[chromium] expose UserGestureToken via WebKit API so PPAPI plugins can correctly consume it
https://bugs.webkit.org/show_bug.cgi?id=104268
Reviewed by Darin Fisher.
Currently, the PPAPI creates a WebScopedUserGesture up to 10 seconds
after a call with an currently active user gesture was made. It should
use the newly added WebUserGestureToken to make sure this user gesture
is not consumed multiple times.
We can't require a WebUserGestureToken for a WebScopedUserGesture, since
e.g. the extension API needs to be able to create a WebScopedUserGesture
out of the blue.
- WebKit.gyp:
- WebKit.gypi:
- public/WebScopedUserGesture.h:
(WebKit):
(WebKit::WebScopedUserGesture::WebScopedUserGesture):
(WebScopedUserGesture):
- public/WebUserGestureIndicator.h:
(WebKit):
(WebUserGestureIndicator):
- public/WebUserGestureToken.h: Copied from Source/WebKit/chromium/public/WebScopedUserGesture.h.
(WebCore):
(WebKit):
(WebUserGestureToken):
(WebKit::WebUserGestureToken::WebUserGestureToken):
(WebKit::WebUserGestureToken::operator=):
(WebKit::WebUserGestureToken::~WebUserGestureToken):
(WebKit::WebUserGestureToken::isNull):
- src/WebScopedUserGesture.cpp:
(WebKit::WebScopedUserGesture::initializeWithToken):
(WebKit):
- src/WebUserGestureIndicator.cpp:
(WebKit::WebUserGestureIndicator::currentUserGestureToken):
(WebKit):
- src/WebUserGestureToken.cpp: Copied from Source/WebKit/chromium/src/WebUserGestureIndicator.cpp.
(WebKit):
(WebKit::WebUserGestureToken::WebUserGestureToken):
(WebKit::WebUserGestureToken::operator WebCore::UserGestureToken*):
(WebKit::WebUserGestureToken::assign):
(WebKit::WebUserGestureToken::reset):
- tests/WebUserGestureTokenTest.cpp: Copied from Source/WebKit/chromium/src/WebUserGestureIndicator.cpp.
(WebCore):
(WebCore::TEST):
- 12:08 AM Changeset in webkit [145045] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Cmd+L (Go-to-Line) masks Go to location bar action
https://bugs.webkit.org/show_bug.cgi?id=111357
Reviewed by Pavel Feldman.
Allow panel shortcut handlers to bubble event.
- inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog.install): Minor refactoring, added JSDocs.
(WebInspector.GoToLineDialog._show): Added JSDocs and return value.
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.handleShortcut):
Mark event as handled iff handler returned true.
- inspector/front-end/ScriptsPanel.js: Added return values to handlers.
- inspector/front-end/TimelinePanel.js: Ditto.
Mar 6, 2013:
- 11:52 PM Changeset in webkit [145044] by
-
- 3 edits3 adds in trunk
Box-shadow displayed improperly with border-radius.
https://bugs.webkit.org/show_bug.cgi?id=111256
Reviewed by Simon Fraser.
Source/WebCore:
RoundedRect::adjustRadii doesn't adjust radii correctly, because
the method compares maxRadiusWidth with maxRadiusHeight. However,
we have to compare maxRadiusWidth / rect.width() with
maxRadiusHeight / rect.height().
Test: fast/borders/border-radius-with-box-shadow-01.html
- platform/graphics/RoundedRect.cpp:
(WebCore::RoundedRect::adjustRadii):
Should check which ratio is smaller.
LayoutTests:
- fast/borders/border-radius-with-box-shadow-01-expected.txt: Added.
- fast/borders/border-radius-with-box-shadow-01.html: Added.
- platform/chromium-linux/fast/borders/border-radius-with-box-shadow-01-expected.png: Added.
- 11:49 PM Changeset in webkit [145043] by
-
- 2 edits in trunk/Source/WebCore
[V8] Preprocess constant values to avoid a "static_cast<signed int>" in CodeGeneratorV8.
https://bugs.webkit.org/show_bug.cgi?id=111625
Reviewed by Kentaro Hara.
When processing constants in IDL files, CodeGeneratorV8 currently runs
the values through 'static_cast<signed int>' in the generated code. We
can avoid this miniscule bit of overhead by preprocessing the hex value
in Perl when generating the code.
The FIXME has been in the code since it originally landed in 2009[1].
Now's as good a time as any to take care of it.
[1]: http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm?rev=144976#L2933
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
If we're presented with a string which begins with '0x', run it
through some fairly obtuse Perlisms to first convert from a hex
string to an integer ('hex($value)'), "pack" the integer as an
unsigned integer ('pack("I", ...)'), and then "unpack" it as a
signed integer ('unpack("i", ...)'). Because that's _of course_
how you would do things.
- 11:25 PM Changeset in webkit [145042] by
-
- 2 edits in trunk/Source/WebKit2
SandboxExtension::createHandle raises an uncaught Objective-C exception if path is empty
https://bugs.webkit.org/show_bug.cgi?id=111689
Reviewed by Filip Pizlo.
- Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::createHandle): Use a function from WebCore platform layer instead of Foundation one equivalent. We already do this elsewhere in this file.
- 10:47 PM Changeset in webkit [145041] by
-
- 2 edits in trunk/Source/WebCore
WebKit does not build without accelerated compositing after Changeset 144823
https://bugs.webkit.org/show_bug.cgi?id=111597
Patch by Paweł Forysiuk <tuxator@o2.pl> on 2013-03-06
Reviewed by Kentaro Hara.
Properly guard functions ifdefed in ScrollingCoordinator.h.
Remove redundant checks and fallback code inside those functions.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::scrollLayerForScrollableArea):
(WebCore::ScrollingCoordinator::horizontalScrollbarLayerForScrollableArea):
(WebCore::ScrollingCoordinator::verticalScrollbarLayerForScrollableArea):
(WebCore):
- 10:32 PM Changeset in webkit [145040] by
-
- 11 edits2 moves in trunk/Source/WebCore
Custom Elements Refactoring: CustomElementConstructor API shouldn't bound to HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=111678
Reviewed by Kentaro Hara.
The latest Custom Elements standard supports non-HTML custom elements. Even though current implementation
support only HTML, it'd be better off to make API generic enough to support them.
This change
- eliminates HTMLElement from the API signature by replacing it with Element, and
- rename V8HTMLCustomElement to V8CustomElement.
No new tests, just changing signatures and a class name.
- WebCore.gypi:
- bindings/v8/V8CustomElement.cpp: Renamed from Source/WebCore/bindings/v8/V8HTMLCustomElement.cpp.
(WebCore):
(WebCore::findWrapperTypeOf):
(WebCore::V8CustomElement::createWrapper):
- bindings/v8/V8CustomElement.h: Renamed from Source/WebCore/bindings/v8/V8HTMLCustomElement.h.
(WebCore):
(V8CustomElement):
(WebCore::V8CustomElement::toV8):
(WebCore::V8CustomElement::wrap):
(WebCore::HTMLCustomElement::wrap):
- bindings/v8/custom/V8CustomElementConstructorCustom.cpp:
(WebCore::V8CustomElementConstructor::callAsFunctionCallback):
- dom/CustomElementConstructor.cpp:
(WebCore::CustomElementConstructor::createElement):
- dom/CustomElementConstructor.h:
(WebCore):
(CustomElementConstructor):
- dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::constructorOf):
(WebCore::CustomElementRegistry::createElement):
- dom/CustomElementRegistry.h:
(WebCore):
(CustomElementRegistry):
- dom/Document.cpp: Ensured that the document is an HTML.
(WebCore::Document::registerElement):
- dom/Document.idl:
- dom/make_names.pl:
(printWrapperFactoryCppFile):
- html/HTMLDocument.idl: Moved an API to Document.idl
- 9:58 PM Changeset in webkit [145039] by
-
- 2 edits in trunk/Source/WebKit2
[wk2] Page overlays shouldn't dirty the entire layer when flushing if the main frame can't scroll
https://bugs.webkit.org/show_bug.cgi?id=111662
<rdar://problem/13355808>
Reviewed by Simon Fraser.
Instead of setNeedsDisplay()ing the whole page overlay layer every time through
TCADA::flushLayers, do it at scroll time instead. Repainting on scroll is
necessary to keep things painted in the right place when we scroll (the overlay
is fixed to the size of the view), but is quite wasteful in apps that don’t scroll.
This works with threaded scrolling because overlay installation forces us
into main-thread scrolling mode.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scroll):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
- 9:55 PM Changeset in webkit [145038] by
-
- 2 edits in trunk/Source/WebCore
TileCache debug minimap should fit inside the intersection of the visible rect and exposed rect
https://bugs.webkit.org/show_bug.cgi?id=111655
<rdar://problem/13355773>
Reviewed by Simon Fraser.
If content clips to the exposed rect, make the TileCache minimap fit in the exposed rect too.
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::commitTreeState):
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::updateTileCoverageMap):
- 9:54 PM Changeset in webkit [145037] by
-
- 2 edits in trunk/Source/WebKit2
[wk2] Page overlays should use the accelerated drawing setting instead of hardcoding it on
https://bugs.webkit.org/show_bug.cgi?id=111654
<rdar://problem/13364085>
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
- 9:49 PM Changeset in webkit [145036] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r144726.
http://trac.webkit.org/changeset/144726
https://bugs.webkit.org/show_bug.cgi?id=111681
caused performance regression for Dromaeo attribute tests.
(Requested by arpitab on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-06
Source/WebCore:
- dom/Element.h:
(WebCore::ElementData::getAttributeItemIndex):
LayoutTests:
- fast/dom/Element/getAttribute-case-insensitivity-expected.txt: Removed.
- fast/dom/Element/getAttribute-case-insensitivity.html: Removed.
- 9:20 PM Changeset in webkit [145035] by
-
- 6 edits in trunk
File.lastModifiedDate() should return the current date/time if the file date/time is not available
https://bugs.webkit.org/show_bug.cgi?id=111403
Reviewed by Kent Tamura.
Source/WebCore:
Per the recent File API spec change:
http://www.w3.org/TR/2012/WD-FileAPI-20121025/#dfn-lastModifiedDate
Test: http/tests/local/fileapi/script-tests/file-last-modified-after-delete.js:
- fileapi/File.cpp:
(WebCore::File::lastModifiedDate): Changed to return the current date/time instead null if the valid file date/time is not available.
- fileapi/File.h:
(File):
LayoutTests:
- http/tests/local/fileapi/file-last-modified-after-delete-expected.txt: Updated.
- http/tests/local/fileapi/script-tests/file-last-modified-after-delete.js: Updated.
- 8:54 PM Changeset in webkit [145034] by
-
- 2 edits in trunk/Source/WebCore
Make RuleData support up to 8191 selectors
https://bugs.webkit.org/show_bug.cgi?id=111663
Patch by Philippe Liard <pliard@chromium.org> on 2013-03-06
Reviewed by Andreas Kling.
r125294 made RuleData consume less memory by replacing a pointer with
an index encoded on 12 bits.
This unfortunately breaks Chrome for Android (and others) when a lot of
CSS is used or more precisely when selectorIndex cannot be stored on 12
bits.
Threfore this change decreases the number of bits used to store
m_position by 1 (from 19 to 18) and adds this extra bit to
m_selectorIndex so that values up to 8191 can be stored safely without
overflowing.
- css/RuleSet.h:
(RuleData):
- 8:47 PM Changeset in webkit [145033] by
-
- 5 edits in trunk/Source/WebKit/chromium
[chromium] Fix typo: destoryPage() => destroyPage()
https://bugs.webkit.org/show_bug.cgi?id=111664
Patch by David Dorwin <ddorwin@chromium.org> on 2013-03-06
Reviewed by Kentaro Hara.
- src/WebHelperPluginImpl.cpp:
(WebKit::WebHelperPluginImpl::closeHelperPlugin):
(WebKit::WebHelperPluginImpl::destroyPage):
- src/WebHelperPluginImpl.h:
(WebHelperPluginImpl):
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::destroyPage):
(WebKit::WebPagePopupImpl::close):
(WebKit::WebPagePopupImpl::closePopup):
- src/WebPagePopupImpl.h:
(WebPagePopupImpl):
- 8:47 PM Changeset in webkit [145032] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Remove unused code from contextmenu of element panel
https://bugs.webkit.org/show_bug.cgi?id=111658
Patch by Seokju Kwon <Seokju Kwon> on 2013-03-06
Reviewed by Pavel Feldman.
No new tests (no functional changes).
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._contextMenuEventFired.set get var):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
- 8:46 PM Changeset in webkit [145031] by
-
- 6 edits in trunk
Source/WebKit: Unreviewed partial roll-out of r145003. Disable
ENABLE_CURSOR_VISIBILITY on win.
- WebKit.vcxproj/FeatureDefines.props:
WebKitLibraries: Unreviewed roll-out of r145011.
- win/tools/vsprops/FeatureDefines.vsprops:
LayoutTests: Unreviewed gardening.
- platform/win/TestExpectations:
- 8:39 PM Changeset in webkit [145030] by
-
- 1 copy in tags/Safari-537.33
New Tag.
- 7:51 PM Changeset in webkit [145029] by
-
- 19 edits in trunk
[CSS Grid Layout] Extend our grammar to support 2 positions for grid-{row|column}
https://bugs.webkit.org/show_bug.cgi?id=110777
Reviewed by Tony Chang.
Source/WebCore:
Now that we support all the logical grid properties, we can change grid-{row|column}
into shorthands. That's what this change does along with extending our parsing support
to handle 2 positions.
Tests: fast/css-grid-layout/grid-item-column-row.html
fast/css-grid-layout/grid-item-end-after-get-set.html
fast/css-grid-layout/grid-item-start-before-get-set.html
- css/CSSComputedStyleDeclaration.cpp:
Removed grid-{row|column} from computedProperties as they are shorthands (see comments
at computedProperties definition).
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForGridShorthand):
Switched to using the StylePropertyShorthand and reusing the existing longhand code.
- css/CSSComputedStyleDeclaration.h:
Added getCSSPropertyValuesForGridShorthand.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridItemPositionShorthand):
Added custom parsing for the shorthand, that builds on top of the longhand code.
- css/CSSParser.h:
Added parseGridItemPositionShorthand.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Removed the previous handling as shorthand are expanded at parse time.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
Added the new shorthands to the list.
- css/StylePropertyShorthand.cpp:
(WebCore::webkitGridColumnShorthand):
(WebCore::webkitGridRowShorthand):
(WebCore::shorthandForProperty):
- css/StylePropertyShorthand.h:
Registered grid-{row|column} as shorthands.
LayoutTests:
- fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
- fast/css-grid-layout/grid-item-column-row-get-set.html:
- fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
- fast/css-grid-layout/grid-item-end-after-get-set.html:
- fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
- fast/css-grid-layout/grid-item-start-before-get-set.html:
Extended the following test to ensure that grid-{row|column} are a
shortand for resp. grid-{before|after} and grid-{start|end}.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
Removed grid-{row|column} as they are now shorthands so they don't appear
in the list of supported properties.
- 7:48 PM Changeset in webkit [145028] by
-
- 11 edits1 add in trunk/Tools
Dashboard cleanup: Move all dashboard ui related code into ui.js.
https://bugs.webkit.org/show_bug.cgi?id=111621
Reviewed by Ojan Vafai.
Creates ui.js, a package for the common UI code the various
dashboards use. HTML generation is now in the ui.html namespace
and popup handling is in ui.popup.
Also moves the event listening for popups to ui.popup.show and
removes it on ui.popup.hid rather than having listener always
around.
- TestResultServer/static-dashboards/aggregate_results.html:
- TestResultServer/static-dashboards/dashboard_base.js:
- TestResultServer/static-dashboards/flakiness_dashboard.html:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(showPopupForBuild):
(htmlForNavBar):
(generatePageForIndividualTests.if):
(generatePageForIndividualTests):
- TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- TestResultServer/static-dashboards/run-embedded-unittests.html:
- TestResultServer/static-dashboards/run-unittests.html:
- TestResultServer/static-dashboards/timeline_explorer.html:
- TestResultServer/static-dashboards/treemap.html:
- TestResultServer/static-dashboards/ui.js: Added.
(.):
- 7:46 PM Changeset in webkit [145027] by
-
- 4 edits in trunk/Source
[Chromium] Fix byte ordering bugs reading back WebGL canvases' content on Android
https://bugs.webkit.org/show_bug.cgi?id=111661
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
Better documented contract of readBackFrameBuffer.
Source/WebCore:
No new tests; covered by existing tests. Ran WebGL conformance
tests on Android and desktop Linux to verify fix.
- platform/chromium/support/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
Avoid incorrect byte swap on Android and other OSs which don't
swizzle R and B channels.
- 7:43 PM Changeset in webkit [145026] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: fast/js/exception-sequencing-binops.html
- 7:32 PM Changeset in webkit [145025] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Improve warning messages when input value is out of range.
https://bugs.webkit.org/show_bug.cgi?id=111534
Reviewed by Laszlo Gombos.
Show input value range when user inputs greater or less value.
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::validationMessageRangeOverflowText):
(WebCore::validationMessageRangeUnderflowText):
- 7:25 PM Changeset in webkit [145024] by
-
- 5 edits in trunk/Source
[EFL][WK2] Enable interactive form validation for email and url input type validation
https://bugs.webkit.org/show_bug.cgi?id=111026
Reviewed by Laszlo Gombos.
WebKit EFL can check if input value is valid by enabling this feature.
Source/WebCore:
- platform/efl/LocalizedStringsEfl.cpp: Change validation messages of email and url the same with chromium port.
(WebCore::validationMessageTypeMismatchForEmailText):
(WebCore::validationMessageTypeMismatchForMultipleEmailText):
(WebCore::validationMessageTypeMismatchForURLText):
- platform/efl/RenderThemeEfl.cpp: Add type checking conditions for email and url.
(WebCore::RenderThemeEfl::supportsDataListUI):
Source/WebKit2:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
- 7:22 PM Changeset in webkit [145023] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: media/encrypted-media/encrypted-media-events.html
- 7:03 PM Changeset in webkit [145022] by
-
- 2 edits in trunk/Source/WTF
Build fix: PageAllocationAligned no longer has executable flag
https://bugs.webkit.org/show_bug.cgi?id=111659
Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-03-06
Reviewed by Kentaro Hara.
Build fix: use false as parameter to execution flag.
- wtf/PageAllocationAligned.cpp:
(WTF::PageAllocationAligned::allocate):
- 6:30 PM Changeset in webkit [145021] by
-
- 3 edits in trunk/Source/WebCore
Remove WebCore::Node::isActiveNode() since it isn't called anywhere.
https://bugs.webkit.org/show_bug.cgi?id=111646
Reviewed by Kentaro Hara.
No new tests. This removes dead code.
- dom/Node.h:
(Node):
- html/HTMLAudioElement.h:
- 6:22 PM Changeset in webkit [145020] by
-
- 2 edits in trunk/Source/WTF
AtomicStringImpls are not safe to send between threads
https://bugs.webkit.org/show_bug.cgi?id=111652
Reviewed by Benjamin Poulain.
We don't have this problem yet, but it's good to be safe.
- wtf/text/WTFString.cpp:
(WTF::String::isSafeToSendToAnotherThread):
- 6:16 PM Changeset in webkit [145019] by
-
- 7 edits in branches/chromium/1364/Source/WebCore
Merge 139854
[V8] Make an Isolate parameter mandatory in SerializedScriptValue::deserialize()
https://bugs.webkit.org/show_bug.cgi?id=106916
Reviewed by Adam Barth.
This is one of steps to remove optional Isolate parameters.
No tests. No change in behavior.
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::deserialize):
(WebCore):
(WebCore::SerializedScriptValue::deserializeForInspector):
- bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAccessorGetter):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
- bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):
TBR=haraken@chromium.org
Review URL: https://codereview.chromium.org/12560005
- 6:14 PM Changeset in webkit [145018] by
-
- 3 edits in trunk/Source/WTF
Don't give PageAllocationAligned the option to allocate executable memory
https://bugs.webkit.org/show_bug.cgi?id=111657
Reviewed by Geoffrey Garen.
- wtf/PageAllocationAligned.cpp:
(WTF::PageAllocationAligned::allocate):
- wtf/PageAllocationAligned.h:
(PageAllocationAligned):
- 5:39 PM Changeset in webkit [145017] by
-
- 2 edits1 delete in trunk/LayoutTests
Unreviewed gardening AppleWin port.
- platform/win/TestExpectations:
- platform/win/cssom: Removed.
- platform/win/cssom/cssvalue-comparison-expected.txt: Removed.
- 5:31 PM Changeset in webkit [145016] by
-
- 2 edits in branches/chromium/1410/Source/WebCore
Merge 145013
Crash in SVGViewSpec::viewTarget
https://bugs.webkit.org/show_bug.cgi?id=111648
Reviewed by Philip Rogers.
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::viewTarget):
TBR=inferno@chromium.org
Review URL: https://codereview.chromium.org/12562002
- 5:29 PM Changeset in webkit [145015] by
-
- 2 edits in branches/chromium/1364/Source/WebCore
Merge 145013
Crash in SVGViewSpec::viewTarget
https://bugs.webkit.org/show_bug.cgi?id=111648
Reviewed by Philip Rogers.
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::viewTarget):
TBR=inferno@chromium.org
Review URL: https://codereview.chromium.org/12424003
- 5:27 PM Changeset in webkit [145014] by
-
- 13 edits2 copies in trunk
[EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
https://bugs.webkit.org/show_bug.cgi?id=110584
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-06
Reviewed by Gyuyoung Kim.
Source/WebKit/efl:
Adds support for help text in DumpRenderTree.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::accessibilityHelpText):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Adds missing implementation of AccessibilityControllerEfl
and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
so that it can make accessibilityController as a js object.
- DumpRenderTree/AccessibilityController.h:
(AccessibilityController):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
(AccessibilityController::childElementById): Moved declaration to base class.
Implementation can be shared among other ports.
- DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
(AccessibilityController::focusedElement):
(AccessibilityController::rootElement):
(AccessibilityController::accessibleElementById):
- DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
(AccessibilityUIElement::helpText):
- DumpRenderTree/efl/CMakeLists.txt:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::DumpRenderTreeChrome):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
(DumpRenderTreeChrome::onWindowObjectCleared):
(DumpRenderTreeChrome::accessibilityController):
- DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
LayoutTests:
Unskipping LayoutTests/accessibility folder.
Added failure tests. Skipping those with missing expected results.
- platform/efl-wk1/TestExpectations:
- 5:25 PM WebKit Team edited by
- (diff)
- 5:24 PM Changeset in webkit [145013] by
-
- 2 edits in trunk/Source/WebCore
Crash in SVGViewSpec::viewTarget
https://bugs.webkit.org/show_bug.cgi?id=111648
Reviewed by Philip Rogers.
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::viewTarget):
- 5:17 PM Changeset in webkit [145012] by
-
- 30 edits in trunk
WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
https://bugs.webkit.org/show_bug.cgi?id=42696
Reviewed by Andreas Kling.
Source/WebCore:
Since the method acts directly on a WebCore element and strictly test
HTMLInputElement::shouldAutoComplete(), the test function is moved to internals.
- testing/Internals.cpp:
(WebCore::Internals::elementShouldAutoComplete):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/qt:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Tools:
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h:
(TestRunner):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
- DumpRenderTree/mac/TestRunnerMac.mm:
- DumpRenderTree/qt/TestRunnerQt.cpp:
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
- DumpRenderTree/win/TestRunnerWin.cpp:
- DumpRenderTree/wx/TestRunnerWx.cpp:
LayoutTests:
- security/set-form-autocomplete-attribute.html: Update the test.
- platform/wk2/TestExpectations: Unskip it for WebKit2.
- 5:16 PM Changeset in webkit [145011] by
-
- 2 edits in trunk/WebKitLibraries
Unreviewed build fix. Add ENABLE_CURSOR_VISIBILITY to the list of FEATURE_DEFINES for
(non-Cairo) Windows builds.
- win/tools/vsprops/FeatureDefines.vsprops:
- 5:15 PM Changeset in webkit [145010] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r143931): set-cookie-on-redirect.html still breaking subsequent tests
https://bugs.webkit.org/show_bug.cgi?id=111650
Unreviewed gardening.
- platform/mac/TestExpectations:
- 5:04 PM Changeset in webkit [145009] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: platform/chromium/fast/events/intercept-postmessage.html
- 4:58 PM Changeset in webkit [145008] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r144748-r144750): sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.1_T2.html failing on Apple MountainLion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=111647
Unreviewed skip in test expectations for Mac.
- platform/mac/TestExpectations:
- 4:35 PM Changeset in webkit [145007] by
-
- 16 edits in trunk/Source
[Mac] Synthetic ResourceResponses cannot be sent over IPC without losing most information
https://bugs.webkit.org/show_bug.cgi?id=111623
Reviewed by Brady Eidson.
- Shared/WebCoreArgumentCoders.cpp:
- Shared/WebCoreArgumentCoders.h: (CoreIPC::::encode): Made the decision on whether to serialize WebCore data in ResourceResponse dynamic. If the platform data is out of date, we need both (because some platforms use encodePlatformData() to pass additional information). (CoreIPC::::decode): Decode platform data first, because this overwrites the ResourceResponse.
- Shared/mac/WebCoreArgumentCodersMac.mm: (CoreIPC::::encodePlatformData): Don't encode NSURLResponse if it's out of date. We may have a bad NSURLResponse with 0 status code given to client, but it was almost certainly the same on sending side. WebCore doesn't mutate real responses - it either keeps them as is, or builds entirely synthetic ones.
- 4:32 PM Changeset in webkit [145006] by
-
- 4 edits2 deletes in trunk/Source
[chromium] Remove WebSharedGraphicsContext3D class
https://bugs.webkit.org/show_bug.cgi?id=111492
Reviewed by James Robinson.
Source/Platform:
- Platform.gypi:
- chromium/public/WebSharedGraphicsContext3D.h: Removed.
Source/WebCore:
Removing dead code, no new tests.
- WebCore.gypi:
- platform/chromium/support/WebSharedGraphicsContext3D.cpp: Removed.
- 4:31 PM Changeset in webkit [145005] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening: rebaselines.
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
- platform/chromium-win/svg/custom/foreign-object-skew-expected.txt:
- 4:29 PM Changeset in webkit [145004] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Don't get callbacks or create GrContext from unowned WebGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=111638
Reviewed by James Robinson.
If the context is not owned, it's lifetime is not guaranteed, and by the time
the GraphicsContext3D is destroyed, the WGC3D can already be deleted.
When the context is not owned by the GraphicsContext3D, then don't clean it up
in the destructor or set up callbacks, as these are the owner's responsibility.
- platform/chromium/support/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::setContextLostCallback):
(WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):
- 4:27 PM Changeset in webkit [145003] by
-
- 38 edits2 adds in trunk
Default mouse cursor behavior should be auto-hide for full screen video with custom controls
https://bugs.webkit.org/show_bug.cgi?id=107601
Reviewed by Beth Dakin.
Source/WebCore:
Test: fullscreen/video-cursor-auto-hide.html
To facilitate automatically hiding the mouse cursor after a certain amount of idle mouse
time, add a new CSS property '-webkit-cursor-visibility', and handle that value inside of
EventHandler. When that value is present, the EventHandler will start a timer which, when
fired, will set the view's cursor to the None cursor. Subsequent mouse moves will either
cancel the timer, or reset the auto-hide timer.
Add a new CSS property, '-webkit-cursor-visibility':
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ECursorVisibility):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Add a rule for video descendants of full screen elements to auto-hide the cursor on hover:
- css/fullscreen.css:
(:-webkit-full-screen video:hover):
Add a new timer, m_autoHideCursorTimer, to control resetting the view's cursor to None after
enough mouse idle time has passed.
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::~EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::startAutoHideCursorTimer):
(WebCore::EventHandler::cancelAutoHideCursorTimer):
(WebCore::EventHandler::autoHideCursorTimerFired):
- page/EventHandler.h:
Make FrameView::isActive() a public function (like it is in its superclass).
- page/FrameView.h:
(FrameView):
Move the definition for timeWithoutMouseMovementBeforeHidingControls from page->theme()
to page->settings() and allow that setting to be overridden in InternalSettings for
testing purposes:
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(WebCore::Settings::setTimeWithoutMouseMovementBeforeHidingControls):
(WebCore::Settings::timeWithoutMouseMovementBeforeHidingControls):
- rendering/RenderTheme.h:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setTimeWithoutMouseMovementBeforeHidingControls):
- testing/InternalSettings.h:
(InternalSettings):
- testing/InternalSettings.idl:
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::startHideFullscreenControlsTimer):
Add support to FeatureObserver for CURSOR_VISIBILITY:
- page/FeatureObserver.h:
Enable the feature flag:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
Enable the CURSOR_VISIBILITY feature.
- WebKit.vcxproj/FeatureDefines.props:
Source/WebKit/mac:
Enable the CURSOR_VISIBILITY feature.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Enable the CURSOR_VISIBILITY feature.
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
Enable the CURSOR_VISIBILITY feature.
- wtf/FeatureDefines.h:
LayoutTests:
- fullscreen/video-cursor-auto-hide-expected.txt: Added.
- fullscreen/video-cursor-auto-hide.html: Added.
Add an expected failing result in platforms which do not enable CURSOR_VISIBILITY.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- 4:27 PM Changeset in webkit [145002] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Return m_inspectorFilesPath if it is not null
https://bugs.webkit.org/show_bug.cgi?id=111633
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-06
Reviewed by Martin Robinson.
Added missing return in InspectorClient::inspectorFilesPath().
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::inspectorFilesPath):
- 4:26 PM Changeset in webkit [145001] by
-
- 4 edits in trunk
Full screen from an iframe with a z-index style will allow siblings with higher z-index to overlay full screen content.
https://bugs.webkit.org/show_bug.cgi?id=111637
Reviewed by Simon Fraser.
Source/WebCore:
No new tests; updated fullscreen/full-screen-iframe-zIndex.html to expose bug.
Pages with explicit z-index: styles on their iframes will override the default z-index: UA style when
elements within that iframe enter full screen mode. Mark the UA style as !important so as to not allow
iframe siblings with higher z-index styles to overlay the full screen element.
- css/fullscreen.css:
(:-webkit-full-screen):
LayoutTests:
- fullscreen/full-screen-iframe-zIndex.html:
- 4:25 PM Changeset in webkit [145000] by
-
- 23 edits in trunk/Source/JavaScriptCore
Bring back eager resolution of function scoped variables
https://bugs.webkit.org/show_bug.cgi?id=111497
Reviewed by Geoffrey Garen.
This reverts the get/put_scoped_var part of the great non-local
variable resolution refactoring. This still leaves all the lazy
variable resolution logic as it's necessary for global property
resolution, and i don't want to make the patch bigger than it
already is.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(CodeBlock):
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::codeBlockFor):
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(JSC):
(UnlinkedFunctionExecutable):
(UnlinkedCodeBlock):
(JSC::UnlinkedCodeBlock::usesGlobalObject):
(JSC::UnlinkedCodeBlock::setGlobalObjectRegister):
(JSC::UnlinkedCodeBlock::globalObjectRegister):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::ResolveResult::checkValidity):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitLoadGlobalObject):
(JSC):
(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::resolveConstDecl):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithThis):
(JSC::BytecodeGenerator::emitGetStaticVar):
(JSC::BytecodeGenerator::emitPutStaticVar):
- bytecompiler/BytecodeGenerator.h:
(JSC::ResolveResult::lexicalResolve):
(JSC::ResolveResult::isStatic):
(JSC::ResolveResult::depth):
(JSC::ResolveResult::index):
(ResolveResult):
(JSC::ResolveResult::ResolveResult):
(BytecodeGenerator):
- bytecompiler/NodesCodegen.cpp:
(JSC::ResolveNode::isPure):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::PostfixNode::emitResolve):
(JSC::TypeOfResolveNode::emitBytecode):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::debugFail):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
(JIT):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_scoped_var):
(JSC):
(JSC::JIT::emit_op_put_scoped_var):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_scoped_var):
(JSC):
(JSC::JIT::emit_op_put_scoped_var):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CodeCache.cpp:
(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
- runtime/CodeCache.h:
(JSC):
(CodeCache):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::createEvalCodeBlock):
- runtime/JSGlobalObject.h:
(JSGlobalObject):
- runtime/Options.cpp:
(JSC::Options::initialize):
- 4:24 PM Changeset in webkit [144999] by
-
- 1 edit1 move1 add12 deletes in trunk/LayoutTests
editing/pasteboard/paste-4035648-fix.html should be a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=111639
Reviewed by Levi Weintraub.
Converted the test. Also renamed it to line-feed-between-br-and-b-should-not-reorder-pasted-content.html
to reflect the semantics of the test, and also added more description per radar bug.
- editing/pasteboard/line-feed-between-br-and-b-should-not-reorder-pasted-content-expected.txt: Added.
- editing/pasteboard/line-feed-between-br-and-b-should-not-reorder-pasted-content.html: Copied from
LayoutTests/editing/pasteboard/paste-4035648-fix.html.
- editing/pasteboard/paste-4035648-fix.html: Removed.
- platform/chromium-linux/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
- platform/chromium-mac-lion/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.txt: Removed.
- platform/chromium/editing/pasteboard/paste-4035648-fix-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
- platform/gtk/editing/pasteboard/paste-4035648-fix-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-4035648-fix-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
- platform/qt/editing/pasteboard/paste-4035648-fix-expected.txt: Removed.
- 4:14 PM Changeset in webkit [144998] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: fast/dom/Window/window-special-properties.html
- 4:11 PM Changeset in webkit [144997] by
-
- 3 edits in trunk/Tools
Re-enable WinEWS test and decrease iterations before clean build back to 10.
- EWSTools/start-queue-win.sh:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 4:10 PM Changeset in webkit [144996] by
-
- 2 edits in trunk/LayoutTests
ASSERTION FAILED: m_tokenizer->state() == HTMLTokenizer::DataState
https://bugs.webkit.org/show_bug.cgi?id=110546
Unreviewed change to test expectations while the above bug is open.
- platform/mac/TestExpectations:
- 4:07 PM Changeset in webkit [144995] by
-
- 7 edits2 adds in trunk
InsertUnorderedList can lead to lost content and assertions in moveParagraphs
https://bugs.webkit.org/show_bug.cgi?id=111228
Reviewed by Ryosuke Niwa.
Source/WebCore:
When a list is wrapped in a presentational inline like a b tag, we'd create markup that included
everything up to the b tag from moveParagraphs when intending to only move the contents of the
list item. This could make it impossible to remove content from a list and trigger loss of
editable text.
Test: editing/execCommand/insert-remove-block-list-inside-presentational-inline.html
- editing/EditingStyle.cpp:
(WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl): Ensure there's an inline style
before calling propertyExistsInStyle.
(WebCore::HTMLElementEquivalent::propertyExistsInStyle): Removing null check for style.
All callers ensure this value isn't null.
- editing/markup.cpp:
(WebCore::highestAncestorToWrapMarkup): Avoid going over RenderBlocks when finding the highest
presentational ancestor to avoid leaving the bounds of the original paragraph.
LayoutTests:
- editing/deleting/pruning-after-merge-1-expected.txt:
- editing/execCommand/insert-remove-block-list-inside-presentational-inline-expected.txt: Added.
- editing/execCommand/insert-remove-block-list-inside-presentational-inline.html: Added.
- editing/pasteboard/paste-and-sanitize-expected.txt:
- editing/pasteboard/paste-and-sanitize.html:
- 3:56 PM Changeset in webkit [144994] by
-
- 3 edits1 add in trunk
[V8] Use implicit references instead of object groups to keep registered MutationObservers alive
https://bugs.webkit.org/show_bug.cgi?id=111382
Reviewed by Adam Barth.
.:
- ManualTests/mutation-observer-leaks-nodes.html: Added.
Source/WebCore:
Two-phase approach to implicit references: after grouping objects
together, add an implicit reference between each registered node's
group and the MutationObserver's group (which includes wrappers from
all worlds).
Also changed many uses of v8::Value to v8::Object where we know we're
dealing with Object and the V8 API expects them.
Test: ManualTests/mutation-observer-leaks-nodes.html
- bindings/v8/V8GCController.cpp:
(WebCore::ImplicitConnection::ImplicitConnection):
(WebCore::ImplicitConnection::wrapper):
(ImplicitConnection):
(WebCore::ImplicitReference::ImplicitReference): Wrapper class holding a parent who should have an implicit reference to a child.
(ImplicitReference):
(WebCore::operator<): Needed for std::sort() call to avoid the overhead of using a HashMap
(WebCore::WrapperGrouper::addObjectWrapperToGroup):
(WebCore::WrapperGrouper::addNodeWrapperToGroup):
(WebCore::WrapperGrouper::addImplicitReference):
(WrapperGrouper):
(WebCore::WrapperGrouper::apply):
- 3:25 PM Changeset in webkit [144993] by
-
- 4 edits in tags/Safari-537.31.15/Source
Versioning.
- 3:22 PM Changeset in webkit [144992] by
-
- 1 copy in tags/Safari-537.31.15
New Tag.
- 3:14 PM Changeset in webkit [144991] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, roll out http://trac.webkit.org/changeset/144989
I think we want the assertion that I removed.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::merge):
(JSC::DFG::AbstractState::mergeVariableBetweenBlocks):
- dfg/DFGAbstractState.h:
(AbstractState):
- 3:08 PM Changeset in webkit [144990] by
-
- 2 edits in trunk
Build fix. Fixes problems building code that uses deprecated functions from GTK+ 2,
such as RenderThemeGtk2.cpp, in debug mode. RenderThemeGtk2.cpp tries to allow usage
of deprecated functions by undefining GTK_DISABLE_DEPRECATED, but it ended up being
redefined because autotoolsconfig.h was included again by headers that came after
config.h.
Reviewed by Martin Robinson.
- Source/autotools/SetupWebKitFeatures.m4: add checks to ensure the
autotoolsconfig.h header is only included once.
- 3:04 PM Changeset in webkit [144989] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG::AbstractState::merge() is still more complicated than it needs to be
https://bugs.webkit.org/show_bug.cgi?id=111619
Reviewed by Mark Hahnenberg.
This method is the one place where we still do some minimal amount of liveness pruning, but the style with
which it is written is awkward, and it makes an assertion about variablesAtTail that will be invalidated
by https://bugs.webkit.org/show_bug.cgi?id=111539.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::merge):
(JSC::DFG::AbstractState::mergeVariableBetweenBlocks):
- dfg/DFGAbstractState.h:
(AbstractState):
- 2:56 PM Changeset in webkit [144988] by
-
- 5 edits in trunk/Source
Source/WebCore: Modify log method in V8DOMActivityLogger so that the apiName and
extraInfo arguments are of type const String& instead of const char*.
This change gets rid of some of the memory ownership issues that arise
with char* pointers.
https://bugs.webkit.org/show_bug.cgi?id=111483
Patch by Ankur Taly <ataly@google.com> on 2013-03-06
Reviewed by Adam Barth.
There are no new tests as there is no change in behavior.
- bindings/v8/V8DOMActivityLogger.h:
(WebCore::V8DOMActivityLogger::log):
Source/WebKit/chromium: Modify log method in WebDOMActivityLogger so that the apiName and
extraInfo arguments are of type const WebString& instead of const char*.
This change gets rid of some of the memory ownership issues that arise
with char* pointers.
https://bugs.webkit.org/show_bug.cgi?id=111483
Patch by Ankur Taly <ataly@google.com> on 2013-03-06
Reviewed by Adam Barth.
There are no new tests as there is no change in behavior.
- public/WebDOMActivityLogger.h: Added property svn:eol-style.
(WebKit::WebDOMActivityLogger::log):
- src/WebDOMActivityLogger.cpp: Added property svn:eol-style.
(WebKit::DOMActivityLoggerContainer::log):
- 2:55 PM Changeset in webkit [144987] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: compositing/rtl/..
- 2:52 PM Changeset in webkit [144986] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r186511. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-06
- DEPS:
- 2:44 PM Changeset in webkit [144985] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening of AppleWin port.
- platform/win/TestExpectations:
- 2:35 PM Changeset in webkit [144984] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: svg/css/font-face-crash.html
- 2:33 PM Changeset in webkit [144983] by
-
- 2 edits in branches/safari-534.59-branch/Source/WebKit2
<rdar://problem/13360535> - Bogus MESSAGE_CHECK in WebPageProxy::getPluginPath
Rubberstamped by Anders Carlsson.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath): Nuke a bogus MESSAGE_CHECK.
- 2:26 PM Changeset in webkit [144982] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][WK2] Implement WebInspector::localizedStringsURL() to return the file URL of localizedStrings.js
https://bugs.webkit.org/show_bug.cgi?id=111448
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-06
Reviewed by Alexey Proskuryakov.
Implement WebInspector::localizedStringsURL() method to return the
file URL of the localizedStrings.js.
This prevents printing warnings about "Localized string not found" in
the console.
- WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspector::localizedStringsURL):
- 2:24 PM Changeset in webkit [144981] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: svg/custom/foreign-object-skew.svg
- 2:24 PM Changeset in webkit [144980] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] |m_gestureScrollOnImplThread| is not reset to false following the end of a fling on the fast path
https://bugs.webkit.org/show_bug.cgi?id=111390
Reviewed by James Robinson.
If there is a fast path gesture scroll which turns into a fling, the member
|m_gestureScrollOnImplThread| is not reset to false once the fling ends. As a
result, GestureScrollUpdate events belonging to a subsequent scroll are always
handled on the fast path, even if they should have been handled on the slow
path instead.
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
- src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::isGestureScrollOnImplThread):
- tests/WebCompositorInputHandlerImplTest.cpp:
(WebKit::TEST_F):
(WebKit):
- 2:22 PM Changeset in webkit [144979] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 2:20 PM Changeset in webkit [144978] by
-
- 1 copy in tags/Safari-536.29.4
New Tag.
- 2:12 PM Changeset in webkit [144977] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Selection handles don't drag to expand correctly for RTL languages
https://bugs.webkit.org/show_bug.cgi?id=111618
Reviewed by Rob Buis.
PR 303712
If we are using a RTL language, we should ensure that the selection handles are angled the right way.
Further, when expanding the selection, the start and end handles should be appropriately set so that
expansion in the natural direction is possible.
Internally reviewed by Mike Fenton.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::SelectionHandler):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- WebKitSupport/SelectionHandler.h:
(SelectionHandler):
- 1:38 PM Changeset in webkit [144976] by
-
- 5 edits in trunk/Source/WebCore
Use SkTypeface API directly, rather than (soon to be private) SkFontHost
https://bugs.webkit.org/show_bug.cgi?id=111588
Reviewed by Stephen White.
No new tests, as existing tests in fast/writing-mode exercise this code.
e.g. japanese-rl-text-with-broken-font.html
vertical-subst-font-vert-no-dflt.html
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::emSizeInFontUnits):
(WebCore::FontPlatformData::openTypeTable):
- platform/graphics/harfbuzz/HarfBuzzFaceSkia.cpp:
(WebCore::harfBuzzSkiaGetTable):
(WebCore::HarfBuzzFace::createFace):
- platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformInit):
- 1:35 PM Changeset in webkit [144975] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] REGRESSION(r143582): API test EWK2UnitTestBase.ewk_view_contents_size_changed failing
https://bugs.webkit.org/show_bug.cgi?id=110608
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-06
Reviewed by Kenneth Rohde Christiansen.
Test was expecting ContentsSizeChanged signal from ViewClientEfl, but
WebView was not calling client callback if useFixedLayout() is true.
This patch prevent early return if useFixedLayout() is true and call
client callback didChangeContentsSize(), which will emit the signal.
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeContentsSize):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::didChangeContentsSize):
- 1:25 PM Changeset in webkit [144974] by
-
- 6 edits in trunk
Source/WebCore: Cleanup in multipart FormData sending code.
https://bugs.webkit.org/show_bug.cgi?id=111603
Patch by Victor Costan <costan@gmail.com> on 2013-03-06
Reviewed by Alexey Proskuryakov.
No new tests. This is cleanup.
- platform/network/FormDataBuilder.cpp:
(WebCore::appendQuotedString): use proper types (e.g, size_t instead of
unsigned long)
LayoutTests: Cleanup in multipart FormData tests.
https://bugs.webkit.org/show_bug.cgi?id=111603
Patch by Victor Costan <costan@gmail.com> on 2013-03-06
Reviewed by Alexey Proskuryakov.
- http/tests/local/formdata/resources/send-form-data-common.js:
(sendFormData): JavaScript style cleanup.
(testSendingFormData): JavaScript style, bugfix in checking if
eventSender.beginDragWithFiles needs to be called.
- http/tests/local/formdata/send-form-data-with-filename-expected.txt: Better test description.
- http/tests/local/formdata/send-form-data-with-filename.html: Better test description.
- 1:23 PM Changeset in webkit [144973] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG should not run full CSE after the optimization fixpoint, since it really just wants store elimination
https://bugs.webkit.org/show_bug.cgi?id=111536
Reviewed by Oliver Hunt and Mark Hahnenberg.
The fixpoint will do aggressive load elimination and pure CSE. There's no need to do it after the fixpoint.
On the other hand, the fixpoint does not profit from doing store elimination (except for SetLocal/Flush).
Previously we had CSE do both, and had it avoid doing some store elimination during the fixpoint by querying
the fixpoint state. This changes CSE to be templated on mode - either NormalCSE or StoreElimination - so
that we explicitly put it into one of those modes depending on where we call it from. The goal is to reduce
time spent doing load elimination after the fixpoint, since that is just wasted cycles.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::run):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(JSC::DFG::performCSE):
(DFG):
(JSC::DFG::performStoreElimination):
- dfg/DFGCSEPhase.h:
(DFG):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- 1:21 PM Changeset in webkit [144972] by
-
- 2 edits in trunk/Source/WebCore
Threaded HTML parser should use 8 bit strings for attributes
https://bugs.webkit.org/show_bug.cgi?id=111610
Reviewed by Eric Seidel.
This fixes a 27% regression in dromaeo_jslibattrjquery on the threaded HTML parser vs. the main thread parser.
No new tests because no new functionality.
- html/parser/CompactHTMLToken.cpp:
(WebCore::CompactHTMLToken::CompactHTMLToken):
- 1:16 PM Changeset in webkit [144971] by
-
- 2 edits in trunk/Source/WTF
Make fastmalloc use guardpages
https://bugs.webkit.org/show_bug.cgi?id=111353
Reviewed by Anders Carlsson.
Add PROT_NONE pages at the beginning and end of every
mmap call made by fastmalloc.
- wtf/TCSystemAlloc.cpp:
(TryMmap):
- 1:12 PM Changeset in webkit [144970] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Express webkit_unit_tests' dependency on DumpRenderTree.pak in gyp
https://bugs.webkit.org/show_bug.cgi?id=111508
Patch by James Robinson <jamesr@chromium.org> on 2013-03-06
Reviewed by Dirk Pranke.
Some tests in webkit_unit_tests, for example WebPageSerializerTest.HTMLNodes, depend on localizable resources
from a pak file. Since unit tests initialize for testing with the same webkit_support functions as layout tests
they end up using DumpRenderTree.pak, but this dependency isn't listed explicitly in the gyp so if you manage to
run webkit_unit_tests without building DumpRenderTree first these tests just crash.
This adds a dependency from webkit_unit_tests to DumpRenderTree_resources so the pak is always built. It's a bit
weird for a gyp file in Source/WebKit/chromium/ to reach into Tools/DumpRenderTree, but I can't think of
anything better.
- WebKitUnitTests.gyp:
- 1:09 PM Changeset in webkit [144969] by
-
- 4 edits in trunk
[WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
https://bugs.webkit.org/show_bug.cgi?id=82866
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-06
Reviewed by Martin Robinson.
Source/WebKit2:
Test was failing because of new media controls needs more space to be
painted than just 10x10 pixels. This is similar to r144070.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewMouseTarget): Modified HTML in order to give more space to the media controls.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
it is passing now.
- 1:00 PM Changeset in webkit [144968] by
-
- 3 edits in trunk/Tools
Dashboard cleanup: remove dashboard time logging.
https://bugs.webkit.org/show_bug.cgi?id=111608
Reviewed by Dirk Pranke.
Remove logTime. It was never accurate, and the dev tools
have better ways to measure this if anyone cares to look
into dashboard perf.
- TestResultServer/static-dashboards/dashboard_base.js:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(processTestRunsForBuilder):
(appendHTML):
- 12:58 PM Changeset in webkit [144967] by
-
- 3 edits in branches/chromium/1410
Merge 144789
REGRESSION(r142191): Fix closed caption buttons for ports still using the painting path.
https://bugs.webkit.org/show_bug.cgi?id=111109
Reviewed by Eric Carlson.
Source/WebCore:
Covered by following tests:
media/track/track-cue-rendering-horizontal.html
media/track/track-cue-rendering-vertical.html
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
- rendering/RenderTheme.h:
(WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton):
LayoutTests:
- platform/chromium/TestExpectations:
TBR=scherkus@chromium.org
Review URL: https://codereview.chromium.org/12463019
- 12:45 PM Changeset in webkit [144966] by
-
- 2 edits in trunk/Tools
[chromium] making DumpRenderTree_resources a separate bundle breaks xcode
https://bugs.webkit.org/show_bug.cgi?id=111509
Reviewed by Dirk Pranke.
Add DumpRenderTree.pak to DumpRenderTree.app again.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 12:42 PM Changeset in webkit [144965] by
-
- 2 edits in trunk/LayoutTests
Add a flaky crash test expectation to platform/mac/fast/speechsynthesis/speech-synthesis-cancel.html
on Mac per 111613.
- platform/mac/TestExpectations:
- 12:31 PM Changeset in webkit [144964] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: animations/animation-delay-changed.html
- 12:24 PM Changeset in webkit [144963] by
-
- 6 edits in trunk/LayoutTests
fast/css/hover-update.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=111592
Reviewed by Ryosuke Niwa.
Speculative fix for a flaky test. The test sometimes fails on slower machines (mostly debug).
Re-check the results in a loop for up to 200ms to see if the :hover pseudo style applies.
Also force a layout after changing the style, which should also trigger the :hover style.
- fast/css/hover-update.html:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- 12:16 PM Changeset in webkit [144962] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening: svg/custom/foreign-object-skew.svg
- platform/chromium/TestExpectations:
- 12:09 PM Changeset in webkit [144961] by
-
- 5 edits in trunk/Source/WebCore
More cleanup in GIFImageReader
https://bugs.webkit.org/show_bug.cgi?id=111137
Reviewed by Stephen White.
Refactor GIFImageReaderReader with the following changes:
+ Separate GIFLZWContext for decoding states.
+ Replace unsigned char* with Vector<unsigned char>
There is no change in code behavior and just refactoring.
No new tests. This is covered by existing GIFImageReaderTest.
I also did a local testing on a 50k image corpus and showed no regression.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::haveDecodedRow):
- platform/image-decoders/gif/GIFImageDecoder.h:
(GIFImageDecoder):
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::outputRow):
(GIFImageReader::doLZW):
(GIFImageReader::decodeInternal):
(GIFImageReader::prepareLZWContext):
- platform/image-decoders/gif/GIFImageReader.h:
(GIFFrameContext):
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext):
(GIFLZWContext):
(GIFLZWContext::GIFLZWContext):
(GIFImageReader):
- 12:05 PM Changeset in webkit [144960] by
-
- 2 edits in trunk/Source/WebKit2
[wk2] Page Overlays: Hook up the layer border/repaint counter setting to the overlay layer
https://bugs.webkit.org/show_bug.cgi?id=111547
<rdar://problem/13355801>
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
Keep the page overlay layer's debug border and repaint counter settings updated.
- 11:51 AM Changeset in webkit [144959] by
-
- 4 edits in trunk/Source/WebCore
Fix typo'd MainThreadScrollingBecauseOfStyleIndictaion
https://bugs.webkit.org/show_bug.cgi?id=111557
Reviewed by Geoff Garen.
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::commitTreeState):
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::updateTileCoverageMap):
- 11:48 AM Changeset in webkit [144958] by
-
- 3 edits in trunk/Source/WebKit2
Joing the adoptNS/adoptCF/adoptRef club.
https://bugs.webkit.org/show_bug.cgi?id=111467
Reviewed by Darin Adler.
Responding to review comments by Darin Adler.
- NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Tighten up this code
by reducing extraneous local variables.
- 11:43 AM Changeset in webkit [144957] by
-
- 3 edits in trunk/Source/JavaScriptCore
Pack Structure members better.
<http://webkit.org/b/111593>
<rdar://problem/13359200>
Reviewed by Mark Hahnenberg.
Shrink Structure by 8 bytes (now at 104 bytes) on 64-bit by packing the members better.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
- runtime/Structure.h:
(Structure):
- 11:34 AM Changeset in webkit [144956] by
-
- 2 edits1 add13 deletes in trunk/LayoutTests
editing/pasteboard/paste-table-cells.html should be a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=111491
Reviewed by Levi Weintraub.
Converted the test.
- editing/pasteboard/paste-table-cells-expected.txt: Added.
- editing/pasteboard/paste-table-cells.html:
- platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.png: Removed.
- platform/chromium-mac-lion/editing/pasteboard/paste-table-cells-expected.png: Removed.
- platform/chromium-mac-snowleopard/editing/pasteboard/paste-table-cells-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-table-cells-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-table-cells-expected.txt: Removed.
- platform/chromium/editing/pasteboard/paste-table-cells-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-table-cells-expected.png: Removed.
- platform/gtk/editing/pasteboard/paste-table-cells-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-table-cells-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-table-cells-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-table-cells-expected.png: Removed.
- platform/qt/editing/pasteboard/paste-table-cells-expected.txt: Removed.
- 11:31 AM Changeset in webkit [144955] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use the new authenticationChallenge API in WebPage
https://bugs.webkit.org/show_bug.cgi?id=111542
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-06
Reviewed by Rob Buis.
Use the new API that expects requestURL and isProxy parameters.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- Api/WebPageClient.h:
- 11:29 AM Changeset in webkit [144954] by
-
- 4 edits11 adds22 deletes in trunk/LayoutTests
Unreviewed chromium windows rebaselines for r144837.
- platform/chromium-linux/fast/invalid/017-expected.txt: Removed.
- platform/chromium-linux/fast/invalid/018-expected.txt: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- platform/chromium-mac-lion/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/chromium-win/fast/invalid/017-expected.txt:
- platform/chromium-win/fast/invalid/018-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- platform/chromium/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/efl/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- platform/mac-lion/tables/mozilla/bugs: Removed.
- platform/mac-lion/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
- platform/mac-lion/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/mac-wk2/tables/mozilla/bugs: Removed.
- platform/mac-wk2/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
- platform/mac-wk2/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- platform/qt/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- platform/win-future/tables: Added.
- platform/win-future/tables/mozilla: Added.
- platform/win-future/tables/mozilla/bugs: Added.
- platform/win-future/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
- platform/win-future/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/win-future/tables/mozilla_expected_failures: Added.
- platform/win-future/tables/mozilla_expected_failures/bugs: Added.
- platform/win-future/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
- tables/mozilla/bugs/bug113235-2-expected.txt: Replaced.
- tables/mozilla/bugs/bug9024-expected.txt: Replaced.
- tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Replaced.
- 11:28 AM Changeset in webkit [144953] by
-
- 18 edits in trunk/Source
Removed some dead code in the page cache
https://bugs.webkit.org/show_bug.cgi?id=111525
Reviewed by Alexey Proskuryakov.
Page cache autorelease doesn't exist anymore, so there's no need to keep
around these olds hacks.
../WebCore:
- WebCore.exp.in:
- history/PageCache.cpp:
(WebCore::PageCache::PageCache):
(WebCore):
- history/PageCache.h:
(PageCache):
- page/Settings.cpp:
(WebCore::Settings::setUsesPageCache):
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::releaseMemory):
- platform/qt/QtTestSupport.cpp:
(WebKit::QtTestSupport::clearMemoryCaches):
../WebKit/blackberry:
- Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::clearMemoryCaches):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::destroy):
../WebKit/efl:
- ewk/ewk_settings.cpp:
(ewk_settings_memory_cache_clear):
../WebKit/mac:
This fixes <rdar://problem/4886761> Fix bizarre WebWindowWatcher policy in WebHistoryItem.
- History/WebHistoryItem.mm:
(+[WebHistoryItem _releaseAllPendingPageCaches]):
- History/WebHistoryItemInternal.h:
- Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics autoreleasedPageCount]):
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
- 11:28 AM Changeset in webkit [144952] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp
Merge 144688
[chromium] Form controls on composited layers are not painted properly
https://bugs.webkit.org/show_bug.cgi?id=111366
Reviewed by James Robinson.
Set PlatformContextSkia::m_drawingToImageBuffer which is used as a hint to properly blend GDI-painted bitmap.
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
TBR=alokp@chromium.org
Review URL: https://codereview.chromium.org/12425009
- 11:08 AM Changeset in webkit [144951] by
-
- 6 edits2 adds in trunk
[chromium] introduce WebUserGestureIndicator
https://bugs.webkit.org/show_bug.cgi?id=111531
Reviewed by Adam Barth.
Source/WebKit/chromium:
Currently, an embedder needs to have a WebFrame to check whether a
user gesture is being processed and to consume a user gesture. However,
the user gesture state is independed of a frame.
- WebKit.gyp:
- public/WebFrame.h:
(WebFrame):
- public/WebUserGestureIndicator.h: Added.
(WebKit):
(WebUserGestureIndicator):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::isProcessingUserGesture):
(WebKit::WebFrameImpl::consumeUserGesture):
- src/WebUserGestureIndicator.cpp: Added.
(WebKit):
(WebKit::WebUserGestureIndicator::isProcessingUserGesture):
(WebKit::WebUserGestureIndicator::consumeUserGesture):
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createView):
- 11:05 AM Changeset in webkit [144950] by
-
- 13 edits2 deletes in trunk
Unreviewed, rolling out r144924.
http://trac.webkit.org/changeset/144924
https://bugs.webkit.org/show_bug.cgi?id=109908
caused multiple crashes in inspector/debugger tests
Source/WebCore:
- bindings/js/JSInjectedScriptHostCustom.cpp:
- bindings/js/ScriptObject.h:
- bindings/v8/ScriptObject.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
- inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::create):
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):
- inspector/InjectedScriptHost.h:
(WebCore):
(InjectedScriptHost):
- inspector/InjectedScriptHost.idl:
- inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::InjectedScriptManager):
(WebCore::InjectedScriptManager::discardInjectedScripts):
(WebCore::InjectedScriptManager::discardInjectedScriptsFor):
- inspector/InjectedScriptManager.h:
(InjectedScriptManager):
- inspector/InjectedScriptSource.js:
(.):
LayoutTests:
- inspector-protocol/persistent-id-expected.txt: Removed.
- inspector-protocol/persistent-id.html: Removed.
- inspector/console/command-line-api-expected.txt:
- 10:55 AM Changeset in webkit [144949] by
-
- 34 edits in trunk/Source
Introduce new message sources for logging.
https://bugs.webkit.org/show_bug.cgi?id=110968
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-06
Reviewed by Pavel Feldman.
Source/WebCore:
Added SecurityMessageSource, RenderingMessageSource, StorageMessageSource, AppCacheMessageSource, CSSMessageSource.
Changed some logging lines to contain more descriptive message source.
- Modules/webdatabase/DatabaseBase.cpp:
(WebCore::DatabaseBase::logErrorMessage):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::logErrorMessage):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::fail):
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
- css/MediaList.cpp:
(WebCore::addResolutionWarningMessageToConsole):
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::executeScript):
(WebCore::ScriptElement::notifyFinished):
- dom/ViewportArguments.cpp:
(WebCore::reportViewportWarning):
- html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseAttribute):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::getImageData):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
- inspector/ConsoleMessage.cpp:
(WebCore::messageSourceValue):
- inspector/Inspector.json:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::reportLocalLoadFailed):
(WebCore::createWindow):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::notifyFinished):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::responseReceived):
- loader/MixedContentChecker.cpp:
(WebCore::MixedContentChecker::logWarning):
- loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::corsPolicyPreventedLoad):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::abort):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::printAccessDeniedMessage):
- page/Console.cpp:
(WebCore::printMessageSourceAndLevelPrefix):
- page/ConsoleTypes.h:
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::logToConsole):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchMessageEventWithOriginCheck):
- page/PointerLockController.cpp:
(WebCore::PointerLockController::requestPointerLock):
- svg/SVGDocumentExtensions.cpp:
(WebCore::reportMessage):
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.mm:
- WebView/WebUIDelegatePrivate.h:
- 10:51 AM Changeset in webkit [144948] by
-
- 3 edits2 adds in trunk
SVG pattern to pattern reference does not work if first pattern has a child node
https://bugs.webkit.org/show_bug.cgi?id=111586
Reviewed by Philip Rogers.
Source/WebCore:
SVGPatternElement::collectPatternAttributes should test for child elements, not child nodes.
Tests: svg/custom/pattern-reference-expected.svg
svg/custom/pattern-reference.svg
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::collectPatternAttributes):
LayoutTests:
- svg/custom/pattern-reference-expected.svg: Added.
- svg/custom/pattern-reference.svg: Added.
- 10:50 AM Changeset in webkit [144947] by
-
- 5 edits1 copy in branches/chromium/1410/Source
Merge 144323
IndexedDB: IO error when checking schema should destroy LevelDB directory
https://bugs.webkit.org/show_bug.cgi?id=110675
Reviewed by Adam Barth.
Source/WebCore:
Also some refactoring to remove IDBBackingStore's dependence on
static LevelDBDatabase methods. This facilitated the unit test.
New unit test - IDBIOErrorTest.CleanUpTest
- Modules/indexeddb/IDBBackingStore.cpp:
(DefaultLevelDBFactory):
Wraps the previous behavior.
(WebCore::IDBBackingStore::open):
The default parameter provides the previous behavior, which is what
non-tests want.
- Modules/indexeddb/IDBBackingStore.h:
- platform/leveldb/LevelDBDatabase.h:
Source/WebKit/chromium:
- WebKit.gyp:
This was cargo-culted. The component build wouldn't run otherwise.
- WebKit.gypi:
- tests/IDBCleanupOnIOErrorTest.cpp: Added.
TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/12549003
- 10:46 AM Changeset in webkit [144946] by
-
- 2 edits in trunk/Source/Platform
[chromium] Remove the contents of WebVideoFrame class
https://bugs.webkit.org/show_bug.cgi?id=106037
Reviewed by James Robinson.
This class becomes an empty base class now, used only for the API
boundary.
- chromium/public/WebVideoFrame.h:
(WebKit):
- 10:37 AM Changeset in webkit [144945] by
-
- 6 edits3 adds in trunk/Source/WebKit2
Track sandbox extensions for blobs in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=111484
Reviewed by Sam Weinig.
- WebKit2.xcodeproj/project.pbxproj:
- NetworkProcess/FileAPI: Added.
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp: Added.
- NetworkProcess/FileAPI/NetworkBlobRegistry.h: Added. Added a registry that wraps normal in-process "BlobRegistryImpl", and also tracks sandbox extensions for blobs. It will also track process connections, so that blobs could be removed when a process crashes.
- NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::registerBlobURL): (WebKit::NetworkConnectionToWebProcess::registerBlobURLFromURL): (WebKit::NetworkConnectionToWebProcess::unregisterBlobURL): Use NetworkBlobRegistry.
- NetworkProcess/SchedulableLoader.h:
- NetworkProcess/SchedulableLoader.cpp: (WebKit::SchedulableLoader::SchedulableLoader): Add extensions for blobs, both in request URL and in request data. (WebKit::SchedulableLoader::consumeSandboxExtensions): Request may now have multiple extensions. (WebKit::SchedulableLoader::invalidateSandboxExtensions): Ditto.
- Shared/FileAPI/BlobRegistrationData.cpp: Fixed extension creation - actually store the result.
- 10:20 AM Changeset in webkit [144944] by
-
- 2 edits in trunk/LayoutTests
Add a flaky failure expectation to fast/css/hover-update.html on Mac per bug 111592.
- platform/mac/TestExpectations:
- 10:15 AM WebKitGTK/2.0.x edited by
- (diff)
- 10:11 AM Changeset in webkit [144943] by
-
- 2 edits in trunk/Source/WebKit/gtk
Link the webkit_tests to XRENDER_LIBS.
This solves the linking failure when building against gtk2 like:
usr/lib/gcc/i586-suse-linux/4.7/../../../../i586-suse-linux/bin/ld:
Source/WebCore/platform/gtk/Programs_unittests_testcopyandpaste-GtkVersioning.o:
undefined reference to symbol 'XFree'
/usr/lib/gcc/i586-suse-linux/4.7/../../../../i586-suse-linux/bin/ld:
note: 'XFree' is defined in DSO /usr/lib/libX11.so.6 so try adding it
to the linker command line
/usr/lib/libX11.so.6: could not read symbols: Invalid operation
https://bugs.webkit.org/show_bug.cgi?id=111572
Patch by Dominique Leuenberger <dimstar@opensuse.org> on 2013-03-06
Reviewed by Gustavo Noronha Silva.
- GNUmakefile.am:
- 10:10 AM Changeset in webkit [144942] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix Windows build after r144910.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 10:05 AM Changeset in webkit [144941] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r186371. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-06
- DEPS:
- 9:53 AM Changeset in webkit [144940] by
-
- 7 edits1 add in trunk/Tools
sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
https://bugs.webkit.org/show_bug.cgi?id=73482
Patch by Alan Cutter <alancutter@chromium.org> on 2013-03-06
Reviewed by Ryosuke Niwa.
Added input checking to the UpdateChromiumDEPS step.
Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
- Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
(RollChromiumDEPS):
(RollChromiumDEPS._parse_args):
(RollChromiumDEPS.execute):
- Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
(IRCCommandTest.test_roll_chromium_deps):
- Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
(IRCBotTest.test_roll_chromium_deps_to_lkgr):
- Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
- Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
(UpdateChromiumDEPS._fetch_last_known_good_revision):
(UpdateChromiumDEPS):
(UpdateChromiumDEPS._parse_revision_number):
(UpdateChromiumDEPS._validate_revisions):
(UpdateChromiumDEPS.run):
- Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
(UpdateChromiumDEPSTest):
(UpdateChromiumDEPSTest.test_parse_revision_number):
- Scripts/webkitpy/tool/commands/roll.py: Updated help text.
(RollChromiumDEPS):
(PostChromiumDEPSRoll):
- 9:41 AM Changeset in webkit [144939] by
-
- 8 edits in trunk/Source/JavaScriptCore
DFG should not check if nodes are shouldGenerate prior to DCE
https://bugs.webkit.org/show_bug.cgi?id=111520
Reviewed by Geoffrey Garen.
All nodes are live before DCE. We don't need to check that they aren't, because they
definitely will be.
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::int32ToDoubleCSE):
(JSC::DFG::CSEPhase::constantCSE):
(JSC::DFG::CSEPhase::weakConstantCSE):
(JSC::DFG::CSEPhase::getCalleeLoadElimination):
(JSC::DFG::CSEPhase::getArrayLengthElimination):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(JSC::DFG::CSEPhase::globalVarWatchpointElimination):
(JSC::DFG::CSEPhase::globalVarStoreElimination):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkStructureElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getMyScopeLoadElimination):
(JSC::DFG::CSEPhase::getLocalLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
- 9:39 AM Changeset in webkit [144938] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix unused parameter warnings in ARM assembler
https://bugs.webkit.org/show_bug.cgi?id=111433
Reviewed by Kentaro Hara.
- assembler/ARMAssembler.h: Remove unreachable revertJump() after r143346.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::moveIntsToDouble): Remove unused scratch parameter instead of UNUSED_PARAM.
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32): Remove unused fpTemp parameter.
(JSC::MacroAssemblerARM::revertJumpReplacementToPatchableBranchPtrWithPatch): Remove unused parameters.
- 9:32 AM Changeset in webkit [144937] by
-
- 4 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Added new baseline after r144837.
- platform/qt/fast/invalid/017-expected.txt:
- platform/qt/fast/invalid/018-expected.txt:
- platform/qt/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
- 9:29 AM WebKitGTK/2.0.x edited by
- (diff)
- 9:25 AM Changeset in webkit [144936] by
-
- 2 edits in trunk/Source/WebCore
[soup] session cookies are not correctly reported in getRawCookies()
https://bugs.webkit.org/show_bug.cgi?id=111584
Reviewed by Martin Robinson.
As per libsoup documentation, SoupCookie->expires is NULL for session cookies.
However, the soup implementation for getRawCookies() does not check for NULL
case before passing the value to soup_date_to_time_t(), which leads to run time
warnings.
We should also pass true for WebCore::Cookie's session argument if
SoupCookie->expires is NULL. The current implementation reports the cookie as a
session one if soup_cookie_jar_is_persistent(jar) returns true, which is
inaccurate.
No new tests, no behavior change for layout tests as Web Inspector currently
ignores the "session" member and uses expires/max-age instead to deduce it.
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::getRawCookies):
- 9:14 AM Changeset in webkit [144935] by
-
- 4 edits2 adds in trunk
REGRESSION(r111639): delayed animation start can be postponed
https://bugs.webkit.org/show_bug.cgi?id=108582
Source/WebCore:
Query the animation timer directly for the time it will next fire rather than
trying to cache the interval. Previous approach was incorrect -- as time advanced
it was possible for the interval to jump beyond the next service time.
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-03-06
Reviewed by Darin Adler.
Test: animations/animation-delay-changed.html
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationControllerPrivate::updateAnimationTimer):
- page/animation/AnimationControllerPrivate.h:
(AnimationControllerPrivate): Remove m_previousTimeToNextService
LayoutTests:
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-03-06
Reviewed by Darin Adler.
- animations/animation-delay-changed-expected.txt: Added.
- animations/animation-delay-changed.html: Added.
- 9:07 AM HackingGtk edited by
- (diff)
- 9:04 AM HackingGtk edited by
- (diff)
- 8:54 AM WebKitGTK/2.0.x edited by
- (diff)
- 8:51 AM Changeset in webkit [144934] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [ACE] show execution line in Ace editor
https://bugs.webkit.org/show_bug.cgi?id=111575
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-06
Reviewed by Pavel Feldman.
Highlight execution line by the means of Ace full line markers.
No new tests.
- inspector/front-end/AceTextEditor.js:
(WebInspector.AceTextEditor.prototype.setExecutionLine):
(WebInspector.AceTextEditor.prototype.clearExecutionLine):
(WebInspector.AceTextEditor.prototype.setSelection):
- inspector/front-end/ace/acedevtools.css:
(.ace-editor-container):
(.webkit-execution-line):
- 8:42 AM WebKitGTK/2.0.x edited by
- (diff)
- 8:39 AM WebKitGTK/2.0.x edited by
- (diff)
- 8:39 AM WebKitGTK/2.0.x edited by
- (diff)
- 8:38 AM WebKitGTK/2.0.x edited by
- (diff)
- 8:28 AM Changeset in webkit [144933] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/efl/TestExpectations: Adjusting the expectation for fast/workers/shared-worker-load-error.html.
- platform/gtk/TestExpectations: Add an expectation for a test added in r144824.
- 8:28 AM Changeset in webkit [144932] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: fix closure compiler warnings in the profiler code
https://bugs.webkit.org/show_bug.cgi?id=111581
Reviewed by Vsevolod Vlasov.
Added missing annotations. Replaced NativeProfileLauncherView with
ProfileLauncherView.
- inspector/InjectedScriptExterns.js:
(InjectedScriptHost.prototype.objectId):
(InjectedScriptHost.prototype.releaseObjectId):
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart.prototype._forEachNode):
- inspector/front-end/ProfileLauncherView.js:
- inspector/front-end/ProfilesPanel.js:
- 8:00 AM Changeset in webkit [144931] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Pass String::StrictConversion instead of true to String::utf8()
https://bugs.webkit.org/show_bug.cgi?id=111546
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-06
Reviewed by Rob Buis.
String::utf8() API changed in r134173.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
- 7:48 AM Changeset in webkit [144930] by
-
- 2 edits in trunk/Source/WebCore
Remove the (dead) code for handling shorthands in StyleResolver / StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=111505
Unreviewed minimal build fix.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Put CSSPropertyWebkitWrap under the proper if-guard.
- 7:45 AM Changeset in webkit [144929] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed follow up to r144928: front-end closure compilation fixes.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.JavaScriptOutlineDialog.prototype.dispose):
(WebInspector.OpenResourceDialog.prototype.dispose):
- inspector/front-end/StyleSheetOutlineDialog.js:
(WebInspector.StyleSheetOutlineDialog.prototype.dispose):
- 7:34 AM Changeset in webkit [144928] by
-
- 5 edits in trunk
Web Inspector: Update open resource dialog when new uiSourceCodes are loaded.
https://bugs.webkit.org/show_bug.cgi?id=111327
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog):
(WebInspector.FilteredItemSelectionDialog.prototype.willHide):
(WebInspector.FilteredItemSelectionDialog.prototype._itemsLoaded):
(WebInspector.FilteredItemSelectionDialog.prototype._updateAfterItemsLoaded):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems.compareFunction):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.SelectionDialogContentProvider.prototype.dispose):
(WebInspector.JavaScriptOutlineDialog.prototype._didBuildOutlineChunk):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.requestItems):
(WebInspector.OpenResourceDialog.prototype._filterUISourceCode):
(WebInspector.OpenResourceDialog.prototype._uiSourceCodeAdded):
(WebInspector.OpenResourceDialog.prototype.dispose):
- inspector/front-end/StyleSheetOutlineDialog.js:
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems.didGetStyleSheet):
LayoutTests:
- inspector/filtered-item-selection-dialog-filtering.html:
- 7:23 AM Changeset in webkit [144927] by
-
- 9 edits2 adds in trunk/Source/WebCore
Web Inspector: Move sidebar-specific styles to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=111173
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-06
Reviewed by Pavel Feldman.
- WebCore.gypi:
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.EventListenerBreakpointsSidebarPane):
- inspector/front-end/NativeBreakpointsSidebarPane.js:
(WebInspector.NativeBreakpointsSidebarPane):
- inspector/front-end/SidebarPane.js:
(WebInspector.SidebarPaneTitle):
(WebInspector.SidebarPaneStack):
(WebInspector.SidebarTabbedPane):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/breakpointsList.css: Added.
(.sidebar-pane > .body .breakpoint-condition):
(#breakpoint-condition-input):
(ol.breakpoint-list):
(.breakpoints-list-deactivated):
(.breakpoint-list li):
(.breakpoint-list li:hover):
(.breakpoint-list .checkbox-elem):
(.breakpoint-list .source-text):
(.sidebar-pane .breakpoint-hit):
(li.breakpoint-hit .breakpoint-hit-marker):
(.event-listener-breakpoints .event-category):
(.event-listener-breakpoints.properties-tree .children li):
(.event-listener-breakpoints .checkbox-elem):
- inspector/front-end/elementsPanel.css:
(.panel.elements .sidebar-pane-toolbar > select):
(.panel.elements .sidebar-pane-toolbar > select:hover):
(.panel.elements .sidebar-pane-toolbar > select:active):
(.panel.elements .sidebar-pane-toolbar > select.select-settings):
(.panel.elements .sidebar-pane-toolbar > select.select-filter):
(.panel.elements .sidebar-pane-toolbar > select > option, .panel.elements .sidebar-pane-toolbar > select > hr):
- inspector/front-end/inspector.css:
(.event-bar .event-properties):
- inspector/front-end/scriptsPanel.css:
(.workers-list > li):
(a.worker-item):
(a.worker-item:hover):
- inspector/front-end/sidebarPane.css: Added.
(.sidebar-pane):
(.sidebar-pane > .body):
(.sidebar-pane > .body .info):
(.sidebar-pane > .body .placard + .info):
(.sidebar-pane.visible > .body):
(.sidebar-pane .section .properties):
(.sidebar-tabbed-pane .tabbed-pane-header):
(.sidebar-pane-stack > .sidebar-pane.visible:nth-last-of-type(1)):
(.sidebar-pane-title):
(.sidebar-pane-title + .sidebar-pane-title, .pane:not(.visible) + .sidebar-pane-title, .sidebar-pane-title:first-of-type):
(.sidebar-pane-title:active):
(.sidebar-pane-title::before):
(.sidebar-pane-title.expanded::before):
(.sidebar-pane-toolbar):
(.sidebar-pane-toolbar > *):
(.sidebar-pane-toolbar > .pane-title-button):
(.sidebar-pane-toolbar > .pane-title-button:hover):
(.sidebar-pane-toolbar > .pane-title-button:active, .sidebar-pane-toolbar > .pane-title-button.toggled):
(.sidebar-pane-toolbar > .pane-title-button.add):
(.sidebar-pane-toolbar > .pane-title-button.element-state):
(.sidebar-pane-toolbar > .pane-title-button.refresh):
(.sidebar-pane-subtitle):
(body.platform-windows .sidebar-pane-subtitle):
(.sidebar-pane-subtitle input, .section .header input[type=checkbox]):
- 7:20 AM Changeset in webkit [144926] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: test that "importScript" is used only in module heads.
https://bugs.webkit.org/show_bug.cgi?id=111548
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-06
Reviewed by Pavel Feldman.
Test that output file after all inlines does not have any 'importScript(s)' statements.
- scripts/inline_js_imports.py:
(main):
- 7:20 AM Changeset in webkit [144925] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Combine style-related panes into a single tab when Elements panel is split horizontally.
https://bugs.webkit.org/show_bug.cgi?id=111550
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-06
Reviewed by Pavel Feldman.
Grouping the Elements sidebar panes into two tabbed panes proved to be
confusing and inconvenient. Put all the Elements sidebar panes into a single tabbed pane.
Combined Styles, Computed Style and Metrics into a single pane.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._splitVertically):
(WebInspector.ElementsPanel.prototype.addExtensionSidebarPane):
- inspector/front-end/elementsPanel.css:
(.sidebar-pane.composite):
(.sidebar-pane.composite > .body):
(.sidebar-pane.composite .metrics):
(.sidebar-pane.composite .sidebar-pane-toolbar):
(.sidebar-pane.composite .sidebar-pane-toolbar > .sidebar-pane-subtitle):
(.sidebar-pane.composite .styles-section.read-only):
- 7:18 AM Changeset in webkit [144924] by
-
- 13 edits2 adds in trunk
Web Inspector: support stable remote object ids
https://bugs.webkit.org/show_bug.cgi?id=109908
Reviewed by Pavel Feldman.
Source/WebCore:
Introduced a map from javascript object to its id. It guarantees
that object is assined id only once (unless it is explicitely
released). The map is per execution context and is stored in
InjectedScriptManager.
Test: inspector-protocol/persistent-id.html
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::objectId):
(WebCore):
(WebCore::JSInjectedScriptHost::releaseObjectId):
- bindings/js/ScriptObject.h:
(WTF):
(WTF::ScriptObjectHash::hash):
(WTF::ScriptObjectHash::equal):
(ScriptObjectHash):
- bindings/v8/ScriptObject.h:
(WTF):
(WTF::ScriptObjectHash::hash):
(WTF::ScriptObjectHash::equal):
(ScriptObjectHash):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::objectIdMethodCustom):
(WebCore):
(WebCore::V8InjectedScriptHost::releaseObjectIdMethodCustom):
- inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::create):
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):
(WebCore::InjectedScriptHost::objectId):
(WebCore):
(WebCore::InjectedScriptHost::releaseObjectId):
- inspector/InjectedScriptHost.h:
(WebCore):
(InjectedScriptHost):
- inspector/InjectedScriptHost.idl:
- inspector/InjectedScriptManager.cpp:
(InjectedScriptManager::ObjectIdMap):
(WebCore::InjectedScriptManager::ObjectIdMap::ObjectIdMap):
(WebCore::InjectedScriptManager::ObjectIdMap::objectId):
(WebCore::InjectedScriptManager::ObjectIdMap::releaseObjectId):
(WebCore):
(WebCore::InjectedScriptManager::InjectedScriptManager):
(WebCore::InjectedScriptManager::discardInjectedScripts):
(WebCore::InjectedScriptManager::discardInjectedScriptsFor):
(WebCore::InjectedScriptManager::objectId):
(WebCore::InjectedScriptManager::releaseObjectId):
- inspector/InjectedScriptManager.h:
(InjectedScriptManager):
- inspector/InjectedScriptSource.js:
(.):
LayoutTests:
Test that same object will have same id if requested several times.
- inspector-protocol/persistent-id-expected.txt: Added.
- inspector-protocol/persistent-id.html: Added.
- inspector/console/command-line-api-expected.txt:
- 7:09 AM Changeset in webkit [144923] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use CachedResource::resourceBuffer() instead of CachedResource::data()
https://bugs.webkit.org/show_bug.cgi?id=111555
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-06
Reviewed by Rob Buis.
CachedResource::data() was renamed to
CachedResource::resourceBuffer() in r130947.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
- 7:07 AM Changeset in webkit [144922] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove some unneeded header includes
https://bugs.webkit.org/show_bug.cgi?id=111545
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-06
Reviewed by Rob Buis.
- WebCoreSupport/CredentialTransformData.cpp:
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- 7:05 AM Changeset in webkit [144921] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use hasTagName instead of hasLocalName in CredentialTransformData
https://bugs.webkit.org/show_bug.cgi?id=111544
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-06
Reviewed by Rob Buis.
hasLocalName() expects an AtomicString, but we are passing a
HTMLName which is a QualifiedName.
- WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::findPasswordFormFields): Use
hasTagName() instead of hasLocalName().
- 6:47 AM Changeset in webkit [144920] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
https://bugs.webkit.org/show_bug.cgi?id=111571
Gardening; added accessibility failure tests.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-06
- platform/efl-wk2/TestExpectations:
- 6:30 AM Changeset in webkit [144919] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r144617): Wrong usage of overwritten variable in toDOMWindow (V8Binding.cpp)
https://bugs.webkit.org/show_bug.cgi?id=111565
Patch by Marja Hölttä <marja@chromium.org> on 2013-03-06
Reviewed by Jochen Eisinger.
In toDOMWindow, the variable "global" was first nuked, and then used again. This
change was introduced in r144617.
No new tests (no functional changes).
- bindings/v8/V8Binding.cpp:
(WebCore::toDOMWindow):
- 6:29 AM Changeset in webkit [144918] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Illegal narrowing in tst_qwebhistory
https://bugs.webkit.org/show_bug.cgi?id=111562
Reviewed by Jocelyn Turcotte.
The bytearray in tst_QWebHistory::restoreIncompatibleVersion1 has integer
values higher than 127 assigned into an array of signed chars. This causes
compiler errors in C++11 since it assigns constants (>127) that does not
fit the destination (-128 to 127)
- tests/qwebhistory/tst_qwebhistory.cpp:
(tst_QWebHistory::restoreIncompatibleVersion1):
- 6:16 AM Changeset in webkit [144917] by
-
- 2 edits in trunk/Source/WTF
Typo in inline function in ByteOrder.h
https://bugs.webkit.org/show_bug.cgi?id=111473
Patch by Paweł Forysiuk <tuxator@o2.pl> on 2013-03-06
Reviewed by Benjamin Poulain.
- wtf/ByteOrder.h:
(ntohs):
- 6:07 AM Changeset in webkit [144916] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: use regular eval instead of injectScript for front-end extension API
https://bugs.webkit.org/show_bug.cgi?id=111529
Reviewed by Pavel Feldman.
Removed InjectedScriptManager::injectScript and replaced all of it calls
except the actual script injection with ScriptController::executeScript.
- inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::injectedScriptFor):
- inspector/InjectedScriptManager.h:
(InjectedScriptManager):
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._emulateTouchEventsChanged.get if):
- inspector/front-end/ExtensionAPI.js:
(buildExtensionAPIInjectedScript):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onReload):
- 6:06 AM Changeset in webkit [144915] by
-
- 2 edits in trunk/Tools
[Qt][MiniBrowser] Touch mocking broken for chained getures
https://bugs.webkit.org/show_bug.cgi?id=111430
Reviewed by Jocelyn Turcotte.
Make it possible again to use touch mocking to test gesture chains
like pan->pinch->pan->pinch without lifting the primary "finger".
For this to work we need to track the pressed mouse buttons and
only synthesize touch release events when the ctrl key is released
if no mouse button is pressed. Else the pressed mouse button(s)
should result in a stationary touch point in a touch update event.
Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
to check for the state of the ctrl key modifier instead of getting
it from the mouse events.
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):
- 6:02 AM Changeset in webkit [144914] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Fix the Mac build after r144787
https://bugs.webkit.org/show_bug.cgi?id=111569
Reviewed by Csaba Osztrogonác.
Use uint_64 explicitly instead of size_t.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
- 6:02 AM Changeset in webkit [144913] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Do not disable C++0x
https://bugs.webkit.org/show_bug.cgi?id=111559
Reviewed by Kenneth Rohde Christiansen.
- WebCore.pri:
- 5:31 AM Changeset in webkit [144912] by
-
- 6 edits in trunk/Source/WebCore
Remove the (dead) code for handling shorthands in StyleResolver / StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=111505
Reviewed by Alexis Menard.
The CSS parsing code expands shorthands (with the exception of 'font') to their longhands.
This means that all the code in StyleResolver / StyleBuilder to handle shorthands is basically
dead and shouldn't be there. The reason for it to be is that people didn't know about shorthands
expansion and thus copied existing code.
This change addresses both issues by removing the code and adding ASSERTs that should prevent people
from adding more dead code.
Refactoring, covered by existing tests.
- css/StylePropertyShorthand.h: Added isExpandedShorthand.
- css/StylePropertyShorthand.cpp:
(WebCore::isExpandedShorthand):
Added this function that ignores 'font' as it is the only shorthand that is no consistently expanded
to account for system fonts.
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
Removed the shorthands.
- css/StyleBuilder.h:
(WebCore::StyleBuilder::setPropertyHandler):
Added ASSERTs that people don't add shorthand handling.
- css/StyleResolver.cpp:
(WebCore::isValidVisitedLinkProperty):
Removed all the shorthands (shouldn't be reachable unless the ASSERT in applyProperty
triggers).
(WebCore::StyleResolver::applyProperty):
Removed all shorthand handling code, moved the shorthands together and added some ASSERT
to ensure people don't abuse the code and re-add some of it back by mistake.
- 5:00 AM Changeset in webkit [144911] by
-
- 48 edits2 moves in trunk/Source
Rename WebCore/editing/visible_units.* to VisibleUnits.*
https://bugs.webkit.org/show_bug.cgi?id=111426
Reviewed by Alexey Proskuryakov.
Source/WebCore:
No new tests. Just a refactoring.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityNodeObject.cpp:
- accessibility/AccessibilityObject.cpp:
- accessibility/AccessibilityRenderObject.cpp:
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
- dom/Position.cpp:
- dom/Range.cpp:
- editing/AlternativeTextController.cpp:
- editing/ApplyBlockElementCommand.cpp:
- editing/ApplyStyleCommand.cpp:
- editing/CompositeEditCommand.cpp:
- editing/DeleteSelectionCommand.cpp:
- editing/EditingAllInOne.cpp:
- editing/EditingStyle.cpp:
- editing/Editor.cpp:
- editing/FormatBlockCommand.cpp:
- editing/FrameSelection.cpp:
- editing/IndentOutdentCommand.cpp:
- editing/InsertLineBreakCommand.cpp:
- editing/InsertListCommand.cpp:
- editing/InsertParagraphSeparatorCommand.cpp:
- editing/InsertTextCommand.cpp:
- editing/ReplaceSelectionCommand.cpp:
- editing/SurroundingText.cpp:
- editing/TextCheckingHelper.cpp:
- editing/TextIterator.cpp:
- editing/TypingCommand.cpp:
- editing/VisiblePosition.cpp:
- editing/VisibleSelection.cpp:
- editing/VisibleUnits.cpp: Copied from Source/WebCore/editing/visible_units.cpp.
- editing/VisibleUnits.h: Copied from Source/WebCore/editing/visible_units.h.
- editing/htmlediting.cpp:
- editing/markup.cpp:
- editing/visible_units.cpp: Removed.
- editing/visible_units.h: Removed.
- page/Frame.cpp:
- page/mac/FrameMac.mm:
- platform/win/EditorWin.cpp:
Source/WebKit/mac:
- WebView/WebFrame.mm:
Source/WebKit2:
- WebProcess/WebPage/mac/WebPageMac.mm:
- 4:52 AM Changeset in webkit [144910] by
-
- 14 edits1 add in trunk/Source/JavaScriptCore
Unused Structure property tables waste 14MB on Membuster.
<http://webkit.org/b/110854>
<rdar://problem/13292104>
Reviewed by Geoffrey Garen.
Turn PropertyTable into a GC object and have Structure drop unpinned tables when marking.
14 MB progression on Membuster3.
This time it should stick; I've been through all the tests with COLLECT_ON_EVERY_ALLOCATION.
The issue with the last version was that Structure::m_offset could be used uninitialized
when re-materializing a previously GC'd property table, causing some sanity checks to fail.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
Added PropertyTable.cpp.
- runtime/PropertyTable.cpp: Added.
(JSC::PropertyTable::create):
(JSC::PropertyTable::clone):
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::destroy):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::visitChildren):
Moved marking of property table values here from Structure::visitChildren().
- runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::get):
Move m_cell to a local before using it multiple times. This avoids a multiple-access race when
Structure::checkOffsetConsistency() is used in assertions on the main thread while a marking thread
zaps the property table.
- runtime/Structure.h:
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
- runtime/StructureInlines.h:
(JSC::Structure::propertyTable):
Added a getter for the Structure's PropertyTable that ASSERTs GC currently isn't active.
Because GC can zap an unpinned property table at any time, it's not entirely safe to access it.
Renamed the variable itself to m_propertyTableUnsafe to force call sites into explaining themselves.
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::checkOffsetConsistency):
Moved these out of Structure.h to break header dependency cycle between Structure/PropertyTable.
- runtime/Structure.cpp:
(JSC::Structure::visitChildren):
Null out m_propertyTable if the table is unpinned. This'll cause the table to get GC'd.
(JSC::Structure::takePropertyTableOrCloneIfPinned):
Added for setting up the property table in a new transition, this code is now shared between
addPropertyTransition() and nonPropertyTransition().
- runtime/JSGlobalData.h:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
Add a global propertyTableStructure.
- runtime/PropertyMapHashTable.h:
(PropertyTable):
(JSC::PropertyTable::createStructure):
(JSC::PropertyTable::copy):
Make PropertyTable a GC object.
- runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::pin):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNamesFromStructure):
(JSC::Structure::checkConsistency):
- 4:41 AM Changeset in webkit [144909] by
-
- 2 edits in trunk/Source/WebKit2
DataReference::vector() should be const.
https://bugs.webkit.org/show_bug.cgi?id=109928
Reviewed by Anders Carlsson.
- Platform/CoreIPC/DataReference.h:
(CoreIPC::DataReference::vector):
- 4:14 AM Changeset in webkit [144908] by
-
- 4 edits in trunk
Do not add CSSPropertyBorderImage shorthand part of the property list when parsing CSS border property
https://bugs.webkit.org/show_bug.cgi?id=111481
Reviewed by Julien Chaffraix.
Source/WebCore:
After http://trac.webkit.org/changeset/135848 and more generally we do not
add shorthand directly into the property list used afterwards to build
StylePropertySet but we rather expand the shorthand to add the
longhands. CSSPropertyBorderImage is a shorthand and it should follow
that rule, so when we successfully parsed CSS border property and we
should reset border-image then we should reset the longhands too.
Test: LayoutTests/inspector/styles/styles-new-API-expected.txt which
reflects the fact that we add longhands instead of the shorthand. All
the other tests should not regress.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
LayoutTests:
As now border-image is expanded when we sucessfully parsed a CSS border,
this test needs to be updated to reflect that the longhands are now
part of the declarated style.
- inspector/styles/styles-new-API-expected.txt:
- 4:14 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:07 AM Changeset in webkit [144907] by
-
- 22 edits3 copies1 add in trunk/Source
Accelerated overflow scrolling for Coordinated Graphics.
https://bugs.webkit.org/show_bug.cgi?id=110323
Source/WebCore:
Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2013-03-06
Reviewed by Noam Rosenthal.
A scroll offset is applied to individual layers on UI process and the
web process is notified assynchronously.
The new API WKCoordinatedScene may be used to scroll layers in the UI process.
Tests will be added on bug #111140.
Scrolling coordinator is used to provide a ScrollableArea to CoordinatedGraphicsLayer.
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
(WebCore::ScrollingCoordinatorCoordinatedGraphics::scrollableAreaScrollLayerDidChange):
(WebCore):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::willDestroyScrollableArea):
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
(ScrollingCoordinatorCoordinatedGraphics):
GraphicsLayerTextureMapper is responsible for receiving the 'did commit' messages and to pass
them to its TextureMapperLayer on the appropriated time.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::didCommitScrollOffset):
(WebCore):
(WebCore::GraphicsLayerTextureMapper::setIsScrollable):
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore::GraphicsLayerTextureMapper::setScrollClient):
(WebCore::GraphicsLayerTextureMapper::setID):
(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::isScrollable):
TextureMapperLayer is responsible for applying the requested scroll offset and for
sending the commit messages to web process. It is also able to hittest layers and identify
the ones that are scrollable.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::hitTest):
(WebCore):
(WebCore::TextureMapperLayer::scrollableLayerHitTestCondition):
(WebCore::TextureMapperLayer::findScrollableContentsLayerAt):
(WebCore::TextureMapperLayer::mapScrollOffset):
(WebCore::TextureMapperLayer::commitScrollOffset):
(WebCore::TextureMapperLayer::scrollBy):
(WebCore::TextureMapperLayer::didCommitScrollOffset):
- platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
(ScrollingClient):
(WebCore::TextureMapperLayer::TextureMapperLayer):
(WebCore::TextureMapperLayer::setID):
(WebCore::TextureMapperLayer::id):
(WebCore::TextureMapperLayer::setScrollClient):
(WebCore::TextureMapperLayer::setIsScrollable):
(WebCore::TextureMapperLayer::isScrollable):
(WebCore::TextureMapperLayer::adjustedPosition):
CoordinatedGraphicsLayer receives the commit messages and updates its ScrollableArea.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setScrollableArea):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::commitScrollOffset):
(WebCore::CoordinatedGraphicsLayer::resetLayerState):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(WebCore):
(CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::isScrollable):
CoordinatedGraphicsScene receives the commit messages from TextureMapperLayer and
dispatches them on the main thread. It also has a new method that is used to find
the topmost scrollable layer at a given point.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerState):
(WebCore::CoordinatedGraphicsScene::createLayer):
(WebCore::CoordinatedGraphicsScene::dispatchCommitScrollOffset):
(WebCore):
(WebCore::CoordinatedGraphicsScene::commitScrollOffset):
(WebCore::CoordinatedGraphicsScene::findScrollableContentsLayerAt):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
(WebCore):
(CoordinatedGraphicsSceneClient):
(CoordinatedGraphicsScene):
New fields have been added to CoordinatedGraphicsLayerState.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(CoordinatedGraphicsLayerState):
Source/WebKit2:
Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2013-03-06
Reviewed by Noam Rosenthal.
Signed off for WebKit2 by Simon Fraser.
A scroll offset is applied to individual layers on UI process and the
web process is notified assynchronously.
The new API WKCoordinatedScene may be used to scroll layers in the UI process.
- CMakeLists.txt:
Encoding and decoding the new members of CoordinatedGraphicsLayerState.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
Adding acceleratedCompositingForOverflowScrollEnabled to WebPreferencesStore.
- Shared/WebPreferencesStore.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
New API WKCoordinatedScene is used to scroll layers on UI side.
- UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:
- UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.h:
- UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h:
A new message is used to send scroll commit messages to web process.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::commitScrollOffset):
(WebKit):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::~CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::detachLayer):
(WebKit::CoordinatedLayerTreeHost::createGraphicsLayer):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHost::commitScrollOffset):
(WebKit):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.messages.in:
- 3:59 AM Changeset in webkit [144906] by
-
- 5 edits2 adds in trunk/LayoutTests
[EFL] Unreviewed gardening
Added new baselines after r144837 and marked as failures
some pasteboard tests that we don't support yet.
- platform/efl/TestExpectations:
- platform/efl/fast/invalid/017-expected.txt:
- platform/efl/fast/invalid/018-expected.txt:
- platform/efl/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/efl/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
- 3:22 AM Changeset in webkit [144905] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip authentication test that is now passing on EFL port.
- platform/efl/TestExpectations:
- 2:51 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 2:48 AM Changeset in webkit [144904] by
-
- 4 edits3 adds in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding a failure expectation for a test added in r144877.
- platform/gtk/fast/invalid/017-expected.txt: Rebaselining after r144837.
- platform/gtk/fast/invalid/018-expected.txt: Ditto.
- platform/gtk/tables/mozilla/bugs/bug113235-2-expected.txt: Added. Ditto.
- platform/gtk/tables/mozilla/bugs/bug9024-expected.txt: Added. Ditto.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added. Ditto.
- 2:48 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:47 AM Changeset in webkit [144903] by
-
- 3 edits4 adds in releases/WebKitGTK/webkit-2.0
Merge r144706 - REGRESSION (r143643): Buttons containing floats render differently
https://bugs.webkit.org/show_bug.cgi?id=110933
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-04
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/forms/button-with-float.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
Also include new flexbox as a renderer that needs to enclose
overhanging floats. Flex boxes establish a block formatting context,
so they need to contain floats:
http://dev.w3.org/csswg/css3-flexbox/#flex-items
LayoutTests:
- css3/flexbox/float-inside-flexitem-expected.html: Added.
- css3/flexbox/float-inside-flexitem.html: Added.
- fast/forms/button-with-float-expected.html: Added.
- fast/forms/button-with-float.html: Added.
- 2:38 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:36 AM Changeset in webkit [144902] by
-
- 6 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK] When the WebProcess crashes, a signal should be emitted
https://bugs.webkit.org/show_bug.cgi?id=105180
Patch by Xan Lopez <Xan Lopez> on 2013-03-06
Reviewed by Carlos Garcia Campos.
Emit a "web-process-crashed" signal when the WebProcess crashes. This
is useful, for example, to show an error page in a web browser
like Chrome does.
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
(processDidCrash):
(attachLoaderClientToView):
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextWebProcessCrashed):
- UIProcess/API/gtk/WebKitWebContextPrivate.h:
- UIProcess/API/gtk/tests/TestWebExtensions.cpp:
(testWebExtensionGetTitle):
(webProcessCrashedCallback):
(testWebExtensionAbortProcess):
(beforeAll):
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(methodCallCallback):
- 2:16 AM WebKitGTK/2.0.x edited by
- Move patch that already landed to proposed merges (diff)
- 1:59 AM Changeset in webkit [144901] by
-
- 4 edits4 moves1 add in trunk
REGGRESSION (r142112): It made compositing tests fail on EFL, Qt.
https://bugs.webkit.org/show_bug.cgi?id=109291
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Report we support fixed layers.
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
(WebCore::ScrollingCoordinatorCoordinatedGraphics::supportsFixedPositionLayers):
(ScrollingCoordinatorCoordinatedGraphics):
LayoutTests:
Unskip now passing test, and move baselines specific to having no scrolling-coordinator to WK1.
- platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png.
- platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt.
- platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png.
- platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt.
- platform/qt-5.0-wk2/TestExpectations:
- 1:54 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:53 AM Changeset in webkit [144900] by
-
- 14 edits4 adds in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK] Add WebKitWebViewGroup to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=111265
Reviewed by Martin Robinson.
In the current API the settings are always shared by all web
views, because they are always created on the default page
group. This makes impossible to have different settings on
different web views. Expose the page group in the API,
so that users can create web views on a group different than the
default one to have their own settings.
- GNUmakefile.list.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitSettings.cpp:
(webkitSettingsGetPreferences): Helper private method to get the
WebPreferences wrapped by a WebKitSettings object.
- UIProcess/API/gtk/WebKitSettingsPrivate.h:
- UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate): Add a default WebKitWebViewGroup.
(webkitWebContextCreatePageForWebView): Create the WebPageProxy
with the WebPageGroup of the given WebKitWebViewGroup.
(webkitWebContextGetDefaultWebViewGroup): Helper private method to
get the default WebKitWebViewGroup.
- UIProcess/API/gtk/WebKitWebContextPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(_WebKitWebViewPrivate): Add a WebKitWebViewGroup in case the view
is created with a group.
(webkitWebViewUpdateSettings): Keep a reference of the group
settings to be able to disconnect the signals when the settings
object is replaced in the view group and connect to the signals
for the custom settings.
(webkitWebViewSettingsChanged): Disconnect the signals for the
previous settings and set the new settings.
(webkitWebViewDisconnectSettingsChangedSignalHandler): Disconnect
notify::settings signal of WebKitWebViewGroup.
(webkitWebViewConstructed): Pass the current WebKitWebViewGroup to
webkitWebContextCreatePageForWebView().
(webkitWebViewSetProperty): Add setter for group property.
(webkitWebViewGetProperty): Add getter for group property.
(webkitWebViewDispose): Call
webkitWebViewDisconnectSettingsChangedSignalHandler().
(webkit_web_view_class_init): Add WebKitWebView:group property.
(webkitWebViewHandleAuthenticationChallenge): Use
webkit_web_view_get_settings().
(webkit_web_view_new_with_group): Create a new web view with the
given WebKitWebViewGroup.
(webkit_web_view_get_group): Return the current WebKitWebViewGroup
or the default one if the view was not created with
webkit_web_view_new_with_group().
(webkit_web_view_set_settings): Set the settings of the current
WebKitWebViewGroup.
(webkit_web_view_get_settings): Get the settings of the current
WebKitWebViewGroup.
(webkit_web_view_set_zoom_level): Use
webkit_web_view_get_settings().
(webkit_web_view_get_zoom_level): Ditto.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebViewGroup.cpp: Added.
(_WebKitWebViewGroupPrivate):
(webkitWebViewGroupSetProperty):
(webkitWebViewGroupGetProperty):
(webkitWebViewGroupConstructed):
(webkit_web_view_group_class_init):
(webkitWebViewGroupAttachSettingsToPageGroup): Set the
WebPreferences of the current WebKitSettings to the WebPageGroup.
(webkitWebViewGroupCreate): Create a new WebKitWebViewGroup for
the given WebPageGroup.
(webkitWebViewGroupGetPageGroup): Helper private method to get the
WebPageGroup wrapped by the WebKitWebViewGroup.
(webkit_web_view_group_new): Create a new WebKitWebViewGroup.
(webkit_web_view_group_get_name): Return the name of a
WebKitWebViewGroup.
(webkit_web_view_group_get_settings): Get the settins of a
WebKitWebViewGroup.
(webkit_web_view_group_set_settings): Set new settings of a
WebKitWebViewGroup.
- UIProcess/API/gtk/WebKitWebViewGroup.h: Added.
(_WebKitWebViewGroup):
(_WebKitWebViewGroupClass):
- UIProcess/API/gtk/WebKitWebViewGroupPrivate.h: Added.
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add
WebKitWebViewGroup section.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
- UIProcess/API/gtk/docs/webkit2gtk.types: Add
webkit_web_view_group_get_type.
- UIProcess/API/gtk/tests/GNUmakefile.am: Add new files to
compilation.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewSettings): We can't watch settings in the default view
group anymore, because they are not released with the web view but
with the web context that is freed after the Test destructor.
- UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp: Added.
(testWebViewGroupDefault):
(testWebViewGroupNewGroup):
(testWebViewNewWithGroup):
(testWebViewGroupSettings):
(beforeAll):
(afterAll):
- UIProcess/API/gtk/webkit2.h: Include WebKitWebViewGroup.h.
- 1:35 AM Changeset in webkit [144899] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Convert from device view size to UI view size only in EwkView.
https://bugs.webkit.org/show_bug.cgi?id=110197
Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-06
Reviewed by Kenneth Rohde Christiansen.
Signed off for WebKit2 by Benjamin Poulain.
Device scale factor is a property of the physical display, so only EwkView
should deal with converting device view size to UI (a.k.a Density Independent Pixel)
view size. It increases readability because we can regard a view size in
other classes (e.g. WebView, PageViewportController, WebPage) except for
EwkView as UI size.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::setDeviceScaleFactor):
(EwkView::setDeviceSize):
(EwkView::size):
(EwkView::deviceSize):
(EwkView::scheduleUpdateDisplay):
(EwkView::createGLSurface):
(EwkView::handleEvasObjectCalculate):
- UIProcess/API/efl/EwkView.h:
(EwkView):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::paintToCurrentGLContext):
(WebKit::WebView::updateViewportSize):
- 1:27 AM Changeset in webkit [144898] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Use Vector::reserveInitialCapacity() in WebEventFactory::createWebTouchEvent()
https://bugs.webkit.org/show_bug.cgi?id=111530
Reviewed by Benjamin Poulain.
In WebEventFactory::createWebTouchEvent(), when constructing the vector of touch points,
we already know in advance the total number of touch points. Therefore, we should
leverage WTF::Vector::reserveInitialCapacity() and WTF::Vector::uncheckedAppend() to save
some capacity checks.
- Shared/efl/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebTouchEvent):
- 1:23 AM Changeset in webkit [144897] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: Delete http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html
- 1:16 AM Changeset in webkit [144896] by
-
- 6 edits3 deletes in trunk
Unreviewed, rolling out r144859.
http://trac.webkit.org/changeset/144859
https://bugs.webkit.org/show_bug.cgi?id=111519
Introduced a test that calls non-exist function on non-
Chromium ports and crash on Chromium (Requested by rniwa on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-06
Source/WebCore:
- html/HTMLAudioElement.h:
(WebCore::HTMLAudioElement::hasPendingActivity):
(HTMLAudioElement):
- html/HTMLAudioElement.idl:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::hasPendingActivity):
- html/HTMLMediaElement.idl:
LayoutTests:
- http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal-expected.txt: Removed.
- http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html: Removed.
- http/tests/misc/resources/delete-frame-during-readystatechange-frame-with-gc-after-video-removal.html: Removed.
- 12:59 AM Changeset in webkit [144895] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Could not open Profiles panel.
https://bugs.webkit.org/show_bug.cgi?id=111535
Reviewed by Alexander Pavlov.
- inspector/front-end/CPUProfileView.js:
- inspector/front-end/ProfilesPanel.js:
- 12:29 AM Changeset in webkit [144894] by
-
- 3 edits3 adds in trunk
Crash during middle mouse click when page is removed
https://bugs.webkit.org/show_bug.cgi?id=111489
Reviewed by Hajime Morrita.
Source/WebCore:
Check for a null page that can happen if we remove the document from the DOM.
The other methods in EventHandler also check for a null page.
Test: editing/pasteboard/selection-paste-crash.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handlePasteGlobalSelection):
LayoutTests:
- editing/pasteboard/resources/selection-paste-crash.html: Added.
- editing/pasteboard/selection-paste-crash-expected.txt: Added.
- editing/pasteboard/selection-paste-crash.html: Added.
- 12:12 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:11 AM Changeset in webkit [144893] by
-
- 10 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK] Add WebKitWebPage::send-request signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=83681
Reviewed by Martin Robinson.
Add WebKitWebPage::send-request signal emitted in willSendRequest
callback to allow web process extensions to modify requests before
they are sent or cancel the resource load.
- UIProcess/API/gtk/WebKitURIRequest.cpp:
(webkitURIRequestSetProperty): Use webkit_uri_request_set_uri() to
set the new URI.
(webkit_uri_request_class_init): Make URI property construct
instead of construct-only, since it can be updated once
constructed. It should never be NULL, so set default value to
about:blank instad of NULL.
(webkit_uri_request_set_uri): New public method to set the URI of
the WebKitURIRequest.
- UIProcess/API/gtk/WebKitURIRequest.h: Allow to include this file
from webkit-web-extension.h.
- UIProcess/API/gtk/WebKitURIResponse.h: Ditto.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add
webkit_uri_request_set_uri.
- UIProcess/API/gtk/tests/TestResources.cpp:
(testWebResourceSendRequest):
(serverCallback):
(beforeAll):
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(sendRequestCallback):
(pageCreatedCallback):
- UIProcess/API/gtk/webkit2marshal.list:
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(willSendRequestForFrame): Emit WebKitWebPage::send-request and
return early if the load is cancelled.
(webkit_web_page_class_init): Add WebKitWebPage::send-request signal.
- WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:
- 12:04 AM Changeset in webkit [144892] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL] Enable asynchronous spell checking by default
https://bugs.webkit.org/show_bug.cgi?id=111295
Reviewed by Benjamin Poulain.
Asynchronous spell checking feature is disabled by default for wk2 platforms.
It means all requests of spell checking are sent synchronously.
WebKit-EFL implements requestCheckingOfString method which allows
to check spelling asynchronously.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
Mar 5, 2013:
- 11:59 PM Changeset in webkit [144891] by
-
- 21 edits in trunk/Source/WebCore
Replace shouldLazyAttach bool with an enum for readability
https://bugs.webkit.org/show_bug.cgi?id=111503
Reviewed by Dimitri Glazkov.
No behavioral change.
- bindings/cpp/WebDOMNodeCustom.cpp:
(WebDOMNode::insertBefore):
(WebDOMNode::replaceChild):
(WebDOMNode::appendChild):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::insertBefore):
(WebCore::JSNode::replaceChild):
(WebCore::JSNode::appendChild):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore):
(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):
- dom/ContainerNode.cpp:
(WebCore):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
(WebCore::updateTreeAfterInsertion):
- dom/ContainerNode.h:
(ContainerNode):
- dom/Node.cpp:
(WebCore::Node::insertBefore):
(WebCore::Node::replaceChild):
(WebCore::Node::appendChild):
- dom/Node.h:
(Node):
- editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::doApply):
- editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply):
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::createControls):
- html/shadow/MediaControlsBlackBerry.cpp:
(WebCore::MediaControlsBlackBerry::createControls):
- html/shadow/MediaControlsChromium.cpp:
(WebCore::MediaControlsChromium::initializeControls):
- html/shadow/MediaControlsChromiumAndroid.cpp:
(WebCore::MediaControlsChromiumAndroid::createControls):
- 11:57 PM WebKitGTK/2.0.x edited by
- (diff)
- 11:54 PM Changeset in webkit [144890] by
-
- 6 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK][WK2] Add WebKitWebPage::webkit_web_page_get_uri to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=111288
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-05
Reviewed by Carlos Garcia Campos.
Add new property URI to WebKitWebPage providing a method
webkit_web_page_get_uri to get it and the signal "notify::uri" to
monitor changes in the URI.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Include new method in
GTK+ doc.
- UIProcess/API/gtk/tests/TestLoaderClient.cpp:
(testWebPageURI):
(beforeAll):
(afterAll): Add test to check that WebKitWebPage URI matches with
WebKitWebView value. The tests is listening for changes in WebKitWebPage
URI via D-Bus and checks that value is the same than WebKitWebView URI.
It also checks that the order of the URIs in a redirection is right.
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(uriChangedCallback):
(pageCreatedCallback): Add new D-Bus signal "URIChanged" connected to
"notify::uri" signal of WebKitWebPage.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(_WebKitWebPagePrivate): Add new URI attribute.
(webkitWebPageSetURI): Method to set the URI and emit the "notify:uri"
signal if it has changed.
(didStartProvisionalLoadForFrame): At this point it use the unreachable
URL from provisional document loader if any. Otherwise, it uses the URL
from provisional document loader.
(didReceiveServerRedirectForProvisionalLoadForFrame): In the case of
redirections it works like for didStartProvisionalLoadForFrame getting
the unreachable URL if any.
(didSameDocumentNavigationForFrame): In this case it gets the URL from
the document loader.
(webkitWebPageGetProperty): Add code related to URI property.
(webkit_web_page_class_init): Add bits related to URI property.
(webkitWebPageCreate): Implement callbacks to monitor URI changes.
(webkit_web_page_get_uri): Return URI attribute.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h: Add new method
header.
- 11:53 PM Changeset in webkit [144889] by
-
- 5 edits in trunk/Source/WebCore
Custom Elements: CustomElementConstructor::m_name doesn't have any good use.
https://bugs.webkit.org/show_bug.cgi?id=111523
Reviewed by Kentaro Hara.
This change removes CustomElementConstructor::m_name and renames
m_tagName to m_name. Now generated function name is same as interface name.
Originally, m_name was added to specify the generated constructor
name. An early version of custom element allows to give the name,
but it no longer says anything about that.
The rename is to align the semantics of type extension mechanism
of Custom Elements, where the name of a custom element isn't
necessarily a tag name.
No new tests. Just removing old code.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- dom/CustomElementConstructor.cpp:
(WebCore::CustomElementConstructor::create):
(WebCore::CustomElementConstructor::CustomElementConstructor):
(WebCore::CustomElementConstructor::createElement):
- dom/CustomElementConstructor.h:
(CustomElementConstructor):
(WebCore::CustomElementConstructor::name):
- dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::registerElement):
- 11:43 PM Changeset in webkit [144888] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Flame Chart. Provide node context info in a popover when mouse hovers over a flame chart item.
https://bugs.webkit.org/show_bug.cgi?id=111442
Reviewed by Yury Semikhatsky.
FlameChart is a canvas so it is not possible to attach the popover to the items on it.
It would be a bit tricky to support an offset due to complex behaviour of the popover.
The simplest solution is to create a fake anchor element and move it to the right position.
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._getPopoverAnchor):
(WebInspector.FlameChart.prototype._showPopover):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype.findNodeCallback):
(WebInspector.FlameChart.prototype._coordinatesToNode):
(WebInspector.FlameChart.prototype.onResize):
- inspector/front-end/flameChart.css:
(.flame-chart .item-anchor):
- 11:37 PM Changeset in webkit [144887] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Ensure right format is used in SnapshotImageGL.
https://bugs.webkit.org/show_bug.cgi?id=111333
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-05
Reviewed by Benjamin Poulain.
GL_BGRA format is not standard for glReadPixels with GLES.
This patch ensures that GL_RGBA is used in SnapshotImageGL
while using GLES.
- UIProcess/API/efl/SnapshotImageGL.cpp:
(getImageSurfaceFromFrameBuffer):
- 11:32 PM Changeset in webkit [144886] by
-
- 3 edits in trunk/Source/JavaScriptCore
Get rid of the invert argument to SpeculativeJIT::jumpSlowForUnwantedArrayMode
https://bugs.webkit.org/show_bug.cgi?id=105624
Reviewed by Oliver Hunt.
All callers pass invert = false, which is the default value of the argument. So, get
rid of the argument and fold away all code that checks it.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- 10:59 PM Changeset in webkit [144885] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed buildfix after r144787. Add missing USE(GRAPHICS_SURFACE) guards.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerState):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):
- 10:54 PM Changeset in webkit [144884] by
-
- 2 edits in trunk/Source/WebCore
Autoreleased cached pages slow down the PLT by 2%
https://bugs.webkit.org/show_bug.cgi?id=111522
Reviewed by Filip Pizlo.
Let's stop doing that.
2% PLT speedup.
- history/PageCache.cpp:
(WebCore::PageCache::remove):
- 10:43 PM Changeset in webkit [144883] by
-
- 1 edit3 moves in trunk/LayoutTests
Make toggle-unlink.html test Mac specific behaviour
https://bugs.webkit.org/show_bug.cgi?id=111321
Reviewed by Ryosuke Niwa.
A new test for Windows behavior will have to be added once bug
110487 is landed.
- editing/execCommand/script-tests/toggle-unlink-mac.js: Renamed
from
LayoutTests/editing/execCommand/script-tests/toggle-unlink.js.
Also set editing behaviour to Mac.
- editing/execCommand/toggle-unlink-mac-expected.txt: Renamed from
LayoutTests/editing/execCommand/toggle-unlink-expected.txt.
- editing/execCommand/toggle-unlink-mac.html: Renamed from
LayoutTests/editing/execCommand/toggle-unlink.html.
- 10:27 PM Changeset in webkit [144882] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
Patch by Vsevolod Vlasov <vsevik@chromium.org> on 2013-03-05
- platform/chromium/TestExpectations:
- 10:09 PM Changeset in webkit [144881] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 9:48 PM Changeset in webkit [144880] by
-
- 2 edits in trunk/LayoutTests
Add a flaky crash test expectation to editing/selection/selection-invalid-offset.html
on Mac per bug 111521.
- platform/mac/TestExpectations:
- 9:32 PM Changeset in webkit [144879] by
-
- 2 edits6 adds in trunk/LayoutTests
Add test coverage for DCE and type checks.
Rubber stamped by Geoffrey Garen.
- fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null-and-decrement-expected.txt: Added.
- fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null-and-decrement.html: Added.
- fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null-expected.txt: Added.
- fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null-and-decrement.js: Added.
(foo):
- fast/js/script-tests/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null.js: Added.
(foo):
- 9:23 PM Changeset in webkit [144878] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html
- 9:16 PM Changeset in webkit [144877] by
-
- 19 edits2 adds in trunk
[Shadow] Implements event re-targeting for Touch Events.
https://bugs.webkit.org/show_bug.cgi?id=107800
Reviewed by Dimitri Glazkov.
Source/WebCore:
So far, Touch Events have been intentionally disabled in shadow
tree since it allows users to access internal nodes in shadow tree
by accessing Touch Event's information.
This patch re-targets all individual touch point's target in
TouchList (touches, targetTouches and changedTouches) owned by a Touch Event
before the Touch Event is dispatched so that we won't break an
upper boundary of shadow DOM.
Touch Events re-targeting is similar to that of Mouse Events
re-targeting. The difference is that a Touch Event can have more
than one related target because of multiple touches. We must
re-target all individual touch points which can be referred from
the Touch Event.
Now, Touch Events can be fired in shadow tree. I've removed the
existing limitation.
Test: fast/dom/shadow/touch-event-retargeting.html
- dom/EventContext.cpp:
(WebCore::EventContext::isTouchEventContext):
(WebCore):
(WebCore::TouchEventContext::TouchEventContext):
(WebCore::TouchEventContext::~TouchEventContext):
(WebCore::TouchEventContext::handleLocalEvents):
(WebCore::TouchEventContext::isTouchEventContext):
(WebCore::TouchEventContext::checkReachability): Used for assertion of reachability for each Touch point.
- dom/EventContext.h:
(WebCore):
(EventContext):
(TouchEventContext): Introduced to hold necessary information for re-targeting Touch event.
(WebCore::TouchEventContext::touches):
(WebCore::TouchEventContext::targetTouches):
(WebCore::TouchEventContext::changedTouches):
(WebCore::EventContext::isReachable):
- dom/EventRetargeter.cpp:
(WebCore::EventRetargeter::calculateEventPath):
(WebCore::EventRetargeter::adjustForTouchEvent):
(WebCore):
(WebCore::EventRetargeter::adjustTouchList):
(WebCore::EventRetargeter::adjustForRelatedTarget):
(WebCore::EventRetargeter::calculateAdjustedNodes): Updated so that this can be used for Touch point re-targeting.
(WebCore::EventRetargeter::buildRelatedNodeMap):
- dom/EventRetargeter.h:
(WebCore):
(EventRetargeter):
- dom/Node.cpp:
(WebCore::Node::dispatchEvent):
(WebCore):
(WebCore::Node::dispatchTouchEvent):
- dom/Node.h:
(WebCore):
(Node):
- dom/Touch.cpp:
(WebCore::Touch::Touch):
(WebCore):
(WebCore::Touch::cloneWithNewTarget):
- dom/Touch.h:
(Touch):
- dom/TouchEvent.cpp:
(WebCore::TouchEventDispatchMediator::create):
(WebCore):
(WebCore::TouchEventDispatchMediator::TouchEventDispatchMediator):
(WebCore::TouchEventDispatchMediator::event):
(WebCore::TouchEventDispatchMediator::dispatchEvent):
- dom/TouchEvent.h:
(TouchEvent):
(WebCore::TouchEvent::setTouches):
(WebCore::TouchEvent::setTargetTouches):
(WebCore::TouchEvent::setChangedTouches):
(TouchEventDispatchMediator):
(WebCore):
(WebCore::toTouchEvent):
- dom/TouchList.cpp:
(WebCore::TouchList::item):
(WebCore):
- dom/TouchList.h:
(TouchList):
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultInFrame): Removed the limitation. Adjusting is no longer done here.
(WebCore::EventHandler::handleTouchEvent):
LayoutTests:
- fast/dom/shadow/resources/event-dispatching.js:
(recordEvent):
(dumpTouchList):
(sortDispatchedEvent):
(showSandboxTree):
- fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt:
- fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node.html:
- fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt:
- fast/dom/shadow/touch-event-retargeting-expected.txt: Added.
- fast/dom/shadow/touch-event-retargeting.html: Added.
- 8:49 PM Changeset in webkit [144876] by
-
- 2 edits3 adds in trunk/LayoutTests
Add test coverage for DCE and type checks.
Rubber stampted by Geoffrey Garen.
- fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-typeof-expected.txt: Added.
- fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-typeof.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-cfg-simplify-eliminate-set-local-type-check-then-typeof.js: Added.
(foo):
- 8:27 PM Changeset in webkit [144875] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. AppleWin port.
- platform/win/TestExpectations:
- 8:22 PM Changeset in webkit [144874] by
-
- 2 edits3 adds in trunk/LayoutTests
DFG may infer an edge to be a double-using edge and then later experience multiple-personality disorder with respect to that particular decision
https://bugs.webkit.org/show_bug.cgi?id=109393
Rubber stamped by Geoffrey Garen.
- fast/js/dfg-double-addition-simplify-to-int-expected.txt: Added.
- fast/js/dfg-double-addition-simplify-to-int.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-double-addition-simplify-to-int.js: Added.
(foo):
- 8:17 PM Changeset in webkit [144873] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed gardening. AppleWin port.
- platform/win/cssom: Added.
- platform/win/cssom/cssvalue-comparison-expected.txt: Added.
- 8:04 PM Changeset in webkit [144872] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. AppleWin port.
Patch by Roger Fong <roger_fong@apple.com> on 2013-03-05
- platform/win/TestExpectations:
- platform/win/fast/forms/number: Added.
- platform/win/fast/forms/number/number-l10n-input-expected.txt: Added.
- 7:59 PM Changeset in webkit [144871] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed gardening. AppleWin port.
- platform/win/TestExpectations:
- platform/win/fast/forms/number: Added.
- platform/win/fast/forms/number/number-l10n-input-expected.txt: Added.
- 7:54 PM Changeset in webkit [144870] by
-
- 2 edits in trunk/Tools
[chromium] don't use custom freetype on linux asan for now
https://bugs.webkit.org/show_bug.cgi?id=111516
Unreviewed, build fix.
Turns out the custom lib is getting picked up by other binaries
on our bot, which is bad.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 7:52 PM Changeset in webkit [144869] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: plugins/plugin-clip-subframe.html
- 7:28 PM Changeset in webkit [144868] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: fast/regions/region-style-in-columns.html
- 7:27 PM Changeset in webkit [144867] by
-
- 2 edits in trunk/Tools
[chromium] making DumpRenderTree_resources a separate bundle breaks xcode
https://bugs.webkit.org/show_bug.cgi?id=111509
Unreviewed, build fix.
Actually comment out the flag :(.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 7:07 PM Changeset in webkit [144866] by
-
- 2 edits in trunk/Tools
[chromium] making DumpRenderTree_resources a separate bundle breaks xcode
https://bugs.webkit.org/show_bug.cgi?id=111509
Unreviewed, build fix.
r144863 appears to have broken the xcode build; I'm temporarily
trying this instead, and if this doesn't work, I'll revert the
other changes.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 6:52 PM Changeset in webkit [144865] by
-
- 6 edits in trunk/Source/WebCore
[Custom Elements][V8] Custom Element doesn't need its own WrapperTypeInfo
https://bugs.webkit.org/show_bug.cgi?id=111411
Reviewed by Kentaro Hara.
No new tests. No observable change yet.
This is a preparation for Bug 110436, where WebKit is going to
allow any HTML element to be a superclass of custom elements.
This change eliminates WrapperTypeInfo for custom element. Instead
of that, the wrapper of a custom element picks WrapperTypeInfo
from most descendant built-in HTML element. For example, think about
following hierarchy:
- ... <- HTMLElement <- HTMLDivElememnt <- ExistingCustomElement <- NewCustomElement
In this case, both ExistingCustomElement and NewCustomElement has
HTMLDivElememnt's type info. This is because HTMLDivElememnt is
the most descendant (or "the nearest") built-in HTML
element. (HTMLElement isn't the most descendant.
ExistingCustomElement isn't a built-in.)
Using such WrapperTypeInfos, created custom element wrappers can
get appropriate set of method and properties regardless of its
super-elements.
This change tells the prototype object of each built-in object
which WrapperTypeInfo the native backing wants:
HTMLDivElememnt.prototype knows V8HTMLDivElement::info for
example. The pointer to the type info is stored into an internal
field. On wrapper construction, createWrapper() walks up the
prototype chain and pick the first one.
- bindings/v8/V8DOMConfiguration.cpp:
(WebCore::V8DOMConfiguration::configureTemplate):
- bindings/v8/V8HTMLCustomElement.cpp:
(WebCore::findWrapperTypeOf):
(WebCore::V8HTMLCustomElement::createWrapper):
- bindings/v8/V8HTMLCustomElement.h:
- bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::constructorForTypeSlowCase):
- bindings/v8/WrapperTypeInfo.h:
(WebCore):
- 6:51 PM Changeset in webkit [144864] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix an incorrect comment. The comment was a holdover from a work-in-progress version of this code.
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::run):
- 6:37 PM Changeset in webkit [144863] by
-
- 2 edits in trunk/Tools
[chromium] build a DumpRenderTree.pak even on windows
https://bugs.webkit.org/show_bug.cgi?id=111504
Reviewed by Tony Chang.
The Chromium Aura build uses the default theme to draw
controls, and that theme requires the ui ResourceBundle
to be initialized. On every other platform, we build
a DumpRenderTree.pak that works for this, but on Windows we
still compile the resources directly into DRT. As a first step,
let's build the pak file. I will then need to land a patch
in Chromium to actually load it. Then I can go back and move
the resources over to just use the .pak file and no longer need
the .rc's.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 6:27 PM Changeset in webkit [144862] by
-
- 33 edits8 adds in trunk
DFG DCE might eliminate checks unsoundly
https://bugs.webkit.org/show_bug.cgi?id=109389
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
This gets rid of all eager reference counting, and does all dead code elimination
in one phase - the DCEPhase. This phase also sets up the node reference counts,
which are then used not just for DCE but also register allocation and stack slot
allocation.
Doing this required a number of surgical changes in places that previously relied
on always having liveness information. For example, the structure check hoisting
phase must now consult whether a VariableAccessData is profitable for unboxing to
make sure that it doesn't try to do hoisting on set SetLocals. The arguments
simplification phase employs its own light-weight liveness analysis. Both phases
previously just used reference counts.
The largest change is that now, dead nodes get turned into Phantoms. Those
Phantoms will retain those child edges that are not proven. This ensures that any
type checks performed by a dead node remain even after the node is killed. On the
other hand, this Phantom conversion means that we need special handling for
SetLocal. I decided to make the four forms of SetLocal explicit:
MovHint(@a, rK): Just indicates that node @a contains the value that would have
now been placed into virtual register rK. Does not actually cause @a to be
stored into rK. This would have previously been a dead SetLocal with @a
being live. MovHints are always dead.
ZombieHint(rK): Indicates that at this point, register rK will contain a dead
value and OSR should put Undefined into it. This would have previously been
a dead SetLocal with @a being dead also. ZombieHints are always dead.
MovHintAndCheck(@a, rK): Identical to MovHint except @a is also type checked,
according to whatever UseKind the edge to @a has. The type check is always a
forward exit. MovHintAndChecks are always live, since they are
NodeMustGenerate. Previously this would have been a dead SetLocal with a
live @a, and the check would have disappeared. This is one of the bugs that
this patch solves.
SetLocal(@a, rK): This still does exactly what it does now, if the SetLocal is
live.
Basically this patch makes it so that dead SetLocals eventually decay to MovHint,
ZombieHint, or MovHintAndCheck depending on the situation. If the child @a is
also dead, then you get a ZombieHint. If the child @a is live but the SetLocal
has a type check and @a's type hasn't been proven to have that type then you get
a MovHintAndCheck. Otherwise you get a MovHint.
This is performance neutral.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
(JSC::DFG::AbstractState::mergeStateAtTail):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
(ArgumentsSimplificationPhase):
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):
- dfg/DFGBasicBlock.h:
(BasicBlock):
- dfg/DFGBasicBlockInlines.h:
(DFG):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::insertPhiNode):
(JSC::DFG::ByteCodeParser::emitFunctionChecks):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::run):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::addPhiSilently):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGCommon.cpp:
(WTF::printInternal):
(WTF):
- dfg/DFGCommon.h:
(WTF):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):
(JSC::DFG::ConstantFoldingPhase::paintUnreachableCode):
- dfg/DFGDCEPhase.cpp: Added.
(DFG):
(DCEPhase):
(JSC::DFG::DCEPhase::DCEPhase):
(JSC::DFG::DCEPhase::run):
(JSC::DFG::DCEPhase::findTypeCheckRoot):
(JSC::DFG::DCEPhase::countEdge):
(JSC::DFG::DCEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::performDCE):
- dfg/DFGDCEPhase.h: Added.
(DFG):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(JSC::DFG::FixupPhase::truncateConstantToInt32):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dump):
(DFG):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::changeChild):
(JSC::DFG::Graph::changeEdge):
(JSC::DFG::Graph::compareAndSwap):
(JSC::DFG::Graph::clearAndDerefChild):
(JSC::DFG::Graph::performSubstitution):
(JSC::DFG::Graph::performSubstitutionForEdge):
(Graph):
(JSC::DFG::Graph::substitute):
- dfg/DFGInsertionSet.h:
(InsertionSet):
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::convertToConstant):
(JSC::DFG::Node::convertToGetLocalUnlinked):
(JSC::DFG::Node::containsMovHint):
(Node):
(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::willHaveCodeGenOrOSR):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compileMovHintAndCheck):
(DFG):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
(JSC::DFG::StructureCheckHoistingPhase::shouldConsiderForHoisting):
(StructureCheckHoistingPhase):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
LayoutTests:
Reviewed by Oliver Hunt.
- fast/js/dfg-arguments-osr-exit-multiple-blocks-before-exit-expected.txt: Added.
- fast/js/dfg-arguments-osr-exit-multiple-blocks-before-exit.html: Added.
- fast/js/dfg-arguments-osr-exit-multiple-blocks-expected.txt: Added.
- fast/js/dfg-arguments-osr-exit-multiple-blocks.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-arguments-osr-exit-multiple-blocks-before-exit.js: Added.
(baz):
(foo):
(bar):
- fast/js/script-tests/dfg-arguments-osr-exit-multiple-blocks.js: Added.
(baz):
(foo):
(bar):
- 6:15 PM Changeset in webkit [144861] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: inspector/console/command-line-api-inspect.html
- 6:13 PM Changeset in webkit [144860] by
-
- 2 edits in trunk/Source/WebKit2
Each web process truncates the disk cache to zero on launch
https://bugs.webkit.org/show_bug.cgi?id=111467
Reviewed by Darin Adler.
Let's not do that.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 6:11 PM Changeset in webkit [144859] by
-
- 6 edits3 adds in trunk
Heap-use-after-free in WebCore::HTMLMediaElement::~HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=110623
Reviewed by Eric Seidel.
Source/WebCore:
Test: http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html
- html/HTMLAudioElement.h:
(HTMLAudioElement):
- html/HTMLAudioElement.idl:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::hasPendingActivity):
- html/HTMLMediaElement.idl:
LayoutTests:
- http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal-expected.txt: Added.
- http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html: Added.
- http/tests/misc/resources/delete-frame-during-readystatechange-frame-with-gc-after-video-removal.html: Added.
- 5:47 PM Changeset in webkit [144858] by
-
- 6 edits2 adds in trunk
AX: Support aria-posinset/setsize
https://bugs.webkit.org/show_bug.cgi?id=109725
Reviewed by Tim Horton.
Source/WebCore:
Expose aria-setsize and aria-posinset through accessibility.
Right now only the Mac platform exposes them.
Test: platform/mac/accessibility/aria-setsize-posinset.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsARIASetSize):
(WebCore):
(WebCore::AccessibilityObject::supportsARIAPosInset):
(WebCore::AccessibilityObject::ariaSetSize):
(WebCore::AccessibilityObject::ariaPosInset):
- accessibility/AccessibilityObject.h:
(AccessibilityObject):
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- html/HTMLAttributeNames.in:
LayoutTests:
- platform/mac/accessibility/aria-setsize-posinset-expected.txt: Added.
- platform/mac/accessibility/aria-setsize-posinset.html: Added.
- 5:41 PM Changeset in webkit [144857] by
-
- 2 edits in trunk/WebKitLibraries
Remove deprecated process suppression assertion SPI from WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=111501
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-03-05
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=111387 replaced all usage of
WKNSProcessInfoProcessAssertionWithTypes() with
-[NSProcessInfo beginSuspensionOfSystemBehaviors:]. Hence, remove
the now deprecated SPI.
- WebKitSystemInterface.h: Remove
WKNSProcessInfoProcessAssertionWithTypes and associated declarations.
- 5:41 PM ScalesAndZooms edited by
- (diff)
- 5:29 PM Changeset in webkit [144856] by
-
- 10 edits1 add in trunk/Source
[chromium] Scroll deltas should be floats
https://bugs.webkit.org/show_bug.cgi?id=111465
Reviewed by James Robinson.
This converts the remaining scroll delta fields to floats so that
we no longer lose precision due to DIP conversion. The natural
type for deltas is WebFloatSize, which was missing, so I also created
that type based on the existing WebSize header.
Source/Platform:
- Platform.gypi:
- chromium/public/WebFloatSize.h: Added.
(WebKit):
(WebFloatSize):
(WebKit::WebFloatSize::isEmpty):
(WebKit::WebFloatSize::WebFloatSize):
(WebKit::WebFloatSize::operator=):
(WebKit::WebFloatSize::operator WebCore::FloatSize):
(WebKit::WebFloatSize::operator gfx::SizeF):
(WebKit::WebFloatSize::operator gfx::Vector2dF):
(WebKit::operator==):
(WebKit::operator!=):
- chromium/public/WebGestureCurveTarget.h:
(WebKit::WebGestureCurveTarget::scrollBy):
(WebGestureCurveTarget):
- chromium/public/WebInputHandlerClient.h:
(WebKit::WebInputHandlerClient::scrollByIfPossible):
(WebInputHandlerClient):
Source/WebKit/chromium:
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::touchpadFlingScroll):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):
- src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollBy):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebCompositorInputHandlerImplTest.cpp:
(MockWebInputHandlerClient):
(WebKit::TEST_F):
- 5:19 PM Changeset in webkit [144855] by
-
- 2 edits9 adds5 deletes in trunk/LayoutTests
Unreviewed apple rebaselines for r144837.
- fast/invalid/017-expected.txt: Added.
- fast/invalid/018-expected.txt: Added.
- platform/chromium-mac/fast/invalid/017-expected.txt: Removed.
- platform/chromium-mac/fast/invalid/018-expected.txt: Removed.
- platform/mac-lion/tables/mozilla/bugs: Added.
- platform/mac-lion/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
- platform/mac-lion/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/mac-lion/tables/mozilla_expected_failures: Removed.
- platform/mac-wk2/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
- platform/mac-wk2/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/mac/fast/invalid/017-expected.txt: Removed.
- platform/mac/fast/invalid/018-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
- 5:17 PM Changeset in webkit [144854] by
-
- 1 edit13 adds3 deletes in trunk/LayoutTests
Unreviewed chromium rebaselines for r144837.
- platform/chromium-linux/fast/invalid/017-expected.txt: Added.
- platform/chromium-linux/fast/invalid/018-expected.txt: Added.
- platform/chromium-linux/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
- platform/chromium-linux/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
- platform/chromium-mac-lion/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/chromium-mac/fast/invalid/017-expected.txt: Added.
- platform/chromium-mac/fast/invalid/018-expected.txt: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
- platform/chromium/fast/invalid/017-expected.txt: Removed.
- platform/chromium/fast/invalid/018-expected.txt: Removed.
- platform/chromium/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
- platform/chromium/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Replaced.
- 5:12 PM Changeset in webkit [144853] by
-
- 5 edits2 adds in trunk
Source/WebCore: [WinCairo] Support for cookies is incomplete
https://bugs.webkit.org/show_bug.cgi?id=110147
Expired and HttpOnly cookies no longer accessible from JavaScript.
Cookies set in JavaScript now have correct domain/path.
Patch by Peter Nelson <peter@peterdn.com> on 2013-03-05
Reviewed by Brent Fulgham.
Test: http/tests/cookies/http-get-cookie-set-in-js.html
- platform/network/curl/CookieJarCurl.cpp:
(WebCore):
(WebCore::addMatchingCurlCookie):
(WebCore::getNetscapeCookieFormat):
(WebCore::setCookiesFromDOM):
(WebCore::cookieRequestHeaderFieldValue):
LayoutTests: [WinCairo] Support for cookies is incomplete
https://bugs.webkit.org/show_bug.cgi?id=110147
Patch by Peter Nelson <peter@peterdn.com> on 2013-03-05
Reviewed by Brent Fulgham.
Re-enabled cookie tests for WinCairo.
Added test to check whether cookie set in HTTP response is accessible in JS.
- http/tests/cookies/http-get-cookie-set-in-js-expected.txt: Added.
- http/tests/cookies/http-get-cookie-set-in-js.html: Added.
- http/tests/cookies/resources/cookies-test-pre.js:
(clearAllCookies): Cookies set in JS now correctly cleared.
- platform/wincairo/TestExpectations:
- 5:10 PM Changeset in webkit [144852] by
-
- 4 edits in trunk/LayoutTests
Unreviewed. AppleWin gardening.
- platform/win/TestExpectations:
- platform/win/css3/filters/effect-reference-expected.txt:
- platform/win/css3/filters/effect-reference-hw-expected.txt:
- 5:08 PM Changeset in webkit [144851] by
-
- 3 edits in trunk/Source/WebKit2
Reset the values if there is a quota error
https://bugs.webkit.org/show_bug.cgi?id=111500
Reviewed by Beth Dakin.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::didSetItem):
(WebKit::StorageAreaProxy::resetValues):
(WebKit):
- WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
- 4:59 PM Changeset in webkit [144850] by
-
- 3 edits in trunk/Source/WebKit2
Keep track of pending value changes in StorageAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=111496
Reviewed by Beth Dakin.
Add a HashCountedSet to keep track of the number of pending value
changes for a given key. If we get incoming storage events from other
processes while we have pending value changes, ignore the events.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::setItem):
(WebKit::StorageAreaProxy::didSetItem):
(WebKit::StorageAreaProxy::dispatchStorageEvent):
(WebKit::StorageAreaProxy::shouldApplyChangesForKey):
(WebKit):
- WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
- 4:36 PM Changeset in webkit [144849] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Fix mac clang build with long long
https://bugs.webkit.org/show_bug.cgi?id=111495
Unreviewed fix for mac build.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore):
- 4:35 PM Changeset in webkit [144848] by
-
- 2 edits in trunk/Source
Fix mac clang build with long long
https://bugs.webkit.org/show_bug.cgi?id=111495
Unreviewed fix for mac build.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore):
- 4:26 PM Changeset in webkit [144847] by
-
- 13 edits in trunk/LayoutTests
Unreviewed rebaseline of media/track/track-cue-rendering-*.html
https://bugs.webkit.org/show_bug.cgi?id=111388
- platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
- platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium-mac-lion/media/track/track-cue-rendering-horizontal-expected.png:
- platform/chromium-mac-lion/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png:
- platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
- platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
- platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium/TestExpectations:
- 4:19 PM Changeset in webkit [144846] by
-
- 3 edits in trunk/Source/WebCore
Add V8Document.h include when the V8 code generator creates a toV8(Document*) call.
https://bugs.webkit.org/show_bug.cgi?id=111486
Reviewed by Adam Barth.
No new tests. This doesn't change user visible behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructor):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
- 4:18 PM Changeset in webkit [144845] by
-
- 9 edits1 add in trunk/Tools
Dashboard cleanup: move string utilities into their own namespace.
https://bugs.webkit.org/show_bug.cgi?id=111485
Reviewed by Ojan Vafai.
One of many pieces to clean up dashboard_base.
Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
- TestResultServer/static-dashboards/aggregate_results.html:
- TestResultServer/static-dashboards/dashboard_base.js:
(isTreeMap):
(isFlakinessDashboard):
- TestResultServer/static-dashboards/flakiness_dashboard.html:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(determineWKPlatform):
(chromiumPlatform):
(platformAndBuildType):
(substringList):
(individualTestsForSubstringList):
(filterBugs):
(populateExpectationsData):
(processMissingTestsWithExpectations):
(processMissingAndExtraExpectations):
(htmlForSingleTestRow):
(.dummyNode.onload):
(expectationsTitle):
- TestResultServer/static-dashboards/run-embedded-unittests.html:
- TestResultServer/static-dashboards/run-unittests.html:
- TestResultServer/static-dashboards/string.js: Added.
- TestResultServer/static-dashboards/timeline_explorer.html:
- TestResultServer/static-dashboards/treemap.html:
- 4:17 PM Changeset in webkit [144844] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 4:16 PM Changeset in webkit [144843] by
-
- 2 edits in trunk/Source/JavaScriptCore
Objective-C API: JSValue should implement init and return nil in exceptional cases
https://bugs.webkit.org/show_bug.cgi?id=111487
Reviewed by Darin Adler.
- API/JSValue.mm:
(-[JSValue init]): We return nil here because there is no way to get the instance into a coherent state
without a JSContext.
(-[JSValue initWithValue:inContext:]): Similarly, we should also return nil here if either of the arguments is 0.
- 4:15 PM Changeset in webkit [144842] by
-
- 14 edits in trunk
[EFL] Build break with latest EFL libraries
https://bugs.webkit.org/show_bug.cgi?id=111028
Reviewed by Dirk Pranke.
.:
In latest EFL trunk, include path of ecore sub modules are changed from
ecore-1 to ecore-XXX-1.
So, this patch adds missing ECORE_XXX_INCLUDE_DIRS.
- Source/cmake/FindEcore.cmake: Added additional path suffixes to find include directories of ecore-XXX
- Source/cmake/FindElementary.cmake: Checked Ecore_Con dependency which Elementary requires.
- Source/cmake/OptionsEfl.cmake: Made Imf and Imf_Evas mandatory.
Source/WebKit:
- PlatformEfl.cmake: Added ECORE_X_INCLUDE_DIRS.
Source/WebKit2:
- PlatformEfl.cmake: Added ECORE_XXX_INCLUDE_DIRS.
Source/WTF:
- wtf/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS.
Tools:
- MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
- TestWebKitAPI/PlatformEfl.cmake: Ditto.
- WebKitTestRunner/PlatformEfl.cmake: Ditto.
- 4:11 PM Changeset in webkit [144841] by
-
- 3 edits1 add in trunk
Fix default background of a dragged image.
https://bugs.webkit.org/show_bug.cgi?id=110512
Reviewed by Tony Chang.
.:
- ManualTests/drag-background-with-padding.html: Added.
Source/WebCore:
Transparent background color (particularly visible in the padding
of an element) was not being respected. The solution is to
initially fill the drag image with transparent instead of white,
so that any color background works correctly. This patch does not
affect Apple Mac or Win platforms, given that this part of the
code is #if guarded from those platforms.
Manual test added:
ManualTests/drag-background-with-padding.html
Infrastructure for retrieving the drag image for pixel testing
does not yet exist.
- page/Frame.cpp:
(WebCore::Frame::nodeImage):
- 4:10 PM Changeset in webkit [144840] by
-
- 3 edits in trunk/Tools
Increase number of WinEWS iterations to 20.
Don't reboot after each iteration set.
Make EWS bots just build temporarily so that the queue catches up again.
- EWSTools/start-queue-win.sh:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 4:05 PM Changeset in webkit [144839] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: /inspector/debugger/debugger-script-preprocessor.html
- 4:01 PM Changeset in webkit [144838] by
-
- 2 edits in trunk/Source/WebKit2
Use a named parameter for whether a quota error ocurred or not
https://bugs.webkit.org/show_bug.cgi?id=111490
Reviewed by Beth Dakin.
This is clearer than setItem returning true on error.
Also, actually set the item in the storage map.
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::setItem):
(WebKit::StorageManager::setItem):
- 3:59 PM Changeset in webkit [144837] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: i < size(), UNKNOWN in WebCore::RenderTableSection::layout
https://bugs.webkit.org/show_bug.cgi?id=108838
Source/WebCore:
Reviewed by Levi Weintraub.
Ensure that RenderTable::recalcSections is called when moving a
TableSection by calling setNeedsSectionRecalc in addChild for
TableSections.
Test: fullscreen/full-screen-table-section.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
LayoutTests:
Reviewed by Levi Weintraub.
Add test for calling requestFullscreen on an element with a
table-section display type.
- fullscreen/full-screen-table-section-expected.txt: Added.
- fullscreen/full-screen-table-section.html: Added.
- 3:58 PM Changeset in webkit [144836] by
-
- 1 copy in tags/Safari-536.29.3
New Tag.
- 3:57 PM Changeset in webkit [144835] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip tests on Windows to make EWS bots happier.
- platform/win/TestExpectations:
- 3:50 PM Changeset in webkit [144834] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: fullscreen/full-screen-iframe-allowed-prexied.
- 3:50 PM Changeset in webkit [144833] by
-
- 18 edits in trunk/Source
Upgrade ANGLE to r1987
https://bugs.webkit.org/show_bug.cgi?id=111381
Reviewed by Dean Jackson.
Source/ThirdParty/ANGLE:
- include/GLSLANG/ShaderLang.h:
- src/common/version.h:
- src/compiler/Compiler.cpp:
(TCompiler::TCompiler):
(TCompiler::Init):
(TCompiler::compile):
- src/compiler/ParseHelper.h:
(TParseContext):
- src/compiler/ShHandle.h:
(TCompiler):
- src/compiler/ShaderLang.cpp:
(ShInitBuiltInResources):
- src/compiler/UnfoldShortCircuit.cpp:
(sh::UnfoldShortCircuit::visitSelection):
- src/compiler/glslang.l:
- src/compiler/glslang.y:
- src/compiler/glslang_lex.cpp:
(glslang_scan):
- src/compiler/glslang_tab.cpp:
Updated ANGLE to r1987.
Source/WebCore:
Covered by existing tests. Ran WebGL conformance tests in Safari
to ensure correct operation of patch.
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::initializeANGLE):
Changed all ports to query for highp support in fragment
shaders and conditionally enable it in ANGLE shader translator.
- 3:46 PM Changeset in webkit [144832] by
-
- 5 edits in trunk
Use new assertion API for process suppression on Mac
https://bugs.webkit.org/show_bug.cgi?id=111387
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-03-05
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
- Shared/ChildProcess.h:
(WebKit::ChildProcess::processSuppressionEnabled): Rename
m_processVisibleAssertion to m_processSuppressionAssertion.
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::setProcessSuppressionEnabled): Ditto. And,
replace calls to WKNSProcessInfoProcessAssertionWithTypes() with call to
-[NSProcessInfo beginSuspensionOfSystemBehaviors:].
WebKitLibraries:
Add WKProcessSuppressionSystemBehaviors constant for use in WebKit2 to
take a process suppression assertion.
- WebKitSystemInterface.h:
- 3:45 PM Changeset in webkit [144831] by
-
- 10 edits2 adds in branches/safari-536.29-branch/Source/WebKit2
<rdar://problem/13345073>
- 3:43 PM WikiStart edited by
- Added a link to wiki:"May 2013 Meeting" (diff)
- 3:42 PM May 2013 Meeting created by
- Add 2013 contributor's meeting page
- 3:33 PM Changeset in webkit [144830] by
-
- 4 edits1 add in trunk/Source
IndexedDB: Add IDBBackingStoreTest
https://bugs.webkit.org/show_bug.cgi?id=111233
Reviewed by Adam Barth.
Source/WebCore:
These are tweaks to make IDBBackingStore more easily testable.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore): Allow use without a backing store.
Source/WebKit/chromium:
Add some really simple IDBBackingStore tests
as a seed for additional tests later.
- WebKit.gypi:
- tests/IDBBackingStoreTest.cpp: Added.
- 3:31 PM Changeset in webkit [144829] by
-
- 5 edits in trunk/Source/WebKit2
Move storageType() to StorageAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=111488
Reviewed by Andreas Kling.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::StorageAreaProxy):
(WebKit::StorageAreaProxy::storageType):
(WebKit::StorageAreaProxy::disabledByPrivateBrowsingInFrame):
- WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
- WebProcess/Storage/StorageNamespaceProxy.cpp:
- WebProcess/Storage/StorageNamespaceProxy.h:
- 3:31 PM Changeset in webkit [144828] by
-
- 2 edits in trunk/LayoutTests
Remove old Mac test expectations for the bug 106412.
- platform/mac/TestExpectations:
- 3:15 PM Changeset in webkit [144827] by
-
- 14 edits in trunk
[chromium] Move check for threaded compositing from WebCompositorSupport to Platform
https://bugs.webkit.org/show_bug.cgi?id=111386
Reviewed by Adrienne Walker.
Source/Platform:
This moves the query for if threaded compositing is enabled from WebCompositorSupport
to Platform. This is part of an effort to remove statefulness on WebCompositorSupport
and because it's much easier to override Platform functions for different tests.
- chromium/public/Platform.h:
(WebKit::Platform::isThreadedCompositingEnabled):
(Platform):
- chromium/public/WebCompositorSupport.h:
Source/WebCore:
This moves checks for whether threaded compositing is enabled from WebCompositorSupport
to Platform. In the case of Canvas2DLayerBridge, the check is moved completely out of
the class to make it easier for tests to specify the threaded configuration to use in the test.
- platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
- platform/graphics/chromium/Canvas2DLayerBridge.h:
(WebCore::Canvas2DLayerBridge::create):
(Canvas2DLayerBridge):
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createAcceleratedCanvas):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::scheduleComposite):
- tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
- tests/Canvas2DLayerManagerTest.cpp:
(FakeCanvas2DLayerBridge::FakeCanvas2DLayerBridge):
Tools:
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
- 3:13 PM WebKit Team edited by
- Move pdr@google.com to the reviewers list (diff)
- 3:04 PM Changeset in webkit [144826] by
-
- 4 edits in trunk/Source/WebCore
Split up the storage event dispatch functions further
https://bugs.webkit.org/show_bug.cgi?id=111482
Reviewed by Beth Dakin.
Add new functions for dispatching storage events to a set of frames.
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::dispatchStorageEvent):
- storage/StorageEventDispatcher.cpp:
(WebCore::StorageEventDispatcher::dispatchSessionStorageEvents):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEvents):
(WebCore):
(WebCore::StorageEventDispatcher::dispatchSessionStorageEventsToFrames):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEventsToFrames):
- storage/StorageEventDispatcher.h:
(WebCore):
(StorageEventDispatcher):
- 2:53 PM Changeset in webkit [144825] by
-
- 4 edits2 adds in trunk
Crash when ImageLoader deletes Element inside SVGImageElement
https://bugs.webkit.org/show_bug.cgi?id=111085
Reviewed by Abhishek Arya.
Source/WebCore:
Elements with ImageLoader objects associated with them may have their
final reference held by the ImageLoader (to allow events to be sent
and handled). Any call on Element that causes the ImageLoader to
dispatch events might then result in the final deref of the Element
itself, thus leaving all the Element's "this" pointers up the stack
pointing to invalid memory.
This change puts the deref of the Element on a timer so that, if the
deref is called via a method on Element, the call stack will unwind
before the deref occurs.
Test: svg/custom/image-with-attr-change-after-delete-crash.html
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::ImageLoader): Initialize a timer
(WebCore::ImageLoader::updatedHasPendingEvent): Put deref of the
element on a oneShotTimer, with appropriate assertions and checks to
ensure we only ref/deref once.
(WebCore::ImageLoader::timerFired): Deref the element when the timer fires.
- loader/ImageLoader.h:
(ImageLoader): Define a timer for controlling deref of the element.
LayoutTests:
- svg/custom/image-with-attr-change-after-delete-crash-expected.txt: Added.
- svg/custom/image-with-attr-change-after-delete-crash.html: Added.
- 2:48 PM Changeset in webkit [144824] by
-
- 5 edits2 adds in trunk
Web Inspector: identify reflection layers in LayerTreeAgent
https://bugs.webkit.org/show_bug.cgi?id=111419
Source/WebCore:
We add a new property "isReflection" to the Layer objects returned
to the front-end to indicate whether the layer was created to host
the reflection for an element. When this new property is true, the
"nodeId" property is set to point to the reflected element's node
id, since there is no node per-se directly associated with this layer.
We also change the "bounds" property to return absolute page coordinates
such that the front-end can use this information to highlight that
region in the page since metrics would otherwise be unavailable.
Reviewed by Dean Jackson.
Test: inspector-protocol/layers/layers-reflected-content.html
- inspector/Inspector.json:
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
LayoutTests:
New test for reflection layers and an updated output for the
existing layersForNode() test since we changed the coordinates
for the "bounds" property to be absolute instead of local.
Reviewed by Dean Jackson.
- inspector-protocol/layers/layers-for-node-expected.txt:
- inspector-protocol/layers/layers-reflected-content-expected.txt: Added.
- inspector-protocol/layers/layers-reflected-content.html: Added.
- 2:47 PM Changeset in webkit [144823] by
-
- 3 edits in trunk/Source/WebCore
[WinCairo] Compile fix after r144024.
https://bugs.webkit.org/show_bug.cgi?id=111306
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-03-05
Reviewed by James Robinson.
- page/scrolling/ScrollingCoordinator.cpp: Added guard for USE(ACCELERATED_COMPOSITING).
- page/scrolling/ScrollingCoordinator.h: Added guard for USE(ACCELERATED_COMPOSITING).
- 2:46 PM Changeset in webkit [144822] by
-
- 2 edits in trunk/Tools
Copy dictionary to the external storage before running layout test on android
https://bugs.webkit.org/show_bug.cgi?id=111480
Patch by Min Qin <qinmin@chromium.org> on 2013-03-05
Reviewed by Adam Barth.
TestWebKitPlatformSupport now needs to read an external dictionary file.
This file does not exist on the device. We need to copy it before running layout tests.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
(ChromiumAndroidDriver._push_platform_resources):
- 2:44 PM Changeset in webkit [144821] by
-
- 4 edits1 add in trunk/Source
keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux
https://bugs.webkit.org/show_bug.cgi?id=85642
Source/WebCore:
Add missing key mappings for GDK_KP_Begin, GDK_KP_Insert, GDK_KP_Delete and GDK_ISO_Level3_Shift.
Patch by James Weatherall <wez@chromium.org> on 2013-03-05
Reviewed by Ojan Vafai.
- platform/chromium/KeyCodeConversionGtk.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
Source/WebKit/chromium:
Add tests to verify that the fixed keys generate the same keyCode values as their equivalents.
Patch by James Weatherall <wez@chromium.org> on 2013-03-05
Reviewed by Ojan Vafai.
- WebKit.gypi:
- tests/KeyCodeConversionTestGtk.cpp: Added.
(WebCore):
(WebCore::TEST):
- 2:35 PM Changeset in webkit [144820] by
-
- 37 edits1 copy in trunk/Source
IndexedDB: Properly refactor frontend/backend code by #includes
https://bugs.webkit.org/show_bug.cgi?id=110653
Reviewed by Dimitri Glazkov.
Source/WebCore:
IndexedDB has a distinct backend and frontend, with well defined
*Interface / *Callbacks classes distinguishing them, respectively.
This makes sure that the frontend and backend do not include each
other and fixes build problems that occurred as a result.
Specifically this moves enums out of IDBCursor and IDBTransaction
into IndexedDB.h in a new WebCore::IndexedDB namespace.
No new tests, as this is just a refactor.
Source/WebKit/chromium:
Clean up the frontend/backend WebIDB* implementations to
match the changes to webkit.
- 2:30 PM Changeset in webkit [144819] by
-
- 8 edits in trunk
Clear associated cache partitions when deleting origins' cache
https://bugs.webkit.org/show_bug.cgi?id=111383
Reviewed by Maciej Stachowiak.
Source/WebCore:
Clear the cache partitions associated with the origin being cleared.
Not possible to test with current automated test tools, must be tested manually.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::removeResourcesWithOrigin):
Source/WebKit2:
Clear the cache partitions associated with the origin being cleared.
- WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
(WebKit):
(WebKit::partitionName):
(WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames):
WebKitLibraries:
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 2:25 PM Changeset in webkit [144818] by
-
- 11 edits3 copies2 moves1 add in trunk/LayoutTests
Rebaseline text output for opaque GraphicsLayers
https://bugs.webkit.org/show_bug.cgi?id=109507
Unreviewed rebaseline.
- compositing/contents-opaque/contents-opaque-background-color-expected.txt:
- compositing/contents-opaque/contents-opaque-layer-opacity-expected.txt:
- compositing/contents-opaque/contents-opaque-layer-transform-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/contents-opaque/contents-opaque-background-color-expected.txt: Copied from LayoutTests/compositing/contents-opaque/contents-opaque-background-color-expected.txt.
- platform/chromium/compositing/contents-opaque/contents-opaque-layer-opacity-expected.txt: Copied from LayoutTests/compositing/contents-opaque/contents-opaque-layer-opacity-expected.txt.
- platform/chromium/compositing/contents-opaque/contents-opaque-layer-transform-expected.txt: Copied from LayoutTests/compositing/contents-opaque/contents-opaque-layer-transform-expected.txt.
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Renamed from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt.
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Renamed from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt.
- platform/efl/TestExpectations:
- platform/efl/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 2:18 PM Changeset in webkit [144817] by
-
- 4 edits3 adds35 deletes in trunk/LayoutTests
editing/pasteboard/paste-text-005.html, paste-text-006.html, and paste-text-007.html should be dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=111466
Reviewed by Levi Weintraub.
- editing/pasteboard/paste-text-005-expected.txt: Added.
- editing/pasteboard/paste-text-005.html:
- editing/pasteboard/paste-text-006-expected.txt: Added.
- editing/pasteboard/paste-text-006.html:
- editing/pasteboard/paste-text-007-expected.txt: Added.
- editing/pasteboard/paste-text-007.html:
- platform/chromium-linux/editing/pasteboard/paste-text-005-expected.png: Removed.
- platform/chromium-linux/editing/pasteboard/paste-text-006-expected.png: Removed.
- platform/chromium-linux/editing/pasteboard/paste-text-007-expected.png: Removed.
- platform/chromium-mac-lion/editing/pasteboard/paste-text-005-expected.png: Removed.
- platform/chromium-mac-lion/editing/pasteboard/paste-text-006-expected.png: Removed.
- platform/chromium-mac-lion/editing/pasteboard/paste-text-007-expected.png: Removed.
- platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-005-expected.txt: Removed.
- platform/chromium-mac/editing/pasteboard/paste-text-005-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/paste-text-006-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/paste-text-007-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-005-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-005-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-006-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-006-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-007-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-007-expected.txt: Removed.
- platform/chromium/editing/pasteboard/paste-text-005-expected.txt: Removed.
- platform/chromium/editing/pasteboard/paste-text-006-expected.txt: Removed.
- platform/chromium/editing/pasteboard/paste-text-007-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-text-005-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-text-007-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-text-005-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-text-005-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-text-006-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-text-006-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-text-007-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-text-007-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-text-005-expected.png: Removed.
- platform/qt/editing/pasteboard/paste-text-005-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-text-006-expected.png: Removed.
- platform/qt/editing/pasteboard/paste-text-006-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-text-007-expected.png: Removed.
- platform/qt/editing/pasteboard/paste-text-007-expected.txt: Removed.
- platform/win/editing/pasteboard/paste-text-005-expected.txt: Removed.
- 2:04 PM Changeset in webkit [144816] by
-
- 3 edits in trunk/Source/WebCore
Inline min/maxInstrinsicLogicalWidth functions
https://bugs.webkit.org/show_bug.cgi?id=111399
Reviewed by Tony Chang.
Turns out these functions don't need to be public and only
have one caller. This patch is in preparation for supporting
intrinsic widths on tables, which will need to pass in the
border and padding width as an argument.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::fillAvailableMeasure):
(WebCore::RenderBox::computeIntrinsicLogicalWidthUsing):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
- rendering/RenderBox.h:
- 2:04 PM Changeset in webkit [144815] by
-
- 2 edits1 add13 deletes in trunk/LayoutTests
editing/pasteboard/paste-table-003.html should be a dump-as-text test
https://bugs.webkit.org/show_bug.cgi?id=111400
Reviewed by Levi Weintraub.
Convert the test to a dump-as-text test. The output is much easier to understand now.
Also moved the test description out of the root element so that it won't be repeated
multiple times in the output.
- editing/pasteboard/paste-table-003-expected.txt: Added.
- editing/pasteboard/paste-table-003.html:
- platform/chromium-linux/editing/pasteboard/paste-table-003-expected.png: Removed.
- platform/chromium-mac-lion/editing/pasteboard/paste-table-003-expected.png: Removed.
- platform/chromium-mac-snowleopard/editing/pasteboard/paste-table-003-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/paste-table-003-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-table-003-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-table-003-expected.txt: Removed.
- platform/chromium/editing/pasteboard/paste-table-003-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-table-003-expected.png: Removed.
- platform/gtk/editing/pasteboard/paste-table-003-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-table-003-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-table-003-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-table-003-expected.png: Removed.
- platform/qt/editing/pasteboard/paste-table-003-expected.txt: Removed.
- 2:02 PM Changeset in webkit [144814] by
-
- 4 edits2 adds in trunk
Cue line-height property shouldn't be inherited from the video element
https://bugs.webkit.org/show_bug.cgi?id=111262
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/track-cue-rendering-on-resize.html
- css/mediaControls.css:
(video::-webkit-media-text-track-container): Set the default font size
and family using the "font" property to also reset the line-height property.
LayoutTests:
- media/track/captions-webvtt/captions-snap-to-lines-set.vtt: Updated.
- media/track/track-cue-rendering-on-resize-expected.txt: Added.
- media/track/track-cue-rendering-on-resize.html: Added.
- 1:48 PM Changeset in webkit [144813] by
-
- 6 edits1 delete in trunk/Source/WebCore
IndexedDB: Remove some unused binding code
https://bugs.webkit.org/show_bug.cgi?id=111463
Reviewed by Adam Barth.
IDBRequest got a custom V8 getter for |request| to help diagnose an issue, but the
root cause was found/fixed (http://wkbug.com/110916 and http://wkbug.com/110206) so
remove it. Also, IDBKey was marked ScriptWrappable but it is now explicitly converted
to a ScriptValue before it gets anywhere near the binding code, so remove that too.
Finally, createIDBKeyFromValue doesn't need to be exposed from IDBBindingUtilities.
No new tests - just removing dead code.
- Modules/indexeddb/IDBKey.h: No need for ScriptWrappable.
- Modules/indexeddb/IDBRequest.idl: Remove custom binding (root cause of bug found).
- WebCore.gypi: Ditto.
- bindings/js/IDBBindingUtilities.h: Don't expose internal createIDBKeyFromValue().
- bindings/v8/IDBBindingUtilities.h: Ditto.
- bindings/v8/custom/V8IDBRequestCustom.cpp: Removed.
- 1:47 PM Changeset in webkit [144812] by
-
- 27 edits2 adds in branches/safari-534.59-branch/Source/WebKit2
534.59 branch needs to handle API clients with a non-zero version number
<rdar://problem/13348902> and https://bugs.webkit.org/show_bug.cgi?id=111475
Reviewed by Anders Carlsson.
This patch:
1 - Adds the APIClient and APIClientTraits versioning mechanism from ToT to the branch.
2 - Updates most APIClients to have a current version of 0.
3 - Updates the WKPageLoaderClient and WKPageUIClient to have non-zero current versions.
4 - Allows non-zero versioned clients through the calls to WKPageSetPageLoaderClient and WKPageSetPageUIClient.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient): Allow non-zero clients through.
(WKPageSetPageUIClient): Ditto.
Add the client traits mechanism and implement traits for the two clients that have a non-zero current version:
- Shared/APIClientTraits.cpp: Added.
- Shared/APIClientTraits.h: Added.
Allow for setting versioned clients using those client traits:
- Shared/APIClient.h:
(WebKit::APIClient::initialize):
(WebKit::APIClient::client):
Update the APIClient templatization for all APIClients to pass their current version:
- UIProcess/WebContextInjectedBundleClient.h:
- UIProcess/WebCookieManagerProxyClient.h:
- UIProcess/WebDatabaseManagerProxyClient.h:
- UIProcess/WebDownloadClient.h:
- UIProcess/WebFindClient.h:
- UIProcess/WebFormClient.h:
- UIProcess/WebGeolocationProvider.h:
- UIProcess/WebHistoryClient.h:
- UIProcess/WebIconDatabaseClient.h:
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageContextMenuClient.h:
- UIProcess/WebPolicyClient.h:
- UIProcess/WebResourceLoadClient.h:
- UIProcess/WebUIClient.h:
- WebProcess/InjectedBundle/InjectedBundleClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebKit2.xcodeproj/project.pbxproj:
- 1:41 PM Changeset in webkit [144811] by
-
- 2 edits in trunk/Source/WTF
Fix cast-align warning in ASCIIFastPath.h on ARM
https://bugs.webkit.org/show_bug.cgi?id=111436
Reviewed by Benjamin Poulain.
- wtf/text/ASCIIFastPath.h:
(WTF::charactersAreAllASCII):
- 1:38 PM Changeset in webkit [144810] by
-
- 37 edits1 delete in trunk/Source
Unreviewed, rolling out r144798.
http://trac.webkit.org/changeset/144798
https://bugs.webkit.org/show_bug.cgi?id=111478
"broke chromium windows build" (Requested by dpranke on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-05
Source/WebCore:
- GNUmakefile.list.am:
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::Cursor::continueFunction):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):
(WebCore::IDBBackingStore::openObjectStoreCursor):
(WebCore::IDBBackingStore::openObjectStoreKeyCursor):
(WebCore::IDBBackingStore::openIndexKeyCursor):
(WebCore::IDBBackingStore::openIndexCursor):
- Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::create):
(WebCore::IDBCursor::IDBCursor):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::stringToDirection):
(WebCore::IDBCursor::directionToString):
- Modules/indexeddb/IDBCursor.h:
(IDBCursor):
- Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::deleteFunction):
(WebCore::IDBCursorBackendImpl::CursorPrefetchIterationOperation::perform):
- Modules/indexeddb/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
(WebCore::IDBCursorBackendImpl::value):
(IDBCursorBackendImpl):
- Modules/indexeddb/IDBCursorBackendInterface.h:
(WebCore):
- Modules/indexeddb/IDBCursorWithValue.cpp:
(WebCore::IDBCursorWithValue::create):
(WebCore::IDBCursorWithValue::IDBCursorWithValue):
- Modules/indexeddb/IDBCursorWithValue.h:
(IDBCursorWithValue):
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction):
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::GetOperation::create):
(WebCore::GetOperation::GetOperation):
(GetOperation):
(WebCore::OpenCursorOperation::create):
(WebCore::OpenCursorOperation::OpenCursorOperation):
(OpenCursorOperation):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::createIndex):
(WebCore::IDBDatabaseBackendImpl::deleteIndex):
(WebCore::IDBDatabaseBackendImpl::get):
(WebCore::GetOperation::perform):
(WebCore::IDBDatabaseBackendImpl::put):
(WebCore::PutOperation::perform):
(WebCore::IDBDatabaseBackendImpl::setIndexKeys):
(WebCore::IDBDatabaseBackendImpl::openCursor):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteRange):
(WebCore::DeleteRangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::clear):
(WebCore::IDBDatabaseBackendImpl::transactionStarted):
(WebCore::IDBDatabaseBackendImpl::transactionFinished):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndCompleteFired):
(WebCore::IDBDatabaseBackendImpl::createTransaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
- Modules/indexeddb/IDBFactory.h:
- Modules/indexeddb/IDBIndex.cpp:
(WebCore):
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore):
(WebCore::IDBObjectStore::openCursor):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::setCursorDetails):
(WebCore::IDBRequest::setResultCursor):
(WebCore::IDBRequest::onSuccess):
- Modules/indexeddb/IDBRequest.h:
(IDBRequest):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::stringToMode):
(WebCore::IDBTransaction::modeToString):
- Modules/indexeddb/IDBTransaction.h:
(WebCore::IDBTransaction::isReadOnly):
(WebCore::IDBTransaction::isVersionChange):
(IDBTransaction):
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::create):
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
- Modules/indexeddb/IDBTransactionBackendImpl.h:
(IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::mode):
- Modules/indexeddb/IDBTransactionCoordinator.cpp:
(WebCore::IDBTransactionCoordinator::processStartedTransactions):
(WebCore::IDBTransactionCoordinator::canRunTransaction):
- Modules/indexeddb/IndexedDB.h: Removed.
- Target.pri:
- WebCore.gypi:
Source/WebKit/chromium:
- src/AssertMatchingEnums.cpp:
- src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::openCursor):
- src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
- src/WebIDBCallbacksImpl.cpp:
- src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::openCursor):
- tests/IDBAbortOnCorruptTest.cpp:
- tests/IDBDatabaseBackendTest.cpp:
- tests/IDBFakeBackingStore.h:
- 1:37 PM Changeset in webkit [144809] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/efl/TestExpectations: Unskipping the fast/workers/shared-worker-load-error.html layout test
and adding a flaky timeout expectation for it. Looking for testing data from the EFL port on this test.
- 1:15 PM Changeset in webkit [144808] by
-
- 7 edits in trunk
MediaStream API: Allow local and remote descriptions to be accessed after close
https://bugs.webkit.org/show_bug.cgi?id=111437
Reviewed by Adam Barth.
Source/WebCore:
It's quite clear in the standard that the getters should still return the old value.
Also overhauling the state setters a bit to check if the new state is different.
Existing tests expanded to cover patch.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::remoteDescription):
(WebCore::RTCPeerConnection::changeSignalingState):
(WebCore::RTCPeerConnection::changeIceGatheringState):
(WebCore::RTCPeerConnection::changeIceConnectionState):
LayoutTests:
Expanding tests to check the new behaviour.
- fast/mediastream/RTCPeerConnection-localDescription-expected.txt:
- fast/mediastream/RTCPeerConnection-localDescription.html:
- fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt:
- fast/mediastream/RTCPeerConnection-remoteDescription.html:
- 1:14 PM Changeset in webkit [144807] by
-
- 2 edits in trunk/LayoutTests
Multiple html5lib Layout Tests are slow since r144032
https://bugs.webkit.org/show_bug.cgi?id=110876
Reviewed by Tony Chang.
Skip the html5lib tests when in debug mode. The -data variants
almost always timeout due to v8 boot-up time:
https://code.google.com/p/v8/issues/detail?id=2567
These timeouts sometimes manifest as failures, and we've even
seen crashes (with empty stacks!?) of these tests on Win and Mac in Debug, so
skipping them until they run in a reasonable time and can
be debugged further.
- platform/chromium/TestExpectations:
- 1:12 PM Changeset in webkit [144806] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: expectations for transitions/transitions-parsing.html
- 1:11 PM Changeset in webkit [144805] by
-
- 11 edits in trunk/Source
Add FrameLoaderClient::didAccessInitialDocument
https://bugs.webkit.org/show_bug.cgi?id=107963
Source/WebCore:
Notifies the FrameLoaderClient if another page accesses the
initial empty document of a main frame. In this case, it is
no longer safe to display the provisional URL.
Only takes effect for PLATFORM(CHROMIUM), since no other platforms
listen to the notification.
Reviewed by Adam Barth.
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::setSecurityToken):
Use default token for initial document.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
Notify loader if initial document is accessed.
(WebCore::V8DOMWindow::namedSecurityCheck):
(WebCore::V8DOMWindow::indexedSecurityCheck):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::didAccessInitialDocument):
(WebCore):
- loader/FrameLoader.h:
(FrameLoader):
- loader/FrameLoaderClient.h:
(FrameLoaderClient):
(WebCore::FrameLoaderClient::didAccessInitialDocument):
Source/WebKit/chromium:
Notifies WebFrameClient if another page accesses the initial
empty document of a main frame. In this case, it is no longer
safe to display the provisional URL.
Reviewed by Adam Barth.
- public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::didAccessInitialDocument):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didAccessInitialDocument):
(WebKit):
- src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
- tests/WebFrameTest.cpp:
- 1:08 PM Changeset in webkit [144804] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Fix assertion in CookieManager::getBackingStoreCookies
https://bugs.webkit.org/show_bug.cgi?id=111468
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-03-05
Reviewed by Rob Buis.
Internally reviewed by Konrad Piascik.
The assert in getBackingStoreCookies could be giving out false positives now
that we have our fixes for cookie loading in PR 286189. The cookie store could
be half loaded if the first cookie get/set call happens before the db is fully loaded.
A full webkit sync call to reload the database will cause the assert to be hit.
Safer to flush everything out and try again.
- platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::getBackingStoreCookies):
- 1:07 PM Changeset in webkit [144803] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 12:57 PM Changeset in webkit [144802] by
-
- 2 edits in trunk/Tools
[chromium] DRT crashes in an Aura/Win build
https://bugs.webkit.org/show_bug.cgi?id=111394
Reviewed by Tony Chang.
When building (and running) with use_aura=1, we assume that
we're using the default theme engine, but DRT creates the
DRTWin theme engine and overwrites the default, leading to crashes
in basically every test from the mismatch.
This fix gets us down to at least "lots of crashes" :).
- DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit):
- 12:44 PM Changeset in webkit [144801] by
-
- 8 edits in trunk/Source/WebCore
CompactHTMLToken does not need an XSSInfo pointer
https://bugs.webkit.org/show_bug.cgi?id=111423
Reviewed by Eric Seidel.
The CompactHTMLToken should remain as small as possible because it is copied. This shrinks the size by one pointer
by moving a relatively uncommon attribute out to its own Vector.
No new tests because no new functionality.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::checkThatXSSInfosAreSafeToSendToAnotherThread):
(WebCore):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
- html/parser/BackgroundHTMLParser.h:
(BackgroundHTMLParser):
- html/parser/CompactHTMLToken.cpp:
(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread):
- html/parser/CompactHTMLToken.h:
(WebCore):
(CompactHTMLToken):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
- html/parser/HTMLDocumentParser.h:
(ParsedChunk):
- html/parser/XSSAuditorDelegate.h:
(XSSInfo):
(WebCore):
- 12:31 PM Changeset in webkit [144800] by
-
- 4 edits in trunk/Source/WebCore
Split StorageEventDispatcher::dispatch into two functions
https://bugs.webkit.org/show_bug.cgi?id=111464
Reviewed by Beth Dakin.
Split StorageEventDispatcher::dispatch into dispatchSessionStorageEvent and
dispatchLocalStorageEvent and make StorageAreaImpl::dispatchStorageEvent call
the right function based on the storage area type.
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::dispatchStorageEvent):
- storage/StorageEventDispatcher.cpp:
(WebCore::StorageEventDispatcher::dispatchSessionStorageEvent):
(WebCore):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEvent):
- storage/StorageEventDispatcher.h:
(StorageEventDispatcher):
- 12:27 PM Changeset in webkit [144799] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Unreviewed build fix after r144024.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::scrollLayerForScrollableArea): Handle
case of not using Accelerated Compositing
(WebCore::ScrollingCoordinator::horizontalScrollbarLayerForScrollableArea):
(WebCore::ScrollingCoordinator::verticalScrollbarLayerForScrollableArea): Ditto.
- 12:11 PM Changeset in webkit [144798] by
-
- 37 edits1 copy in trunk/Source
IndexedDB: Properly refactor frontend/backend code by #includes
https://bugs.webkit.org/show_bug.cgi?id=110653
Reviewed by Dimitri Glazkov.
Source/WebCore:
IndexedDB has a distinct backend and frontend, with well defined
*Interface / *Callbacks classes distinguishing them, respectively.
This makes sure that the frontend and backend do not include each
other and fixes build problems that occurred as a result.
Specifically this moves enums out of IDBCursor and IDBTransaction
into IndexedDB.h in a new WebCore::IndexedDB namespace.
No new tests, as this is just a refactor.
Source/WebKit/chromium:
Clean up the frontend/backend WebIDB* implementations to
match the changes to webkit.
- 12:09 PM Changeset in webkit [144797] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening
Unreviewed gardening
- platform/chromium/TestExpectations:
- 11:57 AM Changeset in webkit [144796] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r186200. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-05
- DEPS:
- 11:56 AM Changeset in webkit [144795] by
-
- 6 edits in trunk/Source
ContainerNode::setActive should not sleep for 100ms on platforms that do not implement synchronous repaint(true) semantics
https://bugs.webkit.org/show_bug.cgi?id=87054
Patch by James Robinson <jamesr@chromium.org> on 2013-03-05
Reviewed by Darin Adler.
Source/WebCore:
Adds a new ChromeClient function to query if the platform supports the immediate parameter
to the invalidation APIs and guards the synchronous repaint logic in ContainerNode::setActive()
with it.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::setActive):
- page/ChromeClient.h:
(WebCore::ChromeClient::supportsImmediateInvalidation):
Source/WebKit/mac:
The Mac WebKit1 port supports immediate invalidations.
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::supportsImmediateInvalidation):
- 11:49 AM Changeset in webkit [144794] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL] WebPageProxy::setThemePath() should check that the page is valid
https://bugs.webkit.org/show_bug.cgi?id=109917
Reviewed by Alexey Proskuryakov.
WebPageProxy::setThemePath() should check that the page is valid before
sending IPC message.
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::setThemePath):
- 11:49 AM Changeset in webkit [144793] by
-
- 1 edit1 move1 add13 deletes in trunk/LayoutTests
editing/pasteboard/5247341.html should be a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=111397
Reviewed by Darin Adler.
Convert the test to use dump-as-markup.js. Also rename it to preserve-line-break-at-end-of-pasted-content
to reflect the content of the test.
- editing/pasteboard/5247341.html: Removed.
- editing/pasteboard/preserve-line-break-at-end-of-pasted-content-expected.txt: Added.
- editing/pasteboard/preserve-line-break-at-end-of-pasted-content.html: Copied from LayoutTests/editing/pasteboard/5247341.html.
- platform/chromium-linux/editing/pasteboard/5247341-expected.png: Removed.
- platform/chromium-mac-lion/editing/pasteboard/5247341-expected.png: Removed.
- platform/chromium-mac-snowleopard/editing/pasteboard/5247341-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/5247341-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/5247341-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/5247341-expected.txt: Removed.
- platform/chromium/editing/pasteboard/5247341-expected.txt: Removed.
- platform/gtk/editing/pasteboard/5247341-expected.png: Removed.
- platform/gtk/editing/pasteboard/5247341-expected.txt: Removed.
- platform/mac/editing/pasteboard/5247341-expected.png: Removed.
- platform/mac/editing/pasteboard/5247341-expected.txt: Removed.
- platform/qt/editing/pasteboard/5247341-expected.png: Removed.
- platform/qt/editing/pasteboard/5247341-expected.txt: Removed.
- 11:43 AM Changeset in webkit [144792] by
-
- 1 copy in tags/Safari-536.29.2
New Tag.
- 11:43 AM Changeset in webkit [144791] by
-
- 3 edits in trunk/Source/WebCore
Simplify storage event dispatch somewhat
https://bugs.webkit.org/show_bug.cgi?id=111461
Reviewed by Beth Dakin.
Add a StorageAreaImpl::dispatchStorageEvent to avoid replicating the calls to
StorageEventDispatcher::dispatch there times. This is in preparation for changing the
interface of StorageEventDispatcher so it can be used by WebKit2.
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::setItem):
(WebCore::StorageAreaImpl::removeItem):
(WebCore::StorageAreaImpl::clear):
(WebCore::StorageAreaImpl::dispatchStorageEvent):
- storage/StorageAreaImpl.h:
Reindent.
- 11:41 AM Changeset in webkit [144790] by
-
- 3 edits2 adds in trunk
Fix some crashes in render sliders
https://bugs.webkit.org/show_bug.cgi?id=111458
Reviewed by Ojan Vafai.
Source/WebCore:
Fix some cases where we assumed the renderer is a renderBox.
Test: fast/forms/range/slider-inline-crash.html
- html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderContainer::layout): Use renderBox() which will return 0 if the renderer is not a RenderBox.
(WebCore::SliderThumbElement::setPositionFromPoint): Bail out early if renderBox() is 0.
LayoutTests:
- fast/forms/range/slider-inline-crash-expected.txt: Added.
- fast/forms/range/slider-inline-crash.html: Added.
- 11:37 AM Changeset in webkit [144789] by
-
- 5 edits in trunk
REGRESSION(r142191): Fix closed caption buttons for ports still using the painting path.
https://bugs.webkit.org/show_bug.cgi?id=111109
Reviewed by Eric Carlson.
Source/WebCore:
Covered by following tests:
media/track/track-cue-rendering-horizontal.html
media/track/track-cue-rendering-vertical.html
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
- rendering/RenderTheme.h:
(WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton):
LayoutTests:
- platform/chromium/TestExpectations:
- 11:17 AM Changeset in webkit [144788] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13269245> Crashes creating WebKit processes in WKSandboxExtensionConsume
https://bugs.webkit.org/show_bug.cgi?id=111456
Reviewed by Anders Carlsson.
It's too late to be draconian about this condition here, crashing doesn't help
diagnose what went wrong when creating a sandbox extension.
Other SandboxExtension functions already have null checks for WKSandboxExtensionRef,
and so should consumePermanently().
- Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::createHandle): For now, added logging when extension creation fails. If that proves insufficiently helpful in practice, we can change to a CRASH() later. (WebKit::SandboxExtension::createHandleForTemporaryFile): Ditto. (WebKit::SandboxExtension::consumePermanently): Gracefully fail if there is no extension to consume.
- 11:16 AM Changeset in webkit [144787] by
-
- 17 edits1 add1 delete in trunk/Source
Coordinated Graphics: CoordinatedGraphicsLayer makes CoordinatedGraphicsScene perform via CoordinatedGraphicsState.
https://bugs.webkit.org/show_bug.cgi?id=108294
Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-03-05
Reviewed by Anders Carlsson.
Source/WebCore:
CoordinatedLayerTreeHostProxy has too many IPC messages (e.g. SyncCanvas and
CreateTile), and there is a long function chain from CoordinatedGraphicsLayer to
CoordinatedGraphicsScene (4 classes).
If we want to add a new message, we need to add similar functions into 4 classes.
Now CoordinatedLayerTreeHost has only one IPC message for CoordinatedGraphicsLayer:
CommitCoordinatedGraphicsState.
CoordinatedGraphicsLayer makes CoordinatedGraphicsScene run as follows:
- CoordinatedGraphicsLayer makes a CoordinatedGraphicsLayerState.
- CoordinatedLayerTreeHost stores all LayerStates.
- CoordinatedLayerTreeHost sends GraphicsState includes LayerStates to CoordinatedLayerTreeHostProxy
at the moment of flushing via CommitCoordinatedGraphicsState message.
- CoordinatedGraphicsScene applies all state changes to layers.
There is one big behavior change. All states changes (e.g.
UpdateTiles, SetLayerChildren, and etc..) are performed at the same time, when
CoordinatedGraphicsScene::commitCoordinatedGraphicsState is called.
This patch is based on Dongsung Huang, and Noam's work in
https://bugs.webkit.org/show_bug.cgi?id=108294
No new tests, covered by existing tests.
- Target.pri:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setPosition):
(WebCore::CoordinatedGraphicsLayer::setAnchorPoint):
(WebCore::CoordinatedGraphicsLayer::setSize):
(WebCore::CoordinatedGraphicsLayer::setTransform):
(WebCore::CoordinatedGraphicsLayer::setChildrenTransform):
(WebCore::CoordinatedGraphicsLayer::setPreserves3D):
(WebCore::CoordinatedGraphicsLayer::setMasksToBounds):
(WebCore::CoordinatedGraphicsLayer::setDrawsContent):
(WebCore::CoordinatedGraphicsLayer::setContentsVisible):
(WebCore::CoordinatedGraphicsLayer::setContentsOpaque):
(WebCore::CoordinatedGraphicsLayer::setBackfaceVisibility):
(WebCore::CoordinatedGraphicsLayer::setOpacity):
(WebCore::CoordinatedGraphicsLayer::setContentsRect):
(WebCore::CoordinatedGraphicsLayer::setFilters):
(WebCore::CoordinatedGraphicsLayer::setContentsToSolidColor):
(WebCore::CoordinatedGraphicsLayer::setShowDebugBorder):
(WebCore::CoordinatedGraphicsLayer::setShowRepaintCounter):
(WebCore::CoordinatedGraphicsLayer::setMaskLayer):
(WebCore::CoordinatedGraphicsLayer::setReplicatedByLayer):
(WebCore::CoordinatedGraphicsLayer::setFixedToViewport):
(WebCore::CoordinatedGraphicsLayer::syncChildren):
(WebCore::CoordinatedGraphicsLayer::syncFilters):
(WebCore::CoordinatedGraphicsLayer::syncImageBacking):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::setDebugBorder):
(WebCore::CoordinatedGraphicsLayer::syncAnimations):
(WebCore::CoordinatedGraphicsLayer::syncCanvas):
(WebCore::CoordinatedGraphicsLayer::destroyCanvasIfNeeded):
(WebCore::CoordinatedGraphicsLayer::createCanvasIfNeeded):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::resetLayerState):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::releaseImageBackingIfNeeded):
(WebCore::CoordinatedGraphicsLayer::setRootLayer):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStorePaintEnd):
(WebCore::CoordinatedGraphicsLayer::createTile):
(WebCore::CoordinatedGraphicsLayer::updateTile):
(WebCore::CoordinatedGraphicsLayer::removeTile):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::createCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::syncCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::destroyCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerRepaintCountIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerChildrenIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerFiltersIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerState):
(WebCore::CoordinatedGraphicsScene::deleteLayer):
(WebCore::CoordinatedGraphicsScene::createTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::removeTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::updateTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::assignImageBackingToLayer):
(WebCore::CoordinatedGraphicsScene::commitSceneState):
(WebCore::CoordinatedGraphicsScene::setLayerAnimationsIfNeeded):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
(WebCore):
(CoordinatedGraphicsScene):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h: Added.
(WebCore):
(TileUpdateInfo):
(TileCreationInfo):
(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):
(CoordinatedGraphicsLayerState):
(CoordinatedGraphicsState):
- platform/graphics/texmap/coordinated/CoordinatedImageBacking.h:
- platform/graphics/texmap/coordinated/CoordinatedLayerInfo.h: Removed.
- platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h:
Source/WebKit2:
There are two changes in WK2.
- Change CoordinatedLayerTreeHostProxy to use CoordinatedGraphicsState.
- Add encode/decode of CoordinatedGraphicsState in CoordinatedGraphicsArgumentCoders.
This patch is based on Dongsung Huang, and Noam's work in
https://bugs.webkit.org/show_bug.cgi?id=108294
No new tests, covered by existing tests.
- Scripts/webkit2/messages.py:
(headers_for_type):
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
Encoding UpdateImageBacking and CreateUpdateAtlas can fail when
encoding WebCoordinatedSurface::Handle fails, but we don't
recover in the case.
(CoreIPC::::decode):
(CoreIPC):
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
(WebCore):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::commitCoordinatedGraphicsState):
(WebKit):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(WebCore):
(CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::coordinatedGraphicsScene):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):
(WebKit::CoordinatedLayerTreeHost::initializeRootCompositingLayerIfNeeded):
(WebKit::CoordinatedLayerTreeHost::syncLayerState):
(WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesIfNeeded):
(WebKit):
(WebKit::CoordinatedLayerTreeHost::updateImageBacking):
(WebKit::CoordinatedLayerTreeHost::setBackgroundColor):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost):
- 11:13 AM Changeset in webkit [144786] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed. AppleWin VS2010 build fix.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- rendering/RenderingAllInOne.cpp:
- 11:07 AM Changeset in webkit [144785] by
-
- 4 edits1 move in trunk
Add html-parser-threaded perf test now that the threaded parser is enabled by default
https://bugs.webkit.org/show_bug.cgi?id=111200
Reviewed by Ryosuke Niwa.
PerformanceTests:
The old srcdoc test no longer triggers the threaded parser due to compatibility fixes.
- Parser/html-parser-threaded.html: Renamed from PerformanceTests/Parser/html-parser-srcdoc.html.
- Skipped: Unfortunately this new test is still skipped too.
Tools:
Had to teach run-perf-tests to ignore one more warning.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
- 11:07 AM Changeset in webkit [144784] by
-
- 18 edits1 delete in trunk
[chromium] Clean up WebWidget / WebLayerTreeView interactions
https://bugs.webkit.org/show_bug.cgi?id=109125
Patch by James Robinson <jamesr@chromium.org> on 2013-03-05
Reviewed by Adrienne Walker.
Source/Platform:
This deprecates most of the calls on WebLayerTreeViewClient since these interactions are handled
entirely on the embedder side of the interface now.
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
- chromium/public/WebLayerTreeViewClient.h:
(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::willBeginFrame):
(WebKit::WebLayerTreeViewClient::didBeginFrame):
(WebKit::WebLayerTreeViewClient::applyScrollAndScale):
(WebKit::WebLayerTreeViewClient::layout):
(WebKit::WebLayerTreeViewClient::didRecreateOutputSurface):
(WebKit::WebLayerTreeViewClient::createInputHandler):
(WebKit::WebLayerTreeViewClient::createOutputSurface):
(WebKit::WebLayerTreeViewClient::willCommit):
(WebKit::WebLayerTreeViewClient::didCommit):
(WebKit::WebLayerTreeViewClient::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewClient::didCompleteSwapBuffers):
Source/WebKit/chromium:
This removes most of the compositing control flow logic from WebViewImpl since
it is now handled in the embedding layer (by the implementation of WebViewClient/WebWidgetClient).
- public/WebViewClient.h:
- public/WebWidget.h:
(WebKit):
(WebKit::WebWidget::animate):
(WebWidget):
(WebKit::WebWidget::didExitCompositingMode):
(WebKit::WebWidget::createInputHandler):
(WebKit::WebWidget::applyScrollAndScale):
(WebKit::WebWidget::instrumentBeginFrame):
(WebKit::WebWidget::instrumentWillBeginFrame):
(WebKit::WebWidget::instrumentDidCancelFrame):
(WebKit::WebWidget::instrumentDidBeginFrame):
(WebKit::WebWidget::instrumentWillComposite):
- src/WebHelperPluginImpl.cpp:
- src/WebHelperPluginImpl.h:
(WebHelperPluginImpl):
- src/WebPagePopupImpl.cpp:
- src/WebPagePopupImpl.h:
(WebPagePopupImpl):
- src/WebPopupMenuImpl.cpp:
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::instrumentWillBeginFrame):
(WebKit::WebViewImpl::instrumentDidBeginFrame):
(WebKit::WebViewImpl::instrumentDidCancelFrame):
(WebKit::WebViewImpl::instrumentWillComposite):
(WebKit):
(WebKit::WebViewImpl::updateBatteryStatus):
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::didExitCompositingMode):
- src/WebViewImpl.h:
- tests/WebLayerTreeViewTestCommon.h:
(MockWebLayerTreeViewClient):
- 11:05 AM Changeset in webkit [144783] by
-
- 2 edits in trunk/Tools
Update list of builders for test results server
https://bugs.webkit.org/show_bug.cgi?id=111166
Reviewed by Ojan Vafai.
- TestResultServer/static-dashboards/builders.jsonp:
- 10:54 AM Changeset in webkit [144782] by
-
- 2 edits in tags/Safari-537.31.14/Source/WebCore
Merged r143490. <rdar://problem/13341434>
- 10:49 AM Changeset in webkit [144781] by
-
- 15 edits in tags/Safari-537.31.14/Source
Merged r143428. <rdar://problem/13341434>
- 10:30 AM Changeset in webkit [144780] by
-
- 1 edit1 add in trunk/Tools
[GTK] Move basic dependency installation to a script
https://bugs.webkit.org/show_bug.cgi?id=110692
Patch by Martin Robinson <mrobinson@igalia.com> and Tomas Popela <tpopela@redhat.com> on 2013-03-05
Reviewed by Gustavo Noronha Silva.
- gtk/install-dependencies: Added. A Script which installs all dependencies
necessary for building for Debian-based distributions and Fedora.
- 10:29 AM Changeset in webkit [144779] by
-
- 2 edits in trunk/Source/WebKit2
Follow up to https://bugs.webkit.org/show_bug.cgi?id=111453, forgot to mark the files as Private.
- WebKit2.xcodeproj/project.pbxproj:
- 10:28 AM Changeset in webkit [144778] by
-
- 4 edits in tags/Safari-537.31.14/Source
Versioning.
- 10:26 AM Changeset in webkit [144777] by
-
- 9 edits1 copy2 moves in trunk/Source/WebKit2
Elevate accessors of C-SPI API variants to Objective-C SPI
https://bugs.webkit.org/show_bug.cgi?id=111453
<rdar://problem/13340357>
Reviewed by Alexey Proskuryakov.
- Shared/mac/ObjCObjectGraphCoders.mm:
- UIProcess/API/mac/WKBrowsingContextControllerInternal.h:
- UIProcess/API/mac/WKBrowsingContextControllerPrivate.h:
- UIProcess/API/mac/WKBrowsingContextGroup.mm:
- UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Renamed from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupInternal.h.
- UIProcess/API/mac/WKProcessGroup.mm:
- UIProcess/API/mac/WKProcessGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h.
- UIProcess/API/mac/WKView.mm:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
(-[WKWebProcessPlugInController _bundleRef]):
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInPrivate.h: Renamed from Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h.
Add access to C-SPI WebKit types as Objective-C SPI.
- 10:19 AM Changeset in webkit [144776] by
-
- 11 edits2 adds in trunk
[CSS Exclusions] shape-outside on floats for polygon shapes
https://bugs.webkit.org/show_bug.cgi?id=98676
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-03-05
Reviewed by David Hyatt.
Source/WebCore:
Implement support for polygonal shape-outside on floats. The basic
tack taken here is to keep using the bounding box of the shape to
position the float, but to compute the offset (caused by the shape)
from the bounding box for each line when creating and positioning
other inline content.
Test: fast/exclusions/shape-outside-floats/shape-outside-floats-simple-polygon.html
- rendering/ExclusionShapeInfo.cpp:
(WebCore):
(WebCore::::computedShape): Add new template parameter.
(WebCore::::logicalTopOffset): Add new template parameter.
(WebCore::::computeSegmentsForLine): Move here from
ExclusionShapeInsideInfo, since ExclusionShapeOutsideInfo needs it
as well. Make virtual since there is slightly different behavior
between each class even though the vast majority of the code is
common.
- rendering/ExclusionShapeInfo.h:
(WebCore):
(WebCore::ExclusionShapeInfo::~ExclusionShapeInfo): Since
computeSegmentsForLine is virtual, the destructor must be virtual
as well.
(ExclusionShapeInfo): Add new data members to support
computeSegmentsForLine.
(WebCore::ExclusionShapeInfo::shapeLogicalRight): Fix bug, the logical
right is based off of maxX, not y. (it's a logical bounding box!)
(WebCore::ExclusionShapeInfo::logicalLineTop): Moved from
ExclusionShapeInsideInfo for use by computeSegmentsForLine and
lineOverlapsShapeBounds.
(WebCore::ExclusionShapeInfo::logicalLineBottom): Moved from
ExclusionShapeInsideInfo for use by computeSegmentsForLine and
lineOverlapsShapeBounds.
(WebCore::ExclusionShapeInfo::lineOverlapsShapeBounds): Moved from
ExclusionShapeInsideInfo for use by computeSegmentsForLine.
- rendering/ExclusionShapeInsideInfo.cpp: Moved common code from
computeSegmentsForLine into ExclusionShapeInfo.
- rendering/ExclusionShapeInsideInfo.h:
(WebCore): Moved some methods to ExclusionShapeInfo.
(ExclusionShapeInsideInfo): Update for new template parameter.
(WebCore::ExclusionShapeInsideInfo::compyteSegmentsForLine): Override
superclass method to clear the segment ranges. Segement ranges
aren't used by shape outside, and have some complex dependencies
that make it very hard to try and move up into ExclusionShapeInfo.
(WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo): Update
for new template parameter.
- rendering/ExclusionShapeOutsideInfo.cpp:
(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Add polygons as a
supported shape.
(WebCore::ExclusionShapeOutsideInfo::computeSegmentsForLine): Override
superclass method to not recompute if it isn't needed (this isn't
straightfoward for shape inside, which is why it isn't common),
and to save the left and right offsets caused by the shape
outside, since that's all that is needed to properly do layout in
the case of floats.
- rendering/ExclusionShapeOutsideInfo.h:
(WebCore::ExclusionShapeOutsideInfo::shapeLogicalOffset): Reformat to
be on a single line, like most other methods of it's type in
WebKit headers.
(ExclusionShapeOutsideInfo): Update for new template parameter.
(WebCore::ExclusionShapeOutsideInfo::logicalLeftOffsetForLine):
Accessor method to get the left offset between the shape and the
shape's bounding box.
(WebCore::ExclusionShapeOutsideInfo::logicalRightOffsetForLine):
Accessor method to get the left offset between the shape and the
shape's bounding box.
(WebCore::ExclusionShapeOutsideInfo::ExclusionShapeOutsideInfo):
Update for new template parameter.
- rendering/RenderBlock.cpp:
(WebCore::::collectIfNeeded): Save the last float encountered so that
the shape outside offset can be accounted for.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Account for the
shape outside offset on the outermost float.
(WebCore::RenderBlock::logicalRightOffsetForLine): Account for the
shape outside offset on the outermost float.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
Initialize the lastFloat member.
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lastFloat): Get the
last float encountered.
(FloatIntervalSearchAdapter): Add a pointer to the last float
encountered. Note that the variable is mutable because
collectIfNeeded is declared as a const method even though it isn't
(it uses loopholes to update m_offset and m_heightRemaining).
Instead of trying to come up with a hack to stick with the
loopholes, I decided to be explicit about it.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Take
into account the offset from any polygonal shape outside.
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Add a FIXME
because the current code will not work properly with stacked
floats that have polygonal shape outside.
LayoutTests:
Simple test for floats with polygonal shape-outside.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-polygon-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-polygon.html: Added.
- 10:18 AM Changeset in webkit [144775] by
-
- 2 edits in trunk/Tools
Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
https://bugs.webkit.org/show_bug.cgi?id=111440
Reviewed by Adrienne Walker.
Remove unnecessary WebCompositorSupport::shutdown call
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- 10:06 AM Changeset in webkit [144774] by
-
- 1 copy in tags/Safari-537.31.14
New Tag.
- 10:05 AM Changeset in webkit [144773] by
-
- 13 edits in trunk/Source/WebCore
[New Multicolumn] Autogenerate regions for columns.
https://bugs.webkit.org/show_bug.cgi?id=111363
Reviewed by Dean Jackson.
In CSS Regions, we lay out the regions first, and then
we put the flow thread into the regions. This model doesn't
really work for multicolumn layout, which needs to be able
to auto-generate new regions lazily in response to the flow
thread asking for regions at particular offsets.
With the multi-column model, where the regions can't just occur
anywhere, its ok not to lay them out before the flow thread, as
long as we have at least given them the correct size.
This patch changes the layout algorithm for columns to:
(1) Size any existing regions (without worrying about placement).
(2) Lay out the flow thread (generating and sizing regions lazily
that need to be created).
(3) Lay out the regions (to give them correct placement and to
compute overflow correctly for the multi-column block that contains
the regions).
There are no new tests, since there are no behavioral changes. This
is just groundwork for being able to add new sets in response to
spans, balancing, and nested pagination contexts.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::layoutBlockChild):
- rendering/RenderBlock.h:
(RenderBlock):
Since we want to be able to call determineLogicalLeftPositionForChild
to place the flow thread properly, and we don't want to apply a layout
delta (flow threads repaint themselves), we parameterize the method
here so that it can be called without applying a layout delta.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
These methods are only used by RenderMultiColumnFlowThread, since
RenderNamedFlowThread overrides them. Remove the code that invalidates
the flow threads region set as regions come and go, since that is now
going to be expected with auto-generation.
(WebCore::RenderFlowThread::validateRegions):
Refactor the code in RenderFlowThread::layout that validates the regions
into its own method, so that we can re-validate regions at any time
after generating new ones.
(WebCore::RenderFlowThread::layout):
Changed to move the region validation code into its own function that is
now called from here.
(WebCore::RenderFlowThread::updateLogicalWidth):
Don't assert if a region set needs layout.
(WebCore::RenderFlowThread::computeLogicalHeight):
Ditto. Don't assert if a region set needs layout. That's expected now.
(WebCore::RenderFlowThread::regionAtBlockOffset):
Add code to regionAtBlockOffset to auto-generate regions up to
the offset. This ensures the region that is being asked for
exists.
(WebCore::RenderFlowThread::pageLogicalTopForOffset):
(WebCore::RenderFlowThread::pageLogicalWidthForOffset):
(WebCore::RenderFlowThread::pageLogicalHeightForOffset):
(WebCore::RenderFlowThread::pageRemainingLogicalHeightForOffset):
These functions are no longer const, since the act of asking for
pagination offsets can cause us to generate new regions.
(WebCore::RenderFlowThread::mapFromFlowToRegion):
Modified to turn auto-generation off, since this is not really
a "layout-time" function.
(WebCore::RenderFlowThread::logicalWidthChangedInRegions):
Modified to not assert if a region set needs layout, since that is
expected now.
- rendering/RenderFlowThread.h:
Changes to remove const from the methods that can trigger region
auto-generation.
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::styleDidChange):
Make sure to propagate style changes down into the regions. I don't know
of any correctness bugs around this, but I figured I'd be thorough.
(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
We no longer build a column set aggressively. We wait for the flow thread
to ask us for a region at a particular offset, and only then do we
build the set.
(WebCore::RenderMultiColumnBlock::addChild):
Now that we lay out the flow thread as a special excluded child, we don't
care about the ordering of it relative to the region children.
(WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
We now lay out the flow thread as a special excluded child (like the legend
of a fieldset).
- rendering/RenderMultiColumnBlock.h:
(RenderMultiColumnBlock):
Add new overrides like layoutSpecialExcludedChild.
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::initialLogicalWidth):
Set the flow thread to the initial column width even when no regions exist
yet. This way we ensure the width is right even when we don't have any
regions yet.
(WebCore::RenderMultiColumnFlowThread::autoGenerateRegionsToBlockOffset):
This method handles autogenerating the new region for a given offset.
Right now it's simplistic, since we only have one column set. This method
will be enhanced in future patches when we start supporting multiple column
sets.
- rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):
Adding new method declarations like autoGenerateRegionsToBlockOffset.
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::updateLogicalWidth):
Since regions lay out after flow threads, we don't need to make
setFlowThreadPortionRect virtual any longer. We can just get our column set's
width correct immediately. This is the same logic, just moved into updateLogicalWidth().
- rendering/RenderMultiColumnSet.h:
Remove setFlowThreadPortionRect override, since the function can just be simple
and non-virtual in RenderRegion now.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::layoutBlock):
Don't ever invalidate region sets in response to our size changing during layout. Since
our size is always determined outside of layout now, we don't need to do any of
these checks.
- rendering/RenderRegion.h:
(WebCore::RenderRegion::setFlowThreadPortionRect):
Changed to be non-virtual now that RenderMultiColumnSet doesn't need to override.
- 10:05 AM Changeset in webkit [144772] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Authentication credentials lost when opening a new tab
https://bugs.webkit.org/show_bug.cgi?id=111445
PR 286627
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-03-05
Reviewed by Rob Buis.
Internally Reviewed by Lianghui Chen.
Prevent changing the private mode boolean value in didChangeSettings if the value
hasn't changed.
Setting the private mode value of credentialstorage every time didChangeSettings gets
called causes the session credential mapping to be cleared on every tab change in
non-private mode.
Tested changing tabs after logging into a site using the HTTP Basic Auth protocol to see
if the credentials are cleared. Also ensured the functionality of private mode is not changed.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- 9:54 AM Changeset in webkit [144771] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] FatFinger pairs the wrong element with fatfinger rect part.
https://bugs.webkit.org/show_bug.cgi?id=111444
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-03-05
Reviewed by Rob Buis.
Internal PR 266214
Internally reviewed by Genevieve Mak.
Instead of subtracting with the element region, we should get the remaining
rect by find the intersect region of element region and fatfinger detection
region.
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::checkForClickableElement):
- 9:42 AM Changeset in webkit [144770] by
-
- 18 edits1 add in trunk/Source
Make AsyncFileReader work without ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=111376
Reviewed by Anders Carlsson.
- WebCore.xcodeproj/project.pbxproj: Added MainThreadTask.h.
- dom/ScriptExecutionContext.cpp:
- dom/ScriptExecutionContext.h: Removed fileThread(). Creating a thread for every context that acesses files appears wasteful and unnecessary.
- fileapi/AsyncFileStream.h:
- fileapi/AsyncFileStream.cpp: (WebCore::createFileThread): FileThread is now a singleton. (WebCore::fileThread): Ditto. (WebCore::AsyncFileStream::AsyncFileStream): (WebCore::AsyncFileStream::create): (WebCore::didStart): (WebCore::AsyncFileStream::startOnFileThread): (WebCore::AsyncFileStream::stop): (WebCore::derefProxyOnMainThread): (WebCore::AsyncFileStream::stopOnFileThread): (WebCore::didGetSize): (WebCore::AsyncFileStream::getSizeOnFileThread): (WebCore::didOpen): (WebCore::AsyncFileStream::openForReadOnFileThread): (WebCore::AsyncFileStream::openForWriteOnFileThread): (WebCore::didRead): (WebCore::AsyncFileStream::readOnFileThread): (WebCore::didWrite): (WebCore::AsyncFileStream::writeOnFileThread): (WebCore::didTruncate): (WebCore::AsyncFileStream::truncateOnFileThread): Use callOnMainThread() instead of posting messages through a context. We never used other threads, and don't plan to.
- loader/ResourceLoader.cpp:
- loader/ResourceLoader.h: We no longer need this pseudo-client call to create an AsyncFileStream, now that we don't need to get a ScriptExecutionContext somewhere.
- platform/MainThreadTask.h: Added. This implements callOnMainThread with multiple strongly typed arguments. Closely based on CrossThreadTask.h.
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::BlobResourceHandle): Create AsyncFileStream directly.
- platform/network/ResourceHandleClient.h: Removed createAsyncFileStream().
- 9:35 AM Changeset in webkit [144769] by
-
- 2 edits in trunk/Source/WebCore
Update the localizable strings file.
Rubber-stamped by Anders Carlsson.
- English.lproj/Localizable.strings:
- 9:32 AM Changeset in webkit [144768] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13345116> REGRESSION: Child processes get access to user cache
and temporary directories instead of private ones
Reviewed by Sam Weinig.
- Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::initializeSandbox): Restore the correct order of calls, so sandbox parameters respect WebKit pseudo containers.
- 9:26 AM Changeset in webkit [144767] by
-
- 14 edits1 delete in trunk/Source/JavaScriptCore
Unreviewed, rolling out r144708.
http://trac.webkit.org/changeset/144708
https://bugs.webkit.org/show_bug.cgi?id=111447
random assertion crashes in inspector tests on qt+mac bots
(Requested by kling on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-05
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
- runtime/PropertyMapHashTable.h:
(PropertyTable):
(JSC::PropertyTable::PropertyTable):
(JSC):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::copy):
- runtime/PropertyTable.cpp: Removed.
- runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::pin):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNamesFromStructure):
(JSC::Structure::visitChildren):
(JSC::Structure::checkConsistency):
- runtime/Structure.h:
(JSC):
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
(JSC::Structure::checkOffsetConsistency):
(Structure):
- runtime/StructureInlines.h:
(JSC::Structure::get):
- runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::get):
- 9:24 AM Changeset in webkit [144766] by
-
- 4 edits2 adds in trunk
AX: aria-label does not override text content on iOS
https://bugs.webkit.org/show_bug.cgi?id=111222
Reviewed by David Kilzer.
Source/WebCore:
Make iOS use the same text alternative computation that Mac is using. The main difference
is that description and title need to be concatenated, because iOS doesn't have two attributes
to return those values.
Test: platform/iphone-simulator/accessibility/aria-label-with-internal-text.html
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper stringValueShouldBeUsedInLabel]):
(-[WebAccessibilityObjectWrapper accessibilityLabel]):
(-[WebAccessibilityObjectWrapper accessibilityHint]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
LayoutTests:
- platform/iphone-simulator/accessibility/aria-label-with-internal-text-expected.txt: Added.
- platform/iphone-simulator/accessibility/aria-label-with-internal-text.html: Added.
- 9:08 AM Changeset in webkit [144765] by
-
- 4 edits in trunk
Unreviewed build fix.
.:
- GNUmakefile.am: remove bad path for generate-feature-defines-files from EXTRA_DIST.
Tools:
- GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
- 8:58 AM Changeset in webkit [144764] by
-
- 8 edits in trunk/Source
BUILD FIX (r144698): Only enable SPEECH_SYNTHESIS for Mac
<http://webkit.org/b/106742>
Fixes the following build failures:
Undefined symbols for architecture i386:
"ZTVN7WebCore25PlatformSpeechSynthesizerE", referenced from:
ZN7WebCore25PlatformSpeechSynthesizerC2EPNS_31PlatformSpeechSynthesizerClientE in PlatformSpeechSynthesizer.o
NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
"ZN7WebCore25PlatformSpeechSynthesizer19initializeVoiceListEv", referenced from:
ZN7WebCore25PlatformSpeechSynthesizerC2EPNS_31PlatformSpeechSynthesizerClientE in PlatformSpeechSynthesizer.o
ld: symbol(s) not found for architecture i386
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- Fix definition of ENABLE_ENCRYPTED_MEDIA_V2_macosx to match other FeatureDefines.xcconfig files.
- Only set ENABLE_SPEECH_SYNTHESIS for the macosx platform.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- Only set ENABLE_SPEECH_SYNTHESIS for the macosx platform.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- Only set ENABLE_SPEECH_SYNTHESIS for the macosx platform.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- Only set ENABLE_SPEECH_SYNTHESIS for the macosx platform.
- 8:58 AM Changeset in webkit [144763] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: registered new MIME type application/font-woff for WOFF fonts.
https://bugs.webkit.org/show_bug.cgi?id=111418
The WOFF MIME Type was formally registered as application/font-woff (FINALLY):
http://www.iana.org/assignments/media-types/application/font-woff
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-05
Reviewed by Pavel Feldman.
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithResponse):
- 8:27 AM Changeset in webkit [144762] by
-
- 10 edits2 adds in trunk
[CSS Grid Layout] Add parsing for grid-{end|after}
https://bugs.webkit.org/show_bug.cgi?id=111372
Reviewed by Tony Chang.
Source/WebCore:
Test: fast/css-grid-layout/grid-item-end-after-get-set.html
This change adds the proper support for grid-{end|after}. It doesn't update
grid-{row|column} to be a shorthand for both grid-{before|start} and grid-{after|end}
though.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Added the new properties to our known properties. Also added
support for getComputedStyle.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
Added parsing for the new properties.
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
The new properties are not inherited.
- css/CSSPropertyNames.in:
Added the new properties.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Added code to handle applying them to our style.
- rendering/style/RenderStyle.h:
- rendering/style/StyleGridItemData.cpp:
(WebCore::StyleGridItemData::StyleGridItemData):
- rendering/style/StyleGridItemData.h:
(WebCore::StyleGridItemData::operator==):
(StyleGridItemData):
Updated our representation to store the new properties.
LayoutTests:
- fast/css-grid-layout/grid-item-end-after-get-set-expected.txt: Added.
- fast/css-grid-layout/grid-item-end-after-get-set.html: Added.
Note that some of the test fails as we don't treat grid-{row|column} as a shorthand.
- 8:06 AM Changeset in webkit [144761] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed follow-up to r144756, fix broken inspector-less build.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willWriteHTML):
- 7:54 AM Changeset in webkit [144760] by
-
- 21 edits2 adds in trunk
Improve robustness of WebSQL quota management.
https://bugs.webkit.org/show_bug.cgi?id=110600.
Reviewed by Geoffrey Garen.
Source/WebCore:
- Introduced the OriginLock for synchronizing write access to the database origin directory. This allows us to more accurately compute the disk usage.
The OriginLock uses a mutex to provide mutual exclusion between
threads and a file lock for mutual exclusion between processes.
The file lock part is conditional on USE(FILE_LOCK).
The mutex mutual exclusion also serves to ensure that only 1 thread
can write to a sqlite database at one time.
- Change the SQLTransactionCoordinator to only allow one write transaction to an origin instead of one write transaction per database. This is needed in order to accurately compute the disk usage. It is also necessary so that the OriginLock does not deadlock itself (as would be the case if concurrent write transactions to different databases in the same origin are allowed).
- Fix DatabaseTracker::getMaxSizeForDatabase() to check for when disk usage may exceed the quota, and ensure that we will return an appropriate max database size.
Disk usage can exceed the usage if it is already near the quota limit
but have not exceeded it yet. If a new database is opened in that
origin, it may bump the usage above the quota, but should not
continually repeat this. Subsequent attempts to open a database
will find that the quota is already exhausted and fail.
There is still a race condition pertaining to the tracker database
getting out of sync that may still enable runaway growth in the
database sizes. That issue only manifest in a multi-process
environment, and will be fixed in another changeset.
- Fixed a bug in SQLStatement to check if the errorCallback exists before invoking it.
No new layout tests. A quota-test.html was attached to bugzilla for manual
testing of multi-tab concurrent consumption of storage resource, and also
to test handling situations when the user deletes the database files while
the script is still using the database.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::originLockFor):
(WebCore::DatabaseTracker::deleteOriginLockFor):
(WebCore::DatabaseTracker::deleteOrigin):
- Modules/webdatabase/DatabaseTracker.h:
- Modules/webdatabase/OriginLock.cpp: Added.
(WebCore::OriginLock::lockFileNameForPath):
(WebCore::OriginLock::OriginLock):
(WebCore::OriginLock::~OriginLock):
(WebCore::OriginLock::lock):
(WebCore::OriginLock::unlock):
- Modules/webdatabase/OriginLock.h: Added.
- Modules/webdatabase/SQLStatement.cpp:
(WebCore::SQLStatement::performCallback):
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::computeNextStateAndCleanupIfNeeded):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):
(WebCore::SQLTransactionBackend::acquireOriginLock):
(WebCore::SQLTransactionBackend::releaseOriginLockIfNeeded):
- Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionBackend):
- Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::getDatabaseIdentifier):
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- config.h:
- platform/FileSystem.h:
- platform/posix/FileSystemPOSIX.cpp:
(WebCore::lockFile):
(WebCore::unlockFile):
LayoutTests:
- storage/websql/multiple-databases-garbage-collection.js:
- This test runs 2 transactions on 2 databases (1 each). The 2 databases are named "persistent" and "forgotten". The test executes the transaction on "persistent" first, but expects the transaction on "forgotten" to finish first. This is because "forgotten"'s transaction is a smaller one. The new changes to SQLTransactionCoordinator now ensures that a write transaction must completes before another is started for databases in the same origin. Hence, the previously expected result will no longer be true.
Regardless, the purpose of the test is not to test the order of
completion but that resources are reclaimed. So, I'm changing the test
to start the "forgotten" transaction first followed by the "persistent"
transaction. This ensures that the test will yield consistent results
even when run on ports that may allow more than one write transaction
to run at the same time.
- 7:29 AM Changeset in webkit [144759] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: move PopoverContentHelper from TimelinePresentationModel.js to Popover.js.
https://bugs.webkit.org/show_bug.cgi?id=111431
Reviewed by Yury Semikhatsky.
class WebInspector.TimelinePresentationModel.PopoverContentHelper was renamed to WebInspector.PopoverContentHelper.
Style names were changed accordingly.
- inspector/front-end/Popover.js:
(WebInspector.PopoverContentHelper):
(WebInspector.PopoverContentHelper.prototype.contentTable):
(WebInspector.PopoverContentHelper.prototype._createCell):
(WebInspector.PopoverContentHelper.prototype.appendTextRow):
(WebInspector.PopoverContentHelper.prototype.appendElementRow):
(WebInspector.PopoverContentHelper.prototype.appendStackTrace):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.generateMainThreadBarPopupContent):
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.generatePopupContentForFrame):
(WebInspector.TimelinePresentationModel.generatePopupContentForFrameStatistics):
- inspector/front-end/popover.css:
(.popover-details):
(.popover-function-name):
(.popover-stacktrace-title):
(.popover-details-row-title):
(.popover-details-row-data):
(.popover-details-title):
- inspector/front-end/timelinePanel.css:
- 7:00 AM Changeset in webkit [144758] by
-
- 3 edits in trunk/Tools
[Qt][MiniBrowser] Improve the update of touch indicators
https://bugs.webkit.org/show_bug.cgi?id=111429
Reviewed by Jocelyn Turcotte.
MiniBrowserApplication::sendTouchEvent sends an empty list
to BrowserWindow::updateVisualMockTouchPoints if the control
button is released, in which case the touch indicators should
be hidden so that we never end up with a leftover indicator
sticking on the screen.
This patch also simplifies the lookup of the indicator items by
replacing the findChild search in the item tree with a QHash
that stores the touch ID's and the pointers to the corresponding
indicator items.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
- MiniBrowser/qt/BrowserWindow.h:
(BrowserWindow):
- 6:54 AM Changeset in webkit [144757] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: remove "Live native memory chart" experiment
https://bugs.webkit.org/show_bug.cgi?id=111432
Reviewed by Alexander Pavlov.
Removed support for live native memory chart.
- English.lproj/localizedStrings.js:
- inspector/front-end/NativeMemorySnapshotView.js:
- inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/nativeMemoryProfiler.css:
- 6:09 AM Changeset in webkit [144756] by
-
- 10 edits in trunk
Web Inspector: remove length parameter from Parse HTML timeline event
https://bugs.webkit.org/show_bug.cgi?id=111421
Reviewed by Yury Semikhatsky.
Source/WebCore:
- remove length parameter in all instrumentation methods used to emit ParseHTML timeline event;
- drive-by style fixes.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::pumpTokenizer):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willWriteHTMLImpl):
(WebCore::InspectorInstrumentation::didWriteHTMLImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willWriteHTML):
(WebCore::InspectorInstrumentation::didWriteHTML):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willWriteHTML):
(WebCore::InspectorTimelineAgent::didWriteHTML):
- inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createParseHTMLData):
- inspector/TimelineRecordFactory.h:
(TimelineRecordFactory):
LayoutTests:
- removed length field from ParseHTML data in expectations.
- inspector/timeline/timeline-parse-html-expected.txt:
- 6:06 AM Changeset in webkit [144755] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: Add a renderer process memory size test.
https://bugs.webkit.org/show_bug.cgi?id=111337
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-05
Reviewed by Yury Semikhatsky.
The test checks that the renderer process memory size
is obtained from the browser and reported to the inspector
frontend correctly.
- src/js/Tests.js:
(.TestSuite.prototype.testRendererProcessNativeMemorySize.checkFuzzyValue):
(.TestSuite.prototype.testRendererProcessNativeMemorySize.step2):
- 5:58 AM Changeset in webkit [144754] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: allow each profiler panel to have own landing page
https://bugs.webkit.org/show_bug.cgi?id=111298
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-05
Reviewed by Yury Semikhatsky.
Refactor profiler landing page to allow different profiler panels to have own landing pages.
- MultiProfileLauncherView is inherited from ProfileLauncherView
- Native memory distribution profiler has got a custom page.
No new tests: code refactoring.
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype.get profile):
(WebInspector.HeapSnapshotView.prototype.get baseProfile):
(WebInspector.HeapSnapshotView.prototype._profiles):
- inspector/front-end/NativeMemorySnapshotView.js:
- inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView):
(WebInspector.ProfileLauncherView.prototype.addProfileType):
(WebInspector.ProfileLauncherView.prototype._controlButtonClicked):
(WebInspector.ProfileLauncherView.prototype._updateControls):
(WebInspector.ProfileLauncherView.prototype.profileStarted):
(WebInspector.ProfileLauncherView.prototype.profileFinished):
(WebInspector.MultiProfileLauncherView):
(WebInspector.MultiProfileLauncherView.prototype.addProfileType):
(WebInspector.MultiProfileLauncherView.prototype._profileTypeChanged):
(WebInspector.NativeProfileLauncherView):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._createLauncherView):
(WebInspector.CPUProfilerPanel):
(WebInspector.CSSSelectorProfilerPanel):
(WebInspector.HeapProfilerPanel):
(WebInspector.CanvasProfilerPanel):
(WebInspector.MemoryChartProfilerPanel):
(WebInspector.MemoryChartProfilerPanel.prototype._createLauncherView):
(WebInspector.NativeMemoryProfilerPanel):
- inspector/front-end/profilesPanel.css:
(.panel-enabler-view.profile-launcher-view button:not(.status-bar-item)):
- 5:33 AM Changeset in webkit [144753] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Clarify some StylesSidebarPanel and CSSMetadata JSDocs.
https://bugs.webkit.org/show_bug.cgi?id=111427
Reviewed by Alexander Pavlov.
Goal: reflect in JSDoc that non-null array is passed to completionsReady callback.
- inspector/front-end/CSSMetadata.js:
Added JSDocs, avoided possible NPEs.
- inspector/front-end/StylesSidebarPane.js:
Fixed JSDocs, removed unused assignment.
- 5:29 AM Changeset in webkit [144752] by
-
- 21 edits in trunk
[WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
https://bugs.webkit.org/show_bug.cgi?id=81042
Reviewed by Enrica Casucci.
Source/WebKit2:
Expose WK2 setting to enable/disabled asynchronous spell checking.
It's used by WebKitTestRunner to reset the setting at the beginning
of the test.
WebKit2 ports might be interested in this setting if they are going
to enable this feature.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAsynchronousSpellCheckingEnabled):
(WKPreferencesGetAsynchronousSpellCheckingEnabled):
- UIProcess/API/C/WKPreferences.h:
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetAsynchronousSpellCheckingEnabled):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setAsynchronousSpellCheckingEnabled):
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
Add setAsynchronousSpellCheckingEnabled implementation for
WebKitTestRunner to have the possibility to test asynchronous
spell checking implementation from bug 109577.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
LayoutTests:
Gardening of the asynchronous spell checking tests.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
Some tests need to be skipped as they require features not
implemented for EFL yet (pasteboard, grammar checking, text replacement).
- platform/gtk-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/qt-5.0-wk2/TestExpectations:
Skip asynchronous spell checking for GTK+, Mac, Qt unless
they implement TextChecker::requestCheckingOfText.
- platform/wk2/TestExpectations:
Remove asynchronous spell checking tests from global wk2's
as they are passing for EFL.
- 5:29 AM Changeset in webkit [144751] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r144727): Change type of columnRange and rowRange to pair<unsigned, unsigned>
<http://webkit.org/b/110050>
Fixes the following build failures:
Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:741:30: error: non-const lvalue reference to type 'pair<unsigned int, unsigned int>' cannot bind to a value of unrelated type 'pair<int, int>'
tableCell->rowIndexRange(rowRange);
~
In file included from Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:33:
Source/WebCore/accessibility/AccessibilityTableCell.h:47:58: note: passing argument to parameter 'rowRange' here
virtual void rowIndexRange(pair<unsigned, unsigned>& rowRange);
Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:742:33: error: non-const lvalue reference to type 'pair<unsigned int, unsigned int>' cannot bind to a value of unrelated type 'pair<int, int>'
tableCell->columnIndexRange(columnRange);
In file included from Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:33:
Source/WebCore/accessibility/AccessibilityTableCell.h:49:61: note: passing argument to parameter 'columnRange' here
virtual void columnIndexRange(pair<unsigned, unsigned>& columnRange);
Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:804:30: error: non-const lvalue reference to type 'pair<unsigned int, unsigned int>' cannot bind to a value of unrelated type 'pair<int, int>'
tableCell->rowIndexRange(rowRange);
~
In file included from Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:33:
Source/WebCore/accessibility/AccessibilityTableCell.h:47:58: note: passing argument to parameter 'rowRange' here
virtual void rowIndexRange(pair<unsigned, unsigned>& rowRange);
Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:818:33: error: non-const lvalue reference to type 'pair<unsigned int, unsigned int>' cannot bind to a value of unrelated type 'pair<int, int>'
tableCell->columnIndexRange(columnRange);
In file included from Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:33:
Source/WebCore/accessibility/AccessibilityTableCell.h:49:61: note: passing argument to parameter 'columnRange' here
virtual void columnIndexRange(pair<unsigned, unsigned>& columnRange);
4 errors generated.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityHeaderElements]):
(-[WebAccessibilityObjectWrapper accessibilityRowRange]):
(-[WebAccessibilityObjectWrapper accessibilityColumnRange]):
- 5:00 AM FeatureFlags edited by
- FONT_LOAD_EVENTS (diff)
- 4:53 AM Changeset in webkit [144750] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Clean up animated scroll/zoom code in WebPagePrivate
https://bugs.webkit.org/show_bug.cgi?id=111373
Patch by Andrew Lo <anlo@rim.com> on 2013-03-05
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.
Internal PR 285468.
Have WebPageClient pass the final scale and position to WebPage when a zoom/scroll
animation finishes, rather than keeping those values as instance variables in
WebPagePrivate.
Rename some functions & variables to reflect that they are used for both block zoom
and generic zoom/scroll animations.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
(BlackBerry::WebKit::WebPage::zoomAnimationFinished):
(BlackBerry::WebKit::WebPagePrivate::resetBlockZoom):
(BlackBerry::WebKit::WebPage::blockZoom):
(BlackBerry::WebKit::WebPagePrivate::animateToScaleAndDocumentScrollPosition):
- Api/WebPage.h:
- Api/WebPageClient.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- 4:23 AM Changeset in webkit [144749] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [refactoring] set frame identifiers in timeline records early, do not keep them in event stack
https://bugs.webkit.org/show_bug.cgi?id=111345
Reviewed by Pavel Feldman.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::setFrameIdentifier):
(WebCore):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::commitFrameRecord):
- inspector/InspectorTimelineAgent.h:
(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
(TimelineRecordEntry):
(InspectorTimelineAgent):
- 4:17 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:34 AM Changeset in webkit [144748] by
-
- 16 edits in trunk
MediaStream API: Add the getStreamById method on RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=111311
Reviewed by Adam Barth.
Source/Platform:
Added an initial initialize method which doesn't take an id;
the id will be generated for you.
- chromium/public/WebMediaStream.h:
(WebMediaStream):
Source/WebCore:
Adding the missing method on RTCPeerConnection defined here:
http://dev.w3.org/2011/webrtc/editor/webrtc.html#widl-RTCPeerConnection-getStreamById-MediaStream-DOMString-streamId
Existing tests have been extended to cover patch.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::getStreamById):
(WebCore):
- Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
- Modules/mediastream/RTCPeerConnection.idl:
- platform/chromium/support/WebMediaStream.cpp:
(WebKit::WebMediaStream::initialize):
(WebKit):
- platform/mediastream/MediaStreamSource.cpp:
(WebCore::MediaStreamSource::setReadyState):
Tools:
Changing mocks to be more realistic.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
(WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
(WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
- DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
(WebTestRunner::WebUserMediaClientMock::requestUserMedia):
LayoutTests:
- fast/mediastream/MediaStream-add-remove-tracks.html:
- fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt:
- fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
- 3:31 AM Changeset in webkit [144747] by
-
- 5 edits3 adds in trunk
Web Inspector: allow retrieval of composited layers in a given DOM subtree
https://bugs.webkit.org/show_bug.cgi?id=111312
Source/WebCore:
Introduce the LayerTreeAgent.layersForNode(node) method allowing the front-end
to gather all composited layers associated with nodes in the subtree of which
the provided node is the root.
In order to gather the layers in the subtree, we first traverse the node's
renderer's RenderObject hierarchy and whenever we encounter a RenderObject
that has a RenderLayer, we then traverse that renderLayer's RenderLayer
hierarchy. This allows for a quick path through the relevant objects we're
gathering.
Layers gathered will push the node to which they're associated, allowing a
nodeId for this layer to be listed in the Layer object sent to the front-end.
It is crucial to be able to provide a nodeId as well as a layerId for a Layer
object in order to be able to correctly assess mutations in the layer tree.
For instance, it is expected that a node's layer be replaced by a new layer
to represent a slightly different rendering of its content, but the front-end
should be able to represent this layer as an object for which only certain
attributes have changed (like the "paintCount" property).
Layer objects also indicate whether they're associated to a node hosted in a
shadow tree (the optional "isInShadowTree" property) in order for the front-end
to be able to only show this layer if the option to show nodes hosted in shadow
tree is enabled.
Finally, since we're only gathering composited layers, we're removing the
"isLayerComposited" property and removing the optional flag on the "paintCount",
"memory" and "compositedBounds" properties.
Reviewed by Simon Fraser.
Test: inspector-protocol/layers/layers-for-node.html
- inspector/Inspector.json:
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::layersForNode):
(WebCore):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderObjectHierarchy):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderLayerHierarchy):
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
(WebCore::InspectorLayerTreeAgent::idForNode):
- inspector/InspectorLayerTreeAgent.h:
(InspectorLayerTreeAgent):
LayoutTests:
New test for the LayerTree.layersForNode() method.
Reviewed by Simon Fraser.
- inspector-protocol/layers/layers-for-node-expected.txt: Added.
- inspector-protocol/layers/layers-for-node.html: Added.
- 2:53 AM Changeset in webkit [144746] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: use timestamps consistent with rest of Timeline in WebSocket events.
https://bugs.webkit.org/show_bug.cgi?id=111344
- create web socket related records in a manner consistent with the rest of timeline.
Reviewed by Pavel Feldman.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCreateWebSocket):
(WebCore::InspectorTimelineAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorTimelineAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorTimelineAgent::didDestroyWebSocket):
- inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
- 2:38 AM Changeset in webkit [144745] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL] Add requestCheckingOfString implementation.
https://bugs.webkit.org/show_bug.cgi?id=108172
Reviewed by Hajime Morrita.
Provide implementation of 'requestCheckingOfString' for WK2-EFL.
It uses the unified text checker feature.
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::TextChecker::requestCheckingOfString):
- 2:27 AM Changeset in webkit [144744] by
-
- 6 edits2 adds in trunk
[CSS Regions] Crash when MathML used in CSS Regions
https://bugs.webkit.org/show_bug.cgi?id=110686
Reviewed by David Hyatt.
Source/WebCore:
The MathML blocks trigger a children layout when computing the preferred widths. This happens to determine the preferred
logical heights of the children. When the layout reaches the line boxes computation the preferred width of the containing block
is requested. Because it wasn't computed, the layout of the children is started again to determine the preferred logical heights.
This causes an infinite recursion and triggers a stack overflow.
The patch introduces a new RAII utility class that disables fragmentation when the constructor is called and restores it
on the destructor. This class is used when computing the preferred height for the children of a MathML block.
Test: fast/regions/mathml-crash.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::setFlowThreadStateIncludingDescendants): Do not cross RenderFlowThread boundaries when updating the flow thread
state flag. The innermost flow threads need to manage their descendants flag values.
- rendering/RenderView.cpp:
(WebCore::FragmentationDisabler::FragmentationDisabler):
(WebCore):
(WebCore::FragmentationDisabler::~FragmentationDisabler):
- rendering/RenderView.h:
(FragmentationDisabler):
(WebCore):
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::computeChildrenPreferredLogicalHeights):
LayoutTests:
Add a test to verify regions and MathML do not crash.
- fast/regions/mathml-crash-expected.txt: Added.
- fast/regions/mathml-crash.html: Added.
- 2:05 AM Changeset in webkit [144743] by
-
- 10 edits2 adds in trunk/Source/WebCore
Cleanup: Move HitTestLocation and HitTestResult into separate files.
https://bugs.webkit.org/show_bug.cgi?id=111294
Reviewed by Allan Sandfeld Jensen.
HitTestLocation and HitTestResult currently both live in
HitTestResult.h. That makes things more difficult to understand than
they should be, and violates the one-class-one-file principle that
WebKit generally follows. Happily, it's fairly trivial to fix.
This should have no visible change; it's strictly an internal
refactoring. It doesn't even touch any implementation code: we're
just moving bits from one place to another.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Hey, look: a new file! Let's add it to six different build systems! :)
- rendering/HitTestLocation.cpp: Added.
(WebCore):
(WebCore::HitTestLocation::HitTestLocation):
(WebCore::HitTestLocation::~HitTestLocation):
(WebCore::HitTestLocation::operator=):
(WebCore::HitTestLocation::move):
(WebCore::HitTestLocation::intersectsRect):
(WebCore::HitTestLocation::intersects):
(WebCore::HitTestLocation::rectForPoint):
- rendering/HitTestLocation.h: Added.
(WebCore):
(HitTestLocation):
(WebCore::HitTestLocation::point):
(WebCore::HitTestLocation::roundedPoint):
(WebCore::HitTestLocation::region):
(WebCore::HitTestLocation::isRectBasedTest):
(WebCore::HitTestLocation::isRectilinear):
(WebCore::HitTestLocation::boundingBox):
(WebCore::HitTestLocation::topPadding):
(WebCore::HitTestLocation::rightPadding):
(WebCore::HitTestLocation::bottomPadding):
(WebCore::HitTestLocation::leftPadding):
(WebCore::HitTestLocation::transformedPoint):
(WebCore::HitTestLocation::transformedRect):
- rendering/HitTestResult.cpp:
- rendering/HitTestResult.h:
Move all this code from HitTestResult.* to HitTestLocation.*.
- rendering/RenderBlock.cpp:
Include HitTestLocation.h.
- 1:30 AM Changeset in webkit [144742] by
-
- 5 edits in trunk/Source/WebCore
Refactor UserGestureIndicator::Token to be a top-level class
https://bugs.webkit.org/show_bug.cgi?id=111412
Reviewed by Nico Weber.
This will allow for forward declaring the class in a public WebKit
API header. The goal is to enable the embedder to hold on to a
UserGestureToken.
- dom/UserGestureIndicator.cpp:
(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::currentToken):
- dom/UserGestureIndicator.h:
(UserGestureToken):
(WebCore::UserGestureToken::~UserGestureToken):
(WebCore):
(UserGestureIndicator):
- page/DOMTimer.h:
(DOMTimer):
- page/EventHandler.h:
- 1:15 AM Changeset in webkit [144741] by
-
- 2 edits in trunk/Source/WebCore
Remove redundant code in Document::updateHoverActiveState.
https://bugs.webkit.org/show_bug.cgi?id=111303
Reviewed by Darin Adler.
Document::updateHoverActiveState currently looks for touchrelease events
and explictly clears out the hover state for all nodes between the
currently hovered node and the top of the hover chain. This is actually
redundant with the logic in the rest of the function; we can simplify by
setting the Element* we're working with to 0, which causes the later
loops to do the necessary work.
There should be no web-visible effect from this change; it should simply
make this function less complex.
Extracted from Allan Sandfeld Jensen's original patch to wkbug.com/98168
- dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
Set innerElementInDocument to 0 rather than walking the hover chain
and clearing it when we see a touchrelease event. The rest of the
code in this function will have the same effect.
- 1:03 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:02 AM Changeset in webkit [144740] by
-
- 8 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r144652 - [GTK] Some WebKit2 GTK+ unit tests are failing in 32 bits bot
https://bugs.webkit.org/show_bug.cgi?id=111346
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-04
Reviewed by Martin Robinson.
The problem is the use of a temporary CString object in the macro
g_assert_cmpstr. It's a common mistake because we usually forget
that g_assert_cmpstr is not a function but a macro, that expands
to multiple lines. This patch adds a new macro ASSERT_CMP_CSTRING
with the same implementation that g_assert_cmpstr, but using
CStrings instead of const char*. It fixes all the cases where a
temporary CString was used in g_assert_cmpstr, and uses the new
macro also for the cases where we were caching the CString just
for g_assert_cmpstr.
- UIProcess/API/gtk/tests/TestDownloads.cpp:
(testDownloadRemoteFile):
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(testInspectorServerPageList):
- UIProcess/API/gtk/tests/TestLoaderClient.cpp:
- UIProcess/API/gtk/tests/TestMain.h:
- UIProcess/API/gtk/tests/TestResources.cpp:
- UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(testGetFaviconURI):
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(assertThatUserAgentIsSentInHeaders):
(testWebKitSettingsUserAgent):
- 12:46 AM Changeset in webkit [144739] by
-
- 2 edits in trunk/Tools
Add content shell bots to garden-o-matic for general failurse
https://bugs.webkit.org/show_bug.cgi?id=111168
Reviewed by Adam Barth.
All but the WebKit (Content Shell) Android bot is stable enough. While
they're not green yet, there must not be any non-layout test failures on
them.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
(.):
- 12:31 AM Changeset in webkit [144738] by
-
- 2 edits in trunk/Source/WebCore
[V8] Remove unused custom indexedPropertyGetter
https://bugs.webkit.org/show_bug.cgi?id=111409
Patch by Koji Hara <kojih@chromium.org> on 2013-03-05
Reviewed by Kentaro Hara.
Remove unused custom indexedPropertyGetter.
There are 9 custom indexedPropertyGetter, including an unused one(NamedNodeMap).
This commit assures all existing custom indexedPropertyGetter(for V8) are used.
No new tests. Simple refactoring.
- bindings/v8/custom/V8NamedNodeMapCustom.cpp: Remove indexedPropertyGetter
- 12:30 AM Changeset in webkit [144737] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening.
Skip failing tests on EFL bots.
- platform/efl/TestExpectations:
- 12:14 AM Changeset in webkit [144736] by
-
- 2 edits in trunk/LayoutTests
Unreviewed; updating test expectations.
fast/regions/seamless-iframe-flowed-into-regions.html is failing not only with debug build.
- platform/chromium/TestExpectations:
- 12:08 AM Changeset in webkit [144735] by
-
- 14 edits in trunk/Source/WebCore
ShadowRoot needs guardRef() and guardDeref()
https://bugs.webkit.org/show_bug.cgi?id=109777
Reviewed by Dimitri Glazkov.
This change moves m_guardRefCount from Document to TreeScope,
which allows ShadowRoot to be guarded by guardRef() mechanism as
Document. After r137524, Node referes TreeScope instead of
Document. This is natural consequence of the change: It no longer
makes sense to guardRef() Document pointer from Node.
Detail:
- Document::m_guardRefCount and related funcdtions are moved to TreeScope
- Document::removedLastRef is factored out into TreeScope::removedLastRefToScope(), TreeScope::dispose() and Docuent::dispose(). ShadowRoot also got its own dispose() implementation.
- Moved guardRef() and guardDeref() calls to TreeScope and Node. Note that there are two "guarded" TreeScope references. One is Node::m_treeScope and another is TreeScope::m_parentTreeScope. The guarded-ref management is now encapsulated in these two classes.
No new tests. Covered by existing tests.
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::dispose): Extracted from removedLastRef()
- dom/Document.h:
(WebCore::Node::isTreeScope):
(WebCore::Node::Node):
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::DocumentFragment): Remove ASSERT() and move it to ...
(WebCore::DocumentFragment::create): ... here, to allow NULL document from ShadowRoot.
- dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::removedLastRef):
- dom/Node.h:
(WebCore::Node::setTreeScope):
- dom/Element.cpp:
(WebCore::Element::ensureAttr): This has been wrong and is fixed in this revision since the incorrectness is unveiled by this change.
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot): Passed NULL document to superclass. This aligns what Document is doing.
(WebCore::ShadowRoot::dispose): Added.
- dom/ShadowRoot.h:
(ShadowRoot):
- dom/TreeScope.cpp:
(SameSizeAsTreeScope):
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::dispose): Added.
(WebCore::TreeScope::setParentTreeScope):
(WebCore::TreeScope::deletionHasBegun):
(WebCore::TreeScope::beginDeletion):
(WebCore::TreeScope::refCount): Added.
- dom/TreeScope.h: Turned m_rootNode to Node* from ContainerNode* for Node::isTreeScope to be inlined.
(WebCore::TreeScope::guardRef): Pulled up from Document.
(WebCore::TreeScope::guardDeref): Ditto.
(WebCore::TreeScope::hasGuardRefCount): Added to hide m_guardRefCount.
(WebCore::TreeScope::deletionHasBegun): Added.
(WebCore::TreeScope::beginDeletion): Added.
(WebCore::TreeScope::removedLastRefToScope): Pulled up from Document.
- dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
Mar 4, 2013:
- 11:59 PM Changeset in webkit [144734] by
-
- 2 edits in trunk/LayoutTests
2013-03-04 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, adding crashing test to the expectations.
- platform/chromium/TestExpectations:
- 11:56 PM Changeset in webkit [144733] by
-
- 2 edits in trunk/Tools
[chromium] remove deprecated WebTestRunner::setFocus API
https://bugs.webkit.org/show_bug.cgi?id=111354
Reviewed by James Robinson.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestDelegate):
- 11:44 PM Changeset in webkit [144732] by
-
- 3 edits2 adds in trunk
getPropertyValue for -webkit-text-stroke returns null, should compute the shorthand value
https://bugs.webkit.org/show_bug.cgi?id=111018
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-03-04
Reviewed by Alexander Pavlov.
Source/WebCore:
Test: fast/css/getPropertyValue-webkit-text-stroke.html
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
LayoutTests:
Added test for getPropertyValue("-webkit-text-stroke").
- fast/css/getPropertyValue-webkit-text-stroke-expected.txt: Added.
- fast/css/getPropertyValue-webkit-text-stroke.html: Added.
- 11:42 PM Changeset in webkit [144731] by
-
- 7 edits in trunk/Tools
Run the bindings generation tests on EWS and CQ bots
https://bugs.webkit.org/show_bug.cgi?id=111358
Reviewed by Adam Barth.
The tests are super fast and not flaky.
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.run_bindings_tests_command):
- Scripts/webkitpy/common/config/ports_mock.py:
(MockPort.run_webkit_tests_command):
(MockPort):
(MockPort.run_bindings_tests_command):
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- Scripts/webkitpy/tool/steps/runtests_unittest.py:
(RunTestsTest.test_webkit_run_unit_tests):
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- 11:33 PM Changeset in webkit [144730] by
-
- 3 edits2 adds in trunk
getPropertyValue for -webkit-columns returns null, should compute the shorthand value
https://bugs.webkit.org/show_bug.cgi?id=111011
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-03-04
Reviewed by Alexander Pavlov.
Source/WebCore:
Test: fast/css/getPropertyValue-columns.html
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
LayoutTests:
Added test for getPropertyValue("-webkit-columns").
- fast/css/getPropertyValue-columns-expected.txt: Added.
- fast/css/getPropertyValue-columns.html: Added.
- 11:31 PM Changeset in webkit [144729] by
-
- 5 edits in trunk
Web Inspector: Do not accumulate file system files, add them to workspace immediately
https://bugs.webkit.org/show_bug.cgi?id=111325
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate.prototype.populate.fileLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):
- inspector/front-end/IsolatedFileSystem.js:
(WebInspector.IsolatedFileSystem.prototype.innerCallback):
(WebInspector.IsolatedFileSystem.prototype.requestFilesRecursive):
LayoutTests:
- inspector/file-system-project.html:
- 11:20 PM Changeset in webkit [144728] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Windows build fix attempt.
floor method is ambigious so explicitly specify the type.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):
- 11:13 PM Changeset in webkit [144727] by
-
- 16 edits2 adds in trunk
AX: cellForColumnAndRow fails for tables with hidden table cells
https://bugs.webkit.org/show_bug.cgi?id=110050
Reviewed by Tim Horton.
Source/WebCore:
If a table had hidden cells, then accessibility code was being confused in a few ways.
1) The cellForColumnAndRow method would return the wrong information since that was
using the RenderTableSection to retrieve a cell, which did not have the same data as the AXTable
2) The way we were adding children made it impossible to determine column and row range because we
would skip rows that had hidden children
3) AccessibilityARIAGrid and AccessibilityTable were using different methods for cellForColumnAndRow
The fix does a few things to make things right:
1) Always add an accessibility row, even if there are no visible cells in that row.
2) Have one method for AXTable and AXARIAGrid for cellForColumnAndRow.
3) Change cellForColumnAndRow to query the accessibility children rather than the RenderTableSection in determining the row, col info.
4) cellForColumnAndRow should use unsigned values instead of int values.
Test: accessibility/table-with-hidden-head-section.html
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore):
- accessibility/AccessibilityARIAGrid.h:
(AccessibilityARIAGrid):
- accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::rowIndexRange):
(WebCore::AccessibilityARIAGridCell::columnIndexRange):
- accessibility/AccessibilityARIAGridCell.h:
(AccessibilityARIAGridCell):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::cellForColumnAndRow):
- accessibility/AccessibilityTable.h:
(WebCore):
(AccessibilityTable):
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::rowIndexRange):
(WebCore::AccessibilityTableCell::columnIndexRange):
- accessibility/AccessibilityTableCell.h:
(AccessibilityTableCell):
- accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(webkitAccessibleTableGetColumnAtIndex):
(webkitAccessibleTableGetRowAtIndex):
(webkitAccessibleTableGetColumnExtentAt):
(webkitAccessibleTableGetRowExtentAt):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- rendering/RenderTableSection.h:
(RenderTableSection):
(WebCore::RenderTableSection::rowRendererAt):
Source/WebKit/chromium:
- src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::cellColumnIndex):
(WebKit::WebAccessibilityObject::cellColumnSpan):
(WebKit::WebAccessibilityObject::cellRowIndex):
(WebKit::WebAccessibilityObject::cellRowSpan):
LayoutTests:
- accessibility/table-with-hidden-head-section-expected.txt: Added.
- accessibility/table-with-hidden-head-section.html: Added.
- platform/chromium/TestExpectations:
- 10:57 PM Changeset in webkit [144726] by
-
- 3 edits2 adds in trunk
getAttribute does not behave correctly for mixed-case attributes on HTML elements
https://bugs.webkit.org/show_bug.cgi?id=105713
Patch by Arpita Bahuguna <a.bah@samsung.com> on 2013-03-04
Reviewed by Andreas Kling.
Source/WebCore:
getAttribute() and getAttributeNode() APIs do not convert the
passed attribute name to lowercase before comparing against the
existing attributes.
The specification however states that the passed name should
be converted to ASCII lowercase before checking for the existence
of the given attribute. [www.w3.org/TR/domcore/#dom-element-getattribute]
Test: fast/dom/Element/getAttribute-case-insensitivity.html
- dom/Element.h:
(WebCore::ElementData::getAttributeItemIndex):
getAttributeItemIndex() accepts a bool param 'shouldIgnoreAttributeCase'
which specifies whether the attribute's case should be ignored
before comparison. But inspite of this param's value we still carry
out a case sensitive search.
Have modified the same to convert the passed attribute's name to
lowercase if 'shouldIgnoreAttributeCase' is true.
LayoutTests:
- fast/dom/Element/getAttribute-case-insensitivity-expected.txt: Added.
- fast/dom/Element/getAttribute-case-insensitivity.html: Added.
Layout test added for verifying that getAttribute() and getAttributeNode()
APIs convert the passed attribute name to lowercase before comparing
against the existing attributes.
- 10:35 PM Changeset in webkit [144725] by
-
- 7 edits in trunk/Source
[Chromium] Add runtime flag for font load events
https://bugs.webkit.org/show_bug.cgi?id=111296
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-04
Reviewed by Kent Tamura.
Add a runtime feature flag for FontLoader interface (disabled by default),
and enable ENABLE_FONT_LOAD_EVENTS build flag for chromium.
Source/WebCore:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setFontLoadEventsEnabled):
(WebCore::RuntimeEnabledFeatures::fontLoadEventsEnabled):
Source/WebKit/chromium:
- features.gypi:
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableFontLoadEvents):
(WebKit):
(WebKit::WebRuntimeFeatures::isFontLoadEventsEnabled):
- 10:31 PM Changeset in webkit [144724] by
-
- 5 edits in trunk/LayoutTests
[V8] Add LayoutTests for SerializedScriptValue Int32/Uint32 cases
https://bugs.webkit.org/show_bug.cgi?id=111364
Reviewed by Kentaro Hara.
A lack of layout tests for SerializedScriptValue special cases let
crbug.com/179280 slip in and out un-noticed. Rectify the situation.
- platform/chromium/fast/storage/serialized-script-value-expected.txt:
- platform/chromium/fast/storage/serialized-script-value.html:
- storage/indexeddb/structured-clone-expected.txt:
- storage/indexeddb/structured-clone.html:
- 10:14 PM Changeset in webkit [144723] by
-
- 15 edits3 copies3 adds in trunk
WEBGL_compressed_texture_atc implementation
https://bugs.webkit.org/show_bug.cgi?id=110496
Patch by Brandon Jones <bajones@google.com> on 2013-03-04
Reviewed by Kenneth Russell.
Source/WebCore:
Test: webgl/conformance/extensions/webgl-compressed-texture-atc.html
Exposes the WEBGL_compressed_texture_atc extension, but is unverified since no desktop hardware supports
the format that I am aware of. Should enable mobile ports to expose the format, however.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- html/canvas/WebGLCompressedTextureATC.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebCore::WebGLCompressedTextureATC::WebGLCompressedTextureATC):
(WebCore::WebGLCompressedTextureATC::~WebGLCompressedTextureATC):
(WebCore::WebGLCompressedTextureATC::getName):
(WebCore::WebGLCompressedTextureATC::create):
(WebCore::WebGLCompressedTextureATC::supported):
- html/canvas/WebGLCompressedTextureATC.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebGLCompressedTextureATC):
- html/canvas/WebGLCompressedTextureATC.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):
- html/canvas/WebGLRenderingContext.h:
(WebCore):
(WebGLRenderingContext):
- platform/graphics/Extensions3D.h:
LayoutTests:
- webgl/conformance/extensions/webgl-compressed-texture-atc-expected.txt: Added.
- webgl/conformance/extensions/webgl-compressed-texture-atc.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-atc.html: Added.
- 10:12 PM Changeset in webkit [144722] by
-
- 3 edits2 adds in trunk
Web Inspector: Exceptions when WebInspector run in hosted mode.
https://bugs.webkit.org/show_bug.cgi?id=111326
Reviewed by Pavel Feldman.
Source/WebCore:
There is bug in commands code generation in InspectorBackend.js
As a consequence all protocol enums have wrong names and cause
exception when refererenced.
Currently protocol enums are referenced only from NetworkManager.
Test: inspector/inspector-backend-commands-generation.html
- inspector/front-end/InspectorBackend.js:
(InspectorBackendClass.prototype.loadFromJSONIfNeeded):
Use static method to generate code.
(InspectorBackendClass._generateCommands):
Extracted from loadFromJSONIfNeeded. Typo fixed.
LayoutTests:
Test runtime commands code generator output.
- inspector/inspector-backend-commands-generation-expected.txt: Added.
- inspector/inspector-backend-commands-generation.html: Added.
- 10:09 PM Changeset in webkit [144721] by
-
- 1 copy in tags/Safari-536.29.1
New Tag.
- 10:04 PM Changeset in webkit [144720] by
-
- 12 edits in trunk/Source
Source/Platform: Add audio hardware support for multi-channel by implementing AudioDestinationNode.maxChannelCount
https://bugs.webkit.org/show_bug.cgi?id=111385
Reviewed by James Robinson.
- chromium/public/Platform.h:
(WebKit::Platform::audioHardwareOutputChannels):
Source/WebCore: Add audio hardware support for multi-channel output by implementing AudioDestinationNode.maxChannelCount
https://bugs.webkit.org/show_bug.cgi?id=111385
Reviewed by James Robinson.
See specification details for .maxChannelCount:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioDestinationNode
- Modules/webaudio/AudioDestinationNode.h:
(WebCore::AudioDestinationNode::maxChannelCount):
- Modules/webaudio/AudioDestinationNode.idl:
- Modules/webaudio/AudioNode.h:
Implement .maxChannelCount attribute.
(AudioNode):
- Modules/webaudio/DefaultAudioDestinationNode.h:
- Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::initialize):
(WebCore::DefaultAudioDestinationNode::createDestination):
(WebCore::DefaultAudioDestinationNode::enableInput):
Call to createDestination() now takes no argument.
Instead we maintain a member variable for the input device ID.
(WebCore::DefaultAudioDestinationNode::maxChannelCount):
(WebCore::DefaultAudioDestinationNode::setChannelCount):
Check port-specific hardware support for maxChannelCount(),
and allow setting the channel count based on what the hardware
supports.
- platform/audio/AudioDestination.h:
(AudioDestination):
- platform/audio/chromium/AudioDestinationChromium.cpp:
(WebCore::AudioDestination::maxChannelCount):
(WebCore::AudioDestinationChromium::render):
Call into chromium WebKit API: audioHardwareOutputChannels().
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestination::maxChannelCount):
Add basic implementation for maxChannelCount() only supporting stereo output.
- platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::maxChannelCount):
Add basic implementation for maxChannelCount() only supporting stereo output.
Later, the mac port can support more than this with some small improvements to AudioDestinationMac.
- 9:55 PM Changeset in webkit [144719] by
-
- 2 edits in trunk/Tools
run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
https://bugs.webkit.org/show_bug.cgi?id=111384
Reviewed by Ryosuke Niwa.
Sometimes I want to know why various LayoutTests are slow
without having to convert them into PerformanceTests in order
to use our fancy profiling. The Driver already knows how to
do the right thing, we just need to expose the options to the user.
Handling of these options is already unittested in the perftests_unittest.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 9:31 PM Changeset in webkit [144718] by
-
- 2 edits in branches/chromium/1410/Source/WebCore
Merge 144437
Web Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
https://bugs.webkit.org/show_bug.cgi?id=111077
Reviewed by Pavel Feldman.
Analysis: DataGridNode.refresh removes all cells and then recreates them.
The issue is that mandatory "corner" cell is not recreated.
- inspector/front-end/DataGrid.js:
(WebInspector.DataGridNode.prototype.refresh):
Added "corner" cell restoration code.
TBR=eustas@chromium.org
Review URL: https://codereview.chromium.org/12414004
- 9:27 PM Changeset in webkit [144717] by
-
- 2 edits in trunk/Source/WebKit/mac
BUILD FIX (r144662): Import JSBase.h in WebFrameLoadDelegate.h
<http://webkit.org/b/111269>
Fixes the following build failure:
In file included from Source/WebKit/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.m:11:
In file included from Source/WebKit/mac/WebView/WebFrameLoadDelegatePrivate.h:29:
Source/WebKit/mac/WebView/WebFrameLoadDelegate.h:41:5: error: 'JSC_OBJC_API_ENABLED' is not defined, evaluates to 0 [-Werror,-Wundef]
#if JSC_OBJC_API_ENABLED
Source/WebKit/mac/WebView/WebFrameLoadDelegate.h:207:5: error: 'JSC_OBJC_API_ENABLED' is not defined, evaluates to 0 [-Werror,-Wundef]
#if JSC_OBJC_API_ENABLED
2 errors generated.
- WebView/WebFrameLoadDelegate.h: Include JSBase.h.
- 9:24 PM Changeset in webkit [144716] by
-
- 3 edits2 adds in trunk/Tools
check-webkit-style says "Have to enable auto props in the subversion config file"
https://bugs.webkit.org/show_bug.cgi?id=107724
Patch by Alan Cutter <alancutter@chromium.org> on 2013-03-04
Reviewed by Tony Chang.
Added a standard svn config file for WebKit developers to use.
Updated the style and commit queue bot build scripts to load this file.
- EWSTools/GoogleComputeEngine/build-commit-queue.sh:
- EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
- EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
- svn-config: Added.
- 9:23 PM Changeset in webkit [144715] by
-
- 19 edits in trunk/LayoutTests
Rebaseline 4 virtual/softwarecompositing tests.
Unreviewed rebaseline of test expectations.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
- 8:57 PM Changeset in webkit [144714] by
-
- 6 edits2 adds in trunk
Background HTML parser can rewind the tokenizer after end-of-file
https://bugs.webkit.org/show_bug.cgi?id=111365
Reviewed by Eric Seidel.
Source/WebCore:
Prior to this patch, it was possible to call didFailSpeculation after
processing the end-of-file token because checkForSpeculationFailure
didn't zero out m_tokenizer in some control paths.
This patch renames checkForSpeculationFailure to validateSpeculations
and ensures that it always takes ownership of the main thread's
HTMLTokenizer.
This patch also adds a number of ASSERTs to make sure the parser state
machine stays in the correct configuration (e.g., that we don't have a
main thread tokenizer while we're supposed to be tokenizing on the
background thread).
Test: fast/parser/document-write-fighting-eof.html
- html/parser/BackgroundHTMLInputStream.cpp:
(WebCore::BackgroundHTMLInputStream::rewindTo):
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::append):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::validateSpeculations):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
LayoutTests:
- fast/parser/document-write-fighting-eof.html: Added.
- 8:37 PM Changeset in webkit [144713] by
-
- 3 edits2 adds in trunk
Make sure that clearOwnerNode also clears StyleResolver references (via didMutate).
https://bugs.webkit.org/show_bug.cgi?id=109446
Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-03-04
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/css/stylesheet.innerHTML-calls-didmutate.html
- css/CSSStyleSheet.h:
LayoutTests:
- fast/css/stylesheet.innerHTML-calls-didmutate-expected.txt: Added.
- fast/css/stylesheet.innerHTML-calls-didmutate.html: Added.
- 7:49 PM Changeset in webkit [144712] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r185990. Requested by
jamesr_ via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-04
- DEPS:
- 7:40 PM Changeset in webkit [144711] by
-
- 2 edits in trunk/Source/WebCore
Unreviewd build fix after r144701.
- platform/EventTracer.cpp:
(WebCore::EventTracer::initialize):
- 7:23 PM Changeset in webkit [144710] by
-
- 2 edits in trunk/Source/WebCore
Fix some style issues in RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=111369
Patch by Min Qin <qinmin@chromium.org> on 2013-03-04
Reviewed by Simon Fraser.
Just style fix, no test needed
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidScroll):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
- 7:17 PM Changeset in webkit [144709] by
-
- 3 edits in trunk/Source/WebCore
Revert changes to RenderLayer::scrollByRecursively() that were added for gesture-scrolling
https://bugs.webkit.org/show_bug.cgi?id=111007
Reviewed by Simon Fraser.
Due to http://trac.webkit.org/changeset/144519 landing, the changes made to RenderLayer in
http://trac.webkit.org/changeset/142057,
http://trac.webkit.org/changeset/140177, and
http://trac.webkit.org/changeset/142195
are no longer necessary (as RenderLayer::scrollByRecursively() is not used for
gesture-scrolling) and should be reverted.
No change in behavior, so no new tests needed.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollByRecursively):
- rendering/RenderLayer.h:
- 7:05 PM Changeset in webkit [144708] by
-
- 14 edits1 add in trunk/Source/JavaScriptCore
Unused Structure property tables waste 14MB on Membuster.
<http://webkit.org/b/110854>
<rdar://problem/13292104>
Reviewed by Geoffrey Garen.
Turn PropertyTable into a GC object and have Structure drop unpinned tables when marking.
14 MB progression on Membuster3.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
Added PropertyTable.cpp.
- runtime/PropertyTable.cpp: Added.
(JSC::PropertyTable::create):
(JSC::PropertyTable::clone):
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::destroy):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::visitChildren):
Moved marking of property table values here from Structure::visitChildren().
- runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::get):
Move m_cell to a local before using it multiple times. This avoids a multiple-access race when
Structure::checkOffsetConsistency() is used in assertions on the main thread while a marking thread
zaps the property table.
- runtime/Structure.h:
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
- runtime/StructureInlines.h:
(JSC::Structure::propertyTable):
Added a getter for the Structure's PropertyTable that ASSERTs GC currently isn't active.
Because GC can zap an unpinned property table at any time, it's not entirely safe to access it.
Renamed the variable itself to m_propertyTableUnsafe to force call sites into explaining themselves.
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::checkOffsetConsistency):
Moved these out of Structure.h to break header dependency cycle between Structure/PropertyTable.
- runtime/Structure.cpp:
(JSC::Structure::visitChildren):
Null out m_propertyTable if the table is unpinned. This'll cause the table to get GC'd.
- runtime/JSGlobalData.h:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
Add a global propertyTableStructure.
- runtime/PropertyMapHashTable.h:
(PropertyTable):
(JSC::PropertyTable::createStructure):
(JSC::PropertyTable::copy):
Make PropertyTable a GC object.
- runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::pin):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNamesFromStructure):
(JSC::Structure::checkConsistency):
- 6:48 PM Changeset in webkit [144707] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r144701.
- platform/EventTracer.cpp:
(WebCore::EventTracer::initialize):
- 6:46 PM Changeset in webkit [144706] by
-
- 3 edits4 adds in trunk
REGRESSION (r143643): Buttons containing floats render differently
https://bugs.webkit.org/show_bug.cgi?id=110933
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-04
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/forms/button-with-float.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
Also include new flexbox as a renderer that needs to enclose
overhanging floats. Flex boxes establish a block formatting context,
so they need to contain floats:
http://dev.w3.org/csswg/css3-flexbox/#flex-items
LayoutTests:
- css3/flexbox/float-inside-flexitem-expected.html: Added.
- css3/flexbox/float-inside-flexitem.html: Added.
- fast/forms/button-with-float-expected.html: Added.
- fast/forms/button-with-float.html: Added.
- 6:34 PM Changeset in webkit [144705] by
-
- 4 edits in trunk/Tools
[chromium] Switch to new webkit_support::CreateLayerTreeView interface
https://bugs.webkit.org/show_bug.cgi?id=111285
Patch by James Robinson <jamesr@chromium.org> on 2013-03-04
Reviewed by Adrienne Walker.
This removes the need for WebCompositorSupport::initialize and exposes
slightly fewer entry points across the repository boundary.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::webCompositorThread):
(TestShell):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::initializeLayerTreeView):
- 5:58 PM Changeset in webkit [144704] by
-
- 1 edit2 adds in trunk/PerformanceTests
Add PerformanceTest for document startup via iframe append/remove
https://bugs.webkit.org/show_bug.cgi?id=111389
Reviewed by Kentaro Hara.
We'd like pages with lots of iframes to be fast.
This test shows that at least for V8/Chromium we spend
all our time booting v8.
On my 32-core linux machine I see about 70 runs/sec in
Release and 5 runs/sec in Debug.
- DOM/iframe-append-remove.html: Added.
- 5:54 PM Changeset in webkit [144703] by
-
- 2 edits in trunk/Source/WebCore
Support WebSpeech - Speech Synthesis
https://bugs.webkit.org/show_bug.cgi?id=106742
Build fix.
- Modules/speech/SpeechSynthesis.cpp:
- 5:45 PM Changeset in webkit [144702] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r144595.
http://trac.webkit.org/changeset/144595
https://bugs.webkit.org/show_bug.cgi?id=90341
Causing multiple crashes in fast/dom/Element/* tests (hits
assert in Attr.cp:215)
Source/WebCore:
- dom/Element.cpp:
(WebCore::Element::setAttributeNode):
LayoutTests:
- fast/dom/Element/setAttributeNode-case-insensitivity-expected.txt: Removed.
- fast/dom/Element/setAttributeNode-case-insensitivity.html: Removed.
- 5:42 PM Changeset in webkit [144701] by
-
- 9 edits in trunk/Source
[chromium] Implement TRACE_EVENT macros for sampling profiling
https://bugs.webkit.org/show_bug.cgi?id=110932
Reviewed by Adam Barth.
We are implementing TRACE_EVENT macros for sampling profiling.
It works in the following mechanism:
- Chromium defines global state variables for sampling profiling.
(i.e. g_trace_state0, g_trace_state1, g_trace_state2 in trace_event.h)
- WebKit gets the addresses of the global state variables at the
initialization step. (i.e. EventTracer::initialize())
- WebKit updates the global states by using TRACE_EVENT_SAMPLING_STATE()
macros every time WebKit changes its state. (e.g. DOM attribute
getters/setters/methods)
- A sampling thread running in Chrome reads the global states
periodically and visualizes the profiling results into about://tracing.
This patch implements (1) a WebKit API to get the addresses of
the global states and (2) the TRACE_EVENT_SAMPLING_STATE() macro.
Source/Platform:
- chromium/public/Platform.h:
(Platform):
(WebKit::Platform::getTraceSamplingState):
Source/WebCore:
No tests. The sampling profiler is not enabled in Chrome by default.
I manually inserted TRACE_EVENT_SAMPLING_STATE() macros and
confirmed that the sampling profiling is working as expected.
- platform/EventTracer.cpp:
(WebCore::EventTracer::initialize):
(WebCore::EventTracer::getTraceCategoryEnabledFlag):
(WebCore):
- platform/EventTracer.h:
(WebCore):
(EventTracer):
- platform/chromium/EventTracerChromium.cpp:
(WebCore):
(WebCore::EventTracer::initialize):
- platform/chromium/TraceEvent.h:
Source/WebKit/chromium:
- src/WebKit.cpp:
(WebKit::initializeWithoutV8):
- 5:39 PM FeatureFlags edited by
- (diff)
- 5:17 PM Changeset in webkit [144700] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: touch-gesture-noscroll-body-* are failing on mac.
- 5:16 PM Changeset in webkit [144699] by
-
- 2 edits in trunk/Tools
Unreviewed. Get rid of some AppleWin VS2010 build warnings.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
- 5:13 PM Changeset in webkit [144698] by
-
- 11 edits in trunk
Support WebSpeech - Speech Synthesis
https://bugs.webkit.org/show_bug.cgi?id=106742
Reviewed by Simon Fraser.
Source/JavaScriptCore:
Enable speech synthesis for the Mac.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Enable speech synthesis for the Mac.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
Enable speech synthesis for the Mac.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Enable speech synthesis for the Mac.
- Configurations/FeatureDefines.xcconfig:
LayoutTests:
Unskip speech synthesis tests.
- fast/dom/script-tests/constructed-objects-prototypes.js:
(constructorPropertiesOnWindow):
- platform/mac/TestExpectations:
- 4:55 PM Changeset in webkit [144697] by
-
- 2 edits in trunk/Tools
BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
~
1 error generated.
- DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
AccessibilityCommonMac.h.
- 4:42 PM Changeset in webkit [144696] by
-
- 20 edits3 adds in trunk
<link rel="apple-touch-icon"> tag is not honored on CNN.com, workflowy.com etc
https://bugs.webkit.org/show_bug.cgi?id=109061
Patch by Ruslan Abdikeev <aruslan@chromium.org> on 2013-03-04
Reviewed by Adam Barth.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Test: fast/dom/icon-url-list-apple-touch.html
Added iconTypes parameter to Document::iconURLs().
Added Document::shortcutIconURLs() with original semantics of iconURLs().
Fixed IconController.cpp to provide iconTypesMask to iconURLs().
Renamed iconTypes to iconTypesMask to make the meaning clearer.
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::shortcutIconURLs):
(WebCore):
(WebCore::Document::iconURLs):
- dom/Document.h:
(Document):
- loader/icon/IconController.cpp:
(WebCore::IconController::iconURL):
(WebCore::IconController::urlsForTypes):
- testing/Internals.cpp:
(WebCore::Internals::iconURLs):
(WebCore::Internals::shortcutIconURLs):
(WebCore):
(WebCore::Internals::allIconURLs):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Added test for apple-touch-icon in allIconURLs().
Changed iconURLs() to shortcutIconURLs().
- fast/dom/icon-url-change.html:
- fast/dom/icon-url-list-apple-touch-expected.txt: Added.
- fast/dom/icon-url-list-apple-touch.html: Added.
- fast/dom/icon-url-list.html:
- fast/dom/icon-url-property.html:
- 4:31 PM Changeset in webkit [144695] by
-
- 4 edits in trunk/Source/WebKit2
UI process storage areas should hold on to storage maps
https://bugs.webkit.org/show_bug.cgi?id=111374
Reviewed by Beth Dakin.
Pass the session storage quota size through to the storage area constructor and
create a StorageMap with the given quota size.
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::create):
(WebKit::StorageManager::StorageArea::StorageArea):
(StorageManager::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::create):
(WebKit::StorageManager::SessionStorageNamespace::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::createSessionStorageNamespace):
(WebKit::StorageManager::createSessionStorageNamespaceInternal):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- 4:22 PM Changeset in webkit [144694] by
-
- 3 edits3 adds in trunk
Cache partitioning does not affect iframe MainResources
https://bugs.webkit.org/show_bug.cgi?id=111022
Reviewed by David Kilzer.
Source/WebCore:
Set the partition of a main resource request if in a subframe.
Test: http/tests/cache/partitioned-cache-iframe.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
LayoutTests:
These tests results are for the case in which the cache is not
partitioned, as no shipping ports have cache partitioning enabled
- http/tests/cache/partitioned-cache-iframe-expected.txt: Added.
- http/tests/cache/partitioned-cache-iframe.html: Added.
- http/tests/cache/resources/random-cached-iframe.cgi: Added.
- 3:51 PM Changeset in webkit [144693] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after r144675.
Work around picky/old C++ compilers by separating the '>>' in
nested templates with a space.
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
- 3:51 PM Changeset in webkit [144692] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: Marking all html5lib/generated/ as crashing.
- 3:47 PM Changeset in webkit [144691] by
-
- 7 edits in trunk/Source/WebKit2
More work on UI side storage
https://bugs.webkit.org/show_bug.cgi?id=111370
Reviewed by Andreas Kling.
Add a DispatchStorageEvent message and begin hooking it up.
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::setItem):
(WebKit):
(WebKit::StorageManager::StorageArea::dispatchEvents):
(WebKit::StorageManager::setItem):
(WebKit::StorageManager::findStorageArea):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- UIProcess/Storage/StorageManager.messages.in:
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::setItem):
(WebKit::StorageAreaProxy::dispatchStorageEvent):
(WebKit):
- WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
- WebProcess/Storage/StorageAreaProxy.messages.in:
- 3:45 PM Changeset in webkit [144690] by
-
- 2 edits in trunk/Source/WebCore
AX: user agent shadow roots for plugins should be 'accessible'
https://bugs.webkit.org/show_bug.cgi?id=111339
Reviewed by Tim Horton.
If a plugin element uses a user agent shadow element, we should make that shadow element
into a button with the title and subtitle put together, and use that as the label. This
will probably be the best accessibility experience.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
- 3:45 PM Changeset in webkit [144689] by
-
- 1 edit2 adds in trunk/LayoutTests
CSS3 calc: identify divide by zero cases at parse time
https://bugs.webkit.org/show_bug.cgi?id=80411
Patch by Alan Cutter <alancutter@chromium.org> on 2013-03-04
Reviewed by Tony Chang.
Added tests to check whether divide by 0 cases are caught.
- css3/calc/catch-divide-by-0-expected.txt: Added.
- css3/calc/catch-divide-by-0.html: Added.
- 3:36 PM Changeset in webkit [144688] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Form controls on composited layers are not painted properly
https://bugs.webkit.org/show_bug.cgi?id=111366
Reviewed by James Robinson.
Set PlatformContextSkia::m_drawingToImageBuffer which is used as a hint to properly blend GDI-painted bitmap.
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
- 3:25 PM Changeset in webkit [144687] by
-
- 3 edits in trunk/Source/WebCore
Give ViewportConstraints classes copy constructors
https://bugs.webkit.org/show_bug.cgi?id=111367
Reviewed by Beth Dakin.
Downstream code requires that ViewportConstraints objects have
copy constructors, so add them.
Also clean up some redundant initialization of stack objects
in RenderLayerCompositor.
No behavior change.
- page/scrolling/ScrollingConstraints.h:
(WebCore::ViewportConstraints::ViewportConstraints):
(ViewportConstraints):
(WebCore::FixedPositionViewportConstraints::FixedPositionViewportConstraints):
(FixedPositionViewportConstraints):
(WebCore::StickyPositionViewportConstraints::StickyPositionViewportConstraints):
(StickyPositionViewportConstraints):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeFixedViewportConstraints):
(WebCore::RenderLayerCompositor::computeStickyViewportConstraints):
- 3:23 PM Changeset in webkit [144686] by
-
- 2 edits in tags/Safari-537.31.13/Source/WebKit2
Merge r144659. <rdar://problem/13326713>
- 3:21 PM Changeset in webkit [144685] by
-
- 2 edits in branches/safari-534.59-branch/Source/WebKit2
Merge r144114
2013-02-26 Anders Carlsson <andersca@apple.com>
Fix a copy/paste error in WebLoaderClient::didBlockInsecurePluginVersion
https://bugs.webkit.org/show_bug.cgi?id=110914
<rdar://problem/13297581>
Reviewed by Beth Dakin.
Pass kWKErrorCodeInsecurePlugInVersion to the pluginDidFail callback.
- UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
- 3:19 PM Changeset in webkit [144684] by
-
- 2 edits in branches/safari-536.29-branch/Source/WebKit2
Merge 144114
2013-02-26 Anders Carlsson <andersca@apple.com>
Fix a copy/paste error in WebLoaderClient::didBlockInsecurePluginVersion
https://bugs.webkit.org/show_bug.cgi?id=110914
<rdar://problem/13297581>
Reviewed by Beth Dakin.
Pass kWKErrorCodeInsecurePlugInVersion to the pluginDidFail callback.
- UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
- 3:12 PM Changeset in webkit [144683] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. AppleWin build fix.
- html/parser/XSSAuditor.cpp:
(WebCore::isSemicolonSeparatedAttribute):
- 3:09 PM Changeset in webkit [144682] by
-
- 3 edits in trunk/Source/WebCore
CSSParser: Avoid temporary String when parsing hex colors.
<http://webkit.org/b/111341>
Reviewed by Anders Carlsson.
Templatize CSSParser::fastParseColor() so we can pass a CSSParserString as the color name.
This avoids creating a temporary WTF::String from the parser string.
- css/CSSParser.cpp:
(WebCore::CSSParser::fastParseColor):
- css/CSSParser.h:
- css/CSSParserValues.h:
(CSSParserString):
- 3:07 PM Changeset in webkit [144681] by
-
- 13 edits1 copy1 add in trunk
[CSS Grid Layout] Add parsing for grid-{start|before}
https://bugs.webkit.org/show_bug.cgi?id=110988
Reviewed by Tony Chang.
Source/WebCore:
Test: fast/css-grid-layout/grid-item-start-before-get-set.html
Refactored how we store internally grid-{row|column} to be based on grid-{before|start}.
This is required as grid-{row|column} are shorthands for resp. grid-{before|after} and grid-{start|end}
in the specification and will also be in the code. That means a lot of methods were renamed to be more
aligned with the new design.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Added the code to parse, apply and get back the new properties. Also
some renaming after the internal naming change below.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::autoPlacementMajorAxisPositionForChild):
(WebCore::RenderGrid::autoPlacementMinorAxisPositionForChild):
- rendering/style/RenderStyle.h:
- rendering/style/StyleGridItemData.cpp:
(WebCore::StyleGridItemData::StyleGridItemData):
- rendering/style/StyleGridItemData.h:
(WebCore::StyleGridItemData::operator==):
Updated the naming now that we manipulate grid-{before|start} instead of grid-{row|column}.
LayoutTests:
- fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
- fast/css-grid-layout/grid-item-column-row-get-set.html:
Extended the test to make sure that both grid-column (resp. grid-row) and grid-start (resp. grid-before) are
in sync.
- fast/css-grid-layout/grid-item-start-before-get-set-expected.txt: Added.
- fast/css-grid-layout/grid-item-start-before-get-set.html: Added
Add this test for grid-{start|before}, similar to LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html.
- 2:44 PM Changeset in webkit [144680] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed build fix: wrap references to PluginInfoStore with
guards for platforms which do not enable NETSCAPE_PLUGIN_AP.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
- UIProcess/WebContext.h:
- 2:41 PM Changeset in webkit [144679] by
-
- 8 edits2 adds in trunk
WebSpeech: change voiceURI to voice
https://bugs.webkit.org/show_bug.cgi?id=110773
Reviewed by Tim Horton.
Source/WebCore:
Change the voiceURI property to a voice property that takes a SpeechSynthesisVoice.
This was recently added to the errata of the WebSpeech spec.
Test: platform/mac/fast/speechsynthesis/speech-synthesis-utterance-uses-voice.html
- Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore):
(WebCore::SpeechSynthesisUtterance::voice):
(WebCore::SpeechSynthesisUtterance::setVoice):
- Modules/speech/SpeechSynthesisUtterance.h:
(SpeechSynthesisUtterance):
- Modules/speech/SpeechSynthesisUtterance.idl:
- Modules/speech/SpeechSynthesisVoice.h:
(WebCore::SpeechSynthesisVoice::platformVoice):
(SpeechSynthesisVoice):
- platform/PlatformSpeechSynthesisUtterance.cpp:
(WebCore::PlatformSpeechSynthesisUtterance::PlatformSpeechSynthesisUtterance):
- platform/PlatformSpeechSynthesisUtterance.h:
(WebCore::PlatformSpeechSynthesisUtterance::voice):
(WebCore::PlatformSpeechSynthesisUtterance::setVoice):
(PlatformSpeechSynthesisUtterance):
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
LayoutTests:
- platform/mac/fast/speechsynthesis/speech-synthesis-utterance-uses-voice-expected.txt: Added.
- platform/mac/fast/speechsynthesis/speech-synthesis-utterance-uses-voice.html: Added.
- 2:29 PM Changeset in webkit [144678] by
-
- 2 edits in branches/safari-536.29-branch/Source/WebKit2
Merge 144659
2013-03-04 Anders Carlsson <andersca@apple.com>
Complete the plug-in URL string before sending it to the UI process
https://bugs.webkit.org/show_bug.cgi?id=111355
<rdar://problem/13326713>
Reviewed by Andreas Kling.
If the URL is not absolute, we won't be able to find it by path extension in the plug-in info store.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::unavailablePluginButtonClicked):
- 2:28 PM Changeset in webkit [144677] by
-
- 5 edits2 adds in trunk
Filename passed to FormData.append() takes precedence over filename in
File.
https://bugs.webkit.org/show_bug.cgi?id=111255
Patch by Victor Costan <costan@gmail.com> on 2013-03-04
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: http/tests/local/formdata/send-form-data-with-filename.html
- platform/network/FormData.cpp:
(WebCore::FormData::appendKeyValuePairItems): changed to implement the
behavior in the XMLHttpRequest W3C spec.
LayoutTests:
(runTest):
- http/tests/local/formdata/send-form-data-with-filename-expected.txt: Added.
- http/tests/local/formdata/send-form-data-with-filename.html: Added.
- http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt: Updated
to reflect the behavior specified in the XMLHttpRequest W3C spec.
- platform/wk2/TestExpectations: newly added test doesn't work in
WebKit2 because beginDragWithFiles is not implemented
- 2:26 PM Changeset in webkit [144676] by
-
- 2 edits in branches/safari-534.59-branch/Source/WebKit2
Merge r144659
2013-03-04 Anders Carlsson <andersca@apple.com>
Complete the plug-in URL string before sending it to the UI process
https://bugs.webkit.org/show_bug.cgi?id=111355
<rdar://problem/13326713>
Reviewed by Andreas Kling.
If the URL is not absolute, we won't be able to find it by path extension in the plug-in info store.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::unavailablePluginButtonClicked):
- 2:25 PM Changeset in webkit [144675] by
-
- 3 edits in trunk/Source/WebKit2
Create and destroy storage areas in the UI process
https://bugs.webkit.org/show_bug.cgi?id=111361
Reviewed by Sam Weinig.
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
Keep track of listener connection and storage area ID pairs.
(WebKit::StorageManager::StorageArea::~StorageArea):
Assert that we don't have any listeners left.
(WebKit::StorageManager::StorageArea::addListener):
Add the pair to the set of listeners.
(WebKit::StorageManager::StorageArea::removeListener):
Remove the pair from the set of listeners.
(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
Given an origin, look up or create the storage area.
(WebKit::StorageManager::createStorageArea):
Create the storage area if it doesn't already exist.
(WebKit::StorageManager::destroyStorageArea):
Look up the storage area and destroy it.
- UIProcess/Storage/StorageManager.h:
Add a map of open storage areas.
- 2:16 PM Changeset in webkit [144674] by
-
- 3 edits2 adds in trunk
Canvas and DOM go out of sync
https://bugs.webkit.org/show_bug.cgi?id=107701
Patch by Alexis Hetu <sugoi@chromium.org> on 2013-03-04
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/canvas/canvas-overflow-hidden-animation.html
Added an update of the current compositor from the layer's stacking
container when the layer itself isn't a stacking container.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAfterLayout):
Added an update of the stacking container of the owning layer of the
layer backing when the owning layer isn't a stacking container itself.
LayoutTests:
Added a new layout test for moving an object (a div) within a div that
has the "overflow:hidden" property.
- fast/canvas/canvas-overflow-hidden-animation-expected.html: Added.
- fast/canvas/canvas-overflow-hidden-animation.html: Added.
- 2:15 PM Changeset in webkit [144673] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Roll chromium DEPS 185662 -> 185963
Roll roll roll the deps
Gently from downstream.
Merrily merrily merrily merrily
Green bots are but a dream.
- DEPS:
- 2:08 PM Changeset in webkit [144672] by
-
- 10 edits in trunk/Source/WebKit2
Add API to allow WK2 clients to query the list of installed plug-ins.
https://bugs.webkit.org/show_bug.cgi?id=111245
Reviewed by Alexey Proskuryakov.
Add API in WKContext, implemented by WebContext, that allows callers to register a callback
retrieve an array containing installed plugin information. This API is exposed through WebContext
because it owns the PluginInfoStore used to fulfill the request.
Bump the WKContextClient API by 1:
- Shared/APIClientTraits.cpp:
- Shared/APIClientTraits.h:
- UIProcess/API/C/WKContext.h:
Add a client protocol to PluginInfoStore to notify the client when plugIn information has been
successfully loaded:
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::PluginInfoStore): Initialize m_client to 0.
(WebKit::PluginInfoStore::loadPluginsIfNecessary): If the client is present, notify after loading the plugin store.
- UIProcess/Plugins/PluginInfoStore.h:
(WebKit::PluginInfoStoreClient::~PluginInfoStoreClient): Default destructor.
(WebKit::PluginInfoStoreClient::PluginInfoStoreClient): Default constructor.
(WebKit::PluginInfoStore::setClient): Simple setter.
(WebKit::PluginInfoStore::client): Simple getter.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Set self as the client of PluginInfoStore.
(WebKit::WebContext::~WebContext): Clear the client of PluginInfoStore.
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins): Pass the callback to own client.
- UIProcess/WebContext.h:
- UIProcess/WebContextClient.cpp:
(WebKit::WebContextClient::plugInInformationBecameAvailable): Pass the callback to the registered WK callback, if present.
- UIProcess/WebContextClient.h:
- 2:05 PM Changeset in webkit [144671] by
-
- 9 edits in trunk/Source/WebCore
Small BlobResourceHandle cleanup
https://bugs.webkit.org/show_bug.cgi?id=111352
Reviewed by Sam Weinig.
- Don't use PassRefPtr<BlobStorageData> when ownership is not being passed.
- Added OVERRIDE to some functions.
- Added const to ResourceHandle::firstRequest().
- platform/network/BlobRegistryImpl.cpp:
(WebCore::loadResourceSynchronously):
(WebCore::BlobRegistryImpl::createResourceHandle):
(WebCore::BlobRegistryImpl::getBlobDataFromURL):
- platform/network/BlobRegistryImpl.h:
(BlobRegistryImpl):
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::createAsync):
(WebCore::BlobResourceHandle::loadResourceSynchronously):
- platform/network/BlobResourceHandle.h:
(BlobResourceHandle):
- platform/network/FormData.cpp:
(WebCore::appendBlobResolved):
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::firstRequest):
- platform/network/ResourceHandle.h:
(ResourceHandle):
- 1:54 PM Changeset in webkit [144670] by
-
- 17 edits in trunk/Source/WebKit2
PDFPlugin: Hook up Services
https://bugs.webkit.org/show_bug.cgi?id=111246
<rdar://problem/13062672>
Reviewed by Alexey Proskuryakov.
Make the Application->Services menu work when the focused selection is a PDFPlugin.
- Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
- Shared/EditorState.h:
(WebKit::EditorState::EditorState):
(EditorState):
Add isInPlugin property to EditorState.
- UIProcess/API/mac/WKView.mm:
(-[WKView validRequestorForSendType:returnType:]):
If the selection is currently in a Plugin, we only currently have the ability
to retrieve the selection as a plain-text string, so restrict sendType to NSStringPboardType.
- WebProcess/Plugins/PDF/SimplePDFPlugin.h:
- WebProcess/Plugins/Plugin.h:
- WebProcess/Plugins/PluginView.h:
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add getStringSelection.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h:
Add pdfLayerController:didChangeSelection: delegate method.
- WebProcess/Plugins/PDF/PDFPlugin.h:
(PDFPlugin):
Add getStringSelection and notifySelectionChanged.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate pdfLayerController:didChangeSelection:]):
Forward selection change notifications to our PDFPlugin.
(WebKit::PDFPlugin::notifySelectionChanged):
Forward selection change notifications to our WebPage.
(WebKit::PDFPlugin::getStringSelection):
Retrieve PDFLayerController's selection as a plain text string.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::countFindMatches):
(WebKit::PluginView::findString):
Drive-bys, check for existance and initialization of the plugin before using it.
(WebKit::PluginView::getStringSelection): Added.
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
Use didChangeSelection instead of sending the EditorStateChanged message directly.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
If a plugin is focused and has a selection, return a EditorState that reflects that.
Since PDFs aren't editable (when editing annotations, the plugin doesn't have focus),
I'm not adding support for the editing-related properties when a plugin has focus.
(WebKit::WebPage::focusedPluginViewForFrame):
(WebKit::WebPage::pluginViewForFrame):
Make these class methods instead of static functions so we can use them from
WebPageMac too, instead of duplicating code there.
(WebKit::WebPage::didChangeSelection): Added.
- WebProcess/WebPage/WebPage.h:
Add didChangeSelection and [focused]PluginViewForFrame.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::getStringSelectionForPasteboard):
Defer to the focused plugin (if it exists) when retrieving the plain-text selection.
- 1:54 PM Changeset in webkit [144669] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Introduce WebInspector.EventTarget interface for interfaces that dispatch events.
https://bugs.webkit.org/show_bug.cgi?id=111320
Reviewed by Pavel Feldman.
- inspector/front-end/Object.js:
(WebInspector.EventTarget):
(WebInspector.EventTarget.prototype.addEventListener):
(WebInspector.EventTarget.prototype.removeEventListener):
(WebInspector.EventTarget.prototype.removeAllListeners):
(WebInspector.EventTarget.prototype.hasEventListeners):
(WebInspector.EventTarget.prototype.dispatchEventToListeners):
- inspector/front-end/ResourceScriptMapping.js:
- inspector/front-end/UISourceCode.js:
- inspector/front-end/Workspace.js:
(WebInspector.ProjectDelegate.prototype.searchInFileContent):
- 1:47 PM Changeset in webkit [144668] by
-
- 8 edits in trunk/Source
Remove contextInternalContext from JSContextInternal.h
https://bugs.webkit.org/show_bug.cgi?id=111356
Reviewed by Geoffrey Garen.
We don't need it any more since we have globalContextRef in JSContext.
Source/JavaScriptCore:
- API/JSContext.mm:
- API/JSContextInternal.h:
- API/JSValue.mm:
(+[JSValue valueWithBool:inContext:]):
(+[JSValue valueWithDouble:inContext:]):
(+[JSValue valueWithInt32:inContext:]):
(+[JSValue valueWithUInt32:inContext:]):
(+[JSValue valueWithNewObjectInContext:]):
(+[JSValue valueWithNewArrayInContext:]):
(+[JSValue valueWithNewRegularExpressionFromPattern:flags:inContext:]):
(+[JSValue valueWithNewErrorFromMessage:inContext:]):
(+[JSValue valueWithNullInContext:]):
(+[JSValue valueWithUndefinedInContext:]):
(-[JSValue toBool]):
(-[JSValue toDouble]):
(-[JSValue toNumber]):
(-[JSValue toString]):
(-[JSValue toDate]):
(-[JSValue toArray]):
(-[JSValue toDictionary]):
(-[JSValue valueForProperty:]):
(-[JSValue setValue:forProperty:]):
(-[JSValue deleteProperty:]):
(-[JSValue hasProperty:]):
(-[JSValue valueAtIndex:]):
(-[JSValue setValue:atIndex:]):
(-[JSValue isUndefined]):
(-[JSValue isNull]):
(-[JSValue isBoolean]):
(-[JSValue isNumber]):
(-[JSValue isString]):
(-[JSValue isObject]):
(-[JSValue isEqualToObject:]):
(-[JSValue isEqualWithTypeCoercionToObject:]):
(-[JSValue isInstanceOf:]):
(-[JSValue callWithArguments:]):
(-[JSValue constructWithArguments:]):
(-[JSValue invokeMethod:withArguments:]):
(valueToObject):
(objectToValueWithoutCopy):
(objectToValue):
(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):
(-[JSValue description]):
- API/JSWrapperMap.mm:
(createObjectWithCustomBrand):
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]):
(-[JSObjCClassInfo wrapperForObject:]):
(-[JSWrapperMap jsWrapperForObject:]):
- API/ObjCCallbackFunction.mm:
(ObjCCallbackFunction::call):
(objCCallbackFunctionForInvocation):
Source/WebKit/mac:
- WebView/WebScriptWorld.mm:
(+[WebScriptWorld scriptWorldForJavaScriptContext:]):
- 1:44 PM Changeset in webkit [144667] by
-
- 3 edits2 adds in trunk
XSSAuditor bypass with --> comment syntax.
https://bugs.webkit.org/show_bug.cgi?id=111349
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/xssAuditor/open-iframe-src-03.html
- html/parser/XSSAuditor.cpp:
(WebCore::isTerminatingCharacter):
Adds ">" to the list of terminating characters, so that comments of
the form --> end the snippet we seek to match.
LayoutTests:
- http/tests/security/xssAuditor/open-iframe-src-03-expected.txt: Added.
- http/tests/security/xssAuditor/open-iframe-src-03.html: Added.
- 1:42 PM Changeset in webkit [144666] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Modal dialogs sometimes lose focus.
https://bugs.webkit.org/show_bug.cgi?id=111317
Reviewed by Pavel Feldman.
setCurrentFocusElement doesn't give focus to an element anymore
if modal glass pane is shown and element is not inside it.
- inspector/front-end/Dialog.js:
(WebInspector.Dialog):
(WebInspector.Dialog.prototype._hide):
- inspector/front-end/InspectorView.js:
(WebInspector.InspectorView.prototype.defaultFocusedElement):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.defaultFocusedElement):
- inspector/front-end/UIUtils.js:
(WebInspector.GlassPane):
(WebInspector.GlassPane.prototype.dispose):
(WebInspector.setCurrentFocusElement):
- inspector/front-end/dialog.css:
- 1:39 PM Changeset in webkit [144665] by
-
- 1 edit3 copies in branches/chromium/1410
Merge 144196
REGRESSION (r134631) of border-radius percentage with border pixel
https://bugs.webkit.org/show_bug.cgi?id=110889
Reviewed by Simon Fraser.
Source/WebCore:
Fixing background color filling to handle "non renderable" rounded
rectangles.
Test: fast/borders/border-radius-percent.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
LayoutTests:
Adding new pixel test to verify the correct rendering of
rounded rectangle backgrounds with inner border radii that
exceed the dimensions of the inner edge of the border.
- fast/borders/border-radius-percent-expected.txt: Added.
- fast/borders/border-radius-percent.html: Added.
- platform/chromium-linux/fast/borders/border-radius-percent-expected.png: Added.
- platform/chromium/TestExpectations:
TBR=junov@google.com
Review URL: https://codereview.chromium.org/12390064
- 1:38 PM Changeset in webkit [144664] by
-
- 12 edits2 adds in trunk
[WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
https://bugs.webkit.org/show_bug.cgi?id=109828
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Providing WKViewClient with Web Process crash and Web Process relaunch
callbacks brings better design as WebView should not be aware of
EFL-specific code handling the corresponding events.
The implementation of the mentioned Web Process callbacks was also added.
- UIProcess/API/C/efl/WKView.cpp:
(WKViewSetThemePath):
- UIProcess/API/C/efl/WKView.h:
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::webProcessCrashed):
(WebKit):
(WebKit::ViewClientEfl::webProcessDidRelaunch):
(WebKit::ViewClientEfl::ViewClientEfl):
- UIProcess/efl/ViewClientEfl.h:
(ViewClientEfl):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::setThemePath):
Accepts WTF::String instead of WKStringRef as it is
more appropriate for C++ API implementation class.
(WebKit::WebView::processDidCrash):
(WebKit::WebView::didRelaunchProcess):
- UIProcess/efl/WebView.h:
(WebView):
- UIProcess/efl/WebViewClient.cpp:
(WebKit::WebViewClient::webProcessCrashed):
(WebKit):
(WebKit::WebViewClient::webProcessDidRelaunch):
- UIProcess/efl/WebViewClient.h:
Tools:
Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
callbacks.
- TestWebKitAPI/CMakeLists.txt:
Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
considered.
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::webProcessCrashed):
(TestWebKitAPI::webProcessDidRelaunch):
(TestWebKitAPI::setViewClient):
(TestWebKitAPI::TEST):
- 1:16 PM Changeset in webkit [144663] by
-
- 5 edits in trunk/Source
Unreviewed. AppleWin build fix.
- WebKit.vcxproj/FeatureDefines.props:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- WebCore.vcxproj/WebCore.vcxproj:
- 1:11 PM Changeset in webkit [144662] by
-
- 4 edits in trunk/Source
JSC_OBJC_API_ENABLED should be removed from FeatureDefines.h
https://bugs.webkit.org/show_bug.cgi?id=111269
Reviewed by Mark Hahnenberg.
Source/WebKit/mac:
Include JavaScriptCore/JSBase.h for the definition of JSC_OBJC_API_ENABLED.
- WebView/WebDelegateImplementationCaching.h:
Source/WTF:
JSC_OBJC_API_ENABLED flag was added to FeatureDefines.h (r143637)
so that it could be used in WebCore.exp.in to determine whether
or not we should be exporting certain symbols based on whether
the WebKit-related portion of the JSC ObjC API was enabled.
It turned out conditionally including certain symbols didn't
work when building fat binaries, so it's not even necessary any more.
- wtf/FeatureDefines.h: Remove JSC_OBJC_API_ENABLED.
- 1:02 PM Changeset in webkit [144661] by
-
- 4 edits in trunk/Source/WebCore
[v8] add isolate parameter to heap statistics calls
https://bugs.webkit.org/show_bug.cgi?id=111308
Patch by Dan Carney <dcarney@google.com> on 2013-03-04
Reviewed by Jochen Eisinger.
No new tests.
- bindings/v8/ScriptGCEvent.cpp:
(WebCore::ScriptGCEvent::getHeapSize):
(WebCore::ScriptGCEvent::getUsedHeapSize):
- bindings/v8/V8AdaptorFunction.cpp:
(WebCore::V8AdaptorFunction::getTemplate):
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::checkMemoryUsage):
- 12:42 PM Changeset in webkit [144660] by
-
- 4 edits in trunk/Source
[chromium] remove deprecated hyphenation methods from Platform
https://bugs.webkit.org/show_bug.cgi?id=111101
Reviewed by Adam Barth.
Source/Platform:
- chromium/public/Platform.h:
(Platform):
Source/WebCore:
- platform/text/chromium/Hyphenation.cpp:
(WebCore::canHyphenate):
(WebCore::lastHyphenLocation):
- 12:33 PM Changeset in webkit [144659] by
-
- 2 edits in trunk/Source/WebKit2
Complete the plug-in URL string before sending it to the UI process
https://bugs.webkit.org/show_bug.cgi?id=111355
<rdar://problem/13326713>
Reviewed by Andreas Kling.
If the URL is not absolute, we won't be able to find it by path extension in the plug-in info store.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
- 12:22 PM Changeset in webkit [144658] by
-
- 5 edits in branches/safari-534.59-branch
<rdar://problem/13337144> - Update 536.29 branch Loader and UI client layouts
Rubberstamped by Anders Carlsson.
Source/WebKit2:
- UIProcess/API/C/WKPage.h:
Tools:
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
- 12:07 PM Changeset in webkit [144657] by
-
- 4 edits3 adds in trunk/Tools
AX: Upstream iOS Accessibility DumpRenderTree changes
https://bugs.webkit.org/show_bug.cgi?id=111220
Reviewed by David Kilzer.
Upstream the iOS changes for accessibility in DumpRenderTree.
- DumpRenderTree/AccessibilityUIElement.cpp:
(headerElementAtIndexCallback):
(linkedElementCallback):
(elementsForRangeCallback):
(increaseTextSelectionCallback):
(decreaseTextSelectionCallback):
(assistiveTechnologySimulatedFocusCallback):
(stringForSelectionCallback):
(getIPhoneLabelCallback):
(getIPhoneHintCallback):
(getIPhoneValueCallback):
(getIPhoneIdentifierCallback):
(getIPhoneTraitsCallback):
(getIPhoneIsElementCallback):
(getIPhoneElementTextPositionCallback):
(getIPhoneElementTextLengthCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement):
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/ios: Added.
- DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
(AccessibilityController::AccessibilityController):
(AccessibilityController::~AccessibilityController):
(AccessibilityController::elementAtPoint):
(AccessibilityController::focusedElement):
(AccessibilityController::rootElement):
(findAccessibleObjectById):
(AccessibilityController::accessibleElementById):
(AccessibilityController::setLogFocusEvents):
(AccessibilityController::setLogScrollingStartEvents):
(AccessibilityController::setLogValueChangeEvents):
(AccessibilityController::setLogAccessibilityEvents):
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
(concatenateAttributeAndValue):
(AccessibilityUIElement::iphoneLabel):
(AccessibilityUIElement::iphoneHint):
(AccessibilityUIElement::iphoneValue):
(AccessibilityUIElement::iphoneIdentifier):
(AccessibilityUIElement::iphoneTraits):
(AccessibilityUIElement::iphoneIsElement):
(AccessibilityUIElement::iphoneElementTextPosition):
(AccessibilityUIElement::iphoneElementTextLength):
(AccessibilityUIElement::url):
(AccessibilityUIElement::x):
(AccessibilityUIElement::y):
(AccessibilityUIElement::width):
(AccessibilityUIElement::height):
(AccessibilityUIElement::clickPointX):
(AccessibilityUIElement::clickPointY):
(AccessibilityUIElement::getChildren):
(AccessibilityUIElement::getChildrenWithRange):
(AccessibilityUIElement::childrenCount):
(AccessibilityUIElement::elementAtPoint):
(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::headerElementAtIndex):
(AccessibilityUIElement::linkedElement):
(AccessibilityUIElement::linkedUIElementAtIndex):
(AccessibilityUIElement::ariaOwnsElementAtIndex):
(AccessibilityUIElement::ariaFlowToElementAtIndex):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::rowAtIndex):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::increaseTextSelection):
(AccessibilityUIElement::decreaseTextSelection):
(AccessibilityUIElement::stringForSelection):
(AccessibilityUIElement::stringForRange):
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
(AccessibilityUIElement::elementsForRange):
(AccessibilityUIElement::getLinkedUIElements):
(AccessibilityUIElement::getDocumentLinks):
(AccessibilityUIElement::attributesOfLinkedUIElements):
(AccessibilityUIElement::attributesOfDocumentLinks):
(AccessibilityUIElement::attributesOfChildren):
(AccessibilityUIElement::allAttributes):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::isPressActionSupported):
(AccessibilityUIElement::isIncrementActionSupported):
(AccessibilityUIElement::isDecrementActionSupported):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::isAttributeSettable):
(AccessibilityUIElement::isAttributeSupported):
(AccessibilityUIElement::parameterizedAttributeNames):
(AccessibilityUIElement::role):
(AccessibilityUIElement::subrole):
(AccessibilityUIElement::roleDescription):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::orientation):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::language):
(AccessibilityUIElement::helpText):
(AccessibilityUIElement::intValue):
(AccessibilityUIElement::minValue):
(AccessibilityUIElement::maxValue):
(AccessibilityUIElement::valueDescription):
(AccessibilityUIElement::insertionPointLineNumber):
(AccessibilityUIElement::isEnabled):
(AccessibilityUIElement::isRequired):
(AccessibilityUIElement::isFocused):
(AccessibilityUIElement::isSelected):
(AccessibilityUIElement::isExpanded):
(AccessibilityUIElement::isChecked):
(AccessibilityUIElement::hierarchicalLevel):
(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):
(AccessibilityUIElement::lineForIndex):
(AccessibilityUIElement::boundsForRange):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfColumns):
(AccessibilityUIElement::attributesOfRows):
(AccessibilityUIElement::attributesOfVisibleCells):
(AccessibilityUIElement::attributesOfHeader):
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
(AccessibilityUIElement::indexInTable):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::cellForColumnAndRow):
(AccessibilityUIElement::selectedTextRange):
(AccessibilityUIElement::assistiveTechnologySimulatedFocus):
(AccessibilityUIElement::setSelectedTextRange):
(AccessibilityUIElement::increment):
(AccessibilityUIElement::decrement):
(AccessibilityUIElement::showMenu):
(AccessibilityUIElement::press):
(AccessibilityUIElement::accessibilityValue):
(AccessibilityUIElement::documentEncoding):
(AccessibilityUIElement::documentURI):
(_accessibilityNotificationCallback):
(AccessibilityUIElement::addNotificationListener):
(AccessibilityUIElement::removeNotificationListener):
(AccessibilityUIElement::isFocusable):
(AccessibilityUIElement::isSelectable):
(AccessibilityUIElement::isMultiSelectable):
(AccessibilityUIElement::isSelectedOptionActive):
(AccessibilityUIElement::isVisible):
(AccessibilityUIElement::isOffScreen):
(AccessibilityUIElement::isCollapsed):
(AccessibilityUIElement::isIgnored):
(AccessibilityUIElement::hasPopup):
(AccessibilityUIElement::takeFocus):
(AccessibilityUIElement::takeSelection):
(AccessibilityUIElement::addSelection):
(AccessibilityUIElement::removeSelection):
(AccessibilityUIElement::uiElementForSearchPredicate):
(AccessibilityUIElement::numberAttributeValue):
- 12:06 PM Changeset in webkit [144656] by
-
- 2 edits in trunk/Source/WebCore
Use initialization from literal for MediaFeatureNames
https://bugs.webkit.org/show_bug.cgi?id=111283
Reviewed by Andreas Kling.
- css/MediaFeatureNames.cpp:
(WebCore::MediaFeatureNames::init):
Initialization from literal is faster and use less memory. The names are
defined statically in MediaFeatureNames.h.
Also use the NotNull placement new to avoid a branch on silly allocators.
- 11:45 AM Changeset in webkit [144655] by
-
- 2 edits in trunk/LayoutTests
(tests) flexbox/resources.css should use unprefixed properties, for firefox
https://bugs.webkit.org/show_bug.cgi?id=111010
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-04
Reviewed by Tony Chang.
Search & replace to remove -moz- prefixes, as per
https://developer.mozilla.org/en-US/docs/CSS/Using_CSS_flexible_boxes:
"Gecko implementation is unprefixed (and is no longer behind a
preference as of Firefox 20)"
- css3/flexbox/resources/flexbox.css:
(.flexbox):
(.inline-flexbox):
(.flex-none):
(.flex-auto):
(.flex-one):
(.row):
(.row-reverse):
(.column):
(.column-reverse):
(.wrap):
(.wrap-reverse):
(.align-content-flex-start):
(.align-content-flex-end):
(.align-content-center):
(.align-content-space-between):
(.align-content-space-around):
(.align-content-stretch):
(.align-items-flex-start):
(.align-items-flex-end):
(.align-items-center):
(.align-items-baseline):
(.align-items-stretch):
(.align-self-auto):
(.align-self-flex-start):
(.align-self-flex-end):
(.align-self-center):
(.align-self-baseline):
(.align-self-stretch):
(.justify-content-flex-start):
(.justify-content-flex-end):
(.justify-content-center):
(.justify-content-space-between):
(.justify-content-space-around):
- 11:44 AM Changeset in webkit [144654] by
-
- 2 edits in trunk/Source/Platform
[chromium] Add ability to wait on async upload completion
https://bugs.webkit.org/show_bug.cgi?id=110987
Reviewed by James Robinson.
Add a graphics context entry point for waiting on asynchronous upload
completion. The wait is performed server-side so the call is
non-blocking.
See https://codereview.chromium.org/12210129/
- chromium/public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::waitAsyncTexImage2DCHROMIUM):
- 11:42 AM Changeset in webkit [144653] by
-
- 7 edits in branches/safari-536.29-branch
<rdar://problem/13337144> - Update 536.29 branch Loader and UI client layouts
Reviewed by Anders Carlsson.
Source/WebKit2:
- Shared/APIClientTraits.cpp:
- Shared/APIClientTraits.h:
- UIProcess/API/C/WKPage.h:
Tools:
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
- 11:32 AM Changeset in webkit [144652] by
-
- 8 edits in trunk/Source/WebKit2
[GTK] Some WebKit2 GTK+ unit tests are failing in 32 bits bot
https://bugs.webkit.org/show_bug.cgi?id=111346
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-04
Reviewed by Martin Robinson.
The problem is the use of a temporary CString object in the macro
g_assert_cmpstr. It's a common mistake because we usually forget
that g_assert_cmpstr is not a function but a macro, that expands
to multiple lines. This patch adds a new macro ASSERT_CMP_CSTRING
with the same implementation that g_assert_cmpstr, but using
CStrings instead of const char*. It fixes all the cases where a
temporary CString was used in g_assert_cmpstr, and uses the new
macro also for the cases where we were caching the CString just
for g_assert_cmpstr.
- UIProcess/API/gtk/tests/TestDownloads.cpp:
(testDownloadRemoteFile):
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(testInspectorServerPageList):
- UIProcess/API/gtk/tests/TestLoaderClient.cpp:
- UIProcess/API/gtk/tests/TestMain.h:
- UIProcess/API/gtk/tests/TestResources.cpp:
- UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(testGetFaviconURI):
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(assertThatUserAgentIsSentInHeaders):
(testWebKitSettingsUserAgent):
- 11:30 AM Changeset in webkit [144651] by
-
- 29 edits in trunk/Source/WebCore
[V8] Unreviewed. Rebaselined run-bindings-tests following r144617
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
- bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::TestActiveDOMObjectV8Internal::TestActiveDOMObjectDomainSafeFunctionSetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetTemplate):
- bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructorConstructor):
(V8TestNamedConstructor):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::GetTemplate):
- bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::installPerContextPrototypeProperties):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
- bindings/scripts/test/V8/V8TestTypedefs.h:
(V8TestTypedefs):
- 11:20 AM Changeset in webkit [144650] by
-
- 2 edits in tags/Safari-537.31.13/Source/WebCore
Merged r144577. <rdar://problem/13328176>
- 11:04 AM Changeset in webkit [144649] by
-
- 4 edits1 delete in trunk/Source
Unreviewed, rolling out r144562.
http://trac.webkit.org/changeset/144562
https://bugs.webkit.org/show_bug.cgi?id=85642
Caused KeyPadInsert faluires in webkit_unittests
Source/WebCore:
- platform/chromium/KeyCodeConversionGtk.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
Source/WebKit/chromium:
- WebKit.gypi:
- tests/KeyCodeConversionTestGtk.cpp: Removed.
- 11:01 AM Changeset in webkit [144648] by
-
- 4 edits in tags/Safari-537.31.13/Source
Versioning.
- 10:59 AM Changeset in webkit [144647] by
-
- 3 edits2 adds in trunk
getComputedStyle not implemented for -webkit-columns shorthand
https://bugs.webkit.org/show_bug.cgi?id=111236
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-03-04
Reviewed by Alexis Menard.
Source/WebCore:
Implement getComputedStyle for -webkit-columns shorthand.
Test: fast/css/getComputedStyle/getComputedStyle-webkit-columns-shorthand.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
LayoutTests:
Add test to check getComputedStyle for -webkit-columns.
- fast/css/getComputedStyle/getComputedStyle-webkit-columns-shorthand-expected.txt: Added.
- fast/css/getComputedStyle/getComputedStyle-webkit-columns-shorthand.html: Added.
- 10:56 AM Changeset in webkit [144646] by
-
- 5 edits in trunk/Source
Add support for 8 bit TextRuns on Chromium Linux & Mac
https://bugs.webkit.org/show_bug.cgi?id=99393
Reviewed by Eric Seidel.
Source/WebCore:
Adding support for 8 bit TextRuns for Mac and Linux Chromium. To accomplish this,
8 bit text runs are upconverted to 16 bit in the complex text path during string
normalization, as HarfBuzz operates on UChars.
Windows has platfom assumptions that TextRuns are 16 bit that need to be addressed
before enabling this optimization.
No new tests. No change in behavior.
(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):
- platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::normalizeCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
Source/WebKit/chromium:
Enabling 8 bit text runs for Linux and Mac platforms.
- features.gypi:
- 10:50 AM Changeset in webkit [144645] by
-
- 1 copy in tags/Safari-537.31.13
New Tag.
- 10:49 AM Changeset in webkit [144644] by
-
- 5 edits in trunk
transition-property property and transition shorthand property doesn't accept "all, all".
https://bugs.webkit.org/show_bug.cgi?id=111201
Reviewed by Simon Fraser.
Source/WebCore:
Relax the parsing of transition-property to allow all, all as a value.
It is not very useful per say but it is possible by the spec and we
align with Firefox, IE and Opera.
Test: LayoutTests/transitions/transitions-parsing.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseAnimationProperty):
LayoutTests:
Updated the tests to cover the bug.
- transitions/transitions-parsing-expected.txt:
- transitions/transitions-parsing.html:
- 10:34 AM Changeset in webkit [144643] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Add a new dependency on jsr-305 for Android
https://bugs.webkit.org/show_bug.cgi?id=111340
Unreviewed build fix; new Android dependency. This is
currently breaking gyp generation on the Android bots.
- DEPS:
- 10:23 AM Changeset in webkit [144642] by
-
- 2 edits in trunk/Source/WebCore
Don't apply page scale to clipRect if applyPageScaleFactorInCompositor is set to true
https://bugs.webkit.org/show_bug.cgi?id=111229
Patch by Min Qin <qinmin@chromium.org> on 2013-03-04
Reviewed by Simon Fraser.
If applyPageScaleFactorInCompositor is set to true, webcore should use css coordinates.
As a result, we shouldn't apply page scale to clipRect in RenderLayerCompositor.
Layout tests set the flag to false, so we don't have anything to test against.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):
- 9:46 AM Changeset in webkit [144641] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add simple vector traits for JSC::Identifier.
<http://webkit.org/b/111323>
Reviewed by Geoffrey Garen.
Identifiers are really just Strings, giving them simple vector traits makes
Vector move them with memcpy() instead of churning the refcounts.
- runtime/Identifier.h:
(WTF):
- 9:41 AM Changeset in webkit [144640] by
-
- 12 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Upstream selection start animation.
https://bugs.webkit.org/show_bug.cgi?id=111335
Patch by Iris Wu <shuwu@rim.com> on 2013-03-04
Reviewed by Rob Buis.
PR 219960
To indicate selection starts, we draw an overlay rect larger than
the selected word at the start of selection. Then shrink it down
to the actual size.
Reviewed Internally by Genevieve Mak and Andrew Lo and Mike Fenton.
- Api/WebAnimation.cpp:
(BlackBerry::WebKit::WebAnimation::shrinkAnimation):
(WebKit):
- Api/WebAnimation.h:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::selectionHighlight):
(WebKit):
- Api/WebPage.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- Api/WebTapHighlight.h:
- WebKitSupport/DefaultTapHighlight.cpp:
(WebKit):
(BlackBerry::WebKit::shrinkAnimationName):
(BlackBerry::WebKit::DefaultTapHighlight::draw):
- WebKitSupport/DefaultTapHighlight.h:
(DefaultTapHighlight):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::cancelSelection):
(BlackBerry::WebKit::textGranularityFromSelectionExpansionType):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::selectNodeIfFatFingersResultIsLink):
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
- WebKitSupport/SelectionHandler.h:
(SelectionHandler):
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 9:29 AM Changeset in webkit [144639] by
-
- 8 edits in trunk
ASSERTION FAILED: m_clipRectsCache->m_respectingOverflowClip[clipRectsType] == (clipRectsContext.respectOverflowClip == RespectOverflowClip) in RenderLayer.
https://bugs.webkit.org/show_bug.cgi?id=108257
Reviewed by David Hyatt.
Source/WebCore:
With composited scrolling we paint both with and without respecting
overflow clip. To prevent collisions in the clip cache, and to prevent
throwing away cached clips unnecessarily, we keep two copies of the
clip cache -- one for when overflow clip is respected, and one for
when it isn't.
No new tests. Covered by existing tests (in debug):
compositing/overflow/automatically-opt-into-composited-scrolling.html
compositing/overflow/composited-scrolling-creates-a-stacking-container.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateClipRects):
No longer asserts that our 'respect overflow clip' status is
consistent. It also gets and sets the clip cache using the clip rect
context rather than just the clip rect type.
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::clearClipRects):
(WebCore::ClipRectsCache::ClipRectsCache):
(WebCore::ClipRectsCache::getClipRects):
(WebCore::ClipRectsCache::setClipRects):
(WebCore::ClipRectsCache::getIndex):
Get and set the cached clip rects using the context rather than
type.
(WebCore::RenderLayer::clipRects):
We now cache twice as many clip rects.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
ShouldRespectOverflowClip was moved out of RenderLayer.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateClipRects):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::clearClipRects):
- rendering/RenderLayer.h:
(WebCore::ClipRectsCache::ClipRectsCache):
(WebCore::ClipRectsCache::getClipRects):
(WebCore::ClipRectsCache::setClipRects):
(ClipRectsCache):
(WebCore::ClipRectsCache::getIndex):
(WebCore::RenderLayer::clipRects):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
LayoutTests:
- platform/efl-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt-5.0-wk2/TestExpectations:
- 9:24 AM Changeset in webkit [144638] by
-
- 7 edits in trunk/Source
Remove unused return value from SourceBufferPrivate::abort() and WebSourceBuffer::abort().
https://bugs.webkit.org/show_bug.cgi?id=111195
Reviewed by Adam Barth.
Source/WebCore:
No new tests. No user visible behavior changed.
- platform/graphics/SourceBufferPrivate.h:
(SourceBufferPrivate):
Source/WebKit/chromium:
- public/WebSourceBuffer.h:
(WebSourceBuffer):
- src/SourceBufferPrivateImpl.cpp:
(WebKit::SourceBufferPrivateImpl::abort):
- src/SourceBufferPrivateImpl.h:
(SourceBufferPrivateImpl):
- src/WebMediaPlayerClientImpl.cpp:
(WebSourceBufferImpl):
(WebKit::WebSourceBufferImpl::abort):
- 9:16 AM Changeset in webkit [144637] by
-
- 2 edits in trunk/Source/WebCore
[New Multicolumn] Eliminate the unique multicolumn flow thread style creation function
https://bugs.webkit.org/show_bug.cgi?id=111338
Reviewed by Allan Jensen.
There is nothing special about a multi-column flow thread style now, so we can just
use the existing anonymous style creation function.
- rendering/RenderMultiColumnBlock.cpp:
(WebCore):
(WebCore::RenderMultiColumnBlock::addChild):
- 9:06 AM Changeset in webkit [144636] by
-
- 9 edits in trunk/Source/WebCore
[GTK] WebCore::returnString is unsafe and should be removed!
https://bugs.webkit.org/show_bug.cgi?id=110423
Reviewed by Martin Robinson.
Remove returnString() and replace it in callers with a new
function that will cache and return the values of string
properties for ATK interfaces in the private section of the
wrapper AtkObject WebKitAccessible.
- accessibility/atk/WebKitAccessibleUtil.cpp: Remove returnString().
- accessibility/atk/WebKitAccessibleUtil.h: Ditto.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(_WebKitAccessiblePrivate): New private structure to store cached
values of string property for the different ATK interfaces.
(cacheAndReturnAtkProperty): New helper function to make sure the
returned const gchar* value is previously cached in the private
section of the wrapper AtkObject.
(webkitAccessibleGetName): Use the new helper function.
(webkitAccessibleGetDescription): Ditto.
(webkitAccessibleInit): Initialize pointer to private structure.
(webkitAccessibleFinalize): Remove unneeded code.
(webkitAccessibleClassInit): Add private struct to class type/
- accessibility/atk/WebKitAccessibleWrapperAtk.h:
(_WebKitAccessible): New member pointing to the private structure,
made the new helper function cacheAndReturnAtkProperty() available
to external callers (implementation files for ATK interfaces).
(AtkCachedProperty): New enum to allow reusing code when calling
cacheAndReturnAtkProperty() to cache and return different properties.
- accessibility/atk/WebKitAccessibleInterfaceAction.cpp:
(webkitAccessibleActionGetKeybinding): Replace calls to returnString()
with calls to the new helper function cacheAndReturnAtkProperty().
(webkitAccessibleActionGetName): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:
(documentAttributeValue): Ditto.
(webkitAccessibleDocumentGetLocale): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceImage.cpp:
(webkitAccessibleImageGetImageDescription): Ditto.
Remove returnString() from WebKitAccessibleHyperlink (which is not
an AtkObject, but a GObject) as well, replacing it in callers with
simple code that will cache and return the required values in the
private section of these kind of objects.
- accessibility/atk/WebKitAccessibleHyperlink.cpp:
(_WebKitAccessibleHyperlinkPrivate): Added two new fields to cache
string values for the key binding and name properties from the
AtkAction interface, which is implemented by AtkHyperlink.
(webkitAccessibleHyperlinkActionGetKeybinding): Cache the string
value for the key binding before returning a const gchar* pointer.
(webkitAccessibleHyperlinkActionGetName): Ditto.
(webkitAccessibleHyperlinkGetURI): Do not cache the URI here, as
this function returns a gchar* that will be owned by the caller.
- 9:04 AM Changeset in webkit [144635] by
-
- 7 edits in trunk/Tools
[chromium] pass all focus handling methods through the WebTestDelegate
https://bugs.webkit.org/show_bug.cgi?id=111328
Reviewed by Nico Weber.
In content_shell, the focus handling is asynchronous. To allow for
switching the focus synchronously between WebViews, we need to intercept
didFocus and didBlur and forward it to the WebTestDelegate.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestDelegate):
(WebTestRunner::WebTestDelegate::setFocus):
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestRunner::WebTestProxy::didFocus):
(WebTestRunner::WebTestProxy::didBlur):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::setWindowIsKey):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::didFocus):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::didBlur):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didFocus):
(WebViewHost::didBlur):
(WebViewHost::setFocus):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 8:50 AM Changeset in webkit [144634] by
-
- 2 edits in trunk/Source/WebCore
[Curl] Compile fix after r144216
https://bugs.webkit.org/show_bug.cgi?id=111305
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-03-04
Reviewed by Brent Fulgham.
- platform/network/curl/ResourceRequest.h:
(WebCore::ResourceRequest::cfURLRequest): Added new parameter.
- 8:43 AM Changeset in webkit [144633] by
-
- 5 edits2 adds in trunk
[New Multicolumn] Make sure region styling works for columns inside regions.
https://bugs.webkit.org/show_bug.cgi?id=111276
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/regions/region-styling-in-columns.html
- rendering/RenderFlowThread.cpp:
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
- rendering/RenderFlowThread.h:
(CurrentRenderFlowThreadMaintainer):
Fix the CurrentRenderFlowThreadMaintainer so that it saves off the old render flow thread
and restores it when done. This effectively makes flow thread layout a push/pop stack,
since with in-flow threads, this is allowed. We assert that a nested flow thread is
in-flow to preserve the invariant that you can't nest CSS Regions flow thread.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::computeChildrenStyleInRegion):
Add isInFlowRenderFlowThread() to the anonymous check to make sure a style gets made
for the nested flow thread.
LayoutTests:
- fast/regions/region-style-in-columns-expected.html: Added.
- fast/regions/region-style-in-columns.html: Added.
- 8:36 AM Changeset in webkit [144632] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: WebInspector.AceTextEditor throws a warning
https://bugs.webkit.org/show_bug.cgi?id=111315
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-04
Reviewed by Pavel Feldman.
Add WebInspector.AceTextEditor to externs.js to suppress closure
compilation warning.
No new tests: no change in behaviour.
- inspector/front-end/externs.js:
(WebInspector.AceTextEditor):
- 8:22 AM Changeset in webkit [144631] by
-
- 4 edits in trunk/Source/WebCore
Fix debug build under certain configurations, cause was
http://trac.webkit.org/changeset/144624.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
- inspector/InspectorLayerTreeAgent.h:
(WebCore):
(WebCore::InspectorLayerTreeAgent::create):
(InspectorLayerTreeAgent):
- 8:22 AM Changeset in webkit [144630] by
-
- 2 edits in trunk/Source/WTF
Deque: Free internal buffer in clear().
<http://webkit.org/b/111316>
<rdar://problem/13336675>
Reviewed by Antti Koivisto.
525 kB progression on Membuster3.
- wtf/Deque.h:
(WTF::::clear):
- 8:21 AM Changeset in webkit [144629] by
-
- 37 edits4 copies76 adds in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening. Updated platform specific expected files and png results.
- platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
- platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-expected.png: Added.
- platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-expected.txt: Added.
- platform/qt-5.0-wk2/css3/filters/composited-reflected-expected.png:
- platform/qt-5.0-wk2/css3/filters/composited-reflected-expected.txt: Added.
- platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png:
- platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.txt: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
- platform/qt-5.0-wk2/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/qt-5.0-wk2/fast/clip/overflow-border-radius-composited-expected.txt: Added.
- platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
- platform/qt-5.0-wk2/fast/overflow/position-fixed-transform-clipping-expected.png: Added.
- platform/qt-5.0-wk2/fast/overflow/position-fixed-transform-clipping-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-in-regions-expected.png:
- platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/reflection-repaint-test-expected.png:
- platform/qt-5.0-wk2/fast/repaint/reflection-repaint-test-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/region-painting-invalidation-expected.png:
- platform/qt-5.0-wk2/fast/repaint/region-painting-invalidation-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/region-painting-via-layout-expected.png:
- platform/qt-5.0-wk2/fast/repaint/region-painting-via-layout-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.txt: Added.
- platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png: Added.
- platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.txt: Added.
- platform/qt-5.0-wk2/fast/ruby/position-after-expected.png: Added.
- platform/qt-5.0-wk2/fast/ruby/position-after-expected.txt: Added.
- platform/qt-5.0-wk2/fast/table/border-collapsing/004-vertical-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/border-collapsing/004-vertical-expected.txt: Added.
- platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
- platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
- platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
- platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
- platform/qt-5.0-wk2/svg/custom/visibility-override-filter-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png.
- platform/qt-5.0-wk2/svg/custom/visibility-override-filter-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/filters/big-sized-filter-2-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/big-sized-filter-2-expected.txt: Added.
- platform/qt-5.0-wk2/svg/filters/filterRes1-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png.
- platform/qt-5.0-wk2/svg/filters/filterRes1-expected.txt: Added.
- platform/qt-5.0-wk2/svg/filters/filterRes3-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png.
- platform/qt-5.0-wk2/svg/filters/filterRes3-expected.txt: Added.
- platform/qt-5.0-wk2/svg/filters/parent-children-with-same-filter-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png.
- platform/qt-5.0-wk2/svg/filters/parent-children-with-same-filter-expected.txt: Added.
- platform/qt-5.0-wk2/svg/filters/shadow-on-filter-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/shadow-on-filter-expected.txt: Added.
- platform/qt-5.0-wk2/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
- platform/qt-5.0-wk2/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
- platform/qt-5.0-wk2/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
- platform/qt-5.0-wk2/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Added.
- platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt: Added.
- 8:04 AM Changeset in webkit [144628] by
-
- 2 edits in trunk/Tools
[GTK] No need to manually add system paths to jhbuildrc
https://bugs.webkit.org/show_bug.cgi?id=110850
Reviewed by Gustavo Noronha Silva.
- gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild
already takes care of.
- 7:53 AM Changeset in webkit [144627] by
-
- 2 edits in trunk/Source/WebCore
[Qt] REGRESSION(r141240) Crash in PluginPackage::fetchInfo
https://bugs.webkit.org/show_bug.cgi?id=111322
Reviewed by Simon Hausmann.
Do not try to load blacklisted plugins.
- plugins/qt/PluginPackageQt.cpp:
(WebCore::PluginPackage::fetchInfo):
- 7:09 AM Changeset in webkit [144626] by
-
- 15 edits in trunk
transition properties can't be found in CSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=110011
Reviewed by Antti Koivisto.
Source/WebCore:
The previous approach for handling the unprefixing was to alias the
unprefixed properties with the prefixed ones in CSSPropertyNames.in.
Unfortunately it will alias the properties in the parsing code which will just
identically parse the two versions. This means that when we populate StylePropertySet
we do not have information whether we just parsed the prefixed, the
unprefixed properties or we parsed both. The patch takes another
approach by creating two distinct sets of properties (unprefixed and
prefixed). Each properties have their own id and we now handle them in
the parsing code as disctints properties and add both versions to the
declared style. In order to avoid properties getting out of sync,
this patch adds few facilities to StylePropertySet to update the
prefixed and the unprefixed entries. Finally the style resolution
happens only for the prefixed version (to limit the size of this patch)
and the unprefixed versions are not resolved. This is to avoid creating
the animation objects twice for the resolved style.
Test : transitions/transitions-parsing.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::addPropertyWithPrefixingVariant): Always add the
prefixed and the unprefixed property even if only one is specified.
(WebCore):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTransitionShorthand): Add both prefixed and
unprefixed longhands to the declarated style.
(WebCore::CSSParser::parseAnimationProperty):
- css/CSSParser.h:
(CSSParser):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSProperty.h:
(WebCore:: prefixingVariantForPropertyId): This function takes a given
property id and returns its prefixed or unprefixed id if it exists. If
not it returns the same id.
(WebCore):
- css/CSSPropertyNames.in:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::removeProperty): Remove
also the prefixed or unprefixed shorthand if it exists.
(WebCore):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet:: appendPrefixingVariantProperty):
(WebCore::StylePropertySet::setPrefixingVariantProperty): If it
exists a unprefixed or prefixed counterpart of the property we're
trying to set, then we update the other one.
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::mergeAndOverrideOnConflict):
- css/StylePropertySet.h:
(StylePropertySet):
- css/StylePropertyShorthand.cpp:
(WebCore::transitionShorthand):
(WebCore):
(WebCore::shorthandForProperty): Define the transitions unprefixed
longhands.
- css/StylePropertyShorthand.h:
(WebCore):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty): StyleBuilder will handle the
resolution and the creation of the animations for the style. As the
declarated style now contains declarations for the prefixed and
unprefixed property we do not want to resolve two times and create duplicate animations.
Therefore when we try to resolve the unprefixed version we just bail out.
LayoutTests:
Updated layout test to cover the bug.
- transitions/transitions-parsing-expected.txt:
- transitions/transitions-parsing.html:
- 7:07 AM Changeset in webkit [144625] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: CPU Flame Chart: reveal profiler DataGrid node when user clicks on a FlameChart item.
https://bugs.webkit.org/show_bug.cgi?id=111309
Reviewed by Yury Semikhatsky.
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.prototype._revealProfilerNode):
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._onClick):
- 6:07 AM Changeset in webkit [144624] by
-
- 7 edits4 deletes in trunk
Web Inspector: remove existing LayerTreeAgent protocol APIs
https://bugs.webkit.org/show_bug.cgi?id=111251
Source/WebCore:
In order to eventually provide a more useful API for the LayerTreeAgent
that will be done in followup bugs, we remove the current API exposed by
the agent providing a clean slate that will make future patches easier
to read. Additionally, we remove the "childLayers" property on the Layer
object since we will no longer be providing a hierarchy of layers, but
rather a flat list of layers attached to a node and its descendants.
No new tests since we're removing the APIs exposed by the LayerTreeAgent.
Subsequent patches will add tests as new APIs are added.
Reviewed by Timothy Hatcher.
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDOMAgent.h:
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
- inspector/InspectorLayerTreeAgent.h:
(InspectorLayerTreeAgent):
LayoutTests:
Remove existing tests since they're testing API that we're
removing.
Reviewed by Timothy Hatcher.
- inspector-protocol/layer-tree-expected.txt: Removed.
- inspector-protocol/layer-tree-generated-content-expected.txt: Removed.
- inspector-protocol/layer-tree-generated-content.html: Removed.
- inspector-protocol/layer-tree.html: Removed.
- 5:54 AM Changeset in webkit [144623] by
-
- 5 edits in trunk
MediaStream.ended must return true when it is created with ended tracks.
https://bugs.webkit.org/show_bug.cgi?id=111293
Reviewed by Kentaro Hara.
Source/WebCore:
Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#MediaStream-ended
When a MediaStream object is created, its ended attribute must be set to false,
unless it is being created using the MediaStream() constructor whose arguments
are lists of MediaStreamTrack objects that are all ended, in which case the
MediaStream object must be created with its ended attribute set to true.
Test: fast/mediastream/MediaStreamConstructor.html
- platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
LayoutTests:
- fast/mediastream/MediaStreamConstructor-expected.txt:
- fast/mediastream/MediaStreamConstructor.html:
- 5:34 AM Changeset in webkit [144622] by
-
- 3 edits2 adds in trunk
Web Inspector: Adding new rules broken if a <style> tag is added to document dynamically
https://bugs.webkit.org/show_bug.cgi?id=111299
Reviewed by Pavel Feldman.
Source/WebCore:
The CSSStyleSheet instance should be retrieved directly from the HTMLStyleElement just created,
not from the document.styleSheets list.
Test: inspector/styles/add-new-rule-with-style-after-body.html
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
LayoutTests:
- inspector/styles/add-new-rule-with-style-after-body-expected.txt: Added.
- inspector/styles/add-new-rule-with-style-after-body.html: Added.
- 5:15 AM Changeset in webkit [144621] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Unreviewed. Fix for closure type annotations.
- inspector/front-end/FlameChart.js:
- 5:07 AM Changeset in webkit [144620] by
-
- 4 edits in trunk/Source/WebCore
[EFL] Build fix when compiling with GLES2 support enabled.
https://bugs.webkit.org/show_bug.cgi?id=111291
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-04
Reviewed by Kenneth Rohde Christiansen.
This patch fixes build issues when compiling with GLES2
support. As part of the fix the patch removes Evas specific
workaround of using GLX with EGL in PlatformContext as GLES2
is the main target with EGL.
- platform/graphics/OpenGLESShims.h:
- platform/graphics/opengl/GLPlatformContext.cpp:
(WebCore::GLCurrentContextWrapper::GLCurrentContextWrapper):
- platform/graphics/texmap/TextureMapper.h:
- 5:00 AM Changeset in webkit [144619] by
-
- 2 edits in trunk/Tools
[chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
https://bugs.webkit.org/show_bug.cgi?id=111284
Disabling the failing two tests on Android.
Reviewed by Jochen Eisinger.
- TestWebKitAPI/Tests/WTF/StringHasher.cpp:
(TestWebKitAPI):
(TestWebKitAPI::TEST):
- 4:39 AM Changeset in webkit [144618] by
-
- 9 edits2 adds in trunk/Source/WebCore
Web Inspector: implement Flame Chart for CPU profiler.
https://bugs.webkit.org/show_bug.cgi?id=111162
Reviewed by Yury Semikhatsky.
It is an initial implementation. The next step is to provide
function names and other stats about the hovered item.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- inspector/compile-front-end.py:
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.prototype._getCPUProfileCallback):
- inspector/front-end/FlameChart.js: Added.
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype.findNodeCallback):
(WebInspector.FlameChart.prototype._coordinatesToNode):
(WebInspector.FlameChart.prototype.onResize):
(WebInspector.FlameChart.prototype._rootNodes):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._drawNode):
(WebInspector.FlameChart.prototype._forEachNode):
(WebInspector.FlameChart.prototype._drawBar):
(WebInspector.FlameChart.prototype.update):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/flameChart.css: Added.
(.flame-chart):
- 4:26 AM Changeset in webkit [144617] by
-
- 25 edits in trunk/Source/WebCore
[V8] Add a "context type" parameter to GetTemplate and ConfigureV8SomethingTemplate functions
https://bugs.webkit.org/show_bug.cgi?id=110875
The parameter will later be used for generating specialized V8
bindings for the 3 different world types (main world, isolated
work, worker).
Patch by Marja Hölttä <marja@chromium.org> on 2013-03-04
Reviewed by Kentaro Hara.
No new tests (no changes in behavior yet).
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateNormalAttrGetter):
(GenerateNamedConstructor):
(GenerateImplementation):
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
- bindings/v8/DOMDataStore.h:
(DOMDataStore):
- bindings/v8/DOMWrapperWorld.cpp:
(WebCore):
(WebCore::DOMWrapperWorld::setInitializingWindow):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::contextHasCorrectPrototype):
- bindings/v8/DOMWrapperWorld.h:
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::getWorld):
- bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
- bindings/v8/PageScriptDebugServer.cpp:
(WebCore::retrieveFrameWithGlobalObjectCheck):
- bindings/v8/V8AdaptorFunction.cpp:
(WebCore::V8AdaptorFunction::getTemplate):
(WebCore::V8AdaptorFunction::wrap):
- bindings/v8/V8AdaptorFunction.h:
(V8AdaptorFunction):
- bindings/v8/V8Binding.cpp:
(WebCore::toDOMWindow):
(WebCore::toScriptExecutionContext):
(WebCore::worldType):
(WebCore):
(WebCore::worldTypeInMainThread):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::clearForNavigation):
(WebCore::V8DOMWindowShell::installDOMWindow):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::createWrapper):
- bindings/v8/V8Initializer.cpp:
(WebCore::findFrame):
- bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::constructorForTypeSlowCase):
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::controllerForContext):
- bindings/v8/WrapperTypeInfo.h:
(WebCore::WrapperTypeInfo::getTemplate):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::eventAttrGetterCustom):
(WebCore::V8DOMWindow::eventAttrSetterCustom):
(WebCore::V8DOMWindow::toStringMethodCustom):
(WebCore::V8DOMWindow::namedSecurityCheck):
(WebCore::V8DOMWindow::indexedSecurityCheck):
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::wrapInShadowObject):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::V8HTMLImageElementConstructor::GetTemplate):
- bindings/v8/custom/V8HTMLImageElementConstructor.h:
(V8HTMLImageElementConstructor):
- bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::createInjectedScriptHostV8Wrapper):
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::initMessageEventMethodCustom):
- 4:13 AM Changeset in webkit [144616] by
-
- 2 edits in trunk/LayoutTests
2013-03-04 Kinuko Yasuda <kinuko@chromium.org>
[Chromium] Unreviewed, removing failure test expectations for passing tests.
- platform/chromium/TestExpectations:
- 3:45 AM Changeset in webkit [144615] by
-
- 6 edits9 adds in trunk/Source
Web Inspector: add Ace editor experiment
https://bugs.webkit.org/show_bug.cgi?id=111191
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-04
Reviewed by Pavel Feldman.
Source/WebCore:
No new tests.
Add Ace text editor experiment.
- WebCore.gypi:
- inspector/front-end/AceTextEditor.js: Added.
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
- inspector/front-end/ace/ace.js: Added.
- inspector/front-end/ace/acedevtools.css: Added.
- inspector/front-end/ace/mode_css.js: Added.
- inspector/front-end/ace/mode_html.js: Added.
- inspector/front-end/ace/mode_javascript.js: Added.
- inspector/front-end/ace/theme_textmate.js: Added.
- inspector/front-end/ace/LICENSE.txt: Added.
Source/WebKit/chromium:
Add target to concatenate js files for Ace Text Editor.
- WebKit.gyp:
- 3:40 AM Changeset in webkit [144614] by
-
- 22 edits in trunk
Add build flag for FontLoader
https://bugs.webkit.org/show_bug.cgi?id=111289
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-04
Reviewed by Benjamin Poulain.
Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
.:
- Source/autotools/SetupWebKitFeatures.m4:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 3:25 AM Changeset in webkit [144613] by
-
- 4 edits2 adds in trunk
XSSAuditor should strip dangerous attributes from SMIL animation elements.
https://bugs.webkit.org/show_bug.cgi?id=111071
Reviewed by Adam Barth.
Source/WebCore:
SMIL animation elements can, amusingly enough, animate the 'href' of a
link. This patch teaches XSSAuditor how to deal with the
semicolon-separated 'animation[values]' attribute in order to ensure
that it doesn't contain JavaScript URLs that could be animated into
place for an unsuspecting user to click on.
Test: http/tests/security/xssAuditor/svg-animate.html
- html/parser/XSSAuditor.cpp:
(WebCore::isSemicolonSeparatedAttribute): Added.
This returns true if the given attribute is SVGNames::valuesAttr,
but makes it possible to easily extend the list with additional
attributes with this strange property.
(WebCore::semicolonSeparatedValueContainsJavaScriptURL): Added.
Given a semicolon-separated string, determine if it contains any
JavaScript URLs.
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
When looking for dangerousness, determine whether or not we should
be comparing against each member of a semicolon-separated list.
LayoutTests:
- http/tests/security/xssAuditor/resources/echo-intertag.pl:
Add a new mode that dumps an element and its attributes, which is a
bit more robust than adding a new mode for each attribute type we're
interested in.
- http/tests/security/xssAuditor/svg-animate-expected.txt: Added.
- http/tests/security/xssAuditor/svg-animate.html: Added.
- 3:09 AM Changeset in webkit [144612] by
-
- 1 edit16 adds in trunk/Source/WebCore
[BlackBerry] New files for BlackBerry::Platform::Graphics::GraphicsContext integration
https://bugs.webkit.org/show_bug.cgi?id=111153
Reviewed by Rob Buis.
BlackBerry PR 293208
This patch contains contributions from many members of the BlackBerry
WebKit team:
Rob Buis
Robin Cao
Eli Fidler
Mike Lattanzio
Yong Li
Maxim Mogilnitsky
Joshua Netterfield
Arvid Nilsson
Jakob Petsovits
Konrad Piascik
Jeff Rogers
Artem Simonov
Filip Spacek
George Staikos
Covered by existing tests.
- platform/graphics/blackberry/FontBlackBerry.cpp: Added.
(FSFixedToFloat):
(FloatToFSFixed):
(WebCore):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawGlyphs):
(WebCore::Font::canReturnFallbackFontsForComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::canExpandAroundIdeographsInComplexText):
- platform/graphics/blackberry/FontCacheBlackBerry.cpp: Added.
(WebCore):
(WebCore::FontCache::platformInit):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::getFamilyNameStringFromFontDescriptionAndFamily):
(WebCore::fontWeightToFontconfigWeight):
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/blackberry/FontCustomPlatformData.h: Added.
(WebCore):
(FontCustomPlatformData):
- platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp: Added.
(WebCore):
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::FontCustomPlatformData::supportsFormat):
(WebCore::createFontCustomPlatformData):
- platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp: Added.
(WebCore):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::name):
(WebCore::FontPlatformData::applyState):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::platformIsEqual):
(WebCore::FontPlatformData::description):
(WebCore::FontPlatformData::harfbuzzFace):
(WebCore::FontPlatformData::scaledFont):
(WebCore::FontPlatformData::setFakeBold):
(WebCore::FontPlatformData::setFakeItalic):
(WebCore::FontPlatformData::platformFontHandle):
(WebCore::FontPlatformData::isFixedPitch):
- platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp: Added.
(WebCore):
(WorldTypeScopedPtr):
(WebCore::WorldTypeScopedPtr::WorldTypeScopedPtr):
(WebCore::WorldTypeScopedPtr::~WorldTypeScopedPtr):
(WebCore::WorldTypeScopedPtr::get):
(WebCore::GlyphPage::fill):
- platform/graphics/blackberry/GradientBlackBerry.cpp: Added.
(WebCore):
(WebCore::totalStopsNeeded):
(WebCore::fillStops):
(WebCore::Gradient::platformGradient):
(WebCore::Gradient::platformDestroy):
(WebCore::Gradient::fill):
(WebCore::Gradient::setPlatformGradientSpaceTransform):
- platform/graphics/blackberry/GraphicsContextBlackBerry.cpp: Added.
(WebCore):
(GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::platformContext):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::setIsAcceleratedContext):
(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clearPlatformShadow):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineDash):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::setMiterLimit):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::addRoundedRectClip):
(WebCore::GraphicsContext::clipOutRoundedRect):
(WebCore::GraphicsContext::clipBounds):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setPlatformTextDrawingMode):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformStrokeStyle):
(WebCore::GraphicsContext::setPlatformStrokeThickness):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::setPlatformShouldAntialias):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
- platform/graphics/blackberry/ITypeUtils.h: Added.
(floatToITypeFixed):
(intToITypeFixed):
(iTypeFixedToFloat):
- platform/graphics/blackberry/ImageBufferBlackBerry.cpp: Added.
(WebCore):
(WebCore::makeBufferCurrent):
(WebCore::getImageDataInternal):
(WebCore::ImageBufferData::getImageData):
(WebCore::flushAndDraw):
(WebCore::ImageBufferData::draw):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::~ImageBuffer):
(WebCore::ImageBuffer::context):
(WebCore::ImageBuffer::platformLayer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
- platform/graphics/blackberry/ImageBufferDataBlackBerry.h: Added.
(WebCore):
(ImageBufferData):
- platform/graphics/blackberry/PathBlackBerry.cpp: Added.
(WebCore):
(WebCore::scratchContext):
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore::Path::operator=):
(WebCore::Path::currentPoint):
(WebCore::Path::contains):
(WebCore::Path::strokeContains):
(WebCore::Path::translate):
(WebCore::Path::boundingRect):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::platformAddPathForRoundedRect):
(WebCore::Path::clear):
(WebCore::Path::isEmpty):
(WebCore::Path::hasCurrentPoint):
(WebCore::Path::apply):
(WebCore::Path::transform):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
- platform/graphics/blackberry/PatternBlackBerry.cpp: Added.
(WebCore):
(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):
(WebCore::Pattern::setPlatformPatternSpaceTransform):
- platform/graphics/blackberry/PlatformSupport.cpp: Added.
(WebCore):
(WebCore::PlatformSupport::getFontFamilyForCharacters):
- platform/graphics/blackberry/PlatformSupport.h: Added.
(WebCore):
(PlatformSupport):
(FontFamily):
- platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp: Added.
(WebCore):
(WebCore::FSFixedToFloat):
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformCharWidthInit):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
(WebCore::SimpleFontData::containsCharacters):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):
- 2:12 AM Changeset in webkit [144611] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Marking a few layout tests as flaky.
- 2:07 AM Changeset in webkit [144610] by
-
- 3 edits2 adds2 deletes in trunk
MediaStream API: local addTrack() and removeTrack() operations should not fire events.
https://bugs.webkit.org/show_bug.cgi?id=111079
Reviewed by Adam Barth.
Source/WebCore:
Removed the scheduling of "addtrack" and "removetrack" events by
addTrack and removeTrack(). Replaced the test since the old test was
driven by the event firing removed by this patch.
Test: fast/mediastream/MediaStream-add-remove-tracks.html
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
LayoutTests:
Replaced the test since the old test was driven by the event firing
removed by this patch.
- fast/mediastream/MediaStream-add-remove-tracks-expected.txt: Added.
- fast/mediastream/MediaStream-add-remove-tracks.html: Added.
- fast/mediastream/MediaStreamTrackList-expected.txt: Removed.
- fast/mediastream/MediaStreamTrackList.html: Removed.
- 1:39 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:37 AM Changeset in webkit [144609] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK][WK2] Add document-loaded signal to WebKitWebPage
https://bugs.webkit.org/show_bug.cgi?id=110614
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-04
Reviewed by Carlos Garcia Campos.
Add a new signal document-loaded to WebKitWebPage that will be emitted
when the DOM document has been loaded.
- UIProcess/API/gtk/tests/TestWebExtensions.cpp:
(documentLoadedCallback):
(testDocumentLoadedSignal):
(beforeAll): Add test for document-loaded signal.
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(documentLoadedCallback):
(pageCreatedCallback):
(methodCallCallback): Add new D-Bus signal DocumentLoaded in order to
test document-loaded signal.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkit_web_page_class_init):
(webkitWebPageCreate): Add document-loaded signal and emit it when
didFinishDocumentLoadForFrame is called.
- 1:36 AM Changeset in webkit [144608] by
-
- 5 edits in trunk
Web Inspector: touchmove not emulated inside iframe
https://bugs.webkit.org/show_bug.cgi?id=111292
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Move fake touch event dispatching from mouseMoved() into handleMouseMoveEvent()
and bail out earlier from dispatchSyntheticTouchEventIfEnabled() when the event
should be dispatched on a subframe.
- page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
LayoutTests:
- fast/events/touch/emulated-touch-iframe.html:
- fast/events/touch/resources/emulated-touch-iframe2.html:
- 1:33 AM Changeset in webkit [144607] by
-
- 15 edits in trunk/Source/WebCore
Long URLs in error messages should be shortened
https://bugs.webkit.org/show_bug.cgi?id=111133
Reviewed by Jochen Eisinger.
When generating console messages, we're often copying the page's URL
in order to add detail about where the error occurred. Generally, this
is fine, but in edge cases (multi-meg 'data:' URLs), we're using far
more memory than we should, and impacting performance.
This patch adds an 'elidedString()' method to KURL for use in this
sort of case; when generating console messages, we should insert the
elided URL rather than the full URL.
This shouldn't change any visible behavior; we're already visually
eliding URLs in console messages for URLs above 150 characters. This
patch simply changes the underlying string to ensure that no URL is
over 1k in length to begin with.
- platform/KURL.cpp:
(WebCore::KURL::elidedString): Added.
- platform/KURL.h:
An exciting new method that gives you the same result as string()
for URLs less than 1k long, and elides the middle of URLs longer
than 1k by replacing everything but the first and last 0.5k with
"...".
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::fail):
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::executeScript):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::isSafeToLoadURL):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
(WebCore::createWindow):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::responseReceived):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFail):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::printAccessDeniedMessage):
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowScriptNonce):
(WebCore::CSPDirectiveList::allowPluginType):
Use 'KURL::elidedString()' rather than 'KURL::string()'
- loader/MixedContentChecker.cpp:
(WebCore::MixedContentChecker::logWarning):
Here, we're doing the same as above, but it enables us to throw
away the asUTF8() function entirely by switching to makeString
rather than String::format.
- 1:22 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:19 AM Changeset in webkit [144606] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r144070 - [WK2][GTK] REGRESSION (r143463): unit test failure in WebKit2APITests/TestContextMenu
https://bugs.webkit.org/show_bug.cgi?id=110869
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-02-26
Reviewed by Martin Robinson.
Test was failing because of new media controls needs more space to be
painted than just 10x10 pixels.
- UIProcess/API/gtk/tests/TestContextMenu.cpp:
(testContextMenuDefaultMenu): Modified test in order to give more space
to the media controls.
- 1:18 AM WebKitGTK/2.0.x edited by
- Add some changes on track for WK2 (diff)
- 12:37 AM Changeset in webkit [144605] by
-
- 8 edits1 add in trunk/Source
Web Inspector: add runtime flag to determine if inspector's source files were flattened.
https://bugs.webkit.org/show_bug.cgi?id=111184
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-04
Reviewed by Pavel Feldman.
Source/WebCore:
- Add a file "buildSystemOnly.js" which will be included into
devtools.html only by GYP build system. This script sets a single flag
which essentially means that inspector source files were run
through a build system and flattened.
- Update "importScript" and "registerRequiredCSS" functions to correct
paths according to the "flattenImports" flag.
No new tests: no change in behaviour.
- WebCore.gypi:
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
- inspector/front-end/View.js:
(WebInspector.View.prototype.registerRequiredCSS):
- inspector/front-end/buildSystemOnly.js: Added.
- inspector/front-end/utilities.js:
Source/WebKit/chromium:
Included "buildSystemOnly.js" in devtools.html by generate_devtools_html.py script.
- WebKit.gyp:
- scripts/generate_devtools_html.py: Add script tag to include buildSystemOnly.js
(write_devtools_html):
- 12:36 AM Changeset in webkit [144604] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=111290
- platform/qt/TestExpectations: Skipped failing test after r144461.
- 12:06 AM Changeset in webkit [144603] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Fix front-end compilation
https://bugs.webkit.org/show_bug.cgi?id=111286
Reviewed by Alexander Pavlov.
- inspector/InjectedScriptSource.js:
- inspector/front-end/FileSystemProjectDelegate.js:
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorTreeNode.prototype.reset):
(WebInspector.NavigatorFolderTreeNode.prototype.didAddChild):
Mar 3, 2013:
- 11:57 PM Changeset in webkit [144602] by
-
- 6 edits in trunk/Source
[EFL][WebGL] Add proper checks to enable GraphicsSurface usage on EGL without XCompositeWindow.
https://bugs.webkit.org/show_bug.cgi?id=108034
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-03
Reviewed by Laszlo Gombos.
Covered by existing WebGL tests.
Currently, we set GRAPHICS_SURFACE to true if support for XCompositeWindow
is identified during compile time. This is ok, when using GLX. We might not
have support for XCompositeWindow when using EGL and GLES2.0. This patch
makes changes so that GRAPHICS_SURFACE is always enabled with EGL and adds
GLX guard to the parts of code dependent on XCompositeWindow support.
- platform/graphics/opengl/GLPlatformSurface.cpp:
- platform/graphics/surfaces/glx/GLXConfigSelector.h:
(WebCore::GLXConfigSelector::findMatchingConfig):
- platform/graphics/surfaces/glx/X11Helper.cpp:
(WebCore::X11Helper::createOffScreenWindow):
(WebCore::X11Helper::isXRenderExtensionSupported):
- platform/graphics/surfaces/glx/X11Helper.h:
- 11:44 PM Changeset in webkit [144601] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [PageAgent] can't find frame by security origin.
https://bugs.webkit.org/show_bug.cgi?id=110849
Use toRawString() in order to compare Frames' SecurityOrigins for storage-related goals.
Reviewed by Vsevolod Vlasov.
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin):
- 11:28 PM Changeset in webkit [144600] by
-
- 16 edits in trunk
Unreviewed, rolling out r144455.
http://trac.webkit.org/changeset/144455
https://bugs.webkit.org/show_bug.cgi?id=111165
A simpler solution to the SecurityOrigin -> localStorage
lookup exists
Source/WebCore:
- inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorage.storageId):
(WebInspector.DOMStorage.prototype.get id):
(WebInspector.DOMStorage.prototype.getItems):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel.prototype._securityOriginAdded):
(WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
(WebInspector.DOMStorageModel.prototype._storageKey):
- inspector/front-end/ExtensionAuditCategory.js:
- inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._reset):
(WebInspector.FileSystemModel.prototype._securityOriginAdded):
(WebInspector.FileSystemModel.prototype._securityOriginRemoved):
(WebInspector.FileSystemModel.prototype._addOrigin):
(WebInspector.FileSystemModel.prototype._removeOrigin):
(WebInspector.FileSystemModel.prototype._requestFileSystemRoot):
(WebInspector.FileSystemModel.prototype._fileSystemRootReceived):
(WebInspector.FileSystemModel.prototype._removeFileSystem):
(WebInspector.FileSystemModel.FileSystem.prototype.get name):
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
(WebInspector.IndexedDBModel.prototype._securityOriginAdded):
(WebInspector.IndexedDBModel.prototype._securityOriginRemoved):
(WebInspector.IndexedDBModel.prototype._addOrigin):
(WebInspector.IndexedDBModel.prototype._removeOrigin):
(WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.):
(WebInspector.IndexedDBModel.prototype._requestData):
(WebInspector.IndexedDBModel.DatabaseId.prototype.equals):
- inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDatabaseView.prototype._refreshDatabase):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._addSecurityOrigin):
(WebInspector.ResourceTreeModel.prototype._removeSecurityOrigin):
(WebInspector.ResourceTreeModel.prototype.securityOrigins):
(WebInspector.ResourceTreeModel.prototype._handleMainFrameDetached):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._navigate):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.IDBDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement.prototype.get itemURL):
(WebInspector.IDBObjectStoreTreeElement.prototype.get itemURL):
(WebInspector.IDBIndexTreeElement.prototype.get itemURL):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):
(WebInspector.FileSystemTreeElement):
LayoutTests:
- http/tests/inspector-enabled/dom-storage-open.html:
- http/tests/inspector/filesystem/delete-entry.html:
- http/tests/inspector/filesystem/request-filesystem-root.html:
- http/tests/inspector/indexeddb/database-data.html:
- http/tests/inspector/indexeddb/database-names.html:
- http/tests/inspector/indexeddb/database-structure.html:
- http/tests/inspector/resource-tree/resource-tree-events.html:
- 11:09 PM Changeset in webkit [144599] by
-
- 3 edits in trunk/Source/WebKit2
PDFPlugin: Rename delegate method from openWithPreview to openWithNativeApplication
https://bugs.webkit.org/show_bug.cgi?id=111258
Reviewed by Alexey Proskuryakov.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate openWithNativeApplication]):
Rename from openWithPreview to openWithNativeApplication to match PDFKit.
- 10:53 PM Changeset in webkit [144598] by
-
- 10 edits in trunk/Source/WebCore
Web Inspector: Let user know when file system based uiSourceCode was changed on disk.
https://bugs.webkit.org/show_bug.cgi?id=110133
Reviewed by Pavel Feldman.
We now check if file system based uiSourceCode content was updated externally when
UISourceCodeFrame is shown or inspector window is focused.
If there is no working copy being edited right now we replace old content with the new one silently.
Otherwise ask user if he wants to replace his working copy with the new content.
- English.lproj/localizedStrings.js:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.editRange):
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate.prototype.innerCallback):
(WebInspector.FileSystemProjectDelegate.prototype.requestFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._contentRequestFinished):
(WebInspector.FileSystemProjectDelegate.prototype.requestUpdatedFileContent):
(WebInspector.FileSystemProjectDelegate.prototype.contentCallback):
(WebInspector.FileSystemProjectDelegate.prototype.searchInFileContent):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.wasShown):
(WebInspector.JavaScriptSourceFrame.prototype.willHide):
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate.prototype.requestUpdatedFileContent):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.setContent):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.checkContentUpdated.updatedContentLoaded):
(WebInspector.UISourceCode.prototype.checkContentUpdated):
- inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype.wasShown):
(WebInspector.UISourceCodeFrame.prototype.willHide):
(WebInspector.UISourceCodeFrame.prototype._windowFocused):
(WebInspector.UISourceCodeFrame.prototype._checkContentUpdated):
- inspector/front-end/Workspace.js:
(WebInspector.ProjectDelegate.prototype.requestUpdatedFileContent):
(WebInspector.Project.prototype.requestUpdatedFileContent):
- 10:34 PM Changeset in webkit [144597] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium gardening
Remove failure annotation on tests which was already fixed.
- platform/chromium/TestExpectations:
- 10:28 PM Changeset in webkit [144596] by
-
- 5 edits in trunk
[Mac] Get rid of a useless method from DOMHTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=111279
Reviewed by Sam Weinig.
Source/WebKit/mac:
- DOM/WebDOMOperations.mm:
- DOM/WebDOMOperationsPrivate.h:
setValueForUser: is already privately exposed by DOMHTMLInputElement,
no need to have it twice.
Tools:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setValueForUser):
The method _setValueForUser: was added for testing. This feature is already
exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
in real use cases. Get rid of the method created for testing, use the real thing
instead.
- 9:51 PM Changeset in webkit [144595] by
-
- 3 edits2 adds in trunk
createAttribute/setAttributeNode does not properly normalize case
https://bugs.webkit.org/show_bug.cgi?id=90341
Patch by Arpita Bahuguna <a.bah@samsung.com> on 2013-03-03
Reviewed by Darin Adler.
Source/WebCore:
setAttributeNode() verifies for existing attributes in a case sensitive
manner. Thus, it would add another attribute if specified in a case
different from the existing one. Instead, like setAttribute(), it too
should modify the existing attribute's value.
Test: fast/dom/Element/setAttributeNode-case-insensitivity.html
- dom/Element.cpp:
(WebCore::Element::setAttributeNode):
Made changes to check for an existing attribute by converting the
specified attribute's localName to lowercase.
LayoutTests:
- fast/dom/Element/setAttributeNode-case-insensitivity-expected.txt: Added.
- fast/dom/Element/setAttributeNode-case-insensitivity.html: Added.
Testcase for verifying that setAttributeNode() checks against existing
attributes in a case insensitive manner. It updates the value of an
existing attribute (in lower case) with that of the one set using
setAttributeNode() (in upper case).
The test also verifies the behavior of attributes when specified with
namespace and prefix.
- 5:42 PM Changeset in webkit [144594] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Rebaselined run-bindings-tests.
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::indexedSecurityCheck):
(TestActiveDOMObjectV8Internal):
(WebCore::TestActiveDOMObjectV8Internal::namedSecurityCheck):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
- 5:39 PM Changeset in webkit [144593] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r144590.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateSecurityCheckFunctions):
- 5:36 PM Changeset in webkit [144592] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix after r144587.
- bindings/v8/V8Binding.cpp:
(WebCore::toV8Context):
- bindings/v8/V8MutationCallback.cpp:
(WebCore::V8MutationCallback::V8MutationCallback):
- 4:16 PM Changeset in webkit [144591] by
-
- 3 edits in trunk/Source/WebCore
[V8] HTMLDocument.all should have [Replaceable]
https://bugs.webkit.org/show_bug.cgi?id=111230
Reviewed by Adam Barth.
(Although HTMLDocument.all is already removed from the spec,)
it is expected to behave as a [Replaceable] attribute. By adding
a [Replaceable] IDL attribute, we can remove custom implementation
of HTMLDocument.all.
I confimed that exactly the same code is generated for .all getter
and setter.
No tests. No change in behavior.
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- html/HTMLDocument.idl:
- 4:12 PM Changeset in webkit [144590] by
-
- 5 edits in trunk/Source/WebCore
[V8] indexedSecurityCheck() and namedSecurityCheck() should be auto-generated
https://bugs.webkit.org/show_bug.cgi?id=111225
Reviewed by Adam Barth.
indexedSecurityCheck() and namedSecurityCheck() should be auto-generated,
except for DOMWindow's ones.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateSecurityCheckFunctions):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedSecurityCheckCustom):
(WebCore::V8DOMWindow::indexedSecurityCheckCustom):
- bindings/v8/custom/V8HistoryCustom.cpp:
- bindings/v8/custom/V8LocationCustom.cpp:
- 4:11 PM Changeset in webkit [144589] by
-
- 2 edits in trunk/Source/JavaScriptCore
Shrink JSC::HashTable entries.
<http://webkit.org/b/111275>
<rdar://problem/13333511>
Reviewed by Anders Carlsson.
Move the Intrinsic value out of the function-specific part of the union,
and store it next to m_attributes. Reduces the size of HashEntry by 8 bytes.
990 kB progression on Membuster3. (PTUS: 797 kB)
- runtime/Lookup.h:
(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):
(HashEntry):
- 4:09 PM Changeset in webkit [144588] by
-
- 2 edits in trunk/Source/WebCore
[V8] Rename $implContentDecls to $implContentInternals in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=111214
Reviewed by Adam Barth.
$implContentDecls stores generated code that is put in a namespace 'XXXV8Internal'.
For clarification, it should be renamed to $implContentInternals.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateConstructorGetter):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateReplaceableAttrSetterCallback):
(GenerateReplaceableAttrSetter):
(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateEventConstructor):
(GenerateTypedArrayConstructor):
(GenerateImplementation):
(WriteData):
- 4:05 PM Changeset in webkit [144587] by
-
- 12 edits in trunk/Source/WebCore
[V8] Rename getWorld() to isolatedWorld(), and getWorldForEnteredContext() to isolatedWorldForEnteredContext()
https://bugs.webkit.org/show_bug.cgi?id=111212
Reviewed by Adam Barth.
The rename I did in r142424 was wrong. Given that getWorld() returns 0
for the main world, it should be named isolatedWorld(). Similarly,
given that getWorldForEnteredContext() returns 0 for the main world,
it should be named isolatedWorldForEnteredContext().
No tests. No change in behavior.
- bindings/v8/CustomElementHelpers.cpp:
(WebCore::CustomElementHelpers::isFeatureAllowed):
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::current):
- bindings/v8/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::makeContextWeak):
- bindings/v8/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::isolatedWorld):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
(WebCore::ScriptController::currentWorldContext):
- bindings/v8/V8Binding.h:
(WebCore::isolatedWorldForEnteredContext):
- bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::wrap):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::wrap):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::wrap):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::constructorCustom):
- 3:56 PM Changeset in webkit [144586] by
-
- 14 edits in branches/safari-534.59-branch
Merge r143988
2013-02-25 Anders Carlsson <andersca@apple.com>
Source/WebKit2:
Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
https://bugs.webkit.org/show_bug.cgi?id=110821
Reviewed by Beth Dakin.
- UIProcess/API/C/WKPage.cpp: (WKPageGetPluginInformationPluginspageAttributeURLKey): (WKPageGetPluginInformationPluginURLKey): Add two new API key getters.
- UIProcess/API/C/WKPage.h: Add a new callback and deprecate the old callback.
- UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didFailToInitializePlugin): (WebKit::WebLoaderClient::didBlockInsecurePluginVersion): (WebKit::WebLoaderClient::pluginLoadPolicy): Make the pluginInformationDictionary a static member function of WebPageProxy so it can be called from WebUIClient as well.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): Pass the bundle version as well.
(WebKit::WebPageProxy::pluginInformationPluginspageAttributeURLKey):
(WebKit::WebPageProxy::pluginInformationPluginURLKey):
Add two new keys.
(WebKit::WebPageProxy::pluginInformationDictionary):
Handle more keys.
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
Get the plug-in bundle identifier and version.
- UIProcess/WebPageProxy.messages.in: Pass along more information; the frame and page URLs.
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::unavailablePluginButtonClicked): Call the new callback if it's supported.
- UIProcess/WebUIClient.h: (WebUIClient):
- UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage): Update for API changes.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::unavailablePluginButtonClicked): Ensure that the pluginspage attribute is a valid URL.
Tools:
Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
https://bugs.webkit.org/show_bug.cgi?id=110821
<rdar://problem/13265303>
Reviewed by Beth Dakin.
Update for WebKit2 changes.
- MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): (WTR::TestController::unavailablePluginButtonClicked):
- WebKitTestRunner/TestController.h: (TestController):
- 3:54 PM Changeset in webkit [144585] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][QT][WK2] Turn on ApplyDeviceScaleFactorInCompositor always.
https://bugs.webkit.org/show_bug.cgi?id=110298
Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-03
Reviewed by Kenneth Rohde Christiansen.
Currently, EFL and Qt turn on ApplyDeviceScaleFactorInCompositor when using
fixed layout, but ApplyDeviceScaleFactorInCompositor is not related to fixed
layout. It is confusing that a platform WebView deals with device view size or
DIP view size case by case. So this patch always turns on
ApplyDeviceScaleFactorInCompositor.
In addition, move the code that turns on ScrollingCoordinatorEnabled to
CoordinatedLayerTreeHost.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::setDeviceScaleFactor):
We should make WebPage know new DIP size.
(EwkView::setSize):
When we set ApplyDeviceScaleFactorInCompositor to true, make WebPage
know the DIP size as a view size.
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::updateViewportSize):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setUseFixedLayout):
WebPage sends the DIP size to Web Process even when we don't use fixed layout.
- 3:52 PM Changeset in webkit [144584] by
-
- 4 edits in trunk/Source/WebCore
[V8] Move HTMLDocument::getNamedProperty() to DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=111223
Reviewed by Adam Barth.
HTMLDocument::getNamedProperty() is used by DOMWindowShell.
It can be a static method in DOMWindowShell.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::getNamedProperty):
(WebCore):
(WebCore::getter):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- 3:19 PM Changeset in webkit [144583] by
-
- 24 edits in trunk
Some perf. tests have variances that differ greatly between runs
https://bugs.webkit.org/show_bug.cgi?id=97510
Reviewed by Benjamin Poulain.
PerformanceTests:
In order to control the number of iterations and processes to use from run-perf-tests, always use 20
iterations on all tests except Dromaeo, where even doing 5 iterations is prohibitively slow, by default.
Without this change, it'll become extremely hard for us to tweak the number of iterations and processes
to use from run-perf-tests.
- Animation/balls.html:
- DOM/DOMTable.html:
- DOM/resources/dom-perf.js:
(runBenchmarkSuite.PerfTestRunner.measureTime):
- Dromaeo/resources/dromaeorunner.js:
- Layout/floats_100_100.html:
- Layout/floats_100_100_nested.html:
- Layout/floats_20_100.html:
- Layout/floats_20_100_nested.html:
- Layout/floats_2_100.html:
- Layout/floats_2_100_nested.html:
- Layout/floats_50_100.html:
- Layout/floats_50_100_nested.html:
- Layout/subtree-detaching.html:
- Parser/html5-full-render.html:
- SVG/SvgHitTesting.html:
- resources/runner.js:
- resources/results-template.html:
Tools:
Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
environment on test results (we run each instance after one another, not in parallel).
We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
iterations as it was done previously in single process. These values are hard-coded in perftest.py
and runner.js but they are to be configurable in the future.
Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
metric now reports an array of the length 4 with each element containing an array of 5 iteration
values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.
Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTestMetric.append_group): Renamed from append.
(PerfTestMetric.grouped_iteration_values): Added.
(PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.
(PerfTest.init): Takes the number of processes (drivers) to run tests with.
This parameter is only used by SingleProcessPerfTest.
(PerfTest.run): Repeat tests using different driver processes.
(PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
We instead use _ensure_metrics to obtain the matched metrics and store the data there.
(PerfTest._ensure_metrics): Added.
(SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
instances of DumpRenderTree/WebKitTestRunner takes too long.
(SingleProcessPerfTest.init):
(ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.
(PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.
- Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect
_run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.
(TestPerfTestMetric.test_append): Updated per name and added some test cases for
grouped_iteration_values.
(TestPerfTest._assert_results_are_correct):
(TestSingleProcessPerfTest): Added.
(TestSingleProcessPerfTest.test_use_only_one_process):
(TestSingleProcessPerfTest.test_use_only_one_process.run_single):
(TestReplayPerfTest.test_run_with_driver_accumulates_results):
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of
sample standard deviations since we're now running tests 4 times.
(MainTest._test_run_with_json_output.mock_upload_json):
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
LayoutTests:
Use dromaeoIterationCount now that we no longer support iterationCount.
- fast/harness/perftests/runs-per-second-iterations.html:
- 3:02 PM Changeset in webkit [144582] by
-
- 13 edits in branches/safari-534.59-branch
Merge r143976
2013-02-25 Anders Carlsson <andersca@apple.com>
Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
https://bugs.webkit.org/show_bug.cgi?id=110793
<rdar://problem/13265303>
Reviewed by Sam Weinig.
Source/WebKit2:
Add a new pluginDidFail callback that takes a WKDictionaryRef and also pass in the
frame and page URLs.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp: (WebKit::pluginInformationDictionary): (WebKit::WebLoaderClient::didFailToInitializePlugin): (WebKit::WebLoaderClient::didBlockInsecurePluginVersion): (WebKit::WebLoaderClient::pluginLoadPolicy):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFailToInitializePlugin): (WebKit::WebPageProxy::didBlockInsecurePluginVersion):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::didFailToInitializePlugin):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin):
Tools:
Update for WebKit2 API changes.
- MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createWebViewWithOptions):
- 2:15 PM Changeset in webkit [144581] by
-
- 6 edits in trunk
[chromium] Remove WebLayerTreeView::setViewportSize call
https://bugs.webkit.org/show_bug.cgi?id=110727
Reviewed by James Robinson.
After https://codereview.chromium.org/12328080 lands,
setViewportSize is called from the Chromium side. The multiplication
by deviceScaleFactor here was prone to off-by-one errors.
The layoutSize() function was only used here so delete it as well.
DumpRenderTree WebViewHost must now call this method as well.
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::updateLayerTreeViewport):
- src/WebViewImpl.h:
(WebViewImpl):
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::initializeLayerTreeView):
(WebViewHost::setWindowRect):
(WebViewHost::setDeviceScaleFactor):
(WebViewHost::updateViewportSize):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 2:15 PM Changeset in webkit [144580] by
-
- 4 edits in trunk/Source/WebKit2
Shared Web Workers have an incorrect visible process name
https://bugs.webkit.org/show_bug.cgi?id=111277
Reviewed by Dan Bernstein.
- SharedWorkerProcess/SharedWorkerProcess.cpp:
(WebKit::SharedWorkerProcess::initializeSharedWorkerProcess):
- SharedWorkerProcess/SharedWorkerProcess.h:
(SharedWorkerProcess):
- SharedWorkerProcess/mac/SharedWorkerProcessMac.mm:
(WebKit::SharedWorkerProcess::initializeProcessName):
The SharedWorkerProcess is not an internet plug-in!
- 12:43 PM Changeset in webkit [144579] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r144565. Reverted r144533.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
- 11:57 AM Changeset in webkit [144578] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the Qt build after r144498
https://bugs.webkit.org/show_bug.cgi?id=111272
Reviewed by Eric Seidel.
Update the Qt version of the XML parser to call the new API.
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::resumeParsing):
(WebCore::XMLDocumentParser::appendFragmentSource):
- 11:36 AM Changeset in webkit [144577] by
-
- 2 edits in trunk/Source/WebCore
Plug-ins that are appropriately large w.r.t page size should autostart
https://bugs.webkit.org/show_bug.cgi?id=111242
Reviewed by Brady Eidson.
A "full-page" plug-in site should never snapshot. The trick is
how to determine what is full-page. This change implements the
following algorithm.
- The plug-in is in the main frame (not an iframe).
- The plug-in is sized with width and height 100%.
- The displayed area of the plug-in is more than 96% of the viewport area.
This is definitely not foolproof. For example, zombo.com has a slight
border around its plug-in. As the window size gets smaller, the body margin
takes up more than 5% of the width or height, and the plug-in doesn't pass
the tests above.
- html/HTMLPlugInImageElement.cpp:
(WebCore): New static constant: sizingFullPageThresholdPercentage
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Implements
the rules described above.
- 10:27 AM Changeset in webkit [144576] by
-
- 12 edits in branches/safari-534.59-branch/Source
Merge r143815
2013-02-22 Anders Carlsson <andersca@apple.com>
pluginLoadStrategy should take a WKDictionaryRef for extensibility
https://bugs.webkit.org/show_bug.cgi?id=110656
<rdar://problem/13265303>
Reviewed by Jessie Berlin.
../WebCore:
Export a symbol needed by WebKit2.
- WebCore.exp.in:
../WebKit2:
Change pluginLoadStrategy to take a WKDictionaryRef instead of a number of parameters;
this lets us add more plug-in information if needed. Also add the page URL and rename documentURL to frameURL.
- UIProcess/API/C/WKPage.cpp: (WKPageGetPluginInformationBundleIdentifierKey): (WKPageGetPluginInformationBundleVersionKey): (WKPageGetPluginInformationDisplayNameKey): (WKPageGetPluginInformationFrameURLKey): (WKPageGetPluginInformationMIMETypeKey): (WKPageGetPluginInformationPageURLKey):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp: (WebKit): (WebKit::WebLoaderClient::pluginLoadPolicy):
- UIProcess/WebLoaderClient.h: (WebLoaderClient):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): (WebKit::WebPageProxy::pluginInformationBundleIdentifierKey): (WebKit): (WebKit::WebPageProxy::pluginInformationBundleVersionKey): (WebKit::WebPageProxy::pluginInformationDisplayNameKey): (WebKit::WebPageProxy::pluginInformationFrameURLKey): (WebKit::WebPageProxy::pluginInformationMIMETypeKey): (WebKit::WebPageProxy::pluginInformationPageURLKey):
- UIProcess/WebPageProxy.h: (WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): (WebKit::WebPage::canPluginHandleResponse):
- 8:16 AM Changeset in webkit [144575] by
-
- 2 edits in trunk/Source/WebCore
[Win] IDLParser.pm fails to parse OESTextureHalfFloat and causes a build failure
https://bugs.webkit.org/show_bug.cgi?id=111267
Reviewed by Kentaro Hara.
Allow empty definitions.
- bindings/scripts/IDLParser.pm:
(Parse):
- 7:59 AM Changeset in webkit [144574] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX: RenderLayerFilterInfo.h needs to include Element.h with ENABLE(SVG)
Fixes the following build failures:
In file included from Source/WebCore/rendering/RenderLayerFilterInfo.cpp:33:
Source/WebCore/rendering/RenderLayerFilterInfo.h:118:19: error: use of undeclared identifier 'Element'
Vector<RefPtr<Element> > m_internalSVGReferences;
Source/WebCore/rendering/RenderLayerFilterInfo.h:118:28: error: expected a type
Vector<RefPtr<Element> > m_internalSVGReferences;
Source/WebCore/rendering/RenderLayerFilterInfo.h:118:30: error: private field 'm_internalSVGReferences' is not used [-Werror,-Wunused-private-field]
Vector<RefPtr<Element> > m_internalSVGReferences;
3 errors generated.
- rendering/RenderLayerFilterInfo.h: Include Element.h within
ENABLE(SVG). Move ENABLE(SVG) block below unconditional
headers.
- 4:05 AM Changeset in webkit [144573] by
-
- 2 edits in trunk/Source/WebKit/win
Windows build fix attempt after r144547.
- WebKit.vcproj/WebKitExports.def.in:
- 3:47 AM Changeset in webkit [144572] by
-
- 23 edits3 deletes in trunk
Unreviewed, rolling out r144567.
http://trac.webkit.org/changeset/144567
https://bugs.webkit.org/show_bug.cgi?id=111266
Does not compile on apple-win (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-03
.:
- Source/autotools/symbols.filter:
Source/WebCore:
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::iconURLs):
- dom/Document.h:
(Document):
- loader/icon/IconController.cpp:
(WebCore::IconController::iconURL):
(WebCore::IconController::urlsForTypes):
- loader/icon/IconController.h:
(IconController):
- testing/Internals.cpp:
(WebCore::Internals::iconURLs):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/chromium:
- public/WebFrame.h:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::iconURLs):
- src/WebFrameImpl.h:
(WebFrameImpl):
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
LayoutTests:
- fast/dom/icon-url-change.html:
- fast/dom/icon-url-list-apple-touch-expected.txt: Removed.
- fast/dom/icon-url-list-apple-touch.html: Removed.
- fast/dom/icon-url-list.html:
- fast/dom/icon-url-property.html:
- platform/chromium-android/fast/dom/icon-url-list-apple-touch-expected.txt: Removed.
- 3:06 AM Changeset in webkit [144571] by
-
- 8 edits in trunk/Source
CSP 1.1: Support CSP 1.1 directives on the unprefixed header.
https://bugs.webkit.org/show_bug.cgi?id=111254
Reviewed by Adam Barth.
Source/WebCore:
We'd like to ensure that early adopters don't get stuck on a prefixed
header; when CSP 1.1 is baked enough to be supported in multiple
browsers, everything should Just Work™.
This patch changes WebKit's behavior regarding CSP_NEXT features.
Currently, they're only exposed on the prefixed header ('X-WebKit-CSP').
This patch exposes those features on the canonical header, assuming
that the runtime flag is set. This shouldn't have any effect at all on
ports that haven't yet enabled CSP_NEXT, and will simply clear the way
for a clean deployment to a wider audience once the specification
process is further along.
This change shouldn't have any effect on the existing tests: they
should run just as they did before. The next step will be to adjust
the LayoutTests for 1.1 to prefer the canonical header, but I'll do
that in another patch to reduce churn.
Related, the enum names no longer made sense: the difference between the
canonical 'Content-Security-Policy' header and 'X-WebKit-CSP' is the
prefix, not the functionality. This patch renames them for clarity.
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument):
Use the new enum names.
- page/ContentSecurityPolicy.cpp:
(CSPDirectiveList):
(WebCore::CSPDirectiveList::CSPDirectiveList):
(WebCore::CSPDirectiveList::addDirective):
Drop the 'm_experimental' property from CSPDirectiveList; we'll
control the behavior via the runtime flag from now on.
Also, this fixes a small bug in 'addDirective()': we never threw
unrecognized directive errors for users who were sending the
prefixed header. Oops!
(WebCore::ContentSecurityPolicy::deprecatedHeaderType):
Use the new enum names.
- page/ContentSecurityPolicy.h:
Redefine the enum for clarity: 'PrefixedReport' and 'Report'
rather than 'ReportAllDirectives' and 'ReportStableDirectives'.
Source/WebKit/chromium:
The enum names no longer made sense: the difference between the
canonical 'Content-Security-Policy' header and 'X-WebKit-CSP' is the
prefix, not the functionality. This patch renames them for clarity.
- public/WebContentSecurityPolicy.h:
- src/AssertMatchingEnums.cpp:
Rename the Chromium side of the enums.
- 2:47 AM Changeset in webkit [144570] by
-
- 4 edits in trunk/Source
Source/WebCore: Another Windows build fix attempt after r144567.
Try touching the IDL file in a hope it'll regenerate JSInternals.cpp.
- testing/Internals.idl:
Source/WebKit/win: That was a wrong fix. Revert r144569.
- WebKit.vcproj/WebKitExports.def.in:
- 2:34 AM Changeset in webkit [144569] by
-
- 2 edits in trunk/Source/WebKit/win
Windows build fix attempt after r144567.
- WebKit.vcproj/WebKitExports.def.in:
- 2:12 AM Changeset in webkit [144568] by
-
- 116 edits in trunk/Source
Unreviewed attempted build fix. Adds back some includes removed in
http://trac.webkit.org/changeset/144565.
Source/WebCore:
- Modules/mediastream/RTCPeerConnection.cpp:
- bindings/ScriptControllerBase.cpp:
- bindings/objc/DOM.mm:
- bindings/v8/ScriptController.cpp:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- css/CSSFontSelector.cpp:
- css/WebKitCSSSVGDocumentValue.cpp:
- dom/DOMImplementation.cpp:
- dom/PendingScript.h:
- dom/ScriptElement.cpp:
- dom/ScriptElement.h:
- history/CachedFrame.cpp:
- html/DOMURL.cpp:
- html/HTMLAnchorElement.cpp:
- html/HTMLAppletElement.cpp:
- html/HTMLElement.cpp:
- html/HTMLEmbedElement.cpp:
- html/HTMLFrameSetElement.cpp:
- html/HTMLHtmlElement.cpp:
- html/HTMLImageElement.cpp:
- html/HTMLObjectElement.cpp:
- html/HTMLPlugInElement.cpp:
- html/ImageDocument.cpp:
- html/ImageInputType.cpp:
- html/MediaDocument.cpp:
- html/PluginDocument.cpp:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
- html/parser/HTMLConstructionSite.cpp:
- html/parser/HTMLParserOptions.cpp:
- html/parser/XSSAuditorDelegate.cpp:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorFileSystemAgent.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorInstrumentation.h:
- inspector/InspectorPageAgent.cpp:
- inspector/NetworkResourcesData.cpp:
- inspector/NetworkResourcesData.h:
(WebCore):
- loader/CookieJar.cpp:
- loader/CrossOriginAccessControl.cpp:
- loader/FrameLoader.cpp:
- loader/MainResourceLoader.cpp:
- loader/MixedContentChecker.cpp:
- loader/PingLoader.cpp:
- loader/SubframeLoader.cpp:
- loader/SubresourceLoader.cpp:
- loader/appcache/ApplicationCacheGroup.cpp:
- loader/appcache/ApplicationCacheHost.cpp:
- loader/cache/CachedResource.cpp:
- loader/icon/IconController.cpp:
- page/DOMWindowExtension.cpp:
- page/Frame.cpp:
- page/PerformanceTiming.cpp:
- page/PointerLockController.cpp:
- page/animation/CSSPropertyAnimation.cpp:
- platform/chromium/PasteboardChromium.cpp:
- platform/efl/ErrorsEfl.cpp:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
- platform/gtk/ErrorsGtk.cpp:
- platform/gtk/PasteboardGtk.cpp:
- platform/gtk/PasteboardHelper.h:
- platform/mac/ClipboardMac.mm:
- platform/mac/HTMLConverter.mm:
- platform/qt/PasteboardQt.cpp:
- plugins/DOMMimeType.cpp:
- plugins/PluginView.cpp:
- rendering/HitTestResult.cpp:
- rendering/RenderImage.cpp:
- rendering/RenderImageResource.cpp:
- rendering/RenderImageResourceStyleImage.cpp:
- rendering/RenderLayer.cpp:
- rendering/RenderLayerBacking.cpp:
- svg/SVGImageLoader.cpp:
- svg/SVGUseElement.cpp:
- testing/MockPagePopupDriver.cpp:
- xml/XSLStyleSheet.h:
(WebCore):
Source/WebKit/chromium:
- src/ApplicationCacheHost.cpp:
- src/AssociatedURLLoader.cpp:
- src/EditorClientImpl.cpp:
- src/SharedWorkerRepository.cpp:
- src/WebDataSourceImpl.cpp:
- src/WebFrameImpl.h:
(WebCore):
- src/WebNode.cpp:
- src/WebSharedWorkerImpl.cpp:
- tests/FrameLoaderClientImplTest.cpp:
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- ewk/ewk_frame.cpp:
Source/WebKit/mac:
- DOM/WebDOMOperations.mm:
- Misc/WebNSPasteboardExtras.mm:
- WebCoreSupport/WebFrameNetworkingContext.mm:
- WebView/WebRenderLayer.mm:
- WebView/WebRenderNode.mm:
Source/WebKit/qt:
- WebCoreSupport/NotificationPresenterClientQt.cpp:
- WebCoreSupport/QWebPageAdapter.cpp:
Source/WebKit2:
- Shared/WebRenderLayer.cpp:
- Shared/WebRenderObject.cpp:
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
- WebProcess/WebPage/mac/WebPageMac.mm:
- WebProcess/WebProcess.cpp:
- WebProcess/soup/WebProcessSoup.cpp:
- 1:54 AM Changeset in webkit [144567] by
-
- 20 edits3 adds in trunk
<link rel="apple-touch-icon"> tag is not honored on CNN.com, workflowy.com etc
https://bugs.webkit.org/show_bug.cgi?id=109061
Patch by Ruslan Abdikeev <aruslan@chromium.org> on 2013-03-03
Reviewed by Adam Barth.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Test: fast/dom/icon-url-list-apple-touch.html
Added iconTypes parameter to Document::iconURLs().
Added Document::shortcutIconURLs() with original semantics of iconURLs().
Fixed IconController.cpp to provide iconTypesMask to iconURLs().
Renamed iconTypes to iconTypesMask to make the meaning clearer.
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::shortcutIconURLs):
(WebCore):
(WebCore::Document::iconURLs):
- dom/Document.h:
(Document):
- loader/icon/IconController.cpp:
(WebCore::IconController::iconURL):
(WebCore::IconController::urlsForTypes):
- testing/Internals.cpp:
(WebCore::Internals::iconURLs):
(WebCore::Internals::shortcutIconURLs):
(WebCore):
(WebCore::Internals::allIconURLs):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Added test for apple-touch-icon in allIconURLs().
Changed iconURLs() to shortcutIconURLs().
- fast/dom/icon-url-change.html:
- fast/dom/icon-url-list-apple-touch-expected.txt: Added.
- fast/dom/icon-url-list-apple-touch.html: Added.
- fast/dom/icon-url-list.html:
- fast/dom/icon-url-property.html:
- 1:28 AM Changeset in webkit [144566] by
-
- 4 edits2 adds in trunk
CSP: Throw a warning when a '*-report-only' header doesn't contain a 'report-uri' directive.
https://bugs.webkit.org/show_bug.cgi?id=111208
Reviewed by Adam Barth.
Source/WebCore:
Developers in the wild have been observed to serve a report-only CSP
header with a policy that doesn't contain a 'report-uri' directive.
This has zero effect, of course, and we should help them understand
that by throwing a warning up on the console.
Test: http/tests/security/contentSecurityPolicy/report-only-report-uri-missing.html
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::isReportOnly): Added.
(WebCore::CSPDirectiveList::reportURIs): Added.
(WebCore::CSPDirectiveList::create):
After creating a CSPDirectiveList, check whether it's in
report-only mode without a report-uri. If so, warn the developer.
(WebCore::ContentSecurityPolicy::reportMissingReportURI): Added.
Write an exciting message to the console, warning the developer
about her expensive no-op machine.
LayoutTests:
- http/tests/security/contentSecurityPolicy/report-only-report-uri-missing-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/report-only-report-uri-missing.html: Added.
- 1:16 AM Changeset in webkit [144565] by
-
- 206 edits7 deletes in trunk/Source
Unreviewed rollout of http://trac.webkit.org/r144530
As described in https://bugs.webkit.org/show_bug.cgi?id=111167 and
https://bugs.webkit.org/show_bug.cgi?id=111035, this patch caused a
large number of ASSERTs in chromium-win.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/RTCPeerConnection.cpp:
- Modules/notifications/Notification.cpp:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/ScriptControllerBase.cpp:
- bindings/js/JSNodeCustom.cpp:
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptSourceCode.h:
(WebCore):
- bindings/objc/DOM.mm:
- bindings/v8/ScriptController.cpp:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- css/CSSCrossfadeValue.h:
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
- css/CSSFontFaceSource.h:
- css/CSSFontSelector.cpp:
- css/WebKitCSSSVGDocumentValue.cpp:
- css/WebKitCSSSVGDocumentValue.h:
(WebCore):
- dom/Clipboard.cpp:
(WebCore::Clipboard::Clipboard):
- dom/ContainerNode.cpp:
- dom/DOMImplementation.cpp:
- dom/PendingScript.h:
- dom/ScriptElement.cpp:
- dom/ScriptElement.h:
- history/CachedFrame.cpp:
- html/DOMURL.cpp:
- html/HTMLAnchorElement.cpp:
- html/HTMLAppletElement.cpp:
- html/HTMLElement.cpp:
- html/HTMLEmbedElement.cpp:
- html/HTMLFrameSetElement.cpp:
- html/HTMLHtmlElement.cpp:
- html/HTMLImageElement.cpp:
- html/HTMLObjectElement.cpp:
- html/HTMLPlugInElement.cpp:
- html/ImageDocument.cpp:
- html/ImageInputType.cpp:
- html/MediaDocument.cpp:
- html/PluginDocument.cpp:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
- html/parser/HTMLConstructionSite.cpp:
- html/parser/HTMLParserOptions.cpp:
- html/parser/HTMLScriptRunner.h:
- html/parser/XSSAuditor.cpp:
- html/parser/XSSAuditorDelegate.cpp:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorFileSystemAgent.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorInstrumentation.h:
(WebCore):
- inspector/InspectorPageAgent.cpp:
- inspector/NetworkResourcesData.cpp:
- inspector/NetworkResourcesData.h:
(WebCore):
- loader/CookieJar.cpp:
- loader/CrossOriginAccessControl.cpp:
- loader/CrossOriginAccessControl.h:
(WebCore):
- loader/CrossOriginPreflightResultCache.h:
- loader/DocumentThreadableLoader.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
- loader/FrameLoader.h:
(WebCore):
(WebCore::FrameLoader::policyChecker):
- loader/ImageLoader.cpp:
- loader/ImageLoader.h:
- loader/LinkLoader.h:
(WebCore):
- loader/MainResourceLoader.cpp:
- loader/MainResourceLoader.h:
(WebCore):
- loader/MixedContentChecker.cpp:
- loader/PingLoader.cpp:
- loader/PolicyChecker.h:
(WebCore):
- loader/ProgressTracker.cpp:
- loader/SubframeLoader.cpp:
- loader/SubresourceLoader.cpp:
- loader/TextTrackLoader.cpp:
- loader/TextTrackLoader.h:
(WebCore):
- loader/ThreadableLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp:
- loader/appcache/ApplicationCacheGroup.h:
(WebCore):
- loader/appcache/ApplicationCacheHost.cpp:
- loader/archive/cf/LegacyWebArchive.cpp:
- loader/cache/CachedFont.cpp:
- loader/cache/CachedFont.h:
(CachedFontClient):
(WebCore::CachedFontClient::~CachedFontClient):
(WebCore::CachedFontClient::expectedType):
(WebCore::CachedFontClient::resourceClientType):
(WebCore::CachedFontClient::fontLoaded):
(WebCore):
- loader/cache/CachedFontClient.h: Removed.
- loader/cache/CachedImage.cpp:
- loader/cache/CachedRawResource.cpp:
- loader/cache/CachedRawResource.h:
(WebCore):
(CachedRawResourceClient):
(WebCore::CachedRawResourceClient::~CachedRawResourceClient):
(WebCore::CachedRawResourceClient::expectedType):
(WebCore::CachedRawResourceClient::resourceClientType):
(WebCore::CachedRawResourceClient::dataSent):
(WebCore::CachedRawResourceClient::responseReceived):
(WebCore::CachedRawResourceClient::dataReceived):
(WebCore::CachedRawResourceClient::redirectReceived):
(WebCore::CachedRawResourceClient::dataDownloaded):
- loader/cache/CachedRawResourceClient.h: Removed.
- loader/cache/CachedResource.cpp:
- loader/cache/CachedResourceHandle.cpp:
(WebCore):
- loader/cache/CachedResourceHandle.h:
(WebCore):
(WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
- loader/cache/CachedSVGDocument.h:
(CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::expectedType):
(WebCore::CachedSVGDocumentClient::resourceClientType):
(WebCore):
- loader/cache/CachedSVGDocumentClient.h: Removed.
- loader/cache/CachedSVGDocumentReference.cpp: Removed.
- loader/cache/CachedSVGDocumentReference.h:
(WebCore):
(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
- loader/cache/CachedStyleSheetClient.h:
(WebCore):
- loader/cache/MemoryCache.h:
(WebCore):
(MemoryCache):
- loader/chromium/CachedRawResourceChromium.cpp:
- loader/icon/IconController.cpp:
- loader/icon/IconLoader.h:
- loader/mac/ResourceLoaderMac.mm:
- page/DOMWindowExtension.cpp:
- page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore):
(WebCore::Frame::reportMemoryUsage):
- page/Frame.h:
(WebCore):
(Frame):
(WebCore::Frame::init):
(WebCore::Frame::loader):
- page/PerformanceNavigation.cpp:
- page/PerformanceTiming.cpp:
- page/PointerLockController.cpp:
- page/Settings.cpp:
- page/animation/CSSPropertyAnimation.cpp:
- platform/chromium/PasteboardChromium.cpp:
- platform/efl/ErrorsEfl.cpp:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/filters/FilterOperation.cpp:
(WebCore):
- platform/graphics/filters/FilterOperation.h:
(WebCore):
(WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
(WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
- platform/gtk/ErrorsGtk.cpp:
- platform/gtk/PasteboardGtk.cpp:
- platform/gtk/PasteboardHelper.h:
- platform/mac/ClipboardMac.h:
- platform/mac/ClipboardMac.mm:
- platform/mac/HTMLConverter.mm:
- platform/mac/PasteboardMac.mm:
- platform/network/AuthenticationChallengeBase.cpp:
- platform/network/cf/CookieJarCFNet.cpp:
- platform/network/cf/ResourceRequestCFNet.cpp:
- platform/network/mac/CookieStorageMac.mm:
- platform/qt/PasteboardQt.cpp:
- plugins/DOMMimeType.cpp:
- plugins/PluginRequest.h: Removed.
- plugins/PluginStream.h:
(PluginStreamClient):
(WebCore::PluginStreamClient::~PluginStreamClient):
(WebCore::PluginStreamClient::streamDidFinishLoading):
(WebCore):
- plugins/PluginStreamClient.h: Removed.
- plugins/PluginView.cpp:
- plugins/PluginView.h:
(WebCore):
(PluginRequest):
(WebCore::PluginRequest::PluginRequest):
(WebCore::PluginRequest::frameLoadRequest):
(WebCore::PluginRequest::notifyData):
(WebCore::PluginRequest::sendNotification):
(WebCore::PluginRequest::shouldAllowPopups):
- rendering/HitTestResult.cpp:
- rendering/InlineFlowBox.cpp:
- rendering/RenderBox.cpp:
- rendering/RenderEmbeddedObject.cpp:
- rendering/RenderImage.cpp:
- rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::RenderImageResource):
(WebCore):
- rendering/RenderImageResource.h:
(WebCore::RenderImageResource::image):
(WebCore::RenderImageResource::errorOccurred):
(WebCore::RenderImageResource::usesImageContainerSize):
(WebCore::RenderImageResource::imageHasRelativeWidth):
(WebCore::RenderImageResource::imageHasRelativeHeight):
(WebCore::RenderImageResource::imageSize):
- rendering/RenderImageResourceStyleImage.cpp:
- rendering/RenderLayer.cpp:
- rendering/RenderLayerBacking.cpp:
- rendering/RenderLayerFilterInfo.h:
(WebCore):
- rendering/RenderListItem.cpp:
- rendering/RenderListMarker.cpp:
- rendering/RenderSnapshottedPlugIn.cpp:
- rendering/RenderTableCol.cpp:
- rendering/RenderTableRow.cpp:
- rendering/RenderTableSection.cpp:
- rendering/style/StyleCachedShader.h:
- rendering/style/StyleCustomFilterProgram.cpp: Removed.
- rendering/style/StyleCustomFilterProgram.h:
(WebCore):
(WebCore::StyleCustomFilterProgram::vertexShaderString):
(StyleCustomFilterProgram):
(WebCore::StyleCustomFilterProgram::fragmentShaderString):
(WebCore::StyleCustomFilterProgram::isLoaded):
(WebCore::StyleCustomFilterProgram::willHaveClients):
(WebCore::StyleCustomFilterProgram::didRemoveLastClient):
(WebCore::StyleCustomFilterProgram::notifyFinished):
- svg/SVGFEImageElement.h:
- svg/SVGFontFaceUriElement.h:
(SVGFontFaceUriElement):
- svg/SVGImageLoader.cpp:
- svg/SVGUseElement.cpp:
- svg/SVGUseElement.h:
- svg/graphics/SVGImageCache.cpp:
- testing/MockPagePopupDriver.cpp:
- xml/XSLStyleSheet.h:
(WebCore):
- xml/XSLTProcessorLibxslt.cpp:
- xml/parser/XMLDocumentParser.cpp:
- xml/parser/XMLDocumentParser.h:
- xml/parser/XMLDocumentParserLibxml2.cpp:
Source/WebKit/chromium:
- src/ApplicationCacheHost.cpp:
- src/AssociatedURLLoader.cpp:
- src/EditorClientImpl.cpp:
- src/SharedWorkerRepository.cpp:
- src/WebDataSourceImpl.cpp:
- src/WebFrameImpl.h:
(WebCore):
- src/WebNode.cpp:
- src/WebSharedWorkerImpl.cpp:
- tests/FrameLoaderClientImplTest.cpp:
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- ewk/ewk_frame.cpp:
Source/WebKit/gtk:
- webkit/webkitwebpolicydecision.cpp:
Source/WebKit/mac:
- DOM/WebDOMOperations.mm:
- Misc/WebNSPasteboardExtras.mm:
- WebCoreSupport/WebFrameNetworkingContext.mm:
- WebView/WebRenderLayer.mm:
- WebView/WebRenderNode.mm:
Source/WebKit/qt:
- WebCoreSupport/NotificationPresenterClientQt.cpp:
- WebCoreSupport/QWebPageAdapter.cpp:
Source/WebKit2:
- NetworkProcess/HostRecord.h:
- NetworkProcess/NetworkResourceLoadScheduler.h:
- NetworkProcess/NetworkResourceLoader.h:
(WebCore):
- Shared/WebRenderLayer.cpp:
- Shared/WebRenderObject.cpp:
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
- WebProcess/WebPage/mac/WebPageMac.mm:
- WebProcess/WebProcess.cpp:
- WebProcess/soup/WebProcessSoup.cpp:
- 12:56 AM Changeset in webkit [144564] by
-
- 2 edits in trunk/Source/WebKit/chromium
WebKit API for enabling DOM logging for certain worlds
https://bugs.webkit.org/show_bug.cgi?id=110779
Patch by Ankur Taly <ataly@google.com> on 2013-03-03
Reviewed by Kentaro Hara.
- WebKit.gyp:
- 12:52 AM Changeset in webkit [144563] by
-
- 4 edits in trunk/Source/WebCore
[V8] Remove TranslateParameter() from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=111218
Reviewed by Adam Barth.
TranslateParameter() does nothing. It tries to convert TimeoutHandler to DOMString,
but there is no non-custom method that uses TimeoutHandler.
The only place where TimeoutHandler is used in the WebKit IDL is setTimeout() and setInterval().
However, the latest spec uses 'any' instead of TimeoutHandler.
http://dev.w3.org/html5/spec-LC/timers.html
Thus, this patch updates the IDL declarations of setTimeout() and setInterval()
according to the spec. By this change, TimeoutHandler is gone away from the WebKit IDL.
(Anyway this IDL change has no effect, because setTimeout() and setInterval() are written
in custom bindings.)
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
- page/DOMWindow.idl:
- workers/WorkerContext.idl:
- 12:46 AM Changeset in webkit [144562] by
-
- 4 edits1 add in trunk/Source
keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux
https://bugs.webkit.org/show_bug.cgi?id=85642
Source/WebCore:
Add missing key mappings for GDK_KP_Begin, GDK_KP_Insert, GDK_KP_Delete and GDK_ISO_Level3_Shift.
Patch by James Weatherall <wez@chromium.org> on 2013-03-03
Reviewed by Adam Barth.
- platform/chromium/KeyCodeConversionGtk.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
Source/WebKit/chromium:
Add tests to verify that the fixed keys generate the same keyCode values as their equivalents.
Patch by James Weatherall <wez@chromium.org> on 2013-03-03
Reviewed by Adam Barth.
- WebKit.gypi:
- tests/KeyCodeConversionTestGtk.cpp: Added.
(WebCore):
(WebCore::TEST):
- 12:33 AM Changeset in webkit [144561] by
-
- 6 edits in trunk/Source/WebCore
REGRESSION(144520): Does not compile on chromium-win
https://bugs.webkit.org/show_bug.cgi?id=111261
Unreviewed rollout of http://trac.webkit.org/changeset/144520. This
patch does not compile for chromium-win. See the bug for the compile
error.
- rendering/ExclusionShapeInsideInfo.cpp:
- rendering/ExclusionShapeInsideInfo.h:
(WebCore):
(LineSegmentRange):
(WebCore::LineSegmentRange::LineSegmentRange):
(WebCore::ExclusionShapeInsideInfo::isEnabledFor):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::exclusionShapeInsideInfo):
(WebCore):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange):
- rendering/RenderBlock.h:
(WebCore):
(RenderBlock):
(RenderBlockRareData):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::constructBidiRunsForLine):
Mar 2, 2013:
- 11:31 PM Changeset in webkit [144560] by
-
- 10 edits in branches/safari-534.59-branch
Merge r143790
2013-02-22 Anders Carlsson <andersca@apple.com>
Source/WebKit2:
Move pluginLoadPolicy to the page loader client
https://bugs.webkit.org/show_bug.cgi?id=110635
<rdar://problem/13265303>
Reviewed by Sam Weinig.
Move the pluginLoadPolicy callback to the page loader client where it belongs.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp: (WebKit::toWKPluginLoadPolicy): (WebKit): (WebKit::toPluginModuleLoadPolicy): (WebKit::WebLoaderClient::pluginLoadPolicy):
- UIProcess/WebLoaderClient.h: (WebLoaderClient):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
- UIProcess/WebUIClient.cpp: (WebKit):
- UIProcess/WebUIClient.h: (WebUIClient):
- UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage):
Tools:
Move pluginLoadPolicy to the page loader client
https://bugs.webkit.org/show_bug.cgi?id=110635
Reviewed by Sam Weinig.
- MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions):
- 11:13 PM Changeset in webkit [144559] by
-
- 4 edits in trunk
REGRESSION (r144517): IndexedDB layout test failures on GTK
https://bugs.webkit.org/show_bug.cgi?id=111243
Reviewed by Martin Robinson.
Source/WebCore:
Changes to the custom JSC bindings for IDBAny are required after r144517,
specifically the case of IDBAny object having the KeyPathType type has to be covered.
These changes are analogous to those made to the V8 bindings in the mentioned commit.
No new tests - already covered by existing tests.
- bindings/js/JSIDBAnyCustom.cpp:
(WebCore::toJS): A helper function that wraps an IDBKeyPath into a JSValue.
(WebCore): Shuffle the order inside the switch statement a bit to match the V8 custom bindings.
Cover the case where the IDBAny object has the KeyPathType, calling the new helper method.
LayoutTests:
- platform/gtk/TestExpectations: Removing failure expectations for IDB tests that again pass.
- 10:59 PM Changeset in webkit [144558] by
-
- 4 edits2 adds in branches/safari-534.59-branch
Merge r142919
2013-02-14 Anders Carlsson <andersca@apple.com>
Add WKContextIsPlugInUpdateAvailable
https://bugs.webkit.org/show_bug.cgi?id=109862
<rdar://problem/13173140>
Reviewed by Sam Weinig.
Source/WebKit2:
- UIProcess/API/C/mac/WKContextPrivateMac.h:
- UIProcess/API/C/mac/WKContextPrivateMac.mm: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.cpp. (WKContextGetProcessSuppressionEnabled): (WKContextSetProcessSuppressionEnabled): (WKContextIsPlugInUpdateAvailable):
- WebKit2.xcodeproj/project.pbxproj:
WebKitLibraries:
Roll WebKitSystemInterface DEPS.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 10:55 PM Changeset in webkit [144557] by
-
- 2 edits in trunk/Source/WebCore
Another try at fixing the build.
- 10:33 PM Changeset in webkit [144556] by
-
- 9 edits in branches/safari-534.59-branch/Source/WebKit2
Merge r142017
2013-02-06 Anders Carlsson <andersca@apple.com>
Pass the document source URL to the pluginLoadPolicy callback
https://bugs.webkit.org/show_bug.cgi?id=109084
<rdar://problem/13154516>
Reviewed by Andreas Kling.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
- UIProcess/WebPageProxy.h: (WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::pluginLoadPolicy):
- UIProcess/WebUIClient.h: (WebUIClient):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): (WebKit::WebPage::canPluginHandleResponse):
- 10:31 PM Changeset in webkit [144555] by
-
- 2 edits in trunk/Source/WebCore
Try to fix build.
- 10:24 PM Changeset in webkit [144554] by
-
- 5 edits in branches/safari-534.59-branch/Source/WebKit2
Merge r141923
2013-02-05 Anders Carlsson <andersca@apple.com>
WebKit clients should be able to override loading of blocked plug-ins
https://bugs.webkit.org/show_bug.cgi?id=108968
<rdar://problem/13154516>
Reviewed by Sam Weinig.
Replace the shouldInstantiatePlugin callback with a new pluginLoadPolicy which is called regardless
of whether the plug-in is blocked or not. This lets clients override the plug-in load policy and
force loading of blacklisted plug-ins (and vice versa).
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
- UIProcess/WebUIClient.cpp: (WebKit::toWKPluginLoadPolicy): (WebKit): (WebKit::toPluginModuleLoadPolicy): (WebKit::WebUIClient::pluginLoadPolicy):
- UIProcess/WebUIClient.h: (WebUIClient):
- 9:55 PM Changeset in webkit [144553] by
-
- 16 edits in trunk/Source
Cut down the number of source files that depend on Clipboard.h
https://bugs.webkit.org/show_bug.cgi?id=110030
Reviewed by Ryosuke Niwa.
Source/WebCore:
I am doing some work on Clipboard and it's better to recompile 50 files
each time we touch the header instead of 700. Also cut down on includes
of DragState.h.
- WebCore.exp.in: Updated for new MouseEvent::create function.
- dom/ClipboardEvent.cpp: Added include of Clipboard.h since we use it
here and the world no longer includes it everywhere.
- dom/ClipboardEvent.h: Forward declared Clipboard instead of including
Clipboard.h. Also made some overrides private because they can be.
- dom/DataTransferItem.h: Removed unneeded include of Clipboard.h.
- dom/MouseEvent.cpp: Added include of Clipboard.h since we use it
here and the world no longer includes it everywhere.
(WebCore::MouseEvent::create): Made the create function non-inline
since we can't compile it without including Clipboard.h and we don't
want to include Clipboard.h in the header. This is not so commonly
used or so hot that this needs to be inlined.
- dom/MouseEvent.h: Forward declared Clipboard instead of including
Clipboard.h. Made MouseEvent::create a non-inline function and also
used overloading instead of default arguments, since we can't compile
a default argument of type PassRefPtr<Clipboard> without including
Clipboard.h.
- dom/WheelEvent.cpp: Added include of Clipboard.h since we use it
here and the world no longer includes it everywhere.
- dom/WheelEvent.h: Forward declare PlatformWheelEvent since it is used
in this header. Previously we'd get it indirectly from including a header
that included Clipboard.h.
- editing/Editor.cpp: Added include of Clipboard.h since we use it here
and the world no longer includes it everywhere.
- inspector/InspectorDebuggerAgent.cpp: Added include of CachedResource.h.
We used to get this indirectly through Clipboard.h.
- inspector/InspectorFrontendHost.cpp: Added includes of ResourceError.h
and ResourceResponse.h. We used to get these indirectly through Clipboard.h.
Also removed unneeded include of <wtf/RefPtr.h>.
- inspector/NetworkResourcesData.cpp: Added include of CachedResource.h.
We used to get this indirectly through Clipboard.h.
- loader/PingLoader.cpp: Added include of ResourceResponse.h.
We used to get this indirectly through Clipboard.h.
- page/DragController.cpp: Added include of DragState.h.
We used to get this indirectly through EventHandler.h
- page/EventHandler.h: Forward declared DragState and Element instead of
including DragState.h. Also added an include of LayoutPoint.h, which we
used to get indirectly through DragState.h.
Source/WebKit/chromium:
- src/SharedWorkerRepository.cpp: Add include of ResourceResponse.h
here. We used to get this indirectly through Clipboard.h.
Source/WebKit/mac:
- WebView/WebPDFView.mm: Add include of Clipboard.h since we use it
here and the world no longer includes it everywhere.
- 9:47 PM Changeset in webkit [144552] by
-
- 13 edits1 add in trunk
StringHasher functions require alignment that call sites do not all guarantee
https://bugs.webkit.org/show_bug.cgi?id=110171
Reviewed by Benjamin Poulain.
Source/WebCore:
- platform/graphics/WidthCache.h:
(WebCore::WidthCache::SmallStringKey::SmallStringKey): Use the newly added
addCharactersAssumingAligned to make sure we don't slow this call site down.
It's safe since this code always adds characters two at a time.
Source/WTF:
The StringHasher class is optimized for clients who pass it two characters at
a time. However, the function named addCharacters did not make this clear to
clients, and one calculateStringHashAndLengthFromUTF8MaskingTop8Bits got it wrong.
Fix by making addCharacters work regardless of hasher alignment and adding a new
function, addCharactersAssumingAligned, for use when we want a faster path and can
guarantee we are adding characters two at a time.
- wtf/StringHasher.h:
(WTF::StringHasher::addCharactersAssumingAligned): Renamed the addCharacters function
addCharactersAssumingAligned, since it only works if the hasher is currently aligned,
meaning it contains an even number of characters. The function already asserts
that this is true, but the calculateStringHashAndLengthFromUTF8MaskingTop8Bits
function was using it in cases where the assertion could fire. Also updated to
call addCharactersInternal by its new name. Also added some new overloads that take
data pointers and lengths so callers can always use addCharactersAssumingAligned
instead of addCharacters if they know the hasher is aligned.
(WTF::StringHasher::addCharacter): Updated to call the public
addCharactersAssumingAligned function since that's simpler and a bit cleaner.
(WTF::StringHasher::addCharacters): Added functions with this name that handle
the case where the hasher is not aligned. These will be called by existing call sites
that were formerly using the function named addCharactersAssumingAligned above.
Also add an overload that works with the default converter automatically.
(WTF::StringHasher::computeHashAndMaskTop8Bits): Changed to call
addCharactersAssumingAligned to eliminate copied and pasted code. The hasher is empty,
so definitely aligned.
(WTF::StringHasher::computeHash): Ditto.
(WTF::StringHasher::addCharactersInternal): Renamed from addCharactersToHash, since
the former name did not make clear how this differs from the public functions.
The real difference is that this is like addCharactersAssumingAligned, but without
the assertion, so addCharactersAssumingAligned is called instead, even within the
class's implementation.
Tools:
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/GNUmakefile.am:
- TestWebKitAPI/TestWebKitAPI.gypi:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/WTF.pro:
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
Added the StringHasher.cpp file.
- TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests
for the functions in the StringHasher class.
- 8:05 PM Changeset in webkit [144551] by
-
- 19 edits1 add in branches/safari-534.59-branch
Merge r141486
2013-01-31 Brian Weinstein <bweinstein@apple.com>
Add a call to the page UI client to determine if a plug-in should load
https://bugs.webkit.org/show_bug.cgi?id=108407
<rdar://problem/13066332>
Source/WebKit2:
Reviewed by Anders Carlsson.
This patch adds a client call to the WKPageUIClient to be called to determine
whether or not a plug-in should load.
- UIProcess/API/C/WKPage.h: Add shouldLoadPlugin.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): Moved from WebProcessProxy, and added a call to
m_uiClient.shouldInstantiatePlugin.
- UIProcess/WebPageProxy.h:
- UIProcss/WebPageProxy.messages.in: Moved GetPluginPath from WebProcessProxy to WebPageProxy.
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::getPluginPath): Moved to WebPageProxy.
- UIProcess/WebProcessProxy.h:
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::shouldInstantiatePlugin): Return that we should load the plug-in if
the client function isn't defined, and call the function if it is.
- UIProcess/WebUIClient.h:
- UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage): Add an entry for the new
client function.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): Send the message to the WebPageProxy, not the WebProcessProxy. (WebKit::WebPage::canPluginHandleResponse): Made a member function, so it can call sendSync, and
send the message to the WebPageProxy, not the WebProcessProxy.
- WebProcess/WebPage/WebPage.h:
Tools:
Add entries for the new function in the necessary structs.
Reviewed by Anders Carlsson.
- MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions):
- 6:53 PM Changeset in webkit [144550] by
-
- 5 edits in trunk/Source/WebKit2
WebKit2 is missing the setShowsURLsInToolTips preference
https://bugs.webkit.org/show_bug.cgi?id=111259
<rdar://problem/12991891>
Reviewed by Maciej Stachowiak.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetShowsURLsInToolTipsEnabled):
(WKPreferencesGetShowsURLsInToolTipsEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Pipe it through.
- 5:45 PM Changeset in webkit [144549] by
-
- 2 edits in trunk/Source/WebCore
XSSAuditor has a subtle race condition when used with the threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=111253
Reviewed by Eric Seidel.
We were refing and derefing a StringImpl for a main-thread
AtomicString. Using QualifiedNames on the background thread is very
fragile and we should figure out a more robust solution.
- html/parser/XSSAuditor.cpp:
(WebCore::findAttributeWithName):
- 4:57 PM Changeset in webkit [144548] by
-
- 2 edits in trunk/Source/WebKit/win
Export a missing symbol after r144547.
Unreviewed.
- WebKit.vcproj/WebKitExports.def.in:
- 4:08 PM Changeset in webkit [144547] by
-
- 47 edits in trunk
Move computedStyleIncludingVisitedInfo from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=109772
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-02
Reviewed by Andreas Kling.
Source/WebCore:
The function computedStyleIncludingVisitedInfo() is purely internal to WebCore,
it is better defined on Internals than on TestRunner.
- testing/Internals.cpp:
(WebCore::Internals::computedStyleIncludingVisitedInfo):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/blackberry:
- WebKitSupport/DumpRenderTreeSupport.cpp:
- WebKitSupport/DumpRenderTreeSupport.h:
(DumpRenderTreeSupport):
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/mac:
- WebView/WebView.mm:
- WebView/WebViewPrivate.h:
Source/WebKit/qt:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
- WebProcess/WebPage/WebFrame.cpp:
- WebProcess/WebPage/WebFrame.h:
(WebFrame):
Tools:
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h:
(TestRunner):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- DumpRenderTree/efl/TestRunnerEfl.cpp:
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
- DumpRenderTree/mac/TestRunnerMac.mm:
- DumpRenderTree/qt/TestRunnerQt.cpp:
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
- DumpRenderTree/win/TestRunnerWin.cpp:
- DumpRenderTree/wx/TestRunnerWx.cpp:
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
LayoutTests:
Update the tests.
- fast/history/multiple-classes-visited.html:
- fast/history/nested-visited-test.html:
- fast/history/self-is-visited.html:
- fast/history/sibling-visited-test.html:
- fast/loader/stateobjects/state-url-sets-links-visited.html:
- platform/win/TestExpectations: unskip the tests.
- platform/chromium/TestExpectations:
- 3:42 PM Changeset in webkit [144546] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r143637): Export ScriptController::javaScriptContext() on iOS
<http://webkit.org/b/106059>
Fixes the following build failure:
Undefined symbols for architecture armv7:
"ZN7WebCore16ScriptController17javaScriptContextEv", referenced from:
-[WebFrame javaScriptContext] in WebFrame.o
ZN20WebFrameLoaderClient35dispatchDidClearWindowObjectInWorldEPN7WebCore15DOMWrapperWorldE in WebFrameLoaderClient.o
ld: symbol(s) not found for architecture armv7
- WebCore.exp.in: Export ScriptController::javaScriptContext()
even more unconditionally.
- 3:36 PM Changeset in webkit [144545] by
-
- 2 edits in trunk/Source/WebKit/mac
BUILD FIX (r143637): Predeclare JSContext as an Objective-C class
<http://webkit.org/b/106059>
Fixes the following build failure:
In file included from Source/WebKit/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.m:11:
In file included from Source/WebKit/mac/WebView/WebFrameLoadDelegatePrivate.h:29:
Source/WebKit/mac/WebView/WebFrameLoadDelegate.h:215:64: error: expected a type
- (void)webView:(WebView *)webView didCreateJavaScriptContext:(JSContext *)context forFrame:(WebFrame *)frame;
1 error generated.
- WebView/WebFrameLoadDelegate.h: Add @class JSContext
declaration.
- 1:06 PM Changeset in webkit [144544] by
-
- 4 edits in trunk/Source/WebCore
Remove two unnecessary mallocs from the main-thread-parser code path
https://bugs.webkit.org/show_bug.cgi?id=111249
Reviewed by Adam Barth.
I noticed these while fixing up our Vector -> String conversions
but never went back to fix the FIXME.
AtomicString(Vector<UChar, capacity>) is smart enough to avoid mallocing
if the represented string is already in the AtomicString table. It
also handles 8bit vs. 16bit and empty() just like nameString() does.
I also removed a 3rd caller to nameString() in the XSSAuditor which
was causing an unnecessary malloc in both the main and background
thread parser paths.
- html/parser/AtomicHTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
- html/parser/HTMLToken.h:
- html/parser/XSSAuditor.cpp:
(WebCore):
(WebCore::threadSafeMatch):
(WebCore::hasName):
- 10:09 AM Changeset in webkit [144543] by
-
- 2 edits in trunk/Source/WebCore
constructTreeFromCompactHTMLToken should call clearExternalCharacters
https://bugs.webkit.org/show_bug.cgi?id=111248
Reviewed by Adam Barth.
I don't know how to write a test for this. It's possible characters()
is never accessed from HTMLStackItem::token(), but it's better to be
safe than sorry here.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::constructTreeFromCompactHTMLToken):
- 7:02 AM Changeset in webkit [144542] by
-
- 3 edits2 adds in trunk
Text overflow ellipsis wrong color when using webkit-text-fill-color
https://bugs.webkit.org/show_bug.cgi?id=54841
Reviewed by David Hyatt.
Source/WebCore:
Take -webkit-text-fill-color into account for ellipsis painting.
Test: fast/css/text-overflow-ellipsis-color.html
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
LayoutTests:
Add reftest for using -webkit-text-fill-color in combination with text-overflow:ellipsis.
- fast/css/text-overflow-ellipsis-color-expected.html: Added.
- fast/css/text-overflow-ellipsis-color.html: Added.
- 6:39 AM Changeset in webkit [144541] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip some passing tests.
- platform/efl/TestExpectations: Remove tests that pass after
- 4:36 AM Changeset in webkit [144540] by
-
- 4 edits in trunk/Source/WebKit/win
- WebCoreSupport/WebFrameNetworkingContext.cpp:
- WebCoreSupport/WebFrameNetworkingContext.h:
- WebCoreSupport/WebPlatformStrategies.cpp:
- 3:59 AM Changeset in webkit [144539] by
-
- 10 edits in branches/chromium/1410
Merge 144352
REGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type=date] unexpectedly makes another line for ::-webkit-calendar-picker-indicator
https://bugs.webkit.org/show_bug.cgi?id=110974
Reviewed by Kentaro Hara.
Source/WebCore:
Input elements with the multiple fields UI require flexible box
layout.
- If display:inline or display:inline-block is specified, we replace it with display:inline-flex.
- If display:block is specified, we replace it with display:flex.
- If other display value is specified, we use it as is, but it won't wrap inside an input element because we have display:inline-block for ::-webkit-calendar-pixker-indicaotor.
r144184 was incomplete. It avoided the wrapping issue, but it
didn't make spin buttons and calendar arrows right-aligned.
Tests: Update fast/forms/date/date-apparance-basic.html
- css/html.css:
(input::-webkit-calendar-picker-indicator):
Add display:inline-block in orde to avoid line-wrapping.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::customStyleForRenderer):
Move the code to BaseMultipleFieldsDateAndTimeInputType::customStyleForRenderer.
- html/InputType.cpp:
(WebCore::InputType::customStyleForRenderer): Added.
- html/InputType.h:
(InputType): Add customStyleForRenderer, and remove
shouldApplyLocaleDirection.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::customStyleForRenderer):
Moved the code from HTMLInputElement::customStyleForRenderer, and
add display property updatting code.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
Add customStyleForRenderer, and remove shouldApplyLocaleDirection.
LayoutTests:
- fast/forms/date/date-appearance-basic-expected.txt:
- fast/forms/date/date-appearance-basic.html:
- platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium/TestExpectations:
TBR=tkent@chromium.org
BUG=crbug.com/178175
- 2:14 AM Changeset in webkit [144538] by
-
- 3 edits in trunk/Source/WebKit/win
Yet another build fix attempt after r144530.
- WebCoreSupport/WebFrameNetworkingContext.cpp:
- WebCoreSupport/WebPlatformStrategies.cpp:
- 1:54 AM Changeset in webkit [144537] by
-
- 2 edits in trunk/Source/WebKit/win
Another build fix attempt after r144530.
- WebCoreSupport/WebFrameNetworkingContext.cpp:
- 1:07 AM Changeset in webkit [144536] by
-
- 2 edits in trunk/Source/WebCore
Fix a typo in my previous commit (r144534).
- platform/win/PasteboardWin.cpp:
- 1:02 AM Changeset in webkit [144535] by
-
- 22 edits2 copies5 adds in trunk
[WebGL] Support for texImage2D of type HALF_FLOAT_OES with ArrayBufferView.
https://bugs.webkit.org/show_bug.cgi?id=110818
Reviewed by Kenneth Russell.
As per OES_texture_half_float specification texImage2D and texSubImage2D entry
points taking ArrayBufferView should extended to accept null with the pixel type
HALF_FLOAT_OES.
Source/WebCore:
Tests: fast/canvas/webgl/oes-texture-half-float-not-supported.html
fast/canvas/webgl/oes-texture-half-float.html
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- html/canvas/OESTextureHalfFloat.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebCore::OESTextureHalfFloat::OESTextureHalfFloat):
(WebCore::OESTextureHalfFloat::~OESTextureHalfFloat):
(WebCore::OESTextureHalfFloat::getName):
(WebCore::OESTextureHalfFloat::create):
- html/canvas/OESTextureHalfFloat.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(OESTextureHalfFloat):
- html/canvas/OESTextureHalfFloat.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContext::validateTexFuncData):
- html/canvas/WebGLRenderingContext.h:
(WebCore):
(WebGLRenderingContext):
- html/canvas/WebGLRenderingContext.idl:
- platform/graphics/Extensions3D.h:
(Extensions3D):
- platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/GraphicsTypes3D.h:
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::texImage2D):
LayoutTests:
- fast/canvas/webgl/constants.html:
- fast/canvas/webgl/oes-texture-half-float-expected.txt: Added.
- fast/canvas/webgl/oes-texture-half-float-not-supported-expected.txt: Added.
- fast/canvas/webgl/oes-texture-half-float-not-supported.html: Added.
- fast/canvas/webgl/oes-texture-half-float.html: Added.
- 12:57 AM Changeset in webkit [144534] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix attempt after r144530.
- platform/win/PasteboardWin.cpp:
Mar 1, 2013:
- 11:52 PM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 11:51 PM WebKitGTK/WebKit2Roadmap edited by
- Update roadmap (diff)
- 11:46 PM Changeset in webkit [144533] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix the build after r144530.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h: Include the header for the
base class.
- 11:00 PM Changeset in webkit [144532] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding failure expectations for IndexedDB tests
that regressed on platforms using JavaScriptCore with r144517.
- 10:41 PM Changeset in webkit [144531] by
-
- 2 edits in trunk/Source/WebCore
Remove unused member variable m_useLatchedEventNode from PlatformWheelEvent.h
https://bugs.webkit.org/show_bug.cgi?id=107314
Reviewed by Darin Adler.
EventHandler::handleGestureScrollCore() was removed in http://trac.webkit.org/changeset/140177,
and this was the only place where the member variable |m_useLatchedEventNode| in
PlatformWheelEvent was mutated. This variable is no longer needed and so it should be removed.
No change in behavior, so no new tests needed.
- platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::useLatchedEventNode):
(PlatformWheelEvent):
- 10:36 PM Changeset in webkit [144530] by
-
- 208 edits7 adds in trunk/Source
Reduce amount of rebuilding when touching networking headers
https://bugs.webkit.org/show_bug.cgi?id=111035
Reviewed by Eric Seidel.
This uses a number of common unsurprising techniques. One interesting observation
is that including CachedResource related headers is very expensive. We can usually
get away with their Client counterparts, and with CachedResourceHandle.
- page/Frame.cpp:
- page/Frame.h: Don't include FrameLoader, greatly reducing include graph for most non-loader files. This required making Frame::init() non-inline - I'm not sure why it ever was.
- loader/FrameLoader.cpp:
- loader/FrameLoader.h: Even though FrameLoader is logically on loading side of WebCore, it's included in too many places. Not including PolicyChecker.h and ResourceHandle.h was among the largest wins. As a future improvement, we should probably convert other members to OwnPtrs.
- css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a definition of a class it holds, but default construction does not.
- loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h, not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
- loader/cache/CachedFont.h:
- loader/cache/CachedFontClient.h: Added.
- loader/cache/CachedRawResource.h:
- loader/cache/CachedRawResourceClient.h: Added.
- loader/cache/CachedSVGDocument.h:
- loader/cache/CachedSVGDocumentClient.h: Added. These types were defining client types in the same headers, making it impossible to avoid including networking headers through CachedResource. Moved clients into separate files.
- plugins/PluginStream.h:
- plugins/PluginStreamClient.h: Added. Similar situation here.
- loader/cache/CachedResourceHandle.cpp:
- loader/cache/CachedResourceHandle.h: Moved functions that need to know about CachedResource to .cpp file. This is another huge win. Added a destructor, so that CachedResource woudn't be needed in all files that include CachedResourceHandle.
- loader/cache/CachedSVGDocumentReference.cpp: Added.
- loader/cache/CachedSVGDocumentReference.h: Moved constructor and virtual function implementations to a .cpp file - they need not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
- platform/graphics/filters/FilterOperation.cpp:
- platform/graphics/filters/FilterOperation.h: Avoid including CachedSVGDocumentReference.h. This is not such a big win now that CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly rendering code that it seems best to cut any ties with resources and loading. Added a virtual destrutor in .cpp file, because inline destructors in polymorphic classes are generally harmful (due to code bloat).
- plugins/PluginRequest.h: Added.
- plugins/PluginView.h: Moved PluginRequest into a separate file, it was out of place in a view hierarchy class file.
- rendering/RenderImageResource.cpp:
- rendering/RenderImageResource.h: Moved definitions of virtual functions to a .cpp file. Thre is no win from having them inline, and now we don't need CachedImage.h in the header.
- rendering/style/StyleCustomFilterProgram.cpp: Added.
- rendering/style/StyleCustomFilterProgram.h: Ditto.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/RTCPeerConnection.cpp:
- Modules/notifications/Notification.cpp:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/ScriptControllerBase.cpp:
- bindings/js/JSNodeCustom.cpp:
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptSourceCode.h:
- bindings/objc/DOM.mm:
- bindings/v8/ScriptController.cpp:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- css/CSSFontFaceSource.h:
- css/CSSFontSelector.cpp:
- css/WebKitCSSSVGDocumentValue.cpp:
- css/WebKitCSSSVGDocumentValue.h:
- dom/Clipboard.cpp:
- dom/ContainerNode.cpp:
- dom/DOMImplementation.cpp:
- dom/PendingScript.h:
- dom/ScriptElement.cpp:
- dom/ScriptElement.h:
- history/CachedFrame.cpp:
- html/DOMURL.cpp:
- html/HTMLAnchorElement.cpp:
- html/HTMLAppletElement.cpp:
- html/HTMLElement.cpp:
- html/HTMLEmbedElement.cpp:
- html/HTMLFrameSetElement.cpp:
- html/HTMLHtmlElement.cpp:
- html/HTMLImageElement.cpp:
- html/HTMLObjectElement.cpp:
- html/HTMLPlugInElement.cpp:
- html/ImageDocument.cpp:
- html/ImageInputType.cpp:
- html/MediaDocument.cpp:
- html/PluginDocument.cpp:
- html/canvas/WebGLRenderingContext.cpp:
- html/parser/HTMLConstructionSite.cpp:
- html/parser/HTMLParserOptions.cpp:
- html/parser/HTMLScriptRunner.h:
- html/parser/XSSAuditor.cpp:
- html/parser/XSSAuditorDelegate.cpp:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorFileSystemAgent.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorInstrumentation.h:
- inspector/InspectorPageAgent.cpp:
- inspector/NetworkResourcesData.cpp:
- inspector/NetworkResourcesData.h:
- loader/CookieJar.cpp:
- loader/CrossOriginAccessControl.cpp:
- loader/CrossOriginPreflightResultCache.h:
- loader/DocumentThreadableLoader.h:
- loader/ImageLoader.cpp:
- loader/ImageLoader.h:
- loader/LinkLoader.h:
- loader/MainResourceLoader.cpp:
- loader/MainResourceLoader.h:
- loader/MixedContentChecker.cpp:
- loader/PingLoader.cpp:
- loader/PolicyChecker.h:
- loader/ProgressTracker.cpp:
- loader/SubframeLoader.cpp:
- loader/SubresourceLoader.cpp:
- loader/TextTrackLoader.cpp:
- loader/TextTrackLoader.h:
- loader/ThreadableLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp:
- loader/appcache/ApplicationCacheGroup.h:
- loader/appcache/ApplicationCacheHost.cpp:
- loader/archive/cf/LegacyWebArchive.cpp:
- loader/cache/CachedFont.cpp:
- loader/cache/CachedImage.cpp:
- loader/cache/CachedRawResource.cpp:
- loader/cache/CachedResource.cpp:
- loader/cache/CachedStyleSheetClient.h:
- loader/cache/MemoryCache.cpp:
- loader/cache/MemoryCache.h:
- loader/chromium/CachedRawResourceChromium.cpp:
- loader/icon/IconController.cpp:
- loader/icon/IconLoader.h:
- loader/mac/ResourceLoaderMac.mm:
- page/DOMWindowExtension.cpp:
- page/DragController.cpp:
- page/PerformanceNavigation.cpp:
- page/PerformanceTiming.cpp:
- page/PointerLockController.cpp:
- page/Settings.cpp:
- page/animation/CSSPropertyAnimation.cpp:
- platform/chromium/PasteboardChromium.cpp:
- platform/efl/ErrorsEfl.cpp:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
- platform/gtk/ErrorsGtk.cpp:
- platform/gtk/PasteboardGtk.cpp:
- platform/gtk/PasteboardHelper.h:
- platform/mac/ClipboardMac.h:
- platform/mac/ClipboardMac.mm:
- platform/mac/HTMLConverter.mm:
- platform/mac/PasteboardMac.mm:
- platform/network/AuthenticationChallengeBase.cpp:
- platform/network/cf/CookieJarCFNet.cpp:
- platform/network/cf/ResourceRequestCFNet.cpp:
- platform/network/mac/CookieStorageMac.mm:
- platform/qt/PasteboardQt.cpp:
- plugins/DOMMimeType.cpp:
- plugins/PluginView.cpp:
- rendering/HitTestResult.cpp:
- rendering/InlineFlowBox.cpp:
- rendering/RenderBox.cpp:
- rendering/RenderEmbeddedObject.cpp:
- rendering/RenderImage.cpp:
- rendering/RenderImageResourceStyleImage.cpp:
- rendering/RenderLayer.cpp:
- rendering/RenderLayerBacking.cpp:
- rendering/RenderLayerFilterInfo.h:
- rendering/RenderListItem.cpp:
- rendering/RenderListMarker.cpp:
- rendering/RenderSnapshottedPlugIn.cpp:
- rendering/RenderTableCol.cpp:
- rendering/RenderTableRow.cpp:
- rendering/RenderTableSection.cpp:
- rendering/style/StyleCachedShader.h:
- svg/SVGFEImageElement.h:
- svg/SVGFontFaceUriElement.h:
- svg/SVGImageLoader.cpp:
- svg/SVGUseElement.cpp:
- svg/SVGUseElement.h:
- svg/graphics/SVGImageCache.cpp:
- testing/MockPagePopupDriver.cpp:
- xml/XSLStyleSheet.h:
- xml/XSLTProcessorLibxslt.cpp:
- xml/parser/XMLDocumentParser.cpp:
- xml/parser/XMLDocumentParser.h:
- xml/parser/XMLDocumentParserLibxml2.cpp: Many self-evident changes - removing unnecessary header includes, adding smaller more local ones that are now necessary.
- 10:14 PM Changeset in webkit [144529] by
-
- 4 edits6 adds in trunk
[New Multicolumn] Transformed objects inside fragmented transparent objects don't render
https://bugs.webkit.org/show_bug.cgi?id=111221.
Reviewed by Simon Fraser.
Source/WebCore:
Improve transparencyClipBox so that it understands when moving into descendants
that it does in fact have to break up the transformed clip rect across the
fragments.
Make sure when handling fragmented transforms using multiple paints that
the test that determines the extent of the transform within the fragments
uses transparencyClipBox. This gives us an accurate set of columns that the
final transformed result will paint across.
Tests: fast/multicol/mixed-opacity-fixed-test.html
fast/multicol/mixed-opacity-test.html
fast/multicol/transform-inside-opacity.html
- rendering/RenderLayer.cpp:
(WebCore::transparencyClipBox):
(WebCore::expandClipRectForDescendantsAndReflection):
Break transformed boxes up into fragments when they are
being requested by an ancestor.
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
- rendering/RenderLayer.h:
(RenderLayer):
Modify collectFragments so that we pass in the correct range
within the columns that can possibly cover the fragmented
transformed box.
LayoutTests:
- fast/multicol/mixed-opacity-fixed-test-expected.html: Added.
- fast/multicol/mixed-opacity-fixed-test.html: Added.
- fast/multicol/mixed-opacity-test-expected.html: Added.
- fast/multicol/mixed-opacity-test.html: Added.
- fast/multicol/transform-inside-opacity-expected.html: Added.
- fast/multicol/transform-inside-opacity.html: Added.
- 9:53 PM Changeset in webkit [144528] by
-
- 2 edits in trunk/Source/WebKit2
Remove call to set task priority of WebKit2 processes on Mac
https://bugs.webkit.org/show_bug.cgi?id=111239
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-03-01
Reviewed by Darin Adler.
Remove call to set task prioirty of WebKit2 processes on Mac as it
is no longer necessary.
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::platformInitialize): Remove call to setpriority().
- 9:23 PM Changeset in webkit [144527] by
-
- 11 edits in trunk
Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
https://bugs.webkit.org/show_bug.cgi?id=110943
Reviewed by Yury Semikhatsky.
Unfortunately in many cases raw pointer may point to an object that has been deleted.
There is no working solution to solve this problem in general.
It could be solved only on case by case basis.
Source/WebCore:
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportLeaf):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::reportMemoryUsage):
- platform/graphics/BitmapImage.cpp:
(WebCore::FrameData::reportMemoryUsage):
- platform/graphics/skia/MemoryInstrumentationSkia.cpp:
(reportMemoryUsage):
Source/WTF:
- wtf/MemoryInstrumentation.h:
(WTF::MemoryInstrumentation::addObject):
(WTF::MemoryInstrumentation::MemberTypeTraits::addObject):
(WTF::MemoryClassInfo::addMember):
(WTF::MemoryInstrumentation::addObjectImpl):
- wtf/MemoryInstrumentationString.h:
(WTF::reportMemoryUsage):
Tools:
- TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
- TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
(TestWebKitAPI::TEST):
- 9:18 PM Changeset in webkit [144526] by
-
- 9 edits2 adds in trunk
Style recalculation takes too long when adding whitespace text nodes
https://bugs.webkit.org/show_bug.cgi?id=110786
Reviewed by Darin Adler.
Source/WebCore:
This takes 216 msec.
for (var i = 0; i < 1500; ++i) {
document.body.appendChild(document.createTextNode('x'));
document.body.appendChild(document.createElement('div'));
document.body.appendChild(document.createTextNode('x'));
}
But this takes 25.3 seconds.
for (var i = 0; i < 1500; ++i) {
document.body.appendChild(document.createTextNode(' '));
document.body.appendChild(document.createElement('div'));
document.body.appendChild(document.createTextNode(' '));
}
The reason is that we do not create renderers for empty text
nodes and thus we are hitting the worst O(N2) case in Node::attach().
(See FIXME in Node::attach().)
This patch adds a logic to bail out the loop to avoid the O(N2) case.
Specifically, the patch bails out the loop if we encounter a text node
for which we again decided not to create a renderer. This bail out is
reasonable because the fact that we again decided not to create a renderer
for the text node indicates that there will be no affect of the result
of Text::textRendererIsNeeded() of the rest of the sibling nodes.
Performance test: https://bugs.webkit.org/attachment.cgi?id=190545
Performance result in Chromium/Linux: 25.3 sec => 48 msec !
Test: perf/append-text-nodes-without-renderers.html (for performance)
fast/dynamic/create-renderer-for-whitespace-only-text.html (for correctness)
The loop was introduced in r29054. We have to make sure that
all layout tests that were updated in r29054 pass with this patch.
See http://trac.webkit.org/changeset/29054.
- dom/Node.cpp:
(WebCore::Node::attach):
LayoutTests:
- fast/html/details-nested-2-expected.txt: Sometimes anonymous blocks are left without
being cleaned up (for some reason). With this patch, one anonymouse block is removed at
the clean-up phase (for some reason). Anyway the new behavior is an expected behavior.
- platform/chromium-mac/fast/html/details-nested-2-expected.txt: Ditto.
- platform/chromium-win/fast/html/details-nested-2-expected.txt: Ditto.
- platform/efl/fast/html/details-nested-2-expected.txt: Ditto.
- platform/mac/fast/html/details-nested-2-expected.txt: Ditto.
- platform/qt/fast/html/details-nested-2-expected.txt: Ditto.
- perf/append-text-nodes-without-renderers-expected.txt: Added. For performance test.
- perf/append-text-nodes-without-renderers.html: Added. Ditto.
- 9:17 PM Changeset in webkit [144525] by
-
- 2 edits in trunk/Source/WebKit/win
Add a missing symbol after r144524.
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-01
- WebKit.vcproj/WebKitExports.def.in:
- 9:06 PM Changeset in webkit [144524] by
-
- 40 edits in trunk
Source/WebCore: Moved markerTextForListItem from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=110939
Patch by Jason Anderssen <janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.
TestRunner framework is an old way of testing webkit, it would be
better to incorporate the testing frame directly into the WebCore itself
as to make it more compatible with WK2.
- testing/Internals.cpp:
(WebCore::Internals::markerTextForListItem):
(WebCore):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/efl: Move markerTextForListItem from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=110939
Patch by Jason Anderssen <janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/gtk: Move markerTextForListItem from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=110939
Patch by Jason Anderssen <janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/mac: Move markerTextForListItem from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=110939
Patch by Jason Anderssen <janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.
- DOM/WebDOMOperations.mm:
- DOM/WebDOMOperationsPrivate.h:
Source/WebKit/qt: Move markerTextForListItem from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=110939
Patch by Jason Anderssen <janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Tools: Move markerTextForListItem from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=110939
Patch by Jason Anderssen <janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h:
(TestRunner):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
- DumpRenderTree/mac/TestRunnerMac.mm:
- DumpRenderTree/qt/TestRunnerQt.cpp:
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
- DumpRenderTree/win/TestRunnerWin.cpp:
- DumpRenderTree/wx/TestRunnerWx.cpp:
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
LayoutTests: Move markerTextForListItem from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=110939
Patch by Jason Anderssen <janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.
- fast/lists/resources/dump-list.js:
(dumpListItemAsHTML):
(testListItemMarkerEqualsListItemText):
- fast/lists/w3-css3-list-styles-numeric.html:
- 7:44 PM Changeset in webkit [144523] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r185662. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-01
- DEPS:
- 6:35 PM Changeset in webkit [144522] by
-
- 6 edits1 add in trunk
Don't leak Documents when using MutationObserver from extensions
https://bugs.webkit.org/show_bug.cgi?id=111234
Patch by Elliott Sprehn <Elliott Sprehn> on 2013-03-01
Reviewed by Adam Barth.
.:
- ManualTests/leak-observer-nonmain-world.html: Added.
Source/WebCore:
MutationObserverCallback holds a WorldContextHandle which secretly isn't
a handle to anything when it's for the main world. When it's for a non-main
world though, like those used in extensions, it becomes a strong reference
to the v8::Context which results in leaks by creating cycles:
MutationObserver -> Callback -> World -> Document -> Node -> MutationObserver.
Instead we should keep a RefPtr to a DOMWrapperWorld in the callback and then
get the v8::Context from that inside handleEvent.
Tests: ManualTests/leak-observer-nonmain-world.html
- bindings/v8/V8Binding.cpp:
(WebCore::toV8Context): Added overload that takes a DOMWrapperWorld.
- bindings/v8/V8Binding.h:
- bindings/v8/V8MutationCallback.cpp:
(WebCore::V8MutationCallback::V8MutationCallback):
(WebCore::V8MutationCallback::handleEvent):
- bindings/v8/V8MutationCallback.h:
(V8MutationCallback):
- 5:31 PM Changeset in webkit [144521] by
-
- 2 edits in trunk/Source/JavaScriptCore
BUILD FIX: testapi should link to Foundation, not CoreFoundation
- JavaScriptCore.xcodeproj/project.pbxproj: Change testapi to
link to Foundation.framework instead of CoreFoundation.framework
since it uses NS types.
- 5:16 PM Changeset in webkit [144520] by
-
- 6 edits in trunk/Source/WebCore
[css exclusions] Move ExclusionShapeInsideInfo into RenderBlockRareData
https://bugs.webkit.org/show_bug.cgi?id=110995
Reviewed by Julien Chaffraix.
This patch moves ExclusionShapeInsideInfo into the RenderBlockRareData struct,
which enables us to move away from the global ExclusionShapeInsideInfo map.
Some additional refactoring was done to remove ExclusionShapeInsideInfo's
dependency on InlineIterator, which depended on RenderBlock. This work required
adding a new LineSegmentIterator struct.
Refactoring, no new tests.
- rendering/ExclusionShapeInsideInfo.cpp:
(WebCore):
(WebCore::LineSegmentRange::LineSegmentRange): Moving the InlineIterator
constructor to the .cpp file, as InlineIterator is now forward declared in
the .h file.
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Moving isEnabledFor to
the .cpp file, as RenderBlock is now forward declared in the .h file.
- rendering/ExclusionShapeInsideInfo.h:
(WebCore):
(LineSegmentIterator): A simple struct for containing segment positions for
layout.
(WebCore::LineSegmentIterator::LineSegmentIterator): Constructor.
(LineSegmentRange): Transitioning to store LineSegmentIterator.
(WebCore::LineSegmentRange::LineSegmentRange): Ditto.
(ExclusionShapeInsideInfo):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed): Destroying a block will now destroy
its ExclusionShapeInsideInfo, so there is no need to remove it from the map.
(WebCore):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): Use
the RenderBlockRareData struct rather than the global map.
- rendering/RenderBlock.h:
(WebCore):
(WebCore::RenderBlock::ensureExclusionShapeInsideInfo): Ensure an info struct
is present if the shape-inside style is set.
(WebCore::RenderBlock::exclusionShapeInsideInfo): Look up the info struct for
the current block.
(WebCore::RenderBlock::setExclusionShapeInsideInfo): Update the info struct
for the current block.
(RenderBlockRareData): Add the ExclusionShapeInsideInfo member.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::constructBidiRunsForLine): Construct the appropriate offsets during
layout based on the stored LineSegmentIterators.
- 5:08 PM Changeset in webkit [144519] by
-
- 15 edits4 copies8 adds in trunk
EventHandler::handleGestureScrollUpdate() should invoke the user-generated scroll routines
so its behavior matches other user-initiated scrolls
https://bugs.webkit.org/show_bug.cgi?id=109769
Reviewed by James Robinson.
Source/WebCore:
To ensure that the scrolling behavior of GestureScrollUpdate events are consistent with
the scrolling behavior of mousewheel events, use the existing user-generated scroll logic
instead of calling into RenderLayer::scrollByRecursively(). This patch fixes the bug
reported in https://bugs.webkit.org/show_bug.cgi?id=109316, where the example page can
be scrolled using touch but cannot be scrolled using mousewheels.
Note that this patch does not use any of the mousewheel event-handling code.
Tests: fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html
fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html
fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html
fast/events/touch/gesture/touch-gesture-noscroll-body.html
- page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureScrollBegin):
(WebCore::EventHandler::handleGestureScrollUpdate):
(WebCore::EventHandler::sendScrollEventToView):
By calling this function at the start of handleGestureScrollUpdate() in the case
where |m_scrollGestureHandlingNode| is null, we ensure that the scroll updates
can still scroll the page itself, if possible.
(WebCore):
(WebCore::EventHandler::clearGestureScrollNodes):
- page/EventHandler.h:
(EventHandler):
- platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::setHasPreciseScrollingDeltas):
Source/WebKit/chromium:
Clear the nodes corresponding to a fling scroll event when the event ends.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::updateAnimations):
LayoutTests:
Four new layout tests have been added and touch-gesture-scroll-page.html has been
modified to demonstrate that this patch fixes two existing bugs. See the inline
comments below for details.
Because I am now using the existing user-generated scroll logic, the delta for a single
GestureScrollUpdate event will not be propagated to the parent of the targeted node
unless the targeted node has no remaining scrollable area. So the changes to the
existing layout tests have been made to ensure that the targeted node has been fully
scrolled before subsequent GestureScrollUpdate events will scroll the parent(s) of
the targeted node.
I have also removed the function recordScroll() from the existing layout tests
because this function already exists in the included file resources/gesture-helpers.js.
- fast/events/touch/gesture/touch-gesture-noscroll-body-expected.txt: Added.
- fast/events/touch/gesture/touch-gesture-noscroll-body-propagated-expected.txt: Added.
- fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
- fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden-expected.txt: Added.
- fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
- fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt: Added.
- fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
- fast/events/touch/gesture/touch-gesture-noscroll-body.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
- fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html:
- fast/events/touch/gesture/touch-gesture-scroll-div-propagated.html:
- fast/events/touch/gesture/touch-gesture-scroll-div-twice-propagated.html:
- fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html:
- fast/events/touch/gesture/touch-gesture-scroll-iframe-propagated.html:
- fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html:
- fast/events/touch/gesture/touch-gesture-scroll-page-propagated.html:
- fast/events/touch/gesture/touch-gesture-scroll-page.html:
I modified this layout test in order to add test coverage for another bug
which is fixed by this patch: if the hit test performed on a GestureScrollBegin
does not target a specific node, the subsequent GestureScrollUpdate events should
still attempt to scroll the page itself. This is consistent with how mousewheel
events behave.
- platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-expected.txt: Added.
- platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-propagated-expected.txt: Added.
- platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden-expected.txt: Added.
- platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt: Added.
These four new layout tests verify that a non-scrollable body will not scroll,
as reported in https://bugs.webkit.org/show_bug.cgi?id=109316.
- 5:05 PM Changeset in webkit [144518] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Revert r143827 to restore WebHelperPluginImpl's call to frameDetached()
https://bugs.webkit.org/show_bug.cgi?id=111232
Patch by David Dorwin <ddorwin@chromium.org> on 2013-03-01
Reviewed by Adam Barth.
This patch reverts r143827, which causes a crash in failure conditions:
http://crbug.com/178848
- src/WebHelperPluginImpl.cpp:
(WebKit::WebHelperPluginImpl::destoryPage):
- 5:04 PM Changeset in webkit [144517] by
-
- 4 edits in trunk/Source/WebCore
IndexedDB: Avoid ScriptValue copies in IDBAny
https://bugs.webkit.org/show_bug.cgi?id=111002
Reviewed by Adam Barth.
This avoids some v8 handle thrashing in the long term,
and protects us against some crashes in the short term.
The crashes will be fixed in
https://bugs.webkit.org/show_bug.cgi?id=110206.
- Modules/indexeddb/IDBAny.cpp:
(WebCore::IDBAny::createNull):
(WebCore::IDBAny::createString):
(WebCore::IDBAny::IDBAny):
(WebCore::IDBAny::scriptValue):
- Modules/indexeddb/IDBAny.h:
(WebCore::IDBAny::create):
(IDBAny):
(WebCore::IDBAny::keyPath):
- bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
(WebCore):
- 5:01 PM Changeset in webkit [144516] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening of AppleWin port.
- platform/win/TestExpectations:
- 5:00 PM Changeset in webkit [144515] by
-
- 7 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Upstream smart selection
https://bugs.webkit.org/show_bug.cgi?id=111226
Patch by Iris Wu <shuwu@rim.com> on 2013-03-01
Reviewed by Rob Buis.
- Extend the touch hold text selection to next paragraph.
- Draw and expand overlay over text as touch hold selection expands.
Select paragraph when it's entirely covered by overlay.
- Start scrolling at a constant rate when the end of
next pargraph is not in the viewport.
Reviewed Internally By Genevieve Mak and Mike Fenton.
PR 217897 238485 258279 279042 299779
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::selectAtDocumentPoint):
(BlackBerry::WebKit::WebPage::expandSelection):
(WebKit):
(BlackBerry::WebKit::WebPage::setOverlayExpansionPixelHeight):
(BlackBerry::WebKit::WebPagePrivate::setOverlayExpansionPixelHeight):
(BlackBerry::WebKit::WebPage::setParagraphExpansionPixelScrollMargin):
- Api/WebPage.h:
- Api/WebPageClient.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::cancelSelection):
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
(BlackBerry::WebKit::isInvalidLine):
(WebKit):
(BlackBerry::WebKit::isInvalidParagraph):
(BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
(BlackBerry::WebKit::SelectionHandler::drawOverlay):
(BlackBerry::WebKit::SelectionHandler::findNextOverlayRegion):
(BlackBerry::WebKit::SelectionHandler::expandSelection):
(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
(BlackBerry::WebKit::SelectionHandler::setParagraphExpansionScrollMargin):
(BlackBerry::WebKit::SelectionHandler::expandSelectionToGranularity):
- WebKitSupport/SelectionHandler.h:
(SelectionHandler):
(BlackBerry::WebKit::SelectionHandler::setOverlayExpansionHeight):
- 4:55 PM Changeset in webkit [144514] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening of AppleWin port.
- platform/win/TestExpectations:
- 3:46 PM Changeset in webkit [144513] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening of AppleWin port.
- platform/win/TestExpectations:
- 3:22 PM Changeset in webkit [144512] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark some software compositing tests as failing before landing anti-aliasing changes
https://bugs.webkit.org/show_bug.cgi?id=111224
- platform/chromium/TestExpectations:
- 3:05 PM Changeset in webkit [144511] by
-
- 14 edits in branches/safari-536.29-branch
Merge 143988
2013-02-25 Anders Carlsson <andersca@apple.com>
Source/WebKit2:
Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
https://bugs.webkit.org/show_bug.cgi?id=110821
Reviewed by Beth Dakin.
- UIProcess/API/C/WKPage.cpp: (WKPageGetPluginInformationPluginspageAttributeURLKey): (WKPageGetPluginInformationPluginURLKey): Add two new API key getters.
- UIProcess/API/C/WKPage.h: Add a new callback and deprecate the old callback.
- UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didFailToInitializePlugin): (WebKit::WebLoaderClient::didBlockInsecurePluginVersion): (WebKit::WebLoaderClient::pluginLoadPolicy): Make the pluginInformationDictionary a static member function of WebPageProxy so it can be called from WebUIClient as well.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): Pass the bundle version as well.
(WebKit::WebPageProxy::pluginInformationPluginspageAttributeURLKey):
(WebKit::WebPageProxy::pluginInformationPluginURLKey):
Add two new keys.
(WebKit::WebPageProxy::pluginInformationDictionary):
Handle more keys.
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
Get the plug-in bundle identifier and version.
- UIProcess/WebPageProxy.messages.in: Pass along more information; the frame and page URLs.
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::unavailablePluginButtonClicked): Call the new callback if it's supported.
- UIProcess/WebUIClient.h: (WebUIClient):
- UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage): Update for API changes.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::unavailablePluginButtonClicked): Ensure that the pluginspage attribute is a valid URL.
Tools:
Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
https://bugs.webkit.org/show_bug.cgi?id=110821
<rdar://problem/13265303>
Reviewed by Beth Dakin.
Update for WebKit2 changes.
- MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): (WTR::TestController::unavailablePluginButtonClicked):
- WebKitTestRunner/TestController.h: (TestController):
- 2:55 PM Changeset in webkit [144510] by
-
- 4 edits in trunk/Tools
Don't use legacy test names when returning results from PerfTest.run
https://bugs.webkit.org/show_bug.cgi?id=111148
Reviewed by Dirk Pranke.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTestMetric.name): Renamed from metric.
(PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
(PerfTest.run): Use metric name instead of the legacy name to store iteration values.
(ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTestMetric.test_init_set_time_metric):
(TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
(TestReplayPerfTest.test_run_with_driver_accumulates_results):
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.init):
(PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
to obtain the trac URL instead of hard coding it.
(PerfTestsRunner._run_tests_set):
- 2:53 PM Changeset in webkit [144509] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark more flaky tests related to scrollbar ordering
https://bugs.webkit.org/show_bug.cgi?id=111199
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 2:42 PM Changeset in webkit [144508] by
-
- 4 edits2 adds in trunk
Support padding, margin and border for internal UA cue styling
https://bugs.webkit.org/show_bug.cgi?id=110703
Reviewed by Eric Carlson.
Source/WebCore:
For some particular user agent styling this allows the possibility
of making the window around the cue text bigger to match some user
styles (see CaptionUserPreferencesMac::captionsStyleSheetOverride).
These properties *cannot* be set through by using the ::cue
pseudo-element and, as specified, are used only internally.
Note: This patch is identical to the previously commited one,
as it was rolled back without related tests failing.
Test: media/track/track-cue-rendering-with-padding.html
- css/mediaControls.css:
(video::-webkit-media-text-track-display): Set the CSS box model
to include in the specified width or height the values of
padding / margin / border by using -webkit-box-sizing and avoid
overflow over 100% width because of having these properties set.
- rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::isOutside): To not interfere with
the regular WebVTT positioning algorithm, the check is done for
the absolute content box.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Added
an extra adjustment step to accomodate vertical padding (and not
overflow the cue container)
LayoutTests:
- media/track/track-cue-rendering-with-padding-expected.txt: Added.
- media/track/track-cue-rendering-with-padding.html: Added.
- 2:39 PM Changeset in webkit [144507] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r125809): CFStrings created via StringImpl::createCFString() might reference freed memory when Objective-C garbage collection is enabled
https://bugs.webkit.org/show_bug.cgi?id=111219
Reviewed by Benjamin Poulain.
StringImpl::createCFString() uses CFStringCreateWithBytesNoCopy() in
order to create CFString without making an unnecessary copy. In order
to ensure that the the StringImpl's backing buffer isn't deallocated
while the CFString is still alive, we use a custom CFAllocator to
ref/deref the StringImpl at the appropriate times.
However, custom allocators aren't supported when Objective-C garbage
collection is enabled, so in this case we use the default CF allocator.
Since we can't guarantee the lifetime of the StringImpl in this case,
we should just fall back to copying the string, as we did prior to r125809.
- platform/text/cf/StringImplCF.cpp:
(garbageCollectionEnabled): Moved the check for whether garbage
collection is enabled from StringWrapperCFAllocator::create() to here.
(WTF::StringWrapperCFAllocator::create): Call garbageCollectionEnabled().
(WTF::StringImpl::createCFString): If garbage collection is enabled,
call the variants of CFStringCreate that copy the string.
- 2:38 PM Changeset in webkit [144506] by
-
- 4 edits in trunk/Source/WebKit/gtk
[GTK] Expose more of the configuration step to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=111213
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-01
Reviewed by Dirk Pranke.
Expose more of the configuration phase to the gyp build, including WebKit features
and binary paths.
- gyp/Configuration.gypi.in: Add templatized gyp variables for the new configuration bits.
- gyp/autogen.sh: Properly link up the WebKit features script. So we can access it
relatively as if we were at the top-level of the source directory.
- gyp/configure.ac: Export the WebKit features.
- 2:26 PM Changeset in webkit [144505] by
-
- 13 edits in branches/safari-536.29-branch
Merge 143976
2013-02-25 Anders Carlsson <andersca@apple.com>
Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
https://bugs.webkit.org/show_bug.cgi?id=110793
<rdar://problem/13265303>
Reviewed by Sam Weinig.
Source/WebKit2:
Add a new pluginDidFail callback that takes a WKDictionaryRef and also pass in the
frame and page URLs.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp: (WebKit::pluginInformationDictionary): (WebKit::WebLoaderClient::didFailToInitializePlugin): (WebKit::WebLoaderClient::didBlockInsecurePluginVersion): (WebKit::WebLoaderClient::pluginLoadPolicy):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFailToInitializePlugin): (WebKit::WebPageProxy::didBlockInsecurePluginVersion):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::didFailToInitializePlugin):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin):
Tools:
Update for WebKit2 API changes.
- MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createWebViewWithOptions):
- 2:22 PM Changeset in webkit [144504] by
-
- 1 edit68 adds in trunk/LayoutTests
AX: Upstream iOS Accessibility layout tests
https://bugs.webkit.org/show_bug.cgi?id=111187
Reviewed by David Kilzer.
Upstream the latest iOS Accessibility layout tests.
- platform/iphone-simulator: Added.
- platform/iphone-simulator/accessibility: Added.
- platform/iphone-simulator/accessibility/accessibility-aria-table-children-expected.txt: Added.
- platform/iphone-simulator/accessibility/accessibility-aria-table-children.html: Added.
- platform/iphone-simulator/accessibility/accessibility-crash-in-axcontainer-expected.txt: Added.
- platform/iphone-simulator/accessibility/accessibility-crash-in-axcontainer.html: Added.
- platform/iphone-simulator/accessibility/accessibility-hint-expected.txt: Added.
- platform/iphone-simulator/accessibility/accessibility-hint.html: Added.
- platform/iphone-simulator/accessibility/aria-pressed-state-expected.txt: Added.
- platform/iphone-simulator/accessibility/aria-pressed-state.html: Added.
- platform/iphone-simulator/accessibility/centerpoint-expected.txt: Added.
- platform/iphone-simulator/accessibility/centerpoint.html: Added.
- platform/iphone-simulator/accessibility/dom-focus-fires-on-correct-element-expected.txt: Added.
- platform/iphone-simulator/accessibility/dom-focus-fires-on-correct-element.html: Added.
- platform/iphone-simulator/accessibility/focus-change-notifications-expected.txt: Added.
- platform/iphone-simulator/accessibility/focus-change-notifications.html: Added.
- platform/iphone-simulator/accessibility/header-elements-expected.txt: Added.
- platform/iphone-simulator/accessibility/header-elements.html: Added.
- platform/iphone-simulator/accessibility/identifier-expected.txt: Added.
- platform/iphone-simulator/accessibility/identifier.html: Added.
- platform/iphone-simulator/accessibility/internal-link-expected.txt: Added.
- platform/iphone-simulator/accessibility/internal-link.html: Added.
- platform/iphone-simulator/accessibility/link-with-images-text-expected.txt: Added.
- platform/iphone-simulator/accessibility/link-with-images-text.html: Added.
- platform/iphone-simulator/accessibility/link-with-only-image-expected.txt: Added.
- platform/iphone-simulator/accessibility/link-with-only-image.html: Added.
- platform/iphone-simulator/accessibility/math-expected.txt: Added.
- platform/iphone-simulator/accessibility/math.html: Added.
- platform/iphone-simulator/accessibility/mixed-checkboxes-expected.txt: Added.
- platform/iphone-simulator/accessibility/mixed-checkboxes.html: Added.
- platform/iphone-simulator/accessibility/no-child-link-header-expected.txt: Added.
- platform/iphone-simulator/accessibility/no-child-link-header.html: Added.
- platform/iphone-simulator/accessibility/non-contiguous-link-expected.txt: Added.
- platform/iphone-simulator/accessibility/non-contiguous-link.html: Added.
- platform/iphone-simulator/accessibility/password-value-expected.txt: Added.
- platform/iphone-simulator/accessibility/password-value.html: Added.
- platform/iphone-simulator/accessibility/placeholder-value-expected.txt: Added.
- platform/iphone-simulator/accessibility/placeholder-value.html: Added.
- platform/iphone-simulator/accessibility/popup-button-value-label-expected.txt: Added.
- platform/iphone-simulator/accessibility/popup-button-value-label.html: Added.
- platform/iphone-simulator/accessibility/radio-button-expected.txt: Added.
- platform/iphone-simulator/accessibility/radio-button.html: Added.
- platform/iphone-simulator/accessibility/secure-text-field-expected.txt: Added.
- platform/iphone-simulator/accessibility/secure-text-field.html: Added.
- platform/iphone-simulator/accessibility/selected-buttons-expected.txt: Added.
- platform/iphone-simulator/accessibility/selected-buttons.html: Added.
- platform/iphone-simulator/accessibility/selected-text-expected.txt: Added.
- platform/iphone-simulator/accessibility/selected-text.html: Added.
- platform/iphone-simulator/accessibility/tab-role-expected.txt: Added.
- platform/iphone-simulator/accessibility/tab-role.html: Added.
- platform/iphone-simulator/accessibility/table-cell-for-row-col-expected.txt: Added.
- platform/iphone-simulator/accessibility/table-cell-for-row-col.html: Added.
- platform/iphone-simulator/accessibility/table-cell-ranges-expected.txt: Added.
- platform/iphone-simulator/accessibility/table-cell-ranges.html: Added.
- platform/iphone-simulator/accessibility/tables-lists-expected.txt: Added.
- platform/iphone-simulator/accessibility/tables-lists.html: Added.
- platform/iphone-simulator/accessibility/text-line-no-ignored-elements-expected.txt: Added.
- platform/iphone-simulator/accessibility/text-line-no-ignored-elements.html: Added.
- platform/iphone-simulator/accessibility/text-marker-list-item-expected.txt: Added.
- platform/iphone-simulator/accessibility/text-marker-list-item.html: Added.
- platform/iphone-simulator/accessibility/text-marker-validation-expected.txt: Added.
- platform/iphone-simulator/accessibility/text-marker-validation.html: Added.
- platform/iphone-simulator/accessibility/text-role-expected.txt: Added.
- platform/iphone-simulator/accessibility/text-role.html: Added.
- platform/iphone-simulator/accessibility/textfield-in-axvalue-expected.txt: Added.
- platform/iphone-simulator/accessibility/textfield-in-axvalue.html: Added.
- platform/iphone-simulator/accessibility/url-test-expected.txt: Added.
- platform/iphone-simulator/accessibility/url-test.html: Added.
- 2:14 PM Changeset in webkit [144503] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed AppleWin build fix.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):
- 2:03 PM Changeset in webkit [144502] by
-
- 2 edits1 add in trunk/Source/WebCore
[GTK] Allow sharing the WebCore include list with the Chromium build
https://bugs.webkit.org/show_bug.cgi?id=110241
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-01
Reviewed by Dirk Pranke.
- WebCore.gyp/WebCoreGTK.gyp: Added. A skeleton gyp file for WebCoreGTK+.
- WebCore.gypi: Added shared include directories.
- 2:02 PM Changeset in webkit [144501] by
-
- 11 edits in branches/safari-536.29-branch/Source
Merge 143815
2013-02-22 Anders Carlsson <andersca@apple.com>
pluginLoadStrategy should take a WKDictionaryRef for extensibility
https://bugs.webkit.org/show_bug.cgi?id=110656
<rdar://problem/13265303>
Reviewed by Jessie Berlin.
Source/WebCore:
Export a symbol needed by WebKit2.
- WebCore.exp.in:
Source/WebKit2:
Change pluginLoadStrategy to take a WKDictionaryRef instead of a number of parameters;
this lets us add more plug-in information if needed. Also add the page URL and rename documentURL to frameURL.
- UIProcess/API/C/WKPage.cpp: (WKPageGetPluginInformationBundleIdentifierKey): (WKPageGetPluginInformationBundleVersionKey): (WKPageGetPluginInformationDisplayNameKey): (WKPageGetPluginInformationFrameURLKey): (WKPageGetPluginInformationMIMETypeKey): (WKPageGetPluginInformationPageURLKey):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp: (WebKit): (WebKit::WebLoaderClient::pluginLoadPolicy):
- UIProcess/WebLoaderClient.h: (WebLoaderClient):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): (WebKit::WebPageProxy::pluginInformationBundleIdentifierKey): (WebKit): (WebKit::WebPageProxy::pluginInformationBundleVersionKey): (WebKit::WebPageProxy::pluginInformationDisplayNameKey): (WebKit::WebPageProxy::pluginInformationFrameURLKey): (WebKit::WebPageProxy::pluginInformationMIMETypeKey): (WebKit::WebPageProxy::pluginInformationPageURLKey):
- UIProcess/WebPageProxy.h: (WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): (WebKit::WebPage::canPluginHandleResponse):
- 2:02 PM Changeset in webkit [144500] by
-
- 1 edit5 adds in trunk/Tools
Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
https://bugs.webkit.org/show_bug.cgi?id=111202
This is useful for running VCExpress builds from command line because there is
no unified solution output, only per project build logs.
The project will be run as the last project in the solution.
- win/AssembleBuildLogs: Added.
- win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
- win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
- win/AssembleBuildLogs/AssembleLogs.cmd: Added.
- win/AssembleBuildLogs/README: Added.
- 2:00 PM Changeset in webkit [144499] by
-
- 11 edits8 adds in trunk/Source
Make in-memory blobs work in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=111132
Reviewed by Sam Weinig.
- NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::registerBlobURL): (WebKit::NetworkConnectionToWebProcess::registerBlobURLFromURL): (WebKit::NetworkConnectionToWebProcess::unregisterBlobURL):
- NetworkProcess/NetworkConnectionToWebProcess.h: Implement BlobRegistry interface by using BlobRegistryImpl (same one as used in WebProcess in non-PPT mode).
- NetworkProcess/NetworkConnectionToWebProcess.messages.in: Added three messages needed for BlobRegistry.
- NetworkProcess/NetworkProcess.cpp:
- NetworkProcess/NetworkProcessPlatformStrategies.cpp: Added.
- NetworkProcess/NetworkProcessPlatformStrategies.h: Added. Added a mostly empty platform strategy, just for FormData to talk to BlobRegistry. Perhaps we'll find a way to avoid this WebCore code path in NetworkProcess, because we obviously know which registry implementation is in use in this process.
- Shared/FileAPI: Added.
- Shared/FileAPI/BlobRegistrationData.cpp: Added.
- Shared/FileAPI/BlobRegistrationData.h: Added. Added a class for passing BlobData and extension handles over IPC. This uses a trick with mutable a member to avoid copying decoded BlobStorageData.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/FileAPI: Added.
- WebProcess/FileAPI/BlobRegistryProxy.cpp: Added.
- WebProcess/FileAPI/BlobRegistryProxy.h: Added. A proxy implementation of BlobRegistry that just sends requests over IPC. We only need async ones.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::createBlobRegistry):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h: Create an appropriate BlobRegistry.
- 1:53 PM Changeset in webkit [144498] by
-
- 19 edits in trunk/Source
Threaded HTML Parser has an extra copy of every byte from the network
https://bugs.webkit.org/show_bug.cgi?id=111135
Reviewed by Adam Barth.
Source/WebCore:
Every LayoutTest executes this code in threaded parsing mode.
- dom/DecodedDataDocumentParser.cpp:
(WebCore::DecodedDataDocumentParser::appendBytes):
- Pass ownership of the decoded string to the parser.
(WebCore::DecodedDataDocumentParser::flush):
- Same.
- dom/DecodedDataDocumentParser.h:
(DecodedDataDocumentParser):
- dom/Document.cpp:
(WebCore::Document::setContent):
- dom/DocumentParser.h:
(DocumentParser):
- dom/RawDataDocumentParser.h:
(WebCore::RawDataDocumentParser::append):
- html/FTPDirectoryDocument.cpp:
(FTPDirectoryDocumentParser):
(WebCore::FTPDirectoryDocumentParser::append):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::append):
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
- html/parser/HTMLViewSourceParser.cpp:
(WebCore::HTMLViewSourceParser::append):
- html/parser/HTMLViewSourceParser.h:
(HTMLViewSourceParser):
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::append):
- html/parser/TextDocumentParser.h:
(TextDocumentParser):
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::append):
- xml/parser/XMLDocumentParser.h:
(XMLDocumentParser):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::resumeParsing):
Source/WTF:
The threaded html parser needs to accept ownership
of a string buffer. The easiest way to do this seemed
to be to use a PassRefPtr<StringImpl>, but there was no way
to generated one from a String (easily), so I added one.
- wtf/text/WTFString.h:
(WTF::String::releaseImpl):
- 1:44 PM Changeset in webkit [144497] by
-
- 21 edits2 adds in trunk
[New Multicolumn] Change inRenderFlowThread to follow containing block chain
https://bugs.webkit.org/show_bug.cgi?id=111206
Reviewed by Simon Fraser.
Source/WebCore:
This patch removes inRenderFlowThread and changes enclosingRenderFlowThread()
to flowThreadContainingBlock(). flowThreadContainingBlock() now follows
the containing block chain instead of the parent chain when outside of layout.
(It already did the right thing when called during layout.)
By removing inRenderFlowThread (which was following the parent chain), all
code that is checking for flow thread containment now correctly uses the
containing block chain. This allows for content to escape in-flow flow threads
and do the right thing without asserting.
Test: fast/multicol/positioned-outside-of-columns.html
- dom/WebKitNamedFlow.cpp:
(WebCore::inFlowThread):
(WebCore::WebKitNamedFlow::getRegionsByContent):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeLeftoverAnonymousBlock):
(WebCore::RenderBlock::collapseAnonymousBoxChild):
(WebCore::RenderBlock::updateRegionsAndExclusionsLogicalSize):
(WebCore::RenderBlock::computeRegionRangeForBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::computeLogicalLocationForFloat):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::hasNextPage):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::pageLogicalTopForOffset):
(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
(WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage):
(WebCore::RenderBlock::regionAtBlockOffset):
(WebCore::RenderBlock::setStaticInlinePositionForChild):
(WebCore::RenderBlock::logicalWidthChangedInRegions):
(WebCore::RenderBlock::clampToStartAndEndRegions):
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::layoutExclusionShapeInsideInfo):
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::flowThread):
(WebCore::LineLayoutState::setFlowThread):
(LineLayoutState):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::clearRenderBoxRegionInfo):
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::objectInFlowRegion):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
- rendering/RenderLayer.cpp:
(WebCore::accumulateOffsetTowardsAncestor):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::canBeComposited):
- rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::locateFlowThreadContainingBlock):
(WebCore::RenderObject::containerForRepaint):
(WebCore::RenderObject::willBeRemovedFromTree):
(WebCore::RenderObject::removeFromRenderFlowThread):
(WebCore::RenderObject::removeFromRenderFlowThreadRecursive):
- rendering/RenderObject.h:
(RenderObject):
(WebCore::RenderObject::flowThreadContainingBlock):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setObjectStyleInRegion):
- rendering/RenderView.cpp:
(WebCore::RenderView::addChild):
(WebCore::RenderView::initializeLayoutState):
(WebCore::RenderView::setSelection):
- rendering/RenderView.h:
(WebCore::RenderView::pushLayoutState):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::containingRegion):
(WebCore::RootInlineBox::setContainingRegion):
LayoutTests:
- fast/multicol/positioned-outside-of-columns-expected.html: Added.
- fast/multicol/positioned-outside-of-columns.html: Added.
- 1:36 PM Changeset in webkit [144496] by
-
- 2 edits in trunk/Source/WebKit2
Uncomment ENABLE_SVG guards to avoid having WebKitPluginProcess link
against libWebCoreSVG.la when SVG is disabled.
Rubber-stamped by Gustavo Noronha.
- GNUmakefile.am:
- 1:32 PM Changeset in webkit [144495] by
-
- 15 edits in trunk/Source
Add SPI for marking a WebView as doing things on behalf of another process
https://bugs.webkit.org/show_bug.cgi?id=111125
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- platform/network/NetworkingContext.h:
(NetworkingContext):
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
Set the sourceApplicationAuditData on the URL connection if available.
Source/WebKit/mac:
- WebCoreSupport/WebFrameNetworkingContext.h:
(WebFrameNetworkingContext):
- WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::sourceApplicationAuditData):
- WebView/WebView.mm:
(-[WebView _setSourceApplicationAuditData:]):
(-[WebView _sourceApplicationAuditData]):
- WebView/WebViewData.h:
- WebView/WebViewData.mm:
(-[WebViewPrivate dealloc]):
- WebView/WebViewPrivate.h:
Add SPI for setting a source application for a WebView.
Source/WebKit2:
- NetworkProcess/mac/RemoteNetworkingContext.h:
- NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::sourceApplicationAuditData):
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::sourceApplicationAuditData):
Stub out sourceApplicationAuditData() client function.
- 1:31 PM Changeset in webkit [144494] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Screen went black while navigating back/forward on the reddit.com page
https://bugs.webkit.org/show_bug.cgi?id=111192
Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.
PR: 299783
When going back to the previous reddit.com page, the actual contents
size was much less than the history contents size. However, we expanded
the actual contents size to history contents size which caused a huge
black area below the actual contents.
To fix that, don't restore the contents size from history contents size
and scroll back to the valid contents area if we are about to overscroll.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- 1:26 PM Changeset in webkit [144493] by
-
- 2 edits in trunk/Tools
Unreviewed. Increase number of patches processed before clean building on WinEWS bots.
- EWSTools/start-queue-win.sh:
- 1:25 PM Changeset in webkit [144492] by
-
- 10 edits in branches/safari-536.29-branch
Merge r143790
2013-02-22 Anders Carlsson <andersca@apple.com>
Source/WebKit2:
Move pluginLoadPolicy to the page loader client
https://bugs.webkit.org/show_bug.cgi?id=110635
<rdar://problem/13265303>
Reviewed by Sam Weinig.
Move the pluginLoadPolicy callback to the page loader client where it belongs.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp: (WebKit::toWKPluginLoadPolicy): (WebKit): (WebKit::toPluginModuleLoadPolicy): (WebKit::WebLoaderClient::pluginLoadPolicy):
- UIProcess/WebLoaderClient.h: (WebLoaderClient):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
- UIProcess/WebUIClient.cpp: (WebKit):
- UIProcess/WebUIClient.h: (WebUIClient):
- UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage):
Tools:
Move pluginLoadPolicy to the page loader client
https://bugs.webkit.org/show_bug.cgi?id=110635
Reviewed by Sam Weinig.
- MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions):
- 1:18 PM Changeset in webkit [144491] by
-
- 3 edits in trunk/Source/WebCore
[Windows] Unreviewed VS2010 build fix.
- WebCore.vcxproj/WebCore.vcxproj: Add missing TimelineTraceEventProcessor files to the project.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- 1:18 PM Changeset in webkit [144490] by
-
- 1 edit3 adds in trunk/Source/ThirdParty/ANGLE
[GTK] Add ANGLE to the GTK+ gyp build
https://bugs.webkit.org/show_bug.cgi?id=111128
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-01
Reviewed by Dirk Pranke.
Add files that build an ANGLE static library for GTK+ using gyp.
- ANGLE.gyp/ANGLE.gyp: Added.
- ANGLE.gypi: Added.
- 1:14 PM Changeset in webkit [144489] by
-
- 5 edits2 deletes in trunk/Source/JavaScriptCore
Objective-C API: Passing JS functions to Objective-C callbacks causes JSValue to leak
https://bugs.webkit.org/show_bug.cgi?id=107836
Reviewed by Oliver Hunt.
We've decided to remove support for this feature from the API because there's no way to automatically manage
the memory for clients in a satisfactory manner. Clients can still pass JS functions to Objective-C methods,
but the methods must accept plain JSValues instead of Objective-C blocks.
We now ignore functions that are part of a protocol that inherits from JSExport that accept blocks as arguments.
- API/JSBlockAdaptor.h: Removed.
- API/JSBlockAdaptor.mm: Removed.
- API/ObjCCallbackFunction.mm:
(ArgumentTypeDelegate::typeBlock): Return nil to signal that we want to ignore this function when copying it
to the object from the protocol.
- API/tests/testapi.mm: Added a test to make sure that we ignore methods declared as part of a JSExport-ed protocol
that have block arguments.
(-[TestObject bogusCallback:]):
- JavaScriptCore.gypi: Updated build files.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 1:07 PM Changeset in webkit [144488] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Improve input bounds clipping for search fields.
https://bugs.webkit.org/show_bug.cgi?id=111204
Reviewed by Rob Buis.
PR 292673.
Use the standardized InputHandler function to get the
bounds of an input field so that search fields are
truncated smaller to account for the X.
Reviewed Internally by Gen Mak.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
- 1:02 PM Changeset in webkit [144487] by
-
- 7 edits2 adds in trunk
[css exclusions] setting shape-inside on a parent does not relayout child blocks' inline content
https://bugs.webkit.org/show_bug.cgi?id=108128
Reviewed by David Hyatt.
Source/WebCore:
Ensure that blocks lay out when their parent's shape-inside changes.
ExclusionShapeInsideInfo now stores an additional flag indicating whether
the shape has changed and its block's children require layout. Each block
can look up the flag via LayoutState to determine whether it needs to lay
out its children.
Test: fast/exclusions/shape-inside/shape-inside-dynamic-nested.html
- rendering/ExclusionShapeInfo.h:
(WebCore::ExclusionShapeInfo::shapeSizeDirty): Add a method to determine
if the shape has changed.
(ExclusionShapeInfo):
- rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::setNeedsLayout): Set the flag indicating
layout is necessary.
(WebCore::ExclusionShapeInsideInfo::needsLayout): Retrieve the layout flag.
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo): Initialize
the layout flag.
- rendering/RenderBlock.cpp:
(WebCore::exclusionInfoRequiresRelayout): Return true if the shape info should
cause a relayout. Also update the needsLayout flag on the ExclusionShapeInsideInfo.
(WebCore):
(WebCore::RenderBlock::updateRegionsAndExclusionsLogicalSize): Return a boolean
indicating whether regions or exclusions updates should cause a relayout.
(WebCore::RenderBlock::layoutBlock): Relayout children if the shape inside has
changed.
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Changing to be a
class method.
(WebCore::LineWidth::LineWidth): Changing to use class method.
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Ditto.
(WebCore::constructBidiRunsForLine): Ditto.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Ditto.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Ditto.
LayoutTests:
Test that setting and resetting shape-inside and shape-outside correctly lay out
content inside of child blocks.
- fast/exclusions/shape-inside/shape-inside-dynamic-nested-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-dynamic-nested.html: Added.
- 12:57 PM Changeset in webkit [144486] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG Branch(LogicalNot) peephole should not try to optimize and work-around the case where LogicalNot may be otherwise live
https://bugs.webkit.org/show_bug.cgi?id=111209
Reviewed by Oliver Hunt.
Even if it is then everything will work just fine. It's not necessary to check the ref count here.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- 12:49 PM Changeset in webkit [144485] by
-
- 3 edits2 adds in trunk
getComputedStyle not implemented for -webkit-column-rule shorthand
https://bugs.webkit.org/show_bug.cgi?id=111203
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-03-01
Reviewed by Alexis Menard.
Source/WebCore:
Implement getComputedStyle for -webkit-column-rule property.
Test: fast/css/getComputedStyle/getComputedStyle-column-rule.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
LayoutTests:
Add test to check getComputedStyle for -webkit-column-rule.
- fast/css/getComputedStyle/getComputedStyle-column-rule-expected.txt: Added.
- fast/css/getComputedStyle/getComputedStyle-column-rule.html: Added.
- 12:46 PM Changeset in webkit [144484] by
-
- 6 edits in trunk/Source/WebCore
REGRESSION(r144318) 1-7% perf. regression on SVG/SvgHitTesting
https://bugs.webkit.org/show_bug.cgi?id=111117
Make sure the allocated vector has a capacity of 1, since that is
far and away the most common case.
Reviewed by Andreas Kling.
- rendering/RenderFlowThread.h:
(WebCore):
- rendering/RenderLayer.h:
(WebCore):
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::collectLayerFragments):
- rendering/RenderMultiColumnSet.h:
- rendering/RenderRegion.h:
(WebCore):
(WebCore::RenderRegion::collectLayerFragments):
- 12:43 PM Changeset in webkit [144483] by
-
- 2 edits in trunk/Source/WebCore
Crash at WebCore::SharedBuffer::hasPlatformData writing an image to the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=111211.
<rdar://problem/8772758>
Reviewed by Ryosuke Niwa.
This is a speculative fix since we don't have a solid repro case.
Adding null check every time we build a SharedBuffer from an NSData
we have obtained manipulating data from the pasteboard.
- platform/mac/PasteboardMac.mm:
(WebCore::writeFileWrapperAsRTFDAttachment):
(WebCore::Pasteboard::writeImage):
- 12:42 PM Changeset in webkit [144482] by
-
- 4 edits2 adds in branches/safari-536.29-branch
Merge r142919
2013-02-14 Anders Carlsson <andersca@apple.com>
Add WKContextIsPlugInUpdateAvailable
https://bugs.webkit.org/show_bug.cgi?id=109862
<rdar://problem/13173140>
Reviewed by Sam Weinig.
Source/WebKit2:
- UIProcess/API/C/mac/WKContextPrivateMac.h:
- UIProcess/API/C/mac/WKContextPrivateMac.mm: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.cpp. (WKContextGetProcessSuppressionEnabled): (WKContextSetProcessSuppressionEnabled): (WKContextIsPlugInUpdateAvailable):
- WebKit2.xcodeproj/project.pbxproj:
WebKitLibraries:
Roll WebKitSystemInterface DEPS.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 12:40 PM Changeset in webkit [144481] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG CSE phase shouldn't rely on ref count of nodes, since it doesn't have to
https://bugs.webkit.org/show_bug.cgi?id=111205
Reviewed by Oliver Hunt.
I don't understand the intuition behind setLocalStoreElimination() validating that the SetLocal's ref count
is 1. I believe this is a hold-over from when setLocalStoreElimination() would match one SetLocal to another,
and then try to eliminate the first SetLocal. But that's not how it works now. Now, setLocalStoreElimination()
is actually Flush elimination: it eliminates any Flush that anchors a SetLocal if it proves that every path
from the SetLocal to the Flush is devoid of operations that may observe the local. It doesn't actually kill
the SetLocal itself: if the SetLocal is live because of other things (other Flushes or GetLocals in other
basic blocks), then the SetLocal will naturally still be alive because th Flush was only keeping the SetLocal
alive by one count rather than being solely responsible for its liveness.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):
- 12:32 PM Changeset in webkit [144480] by
-
- 18 edits in tags/Safari-537.31.12/Source
Merged r144397. <rdar://problem/13291412>
- 12:26 PM Changeset in webkit [144479] by
-
- 2 edits in trunk/Source/WebCore
Crash at WebCore::SharedBuffer::hasPlatformData during paste.
https://bugs.webkit.org/show_bug.cgi?id=111207.
<rdar://problem/13024528>
Reviewed by Ryosuke Niwa.
This is a speculative fix since we don't have a solid repro case.
Adding null check every time we get a SharedBuffer from the pasteboard.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::plainText):
(WebCore::documentFragmentWithRTF):
- 12:04 PM Changeset in webkit [144478] by
-
- 5 edits in trunk/Tools
Don't return statistics in PerfTest.run
https://bugs.webkit.org/show_bug.cgi?id=111145
Reviewed by Dirk Pranke.
Simply return a list of values obtained in each iteration from PerfTest.run.
Also simplify various methods as needed.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTestMetric.init): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
as needed from PerfTestsRunner._generate_results_dict.
(PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
that we don't have to worry about the backward compatibility here.
(PerfTestMetric.iteration_values): Added.
(PerfTestMetric.unit): Added.
(PerfTestMetric.metric_to_unit):
(PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.
(PerfTest.run):
(PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTestMetric.test_init_set_missing_unit):
(TestPerfTestMetric.test_init_set_time_metric): Added.
(TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
(TestPerfTestMetric.test_append):
(TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
test cases and it's not critical to keep math right as they're not used in output JSON anymore.
(TestPerfTest._assert_results_are_correct):
(TestReplayPerfTest.test_run_with_driver_accumulates_results):
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_results_dict):
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
(SomeParserTestData): Ditto.
(MemoryTestData): Ditto.
- 11:51 AM Changeset in webkit [144477] by
-
- 4 edits in trunk/Source/JavaScriptCore
Rename MovHint to MovHintEvent so I can create a NodeType called MovHint
Rubber stamped by Mark Hahnenberg.
This is similar to the SetLocal/SetLocalEvent naming scheme, where SetLocal is the
NodeType and SetLocalEvent is the VariableEventKind.
- dfg/DFGVariableEvent.cpp:
(JSC::DFG::VariableEvent::dump):
- dfg/DFGVariableEvent.h:
(JSC::DFG::VariableEvent::movHint):
(JSC::DFG::VariableEvent::id):
(JSC::DFG::VariableEvent::operand):
(VariableEvent):
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
- 11:23 AM Changeset in webkit [144476] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark rtl-iframe-absolute-overflow-scrolled as flaky.
https://bugs.webkit.org/show_bug.cgi?id=111199
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 11:17 AM Changeset in webkit [144475] by
-
- 2 edits in trunk/Source/WebCore
Build fix for builds with BLOB disabled. This fixes it for me on Mac at least.
- platform/network/BlobRegistryImpl.cpp:
- 11:13 AM Changeset in webkit [144474] by
-
- 3 edits in trunk/Source/WebCore
[Curl] Session cookies should not be persistent.
https://bugs.webkit.org/show_bug.cgi?id=111060
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-03-01
Reviewed by Brent Fulgham.
Curl saves both persistent cookies, and session cookies to the cookie file.
The session cookies should be deleted before starting a new session.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::ResourceHandleManager): Call method to initialize cookie session.
(WebCore::ResourceHandleManager::initCookieSession): Added method to initialize cookie session.
- platform/network/curl/ResourceHandleManager.h: Added method to initialize cookie session.
- 11:04 AM Changeset in webkit [144473] by
-
- 8 edits in branches/safari-536.29-branch/Source/WebKit2
Merge r142017
2013-02-06 Anders Carlsson <andersca@apple.com>
Pass the document source URL to the pluginLoadPolicy callback
https://bugs.webkit.org/show_bug.cgi?id=109084
<rdar://problem/13154516>
Reviewed by Andreas Kling.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
- UIProcess/WebPageProxy.h: (WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::pluginLoadPolicy):
- UIProcess/WebUIClient.h: (WebUIClient):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): (WebKit::WebPage::canPluginHandleResponse):
- 10:53 AM Changeset in webkit [144472] by
-
- 5 edits in branches/safari-536.29-branch/Source/WebKit2
Merge r141923
2013-02-05 Anders Carlsson <andersca@apple.com>
WebKit clients should be able to override loading of blocked plug-ins
https://bugs.webkit.org/show_bug.cgi?id=108968
<rdar://problem/13154516>
Reviewed by Sam Weinig.
Replace the shouldInstantiatePlugin callback with a new pluginLoadPolicy which is called regardless
of whether the plug-in is blocked or not. This lets clients override the plug-in load policy and
force loading of blacklisted plug-ins (and vice versa).
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
- UIProcess/WebUIClient.cpp: (WebKit::toWKPluginLoadPolicy): (WebKit): (WebKit::toPluginModuleLoadPolicy): (WebKit::WebUIClient::pluginLoadPolicy):
- UIProcess/WebUIClient.h: (WebUIClient):
- 10:32 AM Changeset in webkit [144471] by
-
- 4 edits in tags/Safari-537.31.12/Source
Versioning.
- 10:28 AM Changeset in webkit [144470] by
-
- 1 copy in tags/Safari-537.31.12
New Tag.
- 10:11 AM WebKitGTK/2.0.x edited by
- (diff)
- 10:10 AM Changeset in webkit [144469] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r143973 - Build fix for gtk2-based library.
Reviewed by Martin Robinson.
- platform/gtk/WidgetRenderingContext.cpp: move gtk2 check to after the config.h
include, which is the one that includes autotoolsconfig.h, where the gtk2 define
lives.
- 10:07 AM Changeset in webkit [144468] by
-
- 34 edits in releases/WebKitGTK/webkit-2.0
Merge r143869 - [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
https://bugs.webkit.org/show_bug.cgi?id=110702
Reviewed by Martin Robinson.
Source/WebCore:
No tests. Build fix, no behaviour change.
- platform/gtk/GtkVersioning.h: include the autotoolsconfig.h header,
which contains the GTK_API_VERSION_2 define now.
Source/WebKit/gtk:
- tests/testapplicationcache.c: include autotoolsconfig.h.
- tests/testatk.c: ditto.
- tests/testatkroles.c: ditto.
- tests/testcontextmenu.c: ditto.
- tests/testcopyandpaste.c: ditto.
- tests/testdomdocument.c: ditto.
- tests/testdomdomwindow.c: ditto.
- tests/testdomnode.c: ditto.
- tests/testdownload.c: ditto.
- tests/testfavicondatabase.c: ditto.
- tests/testglobals.c: ditto.
- tests/testhittestresult.c: ditto.
- tests/testhttpbackend.c: ditto.
- tests/testkeyevents.c: ditto.
- tests/testloading.c: ditto.
- tests/testmimehandling.c: ditto.
- tests/testnetworkrequest.c: ditto.
- tests/testnetworkresponse.c: ditto.
- tests/testwebbackforwardlist.c: ditto.
- tests/testwebdatasource.c: ditto.
- tests/testwebframe.c: ditto.
- tests/testwebhistoryitem.c: ditto.
- tests/testwebinspector.c: ditto.
- tests/testwebplugindatabase.c: ditto.
- tests/testwebresource.c: ditto.
- tests/testwebsettings.c: ditto.
- tests/testwebview.c: ditto.
- tests/testwindow.c: ditto.
Tools:
- GtkLauncher/main.c: include autotoolsconfig.h.
- Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of
the include ordering check, since it uses autotoolsconfig.h which needs to
come first.
- 9:57 AM Changeset in webkit [144467] by
-
- 13 edits2 adds2 deletes in trunk
Web Inspector: Navigator should show tree element for each folder in the source path.
https://bugs.webkit.org/show_bug.cgi?id=108943
Reviewed by Pavel Feldman.
Source/WebCore:
NavigatorView now renders tree element for each folder in uiSourceCode uri.
Merging several folders into one tree elememnt when folder has only one folder as a child is supported.
ScriptsNavigator has horizontal scroll now.
Projects are shown in ScriptsNavigator by their displayName. This allows us to show several root file system folders
with the same name in the navigator (e.g. 'Source/WebCore/inspector' and 'LayoutTests/inspector').
Test: inspector/debugger/navigator-view.html: Renamed from scripts-file-selector.html
- English.lproj/localizedStrings.js:
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView):
(WebInspector.NavigatorView.iconClassForType):
(WebInspector.NavigatorView.prototype.addUISourceCode):
(WebInspector.NavigatorView.prototype._getProjectNode):
(WebInspector.NavigatorView.prototype._createProjectNode):
(WebInspector.NavigatorView.prototype._getOrCreateProjectNode):
(WebInspector.NavigatorView.prototype._getFolderNode):
(WebInspector.NavigatorView.prototype._createFolderNode):
(WebInspector.NavigatorView.prototype._getOrCreateFolderNode):
(WebInspector.NavigatorView.prototype._getUISourceCodeParentNode):
(WebInspector.NavigatorView.prototype._getOrCreateUISourceCodeParentNode):
(WebInspector.NavigatorView.prototype.revealUISourceCode):
(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorView.prototype.rename):
(WebInspector.NavigatorView.prototype.reset):
(.typeWeight):
(WebInspector.NavigatorTreeOutline._treeElementsCompare):
(WebInspector.BaseNavigatorTreeElement):
(WebInspector.BaseNavigatorTreeElement.prototype.type):
(WebInspector.NavigatorFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement.prototype.onpopulate):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
(WebInspector.NavigatorSourceTreeElement):
(WebInspector.NavigatorTreeNode):
(WebInspector.NavigatorTreeNode.prototype.treeElement):
(WebInspector.NavigatorTreeNode.prototype.dispose):
(WebInspector.NavigatorTreeNode.prototype.isRoot):
(WebInspector.NavigatorTreeNode.prototype.hasChildren):
(WebInspector.NavigatorTreeNode.prototype.populate):
(WebInspector.NavigatorTreeNode.prototype.wasPopulated):
(WebInspector.NavigatorTreeNode.prototype.didAddChild):
(WebInspector.NavigatorTreeNode.prototype.willRemoveChild):
(WebInspector.NavigatorTreeNode.prototype.isPopulated):
(WebInspector.NavigatorTreeNode.prototype.isEmpty):
(WebInspector.NavigatorTreeNode.prototype.child):
(WebInspector.NavigatorTreeNode.prototype.children):
(WebInspector.NavigatorTreeNode.prototype.appendChild):
(WebInspector.NavigatorTreeNode.prototype.removeChild):
(WebInspector.NavigatorTreeNode.prototype.reset):
(WebInspector.NavigatorRootTreeNode):
(WebInspector.NavigatorRootTreeNode.prototype.isRoot):
(WebInspector.NavigatorRootTreeNode.prototype.treeElement):
(WebInspector.NavigatorRootTreeNode.prototype.wasPopulated):
(WebInspector.NavigatorRootTreeNode.prototype.didAddChild):
(WebInspector.NavigatorRootTreeNode.prototype.willRemoveChild):
(WebInspector.NavigatorUISourceCodeTreeNode):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.treeElement):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.updateTitle):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.hasChildren):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.dispose):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype._titleChanged):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype._workingCopyChanged):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype._workingCopyCommitted):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype._formattedChanged):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.reveal):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.commitHandler):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.cancelHandler):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.afterEditing):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename):
(WebInspector.NavigatorFolderTreeNode):
(WebInspector.NavigatorFolderTreeNode.prototype.treeElement):
(WebInspector.NavigatorFolderTreeNode.prototype._createTreeElement):
(WebInspector.NavigatorFolderTreeNode.prototype.wasPopulated):
(WebInspector.NavigatorFolderTreeNode.prototype._addChildrenRecursive):
(WebInspector.NavigatorFolderTreeNode.prototype._shouldMerge):
(WebInspector.NavigatorFolderTreeNode.prototype.didAddChild):
(WebInspector.NavigatorFolderTreeNode.prototype.willRemoveChild):
- inspector/front-end/ScriptsNavigator.js:
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate.prototype.displayName):
- inspector/front-end/navigatorView.css:
(.navigator > ol):
(.navigator .base-navigator-tree-element-title):
(.navigator-tabbed-pane .navigator-container):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.):
(initialize_DebuggerTest):
- http/tests/inspector/workspace-test.js:
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
- inspector/debugger/navigator-view-expected.txt: Added.
- inspector/debugger/navigator-view.html: Added.
- inspector/debugger/scripts-file-selector-expected.txt: Removed.
- inspector/debugger/scripts-file-selector.html: Removed.
- inspector/debugger/scripts-panel-expected.txt:
- inspector/debugger/scripts-panel.html:
- inspector/debugger/scripts-sorting-expected.txt:
- inspector/debugger/scripts-sorting.html:
- 9:49 AM WebKitGTK/2.0.x edited by
- (diff)
- 9:48 AM Changeset in webkit [144466] by
-
- 3 edits in releases/WebKitGTK/webkit-2.0/LayoutTests
Merge r144045 - REGRESSION (r143931): set-cookie-on-redirect.html breaks subsequent tests
https://bugs.webkit.org/show_bug.cgi?id=110844
Patch by Sergio Villar Senin <svillar@igalia.com> on 2013-02-26
Reviewed by Alexey Proskuryakov.
Clean up cookies at the beginning and after finishing the test in
order not to break other tests behavior.
- http/tests/cookies/resources/set-cookie-on-redirect.php: clear cookie before returning.
- http/tests/cookies/set-cookie-on-redirect.html: clear all cookies before starting the test.
- 9:43 AM Changeset in webkit [144465] by
-
- 36 edits5 deletes in trunk/Source/WebCore
[BlackBerry] Upstream BlackBerry::Platform::Graphics::GraphicsContext integration related changes in platform/graphics/blackberry
https://bugs.webkit.org/show_bug.cgi?id=111072
Reviewed by Rob Buis.
BlackBerry PR 293208
This patch contains contributions from many members of the BlackBerry
WebKit team:
Rob Buis
Robin Cao
Michael Carmody
Max Feil
Eli Fidler
Antonio Gomes
Jacky Jiang
Mike Lattanzio
Yong Li
Andrew Lo
Maxim Mogilnitsky
Joshua Netterfield
Arvid Nilsson
Jakob Petsovits
Konrad Piascik
Jeff Rogers
Artem Simonov
Filip Spacek
George Staikos
Cosmin Truta
Covered by existing tests.
- platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
(WebCore::CanvasLayerWebKitThread::deleteTextures):
(CanvasLayerCompositingThreadClient):
(WebCore::CanvasLayerCompositingThreadClient::layerCompositingThreadDestroyed):
(WebCore::CanvasLayerCompositingThreadClient::layerVisibilityChanged):
(WebCore::CanvasLayerCompositingThreadClient::uploadTexturesIfNeeded):
(WebCore::CanvasLayerCompositingThreadClient::clearBuffer):
(WebCore):
(WebCore::CanvasLayerCompositingThreadClient::CanvasLayerCompositingThreadClient):
(WebCore::CanvasLayerCompositingThreadClient::drawTextures):
(WebCore::CanvasLayerCompositingThreadClient::deleteTextures):
(WebCore::CanvasLayerCompositingThreadClient::commitPendingTextureUploads):
(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::clearBuffer):
- platform/graphics/blackberry/CanvasLayerWebKitThread.h:
(WebCore):
(WebCore::CanvasLayerWebKitThread::create):
(CanvasLayerWebKitThread):
- platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:
(WebCore::DisplayRefreshMonitor::displayLinkFired):
- platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::publishToPlatformLayer):
(WebCore::DrawingBuffer::platformLayer):
- platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:
(WebCore::EGLImageLayerCompositingThreadClient::~EGLImageLayerCompositingThreadClient):
(WebCore::EGLImageLayerCompositingThreadClient::uploadTexturesIfNeeded):
(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
(WebCore::EGLImageLayerCompositingThreadClient::deleteTextures):
(WebCore::EGLImageLayerCompositingThreadClient::bindContentsTexture):
(WebCore::EGLImageLayerCompositingThreadClient::setTextureAccessor):
- platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.h:
(Graphics):
(EGLImageLayerCompositingThreadClient):
(WebCore::EGLImageLayerCompositingThreadClient::EGLImageLayerCompositingThreadClient):
- platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
(WebCore::EGLImageLayerWebKitThread::EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::~EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::updateFrontBuffer):
(WebCore::EGLImageLayerWebKitThread::deleteFrontBuffer):
(WebCore::EGLImageLayerWebKitThread::commitPendingTextureUploads):
(WebCore::EGLImageLayerWebKitThread::createTextureIfNeeded):
(WebCore::EGLImageLayerWebKitThread::blitToFrontBuffer):
- platform/graphics/blackberry/EGLImageLayerWebKitThread.h:
(Graphics):
(EGLImageLayerWebKitThread):
- platform/graphics/blackberry/FloatRectBlackBerry.cpp:
(WebCore::FloatRect::normalized):
(WebCore):
- platform/graphics/blackberry/FontCacheBlackberry.cpp: Removed.
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::paintToCanvas):
(WebCore::GraphicsContext3D::getImageData):
(WebCore):
- platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::setBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::clearBackgroundColor):
(WebCore):
(WebCore::GraphicsLayerBlackBerry::setContentsNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplayInRect):
(WebCore::GraphicsLayerBlackBerry::updateLayerBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::setupContentsLayer):
- platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
(GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::notifySyncRequired):
- platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::ImageFrame::asNewNativeImage):
(WebCore):
(WebCore::FrameData::clear):
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::invalidatePlatformData):
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
- platform/graphics/blackberry/InstrumentedPlatformCanvas.h: Removed.
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
(WebCore::LayerCompositingThread::contentsTexture):
(WebCore::LayerCompositingThread::commitPendingTextureUploads):
(WebCore):
- platform/graphics/blackberry/LayerCompositingThread.h:
(Graphics):
(LayerCompositingThread):
- platform/graphics/blackberry/LayerCompositingThreadClient.h:
(Graphics):
(WebCore):
(LayerCompositingThreadClient):
(WebCore::LayerCompositingThreadClient::contentsTexture):
(WebCore::LayerCompositingThreadClient::commitPendingTextureUploads):
- platform/graphics/blackberry/LayerData.h:
(WebCore::LayerData::LayerData):
(WebCore::LayerData::contentsResolutionIndependent):
(LayerData):
(WebCore::LayerData::layerProgram):
(WebCore::LayerData::isContainerForFixedPositionLayers):
(WebCore::LayerData::isFixedToTop):
(WebCore::LayerData::isFixedToLeft):
(WebCore::LayerData::frameVisibleRect):
(WebCore::LayerData::frameContentsSize):
(WebCore::LayerData::contentsScale):
- platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore::LayerFilterRendererAction::LayerFilterRendererAction):
(WebCore::LayerFilterRenderer::initializeSharedGLObjects):
(WebCore::LayerFilterRenderer::ping):
(WebCore::LayerFilterRenderer::pong):
(WebCore::LayerFilterRenderer::pushSnapshot):
(WebCore::LayerFilterRenderer::popSnapshot):
(WebCore::LayerFilterRenderer::applyActions):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore):
(WebCore::LayerRenderer::LayerRenderer):
(WebCore::LayerRenderer::~LayerRenderer):
(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::compositeBuffer):
(WebCore::LayerRenderer::drawColor):
(WebCore::LayerRenderer::useSurface):
(WebCore::LayerRenderer::drawLayersOnSurfaces):
(WebCore::glRound):
(WebCore::LayerRenderer::toOpenGLWindowCoordinates):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore::LayerRenderer::drawHolePunchRect):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::LayerRenderer::compositeLayersRecursive):
(WebCore::LayerRenderer::createProgram):
(WebCore::LayerRenderer::useProgram):
(WebCore::LayerRenderer::useLayerProgram):
- platform/graphics/blackberry/LayerRenderer.h:
(LayerRenderer):
- platform/graphics/blackberry/LayerRendererSurface.cpp:
(WebCore::LayerRendererSurface::ensureTexture):
- platform/graphics/blackberry/LayerTile.cpp:
(WebCore::LayerTile::LayerTile):
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::updateContents):
- platform/graphics/blackberry/LayerTile.h:
(LayerTile):
(WebCore::LayerTile::renderState):
(WebCore::LayerTile::needsRender):
(WebCore::LayerTile::setNeedsRender):
(WebCore::LayerTile::setRenderPending):
(WebCore::LayerTile::setRenderDone):
- platform/graphics/blackberry/LayerTileIndex.h:
- platform/graphics/blackberry/LayerTiler.cpp:
(WebCore):
(WebCore::defaultTileSize):
(WebCore::LayerTiler::LayerTiler):
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::createBuffer):
(WebCore::LayerTiler::willCommit):
(WebCore::LayerTiler::commitPendingTextureUploads):
(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::performTileJob):
(WebCore::LayerTiler::drawTile):
(WebCore::LayerTiler::drawTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::updateTileSize):
(WebCore::LayerTiler::setNeedsBacking):
(WebCore::LayerTiler::contentsTexture):
- platform/graphics/blackberry/LayerTiler.h:
(WebCore::LayerTiler::tileSize):
(LayerTiler):
(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::updateContents):
(TextureJob):
(WebCore::LayerTiler::needsRender):
(WebCore::LayerTiler::removeUpdateContentsJobs):
- platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::LayerWebKitThread):
(WebCore::LayerWebKitThread::~LayerWebKitThread):
(WebCore::LayerWebKitThread::paintContents):
(WebCore::LayerWebKitThread::commitPendingTextureUploads):
(WebCore::LayerWebKitThread::setContents):
(WebCore::LayerWebKitThread::setNeedsCommit):
(WebCore::LayerWebKitThread::notifyAnimationsStarted):
(WebCore::LayerWebKitThread::commitOnWebKitThread):
(WebCore::LayerWebKitThread::startAnimations):
(WebCore::LayerWebKitThread::updateTextureContents):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
(WebCore::LayerWebKitThread::addSublayer):
(WebCore):
(WebCore::LayerWebKitThread::addOverlay):
(WebCore::LayerWebKitThread::insert):
(WebCore::LayerWebKitThread::removeFromSuperlayer):
(WebCore::LayerWebKitThread::removeSublayerOrOverlay):
(WebCore::LayerWebKitThread::remove):
(WebCore::LayerWebKitThread::replaceSublayer):
(WebCore::LayerWebKitThread::filtersCanBeComposited):
(WebCore::LayerWebKitThread::removeAll):
(WebCore::LayerWebKitThread::setSublayers):
(WebCore::LayerWebKitThread::updateLayerHierarchy):
(WebCore::LayerWebKitThread::setIsMask):
(WebCore::LayerWebKitThread::releaseLayerResources):
- platform/graphics/blackberry/LayerWebKitThread.h:
(WebCore::LayerWebKitThread::insertSublayer):
(LayerWebKitThread):
(WebCore::LayerWebKitThread::isMask):
(WebCore::LayerWebKitThread::removeAllSublayers):
(WebCore::LayerWebKitThread::setFixedPosition):
(WebCore::LayerWebKitThread::setIsContainerForFixedPositionLayers):
(WebCore::LayerWebKitThread::setFixedToTop):
(WebCore::LayerWebKitThread::setFixedToLeft):
(WebCore::LayerWebKitThread::setFrameVisibleRect):
(WebCore::LayerWebKitThread::setFrameContentsSize):
(WebCore::LayerWebKitThread::setLayerProgram):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::supportsFullscreen):
(WebCore::MediaPlayerPrivate::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivate::prepareForRendering):
(WebCore):
(WebCore::MediaPlayerPrivate::resizeSourceDimensions):
(WebCore::MediaPlayerPrivate::percentLoaded):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):
(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
(WebCore::MediaPlayerPrivate::isProcessingUserGesture):
(WebCore::loadBufferingImageData):
(WebCore::MediaPlayerPrivate::setBuffering):
(WebCore::MediaPlayerPrivate::drawBufferingAnimation):
(WebCore::MediaPlayerPrivate::onConditionallyEnterFullscreen):
(WebCore::MediaPlayerPrivate::onExitFullscreen):
(WebCore::MediaPlayerPrivate::onCreateHolePunchRect):
(WebCore::MediaPlayerPrivate::onDestroyHolePunchRect):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(BlackBerry):
(Platform):
(Graphics):
(MediaPlayerPrivate):
- platform/graphics/blackberry/PluginLayerWebKitThread.cpp:
(WebCore::PluginLayerWebKitThread::setPluginView):
- platform/graphics/blackberry/Texture.cpp:
(WebCore::Texture::Texture):
(WebCore::Texture::updateContents):
(WebCore::Texture::setContentsToColor):
(WebCore::Texture::protect):
- platform/graphics/blackberry/Texture.h:
(Texture):
(WebCore::Texture::textureId):
(WebCore::Texture::isDirty):
(WebCore::Texture::hasTexture):
(WebCore::Texture::sizeInBytes):
(WebCore::Texture::setTextureId):
(WebCore::Texture::setSize):
- platform/graphics/blackberry/TextureCacheCompositingThread.cpp:
(WebCore::TextureCacheCompositingThread::allocateTextureId):
(WebCore::freeTextureId):
(WebCore::TextureCacheCompositingThread::collectGarbage):
(WebCore::TextureCacheCompositingThread::textureSizeInBytesChanged):
(WebCore):
(WebCore::TextureCacheCompositingThread::textureDestroyed):
(WebCore::TextureCacheCompositingThread::install):
(WebCore::TextureCacheCompositingThread::resizeTexture):
(WebCore::TextureCacheCompositingThread::evict):
(WebCore::TextureCacheCompositingThread::prune):
(WebCore::TextureCacheCompositingThread::clear):
(WebCore::TextureCacheCompositingThread::textureForTiledContents):
(WebCore::TextureCacheCompositingThread::updateContents):
- platform/graphics/blackberry/TextureCacheCompositingThread.h:
(TextureCacheCompositingThread):
(WebCore::TextureCacheCompositingThread::ZombieTexture::ZombieTexture):
(ZombieTexture):
- platform/graphics/blackberry/skia/ImageBufferDataSkia.h: Removed.
- platform/graphics/blackberry/skia/PlatformSupport.cpp: Removed.
- platform/graphics/blackberry/skia/PlatformSupport.h: Removed.
- 9:30 AM Changeset in webkit [144464] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix the Mac build with the current qtbase/dev branch
https://bugs.webkit.org/show_bug.cgi?id=111190
Reviewed by Allan Sandfeld Jensen.
QMAKE_MACOSX_DEPLOYMENT_TARGET now influences
MAC_OS_X_VERSION_MIN_REQUIRED through -mmacosx-version-min after
changes in qtbase to support iOS.
Having only WebCore defining it to 10.5 would create a mismatch of
ENABLE_THREADING_LIBDISPATCH with WTF to cause undefined symbols
while linking both together at the end.
Fix it by removing the statement which isn't needed anymore.
qtbase/mkspecs/common/mac-minimum-version.conf already defines
10.6 as the minimum Mac version.
- Target.pri:
- 9:06 AM Changeset in webkit [144463] by
-
- 7 edits in trunk
Web Inspector: [Regression] Snippets renaming is broken.
https://bugs.webkit.org/show_bug.cgi?id=111181
Reviewed by Alexander Pavlov.
Source/WebCore:
- inspector/front-end/NavigatorView.js:
- inspector/front-end/ScriptSnippetModel.js:
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.rename):
LayoutTests:
- inspector/debugger/script-snippet-model.html:
- 9:04 AM Changeset in webkit [144462] by
-
- 2 edits in trunk/Source/WebCore
Fix a misspelled word in RenderObject.h. staticly -> statically.
Reviewed by Dean Jackson.
- rendering/RenderObject.h:
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(WebCore::RenderObject::RenderObjectBitfields::isPositioned):
- 8:58 AM Changeset in webkit [144461] by
-
- 9 edits in trunk/Source/WebCore
[New Multicolumn] Change flow thread containment to be a state.
https://bugs.webkit.org/show_bug.cgi?id=111110
Change m_inRenderFlowThread from a single bit to an actual state. This
will let us track whether we're inside a multicolumn (in-flow) flow thread
or a named (out-of-flow) flow thread. In the former case, we're going to have
to do more work to maintain this state, but for now I've kept all the logic
the same just for the initial landing.
Reviewed by Andreas Kling.
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
(WebCore::NodeRenderingContext::createRendererForTextIfNeeded):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clone):
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::setFlowThreadStateIncludingDescendants):
(WebCore::RenderObject::removeFromRenderFlowThreadRecursive):
- rendering/RenderObject.h:
(WebCore::RenderObject::setParent):
(RenderObject):
(WebCore::RenderObject::inRenderFlowThread):
(WebCore::RenderObject::flowThreadState):
(WebCore::RenderObject::setFlowThreadState):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(RenderObjectBitfields):
(WebCore::RenderObject::RenderObjectBitfields::flowThreadState):
(WebCore::RenderObject::RenderObjectBitfields::setFlowThreadState):
- rendering/RenderView.cpp:
(WebCore::RenderView::addChild):
- 8:46 AM Changeset in webkit [144460] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
Roll out r144431 because it was a build fix for r144422, which was rolled out in r144446.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
- 8:28 AM Changeset in webkit [144459] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r144358): Add UNUSED_PARAM() macros to WebCore::Extensions3DOpenGL::drawBuffersEXT()
<http://webkit.org/b/109331>
Fixes the following build failures:
Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:218:51: error: unused parameter 'n' [-Werror,-Wunused-parameter]
void Extensions3DOpenGL::drawBuffersEXT(GC3Dsizei n, const GC3Denum* bufs)
Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:218:70: error: unused parameter 'bufs' [-Werror,-Wunused-parameter]
void Extensions3DOpenGL::drawBuffersEXT(GC3Dsizei n, const GC3Denum* bufs)
2 errors generated.
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::drawBuffersEXT): Add UNUSED_PARAM()
macros.
- 8:24 AM Changeset in webkit [144458] by
-
- 6 edits in trunk/Source/WebCore
[v8] ScriptValue has dangerous copy semantics
https://bugs.webkit.org/show_bug.cgi?id=110206
Patch by Dan Carney <dcarney@google.com> on 2013-03-01
Reviewed by Kentaro Hara.
Update ScriptValue to used a SharedPersistent,
making it impossible to return dead references.
No new tests. No change in functionality.
- bindings/v8/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):
(WebCore::ScriptValue::toInspectorValue):
- bindings/v8/ScriptValue.h:
(WebCore::ScriptValue::ScriptValue):
(WebCore::ScriptValue::operator=):
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::isEqual):
(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):
(WebCore::ScriptValue::clear):
(ScriptValue):
(WebCore::ScriptValue::v8Value):
(WebCore::ScriptValue::v8ValueRaw):
- bindings/v8/SharedPersistent.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::scriptValueAsNode):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAttrGetterCustom):
- 7:49 AM Changeset in webkit [144457] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/TestExpectations: Skipped failing test.
- 7:47 AM Changeset in webkit [144456] by
-
- 3 edits in trunk/Source/WebCore
Add FeatureObserver for marquee and reflection
https://bugs.webkit.org/show_bug.cgi?id=111118
Reviewed by Simon Fraser.
Refactoring covered by existing tests.
- page/FeatureObserver.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):
Added some instrumentation for reflection and marquee as they are both prefixed and this would help
to know their popularity on the web. Marquee was split between <marquee> (HTMLMarqueeElement) and
overflow: -webkit-marquee (CSSOverflowMarquee).
- 7:37 AM Changeset in webkit [144455] by
-
- 16 edits in trunk
Web Inspector: Introduce opaque SecurityOrigin string identifiers in the frontend
https://bugs.webkit.org/show_bug.cgi?id=111165
Reviewed by Vsevolod Vlasov.
Source/WebCore:
A plain string security origin value has been replaced by WebInspector.SecurityOrigin all over the code,
containing a URL (which holds a stringified security origin) and an identifier (which is now used
as a key in place of the stringified security origin in various maps). To avoid the ResourceTreeModel
code clutter, the security origin tracking code has been extracted into a separate type,
WebInspector.SecurityOriginTracker, which works as a helper on the ResourceTreeModel.
No new tests, as it is a refactoring.
- inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorage.storageId):
(WebInspector.DOMStorage.prototype.id):
(WebInspector.DOMStorage.prototype.getItems):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel.prototype._securityOriginAdded):
(WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
(WebInspector.DOMStorageModel.prototype._storageKey):
- inspector/front-end/ExtensionAuditCategory.js:
- inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._reset):
(WebInspector.FileSystemModel.prototype._securityOriginAdded):
(WebInspector.FileSystemModel.prototype._securityOriginRemoved):
(WebInspector.FileSystemModel.prototype._addOrigin):
(WebInspector.FileSystemModel.prototype._removeOrigin):
(WebInspector.FileSystemModel.prototype._requestFileSystemRoot):
(WebInspector.FileSystemModel.prototype._fileSystemRootReceived):
(WebInspector.FileSystemModel.prototype._removeFileSystem):
(WebInspector.FileSystemModel.FileSystem.prototype.get name):
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
(WebInspector.IndexedDBModel.prototype._securityOriginAdded):
(WebInspector.IndexedDBModel.prototype._securityOriginRemoved):
(WebInspector.IndexedDBModel.prototype._addOrigin):
(WebInspector.IndexedDBModel.prototype._removeOrigin):
(WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.):
(WebInspector.IndexedDBModel.prototype._requestData):
(WebInspector.IndexedDBModel.DatabaseId.prototype.equals):
- inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDatabaseView.prototype._refreshDatabase):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype.securityOriginForId):
(WebInspector.ResourceTreeModel.prototype.securityOrigins):
(WebInspector.ResourceTreeModel.prototype._handleMainFrameDetached):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.SecurityOriginTracker):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._addSecurityOrigin):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._removeSecurityOrigin):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._bindSecurityOrigin):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._unbindSecurityOrigin):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._detachMainFrame):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._securityOriginForId):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._securityOrigins):
(WebInspector.ResourceTreeFrame.prototype._navigate):
(WebInspector.SecurityOrigin.prototype.id):
(WebInspector.SecurityOrigin.prototype.url):
(WebInspector.SecurityOrigin.prototype.uiTitle):
(WebInspector.SecurityOrigin.prototype.toProtocol):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.IDBDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement.prototype.get itemURL):
(WebInspector.IDBObjectStoreTreeElement.prototype.get itemURL):
(WebInspector.IDBIndexTreeElement.prototype.get itemURL):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):
(WebInspector.FileSystemTreeElement):
LayoutTests:
Follow the string -> object conversion of the security origin.
- http/tests/inspector-enabled/dom-storage-open.html:
- http/tests/inspector/filesystem/delete-entry.html:
- http/tests/inspector/filesystem/request-filesystem-root.html:
- http/tests/inspector/indexeddb/database-data.html:
- http/tests/inspector/indexeddb/database-names.html:
- http/tests/inspector/indexeddb/database-structure.html:
- http/tests/inspector/resource-tree/resource-tree-events.html:
- 7:25 AM Changeset in webkit [144454] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Reverse the base and extent of a selection when reversing its handles
https://bugs.webkit.org/show_bug.cgi?id=111098
Reviewed by Yong Li.
PR283969
Swap the base and extent if base does not come first, and set the new selection.
Internally reviewed by Mike Fenton
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setSelection):
- 7:15 AM Changeset in webkit [144453] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: [Timeline] Show "curtains" when mouse is over CPU bar.
https://bugs.webkit.org/show_bug.cgi?id=108930
Reviewed by Pavel Feldman.
This feature will help developers to focus on events
that caused CPU bar.
- inspector/front-end/Popover.js: Added "arrowDirection" parameter.
- inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid): Added "curtains".
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._mouseMove): Show/hide "curtains"
when mouse is over CPU bar.
- inspector/front-end/timelinePanel.css: Added "curtains" style rules.
- 7:10 AM Changeset in webkit [144452] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Fix sign comparison warning/error after r144340.
https://bugs.webkit.org/show_bug.cgi?id=111164
Reviewed by Mark Hahnenberg.
gcc (both 4.2.1 and 4.7.2) complain about comparing signed and
unsigned terms (clang accepts it just fine).
Work around that by casting the 1 to an uintptr_t as well.
- dfg/DFGEdge.h:
(JSC::DFG::Edge::makeWord):
- 6:47 AM Changeset in webkit [144451] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Styles] Implement navigation to UI locations of property names/values in the source code
Relanding fixed r144449.
https://bugs.webkit.org/show_bug.cgi?id=105285
Reviewed by Vsevolod Vlasov.
Users can now Ctrl/Cmd-click CSS property names/values whose UI locations are found in
an external stylesheet/sass/other file. Inline stylesheets are not navigable,
since their start position is not detectable inside the surrounding HTML as of yet.
No new tests, a UI change.
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSRule.prototype.isSourceNavigable): Whether the rule contains reliable source code information.
(WebInspector.CSSProperty.prototype.uiLocation): Returns a UILocation for the property name of value.
- inspector/front-end/StylesSidebarPane.js: Add navigation code.
(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylePropertiesSection):
- 6:34 AM Changeset in webkit [144450] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r144449.
http://trac.webkit.org/changeset/144449
https://bugs.webkit.org/show_bug.cgi?id=111175
Breaks style-related inspector tests (Requested by apavlov on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-01
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSRule.prototype.get isRegular):
(WebInspector.CSSProperty.prototype.setDisabled):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylePropertiesSection):
(.event):
(.isRevert):
- 6:12 AM Changeset in webkit [144449] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Styles] Implement navigation to UI locations of property names/values in the source code
https://bugs.webkit.org/show_bug.cgi?id=105285
Reviewed by Vsevolod Vlasov.
Users can now Ctrl/Cmd-click CSS property names/values whose UI locations are found in
an external stylesheet/sass/other file. Inline stylesheets are not navigable,
since their start position is not detectable inside the surrounding HTML as of yet.
No new tests, a UI change.
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSRule.prototype.isSourceNavigable): Whether the rule contains reliable source code information.
(WebInspector.CSSProperty.prototype.uiLocation): Returns a UILocation for the property name of value.
- inspector/front-end/StylesSidebarPane.js: Add navigation code.
(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylePropertiesSection):
- 6:02 AM Changeset in webkit [144448] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium gardening, update image expectation again
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- 5:38 AM Changeset in webkit [144447] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r144443.
http://trac.webkit.org/changeset/144443
https://bugs.webkit.org/show_bug.cgi?id=111169
Caused 2 tests to crash by segv on Chromium Mac10.6 (Requested
by toyoshim on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-01
Source/WebCore:
- css/mediaControls.css:
(video::-webkit-media-text-track-display):
- rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::isOutside):
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet):
LayoutTests:
- media/track/track-cue-rendering-with-padding-expected.txt: Removed.
- media/track/track-cue-rendering-with-padding.html: Removed.
- 5:30 AM Changeset in webkit [144446] by
-
- 208 edits7 deletes in trunk/Source
Unreviewed, rolling out r144422 and r144424.
http://trac.webkit.org/changeset/144422
http://trac.webkit.org/changeset/144424
https://bugs.webkit.org/show_bug.cgi?id=111167
Caused over 20 tests to fail assertion on Chromium Win port as
ASSERTION FAILED: m_platformRequestUpdated (Requested by
toyoshim on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-01
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/RTCPeerConnection.cpp:
- Modules/notifications/Notification.cpp:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/ScriptControllerBase.cpp:
- bindings/js/JSNodeCustom.cpp:
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptSourceCode.h:
- bindings/objc/DOM.mm:
- bindings/v8/ScriptController.cpp:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- css/CSSCrossfadeValue.h:
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
- css/CSSFontFaceSource.h:
- css/CSSFontSelector.cpp:
- css/WebKitCSSSVGDocumentValue.cpp:
- css/WebKitCSSSVGDocumentValue.h:
(WebCore):
- dom/Clipboard.cpp:
(WebCore::Clipboard::Clipboard):
- dom/ContainerNode.cpp:
- dom/DOMImplementation.cpp:
- dom/PendingScript.h:
- dom/ScriptElement.cpp:
- dom/ScriptElement.h:
- history/CachedFrame.cpp:
- html/DOMURL.cpp:
- html/HTMLAnchorElement.cpp:
- html/HTMLAppletElement.cpp:
- html/HTMLElement.cpp:
- html/HTMLEmbedElement.cpp:
- html/HTMLFrameSetElement.cpp:
- html/HTMLHtmlElement.cpp:
- html/HTMLImageElement.cpp:
- html/HTMLObjectElement.cpp:
- html/HTMLPlugInElement.cpp:
- html/ImageDocument.cpp:
- html/ImageInputType.cpp:
- html/MediaDocument.cpp:
- html/PluginDocument.cpp:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
- html/parser/HTMLConstructionSite.cpp:
- html/parser/HTMLParserOptions.cpp:
- html/parser/HTMLScriptRunner.h:
- html/parser/XSSAuditor.cpp:
- html/parser/XSSAuditorDelegate.cpp:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorFileSystemAgent.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorInstrumentation.h:
(WebCore):
- inspector/InspectorPageAgent.cpp:
- inspector/NetworkResourcesData.cpp:
- inspector/NetworkResourcesData.h:
(WebCore):
- loader/CookieJar.cpp:
- loader/CrossOriginAccessControl.cpp:
- loader/CrossOriginAccessControl.h:
(WebCore):
- loader/CrossOriginPreflightResultCache.h:
- loader/DocumentThreadableLoader.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
- loader/FrameLoader.h:
(WebCore):
(WebCore::FrameLoader::policyChecker):
- loader/ImageLoader.cpp:
- loader/ImageLoader.h:
- loader/LinkLoader.h:
- loader/MainResourceLoader.cpp:
- loader/MainResourceLoader.h:
- loader/MixedContentChecker.cpp:
- loader/PingLoader.cpp:
- loader/PolicyChecker.h:
(WebCore):
- loader/ProgressTracker.cpp:
- loader/SubframeLoader.cpp:
- loader/SubresourceLoader.cpp:
- loader/TextTrackLoader.cpp:
- loader/TextTrackLoader.h:
- loader/ThreadableLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp:
- loader/appcache/ApplicationCacheGroup.h:
(WebCore):
- loader/appcache/ApplicationCacheHost.cpp:
- loader/archive/cf/LegacyWebArchive.cpp:
- loader/cache/CachedFont.cpp:
- loader/cache/CachedFont.h:
(CachedFontClient):
(WebCore::CachedFontClient::~CachedFontClient):
(WebCore::CachedFontClient::expectedType):
(WebCore::CachedFontClient::resourceClientType):
(WebCore::CachedFontClient::fontLoaded):
(WebCore):
- loader/cache/CachedFontClient.h: Removed.
- loader/cache/CachedImage.cpp:
- loader/cache/CachedRawResource.cpp:
- loader/cache/CachedRawResource.h:
(WebCore):
(CachedRawResourceClient):
(WebCore::CachedRawResourceClient::~CachedRawResourceClient):
(WebCore::CachedRawResourceClient::expectedType):
(WebCore::CachedRawResourceClient::resourceClientType):
(WebCore::CachedRawResourceClient::dataSent):
(WebCore::CachedRawResourceClient::responseReceived):
(WebCore::CachedRawResourceClient::dataReceived):
(WebCore::CachedRawResourceClient::redirectReceived):
(WebCore::CachedRawResourceClient::dataDownloaded):
- loader/cache/CachedRawResourceClient.h: Removed.
- loader/cache/CachedResource.cpp:
- loader/cache/CachedResourceHandle.cpp:
- loader/cache/CachedResourceHandle.h:
(WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
- loader/cache/CachedSVGDocument.h:
(CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::expectedType):
(WebCore::CachedSVGDocumentClient::resourceClientType):
(WebCore):
- loader/cache/CachedSVGDocumentClient.h: Removed.
- loader/cache/CachedSVGDocumentReference.cpp: Removed.
- loader/cache/CachedSVGDocumentReference.h:
(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
- loader/cache/CachedStyleSheetClient.h:
- loader/cache/MemoryCache.cpp:
- loader/cache/MemoryCache.h:
(WebCore):
(MemoryCache):
- loader/chromium/CachedRawResourceChromium.cpp:
- loader/icon/IconController.cpp:
- loader/icon/IconLoader.h:
- loader/mac/ResourceLoaderMac.mm:
- page/DOMWindowExtension.cpp:
- page/DragController.cpp:
- page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::reportMemoryUsage):
- page/Frame.h:
(WebCore):
(Frame):
(WebCore::Frame::init):
(WebCore::Frame::loader):
- page/PerformanceNavigation.cpp:
- page/PerformanceTiming.cpp:
- page/PointerLockController.cpp:
- page/Settings.cpp:
- page/animation/CSSPropertyAnimation.cpp:
- platform/chromium/PasteboardChromium.cpp:
- platform/efl/ErrorsEfl.cpp:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/filters/FilterOperation.cpp:
- platform/graphics/filters/FilterOperation.h:
(WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
(WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
- platform/gtk/ErrorsGtk.cpp:
- platform/gtk/PasteboardGtk.cpp:
- platform/gtk/PasteboardHelper.h:
- platform/mac/ClipboardMac.h:
- platform/mac/ClipboardMac.mm:
- platform/mac/HTMLConverter.mm:
- platform/mac/PasteboardMac.mm:
- platform/network/AuthenticationChallengeBase.cpp:
- platform/network/cf/CookieJarCFNet.cpp:
- platform/network/cf/ResourceRequestCFNet.cpp:
- platform/network/mac/CookieStorageMac.mm:
- platform/qt/PasteboardQt.cpp:
- plugins/DOMMimeType.cpp:
- plugins/PluginRequest.h: Removed.
- plugins/PluginStream.h:
(PluginStreamClient):
(WebCore::PluginStreamClient::~PluginStreamClient):
(WebCore::PluginStreamClient::streamDidFinishLoading):
(WebCore):
- plugins/PluginStreamClient.h: Removed.
- plugins/PluginView.cpp:
- plugins/PluginView.h:
(WebCore):
(PluginRequest):
(WebCore::PluginRequest::PluginRequest):
(WebCore::PluginRequest::frameLoadRequest):
(WebCore::PluginRequest::notifyData):
(WebCore::PluginRequest::sendNotification):
(WebCore::PluginRequest::shouldAllowPopups):
- rendering/HitTestResult.cpp:
- rendering/InlineFlowBox.cpp:
- rendering/RenderBox.cpp:
- rendering/RenderEmbeddedObject.cpp:
- rendering/RenderImage.cpp:
- rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::RenderImageResource):
- rendering/RenderImageResource.h:
(WebCore::RenderImageResource::image):
(WebCore::RenderImageResource::errorOccurred):
(WebCore::RenderImageResource::usesImageContainerSize):
(WebCore::RenderImageResource::imageHasRelativeWidth):
(WebCore::RenderImageResource::imageHasRelativeHeight):
(WebCore::RenderImageResource::imageSize):
- rendering/RenderImageResourceStyleImage.cpp:
- rendering/RenderLayer.cpp:
- rendering/RenderLayerBacking.cpp:
- rendering/RenderLayerFilterInfo.h:
- rendering/RenderListItem.cpp:
- rendering/RenderListMarker.cpp:
- rendering/RenderSnapshottedPlugIn.cpp:
- rendering/RenderTableCol.cpp:
- rendering/RenderTableRow.cpp:
- rendering/RenderTableSection.cpp:
- rendering/style/StyleCachedShader.h:
- rendering/style/StyleCustomFilterProgram.cpp: Removed.
- rendering/style/StyleCustomFilterProgram.h:
(WebCore):
(WebCore::StyleCustomFilterProgram::vertexShaderString):
(StyleCustomFilterProgram):
(WebCore::StyleCustomFilterProgram::fragmentShaderString):
(WebCore::StyleCustomFilterProgram::isLoaded):
(WebCore::StyleCustomFilterProgram::willHaveClients):
(WebCore::StyleCustomFilterProgram::didRemoveLastClient):
(WebCore::StyleCustomFilterProgram::notifyFinished):
- svg/SVGFEImageElement.h:
- svg/SVGFontFaceUriElement.h:
(SVGFontFaceUriElement):
- svg/SVGImageLoader.cpp:
- svg/SVGUseElement.cpp:
- svg/SVGUseElement.h:
- svg/graphics/SVGImageCache.cpp:
- testing/MockPagePopupDriver.cpp:
- xml/XSLStyleSheet.h:
- xml/XSLTProcessorLibxslt.cpp:
- xml/parser/XMLDocumentParser.cpp:
- xml/parser/XMLDocumentParser.h:
- xml/parser/XMLDocumentParserLibxml2.cpp:
Source/WebKit/chromium:
- src/ApplicationCacheHost.cpp:
- src/AssociatedURLLoader.cpp:
- src/EditorClientImpl.cpp:
- src/SharedWorkerRepository.cpp:
- src/WebDataSourceImpl.cpp:
- src/WebFrameImpl.h:
(WebCore):
- src/WebNode.cpp:
- src/WebSharedWorkerImpl.cpp:
- tests/FrameLoaderClientImplTest.cpp:
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- ewk/ewk_frame.cpp:
Source/WebKit/gtk:
- webkit/webkitwebpolicydecision.cpp:
Source/WebKit/mac:
- DOM/WebDOMOperations.mm:
- Misc/WebNSPasteboardExtras.mm:
- WebCoreSupport/WebFrameNetworkingContext.mm:
- WebView/WebRenderLayer.mm:
- WebView/WebRenderNode.mm:
Source/WebKit/qt:
- WebCoreSupport/NotificationPresenterClientQt.cpp:
- WebCoreSupport/QWebPageAdapter.cpp:
Source/WebKit2:
- NetworkProcess/HostRecord.h:
- NetworkProcess/NetworkResourceLoadScheduler.h:
- NetworkProcess/NetworkResourceLoader.h:
(WebCore):
- Shared/WebRenderLayer.cpp:
- Shared/WebRenderObject.cpp:
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
- WebProcess/WebPage/mac/WebPageMac.mm:
- WebProcess/WebProcess.cpp:
- WebProcess/soup/WebProcessSoup.cpp:
- 4:59 AM Changeset in webkit [144445] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium gardening, cleanup lint errors #2
Remove duplicated entries.
- platform/chromium/TestExpectations:
- 4:57 AM Changeset in webkit [144444] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: fix closure compiler warnings in ProfilesPanel
https://bugs.webkit.org/show_bug.cgi?id=111163
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-01
Reviewed by Vsevolod Vlasov.
- inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView.prototype.addProfileType):
- inspector/front-end/ProfilesPanel.js:
- 4:32 AM Changeset in webkit [144443] by
-
- 4 edits2 adds in trunk
Support padding, margin and border for internal UA cue styling
https://bugs.webkit.org/show_bug.cgi?id=110703
Reviewed by Eric Carlson.
Source/WebCore:
For some particular user agent styling this allows the possibility
of making the window around the cue text bigger to match some user
styles (see CaptionUserPreferencesMac::captionsStyleSheetOverride).
These properties *cannot* be set through by using the ::cue
pseudo-element and, as specified, are used only internally.
Test: media/track/track-cue-rendering-with-padding.html
- css/mediaControls.css:
(video::-webkit-media-text-track-display): Set the CSS box model
to include in the specified width or height the values of
padding / margin / border by using -webkit-box-sizing and avoid
overflow over 100% width because of having these properties set.
- rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::isOutside): To not interfere with
the regular WebVTT positioning algorithm, the check is done for
the absolute content box.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Added
an extra adjustment step to accomodate vertical padding (and not
overflow the cue container)
LayoutTests:
- media/track/track-cue-rendering-with-padding-expected.txt: Added.
- media/track/track-cue-rendering-with-padding.html: Added.
- 4:26 AM Changeset in webkit [144442] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium gardening
- platform/chromium/TestExpectations:
- 4:17 AM Changeset in webkit [144441] by
-
- 4 edits in trunk
[Qt] Enable LINK_PREFETCH
https://bugs.webkit.org/show_bug.cgi?id=111158
Reviewed by Simon Hausmann.
Tools:
- qmake/mkspecs/features/features.pri:
LayoutTests:
Unskip tests depending on LINK_PREFETCH.
- platform/qt/TestExpectations:
- 4:13 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:05 AM Changeset in webkit [144440] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Fix failing API tests after r143935
https://bugs.webkit.org/show_bug.cgi?id=111086
Reviewed by Jocelyn Turcotte.
Convert a leftorver resume call to the new resumeAndUpdateContent() call
in PageViewportControllerClientQt so that the notifications about zoom
animation state changes reach the API tests.
- UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):
- 4:04 AM Changeset in webkit [144439] by
-
- 7 edits in trunk
Web Inspector: Save/load timeline should preserve DOMContentLoaded and Load event markers
https://bugs.webkit.org/show_bug.cgi?id=110819
Reviewed by Pavel Feldman.
To create event divider TimelinePresentation model checks if record
frame is main frame. With this patch check is moved to backend and
result is saved in record to avoid incoherence.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
Record "isMainFrame" flag.
(WebCore::InspectorTimelineAgent::didMarkLoadEvent): Ditto.
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createMarkData):
Added data object constructor.
- inspector/TimelineRecordFactory.h: Ditto.
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.isEventDivider):
Use saved flag value instead of comparing with "current" main frame.
- 4:01 AM Changeset in webkit [144438] by
-
- 2 edits in trunk/Tools
[Qt] Update features.pri with new features
https://bugs.webkit.org/show_bug.cgi?id=111157
Reviewed by Jocelyn Turcotte.
- qmake/mkspecs/features/features.pri:
- 3:46 AM Changeset in webkit [144437] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
https://bugs.webkit.org/show_bug.cgi?id=111077
Reviewed by Pavel Feldman.
Analysis: DataGridNode.refresh removes all cells and then recreates them.
The issue is that mandatory "corner" cell is not recreated.
- inspector/front-end/DataGrid.js:
(WebInspector.DataGridNode.prototype.refresh):
Added "corner" cell restoration code.
- 3:39 AM Changeset in webkit [144436] by
-
- 20 edits2 adds in trunk/Source/WebKit2
[WK2] Asynchronous spell checking implementation
https://bugs.webkit.org/show_bug.cgi?id=109577
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com>, Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2013-03-01
Reviewed by Enrica Casucci.
Associate the abstract 'WebCore::TextCheckingRequest' object with the unique identifier
on WebProcess side. The request data from the 'TextCheckingRequest' are retrieved and
passed to the UIProcess. The WK2 client (TextChecker{Gtk/Mac/Efl/Qt}.cpp) gets
the 'TextCheckerCompletion' object with the request data and possibility to notify
the WebProcess about the spelling results.
Finally, the WebPage object calls on the proper 'TextCheckingRequest' object
didSuccess/didCancel method to notify the WebCore about the spelling result.
- CMakeLists.txt:
- GNUmakefile.list.am:
Add 'TextCheckerCompletion.{h/cpp}' to the WebKit2 cmake based and
WK2-Gtk+ builds.
- Scripts/webkit2/messages.py:
(headers_for_type):
Add exception for 'TextCheckingRequestData' class to properly find header
file for it.
- Shared/WebCoreArgumentCoders.cpp:
- Shared/WebCoreArgumentCoders.h:
Teach 'ArgumentCoder' how to encode/decode 'TextCheckingRequestData' class.
- Target.pri:
Add 'TextCheckerCompletion.{h/cpp}' to the WK2-Qt build.
- UIProcess/TextChecker.h:
Add 'requestCheckingOfString' method to the TextChecker's interface.
- UIProcess/TextCheckerCompletion.cpp: Added.
(WebKit::TextCheckerCompletion::create):
(WebKit::TextCheckerCompletion::TextCheckerCompletion):
(WebKit::TextCheckerCompletion::spellDocumentTag):
Return the WebPageProxy's spellDocumentTag as the client might be
interested in from which page the request came.
(WebKit::TextCheckerCompletion::textCheckingRequestData):
Allow to retrieve 'TextCheckingRequestData' object.
(WebKit::TextCheckerCompletion::didFinishCheckingText):
(WebKit::TextCheckerCompletion::didCancelCheckingText):
Notify the 'WebPageProxy' object that the given request has been
handled or canceled.
- UIProcess/TextCheckerCompletion.h: Added.
Introduce a new class for WK2 to retrieve the request data and
call didFinishCheckingText/didCancelCheckingText.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestCheckingOfString):
Create 'TextCheckerCompletion' object and pass it
to the 'TextChecker::requestCheckingOfString' method.
(WebKit::WebPageProxy::didFinishCheckingText):
(WebKit::WebPageProxy::didCancelCheckingText):
Send the messages to WebProcess that the given request has been
handled or canceled.
- UIProcess/WebPageProxy.h:
(WebPageProxy):
Add public declarations for 'didFinishCheckingText', 'didCancelCheckingText'.
Add private declarations for 'requestCheckingOfString'.
Move the 'spellDocumentTag()' method to to the public section to be
accessible from 'TextCheckerCompletion' class.
- UIProcess/WebPageProxy.messages.in:
A new entry for 'RequestCheckingOfString'.
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::TextChecker::requestCheckingOfString):
(WebKit):
- UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::requestCheckingOfString):
(WebKit):
- UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::requestCheckingOfString):
(WebKit):
- UIProcess/qt/TextCheckerQt.cpp:
(WebKit::TextChecker::requestCheckingOfString):
(WebKit):
Add dummy implementations for 'requestCheckingOfString'.
- WebKit2.xcodeproj/project.pbxproj:
Add 'TextCheckerCompletion.{h/cpp} to Mac build.
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::generateTextCheckingRequestID):
Helper function to generate the unique identifier for the abstract
'TextCheckingRequest' object.
(WebKit::WebEditorClient::requestCheckingOfString):
Associate 'TextCheckingRequest' with the unique identifier and add them
to the map object.
Get the request data and send it to the UIProcess.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::addTextCheckingRequest):
Add the identifier and the request to the map object.
(WebKit::WebPage::didFinishCheckingText):
(WebKit::WebPage::didCancelCheckingText):
Call didSucceed/didCancel on the 'TextCheckingRequest' to notify the WebCore
about spellcheking results.
Remove the request from the map object.
- WebProcess/WebPage/WebPage.h:
Add declarations for 'addTextCheckingRequest', 'didFinishCheckingText' and
'didCancelCheckingText.'
- WebProcess/WebPage/WebPage.messages.in:
Add a new entry for DidFinishCheckingText, DidCancelCheckingText.
- 3:36 AM Changeset in webkit [144435] by
-
- 4 edits in trunk/LayoutTests
Flaky test: http/tests/inspector/resource-tree/resource-request-content-while-loading.html
https://bugs.webkit.org/show_bug.cgi?id=111123
Reviewed by Alexander Pavlov.
- TestExpectations:
- http/tests/inspector/resource-tree/resource-request-content-while-loading.html:
- platform/chromium/TestExpectations:
- 2:33 AM Changeset in webkit [144434] by
-
- 18 edits5 adds in trunk
Web Inspector: Selector's raw start position in its line is considered to be 0 when computing UILocation
https://bugs.webkit.org/show_bug.cgi?id=110732
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test: inspector/styles/selector-line.html
- inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::sizetExtractor): Utility for binary search.
(WebCore::ContentSearchUtils::textPositionFromOffset): Converts absolute raw text offset into line:column.
(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines): Refactor.
(WebCore::ContentSearchUtils::lineEndings): Factored out of getRegularExpressionMatchesByLines.
(WebCore::ContentSearchUtils::buildObjectForSearchMatch): Drive-by: pass String by reference.
- inspector/ContentSearchUtils.h:
- inspector/Inspector.json: Use line:column for SourceRange boundaries rather than raw offsets.
- inspector/InspectorStyleSheet.cpp:
(ParsedStyleSheet::text): ASSERT(m_hasText).
(WebCore::InspectorStyle::buildObjectForStyle): Supply the lineEndings argument.
(WebCore::buildSourceRangeObject): Follow the protocol change.
(WebCore::InspectorStyle::setPropertyText): Refactor.
(WebCore::InspectorStyle::toggleProperty): Ditto.
(WebCore::InspectorStyle::styleText): Ditto.
(WebCore::InspectorStyle::populateAllProperties): Ditto.
(WebCore::InspectorStyle::styleWithProperties): Convert relative property range offsets into absolute ones.
(WebCore::InspectorStyle::extractSourceData): Factored out.
(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters): Supply the lineEndings argument.
(WebCore::InspectorStyleSheet::buildObjectForSelectorList): Ditto.
(WebCore::InspectorStyleSheet::lineEndings): Compute line endings for ordinary stylesheets.
(WebCore::InspectorStyleSheetForInlineStyle::lineEndings): Ditto for bogus inline style stylesheets.
- inspector/InspectorStyleSheet.h:
- inspector/front-end/AuditRules.js: Removed the byte counting for unused CSS.
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSRule): Set selector rawLocation based on the selectorList range or sourceLine.
(WebInspector.CSSRule.prototype._setRawLocation): Added.
- inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping.prototype._bindUISourceCode): Fix call order when binding scss sourcecodes.
LayoutTests:
Changed tests have been rebaselined to follow the new source range structure.
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.rangeText): Fix source range dumping format.
- inspector/audits/audits-panel-functional-expected.txt:
- inspector/audits/audits-panel-noimages-functional-expected.txt:
- inspector/styles/get-set-stylesheet-text-expected.txt:
- inspector/styles/parse-stylesheet-errors-expected.txt:
- inspector/styles/resources/selector-line.css: Added.
- inspector/styles/resources/selector-line.css.map: Added.
- inspector/styles/resources/selector-line.scss: Added.
- inspector/styles/selector-line-expected.txt: Added.
- inspector/styles/selector-line.html: Added.
- inspector/styles/styles-new-API-expected.txt:
- inspector/styles/styles-source-offsets-expected.txt:
- inspector/styles/styles-source-offsets.html:
- 2:19 AM Changeset in webkit [144433] by
-
- 2 edits in trunk/Tools
[chromium] put WebTestProxy::scheduleComposite back in place
https://bugs.webkit.org/show_bug.cgi?id=111146
Reviewed by Nico Weber.
The call was removed in http://trac.webkit.org/changeset/144398 because
DRT doesn't need it. However, content shell depends on this call.
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestRunner::WebTestProxy::scheduleComposite):
- 2:13 AM Changeset in webkit [144432] by
-
- 3 edits in trunk/Source/WebCore
Get rid of two silly static null Strings
https://bugs.webkit.org/show_bug.cgi?id=111151
Reviewed by Eric Seidel.
We have a global null String through nullAtom, there is no need
for local static null strings.
- page/Page.cpp:
(WebCore::Page::groupName):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::markerText):
- 2:03 AM Changeset in webkit [144431] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h: Add a missing #include.
- 1:45 AM Changeset in webkit [144430] by
-
- 5 edits1 add in trunk/LayoutTests
[Mac] [WK1] http/tests/xmlhttprequest/navigation-should-abort.html fails
https://bugs.webkit.org/show_bug.cgi?id=111052
Reviewed by Alexey Proskuryakov.
Currently, this test is failing to output the textual content of the
'data:' URL to which the test navigates. Replacing this 'data:' URL
with a "real" HTML file ensures that Mac WK1 behaves the same way as
the other ports for this test.
This doesn't really address the issue raised: navigation to a 'data:'
URL should behave in the same way as a "real" URL; filed
http://wkbug.com/111152 to track that issue.
- http/tests/xmlhttprequest/resources/navigation-target.html: Added.
Add an actual file to which we can navigate.
- http/tests/xmlhttprequest/navigation-should-abort-expected.txt:
- http/tests/xmlhttprequest/navigation-should-abort.html:
Navigate to the new HTML file during the test rather than an inlined
data: URL.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
Remove the expectations set in r144277.
- 1:44 AM Changeset in webkit [144429] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk-wk1/TestExpectations: Removing expectation for the fast/canvas/canvas-currentPath-crash.html test.
- platform/gtk/media/video-playing-and-pause-expected.txt: Rebaselining.
- 1:37 AM Changeset in webkit [144428] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix code-mirror experiment to work in debug mode
https://bugs.webkit.org/show_bug.cgi?id=111064
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-01
Reviewed by Pavel Feldman.
No new tests: no change in behaviour.
Improve importScript function to try load a script from the root
directory iff its loading from the given path failed.
- inspector/front-end/utilities.js:
- 1:18 AM Changeset in webkit [144427] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Canvas] capture a WebGL extension by it's name in lower case
https://bugs.webkit.org/show_bug.cgi?id=110745
Reviewed by Pavel Feldman.
WebGL's getExtension accepts a name that is tested against an ASCII case-insensitive match.
Just force lower case for extension names.
- inspector/InjectedScriptCanvasModuleSource.js:
(.):
- 1:07 AM Changeset in webkit [144426] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Fix definition of DatePickerClient::setValue()
https://bugs.webkit.org/show_bug.cgi?id=110336
Patch by Alberto Garcia <albgarcia@rim.com> on 2013-03-01
Reviewed by Carlos Garcia Campos.
The definition of DatePickerClient::setValue() introduced in
r142987 does not match the prototype.
- WebCoreSupport/DatePickerClient.cpp:
(WebCore::DatePickerClient::setValue):
- 12:47 AM Changeset in webkit [144425] by
-
- 2 edits in trunk/Source/WebCore
XSSAuditor should use threadSafeMatch when relevant.
https://bugs.webkit.org/show_bug.cgi?id=111099
Reviewed by Adam Barth.
Given the work on breaking parsing out into a background thread, we
should compare QualifiedNames in a thread-safe manner. Rather than
casting the result of QualifiedName::localName to a String, we can
call out to threadSafeMatch to do the comparison.
This patch leaves one use of equalIgnoringNullity in
XSSAuditor::findAttributeWithName. That usage seems safe, since we're
creating a new string against which to compare.
- html/parser/XSSAuditor.cpp:
(WebCore::hasName):
Replace call to equalIgnoringNullity(Vector<UChar...>, String)
with threadSafeMatch(String, QualifiedName).
- 12:23 AM Changeset in webkit [144424] by
-
- 2 edits in trunk/Source/WebKit/chromium
REGRESSION(r144422): Broke compilation on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=111150
Unreviewed build fix.
- src/WebFrameImpl.h:
(WebCore):
Feb 28, 2013:
- 11:48 PM Changeset in webkit [144423] by
-
- 2 edits in trunk/Source/WebCore
Add calendar table view for the new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110970
Reviewed by Kent Tamura.
The calendar table that will be used in the new calendar picker (Bug 109439).
No new tests. Code is not used yet.
- Resources/pagepopups/calendarPicker.js:
(DayCell): Cell which represents one day in the calendar.
(DayCell.recycleOrCreate):
(DayCell.prototype._recycleBin):
(DayCell.prototype.throwAway):
(DayCell.prototype.setHighlighted): Sets the highlighted class on the element.
(DayCell.prototype.setDisabled): Sets the disabled class on the element.
(DayCell.prototype.setIsInCurrentMonth): Sets the current-month class on the element.
(DayCell.prototype.setIsToday): Sets the today class on the element.
(DayCell.prototype.reset): Resets the day cell to be reused.
(WeekNumberCell): Cell used for the week number column.
(WeekNumberCell.prototype._recycleBin):
(WeekNumberCell.recycleOrCreate):
(WeekNumberCell.prototype.reset):
(WeekNumberCell.prototype.throwAway):
(WeekNumberCell.prototype.setHighlighted): Sets the highlighted class on the element.
(WeekNumberCell.prototype.setDisabled): Sets the disabled class on the element.
(CalendarTableHeaderView): Header for the calendar table. Contains the column labels.
(CalendarRowCell): Row containing day cells and maybe a week number cell.
(CalendarRowCell.prototype._recycleBin):
(CalendarRowCell.prototype.reset):
(CalendarRowCell.prototype.throwAway):
(CalendarTableView): A list view showing a grid of days.
(CalendarTableView.prototype.rowAtScrollOffset): Returns the row number currently at the scroll offset.
(CalendarTableView.prototype.scrollOffsetForRow): Returns the current scroll offset for the given row.
(CalendarTableView.prototype.onClick): If the click is on a DayCell or WeekNumberCell, select the appropriate date range.
(CalendarTableView.prototype.onMouseOver): If the click is on a DayCell or WeekNumberCell, highlight the appropriate date range.
(CalendarTableView.prototype.onMouseOut):
(CalendarTableView.prototype.prepareNewCell): Prepares a new row cell by recycling or creating a new one.
(CalendarTableView.prototype.height): Returns the height of the view in pixels.
(CalendarTableView.prototype.setHeight): Sets the height of the view in pixels.
(CalendarTableView.prototype.scrollToMonth): Scrolls to reveal the given month.
(CalendarTableView.prototype.dayAtColumnAndRow): Day at a given column and row. Column number doesn't count week number column.
(CalendarTableView.prototype.columnAndRowForDay): Column and row for the given day.
(CalendarTableView.prototype.updateCells): Update the position and appearance of the cell.s
(CalendarTableView.prototype.prepareNewDayCell): Prepares a new day cell. The cell is registered to this._dayCells.
(CalendarTableView.prototype.prepareNewWeekNumberCell): Prepares a new week number cell. The cell is registered to this._weekNumberCells.
(CalendarTableView.prototype.throwAwayDayCell): The cell is unregistered from this._dayCells.
(CalendarTableView.prototype.throwAwayWeekNumberCell): The cell is unregistered from this._weekNumberCells.
- 11:26 PM Changeset in webkit [144422] by
-
- 208 edits5 copies2 adds in trunk/Source
Reduce amount of rebuilding when touching networking headers
https://bugs.webkit.org/show_bug.cgi?id=111035
Reviewed by Eric Seidel.
Source/WebCore:
This uses a number of common unsurprising techniques. One interesting observation
is that including CachedResource related headers is very expensive. We can usually
get away with their Client counterparts, and with CachedResourceHandle.
- page/Frame.cpp:
- page/Frame.h:
Don't include FrameLoader, greatly reducing include graph for most non-loader files.
This required making Frame::init() non-inline - I'm not sure why it ever was.
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
Even though FrameLoader is logically on loading side of WebCore, it's included in
too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
largest wins. As a future improvement, we should probably convert other members
to OwnPtrs.
- css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
definition of a class it holds, but default construction does not.
- loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
- loader/cache/CachedFont.h:
- loader/cache/CachedFontClient.h: Added.
- loader/cache/CachedRawResource.h:
- loader/cache/CachedRawResourceClient.h: Added.
- loader/cache/CachedSVGDocument.h:
- loader/cache/CachedSVGDocumentClient.h: Added.
These types were defining client types in the same headers, making it impossible
to avoid including networking headers through CachedResource. Moved clients into
separate files.
- plugins/PluginStream.h:
- plugins/PluginStreamClient.h: Added.
Similar situation here.
- loader/cache/CachedResourceHandle.cpp:
- loader/cache/CachedResourceHandle.h:
Moved functions that need to know about CachedResource to .cpp file. This is another
huge win. Added a destructor, so that CachedResource woudn't be needed in all files
that include CachedResourceHandle.
- loader/cache/CachedSVGDocumentReference.cpp: Added.
- loader/cache/CachedSVGDocumentReference.h:
Moved constructor and virtual function implementations to a .cpp file - they need
not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
- platform/graphics/filters/FilterOperation.cpp:
- platform/graphics/filters/FilterOperation.h:
Avoid including CachedSVGDocumentReference.h. This is not such a big win now that
CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly
rendering code that it seems best to cut any ties with resources and loading.
Added a virtual destrutor in .cpp file, because inline destructors in polymorphic
classes are generally harmful (due to code bloat).
- plugins/PluginRequest.h: Added.
- plugins/PluginView.h:
Moved PluginRequest into a separate file, it was out of place in a view hierarchy
class file.
- rendering/RenderImageResource.cpp:
- rendering/RenderImageResource.h:
Moved definitions of virtual functions to a .cpp file. Thre is no win from having
them inline, and now we don't need CachedImage.h in the header.
- rendering/style/StyleCustomFilterProgram.cpp: Added.
- rendering/style/StyleCustomFilterProgram.h:
Ditto.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/RTCPeerConnection.cpp:
- Modules/notifications/Notification.cpp:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/ScriptControllerBase.cpp:
- bindings/js/JSNodeCustom.cpp:
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptSourceCode.h:
- bindings/objc/DOM.mm:
- bindings/v8/ScriptController.cpp:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- css/CSSFontFaceSource.h:
- css/CSSFontSelector.cpp:
- css/WebKitCSSSVGDocumentValue.cpp:
- css/WebKitCSSSVGDocumentValue.h:
- dom/Clipboard.cpp:
- dom/ContainerNode.cpp:
- dom/DOMImplementation.cpp:
- dom/PendingScript.h:
- dom/ScriptElement.cpp:
- dom/ScriptElement.h:
- history/CachedFrame.cpp:
- html/DOMURL.cpp:
- html/HTMLAnchorElement.cpp:
- html/HTMLAppletElement.cpp:
- html/HTMLElement.cpp:
- html/HTMLEmbedElement.cpp:
- html/HTMLFrameSetElement.cpp:
- html/HTMLHtmlElement.cpp:
- html/HTMLImageElement.cpp:
- html/HTMLObjectElement.cpp:
- html/HTMLPlugInElement.cpp:
- html/ImageDocument.cpp:
- html/ImageInputType.cpp:
- html/MediaDocument.cpp:
- html/PluginDocument.cpp:
- html/canvas/WebGLRenderingContext.cpp:
- html/parser/HTMLConstructionSite.cpp:
- html/parser/HTMLParserOptions.cpp:
- html/parser/HTMLScriptRunner.h:
- html/parser/XSSAuditor.cpp:
- html/parser/XSSAuditorDelegate.cpp:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorFileSystemAgent.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorInstrumentation.h:
- inspector/InspectorPageAgent.cpp:
- inspector/NetworkResourcesData.cpp:
- inspector/NetworkResourcesData.h:
- loader/CookieJar.cpp:
- loader/CrossOriginAccessControl.cpp:
- loader/CrossOriginPreflightResultCache.h:
- loader/DocumentThreadableLoader.h:
- loader/ImageLoader.cpp:
- loader/ImageLoader.h:
- loader/LinkLoader.h:
- loader/MainResourceLoader.cpp:
- loader/MainResourceLoader.h:
- loader/MixedContentChecker.cpp:
- loader/PingLoader.cpp:
- loader/PolicyChecker.h:
- loader/ProgressTracker.cpp:
- loader/SubframeLoader.cpp:
- loader/SubresourceLoader.cpp:
- loader/TextTrackLoader.cpp:
- loader/TextTrackLoader.h:
- loader/ThreadableLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp:
- loader/appcache/ApplicationCacheGroup.h:
- loader/appcache/ApplicationCacheHost.cpp:
- loader/archive/cf/LegacyWebArchive.cpp:
- loader/cache/CachedFont.cpp:
- loader/cache/CachedImage.cpp:
- loader/cache/CachedRawResource.cpp:
- loader/cache/CachedResource.cpp:
- loader/cache/CachedStyleSheetClient.h:
- loader/cache/MemoryCache.cpp:
- loader/cache/MemoryCache.h:
- loader/chromium/CachedRawResourceChromium.cpp:
- loader/icon/IconController.cpp:
- loader/icon/IconLoader.h:
- loader/mac/ResourceLoaderMac.mm:
- page/DOMWindowExtension.cpp:
- page/DragController.cpp:
- page/PerformanceNavigation.cpp:
- page/PerformanceTiming.cpp:
- page/PointerLockController.cpp:
- page/Settings.cpp:
- page/animation/CSSPropertyAnimation.cpp:
- platform/chromium/PasteboardChromium.cpp:
- platform/efl/ErrorsEfl.cpp:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
- platform/gtk/ErrorsGtk.cpp:
- platform/gtk/PasteboardGtk.cpp:
- platform/gtk/PasteboardHelper.h:
- platform/mac/ClipboardMac.h:
- platform/mac/ClipboardMac.mm:
- platform/mac/HTMLConverter.mm:
- platform/mac/PasteboardMac.mm:
- platform/network/AuthenticationChallengeBase.cpp:
- platform/network/cf/CookieJarCFNet.cpp:
- platform/network/cf/ResourceRequestCFNet.cpp:
- platform/network/mac/CookieStorageMac.mm:
- platform/qt/PasteboardQt.cpp:
- plugins/DOMMimeType.cpp:
- plugins/PluginView.cpp:
- rendering/HitTestResult.cpp:
- rendering/InlineFlowBox.cpp:
- rendering/RenderBox.cpp:
- rendering/RenderEmbeddedObject.cpp:
- rendering/RenderImage.cpp:
- rendering/RenderImageResourceStyleImage.cpp:
- rendering/RenderLayer.cpp:
- rendering/RenderLayerBacking.cpp:
- rendering/RenderLayerFilterInfo.h:
- rendering/RenderListItem.cpp:
- rendering/RenderListMarker.cpp:
- rendering/RenderSnapshottedPlugIn.cpp:
- rendering/RenderTableCol.cpp:
- rendering/RenderTableRow.cpp:
- rendering/RenderTableSection.cpp:
- rendering/style/StyleCachedShader.h:
- svg/SVGFEImageElement.h:
- svg/SVGFontFaceUriElement.h:
- svg/SVGImageLoader.cpp:
- svg/SVGUseElement.cpp:
- svg/SVGUseElement.h:
- svg/graphics/SVGImageCache.cpp:
- testing/MockPagePopupDriver.cpp:
- xml/XSLStyleSheet.h:
- xml/XSLTProcessorLibxslt.cpp:
- xml/parser/XMLDocumentParser.cpp:
- xml/parser/XMLDocumentParser.h:
- xml/parser/XMLDocumentParserLibxml2.cpp:
Many self-evident changes - removing unnecessary header includes, adding smaller
more local ones that are now necessary.
Source/WebKit/chromium:
Adding includes that are now necessary because WebCore headers don't have them
any more.
- src/ApplicationCacheHost.cpp:
- src/AssociatedURLLoader.cpp:
- src/EditorClientImpl.cpp:
- src/SharedWorkerRepository.cpp:
- src/WebDataSourceImpl.cpp:
- src/WebFrameImpl.h:
- src/WebNode.cpp:
- src/WebSharedWorkerImpl.cpp:
- tests/FrameLoaderClientImplTest.cpp:
Source/WebKit/efl:
Adding includes that are now necessary because WebCore headers don't have them
any more.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- ewk/ewk_frame.cpp:
Source/WebKit/gtk:
Adding includes that are now necessary because WebCore headers don't have them
any more.
- webkit/webkitwebpolicydecision.cpp:
Source/WebKit/mac:
Adding includes that are now necessary because WebCore headers don't have them
any more.
- DOM/WebDOMOperations.mm:
- Misc/WebNSPasteboardExtras.mm:
- WebCoreSupport/WebFrameNetworkingContext.mm:
- WebView/WebRenderLayer.mm:
- WebView/WebRenderNode.mm:
Source/WebKit/qt:
Adding includes that are now necessary because WebCore headers don't have them
any more.
- WebCoreSupport/NotificationPresenterClientQt.cpp:
- WebCoreSupport/QWebPageAdapter.cpp:
Source/WebKit2:
Adding includes that are now necessary because WebCore headers don't have them
any more.
- NetworkProcess/HostRecord.h:
- NetworkProcess/NetworkResourceLoadScheduler.h:
- NetworkProcess/NetworkResourceLoader.h:
- Shared/WebRenderLayer.cpp:
- Shared/WebRenderObject.cpp:
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
- WebProcess/WebPage/mac/WebPageMac.mm:
- WebProcess/WebProcess.cpp:
- WebProcess/soup/WebProcessSoup.cpp:
- 10:34 PM Changeset in webkit [144421] by
-
- 3 edits in trunk/Tools
Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
https://bugs.webkit.org/show_bug.cgi?id=111142
Reviewed by Adam Barth.
Merged _run_single_test into _run_tests_set. The code looks much cleaner now.
Also removed _print_status since it's never used anywhere.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.run):
(PerfTestsRunner._run_tests_set):
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(MainTest.run_test):
(MainTest.test_run_test_set):
(MainTest.test_run_test_set_kills_drt_per_run):
(MainTest.test_run_test_set_for_parser_tests):
- 10:28 PM Changeset in webkit [144420] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium gardening
https://bugs.webkit.org/show_bug.cgi?id=111141
- platform/chromium/TestExpectations:
- 10:24 PM Changeset in webkit [144419] by
-
- 11 edits in trunk/Source/WebCore
[V8] Added V8CustomIndexedGetter to IDLs that correspond to existing custom indexedPropertyGetter.
https://bugs.webkit.org/show_bug.cgi?id=110852
Patch by Koji Hara <kojih@chromium.org> on 2013-02-28
Reviewed by Kentaro Hara.
Add V8CustomIndexedGetter attribute that indicates the interface have custom implementation of a getter of indexed properties.
(Also added to the wiki)
https://trac.webkit.org/wiki/WebKitIDL#V8CustomIndexedGetter
Add V8CustomIndexedGetter to IDLs that correspond to existing custom indexedPropertyGetter.
We want to clean up CodeGeneratorV8.pm.
The problem is that all implementations of indexed properties and named properties are currently delegated to custom bindings.
We want to auto-generate as much code as possible.
As a starting point, this commit assures a interface has [V8CustomIndexedGetter] ==> there's custom implementation of indexed getter.
No test. Simple refactoring.
- bindings/scripts/IDLAttributes.txt: Add V8CustomIndexedGetter attribute.
- dom/NamedNodeMap.idl: Add V8CustomIndexedGetter attribute.
- html/HTMLAppletElement.idl: Add V8CustomIndexedGetter attribute.
- html/HTMLEmbedElement.idl: Add V8CustomIndexedGetter attribute.
- html/HTMLFormElement.idl: Add V8CustomIndexedGetter attribute.
- html/HTMLObjectElement.idl: Add V8CustomIndexedGetter attribute.
- html/HTMLOptionsCollection.idl: Add V8CustomIndexedGetter attribute.
- html/HTMLSelectElement.idl: Add V8CustomIndexedGetter attribute.
- page/DOMWindow.idl: Add V8CustomIndexedGetter attribute.
- storage/Storage.idl: Add V8CustomIndexedGetter attribute.
- 10:23 PM Changeset in webkit [144418] by
-
- 2 edits in branches/chromium/1410/Source/WebCore
Merge 144161
Web Inspector: timeline stops working on certain sites
https://bugs.webkit.org/show_bug.cgi?id=110955
Reviewed by Alexander Pavlov.
Analysis: "timerId" value is number,
so it is not wrapped to node as expected.
Solution: wrap values of all types except Node.
- inspector/front-end/TimelinePresentationModel.js:
Wrap nonstring values to text nodes.
TBR=eustas@chromium.org
Review URL: https://codereview.chromium.org/12389044
- 10:07 PM Changeset in webkit [144417] by
-
- 3 edits in trunk/Source/WebCore
Heap-use-after-free in WebCore::AudioNodeInput::updateInternalBus
https://bugs.webkit.org/show_bug.cgi?id=108542
Replace the wrong AudioNodeOutput::bus() usage out of safe peroid,
which causes this issue.
Reviewed by Chris Rogers.
- Modules/webaudio/AudioNodeInput.cpp:
(WebCore::AudioNodeInput::numberOfChannels):
- Modules/webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::bus):
- 9:59 PM Changeset in webkit [144416] by
-
- 11 edits in branches/safari-536.29-branch
Merge r141486
2013-01-30 Brian Weinstein <bweinstein@apple.com>
Add a call to the page UI client to determine if a plug-in should load
https://bugs.webkit.org/show_bug.cgi?id=108407
<rdar://problem/13066332>
Source/WebKit2:
Reviewed by Anders Carlsson.
This patch adds a client call to the WKPageUIClient to be called to determine
whether or not a plug-in should load.
- UIProcess/API/C/WKPage.h: Add shouldLoadPlugin.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): Moved from WebProcessProxy, and added a call to
m_uiClient.shouldInstantiatePlugin.
- UIProcess/WebPageProxy.h:
- UIProcss/WebPageProxy.messages.in: Moved GetPluginPath from WebProcessProxy to WebPageProxy.
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::getPluginPath): Moved to WebPageProxy.
- UIProcess/WebProcessProxy.h:
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::shouldInstantiatePlugin): Return that we should load the plug-in if
the client function isn't defined, and call the function if it is.
- UIProcess/WebUIClient.h:
- UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage): Add an entry for the new
client function.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): Send the message to the WebPageProxy, not the WebProcessProxy. (WebKit::WebPage::canPluginHandleResponse): Made a member function, so it can call sendSync, and
send the message to the WebPageProxy, not the WebProcessProxy.
- WebProcess/WebPage/WebPage.h:
Tools:
Add entries for the new function in the necessary structs.
Reviewed by Anders Carlsson.
- MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions):
- 9:46 PM Changeset in webkit [144415] by
-
- 3 edits in trunk/Tools
Disable window occlusion detection for WebKitTestRunner Web View on Mac
https://bugs.webkit.org/show_bug.cgi?id=111116
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-02-28
Reviewed by Simon Fraser.
Window occlusion notifications were causing WebKitTestRunner's Web View
to be detected as occluded and causing a few JavaScript timer layout
tests to fail. https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
by initializing the page visibility to "visible" after creating the view.
But a better solution is to disable window occlusion detection, so that
not only the page but also the view is treated as visible.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions): Remove call to
setVisibilityState, since it is no longer necessary.
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView): Disable window occlusion
detection for the created WKView.
- 9:41 PM Changeset in webkit [144414] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening for some inspector tests
https://bugs.webkit.org/show_bug.cgi?id=111131
Unreviewed gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-02-28
- platform/efl-wk1/TestExpectations:
- 9:03 PM Changeset in webkit [144413] by
-
- 5 edits in trunk
Unreviewed, rolling out r144370.
http://trac.webkit.org/changeset/144370
https://bugs.webkit.org/show_bug.cgi?id=111136
Caused 21 assertion failure at DocumentLoader.cpp(436)
(Requested by toyoshim on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-28
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::decrementActiveParserCount):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoading):
(WebCore::DocumentLoader::checkLoadComplete):
LayoutTests:
- platform/mac/TestExpectations:
- 8:40 PM Changeset in webkit [144412] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, chromium gardening; update expected image for Snow Leopard
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- platform/chromium/TestExpectations:
- 8:39 PM Changeset in webkit [144411] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Refactoring : Fix indentation and braces in WebInspectorClient.h|cpp
https://bugs.webkit.org/show_bug.cgi?id=109925
Patch by Seokju Kwon <Seokju Kwon> on 2013-02-28
Reviewed by Benjamin Poulain.
The contents of an outermost namespace block should not be indented.
And One-line control clauses should not use braces.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::closeInspectorFrontend):
- WebProcess/WebCoreSupport/WebInspectorClient.h:
(WebCore):
- 8:37 PM Changeset in webkit [144410] by
-
- 4 edits in trunk
[chromium] Events can't be triggered on MediaStreamTrack
https://bugs.webkit.org/show_bug.cgi?id=110930
Reviewed by Kentaro Hara.
Source/WebCore:
Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#mediastreamtrack
ended event handler should be triggered, when stop() is called.
No new tests because the test fast/mediastream/MediaStreamTrack.html
had covered it already.
- platform/mediastream/chromium/MediaStreamCenterChromium.cpp:
(WebCore::MediaStreamCenterChromium::didStopLocalMediaStream):
Tools:
Related code was moved to MediaStreamCenterChromium::didStopLocalMediaStream
- DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
(WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
- 8:18 PM Changeset in webkit [144409] by
-
- 4 edits in trunk/Source/WebKit2
Add a pre-bootstrap message for NetworkProcess XPC service
https://bugs.webkit.org/show_bug.cgi?id=111127
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-02-28
Reviewed by Sam Weinig.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
(WebKit::XPCServiceEventHandler): Hold on to the pre-bootstrap message.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler): Ditto.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService): Send a pre-bootstrap message for NetworkProcess
XPC service.
- 7:35 PM Changeset in webkit [144408] by
-
- 5 edits3 adds in trunk/Source
WebKit API for enabling DOM logging for certain worlds
https://bugs.webkit.org/show_bug.cgi?id=110779
Source/WebCore:
Patch by Ankur Taly <ataly@google.com> on 2013-02-28
Reviewed by Adam Barth.
Adds additional static methods to DOMWrapperWorld for managing the
mapping between worldIDs and logger objects (where DOM logging messages
are sent), and also defines a class (V8DOMActivityLogger) for logger
objects.
- WebCore.gypi:
- bindings/v8/DOMWrapperWorld.cpp:
(WebCore):
(WebCore::domActivityLoggers):
(WebCore::DOMWrapperWorld::setDOMActivityLogger):
(WebCore::DOMWrapperWorld::getDOMActivityLogger):
- bindings/v8/DOMWrapperWorld.h:
(DOMWrapperWorld):
- bindings/v8/V8DOMActivityLogger.h: Added.
(WebCore):
(V8DOMActivityLogger):
(WebCore::V8DOMActivityLogger::~V8DOMActivityLogger):
(WebCore::V8DOMActivityLogger::log):
Source/WebKit/chromium:
Patch by Ankur Taly <ataly@google.com> on 2013-02-28
Reviewed by Adam Barth.
This patch adds initial plumbing for enabling logging of DOM
activity by JavaScript code running withing v8, on a
per-world basis. In particular it adds methods to the chromium
WebKit API for associating a logger object with world ids for which
DOM activity logging is enabled.
- WebKit.gyp:
- public/WebDOMActivityLogger.h: Added.
(v8):
(WebKit):
(WebDOMActivityLogger):
(WebKit::WebDOMActivityLogger::~WebDOMActivityLogger):
(WebKit::WebDOMActivityLogger::log):
- src/WebDOMActivityLogger.cpp: Added.
(WebKit):
(DOMActivityLoggerContainer):
(WebKit::DOMActivityLoggerContainer::DOMActivityLoggerContainer):
(WebKit::DOMActivityLoggerContainer::~DOMActivityLoggerContainer):
(WebKit::DOMActivityLoggerContainer::log):
(WebKit::hasDOMActivityLogger):
(WebKit::setDOMActivityLogger):
- 6:12 PM Changeset in webkit [144407] by
-
- 4 edits in trunk/Source/WebCore
The threaded HTML parser shouldn't need to invalidate the speculation buffer on every document.write
https://bugs.webkit.org/show_bug.cgi?id=111130
Reviewed by Eric Seidel.
Previously, the threaded HTML parser always invalidated its speculation
buffer when it received a document.write. That means we performed
poorly on web sites that contained document.write calls early in the
page.
This patch teaches the HTMLDocumentParser that we don't need to discard
the speculation buffer in the common case of starting and ending in the
DataState.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::checkForSpeculationFailure):
(WebCore::HTMLDocumentParser::didFailSpeculation):
- html/parser/HTMLDocumentParser.h:
(WebCore):
(ParsedChunk):
- 6:11 PM Changeset in webkit [144406] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Rebaselines for Win decorations-with-text-combine.html
Unreviewed expectations update.
- platform/chromium-win-xp/fast/text/decorations-with-text-combine-expected.png:
- platform/chromium-win/fast/text/decorations-with-text-combine-expected.png:
- 5:58 PM Changeset in webkit [144405] by
-
- 4 edits3 adds in trunk
WebInspector: Switch hide element shortcut in ElementsPanel to use a selector
https://bugs.webkit.org/show_bug.cgi?id=110641
Patch by Eberhard Graether <egraether@google.com> on 2013-02-28
Reviewed by Pavel Feldman.
This change switches the shortcut for adding visibility:hidden to an element's style
to toggling a class name on the element and injecting a style rule into the element's
document instead. This way it is possible to change the visibility of all child
elements as well.
Test: inspector/elements/hide-shortcut.html
Source/WebCore:
- inspector/front-end/CSSStyleModel.js:
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._onkeydown):
(WebInspector.ElementsTreeOutline.prototype.resolvedNode.toggleClassAndInjectStyleRule):
(WebInspector.ElementsTreeOutline.prototype.):
(WebInspector.ElementsTreeOutline.prototype._toggleHideShortcut):
LayoutTests:
- inspector/elements/hide-shortcut-expected.txt: Added.
- inspector/elements/hide-shortcut.html: Added.
- inspector/elements/resources/hide-shortcut-iframe.html: Added.
- 5:53 PM Changeset in webkit [144404] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Build break with --no-web-audio and --no-video
https://bugs.webkit.org/show_bug.cgi?id=111055
Unreviewed build fix.
- platform/graphics/gstreamer/GStreamerUtilities.cpp:
- 5:51 PM Changeset in webkit [144403] by
-
- 4 edits in trunk
[EFL] Focus problem in inspector/extensions/extensions-panel.html
https://bugs.webkit.org/show_bug.cgi?id=97077
Patch by Seokju Kwon <Seokju Kwon> on 2013-02-28
Reviewed by Laszlo Gombos.
Source/WebKit/efl:
- WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorFrontendClientEfl::bringToFront): Set focus on inspectorView.
LayoutTests:
Remove inspector/extensions/extensions-panel.html from TestExpectations.
- platform/efl-wk1/TestExpectations:
- 5:50 PM Changeset in webkit [144402] by
-
- 2 edits in trunk/Source/WebCore
Implement the memory report on IPP FFTFrame on Web Audio
https://bugs.webkit.org/show_bug.cgi?id=111039
Reviewed by Yury Semikhatsky.
Covered by existing test.
- platform/audio/FFTFrame.cpp:
(WebCore::FFTFrame::reportMemoryUsage):
- 5:32 PM Changeset in webkit [144401] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG CFA should not do liveness pruning
https://bugs.webkit.org/show_bug.cgi?id=111119
Reviewed by Mark Hahnenberg.
It adds complexity and probably buys nothing. Moreover, I'm transitioning to having
liveness only available at the bitter end of compilation, so this will stop working
after https://bugs.webkit.org/show_bug.cgi?id=109389 anyway.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::mergeStateAtTail):
- 5:24 PM Changeset in webkit [144400] by
-
- 3 edits2 adds in trunk
Stale FrameSelection in removed iframe causes crash
https://bugs.webkit.org/show_bug.cgi?id=108696
Reviewed by Ryosuke Niwa.
Source/WebCore:
Catching a specific issue where selectFrameElementInParentIfFullySelected in a nested
iFrame that is removed can leave the outer frame's selection referencing stale nodes.
Instead, in this case, we keep the frame alive long enough to check for this condition
and clear our selection if we hit it.
Test: editing/selection/selection-in-iframe-removed-crash.html
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):
LayoutTests:
- editing/selection/selection-in-iframe-removed-crash-expected.txt: Added.
- editing/selection/selection-in-iframe-removed-crash.html: Added.
- 5:01 PM Changeset in webkit [144399] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. AppleWin VS2010 build fix.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 4:50 PM Changeset in webkit [144398] by
-
- 4 edits in trunk/Tools
[chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
https://bugs.webkit.org/show_bug.cgi?id=111017
Reviewed by Adam Barth.
This decouples DumpRenderTree from WebLayerTreeViewClient.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHostDRTLayerTreeViewClient):
(WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
(WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
(WebViewHostDRTLayerTreeViewClient::Layout):
(WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
(WebViewHost::initializeLayerTreeView):
- DumpRenderTree/chromium/WebViewHost.h:
(webkit_support):
(WebViewHost):
- 4:47 PM Changeset in webkit [144397] by
-
- 18 edits in trunk/Source
Need API to control page underlay color
https://bugs.webkit.org/show_bug.cgi?id=110918
Patch by Conrad Shultz <Conrad Shultz> on 2013-02-28
Reviewed by Simon Fraser.
Source/WebCore:
- page/ChromeClient.h:
(ChromeClient):
Declare underlayColor().
- platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::setUpOverhangAreasLayerContents):
Have setUpOverhangAreasLayerContents() take a background color parameter.
- platform/mac/ScrollbarThemeMac.h:
(ScrollbarThemeMac):
Ditto.
- platform/mac/ScrollbarThemeMac.mm:
Include ColorMac.h.
(WebCore::ScrollbarThemeMac::setUpOverhangAreasLayerContents):
Use the passed-in background color, if valid, for the overhang area layer.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Get the underlay color from the chrome client and pass it into setUpOverhangAreasLayerContents().
Source/WebKit2:
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
Encode underlayColor.
(WebKit::WebPageCreationParameters::decode):
Decode underlayColor.
- Shared/WebPageCreationParameters.h:
(WebPageCreationParameters):
Add underlayColor member.
- UIProcess/API/mac/WKView.mm:
(-[WKView underlayColor]):
Accessor; retrieves the WebCore::Color from the WebPageProxy and converts it to an NSColor.
(-[WKView setUnderlayColor:]):
Mutator; converts the NSColor to a WebCore::Color and passes it to the WebPageProxy.
- UIProcess/API/mac/WKViewPrivate.h:
Add underlayColor @property.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setUnderlayColor):
Mutator; dispatches SetUnderlayColor to WebPage.
(WebKit::WebPageProxy::creationParameters):
Set the parameters' underlayColor member appropriately.
- UIProcess/WebPageProxy.h:
Declare new member functions and variable.
(WebKit::WebPageProxy::underlayColor):
Accessor.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::underlayColor):
Return the associated WebPage's underlayColor.
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
Declare underlayColor().
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Apply any underlayColor that was supplied as part of the WebPageCreationParameters.
- WebProcess/WebPage/WebPage.h:
Declare new member functions and variable.
(WebKit::WebPage::underlayColor):
Accessor.
- WebProcess/WebPage/WebPage.messages.in:
Add SetUnderlayColor message.
- 4:46 PM Changeset in webkit [144396] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Rebaselines for Mac decorations-with-text-combine.html
Unreviewed expectations update.
- platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.png:
- platform/chromium-mac/fast/text/decorations-with-text-combine-expected.png:
- 4:42 PM Changeset in webkit [144395] by
-
- 3 edits in trunk/Source/WebCore
RelevantRepaintedObjects heuristic should ensure there is some coverage in the
bottom half of the relevant view rect
https://bugs.webkit.org/show_bug.cgi?id=111124
-and corresponding-
<rdar://problem/12257164>
Reviewed by Simon Fraser.
We need two Regions now -- one for the top and another for the bottom. Make sure
we have at least half of our desired coverage in both.
- page/Page.cpp:
(WebCore::Page::resetRelevantPaintedObjectCounter):
(WebCore::Page::addRelevantRepaintedObject):
(WebCore::Page::reportMemoryUsage):
- page/Page.h:
- 4:30 PM Changeset in webkit [144394] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Skip storage tests on Windows.
- platform/win/TestExpectations:
- 4:29 PM Changeset in webkit [144393] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r185341. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-28
- DEPS:
- 4:21 PM Changeset in webkit [144392] by
-
- 2 edits in trunk/Source/WebCore
WebSpeech: support pitch change
https://bugs.webkit.org/show_bug.cgi?id=107348
Reviewed by Beth Dakin.
Implement a policy for the Mac synthesizer to convert from the utterance's pitch rate
to something sensible for the platform.
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper initWithSpeechSynthesizer:WebCore::]):
(-[WebSpeechSynthesisWrapper convertPitchToNSSpeechValue:]):
(-[WebSpeechSynthesisWrapper updateBasePitchForSynthesizer]):
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
- 4:19 PM Changeset in webkit [144391] by
-
- 2 edits in trunk/Tools
Unreviewed, add my secondary email address to the list.
- Scripts/webkitpy/common/config/committers.py:
- 4:03 PM Changeset in webkit [144390] by
-
- 2 edits in trunk/Source/WebKit2
Add the notion of an allowed connection to SessionStorageNamespace
https://bugs.webkit.org/show_bug.cgi?id=111122
Reviewed by Sam Weinig.
Group together each session storage namespace with an allowed connection.
This will help ensure that rouge web processes will not be able to access session storage
from pages in other processes.
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::allowedConnection):
(WebKit::StorageManager::SessionStorageNamespace::create):
(WebKit::StorageManager::SessionStorageNamespace::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::setAllowedConnection):
Add an m_allowedConnection member variable, as well as setters and getters.
(WebKit::StorageManager::createSessionStorageNamespace):
Take an optional allowed connection. (It can be null if the process has not finished launching).
(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnection):
New function to set the allowed connection for a session storage namespace.
(WebKit::StorageManager::createStorageArea):
Add another FIXME.
(WebKit::StorageManager::createSessionStorageNamespaceInternal):
Pass the connection to the SessionStorageNamespace constructor.
(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnectionInternal):
Set the allowed connection.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Pass the connection to createSessionStorageNamespace.
(WebKit::WebPageProxy::connectionWillOpen):
Call setAllowedSessionStorageNamespaceConnection.
(WebKit::WebPageProxy::connectionWillClose):
Call setAllowedSessionStorageNamespaceConnection with a null connection.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connectionWillOpen):
Call connectionWillOpen on all pages.
(WebKit::WebProcessProxy::connectionWillClose):
Call connectionWillClose on all pages.
- 3:59 PM Changeset in webkit [144389] by
-
- 3 edits in trunk/Source/WebKit2
Add private API to disable WKView window occlusion detection
https://bugs.webkit.org/show_bug.cgi?id=111107
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-02-28
Reviewed by Simon Fraser.
- UIProcess/API/mac/WKView.mm:
(-[WKView _enableWindowOcclusionNotifications]): Check if occlusion
detection is enabled before enabling notifications.
(windowBecameOccluded): Ditto before changing window occlusion state.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
Initialize occlusion detection enabled flag to "YES".
(-[WKView windowOcclusionDetectionEnabled]):
(-[WKView setWindowOcclusionDetectionEnabled:]):
- UIProcess/API/mac/WKViewPrivate.h:
- 3:54 PM Changeset in webkit [144388] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Bindings test results update after r144376.
- bindings/scripts/test/JS/JSTestObj.cpp:
- 3:52 PM Changeset in webkit [144387] by
-
- 2 edits in trunk/Tools
Add Philip Rogers as a reviewer.
Unreviewed update of committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 3:43 PM Changeset in webkit [144386] by
-
- 6 edits in trunk/Source/WebKit2
Add the notion of an allowed connection to SessionStorageNamespace
https://bugs.webkit.org/show_bug.cgi?id=111122
Reviewed by Sam Weinig.
Group together each session storage namespace with an allowed connection.
This will help ensure that rouge web processes will not be able to access session storage
from pages in other processes.
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::allowedConnection):
(WebKit::StorageManager::SessionStorageNamespace::create):
(WebKit::StorageManager::SessionStorageNamespace::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::setAllowedConnection):
Add an m_allowedConnection member variable, as well as setters and getters.
(WebKit::StorageManager::createSessionStorageNamespace):
Take an optional allowed connection. (It can be null if the process has not finished launching).
(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnection):
New function to set the allowed connection for a session storage namespace.
(WebKit::StorageManager::createStorageArea):
Add another FIXME.
(WebKit::StorageManager::createSessionStorageNamespaceInternal):
Pass the connection to the SessionStorageNamespace constructor.
(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnectionInternal):
Set the allowed connection.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Pass the connection to createSessionStorageNamespace.
(WebKit::WebPageProxy::connectionWillOpen):
Call setAllowedSessionStorageNamespaceConnection.
(WebKit::WebPageProxy::connectionWillClose):
Call setAllowedSessionStorageNamespaceConnection with a null connection.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connectionWillOpen):
Call connectionWillOpen on all pages.
(WebKit::WebProcessProxy::connectionWillClose):
Call connectionWillClose on all pages.
- 3:38 PM Changeset in webkit [144385] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. AppleWin Build fix.
- WebCore.vcproj/WebCore.vcproj:
- 3:37 PM Changeset in webkit [144384] by
-
- 2 edits in trunk/LayoutTests
Add a flaky failure expectation to http/tests/inspector/resource-tree/resource-request-content-while-loading.html
on all platforms per bug 111123.
- 3:33 PM Changeset in webkit [144383] by
-
- 7 edits in trunk/LayoutTests
Unreviewed, rebaselining fast/forms/date-appearance/basic.html for chromium.
- platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium/TestExpectations:
- 3:30 PM Changeset in webkit [144382] by
-
- 6 edits2 adds1 delete in trunk/LayoutTests
Unreviewed, rebaselining media/track/track-cue-rendering-vertical.html on chromium
- platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Removed.
- platform/chromium-mac-lion/media/track/track-cue-rendering-vertical-expected.png: Added.
- platform/chromium-mac-lion/media/track/track-cue-rendering-vertical-expected.txt: Added.
- platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:
- platform/chromium/TestExpectations:
- 3:25 PM Changeset in webkit [144381] by
-
- 4 edits in trunk/Source/WebCore
[V8] Remove the world->isMainWorld() check from minorGCPrologue()
https://bugs.webkit.org/show_bug.cgi?id=111114
Reviewed by Adam Barth.
A couple of weeks ago, I introduced the following check to minorGCPrologue() in r142419.
void minorGCPrologue() {
A minor GC can handle the main world only.
DOMWrapperWorld* world = worldForEnteredContextWithoutContextCheck();
if (world && world->isMainWorld()) {
MinorGCWrapperVisitor visitor(isolate);
v8::V8::VisitHandlesForPartialDependence(isolate, &visitor);
visitor.notifyFinished();
}
}
- The check makes no sense. A GC should not care about what world we are in.
There is no concept of worlds in GC.
- worldForEnteredContextWithoutContextCheck() returns 0 for the main world.
So if a GC runs in the main world, the minor DOM GC is skipped.
- worldForEnteredContextWithoutContextCheck() caused a Chromium crash
(https://code.google.com/p/chromium/issues/detail?id=177587)
We should remove the check.
No tests. No change in behavior.
- bindings/v8/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::getWorld):
- bindings/v8/V8Binding.h:
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::minorGCPrologue):
- 3:24 PM Changeset in webkit [144380] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, updating chromium TestExpectations to remove passing tests.
- platform/chromium/TestExpectations:
- 3:23 PM Changeset in webkit [144379] by
-
- 2 edits in trunk/Source/JavaScriptCore
Don't try to emit profiling if you don't have the DFG JIT.
Rubber stamped by Mark Hahnenberg.
- jit/JIT.h:
(JSC::JIT::shouldEmitProfiling):
- 3:17 PM Changeset in webkit [144378] by
-
- 12 edits in trunk/Source/WebCore
Create GraphicsContext3DState to aggregate state objects
https://bugs.webkit.org/show_bug.cgi?id=110817
Reviewed by Kenneth Russell.
Aggregate context state-related objects on a GraphicsContext3DState
struct, in a similar fashion as GraphicsContext does. This is useful to
avoid duplicated values for platform-specific initialization lists.
No behavior changes, thus covered by existing tests.
- platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::GraphicsContext3DState::GraphicsContext3DState):
(GraphicsContext3DState):
(GraphicsContext3D):
Moved m_boundFBO, m_activeTexture and m_boundTexture0 to GraphicsContext3DState.
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::reshapeFBOs):
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::readPixels):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteTexture):
- platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::reshapeFBOs):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::createOffscreenBuffers):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebuffer):
(WebCore::GraphicsContext3D::GraphicsContext3D):
Removed initialization list values not needed anymore and reassigned
calls to m_boundFBO, m_boundTexture0 and m_activeTexture to m_state
respectives.
- 3:06 PM Changeset in webkit [144377] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix. A merge error led to a duplication of a single line.
Just removing the duplicate line.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createLocalTransformState):
- 2:57 PM Changeset in webkit [144376] by
-
- 18 edits2 adds4 deletes in trunk
Notification.requestPermission callback should be optional
https://bugs.webkit.org/show_bug.cgi?id=108196
Reviewed by Kentaro Hara.
Spec says it should be optional.
http://notifications.spec.whatwg.org/#notification
Source/WebCore:
Test: fast/notifications/notifications-request-permission-optional.html
- GNUmakefile.list.am:
- Modules/notifications/Notification.h:
(Notification):
- Modules/notifications/Notification.idl:
- Modules/notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::NotificationRequestCallback::timerFired):
- Modules/notifications/NotificationCenter.h:
(NotificationCenter):
- Modules/notifications/NotificationCenter.idl:
- Target.pri:
- UseJSC.cmake:
- UseV8.cmake:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDesktopNotificationsCustom.cpp: Removed.
- bindings/js/JSNotificationCustom.cpp: Removed.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/v8/custom/V8NotificationCenterCustom.cpp: Removed.
- bindings/v8/custom/V8NotificationCustom.cpp: Removed.
LayoutTests:
- fast/notifications/notifications-request-permission-optional-expected.txt: Added.
- fast/notifications/notifications-request-permission-optional.html: Added.
- 2:54 PM Changeset in webkit [144375] by
-
- 3 edits in trunk
Underline should round to match other content.
https://bugs.webkit.org/show_bug.cgi?id=111005
Patch by Ben Wagner <bungeman@chromium.org> on 2013-02-28
Reviewed by Stephen White.
Test: fast/text/decorations-with-text-combine.html
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLineForText):
Round (instead of floor) underlines to match other content.
- 2:51 PM Changeset in webkit [144374] by
-
- 2 edits in trunk/Source/WebCore
Refine Ryosuke's r144367 fix.
Rubber-stamped by Ryosuke Niwa.
- page/PageGroup.cpp:
(WebCore::PageGroup::captionPreferences):
- 2:48 PM Changeset in webkit [144373] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG Phantom node should be honest about the fact that it can exit
https://bugs.webkit.org/show_bug.cgi?id=111115
Reviewed by Mark Hahnenberg.
The chances of this having cause serious issues are low, since most clients of the
NodeDoesNotExit flag run after CFA and CFA updates this properly. But one possible
case of badness is if the ByteCodeParser inserted a Phantom with a type check in
between a LogicalNot and a Branch; then that peephole optimization in Fixup might
go slightly wrong.
- dfg/DFGNodeType.h:
(DFG):
- 2:46 PM Changeset in webkit [144372] by
-
- 5 edits in trunk/Source/WebCore
Windows build fix.
Removing ENABLE(BLOB) checks that I added in bug 111100. Many, many more are needed
to cleanly disable blob code.
- platform/network/BlobData.h:
- platform/network/BlobRegistryImpl.cpp:
- platform/network/BlobRegistryImpl.h:
- platform/network/BlobStorageData.h:
- 2:33 PM Changeset in webkit [144371] by
-
- 2 edits in tags/Safari-537.32/Source/WebKit2
Merged r144324. <rdar://problem/13264712>
- 2:33 PM Changeset in webkit [144370] by
-
- 4 edits in trunk
Threaded HTML parser hits ASSERTION FAILED: this == frameLoader()->activeDocumentLoader()
https://bugs.webkit.org/show_bug.cgi?id=110937
Reviewed by Adam Barth.
Remove the #ifdef guards added to work around this ASSERT.
This was fixed by https://bugs.webkit.org/show_bug.cgi?id=110951
as now DocumentLoader::checkLoadComplete() will ignore the call
if the DocumentLoader is not the active document loader for the Document.
- dom/Document.cpp:
(WebCore::Document::decrementActiveParserCount):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoading):
(WebCore::DocumentLoader::checkLoadComplete):
- 2:08 PM Changeset in webkit [144369] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Rollout r144366.
- 2:06 PM Changeset in webkit [144368] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Move html5linb tests to be Slow rather than Timeout
Unreviewed expectations. Requested by Eric Seidel.
- platform/chromium/TestExpectations:
- 2:02 PM Changeset in webkit [144367] by
-
- 2 edits in trunk/Source/WebCore
Revert an erroneous change in r144336.
Rubber-stamped by Eric Carlson.
- page/PageGroup.cpp:
(WebCore::PageGroup::captionPreferences):
- 2:01 PM Changeset in webkit [144366] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Give Damian Committer privs.
- 1:57 PM Changeset in webkit [144365] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add casts in DFGGPRInfo.h to suppress warnings
https://bugs.webkit.org/show_bug.cgi?id=111104
Reviewed by Filip Pizlo.
With certain flags on, we get compiler warnings on ARM. We should do the proper casts to make these warnings go away.
- dfg/DFGGPRInfo.h:
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):
- 1:52 PM Changeset in webkit [144364] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for Windows. Make sure the new bits are unsigned and not bools.
- rendering/RenderBlock.h:
- 1:52 PM Changeset in webkit [144363] by
-
- 3 edits in trunk/Tools
Merge more methods on PerfTest
https://bugs.webkit.org/show_bug.cgi?id=111030
Reviewed by Dirk Pranke.
Merged parse_output into _run_with_driver as it was the only caller. Also merged _should_ignore_line_in_stderr
and _should_ignore_line_in_parser_test_result into _filter_output since it was their only caller.
This makes the control flow a lot more comprehensible.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest._run_with_driver):
(PerfTest._should_ignore_line):
(PerfTest._filter_output):
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTest._assert_results_are_correct):
(test_ignored_stderr_lines):
- 1:51 PM Changeset in webkit [144362] by
-
- 16 edits in trunk/Source/JavaScriptCore
It should be easy to determine if a DFG node exits forward or backward when doing type checks
https://bugs.webkit.org/show_bug.cgi?id=111102
Reviewed by Mark Hahnenberg.
This adds a NodeExitsForward flag, which tells you the exit directionality of
type checks performed by the node. Even if you convert the node to a Phantom
and use the Edge UseKind for type checks, you'll still get the same exit
directionality that the original node would have wanted.
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGArrayifySlowPathGenerator.h:
(JSC::DFG::ArrayifySlowPathGenerator::ArrayifySlowPathGenerator):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::checkArray):
- dfg/DFGNode.h:
(Node):
(JSC::DFG::Node::setOpAndDefaultNonExitFlags):
(JSC::DFG::Node::convertToPhantom):
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::nodeFlagsAsString):
- dfg/DFGNodeFlags.h:
(DFG):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::backwardSpeculationCheck):
(DFG):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::backwardTypeCheck):
(JSC::DFG::SpeculativeJIT::typeCheck):
(JSC::DFG::SpeculativeJIT::forwardTypeCheck):
(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateIntegerOperand::gpr):
(SpeculateIntegerOperand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::fpr):
(SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateCellOperand::gpr):
(SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
(JSC::DFG::SpeculateBooleanOperand::gpr):
(SpeculateBooleanOperand):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
- 1:48 PM Changeset in webkit [144361] by
-
- 2 edits in trunk/Tools
Update my IRC nick
Unreviewed.
- Scripts/webkitpy/common/config/committers.py:
- 1:45 PM Changeset in webkit [144360] by
-
- 4 edits2 adds in trunk
Meta referrer isn't honored for window.open
https://bugs.webkit.org/show_bug.cgi?id=111076
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/referrer-policy-window-open.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::urlSelected): loadFrameRequest() will set the correct referrer
(WebCore::createWindow): This code is required for the inspector which doesn't set the referrer
- page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow):
LayoutTests:
- http/tests/security/referrer-policy-window-open-expected.txt: Added.
- http/tests/security/referrer-policy-window-open.html: Added.
- 1:37 PM Changeset in webkit [144359] by
-
- 2 edits in trunk/Source/WebCore
[texmap] Remove redundant defines on TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=111090
Reviewed by Antonio Gomes.
driverSupportsSubImage() already uses OpenGL ES defines to return
correct support, thus no need for these additional defines.
No behavior changes, thus covered by existing tests.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
- 1:35 PM Changeset in webkit [144358] by
-
- 28 edits3 adds in trunk/Source
EXT_draw_buffers needs implementation
https://bugs.webkit.org/show_bug.cgi?id=109331
Reviewed by Kenneth Russell.
Source/Platform:
Add EXT_draw_buffers support for chromium port.
- chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::drawBuffersEXT):
Source/WebCore:
This patch adds support for EXT_draw_buffers for WebGL.
mac OpenGL port is passing khronos WebGL conformance test with this patch. OpenGL ES port implementation isn't added in this patch.
Also, it has the WebKit side support for chromium port, but pending command buffer implementation.
Besides the basic extension implementation, we also added drawBuffers() wrapper to work around a mac driver bug: i.e., do not enable a buffer if there is no attachment added.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/v8/V8Binding.h:
(WebCore):
(WebCore::toInt32):
(WebCore::toUInt32):
(WebCore::toFloat):
(WebCore::toInt64):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- html/canvas/EXTDrawBuffers.cpp: Added.
(WebCore):
(WebCore::EXTDrawBuffers::EXTDrawBuffers):
(WebCore::EXTDrawBuffers::~EXTDrawBuffers):
(WebCore::EXTDrawBuffers::getName):
(WebCore::EXTDrawBuffers::create):
(WebCore::EXTDrawBuffers::supported):
(WebCore::EXTDrawBuffers::drawBuffersEXT):
- html/canvas/EXTDrawBuffers.h: Added.
(WebCore):
(EXTDrawBuffers):
- html/canvas/EXTDrawBuffers.idl: Added.
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::drawBuffers):
(WebCore):
(WebCore::WebGLFramebuffer::drawBuffersIfNecessary):
- html/canvas/WebGLFramebuffer.h:
(WebGLFramebuffer):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateFramebufferFuncParameters):
(WebCore::WebGLRenderingContext::getMaxDrawBuffers):
(WebCore::WebGLRenderingContext::getMaxColorAttachments):
- html/canvas/WebGLRenderingContext.h:
(WebCore):
(WebGLRenderingContext):
- platform/chromium/support/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::drawBuffersEXT):
(WebCore):
- platform/graphics/Extensions3D.h:
(Extensions3D):
- platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::getClearBitsByAttachmentType):
- platform/graphics/chromium/Extensions3DChromium.h:
(Extensions3DChromium):
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension):
(WebCore::Extensions3DOpenGL::drawBuffersEXT):
(WebCore):
- platform/graphics/opengl/Extensions3DOpenGL.h:
(Extensions3DOpenGL):
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::ensureEnabled):
- platform/graphics/opengl/Extensions3DOpenGLCommon.h:
(Extensions3DOpenGLCommon):
- platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::drawBuffersEXT):
(WebCore):
(WebCore::Extensions3DOpenGLES::supportsExtension):
- platform/graphics/opengl/Extensions3DOpenGLES.h:
(Extensions3DOpenGLES):
- 1:32 PM Changeset in webkit [144357] by
-
- 2 edits2 adds in trunk/LayoutTests
[EFL][WebGL] Enable compositing/webgl/webgl-reflection.html.
https://bugs.webkit.org/show_bug.cgi?id=110688
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-28
Reviewed by Laszlo Gombos.
This patch adds platform specific test expectation files for the
test and enables it for efl port.
- platform/efl/TestExpectations:
- platform/efl/compositing/webgl/webgl-reflection-expected.png: Added.
- platform/efl/compositing/webgl/webgl-reflection-expected.txt: Added.
- 1:31 PM Changeset in webkit [144356] by
-
- 2 edits in trunk/Source/JavaScriptCore
CodeBlock::valueProfile() has a bogus assertion
https://bugs.webkit.org/show_bug.cgi?id=111106
<rdar://problem/13131427>
Reviewed by Mark Hahnenberg.
This was just a bad assertion: m_bytecodeOffset == -1 means that the value profile is constructed but not initialized.
ValueProfile constructs itself in a safe way; you can call any method you want on a constructed but not initialized
ValueProfile. CodeBlock first constructs all ValueProfiles (by growing the ValueProfile vector) and then initializes
their m_bytecodeOffset later. This is necessary because the initialization is linking bytecode instructions to their
ValueProfiles, so at that point we don't want the ValueProfile vector to resize, which implies that we want all of
them to already be constructed. A GC can happen during this phase, and the GC may want to walk all ValueProfiles.
This is safe, but one of the ValueProfile getters (CodeBlock::valueProfile()) was asserting that any value profile
you get has had its m_bytecodeOffset initialized. This need not be the case and nothing will go wrong if it isn't.
The solution is to remove the assertion, which I believe was put there to ensure that my m_valueProfiles refactoring
a long time ago was sound: it used to be that a ValueProfile with m_bytecodeOffset == -1 was an argument profile; now
all argument profiles are in m_argumentValueProfiles instead. I think it's safe to say that this refactoring was done
soundly since it was a long time ago. So we should kill the assertion - I don't see an easy way to make the assertion
sound with respect to the GC-during-CodeBlock-construction issue, and I don't believe that the assertion is buying us
anything at this point.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::valueProfile):
- 1:30 PM Changeset in webkit [144355] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Maintain the directionality of the selection after modifying the selection using key events.
https://bugs.webkit.org/show_bug.cgi?id=111078
Reviewed by Yong Li.
PR 295224.
When using the key navigation to modify the selection, reset the
directionality of the selection to the original to prevent
changing the anchor.
Reviewed Internally by Nima Ghanavatian.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
- 1:08 PM Changeset in webkit [144354] by
-
- 2 edits in trunk/Source/WebCore
Create BlobRegistry through a strategy
https://bugs.webkit.org/show_bug.cgi?id=111100
Chromium build fix.
- platform/network/BlobRegistry.cpp: Use destructor for chromium too.
- 1:04 PM Changeset in webkit [144353] by
-
- 21 edits1 add in trunk/Source/WebCore
Create BlobRegistry through a strategy
https://bugs.webkit.org/show_bug.cgi?id=111100
Reviewed by Sam Weinig.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj: Added BlobRegistry.cpp.
- WebCore.exp.in:
- loader/LoaderStrategy.cpp: (WebCore::LoaderStrategy::createBlobRegistry):
- loader/LoaderStrategy.h: Addxed a function to create BlobRegistry, with default implementation being in-process WebKit1 one.
- platform/network/BlobData.h: Added ENABLE(BLOB).
- platform/network/BlobRegistry.cpp: Added. Moved singleton to a separate file.
- platform/network/BlobRegistry.h: Made destructor non-inline. Cleaned up includes.
- platform/network/BlobRegistryImpl.cpp:
- platform/network/BlobRegistryImpl.h: Cleaned up includes, made functions that are only called through base class private. Added ENABLE(BLOB).
- platform/network/BlobStorageData.h: Added ENABLE(BLOB).
- platform/network/FormData.cpp: (WebCore::appendBlobResolved): Check blob registry type before upcasting. It's a public function, and we should not depend on high level understanding of process model to prove that the cast is safe.
- platform/network/ResourceHandle.cpp:
- platform/network/cf/FormDataStreamCFNet.cpp:
- platform/network/mac/ResourceHandleMac.mm: Cleaned up includes.
- 12:59 PM Changeset in webkit [144352] by
-
- 12 edits in trunk
REGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type=date] unexpectedly makes another line for ::-webkit-calendar-picker-indicator
https://bugs.webkit.org/show_bug.cgi?id=110974
Reviewed by Kentaro Hara.
Source/WebCore:
Input elements with the multiple fields UI require flexible box
layout.
- If display:inline or display:inline-block is specified, we replace it with display:inline-flex.
- If display:block is specified, we replace it with display:flex.
- If other display value is specified, we use it as is, but it won't wrap inside an input element because we have display:inline-block for ::-webkit-calendar-pixker-indicaotor.
r144184 was incomplete. It avoided the wrapping issue, but it
didn't make spin buttons and calendar arrows right-aligned.
Tests: Update fast/forms/date/date-apparance-basic.html
- css/html.css:
(input::-webkit-calendar-picker-indicator):
Add display:inline-block in orde to avoid line-wrapping.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::customStyleForRenderer):
Move the code to BaseMultipleFieldsDateAndTimeInputType::customStyleForRenderer.
- html/InputType.cpp:
(WebCore::InputType::customStyleForRenderer): Added.
- html/InputType.h:
(InputType): Add customStyleForRenderer, and remove
shouldApplyLocaleDirection.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::customStyleForRenderer):
Moved the code from HTMLInputElement::customStyleForRenderer, and
add display property updatting code.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
Add customStyleForRenderer, and remove shouldApplyLocaleDirection.
LayoutTests:
- fast/forms/date/date-appearance-basic-expected.txt:
- fast/forms/date/date-appearance-basic.html:
- platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium/TestExpectations:
- 12:51 PM Changeset in webkit [144351] by
-
- 7 edits in trunk/Source
Implement more StorageAreaProxy member functions
https://bugs.webkit.org/show_bug.cgi?id=111103
Reviewed by Sam Weinig.
Source/WebCore:
Export two more StorageMap symbols required by WebKit2.
- WebCore.exp.in:
Source/WebKit2:
- Shared/SecurityOriginData.cpp:
(WebKit::SecurityOriginData::securityOrigin):
- Shared/SecurityOriginData.h:
Add helper to create a WebCore::SecurityOrigin from a SecurityOriginData object.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::key):
Fill the storage map and call through to StorageMap::key.
(WebKit::StorageAreaProxy::contains):
Fill the storage map and call through to StorageMap::contains.
(WebKit::StorageAreaProxy::memoryBytesUsedByCache):
Return 0; this matches StorageAreaImpl.
- 12:38 PM Changeset in webkit [144350] by
-
- 28 edits2 adds in trunk
Focus ring for a child layer is incorrectly offset by ancestor composited layer's position
https://bugs.webkit.org/show_bug.cgi?id=110895
Reviewed by Simon Fraser.
Source/WebCore:
Test: compositing/sub-layer-focus-ring.html
The problem occurs in RenderBlock::addFocusRingRects() where the absolute position of a sub-layer is used to calculate the focus ring rect of the layer.
Should use the relative position to the current paintContainer instead.
To fix the issue:
- RenderLayer passes LayerPaintingInfo.rootLayer to PaintInfo.paintContainer
- Let RenderObject::paintFocusRing() and RenderObject::paintOutline() take PaintInfo instead of GraphicsContext* so that the paintContainer can be passed
- RenderBlock::addFocusRingRects() uses localToContainerPoint(FloatPoint(), paintContainer) instead of localToAbsolute() to calculate the focus ring rect of a sublayer.
- rendering/PaintInfo.h:
(WebCore):
(WebCore::PaintInfo::PaintInfo): Add a field paintContainer (the RenderLayerModelObject which originates the current painting)
(PaintInfo):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::addFocusRingRects): Use the added paintContainer parameter to calculate the relative offset of the child layer.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintBackgroundForFragments): Pass LayerPaintingInfo.rootLayer to PaintInfo.paintContainer.
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase): Ditto.
(WebCore::RenderLayer::paintOutlineForFragments): Ditto.
(WebCore::RenderLayer::paintMaskForFragments): Ditto.
- rendering/RenderLayer.cpp:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing): Now takes PaintInfo instead of GraphicsContext*. Pass paintInfo.paintContainer to addFocusRingRects().
(WebCore::RenderObject::paintOutline): Now takes PaintInfo instead of GraphicsContext*.
(WebCore::RenderObject::absoluteFocusRingQuads):
- rendering/RenderObject.h:
(WebCore::RenderObject::addFocusRingRects): Add paintContainer parameter.
LayoutTests:
New ref test for the bug.
- compositing/sub-layer-focus-ring-expected.html: Added.
- compositing/sub-layer-focus-ring.html: Added.
- 12:31 PM Changeset in webkit [144349] by
-
- 3 edits in trunk/LayoutTests
Re-baselining expected pixels for fast/borders/border-radius-percent.html on linux
https://bugs.webkit.org/show_bug.cgi?id=110889
Unreviewed
- TestExpectations:
- platform/chromium-linux/fast/borders/border-radius-percent-expected.png:
- 12:18 PM Changeset in webkit [144348] by
-
- 2 edits in tags/Safari-537.31.11/Source/WebCore
Merged r143684. <rdar://problem/13315270>
- 12:15 PM Changeset in webkit [144347] by
-
- 3 edits in tags/Safari-537.31.11/Source/WebCore
Merged r143680. <rdar://problem/13315270>
- 12:13 PM Changeset in webkit [144346] by
-
- 2 edits in trunk/Source/WTF
Crash in JSC::MarkedBlock::FreeList JSC::MarkedBlock::sweepHelper
https://bugs.webkit.org/show_bug.cgi?id=111059
Reviewed by Ryosuke Niwa.
Sometimes C++'s implicit operator conversion rules suck.
Add explicit operator== and !=.
- wtf/FastMalloc.cpp:
(WTF::HardenedSLL::operator!=):
(WTF::HardenedSLL::operator==):
(HardenedSLL):
- 12:09 PM Changeset in webkit [144345] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening, update expectation
- platform/chromium/TestExpectations: Add Win modifier for compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html
and remove modifiers for fast/forms/textarea/textarea-state-restore.html
- 11:59 AM Changeset in webkit [144344] by
-
- 5 edits in trunk/Source/WebCore
Remove the quirk margin bits from RenderObject and put them back in RenderBlock.
https://bugs.webkit.org/show_bug.cgi?id=111089
Reviewed by Dan Bernstein.
This patch removes the marginBeforeQuirk and marginAfterQuirk bits from RenderObject
and puts them into RenderBlock instead. I also did some renaming and clean-up after
moving them, e.g., to hasMarginBeforeQuirk and hasMarginAfterQuirk.
Even though it's pretty irrelevant, I also made the code writing-mode-correct so that
the correct child margin quirk is propagated across differing writing mode
boundaries.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::marginBeforeEstimateForChild):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::handleAfterSideOfBlock):
(WebCore::RenderBlock::hasMarginBeforeQuirk):
(WebCore):
(WebCore::RenderBlock::hasMarginAfterQuirk):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::setHasMarginBeforeQuirk):
(WebCore::RenderBlock::setHasMarginAfterQuirk):
(RenderBlock):
(WebCore::RenderBlock::hasMarginBeforeQuirk):
(WebCore::RenderBlock::hasMarginAfterQuirk):
(MarginInfo):
(WebCore::RenderBlock::MarginInfo::setHasMarginBeforeQuirk):
(WebCore::RenderBlock::MarginInfo::setHasMarginAfterQuirk):
(WebCore::RenderBlock::MarginInfo::hasMarginBeforeQuirk):
(WebCore::RenderBlock::MarginInfo::hasMarginAfterQuirk):
- rendering/RenderObject.h:
(RenderObject):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(RenderObjectBitfields):
- rendering/style/RenderStyle.h:
- 11:55 AM Changeset in webkit [144343] by
-
- 2 edits in trunk/LayoutTests
Remove these supressions now that we've reverted http://trac.webkit.org/changeset/144126.
- platform/chromium/TestExpectations:
- 11:48 AM Changeset in webkit [144342] by
-
- 8 edits in tags/Safari-537.31.11/Source/WebKit2
Merged r144217. <rdar://problem/13229828>
- 11:46 AM Changeset in webkit [144341] by
-
- 15 edits2 adds2 deletes in trunk
Unreviewed, rolling out r144126 and r144176.
http://trac.webkit.org/changeset/144126
http://trac.webkit.org/changeset/144176
https://bugs.webkit.org/show_bug.cgi?id=111096
Caused fast/notifications/notifications-request-
permission.html to crash (Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-28
Source/WebCore:
- GNUmakefile.list.am:
- Modules/notifications/Notification.h:
(Notification):
- Modules/notifications/Notification.idl:
- Target.pri:
- UseJSC.cmake:
- UseV8.cmake:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSNotificationCustom.cpp: Added.
(WebCore):
(WebCore::JSNotification::requestPermission):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/v8/custom/V8NotificationCustom.cpp: Added.
(WebCore):
(WebCore::V8Notification::requestPermissionMethodCustom):
LayoutTests:
- fast/notifications/notifications-request-permission-optional-expected.txt: Removed.
- fast/notifications/notifications-request-permission-optional.html: Removed.
- 11:45 AM Changeset in webkit [144340] by
-
- 6 edits in trunk/Source/JavaScriptCore
DFG CFA should leave behind information in Edge that says if the Edge's type check is proven to succeed
https://bugs.webkit.org/show_bug.cgi?id=110840
Reviewed by Mark Hahnenberg.
This doesn't add any observable functionality to the compiler, yet. But it does give
every phase that runs after CFA the ability to know, in O(1) time, whether an edge
will need to execute a type check.
- dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::filterEdgeByUse):
(JSC::DFG::AbstractState::filterByType):
- dfg/DFGCommon.cpp:
(WTF):
(WTF::printInternal):
- dfg/DFGCommon.h:
(JSC::DFG::isProved):
(DFG):
(JSC::DFG::proofStatusForIsProved):
(WTF):
- dfg/DFGEdge.cpp:
(JSC::DFG::Edge::dump):
- dfg/DFGEdge.h:
(JSC::DFG::Edge::Edge):
(JSC::DFG::Edge::setNode):
(JSC::DFG::Edge::useKindUnchecked):
(JSC::DFG::Edge::setUseKind):
(Edge):
(JSC::DFG::Edge::proofStatusUnchecked):
(JSC::DFG::Edge::proofStatus):
(JSC::DFG::Edge::setProofStatus):
(JSC::DFG::Edge::isProved):
(JSC::DFG::Edge::needsCheck):
(JSC::DFG::Edge::shift):
(JSC::DFG::Edge::makeWord):
- 11:43 AM Changeset in webkit [144339] by
-
- 3 edits1 copy2 deletes in tags/Safari-537.31.11/Source/WebKit2
Merged r144217. <rdar://problem/13229828>
- 11:40 AM Changeset in webkit [144338] by
-
- 3 edits3 adds in trunk
Source/WebCore: Crash in CachedRawResource::responseReceived().
https://bugs.webkit.org/show_bug.cgi?id=110482
Reviewed by Adam Barth.
Test: http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::responseReceived):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=110482
Reviewed by Adam Barth.
- http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt: Added.
- http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt: Added.
- 11:37 AM Changeset in webkit [144337] by
-
- 2 edits in trunk/Source/WTF
Enable DFG JIT for Qt on Mac
https://bugs.webkit.org/show_bug.cgi?id=111095
Rubber-stamped by Simon Hausmann
- wtf/Platform.h:
- 11:35 AM Changeset in webkit [144336] by
-
- 6 edits in trunk/Source
[Mac] use HAVE() macro instead of version check
https://bugs.webkit.org/show_bug.cgi?id=111087
Reviewed by Dean Jackson.
Source/WebCore:
No new tests, covered by existing tests.
- page/CaptionUserPreferencesMac.h: Use HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK).
- page/CaptionUserPreferencesMac.mm: Ditto.
(WebCore::CaptionUserPreferencesMac::CaptionUserPreferencesMac): Ditto.
(WebCore::CaptionUserPreferencesMac::~CaptionUserPreferencesMac): Ditto.
- page/PageGroup.cpp:
(WebCore::PageGroup::captionPreferences): Ditto.
Source/WTF:
- wtf/Platform.h: Define HAVE_MEDIA_ACCESSIBILITY_FRAMEWORK.
- 11:33 AM Changeset in webkit [144335] by
-
- 7 edits2 adds in trunk
WebSpeech: support the boundary event
https://bugs.webkit.org/show_bug.cgi?id=107350
Reviewed by Beth Dakin.
Source/WebCore:
Generate boundary events for speech synthesis and have them fire the appropriate events.
This implements for the Mac platform, as well as simulating these events in the mock
synthesizer for testing purposes.
Test: platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events.html
- Modules/speech/SpeechSynthesis.cpp:
(WebCore):
(WebCore::SpeechSynthesis::boundaryEventOccurred):
- Modules/speech/SpeechSynthesis.h:
(SpeechSynthesis):
- platform/PlatformSpeechSynthesizer.h:
(WebCore):
(PlatformSpeechSynthesizerClient):
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speechSynthesizer:willSpeakWord:ofString:]):
- platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::speak):
LayoutTests:
- platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events-expected.txt: Added.
- platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events.html: Added.
- 11:23 AM Changeset in webkit [144334] by
-
- 2 edits in tags/Safari-537.31.11/Source/WebCore
Merged r142958. <rdar://problem/13237306>
- 11:16 AM Changeset in webkit [144333] by
-
- 2 edits in trunk/Source/WebKit2
PDFPlugin: PDF orientation isn't respected when printing or print-previewing
https://bugs.webkit.org/show_bug.cgi?id=110925
<rdar://problem/13008621>
Reviewed by Alexey Proskuryakov.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::drawPDFPage): Teach drawPDFPage about PDFPage's rotation property, and use it
to swap the PDF's cropbox. Painting now matches PDFViewController's historical behavior.
- 11:11 AM Changeset in webkit [144332] by
-
- 4 edits in trunk/Source/WebKit/chromium
Add new webkit API to invoke a context menu.
https://bugs.webkit.org/show_bug.cgi?id=111040
Patch by Varun Jain <varunjain@chromium.org> on 2013-02-28
Reviewed by Adam Barth.
- public/WebView.h:
(WebView):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::showContextMenu):
(WebKit):
- src/WebViewImpl.h:
- 11:06 AM Changeset in webkit [144331] by
-
- 2 edits in trunk/LayoutTests
This timeout also happens in Release.
- platform/chromium/TestExpectations:
- 11:04 AM Changeset in webkit [144330] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Histogram all exits from IDBBackingStore::open
https://bugs.webkit.org/show_bug.cgi?id=110677
Reviewed by Tony Chang.
No tests because this only changes logging code.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::open):
- 11:03 AM Changeset in webkit [144329] by
-
- 4 edits in tags/Safari-537.31.11/Source
Versioning.
- 11:00 AM Changeset in webkit [144328] by
-
- 15 edits6 copies in trunk/Source
Factor SourceBuffer methods out of MediaSourcePrivate & WebMediaSource
into SourceBufferPrivate & WebSourceBuffer respectively.
https://bugs.webkit.org/show_bug.cgi?id=110798
Reviewed by Adam Barth, Jer Noble.
Source/WebCore:
No new tests. No user visible behavior has changed.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::addSourceBuffer):
(WebCore::MediaSource::removeSourceBuffer):
- Modules/mediasource/MediaSource.h:
(MediaSource):
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::create):
(WebCore):
(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::buffered):
(WebCore::SourceBuffer::setTimestampOffset):
(WebCore::SourceBuffer::append):
(WebCore::SourceBuffer::abort):
(WebCore::SourceBuffer::removedFromMediaSource):
(WebCore::SourceBuffer::isRemoved):
(WebCore::SourceBuffer::isOpen):
(WebCore::SourceBuffer::isEnded):
- Modules/mediasource/SourceBuffer.h:
(WebCore):
(SourceBuffer):
- Modules/mediasource/SourceBufferList.cpp:
(WebCore::SourceBufferList::SourceBufferList):
(WebCore::SourceBufferList::remove):
(WebCore::SourceBufferList::clear):
- Modules/mediasource/SourceBufferList.h:
(SourceBufferList):
- html/HTMLMediaElement.cpp:
- platform/graphics/MediaSourcePrivate.h:
(WebCore):
(MediaSourcePrivate):
- platform/graphics/SourceBufferPrivate.h:
(WebCore):
(SourceBufferPrivate): Contains methods extracted from MediaPlayerPrivate.
(WebCore::SourceBufferPrivate::SourceBufferPrivate):
(WebCore::SourceBufferPrivate::~SourceBufferPrivate):
Source/WebKit/chromium:
- WebKit.gyp:
- public/WebMediaSourceClient.h:
(WebKit):
(WebMediaSourceClient):
- public/WebSourceBuffer.h:
(WebKit):
(WebSourceBuffer): Contains SourceBuffer methods extracted from WebMediaSource.
(WebKit::WebSourceBuffer::~WebSourceBuffer):
- src/AssertMatchingEnums.cpp:
- src/MediaSourcePrivateImpl.cpp:
(WebKit):
(WebKit::MediaSourcePrivateImpl::MediaSourcePrivateImpl):
(WebKit::MediaSourcePrivateImpl::addSourceBuffer):
(WebKit::MediaSourcePrivateImpl::duration):
(WebKit::MediaSourcePrivateImpl::setDuration):
(WebKit::MediaSourcePrivateImpl::endOfStream):
- src/MediaSourcePrivateImpl.h:
(WebKit):
(MediaSourcePrivateImpl): Adapts MediaSourcePrivate interface to WebMediaSourceClient.
(WebKit::MediaSourcePrivateImpl::~MediaSourcePrivateImpl):
- src/SourceBufferPrivateImpl.cpp:
(WebKit):
(WebKit::SourceBufferPrivateImpl::SourceBufferPrivateImpl):
(WebKit::SourceBufferPrivateImpl::buffered):
(WebKit::SourceBufferPrivateImpl::append):
(WebKit::SourceBufferPrivateImpl::abort):
(WebKit::SourceBufferPrivateImpl::setTimestampOffset):
(WebKit::SourceBufferPrivateImpl::removedFromMediaSource):
- src/SourceBufferPrivateImpl.h:
(WebKit):
(SourceBufferPrivateImpl): Adapts SourceBufferPrivate interface to WebSourceBuffer.
(WebKit::SourceBufferPrivateImpl::~SourceBufferPrivateImpl):
- src/WebMediaPlayerClientImpl.cpp:
(WebMediaSourceClientImpl):
(WebKit):
(WebSourceBufferImpl): Temporary implementation of WebSourceBuffer to keep things working
until the Chromium side changes land.
(WebKit::WebMediaSourceClientImpl::addSourceBuffer):
(WebKit::WebMediaSourceClientImpl::duration):
(WebKit::WebMediaSourceClientImpl::setDuration):
(WebKit::WebMediaSourceClientImpl::endOfStream):
(WebKit::WebSourceBufferImpl::WebSourceBufferImpl):
(WebKit::WebSourceBufferImpl::buffered):
(WebKit::WebSourceBufferImpl::append):
(WebKit::WebSourceBufferImpl::abort):
(WebKit::WebSourceBufferImpl::setTimestampOffset):
(WebKit::WebSourceBufferImpl::removedFromMediaSource):
- src/WebMediaSourceImpl.cpp:
- 10:55 AM Changeset in webkit [144327] by
-
- 1 copy in tags/Safari-537.31.11
New Tag.
- 10:53 AM Changeset in webkit [144326] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Handle Set-Cookie immediately even when loading is deferred
https://bugs.webkit.org/show_bug.cgi?id=111083
Patch by Joe Mason <jmason@rim.com> on 2013-02-28
Reviewed by Yong Li.
Internal PR: 298805
Internally Reviewed By: Leo Yang
Handle Set-Cookie headers immediately, even if loading is being deferred, since any request
created while loading is deferred should include all cookies received. (This especially
affects Set-Cookie headers sent with a 401 response - often this causes an auth dialog to be
opened, which defers loading, but the followup request using the credentials from the dialog
needs to include the cookie.)
This is safe because handleSetCookieHeader only updates the cookiejar, it doesn't call back
into the loader.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyHeadersReceived):
(WebCore::NetworkJob::handleNotifyHeaderReceived):
- 10:51 AM Changeset in webkit [144325] by
-
- 4 edits in trunk/Source
Versioning.
- 10:16 AM Changeset in webkit [144324] by
-
- 2 edits in trunk/Source/WebKit2
Don't install unused XPCServices on Lion
<rdar://problem/13264712>
Rubber-stamped by Anders Carlsson
- Configurations/BaseXPCService.xcconfig:
- 10:11 AM Changeset in webkit [144323] by
-
- 7 edits1 add in trunk/Source
IndexedDB: IO error when checking schema should destroy LevelDB directory
https://bugs.webkit.org/show_bug.cgi?id=110675
Reviewed by Adam Barth.
Source/WebCore:
Also some refactoring to remove IDBBackingStore's dependence on
static LevelDBDatabase methods. This facilitated the unit test.
New unit test - IDBIOErrorTest.CleanUpTest
- Modules/indexeddb/IDBBackingStore.cpp:
(DefaultLevelDBFactory):
Wraps the previous behavior.
(WebCore::IDBBackingStore::open):
The default parameter provides the previous behavior, which is what
non-tests want.
- Modules/indexeddb/IDBBackingStore.h:
- platform/leveldb/LevelDBDatabase.h:
Source/WebKit/chromium:
- WebKit.gyp:
This was cargo-culted. The component build wouldn't run otherwise.
- WebKit.gypi:
- tests/IDBCleanupOnIOErrorTest.cpp: Added.
- 10:00 AM Changeset in webkit [144322] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r144157.
http://trac.webkit.org/changeset/144157
https://bugs.webkit.org/show_bug.cgi?id=110794
It broke chromium windows build
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructor):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorMethodCustom):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):
- 9:19 AM Changeset in webkit [144321] by
-
- 2 edits in branches/chromium/1410/Source/WebKit/chromium
Merge 143917
[Chromium] Disable registerProtocolHandler on Android
https://bugs.webkit.org/show_bug.cgi?id=110481
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-25
Reviewed by Julien Chaffraix.
Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't
actually wired up internally. Disable the feature to avoid breaking feature detection until
we can implement it properly. Previous attempt is at http://trac.webkit.org/changeset/133465
See the discussion of the future implementation at http://crbug.com/156386
- features.gypi: Disable the flag for Android, enable it only for non-Android platforms.
- src/ChromeClientImpl.h: Declaration is now guarded by the flag, not to break Android.
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12382019
- 9:16 AM Changeset in webkit [144320] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking one more html5 test as timeout
Unreviewed expectations, removing a Debug modifier.
- platform/chromium/TestExpectations:
- 9:16 AM Changeset in webkit [144319] by
-
- 2 edits in trunk/Source/WebKit2
BUILD FIX (r144221): SetSmartInsertDeleteEnabled should be wrapped in PLATFORM(MAC)
- WebProcess/WebPage/WebPage.messages.in: Move
SetSmartInsertDeleteEnabled from USE(APPKIT) to PLATFORM(MAC).
- 9:05 AM Changeset in webkit [144318] by
-
- 14 edits2 adds in trunk
[New Multicolumn] Rewrite the painting/stacking model to be spec compliant.
https://bugs.webkit.org/show_bug.cgi?id=110624.
Reviewed by Simon Fraser.
Source/WebCore:
This patch implements a new painting and hit testing model for columns that is
spec-compliant with Section 3.5 of the multicolumn specification, which states:
"All column boxes in a multi-column element are in the same stacking context and
the drawing order of their contents is as specified in CSS 2.1. Column boxes do
not establish new stacking contexts."
What this statement means is that you cannot paint a layer and all its stacking
context descendants in a strip in each column, since some of those descendants
might actually "break out" of the pagination (like fixed positioned descendants)
and overlap multiple columns. In addition clips may apply across pagination
boundaries, and any overlap caused by opacity has to do the right thing and
treat the paginated and unpaginated components together as a single unit.
The solution to this problem is to introduce the concept of a LayerFragment. Now
all layers when painting or hit testing compute a fragment list, and that list
is then walked in order to do painting and hit testing of layers. In the simple
unpaginated case, a layer has one LayerFragment, but in the case of columns the
layer may be broken up into multiple fragments representing boxes in separate
columns.
Much of this patch consists of refactoring all of the painting and hit testing
code to operate on these fragments.
Test: fast/multicol/mixed-positioning-stacking-order.html.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::collectLayerFragments):
This method is called by the RenderLayer code to fetch the layer fragments from
the regions of a flow thread. The flow thread just turns around and calls into
each of its regions one by one to get the fragments from each region.
(WebCore::RenderFlowThread::fragmentsBoundingBox):
A new function that collects LayerFragments and then determines the bounding
box that encloses all of the fragments.
- rendering/RenderFlowThread.h:
Declarations of the new methods for obtaining layer fragments and bounding
box information for fragments.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updatePagination):
RenderLayers now track an enclosing pagination layer. If this is set, then the layer knows it
needs to check with the enclosing pagination layer's flow thread renderer to
obtain layer fragments.
(WebCore::transparencyClipBox):
Modified to obtain a fragments bounding box so that opacity can operate correctly on
column boxes.
(WebCore::accumulateOffsetTowardsAncestor):
This method has been patched to allow for fixed positioned objects to escape
in-flow RenderFlowThreads. Our in-flow RenderFlowThreads behave differently from
CSS Regions flow threads in that they aren't necesssarily acting as the containing
block for all of their descendants. Content is allowed to "escape" from the flow
thread.
(WebCore::RenderLayer::collectFragments):
A new method that collects fragments from the flow thread and sets up the appropriate
clips and translations on each fragment.
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::paintBackgroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):
(WebCore::RenderLayer::paintOutlineForFragments):
(WebCore::RenderLayer::paintMaskForFragments):
(WebCore::RenderLayer::paintOverflowControlsForFragments):
Refactoring of painting to break all individual painting steps out into methods that walk over
fragment boxes. This actually had the side effect of making the main painting function,
paintLayerContents, much cleaner and easier to read. :)
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::createLocalTransformState):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestContentsForFragments):
(WebCore::RenderLayer::hitTestResizerInFragments):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::hitTestContents):
(WebCore::RenderLayer::hitTestList):
Refactoring of hit testing to break all individual hit testing steps out into methods that walk over
fragment boxes.
(WebCore::RenderLayer::backgroundClipRect):
Modified to avoid using the clip rects cache when crossing into different pagination contexts,
e.g., from unpaginated to paginated.
(WebCore::RenderLayer::intersectsDamageRect):
(WebCore::RenderLayer::boundingBox):
Modified boundingBox to work with fragments. A new flag is used to indicate whether or not
the bounds of fragments or the original unsplit box are being computed.
(WebCore::RenderLayer::collectLayers):
Fix layer collection so that in-flow RenderFlowThreads can still be collected, since in-flow
RenderFlowThreads do not establish stacking contexts.
- rendering/RenderLayer.h:
(WebCore::ClipRect::moveBy):
Added a moveBy method that just wrap the corresponding LayoutRect method.
(LayerFragment):
(WebCore::LayerFragment::LayerFragment):
(WebCore::LayerFragment::setRects):
(WebCore::LayerFragment::moveBy):
(WebCore::LayerFragment::intersect):
(WebCore::RenderLayer::enclosingPaginationLayer):
The new LayerFragment struct. Holds clips and translation information for each fragment box.
(WebCore::RenderLayer::isOutOfFlowRenderFlowThread):
Helper method for determining if the renderer is an out-of-flow RenderFlowThread.
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::createMultiColumnFlowThreadStyle):
Change the flow thread style to no longer establish a stacking context.
(WebCore::RenderMultiColumnBlock::layoutBlock):
Patched to move the flow thread to a position that allows it to be untranslated in the
initial column.
(WebCore):
- rendering/RenderMultiColumnBlock.h:
(RenderMultiColumnBlock):
layoutBlock is subclassed to tweak the flow thread's position.
- rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):
The flow thread for multi-column blocks implements collectLayerFragments to hand back LayerFragment
information based off its RenderMultiColumnSets.
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::paintObject):
Changed to no longer paint column contents, since the layer code is just doing that now.
(WebCore::RenderMultiColumnSet::collectLayerFragments):
The method that figures out what columns are intersected by a layer and hands back
initial fragment information.
- rendering/RenderMultiColumnSet.h:
(RenderMultiColumnSet):
Declaration of collectLayerFragments.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::container):
Patch container() to allow fixed positioned objects to escape in-flow RenderFlowThreads.
- rendering/RenderObject.h:
(WebCore::RenderObject::isInFlowRenderFlowThread):
(WebCore::RenderObject::isOutOfFlowRenderFlowThread):
Methods for distinguishing between in-flow and out-of-flow RenderFlowThreads.
(WebCore::RenderObject::canContainFixedPositionObjects):
Patch canContainFixedPositionObjects() to allow fixed positioned objects to escape
in-flow RenderFlowThreads.
- rendering/RenderRegion.h:
(WebCore::RenderRegion::collectLayerFragments):
(RenderRegion):
The virtual functions on Region for fragment collection.
LayoutTests:
- fast/multicol/mixed-positioning-stacking-order-expected.html: Added.
- fast/multicol/mixed-positioning-stacking-order.html: Added.
- 8:57 AM Changeset in webkit [144317] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Adding existing key in DOMStorageItemsView leaves it inconsistent state
https://bugs.webkit.org/show_bug.cgi?id=111061
Reviewed by Alexander Pavlov.
The view must be checked for all the rows with the matching keys. Only the first one would be updated
with the new value while the others must be removed from the grid. Also in case there are various key/value
pairs, the changed node should be selected and revealed in the grid.
No new tests as UI related minor change.
- inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype._domStorageItemUpdated):
- 8:41 AM Changeset in webkit [144316] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] User credentials is not correctly handled
https://bugs.webkit.org/show_bug.cgi?id=110994
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-02-28
Reviewed by Yong Li.
WTF::String::utf8 no longer receives a bool, see r134173.
- platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::encryptedString):
- 8:06 AM Changeset in webkit [144315] by
-
- 1 copy in tags/Safari-537.32
New Tag.
- 7:27 AM Changeset in webkit [144314] by
-
- 2 edits in branches/chromium/1425/Source/WebCore/bindings
Revert 144142
[V8] Remove Event::dataTransferAttrGetterCustom() and Event::valueAttrSetterCustom()
https://bugs.webkit.org/show_bug.cgi?id=110666
Reviewed by Adam Barth.
Event::dataTransferAttrGetterCustom() is not used
(i.e. the custom method is not registered to V8).
Event::valueAttrSetterCustom() is declared but not
implemented. We can remove them.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderCustomCall):
- bindings/v8/custom/V8EventCustom.cpp:
TBR=haraken@chromium.org
Review URL: https://codereview.chromium.org/12386021
- 7:26 AM Changeset in webkit [144313] by
-
- 3 edits in branches/chromium/1425/Source/WebCore/bindings
Revert 144157
[V8] Generate a wrapper function for named constructor callbacks
https://bugs.webkit.org/show_bug.cgi?id=110794
Reviewed by Adam Barth.
This would be the final step of generating wrapper functions.
The patch generates the following wrapper function for named
constructor callbacks.
Handle<Value> namedConstructorCallback(...)
{
return namedConstructor(...);
}
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructor):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::namedConstructor):
(WebCore::namedConstructorCallback):
(WebCore):
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::namedConstructor):
(WebCore::namedConstructorCallback):
(WebCore):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):
TBR=haraken@chromium.org
Review URL: https://codereview.chromium.org/12377018
- 7:25 AM Changeset in webkit [144312] by
-
- 3 edits in branches/chromium/1425/Source/WebCore/bindings/scripts
Revert 144194
[V8] Generate a wrapper function for ReplaceableAttrSetter()
https://bugs.webkit.org/show_bug.cgi?id=110781
Reviewed by Adam Barth.
This is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings. This patch introduces an indirection function
for xxxReplaceableAttrSetter(), like this:
For non-custom replaceable setters (Note: One implementation
is enough for all replaceable setters in one interface.)
void V8XXX:::ReplaceableAttrSetterCallback(...) {
V8XXX::ReplaceableAttrSetter(...);
}
For custom replaceable setters. (Note: This is treated as
a normal custom setter.)
void xxxAttrSetterCallback(...) {
return xxxAttrSetterCustom(...);
}
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateReplaceableAttrSetterCallback):
(GenerateReplaceableAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::TestObjReplaceableAttrSetterCallback):
(TestObjV8Internal):
(WebCore):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::TestTypedefsReplaceableAttrSetterCallback):
(TestTypedefsV8Internal):
TBR=haraken@chromium.org
Review URL: https://codereview.chromium.org/12389023
- 7:24 AM Changeset in webkit [144311] by
-
- 1 add in branches/chromium/1425/codereview.settings
for drovering
- 7:19 AM Changeset in webkit [144310] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=111058.
- platform/qt/TestExpectations: Skipped failing test after r144236.
- 7:17 AM Changeset in webkit [144309] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Disable auto-filling password in forms when auto-form-filling is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=111006
Internal PR: 295181
Internal reviewed by Joe Mason.
Reviewed by Yong Li.
Check WebSettings::isFormAutofillEnabled() before doing user credential form fill stuff.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
- 7:15 AM Changeset in webkit [144308] by
-
- 1 copy in branches/chromium/1425
brachning for 1425
- 7:14 AM Changeset in webkit [144307] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] User credentials are not correctly handled for non-browser usage
https://bugs.webkit.org/show_bug.cgi?id=111032
Internal PR: 295181
Internal reviewed by Joe Mason.
Reviewed by Yong Li.
Use encrypted password as binary data when calling SQLiteStatement::bindBlob(), in
stead of using it as a normal WTF::String.
No new tests as this causes no expected behaviour change.
- platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
- 7:03 AM Changeset in webkit [144306] by
-
- 3 edits in trunk/Tools
[Qt] Enable thin archives before parsing the project files
Rubber-stamped by Simon Hausmann.
The targetSubDir() function can be called before default_post.prf has been
parsed therefore the gnu_thin_archives option has to be set in default_pre.prf
which is parsed before the main project file.
This issue was revealed by r144299 and fixes the clean build.
- qmake/mkspecs/features/default_post.prf:
- qmake/mkspecs/features/default_pre.prf:
- 6:53 AM Changeset in webkit [144305] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: "loadScript" function to load scripts via xhr
https://bugs.webkit.org/show_bug.cgi?id=110879
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-28
Reviewed by Pavel Feldman.
Create an alias for "importScript" function and use it in those cases
which assume lazy script loading.
No new tests.
- inspector/front-end/Panel.js:
(WebInspector.PanelDescriptor.prototype.panel):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
- inspector/front-end/utilities.js:
- 6:43 AM Changeset in webkit [144304] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Move profiler tools into separate panels
https://bugs.webkit.org/show_bug.cgi?id=109832
Patch by Alexei Filippov <alph@chromium.org> on 2013-02-28
Reviewed by Yury Semikhatsky.
This is a first part of the fix that puts each profiler tool into a separate panel.
The fix introduces separate panels for each profiler type.
There are now six panel (including experimental):
- JS CPU profiler
- CSS Selector profiler
- JS Heap profiler
- Canvas profier
- Native memory snapshots
- Native memory distribution
The new functionality is put behind experimental flag.
- inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView):
(WebInspector.ProfileLauncherView.prototype.addProfileType):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader.prototype.view):
(WebInspector.ProfileHeader.prototype.createView):
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype._showProfile):
(WebInspector.ProfilesPanel.prototype._searchableViews):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
(WebInspector.ProfileGroupSidebarTreeElement):
(WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
(WebInspector.CPUProfilerPanel):
(WebInspector.CSSSelectorProfilerPanel):
(WebInspector.HeapProfilerPanel):
(WebInspector.CanvasProfilerPanel):
(WebInspector.MemoryChartProfilerPanel):
(WebInspector.NativeMemoryProfilerPanel):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/inspector.css:
(.toolbar-item.cpu-profiler .toolbar-icon):
(.toolbar-item.css-profiler .toolbar-icon):
(.toolbar-item.heap-profiler .toolbar-icon):
(.toolbar-item.canvas-profiler .toolbar-icon):
(.toolbar-item.memory-chart-profiler .toolbar-icon):
(.toolbar-item.memory-snapshot-profiler .toolbar-icon):
- inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
- 6:34 AM Changeset in webkit [144303] by
-
- 2 edits in trunk/Source/WebKit/chromium
RenderTableCellDeathTest unit test fails on mac
https://bugs.webkit.org/show_bug.cgi?id=110992
Unreviewed revert of all changes. The problem seems to have resolved.
- tests/RenderTableCellTest.cpp: Remove Mac disable code.
- 6:22 AM Changeset in webkit [144302] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, update expectation
- platform/chromium/TestExpectations: Add ImageOnlyFailure for compositing/rtl/rtl-iframe-fixed-overflow.html
- 6:16 AM Changeset in webkit [144301] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, quick test breakage fix for android
https://bugs.webkit.org/show_bug.cgi?id=110740
Patch by Seigo Nonaka <nona@chromium.org> on 2013-02-27
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputInfo): Reconstruct condition check order
- 5:57 AM Changeset in webkit [144300] by
-
- 4 edits in trunk
[Qt] Enable CANVAS_PATH flag
https://bugs.webkit.org/show_bug.cgi?id=108508
Reviewed by Simon Hausmann.
Tools:
Also enable CANVAS_PATH flag for Qt.
- qmake/mkspecs/features/features.pri:
LayoutTests:
Unskip CANVAS_PATH tests.
- platform/qt/TestExpectations:
- 5:41 AM Changeset in webkit [144299] by
-
- 3 edits in trunk/Tools
[Qt][TestWebKitAPI] The activeBuildConfig() function has been replaced with targetSubDir()
Rubber-stamped by Csaba Osztrogonác.
Besides suppressing a warning about the non-existing function this
fixes the build if there is a subdirectory (eg. debug-and-release).
- TestWebKitAPI/InjectedBundle.pri:
- TestWebKitAPI/TestWebKitAPI.pri:
- 5:05 AM Changeset in webkit [144298] by
-
- 2 edits in trunk/Source/WebCore
Add calendar header for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110967
Reviewed by Kent Tamura.
The calendar header showing the current month and containing navigation
buttons, which will be part of the new calendar picker (Bug 109439).
No new tests. Code is not yet used.
- Resources/pagepopups/calendarPicker.js:
(MonthPopupButton): Button that opens the month popup.
(MonthPopupButton.prototype._shouldUseShortMonth): Returns true if we should use the short month format in order to fit in the available width.
(MonthPopupButton.prototype.setCurrentMonth): Sets the month to the button label.
(MonthPopupButton.prototype.onClick): Dispatches buttonClick event which will tell the calendar picker to open the month popup.
(CalendarNavigationButton): A square button that fires repeatedly while the mouse is pressed down.
(CalendarNavigationButton.prototype.setDisabled):
(CalendarNavigationButton.prototype.onClick):
(CalendarNavigationButton.prototype.onMouseDown): Sets the timer to fire while the mouse is pressed down.
(CalendarNavigationButton.prototype.onWindowMouseUp):
(CalendarNavigationButton.prototype.onRepeatingClick):
(CalendarHeaderView): View containing month popup button and the navigation buttons.
(CalendarHeaderView.prototype.onCurrentMonthChanged): Sets the MonthPopupButton label and checks if the navigation buttons should be disabled.
(CalendarHeaderView.prototype.onNavigationButtonClick):
(CalendarHeaderView.prototype.setDisabled): Used to disable all the buttons while the month popup is open.
- 4:55 AM Changeset in webkit [144297] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r184931. Requested by
"Takashi Toyoshima" <toyoshim@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-28
- DEPS:
- 4:33 AM Changeset in webkit [144296] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/TestExpectations: Skipped failing test after r144265.
- 4:28 AM Changeset in webkit [144295] by
-
- 6 edits in trunk
Web Inspector: class console-formatted-string renamed to console-formatted- ?
https://bugs.webkit.org/show_bug.cgi?id=110881
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._renderPropertyPreview):
LayoutTests:
- http/tests/inspector/console-test.js:
(initialize_ConsoleTest.InspectorTest.dumpConsoleMessages):
- inspector/console/console-object-preview-expected.txt:
- inspector/console/console-object-preview.html:
- 4:28 AM Changeset in webkit [144294] by
-
- 2 edits in trunk/Tools
[EFL][WTR] WTR cannot load injected bundle
https://bugs.webkit.org/show_bug.cgi?id=111063
Reviewed by Csaba Osztrogonác.
WTR was not able to load injected bundle because of undefined
symbols for AccessibilityUIElement::scrollToMakeVisible().
Adding empty implementation of this function to AccessibilityUIElementAtk.cpp
solves the problem.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::scrollToMakeVisible):
- 4:26 AM Changeset in webkit [144293] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, update expectation
- platform/chromium/TestExpectations:
- 4:22 AM Changeset in webkit [144292] by
-
- 5 edits4 adds in trunk
XSSAuditor should strip formaction attributes from input and button elements.
https://bugs.webkit.org/show_bug.cgi?id=110975
Reviewed by Daniel Bates.
Source/WebCore:
The 'formaction' attribute of 'input' and 'button' elements is just as
dangerous as the 'action' attribute of 'form' elements. This patch
teaches the XSSAuditor how to avoid them.
Tests: http/tests/security/xssAuditor/formaction-on-button.html
http/tests/security/xssAuditor/formaction-on-input.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterStartToken):
(WebCore::XSSAuditor::filterInputToken): Added.
(WebCore::XSSAuditor::filterButtonToken): Added.
- html/parser/XSSAuditor.h:
Create filters for 'input' and 'button' elements, which currently
only have the effect of filtering the 'formaction' attribute.
LayoutTests:
- http/tests/security/xssAuditor/formaction-on-button-expected.txt: Added.
- http/tests/security/xssAuditor/formaction-on-button.html: Added.
- http/tests/security/xssAuditor/formaction-on-input-expected.txt: Added.
- http/tests/security/xssAuditor/formaction-on-input.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag.pl:
Support 'showFormaction' as a new option to write out formaction values.
- 4:08 AM Changeset in webkit [144291] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, clean up expectations to remove lint errors #1.
- platform/chromium/TestExpectations:
- 3:58 AM Changeset in webkit [144290] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r144169): It broke clipping
https://bugs.webkit.org/show_bug.cgi?id=111065
Reviewed by Noam Rosenthal.
The clipstack was not marked dirty when new clips were added
leading to clipping never being applied.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::ClipStack::push):
- 3:50 AM Changeset in webkit [144289] by
-
- 3 edits1 add in trunk/Source/WebCore
OpenCL implementation of FEImage SVG Filter.
https://bugs.webkit.org/show_bug.cgi?id=110752
Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-02-28
Reviewed by Zoltan Herczeg.
The result of the image is uploaded to an OpenCL buffer.
- Target.pri:
- platform/graphics/gpu/opencl/OpenCLFEImage.cpp: Added.
(WebCore):
(WebCore::FEImage::platformApplyOpenCL):
- svg/graphics/filters/SVGFEImage.h:
(FEImage):
- 3:35 AM Changeset in webkit [144288] by
-
- 5 edits2 adds in trunk
Web Inspector: Make it obvious where command line functions come from
https://bugs.webkit.org/show_bug.cgi?id=62367
Reviewed by Pavel Feldman.
Source/WebCore:
This patch adds a custom .toString() method on the various command-line
API methods that are bound in the inspector. Rather than dumping the
function text, we now model the response after that of native methods:
"function () { [Command Line API] }".
Test: inspector/console/console-native-function-to-string.html
- inspector/InjectedScriptSource.js:
Added a function to the CommandLineAPI constructor that creates a
custom toString() method for each command-line API method.
LayoutTests:
- inspector/console/console-native-function-to-string-expected.txt: Added.
- inspector/console/console-native-function-to-string.html: Added.
- 3:15 AM Changeset in webkit [144287] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviwed gardening. Skip test that made to crash other test.
- platform/qt-5.0-wk1/TestExpectations:
- 3:06 AM Changeset in webkit [144286] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, update test expectation
- platform/chromium/TestExpectations:
- 2:47 AM Changeset in webkit [144285] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
https://bugs.webkit.org/show_bug.cgi?id=111062
- platform/chromium/TestExpectations:
- 2:35 AM Changeset in webkit [144284] by
-
- 9 edits7 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Generating missing baselines for an octet of media tests and removing related expectations.
- platform/gtk/TestExpectations: Also removing expectation for
fast/multicol/newmulticol/column-rules-fixed-height.html, the test is now passing.
- platform/gtk/media/audio-controls-rendering-expected.png: Added.
- platform/gtk/media/audio-controls-rendering-expected.txt: Added.
- platform/gtk/media/controls-after-reload-expected.png: Added.
- platform/gtk/media/controls-after-reload-expected.txt:
- platform/gtk/media/controls-strict-expected.png: Added.
- platform/gtk/media/controls-strict-expected.txt:
- platform/gtk/media/controls-styling-strict-expected.txt:
- platform/gtk/media/controls-without-preload-expected.png: Added.
- platform/gtk/media/controls-without-preload-expected.txt:
- platform/gtk/media/video-controls-rendering-expected.png:
- platform/gtk/media/video-controls-rendering-expected.txt:
- platform/gtk/media/video-display-toggle-expected.png: Added.
- platform/gtk/media/video-display-toggle-expected.txt:
- platform/gtk/media/video-playing-and-pause-expected.png: Added.
- platform/gtk/media/video-playing-and-pause-expected.txt:
- 2:15 AM Changeset in webkit [144283] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- 2:07 AM Changeset in webkit [144282] by
-
- 2 edits in trunk/LayoutTests
Cleanup: XSSAuditor's form[action] tests should be manually executable.
https://bugs.webkit.org/show_bug.cgi?id=111049
Reviewed by Daniel Bates.
We currently check whether we're running in a DRT-like world before
creating user-visible output for XSSAuditor's form[action] tests. This
patch removes that restriction in order to allow manually-run tests
to show some reasonable output.
- http/tests/security/xssAuditor/resources/echo-intertag.pl:
Drop the 'if (window.testRunner)' from the 'showAction' branch in
order to allow manually running the test.
- 1:49 AM Changeset in webkit [144281] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=111054
- platform/chromium/TestExpectations:
- 1:41 AM Changeset in webkit [144280] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipped failing ref html tests.
- platform/qt/TestExpectations:
- 1:39 AM Changeset in webkit [144279] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt][Mac] Fix massive parallel builds
Reviewed by Tor Arne Vestbø.
There exists a race condition that LLIntDesiredOffsets.h is written to
by two parllel instances of the ruby script. This patch ensures that similar to the output file,
the generated file is also prefixed according to the build configuration.
- LLIntOffsetsExtractor.pro:
- 1:39 AM Changeset in webkit [144278] by
-
- 4 edits in trunk/Source/WebCore
ResourceRequestCFNet.cpp won't compile after r144216
<http://webkit.org/b/111034>
Reviewed by Alexey Proskuryakov.
- WebCore.exp.in: Move Mac-only symbol into !PLATFORM(IOS)
section. Update iOS-only symbol to add argument.
- platform/network/cf/ResourceRequest.h: Remove unused method
declaration.
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody): Fix typos.
Add static_cast<CFStringRef>().
(WebCore::ResourceRequest::doUpdateResourceHTTPBody): Fix another
typo.
- 1:33 AM Changeset in webkit [144277] by
-
- 3 edits in trunk/LayoutTests
Add a failing test expectation to navigation-should-abort.html on Mac WebKit1.
The failure is tracked by the bug 111052.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 1:32 AM Changeset in webkit [144276] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Misc build fixes
https://bugs.webkit.org/show_bug.cgi?id=110448
Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-28
Reviewed by Rob Buis.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
WebString was replaced with BlackBerry::Platform::String in r131316.
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
Some webdatabase APIs are encapuslated in DatabaseManager since r137520.
(BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):
Document::isPendingStyleRecalc() was renamed to hasPendingStyleRecalc() in r129844.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::updateFormState):
Add closing brace that was missing in r142482.
- 1:26 AM Changeset in webkit [144275] by
-
- 2 edits in trunk/Tools
[BlackBerry] TestRunnerBlackBerry: remove layerTreeAsText, it's gone from upstream
https://bugs.webkit.org/show_bug.cgi?id=110464
Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-28
Reviewed by Rob Buis.
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- 1:25 AM Changeset in webkit [144274] by
-
- 5 edits in trunk
[BlackBerry] DumpRenderTreeSupport: update the set position methods
https://bugs.webkit.org/show_bug.cgi?id=110578
Patch by Xan Lopez <xlopez@rim.com> on 2013-02-28
Reviewed by Rob Buis.
TestRunner::setMockGeolocationPosition() changed in r130416:
http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h
Source/WebKit/blackberry:
- WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::setMockGeolocationPosition):
- WebKitSupport/DumpRenderTreeSupport.h:
(DumpRenderTreeSupport):
Tools:
DumpRenderTreeSupport::setMockGeolocationError() was renamed to
setMockGeolocationPositionUnavailableError() in r129444:
http://trac.webkit.org/changeset/129444/trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::setMockGeolocationPosition):
(TestRunner::setMockGeolocationPositionUnavailableError):
- 1:17 AM Changeset in webkit [144273] by
-
- 2 edits in trunk/Tools
[BlackBerry] WorkQueueItemBlackBerry: use the new FrameLoader API
https://bugs.webkit.org/show_bug.cgi?id=110465
Patch by Xan Lopez <xlopez@rim.com> on 2013-02-28
Reviewed by Rob Buis.
- DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
(LoadItem::invoke):
- 1:12 AM Changeset in webkit [144272] by
-
- 2 edits in trunk/LayoutTests
A couple more tweaks to TestExpectations after the threaded parser.
- platform/chromium/TestExpectations:
- 12:56 AM Changeset in webkit [144271] by
-
- 8 edits in trunk
Unreviewed, rolling out r144184.
http://trac.webkit.org/changeset/144184
https://bugs.webkit.org/show_bug.cgi?id=110974
The change didn't fix all of the problems.
Source/WebCore:
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
LayoutTests:
- fast/forms/date/date-appearance-basic-expected.txt:
- fast/forms/date/date-appearance-basic.html:
- platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium/TestExpectations:
- 12:42 AM Changeset in webkit [144270] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, mark two tests as slow.
https://bugs.webkit.org/show_bug.cgi?id=111038
https://bugs.webkit.org/show_bug.cgi?id=111046
- platform/chromium/TestExpectations:
- 12:27 AM WebKitIDL edited by
- (diff)
- 12:18 AM Changeset in webkit [144269] by
-
- 2 edits in trunk/LayoutTests
Apparently Failure does not include ImageOnlyFailure.
- platform/chromium/TestExpectations:
- 12:07 AM Changeset in webkit [144268] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
The version of this file I landed in
http://trac.webkit.org/changeset/144262 appears to have been
ever-so-slightly incorrect.
- platform/chromium/inspector/timeline/timeline-script-tag-1-expected.txt:
Feb 27, 2013:
- 11:57 PM Changeset in webkit [144267] by
-
- 2 edits in trunk/Tools
PerfTestRunner doesn't need _needs_http and _has_http_lock
https://bugs.webkit.org/show_bug.cgi?id=111037
Reviewed by Adam Barth.
Delete these variables in favor of using a local variable.
Member variables are like global variables. They introduce implicit dependencies
between member functions.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.init):
(PerfTestsRunner._start_http_servers):
(PerfTestsRunner):
(PerfTestsRunner._stop_http_servers):
(PerfTestsRunner.run):
- 11:55 PM Changeset in webkit [144266] by
-
- 7 edits1 add in trunk
Unreviewed, rolling out r144224.
http://trac.webkit.org/changeset/144224
https://bugs.webkit.org/show_bug.cgi?id=111045
Caused plugins/pass-different-npp-struct.html to time out
(Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-27
Tools:
- DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
(PassDifferentNPPStruct::NPP_SetWindow):
- DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_SetWindow):
LayoutTests:
- platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Added.
- plugins/netscape-plugin-setwindow-size-2.html:
- plugins/netscape-plugin-setwindow-size.html:
- plugins/pass-different-npp-struct.html:
- 11:50 PM Changeset in webkit [144265] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: [Protocol] Genarate JS enum definitions.
https://bugs.webkit.org/show_bug.cgi?id=110461
Reviewed by Pavel Feldman.
Generating corresponding type annotations
would help to compiler to point errors.
- inspector/CodeGeneratorInspector.py: Generate "registerEnum" records.
- inspector/InjectedScriptSource.js: Shadow compiler warning.
- inspector/front-end/InspectorBackend.js:
Added "registerEnum". Added "registerEnum" generation.
- inspector/front-end/NetworkManager.js: Use enum instead of literal.
- inspector/generate_protocol_externs.py: Generate enum typedefs.
- 11:44 PM Changeset in webkit [144264] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Update some test expectations based on the threaded parser behavior.
These look like test integration issues rather than actual bugs in the
parser. We will investigate them offline.
- platform/chromium/TestExpectations:
- 10:44 PM Changeset in webkit [144263] by
-
- 12 edits2 adds in trunk
INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of hour field should respect min/max attributes
https://bugs.webkit.org/show_bug.cgi?id=109555
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-02-27
Reviewed by Kent Tamura.
Source/WebCore:
Make step-up/-down of the hour field respect the min/max attributes of the element.
Note that it still accepts any keyboard inputs (the element
becomes 'invalid' state when out-of-range values entered).
Also, disable the hour field and/or the AMPM field when there is only single possible value.
Test: fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer.html
fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html
fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html
- html/TimeInputType.cpp:
(WebCore::TimeInputType::setupLayoutParameters): Populates layoutParameters.{minimum,maximum}.
- html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder): Add data fields for min/max of day and hour fields.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Set newly added data members.
(WebCore::DateTimeEditBuilder::visitField): Pass minimum/maximum value to the month field constructors.
(WebCore::DateTimeEditBuilder::shouldAMPMFieldDisabled): Added.
(WebCore::DateTimeEditBuilder::shouldDayOfMonthFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldHourFieldDisabled):
Disables the hour field when min, max, and value have the same hour, except when the minute
field is disabled (by step attribute), because we need to leave at least one field editable.
- html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeHourFieldElementBase::DateTimeHourFieldElementBase):
(WebCore::DateTimeHourFieldElementBase::initialize):
(WebCore::DateTimeHourFieldElementBase::setValueAsDate):
(WebCore::DateTimeHourFieldElementBase::setValueAsDateTimeFieldsState):
(WebCore::DateTimeHour11FieldElement::DateTimeHour11FieldElement):
(WebCore::DateTimeHour11FieldElement::create):
(WebCore::DateTimeHour11FieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeHour11FieldElement::setValueAsInteger):
(WebCore::DateTimeHour11FieldElement::clampValueForHardLimits):
(WebCore::DateTimeHour12FieldElement::DateTimeHour12FieldElement):
(WebCore::DateTimeHour12FieldElement::create):
(WebCore::DateTimeHour12FieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeHour12FieldElement::setValueAsInteger):
(WebCore::DateTimeHour12FieldElement::clampValueForHardLimits):
(WebCore::DateTimeHour23FieldElement::DateTimeHour23FieldElement):
(WebCore::DateTimeHour23FieldElement::create):
(WebCore::DateTimeHour23FieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeHour23FieldElement::setValueAsInteger):
(WebCore::DateTimeHour23FieldElement::clampValueForHardLimits):
(WebCore::DateTimeHour24FieldElement::DateTimeHour24FieldElement):
(WebCore::DateTimeHour24FieldElement::create):
(WebCore::DateTimeHour24FieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeHour24FieldElement::setValueAsInteger):
(WebCore::DateTimeHour24FieldElement::clampValueForHardLimits):
- html/shadow/DateTimeFieldElements.h: Splitted DateTimeHourFieldElement into a base class and four derived classes that represents different hour formats.
(DateTimeHourFieldElementBase): Added.
(DateTimeHour11FieldElement): Added. Represents 0-11 hour format.
(DateTimeHour12FieldElement): Added. Represents 1-12 hour format.
(DateTimeHour23FieldElement): Added. Represents 0-23 hour format.
(DateTimeHour24FieldElement): Added. Represents 1-24 hour format.
LayoutTests:
Added test cases with min/max attributes.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield-expected.txt:
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html:
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Added.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html:
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:
- 10:41 PM Changeset in webkit [144262] by
-
- 11 edits15 adds2 deletes in trunk
[Chromium] Enable threaded HTML parser by default in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=110907
Reviewed by Eric Seidel.
Tools:
This patch changes --enable-threaded-html-parser into
--disable-threaded-html-parser and thereby enables the threaded HTML
parser by default for the Chromium port.
- DumpRenderTree/chromium/DumpRenderTree.cpp:
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
LayoutTests:
Update test results to show subtle differences in FrameLoaderClient callbacks.
- platform/chromium-mac/security/block-test-no-port-expected.txt: Removed.
- platform/chromium-win/fast/images/support-broken-image-delegate-expected.txt:
- platform/chromium-win/security/block-test-no-port-expected.txt: Removed.
- platform/chromium/fast/images/support-broken-image-delegate-expected.txt:
- platform/chromium/fast/loader/main-document-url-for-non-http-loads-expected.txt: Added.
- platform/chromium/http/tests/loading/307-after-303-after-post-expected.txt: Added.
- platform/chromium/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
- platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
- platform/chromium/http/tests/misc/window-dot-stop-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
- platform/chromium/inspector/debugger/pause-in-inline-script-expected.txt: Added.
- platform/chromium/inspector/timeline/timeline-script-tag-1-expected.txt: Added.
- platform/chromium/security/block-test-no-port-expected.txt:
- 10:31 PM FeatureFlags edited by
- Sort CSS3_* flags, update comments for form flags (diff)
- 10:25 PM FeatureFlags edited by
- Add STREAM and CSS3_TEXT_LINE_BREAK (diff)
- 10:14 PM EnableFormFeatures edited by
- (diff)
- 9:53 PM Changeset in webkit [144261] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Should not return WebTextInputTypeNone for date input element.
https://bugs.webkit.org/show_bug.cgi?id=110740
Patch by Seigo Nonaka <nona@chromium.org> on 2013-02-27
Reviewed by Kent Tamura.
In the case of Windows 8, text input state including on-screen keyboard is controlled by the
value of WebTextInputType returned from WebViewImpl::textInputType().
In past, it returned WebTextInputTypeDate for date text input but now it returns
WebTextInputTypeNone.
WebTextInputTypeNone is used for non editable node, so on-screen keyboard will be hidden if
the date text input is focused. So there is no way to input on Windows 8 tablet without
physical keyboard except tapping small up/down arrow.
- public/WebTextInputType.h: Introduces WebTextInputTypeDateTimeField.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputInfo): Fills type filed regardless of editable or not. It is
safe because textInputType returns editable type only for known editable element.
(WebKit::WebViewImpl::textInputType): Returns WebTextInputTypeDateTimeField for the date
time field element.
- 9:04 PM Changeset in webkit [144260] by
-
- 4 edits2 adds in trunk
Need to re-layout fixed position elements after scale when using settings()->fixedElementsLayoutRelativeToFrame()
https://bugs.webkit.org/show_bug.cgi?id=105486
Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-02-27
Reviewed by James Robinson.
In settings()->fixedElementsLayoutRelativeToFrame() mode, fixed-position
elements are layout relative to the current visible viewport, which can
be different from the layout viewport when using fixed-layout mode.
We need to re-layout fixed-position elements in case of visible content
size changes.
The test is currently chromium-specific due to difficulties to make this
test works on Mac. The mac port seems to work very differently with
visible content size when a page is scaled. And there is no reliable way
to hide scrollbars in mac-wk1 that doesn't cause a side effect.
Source/WebCore:
Test: platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html
- page/FrameView.h:
(FrameView):
- page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
LayoutTests:
- platform/chromium/fast/repaint/relayout-fixed-position-after-scale-expected.html: Added.
- platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html: Added.
- 7:51 PM Changeset in webkit [144259] by
-
- 2 edits in trunk/Tools
Initialize page visibility after creating WebKitTestRunner WebView on Mac
https://bugs.webkit.org/show_bug.cgi?id=111025
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-02-27
Reviewed by Simon Fraser.
Set page visibility to "visible" after creating WebView to override
visibility state inferred from window occlusion notifications on Mac.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions): Add call to
setVisibilityState.
- 7:31 PM Changeset in webkit [144258] by
-
- 7 edits8 adds in trunk
[CSS Exclusions] Enable shape-inside rectangle support for shape-padding
https://bugs.webkit.org/show_bug.cgi?id=110500
Reviewed by Dirk Schulze.
Source/WebCore:
Added support for CSS shape-padding for shapes defined with shape-inside.
Tests: fast/exclusions/shape-inside/shape-inside-circle-padding.html
fast/exclusions/shape-inside/shape-inside-ellipse-padding.html
fast/exclusions/shape-inside/shape-inside-rectangle-padding.html
fast/exclusions/shape-inside/shape-inside-rounded-rectangle-padding.html
- rendering/ExclusionRectangle.cpp:
(WebCore::FloatRoundedRect::paddingBounds): Inset the rounded rectangle to reflect the padding parameter.
(WebCore::FloatRoundedRect::marginBounds): Expand the rounded rectangle to reflect the margin parameter.
(WebCore::FloatRoundedRect::cornerInterceptForWidth): Moved this method from ExclusionRectangle to FloatRoundedRect.
(WebCore::ExclusionRectangle::shapePaddingBounds): Lazily compute the bounds of the padding box.
(WebCore::ExclusionRectangle::shapeMarginBounds): Lazily compute the bounds of the margin box.
(WebCore::ExclusionRectangle::getExcludedIntervals): This computuation is now based on the (new) margin box.
(WebCore::ExclusionRectangle::getIncludedIntervals): This computation is now base don the (new) padding box.
(WebCore::ExclusionRectangle::firstIncludedIntervalLogicalTop): This computation is now base don the (new) padding box.
- rendering/ExclusionRectangle.h:
(FloatRoundedRect): A subclass of FloatRect that includes corner radii specified as CSS shapes do.
(WebCore::FloatRoundedRect::FloatRoundedRect):
(WebCore::FloatRoundedRect::rx):
(WebCore::FloatRoundedRect::ry):
(WebCore::ExclusionRectangle::ExclusionRectangle):
- rendering/ExclusionShape.cpp:
(WebCore::ExclusionShape::createExclusionShape): Initialize the new shapeMargin and shapePadding properties.
- rendering/ExclusionShape.h:
(ExclusionShape):
(WebCore::ExclusionShape::shapeMargin): Added a public read-only property for shapeMargin.
(WebCore::ExclusionShape::shapePadding): Added a public read-only property for shapePadding.
- rendering/ExclusionShapeInfo.cpp:
(WebCore::::computedShape): Pass the values of the CSS shape-margin and shapp-padding properties to createExclusionShape().
LayoutTests:
Added one shape-inside, shape-padding test for each CSS shape type.
- fast/exclusions/shape-inside/shape-inside-circle-padding-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-circle-padding.html: Added.
- fast/exclusions/shape-inside/shape-inside-ellipse-padding-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-ellipse-padding.html: Added.
- fast/exclusions/shape-inside/shape-inside-rectangle-padding-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-rectangle-padding.html: Added.
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-padding-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-padding.html: Added.
- 7:09 PM Changeset in webkit [144257] by
-
- 2 edits in trunk/Source/WebCore
More style cleanup in GIFImageReader
https://bugs.webkit.org/show_bug.cgi?id=110776
Reviewed by Allan Sandfeld Jensen.
Renamed variable q to currentComponent which more accurately represent
the purpose.
No test. Simple refactoring.
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::decodeInternal):
- 6:58 PM Changeset in webkit [144256] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] Rebaseline after r144236
https://bugs.webkit.org/show_bug.cgi?id=109879
Unreviewed expectations update
- platform/chromium-linux/plugins/plugin-clip-subframe-expected.txt: Added.
- 6:29 PM Changeset in webkit [144255] by
-
- 3 edits in trunk/Tools
Merge PageLoadingPerfTest into ReplayPerfTest
https://bugs.webkit.org/show_bug.cgi?id=111027
Reviewed by Dirk Pranke.
Merged two classes.
We should really move ahead with the bug 100991 and get rid of PageLoadingPerfTest
part of ReplayPerfTest.
- Scripts/webkitpy/performance_tests/perftest.py:
(ReplayPerfTest): Moved _FORCE_GC_FILE here.
(ReplayPerfTest.init):
(ReplayPerfTest._run_with_driver): Moved from PageLoadingPerfTest.
(ReplayPerfTest.run_single): Load the GC page as run_single on PageLoadingPerfTest did.
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestReplayPerfTest):
(TestReplayPerfTest.test_run_single.run_test):
(TestReplayPerfTest.test_run_single): Make sure test_time is passed down properly from output.
(TestReplayPerfTest.test_run_with_driver_accumulates_results): Renamed from
TestPageLoadingPerfTest.test_run.
(TestReplayPerfTest.test_run_with_driver_accumulates_results.mock_run_signle):
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Renamed from
TestPageLoadingPerfTest.test_run_with_memory_output
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results.mock_run_signle):
(TestReplayPerfTest.test_prepare_calls_run_single):
- 6:24 PM Changeset in webkit [144254] by
-
- 2 edits in trunk/Source/WebCore
Add month popup for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110830
Reviewed by Kent Tamura.
Adding month popup view for use in the new calendar picker (Bug 109439).
YearListCell will grow in height when selected to reveal the buttons for
selecting the month.
No new tests. Code is not used yet.
- Resources/pagepopups/calendarPicker.js:
(YearListCell): A row inside the month popup. Contains buttons for choosing a month.
(YearListCell.prototype._recycleBin):
(YearListCell.prototype.reset): Resets a thrown away cell for reuse at the given row.
(YearListCell.prototype.height):
(YearListCell.prototype.setHeight):
(YearListView): List view showing YearListCells.
(YearListView.prototype.onMouseOver): If the mouse is over a month button, highlights it.
(YearListView.prototype.onMouseOut): De-highlights the month button.
(YearListView.prototype.setWidth): Set scroll view width to leave space for the scroll bar.
(YearListView.prototype.setHeight): Sets the scroll bar height as well.
(YearListView.prototype._animateRow): Animates the row height to open/close the YearListCell.
(YearListView.prototype.onCellHeightAnimatorDidStop): Keep this._runningAnimators and this._animatingRows up to date.
(YearListView.prototype.onCellHeightAnimatorStep): Update the cell height and position.
(YearListView.prototype.onClick): If this is a click on a month button, select the month.
(YearListView.prototype.rowAtScrollOffset): Calculates the row currently at the given offset.
(YearListView.prototype.scrollOffsetForRow): Calculates the current scroll offset of the given row.
(YearListView.prototype.prepareNewCell): Prepares a new or recycled YearListCell.
(YearListView.prototype.updateCells): Updates the position of the visible cells.
(YearListView.prototype.deselect): Deselects a row.
(YearListView.prototype.deselectWithoutAnimating): Deselects a row without the closing animation.
(YearListView.prototype.select): Selects a row.
(YearListView.prototype.selectWithoutAnimating): Deselects a row without the opening animation.
(YearListView.prototype.buttonForMonth): Returns the month button for a given month. Returns null if the cell is not visible.
(YearListView.prototype.dehighlightMonth): Dehighlights the month button.
(YearListView.prototype.highlightMonth): Highlights the month button.
(YearListView.prototype.show): Call when showing the year list view. Shows the given month as highlighted.
(YearListView.prototype.hide): Dispatches a did hide event which will be picked up by the CalendarPicker and the MonthPopupView will close.
(YearListView.prototype._moveHighlightTo): Used to move the month highlight in response to a key event.
(YearListView.prototype.onKeyDown): Arrow keys and PageUp/PageDown keys work.
(MonthPopupView): The popup view to be overlayed over the calendar picker.
(MonthPopupView.prototype.show): Takes the initialMonth to show and the calendarTableRect so we can overlay the year list view right on top of it.
(MonthPopupView.prototype.hide):
(MonthPopupView.prototype.onClick): Hides itself if the use clicks outside the year list view.
- 5:33 PM Changeset in webkit [144253] by
-
- 3 edits in trunk/Tools
Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
https://bugs.webkit.org/show_bug.cgi?id=111021
Reviewed by Dirk Pranke.
The underlying code (which is shared with run-webkit-tests)
already knew how to support this option, it just wasn't exposed
via the run-perf-tests front-end. This patch fixes that.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
- 4:56 PM Changeset in webkit [144252] by
-
- 2 edits in trunk/Tools
Stop uploading results to webkit-perf.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=110954
Reviewed by Benjamin Poulain.
Pass in perf.webkit.org instead of webkit-perf.appspot.com as the test results server.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunAndUploadPerfTests):
- 4:42 PM Changeset in webkit [144251] by
-
- 1 edit2 adds1 delete in trunk/LayoutTests
[Chromium] Rebaseline after r144236
https://bugs.webkit.org/show_bug.cgi?id=109879
Unreviewed expectations update
- platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt: Added.
- platform/chromium-win-xp/plugins: Removed.
- platform/chromium-win/plugins/plugin-clip-subframe-expected.txt: Added.
- 4:41 PM AddingFeatures edited by
- GTK port is now using SetupWebKitFeatures.m4 (diff)
- 4:17 PM Changeset in webkit [144250] by
-
- 3 edits in trunk/Source/WebCore
Use FeatureObserver to see how often web sites use multipart main documents
https://bugs.webkit.org/show_bug.cgi?id=111015
Reviewed by Nate Chapin.
Multipart main documents add sigificant complexity to the loader. It
would be interesting to know how often this complexity is used.
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::responseReceived):
- page/FeatureObserver.h:
- 3:50 PM Changeset in webkit [144249] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r144168.
http://trac.webkit.org/changeset/144168
https://bugs.webkit.org/show_bug.cgi?id=111019
It broke the build and tronical is unavailable (Requested by
Ossy_night on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-27
- LLIntOffsetsExtractor.pro:
- 3:47 PM Changeset in webkit [144248] by
-
- 22 edits2 adds in trunk
[chromium] Lower priority of preloaded images
https://bugs.webkit.org/show_bug.cgi?id=110527
Source/WebCore:
Reviewed by Nate Chapin.
This improves Speed Index by ~5%, because it encourages us to load images that are needed for
painting over speculative preloads. Ideally, all embedders would use this, but it relies on
ResourceHandle::didChangePriority being implemented. Currently, only Chrome does that.
Test: http/tests/loading/promote-img-preload-priority.html
- loader/FrameLoaderClient.h:
(FrameLoaderClient):
(WebCore::FrameLoaderClient::dispatchDidChangeResourcePriority): Added callback to enable testing.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::setLoadPriority): Signal callback.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::preload): Actual behavior change.
Source/WebKit/chromium:
Plumb the didChangePriority signal into DRT so it can be tested.
Reviewed by Nate Chapin.
- public/WebFrameClient.h:
(WebKit):
(WebKit::WebFrameClient::didChangeResourcePriority):
(WebFrameClient):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidChangeResourcePriority):
(WebKit):
- src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
Tools:
Plumb the didChangePriority signal into DRT so it can be tested.
Reviewed by Nate Chapin.
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestRunner::WebTestProxy::didChangeResourcePriority):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpResourcePriorities):
(WebTestRunner):
(WebTestRunner::TestRunner::dumpResourceRequestPriorities):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
(WebTestRunner::WebTestProxyBase::willSendRequest):
(WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
(WebTestRunner):
LayoutTests:
Reviewed by Nate Chapin.
- http/tests/loading/promote-img-preload-priority-expected.txt: Added.
- http/tests/loading/promote-img-preload-priority.html: Added.
- 3:25 PM Changeset in webkit [144247] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed trivial buildfix after r144190.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2013-02-27
- platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
- 3:13 PM Changeset in webkit [144246] by
-
- 5 edits in trunk/Source/WebKit2
[WK2] One more unreviewed buildfix for EFL, GTK and Qt after r144218.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2013-02-27
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebProcess/Storage/StorageNamespaceProxy.cpp:
(WebKit::StorageNamespaceProxy::copy):
- 3:04 PM Changeset in webkit [144245] by
-
- 2 edits2 adds in trunk/LayoutTests
Rebaseline 2 SVG tests after WK108429
This patch rebaselines svg/repaint after WK108429 and removes a stale
test expectations entry for svg/custom/text-ctm.
Unreviewed update of test expectations.
- platform/chromium-win/svg/repaint/svgsvgelement-repaint-children-expected.png: Added.
- platform/chromium-win/svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
- platform/chromium/TestExpectations:
- 2:55 PM Changeset in webkit [144244] by
-
- 7 edits2 adds in trunk
WebSpeech: support speech cancel
https://bugs.webkit.org/show_bug.cgi?id=107349
Reviewed by Beth Dakin.
Source/WebCore:
Add the ability to cancel speech utterances and make it work with Mac
and the mock speech synthesizer.
Test: platform/mac/fast/speechsynthesis/speech-synthesis-cancel.html
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::pending):
(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::handleSpeakingCompleted):
- platform/PlatformSpeechSynthesizer.h:
(PlatformSpeechSynthesizer):
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper cancel]):
(WebCore::PlatformSpeechSynthesizer::cancel):
(WebCore):
- platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::cancel):
(WebCore):
(WebCore::PlatformSpeechSynthesizerMock::speak):
- platform/mock/PlatformSpeechSynthesizerMock.h:
(PlatformSpeechSynthesizerMock):
LayoutTests:
- platform/mac/fast/speechsynthesis/speech-synthesis-cancel-expected.txt: Added.
- platform/mac/fast/speechsynthesis/speech-synthesis-cancel.html: Added.
- 2:53 PM Changeset in webkit [144243] by
-
- 5 edits in trunk/Source/WebKit2
Unreviewed (speculative) build fixes for EFL, GTK and Qt after r144218.
- CMakeLists.txt:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- 2:49 PM Changeset in webkit [144242] by
-
- 6 edits in trunk/Source
Unlock partially decoded images after passing them to the ImageDecodingStore
https://bugs.webkit.org/show_bug.cgi?id=110778
Patch by Min Qin <qinmin@chromium.org> on 2013-02-27
Reviewed by Stephen White.
Source/WebCore:
For partially decoded images, we need to unlock them so that the memory can be freed.
This change unlocks all the image frames after they are passed to ImageDecodingStore.
Unit tests are added in ImageFrameGeneratorTest.
- platform/graphics/chromium/ImageFrameGenerator.cpp:
(WebCore::ImageFrameGenerator::tryToResumeDecodeAndScale):
(WebCore::ImageFrameGenerator::tryToDecodeAndScale):
(WebCore::ImageFrameGenerator::decode):
- platform/image-decoders/ImageDecoder.h:
(ImageDecoder):
(WebCore::ImageDecoder::lockFrameBuffers):
(WebCore::ImageDecoder::unlockFrameBuffers):
Source/WebKit/chromium:
Test for testing that image frames are unlocked after passing to ImageDecodingStore.
- tests/ImageFrameGeneratorTest.cpp:
(WebCore::ImageFrameGeneratorTest::SetUp):
(WebCore::ImageFrameGeneratorTest::frameBuffersUnlocked):
(ImageFrameGeneratorTest):
(WebCore::ImageFrameGeneratorTest::frameBuffersLocked):
(WebCore::TEST_F):
- tests/MockImageDecoder.h:
(WebCore::MockImageDecoderClient::frameBuffersLocked):
(WebCore::MockImageDecoderClient::frameBuffersUnlocked):
(WebCore::MockImageDecoder::unlockFrameBuffers):
(WebCore::MockImageDecoder::lockFrameBuffers):
(MockImageDecoder):
- 2:44 PM Changeset in webkit [144241] by
-
- 4 edits in trunk
Insufficient validation when uploading depth textures to WebGL
https://bugs.webkit.org/show_bug.cgi?id=110931
Reviewed by Abhishek Arya.
Source/WebCore:
Updated webgl/conformance/extensions/webgl-depth-texture.html
layout test with additional test cases.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2DImpl):
(WebCore::WebGLRenderingContext::texSubImage2D):
Check for valid format/type combinations, depth, and
depth+stencil formats when uploading HTML elements and
ImageData as textures.
LayoutTests:
Updated webgl/conformance/extensions/webgl-depth-texture.html
layout test with additional test cases. These changes will be
added to the Khronos repository.
- webgl/resources/webgl_test_files/conformance/extensions/webgl-depth-texture.html:
Added more test cases.
- 2:39 PM Changeset in webkit [144240] by
-
- 3 edits in trunk/Source/WebCore
Threaded HTML Parser fails fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html in debug
https://bugs.webkit.org/show_bug.cgi?id=110951
Reviewed by Eric Seidel.
We were triggering this ASSERT because we didn't understand that a
given frame might have multiple DocumentLoaders in various states. That
caused us to think that a DocumentLoader in the provisional state was
actually loading.
- dom/Document.cpp:
(WebCore::Document::decrementActiveParserCount):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoading):
- 2:24 PM Changeset in webkit [144239] by
-
- 7 edits2 copies in branches/chromium/1410
Merge 143541
Account for transform in SVG background images
https://bugs.webkit.org/show_bug.cgi?id=110295
Reviewed by Dirk Schulze.
Source/WebCore:
Tiled SVG background images are rendererd by drawing the SVG content into a temporary
image buffer, then stamping out a tiled pattern using this buffer. Previously the
image buffer did not account for CSS transforms which could result in pixelated backgrounds.
This patch takes advantage of the context's transform when sizing the temporary tiling
image buffer. Because the context's transform also includes scale, this patch simplifies
the SVG image code to no longer track scale.
Test: svg/as-background-image/svg-transformed-background.html
- loader/cache/CachedImage.cpp:
(WebCore):
(WebCore::CachedImage::imageForRenderer):
CachedImage::lookupOrCreateImageForRenderer no longer creates images so it has been
refactored into just "imageForRenderer". Previously there were two versions of
lookupOrCreateImageForRenderer; these have been folded into imageForRenderer.
- loader/cache/CachedImage.h:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
To create the temporary tiling image buffer, the final size in screen coordinates is
needed. This is now computed using the current context's CTM. Because the CTM
already includes the page scale, all page scale tracking can be removed.
The adjustments to srcRect and the pattern transform are the same as before, just
refactored to use imageBufferScale which has x and y components.
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::setContainerSizeForRenderer):
Because the page scale needed to be cached between calls to
setContainerSizeForRenderer, this function was written to modify an existing cache
entry. Because the page scale no longer needs to be tracked, this code has been
simplified to re-write any existing cache entry.
(WebCore::SVGImageCache::imageSizeForRenderer):
This function has been simplified by calling SVGImageForContainer::size() instead
of computing this value manually. The value returned remains the same, containing
the container size multiplied by zoom.
(WebCore::SVGImageCache::imageForRenderer):
Previously we set the page scale on every call to imageForRenderer. Because page scale
no longer needs to be tracked, this function has been simplified to simply return
the cached SVGImageForContainer.
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern):
- svg/graphics/SVGImageForContainer.h:
(WebCore::SVGImageForContainer::create):
(WebCore::SVGImageForContainer::SVGImageForContainer):
(SVGImageForContainer):
LayoutTests:
- svg/as-background-image/svg-transformed-background-expected.html: Added.
- svg/as-background-image/svg-transformed-background.html: Added.
TBR=pdr@google.com
Review URL: https://codereview.chromium.org/12314169
- 2:22 PM Changeset in webkit [144238] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 143257
Fix scaling of tiled SVG backgrounds on high-dpi displays
https://bugs.webkit.org/show_bug.cgi?id=110047
Reviewed by Dirk Schulze.
Source/WebCore:
This patch fixes the scaling of SVG when used for drawing patterns. Tiled/patterend SVG
images are first drawn into an image buffer and then the image buffer is used to stamp
out tiles. Because it is a raster source, the size of the image buffer needs to
be scaled to the final resolution of the device. After scaling the image buffer, the
source rect and pattern transforms need to be adjusted so they align in device pixel
coordinates. This adjustment was not done before this patch, causing pixelated rendering.
Additionally, a FIXME has been added due to webkit.org/b/110065 and the image buffer
has been manually scaled (using "zoomedAndScaledContainerRect") instead of relying
on the ImageBuffer's resolutionScale parameter.
Test: svg/as-background-image/tiled-background-image.html
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
Note that fixing the FIXME does not change that the source rect and transform need
to be adjusted for page scale.
LayoutTests:
- svg/as-background-image/tiled-background-image-expected.html: Added.
- svg/as-background-image/tiled-background-image.html: Added.
TBR=pdr@google.com
Review URL: https://codereview.chromium.org/12326167
- 2:10 PM Changeset in webkit [144237] by
-
- 10 edits2 adds in trunk
AX: Mac platform should support ability to scroll an element into visible
https://bugs.webkit.org/show_bug.cgi?id=109860
Reviewed by Beth Dakin.
Source/WebCore:
Support the scrollToMakeVisible() action for MacOS accessibility clients.
Tests: platform/mac/accessibility/scroll-to-visible-action.html
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper accessibilityScrollToVisible]):
(-[WebAccessibilityObjectWrapper accessibilityPerformAction:]):
Tools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(scrollToMakeVisibleCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::scrollToMakeVisible):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::scrollToMakeVisible):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::scrollToMakeVisible):
(WTR):
LayoutTests:
- platform/mac/accessibility/scroll-to-visible-action.html: Added.
- platform/mac/accessibility/scroll-to-visible-action-expected.txt: Added.
- 2:05 PM Changeset in webkit [144236] by
-
- 20 edits5 adds in trunk
Plugin in iframe may not display
https://bugs.webkit.org/show_bug.cgi?id=109879
Patch by John Bauman <jbauman@chromium.org> on 2013-02-27
Reviewed by Simon Fraser.
Source/WebCore:
Changing the cliprect on a layer containing an iframe may change the
cliprect of plugins inside the iframe, so recursively tell all plugins
in iframes that their cliprect has changed after doing layout on the
outer frame.
Test: plugins/plugin-clip-subframe.html
- platform/ScrollView.cpp:
(WebCore::ScrollView::clipRectChanged):
- platform/ScrollView.h:
- platform/Widget.h:
(WebCore::Widget::clipRectChanged):
- plugins/PluginView.cpp:
(WebCore::PluginView::clipRectChanged):
- plugins/PluginView.h:
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
Source/WebKit/chromium:
Use clipRectChanged to update the geometry.
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::clipRectChanged):
- src/WebPluginContainerImpl.h:
Source/WebKit/mac:
Ensure NetscapePluginWidget informs the plugin view of the cliprect change directly.
- Plugins/WebBaseNetscapePluginView.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(NetscapePluginWidget::clipRectChanged):
Source/WebKit2:
Update geometry when cliprect changes.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::clipRectChanged):
- WebProcess/Plugins/PluginView.h:
Tools:
LogNPPSetWindow will be used with other ports as well.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
LayoutTests:
Use log-npp-set-window to ensure plugin clip changes correctly.
- platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt: Added.
- platform/mac/plugins/plugin-clip-subframe-expected.txt: Added.
- plugins/plugin-clip-subframe-expected.txt: Added.
- plugins/plugin-clip-subframe.html: Added.
- plugins/resources/plugin-clip-subframe-iframe.html: Added.
- 1:46 PM Changeset in webkit [144235] by
-
- 12 edits2 adds in trunk
Implement channel up-mixing and down-mixing rules
https://bugs.webkit.org/show_bug.cgi?id=110812
Reviewed by Kenneth Russell.
Source/WebCore:
Please see Web Audio specification for details of the AudioNode mixing rules attributes:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#UpMix
Test: webaudio/audionode-channel-rules.html
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::channelCount):
(WebCore):
(WebCore::AudioNode::setChannelCount):
(WebCore::AudioNode::channelCountMode):
(WebCore::AudioNode::setChannelCountMode):
(WebCore::AudioNode::channelInterpretation):
(WebCore::AudioNode::setChannelInterpretation):
(WebCore::AudioNode::updateChannelsForInputs):
- Modules/webaudio/AudioNode.h:
(AudioNode):
(WebCore::AudioNode::internalChannelCountMode):
(WebCore::AudioNode::internalChannelInterpretation):
- Modules/webaudio/AudioNode.idl:
- Modules/webaudio/AudioNodeInput.cpp:
(WebCore::AudioNodeInput::numberOfChannels):
(WebCore::AudioNodeInput::bus):
(WebCore::AudioNodeInput::internalSummingBus):
(WebCore::AudioNodeInput::sumAllConnections):
(WebCore::AudioNodeInput::pull):
- Modules/webaudio/AudioNodeInput.h:
(AudioNodeInput):
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::ConvolverNode):
- Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::PannerNode):
- platform/audio/AudioBus.cpp:
(WebCore::AudioBus::speakersCopyFrom):
(WebCore::AudioBus::speakersSumFrom):
(WebCore::AudioBus::speakersSumFrom5_1_ToMono):
(WebCore):
- platform/audio/AudioBus.h:
(AudioBus):
LayoutTests:
- webaudio/audionode-channel-rules-expected.txt: Added.
- webaudio/audionode-channel-rules.html: Added.
- 1:42 PM Changeset in webkit [144234] by
-
- 2 edits in trunk/Source/WebKit/chromium
RenderTableCellDeathTest unit test fails on mac
https://bugs.webkit.org/show_bug.cgi?id=110992
Unreviewed second attempt. Trying to get the right define for the OS.
- tests/RenderTableCellTest.cpp:
- 1:35 PM WebKitGTK/2.0.x edited by
- (diff)
- 1:30 PM Changeset in webkit [144233] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Need WebPage API for animating scroll position & zoom changes
https://bugs.webkit.org/show_bug.cgi?id=110912
Patch by Andrew Lo <anlo@rim.com> on 2013-02-27
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.
Internal PR 285468.
Add an API to WebPage for animated scroll position & zoom level
adjustments.
Have InputHandler use the new API.
Rename some variables to reflect the fact that they are not only
used by block zoom now.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):
(BlackBerry::WebKit::WebPage::blockZoom):
(BlackBerry::WebKit::WebPagePrivate::animateToScaleAndDocumentScrollPosition):
(WebKit):
(BlackBerry::WebKit::WebPage::animateToScaleAndDocumentScrollPosition):
- Api/WebPage.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 1:23 PM Changeset in webkit [144232] by
-
- 2 edits in trunk/Source/WebCore
Threaded HTML parser hits ASSERTION FAILED: this == frameLoader()->activeDocumentLoader()
https://bugs.webkit.org/show_bug.cgi?id=110937
Reviewed by Darin Adler.
This patch restores the ASSERT behind an ifdef so that we can continue
to get converage from the ASSERT while we investigate why it is
triggering in the threaded parser.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::checkLoadComplete):
- 1:20 PM Changeset in webkit [144231] by
-
- 3 edits1 add in trunk/Source/Platform
[chromium] Introduce WebHyphenator class to consolidate hyphenation related method on WebKit::Platform
https://bugs.webkit.org/show_bug.cgi?id=110953
Reviewed by Adam Barth.
This patch makes it easier to mock the hyphenation related methods.
- Platform.gypi:
- chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::hyphenator):
- chromium/public/WebHyphenator.h: Added.
(WebKit):
(WebHyphenator):
(WebKit::WebHyphenator::canHyphenate):
(WebKit::WebHyphenator::computeLastHyphenLocation):
(WebKit::WebHyphenator::~WebHyphenator):
- 12:58 PM Changeset in webkit [144230] by
-
- 2 edits in trunk/LayoutTests
Skip media tests that fail on content_shell
Unreviewed gardening.
- platform/chromium/ContentShellTestExpectations:
- 12:50 PM Changeset in webkit [144229] by
-
- 9 edits in trunk/Source
[BlackBerry] User credentials is not correctly handled
https://bugs.webkit.org/show_bug.cgi?id=110994
Source/WebCore:
Internal PR: 280990
Internal reviewed by Leo Yang.
Reviewed by Yong Li.
Following changes are made:
Remove url from generating the hash to index user credential.
Remove url from database.
Use new CertMgrWrapper API to remove password from CertMgr.
Handle encrypted password as binary data, instead of normal text string.
When authentication fails, remove the saved user credential only when they match.
Remove some url related API from CredentialBackingStore, as they are obsolete now.
No new tests as this is platform specific change about user credential.
- platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::hashCredentialInfo):
(WebCore::CredentialBackingStore::CredentialBackingStore):
(WebCore::CredentialBackingStore::~CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::hasLogin):
(WebCore::CredentialBackingStore::getLogin):
(WebCore::CredentialBackingStore::removeLogin):
(WebCore::CredentialBackingStore::addNeverRemember):
(WebCore::CredentialBackingStore::encryptedString):
(WebCore::CredentialBackingStore::decryptedString):
- platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::purgeCredentials):
Source/WebKit/blackberry:
Reviewed by Yong Li.
Following change are made:
Remove url from CredentialTransformData, as url is not used anymore.
Adapt to updated CredentialBackingStore API about removing url.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- WebCoreSupport/CredentialManager.cpp:
(WebCore::CredentialManager::autofillPasswordForms):
(WebCore::CredentialManager::saveCredentialIfConfirmed):
- WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::CredentialTransformData):
- WebCoreSupport/CredentialTransformData.h:
(CredentialTransformData):
- 12:44 PM Changeset in webkit [144228] by
-
- 4 edits in trunk/Source/WebKit2
REGRESSION (48533): Full-frame plugins stopped working (download instead of loading the plugin)
https://bugs.webkit.org/show_bug.cgi?id=111003
Reviewed by Anders Carlsson.
Also query the Page's pluginData when determining whether a given MIME type can be shown.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCanShowMIMEType):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::canShowMIMEType):
- WebProcess/WebPage/WebPage.h:
- 12:43 PM Changeset in webkit [144227] by
-
- 2 edits in trunk/Source/WebKit/chromium
RenderTableCellDeathTest unit test fails on mac
https://bugs.webkit.org/show_bug.cgi?id=110992
Unreviewed disabling of test that is hanging or crashing on Mac.
- tests/RenderTableCellTest.cpp:
- 12:40 PM Changeset in webkit [144226] by
-
- 3 edits in trunk/Source/WebCore
Refactor transform painting/hit testing code in RenderLayer.
https://bugs.webkit.org/show_bug.cgi?id=110998
Reviewed by Eric Seidel.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
Pull the code that applies the transform for painting into a new
function that can also apply an additional translation offset. This
offset will be used by the new columns code when that patch lands.
(WebCore::RenderLayer::createLocalTransformState):
Also patched to be able to apply an additional translation offset.
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestLayerByApplyingTransform):
Same as with painting, pull the code that applies the transform into
its own function and also enable an extra translation offset to be
applied.
- rendering/RenderLayer.h:
Added the new functions to the header.
- 12:39 PM Changeset in webkit [144225] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Remove suppression invalidation logic from WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=110999
Patch by James Robinson <jamesr@chromium.org> on 2013-02-27
Reviewed by Adrienne Walker.
This suppression logic is now handled on the embedder side. In fact, scheduleComposite() is now only used
by DumpRenderTree.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::suppressInvalidations):
(WebKit::WebViewImpl::scheduleComposite):
- src/WebViewImpl.h:
- 12:38 PM Changeset in webkit [144224] by
-
- 7 edits1 delete in trunk
plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
https://bugs.webkit.org/show_bug.cgi?id=110973
Reviewed by Adam Barth.
There is nothing that ensures that the log messages from the plugin
come in before the layout test finished loading.
Tools:
- DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
(PassDifferentNPPStruct::NPP_SetWindow):
- DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_SetWindow):
LayoutTests:
- platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Removed.
- plugins/netscape-plugin-setwindow-size-2.html:
- plugins/netscape-plugin-setwindow-size.html:
- plugins/pass-different-npp-struct.html:
- 12:37 PM Changeset in webkit [144223] by
-
- 2 edits in trunk/Source/WebCore
Touch CSSGrammar.y.in to fix an internal buildbot
- css/CSSGrammar.y.in: Add copyright dates based on previous
commits.
- 12:21 PM Changeset in webkit [144222] by
-
- 2 edits in trunk
[GTK] Disable MathML support in release builds
https://bugs.webkit.org/show_bug.cgi?id=110981
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-02-27
Reviewed by Martin Robinson.
- Source/autotools/SetupWebKitFeatures.m4: Disable the MathML support in release builds
as the code is not yet deemed production-ready.
- 12:20 PM Changeset in webkit [144221] by
-
- 19 edits in trunk
Add smartInsertDeleteEnabled setting to WebCore::Page
https://bugs.webkit.org/show_bug.cgi?id=107840
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-02-27
Reviewed by Ryosuke Niwa.
Source/WebCore:
Covered by editing/deleting/smart-editing-disabled.html.
- page/Settings.in: Add new setting with true as initial value.
Source/WebKit2:
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode): Remove code related to
isSmartInsertDeleteEnabled.
- Shared/WebPageCreationParameters.h:
(WebPageCreationParameters): Remove isSmartInsertDeleteEnabled.
- Shared/WebPreferencesStore.h:
(WebKit): Add macro for smartInsertDeleteEnabled setting.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetSmartInsertDeleteEnabled):
(WKPreferencesGetSmartInsertDeleteEnabled): Implement methods using the
new setting.
- UIProcess/API/C/WKPreferencesPrivate.h: Add new methods headers.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage): Set smartInsertDeleteEnabled
setting using m_isSmartInsertDeleteEnabled to keep initial value on Mac.
(WebKit::WebPageProxy::creationParameters): Remove usage of
parameters.isSmartInsertDeleteEnabled.
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::smartInsertDeleteEnabled): Enable method for
all platforms.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Remove m_isSmartInsertDeleteEnabled
initialization.
(WebKit::WebPage::updatePreferences): Set smartInsertDeleteEnabled
setting.
(WebKit::WebPage::isSmartInsertDeleteEnabled): Implement method using
settings.
(WebKit):
(WebKit::WebPage::setSmartInsertDeleteEnabled): Implement method using
settings.
- WebProcess/WebPage/WebPage.h:
(WebPage): Enable methods dealing with smartInsertDeleteEnabled for all
platforms and remove m_isSmartInsertDeleteEnabled as it will be a
setting.
LayoutTests:
Replace testRunner.setSmartInsertDeleteEnabled by
internals.settings.setSmartInsertDeleteEnabled in tests.
- editing/deleting/smart-editing-disabled.html:
- editing/selection/doubleclick-beside-cr-span.html:
- editing/selection/doubleclick-whitespace-crash.html:
- editing/selection/doubleclick-whitespace-img-crash.html:
- editing/selection/doubleclick-whitespace.html:
- platform/wk2/TestExpectations: Unflag
editing/deleting/smart-editing-disabled.html as it passes now.
- 12:14 PM Changeset in webkit [144220] by
-
- 8 edits2 adds in trunk
WebSpeech: Support pause/resume ability
https://bugs.webkit.org/show_bug.cgi?id=107345
Reviewed by Beth Dakin.
Source/WebCore:
Add in the pause/resume functionality to SpeechSynthesis. Also hook up
the callback events.
Test: platform/mac/fast/speechsynthesis/speech-synthesis-pause-resume.html
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore::SpeechSynthesis::pending):
(WebCore::SpeechSynthesis::paused):
(WebCore::SpeechSynthesis::startSpeakingImmediately):
(WebCore::SpeechSynthesis::pause):
(WebCore::SpeechSynthesis::resume):
(WebCore):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
- Modules/speech/SpeechSynthesis.h:
(SpeechSynthesis):
- platform/PlatformSpeechSynthesizer.h:
(PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper pause]):
(-[WebSpeechSynthesisWrapper resume]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore):
(WebCore::PlatformSpeechSynthesizer::resume):
LayoutTests:
- platform/mac/fast/speechsynthesis/speech-synthesis-pause-resume-expected.txt: Added.
- platform/mac/fast/speechsynthesis/speech-synthesis-pause-resume.html: Added.
- 12:11 PM Changeset in webkit [144219] by
-
- 2 edits in trunk/Source/JavaScriptCore
Disable some unsound DFG DCE
https://bugs.webkit.org/show_bug.cgi?id=110948
Reviewed by Michael Saboff.
DCE of bitops is not sound since the bitops might call some variant of valueOf.
This used to work right because ValueToInt32 was MustGenerate. From the DFG IR
standpoint it feels weird to make ValueToInt32 be MustGenerate since that node is
implemented entirely as a pure conversion. If we ever gave the DFG the ability to
do effectful bitops, we would most likely implement them as special nodes not
related to the ValueToInt32 and bitop nodes we have now.
This change is performance neutral.
- dfg/DFGNodeType.h:
(DFG):
- 12:04 PM Changeset in webkit [144218] by
-
- 6 edits1 add in trunk/Source/WebKit2
More storage scaffolding
https://bugs.webkit.org/show_bug.cgi?id=110997
Reviewed by Andreas Kling.
- DerivedSources.make:
Add StorageAreaProxy.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::setItem):
Send back a DidSetItem message.
- WebKit2.xcodeproj/project.pbxproj:
Add generated files.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::StorageAreaProxy):
Add the message receiver.
(WebKit::StorageAreaProxy::~StorageAreaProxy):
Remove the message receiver.
(WebKit::StorageAreaProxy::didSetItem):
add stub.
- WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
- WebProcess/Storage/StorageAreaProxy.messages.in: Added.
- 11:40 AM Changeset in webkit [144217] by
-
- 8 edits in trunk/Source/WebKit2
REGRESSION: Loading flash switches to discrete graphics, 100 MB on membuster
<rdar://problem/13229828>
Reviewed by Dan Bernstein.
Due the change in CFBundleIdentifier, the WebProcess and PluginProcess were
unnecessarily muxing (they used to be whitelisted by OpenGL) to the discrete
GPU.
- PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
- WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
Add NSSupportsAutomaticGraphicsSwitching YES.
- WebKit2.xcodeproj/project.pbxproj:
Re-add the PluginService.32-64.Info.plist plist to the project file.
- 11:14 AM Changeset in webkit [144216] by
-
- 34 edits in trunk/Source
Don't add a body to platform request until necessary
https://bugs.webkit.org/show_bug.cgi?id=110900
Reviewed by NOBODY (OOPS!).
Reviewed by Brady Eidson.
ResourceRequest now has more state for syncing between resource and platform parts.
In addition to tracking which is up to date, we also track which has up to date
HTTP Body.
The reason is that we don't need the body on request before it's actually sent,
and we actually cannot build it when networking is out of process.
- WebCore.exp.in: Updated exports.
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setHTTPBody): Update HTTP body before returning it. (WebCore::ResourceRequestBase::updatePlatformRequest): Update according to HTTPBodyUpdatePolicy. (WebCore::ResourceRequestBase::updateResourceRequest): Ditto.
- platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::formDataStreamLengthPropertyName): (WebCore::formCopyProperty): (WebCore::setHTTPBody): Changed to not update Content-Length in platform request directly. We need to keep it in sync with resource request, and it's easier to do in a caller. Exposed computed length as a property do avoid duplicating the work.
- platform/network/cf/FormDataStreamCFNet.h: Removed unnecessary httpBodyFromStream().
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::ResourceHandle::createCFURLConnection): Update body when necessary.
(WebCore::ResourceRequest::nsURLRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdateResourceHTTPBody):
(WebCore):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody):
(WebCore::ResourceRequest::applyWebArchiveHackForMail):
Ditto.
- platform/network/cf/ResourceRequest.h: Track body up-to-date state.
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::cfURLRequest): Honor HTTPBodyUpdatePolicy. (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't update body here. (WebCore::ResourceRequest::doUpdatePlatformHTTPBody): Update the body, and make sure that Content-Length is correct. (WebCore::ResourceRequest::doUpdateResourceRequest): Don't update body here. (WebCore::ResourceRequest::doUpdateResourceHTTPBody): Update the body, fixing a bug where body stream was lost if this function got called. (WebCore::ResourceRequest::applyWebArchiveHackForMail): No need to update body for this one.
- platform/network/mac/ResourceRequestMac.mm: Ditto (but this didn't have a bug with streams in doUpdateResourceRequest()).
- platform/network/mac/FormDataStreamMac.h: Forward declare formDataStreamLengthPropertyName().
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::createNSURLConnection): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::platformLoadResourceSynchronously): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Update body when necessary.
- platform/network/blackberry/ResourceRequest.h:
- platform/network/chromium/ResourceRequest.h:
- platform/network/curl/ResourceRequest.h:
- platform/network/qt/ResourceRequest.h:
- platform/network/soup/ResourceRequest.h:
- platform/network/win/ResourceRequest.h: Added stubs for new functions. These ports don't keep a platform request in ResourceRequest, and don't need updating.
- 11:03 AM Changeset in webkit [144215] by
-
- 8 edits4 adds in trunk/LayoutTests
[Chromium] Test expectations updates
Unreviewed expectations after recent bug fixes.
- platform/chromium-mac-lion/fast/borders/border-radius-percent-expected.png: Added.
- platform/chromium-mac-lion/svg/css/text-shadow-multiple-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-radius-percent-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png:
- platform/chromium-mac/fast/borders/border-radius-percent-expected.png: Added.
- platform/chromium-mac/svg/css/text-shadow-multiple-expected.png:
- platform/chromium-mac/svg/custom/transform-with-shadow-and-gradient-expected.png:
- platform/chromium-win/fast/borders/border-radius-percent-expected.png: Added.
- platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
- platform/chromium-win/svg/custom/transform-with-shadow-and-gradient-expected.png:
- platform/chromium/TestExpectations:
- 10:46 AM Changeset in webkit [144214] by
-
- 19 edits in trunk
Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
https://bugs.webkit.org/show_bug.cgi?id=110944
Reviewed by Dean Jackson.
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
No new tests.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 10:43 AM Changeset in webkit [144213] by
-
- 10 edits in trunk
REGRESSION(r124739): fast/lists/list-marker-remove-crash.html hits an assertion in MoveParagraphs
https://bugs.webkit.org/show_bug.cgi?id=93247
Reviewed by Darin Adler.
Source/WebCore:
The listifyParagraph function inside InsertListCommand triggered a layout for the new list and updated
only the "start" Position. The insertion and layout may have changed the "end" Position as well. The patch
makes sure "end" is also recomputed.
Test: No new test, the patch fixes a regression.
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::listifyParagraph):
LayoutTests:
Update TestExpectations because the test doesn't crash any more.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt-4.8/TestExpectations:
- platform/qt-mac/TestExpectations:
- platform/qt/TestExpectations:
- 10:38 AM Changeset in webkit [144212] by
-
- 3 edits in trunk/Source/WebCore
Add ENABLE_STREAM guards to FileReaderLoader
https://bugs.webkit.org/show_bug.cgi?id=110938
Patch by Zach Kuznia <zork@chromium.org> on 2013-02-27
Reviewed by Hajime Morrita.
- fileapi/FileReaderLoader.cpp:
- fileapi/FileReaderLoader.h:
- 10:38 AM Changeset in webkit [144211] by
-
- 2 edits in trunk/Tools
Unreviewed. Remove myself from watchlist.
Patch by Yong Li <yong.li.webkit@outlook.com> on 2013-02-27
- Scripts/webkitpy/common/config/watchlist:
- 10:34 AM Changeset in webkit [144210] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix build when DFG_JIT is not enabled
https://bugs.webkit.org/show_bug.cgi?id=110991
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-02-27
Reviewed by Csaba Osztrogonác.
- jit/JIT.h:
(JSC::JIT::canBeOptimizedOrInlined):
- 10:19 AM Changeset in webkit [144209] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Fix bug in HTML5 Fullscreen API implementation that was preventing YouTube HTML5 media controls fullscreen button from working properly.
https://bugs.webkit.org/show_bug.cgi?id=110905
Patch by John Griggs <jgriggs@rim.com> on 2013-02-27
Reviewed by Yong Li.
Return true from ChromeClientBlackBerry::supportsFullScreenForElement instead of the negation of the boolean flag (withKeyboard) passed in.
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::supportsFullScreenForElement):
- 10:18 AM Changeset in webkit [144208] by
-
- 4 edits in trunk
Switch QtWebKit to GStreamer 1.0.
https://bugs.webkit.org/show_bug.cgi?id=106669.
Original patch by Sebastian Dröge.
Reviewed by Csaba Osztrogonác.
Source/WebCore:
- WebCore.pri:
Tools:
Build with GStreamer 1.0 if available, but support GStreamer 0.10
temporarily to make upgrading easy and the patch suitable for Qt5.
- qmake/mkspecs/features/features.prf:
- 10:01 AM Changeset in webkit [144207] by
-
- 2 edits in trunk/Websites/planet.webkit.org
Add Martin Robinson's blog to the planet
https://bugs.webkit.org/show_bug.cgi?id=110990
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-27
Reviewed by Eric Seidel.
- config.ini: Add my blog to the planet.
- 9:53 AM Changeset in webkit [144206] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove WebViewImpl::animate shimmy out through compositor
https://bugs.webkit.org/show_bug.cgi?id=110935
Reviewed by Adrienne Walker.
WebViewImpl::animate() and WebViewImpl::updateAnimations() are confusingly similar. ::animate() implements
the WebWidget API and is called by content::RenderWidget and WebViewHost. ::updateAnimations() implements
the WebLayerTreeViewClient API and is called by content::RenderWidgetCompositor and by ::animate(). The
important part of this indirection is that whenever the compositor is active, all animation calls must
route through cc::LayerTreeHost before entering into WebCore's animation code so that the compositor
can set the appropriate rate limiting state. Animations may originate from
content::RenderWidget::AnimateIfNeeded when in software and single threaded mode or from
cc::LayerTreeHost::updateAnimations in threaded compositing mode. In the long ago, content::RenderWidget had no
idea if compositing was active or not and always called WebWidget::animate(), so WebViewImpl::animate() had to
redirect to the compositor when appropriate.
Now (as of chromium r180947) RenderWidget calls WebWidget::animate only when in software mode and otherwise
calls directly into the compositor. Thus WebViewImpl::animate() no longer needs to do this check. In a
follow-up, WebViewImpl::updateAnimations will go away completely in favor of just calling WebWidget::animate in
all cases.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::updateAnimations):
- 9:48 AM Changeset in webkit [144205] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Fix BlackBerry::Platform::String to WTF::String conversion when the string is Latin-1-encoded.
https://bugs.webkit.org/show_bug.cgi?id=110986
Reviewed by Yong Li.
Internally reviewed by Nima Ghanavatian.
BlackBerry PR 292922
We were assuming all platform strings were valid UTF-8, which isn't true for Latin-1 strings.
- platform/text/blackberry/StringBlackBerry.cpp:
(WTF::String::String):
- 9:42 AM Changeset in webkit [144204] by
-
- 2 edits in trunk/Source/WebCore
[TexMap] REGRESSION(144183): It make negative delay tests fails
https://bugs.webkit.org/show_bug.cgi?id=110989
Reviewed by Noam Rosenthal.
Do not apply a negative offset to the animation starttime send to the GraphicLayerClient,
it needs the actual animation start not a virtual start.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::addAnimation):
- 9:35 AM Changeset in webkit [144203] by
-
- 3 edits2 adds in trunk
Fix SourceBufferList so SourceBuffer.append() calls are always rejected after the MediaSource is closed.
https://bugs.webkit.org/show_bug.cgi?id=110917
Reviewed by Eric Carlson.
Source/WebCore:
Test: http/tests/media/media-source/video-media-source-reject-append-after-reopening.html
- Modules/mediasource/SourceBufferList.cpp:
(WebCore::SourceBufferList::clear):
LayoutTests:
- http/tests/media/media-source/video-media-source-reject-append-after-reopening-expected.txt: Added.
- http/tests/media/media-source/video-media-source-reject-append-after-reopening.html: Added.
- 9:25 AM AddingFeatures edited by
- (diff)
- 9:20 AM Changeset in webkit [144202] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Context menu cannot be invoked after doing text selection in landscape mode
https://bugs.webkit.org/show_bug.cgi?id=110860
Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-02-27
Reviewed by Yong Li.
PR 290248 Internally reviewed by Mike Fenton
Add a parameter to notify the webpage client which parts of selection have
changed in visual or in its selected DOM content. Refactor the selection details
parameter to platform repo.
The reason of this issue is that when javascript triggers webpage layout, the selection
will update its apperance event when the selected content is not changed. We want
to hide the context menu only when the selected content is changed not when only its
visual is changed.
- 9:18 AM Changeset in webkit [144201] by
-
- 2 edits in trunk/Tools
Unreviewed. Added myself to committers.py
- Scripts/webkitpy/common/config/committers.py:
- 9:12 AM Changeset in webkit [144200] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] The virtual keyboard hides part of Signing In dialog
https://bugs.webkit.org/show_bug.cgi?id=110836
Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-02-27
Reviewed by Yong Li.
PR # 283427 Internally reviewed by Mike Fenton.
Store form credentials before javascript "onSubmit" event and notify
webpage client to save credentials after that event since javascript
may check credentials and stop the submission in its event handler.
- WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::CredentialTransformData):
(WebCore):
- WebCoreSupport/CredentialTransformData.h:
(CredentialTransformData):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
- WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):
- 9:07 AM Changeset in webkit [144199] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r144192.
http://trac.webkit.org/changeset/144192
https://bugs.webkit.org/show_bug.cgi?id=110984
Stored svn password on wrong computer (Requested by kkristof
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-27
- Scripts/webkitpy/common/config/committers.py:
- 9:02 AM Changeset in webkit [144198] by
-
- 2 edits in trunk/Source/Platform
[Chromium] Remove unused WebKitPlatformSupport class
https://bugs.webkit.org/show_bug.cgi?id=110982
Reviewed by Adam Barth.
Part of a larger refactoring series; see tracking bug 82948.
- chromium/public/Platform.h:
- 8:59 AM Changeset in webkit [144197] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskipp inspector tests after r144071.
- platform/qt/TestExpectations:
- 8:48 AM Changeset in webkit [144196] by
-
- 4 edits3 adds in trunk
REGRESSION (r134631) of border-radius percentage with border pixel
https://bugs.webkit.org/show_bug.cgi?id=110889
Reviewed by Simon Fraser.
Source/WebCore:
Fixing background color filling to handle "non renderable" rounded
rectangles.
Test: fast/borders/border-radius-percent.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
LayoutTests:
Adding new pixel test to verify the correct rendering of
rounded rectangle backgrounds with inner border radii that
exceed the dimensions of the inner edge of the border.
- fast/borders/border-radius-percent-expected.txt: Added.
- fast/borders/border-radius-percent.html: Added.
- platform/chromium-linux/fast/borders/border-radius-percent-expected.png: Added.
- platform/chromium/TestExpectations:
- 8:45 AM Changeset in webkit [144195] by
-
- 6 edits in trunk
[Chromium] Layout Test svg/custom/transform-with-shadow-and-gradient.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=76557
Reviewed by Stephen Chenney.
Source/WebCore:
Always use kDst_Mode transfer for the shadow looper. Using kSrc_Mode to enforce CSS
box-shadow opaqueness at this level is not necessary since the RenderBoxModel box
decoration code already makes sure that shadows are filled with opaque black.
This change aligns the SVG shadow behavior (and pixel results) with CG/Safari.
No new tests, coverage provided by existing tests.
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
LayoutTests:
- platform/chromium-linux/svg/css/text-shadow-multiple-expected.png:
- platform/chromium-linux/svg/custom/transform-with-shadow-and-gradient-expected.png:
- platform/chromium/TestExpectations:
- 8:42 AM Changeset in webkit [144194] by
-
- 4 edits in trunk/Source/WebCore
[V8] Generate a wrapper function for ReplaceableAttrSetter()
https://bugs.webkit.org/show_bug.cgi?id=110781
Reviewed by Adam Barth.
This is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings. This patch introduces an indirection function
for xxxReplaceableAttrSetter(), like this:
For non-custom replaceable setters (Note: One implementation
is enough for all replaceable setters in one interface.)
void V8XXX:::ReplaceableAttrSetterCallback(...) {
V8XXX::ReplaceableAttrSetter(...);
}
For custom replaceable setters. (Note: This is treated as
a normal custom setter.)
void xxxAttrSetterCallback(...) {
return xxxAttrSetterCustom(...);
}
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateReplaceableAttrSetterCallback):
(GenerateReplaceableAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::TestObjReplaceableAttrSetterCallback):
(TestObjV8Internal):
(WebCore):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::TestTypedefsReplaceableAttrSetterCallback):
(TestTypedefsV8Internal):
- 8:26 AM Changeset in webkit [144193] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Accept key events even when composing region is active.
https://bugs.webkit.org/show_bug.cgi?id=110617
Reviewed by Rob Buis.
PR 293598.
Fix a regression in the previous patch caused
by an unhandled Alt key down being sent through
by IMF.
Reviewed Internally by Nima Ghanavatian.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::updateFormState):
- WebKitSupport/InputHandler.h:
(InputHandler):
- 8:21 AM Changeset in webkit [144192] by
-
- 2 edits in trunk/Tools
Unreviewed. Added myself to committers.py
- Scripts/webkitpy/common/config/committers.py:
- 8:18 AM Changeset in webkit [144191] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Flash objects won't load until scrolling page
https://bugs.webkit.org/show_bug.cgi?id=110149
Reviewed by Simon Hausmann.
Revert r134222. The issue from bug 101836 is no longer reproducable,
and the fix was causing flash objects to not load properly.
- plugins/PluginPackage.cpp:
(WebCore::PluginPackage::determineQuirks):
- 8:16 AM Changeset in webkit [144190] by
-
- 36 edits7 adds in trunk
[Texmap] TextureMapper is too eager to use intermediate surfaces
https://bugs.webkit.org/show_bug.cgi?id=110762
Patch by No'am Rosenthal <Noam Rosenthal> on 2013-02-27
Reviewed by Allan Sandfeld Jensen.
Source/WebCore:
Refactor the way intermediate surfaces are handled in TextureMapperLayer.
Beforehand, we would create an intermediate surface whenever there is a chance of overlap, and
the intermediate surface would be the largest possible. The result would then be drawn to the
target surface with the layer's opacity and mask.
This would make it so that (1) surfaces are created even when they're not needed, i.e. when there
is no actual overlap, and (2) mask wouldn't be applied correctly.
In this patch the behavior is changed so that the area to be painted is divided to "overlapping"
and "non overlapping" regions. The non-overlapping regions are painted directly, while the overlapping
regions are tiled to smaller rectangles painted using an intermediate surface.
Masks are applied to those intermediate surfaces based on the transform of the actual mask, not drawn
together with the content texture like before.
This optimizes for the more common case of opacity animations on a large tree, while making the quite
rare case of composited masks slightly less optimized but always correct.
Tests: compositing/overlap-blending/children-opacity-huge.html
compositing/overlap-blending/reflection-opacity-huge.html
compositing/overlap-blending/children-opacity-no-overlap.html
- platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
- platform/graphics/cairo/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
- platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::paintToTextureMapper):
- platform/graphics/qt/MediaPlayerPrivateQt.h:
(MediaPlayerPrivateQt):
- platform/graphics/surfaces/GraphicsSurface.cpp:
(WebCore::GraphicsSurface::paintToTextureMapper):
- platform/graphics/surfaces/GraphicsSurface.h:
(GraphicsSurface):
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
- platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
- platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
- platform/graphics/texmap/TextureMapperBackingStore.h:
(TextureMapperBackingStore):
- platform/graphics/texmap/TextureMapperPlatformLayer.h:
(TextureMapperPlatformLayer):
- platform/graphics/texmap/TextureMapperSurfaceBackingStore.cpp:
(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):
- platform/graphics/texmap/TextureMapperSurfaceBackingStore.h:
(TextureMapperSurfaceBackingStore):
- platform/graphics/texmap/TextureMapperTile.cpp:
(WebCore::TextureMapperTile::paint):
- platform/graphics/texmap/TextureMapperTile.h:
(TextureMapperTile):
- platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper):
- platform/graphics/texmap/TextureMapperTiledBackingStore.h:
(TextureMapperTiledBackingStore):
- platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp:
(WebCore::CoordinatedBackingStore::paintTilesToTextureMapper):
(WebCore::CoordinatedBackingStore::paintToTextureMapper):
- platform/graphics/texmap/coordinated/CoordinatedBackingStore.h:
(CoordinatedBackingStore):
Removed the "mask" parameter from TextureMapperPlatformLayer and overrides, since
we no longer paint the contents and the mask in the same pass.
- platform/graphics/texmap/TextureMapper.cpp:
(WebCore::TextureMapper::TextureMapper):
- platform/graphics/texmap/TextureMapper.h:
(WebCore::TextureMapper::setMaskMode):
(TextureMapper):
(WebCore::TextureMapper::isInMaskMode):
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawNumber):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::draw):
(WebCore):
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
(WebCore::TextureMapperGL::drawFiltered):
- platform/graphics/texmap/TextureMapperGL.h:
(TextureMapperGL):
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::TextureMapperImageBuffer::drawTexture):
(WebCore::TextureMapperImageBuffer::drawSolidColor):
- platform/graphics/texmap/TextureMapperImageBuffer.h:
(TextureMapperImageBuffer):
Instead of painting the mask together with the texture/color, paint the mask
by drawing with DestinationIn to an existing surface.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(TextureMapperPaintOptions):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::shouldBlend):
(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperLayer::replicaTransform):
(WebCore):
(WebCore::applyFilters):
(WebCore::resolveOverlaps):
(WebCore::TextureMapperLayer::computeOverlapRegions):
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):
(WebCore::TextureMapperLayer::applyMask):
(WebCore::TextureMapperLayer::paintIntoSurface):
(WebCore::commitSurface):
(WebCore::TextureMapperLayer::paintWithIntermediateSurface):
(WebCore::TextureMapperLayer::paintRecursive):
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::hasFilters):
- platform/graphics/texmap/TextureMapperShaderProgram.cpp:
(WebCore):
(WebCore::TextureMapperShaderProgram::create):
- platform/graphics/texmap/TextureMapperShaderProgram.h:
LayoutTests:
Added a few ref-tests for correct overlap blending in accelearated compositing mode.
Skipping the new reflection test on Mac/Chromium since it's not rendered
properly on those platforms.
- compositing/overlap-blending/children-opacity-huge-expected.html: Added.
- compositing/overlap-blending/children-opacity-huge.html: Added.
- compositing/overlap-blending/children-opacity-no-overlap-expected.html: Added.
- compositing/overlap-blending/children-opacity-no-overlap.html: Added.
- compositing/overlap-blending/reflection-opacity-huge-expected.html: Added.
- compositing/overlap-blending/reflection-opacity-huge.html: Added.
- 8:13 AM Changeset in webkit [144189] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Template element support is already enabled in
development builds. Removing skip entries for related tests as they all pass.
- 8:11 AM Changeset in webkit [144188] by
-
- 5 edits3 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining after r144096.
- platform/gtk/TestExpectations:
- platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt:
- platform/gtk/css2.1/replaced-elements-001-expected.png: Added.
- platform/gtk/css3/flexbox/button-expected.png: Added.
- platform/gtk/css3/flexbox/button-expected.txt: Added.
- platform/gtk/svg/custom/foreign-object-skew-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug92647-2-expected.txt:
- 8:03 AM Changeset in webkit [144187] by
-
- 2 edits in trunk/LayoutTests
Add plugins test expectations for content_shell
Unreviewed gardening.
- platform/chromium/ContentShellTestExpectations:
- 7:48 AM Changeset in webkit [144186] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [REGRESSION] [Audits] Disabled "Run" button styling is the same as the enabled one
https://bugs.webkit.org/show_bug.cgi?id=110971
Reviewed by Yury Semikhatsky.
Split out PanelEnablerView-related rules into panelEnabledView.css and restored the missing rules
in inspector.css.
- inspector/front-end/inspector.css:
- inspector/front-end/panelEnablerView.css:
- 7:35 AM Changeset in webkit [144185] by
-
- 3 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r144179.
http://trac.webkit.org/changeset/144179
https://bugs.webkit.org/show_bug.cgi?id=110980
Breaks compilation (Requested by vsevik on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-27
- public/WebTextInputType.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputInfo):
(WebKit::WebViewImpl::textInputType):
- 7:29 AM Changeset in webkit [144184] by
-
- 8 edits in trunk
REGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type=date] unexpectedly makes another line for ::-webkit-calendar-picker-indicator
https://bugs.webkit.org/show_bug.cgi?id=110974
Reviewed by Kentaro Hara.
Source/WebCore:
Input elements with the multiple fields UI require flexible box
layout. We should use RenderFlexibleBox regardless of display
property values.
Tests: Update fast/forms/date/date-apparance-basic.html
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createRenderer):
Always use RenderFlexibleBox.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Declare createRenderer.
LayoutTests:
- fast/forms/date/date-appearance-basic-expected.txt:
- fast/forms/date/date-appearance-basic.html:
- platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium/TestExpectations:
- 7:27 AM Changeset in webkit [144183] by
-
- 3 edits in trunk/Source/WebCore
[TexMap] Flickering after transitions on Apple HTML5 demo
https://bugs.webkit.org/show_bug.cgi?id=102501
Reviewed by Noam Rosenthal.
Notify about animation start after the new animation is actually commited.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
(WebCore::GraphicsLayerTextureMapper::addAnimation):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
- 7:11 AM Changeset in webkit [144182] by
-
- 9 edits1 add in trunk
Web Inspector: Refactor AuditsPanel with AuditController as newly introduced entity
https://bugs.webkit.org/show_bug.cgi?id=110866
Reviewed by Alexander Pavlov.
Source/WebCore:
AuditController is being introduced in order to follow MVC pattern with the Audits.
This is the first step about the refactoring. Moving the methods from the AuditsPanel
into AuditController would ease the event driven approach to de-couple the AuditsPanel
and the AuditLauncherView.
No new tests as code refactoring.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/AuditController.js: Added.
(WebInspector.AuditController):
(WebInspector.AuditController.prototype.ruleResultReadyCallback):
(WebInspector.AuditController.prototype.categoryDoneCallback):
(WebInspector.AuditController.prototype._executeAudit):
(WebInspector.AuditController.prototype._auditFinishedCallback):
(WebInspector.AuditController.prototype.startAuditWhenResourcesReady):
(WebInspector.AuditController.prototype.initiateAudit):
(WebInspector.AuditController.prototype._reloadResources):
(WebInspector.AuditController.prototype._didMainResourceLoad):
- inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView):
(WebInspector.AuditLauncherView.prototype._startAudit):
- inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
(WebInspector.AuditsPanel.prototype.auditFinishedCallback):
- inspector/front-end/WebKit.qrc:
LayoutTests:
- inspector/extensions/extensions-audits-tests.js:
- 7:11 AM Changeset in webkit [144181] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] GIFImageDecoderTest.parseAndDecodeByteByByte failing on Android
https://bugs.webkit.org/show_bug.cgi?id=110922
Unreviewed build fix.
- tests/GIFImageDecoderTest.cpp:
(WebKit):
(WebKit::TEST): Disable the entire test on Android.
- 7:00 AM Changeset in webkit [144180] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 6:54 AM Changeset in webkit [144179] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Should not return WebTextInputTypeNone for date input element.
https://bugs.webkit.org/show_bug.cgi?id=110740
Patch by Seigo Nonaka <nona@chromium.org> on 2013-02-27
Reviewed by Kent Tamura.
In the case of Windows 8, text input state including on-screen keyboard is controlled by the
value of WebTextInputType returned from WebViewImpl::textInputType().
In past, it returned WebTextInputTypeDate for date text input but now it returns
WebTextInputTypeNone.
WebTextInputTypeNone is used for non editable node, so on-screen keyboard will be hidden if
the date text input is focused. So there is no way to input on Windows 8 tablet without
physical keyboard except tapping small up/down arrow.
- public/WebTextInputType.h: Introduces WebTextInputTypeDateTimeField.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputInfo): Fills type filed regardless of editable or not. It is
safe because textInputType returns editable type only for known editable element.
(WebKit::WebViewImpl::textInputType): Returns WebTextInputTypeDateTimeField for the date
time field element.
- 6:50 AM Changeset in webkit [144178] by
-
- 3 edits8 adds in trunk
[CSS Regions] Region overset property is not properly computed when there is a region break
https://bugs.webkit.org/show_bug.cgi?id=92497
Patch by Mihai Maerean <Mihai Maerean> on 2013-02-27
Reviewed by David Hyatt.
Source/WebCore:
For "paginated" content in regions that has -webkit-region-break-after:always, the bottom margin was being passed
along for the next region in the chain, which shouldn't happen.
The fix is, at layout, to clear the bottom margin for the nodes (inside paginated contexts) that have
-webkit-region-break-after:always.
Tests: fast/multicol/break-after-always-bottom-margin.html
fast/regions/overset-break-nested.html
fast/regions/overset-break-with-sibling.html
fast/regions/overset-break.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::applyAfterBreak):
LayoutTests:
- fast/multicol/break-after-always-bottom-margin-expected.txt: Added.
- fast/multicol/break-after-always-bottom-margin.html: Added.
- fast/regions/overset-break-expected.txt: Added.
- fast/regions/overset-break-nested-expected.txt: Added.
- fast/regions/overset-break-nested.html: Added.
- fast/regions/overset-break-with-sibling-expected.txt: Added.
- fast/regions/overset-break-with-sibling.html: Added.
- fast/regions/overset-break.html: Added.
- 6:47 AM Changeset in webkit [144177] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 6:46 AM Changeset in webkit [144176] by
-
- 2 edits in trunk/Source/WebCore
Bindings test results update after r144126
https://bugs.webkit.org/show_bug.cgi?id=108196
Unreviewed test update.
- bindings/scripts/test/JS/JSTestObj.cpp: Add include of CallbackFunction.h
- 5:49 AM Changeset in webkit [144175] by
-
- 5 edits in trunk/LayoutTests
[chromium] Adapt test expectations to V8 proto changes.
https://bugs.webkit.org/show_bug.cgi?id=110887
Patch by Michael Starzinger <mstarzinger@chromium.org> on 2013-02-27
Reviewed by Stephen Chenney.
ad window-custom-prototype) This is expected bahavior, consistent with
SpiderMonkey. The test expectation is broken. Assigning 'null' to
'proto' makes the accessor installed on Object.prototype disappear.
ad JSON-parse) The result of JSON.parse() doesn't match the result we
get when evaluating the same string through eval() as V8 still has
special handling of the proto property for object literals.
ad cyclic-prototypes) Test fully matches the WebKit expectation now and
no longer fails. However the exception message has a slightly different
format and hence causes a text diff.
- platform/chromium/TestExpectations: Temporary mark tests failing.
- platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt:
- platform/chromium/fast/js/JSON-parse-expected.txt:
- platform/chromium/fast/js/cyclic-prototypes-expected.txt:
- 5:34 AM Changeset in webkit [144174] by
-
- 2 edits in trunk/Source/WTF
Bug in atomicIncrement implementation for MIPS GCC
https://bugs.webkit.org/show_bug.cgi?id=110969
Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-02-27
Reviewed by Csaba Osztrogonác.
Fix of sync_[add|sub]_and_fetch_8 for GCC patch.
- wtf/Atomics.cpp:
- 5:07 AM Changeset in webkit [144173] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed inspector front-end closure compilaiton fix.
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
- 4:49 AM Changeset in webkit [144172] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 4:38 AM Changeset in webkit [144171] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 4:09 AM Changeset in webkit [144170] by
-
- 2 edits in trunk/Source/WTF
REGRESSION(r137994): It made JSC tests hang and layout tests fail on ARM Thumb2 / Linux
https://bugs.webkit.org/show_bug.cgi?id=108632
Patch by Simon Hausmann <simon.hausmann@digia.com> on 2013-02-27
Reviewed by Csaba Osztrogonác.
It appears that mprotect() is very slow on ARM/Linux, so disable the
approach of unreserved mappings there and fall back to overcomitting
memory, based on Uli Schlachter's recommendation.
- wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::decommit):
- 4:05 AM Changeset in webkit [144169] by
-
- 3 edits in trunk/Source/WebCore
[texmap] Do not apply clip state if redundant
https://bugs.webkit.org/show_bug.cgi?id=110790
Reviewed by Noam Rosenthal.
Add a bool to check if clip state has changed since last apply.
No behavior changes, thus covered by existing tests.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::ClipStack::reset):
(WebCore::TextureMapperGL::ClipStack::pop):
(WebCore::TextureMapperGL::ClipStack::apply):
- platform/graphics/texmap/TextureMapperGL.h:
(WebCore::TextureMapperGL::ClipStack::ClipStack):
(ClipStack):
- 4:05 AM Changeset in webkit [144168] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt][Mac] Fix massive parallel builds
Reviewed by Tor Arne Vestbø.
There exists a race condition that LLIntDesiredOffsets.h is written to
by two parllel instances of the ruby script. This patch ensures that similar to the output file,
the generated file is also prefixed according to the build configuration.
- LLIntOffsetsExtractor.pro:
- 4:03 AM Changeset in webkit [144167] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 3:51 AM Changeset in webkit [144166] by
-
- 3 edits in trunk/LayoutTests
MediaStream constructor test should cover ended MediaStreamTrack.
https://bugs.webkit.org/show_bug.cgi?id=110941
Reviewed by Kentaro Hara.
Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#mediastream
If tracks has ended, it should skip these tracks and continue with the next one.
- fast/mediastream/MediaStreamConstructor-expected.txt:
- fast/mediastream/MediaStreamConstructor.html:
- 3:40 AM Changeset in webkit [144165] by
-
- 7 edits in trunk/Source/WebKit2
[Qt][WK2] Replace use of WebPreferences with use of WKPrefences C API
https://bugs.webkit.org/show_bug.cgi?id=108952
Reviewed by Simon Hausmann.
Signed off for WebKit2 by Benjamin Poulain.
This patch moves the view classes and preferences in the Qt API
to use the C API for accessing and manipulating preferences as
part of the cleanup and move towards using the C API as base for
the Qt WebKit2 API.
Adds the function WebKit::adoptToQString for convenience when
dealing with QString and copied String objects.
Removes the ScrollAnimatorEnabled options from QWebPreferences.
- UIProcess/API/cpp/qt/WKStringQt.cpp:
(WebKit::adoptToQString):
- UIProcess/API/cpp/qt/WKStringQt.h:
(WebKit):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
- UIProcess/API/qt/qwebpreferences.cpp:
(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::setFontFamily):
(QWebPreferencesPrivate::fontFamily):
(QWebPreferencesPrivate::setFontSize):
(QWebPreferencesPrivate::fontSize):
- UIProcess/API/qt/qwebpreferences_p.h:
- UIProcess/API/qt/qwebpreferences_p_p.h:
- 3:07 AM Changeset in webkit [144164] by
-
- 1 edit1 add in trunk/LayoutTests
[EFL] Unreviewed gardening
Updated tests baselines.
- platform/efl/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
- 2:53 AM Changeset in webkit [144163] by
-
- 1 edit2 adds in trunk/LayoutTests
XHR should fire 'abort' event when navigation interrupts a request.
https://bugs.webkit.org/show_bug.cgi?id=110867
Reviewed by Alexey Proskuryakov.
Adding a layout test to ensure that navigation-canceled XMLHttpRequests
fire an 'abort' event rather than an 'error' event.
- http/tests/xmlhttprequest/navigation-should-abort-expected.txt: Added.
- http/tests/xmlhttprequest/navigation-should-abort.html: Added.
- 2:16 AM Changeset in webkit [144162] by
-
- 2 edits in trunk/Tools
Build fix after r144155. The report page is located at /api/report, not /api/test/report.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._upload_json):
- 2:15 AM Changeset in webkit [144161] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: timeline stops working on certain sites
https://bugs.webkit.org/show_bug.cgi?id=110955
Reviewed by Alexander Pavlov.
Analysis: "timerId" value is number,
so it is not wrapped to node as expected.
Solution: wrap values of all types except Node.
- inspector/front-end/TimelinePresentationModel.js:
Wrap nonstring values to text nodes.
- 2:03 AM Changeset in webkit [144160] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening
Mark custom elements tests as failures until we enable them.
- platform/efl/TestExpectations:
- 1:22 AM Changeset in webkit [144159] by
-
- 2 edits in trunk/LayoutTests
[EFL] Remove test related to html5lib after r144032
https://bugs.webkit.org/show_bug.cgi?id=110946
Unreviewed, EFL gardening.
Test was removed after r144032. And remove it from TestExpectations.
html5lib/generated/run-template.html.
Patch by Seokju Kwon <Seokju Kwon> on 2013-02-27
- platform/efl/TestExpectations:
- 1:21 AM Changeset in webkit [144158] by
-
- 2 edits in trunk/Source/WebCore
HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser can trigger ASSERT(m_speculations.isEmpty())
https://bugs.webkit.org/show_bug.cgi?id=110949
Reviewed by Eric Seidel.
We can hit this ASSERT if didReceiveParsedChunkFromBackgroundParser is
called from the background thread while we're processing
m_speculations (i.e., if processing m_speculations is taking a while
and we've yielded to the event loop).
It's hard to write a deterministic test for this patch, but it's hit
quite often with existing LayoutTests.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
- 1:09 AM Changeset in webkit [144157] by
-
- 4 edits in trunk/Source/WebCore
[V8] Generate a wrapper function for named constructor callbacks
https://bugs.webkit.org/show_bug.cgi?id=110794
Reviewed by Adam Barth.
This would be the final step of generating wrapper functions.
The patch generates the following wrapper function for named
constructor callbacks.
Handle<Value> namedConstructorCallback(...)
{
return namedConstructor(...);
}
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructor):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::namedConstructor):
(WebCore::namedConstructorCallback):
(WebCore):
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::namedConstructor):
(WebCore::namedConstructorCallback):
(WebCore):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):
- 1:02 AM Changeset in webkit [144156] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 12:56 AM Changeset in webkit [144155] by
-
- 2 edits in trunk/Tools
Stop uploading results to webkit-perf.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=110954
Reviewed by Benjamin Poulain.
When the specified test results server was webkit-perf.appspot.com, replace it by perf.webkit.org.
Also, always use the new JSON format. Removed the code to generate the old format.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_and_show_results):
(PerfTestsRunner._generate_results_dict):
(PerfTestsRunner._merge_slave_config_json):
(PerfTestsRunner._generate_output_files):
- 12:37 AM Changeset in webkit [144154] by
-
- 12 edits in trunk
Web Inspector: show raster tasks on Timeline
https://bugs.webkit.org/show_bug.cgi?id=105851
- add DeferPaint, Paint & RasterTask trace events handling to trace event processor;
- upon begin frame, emit aggregated background event for all raster tasks related to inspected page.
Reviewed by Pavel Feldman.
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(InstrumentationEvents):
(InstrumentationEventArguments):
- inspector/InspectorInstrumentation.h:
(InstrumentationEvents):
(WebCore):
(InstrumentationEventArguments):
- inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::didBeginFrame):
- inspector/InspectorTimelineAgent.h:
(TimelineRecordType):
(WebCore):
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createRasterData):
(WebCore):
- inspector/TimelineRecordFactory.h:
(TimelineRecordFactory):
- inspector/TimelineTraceEventProcessor.cpp:
(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::~TimelineTraceEventProcessor):
(WebCore):
(WebCore::TimelineTraceEventProcessor::registerHandler):
(WebCore::TimelineTraceEventProcessor::shutdown):
(WebCore::TimelineTraceEventProcessor::TraceEvent::findParameter):
(WebCore::TimelineTraceEventProcessor::TraceEvent::parameter):
(WebCore::TimelineTraceEventProcessor::processEventOnAnyThread):
(WebCore::TimelineTraceEventProcessor::onBeginFrame):
(WebCore::TimelineTraceEventProcessor::onPaintLayerBegin):
(WebCore::TimelineTraceEventProcessor::onPaintLayerEnd):
(WebCore::TimelineTraceEventProcessor::onRasterTaskBegin):
(WebCore::TimelineTraceEventProcessor::onRasterTaskEnd):
(WebCore::TimelineTraceEventProcessor::onLayerDeleted):
(WebCore::TimelineTraceEventProcessor::onPaint):
(WebCore::TimelineTraceEventProcessor::flushRasterizerStatistics):
(WebCore::TimelineTraceEventProcessor::sendTimelineRecord):
(WebCore::TimelineTraceEventProcessor::processBackgroundEvents):
- inspector/TimelineTraceEventProcessor.h:
(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::id):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asUInt):
(TimelineTraceEventProcessor):
- inspector/front-end/TimelineModel.js:
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel._initRecordStyles):
- 12:33 AM Changeset in webkit [144153] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 12:23 AM Changeset in webkit [144152] by
-
- 12 edits in trunk/LayoutTests
Fix the tests based on computedStyleIncludingVisitedInfo for asynchronous update of the visited style
https://bugs.webkit.org/show_bug.cgi?id=110708
Reviewed by Ryosuke Niwa.
The tests using computedStyleIncludingVisitedInfo were using the asumption that visited style
is updated synchronously with the loading of resources.
This assumption is valid for Mac WebKit1, but does not hold for multiprocess
WebKit because the list of visited URLs is maintained outside the WebProcess.
This patch changes the tests to use the 'shouldBecomeXXX' test functions in order to wait
for the asynchronous update. With the change, all the tests succeed reliably on WebKit2.
- fast/history/multiple-classes-visited-expected.txt:
- fast/history/multiple-classes-visited.html:
- fast/history/nested-visited-test-expected.txt:
- fast/history/nested-visited-test.html:
- fast/history/self-is-visited-expected.txt:
- fast/history/self-is-visited.html:
- fast/history/sibling-visited-test-expected.txt:
- fast/history/sibling-visited-test.html:
- fast/js/resources/js-test-pre.js:
(.condition):
(.failureHandler):
(shouldBecomeDifferent):
- platform/wk2/TestExpectations:
- platform/chromium/TestExpectations: The tests can now also timeout due to
computedStyleIncludingVisitedInfo missing from Chromium's DRT.
- 12:09 AM Changeset in webkit [144151] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed gardening.
- 12:04 AM Changeset in webkit [144150] by
-
- 11 edits2 copies15 deletes in trunk
Unreviewed, rolling out r144136, r144143, and r144147.
http://trac.webkit.org/changeset/144136
http://trac.webkit.org/changeset/144143
http://trac.webkit.org/changeset/144147
https://bugs.webkit.org/show_bug.cgi?id=110950
Caused some timeouts and flaky crashes (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-27
Tools:
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
LayoutTests:
- platform/chromium-mac/security/block-test-no-port-expected.txt: Copied from LayoutTests/platform/chromium/security/block-test-no-port-expected.txt.
- platform/chromium-win/fast/images/support-broken-image-delegate-expected.txt:
- platform/chromium-win/http/tests/loading/redirect-methods-expected.txt:
- platform/chromium-win/security/block-test-no-port-expected.txt: Copied from LayoutTests/platform/chromium/security/block-test-no-port-expected.txt.
- platform/chromium/TestExpectations:
- platform/chromium/fast/images/support-broken-image-delegate-expected.txt:
- platform/chromium/fast/loader/main-document-url-for-non-http-loads-expected.txt: Removed.
- platform/chromium/http/tests/loading/307-after-303-after-post-expected.txt: Removed.
- platform/chromium/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Removed.
- platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
- platform/chromium/http/tests/misc/window-dot-stop-expected.txt: Removed.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-allowall-expected.txt: Removed.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Removed.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Removed.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Removed.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Removed.
- platform/chromium/inspector/debugger/pause-in-inline-script-expected.txt: Removed.
- platform/chromium/inspector/timeline/timeline-script-tag-1-expected.txt: Removed.
- platform/chromium/security/block-test-no-port-expected.txt:
Feb 26, 2013:
- 11:32 PM Changeset in webkit [144149] by
-
- 8 edits in trunk/LayoutTests
One more unreviewed fix after r144032 and r144051.
https://bugs.webkit.org/show_bug.cgi?id=110734
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2013-02-26
- TestExpectations: Unskip tests.
- html5lib/generated/run-template-write.html: Revert an accidental change by r144051.
- platform/gtk/TestExpectations: Skip run-template-data.html and run-template-write.html instead of run-template.html
- platform/mac/TestExpectations: Ditto.
- platform/qt/TestExpectations: Ditto.
- platform/win/TestExpectations: Ditto.
- platform/wincairo/TestExpectations: Ditto.
- 11:17 PM Changeset in webkit [144148] by
-
- 6 edits in trunk/Source
Unreviewed, rolling out r144129.
http://trac.webkit.org/changeset/144129
https://bugs.webkit.org/show_bug.cgi?id=110947
Breaks compilation on chromium mac and win (Requested by
vsevik on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-26
Source/Platform:
- chromium/public/WebLayerTreeViewClient.h:
(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::willBeginFrame):
(WebKit::WebLayerTreeViewClient::didBeginFrame):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::willBeginFrame):
(WebKit):
(WebKit::WebViewImpl::didBeginFrame):
- src/WebViewImpl.h:
- tests/WebLayerTreeViewTestCommon.h:
- 10:18 PM Changeset in webkit [144147] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Note another multipart failure to work through.
- platform/chromium/TestExpectations:
- 10:16 PM Changeset in webkit [144146] by
-
- 3 edits2 adds in trunk
getPropertyValue for -webkit-column-rule returns null, should compute the shorthand value
https://bugs.webkit.org/show_bug.cgi?id=110698
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-02-26
Reviewed by Alexander Pavlov.
Source/WebCore:
Test: fast/css/getPropertyValue-column-rule.html
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
LayoutTests:
- fast/css/getPropertyValue-column-rule-expected.txt: Added.
- fast/css/getPropertyValue-column-rule.html: Added.
- 10:14 PM Changeset in webkit [144145] by
-
- 3 edits2 adds in trunk
getPropertyValue for -webkit-margin-collapse returns null, should compute the shorthand value
https://bugs.webkit.org/show_bug.cgi?id=110903
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-02-26
Reviewed by Alexander Pavlov.
Source/WebCore:
getPropertyValue("-webkit-margin-collapse") should compute shorthand value
when -webkit-margin-collapse is specified in CSS.
Test: fast/css/getPropertyValue-webkit-margin-collapse.html
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
LayoutTests:
Added test for getPropertyValue("-webkit-margin-collapse").
- fast/css/getPropertyValue-webkit-margin-collapse-expected.txt: Added.
- fast/css/getPropertyValue-webkit-margin-collapse.html: Added.
- 10:06 PM Changeset in webkit [144144] by
-
- 3 edits2 adds in trunk
getPropertyValue for -webkit-marquee returns null, should compute the shorthand value
https://bugs.webkit.org/show_bug.cgi?id=110816
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-02-26
Reviewed by Alexander Pavlov.
Source/WebCore:
Compute the shorthand value for '-webkit-marquee' specified in CSS.
Test: fast/css/getPropertyValue-webkit-marquee.html
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
LayoutTests:
Added testcases to check getPropertyValue for -webkit-marquee shorthand.
- fast/css/getPropertyValue-webkit-marquee-expected.txt: Added.
- fast/css/getPropertyValue-webkit-marquee.html: Added.
- 9:51 PM Changeset in webkit [144143] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Update expectations to show new FrameLoaderClient callbacks. I missed
this test earlier because it doesn't run on Linux.
- platform/chromium-win/http/tests/loading/redirect-methods-expected.txt:
- 9:11 PM Changeset in webkit [144142] by
-
- 3 edits in trunk/Source/WebCore
[V8] Remove Event::dataTransferAttrGetterCustom() and Event::valueAttrSetterCustom()
https://bugs.webkit.org/show_bug.cgi?id=110666
Reviewed by Adam Barth.
Event::dataTransferAttrGetterCustom() is not used
(i.e. the custom method is not registered to V8).
Event::valueAttrSetterCustom() is declared but not
implemented. We can remove them.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderCustomCall):
- bindings/v8/custom/V8EventCustom.cpp:
- 9:02 PM Changeset in webkit [144141] by
-
- 5 edits1 add in trunk
Use perf.webkit.org JSON format in results page
https://bugs.webkit.org/show_bug.cgi?id=110842
Reviewed by Benjamin Poulain.
PerformanceTests:
Updated the results page template to use the new JSON format.
Since new JSON format doesn't contain statistics such as stdev and min, added statistics.js to compute
these values. Also use 95% percentile confidence interval instead of standard deviation in various places.
- resources/results-template.html: Added statistics.js as dependency.
(TestResult): Updated to take a metric instead of its test. Replaced stdev() with confidenceIntervalDelta()
now that we have a fancy Statistics class.
(TestRun.webkitRevision):
(PerfTestMetric): Renamed from PerfTest since this object now encapsulates each measurement (such as time,
JS heap, and malloc) in test. Also added a conversion table from a metric name to a unit since new format
doesn't contain units.
(PerfTestMetric.name): Updated to compute the full metric name from test name and metric name, matching
the old behavior.
(PerfTestMetric.isMemoryTest): Explicitly look for 'JSHeap' and 'Malloc' tests.
(PerfTestMetric.smallerIsBetter):
(attachPlot): Deleted the code to deal with tests that don't provide individual iteration measurement
since such tests no longer exist. Also fixed up the code compute y-axis range.
(createTableRow.markupForRun): Updated to use confidenceIntervalDelta() instead of stdev().
(init.addTests): Added. Recursively add metrics.
- resources/statistics.js: Added. Imported from perf.webkit.org.
(Statistics.max):
(Statistics.min):
(Statistics.sum):
(Statistics.squareSum):
(Statistics.sampleStandardDeviation):
(Statistics.supportedConfidenceLevels):
(Statistics.confidenceIntervalDelta):
(Statistics.confidenceInterval):
Tools:
Change the default JSON format from that of webkit-perf.appspot.com to that of perf.webkit.org.
A whole bunch of integration tests have been updated to use the new JSON format.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_and_show_results): Renamed output and output_path to legacy_output
and legacy_output_json_path respectively.
(PerfTestsRunner._generate_results_dict): Don't assume meta build information is always available.
(PerfTestsRunner._generate_output_files): Make json_output, which is used to generate the default
JSON file and the results page out of perf_webkit_output instead of legacy_output.
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(MainTest.test_run_memory_test):
(MainTest._test_run_with_json_output.mock_upload_json):
(MainTest):
(MainTest.test_run_with_json_output):
(MainTest.test_run_with_description):
(MainTest.test_run_generates_json_by_default):
(MainTest.test_run_merges_output_by_default):
(MainTest.test_run_respects_reset_results):
(MainTest.test_run_generates_and_show_results_page):
(MainTest.test_run_with_slave_config_json):
(MainTest.test_run_with_multiple_repositories):
(MainTest.test_run_with_upload_json):
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
- 8:34 PM Changeset in webkit [144140] by
-
- 2 edits in trunk/Source/WebCore
SelectorQuery should not ever use ResolvingStyle mode.
https://bugs.webkit.org/show_bug.cgi?id=110843
It looks like we accidentally used ResolvingStyle mode for webkitMatchesSelector, and I exacerbated the problem
in r143858 by switching all of SelectorQuery to use it. There aren't any visible effects, but the style bits
of elements are unnecessarily twiddled when if we do that. Let's not do it.
Reviewed by Eric Seidel.
No public-facing behavior change, covered by existing tests.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches): Switched to always use QueryingRules mode.
- 8:32 PM Changeset in webkit [144139] by
-
- 2 edits in trunk/Source/WebCore
Silence this ASSERT. It is triggered by the threaded HTML parser.
Investigation to follow in https://bugs.webkit.org/show_bug.cgi?id=110937
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::checkLoadComplete):
- 8:26 PM Changeset in webkit [144138] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r184829. Requested by
"Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-26
- DEPS:
- 7:52 PM Changeset in webkit [144137] by
-
- 15 edits3 adds in trunk
DFG OSR exit doesn't know which virtual register to use for the last result register for post_inc and post_dec
https://bugs.webkit.org/show_bug.cgi?id=109036
<rdar://problem/13292139>
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
This was a two-fold problem:
1) post_inc/dec has two results - the new value of the variable, and the old value of the variable. DFG OSR exit
assumed that the "last result" used for the Baseline JIT's register allocation would be the new value. It was
wrong in this assumption.
2) The Baseline JIT knew to disable its last result optimization in cases where it might confuse the DFG. But it
was doing this only for code blocks that could be totally optimized, but not code blocks that could only be
optimized when inlined.
This patch introduces a more rigorous notion of when the Baseline JIT emits profiling, when it does extra work
to account for the possibility of OSR exit, and when it does extra work to account for the possibility of OSR
entry. These notions are called shouldEmitProfiling(), canBeOptimizedOrInlined(), and canBeOptimized(),
respectively.
This is performance-neutral and fixes the reported bug. It probably fixes other bugs as well, since previously
we for example weren't doing the more conservative implementation of op_mov in the Baseline JIT for code blocks
that could be inlined but not optimized. So, if such a code block OSR exited at just the right point, you'd get
symptoms similar to this bug.
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- dfg/DFGCommon.h:
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC::JIT::compilePatchGetArrayLength):
(JSC::JIT::canBeOptimizedOrInlined):
(JIT):
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
- jit/JITCall.cpp:
(JSC::JIT::emit_op_call_put_result):
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
- jit/JITInlines.h:
(JSC::JIT::emitArrayProfilingSite):
(JSC::JIT::map):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_mov):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::privateCompilePutByIdTransition):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::privateCompilePutByIdTransition):
LayoutTests:
Reviewed by Gavin Barraclough.
- fast/js/dfg-post-inc-then-exit-expected.txt: Added.
- fast/js/dfg-post-inc-then-exit.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-post-inc-then-exit.js: Added.
(foo):
- 7:00 PM Changeset in webkit [144136] by
-
- 10 edits16 adds2 deletes in trunk
[Chromium] Enable threaded HTML parser by default in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=110907
Reviewed by Eric Seidel.
Tools:
This patch changes --enable-threaded-html-parser into
--disable-threaded-html-parser and thereby enables the threaded HTML
parser by default for the Chromium port.
- DumpRenderTree/chromium/DumpRenderTree.cpp:
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
LayoutTests:
Update test results to show subtle differences in FrameLoaderClient callbacks.
- platform/chromium-mac/security/block-test-no-port-expected.txt: Removed.
- platform/chromium-win/fast/images/support-broken-image-delegate-expected.txt:
- platform/chromium-win/security/block-test-no-port-expected.txt: Removed.
- platform/chromium/fast/images/support-broken-image-delegate-expected.txt:
- platform/chromium/fast/loader/main-document-url-for-non-http-loads-expected.txt: Added.
- platform/chromium/http/tests/loading/307-after-303-after-post-expected.txt: Added.
- platform/chromium/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
- platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
- platform/chromium/http/tests/misc/window-dot-stop-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
- platform/chromium/inspector/debugger/pause-in-inline-script-expected.txt: Added.
- platform/chromium/inspector/timeline/timeline-script-tag-1-expected.txt: Added.
- platform/chromium/security/block-test-no-port-expected.txt:
- 6:51 PM Changeset in webkit [144135] by
-
- 2 edits in trunk/Source/WebCore
SQLTransactionBackend::doCleanup() should not nullify its current
statement and transaction error fields.
https://bugs.webkit.org/show_bug.cgi?id=110826.
Reviewed by Geoffrey Garen.
The reason for this is because the frontend SQLTransaction may have
tasks that are already registered via callOnMainThread(), and may
invoke transaction state functions that access these objects in the
SQLTransactionBackend. This proves to be problematic if the database
was interrupted resulting in doCleanup() being called concurrently
while those states are executing.
Instead, we leave their clean up to the SQLTransactionBackend destructor
which is guaranteed to only be called when the SQLTransaction is also
destructing i.e. these objects are no longer needed.
No new tests.
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::doCleanup):
- 6:40 PM Changeset in webkit [144134] by
-
- 2 edits in trunk/LayoutTests
Crashes in fast/notifications/notifications-request-permission.html after r144126
https://bugs.webkit.org/show_bug.cgi?id=108196
Unreviewed expectations update.
- platform/chromium/TestExpectations:
- 6:34 PM Changeset in webkit [144133] by
-
- 1 edit1 delete in trunk/LayoutTests
Deleting extraneous baseline after feDisplacementMap fix
https://bugs.webkit.org/show_bug.cgi?id=10592
Unreviewed expectations update. Slow build bot to blame.
- platform/chromium-win-xp/svg/filters/feDisplacementMap-expected.png: Removed.
- 6:04 PM Changeset in webkit [144132] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. AppleWin VS2010 build fix.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 5:45 PM Changeset in webkit [144131] by
-
- 7 edits in trunk/Source/JavaScriptCore
The DFG backend's and OSR's decision to unbox a variable should be based on whether it's used in a typed context
https://bugs.webkit.org/show_bug.cgi?id=110433
Reviewed by Oliver Hunt and Mark Hahnenberg.
This introduces the equivalent of a liveness analysis, except for type checking.
A variable is said to be "profitable for unboxing" (i.e. live at a type check)
if there exists a type check on a GetLocal of that variable, and the type check
is consistent with the variable's prediction. Variables that are not profitable
for unboxing aren't unboxed. Previously they would have been.
This is a slight speed-up on some things but mostly neutral.
- dfg/DFGArgumentPosition.h:
(JSC::DFG::ArgumentPosition::ArgumentPosition):
(JSC::DFG::ArgumentPosition::mergeShouldNeverUnbox):
(JSC::DFG::ArgumentPosition::mergeArgumentPredictionAwareness):
(JSC::DFG::ArgumentPosition::mergeArgumentUnboxingAwareness):
(ArgumentPosition):
(JSC::DFG::ArgumentPosition::isProfitableToUnbox):
(JSC::DFG::ArgumentPosition::shouldUseDoubleFormat):
- dfg/DFGCommon.h:
(JSC::DFG::checkAndSet):
(DFG):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(FixupPhase):
(JSC::DFG::FixupPhase::alwaysUnboxSimplePrimitives):
(JSC::DFG::FixupPhase::setUseKindAndUnboxIfProfitable):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsCaptured):
(JSC::DFG::VariableAccessData::mergeIsProfitableToUnbox):
(VariableAccessData):
(JSC::DFG::VariableAccessData::isProfitableToUnbox):
(JSC::DFG::VariableAccessData::shouldUnboxIfPossible):
(JSC::DFG::VariableAccessData::mergeStructureCheckHoistingFailed):
(JSC::DFG::VariableAccessData::mergeIsArgumentsAlias):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::mergeFlags):
- 5:20 PM Changeset in webkit [144130] by
-
- 7 edits in trunk/Source
Implement StorageAreaProxy::getItem and StorageAreaProxy::setItem
https://bugs.webkit.org/show_bug.cgi?id=110927
Reviewed by Sam Weinig.
Source/WebCore:
Export StorageMap::getItem and StorageMap::setItem.
- WebCore.exp.in:
Source/WebKit2:
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::setItem):
- UIProcess/Storage/StorageManager.h:
Add empty stub.
- UIProcess/Storage/StorageManager.messages.in:
Add SetItem message.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::getItem):
Fill the storage map and get the item from it.
(WebKit::StorageAreaProxy::setItem):
Update the storage map and send a SetItem message to the UI process.
- 5:09 PM Changeset in webkit [144129] by
-
- 6 edits in trunk/Source
[chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame
https://bugs.webkit.org/show_bug.cgi?id=110928
Reviewed by Adrienne Walker.
Source/Platform:
- chromium/public/WebLayerTreeViewClient.h:
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
- src/WebViewImpl.h:
- tests/WebLayerTreeViewTestCommon.h:
- 5:05 PM Changeset in webkit [144128] by
-
- 4 edits5 adds in trunk
Parsing of HTML tags in MathML Text Insertion Points leads to bogus parser behavior
https://bugs.webkit.org/show_bug.cgi?id=110808
Reviewed by Adam Barth.
Source/WebCore:
When looking for various table tags in the HTMLElementStack, compare
QualifiedNames rather than just local names, where necessary.
Note that not all uses have been "fixed"; I've only changed for which
I could write a test with differing behavior. A followup patch to
rationalize the use of QualifiedName vs local names would be ideal.
Tests: html5lib/generated/run-math-data.html
html5lib/generated/run-math-write.html
- html/parser/HTMLElementStack.cpp:
(WebCore::inScopeCommon): Added a version of inScopeCommon that
handles QualifiedNames instead of just localNames.
(WebCore::HTMLElementStack::inTableScope): When given a QualifiedName,
call the new version of inScopeCommon().
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow):
LayoutTests:
- html5lib/generated/run-math-data-expected.txt: Added.
- html5lib/generated/run-math-data.html: Added.
- html5lib/generated/run-math-write-expected.txt: Added.
- html5lib/generated/run-math-write.html: Added.
- html5lib/resources/math.dat: Added.
- 5:01 PM Changeset in webkit [144127] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix windows build.
- 4:52 PM Changeset in webkit [144126] by
-
- 14 edits2 adds2 deletes in trunk
Notification.requestPermission callback should be optional
https://bugs.webkit.org/show_bug.cgi?id=108196
Reviewed by Adam Barth.
Source/WebCore:
Spec says it should be optional.
http://notifications.spec.whatwg.org/#notification
Test: fast/notifications/notifications-request-permission-optional.html
- GNUmakefile.list.am:
- Modules/notifications/Notification.h:
(Notification):
- Modules/notifications/Notification.idl:
- Target.pri:
- UseJSC.cmake:
- UseV8.cmake:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSNotificationCustom.cpp: Removed.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/v8/custom/V8NotificationCustom.cpp: Removed.
LayoutTests:
Specs says it should be optional.
http://notifications.spec.whatwg.org/#notification
- fast/notifications/notifications-request-permission-optional-expected.txt: Added.
- fast/notifications/notifications-request-permission-optional.html: Added.
- 4:45 PM Changeset in webkit [144125] by
-
- 3 edits1 add in trunk/Source/WebCore
IndexedDB: Add temporary diagnostic code to IDBRequest.result getter
https://bugs.webkit.org/show_bug.cgi?id=110916
Reviewed by Kentaro Hara.
Implement a custom getter for IDBRequest.result that does one additional hidden
property set, to try and isolate the flaky crash seen in wkbug.com/105363 which is
difficult to repro locally. If the crash moves to the new line it will point
the investigation in a new direction. Also add an assertion that probes string
wrappers (the expected type).
- Modules/indexeddb/IDBRequest.idl: Mark attribute as [Custom]
- WebCore.gypi: New file.
- bindings/v8/custom/V8IDBRequestCustom.cpp: Added.
(WebCore::V8IDBRequest::resultAttrGetterCustom): Implementation - copy/paste from
generated code, plus extra setNamedHiddenReference call and string ASSERT.
- 4:44 PM Changeset in webkit [144124] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] GIFImageDecoderTest.parseAndDecodeByteByByte failing on Android
https://bugs.webkit.org/show_bug.cgi?id=110922
Unreviewed. Build fix.
- tests/GIFImageDecoderTest.cpp:
(WebKit):
- 4:42 PM Changeset in webkit [144123] by
-
- 2 edits in trunk/LayoutTests
[Chromium] TestExpectations addition
Unreviewed addition of fast/js/regress/inlined-put-by-id-transition.html which crashes occasionally.
- platform/chromium/TestExpectations:
- 4:38 PM Changeset in webkit [144122] by
-
- 3 edits in trunk/Source/JavaScriptCore
Web Inspector: REGRESSION: [JSC] SourceProvider reuses IDs
https://bugs.webkit.org/show_bug.cgi?id=99674
Reviewed by Gavin Barraclough.
Simple incrementing counter for SourceProvider IDs. Uses a
lock to incrementing the counter so we don't increment reuse
counter values or reassign the ID for a given SourceProvider.
- parser/SourceProvider.cpp:
(JSC::SourceProvider::SourceProvider):
(JSC):
(JSC::SourceProvider::getID):
- parser/SourceProvider.h:
(JSC::SourceProvider::asID):
(SourceProvider):
- 4:34 PM Changeset in webkit [144121] by
-
- 50 edits3 deletes in trunk/LayoutTests
New baselines after feDisplacementMap fix
https://bugs.webkit.org/show_bug.cgi?id=10592
Unreviewed expectations update.
- platform/chromium-linux-x86/svg/filters/feDisplacementMap-expected.png: Removed.
- platform/chromium-linux/svg/filters/feDisplacementMap-expected.png: Removed.
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/filters/feDisplacementMap-expected.png: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
- platform/chromium-mac/svg/filters/feDisplacementMap-expected.png:
- platform/chromium-mac/svg/filters/filterRes-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
- platform/chromium-win/svg/filters/feDisplacementMap-expected.png:
- platform/chromium-win/svg/filters/filterRes-expected.png:
- platform/chromium/TestExpectations:
- 4:31 PM Changeset in webkit [144120] by
-
- 6 edits in trunk/Source
[chromium] Remove unused WebLayerTreeViewClient calls
https://bugs.webkit.org/show_bug.cgi?id=110923
Reviewed by Adrienne Walker.
These notifications existed for instrumentation, but now the instrumentation routes
through WebDevToolsAgent.
Source/Platform:
- chromium/public/WebLayerTreeViewClient.h:
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
- src/WebViewImpl.h:
- tests/WebLayerTreeViewTestCommon.h:
- 4:28 PM Changeset in webkit [144119] by
-
- 2 edits in trunk/Source/WebCore
Add a couple of symbols needed by WebKit2.
- WebCore.exp.in:
- 4:19 PM Changeset in webkit [144118] by
-
- 4 edits4 adds in trunk
[CSS Shaders] Implement color and luminosity non-separable blend modes
https://bugs.webkit.org/show_bug.cgi?id=106226
Source/WebCore:
Added the following GLSL helper functions to the CustomFilterValidatedProgram:
- css_Lum(C): returns the luminosity for the color C
- css_ClipColor(C): clips color C
- css_SetLum(C, l): sets the luminosity l on the color C
The above functions are being used for the "color" and "luminosity" non-separable
blend modes, the relevant spec for such modes is at URL:
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blendingnonseparable
Reviewed by Dean Jackson.
Tests: css3/filters/custom/custom-filter-nonseparable-blend-mode-color.html
css3/filters/custom/custom-filter-nonseparable-blend-mode-luminosity.html
- platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::blendFunctionString):
LayoutTests:
Added relevant tests for the "color" and "luminosity" non-separable blend modes.
These tests are currently skipped on Mac due to a slight color difference; please
see relevant bug: http://webkit.org/b/107487.
Reviewed by Dean Jackson.
- css3/filters/custom/custom-filter-nonseparable-blend-mode-color-expected.html: Added.
- css3/filters/custom/custom-filter-nonseparable-blend-mode-color.html: Added.
- css3/filters/custom/custom-filter-nonseparable-blend-mode-luminosity-expected.html: Added.
- css3/filters/custom/custom-filter-nonseparable-blend-mode-luminosity.html: Added.
- 4:13 PM Changeset in webkit [144117] by
-
- 5 edits in trunk/Source
StorageAreaProxy should hold on to a StorageMap and not a HashMap
https://bugs.webkit.org/show_bug.cgi?id=110919
Reviewed by Jessie Berlin.
Source/WebCore:
StorageMap should be a private header.
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit2:
Create a storage map instead of a hash map.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::length):
(WebKit::StorageAreaProxy::loadValuesIfNeeded):
- WebProcess/Storage/StorageAreaProxy.h:
(WebCore):
(StorageAreaProxy):
- 3:43 PM Changeset in webkit [144116] by
-
- 4 edits in trunk
[chromium] Re-enable the fixed version of freetype on linux
https://bugs.webkit.org/show_bug.cgi?id=110542
Reviewed by Tony Chang.
Tools:
Re-land the change in r143794 to switch to building with a fixed
version of FreeType for just DumpRenderTree. This allows us to share
one version of pixel baselines for both Lucid and Precise, and run the
layout tests in a stock Precise install (instead of a Lucid chroot).
Going forward, this approach isolates us from os-level changes to the
version of FreeType. Note that Chromium itself still uses the system
FreeType and is unaffected by this change.
This setting can still be turned off (at compile/gyp-time) by
manually setting use_custom_freetype=0.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
LayoutTests:
Re-add entries for two tests that pass on Lucid but fail on Precise
even with the Freetype change. This isn't worth adding in
Lucid and Precise keywords for just these two tests.
- platform/chromium/TestExpectations:
- 3:18 PM Changeset in webkit [144115] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll Chromium DEPS from r183905 -> r184646.
Unreviewed.
- DEPS:
- 3:06 PM Changeset in webkit [144114] by
-
- 2 edits in trunk/Source/WebKit2
Fix a copy/paste error in WebLoaderClient::didBlockInsecurePluginVersion
https://bugs.webkit.org/show_bug.cgi?id=110914
<rdar://problem/13297581>
Reviewed by Beth Dakin.
Pass kWKErrorCodeInsecurePlugInVersion to the pluginDidFail callback.
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
- 2:57 PM Changeset in webkit [144113] by
-
- 14 edits1 delete in trunk/Source/JavaScriptCore
Unreviewed, rolling out r144074.
http://trac.webkit.org/changeset/144074
https://bugs.webkit.org/show_bug.cgi?id=110897
Causing 20+ crashes on Mac (Requested by bradee-oh on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-26
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
- runtime/PropertyMapHashTable.h:
(PropertyTable):
(JSC::PropertyTable::PropertyTable):
(JSC):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::copy):
- runtime/PropertyTable.cpp: Removed.
- runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
(JSC::Structure::visitChildren):
- runtime/Structure.h:
(JSC):
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::checkOffsetConsistency):
(Structure):
- runtime/StructureInlines.h:
- 2:49 PM Changeset in webkit [144112] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Remove unused WebWidget::instrument calls
https://bugs.webkit.org/show_bug.cgi?id=110906
Patch by James Robinson <jamesr@chromium.org> on 2013-02-26
Reviewed by Jochen Eisinger.
These calls are now routed through WebDevToolsAgent.
- public/WebWidget.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::willBeginFrame):
- src/WebViewImpl.h:
- 2:40 PM Changeset in webkit [144111] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. AppleWin VS2010 build fix.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props:
- 2:33 PM Changeset in webkit [144110] by
-
- 24 edits4 adds in trunk
feDisplacementMap filter gets color space wrong
https://bugs.webkit.org/show_bug.cgi?id=105929
Reviewed by Dirk Schulze.
Source/WebCore:
Tests: svg/filters/feDisplacementMap-color-interpolation-filters-expected.svg
svg/filters/feDisplacementMap-color-interpolation-filters.svg
svg/filters/feDisplacementMap-filterUnits-expected.svg
svg/filters/feDisplacementMap-filterUnits.svg
According to the spec, the SVG feDisplacementMap filter should not
change the color space on its first input, and other vendors seem to
agree that this also means that the output should be in the first
input's color space. That makes sense: we are displacing the input,
not otherwise manipulating colors.
This change improves color space handling for filters by more
explicitly tracking which color space is used for the filter's
operation and which is used for the filter's result. It provides a
means for filter effects to override the color-interpolation-filters
property as defined by the spec. feFlood and feDisplacementMap use
this new feature to enforce the spec requirements.
- platform/graphics/filters/FEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::setResultColorSpace): Override the default color space with the
same color space as the first input filter.
(WebCore):
(WebCore::FEDisplacementMap::transformResultColorSpace): Only transform the color space on
the second filter input.
(WebCore::FEDisplacementMap::platformApplySoftware): Make the application code more efficient,
and give slightly better numerical accuracy.
- platform/graphics/filters/FEDisplacementMap.h:
(FEDisplacementMap): Declare setResultColorSpace.
- platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::platformApplySoftware): Remove the call that forces
the result color space. We do it now in the setResultColorSpace.
- platform/graphics/filters/FEFlood.h:
(FEFlood): Add setResultColorSPace override that enforces sRGB color space. But not if using
CG, which apparently does this this already internally.
- platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::FilterEffect): Rename m_colorSpace to m_operatingColorSpace.
(WebCore::FilterEffect::apply): Allow filter effects to
override the color space conversion of their inputs.
(WebCore::FilterEffect::createImageBufferResult): Always create the
image buffer with the result color space.
- platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::operatingColorSpace): New accessor.
(WebCore::FilterEffect::setOperatingColorSpace): New accessor.
(WebCore::FilterEffect::resultColorSpace): New accessor.
(WebCore::FilterEffect::setResultColorSpace): New accessor.
(FilterEffect):
(WebCore::FilterEffect::transformResultColorSpace): A new virtual
method that allows filter effects individual control over the color
space conversion of their inputs.
- platform/graphics/filters/SourceGraphic.h:
(WebCore::SourceGraphic::SourceGraphic): Variable rename.
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build): Use accessors to set color
space to enable per-effect overrides.
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::buildPrimitives): Use accessors to set color.
LayoutTests:
Add two new feDisplacementMap tests to get better coverage. And update some results.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
- platform/chromium-linux/svg/filters/feDisplacementMap-expected.png:
- platform/chromium-linux/svg/filters/filterRes-expected.png:
- svg/filters/feDisplacementMap-color-interpolation-filters-expected.svg: Added.
- svg/filters/feDisplacementMap-color-interpolation-filters.svg: Added.
- svg/filters/feDisplacementMap-filterUnits-expected.svg: Added.
- svg/filters/feDisplacementMap-filterUnits.svg: Added.
- 2:29 PM Changeset in webkit [144109] by
-
- 4 edits in trunk/Source/WebKit
Unreviewed AppleWin build fix following r143996.
- WebKit.vcproj/WebKitExportGeneratorCommon.vsprops:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorCommon.props:
- 2:21 PM Changeset in webkit [144108] by
-
- 2 edits2 copies in branches/chromium/1364
Merge 143454
BUG=176738
Review URL: https://codereview.chromium.org/12334104
- 2:15 PM Changeset in webkit [144107] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/rendering/RenderArena.cpp
Merge 143811
BUG=webkit.org/b/110394
TBR=jschuh@chromium.org
Review URL: https://codereview.chromium.org/12321148
- 2:13 PM Changeset in webkit [144106] by
-
- 1 edit in branches/chromium/1364/Source/WebCore/rendering/RenderArena.cpp
Merge 143811
BUG=webkit.org/b/110394
TBR=jschuh@chromium.org
Review URL: https://codereview.chromium.org/12334103
- 2:00 PM Changeset in webkit [144105] by
-
- 4 edits3 adds in trunk
X-Frame-Options should accept ALLOWALL as a valid value.
https://bugs.webkit.org/show_bug.cgi?id=110857
Reviewed by Adam Barth.
Source/WebCore:
DoubleClick, among others, serves ALLOWALL as a 'X-Frame-Options' value
with the intent of (shock!) allowing a resource to be framed by all
origins. Given its prevelance, and the fact that IE supports the header,
we shouldn't call it out as invalid.
This patch tweaks the warning logic to only throw the warning if the
header's value isn't 'ALLOWALL', 'DENY', or 'SAMEORIGIN'.
Test: http/tests/security/XFrameOptions/x-frame-options-allowall.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
LayoutTests:
- http/tests/security/XFrameOptions/resources/x-frame-options-allowall.cgi: Added.
- http/tests/security/XFrameOptions/x-frame-options-allowall-expected.txt: Added.
- http/tests/security/XFrameOptions/x-frame-options-allowall.html: Added.
Exciting new test!
- http/tests/security/XFrameOptions/x-frame-options-cached-expected.txt:
Exciting new baseline for an old test that was already using ALLOWALL!
- 1:58 PM Changeset in webkit [144104] by
-
- 5 edits2 adds in trunk
CSS Flexbox: dynamically applied align-items doesn't affect item alignment
https://bugs.webkit.org/show_bug.cgi?id=110341
Reviewed by Ojan Vafai.
Source/WebCore:
If flex items don't change width, we don't lay them out again. This causes problems
when an item goes from stretch to non-stretch since we need to relayout to get the
smaller height. Fix this by marking flex items that were stretch as needing layout.
Test: css3/flexbox/relayout-align-items.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::resolveAlignment): Pull out common code for computing flex item style.
(WebCore::RenderFlexibleBox::styleDidChange): Mark children as needing layout.
(WebCore::RenderFlexibleBox::alignmentForChild): Use resolveAlignment.
- rendering/RenderFlexibleBox.h:
LayoutTests:
Also fix a typo causing align-self-* classes from not applying. There
was only one test that tried to use the align-self classes and it was
testing all values behaved the same.
- css3/flexbox/relayout-align-items-expected.txt: Added.
- css3/flexbox/relayout-align-items.html: Added.
- css3/flexbox/resources/flexbox.css:
(.align-self-auto):
(.align-self-flex-start):
(.align-self-flex-end):
(.align-self-center):
(.align-self-baseline):
(.align-self-stretch):
- 1:54 PM Changeset in webkit [144103] by
-
- 6 edits in trunk/Source/WebCore
StorageMap can just import an entire map of items at once
https://bugs.webkit.org/show_bug.cgi?id=110904
Reviewed by Beth Dakin.
Instead of iterating over the map inside StorageAreaSync, just pass it directly
(through StorageAreaImpl) to StorageMap and iterate over it there.
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::importItems):
- storage/StorageAreaImpl.h:
(StorageAreaImpl):
- storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::performImport):
- storage/StorageMap.cpp:
(WebCore::StorageMap::importItems):
- storage/StorageMap.h:
(StorageMap):
- 1:40 PM Changeset in webkit [144102] by
-
- 8 edits in tags/Safari-537.31.10/Source
Merged r144091. <rdar://problem/13254985>
- 1:40 PM Changeset in webkit [144101] by
-
- 6 edits in trunk/Source/WebCore
[JSC] static methods with Callback should not have this pointer
https://bugs.webkit.org/show_bug.cgi?id=110846
Reviewed by Kentaro Hara.
Fixing the JSC Codegenerator not to use 'this' pointer in static methods.
No new tests.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjConstructorFunctionStaticMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjConstructorFunctionStaticMethodWithCallbackArg):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::staticMethodWithCallbackAndOptionalArgMethod):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::staticMethodWithCallbackAndOptionalArgMethodCallback):
(WebCore::TestObjV8Internal::staticMethodWithCallbackArgMethod):
(WebCore::TestObjV8Internal::staticMethodWithCallbackArgMethodCallback):
(WebCore::ConfigureV8TestObjTemplate):
- 1:38 PM Changeset in webkit [144100] by
-
- 7 edits2 adds in trunk/Source
GIFImageReader to read from source data directly
https://bugs.webkit.org/show_bug.cgi?id=109662
Reviewed by Stephen White.
Source/WebCore:
This is the first patch to improve GIF image decoding.
GIFImageReader has an internal 256 bytes buffer to saving incoming
bytes. This mechanism is out-dated because WebKit holds the entire
file in memory and it is not necessary to hold data in an intermediate
buffer.
This is also a blocker for later work to parse and decode GIF
incrementally.
This change removed the imtermediate 'hold' buffer and uses an index
for data position to keep track of parsing of the GIF file. Buffer for
global colormap and local colormap are also removed because they can be
referenced from the data stream.
This change is tested by:
Layout tests
All tests passed under fast/images.
Unit tests
Added GIFImageDecoderTest for Chromium.
Local testing
I tested this implementation against a set of 50k GIF images and
there's no crashes and produces bit-exact results as previous code.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::decode):
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::doLZW):
(GIFImageReader::decode):
(GIFImageReader::decodeInternal):
(GIFImageReader::setRemainingBytes):
- platform/image-decoders/gif/GIFImageReader.h:
(GIFFrameContext):
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext):
(GIFImageReader::GIFImageReader):
(GIFImageReader::~GIFImageReader):
(GIFImageReader::setData):
(GIFImageReader):
(GIFImageReader::globalColormap):
(GIFImageReader::localColormap):
(GIFImageReader::localColormapSize):
(GIFImageReader::data):
(GIFImageReader::colormap):
Source/WebKit/chromium:
Added the following unit tests to test new logic in GIFImageDecoder:
GIFImageDecoderTest.decodeTwoFrames
Test that it can decode a multi-frame GIF image correctly.
GIFImageDecoderTest.parseAndDecode
First perform a parse operation and then a decode operation. Expect
that parse and decode operates correctly.
GIFImageDecoderTest.parseByteByByte
Test that multi-frame GIF image can be parsed correctly byte by byte.
GIFImageDecoderTest.parseAndDecodeByteByByte
Run a loop to feed decoder byte by byte, perform a parse and then
decode operation and make sure frames are decoded correctly.
GIFImageDecoderTest.brokenSecondFrame
Decode a GIF image with second frame broken. Expect that the first
frame can be decoded correctly.
- WebKit.gypi:
- tests/GIFImageDecoderTest.cpp: Added.
(WebKit):
(WebKit::readFile):
(WebKit::TEST):
- tests/data/broken.gif: Added.
- 1:35 PM Changeset in webkit [144099] by
-
- 10 edits in tags/Safari-537.31.10/Source
Merged r143984. <rdar://problem/13254985>
- 1:12 PM Changeset in webkit [144098] by
-
- 2 edits in tags/Safari-537.31.10/Source/JavaScriptCore
Merged r143509. <rdar://problem/13254985>
- 1:09 PM Changeset in webkit [144097] by
-
- 6 edits2 copies in tags/Safari-537.31.10/Source/WebCore
Merged r143259. <rdar://problem/13254985>
- 1:08 PM Changeset in webkit [144096] by
-
- 17 edits5 adds in trunk
Empty <button>s should collapse; empty <input type="button"> should not collapse
https://bugs.webkit.org/show_bug.cgi?id=110654
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-26
Reviewed by Ojan Vafai.
Source/WebCore:
This patch also fixes other height computation issues with flex boxes
related to scroll bars and hasLineIfEmpty()=true. See below for
details.
Tests: css3/flexbox/button.html
css3/flexbox/position-absolute-child-with-contenteditable.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock): Add a FIXME to make
border/padding/scrollbar inclusion more consistent with other
renderers.
- rendering/RenderButton.h:
(WebCore::RenderButton::hasLineIfEmpty): We only want a line for
<input type=button|submit|reset>, for consistency with Firefox.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Start out layoutBlock by
setting the logical height to border + padding + scrollbar height to
ensure that we have space for the scrollbar even without children. The
layoutFlexItems change below is not enough because we also need this
when hasLineIfEmpty() is false.
(WebCore::RenderFlexibleBox::layoutFlexItems): Ensure we have a line
when hasLineIfEmpty() is true by calling setLogicalHeight(border+
padding+scrollbar+lineHeight()) if we don't have a flex line.
LayoutTests:
- css3/flexbox/button-expected.png: Added.
- css3/flexbox/button-expected.txt: Added.
- css3/flexbox/button.html: Added.
Test empty buttons, <input type=button>, and buttons with
overflow:scroll;
- css3/flexbox/position-absolute-child-with-contenteditable-expected.html: Added.
- css3/flexbox/position-absolute-child-with-contenteditable.html: Added.
Test flex boxes with hasLineIfEmpty()=true and absolute positioned
children. Uses contenteditable=true to get that effect.
- platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.png:
- platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.txt:
- platform/chromium-linux/svg/custom/foreign-object-skew-expected.png:
- platform/chromium-linux/svg/custom/foreign-object-skew-expected.txt:
- platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.txt:
Regenerate test cases that use <input type=button>.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
Mark tests for rebaselining.
- 1:07 PM Changeset in webkit [144095] by
-
- 7 edits in tags/Safari-537.31.10/Source/WebCore
Merged r143072. <rdar://problem/13254985>
- 1:04 PM Changeset in webkit [144094] by
-
- 10 edits in tags/Safari-537.31.10
Merged r142918. <rdar://problem/13254985>
- 1:01 PM Changeset in webkit [144093] by
-
- 5 edits in tags/Safari-537.31.10/Source/WebCore
Merged r142819. <rdar://problem/13254985>
- 12:52 PM Changeset in webkit [144092] by
-
- 8 edits in trunk/Source/WebCore
Unreviewed, rolling out r143941.
http://trac.webkit.org/changeset/143941
https://bugs.webkit.org/show_bug.cgi?id=110901
This is a step in the wrong direction as it ties us to what
grid-{row|column} expect (see
https://bugs.webkit.org/show_bug.cgi?id=110777 for the right
direction) (Requested by jchaffraix on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-26
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridPosition):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/StyleResolver.cpp:
(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::autoPlacementMajorAxisPositionForChild):
(WebCore::RenderGrid::autoPlacementMinorAxisPositionForChild):
- rendering/RenderGrid.h:
- rendering/style/GridPosition.h:
- rendering/style/RenderStyle.h:
- rendering/style/StyleGridItemData.h:
(StyleGridItemData):
- 12:51 PM Changeset in webkit [144091] by
-
- 8 edits in trunk/Source
Unreviewed build fix; use correct macro for platform name in FeatureDefines.xcconfig.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 12:48 PM Changeset in webkit [144090] by
-
- 10 edits in tags/Safari-537.31.10/Source
Merged r144067. <rdar://problem/13250271>
- 12:44 PM Changeset in webkit [144089] by
-
- 3 edits in branches/chromium/1364/Source
Merge 143347
BUG=174627
Review URL: https://codereview.chromium.org/12310146
- 12:36 PM Changeset in webkit [144088] by
-
- 6 edits in tags/Safari-537.31.10/Source
Merged r143650. <rdar://problem/13250271>
- 12:33 PM Changeset in webkit [144087] by
-
- 4 edits in tags/Safari-537.31.10/Source
Versioning.
- 12:28 PM Changeset in webkit [144086] by
-
- 1 copy in tags/Safari-537.31.10
New Tag.
- 12:13 PM Changeset in webkit [144085] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Animated images not animating on accelerated compositing layers
https://bugs.webkit.org/show_bug.cgi?id=110886
Patch by Andrew Lo <anlo@rim.com> on 2013-02-26
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.
Internal PR 299598.
Animated images on AC layers call GraphicsLayer::setContentsToImage
on each frame with the same Image.
We need to set needs display in that case so that the frames are
displayed.
No new tests are needed since there is no new functionality.
- platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::setContents):
- 11:48 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:43 AM Changeset in webkit [144084] by
-
- 5 edits in trunk/Source
Unreviewed, rolling out r144065.
http://trac.webkit.org/changeset/144065
https://bugs.webkit.org/show_bug.cgi?id=110896
Causing failures and crashes on Chromium Win7 and Win XP
(Requested by schenney on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-26
Source/WebCore:
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::normalizeCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
- platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:
(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):
Source/WebKit/chromium:
- features.gypi:
- 11:37 AM Changeset in webkit [144083] by
-
- 2 edits in trunk/Source/JavaScriptCore
Potential crash in YARR JIT generated code when building 64 bit
https://bugs.webkit.org/show_bug.cgi?id=110893
Reviewed by Gavin Barraclough.
The ABI doesn't define the behavior for the upper bits of a value that takes less than 64 bits.
Therefore, we zero extend both the count and length registers to assure that these unsigned values
don't have garbage upper bits.
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generateEnter):
- 11:25 AM Changeset in webkit [144082] by
-
- 2 edits in trunk/Source/WTF
Unreviewed. Build fix for VS2010 solution, take 2.
- WTF.vcxproj/work-around-vs-dependency-tracking-bugs.py:
- 11:21 AM Changeset in webkit [144081] by
-
- 2 edits in trunk/Tools
[chromium] content shell drt: Enable WebKit::setLayoutTestMode()
https://bugs.webkit.org/show_bug.cgi?id=110890
Reviewed by Jochen Eisinger.
Several functions in webkit check that bit to change rendering
in layout test mode. For example, platform/graphics/skia/FrontSkia.cpp
disables font smoothing in this mode. TestShell and DRT both set
this flag, so content shell drt should set it too.
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
- 11:12 AM Changeset in webkit [144080] by
-
- 2 edits in trunk/Source/WTF
Unreviewed. Unreviewed build fix for VS2010 solution.
- WTF.vcxproj/work-around-vs-dependency-tracking-bugs.py:
- 11:03 AM Changeset in webkit [144079] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening.
Adding failure expectations for three html5lib tests that are failing after r144032
on EFL and GTK, most likely due to the ports sharing Libsoup as the network backend.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 11:00 AM Changeset in webkit [144078] by
-
- 2 edits in trunk/Source/WebCore
[TexMap] Ignore layer repaint request when drawsContent is false
https://bugs.webkit.org/show_bug.cgi?id=110888
Reviewed by Noam Rosenthal.
As long as drawsContent is false we should ignore requests for repaints.
A full repaint will be requested when drawsContent is changed to true.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::setDrawsContent):
- 10:55 AM Changeset in webkit [144077] by
-
- 4 edits1 add in trunk/Source/WTF
Fix the atomicIncrement implementation for MIPS GCC
https://bugs.webkit.org/show_bug.cgi?id=106739
Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-02-26
Reviewed by Oliver Hunt.
Implementation of missing sync_[add|sub]_and_fetch_8 functions.
Some architectures, like MIPS32, don't have GCC implementation for
builtin sync_* functions with 64 bits variable size. GCC answer
for the problem: If a target doesn't support atomic operations on
certain variable sizes, you are out of luck with atomicity in that
case (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56296). GCC >= 4.8
will support atomic_* builtin functions for this purpose for all
the GCC targets, but for current compilers we have to include our
own implementation.
- GNUmakefile.list.am:
- WTF.pro:
- wtf/Atomics.cpp: Added.
(WTF):
(WTF::getSwapLock):
(WTF::atomicStep):
- wtf/CMakeLists.txt:
- 10:50 AM Changeset in webkit [144076] by
-
- 2 edits in trunk/Tools
new-commit-bot: Fix the unit test newcommitbot-unittest.py due to r144040
https://bugs.webkit.org/show_bug.cgi?id=110884
Reviewed by Csaba Osztrogonác.
Adding the missing spaces before ':' in the unit test.
- Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
- 10:44 AM Changeset in webkit [144075] by
-
- 3 edits2 adds in trunk
IndexedDB: IDBObjectStore.index() doesn't report errors after deleteIndex()
https://bugs.webkit.org/show_bug.cgi?id=110792
Reviewed by Tony Chang.
Source/WebCore:
The object store's metadata wasn't updated if the index hadn't been accessed
by script and hence placed in the name->object map. Make sure the metadata
is always updated.
Test: storage/indexeddb/deleteIndex-bug110792.html
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::deleteIndex): Always update the object store's metadata.
LayoutTests:
Added regression test for bug.
- storage/indexeddb/deleteIndex-bug110792-expected.txt: Added.
- storage/indexeddb/deleteIndex-bug110792.html: Added.
- 10:43 AM Changeset in webkit [144074] by
-
- 14 edits1 add in trunk/Source/JavaScriptCore
Unused Structure property tables waste 14MB on Membuster.
<http://webkit.org/b/110854>
<rdar://problem/13292104>
Reviewed by Filip Pizlo.
Turn PropertyTable into a GC object and have Structure drop unpinned tables when marking.
14 MB progression on Membuster3.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
Added PropertyTable.cpp.
- runtime/PropertyTable.cpp: Added.
(JSC::PropertyTable::create):
(JSC::PropertyTable::clone):
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::destroy):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::visitChildren):
Moved marking of property table values here from Structure::visitChildren().
- runtime/StructureInlines.h:
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::checkOffsetConsistency):
Moved these to StructureInlines.h to break header dependency cycle between Structure/PropertyTable.
- runtime/Structure.cpp:
(JSC::Structure::visitChildren):
Null out m_propertyTable if the table is unpinned. This'll cause the table to get GC'd.
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
- runtime/Structure.h:
(Structure):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
- runtime/PropertyMapHashTable.h:
(PropertyTable):
(JSC::PropertyTable::createStructure):
(JSC::PropertyTable::copy):
- 10:38 AM Changeset in webkit [144073] by
-
- 11 edits in trunk
Unreviewed, rolling out r144019.
http://trac.webkit.org/changeset/144019
https://bugs.webkit.org/show_bug.cgi?id=110892
due to 8% perf regression on chromium-win7 intl1 page cycler,
see https://bugs.webkit.org/show_bug.cgi?id=110872 (Requested
by gasubic on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-26
Source/WebCore:
- platform/text/LineBreakIteratorPoolICU.h:
(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
(LineBreakIteratorPool):
- platform/text/TextBreakIterator.h:
(WebCore):
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
- rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths):
- rendering/RenderText.h:
(WebCore):
- rendering/break_lines.cpp:
(WebCore):
(WebCore::isBreakableSpace):
(WebCore::needsLineBreakIterator):
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
- rendering/break_lines.h:
(WebCore):
(WebCore::isBreakable):
LayoutTests:
- platform/mac/TestExpectations:
- 10:35 AM Changeset in webkit [144072] by
-
- 6 edits in trunk/Source
Create the SharedGraphicsContext3D through its own method.
https://bugs.webkit.org/show_bug.cgi?id=109345
Reviewed by James Robinson.
Source/Platform:
Add Platform API methods to get shared contexts from the embedder.
- chromium/public/Platform.h:
(Platform):
(WebKit::Platform::sharedOffscreenGraphicsContext3D):
(WebKit::Platform::sharedOffscreenGrContext):
Source/WebCore:
Allow creating a GraphicsContext3DPrivate from an externally owned
WebGraphicsContext3D and GrContext. Then create the shared graphics
context from these provided by the embedder.
This falls back to the old path if the new methods return NULL to
let us land this immediately and then transition the chromium side
over to this path.
- platform/chromium/support/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromExternalWebContextAndGrContext):
(WebCore::GraphicsContext3DPrivate::grContext):
- platform/chromium/support/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::webContext):
- platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3DImpl::getOrCreateContext):
- 10:32 AM Changeset in webkit [144071] by
-
- 2 edits in trunk/Source/WTF
Appease the QT bots.
- 10:29 AM Changeset in webkit [144070] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][GTK] REGRESSION (r143463): unit test failure in WebKit2APITests/TestContextMenu
https://bugs.webkit.org/show_bug.cgi?id=110869
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-02-26
Reviewed by Martin Robinson.
Test was failing because of new media controls needs more space to be
painted than just 10x10 pixels.
- UIProcess/API/gtk/tests/TestContextMenu.cpp:
(testContextMenuDefaultMenu): Modified test in order to give more space
to the media controls.
- 10:04 AM Changeset in webkit [144069] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use APIEntryShim when making JS call
https://bugs.webkit.org/show_bug.cgi?id=110787
Reviewed by Rob Buis.
PR# 301451.
Use APIEntryShim to fix an assert and ensure it is thread-safe.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
- 9:50 AM Changeset in webkit [144068] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r143986): fast/files/revoke-blob-url.html asserts
https://bugs.webkit.org/show_bug.cgi?id=110885
Reviewed by Alexey Proskuryakov.
The ResourceRequest string constructor assumes that the string is a valid URL. Use KURL constructor instead.
- html/DOMURL.cpp:
(WebCore::DOMURL::revokeObjectURL):
- 9:16 AM Changeset in webkit [144067] by
-
- 10 edits in trunk/Source
Draw intermediate snapshots if possible
https://bugs.webkit.org/show_bug.cgi?id=110811
Reviewed by Simon Fraser.
After http://webkit.org/b/110495 we delayed snapshotting until we've
received a nice image, but this made the page look like it is broken.
We should draw any intermediate snapshots that we find, which might
include content such as progress bars/spinners.
Source/WebCore:
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInElement::isPlugInImageElement): Expose virtual method
to indicate if this is a HTMLPlugInImageElement or not.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateSnapshot): If we have
a RenderEmbeddedObject renderer, then tell it to repaint.
- html/HTMLPlugInImageElement.h:
(WebCore::HTMLPlugInImageElement::snapshotImage): Expose an
accessor for snapshot images.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintSnapshotImage): New helper
method to render an image directly. This code is similar to
that in RenderSnapshottedPlugIn.
(WebCore::RenderEmbeddedObject::paintContents): The virtual implementation
of this method for use when we have a snapshot to paint. If we are a plugin that is
in the process of being snapshotted, ask our HTMLPlugInImageElement for a
snapshot and paint that instead. In the case where we are not snapshotting,
or we do not yet have a snapshot, this will call back into the RenderWidget code.
- rendering/RenderEmbeddedObject.h:
(RenderEmbeddedObject): New methods paintSnapshotImage and paintContents
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paintContents): New method called in the middle
of paint() that can be overridden by RenderEmbeddedObject. The code here was
simply moved out of the previous paint().
(WebCore::RenderWidget::paint): Call paintContents at the appropriate time.
- rendering/RenderWidget.h:
(RenderWidget): New virtual method paintContents.
Source/WebKit2:
- WebProcess/Plugins/PluginView.cpp:
(WebKit): Reinstate 60 attempts at snapshots before giving up.
(WebKit::PluginView::isAcceleratedCompositingEnabled): We do not
want accelerated compositing enabled when we are trying to capture
snapshots.
- 9:15 AM Changeset in webkit [144066] by
-
- 2 edits in trunk/Source/WebKit2
Remove nonexistent StringPairVector.h from Target.pri after r142839
Unreviewed gardening.
- Target.pri:
- 9:08 AM Changeset in webkit [144065] by
-
- 5 edits in trunk/Source
Add support for 8 bit TextRuns for Chromium/HarfBuzz
https://bugs.webkit.org/show_bug.cgi?id=99393
Reviewed by Eric Seidel.
Source/WebCore:
Adding support for 8 bit TextRuns for platforms using HarfBuzz. To accomplish this,
8 bit text runs are upconverted to 16 bit in the complex text path during string
normalization, as HarfBuzz operates on UChars.
No new tests. No change in behavior.
(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):
- platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::normalizeCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
Source/WebKit/chromium:
Enabling 8 bit text runs for Chromium.
- features.gypi:
- 8:51 AM WebKitGTK edited by
- (diff)
- 8:37 AM Changeset in webkit [144064] by
-
- 17 edits in trunk/Source
Merged Tip and Debug log levels for web console.
https://bugs.webkit.org/show_bug.cgi?id=109919
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-02-26
Reviewed by Pavel Feldman.
In every component either TIP or DEBUG level was used for reporting,
but not both. This patch is prerequisite for Web Inspector console log filtering.
Source/WebCore:
- css/MediaList.cpp:
(WebCore::addResolutionWarningMessageToConsole):
- inspector/ConsoleMessage.cpp:
(WebCore::messageLevelValue):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::abort):
- page/Console.cpp:
(WebCore::printMessageSourceAndLevelPrefix):
- page/ConsoleTypes.h:
- xml/XSLTProcessorLibxslt.cpp:
(WebCore::XSLTProcessor::parseErrorFunc):
- xml/XSLTProcessorQt.cpp:
(WebCore::XSLTMessageHandler::handleMessage):
Source/WebKit/chromium:
- public/WebConsoleMessage.h:
- src/AssertMatchingEnums.cpp:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::addMessageToConsole):
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.mm:
(stringForMessageLevel):
- WebView/WebUIDelegatePrivate.h:
Source/WebKit/wx:
- WebView.h:
- 8:28 AM Changeset in webkit [144063] by
-
- 10 edits4 adds in trunk/Source
[BlackBerry] Upstream the datalist support UI
https://bugs.webkit.org/show_bug.cgi?id=110736
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-02-26
Reviewed by Rob Buis.
Original code by Otto Derek Cheung <otcheung@rim.com>
Source/WebCore:
- css/themeBlackBerry.css:
(input::-webkit-suggestion-dropdown-box):
(input::-webkit-suggestion-dropdown-box-item):
(input::-webkit-suggestion-prefix-text):
(input::-webkit-suggestion-dropdown-box-item-last):
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::supportsDataListUI):
(WebCore):
- platform/blackberry/RenderThemeBlackBerry.h:
(RenderThemeBlackBerry):
Source/WebKit:
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
- WebCoreSupport/SuggestionBoxElement.cpp: Added.
(WebCore):
(WebCore::SuggestionBoxElement::SuggestionBoxElement):
(WebCore::SuggestionBoxElement::~SuggestionBoxElement):
(WebCore::SuggestionBoxElement::create):
(WebCore::SuggestionBoxElement::defaultEventHandler):
- WebCoreSupport/SuggestionBoxElement.h: Added.
(WebCore):
(SuggestionBoxElement):
- WebCoreSupport/SuggestionBoxHandler.cpp: Added.
(WebCore):
(WebCore::SuggestionBoxHandler::SuggestionBoxHandler):
(WebCore::SuggestionBoxHandler::~SuggestionBoxHandler):
(WebCore::SuggestionBoxHandler::create):
(WebCore::SuggestionBoxHandler::setInputElementAndUpdateDisplay):
(WebCore::SuggestionBoxHandler::showDropdownBox):
(WebCore::SuggestionBoxHandler::hideDropdownBox):
(WebCore::SuggestionBoxHandler::changeInputElementInnerTextValue):
(WebCore::SuggestionBoxHandler::parseSuggestions):
(WebCore::SuggestionBoxHandler::insertSuggestionsToDropdownBox):
(WebCore::adjustDropdownBoxPosition):
(WebCore::SuggestionBoxHandler::buildDropdownBoxTree):
- WebCoreSupport/SuggestionBoxHandler.h: Added.
(WebCore):
(SuggestionBoxHandler):
(WebCore::SuggestionBoxHandler::focusedElement):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::updateFormState):
- WebKitSupport/InputHandler.h:
(WebCore):
(InputHandler):
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 8:22 AM Changeset in webkit [144062] by
-
- 17 edits2 adds in trunk/Source
Source/WebCore: Web Inspector: plumb trace events to Timeline agent
https://bugs.webkit.org/show_bug.cgi?id=105796
Reviewed by Pavel Feldman.
- plumb trace events to Timeline;
- add TimelineTraceEventProcessor to process selected trace events;
- emit timeline events from TimelineTraceEventProcessor.
Note that actual event processing logic is a separate change.
- CMakeLists.txt: Added TimelineTraceEventProcessor.{h,cpp}.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- inspector/InspectorAllInOne.cpp: Ditto.
- inspector/InspectorClient.h:
(InspectorClient):
(WebCore::InspectorClient::setTraceEventCallback):
- inspector/InspectorTimelineAgent.cpp: create/destroy trace event processor on start/stop.
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::page):
(WebCore):
- inspector/InspectorTimelineAgent.h:
(WebCore):
(InspectorTimelineAgent):
- inspector/TimelineTraceEventProcessor.cpp: Added.
(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore):
(WebCore::TimelineTraceEventProcessor::~TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::TraceEvent::parameter):
(WebCore::TimelineTraceEventProcessor::processEventOnAnyThread):
(WebCore::TimelineTraceEventProcessor::processEvent):
(WebCore::TimelineTraceEventProcessor::sendTimelineRecord):
(WebCore::TimelineTraceEventProcessor::processBackgroundEvents):
- inspector/TimelineTraceEventProcessor.h: Added.
(WebCore):
(TimelineTraceEventProcessor):
(TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::timestamp):
(WebCore::TimelineTraceEventProcessor::TraceEvent::phase):
(WebCore::TimelineTraceEventProcessor::TraceEvent::name):
(WebCore::TimelineTraceEventProcessor::TraceEvent::threadIdentifier):
(WebCore::TimelineTraceEventProcessor::TraceEvent::argumentCount):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asBool):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asUInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asDouble):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asString):
(WebCore::TimelineTraceEventProcessor::EventTypeEntry::EventTypeEntry):
(EventTypeEntry):
Source/WebKit/chromium: Plumbing trace events to Timeline
Web Inspector: plumb trace events to Timeline agent
https://bugs.webkit.org/show_bug.cgi?id=105796
Reviewed by Pavel Feldman.
- public/WebDevToolsAgentClient.h:
(WebDevToolsAgentClient):
(WebKit::WebDevToolsAgentClient::setTraceEventCallback):
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::setTraceEventCallback):
(WebKit):
- src/InspectorClientImpl.h:
(InspectorClientImpl):
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::setTraceEventCallback):
(WebKit):
- src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
- 8:14 AM Changeset in webkit [144061] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Web Inspector: Specify return type of WebInspector.UIString
https://bugs.webkit.org/show_bug.cgi?id=110095
Reviewed by Pavel Feldman.
Specify return type of WebInspector.UIString.
Fix new js-compiler warnings.
This change will increase type coverage by 0.4% (to 81%)
- inspector/front-end/ObjectPropertiesSection.js: Fix type errors.
- inspector/front-end/UIString.js:
(WebInspector.UIString): Return type specified.
- 8:08 AM Changeset in webkit [144060] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Resources] Cookies table looks empty.
https://bugs.webkit.org/show_bug.cgi?id=110870
Reviewed by Pavel Feldman.
Fixed data-grid selector.
- inspector/front-end/resourcesPanel.css:
(.storage-view .data-grid): Fixed selector.
- 8:05 AM Changeset in webkit [144059] by
-
- 1 edit5 adds3 deletes in trunk/LayoutTests
[Chromium] New baselines for css3-modsel-15c
Unreviewed test expectations update.
- platform/chromium-linux-x86/css3/selectors3/xml: Removed.
- platform/chromium-linux/css3/selectors3/xml/css3-modsel-15c-expected.png: Added.
- platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-15c-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-15c-expected.png: Added.
- platform/chromium-win/css3/selectors3/xml/css3-modsel-15c-expected.png: Added.
- platform/chromium-win/css3/selectors3/xml/css3-modsel-15c-expected.txt: Added.
- platform/chromium/css3/selectors3/xml/css3-modsel-15c-expected.png: Removed.
- platform/chromium/css3/selectors3/xml/css3-modsel-15c-expected.txt: Removed.
- 7:59 AM Changeset in webkit [144058] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Migrate FileSystem inspection support to ResourceTreeModel's SecurityOriginAdded/Removed events.
https://bugs.webkit.org/show_bug.cgi?id=110878
Reviewed by Alexander Pavlov.
Recently added SecurityOriginAdded/Removed events support was essentially duplicated in
FileSystemModel. This patch migrates FileSystem inspection support to new events.
- inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel):
(WebInspector.FileSystemModel.prototype._reset):
(WebInspector.FileSystemModel.prototype._securityOriginAdded):
(WebInspector.FileSystemModel.prototype._securityOriginRemoved):
(WebInspector.FileSystemModel.prototype._addOrigin):
(WebInspector.FileSystemModel.prototype._removeOrigin):
(WebInspector.FileSystemModel.prototype.refreshFileSystemList):
- 7:57 AM Changeset in webkit [144057] by
-
- 5 edits in trunk
Web Inspector: Cannot deep expand an element that has previously been partially expanded
https://bugs.webkit.org/show_bug.cgi?id=110424
In the case where the children from the provided node have already been pushed, traverse children at the depth provided until we find children that have not been pushed yet.
Reviewed by Pavel Feldman.
- 7:53 AM Changeset in webkit [144056] by
-
- 14 edits1 delete in trunk/Source/JavaScriptCore
Unreviewed, rolling out r144054.
http://trac.webkit.org/changeset/144054
https://bugs.webkit.org/show_bug.cgi?id=110854
broke builds
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
- runtime/PropertyMapHashTable.h:
(PropertyTable):
(JSC::PropertyTable::PropertyTable):
(JSC):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::copy):
- runtime/PropertyTable.cpp: Removed.
- runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
(JSC::Structure::visitChildren):
- runtime/Structure.h:
(JSC):
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::checkOffsetConsistency):
(Structure):
- runtime/StructureInlines.h:
- 7:43 AM Changeset in webkit [144055] by
-
- 6 edits in trunk
REGRESSION (r143619): Crashes in three layout tests
https://bugs.webkit.org/show_bug.cgi?id=110588
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-26
Reviewed by Gustavo Noronha Silva.
Source/WebKit/gtk:
Guard against null main resource identifiers. The main resource
identifier can be null at various times during the load. A null
identifier is never equal to the ones we are looking to remove.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidFinishLoading): Use the new webkitWebViewRemoveSubresource helper.
(WebKit::FrameLoaderClient::dispatchDidFailLoading): ditto.
- webkit/webkitwebview.cpp:
(webkitWebViewRemoveSubresource): Added this helper which removes a subresource, but
never touches the main resource. This is adapted from the old method, for which the
main resource branch was dead code.
- webkit/webkitwebviewprivate.h: Update the method list.
LayoutTests:
- platform/gtk/TestExpectations: Unskip some tests which are no longer
crashing.
- 7:36 AM WebKitGTK/2.0.x edited by
- (diff)
- 7:32 AM Changeset in webkit [144054] by
-
- 14 edits1 add in trunk/Source/JavaScriptCore
Unused Structure property tables waste 14MB on Membuster.
<http://webkit.org/b/110854>
<rdar://problem/13292104>
Reviewed by Filip Pizlo.
Turn PropertyTable into a GC object and have Structure drop unpinned tables when marking.
14 MB progression on Membuster3.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
Added PropertyTable.cpp.
- runtime/PropertyTable.cpp: Added.
(JSC::PropertyTable::create):
(JSC::PropertyTable::clone):
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::destroy):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::visitChildren):
Moved marking of property table values here from Structure::visitChildren().
- runtime/StructureInlines.h:
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::checkOffsetConsistency):
Moved these to StructureInlines.h to break header dependency cycle between Structure/PropertyTable.
- runtime/Structure.cpp:
(JSC::Structure::visitChildren):
Null out m_propertyTable if the table is unpinned. This'll cause the table to get GC'd.
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
- runtime/Structure.h:
(Structure):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
- runtime/PropertyMapHashTable.h:
(PropertyTable):
(JSC::PropertyTable::createStructure):
(JSC::PropertyTable::copy):
- 6:22 AM Changeset in webkit [144053] by
-
- 25 edits2 deletes in trunk
Unreviewed, rolling out r144041, r144044, and r144048.
http://trac.webkit.org/changeset/144041
http://trac.webkit.org/changeset/144044
http://trac.webkit.org/changeset/144048
https://bugs.webkit.org/show_bug.cgi?id=105796
Broke build
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorClient.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
- inspector/InspectorInstrumentation.h:
- inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
- inspector/InspectorTimelineAgent.h:
(WebCore):
(InspectorTimelineAgent):
- inspector/TimelineRecordFactory.cpp:
- inspector/TimelineRecordFactory.h:
- inspector/TimelineTraceEventProcessor.cpp: Removed.
- inspector/TimelineTraceEventProcessor.h: Removed.
- inspector/front-end/TimelineModel.js:
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel._initRecordStyles):
Source/WebKit/chromium:
- public/WebDevToolsAgentClient.h:
- src/InspectorClientImpl.cpp:
- src/InspectorClientImpl.h:
(InspectorClientImpl):
- src/WebDevToolsAgentImpl.cpp:
- src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
LayoutTests:
- inspector/timeline/timeline-enum-stability-expected.txt:
- 6:20 AM Changeset in webkit [144052] by
-
- 9 edits in trunk
Web Inspector: Migrate IndexedDB support to ResourceTreeModel's SecurityOriginAdded/Removed events.
https://bugs.webkit.org/show_bug.cgi?id=110863
Reviewed by Alexander Pavlov.
Source/WebCore:
Recently added SecurityOriginAdded/Removed events support was essentially duplicated in
IndexedDBModel. This patch migrates IndexedDB support to new events.
- inspector/Inspector.json:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):
- inspector/InspectorIndexedDBAgent.h:
(InspectorIndexedDBAgent):
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
(WebInspector.IndexedDBModel.prototype._securityOriginAdded):
(WebInspector.IndexedDBModel.prototype._securityOriginRemoved):
(WebInspector.IndexedDBModel.prototype._addOrigin):
(WebInspector.IndexedDBModel.prototype._removeOrigin):
(WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.):
(WebInspector.IndexedDBModel.prototype._requestData):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype.securityOrigins):
LayoutTests:
- http/tests/inspector/indexeddb/database-names-expected.txt:
- http/tests/inspector/indexeddb/database-names.html:
- 5:57 AM Changeset in webkit [144051] by
-
- 9 edits6 copies in trunk/LayoutTests
Unreviewed fix after r144032.
https://bugs.webkit.org/show_bug.cgi?id=110734
Update expected files due to JSC/V8 differences.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2013-02-26
- TestExpectations: Skip 2 failing tests until proper fix.
- html5lib/generated/run-template-write.html:
- html5lib/generated/run-tests1-data-expected.txt:
- html5lib/generated/run-tests1-write-expected.txt:
- html5lib/generated/run-tests18-data-expected.txt:
- html5lib/generated/run-tests18-write-expected.txt:
- html5lib/generated/run-tests7-data-expected.txt:
- html5lib/generated/run-tests7-write-expected.txt:
- platform/chromium/html5lib/generated/run-tests1-data-expected.txt: Copied from LayoutTests/html5lib/generated/run-tests1-data-expected.txt.
- platform/chromium/html5lib/generated/run-tests1-write-expected.txt: Copied from LayoutTests/html5lib/generated/run-tests1-write-expected.txt.
- platform/chromium/html5lib/generated/run-tests18-data-expected.txt: Copied from LayoutTests/html5lib/generated/run-tests18-data-expected.txt.
- platform/chromium/html5lib/generated/run-tests18-write-expected.txt: Copied from LayoutTests/html5lib/generated/run-tests18-write-expected.txt.
- platform/chromium/html5lib/generated/run-tests7-data-expected.txt: Copied from LayoutTests/html5lib/generated/run-tests7-data-expected.txt.
- platform/chromium/html5lib/generated/run-tests7-write-expected.txt: Copied from LayoutTests/html5lib/generated/run-tests7-write-expected.txt.
- 5:51 AM Changeset in webkit [144050] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 5:51 AM Changeset in webkit [144049] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: in protocol make field "securityOrigin" in type Page.Frame mandatory
https://bugs.webkit.org/show_bug.cgi?id=80857
Reviewed by Vsevolod Vlasov.
Frame.securityOrigin has always been set to a valid value, so this change just fixes
the protocol flaw.
- inspector/Inspector.json:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrame):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._navigate):
- 5:44 AM Changeset in webkit [144048] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix following r144041.
- inspector/TimelineTraceEventProcessor.h:
(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
- 5:43 AM Changeset in webkit [144047] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: DataGrid should reveal and select next/previous DataGridNode upon deletion of selected node
https://bugs.webkit.org/show_bug.cgi?id=110862
Reviewed by Alexander Pavlov.
While deleting entries in the DataGrid, deleting of selected node should trigger selection of
next possible (backward/forward) DataGridNode.
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGridNode.prototype.get leftPadding):
(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):
- 5:42 AM Changeset in webkit [144046] by
-
- 2 edits in trunk/LayoutTests
[Chromium] TestExpectations cleanup.
Unreviewed removal of expectations for tests that are now passing.
- platform/chromium/TestExpectations:
- 5:37 AM Changeset in webkit [144045] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r143931): set-cookie-on-redirect.html breaks subsequent tests
https://bugs.webkit.org/show_bug.cgi?id=110844
Patch by Sergio Villar Senin <svillar@igalia.com> on 2013-02-26
Reviewed by Alexey Proskuryakov.
Clean up cookies at the beginning and after finishing the test in
order not to break other tests behavior.
- http/tests/cookies/resources/set-cookie-on-redirect.php: clear cookie before returning.
- http/tests/cookies/set-cookie-on-redirect.html: clear all cookies before starting the test.
- 5:12 AM Changeset in webkit [144044] by
-
- 13 edits in trunk
Source/WebCore: Web Inspector: show raster tasks on Timeline
https://bugs.webkit.org/show_bug.cgi?id=105851
- add PaintLayer, Paint & RasterTask trace events handling to trace event processor;
- upon begin frame, emit aggregated background event for all raster tasks related to the inspected page.
Reviewed by Pavel Feldman.
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(InstrumentationEvents):
(InstrumentationEventArguments):
- inspector/InspectorInstrumentation.h:
(InstrumentationEvents):
(WebCore):
(InstrumentationEventArguments):
- inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::didBeginFrame):
- inspector/InspectorTimelineAgent.h:
(TimelineRecordType):
(WebCore):
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createRasterData):
(WebCore):
- inspector/TimelineRecordFactory.h:
(TimelineRecordFactory):
- inspector/TimelineTraceEventProcessor.cpp:
(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::~TimelineTraceEventProcessor):
(WebCore):
(WebCore::TimelineTraceEventProcessor::registerHandler):
(WebCore::TimelineTraceEventProcessor::shutdown):
(WebCore::TimelineTraceEventProcessor::TraceEvent::findParameter):
(WebCore::TimelineTraceEventProcessor::TraceEvent::parameter):
(WebCore::TimelineTraceEventProcessor::processEventOnAnyThread):
(WebCore::TimelineTraceEventProcessor::onBeginFrame):
(WebCore::TimelineTraceEventProcessor::onPaintLayerBegin):
(WebCore::TimelineTraceEventProcessor::onPaintLayerEnd):
(WebCore::TimelineTraceEventProcessor::onRasterTaskBegin):
(WebCore::TimelineTraceEventProcessor::onRasterTaskEnd):
(WebCore::TimelineTraceEventProcessor::onLayerDeleted):
(WebCore::TimelineTraceEventProcessor::onPaint):
(WebCore::TimelineTraceEventProcessor::flushRasterizerStatistics):
(WebCore::TimelineTraceEventProcessor::sendTimelineRecord):
(WebCore::TimelineTraceEventProcessor::processBackgroundEvents):
- inspector/TimelineTraceEventProcessor.h:
(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::id):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asBool):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asUInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asDouble):
(TimelineTraceEventProcessor):
- inspector/front-end/TimelineModel.js:
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel._initRecordStyles):
LayoutTests: Web Inspector: show deferred paints on Timeline
https://bugs.webkit.org/show_bug.cgi?id=105851
Reviewed by Pavel Feldman.
- inspector/timeline/timeline-enum-stability-expected.txt: Added "Rasterize" record type.
- 5:11 AM WebKitGtkLayoutTests edited by
- Add explanation to launch a single unit test (diff)
- 5:04 AM Changeset in webkit [144043] by
-
- 9 edits1 add in trunk/Source
Implement JIT on Windows 64 bits
https://bugs.webkit.org/show_bug.cgi?id=107965
Reviewed by Simon Hausmann.
Source/JavaScriptCore:
- MSVC doesn't support inline assembly for 64 bits, implements the trampoline in a separate ASM file.
- Windows 64 bits has a different calling convention than other OSes following the AMD64 ABI.
Differences that we have to handle here:
- Registers passed parameters are RCX, RDX, R8 and R9 instead of RDI, RSI, RDX, RCX, R8 and R9
- RDI and RSI must be preserved by callee
- Only return values <= 8 bytes can be returned by register (RDX can't be used to return a second word)
- There is no red-zone after RIP on the stack, but instead 4 reserved words before it
- Target.pri:
- jit/JITStubs.cpp:
- jit/JITStubs.h:
(JSC):
(JITStackFrame):
(JSC::JITStackFrame::returnAddressSlot):
- jit/JITStubsMSVC64.asm: Added.
- jit/JSInterfaceJIT.h:
(JSInterfaceJIT):
- jit/ThunkGenerators.cpp:
(JSC::nativeForGenerator):
- yarr/YarrJIT.cpp:
(YarrGenerator):
(JSC::Yarr::YarrGenerator::generateEnter):
(JSC::Yarr::YarrGenerator::generateReturn):
Source/WTF:
- wtf/Platform.h:
- 5:01 AM Changeset in webkit [144042] by
-
- 2 edits in trunk/Source/WebCore
Work around a MSVC 2012 Update 1 bug causing a crash on x86
https://bugs.webkit.org/show_bug.cgi?id=110488
Reviewed by Anders Carlsson.
The crash happens when building with /O2, where TextEncodingNameHash::equal is
incorrectly optimized with the inlined toASCIILower and uses a register already in use.
The function returns false incorrectly, causing a mismatch of text encoding name which
then results in a null pointer access.
Slightly rewording the use of the inline function lets the compiler produce correct code.
The bug has already been reported and should be fixed in the next release of MSVS later this year.
https://connect.microsoft.com/VisualStudio/feedback/details/777533/vs2012-c-optimizing-bug-when-using-inline-and-char-return-type-x86-target-only
- platform/text/TextEncodingRegistry.cpp:
- 4:52 AM Changeset in webkit [144041] by
-
- 17 edits2 adds in trunk/Source
Web Inspector: plumb trace events to Timeline agent
https://bugs.webkit.org/show_bug.cgi?id=105796
Reviewed by Pavel Feldman.
Source/WebCore:
- plumb trace events to Timeline;
- add TimelineTraceEventProcessor to process selected trace events;
- emit timeline events from TimelineTraceEventProcessor.
Note that actual event processing logic is a separate change.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/Inspector.json:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorClient.h:
(InspectorClient):
(WebCore::InspectorClient::setTraceEventCallback):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::appendBackgroundThreadRecord):
(WebCore):
(WebCore::InspectorTimelineAgent::page):
- inspector/InspectorTimelineAgent.h:
(WebCore):
(InspectorTimelineAgent):
- inspector/TimelineTraceEventProcessor.cpp: Added.
(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore):
(WebCore::TimelineTraceEventProcessor::~TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::TraceEvent::parameter):
(WebCore::TimelineTraceEventProcessor::processEventOnAnyThread):
(WebCore::TimelineTraceEventProcessor::processEvent):
(WebCore::TimelineTraceEventProcessor::sendTimelineRecord):
(WebCore::TimelineTraceEventProcessor::processBackgroundEvents):
- inspector/TimelineTraceEventProcessor.h: Added.
(WebCore):
(TimelineTraceEventProcessor):
(TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::timestamp):
(WebCore::TimelineTraceEventProcessor::TraceEvent::phase):
(WebCore::TimelineTraceEventProcessor::TraceEvent::name):
(WebCore::TimelineTraceEventProcessor::TraceEvent::threadIdentifier):
(WebCore::TimelineTraceEventProcessor::TraceEvent::argumentCount):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asBool):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asUInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asDouble):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asString):
(WebCore::TimelineTraceEventProcessor::EventTypeEntry::EventTypeEntry):
(EventTypeEntry):
- inspector/front-end/TimelineFrameController.js:
(WebInspector.TimelineFrameController.prototype._addRecord):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelineRecordListRow.prototype.update):
(WebInspector.TimelineRecordGraphRow.prototype.update):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.insertRetrospecitveRecord):
(WebInspector.TimelinePresentationModel.Record.prototype.get isBackground):
- inspector/front-end/timelinePanel.css:
(.timeline-tree-item.background .timeline-tree-icon):
(.timeline-graph-side.background .timeline-graph-bar):
Source/WebKit/chromium:
Plumb trace events to Inspector.
- public/WebDevToolsAgentClient.h:
(WebDevToolsAgentClient):
(WebKit::WebDevToolsAgentClient::setTraceEventCallback):
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::setTraceEventCallback):
(WebKit):
- src/InspectorClientImpl.h:
(InspectorClientImpl):
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::setTraceEventCallback):
(WebKit):
- src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
- 4:52 AM Changeset in webkit [144040] by
-
- 2 edits in trunk/Tools
new-commit-bot: Some IRC clients doesn't linkify rollout messages
https://bugs.webkit.org/show_bug.cgi?id=110861
Reviewed by Ryosuke Niwa.
Adding the space before ':' in order to fix the links shown for the rollout message.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot._summarize_commit_log):
- 4:42 AM Changeset in webkit [144039] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: display background events on Timeline
https://bugs.webkit.org/show_bug.cgi?id=108599
Reviewed by Pavel Feldman.
- add optional `thread' field to timeline event;
- if thread field is present, display the event as 'background' (hollow bar / list icon), align to nearest foreground event;
- do not account background events in Frame mode of overview.
- inspector/Inspector.json:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::appendBackgroundThreadRecord):
(WebCore):
- inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
- inspector/front-end/TimelineFrameController.js:
(WebInspector.TimelineFrameController.prototype._addRecord):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelineRecordListRow.prototype.update):
(WebInspector.TimelineRecordGraphRow.prototype.update):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.insertRetrospecitveRecord):
(WebInspector.TimelinePresentationModel.Record.prototype.get isBackground):
- inspector/front-end/timelinePanel.css:
(.timeline-tree-item.background .timeline-tree-icon):
(.timeline-graph-side.background .timeline-graph-bar):
- 4:33 AM Changeset in webkit [144038] by
-
- 12 edits in trunk/Source/WebCore
[V8] Rename BatchedCallback to BatchedMethod
https://bugs.webkit.org/show_bug.cgi?id=110791
Reviewed by Adam Barth.
Now 'Callback' is used to refer to functions that are called back
by V8. DOM methods should be referred to as 'Method's.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
(WebCore::ConfigureV8Float64ArrayTemplate):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
(WebCore::ConfigureV8TestEventTargetTemplate):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):
- bindings/v8/V8DOMConfiguration.cpp:
(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):
- bindings/v8/V8DOMConfiguration.h:
(V8DOMConfiguration):
- 4:08 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:01 AM Changeset in webkit [144037] by
-
- 3 edits3 adds in trunk
Add User-Agent header in opening handshake headers.
https://bugs.webkit.org/show_bug.cgi?id=110601
Reviewed by Alexey Proskuryakov.
RFC-6455 doesn't require to send User-Agent header, but allow it.
Many web application developers want to have it, and Firefox already
did it. This patch adds User-Agent header in opening handshake also in
WebKit ports.
Test: http/tests/websocket/tests/hybi/useragent-in-openinghandshake.html
Source/WebCore:
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):
LayoutTests:
- http/tests/websocket/tests/hybi/sendback_ua_wsh.py: Added.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
- http/tests/websocket/tests/hybi/useragent-in-openinghandshake-expected.txt: Added.
- http/tests/websocket/tests/hybi/useragent-in-openinghandshake.html: Added.
- 4:01 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:41 AM Changeset in webkit [144036] by
-
- 2 edits in trunk/Source/WebCore
XSSAuditor: Don't rely on implicit casting when copying the document's KURL to String.
https://bugs.webkit.org/show_bug.cgi?id=110859
Reviewed by Jochen Eisinger.
XSSAuditor::init should explicitly make a thread-safe copy of the
document's URL as a String rather than relying on implicit casting from
a copy of the KURL.
This shouldn't change any visible behavior; all existing XSSAuditor
tests should continue to pass. They'll now just be a bit more smug while
doing so.
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
- 3:38 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:31 AM Changeset in webkit [144035] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Updating expectations for two inspector tests.
Expanding expectation for media/encrypted-media/encrypted-media-syntax.html to expect timeouts as well.
Adding a flaky failure expectation for svg/custom/animation-currentColor.svg.
- 3:30 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:28 AM WebKitGTK/1.10.x edited by
- (diff)
- 3:22 AM Changeset in webkit [144034] by
-
- 1 edit1 add in trunk/LayoutTests
[chromium] add content shell specific TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=110710
Reviewed by Eric Seidel.
For now, add tests that pass on content shell but fail on DRT.
Next, I will file bugs for all the remaining failing tests and skip
them here to ease the transition from DRT.
- platform/chromium/ContentShellTestExpectations: Added.
- 3:09 AM Changeset in webkit [144033] by
-
- 1 edit3 moves1 add in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk1/http/tests/navigation/forward-and-cancel-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/navigation/forward-and-cancel-expected.txt.
- platform/qt-5.0-wk1/http/tests/navigation/postredirect-frames-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/navigation/postredirect-frames-expected.txt.
- platform/qt-5.0-wk1/http/tests/navigation/postredirect-goback2-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/navigation/postredirect-goback2-expected.txt.
- 3:05 AM Changeset in webkit [144032] by
-
- 4 edits82 copies7 moves93 adds50 deletes in trunk/LayoutTests
Layout Test Multiple html5lib/ tests are too slow and should be split.
https://bugs.webkit.org/show_bug.cgi?id=110734
Reviewed by Adam Barth.
Split all of the html5lib tests into write and data variants
instead of running both in sequence in each test.
I added a script to autogenerate all of the test harness files
from the *.dat files in resources/ (which we sync with the
upstream html5lib tests.
I removed all the old tests and expectations as well as TestExpectation entries.
All of these tests should now be fast enough to avoid timeout on all platforms.
I set the expectations from my chromium-linux (v8) machine, thus someone
from a jsc port will need to rebaseline appropriately from their machine.
- TestExpectations:
- html5lib/generate-test-wrappers.py: Added.
(WrapperGenerator):
(_files_in_directory_with_suffix):
(_last_path_component_removing_suffix):
(_remove_harness_prefix):
(_remove_harness_type):
(_test_name_from_harness_name):
(_remove_stale_tests):
(_input_path):
(_harness_path):
(_harness_content):
(_write_harness):
(main):
- html5lib/generated/run-adoption01-data-expected.txt: Added.
- html5lib/generated/run-adoption01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-adoption01-write-expected.txt: Added.
- html5lib/generated/run-adoption01-write.html: Renamed from LayoutTests/html5lib/generated/run-template.html.
- html5lib/generated/run-adoption02-data-expected.txt: Added.
- html5lib/generated/run-adoption02-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-adoption02-write-expected.txt: Added.
- html5lib/generated/run-adoption02-write.html: Renamed from LayoutTests/html5lib/generated/run-tests11.html.
- html5lib/generated/run-comments01-data-expected.txt: Added.
- html5lib/generated/run-comments01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-comments01-write-expected.txt: Added.
- html5lib/generated/run-comments01-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-doctype01-data-expected.txt: Added.
- html5lib/generated/run-doctype01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-doctype01-write-expected.txt: Added.
- html5lib/generated/run-doctype01-write.html: Renamed from LayoutTests/html5lib/generated/run-tests10.html.
- html5lib/generated/run-domjs-unsafe-data-expected.txt: Added.
- html5lib/generated/run-domjs-unsafe-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-domjs-unsafe-write-expected.txt: Added.
- html5lib/generated/run-domjs-unsafe-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-entities01-data-expected.txt: Added.
- html5lib/generated/run-entities01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-entities01-write-expected.txt: Added.
- html5lib/generated/run-entities01-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-entities02-data-expected.txt: Added.
- html5lib/generated/run-entities02-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-entities02-write-expected.txt: Added.
- html5lib/generated/run-entities02-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-html5test-com-data-expected.txt: Added.
- html5lib/generated/run-html5test-com-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-html5test-com-write-expected.txt: Added.
- html5lib/generated/run-html5test-com-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-inbody01-data-expected.txt: Added.
- html5lib/generated/run-inbody01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-inbody01-write-expected.txt: Added.
- html5lib/generated/run-inbody01-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-isindex-data-expected.txt: Added.
- html5lib/generated/run-isindex-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-isindex-write-expected.txt: Added.
- html5lib/generated/run-isindex-write.html: Renamed from LayoutTests/html5lib/generated/run-tests2.html.
- html5lib/generated/run-pending-spec-changes-data-expected.txt: Added.
- html5lib/generated/run-pending-spec-changes-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-pending-spec-changes-plain-text-unsafe-data-expected.txt: Added.
- html5lib/generated/run-pending-spec-changes-plain-text-unsafe-data.html: Added.
- html5lib/generated/run-pending-spec-changes-plain-text-unsafe-write-expected.txt: Added.
- html5lib/generated/run-pending-spec-changes-plain-text-unsafe-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-pending-spec-changes-write-expected.txt: Added.
- html5lib/generated/run-pending-spec-changes-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-plain-text-unsafe-data-expected.txt: Added.
- html5lib/generated/run-plain-text-unsafe-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-plain-text-unsafe-write-expected.txt: Added.
- html5lib/generated/run-plain-text-unsafe-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-scriptdata01-data-expected.txt: Added.
- html5lib/generated/run-scriptdata01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-scriptdata01-write-expected.txt: Added.
- html5lib/generated/run-scriptdata01-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tables01-data-expected.txt: Added.
- html5lib/generated/run-tables01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tables01-write-expected.txt: Added.
- html5lib/generated/run-tables01-write.html: Renamed from LayoutTests/html5lib/generated/run-tests22.html.
- html5lib/generated/run-template-data-expected.txt: Added.
- html5lib/generated/run-template-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-template-expected.txt: Removed.
- html5lib/generated/run-template-write-expected.txt: Added.
- html5lib/generated/run-template-write.html: Renamed from LayoutTests/html5lib/generated/run-tests3.html.
- html5lib/generated/run-tests1-data-expected.txt: Added.
- html5lib/generated/run-tests1-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests1-expected.txt: Removed.
- html5lib/generated/run-tests1-write-expected.txt: Added.
- html5lib/generated/run-tests1-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests10-data-expected.txt: Added.
- html5lib/generated/run-tests10-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests10-expected.txt: Removed.
- html5lib/generated/run-tests10-write-expected.txt: Added.
- html5lib/generated/run-tests10-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests11-data-expected.txt: Added.
- html5lib/generated/run-tests11-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests11-expected.txt: Removed.
- html5lib/generated/run-tests11-write-expected.txt: Added.
- html5lib/generated/run-tests11-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests12-data-expected.txt: Added.
- html5lib/generated/run-tests12-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests12-expected.txt: Removed.
- html5lib/generated/run-tests12-write-expected.txt: Added.
- html5lib/generated/run-tests12-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests12.html: Removed.
- html5lib/generated/run-tests14-data-expected.txt: Added.
- html5lib/generated/run-tests14-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests14-expected.txt: Removed.
- html5lib/generated/run-tests14-write-expected.txt: Added.
- html5lib/generated/run-tests14-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests14.html: Removed.
- html5lib/generated/run-tests15-data-expected.txt: Added.
- html5lib/generated/run-tests15-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests15-expected.txt: Removed.
- html5lib/generated/run-tests15-write-expected.txt: Added.
- html5lib/generated/run-tests15-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests15.html: Removed.
- html5lib/generated/run-tests16-data-expected.txt: Added.
- html5lib/generated/run-tests16-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests16-expected.txt: Removed.
- html5lib/generated/run-tests16-write-expected.txt: Added.
- html5lib/generated/run-tests16-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests16.html: Removed.
- html5lib/generated/run-tests17-data-expected.txt: Added.
- html5lib/generated/run-tests17-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests17-expected.txt: Removed.
- html5lib/generated/run-tests17-write-expected.txt: Added.
- html5lib/generated/run-tests17-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests17.html: Removed.
- html5lib/generated/run-tests18-data-expected.txt: Added.
- html5lib/generated/run-tests18-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests18-expected.txt: Removed.
- html5lib/generated/run-tests18-write-expected.txt: Added.
- html5lib/generated/run-tests18-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests18.html: Removed.
- html5lib/generated/run-tests19-data-expected.txt: Added.
- html5lib/generated/run-tests19-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests19-expected.txt: Removed.
- html5lib/generated/run-tests19-write-expected.txt: Added.
- html5lib/generated/run-tests19-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests19.html: Removed.
- html5lib/generated/run-tests2-data-expected.txt: Added.
- html5lib/generated/run-tests2-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests2-expected.txt: Removed.
- html5lib/generated/run-tests2-write-expected.txt: Added.
- html5lib/generated/run-tests2-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests20-data-expected.txt: Added.
- html5lib/generated/run-tests20-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests20-expected.txt: Removed.
- html5lib/generated/run-tests20-write-expected.txt: Added.
- html5lib/generated/run-tests20-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests20.html: Removed.
- html5lib/generated/run-tests21-data-expected.txt: Added.
- html5lib/generated/run-tests21-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests21-expected.txt: Removed.
- html5lib/generated/run-tests21-write-expected.txt: Added.
- html5lib/generated/run-tests21-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests21.html: Removed.
- html5lib/generated/run-tests22-data-expected.txt: Added.
- html5lib/generated/run-tests22-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests22-expected.txt: Removed.
- html5lib/generated/run-tests22-write-expected.txt: Added.
- html5lib/generated/run-tests22-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests23-data-expected.txt: Added.
- html5lib/generated/run-tests23-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests23-expected.txt: Removed.
- html5lib/generated/run-tests23-write-expected.txt: Added.
- html5lib/generated/run-tests23-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests23.html: Removed.
- html5lib/generated/run-tests24-data-expected.txt: Added.
- html5lib/generated/run-tests24-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests24-expected.txt: Removed.
- html5lib/generated/run-tests24-write-expected.txt: Added.
- html5lib/generated/run-tests24-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests24.html: Removed.
- html5lib/generated/run-tests25-data-expected.txt: Added.
- html5lib/generated/run-tests25-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests25-expected.txt: Removed.
- html5lib/generated/run-tests25-write-expected.txt: Added.
- html5lib/generated/run-tests25-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests25.html: Removed.
- html5lib/generated/run-tests26-data-expected.txt: Added.
- html5lib/generated/run-tests26-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests26-expected.txt: Removed.
- html5lib/generated/run-tests26-write-expected.txt: Added.
- html5lib/generated/run-tests26-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests26.html: Removed.
- html5lib/generated/run-tests3-data-expected.txt: Added.
- html5lib/generated/run-tests3-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests3-expected.txt: Removed.
- html5lib/generated/run-tests3-write-expected.txt: Added.
- html5lib/generated/run-tests3-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests4-data-expected.txt: Added.
- html5lib/generated/run-tests4-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests4-expected.txt: Removed.
- html5lib/generated/run-tests4-write-expected.txt: Added.
- html5lib/generated/run-tests4-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests4.html: Removed.
- html5lib/generated/run-tests5-data-expected.txt: Added.
- html5lib/generated/run-tests5-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests5-expected.txt: Removed.
- html5lib/generated/run-tests5-write-expected.txt: Added.
- html5lib/generated/run-tests5-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests5.html: Removed.
- html5lib/generated/run-tests6-data-expected.txt: Added.
- html5lib/generated/run-tests6-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests6-expected.txt: Removed.
- html5lib/generated/run-tests6-write-expected.txt: Added.
- html5lib/generated/run-tests6-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests6.html: Removed.
- html5lib/generated/run-tests7-data-expected.txt: Added.
- html5lib/generated/run-tests7-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests7-expected.txt: Removed.
- html5lib/generated/run-tests7-write-expected.txt: Added.
- html5lib/generated/run-tests7-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests7.html: Removed.
- html5lib/generated/run-tests8-data-expected.txt: Added.
- html5lib/generated/run-tests8-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests8-expected.txt: Removed.
- html5lib/generated/run-tests8-write-expected.txt: Added.
- html5lib/generated/run-tests8-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests8.html: Removed.
- html5lib/generated/run-tests9-data-expected.txt: Added.
- html5lib/generated/run-tests9-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests9-expected.txt: Removed.
- html5lib/generated/run-tests9-write-expected.txt: Added.
- html5lib/generated/run-tests9-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests9.html: Removed.
- html5lib/generated/run-tests_innerHTML_1-data-expected.txt: Added.
- html5lib/generated/run-tests_innerHTML_1-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tests_innerHTML_1-write-expected.txt: Added.
- html5lib/generated/run-tests_innerHTML_1-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tricky01-data-expected.txt: Added.
- html5lib/generated/run-tricky01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-tricky01-write-expected.txt: Added.
- html5lib/generated/run-tricky01-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-webkit01-data-expected.txt: Added.
- html5lib/generated/run-webkit01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-webkit01-write-expected.txt: Added.
- html5lib/generated/run-webkit01-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-webkit02-data-expected.txt: Added.
- html5lib/generated/run-webkit02-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/generated/run-webkit02-write-expected.txt: Added.
- html5lib/generated/run-webkit02-write.html: Renamed from LayoutTests/html5lib/generated/run-tests1.html.
- html5lib/resources/runner.js:
(window.onload):
- html5lib/runner-expected.txt: Removed.
- html5lib/runner.html: Removed.
- platform/chromium/TestExpectations:
- platform/chromium/html5lib/generated/run-tests1-expected.txt: Removed.
- platform/chromium/html5lib/generated/run-tests18-expected.txt: Removed.
- platform/chromium/html5lib/generated/run-tests7-expected.txt: Removed.
- 2:51 AM Changeset in webkit [144031] by
-
- 3 edits2 adds in trunk
Shadow DOM styles appear to be over-eagerly shared
https://bugs.webkit.org/show_bug.cgi?id=110797
Reviewed by Dimitri Glazkov.
Source/WebCore:
A style of a distributed node should not be shared, because the node
might be affected by styles in a shadow dom tree, i.e. :distributed
or something.
Test: fast/dom/shadow/no-style-sharing-with-distributed-nodes.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::locateCousinList):
Skip shadow hosts, because children of shadow hosts are distributed
nodes and cannot share their styles.
LayoutTests:
- fast/dom/shadow/no-style-sharing-with-distributed-nodes-expected.html: Added.
- fast/dom/shadow/no-style-sharing-with-distributed-nodes.html: Added.
- 2:40 AM Changeset in webkit [144030] by
-
- 2 edits in trunk/Source/WebCore
Remove unused conditional includes of {MathML,SVG}Names.h
https://bugs.webkit.org/show_bug.cgi?id=110809
Reviewed by Eric Seidel.
- html/parser/HTMLConstructionSite.cpp:
- 2:30 AM Changeset in webkit [144029] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Update platform specific expected file after r143836.
- 2:05 AM Changeset in webkit [144028] by
-
- 2 edits in trunk/Tools
[GTK] Add Clutter to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=110245
Reviewed by Martin Robinson.
Add clutter, cogl, clutter-gtk, and atk to the optional moduleset.
This allows to build WebKitGtk+ with clutter as an acceleration backend
within the jhbuild environment.
- gtk/jhbuild-optional.modules:
- 1:57 AM Changeset in webkit [144027] by
-
- 2 edits in trunk/Source/WebCore
Threaded HTML parser fails fast/loader/stateobjects/state-attribute-history-getter.html
https://bugs.webkit.org/show_bug.cgi?id=110801
Reviewed by Adam Barth.
This causes 6 more tests to pass for the threaded parser,
an solves all of our timeout issues.
These tests which were failing were racy, we just were never
hitting the race due to using file urls. This change fixes
the threaded parser to emulate one more of the EOF quirks from
the loader/main-thread-parser interaction.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
- 1:47 AM Changeset in webkit [144026] by
-
- 2 edits in trunk/Source/JavaScriptCore
Kill another analyzer warning in javascriptcore
https://bugs.webkit.org/show_bug.cgi?id=110802
Reviewed by Benjamin Poulain.
Add null checks.
- profiler/LegacyProfiler.cpp:
(JSC::LegacyProfiler::startProfiling):
(JSC::LegacyProfiler::stopProfiling):
- 1:15 AM Changeset in webkit [144025] by
-
- 7 edits in trunk
Web Inspector: CSSAgent.setStyleSheetText crashes on inline styles
https://bugs.webkit.org/show_bug.cgi?id=110359
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo): Pass ExceptionCode into setText().
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::redo): Ditto.
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::setText): Make use of checkPageStyleSheet().
(WebCore::InspectorStyleSheet::setRuleSelector): Ditto.
(WebCore::InspectorStyleSheet::addRule): Ditto.
(WebCore::InspectorStyleSheet::deleteRule): Ditto.
(WebCore::InspectorStyleSheet::checkPageStyleSheet):
Return NOT_SUPPORTED_ERR if no m_pageStyleSheet.
(WebCore::InspectorStyleSheet::setStyleText): Check field directly.
- inspector/InspectorStyleSheet.h:
LayoutTests:
- inspector/styles/styles-new-API-expected.txt:
- inspector/styles/styles-new-API.html:
- 1:13 AM Changeset in webkit [144024] by
-
- 26 edits9 copies42 adds in trunk
Implement coordinated scrollbar for subframes and overflow:scroll
https://bugs.webkit.org/show_bug.cgi?id=109560
Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-02-26
Reviewed by James Robinson.
Source/WebCore:
This patch obsoletes ScrollingCoordinatorPrivate for the Chromium
implementation. Also removes the concept of a single main scrolling
layer. Should use HashMap to keep track resources for multiple
scrollable objects.
Many of the callbacks are extended to support ScrollableArea instead
of just FrameView. Now ScrollingCoordinatorChromium coordinates
scrollbars for both subframes and overflow:scroll.
Some drive-by change:
- Remove the GraphicsLayer parameter for layer change callbacks. Should be able to get the latest layer from the ScrollableArea anyway.
- Should start from main frame document when updating touch event target rects.
New chromium test: ScrollingCoordinatorChromiumTest.iframeScrolling
- page/Frame.cpp:
(WebCore::Frame::willDetachPage):
- page/FrameView.cpp:
(WebCore::FrameView::prepareForDetach):
(WebCore::FrameView::layerForScrolling):
(WebCore):
- page/FrameView.h:
(FrameView):
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::scrollLayerForScrollableArea):
(WebCore):
(WebCore::ScrollingCoordinator::horizontalScrollbarLayerForScrollableArea):
(WebCore::ScrollingCoordinator::verticalScrollbarLayerForScrollableArea):
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::willDestroyScrollableArea):
(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
(WebCore::ScrollingCoordinator::scrollableAreaScrollbarLayerDidChange):
(ScrollingCoordinator):
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::scrollingWebLayerForGraphicsLayer):
(WebCore::ScrollingCoordinatorChromium::scrollingWebLayerForScrollableArea):
(WebCore::ScrollingCoordinatorChromium::ScrollingCoordinatorChromium):
(WebCore::ScrollingCoordinatorChromium::~ScrollingCoordinatorChromium):
(WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinatorChromium::touchEventTargetRectsDidChange):
(WebCore::createScrollbarLayer):
(WebCore::detachScrollbarLayer):
(WebCore::setupScrollbarLayer):
(WebCore::ScrollingCoordinatorChromium::willDestroyScrollableArea):
(WebCore::ScrollingCoordinatorChromium::scrollableAreaScrollbarLayerDidChange):
(WebCore::ScrollingCoordinatorChromium::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinatorChromium::setTouchEventTargetRects):
(WebCore::ScrollingCoordinatorChromium::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinatorChromium::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinatorChromium::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinatorChromium::setLayerIsFixedToContainerLayer):
(WebCore::ScrollingCoordinatorChromium::scrollableAreaScrollLayerDidChange):
(WebCore::ScrollingCoordinatorChromium::addWebScrollbarLayer):
(WebCore):
(WebCore::ScrollingCoordinatorChromium::getWebScrollbarLayer):
(WebCore::ScrollingCoordinatorChromium::removeWebScrollbarLayer):
- page/scrolling/chromium/ScrollingCoordinatorChromium.h:
(WebCore):
(ScrollingCoordinatorChromium):
- page/scrolling/mac/ScrollingCoordinatorMac.h:
(ScrollingCoordinatorMac):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::scrollableAreaScrollbarLayerDidChange):
- platform/ScrollableArea.h:
(ScrollableArea):
(WebCore::ScrollableArea::layerForScrolling):
- platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
(WebCore::GraphicsLayer::setContentsToPlatformLayer):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::layerForScrolling):
(WebCore):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateOverflowControlsLayers):
(WebCore::RenderLayerBacking::positionOverflowControlsLayers):
(WebCore::RenderLayerBacking::updateScrollingLayers):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidScroll):
(WebCore::RenderLayerCompositor::scrollingLayerDidChange):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Source/WebKit/chromium:
Added ScrollingCoordinatorChromiumTest.iframeScrolling to verify
impl-side scrolling and impl-side scrollbars for frames.
Update ScrollingCoordinatorChromiumTest.overflowScrolling to verify
impl-side scrollbars.
- tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(WebKit::TEST_F):
(WebKit):
- tests/data/iframe-scrolling-inner.html: Added.
- tests/data/iframe-scrolling.html: Added.
LayoutTests:
Coordinated scrollbars changes drawsContent flag on scrollbar GraphicsLayers,
test expectation are updated.
- platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
- platform/chromium-linux/compositing/iframes/composited-parent-iframe-expected.txt: Added.
- platform/chromium-linux/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
- platform/chromium-linux/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
- platform/chromium-linux/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
- platform/chromium-linux/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
- platform/chromium-linux/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
- platform/chromium-linux/compositing/iframes/iframe-resize-expected.txt: Added.
- platform/chromium-linux/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
- platform/chromium-linux/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
- platform/chromium-linux/compositing/iframes/overlapped-iframe-expected.txt: Added.
- platform/chromium-linux/compositing/iframes/resizer-expected.txt: Added.
- platform/chromium-linux/compositing/iframes/scrolling-iframe-expected.txt: Added.
- platform/chromium-linux/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
- platform/chromium-linux/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
- platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt:
- platform/chromium-linux/compositing/overflow/textarea-scroll-touch-expected.txt: Added.
- platform/chromium-linux/compositing/overflow/updating-scrolling-content-expected.txt:
- platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
- platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
- platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
- platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
- platform/chromium-linux/platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-overlay-with-touch-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-content-clip-to-viewport-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/become-overlapped-iframe-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/composited-parent-iframe-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe2-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe3-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/enter-compositing-iframe-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/iframe-resize-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/iframe-size-from-zero-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/overlapped-iframe-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/resizer-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/scrolling-iframe-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/scrolling-content-clip-to-viewport-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/scrolling-without-painting-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/updating-scrolling-content-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
- platform/chromium/TestExpectations:
- 1:07 AM Changeset in webkit [144023] by
-
- 5 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r144004.
http://trac.webkit.org/changeset/144004
https://bugs.webkit.org/show_bug.cgi?id=110858
This iOS change is outdated (Requested by notbenjamin on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-26
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitNode):
(JSC::BytecodeGenerator::emitNodeInConditionContext):
(BytecodeGenerator):
- parser/Parser.cpp:
(JSC::::Parser):
- parser/Parser.h:
(JSC::Parser::canRecurse):
(Parser):
- 1:06 AM Changeset in webkit [144022] by
-
- 3 edits in trunk/Source/WebCore
[V8] Overloaded constructors don't need header declarations
https://bugs.webkit.org/show_bug.cgi?id=110799
Reviewed by Adam Barth.
They are implemented as static functions in cpp files.
Header declarations are not needed.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
- 1:04 AM Changeset in webkit [144021] by
-
- 4 edits1 delete in trunk/Source
Unreviewed, rolling out r144016.
http://trac.webkit.org/changeset/144016
https://bugs.webkit.org/show_bug.cgi?id=110856
Breaks compilation on chromium mac (Requested by vsevik on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-26
Source/WebCore:
- platform/chromium/KeyCodeConversionGtk.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
Source/WebKit/chromium:
- WebKit.gypi:
- tests/KeyCodeConversionTest.cpp: Removed.
- 12:49 AM Changeset in webkit [144020] by
-
- 2 edits in trunk/Source/WTF
Appease static analyzer warning about null string passed to strlen
https://bugs.webkit.org/show_bug.cgi?id=110658
Reviewed by Benjamin Poulain.
Add a null check before calling strlen
- wtf/Threading.cpp:
(WTF::createThread):
- 12:42 AM Changeset in webkit [144019] by
-
- 11 edits in trunk
Source/WebCore: Add support to -webkit-line-break property for CSS3 Text line-break property values and semantics.
https://bugs.webkit.org/show_bug.cgi?id=89235
Reviewed by Eric Seidel.
This patch adds semantic support for the CSS3 line-break property (qua -webkit-line-break),
and enables testing on (apple) mac ports. Follow on patches will enable these tests on
other ports as they are incrementally verified.
See also wiki documentation at:
[1] http://trac.webkit.org/wiki/LineBreaking
[2] http://trac.webkit.org/wiki/LineBreakingCSS3Mapping
Tests: css3/line-break/line-break-auto-centered.html
css3/line-break/line-break-auto-half-kana.html
css3/line-break/line-break-auto-hyphens.html
css3/line-break/line-break-auto-inseparables.html
css3/line-break/line-break-auto-iteration-marks.html
css3/line-break/line-break-auto-postfixes.html
css3/line-break/line-break-auto-prefixes.html
css3/line-break/line-break-auto-sound-marks.html
css3/line-break/line-break-loose-centered.html
css3/line-break/line-break-loose-half-kana.html
css3/line-break/line-break-loose-hyphens.html
css3/line-break/line-break-loose-inseparables.html
css3/line-break/line-break-loose-iteration-marks.html
css3/line-break/line-break-loose-postfixes.html
css3/line-break/line-break-loose-prefixes.html
css3/line-break/line-break-loose-sound-marks.html
css3/line-break/line-break-normal-centered.html
css3/line-break/line-break-normal-half-kana.html
css3/line-break/line-break-normal-hyphens.html
css3/line-break/line-break-normal-inseparables.html
css3/line-break/line-break-normal-iteration-marks.html
css3/line-break/line-break-normal-postfixes.html
css3/line-break/line-break-normal-prefixes.html
css3/line-break/line-break-normal-sound-marks.html
css3/line-break/line-break-strict-centered.html
css3/line-break/line-break-strict-half-kana.html
css3/line-break/line-break-strict-hyphens.html
css3/line-break/line-break-strict-inseparables.html
css3/line-break/line-break-strict-iteration-marks.html
css3/line-break/line-break-strict-postfixes.html
css3/line-break/line-break-strict-prefixes.html
css3/line-break/line-break-strict-sound-marks.html
These tests were previously added in http://trac.webkit.org/changeset/143378, but skipped
in generic TestExpectations. In this patch, they are marked as Pass for the (apple) mac ports.
- platform/text/LineBreakIteratorPoolICU.h:
(WebCore::LineBreakIteratorPool::makeLocaleWithBreakKeyword):
Add static function to construct ICU locale argument (also used as pool key) with additional
break keyword.
(LineBreakIteratorPool):
(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
Remove direct dependency from ICU library (and types), moving that dependency into
new {open,close}LineBreakIterator() functions (defined in TextBreakIteratorICU.cpp).
Update to take line break mode into account.
Create (and cache) different break iterators depending on line break mode (in addition to locale),
which entails expanding pool entry key format to optionally append "@break=" +
"loose"|"normal"|"strict" keyword to locale string.
- platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::isLooseCJKMode):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):
Define LineBreakIteratorMode enumeration for use in TextBreakIterator et al.
Add state member to indicate line break mode.
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::acquireLineBreakIterator):
Use new line break mode when making iterator from pool.
Handle change of return type of LineBreakIteratorPool::take() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::releaseLineBreakIterator):
Handle change of parameter type of LineBreakIteratorPool::put() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore):
(WebCore::isCJKLocale):
New functions for determining if CJK rules apply.
(WebCore::openLineBreakIterator):
New function for abstracting opening of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
This function also takes into account the line break mode.
(WebCore::closeLineBreakIterator):
(WebCore::mapLineIteratorModeToRules):
New function for abstracting closing of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
Pass line break iterator mode flag when reseting LazyLineBreakIterator.
Add looseMode local variable to prevent need for computing under isBreakable().
- rendering/RenderText.cpp:
(WebCore::mapLineBreakToIteratorMode):
Add implementation for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.
(WebCore):
(WebCore::RenderText::computePreferredLogicalWidths):
Ensure (lazy line) breakIterator is initialized for line break mode.
Ensure isBreakable() is passed loose mode flag to match behavior in RenderBlock::LineBreaker::nextLineBreak.
- rendering/RenderText.h:
(WebCore):
Add declaration for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.
- rendering/break_lines.cpp:
(WebCore):
Introduce (local) enum NBSPBehavior for expanding template on nextBreakablePosition.
(WebCore::isBreakableSpace):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation. Use new loose mode flavors off NBP functions.
(WebCore::needsLineBreakIterator):
Use enum NBSP behavior template parameter rather than boolean.
(WebCore::nextBreakablePositionNonLoosely):
Extend name to distinguish from loose flavor of this function.
(WebCore::nextBreakablePositionLoosely):
Add loose flavor of NBP invoked only when loose mode applies, in which case ASCII shortcut
table cannot be used.
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
Use (renamed) non-loose flavor of NBP.
(WebCore::nextBreakablePositionLoose):
(WebCore::nextBreakablePositionIgnoringNBSPLoose):
Introduce loose flavor of NBP template expansions.
- rendering/break_lines.h:
(WebCore):
(WebCore::isBreakable):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation.
LayoutTests: CSS3: line-break property support
https://bugs.webkit.org/show_bug.cgi?id=89235
Reviewed by Eric Seidel.
- platform/mac/TestExpectations: Mark css3/line-break tests as passing.
- 12:38 AM Changeset in webkit [144018] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskipp now passing tests after r144005.
https://bugs.webkit.org/show_bug.cgi?id=110756.
Reviewed by Geoffrey Garen.
- platform/qt/TestExpectations:
- 12:34 AM Changeset in webkit [144017] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Fix continuous painting mode
https://bugs.webkit.org/show_bug.cgi?id=110788
Patch by James Robinson <jamesr@chromium.org> on 2013-02-26
Reviewed by Adrienne Walker.
Recent instrumentation shuffling caused WebViewImpl::didBeginFrame to no longer be called, which
broke continuous painting. Since continuous painting mode is meant to simply invalidate layers
on each frame, it's a better fit for the animation system. This moves the invalidation calls
into WebViewImpl::updateAnimations along with other animation type things.
Tested manually by enabling continuous painting mode in the inspector. There aren't any automated
tests in WebKit for this feature.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setContinuousPaintingEnabled):
(WebKit::WebViewImpl::didBeginFrame):
(WebKit::WebViewImpl::updateAnimations):
- src/painting/ContinuousPainter.cpp:
(WebKit::ContinuousPainter::setNeedsDisplayRecursive):
- 12:32 AM Changeset in webkit [144016] by
-
- 4 edits1 add in trunk/Source
keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux
https://bugs.webkit.org/show_bug.cgi?id=85642
Source/WebCore:
Add missing key mappings for GDK_KP_Begin, GDK_KP_Insert, GDK_KP_Delete and GDK_ISO_Level3_Shift.
Patch by James Weatherall <wez@chromium.org> on 2013-02-26
Reviewed by Ojan Vafai.
- platform/chromium/KeyCodeConversionGtk.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
Source/WebKit/chromium:
Add tests to verify that the fixed keys generate the same keyCode values
as their equivalents.
Patch by James Weatherall <wez@chromium.org> on 2013-02-26
Reviewed by Ojan Vafai.
- WebKit.gypi:
- tests/KeyCodeConversionTest.cpp: Added.
(WebCore):
(WebCore::TEST):
- 12:28 AM Changeset in webkit [144015] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed trivial !ENABLE(NETSCAPE_PLUGIN_API) build fix
Add an intermediate pluginName string variable instead of
accessing plugin.info outside the feature #ifdef.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
Feb 25, 2013:
- 11:57 PM Changeset in webkit [144014] by
-
- 2 edits in trunk/Tools
Another fix attempt after r143991 since having \r? after a greedy match doesn't help.
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.value_from_svn_info):
- 11:56 PM Changeset in webkit [144013] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 11:47 PM Changeset in webkit [144012] by
-
- 3 edits in trunk/Source/WebKit2
Coordinated Graphics: remove redundant update of non compositing layer.
https://bugs.webkit.org/show_bug.cgi?id=110444
Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-25
Reviewed by Noam Rosenthal.
Currently, we update non compositing layer when the page scrolled. However, it
is not needed, because TiledBackingStore can scroll without tile update.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost):
- 11:42 PM Changeset in webkit [144011] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r143981): Crash in WebFrameLoaderClient::dispatchDidStartProvisionalLoad()
https://bugs.webkit.org/show_bug.cgi?id=110848
Reviewed by Ryosuke Niwa.
NULL-check the result of document->documentElement().
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
- 11:21 PM Changeset in webkit [144010] by
-
- 9 edits in trunk/Source/WebCore
6% regression in intl1 page cycler on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=110784
Unreviewed.
This patch restores the code that I rolled out in
http://trac.webkit.org/changeset/143960 and
http://trac.webkit.org/changeset/143983. Rolling out those patches did
not heal the bot.
- dom/Element.cpp:
(WebCore::Element::addAttributeInternal):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::UniqueElementData::makeShareableCopy):
(WebCore::UniqueElementData::addAttribute):
(WebCore::UniqueElementData::removeAttribute):
(WebCore::ElementData::reportMemoryUsage):
(WebCore::UniqueElementData::getAttributeItem):
(WebCore):
(WebCore::UniqueElementData::attributeItem):
- dom/Element.h:
(ElementData):
(UniqueElementData):
(WebCore::isShadowHost):
(WebCore::ElementData::length):
(WebCore::ElementData::attributeItem):
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::resumeFrom):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
- html/parser/CSSPreloadScanner.cpp:
(WebCore):
(WebCore::CSSPreloadScanner::scanCommon):
(WebCore::CSSPreloadScanner::scan):
(WebCore::CSSPreloadScanner::emitRule):
- html/parser/CSSPreloadScanner.h:
(CSSPreloadScanner):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::startBackgroundParser):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::tagIdFor):
(WebCore):
(WebCore::TokenPreloadScanner::initiatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(TokenPreloadScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::createCheckpoint):
(WebCore::TokenPreloadScanner::rewindTo):
(WebCore::TokenPreloadScanner::scan):
(WebCore::TokenPreloadScanner::scanCommon):
(WebCore::TokenPreloadScanner::updatePredictedBaseURL):
(WebCore::HTMLPreloadScanner::scan):
- html/parser/HTMLPreloadScanner.h:
(TokenPreloadScanner):
(WebCore::TokenPreloadScanner::isSafeToSendToAnotherThread):
(WebCore::TokenPreloadScanner::Checkpoint::Checkpoint):
(Checkpoint):
- 11:01 PM Changeset in webkit [144009] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 10:32 PM Changeset in webkit [144008] by
-
- 2 edits in trunk/Tools
GCE EWS bots failing intermittently on HTTP 502 error while updating their status
https://bugs.webkit.org/show_bug.cgi?id=110845
Unreviewed EWS bot fix.
Switch the Queue Status Server address the EWS bots use to a more direct URL that
doesn't seem to be having problems from GCE like queues.webkit.org.
Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-25
- Scripts/webkitpy/common/net/statusserver.py:
(StatusServer):
- 10:24 PM TestExpectations edited by
- editorial cleanup (diff)
- 10:13 PM TestExpectations edited by
- editorial cleanup (diff)
- 10:10 PM TestExpectations edited by
- describe how to learn which expectations files apply (diff)
- 10:00 PM TestExpectations edited by
- editorial cleanup; add info on generic test expectations file (diff)
- 9:57 PM TestExpectations edited by
- editorial cleanup (diff)
- 9:54 PM TestExpectations edited by
- editorial cleanup (diff)
- 9:53 PM Changeset in webkit [144007] by
-
- 2 edits in trunk/Source/WebCore
AudioDestinationChromium should pass in inputDeviceId when creating WebKit::WebAudioDevice
https://bugs.webkit.org/show_bug.cgi?id=110796
Reviewed by Kenneth Russell.
- platform/audio/chromium/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
- 9:51 PM TestExpectations edited by
- clarify usage of WontFix | Skip (diff)
- 9:49 PM TestExpectations edited by
- ensure grammaticality (diff)
- 9:47 PM TestExpectations edited by
- qualify "equivalent" (diff)
- 9:36 PM Creating and Submitting Layout Tests and Patches edited by
- add description about using webkit-patch upload instead of svn-create-patch (diff)
- 9:06 PM Changeset in webkit [144006] by
-
- 25 edits4 deletes in trunk/Source/WebCore
Need a more robust WebSQL disk usage computation.
https://bugs.webkit.org/show_bug.cgi?id=110805.
Reviewed by Geoffrey Garen.
- Changed DatabaseTracker::usageForOrigin() to compute the disk usage for a specified origin by fetching database sizes from the file system instead of using cached file size values.
- The OriginQuotaManager and OriginUsageRecord are no longer needed. Updated build files to reflect this.
- Removed getMaxSizeForDatabase() from DatabaseManager, DatabaseServer, and AbstractDatabaseServer since it is only needed in the backend.
- DatabaseTracker::getMaxSizeForDatabase() now calls usageForOrigin() to get the disk usage for its computation.
- The performance difference for this changes is a 1.6% degradation per additional database whose size needs to be fetched. This is a worst case estimated based on the disk-stat-speed-test.html benchmark (attached to bugzilla). The benchmark writes an average of 16 bytes per transaction. Most real-world transactions will likely write more content than that. Since disk write IO time will dominate over memory read time for fetching the file size, the degradation ratio will only reduce with larger workloads.
No layout test, but there is a quota-test.html attached to bugzilla.
The test is a webpage that can be loaded into multiple tabs to
consuming storage space. While the test is running, we can run a
"du -k; du -k *" on the database directory to verify that the total
disk usage does not far exceed the allowed quota (some small error
is expected). Without this change, each database from each tab may
exceed the quota by that same maginitude of error.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/webdatabase/AbstractDatabaseServer.h:
- Modules/webdatabase/Database.cpp:
- Modules/webdatabase/Database.h:
- Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::DatabaseBackendBase::maximumSize):
- Modules/webdatabase/DatabaseManager.cpp:
- Modules/webdatabase/DatabaseManager.h:
- Modules/webdatabase/DatabaseServer.cpp:
- Modules/webdatabase/DatabaseServer.h:
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::hasAdequateQuotaForOrigin):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::retryCanEstablishDatabase):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::usageForOrigin):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
- Modules/webdatabase/DatabaseTracker.h:
- Modules/webdatabase/OriginQuotaManager.cpp: Removed.
- Modules/webdatabase/OriginQuotaManager.h: Removed.
- Modules/webdatabase/OriginUsageRecord.cpp: Removed.
- Modules/webdatabase/OriginUsageRecord.h: Removed.
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState):
- Modules/webdatabase/SQLTransactionBackendSync.cpp:
(WebCore::SQLTransactionBackendSync::executeSQL):
- Modules/webdatabase/SQLTransactionClient.cpp:
- Modules/webdatabase/SQLTransactionClient.h:
- Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp:
- Target.pri:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- 8:25 PM Changeset in webkit [144005] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r143654): some jquery test asserts on 32 bit debug build
https://bugs.webkit.org/show_bug.cgi?id=110756
Reviewed by Geoffrey Garen.
TypeOf does speculations manually, so it should mark its JSValueOperand as doing ManualOperandSpeculation.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 8:13 PM Changeset in webkit [144004] by
-
- 5 edits in trunk/Source/JavaScriptCore
[JSC] Upstream iOS Stack bound checking
https://bugs.webkit.org/show_bug.cgi?id=110813
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-25
Reviewed by Filip Pizlo.
On iOS, the StackBounds cannot be cached because the stack
can be in one of two threads (the web thread or the UI thread).
We simply always consider the current stack bound when testing
stack boundaries.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitNode):
(JSC::BytecodeGenerator::emitNodeInConditionContext):
(BytecodeGenerator):
- parser/Parser.cpp:
(JSC::::Parser):
- parser/Parser.h:
(JSC::Parser::canRecurse):
(Parser):
- 8:04 PM Changeset in webkit [144003] by
-
- 3 edits in trunk/Source/WebCore
[texmap] Rename TextureMapperGL::ClipStack::init to reset
https://bugs.webkit.org/show_bug.cgi?id=110783
Reviewed by Noam Rosenthal.
Functions named init() are usually called inside ctor's to initialize
member variables that were unable to be assigned on an initialization
list, which is not the case, and also because reset() better reflects
the behavior (clears the clip stack and assigns a value to the initial
clip state).
No behavior changes, thus covered by existing tests.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::ClipStack::reset):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::initializeDepthBuffer):
- platform/graphics/texmap/TextureMapperGL.h:
(ClipStack):
- 7:18 PM Changeset in webkit [144002] by
-
- 3 edits in trunk/Source/WebKit/chromium
Add expandedToParagraph() method to WebRange
https://bugs.webkit.org/show_bug.cgi?id=110618
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-25
Reviewed by Adam Barth.
Add a method expandedToParagraph() to WebRange to return a copy of the
range expanded to paragraph boundaries. This method is to be used to
query the spelling context around the misspelled word under cursor.
- public/WebRange.h:
(WebRange): Added expandedToParagraph() method declaration.
- src/WebRange.cpp:
(WebKit::WebRange::expandedToParagraph): Added method to copy range, expand the copied range to paragraph boundaries, and return the resulting range.
(WebKit): Added expandedToParagraph() method definition.
- 7:02 PM Changeset in webkit [144001] by
-
- 2 edits in trunk/Source/WTF
Build fix attempt after r143996.
- wtf/FastMalloc.cpp:
(WTF):
- 6:36 PM Changeset in webkit [144000] by
-
- 5 edits in trunk/Source/WebCore
Threaded HTML parser should pass fast/parser/iframe-sets-parent-to-javascript-url.html
https://bugs.webkit.org/show_bug.cgi?id=110637
Reviewed by Eric Seidel.
With the main thread parser, we always parse the first chunk of content
returned as the result of evaluating a JavaScript URL synchronously. In
particular, if the first chunk has an inline script, we'll execute it
synchronously.
Previous to this patch, the threaded parser would always parse this
content asynchronously. It's conceivable that there could be some
content relying on the synchronous behavior, so this patch introduces
the notion of "pinning" a parser to the main thread and uses that
concept to force the result of JavaScript URLs to be parsed on the main
thread (which is probably desirable anyway because they're likely to be
quite short).
This patch fixes fast/parser/iframe-sets-parent-to-javascript-url.html
and fast/dom/javascript-url-crash-function.html with the threaded
parser with --enable-threaded-html-parser.
- dom/DocumentParser.h:
(WebCore::DocumentParser::pinToMainThread):
(DocumentParser):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore):
(WebCore::HTMLDocumentParser::pinToMainThread):
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
(WebCore::HTMLDocumentParser::shouldUseThreading):
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
- 6:33 PM Changeset in webkit [143999] by
-
- 2 edits in trunk/Source/WebCore
Update the localizable strings file.
Rubber-stamped by Anders Carlsson.
- English.lproj/Localizable.strings:
- 6:25 PM Changeset in webkit [143998] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] WebViewImpl::m_client can be null in some unit tests, check it before calling
https://bugs.webkit.org/show_bug.cgi?id=110834
Reviewed by Adrienne Walker.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::suppressInvalidations):
(WebKit::WebViewImpl::setRootGraphicsLayer):
- 6:25 PM Changeset in webkit [143997] by
-
- 2 edits in trunk/Source/WTF
Unreviewed. Fix script to use WEBKIT_SOURCE for VS2010 property sheets instead of WEBKIT_LIBRARIES.
- WTF.vcxproj/work-around-vs-dependency-tracking-bugs.py:
- 6:13 PM Changeset in webkit [143996] by
-
- 2 edits in trunk/Source/WTF
Add cookies to FastMalloc spans
https://bugs.webkit.org/show_bug.cgi?id=110827
Reviewed by Michael Saboff.
Add a cookie to spans, and move some of the hardening around so
that it's more useful.
- wtf/FastMalloc.cpp:
(WTF::internalEntropyValue):
(WTF::spanInitializerCookie):
(WTF::Span::initCookie):
(WTF::Span::clearCookie):
(WTF::Span::isValid):
(Span):
(WTF::NewSpan):
(WTF::DeleteSpan):
(WTF::TCMalloc_ThreadCache_FreeList::Validate):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Deallocate):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- 6:10 PM Changeset in webkit [143995] by
-
- 2 edits in trunk/Tools
Forgot to delete a no-longer-needed unit test after r143980.
Unreviewed, build fix.
- Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_path_to_image_diff):
- 6:10 PM Changeset in webkit [143994] by
-
- 2 edits in trunk/Source/JavaScriptCore
For JSVALUE32_64, maxOffsetRelativeToPatchedStorage() doesn't compute the maximum negative offset
https://bugs.webkit.org/show_bug.cgi?id=110828
Reviewed by Oliver Hunt.
- runtime/JSObject.h:
(JSC::maxOffsetRelativeToPatchedStorage): Only add the OBJECT_OFFSETOF(tag) for positive offsets.
That way this function will return the offset farthest from 0 needed to access either the payload
or tag.
- 6:06 PM Changeset in webkit [143993] by
-
- 5 edits4 adds in trunk
Flexbox should ignore firstLetter pseudo element.
https://bugs.webkit.org/show_bug.cgi?id=105126
Patch by Xueqing Huang <huangxueqing@baidu.com> on 2013-02-25
Reviewed by Tony Chang.
Source/WebCore:
The CSS WG decided that first-line and first-letter should not
apply to flex containers.
http://dev.w3.org/csswg/css3-flexbox/issue-cr-2012#issue-13
tests:
css3/flexbox/flexbox-ignore-firstLetter.html
css3/flexbox/flexbox-ignore-container-firstLetter.html
- rendering/RenderBlock.cpp:
(WebCore::findFirstLetterBlock):
LayoutTests:
The CSS WG decided that first-line and first-letter should not
apply to flex containers.
http://dev.w3.org/csswg/css3-flexbox/issues-cr-2012#issue-13
- css3/flexbox/flexbox-ignore-container-firstLetter-expected.txt: Added.
- css3/flexbox/flexbox-ignore-container-firstLetter.html: Added.
- css3/flexbox/flexbox-ignore-firstLetter-expected.txt: Added.
- css3/flexbox/flexbox-ignore-firstLetter.html: Added.
- css3/flexbox/inline-flex-crash-expected.txt:
- css3/flexbox/inline-flex-crash2-expected.txt:
- 5:35 PM Changeset in webkit [143992] by
-
- 2 edits in branches/chromium/1410/Source/WebCore
Merge 142545
WEBGL_compressed_texture_s3tc extension can be enabled even when not supported
https://bugs.webkit.org/show_bug.cgi?id=109508
Reviewed by Kenneth Russell.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::getExtension): Check whether the extension support is there before returning the extension pointer.
TBR=zmo@google.com
Review URL: https://codereview.chromium.org/12334083
- 5:24 PM Changeset in webkit [143991] by
-
- 2 edits in trunk/Tools
Build fix. run-perf-tests was reporting with revision numbers ending with \r.
Don't include \r at the end of svn info lines on Windows.
This is similar to r143839.
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.value_from_svn_info):
- 5:22 PM Changeset in webkit [143990] by
-
- 2 edits in trunk/Source/WebCore
Lots of unnecessary DidLayout notifications when scrolling zoomed page with iframes
https://bugs.webkit.org/show_bug.cgi?id=110824
Reviewed by Tim Horton.
RenderWidget::setWidgetGeometry() compares the old and new frame rects to decide
if the geometry changed. However, it use implicit IntRect->LayoutRect promotion in
the comparison, and then roundedIntRect() in setting. Thus the code would think
that the geometry changed, even when the final assigned frame did not.
Fix by computing the new frame using roundedIntRect(), and using that to determine
whether the geometry changed.
No way to test DidLayout notifications in DRT/WTR.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
- 5:13 PM Changeset in webkit [143989] by
-
- 10 edits22 moves3 adds in trunk
[Resource Timing] Update test suite so it can be exported to the W3C
https://bugs.webkit.org/show_bug.cgi?id=107343
Reviewed by Tony Gentilcore.
Tools:
- Scripts/export-w3c-performance-wg-tests: Clean up output.
- Scripts/import-w3c-performance-wg-tests:
LayoutTests:
- http/tests/w3c/webperf/resources/webperftestharness.js: Removed unneeded functions and moved new ones to extension.
- http/tests/w3c/webperf/resources/webperftestharnessextension.js:
(test_resource_entries):
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order-expected.txt.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order.html.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_cached-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached-expected.txt.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_cached.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached.html.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_connection_reuse-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_connection_reuse-expected.txt.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_connection_reuse.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_connection_reuse.html.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_dynamic_insertion-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion-expected.txt.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_dynamic_insertion.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion.html.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_frame_initiator_type-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_frame_initiator_type-expected.txt.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_frame_initiator_type.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_frame_initiator_type.html.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_data_url-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url-expected.txt.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_data_url.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url.html.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_failures-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_failures-expected.txt.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_failures.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_failures.html.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_initiator_types-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_initiator_types.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_redirects-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects-expected.txt.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_redirects.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects.html.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_reparenting-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_reparenting-expected.txt.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_reparenting.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_reparenting.html.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_script_types-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_script_types-expected.txt.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_script_types.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_script_types.html.
- platform/chromium/TestExpectations: Moved directories...
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- 5:06 PM Changeset in webkit [143988] by
-
- 16 edits in trunk
Source/WebKit2: Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
https://bugs.webkit.org/show_bug.cgi?id=110821
Reviewed by Beth Dakin.
- UIProcess/API/C/WKPage.cpp:
(WKPageGetPluginInformationPluginspageAttributeURLKey):
(WKPageGetPluginInformationPluginURLKey):
Add two new API key getters.
- UIProcess/API/C/WKPage.h:
Add a new callback and deprecate the old callback.
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didFailToInitializePlugin):
(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
(WebKit::WebLoaderClient::pluginLoadPolicy):
Make the pluginInformationDictionary a static member function of WebPageProxy so it
can be called from WebUIClient as well.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath):
Pass the bundle version as well.
(WebKit::WebPageProxy::pluginInformationPluginspageAttributeURLKey):
(WebKit::WebPageProxy::pluginInformationPluginURLKey):
Add two new keys.
(WebKit::WebPageProxy::pluginInformationDictionary):
Handle more keys.
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
Get the plug-in bundle identifier and version.
- UIProcess/WebPageProxy.messages.in:
Pass along more information; the frame and page URLs.
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::unavailablePluginButtonClicked):
Call the new callback if it's supported.
- UIProcess/WebUIClient.h:
(WebUIClient):
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Update for API changes.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
Ensure that the pluginspage attribute is a valid URL.
Tools: Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
https://bugs.webkit.org/show_bug.cgi?id=110821
<rdar://problem/13265303>
Reviewed by Beth Dakin.
Update for WebKit2 changes.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::unavailablePluginButtonClicked):
- WebKitTestRunner/TestController.h:
(TestController):
- 4:50 PM Changeset in webkit [143987] by
-
- 3 edits in trunk/Source/WebKit/chromium
Remove browser patching mechanism for handling javascript dialogs in chromium port
https://bugs.webkit.org/show_bug.cgi?id=110531
Patch by Ken Kania <kkania@chromium.org> on 2013-02-25
Reviewed by Pavel Feldman.
- public/WebDevToolsAgent.h:
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
(WebKit::browserHintToString):
(WebKit::browserHintFromString):
(WebKit::WebDevToolsAgent::patchWithBrowserData):
- 4:49 PM Changeset in webkit [143986] by
-
- 37 edits7 adds in trunk
Optionally partition cache to prevent using cache for tracking
https://bugs.webkit.org/show_bug.cgi?id=110269
Reviewed by Maciej Stachowiak.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig: Add defines for cache partitioning and public suffix list usage
Source/WebCore:
Implement memory cache partitioning by passing the cache name through
resource requests into a new version of resourceForURL.
Test: http/tests/cache/partitioned-cache.html
- Configurations/FeatureDefines.xcconfig: Add defines for cache partitioning and public suffix list usage
- WebCore.exp.in: Export new functions for WKSI and test suite
- WebCore.xcodeproj/project.pbxproj:
- html/DOMURL.cpp:
(WebCore::DOMURL::revokeObjectURL): Retrofit for new resourceForRequest function
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResource): Retrofit for new resourceForRequest function
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::replayXHR): Retrofit for new resourceForRequest function
- loader/DocumentLoader.h:
(DocumentLoader):
(WebCore::DocumentLoader::recordMemoryCacheLoadForFutureClientNotification): Retrofit for new resourceForRequest function
(WebCore::DocumentLoader::takeMemoryCacheLoadsForClientNotification): Retrofit for new resourceForRequest function
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadedResourceFromMemoryCache): Retrofit for new resourceForRequest function
(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads): Retrofit for new resourceForRequest function
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create): Retrofit for new resourceForRequest function
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
- loader/cache/CachedResource.h: Retrofit for new resourceForRequest function
(CachedResource):
(WebCore::CachedResource::cachePartition):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet): Retrofit for new resourceForRequest function
(WebCore::CachedResourceLoader::requestResource): Retrofit for new resourceForRequest function
(WebCore::CachedResourceLoader::loadResource): Retrofit for new resourceForRequest function
- loader/cache/MemoryCache.cpp:
(WebCore):
(WebCore::partitionName): Add function for determining absolute partition name
(WebCore::MemoryCache::add): Retrofit for partition mapping
(WebCore::MemoryCache::revalidationSucceeded): Retrofit for partition mapping
(WebCore::MemoryCache::resourceForURL): Call into new resourceForRequest
(WebCore::MemoryCache::resourceForRequest): Retrofit for partition mapping
(WebCore::MemoryCache::evict): Retrofit for partition mapping
(WebCore::MemoryCache::removeResourcesWithOrigin): Retrofit for partition mapping
(WebCore::MemoryCache::getOriginsWithCache): Retrofit for partition mapping
(WebCore::MemoryCache::removeUrlFromCache): Retrofit for partition mapping
(WebCore::MemoryCache::removeRequestFromCache): Retrofit for partition mapping
(WebCore::MemoryCache::removeRequestFromCacheImpl): Retrofit for partition mapping
(WebCore::MemoryCache::crossThreadRemoveRequestFromCache): Add function for calling removeRequestFromCacheImpl that takes a CrossThreadResourceRequestData
(WebCore::MemoryCache::getStatistics): Retrofit for partition mapping
(WebCore::MemoryCache::setDisabled): Retrofit for partition mapping
- loader/cache/MemoryCache.h:
(MemoryCache):
- page/SecurityOrigin.cpp:
(WebCore):
(WebCore::SecurityOrigin::cachePartition): Add function for determining the cache partition name
- page/SecurityOrigin.h:
(SecurityOrigin):
- platform/PublicSuffix.h: Added.
(WebCore):
- platform/mac/PublicSuffixMac.mm: Added.
(WebCore):
(WebCore::isPublicSuffix):
(WebCore::topPrivatelyControlledDomain):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/network/cf/ResourceRequest.h:
(ResourceRequest):
(WebCore::ResourceRequest::cachePartition):
(WebCore::ResourceRequest::setCachePartition):
(CrossThreadResourceRequestData):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doPlatformCopyData): Pass through cache partition name
(WebCore):
(WebCore::ResourceRequest::doPlatformAdopt): Pass through cache partition name
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest): Pass through cache partition name
(WebCore::ResourceRequest::doUpdatePlatformRequest): Pass through cache partition name
Source/WebKit/mac:
Update WKSI bindings and add feature defines.
- Configurations/FeatureDefines.xcconfig: Add defines for cache partitioning and public suffix list usage
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
Update WKSI bindings and add feature defines.
- Configurations/FeatureDefines.xcconfig: Add defines for cache partitioning and public suffix list usage
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Tools:
Add test suite for public suffix functions on Mac.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/PublicSuffix.mm: Added.
(TestWebKitAPI):
(TestWebKitAPI::TEST_F):
WebKitLibraries:
Update WKSI bindings.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
LayoutTests:
Added tests for ensuring the cache partitioning functions
- http/tests/cache/partitioned-cache-expected.txt: Added.
- http/tests/cache/partitioned-cache.html: Added.
- http/tests/cache/resources/echo-cookie.cgi: Added.
- http/tests/cache/resources/partitioned-cache-loader.html: Added.
- 4:44 PM Changeset in webkit [143985] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Plumb WebViewImpl's compositor scheduling suppression out to WebWidgetClient
https://bugs.webkit.org/show_bug.cgi?id=110640
Patch by James Robinson <jamesr@chromium.org> on 2013-02-25
Reviewed by Adrienne Walker.
This plumbs the WebViewImpl::m_suppressInvalidations logic out to the WebWidgetClient so
it can be implemented by the embedder. The existing logic is left in place for now,
once the embedder side has landed WebViewImpl will be purely a pass-through.
- public/WebWidgetClient.h:
(WebWidgetClient):
(WebKit::WebWidgetClient::suppressCompositorScheduling):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::suppressInvalidations):
(WebKit::WebViewImpl::setRootGraphicsLayer):
- 4:21 PM Changeset in webkit [143984] by
-
- 10 edits in trunk/Source
Normalize ENABLE_ENCRYPTED_MEDIA definitions across all FeatureDefines files.
https://bugs.webkit.org/show_bug.cgi?id=110806
Source/WebCore:
Reviewed by Alexey Proskuryakov.
Ensure both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 are enabled on macosx_1090.
- Configurations/FeatureDefines.xcconfig:
Fix some build errors which occurred when both ENCRYPTED_MEDIA and
ENCRYPTED_MEDIA_V2 were enabled:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::webkitGenerateKeyRequest):
(WebCore::HTMLMediaElement::webkitAddKey):
- page/DOMWindow.idl:
Source/WebKit/mac:
Reviewed by Alexey Proskuryakov.
Ensure both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 are enabled on macosx_1090.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Ensure both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 are enabled on macosx_1090.
Reviewed by Alexey Proskuryakov.
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
Reviewed by Alexey Proskuryakov.
Ensure both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 are enabled on macosx_1090.
- wtf/FeatureDefines.h:
- 4:12 PM Changeset in webkit [143983] by
-
- 3 edits in trunk/Source/WebCore
6% regression in intl1 page cycler on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=110784
Reviewed by Eric Seidel.
This patch reverts http://trac.webkit.org/changeset/143014 to see if
that's the cause of the PLT regression. If it's not the cause, I'll
roll it back in.
- dom/Element.cpp:
(WebCore::Element::addAttributeInternal):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::UniqueElementData::makeShareableCopy):
(WebCore::ElementData::addAttribute):
(WebCore::ElementData::removeAttribute):
(WebCore::ElementData::reportMemoryUsage):
- dom/Element.h:
(ElementData):
(UniqueElementData):
(WebCore::ElementData::mutableAttributeVector):
(WebCore):
(WebCore::ElementData::immutableAttributeArray):
(WebCore::ElementData::length):
(WebCore::ElementData::getAttributeItem):
(WebCore::ElementData::attributeItem):
- 3:48 PM Changeset in webkit [143982] by
-
- 2 edits in trunk/Source/WebKit2
Full screen mode should not exit when application resigns active state.
https://bugs.webkit.org/show_bug.cgi?id=106129
Reviewed by Darin Adler.
Now that full screen windows get their own full screen space, there is no reason to exit full
screen mode when the application resigns active state. Instead, the windowserver will bring the
space containing the newly active application to the foreground. The user can then swipe back
to the full screen space (or use Mission Control) to get back to the full screen window.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController windowDidLoad]): Remove the applicationDidResignActive: notification from WKFullScreenWindowController.
- 3:39 PM Changeset in webkit [143981] by
-
- 2 edits in trunk/Source/WebKit2
Safari shows empty window and paints webpage in full-screen background
https://bugs.webkit.org/show_bug.cgi?id=103712
Reviewed by Darin Adler.
When canceling full screen mode due to a provisional load, exit normally instead of closing the
full screen window controller. Additionally, to ensure full screen is cancelled when the enclosing
frame around a full screen iframe is navigated, check to see if the navigating document contains
a full screen element, rather than checking whether the document itself is full screen.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
- 3:36 PM Changeset in webkit [143980] by
-
- 2 edits in trunk/Tools
nrwt: reenable multiple http shards on chromium win
https://bugs.webkit.org/show_bug.cgi?id=110814
Reviewed by Tony Chang.
The underlying bug in DumpRenderTree that was causing us to look for a
pac file and timeout under load was fixed a while ago.
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort.relative_test_filename):
- 3:32 PM Changeset in webkit [143979] by
-
- 2 edits in trunk/Source/WebCore
Page::m_isInWindow is uninitialized
https://bugs.webkit.org/show_bug.cgi?id=110807
Reviewed by Simon Fraser.
Ideally m_isInWindow and m_isOnscreen would default to false, and be flipped to true
when the Page is put in-window or on-screen. However, only the Mac port seems to ever
call setIsInWindow/didMoveOnscreen. So, we have to default to true and flip it to false
immediately after construction on Mac.
This is just matching the behaviour of the existing m_isOnscreen.
- page/Page.cpp:
(WebCore::Page::Page): Initialize m_isInWindow to true.
- 3:02 PM Changeset in webkit [143978] by
-
- 2 edits in trunk/Tools
Make ninja the default w/ build-webkit --chromium on windows.
https://bugs.webkit.org/show_bug.cgi?id=110731
Unreviewed - TBR'ing thakis :).
- Scripts/update-webkit-chromium:
- 2:58 PM Changeset in webkit [143977] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
- 2:38 PM Changeset in webkit [143976] by
-
- 13 edits in trunk
Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
https://bugs.webkit.org/show_bug.cgi?id=110793
<rdar://problem/13265303>
Reviewed by Sam Weinig.
Source/WebKit2:
Add a new pluginDidFail callback that takes a WKDictionaryRef and also pass in the
frame and page URLs.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::pluginInformationDictionary):
(WebKit::WebLoaderClient::didFailToInitializePlugin):
(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
(WebKit::WebLoaderClient::pluginLoadPolicy):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFailToInitializePlugin):
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didFailToInitializePlugin):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Tools:
Update for WebKit2 API changes.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
- 2:27 PM Changeset in webkit [143975] by
-
- 8 edits18 copies11 moves28 adds44 deletes in trunk/LayoutTests
Move html5lib/run-test* into html5lib/generated in preparation for generating these harnesses
https://bugs.webkit.org/show_bug.cgi?id=110795
Reviewed by Ojan Vafai.
- html5lib/generated/run-template-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-template.html: Added.
- html5lib/generated/run-tests1-expected.txt: Renamed from LayoutTests/html5lib/run-test7-expected.txt.
- html5lib/generated/run-tests1.html: Added.
- html5lib/generated/run-tests10-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests10.html: Added.
- html5lib/generated/run-tests11-expected.txt: Renamed from LayoutTests/html5lib/run-test11-expected.txt.
- html5lib/generated/run-tests11.html: Added.
- html5lib/generated/run-tests12-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests12.html: Added.
- html5lib/generated/run-tests14-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests14.html: Added.
- html5lib/generated/run-tests15-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests15.html: Added.
- html5lib/generated/run-tests16-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests16.html: Added.
- html5lib/generated/run-tests17-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests17.html: Added.
- html5lib/generated/run-tests18-expected.txt: Renamed from LayoutTests/html5lib/run-test18-expected.txt.
- html5lib/generated/run-tests18.html: Added.
- html5lib/generated/run-tests19-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests19.html: Added.
- html5lib/generated/run-tests2-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests2.html: Added.
- html5lib/generated/run-tests20-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests20.html: Added.
- html5lib/generated/run-tests21-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests21.html: Added.
- html5lib/generated/run-tests22-expected.txt: Renamed from LayoutTests/html5lib/run-test10-expected.txt.
- html5lib/generated/run-tests22.html: Added.
- html5lib/generated/run-tests23-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests23.html: Added.
- html5lib/generated/run-tests24-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests24.html: Added.
- html5lib/generated/run-tests25-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests25.html: Added.
- html5lib/generated/run-tests26-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests26.html: Added.
- html5lib/generated/run-tests3-expected.txt: Renamed from LayoutTests/html5lib/run-test14-expected.txt.
- html5lib/generated/run-tests3.html: Added.
- html5lib/generated/run-tests4-expected.txt: Renamed from LayoutTests/html5lib/run-test12-expected.txt.
- html5lib/generated/run-tests4.html: Added.
- html5lib/generated/run-tests5-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests5.html: Added.
- html5lib/generated/run-tests6-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests6.html: Added.
- html5lib/generated/run-tests7-expected.txt: Renamed from LayoutTests/html5lib/run-test1-expected.txt.
- html5lib/generated/run-tests7.html: Added.
- html5lib/generated/run-tests8-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests8.html: Added.
- html5lib/generated/run-tests9-expected.txt: Renamed from LayoutTests/html5lib/run-template-expected.txt.
- html5lib/generated/run-tests9.html: Added.
- html5lib/run-template.html: Removed.
- html5lib/run-test1.html: Removed.
- html5lib/run-test10.html: Removed.
- html5lib/run-test11.html: Removed.
- html5lib/run-test12.html: Removed.
- html5lib/run-test14.html: Removed.
- html5lib/run-test15-expected.txt: Removed.
- html5lib/run-test15.html: Removed.
- html5lib/run-test16-expected.txt: Removed.
- html5lib/run-test16.html: Removed.
- html5lib/run-test17-expected.txt: Removed.
- html5lib/run-test17.html: Removed.
- html5lib/run-test18.html: Removed.
- html5lib/run-test19-expected.txt: Removed.
- html5lib/run-test19.html: Removed.
- html5lib/run-test2-expected.txt: Removed.
- html5lib/run-test2.html: Removed.
- html5lib/run-test20-expected.txt: Removed.
- html5lib/run-test20.html: Removed.
- html5lib/run-test21-expected.txt: Removed.
- html5lib/run-test21.html: Removed.
- html5lib/run-test22-expected.txt: Removed.
- html5lib/run-test22.html: Removed.
- html5lib/run-test23-expected.txt: Removed.
- html5lib/run-test23.html: Removed.
- html5lib/run-test24-expected.txt: Removed.
- html5lib/run-test24.html: Removed.
- html5lib/run-test25-expected.txt: Removed.
- html5lib/run-test25.html: Removed.
- html5lib/run-test26-expected.txt: Removed.
- html5lib/run-test26.html: Removed.
- html5lib/run-test3-expected.txt: Removed.
- html5lib/run-test3.html: Removed.
- html5lib/run-test4-expected.txt: Removed.
- html5lib/run-test4.html: Removed.
- html5lib/run-test5-expected.txt: Removed.
- html5lib/run-test5.html: Removed.
- html5lib/run-test6-expected.txt: Removed.
- html5lib/run-test6.html: Removed.
- html5lib/run-test7.html: Removed.
- html5lib/run-test8-expected.txt: Removed.
- html5lib/run-test8.html: Removed.
- html5lib/run-test9-expected.txt: Removed.
- html5lib/run-test9.html: Removed.
- platform/chromium/TestExpectations:
- platform/chromium/html5lib/generated/run-tests1-expected.txt: Renamed from LayoutTests/platform/chromium/html5lib/run-test7-expected.txt.
- platform/chromium/html5lib/generated/run-tests18-expected.txt: Renamed from LayoutTests/platform/chromium/html5lib/run-test18-expected.txt.
- platform/chromium/html5lib/generated/run-tests7-expected.txt: Renamed from LayoutTests/platform/chromium/html5lib/run-test1-expected.txt.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 2:21 PM Changeset in webkit [143974] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix after r143965.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateOverloadedConstructorCallback):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
- 2:15 PM WebKitGTK/2.0.x edited by
- (diff)
- 2:12 PM Changeset in webkit [143973] by
-
- 2 edits in trunk/Source/WebCore
Build fix for gtk2-based library.
Reviewed by Martin Robinson.
- platform/gtk/WidgetRenderingContext.cpp: move gtk2 check to after the config.h
include, which is the one that includes autotoolsconfig.h, where the gtk2 define
lives.
- 2:06 PM Changeset in webkit [143972] by
-
- 8 edits2 deletes in trunk/Source
Unreviewed, rolling out r143936.
http://trac.webkit.org/changeset/143936
https://bugs.webkit.org/show_bug.cgi?id=110789
Causes webkit_unit_tests failures on android dbg (Requested by
vollick on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-25
Source/WebCore:
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::GIFImageDecoder):
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::decodingHalted):
(WebCore):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::decode):
- platform/image-decoders/gif/GIFImageDecoder.h:
(GIFImageDecoder):
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::doLZW):
(GIFImageReader::read):
- platform/image-decoders/gif/GIFImageReader.h:
(GIFFrameContext):
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext):
(GIFImageReader::GIFImageReader):
(GIFImageReader::~GIFImageReader):
(GIFImageReader):
(GIFImageReader::globalColormap):
(GIFImageReader::globalColormapSize):
Source/WebKit/chromium:
- WebKit.gyp:
- WebKit.gypi:
- tests/GIFImageDecoderTest.cpp: Removed.
- tests/data/broken.gif: Removed.
- 1:48 PM Changeset in webkit [143971] by
-
- 2 edits in tags/Safari-537.31.9/Source/WebKit2
Merged r143829. <rdar://problem/13236883>
- 1:47 PM Changeset in webkit [143970] by
-
- 4 edits in trunk/Source
Unreviewed. VS2010 solution build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props:
- 1:44 PM Changeset in webkit [143969] by
-
- 4 edits in tags/Safari-537.31.9/Source
Versioning.
- 1:40 PM Changeset in webkit [143968] by
-
- 1 copy in tags/Safari-537.31.9
New Tag.
- 1:31 PM Changeset in webkit [143967] by
-
- 11 edits in trunk/Source/WebCore
[V8] Generate a wrapper function for method callbacks
https://bugs.webkit.org/show_bug.cgi?id=110769
Reviewed by Adam Barth.
This is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings. This patch introduces an indirection
function for xxxMethod(), like this:
For non-custom methods
void xxxMethodCallback(...) {
xxxMethod(...);
}
For custom methods
void xxxMethodCallback(...) {
return xxxMethodCustom(...);
}
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateDomainSafeFunctionGetter):
(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateFunctionCallString):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooMethodCallback):
(Float64ArrayV8Internal):
(WebCore::Float64ArrayV8Internal::setMethodCallback):
(WebCore):
(WebCore::ConfigureV8Float64ArrayTemplate):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethodCallback):
(TestActiveDOMObjectV8Internal):
(WebCore::TestActiveDOMObjectV8Internal::postMessageMethodCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionMethodCallback):
(TestCustomNamedGetterV8Internal):
(WebCore):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::itemMethodCallback):
(TestEventTargetV8Internal):
(WebCore::TestEventTargetV8Internal::addEventListenerMethodCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerMethodCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventMethodCallback):
(WebCore):
(WebCore::ConfigureV8TestEventTargetTemplate):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalMethod1MethodCallback):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalMethod2MethodCallback):
(WebCore::TestInterfaceV8Internal::supplementalMethod3MethodCallback):
(WebCore::TestInterfaceV8Internal::supplementalMethod4MethodCallback):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::TestMediaQueryListListenerV8Internal::methodMethodCallback):
(TestMediaQueryListListenerV8Internal):
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::voidMethodMethodCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethodCallback):
(WebCore::TestObjV8Internal::longMethodMethodCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsMethodCallback):
(WebCore::TestObjV8Internal::objMethodMethod):
(WebCore::TestObjV8Internal::objMethodMethodCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsMethodCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgMethodCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceMethodCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethodCallback):
(WebCore::TestObjV8Internal::serializedValueMethodCallback):
(WebCore::TestObjV8Internal::optionsObjectMethodCallback):
(WebCore::TestObjV8Internal::methodWithExceptionMethodCallback):
(WebCore::TestObjV8Internal::customMethodMethodCallback):
(WebCore::TestObjV8Internal::customMethodWithArgsMethodCallback):
(WebCore::TestObjV8Internal::addEventListenerMethodCallback):
(WebCore::TestObjV8Internal::removeEventListenerMethodCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidMethodCallback):
(WebCore::TestObjV8Internal::withScriptStateObjMethodCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionMethodCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionMethodCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextMethodCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateMethodCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionMethodCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesMethodCallback):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackMethodCallback):
(WebCore::TestObjV8Internal::methodWithOptionalArgMethodCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgMethodCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsMethodCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringMethodCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedMethodCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringMethodCallback):
(WebCore::TestObjV8Internal::methodWithCallbackArgMethodCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgMethodCallback):
(WebCore::TestObjV8Internal::methodWithCallbackAndOptionalArgMethodCallback):
(WebCore::TestObjV8Internal::conditionalMethod1MethodCallback):
(WebCore::TestObjV8Internal::conditionalMethod2MethodCallback):
(WebCore::TestObjV8Internal::conditionalMethod3MethodCallback):
(WebCore::TestObjV8Internal::overloadedMethodMethodCallback):
(WebCore::TestObjV8Internal::classMethodMethodCallback):
(WebCore::TestObjV8Internal::classMethodWithOptionalMethodCallback):
(WebCore::TestObjV8Internal::classMethod2MethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod1MethodCallback):
(WebCore::TestObjV8Internal::classMethodWithClampMethodCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1MethodCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2MethodCallback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1MethodCallback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2MethodCallback):
(WebCore::TestObjV8Internal::stringArrayFunctionMethodCallback):
(WebCore::TestObjV8Internal::domStringListFunctionMethodCallback):
(WebCore::TestObjV8Internal::getSVGDocumentMethodCallback):
(WebCore::TestObjV8Internal::convert1MethodCallback):
(WebCore::TestObjV8Internal::convert2MethodCallback):
(WebCore::TestObjV8Internal::convert4MethodCallback):
(WebCore::TestObjV8Internal::convert5MethodCallback):
(WebCore::TestObjV8Internal::mutablePointFunctionMethodCallback):
(WebCore::TestObjV8Internal::immutablePointFunctionMethodCallback):
(WebCore::TestObjV8Internal::orangeMethodCallback):
(WebCore::TestObjV8Internal::strictFunctionMethodCallback):
(WebCore::TestObjV8Internal::variadicStringMethodMethodCallback):
(WebCore::TestObjV8Internal::variadicDoubleMethodMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodMethodCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextPrototypeProperties):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListMethodCallback):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListMethodCallback):
(WebCore):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::funcMethodCallback):
(TestTypedefsV8Internal):
(WebCore::TestTypedefsV8Internal::multiTransferListMethodCallback):
(WebCore::TestTypedefsV8Internal::setShadowMethodCallback):
(WebCore::TestTypedefsV8Internal::methodWithSequenceArgMethodCallback):
(WebCore::TestTypedefsV8Internal::nullableArrayArgMethodCallback):
(WebCore::TestTypedefsV8Internal::funcWithClampMethodCallback):
(WebCore::TestTypedefsV8Internal::immutablePointFunctionMethodCallback):
(WebCore::TestTypedefsV8Internal::stringArrayFunctionMethodCallback):
(WebCore::TestTypedefsV8Internal::stringArrayFunction2MethodCallback):
(WebCore::TestTypedefsV8Internal::methodWithExceptionMethodCallback):
(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):
- 1:29 PM Changeset in webkit [143966] by
-
- 2 edits in trunk/LayoutTests
Remove two stale entries from TestExpectations
Unreviewed patch of test expectations.
- platform/chromium/TestExpectations:
- 1:28 PM Changeset in webkit [143965] by
-
- 11 edits in trunk/Source/WebCore
[V8] Generate a wrapper method for constructor callbacks
https://bugs.webkit.org/show_bug.cgi?id=110765
Reviewed by Adam Barth.
This is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings. This patch introduces an indirection
function for constructor(), like this:
For non-custom constructors
void constructorCallback(...) {
return constructor(...);
}
For custom constructors
void constructorCallback(...) {
return constructorCustom(...);
}
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateConstructorCallback):
(GenerateConstructor):
(GenerateEventConstructor):
(GenerateTypedArrayConstructor):
(GenerateNamedConstructor):
(GenerateConstructorHeader):
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::constructor):
(Float64ArrayV8Internal):
(WebCore::V8Float64Array::constructorCallback):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::TestEventConstructorV8Internal::constructor):
(WebCore):
(WebCore::V8TestEventConstructor::constructorCallback):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::constructor):
(TestInterfaceV8Internal):
(WebCore::V8TestInterface::constructorCallback):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::TestNodeV8Internal::constructor):
(TestNodeV8Internal):
(WebCore::V8TestNode::constructorCallback):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::constructor):
(TestObjV8Internal):
(WebCore::V8TestObj::constructorCallback):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::TestOverloadedConstructorsV8Internal::constructor1):
(WebCore::TestOverloadedConstructorsV8Internal::constructor2):
(WebCore::TestOverloadedConstructorsV8Internal::constructor3):
(WebCore::TestOverloadedConstructorsV8Internal::constructor4):
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
(WebCore):
(WebCore::V8TestOverloadedConstructors::constructorCallback):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::constructor):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::constructor):
(TestTypedefsV8Internal):
(WebCore::V8TestTypedefs::constructorCallback):
- 1:26 PM Changeset in webkit [143964] by
-
- 6 edits in trunk/Source/WebCore
[V8] Generate xxxAttrSetterCallback()
https://bugs.webkit.org/show_bug.cgi?id=110726
Reviewed by Adam Barth.
This is one of steps to insert TRACE_EVENT_STATE() macros into DOM bindings.
This patch introduces an indirection function for xxxAttrSetter(), like this:
For non-custom setters
void xxxAttrSetterCallback(...) {
xxxAttrSetter(...);
}
For custom setters.
void xxxAttrSetterCallback(...) {
return xxxAttrSetterCustom(...);
}
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetterCallback):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetterCallback):
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::staticStringAttrAttrSetterCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::enumAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::shortAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::longAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::longLongAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::stringAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::testObjAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::createAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetterCallback):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetterCallback):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetterCallback):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetterCallback):
(WebCore::TestObjV8Internal::customAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr1AttrSetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr2AttrSetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr3AttrSetterCallback):
(WebCore::TestObjV8Internal::anyAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrSetterCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrSetterCallback):
(WebCore::TestObjV8Internal::enabledPerContextAttr1AttrSetterCallback):
(WebCore::TestObjV8Internal::enabledPerContextAttr2AttrSetterCallback):
(WebCore::TestObjV8Internal::floatArrayAttrSetterCallback):
(WebCore::TestObjV8Internal::doubleArrayAttrSetterCallback):
(WebCore::TestObjV8Internal::mutablePointAttrSetterCallback):
(WebCore::TestObjV8Internal::immutablePointAttrSetterCallback):
(WebCore::TestObjV8Internal::strawberryAttrSetterCallback):
(WebCore::TestObjV8Internal::strictFloatAttrSetterCallback):
(WebCore::TestObjV8Internal::idAttrSetterCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetterCallback):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetterCallback):
(WebCore):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetterCallback):
(TestTypedefsV8Internal):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetterCallback):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrSetterCallback):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrSetterCallback):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrSetterCallback):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrSetterCallback):
(WebCore):
- 1:24 PM Changeset in webkit [143963] by
-
- 16 edits in trunk/LayoutTests
Rebaseline 3 svg/as-image/ tests
Unreviewed rebaseline of test expectations.
- platform/chromium-linux/svg/as-image/animated-svg-as-image-expected.png:
- platform/chromium-linux/svg/as-image/animated-svg-as-image-same-image-expected.png:
- platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac-lion/svg/as-image/animated-svg-as-image-expected.png:
- platform/chromium-mac-lion/svg/as-image/animated-svg-as-image-same-image-expected.png:
- platform/chromium-mac-lion/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png:
- platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-same-image-expected.png:
- platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac/svg/as-image/animated-svg-as-image-expected.png:
- platform/chromium-mac/svg/as-image/animated-svg-as-image-same-image-expected.png:
- platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
- platform/chromium-win/svg/as-image/animated-svg-as-image-same-image-expected.png:
- platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- 1:16 PM Changeset in webkit [143962] by
-
- 8 edits in trunk/Source/WebKit2
PDFPlugin: Tab between text annotations
https://bugs.webkit.org/show_bug.cgi?id=106539
<rdar://problem/12751789>
Reviewed by Darin Adler.
Use [PDFLayerController activateNextAnnotation:] to advance focus when the tab key is hit while inside a PDF form.
Also, a drive-by fix to make the lifetime of PDFPluginAnnotationEventListener's m_annotation pointer more explicit.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add activateNextAnnotation: SPI.
- WebProcess/Plugins/PDF/PDFPlugin.h:
(PDFPlugin): Add focus(Next|Previous)Annotation.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::focusNextAnnotation): Ask PDFLayerController to focus the next annotation.
(WebKit::PDFPlugin::focusPreviousAnnotation): Ask PDFLayerController to focus the next annotation.
- WebProcess/Plugins/PDF/PDFPluginAnnotation.h: Drive-by, initialize m_parent to 0.
(WebKit::PDFPluginAnnotation::PDFPluginAnnotationEventListener::setAnnotation): Added.
- WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
(WebKit::PDFPluginAnnotation::attach): Use eventNames() instead of string literals.
(WebKit::PDFPluginAnnotation::~PDFPluginAnnotation): Clear the event listener's reference to its annotation.
(WebKit::PDFPluginAnnotation::PDFPluginAnnotationEventListener::handleEvent): Null-check the event listener's annotation.
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h:
(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotation): Create our PDFPluginTextAnnotationEventListener.
(PDFPluginTextAnnotationEventListener): Added an event listener (for keydown events in form fields).
(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotationEventListener::create):
(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotationEventListener::setTextAnnotation):
(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotationEventListener::PDFPluginTextAnnotationEventListener):
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::~PDFPluginTextAnnotation): Unregister our keydown event listener.
(WebKit::PDFPluginTextAnnotation::createAnnotationElement): Register our keydown event listener.
(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotationEventListener::handleEvent): Ask PDFPlugin to focus
the next/previous annotation when the tab key is pressed (Shift-Tab goes backwards).
- 1:13 PM Changeset in webkit [143961] by
-
- 2 edits in trunk/Source/WebCore
Build fix for Debug.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::startBackgroundParser):
- 12:58 PM Changeset in webkit [143960] by
-
- 6 edits in trunk/Source/WebCore
6% regression in intl1 page cycler on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=110784
Reviewed by Eric Seidel.
This patch attempts to heal the regression by reverting all the changes
to the preload scanner up to (and including)
http://trac.webkit.org/changeset/143020/.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::resumeFrom):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
- html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::scan):
(WebCore::CSSPreloadScanner::emitRule):
- html/parser/CSSPreloadScanner.h:
(CSSPreloadScanner):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::isStartTag):
(WebCore):
(WebCore::isStartOrEndTag):
(WebCore::TokenPreloadScanner::identifierFor):
(WebCore::TokenPreloadScanner::inititatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::processPossibleTemplateTag):
(WebCore::TokenPreloadScanner::processPossibleStyleTag):
(WebCore::TokenPreloadScanner::processPossibleBaseTag):
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::scan):
- html/parser/HTMLPreloadScanner.h:
(TokenPreloadScanner):
- 12:54 PM Changeset in webkit [143959] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/12976385> Remove rule to silence attempts to create the ~/Library/Caches/com.apple.WebKit2.WebProcessService directory
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb.in: Remove the obsolete rule. We no longer have a "WebProcessService".
- 12:48 PM Changeset in webkit [143958] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG::Edge should have more bits for UseKind, and DFG::Allocator should be simpler
https://bugs.webkit.org/show_bug.cgi?id=110722
Reviewed by Oliver Hunt.
This rolls out the DFG::Allocator part of http://trac.webkit.org/changeset/143654,
and changes Edge to have more room for UseKinds and possibly other things.
This is performance-neutral on both 32-bit and 64-bit. It reduces the size of
DFG::Node on 64-bit (by virtue of getting rid of the 16-byte alignment of Node)
and increases it slightly on 32-bit (by 4 bytes total - 16-byte alignment led to
80 bytes, but the base size of Node plus the 12 bytes of new m_encodedWords in
Edge gets 84 bytes). But, it will mean that we don't have to increase Node by
another 16 bytes if we ever want to add more UseKinds or other things to Edge.
- dfg/DFGAllocator.h:
(DFG):
(Allocator):
(JSC::DFG::Allocator::Region::headerSize):
(JSC::DFG::Allocator::Region::numberOfThingsPerRegion):
(JSC::DFG::Allocator::Region::data):
(JSC::DFG::Allocator::Region::isInThisRegion):
(JSC::DFG::::Allocator):
(JSC::DFG::::~Allocator):
(JSC::DFG::::allocate):
(JSC::DFG::::free):
(JSC::DFG::::freeAll):
(JSC::DFG::::reset):
(JSC::DFG::::indexOf):
(JSC::DFG::::allocatorOf):
(JSC::DFG::::bumpAllocate):
(JSC::DFG::::freeListAllocate):
(JSC::DFG::::allocateSlow):
(JSC::DFG::::freeRegionsStartingAt):
(JSC::DFG::::startBumpingIn):
- dfg/DFGEdge.h:
(JSC::DFG::Edge::Edge):
(Edge):
(JSC::DFG::Edge::node):
(JSC::DFG::Edge::setNode):
(JSC::DFG::Edge::useKindUnchecked):
(JSC::DFG::Edge::setUseKind):
(JSC::DFG::Edge::operator==):
(JSC::DFG::Edge::operator!=):
(JSC::DFG::Edge::makeWord):
- dfg/DFGNodeAllocator.h:
(DFG):
- 12:27 PM Changeset in webkit [143957] by
-
- 2 edits2 copies in branches/chromium/1410
Merge 143640
Stop starting animations when leaving a page
https://bugs.webkit.org/show_bug.cgi?id=110257
Reviewed by Stephen Chenney.
Source/WebCore:
SVGImage::resetAnimation() incorrectly started animations which could cause a crash
when leaving the page. This patch fixes resetAnimation to only stop the animation,
similar to BitmapImage::resetAnimation().
Additionally, this patch removes an unneeded call to Document::updateStyleForAllDocuments()
that was present in the animation loop. This makes the animation code more resistant to
similar bugs in the future.
Both of these changes are functionally covered with existing tests.
Test: svg/animations/reset-animation-crash.html
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::updateAnimations):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::resetAnimation):
LayoutTests:
- svg/animations/reset-animation-crash-expected.html: Added.
- svg/animations/reset-animation-crash.html: Added.
TBR=pdr@google.com
Review URL: https://codereview.chromium.org/12310113
- 12:23 PM Changeset in webkit [143956] by
-
- 12 edits6 copies in branches/chromium/1410
Merge 142765
Replace SVG bitmap cache with directly-rendered SVG
https://bugs.webkit.org/show_bug.cgi?id=106159
Reviewed by Tim Horton.
Source/WebCore:
This patch removes the caching of SVG bitmaps so SVG images are rendered directly. This
enables WebKit to pass the IE Chalkboard demo in 10s on a Z620:
http://ie.microsoft.com/testdrive/Performance/Chalkboard/
On a simple scaled SVG benchmark similar to the IE10 Chalkboard demo
(http://philbit.com/SvgImagePerformance/viewport.html):
without patch: ~20FPS
with patch: ~55FPS
The bitmap SVG image cache had several shortcomings:
- The bitmap cache prevented viewport rendering. (WK104693)
- Bitmap memory usage was high. (WK106484)
- Caching animating images was expensive.
This change removes almost all of the SVGImageCache implementation, replacing it with
directly-rendered SVG. Instead of caching bitmaps, an SVGImageForContainer is cached which
is a thin wrapper around an SVG image with the associated container size and scale.
When rendering patterns (e.g., tiled backgrounds), a temporary bitmap is used for
performance. This change also removes the redraw timer of the old cache, instead relying
on the SVG image to notify clients if the image changes (e.g., during animations).
This patch fixes two existing bugs (WK99481 and WK104189) that were due to caching bitmaps
at a fixed size. A test has been added for each of these bugs.
Tests: svg/as-image/svg-image-scaled.html
svg/as-image/svg-image-viewbox.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::lookupOrCreateImageForRenderer):
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::clear):
(WebCore::CachedImage::changedInRect):
SVG images are no longer special-cased here. When the SVG image changes, users are
notified through this function, and users can then request their content to be redrawn.
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::drawForContainer):
drawForContainer lays out the SVG content for a specific container size and renders it.
The logic is fairly straightforward but a note about the scales and zooms here:
the destination rect parameter is zoomed but not scaled
the source rect parameter is zoomed but not scaled
the context is scaled but not zoomed
SVGImage::draw(...) only accepts a source and destination rect but does not consider
scale or zoom. Therefore, drawForContainer removes the zoom component from the source
so SVGImage::draw(...) will draw from the pre-zoom source to the post-zoom destination.
(WebCore::SVGImage::drawPatternForContainer):
For performance, drawPatternForContainer renders the SVG content onto a bitmap, then
has the bitmap image draw the pattern. This is necessary because drawPattern is used
for tiling.
(WebCore):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::stopAnimation):
(WebCore::SVGImage::resetAnimation):
(WebCore::SVGImage::reportMemoryUsage):
- svg/graphics/SVGImage.h:
(WebCore):
(SVGImage):
- svg/graphics/SVGImageCache.cpp:
Instead of storing a SizeAndScales values for each renderer, a SVGImageForContainer
is stored which is just a thin wrapper around an SVG image that contains container
sizing information. By combining the image and size information, the two maps of
SVGImageCache have been merged into one.
To make this patch easier to review, SVGImageCache still exists and works similar to
how it did before the patch. Now, SVGImageCache simply stores the SVGImageForContainers.
In a followup patch it will be removed.
Note: the redraw timer of SVGImageCache has been removed because animation
invalidation is now properly propagated back to the image clients.
(WebCore):
(WebCore::SVGImageCache::SVGImageCache):
(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::setContainerSizeForRenderer):
(WebCore::SVGImageCache::imageSizeForRenderer):
Previously, this function returned the scaled image size which was incorrect. The image
size is used by clients such as GraphicsContext2D to determine the source size
for drawing the image. draw() accepts zoomed but not scaled values, so this has been
changed.
(WebCore::SVGImageCache::imageForRenderer):
A FIXME has been added here to not set the scale on every lookup. This can be improved
by setting the page scale factor in setContainerSizeForRenderer() in a future patch.
- svg/graphics/SVGImageCache.h:
(WebCore):
(SVGImageCache):
- svg/graphics/SVGImageForContainer.cpp: Added.
(WebCore):
SVGImageForContainer is a thin wrapper around an SVG image. The lifetime of the
SVGImage will be longer than the image cache.
(WebCore::SVGImageForContainer::size):
This is the only logic in SVGImageForContainer. The size returned needs to be zoomed
but not scaled because it is used (e.g., by RenderImage) to pass back into draw() which
takes zoomed but not scaled values.
(WebCore::SVGImageForContainer::draw):
(WebCore::SVGImageForContainer::drawPattern):
- svg/graphics/SVGImageForContainer.h: Added.
(WebCore):
(SVGImageForContainer):
In a future patch SVGImageForContainer can be made immutable but without a refactoring
for not setting the page scale factor in SVGImageCache::lookupOrCreateImageForRenderer,
setters are needed.
(WebCore::SVGImageForContainer::create):
(WebCore::SVGImageForContainer::containerSize):
(WebCore::SVGImageForContainer::pageScale):
(WebCore::SVGImageForContainer::zoom):
(WebCore::SVGImageForContainer::setSize):
(WebCore::SVGImageForContainer::setZoom):
(WebCore::SVGImageForContainer::setPageScale):
(WebCore::SVGImageForContainer::SVGImageForContainer):
(WebCore::SVGImageForContainer::destroyDecodedData):
(WebCore::SVGImageForContainer::decodedSize):
LayoutTests:
This patch fixes two existing bugs (WK99481 and WK104189) that were due to caching bitmaps
at a fixed size. A test has been added for each of these bugs.
- platform/chromium/TestExpectations:
- svg/as-image/svg-image-scaled-expected.html: Added.
- svg/as-image/svg-image-scaled.html: Added.
- svg/as-image/svg-image-viewbox-expected.html: Added.
- svg/as-image/svg-image-viewbox.html: Added.
TBR=pdr@google.com
Review URL: https://codereview.chromium.org/12319101
- 12:23 PM Changeset in webkit [143955] by
-
- 14 edits in trunk/Source/JavaScriptCore
The DFG special case checks for isCreatedThisArgument are fragile
https://bugs.webkit.org/show_bug.cgi?id=110535
Reviewed by Oliver Hunt.
There may be many situations in which we want to force a variable to never be
unboxed. Capturing is one such case, and the created this argument is another.
Previously all code that dealt with this issue had to query both scenarios.
Now DFG::VariableAccessData knows these things. You just have to ask
VariableAccessData for whether a variable should be unboxed. Anyone wishing to
force a variable to never be unboxed just tells VariableAccessData.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(DFG):
- dfg/DFGCFGSimplificationPhase.cpp:
(CFGSimplificationPhase):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.h:
(Graph):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGUnificationPhase.cpp:
(JSC::DFG::UnificationPhase::run):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsCaptured):
(JSC::DFG::VariableAccessData::mergeShouldNeverUnbox):
(VariableAccessData):
(JSC::DFG::VariableAccessData::shouldNeverUnbox):
(JSC::DFG::VariableAccessData::shouldUnboxIfPossible):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):
- 11:50 AM FeatureFlags edited by
- CSS_REGIONS - see r88148 (diff)
- 11:36 AM Changeset in webkit [143954] by
-
- 2 edits in trunk/Source/WebCore
Changed DatabaseTracker::getMaxSizeForDatabase() to return the previous
database size instead of 0 when the quota limit has been reached.
https://bugs.webkit.org/show_bug.cgi?id=110557.
Reviewed by Geoffrey Garen.
Testing of concurrent multi-process consumption of database quota shows that
returning a value of 0 when the quota is exceeded still allows some databases
to run away with unbounded growth. However, if getMaxSizeForDatabase() returns
the existing database size, the underlying sqlite3 database will successfully
reject new growth.
The value returned by DatabaseTracker::getMaxSizeForDatabase() is used to set
the SQLite3 database size using a sql command "PRAGMA max_page_count = <size>".
The SQLite3 documentation on this pragma says, "The maximum page count cannot
be reduced below the current database size."
It is undefined what setting it to a reduced size will do. So, we're changing
getMaxSizeForDatabase() to return the existing size instead.
No new tests.
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
- 11:29 AM Changeset in webkit [143953] by
-
- 2 edits in trunk/Tools
Fix python unit tests after yoli's email address update in http://trac.webkit.org/changeset/143922
https://bugs.webkit.org/show_bug.cgi?id=110775
Unreviewed, basically a rebaseline.
- Scripts/webkitpy/common/config/watchlist:
- 11:28 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:27 AM Changeset in webkit [143952] by
-
- 3 edits3 adds in releases/WebKitGTK/webkit-2.0
Merge r143931 - [soup] "Too many redirects" error loading chat in plus.google.com
https://bugs.webkit.org/show_bug.cgi?id=64575
Reviewed by Martin Robinson.
Source/WebCore:
Set the firstPartyForCookies for the new request on redirects to
the URL used for redirection.
Test: http/tests/cookies/set-cookie-on-redirect.html
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::doRedirect):
LayoutTests:
This new test checks firstPartyForCookies is properly set to the
new URL on redirects.
- http/tests/cookies/resources/set-cookie-on-redirect.php: Added.
- http/tests/cookies/set-cookie-on-redirect-expected.txt: Added.
- http/tests/cookies/set-cookie-on-redirect.html: Added.
- 11:23 AM Changeset in webkit [143951] by
-
- 2 edits in trunk/Tools
[chromium] Try to get the webkit builder to use msvs again
https://bugs.webkit.org/show_bug.cgi?id=110771
Reviewed by Eric Seidel.
The msvs gyp generator apparently doesn't write the sln file on every
run, so check the vcxproj file instead.
- Scripts/webkitdirs.pm:
(determineIsChromiumNinja):
- 11:14 AM Changeset in webkit [143950] by
-
- 3 edits in trunk/Source/WebCore
Refactor logic for relaying out children out of RenderBlock::styleDidChange
https://bugs.webkit.org/show_bug.cgi?id=110661
Reviewed by David Hyatt.
Instead of having styleDidChange need to know which children to mark as needing layout,
use a bool to keep track of border and padding width changes so at layout time, we know
we need to set relayoutChildren=true.
We steal a bit from m_lineHeight reducing the possible line height from around 500 million pixels
to 250 million pixels.
No new tests, this should be covered by fast/block/positioning/border-change-relayout-test.html and
fast/block/dynamic-padding-border.html.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock): Fix indent and initialize m_hasBorderOrPaddingLogicalWidthChanged.
(WebCore::RenderBlock::styleDidChange): Remove logic for setting children as needing layout.
(WebCore::RenderBlock::updateLogicalWidthAndColumnWidth): Return true if border or padding width changed.
- rendering/RenderBlock.h:
(RenderBlock): Steal a bit from m_lineHeight and give it to m_hasBorderOrPaddingLogicalWidthChanged.
- 10:56 AM Changeset in webkit [143949] by
-
- 3 edits in trunk/Source/JavaScriptCore
Do one lookup per code cache insertion instead of two
https://bugs.webkit.org/show_bug.cgi?id=110674
Reviewed by Sam Weinig.
Deployed the idiomatic "add null value" trick to avoid a second hash
lookup when inserting an item.
- runtime/CodeCache.cpp:
(JSC::CodeCacheMap::pruneSlowCase): Factored this into a helper function
to improve clarity and get some code off the hot path.
(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode): Use the add() API
to avoid two hash lookups. Be sure to remove items if parsing fails,
otherwise we'll leave nulls in the table. (I'm guessing that caching parse
errors is not a win.)
- runtime/CodeCache.h:
(JSC::SourceCodeValue::SourceCodeValue):
(CodeCacheMap):
(JSC::CodeCacheMap::add): Combined find() and set() into add().
(JSC::CodeCacheMap::remove):
(JSC::CodeCacheMap::age):
(JSC::CodeCacheMap::prune): Refactored to support above changes.
- 10:56 AM Changeset in webkit [143948] by
-
- 5 edits in trunk
transition-property property doesn't accept "all, <IDENT>".
https://bugs.webkit.org/show_bug.cgi?id=110074
Reviewed by Dean Jackson.
Source/WebCore:
http://dev.w3.org/csswg/css3-transitions/#transition-property-property
allows all, <IDENT> as a value for the transition-property property. In
fact thanks to http://trac.webkit.org/changeset/143019 we correctly
implemented that behavior for transition shorthand property while
fixing bugs on the previous implementation. We did introduce a
AnimationParseContext to track whether the parsing of the
transition-property was finished or not in relation to the keyword.
This patch extend that mechanism to the longhand by renaming the
boolean and the functions to use it in the context class and set it
correctly while parsing the longhand property.
Test: LayoutTests/transitions/transitions-parsing.html
- css/CSSParser.cpp:
(WebCore::AnimationParseContext::AnimationParseContext):
(WebCore::AnimationParseContext::commitAnimationPropertyKeyword):
(WebCore::AnimationParseContext::animationPropertyKeywordAllowed):
(AnimationParseContext):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseAnimationProperty): We can remove the
condition inShorthand() here, if 'none' is parsed then no more keyword
can appear, if 'all' is parsed then we can continue the parsing but
invalidate the property if another keyword is encountered. These
conditions are valid for the shorthand and the longhand.
LayoutTests:
Extend exising test to cover the bug.
- transitions/transitions-parsing-expected.txt:
- transitions/transitions-parsing.html:
- 10:39 AM Changeset in webkit [143947] by
-
- 3 edits in trunk/Source/WebCore
[Texmap] LayoutTests/compositing/animation/state-at-end-event-transform-layer.html shows a red square where it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=110685
Patch by No'am Rosenthal <Noam Rosenthal> on 2013-02-25
Reviewed by Martin Robinson.
Removed m_shouldUpdateCurrentTransformFromGraphicsLayer etc., as they don't do
what they're supposed to do. No flickers observed.
LayoutTests/compositing/animation/state-at-end-event-transform-layer.html now works correctly.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::setAnimatedTransform):
(WebCore::TextureMapperLayer::setAnimatedOpacity):
(WebCore::TextureMapperLayer::setAnimatedFilters):
(WebCore::TextureMapperLayer::syncAnimations):
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore::TextureMapperLayer::TextureMapperLayer):
(TextureMapperLayer):
- 10:27 AM Changeset in webkit [143946] by
-
- 2 edits in trunk/Tools
[chromium] try to unbreak run-chromium-webkit-unit-tests on the mac bots
https://bugs.webkit.org/show_bug.cgi?id=110767
Reviewed by Eric Seidel.
The tester runs gyp, which generates out/Release/build.ninja. The bot
scripts use existence (and timestamp) of that file to decide if the
current build is supposed to be ninja or xcodebuild. The file exists,
so the snapshot is extracted to out/Release. The snapshot doesn't
contain build.ninja however due to
http://trac.webkit.org/changeset/140375 , so after extracting the
snapshot the scripts think that this is an xcodebuild build. So remove
the part of that revision that removed ninja files from the archive,
and the bots should be happy again.
- BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
- 10:24 AM Changeset in webkit [143945] by
-
- 6 edits in trunk/Source/WebCore
AVFoundation.framework and QTKit.framework are lazy-loaded on every WebProcess launch
https://bugs.webkit.org/show_bug.cgi?id=110725
Reviewed by Eric Carlson.
When settings are changed, do not re-query the media engines (which causes their respective
frameworks to load). Instead, merely clear any previously loaded media engines so that
the media engine list will be re-queried the next time installedMediaEngines() is called.
(WebCore::MediaPlayer::resetMediaEngines): Renamed from requeryMediaEngines.
- platform/graphics/MediaPlayer.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::resetMediaEngines): Ditto.
- html/HTMLMediaElement.h:
- page/Settings.cpp:
(WebCore::Settings::setAVFoundationEnabled): Call renamed method.
(WebCore::Settings::setQTKitEnabled): Ditto.
- platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Only clear out previously queried engines.
- 10:21 AM Changeset in webkit [143944] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the Windows gyp build after r143937
- WebCore.gypi: Update the filename in the source list.
- 10:13 AM Changeset in webkit [143943] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Add isInputMode() method to WebPage class.
https://bugs.webkit.org/show_bug.cgi?id=110754
Patch by Yongxin Dai <yodai@rim.com> on 2013-02-25
Reviewed by Rob Buis.
PR #262569.
There is a case we need to know if the active node is content editable
from TouchHandlerWebKitThread class. WebPage::isInputMode() just delegates
InputHandler::isInputMode().
Reviewed Internally by Mike Fenton.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::isInputMode):
(WebKit):
- Api/WebPage.h:
- 10:10 AM Changeset in webkit [143942] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Force form submission when implicit submission fails.
https://bugs.webkit.org/show_bug.cgi?id=110627
Reviewed by Rob Buis.
PR 286023.
When implicit form submission does not submit the form
do a direct submission of the form.
Reviewed Internally by Nima Ghanavatian.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::updateFormState):
- 10:08 AM Changeset in webkit [143941] by
-
- 8 edits in trunk/Source/WebCore
[CSS Grid Layout] Refactor RenderStyle's grid position storage in preparation to supporting spanning
https://bugs.webkit.org/show_bug.cgi?id=110651
Reviewed by Ojan Vafai.
The current code stores grid-{row|column} as a single GridPosition value. While this works well currently,
we want to be able to handle 2 GridPosition as this enables row / column spanning.
That's what this refactoring achieves: it replaces the internal storage by a GridPositions that contains a
single GridPosition for now. The rest is mechanical updates.
Refactoring covered by existing tests.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridPositions):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Added the simple wrapper valueForGridPositions and updated the rest of the code.
- css/StyleResolver.cpp:
(WebCore::createGridPositions):
(WebCore::StyleResolver::applyProperty):
Ditto with createGridPositions.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::autoPlacementMajorAxisPositionsForChild):
(WebCore::RenderGrid::autoPlacementMinorAxisPositionsForChild):
Updated the code after adding the indirection: s/GridPosition/GridPositions/ and
use the firstPosition helper.
- rendering/RenderGrid.h:
- rendering/style/GridPosition.h:
(WebCore::GridPositions::GridPositions):
(WebCore::GridPositions::firstPosition):
(WebCore::GridPositions::operator==):
Added this class to add the indirection. For now, it only wraps the single GridPosition.
- rendering/style/RenderStyle.h:
- rendering/style/StyleGridItemData.h:
Updated to store / take / return a GridPositions.
- 10:02 AM Changeset in webkit [143940] by
-
- 13 edits in trunk/Source/WebCore
Revert r143840 because it caused flaky crashes.
https://bugs.webkit.org/show_bug.cgi?id=110766
- 9:57 AM Changeset in webkit [143939] by
-
- 4 edits in trunk/Source/WebCore
Remove an obsolete workaround for relaxing 3rd party cookie policy
https://bugs.webkit.org/show_bug.cgi?id=110664
Reviewed by Benjamin Poulain.
Removed shouldRelaxThirdPartyCookiePolicy(). This workaround is no longer needed,
because CFNetwork performs the same check starting with 10.6.8.
Also, the workaround was not quite correct and harmful for performance, as it
was always changing main document URL to an untrue value, which caused ResourceRequest
regeneration.
- platform/network/ResourceHandle.h:
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
- 9:47 AM Changeset in webkit [143938] by
-
- 3 edits in trunk/Source/WebCore
WebInspector: Do not keep track of resources unless they have a valid loader identifier.
https://bugs.webkit.org/show_bug.cgi?id=110761
Reviewed by Pavel Feldman.
- inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceType):
(WebCore::NetworkResourcesData::resourceType):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::addCachedResource):
(WebCore::NetworkResourcesData::addResourceSharedBuffer):
(WebCore::NetworkResourcesData::data):
(WebCore::NetworkResourcesData::xhrReplayData):
(WebCore::NetworkResourcesData::setXHRReplayData):
(WebCore::NetworkResourcesData::reuseXHRReplayData):
(WebCore::NetworkResourcesData::resourceDataForRequestId):
(WebCore::NetworkResourcesData::ensureNoDataForRequestId):
(WebCore::NetworkResourcesData::ensureFreeSpace):
- inspector/NetworkResourcesData.h:
(NetworkResourcesData):
- 9:30 AM Changeset in webkit [143937] by
-
- 4 edits1 move1 add in trunk/Source/WebCore
[EFL][GTK] Move text selection/focus notification for a11y from gtk to atk directory
https://bugs.webkit.org/show_bug.cgi?id=110221
Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2013-02-25
Reviewed by Martin Robinson.
Share implementation between efl and gtk.
Update build with changes made.
- GNUmakefile.list.am: Change WebCore/editing/gtk/FrameSelectionGtk.cpp to WebCore/editing/atk/FrameSelectionAtk.cpp to build.
- PlatformEfl.cmake: Add WebCore/editing/atk to include directories, add Webcore/editing/atk/FrameSelectionAtk.cpp to build.
- editing/FrameSelection.h: Omit notifyAccessibilityForSelectionChange() stub for EFL port.
(WebCore):
- editing/atk/FrameSelectionAtk.cpp: Renamed from Source/WebCore/editing/gtk/FrameSelectionGtk.cpp.
(WebCore):
(WebCore::emitTextSelectionChange):
(WebCore::maybeEmitTextFocusChange):
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
- 9:27 AM Changeset in webkit [143936] by
-
- 8 edits2 adds in trunk/Source
GIFImageReader to read from source data directly
https://bugs.webkit.org/show_bug.cgi?id=109662
Reviewed by Stephen White.
Source/WebCore:
This is the first patch to improve GIF image decoding.
GIFImageReader has an internal 256 bytes buffer to saving incoming
bytes. This mechanism is out-dated because WebKit holds the entire
file in memory and it is not necessary to hold data in an intermediate
buffer.
This is also a blocker for later work to parse and decode GIF
incrementally.
This change removed the imtermediate 'hold' buffer and uses an index
for data position to keep track of parsing of the GIF file. Buffer for
global colormap and local colormap are also removed because they can be
referenced from the data stream.
This change is tested by:
Layout tests
All tests passed under fast/images.
Unit tests
Added GIFImageDecoderTest for Chromium.
Local testing
I tested this implementation against a set of 50k GIF images and
there's no crashes and produces bit-exact results as previous code.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::decode):
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::doLZW):
(GIFImageReader::decode):
(GIFImageReader::decodeInternal):
(GIFImageReader::setRemainingBytes):
- platform/image-decoders/gif/GIFImageReader.h:
(GIFFrameContext):
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext):
(GIFImageReader::GIFImageReader):
(GIFImageReader::~GIFImageReader):
(GIFImageReader::setData):
(GIFImageReader):
(GIFImageReader::globalColormap):
(GIFImageReader::localColormap):
(GIFImageReader::localColormapSize):
(GIFImageReader::data):
(GIFImageReader::colormap):
Source/WebKit/chromium:
Added the following unit tests to test new logic in GIFImageDecoder:
GIFImageDecoderTest.decodeTwoFrames
Test that it can decode a multi-frame GIF image correctly.
GIFImageDecoderTest.parseAndDecode
First perform a parse operation and then a decode operation. Expect
that parse and decode operates correctly.
GIFImageDecoderTest.parseByteByByte
Test that multi-frame GIF image can be parsed correctly byte by byte.
GIFImageDecoderTest.parseAndDecodeByteByByte
Run a loop to feed decoder byte by byte, perform a parse and then
decode operation and make sure frames are decoded correctly.
GIFImageDecoderTest.brokenSecondFrame
Decode a GIF image with second frame broken. Expect that the first
frame can be decoded correctly.
- WebKit.gyp:
- WebKit.gypi:
- tests/GIFImageDecoderTest.cpp: Added.
(WebKit):
(WebKit::readFile):
(WebKit::TEST):
- tests/data/broken.gif: Added.
- 9:14 AM Changeset in webkit [143935] by
-
- 7 edits in trunk/Source/WebKit2
[Qt][WK2] Remove unneeded method didResumeContent from PageViewportController clients
https://bugs.webkit.org/show_bug.cgi?id=110751
Reviewed by Jocelyn Turcotte.
This is a clean-up in the PageViewportController clients that removes leftover
code from previous design that is partially unused and unnecessary, to simplify
the interaction between PageViewportController and clients.
- UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::resumeContent):
- UIProcess/PageViewportControllerClient.h:
(PageViewportControllerClient):
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
- UIProcess/efl/PageViewportControllerClientEfl.h:
(PageViewportControllerClientEfl):
- UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::flickMoveEnded):
(WebKit::PageViewportControllerClientQt::resumeAndUpdateContent):
(WebKit::PageViewportControllerClientQt::pinchGestureCancelled):
- UIProcess/qt/PageViewportControllerClientQt.h:
(PageViewportControllerClientQt):
- 9:05 AM Changeset in webkit [143934] by
-
- 20 edits2 copies in branches/chromium/1410
Merge 143356
Text Autosizing: prevent oscillation of font sizes during autosizing
https://bugs.webkit.org/show_bug.cgi?id=108205
Patch by Tim Volodine <timvolodine@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
On some websites autosized font-sizes oscillate due to layouts caused by
hovering or incremental page loading (and on other sites font sizes do
eventually stabilize, but it takes many layouts before they reach a steady
size). To prevent all these cases, we no longer allow the autosizing
multiplier to change after it has been set (to a value other than 1).
This won't always give exactly the same results, but testing on 2000 top
sites shows that this makes little difference in practice, and it prevents
these very jarring cases. As a happy side-effect, this speeds up layouts
as font sizes change less.
Test: fast/text-autosizing/oscillation-javascript-fontsize-change.html
- page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
- page/Settings.cpp:
(WebCore::Settings::setTextAutosizingFontScaleFactor):
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::recalculateMultipliers):
(WebCore):
(WebCore::TextAutosizer::processContainer):
- rendering/TextAutosizer.h:
(TextAutosizer):
LayoutTests:
Added overflow-y:hidden to some existing tests, since previously those tests
would start off with incorrect multipliers (because mainFrame->view()-layoutSize()
is initially 785 instead of 800 as ScrollView wrongly guesses a scrollbar will
be needed), and then the multipliers would get corrected on a subsequent layout.
Now that we don't allow the multiplier to change after being set, it needs to be
right first time.
Also added specific oscillation test triggered by javascript.
- fast/text-autosizing/constrained-height-body-expected.html:
- fast/text-autosizing/constrained-height-body.html:
- fast/text-autosizing/constrained-then-float-ancestors-expected.html:
- fast/text-autosizing/constrained-then-float-ancestors.html:
- fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html:
- fast/text-autosizing/constrained-then-position-fixed-ancestors.html:
- fast/text-autosizing/nested-em-line-height-expected.html:
- fast/text-autosizing/nested-em-line-height.html:
- fast/text-autosizing/oscillation-javascript-fontsize-change-expected.html: Added.
- fast/text-autosizing/oscillation-javascript-fontsize-change.html: Added.
- fast/text-autosizing/simple-paragraph-expected.html:
- fast/text-autosizing/simple-paragraph.html:
- fast/text-autosizing/span-child-expected.html:
- fast/text-autosizing/span-child.html:
- fast/text-autosizing/unwrappable-blocks-expected.html:
- fast/text-autosizing/unwrappable-blocks.html:
- fast/text-autosizing/unwrappable-inlines-expected.html:
- fast/text-autosizing/unwrappable-inlines.html:
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12310107
- 8:59 AM Changeset in webkit [143933] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry]Adjust fatfinger detection rect size.
https://bugs.webkit.org/show_bug.cgi?id=108678
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-02-25
Reviewed by Rob Buis.
Fix a typo in function names.
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::getNodesFromRect):
- 8:56 AM Changeset in webkit [143932] by
-
- 4 edits in branches/chromium/1410
Merge 143318
[Text Autosizing] Combine narrow descendants of a cluster into groups that should be autosized with the same multiplier.
https://bugs.webkit.org/show_bug.cgi?id=109825
Source/WebCore:
Enhancement of the approach introduced in https://bugs.webkit.org/show_bug.cgi?id=109573.
Instead of using the same text size multiplier for all narrow descendants of any autosizing
cluster, group the descendants by how much narrower they are than the cluster's
|blockContainingAllText| and process each group separately with a different multiplier for
each one.
For example, we want nested comments on the page to be autosized as a group but separately
from a sidebar on the same page.
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.
Updated the existing test to verify the patch.
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processClusterInternal):
Splits the narrow descendants of the autosizing cluster into groups before processing
each group individually.
(WebCore::TextAutosizer::getNarrowDescendantsGroupedByWidth):
Sorts the narrow descendants of the given cluster into groups, combining them by the
difference between their content widths. If sorted by width, two consecutive nodes
belong to the same group if their width difference is no greater than 100 CSS units.
- rendering/TextAutosizer.h:
New method definitions.
LayoutTests:
Verify that narrow descendants are grouped and autosized separately according to the
difference between the descendant's width and the width of its enclosing cluster's
|blockContainingAllText|.
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.
- fast/text-autosizing/narrow-descendants-combined-expected.html:
- fast/text-autosizing/narrow-descendants-combined.html:
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12317102
- 8:56 AM Changeset in webkit [143931] by
-
- 3 edits3 adds in trunk
[soup] "Too many redirects" error loading chat in plus.google.com
https://bugs.webkit.org/show_bug.cgi?id=64575
Reviewed by Martin Robinson.
Source/WebCore:
Set the firstPartyForCookies for the new request on redirects to
the URL used for redirection.
Test: http/tests/cookies/set-cookie-on-redirect.html
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::doRedirect):
LayoutTests:
This new test checks firstPartyForCookies is properly set to the
new URL on redirects.
- http/tests/cookies/resources/set-cookie-on-redirect.php: Added.
- http/tests/cookies/set-cookie-on-redirect-expected.txt: Added.
- http/tests/cookies/set-cookie-on-redirect.html: Added.
- 8:52 AM Changeset in webkit [143930] by
-
- 2 edits2 copies in branches/chromium/1410
Merge 142866
[Text Autosizing] Process narrow descendants with the same multiplier for the font size.
https://bugs.webkit.org/show_bug.cgi?id=109573
Source/WebCore:
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-14
Reviewed by Julien Chaffraix.
Combine narrow descendants of the same autosizing cluster into a group that is autosized
with the same multiplier.
For example, on sites with a sidebar, sometimes the paragraphs next to the sidebar will have
a large margin individually applied (via a CSS selector), causing them all to individually
appear narrower than their enclosing blockContainingAllText. Rather than making each of
these paragraphs into a separate cluster, we want them all to share the same multiplier, as
if they were a single cluster.
Test: fast/text-autosizing/narrow-descendants-combined.html
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processClusterInternal):
Common implementation for processCluster() and processCompositeCluster that accepts the
text width and whether the cluster should be autosized as parameters instead of
calculating it inline.
(WebCore::TextAutosizer::processCluster):
Calculates the text width for a single cluster and whether it should be autosized, then
calls processClusterInternal() to apply the multiplier and process the cluster's
descendants.
(WebCore::TextAutosizer::processCompositeCluster):
Calculates the text width for a group of renderers and if the group should be autosized,
then calls processClusterInternal() repeatedly with the same multiplier to apply it and
process all the descendants of the group.
(WebCore::TextAutosizer::clusterShouldBeAutosized):
Calls the multiple renderers version to avoid code duplication.
(WebCore::TextAutosizer::compositeClusterShouldBeAutosized):
The multiple renderers version of clusterShouldBeAutosized.
- rendering/TextAutosizer.h:
Updated method declarations.
LayoutTests:
Test to verify that all narrow descendants of a cluster are autosized with the same
multiplier.
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-14
Reviewed by Julien Chaffraix.
- fast/text-autosizing/narrow-descendants-combined-expected.html: Added.
- fast/text-autosizing/narrow-descendants-combined.html: Added.
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12326104
- 8:51 AM Changeset in webkit [143929] by
-
- 2 edits in trunk/Tools
Fix tests after r143910
https://bugs.webkit.org/show_bug.cgi?id=110757
Reviewed by Andreas Kling.
While here, also add a test for the bug r143910 fixed.
- Scripts/webkitpy/common/system/executive_unittest.py:
(ScriptErrorTest.test_message_with_output):
(ScriptErrorTest):
(ScriptErrorTest.test_message_with_tuple):
- 8:46 AM Changeset in webkit [143928] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/rendering/TextAutosizer.cpp
Merge 142534
[Text Autosizing] Collect narrow descendants and process them separately. Refactoring for
a change to follow.
https://bugs.webkit.org/show_bug.cgi?id=109054
Preparational change to combine narrow descendants of the same autosizing cluster into
groups by the width difference between the descendant and the block containing all text of
the parent autosizing cluster. The groups will be autosized with the same multiplier.
For example, on sites with a sidebar, sometimes the paragraphs next to the sidebar will have
a large margin individually applied (via a CSS selector), causing them all to individually
appear narrower than their enclosing blockContainingAllText. Rather than making each of
these paragraphs into a separate cluster, we eventually want to be able to merge them back
together into one (or a few) descendant clusters.
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-11
Reviewed by Julien Chaffraix.
No behavioral changes thus no new tests or test changes.
- rendering/TextAutosizer.cpp:
(TextAutosizingClusterInfo): Vector of narrow descendants.
(WebCore::TextAutosizer::processCluster): Process narrow descendants separately.
(WebCore::TextAutosizer::processContainer):
Remember narrow descendants of the parent cluster for later processing.
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12315083
- 8:09 AM Changeset in webkit [143927] by
-
- 2 edits in trunk/Tools
[chromium] Apparently built-product-archive is written in Python, not Perl :-/
https://bugs.webkit.org/show_bug.cgi?id=110755
Reviewed by Jochen Eisinger.
- BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
(extractBuiltProduct):
- 7:51 AM WebKitGTK/2.0.x edited by
- (diff)
- 7:50 AM WebKitGTK/2.0.x edited by
- (diff)
- 7:49 AM Changeset in webkit [143926] by
-
- 52 edits in trunk/Source
Reduce amount of code that includes StylePropertySet.h
<http://webkit.org/b/101149>
Reviewed by Antti Koivisto.
Source/WebCore:
StylePropertySet.h and dependents were getting included by the majority of WebKit
through either StyledElement.h or CSSStyleDeclaration.h. This change removes those includes
and moves inclusion to .cpp files instead. After this change, it's possible to hack most
of WebCore/css/ and rebuild <100 files instead of >1000.
The only real code change in here is changing CSSStyleDeclaration::cssPropertyMatches()
to take a CSSPropertyID/CSSValue* combo instead of a StylePropertySet::Reference.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
- css/CSSComputedStyleDeclaration.h:
(CSSComputedStyleDeclaration):
- css/CSSStyleDeclaration.h:
(CSSStyleDeclaration):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):
- css/PropertySetCSSStyleDeclaration.h:
- css/SelectorChecker.h:
- css/SelectorCheckerFastPath.cpp:
- css/SelectorFilter.cpp:
- css/SelectorFilter.h:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::propertyMatches):
(WebCore::StylePropertySet::removeEquivalentProperties):
- css/StylePropertySet.h:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::MatchedProperties::MatchedProperties):
(WebCore::StyleResolver::MatchedProperties::~MatchedProperties):
- css/StyleResolver.h:
(MatchedProperties):
- css/StyleRule.cpp:
- css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::~ViewportStyleResolver):
- css/ViewportStyleResolver.h:
(ViewportStyleResolver):
- css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::StyleKeyframe):
(WebCore::StyleKeyframe::~StyleKeyframe):
- css/WebKitCSSKeyframeRule.h:
(StyleKeyframe):
- dom/Attr.cpp:
- dom/Document.cpp:
- dom/Element.cpp:
- dom/StyledElement.cpp:
(WebCore::StyledElement::addPropertyToPresentationAttributeStyle):
- dom/StyledElement.h:
(StyledElement):
- editing/FrameSelection.cpp:
- editing/RemoveCSSPropertyCommand.cpp:
(WebCore::RemoveCSSPropertyCommand::~RemoveCSSPropertyCommand):
- editing/RemoveCSSPropertyCommand.h:
(RemoveCSSPropertyCommand):
- editing/RemoveFormatCommand.cpp:
- html/HTMLBodyElement.cpp:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::addHTMLLengthToStyle):
(WebCore::HTMLElement::addHTMLColorToStyle):
- html/HTMLElement.h:
(HTMLElement):
- html/HTMLFontElement.cpp:
- html/HTMLHRElement.cpp:
- html/HTMLPreElement.cpp:
- html/HTMLTableElement.cpp:
- html/HTMLTablePartElement.cpp:
- html/canvas/CanvasStyle.cpp:
- html/shadow/MediaControlElementTypes.cpp:
- inspector/InspectorStyleSheet.cpp:
- page/PageSerializer.cpp:
- rendering/RenderTableCell.cpp:
- svg/SVGAnimateElement.cpp:
- svg/SVGElementRareData.h:
- svg/SVGFontFaceElement.cpp:
Source/WebKit/gtk:
- WebCoreSupport/EditorClientGtk.cpp:
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.mm:
- WebView/WebFrame.mm:
- WebView/WebView.mm:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
- 7:46 AM Changeset in webkit [143925] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip asserting tests.
https://bugs.webkit.org/show_bug.cgi?id=110756
- platform/qt/TestExpectations:
- 7:42 AM Changeset in webkit [143924] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r143895.
http://trac.webkit.org/changeset/143895
https://bugs.webkit.org/show_bug.cgi?id=110758
broke a bunch of tests (Requested by thakis on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-25
- Scripts/update-webkit-chromium:
- 7:22 AM Changeset in webkit [143923] by
-
- 3 edits2 adds in trunk
Web Inspector: Remove CPU profile from a group causes exception
https://bugs.webkit.org/show_bug.cgi?id=110466
Patch by Alexei Filippov <alph@chromium.org> on 2013-02-25
Reviewed by Yury Semikhatsky.
WebInspector.ProfilesPanel._removeProfileHandle did not handle
profile removal from a group. The fix takes care of this case.
Test: inspector/profiler/cpu-profiler-profile-removal.html
Source/WebCore:
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
LayoutTests:
- inspector/profiler/cpu-profiler-profile-removal-expected.txt: Added.
- inspector/profiler/cpu-profiler-profile-removal.html: Added.
- 7:15 AM Changeset in webkit [143922] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Unreviewed. Edit my personal info.
- Scripts/webkitpy/common/config/committers.py:
- 7:10 AM Changeset in webkit [143921] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed follow-up to r143725, reduce chances test flakes on a slow box.
- src/js/Tests.js:
(.TestSuite.prototype.testPageOverlayUpdate.step2):
- 6:53 AM Changeset in webkit [143920] by
-
- 3 edits1 copy1 move40 adds13 deletes in trunk/LayoutTests
XSSAuditor tests shouldn't depend on IFrames's load order.
https://bugs.webkit.org/show_bug.cgi?id=110737
Reviewed by Jochen Eisinger.
Various tests under http/tests/security/xssAuditor actually wrap up
multiple test cases under a single HTML file by loading a variety of
IFrames. Currently, the error messages that these tests expect aren't
detailed enough to distinguish between the order in which the IFrames
load: they all generate the same error, so the ordering is irrelevant.
Before we increase the error message detail in webkit.org/b/110733, we
need to ensure that these tests don't rely on load order. One option
is to serialize the IFrame loading by chaining onload events, but that
seems like a slow way of doing things. This patch takes a different
approach, breaking the multiple-IFrame tests into many single-IFrame
tests (which should be more shardable, and actually execute more quickly
in the long run).
- http/tests/security/xssAuditor/open-iframe-src-expected.txt: Removed.
- http/tests/security/xssAuditor/open-iframe-src.html: Removed.
- http/tests/security/xssAuditor/open-script-src-expected.txt: Removed.
- http/tests/security/xssAuditor/open-script-src.html: Removed.
- http/tests/security/xssAuditor/property-escape-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/property-escape-comment.html: Removed.
- http/tests/security/xssAuditor/property-escape-entity-expected.txt: Removed.
- http/tests/security/xssAuditor/property-escape-entity.html: Removed.
- http/tests/security/xssAuditor/property-escape-quote-expected.txt: Removed.
- http/tests/security/xssAuditor/property-escape-quote.html: Removed.
- http/tests/security/xssAuditor/script-tag-with-comma-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-with-comma.html: Removed.
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-with-source-unterminated.html: Removed.
Removed these tests, breaking them into multiple single-IFrame HTML files.
- http/tests/security/xssAuditor/open-iframe-src-01.html: Added.
- http/tests/security/xssAuditor/open-iframe-src-02.html: Added.
- http/tests/security/xssAuditor/open-script-src-01-expected.txt: Added.
- http/tests/security/xssAuditor/open-script-src-01.html: Added.
- http/tests/security/xssAuditor/open-script-src-02-expected.txt: Added.
- http/tests/security/xssAuditor/open-script-src-02.html: Added.
- http/tests/security/xssAuditor/open-script-src-03-expected.txt: Added.
- http/tests/security/xssAuditor/open-script-src-03.html: Added.
- http/tests/security/xssAuditor/open-script-src-04-expected.txt: Added.
- http/tests/security/xssAuditor/open-script-src-04.html: Added.
- http/tests/security/xssAuditor/property-escape-comment-01-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape-comment-01.html: Added.
- http/tests/security/xssAuditor/property-escape-comment-02-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape-comment-02.html: Added.
- http/tests/security/xssAuditor/property-escape-comment-03-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape-comment-03.html: Added.
- http/tests/security/xssAuditor/property-escape-entity-01-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape-entity-01.html: Added.
- http/tests/security/xssAuditor/property-escape-entity-02-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape-entity-02.html: Added.
- http/tests/security/xssAuditor/property-escape-entity-03-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape-entity-03.html: Added.
- http/tests/security/xssAuditor/property-escape-quote-01.html: Added.
- http/tests/security/xssAuditor/property-escape-quote-02.html: Added.
- http/tests/security/xssAuditor/property-escape-quote-03.html: Added.
- http/tests/security/xssAuditor/script-tag-with-comma-01-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-comma-01.html: Added.
- http/tests/security/xssAuditor/script-tag-with-comma-02-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-comma-02.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-01-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-01.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-02-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-02.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-03-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-03.html: Added.
- http/tests/security/xssAuditor/script-tag-with-trailing-comment5.html: Added.
These tests perform the same validation as the combined tests, they
simply do it without introducing load-order dependencies.
- 6:38 AM Changeset in webkit [143919] by
-
- 6 edits in branches/chromium/1410/Source
Merge 142773
MediaStream API: Use the source id when creating new tracks
https://bugs.webkit.org/show_bug.cgi?id=109688
Reviewed by Adam Barth.
Source/Platform:
Added id to initialize and renamed audio/videoSources to audio/videoTracks.
- chromium/public/WebMediaStream.h:
(WebKit):
(WebMediaStream):
(WebKit::WebMediaStream::audioSources):
(WebKit::WebMediaStream::videoSources):
- chromium/public/WebMediaStreamTrack.h:
(WebMediaStreamTrack):
Source/WebCore:
This patch reuses the ids from the source when creating tracks instead of creating a new one.
This was requested by the chromium port to greatly simplify their implementation.
In the longer run the API should be rewritten to only use tracks instead of sources.
Covered by existing tests.
- platform/chromium/support/WebMediaStream.cpp:
(WebKit::WebMediaStream::audioTracks):
(WebKit::WebMediaStream::videoTracks):
(WebKit::WebMediaStream::initialize):
(WebKit):
- platform/chromium/support/WebMediaStreamTrack.cpp:
(WebKit::WebMediaStreamTrack::initialize):
(WebKit):
- platform/mediastream/MediaStreamComponent.h:
(WebCore::MediaStreamComponent::create):
(MediaStreamComponent):
(WebCore::MediaStreamComponent::MediaStreamComponent):
(WebCore):
- platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::create):
(MediaStreamDescriptor):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
Tools:
Switching mock to new API.
- DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
(WebTestRunner::WebUserMediaClientMock::requestUserMedia):
TBR=dharani@google.com
Review URL: https://codereview.chromium.org/12326102
- 6:14 AM Changeset in webkit [143918] by
-
- 2 edits in trunk/Tools
Unreviewed, fix simple mistake in r143903.
<http://webkit.org/b/110746>
Reviewed by Andreas Kling.
Pass git revision, not svn revision, to git shell command.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.timestamp_of_latest_commit):
- 6:06 AM Changeset in webkit [143917] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Disable registerProtocolHandler on Android
https://bugs.webkit.org/show_bug.cgi?id=110481
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-25
Reviewed by Julien Chaffraix.
Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't
actually wired up internally. Disable the feature to avoid breaking feature detection until
we can implement it properly. Previous attempt is at http://trac.webkit.org/changeset/133465
See the discussion of the future implementation at http://crbug.com/156386
- features.gypi: Disable the flag for Android, enable it only for non-Android platforms.
- src/ChromeClientImpl.h: Declaration is now guarded by the flag, not to break Android.
- 6:06 AM Changeset in webkit [143916] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 5:59 AM Changeset in webkit [143915] by
-
- 2 edits in trunk/Tools
[chromium] Let built-product-archive log which directory it's archiving from and extracting to
https://bugs.webkit.org/show_bug.cgi?id=110748
Reviewed by Jochen Eisinger.
One of the mac testers runs DRT from out/ but WebKitUnitTests from
xcodebuild. I'm trying to understand what's going on.
- BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
(extractBuiltProduct):
- 5:50 AM Changeset in webkit [143914] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 5:37 AM Changeset in webkit [143913] by
-
- 13 edits in trunk
Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
https://bugs.webkit.org/show_bug.cgi?id=110599
Reviewed by Yury Semikhatsky.
Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
that were given us via MemoryInstrumentation calls.
So I extended client api with registerString method that pushes the strings
down to the serializer.
Source/WebCore:
- css/InspectorCSSOMWrappers.h:
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportNodeImpl):
(WebCore::HeapGraphSerializer::reportEdgeImpl):
(WebCore::HeapGraphSerializer::registerString):
(WebCore::HeapGraphSerializer::registerTypeString):
(WebCore::HeapGraphSerializer::addRootNode):
- inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
- inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::registerString):
(WebCore):
- inspector/MemoryInstrumentationImpl.h:
(MemoryInstrumentationClientImpl):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
Source/WTF:
- wtf/MemoryInstrumentation.h:
(MemoryInstrumentationClient):
- wtf/MemoryObjectInfo.h:
(WTF::MemoryObjectInfo::MemoryObjectInfo):
(WTF::MemoryObjectInfo::setClassName):
(WTF::MemoryObjectInfo::classNameId):
(WTF::MemoryObjectInfo::setName):
(WTF::MemoryObjectInfo::nameId):
(MemoryObjectInfo):
Tools:
- TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
- TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
(TestWebKitAPI::Helper::Helper):
(Helper):
(TestWebKitAPI::Helper::addNode):
(TestWebKitAPI::TEST):
- 5:21 AM Changeset in webkit [143912] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 5:20 AM Changeset in webkit [143911] by
-
- 2 edits in trunk/Source/WebCore
Add a scrollbar class for the new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110589
Reviewed by Kent Tamura.
Adding a scrollbar to be used in the new calendar picker (Bug 109439).
No new tests. Code is not used yet.
- Resources/pagepopups/calendarPicker.js:
(ScrubbyScrollBar):
(ScrubbyScrollBar.prototype.height):
(ScrubbyScrollBar.prototype.setHeight):
(ScrubbyScrollBar.prototype.setThumbHeight): Sets the height of the scroll bar thumb.
(ScrubbyScrollBar.prototype._setThumbPositionFromEvent): Sets the thumb position from a mouse event.
(ScrubbyScrollBar.prototype.onMouseDown):
(ScrubbyScrollBar.prototype.onWindowMouseMove):
(ScrubbyScrollBar.prototype.onWindowMouseUp):
(ScrubbyScrollBar.prototype.onThumbStyleTopAnimationStep): Animates the thumb back to the center position.
(ScrubbyScrollBar.prototype.onScrollTimer): Fires repeatedly while the thumb is being dragged.
- 5:16 AM Changeset in webkit [143910] by
-
- 2 edits in trunk/Tools
Make ScriptError not crash when args is a tuple
https://bugs.webkit.org/show_bug.cgi?id=110747
Reviewed by Jochen Eisinger.
I'm trying to understand the error on
http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
better. I'll likely have to revert the ninja switch on windows, but
having error reporting code that doesn't itself crash sounds like a
good thing to have anyways.
The problem is that '%s' % (1, 2) errors out, and args is sometimes a
tuple not a list.
- Scripts/run-chromium-webkit-unit-tests:
- Scripts/webkitpy/common/system/executive.py:
(ScriptError.init):
- 5:13 AM Changeset in webkit [143909] by
-
- 11 edits in trunk/Source/JavaScriptCore
[BlackBerry][ARM] Fix cast-align warnings in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=110738
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-02-25
Reviewed by Rob Buis.
Use reinterpret_cast_ptr instead of reinterpret_cast for
pointers.
- dfg/DFGOperations.cpp:
- heap/CopiedBlock.h:
(JSC::CopiedBlock::zeroFillWilderness):
- heap/WeakBlock.h:
(JSC::WeakBlock::asWeakImpl):
(JSC::WeakBlock::asFreeCell):
(JSC::WeakBlock::weakImpls):
- heap/WeakImpl.h:
(JSC::WeakImpl::asWeakImpl):
- interpreter/JSStack.cpp:
(JSC::JSStack::disableErrorStackReserve):
- interpreter/JSStack.h:
(JSC::JSStack::reservationEnd):
- runtime/ArrayStorage.h:
(JSC::ArrayStorage::from):
- runtime/Butterfly.h:
(JSC::Butterfly::indexingPayload):
- runtime/IndexingHeader.h:
(JSC::IndexingHeader::propertyStorage):
- runtime/JSActivation.h:
(JSC::JSActivation::tearOff):
(JSC::JSActivation::isTornOff):
(JSC::JSActivation::storage):
- 5:10 AM Changeset in webkit [143908] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 5:02 AM Changeset in webkit [143907] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 4:56 AM Changeset in webkit [143906] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 4:47 AM FeatureFlags edited by
- CUSTOM_ELEMENTS (diff)
- 4:36 AM Changeset in webkit [143905] by
-
- 2 edits in trunk/Tools
[EFL] Align feature defaults
https://bugs.webkit.org/show_bug.cgi?id=110715
Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
OptionsEfl.cmake.
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-25
Reviewed by Gyuyoung Kim.
- Scripts/webkitperl/FeatureList.pm:
- 4:31 AM Changeset in webkit [143904] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Fix of closure type annotations.
- inspector/front-end/UISourceCode.js:
- inspector/front-end/utilities.js:
- 4:26 AM Changeset in webkit [143903] by
-
- 7 edits in trunk/Tools
run-perf-tests reports wrong commit time
https://bugs.webkit.org/show_bug.cgi?id=110746
Reviewed by Andreas Kling.
The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
of when the subdirectory was last modified.
Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
insufficient since running "svn log -r <revision>" on a partial checkout only returns
an empty result if the revision didn't modify the subdirectory.
For git, there is no partial checkout, so we just need to pass in "-r" option to keep
the interface compatible with svn.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.timestamp_of_latest_commit):
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.timestamp_of_latest_commit):
- Scripts/webkitpy/common/checkout/scm/scm_mock.py:
(MockSCM.timestamp_of_latest_commit):
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(test_timestamp_of_latest_commit):
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.timestamp_of_latest_commit):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_results_dict):
- 3:45 AM Changeset in webkit [143902] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [Network] Timeline bars and dividers are positioned in different coordinate systems.
https://bugs.webkit.org/show_bug.cgi?id=109943
Reviewed by Pavel Feldman.
Look at network log: red bar (on load) is positioned to the right of
the last required load.
This is incorrect. For exmaple, in case of short event it should be
positioned in the center of the bar.
- inspector/front-end/DataGrid.js:
Fix - hidden columns can have non-zero width.
- inspector/front-end/NetworkPanel.js: Use correct width for calculator.
- inspector/front-end/networkLogView.css: Removed parasite paddinds.
Extracted common absolute "paddings".
- 3:31 AM Changeset in webkit [143901] by
-
- 2 edits in trunk/Source/WebCore
Add list view for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110140
Reviewed by Kent Tamura.
Adding list view class to be used in the new calendar picker (Bug 109439).
No new tests. Code is not yet used.
- Resources/pagepopups/calendarPicker.js:
(ListCell): One row inside the list view. We reuse
list cells to avoid animation hiccups caused by memory allocation.
(ListCell.prototype._recycleBin): Returns array to
store thrown away list cells so we can reuse them.
(ListCell.prototype.throwAway): Hides the cell and puts it in the recycle bin.
(ListCell.prototype.show):
(ListCell.prototype.hide): Hide the cell when we don't need the cell any more.
(ListCell.prototype.width):
(ListCell.prototype.setWidth):
(ListCell.prototype.position):
(ListCell.prototype.setPosition): Sets the CSS transform to position the cell.
(ListCell.prototype.setSelected): Adds selected CSS class.
(ListView): Shows a scrolling list.
(ListView.prototype.onAnimationFrameWillFinish): Calls updateCells if the cells need to be updated.
(ListView.prototype.setNeedsUpdateCells): Mark the cells as need to be updated.
(ListView.prototype.cellAtRow): Returns the cell at a given row. If the cell is not visible and doesn't exist, returns undefined.
(ListView.prototype.rowAtScrollOffset): The row that is displayed at the given scroll offset.
(ListView.prototype.scrollOffsetForRow): The scroll offset for the top of a given row.
(ListView.prototype.addCellIfNecessary): Adds the cell for a given row.
(ListView.prototype.prepareNewCell): Prepares a new or recycled cell for a given row.
(ListView.prototype.throwAwayCell): Throws a way a cell.
(ListView.prototype.firstVisibleRow): The first visible row at the top of the view.
(ListView.prototype.lastVisibleRow): The last visible row at the bottom of the view.
(ListView.prototype.scrollViewDidChangeContentOffset):
(ListView.prototype.scrollViewDidChangeHeight):
(ListView.prototype.scrollViewDidChangePartition):
(ListView.prototype.updateCells): Updates all the cells that are visible.
(ListView.prototype.width):
(ListView.prototype.setWidth):
(ListView.prototype.height):
(ListView.prototype.setHeight):
(ListView.prototype.onClick): Clicking on a row selects it.
(ListView.prototype.select):
(ListView.prototype.deselect):
(ListView.prototype.scrollToRow): Scrolls to a given row.
- 2:53 AM Changeset in webkit [143900] by
-
- 15 edits in trunk
Web Inspector: move profile type specific code out of ProfilesPanel (refactor)
https://bugs.webkit.org/show_bug.cgi?id=110597
Patch by Alexei Filippov <alph@chromium.org> on 2013-02-25
Reviewed by Yury Semikhatsky.
Move profile type specific functionality out of ProfilesPanel class.
This is a first part of WebInspector.ProfilesPanel refactoring.
No new tests as the functionality isn't changed.
Source/WebCore:
- English.lproj/localizedStrings.js:
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.addProfileHeader):
(WebInspector.CPUProfileType.prototype.removeProfile):
(WebInspector.CPUProfileType.prototype._requestProfilesFromBackend):
(WebInspector.CPUProfileType.prototype.resetProfiles):
(WebInspector.CPUProfileType.prototype.addHeapSnapshotChunk):
(WebInspector.CPUProfileType.prototype.finishHeapSnapshot):
(WebInspector.CPUProfileType.prototype.reportHeapSnapshotProgress):
- inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorProfileType.prototype.buttonClicked):
(WebInspector.CSSSelectorProfileType.prototype._startRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype._stopRecordingProfile):
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileType.prototype.buttonClicked):
(WebInspector.CanvasProfileType.prototype._runSingleFrameCapturing):
(WebInspector.CanvasProfileType.prototype._startFrameCapturing):
(WebInspector.CanvasProfileType.prototype._didStartCapturingFrame):
(WebInspector.CanvasProfileType.prototype._reset):
(WebInspector.CanvasProfileType.prototype.removeProfile):
(WebInspector.CanvasProfileHeader.prototype.dispose):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._profiles):
(WebInspector.HeapSnapshotProfileType):
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
(WebInspector.HeapSnapshotProfileType.prototype.addProfileHeader):
(WebInspector.HeapSnapshotProfileType.prototype.addHeapSnapshotChunk):
(WebInspector.HeapSnapshotProfileType.prototype.finishHeapSnapshot):
(WebInspector.HeapSnapshotProfileType.prototype.reportHeapSnapshotProgress):
(WebInspector.HeapSnapshotProfileType.prototype.resetProfiles):
(WebInspector.HeapSnapshotProfileType.prototype.removeProfile):
(WebInspector.HeapSnapshotProfileType.prototype._requestProfilesFromBackend):
(WebInspector.HeapProfileHeader.prototype._updateTransferProgress):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotProfileType):
(WebInspector.NativeSnapshotProfileType.prototype.addNativeSnapshotChunk):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType):
(WebInspector.ProfileType.prototype.buttonClicked):
(WebInspector.ProfileType.prototype.get description):
(WebInspector.ProfileType.prototype.getProfiles):
(WebInspector.ProfileType.prototype.getProfile):
(WebInspector.ProfileType.prototype._makeKey):
(WebInspector.ProfileType.prototype.addProfile):
(WebInspector.ProfileType.prototype.removeProfile):
(WebInspector.ProfileType.prototype.findTemporaryProfile):
(WebInspector.ProfileType.prototype._reset):
(WebInspector.ProfileType.prototype._requestProfilesFromBackend):
(WebInspector.ProfileHeader):
(WebInspector.ProfileHeader.prototype.dispose):
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._loadFromFile):
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
(WebInspector.ProfilesPanel.prototype._populateAllProfiles):
(WebInspector.ProfilesPanel.prototype.wasShown):
(WebInspector.ProfilesPanel.prototype._profilerWasEnabled):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._registerProfileType.onAddProfileHeader):
(WebInspector.ProfilesPanel.prototype._registerProfileType.onRemoveProfileHeader):
(WebInspector.ProfilesPanel.prototype._registerProfileType.onProgressUpdated):
(WebInspector.ProfilesPanel.prototype._registerProfileType):
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype._createTemporaryProfile):
(WebInspector.ProfilesPanel.prototype._removeTemporaryProfile):
(WebInspector.ProfilesPanel.prototype.getProfile):
(WebInspector.ProfilesPanel.prototype.showProfile):
(WebInspector.ProfilesPanel.prototype._getAllProfiles):
(WebInspector.ProfilesPanel.prototype._searchableViews):
(WebInspector.ProfilesPanel.prototype.searchCanceled):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype._reportProfileProgress):
LayoutTests:
- inspector/profiler/canvas2d/canvas-replay-log-grid.html:
- inspector/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt:
- inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
- inspector/profiler/heap-snapshot-loader.html:
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):
- inspector/profiler/profiler-test.js:
(initialize_ProfilerTest.InspectorTest.startProfilerTest.startTest):
(initialize_ProfilerTest.InspectorTest.startProfilerTest):
- 2:40 AM Changeset in webkit [143899] by
-
- 4 edits4 deletes in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipped failing tests.
- platform/qt-5.0-wk2/fast/forms/select-baseline-expected.png: Removed.
- platform/qt-5.0-wk2/fast/forms/select-baseline-expected.txt: Removed.
- platform/qt-5.0/fast/forms/select-baseline-expected.png: Removed.
- platform/qt-5.0/fast/forms/select-baseline-expected.txt: Removed.
- platform/qt/TestExpectations:
- platform/qt/fast/forms/select-baseline-expected.png: Update after r143836.
- platform/qt/fast/forms/select-baseline-expected.txt: Update after r143836.
- 2:33 AM Changeset in webkit [143898] by
-
- 3 edits in trunk/Tools
[chromium] move WebRuntimeFeatures configuration to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=110712
Reviewed by Nico Weber.
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
- 2:04 AM Changeset in webkit [143897] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 1:56 AM Changeset in webkit [143896] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskip tests after r143800.
- platform/qt/TestExpectations:
- 1:48 AM Changeset in webkit [143895] by
-
- 2 edits in trunk/Tools
Make ninja the default build system for build-webkit --chromium on windows
https://bugs.webkit.org/show_bug.cgi?id=110731
Reviewed by Jochen Eisinger.
With http://crbug.com/169945 fixed, this should now work.
- Scripts/update-webkit-chromium:
- 1:48 AM Changeset in webkit [143894] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed fix of type annotation for this._liveLocations.
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
- 1:42 AM Changeset in webkit [143893] by
-
- 6 edits in trunk/Source/WebCore
Fix style errors in WebCore/editing/{htmlediting,markup,visible_units}.*
https://bugs.webkit.org/show_bug.cgi?id=110721
Reviewed by Ryosuke Niwa.
No new tests. This should not make any bahevior changes.
- editing/htmlediting.cpp:
(WebCore::lowestEditableAncestor):
(WebCore):
(WebCore::isSpecialElement):
(WebCore::enclosingListChild):
(WebCore::canMergeLists):
(WebCore::tabSpanNode):
(WebCore::isNodeRendered):
(WebCore::caretMaxOffset):
- editing/htmlediting.h:
(WebCore):
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendElement):
- editing/markup.h:
(WebCore):
- editing/visible_units.cpp:
(WebCore::previousRootInlineBoxCandidatePosition):
(WebCore::nextRootInlineBoxCandidatePosition):
(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::previousBoundary):
(WebCore::endOfLine):
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
(WebCore::nextSentencePositionBoundary):
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):
- 1:41 AM Changeset in webkit [143892] by
-
- 3 edits2 deletes in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Giving up on individually listing slow sputnik tests, replaced all
the expectations with a single one covering the whole directory in both release and debug builds.
Also removing duplicate expectations and adding an expectation for tests that require custom elements support.
- platform/gtk/editing/selection/extend-by-sentence-001-expected.txt: Rebaselining.
- platform/gtk/media/audio-controls-rendering-expected.png: Removed. Requires a new baseline.
- platform/gtk/media/audio-controls-rendering-expected.txt: Removed. Ditto.
- 1:29 AM Changeset in webkit [143891] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 1:11 AM Changeset in webkit [143890] by
-
- 6 edits3 copies in branches/chromium/1410
Merge 142572
REGRESSION (r140778):Calendar Picker buttons are wrong when rtl
https://bugs.webkit.org/show_bug.cgi?id=109158
Reviewed by Kent Tamura.
Source/WebCore:
The calendar picker button's icon and position where wrong when rtl.
Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html
- Resources/pagepopups/calendarPicker.css:
(.year-month-button-left .year-month-button): Use -webkit-margin-end so the margin is applide to the right side.
(.year-month-button-right .year-month-button): Use -webkit-margin-start so the margin is applide to the right side.
(.today-clear-area .today-button): Use -webkit-margin-end so the margin is applide to the right side.
- Resources/pagepopups/calendarPicker.js:
(YearMonthController.prototype._attachLeftButtonsTo): Flip icon image when rtl.
(YearMonthController.prototype._attachRightButtonsTo): Ditto.
LayoutTests:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html: Added.
- 1:10 AM Changeset in webkit [143889] by
-
- 7 edits in trunk
Web Inspector: Improve speed of Linkifier.reset operation.
https://bugs.webkit.org/show_bug.cgi?id=110696
Reviewed by Yury Semikhatsky.
Linkifier calls Location.dispose N times and each dispose method calls Array.remove
which scans entire array and does splice. So the complexity of Linkifier.reset
is O(N2). I replaced the arrays with Set and got O(N) complexity.
Drive by fix: The identifier generator was slightly changed.
Now it produces identifiers that couldn't be converted into a number.
So the engine will never convert Set/Map object into an array.
Source/WebCore:
- inspector/front-end/Script.js:
(WebInspector.Script):
(WebInspector.Script.prototype.updateLocations):
(WebInspector.Script.prototype.createLiveLocation):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.addLiveLocation):
(WebInspector.UISourceCode.prototype.updateLiveLocations):
- inspector/front-end/utilities.js:
LayoutTests:
- inspector/debugger/callstack-placards-discarded.html:
- inspector/debugger/linkifier.html:
- 12:49 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:09 AM Changeset in webkit [143888] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] ChromeClientBlackBerry: fix variable names
https://bugs.webkit.org/show_bug.cgi?id=110562
Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-25
Reviewed by Rob Buis.
manager was incorrectly renamed back to tracker in r138696:
http://trac.webkit.org/changeset/138696/trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
Feb 24, 2013:
- 11:35 PM Changeset in webkit [143887] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] GeolocationClientBlackBerry: add missing headers
https://bugs.webkit.org/show_bug.cgi?id=110563
Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-24
Reviewed by Benjamin Poulain.
Frame.h and SecurityOrigin.h are necessary since r136969.
GeolocationPosition.h since r132360.
- WebCoreSupport/GeolocationClientBlackBerry.cpp:
- 11:27 PM Changeset in webkit [143886] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r143797.
http://trac.webkit.org/changeset/143797
https://bugs.webkit.org/show_bug.cgi?id=110724
Causes assertion failures in multiple tests. (Requested by
vsevik on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-24
- dom/DocumentParser.h:
(DocumentParser):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
(WebCore::HTMLDocumentParser::shouldUseThreading):
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
- 11:00 PM Changeset in webkit [143885] by
-
- 13 edits in trunk/Source/WebCore
Rollout r143556, it regressed html5-full-render perf.
https://bugs.webkit.org/show_bug.cgi?id=110719
Unreviewed rollout.
- css/BasicShapeFunctions.cpp:
(WebCore::convertToLength):
(WebCore::basicShapeForValue):
- css/BasicShapeFunctions.h:
(WebCore):
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::gradientWithStylesResolved):
- css/CSSGradientValue.h:
(CSSGradientValue):
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::style):
(WebCore::CSSToStyleMap::rootElementStyle):
(WebCore::CSSToStyleMap::useSVGZoomRules):
(WebCore::CSSToStyleMap::styleImage):
- css/CSSToStyleMap.h:
(WebCore):
(WebCore::CSSToStyleMap::CSSToStyleMap):
(CSSToStyleMap):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyExclusionShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
- css/StyleBuilder.h:
(WebCore):
(PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
- css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::initElement):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::findSiblingForStyleSharing):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::applyPropertyToCurrentStyle):
(WebCore::StyleResolver::useSVGZoomRules):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::checkForZoomChange):
(WebCore::StyleResolver::checkForGenericFamilyChange):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::styleShader):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createCustomFilterOperation):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):
(WebCore::StyleResolver::loadPendingResources):
(WebCore::StyleResolver::reportMemoryUsage):
- css/StyleResolver.h:
(WebCore::StyleResolver::style):
(WebCore::StyleResolver::parentStyle):
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::hasParentNode):
(StyleResolver):
(WebCore::StyleResolver::isRightPage):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::State::document):
(State):
(WebCore::StyleResolver::applyPropertyToRegularStyle):
(WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::styleMap):
(WebCore::StyleResolver::fontDescription):
(WebCore::StyleResolver::parentFontDescription):
(WebCore::StyleResolver::setFontDescription):
(WebCore::StyleResolver::setZoom):
(WebCore::StyleResolver::setEffectiveZoom):
(WebCore::StyleResolver::setTextSizeAdjust):
(WebCore::StyleResolver::setWritingMode):
(WebCore::StyleResolver::setTextOrientation):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
- 7:57 PM Changeset in webkit [143884] by
-
- 6 edits in trunk/Source/WebCore
[Mac] cleanup MediaPlayerPrivateAVFoundation and InbandTextTrackPrivateAVF
https://bugs.webkit.org/show_bug.cgi?id=110716
Reviewed by Alexey Proskuryakov.
No new tests, no functionality changed.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::InbandTextTrackPrivateAVF): Take AVFInbandTrackParent*
instead of MediaPlayerPrivateAVFoundation*.
(WebCore::InbandTextTrackPrivateAVF::processCue): Pass new cues directly to the client.
(WebCore::InbandTextTrackPrivateAVF::disconnect): m_player -> m_owner.
(WebCore::InbandTextTrackPrivateAVF::setMode): m_player -> m_owner.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::addGenericCue): Delete, no longer needed.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: Don't include
CachedResourceClient.h, it isn't needed.
- 7:38 PM Changeset in webkit [143883] by
-
- 3 edits in branches/chromium/1410/Source/WebCore
Merge 143363
Update FeatureObserver on top level navigation in addition to page destruction.
https://bugs.webkit.org/show_bug.cgi?id=109874
Patch by Kassy Coan <kassycoan@chromium.org> on 2013-02-19
Reviewed by Adam Barth.
No new tests. Only effect is to histogram more frequently.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchDidCommitLoad):
- page/FeatureObserver.cpp:
(WebCore::FeatureObserver::~FeatureObserver):
(WebCore):
(WebCore::FeatureObserver::updateMeasurements):
(WebCore::FeatureObserver::didCommitLoad):
- page/FeatureObserver.h:
(FeatureObserver):
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12340046
- 6:02 PM Changeset in webkit [143882] by
-
- 6 edits in trunk
Add an ASSERT to didChangeDeviceProximity
https://bugs.webkit.org/show_bug.cgi?id=110317
Reviewed by Hajime Morrita.
Source/WebCore:
Add An ASSERT to didChangeDeviceProximity function to check range of value.
Change exist test cases.
- Modules/proximity/DeviceProximityController.cpp:
(WebCore::DeviceProximityController::didChangeDeviceProximity):
LayoutTests:
Fix wrong test cases which are found by ASSERT insertion.
- proximity/basic-operation-expected.txt:
- proximity/basic-operation.html:
- proximity/resources/event-after-navigation-new.html:
- 4:14 PM Changeset in webkit [143881] by
-
- 4 edits in trunk/Source
Clarify meaning of default default encoding localizable string
https://bugs.webkit.org/show_bug.cgi?id=110714
Reviewed by Eric Carlson.
- English.lproj/Localizable.strings: This string is only used on Windows, and it's very confusing to everyone involved.
- 2:40 PM Changeset in webkit [143880] by
-
- 9 edits63 adds in trunk
CSP 1.1: Experiment with 'reflected-xss' directive.
https://bugs.webkit.org/show_bug.cgi?id=104479
Reviewed by Adam Barth.
Source/WebCore:
Content Security Policy 1.1 defines a 'reflected-xss' directive that
works in much the same way as WebKit's current 'X-XSS-Protection'
header[1]. This patch implements the new directive by parsing it
inside ContentSecurityPolicy, and exposing that state to XSSAuditor.
XSSAuditor now grabs the CSP directive's state, and mixes it with the
X-XSS-Protection header's state to determine how the page should be
handled. Moreover, both headers' states are now expressed in terms of
ContentSecurityPolicy::ReflectedXSSDisposition.
[1]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#reflected-xss--experimental
Tests: http/tests/security/contentSecurityPolicy/1.1/reflected-xss-allow.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-allow.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-unset.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-allow.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-parsing.html
- html/parser/XSSAuditor.cpp:
(WebCore::combineXSSProtectionHeaderAndCSP):
Given both headers' states, return the state which the XSSAuditor
should use when parsing a page. Blocking overrides filtering, which
overrides disabling.
(WebCore):
(WebCore::XSSAuditor::init):
Process the 'X-XSS-Protection' header before grabbing the CSP
header's state. Both are passed into the new
combineXSSProtectionHeaderAndCSP method to generate the final
state that ought to be used.
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::filterToken):
- html/parser/XSSAuditor.h:
Switch to ContentSecurityPolicy::ReflectedXSSDisposition internally
in XSSAuditor.
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::reflectedXSSDisposition):
Enum defining the possible state of the 'reflected-xss' CSP directive.
(CSPDirectiveList):
(WebCore::CSPDirectiveList::CSPDirectiveList):
(WebCore::CSPDirectiveList::parseReflectedXSS):
Given a 'reflected-xss' directive's value, set the
ReflectedXSSDisposition into a new property on the CSPDirectiveList.
(WebCore):
(WebCore::CSPDirectiveList::addDirective):
Accept 'reflected-xss' as a valid directive if we're in
experimental mode.
(WebCore::ContentSecurityPolicy::reflectedXSSDisposition):
Expose the directive's state via the public API.
(WebCore::ContentSecurityPolicy::reportInvalidReflectedXSS):
Generate console errors when invalid reflected-xss directive values
are encounted during parsing.
- page/ContentSecurityPolicy.h:
- platform/network/HTTPParsers.cpp:
(WebCore::parseXSSProtectionHeader):
- platform/network/HTTPParsers.h:
(WebCore):
Start using ContentSecurityPolicy::ReflectedXSSDisposition rather
than the XSSProtectionDisposition enum.
LayoutTests:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-unset-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-unset.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-parsing-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-parsing.html: Added.
- http/tests/security/contentSecurityPolicy/resources/reflected-xss-and-xss-protection.js: Added.
(testMixedHeader):
(frameLoaded):
(frameErrored):
- http/tests/security/xssAuditor/resources/echo-intertag.pl:
Added the ability to send an 'X-WebKit-CSP' header to test 'reflected-xss' behavior.
- 1:11 PM Changeset in webkit [143879] by
-
- 2 edits in trunk
[EFL] Rename ENABLE_REGIONS to ENABLE_CSS_REGIONS
https://bugs.webkit.org/show_bug.cgi?id=110699
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-24
Reviewed by Andreas Kling.
Fix a typo. ENABLE_REGIONS is called ENABLE_CSS_REGIONS
throughout the project.
- Source/cmake/OptionsEfl.cmake:
- 12:33 PM Changeset in webkit [143878] by
-
- 2 edits in trunk/Source/WebKit/win
REGRESSION(r143837): Broke build on AppleWin http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29.
https://bugs.webkit.org/show_bug.cgi?id=110713
Unreviewed.
- WebKit.vcproj/WebKitExports.def.in: Add the missing symbol after r143837.
- 12:31 PM Changeset in webkit [143877] by
-
- 16 edits in trunk/Source/WebCore
Updating GObject bindings baselines after r143863.
Unreviewed.
- bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
- 11:51 AM Changeset in webkit [143876] by
-
- 4 edits in tags/Safari-537.31.8/Source/WebCore
Merged r143656. 13281269
- 11:01 AM Changeset in webkit [143875] by
-
- 5 edits1 add1 delete in trunk
[GTK] Stop generating UserAgentGtk.h
https://bugs.webkit.org/show_bug.cgi?id=110582
Reviewed by Martin Robinson.
.:
- configure.ac: Provide the USER_AGENT_GTK_(MAJOR|MINOR)_VERSION defines in the autotoolsconfig.h
header, containing the user agent versions that are to be used in the user agent string. The
WEBKIT_USER_AGENT_(MAJOR|MINOR)_VERSION name is avoided as the same defines are specified in the
webkitversion.h API header (but are not accessible from the WebCore layer). The UserAgentGtk.h
header is also not generated anymore from the input file.
Source/WebCore:
No new tests - no new functionality.
- GNUmakefile.list.am: Move the UserAgentGtk.h build target from the derived sources list to
the list of the WebCore platform sources.
- platform/gtk/UserAgentGtk.cpp:
(WebCore::standardUserAgent): Rename WEBKIT_USER_AGENT_(MAJOR|MINOR)_VERSION to
USER_AGENT_GTK_(MAJOR|MINOR)_VERSION.
- platform/gtk/UserAgentGtk.h: Renamed from Source/WebCore/platform/gtk/UserAgentGtk.h.in.
Same as the input file expect for removed WEBKIT_USER_AGENT_(MAJOR|MINOR)_VERSION defines that
are now replaced by using the USER_AGENT_GTK_(MAJOR|MINOR)_VERSION defines placed in autotoolsconfig.h.
- 10:19 AM Changeset in webkit [143874] by
-
- 2 edits in tags/Safari-537.31.8/Source/WebCore
Merged r143825. <rdar://problem/13258596>
- 10:16 AM Changeset in webkit [143873] by
-
- 11 edits4 copies in tags/Safari-537.31.8
Merged r143821. <rdar://problem/12944761>
- 10:13 AM Changeset in webkit [143872] by
-
- 4 edits in tags/Safari-537.31.8/Source
Merged r143816. <rdar://problem/13096456>
- 10:09 AM Changeset in webkit [143871] by
-
- 4 edits in tags/Safari-537.31.8/Source
Versioning.
- 10:06 AM Changeset in webkit [143870] by
-
- 1 copy in tags/Safari-537.31.8
New Tag.
- 9:42 AM Changeset in webkit [143869] by
-
- 34 edits in trunk
[GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
https://bugs.webkit.org/show_bug.cgi?id=110702
Reviewed by Martin Robinson.
Source/WebCore:
No tests. Build fix, no behaviour change.
- platform/gtk/GtkVersioning.h: include the autotoolsconfig.h header,
which contains the GTK_API_VERSION_2 define now.
Source/WebKit/gtk:
- tests/testapplicationcache.c: include autotoolsconfig.h.
- tests/testatk.c: ditto.
- tests/testatkroles.c: ditto.
- tests/testcontextmenu.c: ditto.
- tests/testcopyandpaste.c: ditto.
- tests/testdomdocument.c: ditto.
- tests/testdomdomwindow.c: ditto.
- tests/testdomnode.c: ditto.
- tests/testdownload.c: ditto.
- tests/testfavicondatabase.c: ditto.
- tests/testglobals.c: ditto.
- tests/testhittestresult.c: ditto.
- tests/testhttpbackend.c: ditto.
- tests/testkeyevents.c: ditto.
- tests/testloading.c: ditto.
- tests/testmimehandling.c: ditto.
- tests/testnetworkrequest.c: ditto.
- tests/testnetworkresponse.c: ditto.
- tests/testwebbackforwardlist.c: ditto.
- tests/testwebdatasource.c: ditto.
- tests/testwebframe.c: ditto.
- tests/testwebhistoryitem.c: ditto.
- tests/testwebinspector.c: ditto.
- tests/testwebplugindatabase.c: ditto.
- tests/testwebresource.c: ditto.
- tests/testwebsettings.c: ditto.
- tests/testwebview.c: ditto.
- tests/testwindow.c: ditto.
Tools:
- GtkLauncher/main.c: include autotoolsconfig.h.
- Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of
the include ordering check, since it uses autotoolsconfig.h which needs to
come first.
- 8:45 AM Changeset in webkit [143868] by
-
- 8 edits in trunk/Source
StyledElement: Don't expose a mutable direct interface to the inline style.
<http://webkit.org/b/110711>
Reviewed by Antti Koivisto.
Source/WebCore:
Remove the ability to grab at a mutable StylePropertySet* for a StyledElement's inline style
from the outside world. It's now private and returns MutableStylePropertySet* for future convenience.
Three paths to changing the inline style remain:
- Setting the "style" attribute
- Via CSSOM (element.style)
- setInlineStyleProperty/removeInlineStyleProperty helpers
- dom/StyledElement.cpp:
(WebCore::StyledElement::ensureMutableInlineStyle):
- dom/StyledElement.h:
(StyledElement):
- editing/ApplyStyleCommand.cpp:
(WebCore::copyStyleOrCreateEmpty):
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
- html/canvas/CanvasStyle.cpp:
(WebCore::currentColor):
Source/WebKit/qt:
QWebElement::styleProperty() is a read-only method, so rewrite it to use StyledElement::inlineStyle().
- Api/qwebelement.cpp:
(QWebElement::styleProperty):
- 8:42 AM Changeset in webkit [143867] by
-
- 3 edits2 adds in trunk
Add methods to date types for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110454
Reviewed by Kent Tamura.
Source/WebCore:
Adding some methods to date types as part of the calendar picker redesign (Bug 109439).
Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-date-types.html
- Resources/pagepopups/calendarPicker.js:
(createUTCDate):
(DateType): Base class for Day, Week and Month.
(Day): Simplified constructor to only accept year, month, date.
(Day.createFromValue): Creates a new Day from a value.
(Day.createFromDate): Throw an error if the given date is invalid.
(Day.createFromDay):
(Day.prototype.equals): Accept non Day objects.
(Day.prototype.previous): Modified to take an offset value.
(Day.prototype.next): Ditto.
(Day.prototype.firstDay): Returns the first day in the range. For Day's case, returns itself.
(Day.prototype.middleDay): Returns the middle day in the range. For Day's case, returns itself.
(Day.prototype.lastDay): Returns the middle day in the range. For Day's case, returns itself.
(Day.prototype.valueOf):
(Day.prototype.weekDay): Returns the week day.
(Week): Simplified constructor to only accept year, month, date.
(Week.createFromValue):
(Week.createFromDate):
(Week.createFromDay):
(Week.weekOneStartDateForYear):
(Week.weekOneStartDayForYear):
(Week._numberOfWeeksSinceDate):
(Week.prototype.equals):
(Week.prototype.previous):
(Week.prototype.next):
(Week.prototype.firstDay): Returns the first day in the week.
(Week.prototype.middleDay): Returns the the day for Thursday.
(Week.prototype.lastDay): Returns the last day in the week.
(Week.prototype.valueOf):
(Month):
(Month.createFromValue):
(Month.createFromDate):
(Month.createFromDay):
(Month.prototype.containsDay):
(Month.prototype.equals):
(Month.prototype.previous):
(Month.prototype.next):
(Month.prototype.firstDay): Returns the first day in the month.
(Month.prototype.middleDay): Returns the middle day in the month.
(Month.prototype.lastDay): Returns the last day in the month.
(Month.prototype.valueOf):
(Month.prototype.toLocaleString): Moved location.
(Month.prototype.toShortLocaleString): Returns the month string in short format.
(CalendarPicker): Use createFromValue.
(YearMonthController.prototype.setMonth): Ditto.
(YearMonthController.prototype.moveRelatively): Ditto.
LayoutTests:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-date-types-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-date-types.html: Added. Unit tests for date types.
- 7:23 AM Changeset in webkit [143866] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] FatFingers: move rectForPoint() from HitTestResult to HitTestLocation
https://bugs.webkit.org/show_bug.cgi?id=110570
Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-24
Reviewed by Allan Sandfeld Jensen.
HitTestResult is no longer a HitTestLocation:
http://trac.webkit.org/changeset/135710/trunk/Source/WebCore/rendering/HitTestResult.h
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::fingerRectForPoint):
- 5:21 AM Changeset in webkit [143865] by
-
- 23 edits3 copies20 adds in trunk
[Custom Elements] Implement bare-bone document.register()
https://bugs.webkit.org/show_bug.cgi?id=100229
Reviewed by Adam Barth.
Source/WebCore:
This change implements a prefixed version of document.register(), with minimal feature support.
- The feature is guarded by ENABLE(CUSTOM_ELEMENTS) and RuntimeEnabledFeatures::customDOMElementsEnabled().
- This bare-bone version only recognizes "name" and "prototype" parameters. It doesn't support default value of "prototype" parameter.
- Currently only V8 is supported. JSC binding needs its own binding implementation.
Major new classes under dom/:
The dom module gets two new classes:
- CustomElementConstructor: A return value of document.register() which holds the custom element definition.
- CustomElementRegistry: A collection of CustomElementConstructor objects. CustomElementRegistry instance is created per Document and is owned by the Document.
CustomElementConstructor knows the definition of each custom
element, which is registered by document.register(). The name and
other options are held by this object. CustomElementRegistry owns a set
of the registered constructors. The registry guarantees invariants
like validity and uniqueness of the element names.
A change on make_names.pl
This change tweaks make_names.pl (or generated HTMLElementFactory)
to hook the creations of unknown elements. Some of element names
which come to the fallback path can be one of registered custom
element.
[V8WrapAsFunction] extended attribute:
The document.register() API returns a constructor
function. However, the V8 binding currently doesn't support it. To
make it possible, this change introduces "V8WrapAsFunction"
extended attribute for annotating CustomElementConstructor IDL
interface.
V8WrapAsFunction wraps the annotated interface with a JavaScript
function, which calls the original object as a function, or as a
constructor depends on the context.
With this wrapper function, there are two levels of indirection
between native C++ object and author-visible JS function:
[JS Adaptor Function] <-(hidden property)-> [JS Wrapper Object] -(internal field)-> [C++ Native object]
The code generator generates the binding code which deals with
this indirection. Also, there is a set of helper functions in
V8AdaptorFunction.h/cpp which takes care of this indirection.
V8DOMWrapper.cpp/h works as a facade for these APIs and is used from
the generated code.
This redundancy comes from limitations of both V8 bindings and V8
embedding API. See bug 108138 for details.
V8HTMLCustomElement
Unlike built-in HTML elements, any custom element has no
corresponding C++ class. Instead, document.register() should allow
passing a prototype object for the elements being registered.
V8HTMLCustomElement handles this lack of native class. It behaves
like a native side proxy of non-native HTMLElement subclasses. It
connects each custom element to an appropriate native element,
which is HTMLElement at this time. This restriction will be
relaxed later. See Bug 110436 for details.
Custom DOM elements and multiple worlds
In this patch, custom element registration and instantiation is not allowed
in non-main world and document.register() API just fails there.
Reviewed by Adam Barth.
Tests: fast/dom/custom/document-register-basic.html
fast/dom/custom/document-register-reentrant-null-constructor.html
fast/dom/custom/document-register-reentrant-returning-fake.html
fast/dom/custom/document-register-reentrant-throwing-constructor.html
- DerivedSources.make:
- WebCore.gypi:
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::customDOMElementsEnabled):
(WebCore::RuntimeEnabledFeatures::setCustomDOMElements):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/scripts/IDLAttributes.txt:
- bindings/v8/CustomElementHelpers.cpp: Added.
(WebCore::CustomElementHelpers::initializeConstructorWrapper):
(WebCore::hasNoBuiltinsInPrototype):
(WebCore::CustomElementHelpers::isValidPrototypeParameter):
(WebCore::CustomElementHelpers::isFeatureAllowed):
- bindings/v8/CustomElementHelpers.h: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.
(CustomElementHelpers):
- bindings/v8/V8AdaptorFunction.cpp: Added.
(WebCore::V8AdaptorFunction::getTemplate):
(WebCore::V8AdaptorFunction::configureTemplate):
(WebCore::V8AdaptorFunction::invocationCallback):
(WebCore::V8AdaptorFunction::wrap):
- bindings/v8/V8AdaptorFunction.h: Added.
(V8AdaptorFunction):
(WebCore::V8AdaptorFunction::unwrap):
(WebCore::V8AdaptorFunction::get):
- bindings/v8/V8DOMConfiguration.cpp:
(WebCore::V8DOMConfiguration::configureTemplate):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::toFunction):
(WebCore::V8DOMWrapper::fromFunction):
- bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
- bindings/v8/V8HTMLCustomElement.cpp: Added.
(WebCore::V8HTMLCustomElement::createWrapper):
- bindings/v8/V8HTMLCustomElement.h: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.
(V8HTMLCustomElement):
(WebCore::V8HTMLCustomElement::toV8):
(WebCore::HTMLCustomElement::toV8):
- bindings/v8/V8HiddenPropertyName.h:
- bindings/v8/custom/V8CustomElementConstructorCustom.cpp: Added.
(WebCore::V8CustomElementConstructor::callAsFunctionCallback):
- dom/CustomElementConstructor.cpp: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.
(WebCore::CustomElementConstructor::create):
(WebCore::CustomElementConstructor::CustomElementConstructor):
(WebCore::CustomElementConstructor::~CustomElementConstructor):
(WebCore::CustomElementConstructor::createElement):
- dom/CustomElementConstructor.h: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.
(CustomElementConstructor):
(WebCore::CustomElementConstructor::document):
(WebCore::CustomElementConstructor::tagName):
(WebCore::CustomElementConstructor::name):
- dom/CustomElementConstructor.idl: Added.
- dom/CustomElementRegistry.cpp: Added.
(WebCore::CustomElementRegistry::CustomElementRegistry):
(WebCore::CustomElementRegistry::~CustomElementRegistry):
(WebCore::CustomElementRegistry::constructorOf):
(WebCore::CustomElementRegistry::isValidName):
(WebCore::CustomElementRegistry::registerElement):
(WebCore::CustomElementRegistry::find):
(WebCore::CustomElementRegistry::createElement):
(WebCore::CustomElementRegistry::document):
- dom/CustomElementRegistry.h: Added.
(CustomElementRegistry):
- dom/Document.cpp:
(WebCore::Document::removedLastRef):
(WebCore::Document::registerElement):
(WebCore::Document::registry):
- dom/Document.h:
(Document):
- dom/make_names.pl:
(printWrapperFactoryCppFile):
- html/HTMLDocument.idl:
Source/WebKit/chromium:
Added enableCustomDOMElements flag.
- features.gypi:
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableCustomDOMElements):
(WebKit):
(WebKit::WebRuntimeFeatures::isCustomDOMElementsEnabled):
Tools:
Added enableCustomDOMElements flag.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
LayoutTests:
- fast/dom/custom/document-register-basic-expected.txt: Added.
- fast/dom/custom/document-register-basic.html: Added.
- fast/dom/custom/document-register-reentrant-null-constructor-expected.txt: Added.
- fast/dom/custom/document-register-reentrant-null-constructor.html: Added.
- fast/dom/custom/document-register-reentrant-returning-fake-expected.txt: Added.
- fast/dom/custom/document-register-reentrant-returning-fake.html: Added.
- fast/dom/custom/document-register-reentrant-throwing-constructor-expected.txt: Added.
- fast/dom/custom/document-register-reentrant-throwing-constructor.html: Added.
- fast/dom/custom/resources/document-register-fuzz.js: Added.
- platform/mac/TestExpectations:
- 5:18 AM Changeset in webkit [143864] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Timeline] Shrink CPU bars to make it easier to see frame information popup.
https://bugs.webkit.org/show_bug.cgi?id=110561
Reviewed by Pavel Feldman.
Area that causes frame information popup is overly "shaded" by CPU bars.
- inspector/front-end/timelinePanel.css:
(.timeline-cpu-bars .timeline-graph-bar): Reduce height and opacity.
- 5:01 AM Changeset in webkit [143863] by
-
- 26 edits3 copies in trunk/Source
Reduce include graph of JSDOMBinding.h
<http://webkit.org/b/110709>
Reviewed by Antti Koivisto.
Source/WebCore:
Move WebCore::root(Foo*) to the custom JSFooCustom.h headers.
This reduces the number of headers pulled in by JSDOMBinding.h.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCSSRuleCustom.cpp:
- bindings/js/JSCSSRuleCustom.h: Added.
(WebCore::root):
- bindings/js/JSCSSRuleListCustom.cpp:
- bindings/js/JSCSSStyleDeclarationCustom.h:
(WebCore::root):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSMediaListCustom.h: Added.
(WebCore::root):
- bindings/js/JSMutationObserverCustom.cpp:
- bindings/js/JSNodeCustom.h:
(WebCore::root):
- bindings/js/JSSVGElementInstanceCustom.cpp:
- bindings/js/JSStyleSheetCustom.h: Added.
(WebCore::root):
- bindings/js/JSTextTrackCustom.h:
- bindings/js/JSTextTrackListCustom.cpp:
- bindings/js/JSXPathResultCustom.cpp:
- bindings/js/SerializedScriptValue.cpp:
- bindings/scripts/CodeGeneratorGObject.pm:
(Generate):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/CodeGeneratorObjC.pm:
(AddIncludesForType):
- css/CSSRule.idl:
- css/CSSStyleDeclaration.idl:
- css/MediaList.idl:
- css/StyleSheet.idl:
- editing/mac/EditorMac.mm:
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
Source/WebKit2:
- Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::WebRenderObject):
- WebProcess/Storage/StorageAreaProxy.cpp:
- 12:39 AM Changeset in webkit [143862] by
-
- 2 edits in trunk/LayoutTests
Add timeout to the Chromium expectation of state-url-sets-links-visited.html
Unreviewed.
- platform/chromium/TestExpectations: Since Chromium's DRT does not support
computedStyleIncludingVisitedInfo, the test can also timeout as it will
raise an exception before invoking finishJSTest.
Feb 23, 2013:
- 11:29 PM Changeset in webkit [143861] by
-
- 2 edits in trunk/Source/WebCore
ResourceRequestBase unnecessarily updates when nothing changes
https://bugs.webkit.org/show_bug.cgi?id=110665
Reviewed by Dan Bernstein.
Don't mark platform data for update if nothing really changed. This avoids ever doing
doUpdatePlatformRequest() in NetworkProcess during normal browsing for me, which is
good for performance.
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::removeCredentials):
(WebCore::ResourceRequestBase::setCachePolicy):
(WebCore::ResourceRequestBase::setTimeoutInterval):
(WebCore::ResourceRequestBase::setFirstPartyForCookies):
(WebCore::ResourceRequestBase::setHTTPMethod):
(WebCore::ResourceRequestBase::clearHTTPAuthorization):
(WebCore::ResourceRequestBase::setAllowCookies):
(WebCore::ResourceRequestBase::setPriority):
- 11:24 PM Changeset in webkit [143860] by
-
- 6 edits2 deletes in trunk/LayoutTests
Add support for testing states changing asynchronously. Apply it to state-url-sets-links-visited.html.
https://bugs.webkit.org/show_bug.cgi?id=109883
Reviewed by Antti Koivisto.
Some tests depends on state change happening asynchronously. This is typically solved by using
timers with a long enough interval.
Timers have the general pitfalls of causing unreliable tests, and forcing unnecessary delays
in the tests.
This patch introduces new testing helpers, shouldBecomeEqual and shouldBecomeEqualToString, to
test a change of state repetively until it succeed (or timeout). Those test functions execute
the condition every 5ms until the test succeed.
The helper shouldBecomeEqualToString is applied on state-url-sets-links-visited.html to illustrate
the concept.
- fast/js/resources/js-test-pre.js:
(_waitForCondition): Generic helper function for the familly shouldBecomeXXX.
(.condition):
(.failureHandler):
(shouldBecomeEqual):
(shouldBecomeEqualToString):
- fast/loader/stateobjects/state-url-sets-links-visited.html:
- platform/wk2/TestExpectations:
state-url-sets-links-visited.html failed on WebKit2 because the visited links table is updated
asynchronously, and the style is only updated after 1 IPC message + 1 timer + 1 IPC message.
The test is changed to use shouldBecomeEqualToString in order to become reliable. If the UIProcess
does not update the style in a reasonable amount of time, the test fails.
- platform/chromium/TestExpectations: Make the test as failing on Chromium until proper test support is added
to DRT or Internals.
- 10:35 PM Changeset in webkit [143859] by
-
- 3 edits2 adds in trunk
Prevent crash in animated transform lists
https://bugs.webkit.org/show_bug.cgi?id=110704
Reviewed by Abhishek Arya.
Source/WebCore:
This change prevents accessing values off the end of toAtEndOfDuration by adding a check
for this case. Similar checks were added in r116458 but the author failed to catch this
case. WK110706 has been filed to handle this case in general.
This change also makes a trivial change that marks effectiveFrom as const.
Test: svg/animations/animateTransform-list-crash.html
- svg/SVGAnimatedTransformList.cpp:
(WebCore::SVGAnimatedTransformListAnimator::calculateAnimatedValue):
LayoutTests:
- svg/animations/animateTransform-list-crash-expected.txt: Added.
- svg/animations/animateTransform-list-crash.html: Added.
- 10:18 PM Changeset in webkit [143858] by
-
- 6 edits in trunk/Source/WebCore
SelectorChecker should not know about SelectorCheckerFastPath.
https://bugs.webkit.org/show_bug.cgi?id=110663
Both SelectorChecker and it's speedy cousin unfortunately include each other.
Luckily, the particular way in which SelectorQuery uses SelectorChecker yields
to a fairly simple decoupling. Now only the cousin knows of SelectorChecker.
Reviewed by Antti Koivisto.
No new functionality, covered by existing tests.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matches): Removed.
- css/SelectorChecker.h:
(SelectorChecker): Updated the decls to remove fast-path flag.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches): Added a helper just for SelectorQuery.
(WebCore::SelectorDataList::matches): Changed the callsite to use new helper.
(WebCore::SelectorDataList::execute): Ditto.
- dom/SelectorQuery.h:
(SelectorDataList): Updated decls.
- 9:31 PM Changeset in webkit [143857] by
-
- 4 edits in trunk/Source/WebCore
[Mac] user preference caption style applied incorrectly
https://bugs.webkit.org/show_bug.cgi?id=110707
<rdar://problem/13281096>
Reviewed by Maciej Stachowiak.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::textTrackContainerElementShadowPseudoId): New
static function so the pseudo ID is available.
(WebCore::MediaControlTextTrackContainerElement::shadowPseudoId): Call textTrackContainerElementShadowPseudoId.
- html/shadow/MediaControlElements.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Style the text track container
element for cue color, edge style, and font name.
- 6:54 PM Changeset in webkit [143856] by
-
- 9 edits in trunk/Source/WebCore
[V8] Generate xxxAttrGetterCallback()
https://bugs.webkit.org/show_bug.cgi?id=110676
Reviewed by Adam Barth.
This is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings. This patch introduces an indirection
function for xxxAttrGetter(), like this:
For non-custom getters
Handle<Value> xxxAttrGetterCallback(...) {
return xxxAttrGetter(...);
}
For custom getters.
Handle<Value> xxxAttrGetterCallback(...) {
return xxxAttrGetterCustom(...);
}
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateSingleBatchedAttribute):
(GenerateNonStandardFunction):
(GenerateImplementation):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingAttrAttrGetterCallback):
(TestActiveDOMObjectV8Internal):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetterCallback):
(WebCore):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::TestEventConstructorV8Internal::attr1AttrGetterCallback):
(TestEventConstructorV8Internal):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetterCallback):
(WebCore):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::TestExceptionV8Internal::nameAttrGetterCallback):
(TestExceptionV8Internal):
(WebCore):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStaticReadOnlyAttrAttrGetterCallback):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetterCallback):
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyLongAttrAttrGetterCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::staticReadOnlyLongAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::enumAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::shortAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::longAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::longLongAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::stringAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::testObjAttrAttrGetter):
(WebCore::TestObjV8Internal::testObjAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::createAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetterCallback):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrGetterCallback):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetterCallback):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetterCallback):
(WebCore::TestObjV8Internal::customAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr1AttrGetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr2AttrGetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr3AttrGetterCallback):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetterCallback):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetterCallback):
(WebCore::TestObjV8Internal::anyAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrGetterCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrGetterCallback):
(WebCore::TestObjV8Internal::enabledPerContextAttr1AttrGetterCallback):
(WebCore::TestObjV8Internal::enabledPerContextAttr2AttrGetterCallback):
(WebCore::TestObjV8Internal::floatArrayAttrGetterCallback):
(WebCore::TestObjV8Internal::doubleArrayAttrGetterCallback):
(WebCore::TestObjV8Internal::contentDocumentAttrGetterCallback):
(WebCore::TestObjV8Internal::mutablePointAttrGetterCallback):
(WebCore::TestObjV8Internal::immutablePointAttrGetterCallback):
(WebCore::TestObjV8Internal::strawberryAttrGetterCallback):
(WebCore::TestObjV8Internal::strictFloatAttrGetterCallback):
(WebCore::TestObjV8Internal::descriptionAttrGetterCallback):
(WebCore::TestObjV8Internal::idAttrGetterCallback):
(WebCore::TestObjV8Internal::hashAttrGetterCallback):
(WebCore::TestObjV8Internal::replaceableAttributeAttrGetterCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetterCallback):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetterCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetterCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetterCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetterCallback):
(WebCore):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrGetterCallback):
(TestTypedefsV8Internal):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrGetterCallback):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrGetterCallback):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrGetterCallback):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrGetterCallback):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrGetterCallback):
(WebCore):
- 5:38 PM Changeset in webkit [143855] by
-
- 2 edits in trunk/Source/WebCore
WebCore fails to link in Chromium official build
https://bugs.webkit.org/show_bug.cgi?id=110701
Reviewed by Abhishek Arya.
This is a follow-up fix for r143853. In WebCore.gyp, we need to
increase the shard of 'webcore_rendering' as well.
No tests. No change in behavior.
- WebCore.gyp/WebCore.gyp:
- 4:17 PM Changeset in webkit [143854] by
-
- 3 edits1 delete in trunk/Source/WebCore
Unreviewed, rolling out r143844.
http://trac.webkit.org/changeset/143844
https://bugs.webkit.org/show_bug.cgi?id=110241
It broke Chromium Mac Release Build
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/WebCoreGTK.gyp: Removed.
- WebCore.gypi:
- 3:33 PM Changeset in webkit [143853] by
-
- 2 edits in trunk/Source/WebCore
WebCore fails to link in Chromium official build
https://bugs.webkit.org/show_bug.cgi?id=110697
Reviewed by Eric Seidel.
Apparently we need to use more shards to work around linker limitations
on Windows again.
- WebCore.gyp/WebCore.gyp:
- 3:31 PM Changeset in webkit [143852] by
-
- 6 edits2 moves in trunk/Tools
[Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
https://bugs.webkit.org/show_bug.cgi?id=110606
Reviewed by Adam Barth.
Part of a larger refactoring series; see tracking bug 82948.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
(WebKitSupportTestEnvironment::mockPlatform):
(WebKitSupportTestEnvironment):
- DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
(MockPlatform::create):
(MockPlatform::MockPlatform):
(MockPlatform::~MockPlatform):
(MockPlatform::setInterfaces):
(MockPlatform::cryptographicallyRandomValues):
(MockPlatform::createMediaStreamCenter):
(MockPlatform::createRTCPeerConnectionHandler):
- DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
(MockPlatform):
- DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
- DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestDelegate):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
- 2:37 PM Changeset in webkit [143851] by
-
- 11 edits in trunk/Source/WebCore
[V8] Rename constructorCallbackCustom() to constructorCustom()
https://bugs.webkit.org/show_bug.cgi?id=110671
Reviewed by Adam Barth.
his is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings.
See https://bugs.webkit.org/show_bug.cgi?id=110667#c0
In the new world, "Callback" is used to indicate that it
is a function called back by V8. Currently "Callback" is
used for both V8 callbacks, DOM methods and DOM constructors.
This patch fixes the inconsistency.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateCustomConstructorCallback):
- bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCustom):
- bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCustom):
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCustom):
- bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCustom):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCustom):
- bindings/v8/custom/V8MessageChannelCustom.cpp:
(WebCore::V8MessageChannel::constructorCustom):
- bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCustom):
- bindings/v8/custom/V8WebKitPointCustom.cpp:
(WebCore::V8WebKitPoint::constructorCustom):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::constructorCustom):
- 2:23 PM Changeset in webkit [143850] by
-
- 50 edits in trunk/Source/WebCore
[V8] Rename xxxCallback() to xxxMethod(), and xxxCallbackCustom() to xxxMethodCustom()
https://bugs.webkit.org/show_bug.cgi?id=110669
Reviewed by Adam Barth.
This is one of steps to insert TRACE_EVENT_STATE()
macros into DOM bindings.
See https://bugs.webkit.org/show_bug.cgi?id=110667#c0
In the new world, "Callback" is used to refer that it
is a function called back by V8. Currently "Callback" is
used for both V8 callbacks, DOM methods and DOM constructors.
This patch fixes the inconsistency.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::Float64ArrayV8Internal::setMethod):
(WebCore):
(WebCore::ConfigureV8Float64ArrayTemplate):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionMethod):
(WebCore):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::itemMethod):
(WebCore::TestEventTargetV8Internal::addEventListenerMethod):
(WebCore::TestEventTargetV8Internal::removeEventListenerMethod):
(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore):
(WebCore::ConfigureV8TestEventTargetTemplate):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalMethod1Method):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::TestInterfaceV8Internal::supplementalMethod3Method):
(WebCore::TestInterfaceV8Internal::supplementalMethod4Method):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::TestMediaQueryListListenerV8Internal::methodMethod):
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::voidMethodMethod):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodWithSequenceArgMethod):
(WebCore::TestObjV8Internal::methodReturningSequenceMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::serializedValueMethod):
(WebCore::TestObjV8Internal::optionsObjectMethod):
(WebCore::TestObjV8Internal::methodWithExceptionMethod):
(WebCore::TestObjV8Internal::customMethodMethod):
(WebCore::TestObjV8Internal::customMethodWithArgsMethod):
(WebCore::TestObjV8Internal::addEventListenerMethod):
(WebCore::TestObjV8Internal::removeEventListenerMethod):
(WebCore::TestObjV8Internal::withScriptStateVoidMethod):
(WebCore::TestObjV8Internal::withScriptStateObjMethod):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionMethod):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionMethod):
(WebCore::TestObjV8Internal::withScriptExecutionContextMethod):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateMethod):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionMethod):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesMethod):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackMethod):
(WebCore::TestObjV8Internal::methodWithOptionalArgMethod):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgMethod):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsMethod):
(WebCore::TestObjV8Internal::methodWithOptionalStringMethod):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedMethod):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringMethod):
(WebCore::TestObjV8Internal::methodWithCallbackArgMethod):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgMethod):
(WebCore::TestObjV8Internal::methodWithCallbackAndOptionalArgMethod):
(WebCore::TestObjV8Internal::conditionalMethod1Method):
(WebCore::TestObjV8Internal::conditionalMethod2Method):
(WebCore::TestObjV8Internal::conditionalMethod3Method):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod3Method):
(WebCore::TestObjV8Internal::overloadedMethod4Method):
(WebCore::TestObjV8Internal::overloadedMethod5Method):
(WebCore::TestObjV8Internal::overloadedMethod6Method):
(WebCore::TestObjV8Internal::overloadedMethod7Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethod9Method):
(WebCore::TestObjV8Internal::overloadedMethod10Method):
(WebCore::TestObjV8Internal::overloadedMethod11Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::classMethodMethod):
(WebCore::TestObjV8Internal::classMethodWithOptionalMethod):
(WebCore::TestObjV8Internal::classMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod12Method):
(WebCore::TestObjV8Internal::classMethodWithClampMethod):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Method):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Method):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Method):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Method):
(WebCore::TestObjV8Internal::stringArrayFunctionMethod):
(WebCore::TestObjV8Internal::domStringListFunctionMethod):
(WebCore::TestObjV8Internal::getSVGDocumentMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::mutablePointFunctionMethod):
(WebCore::TestObjV8Internal::immutablePointFunctionMethod):
(WebCore::TestObjV8Internal::orangeMethod):
(WebCore::TestObjV8Internal::strictFunctionMethod):
(WebCore::TestObjV8Internal::variadicStringMethodMethod):
(WebCore::TestObjV8Internal::variadicDoubleMethodMethod):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextPrototypeProperties):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListMethod):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListMethod):
(WebCore):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::TestTypedefsV8Internal::multiTransferListMethod):
(WebCore::TestTypedefsV8Internal::setShadowMethod):
(WebCore::TestTypedefsV8Internal::methodWithSequenceArgMethod):
(WebCore::TestTypedefsV8Internal::nullableArrayArgMethod):
(WebCore::TestTypedefsV8Internal::funcWithClampMethod):
(WebCore::TestTypedefsV8Internal::immutablePointFunctionMethod):
(WebCore::TestTypedefsV8Internal::stringArrayFunctionMethod):
(WebCore::TestTypedefsV8Internal::stringArrayFunction2Method):
(WebCore::TestTypedefsV8Internal::methodWithExceptionMethod):
(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):
- bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::clearDataMethodCustom):
(WebCore::V8Clipboard::setDragImageMethodCustom):
- bindings/v8/custom/V8ConsoleCustom.cpp:
(WebCore::V8Console::traceMethodCustom):
(WebCore::V8Console::assertMethodCustom):
(WebCore::V8Console::profileMethodCustom):
(WebCore::V8Console::profileEndMethodCustom):
- bindings/v8/custom/V8CryptoCustom.cpp:
(WebCore::V8Crypto::getRandomValuesMethodCustom):
- bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::appendMethodCustom):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::addEventListenerMethodCustom):
(WebCore::V8DOMWindow::removeEventListenerMethodCustom):
(WebCore::V8DOMWindow::postMessageMethodCustom):
(WebCore::V8DOMWindow::toStringMethodCustom):
(WebCore::V8DOMWindow::releaseEventsMethodCustom):
(WebCore::V8DOMWindow::captureEventsMethodCustom):
(WebCore::V8DOMWindow::showModalDialogMethodCustom):
(WebCore::V8DOMWindow::openMethodCustom):
(WebCore::V8DOMWindow::setTimeoutMethodCustom):
(WebCore::V8DOMWindow::setIntervalMethodCustom):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::getInt8MethodCustom):
(WebCore::V8DataView::getUint8MethodCustom):
(WebCore::V8DataView::setInt8MethodCustom):
(WebCore::V8DataView::setUint8MethodCustom):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::V8DedicatedWorkerContext::postMessageMethodCustom):
- bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
(WebCore::V8DeviceMotionEvent::initDeviceMotionEventMethodCustom):
- bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventMethodCustom):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateMethodCustom):
(WebCore::V8Document::createTouchListMethodCustom):
- bindings/v8/custom/V8GeolocationCustom.cpp:
(WebCore::V8Geolocation::getCurrentPositionMethodCustom):
(WebCore::V8Geolocation::watchPositionMethodCustom):
- bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::V8HTMLAllCollection::itemMethodCustom):
(WebCore::V8HTMLAllCollection::namedItemMethodCustom):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextMethodCustom):
(WebCore::V8HTMLCanvasElement::toDataURLMethodCustom):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::writeMethodCustom):
(WebCore::V8HTMLDocument::writelnMethodCustom):
(WebCore::V8HTMLDocument::openMethodCustom):
- bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:
(WebCore::V8HTMLFormControlsCollection::namedItemMethodCustom):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorMethodCustom):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):
- bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::setSelectionRangeMethodCustom):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::namedItemMethodCustom):
(WebCore::V8HTMLOptionsCollection::removeMethodCustom):
(WebCore::V8HTMLOptionsCollection::addMethodCustom):
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::V8HTMLSelectElement::removeMethodCustom):
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateMethodCustom):
(WebCore::V8History::replaceStateMethodCustom):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::inspectedObjectMethodCustom):
(WebCore::V8InjectedScriptHost::internalConstructorNameMethodCustom):
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::functionDetailsMethodCustom):
(WebCore::V8InjectedScriptHost::getInternalPropertiesMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):
(WebCore::V8InjectedScriptHost::inspectMethodCustom):
(WebCore::V8InjectedScriptHost::databaseIdMethodCustom):
(WebCore::V8InjectedScriptHost::storageIdMethodCustom):
(WebCore::V8InjectedScriptHost::evaluateMethodCustom):
(WebCore::V8InjectedScriptHost::setFunctionVariableValueMethodCustom):
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::V8InspectorFrontendHost::platformMethodCustom):
(WebCore::V8InspectorFrontendHost::portMethodCustom):
(WebCore::V8InspectorFrontendHost::showContextMenuMethodCustom):
(WebCore::V8InspectorFrontendHost::recordActionTakenMethodCustom):
(WebCore::V8InspectorFrontendHost::recordPanelShownMethodCustom):
(WebCore::V8InspectorFrontendHost::recordSettingChangedMethodCustom):
- bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
(WebCore::V8JavaScriptCallFrame::evaluateMethodCustom):
(WebCore::V8JavaScriptCallFrame::restartMethodCustom):
(WebCore::V8JavaScriptCallFrame::setVariableValueMethodCustom):
(WebCore::V8JavaScriptCallFrame::scopeTypeMethodCustom):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):
(WebCore::V8Location::reloadMethodCustom):
(WebCore::V8Location::replaceMethodCustom):
(WebCore::V8Location::assignMethodCustom):
(WebCore::V8Location::valueOfMethodCustom):
(WebCore::V8Location::toStringMethodCustom):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::initMessageEventMethodCustom):
(WebCore::V8MessageEvent::webkitInitMessageEventMethodCustom):
- bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::V8MessagePort::postMessageMethodCustom):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):
- bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::requestPermissionMethodCustom):
- bindings/v8/custom/V8NotificationCustom.cpp:
(WebCore::V8Notification::requestPermissionMethodCustom):
- bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemMethodCustom):
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlMethodCustom):
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlMethodCustom):
- bindings/v8/custom/V8SVGLengthCustom.cpp:
(WebCore::V8SVGLength::convertToSpecifiedUnitsMethodCustom):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getBufferParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getExtensionMethodCustom):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getRenderbufferParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsMethodCustom):
(WebCore::V8WebGLRenderingContext::getTexParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::V8WebGLRenderingContext::getVertexAttribMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform1fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform1ivMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform2fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform2ivMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform3fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform3ivMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform4fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform4ivMethodCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix2fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix3fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix4fvMethodCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib1fvMethodCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib2fvMethodCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib3fvMethodCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib4fvMethodCustom):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::importScriptsMethodCustom):
(WebCore::V8WorkerContext::setTimeoutMethodCustom):
(WebCore::V8WorkerContext::setIntervalMethodCustom):
- bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::V8Worker::postMessageMethodCustom):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::openMethodCustom):
(WebCore::V8XMLHttpRequest::sendMethodCustom):
- bindings/v8/custom/V8XSLTProcessorCustom.cpp:
(WebCore::V8XSLTProcessor::setParameterMethodCustom):
(WebCore::V8XSLTProcessor::getParameterMethodCustom):
(WebCore::V8XSLTProcessor::removeParameterMethodCustom):
- 12:44 PM Changeset in webkit [143849] by
-
- 2 edits in trunk/LayoutTests
Skip javascriptDialogEvents.html since its result bleed into other tests non-deterministically per bug 110186.
- platform/mac/TestExpectations:
- 12:41 PM Changeset in webkit [143848] by
-
- 12 edits in trunk/Source/WebCore
Scrollbar style resolution arguments should not passed via statics.
https://bugs.webkit.org/show_bug.cgi?id=110690
Use PseudoStyleRequest to pass scrollbar params for style resolve.
Reviewed by Eric Seidel.
No change in functionality, covered by existing tests.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match): Changed to use context params, rather than statics.
(WebCore::SelectorChecker::checkOne): Changed to pass context to checkScrollbarPseudoClass.
(WebCore::SelectorChecker::checkScrollbarPseudoClass): Changed to use context params, rather than statics.
- css/SelectorChecker.h:
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext): Added scrollbar style args.
(SelectorCheckingContext): Ditto.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Changed to use PseudoStyleRequest.
(WebCore::StyleResolver::State::initForStyleResolve): Ditto.
(WebCore::StyleResolver::pseudoStyleForElement): Ditto.
(WebCore::StyleResolver::ruleMatches): Ditto and added stuffing scrollbar style resolve args into SelectorCheckingContext.
- css/StyleResolver.h:
(PseudoStyleRequest): Added.
(State): Changed to hold and use PseudoStyleRequest instead of just PseudoId
- dom/Element.cpp:
(WebCore::Element::pseudoStyleCacheIsInvalid): Changed to use PseudoStyleRequest.
- page/FrameView.cpp: Ditto.
(WebCore::FrameView::updateScrollCorner): Ditto.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollCornerStyle): Ditto.
(WebCore::RenderLayer::updateResizerStyle): Ditto.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::selectionBackgroundColor): Ditto.
(WebCore::RenderObject::selectionColor): Ditto.
(WebCore::firstLineStyleForCachedUncachedType): Ditto.
(WebCore::RenderObject::getCachedPseudoStyle): Ditto.
(WebCore::RenderObject::getUncachedPseudoStyle): Ditto.
- rendering/RenderObject.h:
(RenderObject): Ditto.
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::getScrollbarPseudoStyle): Ditto.
- rendering/RenderScrollbar.h:
(RenderScrollbar): Removed static members that are now obsolete.
- 12:00 PM Changeset in webkit [143847] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/efl/TestExpectations: Adding a failure expectation for the html5lib/runner.html test
that started failing with r143804.
- platform/gtk/TestExpectations: Ditto. Also adding flaky crasher expectations for two http tests,
crashes are originating from IDB code and starter appearing with r143694.
- 11:57 AM Changeset in webkit [143846] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
https://bugs.webkit.org/show_bug.cgi?id=110605
Reviewed by Adam Barth.
Part of a larger refactoring series; see tracking bug 82948.
- public/WebKit.h:
(WebKit):
- src/WebKit.cpp:
(WebKit::initialize):
(WebKit::initializeWithoutV8):
(WebKit::webKitPlatformSupport):
- 10:37 AM Changeset in webkit [143845] by
-
- 4 edits in trunk/Source/WebCore
Threaded HTML parser should pass fast/parser/parser-yield-timing.html
https://bugs.webkit.org/show_bug.cgi?id=110647
Reviewed by Eric Seidel.
Previously, the threaded HTML parser would run for an arbitrary amount
of time without yielding after speculation succeeded. This might be the
cause of the good DOMContentLoaded numbers.
Note: This patch also demonstrates that the ParseHTML_max numbers
aren't correct currently because they're measuring the interior of this
loop instead of all the time spent in the loop. We should move the
instrumentation in a followup patch.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::resumeParsingAfterYield):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
- html/parser/HTMLParserScheduler.cpp:
- 10:22 AM Changeset in webkit [143844] by
-
- 3 edits1 add in trunk/Source/WebCore
[GTK] Allow sharing the WebCore include list with the Chromium build
https://bugs.webkit.org/show_bug.cgi?id=110241
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-23
Reviewed by Dirk Pranke.
- WebCore.gyp/WebCore.gyp: Moved shared include directories to
WebCore.gypi.
- WebCore.gyp/WebCoreGTK.gyp: Added. A skeleton gyp file for WebCoreGTK+.
- WebCore.gypi: Added shared include directories.
- 9:57 AM Changeset in webkit [143843] by
-
- 64 edits in trunk/Source/WebCore
StyledElement: Tweak signature of collectStyleForPresentationAttribute().
<http://webkit.org/b/110687>
Reviewed by Antti Koivisto.
Out with the old:
collectStyleForPresentationAttribute(const Attribute&, StylePropertySet*)
In with the new:
collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*)
This is primarily about switching to using MutableStylePropertySet* in preparation for
removing mutating functions from the StylePropertySet base class.
- 8:55 AM Changeset in webkit [143842] by
-
- 9 edits1 copy1 add in trunk/Source/WebCore
[EFL][WebGL] Refactor GLPlatformSurface.
https://bugs.webkit.org/show_bug.cgi?id=110616
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-23
Reviewed by Kenneth Rohde Christiansen.
Covered by existing WebGL tests.
With recent changes, there is a clear separation between
transport surface and off-screen surface. PlatformSurface
has the logic to render content to transport surface.
We currently rely on EXT_framebuffer_blit for this. This
extension is not exposed on GLES2.0. PlatformSurface was
supposed to be an abstraction layer without any knowledge
of the type of surface. This patch addresses the issues
in PlatformSurface class. We use shaders to draw texture
content to the surface. Any transport surface related
code in PlatformSurface is moved to GLTransportSurface class.
- PlatformEfl.cmake:
- platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::didResizeCanvas):
- platform/graphics/surfaces/GLTransportSurface.cpp: Added.
(WebCore):
(WebCore::GLTransportSurface::GLTransportSurface):
(WebCore::GLTransportSurface::~GLTransportSurface):
(WebCore::GLTransportSurface::updateContents):
(WebCore::GLTransportSurface::setGeometry):
(WebCore::GLTransportSurface::destroy):
(WebCore::GLTransportSurface::draw):
(WebCore::GLTransportSurface::bindArrayBuffer):
(WebCore::GLTransportSurface::updateTransformationMatrix):
(WebCore::GLTransportSurface::initializeShaderProgram):
- platform/graphics/surfaces/GLTransportSurface.h:
(WebCore):
(GLTransportSurface):
- platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::destroy):
(WebCore::EGLWindowTransportSurface::setGeometry):
- platform/graphics/surfaces/egl/EGLSurface.h:
- platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::setGeometry):
(WebCore::GLXTransportSurface::destroy):
(WebCore::GLXOffScreenSurface::freeResources):
- platform/graphics/surfaces/glx/GLXSurface.h:
- 8:16 AM Changeset in webkit [143841] by
-
- 41 edits25 adds in trunk/LayoutTests
Remove some tests needing to be rebaselined from TestExpectations
- platform/gtk/TestExpectations: Update the list of tests needing new baselines
and skip some that are timing out on my machine.
- platform/gtk/accessibility/color-well-expected.txt: Added.
- platform/gtk/accessibility/image-link-expected.txt: Added.
- platform/gtk/accessibility/image-map1-expected.txt: Added.
- platform/gtk/accessibility/image-map2-expected.txt: Added.
- platform/gtk/accessibility/menu-list-sends-change-notification-expected.txt: Added.
- platform/gtk/accessibility/multiselect-list-reports-active-option-expected.txt: Added.
- platform/gtk/accessibility/notification-listeners-expected.txt: Added.
- platform/gtk/css2.1/t0505-c16-descendant-01-e-expected.png:
- platform/gtk/css2.1/t0505-c16-descendant-01-e-expected.txt:
- platform/gtk/editing/selection/extend-by-sentence-001-expected.png:
- platform/gtk/editing/selection/extend-by-sentence-001-expected.txt: Added.
- platform/gtk/fast/block/float/024-expected.png:
- platform/gtk/fast/block/float/024-expected.txt: Added.
- platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.png:
- platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt: Added.
- platform/gtk/fast/css/resize-corner-tracking-expected.png:
- platform/gtk/fast/css/resize-corner-tracking-expected.txt:
- platform/gtk/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.
- platform/gtk/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
- platform/gtk/fast/inline/drawStyledEmptyInlines-expected.png:
- platform/gtk/fast/inline/drawStyledEmptyInlines-expected.txt:
- platform/gtk/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/gtk/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
- platform/gtk/fast/inline/justify-emphasis-inline-box-expected.png: Added.
- platform/gtk/fast/inline/justify-emphasis-inline-box-expected.txt: Added.
- platform/gtk/fast/repaint/caret-with-transformation-expected.png: Added.
- platform/gtk/fast/repaint/caret-with-transformation-expected.txt: Added.
- platform/gtk/fast/text/capitalize-empty-generated-string-expected.png:
- platform/gtk/fast/text/capitalize-empty-generated-string-expected.txt:
- platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
- platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
- platform/gtk/fast/text/whitespace/006-expected.png:
- platform/gtk/fast/text/whitespace/006-expected.txt:
- platform/gtk/fast/text/whitespace/007-expected.png:
- platform/gtk/fast/text/whitespace/007-expected.txt:
- platform/gtk/media/audio-controls-rendering-expected.png: Added.
- platform/gtk/media/audio-controls-rendering-expected.txt:
- platform/gtk/media/controls-after-reload-expected.txt:
- platform/gtk/media/controls-strict-expected.txt:
- platform/gtk/media/controls-styling-strict-expected.txt:
- platform/gtk/media/controls-without-preload-expected.txt:
- platform/gtk/media/video-controls-rendering-expected.txt:
- platform/gtk/media/video-display-toggle-expected.txt:
- platform/gtk/media/video-playing-and-pause-expected.txt:
- platform/gtk/svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
- platform/gtk/svg/as-image/image-preserveAspectRatio-all-expected.txt: Added.
- platform/gtk/svg/batik/text/xmlSpace-expected.png:
- platform/gtk/svg/batik/text/xmlSpace-expected.txt:
- platform/gtk/svg/carto.net/combobox-expected.png:
- platform/gtk/svg/carto.net/combobox-expected.txt:
- platform/gtk/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/gtk/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.txt: Added.
- platform/gtk/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/gtk/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.txt: Added.
- platform/gtk/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
- platform/gtk/svg/filters/feImage-preserveAspectRatio-all-expected.txt: Added.
- platform/gtk/svg/filters/filter-hidden-content-expected.png: Added.
- platform/gtk/svg/filters/filter-hidden-content-expected.txt: Added.
- platform/gtk/tables/mozilla/bugs/bug113235-3-expected.png:
- platform/gtk/tables/mozilla/bugs/bug113235-3-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
- platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug1318-expected.png:
- platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
- 3:26 AM WebKitGTK/2.0.x edited by
- Add bug #110614 to proposed merges for 1.11.91 (diff)
- 2:49 AM Changeset in webkit [143840] by
-
- 13 edits in trunk/Source/WebCore
ShadowRoot needs guardRef() and guardDeref()
https://bugs.webkit.org/show_bug.cgi?id=109777
Reviewed by Dimitri Glazkov.
This change moves m_guardRefCount from Document to TreeScope,
which allows ShadowRoot to be guarded by guardRef() mechanism as
Document. After r137524, Node referes TreeScope instead of
Document. This is natural consequence of the change: It no longer
makes sense to guardRef() Document pointer from Node.
Detail:
- Document::m_guardRefCount and related funcdtions are moved to TreeScope
- Document::removedLastRef is factored out into TreeScope::removedLastRefToScope(), TreeScope::dispose() and Docuent::dispose(). ShadowRoot also got its own dispose() implementation.
- Moved guardRef() and guardDeref() calls to TreeScope and Node. Note that there are two "guarded" TreeScope references. One is Node::m_treeScope and another is TreeScope::m_parentTreeScope. The guarded-ref management is now encapsulated in these two classes.
No new tests. Covered by existing tests.
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::dispose): Extracted from removedLastRef()
- dom/Document.h:
(WebCore::Node::isTreeScope):
(WebCore::Node::Node):
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::DocumentFragment): Remove ASSERT() and move it to ...
(WebCore::DocumentFragment::create): ... here, to allow NULL document from ShadowRoot.
- dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::removedLastRef):
- dom/Node.h:
(WebCore::Node::setTreeScope):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot): Passed NULL document to superclass. This aligns what Document is doing.
(WebCore::ShadowRoot::dispose): Added.
- dom/ShadowRoot.h:
(ShadowRoot):
- dom/TreeScope.cpp:
(SameSizeAsTreeScope):
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::dispose): Added.
(WebCore::TreeScope::setParentTreeScope):
(WebCore::TreeScope::deletionHasBegun):
(WebCore::TreeScope::beginDeletion):
(WebCore::TreeScope::refCount): Added.
- dom/TreeScope.h: Turned m_rootNode to Node* from ContainerNode* for Node::isTreeScope to be inlined.
(WebCore::TreeScope::guardRef): Pulled up from Document.
(WebCore::TreeScope::guardDeref): Ditto.
(WebCore::TreeScope::hasGuardRefCount): Added to hide m_guardRefCount.
(WebCore::TreeScope::deletionHasBegun): Added.
(WebCore::TreeScope::beginDeletion): Added.
(WebCore::TreeScope::removedLastRefToScope): Pulled up from Document.
- dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
- 1:03 AM Changeset in webkit [143839] by
-
- 2 edits in trunk/Tools
Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.timestamp_of_latest_commit):
- 12:54 AM Changeset in webkit [143838] by
-
- 2 edits in trunk/Source/WebCore
Don't include ResourceHandle.h in ResourceLoaderOptions.h
https://bugs.webkit.org/show_bug.cgi?id=110662
Reviewed by Tim Horton.
- loader/ResourceLoaderOptions.h: Include ResourceHandleTypes.h instead.
- 12:14 AM Changeset in webkit [143837] by
-
- 31 edits in trunk
Source/WebCore: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521
Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.
- testing/Internals.cpp:
(WebCore):
(WebCore::Internals::setAutofilled):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/efl: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521
Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/gtk: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521
Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/qt: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521
Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Tools: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521
Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h:
(TestRunner):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
- DumpRenderTree/mac/TestRunnerMac.mm:
- DumpRenderTree/qt/TestRunnerQt.cpp:
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
- DumpRenderTree/win/TestRunnerWin.cpp:
- DumpRenderTree/wx/TestRunnerWx.cpp:
LayoutTests: Moved setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521
Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.
- fast/forms/input-autofilled.html:
- fast/forms/reset-autofilled.html:
- platform/wk2/TestExpectations:
Feb 22, 2013:
- 10:16 PM Changeset in webkit [143836] by
-
- 43 edits1 copy5 moves3 deletes in trunk/LayoutTests
Rebaseline ports after bug 109994
https://bugs.webkit.org/show_bug.cgi?id=110551
Unreviewed rebaseline of test expectations.
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-22
- css2.1/20110323/replaced-elements-001-expected.txt: Renamed from LayoutTests/platform/mac/css2.1/20110323/replaced-elements-001-expected.txt.
- fast/forms/button-generated-content-expected.txt:
- fast/forms/select-baseline-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/select-baseline-expected.txt.
- platform/chromium-mac-lion/css2.1/20110323/replaced-elements-001-expected.png:
- platform/chromium-mac-lion/fast/forms/button-generated-content-expected.png:
- platform/chromium-mac-lion/fast/forms/select-baseline-expected.png:
- platform/chromium-mac-lion/svg/custom/foreign-object-skew-expected.png:
- platform/chromium-mac-snowleopard/css2.1/20110323/replaced-elements-001-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/button-generated-content-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- platform/chromium-mac/css2.1/20110323/replaced-elements-001-expected.png:
- platform/chromium-mac/fast/forms/button-generated-content-expected.png:
- platform/chromium-mac/fast/forms/select-baseline-expected.png:
- platform/chromium-mac/svg/custom/foreign-object-skew-expected.png:
- platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.png:
- platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.txt:
- platform/chromium-win/fast/forms/button-generated-content-expected.png:
- platform/chromium-win/fast/forms/button-generated-content-expected.txt:
- platform/chromium-win/fast/forms/select-baseline-expected.png:
- platform/chromium-win/fast/forms/select-baseline-expected.txt:
- platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
- platform/chromium-win/svg/custom/foreign-object-skew-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/css2.1/20110323/replaced-elements-001-expected.txt: Removed.
- platform/efl/TestExpectations:
- platform/efl/css2.1/20110323/replaced-elements-001-expected.txt:
- platform/efl/fast/forms/button-generated-content-expected.txt:
- platform/efl/fast/forms/select-baseline-expected.txt:
- platform/efl/svg/custom/foreign-object-skew-expected.txt: Renamed from LayoutTests/platform/mac/svg/custom/foreign-object-skew-expected.txt.
- platform/efl/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/gtk/TestExpectations:
- platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt:
- platform/gtk/fast/forms/button-generated-content-expected.txt:
- platform/gtk/fast/forms/select-baseline-expected.txt:
- platform/gtk/svg/custom/foreign-object-skew-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/fast/forms/select-baseline-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug92647-2-expected.txt: Removed.
- platform/qt/TestExpectations:
- platform/qt/css2.1/20110323/replaced-elements-001-expected.txt:
- platform/qt/fast/forms/button-generated-content-expected.txt:
- platform/qt/fast/forms/select-baseline-expected.txt:
- platform/qt/svg/custom/foreign-object-skew-expected.txt:
- platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/win-future/fast/forms/button-generated-content-expected.txt: Copied from LayoutTests/fast/forms/button-generated-content-expected.txt.
- svg/custom/foreign-object-skew-expected.txt: Renamed from LayoutTests/platform/chromium/svg/custom/foreign-object-skew-expected.txt.
- tables/mozilla/bugs/bug92647-2-expected.txt: Renamed from LayoutTests/platform/chromium/tables/mozilla/bugs/bug92647-2-expected.txt.
- 9:40 PM Changeset in webkit [143835] by
-
- 3 edits in trunk/Source/WebKit/gtk
[GTK] Expose all dependencies to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=110498
Reviewed by Dirk Pranke.
- gyp/Configuration.gypi.in: Add the missing configuration cflags here.
- gyp/Dependencies.gyp: Add targets for all missing dependencies.
- 8:47 PM Changeset in webkit [143834] by
-
- 5 edits in trunk/Source/WebCore
Attr: Simplify modification callbacks.
<http://webkit.org/b/110598>
Reviewed by Antti Koivisto.
Instead of Attr being a friend of Element and grabbing at various internal storage and callbacks,
let Attr simply call Element::setAttribute() when its value is changed, and do all that business
from Element.
- dom/Element.h:
- dom/Element.cpp:
(WebCore::Element::setAttributeInternal):
Call Attr::recreateTextChildAfterAttributeValueChanged() after modifying an attribute value instead
of doing the modification through the Attr node.
- dom/Attr.h:
- dom/Attr.cpp:
(WebCore::Attr::Attr):
(WebCore::Attr::childrenChanged):
Added an m_inChildrenChanged flag so we can prevent infinite callback recursion in childrenChanged().
(WebCore::Attr::setValue):
Call Element::setAttribute() instead of modifying the attribute storage directly.
(WebCore::Attr::recreateTextChildAfterAttributeValueChanged):
Factored out the "remove all children / create a new text child with attribute value" logic into
a separate function.
- 8:28 PM Changeset in webkit [143833] by
-
- 12 edits in trunk/Tools
Upload results to perf.webkit.org in addition to the one specified by --test-results-server
https://bugs.webkit.org/show_bug.cgi?id=108577
Reviewed by Dirk Pranke.
Upload results to perf.webkit.org using new JSON format as well as the host specified by
--test-results-server. The new format is needed to provide extra information perf.webkit.org
need such as the subversion commit time and test URLs. This is a temporarily measure until
we complete the transition and the old JSON format and the code to upload results to
webkit-perf.appspot.com can be deleted.
This patch adds scm.timestamp_of_latest_commit to obtain the timestamp of the latest commit present
in a svn checkout or a git clone. This information is embedded in JSON submitted to perf.webkit.org
so that the app can sort performance test results based on the timestamp of the last commit.
It also changes the repository names returned by port objects to be properly capitalized
human readable names such as WebKit instead of lowercased names such as webkit since these names
are displayed on perf.webkit.org for humans. Several users of this feature has been updated
to explicitly lowercase the names.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.timestamp_of_latest_commit): Added. Obtains the timestamp of the last commit. Unfortunately,
git's timestamp granularity is seconds so we're losing some information compared to using a regular
subversion client. To make matters worse, git doesn't have any option to show ISO-format timestamp in
UTC so we're going to manually fiddle with timezone.
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.timestamp_of_latest_commit): Added.
- Scripts/webkitpy/common/checkout/scm/scm_mock.py:
(MockSCM.timestamp_of_latest_commit): Added.
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(test_timestamp_of_latest_commit): Added a test for Git.timestamp_of_latest_commit.
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.timestamp_of_latest_commit): Added. With svn, all we need to do is to use --xml option and parse
the timestamp which is always in UTC.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGeneratorBase._insert_generic_metadata): Lowercase the name. Note that the name
'chromium' needs to be substituted by 'chrome' for historical reasons.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.repository_paths): Return WebKit instead of webkit as noted above.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.repository_paths): Return Chromium instead of chromium as noted above.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.init): Store the current time in UTC as well as in local time.
(PerfTestsRunner._collect_tests):
(PerfTestsRunner._generate_and_show_results): Retrieve both regular output and one for perf.webkit.org,
and upload them appropriately.
(PerfTestsRunner._generate_results_dict): Store WebKit and Chromium revisions at which tests were ran
in revisions_for_perf_webkit and construct an output for perf.webkit.org.
(PerfTestsRunner._datetime_in_ES5_compatible_iso_format): Added.
(PerfTestsRunner._merge_slave_config_json): Merge slave configuration files into both regular output
and one for perf.webkit.org. Here, we prefix each key with "builder" for perf.webkit.org.
e.g. "processor" would be renamed to "builderProcessor".
(PerfTestsRunner._generate_output_files):
(PerfTestsRunner._upload_json): Added a remote path as an argument since we upload JSONs to /api/report
on perf.webkit.org whereas we upload it to /api/test/report on webkit-perf.appspot.com. Also added the code
to parse response as JSON when possible since perf.webkit.org returns a JSON response as opposed to
webkit-perf.appspot.com which spits out a plaintext response.
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(MainTest._test_run_with_json_output.mock_upload_json): Tolerate perf.webkit.org/api/report for now.
(MainTest._test_run_with_json_output): Store a UTC time as perftestrunner would do.
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Added.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_upload_json): Moved from itegrationtest.py since it really is a unit test. Also added test
cases to parse JSON responses.
(MainTest.test_upload_json.MockFileUploader): Refactored.
(MainTest.test_upload_json.MockFileUploader.reset): Added.
(MainTest.test_upload_json.MockFileUploader.init):
(MainTest.test_upload_json.MockFileUploader.upload_single_text_file):
- 8:14 PM Changeset in webkit [143832] by
-
- 5 edits in trunk/Source
[EFL] Use EINA_LOG instead of fprintf
https://bugs.webkit.org/show_bug.cgi?id=110313
Reviewed by Laszlo Gombos.
Replace fprintf with EINA_LOG.
Source/WebCore:
- platform/efl/NetworkInfoProviderEfl.cpp:
(WebCore::NetworkInfoProviderEfl::startUpdating):
- platform/graphics/efl/CairoUtilitiesEfl.cpp:
(WebCore::evasObjectFromCairoImageSurface):
Source/WebKit/efl:
- ewk/ewk_frame.cpp:
(_ewk_frame_debug):
- 7:43 PM Changeset in webkit [143831] by
-
- 6 edits in tags/Safari-537.31.7/Source
Rollout r143761.
- 7:28 PM Changeset in webkit [143830] by
-
- 2 edits in trunk/Source/WebCore
Threaded HTML parser fails resources/plain-text-unsafe.dat
https://bugs.webkit.org/show_bug.cgi?id=110538
Reviewed by Eric Seidel.
With this patch, the background HTML parser passes all tests in plain-text-unsafe.dat.
No new tests because covered by existing tests.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::tokenExitsSVG):
(WebCore):
(WebCore::tokenExitsMath):
(WebCore::BackgroundHTMLParser::simulateTreeBuilder):
- 7:18 PM Changeset in webkit [143829] by
-
- 2 edits in trunk/Source/WebKit2
Add temporary work around for 32-bit plugins not working in production builds as XPCServices
https://bugs.webkit.org/show_bug.cgi?id=110680
<rdar://problem/13236883>
Reviewed by Anders Carlsson.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::shouldUseXPC):
Temporarily don't use XPC for plug-ins for Safari while we figure out why the
32-bit XPCService is being built universal.
- 7:14 PM Changeset in webkit [143828] by
-
- 2 edits in trunk/Source/WebCore
Correct InspectorInstrumentation for background HTML parser
https://bugs.webkit.org/show_bug.cgi?id=110678
Reviewed by Adam Barth.
resumeParsingAfterScriptExecution potentially calls processParsedChunkFromBackgroundParser multiple times
without yielding. So it is not correct to count each of those as a separate ParseHTML event.
This patch moves the instrumentation outside of the loop.
No new tests because no new functionality.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
- 6:54 PM Changeset in webkit [143827] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove call to detach WebHelperPluginImpl's frame since it is never attached
https://bugs.webkit.org/show_bug.cgi?id=110668
Patch by David Dorwin <ddorwin@chromium.org> on 2013-02-22
Reviewed by Adam Barth.
This fixes http://crbug.com/172764
- src/WebHelperPluginImpl.cpp:
(WebKit::WebHelperPluginImpl::destoryPage):
- 6:48 PM Changeset in webkit [143826] by
-
- 15 edits5 adds in trunk/Source
Factor MediaSource methods out of MediaPlayer & MediaPlayerPrivate and into a new MediaSourcePrivate interface.
https://bugs.webkit.org/show_bug.cgi?id=109857
Reviewed by Adam Barth.
Source/WebCore:
This is a simple refactor that moves MediaSource related methods out of MediaPlayer & MediaPlayerPrivate
so that the MediaSource implementation can be updated without further polluting these interfaces.
MediaSourcePrivate is the new WebCore interface that ports must implement to support the MediaSource API.
No new tests. No user visible behavior has changed.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::duration):
(WebCore::MediaSource::setDuration):
(WebCore::MediaSource::addSourceBuffer):
(WebCore::MediaSource::removeSourceBuffer):
(WebCore::MediaSource::setReadyState):
(WebCore::MediaSource::endOfStream):
(WebCore::MediaSource::buffered):
(WebCore::MediaSource::append):
(WebCore::MediaSource::abort):
(WebCore::MediaSource::setTimestampOffset):
(WebCore::MediaSource::setPrivateAndOpen):
(WebCore):
(WebCore::MediaSource::hasPendingActivity):
(WebCore::MediaSource::stop):
- Modules/mediasource/MediaSource.h:
(MediaSource):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::createMediaPlayer):
(WebCore::HTMLMediaElement::reportMemoryUsage):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- platform/graphics/MediaPlayer.cpp:
(NullMediaPlayerPrivate):
(WebCore::NullMediaPlayerPrivate::load):
(WebCore::MediaPlayer::load):
(WebCore):
(WebCore::MediaPlayer::loadWithNextMediaEngine):
- platform/graphics/MediaPlayer.h:
(WebCore):
(MediaPlayerClient):
(MediaPlayer):
- platform/graphics/MediaPlayerPrivate.h:
(MediaPlayerPrivateInterface):
- platform/graphics/MediaSourcePrivate.h: Added.
(WebCore):
(MediaSourcePrivate): Contains the MediaSource methods extracted from MediaPlayer.
(WebCore::MediaSourcePrivate::MediaSourcePrivate):
(WebCore::MediaSourcePrivate::~MediaSourcePrivate):
Source/WebKit/chromium:
WebMediaSource and WebMediaSource client were created to replace the MediaSource methods in WebMediaPlayer and
WebMediaPlayerClient. This allows the MediaSource implementation to be updated without further polluting the
media player interfaces.
- WebKit.gyp:
- public/WebMediaPlayer.h:
(WebMediaPlayer):
(WebKit::WebMediaPlayer::load):
- public/WebMediaPlayerClient.h:
(WebKit):
- public/WebMediaSource.h: Added.
(WebKit):
(WebMediaSource):
(WebKit::WebMediaSource::~WebMediaSource):
- public/WebMediaSourceClient.h: Added.
(WebKit):
(WebMediaSourceClient):
(WebKit::WebMediaSourceClient::~WebMediaSourceClient):
- src/AssertMatchingEnums.cpp:
- src/WebMediaPlayerClientImpl.cpp:
(WebKit):
(WebMediaSourceClientImpl): Temporary WebMediaSourceClient implementation to keep things working until Chromium
changes land.
(WebKit::WebMediaSourceClientImpl::WebMediaSourceClientImpl):
(WebKit::WebMediaSourceClientImpl::~WebMediaSourceClientImpl):
(WebKit::WebMediaSourceClientImpl::addId):
(WebKit::WebMediaSourceClientImpl::removeId):
(WebKit::WebMediaSourceClientImpl::buffered):
(WebKit::WebMediaSourceClientImpl::append):
(WebKit::WebMediaSourceClientImpl::abort):
(WebKit::WebMediaSourceClientImpl::duration):
(WebKit::WebMediaSourceClientImpl::setDuration):
(WebKit::WebMediaSourceClientImpl::endOfStream):
(WebKit::WebMediaSourceClientImpl::setTimestampOffset):
(WebKit::WebMediaPlayerClientImpl::sourceOpened):
(WebKit::WebMediaPlayerClientImpl::sourceURL):
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- src/WebMediaSourceImpl.cpp: Added.
(WebKit):
(MediaSourcePrivateImpl):
(WebKit::MediaSourcePrivateImpl::~MediaSourcePrivateImpl):
(WebKit::MediaSourcePrivateImpl::MediaSourcePrivateImpl):
(WebKit::MediaSourcePrivateImpl::addId):
(WebKit::MediaSourcePrivateImpl::removeId):
(WebKit::MediaSourcePrivateImpl::buffered):
(WebKit::MediaSourcePrivateImpl::append):
(WebKit::MediaSourcePrivateImpl::abort):
(WebKit::MediaSourcePrivateImpl::duration):
(WebKit::MediaSourcePrivateImpl::setDuration):
(WebKit::MediaSourcePrivateImpl::endOfStream):
(WebKit::MediaSourcePrivateImpl::setTimestampOffset):
(WebKit::WebMediaSourceImpl::WebMediaSourceImpl):
(WebKit::WebMediaSourceImpl::~WebMediaSourceImpl):
(WebKit::WebMediaSourceImpl::open):
- src/WebMediaSourceImpl.h: Added.
(WebKit):
(WebMediaSourceImpl):
- 6:13 PM Changeset in webkit [143825] by
-
- 2 edits in trunk/Source/WebCore
RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset()
https://bugs.webkit.org/show_bug.cgi?id=110673
-and corresponding-
<rdar://problem/13258596>
Reviewed by Sam Weinig.
FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages that
have overflow on the body. We can easily address this by calling it at the
end of RenderLayer::scrollTo().
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
- 6:09 PM Changeset in webkit [143824] by
-
- 2 edits in trunk/Tools
Unreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers and get rid of WinXP Debug testers.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 6:00 PM Changeset in webkit [143823] by
-
- 4 edits in trunk/LayoutTests
More rebaselines after http://trac.webkit.org/changeset/143804.
- html5lib/run-test1-expected.txt:
- html5lib/run-test18-expected.txt:
- html5lib/run-test7-expected.txt:
- 5:59 PM Changeset in webkit [143822] by
-
- 4 edits in trunk
Disable MediaSource on Apple Windows port
https://bugs.webkit.org/show_bug.cgi?id=110494
Reviewed by Tim Horton.
Source/WebKit:
- WebKit.vcxproj/FeatureDefines.props:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- 5:54 PM Changeset in webkit [143821] by
-
- 11 edits4 adds in trunk
WebKit can erroneously strip font-size CSS property from font element with size attribute
https://bugs.webkit.org/show_bug.cgi?id=110657
Reviewed by Justin Garcia.
Source/WebCore:
The bug was caused by ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline
erroneously removing style attributes even on an element such as font that implicitly adds
editing style.
Fixed the bug by removing these elements or attributes when they conflict with the inline
style of the element. This is always safe because implicit style of an element is always
overridden by that of inline style.
Note that when the font element becomes "empty" (i.e. doesn't have any attributes), then
we also want to delete this font element as it doesn't contribute anything to the style.
Test: editing/pasteboard/insert-u-with-text-decoration-none.html
editing/pasteboard/insert-font-with-size-and-css.html
- editing/ApplyStyleCommand.cpp:
(WebCore::isEmptyFontTag): Added ShouldStyleAttributeBeEmpty as an argument. This will
allow removeRedundantStylesAndKeepStyleSpanInline to ignore style attribute when we know
the attribute can be removed.
- editing/ApplyStyleCommand.h: Expose isEmptyFontTag and ShouldStyleAttributeBeEmpty.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::InsertedNodes::didReplaceNode): Added.
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): See above.
- editing/ReplaceSelectionCommand.h:
(InsertedNodes): Added a declaration of didReplaceNode.
LayoutTests:
Added two regression tests to ensure WebKit doesn't erroneously remove inline styles of an element
when its implicit styles differ from the inline styles. Also rebaselined some tests as their results
have progressed.
- editing/pasteboard/insert-u-with-text-decoration-none-expected.txt: Added.
- editing/pasteboard/insert-u-with-text-decoration-none.html: Added.
- editing/pasteboard/insert-font-with-size-and-css-expected.txt: Added.
- editing/pasteboard/insert-font-with-size-and-css.html: Added.
- editing/pasteboard/4744008-expected.txt:
- editing/pasteboard/paste-text-with-style-5-expected.txt:
- editing/pasteboard/paste-text-with-style-5.html:
- editing/pasteboard/style-from-rules-expected.txt:
- editing/pasteboard/style-from-rules.html:
- 5:32 PM Changeset in webkit [143820] by
-
- 2 edits in trunk/Source/WebCore
Remove unused make variable from DerivedSources.make
https://bugs.webkit.org/show_bug.cgi?id=110306
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-22
Reviewed by Alexey Proskuryakov.
r107026 removed the last piece of logic that was guarded with
ENABLE_DASHBOARD_SUPPORT, so now it can be removed from
DerivedSources.make.
Also combined the way ENABLE_ORIENTATION_EVENTS is set to 0
to make it more readable.
No new tests, no new functionality.
- DerivedSources.make:
- 5:15 PM Changeset in webkit [143819] by
-
- 3 edits2 adds in trunk
REGRESSION(r130089): Scrollbar thumb no longer re-rendered on hover
https://bugs.webkit.org/show_bug.cgi?id=109230
Source/WebCore:
In r130089, I accidentally removed the extra check that made scrollbar
parts styles sad. I put it back and made them happy.
Reviewed by Eric Seidel.
Test: fast/css/pseudo-element-selector-scrollbar-hover.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match): Added the check back.
LayoutTests:
Reviewed by Eric Seidel.
- fast/css/pseudo-element-selector-scrollbar-hover-expected.html: Added.
- fast/css/pseudo-element-selector-scrollbar-hover.html: Added.
- 5:10 PM Changeset in webkit [143818] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG::SpeculativeJIT::speculateNumber() should just use SpeculateDoubleOperand instead of doing its own thing
https://bugs.webkit.org/show_bug.cgi?id=110659
Reviewed by Oliver Hunt and Mark Hahnenberg.
This simplifies the code, and also has the effect that if speculateNumber() is called
prior to someone actually using the number in a double context, then the number will
already be up-converted to double and ready to go.
Previously if this ever came up, the subsequent use would have to again branch to see
if the value is tagged as int or tagged as double.
On the other hand, if you ever did speculateNumber() and then used the value as a
JSValue, this will be a slow down now.
I suspect that the former (speculateNumber() and then use as number) is more likely
than the latter (speculateNumber() and then use as JSValue).
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::speculateNumber):
- 5:03 PM Changeset in webkit [143817] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG FixupPhase should have one common hook for knowing if a node is ever being speculated a certain way
https://bugs.webkit.org/show_bug.cgi?id=110650
Reviewed by Mark Hahnenberg.
Changes almost all calls to edge.setUseKind(kind) to be
setUseKindAndUnboxIfProfitable<kind>(edge). This will allow us to use the latter
as a hook for deciding which locals to unbox (webkit.org/b/110433).
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(FixupPhase):
(JSC::DFG::FixupPhase::setUseKindAndUnboxIfProfitable):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::fixDoubleEdge):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):
- 4:57 PM Changeset in webkit [143816] by
-
- 4 edits in trunk/Source
[WK2] The root and page overlay layers should be the size of the view, not the content
https://bugs.webkit.org/show_bug.cgi?id=110660
<rdar://problem/13096456>
Reviewed by Simon Fraser.
Use the view size for the size of the root and page overlay layers.
For one, we never update these layers' sizes when the content size changes, causing size mismatches.
In addition, there's no reason an overlay shouldn't be able to draw outside of the bounds of the content.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
- WebCore.exp.in:
- 4:43 PM Changeset in webkit [143815] by
-
- 11 edits in trunk/Source
pluginLoadStrategy should take a WKDictionaryRef for extensibility
https://bugs.webkit.org/show_bug.cgi?id=110656
<rdar://problem/13265303>
Reviewed by Jessie Berlin.
Source/WebCore:
Export a symbol needed by WebKit2.
- WebCore.exp.in:
Source/WebKit2:
Change pluginLoadStrategy to take a WKDictionaryRef instead of a number of parameters;
this lets us add more plug-in information if needed. Also add the page URL and rename documentURL to frameURL.
- UIProcess/API/C/WKPage.cpp:
(WKPageGetPluginInformationBundleIdentifierKey):
(WKPageGetPluginInformationBundleVersionKey):
(WKPageGetPluginInformationDisplayNameKey):
(WKPageGetPluginInformationFrameURLKey):
(WKPageGetPluginInformationMIMETypeKey):
(WKPageGetPluginInformationPageURLKey):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit):
(WebKit::WebLoaderClient::pluginLoadPolicy):
- UIProcess/WebLoaderClient.h:
(WebLoaderClient):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath):
(WebKit::WebPageProxy::pluginInformationBundleIdentifierKey):
(WebKit):
(WebKit::WebPageProxy::pluginInformationBundleVersionKey):
(WebKit::WebPageProxy::pluginInformationDisplayNameKey):
(WebKit::WebPageProxy::pluginInformationFrameURLKey):
(WebKit::WebPageProxy::pluginInformationMIMETypeKey):
(WebKit::WebPageProxy::pluginInformationPageURLKey):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
(WebKit::WebPage::canPluginHandleResponse):
- 4:35 PM Changeset in webkit [143814] by
-
- 3 edits2 deletes in trunk/LayoutTests
Unreviewed gardening, updating test expecations after r140374.
- platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch: Removed.
- platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
- platform/chromium-win-xp/platform/chromium/fast/events/touch: Removed.
- platform/chromium-win/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
- 4:21 PM Changeset in webkit [143813] by
-
- 4 edits in trunk
Unreviewed, rolling out r143794.
http://trac.webkit.org/changeset/143794
https://bugs.webkit.org/show_bug.cgi?id=110542
debug linux builds broken?
Tools:
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
LayoutTests:
- platform/chromium/TestExpectations:
- 4:00 PM Changeset in webkit [143812] by
-
- 2 edits in trunk/Source/WebCore
Add descriptive names for different addMidpoint use cases
https://bugs.webkit.org/show_bug.cgi?id=110644
Reviewed by Ryosuke Niwa.
Midpoints are used to delineate ranges where we don't add line boxes for contents (collapsed spaces),
and to explicitly split a RenderText into multiple text runs so that text paragraph seperators get
their own line boxes. This patch encapsulates the different cases where midpoints are added to
lineMidpointState into 4 helper functions to make it clearer what's going on in each case.
No new tests. No change in functionality.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::deprecatedAddMidpoint): Original function simply adds a midpoint to the lineMidpointState.
Renaming to deprecated to discourage callers.
(WebCore::startIgnoringSpaces): Adds a midpoint to start collapsing subsequent spaces. Asserts that
we have an even number of midpoints.
(WebCore::stopIgnoringSpaces): Adds the corresponding midpoint from startIgnoringSpaces and asserts
that it's an odd number.
(WebCore::ensureLineBoxInsideIgnoredSpaces): When ignoring spaces and we come across a RenderInline
that needs a line box, this function adds a pair of midpoints which ensures we'll later add a line
box for it.
(WebCore::ensureCharacterGetsLineBox): Adds a pair of midpoints in a text renderer to mark that
the current character needs its own line box. This is used by svg for absolutely positioned
characters, or for text paragraph seperators.
- 3:37 PM Changeset in webkit [143811] by
-
- 2 edits in trunk/Source/WebCore
RenderArena masking has low entropy
https://bugs.webkit.org/show_bug.cgi?id=110394
Reviewed by Oliver Hunt.
No new tests. This is a hardening measure.
- rendering/RenderArena.cpp:
(WebCore::RenderArena::RenderArena):
- 3:28 PM Changeset in webkit [143810] by
-
- 2 edits in trunk/Source/WebKit/chromium
IndexedDB: Remove old SerializedScriptValue-based get() callbacks
https://bugs.webkit.org/show_bug.cgi?id=110626
Reviewed by James Robinson.
Removal now that refactoring is complete.
- public/WebIDBCallbacks.h:
(WebKit):
- 3:21 PM Changeset in webkit [143809] by
-
- 2 edits in trunk/Source/WebCore
Fix the overlay play button position on android
https://bugs.webkit.org/show_bug.cgi?id=110638
Patch by Min Qin <qinmin@chromium.org> on 2013-02-22
Reviewed by Ojan Vafai.
Because we are using flex box, specifying the height is not necessary.
Setting height to 100% will make the enclosure go outside the control panel.
There are no media layout test expecations for android, will do that in another patch.
- css/mediaControlsChromiumAndroid.css:
(video::-webkit-media-controls-overlay-enclosure):
- 3:20 PM Changeset in webkit [143808] by
-
- 2 edits in trunk/WebKitLibraries
Unreviewed. Make WinTools.make stop copying vsprops into nested vsprops folders.
- win/tools/WinTools.make:
- 3:15 PM Changeset in webkit [143807] by
-
- 2 edits24 adds in trunk/LayoutTests
[Chromium] Test expectations for newish tests
Unreviewed test expectations addition.
- platform/chromium-linux-x86/fast/text/decorations-with-text-combine-expected.txt: Added.
- platform/chromium-linux-x86/fast/text/orientation-sideways-expected.txt: Added.
- platform/chromium-linux/fast/text/decorations-with-text-combine-expected.png: Added.
- platform/chromium-linux/fast/text/decorations-with-text-combine-expected.txt: Added.
- platform/chromium-linux/fast/text/orientation-sideways-expected.png: Added.
- platform/chromium-linux/fast/text/orientation-sideways-expected.txt: Added.
- platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.png: Added.
- platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.txt: Added.
- platform/chromium-mac-lion/fast/text/orientation-sideways-expected.png: Added.
- platform/chromium-mac-lion/fast/text/orientation-sideways-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/text/decorations-with-text-combine-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/text/orientation-sideways-expected.txt: Added.
- platform/chromium-mac/fast/text/decorations-with-text-combine-expected.png: Added.
- platform/chromium-mac/fast/text/decorations-with-text-combine-expected.txt: Added.
- platform/chromium-mac/fast/text/orientation-sideways-expected.png: Added.
- platform/chromium-mac/fast/text/orientation-sideways-expected.txt: Added.
- platform/chromium-win-xp/fast/text/decorations-with-text-combine-expected.png: Added.
- platform/chromium-win-xp/fast/text/decorations-with-text-combine-expected.txt: Added.
- platform/chromium-win-xp/fast/text/orientation-sideways-expected.png: Added.
- platform/chromium-win-xp/fast/text/orientation-sideways-expected.txt: Added.
- platform/chromium-win/fast/text/decorations-with-text-combine-expected.png: Added.
- platform/chromium-win/fast/text/decorations-with-text-combine-expected.txt: Added.
- platform/chromium-win/fast/text/orientation-sideways-expected.png: Added.
- platform/chromium-win/fast/text/orientation-sideways-expected.txt: Added.
- platform/chromium/TestExpectations:
- 3:04 PM Changeset in webkit [143806] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix. Added missing #if PLATFORM(CHROMIUM).
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- 3:00 PM Changeset in webkit [143805] by
-
- 3 edits in trunk/Source/WebCore
Document::styleRecalc() and FrameView::layout() should be traced
https://bugs.webkit.org/show_bug.cgi?id=110646
Reviewed by Ojan Vafai.
Document::styleRecalc() and FrameView::layout() are key factors
for web page rendering performance. We should add TRACE_EVENT()
macros to these functions.
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- 2:57 PM Changeset in webkit [143804] by
-
- 33 edits in trunk
Teach the html5lib tests how to test the threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=110643
Reviewed by Adam Barth.
Source/WebCore:
This adds a way to force data: url parsing to go through
the threaded parser, to enable us to test the threaded parser
using the html5lib test harness.
- html/parser/HTMLParserOptions.cpp:
(WebCore::HTMLParserOptions::HTMLParserOptions):
- page/Settings.in:
LayoutTests:
- TestExpectations:
- html5lib/resources/runner.js:
(window.onload):
- html5lib/run-template-expected.txt:
- html5lib/run-test10-expected.txt:
- html5lib/run-test11-expected.txt:
- html5lib/run-test12-expected.txt:
- html5lib/run-test14-expected.txt:
- html5lib/run-test15-expected.txt:
- html5lib/run-test16-expected.txt:
- html5lib/run-test17-expected.txt:
- html5lib/run-test19-expected.txt:
- html5lib/run-test2-expected.txt:
- html5lib/run-test20-expected.txt:
- html5lib/run-test21-expected.txt:
- html5lib/run-test22-expected.txt:
- html5lib/run-test23-expected.txt:
- html5lib/run-test24-expected.txt:
- html5lib/run-test25-expected.txt:
- html5lib/run-test26-expected.txt:
- html5lib/run-test3-expected.txt:
- html5lib/run-test4-expected.txt:
- html5lib/run-test5-expected.txt:
- html5lib/run-test6-expected.txt:
- html5lib/run-test8-expected.txt:
- html5lib/run-test9-expected.txt:
- html5lib/runner-expected.txt:
- platform/chromium/html5lib/run-test1-expected.txt:
- platform/chromium/html5lib/run-test18-expected.txt:
- platform/chromium/html5lib/run-test7-expected.txt:
- 2:42 PM Changeset in webkit [143803] by
-
- 8 edits2 adds in trunk/Source
[chromium] Register newly-created layers for animation
https://bugs.webkit.org/show_bug.cgi?id=106594
Patch by Ali Juma <ajuma@chromium.org> on 2013-02-22
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
(WebKit::WebLayerTreeView::registerForAnimations):
Source/WebKit/chromium:
- WebKit.gyp:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::ChromeClientImpl):
(WebKit::ChromeClientImpl::graphicsLayerFactory):
- src/ChromeClientImpl.h:
(ChromeClientImpl):
- src/GraphicsLayerFactoryChromium.cpp: Added.
(WebKit):
(WebKit::GraphicsLayerFactoryChromium::GraphicsLayerFactoryChromium):
(WebKit::GraphicsLayerFactoryChromium::~GraphicsLayerFactoryChromium):
(WebKit::GraphicsLayerFactoryChromium::createGraphicsLayer):
- src/GraphicsLayerFactoryChromium.h: Added.
(WebKit):
(GraphicsLayerFactoryChromium):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::graphicsLayerFactory):
(WebKit):
(WebKit::WebViewImpl::registerForAnimations):
- src/WebViewImpl.h:
(WebViewImpl):
- 2:39 PM Changeset in webkit [143802] by
-
- 2 edits in trunk/LayoutTests
fast/parser/parser-yield-timing.html doesn't integrate with js-test-pre correctly
https://bugs.webkit.org/show_bug.cgi?id=110645
Reviewed by Eric Seidel.
- fast/parser/parser-yield-timing.html:
- 2:38 PM Changeset in webkit [143801] by
-
- 4 edits2 adds in trunk
Increase the max preferred width of tables to 1000000
https://bugs.webkit.org/show_bug.cgi?id=110545
Reviewed by Emil A Eklund.
Source/WebCore:
Test: fast/table/large-shrink-wrapped-width.html
The old limit of 15000 was picked arbitrarily to avoid overflow.
No need to pick such a small number.
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::computeInstrinsicLogicalWidths):
As best I can tell, this code is just wrong. Removing this makes the
new test pass and doesn't cause any test failure. While we have many
tests that hit this codepath, this code would only
show a difference in the cases where the available container width is
greater then 15000, and I don't think we have any tests that hit that case
other than this new one.
- rendering/TableLayout.h:
LayoutTests:
- fast/table/large-shrink-wrapped-width-expected.txt: Added.
- fast/table/large-shrink-wrapped-width.html: Added.
- 2:38 PM Changeset in webkit [143800] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r143654): some fast/js test crashes on 32 bit build
https://bugs.webkit.org/show_bug.cgi?id=110590
Reviewed by Mark Hahnenberg.
In compileValueToInt32, the refactoring in r143654 undid one of the fixes from
r143314 due to a merge goof.
In speculateNumber, we were simply forgetting to indicate that we need a
ManualOperandSpeculation on a JSValueOperand. ManualOperandSpeculation should
be passed whenever you will be performing the type checks yourself rather than
using the operand class to do it for you.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::speculateNumber):
- 2:30 PM Changeset in webkit [143799] by
-
- 2 edits in trunk/LayoutTests
[chromium] Update test expectations for XP after 143554
https://bugs.webkit.org/show_bug.cgi?id=110636
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 2:19 PM Changeset in webkit [143798] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp
Merge 143512
IndexedDB: Limit LevelDB's max open files
https://bugs.webkit.org/show_bug.cgi?id=109993
Reviewed by Tony Chang.
LevelDB keeps up to 1000 (by default) data files open at a time to
avoid having to open() them. This has caused chromium to hit the
process-wide open file limit. This patch changes max_open_files to 20,
as that's the minimum permitted by LevelDB and we have no reason to
think that performance will suffer because of the extra open calls.
No new tests - a chromium browser test that tracks the open LevelDB
files is plausible but is blocked on http://crbug.com/177249/.
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::openDB):
TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/12326083
- 2:17 PM Changeset in webkit [143797] by
-
- 5 edits in trunk/Source/WebCore
Threaded HTML parser should pass fast/parser/iframe-sets-parent-to-javascript-url.html
https://bugs.webkit.org/show_bug.cgi?id=110637
Reviewed by Eric Seidel.
With the main thread parser, we always parse the first chunk of content
returned as the result of evaluating a JavaScript URL synchronously. In
particular, if the first chunk has an inline script, we'll execute it
synchronously.
Previous to this patch, the threaded parser would always parse this
content asynchronously. It's conceivable that there could be some
content relying on the synchronous behavior, so this patch introduces
the notion of "pinning" a parser to the main thread and uses that
concept to force the result of JavaScript URLs to be parsed on the main
thread (which is probably desirable anyway because they're likely to be
quite short).
This patch fixes fast/parser/iframe-sets-parent-to-javascript-url.html
and fast/dom/javascript-url-crash-function.html with the threaded
parser with --enable-threaded-html-parser.
- dom/DocumentParser.h:
(WebCore::DocumentParser::pinToMainThread):
(DocumentParser):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore):
(WebCore::HTMLDocumentParser::pinToMainThread):
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
(WebCore::HTMLDocumentParser::shouldUseThreading):
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
- 2:16 PM Changeset in webkit [143796] by
-
- 7 edits in trunk/Source/WebCore
[BlackBerry] Reread cookies when retrying a request with new auth credentials
https://bugs.webkit.org/show_bug.cgi?id=110628
Patch by Joe Mason <jmason@rim.com> on 2013-02-22
Reviewed by George Staikos.
Internal PR: 298805
Internally Reviewed By: Leo Yang
The "isRedirect" parameter of initializePlatformRequest is only used to decide whether to
reread cookies. Since we must reread cookies when resending a request with new auth
credentials as well, rename this to "rereadCookies".
The only caller which sets this parameter rather than using the default value is
NetworkManager::startJob, which also has other processing on redirect. So add a new
"rereadCookies" parameter to startJob and ensure it is always set to true on a redirect, but
can also be set to true on a non-redirect. And when startJob is called due to new auth
credentials, set it to true.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::startNewJobWithRequest): Add rereadCookies parameter, pass it to
startJob.
(WebCore::NetworkJob::handleRedirect): Set new rereadCookies param of startNewJob to true.
(WebCore::NetworkJob::notifyChallengeResult): Set new rereadCookies param of startNewJob to
true.
- platform/network/blackberry/NetworkJob.h:
(NetworkJob): Add rereadCookies parameter to startNewJobWithRequest.
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob): Add rereadCookies parameter, pass it instead of
redirectCount to initializePlatformRequest.
- platform/network/blackberry/NetworkManager.h:
(NetworkManager): Add rereadCookies parameter to startJob.
- platform/network/blackberry/ResourceRequest.h:
(ResourceRequest): Rename isRedirect parameter to rereadCookies.
- platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest): Rename isRedirect to rereadCookies.
- 2:15 PM Changeset in webkit [143795] by
-
- 2 edits in trunk/Source/WebCore
Use CFNotificationCenter instead of NSNotificationCenter for SharedTimerIOS
https://bugs.webkit.org/show_bug.cgi?id=110544
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-22
Reviewed by Daniel Bates.
Previously, we were instantiating the Obj-C object WebCoreResumeNotifierIOS
with the only purpose of forwarding one notification to a C function.
This patch updates the code to use CFNotificationCenter to dispatch the notification
without the intermediary object.
- platform/ios/SharedTimerIOS.mm:
(WebCore::applicationDidBecomeActive):
(WebCore::setSharedTimerFireInterval):
- 2:12 PM Changeset in webkit [143794] by
-
- 4 edits in trunk
[chromium] enable the fixed version of freetype on linux
https://bugs.webkit.org/show_bug.cgi?id=110542
Reviewed by Tony Chang.
Tools:
Switch to building with a fixed version of FreeType for
just DumpRenderTree. This allows us to share one version
of pixel baselines for both Lucid and Precise, and run
the layout tests in a stock Precise install (instead of a Lucid
chroot). Going forward, this approach isolates us from os-level
changes to the version of FreeType. Note that Chromium itself
still uses the system FreeType and is unaffected by this change.
This setting can still be turned off (at compile/gyp-time) by
manually setting use_custom_freetype=0.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
LayoutTests:
Add entries for two tests that pass on Lucid but fail on Precise
even with the Freetype change. This isn't worth adding in
Lucid and Precise keywords for just these two tests.
- platform/chromium/TestExpectations:
- 2:10 PM Changeset in webkit [143793] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Expose shadowRoot to the WebKit API
https://bugs.webkit.org/show_bug.cgi?id=110522
Reviewed by Dimitri Glazkov.
- public/WebElement.h:
(WebElement):
- src/WebElement.cpp:
(WebKit::WebElement::shadowRoot):
(WebKit):
- 2:10 PM Changeset in webkit [143792] by
-
- 6 edits10 adds in trunk
Uint8ClampedArray constructor is wrong in WorkerContext.idl
https://bugs.webkit.org/show_bug.cgi?id=110634
Reviewed by Adam Barth.
Source/WebCore:
Tests: fast/canvas/webgl/typed-arrays-in-workers.html
webgl/conformance/typedarrays/typed-arrays-in-workers.html
- workers/WorkerContext.idl:
LayoutTests:
Added copy of new WebGL conformance test both in old location
(fast/canvas/webgl) and new location (webgl -- not yet being run
on any ports) to avoid losing test coverage after cutover.
- fast/canvas/webgl/array-unit-tests.html:
- fast/canvas/webgl/resources/typed-array-test-cases.js: Added.
- fast/canvas/webgl/resources/typed-array-worker.js: Added.
(constructTypedArray):
(constructDataView):
(onmessage):
- fast/canvas/webgl/typed-arrays-in-workers-expected.txt: Added.
- fast/canvas/webgl/typed-arrays-in-workers.html: Added.
- webgl/conformance/typedarrays/typed-arrays-in-workers-expected.txt: Added.
- webgl/conformance/typedarrays/typed-arrays-in-workers.html: Added.
- webgl/resources/webgl_test_files/conformance/typedarrays/00_test_list.txt:
- webgl/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html:
- webgl/resources/webgl_test_files/conformance/typedarrays/resources/typed-array-test-cases.js: Added.
- webgl/resources/webgl_test_files/conformance/typedarrays/resources/typed-array-worker.js: Added.
(constructTypedArray):
(constructDataView):
(onmessage):
- webgl/resources/webgl_test_files/conformance/typedarrays/typed-arrays-in-workers.html: Added.
- 2:07 PM Changeset in webkit [143791] by
-
- 2 edits in trunk/Source/WebCore
Add some checks to DatabaseTracker::getMaxSizeForDatabase() to ensure
that it returns a sane value.
https://bugs.webkit.org/show_bug.cgi?id=110557.
Reviewed by Geoffrey Garen.
No layout test, but there is a quota-test.html attached to bugzilla.
The test is a webpage that can be loaded into multiple tabs to
consuming storage space. Once the test webpages are loaded, you will
need to monitor the database directory and its files to confirm that
growth is bounded. Also try reloading the test in the tabs. At no
time should any database file ever exceed the quota.
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
- 2:06 PM Changeset in webkit [143790] by
-
- 11 edits in trunk
Source/WebKit2: Move pluginLoadPolicy to the page loader client
https://bugs.webkit.org/show_bug.cgi?id=110635
<rdar://problem/13265303>
Reviewed by Sam Weinig.
Move the pluginLoadPolicy callback to the page loader client where it belongs.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::toWKPluginLoadPolicy):
(WebKit):
(WebKit::toPluginModuleLoadPolicy):
(WebKit::WebLoaderClient::pluginLoadPolicy):
- UIProcess/WebLoaderClient.h:
(WebLoaderClient):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath):
- UIProcess/WebUIClient.cpp:
(WebKit):
- UIProcess/WebUIClient.h:
(WebUIClient):
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Tools: Move pluginLoadPolicy to the page loader client
https://bugs.webkit.org/show_bug.cgi?id=110635
Reviewed by Sam Weinig.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):
- 2:00 PM Changeset in webkit [143789] by
-
- 3 edits2 adds in trunk
Preloads should be cleared when JavaScript cancels loading prematurely.
https://bugs.webkit.org/show_bug.cgi?id=110388
Reviewed by Antti Koivisto.
Source/WebCore:
If a page preloads a resource, but JavaScript aborts parsing for any reason (for example, a
redirect or document.write()), the resource is forever marked a preload and won't be reloaded
even if it's explicitly marked no-cache and the page is reloaded.
Test: http/tests/cache/preload-cleared-after-parrsing-canceled-by-js.html
- dom/Document.cpp:
(WebCore::Document::implicitClose):
(WebCore::Document::finishedParsing):
LayoutTests:
- http/tests/cache/preload-cleared-after-parrsing-canceled-by-js-expected.txt: Added.
- http/tests/cache/preload-cleared-after-parrsing-canceled-by-js.html: Added.
- 1:50 PM Changeset in webkit [143788] by
-
- 3 edits in trunk/LayoutTests
Expect editing/spelling/spelling-changed-text.html to fail on Qt and GTK
https://bugs.webkit.org/show_bug.cgi?id=110447
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-22
Reviewed by Ryosuke Niwa.
Qt and GTK layout tests do not mark the word "wellcome" as a misspelling in
editing/spelling/spelling-changed-text.html layout test. This patch disables
editing/spelling/spelling-changed-text.html on Qt and GTK platforms.
- platform/gtk/TestExpectations: Mark editing/spelling/spelling-changed-text.html as [ Failure ].
- platform/qt/TestExpectations: Mark editing/spelling/spelling-changed-text.html as [ Failure ].
- 1:45 PM Changeset in webkit [143787] by
-
- 3 edits in trunk/Source/WebCore
Expose a list of all reasons that qualify a RenderLayer to be composited
https://bugs.webkit.org/show_bug.cgi?id=110505
Expose the various reasons that can qualify a RenderLayer to be composited
via a new bitmask returned by the reasonForCompositing() method on
RenderLayerCompositor. This method already existed and was used for logging
purposes, but the previous functionality is now accessed via the
logReasonForCompositing() method.
This will allow the the InspectorLayerTreeAgent to provide this information
to the front-end on a per-layer basis as requested by the front-end.
Reviewed by Simon Fraser.
No new tests.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore):
(WebCore::RenderLayerCompositor::logReasonsForCompositing):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 1:41 PM Changeset in webkit [143786] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Eliminate invalid clipping for content editable selections
https://bugs.webkit.org/show_bug.cgi?id=110630
Reviewed by Rob Buis.
PR 284629.
Remove selection clipping for content editable
fields as the bounds aren't valid and cause
clipping based on starting node rather than the
union of nodes.
Reviewed Internally by Nima Ghanavatian.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::updateFormState):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):
- 1:38 PM Changeset in webkit [143785] by
-
- 2 edits in trunk/Source/WebCore
ScrollingStateTree::rootStateNode() should be null-checked since it can be null
https://bugs.webkit.org/show_bug.cgi?id=110631
Reviewed by Simon Fraser.
This is a speculative fix for <rdar://problem/13233090> and
<rdar://problem/12519348>. It is totally possible for rootStateNode() to be null,
so we should null-check it.
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinatorMac::syncChildPositions):
- 1:30 PM Changeset in webkit [143784] by
-
- 2 edits in trunk/Source/WebCore
Check for null-device when calling createCompatibleDevice
https://bugs.webkit.org/show_bug.cgi?id=107981
Reviewed by James Robinson.
No new tests. Current tests provided coverage. Site in the wild triggered the failure
(cairo failed to allocate a huge surface).
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- 1:24 PM Changeset in webkit [143783] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry]Adjust fatfinger detection rect size
https://bugs.webkit.org/show_bug.cgi?id=108678.
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-02-22
Reviewed by Antonio Gomes.
Changing HitTestRequest::IgnoreClipping does not solve the problem that
FatFinger rect detect the element out of the viewport. We have to clip
the fatfinger rect according to the current viewport size to avoid picking
the element out of the viewport.
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::fingerRectForPoint):
(BlackBerry::WebKit::FatFingers::findBestPoint):
(BlackBerry::WebKit::FatFingers::getAdjustedPaddings):
(BlackBerry::WebKit::FatFingers::getNodesFromRect):
- WebKitSupport/FatFingers.h:
- 1:20 PM Changeset in webkit [143782] by
-
- 1 edit3 adds in trunk/LayoutTests
Add script to generate LayoutTests from WebGL Conformance Tests
https://bugs.webkit.org/show_bug.cgi?id=110525
Patch by Gregg Tavares <Gregg Tavares> on 2013-02-22
Reviewed by Kenneth Russell.
Adds the script generate-webgl-tests.py which given a path
to the WebGL Conformance 'sdk/tests' folder generates and
or updates LayoutTests for WebGL. Example
git clone git://github.com/KhronosGroup/WebGL.git
generate-webgl-tests.py -w WebGL/sdk/tests -e
- webgl/generate-webgl-tests.py: Added.
(ReadFile):
(WriteFile):
(CopyTree):
(FileReader):
(GreaterThanOrEqualToVersion):
(GetTestList):
(main):
- webgl/resources/webgl-expectation-template.txt: Added.
- webgl/resources/webgl-wrapper-template.html: Added.
- 12:49 PM Changeset in webkit [143781] by
-
- 15 edits in trunk/Source
AudioDestination::create() needs extra device identification information for live/local input streams
https://bugs.webkit.org/show_bug.cgi?id=109494
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebMediaStreamSource.h:
(WebMediaStreamSource):
Source/WebCore:
AudioDestination::create() supports live/local audio input. But, since there may be multiple
audio input devices available, an identifier for the requested input device needs to be
passed in. The embedder may then use this information so that the proper audio hardware is
accessed.
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaStreamSource):
- Modules/webaudio/AudioDestinationNode.h:
(AudioDestinationNode):
- Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::initialize):
(WebCore::DefaultAudioDestinationNode::createDestination):
(WebCore::DefaultAudioDestinationNode::enableInput):
- Modules/webaudio/DefaultAudioDestinationNode.h:
(DefaultAudioDestinationNode):
- Modules/webaudio/OfflineAudioDestinationNode.h:
- platform/audio/AudioDestination.h:
(AudioDestination):
- platform/audio/chromium/AudioDestinationChromium.cpp:
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
- platform/audio/chromium/AudioDestinationChromium.h:
(AudioDestinationChromium):
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestination::create):
- platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::create):
- platform/chromium/support/WebMediaStreamSource.cpp:
(WebKit::WebMediaStreamSource::deviceId):
(WebKit):
(WebKit::WebMediaStreamSource::setDeviceId):
- platform/mediastream/MediaStreamSource.h:
(WebCore::MediaStreamSource::deviceId):
(WebCore::MediaStreamSource::setDeviceId):
(MediaStreamSource):
- 12:44 PM Changeset in webkit [143780] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Removed expectations for tests that now pass. Adjusted an expectation for a flaky crasher.
Marked a few more sputnik tests as slow.
- platform/gtk-wk1/TestExpectations:
- platform/gtk/TestExpectations:
- 12:41 PM Changeset in webkit [143779] by
-
- 2 edits1 copy in trunk/LayoutTests
Mac WebKit2 rebaselines.
Partially revert http://trac.webkit.org/changeset/143709 since the expected result for
cross-origin-local-storage-wk1-expected.txt is different on Mac WebKit on the contrary to
the change log description in the changeset.
Also skip editing/spelling/spelling-changed-text.html on Mac since the test requires
the support for asynchronous spellchecking.
- platform/mac-wk2/http/tests/security/cross-origin-local-storage-wk1-expected.txt: Copied
from platform/mac/http/tests/security/cross-origin-local-storage-wk1-expected.txt.
- platform/mac/TestExpectations:
- 12:37 PM Changeset in webkit [143778] by
-
- 4 edits in branches/chromium/1410/Source/WebKit/chromium
Merge 143355
[chromium] Fix races in double-tap zoom minimum scale policy
https://bugs.webkit.org/show_bug.cgi?id=110183
Reviewed by Adam Barth.
Double-tap zoom on Android is supposed to return to minimum scale
if no pinch zoom occurred since the last double-tap. Because both
pinch zoom and the result of double-tap zoom gets passed in from CC
via applyScrollAndScale, this logic was brittle and prone to races
depending on when the animation update was received. This patch
keeps track of what the target double-tap scale is to make it more
robust.
I also fixed double-tap zoom test mocking to exercise the entire
page scale animation flow (our previous way of testing was hiding the
raciness), and added a new test case in DivAutoZoomMultipleParamsTest.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::startPageScaleAnimation):
(WebKit):
(WebKit::WebViewImpl::enableFakeDoubleTapAnimationForTesting):
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
(WebKit::WebViewImpl::animateZoomAroundPoint):
(WebKit::WebViewImpl::didCommitLoad):
(WebKit::WebViewImpl::applyScrollAndScale):
- src/WebViewImpl.h:
(WebViewImpl):
(WebKit::WebViewImpl::fakeDoubleTapAnimationPendingForTesting):
(WebKit::WebViewImpl::fakeDoubleTapTargetPositionForTesting):
(WebKit::WebViewImpl::fakeDoubleTapPageScaleFactorForTesting):
(WebKit::WebViewImpl::fakeDoubleTapUseAnchorForTesting):
- tests/WebFrameTest.cpp:
TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/12330082
- 12:35 PM Changeset in webkit [143777] by
-
- 3 edits in branches/chromium/1410/Source/WebKit/chromium
Merge 143032
[chromium] WebInputEventBuilders should not reverse page scale
https://bugs.webkit.org/show_bug.cgi?id=109901
Reviewed by James Robinson.
Though in theory logical that if WebInputEvent -> PlatformEvent
conversions divide by page scale, then the reverse builders should
multiply, in reality the only user of the reverse builders is
plugins which expect the same coordinate space as WebCore.
- src/WebInputEventConversion.cpp:
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
- tests/WebInputEventConversionTest.cpp:
(WebCore::TEST):
TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/12330081
- 12:34 PM Changeset in webkit [143776] by
-
- 4 edits in branches/chromium/1410/Source/WebKit/chromium
Merge 142927
[chromium] No triggering autofill on unfocus
https://bugs.webkit.org/show_bug.cgi?id=109735
Patch by David Trainor <dtrainor@chromium.org> on 2013-02-14
Reviewed by James Robinson.
Need to notify the autofill client to not process text changes when we're setting
focus to false and are trying to commit a composition.
- public/WebAutofillClient.h:
(WebAutofillClient):
(WebKit::WebAutofillClient::setIgnoreTextChanges):
(WebKit::WebAutofillClient::~WebAutofillClient):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setFocus):
- tests/WebViewTest.cpp:
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12340032
- 12:33 PM Changeset in webkit [143775] by
-
- 4 edits in branches/chromium/1410/Source/WebKit/chromium
Merge 142913
[chromium] Fix scaling in WebViewImpl::handleGestureEvent, second try
https://bugs.webkit.org/show_bug.cgi?id=109671
Reviewed by James Robinson.
My patch 142571 broke a bunch of things in handleGestureEvent that
assumed the event came in scaled, most notably tap highlight and
double-tap zoom. Switch those to PlatformGestureEvent.
142808 was an earlier version of this patch that was reverted
due to fling events asserting they can't be converted to
PlatformGestureEvent. This version moves fling earlier in the
function to avoid that.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::bestTapNode):
(WebKit::WebViewImpl::enableTapHighlight):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/LinkHighlightTest.cpp:
(WebCore::TEST):
TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/12315056
- 12:31 PM Changeset in webkit [143774] by
-
- 5 edits in branches/chromium/1410/Source/WebKit/chromium
Merge 142571
[chromium] Apply page scale to all WebInputEvent types
https://bugs.webkit.org/show_bug.cgi?id=109370
Reviewed by James Robinson.
Previously we only adjusted a few common input event types by page
scale, but in fact almost every position and size in WebInputEvents
requires it.
I also took the opportunity to change some WebGestureEvent members to
floats (which I checked causes no warnings in Chromium-side code with
GCC or Clang).
New WebInputEventConversionTest: InputEventsScaling
- public/WebInputEvent.h:
(WebKit::WebGestureEvent::WebGestureEvent):
- src/WebInputEventConversion.cpp:
(WebKit::widgetScaleFactor):
(WebKit):
(WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
(WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::hasTouchEventHandlersAt):
(WebKit::WebViewImpl::handleInputEvent):
- tests/WebInputEventConversionTest.cpp:
(WebCore::TEST):
(WebCore):
TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/12319074
- 12:30 PM Changeset in webkit [143773] by
-
- 2 edits2 adds in trunk/LayoutTests
Add a Mac baseline for the test added in r142955.
- platform/mac/TestExpectations:
- platform/mac/svg/filters/filter-hidden-content-expected.png: Added.
- platform/mac/svg/filters/filter-hidden-content-expected.txt: Added.
- 12:28 PM Changeset in webkit [143772] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Marking a bunch of (mostly Sputnik) tests as slow.
- 12:22 PM Changeset in webkit [143771] by
-
- 15 edits in trunk/Source/WebCore
Binding tests rebaseline after r143737.
- bindings/scripts/test/V8/V8Float64Array.cpp:
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
- bindings/scripts/test/V8/V8TestException.cpp:
- bindings/scripts/test/V8/V8TestInterface.cpp:
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
- bindings/scripts/test/V8/V8TestNode.cpp:
- bindings/scripts/test/V8/V8TestObj.cpp:
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
- 12:18 PM Changeset in webkit [143770] by
-
- 6 edits in trunk
INPUT_MULTIPLE_FIELDS_UI: Unable to enter "24" to hour field
https://bugs.webkit.org/show_bug.cgi?id=110431
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-02-22
Reviewed by Kent Tamura.
Source/WebCore:
Fixed a bug that hour-field does not accept "24" as a valid input when hour format is 1-24.
To test <input> against different time formats, added "pattern" attribute to DateTimeEditElement.
Test: fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue): Overwrites layoutParameters.dateTimeFormat by pattern attribute of DateTimeEditElement (if exists).
- html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeHourFieldElement::populateDateTimeFieldsState): Fixed a bug where AM/PM value was passed to setHour().
(WebCore::DateTimeHourFieldElement::setValueAsInteger): Clamps the given value to 0-24 when the range of the field is 1-12 or 1-24. Renamed the parameter as it may not be an hour23 value (0-23).
LayoutTests:
Added test cases for hour formats 0-11 and 1-24.
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:
- 12:08 PM Changeset in webkit [143769] by
-
- 2 edits in trunk/Tools
Unreviewed. Changed gman's primary address for auto-complete in Bugzilla.
- Scripts/webkitpy/common/config/committers.py:
- 12:05 PM Changeset in webkit [143768] by
-
- 2 edits in trunk/Source/JavaScriptCore
Not reviewed.
Fix the 32-bit build by using the right data type in more places.
- runtime/CodeCache.h:
(CodeCacheMap):
- 11:59 AM Changeset in webkit [143767] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Accept key events even when composing region is active.
https://bugs.webkit.org/show_bug.cgi?id=110617
Reviewed by Rob Buis.
PR 293598.
Don't reject key events that arrive when composing region is active,
this can prevent navigation events from firing, instead end
the composition and process the key.
Reviewed Internally by Nima Ghanavatian.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::updateFormState):
- 11:53 AM Changeset in webkit [143766] by
-
- 5 edits2 adds in trunk
[CSS Regions] Region boxes should respect -shape-inside CSS property
https://bugs.webkit.org/show_bug.cgi?id=107880
Reviewed by David Hyatt.
The shape-inside CSS property modifies the shape of the inner inline flow content from rectangular content box
to an arbitrary geometry. The detailed documentation is located in the CSS-Exclusions specification:
http://dev.w3.org/csswg/css3-exclusions/#shape-inside-property. This change adds support for the shape-inside property
on CSS Regions.
Source/WebCore:
Test: fast/regions/shape-inside-on-regions.html
- rendering/ExclusionShapeInfo.cpp:
(WebCore):
(WebCore::::logicalTopOffset): Shape dimension should be relative to the current region.
- rendering/ExclusionShapeInfo.h:
(ExclusionShapeInfo):
(WebCore::::logicalTopOffset): Move the implementation to ExclusionShapeInfo.cpp.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::logicalHeightForLine): Move the function prior to layoutExclusionShapeInsideInfo, since we need to use it there.
(WebCore):
(WebCore::layoutExclusionShapeInsideInfo): Add support for cases when shape-inside is a region-block property.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Update the exclusion shape information for every line, since the content
could flow through several region containers which can have different shape-inside properties.
LayoutTests:
- fast/regions/shape-inside-on-regions-expected.html: Added.
- fast/regions/shape-inside-on-regions.html: Added.
- 11:51 AM Changeset in webkit [143765] by
-
- 2 edits in trunk/Source/JavaScriptCore
Not reviewed.
Fix the 32-bit build by using the right data type.
- runtime/CodeCache.h:
(JSC::CodeCacheMap::find):
- 11:48 AM Changeset in webkit [143764] by
-
- 2 edits in trunk/Source/WebKit2
Two video contollers appear after exiting the fullscreen video when using menubar to exit.
https://bugs.webkit.org/show_bug.cgi?id=110506
Reviewed by Eric Carlson.
When we are notified that the fullscreen window is about to exit fullscreen mode unrequested,
call requestExitFullScreen(), as that will result in Document::webkitExitFullScreen() correctly
tearing down the fullscreen state.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
- 11:44 AM Changeset in webkit [143763] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
Mac OS build broken by new ExpressionParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=110629
Unreviewed build fix. Regenerated ExpressionParser with Bison 2.3.
- src/compiler/preprocessor/ExpressionParser.cpp:
- 11:40 AM Changeset in webkit [143762] by
-
- 7 edits in trunk/Source/WebCore
Add computeInstrinsicLogicalWidths functions to TableLayout subclasses
https://bugs.webkit.org/show_bug.cgi?id=110520
Reviewed by Tony Chang.
This is just a refactor in preparation for adding RenderTable::computeIntinsicLogicalWidths.
No change in behavior.
Split the computePreferredLogicalWidths functions into a computeIntinsicLogicalWidths
and a applyPreferredLogicalWidthQuirks. Also, move the addition of bordersPaddingAndSpacing
into RenderTable since both TableLayout subclasses need this.
This has the added readability benefit of better isolating the quirks that each table layout
mode requires.
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::AutoTableLayout::applyPreferredLogicalWidthQuirks):
- rendering/AutoTableLayout.h:
(AutoTableLayout):
- rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::computeIntrinsicLogicalWidths):
(WebCore::FixedTableLayout::applyPreferredLogicalWidthQuirks):
- rendering/FixedTableLayout.h:
(FixedTableLayout):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computePreferredLogicalWidths):
- rendering/TableLayout.h:
(TableLayout):
- 11:25 AM Changeset in webkit [143761] by
-
- 6 edits in tags/Safari-537.31.7/Source
Merged r143650. <rdar://problem/13250271>
- 11:16 AM Changeset in webkit [143760] by
-
- 4 edits3 copies in tags/Safari-537.31.7
Merged r143269. <rdar://problem/13146994>
- 11:16 AM Changeset in webkit [143759] by
-
- 3 edits in trunk/Source/JavaScriptCore
Code cache size should adapt to workload
https://bugs.webkit.org/show_bug.cgi?id=110560
Reviewed by Antti Koivisto.
(*) 5% PLT arithmetic mean speedup
(*) 10% PLT geometric mean speedup
(*) 3.4X microbenchmark speedup
(*) Reduces initial cache capacity by 16X
- runtime/CodeCache.cpp:
(JSC::CodeCache::CodeCache): Updated for interface change.
- runtime/CodeCache.h:
(JSC::SourceCodeValue::SourceCodeValue):
(SourceCodeValue): Turned the cache value into a struct so it can track its age.
(CodeCacheMap):
(JSC::CodeCacheMap::CodeCacheMap):
(JSC::CodeCacheMap::find):
(JSC::CodeCacheMap::set):
(JSC::CodeCacheMap::clear):
(JSC::CodeCacheMap::pruneIfNeeded):
(CodeCache): Grow and shrink in response to usage.
- 11:14 AM Changeset in webkit [143758] by
-
- 4 edits in tags/Safari-537.31.7/Source/JavaScriptCore
Merged r143097. <rdar://problem/13146994>
- 11:09 AM Changeset in webkit [143757] by
-
- 5 edits in trunk/Source/WebCore
[New Multicolumn] Correctly track whether or not a layer is paginated.
https://bugs.webkit.org/show_bug.cgi?id=110625.
Taking the first step towards implementing the correct spec-compliant painting
model for the new multi-column layout. Add code to make sure the paginated
bits in RenderLayer get propagated correctly for the new layout.
The main difference in bit propagation between the old multicolumn layout and
the new multicolumn layout is that the old layout only tracked pagination "roots",
since it has a broken layer painting model. It incorrectly treats a pagination
"root" inside a multi-column block as establishing a stacking context in each
column. This is incorrect.
The new multicolumn code is going to paint each paginated layer individually,
and this means the bits can't just be about roots. Instead they have to be set
on every layer that may be split across columns, without regard for whether parent
layers are also split or not. This is actually a simpler bit propagation model
than the old code.
Reviewed by Beth Dakin.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
Add code to set the m_isPaginated bit for in-flow RenderFlowThreads. This includes
only RenderMultiColumnFlowThread for now, but eventually it will also include
RenderPageFlowThread.
(WebCore::RenderLayer::useRegionBasedColumns):
Add a helper method to check if region-based columns are turned on, since we're
not attempting to alter the old column pagination model.
(WebCore::RenderLayer::updatePagination):
Added the code to propagate bits under the new model. Whether or not you're paginated
just depends on whether or not your enclosing layer along the containing block chain
is paginated.
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::hitTestList):
Add code that avoids the old multi-column pagination model when the new column model
is enabled. For now there is no code in the new model that does anything with the bits,
but we're avoiding calling the old code, since it is broken for the new columns.
- rendering/RenderLayer.h:
(RenderLayer):
Added the useRegionBasedColumns method to check the Setting.
- rendering/RenderMultiColumnFlowThread.h:
- rendering/RenderObject.h:
(WebCore::RenderObject::isInFlowRenderFlowThread):
(RenderObject):
Implement isInFlowRenderFlowThread, a virtual function for asking if a renderer is
an in-flow RenderFlowThread, which means that it is going to need paginated layers
because the flow thread has to split across "pages" that do not establish stacking
contexts.
- 11:01 AM Changeset in webkit [143756] by
-
- 29 edits2 copies in branches/chromium/1410
Merge 143386
Support both MutationObserver and WebKitMutationObserver
https://bugs.webkit.org/show_bug.cgi?id=109776
Reviewed by Ojan Vafai.
Source/WebCore:
We should allow new MutationObserver now that we support parser generated
mutations. This leaves the old prefixed constructor in until we decide
people don't depend on it.
Test: fast/dom/MutationObserver/mutation-observer-prefix.html
- page/DOMWindow.idl:
LayoutTests:
- fast/dom/MutationObserver/added-out-of-order.html:
- fast/dom/MutationObserver/callback-arguments.html:
- fast/dom/MutationObserver/clear-transient-without-delivery.html:
- fast/dom/MutationObserver/create-during-delivery.html:
- fast/dom/MutationObserver/cross-document.html:
- fast/dom/MutationObserver/database-callback-delivery.html:
- fast/dom/MutationObserver/delivery-order.html:
- fast/dom/MutationObserver/disconnect-cancel-pending.html:
- fast/dom/MutationObserver/document-fragment-insertion.html:
- fast/dom/MutationObserver/end-of-task-delivery.html:
- fast/dom/MutationObserver/filesystem-callback-delivery.html:
- fast/dom/MutationObserver/inline-event-listener.html:
- fast/dom/MutationObserver/mutate-during-delivery.html:
- fast/dom/MutationObserver/mutation-callback-non-element-crash.html:
- fast/dom/MutationObserver/mutation-observer-constructor.html:
- fast/dom/MutationObserver/mutation-observer-prefix-expected.txt: Added.
- fast/dom/MutationObserver/mutation-observer-prefix.html: Added.
- fast/dom/MutationObserver/mutation-record-nullity.html:
- fast/dom/MutationObserver/observe-attributes.html:
- fast/dom/MutationObserver/observe-characterdata.html:
- fast/dom/MutationObserver/observe-childList.html:
- fast/dom/MutationObserver/observe-exceptions.html:
- fast/dom/MutationObserver/observe-subtree.html:
- fast/dom/MutationObserver/observer-wrapper-dropoff-transient.html:
- fast/dom/MutationObserver/observer-wrapper-dropoff.html:
- fast/dom/MutationObserver/parser-mutations.html:
- fast/dom/MutationObserver/removed-out-of-order.html:
- fast/dom/MutationObserver/shadow-dom.html:
- fast/dom/MutationObserver/takeRecords.html:
- fast/dom/MutationObserver/transient-gc-crash.html:
TBR=esprehn@chromium.org
Review URL: https://codereview.chromium.org/12317072
- 11:00 AM Changeset in webkit [143755] by
-
- 4 edits in tags/Safari-537.31.7/Source
Versioning.
- 10:58 AM Changeset in webkit [143754] by
-
- 3 edits2 adds in trunk
text-overflow:ellipsis is not applied when the block contains nested blocks
https://bugs.webkit.org/show_bug.cgi?id=101879
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-02-22
Reviewed by Eric Seidel.
Source/WebCore:
Since text-overflow is not an inherited property, the anonymous blocks
don't know they should ellipse. This causes the anonymous blocks
created in the nested block situation to check their parent to find
out if they should ellipse.
Test: fast/css/text-overflow-ellipsis-anonymous-blocks.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
LayoutTests:
Use the test from the specification that is supplied as part of the
bug.
- fast/css/text-overflow-ellipsis-anonymous-blocks-expected.html: Added.
- fast/css/text-overflow-ellipsis-anonymous-blocks.html: Added.
- 10:50 AM Changeset in webkit [143753] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r143664, r143681): http/tests/security/feed-urls-from-remote.html fails
https://bugs.webkit.org/show_bug.cgi?id=110554
Reviewed by Adam Barth.
Will fix http/tests/security/feed-urls-from-remote.html for Mac WK1.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoading):
- 10:45 AM Changeset in webkit [143752] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 142659
REGRESSION(r136967): Combination of float and clear yields to bad layout
https://bugs.webkit.org/show_bug.cgi?id=109476
Reviewed by Levi Weintraub.
Source/WebCore:
Test: fast/block/margin-collapse/self-collapsing-block-with-float-children.html
The change made at http://trac.webkit.org/changeset/136967 only needs to worry about the first floated
child of a self-collapsing block. The ones that follow are not affected by its margins.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
LayoutTests:
- fast/block/margin-collapse/self-collapsing-block-with-float-children-expected.txt: Added.
- fast/block/margin-collapse/self-collapsing-block-with-float-children.html: Added.
TBR=robert@webkit.org
Review URL: https://codereview.chromium.org/12335038
- 10:40 AM Changeset in webkit [143751] by
-
- 1 copy in tags/Safari-537.31.7
New Tag.
- 10:21 AM Changeset in webkit [143750] by
-
- 4 edits in trunk/Source/WebCore
Build fix after r143637.
- WebCore.exp.in: Unconditionally export ScriptController::javaScriptContext.
- bindings/js/ScriptController.h: Unconditionally define javaScriptContext for Mac builds.
- bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::javaScriptContext): Move the #if inside the function, and return 0 when false.
- 10:20 AM Changeset in webkit [143749] by
-
- 3 edits in trunk/Source/WebCore
[TextAutosizing] Refactoring to eliminate boolean parameter.
https://bugs.webkit.org/show_bug.cgi?id=110490
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-22
Reviewed by Julien Chaffraix.
A follow-up to the recent change that introduced a boolean parameter to
processClusterInternal method of TextAutosizer. Boolean parameters are discouraged by the
WebKit style guide. See http://trac.webkit.org/changeset/142866
Refactoring so no new tests.
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::clusterMultiplier):
Calculates the font size multiplier for the specified cluster.
(WebCore::TextAutosizer::processClusterInternal):
Accepts the font size multiplier instead of |shouldBeAutosized|.
(WebCore::TextAutosizer::processCluster):
(WebCore::TextAutosizer::processCompositeCluster):
Both methods above now calculate the multiplier and then pass it to
processClusterInternal.
- rendering/TextAutosizer.h:
Updated method declarations.
- 10:13 AM Changeset in webkit [143748] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Use KURL::protocolIsInHTTPFamily instead of KURL::protocolInHTTPFamily
https://bugs.webkit.org/show_bug.cgi?id=110581
Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-22
Reviewed by Rob Buis.
KURL::protocolInHTTPFamily() was removed in r109670.
- platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::clearHTTPContentLength):
(WebCore::ResourceRequest::clearHTTPContentType):
- 10:07 AM Changeset in webkit [143747] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build-fix after r143744.
- dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
- 10:05 AM Changeset in webkit [143746] by
-
- 4 edits in branches/chromium/1364/Source
Merge 142755
[Qt] window.open passes height and width parameters even if not defined in a page
https://bugs.webkit.org/show_bug.cgi?id=107705
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Do not override width or height of 0, as that indicates default size, and not minimum size.
Tested by tst_qwebpage.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::adjustWindowRect):
Source/WebKit/efl:
Do not resize window when default size is requested.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::setWindowRect):
Source/WebKit/gtk:
Do not resize window when default size is requested.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::setWindowRect):
Source/WebKit/qt:
Test that minimum size is applied only when the requested size is too small,
not when default is requested.
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage):
(TestPage):
(TestPage::TestPage):
(TestPage::createWindow):
(TestPage::slotGeometryChangeRequested):
(tst_QWebPage::openWindowDefaultSize):
TBR=allan.jensen@digia.com
Review URL: https://codereview.chromium.org/12320068
- 9:56 AM Changeset in webkit [143745] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Canvas] throttle replayTraceLog messages to backend
https://bugs.webkit.org/show_bug.cgi?id=110591
Reviewed by Pavel Feldman.
The replayTraceLog message may be quite expensive. So, while such a request is processed by the
backend, user may well generate a dozen of new ones simply by walking through the DataGrid.
We should actually send to the backend only the last event from the queue.
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):
- 9:53 AM Changeset in webkit [143744] by
-
- 2 edits in trunk/Source/WebCore
Multiple Layout Test crashes (ASSERT) on chromium linux debug after r143727
https://bugs.webkit.org/show_bug.cgi?id=110609
Reviewed by Antonio Gomes.
Revert r128869. InnerNode may now again be from a child document,
and should be handled and not asserted against.
- dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
- 9:47 AM Changeset in webkit [143743] by
-
- 3 edits in trunk/Source/WebCore
Element: Make updateName/updateId/updateLabel private.
<http://webkit.org/b/110603>
Reviewed by Antti Koivisto.
These methods are only called from inside Element so make them private and
move them to the .cpp file.
- dom/Element.cpp:
(WebCore::Element::updateName):
(WebCore::Element::updateId):
- dom/Element.h:
- 9:42 AM Changeset in webkit [143742] by
-
- 46 edits7 adds2 deletes in trunk/Source
Roll ANGLE to r1833
https://bugs.webkit.org/show_bug.cgi?id=110513
Reviewed by Kenneth Russell.
Source/ThirdParty/ANGLE:
Upstream ANGLE r1833 includes webkit side local fixes
1) r139758 build fix for -Wshorten-64-to-32
2) r139665 build fix for uninitialized variables
After this roll, WebKit side ANGLE is the same as upstream ANGLE r1833, except:
1) include/GLSLANG/ShaderLang.h, where "KHR" is removed from include path.
With this roll, we have EXT_draw_buffers support.
- ANGLE.xcodeproj/project.pbxproj:
- Target.pri:
- include/GLSLANG/ShaderLang.h:
- src/common/debug.cpp:
- src/common/system.h: Added.
- src/common/version.h:
- src/compiler/ArrayBoundsClamper.cpp: Removed.
- src/compiler/ArrayBoundsClamper.h: Removed.
- src/compiler/Compiler.cpp:
(TCompiler::TCompiler):
(TCompiler::Init):
(TCompiler::compile):
(TCompiler::getArrayBoundsClamper):
(TCompiler::getArrayIndexClampingStrategy):
(TCompiler::getBuiltInFunctionEmulator):
- src/compiler/DetectDiscontinuity.cpp:
(sh::DetectLoopDiscontinuity::traverse):
(sh::DetectLoopDiscontinuity::visitLoop):
(sh):
(sh::DetectLoopDiscontinuity::visitBranch):
- src/compiler/DetectDiscontinuity.h:
(DetectLoopDiscontinuity):
- src/compiler/Initialize.cpp:
(InitExtensionBehavior):
- src/compiler/Intermediate.cpp:
(TIntermConstantUnion::fold):
(TIntermTraverser::hash):
- src/compiler/MapLongVariableNames.cpp:
(LongNameMap::Size):
(MapLongVariableNames::mapGlobalLongName):
- src/compiler/MapLongVariableNames.h:
(LongNameMap):
- src/compiler/OutputESSL.cpp:
(TOutputESSL::TOutputESSL):
- src/compiler/OutputESSL.h:
(TOutputESSL):
- src/compiler/OutputGLSL.cpp:
(TOutputGLSL::TOutputGLSL):
- src/compiler/OutputGLSL.h:
(TOutputGLSL):
- src/compiler/OutputGLSLBase.cpp:
(TOutputGLSLBase::TOutputGLSLBase):
(TOutputGLSLBase::writeConstantUnion):
(TOutputGLSLBase::visitBinary):
- src/compiler/OutputGLSLBase.h:
(TOutputGLSLBase):
- src/compiler/OutputHLSL.cpp:
(sh::OutputHLSL::output):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::writeConstantUnion):
- src/compiler/ParseHelper.cpp:
(TParseContext::constructorErrorCheck):
(PaParseStrings):
- src/compiler/ParseHelper.h:
- src/compiler/ShHandle.h:
(TCompiler):
- src/compiler/ShaderLang.cpp:
(checkActiveUniformAndAttribMaxLengths):
(checkMappedNameMaxLength):
(getVariableInfo):
(ShInitBuiltInResources):
(ShCompile):
(ShGetInfo):
(ShGetActiveAttrib):
(ShGetActiveUniform):
(ShGetNameHashingEntry):
- src/compiler/SymbolTable.h:
(TFunction::getParamCount):
(TFunction::getParam):
(TSymbolTable::setDefaultPrecision):
- src/compiler/TranslatorESSL.cpp:
(TranslatorESSL::translate):
- src/compiler/TranslatorGLSL.cpp:
(TranslatorGLSL::translate):
- src/compiler/ValidateLimitations.cpp:
(ValidateLimitations::validateFunctionCall):
- src/compiler/VariablePacker.cpp:
(VariablePacker::GetNumRows):
- src/compiler/glslang.h:
- src/compiler/glslang.l:
- src/compiler/glslang.y:
- src/compiler/glslang_lex.cpp:
(string_input):
(glslang_scan):
- src/compiler/glslang_tab.cpp:
- src/compiler/preprocessor/ExpressionParser.cpp:
- src/compiler/preprocessor/ExpressionParser.y:
- src/compiler/preprocessor/Input.cpp:
(pp::Input::Input):
(pp::Input::read):
- src/compiler/preprocessor/Input.h:
(Input):
(pp::Input::count):
(pp::Input::string):
(pp::Input::length):
(Location):
- src/compiler/preprocessor/Preprocessor.cpp:
(pp::Preprocessor::init):
- src/compiler/preprocessor/Preprocessor.h:
(Preprocessor):
- src/compiler/preprocessor/Tokenizer.cpp:
(pp::Tokenizer::init):
- src/compiler/preprocessor/Tokenizer.h:
(Tokenizer):
- src/compiler/preprocessor/Tokenizer.l:
- src/third_party: Added.
- src/third_party/compiler: Added.
- src/third_party/compiler/ArrayBoundsClamper.cpp: Added.
(ArrayBoundsClamper::ArrayBoundsClamper):
(ArrayBoundsClamper::SetClampingStrategy):
(ArrayBoundsClamper::MarkIndirectArrayBoundsForClamping):
(ArrayBoundsClamper::OutputClampingFunctionDefinition):
- src/third_party/compiler/ArrayBoundsClamper.h: Added.
(ArrayBoundsClamper):
(ArrayBoundsClamper::Cleanup):
(ArrayBoundsClamper::GetArrayBoundsClampDefinitionNeeded):
(ArrayBoundsClamper::SetArrayBoundsClampDefinitionNeeded):
- src/third_party/compiler/LICENSE: Added.
- src/third_party/compiler/README.angle: Added.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- 9:28 AM Changeset in webkit [143741] by
-
- 3 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r143734.
http://trac.webkit.org/changeset/143734
https://bugs.webkit.org/show_bug.cgi?id=110615
Causes linux build failures. (Requested by vollick on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-22
- public/WebKit.h:
(WebKit):
- src/WebKit.cpp:
(WebKit::initialize):
(WebKit::initializeWithoutV8):
(WebKit::webKitPlatformSupport):
- 9:26 AM Changeset in webkit [143740] by
-
- 5 edits in trunk/Source
[BlackBerry] Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=110577
Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-22
Reviewed by Rob Buis.
Iterators were renamed to key/value in r130612.
Source/WebCore:
- platform/blackberry/AuthenticationChallengeManager.cpp:
(WebCore::AuthenticationChallengeManager::pageVisibilityChanged):
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyMultipartHeaderReceived):
Source/WebKit/blackberry:
- WebKitSupport/NotificationManager.cpp:
(BlackBerry::WebKit::NotificationManager::show):
(BlackBerry::WebKit::NotificationManager::clearNotifications):
(BlackBerry::WebKit::NotificationManager::removeNotificationFromContextMap):
- 9:23 AM Changeset in webkit [143739] by
-
- 4 edits6 deletes in trunk
[WTR] Do not dump information about empty subframes.
https://bugs.webkit.org/show_bug.cgi?id=110585
Reviewed by Simon Fraser.
Tools:
Follow DumpRenderTree more closely by skipping empty frames
(frames which have no document). We are not really interested in
showing anything about them.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpDescendantFramesText): Do not print subframe names when they
have no associated Document.
LayoutTests:
Remove some platform-specific expectations now that the results match
the base expectations.
- platform/efl/TestExpectations: Unskip tests that are now passing.
- platform/mac-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
- platform/mac-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Removed.
- platform/qt-5.0-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
- platform/qt-5.0-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Removed.
- platform/win-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
- platform/win-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Removed.
- 8:55 AM Changeset in webkit [143738] by
-
- 6 edits2 copies2 adds in trunk/LayoutTests
Unreviewed, rolling out r143678 and r143702.
http://trac.webkit.org/changeset/143678
http://trac.webkit.org/changeset/143702
https://bugs.webkit.org/show_bug.cgi?id=110613
Breaks fast/loader/stateobjects/state-url-sets-links-
visited.html in Chromium (Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-22
- fast/js/resources/js-test-pre.js:
- fast/loader/stateobjects/state-url-sets-links-visited-expected.txt:
- fast/loader/stateobjects/state-url-sets-links-visited.html:
- platform/chromium-win/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt: Copied from LayoutTests/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt.
- platform/chromium/TestExpectations:
- platform/win/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt: Copied from LayoutTests/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt.
- platform/wk2/TestExpectations:
- 8:54 AM Changeset in webkit [143737] by
-
- 3 edits in trunk/Source/WebCore
[V8] Add comments to checkTypeOrDieTrying()
https://bugs.webkit.org/show_bug.cgi?id=110553
Reviewed by Adam Barth.
It is mysterious how the check is helpful. We need comments.
No tests. Just added comments.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
- bindings/v8/ScriptWrappable.h:
(ScriptWrappable):
- 8:51 AM Changeset in webkit [143736] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove ProtocolHandler methods from ChromeClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=110567
Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-22
Reviewed by Rob Buis.
They were removed from ChromeClient in r122810 and are now
implemented in NavigatorContentUtilsClientBlackBerry since r131056.
- WebCoreSupport/ChromeClientBlackBerry.cpp:
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
- 8:46 AM Changeset in webkit [143735] by
-
- 6 edits in trunk/Source/WebKit/chromium
[Chromium] Add support for emulating legacy Android WebView 'setInitialScale' method
https://bugs.webkit.org/show_bug.cgi?id=109946
Adding a WebView method for permanently setting initial page scale.
This override has higher priority than any calculated page scale
and viewport meta tag value.
Also, this patch eliminates a dubious "fixed layout enabled, viewport disabled" mode
previously used by Android WebView.
Reviewed by Adam Barth.
- public/WebView.h:
(WebView):
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setInitialPageScaleOverride):
(WebKit):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
- src/WebViewImpl.h:
- tests/WebFrameTest.cpp:
- 8:41 AM Changeset in webkit [143734] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
https://bugs.webkit.org/show_bug.cgi?id=110605
Reviewed by Adam Barth.
Part of a larger refactoring series; see tracking bug 82948.
- public/WebKit.h:
(WebKit):
- src/WebKit.cpp:
(WebKit::initialize):
(WebKit::initializeWithoutV8):
(WebKit::webKitPlatformSupport):
- 8:33 AM Changeset in webkit [143733] by
-
- 2 edits in trunk/Source/WebCore
32-bit build fix after r143706
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::didReceiveData):
- 8:24 AM Changeset in webkit [143732] by
-
- 6 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Added platform specific expected files after 143626.
- platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
- platform/qt/TestExpectations:
- 8:17 AM Changeset in webkit [143731] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Canvas] do no show a single frame node in data grid
https://bugs.webkit.org/show_bug.cgi?id=110473
Reviewed by Pavel Feldman.
In a single canvas frame capture mode do not show the single "Frame #1" node.
Drive-by: Fix a wrong "this" pointer.
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
(WebInspector.CanvasProfileView.prototype.appendDrawCallGroup):
(WebInspector.CanvasProfileView.prototype._flattenSingleFrameNode):
- 8:12 AM Changeset in webkit [143730] by
-
- 2 edits in trunk/Source/WebCore
Multiple Layout Test crashes (ASSERT) on chromium linux debug after r143727
https://bugs.webkit.org/show_bug.cgi?id=110609
Reviewed by Antonio Gomes.
Point based hit tests should not append but assign HitTestResults.
- rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::nodeAtPoint):
- 7:54 AM Changeset in webkit [143729] by
-
- 10 edits in trunk/Source/WebCore
Web Inspector: show source location after drawer views
https://bugs.webkit.org/show_bug.cgi?id=110156
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-22
Reviewed by Pavel Feldman.
- Add statusBarText method
- Add #drawer-view-anchor, which determines layout position of
drawerView
- Fix layout in #panel-status-bar to avoid floating elements.
No new tests.
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown): Add statusBarItems before
drawer-view-anchor and statusBarText after.
(WebInspector.Panel.prototype.willHide): Remove statusBarText from DOM in the
way it's done for statusBarItems
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.statusBarText): Added.
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.statusBarText): Added.
(WebInspector.SourceFrame.prototype.statusBarItems):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get statusBarItems):
- inspector/front-end/View.js:
(WebInspector.View.prototype.statusBarText):
- inspector/front-end/inspector.css:
(#drawer-view-anchor):
(.source-frame-cursor-position):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector.showViewInDrawer):
- inspector/front-end/timelinePanel.css:
(.timeline-records-stats):
(.timeline-records-stats-container):
- 7:31 AM Changeset in webkit [143728] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip failing tests on EFL bots.
- platform/efl/TestExpectations:
- 6:46 AM Changeset in webkit [143727] by
-
- 15 edits3 adds in trunk
Allow child-frame content in hit-tests.
https://bugs.webkit.org/show_bug.cgi?id=95204
Reviewed by Julien Chaffraix.
Source/WebCore:
Refactors how EventHandler::hitTestResultAtPoint handles child-frame content,
it is now handled by the hit test itself controlled by the AllowChildFrameContent
flag in HitTestRequest.
This means that area-based hit-tests can now return elements from all the child frames
they intersect instead of just the one frame containing the center point. The improved
results from area-based hit-tests will among other things also improve touch adjustment
near frame boundaries.
Tests: fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
Recursion into child-frames have been moved to RenderFrameBase::nodeAtPoint, so
now hitTestResultAtPoint just needs to set AllowChildFrameContent.
- page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::parentShadowHostOrOwner):
New function to iterate up across frame boundaries.
(WebCore::TouchAdjustment::compileSubtargetList):
We need to iterate up across frame boundaries to avoid iframes competing with their
own content for touch adjustment.
- rendering/HitTestRequest.h:
(WebCore::HitTestRequest::allowsChildFrameContent):
(WebCore::HitTestRequest::isChildFrameHitTest):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::append):
(WebCore::HitTestResult::dictationAlternatives):
- rendering/HitTestResult.h:
(WebCore::HitTestResult::pointInMainFrame):
(WebCore::HitTestResult::pointInInnerNodeFrame):
(HitTestResult):
m_hitTestLocation is now in main frame coordinates, which make m_pointInMainFrame
unnecessary, but requires the introduction of m_pointInInnerFrame, to remember
the coordinates of inner-node in its own frame.
- rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::nodeAtPoint):
The recursion into child-frames is now handled here instead of in hitTestResultAtPoint, this
allows us to recurse into multiple frames, instead of just one.
- rendering/RenderFrameBase.h:
(RenderFrameBase):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):
RenderLayer should not lie about being hit if the request is child-frame request.
- testing/Internals.cpp:
(WebCore::Internals::nodesFromRect):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Extended so nodesFromRect with child-frame content can be tested.
LayoutTests:
A new tests for nodesFromRect that returns result from child frames.
- fast/dom/nodesFromRect/nodesFromRect-child-frame-content-expected.txt: Added.
- fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html: Added.
- fast/dom/nodesFromRect/nodesFromRect-continuation-crash.html:
- fast/dom/nodesFromRect/resources/child-frame.html: Added.
- fast/dom/nodesFromRect/resources/nodesFromRect.js:
(check):
(checkShadowContent):
(nodesFromRectAsString):
- 6:39 AM Changeset in webkit [143726] by
-
- 5 edits in trunk/Source/WebCore
ShareableElementData should use zero-length array for storage.
<http://webkit.org/b/109959>
Reviewed by Anders Carlsson.
Use a zero-length Attribute array instead of always casting from void* to an array.
It was done this way originally because I didn't know we could sidestep the MSVC
build error with some #pragma hackery and a default constructor for Attribute.
- dom/Attribute.cpp:
(WebCore::Attribute::Attribute):
- dom/DocumentSharedObjectPool.cpp:
(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):
- dom/Element.cpp:
(WebCore::sizeForShareableElementDataWithAttributeCount):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::UniqueElementData::UniqueElementData):
- dom/Element.h:
(ShareableElementData):
(WebCore::ElementData::attributeItem):
- 5:52 AM Changeset in webkit [143725] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: [Chromium] add a browser test for frames on timeline
https://bugs.webkit.org/show_bug.cgi?id=110592
- factor out timeline recording logic from testPageOverlayUpdate for reuse;
- record timeline while running a simple DOM-based animation;
- assure we have frames and Style Recalc/Layout/Paint events in between.
Reviewed by Yury Semikhatsky.
- src/js/Tests.js:
(.TestSuite.prototype.assertHasKey):
(.TestSuite.prototype.testTimelineFrames.step1):
(.TestSuite.prototype.testTimelineFrames.onTimelineRecorded):
(.TestSuite.prototype.testTimelineFrames):
(.TestSuite.prototype.testPageOverlayUpdate.step4):
(.TestSuite.prototype.testPageOverlayUpdate.onTimelineRecorded):
(.TestSuite.prototype.recordTimeline.addRecord):
(.TestSuite.prototype.recordTimeline.innerAddRecord):
(.TestSuite.prototype.recordTimeline.done):
(.TestSuite.prototype.recordTimeline):
(.TestSuite.prototype.stopTimeline):
- 5:50 AM Changeset in webkit [143724] by
-
- 2 edits in trunk/Source/WebCore
Remove unused declaration: Element::removeCachedHTMLCollection()
Not reviewed by Antti Koivisto.
- dom/Element.h:
(Element):
- 5:44 AM Changeset in webkit [143723] by
-
- 2 edits in trunk/Source/WebCore
Add scroll view for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110137
Reviewed by Kent Tamura.
Adding a scroll view class as part of the new calendar picker (Bug 109439).
No new tests. Code not yet used.
- Resources/pagepopups/calendarPicker.js:
(View):
(View.prototype.offsetRelativeTo): Returns the offset position of this view relative to the given ancestor element.
(View.prototype.attachTo): Attaches view to a node or view.
(View.prototype.bindCallbackMethods): Binds all methods starting with "on" to this.
(ScrollView): A custom scroll view that can contain extremely long content. CSS values have a limit. This can go beyond that.
(ScrollView.prototype.setWidth): Sets the view width.
(ScrollView.prototype.width):
(ScrollView.prototype.setHeight):Sets the view height.
(ScrollView.prototype.height):
(ScrollView.prototype.onScrollAnimatorStep): Callback for scroll animator step.
(ScrollView.prototype.scrollTo): Scrolls to a certain offset.
(ScrollView.prototype.scrollBy): Scrolls by a certain amount.
(ScrollView.prototype.contentOffset): Current content offset.
(ScrollView.prototype.onMouseWheel): Scroll with the mouse wheel.
(ScrollView.prototype.setContentOffset): Sets the content offset.
(ScrollView.prototype.contentPositionForContentOffset): Returns where the content element should be positioned.
- 5:43 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:42 AM Changeset in webkit [143722] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r143696 - [GTK] Control+Shift+Up/Down selection works backwards
https://bugs.webkit.org/show_bug.cgi?id=110459
Reviewed by Martin Robinson.
- platform/gtk/KeyBindingTranslator.cpp:
(WebCore): The translation table for paragraph selection
commands is backwards, fix it.
- 5:41 AM Changeset in webkit [143721] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: InspectorPageAgent::disable() should not update view metrics regardless of the override state
https://bugs.webkit.org/show_bug.cgi?id=110593
Reviewed by Vsevolod Vlasov.
InspectorPageAgent::disable() now checks if the device metrics are overridden before
telling the client to disable the override.
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::setDeviceMetricsOverride):
(WebCore::InspectorPageAgent::deviceMetricsChanged):
- inspector/InspectorPageAgent.h:
(InspectorPageAgent):
- 5:35 AM Changeset in webkit [143720] by
-
- 1 copy in releases/WebKitGTK/webkit-1.11.90
Tagging the WebKitGTK+ 1.11.90 release
- 5:34 AM Changeset in webkit [143719] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r143695.
http://trac.webkit.org/changeset/143695
https://bugs.webkit.org/show_bug.cgi?id=110554
Crashes in DocumentLoader::checkLoadComplete on AppleMac WK1, EFL, GTK.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoading):
- 5:33 AM Changeset in webkit [143718] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding crash expectations for tests that regressed with r143624.
- platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining.
- 5:33 AM Changeset in webkit [143717] by
-
- 2 edits in trunk/Source/WebKit2
Yet another unreviewed buildfix after r143714.
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::paintToCairoSurface):
- 5:26 AM Changeset in webkit [143716] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip tests until regressions (r143470, r143654) fixed.
- platform/qt/TestExpectations:
- 5:18 AM Changeset in webkit [143715] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed preventive buildfix after my last commit.
- UIProcess/API/efl/EwkView.cpp:
- UIProcess/efl/WebView.cpp:
- 4:58 AM Changeset in webkit [143714] by
-
- 6 edits in trunk/Source
[CoordGfx] Minor cleanup in CoordinatedGraphicsScene::paintToGraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=109824
Reviewed by Andreas Kling.
Avoid ugly ifdefs by using PlatformGraphicsContext.
Source/WebCore:
No new tests, only refactoring.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::paintToGraphicsContext):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
(CoordinatedGraphicsScene):
Source/WebKit2:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::displayTimerFired):
- 4:22 AM Changeset in webkit [143713] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL] Remove declaration of non-existent functions from EwkView
https://bugs.webkit.org/show_bug.cgi?id=110572
Reviewed by Kenneth Rohde Christiansen.
Removed declarations of non-existent EwkView::paintToCurrentGLContext() and
EwkView::paintToCairoSurface(cairo_surface_t*) that were accidentally
left at r143699.
- UIProcess/API/efl/EwkView.h:
(EwkView):
- 4:11 AM Changeset in webkit [143712] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0
Unreviewed. Update NEWS and Versions.m4 for 1.11.90 release.
- 4:07 AM Changeset in webkit [143711] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r143710 - Unreviewed. Fix make distcheck.
- GNUmakefile.am: Add CodeGeneratorInspectorStrings.py to
EXTRA_DIST.
- 4:05 AM Changeset in webkit [143710] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix make distcheck.
- GNUmakefile.am: Add CodeGeneratorInspectorStrings.py to
EXTRA_DIST.
- 2:50 AM Changeset in webkit [143709] by
-
- 1 edit6 deletes in trunk/LayoutTests
Unreviewed gardening.
Remove some platform expectations which are identical to the
original ones.
- platform/efl/http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Removed.
- platform/mac-wk2/http/tests/security/cross-origin-local-storage-wk1-expected.txt: Removed.
- platform/qt-5.0-wk2/http/tests/navigation/forward-and-cancel-expected.txt: Removed.
- platform/qt-5.0-wk2/http/tests/navigation/postredirect-frames-expected.txt: Removed.
- platform/qt-5.0-wk2/http/tests/navigation/postredirect-goback2-expected.txt: Removed.
- 2:33 AM Changeset in webkit [143708] by
-
- 2 edits in trunk/Tools
[EFL][DRT] Do not dump empty frames.
https://bugs.webkit.org/show_bug.cgi?id=110474
Reviewed by Kenneth Rohde Christiansen.
Follow the original Mac implementation more closely by skipping
empty frames (frames which have no document). We are not really
interested in showing anything about them.
- DumpRenderTree/efl/DumpRenderTree.cpp:
(dumpFramesAsText):
- 2:15 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:13 AM WebKitGTK/2.0.x edited by
- Bring back previous versions sections (diff)
- 2:10 AM WebKitGTK/2.0.x edited by
- Subresources leaks was merged already (diff)
- 2:07 AM Changeset in webkit [143707] by
-
- 2 edits in trunk/Source/WebCore
GlyphPage: ALWAYS_INLINE all performance-relevant getters.
REGRESSION(r143125): ~5% performance hit on Chromium's intl2 page cycler
<http://webkit.org/b/108835>
Reviewed by Antti Koivisto.
Unreviewed desperate hack. Since I can't reproduce the problem and it's only showing
up on two bots, one Linux and one Snow Leopard, I'm thinking it may be GCC related.
Let's see what happens if we tell it to force inline all the GlyphPage getters.
- platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::indexForCharacter):
(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::glyphAt):
(WebCore::GlyphPage::fontDataForCharacter):
- 2:03 AM Changeset in webkit [143706] by
-
- 3 edits in trunk/Source/WebCore
Update FileReaderLoader to allow specifying a range and reading as a blob.
https://bugs.webkit.org/show_bug.cgi?id=110556
This is part of a series of patches to implement Stream support. See:
https://bugs.webkit.org/show_bug.cgi?id=110194
Patch by Zach Kuznia <zork@chromium.org> on 2013-02-22
Reviewed by Hajime Morrita.
Tests: will be added when js binding is added.
- fileapi/FileReaderLoader.cpp:
- fileapi/FileReaderLoader.h:
- 1:33 AM Changeset in webkit [143705] by
-
- 5 edits in trunk/Source/WebKit2
[WK2][EFL] Clean up PageViewportControllerClientEfl class
https://bugs.webkit.org/show_bug.cgi?id=110438
Reviewed by Andreas Kling.
Cleaned up PageViewportControllerClientEfl class from unused methods
and class members, eliminated access to WK2 internals from this class.
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
- UIProcess/efl/PageViewportControllerClientEfl.h:
(WebKit::PageViewportControllerClientEfl::~PageViewportControllerClientEfl):
(PageViewportControllerClientEfl):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::WebView):
(WebKit::WebView::updateViewportSize):
- 1:33 AM Changeset in webkit [143704] by
-
- 17 edits3 adds in trunk
[WebGL][EFL] Support for creating surface with alpha disabled.
https://bugs.webkit.org/show_bug.cgi?id=110067
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-22
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Covered by compositing/webgl/webgl-no-alpha.html
We currently always create a surface supporting alpha channel.
With this patch we create the surface with alpha only if
required.
- platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::initialize):
- platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore::GLPlatformSurface::createOffScreenSurface):
(WebCore::GLPlatformSurface::createTransportSurface):
(WebCore::GLPlatformSurface::GLPlatformSurface):
(WebCore::GLPlatformSurface::attributes):
(WebCore):
- platform/graphics/opengl/GLPlatformSurface.h:
- platform/graphics/surfaces/egl/EGLConfigSelector.cpp:
(WebCore):
(WebCore::EGLConfigSelector::EGLConfigSelector):
(WebCore::EGLConfigSelector::pBufferContextConfig):
(WebCore::EGLConfigSelector::surfaceContextConfig):
- platform/graphics/surfaces/egl/EGLConfigSelector.h:
(EGLConfigSelector):
- platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
- platform/graphics/surfaces/egl/EGLSurface.h:
(EGLWindowTransportSurface):
- platform/graphics/surfaces/glx/GLXConfigSelector.h:
(WebCore):
(WebCore::GLXConfigSelector::GLXConfigSelector):
(WebCore::GLXConfigSelector::pixmapContextConfig):
(WebCore::GLXConfigSelector::surfaceContextConfig):
(WebCore::GLXConfigSelector::surfaceClientConfig):
(WebCore::GLXConfigSelector::validateAttributes):
(WebCore::GLXConfigSelector::findMatchingConfig):
(WebCore::GLXConfigSelector::findMatchingConfigWithVisualId):
(GLXConfigSelector):
- platform/graphics/surfaces/glx/GLXContext.cpp:
(WebCore::GLXOffScreenContext::initialize):
- platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXOffScreenSurface::GLXOffScreenSurface):
(WebCore::GLXOffScreenSurface::initialize):
- platform/graphics/surfaces/glx/GLXSurface.h:
(GLXTransportSurface):
(GLXOffScreenSurface):
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap):
LayoutTests:
Enabled compositing/webgl/webgl-no-alpha.html for Efl port.
- platform/efl/TestExpectations:
- platform/efl/compositing/webgl/webgl-no-alpha-expected.png: Added.
- platform/efl/compositing/webgl/webgl-no-alpha-expected.txt: Added.
- 1:20 AM Changeset in webkit [143703] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/multicol/newmulticol/positioned-split.html is failing on chromium mac 10.8 since it was added
https://bugs.webkit.org/show_bug.cgi?id=110568
Unreviewed test expectation update.
- platform/chromium/TestExpectations:
- 1:07 AM Changeset in webkit [143702] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/loader/stateobjects/state-url-sets-links-visited.html is timing out in chromium
https://bugs.webkit.org/show_bug.cgi?id=110566
Unreviewed test expectation update.
- platform/chromium/TestExpectations:
- 12:59 AM Changeset in webkit [143701] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: allow opting out from vertical split in the dock-to-right mode
https://bugs.webkit.org/show_bug.cgi?id=110564
Reviewed by Vsevolod Vlasov.
- English.lproj/localizedStrings.js:
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._splitVertically):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/Settings.js:
(WebInspector.Settings):
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
- 12:56 AM WebKitGTK/1.10.x edited by
- (diff)
- 12:55 AM Changeset in webkit [143700] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][EFL][GTK][Qt] Add context menu item tags for C API
https://bugs.webkit.org/show_bug.cgi?id=109815
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-02-22
Reviewed by Anders Carlsson.
This patch adds context menu item tags used by EFL, GTK and Qt ports, defined in
WebCore to WK2 C API.
- Shared/API/c/WKContextMenuItemTypes.h:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
- 12:52 AM Changeset in webkit [143699] by
-
- 7 edits in trunk/Source/WebKit2
[WK2][EFL] Move AC code from EwkView to WebView
https://bugs.webkit.org/show_bug.cgi?id=110216
Reviewed by Anders Carlsson.
Accelerated compositing code is moved from EwkView to WebView.
Added new WKView API to be used from EwkView instead of direct accessing
to coordinated graphics scene.
- UIProcess/API/C/efl/WKView.cpp:
(WKViewSetUserViewportTranslation):
(WKViewUserViewportToContents):
(WKViewPaintToCurrentGLContext):
(WKViewPaintToCairoSurface):
- UIProcess/API/C/efl/WKView.h:
Added WKView API functions.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::displayTimerFired):
(EwkView::feedTouchEvent):
(EwkView::createGLSurface):
(EwkView::handleEvasObjectCalculate):
(EwkView::handleEwkViewMouseWheel):
(EwkView::handleEwkViewMouseDown):
(EwkView::handleEwkViewMouseUp):
(EwkView::handleEwkViewMouseMove):
- UIProcess/API/efl/EwkView.h:
(EwkView):
Using new WKView API.
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::initialize):
(WebKit):
(WebKit::WebView::paintToCurrentGLContext):
(WebKit::WebView::paintToCairoSurface):
(WebKit::WebView::userViewportToContents):
(WebKit::WebView::transformFromScene):
(WebKit::WebView::transformToScene):
(WebKit::WebView::coordinatedGraphicsScene):
(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
- UIProcess/efl/WebView.h:
(WebCore):
(WebKit::WebView::setUserViewportTranslation):
(WebView):
Added WebView methods to support new WKView API.
- 12:46 AM Changeset in webkit [143698] by
-
- 9 edits2 copies5 adds in trunk/LayoutTests
Unreviewed tests rebaseline.
- platform/chromium-linux-x86/fast/images/favicon-as-image-expected.png: Added.
- platform/chromium-linux/fast/images/favicon-as-image-expected.png:
- platform/chromium-linux/http/tests/misc/favicon-as-image-expected.png: Added.
- platform/chromium-linux/http/tests/misc/favicon-as-image-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.png: Added.
- platform/chromium-mac-lion/fast/images/favicon-as-image-expected.png:
- platform/chromium-mac-lion/fast/images/favicon-as-image-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/images/favicon-as-image-expected.txt.
- platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.png:
- platform/chromium-mac-snowleopard/fast/images/favicon-as-image-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.png: Added.
- platform/chromium-mac/fast/images/favicon-as-image-expected.png:
- platform/chromium-mac/fast/images/favicon-as-image-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.png:
- platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/images/favicon-as-image-expected.txt.
- platform/chromium/TestExpectations:
- 12:45 AM Changeset in webkit [143697] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] DomSupport: use NodeTraversal APIs
https://bugs.webkit.org/show_bug.cgi?id=110467
Patch by Xan Lopez <xlopez@rim.com> on 2013-02-22
Reviewed by Antonio Gomes.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::visibleTextQuads):
- 12:40 AM Changeset in webkit [143696] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Control+Shift+Up/Down selection works backwards
https://bugs.webkit.org/show_bug.cgi?id=110459
Reviewed by Martin Robinson.
- platform/gtk/KeyBindingTranslator.cpp:
(WebCore): The translation table for paragraph selection
commands is backwards, fix it.
Feb 21, 2013:
- 11:51 PM Changeset in webkit [143695] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r143664, r143681): http/tests/security/feed-urls-from-remote.html fails
https://bugs.webkit.org/show_bug.cgi?id=110554
Reviewed by Ryosuke Niwa.
Will fix http/tests/security/feed-urls-from-remote.html for Mac WK1.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoading):
- 11:39 PM Changeset in webkit [143694] by
-
- 24 edits in trunk/Source
IndexedDB: Implement SharedBuffer version of put() / onSuccess()
https://bugs.webkit.org/show_bug.cgi?id=110398
Reviewed by Tony Chang.
Source/WebCore:
This avoids all unnecessary data copies within the context of
IndexedDB proper, and removes all references to
SerializedScriptValue from the IndexedDB "backend".
No new tests because this is just a refactor.
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore::deserializeIDBValueBuffer): New version of deserializeIDBValue which takes SharedBuffer.
Source/WebKit/chromium:
Proxy new SharedBuffer calls to WebIDBCallbacks through
to the new SharedBuffer-based IDBCallbacks.
- public/WebIDBCursor.h:
- src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onSuccessWithPrefetch):
- src/IDBCallbacksProxy.h:
(IDBCallbacksProxy):
- src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onSuccess):
- src/WebIDBCallbacksImpl.h:
(WebIDBCallbacksImpl):
- tests/IDBAbortOnCorruptTest.cpp:
(WebCore::MockIDBCallbacks::onSuccess):
(WebCore::MockIDBCallbacks::onSuccessWithPrefetch):
- tests/IDBDatabaseBackendTest.cpp:
- tests/IDBRequestTest.cpp:
(WebKit::TEST_F):
- 11:18 PM Changeset in webkit [143693] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r143691.
http://trac.webkit.org/changeset/143691
https://bugs.webkit.org/show_bug.cgi?id=110559
Breaks compilation on mac. (Requested by vsevik on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore):
(WebCore::RenderLayerCompositor::reasonForCompositing):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 10:39 PM Changeset in webkit [143692] by
-
- 2 edits in trunk/Source/WebCore
Remove deep copy of ImageBuffer in tiled SVG backgrounds
https://bugs.webkit.org/show_bug.cgi?id=110549
Reviewed by Dirk Schulze.
SVGImage::drawPatternForContainer creates a temporary ImageBuffer for stamping out tiled
backgrounds. Previously this ImageBuffer was unnecessarily deep-copied! This patch uses a
shallow copy, taking advantage of the fact that the temporary ImageBuffer is never modified.
This patch is covered with existing tests.
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
- 10:33 PM Changeset in webkit [143691] by
-
- 3 edits in trunk/Source/WebCore
Expose a list of all reasons that qualify a RenderLayer to be composited
https://bugs.webkit.org/show_bug.cgi?id=110505
Expose the various reasons that can qualify a RenderLayer to be composited
via a new bitmask returned by the reasonForCompositing() method on
RenderLayerCompositor. This method already existed and was used for logging
purposes, but the previous functionality is now accessed via the
logReasonForCompositing() method.
This will allow the the InspectorLayerTreeAgent to provide this information
to the front-end on a per-layer basis as requested by the front-end.
Reviewed by Simon Fraser.
No new tests.
- 10:25 PM Changeset in webkit [143690] by
-
- 3 edits2 adds in trunk
RenderTable::paintBoxDecorations sometimes draws box-shadow twice.
https://bugs.webkit.org/show_bug.cgi?id=110196
Reviewed by Simon Fraser.
Source/WebCore:
When RenderTable::paintBoxDecorations draws box-shadow, paintBackground
should not draw box-shadow. So we have to provide bleedAvoidance
parameter for RenderBox::paintBackground.
Test: fast/css/table-border-radius-with-box-shadow.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::paintBoxDecorations):
Provide bleedAvoidance, which determineBackgroundBleedAvoidance
returns, for paintBackground.
LayoutTests:
- fast/css/table-border-radius-with-box-shadow-expected.html: Added.
- fast/css/table-border-radius-with-box-shadow.html: Added.
- 10:02 PM Changeset in webkit [143689] by
-
- 2 edits in trunk/LayoutTests
Add failing test expectations for bugs 110554 and 110555.
- platform/mac/TestExpectations:
- 10:00 PM Changeset in webkit [143688] by
-
- 11 edits in trunk/Source
Allow to retrieve the request data from abstract TextCheckingRequest to be accessible for WK2
https://bugs.webkit.org/show_bug.cgi?id=110208
Reviewed by Hajime Morrita.
Source/WebCore:
The WebCore changes are required to implement asynchronous spell checking in WK2.
The idea of asynchronous spell checking in WK1 is to pass the pointer to the abstract object
to the client who is able to verify the given text and notify the WebCore about results.
WK2 will extract the request data and pass it (with additional information) to the UIProcess.
No new tests, covered by editing/spelling tests.
- editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):
Extract the request data as it is the member of 'TextCheckingRequest'.
- editing/SpellChecker.cpp:
(WebCore):
(WebCore::SpellCheckRequest::didCancel):
(WebCore::SpellCheckRequest::setCheckerAndSequence):
(WebCore::SpellChecker::requestCheckingFor):
(WebCore::SpellChecker::enqueueRequest):
(WebCore::SpellChecker::didCheck):
(WebCore::SpellChecker::didCheckSucceed):
- platform/text/TextChecking.h:
(WebCore):
(TextCheckingRequestData):
Introduce a new 'TextCheckingRequestData' class to keep the request data and to
easy extract it from the 'TextCheckingRequest'.
(WebCore::TextCheckingRequestData::TextCheckingRequestData):
(TextCheckingRequest):
(WebCore::TextCheckingRequest::~TextCheckingRequest):
Source/WebKit/blackberry:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
Extract the request data as it is the member of 'TextCheckingRequest'.
Source/WebKit/chromium:
- src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::requestCheckingOfString):
Extract the request data as it is the member of 'TextCheckingRequest'.
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::didCheckSucceed):
(WebEditorClient::requestCheckingOfString):
Extract the request data as it is the member of 'TextCheckingRequest'.
- 9:56 PM Changeset in webkit [143687] by
-
- 4 edits in trunk/Source
Move fastlog2() to WTF/MathExtras.h so it can be used from multiple projects.
Rubberstamped by Geoff Garen.
Source/WebCore:
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::lruListFor): Remove the inline fastlog2 and use WTF::fastlog2.
Source/WTF:
- wtf/MathExtras.h:
(WTF::fastLog2):
- 9:15 PM Changeset in webkit [143686] by
-
- 12 edits2 adds in trunk/Source/WebCore
Split SelectorChecker's fast-checking logic into its own class.
https://bugs.webkit.org/show_bug.cgi?id=106860
Reviewed by Antti Koivisto.
No functional changes, covered by existing tests.
- CMakeLists.txt: Added new class to existing build system.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/CSSAllInOne.cpp: Ditto.
- css/RuleSet.cpp:
(WebCore::RuleData::RuleData): Changed to use SelectorCheckerFastPath.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matches): Ditto.
- css/SelectorChecker.h:
(SelectorChecker): Move fast path code into SelectorCheckerFastPath.
- css/SelectorCheckerFastPath.cpp: Added.
- css/SelectorCheckerFastPath.h: Added.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::ruleMatches): Changed to use SelectorCheckerFastPath.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::initialize): Ditto.
- 8:03 PM Changeset in webkit [143685] by
-
- 4 edits in trunk/Source/WebCore
Invalidate outstanding checkpoints for the background input stream and preload scanner
https://bugs.webkit.org/show_bug.cgi?id=110537
Reviewed by Adam Barth.
fast/tokenizer/write-before-load.html caused duplicate didFailSpeculation() calls for the same checkpoint.
One was triggered by processParsedChunkFromBackgroundParser and the other by resumeParsingAfterScriptExecution.
This change ensures that after we send a checkpoint, it is cleared so it won't be sent again until the next
processParsedChunkFromBackgroundParser().
No new tests because no new functionality.
- html/parser/BackgroundHTMLInputStream.cpp:
(WebCore::BackgroundHTMLInputStream::rewindTo):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didFailSpeculation):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::rewindTo):
- 7:19 PM Changeset in webkit [143684] by
-
- 2 edits in trunk/Source/WebCore
Followup commit for https://bugs.webkit.org/show_bug.cgi?id=110541
from a comment by Jon Lee.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Logic
in conditional was unnecessarily complex.
- 7:12 PM Changeset in webkit [143683] by
-
- 3 edits in trunk/Source/WebCore
Clean up computePreferredLogicalWidths functions in TableLayout subclasses
https://bugs.webkit.org/show_bug.cgi?id=110515
Reviewed by Tony Chang.
No change in behavior. This is just a cleanup in preparation for other
refactoring to this code.
- rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
Move a FIXME here from computePreferredLogicalWidths. It makes more sense here.
(WebCore::FixedTableLayout::computePreferredLogicalWidths):
-Remove outdated or unhelpful comments.
-Isolate the fixed width codepath to make it a bit less convoluted.
(WebCore::FixedTableLayout::layout):
- rendering/FixedTableLayout.h:
The argument to calcWidthArray is never used. Remove it.
- 7:01 PM Changeset in webkit [143682] by
-
- 2 edits in trunk/Source/WTF
TriState.h should be a Project header
https://bugs.webkit.org/show_bug.cgi?id=110543
Rubber-stamped by Dan Bernstein.
WTF uses a script to copy headers to the build destination, so it isn't
necessary to mark headers as Private/Public (and doing so can be problematic).
- WTF.xcodeproj/project.pbxproj: Mark TriState.h as a Project header.
- 6:54 PM Changeset in webkit [143681] by
-
- 2 edits in trunk/Source/WebCore
LayoutTests/fast/encoding/parser-tests-*.html timeout with threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=109995
Unreviewed speculative fix for Mac WK1.
It appears that m_frame can be null for Mac WK1.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoading):
- 6:48 PM Changeset in webkit [143680] by
-
- 3 edits in trunk/Source/WebCore
Better sizing model for Snapshotted plugins
https://bugs.webkit.org/show_bug.cgi?id=110541
Reviewed by Simon Fraser.
Clarify the way we apply sizing rules to snapshotted plug-ins. In
testing we've found that plug-ins smaller than 40px in either
dimension should never be frozen. Also, larger plugins should
be explicitly marked, because often they are the single dominant
element on the page.
As a drive-by, I removed the flag that indicated whether or not
the label should show automatically. It wasn't being used. This is
all determined from the shadow root and its CSS now.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): New values for size thresholds.
(WebCore::HTMLPlugInImageElement::createRenderer): Remove call to setShouldShowSnapshotLabelAutomatically.
(WebCore::classNameForShadowRoot): Remove logging and clearly assign sizing classes.
(WebCore::HTMLPlugInImageElement::updateSnapshotInfo): We don't need the page size any more.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Use new constant names.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): Remove setShouldShowSnapshotLabelAutomatically.
- 6:48 PM Changeset in webkit [143679] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix a typo that broke the 32 bit build.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 6:29 PM Changeset in webkit [143678] by
-
- 6 edits2 deletes in trunk/LayoutTests
Add support for testing states changing asynchronously. Apply it to state-url-sets-links-visited.html.
https://bugs.webkit.org/show_bug.cgi?id=109883
Reviewed by Antti Koivisto.
Some tests depends on state change happening asynchronously. This is typically solved by using
timers with a long enough interval.
Timers have the general pitfalls of causing unreliable tests, and forcing unnecessary delays
in the tests.
This patch introduces new testing helpers, shouldBecomeEqual and shouldBecomeEqualToString, to
test a change of state repetively until it succeed (or timeout). Those test functions execute
the condition every 5ms until the test succeed.
The helper shouldBecomeEqualToString is applied on state-url-sets-links-visited.html to illustrate
the concept.
- fast/js/resources/js-test-pre.js:
(_waitForCondition): Generic helper function for the familly shouldBecomeXXX.
(.condition):
(.failureHandler):
(shouldBecomeEqual):
(shouldBecomeEqualToString):
- fast/loader/stateobjects/state-url-sets-links-visited.html:
- platform/wk2/TestExpectations:
state-url-sets-links-visited.html fails on WebKit2 because the visited links table is updated
asynchronously, and the style is only updated after 1 IPC message + 1 timer + 1 IPC message.
The test is changed to use shouldBecomeEqualToString in order to become reliable. If the UIProcess
does not update the style in a reasonable amount of time, the test fails.
- 6:10 PM Changeset in webkit [143677] by
-
- 2 edits in trunk/Source/JavaScriptCore
25-30% regression in V8 RayTrace test in 32 bit builds with JIT disabled
https://bugs.webkit.org/show_bug.cgi?id=110539
Reviewed by Filip Pizlo.
Change the scale used to lookup pointers in JSGlobalObject::m_specialPointers to be 4 bytes for
the 32 bit version of the interpreter.
- llint/LowLevelInterpreter32_64.asm:
- 5:43 PM Changeset in webkit [143676] by
-
- 2 edits in trunk/Source/WebCore
Fix the build after r143664.
Unreviewed.
- WebCore.exp.in:
- 5:42 PM Changeset in webkit [143675] by
-
- 2 edits in trunk/Source/WebKit2
QuickTime plugin doesn't load when accelerated compositing is disabled
https://bugs.webkit.org/show_bug.cgi?id=110534
Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-21
Reviewed by Anders Carlsson.
We shouldn't disable accelerated compositing for plugins, because
plugins such as QuickTime rely on this and will try to set other drawing
models that we don't support.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::isAcceleratedCompositingEnabled):
- 5:40 PM Changeset in webkit [143674] by
-
- 3 edits1 delete in trunk/Source/WebKit/chromium
[Chromium] Remove chromium/public/platform directory
https://bugs.webkit.org/show_bug.cgi?id=110471
Reviewed by Adam Barth.
Part of a larger refactoring series; see tracking bug 82948.
- WebKit.gyp:
- public/platform: Removed.
- public/platform/WebKitPlatformSupport.h: Removed.
- public/platform/android: Removed.
- public/platform/default: Removed.
- public/platform/linux: Removed.
- public/platform/mac: Removed.
- public/platform/win: Removed.
- src/WebKit.cpp:
- 5:27 PM Changeset in webkit [143673] by
-
- 2 edits in trunk/Source/WebCore
tables/mozilla/bugs/bug8950.html fails with threaded parser due to attribute duplication
https://bugs.webkit.org/show_bug.cgi?id=110532
Reviewed by Adam Barth.
This is a very basic failure which we should have caught earlier with the html5lib parser
tests, except those use document.write and thus avoid the threaded parser.
AtomicHTMLToken expects its attributes to be unique. We were not doing that for the
CompactHTMLToken path, and this ancient mozilla table test caught that.
Fixes tables/mozilla/bugs/bug8950.html.
- html/parser/AtomicHTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::initializeAttributes):
- 5:26 PM Changeset in webkit [143672] by
-
- 4 edits in trunk
[chromium] support the lucid version of freetype on precise in DRT
https://bugs.webkit.org/show_bug.cgi?id=107338
Reviewed by Tony Chang.
Source/WebKit/chromium:
Add in a linux-only dependency on Freetype2 so that we can
match the version shipped in Ubuntu Lucid.
- DEPS:
Tools:
Modify the DRT build so that we can optionally link against
a fixed version of Freetype2. This allows us to share pixel test
results across multiple versions of Ubuntu without having to
worry about differences in font rendering.
At the moment this feature is off by default. Eventually it will
be on by default on linux.
Note that this only affects DRT; the regular Chromium binary
(and, for now, content_shell) will still use the system version
of Freetype.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 5:13 PM Changeset in webkit [143671] by
-
- 4 edits in trunk/Source
Unreviewed. Add executable property to cmd file.
Required for executable files to maintain their executable permissions over svn.
- JavaScriptCore.vcxproj/copy-files.cmd: Added property svn:executable.
- WTF.vcxproj/copy-files.cmd: Added property svn:executable.
- 5:13 PM Changeset in webkit [143670] by
-
- 3 edits2 adds in trunk
Threaded HTML Parser fails fast/dom/Document/readystate.html
https://bugs.webkit.org/show_bug.cgi?id=110529
Reviewed by Eric Seidel.
Source/WebCore:
We need to create the tokenizer even when we finish a script-created
parser. Most of the time, the tokenizer has already been created at
this point because it is created by calls to document.write.
Test: fast/parser/body-should-exist-after-open-close.html
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::finish):
LayoutTests:
This test is a reduction of the original issue.
- fast/parser/body-should-exist-after-open-close-expected.txt: Added.
- fast/parser/body-should-exist-after-open-close.html: Added.
- 5:11 PM Changeset in webkit [143669] by
-
- 2 edits in trunk/Source/WebCore
Lots of LayoutUnit assertions when loading a Wikipedia article
https://bugs.webkit.org/show_bug.cgi?id=110270
Reviewed by Levi Weintraub.
Change RenderBlock::adjustRectForColumns to ensure that the
endColumn calculation does not overflow.
No new tests, covered by existing tests.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustRectForColumns):
Make the endOffset value be no less than the beforeBorderPadding
value to ensure that endColumn is not negative.
- 4:56 PM Changeset in webkit [143668] by
-
- 7 edits in trunk
Tools: [Chromium] Remove the word "cheher" from the list of misspelled words
https://bugs.webkit.org/show_bug.cgi?id=110447
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-21
Reviewed by Tony Chang.
Other platforms do not mark "cheher" as a misspelled word in layout tests.
This change is to bring Chromium platform in line with the rest of the
platforms.
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(WebTestRunner::MockSpellCheck::hasInCache): Changed "cheher" to "wellcome".
(WebTestRunner::MockSpellCheck::fillSuggestionList): Removed "cheher" misspelling and "checker" suggestion.
(WebTestRunner::MockSpellCheck::initializeIfNeeded): Removed "cheher" misspelling.
LayoutTests: Fix editing/spelling/spelling-changed-text.html on Qt and GTK
https://bugs.webkit.org/show_bug.cgi?id=110447
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-21
Reviewed by Tony Chang.
After r143470 editing/spelling/spelling-changed-text.html fails on Qt and GTK,
because Qt and Gtk spelling tests do not mark "cheher" as a misspelling. This
patch changes the test to use the misspelling "wellcome" instead.
- editing/spelling/spelling-changed-text-expected.txt: Changed "cheher" to "wellcome".
- editing/spelling/spelling-changed-text.html: Changed "cheher" to "wellcome".
- platform/gtk/TestExpectations: Enabled editing/spelling/spelling-changed-text.html test.
- platform/qt/TestExpectations: Enabled editing/spelling/spelling-changed-text.html test.
- 4:55 PM Changeset in webkit [143667] by
-
- 2 edits in trunk/Source/JavaScriptCore
Object allocation profiling will refuse to create objects with more than JSFinalObject::maxInlineCapacity() inline slots, but JSFunction::allocationProfile() asserts that the number of inline slots is always what it asked for
https://bugs.webkit.org/show_bug.cgi?id=110519
<rdar://problem/13218566>
Reviewed by Geoffrey Garen.
- runtime/JSFunction.h:
(JSC::JSFunction::allocationProfile):
- 4:55 PM Changeset in webkit [143666] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r183905. Requested by
"Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21
- DEPS:
- 4:48 PM Changeset in webkit [143665] by
-
- 2 edits in trunk/Source/WebKit/chromium
IndexedDB: Remove copying WebIDBDatabase::put() stub
https://bugs.webkit.org/show_bug.cgi?id=109967
Reviewed by Darin Fisher.
Now that the chromium call to this method has
been removed, we can remove the stub.
- public/WebIDBDatabase.h:
- 4:39 PM Changeset in webkit [143664] by
-
- 6 edits in trunk
LayoutTests/fast/encoding/parser-tests-*.html timeout with threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=109995
Reviewed by Adam Barth.
Source/WebCore:
In the case where during main document onload, we
load a new iframe, and then from within that iframe
we run script to remove the iframe and call testRunner.notifyDone()
the notifyDone() will not correctly dump because
the testRunner does not yet realize that the main resource
has completed loading.
In the main-thread parser, the testRunner does correctly know
that the main thread has completed, because removing the iframe
causes a didFailLoad callback to the embedder, because when
the iframe is being removed, the DocumentLoader for that iframe
is still on the stack and believe's its loading
(because it has a MainResourceLoader which is also on the stack
delivering us the bytes which contain this inline script).
In the threaded-parser case, the DocumentLoader and MainResourceLoader
are no longer on the stack, as we are parsing the iframe asynchronously
after all the bytes have been delivered, and the MainResourceLoader destroyed.
Thus when DocumentLoader::stopLoading() is called, loading() returns
false, and it returns early. One might argue that we should remove that
early return entirely, but it seemed safer to extend the idea of
when we're loading to include the time when the parser is active.
This patch solves this by teaching the DocumentLoader that it is still
"loading" so long as the parser is still active.
Also added a call to DocumentLoader::checkLoadComplete from
Document::decrementActiveParserCount which seemed to cause
http/tests/multipart/policy-ignore-crash.php to pass.
This causes http/tests/security/feed-urls-from-remote.html to timeout
on chromium (but no other platforms that I'm aware of). I believe this
is due to a bug in our DRT implementation in the policyDelegate case
(which AFAIK is not a codepath which Chromium actually uses in the wild).
The test already times out on TOT if you remove the setCustomPolicyDelegate calls!
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoading):
(WebCore):
- loader/DocumentLoader.h:
(DocumentLoader):
LayoutTests:
Mark http/tests/security/feed-urls-from-remote.html as timeout on chromium.
I believe this is due to a bug in our DRT implementation in the policyDelegate case
(which AFAIK is not a codepath which Chromium actually uses in the wild).
The test already times out on TOT if you remove the setCustomPolicyDelegate calls.
- platform/chromium/TestExpectations:
- 4:27 PM Changeset in webkit [143663] by
-
- 6 edits2 adds in trunk
Nodes should not have attributes property
https://bugs.webkit.org/show_bug.cgi?id=110510
Reviewed by Adam Barth.
Source/WebCore:
According to http://dom.spec.whatwg.org/ attributes and hasAttributes
should be defined on Element and not on Node.
Test: fast/dom/Text/text-should-not-have-attributes.html
- dom/Element.idl:
- dom/Node.idl:
LayoutTests:
- fast/dom/Node/initial-values-expected.txt:
- fast/dom/Node/script-tests/initial-values.js:
- fast/dom/Text/text-should-not-have-attributes-expected.txt: Added.
- fast/dom/Text/text-should-not-have-attributes.html: Added.
- 4:26 PM Changeset in webkit [143662] by
-
- 1 edit in trunk/Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in
Unreviewed. Tab to spaces style fix.
- 4:21 PM Changeset in webkit [143661] by
-
- 7 edits in trunk/Source/WebCore
Make BackgroundHTMLParser rewind the preload scanner instead of clear it
https://bugs.webkit.org/show_bug.cgi?id=110517
Reviewed by Adam Barth.
No new tests becuase no new functionality.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::resumeFrom):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
- html/parser/BackgroundHTMLParser.h:
(Checkpoint):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didFailSpeculation):
- html/parser/HTMLDocumentParser.h:
(ParsedChunk):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::createCheckpoint):
(WebCore):
(WebCore::TokenPreloadScanner::rewindTo):
- html/parser/HTMLPreloadScanner.h:
(WebCore):
(TokenPreloadScanner):
(WebCore::TokenPreloadScanner::Checkpoint::Checkpoint):
(Checkpoint):
- 4:19 PM Changeset in webkit [143660] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Build fix for VS2010 WebKit solution.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 4:07 PM Changeset in webkit [143659] by
-
- 4 edits in trunk/LayoutTests
Suppressed failing tests after r143626.
These tests need to be rebaselined.
Unreviewed gardening of TestExpectations.
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 3:50 PM Changeset in webkit [143658] by
-
- 9 edits in trunk/Source
Unreviewed, rolling out r143536.
http://trac.webkit.org/changeset/143536
https://bugs.webkit.org/show_bug.cgi?id=110523
Causing a bunch of tests to fail on Windows, requires
rebaselining (Requested by rfong on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21
Source/WebCore:
- config.h:
- page/Settings.cpp:
(WebCore):
(WebCore::Settings::setShouldPaintNativeControls):
- page/Settings.h:
(Settings):
(WebCore::Settings::shouldPaintNativeControls):
- platform/win/ScrollbarThemeWin.cpp:
(WebCore):
- rendering/RenderThemeWin.cpp:
(WebCore):
Source/WebKit/win:
- WebKitClassFactory.cpp:
(WebKitClassFactory::WebKitClassFactory):
- WebView.cpp:
(WebView::initWithFrame):
(WebView::notifyPreferencesChanged):
- 3:36 PM Changeset in webkit [143657] by
-
- 18 edits6 copies18 deletes in tags/Safari-537.31.6/Source/WebKit2
Merged r142806. <rdar://problem/13236883>
- 3:29 PM Changeset in webkit [143656] by
-
- 4 edits in trunk/Source/WebCore
Don't make an overhang shadow layer when the WKView has a transparent background
https://bugs.webkit.org/show_bug.cgi?id=110429
Reviewed by Anders Carlsson.
When in coordinated scrolling mode, RenderLayerCompositor makes a layer to show
the shadow around the content when rubber-banding. However, if the view is
transparent, we don't want to make this layer, since it darkens the entire view.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateRootLayerConfiguration): Code was moved
into viewHasTransparentBackground(), so just call that here.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresContentShadowLayer): Don't make
a shadow layer when the view is transparent.
(WebCore::RenderLayerCompositor::viewHasTransparentBackground): Return
true if the view is transparent or has a non-opaque background color,
and optionally return that color.
- rendering/RenderLayerCompositor.h:
- 3:29 PM Changeset in webkit [143655] by
-
- 3 edits2 adds in trunk
[Safari] Crash with opacity + drop shadow filter + child element extending beyond filter outsets
https://bugs.webkit.org/show_bug.cgi?id=107467
Source/WebCore:
Reviewed by Dean Jackson.
The filter code plays games with the current GraphicsContext, replacing the current
context with one which will get filtered.
This doesn't play nicely with the RenderLayer code which lazily starts transparency
layers. If we don't start a transparency layer until painting a child of the filtered
layer, then the transparency layer is started using the wrong context.
Fix by eagerly starting transparency layers if we have both a filter and opacity.
Test: css3/filters/filter-with-opacity-and-children.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
LayoutTests:
Reviewed by Dean Jackson.
Testcase with filtered element with opacity, and layer child.
- css3/filters/filter-with-opacity-and-children-expected.txt: Added.
- css3/filters/filter-with-opacity-and-children.html: Added.
- 2:59 PM Changeset in webkit [143654] by
-
- 31 edits2 adds in trunk/Source/JavaScriptCore
DFG should not change its mind about what type speculations a node does, by encoding the checks in the NodeType, UseKind, and ArrayMode
https://bugs.webkit.org/show_bug.cgi?id=109371
Reviewed by Oliver Hunt.
FixupPhase now locks in the speculations that each node will do. The DFG then
remembers those speculations, and doesn't change its mind about them even if the
graph is transformed - for example if a node's child is repointed to a different
node as part of CSE, CFG simplification, or folding. Each node ensures that it
executes the speculations promised by its edges. This is true even for Phantom
nodes.
This still leaves some craziness on the table for future work, like the
elimination of speculating SetLocal's due to CFG simplification
(webkit.org/b/109388) and elimination of nodes via DCE (webkit.org/b/109389).
In all, this allows for a huge simplification of the DFG. Instead of having to
execute the right speculation heuristic each time you want to decide what a node
does (for example Node::shouldSpeculateInteger(child1, child2) &&
node->canSpeculateInteger()), you just ask for the use kinds of its children
(typically node->binaryUseKind() == Int32Use). Because the use kinds are
discrete, you can often just switch over them. This makes many parts of the code
more clear than they were before.
Having UseKinds describe the speculations being performed also makes it far
easier to perform analyses that need to know what speculations are done. This is
so far only used to simplify large parts of the CFA.
To have a larger vocabulary of UseKinds, this also changes the node allocator to
be able to round up Node sizes to the nearest multiple of 16.
This appears to be neutral on benchmarks, except for some goofy speed-ups, like
8% on Octane/box2d.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::startExecuting):
(DFG):
(JSC::DFG::AbstractState::executeEdges):
(JSC::DFG::AbstractState::verifyEdge):
(JSC::DFG::AbstractState::verifyEdges):
(JSC::DFG::AbstractState::executeEffects):
(JSC::DFG::AbstractState::execute):
- dfg/DFGAbstractState.h:
(AbstractState):
(JSC::DFG::AbstractState::filterEdgeByUse):
(JSC::DFG::AbstractState::filterByType):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::filter):
- dfg/DFGAdjacencyList.h:
(JSC::DFG::AdjacencyList::AdjacencyList):
(JSC::DFG::AdjacencyList::child):
(JSC::DFG::AdjacencyList::setChild):
(JSC::DFG::AdjacencyList::reset):
(JSC::DFG::AdjacencyList::firstChild):
(JSC::DFG::AdjacencyList::setFirstChild):
(JSC::DFG::AdjacencyList::numChildren):
(JSC::DFG::AdjacencyList::setNumChildren):
(AdjacencyList):
- dfg/DFGAllocator.h:
(DFG):
(Allocator):
(JSC::DFG::Allocator::cellSize):
(JSC::DFG::Allocator::Region::headerSize):
(JSC::DFG::Allocator::Region::numberOfThingsPerRegion):
(JSC::DFG::Allocator::Region::payloadSize):
(JSC::DFG::Allocator::Region::payloadBegin):
(JSC::DFG::Allocator::Region::payloadEnd):
(JSC::DFG::Allocator::Region::isInThisRegion):
(JSC::DFG::::Allocator):
(JSC::DFG::::~Allocator):
(JSC::DFG::::allocate):
(JSC::DFG::::free):
(JSC::DFG::::freeAll):
(JSC::DFG::::reset):
(JSC::DFG::::indexOf):
(JSC::DFG::::allocatorOf):
(JSC::DFG::::bumpAllocate):
(JSC::DFG::::freeListAllocate):
(JSC::DFG::::allocateSlow):
(JSC::DFG::::freeRegionsStartingAt):
(JSC::DFG::::startBumpingIn):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::handleMinMax):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGCommon.h:
(DFG):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGEdge.cpp:
(JSC::DFG::Edge::dump):
- dfg/DFGEdge.h:
(JSC::DFG::Edge::useKindUnchecked):
(JSC::DFG::Edge::useKind):
(JSC::DFG::Edge::shift):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::fixDoubleEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(FixupPhase):
(JSC::DFG::FixupPhase::truncateConstantToInt32):
(JSC::DFG::FixupPhase::truncateConstantsIfNecessary):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):
- dfg/DFGGraph.cpp:
(DFG):
(JSC::DFG::Graph::refChildren):
(JSC::DFG::Graph::derefChildren):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::performSubstitution):
(JSC::DFG::Graph::isPredictedNumerical):
(JSC::DFG::Graph::addImmediateShouldSpeculateInteger):
(DFG):
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::convertToGetByOffset):
(JSC::DFG::Node::convertToPutByOffset):
(JSC::DFG::Node::willHaveCodeGenOrOSR):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::binaryUseKind):
(Node):
(JSC::DFG::Node::isBinaryUseKind):
- dfg/DFGNodeAllocator.h:
(DFG):
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::nodeFlagsAsString):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::speculationCheck):
(DFG):
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::SpeculativeJIT::typeCheck):
(JSC::DFG::SpeculativeJIT::forwardTypeCheck):
(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileArithMod):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::speculateInt32):
(JSC::DFG::SpeculativeJIT::speculateNumber):
(JSC::DFG::SpeculativeJIT::speculateRealNumber):
(JSC::DFG::SpeculativeJIT::speculateBoolean):
(JSC::DFG::SpeculativeJIT::speculateCell):
(JSC::DFG::SpeculativeJIT::speculateObject):
(JSC::DFG::SpeculativeJIT::speculateObjectOrOther):
(JSC::DFG::SpeculativeJIT::speculateString):
(JSC::DFG::SpeculativeJIT::speculateNotCell):
(JSC::DFG::SpeculativeJIT::speculateOther):
(JSC::DFG::SpeculativeJIT::speculate):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstant):
(JSC::DFG::SpeculativeJIT::needsTypeCheck):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::IntegerOperand::edge):
(IntegerOperand):
(JSC::DFG::IntegerOperand::node):
(JSC::DFG::IntegerOperand::gpr):
(JSC::DFG::IntegerOperand::use):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSValueOperand):
(JSC::DFG::JSValueOperand::edge):
(JSC::DFG::JSValueOperand::node):
(JSC::DFG::JSValueOperand::gpr):
(JSC::DFG::JSValueOperand::fill):
(JSC::DFG::JSValueOperand::use):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::StorageOperand::edge):
(StorageOperand):
(JSC::DFG::StorageOperand::node):
(JSC::DFG::StorageOperand::gpr):
(JSC::DFG::StorageOperand::use):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(SpeculateIntegerOperand):
(JSC::DFG::SpeculateIntegerOperand::edge):
(JSC::DFG::SpeculateIntegerOperand::node):
(JSC::DFG::SpeculateIntegerOperand::gpr):
(JSC::DFG::SpeculateIntegerOperand::use):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateStrictInt32Operand::edge):
(JSC::DFG::SpeculateStrictInt32Operand::node):
(JSC::DFG::SpeculateStrictInt32Operand::gpr):
(JSC::DFG::SpeculateStrictInt32Operand::use):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::edge):
(JSC::DFG::SpeculateDoubleOperand::node):
(JSC::DFG::SpeculateDoubleOperand::fpr):
(JSC::DFG::SpeculateDoubleOperand::use):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(SpeculateCellOperand):
(JSC::DFG::SpeculateCellOperand::edge):
(JSC::DFG::SpeculateCellOperand::node):
(JSC::DFG::SpeculateCellOperand::gpr):
(JSC::DFG::SpeculateCellOperand::use):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
(JSC::DFG::SpeculateBooleanOperand::edge):
(SpeculateBooleanOperand):
(JSC::DFG::SpeculateBooleanOperand::node):
(JSC::DFG::SpeculateBooleanOperand::gpr):
(JSC::DFG::SpeculateBooleanOperand::use):
(DFG):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
- dfg/DFGUseKind.cpp: Added.
(WTF):
(WTF::printInternal):
- dfg/DFGUseKind.h: Added.
(DFG):
(JSC::DFG::typeFilterFor):
(JSC::DFG::isNumerical):
(WTF):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::reportValidationContext):
- 2:57 PM Changeset in webkit [143653] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, roll chromium deps 183552 -> 183788
- DEPS:
- 2:21 PM Changeset in webkit [143652] by
-
- 9 edits in trunk
Autogenerate Settings that call setNeedsRecalcStyleInAllFrames when set
https://bugs.webkit.org/show_bug.cgi?id=109989
Reviewed by Ryosuke Niwa.
.:
Add setters to export symbols.
- Source/autotools/symbols.filter:
Source/WebCore:
Start generating the code for settings that call m_page->setNeedsRecalcStyleInAllFrames()
when the value is changed. This allows us to generate 10 more settings. As a follow up, we
can remove some methods from DRT/WTR after this.
No new tests, this is a build refactor and should not impact any test results.
- page/Settings.cpp:
(WebCore::Settings::Settings): Remove member variables. Add SETTINGS_SETTER_BODIES macro that
has the generated setter bodies.
- page/Settings.h:
(Settings): Remove code that is now generated.
- page/Settings.in: Add new entries with setNeedsStyleRecalcWhenSetting=1
- page/make_settings.pl:
(defaultItemFactory): Add setNeedsStyleRecalcWhenSetting flag.
(generateSettingsMacrosHeader): Print macro for setter bodies.
(printConditionalMacros): Add setter body code.
(printGettersAndSetters): Pass in setNeedsStyleRecalcWhenSetting so we know whether to inline the
setter in the header or not.
(printGetterAndSetter): Ditto.
(printSetterBodies): Print macro for setter bodies.
(printSetterBody): Print setter body for a single setting.
- 2:03 PM Changeset in webkit [143651] by
-
- 12 edits2 adds in trunk/LayoutTests
Rebaseline 4 SVG tests after an aspect ratio change in r143389
These 4 SVG tests needed a rebaseline after fixing WK99984.
Unreviewed rebaseline of test expectations.
- platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium/TestExpectations:
- 1:53 PM Changeset in webkit [143650] by
-
- 6 edits in trunk/Source
Plug-in snapshotting code always accepts first snapshot
https://bugs.webkit.org/show_bug.cgi?id=110495
Reviewed by Tim Horton.
When we detect a plugin that can be snapshotted we start capturing
images until we find one that we believe isn't blank, or we timeout.
I introduced a regression recently where we swap renderers as
soon as the snapshot arrives, whether or not is is blank.
The fix was to have the embedder (currently only WK2) be the one
who tells the HTMLPlugInElement to start displaying snapshots.
Source/WebCore:
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInElement::setDisplayState): Make this a virtual function.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::setDisplayState): Override to call the
base class version, but swap renderers if we should move to the snapshot.
(WebCore::HTMLPlugInImageElement::updateSnapshot): Don't swap renderers here any more.
- html/HTMLPlugInImageElement.h: New virtual version of setDisplayState.
Source/WebKit2:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginSnapshotTimerFired): When we find a
snapshot that we like, tell the HTMLPlugInElement to move to
the snapshot view.
- 1:46 PM Changeset in webkit [143649] by
-
- 2 edits in trunk/Source/WebCore
Tune BackgroundHTMLParser's pendingTokenLimit based on a benchmark
https://bugs.webkit.org/show_bug.cgi?id=110408
Reviewed by Adam Barth.
This constant was tuned by running the top 25 sites in Telemetry on a Nexus 7 device.
The new value decreases the maximum time spent parsing by 40% without significantly impacting total parse time or DOMContentLoaded.
No new tests because no new functionality.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore):
- 1:45 PM ExportingSymbols edited by
- (diff)
- 1:40 PM Changeset in webkit [143648] by
-
- 2 edits in trunk/LayoutTests
Fix duplicate TestExpecataions entry for svg/custom/foreign-object-skew.svg
Unreviewed gardening of TestExpecations
- platform/chromium/TestExpectations:
- 1:22 PM Changeset in webkit [143647] by
-
- 7 edits in trunk/LayoutTests
Rebalance the running times of JSRegress somewhat.
Rubber stamped by Mark Hahnenberg.
- fast/js/regress/script-tests/adapt-to-double-divide.js:
(foo):
- fast/js/regress/script-tests/array-access-polymorphic-structure.js:
- fast/js/regress/script-tests/int-overflow-local.js:
- fast/js/regress/script-tests/method-on-number.js:
(foo):
- fast/js/regress/script-tests/rare-osr-exit-on-local.js:
- fast/js/regress/script-tests/slow-convergence.js:
- 1:11 PM Changeset in webkit [143646] by
-
- 13 edits5 deletes in trunk
Unreviewed, rolling out r143419.
http://trac.webkit.org/changeset/143419
https://bugs.webkit.org/show_bug.cgi?id=110507
Broke border-image on Mac (Requested by jpfau on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21
Source/WebCore:
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h:
(GraphicsContext):
- platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
- platform/graphics/Image.h:
(Image):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintNinePieceImage):
LayoutTests:
- fast/borders/border-image-02.html: Removed.
- platform/chromium-linux/fast/borders/border-image-02-expected.png: Removed.
- platform/chromium/TestExpectations:
- platform/chromium/fast/borders/border-image-02-expected.txt: Removed.
- platform/efl/TestExpectations:
- platform/gtk/fast/borders/border-image-02-expected.png: Removed.
- platform/gtk/fast/borders/border-image-02-expected.txt: Removed.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 1:07 PM Changeset in webkit [143645] by
-
- 1 edit9 adds in trunk/LayoutTests
Add Apache's HashMap.java translated into JavaScript as a JSRegress test
Rubber stamped by Geoffrey Garen.
- fast/js/regress/HashMap-put-get-iterate-keys.html: Added.
- fast/js/regress/HashMap-put-get-iterate.html: Added.
- fast/js/regress/HashMap-string-put-get-iterate.html: Added.
- fast/js/regress/script-tests/HashMap-put-get-iterate-keys.js: Added.
(HashMap):
(HashMap.):
(get var):
- fast/js/regress/script-tests/HashMap-put-get-iterate.js: Added.
(HashMap):
(HashMap.):
(get var):
- fast/js/regress/script-tests/HashMap-string-put-get-iterate.js: Added.
(HashMap):
(HashMap.):
(get var):
- 1:00 PM Changeset in webkit [143644] by
-
- 38 edits1 copy5 adds in trunk
XSSAuditor should block pages by redirecting to a sandboxed data: URL.
https://bugs.webkit.org/show_bug.cgi?id=110406
Reviewed by Adam Barth.
Source/WebCore:
Patch originally by mkwst@chromium.org.
Tests: http/tests/security/xssAuditor/block-does-not-leak-location.html
http/tests/security/xssAuditor/block-does-not-leak-referrer.html
http/tests/security/xssAuditor/full-block-script-tag-cross-domain.html
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
When blocking entire pages via the XSSAuditor, redirect to a data:
URL to ensure that requests for properties don't leak information.
LayoutTests:
- http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt: Added.
- http/tests/security/xssAuditor/block-does-not-leak-location.html: Added.
- http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt: Added.
- http/tests/security/xssAuditor/block-does-not-leak-referrer.html: Added.
- http/tests/security/xssAuditor/full-block-base-href-expected.txt:
- http/tests/security/xssAuditor/full-block-base-href.html:
- http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
- http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
- http/tests/security/xssAuditor/full-block-iframe-javascript-url.html:
- http/tests/security/xssAuditor/full-block-iframe-no-inherit.php:
- http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
- http/tests/security/xssAuditor/full-block-javascript-link.html:
- http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
- http/tests/security/xssAuditor/full-block-link-onclick.html:
- http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-object-tag.html:
- http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt: Added.
- http/tests/security/xssAuditor/full-block-script-tag-cross-domain.html: Added.
- http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-with-source.html:
- http/tests/security/xssAuditor/full-block-script-tag.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-1.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-2.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-3.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-4.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-5.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-6.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-7.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-8.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-9.html:
- http/tests/security/xssAuditor/report-script-tag-full-block-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-02.html:
- http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-03.html:
- http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-04.html:
Rebaselined tests. Can no longer use final location of about:blank to
indicate success.
- http/tests/security/xssAuditor/resources/utilities.js:
(checkIfFrameLocationMatchesSrcAndCallDone):
Check final location against frame source (should only match when same
origin and not blocked).
- http/tests/security/xssAuditor/resources/echo-intertag.pl:
Clean up noise in httpd error log about undefined values.
- 12:56 PM Changeset in webkit [143643] by
-
- 29 edits in trunk
Convert buttons from DeprecatedFlexBox to nondeprecated FlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=109994
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-21
Reviewed by Ojan Vafai.
Source/WebCore:
Covered by existing tests for <button> and <input
type="button|submit|reset">
- css/html.css:
(input[type="button"], input[type="submit"], input[type="reset"], input[type="file"]::-webkit-file-upload-button, button):
Convert from box-align to align-items. We are using flex-start here in
conjunction with an auto margin for correct centering. See
RenderButton.cpp below for the margin & more explanation.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
Add a case for creating a non-deprecated flex box.
- rendering/RenderButton.cpp:
(WebCore::RenderButton::RenderButton):
(WebCore::RenderButton::addChild):
(WebCore::RenderButton::removeChild):
Forward to new base class
(WebCore::RenderButton::styleWillChange):
(WebCore::RenderButton::setupInnerStyle):
We are now using flexbox properties.
- min-width is needed for correct shrinking of the contents
- margin-top and margin-bottom are used for correct centering. We
can't use align-items: center because results are incorrect when the
content overflows. See LayoutTests/fast/forms/control-clip.html
- rendering/RenderButton.h:
Inherit from RenderFlexibleBox
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::createAnonymous):
(WebCore):
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
Add a createAnonymous function to RenderFlexibleBox.
LayoutTests:
- fast/flexbox/box-orient-button.html: Change -webkit-box to
-webkit-flex, and related changes.
- fast/flexbox/resources/box-orient-button.js:
(setFlexDirection): webkitBoxOrient -> webkitFlexDirection
- fast/replaced/table-percent-height.html: Give a value to the
<input type="button"> so that the layout doesn't change. No need to
change expectations because this test uses dumpAsText() and just
compares one button's height to another.
- http/tests/security/isolatedWorld/userGestureEvents.html: Add text
to the button so that sending the click event doesn't miss the
now-smaller button.
- http/tests/security/isolatedWorld/userGestureEvents-expected.txt:
Add that text to the expectation too.
- fast/forms/button-generated-content-expected.txt:
- platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.png:
- platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.txt:
- platform/chromium-linux/fast/forms/button-generated-content-expected.png:
- platform/chromium-linux/fast/forms/button-generated-content-expected.txt:
- platform/chromium-linux/fast/forms/select-baseline-expected.png:
- platform/chromium-linux/fast/forms/select-baseline-expected.txt:
- platform/chromium-linux/svg/custom/foreign-object-skew-expected.png:
- platform/chromium-linux/svg/custom/foreign-object-skew-expected.txt:
- platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/mac/css2.1/20110323/replaced-elements-001-expected.txt:
- platform/mac/fast/forms/select-baseline-expected.txt:
- platform/mac/svg/custom/foreign-object-skew-expected.txt:
Rebaseline. Most changes come from the fact that an empty button now
consistently has a small height, when previously it would sometimes
have the height of the line. See this testcase:
https://bugs.webkit.org/attachment.cgi?id=188679
The new behavior is consistent with Firefox.
The only other difference is fast/forms/button-generated-content.html:
The empty buttons are now aligned on the baseline instead of being
vertically centered in the line. This is consistent with Firefox.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
Mark tests for rebaselining.
- 12:49 PM Changeset in webkit [143642] by
-
- 5 edits in trunk/Source
[chromium] Simplify computation of screenRect/windowRect.
https://bugs.webkit.org/show_bug.cgi?id=110456
Patch by John Mellor <johnme@chromium.org> on 2013-02-21
Reviewed by Adam Barth.
This patch removes applyDeviceScaleFactorInCompositor checks
added by http://trac.webkit.org/changeset/139356 because
Chrome for Android now sizes its screen and window in DIP
units (like other platforms), so they are no longer necessary.
Source/WebCore:
No new tests, since this is just removing an unused codepath.
- platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenRect):
(WebCore::screenAvailableRect):
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processSubtree):
Source/WebKit/chromium:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::windowRect):
- 12:41 PM Changeset in webkit [143641] by
-
- 9 edits2 deletes in trunk
Out-of-view fixed position check should not be affected by page scale at all on Mac
https://bugs.webkit.org/show_bug.cgi?id=110294
-and corresponding-
<rdar://problem/13247582>
Reviewed by Simon Fraser.
Source/WebCore:
Don't scale the layerBounds. Generally, the layerBounds should be relative to the
viewBounds which are also unscaled. Chromium used to want this behavior, but it is
covered by their pageScaleFactorAppliedInCompositor implementation now.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
LayoutTests:
These layer results should be the same regardless of the scale factor.
- compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html:
- compositing/layer-creation/fixed-position-out-of-view-scaled.html:
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed.
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Removed.
- platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
Skip these on Chromium for now.
- platform/chromium/TestExpectations:
- 12:37 PM Changeset in webkit [143640] by
-
- 4 edits2 adds in trunk
Stop starting animations when leaving a page
https://bugs.webkit.org/show_bug.cgi?id=110257
Reviewed by Stephen Chenney.
Source/WebCore:
SVGImage::resetAnimation() incorrectly started animations which could cause a crash
when leaving the page. This patch fixes resetAnimation to only stop the animation,
similar to BitmapImage::resetAnimation().
Additionally, this patch removes an unneeded call to Document::updateStyleForAllDocuments()
that was present in the animation loop. This makes the animation code more resistant to
similar bugs in the future.
Both of these changes are functionally covered with existing tests.
Test: svg/animations/reset-animation-crash.html
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::updateAnimations):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::resetAnimation):
LayoutTests:
- svg/animations/reset-animation-crash-expected.html: Added.
- svg/animations/reset-animation-crash.html: Added.
- 12:33 PM Changeset in webkit [143639] by
-
- 2 edits in trunk/Source/Platform
[chromium] Remove deprecated WebCompositorSupport::createLayerTreeView() declaration
https://bugs.webkit.org/show_bug.cgi?id=110492
Patch by James Robinson <jamesr@chromium.org> on 2013-02-21
Reviewed by Adrienne Walker.
- chromium/public/WebCompositorSupport.h:
(WebCompositorSupport):
- 12:31 PM Changeset in webkit [143638] by
-
- 3 edits in trunk/Tools
[chromium] document WebTestDelegate and WebTestRunner interfaces
https://bugs.webkit.org/show_bug.cgi?id=110472
Reviewed by Adam Barth.
Also remove the default implementation of the remaining WebTestDelegate
methods now that all embedders provide this interface.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestDelegate):
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner):
- 12:00 PM Changeset in webkit [143637] by
-
- 50 edits3 adds in trunk
Objective-C API: Need a way to use the Objective-C JavaScript API with WebKit
https://bugs.webkit.org/show_bug.cgi?id=106059
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
- API/JSBase.h: Renamed enable flag for API.
- API/JSBlockAdaptor.h: Using new flag.
- API/JSBlockAdaptor.mm: Ditto.
- API/JSContext.h: Add convenience C API conversion function for JSGlobalContextRef.
- API/JSContext.mm:
(-[JSContext JSGlobalContextRef]): Implementation of C API convenience function.
(-[JSContext initWithVirtualMachine:]): We don't use the m_apiData field any more.
(-[JSContext initWithGlobalContextRef:]): init method for allocating new JSContexts given a JSGlobalContextRef.
(-[JSContext dealloc]): No more m_apiData.
(-[JSContext wrapperForObjCObject:]): Renamed wrapperForObject.
(-[JSContext wrapperForJSObject:]): Fetches or allocates the JSValue for the specified JSValueRef in this JSContext.
(+[JSContext contextWithGlobalContextRef:]): Helper function to grab the lightweight JSContext wrapper for a given
JSGlobalContextRef from the global wrapper cache or allocate a new one if there isn't already one.
- API/JSContextInternal.h: New flag, new method declaration for initWithGlobalContextRef.
- API/JSExport.h: New flag.
- API/JSValue.h: New flag and new C API convenience method.
- API/JSValue.mm:
(-[JSValue JSValueRef]): Implementation of the C API convenience method.
(objectToValueWithoutCopy):
(+[JSValue valueWithValue:inContext:]): We now ask the JSContext for an Objective-C JSValue wrapper, which it can cache
in its internal JSWrapperMap.
- API/JSValueInternal.h:
- API/JSVirtualMachine.h:
- API/JSVirtualMachine.mm: Added global cache that maps JSContextGroupRef -> JSVirtualMachine lightweight wrappers.
(wrapperCacheLock):
(initWrapperCache):
(+[JSVMWrapperCache addWrapper:forJSContextGroupRef:]):
(+[JSVMWrapperCache wrapperForJSContextGroupRef:]):
(-[JSVirtualMachine init]):
(-[JSVirtualMachine initWithContextGroupRef:]):
(-[JSVirtualMachine dealloc]):
(+[JSVirtualMachine virtualMachineWithContextGroupRef:]):
(-[JSVirtualMachine contextForGlobalContextRef:]):
(-[JSVirtualMachine addContext:forGlobalContextRef:]):
- API/JSVirtualMachineInternal.h:
- API/JSWrapperMap.h:
- API/JSWrapperMap.mm:
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]): We use the JSObjectSetPrototype C API call because
setting the proto property causes all sorts of bad things to happen behind the scenes, which can cause crashes based on
when it gets called.
(-[JSWrapperMap initWithContext:]):
(-[JSWrapperMap jsWrapperForObject:]):
(-[JSWrapperMap objcWrapperForJSValueRef:]):
- API/JavaScriptCore.h:
- API/ObjCCallbackFunction.h:
- API/ObjCCallbackFunction.mm:
(ObjCCallbackFunction::ObjCCallbackFunction): We never actually should have retained the target in the case that we had a
block as a callback. Blocks are initially allocated on the stack and are only moved to the heap if we call their copy method.
Retaining the block on the stack was a bad idea because if that stack frame ever went away and we called the block later,
we'd crash and burn.
(ObjCCallbackFunction::setContext): We need a new setter for when the weak reference to a JSContext inside an ObjCCallbackFunction
disappears, we can allocate a new one in its place.
(ObjCCallbackFunction):
(objCCallbackFunctionCallAsFunction): Reset the callback's context if it's ever destroyed.
(objCCallbackFunctionForInvocation): Again, don't set the proto property because it uses black magic that can cause us to crash
depending on when this is called.
(objCCallbackFunctionForBlock): Here is where we copy the block to the heap when we're first creating the callback object for it.
- API/tests/testapi.c:
(main):
- API/tests/testapi.mm: We're going to get rid of the automatic block conversion, since that is causing leaks. I changed it
here in this test just so that it wouldn't mask any other potential leaks. Also modified some of the tests since JSContexts are
just lightweight wrappers now, we're not guaranteed to get the same pointer back from the call to [JSValue context] as the one
that the value was created in.
(-[TestObject callback:]):
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData): No more m_apiData.
- runtime/JSGlobalData.h: Ditto.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject): Ditto.
- runtime/JSGlobalObject.h:
Source/WebCore:
Reviewed by Geoffrey Garen.
- WebCore.exp.in:
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::setWindow): Since we're basically abandoning a JSDOMWindow here, we call
garbageCollectSoon().
- bindings/js/JSDOMWindowShell.h:
- bindings/js/ScriptController.h: New function to get the JSContext for the global object of the current main world.
- bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::javaScriptContext): Ditto.
- bindings/objc/WebScriptObject.h: Added ifdef guards. Also new convenience conversion function for the JSC Obj-C API.
- bindings/objc/WebScriptObject.mm: JSC::JSValue and JSValue conflict with one another, so we have to be more specific.
(-[WebScriptObject _globalContextRef]): Useful helper function for getting the JSGlobalContextRef of a particular WebScriptObject.
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject webScriptValueAtIndex:]):
(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):
(-[WebScriptObject JSValue]): Implementation of convenience WebScriptObject conversion function to new Objective-C API.
- bindings/objc/WebScriptObjectPrivate.h:
Source/WebKit/mac:
Reviewed by Geoffrey Garen.
Addition of appropriate delegate callbacks and support to the WebKit API.
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebDelegateImplementationCaching.h:
(WebFrameLoadDelegateImplementationCache):
- WebView/WebFrame.h:
- WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
(-[WebFrame _javaScriptContextForScriptWorld:]):
(-[WebFrame javaScriptContext]):
- WebView/WebFrameLoadDelegate.h:
- WebView/WebFramePrivate.h:
- WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame _convertValueToObjcValue:JSC::]):
(-[WebScriptCallFrame exception]):
(-[WebScriptCallFrame evaluateWebScript:]):
- WebView/WebScriptWorld.h:
- WebView/WebScriptWorld.mm:
(+[WebScriptWorld scriptWorldForJavaScriptContext:]):
- WebView/WebView.mm:
(-[WebView _cacheFrameLoadDelegateImplementations]):
(aeDescFromJSValue):
(-[WebView aeDescByEvaluatingJavaScriptFromString:]):
(-[WebView _computedStyleIncludingVisitedInfo:forElement:]):
Source/WTF:
Reviewed by Geoffrey Garen.
- wtf/FeatureDefines.h: Added enable flag for JSC Objective-C API so it can be used in
export files.
Tools:
Reviewed by Geoffrey Garen.
Added new tests for the WebKit API portion of the JSC Objective-C API.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/JSContextBackForwardCache1.html: Added.
- TestWebKitAPI/Tests/mac/JSContextBackForwardCache2.html: Added.
- TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm: Added.
(-[MyConsole log:]):
(-[MyConsole printHelloWorld]):
(-[MyConsole add:to:]):
(-[DidCreateJavaScriptContextFrameLoadDelegate webView:didFinishLoadForFrame:]):
(-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):
- 11:56 AM Changeset in webkit [143636] by
-
- 2 edits in trunk/Source/WebCore
[V8] Rename add{Node,Object}ToGroup() to add{Node,Object}WrapperToGroup()
https://bugs.webkit.org/show_bug.cgi?id=110404
Reviewed by Adam Barth.
The current function name is confusing
(See discussion in bug 110396). We should rename the functions
so that it becomes clear that "Node"/"Object" refers to a type
of a wrapper in the second argument.
No tests. No change in behavior.
- bindings/v8/V8GCController.cpp:
(WebCore::WrapperGrouper::addObjectWrapperToGroup):
(WebCore::WrapperGrouper::addNodeWrapperToGroup):
- 11:39 AM Changeset in webkit [143635] by
-
- 2 edits in trunk/Tools
Unreviewed, add myself as a reviewer
- Scripts/webkitpy/common/config/committers.py:
- 11:35 AM Changeset in webkit [143634] by
-
- 2 edits in tags/Safari-537.31.6/Source/WebKit2
Merged r143552. <rdar://problem/13157837>
- 11:30 AM Changeset in webkit [143633] by
-
- 4 edits in tags/Safari-537.31.6/Source
Versioning.
- 11:26 AM Changeset in webkit [143632] by
-
- 1 copy in tags/Safari-537.31.6
New Tag.
- 11:20 AM Changeset in webkit [143631] by
-
- 2 edits in trunk/Source/WebCore
[JS Binding] ScriptObject default constructor should initialize the Script State to 0
https://bugs.webkit.org/show_bug.cgi?id=110177
Reviewed by Geoffrey Garen.
Adding the initialization of ScriptState to 0.
- bindings/js/ScriptObject.h:
(WebCore::ScriptObject::ScriptObject):
- 11:19 AM Changeset in webkit [143630] by
-
- 3 edits3 adds in trunk
REGRESSION: Crash in MainResourceLoader::setDataBufferingPolicy when sharing an html5 video via email
https://bugs.webkit.org/show_bug.cgi?id=110075
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: webarchive/loading/video-in-webarchive.html
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::continueAfterContentPolicy): isStopping()
isn't accurate to determine whether a SubstituteData load should
continue, as this point in the code shouldn't be reachable from any point
where isStopping() would return true. DocumentLoader might have completely
stopped and believe that MainResourceLoader is complete, though. Don't
continue in that case.
(WebCore::MainResourceLoader::setDataBufferingPolicy): m_resource can be null
in a reasonable case, handle it rather than asserting that it can't be null.
LayoutTests:
- webarchive/loading/resources/video-in-webarchive.webarchive: Added.
- webarchive/loading/video-in-webarchive-expected.txt: Added.
- webarchive/loading/video-in-webarchive.html: Added.
- 11:09 AM Changeset in webkit [143629] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] WebPagePrivate::load should not check new window policy
https://bugs.webkit.org/show_bug.cgi?id=110403
Patch by Andrew Lo <anlo@rim.com> on 2013-02-21
Reviewed by Rob Buis.
Based on my understanding of changeset 135952, we should
not check the new window policy in WebPagePrivate::load.
None of the other ports seem to do this, except for plugins.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::load):
- 10:51 AM Changeset in webkit [143628] by
-
- 5 edits2 deletes in trunk
Unreviewed, rolling out r143616.
http://trac.webkit.org/changeset/143616
https://bugs.webkit.org/show_bug.cgi?id=110491
Caused a test failure on Chromium Mac. (Requested by vollick
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21
Source/WebCore:
- page/FrameView.cpp:
(WebCore::FrameView::visibleContentsResized):
- page/FrameView.h:
(FrameView):
- page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
LayoutTests:
- platform/chromium/fast/repaint/relayout-fixed-position-after-scale-expected.html: Removed.
- platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html: Removed.
- 10:46 AM Changeset in webkit [143627] by
-
- 9 edits in trunk/Source/WebCore
Overflow can be cleared just before it is computed
https://bugs.webkit.org/show_bug.cgi?id=110361
Reviewed by David Hyatt.
Overflow can be cleared just before it is computed in a lot of places because overflow computation happens all at once
now rather than cumulatively during layout. Any object that doesn't use computeOverflow() will still need to clear it manually
though.
No new tests, refactoring.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::simplifiedLayout):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::layout):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
- 10:25 AM Changeset in webkit [143626] by
-
- 303 edits4 copies5 adds in trunk
Mark GraphicsLayers as opaque when possible
https://bugs.webkit.org/show_bug.cgi?id=70634
Reviewed by Simon Fraser.
Source/WebCore:
Mark layers as opaque in a very simple case - the main renderer has an
opaque background and covers the entire composited bounds.
RenderLayer::contentsOpaqueInRect has been implemented conservatively,
i.e. it errs towards returning false negative.
Tests: compositing/contents-opaque/contents-opaque-background-clip.html
compositing/contents-opaque/contents-opaque-background-color.html
compositing/contents-opaque/contents-opaque-layer-opacity.html
compositing/contents-opaque/contents-opaque-layer-transform.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::backgroundIsOpaqueInRect):
(WebCore):
- rendering/RenderBox.h:
(RenderBox):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::backgroundIsOpaqueInRect):
(WebCore::RenderBoxModelObject::foregroundIsOpaqueInRect):
(RenderBoxModelObject):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::contentsOpaqueInRect):
(WebCore):
(WebCore::RenderLayer::listContentsOpaqueInRect):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderLayerModelObject.h:
(RenderLayerModelObject):
LayoutTests:
- compositing/absolute-inside-out-of-view-fixed-expected.txt:
- compositing/backing/no-backing-for-clip-expected.txt:
- compositing/backing/no-backing-for-clip-overlap-expected.txt:
- compositing/backing/no-backing-for-perspective-expected.txt:
- compositing/clip-child-by-non-stacking-ancestor-expected.txt:
- compositing/columns/composited-in-paginated-expected.txt:
- compositing/contents-opaque/contents-opaque-background-clip-expected.txt: Copied from LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt.
- compositing/contents-opaque/contents-opaque-background-clip.html: Added.
- compositing/contents-opaque/contents-opaque-background-color-expected.txt: Copied from LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt.
- compositing/contents-opaque/contents-opaque-background-color.html: Added.
- compositing/contents-opaque/contents-opaque-layer-opacity-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
- compositing/contents-opaque/contents-opaque-layer-opacity.html: Added.
- compositing/contents-opaque/contents-opaque-layer-transform-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
- compositing/contents-opaque/contents-opaque-layer-transform.html: Added.
- compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt:
- compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- compositing/geometry/bounds-ignores-hidden-expected.txt:
- compositing/geometry/clip-expected.txt:
- compositing/geometry/clip-inside-expected.txt:
- compositing/geometry/fixed-position-composited-switch-expected.txt:
- compositing/geometry/flipped-writing-mode-expected.txt:
- compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
- compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
- compositing/geometry/limit-layer-bounds-fixed-expected.txt:
- compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
- compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- compositing/geometry/limit-layer-bounds-positioned-expected.txt:
- compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
- compositing/geometry/limit-layer-bounds-transformed-expected.txt:
- compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
- compositing/geometry/preserve-3d-switching-expected.txt:
- compositing/iframes/become-composited-nested-iframes-expected.txt:
- compositing/iframes/become-overlapped-iframe-expected.txt:
- compositing/iframes/composited-parent-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- compositing/iframes/connect-compositing-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe2-expected.txt:
- compositing/iframes/connect-compositing-iframe3-expected.txt:
- compositing/iframes/enter-compositing-iframe-expected.txt:
- compositing/iframes/iframe-resize-expected.txt:
- compositing/iframes/invisible-nested-iframe-hide-expected.txt:
- compositing/iframes/invisible-nested-iframe-show-expected.txt:
- compositing/iframes/overlapped-iframe-expected.txt:
- compositing/iframes/overlapped-iframe-iframe-expected.txt:
- compositing/iframes/overlapped-nested-iframes-expected.txt:
- compositing/iframes/page-cache-layer-tree-expected.txt:
- compositing/iframes/scrolling-iframe-expected.txt:
- compositing/layer-creation/animation-overlap-with-children-expected.txt:
- compositing/layer-creation/fixed-position-and-transform-expected.txt:
- compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- compositing/layer-creation/fixed-position-under-transform-expected.txt:
- compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- compositing/layer-creation/overflow-scroll-overlap-expected.txt:
- compositing/layer-creation/overlap-animation-clipping-expected.txt:
- compositing/layer-creation/overlap-animation-expected.txt:
- compositing/layer-creation/overlap-child-layer-expected.txt:
- compositing/layer-creation/overlap-clipping-expected.txt:
- compositing/layer-creation/overlap-transformed-3d-expected.txt:
- compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
- compositing/layer-creation/overlap-transformed-layer-expected.txt:
- compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
- compositing/layer-creation/overlap-transforms-expected.txt:
- compositing/layer-creation/spanOverlapsCanvas-expected.txt:
- compositing/layer-creation/stacking-context-overlap-expected.txt:
- compositing/layer-creation/translatez-overlap-expected.txt:
- compositing/masks/mask-layer-size-expected.txt:
- compositing/overflow-trumps-transform-style-expected.txt:
- compositing/overflow/clip-descendents-expected.txt:
- compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- compositing/overflow/textarea-scroll-touch-expected.txt:
- compositing/plugins/no-backing-store-expected.txt:
- compositing/repaint/invalidations-on-composited-layers-expected.txt:
- compositing/rtl/rtl-absolute-expected.txt:
- compositing/rtl/rtl-absolute-overflow-expected.txt:
- compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-fixed-expected.txt:
- compositing/rtl/rtl-fixed-overflow-expected.txt:
- compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-iframe-absolute-expected.txt:
- compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
- compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-iframe-fixed-expected.txt:
- compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
- compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-iframe-relative-expected.txt:
- compositing/rtl/rtl-relative-expected.txt:
- compositing/tiled-layers-hidpi-expected.txt:
- compositing/tiling/backface-preserve-3d-tiled-expected.txt:
- compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- compositing/tiling/huge-layer-add-remove-child-expected.txt:
- compositing/tiling/huge-layer-with-layer-children-expected.txt:
- compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- compositing/tiling/rotated-tiled-clamped-expected.txt:
- compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- compositing/tiling/tile-cache-zoomed-expected.txt:
- compositing/tiling/tiled-layer-resize-expected.txt:
- compositing/visible-rect/2d-transformed-expected.txt:
- compositing/visible-rect/3d-transform-style-expected.txt:
- compositing/visible-rect/3d-transformed-expected.txt:
- compositing/visible-rect/animated-expected.txt:
- compositing/visible-rect/animated-from-none-expected.txt:
- compositing/visible-rect/clipped-by-viewport-expected.txt:
- compositing/visible-rect/clipped-visible-rect-expected.txt:
- compositing/visible-rect/iframe-and-layers-expected.txt:
- compositing/visible-rect/iframe-no-layers-expected.txt:
- compositing/visible-rect/nested-transform-expected.txt:
- compositing/visible-rect/scrolled-expected.txt:
- css3/filters/filtered-compositing-descendant-expected.txt:
- platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/chromium-mac/compositing/overflow/textarea-scroll-touch-expected.txt:
- platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt:
- platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
- platform/chromium-win/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- platform/chromium-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
- platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/chromium-win/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/backing/no-backing-for-clip-expected.txt:
- platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt:
- platform/chromium/compositing/columns/composited-in-paginated-expected.txt:
- platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium/compositing/geometry/clip-expected.txt:
- platform/chromium/compositing/geometry/clip-inside-expected.txt:
- platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt:
- platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt:
- platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
- platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/chromium/compositing/iframes/become-composited-nested-iframes-expected.txt:
- platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
- platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/chromium/compositing/iframes/iframe-resize-expected.txt:
- platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
- platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt:
- platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
- platform/chromium/compositing/iframes/overlapped-iframe-iframe-expected.txt:
- platform/chromium/compositing/iframes/overlapped-nested-iframes-expected.txt:
- platform/chromium/compositing/iframes/resizer-expected.txt:
- platform/chromium/compositing/iframes/scrolling-iframe-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt:
- platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-animation-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-3d-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
- platform/chromium/compositing/layer-creation/spanOverlapsCanvas-expected.txt:
- platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt:
- platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt:
- platform/chromium/compositing/overflow-trumps-transform-style-expected.txt:
- platform/chromium/compositing/overflow/clip-descendents-expected.txt:
- platform/chromium/compositing/rtl/rtl-absolute-expected.txt:
- platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt:
- platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
- platform/chromium/compositing/rtl/rtl-fixed-expected.txt:
- platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/chromium/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium/compositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium/compositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium/compositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium/compositing/rtl/rtl-relative-expected.txt:
- platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- platform/efl/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
- platform/mac/compositing/iframes/resizer-expected.txt:
- platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt:
- platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
- platform/mac/compositing/tiling/tiled-layer-resize-expected.txt:
- platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
- platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
- platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
- platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
- platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/qt/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/qt/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
- platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- 10:21 AM Changeset in webkit [143625] by
-
- 3 edits in trunk/Tools
Unreviewed; add myself to the Media watchlist and update my committers.py setting to Reviewer.
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/watchlist:
- 10:07 AM Changeset in webkit [143624] by
-
- 3 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk
Merge r143619 - [GTK] Remove subresource leaks from WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=108960
Patch by George McCollister <george.mccollister@gmail.com> on 2013-02-21
Reviewed by Martin Robinson.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidFinishLoading): Remove resource
if it isn't the main resource to prevent leak.
(WebKit::FrameLoaderClient::dispatchDidFailLoading): Ditto
- webkit/webkitwebview.cpp:
(cleanupTemporarilyCachedSubresources): Added to cleanup subresources.
(webkit_web_view_get_subresources): Use getSubresources from the
documentLoader to provide subresources since resources will be removed
from webview after loading.
- 10:04 AM Changeset in webkit [143623] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Tools
Merge r143620 - gtk/DumpRenderTree.cpp is missing <locale.h> include
https://bugs.webkit.org/show_bug.cgi?id=109386
- DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build
by include locale.h when we use setlocale.
- 10:02 AM Changeset in webkit [143622] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0/Source
Merge r143618 - A couple more 'make dist' fixes for WebKitGTK+.
Source/WebCore:
- GNUmakefile.list.am: Add a missing file to the source list.
Source/WTF:
- GNUmakefile.list.am: Add a missing file to the source list.
- 9:58 AM WebKitGTK/2.0.x edited by
- (diff)
- 9:57 AM WebKitGTK/2.0.x edited by
- (diff)
- 9:53 AM Changeset in webkit [143621] by
-
- 6 edits in trunk
[CSS Grid Layout] Implement grid growth during auto placement
https://bugs.webkit.org/show_bug.cgi?id=110418
Reviewed by Ojan Vafai.
Source/WebCore:
This change implements the last remaining piece of the auto placement algorithm:
growing the grid mid-placement. With that landed, we should handle all cases properly.
Change covered by : fast/css-grid-layout/grid-item-addition-auto-placement.html
fast/css-grid-layout/grid-item-removal-auto-placement.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::growGrid):
Added this helper function to grow the grid one item in a direction.
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
Updated this function to grow in the minor axis direction and insert in the
newly created grid area.
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
Updated this function to grow in the major axis direction and insert in the
newly create grid area. Unfortunately this code cannot use the iterator to find
the new position as the (auto, auto) case iterates orthogonally to the major axis
direction, which we just grew.
- rendering/RenderGrid.h:
Added growGrid.
LayoutTests:
- fast/css-grid-layout/grid-item-addition-auto-placement-update-expected.txt:
- fast/css-grid-layout/grid-item-removal-auto-placement-update-expected.txt:
- 9:52 AM Changeset in webkit [143620] by
-
- 2 edits in trunk/Tools
gtk/DumpRenderTree.cpp is missing <locale.h> include
https://bugs.webkit.org/show_bug.cgi?id=109386
- DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build
by include locale.h when we use setlocale.
- 9:50 AM Changeset in webkit [143619] by
-
- 3 edits in trunk/Source/WebKit/gtk
[GTK] Remove subresource leaks from WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=108960
Patch by George McCollister <george.mccollister@gmail.com> on 2013-02-21
Reviewed by Martin Robinson.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidFinishLoading): Remove resource
if it isn't the main resource to prevent leak.
(WebKit::FrameLoaderClient::dispatchDidFailLoading): Ditto
- webkit/webkitwebview.cpp:
(cleanupTemporarilyCachedSubresources): Added to cleanup subresources.
(webkit_web_view_get_subresources): Use getSubresources from the
documentLoader to provide subresources since resources will be removed
from webview after loading.
- 9:49 AM Changeset in webkit [143618] by
-
- 4 edits in trunk/Source
A couple more 'make dist' fixes for WebKitGTK+.
Source/WebCore:
- GNUmakefile.list.am: Add a missing file to the source list.
Source/WTF:
- GNUmakefile.list.am: Add a missing file to the source list.
- 9:42 AM Changeset in webkit [143617] by
-
- 3 edits2 adds in trunk
-webkit-margin-collapse: separate doesn't work correctly for before margins
https://bugs.webkit.org/show_bug.cgi?id=109956
Reviewed by David Hyatt.
Source/WebCore:
The collapsing code for "-webkit-margin-collapse: separate" assumed the margin value inside
marginInfo always contributes to the position of the child. This is valid only if the collapse
doesn't happen at the before side of the container. In that case, the child needs to be positioned
at the margin value specified in the style sheet.
Test: fast/block/margin-collapse/webkit-margin-collapse-separate-position.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::collapseMargins):
LayoutTests:
The test verifies a child specifying "-webkit-margin-collapse: separate" is correctly positioned inside
its container, at a value equal with the top margin of the child. The container also need to be sized
accordingly.
- fast/block/margin-collapse/webkit-margin-collapse-separate-position-expected.txt: Added.
- fast/block/margin-collapse/webkit-margin-collapse-separate-position.html: Added.
- 9:31 AM Changeset in webkit [143616] by
-
- 5 edits2 adds in trunk
Need to re-layout fixed position elements after scale when using settings()->fixedElementsLayoutRelativeToFrame()
https://bugs.webkit.org/show_bug.cgi?id=105486
Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-02-21
Reviewed by James Robinson.
In settings()->fixedElementsLayoutRelativeToFrame() mode, fixed-position
elements are layout relative to the current visible viewport, which can
be different from the layout viewport when using fixed-layout mode.
We need to re-layout fixed-position elements in case of visible content
size changes.
The test is currently chromium-specific due to difficulties to make this
test works on Mac. The mac port seems to work very differently with
visible content size when a page is scaled. And there is no reliable way
to hide scrollbars in mac-wk1 that doesn't cause a side effect.
Source/WebCore:
Test: platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html
- page/FrameView.cpp:
(WebCore::FrameView::visibleContentsResized):
- page/FrameView.h:
(FrameView):
- page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
LayoutTests:
- platform/chromium/fast/repaint/relayout-fixed-position-after-scale-expected.html: Added.
- platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html: Added.
- 9:18 AM Changeset in webkit [143615] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] BackingStore: replace instrument{Begin,Cancel}Frame with did{Begin,Cancel}Frame
https://bugs.webkit.org/show_bug.cgi?id=110460
Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Rob Buis.
This was renamed incorrectly in r142879.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
(BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):
- 9:11 AM Changeset in webkit [143614] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Extra ResourceRequest parameter in FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload
https://bugs.webkit.org/show_bug.cgi?id=110451
Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-21
Reviewed by Rob Buis.
Remove the extra ResourceRequest parameter from
FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
- WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):
- 9:09 AM Changeset in webkit [143613] by
-
- 1 edit2 adds in trunk/LayoutTests
[CSS Regions] border-radius on a region causes overflow to be hidden
https://bugs.webkit.org/show_bug.cgi?id=103684
Reviewed by Tony Chang.
The fix for https://bugs.webkit.org/show_bug.cgi?id=74132, making RenderRegion
inherit from RenderBlock instead of RenderReplaced, also fixed this bug.
Still, it deserves a test.
- fast/regions/last-region-border-radius-expected.html: Added.
- fast/regions/last-region-border-radius.html: Added.
- 9:02 AM Changeset in webkit [143612] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] LayerFilterRenderer: fix inclusion of Vector.h
https://bugs.webkit.org/show_bug.cgi?id=110476
Patch by Xan Lopez <xlopez@rim.com> on 2013-02-21
Reviewed by Rob Buis.
Added in r124242. The include line should be wtf/Vector.h
- platform/graphics/blackberry/LayerFilterRenderer.cpp:
- 8:54 AM Changeset in webkit [143611] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Adapt to name changes in WebCore::ViewPortArguments
https://bugs.webkit.org/show_bug.cgi?id=110469
Patch by Xan Lopez <xlopez@rim.com> on 2013-02-21
Reviewed by Rob Buis.
This changed in r134765.
- Api/WebViewportArguments.cpp:
(BlackBerry::WebKit::WebViewportArguments::zoom):
(BlackBerry::WebKit::WebViewportArguments::setZoom):
(BlackBerry::WebKit::WebViewportArguments::minZoom):
(BlackBerry::WebKit::WebViewportArguments::setMinZoom):
(BlackBerry::WebKit::WebViewportArguments::maxZoom):
(BlackBerry::WebKit::WebViewportArguments::setMaxZoom):
(BlackBerry::WebKit::WebViewportArguments::userZoom):
(BlackBerry::WebKit::WebViewportArguments::setUserZoom):
- Api/WebViewportArguments.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::didSetSVGZoomAndPan):
- 8:50 AM Changeset in webkit [143610] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Move posting and scrollbar updates to the page client.
https://bugs.webkit.org/show_bug.cgi?id=110256
Internal PR 297099
Reviewed by Rob Buis.
In blitVisibleContents(), we were calling the WebKit thread
functions BackingStorePrivate::isScrollingOrZooming() and
WebPage::isVisible(). This is not the right spot to do it.
Furthermore, we want to move away from direct window access
in WebKit and leave that kind of dirtywork to the client.
This patch removes invalidateWindow() as well as the two
virtual scrollbar drawing functions and replaces it with
one new virtual, WebPageClient::postToSurface().
This clears up threading issues and gets us another step
further towards pure WebPageCompositor rendering.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- Api/BackingStore_p.h:
(BackingStorePrivate):
- Api/WebPageClient.h:
- 8:46 AM Changeset in webkit [143609] by
-
- 1 edit2 adds in trunk/LayoutTests
[New Multicolumn] Add a positioned object pagination test.
https://bugs.webkit.org/show_bug.cgi?id=110480.
Reviewed by Antti Koivisto.
- fast/multicol/newmulticol/positioned-split-expected.html: Added.
- fast/multicol/newmulticol/positioned-split.html: Added.
- 8:37 AM Changeset in webkit [143608] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening; unskip test that is now passing on the bots.
- platform/efl/TestExpectations:
- 8:33 AM Changeset in webkit [143607] by
-
- 7 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Rename Localizer to Locale
https://bugs.webkit.org/show_bug.cgi?id=110449
Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-21
Reviewed by Rob Buis.
- WebCoreSupport/ColorPickerClient.cpp:
(WebCore::ColorPickerClient::locale):
- WebCoreSupport/ColorPickerClient.h:
(ColorPickerClient):
- WebCoreSupport/DatePickerClient.cpp:
(WebCore::DatePickerClient::locale):
- WebCoreSupport/DatePickerClient.h:
(DatePickerClient):
- WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::locale):
- WebCoreSupport/SelectPopupClient.h:
(SelectPopupClient):
- 8:33 AM Changeset in webkit [143606] by
-
- 3 edits in trunk/Source/WebCore
[New Multicolumn] Remove unneeded layout method in RenderMultiColumnFlowThread.
https://bugs.webkit.org/show_bug.cgi?id=110477.
Reviewed by Antti Koivisto.
I forgot that both the sets and the flow thread lay out before the containing
RenderMultiColumnBlock has finished. That means it hasn't computed its overflow yet.
Therefore there is no need to force it to compute its overflow from inside
RenderMultiColumnFlowThread::layout, because the minute RenderMultiColumnFlowThread
finishes its layout, the block will compute its overflow anyway.
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore):
- rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):
- 8:30 AM Changeset in webkit [143605] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/inspector/InspectorDebuggerAgent.cpp
Merge 143334
Web Inspector: release backtrace object group on each step.
https://bugs.webkit.org/show_bug.cgi?id=110223
Reviewed by Pavel Feldman.
- inspector/InspectorDebuggerAgent.cpp:
(WebCore):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):
TBR=podivilov@chromium.org
Review URL: https://codereview.chromium.org/12316038
- 8:19 AM Changeset in webkit [143604] by
-
- 9 edits2 adds3 deletes in trunk
[GTK] Move feature overriding to the configure phase
https://bugs.webkit.org/show_bug.cgi?id=110293
Reviewed by Gustavo Noronha Silva.
.:
Rework the feature overrides logic so all feature defines go into a
header rather than the command line. This has a few benefits. Most
notably, we can reuse the header in the gyp build. Another nice result
is that changes to the configuration automatically result in a full
rebuild and Debug and Release builds can have different configurations.
All feature define processing happens now during the configuration phase,
instead of when running autogen.sh. This means that we need to distribute
the feature processing script.
- GNUmakefile.am: Read feature defines from WebKitFeatures.txt when kicking
off a build. Also include generate-feature-defines-files in the distribution.
- Source/autotools/SetupAutoconfHeader.m4: Remove an extra ENABLE_3D_RENDERING
from the autoconf header, as it is already provided by the feature configuration.
- Source/autotools/SetupWebKitFeatures.m4: Added.
- Source/autotools/webkitfeature.m4: Removed. The functionality has been moved
to SetupWebKitFeatures.m4.
- autogen.sh: Remove the call to override-feature-defines.
- configure.ac: Now include SetupWebKitFeatures.
Source/WebCore:
- GNUmakefile.am: No longer include GNUmakefile.features.am. We don't
have to process the result of this file or do any modification of
feature_defines_override, because this variable is gone.
Tools:
- Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
WebKitFeatureOverrides.txt to better match the other filenames used in
the new feature processing.
- gtk/generate-feature-defines-files: Added. A script which takes as an argument
the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
and writes WebKitFeatures.txt and WebKitFeatures.h.
- gtk/override-feature-defines: Removed.
- 8:04 AM Changeset in webkit [143603] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Rolling out an unindented change from r143580.
- inspector/Inspector.json:
- 8:02 AM Changeset in webkit [143602] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Unskip some tests which are passing; too bad nobody cared to file
bugs for them in the first place.
- platform/efl/TestExpectations:
- 7:44 AM Changeset in webkit [143601] by
-
- 3 edits in trunk/Source/WebCore
GlyphPage: Bake per-glyph font data array into same allocation as GlyphPage.
A hopeful fix for REGRESSION(r143125): ~5% performance hit on Chromium's intl2 page cycler
<http://webkit.org/b/108835>
Reviewed by Antti Koivisto.
Rewire GlyphPage so that we have to decide at creation time whether there will be a per-glyph
array of SimpleFontData* or not. This removes one allocation and one step of indirection for
pages with glyphs from mixed fonts.
- platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::createForMixedFontData):
(WebCore::GlyphPage::createForSingleFontData):
(WebCore::GlyphPage::createCopiedSystemFallbackPage):
(WebCore::GlyphPage::~GlyphPage):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):
(WebCore::GlyphPage::setGlyphDataForIndex):
(WebCore::GlyphPage::removeFontDataFromSystemFallbackPage):
(WebCore::GlyphPage::GlyphPage):
(WebCore::GlyphPage::hasPerGlyphFontData):
(GlyphPage):
- platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
- 7:38 AM Changeset in webkit [143600] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] MediaPlayerPrivateBlackBerry: include Logging.h
https://bugs.webkit.org/show_bug.cgi?id=110455
Patch by Xan Lopez <xlopez@rim.com> on 2013-02-21
Reviewed by Eric Carlson.
LOG is used in this file, so it is needed.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
- 7:33 AM Changeset in webkit [143599] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Invalid use of COMPILE_ASSERT macro in WebKitTextCodec.cpp
https://bugs.webkit.org/show_bug.cgi?id=110437
Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-21
Reviewed by Yong Li.
- Api/WebKitTextCodec.cpp:
(WebKit): Define COMPILE_ASSERT_MATCHING_ENUM() macro and use it to
check enum values match between WebKit and WTF.
(BlackBerry::WebKit::base64Decode): Use a static cast directly to
convert from WebKit Base64DecodePolicy to WTF.
(BlackBerry::WebKit::base64Encode): Use a static cast directly to
convert from WebKit Base64EncodePolicy to WTF.
- 6:57 AM Changeset in webkit [143598] by
-
- 2 edits in trunk/Source/WebCore
Add animation class for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110132
Reviewed by Kent Tamura.
Adding animation related classes as part of the calendar picker
redesign(Bug 109439).
No new tests. Code is not used yet.
- Resources/pagepopups/calendarPicker.js:
(AnimationTimingFunction.Linear): Parameter t should be a number between 0 and 1.
(AnimationTimingFunction.EaseInOut): Ditto.
(AnimationManager): All animators are managed by this class so we
can dispatch "animationFrameWillFinish" event after all the updates.
(AnimationManager.prototype._startAnimation):
(AnimationManager.prototype._stopAnimation):
(AnimationManager.prototype.add): Adds an animator to the list of running animators.
(AnimationManager.prototype.remove): Removes an animator.
(AnimationManager.prototype._animationFrameCallback): Callback for requestAnimationFrame.
(AnimationManager.prototype._needsAnimationFrame): Returns true if we should request the next animation frame.
(AnimationManager.prototype.on): If we add a callback, request animation frame.
(AnimationManager.prototype.removeListener):
(Animator): Animates between the from value and to value.
(Animator.prototype.setFrom): Sets the from value.
(Animator.prototype.setTo): Sets the to value.
(Animator.prototype.start):
(Animator.prototype.stop):
(Animator.prototype.onAnimationFrame): Called by AnimationManager.
- 6:49 AM WebKitGTK/Releasing edited by
- (diff)
- 6:26 AM Changeset in webkit [143597] by
-
- 4 edits in trunk
Web Inspector: [Canvas] UI: more intuitive control buttons
https://bugs.webkit.org/show_bug.cgi?id=110327
Reviewed by Pavel Feldman.
Source/WebCore:
Tweaks to the CanvasProfiler replay control buttons.
- NextDrawCall forward button (StepOver) should jump up to the last expanded node, otherwise a noop is not intuitive unless the last node is selected.
- NextDrawCall/PrevDrawCall buttons should not skip draw call nodes themselves.
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype._onReplayDrawingCallClick):
LayoutTests:
- inspector/profiler/canvas2d/canvas-replay-log-grid.html:
- 6:19 AM Changeset in webkit [143596] by
-
- 2 edits in trunk/Source/WebCore
Make SpellCheckRequest's constructor private.
https://bugs.webkit.org/show_bug.cgi?id=110462
Reviewed by Antonio Gomes.
It's no need to expose SpellCheckRequest's constructor.
There is SpellCheckRequest::create() method which is
responsible for creating SpellCheckRequest object.
No new tests, no behavior change.
- editing/SpellChecker.h:
(SpellCheckRequest):
- 6:15 AM Changeset in webkit [143595] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Canvas] Remove arrays of DataGrid nodes from the View
https://bugs.webkit.org/show_bug.cgi?id=110325
Reviewed by Pavel Feldman.
Remove arrays of DataGrid nodes from the CanvasProfileView and use live DataGrid instead.
This is a prerequisite to support a non-fixed layered tree in the grid (for example, to hide
a single frame group node, or to combine several draw call groups into a pattern group).
Drive-by: added an assert to injected canvas module.
- inspector/InjectedScriptCanvasModuleSource.js:
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
(WebInspector.CanvasProfileView.prototype._requestTraceLog):
(WebInspector.CanvasProfileView.prototype._selectedCallIndex):
(WebInspector.CanvasProfileView.prototype._peekLastRecursively):
(WebInspector.CanvasProfileView.prototype._appendCallNodes):
(WebInspector.CanvasProfileView.prototype.):
(WebInspector.CanvasProfileView.prototype.splitDrawCallGroup):
(WebInspector.CanvasProfileView.prototype._appendCallNodesToFrameNode):
- 6:13 AM Changeset in webkit [143594] by
-
- 4 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
- 6:08 AM Changeset in webkit [143593] by
-
- 29 edits2 deletes in trunk
Source/WebCore: Web Inspector: Local/session storage tree items in the Resources panel after page refresh are not shown
Re-landing r143581 with a build fix for Windows.
https://bugs.webkit.org/show_bug.cgi?id=109572
Reviewed by Vsevolod Vlasov.
This is a complete rework of the DOMStorage domain of the Web Inspector protocol. The most notable changes:
- Session and local DOM storages are considered to implicitly exist for each SecurityOrigin in the page (previously, only those that were lazily created by DOMWindow would exist).
- Consequently, the addDOMStorage event is gone.
- StorageId is now an object rather than an opaque numeric identifier.
- DOM storage modifiers no longer return a boolean indicating if the operation was successful. Clients should rely on the returned error message instead.
Implementation changes:
- InspectorDOMStorageResource would rely on the frame for which it was created throughout its lifetime. As such, the frame removal from the page would break the respective DOM storage inspection. Since this concept was entirely flawed, InspectorDOMStorageResource has been removed. Instead, a StorageArea is retrieved based on the security origin specified by the client.
- DOM storages can now be dynamically removed (upon the respective SecurityOrigin removal) in the frontend.
- CMakeLists.txt: Remove InspectorDOMStorageResource.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.order: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/WebCoreMemoryInstrumentation.cpp: Ditto.
- dom/WebCoreMemoryInstrumentation.h: Ditto.
- inspector/InjectedScriptSource.js: Account for the structured StorageId.
- inspector/Inspector.json: Update structures and API methods. Do not return boolean success flag and make use of the error message instead.
- inspector/InspectorAllInOne.cpp: Remove InspectorDOMStorageResource.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController): Add InspectorPageAgent into InspectorDOMStorageAgent.
- inspector/InspectorDOMStorageAgent.cpp: Mostly remove InspectorDOMStorageResource usages.
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::isEnabled):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems): Renamed.
(WebCore::toErrorString): Stringify ExceptionCode.
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::storageId): Make it structured rather than a plain string.
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
(WebCore::InspectorDOMStorageAgent::findStorageArea): Added.
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage): Remove InspectorDOMStorageResource map.
- inspector/InspectorDOMStorageAgent.h:
(WebCore::InspectorDOMStorageAgent::create): Update signature.
(InspectorDOMStorageAgent):
- inspector/InspectorDOMStorageResource.cpp: Removed.
- inspector/InspectorDOMStorageResource.h: Removed.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl): Do not call the removed clearResources().
- inspector/InspectorInstrumentation.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin): Added.
- inspector/InspectorPageAgent.h:
(InspectorPageAgent):
- inspector/front-end/DOMStorage.js: Entirely reworked to use the SecurityOriginAdded/Removed events.
(WebInspector.DOMStorage):
(WebInspector.DOMStorage.storageId):
(WebInspector.DOMStorage.prototype.get id):
(WebInspector.DOMStorage.prototype.get securityOrigin):
(WebInspector.DOMStorage.prototype.getItems):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel):
(WebInspector.DOMStorageModel.prototype._securityOriginAdded):
(WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
(WebInspector.DOMStorageModel.prototype._storageKey):
(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype.storageForId):
(WebInspector.DOMStorageModel.prototype.storages):
- inspector/front-end/DOMStorageItemsView.js: Rename Entries -> Items to avoid confusion.
(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageItems):
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageItems):
- inspector/front-end/ResourcesPanel.js: Follow the updated DOMStorage model.
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._initialize):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.ResourcesPanel.prototype._domStorageRemoved):
(WebInspector.ResourcesPanel.prototype._populateDOMStorageTree):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):
- page/DOMWindow.cpp: Remove instrumentation calls.
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
LayoutTests: Web Inspector: Local/session storage tree items in the Resources panel after page refresh are not shown
https://bugs.webkit.org/show_bug.cgi?id=109572
Reviewed by Vsevolod Vlasov.
- http/tests/inspector-enabled/dom-storage-open-expected.txt:
- http/tests/inspector-enabled/dom-storage-open.html:
- 6:05 AM WebKitGTK/2.0.x edited by
- (diff)
- 6:04 AM WebKitGTK/2.0.x created by
- Add page for stable WebKitGTK+ 2.0
- 5:53 AM Changeset in webkit [143592] by
-
- 1 copy in releases/WebKitGTK/webkit-2.0
Branch WebKitGTK+ for 2.0
- 5:50 AM Changeset in webkit [143591] by
-
- 7 edits in trunk/Source
Unreviewed. Fix make distcheck.
Source/WebCore:
- GNUmakefile.list.am: Add missing files to compilation.
Source/WebKit/gtk:
- GNUmakefile.am: Add -DBUILDING_WEBKIT flags to introspection
scanner.
Source/WebKit2:
- GNUmakefile.am: Add -DBUILDING_WEBKIT flags to introspection
scanner.
- GNUmakefile.list.am: Add missing header to compilation and
remove one that no longer exists.
- 5:10 AM Changeset in webkit [143590] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Element::getAttributeItem() no longer returns a mutable attribute
https://bugs.webkit.org/show_bug.cgi?id=110439
Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Antonio Gomes.
This was changed in r142827.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
- 4:40 AM Changeset in webkit [143589] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Fix access to ResourceHandle::context
https://bugs.webkit.org/show_bug.cgi?id=110443
Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Carlos Garcia Campos.
This changed in r141981.
- platform/network/blackberry/ResourceHandleBlackBerry.cpp:
(WebCore::ResourceHandle::start):
- 4:39 AM Changeset in webkit [143588] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt] Replace QWebPageAdaptor::TouchAdjuster
https://bugs.webkit.org/show_bug.cgi?id=110226
Reviewed by Antonio Gomes.
- WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::adjustPointForClicking):
- WebCoreSupport/QWebPageAdapter.h:
- 4:38 AM Changeset in webkit [143587] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] GraphicsLayerBlackBerry: rename showDebugBorder to isShowingDebugBorder
https://bugs.webkit.org/show_bug.cgi?id=110453
Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Carlos Garcia Campos.
This changed in r133517.
- platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::setupContentsLayer):
- 4:37 AM Changeset in webkit [143586] by
-
- 2 edits1 add in trunk/Source/WebCore
Web Inspector: take large strings out of CodeGeneratorInspector.py
https://bugs.webkit.org/show_bug.cgi?id=110159
Patch by Peter Rybin <prybin@chromium.org> on 2013-02-21
Reviewed by Yury Semikhatsky.
Python script is refactored.
- inspector/CodeGeneratorInspector.py:
- inspector/CodeGeneratorInspectorStrings.py: Added.
(InspectorFrontend_h):
(InspectorFrontendChannel):
(InspectorArray):
(InspectorObject):
(String):
(InspectorFrontend):
(InspectorBackendDispatcher_h):
(InspectorAgent):
(InspectorBackendDispatcherImpl):
(InspectorBackendDispatcher):
(CallbackBase):
(void):
(HashMap):
(OptOutput):
(ExactlyInt):
(RuntimeCastHelper):
(provides):
(typename):
(Array):
(Builder):
- 4:30 AM WebKit Team edited by
- add myself as committer (diff)
- 4:29 AM Changeset in webkit [143585] by
-
- 29 edits2 adds in trunk
Unreviewed, rolling out r143581.
http://trac.webkit.org/changeset/143581
https://bugs.webkit.org/show_bug.cgi?id=110457
Breaks Windows builds (compile + link) (Requested by apavlov
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
- dom/WebCoreMemoryInstrumentation.h:
(WebCoreMemoryTypes):
- inspector/InjectedScriptSource.js:
(.):
- inspector/Inspector.json:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::restore):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
(WebCore::InspectorDOMStorageAgent::clearResources):
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):
- inspector/InspectorDOMStorageAgent.h:
(WebCore):
(WebCore::InspectorDOMStorageAgent::create):
(InspectorDOMStorageAgent):
- inspector/InspectorDOMStorageResource.cpp: Added.
(WebCore):
(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
(WebCore::InspectorDOMStorageResource::isSameOriginAndType):
(WebCore::InspectorDOMStorageResource::bind):
(WebCore::InspectorDOMStorageResource::unbind):
(WebCore::InspectorDOMStorageResource::reportMemoryUsage):
- inspector/InspectorDOMStorageResource.h: Added.
(WebCore):
(InspectorDOMStorageResource):
(WebCore::InspectorDOMStorageResource::create):
(WebCore::InspectorDOMStorageResource::id):
(WebCore::InspectorDOMStorageResource::storageArea):
(WebCore::InspectorDOMStorageResource::frame):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didUseDOMStorage):
(WebCore):
- inspector/InspectorPageAgent.cpp:
- inspector/InspectorPageAgent.h:
(InspectorPageAgent):
- inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorage):
(WebInspector.DOMStorage.prototype.get id):
(WebInspector.DOMStorage.prototype.get domain):
(WebInspector.DOMStorage.prototype.getEntries):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel):
(WebInspector.DOMStorageModel.prototype._addDOMStorage):
(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype.storageForId):
(WebInspector.DOMStorageModel.prototype.storages):
(WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
- inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._initialize):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.ResourcesPanel.prototype._addDOMStorage):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
LayoutTests:
- http/tests/inspector-enabled/dom-storage-open-expected.txt:
- http/tests/inspector-enabled/dom-storage-open.html:
- 4:26 AM Changeset in webkit [143584] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] willComposite() and didComposite() are now in InspectorController
https://bugs.webkit.org/show_bug.cgi?id=110343
Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Carlos Garcia Campos.
This was changed in r142879.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::willComposite):
(BlackBerry::WebKit::WebPagePrivate::didComposite):
- 4:09 AM Changeset in webkit [143583] by
-
- 15 edits in trunk
Web Inspector: Get rid of parsedURL in uiSourceCode, use name and path for displayName instead.
https://bugs.webkit.org/show_bug.cgi?id=110335
Reviewed by Alexander Pavlov.
Source/WebCore:
Replaced UISourceCode.parsedURL with UISourceCode.displayName().
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement):
- inspector/front-end/ResourceUtils.js:
(WebInspector.displayNameForURL):
- inspector/front-end/RevisionHistoryView.js:
(WebInspector.RevisionHistoryView.prototype._createUISourceCodeItem):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.displayName):
(WebInspector.UISourceCode.prototype.urlChanged):
Source/WebKit/chromium:
- src/js/Tests.js:
(.TestSuite.prototype._scriptsAreParsed):
LayoutTests:
- http/tests/inspector-enabled/dynamic-scripts.html:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- inspector/debugger/dynamic-scripts.html:
- inspector/debugger/scripts-file-selector-expected.txt:
- inspector/debugger/source-url-comment.html:
- inspector/styles/edit-inspector-stylesheet.html:
- inspector/styles/styles-add-new-rule.html:
- 3:58 AM Changeset in webkit [143582] by
-
- 5 edits in trunk/Source/WebKit2
[WK2][EFL] Move PageViewportController and PageViewportControllerClientEfl out from WebView
https://bugs.webkit.org/show_bug.cgi?id=110345
Reviewed by Andreas Kling.
WebView does not need to know about both PageViewportController and
PageViewportControllerClientEfl. Considering the fact that PageViewportController
will stop being WK2 internal and will be based on WK2 C API, it
should be owned by EwkView rather than WebView.
This patch is also a preparation for WKViewClient API extension to cover all
the places where PageViewportController and PageViewportControllerClientEfl
are accessed directly from WebView at the moment.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
- UIProcess/API/efl/EwkView.h:
(WebKit):
(EwkView::pageViewportControllerClient):
(EwkView::pageViewportController):
(EwkView):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::didCommitLoad):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::didChangeContentsSize):
(WebKit::WebView::didChangeViewportProperties):
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):
- UIProcess/efl/WebView.h:
(WebView):
- 3:57 AM Changeset in webkit [143581] by
-
- 29 edits2 deletes in trunk
Web Inspector: Local/session storage tree items in the Resources panel after page refresh are not shown
https://bugs.webkit.org/show_bug.cgi?id=109572
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
- dom/WebCoreMemoryInstrumentation.h:
(WebCoreMemoryTypes):
- inspector/InjectedScriptSource.js:
(.):
- inspector/Inspector.json:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::isEnabled):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
(WebCore::toErrorString):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
(WebCore::InspectorDOMStorageAgent::findStorageArea):
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):
- inspector/InspectorDOMStorageAgent.h:
(WebCore):
(WebCore::InspectorDOMStorageAgent::create):
(InspectorDOMStorageAgent):
- inspector/InspectorDOMStorageResource.cpp: Removed.
- inspector/InspectorDOMStorageResource.h: Removed.
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin):
(WebCore):
- inspector/InspectorPageAgent.h:
(InspectorPageAgent):
- inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorage):
(WebInspector.DOMStorage.storageId):
(WebInspector.DOMStorage.prototype.get id):
(WebInspector.DOMStorage.prototype.get securityOrigin):
(WebInspector.DOMStorage.prototype.getItems):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel):
(WebInspector.DOMStorageModel.prototype._securityOriginAdded):
(WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
(WebInspector.DOMStorageModel.prototype._storageKey):
(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype.storageForId):
(WebInspector.DOMStorageModel.prototype.storages):
- inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageItems):
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageItems):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._initialize):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.ResourcesPanel.prototype._domStorageRemoved):
(WebInspector.ResourcesPanel.prototype._populateDOMStorageTree):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
LayoutTests:
- http/tests/inspector-enabled/dom-storage-open-expected.txt:
- http/tests/inspector-enabled/dom-storage-open.html:
- 3:39 AM Changeset in webkit [143580] by
-
- 18 edits in trunk
Web Inspector: [Console] Add console API message types for profile/profileEnd.
https://bugs.webkit.org/show_bug.cgi?id=109790
Reviewed by Pavel Feldman.
With profile/profileEnd message types we will gain more control over
output messages.
- English.lproj/localizedStrings.js: Added corresponging strings.
- inspector/ConsoleAPITypes.h: Added enum members.
- inspector/Inspector.json: Ditto.
- inspector/front-end/ConsoleModel.js: Ditto.
- inspector/ConsoleMessage.cpp:
(WebCore::messageTypeValue): Added cases.
- inspector/InspectorProfilerAgent.cpp: Adopted changes.
- inspector/front-end/inspector.js: Ditto.
- inspector/front-end/ConsoleMessage.js:
Added message generators for introduced message types.
- inspector/front-end/ProfilesPanel.js:
Turned showProfileForURL(url) to showProfile(typeId, uid).
- inspector/front-end/ProfilesPanelDescriptor.js:
(WebInspector.ProfilesPanelDescriptor.resolveProfileTitle): Added.
- inspector/front-end/ResourceUtils.js: Removed linkifier plugins.
- 2:44 AM Changeset in webkit [143579] by
-
- 5 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk2/TestExpectations: Skip failing reftests.
- platform/qt/TestExpectations: Skip failing tests after r143541 and r110447.
- platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Rebaselining after r143505.
- platform/qt/fast/js/global-constructors-expected.txt: Rebaselining after r143505.
- 2:43 AM Changeset in webkit [143578] by
-
- 4 edits1 add in trunk/Source/WebCore
OpenCL implementation of FEMerge filter.
https://bugs.webkit.org/show_bug.cgi?id=110193
Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-02-21
Reviewed by Zoltan Herczeg.
In case of odd number of parameters the first parameter is copied to the destination image and
the rest of the parameters are merged in pairs.
- Target.pri:
- platform/graphics/filters/FEMerge.h:
(FEMerge):
- platform/graphics/gpu/opencl/FilterContextOpenCL.h:
(WebCore::FilterContextOpenCL::FilterContextOpenCL):
(FilterContextOpenCL):
- platform/graphics/gpu/opencl/OpenCLFEMerge.cpp: Added.
(WebCore):
(WebCore::FilterContextOpenCL::compileFEMerge):
(WebCore::FilterContextOpenCL::copy): This is a simple copy method.
(WebCore::FilterContextOpenCL::applyFEMerge):
(WebCore::FEMerge::platformApplyOpenCL):
- 2:26 AM Changeset in webkit [143577] by
-
- 4 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- 2:16 AM Changeset in webkit [143576] by
-
- 2 edits in trunk/Source/WebCore
Add event dispatch class for the new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110131
Reviewed by Kent Tamura.
Adding event dispatcher class as part of the new calendar picker patch at Bug 109439.
No new tests. Code is not yet used.
- Resources/pagepopups/calendarPicker.js:
(EventEmitter):
(EventEmitter.prototype.on): Adds a callback for an event.
(EventEmitter.prototype.hasListener): Returns true if more than one listeners exist for an event type.
(EventEmitter.prototype.removeListener): Removes an event listener.
(EventEmitter.prototype.dispatchEvent): Dispatches an event to all callbacks. Takes variable number of arguments.
- 2:09 AM Changeset in webkit [143575] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipped failing inpector tests after r143300.
https://bugs.webkit.org/show_bug.cgi?id=110440.
- platform/qt/TestExpectations:
- 1:18 AM Changeset in webkit [143574] by
-
- 10 edits5 adds in trunk
Web Inspector: Add command for selecting files for file input element
https://bugs.webkit.org/show_bug.cgi?id=109308
Patch by Ken Kania <kkania@chromium.org> on 2013-02-21
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector-protocol/dom/setFileInputFiles.html
- inspector/Inspector.json:
- inspector/InspectorClient.h:
(WebCore::InspectorClient::canSetFileInputFiles):
(InspectorClient):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::setFileInputFiles):
(WebCore):
- inspector/InspectorDOMAgent.h:
(WebCore):
(WebCore::InspectorDOMAgent::create):
(InspectorDOMAgent):
Source/WebKit/chromium:
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canSetFileInputFiles):
(WebKit):
- src/InspectorClientImpl.h:
(InspectorClientImpl):
LayoutTests:
- inspector-protocol/dom/setFileInputFiles-expected.txt: Added.
- inspector-protocol/dom/setFileInputFiles.html: Added.
- platform/chromium/inspector-protocol/dom/setFileInputFiles-expected.txt: Added.
- 1:04 AM Changeset in webkit [143573] by
-
- 37 edits1 move2 adds in trunk
Source/WebCore: [Web Inspector]Add WebSocket networking events in Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=105527.
Patch by Pan Deng <pan.deng@intel.com> on 2013-02-21
Reviewed by Pavel Feldman.
This patch add four WebSocket networking events in Timeline panel. The Events
are CreateWebSocket, SendWebSocketHandshakeRequest, ReceiveWebSocketHandShakeResponse
and DestoryWebSocket. Thanks to Kitamura san's previous work.
Test: http/tests/inspector/websocket/timeline-websocket-event.html
- English.lproj/localizedStrings.js:
- Modules/websockets/WebSocketChannel.cpp: Add protocol information
(WebCore::WebSocketChannel::connect):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCreateWebSocketImpl): Add Timeline agent instrumentation for websocket
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl): Ditto
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl): Ditto
(WebCore::InspectorInstrumentation::didCloseWebSocketImpl): Ditto
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateWebSocket):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorInstrumentation::didCloseWebSocket):
- inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
(WebCore):
(WebCore::InspectorTimelineAgent::didCreateWebSocket): Add Timeline record for websocket create
(WebCore::InspectorTimelineAgent::addWebSocketRecord): Add general websocket record
(WebCore::InspectorTimelineAgent::willSendWebSocketHandshakeRequest): Add Timeline record for websocket handshake request send
(WebCore::InspectorTimelineAgent::didReceiveWebSocketHandshakeResponse): Add Timeline record for websocket handshake response receive
(WebCore::InspectorTimelineAgent::didDestroyWebSocket): Add Timeline record for websocket destroy
- inspector/InspectorTimelineAgent.h:
(WebCore):
(InspectorTimelineAgent):
- inspector/TimelineRecordFactory.h:
(TimelineRecordFactory):
(WebCore::TimelineRecordFactory::createWebSocketCreateData):
(WebCore::TimelineRecordFactory::createGenericWebSocketData):
- inspector/front-end/TimelineModel.js: Add Timeline record type for websocket
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel._initRecordStyles):
(WebInspector.TimelinePresentationModel.prototype.reset): Add slot to store WebSocket Create record
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview): Add PopupContent for websocket record, including url and protocol
LayoutTests: [Web Inspector]Add WebSocket networking events in WebInspector Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=105527.
Patch by Pan Deng <pan.deng@intel.com> on 2013-02-21
Reviewed by Pavel Feldman.
This change add the record event type to test expections. The Events are CreateWebSocket,
SendWebSocketHandshakeRequest, ReceiveWebSocketHandShakeResponse and DestoryWebSocket.
timeline-test.js was moved to http folder, since new added websocket test need it from server side.
- http/tests/inspector/timeline-test.js: Renamed from LayoutTests/inspector/timeline/timeline-test.js.
(initialize_Timeline.InspectorTest.startTimeline.addRecord):
(initialize_Timeline.InspectorTest.startTimeline):
(initialize_Timeline.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):
(initialize_Timeline.InspectorTest.stopTimeline):
(initialize_Timeline.step1):
(initialize_Timeline.step2):
(initialize_Timeline.InspectorTest.evaluateWithTimeline):
(initialize_Timeline.):
(initialize_Timeline.InspectorTest.performActionsAndPrint):
(initialize_Timeline.InspectorTest.printTimelineRecords):
(initialize_Timeline.InspectorTest.printTimestampRecords):
(initialize_Timeline.InspectorTest.innerPrintTimelineRecords):
(initialize_Timeline.InspectorTest.dumpTimelineRecord):
(initialize_Timeline.InspectorTest.dumpTimelineRecords):
(initialize_Timeline.InspectorTest.printTimelineRecordProperties):
(initialize_Timeline.InspectorTest._timelineAgentTypeToString):
(initialize_Timeline.InspectorTest.findPresentationRecord.findByType):
(initialize_Timeline.InspectorTest.findPresentationRecord):
(initialize_Timeline.InspectorTest.FakeFileReader):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.start):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.cancel):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.loadedSize):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.fileSize):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.fileName):
(initialize_Timeline.InspectorTest):
(initialize_Timeline):
- http/tests/inspector/websocket/timeline-websocket-event-expected.txt: Added.
- http/tests/inspector/websocket/timeline-websocket-event.html: Added.
- inspector/timeline/timeline-animation-frame.html: Modify address of script "timeline-test.js"
- inspector/timeline/timeline-decode-resize.html:
- inspector/timeline/timeline-dom-content-loaded-event.html:
- inspector/timeline/timeline-enum-stability-expected.txt:
- inspector/timeline/timeline-event-dispatch.html:
- inspector/timeline/timeline-frames.html:
- inspector/timeline/timeline-injected-script-eval.html:
- inspector/timeline/timeline-layout-reason.html:
- inspector/timeline/timeline-layout.html:
- inspector/timeline/timeline-load-event.html:
- inspector/timeline/timeline-load.html:
- inspector/timeline/timeline-mark-timeline.html:
- inspector/timeline/timeline-network-received-data.html:
- inspector/timeline/timeline-network-resource.html:
- inspector/timeline/timeline-paint.html:
- inspector/timeline/timeline-parse-html.html:
- inspector/timeline/timeline-recalculate-styles.html:
- inspector/timeline/timeline-receive-response-event.html:
- inspector/timeline/timeline-script-tag-1.html:
- inspector/timeline/timeline-script-tag-2.html:
- inspector/timeline/timeline-start-time.html:
- inspector/timeline/timeline-time-stamp.html:
- inspector/timeline/timeline-time.html:
- inspector/timeline/timeline-timer-fired-from-eval-call-site.html:
- inspector/timeline/timeline-timer.html:
- inspector/timeline/timeline-trivial.html:
- 1:03 AM Changeset in webkit [143572] by
-
- 2 edits in trunk/Tools
[Qt] Remove obsolete DEPENDPATH assignment
Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com> on 2013-02-21
Reviewed by Simon Hausmann
qmake now adds CONFIG+=depend_includepath by default, making manual
DEPENDPATH setup unnecessary.
- qmake/mkspecs/features/default_post.prf:
- 1:01 AM Changeset in webkit [143571] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix pkg-config dependencies of QtWebKit itself
Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com> on 2013-02-21
Reviewed by Simon Hausmann.
Don't override QMAKE_PKGCONFIG_REQUIRES needlessly.
- WebCore.pri:
- 1:00 AM Changeset in webkit [143570] by
-
- 3 edits2 adds in trunk
File upload control doesn't apply CSS vertical padding or border to file name
https://bugs.webkit.org/show_bug.cgi?id=109011
Patch by Nils Barth <nbarth@google.com> on 2013-02-21
Reviewed by Hajime Morrita.
Source/WebCore:
Test: fast/forms/file/file-vertical-padding-border.html
- rendering/RenderFileUploadControl.cpp:
Add borderTop() and paddingTop() when computing position.
(WebCore::RenderFileUploadControl::paintObject):
LayoutTests:
- fast/forms/file/file-vertical-padding-border.html: Added.
- fast/forms/file/file-vertical-padding-border-expected.html: Added.
- 12:27 AM Changeset in webkit [143569] by
-
- 9 edits in trunk/Source/WebCore
Stop hardcoding knowledge about blob protocol in ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=110382
Reviewed by Anders Carlsson.
- platform/network/BlobRegistry.h:
- platform/network/chromium/BlobRegistryProxy.h: Removed loadResourceSynchronously(). Chromium did not even implement it, and cross-platform code doesn't need it any more either.
- platform/network/BlobRegistryImpl.cpp: (WebCore::loadResourceSynchronously): A function to load a blob synchronously, suitable for being in a ResourceHandle map. (WebCore::registerBlobResourceHandleConstructor): Register loadResourceSynchronously too. (WebCore::BlobRegistryImpl::createResourceHandle): Don't make policy decisions here, it's just a registry. Moved code for checking request method down to BlobResourceHandle.
- platform/network/BlobRegistryImpl.h: Removed BlobRegistryImpl::loadResourceSynchronously(). A registry shouldn't load resources, and it already has enough accessors to implement this externally.
- platform/network/BlobResourceHandle.h:
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::createAsync): Renamed from create(), to make it clear that it's not OK to call from synchronous loader. Moved method check here. (WebCore::BlobResourceHandle::loadResourceSynchronously): Moved method check here. We used to fall through to NSURLConnection based loader when method was not GET, which of course resulted in an error eventually, but was just wrong.
- platform/network/ResourceHandle.cpp: (WebCore::builtinResourceHandleSynchronousLoaderMap): Added a map for synchronous case. (WebCore::ResourceHandle::registerBuiltinSynchronousLoader): Ditto. (WebCore::ResourceHandle::loadResourceSynchronously): We no longer need to hardcode knowledge about blobRegistry and blobs here.
- platform/network/ResourceHandle.h: Added registerBuiltinSynchronousLoader().
- platform/network/chromium/ResourceHandle.h: Removed loadResourceSynchronously(), which was not implemented for Chromium.
Feb 20, 2013:
- 11:54 PM CoordinatedGraphicsSystem edited by
- New dorothybrowser site! (diff)
- 11:53 PM Changeset in webkit [143568] by
-
- 7 edits in trunk
Web Inspector: TabbedEditorContainer and OpenResourceDialog should show uiSourceCode path and name instead of parsedURL
https://bugs.webkit.org/show_bug.cgi?id=110334
Reviewed by Alexander Pavlov.
Source/WebCore:
Introduced uiSourceCode.name() that returns a name based on uiSourceCode path.
OpenResourceDialog now shows uiSourceCode workspace path as a subtitle.
TabbedEditorContainer now shows uiSourceCode name in the tab header.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemSubtitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype._updateScriptTitle):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._titleForFile):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.name):
LayoutTests:
- inspector/debugger/scripts-file-selector-expected.txt:
- inspector/debugger/ui-source-code-display-name-expected.txt:
- inspector/debugger/ui-source-code-display-name.html:
- 11:33 PM Changeset in webkit [143567] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: debugger buttons are scrolled along with the sidebar content.
https://bugs.webkit.org/show_bug.cgi?id=110434
Reviewed by Vsevolod Vlasov.
- inspector/front-end/scriptsPanel.css:
(div.sidebar-pane-stack#scripts-debug-sidebar-contents, #scripts-sidebar-stack-pane):
- 11:21 PM Changeset in webkit [143566] by
-
- 2 edits in branches/chromium/1410/Source/WebCore/inspector/front-end
Merge 143437
Web Inspector: View.markAsRoot should never be invoked on attached view.
https://bugs.webkit.org/show_bug.cgi?id=110224
Reviewed by Pavel Feldman.
This will cause CSS loading problems after "show".
- inspector/front-end/Drawer.js:
Ensure child view is detached before marked as root.
- inspector/front-end/View.js:
(WebInspector.View.prototype.markAsRoot): Added assertion.
TBR=eustas@chromium.org
BUG=176912
Review URL: https://codereview.chromium.org/12320033
- 10:34 PM Changeset in webkit [143565] by
-
- 3 edits in trunk/Source/WebCore
ChannelMergerNode may need check for deferred updating of output channels
https://bugs.webkit.org/show_bug.cgi?id=108863
There can in rare cases be a slight delay before the output bus is updated
to the new number of channels because of tryLocks() in the context's
updating system. So need to check the channel number before processing.
Reviewed by Chris Rogers.
- Modules/webaudio/ChannelMergerNode.cpp:
(WebCore::ChannelMergerNode::ChannelMergerNode):
(WebCore::ChannelMergerNode::process):
(WebCore::ChannelMergerNode::checkNumberOfChannelsForInput):
- Modules/webaudio/ChannelMergerNode.h:
(ChannelMergerNode):
- 10:26 PM Changeset in webkit [143564] by
-
- 3 edits in trunk/Source/WebCore
[Web Inspector] Fix Sort by Initiator functionality of Network Panel.
https://bugs.webkit.org/show_bug.cgi?id=109135.
Patch by Pan Deng <pan.deng@intel.com> on 2013-02-20
Reviewed by Pavel Feldman.
A refactor for request initiator types, and the sort by Initiator functionality
was changed to sort by url and line number that displayed in initiator cell.
No new tests.
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell): save initiator displayedURL and displayedLineNumber
(WebInspector.NetworkDataGridNode.InitiatorComparator):
- inspector/front-end/NetworkRequest.js:
- 9:36 PM Changeset in webkit [143563] by
-
- 2 edits in trunk/Source/WebCore
WebVTTParser copies character buffer more often than necessary
https://bugs.webkit.org/show_bug.cgi?id=103319
Reviewed by Eric Carlson.
Previously this codepath was creating a String just to parse the timestamp
and then if the timestamp was valid, was creating a second string.
I've fixed it to only create one string and use it in both places.
I also fixed this codepath to use 8bit strings when possible, per the FIXME.
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken):
- 8:58 PM Changeset in webkit [143562] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG::SpeculativeJIT::compileInt32ToDouble() has an unnecessary case for constant operands
https://bugs.webkit.org/show_bug.cgi?id=110309
Reviewed by Sam Weinig.
It used to be necessary, back when we didn't have constant folding. Now we have
constant folding. So we don't need it.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
- 8:38 PM Changeset in webkit [143561] by
-
- 2 edits in trunk/Tools
Unreviewed. Changing primary email id.
- 8:21 PM Changeset in webkit [143560] by
-
- 3 edits4 adds in trunk
Mouseup event does not fire on Scroll Bar
https://bugs.webkit.org/show_bug.cgi?id=25811
Reviewed by Tony Chang.
Source/WebCore:
Currently, clicking on a scrollbar fires a mousedown event, but not a
mouseup event. This causes problems for code like jQuery UI's
draggable[1], as the drag starts, but is never cancelled. Other use
cases are noted in the slightly old Chromium bug[2].
If a mouseup event is received after a mousedown event on a scrollbar,
this patch dispatches a mouseup event on the same node the mousedown
event dispatched on. This matches Gecko's behavior.
[1]: http://bugs.jqueryui.com/ticket/6925
[2]: http://crbug.com/14204
Tests: fast/scrolling/scrollbar-mousedown-mouseup.html
fast/scrolling/scrollbar-mousedown-move-mouseup.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
If a mouseup event follow a mousedown event on a scrollbar,
dispatch an event on the same node from which the mousedown event
was triggered.
LayoutTests:
- fast/scrolling/scrollbar-mousedown-mouseup-expected.txt: Added.
- fast/scrolling/scrollbar-mousedown-mouseup.html: Added.
- fast/scrolling/scrollbar-mousedown-move-mouseup-expected.txt: Added.
- fast/scrolling/scrollbar-mousedown-move-mouseup.html: Added.
- 7:58 PM Changeset in webkit [143559] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, update TestExpectations.
- platform/chromium/TestExpectations:
- 7:51 PM Changeset in webkit [143558] by
-
- 3 edits in trunk/Source/WebKit2
Provide WKView SPI to defer telling the WebPageProxy and WebProcess about changes in the hosting window
https://bugs.webkit.org/show_bug.cgi?id=110415
<rdar://problem/13095405>
Reviewed by Simon Fraser.
- UIProcess/API/mac/WKView.mm: Add _viewInWindowChangesDeferredCount and _viewInWindowChangeWasDeferred to WKViewData.
(-[WKView viewDidMoveToWindow]): If we're deferring window changes, don't include the ViewIsInWindow flag
when sending viewStateDidChange. Instead, save the fact that we want to do that later aside.
(-[WKView beginDeferringViewInWindowChanges]):
(-[WKView endDeferringViewInWindowChanges]): Straightforward begin/end pair. When we exit the last pair and
have a pending window change, let the WebPageProxy know. WebPageProxy will do the check to ensure that
the in-window state has actually changed.
(-[WKView isDeferringViewInWindowChanges]):
- UIProcess/API/mac/WKViewPrivate.h:
- 7:50 PM Changeset in webkit [143557] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed gardening, add chromium-mac specific expectation image.
- platform/chromium-mac/fast/repaint/paint-caret-in-div-with-negative-indent-expected.png: Added.
- 7:39 PM Changeset in webkit [143556] by
-
- 13 edits in trunk/Source/WebCore
[Refactoring] Make m_state an on-stack object
https://bugs.webkit.org/show_bug.cgi?id=109909
Reviewed by Antti Koivisto.
Mode m_state, an instance of StyleResolver::State, an on-stack object.
The state is only required in styleForElement, styleForKeyframe and
so on. No need to keep the state outside of those methods.
No new tests, because just refactoring.
- css/BasicShapeFunctions.cpp:
(WebCore::convertToLength):
(WebCore::basicShapeForValue):
- css/BasicShapeFunctions.h:
(WebCore):
Replaced StyleResolver* with StyleResolver::State&.
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::gradientWithStylesResolved):
- css/CSSGradientValue.h:
(CSSGradientValue):
Replaced StyleResolver* with StyleResolver::State&.
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::style):
(WebCore::CSSToStyleMap::rootElementStyle):
(WebCore::CSSToStyleMap::useSVGZoomRules):
(WebCore::CSSToStyleMap::styleImage):
- css/CSSToStyleMap.h:
(WebCore):
(WebCore::CSSToStyleMap::CSSToStyleMap):
(CSSToStyleMap):
Replaced StyleResolver* with StyleResolver::State&.
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
Replaced m_state with state which is given as an argument of
applySVGProperty.
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyExclusionShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
- css/StyleBuilder.h:
(WebCore):
(PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
Replaced StyleResolver* with StyleResolver::State&.
- css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::StyleResolver):
Removed m_styleMap. Now m_styleMap is an on-stack object.
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::initElement):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::findSiblingForStyleSharing):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyWithNullCheck):
(WebCore::StyleResolver::applyFontPropertyToStyle):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::checkForZoomChange):
(WebCore::StyleResolver::checkForGenericFamilyChange):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::styleShader):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createCustomFilterOperation):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):
(WebCore::StyleResolver::loadPendingResources):
Just replaced m_state with state and added one more parameter to
provide the state.
(WebCore::StyleResolver::reportMemoryUsage):
Since m_state was removed, removed a code for reporting m_state's
memory usage.
- css/StyleResolver.h:
(StyleResolver):
(WebCore::StyleResolver::isRightPage):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::State::document):
Since State::m_element is not always available (sometimes, 0),
added m_document to State and modified to return the m_document.
(WebCore::StyleResolver::State::useSVGZoomRules):
Moved StyleResolver to State.
(State):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
Moved the code, updating a style by using a given StylePropertySet,
to StyleResolver.
- 7:26 PM Changeset in webkit [143555] by
-
- 2 edits in trunk/Source/WebCore
AutoTableLayout applies min-width redundantly with RenderTable
https://bugs.webkit.org/show_bug.cgi?id=110426
Reviewed by Emil A Eklund.
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
This code used to do something, but has since been superceded by
code in RenderTable::computePreferredLogicalWidths.
- 7:22 PM Changeset in webkit [143554] by
-
- 4 edits in trunk
Enable CANVAS_PATH flag
https://bugs.webkit.org/show_bug.cgi?id=108508
Source/WebCore:
Uneviewed attempt to fix Qt minimal build.
- html/canvas/DOMPath.h:
(WebCore::DOMPath::DOMPath):
LayoutTests:
Reviewed by Simon Fraser.
Unreviewed rebaseline after landing patch.
- fast/dom/constructed-objects-prototypes-expected.txt:
- 6:43 PM Changeset in webkit [143553] by
-
- 3 edits2 adds in trunk
DFG inlines Resolves that it doesn't know how to handle correctly
https://bugs.webkit.org/show_bug.cgi?id=110405
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
Don't try to be clever: if there's a failing resolve, we can't inline it, period.
- dfg/DFGCapabilities.h:
(JSC::DFG::canInlineResolveOperations):
(JSC::DFG::canInlineOpcode):
LayoutTests:
Reviewed by Geoffrey Garen.
- fast/js/dfg-inline-resolve-expected.txt: Added.
- fast/js/dfg-inline-resolve.html: Added.
- 6:41 PM Changeset in webkit [143552] by
-
- 2 edits in trunk/Source/WebKit2
Disable window occlusion notifications for App Store on Mac.
https://bugs.webkit.org/show_bug.cgi?id=110417
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-02-20
Reviewed by Simon Fraser.
Temporary fix to workaround issues with window occlusion notifications
in App Store.
- UIProcess/API/mac/WKView.mm:
(+[WKView _registerWindowOcclusionNotificationHandlers]): Return early
if the main bundle identifier matches that of App Store.
- 6:36 PM Changeset in webkit [143551] by
-
- 24 edits2 moves in trunk/Source/WebCore
\2013-02-20 Mark Lam <mark.lam@apple.com>
Rename DatabaseBackendAsync to DatabaseBackend.
https://bugs.webkit.org/show_bug.cgi?id=110422.
Reviewed by Geoffrey Garen.
This is a purely cosmetic change to make the naming consistent with
the front-end Database.
No new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/webdatabase/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):
- Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::from):
(WebCore::Database::backend):
- Modules/webdatabase/Database.h:
- Modules/webdatabase/DatabaseBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackendAsync.cpp.
(WebCore::DatabaseBackend::DatabaseBackend):
(WebCore::DatabaseBackend::openAndVerifyVersion):
(WebCore::DatabaseBackend::performOpenAndVerify):
(WebCore::DatabaseBackend::close):
(WebCore::DatabaseBackend::runTransaction):
(WebCore::DatabaseBackend::inProgressTransactionCompleted):
(WebCore::DatabaseBackend::scheduleTransaction):
(WebCore::DatabaseBackend::scheduleTransactionStep):
(WebCore::DatabaseBackend::transactionClient):
(WebCore::DatabaseBackend::transactionCoordinator):
- Modules/webdatabase/DatabaseBackend.h: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackendAsync.h.
- Modules/webdatabase/DatabaseBackendAsync.cpp: Removed.
- Modules/webdatabase/DatabaseBackendAsync.h: Removed.
- Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::DatabaseBackendBase::~DatabaseBackendBase):
- Modules/webdatabase/DatabaseManager.cpp:
- Modules/webdatabase/DatabaseServer.cpp:
- Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseTask::DatabaseTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::debugTaskName):
(WebCore::DatabaseBackend::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::debugTaskName):
(WebCore::DatabaseBackend::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::DatabaseBackend::DatabaseTransactionTask::~DatabaseTransactionTask):
(WebCore::DatabaseBackend::DatabaseTransactionTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseTransactionTask::debugTaskName):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::debugTaskName):
- Modules/webdatabase/DatabaseTask.h:
(WebCore::DatabaseTask::database):
(DatabaseTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::create):
(DatabaseBackend::DatabaseOpenTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::create):
(DatabaseBackend::DatabaseCloseTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::create):
(DatabaseBackend::DatabaseTableNamesTask):
- Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::recordDatabaseOpen):
(WebCore::DatabaseThread::recordDatabaseClosed):
(WebCore::SameDatabasePredicate::SameDatabasePredicate):
(SameDatabasePredicate):
(WebCore::DatabaseThread::unscheduleDatabaseTasks):
- Modules/webdatabase/DatabaseThread.h:
- Modules/webdatabase/SQLStatementBackend.cpp:
(WebCore::SQLStatementBackend::execute):
(WebCore::SQLStatementBackend::setDatabaseDeletedError):
(WebCore::SQLStatementBackend::setVersionMismatchedError):
(WebCore::SQLStatementBackend::setFailureDueToQuota):
- Modules/webdatabase/SQLStatementBackend.h:
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
- Modules/webdatabase/SQLTransactionBackend.h:
(WebCore::SQLTransactionBackend::database):
- Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::getDatabaseIdentifier):
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- 6:25 PM Changeset in webkit [143550] by
-
- 3 edits1 add in trunk/Source/WebCore
Upstream SharedTimerIOS.mm
<http://webkit.org/b/110161>
Reviewed by Benjamin Poulain.
- Configurations/WebCore.xcconfig:
(EXCLUDED_SOURCE_FILE_NAMES_iphoneos): Add SharedTimerMac.mm.
- WebCore.xcodeproj/project.pbxproj: Add SharedTimerIOS.mm.
- platform/ios/SharedTimerIOS.mm: Add.
(WebCore):
(-[WebCoreResumeNotifierIOS init]):
(-[WebCoreResumeNotifierIOS dealloc]):
(-[WebCoreResumeNotifierIOS didWake]):
(WebCore::setSharedTimerFiredFunction):
(WebCore::timerFired):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):
- 6:24 PM Changeset in webkit [143549] by
-
- 2 edits in trunk/Source/WebCore
Speculative fix for EFL and Windows compilers not realizing
that all possible cases have a return value from this switch.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
- 6:20 PM Changeset in webkit [143548] by
-
- 4 edits1 add16 deletes in trunk/LayoutTests
Convert residual-style.html test to a reftest (and fix typos)
https://bugs.webkit.org/show_bug.cgi?id=109981
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-20
Reviewed by Darin Adler.
- fast/flexbox/box-orient-button.html: clsas->class
- fast/flexbox/resources/box-orient-button.js: DTR->DRT
- fast/invalid/residual-style-expected.html: Added. New reftest
version. Note that some lines are red, which is
https://bugs.webkit.org/show_bug.cgi?id=109984
- fast/invalid/residual-style.html: Add missing semicolon in <style>.
Also close a few more <font> tags, so that the descriptive text is
in black as it should be.
- platform/chromium-android/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-android/fast/invalid/residual-style-expected.txt: Removed.
- platform/chromium-linux/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-linux/fast/invalid/residual-style-expected.txt: Removed.
- platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-mac/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
- platform/chromium-win/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-win/fast/invalid/residual-style-expected.txt: Removed.
- platform/efl/fast/invalid/residual-style-expected.png: Removed.
- platform/efl/fast/invalid/residual-style-expected.txt: Removed.
- platform/gtk/fast/invalid/residual-style-expected.png: Removed.
- platform/gtk/fast/invalid/residual-style-expected.txt: Removed.
- platform/mac/fast/invalid/residual-style-expected.png: Removed.
- platform/mac/fast/invalid/residual-style-expected.txt: Removed.
Removed old expectation files.
- 6:09 PM Changeset in webkit [143547] by
-
- 5 edits in trunk
[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
https://bugs.webkit.org/show_bug.cgi?id=109634
Reviewed by Adrienne Walker.
Source/Platform:
- chromium/public/WebUnitTestSupport.h:
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createOutputSurface):
(WebViewHost::initializeLayerTreeView):
- 6:02 PM Changeset in webkit [143546] by
-
- 9 edits in trunk
[New Multicolumn] Fix overflow computation for column blocks.
https://bugs.webkit.org/show_bug.cgi?id=110392.
Reviewed by Simon Fraser.
Source/WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::addOverflowFromChild):
Exclude in-flow RenderFlowThreads from overflow propagation.
- rendering/RenderMultiColumnSet.h:
- rendering/RenderRegion.h:
(WebCore::RenderRegion::shouldHaveAutoLogicalHeight):
- rendering/RenderRegionSet.h:
(RenderRegionSet):
Override shouldHaveAutoLogicalHeight to always be false
for region sets and for columns. Eventually we're going to try
to leverage this code to do column balancing, and that's why
RenderMultiColumnSet has a unique override.
LayoutTests:
- fast/multicol/newmulticol/column-rules-fixed-height-expected.html:
- fast/multicol/newmulticol/column-rules-fixed-height.html:
- 5:35 PM Changeset in webkit [143545] by
-
- 2 edits in trunk/Source/WebCore
Printing WebGL canvases in Chrome uses stale data after first print
https://bugs.webkit.org/show_bug.cgi?id=110003
Patch by Brandon Jones <bajones@google.com> on 2013-02-20
Reviewed by Kenneth Russell.
Unable to validate printed content automatically. No regression in existing WebGL tests.
- html/canvas/WebGLRenderingContext.cpp: (WebCore): (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
- 5:29 PM Changeset in webkit [143544] by
-
- 7 edits1 move1 delete in trunk/Source/WebKit2
<https://webkit.org/b/110410> Specify the plug-in process / service entitlements via the Xcode configuration.
This is the modern mechanism for applying entitlements to production builds,
and it simplifies the maintenance of entitlements going forward. It also allows
us to fix the new XPC PluginServices to have the same entitlements as PluginProcess.
Reviewed by Alexey Proskuryakov.
- Configurations/Base.xcconfig: Ad-hoc sign all WebKit2 components.
- Configurations/PluginProcess.xcconfig: Specify the entitlements to use.
- Configurations/PluginService.32.xcconfig: Ditto.
- Configurations/PluginService.64.xcconfig: Ditto.
- Configurations/PluginService.Development.xcconfig: Ditto.
- Configurations/PluginService.entitlements: Renamed from Source/WebKit2/PluginProcess/mac/PluginProcess.entitlements.
Move the entitlements in to the Configurations directory to make them easier to find.
- PluginProcess/mac/add-entitlements.sh: Removed. In my testing the dependency issue mentioned
in the script is not an issue with current versions of Xcode. If we see it again we can come
up with a workaround that doesn't involve performing the signing via a script phase.
- WebKit2.xcodeproj/project.pbxproj:
- 5:29 PM Changeset in webkit [143543] by
-
- 3 edits1 move1 delete in trunk/Source/WebKit2
<https://webkit.org/b/110409> Remove duplication between 32- and 64-bit PluginService plists.
Reviewed by Dan Bernstein.
The only difference between the plists was the CFBundleIdentifier. Since the values are the
same as the product name, we can just use the value of the PRODUCT_NAME configuration setting.
- Configurations/PluginService.32.xcconfig:
- Configurations/PluginService.64.xcconfig:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist: Renamed from Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist: Removed.
- 5:22 PM Changeset in webkit [143542] by
-
- 3 edits4 adds in trunk
Incorrect rendering for flex boxes with percentage height in a table cell
https://bugs.webkit.org/show_bug.cgi?id=110389
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-20
Reviewed by Tony Chang.
Source/WebCore:
Tests: css3/flexbox/flex-percentage-height-in-table-standards-mode.html
css3/flexbox/flex-percentage-height-in-table.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
Always update the logical height of the flex box, not just when it is
auto. If necessary, the later updateLogicalHeight() call will adjust
it.
LayoutTests:
- css3/flexbox/flex-percentage-height-in-table-expected.html: Added.
- css3/flexbox/flex-percentage-height-in-table-standards-mode-expected.html: Added.
- css3/flexbox/flex-percentage-height-in-table-standards-mode.html: Added.
- css3/flexbox/flex-percentage-height-in-table.html: Added.
- 5:19 PM Changeset in webkit [143541] by
-
- 9 edits2 adds in trunk
Account for transform in SVG background images
https://bugs.webkit.org/show_bug.cgi?id=110295
Reviewed by Dirk Schulze.
Source/WebCore:
Tiled SVG background images are rendererd by drawing the SVG content into a temporary
image buffer, then stamping out a tiled pattern using this buffer. Previously the
image buffer did not account for CSS transforms which could result in pixelated backgrounds.
This patch takes advantage of the context's transform when sizing the temporary tiling
image buffer. Because the context's transform also includes scale, this patch simplifies
the SVG image code to no longer track scale.
Test: svg/as-background-image/svg-transformed-background.html
- loader/cache/CachedImage.cpp:
(WebCore):
(WebCore::CachedImage::imageForRenderer):
CachedImage::lookupOrCreateImageForRenderer no longer creates images so it has been
refactored into just "imageForRenderer". Previously there were two versions of
lookupOrCreateImageForRenderer; these have been folded into imageForRenderer.
- loader/cache/CachedImage.h:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
To create the temporary tiling image buffer, the final size in screen coordinates is
needed. This is now computed using the current context's CTM. Because the CTM
already includes the page scale, all page scale tracking can be removed.
The adjustments to srcRect and the pattern transform are the same as before, just
refactored to use imageBufferScale which has x and y components.
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::setContainerSizeForRenderer):
Because the page scale needed to be cached between calls to
setContainerSizeForRenderer, this function was written to modify an existing cache
entry. Because the page scale no longer needs to be tracked, this code has been
simplified to re-write any existing cache entry.
(WebCore::SVGImageCache::imageSizeForRenderer):
This function has been simplified by calling SVGImageForContainer::size() instead
of computing this value manually. The value returned remains the same, containing
the container size multiplied by zoom.
(WebCore::SVGImageCache::imageForRenderer):
Previously we set the page scale on every call to imageForRenderer. Because page scale
no longer needs to be tracked, this function has been simplified to simply return
the cached SVGImageForContainer.
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern):
- svg/graphics/SVGImageForContainer.h:
(WebCore::SVGImageForContainer::create):
(WebCore::SVGImageForContainer::SVGImageForContainer):
(SVGImageForContainer):
LayoutTests:
- svg/as-background-image/svg-transformed-background-expected.html: Added.
- svg/as-background-image/svg-transformed-background.html: Added.
- 5:09 PM Changeset in webkit [143540] by
-
- 2 edits in trunk/Source/WebCore
Crash in com.apple.WebKit2.WebProcessService at com.apple.avfoundation: 73-[AVAssetResourceLoader _attemptDelegateHandlingOfRequestWithDictionary:]_block_invoke + 51
https://bugs.webkit.org/show_bug.cgi?id=110385
Reviewed by Eric Carlson.
Ensure AVFoundation does not attempt to message a dead object by explicitly disassociating
the AVAssetResourceLoaderDelegate on MediaPlayerPrivateAVFoundationObjC destruction.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC):
- 5:07 PM Changeset in webkit [143539] by
-
- 4 edits2 adds in trunk
Positioned, replaced elements with intrinsic width keywords compute the wrong width
https://bugs.webkit.org/show_bug.cgi?id=110393
Reviewed by Emil A Eklund.
Source/WebCore:
Test: fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
Add the intrinsic size keywords to the switch. Confusingly, we have to
subtract the border and padding since the callers expect the content width.
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
Don't do the intrinsic ratio calculation if the width is an
intrinsic width keyword, as per, http://dev.w3.org/csswg/css3-sizing/#replaced-intrinsic.
(WebCore::RenderReplaced::computeIntrinsicLogicalWidths):
(WebCore::RenderReplaced::computePreferredLogicalWidths):
The old code was trying to apply the intrinsic ratio calculation to
the intrinsic width, which is wrong per spec.
LayoutTests:
- fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes-expected.txt: Added.
- fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes.html: Added.
- 4:49 PM Changeset in webkit [143538] by
-
- 2 edits in trunk/Source/WebCore
LevelDB: Remove excess vector copy
https://bugs.webkit.org/show_bug.cgi?id=110399
Reviewed by Tony Chang.
Remove an extra copy introduced by the makeVector function.
No new tests, this is covered by existing tests.
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::safeGet):
- 4:48 PM Changeset in webkit [143537] by
-
- 18 edits in trunk
Zoomed, slow-scrolling pages keep recreating tiles when scrolled
https://bugs.webkit.org/show_bug.cgi?id=110379
Source/WebCore:
Reviewed by Tim Horton.
On slow-scrolling pages the TileCache makes the tiles the size of
the visible rect to minimize per-tile painting overhead. If the size
of that rect changes, the TileCache re-creates all the tiles.
This was a problem whem zoomed, because mapping the visible rect
through the scale transform and then rounding it would cause the
size to keep changing, causing lots of tile re-creation.
Fix by carrying the visibleRect around as a FloatRect, and doing
the same for the exposedRect. We then only expand to integers
when computing the tile size. This also fixes an issue where we could
sometimes make extra tiles because of fractional bits of tiles at the edges,
as shown by the test result change.
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateVisibleRect):
- platform/graphics/ca/mac/TileCache.h:
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setVisibleRect):
(WebCore::TileCache::setExposedRect):
(WebCore::TileCache::prepopulateRect):
(WebCore::TileCache::computeTileCoverageRect):
(WebCore::TileCache::tileSizeForCoverageRect):
(WebCore::TileCache::blankPixelCountForTiles):
(WebCore::TileCache::revalidateTiles):
(WebCore::TileCache::ensureTilesForRect):
- platform/graphics/ca/mac/WebTileLayer.mm:
(-[WebTileLayer logFilledFreshTile]):
Source/WebKit2:
Reviewed by Tim Horton.
Make the visible rect and exposed rects passed through
the drawing area to the tile cache FloatRects instead of IntRects.
- UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
(-[WKView _updateWindowAndViewFrames]):
(-[WKView enableFrameSizeUpdates]):
(-[WKView setMinimumWidthForAutoLayout:]):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::viewExposedRectChanged):
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setExposedRect):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewExposedRectChanged):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
LayoutTests:
Reviewed by Tim Horton.
This test now just has one tile, rather than four. There is an apparent issue
with the integral tile cache coverage rect being smaller than the visible rect.
This is caused by rounding when dumping the tile coverage rect.
- platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:
- 4:46 PM HackingOnNewRunWebKitTests edited by
- (diff)
- 4:45 PM HackingOnNewRunWebKitTests edited by
- actually fill out a high-level overview of how things work. (diff)
- 4:45 PM Changeset in webkit [143536] by
-
- 9 edits in trunk/Source
Unreviewed. Remove references to SAFARI_THEME from Windows Solution.
<rdar://problem/13258710>
- config.h:
- page/Settings.cpp:
- page/Settings.h:
- platform/win/ScrollbarThemeWin.cpp:
- rendering/RenderThemeWin.cpp:
- WebKitClassFactory.cpp:
- WebView.cpp:
- 4:33 PM Changeset in webkit [143535] by
-
- 6 edits4 adds in trunk
[CSS Grid Layout] Implement the auto-placement algorithm without grid growth
https://bugs.webkit.org/show_bug.cgi?id=110277
Reviewed by Tony Chang.
Source/WebCore:
Tests: fast/css-grid-layout/grid-item-addition-auto-placement-update.html
fast/css-grid-layout/grid-item-removal-auto-placement-update.html
fast/css-grid-layout/grid-auto-flow-resolution.html (extended to cover more cases)
This change implements most of the auto-placement algorithm per
http://dev.w3.org/csswg/css3-grid-layout/#auto-placement-algo
To limit the size of the code change, it doesn't implement growing the grid if there
are no empty grid areas. If we don't find any empty grid areas, we just insert in the first
one, like what grid-auto-flow: none would do (which explains the test failures).
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridIterator::nextEmptyGridArea):
Added this function to return the GridCoordinate of the next empty grid area along
the iterator's direction.
(WebCore::RenderGrid::placeItemsOnGrid):
Split this function into the different steps below. For efficiency, collect the auto vs specified
major axis grid items in different Vectors.
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
Added this function that implements part of step 1 of the algorithm (the grid items without
auto row / column are already handled in placeItemsOnGrid).
(WebCore::RenderGrid::placeAutoMajorAxisItemsOnGrid):
Added this function that iterates over the auto grid items and call placeAutoMajorAxisItemOnGrid.
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
Added this method to handle the step 4 of the algorithm. Based on the minor axis's position,
it either walks along the major axis once or several times until it finds an empty grid area
for the grid item.
(WebCore::RenderGrid::autoPlacementMajorAxisPositionForChild):
(WebCore::RenderGrid::autoPlacementMinorAxisPositionForChild):
(WebCore::RenderGrid::autoPlacementMajorAxisDirection):
(WebCore::RenderGrid::autoPlacementMinorAxisDirection):
Added these helper functions that return minor / major axis positions & direction.
- rendering/RenderGrid.h:
Added the previous new RenderGrid functions.
LayoutTests:
- fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
- fast/css-grid-layout/grid-auto-flow-resolution.html:
- fast/css-grid-layout/grid-item-addition-auto-placement-update-expected.txt: Added.
- fast/css-grid-layout/grid-item-addition-auto-placement-update.html: Added.
- fast/css-grid-layout/grid-item-removal-auto-placement-update-expected.txt: Added.
- fast/css-grid-layout/grid-item-removal-auto-placement-update.html: Added.
The current algorithm doesn't grow the grid but falls back to inserting the element at
position (1, 1). The failures in these tests are due to that.
- 4:32 PM Changeset in webkit [143534] by
-
- 1 edit2 deletes in branches/chromium/1410
Revert 130774
max-width property is does not overriding the width properties for css tables(display:table)
https://bugs.webkit.org/show_bug.cgi?id=98455
Patch by Pravin D <pravind.2k4@gmail.com> on 2012-10-09
Reviewed by Tony Chang.
Source/WebCore:
The max-width property determines the maximum computed width an element can have. In case of css tables(display:table),
the computed was not being limited by the max-width property. The current patch fixes this issue.
Test: fast/table/css-table-max-width.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::updateLogicalWidth):
Logic to compute the logical width of an element such that it does not exceed the max-width value.
Also when both min-width and max-width are present, the following contraint is used to compute the logical width:
1) min-width < Computed LogicalWidth < max-width, when min-width < max-width.
2) Computed LogicalWidth = min-width, when min-width > max-width.
LayoutTests:
- fast/table/css-table-max-width-expected.txt: Added.
- fast/table/css-table-max-width.html: Added.
TBR=tony@chromium.org
Review URL: https://codereview.chromium.org/12316027
- 4:32 PM Changeset in webkit [143533] by
-
- 6 edits2 copies6 adds in trunk
Accept 'allowfullscreen' in addition to 'webkitallowfullscreen'.
https://bugs.webkit.org/show_bug.cgi?id=110374
Reviewed by Adam Barth.
Source/WebCore:
The fullscreen API also includes a new HTML attribute for iframes
which permits its use. That attribute, 'allowfullcreen' is now
included in the HTML specification [1] and is stable enough
to remove the webkit prefix.
[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-allowfullscreen
Tests: fullscreen/full-screen-enabled-prefixed.html
fullscreen/full-screen-iframe-allowed-prefixed.html
fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute.html
- dom/Document.cpp:
(WebCore::isAttributeOnAllOwners):
(WebCore::Document::fullScreenIsAllowedForElement):
(WebCore::Document::webkitFullscreenEnabled):
- html/HTMLAttributeNames.in:
LayoutTests:
Two previous tests duplicated to preserve testing webkitallowfullscreen
and then modified to test allowfullscreen.
A new test 'full-screen-iframe-with-mixed-allow-webkitallow-attribute.html'
added to test a mixed nesting of iframs with both allowfullscreen and
webkitallowfullscreen.
- fullscreen/full-screen-enabled-prefixed-expected.txt: Added.
- fullscreen/full-screen-enabled-prefixed.html: Copied from LayoutTests/fullscreen/full-screen-enabled.html.
- fullscreen/full-screen-enabled.html:
- fullscreen/full-screen-iframe-allowed-prefixed-expected.txt: Added.
- fullscreen/full-screen-iframe-allowed-prefixed.html: Copied from LayoutTests/fullscreen/full-screen-iframe-allowed.html.
- fullscreen/full-screen-iframe-allowed.html:
- fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute-expected.txt:
- fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute.html: Added.
- fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe1.html: Added.
- fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe2.html: Added.
- 4:31 PM Changeset in webkit [143532] by
-
- 2 edits in trunk/Tools
[GTK] Re-enable 3D CSS transforms when using build-webkit
https://bugs.webkit.org/show_bug.cgi?id=110402
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-20
Reviewed by Xan Lopez.
- Scripts/webkitperl/FeatureList.pm: Enable 3D rendering by default
when building WebKitGTK+.
- 4:20 PM Changeset in webkit [143531] by
-
- 1 edit2 copies in branches/chromium/1364
Merge 142365
BUG=174017
Review URL: https://codereview.chromium.org/12310030
- 4:17 PM Changeset in webkit [143530] by
-
- 15 edits in branches/chromium/1364
Merge 142759
BUG=174566
Review URL: https://codereview.chromium.org/12316026
- 4:07 PM Changeset in webkit [143529] by
-
- 81 edits2 moves33 adds1 delete in trunk
Get VS2010 Solution B&I ready.
<rdar://problem/1322988>
Rubberstamped by Timothy Horton.
Add Production configuration.
Add a submit solutions with a DebugSuffix configuration.
Modify B&I make files as necessary.
- 4:05 PM Changeset in webkit [143528] by
-
- 2 edits2 copies in branches/chromium/1410
Merge 143454
BUG=176738
Review URL: https://codereview.chromium.org/12316025
- 4:02 PM Changeset in webkit [143527] by
-
- 1 edit2 copies in branches/chromium/1364
Merge 142358
BUG=173402
Review URL: https://codereview.chromium.org/12310028
- 4:00 PM Changeset in webkit [143526] by
-
- 2 edits in trunk/Source/WebCore
[v8] Fix an erroneous WrapperGrouper call in preparation for refactoring
https://bugs.webkit.org/show_bug.cgi?id=110396
Reviewed by Kentaro Hara.
This is in preparation for a refactor to expose a simplified
WrapperGrouper interface to V8 wrapper classes enabling them to
specify multiple roots per wrapper object.
- bindings/v8/V8GCController.cpp: Since MutationObservers are not Nodes, the correct call here is addObjectToGroup, as it is for all other non-Node wrappers.
- 3:59 PM Changeset in webkit [143525] by
-
- 1 edit2 copies in branches/chromium/1364
Merge 142657
BUG=173399
Review URL: https://codereview.chromium.org/12330035
- 3:58 PM Changeset in webkit [143524] by
-
- 1 edit2 copies in branches/chromium/1364
Merge 142539
BUG=173068
Review URL: https://codereview.chromium.org/12318024
- 3:53 PM Changeset in webkit [143523] by
-
- 3 edits in branches/chromium/1410/Source
Merge 143347
BUG=174627
Review URL: https://codereview.chromium.org/12321031
- 3:52 PM Changeset in webkit [143522] by
-
- 1 edit4 copies in branches/chromium/1364
Merge 143514
BUG=176882
Review URL: https://codereview.chromium.org/12327026
- 3:50 PM Changeset in webkit [143521] by
-
- 1 edit4 copies in branches/chromium/1410
Merge 143514
BUG=176882
Review URL: https://codereview.chromium.org/12318023
- 3:44 PM Changeset in webkit [143520] by
-
- 3 edits2 adds in trunk
Line layout (but not pref widths) double-counts word spacing when between inlines
https://bugs.webkit.org/show_bug.cgi?id=110381
Reviewed by Emil A Eklund.
Source/WebCore:
When a word break with a space occurs between inlines and word-spacing is non-zero,
line layout incorrectly committed the word-spacing value to the line twice, causing
wrapping in inline-blocks. To fix this, clear the word-spacing value when between
words and ignoring spaces, as we will already have added the word-spacing to the
line.
Test: fast/text/word-space-between-inlines.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/text/word-space-between-inlines-expected.html: Added.
- fast/text/word-space-between-inlines.html: Added.
- 3:44 PM Changeset in webkit [143519] by
-
- 2 edits in branches/chromium/1410/Source/WebKit/chromium
Merge 142564
BUG=174895
Review URL: https://codereview.chromium.org/12310026
- 3:31 PM Changeset in webkit [143518] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Check offset for initialized value
https://bugs.webkit.org/show_bug.cgi?id=110390
Reviewed by Rob Buis.
Instead of checking isEmpty, which checks for either point being <= 0, we want to explicitly check
for the initialized value of (-1, -1). This would be set in redrawSpellCheckDialogIfRequired, and
triggers the restore from cache in requestSpellingCheckingOptions.
Internally reviewed by Gen Mak.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
- 3:29 PM Changeset in webkit [143517] by
-
- 1 edit in branches/chromium/1364/Source/WebCore/editing/CompositeEditCommand.cpp
Merge 142642
BUG=175342
Review URL: https://codereview.chromium.org/12324025
- 3:25 PM Changeset in webkit [143516] by
-
- 1 edit in branches/chromium/1364/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp
Merge 141851
BUG=172926
Review URL: https://codereview.chromium.org/12317033
- 3:21 PM Changeset in webkit [143515] by
-
- 4 edits in branches/chromium/1410/Source
Merge 142755
[Qt] window.open passes height and width parameters even if not defined in a page
https://bugs.webkit.org/show_bug.cgi?id=107705
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Do not override width or height of 0, as that indicates default size, and not minimum size.
Tested by tst_qwebpage.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::adjustWindowRect):
Source/WebKit/efl:
Do not resize window when default size is requested.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::setWindowRect):
Source/WebKit/gtk:
Do not resize window when default size is requested.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::setWindowRect):
Source/WebKit/qt:
Test that minimum size is applied only when the requested size is too small,
not when default is requested.
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage):
(TestPage):
(TestPage::TestPage):
(TestPage::createWindow):
(TestPage::slotGeometryChangeRequested):
(tst_QWebPage::openWindowDefaultSize):
TBR=allan.jensen@digia.com
Review URL: https://codereview.chromium.org/12320020
- 3:13 PM Changeset in webkit [143514] by
-
- 3 edits4 adds in trunk
Source/WebCore: Crash in WebCore::FrameLoader::checkCompleted()
https://bugs.webkit.org/show_bug.cgi?id=110237
Reviewed by Abhishek Arya.
Test: http/tests/misc/delete-frame-during-readystatechange.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted): Protect before setReadyState() is called.
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=110237
Reviewed by Abhishek Arya.
- http/tests/misc/delete-frame-during-readystatechange-expected.txt: Added.
- http/tests/misc/delete-frame-during-readystatechange.html: Added.
- http/tests/misc/resources/delete-frame-during-readystatechange-frame.html: Added.
- http/tests/misc/resources/empty.ogv: Added.
- 3:04 PM Changeset in webkit [143513] by
-
- 2 edits in branches/chromium/1364/Source/WebCore/Modules/webaudio
Merge 142687
BUG=172331
Review URL: https://codereview.chromium.org/12321030
- 3:00 PM Changeset in webkit [143512] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Limit LevelDB's max open files
https://bugs.webkit.org/show_bug.cgi?id=109993
Reviewed by Tony Chang.
LevelDB keeps up to 1000 (by default) data files open at a time to
avoid having to open() them. This has caused chromium to hit the
process-wide open file limit. This patch changes max_open_files to 20,
as that's the minimum permitted by LevelDB and we have no reason to
think that performance will suffer because of the extra open calls.
No new tests - a chromium browser test that tracks the open LevelDB
files is plausible but is blocked on http://crbug.com/177249/.
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::openDB):
- 2:56 PM Changeset in webkit [143511] by
-
- 4 edits in trunk/Source/WebKit/chromium
Add gyp option to switch ENABLE(SQL_DATABASE)
https://bugs.webkit.org/show_bug.cgi?id=109303
http://code.google.com/p/chromium/issues/detail?id=22208
Patch by Paweł Hajdan, Jr. <phajdan.jr@chromium.org> on 2013-02-20
Reviewed by Tony Chang.
This will be useful to implement build with system sqlite.
- features.gypi:
- src/ChromeClientImpl.cpp:
(WebKit):
- src/ChromeClientImpl.h:
(ChromeClientImpl):
- 2:54 PM Changeset in webkit [143510] by
-
- 2 edits2 copies in branches/chromium/1364
Merge 142816
BUG=171557
Review URL: https://codereview.chromium.org/12315018
- 2:49 PM Changeset in webkit [143509] by
-
- 2 edits in trunk/Source/JavaScriptCore
EME: Enable both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 until clients transition to the new API.
https://bugs.webkit.org/show_bug.cgi?id=110284
Reviewed by Eric Carlson.
Re-enable the ENCRYPTED_MEDIA flag.
- Configurations/FeatureDefines.xcconfig:
- 2:39 PM Changeset in webkit [143508] by
-
- 3 edits in branches/chromium/1364
Merge 142063
BUG=173906
Review URL: https://codereview.chromium.org/12324023
- 2:24 PM Changeset in webkit [143507] by
-
- 1 edit2 copies in branches/chromium/1364
Merge 142922
BUG-170679
Review URL: https://codereview.chromium.org/12310023
- 2:16 PM Changeset in webkit [143506] by
-
- 8 edits2 adds in trunk
[New Multicolumn] Resize RenderMultiColumnSets around their columns.
https://bugs.webkit.org/show_bug.cgi?id=110378.
Reviewed by Dirk Schulze.
Source/WebCore:
Test: fast/multicol/newmulticol/positioned-with-constrained-height.html.
- rendering/RenderBlock.h:
(RenderBlock):
Make computeOverflow public so that RenderMultiColumnFlowThread can
access it.
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::layout):
Subclass layout to recompute the overflow for RenderMultiColumnBlock
after the flow thread has finished layout. This way it can account
for changes in RenderMultiColumnSets without having to do a second
layout pass.
- rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):
Override layout().
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnCount):
Clean up a comment that referred to portions as region rects still.
(WebCore::RenderMultiColumnSet::setFlowThreadPortionRect):
- rendering/RenderMultiColumnSet.h:
- rendering/RenderRegion.h:
(WebCore::RenderRegion::setFlowThreadPortionRect):
Make setFlowThreadPortionRect virtual and actually mutate the size
and position of RenderMultiColumnSets so that they enclose their
column rects.
LayoutTests:
- fast/multicol/newmulticol/positioned-with-constrained-height-expected.html: Added.
- fast/multicol/newmulticol/positioned-with-constrained-height.html: Added.
- 2:14 PM Changeset in webkit [143505] by
-
- 22 edits in trunk
Enable CANVAS_PATH flag
https://bugs.webkit.org/show_bug.cgi?id=108508
Reviewed by Simon Fraser.
Enable CANVAS_PATH flag on trunk.
.:
Existing tests cover the feature.
- Source/cmake/WebKitFeatures.cmake:
Source/JavaScriptCore:
Existing tests cover the feature.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Existing tests cover the feature.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Existing tests cover the feature.
- fast/canvas/canvas-path-object-expected.txt:
- inspector/profiler/canvas2d/canvas2d-api-changes.html:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- 2:03 PM Changeset in webkit [143504] by
-
- 3 edits in trunk/Tools
Parse author names with commas in ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=110356
Reviewed by Dirk Pranke.
Paweł's name has a comma in it, which was confusing the ChangeLog parser.
- Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry): Move name splitting regexp into a constant.
(ChangeLogEntry._parse_reviewer_text): Use _split_reviewer_names.
(ChangeLogEntry._split_reviewer_names): Rename to be more specific.
(ChangeLogEntry._split_author_names_with_emails): Rename to be more specific and require emails.
(ChangeLogEntry._parse_author_text): Use _split_author_names_with_emails.
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_parse_authors): Test case with Paweł's name.
- 1:56 PM Changeset in webkit [143503] by
-
- 6 edits in trunk/Source/WebCore
Unreviewed, rolling out r143441.
http://trac.webkit.org/changeset/143441
https://bugs.webkit.org/show_bug.cgi?id=110376
May be causing chromium content_browsertests failures.
(Requested by vollick on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-20
- bindings/v8/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):
(WebCore::ScriptValue::toInspectorValue):
- bindings/v8/ScriptValue.h:
(WebCore::ScriptValue::ScriptValue):
(WebCore::ScriptValue::operator=):
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::isEqual):
(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):
(WebCore::ScriptValue::clear):
(WebCore::ScriptValue::v8Value):
(ScriptValue):
- bindings/v8/SharedPersistent.h:
(WebCore):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::scriptValueAsNode):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAttrGetterCustom):
- 1:53 PM Changeset in webkit [143502] by
-
- 11 edits in trunk
[Chromium] Add runtime flag for CanvasPath
https://bugs.webkit.org/show_bug.cgi?id=109997
Reviewed by Adam Barth.
Source/WebCore:
Add runtime flag for Chromium.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setCanvasPathEnabled):
(WebCore::RuntimeEnabledFeatures::canvasPathEnabled):
- html/canvas/DOMPath.idl:
- page/DOMWindow.idl:
Source/WebKit/chromium:
Add runtime flag for Chromium.
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableCanvasPath):
(WebKit):
(WebKit::WebRuntimeFeatures::isCanvasPathEnabled):
Tools:
Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
the constructor for Path on DOMWindow would never be activatable, since the script
is running after creating the DOMWindow object.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
- 1:53 PM Changeset in webkit [143501] by
-
- 4 edits2 copies in branches/chromium/1364
Merge 143060
Review URL: https://codereview.chromium.org/12328018
- 1:48 PM Changeset in webkit [143500] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening.
Patch by Ian Vollick <vollick@chromium.org> on 2013-02-20
- platform/chromium/TestExpectations:
- 1:45 PM Changeset in webkit [143499] by
-
- 9 edits in trunk/Source
Remove unnecessary includes for Platform.h from headers
https://bugs.webkit.org/show_bug.cgi?id=110300
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-20
Reviewed by Alexey Proskuryakov.
Source/WebCore:
wtf/Platform.h only need to be included in a few places directly
as it is included in config.h. Remove the unnecessay duplicate as
it can be confusing.
No new tests, no change in functionality.
- platform/SecureTextInput.h:
- platform/audio/Biquad.h:
- platform/audio/FFTFrame.h:
- platform/graphics/cpu/arm/filters/FEBlendNEON.h:
- platform/graphics/cpu/arm/filters/NEONHelpers.h:
- platform/graphics/filters/FELighting.h:
Source/WebKit2:
wtf/Platform.h only need to be included in a few places directly
as it is included in config.h. Remove the unnecessay duplicate as
it can be confusing.
- Shared/PrintInfo.h:
- 1:43 PM Changeset in webkit [143498] by
-
- 3 edits in trunk/Source/WebCore
[SVG] Update of element referenced by multiple 'use' nodes is absurdly slow
https://bugs.webkit.org/show_bug.cgi?id=97905
Reviewed by Dirk Schulze.
Rebuilding the shadow and instance trees of dependent use nodes recursively can be
extremely inefficient with non-trivial dependency graphs (the trees are not constructed
in topological order).
To avoid redundant buildShadowAndInstanceTree() invokations, separate the invalidation
phase from the actual tree (re)building phase, and only descend into the dependency DAG
during the invalidation phase (recursion also stops at nodes that have been previously
invalidated).
No new tests: functional coverage provided by existing tests, perfomance tracked by
PerformanceTests/SVG/SvgNestedUse.html.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::invalidateShadowTree):
(WebCore):
(WebCore::SVGUseElement::invalidateDependentShadowTrees):
- svg/SVGUseElement.h:
(SVGUseElement):
- 1:34 PM Changeset in webkit [143497] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening.
Patch by Ian Vollick <vollick@chromium.org> on 2013-02-20
- platform/chromium/TestExpectations:
- 1:31 PM Changeset in webkit [143496] by
-
- 4 edits in trunk/Source
[Chromium] Move WebKitPlatformSupport declaration to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=110262
Reviewed by Adam Barth.
In preparation for removing WebKitPlatformSupport.h entirely (once
downstream references to that file have been updated). Part of a
larger refactoring series; see tracking bug 82948.
Source/Platform:
- chromium/public/Platform.h:
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
(WebKit):
Source/WebKit/chromium:
- public/platform/WebKitPlatformSupport.h:
- 1:28 PM Changeset in webkit [143495] by
-
- 3 edits in trunk/LayoutTests
Make the test land in r143482 less platform-specific
Add outline:none to the test so platform-specific outlines don't kick in and
make us require separate results for Mac and Linux.
Unreviewed, gardening.
- fast/repaint/paint-caret-in-div-with-negative-indent-expected.png:
- fast/repaint/paint-caret-in-div-with-negative-indent.html:
- 1:27 PM Changeset in webkit [143494] by
-
- 5 edits2 deletes in branches/chromium/1364
Revert 143493
Review URL: https://codereview.chromium.org/12314017
- 1:24 PM Changeset in webkit [143493] by
-
- 5 edits2 copies in branches/chromium/1364
Merge 142820
BUG=170184
- 1:20 PM Changeset in webkit [143492] by
-
- 5 edits2 copies in branches/chromium/1364
Merge 142500
BUG=169398
Review URL: https://codereview.chromium.org/12327019
- 1:15 PM Changeset in webkit [143491] by
-
- 1 edit2 copies in branches/chromium/1364
Merge 142899
BUG=168982
Review URL: https://codereview.chromium.org/12315016
- 1:15 PM Changeset in webkit [143490] by
-
- 2 edits in trunk/Source/WebCore
RenderLayerBacking should initialize TiledBacking's isInWindow state with Page's isInWindow, not isOnscreen
https://bugs.webkit.org/show_bug.cgi?id=110370
<rdar://problem/13254006>
Reviewed by Simon Fraser.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
- 1:10 PM Changeset in webkit [143489] by
-
- 5 edits in trunk/Source/WebCore
Cleanup the SQLTransaction and SQLTransactionBackend state dispatch
to only honor a state transition request if the associated database
hasn't been interrupted.
https://bugs.webkit.org/show_bug.cgi?id=110247.
Reviewed by Antti Koivisto.
No new tests.
- Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::performPendingCallback):
(WebCore::SQLTransaction::computeNextStateAndCleanupIfNeeded):
- Modules/webdatabase/SQLTransaction.h:
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::computeNextStateAndCleanupIfNeeded):
(WebCore::SQLTransactionBackend::performNextStep):
- Modules/webdatabase/SQLTransactionBackend.h:
- 1:09 PM Changeset in webkit [143488] by
-
- 2 edits in trunk/Source/WTF
Moar hardening
https://bugs.webkit.org/show_bug.cgi?id=110275
Reviewed by Mark Hahnenberg.
We now poison objects when they get freed, and verify that
any object that is being freed is not poisoned. If the
object looks like it's poisoned we validate the freelist,
and ensure the object is not already present. If it is
we crash.
On allocation, we ensure that the object being allocated
is poisoned, then clear the poisoning fields.
- wtf/FastMalloc.cpp:
(WTF::internalEntropyValue):
(WTF):
(WTF::freedObjectStartPoison):
(WTF::freedObjectEndPoison):
(TCMalloc_ThreadCache_FreeList):
(WTF::TCMalloc_ThreadCache_FreeList::Validate):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Allocate):
(WTF::TCMalloc_ThreadCache::Deallocate):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- 1:02 PM Changeset in webkit [143487] by
-
- 10 edits in trunk/Source/WebCore
ResourceHandle::loadResourceSynchronously should have blob support in cross-platform code
https://bugs.webkit.org/show_bug.cgi?id=110364
Reviewed by Anders Carlsson.
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Added a cross-platform version to keep blob-related logic in one place.
- platform/network/blackberry/ResourceHandleBlackBerry.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously): Renamed loadResourceSynchronously to platformLoadResourceSynchronously, removed blob handling from platforms that had it.
- 1:00 PM Changeset in webkit [143486] by
-
- 3 edits10 adds in trunk
[New Multicolumn] RenderMultiColumnFlowThreads should establish a BFC.
https://bugs.webkit.org/show_bug.cgi?id=110366.
Reviewed by Antti Koivisto.
Source/WebCore:
RenderFlowThreads should establish a block formatting context always.
CSS Regions have named flow thread that they absolutely position, and so
they got this for free by being absolutely positioned.
RenderMultiColumnFlowThreads, however, are relative positioned, so we need
to just add an isRenderFlowThread case specifically so we're not dependent
on the positioning scheme used for the flow thread to establish the BFC.
Test: fast/multicol/newmulticol/float-*.html.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
LayoutTests:
- fast/multicol/newmulticol/float-avoidance-expected.html: Added.
- fast/multicol/newmulticol/float-avoidance.html: Added.
- fast/multicol/newmulticol/float-multicol-expected.html: Added.
- fast/multicol/newmulticol/float-multicol.html: Added.
- fast/multicol/newmulticol/float-paginate-complex-expected.html: Added.
- fast/multicol/newmulticol/float-paginate-complex.html: Added.
- fast/multicol/newmulticol/float-paginate-empty-lines-expected.html: Added.
- fast/multicol/newmulticol/float-paginate-empty-lines.html: Added.
- fast/multicol/newmulticol/float-paginate-expected.html: Added.
- fast/multicol/newmulticol/float-paginate.html: Added.
- 12:14 PM Changeset in webkit [143485] by
-
- 2 edits in branches/chromium/1410/Source/Platform
Merge 142496
[Chromium] FilterTypeSaturatingBrightness enum
https://bugs.webkit.org/show_bug.cgi?id=109380
Introduce a new WebFilterOperation::FilterType enum (FilterTypeSaturatingBrightness)
to support existing interntal clients which rely on the current saturating brightness
behavior (in preparation of switching to the new brightness implementation).
Reviewed by James Robinson.
- chromium/public/WebFilterOperation.h:
(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::createSaturatingBrightnessFilter):
(WebKit::WebFilterOperation::setAmount):
TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/12321021
- 11:58 AM Changeset in webkit [143484] by
-
- 4 edits2 adds in trunk
[New Multicolumn] Column gap is computed incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=110360.
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/multicol/newmulticol/layers-split-across-columns.html.
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnGap):
Make sure we ask the RenderMultiColumnBlock for the gap rather than our
own style, since we don't actually have the gap value in our style.
(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
- rendering/RenderMultiColumnSet.h:
Fix another spot where the columnGap was an int. It should be a LayoutUnit.
LayoutTests:
- fast/multicol/newmulticol/layers-split-across-columns-expected.html: Added.
- fast/multicol/newmulticol/layers-split-across-columns.html: Added.
- 11:51 AM Changeset in webkit [143483] by
-
- 3 edits3 adds in trunk
No caret on empty contenteditable element with negative text-indent
https://bugs.webkit.org/show_bug.cgi?id=108633
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/repaint/paint-caret-in-div-with-negative-indent.html
When an editable element has a negative text indent we won't paint the caret when the
element is empty because it falls outside the element's border box. To ensure the caret is painted,
account for any negative indent with our overflow.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow):
LayoutTests:
- fast/repaint/paint-caret-in-div-with-negative-indent-expected.png: Added.
- fast/repaint/paint-caret-in-div-with-negative-indent-expected.txt: Added.
- fast/repaint/paint-caret-in-div-with-negative-indent.html: Added.
- 11:09 AM Changeset in webkit [143482] by
-
- 18 edits in tags/Safari-537.31.5/Source
Merged r143418. <rdar://problem/13067171>
- 11:01 AM Changeset in webkit [143481] by
-
- 2 edits1 delete in tags/Safari-537.31.5/Source/WebKit2
Merged r143113. <rdar://problem/13236883>
- 10:45 AM Changeset in webkit [143480] by
-
- 7 edits in trunk/Tools
[chromium] use a WebTestProxyBase pointer to identify the window we need the history for
https://bugs.webkit.org/show_bug.cgi?id=110346
Reviewed by Adam Barth.
Using an index is very brittle, as the TestRunner API does not define
any ordering of windows.
Also, make TestRunner::shouldDumpBackForwardList() so content shell can
trigger the capturing in the browser process before generating the
text dump.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner):
(WebTestRunner::WebTestDelegate::captureHistoryForWindow):
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::captureTree):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::captureHistoryForWindow):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 10:45 AM Changeset in webkit [143479] by
-
- 7 edits in trunk/Source/WebCore
Remove stretchesToMinIntrinsicLogicalWidth
https://bugs.webkit.org/show_bug.cgi?id=110266
Reviewed by Emil Eklund.
This was only used by fieldsets and now we have a way to express this
concept in CSS.
- WebCore.order:
- css/html.css:
Make fieldsets min-width: -webkit-min-content.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computePositionedLogicalWidth):
- rendering/RenderBox.h:
Remove all calls to stretchesToMinIntrinsicLogicalWidth.
- 10:41 AM Changeset in webkit [143478] by
-
- 4 edits in tags/Safari-537.31.5/Source
Versioning.
- 10:37 AM Changeset in webkit [143477] by
-
- 1 copy in tags/Safari-537.31.5
New Tag.
- 10:37 AM Changeset in webkit [143476] by
-
- 4 edits4 adds in trunk
Make intrinsic width values work for positioned elements
https://bugs.webkit.org/show_bug.cgi?id=110264
Reviewed by Tony Chang.
Source/WebCore:
Tests: fast/css-intrinsic-dimensions/intrinsic-sized-absolutes.html
fast/css-intrinsic-dimensions/width-shrinks-avoid-floats.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeIntrinsicLogicalWidthUsing):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
Move the computation of intrinsic widths out into a helper function so that
computePositionedLogicalWidthUsing can use it. As per the current spec,
fill-available measures shrink to avoid floats. http://dev.w3.org/csswg/css3-sizing/
(WebCore::RenderBox::computePositionedLogicalWidth):
Compute intrinsic min-widths in addition to non-zero ones. Intrinsic widths
return true for isZero. width and max-width don't need modifying since they already
call computePositionedLogicalWidthUsing for intrinsic widths.
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
Compute intrinsic widths and use a Fixed length for the rest of the positioned width
computation. Doesn't include bordersPlusPadding because the caller, expected the content
width and adds in the bordersPlusPadding later.
- rendering/RenderBox.h:
LayoutTests:
- fast/css-intrinsic-dimensions/intrinsic-sized-absolutes-expected.txt: Added.
- fast/css-intrinsic-dimensions/intrinsic-sized-absolutes.html: Added.
- fast/css-intrinsic-dimensions/width-shrinks-avoid-floats-expected.txt: Added.
- fast/css-intrinsic-dimensions/width-shrinks-avoid-floats.html: Added.
- 10:27 AM Changeset in webkit [143475] by
-
- 3 edits4 adds in trunk
input element with placeholder text and width set to 100% on focus causes overflow even after losing focus
https://bugs.webkit.org/show_bug.cgi?id=109020
Reviewed by David Hyatt.
Source/WebCore:
Tests: fast/forms/input-placeholder-layout-view.html
fast/forms/textarea-placeholder-layout-view.html
Placeholder elements don't affect layout so shouldn't contribute overflow either.
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
LayoutTests:
- fast/forms/input-placeholder-layout-view-expected.html: Added.
- fast/forms/input-placeholder-layout-view.html: Added.
- fast/forms/textarea-placeholder-layout-view-expected.html: Added.
- fast/forms/textarea-placeholder-layout-view.html: Added.
- 10:23 AM Changeset in webkit [143474] by
-
- 10 edits in trunk/Source/WebKit2
[WK2] Remove m_viewportSize in WebPage.
https://bugs.webkit.org/show_bug.cgi?id=110311
Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-20
Reviewed by Anders Carlsson.
EFL and Qt use m_viewSize as a contents size while Apple use it as a viewport
size, so EFL and Qt introduced m_viewportSize to make WebPage know a viewport
size.
EFL and Qt use m_viewSize as a contents size because the size of non compositing
layer is contents size, and EFL and Qt mark whole non compositing layer as dirty
using m_viewSize. Bug 110299 (http://webkit.org/b/110299) changes that it is not
necessary to know m_viewSize when marking whole non compositing layer as dirty.
So we can make EFL and Qt use m_viewSize as a viewport size also.
This patch removes m_viewportSize and related methods to increase readability.
- UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebView::setSize):
- UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::didChangeViewportSize):
- UIProcess/WebPageProxy.cpp:
(WebKit):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::pageRect):
(WebKit::WebChromeClient::contentsSizeChanged):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updateBackingStoreState):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setSize):
(WebKit::WebPage::sendViewportAttributesChanged):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/WebPage.messages.in:
- 10:21 AM Changeset in webkit [143473] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Remove idbFactory from WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=106457
Reviewed by Adam Barth.
Now that https://codereview.chromium.org/12230054 has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.
- public/platform/WebKitPlatformSupport.h:
(WebKit):
- src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
- 10:10 AM Changeset in webkit [143472] by
-
- 18 edits in trunk/Source/WebKit2
[WK2] add setNeedsDisplay in DrawingArea to mark whole layer as dirty.
https://bugs.webkit.org/show_bug.cgi?id=110299
Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-20
Reviewed by Anders Carlsson.
Currently, we call setNeedsDisplay with the size of WebPage to mark whole
backing store as dirty. However, the size of non compositing layer can be
inconsistent with the size of WebPage. For example, in Coordinated Graphics, the
size of non compositing layer is contents size.
So, WebPage should not assume the size of non compositing layer, and should just
call setNeedsDisplay when marking whole layer as dirty.
In addition, this patch renames from setNeedsDisplay() with a rect argument to
setNeedsDisplayInRect(), which matches to the terms of GraphicsLayer.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::invalidateContentsAndRootView):
(WebKit::WebChromeClient::invalidateContentsForSlowScroll):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::restoreViewState):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::setNonCompositedContentsNeedDisplay):
(WebKit):
(WebKit::CoordinatedLayerTreeHost::setNonCompositedContentsNeedDisplayInRect):
(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost):
- WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setNeedsDisplay):
(WebKit):
(WebKit::DrawingAreaImpl::setNeedsDisplayInRect):
(WebKit::DrawingAreaImpl::scroll):
(WebKit::DrawingAreaImpl::forceRepaint):
(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
(WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
(WebKit::DrawingAreaImpl::resumePainting):
- WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
- WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setSize):
(WebKit::WebPage::setDrawsBackground):
(WebKit::WebPage::setDrawsTransparentBackground):
(WebKit::WebPage::resumeActiveDOMObjectsAndAnimations):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplay):
(WebKit):
(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostGtk::scrollNonCompositedContents):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk):
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
(LayerTreeHostMac):
- WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
(WebKit):
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostMac::scrollNonCompositedContents):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
(RemoteLayerTreeDrawingArea):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::setNeedsDisplay):
(WebKit):
(WebKit::RemoteLayerTreeDrawingArea::setNeedsDisplayInRect):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplay):
(WebKit):
(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplayInRect):
- 9:56 AM Changeset in webkit [143471] by
-
- 36 edits2 moves in trunk/Source
Rename DatabaseBackend to DatabaseBackendBase.
https://bugs.webkit.org/show_bug.cgi?id=110303.
Rubber stamped by Alexey Proskuryakov.
Source/WebCore:
This is a purely cosmetic change to make the naming consistent with
the front-end DatabaseBase.
No new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/webdatabase/AbstractDatabaseServer.h:
- Modules/webdatabase/Database.cpp:
(WebCore::Database::create):
(WebCore::Database::version):
- Modules/webdatabase/Database.h:
(Database):
- Modules/webdatabase/DatabaseBackend.cpp: Removed.
- Modules/webdatabase/DatabaseBackend.h: Removed.
- Modules/webdatabase/DatabaseBackendAsync.cpp:
(WebCore::DatabaseBackendAsync::DatabaseBackendAsync):
(WebCore::DatabaseBackendAsync::performOpenAndVerify):
- Modules/webdatabase/DatabaseBackendAsync.h:
- Modules/webdatabase/DatabaseBackendBase.cpp: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackend.cpp.
(WebCore::DatabaseBackendBase::databaseInfoTableName):
(WebCore::DatabaseBackendBase::DatabaseBackendBase):
(WebCore::DatabaseBackendBase::~DatabaseBackendBase):
(WebCore::DatabaseBackendBase::closeDatabase):
(WebCore::DatabaseBackendBase::version):
(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
(DoneCreatingDatabaseOnExitCaller):
(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::securityOrigin):
(WebCore::DatabaseBackendBase::stringIdentifier):
(WebCore::DatabaseBackendBase::displayName):
(WebCore::DatabaseBackendBase::estimatedSize):
(WebCore::DatabaseBackendBase::fileName):
(WebCore::DatabaseBackendBase::details):
(WebCore::DatabaseBackendBase::getVersionFromDatabase):
(WebCore::DatabaseBackendBase::setVersionInDatabase):
(WebCore::DatabaseBackendBase::setExpectedVersion):
(WebCore::DatabaseBackendBase::getCachedVersion):
(WebCore::DatabaseBackendBase::setCachedVersion):
(WebCore::DatabaseBackendBase::getActualVersionForTransaction):
(WebCore::DatabaseBackendBase::disableAuthorizer):
(WebCore::DatabaseBackendBase::enableAuthorizer):
(WebCore::DatabaseBackendBase::setAuthorizerReadOnly):
(WebCore::DatabaseBackendBase::setAuthorizerPermissions):
(WebCore::DatabaseBackendBase::lastActionChangedDatabase):
(WebCore::DatabaseBackendBase::lastActionWasInsert):
(WebCore::DatabaseBackendBase::resetDeletes):
(WebCore::DatabaseBackendBase::hadDeletes):
(WebCore::DatabaseBackendBase::resetAuthorizer):
(WebCore::DatabaseBackendBase::maximumSize):
(WebCore::DatabaseBackendBase::incrementalVacuumIfNeeded):
(WebCore::DatabaseBackendBase::interrupt):
(WebCore::DatabaseBackendBase::isInterrupted):
(WebCore::DatabaseBackendBase::reportOpenDatabaseResult):
(WebCore::DatabaseBackendBase::reportChangeVersionResult):
(WebCore::DatabaseBackendBase::reportStartTransactionResult):
(WebCore::DatabaseBackendBase::reportCommitTransactionResult):
(WebCore::DatabaseBackendBase::reportExecuteStatementResult):
(WebCore::DatabaseBackendBase::reportVacuumDatabaseResult):
- Modules/webdatabase/DatabaseBackendBase.h: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackend.h.
(DatabaseBackendBase):
- Modules/webdatabase/DatabaseBackendSync.cpp:
(WebCore::DatabaseBackendSync::DatabaseBackendSync):
- Modules/webdatabase/DatabaseBackendSync.h:
- Modules/webdatabase/DatabaseBase.h:
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):
(WebCore::DatabaseManager::getMaxSizeForDatabase):
- Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
- Modules/webdatabase/DatabaseServer.cpp:
(WebCore::DatabaseServer::openDatabase):
(WebCore::DatabaseServer::createDatabase):
(WebCore::DatabaseServer::getMaxSizeForDatabase):
- Modules/webdatabase/DatabaseServer.h:
- Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::create):
- Modules/webdatabase/DatabaseSync.h:
(DatabaseSync):
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFile):
- Modules/webdatabase/DatabaseTracker.h:
(DatabaseTracker):
- Modules/webdatabase/OriginQuotaManager.cpp:
(WebCore::OriginQuotaManager::markDatabase):
- Modules/webdatabase/OriginQuotaManager.h:
(OriginQuotaManager):
- Modules/webdatabase/SQLTransactionClient.cpp:
(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
(WebCore::SQLTransactionClient::didExceedQuota):
- Modules/webdatabase/SQLTransactionClient.h:
(SQLTransactionClient):
- Modules/webdatabase/chromium/DatabaseObserver.h:
(DatabaseObserver):
- Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::NotifyDatabaseObserverOnCloseTask::create):
(WebCore::NotifyDatabaseObserverOnCloseTask::NotifyDatabaseObserverOnCloseTask):
(NotifyDatabaseObserverOnCloseTask):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::prepareToOpenDatabase):
(WebCore::DatabaseTracker::failedToOpenDatabase):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::create):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::CloseOneDatabaseImmediatelyTask):
(DatabaseTracker::CloseOneDatabaseImmediatelyTask):
(WebCore::DatabaseTracker::closeOneDatabaseImmediately):
- Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp:
(WebCore::NotifyDatabaseChangedTask::create):
(WebCore::NotifyDatabaseChangedTask::NotifyDatabaseChangedTask):
(NotifyDatabaseChangedTask):
(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
(WebCore::SQLTransactionClient::didExceedQuota):
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit/chromium:
- public/WebDatabase.h:
(WebDatabase):
- src/DatabaseObserver.cpp:
(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):
(WebCore::DatabaseObserver::reportOpenDatabaseResult):
(WebCore::DatabaseObserver::reportChangeVersionResult):
(WebCore::DatabaseObserver::reportStartTransactionResult):
(WebCore::DatabaseObserver::reportCommitTransactionResult):
(WebCore::DatabaseObserver::reportExecuteStatementResult):
(WebCore::DatabaseObserver::reportVacuumDatabaseResult):
- src/WebDatabase.cpp:
(WebKit::WebDatabase::WebDatabase):
- 9:48 AM Changeset in webkit [143470] by
-
- 7 edits2 adds in trunk
Source/WebKit/chromium: Fix use after free in ContextMenuClientImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=109220
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-20
Reviewed by Tony Chang.
ContextMenuClientImpl can use a DocumentMarker after it is freed. The DocumentMarker is originally allocated
by the spell checker. When the user context-clicks on a misspelling, ContextMenuClientImpl saves a reference
to the clicked DocumentMarker, changes the selection, and then uses the DocumentMarker. Changing the selection
causes re-check of spelling. If the spell check client serves the spellcheck request from cache, then re-checking
spelling will delete the DocumentMarker and add a new one. This invalidates the DocumentMarker reference held by
ContextMenuClientImpl. When ContextMenuClientImpl attempts to use the DocumentMarker, Address Sanitizer detects
use after free. The fix is to save a copy of the DocumentMarker before changing selection.
- src/ContextMenuClientImpl.cpp:
(WebKit::selectMisspellingAsync): Save a copy of DocumentMarker before changing selection.
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Use DocumentMarker instead of Vector<DocumentMarker*>.
Tools: [Chromium] Serve spellcheck suggestions for editing/spelling/spelling-changed-text.html from cache
https://bugs.webkit.org/show_bug.cgi?id=109220
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-19
Reviewed by Tony Chang.
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(WebTestRunner::MockSpellCheck::hasInCache): Added a method to detect whether spellcheck results can be served from cache.
(WebTestRunner):
(WebTestRunner::MockSpellCheck::fillSuggestionList): Modified to suggest "checker" for the word "cheher".
(WebTestRunner::MockSpellCheck::initializeIfNeeded): Modified to mark "cheher" as misspelling.
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
(MockSpellCheck):
- DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
(WebTestRunner::SpellCheckClient::requestCheckingOfText): Modified to serve spellcheck suggestions from cache when possible.
LayoutTests: Spellchecker should not crash after text has changed and spellcheck results are served from cache
https://bugs.webkit.org/show_bug.cgi?id=109220
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-20
Reviewed by Tony Chang.
- editing/spelling/spelling-changed-text-expected.txt: Added the expected output for serving spellcheck results from cache for edited text.
- editing/spelling/spelling-changed-text.html: Added a test for serving spellcheck results from cache for edited text.
- 9:33 AM WebKit Team edited by
- Add Max Vujovic to committers list. (diff)
- 9:23 AM Changeset in webkit [143469] by
-
- 4 edits in trunk/Source/WebCore
iOS does not use CaptionUserPreferencesMac
https://bugs.webkit.org/show_bug.cgi?id=110259
Reviewed by Dean Jackson.
- page/CaptionUserPreferencesMac.h: Add PLATFORM(IOS) guard
- page/CaptionUserPreferencesMac.mm: Ditto.
- page/PageGroup.cpp:
(WebCore::PageGroup::captionPreferences): Ditto.
- 9:15 AM Changeset in webkit [143468] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r183552. Requested by
"Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-20
- DEPS:
- 9:10 AM WebKit Team edited by
- Added Hans Muller to list of committers (diff)
- 8:59 AM Changeset in webkit [143467] by
-
- 6 edits2 adds in trunk
[New Multicolumn] Make layers paint properly in columns.
https://bugs.webkit.org/show_bug.cgi?id=110296.
Reviewed by Sam Weinig.
Source/WebCore:
Construct the style for the RenderMultiColumnFlowThread such that it
establishes a stacking context (by being position:relative
with a z-index of 0). This causes the layer collection code
to correctly ignore the RenderFlowThread layers during normal
painting.
Fix more clipping bugs to eliminate subpixel layout differences
between old and new multicolumn.
Test: fast/multicol/newmulticol/layers-in-multicol.html
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::createMultiColumnFlowThreadStyle):
(WebCore):
(WebCore::RenderMultiColumnBlock::addChild):
Use a custom style (similar to what normal RenderFlowThreads do)
for the RenderMultiColumnFlowThread that makes it a stacking
context.
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
Fix the overflow calculations out the leftmost and rightmost
columns to actually look at the physical placement of the columns.
The old code was backwards for RTL.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
Fix the clipping done by overflowRectForFlowThreadPortion to min
and max with the passed-in portion rect so that subclasses that
inflate the rect prior to passing it into the method don't have that
inflation discarded.
LayoutTests:
- fast/multicol/newmulticol/layers-in-multicol-expected.html: Added.
- fast/multicol/newmulticol/layers-in-multicol.html: Added.
- 8:43 AM Changeset in webkit [143466] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Make sure to always sync before reusing backingstore tiles.
https://bugs.webkit.org/show_bug.cgi?id=109863
PR 296118
Reviewed by Rob Buis.
Internally reviewed by Mike Lattanzio and Konrad Piascik.
In SVN r142137, I replaced a syncToCurrentMessage() call
with updateSuspendScreenUpdateState() in some cases,
which internally calls the same function.
Unfortunately, when I optimized updateSuspendScreenUpdateState()
to only sync when the state is actually being changed,
I omitted an adaptation of adoptAsFrontState() which would
rely on this sync but now didn't always perform it.
This caused a bad race condition as tile buffers could now
be accessed from the WebKit thread and the UI thread at
the same time. Fix it by (optionally) letting the caller
of updateSuspendScreenUpdateState() know whether a sync
was performed, and adapt adoptAsFrontState() accordingly.
Also fixes some excessive flicker caused by the same
race condition.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
(BlackBerry::WebKit::BackingStorePrivate::adoptAsFrontState):
- Api/BackingStore_p.h:
- 8:12 AM WebKit Team edited by
- Adding myself (diff)
- 8:08 AM Changeset in webkit [143465] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: CSSProperty.status defaults to "style" not "active"
https://bugs.webkit.org/show_bug.cgi?id=110348
Reviewed by Timothy Hatcher.
- inspector/Inspector.json: Fix the default property status to be "style" in the description.
- 8:07 AM WebKit Team edited by
- (diff)
- 7:38 AM Changeset in webkit [143464] by
-
- 2 edits in trunk/Source/WebCore
[v8] potentially disposed handle returned for npapi object
https://bugs.webkit.org/show_bug.cgi?id=110331
Patch by Dan Carney <dcarney@google.com> on 2013-02-20
Reviewed by Kentaro Hara.
No new tests. No change in functionality.
- bindings/v8/V8NPUtils.cpp:
(WebCore::convertNPVariantToV8Object):
- 7:30 AM Changeset in webkit [143463] by
-
- 27 edits2 adds in trunk
[Gtk] HTML5 Media controls require a design refresh
https://bugs.webkit.org/show_bug.cgi?id=83869
Source/WebCore:
Created new controls that depend less on Gtk and more in CSS.
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> and Martin Robinson <mrobinson@igalia.com> on 2013-02-20
Reviewed by Philippe Normand.
- GNUmakefile.list.am: Added compilation for MediaControlsGtk.cpp
and MediaControlsGtk.h
- css/mediaControlsGtk.css: Taken from Chromium and adapted for
WebKitGtk+.
- html/shadow/MediaControlsGtk.cpp: Added.
(WebCore): Added MediaControlsGtk class.
(WebCore::MediaControlsGtk::MediaControlsGtk): Class constructor
(WebCore::MediaControls::create): Creates the Gtk+ controls
components.
(WebCore::MediaControlsGtk::createControls): Creates the Gtk+
controls components.
(WebCore::MediaControlsGtk::initializeControls): Initializes all
media controls.
(WebCore::MediaControlsGtk::setMediaController): Sets the media
controller.
(WebCore::MediaControlsGtk::reset): Resets the controllers.
(WebCore::MediaControlsGtk::playbackStarted): Invoked when the
playback starts
(WebCore::MediaControlsGtk::updateCurrentTimeDisplay): Updates the
controls when the current time shall be updated.
(WebCore::MediaControlsGtk::changedMute): Updates the controls
then the mute changes.
(WebCore::MediaControlsGtk::showVolumeSlider): Invoked when the
volume slider is meant to be shown.
(WebCore::MediaControlsGtk::createTextTrackDisplay): Creates the
track display. Though it is not used by us, it needs to be created
to prevent immediate crashes when loading a video.
- html/shadow/MediaControlsGtk.h: Added.
(WebCore): Added the MediaControlsGtk class.
(MediaControlsGtk): Added the MediaControlsGtk class.
- platform/gtk/RenderThemeGtk.cpp:
(WebCore): Added getStockSymbolicIconForWidgetType function
signature to load symbolic icons.
(WebCore::supportsFocus): Added media control widgets to support
focus so that the focus ring is not painted by WebCore.
(WebCore::RenderThemeGtk::paintMediaButton): Added the symbolic
icon support. It supports now normal and symbolic icons at the
same time.
(WebCore::RenderThemeGtk::paintMediaFullscreenButton): Added the
symbolic icon support.
(WebCore::RenderThemeGtk::paintMediaMuteButton): Added the
symbolic icon support.
(WebCore::RenderThemeGtk::paintMediaPlayButton): Added the
symbolic icon support.
(WebCore::RenderThemeGtk::paintMediaSeekBackButton): Added the
symbolic icon support.
(WebCore::RenderThemeGtk::paintMediaSeekForwardButton): Added the
symbolic icon support.
(WebCore::borderRadiiFromStyle): Created the radii info from the
style.
(WebCore::RenderThemeGtk::paintMediaSliderTrack): Removed the
background and the Gtk widget support as it is painted with
CSS. Also paint the time ranges with the CSS style.
(WebCore::RenderThemeGtk::paintMediaSliderThumb): Paint slider
thumb according to the CSS parameters.
(WebCore::RenderThemeGtk::paintMediaVolumeSliderContainer):
Delegates in the CSS.
(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): Fills the
track up to the volume level and delegates the border in the CSS.
(WebCore::RenderThemeGtk::paintMediaVolumeSliderThumb): Delegates
in the paintMediaSliderThumb method so the thumb is painted the
same with the CSS parameters.
(WebCore::RenderThemeGtk::paintMediaCurrentTime): Removed the Gtk
background to use only CSS.
- platform/gtk/RenderThemeGtk.h:
(RenderThemeGtk): Changed paintMediaButton to support the symbolic
and normal icons at the same time.
- platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::adjustSliderThumbSize): Not adjusting
the thumb size and letting the CSS decide that for media slider.
(WebCore::getStockSymbolicIconForWidgetType): Implemented as a
fallback to the normal stock icons.
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore):
(WebCore::RenderThemeGtk::adjustSliderThumbSize): Not adjusting
the thumb size and letting the CSS decide that for the media
sliders.
(WebCore::getStockSymbolicIconForWidgetType): Added this function
to load symbolic icons. It falls back to normal icons if the
symbolic is not found.
Tools:
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-02-20
Reviewed by Philippe Normand.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeGtkFontSettings): Added gnome as default icon theme for
the DRT.
- WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::initializeGtkSettings): Added gnome as default icon theme for
the WTR.
- gtk/jhbuild.modules: Added gnome-icon-theme-symbolic as external
dependency.
LayoutTests:
Tests flagged and rebaselines.
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-02-20
Reviewed by Philippe Normand.
- platform/gtk/TestExpectations: Tests flagged and removed some
other flags.
- platform/gtk/accessibility/media-element-expected.txt: Rebaseline
- platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt: Rebaseline
- platform/gtk/fast/layers/video-layer-expected.png: Rebaseline
- platform/gtk/fast/layers/video-layer-expected.txt: Rebaseline
- platform/gtk/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Rebaseline
- platform/gtk/media/audio-repaint-expected.png: Rebaseline
- platform/gtk/media/audio-repaint-expected.txt: Rebaseline
- platform/gtk/media/controls-styling-strict-expected.png: Rebaseline
- platform/gtk/media/video-controls-rendering-expected.png: Rebaseline
- platform/gtk/media/video-empty-source-expected.txt: Rebaseline
- platform/gtk/media/video-no-audio-expected.txt: Rebaseline
- platform/gtk/media/video-volume-slider-expected.txt: Rebaseline
- platform/gtk/media/video-zoom-controls-expected.txt: Rebaseline
- platform/gtk/media/video-zoom-expected.png: Rebaseline
- 7:27 AM Changeset in webkit [143462] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Rename AncestorChainWalker.h to EventPathWalker.h in the project file.
Unreviewed gardening.
AncestorChainWalker has been renamed to EventPathWalker in r143422.
Rename the header in the project file as well so that it shows up in QtCreator.
No new tests needed.
- Target.pri:
- 7:24 AM Changeset in webkit [143461] by
-
- 6 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Read "data-blackberry-text-selection-handle-position" attribute from element
https://bugs.webkit.org/show_bug.cgi?id=110235
Patch by Yongxin Dai <yodai@rim.com> on 2013-02-20
Reviewed by Yong Li.
PR #257207.
Read "data-blackberry-text-selection-handle-position" attribute from element and pass it along
with notifySelectionDetailsChanged(). If "data-blackberry-text-selection-handle-position" attribute
is specified in the element, the selection handle is always flipped to the required position.
along with selected text within element.
Reviewed Internally by Mike Fenton.
- Api/WebPageClient.h:
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::selectionContainerElement):
(DOMSupport):
(BlackBerry::WebKit::DOMSupport::elementHandlePositionAttribute):
- WebKitSupport/DOMSupport.h:
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::requestedSelectionHandlePosition):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- WebKitSupport/SelectionHandler.h:
(SelectionHandler):
- 7:04 AM Changeset in webkit [143460] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fix usage of HitTestRequest::RequestType
https://bugs.webkit.org/show_bug.cgi?id=110342
Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-20
Reviewed by Carlos Garcia Campos.
Rename HitTestResult::* -> HitTestRequest::*
This was introduced by mistake in r142977.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::hitTestResult):
- 6:39 AM Changeset in webkit [143459] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 142594
Web Inspector: stack trace is cut at native bind if inspector is closed
https://bugs.webkit.org/show_bug.cgi?id=109427
Reviewed by Pavel Feldman.
Source/WebCore:
Only top frame is collected instead of full stack trace when inspector
front-end is closed to avoid expensive operations when exceptions are
thrown.
Test: http/tests/inspector-enabled/console-exception-while-no-inspector.html
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addMessageToConsole):
LayoutTests:
Test that stack trace for uncaught exceptions is collected when inspector
front-end is closed.
- http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added.
- http/tests/inspector-enabled/console-exception-while-no-inspector.html: Added.
- platform/chromium/http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added.
TBR=yurys@chromium.org
Review URL: https://codereview.chromium.org/12324011
- 6:24 AM Changeset in webkit [143458] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
- platform/efl/TestExpectations: Marked touch event emulation test as failing.
- 6:10 AM Changeset in webkit [143457] by
-
- 11 edits4 moves in trunk/Tools
[chromium] move most of the remaining mocks to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=110217
Reviewed by Nico Weber.
While most of the functionality provided by these mocks is also
available in the content module, there is no straight forward way to
inject the mock results required for layout tests.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestRunner):
(WebTestRunner::WebTestProxy::geolocationClient):
(WebTestRunner::WebTestProxy::speechInputController):
(WebTestRunner::WebTestProxy::speechRecognizer):
(WebTestRunner::WebTestProxy::deviceOrientationClient):
(WebTestRunner::WebTestProxy::requestPointerLock):
(WebTestRunner::WebTestProxy::requestPointerUnlock):
(WebTestRunner::WebTestProxy::isPointerLocked):
- DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp.
(WebTestRunner::MockWebSpeechInputController::MockWebSpeechInputController):
(WebTestRunner):
(WebTestRunner::MockWebSpeechInputController::~MockWebSpeechInputController):
(WebTestRunner::MockWebSpeechInputController::setDelegate):
(WebTestRunner::MockWebSpeechInputController::addMockRecognitionResult):
(WebTestRunner::MockWebSpeechInputController::setDumpRect):
(WebTestRunner::MockWebSpeechInputController::clearResults):
(WebTestRunner::MockWebSpeechInputController::startRecognition):
(WebTestRunner::MockWebSpeechInputController::cancelRecognition):
(WebTestRunner::MockWebSpeechInputController::stopRecording):
(WebTestRunner::MockWebSpeechInputController::speechTaskFired):
(WebTestRunner::MockWebSpeechInputController::SpeechTask::SpeechTask):
(WebTestRunner::MockWebSpeechInputController::SpeechTask::stop):
(WebTestRunner::MockWebSpeechInputController::SpeechTask::runIfValid):
- DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h.
(WebKit):
(WebTestRunner):
(MockWebSpeechInputController):
(WebTestRunner::MockWebSpeechInputController::taskList):
(SpeechTask):
- DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp.
(WebTestRunner::MockWebSpeechRecognizer::MockWebSpeechRecognizer):
(WebTestRunner):
(WebTestRunner::MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
(WebTestRunner::MockWebSpeechRecognizer::setDelegate):
(WebTestRunner::MockWebSpeechRecognizer::start):
(WebTestRunner::MockWebSpeechRecognizer::stop):
(WebTestRunner::MockWebSpeechRecognizer::abort):
(WebTestRunner::MockWebSpeechRecognizer::addMockResult):
(WebTestRunner::MockWebSpeechRecognizer::setError):
(WebTestRunner::MockWebSpeechRecognizer::startTaskQueue):
(WebTestRunner::MockWebSpeechRecognizer::clearTaskQueue):
(WebTestRunner::MockWebSpeechRecognizer::StepTask::runIfValid):
- DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h.
(WebKit):
(WebTestRunner):
(MockWebSpeechRecognizer):
(WebTestRunner::MockWebSpeechRecognizer::wasAborted):
(WebTestRunner::MockWebSpeechRecognizer::client):
(WebTestRunner::MockWebSpeechRecognizer::handle):
(WebTestRunner::MockWebSpeechRecognizer::taskList):
(Task):
(WebTestRunner::MockWebSpeechRecognizer::Task::Task):
(WebTestRunner::MockWebSpeechRecognizer::Task::~Task):
(StepTask):
(WebTestRunner::MockWebSpeechRecognizer::StepTask::StepTask):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::windowOpened):
(WebTestRunner):
(WebTestRunner::TestInterfaces::windowClosed):
(WebTestRunner::TestInterfaces::windowList):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::requestPointerLock):
(WebTestRunner):
(WebTestRunner::TestRunner::requestPointerUnlock):
(WebTestRunner::TestRunner::isPointerLocked):
(WebTestRunner::TestRunner::didAcquirePointerLockInternal):
(WebTestRunner::TestRunner::didNotAcquirePointerLockInternal):
(WebTestRunner::TestRunner::didLosePointerLockInternal):
(WebTestRunner::TestRunner::windowCount):
(WebTestRunner::TestRunner::setMockDeviceOrientation):
(WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
(WebTestRunner::TestRunner::setGeolocationPermission):
(WebTestRunner::TestRunner::setMockGeolocationPosition):
(WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
(WebTestRunner::TestRunner::addMockSpeechInputResult):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
(WebTestRunner::TestRunner::setMockSpeechRecognitionError):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::didAcquirePointerLock):
(WebTestRunner::TestRunner::didNotAcquirePointerLock):
(WebTestRunner::TestRunner::didLosePointerLock):
(WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner):
(TestRunner):
(HostMethodTask):
(WebTestRunner::TestRunner::HostMethodTask::HostMethodTask):
(WebTestRunner::TestRunner::HostMethodTask::runIfValid):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::setInterfaces):
(WebTestRunner::WebTestProxyBase::setDelegate):
(WebTestRunner::WebTestProxyBase::reset):
(WebTestRunner::WebTestProxyBase::captureTree):
(WebTestRunner::WebTestProxyBase::geolocationClientMock):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::deviceOrientationClientMock):
(WebTestRunner::WebTestProxyBase::speechInputControllerMock):
(WebTestRunner::WebTestProxyBase::speechRecognizerMock):
(WebTestRunner::WebTestProxyBase::geolocationClient):
(WebTestRunner::WebTestProxyBase::speechInputController):
(WebTestRunner::WebTestProxyBase::speechRecognizer):
(WebTestRunner::WebTestProxyBase::deviceOrientationClient):
(WebTestRunner::WebTestProxyBase::requestPointerLock):
(WebTestRunner::WebTestProxyBase::requestPointerUnlock):
(WebTestRunner::WebTestProxyBase::isPointerLocked):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::reset):
- DumpRenderTree/chromium/WebViewHost.h:
(WebKit):
(WebViewHost):
- 5:42 AM Changeset in webkit [143456] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed. Correcting gardening after r143436.
- platform/qt/TestExpectations:
- 5:40 AM Changeset in webkit [143455] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: fix for frontend closure compile errors.
https://bugs.webkit.org/show_bug.cgi?id=110329
Reviewed by Vsevolod Vlasov.
It has no tests because it has no code changes.
- inspector/front-end/HeapSnapshot.js:
(HeapSnapshotMetainfo):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked):
- 5:38 AM Changeset in webkit [143454] by
-
- 4 edits2 adds in trunk
Clear SVGPathSeg role on removal.
https://bugs.webkit.org/show_bug.cgi?id=110058
Reviewed by Dirk Schulze.
Source/WebCore:
SVGPathSegListPropertyTearOff::initialize() and SVGPathSegListPropertyTearOff::replaceItem()
need to clear the context and role for segments being expunged from the list, similarly to
removeItem(). Otherwise, processIncomingListItemValue() can get confused and attempt to
remove stale segments.
Test: svg/dom/SVGPathSegList-crash.html
- svg/properties/SVGPathSegListPropertyTearOff.cpp:
(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):
(WebCore::SVGPathSegListPropertyTearOff::clear):
(WebCore::SVGPathSegListPropertyTearOff::replaceItem):
(WebCore):
- svg/properties/SVGPathSegListPropertyTearOff.h:
(WebCore::SVGPathSegListPropertyTearOff::initialize):
(SVGPathSegListPropertyTearOff):
LayoutTests:
- svg/dom/SVGPathSegList-crash-expected.txt: Added.
- svg/dom/SVGPathSegList-crash.html: Added.
- 4:45 AM Changeset in webkit [143453] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r143434.
http://trac.webkit.org/changeset/143434
https://bugs.webkit.org/show_bug.cgi?id=110326
added reftest fails on chromium mac 10.6 (Requested by
toyoshim on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-20
Source/WebCore:
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
LayoutTests:
- fast/forms/file/file-vertical-padding-border-expected.html: Removed.
- fast/forms/file/file-vertical-padding-border.html: Removed.
- 4:36 AM Changeset in webkit [143452] by
-
- 2 edits in trunk/Tools
[Qt] Make debug builds possible on 32bit Linux
https://bugs.webkit.org/show_bug.cgi?id=110231
Reviewed by Tor Arne Vestbø.
Use the stabs format for debug builds to make the object files
a bit smaller so that they can be linked on a 32bit system.
- qmake/mkspecs/features/unix/default_post.prf:
- 4:33 AM Changeset in webkit [143451] by
-
- 7 edits in trunk
Web Inspector: Make UISourceCode.path() an array of path segments.
https://bugs.webkit.org/show_bug.cgi?id=110229
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate.prototype._filePathForPath):
(WebInspector.FileSystemProjectDelegate.prototype.innerCallback):
(WebInspector.FileSystemProjectDelegate.prototype.requestFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._contentTypeForPath):
(WebInspector.FileSystemProjectDelegate.prototype.populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate.prototype.requestFileContent):
(WebInspector.SimpleProjectDelegate.prototype.searchInFileContent):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleProjectDelegate.prototype._ensureUniquePath):
(WebInspector.SimpleProjectDelegate.prototype.removeFile):
(WebInspector.SimpleWorkspaceProvider.pathForSplittedURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFileByName):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.uri):
- inspector/front-end/Workspace.js:
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.uiSourceCode):
(WebInspector.Workspace.prototype.uiSourceCodeForURL):
(WebInspector.Workspace.prototype.urlForPath):
LayoutTests:
- inspector/workspace-mapping.html:
- 4:17 AM Changeset in webkit [143450] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update expectation for chromium gardening.
https://bugs.webkit.org/show_bug.cgi?id=110324
- platform/chromium/TestExpectations:
- 4:15 AM Changeset in webkit [143449] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: fix message for non-existent domain warning
https://bugs.webkit.org/show_bug.cgi?id=110315
Reviewed by Alexander Pavlov.
Only send (Heap)Profiler.resetProfiles event if the client has
requested profile headers before.
- inspector/InspectorHeapProfilerAgent.cpp:
(HeapProfilerAgentState):
(WebCore):
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorHeapProfilerAgent::clearFrontend):
(WebCore::InspectorHeapProfilerAgent::restore):
(WebCore::InspectorHeapProfilerAgent::getProfileHeaders):
- inspector/InspectorHeapProfilerAgent.h:
(InspectorHeapProfilerAgent):
- inspector/InspectorProfilerAgent.cpp:
(ProfilerAgentState):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::addProfile):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorProfilerAgent::restore):
- inspector/InspectorProfilerAgent.h:
(InspectorProfilerAgent):
- 4:06 AM Changeset in webkit [143448] by
-
- 25 edits2 adds in trunk
Web Inspector: Move workspace specific code from FileMapping to workspace.
https://bugs.webkit.org/show_bug.cgi?id=110219
Reviewed by Pavel Feldman.
Source/WebCore:
Extracted workspace specific code from FileMapping to Workspace.
This allows to reduce usage of uri and eventually make UISourceCode.path an array of path segments.
Test: inspector/workspace-mapping.html
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.rawLocationToUILocation):
- inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.get addScript.get this):
(WebInspector.CompilerScriptMapping.prototype.get addScript):
- inspector/front-end/FileMapping.js:
(WebInspector.FileMapping):
(WebInspector.FileMapping.prototype.mappingEntryForURL):
(WebInspector.FileMapping.prototype.mappingEntryForPath):
- inspector/front-end/FileSystemMapping.js:
(WebInspector.FileSystemMapping.prototype.fileSystemPathForPrefix):
(WebInspector.FileSystemMappingImpl.prototype.addFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.removeFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPathForPrefix):
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype.populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):
(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):
- inspector/front-end/IsolatedFileSystemManager.js:
(WebInspector.IsolatedFileSystemManager):
- inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._addFile):
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._workspaceUISourceCodeForScript):
- inspector/front-end/ResourceUtils.js:
(WebInspector.displayNameForURL):
- inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping.prototype._reloadCSS):
(WebInspector.SASSSourceMapping.prototype._bindUISourceCode):
(WebInspector.SASSSourceMapping.prototype.rawLocationToUILocation):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleWorkspaceProvider.pathForSplittedURL):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
- inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.StylesSourceMapping.prototype._resourceAdded):
(WebInspector.StylesSourceMapping.prototype._mainFrameCreatedOrNavigated):
(WebInspector.StyleContentBinding):
(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):
- inspector/front-end/Workspace.js:
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.hasMappingForURL):
(WebInspector.Workspace.prototype._fileSystemPathForEntry):
(WebInspector.Workspace.prototype.uiSourceCodeForURL):
(WebInspector.Workspace.prototype.urlForPath):
- inspector/front-end/inspector.js:
LayoutTests:
- http/tests/inspector/compiler-script-mapping.html:
- http/tests/inspector/workspace-test.js:
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
- inspector/debugger/network-uisourcecode-provider.html:
- inspector/file-mapping-expected.txt:
- inspector/file-mapping.html:
- inspector/file-system-mapping-expected.txt:
- inspector/file-system-mapping.html:
- inspector/file-system-project.html:
- inspector/workspace-mapping-expected.txt: Added.
- inspector/workspace-mapping.html: Added.
- 3:48 AM Changeset in webkit [143447] by
-
- 3 edits in trunk/Tools
Unreviewed. Add myself to watch lists.
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/watchlist:
- 3:25 AM Changeset in webkit [143446] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Unreviewed BlackBerry build fix.
WebPage::download was renamed in the header by mistake to
convertMainResourceLoadToDownload in r137845.
- Api/WebPage.h:
- 3:18 AM Changeset in webkit [143445] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- 3:08 AM Changeset in webkit [143444] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Port EwkPopupMenuItem to the C API
https://bugs.webkit.org/show_bug.cgi?id=108798
Reviewed by Kenneth Rohde Christiansen.
Make use of the new WKPopupItem C API inside EwkPopupMenuItem to remove
dependency on internal WebPopupItem type. Eina shared string members
are now lazily initialized to make the object cheaper to construct.
- UIProcess/API/efl/ewk_popup_menu.cpp:
(EwkPopupMenu::EwkPopupMenu):
- UIProcess/API/efl/ewk_popup_menu_item.cpp:
(EwkPopupMenuItem::EwkPopupMenuItem):
(EwkPopupMenuItem::type):
(EwkPopupMenuItem::textDirection):
(EwkPopupMenuItem::text):
(EwkPopupMenuItem::tooltipText):
(EwkPopupMenuItem::accessibilityText):
(EwkPopupMenuItem::hasTextDirectionOverride):
(EwkPopupMenuItem::isEnabled):
(EwkPopupMenuItem::isLabel):
(EwkPopupMenuItem::isSelected):
- UIProcess/API/efl/ewk_popup_menu_item_private.h:
(EwkPopupMenuItem::create):
(EwkPopupMenuItem):
- 3:01 AM Changeset in webkit [143443] by
-
- 5 edits in trunk
Web Inspector: Introduce SecurityOriginAdded and SecurityOriginRemoved events into ResourceTreeModel
https://bugs.webkit.org/show_bug.cgi?id=110232
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._addSecurityOrigin): Added.
(WebInspector.ResourceTreeModel.prototype._removeSecurityOrigin): Added.
(WebInspector.ResourceTreeModel.prototype._handleMainFrameDetached): Added.
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
LayoutTests:
- http/tests/inspector/resource-tree/resource-tree-events-expected.txt:
- http/tests/inspector/resource-tree/resource-tree-events.html:
- 2:01 AM Changeset in webkit [143442] by
-
- 3 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
- platform/efl/TestExpectations: Marked new failing ref test svg/as-background-image/tiled-background-image.html.
- platform/efl/fast/js/global-constructors-expected.txt: Rebaselined, MutationObserver constructor now found.
- 1:58 AM Changeset in webkit [143441] by
-
- 6 edits in trunk/Source/WebCore
[v8] ScriptValue has dangerous copy semantics
https://bugs.webkit.org/show_bug.cgi?id=110206
Patch by Dan Carney <dcarney@google.com> on 2013-02-20
Reviewed by Kentaro Hara.
Update ScriptValue to used a SharedPersistent,
making it impossible to return dead references.
No new tests. No change in functionality.
- bindings/v8/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):
(WebCore::ScriptValue::toInspectorValue):
- bindings/v8/ScriptValue.h:
(WebCore::ScriptValue::ScriptValue):
(WebCore::ScriptValue::operator=):
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::isEqual):
(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):
(WebCore::ScriptValue::clear):
(ScriptValue):
(WebCore::ScriptValue::v8Value):
(WebCore::ScriptValue::v8ValueRaw):
- bindings/v8/SharedPersistent.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::scriptValueAsNode):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAttrGetterCustom):
- 1:44 AM Changeset in webkit [143440] by
-
- 7 edits in trunk
Web Inspector: highlight undefined word in JavaScript
https://bugs.webkit.org/show_bug.cgi?id=109585
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-20
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test enhancement: inspector/syntax-highlight-javascript.html
Add global object value properties to tokenizer and add a css style
class to highlight "undefined" with gray color.
- inspector/front-end/SourceJavaScriptTokenizer.js:
(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
- inspector/front-end/SourceJavaScriptTokenizer.re2js:
- inspector/front-end/inspectorSyntaxHighlight.css:
(.webkit-javascript-undef):
LayoutTests:
Enhance layout test to verify highlighting of global object value properties.
- inspector/syntax-highlight-javascript-expected.txt:
- inspector/syntax-highlight-javascript.html:
- 1:43 AM Changeset in webkit [143439] by
-
- 8 edits in trunk
Use EventPathWalker rather than parentNode() to normalize event targets in EventHandler.
https://bugs.webkit.org/show_bug.cgi?id=110037
Reviewed by Ryosuke Niwa.
Source/WebCore:
We need to teach EventHandler about Shadow DOM in a few places in order
to ensure that we properly target events dispatched upon text nodes.
Rather than naively grabbing the text node's direct parent via
parentNode(), we need to account for the case in which the text node is
distributed[1] to an insertion point inside a shadow host.
EventPathWalker::parent understands these relationships, and should
be used when dealing with mouse, drag, and touch events.
[1]: http://www.w3.org/TR/shadow-dom/#dfn-distribution
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::passGestureEventToWidgetIfPossible):
(WebCore::EventHandler::updateDragAndDrop):
Refactor parentNode callsites to use EventPathWalker::parent().
LayoutTests:
- fast/dom/shadow/resources/event-dispatching.js:
(scrollMouseWheel):
(addEventListeners):
Add MouseWheel, Drag, and Touch support to the event-dispatching
tests in Shadow DOM.
- fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node.html:
- fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root.html:
Scroll the mouse wheel, drag a bit, and touch before leaving the
text node, and record the generated events.
- 1:24 AM Changeset in webkit [143438] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Regression] Search in ProfilesPanel is broken
https://bugs.webkit.org/show_bug.cgi?id=110312
Reviewed by Pavel Feldman.
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.prototype.matchesQuery):
(WebInspector.CPUProfileView.prototype.performSearch):
- 1:21 AM Changeset in webkit [143437] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: View.markAsRoot should never be invoked on attached view.
https://bugs.webkit.org/show_bug.cgi?id=110224
Reviewed by Pavel Feldman.
This will cause CSS loading problems after "show".
- inspector/front-end/Drawer.js:
Ensure child view is detached before marked as root.
- inspector/front-end/View.js:
(WebInspector.View.prototype.markAsRoot): Added assertion.
- 1:17 AM Changeset in webkit [143436] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/TestExpectations:
- platform/qt/fast/js/global-constructors-expected.txt: Rebaseline after r143420.
- 1:06 AM Changeset in webkit [143435] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardenning. Unskip now passing tests.
https://bugs.webkit.org/show_bug.cgi?id=99306
- platform/qt-5.0-wk2/TestExpectations:
- 12:10 AM Changeset in webkit [143434] by
-
- 3 edits2 adds in trunk
File upload control doesn't apply CSS vertical padding or border to file name
https://bugs.webkit.org/show_bug.cgi?id=109011
Patch by Nils Barth <nbarth@google.com> on 2013-02-20
Reviewed by Hajime Morrita.
Source/WebCore:
Test: fast/forms/file/file-vertical-padding-border.html
- rendering/RenderFileUploadControl.cpp:
Add borderTop() and paddingTop() when computing position.
(WebCore::RenderFileUploadControl::paintObject):
LayoutTests:
- fast/forms/file/file-vertical-padding-border.html: Added.
- fast/forms/file/file-vertical-padding-border-expected.html: Added.
Feb 19, 2013:
- 11:42 PM Changeset in webkit [143433] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark fast/regions/seamless-iframe-flowed-into-regions.html failure
https://bugs.webkit.org/show_bug.cgi?id=110283
Unreviewed. This test is added by r143256 and it is failing.
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-19
- platform/efl/TestExpectations:
- 10:54 PM Changeset in webkit [143432] by
-
- 2 edits in trunk/Source/WebCore
Few methods in WebGLRenderingContext.idl have incorrect signatures
https://bugs.webkit.org/show_bug.cgi?id=110305
Reviewed by Kentaro Hara.
- html/canvas/WebGLRenderingContext.idl:
- 10:14 PM Changeset in webkit [143431] by
-
- 4 edits16 adds1 delete in trunk/LayoutTests
Unreviewed, rolling out r143393.
http://trac.webkit.org/changeset/143393
https://bugs.webkit.org/show_bug.cgi?id=110302
the converted reftest fails in chromium mac 10.6 and 10.7
(Requested by toyoshim on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19
- fast/flexbox/box-orient-button.html:
- fast/flexbox/resources/box-orient-button.js:
- fast/invalid/residual-style-expected.html: Removed.
- fast/invalid/residual-style.html:
- platform/chromium-android/fast/invalid/residual-style-expected.png: Added.
- platform/chromium-android/fast/invalid/residual-style-expected.txt: Added.
- platform/chromium-linux/fast/invalid/residual-style-expected.png: Added.
- platform/chromium-linux/fast/invalid/residual-style-expected.txt: Added.
- platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Added.
- platform/chromium-mac/fast/invalid/residual-style-expected.png: Added.
- platform/chromium-mac/fast/invalid/residual-style-expected.txt: Added.
- platform/chromium-win/fast/invalid/residual-style-expected.png: Added.
- platform/chromium-win/fast/invalid/residual-style-expected.txt: Added.
- platform/efl/fast/invalid/residual-style-expected.png: Added.
- platform/efl/fast/invalid/residual-style-expected.txt: Added.
- platform/gtk/fast/invalid/residual-style-expected.png: Added.
- platform/gtk/fast/invalid/residual-style-expected.txt: Added.
- platform/mac/fast/invalid/residual-style-expected.png: Added.
- platform/mac/fast/invalid/residual-style-expected.txt: Added.
- 10:02 PM Changeset in webkit [143430] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, uninteresting change to test a theory about bad dependency handling.
- API/JSStringRefCF.cpp:
(JSStringCreateWithCFString): Remove an unnecessary else clause.
- 9:57 PM Changeset in webkit [143429] by
-
- 2 edits in trunk/Source/WebKit/win
Unreviewed, rolling out r143338.
http://trac.webkit.org/changeset/143338
https://bugs.webkit.org/show_bug.cgi?id=110301
False alarm, no need to export the symbol (Requested by
aandrey on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19
- WebKit.vcproj/WebKitExports.def.in:
- 9:53 PM Changeset in webkit [143428] by
-
- 15 edits in trunk/Source
Clarify isInWindow vs. isVisible path through to RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=110261
<rdar://problem/13196122>
Reviewed by Simon Fraser.
Remove RenderLayerCompositor::willMoveOffscreen/didMoveOnscreen.
Add RenderLayerCompositor::setIsInWindow, and pipe in-window changes through from Page::setIsInWindow.
Adjust a few Document functions that previously called RenderView::didMoveOnscreen/willMoveOffscreen to use setIsInWindow instead, since in-win$
- WebCore.exp.in: Export Page::setIsInWindow.
- dom/Document.cpp:
(WebCore::Document::attach): Use setIsInWindow instead of didMoveOnscreen.
(WebCore::Document::documentWillBecomeInactive): Use setIsInWindow instead of willMoveOffscreen.
(WebCore::Document::documentDidResumeFromPageCache): Use setIsInWindow instead of didMoveOnscreen.
- page/FrameView.cpp:
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
RenderView doesn't care about moving on/offscreen, just in-window state.
(WebCore::FrameView::setIsInWindow): Added. Forward isInWindow changes to our RenderView.
- page/FrameView.h:
(FrameView): Add setIsInWindow.
- page/Page.cpp:
(WebCore::Page::setIsInWindow): Added. Forward isInWindow changes to the Page's FrameViews.
- page/Page.h:
(Page): Add setIsInWindow.
(WebCore::Page::isInWindow):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::setIsInWindow): Added. Replace willMoveOffscreen/didMoveOnscreen with setIsInWindow,
since that's the only change we actually care about.
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor): Add setIsInWindow.
- rendering/RenderView.cpp:
(WebCore::RenderView::setIsInWindow): Added. Replace willMoveOffscreen/didMoveOnscreen with setIsInWindow,
since that's the only change RenderLayerCompositor actually cares about.
- rendering/RenderView.h:
(RenderView): Add setIsInWindow.
- WebView/WebView.mm:
(-[WebView viewWillMoveToWindow:]):
(-[WebView viewDidMoveToWindow]):
Use Page::setIsInWindow in addition to willMoveOffscreen/didMoveOnscreen.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setIsInWindow):
Use Page::setIsInWindow in addition to willMoveOffscreen/didMoveOnscreen.
- 9:24 PM Changeset in webkit [143427] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Cleanup and add JSDocs to SuggestBox
https://bugs.webkit.org/show_bug.cgi?id=110202
Reviewed by Pavel Feldman.
SuggestBox contains some obsolete/unused code and not fully
covered with JSDocs.
- inspector/front-end/SuggestBox.js:
(WebInspector.SuggestBox.prototype.visible):
Replaced getter with function.
(WebInspector.SuggestBox.prototype._onScrollOrResize):
Use camel-case for function names.
(WebInspector.SuggestBox.prototype._onBoxMouseDown): Ditto.
(WebInspector.SuggestBox.prototype.updateSuggestions):
Removed unused code.
(WebInspector.SuggestBox.prototype.hide): Adopt changes.
(WebInspector.SuggestBox.prototype._applySuggestion): Ditto.
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.isSuggestBoxVisible): Ditto.
- 7:05 PM Changeset in webkit [143426] by
-
- 5 edits in trunk/Source/WebCore
Calculate EventPath in EventDispatcher's constructor.
https://bugs.webkit.org/show_bug.cgi?id=109905
Reviewed by Dimitri Glazkov.
This patch calculates an EventPath in EventDispatcher's
constructor and removes EventDispatcher::ensureEventPath().
We don't have any reason to initialize an EventPath lazily.
No tests. No change in behavior.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatch):
- dom/EventDispatcher.h:
(WebCore::EventDispatcher::eventPath):
(EventDispatcher):
- dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
- 6:49 PM Changeset in webkit [143425] by
-
- 2 edits in trunk/Tools
Remove warning from run-bindings-tests
https://bugs.webkit.org/show_bug.cgi?id=110285
Reviewed by Kentaro Hara.
Since wkrev.com/139331 run-bindings-tests has been harmlessly emitting
"Unknown option: idlattributesfile". That option was removed from
bindings/scripts/preprocess-idls.pl but was still being passed by
the test script. Remove it.
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_supplemental_dependency): Remove unused arg.
- 6:46 PM Changeset in webkit [143424] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r143400.
http://trac.webkit.org/changeset/143400
https://bugs.webkit.org/show_bug.cgi?id=110290
breaks everything (instacrash launching Safari) (Requested by
thorton on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19
- wtf/FastMalloc.cpp:
(WTF::internalEntropyValue):
(WTF):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Allocate):
(WTF::TCMalloc_ThreadCache::Deallocate):
- 6:28 PM Changeset in webkit [143423] by
-
- 3 edits2 adds in trunk
Fix TileCache tile size when zoomed on slow-scrolling site
https://bugs.webkit.org/show_bug.cgi?id=110289
Source/WebCore:
Reviewed by Tim Horton.
In slow scrolling mode, we use the tile coverage rect as the tile size
(so a single tile covers the viewport). When zoomed, the tile coverage rect
shrinks relative to the TileCache, so scale the tile size back up.
Test: platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed.html
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::tileSizeForCoverageRect):
LayoutTests:
Reviewed by Tim Horton.
Test that dumps tile coverage in a slow-scrolling, zoomed page.
- platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed.html: Added.
- 6:27 PM Changeset in webkit [143422] by
-
- 12 edits2 moves in trunk/Source/WebCore
Rename AncestorChainWalker.
https://bugs.webkit.org/show_bug.cgi?id=110146
Reviewed by Dimitri Glazkov.
Rename AncestorChainWalker to EventPathWalker.
The term of EventPath is used in DOM Core spec. EventPath was
already introduced into a EventContext.h in r112055. We should
spread this term into the Walker class since they share the same
purpose.
No new tests, no behavior change.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/EventDispatcher.cpp:
- dom/EventPathWalker.cpp: Renamed from Source/WebCore/dom/AncestorChainWalker.cpp.
(WebCore):
(WebCore::EventPathWalker::EventPathWalker):
(WebCore::EventPathWalker::parent): parent() is now a static function to cover simple use cases.
(WebCore::EventPathWalker::moveToParent): Renamed from parent().
- dom/EventPathWalker.h: Renamed from Source/WebCore/dom/AncestorChainWalker.h.
(WebCore):
(EventPathWalker):
(WebCore::EventPathWalker::node):
(WebCore::EventPathWalker::isVisitingInsertionPointInReprojection): Renamed from isCrossingInsertionPoint().
- dom/EventRetargeter.cpp:
(WebCore::EventRetargeter::calculateEventPath):
(WebCore::EventRetargeter::buildRelatedNodeMap):
- dom/TreeScope.cpp:
(WebCore::TreeScope::focusedNode):
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::attach):
- page/EventHandler.cpp:
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::handleWheelEvent):
- 5:59 PM Changeset in webkit [143421] by
-
- 2 edits in trunk/Source/WebCore
Snapshotted plugin label should not be selectable
https://bugs.webkit.org/show_bug.cgi?id=110286
Reviewed by Simon Fraser.
Update the CSS to make it clear that you should click
on a snapshot (use the finger pointer) and disable
text selection.
- css/plugIns.css:
(embed::-webkit-snapshotted-plugin-content .snapshot-container .snapshot-label):
- 5:56 PM Changeset in webkit [143420] by
-
- 3 edits2 adds in trunk
[CSS Exclusions] Enable shape-inside support for ellipses
https://bugs.webkit.org/show_bug.cgi?id=109868
Reviewed by Dirk Schulze.
Source/WebCore:
This change is very similar to the one recently made for circles:
removed the test that disabled ellipse values for shape-inside.
The remaining support for ellipses, which is based on rounded rectangles
whose width/height is equal to their radiusX/radiusY, has not changed.
Test: fast/exclusions/shape-inside/shape-inside-ellipse.html
- rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): No longer disallows any BasicShape type.
LayoutTests:
Added a test for ellipse shape-inside values.
- fast/exclusions/shape-inside/shape-inside-ellipse-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-ellipse.html: Added.
- 5:46 PM Changeset in webkit [143419] by
-
- 13 edits5 adds in trunk
'round' not implemented in border-image
https://bugs.webkit.org/show_bug.cgi?id=14185
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-02-19
Reviewed by David Hyatt.
Source/WebCore:
Add rendering support for 'round' keyword of border-image-repeat CSS property
http://dev.w3.org/csswg/css3-background/#border-image-repeat
Rebased original patch by Benjamin Otte <otte@gnome.org> and made few fixes.
Test: fast/borders/border-image-02.html
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h:
(GraphicsContext):
- platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
- platform/graphics/Image.h:
(Image):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintNinePieceImage): For 'round' keyword,
the image is tiled (repeated) to fill the area. If it does not fill the area
with a whole number of tiles, the image is rescaled so that it does.
LayoutTests:
Added test for 'round' keyword of border-image-repeat CSS property
http://dev.w3.org/csswg/css3-background/#border-image-repeat
- fast/borders/border-image-02.html: Added.
- platform/chromium-linux/fast/borders/border-image-02-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/fast/borders/border-image-02-expected.txt: Added.
- platform/efl/TestExpectations:
- platform/gtk/fast/borders/border-image-02-expected.png: Added.
- platform/gtk/fast/borders/border-image-02-expected.txt: Added.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 5:42 PM Changeset in webkit [143418] by
-
- 18 edits in trunk/Source
Allow UI clients to handle vertical wheel events.
https://bugs.webkit.org/show_bug.cgi?id=110006
Patch by Conrad Shultz <Conrad Shultz> on 2013-02-19
Reviewed by Tim Horton.
Source/WebCore:
Add API to allow matching changes in WebKit2 to control rubber-banding behavior at vertical page extrema.
If rubber-banding is disabled during a scroll event that would otherwise trigger rubber-banding, dispatch
didNotHandleWheelEvent() to the page UI client.
- WebCore.exp.in:
Export new rubber-banding API.
- page/Page.cpp:
(WebCore):
(WebCore::Page::rubberBandsAtBottom):
Proxy for the corresponding function in ScrollingCoordinator.
(WebCore::Page::setRubberBandsAtBottom):
Ditto.
(WebCore::Page::rubberBandsAtTop):
Ditto.
(WebCore::Page::setRubberBandsAtTop):
Ditto.
- page/Page.h:
(Page):
Declare new rubber-banding API (above).
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::rubberBandsAtBottom):
Stub API implementation.
(WebCore::ScrollingCoordinator::setRubberBandsAtBottom):
Ditto.
(WebCore::ScrollingCoordinator::rubberBandsAtTop):
Ditto.
(WebCore::ScrollingCoordinator::setRubberBandsAtTop):
Ditto.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
Initialize new member variables.
(WebCore::ScrollingTree::setMainFramePinState):
Set top/bottom pinned states.
(WebCore::ScrollingTree::rubberBandsAtBottom):
New accessor function.
(WebCore::ScrollingTree::setRubberBandsAtBottom):
New mutator function.
(WebCore::ScrollingTree::rubberBandsAtTop):
New accessor function.
(WebCore::ScrollingTree::setRubberBandsAtTop):
New mutator function.
(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):
Start a vertical swipe event if the frame is pinned at the top or bottom and associated rubber-banding is disabled.
- page/scrolling/ScrollingTree.h:
(ScrollingTree):
Declare new rubber-banding API and associated member variables.
- page/scrolling/mac/ScrollingCoordinatorMac.h:
(ScrollingCoordinatorMac):
Declare API overrides.
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::rubberBandsAtBottom):
Method override; proxy to corresponding function in ScrollingTree.
(WebCore::ScrollingCoordinatorMac::setRubberBandsAtBottom):
Ditto.
(WebCore::ScrollingCoordinatorMac::rubberBandsAtTop):
Ditto.
(WebCore::ScrollingCoordinatorMac::setRubberBandsAtTop):
Ditto.
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::pinnedInDirection):
Remove trailing whitespace.
(WebCore::ScrollingTreeScrollingNodeMac::updateMainFramePinState):
Calculate and pass vertical pinning state to ScrollingTree::setMainFramePinState().
Source/WebKit2:
Add API to allow clients to selectively control rubber-banding at vertical page extrema.
- UIProcess/API/C/WKPage.cpp:
(WKPageRubberBandsAtBottom):
Proxy for the corresponding function in WebCore::Page.
(WKPageSetRubberBandsAtBottom):
Ditto.
(WKPageRubberBandsAtTop):
Ditto.
(WKPageSetRubberBandsAtTop):
Ditto.
- UIProcess/API/C/WKPage.h:
Declare new API.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Initialize new member variables.
(WebKit::WebPageProxy::setRubberBandsAtBottom):
New function; dispatches a matching message to the WebKit::WebPage.
(WebKit::WebPageProxy::setRubberBandsAtTop):
Ditto.
- UIProcess/WebPageProxy.h:
(WebPageProxy):
Declare new API.
(WebKit::WebPageProxy::rubberBandsAtBottom):
New accessor function.
(WebKit::WebPageProxy::rubberBandsAtTop):
Ditto.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setRubberBandsAtBottom):
New function; call the matching function on the associated WebCore::Page.
(WebKit::WebPage::setRubberBandsAtTop):
Ditto.
- WebProcess/WebPage/WebPage.h:
(WebPage):
Declare new rubber-banding API.
- WebProcess/WebPage/WebPage.messages.in:
Declare new rubber-banding API.
- 5:29 PM Changeset in webkit [143417] by
-
- 5 edits in trunk/Source/WebCore
Rubber-banding should not affect the visibleRect of the TileCache
https://bugs.webkit.org/show_bug.cgi?id=110278
Reviewed by Beth Dakin.
When rubber-banding a slow-scrolling page, or image document, we would constantly re-create
the bottom tile because of the logic that adapts the tile size to the visible rect when slow
scrolling.
Avoid that by ensuring that the visibleRect is not affected by rubber-banding. This is done
via a GraphicsLayerClient function that allows RenderLayerCompositor to provide a custom
position for the scroll layer. We constrain that scroll position to remove the overhang that
results from rubber-banding.
I wasn't able to make a test for this, even with internals.setScrollViewPosition().
- platform/graphics/GraphicsLayerClient.h:
(GraphicsLayerClient):
(WebCore::GraphicsLayerClient::customPositionForVisibleRectComputation):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::computeVisibleRect):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::customPositionForVisibleRectComputation):
- rendering/RenderLayerCompositor.h:
- 5:24 PM Changeset in webkit [143416] by
-
- 2 edits in trunk/Source/WebKit/win
Unreviewed, force file to recompile to fix win build.
- WebView.cpp:
- 5:20 PM Changeset in webkit [143415] by
-
- 8 edits in trunk/Source/WebCore
Fix crash in preloading scanning base tags with no href attribute for background parser
https://bugs.webkit.org/show_bug.cgi?id=110276
Reviewed by Eric Seidel.
Previously a <base> tag without an href attribute (like the one in fast/dom/HTMLAnchorElement/set-href-attribute-rebase.html)
would crash the background parser's preload scanner.
To fix that, we only call stripLeadingAndTrailingHTMLSpaces() if the href attribute is non-null. This matches the main thread parser.
Along with this, I decided to templatize updatePredictedBaseURL() so that the main and background parser can share the same impl.
This required making CompactHTMLToken and HTMLToken a little more similar:
- Give HTMLToken a getAttributeItem() method.
- Move CompactAttribute to CompactHTMLToken::Attribute and make it a struct.
No new tests because covered by existing tests.
- html/parser/AtomicHTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
- html/parser/CompactHTMLToken.cpp:
(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::CompactHTMLToken):
(WebCore::CompactHTMLToken::getAttributeItem):
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread):
- html/parser/CompactHTMLToken.h:
(WebCore::CompactHTMLToken::Attribute::Attribute):
(Attribute):
(WebCore::CompactHTMLToken::attributes):
(CompactHTMLToken):
(WebCore::CompactHTMLToken::publicIdentifier):
(WebCore::CompactHTMLToken::systemIdentifier):
- html/parser/HTMLParserIdioms.h:
(WebCore):
(WebCore::stripLeadingAndTrailingHTMLSpaces):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore):
(WebCore::TokenPreloadScanner::updatePredictedBaseURL):
- html/parser/HTMLPreloadScanner.h:
- html/parser/HTMLToken.h:
(WebCore::HTMLToken::getAttributeItem):
(HTMLToken):
- 5:18 PM Changeset in webkit [143414] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, include exports for VS2010 as well.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 4:55 PM Changeset in webkit [143413] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp
Merge 142890
IndexedDB: Add a few more histogram calls
https://bugs.webkit.org/show_bug.cgi?id=109762
Reviewed by Tony Chang.
A few places where commits could fail weren't being logged.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::deleteDatabase):
(WebCore::IDBBackingStore::Transaction::commit):
TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/12288067
- 4:48 PM Changeset in webkit [143412] by
-
- 6 edits2 adds in trunk/Source/WebCore
Introducing AbstractSQLTransaction and AbstractSQLTransactionBackend.
https://bugs.webkit.org/show_bug.cgi?id=110273.
Reviewed by Anders Carlsson.
This is part of the webdatabase refactoring for webkit2.
- Also changed the frontend and backend to only refer to the abstract interface of each other.
No new tests.
- Modules/webdatabase/AbstractSQLTransaction.h: Added.
(AbstractSQLTransaction):
(WebCore::AbstractSQLTransaction::~AbstractSQLTransaction):
- Modules/webdatabase/AbstractSQLTransactionBackend.h: Added.
(AbstractSQLTransactionBackend):
(WebCore::AbstractSQLTransactionBackend::~AbstractSQLTransactionBackend):
- Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::hasCallback):
(WebCore::SQLTransaction::hasSuccessCallback):
(WebCore::SQLTransaction::hasErrorCallback):
(WebCore::SQLTransaction::setBackend):
- Modules/webdatabase/SQLTransaction.h:
(SQLTransaction):
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
- Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionBackend):
- Modules/webdatabase/SQLTransactionStateMachine.h:
- 4:47 PM Changeset in webkit [143411] by
-
- 2 edits in trunk/Source/JavaScriptCore
Silence some analyzer warnings
https://bugs.webkit.org/show_bug.cgi?id=110281
Reviewed by Mark Hahnenberg.
The static analyzer believes that callerCodeBlock can be null,
based on other code performing null tests. This should not
ever be the case, but we'll add RELEASE_ASSERTs to make it
obvious if we're ever wrong.
- interpreter/Interpreter.cpp:
(JSC::getCallerInfo):
- 4:47 PM ExportingSymbols edited by
- Updated path to win exports file. (diff)
- 4:45 PM Changeset in webkit [143410] by
-
- 4 edits in trunk/Source/WebCore
Change computeStickyPositionConstraints to use LayoutBoxExtent for margins
https://bugs.webkit.org/show_bug.cgi?id=108872
Reviewed by Levi Weintraub.
Change RenderBoxModelObject::computeStickyPositionConstraints to
use a LayoutBoxExtent to represent margins.
No new tests, no change in functionality.
- platform/graphics/LayoutRect.h:
(WebCore::LayoutRect::contract):
Add version contract methods that takes a LayoutBoxExtent object.
- platform/graphics/LayoutSize.h:
(WebCore::LayoutSize::shrink):
Add shrink method.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computeStickyPositionConstraints):
Change to use a LayoutBoxExtent object to represent margins.
- 4:45 PM NewRunWebKitTests edited by
- (diff)
- 4:45 PM Changeset in webkit [143409] by
-
- 2 edits in trunk/Source/WebKit/win
Unreviewed, fix the Windows build after r143398.
Add new setters to the export list.
- WebKit.vcproj/WebKitExports.def.in:
- 4:42 PM Changeset in webkit [143408] by
-
- 2 edits in trunk/Source/JavaScriptCore
Don't force everything to be blinded in debug builds
https://bugs.webkit.org/show_bug.cgi?id=110279
Reviewed by Mark Hahnenberg.
Switch to an explicit flag for indicating that we want
every constant to be blinded.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::shouldBlind):
- 4:35 PM Changeset in webkit [143407] by
-
- 2 edits in trunk/Source/WebCore
Disable ASSERT(!hasInsertionPoint()) for background parser
https://bugs.webkit.org/show_bug.cgi?id=110251
Reviewed by Adam Barth.
The background parser crashes about 10 layout tests by hitting ASSERT(!hasInsertionPoint()).
Now, finish() is the thing that closes the HTMLInputStream which removes the insertion point.
In these tests, a document.open() calls insert() which clears the HTMLInputStream which causes
there to be an insertion point again.
With the main thread parser, insert() is called before finish() so the ASSERT passes.
However, with the threaded parser, finish() is called before insert(), so we fail the ASSERT.
This patch disables the ASSERT for the background parser because m_input isn't really relevant.
This causes us to pass the tests. However, there is a risk that now hasInsertionPoint() may be incorrect
and Document has a non-debug branch that tests hasInsertionPoint().
No new tests because covered by existing tests.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd):
- 4:34 PM Changeset in webkit [143406] by
-
- 3 edits in trunk/Tools
Unreviewed. Add myself to watch lists.
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/watchlist:
- 4:26 PM Changeset in webkit [143405] by
-
- 2 edits in trunk/Tools
Unreviewed, corrected primary email.
- Scripts/webkitpy/common/config/committers.py:
- 4:25 PM Changeset in webkit [143404] by
-
- 8 edits in trunk/Source/WebCore
Separate constraining for overhang from fixed-position zooming behavior in scrollOffsetForFixedPosition()
https://bugs.webkit.org/show_bug.cgi?id=110267
Reviewed by Beth Dakin.
The static scrollOffsetForFixedPosition() function in ScrollingCoordinator did two things;
it constrained the scroll position when rubber-banding, and applied the special scaling for
fixed position when zoomed.
Separate these out so that we can use the rubber-banding constrained elsewhere.
- page/FrameView.cpp:
(WebCore::FrameView::scrollOffsetForFixedPosition): The static function is here now.
- page/FrameView.h:
- page/scrolling/ScrollingCoordinator.cpp: Code moved to FrameView.
- page/scrolling/ScrollingCoordinator.h:
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition): scrollOffsetForFixedPosition()
is now on FrameView.
- platform/ScrollableArea.cpp:
(WebCore::constrainedScrollPosition): Helper to constrain one axis for overhang.
(WebCore::ScrollableArea::constrainScrollPositionForOverhang): Static function that
can be called by FrameView::scrollOffsetForFixedPosition().
- platform/ScrollableArea.h: Static function constrainScrollPositionForOverhang()
so we can call it from another thread. Also a member fuction of the same name, which takes
the scrollPosition as input (so we can feed it a layer position in a later patch).
- 4:20 PM Changeset in webkit [143403] by
-
- 5 edits in trunk/Source
Unreviewed, rolling out r143382 and r143401.
http://trac.webkit.org/changeset/143382
http://trac.webkit.org/changeset/143401
https://bugs.webkit.org/show_bug.cgi?id=106457
Breaks Chromium win/mac canary compilation
Source/Platform:
- chromium/public/Platform.h:
Source/WebKit/chromium:
- public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::idbFactory):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
- src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
- 4:15 PM Changeset in webkit [143402] by
-
- 2 edits in trunk/Source/WebCore
Fix checkThatTokensAreSafeToSendToAnotherThread() now that the preload scanner is enabled
https://bugs.webkit.org/show_bug.cgi?id=110258
Reviewed by Adam Barth.
We were hitting this ASSERT on numerous tests with the background parser enabled. This copy fixes the assertion.
No new tests becuase covered by existing tests.
- html/parser/HTMLResourcePreloader.h:
(WebCore::PreloadRequest::setCharset):
- 4:14 PM Changeset in webkit [143401] by
-
- 4 edits in trunk/Source
[Chromium] Move WebKitPlatformSupport declaration to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=110262
Reviewed by Adam Barth.
In preparation for removing WebKitPlatformSupport.h entirely (once
downstream references to that file have been updated). Part of a
larger refactoring series; see tracking bug 82948.
Source/Platform:
- chromium/public/Platform.h:
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
(WebKit):
Source/WebKit/chromium:
- public/platform/WebKitPlatformSupport.h:
- 4:13 PM Changeset in webkit [143400] by
-
- 2 edits in trunk/Source/WTF
Moar hardening
https://bugs.webkit.org/show_bug.cgi?id=110275
Reviewed by Anders Carlsson.
We now poison objects when they get freed, and verify that
any object that is being freed is not poisoned. If the
object looks like it's poisoned we validate the freelist,
and ensure the object is not already present. If it is
we crash.
On allocation, we ensure that the object being allocated
is poisoned, then clear the poisoning fields.
- wtf/FastMalloc.cpp:
(WTF::internalEntropyValue):
(WTF):
(WTF::freedObjectStartPoison):
(WTF::freedObjectEndPoison):
(TCMalloc_ThreadCache_FreeList):
(WTF::TCMalloc_ThreadCache_FreeList::Validate):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Allocate):
(WTF::TCMalloc_ThreadCache::Deallocate):
- 3:58 PM Changeset in webkit [143399] by
-
- 3 edits in trunk/Source/WebCore
Fix typo: inititatorFor->initiatorFor
https://bugs.webkit.org/show_bug.cgi?id=110260
Reviewed by Adam Barth.
No new tests because no changed functionality.
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::initiatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
- html/parser/HTMLPreloadScanner.h:
- 3:38 PM Changeset in webkit [143398] by
-
- 13 edits in trunk/Source
Convert 3 settings to use Settings.in
https://bugs.webkit.org/show_bug.cgi?id=109875
Reviewed by Ryosuke Niwa.
Source/WebCore:
Convert mediaEnabled, applicationChromeMode and DOMPasteAllowed to
use Settings.in. They previously had inconsistently named setters.
No new tests, this is a refactoring.
- Source/WebCore/WebCore.exp.in: Remove symbols that are now inlined from exports.
- Source/WebCore/WebCore.order: Remove symbols that no longer exist.
- dom/make_names.pl:
(printConstructorInterior): Rename isMediaEnabled to mediaEnabled.
(printWrapperFunctions): Rename isMediaEnabled to mediaEnabled.
- editing/EditorCommand.cpp:
(WebCore::supportedPaste): Rename isDOMPasteAllowed to DOMPasteAllowed.
- page/Settings.cpp:
(WebCore::Settings::Settings): Remove custom code.
- page/Settings.h:
(Settings): Remove custom code.
- page/Settings.in: Add entries for mediaEnabled, applicationChromeMode and DOMPasteAllowed.
- page/make_settings.pl:
(setterFunctionName): Expand uppercase rules to include DOM.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isDefault): Rename inApplicationChromeMode to applicationChromeMode.
- rendering/RenderThemeWin.cpp:
(WebCore::documentIsInApplicationChromeMode): Rename inApplicationChromeMode to applicationChromeMode.
Source/WebKit/efl:
- ewk/ewk_view.cpp:
(_ewk_view_priv_new): Rename isDOMPasteAllowed to DOMPasteAllowed.
- 3:34 PM Changeset in webkit [143397] by
-
- 5 edits2 adds in trunk
[CSS Grid Layout] Refactor the code in preparation of auto placement support
https://bugs.webkit.org/show_bug.cgi?id=110244
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/css-grid-layout/grid-auto-flow-resolution.html
In order to support auto placement, we need to iterate over the grid items with
auto row / column several times. This changes makes us do that in a very simple,
not-yet-conformant way. While touching this code, the distinction between grid-auto-flow
none and row / column was better drawn (and enforced).
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveGridPositionFromStyle):
Made it illegal to call resolveGridPositionFromStyle if the grid track is auto and
grid-auto-flow is not none. This would catch bad use of the function.
(WebCore::RenderGrid::maximumIndexInDirection):
Updated to bail out if the grid track is auto. Also improved the comment.
(WebCore::RenderGrid::placeItemsOnGrid):
Updated the function to do several iterations. Also handled the grid-auto-flow: none
case differently as it shouldn't need the extra iteration(s).
LayoutTests:
- fast/css-grid-layout/grid-auto-flow-resolution-expected.txt: Added.
- fast/css-grid-layout/grid-auto-flow-resolution.html: Added.
- fast/css-grid-layout/implicit-position-dynamic-change.html:
- fast/css-grid-layout/resources/grid.css:
(.autoRowAutoColumn):
(.firstRowAutoColumn):
(.secondRowAutoColumn):
(.thirdRowAutoColumn):
(.autoRowFirstColumn):
(.autoRowSecondColumn):
(.autoRowThirdColumn):
Added these helper classes, some will be used in a follow-up patch.
(.sizedToGridArea):
Hoisted this class into the common style.
- 3:31 PM Changeset in webkit [143396] by
-
- 5 edits in trunk/Source/WebKit2
StorageAreaProxy should know its quota
https://bugs.webkit.org/show_bug.cgi?id=110268
Reviewed by Sam Weinig.
Begin stubbing out StorageAreaProxy::setItem and add some quota member variables.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::StorageAreaProxy):
(WebKit::StorageAreaProxy::setItem):
- WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
- WebProcess/Storage/StorageNamespaceProxy.cpp:
(WebKit::StorageNamespaceProxy::createSessionStorageNamespace):
(WebKit::StorageNamespaceProxy::StorageNamespaceProxy):
- WebProcess/Storage/StorageNamespaceProxy.h:
(WebKit::StorageNamespaceProxy::quota):
(StorageNamespaceProxy):
- 3:23 PM Changeset in webkit [143395] by
-
- 6 edits3 adds in trunk
[New Multicolumn] REGRESSION: RenderMultiColumnSets broken by the RenderRegion -> RenderBlock subclassing.
https://bugs.webkit.org/show_bug.cgi?id=110239.
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/multicol/newmulticol/column-rules-fixed-height.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::columnRectAt):
Make sure the columnGap() in the old multicolumn code is always expressed as a LayoutUnit. This was the
one place where it was still an int.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
Rework the painting of flow thread portions to account for the fact that regions paint at an integral
translation. This means you have to construct clipping around that integral destination. Subpixel layout
regions did not clip correctly as a result of this issue.
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnRectAt):
Fix the same bug with columnGap() that the old column code has, i.e., one spot where it was an int.
(WebCore::RenderMultiColumnSet::paintObject):
RenderMultiColumnSet should be using paintObject and not paint and it needs to check for visibility
and phases now that it is a RenderBlock subclass.
(WebCore::RenderMultiColumnSet::paintColumnRules):
Fix the bug that Opera guys fixed in the old multi-column code. They didn't patch the new code, so this
takes care of that.
- rendering/RenderMultiColumnSet.h:
(RenderMultiColumnSet):
Change to use paintObject instead of paint.
LayoutTests:
- fast/multicol/newmulticol: Added.
- fast/multicol/newmulticol/column-rules-fixed-height-expected.html: Added.
- fast/multicol/newmulticol/column-rules-fixed-height.html: Added.
- 3:21 PM Changeset in webkit [143394] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix indentation of Opcode.h
Rubber stamped by Mark Hahnenberg.
- bytecode/Opcode.h:
- 3:20 PM Changeset in webkit [143393] by
-
- 4 edits1 add16 deletes in trunk/LayoutTests
Convert residual-style.html test to a reftest (and fix typos)
https://bugs.webkit.org/show_bug.cgi?id=109981
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-19
Reviewed by Darin Adler.
- fast/flexbox/box-orient-button.html: clsas->class
- fast/flexbox/resources/box-orient-button.js: DTR->DRT
- fast/invalid/residual-style-expected.html: Added. New reftest
version. Note that some lines are red, which is
https://bugs.webkit.org/show_bug.cgi?id=109984
- fast/invalid/residual-style.html: Add missing semicolon in <style>.
Also close a few more <font> tags, so that the descriptive text is
in black as it should be.
- platform/chromium-android/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-android/fast/invalid/residual-style-expected.txt: Removed.
- platform/chromium-linux/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-linux/fast/invalid/residual-style-expected.txt: Removed.
- platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-mac/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
- platform/chromium-win/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-win/fast/invalid/residual-style-expected.txt: Removed.
- platform/efl/fast/invalid/residual-style-expected.png: Removed.
- platform/efl/fast/invalid/residual-style-expected.txt: Removed.
- platform/gtk/fast/invalid/residual-style-expected.png: Removed.
- platform/gtk/fast/invalid/residual-style-expected.txt: Removed.
- platform/mac/fast/invalid/residual-style-expected.png: Removed.
- platform/mac/fast/invalid/residual-style-expected.txt: Removed.
Removed old expectation files.
- 3:19 PM Changeset in webkit [143392] by
-
- 6 edits1 add in trunk/Source/JavaScriptCore
Moved PolymorphicAccessStructureList into its own file.
Rubber stamped by Mark Hahnenberg.
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/Instruction.h:
(JSC):
- bytecode/PolymorphicAccessStructureList.h: Added.
(JSC):
(PolymorphicAccessStructureList):
(PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
(JSC::PolymorphicAccessStructureList::visitWeak):
- bytecode/StructureStubInfo.h:
- 3:17 PM WebKit Team edited by
- (diff)
- 3:15 PM Changeset in webkit [143391] by
-
- 6 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Appropriately handle word wrapping in SpellingHandler
https://bugs.webkit.org/show_bug.cgi?id=110253
Reviewed by Rob Buis.
PR286001
Since we traverse through text by visual lines instead of blocks, word wrapping causes some
bad behavior. Changing the way we traverse text to jump by words instead of lines. This will
mean it takes longer to finish spellchecking, but the removal of any loops allows webkit
processing to continue. This gives priority to user actions while still completing a large
paragraph in a reasonable amount of time.
Internally reviewed by Mike Fenton
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- WebKitSupport/SpellingHandler.cpp:
(BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
(BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):
(BlackBerry::WebKit::SpellingHandler::startOfNextWord):
(WebKit):
(BlackBerry::WebKit::SpellingHandler::incrementByWord):
(BlackBerry::WebKit::SpellingHandler::doesWordWrap):
- WebKitSupport/SpellingHandler.h:
(SpellingHandler):
- 3:10 PM Changeset in webkit [143390] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix indentation of Instruction.h
Rubber stamped by Mark Hahnenberg.
- bytecode/Instruction.h:
- 3:04 PM Changeset in webkit [143389] by
-
- 8 edits6 adds in trunk
Fix 'slice' aspect ratio calculation
https://bugs.webkit.org/show_bug.cgi?id=99984
Patch by Branimir Lambov <blambov@google.com> on 2013-02-19
Reviewed by Dirk Schulze.
Source/WebCore:
Previously the calculation for the 'slice' aspect ratio would incorrectly calculate the
source rect location based on the destination rect offset. This caused our source rect to be
incorrect, and sometimes render outside the visible area completely. After this patch
our implementation matches the implementation of both Gecko and Presto.
The relevant spec section:
http://www.w3.org/TR/SVG/single-page.html#coords-PreserveAspectRatioAttribute
Tests: svg/as-image/image-preserveAspectRatio-all.svg
svg/filters/feImage-preserveAspectRatio-all.svg
- svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::transformRect):
LayoutTests:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
- svg/as-image/image-preserveAspectRatio-all-expected.txt: Added.
- svg/as-image/image-preserveAspectRatio-all.svg: Added.
- svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
- svg/filters/feImage-preserveAspectRatio-all-expected.txt: Added.
- svg/filters/feImage-preserveAspectRatio-all.svg: Added.
- 3:03 PM Changeset in webkit [143388] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test Expectations to reflect flakey calendar tests.
https://bugs.webkit.org/show_bug.cgi?id=107508
Unreviewed test expectations.
- platform/chromium/TestExpectations: Re-added all the flakey calendar tests.
- 3:01 PM Changeset in webkit [143387] by
-
- 2 edits in trunk/Source/WebCore
[V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM occurs
https://bugs.webkit.org/show_bug.cgi?id=110254
Patch by Kentaro Hara <haraken@google.com> on 2013-02-19
Reviewed by Adam Barth.
Chromium bug: https://code.google.com/p/chromium/issues/detail?id=176951
Currently ScriptRunner::runCompiledScript() calls
ASSERT(script.IsEmpty()) when OOM occurs. The Chromium bug is
hitting the ASSERT(). The ASSERT() does not make sense at all.
Instead, we should return an empty handle when OOM occurs.
No tests. The bug happens only when OOM occurs.
- bindings/v8/ScriptRunner.cpp:
(WebCore::ScriptRunner::runCompiledScript):
- 2:58 PM Changeset in webkit [143386] by
-
- 31 edits2 adds in trunk
Support both MutationObserver and WebKitMutationObserver
https://bugs.webkit.org/show_bug.cgi?id=109776
Reviewed by Ojan Vafai.
Source/WebCore:
We should allow new MutationObserver now that we support parser generated
mutations. This leaves the old prefixed constructor in until we decide
people don't depend on it.
Test: fast/dom/MutationObserver/mutation-observer-prefix.html
- page/DOMWindow.idl:
LayoutTests:
- fast/dom/MutationObserver/added-out-of-order.html:
- fast/dom/MutationObserver/callback-arguments.html:
- fast/dom/MutationObserver/clear-transient-without-delivery.html:
- fast/dom/MutationObserver/create-during-delivery.html:
- fast/dom/MutationObserver/cross-document.html:
- fast/dom/MutationObserver/database-callback-delivery.html:
- fast/dom/MutationObserver/delivery-order.html:
- fast/dom/MutationObserver/disconnect-cancel-pending.html:
- fast/dom/MutationObserver/document-fragment-insertion.html:
- fast/dom/MutationObserver/end-of-task-delivery.html:
- fast/dom/MutationObserver/filesystem-callback-delivery.html:
- fast/dom/MutationObserver/inline-event-listener.html:
- fast/dom/MutationObserver/mutate-during-delivery.html:
- fast/dom/MutationObserver/mutation-callback-non-element-crash.html:
- fast/dom/MutationObserver/mutation-observer-constructor.html:
- fast/dom/MutationObserver/mutation-observer-prefix-expected.txt: Added.
- fast/dom/MutationObserver/mutation-observer-prefix.html: Added.
- fast/dom/MutationObserver/mutation-record-nullity.html:
- fast/dom/MutationObserver/observe-attributes.html:
- fast/dom/MutationObserver/observe-characterdata.html:
- fast/dom/MutationObserver/observe-childList.html:
- fast/dom/MutationObserver/observe-exceptions.html:
- fast/dom/MutationObserver/observe-subtree.html:
- fast/dom/MutationObserver/observer-wrapper-dropoff-transient.html:
- fast/dom/MutationObserver/observer-wrapper-dropoff.html:
- fast/dom/MutationObserver/parser-mutations.html:
- fast/dom/MutationObserver/removed-out-of-order.html:
- fast/dom/MutationObserver/shadow-dom.html:
- fast/dom/MutationObserver/takeRecords.html:
- fast/dom/MutationObserver/transient-gc-crash.html:
- 2:38 PM Changeset in webkit [143385] by
-
- 6 edits in trunk/Source/WebKit2
<rdar://problem/13239119> NetworkProcess generates timeout spindump logs
Reviewed by Mark Rowe.
Don't keep a window server connection in processes that don't need it, and don't
run an NSApplication run loop.
- Shared/ChildProcess.h:
- Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::shutdownWindowServerConnection): Added a function to shut down connections, and to make sure we don't get one in the future.
- NetworkProcess/mac/NetworkProcessMac.mm: (WebKit::NetworkProcess::initializeProcessName):
- OfflineStorageProcess/mac/OfflineStorageProcessMac.mm: (WebKit::OfflineStorageProcess::initializeProcessName):
- SharedWorkerProcess/mac/SharedWorkerProcessMac.mm: (WebKit::SharedWorkerProcess::platformInitializeSharedWorkerProcess): Also removed some unused includes and forward declarations.
- 2:29 PM Changeset in webkit [143384] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling in r143348.
http://trac.webkit.org/changeset/143348
https://bugs.webkit.org/show_bug.cgi?id=110242
The bug was that isEmptyValue() was returning true for the deleted value.
Fixed this and simplified things further by delegating to m_sourceCode
for both isNull() and isHashTableDeletedValue(), so they can't be out of
sync.
- runtime/CodeCache.cpp:
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
- runtime/CodeCache.h:
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(SourceCodeKey):
- 2:15 PM Changeset in webkit [143383] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 2:02 PM Changeset in webkit [143382] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Remove idbFactory from WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=106457
Reviewed by Kentaro Hara.
Now that https://codereview.chromium.org/12230054 has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.
- public/platform/WebKitPlatformSupport.h:
(WebKit):
- src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
- 1:53 PM Changeset in webkit [143381] by
-
- 2 edits1 add1 delete in trunk/Source/JavaScriptCore
[GTK] Improve gyp build JavaScriptCore code generation
https://bugs.webkit.org/show_bug.cgi?id=109969
Reviewed by Dirk Pranke.
Switch away from using DerivedSources.make when building JavaScriptCore generated
sources. This bring a couple advantages, such as building the sources in parallel,
but requires us to list the generated sources more than once.
- JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Add rules for generating JavaScriptCore sources.
- JavaScriptCore.gyp/generate-derived-sources.sh: Added.
- JavaScriptCore.gyp/redirect-stdout.sh: Added.
- 1:51 PM Changeset in webkit [143380] by
-
- 7 edits in trunk/Source/WebCore
Remove RenderText::updateText
https://bugs.webkit.org/show_bug.cgi?id=109991
Reviewed by Eric Seidel.
There's no reason for the generic RenderText::updateText virtual hook
anymore now that r143060 made RenderQuote stop setting dirty bits during
layout since the hook is only used by RenderCounter.
Instead add updateCounterIfNeeded and make it clear this is a hack for
counters.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::updateCounterIfNeeded): Added, not handles the counter specific hack.
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
- rendering/RenderCounter.cpp:
(WebCore::RenderCounter::updateCounter):
- rendering/RenderCounter.h:
(RenderCounter):
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::updateDepth):
- rendering/RenderQuote.h:
(RenderQuote):
- rendering/RenderText.h:
(RenderText):
- 1:48 PM Changeset in webkit [143379] by
-
- 5 edits3 copies in branches/chromium/1364
Merge 141645
Prevent skipped repaints for children of inner SVG elements
https://bugs.webkit.org/show_bug.cgi?id=108429
Reviewed by Eric Seidel.
Source/WebCore:
This patch fixes a bug caused by r108699 and r133786 where we would not repaint children
of inner SVG elements because "m_didTransformToRootUpdate" was never reset on viewport
containers. The stale m_didTransformToRootUpdate variable caused us to skip child repaints.
I verified that the Robohornet SVG benchmark performance gains in r133786 are not regressed
with this patch.
Test: svg/repaint/svgsvgelement-repaint-children.html
- rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::calcViewport):
This can be removed because setNeedsTransformUpdate() will set m_needsTransformUpdate.
(WebCore::RenderSVGViewportContainer::calculateLocalTransform):
This change is straightforward and is similar to the equivalent assignment in
RenderSVGTransformableContainer::calculateLocalTransform().
LayoutTests:
Need to update expectations for a single file (just a 1px difference).
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- svg/repaint/svgsvgelement-repaint-children-expected.png: Added.
- svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
- svg/repaint/svgsvgelement-repaint-children.html: Added.
TBR=pdr@google.com
- 1:46 PM Changeset in webkit [143378] by
-
- 2 edits64 adds in trunk/LayoutTests
CSS3: add line-break tests, initially skipping on all platforms
https://bugs.webkit.org/show_bug.cgi?id=109954
Reviewed by Dirk Pranke.
See also wiki documentation at:
[1] http://trac.webkit.org/wiki/LineBreaking
[2] http://trac.webkit.org/wiki/LineBreakingCSS3Mapping
See also:
https://bugs.webkit.org/show_bug.cgi?id=89235
- TestExpectations:
- css3/line-break/line-break-auto-centered-expected.html: Added.
- css3/line-break/line-break-auto-centered.html: Added.
- css3/line-break/line-break-auto-half-kana-expected.html: Added.
- css3/line-break/line-break-auto-half-kana.html: Added.
- css3/line-break/line-break-auto-hyphens-expected.html: Added.
- css3/line-break/line-break-auto-hyphens.html: Added.
- css3/line-break/line-break-auto-inseparables-expected.html: Added.
- css3/line-break/line-break-auto-inseparables.html: Added.
- css3/line-break/line-break-auto-iteration-marks-expected.html: Added.
- css3/line-break/line-break-auto-iteration-marks.html: Added.
- css3/line-break/line-break-auto-postfixes-expected.html: Added.
- css3/line-break/line-break-auto-postfixes.html: Added.
- css3/line-break/line-break-auto-prefixes-expected.html: Added.
- css3/line-break/line-break-auto-prefixes.html: Added.
- css3/line-break/line-break-auto-sound-marks-expected.html: Added.
- css3/line-break/line-break-auto-sound-marks.html: Added.
- css3/line-break/line-break-loose-centered-expected.html: Added.
- css3/line-break/line-break-loose-centered.html: Added.
- css3/line-break/line-break-loose-half-kana-expected.html: Added.
- css3/line-break/line-break-loose-half-kana.html: Added.
- css3/line-break/line-break-loose-hyphens-expected.html: Added.
- css3/line-break/line-break-loose-hyphens.html: Added.
- css3/line-break/line-break-loose-inseparables-expected.html: Added.
- css3/line-break/line-break-loose-inseparables.html: Added.
- css3/line-break/line-break-loose-iteration-marks-expected.html: Added.
- css3/line-break/line-break-loose-iteration-marks.html: Added.
- css3/line-break/line-break-loose-postfixes-expected.html: Added.
- css3/line-break/line-break-loose-postfixes.html: Added.
- css3/line-break/line-break-loose-prefixes-expected.html: Added.
- css3/line-break/line-break-loose-prefixes.html: Added.
- css3/line-break/line-break-loose-sound-marks-expected.html: Added.
- css3/line-break/line-break-loose-sound-marks.html: Added.
- css3/line-break/line-break-normal-centered-expected.html: Added.
- css3/line-break/line-break-normal-centered.html: Added.
- css3/line-break/line-break-normal-half-kana-expected.html: Added.
- css3/line-break/line-break-normal-half-kana.html: Added.
- css3/line-break/line-break-normal-hyphens-expected.html: Added.
- css3/line-break/line-break-normal-hyphens.html: Added.
- css3/line-break/line-break-normal-inseparables-expected.html: Added.
- css3/line-break/line-break-normal-inseparables.html: Added.
- css3/line-break/line-break-normal-iteration-marks-expected.html: Added.
- css3/line-break/line-break-normal-iteration-marks.html: Added.
- css3/line-break/line-break-normal-postfixes-expected.html: Added.
- css3/line-break/line-break-normal-postfixes.html: Added.
- css3/line-break/line-break-normal-prefixes-expected.html: Added.
- css3/line-break/line-break-normal-prefixes.html: Added.
- css3/line-break/line-break-normal-sound-marks-expected.html: Added.
- css3/line-break/line-break-normal-sound-marks.html: Added.
- css3/line-break/line-break-strict-centered-expected.html: Added.
- css3/line-break/line-break-strict-centered.html: Added.
- css3/line-break/line-break-strict-half-kana-expected.html: Added.
- css3/line-break/line-break-strict-half-kana.html: Added.
- css3/line-break/line-break-strict-hyphens-expected.html: Added.
- css3/line-break/line-break-strict-hyphens.html: Added.
- css3/line-break/line-break-strict-inseparables-expected.html: Added.
- css3/line-break/line-break-strict-inseparables.html: Added.
- css3/line-break/line-break-strict-iteration-marks-expected.html: Added.
- css3/line-break/line-break-strict-iteration-marks.html: Added.
- css3/line-break/line-break-strict-postfixes-expected.html: Added.
- css3/line-break/line-break-strict-postfixes.html: Added.
- css3/line-break/line-break-strict-prefixes-expected.html: Added.
- css3/line-break/line-break-strict-prefixes.html: Added.
- css3/line-break/line-break-strict-sound-marks-expected.html: Added.
- css3/line-break/line-break-strict-sound-marks.html: Added.
- 1:18 PM Changeset in webkit [143377] by
-
- 3 edits2 adds in trunk
Border changes on tables with collapsed borders doesn't relayout table cells
https://bugs.webkit.org/show_bug.cgi?id=109774
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/table/border-collapsing/dynamic-border-width-change.html
Changes to border top and border bottom on table rows also changes the size
of the table cell causing a relayout to be needed.
- rendering/RenderTableRow.cpp:
(WebCore::borderWidthChanged): Also include border top and bottom.
(WebCore::RenderTableRow::styleDidChange): Remove logical from the helper function name.
LayoutTests:
- fast/table/border-collapsing/dynamic-border-width-change-expected.txt: Added.
- fast/table/border-collapsing/dynamic-border-width-change.html: Added.
- 12:56 PM Changeset in webkit [143376] by
-
- 1 edit1 add in trunk/LayoutTests
Add a test result missed in r143074.
- platform/mac-wk2/tiled-drawing/null-parent-back-crash-expected.txt: Added.
- 12:49 PM Changeset in webkit [143375] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Remove two now-passing tests.
- platform/chromium/TestExpectations:
- 12:47 PM Changeset in webkit [143374] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Rebaselined run-bindings-tests.
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):
- 12:43 PM Changeset in webkit [143373] by
-
- 4 edits in trunk/LayoutTests
[WebGL] Fix oes-element-index-uint.html test.
https://bugs.webkit.org/show_bug.cgi?id=110045
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-19
Reviewed by Kenneth Russell.
This patch fixes the test case to use updated WebGLTestUtils functions
and adds shaders used during resized buffer tests. This patch
also enables the test for EFL port.
- fast/canvas/webgl/oes-element-index-uint-expected.txt:
- fast/canvas/webgl/oes-element-index-uint.html:
- platform/efl/TestExpectations:
- 12:36 PM Changeset in webkit [143372] by
-
- 2 edits in trunk/Source/Platform
WebAudio API: Change the Platform::createAudioDevice function to take a DeviceId parameter
https://bugs.webkit.org/show_bug.cgi?id=110192
Reviewed by Adam Barth.
- chromium/public/Platform.h:
(WebKit::Platform::createAudioDevice):
(Platform):
- 12:32 PM Changeset in webkit [143371] by
-
- 4 edits in tags/Safari-537.31.4/Source
Versioning.
- 12:29 PM Changeset in webkit [143370] by
-
- 1 copy in tags/Safari-537.31.4
New Tag.
- 12:10 PM Changeset in webkit [143369] by
-
- 6 edits in trunk/Source/WebCore
[GTK][AC] Implement matrix transform animation with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=109848
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-19
Reviewed by Gustavo Noronha Silva.
Clutter 1.12 doesn't support additive transform animations yet, so the combination
of two or more transformations(such as rotation after translation) runs unexpectedly.
So we use a matrix transformation instead for the case.
Covered by existing animation tests.
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::getValueFunctionNameForTransformOperation):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
- platform/graphics/clutter/PlatformClutterAnimation.cpp:
(WebCore::toClutterActorPropertyString): Add actor property "transform"
(WebCore::clutterMatrixProgress): Handle interpolation between two matrices instead of default clutter_matrix_progress.
(WebCore):
(WebCore::PlatformClutterAnimation::supportsAdditiveValueFunction):
(WebCore::PlatformClutterAnimation::setFromValue): for TransformationMatrix.
(WebCore::PlatformClutterAnimation::setToValue): ditto.
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore::PlatformClutterAnimation::addTransformTransition):
- platform/graphics/clutter/PlatformClutterAnimation.h:
(PlatformClutterAnimation):
- platform/graphics/clutter/TransformationMatrixClutter.cpp: Add copy constructor for CoglMatrix.
(WebCore::TransformationMatrix::TransformationMatrix):
(WebCore):
- platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix):
- 12:02 PM Changeset in webkit [143368] by
-
- 2 edits1 delete in branches/chromium/1410
Revert 129070
[Chromium] Disable resource load scheduling
https://bugs.webkit.org/show_bug.cgi?id=97131
Reviewed by Nate Chapin.
Source/WebCore:
We'll use Chrome's network stack for scheduling instead.
No new tests.
- loader/ResourceLoadScheduler.cpp:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::preload):
LayoutTests:
The preload scanner loads resources sooner and these tests are affected.
- platform/chromium/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
- platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Added.
TBR=simonjam@chromium.org
Review URL: https://codereview.chromium.org/12294041
- 12:01 PM Changeset in webkit [143367] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark fast/workers/storage/interrupt-database.html as flaky crasher
https://bugs.webkit.org/show_bug.cgi?id=110247
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 11:39 AM Changeset in webkit [143366] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r143348.
http://trac.webkit.org/changeset/143348
https://bugs.webkit.org/show_bug.cgi?id=110242
"Caused a deleted value sentinel crash on the layout tests"
(Requested by ggaren on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19
- runtime/CodeCache.cpp:
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
- runtime/CodeCache.h:
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(SourceCodeKey):
- 11:34 AM Changeset in webkit [143365] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 142793
Bidi-Isolated inlines can cause subsequent content to not be rendered
https://bugs.webkit.org/show_bug.cgi?id=108137
Reviewed by Eric Seidel.
Source/WebCore:
First step in fixing how inline isolates behave with collapsed spaces.
webkit.org/b/109624 tracks the overarching issue.
Test: fast/text/content-following-inline-isolate-with-collapsed-whitespace.html
- rendering/InlineIterator.h:
(WebCore::IsolateTracker::addFakeRunIfNecessary): If we enter an isolate while
ignoring spaces, ensure we leave it considering them again. This can result in
including spaces that should be ignored following the isolate on the line, but
failing to do so results in those contents not being rendered at all.
LayoutTests:
- fast/text/content-following-inline-isolate-with-collapsed-whitespace.html: Added.
- fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt: Added.
TBR=leviw@chromium.org
Review URL: https://codereview.chromium.org/12308006
- 11:29 AM Changeset in webkit [143364] by
-
- 61 edits4 deletes in trunk/LayoutTests
Rebaselining, again, calendar tests
https://bugs.webkit.org/show_bug.cgi?id=110240
Unreviewed expectations update.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Removed.
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- 11:19 AM Changeset in webkit [143363] by
-
- 4 edits in trunk/Source/WebCore
Update FeatureObserver on top level navigation in addition to page destruction.
https://bugs.webkit.org/show_bug.cgi?id=109874
Patch by Kassy Coan <kassycoan@chromium.org> on 2013-02-19
Reviewed by Adam Barth.
No new tests. Only effect is to histogram more frequently.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchDidCommitLoad):
- page/FeatureObserver.cpp:
(WebCore::FeatureObserver::~FeatureObserver):
(WebCore):
(WebCore::FeatureObserver::updateMeasurements):
(WebCore::FeatureObserver::didCommitLoad):
- page/FeatureObserver.h:
(FeatureObserver):
- 11:15 AM Changeset in webkit [143362] by
-
- 2 edits in trunk/Tools
Unreviewed, changing primary email.
- 11:10 AM Changeset in webkit [143361] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary (and problematic) copy-constructor from LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=110121
This copy constructor does what a default copy constructor would do, so
it's not necessary. Furthermore, this copy constructor is the only
reason why LayoutUnit becomes non-POD, and that triggers a gdb bug,
making it impossible to do things like "print location()" when inside
some RenderBlock, for instance.
Gdb bug http://sourceware.org/bugzilla/show_bug.cgi?id=15154 reported.
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-02-19
Reviewed by Benjamin Poulain.
No tests. Apart from dealing with buggy debuggers, this is just code cleanup.
- platform/LayoutUnit.h:
- 11:10 AM Changeset in webkit [143360] by
-
- 2 edits1 copy1 move in trunk/Tools
REGRESSION: Sheriffbot is failing to process rollout requests
https://bugs.webkit.org/show_bug.cgi?id=106945
Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-19
Reviewed by Adam Barth.
Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
This resolves problems when Sheriffbot attempts to perform a rollout request.
- EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
- EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
- EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.
- 11:08 AM Changeset in webkit [143359] by
-
- 1 edit1 add in trunk/Source/WebKit/gtk/po
Romanian translation for WebKitGtk+ HEAD
https://bugs.webkit.org/show_bug.cgi?id=110009
Patch by Mișu Moldovan <dumol@gnome.org> on 2013-02-19
Reviewed by Gustavo Noronha.
- ro.po: Added.
- 11:06 AM Changeset in webkit [143358] by
-
- 1 edit4 adds in trunk/LayoutTests
[WK2] Cannot load documents with blob urls
https://bugs.webkit.org/show_bug.cgi?id=110160
Reviewed by Sam Weinig.
- http/tests/fileapi/blob-url-in-subframe-expected.txt: Added.
- http/tests/fileapi/blob-url-in-subframe.html: Added.
- http/tests/fileapi/resources: Added.
- http/tests/fileapi/resources/blob-url-in-subframe-frame.html: Added.
- 11:00 AM Changeset in webkit [143357] by
-
- 2 edits in trunk/Source/WebCore
LayoutUnit::epsilon shouldn't be necessary to place floats
https://bugs.webkit.org/show_bug.cgi?id=94000
Reviewed by Levi Weintraub.
Currently, to get float placement correct, we need to have an
epsilon tolerance in RenderBlock::computeLogicalLocationForFloat
for the width of the line to fit them on. This really shouldn't
be necessary, and probably indicates we're losing precision
elsewhere.
Remove epsilon as it no longer appears to be needed. All layout
tests pass without it.
No new tests, covered by existing tests.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat):
- 10:57 AM Changeset in webkit [143356] by
-
- 22 edits2 adds in trunk
Text Autosizing: prevent oscillation of font sizes during autosizing
https://bugs.webkit.org/show_bug.cgi?id=108205
Patch by Tim Volodine <timvolodine@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
On some websites autosized font-sizes oscillate due to layouts caused by
hovering or incremental page loading (and on other sites font sizes do
eventually stabilize, but it takes many layouts before they reach a steady
size). To prevent all these cases, we no longer allow the autosizing
multiplier to change after it has been set (to a value other than 1).
This won't always give exactly the same results, but testing on 2000 top
sites shows that this makes little difference in practice, and it prevents
these very jarring cases. As a happy side-effect, this speeds up layouts
as font sizes change less.
Test: fast/text-autosizing/oscillation-javascript-fontsize-change.html
- page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
- page/Settings.cpp:
(WebCore::Settings::setTextAutosizingFontScaleFactor):
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::recalculateMultipliers):
(WebCore):
(WebCore::TextAutosizer::processContainer):
- rendering/TextAutosizer.h:
(TextAutosizer):
LayoutTests:
Added overflow-y:hidden to some existing tests, since previously those tests
would start off with incorrect multipliers (because mainFrame->view()-layoutSize()
is initially 785 instead of 800 as ScrollView wrongly guesses a scrollbar will
be needed), and then the multipliers would get corrected on a subsequent layout.
Now that we don't allow the multiplier to change after being set, it needs to be
right first time.
Also added specific oscillation test triggered by javascript.
- fast/text-autosizing/constrained-height-body-expected.html:
- fast/text-autosizing/constrained-height-body.html:
- fast/text-autosizing/constrained-then-float-ancestors-expected.html:
- fast/text-autosizing/constrained-then-float-ancestors.html:
- fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html:
- fast/text-autosizing/constrained-then-position-fixed-ancestors.html:
- fast/text-autosizing/nested-em-line-height-expected.html:
- fast/text-autosizing/nested-em-line-height.html:
- fast/text-autosizing/oscillation-javascript-fontsize-change-expected.html: Added.
- fast/text-autosizing/oscillation-javascript-fontsize-change.html: Added.
- fast/text-autosizing/simple-paragraph-expected.html:
- fast/text-autosizing/simple-paragraph.html:
- fast/text-autosizing/span-child-expected.html:
- fast/text-autosizing/span-child.html:
- fast/text-autosizing/unwrappable-blocks-expected.html:
- fast/text-autosizing/unwrappable-blocks.html:
- fast/text-autosizing/unwrappable-inlines-expected.html:
- fast/text-autosizing/unwrappable-inlines.html:
- 10:42 AM Changeset in webkit [143355] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Fix races in double-tap zoom minimum scale policy
https://bugs.webkit.org/show_bug.cgi?id=110183
Reviewed by Adam Barth.
Double-tap zoom on Android is supposed to return to minimum scale
if no pinch zoom occurred since the last double-tap. Because both
pinch zoom and the result of double-tap zoom gets passed in from CC
via applyScrollAndScale, this logic was brittle and prone to races
depending on when the animation update was received. This patch
keeps track of what the target double-tap scale is to make it more
robust.
I also fixed double-tap zoom test mocking to exercise the entire
page scale animation flow (our previous way of testing was hiding the
raciness), and added a new test case in DivAutoZoomMultipleParamsTest.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::startPageScaleAnimation):
(WebKit):
(WebKit::WebViewImpl::enableFakeDoubleTapAnimationForTesting):
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
(WebKit::WebViewImpl::animateZoomAroundPoint):
(WebKit::WebViewImpl::didCommitLoad):
(WebKit::WebViewImpl::applyScrollAndScale):
- src/WebViewImpl.h:
(WebViewImpl):
(WebKit::WebViewImpl::fakeDoubleTapAnimationPendingForTesting):
(WebKit::WebViewImpl::fakeDoubleTapTargetPositionForTesting):
(WebKit::WebViewImpl::fakeDoubleTapPageScaleFactorForTesting):
(WebKit::WebViewImpl::fakeDoubleTapUseAnchorForTesting):
- tests/WebFrameTest.cpp:
- 10:40 AM Changeset in webkit [143354] by
-
- 2 edits in trunk/Source/JavaScriptCore
HeapBlock::destroy should issue warning if result is unused
https://bugs.webkit.org/show_bug.cgi?id=110233
Reviewed by Oliver Hunt.
To enforce the fact that we need to return blocks to the BlockAllocator after calling destroy,
we should add WARN_UNUSED_RETURN to HeapBlock::destroy and any other destroy functions in its subclasses.
- heap/HeapBlock.h:
- 10:29 AM Changeset in webkit [143353] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Cannot load documents with blob urls
https://bugs.webkit.org/show_bug.cgi?id=110160
Reviewed by Sam Weinig.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::canHandleRequest): Added knowledge about blobs.
- 10:28 AM Changeset in webkit [143352] by
-
- 4 edits in trunk
[EFL][DRT] http/tests/loading/307-after-303-after-post.html times out
https://bugs.webkit.org/show_bug.cgi?id=93214
Source/WebCore:
Ensured that GET verb is consistently used for any request
coming after a redirection that triggers switching to GET.
Patch by Youenn Fablet <youennf@gmail.com> on 2013-02-19
Reviewed by Martin Robinson.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::doRedirect):
LayoutTests:
Removed Failure from potential outcome of
http/tests/loading/307-after-303-after-post.html test.
Patch by Youenn Fablet <youennf@gmail.com> on 2013-02-19
Reviewed by Martin Robinson.
- platform/efl/TestExpectations:
- 10:12 AM Changeset in webkit [143351] by
-
- 2 edits in trunk/Source/JavaScriptCore
WeakSet::removeAllocator leaks WeakBlocks
https://bugs.webkit.org/show_bug.cgi?id=110228
Reviewed by Geoffrey Garen.
We need to return the WeakBlock to the BlockAllocator after the call to WeakBlock::destroy.
- heap/WeakSet.cpp:
(JSC::WeakSet::removeAllocator):
- 10:07 AM Changeset in webkit [143350] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix compilation if Qt was configured with -no-rtti
https://bugs.webkit.org/show_bug.cgi?id=110234
Reviewed by Noam Rosenthal.
Availability of dynamic_cast should be checked.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):
- 10:05 AM Changeset in webkit [143349] by
-
- 3 edits in trunk/Source/WebCore
Unregistered blob URLs have incorrect MIME type
https://bugs.webkit.org/show_bug.cgi?id=110166
Reviewed by Sam Weinig.
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::shouldUseInnerURL): Added a FIXME.
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyResponseOnError): Pass an accurate MIME type (for a delegate to see).
- 9:48 AM Changeset in webkit [143348] by
-
- 3 edits in trunk/Source/JavaScriptCore
Save space on keys in the CodeCache
https://bugs.webkit.org/show_bug.cgi?id=110179
Reviewed by Oliver Hunt.
Share the SourceProvider's string instead of making our own copy. This
chops off 16MB - 32MB from the CodeCache's memory footprint when full.
(It's 16MB when the strings are LChar, and 32MB when they're UChar.)
- runtime/CodeCache.cpp:
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
- runtime/CodeCache.h: Removed a defunct enum value.
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(SourceCodeKey):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::string):
(JSC::SourceCodeKey::operator==): Store a SourceCode instead of a String
so we can share our string with our SourceProvider. Cache our hash so
we don't have to re-decode our string just to re-hash the table.
- 9:42 AM Changeset in webkit [143347] by
-
- 5 edits in trunk/Source
IndexedDB: additional checks on LevelDB decoding
https://bugs.webkit.org/show_bug.cgi?id=109711
Reviewed by Tony Chang.
Source/WebCore:
Watch out for decoding errors caused by corrupted data, and exit various
decode/compare operations earlier.
Covered by existing LayoutTests and Chromium's webkit_unit_tests
- Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::decodeStringWithLength): Bail if length is negative.
(WebCore::IDBLevelDBCoding::compareEncodedStringsWithLength): Distinguish error case.
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey): Bail if length is negative.
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys): Distinguish error case.
(WebCore::IDBLevelDBCoding::compare): Plumb through "ok".
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare): Ditto.
(WebCore::IDBLevelDBCoding::ExistsEntryKey::compare): Ditto.
(WebCore::IDBLevelDBCoding::IndexDataKey::compare): Ditto.
- Modules/indexeddb/IDBLevelDBCoding.h: Updated method signatures.
Source/WebKit/chromium:
- tests/IDBLevelDBCodingTest.cpp: Update test with new method signatures.
- 9:12 AM Changeset in webkit [143346] by
-
- 3 edits in trunk/Source/JavaScriptCore
revertBranchPtrWithPatch is incorrect on ARM traditional
https://bugs.webkit.org/show_bug.cgi?id=110201
Reviewed by Oliver Hunt.
Revert two instructions back to their original value.
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::revertBranchPtrWithPatch):
(ARMAssembler):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchPtrWithPatch):
(JSC::MacroAssemblerARM::revertJumpReplacementToBranchPtrWithPatch):
- 9:09 AM Changeset in webkit [143345] by
-
- 7 edits in trunk
Unreviewed build fix.
.:
- Source/autotools/FindDependencies.m4:
- Source/autotools/Versions.m4:
- Source/cmake/FindHarfBuzz.cmake:
Bump gtk and efl dependencies on harfbuzz
to 0.9.7. See bug 110145.
Tools:
- efl/jhbuild.modules:
- gtk/jhbuild.modules:
Bump harfbuzz module to 0.9.7. See related bug 110145.
- 9:01 AM Changeset in webkit [143344] by
-
- 2 edits in trunk
Only depend on xrender if x11 is being used
https://bugs.webkit.org/show_bug.cgi?id=84095
Patch by Changhun Kang <temoochin@company100.net> on 2013-02-19
Reviewed by Martin Robinson.
- Source/autotools/FindDependencies.m4:
- 9:01 AM Changeset in webkit [143343] by
-
- 4 edits in trunk/Source/WebCore
[GTK][AC] Implement keyframe animations with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=110057
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-19
Reviewed by Gustavo Noronha Silva.
This patch brings accelerated keyframe animation with clutter to WebKitGtk+.
Changes of GraphicsLayerClutter are based on GraphicsLayerCA. But major changes
of PlatformClutterAnimation are implemented with clutter keyframe transition apis.
See http://developer.gnome.org/clutter/stable/ClutterKeyframeTransition.html
Covered by existing animation tests.
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::createKeyframeAnimation):
(WebCore::GraphicsLayerClutter::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerClutter::setAnimationKeyframes):
- platform/graphics/clutter/PlatformClutterAnimation.cpp:
(WebCore::toClutterActorPropertyString):
(WebCore::PlatformClutterAnimation::PlatformClutterAnimation):
(WebCore::PlatformClutterAnimation::setTimingFunction):
(WebCore::PlatformClutterAnimation::setValues):
(WebCore::PlatformClutterAnimation::setKeyTimes):
(WebCore::PlatformClutterAnimation::setTimingFunctions):
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore):
(WebCore::PlatformClutterAnimation::addClutterKeyframeTransitionForProperty):
(WebCore::PlatformClutterAnimation::addOpacityTransition):
(WebCore::PlatformClutterAnimation::addTransformTransition):
(WebCore::PlatformClutterAnimation::addAnimationForKey):
(WebCore::PlatformClutterAnimation::removeAnimationForKey):
- platform/graphics/clutter/PlatformClutterAnimation.h:
(PlatformClutterAnimation):
- 8:55 AM Changeset in webkit [143342] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing test.
- platform/qt/TestExpectations:
- 8:50 AM Changeset in webkit [143341] by
-
- 8 edits in trunk/Source/WebKit2
[GTK] Move the API to get TLS certificate from WebKitURIResponse to WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=110190
Reviewed by Anders Carlsson.
Add webkit_web_view_get_tls_info() and remove
webkit_uri_response_get_https_status(). This way I can be sure
that when called after load has been committed the certificate
will be available. It also makes the API easier to use.
- UIProcess/API/gtk/WebKitURIResponse.cpp:
- UIProcess/API/gtk/WebKitURIResponse.h:
- UIProcess/API/gtk/WebKitURIResponsePrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewLoadChanged):
(mainResourceResponseChangedCallback):
(webkit_web_view_get_tls_info):
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestSSL.cpp:
- 8:50 AM Changeset in webkit [143340] by
-
- 1 edit in trunk/Source/WebKit/win/ChangeLog
Unreviewed, adding external symbol ?didBeginFrame@InspectorCanvasAgent@WebCore@@QAEXXZ.
- WebKit.vcproj/WebKitExports.def.in:
- 8:48 AM Changeset in webkit [143339] by
-
- 8 edits in trunk/Source/WebKit2
[WK2][EFL] Eliminate access to WK2 C++ internals from ewk_view functions
https://bugs.webkit.org/show_bug.cgi?id=109794
Reviewed by Anders Carlsson.
- UIProcess/API/C/efl/WKView.cpp:
(WKViewSetShowsAsSource):
(WKViewGetShowsAsSource):
Added new WKView API to wrap WebPageProxy::setMainFrameInViewSourceMode()
and WebPageProxy::mainFrameInViewSourceMode() calls.
(WKViewExitFullScreen):
Added new WKView API to wrap WebFullScreenManagerProxy::exitFullScreen()
calls.
- UIProcess/API/C/efl/WKView.h:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::feedTouchEvent):
Added feedTouchEvent() method so that: at first ewk_view_feed_touch_event()
is not invoked from EwkView class, secondly ewk_view_feed_touch_event() does
not access WebPage instance directly.
(EwkView::feedTouchEvents):
- UIProcess/API/efl/EwkView.h:
(EwkView):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_feed_touch_event):
(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):
(ewk_view_fullscreen_exit):
(ewkViewPageContentsCallback):
(ewk_view_page_contents_get):
(ewk_view_source_mode_set):
(ewk_view_source_mode_get):
Those are now using exported C API.
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::setShowsAsSource):
(WebKit):
(WebKit::WebView::showsAsSource):
(WebKit::WebView::exitFullScreen):
- UIProcess/efl/WebView.h:
(WebView):
Added WebView methods to support added WKView API.
- 8:47 AM Changeset in webkit [143338] by
-
- 2 edits in trunk/Source/WebKit/win
Unreviewed, Web Inspector: follow up to r143328 fixing Win Debug Build
https://bugs.webkit.org/show_bug.cgi?id=110227
Adding external symbol ?didBeginFrame@InspectorCanvasAgent@WebCore@@QAEXXZ.
- WebKit.vcproj/WebKitExports.def.in:
- 8:27 AM Changeset in webkit [143337] by
-
- 2 edits in trunk/Source/WebCore
[harfbuzz] Crash in harfbuzz related code
https://bugs.webkit.org/show_bug.cgi?id=110145
Reviewed by Martin Robinson.
Patch by Behdad Esfahbod <behdad@google.com>
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Ask harfbuzz
to guess the segment properties.
- 8:27 AM Changeset in webkit [143336] by
-
- 188 edits47 adds23 deletes in trunk/LayoutTests
Test Expectations update after r143267 and others
Unreviewed expectations update.
Updated many Chromium expectations, and removed superfluous
expectations from mac and win.
- editing/selection/extend-by-sentence-001-expected.txt: Added.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-linux-x86/svg/filters/big-sized-filter-2-expected.png: Removed.
- platform/chromium-linux-x86/svg/filters/shadow-on-filter-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug1188-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug1318-expected.png: Removed.
- platform/chromium-linux/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-linux/svg/batik/text/xmlSpace-expected.txt:
- platform/chromium-linux/svg/filters/big-sized-filter-2-expected.png: Removed.
- platform/chromium-linux/svg/filters/shadow-on-filter-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
- platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.txt:
- platform/chromium-mac-lion/editing/selection/extend-by-sentence-001-expected.png:
- platform/chromium-mac-lion/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
- platform/chromium-mac-lion/svg/filters/filter-on-tspan-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/extend-by-sentence-001-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/filters/big-sized-filter-2-expected.png: Removed.
- platform/chromium-mac-snowleopard/svg/filters/filter-on-tspan-expected.png:
- platform/chromium-mac-snowleopard/svg/filters/shadow-on-filter-expected.png: Removed.
- platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.png:
- platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.txt: Added.
- platform/chromium-mac/fast/inline/drawStyledEmptyInlines-expected.txt: Added.
- platform/chromium-mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/chromium-mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt: Added.
- platform/chromium-mac/fast/text/capitalize-empty-generated-string-expected.txt: Added.
- platform/chromium-mac/fast/text/whitespace/006-expected.txt: Added.
- platform/chromium-mac/fast/text/whitespace/007-expected.txt: Added.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added property svn:mime-type.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
- platform/chromium-mac/svg/batik/text/xmlSpace-expected.txt: Added.
- platform/chromium-mac/svg/custom/visibility-override-filter-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
- platform/chromium-mac/svg/filters/big-sized-filter-2-expected.png:
- platform/chromium-mac/svg/filters/feImage-reference-svg-primitive-expected.png:
- platform/chromium-mac/svg/filters/filter-on-tspan-expected.png:
- platform/chromium-mac/svg/filters/filterRes1-expected.png:
- platform/chromium-mac/svg/filters/filterRes3-expected.png:
- platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png:
- platform/chromium-mac/svg/filters/shadow-on-filter-expected.png:
- platform/chromium-mac/svg/filters/shadow-on-rect-with-filter-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug113235-3-expected.txt: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.
- platform/chromium-win-xp/svg/filters/big-sized-filter-2-expected.png: Removed.
- platform/chromium-win-xp/svg/filters/shadow-on-filter-expected.png: Removed.
- platform/chromium-win/editing/selection/extend-by-sentence-001-expected.txt:
- platform/chromium-win/fast/inline/drawStyledEmptyInlines-expected.txt:
- platform/chromium-win/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/chromium-win/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
- platform/chromium-win/fast/text/capitalize-empty-generated-string-expected.txt:
- platform/chromium-win/fast/text/whitespace/006-expected.txt:
- platform/chromium-win/fast/text/whitespace/007-expected.txt:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
- platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
- platform/chromium-win/svg/filters/big-sized-filter-2-expected.png:
- platform/chromium-win/svg/filters/feImage-reference-svg-primitive-expected.png:
- platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
- platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug113235-3-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug1318-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/editing/selection/extend-by-sentence-001-expected.txt: Removed.
- platform/chromium/fast/inline/drawStyledEmptyInlines-expected.txt: Removed.
- platform/chromium/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt: Removed.
- platform/chromium/fast/text/capitalize-empty-generated-string-expected.txt: Removed.
- platform/chromium/fast/text/whitespace/006-expected.txt: Removed.
- platform/chromium/fast/text/whitespace/007-expected.txt: Removed.
- platform/chromium/svg/batik/text/xmlSpace-expected.txt: Removed.
- platform/chromium/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Removed.
- platform/chromium/tables/mozilla/bugs/bug113235-3-expected.txt: Removed.
- platform/efl-wk2/svg/filters: Added.
- platform/efl-wk2/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
- platform/efl/svg/filters/shadow-on-rect-with-filter-expected.png: Removed.
- platform/gtk/editing/selection/extend-by-sentence-001-expected.txt: Removed.
- platform/mac/TestExpectations:
- platform/mac/editing/selection/extend-by-sentence-001-expected.txt: Removed.
- platform/win/TestExpectations:
- 8:26 AM Changeset in webkit [143335] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] ASSERT(node) hit in WebPage::findZoomableAreaForPoint if no zoomable area found
https://bugs.webkit.org/show_bug.cgi?id=110220
Reviewed by Allan Sandfeld Jensen.
If EventHandler::bestZoomableAreaForTouchPoint was unsuccessfull, eg.
no node was found for a given point, we hit ASSERT(node).
We should only assert for a valid node if a zoomable area was found.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::findZoomableAreaForPoint):
- 8:12 AM Changeset in webkit [143334] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: release backtrace object group on each step.
https://bugs.webkit.org/show_bug.cgi?id=110223
Reviewed by Pavel Feldman.
- inspector/InspectorDebuggerAgent.cpp:
(WebCore):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):
- 8:01 AM Changeset in webkit [143333] by
-
- 12 edits3 deletes in trunk
Unreviewed, rolling out r142975.
http://trac.webkit.org/changeset/142975
https://bugs.webkit.org/show_bug.cgi?id=110225
Introduces hard-to-reproduce crashes upon inspected page
navigation on Mac (Requested by apavlov on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19
Source/WebCore:
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::enable):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::collectStyleSheets):
(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::detectOrigin):
(WebCore::InspectorCSSAgent::buildObjectForRule):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
- inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getViaInspectorResourceForRule):
(WebInspector.CSSStyleModelResourceBinding.prototype.):
(WebInspector.CSSStyleModelResourceBinding.prototype.requestStyleSheetIdForResource):
(WebInspector.CSSStyleModelResourceBinding.prototype.requestResourceURLForStyleSheetId):
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetIdForResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._loadStyleSheetHeaders):
(WebInspector.CSSStyleModelResourceBinding.prototype.headersLoaded):
(WebInspector.CSSStyleModelResourceBinding.prototype._requestViaInspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._getOrCreateInspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._reset):
- inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping.prototype._styleSheetChanged.callback):
(WebInspector.SASSSourceMapping.prototype._styleSheetChanged):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode.callback):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):
- inspector/front-end/StylesSourceMapping.js:
(WebInspector.StyleContentBinding.prototype.callback):
(WebInspector.StyleContentBinding.prototype.setStyleContent):
(WebInspector.StyleContentBinding.prototype.):
(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):
LayoutTests:
- inspector/styles/resources/stylesheet-tracking.css: Removed.
- inspector/styles/stylesheet-tracking-expected.txt: Removed.
- inspector/styles/stylesheet-tracking.html: Removed.
- 7:53 AM Changeset in webkit [143332] by
-
- 2 edits in trunk/Source/WebKit2
Regression(r143273): Caused a lot of tests to time out
https://bugs.webkit.org/show_bug.cgi?id=110212
Reviewed by Anders Carlsson.
StorageManager::destroySessionStorageNamespace() and StorageManager::cloneSessionStorageNamespace()
should call their respective "*Internal" equivalent instead of calling themselves. This lead to
a lot of time outs on our build bots.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::destroySessionStorageNamespace):
(WebKit::StorageManager::cloneSessionStorageNamespace):
- 7:41 AM QtWebKitBuildBots edited by
- (diff)
- 7:36 AM Changeset in webkit [143331] by
-
- 4 edits2 adds in trunk
RenderGrid::computedUsedBreadthOfGridTracks can read past m_grid's size
https://bugs.webkit.org/show_bug.cgi?id=110126
Reviewed by Ojan Vafai.
Source/WebCore:
The issue comes from how we store the column information inside m_grid.
Because m_grid is a Vector of rows, we could lose the column information
if we had no row, no grid item but some columns defined in CSS. As the
logic would assume that our row / column size would be greater than what
the style defines explicitely, we would access past our Vector's boundary.
The fix is to ensure that we have at least a row so that we can store the
column information in every case. This fix is overly broad as it also forces
the grid to have one column, which shouldn't be an issue.
Test: fast/css-grid-layout/grid-element-empty-row-column.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::maximumIndexInDirection):
Forced this function to return at least one as the maximum index so that
m_grid has at least one row / column.
(WebCore::RenderGrid::placeItemsOnGrid):
Added a ASSERT that m_grid is bigger than the explicit grid-rows / grid-columns.
Also changed an existing ASSERT to use gridWasPopulated for consistency and changed
the code not to call gridRowCount as it would ASSERT (we are in the middle of populating
the grid).
- rendering/RenderGrid.h:
(WebCore::RenderGrid::gridWasPopulated):
Added this helper function.
(WebCore::RenderGrid::gridColumnCount):
Replaced a now unneeded branch with an ASSERT. As placeItemsOnGrid should be called
prior to read m_grid, this change should be fine.
(WebCore::RenderGrid::gridRowCount):
Added an ASSERT.
LayoutTests:
- fast/css-grid-layout/grid-element-empty-row-column-expected.txt: Added.
- fast/css-grid-layout/grid-element-empty-row-column.html: Added.
- 7:19 AM Changeset in webkit [143330] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding a crash expectation for the layout test
added in r143303. The test is crashing due to missing bits of EventSender implementation.
- 7:16 AM Changeset in webkit [143329] by
-
- 2 edits in trunk/Source/WebCore
[Soup] Use synchronous calls to close completely processed streams
https://bugs.webkit.org/show_bug.cgi?id=107432
Reviewed by Martin Robinson.
There is no need to close already processed streams in asynchronous
calls since they won't block. Using the synchronous call will save
us some code and unnecessary asynchronous burden. This is kind of
a code refactor so no new tests needed.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore):
(WebCore::redirectSkipCallback):
(WebCore::readCallback):
- 7:13 AM Changeset in webkit [143328] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: [Canvas] use timeline's didBeginFrame for marking frame end calls
https://bugs.webkit.org/show_bug.cgi?id=110130
Reviewed by Pavel Feldman.
In Web Inspector canvas profiler use timeline's didBeginFrame for marking frame end calls instead of an ad-hoc timeout-based solution.
- inspector/InjectedScriptCanvasModule.cpp:
(WebCore::InjectedScriptCanvasModule::markFrameEnd):
(WebCore):
- inspector/InjectedScriptCanvasModule.h:
(InjectedScriptCanvasModule):
- inspector/InjectedScriptCanvasModuleSource.js:
(.):
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::hasUninstrumentedCanvases):
(WebCore::InspectorCanvasAgent::notifyRenderingContextWasWrapped):
(WebCore::InspectorCanvasAgent::findFramesWithUninstrumentedCanvases):
(WebCore::InspectorCanvasAgent::frameNavigated):
(WebCore::InspectorCanvasAgent::didBeginFrame):
(WebCore):
- inspector/InspectorCanvasAgent.h:
(InspectorCanvasAgent):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::didBeginFrame):
- 6:59 AM Changeset in webkit [143327] by
-
- 12 edits2 adds in trunk
Web Inspector: Decouple various file system project implementation parts for better testability and cover with tests.
https://bugs.webkit.org/show_bug.cgi?id=110204
Reviewed by Pavel Feldman.
Source/WebCore:
Extracted FileSystemWorkspaceProvider from IsolatedFileSystemManager to take care of managing workspace projects and projectDelegates.
Replaced FileMapping.urlForURI with urlForPath method that does not need any information about workspace structure anymore.
Test: inspector/file-system-project.html
- inspector/front-end/FileMapping.js:
(WebInspector.FileMapping.prototype.urlForPath):
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype.populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):
(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemRemoved):
- inspector/front-end/IsolatedFileSystem.js:
(WebInspector.IsolatedFileSystem):
(WebInspector.IsolatedFileSystem.prototype.name):
(WebInspector.IsolatedFileSystem.prototype.rootURL):
- inspector/front-end/IsolatedFileSystemManager.js:
(WebInspector.IsolatedFileSystemManager):
(WebInspector.IsolatedFileSystemManager.prototype._innerAddFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemRemoved):
(WebInspector.IsolatedFileSystemManager.prototype._isolatedFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype.requestDOMFileSystem):
- inspector/front-end/inspector.js:
LayoutTests:
- http/tests/inspector/inspector-test.js:
(initialize_InspectorTest):
(initialize_InspectorTest.):
- http/tests/inspector/workspace-test.js:
(initialize_WorkspaceTest.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
- inspector/file-mapping-expected.txt:
- inspector/file-mapping.html:
- inspector/file-system-project-expected.txt: Added.
- inspector/file-system-project.html: Added.
- inspector/version-controller.html:
- 6:43 AM Changeset in webkit [143326] by
-
- 3 edits in trunk/Tools
[Qt] Skip the build with a warning if certain tools cannot be found in the PATH
https://bugs.webkit.org/show_bug.cgi?id=110215
Reviewed by Tor Arne Vestbø.
Check that gperf, python, ruby, perl, bison and flex are in the PATH before
continuing the build. Otherwise skip with an error message explaining which
programs are missing from the build.
- qmake/mkspecs/features/configure.prf:
- qmake/mkspecs/features/functions.prf:
- 6:31 AM Changeset in webkit [143325] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Canvas] do not replace replay image with spinner icon
https://bugs.webkit.org/show_bug.cgi?id=110213
Reviewed by Pavel Feldman.
Otherwise it's visually hard to see changes in the replay image. Instead show a small spinner icon in the bottom right corner.
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype._enableWaitIcon):
- inspector/front-end/canvasProfiler.css:
(#canvas-replay-image-container):
(.canvas-debug-info):
(.canvas-spinner-icon):
- 6:29 AM Changeset in webkit [143324] by
-
- 5 edits in trunk
Web Inspector: [Canvas] UI: tweak replay control buttons behavior
https://bugs.webkit.org/show_bug.cgi?id=110207
Reviewed by Pavel Feldman.
Source/WebCore:
New behavior for control buttons in the Canvas profiler.
- The NextCall button (~StepInto) on a node group should expand it and move into its first child (instead of expanding and moving into the next node group)
- The NextDrawCall button (~StepOver) should move to a next node that has children (instead of just iterating call group nodes, ignoring frame nodes).
- The ReplayLast button should select the last expanded node (instead of always selecting last frame group node).
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype._onReplayStepClick):
(WebInspector.CanvasProfileView.prototype._onReplayDrawingCallClick):
(WebInspector.CanvasProfileView.prototype._onReplayLastStepClick):
LayoutTests:
Testing control buttons behavior.
- inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt:
- inspector/profiler/canvas2d/canvas-replay-log-grid.html:
- 5:54 AM Changeset in webkit [143323] by
-
- 3 edits42 deletes in trunk
Unreviewed, rolling out r143319.
http://trac.webkit.org/changeset/143319
https://bugs.webkit.org/show_bug.cgi?id=110214
Causes build issues on win32 (Requested by carewolf on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19
Tools:
- qmake/mkspecs/features/features.pri:
LayoutTests:
- platform/qt/mathml/presentation/attributes-expected.png: Removed.
- platform/qt/mathml/presentation/attributes-expected.txt: Removed.
- platform/qt/mathml/presentation/fenced-expected.png: Removed.
- platform/qt/mathml/presentation/fenced-expected.txt: Removed.
- platform/qt/mathml/presentation/fenced-mi-expected.png: Removed.
- platform/qt/mathml/presentation/fenced-mi-expected.txt: Removed.
- platform/qt/mathml/presentation/fractions-expected.png: Removed.
- platform/qt/mathml/presentation/fractions-expected.txt: Removed.
- platform/qt/mathml/presentation/fractions-vertical-alignment-expected.png: Removed.
- platform/qt/mathml/presentation/fractions-vertical-alignment-expected.txt: Removed.
- platform/qt/mathml/presentation/mo-expected.png: Removed.
- platform/qt/mathml/presentation/mo-expected.txt: Removed.
- platform/qt/mathml/presentation/mo-stretch-expected.png: Removed.
- platform/qt/mathml/presentation/mo-stretch-expected.txt: Removed.
- platform/qt/mathml/presentation/mroot-pref-width-expected.png: Removed.
- platform/qt/mathml/presentation/mroot-pref-width-expected.txt: Removed.
- platform/qt/mathml/presentation/over-expected.png: Removed.
- platform/qt/mathml/presentation/over-expected.txt: Removed.
- platform/qt/mathml/presentation/roots-expected.png: Removed.
- platform/qt/mathml/presentation/roots-expected.txt: Removed.
- platform/qt/mathml/presentation/row-alignment-expected.png: Removed.
- platform/qt/mathml/presentation/row-alignment-expected.txt: Removed.
- platform/qt/mathml/presentation/row-expected.png: Removed.
- platform/qt/mathml/presentation/row-expected.txt: Removed.
- platform/qt/mathml/presentation/style-expected.png: Removed.
- platform/qt/mathml/presentation/style-expected.txt: Removed.
- platform/qt/mathml/presentation/sub-expected.png: Removed.
- platform/qt/mathml/presentation/sub-expected.txt: Removed.
- platform/qt/mathml/presentation/subsup-expected.png: Removed.
- platform/qt/mathml/presentation/subsup-expected.txt: Removed.
- platform/qt/mathml/presentation/sup-expected.png: Removed.
- platform/qt/mathml/presentation/sup-expected.txt: Removed.
- platform/qt/mathml/presentation/tables-expected.png: Removed.
- platform/qt/mathml/presentation/tables-expected.txt: Removed.
- platform/qt/mathml/presentation/tokenElements-expected.png: Removed.
- platform/qt/mathml/presentation/tokenElements-expected.txt: Removed.
- platform/qt/mathml/presentation/under-expected.png: Removed.
- platform/qt/mathml/presentation/under-expected.txt: Removed.
- platform/qt/mathml/presentation/underover-expected.png: Removed.
- platform/qt/mathml/presentation/underover-expected.txt: Removed.
- platform/qt/mathml/xHeight-expected.png: Removed.
- platform/qt/mathml/xHeight-expected.txt: Removed.
- 5:49 AM AddingFeatures edited by
- wtf/FeatureDefines.h has the defaults for all the feature flags (diff)
- 5:44 AM Changeset in webkit [143322] by
-
- 5 edits2 adds in trunk
[CSS Regions] Assertion in RenderFlowThread::removeRenderBoxRegionInfo
https://bugs.webkit.org/show_bug.cgi?id=109914
Reviewed by David Hyatt.
Source/WebCore:
This patch moves a part of the invalidation operations inside the RenderFlowThread::invalidateRegions call. The maps
are cleared anyway at layout time but doing this earlier makes sure the flow thread is in a more consistent state
(the RenderFlowThread object has both the region chain invalidated and the regions information cleared).
RenderFlowThread::removeRenderBoxRegionInfo will check if the region chain is invalidated. If true, it means the
flow thread has a layout scheduled and the regions information is not yet reliable. In this case we just return from the
function and wait for the layout to cleanup the box information.
Test: fast/regions/remove-box-info-assert.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
- rendering/RenderFlowThread.h:
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
LayoutTests:
The test creates a flow thread with two regions and a content node. We remove the region and the node from the flow thread
at the same time. When the style is updated, the region is first removed from the chain and range information for boxes
is cleared from the flow thread. When the node is removed from the flow thread it tries to delete its region box information.
The range information on the flow thread is gone so the range for the node's box is zero - nothing gets deleted. Afterwards,
an ASSERT is triggered because there's leftover box information inside the region chain.
- fast/regions/remove-box-info-assert-expected.txt: Added.
- fast/regions/remove-box-info-assert.html: Added.
- 5:30 AM Changeset in webkit [143321] by
-
- 10 edits3 copies2 moves5 adds in trunk/LayoutTests
[chromium] Unreviewed gardening.
New baselines for effect-reference.html and effect-reference-hw.html
- platform/chromium-linux-x86/css3/filters/effect-reference-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/effect-reference-expected.txt: Copied from LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.txt.
- platform/chromium-linux/css3/filters/effect-reference-expected.png: Added.
- platform/chromium-linux/css3/filters/effect-reference-expected.txt: Copied from LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.txt.
- platform/chromium-linux/css3/filters/effect-reference-hw-expected.png:
- platform/chromium-mac-lion/css3/filters/effect-reference-expected.png: Added.
- platform/chromium-mac-lion/css3/filters/effect-reference-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/css3/filters/effect-reference-hw-expected.txt.
- platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/css3/filters/effect-reference-hw-expected.txt.
- platform/chromium-mac/css3/filters/effect-reference-expected.png:
- platform/chromium-mac/css3/filters/effect-reference-expected.txt:
- platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
- platform/chromium-win-xp/css3/filters/effect-reference-expected.png: Added.
- platform/chromium-win-xp/css3/filters/effect-reference-expected.txt: Copied from LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.txt.
- platform/chromium-win/css3/filters/effect-reference-expected.png:
- platform/chromium-win/css3/filters/effect-reference-expected.txt:
- platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
- platform/chromium-win/css3/filters/effect-reference-hw-expected.txt:
- 5:15 AM Changeset in webkit [143320] by
-
- 2 edits in trunk/Source/WebCore
Fix build broekn by r142988.
https://bugs.webkit.org/show_bug.cgi?id=109530
Unreviewed. Build fix.
Properly add shortMonthFormat() to the LocaleNone class.
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-02-19
- platform/text/LocaleNone.cpp:
(LocaleNone):
(WebCore::LocaleNone::shortMonthFormat):
- 5:02 AM Changeset in webkit [143319] by
-
- 3 edits44 adds in trunk
[Qt] Enable MathML
https://bugs.webkit.org/show_bug.cgi?id=110205
Reviewed by Simon Hausmann.
Tools:
- qmake/mkspecs/features/features.pri:
LayoutTests:
Baselines for the MathML tests.
- platform/qt/mathml/presentation/attributes-expected.png: Added.
- platform/qt/mathml/presentation/attributes-expected.txt: Added.
- platform/qt/mathml/presentation/fenced-expected.png: Added.
- platform/qt/mathml/presentation/fenced-expected.txt: Added.
- platform/qt/mathml/presentation/fenced-mi-expected.png: Added.
- platform/qt/mathml/presentation/fenced-mi-expected.txt: Added.
- platform/qt/mathml/presentation/fractions-expected.png: Added.
- platform/qt/mathml/presentation/fractions-expected.txt: Added.
- platform/qt/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
- platform/qt/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
- platform/qt/mathml/presentation/mo-expected.png: Added.
- platform/qt/mathml/presentation/mo-expected.txt: Added.
- platform/qt/mathml/presentation/mo-stretch-expected.png: Added.
- platform/qt/mathml/presentation/mo-stretch-expected.txt: Added.
- platform/qt/mathml/presentation/mroot-pref-width-expected.png: Added.
- platform/qt/mathml/presentation/mroot-pref-width-expected.txt: Added.
- platform/qt/mathml/presentation/over-expected.png: Added.
- platform/qt/mathml/presentation/over-expected.txt: Added.
- platform/qt/mathml/presentation/roots-expected.png: Added.
- platform/qt/mathml/presentation/roots-expected.txt: Added.
- platform/qt/mathml/presentation/row-alignment-expected.png: Added.
- platform/qt/mathml/presentation/row-alignment-expected.txt: Added.
- platform/qt/mathml/presentation/row-expected.png: Added.
- platform/qt/mathml/presentation/row-expected.txt: Added.
- platform/qt/mathml/presentation/style-expected.png: Added.
- platform/qt/mathml/presentation/style-expected.txt: Added.
- platform/qt/mathml/presentation/sub-expected.png: Added.
- platform/qt/mathml/presentation/sub-expected.txt: Added.
- platform/qt/mathml/presentation/subsup-expected.png: Added.
- platform/qt/mathml/presentation/subsup-expected.txt: Added.
- platform/qt/mathml/presentation/sup-expected.png: Added.
- platform/qt/mathml/presentation/sup-expected.txt: Added.
- platform/qt/mathml/presentation/tables-expected.png: Added.
- platform/qt/mathml/presentation/tables-expected.txt: Added.
- platform/qt/mathml/presentation/tokenElements-expected.png: Added.
- platform/qt/mathml/presentation/tokenElements-expected.txt: Added.
- platform/qt/mathml/presentation/under-expected.png: Added.
- platform/qt/mathml/presentation/under-expected.txt: Added.
- platform/qt/mathml/presentation/underover-expected.png: Added.
- platform/qt/mathml/presentation/underover-expected.txt: Added.
- platform/qt/mathml/xHeight-expected.png: Added.
- platform/qt/mathml/xHeight-expected.txt: Added.
- 4:45 AM Changeset in webkit [143318] by
-
- 6 edits in trunk
[Text Autosizing] Combine narrow descendants of a cluster into groups that should be autosized with the same multiplier.
https://bugs.webkit.org/show_bug.cgi?id=109825
Source/WebCore:
Enhancement of the approach introduced in https://bugs.webkit.org/show_bug.cgi?id=109573.
Instead of using the same text size multiplier for all narrow descendants of any autosizing
cluster, group the descendants by how much narrower they are than the cluster's
|blockContainingAllText| and process each group separately with a different multiplier for
each one.
For example, we want nested comments on the page to be autosized as a group but separately
from a sidebar on the same page.
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.
Updated the existing test to verify the patch.
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processClusterInternal):
Splits the narrow descendants of the autosizing cluster into groups before processing
each group individually.
(WebCore::TextAutosizer::getNarrowDescendantsGroupedByWidth):
Sorts the narrow descendants of the given cluster into groups, combining them by the
difference between their content widths. If sorted by width, two consecutive nodes
belong to the same group if their width difference is no greater than 100 CSS units.
- rendering/TextAutosizer.h:
New method definitions.
LayoutTests:
Verify that narrow descendants are grouped and autosized separately according to the
difference between the descendant's width and the width of its enclosing cluster's
|blockContainingAllText|.
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.
- fast/text-autosizing/narrow-descendants-combined-expected.html:
- fast/text-autosizing/narrow-descendants-combined.html:
- 4:21 AM Changeset in webkit [143317] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Native Memory Instrumentation: show user provided name property of the heap snapshot node.
https://bugs.webkit.org/show_bug.cgi?id=110124
Reviewed by Yury Semikhatsky.
Publish userProvidedName into grid node.
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker):
- inspector/front-end/NativeHeapSnapshot.js:
(WebInspector.NativeHeapSnapshotNode.prototype.serialize):
- 4:15 AM Changeset in webkit [143316] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 3:46 AM Changeset in webkit [143315] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening for chromium.
https://bugs.webkit.org/show_bug.cgi?id=110203
- platform/chromium/TestExpectations:
- 2:41 AM Changeset in webkit [143314] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION(r143241): It made 27 layout tests crash on 32 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=110184
Reviewed by Zoltan Herczeg.
32-bit backend was making all sorts of crazy assumptions, which happened to mostly
not break things prior to http://trac.webkit.org/changeset/143241. This brings the
32-bit backend's type speculation fully into compliance with what the 64-bit
backend does.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
- 2:14 AM Changeset in webkit [143313] by
-
- 3 edits2 adds in trunk
Caret is not displayed when trying to focus inside a contenteditable element containing an empty block.
https://bugs.webkit.org/show_bug.cgi?id=108053
Source/WebCore:
Patch by Arpita Bahuguna <a.bah@samsung.com> on 2013-02-19
Reviewed by Ryosuke Niwa.
Test: editing/selection/caret-in-div-containing-empty-block.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::localCaretRect):
When trying to compute the caret rect for the contenteditable div, the
border and the padding were not considered. Because of this, for the
given test case, which had a border defined on the containing div, the
caret was being painted just atop the border, thereby masking it.
Have modified the code to ensure that the computed caret rect takes
into account the border and padding (if any) specified on the box, but only
if the node doesn't have content that shall be skipped for editing.
We do not add border and padding while computing the caret rect for any
element that either has no content or has content that shall be skipped
for editing purposes. This holds true for table elements as well.
This helps avoid the caret displacement previsouly observed before/after
any controls placed within the contenteditable box, when considering
border and padding in computation of the caret rect.
LayoutTests:
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2013-02-19
Reviewed by Ryosuke Niwa.
- editing/selection/caret-in-div-containing-empty-block-expected.txt: Added.
- editing/selection/caret-in-div-containing-empty-block.html: Added.
Layout test added for verifying that a caret is displayed within a
contenteditable div having a border, both for the horizontal
as well as the vertical writing modes.
- 1:56 AM Changeset in webkit [143312] by
-
- 4 edits2 adds in trunk
CSSRegions: crash positioned object with inline containing block in flow thread
https://bugs.webkit.org/show_bug.cgi?id=108307
Reviewed by David Hyatt.
Source/WebCore:
The fix for https://bugs.webkit.org/show_bug.cgi?id=69896 allowed positioned blocks work
with variable width regions. However, the information needed for that is available only
when the container used for positioning is a block.
This patch ensures we are using this solution only when the container used for positioning
is a block. This needs to be revisited when we will extend support for other types of boxes
as mentioned in RenderBox::renderBoxRegionInfo.
Test: fast/regions/positioned-object-inline-cb-crash.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth): Make sure we are using containerBlocks
that are blocks. Add an assert that the type of containerBlock we are using can have
computed RenderBoxRegionInfo.
(WebCore::RenderBox::computePositionedLogicalHeight):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::canHaveBoxInfoInRegion): This helper method
will return the boxes that may have computed RenderBoxRegionInfo. Currently,
returns true for blocks only.
LayoutTests:
- fast/regions/positioned-object-inline-cb-crash-expected.txt: Added.
- fast/regions/positioned-object-inline-cb-crash.html: Added.
- 1:31 AM Changeset in webkit [143311] by
-
- 2 edits in trunk/Tools
Unreviewed, updated spelling of my name.
- Scripts/webkitpy/common/config/committers.py:
- 1:27 AM Changeset in webkit [143310] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] fix ScrollAnimatorNoneTest after r143295
https://bugs.webkit.org/show_bug.cgi?id=110189
Reviewed by Nico Weber.
- tests/ScrollAnimatorNoneTest.cpp:
(MockScrollableArea):
- 1:22 AM Changeset in webkit [143309] by
-
- 2 edits in trunk/Source/WebCore
Yet anther JSC build fix after r143304.
- bindings/js/JSDOMBinding.h:
(WebCore::argumentOrNull):
- 1:00 AM Changeset in webkit [143308] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix. Fixed warning caused by r143305.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
- 12:55 AM Changeset in webkit [143307] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding a failure expectation for the failing
fast/regions/seamless-iframe-flowed-into-regions.html added in r143256.
- 12:23 AM Changeset in webkit [143306] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r143304.
- bindings/js/JSDOMBinding.h:
(WebCore::argumentOrNull):
- 12:21 AM Changeset in webkit [143305] by
-
- 16 edits in trunk/Source/WebCore
[V8] Remove redundant usage of MAYBE_MISSING_PARAMETER() macro
https://bugs.webkit.org/show_bug.cgi?id=109899
Reviewed by Adam Barth.
Currently:
- MAYBE_MISSING_PARAMETER(args, index, DefaultIsUndefined) returns args[index].
- MAYBE_MISSING_PARAMETER(args, index, DefaultIsNullString) returns Local<Value>()
if args[index] is missing (i.e. the length of |args| is less than |index|).
It returns args[index] otherwise.
No one other than CodeGeneratorV8.pm uses
MAYBE_MISSING_PARAMETER(args, index, DefaultIsUndefined). Instead, we simply use
args[index]. We should remove the redundant usage from CodeGeneratorV8.pm too.
The long-name macro has been making generated code less readable.
In addition, we can rename MAYBE_MISSING_PARAMETER() to argumentOrNull().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooCallback):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::TestMediaQueryListListenerV8Internal::methodCallback):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::TestObjV8Internal::methodWithOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::overloadedMethod10Callback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::classMethodWithOptionalCallback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
(WebCore::TestObjV8Internal::domStringListFunctionCallback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::TestObjV8Internal::variadicStringMethodCallback):
(WebCore::TestObjV8Internal::variadicDoubleMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):
(WebCore::V8TestOverloadedConstructors::constructor4Callback):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::funcCallback):
(WebCore::TestTypedefsV8Internal::setShadowCallback):
(WebCore::TestTypedefsV8Internal::methodWithSequenceArgCallback):
(WebCore::TestTypedefsV8Internal::nullableArrayArgCallback):
(WebCore::TestTypedefsV8Internal::stringArrayFunctionCallback):
(WebCore::TestTypedefsV8Internal::stringArrayFunction2Callback):
(WebCore::V8TestTypedefs::constructorCallback):
- bindings/v8/V8BindingMacros.h:
(WebCore):
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateCallbackCustom):
(WebCore::V8History::replaceStateCallbackCustom):
- 12:12 AM Changeset in webkit [143304] by
-
- 14 edits in trunk/Source/WebCore
[JSC] MAYBE_MISSING_PARAMETER(..., DefaultIsNullString) macro is redundant
https://bugs.webkit.org/show_bug.cgi?id=109902
Reviewed by Adam Barth.
Currently:
- MAYBE_MISSING_PARAMETER(exec, index, DefaultIsUndefined) returns exec->argument(index).
- MAYBE_MISSING_PARAMETER(exec, index, DefaultIsNullString) returns JSValue() if exec->argument(index) is missing (i.e. the length of the argument is less than index). It returns exec->argument(index) otherwise.
No one other than CodeGeneratorJS.pm uses
MAYBE_MISSING_PARAMETER(exec, index, DefaultIsUndefined).
Instead, we simply use exec->argument(index). We should remove
the redundant usage in CodeGeneratorJS.pm too. The long-name macro
has been making generated code less readable.
In addition, we can rename MAYBE_MISSING_PARAMETER() to argumentOrNull().
c.f. corresponding V8 bug: https://bugs.webkit.org/show_bug.cgi?id=109899
No tests. No change in behavior.
- bindings/js/JSDOMBinding.h:
(WebCore):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::jsFloat64ArrayPrototypeFunctionFoo):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefined):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod8):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod9):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod10):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongSequence):
(WebCore::jsTestObjPrototypeFunctionStringArrayFunction):
(WebCore::jsTestObjPrototypeFunctionDomStringListFunction):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
(WebCore::jsTestObjPrototypeFunctionVariadicStringMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicDoubleMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors1):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors2):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors3):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors4):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionMultiTransferList):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::constructJSTestTypedefs):
(WebCore::jsTestTypedefsPrototypeFunctionFunc):
(WebCore::jsTestTypedefsPrototypeFunctionMultiTransferList):
(WebCore::jsTestTypedefsPrototypeFunctionSetShadow):
(WebCore::jsTestTypedefsPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestTypedefsPrototypeFunctionNullableArrayArg):
(WebCore::jsTestTypedefsPrototypeFunctionStringArrayFunction):
(WebCore::jsTestTypedefsPrototypeFunctionStringArrayFunction2):
