Timeline
Apr 22, 2013:
- 11:51 PM Changeset in webkit [148945] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Assertion Failures in Coordinated Graphics after r148433
https://bugs.webkit.org/show_bug.cgi?id=114731
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-22
Reviewed by Gyuyoung Kim.
The assert is incorrect. In some cases in coordinated graphics we may have a backing store
and drawsContent would be set to false.
No new tests.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintSelf):
- 11:36 PM Changeset in webkit [148944] by
-
- 29 edits2 adds in trunk
table's text aligned on top instead of center because of rowspan
https://bugs.webkit.org/show_bug.cgi?id=18092
Patch by Suchit Agrawal <a.suchit@samsung.com> on 2013-04-22
Reviewed by Beth Dakin.
Source/WebCore:
Last row in the rowspan is not getting the height of rowspan cell because there is not
enough rows present below rowspan cell and we are strictly applying height of rowspan
to the row which should lay last in the rowspan based of rowspan value.
When row contains rowspan cell and it is last row of the table then
rowspan height is adding to last row of the table.
Test: fast/table/Rowspan-value-more-than-number-of-rows-present.html
It calculates logical height of the rows in the table.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
LayoutTests:
Added test cases, based on rowspan issue.
- fast/table/Rowspan-value-more-than-number-of-rows-present-expected.txt: Added.
- fast/table/Rowspan-value-more-than-number-of-rows-present.html: Added.
Test cases need to do rebaseline in efl, gtk and mac platforms.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
Test case results are updated in qt platform.
- platform/qt/fast/table/giantRowspan-expected.png:
- platform/qt/fast/table/giantRowspan-expected.txt:
- platform/qt/fast/table/giantRowspan2-expected.png:
- platform/qt/fast/table/giantRowspan2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug133756-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug133756-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug133756-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug133756-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug220536-expected.png:
- platform/qt/tables/mozilla/bugs/bug220536-expected.txt:
- platform/qt/tables/mozilla/bugs/bug8858-expected.txt:
- platform/qt/tables/mozilla/core/bloomberg-expected.png:
- platform/qt/tables/mozilla/core/bloomberg-expected.txt:
- platform/qt/tables/mozilla/core/row_span-expected.png:
- platform/qt/tables/mozilla/core/row_span-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
- tables/mozilla/core/bloomberg-expected.txt:
- tables/mozilla/core/row_span-expected.txt:
- tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- 9:52 PM Changeset in webkit [148943] by
-
- 4 edits4 adds in trunk
[CSS Regions] Region's float parent doesn't size according to region size but to content node size
https://bugs.webkit.org/show_bug.cgi?id=111332
Reviewed by David Hyatt.
Source/WebCore:
Tests: fast/regions/intrinsic-sized-regions.html
fast/regions/region-with-float-parent.html
The patch ensures that the computation of region's preferred widths
takes into account the region width/min-width if these values are specified.
Also implemented the computation of intrinsic widths for a region,
based on the min/max preferred widths of the associated flow thread.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderRegion::computePreferredLogicalWidths):
- rendering/RenderRegion.h:
(RenderRegion):
LayoutTests:
Added tests for intrinsic and preferred width computation for region.
- fast/regions/intrinsic-sized-regions-expected.txt: Added.
- fast/regions/intrinsic-sized-regions.html: Added.
- fast/regions/region-with-float-parent-expected.txt: Added.
- fast/regions/region-with-float-parent.html: Added.
- 9:47 PM Changeset in webkit [148942] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix a typo in MacroAssemblerARMv7.h.
https://bugs.webkit.org/show_bug.cgi?id=115011.
Reviewed by Geoffrey Garen.
- assembler/ARMAssembler.h: Fix a comment.
- assembler/ARMv7Assembler.h: Added some comments.
- assembler/MacroAssemblerARMv7.h:
- ARMAssembler::PL should be ARMv7Assembler::ConditionPL.
- 8:32 PM Changeset in webkit [148941] by
-
- 3 edits in trunk/Source/WTF
[CMake] Move NullPtr.cpp from PlatformWinCE.cmake to CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=114557
Reviewed by Laszlo Gombos.
This file is not specific to Windwos CE. Move it the the general
CMakeLists.txt so other ports can use it to. It does not affect
ports which do not need it, since it contains a preprocessor guard.
- wtf/CMakeLists.txt:
- wtf/PlatformWinCE.cmake:
- 7:33 PM Changeset in webkit [148940] by
-
- 4 edits in trunk/Source/WebKit
Speculative Windows build fix.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
- 7:03 PM Changeset in webkit [148939] by
-
- 7 edits in trunk/LayoutTests
Remove references to the inspector/profiler/memory-instrumentation tests removed in r148921
Rubber-stamped by Benjamin Poulain.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 6:10 PM Changeset in webkit [148938] by
-
- 5 edits in trunk/Source/WebKit2
Need WebKit SPI to detect whether a page contains form controls
<rdar://problem/13686661>
https://bugs.webkit.org/show_bug.cgi?id=115003
Reviewed by Beth Dakin.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameContainsAnyFormControls):
- WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::containsAnyFormControls):
- WebProcess/WebPage/WebFrame.h:
- 5:43 PM Changeset in webkit [148937] by
-
- 2 edits in trunk/Source/WebKit2
[Mac] REGRESSION (r142806): "Just Leaking" Console errors on launch
https://bugs.webkit.org/show_bug.cgi?id=115002
<rdar://problem/13254212>
Reviewed by Sam Weinig.
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm: (WebKit::BootstrapMain): Added an autorelease pool for code that uses Objective-C.
- 5:16 PM Changeset in webkit [148936] by
-
- 7 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Create an equivalent of Structure::get() that can work from a compilation thread
https://bugs.webkit.org/show_bug.cgi?id=114987
Reviewed by Geoffrey Garen.
This completes the work started by r148570. That patch made it possible to do
Structure::get() without modifying Structure. This patch takes this further, and
makes this thread-safe (for non-uncacheable-dictionaries) via
Structure::getConcurrently(). This method not only doesn't modify Structure, but
also ensures that any concurrent attempts to add to, remove from, or steal the
table from that structure doesn't mess up the result of the call. The call may
return invalidOffset even if a property is *just* about to be added, but it will
never do the reverse: if it returns a property then you can be sure that the
structure really does have that property and always will have it.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
- runtime/PropertyMapHashTable.h:
(PropertyTable):
(JSC::PropertyTable::findConcurrently):
(JSC):
(JSC::PropertyTable::add):
(JSC::PropertyTable::remove):
(JSC::PropertyTable::reinsert):
(JSC::PropertyTable::rehash):
- runtime/PropertyTable.cpp:
(JSC::PropertyTable::PropertyTable):
- runtime/Structure.cpp:
(JSC::Structure::findStructuresAndMapForMaterialization):
(JSC::Structure::getConcurrently):
- runtime/Structure.h:
(Structure):
- runtime/StructureInlines.h:
(JSC::Structure::getConcurrently):
- 5:16 PM Changeset in webkit [148935] by
-
- 3 edits in trunk/Source/WebKit/gtk
Try to fix the build after enabling gobject-introspection
- GNUmakefile.am: Disable --warn-error for WebKit1 until we can work out all gir failures.
- webkit/webkitwebplugin.cpp: Skip this API for introspection because it return a GSList
of pointer (non-boxed) types.
- 5:10 PM Changeset in webkit [148934] by
-
- 2 edits in trunk/Tools
<http://webkit.org/b/114989> Add a user default to allow use of the Safari binary rather than SafariForWebKitDevelopment
Reviewed by Anders Carlsson.
- Scripts/webkitdirs.pm:
(skipSafariExecutableEntitlementChecks): Look for the SkipSafariExecutableEntitlementChecks default in the
/Library/Preferences/org.webkit.BuildConfiguration preference domain.
(safariPathFromSafariBundle): If the user default is set asking us to skip the entitlement checks, return
the path to the regular Safari binary.
- 4:50 PM Changeset in webkit [148933] by
-
- 4 edits in trunk/Source/WebCore
Debug build fix.
Rubber-stamped by Ryosuke Niwa.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
- inspector/InspectorMemoryAgent.h:
(WebCore):
(WebCore::InspectorMemoryAgent::create):
(InspectorMemoryAgent):
- 4:42 PM Changeset in webkit [148932] by
-
- 2 edits in trunk/Source/WebCore
Address review feedback I forgot to address in r148929
https://bugs.webkit.org/show_bug.cgi?id=114480
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest): Rework the "what" comment into a more useful "why" comment.
- 4:40 PM Changeset in webkit [148931] by
-
- 2 edits in trunk/Tools
Unreviewed Efl build fix after r148921
- TestWebKitAPI/CMakeLists.txt:
- 4:34 PM Changeset in webkit [148930] by
-
- 3 edits in trunk/Source/WebCore
Second Mac debug build fix after r148921
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-22
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
- inspector/InspectorMemoryAgent.h:
(InspectorMemoryAgent):
- 4:28 PM Changeset in webkit [148929] by
-
- 5 edits14 adds in trunk
REGRESSION (r141136): Wiki "Random article" function very broken.
<rdar://problem/13229985> and https://bugs.webkit.org/show_bug.cgi?id=114480
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: http/tests/navigation/redirect-to-random-url-versus-memory-cache.html
If we are performing a conditional GET to revalidate a resource and there's a redirect,
check to see if the redirect is to a different URL than the final URL of the resource.
If the URLs differ then we should make the redirect-request unconditional and do a normal load.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::makeUnconditional):
- platform/network/ResourceRequestBase.h:
(ResourceRequestBase):
LayoutTests:
- http/tests/navigation/redirect-to-random-url-versus-memory-cache-expected.txt: Added.
- http/tests/navigation/redirect-to-random-url-versus-memory-cache.html: Added.
- http/tests/navigation/resources/randomredirects/0.php: Added.
- http/tests/navigation/resources/randomredirects/1.php: Added.
- http/tests/navigation/resources/randomredirects/2.php: Added.
- http/tests/navigation/resources/randomredirects/3.php: Added.
- http/tests/navigation/resources/randomredirects/4.php: Added.
- http/tests/navigation/resources/randomredirects/5.php: Added.
- http/tests/navigation/resources/randomredirects/6.php: Added.
- http/tests/navigation/resources/randomredirects/7.php: Added.
- http/tests/navigation/resources/randomredirects/8.php: Added.
- http/tests/navigation/resources/randomredirects/9.php: Added.
- http/tests/navigation/resources/randomredirects/randomredirect.php: Added.
- 4:27 PM Changeset in webkit [148928] by
-
- 2 edits in trunk/Source/WebKit/win
Another Windows build fix after r148921
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-22
- AccessibleBase.cpp: Add missing header include.
- 4:26 PM Changeset in webkit [148927] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
Skip svg/custom/mask-invalidation.svg on Mac
<rdar://problem/13711076>
Patch by David Farler <dfarler@apple.com> on 2013-04-22
- platform/mac/Skipped:
Skip svg/custom/mask-invalidation.svg
- 4:25 PM Changeset in webkit [148926] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add branchAdd32 missing implementation in SH4 base JIT.
This should fix SH4 build, broken since r148893.
https://bugs.webkit.org/show_bug.cgi?id=114993.
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-04-22
Reviewed by Oliver Hunt.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchAdd32):
(MacroAssemblerSH4):
- 4:12 PM Changeset in webkit [148925] by
-
- 2 edits in trunk/Source/WebCore
Mac debug build fix after r148921
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-22
- page/animation/CompositeAnimation.cpp:
- 4:08 PM Changeset in webkit [148924] by
-
- 3 edits in trunk/Source/JavaScriptCore
Windows build fix after r148921
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-22
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 4:06 PM Changeset in webkit [148923] by
-
- 3 edits3 adds in trunk
[Cairo] Canvas-shadow behavior is not being as expected
https://bugs.webkit.org/show_bug.cgi?id=108897
Patch by Rashmi Shyamasundar <rashmi.s2@samsung.com> on 2013-04-22
Reviewed by Martin Robinson.
Source/WebCore:
Use the pattern-extend-mode "CAIRO_EXTEND_NONE" instead of "CAIRO_EXTEND_PAD" in
PlatformContextCairo::drawSurfaceToContext().
In the function PlatformContextCairo::drawSurfaceToContext(), a pattern is being
created from the source surface and this pattern is drawn onto the destination
context. There is no gradient involved. Hence the extend mode for filling the
pattern should be "CAIRO_EXTEND_NONE". If we use the extend mode
"CAIRO_EXTEND_PAD" in PlatformContextCairo::drawSurfaceToContext(), the original
image area is also filled with the shadow color which is not the expected behavior.
Test: fast/canvas/canvas-image-shadow.html
- platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::drawSurfaceToContext):
LayoutTests:
Test to verify the shadow of an image drawn on canvas.
This test uses an image whose size is smaller than,
the size of the rectangle which should be filled with the image.
- fast/canvas/canvas-image-shadow-expected.txt: Added.
- fast/canvas/canvas-image-shadow.html: Added.
- fast/canvas/green.png: Added.
- fast/canvas/script-tests/canvas-image-shadow.js: Added.
(draw):
- 3:56 PM Changeset in webkit [148922] by
-
- 11 edits in trunk/Source/WebKit2
Web process should decide when to continue main resource loads
https://bugs.webkit.org/show_bug.cgi?id=114995
Reviewed by Sam Weinig.
Main resource loads can be converted to downloads, so we need the ability to let the web process decide when
to continue loading after a response has been received.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
For non-main resources, just call continueDidReceiveResponse directly; there's no need to ping-pong to the web process in that case.
(WebKit::NetworkResourceLoader::continueDidReceiveResponse):
Just call ResourceHandle::continueDidReceiveResponse.
- NetworkProcess/NetworkResourceLoader.messages.in:
Add ContinueDidReceiveResponse message.
- NetworkProcess/SchedulableLoader.cpp:
(WebKit::SchedulableLoader::SchedulableLoader):
Initialize m_isLoadingMainResource.
- NetworkProcess/SchedulableLoader.h:
(WebKit::SchedulableLoader::isLoadingMainResource):
Add getter.
(SchedulableLoader):
Move m_shouldClearReferrerOnHTTPSToHTTPRedirect next to the rest of the booleans.
- Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):
- Shared/Network/NetworkResourceLoadParameters.h:
(NetworkResourceLoadParameters):
Add isMainResource flag.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleSubresourceLoad):
Pass the cached resource to scheduleLoad.
(WebKit::WebResourceLoadScheduler::schedulePluginStreamLoad):
Pass null to scheduleLoad.
(WebKit::WebResourceLoadScheduler::scheduleLoad):
Initialize isMainResource.
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
If this is a main resource load, send back a ContinueDidReceiveResponse message.
- 3:52 PM Changeset in webkit [148921] by
-
- 395 edits30 deletes in trunk
Remove the memory instrumentation code
https://bugs.webkit.org/show_bug.cgi?id=114931
Reviewed by Andreas Kling.
.:
- Source/autotools/symbols.filter:
Source/JavaScriptCore:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
Source/WebCore:
The Memory Instrumentation code is unfinished and has already
become out of sync the objects it is supposed to represent.
The current approach does not seem maintainable, it is better to
remove it before someone gets hurt.
By removing the code, the binary become 1240976 bytes smaller.
Yep, almost 1 Mb, bringing WebCore to the size it has 5 months ago :)
- MostWebCoreFiles: remove the support for memory instrumentation.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/mac:
- WebView/WebRenderLayer.mm:
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
Source/WTF:
On Mac x86_64, the code removal cause the binary to be
9224 bytes smaller.
- GNUmakefile.list.am:
- WTF.pro:
- WTF.vcproj/WTF.vcproj:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/Forward.h:
- wtf/ListHashSet.h:
(ListHashSet):
(ListHashSetNodeAllocator):
(WTF::ListHashSetNodeAllocator::pool):
(WTF::ListHashSetNodeAllocator::pastPool):
- wtf/MemoryInstrumentation.cpp: Removed.
- wtf/MemoryInstrumentation.h: Removed.
- wtf/MemoryInstrumentationArrayBufferView.h: Removed.
- wtf/MemoryInstrumentationHashCountedSet.h: Removed.
- wtf/MemoryInstrumentationHashMap.h: Removed.
- wtf/MemoryInstrumentationHashSet.h: Removed.
- wtf/MemoryInstrumentationListHashSet.h: Removed.
- wtf/MemoryInstrumentationSequence.h: Removed.
- wtf/MemoryInstrumentationString.h: Removed.
- wtf/MemoryInstrumentationVector.h: Removed.
- wtf/MemoryObjectInfo.h: Removed.
- wtf/text/AtomicString.h:
- wtf/text/StringImpl.h:
(WTF::StringImpl::isASCIILiteral):
- wtf/text/WTFString.h:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: Removed.
LayoutTests:
- inspector/profiler/memory-instrumentation-cached-images-expected.txt: Removed.
- inspector/profiler/memory-instrumentation-cached-images.html: Removed.
- inspector/profiler/memory-instrumentation-canvas-expected.txt: Removed.
- inspector/profiler/memory-instrumentation-canvas.html: Removed.
- inspector/profiler/memory-instrumentation-external-array-expected.txt: Removed.
- inspector/profiler/memory-instrumentation-external-array.html: Removed.
- inspector/profiler/memory-instrumentation-external-string-expected.txt: Removed.
- inspector/profiler/memory-instrumentation-external-string.html: Removed.
- inspector/profiler/memory-instrumentation-test.js: Removed.
- 3:39 PM Changeset in webkit [148920] by
-
- 3 edits2 adds in trunk
Do not reuse ExclusionShapeInsideInfo in a recursive region layout
https://bugs.webkit.org/show_bug.cgi?id=114467
Reviewed by David Hyatt.
Source/WebCore:
Elements that respect shape-inside that have inline children should not reuse an
ExclusionShapeInsideInfo for their children's layout. This patch adds the test
for regions. See the details for non-region layout in bug 104582.
https://bugs.webkit.org/show_bug.cgi?id=104582
Test: fast/regions/shape-inside/shape-inside-recursive-layout.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Do not look up a region's
ExclusionShapeInsideInfo if a block is already respecting shape-inside.
LayoutTests:
Test that for various types of inline containers do not reuse
ExclusionShapeInsideInfo when laying out their children.
- fast/regions/shape-inside/shape-inside-recursive-layout-expected.html: Added.
- fast/regions/shape-inside/shape-inside-recursive-layout.html: Added.
- 3:36 PM Changeset in webkit [148919] by
-
- 3 edits in trunk/Source/WebKit2
Plugin Snapshotting: Don't consume insane amounts of time detecting the primary plugin
https://bugs.webkit.org/show_bug.cgi?id=114994
<rdar://problem/13696269>
Reviewed by Anders Carlsson.
On some pages, we currently waste a lot of time on every subframe load
and every addPluginView doing primary plugin detection. This patch
attempts to address this via a few minor changes:
- Only allow detection after the main frame's didFinishLoad comes, instead of the first subframe.
- Only explicitly detect on the main frame's didFinishLoad (not subframes).
- Coalesce calls to determinePrimarySnapshottedPlugIn from both addPluginView
(in case JS is adding lots of plugins in a loop) and didFinishLoad.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::addPluginView): Coalesce calls to determinePrimarySnapshottedPlugIn.
(WebKit::WebPage::didFinishLoad):
Coalesce calls to determinePrimarySnapshottedPlugIn.
Bail on subframe loads, we're only interested in the main frame being complete.
(WebKit::WebPage::determinePrimarySnapshottedPlugInTimerFired):
Call determinePrimarySnapshottedPlugIn.
- WebProcess/WebPage/WebPage.h:
Add m_determinePrimarySnapshottedPlugInTimer and determinePrimarySnapshottedPlugInTimerFired
- 3:29 PM Changeset in webkit [148918] by
-
- 2 edits in trunk/LayoutTests
Fix r148773.
- platform/mac-lion/TestExpectations:
- 3:21 PM Changeset in webkit [148917] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13334446> [Mac] Tweak sandbox profiles.
Reviewed by Anders Carlsson.
Unbreak Lion, which doesn't provide detailed control over IPC.
- WebProcess/com.apple.WebProcess.sb.in:
- 3:15 PM Changeset in webkit [148916] by
-
- 9 edits in trunk
[GTK] Enable introspection always for developer builds
https://bugs.webkit.org/show_bug.cgi?id=114983
Reviewed by Gustavo Noronha Silva.
.:
- Source/autotools/SetupAutoconfHeader.m4: No longer expose the ENABLE_INTROSPECTION
autoconf header variable. It isn't used and it means that when introspection is enabled
or disabled, there is an unnecessary full rebuild.
Source/WebKit/gtk:
- GNUmakefile.am: Make warnings during gir scanning cause the build to fail. Eliminate
warnings about deprecated API that the g-ir-scanner uses when generating
the scanner program. Use --quiet to avoid printing lots of output to
non-verbose builds.
Source/WebKit2:
- GNUmakefile.am: Make warnings during gir scanning cause the build to fail. Eliminate
warnings about deprecated API that the g-ir-scanner uses when generating
the scanner program. Use --quiet.
Tools:
- Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary): Always enable introspection
when using build-webkit.
- gtk/jhbuildrc: Enable documentation for all jhbuild modules and explicitly
choose the memory gsettings backend while in the jhbuild. This eliminates
warnings from programs that fall back to the memory backend.
- 3:07 PM Changeset in webkit [148915] by
-
- 3 edits in trunk/LayoutTests
[css exclusions] shape-inside-recursive-layout.html should not yet test display: inline-grid
https://bugs.webkit.org/show_bug.cgi?id=114986
Reviewed by Dirk Schulze.
Because the inline-grid value is not yet supported, the test case is falling back to
display: block. This causes an incorrect layout, as block and inline content react to
shape-inside differently.
- fast/exclusions/shape-inside/shape-inside-recursive-layout-expected.html:
- fast/exclusions/shape-inside/shape-inside-recursive-layout.html:
- 2:54 PM Changeset in webkit [148914] by
-
- 6 edits in trunk/Source
[GTK] Fix remaining introspection warnings
https://bugs.webkit.org/show_bug.cgi?id=114980
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
- bindings/gobject/WebKitDOMCustom.h: Add scope and transfer annotations and flesh
out gtkdoc for completeness.
- bindings/gobject/WebKitDOMEventTarget.h:
(_WebKitDOMEventTargetIface): Ditto and also align virtual method names with those used
for the concrete ones.
Source/WebKit/gtk:
- webkit/webkitspellchecker.h:
(_WebKitSpellCheckerInterface): Align the name of the check_spelling_of_string virtual
method with the concrete method to avoid a g-ir-scanner warning.
- webkit/webkitversion.h.in: Skip WEBKITGTK_API_VERSION for introspection because it
doesn't follow the appropriate namespace name.
- 2:45 PM Changeset in webkit [148913] by
-
- 7 edits in trunk/Source/WebKit2
Make it easier to extend NetworkResourceLoadParameters
https://bugs.webkit.org/show_bug.cgi?id=114992
Reviewed by Sam Weinig.
Turn NetworkResourceLoadParameters into a struct which matches all our other parameter classes in WebKit2. Fill in the struct manually
instead of having a constructor with 9 parameters.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
(WebKit::NetworkConnectionToWebProcess::performSynchronousLoad):
- NetworkProcess/SchedulableLoader.cpp:
(WebKit::SchedulableLoader::SchedulableLoader):
- Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):
- Shared/Network/NetworkResourceLoadParameters.h:
(NetworkResourceLoadParameters):
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::loadResourceSynchronously):
- 2:19 PM Changeset in webkit [148912] by
-
- 11 edits2 adds in trunk/Source
PDFPlugin: Support unlocking encrypted PDFs
https://bugs.webkit.org/show_bug.cgi?id=114938
<rdar://problem/12872888>
Reviewed by Alexey Proskuryakov and Oliver Hunt.
If we try to load an encrypted PDF, we need to provide a sane mechanism
through which the user can provide the password. Add a slightly-below-center
password field to match PDFKit's normal behavior.
- WebKit2.xcodeproj/project.pbxproj: Add PDFPluginPasswordField.{h,mm}
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add attemptToUnlockWithPassword:
- WebProcess/Plugins/PDF/PDFPlugin.h:
Add createPasswordEntryForm, attemptToUnlockPDF, m_passwordField.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(annotationStyle): Make #annotationContainer a flexbox that centers its contents.
This won't affect the normal absolutely-positioned form fields, but the inline
password field will be centered vertically and horizontally.
(WebKit::PDFPlugin::pdfDocumentDidLoad):
If the document is locked when loaded, create a password field.
(WebKit::PDFPlugin::createPasswordEntryForm):
Create a PDFPluginPasswordField and attach it to the document.
(WebKit::PDFPlugin::attemptToUnlockPDF):
Try to unlock the PDF with the given password. If this succeeds, remove
the password field and relayout the scroll view.
(WebKit::PDFPlugin::calculateSizes):
Make the document 0x0 if it is locked, preventing scrolling.
(WebKit::PDFPlugin::handleMouseEvent):
Don't pass mouse events to PDFLayerController while it is locked,
as it has no useful events to provide, and will try to present a
dialog asking for the password if we let a click through.
- WebProcess/Plugins/PDF/PDFPluginAnnotation.h:
(WebKit::PDFPluginAnnotation::eventListener): Added.
- WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
(WebKit::PDFPluginAnnotation::handleEvent):
Move event-handling code here from PDFPluginAnnotationEventListener::handleEvent
so that subclasses can override this instead of having to have their own
event listeners (this is also why we now expose eventListener()).
(WebKit::PDFPluginAnnotation::PDFPluginAnnotationEventListener::handleEvent):
Forward the event to our owning PDFPluginAnnotation.
- WebProcess/Plugins/PDF/PDFPluginPasswordField.h: Added.
(WebKit::PDFPluginPasswordField::PDFPluginPasswordField):
- WebProcess/Plugins/PDF/PDFPluginPasswordField.mm: Added.
(WebKit::PDFPluginPasswordField::create):
(WebKit::PDFPluginPasswordField::~PDFPluginPasswordField):
Unregister for keyup.
(WebKit::PDFPluginPasswordField::createAnnotationElement):
Register for keyup, and set our element's class to "password".
(WebKit::PDFPluginPasswordField::updateGeometry):
Added. Override updateGeometry and do nothing, as the password field
has a geometry defined by CSS instead of by the PDF content.
(WebKit::PDFPluginPasswordField::handleEvent):
If the enter/return key is pressed, attempt to unlock the PDF. Also,
we do not call either of our superclass' implementations of handleEvent,
because blurring the password field should not destroy it, and tabbing
between fields has no relevance when there can only be one field.
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h:
(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotationEventListener):
Removed. We now share our superclass' event listener.
(WebKit::PDFPluginTextAnnotation::textAnnotation): Const.
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::~PDFPluginTextAnnotation):
PDFPluginTextAnnotation no longer has its own event listener,
so there's nothing left to clear here. Just make sure to unregister
our event from PDFPluginAnnotation's shared event listener!
(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
Ensure that we can create a PDFPluginTextAnnotation with a null annotation.
(WebKit::PDFPluginTextAnnotation::commit): Use value().
(WebKit::PDFPluginTextAnnotation::value):
Factor retrieving the value of the form control out of commit().
(WebKit::PDFPluginTextAnnotation::handleEvent):
Call up to PDFPluginAnnotation's handler so that defocus destroys the annotation.
Export HTMLNames::typeAttr.
- WebCore.exp.in:
- 1:46 PM Changeset in webkit [148911] by
-
- 3 edits in trunk/Source/WebKit2
Slow/beachballing when using the find bar on a page with plug-ins
https://bugs.webkit.org/show_bug.cgi?id=114990
<rdar://problem/12832313>
Reviewed by Tim Horton.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::notifyWidget):
Call shouldCreateTransientPaintingSnapshot().
(WebKit::PluginView::shouldCreateTransientPaintingSnapshot):
Don't create a painting snapshot if we're asked to paint the find indicator.
- WebProcess/Plugins/PluginView.h:
Add new member function.
- 1:40 PM Changeset in webkit [148910] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/13334446> [Mac] Tweak sandbox profiles.
Reviewed by Sam Weinig.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- WebProcess/com.apple.WebProcess.sb.in:
- 1:39 PM Changeset in webkit [148909] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Update about:config lists
https://bugs.webkit.org/show_bug.cgi?id=114967
Patch by Eli Fidler <efidler@blackberry.com> on 2013-04-22
Reviewed by Rob Buis.
- WebCoreSupport/AboutDataEnableFeatures.in:
- WebCoreSupport/AboutDataHaveFeatures.in:
- WebCoreSupport/AboutDataUseFeatures.in:
- 1:39 PM Changeset in webkit [148908] by
-
- 2 edits in trunk/Source/WebCore
Use-after-free in CompositeEditCommand::cloneParagraphUnderNewElement
https://bugs.webkit.org/show_bug.cgi?id=114911
Reviewed by Oliver Hunt.
Back ported https://src.chromium.org/viewvc/blink?revision=148680&view=revision.
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
- 1:29 PM Changeset in webkit [148907] by
-
- 4 edits2 adds in trunk
[Mac] "automatic" track selection should only select a track that matches user language
https://bugs.webkit.org/show_bug.cgi?id=114976
Reviewed by Jer Noble.
Source/WebCore:
Test: media/track/track-automatic-subtitles.html
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): When in "automatic" mode, only
consider text tracks that match the user's preferred language when the primary audio track
does not.
LayoutTests:
- media/track/track-automatic-subtitles-expected.txt: Added.
- media/track/track-automatic-subtitles.html: Added.
- platform/mac/TestExpectations: Skip track-user-preferences.html, the logic is no longer
correct for the Mac port.
- 1:02 PM Changeset in webkit [148906] by
-
- 2 edits in trunk/Source/WebCore
Cancelling load may cause deadlock in -[AVPlayerItem release]
https://bugs.webkit.org/show_bug.cgi?id=114962
Reviewed by Eric Carlson.
Work around a bug in AVAssetResourceLoader by using a generic, non-main dispatch queue
to recieve AVAssetResourceLoaderDelegate callbacks, and then marshalling those
callbacks to the main thread asynchronously.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::globalLoaderDelegateQueue): Added.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Use the new global queue.
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
Marshall the request to the main queue, and return YES (wait) immediately.
- 1:01 PM Changeset in webkit [148905] by
-
- 3 edits in trunk/Source/WebKit2
Don't kill our XPC services in response to memory pressure
https://bugs.webkit.org/show_bug.cgi?id=114985
<rdar://problem/13229217>
Reviewed by Mark Rowe.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
Call xpc_transaction_begin() so we'll never be killed by the kernel when there's memory pressure;
we prefer to manage our own lifetime thank you very much!
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::platformInitialize):
Remove call to disable sudden termination.
- 12:54 PM Changeset in webkit [148904] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13681842> [Mac] Tweak WebProcess sandbox profile to use
system-graphics function when available.
Reviewed by Sam Weinig.
- WebProcess/com.apple.WebProcess.sb.in:
- 12:52 PM Changeset in webkit [148903] by
-
- 13 edits in trunk
[GTK] Set up libPlatform.la
https://bugs.webkit.org/show_bug.cgi?id=114168
Reviewed by Martin Robinson.
.:
- GNUmakefile.am: Define the platform_cppflags and platform_sources variables.
Source/Platform:
- GNUmakefile.am: Set up the libPlatform.la static library to build the source files listed in platform_sources.
As with the libPlatformGtk.la library, only the Source/WebCore/platform and its subdirectories are allowed to be
searched for headers to include, providing a convenient way to detect any platform violations. These directories
are listed in the platform_webcore_cppflags variable.
Source/WebCore:
No new tests - no new functionality.
- GNUmakefile.am: Also add the LevelDB-specific cppflags to the platform_cppflags if required as the LevelDB
code is now built into the new libPlatform.la library.
- GNUmakefile.list.am: Build a small set of non-GTK-specific platform source files that are already free of
platform violations into the new libPlatform.la library.
Source/WebKit/gtk:
- GNUmakefile.am: Add the new libPlatform.la library to the libwebkitgtk library.
Source/WebKit2:
- GNUmakefile.am: Add the new libPlatform.la library to the libwebkitgtk library. Link the WebKitPluginProcess
executable against libPlatform.la as well.
Tools:
- GNUmakefile.am: Link the DumpRenderTree executable against both libPlatform.la and libPlatformGtk.la libraries.
- 12:47 PM Changeset in webkit [148902] by
-
- 6 edits7 adds in trunk/Source/WebKit2
Hard code plug-in sandbox profile lookup directories and move
the profiles to WebKit2.
Reviewed by Anders Carlsson.
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
(WebKit::PluginProcessMainDelegate::getExtraInitializationData):
- PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
(WebKit::PluginServiceInitializerDelegate::getExtraInitializationData):
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):
Stop passing the sandbox-profile-directory-path to the plug-in process.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::loadSandboxProfileForDirectory):
(WebKit::loadSandboxProfile):
(WebKit::PluginProcess::initializeSandbox):
Hard code the plug-in sandbox profile lookup to only look in the WebKit2 bundle
and /System/Library/Sandbox/Profiles/.
- Resources/PlugInSandboxProfiles: Added.
Add profiles.
- WebKit2.xcodeproj/project.pbxproj:
Copy the profiles to the bundle.
- 12:37 PM Changeset in webkit [148901] by
-
- 4 edits in trunk/Source/WebKit2
Refactor creation of the full screen window into an (overridable) method.
https://bugs.webkit.org/show_bug.cgi?id=110369
Reviewed by Eric Carlson.
Add a new WKView method -(NSWindow)createFullScreenWindow which can be overridden
by subclasses to provide custom full screen windows to the WKFullScreenWindowController.
- UIProcess/API/mac/WKView.mm:
(-[WKView fullScreenWindowController]):
(-[WKView createFullScreenWindow]):
- UIProcess/API/mac/WKViewPrivate.h:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController initWithWindow:]):
- 12:13 PM Changeset in webkit [148900] by
-
- 2 edits in trunk/Source/WTF
StringImpl.h should compile with -Wshorten-64-to-32
<http://webkit.org/b/114970>
Reviewed by Darin Adler.
Fixes the following warnings with -Wshorten-64-to-32:
StringImpl.h:317:25: error: implicit conversion loses integer precision: 'uintptr_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
unsigned hash = reinterpret_cast<uintptr_t>(this);
- wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl): Add static_cast<uint32_t>() to
formalize taking the lower 32-bits of the pointer value on
64-bit architectures.
- 11:40 AM Changeset in webkit [148899] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix broken 32-bit build to green the bots.
https://bugs.webkit.org/show_bug.cgi?id=114968.
Unreviewed.
Basically, I moved a JIT::emit_op_loop_hint() and JIT::emitSlow_op_loop_hint()
into common code where they belong, instead of the 64-bit specific section.
Also fixed some SH4 assertions failures which were also caused by
https://bugs.webkit.org/show_bug.cgi?id=114963. Thanks to Julien Brianceau
for pointing this out.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchAdd32):
- jit/JITOpcodes.cpp:
(JSC):
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):
- 11:23 AM Changeset in webkit [148898] by
-
- 5 edits in trunk
Range.getClientRects() should not include rects for partially selected elements
https://bugs.webkit.org/show_bug.cgi?id=76839
Reviewed by Sam Weinig.
Source/WebCore:
CSSOM says that Range.getClientRects() should include the border boxes
of each element selected by the range. However, we were also
incorrectly including border boxes for partially selected elements.
For instance, consider the following selection:
<div>line one<br>line two</div>
-------------
The <div> is two lines tall, but only the first line is selected.
Despite this, we'd include the <div>'s border box since its start tag
was included in the selection.
Fix this by excluding partially selected elements. This is accomplished
by skipping over elements that come after the start boundary point of
the range but are ancestors of the end boundary point.
Added test cases to LayoutTests/fast/dom/Range/getClientRects.html.
- dom/Range.cpp:
(WebCore::Range::getBorderAndTextQuads):
LayoutTests:
- fast/dom/Range/getClientRects-expected.txt: Updated expected result.
- fast/dom/Range/getClientRects.html: Added new test cases.
- 11:21 AM Changeset in webkit [148897] by
-
- 2 edits in trunk/Source/JavaScriptCore
2013-04-22 Oliver Hunt <oliver@apple.com>
Perform null check before trying to use the result of readline()
RS=Gavin
- jsc.cpp: (runInteractive):
- 11:19 AM Changeset in webkit [148896] by
-
- 2 edits in trunk/Source/JavaScriptCore
2013-04-22 Oliver Hunt <oliver@apple.com>
Fix assertions to account for new Vector layout
RS=Gavin
- llint/LLIntData.cpp: (JSC::LLInt::Data::performAssertions):
- 11:11 AM Changeset in webkit [148895] by
-
- 3 edits in trunk/LayoutTests
Unreviewed Mac gardening. Update a test and results now that forced text
tracks are supported.
- media/track/track-in-band-expected.txt:
- media/track/track-in-band.html:
- 10:56 AM Changeset in webkit [148894] by
-
- 3 edits2 adds in trunk
Crash on OS X when shift clicking outside of input
https://bugs.webkit.org/show_bug.cgi?id=104058
Patch by Yi Shen <max.hong.shen@gmail.com> on 2013-04-22
Reviewed by Chang Shu.
Source/WebCore:
Shift clicking outside of a focused div while removing the focused div from
the dom tree at the same time may hit a null visible position, which should
not be used to calculate the text distance with the new selection's start and
end position. Otherwise, the browser may crash.
Test: editing/selection/crash-on-shift-click.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEventSingleClick):
LayoutTests:
Add test for shift click crash issue.
- editing/selection/crash-on-shift-click-expected.txt: Added.
- editing/selection/crash-on-shift-click.html: Added.
- 10:37 AM Changeset in webkit [148893] by
-
- 12 edits in trunk/Source/JavaScriptCore
Change baseline JIT watchdog timer check to use the proper fast slow path
infrastructure.
https://bugs.webkit.org/show_bug.cgi?id=114963.
Reviewed by Oliver Hunt.
SH4 parts contributed by Julien Brianceau.
- assembler/ARMAssembler.h:
- assembler/MacroAssemblerARM.h:
- assembler/MacroAssemblerARMv7.h:
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branchAdd32):
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchAdd32):
- assembler/MacroAssemblerX86Common.h:
- assembler/SH4Assembler.h:
- jit/JIT.cpp:
(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
(JSC::JIT::emitEnterOptimizationCheck):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):
(JSC::JIT::emit_op_enter):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_enter):
- 10:02 AM Changeset in webkit [148892] by
-
- 2 edits in trunk/Source/WebCore
Scrollbar should not depend on EventHandler, Frame and FrameView
https://bugs.webkit.org/show_bug.cgi?id=114941
Reviewed by Darin Adler.
It's a layering violation that Scrollbar uses EventHandler, Frame
and FrameView. Frame is used to get the EventHandler that is used
to set mousePressed to false after a Scrollbar::mouseUp(). This is
not really needed, since EventHandler already sets m_mousePressed
to false when calling Scrollbar::mouseUp(). The PopupMenu windows
implementation also calls Scrollbar::mouseUp(), but that scrollbar
is not inside a FrameView.
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::isScrollViewScrollbar):
isScrollViewScrollbar() is a method of ScrollView so we don't need
to cast to FrameView.
(WebCore::Scrollbar::mouseUp): Remove EventHandler ussage.
- 10:00 AM Changeset in webkit [148891] by
-
- 7 edits in trunk/Source
Shrink baseline size of WTF::Vector on 64-bit by switching to unsigned capacity and size.
<http://webkit.org/b/97268>
<rdar://problem/12376519>
Reviewed by Sam Weinig.
Source/JavaScriptCore:
Update LLInt WTF::Vector offset constants to match the new memory layout.
- llint/LowLevelInterpreter.asm:
Source/WebCore:
- CMakeLists.txt: Add a workaround for GCC 4.6.x in Release mode so it
does not crash.
Source/WTF:
Shrink Vector by 8 bytes on 64-bit by using 32-bit capacity and size.
Vector now inherits from VectorBuffer instead of having a VectorBuffer member;
this is necessary for m_size to fall into the padding after the base class members.
The WTF::Vector API still uses size_t.
Based on Blink r148313 by <cevans@chromium.org>.
- wtf/SizeLimits.cpp:
- wtf/Vector.h:
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(VectorBufferBase):
(WTF::VectorBuffer::shouldReallocateBuffer):
(Vector):
(WTF::Vector::Vector):
(WTF::Vector::capacity):
(WTF::Vector::at):
(WTF::Vector::data):
(WTF::Vector::swap):
(WTF::::Vector):
(WTF::::reserveCapacity):
(WTF::::tryReserveCapacity):
(WTF::::reserveInitialCapacity):
(WTF::::shrinkCapacity):
(WTF::::releaseBuffer):
- 9:43 AM Changeset in webkit [148890] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] URL decode data: URLs before passing to the platform media player.
https://bugs.webkit.org/show_bug.cgi?id=114887
Patch by John Griggs <jgriggs@blackberry.com> on 2013-04-22
Reviewed by Rob Buis.
Pass data URL through URL decoding before passing to platform media player. PR 313635.
Reviewed internally by Liam Quinn
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::load):
- 9:40 AM Changeset in webkit [148889] by
-
- 1 edit1 copy1 move2 adds in trunk/LayoutTests
Fix an incorrect rebaseline done in r148830.
Instead of updating the cross platform wk2 results, r148830 should have added efl wk2
specific results. Move the previous mac wk2 specific results into the mac wk2 platform
directory.
- platform/efl-wk2/loader/go-back-cached-main-resource-expected.txt: Renamed from LayoutTests/platform/wk2/loader/go-back-cached-main-resource-expected.txt.
- platform/mac-wk2/loader/go-back-cached-main-resource-expected.txt: Downloaded from the mac-wk2 bots.
- 9:32 AM Changeset in webkit [148888] by
-
- 2 edits in trunk/Source/WTF
Memory barrier support should also ensure that we always do a compiler fence
https://bugs.webkit.org/show_bug.cgi?id=114934
Reviewed by Michael Saboff.
This is a cherry-pick merge of the WTF part of r148836 from the dfgFourthTier
branch. It fixes a memory ordering bug that is likely asymptomatic, but
nonetheless real: TCSpinLock expects that using a memoryBarrierBeforeUnlock()
prior to setting lockword_ to 0 will ensure that the assignment to lockword_
won't get floated above any of the stores in the critical section. While that
memory barrier does indeed do the right thing on ARM, it doesn't do the right
thing on other architectures: it turns into empty code that the compiler blows
away, which is fine for the hardware since X86 won't reorder that store - but
it's not fine for the compiler, which may still do its own reorderings.
The WTF part of r148836 fixes this by using a compiler fence: an empty asm
volatile block that is marked as clobbering memory.
Instead of doing a separate surgical fix in trunk, I decided to merge the
whole WTF change over, to make merging easier in the future.
Performance testing of this change in dfgFourthTier showed no regression.
- wtf/Atomics.h:
(WTF::compilerFence):
(WTF::armV7_dmb):
(WTF::armV7_dmb_st):
(WTF::loadLoadFence):
(WTF::loadStoreFence):
(WTF::storeLoadFence):
(WTF::storeStoreFence):
(WTF::memoryBarrierAfterLock):
(WTF::memoryBarrierBeforeUnlock):
(WTF::x86_mfence):
- 9:03 AM Changeset in webkit [148887] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Add webkit_web_context_set_disk_cache_directory to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=111848
Reviewed by Anders Carlsson.
This allow applications to set a custom directory for the disk
cache.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_set_disk_cache_directory):
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
- UIProcess/API/gtk/tests/TestMain.cpp:
(removeNonEmptyDirectory):
(main): Use a different temporary disk cache directory for every
test.
- 8:57 AM Changeset in webkit [148886] by
-
- 6 edits in trunk/Source/WebKit2
[SOUP] Soup disk cache should respect the diskCacheDirectory from the process initial parameters
https://bugs.webkit.org/show_bug.cgi?id=111845
Reviewed by Anders Carlsson.
Move the cache initialization to platformInitializeWebProcess() to
create the cache using the directory received from the UI
process. This allows to add public API to set a different disk
cache directory from the UI process.
- UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformDefaultDiskCacheDirectory): Return
default disk cache directory.
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultDiskCacheDirectory): Ditto.
- WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl): Remove soup cache initialization.
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk): Ditto.
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformInitializeWebProcess): Initialize
soup cache.
- 8:43 AM Changeset in webkit [148885] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Update BatteryClientBlackBerry to use our port's new listener interface
https://bugs.webkit.org/show_bug.cgi?id=114892
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-04-22
Reviewed by Rob Buis.
PR 328147
Modify the client so we only have one listener for battery change events.
The dispatch of different event listeners are handled by BatteryController.
- WebCoreSupport/BatteryClientBlackBerry.cpp:
(WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
(WebCore::BatteryClientBlackBerry::startUpdating):
(WebCore::BatteryClientBlackBerry::stopUpdating):
(WebCore::BatteryClientBlackBerry::onStatusChange):
- WebCoreSupport/BatteryClientBlackBerry.h:
(BatteryClientBlackBerry):
- 8:31 AM Changeset in webkit [148884] by
-
- 2 edits in trunk/Source/WTF
WTF::AtomicString::find() should take unsigned 'start' argument
<http://webkit.org/b/114958>
Reviewed by Darin Adler.
Fixes the following warnings with -Wshorten-64-to-32:
AtomicString.h:113:76: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
size_t find(UChar c, size_t start = 0) const { return m_string.find(c, start); }
AtomicString.h:115:35: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
{ return m_string.find(s, start, caseSentitive); }
AtomicString.h:117:35: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
{ return m_string.find(s, start, caseSentitive); }
- wtf/text/AtomicString.h:
(WTF::AtomicString::find): Change type of 'start' argument from
size_t to unsigned.
- 8:20 AM Changeset in webkit [148883] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Fix build warning when GESTURE_EVENTS is ON.
https://bugs.webkit.org/show_bug.cgi?id=114812
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-04-22
Reviewed by Andreas Kling.
Handle GestureSingleTap in the event type switch.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformHandleMouseEvent):
- 8:02 AM Changeset in webkit [148882] by
-
- 3 edits in trunk/LayoutTests
Update layout test verifying Tab behaves correctly after linking to fragment ID
https://bugs.webkit.org/show_bug.cgi?id=114645
Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-04-22
Reviewed by Chris Fleizach.
- fast/dom/fragment-activation-focuses-target.html: Updated test.
- fast/dom/fragment-activation-focuses-target-expected.txt: Updated expectations.
- 7:26 AM Changeset in webkit [148881] by
-
- 16 edits in trunk
fix build warning(unused parameter)
https://bugs.webkit.org/show_bug.cgi?id=114855
Patch by Xuefei Ren <xren@blackberry.com> on 2013-04-22
Reviewed by Rob Buis.
Source/WebCore:
remove warning(unused parameter) in
Source/WebCore/platform/graphics/blackberry
- platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
(WebCore::CanvasLayerCompositingThreadClient::drawTextures):
(WebCore::CanvasLayerCompositingThreadClient::deleteTextures):
(WebCore::CanvasLayerCompositingThreadClient::commitPendingTextureUploads):
- platform/graphics/blackberry/FontBlackBerry.cpp:
(WebCore::Font::offsetForPositionForComplexText):
- platform/graphics/blackberry/FontCacheBlackBerry.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getTraitsInFamily):
- platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp:
(WebCore::GlyphPage::fill):
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
- platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
- platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
(WebCore::flushAndDraw):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::platformTransformColorSpace):
- platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::drawTile):
- platform/graphics/blackberry/PathBlackBerry.cpp:
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::clipPath):
- platform/graphics/blackberry/PatternBlackBerry.cpp:
(WebCore::Pattern::platformPattern):
Source/WebKit/blackberry:
remove warning(unused parameter) in
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::extractedTextRequest):
Tools:
remove warning(unused parameter) in
Tools/DumpRenderTree/blackberry/EventSender.cpp
- DumpRenderTree/blackberry/EventSender.cpp:
(getDragModeCallback):
- 7:24 AM Changeset in webkit [148880] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] ASSERT in FrameLoaderClient::convertMainResourceLoadToDownload
https://bugs.webkit.org/show_bug.cgi?id=114741
Patch by Xan Lopez <xlopez@igalia.com> on 2013-04-22
Reviewed by George Staikos.
Consider the case where a ResourceHandle won't have a FilterStream
object associated (for example, Blob objects) instead of ASSERTing
pointlessly when asking our network layer for such an object.
This partially fixes fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
- 7:19 AM Changeset in webkit [148879] by
-
- 5 edits2 adds in trunk
[BlackBerry] Add additional datalist support.
https://bugs.webkit.org/show_bug.cgi?id=114883
Reviewed by Rob Buis.
PR 210083.
Source/WebCore:
Extend support for datalist to include all non-popup input types.
Re-enabling fast/forms/datalist/input-list
Internally Reviewed by Otto Cheung.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::supportsDataListUI):
Source/WebKit/blackberry:
Properly set state when opening a Date/Time popup and simplify
the logic for showing datalist options.
Internally Reviewed by Otto Cheung.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openDatePopup):
(BlackBerry::WebKit::InputHandler::showTextInputTypeSuggestionBox):
LayoutTests:
Fix results for fast/forms/datalist/input-list.
Internally Reviewed by Otto Cheung.
- platform/blackberry/fast/forms/datalist/input-list-expected.txt: Added.
- 5:39 AM Changeset in webkit [148878] by
-
- 1 edit56 adds in trunk/LayoutTests
[CSS Regions] Add tests for lists and counters
https://bugs.webkit.org/show_bug.cgi?id=103975
Reviewed by Andreas Kling.
Lists and counters work correctly with regions since r148026 (http://trac.webkit.org/changeset/148026).
This patch adds W3C formatted ref tests to our battery.
- fast/regions/counters/extract-list-items-001-expected.html: Added.
- fast/regions/counters/extract-list-items-001.html: Added.
- fast/regions/counters/extract-list-items-002-expected.html: Added.
- fast/regions/counters/extract-list-items-002.html: Added.
- fast/regions/counters/extract-list-items-003-expected.html: Added.
- fast/regions/counters/extract-list-items-003.html: Added.
- fast/regions/counters/extract-list-items-004-expected.html: Added.
- fast/regions/counters/extract-list-items-004.html: Added.
- fast/regions/counters/extract-list-items-005-expected.html: Added.
- fast/regions/counters/extract-list-items-005.html: Added.
- fast/regions/counters/extract-list-items-006-expected.html: Added.
- fast/regions/counters/extract-list-items-006.html: Added.
- fast/regions/counters/extract-list-items-007-expected.html: Added.
- fast/regions/counters/extract-list-items-007.html: Added.
- fast/regions/counters/extract-list-items-008-expected.html: Added.
- fast/regions/counters/extract-list-items-008.html: Added.
- fast/regions/counters/extract-list-items-009-expected.html: Added.
- fast/regions/counters/extract-list-items-009.html: Added.
- fast/regions/counters/extract-list-items-010-expected.html: Added.
- fast/regions/counters/extract-list-items-010.html: Added.
- fast/regions/counters/extract-list-items-011-expected.html: Added.
- fast/regions/counters/extract-list-items-011.html: Added.
- fast/regions/counters/extract-list-items-012-expected.html: Added.
- fast/regions/counters/extract-list-items-012.html: Added.
- fast/regions/counters/extract-list-items-013-expected.html: Added.
- fast/regions/counters/extract-list-items-013.html: Added.
- fast/regions/counters/extract-list-items-014-expected.html: Added.
- fast/regions/counters/extract-list-items-014.html: Added.
- fast/regions/counters/extract-list-items-015-expected.html: Added.
- fast/regions/counters/extract-list-items-015.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-divs-001-expected.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-divs-001.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-divs-002-expected.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-divs-002.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-expected.html: Added.
- fast/regions/counters/extract-numbered-paragraphs.html: Added.
- fast/regions/counters/extract-numbered-spans-display-only-some-expected.html: Added.
- fast/regions/counters/extract-numbered-spans-display-only-some.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-001-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-001.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-002-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-002.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-003-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-003.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html: Added.
- fast/regions/counters/extract-unordered-lists-in-regions-expected.html: Added.
- fast/regions/counters/extract-unordered-lists-in-regions.html: Added.
- 4:51 AM Changeset in webkit [148877] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening. css3-device-adaptation doesn't work for WK1 EFL properly.
- platform/efl-wk1/TestExpectations: Added tests related to css3-device-adaptation.
- 4:42 AM Changeset in webkit [148876] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark IndexedDB test as crashing in Release mode and fix duplicate line in
TestExpectations.
- platform/efl/TestExpectations:
- 3:56 AM Changeset in webkit [148875] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL WK1 gardening. Skip pasteboard tests because EFL WK1 doesn't support it yet.
- platform/efl-wk1/TestExpectations:
- 3:51 AM Changeset in webkit [148874] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip several compositing test cases on EFL WK2 due to regression in
r148748.
- platform/efl-wk2/TestExpectations:
- 3:41 AM Changeset in webkit [148873] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Add several regressions to TestExpectations to make the tree green.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 3:32 AM Changeset in webkit [148872] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Fix expected result for several test cases.
- platform/efl/TestExpectations:
- 3:07 AM Changeset in webkit [148871] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Unskipping the fast/sub-pixel layout tests.
Removing failure expectations for tests that are passing after the subpixel layout was enabled.
- 2:58 AM Changeset in webkit [148870] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Add dummy implementations of DragData::droppedFileSystemId()
https://bugs.webkit.org/show_bug.cgi?id=114861
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-22
Reviewed by Carlos Garcia Campos.
- platform/blackberry/DragDataBlackBerry.cpp:
(WebCore):
(WebCore::DragData::droppedFileSystemId):
- 2:20 AM Changeset in webkit [148869] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- 2:14 AM Changeset in webkit [148868] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Unskip fast/exclusions tests after r148594.
- platform/qt/TestExpectations:
- 2:11 AM Changeset in webkit [148867] by
-
- 2 edits in trunk/Tools
[BlackBerry] Add dummy implementation of AccessibilityController::accessibleElementById()
https://bugs.webkit.org/show_bug.cgi?id=114939
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-22
Reviewed by Carlos Garcia Campos.
This was added in r129308.
- DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
(AccessibilityController::accessibleElementById):
- 2:07 AM Changeset in webkit [148866] by
-
- 2 edits in trunk/LayoutTests
[EFL] accessibility/language-attribute.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112030
Unreviewed, EFL gardening.
Unskipping accessibility/language-attribute.html after r148737.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-04-22
- platform/efl-wk2/TestExpectations:
- 2:05 AM Changeset in webkit [148865] by
-
- 15 edits6 adds in trunk
Source/WebCore: [CSS Regions] Elements in a region should be assignable to a named flow
https://bugs.webkit.org/show_bug.cgi?id=74144
Patch by Mihai Maerean <Mihai Maerean> on 2013-04-22
Reviewed by David Hyatt.
DOM children of a region must not be rendered as children of the region, but can be collected in flow threads.
NodeRenderingContext::parentRenderer now creates the parent render flow thread if it doesn't exist.
Element::moveToFlowThreadIsNeeded is a virtual method that is overriden in PseudoElement to return false and
in SVGElement so only svg root elements can directly be collected by a render flow thread.
RenderObject::canDOMChildrenHaveRenderParent exists to optimize the code so nodes inside regions (and maybe
other types of renderers in the future) can still have renderers if they need to be in a flow thread while the
rest of renderers that can't have children skip the new instructions.
Tests: fast/regions/flow-body-in-html.html . To test the duplicate bug #103685.
fast/regions/region-content-flown-into-region.html
fast/regions/universal-selector-children-to-the-same-region.html . To test the duplicate bug #103685.
- dom/Element.cpp:
(WebCore::Element::moveToFlowThreadIsNeeded):
- dom/Element.h:
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::parentRenderer): the renderer that will be the parent for this node's renderer.
In the case of RenderFlowThreads, it may need to create it.
(WebCore::NodeRenderingContext::shouldCreateRenderer): In a region, only the children that need to be in a flow
thread should have a renderer.
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRenderingContext::moveToFlowThread):
- dom/NodeRenderingContext.h:
(NodeRenderingContext):
- dom/PseudoElement.h: pseudo-elements cannot be directly collected into a named flow.
- dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
(WebCore::Text::updateTextRenderer): Because calling textRendererIsNeeded(NodeRenderingContext(...)) on a
non-const l-value NodeRenderingContext cannot be done on a temporary object on the stack.
- dom/Text.h:
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::isContentNodeRegisteredWithAnyNamedFlow):
- rendering/FlowThreadController.h:
- rendering/RenderObject.h:
(WebCore::RenderObject::canDOMChildrenHaveRenderParent): Even if this render object can't have render children,
the children in the DOM tree may have a render parent (that is different from this render object).
- rendering/RenderRegion.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::moveToFlowThreadIsNeeded): Allow only svg root elements to be directly collected by a
render flow thread.
- svg/SVGElement.h:
LayoutTests: [CSS Regions] Elements in a region should be assignable to a named flow
https://bugs.webkit.org/show_bug.cgi?id=74144
Reviewed by David Hyatt.
- fast/regions/flow-body-in-html-expected.txt: Added.
Patch by Mihai Maerean <Mihai Maerean> on 2013-04-22
- fast/regions/flow-body-in-html.html: Added. To test the duplicate bug #103685.
- fast/regions/region-content-flown-into-region-expected.txt: Added.
- fast/regions/region-content-flown-into-region.html: Added.
- fast/regions/universal-selector-children-to-the-same-region-expected.txt: Added.
- fast/regions/universal-selector-children-to-the-same-region.html: Added. To test the duplicate bug #103685.
- 1:59 AM Changeset in webkit [148864] by
-
- 2 edits in trunk/Source/WebCore
Gradient: add PlatformGradient definition for BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=114727
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-22
Reviewed by Carlos Garcia Campos.
- platform/graphics/Gradient.h:
(Graphics):
- 1:58 AM FeatureFlags edited by
- (diff)
- 1:32 AM Changeset in webkit [148863] by
-
- 13 edits in trunk
Use DOM ordering for list counts
https://bugs.webkit.org/show_bug.cgi?id=110352
Reviewed by Elliott Sprehn.
Source/WebCore:
Currently the list items ordering is made by traversing the render tree. This gives bad results for:
- list items flown inside regions because they are not rendered as descendants of their DOM list ancestors.
- list items matched to insertion points inside a shadow tree. The insertion point may be a child of a
list so the numbering gets broken.
To implement correct DOM ordering I've taken into account the fact that pseudo-elements can have display: list-item
so they should be included when traversing the DOM tree. I've added helper methods on the NodeTraversal
namespace that should allow easily traversing the tree including the pseudo-elements (e.g. firstChildWithPseudo
for an element with pseudo-before will return the before PseudoElement). Using these helper methods I've implemented
pre-order traversal methods aware of the pseudo-elements.
An effect of this change is how the list items inside shadow tree update their counting. With the patch, if there's
no <ol> or <ul> element on the ancestor chain of a <li> element to the shadow root, the list node will be considered the
first parent of the <li> or the shadow root if there is no ancestor.
The RenderListItem class now makes use of this new method of traversal, replacing the one based on the render tree.
To simplify the CSS counters implementation, I've changed the traversal functions inside RenderCounter to also make use
of this method. The CSS counters and the list items now have the same traversal algorithm.
In later patches I'll add tests that should cover the regions and shadow DOM use cases.
Tests bug for shadow DOM: https://bugs.webkit.org/show_bug.cgi?id=113193
Tests bug for regions: https://bugs.webkit.org/show_bug.cgi?id=103975
Tests: no new tests is this patch; added the correct expectations for fast/lists/positioned-count-crash.html
and fast/dom/shadow/shadow-and-list-elements.html
- dom/Node.cpp:
(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore):
(WebCore::Node::pseudoAwareNextSibling):
(WebCore::Node::pseudoAwareFirstChild):
(WebCore::Node::pseudoAwareLastChild):
- dom/Node.h:
(Node):
- dom/NodeTraversal.cpp:
(WebCore):
(WebCore::NodeTraversal::previousIncludingPseudo):
(NodeTraversal):
(WebCore::NodeTraversal::nextIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudoSkippingChildren):
- dom/NodeTraversal.h:
(ElementTraversal):
(NodeTraversal):
(WebCore::ElementTraversal::previousIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
(WebCore::ElementTraversal::pseudoAwarePreviousSibling):
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::attach):
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):
- rendering/RenderCounter.cpp:
(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):
- rendering/RenderListItem.cpp:
(WebCore):
(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):
- rendering/RenderListItem.h:
(RenderListItem):
LayoutTests:
The fast/dom/shadow/shadow-and-list-elements-expected.html has changed because the list items
inside the shadow tree no longer see the root <ol> element.
The test fast/lists/positioned-count-crash.html has the correct rendering after changing
the list counting to be in DOM order.
- fast/dom/shadow/shadow-and-list-elements-expected.html:
- fast/lists/positioned-count-crash-expected.txt:
- 12:57 AM Changeset in webkit [148862] by
-
- 2 edits in trunk/Source/WebCore
Fix multiple definition of ImageBuffer::platformLayer() in the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=114936
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-22
Reviewed by Carlos Garcia Campos.
We already have a definition in ImageBufferBlackBerry.cpp.
- platform/graphics/ImageBuffer.cpp:
(WebCore):
- 12:49 AM Changeset in webkit [148861] by
-
- 2 edits in trunk/LayoutTests
[GTK] Cleanup TestExpectations to pass --lint-test-files
https://bugs.webkit.org/show_bug.cgi?id=114927
Unreviewed gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-22
- platform/gtk/TestExpectations:
- 12:29 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:25 AM Changeset in webkit [148860] by
-
- 9 edits in trunk
[WebKit2] Plugins without a MIME Type fail to load
https://bugs.webkit.org/show_bug.cgi?id=112834
Reviewed by Benjamin Poulain.
Source/WebKit2:
The problem is that when the plugin is created and the MIME Type
is empty, since the MIME Type guessed in the UI process using the
plugin extension is not passed to the WebProcess, when the plugin
is instantiated, the value of NPMIMEType parameter passed to
NPP_New is NULL, and NPERR_INVALID_INSTANCE_ERROR is returned.
GetPluginPath message has been renamed to FindPlugin, since it
doesn't only return the path but also the new MIME Type and load
policy.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin): Receive an output newMIMEType
parameter that is passed to PluginModuleInfo::findPlugin() so that
in case of guessing the MIME Type, the new one is passed back to
the WebProcess.
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin): Pass the MIME Type
from the parameters to WebPage::createPlugin.
(WebKit::WebFrameLoaderClient::recreatePlugin): Pass a newMIMEType
parameter to WebPage::createPlugin.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin): Add newMIMEType out parameter and
pass it to the FindPlugin message.
(WebKit::WebPage::canPluginHandleResponse): Pass newMIMEType to
FindPlugin message.
- WebProcess/WebPage/WebPage.h:
(WebPage):
LayoutTests:
- platform/wk2/TestExpectations: Unskip
plugins/no-mime-with-valid-extension.html.
Apr 21, 2013:
- 11:54 PM Changeset in webkit [148859] by
-
- 3 edits2 adds in trunk
Division by zero in CSSGradientValue::addStops()
https://bugs.webkit.org/show_bug.cgi?id=114807
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-21
Reviewed by Dean Jackson.
Source/WebCore:
The normalization of the color stop positions of a linear gradient
doesn't take into account that the first and last position can be
the same. In such case the positions are computed dividing by 0.
Clamp the positions to 1 without moving the end points in such
case to match what other browsers do. This ensures that positions
passed to the platform gradient are in the 0-1 range which fixes a
crash due to an assert in BlackBerry port running test
fast/forms/type-after-focus-rule-shrink-width.html.
Test: fast/gradients/css3-color-stop-invalid.html
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
LayoutTests:
- fast/gradients/css3-color-stop-invalid-expected.html: Added.
- fast/gradients/css3-color-stop-invalid.html: Added.
- 11:52 PM Changeset in webkit [148858] by
-
- 2 edits in trunk/Tools
Unreviewed EFL build fix after r148855.
- TestWebKitAPI/PlatformEfl.cmake:
- 11:21 PM Changeset in webkit [148857] by
-
- 9 edits in trunk/Source
Improve StringImpl code density for older ARM hardware
https://bugs.webkit.org/show_bug.cgi?id=114898
Reviewed by Geoffrey Garen.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
Source/WTF:
Reduce the number of instructions needed for StringImpl::deref
on older ARM hardware.
The extra indirection should have a negligible impact on x86_64.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::destroy):
- wtf/text/StringImpl.h:
(StringImpl):
(WTF::StringImpl::deref):
- 11:06 PM Changeset in webkit [148856] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r148851.
http://trac.webkit.org/changeset/148851
https://bugs.webkit.org/show_bug.cgi?id=114935
EFL Buildbot reports fail after gardening on r148851
(Requested by gyuyoung on #webkit).
- platform/efl/TestExpectations:
- 11:00 PM Changeset in webkit [148855] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Mark WKViewClientWebProcessCallbacks API test as failing
https://bugs.webkit.org/show_bug.cgi?id=114922
Reviewed by Gyuyoung Kim.
Mark WKViewClientWebProcessCallbacks API test as failing on WK2 EFL.
- TestWebKitAPI/PlatformEfl.cmake:
- 10:54 PM Changeset in webkit [148854] by
-
- 3 edits in trunk/Source/WebCore
Fix some minor bad use of strings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=114907
Reviewed by Darin Adler.
- editing/Editor.cpp:
(WebCore::Editor::selectedText): This was implicitly getting the emptyString()
for the argument "".
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::takeResults): ditto.
- 10:32 PM Changeset in webkit [148853] by
-
- 2 edits in branches/dfgFourthTier/Tools
fourthTier: tandem WebKit and LLVM builds should ./configure LLVM if needed
https://bugs.webkit.org/show_bug.cgi?id=114933
Reviewed by Andy Estes.
This makes it easy to get set up for tandem LLVM builds.
- Scripts/copy-webkitlibraries-to-product-directory:
- 9:39 PM Changeset in webkit [148852] by
-
- 26 edits2 copies in trunk
[Part 4] Parse the custom() function in -webkit-filter: parse the matN() functions
https://bugs.webkit.org/show_bug.cgi?id=71444
Reviewed by Dean Jackson.
Source/WebCore:
Custom filter parameters should support mat2 to mat4 value functions. Added parsing
and style resolving bits to support the matrix function values. A later patch will
add the matrices to the shader program.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-parameters
Modified existing tests to cover changes.
- GNUmakefile.list.am: Added WebKitCSSMatFunctionValue to individual build systems.
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForCustomFilterMatParameter):
(WebCore):
(WebCore::valueForCustomFilterParameter):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseMatValue):
(WebCore):
(WebCore::CSSParser::parseCustomFilterParameters):
- css/CSSParser.h:
(WebCore):
- css/CSSValue.cpp:
(WebCore::CSSValue::reportMemoryUsage):
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):
- css/CSSValue.h:
(WebCore::CSSValue::isWebKitCSSMatFunctionValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::parseCustomFilterArrayParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
- css/StyleResolver.h:
(StyleResolver):
- css/WebKitCSSMatFunctionValue.cpp:
(WebCore::WebKitCSSMatFunctionValue::WebKitCSSMatFunctionValue):
(WebCore::WebKitCSSMatFunctionValue::customCssText):
(WebCore::WebKitCSSMatFunctionValue::cloneForCSSOM):
(WebCore::WebKitCSSMatFunctionValue::equals):
(WebCore::WebKitCSSMatFunctionValue::reportDescendantMemoryUsage):
- css/WebKitCSSMatFunctionValue.h:
(WebKitCSSMatFunctionValue):
(WebCore::WebKitCSSMatFunctionValue::create):
- platform/graphics/filters/CustomFilterArrayParameter.h:
(WebCore::CustomFilterArrayParameter::create):
(WebCore::CustomFilterArrayParameter::CustomFilterArrayParameter):
- platform/graphics/filters/CustomFilterParameter.h:
(CustomFilterParameter):
- platform/graphics/filters/CustomFilterRenderer.cpp:
(WebCore::CustomFilterRenderer::bindProgramParameters):
LayoutTests:
Added tests for mat2 to mat4 parameter functions on custom fiter function and
parameter descriptor.
- css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-invalid.js:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-valid.js:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-invalid.js:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-valid.js:
- 7:16 PM Changeset in webkit [148851] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening. Remove test cases which are expected failed, but passed now.
- platform/efl/TestExpectations:
- 4:59 PM Changeset in webkit [148850] by
-
- 4 edits1 add in branches/dfgFourthTier
fourthTier: WebKit's build system should relink JavaScriptCore if LLVM's libraries changed but its headers didn't
https://bugs.webkit.org/show_bug.cgi?id=114926
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
Use a phony file that includes a phony header to force JavaScriptCore to be relinked
if necessary. The external LLVM-importing scripts will touch the header if the libraries
are known to have changed.
- JavaScriptCore.xcodeproj/project.pbxproj:
- ftl/WebKitLLVMLibraryAnchor.cpp: Added.
Tools:
Reviewed by Geoffrey Garen.
If the LLVM libraries change, then touch a phony header, which will force relink
of JavaScriptCore.
- Scripts/copy-webkitlibraries-to-product-directory:
(unpackIfNecessary):
- 4:26 PM Changeset in webkit [148849] by
-
- 32 edits in trunk
JS Lexer and Parser should be more informative when they encounter errors
https://bugs.webkit.org/show_bug.cgi?id=114924
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Add new tokens to represent the various ways that parsing and lexing have failed.
This gives us the ability to produce better error messages in some cases,
and to indicate whether or not the failure was due to invalid source, or simply
early termination.
The jsc prompt now makes use of this so that you can write functions that
are more than one line long.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
- jsc.cpp:
(stringFromUTF):
(jscSource):
(runInteractive):
- parser/Lexer.cpp:
(JSC::::parseFourDigitUnicodeHex):
(JSC::::parseIdentifierSlowCase):
(JSC::::parseString):
(JSC::::parseStringSlowCase):
(JSC::::lex):
- parser/Lexer.h:
(UnicodeHexValue):
(JSC::Lexer::UnicodeHexValue::UnicodeHexValue):
(JSC::Lexer::UnicodeHexValue::valueType):
(JSC::Lexer::UnicodeHexValue::isValid):
(JSC::Lexer::UnicodeHexValue::value):
(Lexer):
- parser/Parser.h:
(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):
(JSC::::parse):
- parser/ParserError.h:
(ParserError):
(JSC::ParserError::ParserError):
- parser/ParserTokens.h:
- runtime/Completion.cpp:
(JSC):
(JSC::checkSyntax):
- runtime/Completion.h:
(JSC):
LayoutTests:
Update test results to cover improved error messages.
- fast/js/kde/parse-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T5-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T10-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T5-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T6-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T7-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T8-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T9-expected.txt:
- sputnik/Conformance/13_Function_Definition/S13_A7_T3-expected.txt:
- 4:26 PM Changeset in webkit [148848] by
-
- 2 edits in branches/dfgFourthTier/Tools
fourthTier: developing LLVM in tandem with WebKit should be fun and easy
https://bugs.webkit.org/show_bug.cgi?id=114925
Reviewed by Geoffrey Garen.
This enables building LLVM along with WebKit, so that build-jsc and build-webkit
will also optionally build LLVM and quickly symlink LLVM's built products into
the right places.
Most WebKit and JSC hackers will want to rely on the checked-in already-built
versions of LLVM in WebKitLibraries. But developing both systems in tandem is an
increasingly common use-case for me, and it may become a common use case for a
handful of others. Currently, this is really painful: you first have to build
LLVM, then you have to export-llvm-build (which takes a while), and then you
have to make sure that your LLVM_LIBRARY_PACKAGE and LLVM_INCLUDE_PACKAGE
variables are set to point to the thing you exported. The whole process loses
track of dependencies very quickly: making a tiny change in LLVM requires
packaging, and then unpackaging, a large number of potentially large headers and
static libraries. Not only is this slow but it then causes the WebKit build
system to rebuild anything that transitively includes any LLVM header, which is
now quite a few files. While this sort of use pattern is still worthwhile if
you're trying to package a binary drop and test it, it's not great if you're
just trying to do experimental development that involves making small changes
in both trees.
This change fixes this use case while keeping the old use cases intact. You can
do tandem development using one of two modes:
Your own LLVM directory: just set LLVM_SOURCE_PATH to the *absolute* path of
the LLVM directory you're using. Once this is done, any invocation of a WebKit
build via build-jsc or build-webkit will also build LLVM, and then quickly
symlink things into place without perturbing dependency tracking.
Internal LLVM directory: if you check out llvm into a directory called 'llvm'
right off of the WebKit source tree, then the build system will automatically
use this.
Here's how this takes care of dependencies:
Headers: the include/llvm and include/llvm-c directories are symlinked into
$productsDir/usr/local/include. And then everything just works.
Libraries: the build system detects, by reading LLVM's Makefile.config, which
mode LLVM is built in (like Release+Asserts or Debug+Asserts) and symlinks
the .a files into $productsDir/<thingy>. It will ranlib those libraries only
if they have changed, by checking both the modification time and also whether
the last time we had a symlink, that symlink was from the same directory.
This helps if you switch to an *older* LLVM build (using LLVM_SOURCE_PATH)
but that build wasn't yet ranlib'd.
One problem that this does not yet solve is that xcodebuild will not relink
JavaScriptCore if the only thing that changed was the libraries. I will work
on this problem separately: https://bugs.webkit.org/show_bug.cgi?id=114926.
- Scripts/copy-webkitlibraries-to-product-directory:
(unpackIfNecessary):
(fileContains):
(fileContentsEquals):
- 1:52 PM Changeset in webkit [148847] by
-
- 2 edits in trunk/LayoutTests
Regression(r148672): fast/events/touch/frame-hover-update.html fails
https://bugs.webkit.org/show_bug.cgi?id=114912
Reviewed by Allan Sandfeld Jensen.
Fix relative path to js-test-post.js in fast/events/touch/frame-hover-update.html.
- fast/events/touch/frame-hover-update.html:
- 1:28 PM Changeset in webkit [148846] by
-
- 3 edits in trunk/LayoutTests
Rewrite fast/workers/dedicated-worker-lifecycle.html to verify that
the GC is able to reclaim orphaned Workers on a timely basis.
https://bugs.webkit.org/show_bug.cgi?id=114893.
Reviewed by Geoffrey Garen.
- fast/workers/resources/dedicated-worker-lifecycle.js:
(orphanAllWorkers):
(runTests.worker.onmessage):
(runTests):
(orphanedWorkerExited.worker.onmessage):
(orphanedWorkerExited):
- fast/workers/resources/worker-util.js:
(waitUntilThreadCountMatchesCondition):
(waitUntilThreadCountMatches):
(waitUntilThreadCountDoesNotExceed):
- 12:51 PM Changeset in webkit [148845] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark css1/cascade/cascade_order.html as flaky.
- platform/efl/TestExpectations:
- 12:48 PM Changeset in webkit [148844] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark several webgl tests as flaky.
Mark several ref tests as failing (started between r148032 and r148102).
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 12:15 PM Changeset in webkit [148843] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark websocket tests as flaky and webgl/conformance/rendering/gl-scissor-test.html
as failing.
- platform/efl-wk2/TestExpectations:
- 11:53 AM Changeset in webkit [148842] by
-
- 4 edits in branches/safari-536.30-branch/Source
Versioning.
- 11:51 AM Changeset in webkit [148841] by
-
- 1 copy in tags/Safari-536.30.2
New Tag.
- 11:36 AM Changeset in webkit [148840] by
-
- 4 edits2 adds in trunk
[GStreamer] Media attribute preload="none" is not honored
https://bugs.webkit.org/show_bug.cgi?id=114357
Reviewed by Philippe Normand.
Source/WebCore:
Fix the logic that prevents live streams from being buffered to not make preload="none" ignored.
Test: http/tests/media/video-preload.html
We need a http test because the bug does not triggered with local files.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
Remove m_originalPreloadWasAutoAndWasOverridden because it is not necessary and it is causing this bug.
Currently if the tag has preload="none" attribute we set m_preload to Auto in the constructor. After that
MedaPlayer calls setPreload(None), so we set m_originalPreloadWasAutoAndWasOverridden to true and later
reset m_preload to Auto. The error prone factor here is that the m_preload member is repeated in the
private class and setPreload is also used there. This seems to be necessary because we need to be able
to ignore preloading if this is a live stream. Fortunately the original parsed value is available in the
constructor, so we can use that. This will give the correct value that we should override only in the case
of a live stream and that's it, we don't need to reset it later to Auto.
Furthermore, we should ignore setting preload to auto from js if it is a live stream. This patch also handles
this with an early return in setPreload.
LayoutTests:
- http/tests/media/video-preload-expected.txt: Added.
- http/tests/media/video-preload.html: Added.
- 10:46 AM Changeset in webkit [148839] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark several tests as failing on EFL port due to the bump to libsoup
2.42.0.
- platform/efl/TestExpectations:
- 10:34 AM Changeset in webkit [148838] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark several test cases as failing on EFL port and filed bugs for them.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 10:19 AM Changeset in webkit [148837] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark websocket tests as flaky on EFL WK2.
- platform/efl-wk2/TestExpectations:
- 10:11 AM Changeset in webkit [148836] by
-
- 17 edits2 adds in branches/dfgFourthTier/Source
fourthTier: It should be possible to query WatchpointSets, and add Watchpoints, even if the compiler is running in another thread
https://bugs.webkit.org/show_bug.cgi?id=114909
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
The idea here is that a concurrent compiler will use watchpoint sets as follows:
During concurrent compilation: It will create Watchpoints, and query WatchpointSets only
for the purpose of profiling. That is, it will use decide whether it is profitable to
compile the code "as if" the watchpoint sets are valid.
During synchronous linking: By "linking" I don't necessarily mean the LinkBuffer stuff,
but just the very bitter end of compilation where we make the JIT code callable. This
can happen after LinkBuffer stuff. Anyway, this will have to happen synchronously, and
at that point we can (a) check that all WatchpointSets that we assumed were valid are
still valid and (b) if they are then we add the watchpoints to those sets. If any of the
sets are invalid, we give up on this compilation and try again later.
The querying of WatchpointSets is engineered to say that the set is still valid if it
is so *right now*, but this is done in a racy way and so it may say so spuriously: we
may, with hopefully low probability, have a set that says it is valid even though it was
just invalidated. The goal is only to ensure that (i) a set never claims to be invalid
if it is actually valid, (ii) a set doesn't claim to be valid if it was invalidated
before compilation even began, and (iii) querying the validity of a set doesn't cause us
to crash.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/Watchpoint.cpp:
(JSC::InlineWatchpointSet::inflateSlow):
- bytecode/Watchpoint.h:
(WatchpointSet):
(InlineWatchpointSet):
(JSC::InlineWatchpointSet::hasBeenInvalidated):
(JSC::InlineWatchpointSet::isThin):
(JSC::InlineWatchpointSet::isFat):
(JSC::InlineWatchpointSet::fat):
- dfg/DFGDesiredWatchpoints.cpp: Added.
(DFG):
(JSC::DFG::DesiredWatchpoints::DesiredWatchpoints):
(JSC::DFG::DesiredWatchpoints::~DesiredWatchpoints):
(JSC::DFG::DesiredWatchpoints::addLazily):
(JSC::DFG::DesiredWatchpoints::reallyAdd):
(JSC::DFG::DesiredWatchpoints::areStillValid):
- dfg/DFGDesiredWatchpoints.h: Added.
(DFG):
(JSC::DFG::WatchpointForGenericWatchpointSet::WatchpointForGenericWatchpointSet):
(WatchpointForGenericWatchpointSet):
(GenericDesiredWatchpoints):
(JSC::DFG::GenericDesiredWatchpoints::GenericDesiredWatchpoints):
(JSC::DFG::GenericDesiredWatchpoints::addLazily):
(JSC::DFG::GenericDesiredWatchpoints::reallyAdd):
(JSC::DFG::GenericDesiredWatchpoints::areStillValid):
(DesiredWatchpoints):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addLazily):
(JITCompiler):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLCompile.h:
(FTL):
- ftl/FTLState.h:
(State):
- runtime/JSFunction.h:
(JSFunction):
(JSC::JSFunction::allocationProfileWatchpointSet):
- runtime/Structure.h:
(Structure):
(JSC::Structure::transitionWatchpointSet):
Source/WTF:
Reviewed by Oliver Hunt.
Harden our notions of memory fences, now that we're doing racy algorithms.
- wtf/Atomics.h:
(WTF):
(WTF::compilerFence):
(WTF::armV7_dmb):
(WTF::armV7_dmb_st):
(WTF::loadLoadFence):
(WTF::loadStoreFence):
(WTF::storeLoadFence):
(WTF::storeStoreFence):
(WTF::memoryBarrierAfterLock):
(WTF::memoryBarrierBeforeUnlock):
(WTF::x86_mfence):
- 9:14 AM Changeset in webkit [148835] by
-
- 2 edits in trunk/LayoutTests
fast/media/mq-resolution.html throws TypeError when calling setPageScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=114914
Reviewed by Antonio Gomes.
Update fast/media/mq-resolution.html to call setPageScaleFactor() method on
window.internals instead of window.internals.settings. This method was moved
out of settings in r136055.
- fast/media/mq-resolution.html:
- 9:13 AM Changeset in webkit [148834] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebCore
Rollout r145656. <rdar://problem/13691099>
- 8:11 AM Changeset in webkit [148833] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline fast/forms/validation-message-appearance.html and fix expectation
for editing/pasteboard/paste-text-004.html.
- platform/efl/TestExpectations:
- platform/efl/fast/forms/validation-message-appearance-expected.png: Added.
- platform/efl/fast/forms/validation-message-appearance-expected.txt:
- 8:02 AM Changeset in webkit [148832] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark more compositing test cases as crashing due to r148433 for
EFL port.
- platform/efl/TestExpectations:
- 7:22 AM Changeset in webkit [148831] by
-
- 2 edits in trunk/LayoutTests
Regression(r148672): fast/events/touch/frame-hover-update.html fails
https://bugs.webkit.org/show_bug.cgi?id=114912
Reviewed by Allan Sandfeld Jensen.
Fix relative path to js-test-pre.js in the test case.
- fast/events/touch/frame-hover-update.html:
- 7:10 AM Changeset in webkit [148830] by
-
- 5 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline several test cases for EFL port.
- platform/efl-wk2/http/tests/inspector/console-resource-errors-expected.txt:
- platform/efl/fast/backgrounds/background-position-parsing-expected.png:
- platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
- platform/wk2/loader/go-back-cached-main-resource-expected.txt:
- 6:54 AM Changeset in webkit [148829] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Remove duplicate entry in EFL's TestExpectations for:
inspector/debugger/dynamic-script-tag.html
- platform/efl/TestExpectations:
- 6:50 AM Changeset in webkit [148828] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark more compisiting / webgl tests as crashing due to r148433 for
EFL port.
- platform/efl/TestExpectations:
- 5:56 AM Changeset in webkit [148827] by
-
- 51 deletes in trunk/LayoutTests/platform/gtk
Unreviewed GTK gardening. Removing the remaining redundant baselines.
- 5:54 AM Changeset in webkit [148826] by
-
- 208 edits51 adds in trunk/LayoutTests/platform/gtk
Unreviewed GTK gardening. Updating baselines for tests under accessibility, fast/backgrounds, fast/body-propagation,
fast/doctypes, fast/fast-mobile-scrolling, fast/inspector-support, fast/loader, fast/tokenizer and fast/xsl directories
after enabling the subpixel layout.
- 5:46 AM Changeset in webkit [148825] by
-
- 726 edits124 adds in trunk/LayoutTests/platform/gtk/fast
Unreviewed GTK gardening. Updating baselines for tests under fast/block, fast/borders, fast/box-shadow,
fast/box-sizing, fast/canvas, fast/clip and fast/compact directories after enabling subpixel layout.
- 4:06 AM Changeset in webkit [148824] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark several compositing test as crashing on EFL port due to
r148433.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 3:07 AM Changeset in webkit [148823] by
-
- 15 edits in trunk/Source
Widget should not depend on AXObjectCache
https://bugs.webkit.org/show_bug.cgi?id=114514
Reviewed by Chris Fleizach.
Source/WebCore:
Move AXObjectCache usage from platform files to FrameView.
- WebCore.exp.in: Update symbols.
- page/FrameView.cpp:
(WebCore::FrameView::didAddScrollbar): Handle scrollbar updates in
AXObjectCache.
(WebCore::FrameView::willRemoveScrollbar): Handle scrollbar
updates in AXObjectCache and remove the scrollbar from the cache.
- page/FrameView.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar): Use
didAddScrollbar/willRemoveScrollbar
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::didAddScrollbar): This is the old
didAddVerticalScrollbar and didAddHorizontalScrollbar joined in a
single method that receives a ScrollbarOrientation parameter.
(WebCore::ScrollableArea::willRemoveScrollbar): This is the old
willRemoveVerticalScrollbar and
willRemoveHorizontalScrollbarScrollbar joined in a single method
that receives a ScrollbarOrientation parameter.
- platform/ScrollableArea.h:
(ScrollableArea):
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::~Scrollbar): Remove AXObjectCache usage.
- platform/Scrollbar.h:
- platform/Widget.h:
(Widget): Remove axObjectCache() method.
- platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createScrollbar): Use didAddScrollbar.
(WebCore::RenderLayer::destroyScrollbar): Use willRemoveScrollbar.
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::createScrollbar): Use didAddScrollbar.
(WebCore::RenderListBox::destroyScrollbar): Use willRemoveScrollbar.
Source/WebKit2:
Update to API changes.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::createScrollbar):
- WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
(WebKit::SimplePDFPlugin::createScrollbar):
(WebKit::SimplePDFPlugin::destroyScrollbar):
- 2:26 AM Changeset in webkit [148822] by
-
- 529 edits121 adds in trunk/LayoutTests/platform/gtk/fast
Unreviewed GTK gardening. Updating baselines for tests under fast/css, fast/css-generated-content,
fast/css3-text and fast/dom directories after enabling the subpixel layout.
- 2:18 AM Changeset in webkit [148821] by
-
- 611 edits171 adds in trunk/LayoutTests/platform/gtk/fast
Unreviewed GTK gardening. Updating baselines for tests under fast/dynamic, fast/encoding, fast/events,
fast/flexbox, fast/forms, fast/frames, fast/gradients, fast/hidpi and fast/html directories after enabling subpixel layout.
- 2:04 AM Changeset in webkit [148820] by
-
- 2 edits in trunk/Source/JavaScriptCore
Refactor identical inline functions in JSVALUE64 and JSVALUE32_64 sections
out into the common section.
https://bugs.webkit.org/show_bug.cgi?id=114910.
Reviewed by Filip Pizlo.
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::callOperation):
- 1:23 AM Changeset in webkit [148819] by
-
- 305 edits170 adds in trunk/LayoutTests/platform/gtk/fast
Unreviewed GTK gardening. Updating baselines for tests under fast/images, fast/inline, fast/inline-block,
fast/invalid, fast/js, fast/layers, fast/line-grid, fast/lists and fast/multicol directories after enabling subpixel layout.
- 1:15 AM Changeset in webkit [148818] by
-
- 379 edits80 adds in trunk/LayoutTests/platform/gtk/fast
Unreviewed GTK gardening. Updating baselines for tests under fast/overflow, fast/parser, fast/reflections,
fast/regions and fast/repaint directories after enabling subpixel layout.
- 1:05 AM Changeset in webkit [148817] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening. Remove duplicated tests.
- platform/efl/TestExpectations:
- 12:48 AM Changeset in webkit [148816] by
-
- 645 edits157 adds in trunk/LayoutTests/platform/gtk
Unreviewed GTK gardening. Updating baselines for tests under fast/replaced, fast/ruby, fast/runin,
fast/scrolling, fast/selectors, fast/spatial-navigation, fast/subpixel and mathml directories after enabling subpixel layout.
- 12:38 AM Changeset in webkit [148815] by
-
- 547 edits178 adds in trunk/LayoutTests/platform/gtk
Unreviewed GTK gardening. Updating baselines for tests under fast/text, fast/transforms, fast/writing-mode,
ietestcenter, media, plugins and scrollbars directories after enabling the subpixel layout.
- 12:29 AM Changeset in webkit [148814] by
-
- 20 deletes in trunk/LayoutTests/platform/gtk/svg
Unreviewed GTK gardening. Removing redundant baselines under the svg/ directory.
- 12:27 AM Changeset in webkit [148813] by
-
- 175 edits17 adds in trunk/LayoutTests/platform/gtk/svg/dynamic-updates
Unreviewed GTK gardening. Part 2 of updating baselines for tests under svg/dynamic-updates after enabling the subpixel layout.
- 12:22 AM Changeset in webkit [148812] by
-
- 138 edits33 adds2 deletes in trunk/LayoutTests/platform/gtk/svg/dynamic-updates
Unreviewed GTK gardening. Part 1 of updating baselines for tests under svg/dynamic-updates after enabling the subpixel layout.
- 12:15 AM Changeset in webkit [148811] by
-
- 668 edits52 adds in trunk/LayoutTests/platform/gtk/tables/mozilla/bugs
Unreviewed GTK gardening. Part 3 of updating baselines for tests under the tables/ directory
after enabling the subpixel layout.
- 12:06 AM Changeset in webkit [148810] by
-
- 658 edits30 adds in trunk/LayoutTests/platform/gtk/tables/mozilla
Unreviewed GTK gardening. Part 2 of updating baselines for tests under the tables/ directory
after enabling the subpixel layout.
Apr 20, 2013:
- 11:57 PM Changeset in webkit [148809] by
-
- 405 edits21 adds in trunk/LayoutTests/platform/gtk/tables
Unreviewed GTK gardening. Part 1 of updating baselines for tests under the tables directory
after enabling the subpixel layout for the GTK port.
- 11:27 PM Changeset in webkit [148808] by
-
- 205 edits22 adds in trunk/LayoutTests/platform/gtk/svg
Unreviewed GTK gardening. Updating baselines for tests under svg/batik, svg/canvas, svg/carto.net, svg/clip-path,
svg/css, svg/custom and svg/hixie after enabling the subpixel layout.
- 11:23 PM Changeset in webkit [148807] by
-
- 534 edits54 adds in trunk/LayoutTests/platform/gtk/svg
Unreviewed GTK gardening. Updating baselines for tests under svg/W3C-* after enabling the subpixel layout.
- 10:53 PM Changeset in webkit [148806] by
-
- 510 edits84 adds in trunk/LayoutTests/platform/gtk/svg
Unreviewed GTK gardening. Updating baselines for tests under svg/custom, svg/dom, svg/in-html,
svg/overflow, svg/repaint and svg/transforms after enabling the subpixel layout.
- 10:43 PM Changeset in webkit [148805] by
-
- 256 edits156 adds in trunk/LayoutTests/platform/gtk/svg
Unreviewed GTK gardening. Updating baselines for tests under svg/as-*, svg/filters, svg/stroke,
svg/text, svg/wicd and svg/zoom directories after enabling subpixel layout for the GTK port.
Patch #7 of approx. 24,
svn commitis used directly to avoid the webkit-patch and ChangeLog overhead.
- 10:13 PM Changeset in webkit [148804] by
-
- 31 edits2 adds in branches/dfgFourthTier/Source
fourthTier: value profiles and array profiles should be thread-safe enough to be accessible in a concurrent compilation thread
https://bugs.webkit.org/show_bug.cgi?id=114906
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
This introduces thread safety to value profiles, array profiles, and
array allocation profiles.
We already have three separate operations that happen on profiles:
(1) writing, which the JIT, LLInt, and OSR exit do; (2) updating,
which happens during GC, from OSR entry slow-paths, and in the DFG;
and (3) reading, which happens in the DFG. For example, the JIT/LLInt
and OSR exit write to ValueProfile::m_buckets, which gets synthesized
into ValueProfile::m_prediction (and other fields) during update, and
the latter gets read by the DFG. Note that (2) must also happen in
the DFG since only the DFG knows which code blocks it will inline,
and those blocks' profiles may not have otherwise been updated via
any other mechanism.
I refer to these three operations as writing, updating, and reading.
Consequently, both profile updating and profile reading may happen
asynchronously, if the JIT is asynchronous.
The locking protocol for profiles works as follows:
- Writing does not require locking, but is only allowed on the main thread. We require that these fields can be stored atomically by the profiling code, even without locks. For value profiles, this only works on 64-bit platforms, currently. For array profiles, which consist of multiple separate fields, this means that an asynchronous update of the profile may see slight inconsistencies (like a structure that doesn't quite match the array modes bits), but these should be harmless: at worst, the DFG will specialize too much and we'll have OSR exits.
- Updating a value profile requires holding a lock, but must assume that the fields written by the profiling code in JIT/LLInt may be written to without locking.
- Reading a value profile requires holding a lock.
The one major exception to these rules is the ArrayAllocationProfile,
which requires no locking. We do this because it's used so often and
in places where we don't necessarily have access to the owning
CodeBlock, so if we did want it to be locked it would have to have
its own lock. Also, I believe that it is sound to just make this
profile racy and not worry about locking at all. All that was needed
were some changes to ensure that we explicitly read some raced-over
fields only once.
Two additional interesting things in this change:
- To make it easy to see which profile methods require locking, they take a const CodeBlockLocker& as an argument. I saw this idiom for identifying which methods require which locks to be held being used in LLVM, and I quite like it.
- Lazy operand value profiles, which are created lazily and at any time, require the CodeBlockLock to be held when they are being created. Writes to them are lockless and main-thread-only, but as with other profiles, updates and reads require locking.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/ArrayAllocationProfile.cpp:
(JSC::ArrayAllocationProfile::updateIndexingType):
- bytecode/ArrayAllocationProfile.h:
(JSC::ArrayAllocationProfile::selectIndexingType):
- bytecode/ArrayProfile.cpp:
(JSC::ArrayProfile::computeUpdatedPrediction):
(JSC::ArrayProfile::briefDescription):
- bytecode/ArrayProfile.h:
(ArrayProfile):
(JSC::ArrayProfile::expectedStructure):
(JSC::ArrayProfile::structureIsPolymorphic):
(JSC::ArrayProfile::hasDefiniteStructure):
(JSC::ArrayProfile::observedArrayModes):
(JSC::ArrayProfile::mayInterceptIndexedAccesses):
(JSC::ArrayProfile::mayStoreToHole):
(JSC::ArrayProfile::outOfBounds):
(JSC::ArrayProfile::usesOriginalArrayStructures):
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpValueProfiling):
(JSC::CodeBlock::dumpArrayProfiling):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::updateAllArrayPredictions):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):
(JSC::CodeBlock::updateAllPredictionsAndCheckIfShouldOptimizeNow):
(CodeBlock):
- bytecode/CodeBlockLock.h: Added.
(JSC):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/LazyOperandValueProfile.cpp:
(JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):
(JSC::CompressedLazyOperandValueProfileHolder::add):
(JSC::LazyOperandValueProfileParser::LazyOperandValueProfileParser):
(JSC::LazyOperandValueProfileParser::~LazyOperandValueProfileParser):
(JSC):
(JSC::LazyOperandValueProfileParser::initialize):
(JSC::LazyOperandValueProfileParser::prediction):
- bytecode/LazyOperandValueProfile.h:
(CompressedLazyOperandValueProfileHolder):
(LazyOperandValueProfileParser):
- bytecode/MethodOfGettingAValueProfile.cpp:
(JSC::MethodOfGettingAValueProfile::getSpecFailBucket):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- bytecode/ResolveGlobalStatus.cpp:
(JSC::ResolveGlobalStatus::computeFor):
- bytecode/ValueProfile.h:
(JSC::ValueProfileBase::briefDescription):
(ValueProfileBase):
(JSC::ValueProfileBase::computeUpdatedPrediction):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::fromObserved):
- dfg/DFGArrayMode.h:
(ArrayMode):
(JSC::DFG::ArrayMode::withProfile):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGOSRExitPreparation.cpp:
(JSC::DFG::prepareCodeOriginForOSRExit):
- dfg/DFGPredictionInjectionPhase.cpp:
(JSC::DFG::PredictionInjectionPhase::run):
- jit/JITInlines.h:
(JSC::JIT::chooseArrayMode):
- jit/JITStubs.cpp:
(JSC::tryCachePutByID):
(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::lazyLinkFor):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::setUpCall):
- profiler/ProfilerBytecodeSequence.cpp:
(JSC::Profiler::BytecodeSequence::BytecodeSequence):
- runtime/JSScope.cpp:
(JSC::JSScope::resolveContainingScopeInternal):
(JSC::JSScope::resolvePut):
Source/WTF:
Reviewed by Oliver Hunt.
Add ability to abstract whether or not the CodeBlock requires locking at all,
since some platforms may not support the byte spin-locking and/or may not want
to, if they turn off concurrent JIT.
- WTF.xcodeproj/project.pbxproj:
- wtf/ByteSpinLock.h:
- wtf/NoLock.h: Added.
(WTF):
(NoLock):
(WTF::NoLock::lock):
(WTF::NoLock::unlock):
(WTF::NoLock::isHeld):
- wtf/Platform.h:
- 9:38 PM Changeset in webkit [148803] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
Unreviewed, 32-bit build fix.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::tallyFrequentExitSites):
- 8:47 PM EFLWebKitBuildBots edited by
- (diff)
- 8:44 PM EFLWebKitBuildBots edited by
- (diff)
- 8:32 PM Changeset in webkit [148802] by
-
- 22 edits1 add in trunk
[Part 5] Parse color value for custom() function parameters
https://bugs.webkit.org/show_bug.cgi?id=114902
Reviewed by Dean Jackson.
Source/WebCore:
Custom filter parameters should support color values. Added parsing
and style resolving bits to support color values. A later patch will
add the color values to the shader program.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-parameters
Modified existing tests to cover changes.
- GNUmakefile.list.am: Added CustomFilterColorParameter to support color values
as custom filter parameters.
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForCustomFilterColorParameter):
(WebCore):
(WebCore::valueForCustomFilterParameter):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseCustomFilterParameters):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::parseCustomFilterColorParameter):
(WebCore):
(WebCore::StyleResolver::parseCustomFilterParameter):
- css/StyleResolver.h:
(StyleResolver):
- platform/graphics/filters/CustomFilterColorParameter.h: Added.
(WebCore):
(WebCore::blendFunc):
(CustomFilterColorParameter):
(WebCore::CustomFilterColorParameter::create):
(WebCore::CustomFilterColorParameter::blend):
(WebCore::CustomFilterColorParameter::color):
(WebCore::CustomFilterColorParameter::setColor):
(WebCore::CustomFilterColorParameter::operator==):
(WebCore::CustomFilterColorParameter::CustomFilterColorParameter):
(WebCore::CustomFilterColorParameter::~CustomFilterColorParameter):
- platform/graphics/filters/CustomFilterParameter.h:
(CustomFilterParameter):
- platform/graphics/filters/CustomFilterRenderer.cpp:
(WebCore::CustomFilterRenderer::bindProgramParameters):
LayoutTests:
Added tests for color parameters on custom fiter function and parameter descriptor.
- css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-invalid.js:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-valid.js:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-invalid.js:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-valid.js:
- 4:25 PM Changeset in webkit [148801] by
-
- 937 edits275 adds in trunk/LayoutTests/platform/gtk/editing
Unreviewed GTK gardening. Updating baselines for editing tests after enabling subpixel layout for the GTK port.
- 4:11 PM Changeset in webkit [148800] by
-
- 549 edits79 adds in trunk/LayoutTests/platform/gtk/css3
Unreviewed GTK gardening. Updating baselines for the remaining tests under the css3 directory
after enabling the subpixel layout for the GTK port.
- 4:03 PM Changeset in webkit [148799] by
-
- 822 edits114 adds in trunk/LayoutTests/platform/gtk/css3/selectors3
Unreviewed GTK gardening. Updating baselines for the css3/selectors/html and css3/selectors/xml tests
after enabling the subpixel layout. Patch #3 of many more.
- 3:51 PM Changeset in webkit [148798] by
-
- 1372 edits104 adds in trunk/LayoutTests/platform/gtk/css2.1
Unreviewed GTK gardening, updating css2.1 baselines after enabling the subpixel layout.
- 1:13 PM Changeset in webkit [148797] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed gardening. Rebaseline after r148792. Fix mac-wk2 text.
- platform/mac-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
- 1:11 PM Changeset in webkit [148796] by
-
- 2 edits in trunk/PerformanceTests/SunSpider
SunSpider/string-tagcloud should be more lenient in validating its results, since they depend on Math.log, which isn't formally specified
https://bugs.webkit.org/show_bug.cgi?id=114895
Reviewed by Michael Saboff.
- tests/sunspider-1.0/string-tagcloud.js:
- 12:55 PM Changeset in webkit [148795] by
-
- 170 edits126 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaseline #1 after enabling the subpixel layout, covering the animations, css1, fonts, fullscreen,
transforms and transitions directories.
- 12:22 PM Changeset in webkit [148794] by
-
- 2 edits1 add in trunk/Tools
[GTK] Fix baseline positioning issue by updating Freetype
https://bugs.webkit.org/show_bug.cgi?id=106775
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: Bump the Freetype Jhbuild dependency to 2.4.11.
- gtk/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added. This is the Freetype
patch (committed as e0469372) that fixes rounding issues for smaller fonts. It is bound to be included
in the 2.4.12 release of Freetype (not released yet) but is provided here as its effect on baselines is
considered positive and will reduce the amout of future rebaselining.
- 12:21 PM Changeset in webkit [148793] by
-
- 2 edits in trunk
Enable sub-pixel layout for the GTK port
https://bugs.webkit.org/show_bug.cgi?id=94792
Reviewed by Martin Robinson.
- Source/autotools/SetupWebKitFeatures.m4: Enable the subpixel layout.
- 12:20 PM Changeset in webkit [148792] by
-
- 6 edits1 copy in trunk/LayoutTests
Unreviewed gardening. Rebaseline after r148791. Update text expectations.
- platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/mac-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Copied from LayoutTests/platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt.
- platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- 9:41 AM Changeset in webkit [148791] by
-
- 4 edits4 adds in trunk
REGRESSION (r147588): Line breaks occur in the middle of Hebrew words at haaertz.co.il and other websites
https://bugs.webkit.org/show_bug.cgi?id=114721
Reviewed by Dean Jackson.
Source/WebCore:
Tests: fast/text/line-break-after-empty-inline-hebrew.html
fast/text/line-break-after-inline-latin1.html
If prior context changes content or length after creating line break iterator, then need to
create new iterator with new prior context instead of using cached iterator with old prior context.
- platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator): Initialize members to cache reference to initialized prior context.
(WebCore::LazyLineBreakIterator::get): Create new iterator if prior context content reference changes.
(WebCore::LazyLineBreakIterator::resetStringAndReleaseIterator): Reset cached prior context references.
(LazyLineBreakIterator): Add members to cache reference to initialized prior context.
LayoutTests:
- fast/text/line-break-after-empty-inline-hebrew-expected.txt: Added.
- fast/text/line-break-after-empty-inline-hebrew.html: Added.
- fast/text/line-break-after-inline-latin1-expected.txt: Added.
- fast/text/line-break-after-inline-latin1.html: Added.
- platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Rebaseline.
- 3:27 AM Changeset in webkit [148790] by
-
- 8 edits in trunk/Source
LLint should be able to use x87 instead of SSE for floating pointer
https://bugs.webkit.org/show_bug.cgi?id=112239
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Implements LLInt floating point operations in x87, to ensure we support
x86 without SSE2.
X86 (except 64bit) now defaults to using x87 instructions in order to
support all 32bit x86 back to i686. The implementation uses the fucomi
instruction from i686 which sets the new minimum.
The FPU registers must always be empty on entering or exiting a function.
We make sure to only use two X87 registers, and they are always emptied
before calling deeper functions or returning from the LLInt.
- jit/JITStubs.cpp:
(JSC): Empty FPU registers before exiting.
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/instructions.rb:
- offlineasm/x86.rb:
Source/WTF:
Disable GTK workaround now that LLInt does not require SSE2.
- wtf/Platform.h:
- 2:53 AM Changeset in webkit [148789] by
-
- 2 edits in trunk
[Qt][Mac] Remove obsolete workaround for debug builds
https://bugs.webkit.org/show_bug.cgi?id=114750
Reviewed by Jocelyn Turcotte.
This workaround made default builds fail with recent Qt5 because
it removed the major version number from the library name, producing
QtWebKitWidgets, whereas the linking command line tried to link
against Qt5WebKitWidgets.
Debug builds are possible with and without framework-enabled builds
of Qt, but the debug versions of the Qt libraries have to be present.
Debug builds with a release version of Qt are not possible on Mac
since for debug builds qmake produces a linker command line where
all the Qt libraries have the "_debug" suffix, therefore if the debug
libraries are missing the build fails.
- Source/widgetsapi.pri:
- 1:23 AM Changeset in webkit [148788] by
-
- 8 edits in trunk
[GTK] Fix unit test webkit2/WebKitFindController/hide
https://bugs.webkit.org/show_bug.cgi?id=89810
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-20
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
The test had some hacks in order to compare a page with highlighted
results after using the find command with the original page. Now it uses
the snapshots API that allows to make the test simpler and more
reliable.
- UIProcess/API/gtk/tests/TestMain.h:
(Test::cairoSurfacesEqual): Moved helper function to compare two cairo
surfaces from TestWebKitWebView.
(Test):
- UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
(testFindControllerHide): Modify test to use snapshots.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewSnapshot): Move basic snapshop methods to WebViewTest to
share them with TestWebKitFindController test.
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::WebViewTest): Initialize cairo surface.
(WebViewTest::~WebViewTest): Destroy cairo surface.
(onSnapshotReady): Callback to set the cairo surface when the snapshot
is ready.
(WebViewTest::getSnapshotAndWaitUntilReady): Method that takes a
snapshot and returns the cairo surface when it is ready.
- UIProcess/API/gtk/tests/WebViewTest.h: Add new method headers and
attribute for the cairo surface.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Unskip test webkit2/WebKitFindController/hide.
Apr 19, 2013:
- 9:38 PM Changeset in webkit [148787] by
-
- 4 edits in trunk/Source/WebCore
[EFL] Arrow of combo box are drawn twice
https://bugs.webkit.org/show_bug.cgi?id=113917
Reviewed by Gyuyoung Kim.
combo_button_icon part is for arrow so that images of combo_button part should
not contain arrow.
No new tests required due to no behavioral change.
- platform/efl/DefaultTheme/widget/combo/combo_focus_button.png:
- platform/efl/DefaultTheme/widget/combo/combo_hover_button.png:
- platform/efl/DefaultTheme/widget/combo/combo_press_button.png:
- 6:03 PM Changeset in webkit [148786] by
-
- 3 edits in trunk/LayoutTests
[css exclusions] Fix up shape-inside-recursive-layout test case
https://bugs.webkit.org/show_bug.cgi?id=114890
Reviewed by Dirk Schulze.
The children of the old-flexbox, new-flexbox, and grid shape-inside containers
should have their display value set to -webkit-inline-box, -webkit-inline-flex,
and -webkit-inline-grid respectively. These values should not be set for
the containers themselves, as we are interested in the behavior of descendants
of the shape-inside container.
- fast/exclusions/shape-inside/shape-inside-recursive-layout-expected.html:
- fast/exclusions/shape-inside/shape-inside-recursive-layout.html:
- 6:03 PM Changeset in webkit [148785] by
-
- 38 edits12 copies1 move5 adds in trunk/Source/WebCore
Add interfaces and stubs for audio and video tracks
https://bugs.webkit.org/show_bug.cgi?id=113965
Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-19
Reviewed by Jer Noble.
No new tests because there's no implementations, so there's nothing
interesting to test.
- CMakeLists.txt: Add AudioTrack, VideoTrack, AudioTrackList and VideoTrackList.
- DerivedSources.cpp: Same.
- DerivedSources.make: Same.
- DerivedSources.pri: Same.
- GNUmakefile.list.am: Same.
- Target.pri: Same.
- UseJSC.cmake: Same.
- WebCore.vcproj/WebCore.vcproj: Same.
- WebCore.xcodeproj/project.pbxproj: Same.
- bindings/gobject/GNUmakefile.am: Same.
- bindings/js/JSAudioTrackCustom.cpp: Added, based on JSTestTrackCustom
- bindings/js/JSAudioTrackListCustom.cpp: Same.
- bindings/js/JSBindingsAllInOne.cpp: Add AudioTrack, VideoTrack, AudioTrackList and VideoTrackList.
- bindings/js/JSVideoTrackCustom.cpp: Added, based on JSTestTrackCustom
- bindings/js/JSVideoTrackListCustom.cpp: Same.
- dom/EventTarget.h: Make AudioTrackList and VideoTrackList event targets.
- dom/EventTargetFactory.in: Same.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Add m_audioTracks and m_videoTracks
(WebCore::HTMLMediaElement::~HTMLMediaElement): Clear clients for audio and video tracks
(WebCore::HTMLMediaElement::audioTrackEnabledChanged): Added.
(WebCore::HTMLMediaElement::videoTrackSelectedChanged): Added.
(WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack): Added, based on mediaPlayerDidAddTextTrack
(WebCore::HTMLMediaElement::mediaPlayerDidAddVideoTrack): Same.
(WebCore::HTMLMediaElement::mediaPlayerDidRemoveAudioTrack): Added, based on mediaPlayerDidRemoveTextTrack
(WebCore::HTMLMediaElement::mediaPlayerDidRemoveVideoTrack): Same.
(WebCore::HTMLMediaElement::addAudioTrack): Added, based on addTextTrack
(WebCore::HTMLMediaElement::addVideoTrack): Same.
(WebCore::HTMLMediaElement::removeAudioTrack): Added, based on removeTextTrack
(WebCore::HTMLMediaElement::removeVideoTrack): Added, based on removeTextTrack
(WebCore::HTMLMediaElement::removeAllInbandTracks): Remove audio and video tracks too
(WebCore::HTMLMediaElement::audioTracks): Added, based on textTracks
(WebCore::HTMLMediaElement::videoTracks): Added, based on textTracks
(WebCore::HTMLMediaElement::reportMemoryUsage): Add audio and video tracks
- html/HTMLMediaElement.h: Add audioTracks and videoTracks and related functions
- html/HTMLMediaElement.idl: Add audioTracks and videoTracks
- html/track/AudioTrack.cpp: Added, based on TextTrack and InbandTextTrack.
- html/track/AudioTrack.h: Same.
- html/track/AudioTrack.idl: Added.
- html/track/AudioTrackList.cpp: Added, based on TextTrackList
- html/track/AudioTrackList.h: Same.
- html/track/AudioTrackList.idl: Added.
- html/track/TextTrackList.h: Add missing OVERRIDE on interfaceName()
- html/track/VideoTrack.cpp: Added, based on TextTrack and InbandTextTrack.
- html/track/VideoTrack.h: Same.
- html/track/VideoTrack.idl: Added.
- html/track/VideoTrackList.cpp: Added, based on TextTrackList
- html/track/VideoTrackList.h: Same.
- html/track/VideoTrackList.idl: Added.
- platform/graphics/AudioTrackPrivate.h: Added, based on InbandTextTrackPrivate.h
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::addAudioTrack): Added, based on addTextTrack
(WebCore::MediaPlayer::removeAudioTrack): Added, based on removeTextTrack
(WebCore::MediaPlayer::addVideoTrack): Added, based on addTextTrack
(WebCore::MediaPlayer::removeVideoTrack): Added, based on removeTextTrack
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerDidAddAudioTrack): Added, based on mediaPlayerDidAddTextTrack
(WebCore::MediaPlayerClient::mediaPlayerDidAddVideoTrack): Same
(WebCore::MediaPlayerClient::mediaPlayerDidRemoveAudioTrack): Added, based on mediaPlayerDidRemoveTextTrack
(WebCore::MediaPlayerClient::mediaPlayerDidRemoveVideoTrack): Same
- platform/graphics/VideoTrackPrivate.h: Added, based on InbandTextTrackPrivate.h
- 5:27 PM Changeset in webkit [148784] by
-
- 32 edits in trunk/PerformanceTests/SunSpider
Whenever it is cheap and non-invasive, SunSpider tests should validate their results to ensure that the browser runs them correctly
https://bugs.webkit.org/show_bug.cgi?id=114852
Reviewed by Geoffrey Garen.
This adds low-overhead checking of the results of each SunSpider tests. This is not
meant to be an exhaustive test that everything was executed correctly, but rather a
simple sanity check that will catch glaring mistakes. The philosophy here is that we're
not trying to prevent all forms of cheating, or that we're trying to prove the
browser's correctness. Moreover, these checks are meant to incur minimal overhead;
they currently clock in at <2% slow-down in SunSpider 1.0.
The test expectations were generated using the LLInt on command-line, and I've verified
that Firefox 20, Chrome 26, IE 10, Safari 6, and ToT with all of the JITs agree. Note
that some tests cannot be precisely validated because they use Math functions, which
ECMAScript chooses to not formally specify - those functions like sin() and friends are
allowed to return implementation-dependent results. Also some tests cannot be validated
at all because their behavior is either intentionally random or is timezone-dependent.
But 23 out of 26 tests now have some kind of validation.
I've updated the harnesses to show erroneous runs when displaying results.
- resources/TEMPLATE.html:
- resources/driver-TEMPLATE.html:
- resources/sunspider-analyze-results.js:
(formatResult):
(resultLine):
(printOutput):
- resources/sunspider-compare-results.js:
(.formatMean):
(.resultLine):
(.printOutput):
(sunspiderCompareResults):
- resources/sunspider-standalone-driver.js:
- tests/sunspider-1.0/3d-cube.js:
(Init):
- tests/sunspider-1.0/3d-morph.js:
- tests/sunspider-1.0/3d-raytrace.js:
- tests/sunspider-1.0/access-binary-trees.js:
- tests/sunspider-1.0/access-fannkuch.js:
- tests/sunspider-1.0/access-nbody.js:
- tests/sunspider-1.0/access-nsieve.js:
(sieve):
- tests/sunspider-1.0/bitops-3bit-bits-in-byte.js:
- tests/sunspider-1.0/bitops-bits-in-byte.js:
- tests/sunspider-1.0/bitops-bitwise-and.js:
- tests/sunspider-1.0/bitops-nsieve-bits.js:
- tests/sunspider-1.0/controlflow-recursive.js:
- tests/sunspider-1.0/crypto-aes.js:
- tests/sunspider-1.0/crypto-md5.js:
- tests/sunspider-1.0/crypto-sha1.js:
- tests/sunspider-1.0/date-format-tofte.js:
- tests/sunspider-1.0/date-format-xparb.js:
- tests/sunspider-1.0/math-cordic.js:
- tests/sunspider-1.0/math-partial-sums.js:
(partial):
- tests/sunspider-1.0/math-spectral-norm.js:
- tests/sunspider-1.0/regexp-dna.js:
- tests/sunspider-1.0/string-base64.js:
- tests/sunspider-1.0/string-fasta.js:
(fastaRepeat):
(fastaRandom):
- tests/sunspider-1.0/string-tagcloud.js:
- tests/sunspider-1.0/string-unpack-code.js:
- tests/sunspider-1.0/string-validate-input.js:
- 5:15 PM Changeset in webkit [148783] by
-
- 9 edits5 deletes in trunk/Source/WebKit2
Unreviewed, revert r148782. It was not reviewed by a WebKit2 owner.
- PluginProcess/mac/PluginProcessShim.mm:
- Shared/mac/CookieStorageShim.cpp: Removed.
- Shared/mac/CookieStorageShim.h: Removed.
- Shared/mac/CookieStorageShimLibrary.cpp: Removed.
- Shared/mac/CookieStorageShimLibrary.h: Removed.
- Shared/mac/DYLDInterpose.h: Removed.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::addDYLDEnvironmentAdditions):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- WebProcess/mac/SecItemShimLibrary.mm:
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
- 4:32 PM Changeset in webkit [148782] by
-
- 9 edits3 copies2 adds in trunk/Source/WebKit2
WWDC session videos don’t play at developer.apple.com
https://bugs.webkit.org/show_bug.cgi?id=114858
Reviewed by Eric Carlson.
AVFoundation uses CFNetwork to store and retrieve cookies from the global store.
However, in the case where network access happens in the NetworkProcess, session
cookies are stored in-memory, and are not accessable in the WebProcess. Until such
a time as AVFoundation can provide an API which would allow us to provide cookies
for a specific request, we will interpose the CFNetwork method which they use to
retrieve the cookie string from the cookie store for their pending request.
Duplicate the previous SecItemShim target to a new, WebProcessShim target. This
target includes the SecItemShim functionality, but will add a new shim for cookie
retrieval:
- Shared/mac/CookieStorageShimLibrary.h: Added
(CookieStorageShimCallbacks):
- Shared/mac/CookieStorageShimLibrary.cpp: Added.
(WebKit::ShimProtector::ShimProtector): A simple stack-based counter class.
(WebKit::ShimProtector::~ShimProtector):
(WebKit::ShimProtector::count):
(WebKit::shimCFHTTPCookieStorageCopyRequestHeaderFieldsForURL): Interpose
the CFNetwork call, and pass to the registered callback.
(WebKit::WebKitCookieStorageShimInitialize): Register the callbacks.
Add a helper singleton class which will talk to the shim through the
registered callbacks:
- Shared/mac/CookieStorageShim.h: Added
(WebKit::CookieStorageShim::CookieStorageShim):
- Shared/mac/CookieStorageShim.cpp: Added.
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL): Pass the request
over to the NetworkProcess.
(WebKit::CookieStorageShim::shared): Simple singleton.
(WebKit::CookieStorageShim::initialize): Call the library initializer.
Initialize the shim only when the WebProcess is delegating network loading
to the NetworkProcess:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Rename the WebProcess's shim from SecItemShim -> WebProcessShim:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::addDYLDEnvironmentAdditions):
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):
As the DYLD_INTERPOSE macro is used in multiple files now, put it in its
own header:
- Shared/mac/DYLDInterpose.h: Added.
- PluginProcess/mac/PluginProcessShim.mm:
- WebProcess/mac/SecItemShimLibrary.mm:
Add new files to the project:
- WebKit2.xcodeproj/project.pbxproj:
- 4:28 PM Changeset in webkit [148781] by
-
- 7 edits2 adds in trunk
[CSS Exclusions] Implement empty segments for multiple-segment shape-insides
https://bugs.webkit.org/show_bug.cgi?id=100049
Reviewed by David Hyatt.
Source/WebCore:
Content should not overflow a shape-inside segment, even if that means no content
will be placed in that segment. Overflow may be pushed to outside the shape. This
patch removes the restriction that every line must consume at least some text
input while inside a shape-inside. Content that does not fit is pushed down until
it does, either inside the shape or just below it.
Test: fast/exclusions/shape-inside/shape-inside-empty-segments.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::constructBidiRunsForSegment): Do not include empty segments for
consideration, as the actual BidiRuns construction expects to consume at
least one character.
(WebCore::constructBidiRunsForLine): Ditto.
(WebCore::firstPositiveWidth): Find the first positive word measurement width,
as there may be some empty word break measurements inserted.
(WebCore::adjustLogicalLineTop): Move the current line down, if necessary, to
fit it within the shape inside.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): If nothing fit in the
current segment, find the first available position for the smallest item
at the beginning of the text.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Return an empty segment
for a line that is inside the shape, but has no segments.
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Do not consume
input to meet minimum size requirements if you are inside a shape.
LayoutTests:
Testing that shape-insides do not place content where it will not fit. Also
fixing up some previous tests and expectations.
- fast/exclusions/resources/multi-segment-polygon.js:
(simulateWithText): Enable multi-line shape expectations using arrays.
- fast/exclusions/resources/simple-rectangle.js:
(createRectangleTest): Add overflow: break-word property to tests.
(createRectangleTestResult): Ditto.
- fast/exclusions/shape-inside/shape-inside-empty-expected.html: Adjust results
for tests where content should be pushed down.
- fast/exclusions/shape-inside/shape-inside-empty-segments-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-empty-segments.html: Added.
- fast/exclusions/shape-inside/shape-inside-empty.html: Shapes with height but
no width should still push content down below the shape.
- 4:12 PM Changeset in webkit [148780] by
-
- 9 edits in tags/Safari-537.38.2/Source
Merged r148779. <rdar://problem/13696616>
- 4:03 PM Changeset in webkit [148779] by
-
- 9 edits in trunk/Source
Remove uses of WebKit_Source from AppleWin build in WTF and JavaScriptCore.
- JavaScriptCore.vcxproj/JavaScriptCore.make:
- JavaScriptCore.vcxproj/build-generated-files.sh:
- JavaScriptCore.vcxproj/copy-files.cmd:
- JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
- WTF.vcxproj/WTF.make:
- WTF.vcxproj/copy-files.cmd:
- WTF.vcxproj/work-around-vs-dependency-tracking-bugs.py:
(react_to_vsprops_changes):
(react_to_webkit1_interface_changes):
- 4:03 PM Changeset in webkit [148778] by
-
- 2 edits in trunk/Tools
Build fixes for the flakiness dashboard.
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- 3:47 PM Changeset in webkit [148777] by
-
- 2 edits in trunk/Source/WebCore
Add a missing null pointer check after r148759.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
- 3:38 PM Changeset in webkit [148776] by
-
- 4 edits in tags/Safari-537.38.2/Source
Versioning.
- 3:35 PM Changeset in webkit [148775] by
-
- 1 copy in tags/Safari-537.38.2
New Tag.
- 3:16 PM Changeset in webkit [148774] by
-
- 2 edits in trunk/LayoutTests
[Mac] [WK2] Layout Test fast/regions/fixed-pos-elem-in-region.html is flaky on Debug builders
https://bugs.webkit.org/show_bug.cgi?id=114571
- platform/mac-wk2/TestExpectations:
The bots are also seeing image failures flakily, so add that expectation.
- 2:32 PM Changeset in webkit [148773] by
-
- 2 edits in trunk/LayoutTests
[Mac Lion] media/W3C/video/events/event_canplay.html is flakey, sometimes times out
https://bugs.webkit.org/show_bug.cgi?id=114889
- platform/mac-lion/TestExpectations:
Mark it as such.
- 2:17 PM Changeset in webkit [148772] by
-
- 3 edits in trunk/Source/WebCore
Use Vector instead of StringBuilder for CSSPreloadScanner's buffers
https://bugs.webkit.org/show_bug.cgi?id=114794
Reviewed by Ryosuke Niwa.
Cleanup for other String changes.
CSSPreloadScanner only handles UChar, StringBuilder was a little
overkill.
- html/parser/CSSPreloadScanner.cpp:
(WebCore):
(WebCore::ruleEqualIgnoringCase):
(WebCore::CSSPreloadScanner::emitRule):
- html/parser/CSSPreloadScanner.h:
- 2:13 PM Changeset in webkit [148771] by
-
- 2 edits in trunk/Source/WTF
Remove the declaration of MemoryObjectInfo from StringImpl
https://bugs.webkit.org/show_bug.cgi?id=114788
Reviewed by Andreas Kling.
- wtf/text/StringImpl.h: The declaration is an other left over from chromium.
- 2:10 PM Changeset in webkit [148770] by
-
- 2 edits in trunk/Source/WebCore
StyledMarkupAccumulator::appendText() should not allocate an intermediary StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=114847
Reviewed by Geoffrey Garen.
For some reason StyledMarkupAccumulator::appendText() was allocating a separate buffer
for invoking appendStyleNodeOpenTag. This is a bad idea.
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
(WebCore::StyledMarkupAccumulator::appendText):
- 2:06 PM Changeset in webkit [148769] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Support the SourceMap header, X-SourceMap was deprecated
https://bugs.webkit.org/show_bug.cgi?id=114888
Check first for SourceMap, then fallback to X-SourceMap. Leaving in
support for the deprecated header because most tools and articles
online mention that version and have not yet updated.
Reviewed by Timothy Hatcher.
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::sourceMapURLForResource):
- 2:06 PM Changeset in webkit [148768] by
-
- 9 edits5 adds in trunk
Web Inspector: Backend should detect sourceMappingURLs in CSS Resources
https://bugs.webkit.org/show_bug.cgi?id=114854
Source/WebCore:
Reviewed by Timothy Hatcher.
Test: http/tests/inspector/network/css-source-mapping-url.html
- inspector/Inspector.json:
- Page.getResourceTree - add sourceMapURL to resource payloads
- Network.loadingFinished and Network.requestServedFromMemoryCache, include extra resource info object with possible sourceMapURL.
- inspector/ContentSearchUtils.h:
- inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::scriptCommentPattern):
(WebCore::ContentSearchUtils::stylesheetCommentPattern):
(WebCore::ContentSearchUtils::findMagicComment):
(WebCore::ContentSearchUtils::findScriptSourceURL):
(WebCore::ContentSearchUtils::findScriptSourceMapURL):
(WebCore::ContentSearchUtils::findStylesheetSourceMapURL):
Separate Script and Stylesheet regex pattern creation, but
share the search function using the pattern.
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
(WebCore::InspectorDebuggerAgent::didParseSource):
Update function names. Check for the SourceMap header before
checking for a sourceMappingURL comment.
- inspector/InspectorPageAgent.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::sourceMapURLForResource):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
Provide the sourceMapURL for Page.getResourceTree.
- inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForExtraResourceInfo):
(WebCore::buildObjectForCachedResource):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
Include ExtraResourceInfo objects in finish loading and
request served from cache.
LayoutTests:
Test a different ways we would expect to see a sourceMapURL for
stylesheet resources.
Reviewed by NOBODY (OOPS!).
- http/tests/inspector/network/css-source-mapping-url-expected.txt: Added.
- http/tests/inspector/network/css-source-mapping-url.html: Added.
- http/tests/inspector/network/resources/source-map-test-style.css: Added.
- http/tests/inspector/network/resources/source-map-test-style.css.map: Added.
- http/tests/inspector/network/resources/source-map-test-style.scss: Added.
- 2:02 PM Changeset in webkit [148767] by
-
- 4 edits in trunk/Source/JavaScriptCore
Rename JSStringJoiner::build() to join()
https://bugs.webkit.org/show_bug.cgi?id=114845
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-19
Reviewed by Geoffrey Garen.
The method name build() came from StringBuilder history. It does not make much
sense on the StringJoiner.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
- runtime/JSStringJoiner.cpp:
(JSC::JSStringJoiner::join):
- runtime/JSStringJoiner.h:
(JSStringJoiner):
- 1:56 PM Changeset in webkit [148766] by
-
- 2 edits in trunk/Source/WTF
Make StringImpl::cost const
https://bugs.webkit.org/show_bug.cgi?id=114790
Reviewed by Andreas Kling.
- wtf/text/StringImpl.h:
(WTF::StringImpl::cost):
- 1:41 PM Changeset in webkit [148765] by
-
- 5 edits in trunk/Source/WebCore
Remove non-overlap testing code in RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=85521
Reviewed by Simon Fraser.
m_compositingConsultsOverlap is always true in the current
code. This patch removes this flag, and removes dead code that is
never executed because it was never false.
No new tests, no change in behavior. The cleanup is covered by
existing tests.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
removed if-statement that is always true.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldClipCompositedBounds):
removed if-statement that would never get triggered.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
removed m_compositingConsultsOverlap, and retained the code as if the flag were "true".
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 1:32 PM Changeset in webkit [148764] by
-
- 8 edits in tags/Safari-537.38.1/Source
Merged r148760. <rdar://problem/13696616>
- 1:30 PM Changeset in webkit [148763] by
-
- 4 edits in tags/Safari-537.38.1/Source
Versioning.
- 1:29 PM Changeset in webkit [148762] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Find-on-page should do the scoping again when highlight policy changed
https://bugs.webkit.org/show_bug.cgi?id=114885
Patch by Andy Chen <andchen@blackberry.com> on 2013-04-19
Reviewed by Rob Buis.
PR 195773
Internally reviewed by Mike Fenton.
For find on page, we need to treat it as a new search if highlightAllMatches
changes but the text is not changed.
- WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
- 1:26 PM Changeset in webkit [148761] by
-
- 1 copy in tags/Safari-537.38.1
New Tag.
- 1:14 PM Changeset in webkit [148760] by
-
- 8 edits in trunk/Source
Unreviewed. WebKit_Source is incorrectly set.
- WTF.vcxproj/WTF.make:
- JavaScriptCore.vcxproj/JavaScriptCore.make:
- WebCore.vcxproj/WebCore.make:
- WebKit.vcxproj/WebKit.make:
- 12:58 PM Changeset in webkit [148759] by
-
- 2 edits in trunk/Source/WebCore
Make loops in RenderObject::containingBlock homogeneous in their forms to simplify
https://bugs.webkit.org/show_bug.cgi?id=114853
Reviewed by David Hyatt.
This patch prepares us to avoid computing containing blocks during a depth-first traversal of the render tree.
Extracted inline functions out of RenderBlock::containingBlock to make the code simpler. Also moved the code
to obtain the nearest containing block out of the loop for a relatively positioned inline.
- rendering/RenderObject.cpp:
(WebCore::isNonReplacedInlineInFlowPosition): Extracted.
(WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject): Extracted.
(WebCore::isNonRenderBlockInline): Extracted.
(WebCore::RenderObject::containingBlock): Refactored as stated above.
- 12:45 PM Changeset in webkit [148758] by
-
- 2 edits in trunk/Source/WebCore
WebKit should not decode or support PDF favicons
https://bugs.webkit.org/show_bug.cgi?id=114650
<rdar://problem/10133914>
Reviewed by Dan Bernstein.
Drop the image data on the floor if it begins with the PDF magic number.
No other browser I can find on OS X supports PDF favicons (by experimentation),
and we do not properly display them.
- loader/icon/IconLoader.cpp:
(WebCore::IconLoader::notifyFinished):
- 12:00 PM Changeset in webkit [148757] by
-
- 9 edits18 deletes in trunk/Source/WebCore
Remove the OpenVG backend
https://bugs.webkit.org/show_bug.cgi?id=114881
Reviewed by Tim Horton.
- platform/graphics/FloatRect.h:
(FloatRect): Remove #ifdefs for OpenVG backend.
- platform/graphics/GraphicsContext.cpp:
(WebCore): Ditto.
- platform/graphics/GraphicsContext.h:
- platform/graphics/NativeImagePtr.h:
(WebCore): Ditto.
- platform/graphics/Path.cpp:
(WebCore): Ditto.
- platform/graphics/Path.h:
- platform/graphics/openvg/EGLDisplayOpenVG.cpp: Removed.
- platform/graphics/openvg/EGLDisplayOpenVG.h: Removed.
- platform/graphics/openvg/EGLUtils.h: Removed.
- platform/graphics/openvg/GraphicsContextOpenVG.cpp: Removed.
- platform/graphics/openvg/ImageOpenVG.cpp: Removed.
- platform/graphics/openvg/PainterOpenVG.cpp: Removed.
- platform/graphics/openvg/PainterOpenVG.h: Removed.
- platform/graphics/openvg/PathOpenVG.cpp: Removed.
- platform/graphics/openvg/PlatformPathOpenVG.h: Removed.
- platform/graphics/openvg/SharedResourceOpenVG.cpp: Removed.
- platform/graphics/openvg/SharedResourceOpenVG.h: Removed.
- platform/graphics/openvg/SurfaceOpenVG.cpp: Removed.
- platform/graphics/openvg/SurfaceOpenVG.h: Removed.
- platform/graphics/openvg/TiledImageOpenVG.cpp: Removed.
- platform/graphics/openvg/TiledImageOpenVG.h: Removed.
- platform/graphics/openvg/VGUtils.cpp: Removed.
- platform/graphics/openvg/VGUtils.h: Removed.
- platform/graphics/transforms/AffineTransform.h:
(AffineTransform): Ditto.
- platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix): Ditto.
- platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: Removed.
- 11:12 AM Changeset in webkit [148756] by
-
- 3 edits in trunk/Source/WebKit2
Add JoinExistingSession to the WebContext XPC.
<rdar://problem/13541540> and https://bugs.webkit.org/show_bug.cgi?id=114882
Reviewed by Sam Weinig.
This fixes <keygen> and maybe other things.
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
- 10:55 AM Changeset in webkit [148755] by
-
- 9 edits1 add1 delete in trunk
[GTK] JSCore.gir.in has a few problems
https://bugs.webkit.org/show_bug.cgi?id=114710
Reviewed by Philippe Normand.
.:
- GNUmakefile.am: Move common GIR initialization here from WebKit1.
- configure.ac: Updated to reflect new JSC gir file location.
Source/JavaScriptCore:
- GNUmakefile.am: Add the gobject introspection steps for JavaScriptCore here,
because they are shared between WebKit1 and WebKit2.
- JavaScriptCore.gir.in: Added. Moved from the WebKit1 directory. Now written
as foreign interfaces and referencing the javascriptcoregtk library.
Source/WebKit/gtk:
- GNUmakefile.am: Updated to reflect new name and location of JavaScriptCore-x.0.gir.
- JSCore.gir.in: Removed.
Source/WebKit2:
- GNUmakefile.am: Updated to reflect new location of JavaScriptCore gir file. Share the
same autotools data task as the WebKit1 and JavaScriptCore gir installations.
- 10:25 AM Changeset in webkit [148754] by
-
- 2 edits in trunk/Source/WebCore
ContainerNode::removeChildren should first detach the children then remove them
https://bugs.webkit.org/show_bug.cgi?id=113433
Reviewed by Ryosuke Niwa.
Currently, ContainerNode::removeChildren initially removes the nodes from the DOM tree and then
calls detach() on each of them. This is anti-intuitive and can lead to subtle bugs because the
detached renderers are not backed by a valid DOM tree any more. With the patch, the nodes are first
detached and then removed from the DOM.
The patch also lets the tree in a consistent state after each node removal by clearing the previous
sibling pointer of the node following the one removed.
I haven't found any proof the performance will get worse if the detachment happens when the children
are still in the DOM tree.
Tests: No changed visible functionality.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
- 10:17 AM Changeset in webkit [148753] by
-
- 11 edits2 adds in trunk/Source/WebCore
Refactor transform code in StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=114874
Reviewed by Andreas Kling.
Move transform code frome StyleResolver into own files.
Refactoring, no changes in functionality.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
- css/StyleResolver.h:
- css/TransformFunctions.cpp: Added.
(WebCore):
(WebCore::transformOperationType):
(WebCore::convertToFloatLength):
(WebCore::transformsForValue):
- css/TransformFunctions.h: Added.
(WebCore):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- 10:05 AM May 2013 Meeting edited by
- (diff)
- 10:03 AM Changeset in webkit [148752] by
-
- 7 edits in trunk/Source/WebCore
Rename TextTrackList owner to element for consistency
https://bugs.webkit.org/show_bug.cgi?id=79822
Reviewed by Eric Carlson.
No new tests. Covered by existing tests.
- bindings/js/JSTextTrackListCustom.cpp:
(WebCore::JSTextTrackListOwner::isReachableFromOpaqueRoots):
(WebCore::JSTextTrackList::visitChildren):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
- html/track/TextTrackList.cpp:
(TextTrackList::append):
(TextTrackList::remove):
- html/track/TextTrackList.h:
(WebCore::TextTrackList::create):
- html/track/TrackListBase.cpp:
(TrackListBase::TrackListBase):
(TrackListBase::remove):
- html/track/TrackListBase.h:
(WebCore::TrackListBase::clearElement):
(WebCore::TrackListBase::element):
(TrackListBase):
- 9:40 AM Changeset in webkit [148751] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed Gardening.
- platform/efl/TestExpectations: Adding failure expectations for two tests
which are failing on EFL bots.
- 9:17 AM Changeset in webkit [148750] by
-
- 3 edits in trunk/Source/WebCore
[Mac] ComplexTextController is slow with large numbers of text runs.
<http://webkit.org/b/114875>
<rdar://problem/13337036>
Reviewed by Dan Bernstein.
Instead of iterating over the text runs in indexOfCurrentRun() to figure out the leftmost glyph,
create a lookup table of [run# -> distance in glyphs] at ComplexTextController construction time.
This avoids O(n2) behavior in indexOfCurrentRun().
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::indexOfCurrentRun):
- platform/graphics/mac/ComplexTextController.h:
- 9:03 AM Changeset in webkit [148749] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Minimize calls to GailTextUtil in AtkText implementation
https://bugs.webkit.org/show_bug.cgi?id=114868
Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-04-19
Reviewed by Martin Robinson.
Create a new helper function to concentrate inside of it the calls to
gail_text_util_get_text(), so we can get rid of it later more easily.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetTextForOffset): New helper function.
(webkitAccessibleTextGetTextAfterOffset): Rely on the new function.
(webkitAccessibleTextGetTextAtOffset): Ditto.
(webkitAccessibleTextGetTextBeforeOffset): Ditto.
- 9:01 AM Changeset in webkit [148748] by
-
- 15 edits in trunk/Source
[Texmap] Implementation for pattern compositing
https://bugs.webkit.org/show_bug.cgi?id=109588
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-19
Reviewed by Allan Sandfeld Jensen.
Source/WebCore:
Enable pattern compositing (background images) for CoordinatedGraphics/TextureMapperGL.
Use the existing patternTransform shader uniform, multiplying it by a matrix calculated
using the contentsRect, tileSize and tilePhase.
Covered by existing tests in compositing/patterns.
- platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
Conditionally enable pattern compositing for coordinated graphics.
- platform/graphics/texmap/TextureMapper.cpp:
(WebCore::TextureMapper::TextureMapper):
- platform/graphics/texmap/TextureMapper.h:
(WebCore::TextureMapper::setPatternTransform):
(WebCore::TextureMapper::setWrapMode):
(WebCore::TextureMapper::wrapMode):
(WebCore::TextureMapper::patternTransform):
Add wrapMode and patternTransform properties to the TextureMapper state.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
Paint with GL_REPEAT and a pattern transform when needed.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computePatternTransformIfNeeded):
(WebCore):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::setContentsRect):
(WebCore::TextureMapperLayer::setContentsTileSize):
(WebCore::TextureMapperLayer::setContentsTilePhase):
Apply the patternTransform from the tile size/phase.
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore::TextureMapperLayer::TextureMapperLayer):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::setShouldMapBackingStoreToContentsRect):
(State):
(WebCore::TextureMapperLayer::State::State):
Allow the client to configure whether a layer uses its bounds or its
contents rect to paint the backing store.
This is needed now since layers with background images, unlike layers
with regular images, may have bounds that are greater than the contents
rect.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setContentsTileSize):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::setContentsTilePhase):
(WebCore::CoordinatedGraphicsLayer::setShouldSupportContentsTiling):
(WebCore::GraphicsLayer::supportsContentsTiling):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerState):
(WebCore::CoordinatedGraphicsScene::assignImageBackingToLayer):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(CoordinatedGraphicsLayerState):
Logic to pass the tileSize/tilePhase from CoordinatedGraphicsLayer
to TextureMapperLayer.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
Don't reset the layer's image contents when this is a directly composited image.
Source/WebKit2:
Serialize the two new properties from CoordinatedGraphicsLayer to CoordinatedGraphicsScene.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
Encode/decode the new tiling properties.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
Enable pattern compositing for coordinated graphics.
This is needed since we don't want to enable pattern compositing for
WebKit1 yet.
- 8:34 AM Changeset in webkit [148747] by
-
- 2 edits1 delete in trunk/LayoutTests
[EFL] Unreviewed Gardening.
Marking compositing reftests added in r148172 as ImageOnlyFailure.
Also, skip failing tests on EFL bots.
- platform/efl/TestExpectations:
- platform/efl/compositing/geometry/foreground-layer-expected.txt: Removed.
- 8:21 AM Changeset in webkit [148746] by
-
- 2 edits in trunk/LayoutTests
Fix expectations added in r148720.
- fast/js/stack-trace-expected.txt:
- 7:53 AM Changeset in webkit [148745] by
-
- 3 edits in trunk/Tools
[GTK] Make the 32 bits bot only build and run API tests
https://bugs.webkit.org/show_bug.cgi?id=113532
Reviewed by Martin Robinson.
- BuildSlaveSupport/build.webkit.org-config/config.json: make the 32 bits bot use the new BuildAndAPITest type
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(BuildAndAPITestFactory): new factory that builds and runs API tests, only used by the GTK+ 32 bits bot at the
moment;
(BuildAndAPITestFactory.init): add API tests step for platforms that have it.
- 7:32 AM Changeset in webkit [148744] by
-
- 2 edits in trunk/Tools
[Qt] Only use thin archives on Linux
Rubber-stamped by Jocelyn Turcotte.
Since "thin archive" is a feature of GNU's ar
we limit the usage to Linux to avoid problems
with other configurations (eg. macx-g++).
- qmake/mkspecs/features/default_pre.prf:
- 6:54 AM Changeset in webkit [148743] by
-
- 3 edits in trunk/Source/WebCore
[GTK][AC] Manage actor's children by using clutter's own way.
https://bugs.webkit.org/show_bug.cgi?id=114257
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-19
Reviewed by Gustavo Noronha Silva.
I believe we don't need to maintain a children list of GList. We can do it
by using clutter APIs like clutter_actor_get_children, clutter_actor_get_first_child, etc.
No new tests since no functionality changed.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphics_layer_actor_init):
(graphicsLayerActorAllocate):
(graphicsLayerActorPaint):
(graphicsLayerActorRemoveAll):
(graphicsLayerActorGetnChildren):
(graphicsLayerActorReplaceSublayer):
(graphicsLayerActorInsertSublayer):
- platform/graphics/clutter/GraphicsLayerActor.h:
(_GraphicsLayerActor):
- 6:51 AM Changeset in webkit [148742] by
-
- 5 edits in trunk/Source/WebCore
[GTK][AC] Support masksToBounds for clutter AC backend.
https://bugs.webkit.org/show_bug.cgi?id=114113
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-19
Reviewed by Gustavo Noronha Silva.
We can support the masksToBounds property by using clutter_actor_set_clip simply.
Covered by existing AC tests.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorSetMasksToBounds):
- platform/graphics/clutter/GraphicsLayerActor.h:
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::setMasksToBounds):
(WebCore):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerClutter::setupContentsLayer):
(WebCore::GraphicsLayerClutter::updateMasksToBounds):
- platform/graphics/clutter/GraphicsLayerClutter.h:
(GraphicsLayerClutter):
- 6:32 AM Changeset in webkit [148741] by
-
- 2 edits in trunk/Source/WTF
OSAllocatorPosix: fix build warnings about unused parameters in QNX
https://bugs.webkit.org/show_bug.cgi?id=114859
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-19
Reviewed by Carlos Garcia Campos.
- wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveUncommitted):
- 5:43 AM Changeset in webkit [148740] by
-
- 6 edits1 add in trunk/Source/WebKit
[EFL] Add method in ewk_settings for setting the CSS media type
https://bugs.webkit.org/show_bug.cgi?id=113284
Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-04-19
Reviewed by Gyuyoung Kim.
Source/WebKit:
test_ewk_setting is added.
- PlatformEfl.cmake:
Source/WebKit/efl:
Added APIs to set and get CSS media type.
Added unit tests for these APIs.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::overrideMediaType):
- ewk/ewk_settings.cpp:
(ewk_settings_css_media_type_set):
(ewk_settings_css_media_type_get):
- ewk/ewk_settings.h:
- tests/test_ewk_setting.cpp: Added.
(TEST_F):
- 4:47 AM Changeset in webkit [148739] by
-
- 2 edits in trunk/Source/WebKit/blackberry
fixed debug broken from previous patch
https://bugs.webkit.org/show_bug.cgi?id=114844
Patch by Xuefei Ren <xren@blackberry.com> on 2013-04-19
Reviewed by Rob Buis.
- WebKitSupport/RenderQueue.cpp:
(BlackBerry::WebKit::RenderQueue::scrollZoomJobsCompleted):
Add the parameter outstandingJobs which is used in ASSERT(),it was
removed in the r148677 by misstake.now I need to fix it.
- 4:30 AM Changeset in webkit [148738] by
-
- 3 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Added new baseline.
- platform/qt/editing/selection/select-across-readonly-input-1-expected.txt: Updated after r148594.
- platform/qt/fast/sub-pixel/inline-block-with-padding-expected.txt: Added after r148604.
- platform/qt/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added after r148604.
- platform/qt/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Added after r148604.
- 3:37 AM Changeset in webkit [148737] by
-
- 4 edits in trunk
[GTK][WK2] accessibility/language-attribute.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106342
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-04-19
Reviewed by Gyuyoung Kim.
Tools:
Adds support for getting language information.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::language):
LayoutTests:
Unskipping accessibility/language-attribute.html.
- platform/gtk-wk2/TestExpectations:
- 2:59 AM Changeset in webkit [148736] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] EditorClientBlackBerry: Fix parameter name
https://bugs.webkit.org/show_bug.cgi?id=114856
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-19
Reviewed by Carlos Garcia Campos.
Build fix due to a typo in a parameter name.
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::requestCheckingOfString):
- 1:48 AM FeatureFlags edited by
- (diff)
- 1:47 AM Changeset in webkit [148735] by
-
- 4 edits in trunk/Tools
[Dashboard] Remove the isToTWebKit member variable from the BuilderGroup interface
https://bugs.webkit.org/show_bug.cgi?id=114805
Reviewed by Benjamin Poulain.
Remove the isToTWebKit member variable from the BuilderGroup and all its usages as it now defaults to true for every
builder group. The isTipOfTreeWebKitBuilder method now returns true by default but should be removed in a follow-up patch.
The BuilderGroup constructor does not accept the isToTWebKit parameter anymore so all the callsites are adjusted accordingly.
- TestResultServer/static-dashboards/builders.js:
(BuilderGroup):
(loadBuildersList):
- TestResultServer/static-dashboards/dashboard_base.js:
(isTipOfTreeWebKitBuilder):
(expectationsMap):
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):
- 1:43 AM Changeset in webkit [148734] by
-
- 2 edits in trunk/Tools
[Dashboard] htmlForIndividualTests unit test should include its dummy builder under the webkit.org builder master
https://bugs.webkit.org/show_bug.cgi?id=114804
Reviewed by Benjamin Poulain.
The htmlForIndividualTests unit test should include its dummy builder under the sole supported webkit.org builder master
just so the unit tests properly functions.
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- 1:42 AM Changeset in webkit [148733] by
-
- 3 edits in trunk/Tools
[Dashboard] Remove Chromium-specific helper functions that were used in the builder-loading code
https://bugs.webkit.org/show_bug.cgi?id=114803
Reviewed by Benjamin Poulain.
Remove three Chromium-specific helper functions that were used to determine Chromium DEPS, Content Shell and WebKit ToT
test runners. These are not required anymore and thus removed along with a couple of unit tests that were testing these
methods' correct behavior.
- TestResultServer/static-dashboards/builders.js:
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- 1:41 AM Changeset in webkit [148732] by
-
- 2 edits in trunk/Tools
[Dashboard] Remove the Chromium-specific builder masters
https://bugs.webkit.org/show_bug.cgi?id=114802
Reviewed by Benjamin Poulain.
Remove all the Chromium-specific builder masters, the webkit.org builder master is the only one currently supported.
- TestResultServer/static-dashboards/builders.js:
- 1:40 AM Changeset in webkit [148731] by
-
- 24 edits6 deletes in trunk
Remove unmaintained feature REQUEST_AUTOCOMPLETE
https://bugs.webkit.org/show_bug.cgi?id=114846
Patch by Dan Beam <dbeam@chromium.org> on 2013-04-19
Reviewed by Kent Tamura.
Source/WebCore:
- GNUmakefile.list.am: Remove AutocompleteErrorEvent.h include.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore): Remove requestAutocomplete() runtime feature.
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures): Remove requestAutocomplete() runtime feature.
- dom/AutocompleteErrorEvent.h: Removed.
- dom/AutocompleteErrorEvent.idl: Removed.
- dom/EventNames.h: Remove
autocompleteandautocompleteerrorevent names.
(WebCore):
- dom/EventNames.in: Remove
autocompleteandautocompleteerrorevent names. - html/HTMLAttributeNames.in: Remove
onautocompleteandonautocompleteerrorform attributes. - html/HTMLFormElement.cpp: Remove requestAutocomplete() related code.
(WebCore::HTMLFormElement::HTMLFormElement): Remove timer and event queue for requestAutocomplete() related events.
(WebCore::HTMLFormElement::parseAttribute): Remove parsing ofonautocompleteandonautocompleterror.
- html/HTMLFormElement.h: Remove requestAutocomplete() related members.
(HTMLFormElement):
- html/HTMLFormElement.idl: Remove public requestAutocomplete() API method.
- loader/EmptyClients.cpp: Remove stub implementation.
(WebCore):
- loader/EmptyClients.h: Remove stub interface.
(EmptyFrameLoaderClient):
- loader/FrameLoaderClient.h: Remove didRequestAutocomplete() from interface.
(FrameLoaderClient):
- page/DOMWindow.idl: Remove
AutocompleteErrorEventfrom window DOM interface.
Source/WTF:
- wtf/FeatureDefines.h: Remove REQUEST_AUTOCOMPLETE as a feature definition.
LayoutTests:
- fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Removed.
- fast/events/constructors/autocomplete-error-event-constructor.html: Removed.
- fast/events/event-creation.html: Remove AutocompleteErrorEvent test code.
- fast/forms/form-request-autocomplete-expected.txt: Removed.
- fast/forms/form-request-autocomplete.html: Removed.
- fast/js/constructor-length.html: Remove AutocompleteErrorEvent test code.
- fast/js/script-tests/global-constructors.js: Remove AutocompleteErrorEvent constructor.
- platform/blackberry/fast/js/constructor-length-expected.txt: Remove test expectations.
- platform/gtk/fast/js/constructor-length-expected.txt: Remove test expectations.
- platform/mac/fast/js/constructor-length-expected.txt: Remove test expectations.
- platform/qt/fast/js/constructor-length-expected.txt: Remove test expectations.
- 1:40 AM Changeset in webkit [148730] by
-
- 2 edits in trunk/Tools
[Dashboard] Remove all the Chromium-specific builder groups
https://bugs.webkit.org/show_bug.cgi?id=114801
Reviewed by Benjamin Poulain.
Remove all the Chromium-specific builder groups, all of these are not supported anymore.
- TestResultServer/static-dashboards/builders.js:
- 1:39 AM Changeset in webkit [148729] by
-
- 2 edits in trunk/Tools
[Dashboard] Only accept the 'group' parameter if present in the layout tests builders group
https://bugs.webkit.org/show_bug.cgi?id=114799
Reviewed by Benjamin Poulain.
The layout tests builder group is the only one supported, all the other Chromium-specific builder groups are
bound to be removed.
- TestResultServer/static-dashboards/history.js:
(.):
- 1:37 AM Changeset in webkit [148728] by
-
- 2 edits in trunk/Tools
[Dashboard] Remove Chromium-specific builder loading code from loadBuildersList
https://bugs.webkit.org/show_bug.cgi?id=114797
Reviewed by Benjamin Poulain.
Remove anything Chromium-specific from the builder-loading code, specifically removing support for loading builder data
for anything other that the layout-tests type and removing support for loading builder data from builders connected
to the Chromium-specific builder groups which are no longer supported.
- TestResultServer/static-dashboards/builders.js:
- 1:36 AM Changeset in webkit [148727] by
-
- 2 edits in trunk/Tools
[Dashboard] The currentBuilderGroupCategory method should return the layout tests builder groups by default
https://bugs.webkit.org/show_bug.cgi?id=114796
Reviewed by Benjamin Poulain.
With the Chromium builders no longer uploading results and the layout-tests test type the only one supported by the
WebKit's dashboard, the currentBuilderGroupCategory can now return LAYOUT_TESTS_BUILDER_GROUPS as the default builder
group category.
- TestResultServer/static-dashboards/dashboard_base.js:
(currentBuilderGroupCategory):
- 1:33 AM Changeset in webkit [148726] by
-
- 2 edits in trunk/Tools
[Dashboard] Narrow down the test types list to only layout-tests
https://bugs.webkit.org/show_bug.cgi?id=114795
Reviewed by Ryosuke Niwa.
Remove all the redundant test types that the webkit.org builders do not upload results for. All of the removed
test types were specific to the Chromium builders.
- TestResultServer/static-dashboards/dashboard_base.js:
- 1:28 AM Changeset in webkit [148725] by
-
- 2 edits in trunk/Tools
[Dashboard] The revision rows for aggregate results should no longer include Chromium revisions
https://bugs.webkit.org/show_bug.cgi?id=114760
Reviewed by Benjamin Poulain.
With the Chromium builders no longer present there's no need to display the Chromium revision range under the
aggregate results. Only the first half of the htmlForRevisionRows method (the one returning the table row listing the
WebKit revisions) is now relevant - the method is therefor removed and its callsites updated to directly call the
htmlForTableRow method that returns the table row containing all the relevant WebKit revisions.
- TestResultServer/static-dashboards/aggregate_results.js:
(htmlForSummaryTable):
(htmlForTestType):
- 1:25 AM Changeset in webkit [148724] by
-
- 2 edits in trunk/Tools
[Dashboard] Remove Chromium-specific cases from the construction of the chart HTML for aggregate results
https://bugs.webkit.org/show_bug.cgi?id=114759
Reviewed by Benjamin Poulain.
Aggregate results are not viewable for Chromium builders anymore, meaning the WebKit revisions are shown by default.
This means the code in the chartHTML method can be simplified, defaulting the revision key to WEBKIT_REVISIONS_KEY
and the revision label to 'WebKit Revision'.
- TestResultServer/static-dashboards/aggregate_results.js:
(chartHTML):
- 12:14 AM EFLWebKitBuildBots edited by
- (diff)
Apr 18, 2013:
- 10:59 PM Changeset in webkit [148723] by
-
- 9 edits in trunk
Add CSS.setStyleText to the Web Inspector protocol.
This provides a direct path for the Safari Web Inspector to live edit whole style rules.
https://webkit.org/b/109340
rdar://problem/13337211
Reviewed by Joseph Pecoraro.
Source/WebCore:
- inspector/Inspector.json:
(CSS.setStyleText): Added.
- inspector/InspectorCSSAgent.cpp:
(InspectorCSSAgent::SetStyleTextAction):
(WebCore::InspectorCSSAgent::SetStyleTextAction::SetStyleTextAction): Added.
(WebCore::InspectorCSSAgent::SetStyleTextAction::perform): Added.
(WebCore::InspectorCSSAgent::SetStyleTextAction::undo): Added.
(WebCore::InspectorCSSAgent::SetStyleTextAction::redo): Added.
(WebCore::InspectorCSSAgent::SetStyleTextAction::mergeId): Added.
(WebCore::InspectorCSSAgent::SetStyleTextAction::merge): Added.
(WebCore::InspectorCSSAgent::SetPropertyTextAction::redo):
(WebCore::InspectorCSSAgent::setStyleText): Added.
- inspector/InspectorCSSAgent.h:
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::getText): Added.
(WebCore::InspectorStyle::setText): Added.
(WebCore::InspectorStyleSheet::setStyleText):
(WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
- inspector/InspectorStyleSheet.h:
(WebCore::InspectorStyle::styleText): Added as an alias to getText.
(WebCore::InspectorStyle::applyStyleText): Added as an alias to setText.
LayoutTests:
- inspector/styles/styles-new-API-expected.txt: Updated.
- inspector/styles/styles-new-API.html: Test CSSAgent.setStyleText.
- 8:04 PM May 2013 Meeting edited by
- (diff)
- 7:33 PM EFLWebKitBuildBots edited by
- Add Samsung gardners (diff)
- 7:31 PM Changeset in webkit [148722] by
-
- 3 edits in trunk/LayoutTests
More cleaning up of skipped tests.
- platform/mac-wk2/TestExpectations:
Remove tests that now pass.
- platform/mac/TestExpectations:
Remove an entry for a bug that has been closed and whose test works just fine on both WK1
and WK2.
- 6:52 PM Changeset in webkit [148721] by
-
- 2 edits in trunk/Source/JavaScriptCore
Use StringJoiner to create the JSString of arrayProtoFuncToString
https://bugs.webkit.org/show_bug.cgi?id=114779
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-18
Reviewed by Geoffrey Garen.
The function arrayProtoFuncToString was just a glorified JSStringJoiner.
This patch replaces it by JSStringJoiner to simplify the code and enjoy any optimization
made on JSStringJoiner.
For some reason, this makes the execution 3.4% faster, despite having almost identical code.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
- 6:34 PM Changeset in webkit [148720] by
-
- 4 edits in trunk
StackFrame::column() returning bogus value
https://bugs.webkit.org/show_bug.cgi?id=114840
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Don't add one part of the expression offset to the other part of the expression.
Make StackFrame::toString() include the column info.
- interpreter/Interpreter.cpp:
(JSC::StackFrame::expressionInfo):
(JSC::StackFrame::toString):
LayoutTests:
Update test result
- fast/js/stack-trace-expected.txt:
- 6:23 PM Changeset in webkit [148719] by
-
- 2 edits in trunk/Source/WebKit2
PDFPlugin: Update PDFLayerController's scale factors earlier
https://bugs.webkit.org/show_bug.cgi?id=114843
Reviewed by Simon Fraser.
Inform PDFLayerController of the initial page/device scale factors so that
it renders at the correct scale the first time, instead of first rendering
at 1x and then flashing to 2x (on 2x devices).
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::pdfDocumentDidLoad):
- 5:38 PM Changeset in webkit [148718] by
-
- 2 edits in trunk
[EFL] Build break when using cmake without CMAKE_BUILD_TYPE
https://bugs.webkit.org/show_bug.cgi?id=114835
Unreviewed build fix.
Patch by Ryuan Choi <ryuan.choi@gmail.com> on 2013-04-18
- Source/cmake/OptionsEfl.cmake:
- 5:25 PM Changeset in webkit [148717] by
-
- 4 edits in trunk/Source/WebKit2
PDFPlugin: Hook up the search-in-Spotlight menu item
https://bugs.webkit.org/show_bug.cgi?id=114837
<rdar://problem/13583591>
Reviewed by Mark Rowe.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h:
Add performSpotlightSearch: delegate callback.
- WebProcess/Plugins/PDF/PDFPlugin.h:
(WebKit::PDFPlugin::performSpotlightSearch):
Add performSpotlightSearch() PDFPlugin method.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate performSpotlightSearch:]): Hand the search string to PDFPlugin.
(WebKit::PDFPlugin::performSpotlightSearch): Hand the search string to WebPageProxy.
- 5:23 PM Changeset in webkit [148716] by
-
- 3 edits in trunk/Source/WebKit2
Dispatch local storage events
https://bugs.webkit.org/show_bug.cgi?id=114838
Reviewed by Beth Dakin.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::dispatchEvents):
Pass 0 as the storage area ID if the event originally comes from another process.
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::dispatchLocalStorageEvent):
Gather all the frames for which we want to dispatch events.
- 5:13 PM Changeset in webkit [148715] by
-
- 5 edits in trunk/Source/WebKit2
Use the page group id from the UI process as the local storage namespace ID
https://bugs.webkit.org/show_bug.cgi?id=114836
Reviewed by Beth Dakin.
The WebCore PageGroup identifier is different across processes, so use the one given to us by the UI process.
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::createLocalStorageNamespace):
- WebProcess/WebPage/WebPageGroupProxy.h:
(WebKit::WebPageGroupProxy::corePageGroup):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::webPageGroup):
- WebProcess/WebProcess.h:
- 4:57 PM Changeset in webkit [148714] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed gardening; fix bindings tests after r148700.
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetOwner::isReachableFromOpaqueRoots):
- 4:40 PM Changeset in webkit [148713] by
-
- 8 edits in trunk/Source/WebKit2
Add a synchronous version of WKView endDeferringViewInWindowChanges
https://bugs.webkit.org/show_bug.cgi?id=114780
<rdar://problem/12821901>
Reviewed by Simon Fraser.
Add new WKView SPI, endDeferringViewInWindowChangesSync, which synchronously
(though with a 250 ms timeout) does the work required to reparent a WKView
without flashing white.
- UIProcess/API/mac/WKView.mm:
(-[WKView beginDeferringViewInWindowChanges]):
(-[WKView endDeferringViewInWindowChanges]):
Make begin/endDeferringViewInWindowChanges not allow nested deferrals,
as we don't need them, and they complicate synchronous-end a lot.
(-[WKView endDeferringViewInWindowChangesSync]):
Add a sync version of endDeferringViewInWindowChanges which waits
for DidUpdateInWindowState.
(-[WKView isDeferringViewInWindowChanges]):
- UIProcess/API/mac/WKViewPrivate.h: Add endDeferringViewInWindowChangesSync.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::waitForDidUpdateInWindowState):
Add waitForDidUpdateInWindowState(), which blocks for
250ms or until the WebProcess reparents all of its layers and spins
the runloop once, to prevent flashing when parenting a WKView.
If we've already timed out waiting for the WebProcess, don't block, as
it's probably quite busy and is likely to time out again.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::isInWindow): Added.
(WebKit::WebPageProxy::waitForDidUpdateInWindowState): Added.
(WebKit::WebPageProxy::didUpdateInWindowState): Added.
- UIProcess/WebPageProxy.messages.in: Add DidUpdateInWindowState()
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didUpdateInWindowStateTimerFired): Send DidUpdateInWindowState to WebPageProxy.
(WebKit::WebPage::setIsInWindow): When setIsInWindow completes, TileController
tiles have been reparented, and the TiledCoreAnimationDrawingArea has
reconnected the layer tree to the context, start a 0-delay runloop timer
to allow painting and layer flushing to finish; when the timer fires,
we'll send the UIProcess a DidUpdateInWindowState so it can stop blocking.
- WebProcess/WebPage/WebPage.h:
(WebPage): Add didUpdateInWindowStateTimerFired and m_sendDidUpdateInWindowStateTimer.
- 4:33 PM May 2013 Meeting edited by
- (diff)
- 4:32 PM Changeset in webkit [148712] by
-
- 7 edits in trunk/Source
REGRESSION (r116645): Versions app's UI is munged in HiDPI due to background-size being reset to 'auto' when background short-hand is also specified
https://bugs.webkit.org/show_bug.cgi?id=114833
Reviewed by David Kilzer.
Source/WebCore:
Added applicationIsVersions() to RuntimeApplicationChecks.
- WebCore.exp.in:
- platform/RuntimeApplicationChecks.cpp:
(WebCore::applicationIsVersions):
(WebCore):
- platform/RuntimeApplicationChecks.h:
(WebCore):
Source/WebKit/mac:
The Versions app specifies both a background-size and a background
shorthand CSS property, and its UI is broken after r116645 which resets
background-size to 'auto' if the background shorthand property is
specified.
This patch enables the useLegacyBackgroundSizeShorthandBehavior setting
added in r147034 to restore the expected behavior if the embedder is
Versions.app and it was linked against a version of WebKit that had the
legacy behavior.
- Misc/WebKitVersionChecks.h:
- WebView/WebView.mm:
(shouldUseLegacyBackgroundSizeShorthandBehavior):
(-[WebView _commonInitializationWithFrameName:groupName:]):
- 3:52 PM Changeset in webkit [148711] by
-
- 3 edits3 adds in trunk
Crash beneath JSC::JIT::privateCompileSlowCases @ stephenrdonaldson.com
https://bugs.webkit.org/show_bug.cgi?id=114774
Reviewed by Geoffrey Garen.
We're not linking up all of the slow cases in the baseline JIT when compiling put_to_base.
Source/JavaScriptCore:
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_put_to_base):
LayoutTests:
- fast/js/put-to-base-global-checked-expected.txt: Added.
- fast/js/put-to-base-global-checked.html: Added.
- fast/js/script-tests/put-to-base-global-checked.js: Added.
(globalF):
(warmup):
(foo):
- 3:45 PM Changeset in webkit [148710] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Invalidate spell checking requests in platform code
https://bugs.webkit.org/show_bug.cgi?id=114830
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-04-18
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
Cache the value of the last requested sequence id at focus change.
All requests prior to this point will be rejected upon processing.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::stopPendingSpellCheckRequests):
- WebKitSupport/InputHandler.h:
(InputHandler):
- 3:45 PM Changeset in webkit [148709] by
-
- 2 edits in trunk/Source/JavaScriptCore
Interpreter entry points should throw the TerminatedExecutionException from the caller frame.
https://bugs.webkit.org/show_bug.cgi?id=114816.
Reviewed by Oliver Hunt.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
- 3:34 PM Changeset in webkit [148708] by
-
- 6 edits1 move in trunk/Source
Network Process crashing trying to read in IDNScriptWhiteList.txt
https://bugs.webkit.org/show_bug.cgi?id=114827
Reviewed by Anders Carlsson.
Move IDNScriptWhiteList.txt from WebKit to WebCore, so that the NetworkProcess does not have to link against
WebKit. It was a layering violation for WebCore to be trying to access WebKit resources anyway.
Source/WebCore:
- Resources/IDNScriptWhiteList.txt: Copied from Source/WebKit/mac/Resources/IDNScriptWhiteList.txt.
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/WebCoreNSURLExtras.mm:
(WebCore::readIDNScriptWhiteList):
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Resources/IDNScriptWhiteList.txt: Removed.
- 3:29 PM Changeset in webkit [148707] by
-
- 3 edits in trunk/Source/WebCore
Remove GraphicsLayerCA::constrainedSize() now that we can manage large layer memory use ourselves in TileController
https://bugs.webkit.org/show_bug.cgi?id=114834
Reviewed by Tim Horton.
GraphicsLayerCA::constrainedSize() was added to handle poor CATiledLayer behavior when layer sizes
got extremely large. Now that we no longer use CATiledLayer, remove this code. We can later add
tile memory bounding to TileController if that becomes necessary.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateGeometry):
- platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
- 3:13 PM Changeset in webkit [148706] by
-
- 3 edits in trunk/Source/WebKit2
StorageManager should keep track of local storage namespaces
https://bugs.webkit.org/show_bug.cgi?id=114831
Reviewed by Beth Dakin.
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
Add the local storage namespace, and security origin as member variables.
(StorageManager::LocalStorageNamespace):
New class that represents a local storage namespace.
(WebKit::StorageManager::StorageArea::~StorageArea):
If this storage area belongs to a local storage namespace, notify it that we've been destroyed.
(WebKit::StorageManager::StorageArea::clone):
Assert that we don't have a local storage namespace.
(WebKit::StorageManager::LocalStorageNamespace::getOrCreateStorageArea):
If we already have a storage area for the given security origin, return it. Otherwise, create a new storage area.
Note that LocalStorageNamespace does not hold strong references to its StorageArea objects; they are being kept alive
by a mapping inside the StorageManager.
(WebKit::StorageManager::LocalStorageNamespace::didDestroyStorageArea):
Remove the storage area from the map. If there are no more areas, remove the namespace from the manager.
(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
StorageArea::create now takes the security origin.
(WebKit::StorageManager::createLocalStorageMap):
Get (or create) the right local storage namespace and then create a storage area.
- 2:56 PM Changeset in webkit [148705] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLInt ARM backend should not use the d8 register as scratch register
https://bugs.webkit.org/show_bug.cgi?id=114811
Reviewed by Filip Pizlo.
The d8 register must preserved across function calls and should
not used as scratch register. Changing it to d6.
- offlineasm/arm.rb:
- 2:55 PM Changeset in webkit [148704] by
-
- 4 edits in trunk/Source/JavaScriptCore
Removed HeapTimer::synchronize
https://bugs.webkit.org/show_bug.cgi?id=114832
Reviewed by Mark Hahnenberg.
HeapTimer::synchronize was a flawed attempt to make HeapTimer thread-safe.
Instead, we use proper locking now.
This is a slight API change, since the GC timer will now only fire in the
run loop that created the JS VM, even if another run loop later executes
some JS.
- API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
- heap/HeapTimer.cpp:
(JSC):
- heap/HeapTimer.h:
(HeapTimer):
- 2:48 PM Changeset in webkit [148703] by
-
- 15 edits1 add in branches/dfgFourthTier/Source
fourthTier: all inline caches should thread-safe enough to allow a concurrent compilation thread to read them safely
https://bugs.webkit.org/show_bug.cgi?id=114762
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
For most inline caches this is easy: the inline cache has a clean temporal
separation between doing the requested action (which may take an unbounded
amount of time, may recurse, and may do arbitrary things) and recording the
relevant information in the cache. So, we just put locks around the
recording bit. That part is always O(1) and does not recurse. The lock we
use is per-CodeBlock to achieve a good balance between locking granularity
and low space overhead. So a concurrent compilation thread will only block
if an inline cache ping-pongs in the code block being compiled (or inlined)
and never when other inline caches do things.
For resolve operations, it's a bit tricky. The global resolve bit works
like any other IC in that it has the clean temporal separation. But the
operations vector itself doesn't have this separation, since we will be
filling it in tandem with actions that may take a long time. This patch
gets around this by having a m_ready bit in the ResolveOperations and
PutToBaseOperation. This is set while holding the CodeBlock's lock. If the
DFG observes the m_ready bit not set (while holding the lock) then it
conservatively assumes that the resolve hasn't happened yet and just
plants a ForceOSRExit.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/CodeBlock.h:
(CodeBlock):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- bytecode/ResolveGlobalStatus.cpp:
(JSC::ResolveGlobalStatus::computeFor):
- bytecode/ResolveOperation.h:
(JSC::ResolveOperations::ResolveOperations):
(ResolveOperations):
(JSC::PutToBaseOperation::PutToBaseOperation):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
- jit/JITStubs.cpp:
(JSC::tryCachePutByID):
(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::lazyLinkFor):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::setUpCall):
- runtime/JSScope.cpp:
(JSC::JSScope::resolveContainingScopeInternal):
(JSC::JSScope::resolveContainingScope):
(JSC::JSScope::resolvePut):
Source/WTF:
Reviewed by Mark Hahnenberg.
Implemented a new spinlock that is optimized for compactness, by using just a byte.
This will be useful as we start using fine-grained locking on a bunch of places.
At some point I'll make these byte-sized spinlocks into adaptive mutexes, but for
now I think it's fine to do the evil thing and use spinning particularly since we
only use them for short critical sections.
- WTF.xcodeproj/project.pbxproj:
- wtf/Atomics.h:
(WTF):
(WTF::weakCompareAndSwap):
- wtf/ByteSpinLock.h: Added.
(WTF):
(ByteSpinLock):
(WTF::ByteSpinLock::ByteSpinLock):
(WTF::ByteSpinLock::lock):
(WTF::ByteSpinLock::unlock):
(WTF::ByteSpinLock::isHeld):
- wtf/ThreadingPrimitives.h:
(WTF::pauseBriefly):
(WTF):
- 2:48 PM Changeset in webkit [148702] by
-
- 3 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r148545.
- WebCoreSupport/EditorClientWinCE.cpp:
- WebView.cpp:
- 2:20 PM May 2013 Meeting edited by
- (diff)
- 2:19 PM May 2013 Meeting edited by
- (diff)
- 2:12 PM May 2013 Meeting edited by
- (diff)
- 2:01 PM Changeset in webkit [148701] by
-
- 2 edits in trunk/Source/WebCore
Remove obsolete macros from libpng
https://bugs.webkit.org/show_bug.cgi?id=114817
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-18
Reviewed by Benjamin Poulain.
libpng 1.4 removes the png_voidp_NULL and png_error_ptr_NULL
macros. Null pointers must be used directly instead.
- platform/image-encoders/PNGImageEncoder.cpp:
(WebCore::compressRGBABigEndianToPNG):
- 1:39 PM Changeset in webkit [148700] by
-
- 2 edits in trunk/Source/WebCore
CodeGeneratorJS.pm should generate "isFiringEventListeners()" check in isReachableFromOpaqueRoots()
https://bugs.webkit.org/show_bug.cgi?id=114784
Reviewed by Geoffrey Garen.
EventTarget subclasses shouldn't have to use CustomIsReachable directives
in order to keep their wrappers alive while firing event listeners.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- 1:31 PM Changeset in webkit [148699] by
-
- 4 edits in branches/safari-536.30-branch/Source
Versioning.
- 1:30 PM Changeset in webkit [148698] by
-
- 1 copy in tags/Safari-536.30.1
New Tag.
- 1:13 PM Changeset in webkit [148697] by
-
- 555 edits3 moves in branches/dfgFourthTier/Source
Cherry-pick merged <http://trac.webkit.org/changeset/148696> to the FTL
branch, to ease merging back later.
NOTE: Please skip this patch when merging from the FTL branch back to
trunk.
Reviewed by Phil Pizlo.
WebCore:
Reviewed by Phil Pizlo.
WebKit/blackberry:
Reviewed by Phil Pizlo.
WebKit/efl:
Reviewed by Phil Pizlo.
WebKit/gtk:
Reviewed by Phil Pizlo.
WebKit/mac:
Reviewed by Phil Pizlo.
WebKit/qt:
Reviewed by Phil Pizlo.
WebKit/win:
Reviewed by Phil Pizlo.
WebKit2:
Reviewed by Phil Pizlo.
- 12:32 PM Changeset in webkit [148696] by
-
- 550 edits3 moves in trunk/Source
Renamed JSGlobalData to VM
https://bugs.webkit.org/show_bug.cgi?id=114777
Reviewed by Phil Pizlo.
- API/APICast.h:
(JSC):
(toJS):
(toRef):
- API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(APIEntryShimWithoutLock):
(JSC::APIEntryShim::APIEntryShim):
(APIEntryShim):
(JSC::APIEntryShim::~APIEntryShim):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
(APICallbackShim):
- API/JSAPIWrapperObject.h:
(JSAPIWrapperObject):
- API/JSAPIWrapperObject.mm:
(JSC::::createStructure):
(JSC::JSAPIWrapperObject::JSAPIWrapperObject):
(JSC::JSAPIWrapperObject::finishCreation):
(JSC::JSAPIWrapperObject::visitChildren):
- API/JSBase.cpp:
(JSGarbageCollect):
(JSReportExtraMemoryCost):
(JSSynchronousGarbageCollectForDebugging):
- API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
(JSC::JSCallbackConstructor::finishCreation):
- API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::createStructure):
- API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::finishCreation):
(JSC::JSCallbackFunction::create):
- API/JSCallbackFunction.h:
(JSCallbackFunction):
(JSC::JSCallbackFunction::createStructure):
- API/JSCallbackObject.cpp:
(JSC::::create):
(JSC::::createStructure):
- API/JSCallbackObject.h:
(JSC::JSCallbackObjectData::setPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
(JSCallbackObject):
(JSC::JSCallbackObject::setPrivateProperty):
- API/JSCallbackObjectFunctions.h:
(JSC::::JSCallbackObject):
(JSC::::finishCreation):
(JSC::::put):
(JSC::::staticFunctionGetter):
- API/JSClassRef.cpp:
(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::contextData):
(OpaqueJSClass::prototype):
- API/JSClassRef.h:
(OpaqueJSClassContextData):
- API/JSContext.mm:
(-[JSContext setException:]):
(-[JSContext initWithGlobalContextRef:]):
(+[JSContext contextWithGlobalContextRef:]):
- API/JSContextRef.cpp:
(JSContextGroupCreate):
(JSContextGroupRelease):
(JSGlobalContextCreate):
(JSGlobalContextCreateInGroup):
(JSGlobalContextRetain):
(JSGlobalContextRelease):
(JSContextGetGroup):
(JSContextCreateBacktrace):
- API/JSObjectRef.cpp:
(JSObjectMake):
(JSObjectMakeConstructor):
(JSObjectMakeFunction):
(JSObjectSetPrototype):
(JSObjectHasProperty):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectDeleteProperty):
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):
(OpaqueJSPropertyNameArray::OpaqueJSPropertyNameArray):
(OpaqueJSPropertyNameArray):
(JSObjectCopyPropertyNames):
(JSPropertyNameArrayRelease):
(JSPropertyNameAccumulatorAddName):
- API/JSScriptRef.cpp:
(OpaqueJSScript::create):
(OpaqueJSScript::vm):
(OpaqueJSScript::OpaqueJSScript):
(OpaqueJSScript):
(parseScript):
- API/JSVirtualMachine.mm:
(scanExternalObjectGraph):
- API/JSVirtualMachineInternal.h:
(JSC):
- API/JSWrapperMap.mm:
(makeWrapper):
- API/ObjCCallbackFunction.h:
(JSC::ObjCCallbackFunction::createStructure):
- API/ObjCCallbackFunction.mm:
(JSC::ObjCCallbackFunction::create):
- API/OpaqueJSString.cpp:
(OpaqueJSString::identifier):
- API/OpaqueJSString.h:
(JSC):
(OpaqueJSString):
- GNUmakefile.list.am:
- JSCTypedArrayStubs.h:
(JSC):
- JavaScriptCore.order:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- JavaScriptCore.xcodeproj/project.pbxproj:
- KeywordLookupGenerator.py:
(Trie.printSubTreeAsC):
- Target.pri:
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
- assembler/ARMAssembler.h:
(ARMAssembler):
- assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::executableCopy):
- assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::executableCopy):
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::linkCode):
- assembler/LinkBuffer.h:
(JSC):
(JSC::LinkBuffer::LinkBuffer):
(LinkBuffer):
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::executableCopy):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::executableCopy):
- assembler/X86Assembler.h:
(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):
- bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::unlink):
- bytecode/CallLinkInfo.h:
(CallLinkInfo):
- bytecode/CodeBlock.cpp:
(JSC::dumpStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::visitStructures):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::createActivation):
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::findClosureCallForReturnPC):
(JSC::ProgramCodeBlock::jettisonImpl):
(JSC::EvalCodeBlock::jettisonImpl):
(JSC::FunctionCodeBlock::jettisonImpl):
(JSC::CodeBlock::predictedMachineCodeSize):
(JSC::CodeBlock::usesOpcode):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::appendWeakReference):
(JSC::CodeBlock::appendWeakReferenceTransition):
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::setGlobalData):
(JSC::CodeBlock::vm):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC::CodeBlock::addConstant):
(JSC::CodeBlock::setConstantRegisters):
(CodeBlock):
(JSC::CodeBlock::WeakReferenceTransition::WeakReferenceTransition):
- bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::getSlow):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):
- bytecode/GetByIdStatus.h:
(GetByIdStatus):
- bytecode/Instruction.h:
(JSC::Instruction::Instruction):
- bytecode/ObjectAllocationProfile.h:
(JSC::ObjectAllocationProfile::initialize):
(JSC::ObjectAllocationProfile::possibleDefaultPropertyCount):
- bytecode/PolymorphicAccessStructureList.h:
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
- bytecode/PolymorphicPutByIdList.h:
(JSC::PutByIdAccess::transition):
(JSC::PutByIdAccess::replace):
- bytecode/PreciseJumpTargets.cpp:
(JSC::computePreciseJumpTargets):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
- bytecode/PutByIdStatus.h:
(JSC):
(PutByIdStatus):
- bytecode/ResolveGlobalStatus.cpp:
(JSC::computeForStructure):
- bytecode/SamplingTool.cpp:
(JSC::SamplingTool::notifyOfScope):
- bytecode/SamplingTool.h:
(JSC::ScriptSampleRecord::ScriptSampleRecord):
(SamplingTool):
- bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initPutByIdTransition):
(JSC::StructureStubInfo::initPutByIdReplace):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
(JSC::UnlinkedFunctionExecutable::link):
(JSC::UnlinkedFunctionExecutable::fromGlobalCode):
(JSC::UnlinkedFunctionExecutable::codeBlockFor):
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedFunctionExecutable::create):
(UnlinkedFunctionExecutable):
(JSC::UnlinkedFunctionExecutable::finishCreation):
(JSC::UnlinkedFunctionExecutable::createStructure):
(JSC::UnlinkedCodeBlock::addRegExp):
(JSC::UnlinkedCodeBlock::addConstant):
(JSC::UnlinkedCodeBlock::addFunctionDecl):
(JSC::UnlinkedCodeBlock::addFunctionExpr):
(JSC::UnlinkedCodeBlock::vm):
(UnlinkedCodeBlock):
(JSC::UnlinkedCodeBlock::finishCreation):
(JSC::UnlinkedGlobalCodeBlock::UnlinkedGlobalCodeBlock):
(JSC::UnlinkedProgramCodeBlock::create):
(JSC::UnlinkedProgramCodeBlock::addFunctionDeclaration):
(JSC::UnlinkedProgramCodeBlock::UnlinkedProgramCodeBlock):
(JSC::UnlinkedProgramCodeBlock::createStructure):
(JSC::UnlinkedEvalCodeBlock::create):
(JSC::UnlinkedEvalCodeBlock::UnlinkedEvalCodeBlock):
(JSC::UnlinkedEvalCodeBlock::createStructure):
(JSC::UnlinkedFunctionCodeBlock::create):
(JSC::UnlinkedFunctionCodeBlock::UnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionCodeBlock::createStructure):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::addStringConstant):
(JSC::BytecodeGenerator::expectedFunctionForIdentifier):
(JSC::BytecodeGenerator::emitThrowReferenceError):
(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded):
- bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
(JSC::BytecodeGenerator::vm):
(JSC::BytecodeGenerator::propertyNames):
(JSC::BytecodeGenerator::makeFunction):
- bytecompiler/NodesCodegen.cpp:
(JSC::RegExpNode::emitBytecode):
(JSC::ArrayNode::toArgumentList):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::InstanceOfNode::emitBytecode):
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
(JSC::evaluateInGlobalCallFrame):
- debugger/Debugger.h:
(JSC):
- debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::DebuggerActivation):
(JSC::DebuggerActivation::finishCreation):
- debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::create):
(JSC::DebuggerActivation::createStructure):
(DebuggerActivation):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::vm):
(JSC::DFG::AssemblyHelpers::debugCall):
(JSC::DFG::AssemblyHelpers::emitExceptionCheck):
(AssemblyHelpers):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
- dfg/DFGByteCodeParser.h:
(JSC):
- dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::CCallHelpers):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::canHandleOpcodes):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::reportToProfiler):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGDriver.h:
(JSC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
- dfg/DFGGraph.h:
(Graph):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(JSC):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOperations.cpp:
(JSC::DFG::putByVal):
(JSC::DFG::operationPutByValInternal):
(JSC::getHostCallReturnValueWithExecState):
- dfg/DFGPhase.h:
(JSC::DFG::Phase::vm):
- dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):
(JSC::DFG::linkSlowFor):
(JSC::DFG::dfgLinkFor):
(JSC::DFG::dfgLinkSlowFor):
(JSC::DFG::dfgLinkClosureCall):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::typedArrayDescriptor):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileFromCharCode):
(JSC::DFG::SpeculativeJIT::compileMakeRope):
(JSC::DFG::SpeculativeJIT::compileStringEquality):
(JSC::DFG::SpeculativeJIT::compileToStringOnCell):
(JSC::DFG::SpeculativeJIT::speculateObject):
(JSC::DFG::SpeculativeJIT::speculateObjectOrOther):
(JSC::DFG::SpeculativeJIT::speculateString):
(JSC::DFG::SpeculativeJIT::speculateStringOrStringObject):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::prepareForExternalCall):
(JSC::DFG::SpeculativeJIT::emitAllocateBasicStorage):
(JSC::DFG::SpeculativeJIT::emitAllocateJSObject):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator):
(JSC::DFG::throwExceptionFromCallSlowPathGenerator):
(JSC::DFG::slowPathFor):
(JSC::DFG::linkForThunkGenerator):
(JSC::DFG::linkCallThunkGenerator):
(JSC::DFG::linkConstructThunkGenerator):
(JSC::DFG::linkClosureCallThunkGenerator):
(JSC::DFG::virtualForThunkGenerator):
(JSC::DFG::virtualCallThunkGenerator):
(JSC::DFG::virtualConstructThunkGenerator):
- dfg/DFGThunks.h:
(JSC):
(DFG):
- heap/BlockAllocator.h:
(JSC):
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::tryAllocateSlowCase):
(JSC::CopiedSpace::tryReallocate):
- heap/CopiedSpaceInlines.h:
(JSC::CopiedSpace::tryAllocate):
- heap/GCThreadSharedData.cpp:
(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::reset):
- heap/GCThreadSharedData.h:
(JSC):
(GCThreadSharedData):
- heap/HandleSet.cpp:
(JSC::HandleSet::HandleSet):
(JSC::HandleSet::~HandleSet):
(JSC::HandleSet::grow):
- heap/HandleSet.h:
(JSC):
(HandleSet):
(JSC::HandleSet::vm):
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC):
(JSC::Heap::lastChanceToFinalize):
(JSC::Heap::protect):
(JSC::Heap::unprotect):
(JSC::Heap::stack):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::deleteAllCompiledCode):
(JSC::Heap::collect):
(JSC::Heap::isValidAllocation):
- heap/Heap.h:
(JSC):
(Heap):
(JSC::Heap::vm):
- heap/HeapTimer.cpp:
(JSC::HeapTimer::HeapTimer):
(JSC::HeapTimer::timerDidFire):
(JSC::HeapTimer::timerEvent):
- heap/HeapTimer.h:
(JSC):
(HeapTimer):
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC::IncrementalSweeper::sweepNextBlock):
(JSC::IncrementalSweeper::willFinishSweeping):
(JSC::IncrementalSweeper::create):
- heap/IncrementalSweeper.h:
(IncrementalSweeper):
- heap/Local.h:
(Local):
(JSC::::Local):
(JSC::LocalStack::LocalStack):
(JSC::LocalStack::push):
(LocalStack):
- heap/LocalScope.h:
(JSC):
(LocalScope):
(JSC::LocalScope::LocalScope):
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::addCurrentThread):
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::allocateSlowCase):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::vm):
- heap/SlotVisitor.cpp:
(JSC::SlotVisitor::SlotVisitor):
(JSC::SlotVisitor::setup):
- heap/Strong.h:
(JSC):
(Strong):
(JSC::Strong::operator=):
- heap/StrongInlines.h:
(JSC::::Strong):
(JSC::::set):
- heap/SuperRegion.h:
(JSC):
- heap/WeakSet.cpp:
- heap/WeakSet.h:
(WeakSet):
(JSC::WeakSet::WeakSet):
(JSC::WeakSet::vm):
- interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):
- interpreter/AbstractPC.h:
(JSC):
(AbstractPC):
- interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
- interpreter/CallFrame.h:
(ExecState):
(JSC::ExecState::clearException):
(JSC::ExecState::clearSupplementaryExceptionInfo):
(JSC::ExecState::exception):
(JSC::ExecState::hadException):
(JSC::ExecState::propertyNames):
(JSC::ExecState::emptyList):
(JSC::ExecState::interpreter):
(JSC::ExecState::heap):
(JSC::ExecState::arrayConstructorTable):
(JSC::ExecState::arrayPrototypeTable):
(JSC::ExecState::booleanPrototypeTable):
(JSC::ExecState::dateTable):
(JSC::ExecState::dateConstructorTable):
(JSC::ExecState::errorPrototypeTable):
(JSC::ExecState::globalObjectTable):
(JSC::ExecState::jsonTable):
(JSC::ExecState::mathTable):
(JSC::ExecState::numberConstructorTable):
(JSC::ExecState::numberPrototypeTable):
(JSC::ExecState::objectConstructorTable):
(JSC::ExecState::privateNamePrototypeTable):
(JSC::ExecState::regExpTable):
(JSC::ExecState::regExpConstructorTable):
(JSC::ExecState::regExpPrototypeTable):
(JSC::ExecState::stringConstructorTable):
(JSC::ExecState::abstractReturnPC):
- interpreter/CallFrameClosure.h:
(CallFrameClosure):
- interpreter/Interpreter.cpp:
(JSC):
(JSC::eval):
(JSC::loadVarargs):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::appendSourceToError):
(JSC::getCallerInfo):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::retrieveArgumentsFromVMCode):
(JSC::Interpreter::retrieveCallerFromVMCode):
- interpreter/Interpreter.h:
(JSC):
(JSC::TopCallFrameSetter::TopCallFrameSetter):
(JSC::TopCallFrameSetter::~TopCallFrameSetter):
(TopCallFrameSetter):
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
(Interpreter):
- interpreter/JSStack.cpp:
(JSC::JSStack::JSStack):
- interpreter/JSStack.h:
(JSC):
- jit/ClosureCallStubRoutine.cpp:
(JSC::ClosureCallStubRoutine::ClosureCallStubRoutine):
- jit/ClosureCallStubRoutine.h:
(ClosureCallStubRoutine):
- jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::ExecutableAllocator):
(JSC::ExecutableAllocator::allocate):
- jit/ExecutableAllocator.h:
(JSC):
(ExecutableAllocator):
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::ExecutableAllocator):
(JSC::ExecutableAllocator::allocate):
- jit/GCAwareJITStubRoutine.cpp:
(JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):
(JSC::MarkingGCAwareJITStubRoutineWithOneObject::MarkingGCAwareJITStubRoutineWithOneObject):
(JSC::createJITStubRoutine):
- jit/GCAwareJITStubRoutine.h:
(GCAwareJITStubRoutine):
(MarkingGCAwareJITStubRoutineWithOneObject):
(JSC):
- jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompile):
(JSC::JIT::linkFor):
(JSC::JIT::linkSlowCall):
- jit/JIT.h:
(JSC::JIT::compile):
(JSC::JIT::compileClosureCall):
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JSC::JIT::compileGetByVal):
(JSC::JIT::compilePutByVal):
(JSC::JIT::compileCTINativeCall):
(JSC::JIT::compilePatchGetArrayLength):
(JIT):
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):
- jit/JITCode.h:
(JSC):
(JSC::JITCode::execute):
- jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
- jit/JITExceptions.cpp:
(JSC::genericThrow):
(JSC::jitThrow):
- jit/JITExceptions.h:
(JSC):
- jit/JITInlines.h:
(JSC::JIT::emitLoadCharacterString):
(JSC::JIT::updateTopCallFrame):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::privateCompileGetByVal):
(JSC::JIT::privateCompilePutByVal):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp:
(JSC::ctiTrampoline):
(JSC):
(JSC::performPlatformSpecificJITAssertions):
(JSC::tryCachePutByID):
(JSC::tryCacheGetByID):
(JSC::returnToThrowTrampoline):
(JSC::throwExceptionFromOpCall):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):
(JSC::putByVal):
- jit/JITStubs.h:
(JSC):
(JITStackFrame):
- jit/JITThunks.cpp:
(JSC::JITThunks::ctiNativeCall):
(JSC::JITThunks::ctiNativeConstruct):
(JSC::JITThunks::ctiStub):
(JSC::JITThunks::hostFunctionStub):
- jit/JITThunks.h:
(JSC):
(JITThunks):
- jit/JITWriteBarrier.h:
(JSC):
(JSC::JITWriteBarrierBase::set):
(JSC::JITWriteBarrier::set):
- jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::loadJSStringArgument):
(JSC::SpecializedThunkJIT::finalize):
- jit/ThunkGenerator.h:
(JSC):
- jit/ThunkGenerators.cpp:
(JSC::generateSlowCaseFor):
(JSC::linkForGenerator):
(JSC::linkCallGenerator):
(JSC::linkConstructGenerator):
(JSC::linkClosureCallGenerator):
(JSC::virtualForGenerator):
(JSC::virtualCallGenerator):
(JSC::virtualConstructGenerator):
(JSC::stringLengthTrampolineGenerator):
(JSC::nativeForGenerator):
(JSC::nativeCallGenerator):
(JSC::nativeConstructGenerator):
(JSC::stringCharLoad):
(JSC::charToString):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
- jit/ThunkGenerators.h:
(JSC):
- jsc.cpp:
(GlobalObject):
(GlobalObject::create):
(GlobalObject::createStructure):
(GlobalObject::finishCreation):
(GlobalObject::addFunction):
(GlobalObject::addConstructableFunction):
(functionDumpCallFrame):
(functionJSCStack):
(functionReleaseExecutableMemory):
(functionRun):
(main):
(runWithScripts):
(jscmain):
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LLIntData.h:
(JSC):
(Data):
(JSC::LLInt::Data::performAssertions):
- llint/LLIntEntrypoints.cpp:
(JSC::LLInt::getFunctionEntrypoint):
(JSC::LLInt::getEvalEntrypoint):
(JSC::LLInt::getProgramEntrypoint):
- llint/LLIntEntrypoints.h:
(JSC):
(LLInt):
(JSC::LLInt::getEntrypoint):
- llint/LLIntExceptions.cpp:
(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
- llint/LLIntOffsetsExtractor.cpp:
- llint/LLIntSlowPaths.cpp:
(LLInt):
(JSC::LLInt::llint_trace_operand):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::shouldJIT):
(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):
- llint/LLIntThunks.cpp:
(JSC::LLInt::generateThunkWithJumpTo):
(JSC::LLInt::functionForCallEntryThunkGenerator):
(JSC::LLInt::functionForConstructEntryThunkGenerator):
(JSC::LLInt::functionForCallArityCheckThunkGenerator):
(JSC::LLInt::functionForConstructArityCheckThunkGenerator):
(JSC::LLInt::evalEntryThunkGenerator):
(JSC::LLInt::programEntryThunkGenerator):
- llint/LLIntThunks.h:
(JSC):
(LLInt):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/cloop.rb:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::ASTBuilder):
(JSC::ASTBuilder::createSourceElements):
(JSC::ASTBuilder::createCommaExpr):
(JSC::ASTBuilder::createLogicalNot):
(JSC::ASTBuilder::createUnaryPlus):
(JSC::ASTBuilder::createVoid):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createObjectLiteral):
(JSC::ASTBuilder::createArray):
(JSC::ASTBuilder::createNumberExpr):
(JSC::ASTBuilder::createString):
(JSC::ASTBuilder::createBoolean):
(JSC::ASTBuilder::createNull):
(JSC::ASTBuilder::createBracketAccess):
(JSC::ASTBuilder::createDotAccess):
(JSC::ASTBuilder::createRegExp):
(JSC::ASTBuilder::createNewExpr):
(JSC::ASTBuilder::createConditionalExpr):
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createArguments):
(JSC::ASTBuilder::createArgumentsList):
(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::createPropertyList):
(JSC::ASTBuilder::createElementList):
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createClause):
(JSC::ASTBuilder::createClauseList):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createEmptyStatement):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createLabelStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
(JSC::ASTBuilder::appendConstDecl):
(JSC::ASTBuilder::addVar):
(JSC::ASTBuilder::combineCommaNodes):
(JSC::ASTBuilder::Scope::Scope):
(JSC::ASTBuilder::createNumber):
(ASTBuilder):
(JSC::ASTBuilder::makeTypeOfNode):
(JSC::ASTBuilder::makeDeleteNode):
(JSC::ASTBuilder::makeNegateNode):
(JSC::ASTBuilder::makeBitwiseNotNode):
(JSC::ASTBuilder::makeMultNode):
(JSC::ASTBuilder::makeDivNode):
(JSC::ASTBuilder::makeModNode):
(JSC::ASTBuilder::makeAddNode):
(JSC::ASTBuilder::makeSubNode):
(JSC::ASTBuilder::makeLeftShiftNode):
(JSC::ASTBuilder::makeRightShiftNode):
(JSC::ASTBuilder::makeURightShiftNode):
(JSC::ASTBuilder::makeBitOrNode):
(JSC::ASTBuilder::makeBitAndNode):
(JSC::ASTBuilder::makeBitXOrNode):
(JSC::ASTBuilder::makeFunctionCallNode):
(JSC::ASTBuilder::makeBinaryNode):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):
- parser/Lexer.cpp:
(JSC::Keywords::Keywords):
(JSC::::Lexer):
(JSC::::parseIdentifier):
(JSC::::parseIdentifierSlowCase):
- parser/Lexer.h:
(JSC::Keywords::isKeyword):
(JSC::Keywords::getKeyword):
(Keywords):
(Lexer):
(JSC::::makeIdentifier):
(JSC::::makeRightSizedIdentifier):
(JSC::::makeIdentifierLCharFromUChar):
(JSC::::makeLCharIdentifier):
- parser/NodeConstructors.h:
(JSC::ParserArenaFreeable::operator new):
(JSC::ParserArenaDeletable::operator new):
(JSC::ParserArenaRefCounted::ParserArenaRefCounted):
(JSC::PropertyNode::PropertyNode):
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ForInNode::ForInNode):
- parser/Nodes.cpp:
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):
- parser/Nodes.h:
(ParserArenaFreeable):
(ParserArenaDeletable):
(ParserArenaRefCounted):
(ArrayNode):
(ForInNode):
(ContinueNode):
(BreakNode):
(ScopeNode):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):
- parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseInner):
(JSC::::parseSourceElements):
(JSC::::parseTryStatement):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseAssignmentExpression):
(JSC::::parseProperty):
(JSC::::parsePrimaryExpression):
(JSC::::parseMemberExpression):
(JSC::::parseUnaryExpression):
- parser/Parser.h:
(JSC):
(JSC::Scope::Scope):
(JSC::Scope::declareVariable):
(JSC::Scope::declareParameter):
(Scope):
(Parser):
(JSC::Parser::pushScope):
(JSC::::parse):
(JSC::parse):
- parser/ParserArena.h:
(IdentifierArena):
(JSC::IdentifierArena::makeIdentifier):
(JSC::IdentifierArena::makeIdentifierLCharFromUChar):
(JSC::IdentifierArena::makeNumericIdentifier):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::SyntaxChecker):
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
- profiler/LegacyProfiler.cpp:
(JSC::LegacyProfiler::startProfiling):
(JSC::LegacyProfiler::stopProfiling):
- profiler/LegacyProfiler.h:
(JSC):
- profiler/ProfilerBytecode.cpp:
(JSC::Profiler::Bytecode::toJS):
- profiler/ProfilerBytecodeSequence.cpp:
(JSC::Profiler::BytecodeSequence::BytecodeSequence):
(JSC::Profiler::BytecodeSequence::addSequenceProperties):
- profiler/ProfilerBytecodes.cpp:
(JSC::Profiler::Bytecodes::toJS):
- profiler/ProfilerCompilation.cpp:
(JSC::Profiler::Compilation::toJS):
- profiler/ProfilerCompiledBytecode.cpp:
(JSC::Profiler::CompiledBytecode::toJS):
- profiler/ProfilerDatabase.cpp:
(JSC::Profiler::Database::Database):
(JSC::Profiler::Database::toJS):
(JSC::Profiler::Database::toJSON):
- profiler/ProfilerDatabase.h:
(Database):
- profiler/ProfilerOSRExit.cpp:
(JSC::Profiler::OSRExit::toJS):
- profiler/ProfilerOrigin.cpp:
(JSC::Profiler::Origin::toJS):
- profiler/ProfilerProfiledBytecodes.cpp:
(JSC::Profiler::ProfiledBytecodes::toJS):
- runtime/ArgList.h:
(MarkedArgumentBuffer):
- runtime/Arguments.cpp:
(JSC::Arguments::putByIndex):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
(JSC::Arguments::defineOwnProperty):
(JSC::Arguments::tearOff):
(JSC::Arguments::didTearOffActivation):
(JSC::Arguments::tearOffForInlineCallFrame):
- runtime/Arguments.h:
(JSC::Arguments::create):
(JSC::Arguments::createStructure):
(Arguments):
(JSC::Arguments::Arguments):
(JSC::Arguments::trySetArgument):
(JSC::Arguments::finishCreation):
- runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::finishCreation):
- runtime/ArrayConstructor.h:
(JSC::ArrayConstructor::createStructure):
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::ArrayPrototype):
(JSC::ArrayPrototype::finishCreation):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
- runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::createStructure):
- runtime/BatchedTransitionOptimizer.h:
(JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
(JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
(BatchedTransitionOptimizer):
- runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::finishCreation):
(JSC::constructBoolean):
(JSC::constructBooleanFromImmediateBoolean):
- runtime/BooleanConstructor.h:
(JSC::BooleanConstructor::createStructure):
- runtime/BooleanObject.cpp:
(JSC::BooleanObject::BooleanObject):
(JSC::BooleanObject::finishCreation):
- runtime/BooleanObject.h:
(BooleanObject):
(JSC::BooleanObject::create):
(JSC::BooleanObject::createStructure):
- runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
(JSC::BooleanPrototype::finishCreation):
(JSC::booleanProtoFuncToString):
- runtime/BooleanPrototype.h:
(JSC::BooleanPrototype::createStructure):
- runtime/Butterfly.h:
(JSC):
(Butterfly):
- runtime/ButterflyInlines.h:
(JSC::Butterfly::createUninitialized):
(JSC::Butterfly::create):
(JSC::Butterfly::growPropertyStorage):
(JSC::Butterfly::createOrGrowArrayRight):
(JSC::Butterfly::growArrayRight):
(JSC::Butterfly::resizeArray):
- runtime/CodeCache.cpp:
(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
- runtime/CodeCache.h:
(JSC):
(JSC::SourceCodeValue::SourceCodeValue):
(CodeCache):
- runtime/CommonIdentifiers.cpp:
(JSC):
(JSC::CommonIdentifiers::CommonIdentifiers):
- runtime/CommonIdentifiers.h:
(CommonIdentifiers):
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::opIn):
- runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
- runtime/DateConstructor.cpp:
(JSC::DateConstructor::finishCreation):
- runtime/DateConstructor.h:
(JSC::DateConstructor::createStructure):
- runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
(JSC::DateInstance::finishCreation):
(JSC::DateInstance::calculateGregorianDateTime):
(JSC::DateInstance::calculateGregorianDateTimeUTC):
- runtime/DateInstance.h:
(DateInstance):
(JSC::DateInstance::create):
(JSC::DateInstance::createStructure):
- runtime/DatePrototype.cpp:
(JSC::DatePrototype::finishCreation):
(JSC::dateProtoFuncSetTime):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncToJSON):
- runtime/DatePrototype.h:
(JSC::DatePrototype::createStructure):
- runtime/Error.cpp:
(JSC::createError):
(JSC::createEvalError):
(JSC::createRangeError):
(JSC::createReferenceError):
(JSC::createSyntaxError):
(JSC::createTypeError):
(JSC::createURIError):
(JSC::addErrorInfo):
(JSC::throwError):
- runtime/Error.h:
(JSC):
(JSC::StrictModeTypeErrorFunction::create):
(JSC::StrictModeTypeErrorFunction::createStructure):
- runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::finishCreation):
- runtime/ErrorConstructor.h:
(JSC::ErrorConstructor::createStructure):
- runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
- runtime/ErrorInstance.h:
(JSC::ErrorInstance::createStructure):
(JSC::ErrorInstance::create):
(ErrorInstance):
(JSC::ErrorInstance::finishCreation):
- runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::finishCreation):
- runtime/ErrorPrototype.h:
(JSC::ErrorPrototype::createStructure):
- runtime/ExceptionHelpers.cpp:
(JSC::createInterruptedExecutionException):
(JSC::createTerminatedExecutionException):
- runtime/ExceptionHelpers.h:
(JSC):
(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::InterruptedExecutionError::create):
(JSC::InterruptedExecutionError::createStructure):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
(JSC::TerminatedExecutionError::create):
(JSC::TerminatedExecutionError::createStructure):
- runtime/Executable.cpp:
(JSC::jettisonCodeBlock):
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::EvalExecutable::compileOptimized):
(JSC::EvalExecutable::compileInternal):
(JSC::EvalExecutable::jettisonOptimizedCode):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compileOptimized):
(JSC::ProgramExecutable::jettisonOptimizedCode):
(JSC::ProgramExecutable::initializeGlobalProperties):
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::jettisonOptimizedCodeForCall):
(JSC::FunctionExecutable::jettisonOptimizedCodeForConstruct):
(JSC::FunctionExecutable::fromGlobalCode):
- runtime/Executable.h:
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::finishCreation):
(JSC::ExecutableBase::createStructure):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::createStructure):
(JSC::NativeExecutable::finishCreation):
(JSC::NativeExecutable::NativeExecutable):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::finishCreation):
(JSC::EvalExecutable::compile):
(EvalExecutable):
(JSC::EvalExecutable::create):
(JSC::EvalExecutable::createStructure):
(JSC::ProgramExecutable::create):
(ProgramExecutable):
(JSC::ProgramExecutable::compile):
(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::compileForCall):
(FunctionExecutable):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::FunctionExecutable::jettisonOptimizedCodeFor):
(JSC::FunctionExecutable::createStructure):
(JSC::JSFunction::JSFunction):
- runtime/ExecutionHarness.h:
(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):
- runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::finishCreation):
- runtime/FunctionConstructor.h:
(JSC::FunctionConstructor::createStructure):
- runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::finishCreation):
(JSC::FunctionPrototype::addFunctionProperties):
(JSC::functionProtoFuncBind):
- runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::createStructure):
- runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
(JSC::DefaultGCActivityCallback::didAllocate):
- runtime/GCActivityCallback.h:
(JSC::GCActivityCallback::GCActivityCallback):
- runtime/GCActivityCallbackBlackBerry.cpp:
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
(JSC::DefaultGCActivityCallback::didAllocate):
- runtime/GetterSetter.h:
(JSC::GetterSetter::GetterSetter):
(JSC::GetterSetter::create):
(JSC::GetterSetter::setGetter):
(JSC::GetterSetter::setSetter):
(JSC::GetterSetter::createStructure):
- runtime/Identifier.cpp:
(JSC::Identifier::add):
(JSC::Identifier::add8):
(JSC::Identifier::addSlowCase):
(JSC::Identifier::from):
(JSC::Identifier::checkCurrentIdentifierTable):
- runtime/Identifier.h:
(JSC::Identifier::Identifier):
(JSC::Identifier::createLCharFromUChar):
(Identifier):
(JSC::Identifier::add):
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
(JSC::InternalFunction::finishCreation):
(JSC::InternalFunction::name):
(JSC::InternalFunction::displayName):
- runtime/InternalFunction.h:
(JSC::InternalFunction::createStructure):
(InternalFunction):
- runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
(JSC::JSAPIValueWrapper::finishCreation):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):
- runtime/JSActivation.cpp:
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::symbolTablePutWithAttributes):
(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::put):
(JSC::JSActivation::putDirectVirtual):
(JSC::JSActivation::argumentsGetter):
- runtime/JSActivation.h:
(JSActivation):
(JSC::JSActivation::create):
(JSC::JSActivation::createStructure):
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::tearOff):
- runtime/JSArray.cpp:
(JSC::createArrayButterflyInDictionaryIndexingMode):
(JSC::JSArray::setLengthWritable):
(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::setLength):
(JSC::JSArray::push):
(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithArrayStorage):
(JSC::JSArray::unshiftCountWithAnyIndexingType):
(JSC::ContiguousTypeAccessor::setWithValue):
(JSC::JSArray::sortCompactedVector):
(JSC::JSArray::sortVector):
- runtime/JSArray.h:
(JSC::JSArray::JSArray):
(JSArray):
(JSC::JSArray::shiftCountForShift):
(JSC::JSArray::unshiftCountForShift):
(JSC::JSArray::createStructure):
(JSC::createContiguousArrayButterfly):
(JSC::createArrayButterfly):
(JSC):
(JSC::JSArray::create):
(JSC::JSArray::tryCreateUninitialized):
(JSC::constructArray):
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::JSBoundFunction):
- runtime/JSBoundFunction.h:
(JSC::JSBoundFunction::createStructure):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::putToPrimitive):
(JSC::JSValue::toStringSlowCase):
- runtime/JSCJSValue.h:
(JSC):
- runtime/JSCell.h:
(JSCell):
- runtime/JSCellInlines.h:
(JSC::JSCell::JSCell):
(JSC::JSCell::finishCreation):
(JSC::allocateCell):
(JSC::JSCell::setStructure):
(JSC::JSCell::fastGetOwnProperty):
- runtime/JSDateMath.cpp:
(JSC::getDSTOffset):
(JSC::getUTCOffset):
(JSC::parseDate):
- runtime/JSDestructibleObject.h:
(JSC::JSDestructibleObject::JSDestructibleObject):
- runtime/JSFunction.cpp:
(JSC::JSFunction::create):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::finishCreation):
(JSC::JSFunction::createAllocationProfile):
(JSC::JSFunction::name):
(JSC::JSFunction::displayName):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::deleteProperty):
- runtime/JSFunction.h:
(JSFunction):
(JSC::JSFunction::create):
(JSC::JSFunction::setScope):
(JSC::JSFunction::createStructure):
- runtime/JSGlobalData.cpp: Removed.
- runtime/JSGlobalData.h: Removed.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::setGlobalThis):
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::putDirectVirtual):
(JSC::JSGlobalObject::reset):
(JSC):
(JSC::JSGlobalObject::haveABadTime):
(JSC::JSGlobalObject::createThrowTypeError):
(JSC::JSGlobalObject::resetPrototype):
(JSC::JSGlobalObject::addStaticGlobals):
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::create):
(JSGlobalObject):
(JSC::JSGlobalObject::finishCreation):
(JSC::JSGlobalObject::vm):
(JSC::JSGlobalObject::createStructure):
(JSC::ExecState::dynamicGlobalObject):
(JSC::constructEmptyArray):
(DynamicGlobalObjectScope):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncProtoSetter):
- runtime/JSLock.cpp:
(JSC::JSLockHolder::JSLockHolder):
(JSC::JSLockHolder::init):
(JSC::JSLockHolder::~JSLockHolder):
(JSC::JSLock::JSLock):
(JSC::JSLock::willDestroyGlobalData):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):
- runtime/JSLock.h:
(JSC):
(JSLockHolder):
(JSLock):
(JSC::JSLock::vm):
(DropAllLocks):
- runtime/JSNameScope.h:
(JSC::JSNameScope::createStructure):
(JSC::JSNameScope::finishCreation):
(JSC::JSNameScope::JSNameScope):
- runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::JSNotAnObject):
(JSC::JSNotAnObject::create):
(JSC::JSNotAnObject::createStructure):
- runtime/JSONObject.cpp:
(JSC::JSONObject::JSONObject):
(JSC::JSONObject::finishCreation):
(Holder):
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::stringify):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
(JSC::Stringifier::Holder::Holder):
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::Walker):
(JSC::Walker::walk):
(JSC::JSONProtoFuncParse):
(JSC::JSONProtoFuncStringify):
(JSC::JSONStringify):
- runtime/JSONObject.h:
(JSC::JSONObject::createStructure):
- runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putByIndex):
(JSC::JSObject::enterDictionaryIndexingModeWhenArrayStorageAlreadyExists):
(JSC::JSObject::enterDictionaryIndexingMode):
(JSC::JSObject::notifyPresenceOfIndexedAccessors):
(JSC::JSObject::createInitialIndexedStorage):
(JSC::JSObject::createInitialUndecided):
(JSC::JSObject::createInitialInt32):
(JSC::JSObject::createInitialDouble):
(JSC::JSObject::createInitialContiguous):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::createInitialArrayStorage):
(JSC::JSObject::convertUndecidedToInt32):
(JSC::JSObject::convertUndecidedToDouble):
(JSC::JSObject::convertUndecidedToContiguous):
(JSC::JSObject::constructConvertedArrayStorageWithoutCopyingElements):
(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToDouble):
(JSC::JSObject::convertInt32ToContiguous):
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::genericConvertDoubleToContiguous):
(JSC::JSObject::convertDoubleToContiguous):
(JSC::JSObject::rageConvertDoubleToContiguous):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
(JSC::JSObject::convertUndecidedForValue):
(JSC::JSObject::convertInt32ForValue):
(JSC::JSObject::setIndexQuicklyToUndecided):
(JSC::JSObject::convertInt32ToDoubleOrContiguousWhilePerformingSetIndex):
(JSC::JSObject::convertDoubleToContiguousWhilePerformingSetIndex):
(JSC::JSObject::ensureInt32Slow):
(JSC::JSObject::ensureDoubleSlow):
(JSC::JSObject::ensureContiguousSlow):
(JSC::JSObject::rageEnsureContiguousSlow):
(JSC::JSObject::ensureArrayStorageSlow):
(JSC::JSObject::ensureArrayStorageExistsAndEnterDictionaryIndexingMode):
(JSC::JSObject::switchToSlowPutArrayStorage):
(JSC::JSObject::putDirectVirtual):
(JSC::JSObject::setPrototype):
(JSC::JSObject::setPrototypeWithCycleCheck):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::getPropertySpecificValue):
(JSC::JSObject::getOwnNonIndexPropertyNames):
(JSC::JSObject::seal):
(JSC::JSObject::freeze):
(JSC::JSObject::preventExtensions):
(JSC::JSObject::reifyStaticFunctionsForDelete):
(JSC::JSObject::removeDirect):
(JSC::JSObject::putIndexedDescriptor):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::allocateSparseIndexMap):
(JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes):
(JSC::JSObject::putByIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::putByIndexBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::putDirectIndexBeyondVectorLength):
(JSC::JSObject::putDirectNativeFunction):
(JSC::JSObject::increaseVectorLength):
(JSC::JSObject::ensureLengthSlow):
(JSC::JSObject::growOutOfLineStorage):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::putDescriptor):
(JSC::JSObject::putDirectMayBeIndex):
(JSC::DefineOwnPropertyScope::DefineOwnPropertyScope):
(JSC::DefineOwnPropertyScope::~DefineOwnPropertyScope):
(DefineOwnPropertyScope):
(JSC::JSObject::defineOwnNonIndexProperty):
- runtime/JSObject.h:
(JSObject):
(JSC::JSObject::putByIndexInline):
(JSC::JSObject::putDirectIndex):
(JSC::JSObject::setIndexQuickly):
(JSC::JSObject::initializeIndex):
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectOffset):
(JSC::JSObject::putDirect):
(JSC::JSObject::isSealed):
(JSC::JSObject::isFrozen):
(JSC::JSObject::flattenDictionaryObject):
(JSC::JSObject::ensureInt32):
(JSC::JSObject::ensureDouble):
(JSC::JSObject::ensureContiguous):
(JSC::JSObject::rageEnsureContiguous):
(JSC::JSObject::ensureArrayStorage):
(JSC::JSObject::finishCreation):
(JSC::JSObject::createStructure):
(JSC::JSObject::ensureLength):
(JSC::JSNonFinalObject::createStructure):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSC::JSFinalObject::createStructure):
(JSC::JSFinalObject::finishCreation):
(JSC::JSFinalObject::JSFinalObject):
(JSC::JSFinalObject::create):
(JSC::JSObject::setButterfly):
(JSC::JSObject::JSObject):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
(JSC::JSObject::putOwnDataProperty):
(JSC::JSObject::putDirectWithoutTransition):
(JSC):
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::JSPropertyNameIterator::create):
- runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::createStructure):
(JSC::JSPropertyNameIterator::setCachedStructure):
(JSC::JSPropertyNameIterator::setCachedPrototypeChain):
(JSC::JSPropertyNameIterator::finishCreation):
(JSC::StructureRareData::setEnumerationCache):
- runtime/JSProxy.cpp:
(JSC::JSProxy::setTarget):
- runtime/JSProxy.h:
(JSC::JSProxy::create):
(JSC::JSProxy::createStructure):
(JSC::JSProxy::JSProxy):
(JSC::JSProxy::finishCreation):
(JSProxy):
- runtime/JSScope.cpp:
(JSC::executeResolveOperations):
(JSC::JSScope::resolveContainingScopeInternal):
(JSC::JSScope::resolveWithBase):
(JSC::JSScope::resolveWithThis):
(JSC::JSScope::resolvePut):
- runtime/JSScope.h:
(JSScope):
(JSC::JSScope::JSScope):
(JSC::JSScope::vm):
(JSC::ExecState::vm):
- runtime/JSSegmentedVariableObject.h:
(JSC::JSSegmentedVariableObject::JSSegmentedVariableObject):
(JSC::JSSegmentedVariableObject::finishCreation):
- runtime/JSString.cpp:
(JSC::JSRopeString::RopeBuilder::expand):
(JSC::StringObject::create):
- runtime/JSString.h:
(JSC):
(JSString):
(JSC::JSString::JSString):
(JSC::JSString::finishCreation):
(JSC::JSString::create):
(JSC::JSString::createHasOtherOwner):
(JSC::JSString::createStructure):
(JSRopeString):
(JSC::JSRopeString::RopeBuilder::RopeBuilder):
(JSC::JSRopeString::RopeBuilder::append):
(RopeBuilder):
(JSC::JSRopeString::JSRopeString):
(JSC::JSRopeString::finishCreation):
(JSC::JSRopeString::append):
(JSC::JSRopeString::createNull):
(JSC::JSRopeString::create):
(JSC::jsEmptyString):
(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsNontrivialString):
(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsSubstring8):
(JSC::jsOwnedString):
(JSC::jsStringBuilder):
(JSC::inlineJSValueNotStringtoString):
- runtime/JSStringJoiner.cpp:
(JSC::JSStringJoiner::build):
- runtime/JSSymbolTableObject.h:
(JSC::JSSymbolTableObject::JSSymbolTableObject):
(JSC::JSSymbolTableObject::finishCreation):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):
- runtime/JSVariableObject.h:
(JSC::JSVariableObject::JSVariableObject):
- runtime/JSWithScope.h:
(JSC::JSWithScope::create):
(JSC::JSWithScope::createStructure):
(JSC::JSWithScope::JSWithScope):
- runtime/JSWrapperObject.h:
(JSWrapperObject):
(JSC::JSWrapperObject::createStructure):
(JSC::JSWrapperObject::JSWrapperObject):
(JSC::JSWrapperObject::setInternalValue):
- runtime/LiteralParser.cpp:
(JSC::::tryJSONPParse):
(JSC::::makeIdentifier):
(JSC::::parse):
- runtime/Lookup.cpp:
(JSC::HashTable::createTable):
(JSC::setUpStaticFunctionSlot):
- runtime/Lookup.h:
(JSC::HashTable::initializeIfNeeded):
(JSC::HashTable::entry):
(JSC::HashTable::begin):
(JSC::HashTable::end):
(HashTable):
(JSC::lookupPut):
- runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
(JSC::MathObject::finishCreation):
(JSC::mathProtoFuncSin):
- runtime/MathObject.h:
(JSC::MathObject::createStructure):
- runtime/MemoryStatistics.cpp:
- runtime/MemoryStatistics.h:
- runtime/NameConstructor.cpp:
(JSC::NameConstructor::finishCreation):
(JSC::constructPrivateName):
- runtime/NameConstructor.h:
(JSC::NameConstructor::createStructure):
- runtime/NameInstance.cpp:
(JSC::NameInstance::NameInstance):
- runtime/NameInstance.h:
(JSC::NameInstance::createStructure):
(JSC::NameInstance::create):
(NameInstance):
(JSC::NameInstance::finishCreation):
- runtime/NamePrototype.cpp:
(JSC::NamePrototype::NamePrototype):
(JSC::NamePrototype::finishCreation):
- runtime/NamePrototype.h:
(JSC::NamePrototype::createStructure):
- runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::createStructure):
(JSC::NativeErrorConstructor::finishCreation):
- runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::finishCreation):
- runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::finishCreation):
(JSC::constructWithNumberConstructor):
- runtime/NumberConstructor.h:
(JSC::NumberConstructor::createStructure):
- runtime/NumberObject.cpp:
(JSC::NumberObject::NumberObject):
(JSC::NumberObject::finishCreation):
(JSC::constructNumber):
- runtime/NumberObject.h:
(NumberObject):
(JSC::NumberObject::create):
(JSC::NumberObject::createStructure):
- runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
(JSC::NumberPrototype::finishCreation):
(JSC::integerValueToString):
(JSC::numberProtoFuncToString):
- runtime/NumberPrototype.h:
(JSC::NumberPrototype::createStructure):
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::finishCreation):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorPreventExtensions):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
- runtime/ObjectConstructor.h:
(JSC::ObjectConstructor::createStructure):
(JSC::constructEmptyObject):
- runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
(JSC::ObjectPrototype::finishCreation):
(JSC::objectProtoFuncToString):
- runtime/ObjectPrototype.h:
(JSC::ObjectPrototype::createStructure):
- runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
- runtime/Operations.h:
(JSC):
(JSC::jsString):
(JSC::jsStringFromArguments):
(JSC::normalizePrototypeChainForChainAccess):
(JSC::normalizePrototypeChain):
- runtime/PropertyMapHashTable.h:
(JSC::PropertyMapEntry::PropertyMapEntry):
(JSC::PropertyTable::createStructure):
(PropertyTable):
(JSC::PropertyTable::copy):
- runtime/PropertyNameArray.h:
(JSC::PropertyNameArray::PropertyNameArray):
(JSC::PropertyNameArray::vm):
(JSC::PropertyNameArray::addKnownUnique):
(PropertyNameArray):
- runtime/PropertyTable.cpp:
(JSC::PropertyTable::create):
(JSC::PropertyTable::clone):
(JSC::PropertyTable::PropertyTable):
- runtime/PrototypeMap.cpp:
(JSC::PrototypeMap::emptyObjectStructureForPrototype):
- runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
(JSC::RegExp::finishCreation):
(JSC::RegExp::createWithoutCaching):
(JSC::RegExp::create):
(JSC::RegExp::compile):
(JSC::RegExp::compileIfNecessary):
(JSC::RegExp::match):
(JSC::RegExp::compileMatchOnly):
(JSC::RegExp::compileIfNecessaryMatchOnly):
- runtime/RegExp.h:
(JSC):
(RegExp):
(JSC::RegExp::createStructure):
- runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::RegExpCache):
(JSC::RegExpCache::addToStrongCache):
- runtime/RegExpCache.h:
(RegExpCache):
- runtime/RegExpCachedResult.cpp:
(JSC::RegExpCachedResult::lastResult):
(JSC::RegExpCachedResult::setInput):
- runtime/RegExpCachedResult.h:
(JSC::RegExpCachedResult::RegExpCachedResult):
(JSC::RegExpCachedResult::record):
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpConstructor::finishCreation):
(JSC::constructRegExp):
- runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::createStructure):
(RegExpConstructor):
(JSC::RegExpConstructor::performMatch):
- runtime/RegExpMatchesArray.cpp:
(JSC::RegExpMatchesArray::RegExpMatchesArray):
(JSC::RegExpMatchesArray::create):
(JSC::RegExpMatchesArray::finishCreation):
(JSC::RegExpMatchesArray::reifyAllProperties):
- runtime/RegExpMatchesArray.h:
(RegExpMatchesArray):
(JSC::RegExpMatchesArray::createStructure):
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::finishCreation):
(JSC::RegExpObject::match):
- runtime/RegExpObject.h:
(JSC::RegExpObject::create):
(JSC::RegExpObject::setRegExp):
(JSC::RegExpObject::setLastIndex):
(JSC::RegExpObject::createStructure):
- runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
- runtime/RegExpPrototype.h:
(JSC::RegExpPrototype::createStructure):
- runtime/SmallStrings.cpp:
(JSC::SmallStrings::initializeCommonStrings):
(JSC::SmallStrings::createEmptyString):
(JSC::SmallStrings::createSingleCharacterString):
(JSC::SmallStrings::initialize):
- runtime/SmallStrings.h:
(JSC):
(JSC::SmallStrings::singleCharacterString):
(SmallStrings):
- runtime/SparseArrayValueMap.cpp:
(JSC::SparseArrayValueMap::SparseArrayValueMap):
(JSC::SparseArrayValueMap::finishCreation):
(JSC::SparseArrayValueMap::create):
(JSC::SparseArrayValueMap::createStructure):
(JSC::SparseArrayValueMap::putDirect):
(JSC::SparseArrayEntry::put):
- runtime/SparseArrayValueMap.h:
- runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::StrictEvalActivation):
- runtime/StrictEvalActivation.h:
(JSC::StrictEvalActivation::create):
(JSC::StrictEvalActivation::createStructure):
- runtime/StringConstructor.cpp:
(JSC::StringConstructor::finishCreation):
- runtime/StringConstructor.h:
(JSC::StringConstructor::createStructure):
- runtime/StringObject.cpp:
(JSC::StringObject::StringObject):
(JSC::StringObject::finishCreation):
(JSC::constructString):
- runtime/StringObject.h:
(JSC::StringObject::create):
(JSC::StringObject::createStructure):
(StringObject):
- runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
(JSC::StringPrototype::finishCreation):
(JSC::removeUsingRegExpSearch):
(JSC::replaceUsingRegExpSearch):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSplit):
- runtime/StringPrototype.h:
(JSC::StringPrototype::createStructure):
- runtime/StringRecursionChecker.h:
(JSC::StringRecursionChecker::performCheck):
(JSC::StringRecursionChecker::~StringRecursionChecker):
- runtime/Structure.cpp:
(JSC::StructureTransitionTable::add):
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::toCacheableDictionaryTransition):
(JSC::Structure::toUncacheableDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::takePropertyTableOrCloneIfPinned):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::allocateRareData):
(JSC::Structure::cloneRareDataFrom):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNamesFromStructure):
(JSC::Structure::prototypeChainMayInterceptStoreTo):
- runtime/Structure.h:
(Structure):
(JSC::Structure::finishCreation):
(JSC::Structure::setPrototypeWithoutTransition):
(JSC::Structure::setGlobalObject):
(JSC::Structure::setObjectToStringValue):
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
(JSC::Structure::setPreviousID):
- runtime/StructureChain.cpp:
(JSC::StructureChain::StructureChain):
- runtime/StructureChain.h:
(JSC::StructureChain::create):
(JSC::StructureChain::createStructure):
(JSC::StructureChain::finishCreation):
(StructureChain):
- runtime/StructureInlines.h:
(JSC::Structure::create):
(JSC::Structure::createStructure):
(JSC::Structure::get):
(JSC::Structure::setEnumerationCache):
(JSC::Structure::prototypeChain):
(JSC::Structure::propertyTable):
- runtime/StructureRareData.cpp:
(JSC::StructureRareData::createStructure):
(JSC::StructureRareData::create):
(JSC::StructureRareData::clone):
(JSC::StructureRareData::StructureRareData):
- runtime/StructureRareData.h:
(StructureRareData):
- runtime/StructureRareDataInlines.h:
(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::setObjectToStringValue):
- runtime/StructureTransitionTable.h:
(StructureTransitionTable):
(JSC::StructureTransitionTable::setSingleTransition):
- runtime/SymbolTable.h:
(JSC::SharedSymbolTable::create):
(JSC::SharedSymbolTable::createStructure):
(JSC::SharedSymbolTable::SharedSymbolTable):
- runtime/VM.cpp: Copied from Source/JavaScriptCore/runtime/JSGlobalData.cpp.
(JSC::VM::VM):
(JSC::VM::~VM):
(JSC::VM::createContextGroup):
(JSC::VM::create):
(JSC::VM::createLeaked):
(JSC::VM::sharedInstanceExists):
(JSC::VM::sharedInstance):
(JSC::VM::sharedInstanceInternal):
(JSC::VM::getHostFunction):
(JSC::VM::ClientData::~ClientData):
(JSC::VM::resetDateCache):
(JSC::VM::startSampling):
(JSC::VM::stopSampling):
(JSC::VM::discardAllCode):
(JSC::VM::dumpSampleData):
(JSC::VM::addSourceProviderCache):
(JSC::VM::clearSourceProviderCaches):
(JSC::VM::releaseExecutableMemory):
(JSC::releaseExecutableMemory):
(JSC::VM::gatherConservativeRoots):
(JSC::VM::addRegExpToTrace):
(JSC::VM::dumpRegExpTrace):
- runtime/VM.h: Copied from Source/JavaScriptCore/runtime/JSGlobalData.h.
(VM):
(JSC::VM::isSharedInstance):
(JSC::VM::usingAPI):
(JSC::VM::isInitializingObject):
(JSC::VM::setInitializingObjectClass):
(JSC::WeakSet::heap):
- runtime/WriteBarrier.h:
(JSC):
(JSC::WriteBarrierBase::set):
(JSC::WriteBarrierBase::setMayBeNull):
(JSC::WriteBarrierBase::setEarlyValue):
(JSC::WriteBarrier::WriteBarrier):
- testRegExp.cpp:
(GlobalObject):
(GlobalObject::create):
(GlobalObject::createStructure):
(GlobalObject::finishCreation):
(main):
(testOneRegExp):
(parseRegExpLine):
(runFromFiles):
(realMain):
- yarr/YarrInterpreter.h:
(BytecodePattern):
- yarr/YarrJIT.cpp:
(YarrGenerator):
(JSC::Yarr::YarrGenerator::compile):
(JSC::Yarr::jitCompile):
- yarr/YarrJIT.h:
(JSC):
../WebCore:
- ForwardingHeaders/runtime/JSGlobalData.h: Removed.
- ForwardingHeaders/runtime/VM.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSGlobalData.h.
- WebCore.exp.in:
- WebCore.order:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- bindings/js/DOMObjectHashTableMap.cpp:
(WebCore::DOMObjectHashTableMap::mapFor):
- bindings/js/DOMObjectHashTableMap.h:
(JSC):
(DOMObjectHashTableMap):
- bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::normalWorld):
(WebCore::mainThreadNormalWorld):
- bindings/js/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::create):
(WebCore::DOMWrapperWorld::vm):
(DOMWrapperWorld):
(WebCore):
- bindings/js/GCController.cpp:
(WebCore::collect):
(WebCore::GCController::garbageCollectSoon):
(WebCore::GCController::garbageCollectNow):
(WebCore::GCController::setJavaScriptGarbageCollectorTimerEnabled):
(WebCore::GCController::discardAllCompiledCode):
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::get):
(WebCore::set):
(WebCore::deserializeIDBValue):
(WebCore::deserializeIDBValueBuffer):
(WebCore::idbKeyToScriptValue):
- bindings/js/JSCallbackData.h:
(WebCore::JSCallbackData::JSCallbackData):
- bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSSQLStatementErrorCallback::handleEvent):
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::JSCustomXPathNSResolver):
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSDOMBinding.cpp:
(WebCore::getHashTableForGlobalData):
(WebCore::reportException):
(WebCore::cacheDOMStructure):
- bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::createStructure):
(WebCore::DOMConstructorWithDocument::finishCreation):
(WebCore::getDOMStructure):
(WebCore::setInlineCachedWrapper):
(WebCore):
(WebCore::jsStringWithCache):
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
(WebCore::JSDOMGlobalObject::finishCreation):
- bindings/js/JSDOMGlobalObject.h:
(JSDOMGlobalObject):
(WebCore::JSDOMGlobalObject::createStructure):
(WebCore::getDOMConstructor):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::updateDocument):
(WebCore::JSDOMWindowBase::commonVM):
- bindings/js/JSDOMWindowBase.h:
(JSDOMWindowBase):
(WebCore::JSDOMWindowBase::createStructure):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation):
(WebCore::DialogHandler::dialogCreated):
(WebCore::DialogHandler::returnValue):
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::finishCreation):
(WebCore::JSDOMWindowShell::setWindow):
- bindings/js/JSDOMWindowShell.h:
(JSDOMWindowShell):
(WebCore::JSDOMWindowShell::create):
(WebCore::JSDOMWindowShell::createStructure):
- bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::JSDOMWrapper):
- bindings/js/JSDeviceMotionEventCustom.cpp:
(WebCore::createAccelerationObject):
(WebCore::createRotationRateObject):
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
- bindings/js/JSDictionary.h:
(WebCore::JSDictionary::JSDictionary):
- bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::setWrapper):
(WebCore::JSEventListener::jsFunction):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::all):
(WebCore::JSHTMLDocument::setAll):
- bindings/js/JSHTMLTemplateElementCustom.cpp:
(WebCore::JSHTMLTemplateElement::content):
- bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::state):
- bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::finishCreation):
- bindings/js/JSImageConstructor.h:
(WebCore::JSImageConstructor::createStructure):
- bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::nodeAsScriptValue):
(WebCore::JSInjectedScriptHost::functionDetails):
(WebCore::getJSListenerFunctions):
(WebCore::JSInjectedScriptHost::getEventListeners):
(WebCore::JSInjectedScriptHost::inspect):
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data):
(WebCore::handleInitMessageEvent):
- bindings/js/JSMutationCallback.cpp:
(WebCore::JSMutationCallback::call):
- bindings/js/JSMutationObserverCustom.cpp:
(WebCore::JSMutationObserverConstructor::constructJSMutationObserver):
- bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
- bindings/js/JSNodeFilterCondition.h:
(WebCore::JSNodeFilterCondition::create):
(JSNodeFilterCondition):
- bindings/js/JSNodeFilterCustom.cpp:
(WebCore::toNodeFilter):
- bindings/js/JSPopStateEventCustom.cpp:
(WebCore::cacheState):
- bindings/js/JSRequestAnimationFrameCallbackCustom.cpp:
(WebCore::JSRequestAnimationFrameCallback::handleEvent):
- bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
- bindings/js/JSWorkerContextBase.cpp:
(WebCore::JSWorkerContextBase::JSWorkerContextBase):
(WebCore::JSWorkerContextBase::finishCreation):
- bindings/js/JSWorkerContextBase.h:
(WebCore::JSWorkerContextBase::createStructure):
(JSWorkerContextBase):
- bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::recompileAllJSFunctions):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::executeFunctionInContext):
- bindings/js/ScheduledAction.h:
(WebCore::ScheduledAction::ScheduledAction):
- bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
(WebCore::ScriptCachedFrameData::clear):
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
(WebCore::createScriptArguments):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createWindowShell):
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::createWorld):
(WebCore::ScriptController::getAllWorlds):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::cacheableBindingRootObject):
(WebCore::ScriptController::bindingRootObject):
(WebCore::ScriptController::clearScriptObjects):
(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
- bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::windowScriptObject):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidPause):
- bindings/js/ScriptEventListener.cpp:
(WebCore::eventListenerHandlerBody):
(WebCore::eventListenerHandler):
(WebCore::eventListenerHandlerLocation):
- bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptCallback::call):
- bindings/js/ScriptGCEvent.cpp:
(WebCore::ScriptGCEvent::getHeapSize):
- bindings/js/ScriptObject.cpp:
(WebCore::ScriptObject::ScriptObject):
(WebCore::ScriptGlobalObject::set):
- bindings/js/ScriptState.h:
(WebCore):
- bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::deserialize):
- bindings/js/ScriptValue.h:
(WebCore::ScriptValue::ScriptValue):
- bindings/js/ScriptWrappable.h:
(JSC):
(ScriptWrappable):
- bindings/js/ScriptWrappableInlines.h:
(WebCore::ScriptWrappable::setWrapper):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readTerminal):
(WebCore::SerializedScriptValue::deserializeForInspector):
(WebCore::SerializedScriptValue::maybeThrowExceptionIfSerializationFailed):
- bindings/js/WebCoreJSClientData.h:
(WebCoreJSClientData):
(WebCore::initNormalWorldClientData):
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::~WorkerScriptController):
(WebCore::WorkerScriptController::initScript):
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::scheduleExecutionTermination):
(WebCore::WorkerScriptController::isExecutionTerminating):
(WebCore::WorkerScriptController::disableEval):
- bindings/js/WorkerScriptController.h:
(JSC):
(WebCore::WorkerScriptController::vm):
(WorkerScriptController):
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
- bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackImplementation):
(JSValueToNative):
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):
- bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::getJSFloat64ArrayConstructorTable):
(WebCore::JSFloat64ArrayConstructor::finishCreation):
(WebCore::getJSFloat64ArrayPrototypeTable):
(WebCore::getJSFloat64ArrayTable):
(WebCore::JSFloat64Array::finishCreation):
(WebCore::JSFloat64Array::createPrototype):
- bindings/scripts/test/JS/JSFloat64Array.h:
(WebCore::JSFloat64Array::create):
(WebCore::JSFloat64Array::createStructure):
(JSFloat64Array):
(WebCore::JSFloat64ArrayPrototype::create):
(WebCore::JSFloat64ArrayPrototype::createStructure):
(WebCore::JSFloat64ArrayPrototype::JSFloat64ArrayPrototype):
(WebCore::JSFloat64ArrayConstructor::createStructure):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):
(WebCore::JSTestActiveDOMObject::finishCreation):
(WebCore::JSTestActiveDOMObject::createPrototype):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(WebCore::JSTestActiveDOMObject::create):
(WebCore::JSTestActiveDOMObject::createStructure):
(JSTestActiveDOMObject):
(WebCore::JSTestActiveDOMObjectPrototype::create):
(WebCore::JSTestActiveDOMObjectPrototype::createStructure):
(WebCore::JSTestActiveDOMObjectPrototype::JSTestActiveDOMObjectPrototype):
(WebCore::JSTestActiveDOMObjectConstructor::createStructure):
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::callbackWithNoParam):
(WebCore::JSTestCallback::callbackWithClass1Param):
(WebCore::JSTestCallback::callbackWithClass2Param):
(WebCore::JSTestCallback::callbackWithStringList):
(WebCore::JSTestCallback::callbackWithBoolean):
(WebCore::JSTestCallback::callbackRequiresThisToPass):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
(WebCore::JSTestCustomNamedGetter::finishCreation):
(WebCore::JSTestCustomNamedGetter::createPrototype):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(WebCore::JSTestCustomNamedGetter::create):
(WebCore::JSTestCustomNamedGetter::createStructure):
(JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetterPrototype::create):
(WebCore::JSTestCustomNamedGetterPrototype::createStructure):
(WebCore::JSTestCustomNamedGetterPrototype::JSTestCustomNamedGetterPrototype):
(WebCore::JSTestCustomNamedGetterConstructor::createStructure):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::finishCreation):
(WebCore::JSTestEventConstructor::finishCreation):
(WebCore::JSTestEventConstructor::createPrototype):
- bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::JSTestEventConstructor::create):
(WebCore::JSTestEventConstructor::createStructure):
(JSTestEventConstructor):
(WebCore::JSTestEventConstructorPrototype::create):
(WebCore::JSTestEventConstructorPrototype::createStructure):
(WebCore::JSTestEventConstructorPrototype::JSTestEventConstructorPrototype):
(WebCore::JSTestEventConstructorConstructor::createStructure):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::finishCreation):
(WebCore::JSTestEventTarget::finishCreation):
(WebCore::JSTestEventTarget::createPrototype):
- bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::JSTestEventTarget::create):
(WebCore::JSTestEventTarget::createStructure):
(JSTestEventTarget):
(WebCore::JSTestEventTargetPrototype::create):
(WebCore::JSTestEventTargetPrototype::createStructure):
(WebCore::JSTestEventTargetPrototype::JSTestEventTargetPrototype):
(WebCore::JSTestEventTargetConstructor::createStructure):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionConstructor::finishCreation):
(WebCore::JSTestException::finishCreation):
(WebCore::JSTestException::createPrototype):
- bindings/scripts/test/JS/JSTestException.h:
(WebCore::JSTestException::create):
(WebCore::JSTestException::createStructure):
(JSTestException):
(WebCore::JSTestExceptionPrototype::create):
(WebCore::JSTestExceptionPrototype::createStructure):
(WebCore::JSTestExceptionPrototype::JSTestExceptionPrototype):
(WebCore::JSTestExceptionConstructor::createStructure):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::finishCreation):
(WebCore::JSTestInterface::finishCreation):
(WebCore::JSTestInterface::createPrototype):
- bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::JSTestInterface::create):
(WebCore::JSTestInterface::createStructure):
(JSTestInterface):
(WebCore::JSTestInterfacePrototype::create):
(WebCore::JSTestInterfacePrototype::createStructure):
(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):
(WebCore::JSTestInterfaceConstructor::createStructure):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
(WebCore::JSTestMediaQueryListListener::finishCreation):
(WebCore::JSTestMediaQueryListListener::createPrototype):
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListener::create):
(WebCore::JSTestMediaQueryListListener::createStructure):
(JSTestMediaQueryListListener):
(WebCore::JSTestMediaQueryListListenerPrototype::create):
(WebCore::JSTestMediaQueryListListenerPrototype::createStructure):
(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):
(WebCore::JSTestMediaQueryListListenerConstructor::createStructure):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):
(WebCore::JSTestNamedConstructor::finishCreation):
(WebCore::JSTestNamedConstructor::createPrototype):
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
(WebCore::JSTestNamedConstructor::create):
(WebCore::JSTestNamedConstructor::createStructure):
(JSTestNamedConstructor):
(WebCore::JSTestNamedConstructorPrototype::create):
(WebCore::JSTestNamedConstructorPrototype::createStructure):
(WebCore::JSTestNamedConstructorPrototype::JSTestNamedConstructorPrototype):
(WebCore::JSTestNamedConstructorConstructor::createStructure):
(WebCore::JSTestNamedConstructorNamedConstructor::createStructure):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::finishCreation):
(WebCore::JSTestNode::finishCreation):
(WebCore::JSTestNode::createPrototype):
- bindings/scripts/test/JS/JSTestNode.h:
(WebCore::JSTestNode::create):
(WebCore::JSTestNode::createStructure):
(JSTestNode):
(WebCore::JSTestNodePrototype::create):
(WebCore::JSTestNodePrototype::createStructure):
(WebCore::JSTestNodePrototype::JSTestNodePrototype):
(WebCore::JSTestNodeConstructor::createStructure):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::finishCreation):
(WebCore::JSTestObj::finishCreation):
(WebCore::JSTestObj::createPrototype):
(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjAnyAttribute):
(WebCore::setJSTestObjReplaceableAttribute):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::create):
(WebCore::JSTestObj::createStructure):
(JSTestObj):
(WebCore::JSTestObjPrototype::create):
(WebCore::JSTestObjPrototype::createStructure):
(WebCore::JSTestObjPrototype::JSTestObjPrototype):
(WebCore::JSTestObjConstructor::createStructure):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):
(WebCore::JSTestOverloadedConstructors::finishCreation):
(WebCore::JSTestOverloadedConstructors::createPrototype):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(WebCore::JSTestOverloadedConstructors::create):
(WebCore::JSTestOverloadedConstructors::createStructure):
(JSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructorsPrototype::create):
(WebCore::JSTestOverloadedConstructorsPrototype::createStructure):
(WebCore::JSTestOverloadedConstructorsPrototype::JSTestOverloadedConstructorsPrototype):
(WebCore::JSTestOverloadedConstructorsConstructor::createStructure):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
(WebCore::JSTestSerializedScriptValueInterface::finishCreation):
(WebCore::JSTestSerializedScriptValueInterface::createPrototype):
(WebCore::jsTestSerializedScriptValueInterfaceCachedValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedReadonlyValue):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterface::create):
(WebCore::JSTestSerializedScriptValueInterface::createStructure):
(JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::create):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::createStructure):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::finishCreation):
(WebCore::JSTestTypedefs::finishCreation):
(WebCore::JSTestTypedefs::createPrototype):
- bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore::JSTestTypedefs::create):
(WebCore::JSTestTypedefs::createStructure):
(JSTestTypedefs):
(WebCore::JSTestTypedefsPrototype::create):
(WebCore::JSTestTypedefsPrototype::createStructure):
(WebCore::JSTestTypedefsPrototype::JSTestTypedefsPrototype):
(WebCore::JSTestTypedefsConstructor::createStructure):
- bridge/c/CRuntimeObject.h:
(JSC::Bindings::CRuntimeObject::createStructure):
- bridge/c/c_instance.cpp:
(JSC::Bindings::CRuntimeMethod::create):
(JSC::Bindings::CRuntimeMethod::createStructure):
(JSC::Bindings::CRuntimeMethod::finishCreation):
- bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::createRuntimeObject):
- bridge/objc/ObjCRuntimeObject.h:
(JSC::Bindings::ObjCRuntimeObject::createStructure):
- bridge/objc/objc_instance.mm:
(ObjCRuntimeMethod::create):
(ObjCRuntimeMethod::createStructure):
(ObjCRuntimeMethod::finishCreation):
- bridge/objc/objc_runtime.h:
(JSC::Bindings::ObjcFallbackObjectImp::createStructure):
- bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
(JSC::Bindings::ObjcFallbackObjectImp::finishCreation):
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObject::createStructure):
(JSC::Bindings::QtInstance::~QtInstance):
(JSC::Bindings::QtInstance::getQtInstance):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::RuntimeArray):
(JSC::RuntimeArray::finishCreation):
- bridge/runtime_array.h:
(JSC::RuntimeArray::create):
(JSC::RuntimeArray::createStructure):
(RuntimeArray):
- bridge/runtime_method.cpp:
(JSC::RuntimeMethod::finishCreation):
- bridge/runtime_method.h:
(JSC::RuntimeMethod::create):
(JSC::RuntimeMethod::createStructure):
(RuntimeMethod):
- bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::RuntimeObject):
(JSC::Bindings::RuntimeObject::finishCreation):
- bridge/runtime_object.h:
(JSC::Bindings::RuntimeObject::createStructure):
- bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::RootObject):
(JSC::Bindings::RootObject::gcProtect):
(JSC::Bindings::RootObject::gcUnprotect):
(JSC::Bindings::RootObject::updateGlobalObject):
(JSC::Bindings::RootObject::addRuntimeObject):
- bridge/runtime_root.h:
(RootObject):
- dom/Node.cpp:
- dom/Node.h:
(JSC):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::vm):
- dom/ScriptExecutionContext.h:
(JSC):
(ScriptExecutionContext):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
- html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::notifyFinished):
- inspector/ScriptArguments.cpp:
(WebCore::ScriptArguments::ScriptArguments):
- loader/icon/IconDatabaseBase.cpp:
(WebCore):
(WebCore::iconDatabase):
(WebCore::setGlobalIconDatabase):
- platform/qt/MemoryUsageSupportQt.cpp:
(WebCore::memoryUsageKB):
(WebCore::actualMemoryUsageKB):
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::createGlobalData):
- plugins/PluginView.cpp:
(WebCore::PluginView::start):
(WebCore::PluginView::stop):
(WebCore::PluginView::performRequest):
(WebCore::PluginView::npObject):
(WebCore::PluginView::privateBrowsingStateChanged):
- plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::getWindowInfo):
- plugins/efl/PluginViewEfl.cpp:
(WebCore::PluginView::dispatchNPEvent):
- plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformStart):
- plugins/mac/PluginViewMac.mm:
(WebCore::PluginView::platformStart):
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::setNPWindowIfNeeded):
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowRect):
- testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::injectInternalsObject):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::dropProtection):
../WebKit/blackberry:
- Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::clearMemoryCaches):
- WebKitSupport/AboutData.cpp:
- WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::javaScriptObjectsCount):
../WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::javaScriptObjectsCount):
../WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::gcCountJavascriptObjects):
../WebKit/mac:
- Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics javaScriptObjectsCount]):
(+[WebCoreStatistics javaScriptGlobalObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
(+[WebCoreStatistics javaScriptObjectTypeCounts]):
(+[WebCoreStatistics shouldPrintExceptions]):
(+[WebCoreStatistics setShouldPrintExceptions:]):
(+[WebCoreStatistics memoryStatistics]):
(+[WebCoreStatistics javaScriptReferencedObjectsCount]):
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(identifierFromIdentifierRep):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
(LocalObjectMap):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
(WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
(WebKit::NetscapePluginInstanceProxy::evaluate):
(WebKit::NetscapePluginInstanceProxy::addValueToArray):
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyRuntimeMethod::create):
(WebKit::ProxyRuntimeMethod::createStructure):
(WebKit::ProxyRuntimeMethod::finishCreation):
(WebKit::ProxyInstance::getPropertyNames):
- Plugins/Hosted/ProxyRuntimeObject.h:
(WebKit::ProxyRuntimeObject::create):
(WebKit::ProxyRuntimeObject::createStructure):
- Plugins/WebNetscapePluginStream.mm:
(WebNetscapePluginStream::wantsAllStreams):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView sendEvent:isDrawRect:]):
(-[WebNetscapePluginView privateBrowsingModeDidChange]):
(-[WebNetscapePluginView setWindowIfNecessary]):
(-[WebNetscapePluginView createPluginScriptableObject]):
(-[WebNetscapePluginView getFormValue:]):
(-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
(-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
(-[WebNetscapePluginView loadPluginRequest:]):
(-[WebNetscapePluginView _printedPluginBitmap]):
- Plugins/WebPluginController.mm:
(+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
(-[WebPluginController stopOnePlugin:]):
(-[WebPluginController destroyOnePlugin:]):
(-[WebPluginController startAllPlugins]):
(-[WebPluginController addPlugin:]):
- WebKit.order:
- WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame scopeChain]):
(-[WebScriptCallFrame evaluateWebScript:]):
- WebView/WebScriptDebugger.mm:
(WebScriptDebugger::WebScriptDebugger):
../WebKit/qt:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::javaScriptObjectsCount):
- WebCoreSupport/QWebFrameAdapter.cpp:
(QWebFrameAdapter::addToJavaScriptWindowObject):
../WebKit/win:
- WebCoreStatistics.cpp:
(WebCoreStatistics::javaScriptObjectsCount):
(WebCoreStatistics::javaScriptGlobalObjectsCount):
(WebCoreStatistics::javaScriptProtectedObjectsCount):
(WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
- WebJavaScriptCollector.cpp:
(WebJavaScriptCollector::objectCount):
../WebKit2:
- Shared/linux/WebMemorySamplerLinux.cpp:
(WebKit::WebMemorySampler::sampleWebKit):
- Shared/mac/WebMemorySampler.mac.mm:
(WebKit::WebMemorySampler::sampleWebKit):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::javaScriptObjectsCount):
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
(WebKit::JSNPMethod::finishCreation):
- WebProcess/Plugins/Netscape/JSNPMethod.h:
(WebKit::JSNPMethod::create):
(JSNPMethod):
(WebKit::JSNPMethod::createStructure):
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::finishCreation):
(WebKit::JSNPObject::callMethod):
(WebKit::JSNPObject::callObject):
(WebKit::JSNPObject::callConstructor):
(WebKit::JSNPObject::put):
(WebKit::JSNPObject::deleteProperty):
(WebKit::JSNPObject::getOwnPropertyNames):
(WebKit::JSNPObject::propertyGetter):
- WebProcess/Plugins/Netscape/JSNPObject.h:
(WebKit::JSNPObject::create):
(WebKit::JSNPObject::createStructure):
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::create):
(WebKit::NPJSObject::initialize):
- WebProcess/Plugins/Netscape/NPJSObject.h:
(JSC):
(NPJSObject):
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::getOrCreateNPObject):
(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
(WebKit::NPRuntimeObjectMap::evaluate):
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
(JSC):
(NPRuntimeObjectMap):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::windowScriptNPObject):
(WebKit::PluginView::pluginElementNPObject):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::getWebCoreStatistics):
- 12:26 PM Changeset in webkit [148695] by
-
- 5 edits in trunk/Source/WebKit2
Differentiate between creating local storage maps and session storage maps
https://bugs.webkit.org/show_bug.cgi?id=114823
Reviewed by Beth Dakin.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createLocalStorageMap):
(WebKit::StorageManager::createSessionStorageMap):
- UIProcess/Storage/StorageManager.h:
- UIProcess/Storage/StorageManager.messages.in:
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::StorageAreaMap):
- 12:18 PM Changeset in webkit [148694] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
Fix skip format on svg/custom/use-href-update-crash.svg
https://bugs.webkit.org/show_bug.cgi?id=104054
<rdar://problem/13680081>
Patch by David Farler <dfarler@apple.com> on 2013-04-18
- platform/mac/Skipped:
Remove [ Failure Pass ] for svg/custom/use-href-update-crash.svg
- 11:39 AM Changeset in webkit [148693] by
-
- 3 edits in trunk/LayoutTests
More cleaning up of skipped WK2 tests.
- platform/mac-wk2/TestExpectations:
- platform/wk2/TestExpectations:
- 11:34 AM Changeset in webkit [148692] by
-
- 3 edits in trunk/Source/WebKit2
StorageAreaMaps should not assume that a zero storage namespace ID is used for local storage
https://bugs.webkit.org/show_bug.cgi?id=114822
Reviewed by Beth Dakin.
Store the storage type directly in the storage area map.
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::StorageAreaMap):
- WebProcess/Storage/StorageAreaMap.h:
(WebKit::StorageAreaMap::storageType):
- 11:18 AM Changeset in webkit [148691] by
-
- 4 edits in trunk/Source/WebKit2
Begin fleshing out UI side local storage
https://bugs.webkit.org/show_bug.cgi?id=114820
Reviewed by Beth Dakin.
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::createLocalStorageNamespace):
(WebKit::StorageNamespaceImpl::createSessionStorageNamespace):
(WebKit::StorageNamespaceImpl::StorageNamespaceImpl):
(WebKit::StorageNamespaceImpl::~StorageNamespaceImpl):
- WebProcess/Storage/StorageNamespaceImpl.h:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::localStorageNamespace):
- 11:14 AM Changeset in webkit [148690] by
-
- 15 edits in trunk/Source/WebCore
Fix windows build by moving template definition to JSDOMBinding.h
- 11:08 AM Changeset in webkit [148689] by
-
- 2 edits in trunk/Source/WebKit2
Fix spelling I thought I had fixed.
- UIProcess/API/mac/WKBrowsingContextGroup.mm:
(-[WKBrowsingContextGroup initWithIdentifier:]):
- 11:03 AM Changeset in webkit [148688] by
-
- 5 edits in trunk
Forced subtitles never rendered
https://bugs.webkit.org/show_bug.cgi?id=114818
Source/WebCore:
Reviewed by Jer Noble.
No new tests, media/track/track-forced-subtitles-in-band.html was updated to test this change.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::isRendered): "forced" tracks are rendered.
LayoutTests:
Update test to check that a forced cue is rendered.
Reviewed by Jer Noble.
- media/track/track-forced-subtitles-in-band-expected.txt:
- media/track/track-forced-subtitles-in-band.html:
- 11:03 AM Changeset in webkit [148687] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
svg/custom/use-href-update-crash.svg is skipped on trunk
https://bugs.webkit.org/show_bug.cgi?id=104054
<rdar://problem/13680081>
Patch by David Farler <dfarler@apple.com> on 2013-04-18
- platform/mac/Skipped:
Skip svg/custom/use-href-update-crash.svg
- 11:00 AM Changeset in webkit [148686] by
-
- 2 edits in trunk/Source/WebKit2
WebKit should not write WKPreferences to app user defaults when using the ObjC API
<rdar://problem/13593578>
https://bugs.webkit.org/show_bug.cgi?id=114821
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKBrowsingContextGroup.mm:
(-[WKBrowsingContextGroup initWithIdentifier:]):
Use a identifier-less preferences for the ObjC-API. I think we will probably want this
to be the default for the C-API at some point as well, but Safari currently uses this
behavior.
- 10:55 AM Changeset in webkit [148685] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Should pass through an actual error code when calling notifyLoadFinished
https://bugs.webkit.org/show_bug.cgi?id=114815
Patch by Ed Baker <edbaker@blackberry.com> on 2013-04-18
Reviewed by Rob Buis.
PR #318079
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::postProgressFinishedNotification):
- 10:50 AM Changeset in webkit [148684] by
-
- 2 edits in trunk/Source/WTF
Speculative build fix for Qt Mountain Lion Release after r148639.
https://bugs.webkit.org/show_bug.cgi?id=114793
Reviewed by Michael Saboff.
- wtf/CurrentTime.cpp:
- 10:14 AM Changeset in webkit [148683] by
-
- 13 edits in trunk/Source
Change storage factory functions to take a PageGroup and Page respectively
https://bugs.webkit.org/show_bug.cgi?id=114776
Reviewed by Beth Dakin.
Source/WebCore:
Change StorageNamespace::localStorageNamespace to take a PageGroup since WebKit2 needs
to know which local storage namespace belongs to which page group. Also remove the quota parameter from
the sessionStorageNamespace function since that's trivial to get from the Page.
- WebCore.exp.in:
- page/Page.cpp:
(WebCore::Page::sessionStorage):
- page/PageGroup.cpp:
(WebCore::PageGroup::localStorage):
- storage/StorageNamespace.cpp:
(WebCore::StorageNamespace::localStorageNamespace):
(WebCore::StorageNamespace::sessionStorageNamespace):
- storage/StorageNamespace.h:
- storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::localStorageNamespace):
(WebCore::StorageNamespaceImpl::sessionStorageNamespace):
- storage/StorageNamespaceImpl.h:
- storage/StorageStrategy.cpp:
(WebCore::StorageStrategy::localStorageNamespace):
(WebCore::StorageStrategy::sessionStorageNamespace):
- storage/StorageStrategy.h:
Source/WebKit2:
Update for WebCore changes.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::localStorageNamespace):
(WebKit::WebPlatformStrategies::sessionStorageNamespace):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
- 9:34 AM Changeset in webkit [148682] by
-
- 2 edits in trunk/Source/WebKit2
Remove an ASSERT that is causing flakeyness in Debug builds.
Reviewed by Jessie Berlin.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::open): Removed ASSERT(m_createdInspectorPage).
- 9:20 AM Changeset in webkit [148681] by
-
- 4 edits in trunk
[GTK] fast/canvas/DrawImageSinglePixelStretch.html fails
https://bugs.webkit.org/show_bug.cgi?id=58309
Reviewed by Alejandro G. Castro.
Source/WebCore:
No new tests. This patch unskips a test.
Prevent sampling outside source boundaries, by creating subsurfaces from source surfaces.
This also requires careful handling of negative and floating source rectangles.
- platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::drawSurfaceToContext): Use a subsurface to prevent sampling
outside rectangle boundaries.
LayoutTests:
- platform/gtk/TestExpectations: Unskip a test which is now passing.
- 9:14 AM Changeset in webkit [148680] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Improper initialization of ANGLEResources (resubmission)
https://bugs.webkit.org/show_bug.cgi?id=114814
Patch by Jonathan Feldstein <jfeldstein@blackberry.com> on 2013-04-18
Reviewed by Yong Li, Rob Buis
Internally reviewed by Maxim Mogilnitsky
MaxDrawBuffers, OES_standard_derivatives, OES_EGL_image_external and ARB_texture_rectangle
are initialized through the ShBuiltInResources function so these fields do not need to be
set again in GraphicsContext3DBlackBerry.cpp. In addition, the extension flags should not
be set to true without getExtension being called (Khronos WebGL specs, section 5.14.14.).
In fact, as a direct result of these extensions being enabled prior to calling
getExtension, a WebGL conformance suite test for GL_OES_standard_derivatives was failing.
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- 9:12 AM Changeset in webkit [148679] by
-
- 21 edits1 move in trunk/Source/WebKit2
[GTK] Add WebKitWebPage::send-request signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=83681
Reviewed by Anders Carlsson.
Add WebKitWebPage::send-request signal emitted in willSendRequest
callback to allow web process extensions to modify requests before
they are sent or cancel the resource load.
This patch makes WebKitURIRequest and WebKitURIResponse objects
shareable between UI process and web extensions APIs. Since both
APIs force single header includes, the WebKitDefines.h header has
been split moving the forward declarations specific to the UI
process API to a new file WebKitForwardDeclarations.h. This way we
can also share the WebKitDefines.h header and remove the
WebKitWebExtensionDefines.h header used in the web extensions API.
- GNUmakefile.list.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitContextMenu.h: Include WebKitForward.h.
- UIProcess/API/gtk/WebKitContextMenuItem.h: Ditto.
- UIProcess/API/gtk/WebKitDefines.h: Remove forward declarations.
- UIProcess/API/gtk/WebKitDownload.h: Include WebKitForward.h.
- UIProcess/API/gtk/WebKitFindController.h: Ditto.
- UIProcess/API/gtk/WebKitForwardDeclarations.h: Added. Contains
the forward declarations moved from WebKitDefines.h.
- UIProcess/API/gtk/WebKitPrintOperation.h: Include WebKitForward.h.
- UIProcess/API/gtk/WebKitURIRequest.cpp:
(webkitURIRequestSetProperty): Use webkit_uri_request_set_uri() to
set the new URI.
(webkit_uri_request_class_init): Make URI property construct
instead of construct-only, since it can be updated once
constructed. It should never be NULL, so set default value to
about:blank instad of NULL.
(webkit_uri_request_set_uri): New public method to set the URI of
the WebKitURIRequest.
- UIProcess/API/gtk/WebKitURIRequest.h: Allow to include this file
from webkit-web-extension.h.
- UIProcess/API/gtk/WebKitURIResponse.h: Ditto.
- UIProcess/API/gtk/WebKitURISchemeRequest.h: Include
WebKitForward.h.
- UIProcess/API/gtk/WebKitWebView.h: Ditto.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add
webkit_uri_request_set_uri.
- UIProcess/API/gtk/tests/TestResources.cpp:
(testWebResourceSendRequest):
(serverCallback):
(beforeAll):
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(sendRequestCallback):
(pageCreatedCallback):
- UIProcess/API/gtk/webkit2marshal.list:
- WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.h: Include
WebKitDefines.h instead of WebKitWebExtensionDefines.h.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(willSendRequestForFrame): Emit WebKitWebPage::send-request and
return early if the load is cancelled.
(webkit_web_page_class_init): Add WebKitWebPage::send-request
signal.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h: Include
WebKitDefines.h instead of WebKitWebExtensionDefines.h.
- WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:
- 8:01 AM Changeset in webkit [148678] by
-
- 10 edits in trunk/Source
remove build warning(unused parameter)
https://bugs.webkit.org/show_bug.cgi?id=114670
Patch by Xuefei Ren <xren@blackberry.com> on 2013-04-18
Reviewed by Rob Buis.
Source/JavaScriptCore:
remove warning in Source/JavaScriptCore/runtime/GCActivityCallbackBlackBerry.cpp
- runtime/GCActivityCallbackBlackBerry.cpp:
(JSC::DefaultGCActivityCallback::didAllocate):
Source/WebCore:
remove warning(unused parameter) in
Source/WebCore/html/shadow/MediaControlsBlackBerry.cpp
Source/WebCore/loader/blackberry/CookieJarBlackBerry.cpp
Source/WebCore/platform/blackberry/AuthenticationChallengeManager.cpp
Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp
Source/WebCore/platform/network/blackberry/ResourceResponseBlackBerry.cpp
Source/WebCore/platform/network/blackberry/SocketStreamHandleBlackBerry.cpp
Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp
- html/shadow/MediaControlsBlackBerry.cpp:
(WebCore::MediaControlFullscreenFullscreenButtonElement::setIsFullscreen):
- loader/blackberry/CookieJarBlackBerry.cpp:
(WebCore::getRawCookies):
(WebCore::deleteCookie):
- platform/blackberry/AuthenticationChallengeManager.cpp:
(WebCore::AuthenticationChallengeManager::notifyChallengeResult):
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderTheme::themeForPage):
- platform/network/blackberry/ResourceResponseBlackBerry.cpp:
(WebCore::ResourceResponse::doPlatformAdopt):
- platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
(WebCore::SocketStreamHandle::notifyStatusReceived):
- plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::invalidateRegion):
- 7:55 AM Changeset in webkit [148677] by
-
- 11 edits in trunk
remove build warning(unused parameter)
https://bugs.webkit.org/show_bug.cgi?id=114670
Patch by Xuefei Ren <xren@blackberry.com> on 2013-04-18
Reviewed by Rob Buis.
Source/WebCore:
remove builde warning (unused parameter) in
Source/WebCore/platform/blackberry/CursorBlackBerry.cpp
- platform/blackberry/CursorBlackBerry.cpp:
(WebCore::Cursor::Cursor):
Source/WebKit/blackberry:
remove builde warning (unused parameter) in
Source/WebKit/blackberry
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::spannableTextInRange):
- WebKitSupport/RenderQueue.cpp:
(BlackBerry::WebKit::RenderQueue::backingStoreRectChanging):
(BlackBerry::WebKit::RenderQueue::scrollZoomJobsCompleted):
- WebKitSupport/SurfacePool.cpp:
(BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):
(BlackBerry::WebKit::SurfacePool::waitForBuffer):
(BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
(BlackBerry::WebKit::SurfacePool::destroyPlatformSync):
Tools:
remove builde warning (unused parameter) in
Tools/DumpRenderTree/blackberry
- DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):
(BlackBerry::WebKit::DumpRenderTree::didReceiveResponseForFrame):
- DumpRenderTree/blackberry/EventSender.cpp:
(getDragModeCallback):
(setDragModeCallback):
(mouseWheelToCallback):
(contextClickCallback):
(mouseDownCallback):
(mouseUpCallback):
(mouseMoveToCallback):
(beginDragWithFilesCallback):
(leapForwardCallback):
(keyDownCallback):
(textZoomInCallback):
(textZoomOutCallback):
(zoomPageInCallback):
(zoomPageOutCallback):
(addTouchPointCallback):
(updateTouchPointCallback):
(setTouchModifierCallback):
(touchStartCallback):
(touchCancelCallback):
(touchMoveCallback):
(touchEndCallback):
(clearTouchPointsCallback):
(cancelTouchPointCallback):
(releaseTouchPointCallback):
(scalePageByCallback):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::authenticateSession):
(TestRunner::setSpatialNavigationEnabled):
(TestRunner::apiTestNewWindowDataLoadBaseURL):
(TestRunner::setPluginsEnabled):
(TestRunner::setApplicationCacheOriginQuota):
(TestRunner::addMockSpeechInputResult):
(TestRunner::setViewModeMediaFeature):
(TestRunner::deleteLocalStorageForOrigin):
(TestRunner::applicationCacheDiskUsageForOrigin):
(TestRunner::grantWebNotificationPermission):
(TestRunner::denyWebNotificationPermission):
(TestRunner::simulateWebNotificationClick):
(TestRunner::simulateLegacyWebNotificationClick):
- 7:30 AM Changeset in webkit [148676] by
-
- 6 edits in trunk/Source/WebKit/blackberry
remove build warning(unused parameter)
https://bugs.webkit.org/show_bug.cgi?id=114670
Patch by Xuefei Ren <xren@blackberry.com> on 2013-04-18
Reviewed by Rob Buis.
remove build warning in Source/WebKit/blackberry/Api
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::scroll):
(BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
(BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
(BlackBerry::WebKit::BackingStorePrivate::actualVisibleSizeChanged):
- Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::clearAppCache):
(BlackBerry::WebKit::clearDatabase):
- Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToImage):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerVisibilityChanged):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setCaretHighlightStyle):
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositor::cleanup):
- 7:24 AM Changeset in webkit [148675] by
-
- 2 edits in trunk/Source/WebCore
EditingStyle: Avoid some unnecessary CSSStyleDeclaration wrappers.
<http://webkit.org/b/114763>
Reviewed by Antti Koivisto.
removeEquivalentProperties(CSSStyleDeclaration) and removeEquivalentProperties(StylePropertySet)
only have different behavior if the CSSStyleDeclaration is computed style (they differ in handling
of the 'font-size' property.)
Avoid creating a CSSStyleDeclaration for StylePropertySets where we can just pass them in directly.
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
- 7:08 AM Changeset in webkit [148674] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] CoordinatedGraphicsLayerState is a struct, not a class
https://bugs.webkit.org/show_bug.cgi?id=108855
Reviewed by Andreas Kling.
Fixes the forward declaration which takes CoordinatedGraphicsLayerState
as a class.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(WebCore):
- 6:54 AM Changeset in webkit [148673] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: media/track/track-mode.html
https://bugs.webkit.org/show_bug.cgi?id=114361
Unreviewed, fix a flaky test.
- media/track/track-mode.html:
- 6:37 AM Changeset in webkit [148672] by
-
- 4 edits2 adds in trunk
Unset :hover in inner documents
https://bugs.webkit.org/show_bug.cgi?id=114446
Reviewed by Antonio Gomes.
Source/WebCore:
Fixes a regression from r145126 where hover nodes in inner documents was sometimes
not unset. Additionally it uses the new api from r145126 to avoid an unnecessary
hit test in touch-event handling.
Test: fast/events/touch/frame-hover-update.html
- dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
- page/EventHandler.cpp:
(WebCore::shouldGesturesTriggerActive):
(WebCore::EventHandler::handleTouchEvent):
LayoutTests:
Test expected effect of touch events on hover state.
- fast/events/touch/frame-hover-update-expected.txt: Added.
- fast/events/touch/frame-hover-update.html: Added.
- 6:08 AM Changeset in webkit [148671] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Change inadequate return value in method setDone().
https://bugs.webkit.org/show_bug.cgi?id=114806
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-04-18
Reviewed by Andreas Kling.
Fix possible warning in EFL port: no return statement in function returning non-void.
Change return value from bool to void in method setDone().
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::CallbackDataTimer::setDone):
- 6:04 AM Changeset in webkit [148670] by
-
- 12 edits2 adds in trunk
[WK2][EFL] Text Checker's settings refactor
https://bugs.webkit.org/show_bug.cgi?id=111713
Reviewed by Andreas Kling.
Source/WebKit2:
Use WK2's TextCheckerState object as the store for the text checker settings.
It's shared between the client (Ewk API part) and WebProcess (read only).
Thanks to it, we don't have to keep any additional structure with
the settings on ewk side.
In the consistency with WKTextChecker C API, move the Ewk's text checker settings APIs
to the ewk_text_checker.h/cpp. They're not connected to Ewk_View/Ewk_Settings object to
keep them in ewk_setting.h/cpp.
Introduce a new class to implement WKTextCheckerClient callbacks to call spelling
methods through WK2 C API.
The main purpose of this change is to detach text checker initialization from ewk_context.
- PlatformEfl.cmake:
Add a new files to the build.
- UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
Detach the text checker initialization from context.
There might be more than default context.
There is one text checker object per application.
- UIProcess/API/efl/ewk_settings.cpp:
- UIProcess/API/efl/ewk_settings.h:
Remove the text checker settings.
- UIProcess/API/efl/ewk_text_checker.cpp:
Add the text checker settings to the ewk_text_checker.h/cpp
(convertLanguagesToEinaList):
Add helper function to convert Vector's values to Eina_List.
(clientCallbacks):
Add the client callback responsible for the continuous spell checking
setting change to the struct.
(ewk_text_checker_continuous_spell_checking_enabled_set):
Do not call the client's callback responsible for the setting
change unless WebKit changes the setting (trough the context
'Check Spelling While Typing' option).
- UIProcess/API/efl/ewk_text_checker.h:
Adjust APIs name to the ewk_text_checker syntax.
Update the documentation according to the changes.
- UIProcess/API/efl/ewk_text_checker_private.h:
(ClientCallbacks):
Move ClientCallbacks structure to TextCheckerClientEfl.
The client callbacks (Ewk API) have to be accessible in WKTextCheckerClient callbacks
to choose what implementation will be used - the client's (if definied) or Enchant impl.
- UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
Update the unit tests according to the APIs change.
Update the test responsible for the notification about the setting change
according to changes in 'ewk_text_checker_continuous_spell_checking_enabled_set'.
- UIProcess/efl/TextCheckerClientEfl.cpp: Added.
Implement WKTextCheckerClient callbacks.
(TextCheckerClientEfl::TextCheckerClientEfl):
(TextCheckerClientEfl::instance):
Allow to get and create TextCheckerClientEfl object.
(TextCheckerClientEfl::isContinuousSpellCheckingEnabled):
Get the setting value based on WK2 C API.
(TextCheckerClientEfl::ensureSpellCheckingLanguage):
Load the default languages if user didn't specify any.
(TextCheckerClientEfl::updateSpellCheckingLanguages):
(TextCheckerClientEfl::languagesUpdateTimerFired):
(TextCheckerClientEfl::availableSpellCheckingLanguages):
(TextCheckerClientEfl::loadedSpellCheckingLanguages):
(TextCheckerClientEfl::availableSpellCheckingLanguages):
(TextCheckerClientEfl::loadedSpellCheckingLanguages):
Provide support for languages.
(TextCheckerClientEfl::spellCheckingSettingChangeTimerFired):
(TextCheckerClientEfl::callContinuousSpellCheckingChangeCallbackAsync):
Notify the client about the setting change.
(TextCheckerClientEfl::isContinuousSpellCheckingEnabledCallback):
(TextCheckerClientEfl::setContinuousSpellCheckingEnabledCallback):
(TextCheckerClientEfl::uniqueSpellDocumentTagCallback):
(TextCheckerClientEfl::closeSpellDocumentWithTagCallback):
(TextCheckerClientEfl::checkSpellingOfStringCallback):
(TextCheckerClientEfl::guessesForWordCallback):
(TextCheckerClientEfl::learnWordCallback):
(TextCheckerClientEfl::ignoreWordCallback):
WKTextCheckerClient callbacks implementation.
- UIProcess/efl/TextCheckerClientEfl.h: Added.
(TextCheckerClientEfl):
(TextCheckerClientEfl::clientCallbacks):
Return the client callbacks to be used in ewk_text_checker.cpp.
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::TextChecker::state):
Initialize the TextCheckerState's members to false.
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
Set the default language if user didn't specify any.
Notify the client about the setting change.
This method is called when context menu 'Check Spelling While Typing'
option has been toggled.
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
Set the default language if user didn't specify any.
Called by WKTextChecker's API.
Tools:
- MiniBrowser/efl/main.c:
(window_create):
Use a new text checker API to enable spell checking.
- 5:56 AM Changeset in webkit [148669] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
Add checking whether the compiler allows to use #pragma directive.
https://bugs.webkit.org/show_bug.cgi?id=114740
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-04-18
Reviewed by Andreas Kling.
Some compilers may complain that #pragma warning is an undefined macro.
- src/compiler/depgraph/DependencyGraph.cpp:
- 5:54 AM Changeset in webkit [148668] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Toolbar icons are displayed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=114792
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-18
Reviewed by Timothy Hatcher.
Inspector uses small toolbar icons when docking the inspector.
So icons should have different x position.
No tests because no behavior change is expected.
- inspector/front-end/inspector.css: Add missing 'background-position-x' values.
(body.dock-to-bottom .toolbar-item.profiles .toolbar-icon):
(body.dock-to-bottom .toolbar-item.cpu-profiler .toolbar-icon):
(body.dock-to-bottom .toolbar-item.css-profiler .toolbar-icon):
(body.dock-to-bottom .toolbar-item.heap-profiler .toolbar-icon):
(body.dock-to-bottom .toolbar-item.canvas-profiler .toolbar-icon):
(body.dock-to-bottom .toolbar-item.memory-chart-profiler .toolbar-icon):
(body.dock-to-bottom .toolbar-item.memory-snapshot-profiler .toolbar-icon):
- 5:43 AM Changeset in webkit [148667] by
-
- 9 edits in trunk/Source/WebKit/blackberry
removei build warning (unused parameter )
https://bugs.webkit.org/show_bug.cgi?id=114670
Patch by Xuefei Ren <xren@blackberry.com> on 2013-04-18
Reviewed by Rob Buis.
remove warning (unused parameter ) in
Source/WebKit/blackberry/WebCoreSupport
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::mouseDidMoveOverElement):
(WebCore::ChromeClientBlackBerry::needTouchEvents):
(WebCore::ChromeClientBlackBerry::reachedMaxAppCacheSize):
- WebCoreSupport/DatePickerClient.cpp:
(WebCore::DatePickerClient::setValue):
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::checkSpellingOfString):
(WebCore::EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveResponse):
(WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):
- WebCoreSupport/InspectorClientBlackBerry.cpp:
(WebCore::InspectorClientBlackBerry::updateInspectorStateCookie):
- WebCoreSupport/NetworkInfoClientBlackBerry.cpp:
(WebCore::NetworkInfoClientBlackBerry::onCurrentNetworkTypeChange):
(WebCore::NetworkInfoClientBlackBerry::onCurrentCellularTypeChange):
- WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::generateHTML):
- WebCoreSupport/UserMediaClientImpl.cpp:
(WebCore::UserMediaClientImpl::requestUserMedia):
- 5:02 AM Changeset in webkit [148666] by
-
- 8 edits in trunk/Source/WebKit2
[GTK][WK2] Add WebKitWebPage::webkit_web_page_get_uri to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=111288
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-18
Reviewed by Anders Carlsson.
Add new property URI to WebKitWebPage providing a method
webkit_web_page_get_uri to get it and the signal "notify::uri" to
monitor changes in the URI.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Include new method in
GTK+ doc.
- UIProcess/API/gtk/tests/TestLoaderClient.cpp:
(testWebPageURI):
(beforeAll):
(afterAll): Add test to check that WebKitWebPage URI matches with
WebKitWebView value. The tests is listening for changes in WebKitWebPage
URI via D-Bus and checks that value is the same than WebKitWebView URI.
It also checks that the order of the URIs in a redirection is right.
When the test finishes the signals are disconnected properly.
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(uriChangedCallback):
(pageCreatedCallback): Add new D-Bus signal "URIChanged" connected to
"notify::uri" signal of WebKitWebPage.
- UIProcess/API/gtk/tests/WebKitTestBus.cpp:
(WebKitTestBus::getOrCreateConnection): Rename method connection() to
getOrCreateConnection().
(WebKitTestBus::createProxy): Use the new method name.
- UIProcess/API/gtk/tests/WebKitTestBus.h:
(WebKitTestBus::connection): Add public getter for m_connection.
(WebKitTestBus): Add private method header getOrCreateConnection().
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(_WebKitWebPagePrivate): Add new URI attribute.
(webkitWebPageSetURI): Method to set the URI and emit the "notify:uri"
signal if it has changed.
(didStartProvisionalLoadForFrame): At this point it use the unreachable
URL from provisional document loader if any. Otherwise, it uses the URL
from provisional document loader.
(didReceiveServerRedirectForProvisionalLoadForFrame): In the case of
redirections it works like for didStartProvisionalLoadForFrame getting
the unreachable URL if any.
(didSameDocumentNavigationForFrame): In this case it gets the URL from
the document loader.
(webkitWebPageGetProperty): Add code related to URI property.
(webkit_web_page_class_init): Add bits related to URI property.
(webkitWebPageCreate): Implement callbacks to monitor URI changes.
(webkit_web_page_get_uri): Return URI attribute.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h: Add new method
header.
- 3:35 AM Changeset in webkit [148665] by
-
- 7 edits in trunk/Source/WebKit2
[GTK] When the WebProcess crashes, a signal should be emitted
https://bugs.webkit.org/show_bug.cgi?id=105180
Reviewed Carlos Garcia Campos.
Emit a "web-process-crashed" signal when the WebProcess crashes. This
is useful, for example, to show an error page in a web browser
like Chrome does.
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
(processDidCrash):
(attachLoaderClientToView):
- UIProcess/API/gtk/WebKitWebContextPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init):
(webkitWebViewWebProcessCrashed):
- UIProcess/API/gtk/tests/TestWebExtensions.cpp:
(testWebExtensionGetTitle):
(webProcessCrashedCallback):
(testWebKitWebViewProcessCrashed):
(beforeAll):
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(methodCallCallback):
- 3:27 AM Changeset in webkit [148664] by
-
- 3 edits in trunk/LayoutTests
fast/sub-pixel/float-wrap-zoom.html fails
https://bugs.webkit.org/show_bug.cgi?id=114800
Unreviewed gardending.
The test depends on pixel rounding in text painting.
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 3:11 AM Changeset in webkit [148663] by
-
- 2 edits in trunk/Source/JavaScriptCore
Implement JIT for MinGW-w64 64-bit
https://bugs.webkit.org/show_bug.cgi?id=114580
Patch by Jonathan Liu <net147@gmail.com> on 2013-04-18
Reviewed by Jocelyn Turcotte.
- jit/JITStubs.cpp:
(JSC):
- 2:47 AM Changeset in webkit [148662] by
-
- 3 edits in trunk/Tools
[EFL] Add a newline to the end of log message
https://bugs.webkit.org/show_bug.cgi?id=114659
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-18
Reviewed by Gyuyoung Kim.
Move a newline to info() definition.
- EWebLauncher/main.c:
(on_load_finished):
(on_tooltip_text_set):
(on_tooltip_text_unset):
(on_inputmethod_changed):
(on_focus_out):
(on_focus_in):
(on_key_down):
(windowCreate):
- MiniBrowser/efl/main.c:
(on_key_down):
(on_download_request):
(on_download_finished):
(on_download_failed):
(on_refresh_button_clicked):
(on_popup_menu_discarded):
(on_popup_menu_item_clicked):
(popup_menu_populate):
(on_popup_menu_show):
(on_window_create):
(context_popup_item_selected_cb):
(on_context_menu_show):
(on_context_menu_hide):
(window_create):
- 2:24 AM Changeset in webkit [148661] by
-
- 21 edits1 copy27 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Updating png expected results after r148594.
- platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.png:
- platform/qt-5.0-wk2/compositing/overflow/overflow-compositing-descendant-expected.png:
- platform/qt-5.0-wk2/compositing/overflow/scroll-ancestor-update-expected.png: Added.
- platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed-expected.png:
- platform/qt-5.0-wk2/compositing/self-painting-layers-expected.png: Added.
- platform/qt-5.0-wk2/compositing/shadows/shadow-drawing-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/replaced-boundaries-3-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/select-box-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/select-element-paragraph-boundary-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/background-position-parsing-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/box-shadow-transformed-expected.png:
- platform/qt-5.0-wk2/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/qt-5.0-wk2/fast/css-generated-content/014-expected.png:
- platform/qt-5.0-wk2/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/qt-5.0-wk2/fast/events/pointer-events-2-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/menulist-separator-painting-expected.txt:
- platform/qt-5.0-wk2/fast/forms/select-baseline-expected.txt: Added.
- platform/qt-5.0-wk2/fast/forms/selectlist-minsize-expected.txt: Added.
- platform/qt-5.0-wk2/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
- platform/qt-5.0-wk2/fast/inline/continuation-outlines-expected.png: Added.
- platform/qt-5.0-wk2/fast/lists/ordered-list-with-no-ol-tag-expected.png: Added.
- platform/qt-5.0-wk2/fast/text/whitespace/013-expected.png:
- platform/qt-5.0-wk2/fast/text/whitespace/014-expected.png:
- platform/qt-5.0-wk2/svg/as-border-image/svg-as-border-image-expected.png:
- platform/qt-5.0-wk2/svg/custom/image-parent-translation-expected.png:
- platform/qt-5.0-wk2/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/qt-5.0-wk2/svg/custom/js-update-image-and-display-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/text/whitespace/013-expected.png.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
- platform/qt-5.0-wk2/svg/text/remove-text-node-from-tspan-expected.png:
- platform/qt-5.0-wk2/svg/text/remove-tspan-from-text-expected.png:
- platform/qt-5.0-wk2/svg/text/text-deco-01-b-expected.png: Added.
- platform/qt-5.0-wk2/svg/wicd/test-rightsizing-b-expected.png:
- platform/qt-5.0-wk2/svg/wicd/test-scalable-background-image2-expected.png:
- platform/qt-5.0-wk2/svg/zoom/page/zoom-background-images-expected.png:
- platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug56563-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png: Added.
- 1:50 AM EFLWebKit edited by
- libsoup was bumped after r148506 (diff)
- 1:05 AM Changeset in webkit [148660] by
-
- 7 edits in trunk/Source/WebKit2
[EFL][WK2] Add tooltip API to the WKView client
https://bugs.webkit.org/show_bug.cgi?id=111563
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2013-04-18
Reviewed by Andreas Kling.
Add tooltip to the barebone Tizen C API, and implement
the method so that the EFL API keeps working.
- UIProcess/API/C/efl/WKView.h:
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeTooltip):
(WebKit):
(WebKit::ViewClientEfl::ViewClientEfl):
- UIProcess/efl/ViewClientEfl.h:
(ViewClientEfl):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::toolTipChanged):
- UIProcess/efl/WebViewClient.cpp:
(WebKit::WebViewClient::didChangeTooltip):
(WebKit):
- UIProcess/efl/WebViewClient.h:
- 12:26 AM Changeset in webkit [148659] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Fix expectations for a couple of flaky tests.
Adding aditional flaky and timeout expectations for the currently failing tests.
Apr 17, 2013:
- 9:25 PM Changeset in webkit [148658] by
-
- 3 edits1 move1 add1 delete in trunk
[css3-text] Rendering -webkit-hanging value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=114663
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-17
Reviewed by Beth Dakin.
This patch is the rendering part to support hanging value for text-indent.
"hanging" means "Inverts which lines are affected."
It's prefixed and guarded by CSS3_TEXT flag.
Spec: http://dev.w3.org/csswg/css-text/#text-indent
Source/WebCore:
Test: fast/css3-text/css3-text-indent/text-indent-each-line-hanging.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::requiresIndent): Inverted the return value when "-webkit-hanging" is applied.
LayoutTests:
Renamed and updated the existing testcases.
- fast/css3-text/css3-text-indent/text-indent-each-line-hanging-expected.html: Renamed from LayoutTests/fast/css3-text/css3-text-indent/text-indent-each-line-expected.html
- fast/css3-text/css3-text-indent/text-indent-each-line-hanging.html: Renamed from LayoutTests/fast/css3-text/css3-text-indent/text-indent-each-line.html.
- 9:02 PM Changeset in webkit [148657] by
-
- 4 edits in trunk/Source
Versioning.
- 9:01 PM Changeset in webkit [148656] by
-
- 1 copy in tags/Safari-537.38
New Tag.
- 8:17 PM Changeset in webkit [148655] by
-
- 4 edits in trunk/Source/JavaScriptCore
Avoid using a branch range that is too far for some CPU architectures.
https://bugs.webkit.org/show_bug.cgi?id=114782.
Reviewed by David Kilzer.
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 6:11 PM Changeset in webkit [148654] by
-
- 5 edits in trunk
AX: aria-level does not override implicit level on h1, h2, etc
https://bugs.webkit.org/show_bug.cgi?id=114692
Patch by James Craig <james@cookiecrook.com> on 2013-04-17
Reviewed by Chris Fleizach.
aria-level now works on headings without an explicit role="heading" defined. Updated existing test coverage.
Source/WebCore:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::headingLevel):
LayoutTests:
- accessibility/heading-level-expected.txt:
- accessibility/heading-level.html:
- 6:08 PM Changeset in webkit [148653] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix SH4 build (broken since r148639).
https://bugs.webkit.org/show_bug.cgi?id=114773.
Allow longer displacements for specific branches in SH4 LLINT.
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-04-17
Reviewed by Oliver Hunt.
- offlineasm/sh4.rb:
- 5:37 PM Changeset in webkit [148652] by
-
- 5 edits2 adds in trunk
AX: VoiceOver says everything that isn't a link is a "clickable" in Safari reader?
https://bugs.webkit.org/show_bug.cgi?id=114687
Reviewed by Tim Horton.
Source/WebCore:
VoiceOver is saying all text is clickable, because AXPress is exposed as an action on static text.
That is happening, because there's a click handler on the body element in this case.
I think the best plan to keep existing functionality, but fix this case is not to expose
the press action for static text when the handler is on the body element.
Test: platform/mac/accessibility/press-action-not-exposed-when-body-is-click-handler.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::mouseButtonListener):
Change from checking getAttributeEventListener to hasEventListeners. The former only
checks if "onclick" is installed on the element and does not work with addEventListener!
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isStaticText):
LayoutTests:
- platform/mac/accessibility/press-action-not-exposed-when-body-is-click-handler-expected.txt: Added.
- platform/mac/accessibility/press-action-not-exposed-when-body-is-click-handler.html: Added.
- 5:04 PM Changeset in webkit [148651] by
-
- 3 edits in trunk/Source/WebCore
Fix GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush() to do predictive visible rect expansion
https://bugs.webkit.org/show_bug.cgi?id=114775
Reviewed by Tim Horton.
GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush() is intended to answer the question
"if your visible rect is changed to X, would any tiles be created or destroyed?".
However, for compositing layer tiled layers, we do some predictive visible rect expansion based on how
the visible rect is changing when we actually commit visible rect changes. recursiveVisibleRectChangeRequiresFlush()
was not doing that, causing it to give confusing answers, so fix it to do so.
Both now call adjustTiledLayerVisibleRect(), and it's cleaner to make this a static function.
A somewhat unrelated change is to take the layer bounds origin into account
in GraphicsLayerCA::computeVisibleRect(). Desktop WebKit never sets this, but it's used
on other platforms for composited scrolling, so needs to be taken into account
when computing visible rects.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush):
(WebCore::GraphicsLayerCA::computeVisibleRect):
(WebCore::GraphicsLayerCA::adjustTiledLayerVisibleRect):
(WebCore::GraphicsLayerCA::updateVisibleRect):
- platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
- 4:58 PM Changeset in webkit [148650] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed. More Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 4:53 PM Changeset in webkit [148649] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
Update expected output for fast/css/variables/deferred-image-load-from-variable.html
<rdar://problem/13679357>
Patch by David Farler.
- fast/css/image-set-value-not-removed-crash-expected.txt:
Added newline.
- 4:53 PM Changeset in webkit [148648] by
-
- 17 edits in trunk/Source/WebCore
Automate generation of toJS function for classes that need to report extra memory usage
https://bugs.webkit.org/show_bug.cgi?id=114768
Reviewed by Geoff Garen.
Only really used by AudioBuffer for now. The other classes that need it can be
trivially refactored at a later date.
- Modules/webaudio/AudioBuffer.idl:
- bindings/js/JSAudioBufferCustom.cpp:
- bindings/js/JSDOMBinding.h:
(WebCore):
(HasMemoryCost):
(NoType):
(BaseMixin):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- 4:38 PM Changeset in webkit [148647] by
-
- 1 edit1679 deletes in trunk/LayoutTests
Remove the mac-snowleopard LayoutTest directory.
Reviewed by Sam Weinig.
- platform/mac-snowleopard/TestExpectations: Removed.
- platform/mac-snowleopard/animations/missing-values-first-keyframe-expected.png: Removed.
- platform/mac-snowleopard/animations/missing-values-last-keyframe-expected.png: Removed.
- platform/mac-snowleopard/animations/suspend-transform-animation-expected.png: Removed.
- platform/mac-snowleopard/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Removed.
- platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Removed.
- platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Removed.
- platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Removed.
- platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Removed.
- platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Removed.
- platform/mac-snowleopard/canvas/philip/tests/2d.line.cap.closed-expected.txt: Removed.
- platform/mac-snowleopard/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Removed.
- platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Removed.
- platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Removed.
- platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Removed.
- platform/mac-snowleopard/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Removed.
- platform/mac-snowleopard/canvas/philip/tests/2d.strokeRect.zero.5-expected.txt: Removed.
- platform/mac-snowleopard/compositing/color-matching/image-color-matching-expected.png: Removed.
- platform/mac-snowleopard/compositing/direct-image-compositing-expected.png: Removed.
- platform/mac-snowleopard/compositing/flat-with-transformed-child-expected.png: Removed.
- platform/mac-snowleopard/compositing/framesets/composited-frame-alignment-expected.png: Removed.
- platform/mac-snowleopard/compositing/geometry/clipping-foreground-expected.png: Removed.
- platform/mac-snowleopard/compositing/geometry/composited-html-size-expected.png: Removed.
- platform/mac-snowleopard/compositing/geometry/fixed-in-composited-expected.png: Removed.
- platform/mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Removed.
- platform/mac-snowleopard/compositing/geometry/foreground-layer-expected.png: Removed.
- platform/mac-snowleopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Removed.
- platform/mac-snowleopard/compositing/geometry/layer-due-to-layer-children-expected.png: Removed.
- platform/mac-snowleopard/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Removed.
- platform/mac-snowleopard/compositing/geometry/repaint-foreground-layer-expected.png: Removed.
- platform/mac-snowleopard/compositing/geometry/root-layer-update-expected.png: Removed.
- platform/mac-snowleopard/compositing/geometry/rtl-composited-expected.png: Removed.
- platform/mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Removed.
- platform/mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Removed.
- platform/mac-snowleopard/compositing/iframes/composited-iframe-scroll-expected.png: Removed.
- platform/mac-snowleopard/compositing/iframes/iframe-content-flipping-expected.png: Removed.
- platform/mac-snowleopard/compositing/images/content-image-change-expected.png: Removed.
- platform/mac-snowleopard/compositing/images/direct-image-background-color-expected.png: Removed.
- platform/mac-snowleopard/compositing/images/direct-pdf-image-expected.png: Removed.
- platform/mac-snowleopard/compositing/images/direct-svg-image-expected.png: Removed.
- platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Removed.
- platform/mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Removed.
- platform/mac-snowleopard/compositing/masks/layer-mask-placement-expected.png: Removed.
- platform/mac-snowleopard/compositing/masks/masked-ancestor-expected.png: Removed.
- platform/mac-snowleopard/compositing/masks/simple-composited-mask-expected.png: Removed.
- platform/mac-snowleopard/compositing/overflow/fixed-position-ancestor-clip-expected.png: Removed.
- platform/mac-snowleopard/compositing/overflow/overflow-compositing-descendant-expected.png: Removed.
- platform/mac-snowleopard/compositing/overflow/overflow-positioning-expected.png: Removed.
- platform/mac-snowleopard/compositing/overflow/overflow-scroll-expected.png: Removed.
- platform/mac-snowleopard/compositing/overflow/repaint-after-losing-scrollbars-expected.png: Removed.
- platform/mac-snowleopard/compositing/overflow/scroll-ancestor-update-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/become-simple-composited-reflection-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/compositing-change-inside-reflection-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/deeply-nested-reflections-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/masked-reflection-on-composited-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-anchor-point-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-mask-change-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-on-overflow-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-opacity-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-size-change-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-transformed-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-transformed2-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/nested-reflection-transition-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/reflection-opacity-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/reflection-positioning-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/reflection-positioning2-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/remove-add-reflection-expected.png: Removed.
- platform/mac-snowleopard/compositing/reflections/transform-inside-reflection-expected.png: Removed.
- platform/mac-snowleopard/compositing/repaint/same-size-invalidation-expected.png: Removed.
- platform/mac-snowleopard/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
- platform/mac-snowleopard/compositing/scrollbar-painting-expected.png: Removed.
- platform/mac-snowleopard/compositing/self-painting-layers-expected.png: Removed.
- platform/mac-snowleopard/compositing/shadows/shadow-drawing-expected.png: Removed.
- platform/mac-snowleopard/compositing/tiling/constrained-layer-size-expected.png: Removed.
- platform/mac-snowleopard/compositing/transitions/scale-transition-no-start-expected.png: Removed.
- platform/mac-snowleopard/compositing/video/video-background-color-expected.png: Removed.
- platform/mac-snowleopard/compositing/visibility/visibility-composited-expected.png: Removed.
- platform/mac-snowleopard/compositing/visibility/visibility-simple-canvas2d-layer-expected.png: Removed.
- platform/mac-snowleopard/compositing/visibility/visibility-simple-video-layer-expected.png: Removed.
- platform/mac-snowleopard/compositing/visibility/visibility-simple-webgl-layer-expected.png: Removed.
- platform/mac-snowleopard/compositing/webgl/webgl-background-color-expected.png: Removed.
- platform/mac-snowleopard/compositing/webgl/webgl-no-alpha-expected.png: Removed.
- platform/mac-snowleopard/css1/box_properties/border_bottom-expected.png: Removed.
- platform/mac-snowleopard/css1/box_properties/border_left-expected.png: Removed.
- platform/mac-snowleopard/css1/box_properties/border_right_inline-expected.png: Removed.
- platform/mac-snowleopard/css1/box_properties/float_on_text_elements-expected.png: Removed.
- platform/mac-snowleopard/css1/box_properties/margin_inline-expected.png: Removed.
- platform/mac-snowleopard/css1/box_properties/margin_left-expected.png: Removed.
- platform/mac-snowleopard/css1/box_properties/margin_right-expected.png: Removed.
- platform/mac-snowleopard/css1/box_properties/padding_bottom_inline-expected.png: Removed.
- platform/mac-snowleopard/css1/box_properties/padding_inline-expected.png: Removed.
- platform/mac-snowleopard/css1/box_properties/padding_left-expected.png: Removed.
- platform/mac-snowleopard/css1/box_properties/padding_right-expected.png: Removed.
- platform/mac-snowleopard/css1/cascade/important-expected.png: Removed.
- platform/mac-snowleopard/css1/classification/display-expected.png: Removed.
- platform/mac-snowleopard/css1/color_and_background/background_image-expected.png: Removed.
- platform/mac-snowleopard/css1/color_and_background/background_position-expected.png: Removed.
- platform/mac-snowleopard/css1/color_and_background/background_repeat-expected.png: Removed.
- platform/mac-snowleopard/css1/font_properties/font-expected.png: Removed.
- platform/mac-snowleopard/css1/font_properties/font_family-expected.png: Removed.
- platform/mac-snowleopard/css1/formatting_model/inline_elements-expected.png: Removed.
- platform/mac-snowleopard/css1/pseudo/firstletter-expected.png: Removed.
- platform/mac-snowleopard/css1/pseudo/firstline-expected.png: Removed.
- platform/mac-snowleopard/css1/pseudo/multiple_pseudo_elements-expected.png: Removed.
- platform/mac-snowleopard/css1/pseudo/pseudo_elements_in_selectors-expected.png: Removed.
- platform/mac-snowleopard/css1/text_properties/text_decoration-expected.png: Removed.
- platform/mac-snowleopard/css1/text_properties/text_transform-expected.png: Removed.
- platform/mac-snowleopard/css1/units/urls-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-003-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-010-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-017-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-024-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-031-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-006-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-013-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-020-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-022-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-027-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-029-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-034-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-036-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-041-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-043-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-048-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-050-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-055-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-057-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-062-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-064-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-069-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-071-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-076-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/block-replaced-height-003-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/block-replaced-width-006-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/border-collapse-offset-002-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/dynamic-top-change-001-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/dynamic-top-change-002-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/dynamic-top-change-003-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/dynamic-top-change-004-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/float-replaced-height-003-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/float-replaced-width-001-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/float-replaced-width-002-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/float-replaced-width-003-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/float-replaced-width-004-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/float-replaced-width-005-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/float-replaced-width-011-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/height-width-inline-table-001-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/height-width-table-001-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/inline-block-replaced-height-003-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/inline-block-replaced-height-008-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/inline-block-replaced-width-006-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/inline-replaced-height-003-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/inline-replaced-height-008-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/inline-replaced-width-001-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/inline-replaced-width-006-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-001-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-002-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-003-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-004-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-005-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-006-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-007-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-008-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-009-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-010-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-012-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-013-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-014-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/margin-applies-to-015-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.txt: Removed.
- platform/mac-snowleopard/css2.1/20110323/table-caption-001-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/table-caption-002-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/width-replaced-element-001-expected.png: Removed.
- platform/mac-snowleopard/css2.1/t051201-c23-first-line-00-b-expected.png: Removed.
- platform/mac-snowleopard/css2.1/t1002-c5523-width-02-b-g-expected.png: Removed.
- platform/mac-snowleopard/css2.1/t1202-counter-09-b-expected.png: Removed.
- platform/mac-snowleopard/css2.1/t1202-counter-09-b-expected.txt: Removed.
- platform/mac-snowleopard/css2.1/t1202-counters-09-b-expected.png: Removed.
- platform/mac-snowleopard/css2.1/t1202-counters-09-b-expected.txt: Removed.
- platform/mac-snowleopard/css2.1/t1508-c527-font-01-b-expected.png: Removed.
- platform/mac-snowleopard/css2.1/t1508-c527-font-05-b-expected.png: Removed.
- platform/mac-snowleopard/css2.1/t1508-c527-font-05-b-expected.txt: Removed.
- platform/mac-snowleopard/css2.1/t1508-c527-font-10-c-expected.png: Removed.
- platform/mac-snowleopard/css2.1/t1508-c527-font-10-c-expected.txt: Removed.
- platform/mac-snowleopard/css3/filters/add-filter-rendering-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/crash-filter-change-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-blur-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-blur-hw-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-brightness-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-brightness-hw-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-combined-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-combined-hw-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-contrast-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-contrast-hw-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-drop-shadow-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-drop-shadow-hw-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-grayscale-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-grayscale-hw-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-hue-rotate-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-hue-rotate-hw-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-invert-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-invert-hw-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-opacity-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-opacity-hw-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-saturate-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-saturate-hw-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-sepia-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/effect-sepia-hw-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/filter-region-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/filter-repaint-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/filter-with-transform-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/filtered-compositing-descendant-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/multiple-filters-invalidation-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/nested-filter-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/regions-expanding-expected.png: Removed.
- platform/mac-snowleopard/css3/filters/simple-filter-rendering-expected.png: Removed.
- platform/mac-snowleopard/css3/flexbox/repaint-expected.png: Removed.
- platform/mac-snowleopard/css3/flexbox/repaint-rtl-column-expected.png: Removed.
- platform/mac-snowleopard/css3/images/cross-fade-background-size-expected.png: Removed.
- platform/mac-snowleopard/css3/images/cross-fade-blending-expected.png: Removed.
- platform/mac-snowleopard/css3/images/cross-fade-simple-expected.png: Removed.
- platform/mac-snowleopard/css3/images/cross-fade-sizing-expected.png: Removed.
- platform/mac-snowleopard/css3/images/cross-fade-tiled-expected.png: Removed.
- platform/mac-snowleopard/css3/selectors3/html/css3-modsel-19b-expected.png: Removed.
- platform/mac-snowleopard/css3/selectors3/html/css3-modsel-39-expected.png: Removed.
- platform/mac-snowleopard/css3/selectors3/html/css3-modsel-39b-expected.png: Removed.
- platform/mac-snowleopard/css3/selectors3/html/css3-modsel-39c-expected.png: Removed.
- platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-19b-expected.png: Removed.
- platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-39-expected.png: Removed.
- platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-39a-expected.png: Removed.
- platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-39b-expected.png: Removed.
- platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-39c-expected.png: Removed.
- platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-19b-expected.png: Removed.
- platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-39-expected.png: Removed.
- platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-39a-expected.png: Removed.
- platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-39b-expected.png: Removed.
- platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-39c-expected.png: Removed.
- platform/mac-snowleopard/editing/input/devanagari-ligature-expected.png: Removed.
- platform/mac-snowleopard/editing/input/devanagari-ligature-expected.txt: Removed.
- platform/mac-snowleopard/editing/inserting/break-blockquote-after-delete-expected.png: Removed.
- platform/mac-snowleopard/editing/inserting/typing-at-end-of-line-expected.png: Removed.
- platform/mac-snowleopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Removed.
- platform/mac-snowleopard/editing/pasteboard/paste-TIFF-expected.png: Removed.
- platform/mac-snowleopard/editing/selection/drag-to-contenteditable-iframe-expected.png: Removed.
- platform/mac-snowleopard/editing/selection/unrendered-002-expected.png: Removed.
- platform/mac-snowleopard/editing/unsupported-content/list-delete-001-expected.png: Removed.
- platform/mac-snowleopard/editing/unsupported-content/list-delete-003-expected.png: Removed.
- platform/mac-snowleopard/editing/unsupported-content/list-type-after-expected.png: Removed.
- platform/mac-snowleopard/editing/unsupported-content/list-type-before-expected.png: Removed.
- platform/mac-snowleopard/editing/unsupported-content/table-delete-001-expected.png: Removed.
- platform/mac-snowleopard/editing/unsupported-content/table-delete-002-expected.png: Removed.
- platform/mac-snowleopard/editing/unsupported-content/table-delete-003-expected.png: Removed.
- platform/mac-snowleopard/editing/unsupported-content/table-type-after-expected.png: Removed.
- platform/mac-snowleopard/editing/unsupported-content/table-type-before-expected.png: Removed.
- platform/mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Removed.
- platform/mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Removed.
- platform/mac-snowleopard/fast/backgrounds/size/backgroundSize18-expected.png: Removed.
- platform/mac-snowleopard/fast/backgrounds/size/backgroundSize19-expected.png: Removed.
- platform/mac-snowleopard/fast/backgrounds/size/backgroundSize21-expected.png: Removed.
- platform/mac-snowleopard/fast/backgrounds/size/backgroundSize22-expected.png: Removed.
- platform/mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
- platform/mac-snowleopard/fast/block/basic/truncation-rtl-expected.png: Removed.
- platform/mac-snowleopard/fast/block/float/020-expected.png: Removed.
- platform/mac-snowleopard/fast/block/float/float-avoidance-expected.png: Removed.
- platform/mac-snowleopard/fast/block/margin-collapse/103-expected.png: Removed.
- platform/mac-snowleopard/fast/block/positioning/028-expected.png: Removed.
- platform/mac-snowleopard/fast/block/positioning/031-expected.png: Removed.
- platform/mac-snowleopard/fast/borders/border-image-massive-scale-expected.png: Removed.
- platform/mac-snowleopard/fast/borders/border-image-outset-expected.png: Removed.
- platform/mac-snowleopard/fast/borders/border-image-outset-in-shorthand-expected.png: Removed.
- platform/mac-snowleopard/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Removed.
- platform/mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png: Removed.
- platform/mac-snowleopard/fast/borders/border-image-scale-transform-expected.png: Removed.
- platform/mac-snowleopard/fast/borders/border-image-scaled-expected.png: Removed.
- platform/mac-snowleopard/fast/borders/border-image-slice-constrained-expected.png: Removed.
- platform/mac-snowleopard/fast/borders/inline-mask-overlay-image-expected.png: Removed.
- platform/mac-snowleopard/fast/borders/rtl-border-01-expected.png: Removed.
- platform/mac-snowleopard/fast/borders/rtl-border-02-expected.png: Removed.
- platform/mac-snowleopard/fast/borders/rtl-border-03-expected.png: Removed.
- platform/mac-snowleopard/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
- platform/mac-snowleopard/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
- platform/mac-snowleopard/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
- platform/mac-snowleopard/fast/canvas/canvas-incremental-repaint-expected.png: Removed.
- platform/mac-snowleopard/fast/canvas/set-colors-expected.txt: Removed.
- platform/mac-snowleopard/fast/canvas/shadow-offset-7-expected.png: Removed.
- platform/mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Removed.
- platform/mac-snowleopard/fast/css/background-shorthand-invalid-url-expected.png: Removed.
- platform/mac-snowleopard/fast/css/bidi-override-in-anonymous-block-expected.png: Removed.
- platform/mac-snowleopard/fast/css/child-style-can-override-visited-style-expected.png: Removed.
- platform/mac-snowleopard/fast/css/clip-text-in-scaled-div-expected.png: Removed.
- platform/mac-snowleopard/fast/css/color-correction-backgrounds-and-text-expected.png: Removed.
- platform/mac-snowleopard/fast/css/color-correction-on-background-image-expected.png: Removed.
- platform/mac-snowleopard/fast/css/continuationCrash-expected.png: Removed.
- platform/mac-snowleopard/fast/css/font-family-pictograph-expected.png: Removed.
- platform/mac-snowleopard/fast/css/font-family-pictograph-expected.txt: Removed.
- platform/mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.png: Removed.
- platform/mac-snowleopard/fast/css/outline-narrowLine-expected.png: Removed.
- platform/mac-snowleopard/fast/css/text-overflow-input-expected.png: Removed.
- platform/mac-snowleopard/fast/css/text-transform-select-expected.png: Removed.
- platform/mac-snowleopard/fast/css/transform-default-parameter-expected.png: Removed.
- platform/mac-snowleopard/fast/css/value-list-out-of-bounds-crash-expected.png: Removed.
- platform/mac-snowleopard/fast/dom/52776-expected.png: Removed.
- platform/mac-snowleopard/fast/dom/52776-expected.txt: Removed.
- platform/mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Removed.
- platform/mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png: Removed.
- platform/mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/001-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/HTMLOptionElement_label01-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/HTMLOptionElement_label02-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/HTMLOptionElement_label03-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/HTMLOptionElement_label04-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/basic-buttons-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/basic-inputs-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/basic-selects-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/basic-textareas-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/basic-textareas-quirks-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/box-shadow-override-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/button-align-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/button-cannot-be-nested-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/button-default-title-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/button-generated-content-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/button-inner-block-reuse-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/button-sizes-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/button-style-color-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/button-table-styles-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/button-text-transform-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/button-white-space-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/control-clip-overflow-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/control-restrict-line-height-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/disabled-select-change-index-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/fieldset-align-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/file/file-input-direction-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/file/input-file-re-render-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/form-element-geometry-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/form-hides-table-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/formmove-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/input-appearance-height-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/input-button-sizes-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/input-table-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/input-value-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/listbox-bidi-align-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/listbox-hit-test-zoomed-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/listbox-scrollbar-incremental-load-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/menulist-style-color-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/menulist-width-change-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/option-strip-whitespace-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/option-text-clip-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/placeholder-position-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/plaintext-mode-2-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/range/slider-padding-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/range/slider-thumb-shared-style-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/search-vertical-alignment-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/select-align-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/select-baseline-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/select-change-listbox-to-popup-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/select-disabled-appearance-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/select-initial-position-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/select-item-background-clip-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/select-selected-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/select-size-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/select-style-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/select-visual-hebrew-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/select-writing-direction-natural-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/select-writing-direction-natural-expected.txt: Removed.
- platform/mac-snowleopard/fast/forms/textAreaLineHeight-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/textarea-align-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/textarea-scroll-height-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/textarea-scrollbar-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/textarea-scrolled-type-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/textarea-width-expected.png: Removed.
- platform/mac-snowleopard/fast/gradients/crash-on-zero-radius-expected.png: Removed.
- platform/mac-snowleopard/fast/gradients/css3-radial-gradients-expected.png: Removed.
- platform/mac-snowleopard/fast/gradients/generated-gradients-expected.png: Removed.
- platform/mac-snowleopard/fast/gradients/gradient-after-transparent-border-expected.png: Removed.
- platform/mac-snowleopard/fast/gradients/simple-gradients-expected.png: Removed.
- platform/mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.png: Removed.
- platform/mac-snowleopard/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Removed.
- platform/mac-snowleopard/fast/images/gray-scale-png-with-color-profile-expected.png: Removed.
- platform/mac-snowleopard/fast/images/image-css3-content-data-expected.png: Removed.
- platform/mac-snowleopard/fast/images/jpeg-with-color-profile-expected.png: Removed.
- platform/mac-snowleopard/fast/images/paletted-png-with-color-profile-expected.png: Removed.
- platform/mac-snowleopard/fast/images/pdf-as-background-expected.png: Removed.
- platform/mac-snowleopard/fast/images/pdf-as-image-expected.png: Removed.
- platform/mac-snowleopard/fast/images/png-with-color-profile-expected.png: Removed.
- platform/mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Removed.
- platform/mac-snowleopard/fast/inline/inline-borders-with-bidi-override-expected.png: Removed.
- platform/mac-snowleopard/fast/inline/inline-box-background-long-image-expected.png: Removed.
- platform/mac-snowleopard/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Removed.
- platform/mac-snowleopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Removed.
- platform/mac-snowleopard/fast/layers/scroll-with-transform-layer-expected.png: Removed.
- platform/mac-snowleopard/fast/lists/003-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/block-axis-horizontal-bt-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/block-axis-horizontal-tb-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/column-rules-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/column-rules-stacking-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/columns-shorthand-parsing-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/float-avoidance-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/float-multicol-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/float-paginate-complex-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/layers-in-multicol-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/nested-columns-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/overflow-across-columns-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/overflow-across-columns-percent-height-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/overflow-unsplittable-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/pagination-h-horizontal-bt-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/pagination-h-horizontal-tb-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/pagination-h-vertical-lr-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/pagination-h-vertical-rl-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/pagination-v-horizontal-bt-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/pagination-v-horizontal-tb-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/pagination-v-vertical-lr-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/pagination-v-vertical-rl-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/positioned-with-constrained-height-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/positive-leading-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/scrolling-overflow-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/shadow-breaking-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/single-line-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/span/anonymous-style-inheritance-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/span/span-as-immediate-columns-child-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/span/span-as-nested-columns-child-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/span/span-margin-collapsing-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/vertical-lr/float-avoidance-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/vertical-rl/float-avoidance-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/vertical-rl/rule-style-expected.png: Removed.
- platform/mac-snowleopard/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Removed.
- platform/mac-snowleopard/fast/overflow/006-expected.png: Removed.
- platform/mac-snowleopard/fast/overflow/overflow-focus-ring-expected.png: Removed.
- platform/mac-snowleopard/fast/overflow/overflow-x-y-expected.png: Removed.
- platform/mac-snowleopard/fast/parser/document-write-option-expected.png: Removed.
- platform/mac-snowleopard/fast/preloader/document-write-2-expected.txt: Removed.
- platform/mac-snowleopard/fast/preloader/document-write-expected.txt: Removed.
- platform/mac-snowleopard/fast/preloader/script-expected.txt: Removed.
- platform/mac-snowleopard/fast/reflections/reflection-direction-expected.png: Removed.
- platform/mac-snowleopard/fast/reflections/reflection-masks-expected.png: Removed.
- platform/mac-snowleopard/fast/reflections/reflection-masks-opacity-expected.png: Removed.
- platform/mac-snowleopard/fast/reflections/reflection-masks-outset-expected.png: Removed.
- platform/mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt: Removed.
- platform/mac-snowleopard/fast/repaint/line-flow-with-floats-2-expected.png: Removed.
- platform/mac-snowleopard/fast/repaint/line-flow-with-floats-8-expected.png: Removed.
- platform/mac-snowleopard/fast/repaint/line-flow-with-floats-9-expected.png: Removed.
- platform/mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
- platform/mac-snowleopard/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
- platform/mac-snowleopard/fast/repaint/scale-page-shrink-expected.png: Removed.
- platform/mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png: Removed.
- platform/mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Removed.
- platform/mac-snowleopard/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
- platform/mac-snowleopard/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Removed.
- platform/mac-snowleopard/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
- platform/mac-snowleopard/fast/repaint/text-shadow-expected.png: Removed.
- platform/mac-snowleopard/fast/repaint/text-shadow-horizontal-expected.png: Removed.
- platform/mac-snowleopard/fast/replaced/replaced-breaking-expected.png: Removed.
- platform/mac-snowleopard/fast/replaced/width100percent-button-expected.png: Removed.
- platform/mac-snowleopard/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Removed.
- platform/mac-snowleopard/fast/selectors/166-expected.png: Removed.
- platform/mac-snowleopard/fast/selectors/visited-descendant-expected.png: Removed.
- platform/mac-snowleopard/fast/table/auto-100-percent-width-expected.png: Removed.
- platform/mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png: Removed.
- platform/mac-snowleopard/fast/table/frame-and-rules-expected.png: Removed.
- platform/mac-snowleopard/fast/table/height-percent-test-vertical-expected.png: Removed.
- platform/mac-snowleopard/fast/table/multiple-captions-display-expected.png: Removed.
- platform/mac-snowleopard/fast/text/backslash-to-yen-sign-euc-expected.png: Removed.
- platform/mac-snowleopard/fast/text/capitalize-boundaries-expected.png: Removed.
- platform/mac-snowleopard/fast/text/capitalize-boundaries-expected.txt: Removed.
- platform/mac-snowleopard/fast/text/complex-text-opacity-expected.png: Removed.
- platform/mac-snowleopard/fast/text/complex-text-opacity-expected.txt: Removed.
- platform/mac-snowleopard/fast/text/fallback-traits-fixup-expected.png: Removed.
- platform/mac-snowleopard/fast/text/fallback-traits-fixup-expected.txt: Removed.
- platform/mac-snowleopard/fast/text/hyphenate-character-expected.png: Removed.
- platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt: Removed.
- platform/mac-snowleopard/fast/text/hyphenate-limit-lines-expected.png: Removed.
- platform/mac-snowleopard/fast/text/hyphenate-limit-lines-expected.txt: Removed.
- platform/mac-snowleopard/fast/text/hyphenate-locale-expected.txt: Removed.
- platform/mac-snowleopard/fast/text/hyphens-expected.png: Removed.
- platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Removed.
- platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Removed.
- platform/mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.png: Removed.
- platform/mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.txt: Removed.
- platform/mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.png: Removed.
- platform/mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Removed.
- platform/mac-snowleopard/fast/text/international/bidi-CS-after-AN-expected.png: Removed.
- platform/mac-snowleopard/fast/text/international/bidi-CS-after-AN-expected.txt: Removed.
- platform/mac-snowleopard/fast/text/international/bidi-menulist-expected.png: Removed.
- platform/mac-snowleopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Removed.
- platform/mac-snowleopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Removed.
- platform/mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png: Removed.
- platform/mac-snowleopard/fast/text/international/bidi-neutral-run-expected.txt: Removed.
- platform/mac-snowleopard/fast/text/international/bold-bengali-expected.png: Removed.
- platform/mac-snowleopard/fast/text/international/bold-bengali-expected.txt: Removed.
- platform/mac-snowleopard/fast/text/international/hebrew-vowels-expected.png: Removed.
- platform/mac-snowleopard/fast/text/international/khmer-selection-expected.png: Removed.
- platform/mac-snowleopard/fast/text/international/khmer-selection-expected.txt: Removed.
- platform/mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Removed.
- platform/mac-snowleopard/fast/text/justify-ideograph-leading-expansion-expected.png: Removed.
- platform/mac-snowleopard/fast/text/justify-ideograph-leading-expansion-expected.txt: Removed.
- platform/mac-snowleopard/fast/text/midword-break-after-breakable-char-expected.png: Removed.
- platform/mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.png: Removed.
- platform/mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Removed.
- platform/mac-snowleopard/fast/text/stroking-decorations-expected.png: Removed.
- platform/mac-snowleopard/fast/text/stroking-expected.png: Removed.
- platform/mac-snowleopard/fast/text/text-letter-spacing-expected.png: Removed.
- platform/mac-snowleopard/fast/text/unicode-variation-selector-expected.png: Removed.
- platform/mac-snowleopard/fast/text/wbr-expected.png: Removed.
- platform/mac-snowleopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Removed.
- platform/mac-snowleopard/fast/writing-mode/border-image-horizontal-bt-expected.png: Removed.
- platform/mac-snowleopard/fast/writing-mode/border-image-vertical-lr-expected.png: Removed.
- platform/mac-snowleopard/fast/writing-mode/border-image-vertical-rl-expected.png: Removed.
- platform/mac-snowleopard/fast/writing-mode/fallback-orientation-expected.png: Removed.
- platform/mac-snowleopard/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Removed.
- platform/mac-snowleopard/fast/xsl/sort-locale-expected.txt: Removed.
- platform/mac-snowleopard/fonts/cursive-expected.png: Removed.
- platform/mac-snowleopard/fonts/default-expected.png: Removed.
- platform/mac-snowleopard/fonts/fantasy-expected.png: Removed.
- platform/mac-snowleopard/fonts/monospace-expected.png: Removed.
- platform/mac-snowleopard/fonts/sans-serif-expected.png: Removed.
- platform/mac-snowleopard/fonts/serif-expected.png: Removed.
- platform/mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png: Removed.
- platform/mac-snowleopard/http/tests/inspector/resource-har-conversion-expected.txt: Removed.
- platform/mac-snowleopard/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Removed.
- platform/mac-snowleopard/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Removed.
- platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps/012-expected.txt: Removed.
- platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps/013-expected.txt: Removed.
- platform/mac-snowleopard/media/controls-layout-direction-expected.png: Removed.
- platform/mac-snowleopard/media/controls-strict-expected.png: Removed.
- platform/mac-snowleopard/media/controls-strict-expected.txt: Removed.
- platform/mac-snowleopard/media/controls-styling-expected.txt: Removed.
- platform/mac-snowleopard/media/controls-without-preload-expected.txt: Removed.
- platform/mac-snowleopard/media/media-can-play-wav-audio-expected.txt: Removed.
- platform/mac-snowleopard/media/media-document-audio-repaint-expected.png: Removed.
- platform/mac-snowleopard/media/video-aspect-ratio-expected.png: Removed.
- platform/mac-snowleopard/media/video-canvas-alpha-expected.png: Removed.
- platform/mac-snowleopard/media/video-colorspace-yuv420-expected.png: Removed.
- platform/mac-snowleopard/media/video-colorspace-yuv422-expected.png: Removed.
- platform/mac-snowleopard/media/video-controls-rendering-expected.png: Removed.
- platform/mac-snowleopard/media/video-controls-rendering-expected.txt: Removed.
- platform/mac-snowleopard/media/video-display-toggle-expected.png: Removed.
- platform/mac-snowleopard/media/video-display-toggle-expected.txt: Removed.
- platform/mac-snowleopard/media/video-frame-accurate-seek-expected.png: Removed.
- platform/mac-snowleopard/media/video-layer-crash-expected.png: Removed.
- platform/mac-snowleopard/media/video-no-audio-expected.png: Removed.
- platform/mac-snowleopard/media/video-no-audio-expected.txt: Removed.
- platform/mac-snowleopard/media/video-playing-and-pause-expected.png: Removed.
- platform/mac-snowleopard/media/video-size-intrinsic-scale-expected.txt: Removed.
- platform/mac-snowleopard/media/video-zoom-expected.png: Removed.
- platform/mac-snowleopard/platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt: Removed.
- platform/mac-snowleopard/platform/mac/editing/selection/25228-expected.png: Removed.
- platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Removed.
- platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Removed.
- platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Removed.
- platform/mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Removed.
- platform/mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Removed.
- platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Removed.
- platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Removed.
- platform/mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.png: Removed.
- platform/mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.txt: Removed.
- platform/mac-snowleopard/platform/mac/scrollbars/key-window-not-first-responder-expected.png: Removed.
- platform/mac-snowleopard/plugins/mouse-click-plugin-clears-selection-expected.png: Removed.
- platform/mac-snowleopard/printing/compositing-layer-printing-expected.png: Removed.
- platform/mac-snowleopard/printing/media-queries-print-expected.png: Removed.
- platform/mac-snowleopard/printing/page-rule-in-media-query-expected.png: Removed.
- platform/mac-snowleopard/printing/return-from-printing-mode-expected.png: Removed.
- platform/mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png: Removed.
- platform/mac-snowleopard/scrollbars/scrollbars-on-positioned-content-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-11-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-25-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-27-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-32-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/color-prof-01-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-01-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/interact-order-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/interact-order-02-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/linking-a-04-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/linking-a-05-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/linking-a-07-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/linking-uri-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/masking-path-03-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/masking-path-05-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/painting-render-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-02-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-04-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-05-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-08-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-10-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-15-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/script-handle-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-dom-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-frag-06-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-06-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-08-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-use-03-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/styling-css-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/styling-css-02-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/styling-css-03-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/styling-css-04-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-deco-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-path-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-text-03-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-text-04-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-text-05-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-text-06-t-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-text-08-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-tref-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-tselect-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Removed.
- platform/mac-snowleopard/svg/as-background-image/svg-as-background-1-expected.png: Removed.
- platform/mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png: Removed.
- platform/mac-snowleopard/svg/as-background-image/svg-as-background-6-expected.png: Removed.
- platform/mac-snowleopard/svg/as-background-image/svg-background-partial-redraw-expected.png: Removed.
- platform/mac-snowleopard/svg/as-border-image/svg-as-border-image-2-expected.png: Removed.
- platform/mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Removed.
- platform/mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png: Removed.
- platform/mac-snowleopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Removed.
- platform/mac-snowleopard/svg/as-image/animated-svg-as-image-same-image-expected.png: Removed.
- platform/mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Removed.
- platform/mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png: Removed.
- platform/mac-snowleopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Removed.
- platform/mac-snowleopard/svg/as-object/embedded-svg-size-changes-expected.png: Removed.
- platform/mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-expected.png: Removed.
- platform/mac-snowleopard/svg/batik/paints/gradientLimit-expected.png: Removed.
- platform/mac-snowleopard/svg/carto.net/button-expected.png: Removed.
- platform/mac-snowleopard/svg/carto.net/colourpicker-expected.png: Removed.
- platform/mac-snowleopard/svg/carto.net/combobox-expected.png: Removed.
- platform/mac-snowleopard/svg/carto.net/scrollbar-expected.png: Removed.
- platform/mac-snowleopard/svg/carto.net/selectionlist-expected.png: Removed.
- platform/mac-snowleopard/svg/carto.net/slider-expected.png: Removed.
- platform/mac-snowleopard/svg/carto.net/tabgroup-expected.png: Removed.
- platform/mac-snowleopard/svg/carto.net/textbox-expected.png: Removed.
- platform/mac-snowleopard/svg/carto.net/window-expected.png: Removed.
- platform/mac-snowleopard/svg/clip-path/clip-path-pixelation-expected.png: Removed.
- platform/mac-snowleopard/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Removed.
- platform/mac-snowleopard/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
- platform/mac-snowleopard/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
- platform/mac-snowleopard/svg/css/arrow-with-shadow-expected.png: Removed.
- platform/mac-snowleopard/svg/css/composite-shadow-text-expected.png: Removed.
- platform/mac-snowleopard/svg/css/css-box-min-width-expected.png: Removed.
- platform/mac-snowleopard/svg/css/group-with-shadow-expected.png: Removed.
- platform/mac-snowleopard/svg/css/path-gradient-stroke-shadow-expected.png: Removed.
- platform/mac-snowleopard/svg/css/rect-gradient-stroke-shadow-expected.png: Removed.
- platform/mac-snowleopard/svg/css/shadow-changes-expected.png: Removed.
- platform/mac-snowleopard/svg/css/shadow-with-large-radius-expected.png: Removed.
- platform/mac-snowleopard/svg/css/shadow-with-negative-offset-expected.png: Removed.
- platform/mac-snowleopard/svg/css/text-gradient-shadow-expected.png: Removed.
- platform/mac-snowleopard/svg/css/text-shadow-multiple-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/SVGMatrix-interface-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/absolute-sized-content-with-resources-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/absolute-sized-svg-in-xhtml-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/altglyph-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/baseval-animval-equality-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/bug45331-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/circle-move-invalidation-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/clip-path-referencing-use-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/clip-path-referencing-use2-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/clone-element-with-animated-svg-properties-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/container-opacity-clip-viewBox-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/convolution-crash-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/coords-relative-units-transforms-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/createImageElement-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/createImageElement2-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/dominant-baseline-hanging-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/dynamic-svg-document-creation-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/embedding-external-svgs-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/empty-clip-path-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/empty-merge-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/feDisplacementMap-01-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/fill-SVGPaint-interface-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/fill-fallback-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/focus-ring-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/font-face-cascade-order-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/font-face-simple-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/foreign-object-skew-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/foreignObject-crash-on-hover-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/getPresentationAttribute-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/getTransformToElement-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/getscreenctm-in-mixed-content-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/getsvgdocument-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/glyph-selection-arabic-forms-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/glyph-selection-lang-attribute-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/glyph-selection-non-bmp-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/gradient-cycle-detection-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/gradient-deep-referencing-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/gradient-rotated-bbox-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/gradient-stroke-width-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/gradient-with-1d-boundingbox-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/grayscale-gradient-mask-2-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/group-opacity-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/hit-test-path-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/hit-test-path-stroke-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/hit-test-unclosed-subpaths-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/hit-test-with-br-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/image-parent-translation-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/image-rescale-clip-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/image-rescale-scroll-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/image-small-width-height-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/invalid-fill-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/invalid-fill-hex-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/invalid-lengthlist-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/invalid-stroke-hex-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/invalid-uri-stroke-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/invisible-text-after-scrolling-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/js-update-image-and-display-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/js-update-image-and-display2-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/js-update-image-and-display3-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/js-update-stop-linked-gradient-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/junk-data-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/linking-a-03-b-viewTarget-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/linking-a-03-b-zoomAndPan-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/marker-opacity-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/marker-overflow-clip-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/mask-invalidation-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/missing-xlink-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/mouse-move-on-svg-container-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/mouse-move-on-svg-root-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/no-inherited-dashed-stroke-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/non-opaque-filters-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/non-scaling-stroke-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/object-sizing-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/path-bad-data-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/path-textPath-simulation-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/pattern-cycle-detection-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/pattern-deep-referencing-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/pattern-incorrect-tiling-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/pattern-rotate-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/pattern-rotate-gaps-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/percentage-of-html-parent-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/pointer-events-image-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/pointer-events-path-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/pointer-events-text-css-transform-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/pointer-events-text-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/recursive-clippath-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/recursive-filter-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/recursive-gradient-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/recursive-mask-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/recursive-pattern-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/relative-sized-content-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/relative-sized-content-with-resources-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/relative-sized-deep-shadow-tree-content-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/relative-sized-image-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/relative-sized-inner-svg-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/relative-sized-shadow-tree-content-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/relative-sized-use-on-symbol-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/resource-invalidate-on-target-update-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/rootmost-svg-xy-attrs-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/second-inline-text-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/shape-rendering-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/shapes-supporting-markers-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/simple-text-double-shadow-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/simpleCDF-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/stroke-fallback-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/stroke-width-large-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/stroked-pattern-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/style-attribute-font-size-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/svg-curve-with-relative-cordinates-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/svg-float-border-padding-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/svg-fonts-without-missing-glyph-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/svg-overflow-types-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/text-decoration-visibility-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/text-dom-01-f-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/text-filter-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/text-image-opacity-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/text-linking-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/text-xy-updates-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-clipped-hit-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-css-no-effect-on-shadow-tree-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt: Removed.
- platform/mac-snowleopard/svg/custom/use-dynamic-append-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-elementInstance-methods-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-event-handler-on-referenced-element-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-event-handler-on-use-element-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-events-crash-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-font-face-crash-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-instanceRoot-event-bubbling-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-instanceRoot-event-listeners-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-on-symbol-inside-pattern-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-property-changes-through-dom-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-property-changes-through-svg-dom-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/viewport-em-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/visibility-override-filter-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/zero-path-square-cap-rendering2-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGLengthList-appendItem-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGLengthList-basics-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGLengthList-getItem-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGLengthList-initialize-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGLengthList-insertItemBefore-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGLengthList-removeItem-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGLengthList-replaceItem-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGNumberList-basics-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGPathSegList-appendItem-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGPathSegList-cloning-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGPathSegList-removeItem-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGPathSegList-replaceItem-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGPathSegList-segment-modification-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGPointList-basics-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGStringList-basics-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png: Removed.
- platform/mac-snowleopard/svg/dom/css-transforms-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/animate-fill-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/big-sized-filter-2-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/big-sized-filter-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feColorMatrix-default-type-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feColorMatrix-offset-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feColorMatrix-saturate-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feColorMatrix-values-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feComposite-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feConvolveFilter-y-bounds-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feDisplacementMap-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feDropShadow-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feGaussianBlur-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-late-indirect-update-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-multiple-targets-id-change-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-position-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-preserveAspectratio-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-reference-invalidation-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-reference-svg-primitive-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-subregions-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-target-add-to-document-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-target-attribute-change-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-target-changes-id-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-target-id-change-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-target-inline-style-change-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-target-property-change-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-target-reappend-to-document-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-target-remove-from-document-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feImage-target-style-change-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feLighting-crash-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feMerge-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feOffset-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/feTile-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/filter-clip-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/filter-on-tspan-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/filter-placement-issue-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/filter-refresh-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/filter-rounding-issues-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/filter-source-position-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/filter-width-update-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/filterRes-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/filterRes1-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/filterRes2-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/filterRes3-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/filteredImage-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/parent-children-with-same-filter-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/shadow-on-filter-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/shadow-on-rect-with-filter-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/sourceAlpha-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/subRegion-in-userSpace-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/subRegion-one-effect-expected.png: Removed.
- platform/mac-snowleopard/svg/filters/subRegion-two-effects-expected.png: Removed.
- platform/mac-snowleopard/svg/foreignObject/fO-parent-display-changes-expected.png: Removed.
- platform/mac-snowleopard/svg/foreignObject/filter-expected.png: Removed.
- platform/mac-snowleopard/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Removed.
- platform/mac-snowleopard/svg/foreignObject/svg-document-as-direct-child-expected.png: Removed.
- platform/mac-snowleopard/svg/foreignObject/svg-document-in-html-document-expected.png: Removed.
- platform/mac-snowleopard/svg/foreignObject/text-tref-02-b-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/data-types/002-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/error/002-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/error/012-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/error/013-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/intrinsic/001-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/intrinsic/002-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/intrinsic/003-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/mixed/003-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/mixed/006-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/mixed/007-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/mixed/008-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/mixed/009-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/mixed/010-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/mixed/011-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/perf/001-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/perf/002-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/perf/005-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/perf/006-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/perf/007-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/processing-model/003-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/processing-model/004-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/rendering-model/003-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/rendering-model/004-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/text/003-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/viewbox/001-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/viewbox/002-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/viewbox/preserveAspectRatio/001-expected.png: Removed.
- platform/mac-snowleopard/svg/hixie/viewbox/preserveAspectRatio/002-expected.png: Removed.
- platform/mac-snowleopard/svg/in-html/circle-expected.png: Removed.
- platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Removed.
- platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Removed.
- platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Removed.
- platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Removed.
- platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Removed.
- platform/mac-snowleopard/svg/repaint/filter-child-repaint-expected.png: Removed.
- platform/mac-snowleopard/svg/repaint/filter-repaint-expected.png: Removed.
- platform/mac-snowleopard/svg/repaint/image-with-clip-path-expected.png: Removed.
- platform/mac-snowleopard/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Removed.
- platform/mac-snowleopard/svg/text/bidi-text-query-expected.png: Removed.
- platform/mac-snowleopard/svg/text/font-size-below-point-five-2-expected.png: Removed.
- platform/mac-snowleopard/svg/text/foreignObject-text-clipping-bug-expected.png: Removed.
- platform/mac-snowleopard/svg/text/kerning-expected.png: Removed.
- platform/mac-snowleopard/svg/text/multichar-glyph-expected.png: Removed.
- platform/mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.png: Removed.
- platform/mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.txt: Removed.
- platform/mac-snowleopard/svg/text/scaling-font-with-geometric-precision-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-textLength-spacing-squeeze-1-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-textLength-spacing-squeeze-2-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-textLength-spacing-squeeze-3-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-textLength-spacing-squeeze-4-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-textLength-spacing-stretch-1-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-textLength-spacing-stretch-2-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-textLength-spacing-stretch-3-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-textLength-spacing-stretch-4-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-x-list-1-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-x-list-2-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-x-list-3-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-x-list-4-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-x-list-with-tspans-1-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-x-list-with-tspans-2-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-x-list-with-tspans-3-expected.png: Removed.
- platform/mac-snowleopard/svg/text/select-x-list-with-tspans-4-expected.png: Removed.
- platform/mac-snowleopard/svg/text/selection-background-color-expected.png: Removed.
- platform/mac-snowleopard/svg/text/selection-styles-expected.png: Removed.
- platform/mac-snowleopard/svg/text/small-fonts-2-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-align-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-align-02-b-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-align-03-b-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-align-04-b-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-align-05-b-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-align-06-b-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-altglyph-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-deco-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-fill-opacity-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-fonts-01-t-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-intro-05-t-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-intro-05-t-expected.txt: Removed.
- platform/mac-snowleopard/svg/text/text-overflow-ellipsis-svgfont-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-path-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-repaint-rects-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-spacing-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-text-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-text-03-b-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-text-04-t-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-text-05-t-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-text-06-t-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-text-07-t-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-text-08-b-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-tselect-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-tselect-02-f-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-tspan-01-b-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-ws-01-t-expected.png: Removed.
- platform/mac-snowleopard/svg/text/text-ws-02-t-expected.png: Removed.
- platform/mac-snowleopard/svg/text/textPathBoundsBug-expected.png: Removed.
- platform/mac-snowleopard/svg/text/tspan-dynamic-positioning-expected.png: Removed.
- platform/mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png: Removed.
- platform/mac-snowleopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Removed.
- platform/mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed.
- platform/mac-snowleopard/svg/webarchive/svg-cursor-subresources-expected.png: Removed.
- platform/mac-snowleopard/svg/webarchive/svg-feimage-subresources-expected.png: Removed.
- platform/mac-snowleopard/svg/wicd/rightsizing-grid-expected.png: Removed.
- platform/mac-snowleopard/svg/wicd/test-rightsizing-a-expected.png: Removed.
- platform/mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png: Removed.
- platform/mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png: Removed.
- platform/mac-snowleopard/svg/wicd/test-scalable-background-image2-expected.png: Removed.
- platform/mac-snowleopard/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Removed.
- platform/mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
- platform/mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png: Removed.
- platform/mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
- platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Removed.
- platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Removed.
- platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Removed.
- platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Removed.
- platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug10269-2-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug1055-1-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug1163-1-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug119786-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug1302-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug222846-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug2479-1-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug2479-4-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug29058-3-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug2947-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug3977-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug5797-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug5835-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug5838-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug625-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug6304-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug650-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug7112-1-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs/bug7112-2-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-3-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/core/bloomberg-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/core/captions-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/core/cell_heights-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/core/col_widths_auto_fix-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/core/col_widths_fix_fixPer-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/core/nested1-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/core/one_row-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/core/row_span-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_index-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_position-table-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin/table_frame_border-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin/table_frame_box-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin/x_caption_class-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin/x_caption_id-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin/x_caption_style-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/other/cell_widths-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/other/nestedTables-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/other/test3-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/other/test6-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/other/wa_table_thtd_rowspan-expected.png: Removed.
- platform/mac-snowleopard/tables/mozilla/other/wa_table_tr_align-expected.png: Removed.
- platform/mac-snowleopard/transforms/2d/hindi-rotated-expected.png: Removed.
- platform/mac-snowleopard/transforms/2d/transform-fixed-container-expected.png: Removed.
- platform/mac-snowleopard/transforms/3d/general/perspective-units-expected.png: Removed.
- platform/mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Removed.
- platform/mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png: Removed.
- platform/mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Removed.
- platform/mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Removed.
- platform/mac-snowleopard/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Removed.
- platform/mac-snowleopard/webarchive/test-css-url-resources-in-stylesheets-expected.png: Removed.
- platform/mac-snowleopard/webarchive/test-link-rel-icon-beforeload-expected.png: Removed.
- 4:34 PM Changeset in webkit [148646] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed. Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 4:29 PM Changeset in webkit [148645] by
-
- 4 edits in trunk/Source/WebCore
BasicShapeFunctions should use RenderStyle instead of StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=114743
Reviewed by Antti Koivisto.
BasicShapeFunctions does include RenderStyle instead of StyleResolver now.
This is a simple refactoring patch, no new tests.
- css/BasicShapeFunctions.cpp:
(WebCore::convertToLength): Use style and rootElementStyle directly.
(WebCore::basicShapeForValue): Ditto.
- css/BasicShapeFunctions.h:
(WebCore):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyExclusionShape::applyValue):
- 4:24 PM Changeset in webkit [148644] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][AC] m_pendingSurfaceResize needs to be guarded by USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=114770
AC related code is guarded by USE(ACCELERATED_COMPOSITING) in order to build
WebKitEfl with no-tiled-backing-store(r147792), but m_pendingSurfaceResize is
not included. This patch allows m_pendingSurfaceResize to be guarded by
USE(ACCELERATED_COMPOSITING).
Reviewed by Simon Fraser.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::displayTimerFired):
(EwkView::handleEvasObjectCalculate):
- UIProcess/API/efl/EwkView.h:
(EwkView):
- 4:23 PM Changeset in webkit [148643] by
-
- 5 edits3 adds in trunk
Content inside frames and scrollbars in overflow areas hit-tests incorrectly when
the WKView has a header
https://bugs.webkit.org/show_bug.cgi?id=114769
Reviewed by Simon Fraser.
Source/WebCore:
convertToRenderer() and convertFromRenderer() need to factor in the headerHeight,
much like all of the conversion functions on ScrollView.
- page/FrameView.cpp:
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
The scrollPosition equivalent of the existing scrollOffsetRelativeToDocument()
function.
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollPositionRelativeToDocument):
- platform/ScrollView.h:
(ScrollView):
LayoutTests:
- platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-in-frame-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-in-frame.html: Added.
- platform/mac-wk2/tiled-drawing/resources/iframe-to-hit-test.html: Added.
- 4:01 PM Changeset in webkit [148642] by
-
- 2 edits in trunk/Source/WebCore
Remove FragmentScriptingPermission.h include from Element.h.
<http://webkit.org/b/114757>
Rubber-stamped by Anders Carlsson.
- dom/Element.h:
- 3:57 PM Changeset in webkit [148641] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix broken build. Replaced a static const with a #define.
https://bugs.webkit.org/show_bug.cgi?id=114577.
Unreviewed.
- runtime/Watchdog.cpp:
(JSC::Watchdog::Watchdog):
(JSC::Watchdog::isEnabled):
- 3:38 PM Changeset in webkit [148640] by
-
- 2 edits in trunk/LayoutTests
Unskip some tests for wk2 where the underlying cause of them being skipped has since been
fixed or the original issue does not reproduce.
- platform/wk2/TestExpectations:
- 3:37 PM Changeset in webkit [148639] by
-
- 34 edits4 adds1 delete in trunk/Source
Source/JavaScriptCore: Add LLINT and baseline JIT support for timing out scripts.
https://bugs.webkit.org/show_bug.cgi?id=114577.
Reviewed by Geoffrey Garen.
Introduces the new Watchdog class which is used to track script
execution time, and initiate script termination if needed.
- API/JSContextRef.cpp:
(internalScriptTimeoutCallback):
(JSContextGroupSetExecutionTimeLimit):
(JSContextGroupClearExecutionTimeLimit):
- API/JSContextRefPrivate.h:
- Added new script execution time limit APIs.
- API/tests/testapi.c:
(currentCPUTime):
(shouldTerminateCallback):
(cancelTerminateCallback):
(extendTerminateCallback):
(main):
- Added new API tests for script execution time limit.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitLoopHint):
- loop hints are needed for the llint as well. Hence, it will be emitted unconditionally.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
- Added checks for script termination before entering script code.
- jit/JIT.cpp:
(JSC::JIT::emitWatchdogTimerCheck):
- jit/JIT.h:
(JSC::JIT::emit_op_loop_hint):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION(void, handle_watchdog_timer)):
- jit/JITStubs.h:
- llint/LLIntExceptions.cpp:
(JSC::LLInt::doThrow):
- Factored out some common code from returnToThrow() and callToThrow().
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL(slow_path_handle_watchdog_timer)):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/ExceptionHelpers.cpp:
(JSC::throwTerminatedExecutionException):
- Also removed the now unused InterruptedExecutionException.
- runtime/ExceptionHelpers.h:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
- Added watchdog, and removed the now obsolete Terminator.
- runtime/Terminator.h: Removed.
- runtime/Watchdog.cpp: Added.
(JSC::Watchdog::Watchdog):
(JSC::Watchdog::~Watchdog):
(JSC::Watchdog::setTimeLimit):
(JSC::Watchdog::didFire):
(JSC::Watchdog::isEnabled):
(JSC::Watchdog::fire):
(JSC::Watchdog::arm):
(JSC::Watchdog::disarm):
(JSC::Watchdog::startCountdownIfNeeded):
(JSC::Watchdog::startCountdown):
(JSC::Watchdog::stopCountdown):
(JSC::Watchdog::Scope::Scope):
(JSC::Watchdog::Scope::~Scope):
- runtime/Watchdog.h: Added.
(Watchdog):
(JSC::Watchdog::didFire):
(JSC::Watchdog::timerDidFireAddress):
(JSC::Watchdog::isArmed):
(Watchdog::Scope):
- runtime/WatchdogMac.cpp: Added.
(JSC::Watchdog::initTimer):
(JSC::Watchdog::destroyTimer):
(JSC::Watchdog::startTimer):
(JSC::Watchdog::stopTimer):
- runtime/WatchdogNone.cpp: Added.
(JSC::Watchdog::initTimer):
(JSC::Watchdog::destroyTimer):
(JSC::Watchdog::startTimer):
(JSC::Watchdog::stopTimer):
Source/WebCore: Add LLINT and baseline JIT support for timing out scripts.
https://bugs.webkit.org/show_bug.cgi?id=114577.
Reviewed by Geoffrey Garen.
Replaced use of the obsolete JSGlobalData.terminator methods with the
JSGlobalData.watchdog equivalents.
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::maybeThrowExceptionIfSerializationFailed):
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::scheduleExecutionTermination):
(WebCore::WorkerScriptController::isExecutionTerminating):
Source/WTF: Added currentCPUTime() and currentCPUTimeMS().
https://bugs.webkit.org/show_bug.cgi?id=114577.
Reviewed by Geoffrey Garen.
The currentCPUTime() implementation came from the old TimeoutChecker.cpp.
- wtf/CurrentTime.cpp:
(WTF::currentCPUTime):
(WTF::currentCPUTimeMS):
- wtf/CurrentTime.h:
- 2:30 PM Changeset in webkit [148638] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. VS2010 Windows build fix.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd:
- 2:23 PM Changeset in webkit [148637] by
-
- 2 edits in trunk/LayoutTests
Remove more tests from the Skipped list that were skipped early on with a bunch of eventSender
related tests and then not unskipped when various parts of eventSender got implemented in
WebKitTestRunner.
- platform/mac-wk2/TestExpectations:
- 2:15 PM Changeset in webkit [148636] by
-
- 3 edits in trunk/Source/WebCore
Crash in WebCore::HTMLMediaElement::~HTMLMediaElement.
https://bugs.webkit.org/show_bug.cgi?id=113531
Reviewed by Eric Carlson.
No new tests, though this is intermittently reproducible with
http/tests/misc/delete-frame-during-readystatechange.html under ASAN.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement): Clear the media player manually
before the destructor exits. Clearing the media player may cancel a resource load,
which can trigger a readystatechange event. It's possible for the HTMLMediaElement
to attempt to fire an abort event within the readystatechange event, even though it is
now in an inconsistent state. Clearling the media player before finishing the destructor
ensures that the HTMLMediaElement will at least still be alive if this case is triggered.
Set m_completelyLoaded to true to ensure that if userCancelledLoad() is called, it doesn't
attempt to fire events while destructing.
- 2:14 PM Changeset in webkit [148635] by
-
- 3 edits in trunk/Source/WebKit/blackberry
Clean up spellcheck state when changing focus.
https://bugs.webkit.org/show_bug.cgi?id=114758
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-04-17
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton and Gen Mak.
PR325941
If we lose focus while waiting for a spellcheck request to return, we will
never see the reply and continue to queue up future requests. By clearing
the queue we ensure that all requests being processed and waiting to fire
are valid.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
- WebKitSupport/SpellingHandler.cpp:
(BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
- 2:13 PM Changeset in webkit [148634] by
-
- 5 edits in trunk/Source/WebKit2
The storage manager should know the local storage directory
https://bugs.webkit.org/show_bug.cgi?id=114765
Reviewed by Beth Dakin.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::create):
(WebKit::StorageManager::setLocalStorageDirectory):
(WebKit::StorageManager::setLocalStorageDirectoryInternal):
- UIProcess/Storage/StorageManager.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::setLocalStorageDirectory):
- UIProcess/WebContext.h:
- 1:51 PM Changeset in webkit [148633] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][AC] MiniBrowser starts with a black empty view before painting a web page
https://bugs.webkit.org/show_bug.cgi?id=103745
Reviewed by Kenneth Rohde Christiansen.
Evas paints empty evas objects before rendering a web page, so it shows
a black empty view for a moment. This patch prevents from painting the empty
evas objects until a GL surface is ready for rendering.
- UIProcess/API/efl/EwkView.cpp:
(showEvasObjectsIfNeeded):
(EwkView::displayTimerFired):
(EwkView::handleEvasObjectShow):
- 1:40 PM Changeset in webkit [148632] by
-
- 2 edits in trunk/Tools
[Dashboard] Remove code for showing 'WebKit roll' annotations in timelines for Chromium builders
https://bugs.webkit.org/show_bug.cgi?id=114755
Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-04-17
Reviewed by Ryosuke Niwa.
The Chromium builders are no longer available to inspect so there's no need for the code that used to show
the 'WebKit roll' annotations in the Chromium builders' timeline.
- TestResultServer/static-dashboards/timeline_explorer.js:
- 1:39 PM Changeset in webkit [148631] by
-
- 2 edits in trunk/Tools
[Dashboard] Clean up the timeline updating code, removing Chromium-specific cases
https://bugs.webkit.org/show_bug.cgi?id=114756
Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-04-17
Reviewed by Ryosuke Niwa.
Clean up the updating of the timeline in the timeline explorer, defaulting to the webkit.org build master when
constructing the results URL and removing the possible row addition containing the Chromium commit range that
only applied to Chromium builders in the first place. Also removes the now-redundant shouldShowWebKitRevisionsOnly
method.
- TestResultServer/static-dashboards/timeline_explorer.js:
- 1:14 PM Changeset in webkit [148630] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: make generate-inspector-protocol-version work with python3
https://bugs.webkit.org/show_bug.cgi?id=114717
Revision r146765 added print() calls that made the script complain about
invalid syntax when using python3.
This commit replaces such calls with calls to sys.stdout.write(), analogous
to the sys.stderr.write() ones already used throughout the file.
Patch by Sergio Correia <Sergio Correia> on 2013-04-17
Reviewed by Timothy Hatcher.
No new tests. No user visible behavior changed.
- inspector/generate-inspector-protocol-version:
(main):
- 1:11 PM Changeset in webkit [148629] by
-
- 2 edits in trunk/LayoutTests
Remove some tests from the Skipped list that were skipped early on with a bunch of eventSender
related tests and then not unskipped when various parts of eventSender got implemented in
WebKitTestRunner.
- platform/mac-wk2/TestExpectations:
- 1:02 PM Changeset in webkit [148628] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Fix Localized string warngs
https://bugs.webkit.org/show_bug.cgi?id=114718
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-17
Reviewed by Timothy Hatcher.
No tests because no behavior change is expected.
- English.lproj/localizedStrings.js:
- 12:42 PM WebKit Team edited by
- (diff)
- 12:28 PM Changeset in webkit [148627] by
-
- 8 edits2 copies in trunk/Source
Copy make-file-export-generator script to the the Source folders of the projects that use it.
<rdar://problem/13675604>
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.filters:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorBuildCmd.cmd:
- WebKit.vcxproj/WebKitExportGenerator/make-export-file-generator: Copied from Source/WebCore/make-export-file-generator.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.filters:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorBuildCmd.cmd:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/make-export-file-generator: Copied from Source/WebCore/make-export-file-generator.
- 12:17 PM Changeset in webkit [148626] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Unreviewed Windows buildfix.
- platform/qt/DragDataQt.cpp: Add a missing include.
- 12:14 PM Changeset in webkit [148625] by
-
- 2 edits in trunk/Source/WTF
REGRESSION(r148584): WebKit nightly builds don't load any page
https://bugs.webkit.org/show_bug.cgi?id=114752
Reviewed by Anders Carlsson.
We can't use C++ style () comments in Platform.h because WebKit2/DerivedSource.make doesn't know
how to strip it to be merged with *.sb.in to generate *.sb files. Specifically, we have:
# Some versions of clang incorrectly strip out comments in c89 code.
# Use -traditional as a workaround, but only when needed since that causes
# other problems with later versions of clang.
ifeq ($(shell echo 'x' | $(CC) -E -P -x c -std=c89 - | grep x),)
TEXT_PREPROCESSOR_FLAGS=-E -P -x c -traditional -w
else
TEXT_PREPROCESSOR_FLAGS=-E -P -x c -std=c89 -w
endif
- wtf/Platform.h:
- 12:14 PM Changeset in webkit [148624] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Check image node with usemap attribute isLink failed
https://bugs.webkit.org/show_bug.cgi?id=114751
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-17
Reviewed by Rob Buis.
PR 326780
Internally Reviewed by Liam Quinn.
An image node with usemap will crash when call isLink.
If the node is linkNode, bring up the CCM(eg. linked image).
Also use toElement method as agomes suggested in pr 113957.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::findBestPoint):
- 11:58 AM Changeset in webkit [148623] by
-
- 4 edits in trunk/Source/WTF
[Windows, WinCairo] Remove Include Settings for Pthreads from WTF
https://bugs.webkit.org/show_bug.cgi?id=114694
Reviewed by Ryosuke Niwa.
- WTF.vcproj/WTFCommon.vsprops: Remove pthread search path.
- WTF.vcxproj/WTFCommon.props: Remove pthread search path.
- wtf/FastMalloc.cpp: Guard pthread.h include for non-pthread
builds.
- 11:48 AM Changeset in webkit [148622] by
-
- 7 edits19 adds in trunk
Breaking Float: floated block level element following inline element in floated container breaks to next line
https://bugs.webkit.org/show_bug.cgi?id=45274
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-17
Reviewed by David Hyatt.
Source/WebCore:
Fix position issue of floating element in floating element.
Inner floating element has placed at next line when outer floating element has text,
even though previous line has spaces enough to fit it.
To solve this, the width of a space added temporarily for prohibiting duplication more than 2 empty spaces
is subtracted when floating element is checked whether it fits on a line.
Tests: css2.1/20110323/floats-001.html
css2.1/20110323/floats-102.html
fast/inline-block/float-both-whitespace.html
fast/inline-block/float-leading-whitespace.html
fast/inline-block/float-no-whitespace.html
fast/inline-block/float-trailing-whitespace.html
fast/inline-block/multiple-floats-with-whitespace.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::trailingWhitespaceWidth):
(WebCore::LineWidth::setTrailingWhitespaceWidth):
(LineWidth):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests:
- css2.1/20110323/floats-001-expected.html: Added.
- css2.1/20110323/floats-001.html: Added.
- css2.1/20110323/floats-102-expected.html: Added.
- css2.1/20110323/floats-102.html: Added.
Tests for whitespace around floating elements.
Following test cases are provied by Joseph Pecoraro.
See https://bugs.webkit.org/show_bug.cgi?id=58806
- fast/exclusions/shape-outside-floats/shape-outside-floats-stacked.html: Updated to match new treatment of trailing space.
- fast/inline-block/float-both-whitespace-expected.png: Added.
- fast/inline-block/float-both-whitespace-expected.txt: Added.
- fast/inline-block/float-both-whitespace.html: Added.
- fast/inline-block/float-leading-whitespace-expected.png: Added.
- fast/inline-block/float-leading-whitespace-expected.txt: Added.
- fast/inline-block/float-leading-whitespace.html: Added.
- fast/inline-block/float-no-whitespace-expected.png: Added.
- fast/inline-block/float-no-whitespace-expected.txt: Added.
- fast/inline-block/float-no-whitespace.html: Added.
- fast/inline-block/float-trailing-whitespace-expected.png: Added.
- fast/inline-block/float-trailing-whitespace-expected.txt: Added.
- fast/inline-block/float-trailing-whitespace.html: Added.
- fast/inline-block/multiple-floats-with-whitespace-expected.png: Added.
- fast/inline-block/multiple-floats-with-whitespace-expected.txt: Added.
- fast/inline-block/multiple-floats-with-whitespace.html: Added.
Update the following tests so that wrapping happens as it
did before. With this change the float:left div progressed
and could fit on an earlier line when we position after
collapsing whitespace. This moved the float a line earlier
and changed the results of the test. By adding a character
to the line, the float won't fit and goes back on to the
line that it was on before this change.
- fast/multicol/float-truncation.html:
- fast/multicol/vertical-lr/float-truncation.html:
- fast/multicol/vertical-rl/float-truncation.html:
- 11:38 AM Changeset in webkit [148621] by
-
- 7 edits in trunk/Source/WebCore
Lots of unused parameter warnings in filesystem code
https://bugs.webkit.org/show_bug.cgi?id=114747
Reviewed by Carlos Garcia Campos.
Comment out or remove unused parameter identifiers.
No functionalities changed, no new tests.
- Modules/filesystem/DOMFileSystem.cpp: Comment out |snapshot| because
it is referred in the comments inside the function.
(WebCore):
- Modules/filesystem/DOMFileSystemSync.cpp: Ditto.
(WebCore):
- Modules/filesystem/FileWriter.cpp: Remove unused |ec|.
(WebCore::FileWriter::abort):
- Modules/filesystem/FileWriterSync.cpp:
(WebCore::FileWriterSync::didWrite): Remove unused |bytes|.
- platform/AsyncFileSystemCallbacks.h:
(WebCore::AsyncFileSystemCallbacks::didOpenFileSystem): Comment out unused parameters
because the function is inlined.
(WebCore::AsyncFileSystemCallbacks::didCreateSnapshotFile): Ditto.
(WebCore::AsyncFileSystemCallbacks::didReadDirectoryEntry): Ditto.
(WebCore::AsyncFileSystemCallbacks::didReadDirectoryEntries): Ditto.
(WebCore::AsyncFileSystemCallbacks::didCreateFileWriter): Ditto.
- platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread): Remove unused |client|.
- 11:36 AM Changeset in webkit [148620] by
-
- 10 edits in trunk/Source
Source/JavaScriptCore: [Windows, WinCairo] Stop individually building WTF files in JSC.
https://bugs.webkit.org/show_bug.cgi?id=114705
Reviewed by Anders Carlsson.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
Export additional String/fastMalloc symbols needed by JSC program.
- JavaScriptCore.vcproj/jsc/jsc.vcproj: Don't manually build
WTF implementation files (a second time!) in this project.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
Export additional String/fastMalloc symbols needed by JSC program.
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj: Don't manually
build WTF implementation files (a second time!) in this project.
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj.filters: Ditto.
Source/WebCore: [Windows, WinCairo] Stop individually building WTF files in WebCore
https://bugs.webkit.org/show_bug.cgi?id=114705
Reviewed by Anders Carlsson.
- WebCore.vcproj/WebCore.vcproj: Remove references to WTF objects.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto
- 11:27 AM Changeset in webkit [148619] by
-
- 8 edits in trunk/Source/WebCore
Make lengthConversion methods and arguments const
https://bugs.webkit.org/show_bug.cgi?id=114749
Reviewed by Andreas Kling.
Refactoring, no new tests.
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::computeLengthPx):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::CSSCalcBinaryOperation::toCalcValue):
(WebCore::CSSCalcBinaryOperation::computeLengthPx):
- css/CSSCalculationValue.h:
(WebCore::CSSCalcValue::toCalcValue):
(CSSCalcValue):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
(WebCore::CSSPrimitiveValue::viewportPercentageLength):
- css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::convertToIntLength):
(WebCore::StyleResolver::convertToFloatLength):
- css/StyleResolver.h:
(StyleResolver):
- 11:16 AM Changeset in webkit [148618] by
-
- 3 edits in trunk/Source/WebCore
[refactor] Moved ScriptedAnimationController common code to inline function
https://bugs.webkit.org/show_bug.cgi?id=114681
Reviewed by Daniel Bates.
Avoided duplicated code by moving ScriptedAnimationController clearance
code to a common function used by both Document::dispose() and
Document::detach().
No new tests, no behavior changes.
- dom/Document.cpp:
(WebCore::Document::dispose):
(WebCore::Document::detach):
(WebCore::Document::clearScriptedAnimationController): Added.
- dom/Document.h:
(Document):
- 9:42 AM Changeset in webkit [148617] by
-
- 3 edits2 adds in trunk
Source/WebCore: AX: When img@alt is undefined, WebKit should use @title as accessibility label if available
https://bugs.webkit.org/show_bug.cgi?id=114535
Reviewed by Tim Horton.
Don't hide images from Accessibility that have the title attribute on them.
Test: accessibility/empty-image-with-title.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
LayoutTests: When img@alt is undefined, WebKit should use @title as accessibility label if available
https://bugs.webkit.org/show_bug.cgi?id=114535
Reviewed by Tim Horton.
- accessibility/empty-image-with-title-expected.txt: Added.
- accessibility/empty-image-with-title.html: Added.
- 9:32 AM Changeset in webkit [148616] by
-
- 4 edits in trunk/Source/JavaScriptCore
releaseExecutableMemory() should canonicalize cell liveness data before
it scans the GC roots.
https://bugs.webkit.org/show_bug.cgi?id=114733.
Reviewed by Mark Hahnenberg.
- heap/Heap.cpp:
(JSC::Heap::canonicalizeCellLivenessData):
- heap/Heap.h:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::releaseExecutableMemory):
- 9:15 AM Changeset in webkit [148615] by
-
- 2 edits in trunk/Tools
media-stream and xslt are no longer configurable options in the GTK+ port
https://bugs.webkit.org/show_bug.cgi?id=114736
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-17
Reviewed by Martin Robinson.
media-stream support was removed in r145199 and XSLT is a hard
requirement since r145859. Attempting to pass those options to the
configure script, only results in a warning.
- Scripts/webkitdirs.pm:
(buildAutotoolsProject):
- 9:14 AM Changeset in webkit [148614] by
-
- 3 edits2 adds in trunk
getAttribute does not behave correctly for mixed-case attributes on HTML elements
https://bugs.webkit.org/show_bug.cgi?id=105713
Patch by Arpita Bahuguna <a.bah@samsung.com> on 2013-04-17
Reviewed by Andreas Kling.
Source/WebCore:
getAttribute() and getAttributeNode() APIs do not convert the
passed attribute name to lowercase before comparing against the
existing attributes.
The specification however states that the passed name should
be converted to ASCII lowercase before checking for the existence
of the given attribute. [www.w3.org/TR/domcore/#dom-element-getattribute]
Test: fast/dom/Element/getAttribute-case-insensitivity.html
- dom/Element.h:
(WebCore::ElementData::getAttributeItemIndex):
getAttributeItemIndex() accepts a bool param 'shouldIgnoreAttributeCase'
which specifies whether or not the attribute's case should be ignored
before comparison but we don't really convert the passed name to lowercase
before carrying out the comparison.
Thus, when called from APIs such as getAttribute() and getAttributeNode()
which do not explicitally convert the attribute name to lowercase
before calling on this method, it fails to carry out a case-insensitive
search.
Have thus made changes to convert the passed attribute's name to
lowercase if 'shouldIgnoreAttributeCase' is true.
LayoutTests:
- fast/dom/Element/getAttribute-case-insensitivity-expected.txt: Added.
- fast/dom/Element/getAttribute-case-insensitivity.html: Added.
Layout test added for verifying that getAttribute() and getAttributeNode()
APIs convert the passed attribute name to lowercase before comparing
against the existing attributes.
- 8:56 AM Changeset in webkit [148613] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Add support for filesystem: URLs to BlackBerry Media Player.
https://bugs.webkit.org/show_bug.cgi?id=114686
https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=314865
Patch by John Griggs <jgriggs@blackberry.com> on 2013-04-17
Reviewed by Rob Buis.
Translate filesystem: URLs to file:// URLs for use by the media player, but only after the filesystem: URL has been checked for security, etc.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::onError):
(WebCore::MediaPlayerPrivate::onDurationChanged):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
- 8:54 AM Changeset in webkit [148612] by
-
- 434 edits2 copies2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Updating png expected results after r148594.
- platform/qt/compositing/direct-image-compositing-expected.png:
- platform/qt/compositing/geometry/video-fixed-scrolling-expected.png:
- platform/qt/compositing/overflow/overflow-compositing-descendant-expected.png:
- platform/qt/compositing/overflow/scroll-ancestor-update-expected.png:
- platform/qt/compositing/reflections/nested-reflection-transformed-expected.png:
- platform/qt/compositing/self-painting-layers-expected.png:
- platform/qt/compositing/shadows/shadow-drawing-expected.png:
- platform/qt/css1/basic/inheritance-expected.png:
- platform/qt/css1/box_properties/acid_test-expected.png:
- platform/qt/css1/box_properties/clear_float-expected.png:
- platform/qt/css1/box_properties/float_on_text_elements-expected.png:
- platform/qt/css1/box_properties/margin_right-expected.png:
- platform/qt/css1/box_properties/padding_right-expected.png:
- platform/qt/css1/box_properties/width-expected.png:
- platform/qt/css1/color_and_background/background_attachment-expected.png:
- platform/qt/css1/font_properties/font_size-expected.png:
- platform/qt/css1/font_properties/font_weight-expected.png:
- platform/qt/css1/formatting_model/inline_elements-expected.png:
- platform/qt/css1/formatting_model/vertical_formatting-expected.png:
- platform/qt/css1/text_properties/text_indent-expected.png:
- platform/qt/css1/units/percentage_units-expected.png:
- platform/qt/css2.1/20110323/empty-inline-002-expected.png:
- platform/qt/css2.1/20110323/floating-replaced-height-008-expected.png:
- platform/qt/css2.1/20110323/inline-block-replaced-height-008-expected.png:
- platform/qt/css2.1/20110323/inline-non-replaced-width-001-expected.png:
- platform/qt/css2.1/20110323/inline-non-replaced-width-002-expected.png:
- platform/qt/css2.1/20110323/inline-replaced-height-008-expected.png:
- platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
- platform/qt/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
- platform/qt/css2.1/t09-c5526c-display-00-e-expected.png:
- platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
- platform/qt/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
- platform/qt/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
- platform/qt/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
- platform/qt/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
- platform/qt/css2.1/t1506-c525-font-wt-00-b-expected.png:
- platform/qt/css2.1/t1508-c527-font-09-b-expected.png:
- platform/qt/css3/filters/custom/custom-filter-clamp-css-color-matrix-expected.png: Copied from LayoutTests/platform/qt/printing/return-from-printing-mode-expected.png.
- platform/qt/css3/filters/custom/custom-filter-nonseparable-blend-mode-luminosity-expected.png: Copied from LayoutTests/platform/qt/fast/block/float/overhanging-tall-block-expected.png.
- platform/qt/css3/flexbox/auto-margins-expected.png: Added.
- platform/qt/css3/flexbox/flexbox-baseline-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-25-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-70-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-25-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-70-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-25-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-70-expected.png:
- platform/qt/editing/selection/replaced-boundaries-3-expected.png:
- platform/qt/editing/selection/select-box-expected.png:
- platform/qt/editing/selection/select-element-paragraph-boundary-expected.png:
- platform/qt/fast/backgrounds/background-position-parsing-expected.png:
- platform/qt/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/qt/fast/block/basic/001-expected.png:
- platform/qt/fast/block/basic/011-expected.png:
- platform/qt/fast/block/basic/014-expected.png:
- platform/qt/fast/block/basic/015-expected.png:
- platform/qt/fast/block/basic/016-expected.png:
- platform/qt/fast/block/basic/019-expected.png:
- platform/qt/fast/block/basic/fieldset-stretch-to-legend-expected.png:
- platform/qt/fast/block/float/002-expected.png:
- platform/qt/fast/block/float/013-expected.png:
- platform/qt/fast/block/float/017-expected.png:
- platform/qt/fast/block/float/avoiding-float-centered-expected.png:
- platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.png:
- platform/qt/fast/block/float/float-avoidance-expected.png:
- platform/qt/fast/block/float/nopaint-after-layer-destruction2-expected.png:
- platform/qt/fast/block/float/overhanging-tall-block-expected.png:
- platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
- platform/qt/fast/block/margin-collapse/055-expected.png:
- platform/qt/fast/block/margin-collapse/100-expected.png:
- platform/qt/fast/block/margin-collapse/103-expected.png:
- platform/qt/fast/block/positioning/047-expected.png:
- platform/qt/fast/block/positioning/051-expected.png:
- platform/qt/fast/borders/fieldsetBorderRadius-expected.png:
- platform/qt/fast/borders/rtl-border-01-expected.png:
- platform/qt/fast/borders/rtl-border-02-expected.png:
- platform/qt/fast/borders/rtl-border-03-expected.png:
- platform/qt/fast/box-shadow/box-shadow-transformed-expected.png:
- platform/qt/fast/box-shadow/single-pixel-shadow-expected.png:
- platform/qt/fast/box-sizing/box-sizing-expected.png:
- platform/qt/fast/css-generated-content/011-expected.png:
- platform/qt/fast/css-generated-content/013-expected.png:
- platform/qt/fast/css-generated-content/014-expected.png:
- platform/qt/fast/css-generated-content/inline-display-types-expected.png:
- platform/qt/fast/css/004-expected.png:
- platform/qt/fast/css/005-expected.png:
- platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/qt/fast/css/background-shorthand-invalid-url-expected.png:
- platform/qt/fast/css/css1_forward_compatible_parsing-expected.png:
- platform/qt/fast/css/empty-pseudo-class-expected.png:
- platform/qt/fast/css/fieldset-display-row-expected.png:
- platform/qt/fast/css/first-child-pseudo-class-expected.png:
- platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.png:
- platform/qt/fast/css/first-of-type-pseudo-class-expected.png:
- platform/qt/fast/css/font-size-negative-expected.png:
- platform/qt/fast/css/h1-in-section-elements-expected.png:
- platform/qt/fast/css/hsl-color-expected.png:
- platform/qt/fast/css/hsla-color-expected.png:
- platform/qt/fast/css/inline-properties-important-expected.png:
- platform/qt/fast/css/invalid-percentage-property-expected.png:
- platform/qt/fast/css/last-child-pseudo-class-expected.png:
- platform/qt/fast/css/last-of-type-pseudo-class-expected.png:
- platform/qt/fast/css/line-height-negative-expected.png:
- platform/qt/fast/css/only-child-pseudo-class-expected.png:
- platform/qt/fast/css/only-of-type-pseudo-class-expected.png:
- platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png:
- platform/qt/fast/css/rgb-float-expected.png:
- platform/qt/fast/css/text-align-expected.png:
- platform/qt/fast/css/text-overflow-ellipsis-text-align-center-expected.png:
- platform/qt/fast/css/text-overflow-ellipsis-text-align-justify-expected.png:
- platform/qt/fast/css/text-overflow-ellipsis-text-align-left-expected.png:
- platform/qt/fast/css/text-overflow-ellipsis-text-align-right-expected.png:
- platform/qt/fast/css/text-transform-select-expected.png:
- platform/qt/fast/css/transform-default-parameter-expected.png:
- platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png:
- platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png:
- platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png:
- platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.png:
- platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
- platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.png:
- platform/qt/fast/encoding/utf-16-big-endian-expected.png:
- platform/qt/fast/encoding/utf-16-little-endian-expected.png:
- platform/qt/fast/events/pointer-events-2-expected.png:
- platform/qt/fast/flexbox/011-expected.png:
- platform/qt/fast/flexbox/flex-hang-expected.png:
- platform/qt/fast/forms/004-expected.png:
- platform/qt/fast/forms/006-expected.png:
- platform/qt/fast/forms/007-expected.png:
- platform/qt/fast/forms/HTMLOptionElement_label01-expected.png:
- platform/qt/fast/forms/HTMLOptionElement_label02-expected.png:
- platform/qt/fast/forms/HTMLOptionElement_label03-expected.png:
- platform/qt/fast/forms/HTMLOptionElement_label04-expected.png:
- platform/qt/fast/forms/basic-inputs-expected.png:
- platform/qt/fast/forms/basic-selects-expected.png:
- platform/qt/fast/forms/basic-textareas-quirks-expected.png:
- platform/qt/fast/forms/box-shadow-override-expected.png:
- platform/qt/fast/forms/button-default-title-expected.png:
- platform/qt/fast/forms/button-generated-content-expected.png:
- platform/qt/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
- platform/qt/fast/forms/datalist/input-appearance-range-with-transform-expected.png:
- platform/qt/fast/forms/disabled-select-change-index-expected.png:
- platform/qt/fast/forms/fieldset-align-expected.png:
- platform/qt/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png:
- platform/qt/fast/forms/fieldset-with-float-expected.png:
- platform/qt/fast/forms/float-before-fieldset-expected.png:
- platform/qt/fast/forms/formmove-expected.png:
- platform/qt/fast/forms/indeterminate-expected.png:
- platform/qt/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
- platform/qt/fast/forms/listbox-bidi-align-expected.png:
- platform/qt/fast/forms/option-strip-whitespace-expected.png:
- platform/qt/fast/forms/option-text-clip-expected.png:
- platform/qt/fast/forms/placeholder-pseudo-style-expected.png:
- platform/qt/fast/forms/range/input-appearance-range-expected.png:
- platform/qt/fast/forms/select-align-expected.png:
- platform/qt/fast/forms/select-change-listbox-to-popup-expected.png:
- platform/qt/fast/forms/select-disabled-appearance-expected.png:
- platform/qt/fast/forms/select-initial-position-expected.png:
- platform/qt/fast/forms/select-selected-expected.png:
- platform/qt/fast/gradients/radial-centered-expected.png:
- platform/qt/fast/html/details-marker-style-expected.png:
- platform/qt/fast/html/details-replace-summary-child-expected.png:
- platform/qt/fast/html/details-writing-mode-expected.png:
- platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png:
- platform/qt/fast/inline-block/002-expected.png:
- platform/qt/fast/inline-block/inline-block-vertical-align-expected.png:
- platform/qt/fast/inline/continuation-outlines-expected.png:
- platform/qt/fast/inline/inline-borders-with-bidi-override-expected.png:
- platform/qt/fast/inline/inline-box-background-expected.png:
- platform/qt/fast/inline/inline-box-background-long-image-expected.png:
- platform/qt/fast/inline/inline-box-background-repeat-x-expected.png:
- platform/qt/fast/inline/inline-box-background-repeat-y-expected.png:
- platform/qt/fast/invalid/010-expected.png:
- platform/qt/fast/invalid/012-expected.png:
- platform/qt/fast/invalid/014-expected.png:
- platform/qt/fast/invalid/nestedh3s-expected.png:
- platform/qt/fast/line-grid/line-align-left-edges-expected.png:
- platform/qt/fast/lists/008-expected.png:
- platform/qt/fast/lists/008-vertical-expected.png:
- platform/qt/fast/lists/list-marker-before-content-table-expected.png:
- platform/qt/fast/lists/ordered-list-with-no-ol-tag-expected.png:
- platform/qt/fast/multicol/column-break-with-balancing-expected.png:
- platform/qt/fast/multicol/column-count-with-rules-expected.png:
- platform/qt/fast/multicol/column-rules-expected.png:
- platform/qt/fast/multicol/column-rules-stacking-expected.png:
- platform/qt/fast/multicol/columns-shorthand-parsing-expected.png:
- platform/qt/fast/multicol/float-multicol-expected.png:
- platform/qt/fast/multicol/float-paginate-complex-expected.png:
- platform/qt/fast/multicol/layers-in-multicol-expected.png:
- platform/qt/fast/multicol/max-height-columns-block-expected.png:
- platform/qt/fast/multicol/nested-columns-expected.png:
- platform/qt/fast/multicol/overflow-across-columns-expected.png:
- platform/qt/fast/multicol/overflow-across-columns-percent-height-expected.png:
- platform/qt/fast/multicol/overflow-unsplittable-expected.png:
- platform/qt/fast/multicol/positive-leading-expected.png:
- platform/qt/fast/multicol/shadow-breaking-expected.png:
- platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
- platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.png:
- platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.png:
- platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
- platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
- platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
- platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
- platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
- platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.png:
- platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
- platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.png:
- platform/qt/fast/multicol/span/span-margin-collapsing-expected.png:
- platform/qt/fast/multicol/table-vertical-align-expected.png:
- platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
- platform/qt/fast/multicol/vertical-lr/nested-columns-expected.png:
- platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
- platform/qt/fast/multicol/vertical-rl/nested-columns-expected.png:
- platform/qt/fast/parser/bad-xml-slash-expected.png:
- platform/qt/fast/parser/document-write-option-expected.png:
- platform/qt/fast/parser/style-script-head-test-expected.png:
- platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png:
- platform/qt/fast/regions/overflow-in-uniform-regions-expected.png: Added.
- platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
- platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png:
- platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
- platform/qt/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png:
- platform/qt/fast/regions/top-overflow-out-of-second-region-expected.png:
- platform/qt/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
- platform/qt/fast/repaint/line-flow-with-floats-1-expected.png:
- platform/qt/fast/repaint/line-flow-with-floats-10-expected.png:
- platform/qt/fast/repaint/line-flow-with-floats-2-expected.png:
- platform/qt/fast/repaint/line-flow-with-floats-3-expected.png:
- platform/qt/fast/repaint/line-flow-with-floats-4-expected.png:
- platform/qt/fast/repaint/line-flow-with-floats-6-expected.png:
- platform/qt/fast/repaint/line-flow-with-floats-7-expected.png:
- platform/qt/fast/repaint/line-flow-with-floats-8-expected.png:
- platform/qt/fast/repaint/line-flow-with-floats-9-expected.png:
- platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.png:
- platform/qt/fast/repaint/repaint-during-scroll-with-zoom-expected.png:
- platform/qt/fast/repaint/transform-replaced-shadows-expected.png:
- platform/qt/fast/replaced/border-radius-clip-content-edge-expected.png:
- platform/qt/fast/replaced/width100percent-radio-expected.png:
- platform/qt/fast/ruby/ruby-block-style-not-updated-expected.png:
- platform/qt/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png:
- platform/qt/fast/ruby/ruby-inline-style-not-updated-expected.png:
- platform/qt/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png:
- platform/qt/fast/ruby/ruby-inline-table-expected.png:
- platform/qt/fast/runin/runin-generated-before-content-expected.png:
- platform/qt/fast/selectors/032-expected.png:
- platform/qt/fast/selectors/166-expected.png:
- platform/qt/fast/selectors/unqualified-hover-quirks-expected.png:
- platform/qt/fast/table/009-expected.png:
- platform/qt/fast/table/035-expected.png:
- platform/qt/fast/table/035-vertical-expected.png:
- platform/qt/fast/table/041-expected.png:
- platform/qt/fast/table/absolute-table-at-bottom-expected.png:
- platform/qt/fast/table/border-collapsing/004-expected.png:
- platform/qt/fast/table/border-collapsing/004-vertical-expected.png:
- platform/qt/fast/table/mozilla-bug10296-vertical-align-1-expected.png:
- platform/qt/fast/table/mozilla-bug10296-vertical-align-2-expected.png:
- platform/qt/fast/table/nested-percent-height-table-expected.png:
- platform/qt/fast/table/percent-heights-expected.png:
- platform/qt/fast/table/table-before-child-style-update-expected.png:
- platform/qt/fast/table/table-display-types-strict-expected.png:
- platform/qt/fast/table/table-row-before-child-style-update-expected.png:
- platform/qt/fast/table/table-row-style-not-updated-expected.png:
- platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.png:
- platform/qt/fast/table/table-row-style-not-updated-with-before-content-expected.png:
- platform/qt/fast/table/table-style-not-updated-expected.png:
- platform/qt/fast/text/atsui-kerning-and-ligatures-expected.png:
- platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.png:
- platform/qt/fast/text/basic/012-expected.png:
- platform/qt/fast/text/basic/013-expected.png:
- platform/qt/fast/text/basic/generic-family-reset-expected.png:
- platform/qt/fast/text/cg-vs-atsui-expected.png:
- platform/qt/fast/text/line-breaks-expected.png:
- platform/qt/fast/text/should-use-atsui-expected.png:
- platform/qt/fast/text/whitespace/007-expected.png:
- platform/qt/fast/text/whitespace/013-expected.png:
- platform/qt/fast/text/whitespace/014-expected.png:
- platform/qt/fast/text/whitespace/018-expected.png:
- platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
- platform/qt/fast/transforms/bounding-rect-zoom-expected.png:
- platform/qt/fast/writing-mode/fieldsets-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png:
- platform/qt/printing/return-from-printing-mode-expected.png:
- platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
- platform/qt/svg/as-border-image/svg-as-border-image-2-expected.png:
- platform/qt/svg/as-border-image/svg-as-border-image-expected.png:
- platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
- platform/qt/svg/batik/text/textEffect-expected.png:
- platform/qt/svg/batik/text/textEffect3-expected.png:
- platform/qt/svg/custom/bug45331-expected.png:
- platform/qt/svg/custom/image-parent-translation-expected.png:
- platform/qt/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.png:
- platform/qt/svg/custom/js-late-clipPath-creation-expected.png:
- platform/qt/svg/custom/js-late-gradient-and-object-creation-expected.png:
- platform/qt/svg/custom/js-late-gradient-creation-expected.png:
- platform/qt/svg/custom/junk-data-expected.png:
- platform/qt/svg/custom/missing-xlink-expected.png:
- platform/qt/svg/custom/object-sizing-expected.png:
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
- platform/qt/svg/custom/path-bad-data-expected.png:
- platform/qt/svg/custom/repaint-shadow-expected.png:
- platform/qt/svg/custom/rootmost-svg-xy-attrs-expected.png:
- platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/qt/svg/custom/svg-fonts-in-html-expected.png:
- platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.png:
- platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png:
- platform/qt/svg/custom/use-font-face-crash-expected.png:
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.png:
- platform/qt/svg/hixie/error/003-expected.png:
- platform/qt/svg/hixie/error/012-expected.png:
- platform/qt/svg/hixie/perf/003-expected.png:
- platform/qt/svg/text/append-text-node-to-tspan-expected.png:
- platform/qt/svg/text/modify-text-node-in-tspan-expected.png:
- platform/qt/svg/text/remove-text-node-from-tspan-expected.png:
- platform/qt/svg/text/remove-tspan-from-text-expected.png:
- platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
- platform/qt/svg/text/small-fonts-in-html5-expected.png:
- platform/qt/svg/transforms/svg-css-transforms-clip-path-expected.png:
- platform/qt/svg/transforms/svg-css-transforms-expected.png:
- platform/qt/svg/wicd/rightsizing-grid-expected.png:
- platform/qt/svg/wicd/test-rightsizing-a-expected.png:
- platform/qt/svg/wicd/test-rightsizing-b-expected.png:
- platform/qt/svg/wicd/test-scalable-background-image1-expected.png:
- platform/qt/svg/wicd/test-scalable-background-image2-expected.png:
- platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.png:
- platform/qt/svg/zoom/page/zoom-background-images-expected.png:
- platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
- platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png:
- platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/qt/tables/mozilla/bugs/bug10269-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug10296-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug1055-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug106816-expected.png:
- platform/qt/tables/mozilla/bugs/bug11384s-expected.png:
- platform/qt/tables/mozilla/bugs/bug126742-expected.png:
- platform/qt/tables/mozilla/bugs/bug131020-expected.png:
- platform/qt/tables/mozilla/bugs/bug1318-expected.png:
- platform/qt/tables/mozilla/bugs/bug139524-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug159108-expected.png:
- platform/qt/tables/mozilla/bugs/bug17130-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug17130-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug18359-expected.png:
- platform/qt/tables/mozilla/bugs/bug19061-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug19061-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug215629-expected.png:
- platform/qt/tables/mozilla/bugs/bug24200-expected.png:
- platform/qt/tables/mozilla/bugs/bug2479-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug2479-4-expected.png:
- platform/qt/tables/mozilla/bugs/bug28928-expected.png:
- platform/qt/tables/mozilla/bugs/bug2997-expected.png:
- platform/qt/tables/mozilla/bugs/bug3309-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug33855-expected.png:
- platform/qt/tables/mozilla/bugs/bug39209-expected.png:
- platform/qt/tables/mozilla/bugs/bug3977-expected.png:
- platform/qt/tables/mozilla/bugs/bug4382-expected.png:
- platform/qt/tables/mozilla/bugs/bug4527-expected.png:
- platform/qt/tables/mozilla/bugs/bug46480-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug46480-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug5538-expected.png:
- platform/qt/tables/mozilla/bugs/bug6304-expected.png:
- platform/qt/tables/mozilla/bugs/bug69187-expected.png:
- platform/qt/tables/mozilla/bugs/bug7112-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug7112-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug73321-expected.png:
- platform/qt/tables/mozilla/bugs/bug8032-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug8381-expected.png:
- platform/qt/tables/mozilla/bugs/bug9271-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug9271-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug96334-expected.png:
- platform/qt/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
- platform/qt/tables/mozilla/core/margins-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_index-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_position-table-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
- platform/qt/tables/mozilla/marvin/tables_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_align_center-expected.png:
- platform/qt/tables/mozilla/other/test3-expected.png:
- platform/qt/tables/mozilla/other/test6-expected.png:
- platform/qt/tables/mozilla/other/wa_table_tr_align-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug21518-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug61042-2-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
- platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
- platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
- platform/qt/tables/mozilla_expected_failures/core/captions1-expected.png:
- platform/qt/tables/mozilla_expected_failures/core/captions2-expected.png:
- platform/qt/tables/mozilla_expected_failures/core/captions3-expected.png:
- platform/qt/tables/mozilla_expected_failures/core/standards1-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
- platform/qt/transforms/svg-vs-css-expected.png:
- 8:32 AM Changeset in webkit [148611] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Eclipse warnings in MediaPlayerPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=114654
Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-17
Reviewed by Philippe Normand.
No new tests (nothing added).
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
Initialize m_volumeAndMuteInitialized
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
Initialize signal handlers to 0.
- 7:49 AM Changeset in webkit [148610] by
-
- 2 edits in trunk/LayoutTests
[Qt] Remove fast/regions/counters/extract-list-items-013.html from TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=114724
Unreviewed gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-17
- platform/qt/TestExpectations: Removed after r148289
- 7:49 AM Changeset in webkit [148609] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Implement context menu in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=102932
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-04-17
Reviewed by Gyuyoung Kim.
Added context menu support for EFL port using Elementary context popup.
- MiniBrowser/efl/main.c:
(_Browser_Window):
(context_popup_item_selected_cb):
(context_popup_populate):
(on_context_menu_show):
(on_context_menu_hide):
(window_create):
- 7:05 AM Changeset in webkit [148608] by
-
- 4 edits in trunk/Tools
REGRESSION(r148588): It broke the Qt WK2 EWS
https://bugs.webkit.org/show_bug.cgi?id=114737
Reviewed by Jocelyn Turcotte.
- Scripts/webkitpy/common/config/ews.json: "Qt WK2 EWS" should use qt-wk2 port.
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(QtPort.build_webkit_command): qt port shouldn't build WebKit2.
(QtPort.run_webkit_tests_command): qt port runs WK1 tests.
(QtWK2Port): Added.
(QtWK2Port.build_webkit_command): qt-wk2 port builds WK1 and WK2 too.
(QtWK2Port.run_webkit_tests_command): qt-wk2 port runs WK2 tests.
- Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_qt_port):
(DeprecatedPortTest):
(DeprecatedPortTest.test_qt_wk2_port):
- 6:54 AM Changeset in webkit [148607] by
-
- 2 edits1 add9 deletes in trunk/LayoutTests
[Qt] Ureviewed gardening. Cleaning up after r148596.
- platform/qt-5.0-wk2/fast/backgrounds/background-position-parsing-expected.txt: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
- platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/clip/overflow-border-radius-composited-expected.png: Removed.
- platform/qt-5.0-wk2/fast/clip/overflow-border-radius-composited-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/table/border-collapsing/004-vertical-expected.png: Removed.
- platform/qt-5.0-wk2/fast/table/border-collapsing/004-vertical-expected.txt: Removed.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Removed.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Removed.
- platform/qt/TestExpectations: Skip two reftest.
- 6:42 AM Changeset in webkit [148606] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed Gardening.
Marking compositing reftests added in r148172 as failing.
- platform/efl/TestExpectations:
- 6:29 AM Changeset in webkit [148605] by
-
- 3 edits in trunk/Source/WebCore
[CSS Regions] Remove m_flowThread from NodeRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=114732
Reviewed by Antti Koivisto.
Cleanup NodeRenderingContext. Remove unused member m_flowThread.
Tests: None needed.
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
- dom/NodeRenderingContext.h: Removed m_flowThread.
- 6:05 AM Changeset in webkit [148604] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unskip tests requiring SUBPIXEL_LAYOUT
Unreviewed Qt gardening.
- platform/qt/TestExpectations:
- 5:53 AM Changeset in webkit [148603] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Mark various tests as flaky or failing.
- 5:37 AM Changeset in webkit [148602] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Cleaning up unneeded expecteds after r148596.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-04-17
- platform/qt-5.0-wk1/compositing/direct-image-compositing-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/direct-image-compositing-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.txt: Removed.
- platform/qt-5.0-wk2/editing/selection/select-box-expected.png: Removed.
- platform/qt-5.0-wk2/editing/selection/select-box-expected.txt: Removed.
- platform/qt-5.0-wk2/editing/selection/select-element-paragraph-boundary-expected.png: Removed.
- platform/qt-5.0-wk2/editing/selection/select-element-paragraph-boundary-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/forms/selectlist-minsize-expected.txt: Removed.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Removed.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Removed.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Removed.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Removed.
- platform/qt-5.0-wk2/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Removed.
- platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.png: Removed.
- platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
- platform/qt-5.0/editing/selection/select-box-expected.png: Removed.
- platform/qt-5.0/editing/selection/select-box-expected.txt: Removed.
- platform/qt-5.0/editing/selection/select-element-paragraph-boundary-expected.png: Removed.
- platform/qt-5.0/editing/selection/select-element-paragraph-boundary-expected.txt: Removed.
- platform/qt-5.0/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt: Removed.
- platform/qt-5.0/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt: Removed.
- platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt: Removed.
- platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt: Removed.
- platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt: Removed.
- platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt: Removed.
- platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.png: Removed.
- platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.txt: Removed.
- platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.png: Removed.
- platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.txt: Removed.
- platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.png: Removed.
- platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.txt: Removed.
- platform/qt-5.0/fast/forms/selectlist-minsize-expected.png: Removed.
- platform/qt-5.0/fast/forms/selectlist-minsize-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Removed.
- platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.png: Removed.
- platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Removed.
- 5:37 AM Changeset in webkit [148601] by
-
- 2 edits in trunk/Tools
Unreviewed.
- Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_efl_port): Adjusting the expected outcome of the EFL build-webkit command after r148589.
- 5:13 AM Changeset in webkit [148600] by
-
- 2 edits in trunk/Source/WebCore
[Qt] MediaPlayerPrivateQt.cpp doesn't build in debug
Unreviewed build fix.
We need to include Logging.h to get the LOG definitions.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
- 4:51 AM Changeset in webkit [148599] by
-
- 1 edit81 deletes in trunk/LayoutTests
[Qt] Unreviewed gardening. Cleaning up unneeded expecteds after r148596.
- platform/qt-5.0-wk1/compositing/direct-image-compositing-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/direct-image-compositing-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.txt: Removed.
- platform/qt-5.0-wk2/editing/selection/select-box-expected.png: Removed.
- platform/qt-5.0-wk2/editing/selection/select-box-expected.txt: Removed.
- platform/qt-5.0-wk2/editing/selection/select-element-paragraph-boundary-expected.png: Removed.
- platform/qt-5.0-wk2/editing/selection/select-element-paragraph-boundary-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/forms/selectlist-minsize-expected.txt: Removed.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Removed.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Removed.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Removed.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Removed.
- platform/qt-5.0-wk2/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Removed.
- platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.png: Removed.
- platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
- platform/qt-5.0/editing/selection/select-box-expected.png: Removed.
- platform/qt-5.0/editing/selection/select-box-expected.txt: Removed.
- platform/qt-5.0/editing/selection/select-element-paragraph-boundary-expected.png: Removed.
- platform/qt-5.0/editing/selection/select-element-paragraph-boundary-expected.txt: Removed.
- platform/qt-5.0/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt: Removed.
- platform/qt-5.0/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt: Removed.
- platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt: Removed.
- platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt: Removed.
- platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt: Removed.
- platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt: Removed.
- platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.png: Removed.
- platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.txt: Removed.
- platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.png: Removed.
- platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.txt: Removed.
- platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.png: Removed.
- platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.txt: Removed.
- platform/qt-5.0/fast/forms/selectlist-minsize-expected.png: Removed.
- platform/qt-5.0/fast/forms/selectlist-minsize-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Removed.
- platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.png: Removed.
- platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Removed.
- 4:00 AM Changeset in webkit [148598] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed Gardening.
Marking a lot of WebGL/CoordinatedGraphics related failures
as crashes after r114731, needs to be looked at in bug 114731.
- platform/efl/TestExpectations:
- 3:29 AM Changeset in webkit [148597] by
-
- 5 edits in trunk
execCommand("RemoveFormat") might remove format after the selection
https://bugs.webkit.org/show_bug.cgi?id=112240
Reviewed by Ryosuke Niwa.
Source/WebCore:
Tests: editing/execCommand/remove-format-multiple-elements-mac.html
This bug is hit when ApplyStyleCommand is used to change the
style and the current selection ends in the beginning of a new node.
The bug is actually a two-fold thing:
- There was no check as to whether the end node is really
selected or not, and format was always removed from it with
pushDownInlineStyleAroundNode(). An equivalent check for the start
node was already in place, so fix it analogously.
- Previous stage might change the dom tree, resulting in a render
tree that is not up-to-date. Position::upstream() is later used
and, in order to be able to find a visually equivalent position in
a text node, this method needs the render tree to be up-to-date,
therefore, a call to updateLayoutIgnorePendingStylesheets() is
necessary.
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeInlineStyle): Make sure that no
format is removed from the end node if it's not fully selected.
(WebCore::ApplyStyleCommand::nodeFullySelected): Call updateLayoutIgnorePendingStylesheets()
LayoutTests:
- editing/execCommand/remove-format-multiple-elements-mac-expected.txt: Updated.
- editing/execCommand/script-tests/remove-format-multiple-elements-mac.js:
(selectFirstLine): Add this method to check that RemoveFormat works when
a whole line is selected.
- 2:33 AM Changeset in webkit [148596] by
-
- 983 edits4 copies36 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaselining text expected results after r148594.
- platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
- platform/qt/compositing/direct-image-compositing-expected.txt:
- platform/qt/compositing/layer-creation/overlap-animation-container-expected.txt:
- platform/qt/compositing/overflow/theme-affects-visual-overflow-expected.txt:
- platform/qt/compositing/shadows/shadow-drawing-expected.txt:
- platform/qt/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/qt/css1/basic/inheritance-expected.txt:
- platform/qt/css1/box_properties/acid_test-expected.txt:
- platform/qt/css1/box_properties/clear_float-expected.txt:
- platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
- platform/qt/css1/box_properties/margin-expected.txt:
- platform/qt/css1/box_properties/margin_bottom-expected.txt:
- platform/qt/css1/box_properties/margin_right-expected.txt:
- platform/qt/css1/box_properties/margin_top-expected.txt:
- platform/qt/css1/box_properties/padding-expected.txt:
- platform/qt/css1/box_properties/padding_bottom-expected.txt:
- platform/qt/css1/box_properties/padding_left-expected.txt:
- platform/qt/css1/box_properties/padding_right-expected.txt:
- platform/qt/css1/box_properties/padding_top-expected.txt:
- platform/qt/css1/box_properties/width-expected.txt:
- platform/qt/css1/color_and_background/background_attachment-expected.txt:
- platform/qt/css1/font_properties/font-expected.txt:
- platform/qt/css1/font_properties/font_size-expected.txt:
- platform/qt/css1/font_properties/font_weight-expected.txt:
- platform/qt/css1/formatting_model/floating_elements-expected.txt:
- platform/qt/css1/formatting_model/horizontal_formatting-expected.txt:
- platform/qt/css1/formatting_model/inline_elements-expected.txt:
- platform/qt/css1/formatting_model/replaced_elements-expected.txt:
- platform/qt/css1/formatting_model/vertical_formatting-expected.txt:
- platform/qt/css1/text_properties/text_indent-expected.txt:
- platform/qt/css1/text_properties/vertical_align-expected.txt:
- platform/qt/css1/units/percentage_units-expected.txt:
- platform/qt/css1/units/rounding-expected.txt: Added.
- platform/qt/css2.1/20110323/absolute-non-replaced-height-002-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-height-007-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-height-009-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-max-height-002-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-max-height-007-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-max-height-009-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-001-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-002-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-003-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-004-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-005-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-006-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-007-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-008-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-009-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-010-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-011-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-012-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-013-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-014-expected.txt:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-016-expected.txt:
- platform/qt/css2.1/20110323/block-non-replaced-height-005-expected.txt:
- platform/qt/css2.1/20110323/block-non-replaced-height-006-expected.txt:
- platform/qt/css2.1/20110323/block-non-replaced-width-007-expected.txt:
- platform/qt/css2.1/20110323/block-replaced-width-001-expected.txt:
- platform/qt/css2.1/20110323/block-replaced-width-006-expected.txt:
- platform/qt/css2.1/20110323/float-non-replaced-width-006-expected.txt:
- platform/qt/css2.1/20110323/floating-replaced-height-008-expected.txt:
- platform/qt/css2.1/20110323/inline-block-non-replaced-width-001-expected.txt:
- platform/qt/css2.1/20110323/inline-block-non-replaced-width-002-expected.txt:
- platform/qt/css2.1/20110323/inline-block-replaced-height-008-expected.txt:
- platform/qt/css2.1/20110323/inline-non-replaced-width-001-expected.txt:
- platform/qt/css2.1/20110323/inline-non-replaced-width-002-expected.txt:
- platform/qt/css2.1/20110323/inline-replaced-height-008-expected.txt:
- platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt:
- platform/qt/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.txt:
- platform/qt/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
- platform/qt/css2.1/t0803-c5502-mrgn-r-01-c-a-expected.txt:
- platform/qt/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.txt:
- platform/qt/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
- platform/qt/css2.1/t0803-c5504-mrgn-l-01-c-a-expected.txt:
- platform/qt/css2.1/t0803-c5505-mrgn-01-e-a-expected.txt:
- platform/qt/css2.1/t0803-c5505-mrgn-03-c-ag-expected.txt:
- platform/qt/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/qt/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt:
- platform/qt/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
- platform/qt/css2.1/t0804-c5507-padn-r-01-c-a-expected.txt:
- platform/qt/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
- platform/qt/css2.1/t0804-c5509-padn-l-01-b-a-expected.txt:
- platform/qt/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
- platform/qt/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
- platform/qt/css2.1/t0804-c5510-padn-01-e-a-expected.txt:
- platform/qt/css2.1/t09-c5526c-display-00-e-expected.txt:
- platform/qt/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
- platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
- platform/qt/css2.1/t090501-c414-flt-03-b-g-expected.txt:
- platform/qt/css2.1/t1002-c5523-width-02-b-g-expected.txt:
- platform/qt/css2.1/t100801-c544-valgn-00-a-ag-expected.txt:
- platform/qt/css2.1/t100801-c544-valgn-02-d-agi-expected.txt:
- platform/qt/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
- platform/qt/css2.1/t100801-c544-valgn-04-d-agi-expected.txt:
- platform/qt/css2.1/t100801-c548-ln-ht-00-c-a-expected.txt:
- platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.txt:
- platform/qt/css2.1/t1506-c525-font-wt-00-b-expected.txt:
- platform/qt/css2.1/t1507-c526-font-sz-01-b-a-expected.txt:
- platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
- platform/qt/css2.1/t1508-c527-font-09-b-expected.txt:
- platform/qt/css3/flexbox/flexbox-baseline-expected.txt:
- platform/qt/css3/selectors3/html/css3-modsel-25-expected.txt:
- platform/qt/css3/selectors3/html/css3-modsel-70-expected.txt:
- platform/qt/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
- platform/qt/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
- platform/qt/css3/selectors3/xml/css3-modsel-25-expected.txt:
- platform/qt/css3/selectors3/xml/css3-modsel-70-expected.txt:
- platform/qt/editing/inserting/editing-empty-divs-expected.txt:
- platform/qt/editing/pasteboard/4641033-expected.txt:
- platform/qt/editing/pasteboard/4944770-1-expected.txt:
- platform/qt/editing/pasteboard/4944770-2-expected.txt:
- platform/qt/editing/selection/3690703-2-expected.txt:
- platform/qt/editing/selection/3690703-expected.txt:
- platform/qt/editing/selection/3690719-expected.txt:
- platform/qt/editing/selection/5354455-2-expected.txt:
- platform/qt/editing/selection/caret-before-select-expected.txt:
- platform/qt/editing/selection/caret-ltr-2-expected.txt:
- platform/qt/editing/selection/caret-ltr-2-left-expected.txt:
- platform/qt/editing/selection/caret-ltr-expected.txt:
- platform/qt/editing/selection/caret-ltr-right-expected.txt:
- platform/qt/editing/selection/caret-rtl-2-expected.txt:
- platform/qt/editing/selection/caret-rtl-2-left-expected.txt:
- platform/qt/editing/selection/caret-rtl-expected.txt:
- platform/qt/editing/selection/caret-rtl-right-expected.txt:
- platform/qt/editing/selection/drag-start-event-client-x-y-expected.txt: Added.
- platform/qt/editing/selection/replaced-boundaries-3-expected.txt:
- platform/qt/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/qt/editing/selection/select-across-readonly-input-2-expected.txt:
- platform/qt/editing/selection/select-across-readonly-input-3-expected.txt:
- platform/qt/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/qt/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/qt/editing/selection/select-box-expected.txt:
- platform/qt/editing/selection/select-element-paragraph-boundary-expected.txt:
- platform/qt/editing/selection/select-text-overflow-ellipsis-expected.txt:
- platform/qt/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
- platform/qt/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
- platform/qt/editing/style/block-style-005-expected.txt: Added.
- platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
- platform/qt/fast/backgrounds/background-position-parsing-expected.txt:
- platform/qt/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
- platform/qt/fast/block/basic/001-expected.txt:
- platform/qt/fast/block/basic/011-expected.txt:
- platform/qt/fast/block/basic/014-expected.txt:
- platform/qt/fast/block/basic/015-expected.txt:
- platform/qt/fast/block/basic/016-expected.txt:
- platform/qt/fast/block/basic/019-expected.txt:
- platform/qt/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
- platform/qt/fast/block/float/004-expected.txt:
- platform/qt/fast/block/float/005-expected.txt:
- platform/qt/fast/block/float/006-expected.txt:
- platform/qt/fast/block/float/013-expected.txt:
- platform/qt/fast/block/float/016-expected.txt:
- platform/qt/fast/block/float/025-expected.txt:
- platform/qt/fast/block/float/027-expected.txt:
- platform/qt/fast/block/float/032-expected.txt:
- platform/qt/fast/block/float/avoiding-float-centered-expected.txt:
- platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.txt:
- platform/qt/fast/block/float/float-avoidance-expected.txt:
- platform/qt/fast/block/float/float-in-float-painting-expected.txt:
- platform/qt/fast/block/float/nopaint-after-layer-destruction2-expected.txt:
- platform/qt/fast/block/float/overhanging-tall-block-expected.txt:
- platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
- platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.txt:
- platform/qt/fast/block/margin-collapse/030-expected.txt:
- platform/qt/fast/block/margin-collapse/037-expected.txt:
- platform/qt/fast/block/margin-collapse/038-expected.txt:
- platform/qt/fast/block/margin-collapse/055-expected.txt:
- platform/qt/fast/block/margin-collapse/100-expected.txt:
- platform/qt/fast/block/margin-collapse/103-expected.txt:
- platform/qt/fast/block/positioning/047-expected.txt:
- platform/qt/fast/block/positioning/051-expected.txt:
- platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
- platform/qt/fast/borders/bidi-002-expected.txt:
- platform/qt/fast/borders/bidi-009a-expected.txt:
- platform/qt/fast/borders/bidi-012-expected.txt:
- platform/qt/fast/borders/fieldsetBorderRadius-expected.txt: Added.
- platform/qt/fast/borders/rtl-border-01-expected.txt:
- platform/qt/fast/borders/rtl-border-02-expected.txt:
- platform/qt/fast/borders/rtl-border-03-expected.txt:
- platform/qt/fast/box-sizing/box-sizing-expected.txt:
- platform/qt/fast/clip/overflow-border-radius-composited-expected.txt:
- platform/qt/fast/clip/overflow-border-radius-transformed-expected.txt:
- platform/qt/fast/css-generated-content/011-expected.txt:
- platform/qt/fast/css-generated-content/012-expected.txt:
- platform/qt/fast/css-generated-content/013-expected.txt:
- platform/qt/fast/css-generated-content/014-expected.txt:
- platform/qt/fast/css-generated-content/015-expected.txt:
- platform/qt/fast/css-generated-content/inline-display-types-expected.txt:
- platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
- platform/qt/fast/css/003-expected.txt:
- platform/qt/fast/css/004-expected.txt:
- platform/qt/fast/css/005-expected.txt:
- platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt:
- platform/qt/fast/css/background-shorthand-invalid-url-expected.txt:
- platform/qt/fast/css/bidi-override-in-anonymous-block-expected.txt:
- platform/qt/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Added.
- platform/qt/fast/css/continuationCrash-expected.txt:
- platform/qt/fast/css/css1_forward_compatible_parsing-expected.txt:
- platform/qt/fast/css/css2-system-fonts-expected.txt:
- platform/qt/fast/css/empty-inline-003-quirksmode-expected.txt:
- platform/qt/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt:
- platform/qt/fast/css/empty-pseudo-class-expected.txt:
- platform/qt/fast/css/fieldset-display-row-expected.txt:
- platform/qt/fast/css/first-child-pseudo-class-expected.txt:
- platform/qt/fast/css/first-line-text-decoration-expected.txt:
- platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
- platform/qt/fast/css/first-of-type-pseudo-class-expected.txt:
- platform/qt/fast/css/font-size-negative-expected.txt:
- platform/qt/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Added.
- platform/qt/fast/css/h1-in-section-elements-expected.txt:
- platform/qt/fast/css/hsl-color-expected.txt:
- platform/qt/fast/css/hsla-color-expected.txt: Added.
- platform/qt/fast/css/inline-properties-important-expected.txt:
- platform/qt/fast/css/input-search-padding-expected.txt:
- platform/qt/fast/css/invalid-percentage-property-expected.txt:
- platform/qt/fast/css/last-child-pseudo-class-expected.txt:
- platform/qt/fast/css/last-of-type-pseudo-class-expected.txt:
- platform/qt/fast/css/line-height-negative-expected.txt:
- platform/qt/fast/css/non-standard-checkbox-size-expected.txt:
- platform/qt/fast/css/only-child-pseudo-class-expected.txt:
- platform/qt/fast/css/only-of-type-pseudo-class-expected.txt:
- platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt:
- platform/qt/fast/css/rgb-float-expected.txt:
- platform/qt/fast/css/selector-set-attribute-expected.txt:
- platform/qt/fast/css/text-align-expected.txt:
- platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/qt/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
- platform/qt/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt:
- platform/qt/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
- platform/qt/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
- platform/qt/fast/css/text-overflow-input-expected.txt:
- platform/qt/fast/css/text-transform-select-expected.txt:
- platform/qt/fast/css/transform-default-parameter-expected.txt:
- platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
- platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt:
- platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt:
- platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:
- platform/qt/fast/css/word-space-extra-expected.txt:
- platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
- platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.txt:
- platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
- platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
- platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
- platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
- platform/qt/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
- platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
- platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.txt:
- platform/qt/fast/dom/clone-node-dynamic-style-expected.txt:
- platform/qt/fast/dynamic/012-expected.txt:
- platform/qt/fast/dynamic/anchor-lock-expected.txt:
- platform/qt/fast/encoding/utf-16-big-endian-expected.txt:
- platform/qt/fast/encoding/utf-16-little-endian-expected.txt:
- platform/qt/fast/events/document-elementFromPoint-expected.txt: Added.
- platform/qt/fast/events/pointer-events-2-expected.txt:
- platform/qt/fast/flexbox/011-expected.txt:
- platform/qt/fast/flexbox/flex-hang-expected.txt:
- platform/qt/fast/forms/003-expected.txt:
- platform/qt/fast/forms/004-expected.txt:
- platform/qt/fast/forms/006-expected.txt:
- platform/qt/fast/forms/007-expected.txt:
- platform/qt/fast/forms/HTMLOptionElement_label01-expected.txt:
- platform/qt/fast/forms/HTMLOptionElement_label02-expected.txt:
- platform/qt/fast/forms/HTMLOptionElement_label03-expected.txt:
- platform/qt/fast/forms/HTMLOptionElement_label04-expected.txt:
- platform/qt/fast/forms/HTMLOptionElement_label06-expected.txt:
- platform/qt/fast/forms/HTMLOptionElement_label07-expected.txt:
- platform/qt/fast/forms/basic-inputs-expected.txt:
- platform/qt/fast/forms/basic-selects-expected.txt:
- platform/qt/fast/forms/basic-textareas-quirks-expected.txt:
- platform/qt/fast/forms/box-shadow-override-expected.txt:
- platform/qt/fast/forms/button-default-title-expected.txt:
- platform/qt/fast/forms/button-generated-content-expected.txt:
- platform/qt/fast/forms/button-inner-block-reuse-expected.txt:
- platform/qt/fast/forms/button-sizes-expected.txt:
- platform/qt/fast/forms/control-clip-overflow-expected.txt:
- platform/qt/fast/forms/control-restrict-line-height-expected.txt:
- platform/qt/fast/forms/disabled-select-change-index-expected.txt:
- platform/qt/fast/forms/fieldset-align-expected.txt:
- platform/qt/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
- platform/qt/fast/forms/fieldset-with-float-expected.txt:
- platform/qt/fast/forms/file/file-input-disabled-expected.txt:
- platform/qt/fast/forms/float-before-fieldset-expected.txt:
- platform/qt/fast/forms/form-element-geometry-expected.txt:
- platform/qt/fast/forms/formmove-expected.txt:
- platform/qt/fast/forms/formmove2-expected.txt:
- platform/qt/fast/forms/indeterminate-expected.txt:
- platform/qt/fast/forms/input-button-sizes-expected.txt:
- platform/qt/fast/forms/input-text-word-wrap-expected.txt:
- platform/qt/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
- platform/qt/fast/forms/menulist-clip-expected.txt:
- platform/qt/fast/forms/menulist-deselect-update-expected.txt:
- platform/qt/fast/forms/menulist-style-color-expected.txt:
- platform/qt/fast/forms/minWidthPercent-expected.txt:
- platform/qt/fast/forms/option-script-expected.txt:
- platform/qt/fast/forms/option-strip-whitespace-expected.txt:
- platform/qt/fast/forms/option-text-clip-expected.txt:
- platform/qt/fast/forms/placeholder-position-expected.txt:
- platform/qt/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/qt/fast/forms/range/input-appearance-range-expected.txt:
- platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/qt/fast/forms/search-rtl-expected.txt:
- platform/qt/fast/forms/search-styled-expected.txt:
- platform/qt/fast/forms/search-vertical-alignment-expected.txt:
- platform/qt/fast/forms/select-align-expected.txt:
- platform/qt/fast/forms/select-baseline-expected.txt:
- platform/qt/fast/forms/select-change-listbox-to-popup-expected.txt:
- platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.txt:
- platform/qt/fast/forms/select-disabled-appearance-expected.txt:
- platform/qt/fast/forms/select-initial-position-expected.txt:
- platform/qt/fast/forms/select-selected-expected.txt:
- platform/qt/fast/forms/select-size-expected.txt:
- platform/qt/fast/forms/select-style-expected.txt:
- platform/qt/fast/forms/select/optgroup-rendering-expected.txt:
- platform/qt/fast/forms/selectlist-minsize-expected.txt:
- platform/qt/fast/forms/stuff-on-my-optgroup-expected.txt:
- platform/qt/fast/gradients/crash-on-zero-radius-expected.txt:
- platform/qt/fast/gradients/radial-centered-expected.txt:
- platform/qt/fast/html/details-add-child-1-expected.txt:
- platform/qt/fast/html/details-add-child-2-expected.txt:
- platform/qt/fast/html/details-add-details-child-1-expected.txt:
- platform/qt/fast/html/details-add-details-child-2-expected.txt:
- platform/qt/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-1-expected.txt:
- platform/qt/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-10-expected.txt:
- platform/qt/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-2-expected.txt:
- platform/qt/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-3-expected.txt:
- platform/qt/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-4-expected.txt:
- platform/qt/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-5-expected.txt:
- platform/qt/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-6-expected.txt:
- platform/qt/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-7-expected.txt:
- platform/qt/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-8-expected.txt:
- platform/qt/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-9-expected.txt:
- platform/qt/fast/html/details-add-summary-child-1-expected.txt:
- platform/qt/fast/html/details-add-summary-child-2-expected.txt:
- platform/qt/fast/html/details-marker-style-expected.txt:
- platform/qt/fast/html/details-nested-1-expected.txt:
- platform/qt/fast/html/details-nested-2-expected.txt:
- platform/qt/fast/html/details-no-summary1-expected.txt:
- platform/qt/fast/html/details-no-summary2-expected.txt:
- platform/qt/fast/html/details-no-summary3-expected.txt:
- platform/qt/fast/html/details-no-summary4-expected.txt:
- platform/qt/fast/html/details-open-javascript-expected.txt:
- platform/qt/fast/html/details-open1-expected.txt:
- platform/qt/fast/html/details-open2-expected.txt:
- platform/qt/fast/html/details-open3-expected.txt:
- platform/qt/fast/html/details-open4-expected.txt:
- platform/qt/fast/html/details-open5-expected.txt:
- platform/qt/fast/html/details-open6-expected.txt:
- platform/qt/fast/html/details-position-expected.txt:
- platform/qt/fast/html/details-remove-child-1-expected.txt:
- platform/qt/fast/html/details-remove-child-2-expected.txt:
- platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-1-expected.txt:
- platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-2-expected.txt:
- platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-3-expected.txt:
- platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-4-expected.txt:
- platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-5-expected.txt:
- platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-6-expected.txt:
- platform/qt/fast/html/details-remove-summary-child-1-expected.txt:
- platform/qt/fast/html/details-remove-summary-child-2-expected.txt:
- platform/qt/fast/html/details-replace-summary-child-expected.txt:
- platform/qt/fast/html/details-replace-text-expected.txt:
- platform/qt/fast/html/details-writing-mode-expected.txt:
- platform/qt/fast/images/imagemap-focus-ring-zoom-expected.txt:
- platform/qt/fast/images/zoomed-img-size-expected.txt: Added.
- platform/qt/fast/inline-block/002-expected.txt:
- platform/qt/fast/inline-block/inline-block-vertical-align-expected.txt:
- platform/qt/fast/inline/002-expected.txt:
- platform/qt/fast/inline/continuation-outlines-expected.txt:
- platform/qt/fast/inline/inline-borders-with-bidi-override-expected.txt:
- platform/qt/fast/inline/inline-box-background-expected.txt:
- platform/qt/fast/inline/inline-box-background-long-image-expected.txt:
- platform/qt/fast/inline/inline-box-background-repeat-x-expected.txt:
- platform/qt/fast/inline/inline-box-background-repeat-y-expected.txt:
- platform/qt/fast/inline/outline-continuations-expected.txt:
- platform/qt/fast/inline/positionedLifetime-expected.txt:
- platform/qt/fast/invalid/010-expected.txt:
- platform/qt/fast/invalid/014-expected.txt:
- platform/qt/fast/invalid/nestedh3s-expected.txt:
- platform/qt/fast/line-grid/line-align-left-edges-expected.txt: Added.
- platform/qt/fast/lists/003-expected.txt:
- platform/qt/fast/lists/003-vertical-expected.txt:
- platform/qt/fast/lists/008-expected.txt:
- platform/qt/fast/lists/008-vertical-expected.txt:
- platform/qt/fast/lists/list-marker-before-content-table-expected.txt:
- platform/qt/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
- platform/qt/fast/multicol/break-properties-expected.txt: Added.
- platform/qt/fast/multicol/client-rects-expected.txt:
- platform/qt/fast/multicol/column-break-with-balancing-expected.txt:
- platform/qt/fast/multicol/float-multicol-expected.txt:
- platform/qt/fast/multicol/float-paginate-complex-expected.txt:
- platform/qt/fast/multicol/layers-in-multicol-expected.txt:
- platform/qt/fast/multicol/nested-columns-expected.txt:
- platform/qt/fast/multicol/overflow-across-columns-expected.txt:
- platform/qt/fast/multicol/overflow-across-columns-percent-height-expected.txt:
- platform/qt/fast/multicol/overflow-unsplittable-expected.txt:
- platform/qt/fast/multicol/scrolling-overflow-expected.txt:
- platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
- platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.txt:
- platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.txt:
- platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
- platform/qt/fast/multicol/span/clone-flexbox-expected.txt:
- platform/qt/fast/multicol/span/clone-summary-expected.txt:
- platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
- platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
- platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
- platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
- platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
- platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.txt:
- platform/qt/fast/multicol/span/span-margin-collapsing-expected.txt:
- platform/qt/fast/multicol/table-vertical-align-expected.txt:
- platform/qt/fast/multicol/vertical-lr/break-properties-expected.txt: Added.
- platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
- platform/qt/fast/multicol/vertical-lr/float-multicol-expected.txt:
- platform/qt/fast/multicol/vertical-lr/nested-columns-expected.txt:
- platform/qt/fast/multicol/vertical-rl/break-properties-expected.txt: Added.
- platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
- platform/qt/fast/multicol/vertical-rl/float-multicol-expected.txt:
- platform/qt/fast/multicol/vertical-rl/nested-columns-expected.txt:
- platform/qt/fast/overflow/007-expected.txt:
- platform/qt/fast/overflow/overflow-rtl-vertical-expected.txt:
- platform/qt/fast/parser/bad-xml-slash-expected.txt:
- platform/qt/fast/parser/document-write-option-expected.txt:
- platform/qt/fast/parser/entity-comment-in-style-expected.txt:
- platform/qt/fast/parser/style-script-head-test-expected.txt: Added.
- platform/qt/fast/reflections/reflection-with-zoom-expected.txt:
- platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
- platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
- platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
- platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt:
- platform/qt/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
- platform/qt/fast/regions/top-overflow-out-of-second-region-expected.txt:
- platform/qt/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
- platform/qt/fast/repaint/control-clip-expected.txt:
- platform/qt/fast/repaint/delete-into-nested-block-expected.txt:
- platform/qt/fast/repaint/line-flow-with-floats-1-expected.txt:
- platform/qt/fast/repaint/line-flow-with-floats-10-expected.txt:
- platform/qt/fast/repaint/line-flow-with-floats-2-expected.txt:
- platform/qt/fast/repaint/line-flow-with-floats-3-expected.txt:
- platform/qt/fast/repaint/line-flow-with-floats-4-expected.txt:
- platform/qt/fast/repaint/line-flow-with-floats-5-expected.txt:
- platform/qt/fast/repaint/line-flow-with-floats-6-expected.txt:
- platform/qt/fast/repaint/line-flow-with-floats-7-expected.txt:
- platform/qt/fast/repaint/line-flow-with-floats-8-expected.txt:
- platform/qt/fast/repaint/line-flow-with-floats-9-expected.txt:
- platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/qt/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
- platform/qt/fast/repaint/search-field-cancel-expected.txt:
- platform/qt/fast/repaint/transform-translate-expected.txt:
- platform/qt/fast/replaced/007-expected.txt:
- platform/qt/fast/replaced/replaced-breaking-expected.txt:
- platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt:
- platform/qt/fast/replaced/table-percent-height-expected.txt:
- platform/qt/fast/replaced/table-percent-height-text-controls-expected.txt: Added.
- platform/qt/fast/replaced/three-selects-break-expected.txt:
- platform/qt/fast/replaced/width100percent-checkbox-expected.txt:
- platform/qt/fast/replaced/width100percent-radio-expected.txt:
- platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
- platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.
- platform/qt/fast/ruby/ruby-block-style-not-updated-expected.txt:
- platform/qt/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt:
- platform/qt/fast/ruby/ruby-inline-style-not-updated-expected.txt:
- platform/qt/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt:
- platform/qt/fast/ruby/ruby-inline-table-expected.txt:
- platform/qt/fast/runin/runin-generated-before-content-expected.txt:
- platform/qt/fast/selectors/032-expected.txt:
- platform/qt/fast/selectors/166-expected.txt:
- platform/qt/fast/selectors/unqualified-hover-quirks-expected.txt:
- platform/qt/fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction-expected.txt: Added.
- platform/qt/fast/table/009-expected.txt:
- platform/qt/fast/table/014-expected.txt:
- platform/qt/fast/table/035-expected.txt:
- platform/qt/fast/table/035-vertical-expected.txt:
- platform/qt/fast/table/040-expected.txt:
- platform/qt/fast/table/040-vertical-expected.txt:
- platform/qt/fast/table/041-expected.txt:
- platform/qt/fast/table/absolute-table-at-bottom-expected.txt:
- platform/qt/fast/table/border-collapsing/004-expected.txt:
- platform/qt/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/qt/fast/table/frame-and-rules-expected.txt:
- platform/qt/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
- platform/qt/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
- platform/qt/fast/table/nested-percent-height-table-expected.txt:
- platform/qt/fast/table/overflowHidden-expected.txt:
- platform/qt/fast/table/percent-heights-expected.txt:
- platform/qt/fast/table/table-before-child-style-update-expected.txt:
- platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
- platform/qt/fast/table/table-cell-before-after-content-around-table-expected.txt:
- platform/qt/fast/table/table-cell-before-after-content-around-table-row-expected.txt:
- platform/qt/fast/table/table-display-types-strict-expected.txt:
- platform/qt/fast/table/table-row-before-after-content-around-block-expected.txt:
- platform/qt/fast/table/table-row-before-after-content-around-table-expected.txt:
- platform/qt/fast/table/table-row-before-child-style-update-expected.txt:
- platform/qt/fast/table/table-row-style-not-updated-expected.txt:
- platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.txt:
- platform/qt/fast/table/table-row-style-not-updated-with-before-content-expected.txt:
- platform/qt/fast/table/table-style-not-updated-expected.txt:
- platform/qt/fast/table/tableInsideCaption-expected.txt:
- platform/qt/fast/text/basic/012-expected.txt:
- platform/qt/fast/text/basic/013-expected.txt:
- platform/qt/fast/text/basic/generic-family-reset-expected.txt:
- platform/qt/fast/text/line-breaks-expected.txt:
- platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
- platform/qt/fast/text/whitespace/012-expected.txt:
- platform/qt/fast/text/whitespace/013-expected.txt:
- platform/qt/fast/text/whitespace/014-expected.txt:
- platform/qt/fast/text/whitespace/017-expected.txt:
- platform/qt/fast/text/whitespace/018-expected.txt:
- platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
- platform/qt/fast/transforms/bounding-rect-zoom-expected.txt:
- platform/qt/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt:
- platform/qt/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt:
- platform/qt/fast/transforms/transforms-with-zoom-expected.txt:
- platform/qt/fast/writing-mode/fieldsets-expected.txt:
- platform/qt/http/tests/misc/acid3-expected.txt:
- platform/qt/http/tests/misc/iframe404-expected.txt:
- platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Added.
- platform/qt/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt:
- platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt:
- platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt:
- platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt:
- platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt:
- platform/qt/printing/return-from-printing-mode-expected.txt:
- platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
- platform/qt/svg/as-border-image/svg-as-border-image-2-expected.txt:
- platform/qt/svg/as-border-image/svg-as-border-image-expected.txt:
- platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
- platform/qt/svg/as-image/svg-non-integer-scaled-image-expected.txt: Copied from LayoutTests/platform/qt/fast/reflections/reflection-with-zoom-expected.txt.
- platform/qt/svg/batik/filters/feTile-expected.txt:
- platform/qt/svg/batik/filters/filterRegions-expected.txt:
- platform/qt/svg/batik/masking/maskRegions-expected.txt:
- platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
- platform/qt/svg/batik/text/smallFonts-expected.txt:
- platform/qt/svg/batik/text/textAnchor-expected.txt:
- platform/qt/svg/batik/text/textAnchor2-expected.txt:
- platform/qt/svg/batik/text/textAnchor3-expected.txt:
- platform/qt/svg/batik/text/textEffect-expected.txt:
- platform/qt/svg/batik/text/textEffect3-expected.txt:
- platform/qt/svg/batik/text/textFeatures-expected.txt:
- platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
- platform/qt/svg/batik/text/textLayout-expected.txt:
- platform/qt/svg/batik/text/textLayout2-expected.txt:
- platform/qt/svg/batik/text/textLength-expected.txt:
- platform/qt/svg/batik/text/textOnPath-expected.txt:
- platform/qt/svg/batik/text/textOnPath2-expected.txt:
- platform/qt/svg/batik/text/textOnPath3-expected.txt:
- platform/qt/svg/batik/text/textOnPathSpaces-expected.txt:
- platform/qt/svg/batik/text/textPCDATA-expected.txt:
- platform/qt/svg/batik/text/textPosition2-expected.txt:
- platform/qt/svg/batik/text/textProperties-expected.txt:
- platform/qt/svg/batik/text/textStyles-expected.txt:
- platform/qt/svg/batik/text/verticalText-expected.txt:
- platform/qt/svg/batik/text/verticalTextOnPath-expected.txt:
- platform/qt/svg/batik/text/xmlSpace-expected.txt:
- platform/qt/svg/carto.net/button-expected.txt:
- platform/qt/svg/carto.net/colourpicker-expected.txt:
- platform/qt/svg/carto.net/scrollbar-expected.txt:
- platform/qt/svg/carto.net/selectionlist-expected.txt:
- platform/qt/svg/carto.net/slider-expected.txt:
- platform/qt/svg/carto.net/textbox-expected.txt:
- platform/qt/svg/carto.net/window-expected.txt:
- platform/qt/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt:
- platform/qt/svg/css/group-with-shadow-expected.txt:
- platform/qt/svg/css/text-shadow-multiple-expected.txt:
- platform/qt/svg/custom/bug45331-expected.txt:
- platform/qt/svg/custom/clip-mask-negative-scale-expected.txt: Added.
- platform/qt/svg/custom/dominant-baseline-hanging-expected.txt:
- platform/qt/svg/custom/dominant-baseline-modes-expected.txt:
- platform/qt/svg/custom/font-face-cascade-order-expected.txt:
- platform/qt/svg/custom/font-face-simple-expected.txt:
- platform/qt/svg/custom/fractional-rects-expected.txt: Added.
- platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
- platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
- platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
- platform/qt/svg/custom/glyph-setting-d-attribute-expected.txt:
- platform/qt/svg/custom/image-parent-translation-expected.txt:
- platform/qt/svg/custom/image-small-width-height-expected.txt:
- platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
- platform/qt/svg/custom/invalid-css-expected.txt:
- platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
- platform/qt/svg/custom/js-late-clipPath-creation-expected.txt:
- platform/qt/svg/custom/js-late-gradient-creation-expected.txt:
- platform/qt/svg/custom/js-late-pattern-and-object-creation-expected.txt:
- platform/qt/svg/custom/js-late-pattern-creation-expected.txt:
- platform/qt/svg/custom/js-update-container-expected.txt: Added.
- platform/qt/svg/custom/junk-data-expected.txt:
- platform/qt/svg/custom/linking-uri-01-b-expected.txt:
- platform/qt/svg/custom/missing-xlink-expected.txt:
- platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt:
- platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
- platform/qt/svg/custom/object-sizing-expected.txt:
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
- platform/qt/svg/custom/path-bad-data-expected.txt:
- platform/qt/svg/custom/path-textPath-simulation-expected.txt:
- platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
- platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
- platform/qt/svg/custom/rootmost-svg-xy-attrs-expected.txt:
- platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/qt/svg/custom/stroked-pattern-expected.txt:
- platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
- platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
- platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
- platform/qt/svg/custom/text-hit-test-expected.txt:
- platform/qt/svg/custom/text-letter-spacing-expected.txt:
- platform/qt/svg/custom/text-rotated-gradient-expected.txt:
- platform/qt/svg/custom/text-rotation-expected.txt:
- platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.txt:
- platform/qt/svg/custom/text-tref-03-b-change-href-expected.txt:
- platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt:
- platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.txt:
- platform/qt/svg/custom/text-whitespace-handling-expected.txt:
- platform/qt/svg/custom/text-x-dx-lists-expected.txt:
- platform/qt/svg/custom/text-x-override-in-tspan-child-expected.txt:
- platform/qt/svg/custom/tref-own-content-removal-expected.txt:
- platform/qt/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Added.
- platform/qt/svg/custom/use-detach-expected.txt:
- platform/qt/svg/custom/use-font-face-crash-expected.txt:
- platform/qt/svg/custom/use-instanceRoot-modifications-expected.txt:
- platform/qt/svg/custom/use-modify-container-in-target-expected.txt:
- platform/qt/svg/custom/use-modify-target-container-expected.txt:
- platform/qt/svg/custom/use-modify-target-symbol-expected.txt:
- platform/qt/svg/custom/use-on-g-containing-symbol-expected.txt:
- platform/qt/svg/custom/use-on-g-containing-use-expected.txt:
- platform/qt/svg/custom/use-on-g-expected.txt:
- platform/qt/svg/custom/use-on-rect-expected.txt:
- platform/qt/svg/custom/use-on-symbol-expected.txt:
- platform/qt/svg/custom/use-on-text-expected.txt:
- platform/qt/svg/custom/use-on-use-expected.txt:
- platform/qt/svg/custom/use-recursion-1-expected.txt:
- platform/qt/svg/custom/use-recursion-2-expected.txt:
- platform/qt/svg/custom/use-recursion-3-expected.txt:
- platform/qt/svg/custom/use-recursion-4-expected.txt:
- platform/qt/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
- platform/qt/svg/custom/use-transform-expected.txt:
- platform/qt/svg/custom/viewBox-hit-expected.txt: Added.
- platform/qt/svg/custom/viewbox-syntax-expected.txt:
- platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
- platform/qt/svg/hixie/error/012-expected.txt:
- platform/qt/svg/hixie/perf/003-expected.txt:
- platform/qt/svg/hixie/perf/004-expected.txt:
- platform/qt/svg/hixie/perf/005-expected.txt:
- platform/qt/svg/hixie/perf/006-expected.txt:
- platform/qt/svg/hixie/text/001-expected.txt:
- platform/qt/svg/hixie/text/003-expected.txt:
- platform/qt/svg/hixie/text/003a-expected.txt:
- platform/qt/svg/hixie/text/003b-expected.txt:
- platform/qt/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
- platform/qt/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
- platform/qt/svg/text/append-text-node-to-tspan-expected.txt:
- platform/qt/svg/text/font-size-below-point-five-2-expected.txt:
- platform/qt/svg/text/font-size-below-point-five-expected.txt:
- platform/qt/svg/text/modify-text-node-in-tspan-expected.txt:
- platform/qt/svg/text/remove-text-node-from-tspan-expected.txt:
- platform/qt/svg/text/remove-tspan-from-text-expected.txt:
- platform/qt/svg/text/scaled-font-expected.txt:
- platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
- platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
- platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
- platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
- platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.txt:
- platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.txt:
- platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.txt:
- platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.txt:
- platform/qt/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
- platform/qt/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
- platform/qt/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
- platform/qt/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
- platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
- platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
- platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
- platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
- platform/qt/svg/text/select-x-list-1-expected.txt:
- platform/qt/svg/text/select-x-list-2-expected.txt:
- platform/qt/svg/text/select-x-list-3-expected.txt:
- platform/qt/svg/text/select-x-list-4-expected.txt:
- platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
- platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
- platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
- platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
- platform/qt/svg/text/selection-doubleclick-expected.txt:
- platform/qt/svg/text/selection-tripleclick-expected.txt:
- platform/qt/svg/text/small-fonts-2-expected.txt:
- platform/qt/svg/text/small-fonts-3-expected.txt:
- platform/qt/svg/text/small-fonts-expected.txt:
- platform/qt/svg/text/small-fonts-in-html5-expected.txt:
- platform/qt/svg/text/text-align-01-b-expected.txt:
- platform/qt/svg/text/text-align-02-b-expected.txt:
- platform/qt/svg/text/text-align-03-b-expected.txt:
- platform/qt/svg/text/text-align-04-b-expected.txt:
- platform/qt/svg/text/text-align-05-b-expected.txt:
- platform/qt/svg/text/text-align-06-b-expected.txt:
- platform/qt/svg/text/text-altglyph-01-b-expected.txt:
- platform/qt/svg/text/text-deco-01-b-expected.txt:
- platform/qt/svg/text/text-hkern-expected.txt:
- platform/qt/svg/text/text-overflow-ellipsis-svgfont-expected.txt:
- platform/qt/svg/text/text-path-01-b-expected.txt:
- platform/qt/svg/text/text-path-middle-align-expected.txt:
- platform/qt/svg/text/text-spacing-01-b-expected.txt:
- platform/qt/svg/text/text-text-01-b-expected.txt:
- platform/qt/svg/text/text-text-03-b-expected.txt:
- platform/qt/svg/text/text-text-04-t-expected.txt:
- platform/qt/svg/text/text-text-05-t-expected.txt:
- platform/qt/svg/text/text-text-06-t-expected.txt:
- platform/qt/svg/text/text-text-07-t-expected.txt:
- platform/qt/svg/text/text-text-08-b-expected.txt:
- platform/qt/svg/text/text-tref-01-b-expected.txt:
- platform/qt/svg/text/text-tselect-01-b-expected.txt:
- platform/qt/svg/text/text-tspan-01-b-expected.txt:
- platform/qt/svg/text/text-viewbox-rescale-expected.txt:
- platform/qt/svg/text/text-ws-01-t-expected.txt:
- platform/qt/svg/text/text-ws-02-t-expected.txt:
- platform/qt/svg/transforms/animated-path-inside-transformed-html-expected.txt:
- platform/qt/svg/transforms/svg-css-transforms-clip-path-expected.txt:
- platform/qt/svg/transforms/svg-css-transforms-expected.txt:
- platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
- platform/qt/svg/wicd/rightsizing-grid-expected.txt:
- platform/qt/svg/wicd/sizing-flakiness-expected.txt:
- platform/qt/svg/wicd/test-rightsizing-a-expected.txt:
- platform/qt/svg/wicd/test-rightsizing-b-expected.txt:
- platform/qt/svg/wicd/test-scalable-background-image1-expected.txt:
- platform/qt/svg/wicd/test-scalable-background-image2-expected.txt:
- platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.txt:
- platform/qt/svg/zoom/page/zoom-background-images-expected.txt:
- platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
- platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
- platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
- platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
- platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
- platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
- platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Copied from LayoutTests/platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt.
- platform/qt/svg/zoom/page/zoom-svg-as-image-expected.txt: Copied from LayoutTests/platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt.
- platform/qt/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Copied from LayoutTests/platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt.
- platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
- platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt:
- platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
- platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
- platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
- platform/qt/tables/mozilla/bugs/bug10269-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug10296-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1055-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug106816-expected.txt:
- platform/qt/tables/mozilla/bugs/bug113235-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug113424-expected.txt:
- platform/qt/tables/mozilla/bugs/bug11384q-expected.txt:
- platform/qt/tables/mozilla/bugs/bug11384s-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
- platform/qt/tables/mozilla/bugs/bug126742-expected.txt:
- platform/qt/tables/mozilla/bugs/bug131020-expected.txt:
- platform/qt/tables/mozilla/bugs/bug13118-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1318-expected.txt:
- platform/qt/tables/mozilla/bugs/bug139524-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug159108-expected.txt:
- platform/qt/tables/mozilla/bugs/bug17130-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug17130-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug17138-expected.txt:
- platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
- platform/qt/tables/mozilla/bugs/bug19061-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug19061-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug24200-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2479-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/qt/tables/mozilla/bugs/bug26553-expected.txt: Added.
- platform/qt/tables/mozilla/bugs/bug2886-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug28928-expected.txt:
- platform/qt/tables/mozilla/bugs/bug29326-expected.txt:
- platform/qt/tables/mozilla/bugs/bug30692-expected.txt:
- platform/qt/tables/mozilla/bugs/bug3309-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug33137-expected.txt:
- platform/qt/tables/mozilla/bugs/bug33855-expected.txt:
- platform/qt/tables/mozilla/bugs/bug39209-expected.txt:
- platform/qt/tables/mozilla/bugs/bug42187-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4382-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4527-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46480-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46480-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug5538-expected.txt:
- platform/qt/tables/mozilla/bugs/bug6304-expected.txt:
- platform/qt/tables/mozilla/bugs/bug67915-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug69187-expected.txt:
- platform/qt/tables/mozilla/bugs/bug7112-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug7112-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug73321-expected.txt:
- platform/qt/tables/mozilla/bugs/bug8032-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug83786-expected.txt: Added.
- platform/qt/tables/mozilla/bugs/bug8381-expected.txt:
- platform/qt/tables/mozilla/bugs/bug9271-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug9271-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug96334-expected.txt:
- platform/qt/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/qt/tables/mozilla/core/bloomberg-expected.txt:
- platform/qt/tables/mozilla/core/margins-expected.txt:
- platform/qt/tables/mozilla/core/misc-expected.txt:
- platform/qt/tables/mozilla/dom/tableDom-expected.txt:
- platform/qt/tables/mozilla/marvin/backgr_index-expected.txt:
- platform/qt/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/qt/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/qt/tables/mozilla/marvin/tables_align_center-expected.txt:
- platform/qt/tables/mozilla/marvin/x_table_align_center-expected.txt:
- platform/qt/tables/mozilla/other/test3-expected.txt:
- platform/qt/tables/mozilla/other/test6-expected.txt:
- platform/qt/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- platform/qt/tables/mozilla/other/wa_table_tr_align-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug61042-1-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug61042-2-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
- platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
- platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
- platform/qt/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/qt/tables/mozilla_expected_failures/core/captions2-expected.txt:
- platform/qt/tables/mozilla_expected_failures/core/captions3-expected.txt:
- platform/qt/tables/mozilla_expected_failures/core/standards1-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- platform/qt/tables/mozilla_expected_failures/other/test4-expected.txt:
- platform/qt/transforms/2d/zoom-menulist-expected.txt:
- platform/qt/transforms/svg-vs-css-expected.txt:
- 2:18 AM Changeset in webkit [148595] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] GraphicsContext3D: don't initialize m_extensions in the constructor
https://bugs.webkit.org/show_bug.cgi?id=114726
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-17
Reviewed by Carlos Garcia Campos.
m_extensions is now initialized on demand by
GraphicsContext3D::getExtensions().
Doing it in the constructor produces a crash, because
Extensions3DOpenGLES() calls glGetString before the WebGL context
is current.
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- 1:57 AM Changeset in webkit [148594] by
-
- 2 edits in trunk/Tools
[Qt] Enable sub-pixel layout.
https://bugs.webkit.org/show_bug.cgi?id=113199
Reviewed by Jocelyn Turcotte.
- qmake/mkspecs/features/features.pri:
- 1:18 AM Changeset in webkit [148593] by
-
- 62 edits in trunk/Source/WebCore
Replace JSC-specific IDL extended attributes with generic (JSC+V8) ones, now that the distinction no longer matters
https://bugs.webkit.org/show_bug.cgi?id=114712
Reviewed by Dan Bernstein.
No behavior change expected.
- bindings/scripts/IDLAttributes.txt: Remove the JSFoo attributes
that have bare Foo equivalents.
- bindings/scripts/CodeGeneratorJS.pm: Remove support for JSFoo
aliases.
(GetGenerateIsReachable):
(GetCustomIsReachable):
(ShouldGenerateToJSDeclaration):
(ShouldGenerateToJSImplementation):
(HasCustomConstructor):
(HasCustomGetter):
(HasCustomSetter):
(HasCustomMethod):
Replace JSFoo attributes with equivalen Foo attributs in all files
below:
- Modules/geolocation/Geolocation.idl:
- Modules/indexeddb/IDBDatabase.idl:
- Modules/indexeddb/IDBObjectStore.idl:
- Modules/webaudio/DOMWindowWebAudio.idl:
- Modules/websockets/DOMWindowWebSocket.idl:
- Modules/websockets/WorkerContextWebSocket.idl:
- css/CSSRule.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSValue.idl:
- css/MediaList.idl:
- css/StyleMedia.idl:
- css/StyleSheet.idl:
- dom/MessagePort.idl:
- dom/MutationObserver.idl:
- dom/Node.idl:
- fileapi/Blob.idl:
- html/HTMLDocument.idl:
- html/HTMLTemplateElement.idl:
- html/canvas/ArrayBuffer.idl:
- html/canvas/CanvasRenderingContext.idl:
- html/canvas/DataView.idl:
- html/canvas/EXTDrawBuffers.idl:
- html/canvas/EXTTextureFilterAnisotropic.idl:
- html/canvas/OESElementIndexUint.idl:
- html/canvas/OESStandardDerivatives.idl:
- html/canvas/OESTextureFloat.idl:
- html/canvas/OESTextureHalfFloat.idl:
- html/canvas/OESVertexArrayObject.idl:
- html/canvas/WebGLCompressedTextureATC.idl:
- html/canvas/WebGLCompressedTexturePVRTC.idl:
- html/canvas/WebGLCompressedTextureS3TC.idl:
- html/canvas/WebGLDebugRendererInfo.idl:
- html/canvas/WebGLDebugShaders.idl:
- html/canvas/WebGLDepthTexture.idl:
- html/canvas/WebGLLoseContext.idl:
- html/track/TextTrack.idl:
- html/track/TextTrackCue.idl:
- html/track/TextTrackList.idl:
- loader/appcache/DOMApplicationCache.idl:
- page/BarInfo.idl:
- page/Console.idl:
- page/DOMSelection.idl:
- page/DOMWindow.idl:
- page/History.idl:
- page/Location.idl:
- page/MemoryInfo.idl:
- page/Navigator.idl:
- page/Screen.idl:
- page/WorkerNavigator.idl:
- plugins/DOMMimeTypeArray.idl:
- plugins/DOMPluginArray.idl:
- storage/Storage.idl:
- workers/AbstractWorker.idl:
- workers/SharedWorker.idl:
- workers/Worker.idl:
- workers/WorkerContext.idl:
- workers/WorkerLocation.idl:
- xml/XMLHttpRequestUpload.idl:
- 12:38 AM Changeset in webkit [148592] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Add webkit_web_page_get_id() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=111938
Reviewed by Anders Carlsson.
Add API to the web extensions API to get the identifier of a web
page.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(methodCallCallback): Check the page ID matches the one returned
by webkit_web_page_get_id().
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkit_web_page_get_id):
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h:
Apr 16, 2013:
- 9:58 PM Changeset in webkit [148591] by
-
- 2 edits in trunk/Websites/webkit.org
Update team.html to use contributors.json instead of committers.py
https://bugs.webkit.org/show_bug.cgi?id=114720
Reviewed by Ryosuke Niwa.
Updating the team.html to use contributors.json. Also removing the unused field 'area'
from the contributors information.
- team.html:
- 8:55 PM Changeset in webkit [148590] by
-
- 7 edits in trunk/Source
Re-name Page::layoutMilestones() to Page::requestedLayoutMilestones()
https://bugs.webkit.org/show_bug.cgi?id=114713
Reviewed by Simon Fraser.
Source/WebCore:
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::addLayoutMilestones):
(WebCore::Page::removeLayoutMilestones):
(WebCore::Page::isCountingRelevantRepaintedObjects):
- page/Page.h:
(WebCore::Page::requestedLayoutMilestones):
(Page):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _layoutMilestones]):
- 7:24 PM WebKit Team edited by
- (diff)
- 7:14 PM Changeset in webkit [148589] by
-
- 4 edits in trunk/Tools
Add Efl WebKit2 EWS bot
https://bugs.webkit.org/show_bug.cgi?id=114564
Reviewed by Ryosuke Niwa.
Added EflWK2EWS, and add myself a watcher for EflWK2EWS.
Also add a deprecated EflWK2Port class.
Besides clean up eflews watchers.
- QueueStatusServer/config/queues.py:
- Scripts/webkitpy/common/config/ews.json:
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(EflPort.build_webkit_command):
(EflWK2Port):
(EflWK2Port.build_webkit_command):
- 6:41 PM Changeset in webkit [148588] by
-
- 4 edits1 add in trunk/Tools
Isolate Early Warning System definitions into a JSON
https://bugs.webkit.org/show_bug.cgi?id=114558
Reviewed by Benjamin Poulain.
Added ews.json to common/config, and made tool/commands/init.py call
AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
Reland the patch since the EWS failure was a false positive.
- Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
- Scripts/webkitpy/tool/commands/init.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.init):
(AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest._default_expected_logs):
(_test_ews):
(test_ewses):
- 6:13 PM Changeset in webkit [148587] by
-
- 2 edits in trunk/Source/WTF
Harden FastMalloc against partial pointer overflows
https://bugs.webkit.org/show_bug.cgi?id=114716
Reviewed by Gavin Barraclough.
Bite the bullet and perform object alignment checks on free.
malloc/free micro benchmark shows a regression, but real
benchmarks don't. There's a little code motion in this avoid
taking too much of a performance hit. In addition to the
alignment check we also validate the containing span as
we've already taken the hit of finding it.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- 6:01 PM Changeset in webkit [148586] by
-
- 3 edits in trunk/Source/WebCore
[CMake] Fix dependecy calculation for generated inspector files
https://bugs.webkit.org/show_bug.cgi?id=114092
Reviewed by Brent Fulgham.
At least in a generated Visual Studio solution the files generated via
CodeGeneratorInspector.py are considered outdated all the time because
the code generator only touches the file when the content changed.
Add an --write_always parameter to the script to touch the file always.
- CMakeLists.txt:
- inspector/CodeGeneratorInspector.py:
- 5:38 PM Changeset in webkit [148585] by
-
- 9 edits in trunk/Source
Clone storage namespaces for window.open
https://bugs.webkit.org/show_bug.cgi?id=114703
Reviewed by Sam Weinig.
Source/WebCore:
Pass the new page to StorageNamespace::copy.
- page/Chrome.cpp:
(WebCore::Chrome::createWindow):
- storage/StorageNamespace.h:
(StorageNamespace):
- storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::copy):
- storage/StorageNamespaceImpl.h:
(WebCore):
(StorageNamespaceImpl):
Source/WebKit2:
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::clone):
New helper function for cloning a storage area.
(WebKit::StorageManager::StorageArea::setItem):
Correctly handle the copy-on-write feature of StorageMap if it has multiple storage areas pointing to it.
(WebKit::StorageManager::StorageArea::removeItem):
Ditto.
(WebKit::StorageManager::SessionStorageNamespace::cloneTo):
Add cloned storage areas.
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::copy):
Create a new session storage namespace for the new page.
- 5:30 PM Changeset in webkit [148584] by
-
- 6 edits in trunk
Fix fallout after r148545.
Source/WebCore:
- platform/text/TextChecking.h:
Move Platform defines that were incorrectly in WebCore, into Platform.h
Source/WTF:
- wtf/Platform.h:
Move Platform defines that were incorrectly in WebCore, into Platform.h
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
Remove calls to non-existent API functions.
- 5:21 PM Changeset in webkit [148583] by
-
- 6 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r148576.
http://trac.webkit.org/changeset/148576
https://bugs.webkit.org/show_bug.cgi?id=114714
WebCore is building some of these same files (Requested by
bfulgham on #webkit).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj:
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj.filters:
- 5:09 PM Changeset in webkit [148582] by
-
- 4 edits2 adds in trunk
[CSS Exclusions] polygon shape-inside layout fails
https://bugs.webkit.org/show_bug.cgi?id=114402
Source/WebCore:
Reviewed by Dirk Schulze.
The firstIncludedIntervalLogicalTop() method's implementation relied on optimistic
assumptions about floating point accuracy which, in rare cases, caused it to discard
first-fit locations based on the intersection of the minLogicalIntervalTop offset edge
and a polygon offset edge. Now: we do not verify that first-fit locations based on the
intersection of an offset edge and the minLogicalIntervalTop offset edge are below
the horizontal minLogicalIntervalTop line. They're essentially below the line "by definition".
Test: fast/exclusions/shape-inside/shape-inside-polygon-layout.html
- rendering/ExclusionPolygon.cpp:
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Avoid floating point problems
when checking intersections with the offset edge based on minLogicalIntervalTop.
- rendering/ExclusionPolygon.h:
(WebCore::OffsetPolygonEdge::OffsetPolygonEdge): Initialize the basis field.
(WebCore::OffsetPolygonEdge::basis): Report what the offset edge is "based on": a polygon
edge, the top of the line, or a (reflex) vertex.
(OffsetPolygonEdge): Added the Basis enum to enable tracking what the geometry of
an offset edge is based on.
LayoutTests:
Verify that subsequent polygon shape-inside lines are vertically adjacent.
Reviewed by Dirk Schulze.
- fast/exclusions/shape-inside/shape-inside-polygon-layout-expected.txt: Added.
- fast/exclusions/shape-inside/shape-inside-polygon-layout.html: Added.
- 5:07 PM Changeset in webkit [148581] by
-
- 1 edit3 adds in trunk/LayoutTests
[CSS Shaders] Add a test with a vertex, fragment shader pair that compiles but don't link
https://bugs.webkit.org/show_bug.cgi?id=114636
Added a test to check that unavailable varyings in fragment shaders
don't lead to unexpected crashes due to linking errors.
The current implementation does not crash, and this makes sure it
won't in future.
Reviewed by Dean Jackson.
- css3/filters/custom/custom-filter-unavailable-varying-expected.html: Added.
- css3/filters/custom/custom-filter-unavailable-varying.html: Added.
- css3/filters/resources/unavailable-varying.fs: Added.
- 5:05 PM Changeset in webkit [148580] by
-
- 4 edits in branches/safari-536.30-branch/Source
Versioning.
- 5:05 PM Changeset in webkit [148579] by
-
- 2 edits in trunk/Source/WebCore
Further unreviewed build fix: protect JSAudioBufferCustom with a ENABLE(WEB_AUDIO) check.
- bindings/js/JSAudioBufferCustom.cpp:
- 5:03 PM Changeset in webkit [148578] by
-
- 1 copy in tags/Safari-536.30
New Tag.
- 5:03 PM Changeset in webkit [148577] by
-
- 4 edits in trunk/Source/WebKit/win
Unreviewed. Build fix for Windows.
- WebCoreSupport/WebContextMenuClient.cpp:
- WebCoreSupport/WebDragClient.cpp:
- WebFrame.cpp:
- 5:02 PM Changeset in webkit [148576] by
-
- 6 edits in trunk/Source/JavaScriptCore
[Windows, WinCairo] Stop individually building WTF files in JSC.
https://bugs.webkit.org/show_bug.cgi?id=114705
Reviewed by Anders Carlsson.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
Export additional String/fastMalloc symbols needed by JSC program.
- JavaScriptCore.vcproj/jsc/jsc.vcproj: Don't manually build
WTF implementation files (a second time!) in this project.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
Export additional String/fastMalloc symbols needed by JSC program.
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj: Don't manually
build WTF implementation files (a second time!) in this project.
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj.filters: Ditto.
- 4:52 PM Changeset in webkit [148575] by
-
- 5 edits in trunk/Source/WebKit/blackberry
Redo spellchecking of a field if the layout has changed
https://bugs.webkit.org/show_bug.cgi?id=114700
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-04-16
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
PR258637
If we insert a child node during spellchecking, the current request along
with the requests in queue become stale. The offsets were calculated when
they were created are no longer valid. We clear the queue by setting sequence
id to -1 and trigger spell checking again. We only trigger re-checking
if the layout change occurred during processing of a request. This is
maintained with the m_request pointer as it should be cleared after use.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::layoutFinished):
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::requestCheckingOfString):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
(WebKit):
(BlackBerry::WebKit::InputHandler::stopPendingSpellCheckRequests):
- WebKitSupport/InputHandler.h:
(InputHandler):
- 4:52 PM Changeset in webkit [148574] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
CSS Variables aren't available on safari-536.30-branch.
<rdar://problem/13668920>
Patch by David Farler <dfarler@apple.com> on 2013-04-16
- platform/mac/Skipped:
Skip fast/css/variables/deferred-image-load-from-variable.html
- 4:47 PM Changeset in webkit [148573] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
Skip fast/dom/Geolocation/watchPosition-unique.html on safari-536.30-branch
<rdar://problem/13668237>
Patch by David Farler <dfarler@apple.com> on 2013-04-16
- platform/mac/Skipped:
Skip fast/dom/Geolocation/watchPosition-unique.html.
- 4:45 PM Changeset in webkit [148572] by
-
- 1 edit in branches/safari-536.30-branch/Source/WebKit2/win/WebKit2.def
Windows build fix after r139111.
- 4:45 PM Changeset in webkit [148571] by
-
- 4 edits in trunk
.: [CMake] Do not use JAVASCRIPTCORE_DIR in add_custom_command() of JavaScriptcore project
https://bugs.webkit.org/show_bug.cgi?id=114265
Reviewed by Brent Fulgham.
- Source/cmake/WebKitMacros.cmake: Removed macro GENERATE_HASH_LUT.
Source/JavaScriptCore: [CMake] Do not use JAVASCRIPTCORE_DIR in add_custom_command() of JavaScriptCore project
https://bugs.webkit.org/show_bug.cgi?id=114265
Reviewed by Brent Fulgham.
Use CMAKE_CURRENT_SOURCE_DIR instead, since it provides the same value and is more
understandable. Also move the GENERATE_HASH_LUT macro into the CMakeLists.txt
of JavaScriptCore to avoid the usage of JAVASCRIPTCORE_DIR there too.
- CMakeLists.txt:
- 4:31 PM Changeset in webkit [148570] by
-
- 6 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should be able to query Structure without modifying it
https://bugs.webkit.org/show_bug.cgi?id=114708
Reviewed by Oliver Hunt.
This is work towards allowing the DFG, and FTL, to run on a separate thread.
The idea is that the most evil thing that the DFG does that has thread-safety
issues is fiddling with Structures by calling Structure::get(). This can lead
to rematerialization of property tables, which is definitely not thread-safe
due to how StringImpl works. So, this patch completely side-steps the problem
by creating a new version of Structure::get, called
Structure::getWithoutMaterializing, which may choose to do an O(n) search if
necessary to avoid materialization. I believe this should be fine - the DFG
does't call into these code path often enough for this to matter, and most of
the time, the Structure that we call this on will already have a property
table because some inline cache would have already called ::get() on that
Structure.
Also cleaned up the materialization logic: we can stop the search as soon as
we find any Structure with a property table rather than searching all the way
for a pinned one.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
- runtime/Structure.cpp:
(JSC::Structure::findStructuresAndMapForMaterialization):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::getWithoutMaterializing):
(JSC):
- runtime/Structure.h:
(Structure):
- runtime/StructureInlines.h:
(JSC::Structure::getWithoutMaterializing):
(JSC):
- 4:31 PM Changeset in webkit [148569] by
-
- 4 edits in trunk/Source/WebCore
Changed the default debugger from GDB to LLDB for the 'All Source' scheme in WebKit.xcworkspace.
Patch by Andy Estes <aestes@apple.com> on 2013-04-16
Rubber-stamped by Dan Bernstein.
- WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
- 4:26 PM Changeset in webkit [148568] by
-
- 2 edits in trunk/Source/JavaScriptCore
Another Windows build fix attempt.
- runtime/JSGlobalData.h:
(JSGlobalData):
- 4:25 PM Changeset in webkit [148567] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
<rdar://problem/13668125> Elgar: fast/block/float/float-not-removed-from-pre-block.html fails: expected file needs updating: two spaces
Patch by David Farler <dfarler@apple.com> on 2013-04-16
- fast/block/float/float-not-removed-from-pre-block-expected.txt:
Two spaces instead of one.
- 4:17 PM Changeset in webkit [148566] by
-
- 5 edits1 add in trunk/Source/WebCore
Repeated use of decodeAudioData() causes leak
https://bugs.webkit.org/show_bug.cgi?id=114709
Reviewed by Geoffrey Garen.
Report the correct size of the AudioBuffer to the garbage collector so that creating
these large buffers will trigger garbage collection.
- Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::memoryCost): Added; simple sum of the buffer sizes in m_channels;
- Modules/webaudio/AudioBuffer.h:
- Modules/webaudio/AudioBuffer.idl: Add the CustomToJSObject flag.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSAudioBufferCustom.cpp: Added.
(WebCore::toJS): Added; report the extra size of an AudioBuffer when the wrapper
is created.
- 4:01 PM Changeset in webkit [148565] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Viewport not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=114704
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-04-16.
Reviewed by Rob Buis.
Internally reviewed by Konrad Piascik.
PR: 326260
The applyDeviceScaleFactorInCompositor setting is now generated from
Settings.in after rebase, the setter should be setApplyDeviceScaleFactorInCompositor()
instead of setApplyPageScaleFactorInCompositor().
The setting can be removed from WebSettings and use a simpler way
instead in the future if there are no issues when TextAutoSizer is
enabled. Just keep it for now.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::setApplyDeviceScaleFactorInCompositor):
- Api/WebSettings.h:
- 4:01 PM Changeset in webkit [148564] by
-
- 12 edits1 add in trunk/Source
Need a new layout milestone to notify bundle clients when the header has been
flushed
https://bugs.webkit.org/show_bug.cgi?id=114706
-and corresponding-
<rdar://problem/13657284>
Reviewed by Simon Fraser.
Source/WebCore:
New LayoutMilestone is DidFirstFlushForHeaderLayer.
- page/LayoutMilestones.h:
New API to allow removing a LayoutMilestone.
- WebCore.exp.in:
- page/Page.cpp:
(WebCore::Page::removeLayoutMilestones):
- page/Page.h:
(Page):
New boolean member variable m_headerLayerAwaitingFirstFlush keeps track of whether
we need to send the DidFirstFlushForHeaderLayer milestone.
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
Send the milestone if appropriate.
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
Set m_headerLayerAwaitingFirstFlush to true for a newly created layer.
(WebCore::RenderLayerCompositor::updateLayerForHeader):
Source/WebKit2:
Make this new LayoutMilestone private at the API layer.
- Shared/API/c/WKPageLoadTypes.h:
- Shared/API/c/WKPageLoadTypesPrivate.h: Added.
Handle the new milestone.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toWKLayoutMilestones):
(WebKit::toLayoutMilestones):
New file to make the milestone private.
- WebKit2.xcodeproj/project.pbxproj:
Add or remove the DidFirstFlushForHeaderLayer millstone based on whether we just
added or removed a header.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::setHeaderLayerWithHeight):
- 4:01 PM Changeset in webkit [148563] by
-
- 3 edits in branches/dfgFourthTier/WebKitLibraries
Updated LLVM drops to include MCJIT fixes.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 3:59 PM Changeset in webkit [148562] by
-
- 2 edits in trunk/Source/JavaScriptCore
Try to fix the Windows build.
- runtime/JSGlobalData.h:
- 3:58 PM Changeset in webkit [148561] by
-
- 3 edits in branches/dfgFourthTier/Tools
fourthTier: Update LLVM-related build scripts to copy generated headers as well
https://bugs.webkit.org/show_bug.cgi?id=114551
Reviewed by Oliver Hunt.
Also added the ability to use something other than bzip2 compression, since although
it is great for checking things into the tree, it increases turn-around times when
experimenting.
- Scripts/copy-webkitlibraries-to-product-directory:
(unpackIfNecessary):
- Scripts/export-llvm-build:
- 3:58 PM Changeset in webkit [148560] by
-
- 3 edits in trunk/Source/WebCore
PlugIn Snapshotting: Crashes refreshing non-main-frame PDFPlugins
https://bugs.webkit.org/show_bug.cgi?id=114702
<rdar://problem/13542020>
Reviewed by Dean Jackson.
If:
a) a plugin fails all the tests in willCreatePlugIn, so it is WaitingForSnapshot there
b) primary plugin detection attempts to restart a plugin between the
time that willCreatePlugIn and didCreatePlugIn fire
c) when didCreatePlugIn fires, shouldAlwaysAutoStart() returns true,
because the plug-in is whitelisted,
we end up reattach()ing and going to Restarted state, and then going straight
to Playing state in didCreatePlugIn.
Instead, primary plugin promotion should be deferred until after the plugin is created,
so that we can take that one last bit of information (shouldAlwaysAutoStart) into account
before restarting and reattaching the plug-in.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn):
(WebCore::HTMLPlugInImageElement::restartSnapshottedPlugIn):
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):
(WebCore::HTMLPlugInImageElement::subframeLoaderDidCreatePlugIn):
- html/HTMLPlugInImageElement.h:
- 3:52 PM Changeset in webkit [148559] by
-
- 4 edits in branches/safari-536.30-branch/Source
Fixing incorrect versioning.
- 3:51 PM Changeset in webkit [148558] by
-
- 2 edits in trunk/Source/WebKit/gtk
Fix speling error.
- WebCoreSupport/WebViewInputMethodFilter.cpp:
- 3:38 PM Changeset in webkit [148557] by
-
- 3 edits in trunk/Source/WebKit/efl
More EFL build fixes.
- ewk/ewk_frame.cpp:
- ewk/ewk_view.cpp:
- 3:38 PM Changeset in webkit [148556] by
-
- 1 edit in branches/safari-536.30-branch/LayoutTests/fast/parser/document-open-in-unload.html
Change testRunner to layoutTestController.
- 3:35 PM Changeset in webkit [148555] by
-
- 2 edits in trunk/Source/WebCore
ASSERTION FAILED: i < size(), UNKNOWN in WebCore::ChannelMergerNode::process
https://bugs.webkit.org/show_bug.cgi?id=112657
Avoid to access input bus in checkNumberOfChannelsForInput() before the
bus is updated with AudioNode::checkNumberOfChannelsForInput().
Reviewed by Chris Rogers.
- Modules/webaudio/ChannelMergerNode.cpp:
(WebCore::ChannelMergerNode::checkNumberOfChannelsForInput):
- 3:35 PM Changeset in webkit [148554] by
-
- 2 edits in trunk/Source/WebKit/gtk
Another GTK+ build fix.
- WebCoreSupport/WebViewInputMethodFilter.cpp:
- 3:33 PM Changeset in webkit [148553] by
-
- 2 edits in trunk/Source/WebKit2
Another EFL build fix.
- WebProcess/WebPage/efl/WebPageEfl.cpp:
- 3:30 PM Changeset in webkit [148552] by
-
- 4 edits in trunk/Source/WebKit/gtk
GTK+ build fix attempt.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/WebViewInputMethodFilter.cpp:
- webkit/webkitwebframe.cpp:
- 3:28 PM Changeset in webkit [148551] by
-
- 3 edits in trunk/Source/WebCore
Even more Windows build fix and a Qt minimal build fix attempt.
- html/parser/XSSAuditorDelegate.cpp:
- page/win/FrameCGWin.cpp:
- 3:24 PM Changeset in webkit [148550] by
-
- 2 edits in trunk/Source/WebKit/efl
EFL build fix after r148545.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- 3:22 PM Changeset in webkit [148549] by
-
- 3 edits in trunk/Source/WebCore
More Windows build fixes.
- platform/win/DragDataWin.cpp:
- platform/win/PasteboardWin.cpp:
- 3:03 PM Changeset in webkit [148548] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix.
- page/win/FrameWin.cpp:
- 3:01 PM Changeset in webkit [148547] by
-
- 2 edits in trunk/Source/WebCore
PlugIns that resize in user gestures should be immune to snapshotting
https://bugs.webkit.org/show_bug.cgi?id=114697
<rdar://problem/13666258>
Reviewed by Tim Horton.
Now that we snapshot plugins if they resize above the snapshotting threshold,
we need to make sure that we don't do it in response to a user gesture
such as a click.
Due to the complexities of real-world content and the way they often do
things using timeout, I copied the code from the generic user gesture
timeout, which gives a 5 second grace period after clicks.
- html/HTMLPlugInImageElement.cpp:
(WebCore::documentHadRecentUserGesture): New static function to share the code for
checking the time since the last click (or whatever).
(WebCore::HTMLPlugInImageElement::checkSizeChangeForSnapshotting): Make sure
to test for a user gesture.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Move the
code into the new function.
- 2:55 PM Changeset in webkit [148546] by
-
- 2 edits in trunk/LayoutTests
[Mac] compositing/background-color/background-color-change-to-text.html fails on some bots
https://bugs.webkit.org/show_bug.cgi?id=106186
- platform/mac/TestExpectations:
Mark 7 other tests that fall under this category as flakey.
- 2:54 PM Changeset in webkit [148545] by
-
- 67 edits in trunk/Source
Remove more #includes from Frame.h
https://bugs.webkit.org/show_bug.cgi?id=114642
Reviewed by Anders Carlsson.
Source/WebCore:
Convert Editor, FrameSelection, EventHandler and AnimationController into
OwnPtrs, to avoid inclusion.
- accessibility/AXObjectCache.cpp:
- accessibility/AccessibilityObject.cpp:
- accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
- bindings/objc/DOM.mm:
- dom/CharacterData.cpp:
- dom/ContainerNode.cpp:
- dom/Element.cpp:
- editing/AlternativeTextController.cpp:
- editing/CompositeEditCommand.cpp:
- editing/DeleteButtonController.h:
- editing/EditingStyle.cpp:
- editing/InsertLineBreakCommand.cpp:
- editing/SpellChecker.cpp:
- editing/SpellingCorrectionCommand.cpp:
- editing/TextInsertionBaseCommand.cpp:
- history/CachedFrame.cpp:
- html/HTMLAnchorElement.cpp:
- html/HTMLInputElement.cpp:
- html/HTMLPlugInElement.cpp:
- html/HTMLSelectElement.cpp:
- html/HTMLTextAreaElement.cpp:
- html/HTMLTextFormControlElement.cpp:
- html/TextFieldInputType.cpp:
- html/shadow/ClearButtonElement.cpp:
- html/shadow/MediaControlElements.cpp:
- html/shadow/SliderThumbElement.cpp:
- inspector/InspectorPageAgent.h:
- loader/FrameLoader.cpp:
- page/DOMWindow.cpp:
- page/Frame.cpp:
- page/Frame.h:
- page/FrameView.cpp:
- page/FrameView.h:
- page/Page.cpp:
- page/TouchAdjustment.cpp:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
- platform/gtk/PasteboardGtk.cpp:
- platform/qt/ClipboardQt.cpp:
- rendering/HitTestResult.cpp:
- rendering/RenderBlock.cpp:
- rendering/RenderEmbeddedObject.cpp:
- rendering/RenderLayer.cpp:
- rendering/RenderNamedFlowThread.cpp:
- rendering/RenderObject.cpp:
- rendering/RenderSnapshottedPlugIn.cpp:
- svg/graphics/SVGImage.cpp:
- testing/Internals.cpp:
Source/WebKit/mac:
- WebView/WebFrame.mm:
- WebView/WebHTMLRepresentation.mm:
- WebView/WebView.mm:
Source/WebKit/qt:
- WebCoreSupport/DragClientQt.cpp:
- WebCoreSupport/FrameLoaderClientQt.cpp:
- WebCoreSupport/QWebFrameAdapter.cpp:
- WebCoreSupport/QWebPageAdapter.cpp:
Source/WebKit2:
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/WebPage/WebFrame.cpp:
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
- WebProcess/WebPage/mac/WebPageMac.mm:
- WebProcess/WebPage/qt/WebPageQt.cpp:
- 2:35 PM Changeset in webkit [148544] by
-
- 4 edits2 copies in branches/safari-536.30-branch
Merge r125955. <rdar://problem/13485383>
- 2:22 PM Changeset in webkit [148543] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Update WebPage.{h, cpp} for supporting web filesystem
https://bugs.webkit.org/show_bug.cgi?id=114698
Reviewed by Rob Buis.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::clearBrowsingData):
(BlackBerry::WebKit::WebPage::clearWebFileSystem):
(WebKit):
- Api/WebPage.h:
- 2:20 PM Changeset in webkit [148542] by
-
- 2 edits in trunk/Source/WebCore
Speculative Windows build fix.
- platform/win/ContextMenuWin.cpp:
- 2:07 PM Changeset in webkit [148541] by
-
- 2 edits in trunk
Changed the default debugger from GDB to LLDB for the 'All Source' scheme in WebKit.xcworkspace.
Rubber-stamped by Dan Bernstein.
- WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
- 1:42 PM Changeset in webkit [148540] by
-
- 13 edits in trunk/Source/WebCore
[Mac] in-band cues sometimes displayed late
https://bugs.webkit.org/show_bug.cgi?id=114629
Reviewed by Jer Noble.
No new tests, this deals with a platform-specific issue that is extremely timing dependent.
- html/track/InbandTextTrack.cpp:
(WebCore::TextTrackCueMap::add): New, two way cue data <-> cue map.
(WebCore::TextTrackCueMap::find):
(WebCore::TextTrackCueMap::remove):
(WebCore::InbandTextTrack::updateCueFromCueData): New, update an existing cue. Set cue end time
to video duration if it is unknown.
(WebCore::InbandTextTrack::addGenericCue): Look for existing cues without considering duration
so we can match incomplete cues.
(WebCore::InbandTextTrack::updateGenericCue): New, update an existing cue. This allows us to
add in-band cues as soon as we get them from the media engine and update them as more
information becomes available.
(WebCore::InbandTextTrack::removeGenericCue): New, remove an existing cue. This is necessary
because we never want to keep an incomplete cue when a seek happens.
(WebCore::InbandTextTrack::removeCue): New, base class override so we can keep the two way
map up to date.
- html/track/InbandTextTrack.h:
- html/track/TextTrack.cpp:
(WebCore::TextTrack::addCue): TextTrack::removeCue takes a RefPtr.
(WebCore::TextTrack::removeCue): Take a RefPtr.
(WebCore::TextTrack::hasCue): Allow caller to request match without considering end time.
- html/track/TextTrack.h:
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue): Initialize m_processingCueChanges.
(WebCore::TextTrackCue::willChange): Renamed from cueWillChange. Use m_processingCueChanges
to avoid thrashing the track when many cue properties will change.
(WebCore::TextTrackCue::didChange): Renamed from cueDidChange. Use m_processingCueChanges
to avoid thrashing the track when many cue properties will change.
(WebCore::TextTrackCue::setId): cueWillChange -> willChange. cueDidChange -> didChange.
(WebCore::TextTrackCue::setStartTime): Ditto.
(WebCore::TextTrackCue::setEndTime): Ditto.
(WebCore::TextTrackCue::setPauseOnExit): Ditto.
(WebCore::TextTrackCue::setVertical): Ditto.
(WebCore::TextTrackCue::setSnapToLines): Ditto.
(WebCore::TextTrackCue::setLine): Ditto.
(WebCore::TextTrackCue::setPosition): Ditto.
(WebCore::TextTrackCue::setSize): Ditto.
(WebCore::TextTrackCue::setAlign): Ditto.
(WebCore::TextTrackCue::setText): Ditto.
(WebCore::TextTrackCue::setRegionId): Ditto.
(WebCore::TextTrackCue::isEqual): Renamed from operator==, take match rules param.
- html/track/TextTrackCue.h:
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::isEqual): Renamed from operator==, take match rules param.
- html/track/TextTrackCueGeneric.h:
- platform/graphics/InbandTextTrackPrivateClient.h: Make GenericCueData refcounted.
(WebCore::GenericCueData::create): New.
(WebCore::GenericCueData::status): Ditto.
(WebCore::GenericCueData::setStatus): Ditto.
(WebCore::GenericCueData::GenericCueData):
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCue): Add cues as soon as we get them from the media
engine, update duration once we know it.
(WebCore::InbandTextTrackPrivateAVF::resetCueValues): Tell the client to remove all incomplete
cues we have delivered.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Do not flush cues when seek completes,
we did that when the seek started and cues can be delivered before we get the the
seek completed notification.
- 1:22 PM Changeset in webkit [148539] by
-
- 5 edits in trunk
dfn element should be exposed as AXGroup:AXDefinition
https://bugs.webkit.org/show_bug.cgi?id=108980
Patch by James Craig <james@cookiecrook.com> on 2013-04-16
Reviewed by Chris Fleizach.
Source/WebCore:
dfn element now exposed as AXGroup:AXDefinition. Updated existing tests.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
LayoutTests:
dfn element now exposed as AXGroup:AXDefinition
- platform/mac/accessibility/role-subrole-roledescription-expected.txt:
- platform/mac/accessibility/role-subrole-roledescription.html:
- 1:15 PM Changeset in webkit [148538] by
-
- 2 edits in trunk/Source/WebKit2
Make resizing the docked Web Inspector stay in sync with the inspected view.
Reviewed by Joseph Pecoraro.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
Disable screen updates to make sure the layers for both views resize in sync.
- 1:05 PM Changeset in webkit [148537] by
-
- 6 edits in trunk/Source/WebCore
Begin chipping away at ScriptState
https://bugs.webkit.org/show_bug.cgi?id=114695
Reviewed by Geoffrey Garen.
Remove ScriptStateProtectedPtr as well as evalEnabled and setEvalEnabled.
- bindings/js/ScriptState.cpp:
- bindings/js/ScriptState.h:
- inspector/InjectedScriptBase.cpp:
(WebCore::InjectedScriptBase::callFunctionWithEvalEnabled):
- inspector/ScriptArguments.cpp:
(WebCore::ScriptArguments::ScriptArguments):
(WebCore::ScriptArguments::globalState):
- inspector/ScriptArguments.h:
- 12:57 PM Changeset in webkit [148536] by
-
- 50 edits in trunk/Source
Remove unneeded headers from ScriptExecutionContext.h
https://bugs.webkit.org/show_bug.cgi?id=114631
Reviewed by Alexey Proskuryakov.
Source/WebCore:
This shaves another minute off WebCore build time on my MacBook Pro.
- dom/ScriptExecutionContext.cpp:
- dom/ScriptExecutionContext.h:
- fileapi/Blob.cpp:
- rendering/RenderBlock.cpp:
- rendering/RenderBox.cpp:
- rendering/RenderFlowThread.cpp:
- rendering/RenderFrameSet.cpp:
- rendering/RenderIFrame.cpp:
- rendering/RenderImage.cpp:
- rendering/RenderListBox.cpp:
- rendering/RenderListItem.cpp:
- rendering/RenderListMarker.cpp:
- rendering/RenderMedia.cpp:
- rendering/RenderObject.cpp:
- rendering/RenderRegion.cpp:
- rendering/RenderReplaced.cpp:
- rendering/RenderReplica.cpp:
- rendering/RenderRubyRun.cpp:
- rendering/RenderScrollbarPart.cpp:
- rendering/RenderSlider.cpp:
- rendering/RenderTable.cpp:
- rendering/RenderTableCell.cpp:
- rendering/RenderTableRow.cpp:
- rendering/RenderTableSection.cpp:
- rendering/RenderTextControlSingleLine.cpp:
- rendering/RenderTextTrackCue.cpp:
- rendering/RenderVideo.cpp:
- rendering/RenderView.cpp:
- rendering/RenderWidget.cpp:
- rendering/svg/RenderSVGContainer.cpp:
- rendering/svg/RenderSVGForeignObject.cpp:
- rendering/svg/RenderSVGGradientStop.cpp:
- rendering/svg/RenderSVGHiddenContainer.cpp:
- rendering/svg/RenderSVGImage.cpp:
- rendering/svg/RenderSVGResourceContainer.cpp:
- rendering/svg/RenderSVGResourceMarker.cpp:
- rendering/svg/RenderSVGRoot.cpp:
- rendering/svg/RenderSVGShape.cpp:
- rendering/svg/RenderSVGText.cpp:
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
- WebProcess/WebPage/PageOverlay.cpp:
- 12:47 PM Changeset in webkit [148535] by
-
- 2 edits in trunk/Tools
Unreviewed. Disable WinEWS tests, simply not enough bots.
All bots are running consistently now but the queue still keeps growing.
Until we get more bots or make the tests faster, it doesn't seem wise to keep running tests.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 12:19 PM Changeset in webkit [148534] by
-
- 7 edits in trunk/Source
Remove even yet still more traces of v8
https://bugs.webkit.org/show_bug.cgi?id=114693
Reviewed by Anders Carlsson.
../WebCore:
No behavior change.
- bindings/generic/ActiveDOMCallback.h:
(WebCore::ActiveDOMCallback::isScriptControllerTerminating): Remove a V8-specific
method and the comment referencing it.
- bindings/generic/ActiveDOMCallback.cpp:
(WebCore::ActiveDOMCallback::isScriptControllerTerminating): ditto
- fileapi/File.cpp:
(WebCore::File::File): Remove a comment referencing v8
- inspector/InjectedScriptExterns.js: ditto
../WebKit2:
- Scripts/generate-forwarding-headers.pl: Remove v8 from list of platforms.
- 12:12 PM Changeset in webkit [148533] by
-
- 3 edits2 copies in branches/safari-536.30-branch
Merged r130313. <rdar://problem/13656005>
- 11:59 AM Changeset in webkit [148532] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: http/tests/security/cookies/third-party-cookie-blocking-user-action.html
https://bugs.webkit.org/show_bug.cgi?id=114511
Clear the test cookie at the beginning of the test to avoid failing if
the cookie is still around from a previous test.
Reviewed by Alexey Proskuryakov.
- http/tests/security/cookies/third-party-cookie-blocking-user-action.html:
- 11:56 AM Changeset in webkit [148531] by
-
- 18 edits in trunk/Source
Remove unused AlternativeTextClient::dismissDictationAlternativeUI
https://bugs.webkit.org/show_bug.cgi?id=114598
Reviewed by Ryosuke Niwa.
Source/WebCore:
Removing dead code.
- WebCore.exp.in:
- editing/mac/AlternativeTextUIController.h: Made dismissAlternatives() private.
- page/AlternativeTextClient.h:
Source/WebKit/mac:
- WebCoreSupport/WebAlternativeTextClient.h:
- WebCoreSupport/WebAlternativeTextClient.mm:
- WebView/WebView.mm:
- WebView/WebViewInternal.h:
Source/WebKit2:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::dictationAlternatives):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebAlternativeTextClient.h:
- WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp:
- 11:55 AM Changeset in webkit [148530] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Windows] Unreviewed VS2010 build correction.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props:
Specify proper link library to avoid mixture of ICU 4.0 and 4.6
symbols during link.
- 11:54 AM Changeset in webkit [148529] by
-
- 4 edits in trunk/Source/WebKit
../WebKit: [Windows] Unreviewed VS2010 build correction.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorCommon.props:
Add correct link library to avoid mixture of ICU 4.0 and 4.6
syumbol use.
../WebKit/win: [Windows] Unreviewed build correction.
- WebKit.vcproj/WebKitExportGeneratorCommon.vsprops: Add correct
ICU link library to avoid mixture of ICU 4.0 and 4.6 symbols
during link.
- 11:50 AM Changeset in webkit [148528] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
Build fix after r148527.
- committers-autocomplete.js:
(WebKitCommitters):
- 11:41 AM Changeset in webkit [148527] by
-
- 10 edits1 add in trunk
The list of contributors in committers.py should be a separate JSON
https://bugs.webkit.org/show_bug.cgi?id=114673
Reviewed by Anders Carlsson.
Tools:
Added webkitpy/common/config/contributors.json, made CommitterList load it.
- EWSTools/start-queue-mac.sh:
- EWSTools/start-queue.sh:
- Scripts/webkitpy/common/checkout/commitinfo.py:
(CommitInfo.committer):
- Scripts/webkitpy/common/config/contributors.json: Added.
- Scripts/webkitpy/common/config/committers.py:
(Reviewer.init):
(CommitterList.init):
(CommitterList.load_json): Added.
(CommitterList.load_json.emails):
(CommitterList.load_json.nicks):
- Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
(MockCommitInfo.author):
Websites/bugs.webkit.org:
Updated the Bugzilla autocompletion code to use contributors.json.
Basically, this removes a large chunk of this JavaScript file.
- committers-autocomplete.js:
(WebKitCommitters):
Websites/webkit.org:
Updated the website to refer to contributors.json instead of committers.py.
- coding/commit-review-policy.html:
- 11:29 AM Changeset in webkit [148526] by
-
- 15 edits in trunk/Source/WebKit2
[GTK][WK2] Add API to retrieve a snapshot from a webview
https://bugs.webkit.org/show_bug.cgi?id=98270
Reviewed by Anders Carlsson.
This adds the GTK+ API necessary to retrieve a snapshot from a
webview asynchronously. The API uses the injected bundle
internally to get the snapshot from the WebProcess.
- UIProcess/API/gtk/WebKitError.cpp:
(webkit_snapshot_error_quark): Add snapshot API related error
quark.
- UIProcess/API/gtk/WebKitError.h: Add snapshot error handling.
- UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
(didReceiveWebViewMessageFromInjectedBundle): Handle the new
"DidGetSnapshot" message.
- UIProcess/API/gtk/WebKitPrivate.h: Add SnapshotRegion enum.
- UIProcess/API/gtk/WebKitWebView.cpp:
(_WebKitWebViewPrivate): Add a map for the snapshot results.
(GetSnapshotAsyncData):
(webKitWebViewDidReceiveSnapshot):
(webKitSnapshotRegionToSnapshotRegion): Helper method for casting
the region option enumeration.
(generateSnapshotCallbackID): Method to generate unique callback
ids.
(webkit_web_view_get_snapshot):
(webkit_web_view_get_snapshot_finish): New snapshotting API.
- UIProcess/API/gtk/WebKitWebView.h: Ditto.
- UIProcess/API/gtk/WebKitWebViewPrivate.h: Add the private method
to handle a received snapshot.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add the new API
bits.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(cairoSurfacesEqual): Add helper to compare cairo_surface_t
structs.
(testWebViewSnapshot): New test.
(beforeAll): Add the new test.
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::selectAll): Add method to help test snapshots
including selection.
- UIProcess/API/gtk/tests/WebViewTest.h: Ditto
- WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
(didReceiveMessageToPage): Ditto.
(webkitWebExtensionCreate): Register method above.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkitWebPageDidReceiveMessage): Add this method. It
handles the new message "GetSnapshot".
- WebProcess/InjectedBundle/API/gtk/WebKitWebPagePrivate.h:
Add method above.
- 11:25 AM Changeset in webkit [148525] by
-
- 2 edits in trunk/Source/WebKit/mac
REGRESSION(r146025): WebKit applications can't apply underline or strike through
https://bugs.webkit.org/show_bug.cgi?id=114662
Reviewed by Enrica Casucci.
Use -webkit- prefixes to apply underline. There should be no further compatibility issues
since -khtml- was used only internally to pass the information down to WebCore.
Unfortunately, we can't test this code like any other font panel bug.
In the long run, we need to add some abstraction layer around font panel to make this testable
or else we'll keep regressing this feature.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _styleFromFontAttributes:]):
(-[WebHTMLView _styleForAttributeChange:]):
- 11:08 AM Changeset in webkit [148524] by
-
- 2 edits in trunk/Source/WebKit2
Create full rects for the inspector and inspected views when
adjusting to an inspected view frame change.
This ensures switching dock sides restores the inspected view
and inspector to fill the parent's bounds.
https://webkit.org/b/114666
rdar://problem/13660796
Reviewed by Joseph Pecoraro.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
- 10:56 AM Changeset in webkit [148523] by
-
- 4 edits4 adds in trunk
Float at exact multiple of line-height affects too many lines
https://bugs.webkit.org/show_bug.cgi?id=112744
Reviewed by David Hyatt.
Source/WebCore:
Tests: fast/block/float/float-with-fractional-height-vertical-lr.html
fast/block/float/float-with-fractional-height.html
When adding floats to the interval tree used for testing floats' overlap with lineboxes
truncate the dimensions of the float rather than rounding them. This matches the
treatment of linebox dimensions so ensures the test for overlap is comparing like
with like.
- rendering/RenderBlock.cpp:
(WebCore::::collectIfNeeded):
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject):
(WebCore::::string):
LayoutTests:
- fast/block/float/float-with-fractional-height-expected.html: Added.
- fast/block/float/float-with-fractional-height-vertical-lr-expected.html: Added.
- fast/block/float/float-with-fractional-height-vertical-lr.html: Added.
- fast/block/float/float-with-fractional-height.html: Added.
- platform/mac/fast/backgrounds/background-position-parsing-expected.txt:
- 10:52 AM Changeset in webkit [148522] by
-
- 6 edits2 adds in trunk
AX: aria-valuetext is not exposed on OS X.
https://bugs.webkit.org/show_bug.cgi?id=114628
Reviewed by Tim Horton.
Source/WebCore:
aria-valuetext is only being exposed on ARIA controls. That's because there were
checks in place so that ONLY ARIA defined controls would return anything related to valuetext.
We should allow this to work on native controls as well.
Test: platform/mac/accessibility/aria-valuetext-on-native-slider.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::valueDescription):
(WebCore):
(WebCore::AccessibilityNodeObject::valueForRange):
(WebCore::AccessibilityNodeObject::maxValueForRange):
(WebCore::AccessibilityNodeObject::minValueForRange):
- accessibility/AccessibilityNodeObject.h:
(AccessibilityNodeObject):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isRangeControl):
Rename isARIAControl to isRangeControl and make it apply to all elements.
- accessibility/AccessibilityObject.h:
LayoutTests:
- platform/mac/accessibility/aria-valuetext-on-native-slider-expected.txt: Added.
- platform/mac/accessibility/aria-valuetext-on-native-slider.html: Added.
- 10:18 AM Changeset in webkit [148521] by
-
- 2 edits in trunk/Source/WebCore
RenderView should bail out of paintBoxDecorations() when painting with a different renderer
https://bugs.webkit.org/show_bug.cgi?id=114665
<rdar://problem/13434884>
Reviewed by Simon Fraser.
- rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations): Add a check to see if we should paint within the renderer.
This check exists in all other implementations of paintBoxDecorations(), and correctly avoids painting the
decorations if the root provided is not the RenderView.
- 10:18 AM Changeset in webkit [148520] by
-
- 1 copy in releases/WebKitGTK/webkit-2.0.1
Tagging the WebKitGTK+ 2.0.1 release
- 10:16 AM Changeset in webkit [148519] by
-
- 6 edits in trunk/Source/WebKit2
Initialize logging channels for web processes
https://bugs.webkit.org/show_bug.cgi?id=114621
Reviewed by Sam Weinig.
Use InitializeWebKit2 for initializing the web and plugin processes.
It handles initializing the logging channels and it's better to have
shared core for this. For the plugin process now we always create
a RunLoop object which is not necessary with the -scanPlugin argument
but it shouldn't be a problem.
- PluginProcess/qt/PluginProcessMainQt.cpp:
(WebKit::PluginProcessMain):
- PluginProcess/unix/PluginProcessMainUnix.cpp:
(WebKit::PluginProcessMainUnix):
- WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):
- WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
- 10:12 AM Changeset in webkit [148518] by
-
- 11 edits in trunk/Source/WebCore
[CSS Shaders] Remove the cache of validated programs
https://bugs.webkit.org/show_bug.cgi?id=112844
Reviewed by Dean Jackson.
Since we're caching CustomFilterProgram(s) now, we don't need another cache for
CustomFilterValidatedProgram(s). With this patch, CustomFilterProgram stores a reference
to a lazily created CustomFilterValidatedProgram, and CustomFilterGlobalContext no longer
has a validated program cache.
Also, this patch removes the CustomFilterValidatedProgram's stored reference to
CustomFilterGlobalContext. The removal of the validated program cache would cause
this reference to become weak. Validated programs only needed to keep the global context
reference in order to create a CustomFilterCompiledProgram. In this patch, we create
CustomFilterCompiledProgram(s) in FECustomFilter instead of in CustomFilterValidatedProgram,
so validated programs don't need to store the global context reference anymore.
No new tests. Just Refactoring.
- platform/graphics/filters/CustomFilterCompiledProgram.cpp:
(WebCore::CustomFilterCompiledProgram::CustomFilterCompiledProgram):
- platform/graphics/filters/CustomFilterGlobalContext.cpp:
(WebCore::CustomFilterGlobalContext::~CustomFilterGlobalContext):
- platform/graphics/filters/CustomFilterGlobalContext.h:
(CustomFilterGlobalContext):
- platform/graphics/filters/CustomFilterProgram.cpp:
(WebCore::CustomFilterProgram::validatedProgram):
(WebCore::CustomFilterProgram::setValidatedProgram):
- platform/graphics/filters/CustomFilterProgram.h:
- platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram):
(WebCore::CustomFilterValidatedProgram::compiledProgram):
(WebCore::CustomFilterValidatedProgram::setCompiledProgram):
(WebCore::CustomFilterValidatedProgram::~CustomFilterValidatedProgram):
- platform/graphics/filters/CustomFilterValidatedProgram.h:
(CustomFilterValidatedProgram):
- platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::prepareForDrawing):
- rendering/FilterEffectRenderer.cpp:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeFilterOperations):
- 9:45 AM Changeset in webkit [148517] by
-
- 6 edits in branches/safari-536.30-branch/LayoutTests
Update from testrunner to layoutTestController.
- 9:16 AM Changeset in webkit [148516] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] LayerTexture: check if the graphics context is NULL
https://bugs.webkit.org/show_bug.cgi?id=114674
Patch by Anthony Scian <ascian@blackberry.com> on 2013-04-16
Reviewed by Rob Buis.
Internal PR: 256522
- platform/graphics/blackberry/LayerTexture.cpp:
(WebCore::LayerTexture::setContentsToColor):
- 9:07 AM Changeset in webkit [148515] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebCore
Merged r147938. <rdar://problem/13600559>
- 8:34 AM Changeset in webkit [148514] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] Add an API for getting context menu item's parent menu
https://bugs.webkit.org/show_bug.cgi?id=107510
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-04-16
Reviewed by Kenneth Rohde Christiansen.
Added parent menu support and API for Ewk_Context_Menu_Item, to
allow selecting context menus using Elementary widgets.
Context menu unit test updated with new function.
- UIProcess/API/efl/ewk_context_menu.cpp:
(EwkContextMenu::EwkContextMenu):
- UIProcess/API/efl/ewk_context_menu_item.cpp:
(EwkContextMenuItem::EwkContextMenuItem):
(ewk_context_menu_item_parent_menu_get):
- UIProcess/API/efl/ewk_context_menu_item.h:
- UIProcess/API/efl/ewk_context_menu_item_private.h:
(EwkContextMenuItem::create):
(EwkContextMenuItem::parentMenu):
(EwkContextMenuItem::setParentMenu):
(EwkContextMenuItem):
- UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:
(showContextMenu):
- 8:33 AM Changeset in webkit [148513] by
-
- 3 edits in branches/safari-536.30-branch
Merged r148483. <rdar://problem/13659541>
- 8:07 AM Changeset in webkit [148512] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Accelerated animation regression with GL renderer
https://bugs.webkit.org/show_bug.cgi?id=114685
Reviewed by Rob Buis.
Internally reviewed by Filip Spacek.
GL renderer changed the assumption made in accelerated animation
code that rendering the contents of AC layer tiles would be the
slow operation. By starting animations after the slow operation,
the appearance of the animation could be made smooth.
Rendering tiles may still be slow, but now something else can be
slow too: drawing display lists to backing. And it's running on
the compositing thread, can happen at any time and will interrupt
accelerated animations.
Improved the situation by calling an API for updating backing to
schedule the delay at a convenient time. We try to update backing
before starting animations. However, future backing updates can
still interrupt the running animation and cause dropped frames.
Further improvements to animation smoothness will probably require
optimizations in the GL renderer.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebKitSupport/FrameLayers.cpp:
(BlackBerry::WebKit::FrameLayers::notifyAnimationsStarted):
(WebKit):
- WebKitSupport/FrameLayers.h:
(FrameLayers):
- 5:59 AM Changeset in webkit [148511] by
-
- 2 edits in trunk/Source/WebKit/efl
REGRESSION (r148506): Use of deprecated libsoup API
https://bugs.webkit.org/show_bug.cgi?id=114679
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-16
Reviewed by Gyuyoung Kim.
Remove deprecated libsoup API usage.
- ewk/ewk_network.cpp:
(ewk_network_proxy_uri_set):
(ewk_network_proxy_uri_get):
- 5:14 AM Changeset in webkit [148510] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0
Unreviewed. Update NEWS and Versions.m4 for 2.0.1 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.0.1.
- 4:46 AM Changeset in webkit [148509] by
-
- 2 edits in trunk/Source/WebKit2
Fix release builds with !LOG_DISABLED.
- Platform/mac/Logging.mac.mm:
- 3:05 AM Changeset in webkit [148508] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r148128): window.resizeTo doesn't work from Safari address bar.
<rdar://problem/13635894>
<http://webkit.org/b/114561>
Reviewed by Sam Weinig.
Suppressing window geometry changes while any user gesture is active was a bit too restrictive,
and broke legitimate use-cases. Narrow it down to checking EventHandler::mousePressed().
No test yet, adding one is tracked by <http://webkit.org/b/114561>.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::allowedToChangeWindowGeometry):
Added to share code between all DOMWindow functions that alter window geometry.
(WebCore::DOMWindow::moveBy):
(WebCore::DOMWindow::moveTo):
(WebCore::DOMWindow::resizeBy):
(WebCore::DOMWindow::resizeTo):
- 2:40 AM Changeset in webkit [148507] by
-
- 17 edits in trunk/Source
[GTK][EFL] Remove deprecated libsoup API usage
https://bugs.webkit.org/show_bug.cgi?id=104894
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-16
Reviewed by Philippe Normand.
Source/WebCore:
Based on a patch by Claudio Saavedra <Claudio Saavedra>.
Remove LIBSOUP_USE_UNSTABLE_REQUEST_API and only include
libsoup/soup.h.
- platform/network/ResourceHandleInternal.h:
- platform/network/soup/GOwnPtrSoup.cpp:
- platform/network/soup/ProxyResolverSoup.h:
- platform/network/soup/ResourceErrorSoup.cpp:
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ensureSessionIsInitialized): No need to add the requester
feature.
(WebCore::createSoupRequestAndMessageForHandle): SoupSession has a
requester API, use it.
Source/WebKit/efl:
Remove LIBSOUP_USE_UNSTABLE_REQUEST_API and only include
libsoup/soup.h.
Source/WebKit2:
Remove LIBSOUP_USE_UNSTABLE_REQUEST_API and only include
libsoup/soup.h.
- WebProcess/Cookies/soup/WebKitSoupCookieJarSqlite.h:
- WebProcess/efl/WebProcessMainEfl.cpp:
- WebProcess/gtk/WebProcessMainGtk.cpp:
- WebProcess/soup/WebKitSoupRequestGeneric.h:
- WebProcess/soup/WebProcessSoup.cpp:
- WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestManager::registerURIScheme): Remove requester and
use method soup_session_add_feature_by_type().
- 2:35 AM Changeset in webkit [148506] by
-
- 4 edits1 delete in trunk
[EFL] Bump libsoup dependency to 2.42.0
https://bugs.webkit.org/show_bug.cgi?id=113927
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-16
Reviewed by Gyuyoung Kim.
Update libsoup required version to v2.42.0 and GLib to v2.36.0 as
required by libsoup for EFL port.
.:
- Source/cmake/OptionsEfl.cmake:
Tools:
- efl/jhbuild.modules:
- efl/patches/libsoup-2.40-auth-fix.patch: Removed as it's already
included in v2.42.0.
- 2:29 AM Changeset in webkit [148505] by
-
- 10 edits in trunk/Source/WebCore
Remove more traces of the now-obsolete support for V8
https://bugs.webkit.org/show_bug.cgi?id=114657
Reviewed by Ryosuke Niwa.
In addition to passing existing tests, I verified that the ElementFactory
and ElementWrapperFactory files were all textually identical before and after.
- dom/CustomEvent.cpp:
(WebCore): Remove Use(V8) bock.
- dom/CustomEvent.h:
(CustomEvent): ditto
- dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent): ditto
(WebCore::MessageEvent::initMessageEvent): ditto
- dom/Node.h:
(Node): ditto
- dom/make_event_factory.pl:
(generateImplementation): Remove V8 support.
- dom/make_names.pl: Remove gobs of V8 support and simplify.
(printJSElementIncludes):
(printConditionalElementIncludes):
(printFactoryCppFile):
(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):
- inspector/InjectedScriptCanvasModuleSource.js: Remove V8 stack
trace code.
- platform/qt/PlatformSupport.h: Remove a macro only used for V8
bindings.
- svg/SVGZoomAndPan.h:
(SVGZoomAndPan): Remove mention of V8 from comment.
- 2:26 AM Changeset in webkit [148504] by
-
- 7 edits in trunk/Tools
Remove Account class from committers.py
https://bugs.webkit.org/show_bug.cgi?id=114671
Reviewed by Csaba Osztrogonác.
Account class was added to support watch list email addresses that are not associated with
a particular contributor but nobody uses these email address since Chromium port forked.
Remove it.
Also removed account_by_login from CommitterList since it was never called except its unittests.
- Scripts/webkitpy/common/checkout/changelog.py:
- Scripts/webkitpy/common/config/committers.py:
(Contributor):
(Contributor.matches_glob):
(Reviewer.init):
(CommitterList.init):
(CommitterList._email_to_account_map):
(CommitterList._login_to_account_map):
(CommitterList.contributors_by_fuzzy_match):
(CommitterList.contributor_by_email):
(CommitterList.contributor_by_name):
(CommitterList.committer_by_email):
(CommitterList.reviewer_by_email):
- Scripts/webkitpy/common/config/committers_unittest.py:
(CommittersTest.test_committer_lookup):
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla._commit_queue_flag):
- Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
(test_commit_queue_flag):
- Scripts/webkitpy/common/watchlist/watchlistparser.py:
(WatchListParser._validate):
- 1:51 AM Changeset in webkit [148503] by
-
- 3 edits in trunk/Tools
Unreviewed update to the watchlist.
Removing 'mkwst+watchlist@chromium.org' from committers.py and the
watchist file; moving to 'mkwst@chromium.org' instead.
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/watchlist:
- 1:36 AM Changeset in webkit [148502] by
-
- 55 edits1 move in trunk/Tools
Move webkitpy.layout_tests.port to webkitpy.port
https://bugs.webkit.org/show_bug.cgi?id=114668
Reviewed by Maciej Stachowiak.
Moved. Port objects knows a lot more than just layout_tests. They doesn't belong down in layout_tests.
- Scripts/webkitpy/common/host.py:
- Scripts/webkitpy/common/host_mock.py:
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
- Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
- Scripts/webkitpy/layout_tests/lint_test_expectations.py:
- Scripts/webkitpy/layout_tests/port: Removed.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
- Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
- Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
- Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
- Scripts/webkitpy/performance_tests/perftest.py:
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
- Scripts/webkitpy/port: Copied from Tools/Scripts/webkitpy/layout_tests/port.
- Scripts/webkitpy/port/apple.py:
- Scripts/webkitpy/port/base.py:
- Scripts/webkitpy/port/base_unittest.py:
- Scripts/webkitpy/port/config_unittest.py:
(ConfigTest.test_default_configurationstandalone):
- Scripts/webkitpy/port/driver_unittest.py:
- Scripts/webkitpy/port/efl.py:
- Scripts/webkitpy/port/efl_unittest.py:
- Scripts/webkitpy/port/factory.py:
- Scripts/webkitpy/port/factory_unittest.py:
- Scripts/webkitpy/port/gtk.py:
- Scripts/webkitpy/port/gtk_unittest.py:
- Scripts/webkitpy/port/image_diff.py:
- Scripts/webkitpy/port/image_diff_unittest.py:
- Scripts/webkitpy/port/leakdetector_unittest.py:
- Scripts/webkitpy/port/mac.py:
- Scripts/webkitpy/port/mac_unittest.py:
- Scripts/webkitpy/port/mock_drt.py:
- Scripts/webkitpy/port/mock_drt_unittest.py:
- Scripts/webkitpy/port/port_testcase.py:
- Scripts/webkitpy/port/qt.py:
- Scripts/webkitpy/port/qt_unittest.py:
- Scripts/webkitpy/port/server_process_unittest.py:
- Scripts/webkitpy/port/test.py:
- Scripts/webkitpy/port/win.py:
- Scripts/webkitpy/port/win_unittest.py:
- Scripts/webkitpy/port/xvfbdriver.py:
- Scripts/webkitpy/port/xvfbdriver_unittest.py:
- Scripts/webkitpy/tool/bot/botinfo_unittest.py:
- Scripts/webkitpy/tool/commands/gardenomatic.py:
- Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/commands/queries_unittest.py:
- Scripts/webkitpy/tool/commands/rebaseline.py:
- Scripts/webkitpy/tool/servers/gardeningserver.py:
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
- Scripts/webkitpy/tool/servers/rebaselineserver.py:
- Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
- 1:25 AM Changeset in webkit [148501] by
-
- 4 edits1 delete in trunk/Tools
Unreviewed, rolling out r148498.
http://trac.webkit.org/changeset/148498
https://bugs.webkit.org/show_bug.cgi?id=114669
Appears to have broken EWS (Requested by rniwa on #webkit).
- Scripts/webkitpy/common/config/ews.json: Removed.
- Scripts/webkitpy/tool/commands/init.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.init):
(AbstractEarlyWarningSystem.handle_script_error.does):
(GtkEWS):
(GtkWK2EWS):
(EflEWS):
(QtEWS):
(QtWK2EWS):
(WinEWS):
(MacEWS):
(MacWK2EWS):
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest._default_expected_logs):
(_test_ews):
(test_ewses):
- 1:15 AM Changeset in webkit [148500] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: [Network] Cover the type of preflight xhr.
https://bugs.webkit.org/show_bug.cgi?id=113471.
Patch by Pan Deng <pan.deng@intel.com> on 2013-04-16
Reviewed by Vsevolod Vlasov.
Add the Network resource type test to make sure the xhr-preflight is "xhr".
- http/tests/inspector/network-preflight-options-expected.txt:
- http/tests/inspector/network-preflight-options.html:
- 12:55 AM Changeset in webkit [148499] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- 12:43 AM Changeset in webkit [148498] by
-
- 4 edits1 add in trunk/Tools
Isolate Early Warning System definitions into a JSON
https://bugs.webkit.org/show_bug.cgi?id=114558
Reviewed by Benjamin Poulain.
Added ews.json to common/config, and made tool/commands/init.py call
AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
- Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
- Scripts/webkitpy/tool/commands/init.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.init):
(AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest._default_expected_logs):
(_test_ews):
(test_ewses):
- 12:36 AM Changeset in webkit [148497] by
-
- 2 edits in trunk/Source/WebCore
Potential use after free in ApplyStyleCommand::splitAncestorsWithUnicodeBidi
https://bugs.webkit.org/show_bug.cgi?id=114664
Reviewed by Oliver Hunt.
Use RefPtr as needed.
No new tests since this bug was discovered by code inspection.
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
- 12:04 AM Changeset in webkit [148496] by
-
- 3 edits2 adds in branches/safari-536.30-branch
Merged r142631.
Source/WebCore:
2013-02-12 Dominic Mazzoni <dmazzoni@google.com>
ASSERTION FAILED: i < size(), UNKNOWN in WebCore::AccessibilityMenuListPopup::didUpdateActiveOption
https://bugs.webkit.org/show_bug.cgi?id=109452
Reviewed by Chris Fleizach.
Send the accessibility childrenChanged notification in
HTMLSelectElement::setRecalcListItems instead of in childrenChanged
so that all possible codepaths are caught.
Test: accessibility/insert-selected-option-into-select-causes-crash.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childrenChanged):
(WebCore::HTMLSelectElement::setRecalcListItems):
LayoutTests:
Updated the test to account for the lack of accessibleElementById.
2013-02-12 Dominic Mazzoni <dmazzoni@google.com>
ASSERTION FAILED: i < size(), UNKNOWN in WebCore::AccessibilityMenuListPopup::didUpdateActiveOption
https://bugs.webkit.org/show_bug.cgi?id=109452
Reviewed by Chris Fleizach.
Add test to ensure a crash doesn't happen if a selected option
is added to a select element, which was triggering a code path where
the DOM has added a new child of the select but the accessibility
object never got updated.
- accessibility/insert-selected-option-into-select-causes-crash-expected.txt: Added.
- accessibility/insert-selected-option-into-select-causes-crash.html: Added.
Apr 15, 2013:
- 11:12 PM Changeset in webkit [148495] by
-
- 7 edits in trunk
Web Inspector: Make var and function declarations work again in the Console.
https://webkit.org/b/114534
rdar://problem/13614477
Reviewed by Oliver Hunt.
Source/WebCore:
- inspector/InjectedScriptSource.js:
(InjectedScript.prototype._evaluateOn): Use 'with' when not evaluating
on a call frame.
LayoutTests:
- inspector/console/command-line-api-expected.txt:
- inspector/console/console-eval-syntax-error-expected.txt:
- inspector/extensions/extensions-eval-expected.txt:
- platform/mac/http/tests/inspector/console-resource-errors-expected.txt:
Updated test results.
- 10:56 PM Changeset in webkit [148494] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Add missing Localized strings
https://bugs.webkit.org/show_bug.cgi?id=114656
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-15
Reviewed by Timothy Hatcher.
No tests because no behavior change is expected.
- English.lproj/localizedStrings.js:
- 10:31 PM Changeset in webkit [148493] by
-
- 3 edits2 adds in branches/safari-536.30-branch
Merged r139444.
Source/WebCore:
2013-01-11 Stephen Chenney <schenney@chromium.org>
Objects can be re-added to the AXObjectCache during removal
https://bugs.webkit.org/show_bug.cgi?id=104171
The problem occurs when a label's corresponding element is a sibling
that precedes it in the render tree, and the corresponding element is
removed. The corresponding element's AX render object is removed, but
then recreated when accessibilityIsIgnored() invokes correspondingControl()
on the label. The corresponding renderer then has an AX render object
that survives beyond the deleted renderer, leading to invalid memory
accesses.
The solution is to rearrange the calls to delete the renderer's AX
render object only when we are sure it will no longer be required.
Reviewed by Simon Fraser.
Test: accessibility/corresponding-control-deleted-crash.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed): Move the call to remove the
renderer from the AXCache to after the renderer is removed from the
render tree. This means that the AXObject still exists during renderer
removal, as we require.
LayoutTests:
Checked in a failing expected result for corresponding-control-deleted-crash.html,
since the test requires author shadow DOM to be enabled.
2013-01-11 Stephen Chenney <schenney@chromium.org>
Objects can be re-added to the AXObjectCache during removal
https://bugs.webkit.org/show_bug.cgi?id=104171
Reviewed by Simon Fraser.
New test which asserts with !m_hasAXObject in RenderObject::~RenderObject without the patch. Requires Shadow DOM enabled.
- accessibility/corresponding-control-deleted-crash-expected.txt: Added.
- accessibility/corresponding-control-deleted-crash.html: Added.
- 10:09 PM Changeset in webkit [148492] by
-
- 4 edits2 adds in branches/safari-536.30-branch
Merged r131670.
2012-10-17 Tom Sepez <tsepez@chromium.org>
Crash in ContainerNode::removeAllChildren()
https://bugs.webkit.org/show_bug.cgi?id=98443
Reviewed by Eric Carlson.
Source/WebCore:
This patch makes the errorEventSender added in WebKit Revision 112190 interact
with the updatedHasPendingLoadEvent() mechanism in the same manner as the other
existing event senders.
Test: http/tests/security/video-poster-cross-origin-crash2.html
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::updatedHasPendingEvent):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingLoadEvent):
- loader/ImageLoader.h:
(ImageLoader):
LayoutTests:
- http/tests/security/video-poster-cross-origin-crash2-expected.txt: Added.
- http/tests/security/video-poster-cross-origin-crash2.html: Added.
- 9:37 PM Changeset in webkit [148491] by
-
- 5 edits in branches/safari-536.30-branch
Merged r142063.
2013-02-06 Tom Sepez <tsepez@chromium.org>
document.referrer leakage with XSS Auditor page block
https://bugs.webkit.org/show_bug.cgi?id=109089
Reviewed by Adam Barth.
Source/WebCore:
Pass "about:blank" as referrer instead of "" so that the actual page
is not leaked when empty referrers are replaced later on in the
request.
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
LayoutTests:
Test prints the referrer to show it isn't leaked.
- http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag.html:
- 8:41 PM Changeset in webkit [148490] by
-
- 3 edits in trunk/Source/WTF
Unreviewed, rolling out r148488.
http://trac.webkit.org/changeset/148488
https://bugs.webkit.org/show_bug.cgi?id=114660
Roll back in r148462 since it was a false positive. (Requested
by rniwa on #webkit).
- wtf/FastMalloc.cpp:
(WTF):
(WTF::setThreadHeap):
(WTF::TCMalloc_ThreadCache::GetThreadHeap):
(WTF::TCMalloc_ThreadCache::InitTSD):
- wtf/ThreadSpecificWin.cpp:
(WTF::destructorsList):
(WTF::destructorsMutex):
(WTF::threadSpecificKeyCreate):
(WTF::threadSpecificKeyDelete):
- 8:37 PM Changeset in webkit [148489] by
-
- 3 edits in trunk/Source/JavaScriptCore
Windows clean build fix after r148479.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 7:55 PM Changeset in webkit [148488] by
-
- 3 edits in trunk/Source/WTF
Unreviewed, rolling out r148462.
http://trac.webkit.org/changeset/148462
https://bugs.webkit.org/show_bug.cgi?id=114658
Broke Windows builds (Requested by rniwa on #webkit).
- wtf/FastMalloc.cpp:
(WTF):
(WTF::setThreadHeap):
(WTF::TCMalloc_ThreadCache::GetThreadHeap):
(WTF::TCMalloc_ThreadCache::InitTSD):
- wtf/ThreadSpecificWin.cpp:
(WTF::destructorsList):
(WTF::destructorsMutex):
(WTF::threadSpecificKeyCreate):
(WTF::threadSpecificKeyDelete):
- 7:52 PM Changeset in webkit [148487] by
-
- 6 edits in trunk/Source/WebCore
Rename restartedPlugin to isRestartedPlugin. This was
review feedback from r148038 that I thought I fixed
everywhere but failed.
https://bugs.webkit.org/show_bug.cgi?id=114233
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInElement::isRestartedPlugin): Prefix with "is".
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::setDisplayState):
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired):
- html/HTMLPlugInImageElement.h:
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintContents):
- rendering/RenderLayerBacking.cpp:
(WebCore::isRestartedPlugin):
- 7:15 PM Changeset in webkit [148486] by
-
- 3 edits in trunk/Source/WebCore
Remove V8 attribtues from IDLAttributes.txt
https://bugs.webkit.org/show_bug.cgi?id=114651
Reviewed by Sam Weinig.
No tests because no behavior change is expected.
- bindings/scripts/IDLAttributes.txt: Remove V8 attribtues.
- html/track/TextTrackList.idl: Remove a stray V8-specific attribute
(so I guess this change is not useless)
- 6:38 PM Changeset in webkit [148485] by
-
- 27 edits2 adds in branches/safari-536.30-branch
Merged r139111.
2013-01-08 Tom Sepez <tsepez@chromium.org>
Copy-paste preserves <embed> tags containing active content.
https://bugs.webkit.org/show_bug.cgi?id=77625
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: editing/pasteboard/paste-noplugin.html
- dom/FragmentScriptingPermission.h:
(WebCore::scriptingContentIsAllowed):
(WebCore::pluginContentIsAllowed):
Add new permission to restrict plugin pasting. Add inline functions to check
the implications of each permission rather than having a list of raw comparisions
sprinkled throughout the code.
- editing/markup.cpp:
(WebCore::createFragmentFromMarkup):
Revert back to unsafe plugin pasting regardless of caller's intentions when
the settings allow it.
- dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertScriptElement):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::endElementNs):
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseEndElement):
Use new inline functions to check implications of permissions rather than raw
comparisions.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
Check if plugin pasting is allowed before inserting applet/embed/oject elements.
- page/Settings.in:
Declaration of new unsafePluginPastingEnabled setting.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::documentFragment):
- platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asFragment):
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/qt/DragDataQt.cpp:
(WebCore::DragData::asFragment):
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::fragmentFromCFHTML):
(WebCore::fragmentFromHTML):
- platform/wx/PasteboardWx.cpp:
(WebCore::Pasteboard::documentFragment):
Pass DisallowScriptingAndPluginContent enum value.
Source/WebKit/chromium:
Adds chromium API to new unsafePluginPastingEnabled setting.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setUnsafePluginPastingEnabled):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
LayoutTests:
- editing/pasteboard/paste-noplugin-expected.txt: Added.
- editing/pasteboard/paste-noplugin.html: Added.
- 6:34 PM Changeset in webkit [148484] by
-
- 6 edits in trunk
WebKit should not expose AXSubrole:AXDescriptionList on Mountain Lion as it causes a regression in VoiceOver behavior
https://bugs.webkit.org/show_bug.cgi?id=113975
Patch by James Craig <james@cookiecrook.com> on 2013-04-15
Reviewed by Chris Fleizach.
Serve NSAccessibilityDescriptionListSubrole or NSAccessibilityDefinitionListSubrole
depending on platform. Updated existing test coverage.
Source/WebCore:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper subrole]):
LayoutTests:
- platform/mac/accessibility/lists-expected.txt:
- platform/mac/accessibility/role-subrole-roledescription-expected.txt:
- platform/mac/accessibility/role-subrole-roledescription.html:
- 6:20 PM Changeset in webkit [148483] by
-
- 3 edits3 moves in trunk
Source/WebKit/mac: plugins/get-url-beforeunload-destroys-plugin.html crashes in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=114653
<rdar://problem/13659541>
Reviewed by Sam Weinig.
Protect the NetscapePluginInstanceProxy since it can otherwise go away.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::performRequest):
LayoutTests: plugins/get-url-beforeunload-destroys-plugin.html crashes in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=114653
Reviewed by Sam Weinig.
Move this test back now that it passes in WK1.
- http/tests/plugins/get-url-beforeunload-destroys-plugin-expected.txt: Renamed from LayoutTests/platform/mac-wk2/http/tests/plugins/get-url-beforeunload-destroys-plugin-expected.txt.
- http/tests/plugins/get-url-beforeunload-destroys-plugin.html: Renamed from LayoutTests/platform/mac-wk2/http/tests/plugins/get-url-beforeunload-destroys-plugin.html.
- http/tests/plugins/resources/notify-done.html: Renamed from LayoutTests/platform/mac-wk2/http/tests/plugins/resources/notify-done.html.
- 6:05 PM Changeset in webkit [148482] by
-
- 9 edits in trunk/Source
Plugins that resize might need to be snapshotted.
https://bugs.webkit.org/show_bug.cgi?id=102157
<rdar://problem/12696259>
Reviewed by Tim Horton.
Source/WebCore:
A plugin could avoid snapshotting if it started very
small (below the threshold where we autostart), and then
resized to be large (above the threshold). Detect this
case and tell the plugin to snapshot.
There unfortunately is a bit of state to track when doing
this. We have to start the snapshotting in a post-layout
task, so we carry a flag to say we're checking size but
not wanting the plugin to update (which would restart it).
We also might be a plugin that would have already restarted
due to a similar plugin being clicked or detected as dominant.
So this patch introduces a member variable that tracks what
decision has been made on snapshotting.
I also added some more logging to be more clear about what is
happening to plugins going through the snapshot process, and
changed the order of the tests in the algorithm so that domain
detection comes before examining the size.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Initialise
the two new member variables.
(WebCore::HTMLPlugInImageElement::setDisplayState): Mark a restarted
plugin as NeverSnapshot. This means that if it later resizes above the
threshold, it won't trigger the snapshot detection.
(WebCore::HTMLPlugInImageElement::checkSnapshotStatus): Renamed from
updateSnapshotInfo. This now updates the snapshot, but also runs
the check for size changes.
(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin): Gather all plugins
that look like a restarting plugin, not just those snapshotted. That
way they can all be marked as NeverSnapshot.
(WebCore::HTMLPlugInImageElement::restartSimilarPlugIns): Bless every
plugin that looks similar, whether or not it is snapshotted.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): More logging.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Ditto.
(WebCore::HTMLPlugInImageElement::checkSizeChangeForSnapshotting): New
method. If the plugin was below the threshold and is now above it,
begin the snapshotting process.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Plugins
that were marked as NeverSnapshot should start immediately. Move the origin
test earlier in the method. If a plugin avoided snapshotting due to size,
remember the size.
(WebCore::HTMLPlugInImageElement::subframeLoaderDidCreatePlugIn): Mark the
plugin as NeverSnapshot.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): Four new member variables:
- the decision we made regarding snapshotting (or not), uses the SnapshotDecision enum
- the size when it avoided snapshotting
- a flag to indicate the post layout update was triggered due to a size change
(WebCore::HTMLPlugInImageElement::needsCheckForSizeChange): New method.
(WebCore::HTMLPlugInImageElement::setNeedsCheckForSizeChange): New method.
(WebCore::HTMLPlugInImageElement::snapshotDecision): Return the decision
regarding snapshotting or not snapshotting.
- page/FrameView.cpp:
(WebCore::FrameView::addWidgetToUpdate): Guard updating the widget. We don't
want to do it when we're checking for a size change in the plugin.
(WebCore::FrameView::updateWidget): Call new name.
- plugins/PluginViewBase.h:
(WebCore::PluginViewBase::beginSnapshottingRunningPlugin): Empty virtual
method to snapshot a running plugin.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::layout): If the plugin has increased in
size add it to the post layout list so that it will be checked.
Source/WebKit2:
Allow a running plugin to be snapshotted. All this
means is that we start the snapshot timer again.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::beginSnapshottingRunningPlugin): Restart
the timer.
- WebProcess/Plugins/PluginView.h: Virtual method declaration.
- 6:01 PM Changeset in webkit [148481] by
-
- 3 edits2 adds in trunk
activating a focused link to an in-page fragment ID should transfer focus to the target of the link when possible
https://bugs.webkit.org/show_bug.cgi?id=17450
Reviewed by Maciej Stachowiak.
Source/WebCore:
When a fragment is scrolled to due to an activation event or on load, focus should attempt to
move to the fragment if possible.
Test: fast/dom/fragment-activation-focuses-target.html
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
LayoutTests:
- fast/dom/fragment-activation-focuses-target.html: Added.
- 5:30 PM Changeset in webkit [148480] by
-
- 21 edits in trunk/Source/WebCore
Remove V8-specific extended attributes from IDL files
https://bugs.webkit.org/show_bug.cgi?id=114523
Reviewed by Geoffrey Garen.
No tests because no behavior change is expected.
- Modules/encryptedmedia/MediaKeyMessageEvent.idl:
- Modules/encryptedmedia/MediaKeyNeededEvent.idl:
- Modules/encryptedmedia/MediaKeySession.idl:
- Modules/encryptedmedia/MediaKeys.idl:
- Modules/filesystem/HTMLInputElementFileSystem.idl:
- Modules/indexeddb/IDBAny.idl:
- Modules/mediasource/MediaSource.idl:
- Modules/mediasource/SourceBuffer.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/mediastream/MediaStream.idl:
- Modules/webaudio/AudioDestinationNode.idl:
- html/track/TextTrackCue.idl:
- html/track/TextTrackCueList.idl:
- html/track/TextTrackList.idl:
- html/track/TextTrackRegion.idl:
- html/track/TextTrackRegionList.idl:
- html/track/TrackEvent.idl:
- storage/Storage.idl:
- svg/SVGDocument.idl:
- svg/SVGElement.idl:
- workers/WorkerContext.idl:
- xml/XMLHttpRequest.idl:
- xml/XPathNSResolver.idl:
- 5:22 PM Changeset in webkit [148479] by
-
- 25 edits1 copy in trunk/Source
ScriptWrappable subclasses shouldn't have to include WeakInlines.h
https://bugs.webkit.org/show_bug.cgi?id=114641
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
Move back the Weak constructor, destructor and clear() to Weak.h. Add a new weakClearSlowCase function
and put it in Weak.cpp.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- heap/Weak.cpp: Added.
- heap/Weak.h:
- heap/WeakInlines.h:
- heap/WeakSetInlines.h:
Source/WebCore:
Remove ScriptWrappableInlines.h includes, they're not needed anymore.
- css/WebKitCSSMatrix.cpp:
- dom/ClientRect.cpp:
- dom/ClientRectList.cpp:
- dom/Clipboard.cpp:
- dom/DOMStringMap.cpp:
- dom/Event.cpp:
- dom/MutationRecord.cpp:
- fileapi/FileList.cpp:
- page/BarInfo.cpp:
- plugins/DOMMimeTypeArray.cpp:
- plugins/DOMPlugin.cpp:
- plugins/DOMPluginArray.cpp:
- storage/Storage.cpp:
- 5:10 PM Changeset in webkit [148478] by
-
- 2 edits in branches/safari-536.30-branch/Source/JavaScriptCore
Build fix for Windows.
<rdar://problem/13438603>
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- 4:46 PM Changeset in webkit [148477] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] build fix after r148434
https://bugs.webkit.org/show_bug.cgi?id=114647
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-15
Reviewed by Benjamin Poulain.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::showContextMenu):
- 4:26 PM Changeset in webkit [148476] by
-
- 3 edits in branches/safari-536.30-branch/Source/WebCore
Build fix for r148472.
- 4:17 PM Changeset in webkit [148475] by
-
- 15 edits in trunk/Source/JavaScriptCore
HeapTimer lifetime should be less complicated
https://bugs.webkit.org/show_bug.cgi?id=114529
Reviewed by Oliver Hunt.
Right now our HeapTimer lifetime is rather complicated. HeapTimers are "owned" by the JSGlobalData,
but there's an issue in that there can be races between a thread that is trying to tear down a JSGlobalData
and the HeapTimer's fire function. Our current code for tearing down HeapTimers is an intricate and delicate
dance which probably contains subtle bugs.
We can make our lives easier by changing things around a bit.
1) We should free the API lock from being solely owned by the JSGlobalData so we don't have to worry about
grabbing the lock out of invalid memory when our HeapTimer callback fires.
2) We should also make it so that we deref the JSGlobalData first, then unlock the API lock so that when we
have the lock, the JSGlobalData is in one of two states: fully valid or completely destroyed, and we know exactly which one.
3) The JSLock can tell us this information by keeping a back pointer to the JSGlobalData. When the JSGlobalData's
destructor is called, it clears this pointer in the JSLock. Other clients of the API lock can then check
this pointer to determine whether or not the JSGlobalData is still around.
4) The CFRunLoopTimer will use the API lock as its context rather than the HeapTimer itself. The only way
the HeapTimer's callback can get to the HeapTimer is through the API lock's JSGlobalData pointer.
5) The CFRunLoopTimerContext struct has two fields for retain and release callbacks for the context's info field.
We'll provide these callbacks to ref() and deref() the JSLock as necessary. Thus, the timer becomes the other
owner of the JSLock apart from the JSGlobalData.
- API/APIShims.h: Remove the cruft that was required by the previous design, such as RefGlobalDataTag.
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(APIEntryShimWithoutLock):
(JSC::APIEntryShim::APIEntryShim):
(JSC::APIEntryShim::~APIEntryShim): Protect the API lock with a RefPtr, deref the JSGlobalData, which could destroy it,
then unlock the API lock. This ordering prevents others from obtaining the API lock while the JSGlobalData is in the
middle of being torn down.
(JSC::APIEntryShim::init): We now take the lock, then ref the JSGlobalData, which is the opposite order of when we
tear down the shim.
- heap/Heap.cpp:
(JSC::Heap::setActivityCallback): Use PassOwnPtr now.
(JSC::Heap::activityCallback): Ditto.
(JSC::Heap::sweeper): Ditto.
(JSC):
- heap/Heap.h:
(Heap):
- heap/HeapTimer.cpp:
(JSC::retainAPILock): Retain callback for CFRunLoopTimerContext struct.
(JSC::releaseAPILock): Release callback for the CFRunLoopTimerContext struct.
(JSC::HeapTimer::HeapTimer): Use the API lock as the context's info field rather than the HeapTimer.
(JSC::HeapTimer::timerDidFire): Grab the API lock. Return early if the JSGlobalData has already been destroyed.
Otherwise, figure out which kind of HeapTimer we are based on the CFRunLoopTimerRef passed to the callback and
call the HeapTimer's callback.
- heap/HeapTimer.h:
(HeapTimer):
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::create): PassOwnPtr all the things.
- heap/IncrementalSweeper.h:
(IncrementalSweeper):
- jsc.cpp:
(jscmain): We use an APIEntryShim instead of a RefPtr for the JSGlobalData because we need to
tear down the JSGlobalData while we still hold the lock, which the APIEntryShim handles correctly.
- runtime/GCActivityCallback.h:
(DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::create):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData): Notify the API lock that the JSGlobalData is being torn down.
- runtime/JSGlobalData.h:
(JSGlobalData):
(JSC::JSGlobalData::apiLock):
- runtime/JSLock.cpp:
(JSC::JSLockHolder::JSLockHolder): Ref, then lock (just like the API shim).
(JSC):
(JSC::JSLock::willDestroyGlobalData):
(JSC::JSLockHolder::init):
(JSC::JSLockHolder::~JSLockHolder): Protect, deref, then unlock (just like the API shim).
(JSC::JSLock::JSLock):
- runtime/JSLock.h: Add back pointer to the JSGlobalData and a callback for when the JSGlobalData is being
torn down that clears this pointer to notify other clients (i.e. timer callbacks) that the JSGlobalData is no
longer valid.
(JSLockHolder):
(JSLock):
(JSC::JSLock::globalData):
- testRegExp.cpp:
(realMain): We use an APIEntryShim instead of a RefPtr for the JSGlobalData because we need to
tear down the JSGlobalData while we still hold the lock, which the APIEntryShim handles correctly.
- 4:04 PM Changeset in webkit [148474] by
-
- 14 edits1 add in trunk/Source
LLInt SH4 backend implementation
https://bugs.webkit.org/show_bug.cgi?id=112886
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-04-15
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- dfg/DFGOperations.cpp:
(JSC):
- jit/JITStubs.cpp:
- llint/LLIntOfflineAsmConfig.h:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- offlineasm/arm.rb:
- offlineasm/ast.rb:
- offlineasm/backends.rb:
- offlineasm/instructions.rb:
- offlineasm/mips.rb:
- offlineasm/risc.rb:
- offlineasm/sh4.rb: Added.
Source/WTF:
- wtf/Platform.h:
- 3:56 PM Changeset in webkit [148473] by
-
- 2 edits in branches/safari-536.30-branch/Source/JavaScriptCore
Merged r141029. <rdar://problem/13334878>
- 3:26 PM Changeset in webkit [148472] by
-
- 5 edits in branches/safari-536.30-branch/Source/WebCore
r138821, <rdar://problem/13334928>
- 3:19 PM Changeset in webkit [148471] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebCore
Merged r138990.
2013-01-07 Tom Sepez <tsepez@chromium.org>
Document::initSecurityContext() gives parent security context to iframes with invalid URLs.
https://bugs.webkit.org/show_bug.cgi?id=104960
Reviewed by Adam Barth.
Change covers the case of an invalid non-empty URL. We know nothing
about that kind of URL and choose not to inherit origins.
- dom/Document.cpp:
(WebCore::shouldInheritSecurityOriginFromOwner):
- 3:07 PM Changeset in webkit [148470] by
-
- 5 edits2 copies in branches/safari-536.30-branch
Merge r143454. <rdar://problem/13334919>
- 2:42 PM Changeset in webkit [148469] by
-
- 4 edits2 copies in branches/safari-536.30-branch
Merge r143454. <rdar://problem/13334874>
- 2:25 PM Changeset in webkit [148468] by
-
- 2 edits in trunk/Source/WebCore
Call directly RenderBlock::deleteLineBoxTree
https://bugs.webkit.org/show_bug.cgi?id=102761
Reviewed by Darin Adler.
Instead of implementing RenderLineBoxList::deleteLineBoxTree logic inside
RenderBlock::determineStartPosition, we can reuse the code. The commentaries added
in the changeset #86628 are not valid anymore, nextRootBox is casting m_nextLineBox
and nextLineBox is returning m_nextLineBox.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::determineStartPosition):
- 2:19 PM Changeset in webkit [148467] by
-
- 4 edits in trunk/Source/WebCore
Remove files related to quota and proximity events from the Xcode project
https://bugs.webkit.org/show_bug.cgi?id=114635
Reviewed by Benjamin Poulain.
- WebCore.xcodeproj/project.pbxproj:
- history/PageCache.cpp:
- page/DOMWindow.cpp:
- 2:07 PM Changeset in webkit [148466] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Crash from null m_webSettings in WebPagePrivate
https://bugs.webkit.org/show_bug.cgi?id=114633
RIM PR 303745
Patch by Liam Quinn <lquinn@blackberry.com> on 2013-04-15
Reviewed by Rob Buis.
Internally reviewed by Leo Yang.
Speculative fix suggested by George Staikos--initialize m_webSettings first thing in the init() method.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
- 2:05 PM Changeset in webkit [148465] by
-
- 17 edits in branches/safari-536.30-branch
Merge r142759. <rdar://problem/13334873>
- 2:04 PM Changeset in webkit [148464] by
-
- 2 edits in trunk/Source/WebKit2
After switching to another space and back, video races to catch up with audio
https://bugs.webkit.org/show_bug.cgi?id=114634
Reviewed by Tim Horton.
In Mountain Lion and previous, report that a view is "not visible" when its window
is not in the active space. This causes us to notify AVFoundation that its CAImageQueues
will not be serviced and results in not having the "catch up" behavior when returning
to the browser's space.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::isViewVisible):
- 1:32 PM Changeset in webkit [148463] by
-
- 17 edits in trunk
[CMake] Add WTF_USE_*_UNICODE variables
https://bugs.webkit.org/show_bug.cgi?id=114556
Reviewed by Brent Fulgham.
WTF_USE_ICU_UNICODE and WTF_USE_WCHAR_UNICODE are used to
reduce duplication in the platform specific CMake files.
.:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsWinCE.cmake:
Source/JavaScriptCore:
- CMakeLists.txt:
- PlatformEfl.cmake:
Source/WebCore:
- CMakeLists.txt:
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformWinCE.cmake:
Source/WTF:
- wtf/CMakeLists.txt:
- wtf/PlatformBlackBerry.cmake:
- wtf/PlatformEfl.cmake:
- wtf/PlatformWinCE.cmake:
- 1:23 PM Changeset in webkit [148462] by
-
- 3 edits in trunk/Source/WTF
[WIN] Remove remaining calls to pthread from WTF
https://bugs.webkit.org/show_bug.cgi?id=114563
Reviewed by Brent Fulgham.
Replace pthread_key_create with threadSpecificKeyCreate and
pthread_setspecific with threadSpecificSet from ThreadSpecific.h.
These functions provide a windows-specific implementation for the pthread functions,
but require that the thread has been created with WTF::createThread(),
which is the case for all threads created within WebKit.
To call this function from fastMalloc we must not call fastMalloc in them.
To fulfill this constraint ThreadSpecificWin will allocated its memory through the
original malloc implementation and use the stack for local and static variables.
Keep the Darwin implementation as it is, since it contains some performance tweaks.
- wtf/FastMalloc.cpp:
- wtf/ThreadSpecificWin.cpp:
(WTF::destructorsList):
(WTF::destructorsMutex):
(WTF::threadSpecificKeyCreate):
(WTF::threadSpecificKeyDelete):
- 1:13 PM Changeset in webkit [148461] by
-
- 2 edits in trunk/Tools
WKR gets stuck when there are many merges
https://bugs.webkit.org/show_bug.cgi?id=114632
Reviewed by Andreas Kling.
Move the last revision forward when it exists in a branch.
Otherwise, we'll be stuck looping over revisions made to merge patches.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.next_work_item):
- 1:09 PM Changeset in webkit [148460] by
-
- 4 edits in branches/safari-536.30-branch/Source/WebCore
Merge 133840, 134191, 134197, <rdar://problem/13334895>
- 1:05 PM Changeset in webkit [148459] by
-
- 9 edits in branches/safari-536.30-branch/Source/WebCore
Merged r140127. <rdar://problem/13334953>
- 12:46 PM Changeset in webkit [148458] by
-
- 2 edits in trunk/Source/WebCore
HTMLMediaElement::removeTextTrack should clear track client
https://bugs.webkit.org/show_bug.cgi?id=114630
Reviewed by Jer Noble.
No new tests, this is clean-up that prevents a potential crash.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removeTextTrack): Clear the track client.
- 12:39 PM Changeset in webkit [148457] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebCore
Merge r138213, <rdar://problem/13335063>
- 12:32 PM Changeset in webkit [148456] by
-
- 2 edits in trunk/Source/WebKit/win
Crash when favicon is requested
https://bugs.webkit.org/show_bug.cgi?id=114624
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-15
Reviewed by Brent Fulgham.
- WebIconDatabase.cpp:
(WebIconDatabase::getOrCreateDefaultIconBitmap): Added NULL pointer check.
- 12:04 PM Changeset in webkit [148455] by
-
- 7 edits1 delete in branches/safari-536.30-branch
Rollout r145643.
- 11:27 AM Changeset in webkit [148454] by
-
- 4 edits2 adds in branches/safari-536.30-branch
Merge r142816, <rdar://problem/13334866>
- 11:23 AM Changeset in webkit [148453] by
-
- 3 edits2 adds in trunk
An inline element with an absolutely positioned child does not correctly calculate/render padding and margin
https://bugs.webkit.org/show_bug.cgi?id=47554
Reviewed by David Hyatt.
Source/WebCore:
When looking for padding/margin to add from the start of a child's parent skip past any leading positioned siblings as
we don't add the padding/margin of the common parent when skipping past them in |skipLeadingWhitespace|. We
don't need to worry about the case of trailing positioned objects as we will account for their parent's
border/margin/padding when we encounter them in |nextSegmentBreak|.
Test: fast/inline/padding-before-leading-positioned-element-contributes-width.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::previousInFlowSibling):
(WebCore):
(WebCore::inlineLogicalWidth):
LayoutTests:
- fast/inline/padding-before-leading-positioned-element-contributes-width-expected.txt: Added.
- fast/inline/padding-before-leading-positioned-element-contributes-width.html: Added.
- 11:19 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:16 AM Changeset in webkit [148452] by
-
- 1 edit1 add in trunk/LayoutTests
Flaky Test: http/tests/ssl/ping-with-unsafe-redirect.html
https://bugs.webkit.org/show_bug.cgi?id=114616
Land expected results for the test.
- http/tests/ssl/ping-with-unsafe-redirect-expected.txt: Added.
- 11:02 AM Changeset in webkit [148451] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Forward userGesture when creating a new window
https://bugs.webkit.org/show_bug.cgi?id=114622
Patch by Andy Chen <andchen@blackberry.com> on 2013-04-15
Reviewed by Rob Buis.
Client could use this info to decide whether the popup should
be blocked.
PR 291898
Reviewed internally by Mike Fenton
- Api/WebPageClient.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
- 10:59 AM Changeset in webkit [148450] by
-
- 3 edits2 adds in branches/safari-536.30-branch
Merge r142922, <rdar://problem/13334860>
- 10:52 AM Changeset in webkit [148449] by
-
- 2 edits in trunk/Tools
[GTK] Missing a few packages for building on stock Fedora
https://bugs.webkit.org/show_bug.cgi?id=113916
Reviewed by Philippe Normand.
- gtk/install-dependencies: add packages that are missing.
- 10:46 AM Changeset in webkit [148448] by
-
- 3 edits2 adds in branches/safari-536.30-branch
Merged r138988, <rdar://problem/13334838>
- 10:13 AM Changeset in webkit [148447] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=114623
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-15
Reviewed by Brent Fulgham.
- platform/network/curl/CookieJarCurl.cpp: Added required header files.
- 10:09 AM Changeset in webkit [148446] by
-
- 2 edits in trunk/Tools
REGRESSION (r148360): Failure in webkitpy.tool.multicommandtool_unittest.MultiCommandToolTest.test_command_help
https://bugs.webkit.org/show_bug.cgi?id=114602
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/tool/multicommandtool_unittest.py:
(CommandTest.test_required_arguments): Reset the static argument_names variable on the TrivialCommand
interface so its value doesn't leak into the following tests.
- 10:06 AM Changeset in webkit [148445] by
-
- 2 edits in trunk
[GTK] REGRESSION(r147499): HTTP auth dialog doesn't remember passwords anymore
https://bugs.webkit.org/show_bug.cgi?id=114613
Reviewed by Carlos Garcia Campos.
- Source/autotools/SetupAutoconfHeader.m4: Correct definition of ENABLE_CREDENTIAL_STORAGE
so that the ENABLE(CREDENTIAL_STORAGE) macro work properly.
- 9:22 AM Changeset in webkit [148444] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- 9:07 AM Changeset in webkit [148443] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r148236.
- 8:52 AM Changeset in webkit [148442] by
-
- 2 edits in trunk/Source/WebCore
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790
Patch by Rob Buis <rbuis@rim.com> on 2013-04-15
Reviewed by Darin Adler.
It does not seem needed to initialize jpeg_create_compress struct to zero,
all that is needed is set the err field. See for instance SkImageDecoder_libjpeg.cpp.
- platform/image-encoders/JPEGImageEncoder.cpp:
(WebCore::compressRGBABigEndianToJPEG):
- 8:39 AM Changeset in webkit [148441] by
-
- 3 edits in trunk/Tools
Deprecate land-cowboy in favor of land-cowhand
https://bugs.webkit.org/show_bug.cgi?id=104470
Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-04-15
Reviewed by Darin Adler.
Move the LandCowboy command implementation under the LandCowhand command and deprecate the former.
- Scripts/webkitpy/tool/commands/download.py:
(LandCowhand):
(LandCowboy):
(LandCowboy._prepare_state):
- Scripts/webkitpy/tool/commands/download_unittest.py:
(test_land_cowhand): Adjust the unit tests by testing both LandCowhand and LandCowboy,
also checking the deprecation message in the output of the latter.
- 8:28 AM Changeset in webkit [148440] by
-
- 3 edits1 delete in trunk/Source/WebCore
[GTK] Remove platform specific implementation of KURL::fileSystemPath()
https://bugs.webkit.org/show_bug.cgi?id=114133
Reviewed by Martin Robinson.
r147883 added a generic implementation of this function,
which can be used by all ports to share the code.
- GNUmakefile.list.am:
- platform/KURL.cpp:
(WebCore):
- platform/gtk/KURLGtk.cpp: Removed.
- 8:28 AM Changeset in webkit [148439] by
-
- 3 edits in trunk/Source/WebKit2
Schedule rendering at regular interval (60fps)
https://bugs.webkit.org/show_bug.cgi?id=114617
Patch by Seulgi Kim <seulgikim@company100.net> on 2013-04-15
Reviewed by Martin Robinson.
Schedule rendering reguarly regardless of the time taken to render a
frame. Otherwise, next flush delayed by the amount of the rendering
time.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::LayerTreeHostGtk):
(WebKit::LayerTreeHostGtk::layerFlushTimerFired):
(WebKit::LayerTreeHostGtk::flushAndRenderLayers):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
- 8:25 AM Changeset in webkit [148438] by
-
- 2 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r148373.
- WebCoreSupport/EditorClientWinCE.cpp:
- 8:22 AM Changeset in webkit [148437] by
-
- 2 edits in trunk/Source/WebCore
Debug buildfix after r148433.
https://bugs.webkit.org/show_bug.cgi?id=108295
Reviewed by Allan Sandfeld Jensen.
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore::TextureMapperLayer::children): Added.
- 7:16 AM Changeset in webkit [148436] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt/TestExpectations:
- 7:02 AM Changeset in webkit [148435] by
-
- 2 edits in trunk/Tools
Improve Windows cmd.exe detection
https://bugs.webkit.org/show_bug.cgi?id=114620
Patch by Jonathan Liu <net147@gmail.com> on 2013-04-15
Reviewed by Jocelyn Turcotte.
The current detection code handles Windows cmd.exe and Cygwin shell
but not does not handle MSYS shell correctly. Simplify and improve the
detection by checking MINGW_IN_SHELL instead as used in other places
(e.g. qt_functions.prf).
- qmake/mkspecs/features/default_pre.prf:
- 6:43 AM Changeset in webkit [148434] by
-
- 12 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API in ewk_context_menu
https://bugs.webkit.org/show_bug.cgi?id=109698
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-04-15
Reviewed by Andreas Kling.
EFL port unlike others does not handle context menus inside WebKit but exposes an API:
ewk_context_menu and ewk_context_menu_item, and leaves context menu to application.
Currently EFL port's context menu API uses internal C++ classes, while it should use WK2 C API,
to avoid violating layering.
This patch changes EFL context menu API to use only WK2 C API.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::showContextMenu):
- UIProcess/API/efl/EwkView.h:
(WebKit):
(EwkView):
- UIProcess/API/efl/ewk_context_menu.cpp:
(EwkContextMenu::EwkContextMenu):
(EwkContextMenu::contextMenuItemSelected):
(ewk_context_menu_item_select):
(getWKTagFromEwkAction):
- UIProcess/API/efl/ewk_context_menu_item.cpp:
(EwkContextMenuItem::EwkContextMenuItem):
(getEwkActionFromWKTag):
- UIProcess/API/efl/ewk_context_menu_item.h:
- UIProcess/API/efl/ewk_context_menu_item_private.h:
(EwkContextMenuItem::create):
(EwkContextMenuItem):
- UIProcess/API/efl/ewk_context_menu_private.h:
(EwkContextMenu::create):
(EwkContextMenu):
- UIProcess/efl/ContextMenuClientEfl.cpp:
(showContextMenu):
(hideContextMenu):
(ContextMenuClientEfl::ContextMenuClientEfl):
- UIProcess/efl/ContextMenuClientEfl.h:
(WebKit::ContextMenuClientEfl::view):
- UIProcess/efl/WebContextMenuProxyEfl.cpp:
(WebKit::WebContextMenuProxyEfl::showContextMenu):
(WebKit::WebContextMenuProxyEfl::hideContextMenu):
- UIProcess/efl/WebContextMenuProxyEfl.h:
(WebContextMenuProxyEfl):
- 6:24 AM Changeset in webkit [148433] by
-
- 6 edits in trunk/Source/WebCore
Coordinated Graphics: Remove GraphicsLayerTextureMapper dependency from CoordinatedGraphicsScene.
https://bugs.webkit.org/show_bug.cgi?id=108295
Since all the changes to the TextureMapperLayer tree now come in a single IPC message via
CoordinatedGraphicsState, we don't need the additional buffering done in GraphicsLayerTextureMapper.
This reduces unnecessary function calls, and also streamlines GraphicsLayerTextureMapper to be used
only in WebKit1 (without CoordinatedGraphics).
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-15
Reviewed by Allan Sandfeld Jensen.
No new tests, refactor only.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::setDrawsContent):
(WebCore::GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded):
(WebCore::GraphicsLayerTextureMapper::updateDebugBorderAndRepaintCount):
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):
(WebCore):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
Removed references to m_hasOwnBackingStore, which was done to separate the CoordinatedGraphics
path from the WK1 path.
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore::TextureMapperLayer::drawsContent):
(WebCore::TextureMapperLayer::contentsAreVisible):
(WebCore::TextureMapperLayer::size):
(WebCore::TextureMapperLayer::opacity):
(WebCore::TextureMapperLayer::transform):
(WebCore::TextureMapperLayer::isShowingRepaintCounter):
(WebCore::TextureMapperLayer::fixedToViewport):
(TextureMapperLayer):
Added a few public functions needed by CoordinatedGraphicsScene.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::layerShouldHaveBackingStore):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebCore::CoordinatedGraphicsScene::paintToGraphicsContext):
(WebCore::CoordinatedGraphicsScene::adjustPositionForFixedLayers):
(WebCore::CoordinatedGraphicsScene::createCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::syncCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::destroyCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerRepaintCountIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerChildrenIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerFiltersIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerState):
(WebCore::CoordinatedGraphicsScene::getLayerByIDIfExists):
(WebCore::CoordinatedGraphicsScene::createLayer):
(WebCore::CoordinatedGraphicsScene::deleteLayer):
(WebCore::CoordinatedGraphicsScene::setRootLayerID):
(WebCore::CoordinatedGraphicsScene::prepareContentBackingStore):
(WebCore::CoordinatedGraphicsScene::createBackingStoreIfNeeded):
(WebCore::CoordinatedGraphicsScene::removeBackingStoreIfNeeded):
(WebCore::CoordinatedGraphicsScene::resetBackingStoreSizeToLayerSize):
(WebCore::CoordinatedGraphicsScene::createTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::removeTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::updateTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::assignImageBackingToLayer):
(WebCore::CoordinatedGraphicsScene::commitSceneState):
(WebCore::CoordinatedGraphicsScene::ensureRootLayer):
(WebCore::CoordinatedGraphicsScene::setLayerAnimationsIfNeeded):
(WebCore::CoordinatedGraphicsScene::findScrollableContentsLayerAt):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
(CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::layerByID):
(WebCore::CoordinatedGraphicsScene::rootLayer):
Use TextureMapperLayer instead of GraphicsLayer and GraphicsLayerTextureMapper.
- 6:00 AM Changeset in webkit [148432] by
-
- 5 edits in trunk/Source/WebCore
Dynamically triggered subframe loads are causing tile churn
https://bugs.webkit.org/show_bug.cgi?id=114440
Reviewed by Andreas Kling.
In some cases we switch in and out of minimal tiles multiple times during page loading. This
creates tile churn where we create speculative tiles and then throw them out. This can be
caused by various reasons including dynamically created subframes.
- page/FrameView.cpp:
(WebCore::FrameView::setIsVisuallyNonEmpty):
Stay in minimal tiles modes until there is some visual contents. This avoids switching out from minimal
tiles while awaiting response for the initial requests.
- page/FrameView.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::computeTileCoverage):
- rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::didSwitchToFullTileCoverageDuringLoading):
(WebCore::RenderLayerBacking::setDidSwitchToFullTileCoverageDuringLoading):
Only switch into minimal coverage mode once per page load.
(RenderLayerBacking):
- 5:02 AM Changeset in webkit [148431] by
-
- 5 edits4 adds in trunk
color-index media feature not supported
https://bugs.webkit.org/show_bug.cgi?id=114468
Patch by Rune Lillesveen <rune@opera.com> on 2013-04-15
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Support the color-index media feature. Currently assumes that no WebKit
browser will have an output device that uses a color lookup table.
Tests: fast/media/mq-color-index-01.html
fast/media/mq-color-index-02.html
- css/MediaFeatureNames.h:
(MediaFeatureNames):
- css/MediaQueryEvaluator.cpp:
(WebCore::color_indexMediaFeatureEval):
(WebCore):
(WebCore::min_color_indexMediaFeatureEval):
(WebCore::max_color_indexMediaFeatureEval):
- css/MediaQueryExp.cpp:
(WebCore::featureWithPositiveInteger):
(WebCore::featureWithoutValue):
LayoutTests:
Added testcases for checking support and handling invalid values for
the color-index media feature.
- fast/media/mq-color-index-01-expected.html: Added.
- fast/media/mq-color-index-01.html: Added.
- fast/media/mq-color-index-02-expected.txt: Added.
- fast/media/mq-color-index-02.html: Added.
- 4:49 AM Changeset in webkit [148430] by
-
- 6 edits in trunk/Source
[CoordGfx] Background color should not be part of GraphicsLayerState
https://bugs.webkit.org/show_bug.cgi?id=113785
Source/WebCore:
Page background is independent from layer state, send it to the UI
as soon as possible.
Should not cause observable change in behavior so no new tests.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::commitSceneState):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
Source/WebKit2:
Reviewed by Andreas Kling.
Page background is independent from layer state, send it to the UI
as soon as possible.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::setBackgroundColor):
- 4:11 AM QtWebKitBuildBots edited by
- Updating some bot information. (diff)
- 4:08 AM Changeset in webkit [148429] by
-
- 2 edits in trunk/Tools
[webkitpy] Use $NUMBER_OF_PROCESSORS in Executive.cpu_count()
https://bugs.webkit.org/show_bug.cgi?id=114506
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-15
Reviewed by Philippe Normand.
- Scripts/webkitpy/common/system/executive.py:
(Executive.cpu_count): Modify function in order to use the environment
variable $NUMBER_OF_PROCESSORS if it is defined and it is an integer
greater than 0.
- 3:58 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:57 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:54 AM Changeset in webkit [148428] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Merge r147967 - Bug 110293 uses read -d which is a non-portable bashism
https://bugs.webkit.org/show_bug.cgi?id=113349
Reviewed by Gustavo Noronha Silva.
- Source/autotools/SetupWebKitFeatures.m4: Pass the default feature set to the
feature script in a more portable way.
- 3:50 AM Changeset in webkit [148427] by
-
- 5 edits in trunk
[BlackBerry] ASSERT in StyleResolver::ensureScopeResolver()
https://bugs.webkit.org/show_bug.cgi?id=114615
Patch by Xan Lopez <xlopez@igalia.com> on 2013-04-15
Reviewed by Carlos Garcia Campos.
Source/WebKit/blackberry:
Add a method to enable the style scoped feature to our
DumpRenderTreeSupport class.
- WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::setStyleScopedEnabled):
- WebKitSupport/DumpRenderTreeSupport.h:
(DumpRenderTreeSupport):
Tools:
Enable the style scoped feature if we have support for it.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
- 3:36 AM Changeset in webkit [148426] by
-
- 3 edits in trunk/LayoutTests
[EFL] Unskip some inspector tests related to styles
https://bugs.webkit.org/show_bug.cgi?id=114609
Unreviewed gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-15
- platform/efl-wk2/TestExpectations: Old issues. Fixed on the latest codebase.
- platform/efl/TestExpectations: Fixed by r128637.
- 3:35 AM QtWebKitGardening edited by
- Rename sheriffbot to webkitbot (diff)
- 3:33 AM CommitterTips edited by
- Rename sheriffbot to webkitbot (diff)
- 3:11 AM Changeset in webkit [148425] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Filesystem callback notifyCreateSnapshotFileAndReadMetadata can be called on the wring thread
https://bugs.webkit.org/show_bug.cgi?id=114610
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-15
Reviewed by Xan Lopez.
Override notifyCreateSnapshotFileAndReadMetadata to make sure the
callback is called on the right thread.
Fixes a crash in several fast/filesystem test in debug builds.
- platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.cpp:
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyCreateSnapshotFileAndReadMetadata):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyCreateSnapshotFileAndReadMetadataOnWorkerThread):
- platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.h:
- 2:31 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:28 AM Changeset in webkit [148424] by
-
- 9 edits in releases/WebKitGTK/webkit-2.0
Merge r147499 - [GTK] Make libsecret optional
https://bugs.webkit.org/show_bug.cgi?id=113821
Reviewed by Gustavo Noronha Silva.
.:
Add a configuration option to disable credential storage and thus remove
the libsecret dependency. This should make it possible to build WebKit 2.x
on Windows again.
- Source/autotools/FindDependencies.m4: Only look for libsecret if credential storage is active.
- Source/autotools/PrintBuildConfiguration.m4: Print whether or not credential storage is active.
- Source/autotools/ReadCommandLineArguments.m4: Added an option to control credential storage.
- Source/autotools/SetupAutoconfHeader.m4: Expose credential storage setting to code.
Source/WebCore:
Don't try to use libsecret if credential storage is disabled.
- platform/gtk/GRefPtrGtk.cpp: Protect libsecret sections.
- platform/gtk/GRefPtrGtk.h: Ditto.
- platform/network/gtk/CredentialBackingStore.cpp: Ditto.
- 2:18 AM Changeset in webkit [148423] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry][CSS Filters] Non-image content disappears when filter applied
https://bugs.webkit.org/show_bug.cgi?id=114498
Reviewed by Carlos Garcia Campos.
Applying a filter to a div with simple text content caused the div to
disappear.
In https://bugs.webkit.org/show_bug.cgi?id=114276, we added some GL
state save/restore code for vertex attributes to make sure the state
changes done by BlackBerry::Platform::Graphics don't interfere with
GL code executing in WebKit. However, saving and restoring vertex
attribute state won't do much good if those attributes were never
enabled to begin with. Fixed by enabling vertex attributes
appropriately when setting them, so that state can be saved and
restored.
All the CSS Filters layout tests apply the filters to simple rectangles
or images, there's nothing sufficiently complex that we manage to
trigger this GL state conflict in the BlackBerry port. This suggests
adding a new platform-specific layout test would be appropriate, but
since we don't use pixel tests yet, such a test would not help detect
regressions. Ultimately we decided against adding a layout test for
this bug at this time.
- platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore::LayerFilterRenderer::applyActions):
- 2:16 AM Changeset in webkit [148422] by
-
- 2 edits in trunk/Tools
[Qt] QtMultimedia not used when GStreamer is not found
https://bugs.webkit.org/show_bug.cgi?id=111842
Reviewed by Philippe Normand.
Fallback to using QtMultimedia when native libraries are not found.
- qmake/mkspecs/features/features.prf:
- 2:11 AM Changeset in webkit [148421] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
spelling-with-whitespace-selection.html passes after r148282.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 2:02 AM Changeset in webkit [148420] by
-
- 10 edits in trunk/Source/WebKit2
[WK2] Add new callbacks and a function for WebKit2 context menu API
https://bugs.webkit.org/show_bug.cgi?id=111552
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-04-15
Reviewed by Anders Carlsson.
Add contextMenuHide and contextMenuShow callbacks to WKPageContextMenuClient
and WKPageContextMenuSelected API so context menus can be handled outside
WebKit. API version of this client was bumped so older client version still
can be used
- Shared/APIClientTraits.cpp:
(WebKit):
- Shared/APIClientTraits.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageSelectContextMenuItem):
- UIProcess/API/C/WKPage.h:
- UIProcess/API/gtk/WebKitContextMenuClient.cpp:
(attachContextMenuClientToView):
- UIProcess/WebPageContextMenuClient.cpp:
(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
(WebKit::WebPageContextMenuClient::showContextMenu):
(WebKit):
(WebKit::WebPageContextMenuClient::hideContextMenu):
- UIProcess/WebPageContextMenuClient.h:
(WebPageContextMenuClient):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::internalShowContextMenu):
- UIProcess/efl/ContextMenuClientEfl.cpp:
(ContextMenuClientEfl::ContextMenuClientEfl):
- 1:20 AM Changeset in webkit [148419] by
-
- 2 edits in trunk/LayoutTests
[EFL] inspector/styles/styles-history.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=98777
Unreviewed gardening.
Unskip inspector/styles/styles-history.html as it was fixed by r131895.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-15
- platform/efl/TestExpectations:
- 12:27 AM Changeset in webkit [148418] by
-
- 1 edit1 delete in trunk/LayoutTests
[EFL] Remove inspector/styles/paste-property-expected.txt from efl-wk2
https://bugs.webkit.org/show_bug.cgi?id=114604
Unreviewed gardening.
Remove an improper file after r147420.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-15
- platform/efl-wk2/inspector/styles/paste-property-expected.txt: Removed.
- 12:06 AM Changeset in webkit [148417] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline fast/js/global-constructors.html for EFL port due to
addition of MutationRecordConstructor.
- platform/efl/fast/js/global-constructors-expected.txt:
Apr 14, 2013:
- 11:58 PM Changeset in webkit [148416] by
-
- 14 edits6 deletes in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline several SVG tests for EFL port.
- platform/efl-wk2/svg/css/group-with-shadow-expected.png:
- platform/efl-wk2/svg/filters/shadow-on-rect-with-filter-expected.png:
- platform/efl/svg/css/arrow-with-shadow-expected.png:
- platform/efl/svg/css/arrow-with-shadow-expected.txt: Removed.
- platform/efl/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
- platform/efl/svg/css/clippath-with-shadow-expected.txt: Removed.
- platform/efl/svg/css/composite-shadow-example-expected.png:
- platform/efl/svg/css/composite-shadow-example-expected.txt:
- platform/efl/svg/css/composite-shadow-with-opacity-expected.png:
- platform/efl/svg/css/composite-shadow-with-opacity-expected.txt:
- platform/efl/svg/css/group-with-shadow-expected.txt:
- platform/efl/svg/css/path-with-shadow-expected.txt:
- platform/efl/svg/css/shadow-and-opacity-expected.txt:
- platform/efl/svg/css/shadow-with-large-radius-expected.txt: Removed.
- platform/efl/svg/css/shadow-with-negative-offset-expected.txt: Removed.
- platform/efl/svg/css/text-gradient-shadow-expected.txt:
- platform/efl/svg/css/text-shadow-multiple-expected.txt:
- platform/efl/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
- platform/efl/transitions/svg-text-shadow-transition-expected.txt:
- 8:13 PM CommitterTips edited by
- Clarify that "Unreviewed" should be present if no "Reviewed by" is present. (diff)
- 7:22 PM Changeset in webkit [148415] by
-
- 2 edits in branches/safari-536.30-branch/Source/JavaScriptCore
Revert "Attempt to fix Windows build after r148370"
This reverts commit r148375.
- runtime/JSStringJoiner.h: Remove include of
<wtf/CheckedArithmetic.h>.
- 6:29 PM Changeset in webkit [148414] by
-
- 12 edits in trunk
[css3-text] Parsing -webkit-hanging value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=113680
Source/WebCore:
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-14
Reviewed by Andreas Kling.
This patch is the parsing part to support hanging value for text-indent.
"hanging" means "Inverts which lines are affected."
It's prefixed and guarded by CSS3_TEXT flag.
No new tests, this patch updates existing tests.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseTextIndent): Parsed "-webkit-hanging" with "-webkit-each-line".
- css/CSSValueKeywords.in: Added "-webkit-hanging" keyword.
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyTextIndent::applyInheritValue):
(WebCore::ApplyPropertyTextIndent::applyInitialValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h: Added enum TextIndentType.
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h: Added m_textIndentType.
(StyleRareInheritedData):
Added the usual getter / setter / initial methods for m_textIndentType.
LayoutTests:
"hanging" is added for text-indent in CSS3.
http://dev.w3.org/csswg/css3-text/#hanging
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-14
Reviewed by Andreas Kling.
- fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt:
- fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent.js:
(valueSettingTest):
- 4:32 PM Changeset in webkit [148413] by
-
- 9 edits2 adds in trunk/Source
Move Mac specific snapshotting code into its own file
https://bugs.webkit.org/show_bug.cgi?id=114597
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm:
(-[DOMRange renderedImageForcingBlackText:]):
- page/Frame.h:
- page/mac/FrameMac.mm:
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
- page/mac/FrameSnapshottingMac.h: Added.
- page/mac/FrameSnapshottingMac.mm: Added.
(WebCore::imageFromRect):
(WebCore::selectionImage):
(WebCore::rangeImage):
(WebCore::snapshotDragImage):
- platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::dragNSImage):
Move the four Mac specific snapshotting functions in Frame.h into FrameSnapshottingMac.h/mm and turn
them into free standing functions.
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _selectionDraggingImage]):
(-[WebHTMLView selectionImageForcingBlackText:]):
- 2:50 PM Changeset in webkit [148412] by
-
- 2 edits in trunk/LayoutTests
Re-skip editing/spelling/spelling-changed-text.html on Mac/WK1.
- platform/mac/TestExpectations:
- 2:13 PM Changeset in webkit [148411] by
-
- 2 edits in trunk/Source/WebCore
Hawtfix Mac build.
- WebCore.exp.in:
- 1:32 PM Changeset in webkit [148410] by
-
- 5 edits in trunk/Source/WebCore
Only MutableStylePropertySets should be able to have CSSOM wrappers.
<http://webkit.org/b/114595>
Reviewed by Antti Koivisto.
Tighten typing so that only MutableStylePropertySets can have CSSOM wrappers associated.
This allows us to get rid of the out-of-line base class destructor.
- WebCore.exp.in:
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::~MutableStylePropertySet):
(WebCore::MutableStylePropertySet::cssStyleDeclaration):
(WebCore::MutableStylePropertySet::ensureInlineCSSStyleDeclaration):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- dom/StyledElement.cpp:
(WebCore::StyledElement::inlineStyleCSSOMWrapper):
- 1:05 PM Changeset in webkit [148409] by
-
- 4 edits in branches/safari-536.30-branch/Source/WTF
Try to fix Windows Elgar build again after r148370
Merge r148401.
Add EnumClass.h to the MSVC project.
2013-04-14 David Kilzer <ddkilzer@apple.com>
Add EnumClass.h to project files
<http://webkit.org/b/114582>
Rubber-stamped by Dan Bernstein.
- WTF.pro: Add EnumClass.h to project.
- WTF.vcproj/WTF.vcproj: Ditto.
- WTF.vcxproj/WTF.vcxproj: Ditto.
- WTF.vcxproj/WTF.vcxproj.filters: Ditto.
- WTF.xcodeproj/project.pbxproj: Ditto.
- 12:19 PM Changeset in webkit [148408] by
-
- 2 edits in trunk/Source/WebCore
Remove unused function declaration StylePropertySet::setNeedsStyleRecalc().
Rubber-stamped by Antti Koivisto.
- css/StylePropertySet.h:
(StylePropertySet):
- 12:17 PM Changeset in webkit [148407] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Regression(r148274): Broke rendering in the browser
https://bugs.webkit.org/show_bug.cgi?id=114593
Reviewed by Anders Carlsson.
r148274 added a new "didChangeViewportAttributes" callback to
WKView but did not hook it up in ViewClientEfl. This patch
fixes this and makes rendering work again in the browser.
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::ViewClientEfl):
- 12:09 PM Changeset in webkit [148406] by
-
- 3 edits in trunk/Source/WebCore
Move StylePropertySet internal storage access helpers to subclass.
<http://webkit.org/b/114592>
Reviewed by Antti Koivisto.
Removed mutablePropertyVector() since most call sites are inside MutableStylePropertySet
and can access m_propertyVector directly. The few ones that aren't can just cast.
For ImmutableStylePropertySet, moved value/metadata array accessors to the subclass
and remove "immutable" from their names.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::immutableCopyIfNeeded):
(WebCore::ImmutableStylePropertySet::ImmutableStylePropertySet):
(WebCore::ImmutableStylePropertySet::~ImmutableStylePropertySet):
(WebCore::MutableStylePropertySet::MutableStylePropertySet):
(WebCore::MutableStylePropertySet::removeProperty):
(WebCore::MutableStylePropertySet::removePrefixedOrUnprefixedProperty):
(WebCore::MutableStylePropertySet::setProperty):
(WebCore::MutableStylePropertySet::appendPrefixingVariantProperty):
(WebCore::MutableStylePropertySet::parseDeclaration):
(WebCore::MutableStylePropertySet::addParsedProperties):
(WebCore::MutableStylePropertySet::clear):
(WebCore::MutableStylePropertySet::removePropertiesInSet):
(WebCore::MutableStylePropertySet::findCSSPropertyWithID):
(WebCore::MutableStylePropertySet::removeEquivalentProperties):
(WebCore::StylePropertySet::reportMemoryUsage):
- css/StylePropertySet.h:
(PropertyReference):
(StylePropertySet):
(ImmutableStylePropertySet):
(WebCore::ImmutableStylePropertySet::valueArray):
(WebCore::ImmutableStylePropertySet::metadataArray):
(WebCore::StylePropertySet::PropertyReference::propertyMetadata):
(WebCore::StylePropertySet::PropertyReference::propertyValue):
(WebCore::StylePropertySet::propertyCount):
- 11:25 AM Changeset in webkit [148405] by
-
- 2 edits in trunk/Source/WTF
Try to fix non-apple windows builds
- 10:56 AM Changeset in webkit [148404] by
-
- 2 edits in trunk/Source/WebCore
Specialize propertyCount() in StylePropertySet subclasses.
<http://webkit.org/b/114590>
Reviewed by Antti Koivisto.
Avoid branching on m_isMutable in code that already knows which type of set it is.
- css/StylePropertySet.h:
(WebCore::ImmutableStylePropertySet::propertyCount):
(ImmutableStylePropertySet):
(WebCore::MutableStylePropertySet::propertyCount):
(MutableStylePropertySet):
- 10:49 AM Changeset in webkit [148403] by
-
- 9 edits in trunk/Source/WebCore
Move property setting/removing functions to MutableStylePropertySet.
<http://webkit.org/b/114589>
Reviewed by Antti Koivisto.
Move all functions for setting/removing properties from StylePropertySet to MutableStylePropertySet.
Had to change SVGElement::animatedSMILStyleProperties() & friends to hand out MutableStylePropertySet*
which was always the internal type anyway.
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::removeShorthandProperty):
(WebCore::MutableStylePropertySet::removeProperty):
(WebCore::MutableStylePropertySet::removePrefixedOrUnprefixedProperty):
(WebCore::MutableStylePropertySet::setProperty):
(WebCore::MutableStylePropertySet::appendPrefixingVariantProperty):
(WebCore::MutableStylePropertySet::setPrefixingVariantProperty):
(WebCore::MutableStylePropertySet::mergeAndOverrideOnConflict):
(WebCore::MutableStylePropertySet::removeBlockProperties):
(WebCore::MutableStylePropertySet::removePropertiesInSet):
(WebCore::MutableStylePropertySet::findCSSPropertyWithID):
(WebCore::MutableStylePropertySet::removeEquivalentProperties):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::removePropertiesInStyle):
(WebCore::reconcileTextDecorationProperties):
- svg/SVGAnimateElement.cpp:
(WebCore::applyCSSPropertyToTarget):
- svg/SVGElement.cpp:
(WebCore::SVGElement::animatedSMILStyleProperties):
(WebCore::SVGElement::ensureAnimatedSMILStyleProperties):
- svg/SVGElement.h:
(SVGElement):
- svg/SVGElementRareData.h:
(WebCore::SVGElementRareData::animatedSMILStyleProperties):
(WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):
(SVGElementRareData):
- 10:33 AM Changeset in webkit [148402] by
-
- 5 edits in trunk/Source/WebCore
EditingStyle should have a MutableStylePropertySet internally.
<http://webkit.org/b/114588>
Reviewed by Anders Carlsson.
Switch EditingStyle::m_mutableStyle to a RefPtr<MutableStylePropertySet>.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::copyBlockProperties):
- css/StylePropertySet.h:
(StylePropertySet):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::setStyle):
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::StyleChange::StyleChange):
(WebCore::setTextDecorationProperty):
(WebCore::StyleChange::extractTextStyles):
(WebCore::diffTextDecorations):
(WebCore::getPropertiesNotIn):
- editing/EditingStyle.h:
(WebCore::EditingStyle::style):
(EditingStyle):
(StyleChange):
- 9:49 AM Changeset in webkit [148401] by
-
- 6 edits in trunk/Source/WTF
Add EnumClass.h to project files
<http://webkit.org/b/114582>
Rubber-stamped by Dan Bernstein.
- WTF.pro: Add EnumClass.h to project.
- WTF.vcproj/WTF.vcproj: Ditto.
- WTF.vcxproj/WTF.vcxproj: Ditto.
- WTF.vcxproj/WTF.vcxproj.filters: Ditto.
- WTF.xcodeproj/project.pbxproj: Ditto.
- 9:43 AM Changeset in webkit [148400] by
-
- 6 edits in trunk/Source/WebCore
Move addParsedProperty/addParsedProperties to MutableStylePropertySet.
<http://webkit.org/b/114587>
Reviewed by Antti Koivisto.
All CSSParser methods that mutate an existing StylePropertySet now take a MutableStylePropertySet*
instead of a StylePropertySet*.
- css/CSSParser.cpp:
(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::parseKeywordValue):
(WebCore::parseTranslateTransformValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):
- css/CSSParser.h:
(CSSParser):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::setProperty):
(WebCore::MutableStylePropertySet::addParsedProperties):
(WebCore::MutableStylePropertySet::addParsedProperty):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- css/ViewportStyleResolver.h:
(ViewportStyleResolver):
- 9:21 AM Changeset in webkit [148399] by
-
- 3 edits in trunk/Source/WebCore
CSSParser should return ImmutableStylePropertySets.
<http://webkit.org/b/114585>
Reviewed by Anders Carlsson.
The StylePropertySets created by CSSParser were already immutable.
Let this be reflected in the pointer types returned.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseInlineStyleDeclaration):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::createStylePropertySet):
- css/CSSParser.h:
(CSSParser):
- 9:14 AM Changeset in webkit [148398] by
-
- 4 edits in trunk/Source/WebCore
Move StylePropertySet::createImmutable() to ImmutableStylePropertySet.
<http://webkit.org/b/114584>
Reviewed by Anders Carlsson.
StylePropertySet::createImmutable() -> ImmutableStylePropertySet::create()
Also, immutableCopyIfNeeded() now returns a PassRefPtr<ImmutableStylePropertySet>.
- css/CSSParser.cpp:
(WebCore::CSSParser::createStylePropertySet):
- css/StylePropertySet.cpp:
(WebCore::ImmutableStylePropertySet::create):
(WebCore::StylePropertySet::immutableCopyIfNeeded):
- css/StylePropertySet.h:
(StylePropertySet):
(ImmutableStylePropertySet):
- 8:46 AM Changeset in webkit [148397] by
-
- 5 edits in trunk/Source/WebCore
Move parseDeclaration() and clear() to MutableStylePropertySet.
<http://webkit.org/b/114583>
Reviewed by Anders Carlsson.
...and remove ASSERT(isMutable()) from the function bodies.
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::removedFrom):
Use clear() directly instead of taking an empty string through the CSS parser.
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::parseDeclaration):
(WebCore::MutableStylePropertySet::clear):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleFromString):
- 8:19 AM Changeset in webkit [148396] by
-
- 23 edits in trunk/Source
Move CSSOM classes to using MutableStylePropertySet over StylePropertySet.
<http://webkit.org/b/114581>
Reviewed by Anders Carlsson.
Source/WebCore:
Moved ensureCSSStyleDeclaration() and ensureInlineCSSStyleDeclaration() from StylePropertySet
to MutableStylePropertySet.
StyleRule & co now return a MutableStylePropertySet* from mutableProperties() to aid with...
CSSStyleDeclaration now only deals with MutableStylePropertySets. This was already the case
in practice, we just didn't have any compile-time foot-shooting protection.
In other words, if there's a CSSOM wrapper for a given StylePropertySet, it's guaranteed to
be mutable, and the pointer types now reflect this.
- WebCore.exp.in:
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::StyleRuleCSSStyleDeclaration::StyleRuleCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::reattach):
- css/PropertySetCSSStyleDeclaration.h:
(WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
(PropertySetCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::create):
(StyleRuleCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::ensureCSSStyleDeclaration):
(WebCore::MutableStylePropertySet::ensureInlineCSSStyleDeclaration):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- css/StyleRule.cpp:
(WebCore::StyleRule::mutableProperties):
(WebCore::StyleRulePage::mutableProperties):
(WebCore::StyleRuleFontFace::mutableProperties):
(WebCore::StyleRuleViewport::mutableProperties):
(WebCore::StyleRuleFilter::mutableProperties):
- css/StyleRule.h:
(StyleRule):
(StyleRuleFontFace):
(StyleRulePage):
(StyleRuleViewport):
(StyleRuleFilter):
- css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::mutableProperties):
- css/WebKitCSSKeyframeRule.h:
(StyleKeyframe):
- dom/Attr.cpp:
(WebCore::Attr::style):
- dom/Attr.h:
(Attr):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::copyTypingStyle):
- editing/FrameSelection.h:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
Source/WebKit/gtk:
- WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::shouldApplyStyle):
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldApplyStyle):
- WebView/WebFrame.mm:
(-[WebFrame _typingStyle]):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::shouldApplyStyle):
- 7:24 AM Changeset in webkit [148395] by
-
- 24 edits in trunk/Source/WebCore
Move create() methods from StylePropertySet to MutableStylePropertySet.
<http://webkit.org/b/114574>
Reviewed by Antti Koivisto.
Move the two create() methods that create MutableStylePropertySets from StylePropertySet
to MutableStylePropertySet, and make them actually return MutableStylePropertySets.
Switch to using {Pass,}RefPtr<MutableStylePropertySet> where appropriate to keep things building.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFaceValue):
- css/DOMWindowCSS.cpp:
(WebCore::DOMWindowCSS::supports):
- css/ElementRuleCollector.cpp:
(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):
- css/FontLoader.cpp:
(WebCore::FontLoader::resolveFontStyle):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::copyPropertiesInSet):
(WebCore::MutableStylePropertySet::create):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::resolveVariables):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- dom/Attr.cpp:
(WebCore::Attr::style):
- dom/Document.cpp:
(WebCore::Document::createCSSStyleDeclaration):
- dom/StyledElement.cpp:
(WebCore::StyledElement::ensureMutableInlineStyle):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
- editing/ApplyStyleCommand.cpp:
(WebCore::copyStyleOrCreateEmpty):
- editing/EditingStyle.cpp:
(WebCore::editingStyleFromComputedStyle):
(WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
(WebCore::EditingStyle::setProperty):
(WebCore::EditingStyle::extractAndRemoveTextDirection):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::forceInline):
- editing/Editor.cpp:
(WebCore::Editor::setBaseWritingDirection):
- editing/EditorCommand.cpp:
(WebCore::executeApplyStyle):
(WebCore::executeToggleStyleInList):
(WebCore::executeApplyParagraphStyle):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):
- html/HTMLTableElement.cpp:
(WebCore::leakBorderStyle):
(WebCore::HTMLTableElement::createSharedCellStyle):
(WebCore::leakGroupBorderStyle):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
- page/DragController.cpp:
(WebCore::DragController::concludeEditDrag):
- svg/SVGElementRareData.h:
(WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::getPresentationAttribute):
- 5:37 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:35 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:34 AM Changeset in webkit [148394] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Merge r148293 - [GTK] Lower the pango dependency
https://bugs.webkit.org/show_bug.cgi?id=114520
Reviewed by Carlos Garcia Campos.
- Source/autotools/Versions.m4: Only depend on Pango 1.30.0 instead of
Pango 1.32.0. 1.32.0 isn't strictly necessary and the version of GTK+ that
we depend on (3.6.0) depends on 1.30.0.
- 5:33 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:32 AM Changeset in webkit [148393] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Tools
Merge r147946 - [GTK] Bump gnome-themes-standard to 3.6.0
https://bugs.webkit.org/show_bug.cgi?id=114155
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-08
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
dependency of gnome-themes-standard accordingly.
- 5:32 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:31 AM Changeset in webkit [148392] by
-
- 2 edits1 add in releases/WebKitGTK/webkit-2.0/Tools
Merge r148110 - [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
https://bugs.webkit.org/show_bug.cgi?id=114365
Reviewed by Martin Robinson.
Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
The patch addresses crashes in the tally_event_reply method. It is already committed into the
at-spi2-atk source tree and will be available with the next stable release, after which the
patch should be removed and the dependency version bumped.
- gtk/jhbuild.modules:
- gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
- 5:29 AM Changeset in webkit [148391] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Tools
Merge r147574 - [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
https://bugs.webkit.org/show_bug.cgi?id=113883
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
- 5:27 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:24 AM Changeset in webkit [148390] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Tools
Merge r147547 - [GTK] Bump required versions of some dependencies
https://bugs.webkit.org/show_bug.cgi?id=113282
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-03
Reviewed by Martin Robinson.
.:
This patch updates the following dependencies:
- libsoup 2.42.0: is the current stable release.
- glib 2.36.0: libsoup 2.42 requires 2.35.0, but we don't want to depend on unstable versions and 2.36 is the next stable version after 2.35.
- gtk+ 3.6.0: this is the previous stable release. We don't currently have any code using newer API, so we will be able to remove all the #ifdefed code.
- at-spi2 2.5.3: is the version required by gtk+ 3.6.
- GObject introspection 1.32.0: is the version required by gtk+ 3.6.
- Pango 1.32.0: it's the current stable version and the first one depending on Harfbuzz.
- Fontconfig 2.5: required by pango 1.32.0 when using Harfbuzz.
- gtk+ 2.24.10: it allows us to remove a lot of deprecated code and #ifdefs.
- Source/autotools/Versions.m4:
Tools:
- gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
- 5:23 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:19 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:18 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:17 AM Changeset in webkit [148389] by
-
- 4 edits15 deletes in releases/WebKitGTK/webkit-2.0
Merge r147963 - [WIN] Remove WebKit2 source code
https://bugs.webkit.org/show_bug.cgi?id=114096
Reviewed by Anders Carlsson.
Source/WebKit2:
Remove conditional includes for the windows platform.
- Shared/API/c/WKBase.h:
- UIProcess/API/C/WKAPICast.h:
Tools:
Remove the windows specific parts of the MiniBrowser.
- MiniBrowser/MiniBrowser.vcproj: Removed.
- MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
- MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
- MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
- MiniBrowser/win/BrowserView.cpp: Removed.
- MiniBrowser/win/BrowserView.h: Removed.
- MiniBrowser/win/BrowserWindow.cpp: Removed.
- MiniBrowser/win/BrowserWindow.h: Removed.
- MiniBrowser/win/MiniBrowser.cpp: Removed.
- MiniBrowser/win/MiniBrowser.h: Removed.
- MiniBrowser/win/MiniBrowser.rc: Removed.
- MiniBrowser/win/main.cpp: Removed.
- MiniBrowser/win/resource.h: Removed.
- MiniBrowser/win/stdafx.cpp: Removed.
- MiniBrowser/win/stdafx.h: Removed.
- 5:15 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:15 AM Changeset in webkit [148388] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Tools
Merge r148230 - [GTK] Windows build failure after r136056
https://bugs.webkit.org/show_bug.cgi?id=114121
Patch by Kalev Lember <kalevlember@gmail.com> on 2013-04-11
Reviewed by Martin Robinson.
- TestWebKitAPI/config.h: Make sure defines are correct for other
Windows ports than apple-win.
- 5:14 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:13 AM Changeset in webkit [148387] by
-
- 1 edit1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r147814 - Translation of WebKitGTK+ for Malayalam (ml)
https://bugs.webkit.org/show_bug.cgi?id=113280
Patch by Ani Peter <peter.ani@gmail.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
- ml.po: Added.
- 5:11 AM Changeset in webkit [148386] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r147812 - webkit translations for gujarati
https://bugs.webkit.org/show_bug.cgi?id=113190
Patch by Sweta Kothari <swkothar@redhat.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
- gu.po:
- 4:36 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:33 AM Changeset in webkit [148385] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r147811 - [l10n] [hi] Updated WebKit Translation in Hindi [hi] language
https://bugs.webkit.org/show_bug.cgi?id=113180
Patch by Rajesh Ranjan <rajeshkajha@yahoo.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
- hi.po:
- 4:28 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:26 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:25 AM Changeset in webkit [148384] by
-
- 1 edit1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r147015 - Tamil translation for Gnome 3.6
https://bugs.webkit.org/show_bug.cgi?id=96995
Patch by Shantha kumar <shkumar@redhat.com> on 2013-03-27
Reviewed by Gustavo Noronha Silva (kov).
- ta.po: Added.
- 4:24 AM Changeset in webkit [148383] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r147003 - Updated Slovenian translation
https://bugs.webkit.org/show_bug.cgi?id=113151
Patch by Matej Urbančič <mateju@svn.gnome.org> on 2013-03-27
Reviewed by Gustavo Noronha Silva (kov).
- sl.po: translation update.
- 4:05 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:01 AM Changeset in webkit [148382] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r148286 - [GTK] Web Process crash when the UI process finishes too early
https://bugs.webkit.org/show_bug.cgi?id=112729
Reviewed by Anders Carlsson.
The problem is when creating the GSocket in the WorkQeue for the
socket descriptor. GLib considers a programmer error to create a
GSocket providing an invalid socket and finishes the process with
g_error(). We are actually providing a valid socket when creating
the GSocket, but it can be invalidated by the worker thread while
the GSocket is being created. This is because
registerEventSourceHandler is called from the main thread and
unregisterEventSourceHandler can be called from the worker
thread. We are currently registering two event handlers, one to
read data from the socket and another one to close the CoreIPC
connection when the socket connection is broken. Every event
source registered uses its own GSocket (even if the file
descriptor is actually the same), so that when the UI process
finishes too early, the first event handler can be executed in the
worker thread, closing the socket descriptor, while the main
thread is creating the GSocket for the second one.
We don't really need to use a separate event handler to monitor
the connection, because GSocket always notifies when condition is
G_IO_HUP and G_IO_ERR even if they haven't been explicitly set in
g_socket_create_source(). We can register socket event sources
differently, providing also a function to be called when the
connection is closed, using a single socket and the same even source.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::open): Register a single socket event
handler providing also a function to be called when the connection
is closed.
- Platform/WorkQueue.h:
(WorkQueue):
- Platform/gtk/WorkQueueGtk.cpp: The EventSource class has been
split, moving everyting specific to socket event source to a
derived class SocketEventSource.
(WorkQueue::EventSource::EventSource):
(WorkQueue::EventSource::performWork):
(WorkQueue::EventSource::performWorkOnce):
(WorkQueue::EventSource::performWorkOnTermination):
(WorkQueue::EventSource::deleteEventSource):
(WorkQueue::EventSource):
(WorkQueue::SocketEventSource):
(WorkQueue::SocketEventSource::SocketEventSource):
(WorkQueue::SocketEventSource::cancel):
(WorkQueue::SocketEventSource::didClose):
(WorkQueue::SocketEventSource::checkCondition):
(WorkQueue::SocketEventSource::eventCallback):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatchOnSource):
- 1:10 AM Changeset in webkit [148381] by
-
- 11 edits in trunk/Source
Source/WebKit/efl: Unreviewed build fix for WebKit1 EFL after r148373 due to missing
header includes.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/EditorClientEfl.cpp:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
- WebCoreSupport/InspectorClientEfl.cpp:
- ewk/ewk_frame.cpp:
- ewk/ewk_view.cpp:
- ewk/ewk_view_private.h:
(WebCore):
Source/WebKit2: Unreviewed build fix for WebKit2 EFL after r148373 due to missing
header includes.
- UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
- UIProcess/efl/InputMethodContextEfl.cpp:
Apr 13, 2013:
- 9:13 PM Changeset in webkit [148380] by
-
- 2 edits in trunk/Source/WebCore
Fix three crashes seen on the bots after "Make Frame's ScriptController an OwnPtr and remove the #include"
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
Check that the frame is not null (as it can be in cases like http/tests/xmlhttprequest/detaching-frame-2.html).
We used to be getting lucky, in that shouldBypassMainWorldContentSecurityPolicy(), the function that is ultimately
called, only operates on global state. Now that we need to actually dereference the Frame to get the ScriptController,
we see this crash.
- 9:06 PM Changeset in webkit [148379] by
-
- 2 edits in trunk/Tools
Build fix attempt for webkitbot. Unicodify everything.
- Scripts/webkitpy/tool/bot/irc_command.py:
(Whois.execute):
- 8:55 PM Changeset in webkit [148378] by
-
- 3 edits2 adds in trunk
Selection direction is not preserved when applying styles
https://bugs.webkit.org/show_bug.cgi?id=110979
Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2013-04-13
Reviewed by Ryosuke Niwa.
Source/WebCore:
The patch is based on the one submitted by Shezan Baig.
If the starting selection was directional and its base was not first,
switch newStart and newEnd when setting the ending direction. Otherwise,
leave the order unchanged.
Test: editing/style/preserve-selection-direction.html
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::updateStartEnd):
LayoutTests:
Add a test, based on the work by Shezan Baig
- editing/style/preserve-selection-direction-expected.txt: Added.
- editing/style/preserve-selection-direction.html: Added.
- 8:02 PM Changeset in webkit [148377] by
-
- 2 edits in trunk/Source/WebCore
Added svn:ignore for inspector/CodeGeneratorInspectorStrings.pyc
- inspector: Added property svn:ignore.
- 7:12 PM Changeset in webkit [148376] by
-
- 5 edits in trunk/Source/WebKit2
Add ObjC API for setting initialization data for the WKWebProcessPlugIn
https://bugs.webkit.org/show_bug.cgi?id=103846
Reviewed by Darin Adler.
- UIProcess/API/mac/WKProcessGroup.h:
Adds a new optional processGroupWillCreateConnectionToWebProcessPlugIn: method for the WKProcessGroupDelegate protocol,
which allows the user to pass (via an autoreleased return value) initialization data to the web process plugin.
- UIProcess/API/mac/WKProcessGroup.mm:
(getInjectedBundleInitializationUserData):
(setUpInectedBundleClient):
(-[WKProcessGroup initWithInjectedBundleURL:]):
(-[WKProcessGroup dealloc]):
Use the existing WKContextInjectedBundleClient infrastructure to pass the initialization data to the bundle
via the new ObjCObjectGraph APIObject.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
Adds webProcessPlugIn:initializeWithObject: to the WKWebProcessPlugIn protocol, replacing webProcessPlugInInitialize:.
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::load):
Pass the initialization data to the web process plugin.
- 7:00 PM Changeset in webkit [148375] by
-
- 2 edits in branches/safari-536.30-branch/Source/JavaScriptCore
Attempt to fix Windows build after r148370
Try to fix the following build failure:
4>JSStringJoiner.cpp
4>..\..\runtime\JSStringJoiner.cpp(112) : error C2653: 'CheckedState' : is not a class or namespace name
4>..\..\runtime\JSStringJoiner.cpp(112) : error C2065: 'DidOverflow' : undeclared identifier
4>..\..\runtime\JSStringJoiner.cpp(112) : warning C4805: '==' : unsafe mix of type 'bool' and type unknown-type in operation
- runtime/JSStringJoiner.h: Include <wtf/CheckedArithmetic.h>.
- 6:27 PM Changeset in webkit [148374] by
-
- 2 edits in trunk/Source/WebKit2
Attempt Build Fix.
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
- 5:54 PM Changeset in webkit [148373] by
-
- 88 edits in trunk/Source
Make Frame's ScriptController an OwnPtr and remove the #include
https://bugs.webkit.org/show_bug.cgi?id=114105
Reviewed by Dean Jackson.
Source/WebCore:
- Modules/websockets/WebSocket.cpp:
- bindings/generic/BindingSecurity.cpp:
- bindings/js/JSEventListener.cpp:
- bindings/js/JSLazyEventListener.cpp:
- bindings/js/PageScriptDebugServer.cpp:
- bindings/js/ScriptEventListener.cpp:
- bindings/js/ScriptState.cpp:
- bindings/objc/DOM.mm:
- bindings/objc/DOMAbstractView.mm:
- bindings/objc/DOMInternal.mm:
- dom/DocumentStyleSheetCollection.cpp:
- dom/EventTarget.cpp:
- dom/ScriptElement.cpp:
- history/CachedFrame.cpp:
- html/HTMLCanvasElement.cpp:
- html/HTMLDocument.cpp:
- html/HTMLElement.cpp:
- html/HTMLFormElement.cpp:
- html/HTMLPlugInElement.cpp:
- html/HTMLPlugInImageElement.cpp:
- html/parser/HTMLParserOptions.cpp:
- inspector/InspectorAgent.cpp:
- inspector/InspectorController.cpp:
- inspector/InspectorFrontendClientLocal.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorOverlay.cpp:
- inspector/InspectorPageAgent.cpp:
- inspector/PageRuntimeAgent.cpp:
- loader/DocumentWriter.cpp:
- loader/NavigationScheduler.cpp:
- loader/SubframeLoader.cpp:
- loader/cache/CachedResourceLoader.cpp:
- page/DOMWindow.cpp:
- page/EventSource.cpp:
- page/Frame.cpp:
- page/Frame.h:
- page/Navigator.cpp:
- page/Page.cpp:
- page/PageGroup.cpp:
- xml/XMLHttpRequest.cpp:
- xml/XMLTreeViewer.cpp:
Source/WebKit/mac:
- Plugins/Hosted/HostedNetscapePluginStream.mm:
- Plugins/WebNetscapePluginStream.mm:
- Plugins/WebPluginContainerCheck.mm:
- WebCoreSupport/WebGeolocationClient.mm:
- WebCoreSupport/WebInspectorClient.mm:
- WebView/WebFrame.mm:
Source/WebKit2:
- Shared/WebHitTestResult.cpp:
- Shared/WebHitTestResult.h:
- UIProcess/Plugins/PlugInAutoStartProvider.cpp:
- UIProcess/WebContext.h:
- UIProcess/WebPageProxy.h:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/Storage/StorageAreaImpl.cpp:
- WebProcess/Storage/StorageAreaMap.cpp:
- WebProcess/WebPage/WebFrame.cpp:
- WebProcess/WebPage/WebPage.cpp:
- 5:46 PM Changeset in webkit [148372] by
-
- 5 edits in trunk/Tools
webkitbot should provide full name, email address, and IRC nicknames on whois
https://bugs.webkit.org/show_bug.cgi?id=114494
Reviewed by Benjamin Poulain.
A response like the one below is useless. Improve it:
webkitbot: rniwa: zdobersek is zdobersek (zandobersek@gmail.com). Why do you ask?
We now report full name, email address, committer/reviewer status, and IRC nickname.
Also teach webkitbot how to respond to ping.
- Scripts/webkitpy/tool/bot/irc_command.py:
(PingPong): Moved
(PingPong.execute):
(Whois._full_record_and_nick): Renamed and rewritten.
(Whois.execute):
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois): Updated test cases as needed.
- Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help): Added ping.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot): Teached WKR how to respond to hi.
- 5:28 PM Changeset in webkit [148371] by
-
- 5 edits in trunk/Websites/bugs.webkit.org
Delete bubbles from webkit-commit-queue.appspot.com now that we've completed the transition
https://bugs.webkit.org/show_bug.cgi?id=114476
Reviewed by Gyuyoung Kim.
- code-review.js:
- template/en/custom/attachment/edit.html.tmpl:
- template/en/custom/attachment/list.html.tmpl:
- template/en/custom/attachment/reviewform.html.tmpl:
- 4:15 PM Changeset in webkit [148370] by
-
- 7 edits in branches/safari-536.30-branch
Merge 145580, 145587, 145594, r145595, r145647, 145759. Part 2/2 for <rdar://problem/13438603>.
- 4:15 PM Changeset in webkit [148369] by
-
- 2 edits1 add in branches/safari-536.30-branch/Source/WTF
Merge r141499, r141950, r141965. Part 1/2 for <rdar://problem/13438603>.
Add Source/WTF/wtf/EnumClass.h
- 3:28 PM Changeset in webkit [148368] by
-
- 14 edits1 add in trunk
Add form delegate method that's invoked right before sending a submit event to a form element
https://bugs.webkit.org/show_bug.cgi?id=114575
Reviewed by Dan Bernstein.
Source/WebCore:
- WebCore.exp.in:
Export a symbol.
- WebCore.xcodeproj/project.pbxproj:
Make DOMHTMLFormElementInternal.h a private header.
Source/WebKit/mac:
- MigrateHeaders.make:
Copy DOMHTMLFormElementInternal.h over to WebKit.
- WebCoreSupport/WebFrameLoaderClient.mm:
(makeFormFieldValuesDictionary):
New helper function that returns the values of a form in dictionary form.
(WebFrameLoaderClient::dispatchWillSendSubmitEvent):
Call the right delegate method.
(WebFrameLoaderClient::dispatchWillSubmitForm):
Use the helper function.
- WebView/WebDelegateImplementationCaching.h:
- WebView/WebDelegateImplementationCaching.mm:
(CallFormDelegate):
Add another overload.
- WebView/WebFormDelegate.h:
- WebView/WebFormDelegate.m:
(-[WebFormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
Add a default implementation.
Tools:
Add a test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm: Added.
(-[FormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):
- TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::toSTD):
Don't crash when a null NSString is passed to toSTD.
- 3:01 PM Changeset in webkit [148367] by
-
- 3 edits4 adds in trunk
Whitespace between nowrap elements ignored after collapsed trailing space in a text run
https://bugs.webkit.org/show_bug.cgi?id=17705
Reviewed by Ryosuke Niwa.
Source/WebCore:
Bug 93448 and r138654 fixed the treatment of line-breaks between nowrap elements. This augments
that fix by recognizing that we have a potential break not only in situations where the next character is a
space and the current character is not, but also where the next character is a space and the current character
*is* a space *and* we are ignoring spaces. This is so because any spaces we have ignored up to this point
after the actual word end will get collapsed away even if we don't end up taking the line break.
In a nutshell, if we allow whitespace collapsing 'word ' and 'word' are equivalent when before a whitespace
character, so treat the first as well as the second as a potential linebreak.
Test: fast/text/whitespace/inline-whitespace-wrapping-5.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/text/whitespace/inline-whitespace-wrapping-5-expected.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-5.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-6-expected.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-6.html: Added.
- 2:49 PM Changeset in webkit [148366] by
-
- 4 edits3 copies in branches/safari-536.30-branch
Merged r136845. <rdar://problem/13334927>
- 2:11 PM QtWebKit edited by
- Add QupZilla Web Browser which also uses QtWebKit (diff)
- 1:03 PM Changeset in webkit [148365] by
-
- 19 edits in trunk/Source
Rename/tweak some StylePropertySet/CSSStyleDeclaration copying functions.
<http://webkit.org/b/114569>
Reviewed by Anders Carlsson.
- StylePropertySet::copy() -> mutableCopy()
This function now returns a MutableStylePropertySet, and this is also reflected in the name.
- CSSStyleDeclaration::copy() -> copyProperties()
Renamed to reflect that it's the properties being copied, not the CSSStyleDeclaration.
They also now return MutableStylePropertySets.
- StylePropertySet::copyPropertiesInSet()
- CSSStyleDeclaration::copyPropertiesInSet()
These functions now return MutableStylePropertySets.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyProperties):
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
- css/CSSComputedStyleDeclaration.h:
(CSSComputedStyleDeclaration):
- css/CSSStyleDeclaration.h:
(CSSStyleDeclaration):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::copyProperties):
- css/PropertySetCSSStyleDeclaration.h:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::mutableCopy):
(WebCore::StylePropertySet::copyPropertiesInSet):
- css/StylePropertySet.h:
(StylePropertySet):
- css/StyleRule.cpp:
(WebCore::StyleRule::StyleRule):
(WebCore::StyleRule::mutableProperties):
(WebCore::StyleRulePage::StyleRulePage):
(WebCore::StyleRulePage::mutableProperties):
(WebCore::StyleRuleFontFace::StyleRuleFontFace):
(WebCore::StyleRuleFontFace::mutableProperties):
(WebCore::StyleRuleViewport::StyleRuleViewport):
(WebCore::StyleRuleViewport::mutableProperties):
(WebCore::StyleRuleFilter::StyleRuleFilter):
(WebCore::StyleRuleFilter::mutableProperties):
- css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::addViewportRule):
- css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::mutableProperties):
- dom/Element.cpp:
(WebCore::UniqueElementData::UniqueElementData):
- dom/StyledElement.cpp:
(WebCore::StyledElement::ensureMutableInlineStyle):
- editing/ApplyStyleCommand.cpp:
(WebCore::copyStyleOrCreateEmpty):
- editing/EditingStyle.cpp:
(WebCore::copyEditingProperties):
(WebCore::editingStyleFromComputedStyle):
(WebCore::EditingStyle::EditingStyle):
(WebCore::EditingStyle::init):
(WebCore::EditingStyle::copy):
(WebCore::EditingStyle::mergeStyle):
(WebCore::getPropertiesNotIn):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::copyTypingStyle):
- 11:19 AM Changeset in webkit [148364] by
-
- 8 edits in branches/safari-536.30-branch/Source/WebKit2
Merged r147512. <rdar://problem/13380323>
- 11:00 AM Changeset in webkit [148363] by
-
- 11 edits2 moves in trunk/Source/WebCore
Rename StyleBuilder to DeprecatedStyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=114532
Reviewed by Benjamin Poulain.
The StyleBuilder code is hard to read and maintain. People should
not add new properties to this class. To make this clear, this
patch renames the class to DeprecatedStyleBuilder.
Pure refactoring, no change in functionality.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/DeprecatedStyleBuilder.cpp: Renamed from Source/WebCore/css/StyleBuilder.cpp.
- css/DeprecatedStyleBuilder.h: Renamed from Source/WebCore/css/StyleBuilder.h.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::reportMemoryUsage):
- css/StyleResolver.h:
(StyleResolver):
- rendering/style/RenderStyle.h:
- 10:56 AM Changeset in webkit [148362] by
-
- 2 edits in trunk/Tools
Python test fix attempt after r148360.
- Scripts/webkitpy/tool/multicommandtool_unittest.py:
(test_command_help):
- 10:53 AM Changeset in webkit [148361] by
-
- 2 edits in trunk/LayoutTests
Update Mac WebKit2 test expectations for flaky and failing tests.
- platform/mac-wk2/TestExpectations:
- 10:39 AM Changeset in webkit [148360] by
-
- 19 edits in trunk/Tools
Merge AbstractDeclarativeCommand into Command as a comment suggests
https://bugs.webkit.org/show_bug.cgi?id=114559
Reviewed by Antti Koivisto.
Merged two classes as the comment right above AbstractDeclarativeCommand suggested.
We need to merge a lot more classes to make webkitpy hackable.
- Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
(AbstractLocalServerCommand):
(AbstractLocalServerCommand.init):
- Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
(AbstractSequencedCommand):
(AbstractSequencedCommand.init):
- Scripts/webkitpy/tool/commands/adduserstogroups.py:
(AddUsersToGroups):
- Scripts/webkitpy/tool/commands/analyzechangelog.py:
(AnalyzeChangeLog):
(AnalyzeChangeLog.init):
- Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
- Scripts/webkitpy/tool/commands/bugfortest.py:
(BugForTest):
- Scripts/webkitpy/tool/commands/bugsearch.py:
(BugSearch):
- Scripts/webkitpy/tool/commands/chromechannels.py:
(ChromeChannels):
(init):
- Scripts/webkitpy/tool/commands/download.py:
(AbstractPatchProcessingCommand):
- Scripts/webkitpy/tool/commands/findusers.py:
(FindUsers):
- Scripts/webkitpy/tool/commands/openbugs.py:
(OpenBugs):
- Scripts/webkitpy/tool/commands/queries.py:
(BugsToCommit):
(PatchesInCommitQueue):
(PatchesToCommitQueue):
(PatchesToCommitQueue.init):
(PatchesToReview):
(PatchesToReview.init):
(PatchesToReview.execute):
(WhatBroke):
(ResultsFor):
(FailureReason):
(FindFlakyTests):
(TreeStatus):
(CrashLog):
(PrintExpectations):
(PrintExpectations.init):
(PrintBaselines):
(PrintBaselines.init):
- Scripts/webkitpy/tool/commands/queues.py:
(AbstractQueue.init):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand):
- Scripts/webkitpy/tool/commands/suggestnominations.py:
(SuggestNominations):
(SuggestNominations.init):
- Scripts/webkitpy/tool/commands/upload.py:
(CommitMessageForCurrentDiff):
(CommitMessageForCurrentDiff.init):
(CleanPendingCommit):
(CleanReviewQueue):
(AssignToCommitter):
(PostCommits):
(PostCommits.init):
(MarkBugFixed):
(MarkBugFixed.init):
(CreateBug):
(CreateBug.init):
- Scripts/webkitpy/tool/multicommandtool.py:
(Command):
(Command.init):
(Command.main):
(HelpCommand):
(HelpCommand.init):
- Scripts/webkitpy/tool/multicommandtool_unittest.py:
(TrivialCommand):
(TrivialCommand.init):
(LikesToRetry):
(LikesToRetry.init):
(CommandTest.test_name_with_arguments):
(CommandTest.test_required_arguments):
(test_command_help):
- 9:43 AM Changeset in webkit [148359] by
-
- 6 edits in trunk/Source/WebCore
Remove unused method CSSStyleDeclaration::makeMutable().
<http://webkit.org/b/114567>
Reviewed by Anders Carlsson.
- css/CSSComputedStyleDeclaration.cpp:
- css/CSSComputedStyleDeclaration.h:
(CSSComputedStyleDeclaration):
- css/CSSStyleDeclaration.h:
(CSSStyleDeclaration):
- css/PropertySetCSSStyleDeclaration.cpp:
- css/PropertySetCSSStyleDeclaration.h:
- 9:38 AM Changeset in webkit [148358] by
-
- 3 edits2 adds in trunk
Width of last of consecutive tabs may be incorrect with "white-space: pre-wrap"
https://bugs.webkit.org/show_bug.cgi?id=114562
Reviewed by Dan Bernstein.
Source/WebCore:
When we measure the last word of a RenderText, make sure we use the correct x
position taking into account the current accumulated word measurements up to
this character. This is of particular importance in the case of tabs where the
measured width would differ based on the x position.
Test: fast/text/tab-last-word-in-renderer-pre-wrap.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun):
LayoutTests:
- fast/text/tab-last-word-in-renderer-pre-wrap-expected.html: Added.
- fast/text/tab-last-word-in-renderer-pre-wrap.html: Added.
- 9:07 AM Changeset in webkit [148357] by
-
- 2 edits in trunk/Source/WebCore
[Windows, WinCairo] ImageBufferCairo.cpp fails to compile after 148247, 148264.
https://bugs.webkit.org/show_bug.cgi?id=114540
Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-04-13
Reviewed by Brent Fulgham.
- platform/graphics/cairo/ImageBufferCairo.cpp:
- 7:09 AM Changeset in webkit [148356] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add missing export macro to SymbolTableEntry::freeFatEntrySlow()
- runtime/SymbolTable.h:
(SymbolTableEntry):
- 5:04 AM Changeset in webkit [148355] by
-
- 5 edits in trunk
[EFL] --minimal build fails with error: 'ViewModeInvalid' is not a member of 'WebCore::Page'
https://bugs.webkit.org/show_bug.cgi?id=114048
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-13
Reviewed by Gyuyoung Kim.
Source/WebKit/efl:
Wrapped view-mode media related code into #if ENABLE(VIEW_MODE_CSS_MEDIA)
- WebCoreSupport/AssertMatchingEnums.cpp:
- ewk/ewk_view.cpp:
(ewk_view_mode_set):
Tools:
Wrapped view media related code in #if ENABLE(VIEW_MODE_CSS_MEDIA)
- DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::setViewModeMediaFeature):
- 2:47 AM Changeset in webkit [148354] by
-
- 2 edits2 deletes in trunk/Tools
Merge watchlistloader into host since it's an unnecessary indirection
https://bugs.webkit.org/show_bug.cgi?id=114555
Reviewed by Antti Koivisto.
We don't need a class to load a file.
- Scripts/webkitpy/common/host.py:
(Host.watch_list):
- Scripts/webkitpy/common/watchlist/watchlistloader.py: Removed.
- Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Removed.
- 1:16 AM Changeset in webkit [148353] by
-
- 4 edits in trunk/Tools
Rename JSONResultsGeneratorBase to JSONResultsGenerator
https://bugs.webkit.org/show_bug.cgi?id=114553
Reviewed by Philippe Normand.
Renamed now that we've got rid of the old JSONResultsGenerator in r148352.
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator):
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGenerator):
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
(JSONGeneratorTest._test_json_generation):
(JSONGeneratorTest._verify_json_results):
- 1:02 AM Changeset in webkit [148352] by
-
- 8 edits in trunk/Tools
Remove more Chromium specific code from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=114552
Reviewed by Philippe Normand.
- Scripts/webkitpy/common/host.py:
(Host.checkout):
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGeneratorBase):
(JSONResultsGeneratorBase.init):
(JSONResultsGeneratorBase._is_results_all_of_type):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port):
(Port.expected_filename):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
- Scripts/webkitpy/tool/commands/queues.py:
(PatchProcessingQueue._new_port_name_from_old):
(CommitQueue.did_pass_testing_ews):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._results_url):
(Rebaseline._builder_with_name):
- Scripts/webkitpy/tool/mocktool.py:
(MockTool.irc):
- 12:56 AM Changeset in webkit [148351] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix after r148311.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(resizeWebKitWebViewBaseFromAllocation): Passing IntSize() as the scroll offset
argument to the DrawingAreaProxy::setSize method.
- 12:53 AM Changeset in webkit [148350] by
-
- 4 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Fix release build.
- dfg/DFGOSRExitCompilerCommon.cpp:
- ftl/FTLExitValue.cpp:
- ftl/FTLOSRExitCompiler.cpp:
- 12:40 AM Changeset in webkit [148349] by
-
- 3 edits in trunk/Tools
Fix flakiness dashboard unit test failures
https://bugs.webkit.org/show_bug.cgi?id=114518
Reviewed by Ryosuke Niwa.
Fix the current failures in unit tests for the flakiness dashboard by adjusting failing
test cases to simulate loading the builders list from the webkit.org build master, replacing
the Chromium builders and platforms that are used in tests with builders and platforms for the
Apple Mac Lion WebKit2 port, and removing two test cases that were testing Chromium-specific
functionality of the dashboard.
This is sort of an interlude to the flakiness dashboard cleanup, with the removal of Chromium-specific
code and hopefully general simplification of the dashboard codebase coming in near future.
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(resetGlobals):
(test):
- TestResultServer/static-dashboards/loader_unittests.js:
- 12:38 AM Changeset in webkit [148348] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed GTK build fix after r148305.
- GNUmakefile.list.am: Adding the TrackListBase build targets to the build.
- 12:38 AM Changeset in webkit [148347] by
-
- 35 edits26 adds in branches/dfgFourthTier/Source
fourthTier: FTL should have OSR exit
https://bugs.webkit.org/show_bug.cgi?id=113623
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
This implements OSR exit, and hilariously, it actually works. The idea is to have
LLVM call a no-return function on the off-ramp, passing it everything we know about
bytecode state that isn't already flushed to the call frame. Our own JIT takes care
of the rest.
We can now run all of SunSpider, V8, and Kraken with the FTL enabled.
The details are described in FTLOSRExit.h.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- assembler/AbstractMacroAssembler.h:
(Address):
(JSC::AbstractMacroAssembler::Address::withOffset):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::offsetOf):
(LinkBuffer):
- assembler/MacroAssemblerX86Common.h:
- assembler/RepatchBuffer.h:
(JSC::RepatchBuffer::RepatchBuffer):
(JSC::RepatchBuffer::~RepatchBuffer):
(RepatchBuffer):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::tallyFrequentExitSites):
- bytecode/Operands.h:
(Operands):
(JSC):
(JSC::::dump):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
- dfg/DFGGPRInfo.h:
(DFG):
(GPRInfo):
- dfg/DFGMinifiedNode.h:
(JSC::DFG::belongsInMinifiedGraph):
- dfg/DFGNodeType.h:
(JSC::DFG::needsOSRBackwardRewiring):
(DFG):
(JSC::DFG::needsOSRForwardRewiring):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
(DFG):
(JSC::DFG::OSRExit::convertToForward):
- dfg/DFGOSRExit.h:
(OSRExit):
- dfg/DFGOSRExitBase.cpp: Added.
(DFG):
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):
(JSC::DFG::OSRExitBase::doSearchForForwardConversion):
- dfg/DFGOSRExitBase.h: Added.
(DFG):
(JSC::DFG::OSRExitBase::OSRExitBase):
(OSRExitBase):
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSite):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::handleExitCounts):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
- dfg/DFGOSRExitCompilerCommon.h:
(DFG):
- dfg/DFGOSRExitPreparation.cpp: Added.
(DFG):
(JSC::DFG::prepareCodeOriginForOSRExit):
- dfg/DFGOSRExitPreparation.h: Added.
(DFG):
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
- dfg/DFGValueSource.h:
(JSC::DFG::ValueSource::forSpeculation):
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
- ftl/FTLAbbreviations.h:
(JSC::FTL::functionType):
(FTL):
(JSC::FTL::typeOf):
(JSC::FTL::appendBasicBlock):
(JSC::FTL::insertBasicBlock):
(JSC::FTL::buildCall):
(JSC::FTL::setTailCall):
- ftl/FTLCArgumentGetter.cpp: Added.
(FTL):
(JSC::FTL::CArgumentGetter::loadNextAndBox):
- ftl/FTLCArgumentGetter.h: Added.
(FTL):
(JSC::FTL::isArgumentRegister):
(CArgumentGetter):
(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):
(JSC::FTL::CArgumentGetter::nextAddress):
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLExitArgument.cpp: Added.
(FTL):
(JSC::FTL::ExitArgument::dump):
- ftl/FTLExitArgument.h: Added.
(FTL):
(ExitArgumentRepresentation):
(ExitArgument):
(JSC::FTL::ExitArgument::ExitArgument):
(JSC::FTL::ExitArgument::operator!):
(JSC::FTL::ExitArgument::format):
(JSC::FTL::ExitArgument::argument):
(JSC::FTL::ExitArgument::withFormat):
(JSC::FTL::ExitArgument::representation):
- ftl/FTLExitArgumentForOperand.cpp: Added.
(FTL):
(JSC::FTL::ExitArgumentForOperand::dump):
- ftl/FTLExitArgumentForOperand.h: Added.
(FTL):
(ExitArgumentForOperand):
(JSC::FTL::ExitArgumentForOperand::ExitArgumentForOperand):
(JSC::FTL::ExitArgumentForOperand::operator!):
(JSC::FTL::ExitArgumentForOperand::exitArgument):
(JSC::FTL::ExitArgumentForOperand::operand):
(JSC::FTL::lesserArgumentIndex):
- ftl/FTLExitArgumentList.h: Added.
(FTL):
- ftl/FTLExitThunkGenerator.cpp: Added.
(FTL):
(JSC::FTL::ExitThunkGenerator::ExitThunkGenerator):
(JSC::FTL::ExitThunkGenerator::~ExitThunkGenerator):
(JSC::FTL::ExitThunkGenerator::emitThunk):
- ftl/FTLExitThunkGenerator.h: Added.
(FTL):
(ExitThunkGenerator):
(JSC::FTL::ExitThunkGenerator::didThings):
- ftl/FTLExitValue.cpp: Added.
(FTL):
(JSC::FTL::ExitValue::dump):
- ftl/FTLExitValue.h: Added.
(FTL):
(ExitValue):
(JSC::FTL::ExitValue::ExitValue):
(JSC::FTL::ExitValue::operator!):
(JSC::FTL::ExitValue::dead):
(JSC::FTL::ExitValue::inJSStack):
(JSC::FTL::ExitValue::inJSStackAsInt32):
(JSC::FTL::ExitValue::inJSStackAsDouble):
(JSC::FTL::ExitValue::constant):
(JSC::FTL::ExitValue::exitArgument):
(JSC::FTL::ExitValue::kind):
(JSC::FTL::ExitValue::isDead):
(JSC::FTL::ExitValue::isInJSStackSomehow):
(JSC::FTL::ExitValue::isConstant):
(JSC::FTL::ExitValue::isArgument):
- ftl/FTLFormattedValue.h:
(FTL):
(JSC::FTL::noValue):
(JSC::FTL::int32Value):
(JSC::FTL::uInt32Value):
(JSC::FTL::booleanValue):
(JSC::FTL::jsValueValue):
(JSC::FTL::doubleValue):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::initializeExitThunks):
(FTL):
(JSC::FTL::JITCode::exitThunks):
- ftl/FTLJITCode.h:
(JITCode):
- ftl/FTLLowerDFGToLLVM.cpp:
(FTL):
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::transferAndCheckArguments):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileMovHint):
(JSC::FTL::LowerDFGToLLVM::compileZombieHint):
(JSC::FTL::LowerDFGToLLVM::compileMovHintAndCheck):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructure):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::speculateBackward):
(JSC::FTL::LowerDFGToLLVM::speculateForward):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::terminate):
(JSC::FTL::LowerDFGToLLVM::backwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::forwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::typeCheck):
(JSC::FTL::LowerDFGToLLVM::appendTypeCheck):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::isLive):
(JSC::FTL::LowerDFGToLLVM::use):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::tryToSetConstantExitArgument):
(JSC::FTL::LowerDFGToLLVM::addExitArgument):
(JSC::FTL::LowerDFGToLLVM::linkOSRExitsAndCompleteInitializationBlocks):
(JSC::FTL::LowerDFGToLLVM::observeMovHint):
- ftl/FTLOSRExit.cpp: Added.
(FTL):
(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::codeLocationForRepatch):
(JSC::FTL::OSRExit::convertToForward):
- ftl/FTLOSRExit.h: Added.
(FTL):
(OSRExit):
- ftl/FTLOSRExitCompilationInfo.h: Added.
(FTL):
(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):
(OSRExitCompilationInfo):
- ftl/FTLOSRExitCompiler.cpp: Added.
(FTL):
(JSC::FTL::compileStub):
(JSC::FTL::compileFTLOSRExit):
- ftl/FTLOSRExitCompiler.h: Added.
(FTL):
- ftl/FTLOutput.h:
(JSC::FTL::Output::newBlock):
(JSC::FTL::Output::intToPtr):
(JSC::FTL::Output::load):
(JSC::FTL::Output::store):
(Output):
(JSC::FTL::Output::call):
(JSC::FTL::Output::convertToTailCall):
(FTL):
- ftl/FTLState.h:
(State):
- ftl/FTLThunks.cpp: Added.
(FTL):
(JSC::FTL::osrExitGenerationThunkGenerator):
- ftl/FTLThunks.h: Added.
(JSC):
(FTL):
- ftl/FTLValueFormat.cpp: Added.
(WTF):
(WTF::printInternal):
- ftl/FTLValueFormat.h: Added.
(FTL):
(WTF):
- ftl/FTLValueSource.cpp: Added.
(FTL):
(JSC::FTL::ValueSource::dump):
- ftl/FTLValueSource.h: Added.
(FTL):
(ValueSource):
(JSC::FTL::ValueSource::ValueSource):
(JSC::FTL::ValueSource::kind):
(JSC::FTL::ValueSource::operator!):
(JSC::FTL::ValueSource::node):
Source/WTF:
Reviewed by Oliver Hunt.
Finally make toCString() somewhat variadic.
- wtf/StringPrintStream.h:
(WTF):
(WTF::toCString):
Apr 12, 2013:
- 9:39 PM Changeset in webkit [148346] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebKit2
Merged r148284. <rdar://problem/13335003>
- 9:23 PM Changeset in webkit [148345] by
-
- 3 edits in branches/safari-536.30-branch/Source/WebCore
Merged 140893. <rdar://problem/13334946>
- 9:18 PM Changeset in webkit [148344] by
-
- 5 edits in branches/safari-536.30-branch/Source/WebCore
Merged r141315. <rdar://problem/13334946>
- 9:15 PM Changeset in webkit [148343] by
-
- 4 edits in branches/safari-536.30-branch/Source/WebCore
Merged r140886. <rdar://problem/13334946>
- 8:52 PM Changeset in webkit [148342] by
-
- 8 edits in branches/safari-536.30-branch/Source/WebCore
Merged r140892. <rdar://problem/13334946>
- 8:15 PM Changeset in webkit [148341] by
-
- 4 edits in branches/safari-536.30-branch/Source/WebCore
Merged r140891. <rdar://problem/13334946>
- 8:09 PM Changeset in webkit [148340] by
-
- 9 edits2 copies in branches/safari-536.30-branch
Merged r140748. <rdar://problem/13334946>
- 7:38 PM Changeset in webkit [148339] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebKit2
Merged r141445. <rdar://problem/13266396>
- 7:32 PM Changeset in webkit [148338] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebKit2
Merged r141445. <rdar://problem/13335003>
- 7:08 PM Changeset in webkit [148337] by
-
- 1 edit2 copies in branches/safari-536.30-branch/LayoutTests
Merged r136596. <rdar://problem/13334868>
- 7:02 PM Changeset in webkit [148336] by
-
- 2 edits6 copies in branches/safari-536.30-branch/LayoutTests
Merged r133701. <rdar://problem/13334976>
- 7:00 PM Changeset in webkit [148335] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebCore
Merged r129814. <rdar://problem/13334978>
- 6:52 PM Changeset in webkit [148334] by
-
- 5 edits in branches/safari-536.30-branch/LayoutTests
Merged r128747. <rdar://problem/13266379>
- 6:47 PM Changeset in webkit [148333] by
-
- 3 edits in branches/safari-536.30-branch/LayoutTests
Merged r123167. <rdar://problem/13266379>
- 6:44 PM Changeset in webkit [148332] by
-
- 3 edits in branches/safari-536.30-branch/Source/WebCore
Merged r143565, <rdar://problem/13334867>
- 6:37 PM Changeset in webkit [148331] by
-
- 7 edits in trunk/Source/WebKit2
Add private interface to WKView to asynchronously update the drawing area size
https://bugs.webkit.org/show_bug.cgi?id=114549
Reviewed by Simon Fraser.
This will allow a client using the WKView to resize the contents without blocking waiting for the web process to repaint.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setDrawingAreaSize:]):
- if the new size of teh drawing area does not match the frame size, position it according to the contentAnchor.
(-[WKView updateLayer]):
- Don't let a subsequent frame size change block on a prior async resize.
(-[WKView forceAsyncDrawingAreaSizeUpdate:]):
- resize the drawing area asynchronously, even if frame size udpates are disabled.
(-[WKView waitForAsyncDrawingAreaSizeUpdate]):
- wait for asynchronous updates to complete.
- UIProcess/API/mac/WKViewPrivate.h:
- declare new methods.
- UIProcess/DrawingAreaProxy.cpp:
(WebKit):
- UIProcess/DrawingAreaProxy.h:
(DrawingAreaProxy):
(WebKit::DrawingAreaProxy::waitForPossibleGeometryUpdate):
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
(TiledCoreAnimationDrawingAreaProxy):
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForPossibleGeometryUpdate):
- pass timeout for waitForPossibleGeometryUpdate as a parameter.
- 6:25 PM Changeset in webkit [148330] by
-
- 2 edits in trunk/Source/WebKit2
32-bit build fix.
- UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
- 6:09 PM Changeset in webkit [148329] by
-
- 8 edits in trunk
Query directly for cache partition names
https://bugs.webkit.org/show_bug.cgi?id=114538
Reviewed by David Kilzer.
Source/WebKit2:
Call back into WebKitSystemInterface to ask it for the cache
partition names instead of trying to figure them out.
- WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::getCacheOrigins):
(WebKit):
(WebKit::WebResourceCacheManager::returnCacheOrigins):
- WebProcess/ResourceCache/WebResourceCacheManager.h:
(WebResourceCacheManager):
- WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
(WebKit::WebResourceCacheManager::cfURLCacheHostNames):
(WebKit):
(WebKit::WebResourceCacheManager::cfURLCacheHostNamesWithCallback):
WebKitLibraries:
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 6:02 PM Changeset in webkit [148328] by
-
- 2 edits in trunk/Tools
BUILD FIX: Make AccessibilityUIElementIOS.mm build on iOS
Reviewed by Chris Fleizach.
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Declare
-_accessibilityPath from the WebAccessibilityObjectWrapper
class.
(_CGPathEnumerationIteration): Remove unused CGPoint* variable.
- 5:55 PM Changeset in webkit [148327] by
-
- 5 edits2 adds in branches/safari-536.30-branch
Merge r132856. <rdar://problem/13334380>
- 5:49 PM Changeset in webkit [148326] by
-
- 4 edits2 adds in branches/safari-536.30-branch
Merge r131488. <rdar://problem/13334380>
- 5:46 PM Changeset in webkit [148325] by
-
- 3 edits2 copies in branches/safari-536.30-branch
Merged r130717. <rdar://problem/13334846>
- 5:37 PM Changeset in webkit [148324] by
-
- 2 edits in trunk/Source/WebKit2
Build fix - too soon!
- UIProcess/API/mac/WKViewPrivate.h:
- 5:33 PM Changeset in webkit [148323] by
-
- 5 edits in trunk/Source/WebCore
Update AVFoundationCF code following http://trac.webkit.org/changeset/148291.
https://bugs.webkit.org/show_bug.cgi?id=114548.
Reviewed by Eric Carlson.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::seekToTime):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMinTimeSeekable):
(WebCore):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeSeekable):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
(MediaPlayerPrivateAVFoundationCF):
- 5:15 PM Changeset in webkit [148322] by
-
- 2 edits in trunk/Source/WebKit2
Build fix - too soon!
- UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
- 5:15 PM Changeset in webkit [148321] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebCore
Merged r136619. <rdar://problem/13335066>
- 5:09 PM Changeset in webkit [148320] by
-
- 5 edits in branches/safari-536.30-branch
Merged r117463. <rdar://problem/13335066>
- 5:03 PM Changeset in webkit [148319] by
-
- 2 edits2 deletes in branches/safari-536.30-branch/LayoutTests
Merged r138692. <rdar://problem/13334855>
- 4:58 PM Changeset in webkit [148318] by
-
- 1 edit4 copies3 adds1 delete in branches/safari-536.30-branch/LayoutTests
Merged r138686. <rdar://problem/13334855>
- 4:55 PM Changeset in webkit [148317] by
-
- 2 edits in trunk/Tools
Unreviewed, remove an old email address for myself.
- Scripts/webkitpy/common/config/committers.py:
- 4:47 PM Changeset in webkit [148316] by
-
- 2 edits in trunk/Source/WebCore
Demystify some code in RenderLayer::updateScrollableAreaSet()
https://bugs.webkit.org/show_bug.cgi?id=114543
Reviewed by Tim Horton.
Clean up some code that called functions with important side effects
inside a ternary operator, and clean up the #ifdefs.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollableAreaSet):
- 4:46 PM Changeset in webkit [148315] by
-
- 7 edits15 copies2 deletes in branches/safari-536.30-branch
Merged r138654. <rdar://problem/13334855>
- 4:43 PM Changeset in webkit [148314] by
-
- 2 edits in trunk/Source/JavaScriptCore
Block freeing thread should call Region::destroy instead of delete
https://bugs.webkit.org/show_bug.cgi?id=114544
Reviewed by Oliver Hunt.
Since Region doesn't have a virtual destructor, calling delete will not properly clean up all of
the state of the Region. We should call destroy() instead.
- heap/BlockAllocator.cpp:
(JSC::BlockAllocator::releaseFreeRegions):
(JSC::BlockAllocator::blockFreeingThreadMain):
- 4:42 PM Changeset in webkit [148313] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: switch to using MCJIT and disable frame pointer elimination
https://bugs.webkit.org/show_bug.cgi?id=114542
Reviewed by Oliver Hunt and Michael Saboff.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- 4:29 PM Changeset in webkit [148312] by
-
- 11 edits1 add in trunk
[WK2] WebPageProxy loadURL() won't work when called just after terminateProcess()
https://bugs.webkit.org/show_bug.cgi?id=110743
Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-04-12
Reviewed by Benjamin Poulain.
Source/WebKit2:
A call to loadURL() just after terminating WebProcess will fail thanks to
WebPageProxy being in an undefined state since it is in the middle of its own
cleanup after process termination.
To properly fix this, not only WebPageProxy cleanup should be made
at WebProcess termination request, but also WebProcessProxy needs
to only return to its caller after terminating the process and
closing connections. Otherwise, WebPageProxy can even be able to
detect that WebProcess is no longer running, but a call to respawn
the process will fail.
To fix these issues, this patch moves the cleanup code to a shared private function
that is used for both the cases i.e. user termination and real crash. WebProcess
shutdown is done using a new method that ensures that all cleanup was done before
returning.
A last change introduced in this patch is that for user requested termination,
clients are no longer notified of a crash (since it is not a crash).
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::terminateProcess):
(WebKit::WebPageProxy::processDidCrash):
(WebKit):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::userRequestedTerminate):
(WebKit):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
Tools:
Adding a new test file to check if loading a page just after WebProcess
has crashed (or was terminated) works. The test executes the
following steps (Load, Crash, Load), thus stressing WebProcess
reattach and process termination code path.
- TestWebKitAPI/GNUmakefile.am:
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Added.
(TestWebKitAPI):
(WebKit2CrashLoader):
(TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
(TestWebKitAPI::WebKit2CrashLoader::loadUrl):
(TestWebKitAPI::WebKit2CrashLoader::crashWebProcess):
(TestWebKitAPI::didFinishLoad):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
- 4:18 PM Changeset in webkit [148311] by
-
- 15 edits in trunk/Source/WebKit2
Add contentAnchor to WKView
http://bugs.webkit.org/show_bug.cgi?id=114469
Currently if you call setFrameSize: while frame size updates are disabled, or if the geometry
update times out, then the previously rendered page content will be rendered anchored to the
top left corner of the frame.
This is appropriate if the frame is being resized from the bottom right corner. In order to
achieve a more desirable appearance if the frame is being resized from another corner we
should allow the corner at which the content anchors to be specified.
Reviewed by Simon Fraser.
- UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
- If the content anchor has been set, then updating the frame size moves the origin within the layer.
(-[WKView _setDrawingAreaSize:]):
- Instruct the drawing area to paint at the correct position within the layer.
(-[WKView _setAcceleratedCompositingModeRootLayer:]):
- If the root layer is cleared this implicitly resets any origin position we had set within it.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
- initialize new data members.
(-[WKView setContentAnchor:]):
(-[WKView contentAnchor]):
- Accessor implementation for @property contentAnchor.
- UIProcess/API/mac/WKViewPrivate.h:
(NS_ENUM):
- Added WKContentAnchor enum type, and @property contentAnchor.
- UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::setSize):
- Don't suppress geometry updates where the layer poistion has changed.
- UIProcess/DrawingAreaProxy.h:
(DrawingAreaProxy):
- Added m_layerPosition, layerPosition argument to setSize
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
(TiledCoreAnimationDrawingAreaProxy):
- Added m_lastSentLayerPosition
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
- Don't suppress geometry updates where the layer poistion has changed.
(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):
- Pass layer position in UpdateGeometry message.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::updateGeometry):
- Added layerPosition argument to updateGeometry
- WebProcess/WebPage/DrawingArea.messages.in:
- Added layerPosition argument to updateGeometry
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
- Added layerPosition argument to updateGeometry
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
- Added layerPosition argument to updateGeometry
- 4:11 PM Changeset in webkit [148310] by
-
- 3 edits3 adds in trunk
<rdar://problem/13277362> REGRESSION (r141981): Crash when closing a Google Docs document
https://bugs.webkit.org/show_bug.cgi?id=114541
Reviewed by Brady Eidson.
Test: http/tests/ssl/ping-with-unsafe-redirect.html
- loader/FrameNetworkingContext.h: (WebCore::FrameNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect): Added a null check. All NetworkingContext functions except for this one had it already.
- 4:07 PM Changeset in webkit [148309] by
-
- 1 edit in branches/safari-536.30-branch/LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag.pl
Update from testRunner to layoutTestController
- 4:07 PM Changeset in webkit [148308] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
Update from testRunner to layoutTestController
- 3:50 PM Changeset in webkit [148307] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Don't forget to skip the test in WebKit2 for now.
- platform/mac-wk2/TestExpectations:
- 3:46 PM Changeset in webkit [148306] by
-
- 10 edits2 adds in trunk
[Mac] REGRESSION: Auto substitution strips new lines
https://bugs.webkit.org/show_bug.cgi?id=114537
Reviewed by Enrica Casucci.
Source/WebCore:
The bug was caused by SpellingCorrectionCommand's use of InsertTextCommand. This command can't insert
new lines and there's even an assertion for it. Use TypingCommand::insertText instead.
Since TypingCommand::insertText calls appliedEditing on its own, we need to avoid calling that again in
CompositeEditCommand::apply after SpellingCorrectionCommand::doApply. Replaced the check in apply to use
callsAppliedEditingInDoApply instead of isTypingCommand, and added callsAppliedEditingInDoApply to both
TypingCommand and SpellingCorrectionCommand to return true (it returns false by default).
Test: platform/mac/editing/spelling/autocorrection-with-multi-line-text.html
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::apply): Use TypingCommand::insertText instead of InsertTextCommand
(WebCore::CompositeEditCommand::callsAppliedEditingInDoApply): Added. Returns false.
- editing/CompositeEditCommand.h:
(CompositeEditCommand):
- editing/SpellingCorrectionCommand.cpp:
(WebCore::SpellingCorrectionCommand::doApply):
(WebCore::SpellingCorrectionCommand::callsAppliedEditingInDoApply): Added. Returns true.
- editing/SpellingCorrectionCommand.h:
(SpellingCorrectionCommand):
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::callsAppliedEditingInDoApply): Added. Returns true.
- editing/TypingCommand.h:
(TypingCommand):
Tools:
Add a rule to replace "helloleworld" by "hello\nworld" for testing purpose.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
LayoutTests:
Added a regression test. Unfortunately, we can't setup text substituion in DumpRenderTree
so use NSSpellChecker to exercise the relevant code path.
- platform/mac/editing/spelling/autocorrection-with-multi-line-text-expected.txt: Added.
- platform/mac/editing/spelling/autocorrection-with-multi-line-text.html: Added.
- 3:04 PM Changeset in webkit [148305] by
-
- 16 edits1 copy1 add in trunk/Source/WebCore
Refactor TextTrack and TextTrackList to make it easier to add audio and video tracks
https://bugs.webkit.org/show_bug.cgi?id=114330
Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-12
Reviewed by Jer Noble.
No new tests because this doesn't add new functionality.
- CMakeLists.txt: Only compile text track files if ENABLE(VIDEO_TRACK), and add TrackListBase
- Target.pri: Add TrackListBase
- WebCore.vcproj/WebCore.vcproj: Correct InbandTextTrackPrivate.h's location and add TrackListBase
- WebCore.xcodeproj/project.pbxproj: Add TrackListBase
- html/HTMLMediaElement.cpp: Renamed "track" functions to "textTrack"
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack): Renamed.
(WebCore::HTMLMediaElement::mediaPlayerDidRemoveTextTrack): Renamed.
(WebCore::HTMLMediaElement::addTextTrack): Renamed.
(WebCore::HTMLMediaElement::removeTextTrack): Renamed.
(WebCore::HTMLMediaElement::removeAllInbandTracks): Use renamed functions.
(WebCore::HTMLMediaElement::didAddTextTrack): Renamed.
(WebCore::HTMLMediaElement::didRemoveTextTrack): Renamed.
- html/HTMLMediaElement.h:
Renamed "track" functions to "textTrack" and only forward-declare TextTrackList if ENABLE(VIDEO_TRACK)
- html/HTMLTrackElement.cpp: Renamed "track" functions to "textTrack"
(WebCore::HTMLTrackElement::insertedInto):
(WebCore::HTMLTrackElement::removedFrom):
- html/track/TextTrack.cpp:
Move media element, label, language and kind into TrackBase and move EventTarget functions into TextTrack.
(WebCore::TextTrack::TextTrack): Added.
(WebCore::TextTrack::interfaceName): Added.
(WebCore::TextTrack::scriptExecutionContext): Added.
(WebCore::TextTrack::eventTargetData): Added.
(WebCore::TextTrack::ensureEventTargetData): Added.
(WebCore::TextTrack::isValidKind): Added to support TrackBase::setKind()
(WebCore::TextTrack::setKind): Override to support textTrackKindChanged()
(WebCore::TextTrack::isRendered): Use kind(), label() and language() instead of m_kind, etc.
(WebCore::TextTrack::platformTextTrack): Ditto.
(WebCore::TextTrack::isMainProgramContent): Ditto.
- html/track/TextTrack.h:
Same as TextTrack.cpp, plus added defaultKindKeyword() so TrackBase::setKind() will work and added
toTextTrack().
- html/track/TextTrackList.cpp:
Move functionality into TrackListBase, add toTextTrack() casts, use
TrackBase where necesssary and use owner() instead of m_owner.
Moved EventTarget functions into TrackListBase.
(TextTrackList::TextTrackList):
(TextTrackList::getTrackIndexRelativeToRenderedTracks):
(TextTrackList::item):
(TextTrackList::invalidateTrackIndexesAfterTrack):
(TextTrackList::append):
(TextTrackList::remove):
(TextTrackList::contains):
- html/track/TextTrackList.h:
Move EventTarget, RefCounted and m_inbandTracks into TrackListBase.
Override length(), contains() and remove().
- html/track/TrackBase.cpp: Remove EventTarget functions.
(WebCore::TrackBase::TrackBase):
Remove EventTarget, add label and language
(WebCore::TrackBase::setKind): Added
- html/track/TrackBase.h:
Don't extend EventTarget (AudioTrack and VideoTrack aren't). Handle
kind, label, language and media element.
(WebCore::TrackBase::setMediaElement): Added.
(WebCore::TrackBase::mediaElement): Added.
(WebCore::TrackBase::kind): Added.
(WebCore::TrackBase::label): Added.
(WebCore::TrackBase::setLabel): Added.
(WebCore::TrackBase::language): Added.
(WebCore::TrackBase::setLanguage): Added.
- html/track/TrackListBase.cpp:
Added. Handles functionality common to TextTrackList, AudioTrackList and
VideoTrackList.
(TrackListBase::TrackListBase): Added.
(TrackListBase::~TrackListBase): Added.
(TrackListBase::length): Added.
(TrackListBase::remove): Added.
(TrackListBase::contains): Added.
(TrackListBase::scheduleAddTrackEvent): Added.
(TrackListBase::scheduleRemoveTrackEvent): Added.
(TrackListBase::scheduleChangeEvent): Added.
(TrackListBase::asyncEventTimerFired): Added.
- html/track/TrackListBase.h:
Copied from Source/WebCore/html/track/TextTrackList.h. Handles
functionality common to TextTrackList, AudioTrackList and VideoTrackList.
(WebCore::TrackListBase::scriptExecutionContext): Added.
(WebCore::TrackListBase::clearOwner): Added.
(WebCore::TrackListBase::owner): Added.
(WebCore::TrackListBase::isFiringEventListeners): Added.
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::addTextTrack): Renamed (was addTrack)
(WebCore::MediaPlayer::removeTextTrack): Renamed (was removeTrack)
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerDidAddTextTrack): Renamed (was mediaPlayerDidAddTrack)
(WebCore::MediaPlayerClient::mediaPlayerDidRemoveTextTrack): Renamed (was mediaPlayerDidRemoveTrack)
- 2:54 PM Changeset in webkit [148304] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r148296 and r148297.
http://trac.webkit.org/changeset/148296
http://trac.webkit.org/changeset/148297
https://bugs.webkit.org/show_bug.cgi?id=114536
Needs more thought (Requested by ap on #webkit).
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- 2:39 PM Changeset in webkit [148303] by
-
- 18 edits in trunk/Source/WebCore
make the codegenerator actually emit polymorphism check in the "no vtable" path
https://bugs.webkit.org/show_bug.cgi?id=114533
Reviewed by David Kilzer.
Make the "no vtable" check correct so that we actually plant a polymorphism
check. Update a few interfaces to have the correct validation attributes.
- Modules/webdatabase/SQLTransaction.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::toJS):
- bindings/scripts/test/TestInterface.idl:
- html/track/TextTrackCue.idl:
- svg/SVGAnimatedAngle.idl:
- svg/SVGAnimatedBoolean.idl:
- svg/SVGAnimatedEnumeration.idl:
- svg/SVGAnimatedInteger.idl:
- svg/SVGAnimatedLength.idl:
- svg/SVGAnimatedLengthList.idl:
- svg/SVGAnimatedNumber.idl:
- svg/SVGAnimatedNumberList.idl:
- svg/SVGAnimatedPreserveAspectRatio.idl:
- svg/SVGAnimatedRect.idl:
- svg/SVGAnimatedString.idl:
- svg/SVGAnimatedTransformList.idl:
- 1:44 PM Changeset in webkit [148302] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Enable selecting text in single line input field without selection point being actually on the targeted text vertically
https://bugs.webkit.org/show_bug.cgi?id=114515
Patch by Yongxin Dai <yodai@rim.com> on 2013-04-12
Reviewed by Rob Buis.
PR #317924.
Internally reviewed by Mike Fenton.
It was still hard to select text in URL bar with an inverted selection handle.
We improve the issue by replacing the Y coordinate of selection point with Y
coordinate of start caret for single line input filed. Thus, the Y coordinate
is always valid regardless of the actual location of the selection handle.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::startCaretViewportRect):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- WebKitSupport/SelectionHandler.h:
(SelectionHandler):
- 1:28 PM Changeset in webkit [148301] by
-
- 14 edits in trunk/Source/WebCore
Make CodeGeneratorJS plant comments to explain failures in the binding validation
https://bugs.webkit.org/show_bug.cgi?id=114528
Reviewed by Sam Weinig.
No change in behaviour, just make the generated bindings include comments
to aid diagnosing issues that may be non-obvious.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::toJS):
- 1:17 PM Changeset in webkit [148300] by
-
- 8 edits in trunk/Source
REGRESSION (r138858): GIFs don't start playing when they come out of background tabs
https://bugs.webkit.org/show_bug.cgi?id=108864
<rdar://problem/13140489>
Reviewed by Antti Koivisto.
Don't repaint the world when animations resume; instead, FrameView
will cause all animated images to repaint. This line also had no effect for
TiledCoreAnimationDrawingArea, which does not implement setNeedsDisplay.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::resumeActiveDOMObjectsAndAnimations):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::resumeAnimatingImagesForLoader): Added.
Iterate through all of the loader's cached resources. If they are bitmap images
which claim to be animatable, notify the image's observers that the animation advanced
by one frame. In reality, the image is still on the same frame, but will now be repainted,
restarting the animation loop.
- loader/cache/CachedImage.h:
- page/FrameView.cpp:
(WebCore::FrameView::setIsInWindow):
When the FrameView is brought into a window, repaint all animated images.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::canAnimate): Added.
Return whether or not the image should animate (claims to animate, has not already
finished its animation, and has an ImageObserver) *and* has more than one frame.
- platform/graphics/BitmapImage.h:
(BitmapImage): Add canAnimate.
- 1:10 PM Changeset in webkit [148299] by
-
- 2 edits in trunk/Tools
Re-enable WinEWS tests.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 12:35 PM Changeset in webkit [148298] by
-
- 13 edits in trunk/Source/WebCore
r148197 broke the GTK+ build
https://bugs.webkit.org/show_bug.cgi?id=114525
Reviewed by Anders Carlsson.
Re-add the ENABLE(SCROLLING_THREAD) guards to scrolling thread files
and extend them with USE(COORDINATED_GRAPHICS). This code is unused
by other configurations currently.
- page/scrolling/ScrollingStateFixedNode.cpp: Re-add guards.
- page/scrolling/ScrollingStateFixedNode.h: Ditto.
- page/scrolling/ScrollingStateNode.cpp: Ditto.
- page/scrolling/ScrollingStateNode.h: Ditto.
- page/scrolling/ScrollingStateScrollingNode.cpp: Ditto.
- page/scrolling/ScrollingStateScrollingNode.h: Ditto.
- page/scrolling/ScrollingStateStickyNode.cpp: Ditto.
- page/scrolling/ScrollingStateStickyNode.h: Ditto.
- page/scrolling/ScrollingStateTree.cpp: Ditto.
- page/scrolling/ScrollingStateTree.h: Ditto.
- page/scrolling/mac/ScrollingStateNodeMac.mm: Ditto.
- page/scrolling/mac/ScrollingStateScrollingNodeMac.mm: Ditto.
- 12:28 PM Changeset in webkit [148297] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13334446> [Mac] Tweak sandbox profile.
Apply a post-landing review comment.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- 12:14 PM Changeset in webkit [148296] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13334446> [Mac] Tweak sandbox profile.
Reviewed by Jessie Berlin.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- 12:09 PM Changeset in webkit [148295] by
-
- 2 edits in trunk/Source/WebCore
(AVFoundation) WebKit fails to detect live stream.
https://bugs.webkit.org/show_bug.cgi?id=114474
Reviewed by Eric Carlson.
Remove a workaround (added by r88944) for an error in an Apple.com javascript
media controller. The error has been fixed, and the workaround is causing problems
with other media streams.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
- 11:57 AM Changeset in webkit [148294] by
-
- 15 edits6 adds4 deletes in trunk
[GTK] Split GtkAuthenticationDialog in two widgets
https://bugs.webkit.org/show_bug.cgi?id=103644
Reviewed by Xan Lopez.
Source/WebCore:
The current GtkAuthenticationDialog implements both the common
logic and widgets to implement a real GtkDialog and a widget to be
embedded in any container. WebKit1 uses a GtkDialog while WebKit2
embeds the dialog in the WebView. This patch splits the code to
leave in Platform only the code that is actually common, leaving
the widget implementation to the WebKit layer, using a dialog in
WebKit1 and embedding auth widget in the WebView in WebKit2.
- GNUmakefile.list.am: Add new files to compilation.
- platform/gtk/GtkAuthenticationDialog.cpp: Removed.
- platform/gtk/GtkAuthenticationDialog.h: Removed.
- platform/gtk/WebKitAuthenticationWidget.cpp: Added.
(_WebKitAuthenticationWidgetPrivate):
(packTwoColumnLayoutInBox):
(createLabel):
(createEntry):
(webkitAuthenticationWidgetInitialize):
(webkitAuthenticationWidgetFinalize):
(webkit_authentication_widget_init):
(webkit_authentication_widget_class_init):
(webkitAuthenticationWidgetNew):
(webkitAuthenticationWidgetCreateCredential):
(webkitAuthenticationWidgetGetChallenge):
- platform/gtk/WebKitAuthenticationWidget.h: Added.
(_WebKitAuthenticationWidget):
(_WebKitAuthenticationWidgetClass):
Source/WebKit/gtk:
- GNUmakefile.am: Add new files to compilation.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
Use helper createAuthenticationDialog() to create and show the
auth dialog.
- webkit/webkitauthenticationdialog.cpp: Added.
(authenticationDialogResponseCallback):
(createAuthenticationDialog):
- webkit/webkitauthenticationdialog.h: Added.
- webkit/webkitsoupauthdialog.cpp:
(sessionAuthenticate): Ditto.
Source/WebKit2:
- GNUmakefile.list.am: Add new files to compilation.
- UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.cpp: Removed.
- UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.h: Removed.
- UIProcess/API/gtk/WebKitAuthenticationDialog.cpp: Added.
(webkitAuthenticationDialogAuthenticate): Use the
AuthenticationChallengeProxy to authenticate and destroy the dialog.
(okButtonClicked): Call webkitAuthenticationDialogAuthenticate()
with the credential.
(cancelButtonClicked): Call
webkitAuthenticationDialogAuthenticate() with a NULL credential to
continue without credential.
(webkitAuthenticationDialogInitialize): Build the UI.
(webkitAuthenticationDialogDraw): Draw a background.
(webkitAuthenticationDialogMap): Grab default button.
(webkitAuthenticationDialogConstructed): Create a GtkStyleContext
with the GtkWindow path to draw the widget background like a real
dialog.
(webkit_authentication_dialog_class_init):
(webkitAuthenticationDialogNew): Create a new
WebKitAuthenticationDialog widget.
- UIProcess/API/gtk/WebKitAuthenticationDialog.h: Added.
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewHandleAuthenticationChallenge): Create a
WebKitAuthenticationDialog widget and pass add it to the
container.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(_WebKitWebViewBasePrivate): Updated to use the widget directly.
(webkitWebViewChildIsInternalWidget): Ditto.
(webkitWebViewBaseAddAuthenticationDialog): Ditto.
(webkitWebViewBaseCancelAuthenticationDialog): Ditto.
(webkitWebViewBaseContainerRemove): Ditto.
(webkitWebViewBaseContainerForall): Ditto.
(resizeWebKitWebViewBaseFromAllocation): Ditto.
(webkitWebViewBaseFocus): Ditto.
(webkitWebViewBaseDestroy): Destroy the auth widget is present.
(webkit_web_view_base_class_init): Add implementation for
GtkWidgetClass::destroy.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
Tools:
- gtk/generate-gtkdoc:
(get_webkit2_options): Do not generate api docs for
WebKitAuthenticationDialog which is private in WebKit2.
(get_webkit1_options): Do not generate api docs for
webkitauthenticationdialog which is private in WebKit1.
- 11:45 AM Changeset in webkit [148293] by
-
- 2 edits in trunk
[GTK] Lower the pango dependency
https://bugs.webkit.org/show_bug.cgi?id=114520
Reviewed by Carlos Garcia Campos.
- Source/autotools/Versions.m4: Only depend on Pango 1.30.0 instead of
Pango 1.32.0. 1.32.0 isn't strictly necessary and the version of GTK+ that
we depend on (3.6.0) depends on 1.30.0.
- 11:43 AM Changeset in webkit [148292] by
-
- 2 edits in trunk/Tools
WebKit Queues should capitalize K in Wk2
https://bugs.webkit.org/show_bug.cgi?id=114524
Reviewed by Philippe Normand.
- QueueStatusServer/model/queues.py:
(Queue.display_name):
- 11:39 AM Changeset in webkit [148291] by
-
- 9 edits in trunk/Source/WebCore
Add support for MediaPlayer::minTimeSeekable()
https://bugs.webkit.org/show_bug.cgi?id=114484
Reviewed by Eric Carlson.
Plumb a new minTimeSeekable() method through MediaPlayer and
MediaPlayerPrivate and use this new method in the existing
HTMLMediaElement::minTimeSeekable() method.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::minTimeSeekable): Pass to MediaPlayer.
- platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::minTimeSeekable): Return 0.
(WebCore::MediaPlayer::minTimeSeekable): Pass to MediaPlayerPrivate.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::seekable): Define in terms of
minTimeSeekable()
(WebCore::MediaPlayerPrivateInterface::minTimeSeekable): Default to 0.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
Initialize new m_cachedMinTimeSeekable ivar.
(WebCore::MediaPlayerPrivateAVFoundation::maxTimeSeekableDouble):
Renamed from maxTimeSeekable().
(WebCore::MediaPlayerPrivateAVFoundation::minTimeSeekable): Added.
Cache value of platformMinTimeSeekable().
(WebCore::MediaPlayerPrivateAVFoundation::seekableTimeRangesChanged):
Reset m_cachedMinTimeSeekable.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime): float -> double.
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMinTimeSeekable):
Added. Retrieve the lowest value from -[m_playerItem seekableTimeRanges].
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeSeekable):
float -> double.
- 11:36 AM Changeset in webkit [148290] by
-
- 2 edits in trunk/Source/WebKit/win
All tests crash on Windows
https://bugs.webkit.org/show_bug.cgi?id=114522
Reviewed by Ryosuke Niwa.
In the MSVC++ ABI, a member function pointer will have a different size depending on whether the
class it belongs to is defined or not. Because of this, when passing member function pointers as parameters
it's important to ensure that the class is known by both the caller and the callee.
- WebFrame.cpp:
Include PolicyChecker.h
- 11:06 AM Changeset in webkit [148289] by
-
- 20 edits2 adds60 deletes in trunk
Unreviewed, rolling out r147942, r148026, and r148092.
http://trac.webkit.org/changeset/147942
http://trac.webkit.org/changeset/148026
http://trac.webkit.org/changeset/148092
https://bugs.webkit.org/show_bug.cgi?id=114521
"r147942 is buggy. Rollback all the patches depending on it."
(Requested by abucur on #webkit).
Source/WebCore:
- dom/ContainerNode.cpp:
(WebCore::willRemoveChildren):
(WebCore):
(WebCore::ContainerNode::removeChildren):
- dom/Document.cpp:
(WebCore::Document::nodeChildrenWillBeRemoved):
(WebCore):
- dom/Document.h:
(Document):
- dom/Node.cpp:
- dom/Node.h:
(Node):
- dom/NodeTraversal.cpp:
- dom/NodeTraversal.h:
(ElementTraversal):
(NodeTraversal):
- dom/Range.cpp:
(WebCore::boundaryNodeChildrenWillBeRemoved):
(WebCore):
(WebCore::Range::nodeChildrenWillBeRemoved):
- dom/Range.h:
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::attach):
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):
- rendering/RenderCounter.cpp:
(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):
- rendering/RenderListItem.cpp:
(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):
- rendering/RenderListItem.h:
(RenderListItem):
LayoutTests:
- fast/dom/MutationObserver/added-out-of-order-expected.txt:
- fast/dom/MutationObserver/added-out-of-order.html:
- fast/dom/Range/range-remove-children-event-expected.txt: Removed.
- fast/dom/Range/range-remove-children-event.html: Removed.
- fast/dom/containerNode-expected.txt: Added.
- fast/dom/containerNode.html: Added.
- fast/dom/shadow/shadow-and-list-elements-expected.html:
- fast/events/mutation-during-innerHTML-expected.txt: Removed.
- fast/events/mutation-during-innerHTML.html: Removed.
- fast/lists/positioned-count-crash-expected.txt:
- fast/regions/counters/extract-list-items-001-expected.html: Removed.
- fast/regions/counters/extract-list-items-001.html: Removed.
- fast/regions/counters/extract-list-items-002-expected.html: Removed.
- fast/regions/counters/extract-list-items-002.html: Removed.
- fast/regions/counters/extract-list-items-003-expected.html: Removed.
- fast/regions/counters/extract-list-items-003.html: Removed.
- fast/regions/counters/extract-list-items-004-expected.html: Removed.
- fast/regions/counters/extract-list-items-004.html: Removed.
- fast/regions/counters/extract-list-items-005-expected.html: Removed.
- fast/regions/counters/extract-list-items-005.html: Removed.
- fast/regions/counters/extract-list-items-006-expected.html: Removed.
- fast/regions/counters/extract-list-items-006.html: Removed.
- fast/regions/counters/extract-list-items-007-expected.html: Removed.
- fast/regions/counters/extract-list-items-007.html: Removed.
- fast/regions/counters/extract-list-items-008-expected.html: Removed.
- fast/regions/counters/extract-list-items-008.html: Removed.
- fast/regions/counters/extract-list-items-009-expected.html: Removed.
- fast/regions/counters/extract-list-items-009.html: Removed.
- fast/regions/counters/extract-list-items-010-expected.html: Removed.
- fast/regions/counters/extract-list-items-010.html: Removed.
- fast/regions/counters/extract-list-items-011-expected.html: Removed.
- fast/regions/counters/extract-list-items-011.html: Removed.
- fast/regions/counters/extract-list-items-012-expected.html: Removed.
- fast/regions/counters/extract-list-items-012.html: Removed.
- fast/regions/counters/extract-list-items-013-expected.html: Removed.
- fast/regions/counters/extract-list-items-013.html: Removed.
- fast/regions/counters/extract-list-items-014-expected.html: Removed.
- fast/regions/counters/extract-list-items-014.html: Removed.
- fast/regions/counters/extract-list-items-015-expected.html: Removed.
- fast/regions/counters/extract-list-items-015.html: Removed.
- fast/regions/counters/extract-numbered-paragraphs-divs-001-expected.html: Removed.
- fast/regions/counters/extract-numbered-paragraphs-divs-001.html: Removed.
- fast/regions/counters/extract-numbered-paragraphs-divs-002-expected.html: Removed.
- fast/regions/counters/extract-numbered-paragraphs-divs-002.html: Removed.
- fast/regions/counters/extract-numbered-paragraphs-expected.html: Removed.
- fast/regions/counters/extract-numbered-paragraphs.html: Removed.
- fast/regions/counters/extract-numbered-spans-display-only-some-expected.html: Removed.
- fast/regions/counters/extract-numbered-spans-display-only-some.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-001-expected.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-001.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-002-expected.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-002.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-003-expected.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-003.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001-expected.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002-expected.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003-expected.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004-expected.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html: Removed.
- fast/regions/counters/extract-unordered-lists-in-regions-expected.html: Removed.
- fast/regions/counters/extract-unordered-lists-in-regions.html: Removed.
- 10:58 AM Changeset in webkit [148288] by
-
- 13 edits2 adds in trunk
TimeRanges::nearest() returns incorrect results.
https://bugs.webkit.org/show_bug.cgi?id=114483
Reviewed by Eric Carlson.
.:
Add symbols needed by WebCoreTestSupport to exports list.
- Source/autotools/symbols.filter:
Source/WebCore:
Test: media/timeranges-nearest.html
TimeRanges::nearest() has had an incorrect algorithm since its
addition, which has gone unnoticed because no media engine supports
seekable ranges with greater than one entry, and no media engine
seekable ranges with startTime values > 0.
Fix the algorithm used to walk a TimeRanges object; return the closest
time, not the smallest delta between range and target time.
- html/TimeRanges.cpp:
(TimeRanges::nearest):
Add some internal functions to allow us to write LayoutTests for
TimeRanges objects:
- WebCore.exp.in:
- testing/Internals.cpp:
(WebCore::Internals::createTimeRanges):
(WebCore::Internals::closestTimeToTimeRanges):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
Add symbols needed by WebCoreTestSupport to the exports list.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/win:
Add symbols needed by WebCoreTestSupport to the exports list.
- WebKit.vcproj/WebKitExports.def.in:
LayoutTests:
- media/timeranges-nearest-expected.txt: Added.
- media/timeranges-nearest.html: Added.
- 10:40 AM Changeset in webkit [148287] by
-
- 2 edits in trunk/Source/WTF
Remove bogus change
- 10:24 AM Changeset in webkit [148286] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Web Process crash when the UI process finishes too early
https://bugs.webkit.org/show_bug.cgi?id=112729
Reviewed by Anders Carlsson.
The problem is when creating the GSocket in the WorkQeue for the
socket descriptor. GLib considers a programmer error to create a
GSocket providing an invalid socket and finishes the process with
g_error(). We are actually providing a valid socket when creating
the GSocket, but it can be invalidated by the worker thread while
the GSocket is being created. This is because
registerEventSourceHandler is called from the main thread and
unregisterEventSourceHandler can be called from the worker
thread. We are currently registering two event handlers, one to
read data from the socket and another one to close the CoreIPC
connection when the socket connection is broken. Every event
source registered uses its own GSocket (even if the file
descriptor is actually the same), so that when the UI process
finishes too early, the first event handler can be executed in the
worker thread, closing the socket descriptor, while the main
thread is creating the GSocket for the second one.
We don't really need to use a separate event handler to monitor
the connection, because GSocket always notifies when condition is
G_IO_HUP and G_IO_ERR even if they haven't been explicitly set in
g_socket_create_source(). We can register socket event sources
differently, providing also a function to be called when the
connection is closed, using a single socket and the same even source.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::open): Register a single socket event
handler providing also a function to be called when the connection
is closed.
- Platform/WorkQueue.h:
(WorkQueue):
- Platform/gtk/WorkQueueGtk.cpp: The EventSource class has been
split, moving everyting specific to socket event source to a
derived class SocketEventSource.
(WorkQueue::EventSource::EventSource):
(WorkQueue::EventSource::performWork):
(WorkQueue::EventSource::performWorkOnce):
(WorkQueue::EventSource::performWorkOnTermination):
(WorkQueue::EventSource::deleteEventSource):
(WorkQueue::EventSource):
(WorkQueue::SocketEventSource):
(WorkQueue::SocketEventSource::SocketEventSource):
(WorkQueue::SocketEventSource::cancel):
(WorkQueue::SocketEventSource::didClose):
(WorkQueue::SocketEventSource::checkCondition):
(WorkQueue::SocketEventSource::eventCallback):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatchOnSource):
- 10:23 AM Changeset in webkit [148285] by
-
- 23 edits2 adds in trunk
Support "forced" subtitles
https://bugs.webkit.org/show_bug.cgi?id=114460
Reviewed by Jer Noble.
Source/WebCore:
Test: media/track/track-forced-subtitles.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureTextTrackGroup): Enable a forced track if nothing else is enabled.
(WebCore::HTMLMediaElement::configureTextTracks): Include forced tracks with captions+subtitles.
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::InbandTextTrack): Deal with kind=forced.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::forcedKeyword): New keyword.
(WebCore::TextTrack::isValidKindKeyword): Include forced.
(WebCore::TextTrack::platformTextTrack): Ditto.
- html/track/TextTrack.h:
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::primaryAudioTrackLanguageOverride): New override to support testing.
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Support forced tracks.
- platform/graphics/InbandTextTrackPrivate.h:
- platform/graphics/PlatformTextTrack.h: Add Forced, minor cleanup.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCue): Drive-by enhancement: log cue position.
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::kind): Support forced.
(WebCore::InbandTextTrackPrivateAVFObjC::label): Drive-by cleanup.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Don't filter out forced tracks.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Log the language returned.
- testing/Internals.cpp:
(WebCore::Internals::setPrimaryAudioTrackLanguageOverride): New.
(WebCore::Internals::setCaptionDisplayMode): New.
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- media/content/CC+Subtitles.m4v: Added.
- media/track/track-forced-subtitles-in-band-expected.txt: Added.
- media/track/track-forced-subtitles-in-band.html: Added.
- media/trackmenu-test.js:
- platform/efl/TestExpectations: Skip new test.
- platform/gtk/TestExpectations: Ditto.
- platform/mac/TestExpectations: Ditto.
- platform/qt/TestExpectations: Ditto.
- platform/win/TestExpectations: Ditto.
- 10:06 AM Changeset in webkit [148284] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/13126204> [Mac] Tweak sandbox profile.
Reviewed by Anders Carlsson.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- WebProcess/com.apple.WebProcess.sb.in:
- 9:54 AM Changeset in webkit [148283] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Some ligatures are applied across different fronts
https://bugs.webkit.org/show_bug.cgi?id=113604
Reviewed by Darin Adler.
The bug was caused by applyFontTransforms applying ligatures without updating the font data in the glyph buffer.
Suppose we have characters AB and A uses font X and B uses font Y. Further suppose that we have ligatures for AB
in Y. The problem was that WithIterator::advanceInternal calls applyFontTransforms on AB to apply this ligature
even though A and B use different fonts. Since X doesn't contain the same ligature for A to be paired with that
of B in X, we get a blank A.
Fixed the bug by resetting lastGlyphCount after calling applyFontTransforms. This ensures that we don't call
applyFontTransforms across different fonts.
No new tests since this requires a variant of Osaka font that doesn't come with OS X.
The bug 114482 tracks the effort to add a test for this bug fix. I've already asked someone to create a custom
font for us so that we can test this bug fix but that's going to a while.
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal):
- 9:52 AM Changeset in webkit [148282] by
-
- 26 edits6 deletes in trunk
[Mac] Enable spellchecking tests added in r141471
https://bugs.webkit.org/show_bug.cgi?id=108525
Reviewed by Darin Adler.
Source/WebCore:
Made automatic quote substitution, dash substitution, text replacement, and spelling correction
togglable via internals object. These functions are no-op when text replacement is not used.
This allows us to disable automatic spelling correction in spellcheck tests.
Enabled several tests added in r141471.
- WebCore.exp.in:
- testing/Internals.cpp:
(WebCore::Internals::setContinuousSpellCheckingEnabled): Don't null check editor() since it's not
null whenever frame() is not null.
(WebCore::Internals::setAutomaticQuoteSubstitutionEnabled): Added.
(WebCore::Internals::setAutomaticLinkDetectionEnabled): Added.
(WebCore::Internals::setAutomaticDashSubstitutionEnabled): Added.
(WebCore::Internals::setAutomaticTextReplacementEnabled): Added.
(WebCore::Internals::setAutomaticSpellingCorrectionEnabled): Added.
- testing/Internals.h:
- testing/Internals.idl:
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
(resetDefaultsToConsistentValues):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
LayoutTests:
Updated the tests not to assume spelling correction suggestions were listed in a context menu since
only Chromium port did this.
- editing/spelling/resources/util.js:
(initSpellTest): Disable automatic text replacements.
- editing/spelling/spelling-with-underscore-selection-expected.txt: Removed.
- editing/spelling/spelling-with-underscore-selection.html: Removed.
This test erroneously assumed a specific word breaking behavior that doesn't include the underscore
when selecting a word especially since Chromium was the only port that was running these tests.
- editing/spelling/spelling-double-clicked-word-with-underscores-expected.txt: Removed.
- editing/spelling/spelling-double-clicked-word-with-underscores.html: Removed.
Ditto.
- editing/spelling/spelling-should-select-single-word-expected.txt: Removed.
- editing/spelling/spelling-should-select-single-word.html: Removed.
Removed since this test doesn't do anything useful without the assertion for the context menu.
- editing/spelling/spelling-double-clicked-word-expected.txt:
- editing/spelling/spelling-double-clicked-word.html:
- editing/spelling/spelling-exactly-selected-word-expected.txt:
- editing/spelling/spelling-exactly-selected-word.html:
- editing/spelling/spelling-with-punctuation-selection-expected.txt:
- editing/spelling/spelling-with-punctuation-selection.html:
- editing/spelling/spelling-with-whitespace-selection-expected.txt:
- editing/spelling/spelling-with-whitespace-selection.html:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 9:33 AM Changeset in webkit [148281] by
-
- 4 edits in trunk/Source/WebKit2
[GTK][WK2] Add document-loaded signal to WebKitWebPage
https://bugs.webkit.org/show_bug.cgi?id=110614
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-12
Reviewed by Carlos Garcia Campos.
Add a new signal document-loaded to WebKitWebPage that will be emitted
when the DOM document has been loaded for the main frame.
- UIProcess/API/gtk/tests/TestWebExtensions.cpp:
(documentLoadedCallback):
(testDocumentLoadedSignal):
(beforeAll): Add test for document-loaded signal.
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(documentLoadedCallback):
(pageCreatedCallback):
(methodCallCallback): Add new D-Bus signal DocumentLoaded in order to
test document-loaded signal.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkit_web_page_class_init):
(webkitWebPageCreate): Add document-loaded signal and emit it when
didFinishDocumentLoadForFrame is called.
- 9:19 AM Changeset in webkit [148280] by
-
- 2 edits in trunk/Source/WTF
[Qt][Win] r148257 broke the build
https://bugs.webkit.org/show_bug.cgi?id=114512
Build fix.
- wtf/Platform.h:
- 9:07 AM Changeset in webkit [148279] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Webkit fails to build webkit2gtk-tests-resources.gresource.
https://bugs.webkit.org/show_bug.cgi?id=114485
Patch by Hanyee Kim <choco@company100.net> on 2013-04-12
Reviewed by Martin Robinson.
Generating webkit2gtk-tests-resources.gresource can be failed due to
the non-existing target directory.
We need to make target directory before generating it.
- UIProcess/API/gtk/tests/GNUmakefile.am:
- 8:13 AM Changeset in webkit [148278] by
-
- 8 edits in trunk/Source/WebKit2
REGRESSION(r145869): Right-click on SWF contents displays the context menu at the wrong place.
<http://webkit.org/b/113836>
<rdar://problem/13587624>
Reviewed by Anders "Wesley Crusher" Carlsson.
Mac plugins expect flipped-Y screen coordinates, while DOM APIs speak in unflipped coordinates,
and we were mixing them up in the window frame caching optimization.
Solve this by having the UIProcess send both flipped and unflipped window frames to the WebProcess.
The flipped frame is passed on to plugins, and the unflipped frame is used for window.screenX/Y etc.
- UIProcess/API/mac/WKView.mm:
(-[WKView _updateWindowAndViewFrames]):
No need to retrieve the window frame here as WebPageProxy::windowAndViewFramesChanged() will
always override it anyway.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::windowAndViewFramesChanged):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::windowRect):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowAndViewFramesChanged):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::windowFrameInUnflippedScreenCoordinates):
- WebProcess/WebPage/WebPage.messages.in:
- 7:05 AM Changeset in webkit [148277] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Crash running layout tests
https://bugs.webkit.org/show_bug.cgi?id=114503
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-12
Reviewed by Xan Lopez.
Hit an assertion in ~GuardedPointerBase when DRT is
deleted. DumpRenderTree class derives from
BlackBerry::Platform::LayoutTestClient that derives from
BlackBerry::Platform::GuardedPointerBase, so the DRT pointer
should no be released with delete but with
BlackBerry::Platform::deleteGuardedObject().
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
- 6:50 AM Changeset in webkit [148276] by
-
- 5 edits in trunk/Tools
[GTK] Enable WebKit2 building on GTK EWSs
https://bugs.webkit.org/show_bug.cgi?id=114500
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-12
Reviewed by Philippe Normand.
Add configuration in order to be able to setup GTK EWSs building
WebKit2. A new queue gtk-wk2-ews is added.
- QueueStatusServer/config/queues.py:
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(GtkWK2Port):
(GtkWK2Port.build_webkit_command):
(GtkWK2Port.run_webkit_tests_command):
- Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest):
(DeprecatedPortTest.test_gtk_wk2_port):
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(GtkWK2EWS):
- 6:22 AM Changeset in webkit [148275] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Upstream the filesystem code
https://bugs.webkit.org/show_bug.cgi?id=114437
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-12
Reviewed by Rob Buis.
These are the changes for AsyncFileSystemBlackBerry.
This patch contains contributions from many members of the
BlackBerry WebKit team.
- platform/blackberry/AsyncFileSystemBlackBerry.cpp:
(WebCore::AsyncFileSystem::isAvailable):
(WebCore):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystemBlackBerry::openFileSystem):
(WebCore::AsyncFileSystem::deleteFileSystem):
(WebCore::AsyncFileSystemBlackBerry::AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::~AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::move):
(WebCore::AsyncFileSystemBlackBerry::copy):
(WebCore::AsyncFileSystemBlackBerry::remove):
(WebCore::AsyncFileSystemBlackBerry::removeRecursively):
(WebCore::AsyncFileSystemBlackBerry::readMetadata):
(WebCore::AsyncFileSystemBlackBerry::createFile):
(WebCore::AsyncFileSystemBlackBerry::createDirectory):
(WebCore::AsyncFileSystemBlackBerry::fileExists):
(WebCore::AsyncFileSystemBlackBerry::directoryExists):
(WebCore::AsyncFileSystemBlackBerry::readDirectory):
(WebCore::AsyncFileSystemBlackBerry::createWriter):
(WebCore::AsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadata):
(WebCore::AsyncFileSystemBlackBerry::fileSystemURLToPath):
- platform/blackberry/AsyncFileSystemBlackBerry.h:
(WTF):
(WTF::BlackBerry::Platform::WebFileSystem):
(WebCore::AsyncFileSystemBlackBerry::create):
(AsyncFileSystemBlackBerry):
- 6:10 AM Changeset in webkit [148274] by
-
- 11 edits4 copies in trunk/Source/WebKit2
[WK2][EFL] WebView: Add callbacks to the WKViewClient to handle page viewport update
https://bugs.webkit.org/show_bug.cgi?id=110463
Reviewed by Anders Carlsson.
- UIProcess/efl/ViewClientEfl.h:
(ViewClientEfl):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::didChangeViewportProperties):
- UIProcess/efl/WebViewClient.cpp:
(WebKit::WebViewClient::didChangeViewportAttributes):
(WebKit):
- UIProcess/efl/WebViewClient.h:
Added didChangeViewportAttributes callback to the WKViewClient to
handle page viewport updates.
- CMakeLists.txt:
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
- UIProcess/API/C/WKAPICast.h:
(WebKit):
- UIProcess/API/C/WKViewportAttributes.cpp: Added.
(WKViewportAttributesGetTypeID):
- UIProcess/API/C/WKViewportAttributes.h: Added.
- UIProcess/API/C/efl/WKView.h:
- UIProcess/WebViewportAttributes.cpp: Added.
(WebKit):
(WebKit::WebViewportAttributes::WebViewportAttributes):
(WebKit::WebViewportAttributes::~WebViewportAttributes):
- UIProcess/WebViewportAttributes.h: Added.
(WebKit):
(WebViewportAttributes):
(WebKit::WebViewportAttributes::create):
(WebKit::WebViewportAttributes::originalAttributes):
(WebKit::WebViewportAttributes::type):
Added WKViewportAttributesRef - WK2 C API object that is wrapping
WebCore::ViewportAttributes structure and is passed in didChangeViewportAttributes
WKViewClient callback.
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeViewportAttributes):
(WebKit):
Added implementaion of didChangeViewportAttributes WKViewClient
callback so that existing EFL WK2 funtionality is kept.
- 3:54 AM Changeset in webkit [148273] by
-
- 2 edits in trunk/Source/WebCore
Apply our MSVC 2012 optimizer bug workaround to all minor releases
https://bugs.webkit.org/show_bug.cgi?id=114436
Reviewed by Alexey Proskuryakov.
The bug has only been partially fixed in Update 2 but our Update 1 workaround
still avoids the crash.
- platform/text/TextEncodingRegistry.cpp:
(WebCore::TextEncodingNameHash::equal):
- 3:28 AM Changeset in webkit [148272] by
-
- 2 edits in trunk/Source/WebCore
And again, with the correct case this time.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
- 3:22 AM Changeset in webkit [148271] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
Add missing #include and forward declaration.
- 2:03 AM Changeset in webkit [148270] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Crash running layout tests when WebPage is destroyed
https://bugs.webkit.org/show_bug.cgi?id=114497
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-12
Reviewed by Xan Lopez.
PR 324649
Internally reviewed by Konrad Piascik and Rob Buis.
Use a bool member to keep track of whether the inspector is
enabled or not instead of relaying on the enable developer extras
setting, that can be set in other places than enableWebInspector().
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Initialize
m_inspectorEnabled.
(BlackBerry::WebKit::WebPage::enableWebInspector): Return early if
inspector is already enabled and set m_inspectorEnabled to true.
(BlackBerry::WebKit::WebPage::disableWebInspector): Return early
if inspector is not enabled and set m_inspectorEnabled to false.
(BlackBerry::WebKit::WebPage::isWebInspectorEnabled): Check the
current value of m_inspectorEnabled instead of the developer
extras setting.
- Api/WebPage_p.h:
(WebPagePrivate): Add m_inspectorEnabled.
- 1:55 AM Changeset in webkit [148269] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed functionality fix for ports enabling the MicroData feature.
- html/DOMSettableTokenList.idl: Add the SkipVTableValidation IDL attribute to the DOMSettableTokenList interface.
This removes crashes in the MicroData layout tests that are occurring on EFL and GTK builders, the two ports being
the only ports that enable this feature.
- 1:17 AM Changeset in webkit [148268] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/TestExpectations:
- platform/qt/fast/js/global-constructors-expected.txt: Rebaselining after r148236.
- 1:12 AM Changeset in webkit [148267] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] The style of visited links doesn't change in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112175
Reviewed by Benjamin Poulain.
The problem is that visited links were not tracked by the web
process. There's a web process initial parameter to set whether
web process should track visited links or not and it's disabled by
default.
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess): Always set
shouldTrackVisitedLinks to true.
- 12:55 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:38 AM Changeset in webkit [148266] by
-
- 1 edit2 deletes in trunk/Tools
Remove Chromium scripts
https://bugs.webkit.org/show_bug.cgi?id=114492
Reviewed by Benjamin Poulain.
- Scripts/run-chromium-webkit-unit-tests: Removed.
- Scripts/update-webkit-chromium: Removed.
- 12:15 AM Changeset in webkit [148265] by
-
- 15 edits1 add in trunk/Source/WebCore
Move CachedRawResourceClient into a separate file
https://bugs.webkit.org/show_bug.cgi?id=114491
Reviewed by Mark Rowe.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- loader/DocumentLoader.cpp:
- loader/DocumentLoader.h:
- loader/DocumentThreadableLoader.h:
- loader/archive/cf/LegacyWebArchive.cpp:
- loader/cache/CachedRawResource.cpp:
- loader/cache/CachedRawResource.h:
- loader/cache/CachedRawResourceClient.h: Added.
- loader/icon/IconLoader.h:
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
- 12:14 AM Changeset in webkit [148264] by
-
- 18 edits in trunk
Unreviewed, rolling out r148262.
http://trac.webkit.org/changeset/148262
https://bugs.webkit.org/show_bug.cgi?id=114493
Cairo dep should now build, rolling r148247 back in (Requested
by zdobersek on #webkit).
Patch by Commit Queue <rniwa@webkit.org> on 2013-04-12
.:
- Source/autotools/FindDependencies.m4:
- Source/autotools/PrintBuildConfiguration.m4:
- Source/autotools/SetupWebKitFeatures.m4:
Source/WebCore:
- platform/graphics/GraphicsContext.cpp:
(WebCore):
- platform/graphics/ImageBuffer.cpp:
(WebCore):
- platform/graphics/cairo/GLContext.h:
(GLContext):
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore):
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore):
(WebCore::createCairoGLSurface):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::mapSurfaceToImage):
(WebCore::unmapSurfaceFromImage):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBufferData::paintToTextureMapper):
(WebCore::ImageBuffer::platformLayer):
- platform/graphics/cairo/ImageBufferDataCairo.h:
(ImageBufferData):
- platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::GLContextEGL):
(WebCore::GLContextEGL::~GLContextEGL):
(WebCore::GLContextEGL::cairoDevice):
(WebCore):
- platform/graphics/egl/GLContextEGL.h:
- platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::GLContextGLX):
(WebCore::GLContextGLX::~GLContextGLX):
(WebCore::GLContextGLX::cairoDevice):
(WebCore):
- platform/graphics/glx/GLContextGLX.h:
(GLContextGLX):
Tools:
- Scripts/webkitdirs.pm:
(buildAutotoolsProject):
- gtk/jhbuild.modules:
Apr 11, 2013:
- 11:11 PM Changeset in webkit [148263] by
-
- 10 edits1 add in trunk/Source/WebCore
Reduce includes of CachedSVGDocument.h
https://bugs.webkit.org/show_bug.cgi?id=114489
Reviewed by Jon Honeycutt.
- loader/cache/CachedSVGDocumentReference.cpp: Added.
- loader/cache/CachedSVGDocumentReference.h: Moved function implementations to newly added .cpp file, and removed an include of CachedSVGDocument.h.
- css/WebKitCSSSVGDocumentValue.h: Just removed an unnecessary include.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- 11:04 PM Changeset in webkit [148262] by
-
- 18 edits in trunk
Unreviewed, rolling out r148247.
http://trac.webkit.org/changeset/148247
https://bugs.webkit.org/show_bug.cgi?id=114490
Cairo dep fails to build on builders due to missing EGL
headers (Requested by zdobersek on #webkit).
Patch by Commit Queue <rniwa@webkit.org> on 2013-04-11
.:
- Source/autotools/FindDependencies.m4:
- Source/autotools/PrintBuildConfiguration.m4:
- Source/autotools/SetupWebKitFeatures.m4:
Source/WebCore:
- platform/graphics/GraphicsContext.cpp:
(WebCore):
- platform/graphics/ImageBuffer.cpp:
(WebCore):
- platform/graphics/cairo/GLContext.h:
(GLContext):
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore):
- platform/graphics/cairo/ImageBufferDataCairo.h:
(ImageBufferData):
- platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::GLContextEGL):
(WebCore::GLContextEGL::~GLContextEGL):
- platform/graphics/egl/GLContextEGL.h:
- platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::GLContextGLX):
(WebCore::GLContextGLX::~GLContextGLX):
- platform/graphics/glx/GLContextGLX.h:
(GLContextGLX):
Tools:
- Scripts/webkitdirs.pm:
(buildAutotoolsProject):
- gtk/jhbuild.modules:
- 10:03 PM Changeset in webkit [148261] by
-
- 2 edits in trunk/Source/WebCore
Remove debugging code that is no longer used with current mac sdks.
https://bugs.webkit.org/show_bug.cgi?id=114486
Reviewed by Dan Bernstein.
This code compared MAC_OS_X_VERSION_MAX_ALLOWED and friends to
107 and 106 instead of the correct 1070 and 1060. Instead of fixing
this, rip the code out completely: Since WebKit now only targets
current systems, the ifdef is always false anyways.
No tests, as this only removes debugging code.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
- 9:21 PM Changeset in webkit [148260] by
-
- 14 edits in trunk/Source/WebCore
Fix windows build and land new binding test results
- 8:42 PM Changeset in webkit [148259] by
-
- 5 edits in trunk/Source/JavaScriptCore
Merge CharacterClassTable into CharacterClass
https://bugs.webkit.org/show_bug.cgi?id=114409
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-11
Reviewed by Darin Adler.
CharacterClassTable is only a pointer and a boolean.
It is a little overkill to make a separate allocation
for that.
- create_regex_tables:
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::matchCharacterClass):
- yarr/YarrPattern.cpp:
(JSC::Yarr::CharacterClassConstructor::charClass):
- yarr/YarrPattern.h:
(CharacterClass):
(JSC::Yarr::CharacterClass::CharacterClass):
- 7:38 PM Changeset in webkit [148258] by
-
- 3 edits12 adds in trunk
Selection gaps don't repaint correctly with transforms
https://bugs.webkit.org/show_bug.cgi?id=111000
Patch by Shezan Baig <Shezan Baig> on 2013-04-11
Reviewed by Simon Fraser.
Source/WebCore:
When computing offsetFromRepaintContainer, we need to add UseTransforms
to the MapCoordinateFlags argument. Note that ApplyContainerFlip is
the default value for the flag, so this change effectively only adds
the UseTransforms flag.
Tests: fast/repaint/selection-gap-absolute-child.html
fast/repaint/selection-gap-fixed-child.html
fast/repaint/selection-gap-flipped-absolute-child.html
fast/repaint/selection-gap-flipped-fixed-child.html
fast/repaint/selection-gap-transformed-absolute-child.html
fast/repaint/selection-gap-transformed-fixed-child.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGapRectsForRepaint):
LayoutTests:
- fast/repaint/selection-gap-absolute-child-expected.txt: Added.
- fast/repaint/selection-gap-absolute-child.html: Added.
- fast/repaint/selection-gap-fixed-child-expected.txt: Added.
- fast/repaint/selection-gap-fixed-child.html: Added.
- fast/repaint/selection-gap-flipped-absolute-child-expected.txt: Added.
- fast/repaint/selection-gap-flipped-absolute-child.html: Added.
- fast/repaint/selection-gap-flipped-fixed-child-expected.txt: Added.
- fast/repaint/selection-gap-flipped-fixed-child.html: Added.
- fast/repaint/selection-gap-transformed-absolute-child-expected.txt: Added.
- fast/repaint/selection-gap-transformed-absolute-child.html: Added.
- fast/repaint/selection-gap-transformed-fixed-child-expected.txt: Added.
- fast/repaint/selection-gap-transformed-fixed-child.html: Added.
- 6:43 PM Changeset in webkit [148257] by
-
- 21 edits in trunk/Source
Add more type validation to debug builds
https://bugs.webkit.org/show_bug.cgi?id=114478
Reviewed by Mark Hahnenberg.
Source/WebCore:
Add a bunch more type checks to the JS DOM bindings.
- Modules/mediastream/MediaStream.idl:
- Modules/webaudio/AudioDestinationNode.idl:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMBinding.h:
(WebCore::getExistingWrapper):
(WebCore):
(WebCore::createNewWrapper):
- bindings/scripts/CodeGeneratorJS.pm:
(GetNativeTypeForConversions):
(GetGnuVTableRefForInterface):
(GetGnuVTableNameForInterface):
(GetGnuMangledNameForInterface):
(GetGnuVTableOffsetForType):
(GetWinVTableRefForInterface):
(GetWinVTableNameForInterface):
(GetWinMangledNameForInterface):
(GetNamespaceForInterface):
(GetImplementationLacksVTableForInterface):
(GetSkipVTableValidationForInterface):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- dom/Clipboard.idl:
- dom/DOMStringMap.idl:
- dom/MutationRecord.idl:
- dom/NodeList.idl:
- html/DOMTokenList.idl:
- html/track/TextTrack.idl:
- inspector/ScriptProfileNode.idl:
- storage/Storage.idl:
- xml/XPathNSResolver.idl:
Source/WTF:
Add BINDING_VALIDATION flag and make RELEASE_ASSERT use UNLIKELY.
- wtf/Assertions.h:
- wtf/Platform.h:
- 5:50 PM Changeset in webkit [148256] by
-
- 12 edits1 delete in trunk/Source/WebCore
Remove ResourceLoadInfo
https://bugs.webkit.org/show_bug.cgi?id=113302
Reviewed by Benjamin Poulain.
Co-authored by Christophe Dumez.
Removed ResourceLoadInfo since it had been only used by Chromium port.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForResourceResponse):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously):
- platform/network/ResourceLoadInfo.h: Removed.
- platform/network/ResourceResponseBase.cpp:
(WebCore):
(WebCore::ResourceResponseBase::reportMemoryUsage):
- platform/network/ResourceResponseBase.h:
(ResourceResponseBase):
- 5:50 PM Changeset in webkit [148255] by
-
- 2 edits in trunk/LayoutTests
Remove passing test expectations for ietestcenter/css3/grid/grid-items-003.htm since it started failing on
Mountain Lion WebKit2 bots after a slave reboot as well.
- platform/mac-wk2/TestExpectations:
- 5:47 PM Changeset in webkit [148254] by
-
- 4 edits in trunk/Source
Submission Notes.
- 5:39 PM Changeset in webkit [148253] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r146956): ASSERTion failure: WebKit::WebProcess::pageWillLeaveWindow
https://bugs.webkit.org/show_bug.cgi?id=114481
<rdar://problem/13534784>
Reviewed by Simon Fraser.
Inform the WebProcess of WebPages which are already in a window when created.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- 5:20 PM Changeset in webkit [148252] by
-
- 2 edits in trunk/Source/WebCore
Another Mac Lion build fix attempt after r148197.
- page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
- 5:08 PM Changeset in webkit [148251] by
-
- 3 edits2 adds in trunk
Unable to paste twice in input field when specific CSS present
https://bugs.webkit.org/show_bug.cgi?id=108675
Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2013-04-11
Reviewed by Ryosuke Niwa.
Source/WebCore:
When we are pre-rendering text in ReplaceSelectionCommand, we shouldn't care
whether the content is clipped by its ancestors or not. This bug was caused
by the fact the plainText() method returned an empty string because the text
was fully clipped by its ancestors. Make plainText ignore style visibility.
Test: editing/inserting/insert-text-into-text-field.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
LayoutTests:
- editing/inserting/insert-text-into-text-field-expected.txt: Added.
- editing/inserting/insert-text-into-text-field.html: Added.
- 4:55 PM Changeset in webkit [148250] by
-
- 8 edits in trunk/Source/WebKit2
Add support for clearing storage areas
https://bugs.webkit.org/show_bug.cgi?id=114479
Reviewed by Beth Dakin.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::StorageArea):
Store the quota size so we can recreate the underlying StorageMap when clearing.
(WebKit::StorageManager::StorageArea::clear):
Create a new storage map and dispatch events.
(WebKit::StorageManager::clear):
Find the right storage area and call clear.
- UIProcess/Storage/StorageManager.messages.in:
Add Clear message.
- WebProcess/Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::clear):
Call the storage map.
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::clear):
Reset the cached values and send a clear message.
(WebKit::StorageAreaMap::resetValues):
New helper function.
(WebKit::StorageAreaMap::didClear):
New stub.
- WebProcess/Storage/StorageAreaMap.messages.in:
Add DidClear message.
- 4:51 PM Changeset in webkit [148249] by
-
- 4 edits in trunk/Source/WebKit2
WebKit should set the header and footer layers' contentsScale when the device
scale factor changes
https://bugs.webkit.org/show_bug.cgi?id=114471
-and corresponding-
<rdar://problem/13621288>
Reviewed by Simon Fraser.
Update the header and footer contentsScale when the device scale factor has
changed.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setDeviceScaleFactor):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::updateHeaderAndFooterLayersForDeviceScaleChange):
- 4:46 PM Changeset in webkit [148248] by
-
- 2 edits in trunk
[GTK] Webkit fails to build with MinGW compiler after changeset 146468
https://bugs.webkit.org/show_bug.cgi?id=114473
Patch by Paweł Forysiuk <tuxator@o2.pl> on 2013-04-11
Reviewed by Martin Robinson.
- Source/autotools/CheckSystemAndBasicDependencies.m4: Fix typo.
- 4:39 PM Changeset in webkit [148247] by
-
- 18 edits in trunk
[GTK] Add accelerated 2D canvas support using cairo-gl
https://bugs.webkit.org/show_bug.cgi?id=104672
Reviewed by Alejandro G. Castro.
.:
Detect that we can activate accelerated canvas when CairoGL is present and
TextureMapperGL is enabled.
- Source/autotools/FindDependencies.m4: Look for CairoGL.
- Source/autotools/PrintBuildConfiguration.m4: Print the status of accelerated canvas activation.
- Source/autotools/SetupWebKitFeatures.m4: Set the feature.
Source/WebCore:
No new tests. We do not yet have the ability to run tests against
accelerated content.
- platform/graphics/GraphicsContext.cpp:
(WebCore): We don't use the stub implementation of isAcceleratedContext any longer.
- platform/graphics/ImageBuffer.cpp:
(WebCore): Ditto for ImageBuffer::platformLayer.
- platform/graphics/cairo/GLContext.h:
(GLContext): Added method to get a cairo_device_t from the context.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::isAcceleratedContext): Return true when we are a CairoGL surface.
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData): Initialize the size and the texture to 0.
(WebCore::createCairoGLSurface): Added this helper.
(WebCore::ImageBuffer::ImageBuffer): When we are in accelerated rendering mode, create
a CairoGL surface.
(WebCore::ImageBuffer::platformTransformColorSpace): Do not implement this for accelerated
contexts yet.
(WebCore::mapSurfaceToImage): Added this helper, since we don't require Cairo 1.12 yet,
which provides an builtin implementation.
(WebCore::unmapSurfaceFromImage): Ditto.
(WebCore::getImageData): Map the surface to an image surface first.
(WebCore::ImageBuffer::putByteArray): Ditto.
(WebCore::ImageBufferData::paintToTextureMapper): Connect the accelerated canvas into the
TextureMapper infrastructure.
(WebCore::ImageBuffer::platformLayer): This lets the TextureMapper at the ImageBufferData.
- platform/graphics/cairo/ImageBufferDataCairo.h:
(ImageBufferData): Subclass TexturMapperPlatformLayer where appropriate.
- platform/graphics/egl/GLContextEGL.cpp: Added implementation of cairoDevice.
- platform/graphics/egl/GLContextEGL.h: Ditto.
- platform/graphics/glx/GLContextGLX.cpp: Ditto
- platform/graphics/glx/GLContextGLX.h: Ditto.
Tools:
Since the value of ACCELERATED_2D_CANVAS relies on some somewhat unusual
dependencies, don't override value of the setting determined by configure.
This will make it easier for people using build-webkit, but not the
WebKit JHBuild.
- Scripts/webkitdirs.pm:
(buildAutotoolsProject): Add a blacklist for settings to never override.
- gtk/jhbuild.modules: Build CairoGL.
- 4:31 PM Changeset in webkit [148246] by
-
- 2 edits in trunk/Tools
build.webkit.org should link to webkit-queues instead of webkit-commit-queue
https://bugs.webkit.org/show_bug.cgi?id=114477
Reviewed by Benjamin Poulain.
- BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- 4:26 PM Changeset in webkit [148245] by
-
- 10 edits in trunk/Source
Implement removing storage area items
https://bugs.webkit.org/show_bug.cgi?id=114472
Reviewed by Beth Dakin.
Source/WebCore:
Export StorageMap::removeItem.
- WebCore.exp.in:
Source/WebKit2:
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::setItem):
Rename connection to sourceConnection.
(WebKit::StorageManager::StorageArea::removeItem):
Remove the item from the map and dispatch events if needed.
(WebKit::StorageManager::removeItem):
Find the right storage area, remove the item and send back a DidRemoveItem message.
- UIProcess/Storage/StorageManager.messages.in:
Add RemoveItem message.
- WebProcess/Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::removeItem):
Call StorageAreaMap::removeItem.
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::removeItem):
Send a RemoveItem message to the storage manager.
(WebKit::StorageAreaMap::didRemoveItem):
Add empty stub.
- WebProcess/Storage/StorageAreaMap.messages.in:
Add DidRemoveItem message.
- 4:25 PM Changeset in webkit [148244] by
-
- 5 edits1 add in trunk
TextTrackList's .onremovetrack is missing from IDL
https://bugs.webkit.org/show_bug.cgi?id=103421
Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-11
Reviewed by Eric Carlson.
Source/WebCore:
Fixed test media/track/opera/interfaces/TextTrackList/onremovetrack.html
- html/track/TextTrackList.cpp:
(TextTrackList::remove):
(TextTrackList::scheduleRemoveTrackEvent):
- html/track/TextTrackList.h:
(TextTrackList):
- html/track/TextTrackList.idl:
LayoutTests:
- media/track/opera/interfaces/TextTrackList/onremovetrack-expected.txt: Added.
- 4:24 PM WebKit Team edited by
- added my irc handles and new employer (diff)
- 4:20 PM Changeset in webkit [148243] by
-
- 2 edits in trunk/Tools
Leaks builder should not be triggered upon new commits
https://bugs.webkit.org/show_bug.cgi?id=114475
Reviewed by Jessie Berlin.
Don't trigger them on new checkins wait for Mountaion Lion (Build), which already triggers
the leak builder when builds are done.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 4:18 PM WebKitGTK/2.0.x edited by
- (diff)
- 4:09 PM Changeset in webkit [148242] by
-
- 1 edit18 adds in trunk/Source/WebCore
[BlackBerry] Upstream the filesystem code
https://bugs.webkit.org/show_bug.cgi?id=114437
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-11
Reviewed by Rob Buis.
This patch contains contributions from many members of the
BlackBerry WebKit team.
- platform/blackberry/AsyncFileWriterBlackBerry.cpp: Added.
(WebCore):
(WebCore::AsyncFileWriterBlackBerry::write):
- platform/blackberry/AsyncFileWriterBlackBerry.h: Added.
(WTF):
(WTF::BlackBerry::Platform::WebFileWriter):
(WebCore):
- platform/blackberry/DOMFileSystemBlackBerry.cpp: Added.
(WebCore):
(WebCore::DOMFileSystemBase::createFileSystemURL):
(WebCore::DOMFileSystemBase::crackFileSystemURL):
(WebCore::DOMFileSystemBase::supportsToURL):
(WebCore::DOMFileSystemBase::isValidType):
- platform/blackberry/LocalFileSystemBlackBerry.cpp: Added.
(WebCore):
(WebCore::fileSystemTypeString):
(WebCore::openFileSystem):
(WebCore::LocalFileSystem::deleteFileSystem):
(WebCore::LocalFileSystem::readFileSystem):
(WebCore::LocalFileSystem::requestFileSystem):
- platform/blackberry/PlatformAsyncFileSystemCallbacks.cpp: Added.
(WebCore):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyOpenFileSystem):
(WebCore::PlatformAsyncFileSystemCallbacks::notifySucceed):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyFail):
(WebCore::getFileMetadata):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyReadMetadata):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyCreateSnapshotFileAndReadMetadata):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyReadDirectory):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyCreateFileWriter):
(WebCore::PlatformAsyncFileSystemCallbacks::createAsyncFileSystem):
(WebCore::PlatformAsyncFileSystemCallbacks::createAsyncFileWriter):
(WebCore::PlatformAsyncFileSystemCallbacks::deleteMe):
- platform/blackberry/PlatformAsyncFileSystemCallbacks.h: Added.
(WebCore):
- platform/blackberry/PlatformBlob.cpp: Added.
(WebCore):
(WebCore::PlatformBlob::nextDataItem):
- platform/blackberry/PlatformBlob.h: Added.
(WebCore):
- platform/blackberry/PlatformFileWriterClient.cpp: Added.
(WebCore):
(WebCore::PlatformFileWriterClient::notifyWrite):
(WebCore::PlatformFileWriterClient::notifyTruncate):
(WebCore::PlatformFileWriterClient::notifyFail):
- platform/blackberry/PlatformFileWriterClient.h: Added.
(WebCore):
(WTF):
(WTF::WebCore::PlatformFileWriterClient):
- platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp: Added.
(WebCore):
(WebCore::WorkerAsyncFileSystemBlackBerry::WorkerAsyncFileSystemBlackBerry):
(WebCore::WorkerAsyncFileSystemBlackBerry::~WorkerAsyncFileSystemBlackBerry):
(WebCore::WorkerAsyncFileSystemBlackBerry::waitForOperationToComplete):
(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::moveOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::copyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursivelyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readMetadataOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createFileOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::fileExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::directoryExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadataOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystem):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystem):
(WebCore::WorkerAsyncFileSystemBlackBerry::move):
(WebCore::WorkerAsyncFileSystemBlackBerry::copy):
(WebCore::WorkerAsyncFileSystemBlackBerry::remove):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursively):
(WebCore::WorkerAsyncFileSystemBlackBerry::readMetadata):
(WebCore::WorkerAsyncFileSystemBlackBerry::createFile):
(WebCore::WorkerAsyncFileSystemBlackBerry::createDirectory):
(WebCore::WorkerAsyncFileSystemBlackBerry::fileExists):
(WebCore::WorkerAsyncFileSystemBlackBerry::directoryExists):
(WebCore::WorkerAsyncFileSystemBlackBerry::readDirectory):
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriter):
(WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadata):
- platform/blackberry/WorkerAsyncFileSystemBlackBerry.h: Added.
(WebCore):
(WorkerAsyncFileSystemBlackBerry):
(WebCore::WorkerAsyncFileSystemBlackBerry::create):
- platform/blackberry/WorkerAsyncFileWriterBlackBerry.cpp: Added.
(WebCore):
(WebCore::WorkerAsyncFileWriterBlackBerry::writeOnMainThread):
(WebCore::WorkerAsyncFileWriterBlackBerry::truncateOnMainThread):
(WebCore::WorkerAsyncFileWriterBlackBerry::abortOnMainThread):
(WebCore::WorkerAsyncFileWriterBlackBerry::write):
(WebCore::WorkerAsyncFileWriterBlackBerry::truncate):
(WebCore::WorkerAsyncFileWriterBlackBerry::abort):
(WebCore::WorkerAsyncFileWriterBlackBerry::waitForOperationToComplete):
(WebCore::WorkerAsyncFileWriterBlackBerry::platformWriterClient):
- platform/blackberry/WorkerAsyncFileWriterBlackBerry.h: Added.
(WebCore):
- platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.cpp: Added.
(WebCore):
(WebCore::performTaskOnMainThread):
(WebCore::postTaskToMainThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyStop):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyOpenFileSystem):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifySucceed):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyFail):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyReadMetadata):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyReadDirectory):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyCreateFileWriter):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::createAsyncFileSystem):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::createAsyncFileWriter):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::deleteMe):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::postTaskToWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyOpenFileSystemOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifySucceedOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyFailOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyReadMetadataOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyReadDirectoryEntryOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyCreateFileWriterOnWorkerThread):
- platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.h: Added.
(WebCore):
- platform/blackberry/WorkerPlatformFileWriterClient.cpp: Added.
(WebCore):
(WebCore::WorkerPlatformFileWriterClient::notifyWriteOnWorkerThread):
(WebCore::WorkerPlatformFileWriterClient::notifyFailOnWorkerThread):
(WebCore::WorkerPlatformFileWriterClient::notifyTruncateOnWorkerThread):
(WebCore::WorkerPlatformFileWriterClient::notifyWrite):
(WebCore::WorkerPlatformFileWriterClient::notifyTruncate):
(WebCore::WorkerPlatformFileWriterClient::notifyFail):
(WebCore::WorkerPlatformFileWriterClient::postTaskToWorkerThreadIfNeeded):
- platform/blackberry/WorkerPlatformFileWriterClient.h: Added.
(WebCore):
(WTF):
(WTF::WebCore::WorkerPlatformFileWriterClient):
- 4:04 PM Changeset in webkit [148241] by
-
- 3 edits in trunk/WebKitLibraries
Build fix.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- 3:56 PM Changeset in webkit [148240] by
-
- 4 edits in trunk/WebKitLibraries
<rdar://problem/10416316> [Mac] WebSocket doesn't work with authenticating proxies
https://bugs.webkit.org/show_bug.cgi?id=114464
Update WebKitSystemInterface.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 3:17 PM Changeset in webkit [148239] by
-
- 2 edits in trunk/Source/WebCore
Mac Lion build fix attempt after r148197.
- page/scrolling/mac/ScrollingStateNodeMac.mm:
- 2:50 PM Changeset in webkit [148238] by
-
- 2 edits in trunk/Source/WebKit2
InjectedBundleNodeHandle::imageForRect doesn't respect device scale factor or highlighting option
https://bugs.webkit.org/show_bug.cgi?id=114466
<rdar://problem/13508513>
Reviewed by Simon Fraser.
Respect the device scale factor when creating the snapshot image.
Clear the snapshot image before drawing into it.
Respect SnapshotOptionsExcludeSelectionHighlighting.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::imageForRect):
- 2:42 PM Changeset in webkit [148237] by
-
- 4 edits in trunk/Source/WebCore
<rdar://problem/10416316> [Mac] WebSocket doesn't work with authenticating proxies
https://bugs.webkit.org/show_bug.cgi?id=114464
Reviewed by Brady Eidson.
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm: Updated for new wkCopyCONNECTProxyResponse signature.
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::executePACFileURL): Fixed a typo in a comment. (WebCore::SocketStreamHandle::addCONNECTCredentials): Don't crash even if the rest of the fix didn't work (which would be the case on some OS versions). (WebCore::SocketStreamHandle::readStreamCallback): Replaced most breaks with returns, because breaks were confusing in such a huge switch. Changed null proxyResponse to not be treated as authentication success, because it's not. Merged two parts of WaitingForConnect state handling for clarity. (WebCore::SocketStreamHandle::writeStreamCallback): Don't blindly assume that we can start WebSocket handshake after kCFStreamEventCanAcceptBytes. Perhaps it's nothing but a failed CONNECT, and a read callback still needs to send authentication. Without this, establishing connections was flaky. Added a check for Closed state, matching read callback.
- 2:41 PM Changeset in webkit [148236] by
-
- 3 edits2 adds in trunk
MutationRecord is not exposed
https://bugs.webkit.org/show_bug.cgi?id=114288
Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2013-04-11
Reviewed by Darin Adler.
Source/WebCore:
Expose MutationRecord on DOMWindow. This patch is copied from a patch
by Adam Klein. https://codereview.chromium.org/13861028
Test: fast/dom/MutationObserver/mutation-record-constructor.html
- page/DOMWindow.idl:
LayoutTests:
This test is copied from a patch by Adam Klein.
https://codereview.chromium.org/13861028
The test expectation of "typeof MutationRecord" is changed from
"function" to "object". (See bug 114457)
- fast/dom/MutationObserver/mutation-record-constructor-expected.txt: Added.
- fast/dom/MutationObserver/mutation-record-constructor.html: Added.
- 2:28 PM Changeset in webkit [148235] by
-
- 3 edits2 copies in branches/safari-536.30-branch
Merged r136554. <rdar://problem/13334986>
- 2:01 PM Changeset in webkit [148234] by
-
- 2 edits in trunk/Source/WebCore
Cannot scroll to footer on a page with overflow:hidden on the body
https://bugs.webkit.org/show_bug.cgi?id=114462
-and corresponding-
<rdar://problem/13530042>
Reviewed by Simon Fraser.
Add a new scenario in which we want to overrideHidden -- whenever we are the
mainFrame and there is a header or footer.
- page/FrameView.cpp:
(WebCore::FrameView::applyOverflowToViewport):
- 2:01 PM WebKitGTK/2.0.x edited by
- Added r148230 as proposed merge (diff)
- 1:57 PM WebKitGTK/2.0.x edited by
- Added r147963 as proposed merge (diff)
- 1:53 PM Changeset in webkit [148233] by
-
- 12 edits in trunk/Source
Unreviewed, rolling out r148034, r148052, r148097, and
r148194.
http://trac.webkit.org/changeset/148034
http://trac.webkit.org/changeset/148052
http://trac.webkit.org/changeset/148097
http://trac.webkit.org/changeset/148194
https://bugs.webkit.org/show_bug.cgi?id=114463
broke mutiresolution favicons, among other things (Requested
by thorton on #webkit).
Source/WebCore:
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::setIconDataForIconURL):
- loader/icon/IconDatabase.h:
(IconDatabase):
- loader/icon/IconDatabaseBase.h:
- loader/icon/IconRecord.cpp:
- loader/icon/IconRecord.h:
(IconRecord):
Source/WebKit2:
- UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::setIconDataForIconURL):
- UIProcess/WebIconDatabase.h:
(WebIconDatabase):
- UIProcess/WebIconDatabase.messages.in:
- WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
(WebKit::WebIconDatabaseProxy::setIconDataForIconURL):
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::destroy):
- 1:51 PM Changeset in webkit [148232] by
-
- 3 edits in trunk/Source/WebCore
[GTK][AC] Implement GraphicsLayerClutter::moveOrCopyAnimations
https://bugs.webkit.org/show_bug.cgi?id=114019
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-11
Reviewed by Gustavo Noronha Silva.
Fill moveOrCopyAnimations that is based on Mac port implementation.
Tests: animations/3d/change-transform-in-end-event.html
animations/3d/transform-origin-vs-functions.html
compositing/animation/state-at-end-event-transform-layer.html
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::moveOrCopyLayerAnimation):
(WebCore):
(WebCore::GraphicsLayerClutter::moveOrCopyAnimations):
- platform/graphics/clutter/GraphicsLayerClutter.h:
- 1:34 PM Changeset in webkit [148231] by
-
- 4 edits in trunk/Source
Implement StorageManager::getValues
https://bugs.webkit.org/show_bug.cgi?id=114461
Reviewed by Beth Dakin.
Source/WebCore:
Expose the item hash map.
- storage/StorageMap.h:
(WebCore::StorageMap::items):
Source/WebKit2:
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::items):
(WebKit::StorageManager::getValues):
Return the items from the right storage area.
- 1:22 PM Changeset in webkit [148230] by
-
- 2 edits in trunk/Tools
[GTK] Windows build failure after r136056
https://bugs.webkit.org/show_bug.cgi?id=114121
Patch by Kalev Lember <kalevlember@gmail.com> on 2013-04-11
Reviewed by Martin Robinson.
- TestWebKitAPI/config.h: Make sure defines are correct for other
Windows ports than apple-win.
- 1:14 PM Changeset in webkit [148229] by
-
- 3 edits in trunk/Source/WebKit2
Clean up related storage areas when a connection is destroyed
https://bugs.webkit.org/show_bug.cgi?id=114459
Reviewed by Beth Dakin.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::processWillCloseConnection):
Dispatch invalidateConnectionInternal on the work queue.
(WebKit::StorageManager::createStorageMap):
(WebKit::StorageManager::destroyStorageMap):
Rename m_storageAreas to m_storageAreasByConnection.
(WebKit::StorageManager::invalidateConnectionInternal):
Go over all known storage areas and remove this connection as a listener.
(WebKit::StorageManager::findStorageArea):
Rename m_storageAreas to m_storageAreasByConnection.
- UIProcess/Storage/StorageManager.h:
Rename m_storageAreas to m_storageAreasByConnection.
- 1:08 PM Changeset in webkit [148228] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Use the platform list of languages with fonts instead of hardcoding
https://bugs.webkit.org/show_bug.cgi?id=114452
Patch by Eli Fidler <efidler@blackberry.com> on 2013-04-11
Reviewed by Rob Buis.
BlackBerry PR 325244
Internally reviewed by Jeff Rogers
No functional change, but platform font changes won't need a WebKit change
going forward.
- page/blackberry/SettingsBlackBerry.cpp:
(WebCore::Settings::initializeDefaultFontFamilies):
- 1:05 PM Changeset in webkit [148227] by
-
- 8 edits6 adds in trunk
[CSS Shaders] Parse parameters descriptor
https://bugs.webkit.org/show_bug.cgi?id=114455
Reviewed by Dean Jackson.
Source/WebCore:
Add support for the 'parameters' descriptor in the filter at-rule to support
parameterization of CSS Shaders.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-parameters
Tests: css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid.html
css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp: Added 'parameters' property and fail parsing if not inside
of an @filter rule.
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFilterRuleParameters): New helper function to verify
values.
(WebCore):
- css/CSSParser.h:
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in: Added new property name 'parameters'.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
LayoutTests:
Tests for the 'parameters' descriptor on @filter rule.
- css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid-expected.txt: Added.
- css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid.html: Added.
- css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid-expected.txt: Added.
- css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid.html: Added.
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-invalid.js: Added.
(testInvalidParametersProperty):
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-valid.js: Added.
(testParametersProperty):
- 1:01 PM Changeset in webkit [148226] by
-
- 2 edits in trunk/PerformanceTests/SunSpider
Get rid of the 10ms delay between test executions
https://bugs.webkit.org/show_bug.cgi?id=114458
<rdar://problem/13631112>
Reviewed by Darin Adler and Geoffrey Garen.
More details on this in the bug. Long story short, I don't know why the 10ms delay is
there, and it appears to be the root of some noisyness and unreliability in the results.
Removing it makes results more consistent, which is a good thing.
- resources/driver-TEMPLATE.html:
- 12:56 PM Changeset in webkit [148225] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Initial scale changes depending on the order of page navigations
https://bugs.webkit.org/show_bug.cgi?id=114448
Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
PR: 323941
During page transitions, absoluteVisibleOverflowSize() and contentsSize()
in fixedLayoutSize() were based on the old page when we just started or
committed provisinal load. In that case, fixedLayoutSize() is very old
page dependent and can cause inconsistent behaviors. For example, if
the old page contents width is 4000, we will get DEFAULT_MAX_LAYOUT_WIDTH 1024
as the new page's fixedLayoutSize; however, we will get 768 if we
navigate to the new page directly.
To fix that, return default layout size if the page doesn't have
virtual viewport and m_loadState is Provisional.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
- 12:37 PM Changeset in webkit [148224] by
-
- 2 edits in trunk/Source/WebCore
Default Implementation of toString for NPObject shouldn't return NPClass & NPObject address as String
https://bugs.webkit.org/show_bug.cgi?id=114450
Patch by Arunprasad Rajkumar <arunprasadr@nds.com> on 2013-04-11
Reviewed by Anders Carlsson.
- bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::stringValue):
- 12:17 PM Changeset in webkit [148223] by
-
- 3 edits2 adds in trunk
REGRESSION (142152): ensure we skip past out-of-flow objects when detecting whitespace to ignore after leading empty inlines
https://bugs.webkit.org/show_bug.cgi?id=114311
Reviewed by Emil A Eklund.
Source/WebCore:
When we hit an empty inline in line layout and try to detect whether it has any whitespace after it that we ought to ignore, then
we need to skip past out-of-flow and floating objects when looking for that whitespace. Failure to do so will result in us
adding the width from the first space we encounter to our line width and over-estimating the real width of the line.
We're hitting this bug now because we have broadened the category of empty inlines that get lineboxes so we go into line layout
and have to deal with them and their subsequent whitespace there. Previously this sort of whitespace would have been simply
consumed by |skipLeadingWhitespace|.
Test: fast/inline/out-of-flow-objects-and-whitespace-after-empty-inline.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::shouldSkipWhitespaceAfterStartObject):
LayoutTests:
- fast/inline/out-of-flow-objects-and-whitespace-after-empty-inline-expected.txt: Added.
- fast/inline/out-of-flow-objects-and-whitespace-after-empty-inline.html: Added.
- 12:14 PM Changeset in webkit [148222] by
-
- 2 edits in trunk/Tools
Remove myself from watchlists.
- Scripts/webkitpy/common/config/watchlist:
- 11:56 AM Changeset in webkit [148221] by
-
- 18 edits in trunk
Autocorrected text doesn't have a marker of type autocorrected
https://bugs.webkit.org/show_bug.cgi?id=114337
Reviewed by Darin Adler.
Source/WebCore:
The bug was caused by markAndReplaceFor's text replacement errornously assuming that there are
no other text checking result starting at the same offset. That resulted in us adjusting location
offsets of the subsequent results pointing at the replaced text, hit an assertion, and blow up.
Fixed the bug by skipping all remaining results for the replaced text since they're no longer
applicable.
Tests: Existing autocorection tests have been updated to assert new behavior.
- editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):
LayoutTests:
Updated tests to assert the existence of "autocorrected" markers.
- platform/mac/editing/spelling/click-autocorrected-word-expected.png:
- platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/click-autocorrected-word.html:
- platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
- platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/delete-into-autocorrected-word.html:
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png:
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html:
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png:
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html:
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png:
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html:
- 11:54 AM Changeset in webkit [148220] by
-
- 8 edits6 adds in trunk
[CSS Shaders] Parse the geometry descriptor
https://bugs.webkit.org/show_bug.cgi?id=110815
Source/WebCore:
Added initial parsing for the "geometry" descriptor, as per specification:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#geometry
This descriptor allows to specify the mesh geometry for custom filters.
Reviewed by Dirk Schulze.
Tests: css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-invalid.html
css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGeometry): New method that parses the geometry
descriptor (grid()).
(WebCore):
- css/CSSParser.h:
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in: Added conditional "geometry" property.
- css/CSSValueKeywords.in: Added conditional "attached" value keyword; detached
was already there.
LayoutTests:
Positive and negative parsing tests for the "geometry" descriptor as
per specification:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#geometry
Reviewed by Dirk Schulze.
- css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-invalid-expected.txt: Added.
- css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-invalid.html: Added.
- css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid-expected.txt: Added.
- css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid.html: Added.
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-geometry-property-invalid.js: Added.
(testInvalidGeometryProperty):
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-geometry-property-valid.js: Added.
(testGeometryProperty):
- 11:43 AM Changeset in webkit [148219] by
-
- 6 edits in trunk/Source
Make StorageAreaMap dispatch session storage events
https://bugs.webkit.org/show_bug.cgi?id=114454
Reviewed by Beth Dakin.
Source/WebCore:
Export storage symbols and headers needed by WebKit2.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit2:
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::dispatchStorageEvent):
Depending on the storage area type, call dispatchSessionStorageEvent or dispatchLocalStorageEvent.
(WebKit::StorageAreaMap::dispatchSessionStorageEvent):
Enumerate all the frames in our page and dispatch the event to the relevant ones.
(WebKit::StorageAreaMap::dispatchLocalStorageEvent):
Add empty stub for now.
- 11:39 AM Changeset in webkit [148218] by
-
- 2 edits in trunk
Unreviewed.
- Source/autotools/symbols.filter: Stop exporting redundant symbols.
- 11:27 AM Changeset in webkit [148217] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Removing expectations for a bunch of tests that are passing.
- 11:19 AM Changeset in webkit [148216] by
-
- 2 edits in trunk/Tools
Build fix. Don't hard-code queues.webkit.org at least during the transition.
- QueueStatusServer/templates/statusbubble.html:
- 10:44 AM Changeset in webkit [148215] by
-
- 9 edits in trunk/Source/WebKit2
Implement more logic in StorageAreaMap
https://bugs.webkit.org/show_bug.cgi?id=114451
Reviewed by Alexey Proskuryakov.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add new overload.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::addListener):
(WebKit::StorageManager::StorageArea::removeListener):
These take storage map IDs.
(WebKit::StorageManager::StorageArea::setItem):
Rename storageAreaID to sourceStorageAreaID.
(WebKit::StorageManager::StorageArea::dispatchEvents):
Remove the code that would not dispatch to the source connection, there may still be storage areas interested in those events.
(WebKit::StorageManager::setItem):
This now takes the source storage area ID.
(WebKit::StorageManager::findStorageArea):
This takes a storage map ID.
- UIProcess/Storage/StorageManager.messages.in:
SetItem now takes the source storage area ID as well.
- WebProcess/Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::setItem):
Pass the source frame to StorageAreaMap::setItem.
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::StorageAreaMap):
Send CreateStorageMap and add the object as a message receiver.
(WebKit::StorageAreaMap::~StorageAreaMap):
Send DestroyStorageMap and remove the object as a message receiver.
(WebKit::StorageAreaMap::length):
(WebKit::StorageAreaMap::key):
(WebKit::StorageAreaMap::item):
(WebKit::StorageAreaMap::contains):
Load values and forward calls to the storage map.
(WebKit::StorageAreaMap::setItem):
This now takes the source frame as well. Update the local storage map and send a SetItem message.
(WebKit::StorageAreaMap::loadValuesIfNeeded):
Get the values from the storage manager.
(WebKit::StorageAreaMap::dispatchStorageEvent):
This now takes the source storage area ID.
- WebProcess/Storage/StorageAreaMap.messages.in:
DispatchStorageEvent now takes the source storage area ID.
- 10:18 AM Changeset in webkit [148214] by
-
- 5 edits in trunk
Web/Plugin process deadlock initializing async plugins.
<rdar://problem/13525232> and https://bugs.webkit.org/show_bug.cgi?id=114217
Rubberstamped by Anders Carlsson.
Rollout r147953 and r147968 as we identified other causes for this.
Source/WebKit2:
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPluginAsynchronously):
- WebProcess/Plugins/PluginProxy.messages.in:
LayoutTests:
- platform/mac-wk2/TestExpectations:
- 10:02 AM Changeset in webkit [148213] by
-
- 2 edits in trunk/LayoutTests
[WK2] Run toString & valueOf LayoutTests for WebKit2 also
https://bugs.webkit.org/show_bug.cgi?id=114433
Patch by Arunprasad Rajkumar <arunprasadr@nds.com> on 2013-04-11
Reviewed by Anders Carlsson.
- platform/wk2/TestExpectations:
- 9:55 AM Changeset in webkit [148212] by
-
- 2 edits in trunk/Tools
Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114397
Reviewed by Benjamin Poulain.
Reland the patch since Alan appears to have finished the migration.
- Scripts/webkitpy/common/net/statusserver.py:
(StatusServer):
- 9:52 AM Changeset in webkit [148211] by
-
- 2 edits in trunk/Source/WebCore
handleMouseMoveEvent should let hit-testing hit-test scrollbars
https://bugs.webkit.org/show_bug.cgi?id=114430
Reviewed by Antonio Gomes.
Allow hit-testing to hit-test frame scrollbars so handleMouseMoveEvent
does not have to do it itself.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent):
- 9:38 AM Changeset in webkit [148210] by
-
- 7 edits2 adds in trunk
[Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
https://bugs.webkit.org/show_bug.cgi?id=76796
Patch by Brian Holt <brian.holt@samsung.com> on 2013-04-11
Reviewed by Chris Fleizach.
Source/WebCore:
When using caret-browsing with the right and left arrows, the
behaviour of menuLists should be the same as listBoxes. This means
not default-handling the event and passing it up the stack instead.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
Tools:
Make the Gtk window for the DRT a toplevel so that it gets the
focus from the window manager when the test starts.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(main):
LayoutTests:
Adding a new test to verify that it is possible to arrow out of
combo boxes when caret browsing is enabled. Updated failing tests
to reflect changed accessibility events in the DRT.
- platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Updated.
- platform/gtk/accessibility/caret-browsing-select-focus-expected.txt: Added.
- platform/gtk/accessibility/caret-browsing-select-focus.html: Added.
- platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Updated.
- 9:32 AM Changeset in webkit [148209] by
-
- 17 edits in trunk/Source
Remove some ResourceHandle.h includes
https://bugs.webkit.org/show_bug.cgi?id=114416
Reviewed by Ryosuke Niwa.
Source/WebCore:
- loader/CrossOriginAccessControl.h:
- loader/CrossOriginPreflightResultCache.h:
These files don't need ResourceHandle.h, just ResourceHandleTypes.h.
- loader/TextTrackLoader.cpp:
- loader/ThreadableLoader.h:
- loader/appcache/ApplicationCacheGroup.h:
- loader/cache/MemoryCache.h:
- loader/mac/ResourceLoaderMac.mm:
- page/Settings.cpp:
- platform/network/AuthenticationChallengeBase.cpp:
- platform/network/cf/CookieJarCFNet.cpp:
- platform/network/cf/ResourceRequestCFNet.cpp:
- xml/XSLTProcessorLibxslt.cpp:
- xml/parser/XMLDocumentParser.cpp:
- xml/parser/XMLDocumentParserLibxml2.cpp:
Just straightforward removal of includes.
Source/WebKit2:
- WebProcess/Network/NetworkProcessConnection.cpp: Added an include that is now
necessary.
- 9:19 AM Changeset in webkit [148208] by
-
- 9 edits in trunk
Use CSS4 image-rendering to determing image scaling quality
https://bugs.webkit.org/show_bug.cgi?id=113405
Reviewed by Simon Fraser.
Source/WebCore:
Implement the new CSS4 image-rendering property values.
Image scaling now uses low-quality (pixelated) scaling for
crisp-edges, pixelated and optimizeSpeed values, and always
use high quality (smooth) scaling for -webkit-smooth and
optimizeQuality. The latter can be used to disable low quality
scaling during CSS animations or live resizing.
The new values are protected with a new CSS4_IMAGES feature, but
the crisp-edge value has been introduced before to displace the
deprecated -webkit-optimize-contrast value, and optimizeSpeed
and optimizeQuality values are supported for SVG compatibility.
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EImageRendering):
- css/CSSValueKeywords.in:
- rendering/RenderBoxModelObject.cpp:
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::paintReplaced):
- rendering/style/RenderStyleConstants.h:
Tools:
Introduce new flag to enable experimental support for CSS4 Images.
- Scripts/webkitperl/FeatureList.pm:
- 9:19 AM Changeset in webkit [148207] by
-
- 2 edits in trunk/Source/JavaScriptCore
Added UNLIKELY() suggested in https://bugs.webkit.org/show_bug.cgi?id=114366
after checking in the original change.
Rubber-stamped by Jessie Berlin.
- dfg/DFGOperations.cpp:
- 9:02 AM Changeset in webkit [148206] by
-
- 2 edits in trunk/Source/WebCore
Build fix: use of uninitialized variable in ScrollingStateTree
https://bugs.webkit.org/show_bug.cgi?id=114443
Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-04-11
Reviewed by Anders Carlsson.
Initialize pointer to zero before use, fixes build.
No new tests, no changes on behavior.
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachNode):
- 8:55 AM Changeset in webkit [148205] by
-
- 8 edits6 adds in trunk
[CSS Shaders] Parse mix descriptor
https://bugs.webkit.org/show_bug.cgi?id=114414
Reviewed by Antti Koivisto.
Source/WebCore:
Add support for the 'mix' descriptor in the filter at-rule to support blend modes
and composite operators in CSS Shaders.
Each pixel in the fragment shader will be blended and composited with the
backdrop by taking these values into account.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-mix
Tests: css3/filters/custom-with-at-rule-syntax/parsing-mix-property-invalid.html
css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp: Added 'mix' property and fail parsing if not inside
of an @filter rule.
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFilterRuleMix): New helper function to verify
values.
(WebCore):
- css/CSSParser.h:
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in: Added new property name 'mix'.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
LayoutTests:
Tests for the 'mix' descriptor on @filter rule.
- css3/filters/custom-with-at-rule-syntax/parsing-mix-property-invalid-expected.txt: Added.
- css3/filters/custom-with-at-rule-syntax/parsing-mix-property-invalid.html: Added.
- css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid-expected.txt: Added.
- css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid.html: Added.
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-mix-property-invalid.js: Added.
(testInvalidMixProperty):
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-mix-property-valid.js: Added.
(testMixProperty):
- 8:09 AM Changeset in webkit [148204] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
[Qt][Mac] Linking fails with Qt 5.1
https://bugs.webkit.org/show_bug.cgi?id=114435
Reviewed by Tor Arne Vestbø.
Qt 5.1 enables C++11 by default when using clang on Mac
and links against the libc++ standard library. As a result
building the QtWebKit shared library fails when linking
agains the ANGLE intermediate static library because libc++
misses some symbols needed by ANGLE.
Disable C++11 for the ANGLE intermediate library to fix the build.
- ANGLE.pri:
- 7:51 AM Changeset in webkit [148203] by
-
- 5 edits in trunk
Parent box with background-size auto and gradient image does not get properly repainted when child box is resized.
https://bugs.webkit.org/show_bug.cgi?id=114424
Source/WebCore:
Patch by Zalan Bujtas <Alan Bujtas> on 2013-04-11
Reviewed by Antti Koivisto.
Initiate full repaint on fill layer, when the image is generated and the background
property defines auto size.
http://www.w3.org/TR/css3-background/#background-size
'If the image has neither an intrinsic width nor an intrinsic height, its size is determined as for 'contain'.'
Extended fast/repaint/background-shorthand-with-gradient-and-height-changes.html
to cover this case too.
- rendering/RenderObject.cpp:
(WebCore::mustRepaintFillLayers):
LayoutTests:
Patch by Zalan Bujtas <Alan Bujtas> on 2013-04-11
Reviewed by Antti Koivisto.
- fast/repaint/background-shorthand-with-gradient-and-height-changes-expected.txt:
- fast/repaint/background-shorthand-with-gradient-and-height-changes.html:
- 7:42 AM Changeset in webkit [148202] by
-
- 2 edits in trunk/Source/WebCore
[GTK][AC] use a smart pointer for GList and ClutterCanvas
https://bugs.webkit.org/show_bug.cgi?id=114057
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-11
Reviewed by Gustavo Noronha Silva.
We can make simple code & prevent possible memory leak by using a proper smart pointer.
Especially if we get children by clutter_actor_get_children, we should free it after using.
No functionality changed.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorUpdateTexture):
(graphicsLayerActorRemoveAll):
- 7:36 AM Changeset in webkit [148201] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry][CSS Filters] Blur filter fails to recompute blur size when layer size changes
https://bugs.webkit.org/show_bug.cgi?id=114272
Reviewed by Rob Buis.
Blur appeared blocky or pixelated when surface changed size after
creating the filter actions. The initial image size was used to
determine the blur size (expressed in texture coordinate system).
Fixed by recomputing the blur size when the surface size changes, using
a new Uniform1f subclass that can use a functor to compute the uniform
value per-frame.
This fixes css3/filters/effect-blur-hw.html. This can only be verified
by manual inspection because the BlackBerry port is not currently using
pixel tests.
PR 323730
- platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore):
(SurfaceFunctor):
(WebCore::SurfaceFunctor::SurfaceFunctor):
(InverseSurfaceWidth):
(WebCore::InverseSurfaceWidth::InverseSurfaceWidth):
(WebCore::InverseSurfaceWidth::operator()):
(InverseSurfaceHeight):
(WebCore::InverseSurfaceHeight::InverseSurfaceHeight):
(WebCore::LayerFilterRenderer::actionsForOperations):
- platform/graphics/blackberry/LayerFilterRenderer.h:
(Uniform1f):
(WebCore):
(Uniform1fWithFunctor):
(WebCore::Uniform1fWithFunctor::create):
(WebCore::Uniform1fWithFunctor::Uniform1fWithFunctor):
(WebCore::Uniform1fWithFunctor::apply):
(WebCore::Uniform1f::createWithFunctor):
- 7:28 AM Changeset in webkit [148200] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] Accelerated compositing debug rectangle incorrectly drawn for layers with surfaces
https://bugs.webkit.org/show_bug.cgi?id=114275
Reviewed by Carlos Garcia Campos.
The drawDebugBorder method was updated to mirror the logic in
compositeLayersRecursive, i.e. if we're compositing a surface to the
screen, use the transformed bounds stored in the surface. The bounds
stored in the layer should only be used when drawing the layer to the
surface.
Speaking of which, also update the code to skip border drawing when
drawing a layer to a surface. Drawing the borders inside the surface
would only result in messing up the surface contents, especially when
CSS filters like blur were the reason for having a surface in the first
place - the border would be blurred and hard to discern.
Only manually testable, the debug border is disabled during layout
tests.
PR 323746
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::drawDebugBorder):
- platform/graphics/blackberry/LayerRendererSurface.cpp:
(WebCore::LayerRendererSurface::drawRect):
(WebCore::LayerRendererSurface::transformedBounds): Added.
(WebCore):
- platform/graphics/blackberry/LayerRendererSurface.h:
(LayerRendererSurface):
- 7:27 AM Changeset in webkit [148199] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Compiler warning in LayerWebKitThread.cpp
https://bugs.webkit.org/show_bug.cgi?id=114277
Reviewed by Carlos Garcia Campos.
All the relevant WTF::Vector APIs use size_t, storing the position in
an int resulted in a compiler warning. Fixed by switching to size_t.
No change in behavior, no new tests.
PR 323753
- platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::remove):
(WebCore::LayerWebKitThread::replaceSublayer):
- 6:39 AM WebKitGTK/2.0.x edited by
- (diff)
- 6:36 AM Changeset in webkit [148198] by
-
- 3 edits8 adds in releases/WebKitGTK/webkit-2.0
Merge r148182 - FrameLoaderClient::assignIdentifierToInitialRequest() not called for the main resource when loaded from the memory cache
https://bugs.webkit.org/show_bug.cgi?id=112418
Source/WebCore:
Reviewed by Darin Adler.
When the main resource is loaded from the memory cache the
response is not added to the ResponseVector of the document
loader, so that when committing the provisional load the remaining
delegate messages are not called because the ResponseVector of the
document loader is empty. When the main resource is loaded from
the memory cache, there's no resource loader, and the client is
notified about the response received using
ResourceLoadNotifier::dispatchDidReceiveResponse() directly
instead of ResourceLoadNotifier::didReceiveResponse() which is the
one adding the response to the ResponseVector of the document
loader. So, the problem can be fixed by adding the response to the
ResponseVector before calling dispatchDidReceiveResponse() when
loading the main resource without a resource loade
Test: loader/go-back-cached-main-resource.html
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
LayoutTests:
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-11
Reviewed by Darin Adler.
- loader/go-back-cached-main-resource-expected.txt: Added.
- loader/go-back-cached-main-resource.html: Added.
- loader/resources/first-page.html: Added.
- loader/resources/other-page.html: Added.
- platform/gtk-wk1/loader/go-back-cached-main-resource-expected.txt: Added.
- platform/wk2/loader/go-back-cached-main-resource-expected.txt: Added.
- 6:16 AM Changeset in webkit [148197] by
-
- 15 edits2 adds in trunk/Source/WebCore
[CoordinatedGraphics] Use ScrollingStateTree to handle fixed elements positioning while scrolling
https://bugs.webkit.org/show_bug.cgi?id=114353
Reviewed by Noam Rosenthal.
ScrollingCoordinatorCoordinatedGraphics should implement threaded scrolling interface and
re-use threaded scrolling approach (ScrollingStateTree and ViewportConstraints) to handle
fixed/sticky elements positioning while scrolling. The rationals are below.
Before the change ScrollingCoordinatorCoordinatedGraphics was implementing Chromium-specific
interface which is going to be removed eventually as there is no ScrollingCoordinatorChromium
existing.
Tested by existing manual tests (fixed-position.html for example.
- CMakeLists.txt:
- Target.pri:
Included ScrollingStateTree files.
- page/scrolling/ScrollingStateFixedNode.cpp:
- page/scrolling/ScrollingStateFixedNode.h:
- page/scrolling/ScrollingStateNode.cpp:
- page/scrolling/ScrollingStateNode.h:
- page/scrolling/ScrollingStateScrollingNode.cpp:
- page/scrolling/ScrollingStateScrollingNode.h:
- page/scrolling/ScrollingStateStickyNode.cpp:
- page/scrolling/ScrollingStateStickyNode.h:
- page/scrolling/ScrollingStateTree.cpp:
- page/scrolling/ScrollingStateTree.h:
Removed ENABLE(THREADED_SCROLLING) code guards.
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
(WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::~ScrollingCoordinatorCoordinatedGraphics):
(WebCore):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::attachToStateTree):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::detachFromStateTree):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::clearStateTree):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::updateViewportConstrainedNode):
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
ScrollingCoordinatorCoordinatedGraphics is using threaded scrolling approach to handle fixed
elements positioning while scrolling.
(WebCore):
(ScrollingCoordinatorCoordinatedGraphics):
- page/scrolling/coordinatedgraphics/ScrollingStateNodeCoordinatedGraphics.cpp: Added.
(WebCore):
(WebCore::ScrollingStateNode::platformScrollLayer):
(WebCore::ScrollingStateNode::setScrollPlatformLayer):
(WebCore::ScrollingStateNode::setScrollLayer):
- page/scrolling/coordinatedgraphics/ScrollingStateScrollingNodeCoordinatedGraphics.cpp: Added.
(WebCore):
(WebCore::ScrollingStateScrollingNode::counterScrollingPlatformLayer):
(WebCore::ScrollingStateScrollingNode::setCounterScrollingLayer):
- 5:49 AM Changeset in webkit [148196] by
-
- 1 edit1 delete in trunk/LayoutTests
[Qt] Unreviewed gardening. Remove platform specific expected after r148195.
- platform/qt/fast/events/backspace-navigates-back-expected.txt: Removed.
- 4:46 AM Changeset in webkit [148195] by
-
- 7 edits in trunk/Source
[Qt] EventHandler should handle Space and BackSpace
https://bugs.webkit.org/show_bug.cgi?id=114428
Reviewed by Jocelyn Turcotte.
Source/WebCore:
Enable default space-handling for Qt.
- page/EventHandler.cpp:
Source/WebKit/qt:
Remove our own handling of space and backspace.
- WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::handleScrolling):
- WidgetApi/qwebpage.cpp:
(QWebPagePrivate::keyPressEvent):
Source/WebKit2:
Remove our own handling of space and backspace.
- WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
- 4:37 AM Changeset in webkit [148194] by
-
- 2 edits in trunk/Source/WebCore
IconDatabase: Simplify boolean logic in assertion.
https://bugs.webkit.org/show_bug.cgi?id=114425
Reviewed by Andreas Kling.
Follow-up to r148097; drop the overzealous use of !! to turn a
PassRefPtr into a boolean.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::updateIconRecord):
- 4:28 AM Changeset in webkit [148193] by
-
- 2 edits4 adds in trunk/LayoutTests
[Qt] Unreviewed gardending. Greening bots.
- 4:11 AM Changeset in webkit [148192] by
-
- 14 edits in trunk/Source
[BlackBerry] LayerTexture refactoring
https://bugs.webkit.org/show_bug.cgi?id=114276
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Remove the GpuHandle and HostType typedefs from LayerTexture, they
don't make any sense now that we removed the Skia code paths. With Skia
they used to be an OpenGL texture ID and an SkBitmap respectively, but
now it's just BlackBerry::Platform::Graphics::Buffer all around.
This allows us to rename textureId() into buffer() which is more to the
point. The texture ID concept is now up for grabs and can be used to
consolidate all the various code for extracting an OpenGL texture from
a BlackBerry::Platform::Graphics::Buffer. This opportunity is seized in
LayerTexture::platformTexture(), a name which makes more sense than
textureId() for anyone familiar with the GraphicsContext3D code. We can
also leverage the Platform3DObject typedef to avoid including gl2.h.
The vertex attribute state was getting trampled when interacting with
BlackBerry::Platform::Graphics in the LayerFilterRenderer. Some
additional GL state save/restore incantations when accessing the OpenGL
texture for a LayerTexture in the new LayerTexture::platformTexture()
method fixes various CSS Filters test cases.
Since we removed the Skia integration from LayerTiler, nobody cares
about the dirty rect, tile rect or opaqueness of the tile contents. So
remove those parameters from the updateContents code path.
No change in behavior except for fixing CSS Filters tests like
css3/filters/effect-blur-hw.html. This can only be verified by manually
looking at the tests, we don't have pixel test support to catch this
kind of regression.
PR 322882
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::drawSurface):
- platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore::LayerFilterRenderer::ping):
(WebCore::LayerFilterRenderer::pong):
(WebCore::LayerFilterRenderer::pushSnapshot):
(WebCore::LayerFilterRenderer::popSnapshot):
(WebCore::LayerFilterRenderer::applyActions):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::useSurface):
- platform/graphics/blackberry/LayerTexture.cpp:
(WebCore::LayerTexture::LayerTexture):
(WebCore::LayerTexture::updateContents):
(WebCore::LayerTexture::setContentsToColor):
(WebCore::LayerTexture::protect):
(WebCore::LayerTexture::platformTexture):
(WebCore):
- platform/graphics/blackberry/LayerTexture.h:
(WebCore::LayerTexture::isDirty):
(WebCore::LayerTexture::buffer):
(LayerTexture):
(WebCore::LayerTexture::setBuffer):
- platform/graphics/blackberry/LayerTile.cpp:
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::updateContents):
- platform/graphics/blackberry/LayerTile.h:
(WebCore::LayerTile::hasTexture):
(LayerTile):
- platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::performTileJob):
(WebCore::LayerTiler::drawTile):
- platform/graphics/blackberry/LayerTiler.h:
(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::updateContents):
(TextureJob):
(LayerTiler):
- platform/graphics/blackberry/TextureCacheCompositingThread.cpp:
(WebCore::TextureCacheCompositingThread::createBuffer):
(WebCore::TextureCacheCompositingThread::collectGarbage):
(WebCore::TextureCacheCompositingThread::install):
(WebCore::TextureCacheCompositingThread::resizeTexture):
(WebCore::TextureCacheCompositingThread::evict):
(WebCore::TextureCacheCompositingThread::textureForContents):
(WebCore::TextureCacheCompositingThread::updateContents):
- platform/graphics/blackberry/TextureCacheCompositingThread.h:
(TextureCacheCompositingThread):
(WebCore::TextureCacheCompositingThread::ZombieTexture::ZombieTexture):
(ZombieTexture):
Source/WebKit/blackberry:
Adapt to the LayerTexture refactoring down in WebCore.
PR 322882
- Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
- 4:04 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:00 AM Changeset in webkit [148191] by
-
- 40 edits2 moves2 adds2 deletes in releases/WebKitGTK/webkit-2.0/Source
Merge r147924 - [GTK] DOM objects created wrapping a base class have incorrect GObject type
https://bugs.webkit.org/show_bug.cgi?id=113132
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Some of the DOM methods can create a concrete instance of another
object, but return a base class. GObject bindings provide custom
kit implementations for Node, Element, Event and EvenTarget, so
any concrete HTMLElement wrapped as an HTMLElement ends up
wrapping the right WebCore object but in the wrong GObject type.
This affects not only HTMLElements, but any polymorphic object
wrapped using a base class.
This patch changes the way objects are created, so that all
classes have their own kit implementation, but for polymorphic
objects the kit implementation of the base class is always
used. The kit method of polymorphic base classes use a generic
wrap method instead of the wrapFoo method like all other
classes. In the static code we provide the implementation of the
generic wrap method for every polimorphic base class, falling back
to their wrapFoo method if the concrete object can't be used to
wrap the object.
Both WebKitDOMBinding and WebKitHTMLElementWrapperFactory now provide
implementations of wrap and have been renamed to WebKitDOMPrivate
and WebKitDOMHTMLPrivate.
- bindings/gobject/GNUmakefile.am:
- bindings/gobject/WebKitDOMBinding.cpp: Removed.
- bindings/gobject/WebKitDOMEventTarget.cpp:
(WebKit::kit): Moved kit implementation from WebKitDOMBinding for
consistency with all other objects that have their own kit.
(WebKit::core): Updated to match the core implementation fo all
other objects.
- bindings/gobject/WebKitDOMEventTargetPrivate.h:
(WebCore):
(WebKit):
- bindings/gobject/WebKitDOMHTMLPrivate.cpp: Added.
(WebKit): Use preprocessor macros to define and set the wrap
functions of all HTML elements, removing a lot of boilerplate code
and making it easier to add new wrap functions in the future.
(WebKit::wrap):
- bindings/gobject/WebKitDOMHTMLPrivate.h: Renamed from Source/WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.h.
(WebCore):
(WebKit):
- bindings/gobject/WebKitDOMObject.cpp:
- bindings/gobject/WebKitDOMPrivate.cpp: Added.
(WebKit):
(WebKit::wrap):
- bindings/gobject/WebKitDOMPrivate.h: Renamed from Source/WebCore/bindings/gobject/WebKitDOMBinding.h.
(WebCore):
(WebKit):
- bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Removed.
- bindings/scripts/CodeGeneratorGObject.pm:
(IsBaseType): Helper function to check if a type is a base class.
(GetBaseClass): Helper function to get the base class for a given
parent type.
(GenerateFunction): Remove special case for EventTarget since the
kit prototype of EventTarget is in its private header like all
other objects.
(GenerateCFile): Add a kit implementation for all objects.
(IsPolymorphic): Helper function to check if the given type is the
base class of a polymorphic object.
(Generate): Include the private header of the base class for
polymorphic objects.
(WriteData): Remove the special case for WebKitDOMNode since now
all objects has a kit method.
- bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
(WebKit::kit):
- bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestExceptionPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructorPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
(WebKit::kit):
- bindings/scripts/test/GObject/WebKitDOMTestNodePrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefsPrivate.h:
(WebKit):
Source/WebKit/gtk:
Remove WebKitDOMBindindg.h include from several files because it's
been renamed and it was not actually needed.
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/EditorClientGtk.cpp:
- webkit/webkithittestresult.cpp:
- 3:00 AM Changeset in webkit [148190] by
-
- 3 edits in trunk/Tools
Remove code for Chromium from wkbuild.py
https://bugs.webkit.org/show_bug.cgi?id=114423
Reviewed by Benjamin Poulain.
- BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
(_should_file_trigger_build):
- BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
(ShouldBuildTest):
- 2:49 AM Changeset in webkit [148189] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] RenderThemeBlackBerry: upstream missing code
https://bugs.webkit.org/show_bug.cgi?id=114343
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-11
Reviewed by Xan Lopez.
Add implementations of sliderTickSize() and
sliderTickOffsetFromTrackCenter(), as well as a missing header.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore):
(WebCore::RenderThemeBlackBerry::sliderTickSize):
(WebCore::RenderThemeBlackBerry::sliderTickOffsetFromTrackCenter):
- platform/blackberry/RenderThemeBlackBerry.h:
(RenderThemeBlackBerry):
- 2:17 AM Changeset in webkit [148188] by
-
- 4 edits in trunk/Source/WebCore
HitTestRequest::AllowFrameScrollbars does not test main frame scrollbar
https://bugs.webkit.org/show_bug.cgi?id=112563
Reviewed by Antonio Gomes.
Move the frame scrollbar testing from RenderPart to RenderView, so that it is
tested by all frame and not just child frames. At the same time remove the
main frame test from the one current callsite using the option.
Tested by fast/events/touch/gesture/gesture-scrollbar.html.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
- rendering/RenderPart.cpp:
(WebCore::RenderPart::nodeAtPoint):
- rendering/RenderView.cpp:
(WebCore::RenderView::hitTest):
- 2:09 AM Changeset in webkit [148187] by
-
- 2 edits in trunk/Tools
Unreviewed, update my IRC nickname.
- Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
- 2:00 AM Changeset in webkit [148186] by
-
- 19 edits in trunk
Incorrect evaluation of resolution media queries
https://bugs.webkit.org/show_bug.cgi?id=114029
Patch by Rune Lillesveen <rune@opera.com> on 2013-04-11
Reviewed by Kenneth Rohde Christiansen.
.:
Removed setResolutionOverride from exports.
- Source/autotools/symbols.filter:
Source/WebCore:
The implementation used the physical resolution to evaluate the
resolution media features. Changed to use the actual CSS resolution,
also known as the device-pixel-ratio, instead. Unified the code for
evaluating the resolution and device-pixel-ratio media features.
No new tests, covered by existing tests.
- WebCore.exp.in:
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isResolution):
- css/MediaQueryEvaluator.cpp:
(WebCore::evalResolution):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::resolutionMediaFeatureEval):
- page/Screen.cpp:
- page/Screen.h:
- page/Settings.cpp:
(WebCore):
- page/Settings.h:
(Settings):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
- testing/InternalSettings.h:
(Backup):
(InternalSettings):
- testing/InternalSettings.idl:
Source/WebKit:
Removed setResolutionOverride from exports.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/win:
Removed setResolutionOverride from exports.
- WebKit.vcproj/WebKitExports.def.in:
LayoutTests:
Modified tests to change CSS resolution instead of physical resolution.
- fast/media/mq-resolution.html:
- 1:46 AM Changeset in webkit [148185] by
-
- 15 edits1 delete in trunk/Tools
Remove the rest of Chromium code from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=114420
Reviewed by Benjamin Poulain.
- Scripts/webkitpy/common/config/urls.py:
(view_revision_url):
- Scripts/webkitpy/common/host.py:
(Host._engage_awesome_locale_hacks):
(Host.initialize_scm):
(Host):
- Scripts/webkitpy/common/host_mock.py:
(MockHost.init):
(MockHost.checkout):
- Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGeneratorBase._insert_generic_metadata):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._tokenize_line):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(ExpectationSyntaxTests.test_bare_name_and_bugs):
(ExpectationSyntaxTests.test_warnings):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.skips_perf_test):
(Port.path_to_test_expectations_file):
(Port._port_flag_for_scripts):
- Scripts/webkitpy/style/checkers/cpp.py:
(check_function_definition):
(check_include_line):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(OrderOfIncludesTest.test_check_wtf_includes):
(WebKitStyleTest.test_webkit_export_check):
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_valid_expectations):
- Scripts/webkitpy/tool/bot/irc_command.py:
(Rollout.execute):
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois):
- Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help):
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
(SheriffBotTest.test_command_aliases):
- 1:29 AM Changeset in webkit [148184] by
-
- 2 edits in trunk/Tools
roll-chromium-deps doesn't roll DEPS
https://bugs.webkit.org/show_bug.cgi?id=114421
Reviewed by Antti Koivisto.
Roll DEPS. Rolling DEPS. Rolled DEPS.
- Scripts/webkitpy/tool/bot/irc_command.py:
(RollChromiumDEPS.execute):
- 1:27 AM Changeset in webkit [148183] by
-
- 3 edits in trunk/Tools
[webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
https://bugs.webkit.org/show_bug.cgi?id=114418
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/checkout/scm/scm_mock.py:
(MockSCM.add): Remove optional remove_exit_code argument.
(MockSCM.add_list): Remove optional remove_exit_code argument and return value.
- Scripts/webkitpy/tool/servers/rebaselineserver.py:
(_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
(_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
- 1:25 AM Changeset in webkit [148182] by
-
- 3 edits8 adds in trunk
FrameLoaderClient::assignIdentifierToInitialRequest() not called for the main resource when loaded from the memory cache
https://bugs.webkit.org/show_bug.cgi?id=112418
Source/WebCore:
Reviewed by Darin Adler.
When the main resource is loaded from the memory cache the
response is not added to the ResponseVector of the document
loader, so that when committing the provisional load the remaining
delegate messages are not called because the ResponseVector of the
document loader is empty. When the main resource is loaded from
the memory cache, there's no resource loader, and the client is
notified about the response received using
ResourceLoadNotifier::dispatchDidReceiveResponse() directly
instead of ResourceLoadNotifier::didReceiveResponse() which is the
one adding the response to the ResponseVector of the document
loader. So, the problem can be fixed by adding the response to the
ResponseVector before calling dispatchDidReceiveResponse() when
loading the main resource without a resource loade
Test: loader/go-back-cached-main-resource.html
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
LayoutTests:
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-11
Reviewed by Darin Adler.
- loader/go-back-cached-main-resource-expected.txt: Added.
- loader/go-back-cached-main-resource.html: Added.
- loader/resources/first-page.html: Added.
- loader/resources/other-page.html: Added.
- platform/gtk-wk1/loader/go-back-cached-main-resource-expected.txt: Added.
- platform/wk2/loader/go-back-cached-main-resource-expected.txt: Added.
- 12:45 AM Changeset in webkit [148181] by
-
- 2 edits in trunk/Tools
Fix roll-chromium-deps and hi.
- Scripts/webkitpy/tool/bot/irc_command.py:
(Hi.execute):
(RollChromiumDEPS.execute):
- 12:40 AM Changeset in webkit [148180] by
-
- 10 edits7 deletes in trunk/Tools
Remove webkitpy code to roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=114415
Reviewed by Benjamin Poulain.
Removed the code to roll Chromium DEPS in WebKit.
- Scripts/webkitpy/common/checkout/checkout.py:
(Checkout.bug_id_for_this_commit):
- Scripts/webkitpy/common/checkout/checkout_mock.py:
(MockCheckout.commit_message_for_this_commit):
- Scripts/webkitpy/common/checkout/checkout_unittest.py:
(CheckoutTest.test_suggested_reviewers):
- Scripts/webkitpy/common/checkout/deps.py: Removed.
- Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
- Scripts/webkitpy/tool/bot/irc_command.py:
(RollChromiumDEPS): Teach webkitbot a sense of humor.
(RollChromiumDEPS.execute):
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_create_bug):
- Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_revert):
- Scripts/webkitpy/tool/bot/sheriff.py:
(Sheriff.post_rollout_patch):
- Scripts/webkitpy/tool/commands/init.py:
- Scripts/webkitpy/tool/commands/roll.py: Removed.
- Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
- Scripts/webkitpy/tool/steps/init.py:
- Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
- Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
- Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
- 12:20 AM Changeset in webkit [148179] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed Qt buildfixes after r148147, r148148 and r148154.
- DerivedSources.pri:
- Target.pri:
- 12:06 AM Changeset in webkit [148178] by
-
- 1 copy in tags/Safari-537.37
New Tag.
- 12:03 AM Changeset in webkit [148177] by
-
- 3 edits in trunk/Tools
[webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
https://bugs.webkit.org/show_bug.cgi?id=114386
Reviewed by Benjamin Poulain.
Subversion client 1.7 uses a new locking scheme that invalidates the technique used
in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
can be implemented. Further, 1.7 changed svn add to not add intermediate directories
by default and to return exit code 1 if a file/dir had already been added.
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(test_svn_lock): Skip body of test if subversion client 1.7 or later.
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
Apr 10, 2013:
- 11:29 PM Changeset in webkit [148176] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix, fixing the WebKit2 build.
- GNUmakefile.list.am:
- 11:22 PM Changeset in webkit [148175] by
-
- 17 edits in trunk/Source/WebCore
Remove some includes of CachedImage.h
https://bugs.webkit.org/show_bug.cgi?id=114411
Reviewed by Dan Bernstein.
- css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a definition of a class it holds, but default construction does not.
- rendering/RenderImageResource.cpp:
- rendering/RenderImageResource.h: Moved definitions of virtual functions to a .cpp file. There is no win from having them inline, and now we don't need CachedImage.h in the header.
- bindings/js/JSNodeCustom.cpp:
- dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard):
- platform/mac/ClipboardMac.h:
- rendering/InlineFlowBox.cpp:
- rendering/RenderBox.cpp:
- rendering/RenderListItem.cpp:
- rendering/RenderListMarker.cpp:
- rendering/RenderTableCol.cpp:
- rendering/RenderTableRow.cpp:
- rendering/RenderTableSection.cpp:
- svg/graphics/SVGImageCache.cpp: Removed unnecessary includes.
- platform/mac/PasteboardMac.mm:
- rendering/RenderSnapshottedPlugIn.cpp: Added ones where they are now necessary.
- 11:19 PM Changeset in webkit [148174] by
-
- 2 edits in trunk/Tools
Unreviewed.
- GNUmakefile.am: Removing extra whitespace that's producing warnings.
- 11:04 PM Changeset in webkit [148173] by
-
- 4 edits in trunk/Tools
[webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
https://bugs.webkit.org/show_bug.cgi?id=114410
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.add_list): Remove optional return_exit_code argument. Remove return value.
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.add): Remove optional return_exit_code argument.
(SCM.add_list): Remove optional return_exit_code argument.
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.add_list): Remove optional return_exit_code argument. Remove return value.
- 10:47 PM Changeset in webkit [148172] by
-
- 8 edits19 adds in trunk
Allow direct compositing of background images
https://bugs.webkit.org/show_bug.cgi?id=108203
Patch by No'am Rosenthal <Noam Rosenthal> on 2013-04-10
Reviewed by Simon Fraser.
Source/WebCore:
Use setContentsToImage for background images, if the GraphicsLayer has only a background
bitmap image and nothing else. Compute the contentsRect/contentsTileRect from the box model.
Added new properties to GraphicsLayer, contentsTilePhase and contentsTileSize, which controls the "single tile rect",
which allows us to compute the pattern-space transform of a tile, thus allowing background-size
and other characteristics of background images.
This feature is explicitly disabled when there is any composition with a background color or if
there are several background images, as in that case having a single backing store has some
advantages over directly compositing in hardware.
Currently, this feature is disabled for all ports, allowing ports to implement their backend
and decide when to enable it.
Note that RenderBoxModelObject::getGeometryForBackgroundImage crops the contents rect to the
area that contains the tiles, which allows us to assume full tiling in GraphicsLayer.
In this way contentsTileSize/Phase is equivalent to GraphicsContext::drawTiledImage.
Tests: compositing/patterns/direct-pattern-compositing-add-text.html
compositing/patterns/direct-pattern-compositing-change.html
compositing/patterns/direct-pattern-compositing-contain.html
compositing/patterns/direct-pattern-compositing-cover.html
compositing/patterns/direct-pattern-compositing-load.html
compositing/patterns/direct-pattern-compositing-padding.html
compositing/patterns/direct-pattern-compositing-position.html
compositing/patterns/direct-pattern-compositing-rotation.html
compositing/patterns/direct-pattern-compositing-size.html
compositing/patterns/direct-pattern-compositing.html
- platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
(WebCore::GraphicsLayer::setContentsTileSize):
(WebCore::GraphicsLayer::setContentsTilePhase):
(WebCore::GraphicsLayer::contentsTileSize):
(WebCore::GraphicsLayer::contentsTilePhase):
(WebCore::GraphicsLayer::supportsContentsTiling):
Add a contentsTileRect property that enables tile-repeat of background images.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::imageChanged):
Pass background image changes to the layer backing.
- rendering/RenderBoxModelObject.cpp:
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::getGeometryForBackgroundImage):
Expose a function that performs the geometry calculations needed to determine
the tileRect for a background image. This function is also responsible
for cropping the contentsRect to fit the area that is drawn into.
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateDirectlyCompositedContents):
(WebCore::RenderLayerBacking::resetContentsRect):
(WebCore::hasBoxDecorationsOrBackgroundImage):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundColor):
(WebCore::canCreateTiledImage):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::backgroundRectForBox):
Allow background images to be directly composited if conditions allow (see bug description).
LayoutTests:
Added several ref-tests as preparation for supporting direct compositing of background
images.
- compositing/patterns/direct-pattern-compositing-add-text-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-add-text.html: Added.
- compositing/patterns/direct-pattern-compositing-change-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-change.html: Added.
- compositing/patterns/direct-pattern-compositing-contain-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-contain.html: Added.
- compositing/patterns/direct-pattern-compositing-cover-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-cover.html: Added.
- compositing/patterns/direct-pattern-compositing-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-load-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-load.html: Added.
- compositing/patterns/direct-pattern-compositing-padding-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-padding.html: Added.
- compositing/patterns/direct-pattern-compositing-position-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-position.html: Added.
- compositing/patterns/direct-pattern-compositing-size-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-size.html: Added.
- compositing/patterns/direct-pattern-compositing.html: Added.
- 9:59 PM Changeset in webkit [148171] by
-
- 2 edits in trunk/Tools
Remove myself from the watchlists, I'm getting too much bug mail. :)
- Scripts/webkitpy/common/config/watchlist:
- 8:53 PM Changeset in webkit [148170] by
-
- 5 edits in trunk/Source/WebCore
Replace ENABLE_LEGACY_WEB_AUDIO preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114351
Reviewed by Ryosuke Niwa.
The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/AudioParam.idl:
- Modules/webaudio/OscillatorNode.idl:
- 8:23 PM Changeset in webkit [148169] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Build warning in didReceiveMessage() generated by messages.py
https://bugs.webkit.org/show_bug.cgi?id=112513
Reviewed by Anders Carlsson.
Legacy receiver makes -Wunused-parameter build warnings. This patch is to fix them.
- Scripts/webkit2/messages.py:
(generate_message_handler):
- 8:21 PM Changeset in webkit [148168] by
-
- 2 edits in trunk/Source/WebCore
Replace ENABLE_DIRECTORY_UPLOAD preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114350
Reviewed by Ryosuke Niwa.
The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
- fileapi/File.idl:
- 8:17 PM Changeset in webkit [148167] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unify JSC Parser's error and error message
https://bugs.webkit.org/show_bug.cgi?id=114363
Reviewed by Geoffrey Garen.
The parser kept the error state over two attributes:
error and errorMessage. They were changed in sync,
but had some discrepancy (for example, the error message
was always defined to something).
This patch unifies the two. There is an error if
if the error message is non-null or if the parsing finished
before the end.
This also gets rid of the allocation of the error message
when instantiating a parser.
- parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseInner):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseForStatement):
(JSC::::parseSwitchStatement):
(JSC::::parsePrimaryExpression):
- parser/Parser.h:
(JSC::Parser::updateErrorMessage):
(JSC::Parser::updateErrorWithNameAndMessage):
(JSC::Parser::hasError):
(Parser):
- 8:12 PM Changeset in webkit [148166] by
-
- 2 edits in trunk/Source/WTF
[WTF] Get rid of truncated thread name warnings for non-Windows platforms
https://bugs.webkit.org/show_bug.cgi?id=114266
Reviewed by Ryosuke Niwa.
Hide the annoying message from ports that are not really interested
about it.
- wtf/Threading.cpp:
(WTF::createThread):
- 6:59 PM Changeset in webkit [148165] by
-
- 2 edits in trunk/Source/WebKit2
[CMAKE] Build fix after StorageArea refactoring
https://bugs.webkit.org/show_bug.cgi?id=114398
Unreviewed build fix.
Change StorageAreaImpl.messages.in with StorageAreaMap.messages.in.
Add StorageAreaMap.cpp in CMakeLists.txt.
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-10
- CMakeLists.txt:
- 6:36 PM Changeset in webkit [148164] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r148158.
http://trac.webkit.org/changeset/148158
https://bugs.webkit.org/show_bug.cgi?id=114405
We need to migrate status data (Requested by rniwa on
#webkit).
- Scripts/webkitpy/common/net/statusserver.py:
(StatusServer):
- 6:27 PM Changeset in webkit [148163] by
-
- 2 edits in trunk/Source/WebCore
Cleanup local variables in Editor::markAndReplaceFor
https://bugs.webkit.org/show_bug.cgi?id=114383
Reviewed by Enrica Casucci.
Added resultEndLocation, which is the sum of resultLocation and resultLength.
Also replaced ambiguousBoundaryOffset by useAmbiguousBoundaryOffset since the ambiguous offset is always
selectionOffset -1 to avoid the extra house keeping and obnoxious -1 check.
- editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):
- 6:25 PM Changeset in webkit [148162] by
-
- 5 edits in trunk/Source/JavaScriptCore
Set trap is not being called for API objects
https://bugs.webkit.org/show_bug.cgi?id=114403
Reviewed by Anders Carlsson.
Intercept putByIndex on the callback object and add tests
to make sure we don't regress in future.
- API/JSCallbackObject.h:
(JSCallbackObject):
- API/JSCallbackObjectFunctions.h:
(JSC::::putByIndex):
(JSC):
- API/tests/testapi.c:
(PropertyCatchalls_setProperty):
- API/tests/testapi.js:
- 6:22 PM Changeset in webkit [148161] by
-
- 7 edits in trunk/Source/WebKit2
Make StorageAreaImpl a wrapper around StorageAreaMap
https://bugs.webkit.org/show_bug.cgi?id=114404
Reviewed by Oliver Hunt.
Prepare for moving all the code that deals with local storage values to StorageAreaMap,
and make StorageAreaImpl a dumb wrapper that simply calls through to the map.
- WebProcess/Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::create):
(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::~StorageAreaImpl):
(WebKit::StorageAreaImpl::storageType):
(WebKit::StorageAreaImpl::length):
(WebKit::StorageAreaImpl::key):
(WebKit::StorageAreaImpl::getItem):
(WebKit::StorageAreaImpl::setItem):
(WebKit::StorageAreaImpl::contains):
- WebProcess/Storage/StorageAreaImpl.h:
(WebKit::StorageAreaImpl::storageAreaID):
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::generateStorageMapID):
(WebKit::StorageAreaMap::create):
(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::storageType):
(WebKit::StorageAreaMap::length):
(WebKit::StorageAreaMap::key):
(WebKit::StorageAreaMap::item):
(WebKit::StorageAreaMap::setItem):
(WebKit::StorageAreaMap::contains):
(WebKit::StorageAreaMap::didSetItem):
(WebKit::StorageAreaMap::dispatchStorageEvent):
- WebProcess/Storage/StorageAreaMap.h:
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::storageArea):
- WebProcess/Storage/StorageNamespaceImpl.h:
(StorageNamespaceImpl):
- 6:03 PM Changeset in webkit [148160] by
-
- 5 edits in trunk/Source/WebKit2
Rename StorageManager messages to refer to the StorageMap instead of the StorageArea
https://bugs.webkit.org/show_bug.cgi?id=114401
Reviewed by Ryosuke Niwa.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createStorageMap):
(WebKit::StorageManager::destroyStorageMap):
(WebKit::StorageManager::setItem):
- UIProcess/Storage/StorageManager.h:
- UIProcess/Storage/StorageManager.messages.in:
- WebProcess/Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::~StorageAreaImpl):
- 5:20 PM Changeset in webkit [148159] by
-
- 13 edits399 deletes in trunk
Mass remove all the empty directories
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-10
Rubberstamped by Ryosuke Niwa.
PerformanceTests:
- Bindings/resources: Removed.
Source/JavaScriptCore:
- qt/api: Removed.
- qt/benchmarks/qscriptengine: Removed.
- qt/benchmarks/qscriptvalue: Removed.
- qt/tests/qscriptengine: Removed.
- qt/tests/qscriptstring: Removed.
- qt/tests/qscriptvalue: Removed.
- qt/tests/qscriptvalueiterator: Removed.
Source/ThirdParty/ANGLE:
- src/libGLESv2/geometry: Removed.
Source/WebCore:
- Modules/intents: Removed.
- Modules/protocolhandler: Removed.
- Modules/speech/mac: Removed.
- accessibility/efl: Removed.
- accessibility/gtk: Removed.
- bridge/jni/jsc: Removed.
- editing/android: Removed.
- editing/gtk: Removed.
- history/android: Removed.
- page/android: Removed.
- platform/android: Removed.
- platform/clutter: Removed.
- platform/graphics/blackberry/skia: Removed.
- platform/graphics/harfbuzz/ng: Removed.
- platform/graphics/pango: Removed.
- platform/image-decoders/cg: Removed.
- platform/image-decoders/qt: Removed.
- platform/network/android: Removed.
- platform/network/soup/cache/webkit: Removed.
- platform/text/android: Removed.
- platform/text/wince: Removed.
- platform/track: Removed.
Source/WebKit/efl:
- DefaultTheme/widget/button: Removed.
- DefaultTheme/widget/check: Removed.
- DefaultTheme/widget/combo: Removed.
- DefaultTheme/widget/entry: Removed.
- DefaultTheme/widget/file: Removed.
- DefaultTheme/widget/mediacontrol/fullscreenbutton: Removed.
- DefaultTheme/widget/mediacontrol/mutebutton: Removed.
- DefaultTheme/widget/mediacontrol/playpausebutton: Removed.
- DefaultTheme/widget/mediacontrol/seekbackwardbutton: Removed.
- DefaultTheme/widget/mediacontrol/seekforwardbutton: Removed.
- DefaultTheme/widget/mediacontrol/togglecaptionsbutton: Removed.
- DefaultTheme/widget/progressbar: Removed.
- DefaultTheme/widget/radio: Removed.
- DefaultTheme/widget/scrollbar: Removed.
- DefaultTheme/widget/search/cancel: Removed.
- DefaultTheme/widget/search/decoration: Removed.
- DefaultTheme/widget/search/field: Removed.
- DefaultTheme/widget/slider: Removed.
- DefaultTheme/widget/spinner: Removed.
Source/WebKit/gtk:
- gyp: Removed.
- po: Removed.
Source/WebKit/mac:
- ForwardingHeaders/wtf/unicode/icu: Removed.
Source/WebKit/qt:
- tests/qdeclarativewebview/resources: Removed.
Source/WebKit2:
- Platform/CoreIPC/gtk: Removed.
- Platform/CoreIPC/qt: Removed.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32: Removed.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.64: Removed.
- PluginProcess/gtk: Removed.
- Shared/API/c/win: Removed.
- Shared/Plugins/Netscape/win: Removed.
- Shared/cg/win: Removed.
- Shared/win: Removed.
- UIProcess/API/C/win: Removed.
- UIProcess/API/gtk/webkit: Removed.
- UIProcess/Launcher/win: Removed.
- UIProcess/Plugins/gtk: Removed.
- UIProcess/Plugins/win: Removed.
- UIProcess/texmap: Removed.
- UIProcess/win: Removed.
- WebProcess/Authentication/mac: Removed.
- WebProcess/Cookies/efl: Removed.
- WebProcess/Cookies/gtk: Removed.
- WebProcess/Downloads/cf/win: Removed.
- WebProcess/Downloads/cfnet: Removed.
- WebProcess/Downloads/curl: Removed.
- WebProcess/Downloads/efl: Removed.
- WebProcess/Downloads/gtk: Removed.
- WebProcess/Downloads/mac: Removed.
- WebProcess/Downloads/qt: Removed.
- WebProcess/Downloads/soup: Removed.
- WebProcess/FullScreen/gtk: Removed.
- WebProcess/FullScreen/mac: Removed.
- WebProcess/FullScreen/qt: Removed.
- WebProcess/FullScreen/win: Removed.
- WebProcess/InjectedBundle/API/c/win: Removed.
- WebProcess/InjectedBundle/win: Removed.
- WebProcess/KeyValueStorage: Removed.
- WebProcess/Network/CustomProtocols/mac: Removed.
- WebProcess/Plugins/Netscape/gtk: Removed.
- WebProcess/Plugins/Netscape/win: Removed.
- WebProcess/WebCoreSupport/win: Removed.
- WebProcess/WebPage/LayerTreeCoordinator: Removed.
- WebProcess/WebPage/ca/mac: Removed.
- WebProcess/WebPage/ca/win: Removed.
- WebProcess/WebPage/win: Removed.
- WebProcess/win: Removed.
- qt/Resources: Removed.
Source/WTF:
- wtf/qt/compat: Removed.
- wtf/unicode/glib: Removed.
- wtf/unicode/qt4: Removed.
- wtf/unicode/wince: Removed.
Tools:
- BuildSlaveSupport/gtk/crashmon/log: Removed.
- BuildSlaveSupport/gtk/xvfb/log: Removed.
- DumpRenderTree/ForwardingHeaders/wtf: Removed.
- DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
- MiniBrowser/gtk/WebBundle: Removed.
- MiniBrowser/win: Removed.
- QtTestPlatformPlugin/mac: Removed.
- Scripts/webkitpy/tool/bot/testdata: Removed.
- Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
- efl/ImageDiff: Removed.
- iExploder/htdocs: Removed.
- iExploder/iexploder-1.7.2/output: Removed.
- iExploder/tools: Removed.
- qmake/config.tests/libexecdir: Removed.
- qmake/config.tests/libjpeg: Removed.
- qmake/config.tests/libpng: Removed.
WebKitLibraries:
- win/bin: Removed.
- win/lib/WebKitSystemInterface: Removed.
LayoutTests:
- css2.1/reference: Removed.
- css3/flexbox/script-tests: Removed.
- css3/viewport-relative-lengths: Removed.
- editing/deleting/resources: Removed.
- editing/inserting/resources: Removed.
- editing/style/resources: Removed.
- editing/text-iterator/resources: Removed.
- fast/dom/CSSStyleDeclaration/resources: Removed.
- fast/dom/EntityReference/resources: Removed.
- fast/dom/HTMLFontElement/resources: Removed.
- fast/dom/HTMLFormElement/resources: Removed.
- fast/dom/HTMLSelectElement/resources: Removed.
- fast/dom/HTMLTableElement/resources: Removed.
- fast/dom/HTMLTableRowElement/resources: Removed.
- fast/dom/HTMLTableSectionElement/resources: Removed.
- fast/dom/MediaStream/script-tests: Removed.
- fast/dom/Node/resources: Removed.
- fast/dom/Proximity: Removed.
- fast/dom/Selection/resources: Removed.
- fast/dom/Text/resources: Removed.
- fast/events/spatial-navigation/resources: Removed.
- fast/events/transformaction: Removed.
- fast/forms/script-tests: Removed.
- fast/loading/resources: Removed.
- fast/mutation: Removed.
- fast/regex/resources: Removed.
- fast/speech/script-tests: Removed.
- fast/xhtmlmp: Removed.
- http/tests/inspector/resources/compiler-source-mapping-provider: Removed.
- http/tests/media/media-source/webm: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5: Removed.
- http/tests/w3c/webperf/submission/resource-timing/html: Removed.
- http/tests/w3c/webperf/submission/user-timing: Removed.
- http/tests/xhtmlmp: Removed.
- http/tests/xmlhttprequest/web-apps/recursion: Removed.
- inspector/performance/resources: Removed.
- inspector/protocol/resources: Removed.
- inspector/resources: Removed.
- media/track/captions: Removed.
- platform/efl-wk1/dom/xhtml/level3/core: Removed.
- platform/efl-wk1/fast/dom/DOMException: Removed.
- platform/efl-wk1/mathml/presentation: Removed.
- platform/efl-wk1/svg/dynamic-updates: Removed.
- platform/efl-wk2/dom/xhtml/level3/core: Removed.
- platform/efl-wk2/fast/block/basic: Removed.
- platform/efl-wk2/fast/dom/DOMException: Removed.
- platform/efl-wk2/fast/frames: Removed.
- platform/efl-wk2/http/tests/loading: Removed.
- platform/efl/fast/css3-text-decoration/repaint: Removed.
- platform/efl/fast/dom/HTMLTemplateElement: Removed.
- platform/efl/fast/files: Removed.
- platform/efl/fast/forms/mailto: Removed.
- platform/efl/fast/innerHTML: Removed.
- platform/efl/fast/viewport: Removed.
- platform/efl/inspector/editor: Removed.
- platform/gtk/css3/calc: Removed.
- platform/gtk/editing/pasteboard/resources: Removed.
- platform/gtk/fast/innerHTML: Removed.
- platform/gtk/fast/js/regress: Removed.
- platform/gtk/fast/viewport: Removed.
- platform/gtk/http/tests/webarchive: Removed.
- platform/gtk/http/tests/websocket/tests: Removed.
- platform/gtk/ietestcenter/css3/grid: Removed.
- platform/gtk/platform/gtk/fonts: Removed.
- platform/gtk/sputnik/Unicode/Unicode_510: Removed.
- platform/gtk/svg/hittest: Removed.
- platform/gtk/tables/hittesting: Removed.
- platform/mac-future/accessibility: Removed.
- platform/mac-lion/animations: Removed.
- platform/mac-lion/compositing/visible-rect: Removed.
- platform/mac-lion/css1/units: Removed.
- platform/mac-lion/css3/selectors3: Removed.
- platform/mac-lion/editing/execCommand: Removed.
- platform/mac-lion/editing/inserting: Removed.
- platform/mac-lion/editing/pasteboard: Removed.
- platform/mac-lion/fast/block/float: Removed.
- platform/mac-lion/fast/block/margin-collapse: Removed.
- platform/mac-lion/fast/frames: Removed.
- platform/mac-lion/fast/inline: Removed.
- platform/mac-lion/fast/layers: Removed.
- platform/mac-lion/fast/lists: Removed.
- platform/mac-lion/fast/overflow: Removed.
- platform/mac-lion/fast/text/basic: Removed.
- platform/mac-lion/ietestcenter/css3: Removed.
- platform/mac-lion/tables/mozilla: Removed.
- platform/mac-lion/transforms: Removed.
- platform/mac-snowleopard/css3/filters/custom: Removed.
- platform/mac-snowleopard/fast/canvas/webgl: Removed.
- platform/mac-snowleopard/fast/html: Removed.
- platform/mac-snowleopard/fast/loader: Removed.
- platform/mac-snowleopard/fast/regions: Removed.
- platform/mac-snowleopard/http/tests/media: Removed.
- platform/mac-snowleopard/mathml/presentation: Removed.
- platform/mac-snowleopard/sputnik/Unicode/Unicode_510: Removed.
- platform/mac-snowleopard/svg/batik/filters: Removed.
- platform/mac-snowleopard/svg/batik/masking: Removed.
- platform/mac-snowleopard/svg/batik/text: Removed.
- platform/mac-wk2/compositing/geometry: Removed.
- platform/mac-wk2/compositing/iframes: Removed.
- platform/mac-wk2/css3/filters/custom: Removed.
- platform/mac-wk2/fast/css: Removed.
- platform/mac-wk2/fast/dynamic: Removed.
- platform/mac-wk2/fast/harness: Removed.
- platform/mac-wk2/fast/multicol/vertical-rl: Removed.
- platform/mac-wk2/http/tests/appcache: Removed.
- platform/mac-wk2/http/tests/inspector: Removed.
- platform/mac-wk2/http/tests/misc: Removed.
- platform/mac-wk2/mathml: Removed.
- platform/mac-wk2/media: Removed.
- platform/mac-wk2/platform/mac/accessibility: Removed.
- platform/mac-wk2/tables/mozilla: Removed.
- platform/mac/css3/calc: Removed.
- platform/mac/css3/filters/custom: Removed.
- platform/mac/dom/xhtml/level2/html: Removed.
- platform/mac/fast/dom/shadow: Removed.
- platform/mac/fast/files: Removed.
- platform/mac/fast/forms/label: Removed.
- platform/mac/fast/innerHTML: Removed.
- platform/mac/fast/inspector: Removed.
- platform/mac/http/tests/xmlhttprequest/web-apps: Removed.
- platform/mac/inspector/console: Removed.
- platform/mac/inspector/debugger: Removed.
- platform/mac/inspector/extensions: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/sticky: Removed.
- platform/mac/sputnik/Unicode/Unicode_510: Removed.
- platform/mac/svg/animations: Removed.
- platform/mac/tables/mozilla/images: Removed.
- platform/mac/tiled-drawing/fixed: Removed.
- platform/mac/tiled-drawing/fixed-background: Removed.
- platform/mac/tiled-drawing/sticky: Removed.
- platform/qt-5.0-wk1/compositing/backing: Removed.
- platform/qt-5.0-wk1/compositing/filters: Removed.
- platform/qt-5.0-wk1/compositing/images: Removed.
- platform/qt-5.0-wk1/compositing/masks: Removed.
- platform/qt-5.0-wk1/compositing/rtl: Removed.
- platform/qt-5.0-wk1/compositing/tiling: Removed.
- platform/qt-5.0-wk1/compositing/visibility: Removed.
- platform/qt-5.0-wk1/css3/filters: Removed.
- platform/qt-5.0-wk1/editing/inserting: Removed.
- platform/qt-5.0-wk1/fast/dom/Window: Removed.
- platform/qt-5.0-wk2/compositing/backing: Removed.
- platform/qt-5.0-wk2/compositing/shadows: Removed.
- platform/qt-5.0-wk2/css1/basic: Removed.
- platform/qt-5.0-wk2/css1/box_properties: Removed.
- platform/qt-5.0-wk2/fast/block/basic: Removed.
- platform/qt-5.0-wk2/fast/block/float: Removed.
- platform/qt-5.0-wk2/fast/block/margin-collapse: Removed.
- platform/qt-5.0-wk2/fast/block/positioning/auto: Removed.
- platform/qt-5.0-wk2/fast/dom/HTMLHeadElement: Removed.
- platform/qt-5.0-wk2/fast/dom/HTMLTableElement: Removed.
- platform/qt-5.0-wk2/fast/dom/HTMLTextAreaElement: Removed.
- platform/qt-5.0-wk2/fast/dom/Window: Removed.
- platform/qt-5.0-wk2/fast/dynamic: Removed.
- platform/qt-5.0-wk2/fast/forms/datalist: Removed.
- platform/qt-5.0-wk2/fast/forms/mailto: Removed.
- platform/qt-5.0-wk2/fast/forms/number: Removed.
- platform/qt-5.0-wk2/fast/frames: Removed.
- platform/qt-5.0-wk2/fast/html: Removed.
- platform/qt-5.0-wk2/fast/images/png-suite: Removed.
- platform/qt-5.0-wk2/fast/inline: Removed.
- platform/qt-5.0-wk2/fast/lists: Removed.
- platform/qt-5.0-wk2/fast/multicol/span: Removed.
- platform/qt-5.0-wk2/fast/multicol/vertical-lr: Removed.
- platform/qt-5.0-wk2/fast/parser: Removed.
- platform/qt-5.0-wk2/fast/text/international: Removed.
- platform/qt-5.0-wk2/fullscreen/fullscreen: Removed.
- platform/qt-5.0-wk2/http/tests/websocket/test/hybi: Removed.
- platform/qt-5.0-wk2/platform/qt/plugins: Removed.
- platform/qt-5.0-wk2/svg/dom: Removed.
- platform/qt-5.0/animations: Removed.
- platform/qt-5.0/css1/text_properties: Removed.
- platform/qt-5.0/css2.1/20110323: Removed.
- platform/qt-5.0/editing/deleting: Removed.
- platform/qt-5.0/editing/inserting: Removed.
- platform/qt-5.0/editing/pasteboard: Removed.
- platform/qt-5.0/fast/borders: Removed.
- platform/qt-5.0/fast/css: Removed.
- platform/qt-5.0/fast/dom/DeviceMotion: Removed.
- platform/qt-5.0/fast/dom/DeviceOrientation: Removed.
- platform/qt-5.0/fast/dom/HTMLProgressElement: Removed.
- platform/qt-5.0/fast/dom/HTMLTextAreaElement: Removed.
- platform/qt-5.0/fast/dynamic: Removed.
- platform/qt-5.0/fast/html: Removed.
- platform/qt-5.0/fast/inline: Removed.
- platform/qt-5.0/fast/js: Removed.
- platform/qt-5.0/fast/multicol: Removed.
- platform/qt-5.0/fast/parser: Removed.
- platform/qt-5.0/fast/repaint: Removed.
- platform/qt-5.0/fast/replaced: Removed.
- platform/qt-5.0/fast/table/border-collapsing: Removed.
- platform/qt-5.0/fast/writing-mode: Removed.
- platform/qt-5.0/fast/xsl: Removed.
- platform/qt-5.0/svg/as-background-image: Removed.
- platform/qt-5.0/svg/custom: Removed.
- platform/qt-5.0/svg/hixie/intrinsic: Removed.
- platform/qt-5.0/svg/text: Removed.
- platform/qt-5.0/svg/wicd: Removed.
- platform/qt-5.0/svg/zoom/page: Removed.
- platform/qt-5.0/tables/mozilla/bugs: Removed.
- platform/qt-5.0/transitions: Removed.
- platform/qt-arm/fast/block: Removed.
- platform/qt-arm/fast/dom: Removed.
- platform/qt-arm/transforms: Removed.
- platform/qt-linux/fast/css: Removed.
- platform/qt-mac/editing: Removed.
- platform/qt-mac/fast/block/float: Removed.
- platform/qt-mac/plugins: Removed.
- platform/qt-win/fast/events: Removed.
- platform/qt.5-0/fast/text/whitespace: Removed.
- platform/qt/compositing/tiling: Removed.
- platform/qt/fast/css/dumpAsText: Removed.
- platform/qt/fast/encoding/dumpAsText: Removed.
- platform/qt/fast/forms/mailto: Removed.
- platform/qt/fast/innerHTML: Removed.
- platform/qt/fast/inspector: Removed.
- platform/qt/fast/js/regress: Removed.
- platform/qt/fast/media/w3c: Removed.
- platform/qt/http/tests/plugins: Removed.
- platform/qt/http/tests/security/aboutBlank: Removed.
- platform/qt/http/tests/security/cookies: Removed.
- platform/qt/http/tests/security/mixedContent: Removed.
- platform/qt/http/tests/security/xssAuditor: Removed.
- platform/qt/http/tests/xmlhttprequest/workers: Removed.
- platform/qt/inspector/console: Removed.
- platform/qt/inspector/debugger: Removed.
- platform/qt/inspector/extensions: Removed.
- platform/qt/mathml/presentation: Removed.
- platform/qt/scrollingcoordinator: Removed.
- platform/qt/svg/hixie/error/dumpAsText: Removed.
- platform/qt/tables/mozilla/images: Removed.
- platform/qt/traversal: Removed.
- platform/win-7sp0/fast/harness: Removed.
- platform/win-wk2/css2.1: Removed.
- platform/win-wk2/editing/deleting: Removed.
- platform/win-wk2/editing/selection: Removed.
- platform/win-wk2/fast/css: Removed.
- platform/win-wk2/fast/forms: Removed.
- platform/win-wk2/fast/repaint: Removed.
- platform/win-wk2/fast/ruby: Removed.
- platform/win-wk2/fast/text/international: Removed.
- platform/win-wk2/http/tests/inspector-enabled: Removed.
- platform/win-wk2/http/tests/security: Removed.
- platform/win-wk2/http/tests/uri: Removed.
- platform/win-wk2/media: Removed.
- platform/win-wk2/platform/win/inverted-colors: Removed.
- platform/win-wk2/platform/win/plugins: Removed.
- platform/win-wk2/plugins/npruntime: Removed.
- platform/win-wk2/svg/W3C-I18N: Removed.
- platform/win-wk2/svg/W3C-SVG-1.1-SE: Removed.
- platform/win-wk2/svg/text: Removed.
- platform/win-wk2/svg/zoom/page: Removed.
- platform/win/canvas/philip/tests: Removed.
- platform/win/compositing/geometry: Removed.
- platform/win/compositing/overflow: Removed.
- platform/win/editing/style: Removed.
- platform/win/editing/undo: Removed.
- platform/win/fast/block/basic: Removed.
- platform/win/fast/css/getComputedStyle: Removed.
- platform/win/fast/css3-text-decoration/getComputedStyle: Removed.
- platform/win/fast/dom/Element: Removed.
- platform/win/fast/dom/HTMLTextAreaElement: Removed.
- platform/win/fast/dom/Window: Removed.
- platform/win/fast/events/resources: Removed.
- platform/win/fast/frames/seamless: Removed.
- platform/win/fast/layers: Removed.
- platform/win/fast/loader: Removed.
- platform/win/fast/overflow: Removed.
- platform/win/fast/parser: Removed.
- platform/win/fast/table: Removed.
- platform/win/fast/transforms: Removed.
- platform/win/inspector/debugger: Removed.
- platform/win/platform/win/accessibility: Removed.
- platform/win/tables/mozilla/bugs: Removed.
- platform/win/tables/mozilla/other: Removed.
- platform/win/tables/mozilla_expected_failures/bugs: Removed.
- platform/wk2/tables/mozilla/bugs: Removed.
- pointer-lock/resources: Removed.
- storage/indexeddb/script-tests: Removed.
- svg/dom/SVGStyleElement/resources: Removed.
- webintents/resources: Removed.
- 5:15 PM Changeset in webkit [148158] by
-
- 2 edits in trunk/Tools
Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114397
Reviewed by Benjamin Poulain.
- Scripts/webkitpy/common/net/statusserver.py:
(StatusServer):
- 5:10 PM Changeset in webkit [148157] by
-
- 2 edits in trunk/Source/WebKit2
[CMAKE] Build fix after r148147, r148148
https://bugs.webkit.org/show_bug.cgi?id=114395
Unreviewed build fix.
Use StorageAreaImpl, StorageNamespaceImpl instead of StorageAreaProxy, StorageNamespaceProxy.
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-10
- CMakeLists.txt:
- 5:09 PM Changeset in webkit [148156] by
-
- 5 edits in trunk/Websites/bugs.webkit.org
Make old EWS bubbles less opaque to disambiguate two set of bubbles.
Rubber-stamped by Benjamin Poulain.
- code-review.js:
- template/en/custom/attachment/edit.html.tmpl:
- template/en/custom/attachment/list.html.tmpl:
- template/en/custom/attachment/reviewform.html.tmpl:
- 5:04 PM Changeset in webkit [148155] by
-
- 2 edits in trunk/Source/WebCore
Log when the animation timer fires
https://bugs.webkit.org/show_bug.cgi?id=114393
Reviewed by Dean Jackson.
Logging to the Animations log channel when the updateAnimationTimer
fires is useful, because it indicates whether we're running
software animations.
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::updateAnimationTimer):
- 5:02 PM Changeset in webkit [148154] by
-
- 5 edits1 move2 adds in trunk/Source/WebKit2
Add a stubbed out StorageAreaMap class
https://bugs.webkit.org/show_bug.cgi?id=114392
Reviewed by Andreas Kling.
The intention is that StorageAreaMap is going to take over responsibility for storing the storage values in the
web process, as well as dispatching events. A StorageAreaMap will be shared between multiple StorageAreaImpl objects,
for example if multiple frames with the same origin use local storage.
- DerivedSources.make:
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::dispatchEvents):
(WebKit::StorageManager::setItem):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::~StorageAreaImpl):
- WebProcess/Storage/StorageAreaMap.cpp: Added.
(WebKit):
(WebKit::StorageAreaMap::create):
(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::~StorageAreaMap):
(WebKit::StorageAreaMap::didSetItem):
(WebKit::StorageAreaMap::dispatchStorageEvent):
- WebProcess/Storage/StorageAreaMap.h: Added.
(WebKit):
(StorageAreaMap):
- WebProcess/Storage/StorageAreaMap.messages.in: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaImpl.messages.in.
- 5:00 PM Changeset in webkit [148153] by
-
- 5 edits in trunk/Websites/bugs.webkit.org
Bugzilla should show bubbles from webkit-queues.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114391
Reviewed by Benjamin Poulain.
Include iframe from webkit-queues.appspot.com as well as one for webkit-commit-queue.appspot.com.
- code-review.js:
- template/en/custom/attachment/edit.html.tmpl:
- template/en/custom/attachment/list.html.tmpl:
- template/en/custom/attachment/reviewform.html.tmpl:
- 4:53 PM Changeset in webkit [148152] by
-
- 2 edits in trunk/Tools
Remove abarth from watchlists
https://bugs.webkit.org/show_bug.cgi?id=114390
Reviewed by Ryosuke Niwa.
I'm trying to cut down on the amount of bugmail I get so that I'll have
more of a chance to notice a piece of bugmail directed at me.
- Scripts/webkitpy/common/config/watchlist:
- 4:44 PM Changeset in webkit [148151] by
-
- 3 edits in trunk/Tools
webkit-test-results.appspot.com loads the dashboard for Chromium by default
https://bugs.webkit.org/show_bug.cgi?id=114381
Reviewed by Benjamin Poulain.
Changed the defaults.
- TestResultServer/static-dashboards/builders.js:
- TestResultServer/static-dashboards/dashboard_base.js:
(currentBuilderGroupCategory):
- 4:34 PM Changeset in webkit [148150] by
-
- 4 edits2 adds in branches/safari-536.30-branch
Merge 136250. <rdar://problem/13335010>
- 4:25 PM Changeset in webkit [148149] by
-
- 2 edits in trunk/Source/WebCore
Inspector highlights are offset when the WKView has a header
https://bugs.webkit.org/show_bug.cgi?id=114389
-and corresponding-
<rdar://problem/13522434>
Reviewed by Sam Weinig.
rootViewToContents() and contentsToRootView() need to factor in the
headerHeight(), much like windowToContents() and contentsToWindow() do already.
- platform/ScrollView.cpp:
(WebCore::ScrollView::rootViewToContents):
(WebCore::ScrollView::contentsToRootView):
- 4:22 PM Changeset in webkit [148148] by
-
- 6 edits3 moves in trunk/Source/WebKit2
Rename StorageAreaProxy to StorageAreaImpl.
Rubber-stamped by Beth Dakin.
- DerivedSources.make:
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::dispatchEvents):
(WebKit::StorageManager::setItem):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Storage/StorageAreaImpl.cpp: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp.
- WebProcess/Storage/StorageAreaImpl.h: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.h.
- WebProcess/Storage/StorageAreaImpl.messages.in: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.messages.in.
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::storageArea):
- WebProcess/Storage/StorageNamespaceImpl.h:
(WebKit):
(StorageNamespaceImpl):
- 4:21 PM Changeset in webkit [148147] by
-
- 5 edits2 moves in trunk/Source/WebKit2
Rename StorageNamespaceProxy to StorageNamespaceImpl.
Rubber-stamped by Beth Dakin.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::create):
(WebKit::StorageAreaProxy::StorageAreaProxy):
- WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
- WebProcess/Storage/StorageNamespaceImpl.cpp: Renamed from Source/WebKit2/WebProcess/Storage/StorageNamespaceProxy.cpp.
- WebProcess/Storage/StorageNamespaceImpl.h: Renamed from Source/WebKit2/WebProcess/Storage/StorageNamespaceProxy.h.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::sessionStorageNamespace):
- 4:11 PM Changeset in webkit [148146] by
-
- 6 edits in trunk/Tools
Remove Chromium EWS bots from the queue status server
https://bugs.webkit.org/show_bug.cgi?id=113988
Reviewed by Benjamin Poulain.
Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
- QueueStatusServer/app.yaml:
- QueueStatusServer/config/queues.py:
- QueueStatusServer/model/queues.py:
(Queue.short_name):
(Queue.display_name):
- QueueStatusServer/model/queues_unittest.py:
(QueueTest.test_short_name):
(QueueTest.test_display_name):
(QueueTest.test_name_with_underscores):
- QueueStatusServer/templates/activebots.html:
- 3:47 PM Changeset in webkit [148145] by
-
- 4 edits in trunk/Source/WebCore
Flesh out the Animations logging
https://bugs.webkit.org/show_bug.cgi?id=114388
Reviewed by Dean Jackson.
Log state changes and transition/animation creation and destruction
to the Animations log channel.
- page/animation/AnimationBase.cpp:
(WebCore::nameForState):
(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::goIntoEndingOrLoopingState):
(WebCore::AnimationBase::freezeAtTime):
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
- page/animation/KeyframeAnimation.h:
(WebCore::KeyframeAnimation::keyframes):
(KeyframeAnimation):
- 3:45 PM Changeset in webkit [148144] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/13047266> External XML entities are not loaded with modern libxml2
https://bugs.webkit.org/show_bug.cgi?id=114377
Reviewed by Darin Adler.
Covered by http/tests/security/xss-DENIED-xml-external-entity.xhtml when using
new enough libxml2.
- xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::switchToUTF16): Added a FIXME with an idea for improvement. (WebCore::XMLParserContext::createStringParser): Apply XML_PARSE_NOENT in a non-hacky way, so that the new libxml2 check doesn't fail. (WebCore::XMLParserContext::createMemoryParser): Updated an unhelpful and incorrect comment (XML_PARSE_NODICT actually means "Do not reuse the context dictionary").
- 3:35 PM Changeset in webkit [148143] by
-
- 2 edits in trunk/Source/WebKit2
[wk2] Un-pollute TCADA methods with "PageOverlayLayerMap::iterator end"
https://bugs.webkit.org/show_bug.cgi?id=114387
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::paintContents):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
- 3:25 PM Changeset in webkit [148142] by
-
- 4 edits3 adds in trunk
JSObject::getOwnNonIndexPropertyNames calculates numCacheableSlots incorrectly
https://bugs.webkit.org/show_bug.cgi?id=114235
Reviewed by Filip Pizlo.
If the object doesn't have any properties but the prototype does, we'll assume those prototype properties are
accessible in the base object's backing store, which is bad.
Source/JavaScriptCore:
- runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnNonIndexPropertyNames):
- runtime/PropertyNameArray.h:
(JSC::PropertyNameArray::PropertyNameArray):
(JSC::PropertyNameArray::setNumCacheableSlotsForObject):
(JSC::PropertyNameArray::setBaseObject):
(PropertyNameArray):
LayoutTests:
- fast/js/get-by-pname-only-prototype-properties-expected.txt: Added.
- fast/js/get-by-pname-only-prototype-properties.html: Added.
- fast/js/script-tests/get-by-pname-only-prototype-properties.js: Added.
(foo):
- 3:18 PM Changeset in webkit [148141] by
-
- 3 edits in trunk/Source/WebKit2
[wk2] REGRESSION: Find highlight does not update when the view is resized
https://bugs.webkit.org/show_bug.cgi?id=114382
<rdar://problem/13599797>
Reviewed by Simon Fraser.
Invalidate the page overlays from TiledCoreAnimationDrawingArea::updateGeometry.
This will have no effect if the page overlay hasn't previously asked to be painted
(as drawsContent will remain false on the layer).
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea): Add invalidateAllPageOverlays.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::invalidateAllPageOverlays): Factor this out of didChangeScrollOffsetForAnyFrame.
(WebKit::TiledCoreAnimationDrawingArea::didChangeScrollOffsetForAnyFrame): Call invalidateAllPageOverlays.
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry): Call invalidateAllPageOverlays.
- 2:53 PM Changeset in webkit [148140] by
-
- 2 edits in trunk/Source/WebCore
[Mac] in-band tracks sometimes not recognized
https://bugs.webkit.org/show_bug.cgi?id=114380
Reviewed by Jer Noble.
No new tests, covered by existing in-band tests.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Don't call selectMediaOption,
availableMediaCharacteristicsWithMediaSelectionOptions is unlikely to be loaded at this time.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Disable automatic text track
selection.
(WebCore::assetMetadataKeyNames): Watch for the status of availableMediaCharacteristicsWithMediaSelectionOptions
to change.
- 2:22 PM Changeset in webkit [148139] by
-
- 3 edits2 adds in trunk
[CSS Exclusions] Zoom causes shape-inside to fail when shape-padding is specified
https://bugs.webkit.org/show_bug.cgi?id=113730
Reviewed by Dirk Schulze.
Source/WebCore:
Snap computed margin and polygon boundaries to the LayoutUnit grid to ensure
that they fall within the shape's LayoutUnit bounding box.
Test: fast/exclusions/shape-inside/shape-inside-polygon-zoom.html
- rendering/ExclusionPolygon.cpp:
(WebCore::snapVerticesToLayoutUnitGrid): Convert the FloatPoint coordinates to LayoutUnits and then back to floats.
(WebCore::computeShapePaddingBounds): Now calls snapVerticesToLayoutUnitGrid() before creating a FloatPolygon.
(WebCore::computeShapeMarginBounds): Ditto.
LayoutTests:
Verify that content lays out within a padded shape-inside polygon when the
document has been zoomed.
- fast/exclusions/shape-inside/shape-inside-polygon-zoom-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-polygon-zoom.html: Added.
- 2:11 PM Changeset in webkit [148138] by
-
- 2 edits in trunk/Source/WebCore
One more unreviewed buildfix after r148123.
- platform/graphics/filters/CustomFilterMeshGenerator.h:
- 1:57 PM Changeset in webkit [148137] by
-
- 8 edits in trunk/Source
FindBanner matches are offset when the WKView has a header or footer
https://bugs.webkit.org/show_bug.cgi?id=114314
-and corresponding-
<rdar://problem/13522434>
Reviewed by Simon Fraser.
Source/WebCore:
There were already a few places in the code where we needed to adjust the
scrollOffset() to pretend that (0,0) is that the top of the Document rather than
the top of the header. To fix the FindBanner issues, we need to know that version
of the offset in a few more places, so I added a function on ScrollView to fetch
it called scrollOffsetRelativeToDocument().
New function subtracts out the headerHeight() to treat the top of
the document as (0,0).
- WebCore.exp.in:
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollOffsetRelativeToDocument):
Use scrollOffsetRelativeToDocument() where we were previously making this
calculation. Also re-name an inaccurately named variable where we are actually
converting FROM a document offset to a ScrollableArea offset.
(WebCore::ScrollView::windowToContents):
- platform/ScrollView.h:
(ScrollView):
getRectToExpose needs to know about the actual visibleContentRect and the
visibleContentRect that is relative to the Document. So this
patch adds a new parameter to getRectToExpose for that purpose.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::getRectToExpose):
- rendering/RenderLayer.h:
Source/WebKit2:
When calculating the matching rects, also adjust to the scroll offset that is
relative to the Document.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::rectsForTextMatches):
- 1:45 PM Changeset in webkit [148136] by
-
- 7 edits2 adds in trunk
when ARIA button contains a link, label text is ignored (affects main buttons on m.facebook.com)
https://bugs.webkit.org/show_bug.cgi?id=113906
Reviewed by Tim Horton.
Source/WebCore:
If an element does not expose any children, then it's safe to include all of its sub children when determining
the visible text.
The bug is that all elements were ignoring focusable elements (like <a>) when determining visible children text
Test: accessibility/link-inside-button-accessible-text.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::shouldUseAccessiblityObjectInnerText):
- accessibility/AccessibilityNodeObject.h:
(AccessibilityNodeObject):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isDescendantOfBarrenParent):
(AccessibilityObject):
LayoutTests:
The static-text-role-uses-text-under-element.html relies on similar logic to this bug.
I realized that it was verifying the wrong thing and if we had looked closely at this layout test
we would have caught this regression earlier most likely.
- accessibility/link-inside-button-accessible-text-expected.txt: Added.
- accessibility/link-inside-button-accessible-text.html: Added.
- platform/mac/accessibility/static-text-role-uses-text-under-element-expected.txt:
- platform/mac/accessibility/static-text-role-uses-text-under-element.html:
- 1:38 PM Changeset in webkit [148135] by
-
- 2 edits in trunk/Source/WebCore
AX: Make sure all AX methods called from outside call prepareAccessibility
https://bugs.webkit.org/show_bug.cgi?id=113818
Reviewed by Darin Adler.
Make sure any calls that can be made from outside WebCore are protected with the
prepareAccessibility method.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityMathRootIndexObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathRadicandObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathNumeratorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathDenominatorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathBaseObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSubscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSuperscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathUnderObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathOverObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedOpenString]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedCloseString]):
(-[WebAccessibilityObjectWrapper accessibilityIsMathTopObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathType]):
- 1:30 PM Changeset in webkit [148134] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove code duplicates from MacroAssemblerARM
https://bugs.webkit.org/show_bug.cgi?id=104457
Reviewed by Oliver Hunt.
Reuse some existing methods to avoid duplicated code.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::store8):
(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::swap):
(JSC::MacroAssemblerARM::add32):
(JSC::MacroAssemblerARM::sub32):
- 1:21 PM Changeset in webkit [148133] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed buildfix after r148123.
- inspector/InspectorInstrumentation.h:
(WebCore):
- 1:05 PM Changeset in webkit [148132] by
-
- 10 edits in trunk/Tools
Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114370
Reviewed by Ryosuke Niwa.
Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
Unfortunately, there's no way to test this until this is committed and there is
a master restart.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- TestResultServer/generate_builders_json.py:
- TestResultServer/static-dashboards/dashboard_base.js:
- TestResultServer/static-dashboards/loader.js:
- 1:02 PM Changeset in webkit [148131] by
-
- 3 edits2 adds in trunk
Clicking on the volume slider of HTML5 elements is pausing sometimes
https://bugs.webkit.org/show_bug.cgi?id=112548
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-04-10
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/click-volume-bar-not-pausing.html
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
Calling the setDefaultHandled() method on the event prevents it
from being incorrectly propagated from the volume button up to the
MediaDocument.
LayoutTests:
Added test.
- media/click-volume-bar-not-pausing-expected.txt: Added.
- media/click-volume-bar-not-pausing.html: Added.
- 1:01 PM Changeset in webkit [148130] by
-
- 3 edits3 adds in trunk
DFG: Negative size for new Array() interpreted as large unsigned int
https://bugs.webkit.org/show_bug.cgi?id=114366
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Added new check in operationNewArrayWithSize() for a negative
size. If size is negative throw a "RangeError: Array size is not a
small enough positive integer" exception.
- dfg/DFGOperations.cpp:
LayoutTests:
New test to make sure DFG generated code for new Array() with a
computed negative size throws an exception.
- fast/js/dfg-negative-array-size-expected.txt: Added.
- fast/js/dfg-negative-array-size.html: Added.
- fast/js/script-tests/dfg-negative-array-size.js: Added.
- 12:56 PM Changeset in webkit [148129] by
-
- 17 edits2 moves in trunk/Source
[BlackBerry] Rename BlackBerry specific Texture class
https://bugs.webkit.org/show_bug.cgi?id=95781
Reviewed by Rob Buis.
Texture was a bit too generic and prone to name conflicts. Renamed it
to LayerTexture.
Source/WebCore:
No change in behavior, no new tests.
PR 322882
- PlatformBlackBerry.cmake:
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::drawSurface):
(WebCore::LayerCompositingThread::contentsTexture):
- platform/graphics/blackberry/LayerCompositingThread.h:
(LayerCompositingThread):
- platform/graphics/blackberry/LayerCompositingThreadClient.h:
(WebCore):
(WebCore::LayerCompositingThreadClient::contentsTexture):
- platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore::LayerFilterRenderer::applyActions):
- platform/graphics/blackberry/LayerFilterRenderer.h:
(LayerFilterRenderer):
- platform/graphics/blackberry/LayerRendererSurface.h:
(WebCore::LayerRendererSurface::texture):
(LayerRendererSurface):
- platform/graphics/blackberry/LayerTexture.cpp: Renamed from Source/WebCore/platform/graphics/blackberry/Texture.cpp.
(WebCore):
(WebCore::LayerTexture::LayerTexture):
(WebCore::LayerTexture::~LayerTexture):
(WebCore::LayerTexture::updateContents):
(WebCore::LayerTexture::setContentsToColor):
(WebCore::LayerTexture::protect):
- platform/graphics/blackberry/LayerTexture.h: Renamed from Source/WebCore/platform/graphics/blackberry/Texture.h.
(WebCore):
(LayerTexture):
(WebCore::LayerTexture::create):
(WebCore::LayerTexture::textureId):
(WebCore::LayerTexture::isDirty):
(WebCore::LayerTexture::hasTexture):
(WebCore::LayerTexture::isColor):
(WebCore::LayerTexture::isOpaque):
(WebCore::LayerTexture::isProtected):
(WebCore::LayerTexture::protect):
(WebCore::LayerTexture::unprotect):
(WebCore::LayerTexture::size):
(WebCore::LayerTexture::width):
(WebCore::LayerTexture::height):
(WebCore::LayerTexture::bytesPerPixel):
(WebCore::LayerTexture::sizeInBytes):
(WebCore::LayerTexture::setTextureId):
(WebCore::LayerTexture::setSize):
- platform/graphics/blackberry/LayerTile.cpp:
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::updateContents):
(WebCore::LayerTile::setTexture):
- platform/graphics/blackberry/LayerTile.h:
(WebCore::LayerTile::texture):
(LayerTile):
- platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::drawTile):
(WebCore::LayerTiler::contentsTexture):
- platform/graphics/blackberry/LayerTiler.h:
(LayerTiler):
(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::updateContents):
(TextureJob):
- platform/graphics/blackberry/TextureCacheCompositingThread.cpp:
(WebCore::TextureProtector::TextureProtector):
(TextureProtector):
(WebCore::TextureCacheCompositingThread::allocateTextureId):
(WebCore::freeTextureId):
(WebCore::TextureCacheCompositingThread::textureResized):
(WebCore::TextureCacheCompositingThread::textureSizeInBytesChanged):
(WebCore::TextureCacheCompositingThread::textureDestroyed):
(WebCore::TextureCacheCompositingThread::install):
(WebCore::TextureCacheCompositingThread::resizeTexture):
(WebCore::TextureCacheCompositingThread::evict):
(WebCore::TextureCacheCompositingThread::textureAccessed):
(WebCore::TextureCacheCompositingThread::prune):
(WebCore::TextureCacheCompositingThread::textureForTiledContents):
(WebCore::TextureCacheCompositingThread::textureForColor):
(WebCore::TextureCacheCompositingThread::updateContents):
- platform/graphics/blackberry/TextureCacheCompositingThread.h:
(WebCore::TextureCacheCompositingThread::createTexture):
(TextureCacheCompositingThread):
(WebCore::TextureCacheCompositingThread::ZombieTexture::ZombieTexture):
(ZombieTexture):
Source/WebKit/blackberry:
PR 322882
- Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
- Api/WebOverlay_p.h:
(WebOverlayLayerCompositingThreadClient):
- 12:38 PM Changeset in webkit [148128] by
-
- 2 edits in trunk/Source/WebCore
Disallow programmatic movement of the browser window while user gestures are in progress.
<http://webkit.org/b/114271>
<rdar://problem/13226530>
Reviewed by Oliver Hunt.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::moveBy):
(WebCore::DOMWindow::moveTo):
(WebCore::DOMWindow::resizeBy):
(WebCore::DOMWindow::resizeTo):
- 12:33 PM Changeset in webkit [148127] by
-
- 3 edits in trunk/Source/JavaScriptCore
WinCairo build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=114358
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-10
Reviewed by Brent Fulgham.
Export the symbol WTF::MD5::checksum().
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 12:24 PM Changeset in webkit [148126] by
-
- 3 edits in trunk/Tools
[Qt] Fix regression to test-webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=114368
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
(PortFactory.get): Remove obsolete chromium port related code.
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.default_child_processes): Prevent type error if can't determine total memory.
- 12:18 PM Changeset in webkit [148125] by
-
- 2 edits in trunk/Source/WebKit2
Fixed build failure in Plugin.h: FloatPoint was not in namespace WebCore
make[1]: * Waiting for unfinished jobs....
In file included from Source/WebKit2/PluginProcess/PluginCreationParameters.h:31:0,
from Source/WebKit2/PluginProcess/PluginCreationParameters.cpp:27:
./Source/WebKit2/WebProcess/Plugins/Plugin.h:268:58: error: 'FloatPoint' in namespace 'WebCore' does not name a type
./Source/WebKit2/WebProcess/Plugins/Plugin.h:268:77: error: ISO C++ forbids declaration of 'parameter' with no type [-fpermissive]
cc1plus: warning: unrecognized command line option "-Wno-c++11-extensions" [enabled by default]
make[1]: * [Source/WebKit2/PluginProcess/libwebkit2gtk_3_0_la-PluginCreationParameters.lo] Error 1
It now passes that make target.
https://bugs.webkit.org/show_bug.cgi?id=111862
Patch by Tobias Mueller <tobiasmue@gnome.org> on 2013-04-10
Reviewed by Darin Adler.
- WebProcess/Plugins/Plugin.h:
(WebCore): Added FloatPoint to the WebCore namespace
- 12:16 PM Changeset in webkit [148124] by
-
- 2 edits in trunk/Source/WebCore
Refactor Editor::markAndReplaceFor before fixing autocorrection bugs
https://bugs.webkit.org/show_bug.cgi?id=114344
Reviewed by Enrica Casucci.
This patch refactors Editor::markAndReplaceFor so that we can start fixing bugs in a sane state.
Extracted isAutomaticTextReplacementType and correctSpellcheckingPreservingTextCheckingParagraph,
and made convenience local variables const.
In particular, shouldMarkSpelling used to be assigned of false when shouldShowCorrectionPanel was true
in a middle of a function but this was removed in favor of explicitly checking this condition later
since shouldMarkSpelling was only referenced once after the assignment.
- editing/Editor.cpp:
(WebCore::isAutomaticTextReplacementType): Extracted.
(WebCore::correctSpellcheckingPreservingTextCheckingParagraph): Extracted. Used highestAncestor
and rangeFromLocationAndLength to match the rest of the up-to-date editing code.
(WebCore::Editor::markAndReplaceFor): See above.
- 12:11 PM Changeset in webkit [148123] by
-
- 38 edits in trunk
Remove unneeded headers from FrameLoader.h
https://bugs.webkit.org/show_bug.cgi?id=114223
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Update for WTF changes.
- bytecode/SpeculatedType.h:
- runtime/JSCJSValue.h:
Source/WebCore:
Remove unneeded headers from FrameLoader.h and add them back into the respective .cpp files where needed.
- dom/Document.cpp:
- history/CachedFrame.cpp:
- history/PageCache.cpp:
- inspector/InspectorResourceAgent.cpp:
- loader/DocumentLoader.cpp:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad):
- loader/FrameLoader.h:
(WebCore):
(WebCore::FrameLoader::policyChecker):
(WebCore::FrameLoader::history):
(WebCore::FrameLoader::icon):
- loader/MixedContentChecker.h:
- loader/icon/IconLoader.cpp:
- page/History.cpp:
- page/Page.cpp:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- testing/Internals.cpp:
Source/WebKit/blackberry:
Include HistoryController.h from WebCore.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
Source/WebKit/mac:
Include HistoryController.h from WebCore.
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebView.mm:
Source/WebKit/win:
Include HistoryController.h from WebCore.
- WebView.cpp:
Source/WebKit2:
Include HistoryController.h from WebCore.
- WebProcess/Plugins/PDF/SimplePDFPlugin.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebPage/WebPage.cpp:
Source/WTF:
- wtf/Forward.h:
Add PrintStream.
- wtf/HashTable.h:
Don't include DataLog.h unless DUMP_HASHTABLE_STATS_PER_TABLE is 1.
Tools:
Add back headers implicitly included by other headers.
- WebKitTestRunner/WorkQueueManager.cpp:
- 12:03 PM Changeset in webkit [148122] by
-
- 2 edits in trunk/Source/WebCore
Minor code cleanup in AnimationBase::progress
https://bugs.webkit.org/show_bug.cgi?id=114371
Reviewed by Dean Jackson.
Convert some "return; else if" to just "return; if".
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::progress):
- 11:56 AM Changeset in webkit [148121] by
-
- 3 edits2 adds in trunk
Empty inline continuations should only get lineboxes if the padding applies to their side of the inline
https://bugs.webkit.org/show_bug.cgi?id=113896
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/inline/inline-with-empty-inline-continuations.html
Where an empty inline is split across anonymous blocks we should only give lineboxes to the 'sides' of the
inline that have borders, padding or margin.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::shouldApplyStartBorderPaddingOrMargin):
(WebCore):
(WebCore::shouldApplyEndBorderPaddingOrMargin):
(WebCore::hasInlineDirectionBordersPaddingOrMargin):
(WebCore::alwaysRequiresLineBox):
LayoutTests:
- fast/inline/inline-with-empty-inline-continuations-expected.txt: Added.
- fast/inline/inline-with-empty-inline-continuations.html: Added.
- 11:53 AM Changeset in webkit [148120] by
-
- 4 edits2 adds in trunk
[CSS Exclusions] Increasing padding does not correctly layout child blocks
https://bugs.webkit.org/show_bug.cgi?id=112929
Reviewed by David Hyatt.
If a child block has changed dimension inside a shape and it has affected the block siblings
we need to relayout the content inside the shape.
Source/WebCore:
Test: fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout): Add condition for dimension change.
(WebCore::RenderBlock::layoutBlock): Call updateRegionsAndExclusionsAfterChildLayout with the new parameter.
- rendering/RenderBlock.h:
(RenderBlock): Add extra parameter to updateRegionsAndExclusionsAfterChildLayout(...)
LayoutTests:
- fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html: Added.
- 11:51 AM Changeset in webkit [148119] by
-
- 42 edits2 deletes in trunk/Source
Removed bitrotted TimeoutChecker code
https://bugs.webkit.org/show_bug.cgi?id=114336
Reviewed by Alexey Proskuryakov.
This mechanism hasn't worked for a while.
MarkL is working on a new version of this feature with a distinct
implementation.
- API/APIShims.h:
(JSC::APIEntryShim::~APIEntryShim):
(JSC::APIEntryShim::init):
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGGPRInfo.h:
- jit/JIT.cpp:
- jit/JIT.h:
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/JSInterfaceJIT.h:
(JSInterfaceJIT):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
- runtime/JSGlobalObject.cpp:
- runtime/JSONObject.cpp:
(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::walk):
- runtime/TimeoutChecker.cpp: Removed.
- runtime/TimeoutChecker.h: Removed.
../WebCore:
This mechanism hasn't worked for a while.
MarkL is working on a new version of this feature with a distinct
implementation.
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonJSGlobalData):
- bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSMutationCallback.cpp:
(WebCore::JSMutationCallback::call):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneBase::CloneBase):
(WebCore::CloneSerializer::serialize):
(WebCore::CloneDeserializer::deserialize):
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
../WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setTimeoutForJavaScriptExecution):
../WebKit/mac:
This mechanism hasn't worked for a while.
MarkL is working on a new version of this feature with a distinct
implementation.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::evaluate):
../WebKit/qt:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createDocumentLoader):
../WebKit2:
This mechanism hasn't worked for a while.
MarkL is working on a new version of this feature with a distinct
implementation.
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::construct):
(WebKit::NPJSObject::invoke):
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::evaluate):
- 11:50 AM Changeset in webkit [148118] by
-
- 2 edits in trunk/Source/WebCore
Replace ENABLE_JAVASCRIPT_DEBUGGER preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114352
Reviewed by Timothy Hatcher.
The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
- page/Console.idl:
- 11:48 AM Changeset in webkit [148117] by
-
- 3 edits2 adds in trunk
Layers with opacity and blur filters are reported as opaque to the compositor
https://bugs.webkit.org/show_bug.cgi?id=114295
Reviewed by Simon Fraser.
Source/WebCore:
Test: compositing/contents-opaque/filter.html
Some filters like opacity and blur might still trigger transparency in the layer, even though the
background is opaque. I've added the special case in RenderLayer::backgroundIsKnownToBeOpaqueInRect to check
for filters that might have transparency. Note that this special case is required only for software drawn
filters, as the transparency is going to be backed in the GraphicsLayer content. Composited filters can
figure it out in the compositor.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
LayoutTests:
Added test to check for blur and opacity filters drawn in software mode which needs
to force the layer report non-opaque to the compositor.
- compositing/contents-opaque/filter-expected.txt: Added.
- compositing/contents-opaque/filter.html: Added.
- 11:37 AM Changeset in webkit [148116] by
-
- 2 edits in tags/Safari-537.35.11/Source/WebCore
Rollout r148109.
- 11:26 AM Changeset in webkit [148115] by
-
- 4 edits2 adds in trunk
[Texmap] In certain situations nested blending with overflow:hidden displays clipped results
https://bugs.webkit.org/show_bug.cgi?id=114290
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-10
Reviewed by Allan Sandfeld Jensen.
Source/WebCore:
Always apply the clip when binding a surface, even if it hasn't changed.
Otherwise when binding a nested surface and rebinding its container surface,
the clip wouldn't apply.
Test: compositing/overlap-blending/nested-overlap-overflow.html
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::bind):
LayoutTests:
Added a ref-test that exposes an issue with TextureMapper overlap blending when composited.
This ref-test does not show correct results on Mac, skipped in TestExpectations and created a bug.
- compositing/overlap-blending/nested-overlap-overflow-expected.html: Added.
- compositing/overlap-blending/nested-overlap-overflow.html: Added.
- platform/mac/TestExpectations: Skipped new tests and created bug.
- 11:17 AM Changeset in webkit [148114] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
I should know better than to lie in ChangeLog entries.
- 11:14 AM Changeset in webkit [148113] by
-
- 4 edits in trunk/Source/WebKit2
<rdar://problem/13617144> WKNavigationData needs to expose the destination of the navigation
Introduce WKNavigationDataCopyNavigationDestinationURL to access the destination of the navigation.
Reviewed by Darin Adler.
- UIProcess/API/C/WKNavigationData.cpp:
(WKNavigationDataCopyURL): Add a note about returning the URL from the original request for sake of
backwards-compatibility.
(WKNavigationDataCopyNavigationDestinationURL): Return the URL from our underlying WebNavigationDataStore.
- UIProcess/API/C/WKNavigationData.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::updateGlobalHistory): Store the current URL in to the WebNavigationDataStore
object. WKNavigationData can retrieve the value that we were previously storing here via the originalRequest.
- 11:14 AM Changeset in webkit [148112] by
-
- 4 edits in trunk/Source/WebKit2
<rdar://problem/13617104> WKPageCopySessionState needs to provide more context to the filter callback
Introduce a new value type for WKPageSessionStateFilterCallback that represents the passing
of whole WKBackForwardListItemRefs to the filter callback. This allows clients to consider
more than the original URL of the item when filtering entries from the session state.
Reviewed by Darin Adler.
- UIProcess/API/C/WKPage.cpp:
(WKPageGetSessionBackForwardListItemValueType): Return a static string representing our new value type.
- UIProcess/API/C/WKPage.h:
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Call the filter function with each of the
possible value types in turn, respecting the first false value, if any, that is returned.
- 11:07 AM Changeset in webkit [148111] by
-
- 4 edits in trunk/Source/WebCore
Use minimal tiles during live resize
https://bugs.webkit.org/show_bug.cgi?id=114364
Reviewed by Darin Adler.
We currently update non-visible speculative tiles during resizing. We should just drop them.
- page/FrameView.cpp:
(WebCore::FrameView::willStartLiveResize):
(WebCore::FrameView::willEndLiveResize):
- page/FrameView.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::computeTileCoverage):
Use minimal coverage in live resize state.
- 11:05 AM Changeset in webkit [148110] by
-
- 2 edits1 add in trunk/Tools
[GTK] Include a crash-fixing patch for the at-spi2-atk dependency
https://bugs.webkit.org/show_bug.cgi?id=114365
Reviewed by Martin Robinson.
Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
The patch addresses crashes in the tally_event_reply method. It is already committed into the
at-spi2-atk source tree and will be available with the next stable release, after which the
patch should be removed and the dependency version bumped.
- gtk/jhbuild.modules:
- gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
- 11:03 AM Changeset in webkit [148109] by
-
- 2 edits in tags/Safari-537.35.11/Source/WebCore
Merged r147977. <rdar://problem/13604480>
- 10:55 AM Changeset in webkit [148108] by
-
- 4 edits in tags/Safari-537.35.11/Source
Versioning.
- 10:51 AM Changeset in webkit [148107] by
-
- 1 copy in tags/Safari-537.35.11
New Tag.
- 10:47 AM Changeset in webkit [148106] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION (r148073): WebKit Nightly r148082 crashes on launch in JSObjectSetPrivate
https://bugs.webkit.org/show_bug.cgi?id=114341
Reviewed by Alexey Proskuryakov.
Make JSObjectSetPrivate use uncheckedToJS as some clients
clear their private data during finalization for some reason.
- API/JSObjectRef.cpp:
(JSObjectSetPrivate):
- 10:36 AM BuildingGtk edited by
- Warn that the instructions aren't really useful for building a release … (diff)
- 10:13 AM Changeset in webkit [148105] by
-
- 19 edits4 adds in trunk
Blob content type normalization.
https://bugs.webkit.org/show_bug.cgi?id=111380
Patch by Victor Costan <costan@gmail.com> on 2013-04-10
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Tests: http/tests/fast/files/blob-constructor.js
http/tests/fileapi/xhr-send-form-data-filename-escaping.html
http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html
- WebCore.exp.in: exported Blob::isNormalizedContentType()
- bindings/js/JSBlobCustom.cpp:
(WebCore::JSBlobConstructor::constructJSBlob): remove checks on Blob type, BlobBuilder will normalize it
- fileapi/Blob.cpp:
(BlobType): utilities for normalizing a Blob's type according to the File API spec
(WebCore::BlobType::isValid): content type validity checks in the File API spec
(WebCore::BlobType::normalize): implements the normalization rules in the File API spec
(WebCore::BlobType::isNormalized): useful for ASSERTing that a Blob type has been normalized
(WebCore): implement Blob type normalization according to the File API spec
(WebCore::Blob::Blob): normalize the Blob type in the data URL
(WebCore::Blob::slice): normalize the Blob type argument
- fileapi/Blob.h:
(BlobType): utilities for normalizing a Blob's type according to the File API spec
(WebCore::Blob::create): assert that the deserialized Blob's type was normalized
- fileapi/File.cpp:
(WebCore::createBlobDataForFileWithType): assert that the File's MIME type is a normalized Blob type
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::BlobBuilder::getBlob): normalize the Blob's type before building it
- platform/network/BlobData.h:
(WebCore::BlobData::setContentType): assert that the Blob type has been normalized
- platform/network/FormData.cpp:
(WebCore::FormData::appendKeyValuePairItems): assert that Blob's type has been normalized
- platform/network/FormDataBuilder.cpp:
(WebCore::FormDataBuilder::addContentTypeToMultiPartHeader): assert that the Content-Type field is normalized
- xml/XMLHttpRequest.cpp: when responseType is blob, normalize Content-Type before passing to Blob constructor
LayoutTests:
- http/tests/fast/files/script-tests/blob-constructor.js: added/updated test cases for Blob type normalization
- http/tests/fast/files/blob-constructor-expected.txt: added/updated test cases for Blob type normalization
- http/tests/fileapi/xhr-send-form-data-filename-escaping-expected.txt: Added.
- http/tests/fileapi/xhr-send-form-data-filename-escaping.html: Added.
- http/tests/fileapi/xhr-send-form-data-mimetype-normalization-expected.txt: Added.
- http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html: Added.
- http/tests/local/formdata/resources/send-form-data-common.js:
(dumpResponse): return the HTTP response text so it can be used in JS test code
(sendFormData): passthrough the HTTP response text returned by dumpResponse()
(testSendingFormData): passthrough the HTTP response text returned by dumpResponse()
- http/tests/xmlhttprequest/post-blob-content-type-async-expected.txt: updated expectation for invalid Content-Type
- http/tests/xmlhttprequest/post-blob-content-type-sync-expected.txt: updated expectation for invalid Content-Type
- http/tests/xmlhttprequest/post-blob-content-type-tests.js: updated expectation for invalid Content-Type
- 10:11 AM Changeset in webkit [148104] by
-
- 13 edits8 deletes in trunk/LayoutTests
Rebaseline four tiled drawing tests affeted by r148049.
Move results from platform/mac/platform/mac-wk2/tiled-drawing to platform/mac-wk2/tiled-drawing
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view-expected.txt:
- platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt: Removed.
- 9:50 AM Changeset in webkit [148103] by
-
- 2 edits in trunk/Tools
[WinCairo] Unreviewed build fix. Correct DropBox download link.
- Scripts/update-webkit-wincairo-libs: Revise download URL to
match change in DropBox server behavior.
- 9:32 AM Changeset in webkit [148102] by
-
- 3 edits in trunk/Source/WebCore
TileController doesn't remove tiles when the view is resized, leading to stale content
https://bugs.webkit.org/show_bug.cgi?id=114323
<rdar://problem/13520671>
Reviewed by Simon Fraser.
Ensure that tiles are removed if the view shrinks, so that they are not displayed
with stale content if the view later grows again (they will not be repainted by WebCore
while out-of-view).
- platform/graphics/ca/mac/TileController.h:
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::revalidateTiles):
- 9:28 AM Changeset in webkit [148101] by
-
- 2 edits in trunk/Source/WebCore
Update the localizable strings file.
Rubber-stamped by Dan Bernstein.
- English.lproj/Localizable.strings:
- 9:27 AM Changeset in webkit [148100] by
-
- 3 edits in trunk/Source/WebCore
Replace ENABLE_CHANNEL_MESSAGING preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114346
Reviewed by Geoffrey Garen.
The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
- page/DOMWindow.idl:
- workers/WorkerContext.idl:
- 9:25 AM Changeset in webkit [148099] by
-
- 32 edits in trunk/Source/WebCore
Update all float attributes in HTMLMediaElement to double
https://bugs.webkit.org/show_bug.cgi?id=113615
Reviewed by Geoffrey Garen
Patch by Aaron Colwell
No new tests. Primary behavior doesn't change. Just time, playbackRate, and volume precision.
All existing LayoutTests/media tests still pass.
- WebCore.exp.in: Remove function that no longer need to be exported.
- html/HTMLMediaElement.cpp: Change all float attributes to double.
- html/HTMLMediaElement.h: Ditto.
- html/HTMLMediaElement.idl: Ditto.
- html/MediaController.cpp: Ditto.
- html/MediaController.h: Ditto.
- html/MediaControllerInterface.h: Ditto.
- html/TimeRanges.cpp: Ditto.
- html/TimeRanges.idl: Ditto.
- html/shadow/MediaControlElementTypes.cpp: Ditto.
- html/shadow/MediaControlElementTypes.h: Ditto.
- html/shadow/MediaControlElements.cpp: Ditto.
- html/shadow/MediaControlElements.h: Ditto.
- html/shadow/MediaControls.cpp: Ditto.
- html/shadow/MediaControlsApple.cpp: Ditto.
- html/shadow/MediaControlsBlackBerry.cpp: Ditto.
- html/shadow/MediaControlsBlackBerry.h: Ditto.
- html/shadow/MediaControlsGtk.cpp: Ditto.
- html/track/TextTrackCue.cpp: Ditto.
- html/track/TextTrackCue.h: Ditto.
- platform/Clock.h: Ditto.
- platform/ClockGeneric.cpp: Ditto.
- platform/ClockGeneric.h: Ditto.
- platform/graphics/MediaPlayer.cpp: Ditto.
- platform/graphics/MediaPlayer.h: Ditto.
- platform/graphics/MediaPlayerPrivate.h: Ditto.
- platform/mac/PlatformClockCA.cpp: Ditto.
- platform/mac/PlatformClockCA.h: Ditto.
- platform/mac/PlatformClockCM.h: Ditto.
- platform/mac/PlatformClockCM.mm: Ditto.
- 9:16 AM Changeset in webkit [148098] by
-
- 3 edits in trunk/Source/WebCore
Replace ENABLE_MICRODATA preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114349
Reviewed by Geoffrey Garen.
The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
- dom/Document.idl:
- html/HTMLElement.idl:
- 9:13 AM Changeset in webkit [148097] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r148034): IconDatabase::updateIconRecord crashes with null iconData and iconBitmap.
https://bugs.webkit.org/show_bug.cgi?id=114356
Reviewed by Tim Horton.
When loading an icon fails (for example, when a non-existent URI is
passed to the loader), updateIconRecord can be called with both
iconData and iconBitmap having no data.
This used to be fine before r148034, but causes an assertion now.
No new tests, existing tests such as fast/encoding/mispositioned-meta.html
were crashing.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::updateIconRecord): Change the ASSERT() to check
for a NAND condition that only fails if both iconData and iconBitmap
are not 0.
- 8:44 AM Changeset in webkit [148096] by
-
- 2 edits in trunk/Tools
Removed an annoying message from svn-create-patch
https://bugs.webkit.org/show_bug.cgi?id=114332
Reviewed by Alexey Proskuryakov.
I see this message basically every time I write a patch, so it must not
be true.
- Scripts/svn-create-patch:
(generateDiff):
- 8:10 AM Changeset in webkit [148095] by
-
- 5 edits in trunk/Source/WebKit/qt
[Qt] Add API in QWebSettings for setting the CSS media type
https://bugs.webkit.org/show_bug.cgi?id=113853
Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-04-10
Reviewed by Jocelyn Turcotte.
- Api/qwebsettings.cpp:
(QWebSettingsPrivate):
(QWebSettingsPrivate::apply):
(QWebSettings::setCSSMediaType):
(QWebSettings::cssMediaType):
- Api/qwebsettings.h:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::overrideMediaType):
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage):
(tst_QWebPage::cssMediaTypeGlobalSetting):
(tst_QWebPage::cssMediaTypePageSetting):
- 7:58 AM Changeset in webkit [148094] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] Update a dirty region which is not covered with keepRect.
https://bugs.webkit.org/show_bug.cgi?id=113752
Patch by JungJik Lee <jungjik.lee@samsung.com> on 2013-04-10
Reviewed by Jocelyn Turcotte.
There can be a dirty region which is not covered with keepRect.
However the dirty could be inside the tile area. In this case,
currently we ignore the dirty by intersecting with keepRect
and the dirty region will not be invalidated until the tile is
recreated. We must expand the keep rect to its intersecting tiles
to make sure that the dirty region is applied to existing tiles.
No tests needed, change is unobservable.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::invalidate):
- 7:36 AM Changeset in webkit [148093] by
-
- 4 edits in trunk/Source
Remove ENABLE_3D_PLUGIN
https://bugs.webkit.org/show_bug.cgi?id=108002
Source/WebCore:
Remove ENABLE_3D_PLUGIN, it was only used by Chromium.
Reviewed by Antti Koivisto.
No new tests, removing dead code.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadPlugin):
Source/WTF:
Reviewed by Antti Koivisto.
Remove ENABLE_3D_PLUGIN, it was only used by Chromium.
- wtf/FeatureDefines.h:
- 6:47 AM Changeset in webkit [148092] by
-
- 1 edit57 adds in trunk/LayoutTests
[CSS Regions] Add tests for lists and counters
https://bugs.webkit.org/show_bug.cgi?id=103975
Reviewed by Antti Koivisto.
Lists and counters work correctly with regions since r148026 (http://trac.webkit.org/changeset/148026).
This patch adds W3C formatted ref tests to our battery.
- fast/regions/counters/extract-list-items-001-expected.html: Added.
- fast/regions/counters/extract-list-items-001.html: Added.
- fast/regions/counters/extract-list-items-002-expected.html: Added.
- fast/regions/counters/extract-list-items-002.html: Added.
- fast/regions/counters/extract-list-items-003-expected.html: Added.
- fast/regions/counters/extract-list-items-003.html: Added.
- fast/regions/counters/extract-list-items-004-expected.html: Added.
- fast/regions/counters/extract-list-items-004.html: Added.
- fast/regions/counters/extract-list-items-005-expected.html: Added.
- fast/regions/counters/extract-list-items-005.html: Added.
- fast/regions/counters/extract-list-items-006-expected.html: Added.
- fast/regions/counters/extract-list-items-006.html: Added.
- fast/regions/counters/extract-list-items-007-expected.html: Added.
- fast/regions/counters/extract-list-items-007.html: Added.
- fast/regions/counters/extract-list-items-008-expected.html: Added.
- fast/regions/counters/extract-list-items-008.html: Added.
- fast/regions/counters/extract-list-items-009-expected.html: Added.
- fast/regions/counters/extract-list-items-009.html: Added.
- fast/regions/counters/extract-list-items-010-expected.html: Added.
- fast/regions/counters/extract-list-items-010.html: Added.
- fast/regions/counters/extract-list-items-011-expected.html: Added.
- fast/regions/counters/extract-list-items-011.html: Added.
- fast/regions/counters/extract-list-items-012-expected.html: Added.
- fast/regions/counters/extract-list-items-012.html: Added.
- fast/regions/counters/extract-list-items-013-expected.html: Added.
- fast/regions/counters/extract-list-items-013.html: Added.
- fast/regions/counters/extract-list-items-014-expected.html: Added.
- fast/regions/counters/extract-list-items-014.html: Added.
- fast/regions/counters/extract-list-items-015-expected.html: Added.
- fast/regions/counters/extract-list-items-015.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-divs-001-expected.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-divs-001.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-divs-002-expected.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-divs-002.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-expected.html: Added.
- fast/regions/counters/extract-numbered-paragraphs.html: Added.
- fast/regions/counters/extract-numbered-spans-display-only-some-expected.html: Added.
- fast/regions/counters/extract-numbered-spans-display-only-some.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-001-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-001.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-002-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-002.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-003-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-003.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html: Added.
- fast/regions/counters/extract-unordered-lists-in-regions-expected.html: Added.
- fast/regions/counters/extract-unordered-lists-in-regions.html: Added.
- 5:18 AM Changeset in webkit [148091] by
-
- 10 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening. Rebaselining after r148049.
- platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
- 4:48 AM Changeset in webkit [148090] by
-
- 6 edits4 adds in trunk
[Texmap] Hierarchy of layers with opacity may result in wrong blending.
https://bugs.webkit.org/show_bug.cgi?id=113732
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-10
Reviewed by Allan Sandfeld Jensen.
Source/WebCore:
This is a combination of three issues with nested intermediate surfaces:
- glScissor inside an intermediate surface should not be mirrored.
- The current surface should be passed to the next surface in paintOptions.
- When clipping for the non-overlap region, the containing surface offset
should be applied.
Though the changes are separate, they cannot be tested separately as neither
fixes a testable case on its own.
Tests: compositing/overlap-blending/nested-non-overlap-clipping.html
compositing/overlap-blending/nested-overlap.html
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::ClipStack::reset):
(WebCore::TextureMapperGL::ClipStack::apply):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::clearIfNeeded):
- platform/graphics/texmap/TextureMapperGL.h:
(ClipStack):
Do not mirror the scissor clip when painting to an FBO.
Also a minor refactor to avoid reading the viewport values from the driver.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):
Apply the offset when clipping for a non-overlap region.
(WebCore::TextureMapperLayer::paintIntoSurface):
Make sure the current surface is passed to the next one.
LayoutTests:
Added two ref-tests for nested composited overlaps.
This ref-test does not work on Mac due to a slight mismatch opacity value on CoreAnimation.
A new bug has been posted, and TestExpectations has been updated.
- compositing/overlap-blending/nested-non-overlap-clipping-expected.html: Added.
- compositing/overlap-blending/nested-non-overlap-clipping.html: Added.
- compositing/overlap-blending/nested-overlap-expected.html: Added.
- compositing/overlap-blending/nested-overlap.html: Added.
- platform/mac/TestExpectations: Skipped new tests and created bug.
- 4:34 AM Changeset in webkit [148089] by
-
- 19 edits2 copies2 adds in trunk
Create fewer tiles when page is loading
https://bugs.webkit.org/show_bug.cgi?id=114294
Source/WebCore:
Reviewed by Anders Carlsson.
We currently create speculative tiles immediately. Page is often changing rapidly during loading and
keeping the speculative tiles up to date creates extra work.
Tests: platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative.html
platform/mac-wk2/tiled-drawing/tile-coverage-speculative.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadProgressingStatusChanged):
- page/FrameView.cpp:
(WebCore::FrameView::adjustTiledBackingCoverage):
(WebCore::FrameView::setWasScrolledByUser):
User scrolling enables speculative tiling no matter what the load status.
- page/FrameView.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::computeTileCoverage):
(WebCore::RenderLayerBacking::adjustTiledBackingCoverage):
Cover only the viewport during loading.
LayoutTests:
Reviewed by Anders Carlsson.
Reduced initial tile counts and new tests for speculative tiles.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative.html: Added.
- platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-speculative-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/tile-coverage-speculative.html: Added.
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
- platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
- 3:48 AM Changeset in webkit [148088] by
-
- 14 edits in trunk
[GTK] Add support for Page Visibility
https://bugs.webkit.org/show_bug.cgi?id=97324
Patch by Anton Obzhirov <Anton Obzhirov> on 2013-04-10
Reviewed by Sam Weinig.
.:
Page Visibility has been enabled for GTK port.
New GTK unittest has been added.
- Source/autotools/SetupWebKitFeatures.m4:
Source/WebKit/gtk:
Implemented access to page visibility API for GTK test runner.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setPageVisibility):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
Source/WebKit2:
Added new unittest to test page visibility using GTK Widget visibility API.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewPageVisibility):
(beforeAll):
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::showInWindow):
- UIProcess/API/gtk/tests/WebViewTest.h:
Tools:
Implemented test runner API for page visibility layout tests.
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::resetPageVisibility):
(TestRunner::setPageVisibility):
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
- platform/gtk/TestExpectations:
- 2:47 AM Changeset in webkit [148087] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] RenderThemeBlackBerry: get rid of all the SKIA code
https://bugs.webkit.org/show_bug.cgi?id=114339
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-10
Reviewed by Carlos Garcia Campos.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderThumb):
- 2:17 AM Changeset in webkit [148086] by
-
- 2 edits in trunk/Tools
[ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
https://bugs.webkit.org/show_bug.cgi?id=114342
Reviewed by Gyuyoung Kim.
Commit 148033 only added an implementation for the Mac port, which made
other ports fail most tests since loading the injected bundle failed
with a missing symbol.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::pathDescription):
- 2:06 AM Changeset in webkit [148085] by
-
- 9 edits1 move1 add1 delete in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaselining after r148049.
- platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt: Removed.
- platform/qt/compositing/iframes/page-cache-layer-tree-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/iframes/page-cache-layer-tree-expected.txt.
- platform/qt/fast/multicol/shadow-breaking-expected.txt:
- platform/qt/svg/css/composite-shadow-text-expected.png:
- platform/qt/svg/css/composite-shadow-text-expected.txt:
- platform/qt/svg/css/group-with-shadow-expected.txt:
- platform/qt/svg/css/path-with-shadow-expected.txt:
- platform/qt/svg/css/shadow-and-opacity-expected.txt:
- platform/qt/svg/css/shadow-breaking-expected.png: Added.
- platform/qt/svg/css/text-shadow-multiple-expected.txt:
- platform/qt/transitions/svg-text-shadow-transition-expected.txt:
- 12:55 AM Changeset in webkit [148084] by
-
- 2 edits in trunk/Tools
[EFL] Add spell checking option to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=114282
Patch by Artur Moryc <a.moryc@samsung.com> on 2013-04-10
Reviewed by Ryosuke Niwa.
Spell checking is enabled by adding a flag (t/text-checking)
with launching MiniBrowser.
- MiniBrowser/efl/main.c:
(window_create):
(elm_main):
- 12:39 AM Changeset in webkit [148083] by
-
- 5 edits in trunk
REGRESSION (r146518): WebKit2APITests/TestInspector is failing
https://bugs.webkit.org/show_bug.cgi?id=113281
Reviewed by Darin Adler.
Source/WebKit2:
Changes to the WebInspectorProxy opening processing in r146518 caused the change in how the GTK-specific
WebInspectorProxy code operates, specifically the 'bring-to-front' signal is not emitted anymore when opening the
inspector due to the WebInspectorProxy::bringToFront method now only bringing the inspector window to front if it exists
and opening it (and thus unable to bring it to front) otherwise.
Closing of the inspector through the didClose method is now done immediately after sending the WebInspector::Close()
message to the WebProcess rather than waiting for the WebProcess to communicate back the order of closing. Due to this
the relevant code in the test cases had to be changed to not run the loop but rather just check that the closing was
successful.
(InspectorTest::InspectorTest): Remove the initialization of the now redundant m_quitOnBringToFront member variable.
(InspectorTest::bringToFront): Quit the loop without checking the removed member variable.
(InspectorTest::closed): Do not quit the loop as it is not run anymore.
(InspectorTest::showIdle): A helper method that asynchronously calls the webkit_web_inspector_show method, removing some
unnecessary complexity about under what exact circumstances to quit the loop in open-window/bring-to-front callbacks.
(InspectorTest::show): Replaces the showAndWaitUntilFinished method, adding an idle invocation of the showIdle helper
method and running the loop.
(InspectorTest::close): Formerly closeAndWaitUntilClosed, now does not run the loop anymore as there's no need for it.
(testInspectorDefault): Only the window opening event is now expected upon showing the inspector for the first time.
Adjusting callsites to use InspectorTest::show and InspectorTest::close instead of
InspectorTest::showAndWaitUntilFinished and InspectorTest::showAndWaitUntilFinished.
(CustomInspectorTest::destroyWindow): Formerly destroyWindowAndWaitUntilClosed, the closing is not asynchronous anymore
so the loop is not run.
(testInspectorManualAttachDetach): Only the window opening event is now expected upon showing the inspector for the first time.
Adjusting callsites to use InspectorTest::show and InspectorTest::close instead of
InspectorTest::showAndWaitUntilFinished and InspectorTest::showAndWaitUntilFinished.
(testInspectorCustomContainerDestroyed): Adjusting callsites to use InspectorTest::show and CustomInspectorTest::destroyWindow
instead of InspectorTest::showAndWaitUntilFinished and CustomInspectorTest::destroyWindowAndWaitUntilClosed.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::show): When showing a connected WebInspectorProxy, call the bringToFront method which will
open the inspector if it's not yet visible or bring it to the front otherwise.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
- 12:38 AM Changeset in webkit [148082] by
-
- 3 edits in trunk/Source/WebKit2
[GTK][WK2] Implement WebInspectorProxy::platformInspectedWindowWidth
https://bugs.webkit.org/show_bug.cgi?id=113498
Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-04-10
Reviewed by Martin Robinson.
The method was introduced in r147004.
- UIProcess/API/gtk/tests/TestInspector.cpp: Specify the gMinimumAttachedInspectorWidth variable, reflecting the value
of WebInspectorProxy::minimumAttachedWidth. Use it as the width to which the inspected view should be resized in
InspectorTest::resizeViewAndAttach.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformInspectedWindowHeight): Use the gtk_widget_get_allocated_height method to return the
widget height.
(WebKit::WebInspectorProxy::platformInspectedWindowWidth): Newly implemented, similarly uses the
gtk_widget_get_allocated_width method to return the widget width.
- 12:36 AM Changeset in webkit [148081] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r147719): Failures in two a11y tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=114259
Reviewed by Ryosuke Niwa.
No new tests - covered by existing tests.
Partially revert r147719, restoring the possible creation of the AXObject cache
and the subsequent call to its handleFocusedUIElementChanged method. Removing this
code caused regressions in accessibility tests on the GTK port, so the comment about
the AXObject cache is adjusted accordingly.
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
- 12:18 AM Changeset in webkit [148080] by
-
- 11 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r148049.
- platform/gtk/fast/multicol/shadow-breaking-expected.txt:
- platform/gtk/svg/css/composite-shadow-text-expected.txt:
- platform/gtk/svg/css/group-with-shadow-expected.txt:
- platform/gtk/svg/css/path-with-shadow-expected.txt:
- platform/gtk/svg/css/shadow-and-opacity-expected.txt:
- platform/gtk/svg/css/shadow-changes-expected.txt:
- platform/gtk/svg/css/text-gradient-shadow-expected.txt:
- platform/gtk/svg/css/text-shadow-multiple-expected.txt:
- platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.txt:
- platform/gtk/transitions/svg-text-shadow-transition-expected.txt:
Apr 9, 2013:
- 11:59 PM Changeset in webkit [148079] by
-
- 3 edits3 adds in trunk
[GStreamer] playbin uri getter is invalid
https://bugs.webkit.org/show_bug.cgi?id=113884
Reviewed by Martin Robinson.
Source/WebCore:
When loading a new media location use the url stored as a member
variable instead of the one stored as a playbin property. The uri
property semantic changed in playbin since 0.10.36+. One should
now use current-uri but to avoid ifdefs depending on GStreamer
version we simply use the url already known as member variable.
Test: http/tests/media/video-redirect.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
LayoutTests:
New test for Quicktime reference movie redirect
support.
- http/tests/media/resources/redirect-to-counting-captioned.mov: Added.
- http/tests/media/video-redirect-expected.txt: Added.
- http/tests/media/video-redirect.html: Added.
- 11:45 PM Changeset in webkit [148078] by
-
- 2 edits in trunk/Source/WebKit2
WKFrameIsDisplayingMarkupDocument should return true for Web Archives
https://bugs.webkit.org/show_bug.cgi?id=114291
Reviewed by Dean Jackson.
Also return true for the Web Archive MIME type since a Web Archive
is displaying a markup document by nature.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::isDisplayingMarkupDocument):
- 10:21 PM Changeset in webkit [148077] by
-
- 2 edits in trunk/Tools
Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
Unreviewed.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_build_check):
- 10:12 PM Changeset in webkit [148076] by
-
- 12 edits in trunk
[JSC] Script run from an isolated world should bypass a page's CSP
https://bugs.webkit.org/show_bug.cgi?id=100815
Reviewed by Oliver Hunt.
Source/WebCore:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
- bindings/js/ScriptController.h: Test the current caller's DOM wrapper
world to decide whether CSP should be enforced.
Like most of CSP, this is a stupid policy because it doesn't address
second-order effects like <script> parsing or event handler execution,
which might be triggered indirectly by privileged scripts. These indirect
effects are still broken. Oh well.
LayoutTests:
Enabled these tests, now that they pass.
I removed all the nonsense in these tests about setting an isolated world's
CSP and origin manually, since we have no use for those features.
- http/tests/security/isolatedWorld/bypass-main-world-csp-expected.txt:
- http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr-expected.txt:
- http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr.html:
- http/tests/security/isolatedWorld/bypass-main-world-csp.html:
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 9:59 PM Changeset in webkit [148075] by
-
- 11 edits11 deletes in trunk/Tools
[webkitpy] Remove chromium ports.
https://bugs.webkit.org/show_bug.cgi?id=114326
Reviewed by Dirk Pranke.
As a side effect, also:
- remove chromium builders from webkitpy.layout_tests.port.builders
- remove chromium builders from rebaseline
- rewrite chromium dependent tests in rebaseline_unittest
- remove chromium platform from garden-o-matic
- select apple platform as default platform in garden-o-matic
- remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_move_baselines):
(BaselineOptimizerTest.test_efl):
(BaselineOptimizerTest.test_no_add_mac_future):
(BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
(BaselineOptimizerTest.test_common_directory_includes_root):
(BaselineOptimizerTest.test_complex_shadowing):
(BaselineOptimizerTest.test_virtual_ports_filtered):
- Scripts/webkitpy/layout_tests/port/builders.py:
- Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/factory.py:
(platform_options):
(PortFactory):
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_qt):
(FactoryTest.test_get_from_builder_name):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_build_check):
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_expectations_path):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(Rebaseline._builders_to_pull_from):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(_BaseTestCase):
(_BaseTestCase.setUp):
(TestRebaselineTest.setUp):
(TestRebaselineTest.test_baseline_directory):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_test):
(test_rebaseline_test_and_print_scm_changes):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
(TestRebaselineExpectations.test_rebaseline_expectations):
- 6:59 PM Changeset in webkit [148074] by
-
- 2 edits in trunk/Source/WebCore
Remove chromium exceptions from WebCore's gitattributes
https://bugs.webkit.org/show_bug.cgi?id=114327
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-09
Reviewed by Darin Adler.
- .gitattributes:
- 6:23 PM Changeset in webkit [148073] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add liveness tests to JSC API entry points
https://bugs.webkit.org/show_bug.cgi?id=114318
Reviewed by Geoffrey Garen.
Add simple checks for the existence of a method table on any
JSCells passed across the API. This in turn forces a structure
validity test.
- API/APICast.h:
(toJS):
(toJSForGC):
(unsafeToJS):
- API/JSObjectRef.cpp:
(JSObjectGetPrivate):
- 6:11 PM Changeset in webkit [148072] by
-
- 3 edits2 adds in trunk
Update Document's event listener type bitfield when adopting a Node
https://bugs.webkit.org/show_bug.cgi?id=114322
Reviewed by Darin Adler.
Source/WebCore:
Without this, moving a Node between documents can silently deactivate
an event listener, if it's one of the types that whose creation is
optimized away by Document::hasListenerType.
An alternate approach would be to simply copy the old document's
bitfield over. It's a tradeoff between making adoption fast and making
the operation of any operation depending on these event types fast.
The latter seems like the right optimization given that adoption
doesn't happen very often.
Test: fast/events/event-listener-moving-documents.html
- dom/Node.cpp:
(WebCore::Node::didMoveToNewDocument): For each event listener type on the adopted node, update the new document's list of listener types.
LayoutTests:
- fast/events/event-listener-moving-documents-expected.txt: Added.
- fast/events/event-listener-moving-documents.html: Added.
- 5:57 PM Changeset in webkit [148071] by
-
- 5 edits in trunk/Source/WebCore
Add logging channel for animations
https://bugs.webkit.org/show_bug.cgi?id=114325
Reviewed by Simon Fraser.
- platform/Logging.cpp: Add LogAnimations.
(WebCore::getChannelFromName): Return LogAnimations for "Animations".
- platform/Logging.h: Add LogAnimations.
- platform/mac/LoggingMac.mm:
(WebCore::initializeLoggingChannelsIfNecessary): Copy preference.
- platform/win/LoggingWin.cpp:
(WebCore::initializeLoggingChannelsIfNecessary): Copy preference.
- 5:32 PM Changeset in webkit [148070] by
-
- 18 edits9 adds in trunk
[CSS3] Parsing the property, text-justify.
https://bugs.webkit.org/show_bug.cgi?id=100058
Reviewed by Andreas Kling.
This patch implements the parsing side of the "text-justify" property specified
in CSS3 working draft, with "-webkit-" prefix, under ENABLE_CSS3_TEXT flag.
Specification link : http://www.w3.org/TR/css3-text/#text-justify
Source/WebCore:
Tests: fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited.html
fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextJustify):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- css/StylePropertySet.cpp:
(WebCore):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
LayoutTests:
- fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-expected.txt: Added.
- fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited-expected.txt: Added.
- fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited.html: Added.
- fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html: Added.
- fast/css3-text/css3-text-justify/getComputedStyle/script-tests/getComputedStyle-text-justify-inherited.js: Added.
(testComputedStyle):
(ownValueTest):
(inheritanceTest):
- fast/css3-text/css3-text-justify/getComputedStyle/script-tests/getComputedStyle-text-justify.js: Added.
(testElementStyle):
(testComputedStyle):
(valueSettingTest):
(invalidValueSettingTest):
- platform/mac/TestExpectations: ditto
- platform/qt-4.8/TestExpectations: ditto
- platform/qt-mac/TestExpectations: ditto
- platform/qt/TestExpectations: ditto
- 5:17 PM Changeset in webkit [148069] by
-
- 3 edits in trunk/Source/WebCore
[GTK][AC] Adding contentsLayer for image and video
https://bugs.webkit.org/show_bug.cgi?id=113912
Reviewed by Gustavo Noronha Silva.
contentsLayer is a ClutterActor, which is added to the main layer
as a child when GraphicsLayer needs to render an image or video.
No new tests, already covered by existing AC tests.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorUpdateTexture):
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
(WebCore):
(WebCore::GraphicsLayerClutter::setContentsToImage): Pass a Cairo surface to GraphicsLayer.
(WebCore::GraphicsLayerClutter::setContentsNeedsDisplay):
(WebCore::GraphicsLayerClutter::setContentsRect):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerClutter::setupContentsLayer):
(WebCore::GraphicsLayerClutter::updateContentsImage): Set the Cairo surface for contentsLayer
to upload it as a texture.
(WebCore::GraphicsLayerClutter::updateContentsNeedsDisplay):
(WebCore::GraphicsLayerClutter::updateContentsRect):
(WebCore::GraphicsLayerClutter::updateSublayerList):
- platform/graphics/clutter/GraphicsLayerClutter.h:
(WebCore::GraphicsLayerClutter::hasContentsLayer):
(GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::contentsLayer):
- 5:04 PM Changeset in webkit [148068] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION: Blob URLs broken with NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=114320
Reviewed by Brady Eidson.
Update BlobResourceHandle to use modern resource client calls.
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::readSync): Don't call notifyReceiveData if there is no data (it's especially egregious when length is -1, signaling an error). (WebCore::BlobResourceHandle::notifyResponseOnSuccess): Use didReceiveResponseAsync when a client wants async callbacks. This is not very clean, as we don't wait for response, but should be workable for blobs. (WebCore::BlobResourceHandle::notifyResponseOnError): Ditto. (WebCore::BlobResourceHandle::notifyReceiveData): Use didReceiveBuffer (clients that only implement didReceiveData will have it automatically unwrapped).
- 5:03 PM Changeset in webkit [148067] by
-
- 2 edits in trunk/Source/JavaScriptCore
Rollout last patch as it destroyed everything
- 5:00 PM Changeset in webkit [148066] by
-
- 2 edits in trunk/LayoutTests
r148048 revealed that compositing/plugins/invalidate_rect.html was
only succeeded through chance, and cannot work as designed because
plugin painting is async on some platforms. Mark it as flakey.
- platform/mac/TestExpectations:
- 4:57 PM Changeset in webkit [148065] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r123837): Full screen transition is broken at apple.com
https://bugs.webkit.org/show_bug.cgi?id=95650
Reviewed by Simon Fraser.
Cancel any outstanding animations on <video> elements as they enter full screen, so as to
not confuse the WebKit/WebKit2 full screen window animation about the starting and destination
screen rects.
- css/fullscreen.css:
(video:-webkit-full-screen, audio:-webkit-full-screen):
- 4:52 PM Changeset in webkit [148064] by
-
- 3 edits in trunk/Source/WebCore
hang in mediaSelectionGroupForMediaCharacteristic
https://bugs.webkit.org/show_bug.cgi?id=114054
Reviewed by Eric Carlson.
No new tests; Fixes sporadic hangs in media/ tests.
-[AVURLAsset mediaSelectionGroupForMediaCharacteristic:] can deadlock in certain situations: When AVURLAsset
posts a synchronous AVAssetResourceLoader notification to the main thread, calling -mediaSelectionGroupForMediaCharacteristic:
on the main thread requires IO to occur if the media characteristics are not yet loaded. Instead of blocking,
bail out early if the media characteristics are not yet known.
Add a new method, safeMediaSelectionGroupForLegibleMedia(), which first checks selection group availability
before calling mediaSelectionGroupForMediaCharacteristic:.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
(MediaPlayerPrivateAVFoundationObjC):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForLegibleMedia): Added.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Use new safe method.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Ditto.
- 4:29 PM Changeset in webkit [148063] by
-
- 3 edits in trunk/Source/WebCore
AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817
Unreviewed build fix for iOS.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityPath]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
- 4:28 PM Changeset in webkit [148062] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add liveness tests to JSC API entry points
https://bugs.webkit.org/show_bug.cgi?id=114318
Reviewed by Filip Pizlo.
Add simple checks for the existence of a method table on any
JSCells passed across the API. This in turn forces a structure
validity test.
- API/APICast.h:
(toJS):
(toJSForGC):
- 4:22 PM Changeset in webkit [148061] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed correctness fix: use lroundf instead of lround for a float to int conversion.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):
- 4:04 PM Changeset in webkit [148060] by
-
- 2 edits in trunk/Source/WebCore
Change requisite hardware checks for enabling antialiasing.
https://bugs.webkit.org/show_bug.cgi?id=114101
<rdar://problem/12342776>.
m_maySupportMultisampling should be true by default for all platforms/hardware now except older versions of AMD.
Reviewed by Dean Jackson.
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):
- 3:55 PM Changeset in webkit [148059] by
-
- 8 edits2 deletes in trunk
Unreviewed, rolling out r148010.
http://trac.webkit.org/changeset/148010
https://bugs.webkit.org/show_bug.cgi?id=114310
Causes problems with focus rings (Requested by anttik on
#webkit).
Source/WebCore:
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyComputeLength::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
LayoutTests:
- fast/borders/border-width-less-then-a-unit-of-pt-expected.html: Removed.
- fast/borders/border-width-less-then-a-unit-of-pt.html: Removed.
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- 3:52 PM Changeset in webkit [148058] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, another fix for the Windows build after r148050.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::setFontSize): Use lround().
- 3:37 PM Changeset in webkit [148057] by
-
- 4 edits in trunk/LayoutTests
Rebaseline tests affected by r148049 or r148048.
- compositing/layer-creation/rotate3d-overlap-expected.txt:
- compositing/repaint/resize-repaint-expected.txt:
- compositing/repaint/resize-repaint.html: Allow the test to run
outside WTR/DRT.
- 3:31 PM Changeset in webkit [148056] by
-
- 5 edits2 adds in trunk
[CSS Exclusions] Properly position multiple stacked floats with non rectangular shape outside
https://bugs.webkit.org/show_bug.cgi?id=110372
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-04-09
Reviewed by Dean Jackson.
Source/WebCore:
Stacked floats get positioned based on the bounding box of the shape,
not on the shape contours itself. This patch causes that to happen.
Test: fast/exclusions/shape-outside-floats/shape-outside-floats-stacked.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat): Use the
"BoundingBoxOffset" mode so that we compute offsets based on the shape
bounding boxes of previous floats, not the shape contour.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Check the
ShapeOutsideFloatOffsetMode to determine if the offset should be
adjusted for the shape contour or not.
(WebCore::RenderBlock::logicalRightOffsetForLine): Ditto.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalRightOffsetForLine): Add parameter for offset mode.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Ditto.
(RenderBlock):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): If the
new float is being added on top of a previous float on the same line,
undo the offset for the previous float's shape contour so that we
position the new float based on the bounding box.
LayoutTests:
Tests demonstrating stacked floats properly working with shape-outside.
- fast/exclusions/shape-outside-floats/shape-outside-floats-stacked-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-stacked.html: Added.
- 3:02 PM Changeset in webkit [148055] by
-
- 2 edits in trunk/Tools
newcommitbot (WKR) requires a subversion checkout
https://bugs.webkit.org/show_bug.cgi?id=114309
Reviewed by Benjamin Poulain.
Directly talk to the subversion server instead of relying on a local checkout.
This allows us to run WKR off of a git clone.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.next_work_item):
(NewCommitBot.process_work_item):
- 2:35 PM Changeset in webkit [148054] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r147454): Youtube annotation links to new window broken
https://bugs.webkit.org/show_bug.cgi?id=114242
<rdar://problem/13609940>
Reviewed by Beth Dakin.
Set the current user gesture to "DefinitelyProcessingNewUserGesture" if popups are allowed.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performFrameLoadURLRequest):
- 2:30 PM Changeset in webkit [148053] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix the Windows build after r148050.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Use lround().
- 2:28 PM Changeset in webkit [148052] by
-
- 2 edits in trunk/Source/WebCore
[wk2] IconDatabase images should be decoded in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=112524
<rdar://problem/10133914>
Reviewed by Simon Fraser.
Move an ASSERT that dereferenced a pointer inside the null-check for that pointer.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::setIconBitmapForIconURL):
- 2:25 PM Changeset in webkit [148051] by
-
- 4 edits in trunk/Tools
webkitbot refers to sheriffbot in help
https://bugs.webkit.org/show_bug.cgi?id=114307
Reviewed by Benjamin Poulain.
Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
- Scripts/webkitpy/tool/bot/irc_command.py:
(Help):
(Help.execute):
(RollChromiumDEPS.execute):
- Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help):
- Scripts/webkitpy/tool/bot/sheriff.py:
(Sheriff.name):
- 1:56 PM Changeset in webkit [148050] by
-
- 24 edits2 adds in trunk
[Mac] user caption styles not applied to correct element
https://bugs.webkit.org/show_bug.cgi?id=114230
Reviewed by Jer Noble.
Source/WebCore:
Test: media/track/track-css-user-override.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Drive by clean-up so we don't log excessively.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement): Initialize
new member variables.
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Set cue font size when it is
inserted into the tree.
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Update the font size of
all active cues.
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Set size-relative CSS properties
after a time because this can be called during layout.
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::textTrackPreferencesChanged): Call closedCaptionTracksChanged before updateSizes.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::setFontSize): New, set the cue's font size.
- html/track/TextTrackCue.h:
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): Set cue properties on the cue element
instead of on the cue box to match what we do for the "cue" pseudo element.
(WebCore::TextTrackCueGeneric::setFontSize): New, set the cue's font size.
- html/track/TextTrackCueGeneric.h:
- html/track/TextTrackList.cpp:
(TextTrackList::remove): Drive-by cleanup, don't ASSERT when the media element is NULL.
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::setCaptionsStyleSheetOverride): New, allow user CSS overrides
to be tested in DRT.
(WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride): New, generate a user style
sheet override. Moved here from CaptionUserPreferencesMac.
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMac.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS): Don't ignore background color importance.
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Implement even when we don't
have the media accessibility framework so this can be tested in DRT. Apply all cue properties
to the element used for the "cue" pseudo element.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::didLoadingProgress): Drive-by cleanup, remove logging
because this method is called so frequently and the logging is not especially useful.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Only log when the ready/network
state changes because this method is called so frequently.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer): Drive-by cleanup, remove logging
because this method is called so frequently and the logging is not especially useful.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Make the logging more useful.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): Reset captions style sheet override.
(WebCore::Internals::captionsStyleSheetOverride): New, return the captions style sheet override.
(WebCore::Internals::setCaptionsStyleSheetOverride): New, override the captions style sheet override.
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- media/track/track-css-user-override-expected.txt: Added.
- media/track/track-css-user-override.html: Added.
- media/track/track-cue-container-rendering-position-expected.txt:
- media/track/track-cue-container-rendering-position.html:
- media/track/track-cue-rendering-expected.txt:
- media/track/track-cue-rendering.html: Font size is not applied instantly when a video element is
resized, so check after a very short delay.
- 1:52 PM Changeset in webkit [148049] by
-
- 66 edits2 adds in trunk
Repaint rect too small on elements with shadows
https://bugs.webkit.org/show_bug.cgi?id=114225
Source/WebCore:
Reviewed by Dain Adler.
We assumed that shadows (box-shadow, text-shadow, svg shadows)
only required inflating the repaint rect by the blur radius of
the shadow. However, this is incorrect; the shadow can extend
further, which resulted in clipped or incorrectly invalidated
shadows.
Fix by disambiguating the blur radius (which is 2x the standard
deviation of the Gaussian distribution used to generate the blur),
from the painting extent, which is how far the shadow visually
projects. Using a 1.4 multiplier of the blur radius is a good
approximation for the painting extent.
Renamed ShadowData::blur() to ShadowData::radius(), and added
ShadowData::paintingExtent(). Use the latter in all places
which relate to invalidation.
Test: fast/box-shadow/shadow-repaint.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontAttributesForSelectionStart):
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::applyShadowToGraphicsContext):
(WebCore::InlineTextBox::paintDecoration):
- rendering/RenderBoxModelObject.cpp:
(WebCore::applyBoxShadowForBackground):
(WebCore::areaCastingShadowInHole):
(WebCore::RenderBoxModelObject::paintBoxShadow):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowInsetExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):
- rendering/style/ShadowData.cpp:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::operator==):
(WebCore::calculateShadowExtent):
- rendering/style/ShadowData.h:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::radius):
(WebCore::ShadowData::paintingExtent):
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
LayoutTests:
Reviewed by Darin Alder.
New test for invalidation with box-shadow. Update test results affected
by shadow extent.
- compositing/geometry/foreground-layer-expected.txt:
- compositing/iframes/composited-parent-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- compositing/iframes/connect-compositing-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe2-expected.txt:
- compositing/iframes/connect-compositing-iframe3-expected.txt:
- compositing/iframes/enter-compositing-iframe-expected.txt:
- compositing/iframes/iframe-resize-expected.txt:
- compositing/iframes/invisible-nested-iframe-show-expected.txt:
- compositing/iframes/overlapped-iframe-expected.txt:
- compositing/iframes/page-cache-layer-tree-expected.txt:
- compositing/iframes/scrolling-iframe-expected.txt:
- compositing/visible-rect/iframe-and-layers-expected.txt:
- fast/box-shadow/shadow-repaint-expected.txt: Added.
- fast/box-shadow/shadow-repaint.html: Added.
- platform/mac/fast/multicol/shadow-breaking-expected.png:
- platform/mac/fast/multicol/shadow-breaking-expected.txt:
- platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
- platform/mac/fast/repaint/moving-shadow-on-path-expected.png:
- platform/mac/fast/repaint/moving-shadow-on-path-expected.txt:
- platform/mac/svg/css/arrow-with-shadow-expected.png:
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.png:
- platform/mac/svg/css/clippath-with-shadow-expected.png:
- platform/mac/svg/css/composite-shadow-example-expected.png:
- platform/mac/svg/css/composite-shadow-example-expected.txt:
- platform/mac/svg/css/composite-shadow-text-expected.txt:
- platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
- platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
- platform/mac/svg/css/group-with-shadow-expected.png:
- platform/mac/svg/css/group-with-shadow-expected.txt:
- platform/mac/svg/css/mask-with-shadow-expected.png:
- platform/mac/svg/css/path-with-shadow-expected.png:
- platform/mac/svg/css/path-with-shadow-expected.txt:
- platform/mac/svg/css/shadow-and-opacity-expected.png:
- platform/mac/svg/css/shadow-and-opacity-expected.txt:
- platform/mac/svg/css/shadow-changes-expected.png:
- platform/mac/svg/css/shadow-changes-expected.txt:
- platform/mac/svg/css/shadow-with-large-radius-expected.png:
- platform/mac/svg/css/shadow-with-negative-offset-expected.png:
- platform/mac/svg/css/stars-with-shadow-expected.png:
- platform/mac/svg/css/stars-with-shadow-expected.txt:
- platform/mac/svg/css/text-gradient-shadow-expected.png:
- platform/mac/svg/css/text-gradient-shadow-expected.txt:
- platform/mac/svg/css/text-shadow-multiple-expected.png:
- platform/mac/svg/custom/repaint-shadow-expected.png:
- platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.txt:
- svg/css/arrow-with-shadow-expected.txt:
- svg/css/circle-in-mask-with-shadow-expected.txt:
- svg/css/clippath-with-shadow-expected.txt:
- svg/css/mask-with-shadow-expected.txt:
- svg/css/shadow-with-large-radius-expected.txt:
- svg/css/shadow-with-negative-offset-expected.txt:
- svg/css/text-shadow-multiple-expected.txt:
- svg/custom/repaint-shadow-expected.txt:
- svg/filters/shadow-on-rect-with-filter-expected.txt:
- svg/repaint/repaint-webkit-svg-shadow-container-expected.txt:
- 1:52 PM Changeset in webkit [148048] by
-
- 2 edits in trunk/Source/WebCore
window.internals.repaintRectsAsText() is hard to use because it doesn't force layout
https://bugs.webkit.org/show_bug.cgi?id=114219
Reviewed by Beth Dakin.
Force layout when setTracksRepaints() is set to true, to flush out any pending
repaints from a layout that hasn't happened yet. Also force layout in
trackedRepaintRectsAsText(), so that any pending layout happpens and thus
repaints.
- page/FrameView.cpp:
(WebCore::FrameView::setTracksRepaints):
(WebCore::FrameView::trackedRepaintRectsAsText):
- 1:48 PM Changeset in webkit [148047] by
-
- 10 edits2 adds in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should provide utilities for common OSR exit tasks
https://bugs.webkit.org/show_bug.cgi?id=114306
Reviewed by Mark Hahnenberg.
Just abstract out some things that the FTL will want to use as well.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler.h:
(OSRExitCompiler):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompilerCommon.cpp: Added.
(DFG):
(JSC::DFG::handleExitCounts):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
- dfg/DFGOSRExitCompilerCommon.h: Added.
(DFG):
- 1:47 PM Changeset in webkit [148046] by
-
- 3 edits in trunk/Tools
Kill old processes between runs on WinEWS bots.
Temporarily disable tests to let bots catch up again.
- EWSTools/start-queue-win.sh:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 1:42 PM Changeset in webkit [148045] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLInt conditional branch compilation fault on MIPS.
https://bugs.webkit.org/show_bug.cgi?id=114264
Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-04-09
Reviewed by Filip Pizlo.
Fix conditional branch compilation in LLInt offlineasm.
- offlineasm/mips.rb:
- 1:35 PM Changeset in webkit [148044] by
-
- 2 edits in trunk/Source/WebCore
AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817
Unreviewed build fix (again).
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
- 1:35 PM Changeset in webkit [148043] by
-
- 3 edits in trunk/Source/WebKit2
If we fail to decode a message name, pass the message length as the name
https://bugs.webkit.org/show_bug.cgi?id=114305
<rdar://problem/13605703>
Reviewed by Sam Weinig.
- Platform/CoreIPC/ArgumentDecoder.h:
(CoreIPC::ArgumentDecoder::length):
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::processIncomingMessage):
- 1:18 PM Changeset in webkit [148042] by
-
- 2 edits in trunk/Source/WebCore
AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817
Unreviewed build fix.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(WebTransformCGPathToNSBezierPath):
- 1:06 PM Changeset in webkit [148041] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Main page is rendered at wrong large scale after back from any zooming article at read.thestar.com
https://bugs.webkit.org/show_bug.cgi?id=114296
Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
PR: 308655
We were relying on the load state Committed to reset m_userPerformedManualZoom
and m_userPerformedManualScroll; however, the main resources of the
articles on read.thestar.com were preloaded and the WebPage didn't get
any load state change callbacks when going back to the main page from
the articles. Therefore, m_userPerformedManualZoom had never been reset
in this case and we picked up the wrong scale when restoring the main page.
Rset m_userPerformedManualScroll and m_userPerformedManualScroll when
we are going back or forward.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::goBackOrForward):
- 12:56 PM Changeset in webkit [148040] by
-
- 2 edits in trunk/LayoutTests
Mark mouse-events-scaled-iframe.html as flaky
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-09
- platform/mac-wk2/TestExpectations:
- 12:55 PM Changeset in webkit [148039] by
-
- 2 edits in trunk/Source/WebCore
AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817
Reviewed by Tim Horton.
Minor fix from review feedback.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
- 12:48 PM Changeset in webkit [148038] by
-
- 7 edits in trunk/Source/WebKit2
Don't create another plugin process for restarted plugins
https://bugs.webkit.org/show_bug.cgi?id=114233
Reviewed by Geoff Garen.
A snapshotting plugin starts in a separate process from
regular plugins. This can be a little confusing to users
because they might see two plugin processes. We can set
the minimum life and timeout on the snapshotting process
to much smaller values, since the process doesn't need
to live that long. This will reduce some potential
confusion. Also, since there is another plugin process
running real plugins, it should be paged in if it needs
to restart.
There was, however, a bug in the process management. A
restarted plugin received a special PluginProcess::Type,
so that it could cross fade into the page nicely. This
caused it to start a *third* plugin process. Instead
mark a restarted flag directly on the PluginProxy and
revert back to two process types.
- PluginProcess/PluginProcess.h: Remove TypeRestartedProcess.
- UIProcess/Plugins/PluginProcessProxy.cpp: Add two new
timeout values for snapshotting processes.
(WebKit::PluginProcessProxy::didFinishLaunching): Chose which
of the timeout pairs to use.
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::PluginProxy::pluginLayer): Don't look at the process type, instead
look at the process flag to see if we are restarted.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::create): Copy the new flag into constructor.
(WebKit::PluginProxy::PluginProxy): Remember the flag.
- WebProcess/Plugins/PluginProxy.h: Add a new m_restartedProcess flag.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin): When we are creating the proxy, separate
the concept of snapshotting and restarting.
- 12:18 PM Changeset in webkit [148037] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should better abstract floating point arguments
https://bugs.webkit.org/show_bug.cgi?id=114300
Reviewed by Mark Hahnenberg.
- dfg/DFGFPRInfo.h:
(FPRInfo):
(JSC::DFG::FPRInfo::toArgumentRegister):
- 12:16 PM Changeset in webkit [148036] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSObject::getOwnNonIndexPropertyNames calculates numCacheableSlots incorrectly
https://bugs.webkit.org/show_bug.cgi?id=114235
Reviewed by Geoffrey Garen.
Due to the way that numCacheableSlots is currently calculated, checking an object's prototype for enumerable
properties causes us not to cache any properties at all. We should only cache properties on the object itself
since we currently don't take advantage of any sort of name caching for properties in the prototype chain.
This fix undoes a ~2% SunSpider regression caused by http://trac.webkit.org/changeset/147570.
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnNonIndexPropertyNames):
- 12:10 PM Changeset in webkit [148035] by
-
- 4 edits in trunk/Tools
[webkitpy] Remove chromium deprecated port support.
https://bugs.webkit.org/show_bug.cgi?id=114228
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
(ChromiumPort): Removed.
(ChromiumAndroidPort): Removed.
(ChromiumXVFBPort): Removed.
- Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_chromium_port): Removed.
(DeprecatedPortTest.test_chromium_android_port): Removed.
(DeprecatedPortTest.test_chromium_xvfb_port): Removed.
- Scripts/webkitpy/tool/steps/update_unittest.py:
(UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
(UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
- 12:09 PM FeatureFlags edited by
- HTML Notifications were finally removed. (diff)
- 12:04 PM Changeset in webkit [148034] by
-
- 12 edits in trunk/Source
[wk2] IconDatabase images should be decoded in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=112524
<rdar://problem/10133914>
Reviewed by Oliver Hunt.
In the interests of keeping decoding of data coming in from the greater Internet
in the WebProcess, move decoding of favicons from the UIProcess to the WebProcess.
- UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::setIconBitmapForIconURL):
Receive a ShareableBitmap handle from the WebProcess instead of a DataReference.
Use the new setIconBitmapForIconURL IconDatabase method.
- UIProcess/WebIconDatabase.h:
(WebIconDatabase):
Rename setIconDataForIconURL to setIconBitmapForIconURL.
- UIProcess/WebIconDatabase.messages.in: Ditto.
- WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
(WebKit::WebIconDatabaseProxy::setIconDataForIconURL):
In the WebProcess, decode the incoming icon and draw it into a ShareableBitmap.
No testable behavior change.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::updateIconRecord):
Added updateIconRecord, which factors most of setIconDataForIconURL out so it can
be shared with setIconBitmapForIconURL. This function will set either a bitmap or
raw image data for the given icon URL.
(WebCore::IconDatabase::setIconBitmapForIconURL):
Added; make a copy of the bitmap for thread-safety purposes, and call updateIconRecord.
(WebCore::IconDatabase::setIconDataForIconURL):
Factored out of what is now updateIconRecord.
- loader/icon/IconDatabase.h:
(IconDatabase): Add setIconBitmapForIconURL and updateIconRecord.
- loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::setIconBitmapForIconURL): Added.
- loader/icon/IconRecord.cpp:
(WebCore::IconRecord::setImage): Set the image for an icon record directly (as opposed
to setting the image data, which causes the image to be decoded in the WebProcess).
- loader/icon/IconRecord.h:
(IconRecord): Add setImage.
- 11:53 AM Changeset in webkit [148033] by
-
- 22 edits4 adds in trunk
AX: The bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817
Reviewed by David Kilzer.
Source/WebCore:
This allows bounding paths to be returned for some web elements (image map areas and SVG shapes).
This provides more accuracy when assistive technologies highlight elements.
The Mac and iOS platforms share some code to help transform paths to their screen coordinates.
Tests: platform/iphone-simulator/accessibility/element-paths.html
platform/mac/accessibility/element-paths.html
- accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):
(WebCore):
(WebCore::AccessibilityImageMapLink::elementPath):
(WebCore::AccessibilityImageMapLink::elementRect):
- accessibility/AccessibilityImageMapLink.h:
(AccessibilityImageMapLink):
(WebCore::AccessibilityImageMapLink::supportsPath):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::elementPath):
(WebCore::AccessibilityObject::supportsPath):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore):
(WebCore::AccessibilityRenderObject::supportsPath):
(WebCore::AccessibilityRenderObject::elementPath):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityPath]):
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
(-[WebAccessibilityObjectWrapper convertRectToScreenSpace:]):
(-[WebAccessibilityObjectWrapper accessibilityActivationPoint]):
(-[WebAccessibilityObjectWrapper accessibilityFrame]):
(-[WebAccessibilityObjectWrapper frameForTextMarkers:]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
(WebCore):
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(PathConversionInfo):
(ConvertPathToScreenSpaceFunction):
(-[WebAccessibilityObjectWrapperBase convertPathToScreenSpace:]):
(-[WebAccessibilityObjectWrapperBase convertPointToScreenSpace:]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
(WebTransformCGPathToNSBezierPath):
(-[WebAccessibilityObjectWrapper bezierPathFromPath:]):
(-[WebAccessibilityObjectWrapper path]):
(-[WebAccessibilityObjectWrapper position]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Tools:
Add a pathDescription property for testing so that it's possible
to verify that a path is being returned correctly.
- DumpRenderTree/AccessibilityUIElement.cpp:
(getPathDescriptionCallback):
(AccessibilityUIElement::pathDescription):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement):
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(_CGPathEnumerationIteration):
(AccessibilityUIElement::pathDescription):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::pathDescription):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::pathDescription):
(WTR):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::pathDescription):
(WTR):
LayoutTests:
Add new tests for Mac and iOS to verify that path output works.
Modify existing tests to indicate that there is a new AXAttribute, AXPath.
- platform/iphone-simulator/accessibility/element-paths-expected.txt: Added.
- platform/iphone-simulator/accessibility/element-paths.html: Added.
- platform/mac/accessibility/document-links-expected.txt:
- platform/mac/accessibility/element-paths-expected.txt: Added.
- platform/mac/accessibility/element-paths.html: Added.
- platform/mac/accessibility/image-map2-expected.txt:
- 11:04 AM Changeset in webkit [148032] by
-
- 2 edits2 deletes in trunk/Source
Remove the WebKit copy of GLU and the file using it
https://bugs.webkit.org/show_bug.cgi?id=114249
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-09
Reviewed by Darin Adler.
Source/ThirdParty:
- glu/.gitignore: Removed.
- glu/LICENSE.txt: Removed.
- glu/README.webkit: Removed.
- glu/glu.gyp: Removed.
- glu/gluos.h: Removed.
- glu/internal_glu.h: Removed.
- glu/libtess/GNUmakefile: Removed.
- glu/libtess/Imakefile: Removed.
- glu/libtess/README: Removed.
- glu/libtess/alg-outline: Removed.
- glu/libtess/dict-list.h: Removed.
- glu/libtess/dict.c: Removed.
- glu/libtess/dict.h: Removed.
- glu/libtess/geom.c: Removed.
- glu/libtess/geom.h: Removed.
- glu/libtess/memalloc.c: Removed.
- glu/libtess/memalloc.h: Removed.
- glu/libtess/mesh.c: Removed.
- glu/libtess/mesh.h: Removed.
- glu/libtess/normal.c: Removed.
- glu/libtess/normal.h: Removed.
- glu/libtess/priorityq-heap.c: Removed.
- glu/libtess/priorityq-heap.h: Removed.
- glu/libtess/priorityq-sort.h: Removed.
- glu/libtess/priorityq.c: Removed.
- glu/libtess/priorityq.h: Removed.
- glu/libtess/render.c: Removed.
- glu/libtess/render.h: Removed.
- glu/libtess/sweep.c: Removed.
- glu/libtess/sweep.h: Removed.
- glu/libtess/tess.c: Removed.
- glu/libtess/tess.h: Removed.
- glu/libtess/tessmono.c: Removed.
- glu/libtess/tessmono.h: Removed.
Source/WebCore:
- platform/graphics/gpu/LoopBlinnPathProcessor.cpp: Removed.
- 10:45 AM Changeset in webkit [148031] by
-
- 4 edits in trunk/Source/WebCore
Throttle resize events during live window resize.
<http://webkit.org/b/114292>
<rdar://problem/13411454>
Reviewed by Geoffrey Garen.
Limit resize events to one at max every 0.2 seconds during live window resize.
This mitigates heavy CPU usage during resize on pages with complex onresize handlers.
If there's a pending resize event when the live resize ends, it fires immediately.
- page/FrameView.cpp:
(WebCore::FrameView::sendResizeEvent):
Factored out dispatch of the resize event after layout so we can call it on a timer
instead of immediately while live window resize is active.
(WebCore::FrameView::FrameView):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::delayedResizeEventTimerFired):
(WebCore::FrameView::willEndLiveResize):
(WebCore::FrameView::scheduleResizeEvent):
- page/FrameView.h:
- platform/ScrollableArea.h:
Made willStartLiveResize() and willEndLiveResize() virtual so we can override
them on FrameView.
- 10:31 AM FeatureFlags edited by
- (diff)
- 10:05 AM Changeset in webkit [148030] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 10:04 AM FeatureFlags edited by
- Add info on the CSS Exclusions flag (diff)
- 10:03 AM Changeset in webkit [148029] by
-
- 1 copy in tags/Safari-536.29.13
New Tag.
- 9:52 AM Changeset in webkit [148028] by
-
- 2 edits in trunk/Source/WebCore
Add webp to supported image mime types if WEBP feature is enabled/used
https://bugs.webkit.org/show_bug.cgi?id=112819
Patch by Jeff Rogers <jrogers@rim.com> on 2013-04-09
Reviewed by Darin Adler.
Add WebP to list of supported image types in MIMETypeRegistry if enabled.
No new tests: WebP image decoding already covered by exisiting tests.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
- 9:46 AM Changeset in webkit [148027] by
-
- 3 edits4 adds in trunk
Whitespace in particular source code changes rendering; does not in Firefox
https://bugs.webkit.org/show_bug.cgi?id=100943
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-04-09
Reviewed by Darin Adler.
Source/WebCore:
A render inline which requires a line box is considered a possible
trailing object. So, ensureLineBoxInsideIgnoredSpaces will be called
for it, even if it is placed after a text render ending with a single
space.
Tests: fast/text/whitespace/trailing-space-before-empty-span-1.html
fast/text/whitespace/trailing-space-before-empty-span-2.html
- rendering/RenderBlockLineLayout.cpp:
(TrailingObjects):
(WebCore::TrailingObjects::appendBoxIfNeeded):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/text/whitespace/trailing-space-before-empty-span-1-expected.html: Added.
- fast/text/whitespace/trailing-space-before-empty-span-1.html: A test
with a span whose text ends with a single span. A following span
is empty but requires a line box (because it has some padding).
The second span should be rendered.
- fast/text/whitespace/trailing-space-before-empty-span-2-expected.html: Added.
- fast/text/whitespace/trailing-space-before-empty-span-2.html: Same
test as trailing-space-before-empty-span-1.html except that second
span contains whitespace only text.
- 9:39 AM Keeping the Tree Green edited by
- (diff)
- 9:22 AM FeatureFlags edited by
- Add info about CSS_SHADERS. (diff)
- 8:27 AM Changeset in webkit [148026] by
-
- 13 edits in trunk
Use DOM ordering for list counts
https://bugs.webkit.org/show_bug.cgi?id=110352
Reviewed by Elliott Sprehn.
Source/WebCore:
Currently the list items ordering is made by traversing the render tree. This gives bad results for:
- list items flown inside regions because they are not rendered as descendants of their DOM list ancestors.
- list items matched to insertion points inside a shadow tree. The insertion point may be a child of a
list so the numbering gets broken.
To implement correct DOM ordering I've taken into account the fact that pseudo-elements can have display: list-item
so they should be included when traversing the DOM tree. I've added helper methods on the NodeTraversal
namespace that should allow easily traversing the tree including the pseudo-elements (e.g. firstChildWithPseudo
for an element with pseudo-before will return the before PseudoElement). Using these helper methods I've implemented
pre-order traversal methods aware of the pseudo-elements.
An effect of this change is how the list items inside shadow tree update their counting. With the patch, if there's
no <ol> or <ul> element on the ancestor chain of a <li> element to the shadow root, the list node will be considered the
first parent of the <li> or the shadow root if there is no ancestor.
The RenderListItem class now makes use of this new method of traversal, replacing the one based on the render tree.
To simplify the CSS counters implementation, I've changed the traversal functions inside RenderCounter to also make use
of this method. The CSS counters and the list items now have the same traversal algorithm.
In later patches I'll add tests that should cover the regions and shadow DOM use cases.
Tests bug for shadow DOM: https://bugs.webkit.org/show_bug.cgi?id=113193
Tests bug for regions: https://bugs.webkit.org/show_bug.cgi?id=103975
Tests: no new tests is this patch; added the correct expectations for fast/lists/positioned-count-crash.html
and fast/dom/shadow/shadow-and-list-elements.html
- dom/Node.cpp:
(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore):
(WebCore::Node::pseudoAwareNextSibling):
(WebCore::Node::pseudoAwareFirstChild):
(WebCore::Node::pseudoAwareLastChild):
- dom/Node.h:
(Node):
- dom/NodeTraversal.cpp:
(WebCore):
(WebCore::NodeTraversal::previousIncludingPseudo):
(NodeTraversal):
(WebCore::NodeTraversal::nextIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudoSkippingChildren):
- dom/NodeTraversal.h:
(ElementTraversal):
(NodeTraversal):
(WebCore::ElementTraversal::previousIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
(WebCore::ElementTraversal::pseudoAwarePreviousSibling):
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::attach):
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):
- rendering/RenderCounter.cpp:
(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):
- rendering/RenderListItem.cpp:
(WebCore):
(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):
- rendering/RenderListItem.h:
(RenderListItem):
LayoutTests:
The fast/dom/shadow/shadow-and-list-elements-expected.html has changed because the list items
inside the shadow tree no longer see the root <ol> element.
The test fast/lists/positioned-count-crash.html has the correct rendering after changing
the list counting to be in DOM order.
- fast/dom/shadow/shadow-and-list-elements-expected.html:
- fast/lists/positioned-count-crash-expected.txt:
- 7:50 AM Changeset in webkit [148025] by
-
- 16 edits in trunk
[EFL] Declare TEST_THEME_DIR in a single place.
https://bugs.webkit.org/show_bug.cgi?id=114285
Reviewed by Anders Carlsson.
.:
Instead of adding the `THEME_DIR' preprocessor variable in many
different CMakeList.txt files in the tree, declare it in
OptionsEfl.cmake so that we avoid needlessly duplicating code around.
While here, rename it to `TEST_THEME_DIR', which is the name used our
WebKit2 infrastructure, to better reflect the purpose of this value.
- Source/cmake/OptionsEfl.cmake: Add the TEST_THEME_DIR preprocessor
definition.
Source/WebKit2:
- PlatformEfl.cmake: Remove definition of `TEST_THEME_DIR', which is
now defined in OptionsEfl.cmake.
Tools:
Adapt to the renaming of
THEME_DIR' toTEST_THEME_DIR'.
- DumpRenderTree/efl/CMakeLists.txt:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::createInspectorView):
(DumpRenderTreeChrome::initialize):
(DumpRenderTreeChrome::onDownloadRequest):
- EWebLauncher/CMakeLists.txt:
- EWebLauncher/main.c:
(findThemePath):
- EWebLauncher/url_bar.c:
(url_bar_add):
- MiniBrowser/efl/CMakeLists.txt:
- MiniBrowser/efl/main.c:
(window_create):
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
- WebKitTestRunner/PlatformEfl.cmake:
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::PlatformWebView):
- 7:48 AM Changeset in webkit [148024] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] InputHandler: fix calls to HTMLInputElement methods
https://bugs.webkit.org/show_bug.cgi?id=114283
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-09
Reviewed by Rob Buis.
Fix calls with wrong names.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertInputType):
- 7:35 AM Changeset in webkit [148023] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] --minimal build fails with error:
setSeamlessIFramesEnabled' is not a member ofWebCore::RuntimeEnabledFeatures'
https://bugs.webkit.org/show_bug.cgi?id=113951
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-09
Reviewed by Laszlo Gombos.
Wrapped code related to iframe seamless into #if ENABLE(IFRAME_SEAMLESS)
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setSeamlessIFramesEnabled):
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
- 7:31 AM Changeset in webkit [148022] by
-
- 5 edits3 adds in trunk
[CoordinatedGraphics] serviceScriptedAnimations expects time in seconds
https://bugs.webkit.org/show_bug.cgi?id=112582
Reviewed by Andreas Kling.
Source/WebKit/qt:
We've been exposing different time unit for requestAnimationFrame because
of wrong conversion before serviceScriptedAnimations function calls.
Fixed it to use seconds instead of milliseconds.
- WebCoreSupport/ChromeClientQt.cpp: Remove unnecessary conversion.
Source/WebKit2:
We've been exposing different time unit for requestAnimationFrame because
of wrong conversion before serviceScriptedAnimations function calls.
Fixed it to use seconds instead of milliseconds.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::syncDisplayState): Remove unnecessary conversion.
LayoutTests:
Add test to measure if the time interval is coherent with the unit
of DOMTimeStamp (milliseconds) by comparing it with Date.now() interval.
- fast/animation/request-animation-frame-time-unit-expected.txt: Added.
- fast/animation/request-animation-frame-time-unit.html: Added.
- fast/animation/script-tests/request-animation-frame-time-unit.js: Added.
- 7:14 AM Changeset in webkit [148021] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Remove obsolete QtWebPageFindClient forward declaration from qquickwebview_p.h.
https://bugs.webkit.org/show_bug.cgi?id=114284
Reviewed by Andreas Kling.
The class QtWebPageFindClient was removed in r142073 when the functionality
was folded into QQuickWebViewPrivate.
- UIProcess/API/qt/qquickwebview_p.h:
(WebKit):
- 7:13 AM Changeset in webkit [148020] by
-
- 3 edits in trunk/Source/WebCore
[Texmap] TextureMapperLayer refactor for readiblity
https://bugs.webkit.org/show_bug.cgi?id=114278
Reviewed by Noam Rosenthal.
Removes non-needed return values, function parameters and changes
boolean values with enums for readibility.
No behavioral changes, thus no tests.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::sortByZOrder):
(WebCore::TextureMapperLayer::computeOverlapRegions):
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):
(WebCore::commitSurface):
(WebCore::TextureMapperLayer::paintWithIntermediateSurface):
(WebCore::TextureMapperLayer::paintRecursive):
- platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
- 6:45 AM Changeset in webkit [148019] by
-
- 8 edits in trunk
[WebSocket] Ignore incoming message in CLOSING state
https://bugs.webkit.org/show_bug.cgi?id=85934
Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-04-09
Reviewed by Kent Tamura.
Source/WebCore:
Change WebSocket implementation to suit the new WebSocket API, which
states that we should ignore messages in CLOSING state.
No new tests, updating existing tests.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveMessage):
LayoutTests:
- http/tests/websocket/tests/hybi/client-close-expected.txt: Rebaseline.
- http/tests/websocket/tests/hybi/client-close.html: Change expected results.
- http/tests/websocket/tests/hybi/client-close_wsh.py: Embed message in close frame
instead of using regular message sending call.
- http/tests/websocket/tests/hybi/fragmented-frames.html: Call WebSocket.close()
only after receiving all messages from server.
- http/tests/websocket/tests/hybi/unmasked-frames.html: Remove extra
WebSocket.close() call that caused regression.
- 6:26 AM Changeset in webkit [148018] by
-
- 4 edits in trunk
[GTK][AC] upversion of clutter and its dependecy
https://bugs.webkit.org/show_bug.cgi?id=114016
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-09
Reviewed by Gustavo Noronha Silva.
Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
.:
- Source/autotools/Versions.m4:
Tools:
- gtk/jhbuild-optional.modules:
- 6:13 AM Changeset in webkit [148017] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Add Localized strings after r144154 and r135127
https://bugs.webkit.org/show_bug.cgi?id=114269
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-09
Reviewed by Timothy Hatcher.
No new tests, no behavior change.
- English.lproj/localizedStrings.js:
- 5:55 AM Changeset in webkit [148016] by
-
- 1 delete in trunk/LayoutTests/platform/efl-wk2/tables/mozilla_expected_failures
Remove empty directories
- 5:53 AM Changeset in webkit [148015] by
-
- 4 edits2 deletes in trunk/LayoutTests
[EFL] Move tables/mozilla_expected_failures/bugs/bug89315.html's expectations to efl/.
There is no point in keeping the rebaselined results WK2-only. While
here, actually unskip the test and provide a more accurate pixel result
(the previous one was fine, but this one passes with --tolerance=0).
- platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.png: Removed.
- platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Removed.
- platform/efl/TestExpectations:
- platform/efl/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- 5:13 AM Changeset in webkit [148014] by
-
- 2 edits in trunk/Source/WebKit2
Fix GTK WebKit2 build after r148005.
https://bugs.webkit.org/show_bug.cgi?id=114270
Reviewed by Andreas Kling.
Fix GTK build break that went through the buildbot undetected.
- UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
(webkit_file_chooser_request_get_selected_files):
- 5:11 AM Changeset in webkit [148013] by
-
- 4 edits in trunk/Source/WebCore
Throttle compositing layer flushes in subframes
https://bugs.webkit.org/show_bug.cgi?id=114267
Reviewed by Andreas Kling.
Throttle compositing layer flushes in all frames, not just the main one.
This especially reduces flushes/repaints generated by ads in iframes.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadProgressingStatusChanged):
- page/FrameView.cpp:
(WebCore::FrameView::updateLayerFlushThrottlingInAllFrames):
- page/FrameView.h:
- 5:00 AM Changeset in webkit [148012] by
-
- 3 edits in trunk/LayoutTests
[EFL] Gardening.
Now unskip a few compositing-related tests which are not failing
anymore.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 4:53 AM Changeset in webkit [148011] by
-
- 6 edits in trunk/Source/WebKit2
[Qt][WK2] Remove direct references to WebPageProxy from QQuickWebPage.
https://bugs.webkit.org/show_bug.cgi?id=112850
Reviewed by Andreas Kling.
Removes direct references to WebPageProxy from QQuickWebPage and prepares the
class for the move to QRawWebView. The access to the device scale factor and
CoordinatedGraphicsScene is provided through QQuickWebViewPrivate, and therefore
accessors to these properties are temporarily added. Eventually, this access will
be provided through QRawWebView when the move is complete.
This also moves the pointer to QtWebPageEventHandler from QQuickWebPagePrivate
to QQuickWebViewPrivate as it is mainly used from there.
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paint):
(QQuickWebPage::updatePaintNode):
- UIProcess/API/qt/qquickwebpage_p.h:
- UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::handleMouseEvent):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewPrivate::coordinatedGraphicsScene):
(QQuickWebViewPrivate::deviceScaleFactor):
(QQuickWebViewPrivate::setIntrinsicDeviceScaleFactor):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::itemChange):
(QQuickWebView::touchEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
- UIProcess/API/qt/qquickwebview_p_p.h:
(WebCore):
(WebKit):
(QQuickWebViewPrivate):
- 4:51 AM Changeset in webkit [148010] by
-
- 9 edits2 adds in trunk
Table border doesn't show up
https://bugs.webkit.org/show_bug.cgi?id=13709
Patch by Suchit Agrawal <a.suchit@samsung.com> on 2013-04-09
Reviewed by Antti Koivisto.
Source/WebCore:
Border issue is fixed when border width is less than 0.8pt
Border width is stored as unsigned. Border width (specified by
author) is converted into pixels and some times this pixel value
goes less than 1px. In this case, border width becomes 0px when
pixel value (double type) assigned to unsigned type.
Border width should not fall to 0px unless it is specified by
author.
Test: fast/borders/border-width-less-then-a-unit-of-pt.html
- css/StyleBuilder.cpp:
ApplyPropetyComputeLength class is replaced with 3 classes :
ApplyPropertyComputeBorderWidth, ApplyPropertyComputeTextSpacing
and ApplyPropertyComputeTransformOriginZ.
(WebCore::ApplyPropertyComputeBorderWidth::applyValue):
(WebCore::ApplyPropertyComputeBorderWidth::createHandler):
This class handles all width properties like border, outline,
etc. These all properties stores value in integer types.
Pixel value rounded of to 1px if value less than 1px and greater
than 0px.
(WebCore):
(ApplyPropertyComputeTextSpacing):
(WebCore::ApplyPropertyComputeTextSpacing::setValue):
(WebCore::ApplyPropertyComputeTextSpacing::applyValue):
(WebCore::ApplyPropertyComputeTextSpacing::createHandler):
This class handles all spacing properties like word-spacing,
letter-spacing etc.
(ApplyPropertyComputeTransformOriginZ):
(WebCore::ApplyPropertyComputeTransformOriginZ::setValue):
(WebCore::ApplyPropertyComputeTransformOriginZ::applyValue):
(WebCore::ApplyPropertyComputeTransformOriginZ::createHandler):
This class handles TransformOriginZ Property.
(WebCore::StyleBuilder::StyleBuilder):
ApplyProprtyComputeLength class usage changed with defined new
classes as per class definition.
LayoutTests:
This test file have border width, outline offset, outline width, border
spacing and column rule width properties test cases.
- fast/borders/border-width-less-then-a-unit-of-pt-expected.html: Added.
- fast/borders/border-width-less-then-a-unit-of-pt.html: Added.
Test case table/mozilla_expected_failures/bug89315.html need to do rebaseline
in efl, gtk and mac.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
Updated the test result for table/mozilla_expected_failures/bug89315.html
Border is expected for table in test table/mozilla_expected_failures/bug89315.html
- platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- 4:50 AM Changeset in webkit [148009] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unskip and update inspector tests
https://bugs.webkit.org/show_bug.cgi?id=114263
Unreviewed gardening.
Removed fast/events/autoscroll.html after r147830.
Unskip inspector/timeline/timeline-animation-frame.html that is now passing.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-09
- platform/qt/TestExpectations:
- 4:48 AM Changeset in webkit [148008] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Use C API to enable Navigator Qt Object.
https://bugs.webkit.org/show_bug.cgi?id=112810
Reviewed by Andreas Kling.
Replace the direct reference to the WebPageProxy with use of
C API.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::setNavigatorQtObjectEnabled):
- 4:42 AM Changeset in webkit [148007] by
-
- 3 edits in trunk/LayoutTests
[EFL] More gardening.
Unskip some tests which have stopped crashing after r147759,
147933 and others.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 4:34 AM Changeset in webkit [148006] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening. Unskip some tests that have been passing for a while.
- platform/efl/TestExpectations:
- 4:13 AM Changeset in webkit [148005] by
-
- 7 edits in trunk/Source/WebKit2
[WK2] Add C API to copy selected files from WebOpenPanelParameters.
https://bugs.webkit.org/show_bug.cgi?id=112339
Reviewed by Andreas Kling.
Replaces the existing WebOpenPanelParameters::selectedFileNames() method
to return a copy of the selected file names and exposes it through the
C API. This is done in order to reduce the direct use of WebKit2 internal
classes. The implementation is very similar to the one in
WebOpenPanelParameters::acceptMIMETypes().
This also updates the GTK port, which is the other user of selectedFileNames.
- Shared/WebOpenPanelParameters.cpp:
(WebKit::WebOpenPanelParameters::selectedFileNames):
(WebKit):
- Shared/WebOpenPanelParameters.h:
(WebOpenPanelParameters):
- UIProcess/API/C/WKOpenPanelParameters.cpp:
(WKOpenPanelParametersCopySelectedFileNames):
- UIProcess/API/C/WKOpenPanelParameters.h:
- UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
(webkit_file_chooser_request_get_selected_files):
- UIProcess/qt/QtWebPageUIClient.cpp:
(WebKit::QtWebPageUIClient::runOpenPanel):
- 4:01 AM Changeset in webkit [148004] by
-
- 2 edits in trunk/Source/WTF
[CMake] Remove conditional source file lists in WTF
https://bugs.webkit.org/show_bug.cgi?id=114250
Reviewed by Laszlo Gombos.
Use the #ifdef in the source file instead of conditional adding
files to the list of source files. This allows us to remove the
information of enabled features from CMake in next step.
- wtf/CMakeLists.txt:
- 3:44 AM Changeset in webkit [148003] by
-
- 2 edits in trunk/Source/WebCore
Initialization skipped error on WinCario after r147643
https://bugs.webkit.org/show_bug.cgi?id=114258
Reviewed by Csaba Osztrogonác.
Build fix. Adding extra block statement to avoid error C2362 on WinCario
- platform/win/DragImageCairoWin.cpp:
(WebCore::createDragImageFromImage):
- 3:15 AM Changeset in webkit [148002] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding failure expectations for two a11y tests that regressed with r147719.
- 3:11 AM Changeset in webkit [148001] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r147995.
http://trac.webkit.org/changeset/147995
https://bugs.webkit.org/show_bug.cgi?id=114261
Wrong gardening. (Requested by gyuyoung on #webkit).
- platform/efl/TestExpectations:
- 3:03 AM Changeset in webkit [148000] by
-
- 15 edits in trunk/Source
[WK2] Remove build warnings for unused parameters
https://bugs.webkit.org/show_bug.cgi?id=114234
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-04-09
Reviewed by Andreas Kling.
Fix build warnings -Wunused-parameter.
Source/WebCore:
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::openInMemory):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::CreateIndexAbortOperation::perform):
(WebCore::DeleteIndexAbortOperation::perform):
(WebCore::CreateObjectStoreAbortOperation::perform):
(WebCore::DeleteObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):
- Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::decodeBool):
(WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
- Modules/indexeddb/IDBLevelDBCoding.h:
(WebCore::IDBLevelDBCoding::encodeIntSafely):
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::canSet):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::ComparatorAdapter::FindShortestSeparator):
(WebCore::ComparatorAdapter::FindShortSuccessor):
Source/WebKit2:
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::SessionStorageNamespace::cloneTo):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::requestNetworkingStatistics):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::removeItem):
(WebKit::StorageAreaProxy::clear):
(WebKit::StorageAreaProxy::dispatchSessionStorageEvent):
(WebKit::StorageAreaProxy::dispatchLocalStorageEvent):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::didUninstallPageOverlay):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didFinishLoad):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin):
- 2:24 AM Changeset in webkit [147999] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Marking a bunch of CSS layout tests as flaky timeouts,
most likely due to libsoup dependency bump.
- 2:07 AM Changeset in webkit [147998] by
-
- 17 edits21 adds in trunk
[WK2] Drop WebProcess capabilities on Linux using seccomp filters
https://bugs.webkit.org/show_bug.cgi?id=89875
Reviewed by Maciej Stachowiak.
.:
Added the bits to EFL/CMake buildsystem to find the libseccomp
library.
- Source/cmake/FindLibSeccomp.cmake: Added.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebCore:
Make the DATA_DIR global since it is now needed for WebCore and WebKit2.
It is now used to set a sandbox policy for the EFL port.
- PlatformEfl.cmake:
Source/WebKit2:
Introduce the foundations of the SeccompFilter-based sandbox. The
hardening of the WebProcess (and potentially PluginProcess, etc)
works by a combination of the two things:
- Blocking syscalls that are not used, reducing the size of the attack
surface.
- Trapping sensitive syscalls and delegating the execution of these
syscalls to a separated trusted process subject to a set of policies.
The initial implementation traps the open()-family of syscalls on WebKit
EFL's and Qt's WebProcess, but it could be easily used by any Linux port,
since the code is suppose to be Linux-compliant. The list of syscalls handled
by the broker process should definitely grow as we mature the
implementation. Other syscalls needs to be handled to get this sandbox
fully functional, like unlink(), mkdir(), etc.
The broker process should be initialized as early as possible on the
sandboxed process main() function, because it only does a fork(), which
is cheap on Linux. That also aims to minimize the resident memory footprint
of the broker process.
Opening of files for upload and saving downloads is not supported yet,
since it should be handled to the UIProcess in a similar fashion as
the Mac port does.
- PlatformEfl.cmake:
- Shared/linux/SeccompFilters/OpenSyscall.cpp: Added.
(WebKit):
(WebKit::OpenSyscall::createFromOpenatContext):
(WebKit::OpenSyscall::createFromCreatContext):
(WebKit::OpenSyscall::OpenSyscall):
(WebKit::OpenSyscall::setResult):
(WebKit::OpenSyscall::execute):
(WebKit::OpenSyscall::encode):
(WebKit::OpenSyscall::decode):
(WebKit::OpenSyscallResult::OpenSyscallResult):
(WebKit::OpenSyscallResult::~OpenSyscallResult):
(WebKit::OpenSyscallResult::encode):
(WebKit::OpenSyscallResult::decode):
- Shared/linux/SeccompFilters/OpenSyscall.h: Added.
(CoreIPC):
(WebKit):
(OpenSyscall):
(WebKit::OpenSyscall::setPath):
(WebKit::OpenSyscall::setFlags):
(WebKit::OpenSyscall::setMode):
(OpenSyscallResult):
(WebKit::OpenSyscallResult::fd):
(WebKit::OpenSyscallResult::errorNumber):
- Shared/linux/SeccompFilters/SeccompBroker.cpp: Added.
(WebKit):
(SeccompBrokerClient):
(WebKit::sendMessage):
(WebKit::receiveMessage):
(WebKit::SIGSYSHandler):
(WebKit::registerSIGSYSHandler):
(WebKit::SeccompBrokerClient::shared):
(WebKit::SeccompBrokerClient::SeccompBrokerClient):
(WebKit::SeccompBrokerClient::~SeccompBrokerClient):
(WebKit::SeccompBrokerClient::dispatch):
(WebKit::SeccompBrokerClient::handleIfOpeningOnlineCPUCount):
(WebKit::SeccompBroker::launchProcess):
(WebKit::SeccompBroker::initialize):
(WebKit::SeccompBroker::runLoop):
- Shared/linux/SeccompFilters/SeccompBroker.h: Added.
(WebKit):
(SeccompBroker):
(WebKit::SeccompBroker::setSyscallPolicy):
(WebKit::SeccompBroker::SeccompBroker):
- Shared/linux/SeccompFilters/SeccompFilters.cpp: Added.
(WebKit):
(WebKit::SeccompFilters::SeccompFilters):
(WebKit::SeccompFilters::~SeccompFilters):
(WebKit::SeccompFilters::addRule):
(WebKit::SeccompFilters::initialize):
- Shared/linux/SeccompFilters/SeccompFilters.h: Added.
(WebKit):
(SeccompFilters):
(WebKit::SeccompFilters::context):
(WebKit::SeccompFilters::platformInitialize):
- Shared/linux/SeccompFilters/SigactionSyscall.cpp: Added.
(WebKit):
(WebKit::SigactionSyscall::createFromContext):
- Shared/linux/SeccompFilters/SigactionSyscall.h: Added.
(WebKit):
(SigactionSyscall):
- Shared/linux/SeccompFilters/SigprocmaskSyscall.cpp: Added.
(WebKit):
(WebKit::SigprocmaskSyscall::createFromContext):
- Shared/linux/SeccompFilters/SigprocmaskSyscall.h: Added.
(WebKit):
(SigprocmaskSyscall):
- Shared/linux/SeccompFilters/Syscall.cpp: Added.
(WebKit):
(WebKit::Syscall::createFromContext):
(WebKit::Syscall::createFromDecoder):
(WebKit::Syscall::Syscall):
(WebKit::SyscallResult::createFromDecoder):
(WebKit::SyscallResult::SyscallResult):
- Shared/linux/SeccompFilters/Syscall.h: Added.
(CoreIPC):
(WebKit):
(Syscall):
(WebKit::Syscall::~Syscall):
(WebKit::Syscall::type):
(WebKit::Syscall::setContext):
(WebKit::Syscall::context):
(SyscallResult):
(WebKit::SyscallResult::~SyscallResult):
(WebKit::SyscallResult::type):
- Shared/linux/SeccompFilters/SyscallPolicy.cpp: Added.
(WebKit):
(WebKit::removeTrailingSlash):
(WebKit::SyscallPolicy::hasPermissionForPath):
(WebKit::SyscallPolicy::addFilePermission):
(WebKit::SyscallPolicy::addDirectoryPermission):
(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):
- Shared/linux/SeccompFilters/SyscallPolicy.h: Added.
(WebKit):
(SyscallPolicy):
- Target.pri:
- WebKit2.pri:
- WebProcess/efl/SeccompFiltersWebProcessEfl.cpp: Added.
(WebKit):
(WebKit::SeccompFiltersWebProcessEfl::SeccompFiltersWebProcessEfl):
(WebKit::SeccompFiltersWebProcessEfl::platformInitialize):
- WebProcess/efl/SeccompFiltersWebProcessEfl.h: Added.
(WebKit):
(SeccompFiltersWebProcessEfl):
- WebProcess/qt/SeccompFiltersWebProcessQt.cpp: Added.
(WebKit):
(WebKit::SeccompFiltersWebProcessQt::SeccompFiltersWebProcessQt):
(WebKit::SeccompFiltersWebProcessQt::platformInitialize):
- WebProcess/qt/SeccompFiltersWebProcessQt.h: Added.
(WebKit):
(SeccompFiltersWebProcessQt):
- WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
Tools:
Add unit tests to verify if the handling of the open, openat, creat syscall
is being done right. We check if the Read/Write/ReadAndWrite permissions
are respected, if the canonical path is being resolved and if
the permissions are falling back to the topmost parent directory with a
policy set when the directory being opened has no policy.
We also test if any attempt of blocking SIGSYS is silently ignored.
SIGSYS cannot be blocked because in it's handler is where we hook
syscalls to the broker process.
Also added libseccomp to EFL's jhbuild to make the life of developers
willing to help easier.
- Scripts/webkitperl/FeatureList.pm:
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
(TestWebKitAPI):
(SeccompEnvironment):
(TestWebKitAPI::SeccompEnvironment::SetUp):
(TestWebKitAPI::SeccompEnvironment::TearDown):
(TestWebKitAPI::dummyHandler):
(TestWebKitAPI::TEST):
(TestWebKitAPI::stressTest):
- efl/jhbuild.modules:
- qmake/mkspecs/features/features.pri:
- 1:49 AM Changeset in webkit [147997] by
-
- 2 edits in trunk
Unreviewed. Fix GTK+ 32 bit build.
- Source/autotools/symbols.filter: Add some symbols that are
mangled differently in 32 bits due to size_t.
- 1:35 AM FeatureFlags edited by
- subpixel layout update (diff)
- 1:33 AM FeatureFlags edited by
- (diff)
- 1:31 AM FeatureFlags edited by
- (diff)
- 1:12 AM Changeset in webkit [147996] by
-
- 5 edits2 adds2 deletes in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations:
- platform/gtk/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
- platform/gtk/fast/js/exception-linenums-in-html-3-expected.png: Removed.
- platform/gtk/fast/js/missing-style-end-tag-js-expected.png: Removed.
- platform/gtk/fast/text/international/003-expected.png:
- platform/gtk/fast/text/international/003-expected.txt:
- platform/gtk/fast/text/international/text-combine-image-test-expected.png: Added.
- platform/gtk/fast/text/international/text-combine-image-test-expected.txt:
- 1:04 AM FeatureFlags edited by
- CSS Regions (diff)
- 12:48 AM Changeset in webkit [147995] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
fast/dom/shadow/selections-in-shadow.html is passed on EFL layout test now.
- platform/efl/TestExpectations:
- 12:35 AM Changeset in webkit [147994] by
-
- 22 edits in trunk
REGRESSION: Autocorrection doesn't work in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=113846
Reviewed by Alexey Proskuryakov.
Tools:
The problem was that we were replacing NSSpellCheck's dictionary with our own
in DumpRenderTree but we were not adding necessary corrections to the dictionary.
Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
and "would" respectively in DumpRenderTree.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
LayoutTests:
Removed failing expectations from tests that require "mesage" to be corrected to "message".
Also modified to dynamically assert the marker positions so that we may catch regressions
without pixel results (we still dump pixel results via dumpAsText(true) for sanity check).
- platform/mac/TestExpectations:
- platform/mac/editing/spelling/autocorrection-contraction-expected.png:
- platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
- platform/mac/editing/spelling/click-autocorrected-word-expected.png:
- platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/click-autocorrected-word.html:
- platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
- platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/delete-into-autocorrected-word.html:
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png:
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html:
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png:
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html:
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png:
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html:
- platform/mac-wk2/TestExpectations:
- 12:30 AM Changeset in webkit [147993] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL] Mark not implemented methods in TextCheckerEfl.
https://bugs.webkit.org/show_bug.cgi?id=112261
Reviewed by Anders Carlsson.
There's no need to call client's methods in TextCheckerEfl.cpp if they are not
implemented. Mark them as not implemented until we provide proper implementation.
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::checkGrammarOfString):
(WebKit::TextChecker::spellingUIIsShowing):
(WebKit::TextChecker::toggleSpellingUIIsShowing):
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
- 12:20 AM Changeset in webkit [147992] by
-
- 4 edits in trunk
Do not set CMAKE_BUILD_TYPE if it is not defined
https://bugs.webkit.org/show_bug.cgi?id=114243
Reviewed by Geoffrey Garen.
Setting the CMAKE_BUILD_TYPE causes some problem with Visual Studio.
Adopt the current usage of the variable to better CMake style.
- CMakeLists.txt:
- Source/cmake/OptionsCommon.cmake:
- Source/cmake/OptionsEfl.cmake:
- 12:12 AM Changeset in webkit [147991] by
-
- 1 edit4 deletes in trunk/Tools
Remove the gyp files for Tools
https://bugs.webkit.org/show_bug.cgi?id=114248
Reviewed by Ryosuke Niwa.
- DumpRenderTree/DumpRenderTree.gyp: Removed.
- DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
- DumpRenderTree/DumpRenderTree.gypi: Removed.
- TestWebKitAPI/TestWebKitAPI.gyp: Removed.
- TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
- TestWebKitAPI/TestWebKitAPI.gypi: Removed.
- 12:07 AM Changeset in webkit [147990] by
-
- 1 edit1 delete in trunk/Source/JavaScriptCore
Remove yarr.gyp
https://bugs.webkit.org/show_bug.cgi?id=114247
Reviewed by Benjamin Poulain.
- yarr/yarr.gyp: Removed.
Apr 8, 2013:
- 11:59 PM Changeset in webkit [147989] by
-
- 1 edit1 delete in trunk/Source/ThirdParty
Remove gyp from ThirdParty
https://bugs.webkit.org/show_bug.cgi?id=114244
Rubberstamped by Ryosuke Niwa.
- gyp: Removed.
- 11:57 PM Changeset in webkit [147988] by
-
- 1 edit1 delete in trunk/Source/ThirdParty/ANGLE
Remove ANGLE.gyp
https://bugs.webkit.org/show_bug.cgi?id=114245
Unreviewed. Just removing an empty directory.
- ANGLE.gyp: Removed.
- 11:49 PM Changeset in webkit [147987] by
-
- 1 edit2 deletes in trunk/Source/WebCore
Remove WebCore.gyp/gypi
https://bugs.webkit.org/show_bug.cgi?id=114239
Reviewed by Benjamin Poulain.
- WebCore.gyp: Removed.
- WebCore.gyp/.gitignore: Removed.
- WebCore.gyp/ConvertFileToHeaderWithCharacterArray.gypi: Removed.
- WebCore.gyp/MakeNames.gypi: Removed.
- WebCore.gyp/WebCore.gyp: Removed.
- WebCore.gyp/mac: Removed.
- WebCore.gyp/mac/adjust_visibility.sh: Removed.
- WebCore.gyp/mac/check_objc_rename.sh: Removed.
- WebCore.gyp/scripts: Removed.
- WebCore.gyp/scripts/action_csspropertynames.py: Removed.
- WebCore.gyp/scripts/action_cssvaluekeywords.py: Removed.
- WebCore.gyp/scripts/action_derivedsourcesallinone.py: Removed.
- WebCore.gyp/scripts/action_makenames.py: Removed.
- WebCore.gyp/scripts/action_useragentstylesheets.py: Removed.
- WebCore.gyp/scripts/rule_bison.py: Removed.
- WebCore.gyp/scripts/supplemental_idl_files.py: Removed.
- WebCore.gypi: Removed.
- 11:46 PM Changeset in webkit [147986] by
-
- 1 edit2 deletes in trunk/Source/JavaScriptCore
Remove JavaScriptCore.gyp/gypi
https://bugs.webkit.org/show_bug.cgi?id=114238
Reviewed by Benjamin Poulain.
- JavaScriptCore.gyp: Removed.
- JavaScriptCore.gyp/.gitignore: Removed.
- JavaScriptCore.gypi: Removed.
- 11:45 PM Changeset in webkit [147985] by
-
- 14 edits in trunk/Source/JavaScriptCore
Adds fromCharCode intrinsic support.
https://bugs.webkit.org/show_bug.cgi?id=104807
Patch by Vahag Vardanyan <vaag@ispras.ru> on 2013-04-08
Reviewed by Oliver Hunt.
Switch to using fromCharCode intrinsic instead of call operation in some cases.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileFromCharCode):
(DFG):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/StringConstructor.cpp:
(JSC::stringFromCharCode):
(JSC):
- runtime/StringConstructor.h:
(JSC):
- 11:44 PM Changeset in webkit [147984] by
-
- 2 edits in trunk/Tools
WKR (new-commit-bot) is too slow
https://bugs.webkit.org/show_bug.cgi?id=110087
Reviewed by Geoffrey Garen.
Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
Just run "svn log -r <revision>" instead to cut down the delay.
Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot):
(NewCommitBot.next_work_item):
(NewCommitBot._is_empty_log):
(NewCommitBot._update_checkout):
- 11:16 PM Changeset in webkit [147983] by
-
- 15 edits6 deletes in trunk
Rollout r147756: performance regression
https://bugs.webkit.org/show_bug.cgi?id=114176
Patch by Mihai Maerean <Mihai Maerean> on 2013-04-08
Reviewed by Alexis Menard.
Source/WebCore:
Rolling out the patch for https://bugs.webkit.org/show_bug.cgi?id=74144 "[CSS Regions] Elements in a region
should be assignable to a named flow" because of the performance regression in Parser/html5-full-render.html .
No new tests (because this is a rollout patch).
- dom/Element.cpp:
- dom/Element.h:
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
- dom/NodeRenderingContext.h:
- dom/PseudoElement.h:
- dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
(WebCore::Text::updateTextRenderer):
- dom/Text.h:
- rendering/FlowThreadController.cpp:
- rendering/FlowThreadController.h:
- rendering/RenderObject.h:
- rendering/RenderRegion.h:
- svg/SVGElement.cpp:
- svg/SVGElement.h:
LayoutTests:
- fast/regions/flow-body-in-html-expected.txt: Removed.
- fast/regions/flow-body-in-html.html: Removed.
- fast/regions/region-content-flown-into-region-expected.html: Removed.
- fast/regions/region-content-flown-into-region.html: Removed.
- fast/regions/universal-selector-children-to-the-same-region-expected.txt: Removed.
- fast/regions/universal-selector-children-to-the-same-region.html: Removed.
- 10:55 PM Changeset in webkit [147982] by
-
- 2 edits in trunk/Tools
Build fix. Can't remove appendCustomBuildFlags.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(appendCustomBuildFlags):
- 10:35 PM Changeset in webkit [147981] by
-
- 4 edits in trunk/Tools
Remove Chromium builders from build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=113990
Reviewed by Benjamin Poulain.
Removed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(InstallGtkDependencies):
(RunUnitTests.start):
(RunWebKit2Tests.start):
(Factory.init):
(unitTestsSupported):
(TestFactory.init):
(BuildAndTestFactory.init):
(BuildAndPerfTestFactory.init):
(BuildAndPerfTestWebKit2Factory.init):
(DownloadAndPerfTestFactory.init):
(loadBuilderConfig):
- BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- 9:53 PM Changeset in webkit [147980] by
-
- 1 edit2 deletes in trunk/Source/WTF
Remove WTF.gyp/WTF.gypi
https://bugs.webkit.org/show_bug.cgi?id=114237
Reviewed by Maciej Stachowiak.
- WTF.gyp: Removed.
- WTF.gyp/.gitignore: Removed.
- WTF.gyp/WTF.gyp: Removed.
- WTF.gypi: Removed.
- 8:23 PM FeatureFlags edited by
- (diff)
- 8:15 PM Changeset in webkit [147979] by
-
- 24 edits in trunk
Remove HTML Notification
https://bugs.webkit.org/show_bug.cgi?id=114231
Reviewed by Ryosuke Niwa.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
The feature is dead. It was only kept in the tree because of chromium.
- Configurations/FeatureDefines.xcconfig:
- Modules/notifications/Notification.cpp:
(WebCore):
(WebCore::Notification::Notification):
- Modules/notifications/Notification.h:
(Notification):
- Modules/notifications/NotificationCenter.h:
(NotificationCenter):
- Modules/notifications/NotificationCenter.idl:
- page/FeatureObserver.h:
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/qt:
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationClicked):
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
(WebCore::NotificationPresenterClientQt::dumpShowText):
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- qmake/mkspecs/features/features.pri:
LayoutTests:
- fast/notifications/notifications-with-permission-expected.txt:
- fast/notifications/notifications-with-permission.html:
- 8:09 PM Changeset in webkit [147978] by
-
- 2 edits in trunk/LayoutTests
[Mac][WebKit2] destroy-during-async-npp-new.html does not crash anymore
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08
- platform/mac-wk2/TestExpectations:
The test destroy-during-async-npp-new.html has not crashed in a long time. Re-enable
it to see how the bots like it.
- 8:08 PM FeatureFlags edited by
- (diff)
- 7:43 PM Changeset in webkit [147977] by
-
- 2 edits in trunk/Source/WebCore
Don't try to remove a non-existent snapshot
https://bugs.webkit.org/show_bug.cgi?id=114226
<rdar://problem/13604480>
Reviewed by Darin Adler.
We don't need to trigger the timer to remove a snapshot
if there was never a snapshot displayed.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::setDisplayState): Detect if we're moving from the DisplayingSnapshot state.
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired): Guard against a missing renderer.
- 7:36 PM UnmaintainedFeatureList edited by
- Replaced the content by a hyperlink to … (diff)
- 7:36 PM FeatureFlags edited by
- Copied the rest of info from … (diff)
- 7:35 PM FeatureFlags edited by
- (diff)
- 7:34 PM UnmaintainedFeatureList edited by
- (diff)
- 7:32 PM FeatureFlags edited by
- Added grid layout (diff)
- 7:29 PM MaintainedFeatureList edited by
- Replaced the content with a link to FeatureFlags (diff)
- 7:28 PM FeatureFlags edited by
- Added the contributor list for CSS3_TEXT_LINE_BREAK (diff)
- 7:26 PM Changeset in webkit [147976] by
-
- 13 edits in trunk/Source/WTF
wtf/dtoa/* uses a confusing name to reference its buffers
https://bugs.webkit.org/show_bug.cgi?id=109709
Reviewed by Darin Adler.
The data structure Vector in wtf/dtoa has nothing to do with a traditional
vector, is it just a pointer and the length of the pointed buffer.
Rename it to BufferReference to avoid mistakes.
- wtf/dtoa/bignum-dtoa.cc:
- wtf/dtoa/bignum-dtoa.h:
- wtf/dtoa/bignum.cc:
- wtf/dtoa/bignum.h:
(Bignum):
- wtf/dtoa/double-conversion.cc:
- wtf/dtoa/fast-dtoa.cc:
- wtf/dtoa/fast-dtoa.h:
- wtf/dtoa/fixed-dtoa.cc:
- wtf/dtoa/fixed-dtoa.h:
(double_conversion):
- wtf/dtoa/strtod.cc:
- wtf/dtoa/strtod.h:
(double_conversion):
- wtf/dtoa/utils.h:
(double_conversion):
(WTF::double_conversion::BufferReference::BufferReference):
(WTF::double_conversion::BufferReference::SubBufferReference):
(StringBuilder):
- 7:12 PM UnmaintainedFeatureList edited by
- (diff)
- 6:45 PM Changeset in webkit [147975] by
-
- 2 edits in trunk/Source/WebCore
Do not define CAN_THEME_URL_ICON for PLATFORM(WIN_CAIRO)
https://bugs.webkit.org/show_bug.cgi?id=108444
Reviewed by Darin Adler.
Image::loadPlatformResource("urlIcon") returns nothing
since r30961 on Windows which makes the code useless.
- loader/icon/IconDatabase.cpp:
- 6:40 PM Changeset in webkit [147974] by
-
- 9 edits in trunk/Source
Build fix.
- platform/win/DragImageWin.cpp:
(WebCore::createDragImageIconForCachedImageFilename):
- WebKit.vcproj/WebKitExports.def.in:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 6:34 PM Changeset in webkit [147973] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] WebPage: fix build due to type mismatches
https://bugs.webkit.org/show_bug.cgi?id=114148
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-08
Reviewed by Darin Adler.
Add explicit conversions between LayoutUnit and int, and between
LayoutRect and IntRect.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::rectForNode):
- 6:27 PM Changeset in webkit [147972] by
-
- 2 edits in trunk/Source/WTF
[BlackBerry] MathExtras: macros defined in math.h conflict with the real functions
https://bugs.webkit.org/show_bug.cgi?id=112683
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-08
Reviewed by Darin Adler.
After calls to signbit and friends were prefixed with std:: in
r143232, the BlackBerry port no longer compiles.
The solution is to get rid of the macros defined in math.h and use
the real functions instead.
- wtf/MathExtras.h:
- 6:06 PM Changeset in webkit [147971] by
-
- 3 edits in trunk/LayoutTests
[Mac] Fix test expectations for ietestcenter/css3/grid/grid-items-003.htm
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08
- platform/mac-wk2/TestExpectations: The test pass on WebKit2 Mountain Lion Release builds.
- platform/mac/TestExpectations: The test is flaky on Mountain Lion Release builds.
- 5:50 PM Changeset in webkit [147970] by
-
- 3 edits in trunk/LayoutTests
[Mac][WebKit2] fast/css/sticky/sticky-top-zoomed.html is flaky on Mountain Lion
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
The test is flaky on MountainLion for WebKit1 and WebKit2. It fails systematically
in Debug or on older OS X.
- 5:46 PM UnmaintainedFeatureList edited by
- (diff)
- 5:45 PM Changeset in webkit [147969] by
-
- 15 edits in trunk/LayoutTests
Tests for exceptions of type DOMException.TYPE_ERR in encrypted-media-syntax.html are broken
https://bugs.webkit.org/show_bug.cgi?id=113119
Renames testException() to testDOMException() and tweaks the check.
Also adds a new testException() helper for checking non-DOM exceptions.
Patch by Steve Block <steveblock@chromium.org> on 2013-04-08
Reviewed by Darin Adler.
- media/encrypted-media/encrypted-media-not-loaded.html:
- media/encrypted-media/encrypted-media-syntax-expected.txt:
- media/encrypted-media/encrypted-media-syntax.html:
- media/encrypted-media/encrypted-media-v2-syntax.html:
- media/media-fullscreen.js:
(buttonClickHandler):
(canplaythrough):
- media/track/track-add-remove-cue.html:
- media/track/track-addtrack-kind.html:
- media/track/track-cue-mutable.html:
- media/video-buffered.html:
- media/video-play-require-user-gesture.html:
- media/video-seek-no-src-exception.html:
- media/video-seekable.html:
- media/video-test.js:
(testDOMException):
- media/video-volume.html:
- 5:39 PM Changeset in webkit [147968] by
-
- 2 edits in trunk/LayoutTests
Skip async plugin test while fixing the failure.
https://bugs.webkit.org/show_bug.cgi?id=114217
- platform/mac-wk2/TestExpectations:
- 5:31 PM Changeset in webkit [147967] by
-
- 2 edits in trunk
Bug 110293 uses read -d which is a non-portable bashism
https://bugs.webkit.org/show_bug.cgi?id=113349
Reviewed by Gustavo Noronha Silva.
- Source/autotools/SetupWebKitFeatures.m4: Pass the default feature set to the
feature script in a more portable way.
- 5:22 PM Changeset in webkit [147966] by
-
- 3 edits in trunk/Tools
Remove chromium EWS support, and fix broken test.
https://bugs.webkit.org/show_bug.cgi?id=114221
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractChromiumEWS): Removed.
(ChromiumLinuxEWS): Removed.
(ChromiumLinuxDebugEWS): Removed.
(ChromiumWindowsEWS): Removed.
(ChromiumAndroidEWS): Removed.
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest): Fix misspelled class name.
(test_ewses): Fix entry point name to ensure test is run.
- 5:10 PM Changeset in webkit [147965] by
-
- 7 edits3 adds in trunk
DFG should be able to inline string equality comparisons
https://bugs.webkit.org/show_bug.cgi?id=114224
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
Inline 8-bit string equality, go to slow path for 16-bit strings. 2x speed-up for string equality
comparisons on 8-bit strings. 20-50% speed-up on JSRegress/HashMap tests. 30% speed-up on
string-fasta. 2% speed-up on SunSpider overall. Some small speed-ups elsewhere.
This is a gnarly change but we have loads of test coverage already between the HashMap tests and
preexisting DFG string equality tests (which appear to have been designed to test OSR exits, but
also give us good overall coverage on string equality behavior).
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileStringEquality):
(DFG):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
LayoutTests:
Reviewed by Oliver Hunt.
- fast/js/regress/script-tests/string-equality.js: Added.
(foo):
- fast/js/regress/string-equality-expected.txt: Added.
- fast/js/regress/string-equality.html: Added.
- 4:59 PM Changeset in webkit [147964] by
-
- 2 edits in trunk/Source/WebKit2
Don't run primary plugin detection if plugin snapshotting is off
https://bugs.webkit.org/show_bug.cgi?id=114222
<rdar://problem/13603988>
Reviewed by Dean Jackson.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):
- 4:55 PM FeatureFlags edited by
- Rename INPUT_TYPE_DATETIME to INPUT_TYPE_DATETIME_INCOMPLETE (diff)
- 4:53 PM Changeset in webkit [147963] by
-
- 4 edits15 deletes in trunk
[WIN] Remove WebKit2 source code
https://bugs.webkit.org/show_bug.cgi?id=114096
Reviewed by Anders Carlsson.
Source/WebKit2:
Remove conditional includes for the windows platform.
- Shared/API/c/WKBase.h:
- UIProcess/API/C/WKAPICast.h:
Tools:
Remove the windows specific parts of the MiniBrowser.
- MiniBrowser/MiniBrowser.vcproj: Removed.
- MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
- MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
- MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
- MiniBrowser/win/BrowserView.cpp: Removed.
- MiniBrowser/win/BrowserView.h: Removed.
- MiniBrowser/win/BrowserWindow.cpp: Removed.
- MiniBrowser/win/BrowserWindow.h: Removed.
- MiniBrowser/win/MiniBrowser.cpp: Removed.
- MiniBrowser/win/MiniBrowser.h: Removed.
- MiniBrowser/win/MiniBrowser.rc: Removed.
- MiniBrowser/win/main.cpp: Removed.
- MiniBrowser/win/resource.h: Removed.
- MiniBrowser/win/stdafx.cpp: Removed.
- MiniBrowser/win/stdafx.h: Removed.
- 4:41 PM Changeset in webkit [147962] by
-
- 43 edits1 copy3 adds in trunk/Source
Stop #include-ing all of JavaScriptCore in every DOM-related file
https://bugs.webkit.org/show_bug.cgi?id=114220
Reviewed by Sam Weinig.
I separated WeakInlines.h from Weak.h so WebCore data types that need
to declare a Weak<T> data member don't have to #include all of the
infrastructure for accessing that data member.
This also required separating Weak<T> from PassWeak<T> by removing the
WeakImplAccessor class template and pushing code down into its subclasses.
- API/JSWeakObjectMapRefPrivate.cpp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/UnlinkedCodeBlock.h:
- heap/PassWeak.h:
(JSC):
(PassWeak):
(JSC::::PassWeak):
(JSC::::operator):
(JSC::::get):
- heap/SlotVisitorInlines.h:
- heap/Weak.h:
(JSC):
(Weak):
- heap/WeakInlines.h: Copied from Source/JavaScriptCore/heap/Weak.h.
(JSC):
(JSC::::Weak):
(JSC::::operator):
(JSC::::get):
(JSC::::was):
(JSC::weakClear):
- jit/JITThunks.h:
- runtime/RegExpCache.h:
- runtime/Structure.h:
- runtime/WeakGCMap.h:
../WebCore:
I separated ScriptWrappableInlines.h from ScriptWrappable.h so
WebCore data types that inherit from ScriptWrappable don't
have to #include all of the infrastructure for accessing that data member.
- ForwardingHeaders/heap/PassWeak.h: Added.
- ForwardingHeaders/heap/WeakInlines.h: Added.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMWrapperWorld.h:
- bindings/js/JSDOMBinding.h:
(JSC):
- bindings/js/JSEventListener.h:
- bindings/js/JSMutationCallback.cpp:
- bindings/js/JSNodeFilterCondition.h:
- bindings/js/ScriptWrappable.h:
(JSC):
(WebCore):
(ScriptWrappable):
- bindings/js/ScriptWrappableInlines.h: Added.
(WebCore):
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::clearWrapper):
- bridge/qt/qt_instance.h:
- bridge/qt/qt_runtime.h:
- bridge/runtime_root.cpp:
- bridge/runtime_root.h:
- css/StylePropertySet.cpp:
- dom/LiveNodeList.cpp:
(WebCore::LiveNodeListBase::reportMemoryUsage):
- dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
- inspector/InspectorDebuggerAgent.cpp:
- inspector/NetworkResourcesData.cpp:
- loader/cache/CachedSVGDocument.cpp:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::reportMemoryUsage):
../WebKit2:
- Shared/WebCoreArgumentCoders.cpp:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
- 4:27 PM Changeset in webkit [147961] by
-
- 2 edits in trunk/LayoutTests
[Mac][WebKit2] The test images-enabled-unset-can-block-image-and-can-reload-in-place.html passes
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08
- platform/mac-wk2/TestExpectations:
This test have been passing reliably for many revisions and pass locally.
- 4:18 PM Changeset in webkit [147960] by
-
- 12 edits4 deletes in trunk
[BlackBerry] Update BlackBerry JavaScript API
https://bugs.webkit.org/show_bug.cgi?id=114065
Patch by Jeff Rogers <jrogers@rim.com> on 2013-04-08
Reviewed by Rob Buis.
.:
Internal PR 317350
Export JSC symbols in BlackBerry build.
- Source/cmake/OptionsBlackBerry.cmake:
Source/WebKit:
Internal PR 317350
Remove obsolete files.
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
Internal PR 317350
Add new API for determining if user gesture is being processed.
Remove obsolete files.
Properly expose JSC global context.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
(BlackBerry::WebKit::WebPage::globalContext):
(BlackBerry::WebKit::WebPage::isProcessingUserGesture):
(WebKit):
- Api/WebPage.h:
- Api/WebPageClient.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- WebCoreSupport/ChromeClientBlackBerry.cpp:
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
- WebCoreSupport/ClientExtension.cpp: Removed.
- WebCoreSupport/ClientExtension.h: Removed.
- WebCoreSupport/ExternalExtension.cpp: Removed.
- WebCoreSupport/ExternalExtension.h: Removed.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):
- 4:01 PM Changeset in webkit [147959] by
-
- 2 edits in trunk/LayoutTests
Update the Mac WebKit2 TestExpectations for http/tests/canvas/canvas-slow-font-loading.html
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08
- platform/mac-wk2/TestExpectations: The test is flaky in release. Mark it as such.
- 4:01 PM WikiStart edited by
- Add links to new feature list pages. (diff)
- 3:56 PM MaintainedFeatureList created by
- 3:47 PM UnmaintainedFeatureList edited by
- (diff)
- 3:46 PM Changeset in webkit [147958] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Clean up render theme code.
https://bugs.webkit.org/show_bug.cgi?id=114216
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-08
Reviewed by Rob Buis.
BlackBerry PR 323062
Clean up redundant code.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore):
(WebCore::RenderThemeBlackBerry::paintSliderTrack):
- platform/blackberry/RenderThemeBlackBerry.h:
(RenderThemeBlackBerry):
- 3:19 PM Changeset in webkit [147957] by
-
- 2 edits in trunk/Tools
Use port 6665 instead of 6667 since the latter doesn't seem to work well.
- Scripts/webkitpy/common/config/irc.py:
- 3:05 PM Changeset in webkit [147956] by
-
- 14 edits5 adds in trunk
Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
https://bugs.webkit.org/show_bug.cgi?id=113139
Patch by Arunprasad Rajkumar <arunprasadr@nds.com> on 2013-04-08
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: plugins/npruntime/tostring.html
plugins/npruntime/valueof.html
- bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::~CInstance):
(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(Bindings):
(JSC::Bindings::CInstance::invokeConstruct):
(JSC::Bindings::CInstance::stringValue):
(JSC::Bindings::CInstance::booleanValue):
(JSC::Bindings::CInstance::valueOf):
(JSC::Bindings::CInstance::toJSPrimitive):
- bridge/c/c_instance.h:
(CInstance):
Tools:
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
- DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
- DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
(ToStringAndValueOfObject):
(ToStringAndValueOfObject::ToStringAndValueOfObject):
(ScriptableObject):
(ToStringAndValueOfObject::ScriptableObject::hasMethod):
(ToStringAndValueOfObject::ScriptableObject::invoke):
(ToStringAndValueOfObject::ScriptableObject::pluginTest):
(ToStringAndValueOfObject::NPP_GetValue):
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- GNUmakefile.am:
LayoutTests:
- platform/qt-mac/TestExpectations:
- platform/wk2/TestExpectations:
- plugins/npruntime/tostring-expected.txt: Added.
- plugins/npruntime/tostring.html: Added.
- plugins/npruntime/valueof-expected.txt: Added.
- plugins/npruntime/valueof.html: Added.
- 2:43 PM Changeset in webkit [147955] by
-
- 4 edits in trunk
REGRESSION (r138858): Crash in WebCore::FrameLoader::~FrameLoader() when opening page in a background tab
https://bugs.webkit.org/show_bug.cgi?id=109935
<rdar://problem/13225963>
Reviewed by Brady Eidson.
Previously, we were deciding if a Page could go into
the PageCache by blacklisting certain load types. Instead,
whitelist the load types that we know can go into the cache,
so that newly-added load types are not cached unless
that is explicitly desired.
The crash occurs when a page which is actively loading
is put into the page cache while doing a redirect with
FrameLoadTypeRedirectWithLockedBackForwardList (note that
this is a redirect that was not covered in the blacklist),
and then promptly removed from the page cache, resulting
in resources from the redirect target (the now-active page)
being incorrectly destroyed.
No new tests, only known crash repro case is extremely
timing dependent (and only happens in WebKit2, with tiled
drawing, in background tabs).
- history/PageCache.cpp:
(WebCore::PageCache::canCache):
Adjust a test which depended on slow-redirects going
into the page cache (which will no longer happen)
to instead click on a link.
- fast/history/timed-refresh-in-cached-frame.html:
- 2:41 PM Changeset in webkit [147954] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::continueDidReceiveResponse):
- 2:31 PM Changeset in webkit [147953] by
-
- 3 edits in trunk/Source/WebKit2
Web/Plugin process deadlock initializing async plugins.
<rdar://problem/13525232> and https://bugs.webkit.org/show_bug.cgi?id=114217
Reviewed by Anders Carlsson.
The "Async initialization complete" messages probably don't have to be synchronous.
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPluginAsynchronously): Notify of initialization success/failure asynchronously.
- WebProcess/Plugins/PluginProxy.messages.in:
- 2:24 PM Changeset in webkit [147952] by
-
- 11 edits in trunk/Source
Add an async version of ResourceHandle::didReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=114215
Reviewed by Sam Weinig.
Source/WebCore:
In order to support converting NSURLConnections to NSURLDownloads when using the network process
we need an async version of didReceiveResponse.
- WebCore.exp.in:
- platform/network/ResourceHandleClient.cpp:
(WebCore::ResourceHandleClient::didReceiveResponseAsync):
Just call continueDidReceiveResponse().
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::continueWillSendRequest):
Split up a single condition in two, making it easier to see which assertion fails.
(WebCore::ResourceHandle::continueDidReceiveResponse):
Call -[WebCoreResourceHandleAsOperationQueueDelegate continueDidReceiveResponse].
(WebCore::ResourceHandle::continueShouldUseCredentialStorage):
(WebCore::ResourceHandle::continueCanAuthenticateAgainstProtectionSpace):
(WebCore::ResourceHandle::continueWillCacheResponse):
Split up a single condition in two, making it easier to see which assertion fails.
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h:
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate continueDidReceiveResponse]):
Signal the semaphore.
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
Call didReceiveResponseAsync on the main thread and wait on the semaphore.
Source/WebKit2:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
Send the message and then call continueDidReceiveResponse.
- 2:07 PM Changeset in webkit [147951] by
-
- 2 edits in trunk
[GTK] Configure should verify ICU is installed on mingw
https://bugs.webkit.org/show_bug.cgi?id=113645
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-04-08
Reviewed by Gustavo Noronha Silva.
- Source/autotools/FindDependencies.m4: When falling back to hard-coded compiler flags
for ICU and mingw, check that headers do exist on the system and error out otherwise.
- 2:01 PM Changeset in webkit [147950] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- 2:00 PM Changeset in webkit [147949] by
-
- 2 edits in trunk/Source/WebCore
Crash in ScrollingCoordinator::mainThreadScrollingReasons() when going back
https://bugs.webkit.org/show_bug.cgi?id=114214
-and corresponding-
<rdar://problem/13208616>
Reviewed by Anders Carlsson.
When a page is restoring from the page cache, the mainFrame can have a null
Document. So we should null-check the Document here.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::mainThreadScrollingReasons):
- 1:51 PM Changeset in webkit [147948] by
-
- 3 edits in trunk/Source/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 1:25 PM Changeset in webkit [147947] by
-
- 2 edits in trunk/Source/JavaScriptCore
Make resolve more robust in the face of lookup misses
https://bugs.webkit.org/show_bug.cgi?id=114211
Reviewed by Filip Pizlo.
This simply short circuits the resolve operations in the
event that we don't find a path to a property. There's no
repro case for this happening unfortunately.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- 1:09 PM Changeset in webkit [147946] by
-
- 2 edits in trunk/Tools
[GTK] Bump gnome-themes-standard to 3.6.0
https://bugs.webkit.org/show_bug.cgi?id=114155
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-08
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
dependency of gnome-themes-standard accordingly.
- 1:05 PM Changeset in webkit [147945] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] More null checks for m_mainFrame
https://bugs.webkit.org/show_bug.cgi?id=114172
Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-04-08
Reviewed by Rob Buis.
After r147744, some unit tests were crashing on WebPage
shutdown, because BackingStorePrivate::repaint() now uses
pixelContentsRect() (accessing m_webPage->contentsRect())
instead of BackingStoreClient::contentsRect(). In m_webPage,
m_mainFrame had already been set to 0.
Make us more robust against these errors by checking
the existence of m_mainFrame more diligently.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
(BlackBerry::WebKit::WebPagePrivate::contentsSize):
(BlackBerry::WebKit::WebPagePrivate::absoluteVisibleOverflowSize):
(BlackBerry::WebKit::WebPagePrivate::setViewMode):
- 12:50 PM UnmaintainedFeatureList edited by
- (diff)
- 12:35 PM Changeset in webkit [147944] by
-
- 3 edits in trunk/Tools
Remove my watchlist entries.
https://bugs.webkit.org/show_bug.cgi?id=114180
Reviewed by Adam Barth.
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/watchlist:
- 12:18 PM Changeset in webkit [147943] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed gardening. Remove expected results added by r147824.
- platform/mac-future/accessibility/press-action-is-first-expected.txt: Removed.
- 12:10 PM Changeset in webkit [147942] by
-
- 9 edits4 adds2 deletes in trunk
Simplify ContainerNode::removeChildren
https://bugs.webkit.org/show_bug.cgi?id=113517
Reviewed by Darin Adler.
The patch is based on the work made by Elliott Sprehn. He kindly agreed
for me to finalize the last bits and pieces of the fix.
Source/WebCore:
Simplify ContainerNode::removeChildren by merging the loops and removing
willRemoveChildren. This removes two traversals of the children, avoids
refing and derefing all the children once, avoids allocating a second
NodeVector of children, and means we detach() in the same order as
normal removal.
This does mean you can get into an infinite loop with DOMNodeRemoved
listeners by continously adding nodes but this is true in all other browsers
and the current behavior is bad because it means you don't get notified
of nodes added during removal (which other browsers do notify of). This
patch removes the containerNode.html test that originally tested for this
infinite loop and adds a new one that tests that all nodes get notified.
This makes PerformanceTests/Parser/innerHTML-setter.html 2-6% faster.
There's also a new test verifying ranges remain consistent if modified
inside an mutation event handler. Without the patch it's possible to create
a range with boundaries outside of the DOM tree.
Tests: fast/dom/Range/range-remove-children-event.html
fast/events/mutation-during-innerHTML.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
- dom/Document.cpp:
- dom/Document.h: nodeChildrenWillBeRemoved is not needed any more.
- dom/Range.cpp:
- dom/Range.h: nodeChildrenWillBeRemoved is not needed any more.
LayoutTests:
Remove containerNode.html test since it was checking for an infinite
loop when adding DOM nodes inside a DOMNodeRemoved mutation event
handler, but we actually do want to allow an infinite loop here for
correctness and compatability with other browsers.
Also added mutation-during-innerHTML which checks that all nodes
are notified of being removed even if they were added during the
DOMNodeRemoved notification.
There's a new test range-remove-children-event that verifies the
ranges modified inside a mutation event handler remain consistent.
- fast/dom/MutationObserver/added-out-of-order-expected.txt:
- fast/dom/MutationObserver/added-out-of-order.html:
- fast/dom/Range/range-remove-children-event-expected.txt: Added.
- fast/dom/Range/range-remove-children-event.html: Added.
- fast/dom/containerNode-expected.txt: Removed.
- fast/dom/containerNode.html: Removed.
- fast/events/mutation-during-innerHTML-expected.txt: Added.
- fast/events/mutation-during-innerHTML.html: Added.
- 12:06 PM Changeset in webkit [147941] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix.
- 12:06 PM UnmaintainedFeatureList edited by
- (diff)
- 11:39 AM Changeset in webkit [147940] by
-
- 13 edits in trunk/Source/WebCore
Remove some #includes in headers in rendering code
https://bugs.webkit.org/show_bug.cgi?id=114079
Reviewed by Sam Weinig.
Clean up #includes in RenderObject, RenderLayer etc.
Moved makeMatrixRenderable() into RenderLayer.app, allowing
the removal of a TransformationMatrix.h include.
Make some RenderLayer functions that deal with filters not inline,
to avoid including RenderLayerFilterInfo.h.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/ImageOrientation.cpp:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/transforms/AffineTransform.cpp:
- platform/graphics/transforms/AffineTransform.h:
- rendering/RenderBoxModelObject.h:
- rendering/RenderLayer.cpp:
(WebCore::makeMatrixRenderable):
(WebCore::RenderLayer::filterRenderer):
(WebCore::RenderLayer::filterInfo):
(WebCore::RenderLayer::ensureFilterInfo):
(WebCore::RenderLayer::removeFilterInfoIfNeeded):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.h:
- rendering/RenderLineBoxList.h:
- rendering/RenderObject.h:
- 11:38 AM Changeset in webkit [147939] by
-
- 5 edits in trunk
Unreviewed, rolling out r147850.
http://trac.webkit.org/changeset/147850
https://bugs.webkit.org/show_bug.cgi?id=113706
Changeset crossed paths with 147505, which is the same fix.
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth):
LayoutTests:
- fast/inline/inline-with-empty-inline-children-expected.txt:
- fast/inline/inline-with-empty-inline-children.html:
- 11:20 AM UnmaintainedFeatureList edited by
- (diff)
- 11:20 AM UnmaintainedFeatureList edited by
- Already in the list + not a problem. (diff)
- 11:17 AM Changeset in webkit [147938] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/12834449> Crashes in WebSocketChannel::processFrame when processing a ping
https://bugs.webkit.org/show_bug.cgi?id=114178
Reviewed by Brady Eidson.
No test, I could never reproduce even manually.
Calling enqueueRawFrame() could change incoming buffer, so a subsequent skipBuffer()
would operate on wrong assumptions. This happened because enqueueRawFrame() actually
tried to process the queue, and send failure sometimed clears m_buffer.
Fixing this by decoupling enqueuing from sending, and making sure that skipBuffer()
in ping frame processing case is performed at a safe time.
- Modules/websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::send): (WebCore::WebSocketChannel::startClosingHandshake): (WebCore::WebSocketChannel::processFrame): (WebCore::WebSocketChannel::enqueueTextFrame): (WebCore::WebSocketChannel::enqueueRawFrame): (WebCore::WebSocketChannel::enqueueBlobFrame):
- 11:09 AM Changeset in webkit [147937] by
-
- 17 edits10 deletes in trunk
REGRESSION (r147502): Animations of CA filters broken
https://bugs.webkit.org/show_bug.cgi?id=114067
Reviewed by Dean Jackson.
Revert r147502 [1] because it broke CA filter animations.
[1]: http://trac.webkit.org/changeset/147502
Source/WebCore:
- platform/graphics/IntRectExtent.h:
(WebCore::IntRectExtent::isZero):
(IntRectExtent):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::needsCompositingLayersRebuiltForOverflow):
(WebCore):
(WebCore::RenderLayer::styleChanged):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateFilters):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
Source/WTF:
- wtf/Platform.h:
LayoutTests:
- compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
- css3/filters/composited-layer-bounds-after-sw-blur-animation-expected.txt: Removed.
- css3/filters/composited-layer-bounds-after-sw-blur-animation.html: Removed.
- css3/filters/composited-layer-bounds-with-composited-blur-expected.txt: Removed.
- css3/filters/composited-layer-bounds-with-composited-blur.html: Removed.
- css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt: Removed.
- css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change.html: Removed.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow-expected.txt: Removed.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow.html: Removed.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow-expected.txt: Removed.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow.html: Removed.
- css3/filters/filter-change-repaint-composited-expected.png:
- css3/filters/filter-change-repaint-composited.html:
- platform/qt/TestExpectations:
- 11:05 AM UnmaintainedFeatureList edited by
- (diff)
- 11:01 AM UnmaintainedFeatureList edited by
- (diff)
- 11:00 AM UnmaintainedFeatureList edited by
- (diff)
- 10:54 AM UnmaintainedFeatureList edited by
- (diff)
- 10:54 AM Changeset in webkit [147936] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Force horizontal list to be horizontal scrollable.
https://bugs.webkit.org/show_bug.cgi?id=114173
Patch by Iris Wu <shuwu@blackberry.com> on 2013-04-08
Reviewed by Rob Buis.
Force content to be horizontal/vertical overscrollable if it
scrolls in horizontal/vertical way.
PR 237440
Internally Reviewed by Arvid Nilsson.
- WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 10:53 AM UnmaintainedFeatureList edited by
- Added CSS Grid Layout to the list (diff)
- 10:52 AM Changeset in webkit [147935] by
-
- 4 edits in tags/Safari-537.35.10/Source
Versioning.
- 10:51 AM Changeset in webkit [147934] by
-
- 2 edits in trunk/Source/JavaScriptCore
Allow KeywordLookupGenerator.py to work on Windows with Windows style line endings
https://bugs.webkit.org/show_bug.cgi?id=63234
Patch by Justin Haygood <jhaygood@reaktix.com> on 2013-04-08
Reviewed by Oliver Hunt.
- KeywordLookupGenerator.py:
(parseKeywords):
- 10:48 AM Changeset in webkit [147933] by
-
- 4 edits in trunk
Source/JavaScriptCore: REGRESSION(r146669): Assertion hit in JSC::DFG::SpeculativeJIT::fillSpeculateCell() running webgl tests
https://bugs.webkit.org/show_bug.cgi?id=114129
<rdar://problem/13594898>
Reviewed by Darin Adler.
The check to see if we need a cell check when simplifying a GetById or PutById needs to be hoisted to
above where we abstractly execute the instruction, since after we abstracting execute it, it will
seem like it no longer needs the cell check.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
LayoutTests: REGRESSION(r146669): Assertion hit in JSC::DFG::SpeculativeJIT::fillSpeculateCell() running webgl tests
https://bugs.webkit.org/show_bug.cgi?id=114129 and https://bugs.webkit.org/show_bug.cgi?id=90649
<rdar://problem/13594898> and <rdar://problem/11815727>
Reviewed by Darin Adler.
Unskip these tests because they give us DFG coverage and they are now passing.
- platform/mac/TestExpectations:
- 10:46 AM Changeset in webkit [147932] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Avoid "QFont::setPixelSize: Pixel size <= 0 (0)"
https://bugs.webkit.org/show_bug.cgi?id=114175
Reviewed by Allan Sandfeld Jensen.
QFont doesn't support a 0-size but WebCore does.
Leave our QFont in its default state in this case to avoid the warning.
- platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- 10:42 AM Changeset in webkit [147931] by
-
- 2 edits in tags/Safari-537.35.10/Source/WebCore
Merged r147806. <rdar://problem/13591653>
- 10:41 AM Changeset in webkit [147930] by
-
- 5 edits in trunk
Counter still gets incremented when counter-increment is set to none
https://bugs.webkit.org/show_bug.cgi?id=84985
Patch by Yi Shen <max.hong.shen@gmail.com> on 2013-04-08
Reviewed by Darin Adler.
When the counter-increment is set to none, no counters are incremented.
Source/WebCore:
Tests: New test cases added in fast/css/counters/counter-increment-tests.htm
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyCounter::applyValue):
LayoutTests:
- fast/css/counters/counter-increment-tests-expected.txt: Added new test cases.
- fast/css/counters/counter-increment-tests.htm: Added new test cases.
- 10:37 AM Changeset in webkit [147929] by
-
- 2 edits in trunk/Source/WTF
REGRESSION(r147894): Broke WTFReportBacktrace() on Mac.
<http://webkit.org/b/114174>
Reviewed by Anders Carlsson.
An #elif !OS(ANDROID) block was erroneously removed, turn it into an #else instead since
that path will still be taken for OS(DARWIN).
- wtf/Assertions.cpp:
- 10:26 AM Changeset in webkit [147928] by
-
- 3 edits2 adds2 deletes in trunk
Crash in WebCore::ElementRuleCollector::collectMatchingRulesForList
https://bugs.webkit.org/show_bug.cgi?id=113458
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-04-08
Reviewed by Darin Adler.
Source/WebCore:
A stylesheet which has been invalidated (type changed from "" or
"text/css") was not correctly removed from the list of active
style sheets when its children are changed.
This change releases StyleElement::m_sheet in advance of calling
DocumentStyleSheetCollection::updateActiveStyleSheets.
(StyleElement::clearSheet calls CSSStyleSheet::clearOwnerNode calls
CSSStyleSheet::didMutate calls Document::styleResolverChanged calls
DocumentStyleSheetCollection::updateActiveStyleSheets)
Test: fast/css/style-element-invalidation-crash.html
- dom/StyleElement.cpp:
(WebCore::StyleElement::clearSheet): Release m_sheet before we
trigger an update of the active style sheets.
LayoutTests:
- fast/css/style-element-invalidation-crash-expected.txt: Added.
- fast/css/style-element-invalidation-crash.html: Added.
- fast/css/stylesheet.innerHTML-calls-didmutate.html: Removed.
- fast/css/stylesheet.innerHTML-calls-didmutate-expected.txt: Removed.
- 10:24 AM Changeset in webkit [147927] by
-
- 7 edits in trunk
[GTK] Build Platform as a separate static library
https://bugs.webkit.org/show_bug.cgi?id=114164
Reviewed by Martin Robinson.
.:
- GNUmakefile.am: Add webkit2platform_sources definition.
Source/WebKit2:
This way we reduce a bit the amount of files compiled twice
because of the plugin process.
- GNUmakefile.am:
- GNUmakefile.list.am:
- Platform/gtk/WorkQueueGtk.cpp: Remove unused header.
- Platform/unix/SharedMemoryUnix.cpp: Ditto.
- 10:23 AM Changeset in webkit [147926] by
-
- 3 edits in trunk/LayoutTests
Stop skipping first part of test in LayoutTests/media/track/opera/interfaces/TextTrack/cues.html
https://bugs.webkit.org/show_bug.cgi?id=104255
Updated test to match the one hosted by W3C which has corrected the reported error.
Reviewed by Eric Carlson.
- media/track/opera/interfaces/TextTrack/cues-expected.txt:
- media/track/opera/interfaces/TextTrack/cues.html:
- 10:22 AM Changeset in webkit [147925] by
-
- 8 edits in tags/Safari-537.35.10/Source
Merged r147659. <rdar://problem/13569460>
- 10:20 AM Changeset in webkit [147924] by
-
- 40 edits2 moves2 adds2 deletes in trunk/Source
[GTK] DOM objects created wrapping a base class have incorrect GObject type
https://bugs.webkit.org/show_bug.cgi?id=113132
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Some of the DOM methods can create a concrete instance of another
object, but return a base class. GObject bindings provide custom
kit implementations for Node, Element, Event and EvenTarget, so
any concrete HTMLElement wrapped as an HTMLElement ends up
wrapping the right WebCore object but in the wrong GObject type.
This affects not only HTMLElements, but any polymorphic object
wrapped using a base class.
This patch changes the way objects are created, so that all
classes have their own kit implementation, but for polymorphic
objects the kit implementation of the base class is always
used. The kit method of polymorphic base classes use a generic
wrap method instead of the wrapFoo method like all other
classes. In the static code we provide the implementation of the
generic wrap method for every polimorphic base class, falling back
to their wrapFoo method if the concrete object can't be used to
wrap the object.
Both WebKitDOMBinding and WebKitHTMLElementWrapperFactory now provide
implementations of wrap and have been renamed to WebKitDOMPrivate
and WebKitDOMHTMLPrivate.
- bindings/gobject/GNUmakefile.am:
- bindings/gobject/WebKitDOMBinding.cpp: Removed.
- bindings/gobject/WebKitDOMEventTarget.cpp:
(WebKit::kit): Moved kit implementation from WebKitDOMBinding for
consistency with all other objects that have their own kit.
(WebKit::core): Updated to match the core implementation fo all
other objects.
- bindings/gobject/WebKitDOMEventTargetPrivate.h:
(WebCore):
(WebKit):
- bindings/gobject/WebKitDOMHTMLPrivate.cpp: Added.
(WebKit): Use preprocessor macros to define and set the wrap
functions of all HTML elements, removing a lot of boilerplate code
and making it easier to add new wrap functions in the future.
(WebKit::wrap):
- bindings/gobject/WebKitDOMHTMLPrivate.h: Renamed from Source/WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.h.
(WebCore):
(WebKit):
- bindings/gobject/WebKitDOMObject.cpp:
- bindings/gobject/WebKitDOMPrivate.cpp: Added.
(WebKit):
(WebKit::wrap):
- bindings/gobject/WebKitDOMPrivate.h: Renamed from Source/WebCore/bindings/gobject/WebKitDOMBinding.h.
(WebCore):
(WebKit):
- bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Removed.
- bindings/scripts/CodeGeneratorGObject.pm:
(IsBaseType): Helper function to check if a type is a base class.
(GetBaseClass): Helper function to get the base class for a given
parent type.
(GenerateFunction): Remove special case for EventTarget since the
kit prototype of EventTarget is in its private header like all
other objects.
(GenerateCFile): Add a kit implementation for all objects.
(IsPolymorphic): Helper function to check if the given type is the
base class of a polymorphic object.
(Generate): Include the private header of the base class for
polymorphic objects.
(WriteData): Remove the special case for WebKitDOMNode since now
all objects has a kit method.
- bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
(WebKit::kit):
- bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestExceptionPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructorPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
(WebKit::kit):
- bindings/scripts/test/GObject/WebKitDOMTestNodePrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefsPrivate.h:
(WebKit):
Source/WebKit/gtk:
Remove WebKitDOMBindindg.h include from several files because it's
been renamed and it was not actually needed.
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/EditorClientGtk.cpp:
- webkit/webkithittestresult.cpp:
- 10:08 AM Changeset in webkit [147923] by
-
- 1 copy in tags/Safari-537.35.10
New Tag.
- 10:04 AM Changeset in webkit [147922] by
-
- 2 edits in trunk/Source/WebCore
Fix the build with strict GCC 4.8
Unreviewed build fix.
Initialize dragImage to suppress GCC's warning about it being possibly used uninitialized,
which results is a build failure with GCC 4.8 that sets -Werror=maybe-uninitialized.
No new tests needed.
- page/DragController.cpp:
(WebCore::DragController::doImageDrag):
- 9:52 AM Changeset in webkit [147921] by
-
- 8 edits2 deletes in trunk/Source/WebCore
Remove the unused LayoutTestSupport class
https://bugs.webkit.org/show_bug.cgi?id=114170
Reviewed by Alexey Proskuryakov.
The LayoutTestSupport class is not used by any port anywhere in the code and should be removed.
No new tests - no changes in functionality.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/LayoutTestSupport.cpp: Removed.
- platform/LayoutTestSupport.h: Removed.
- 9:51 AM Changeset in webkit [147920] by
-
- 11 edits1 delete in trunk/Source/WebCore
Remove WebCore::(enable|disable)SecureTextInput methods
https://bugs.webkit.org/show_bug.cgi?id=114126
Reviewed by Alexey Proskuryakov.
Remove the enableSecureTextInput and disableSecureTextInput methods and all the codepaths leading to them.
These were used only by the Chromium port and are as such not required anymore.
No new tests - no changes in functionality.
- GNUmakefile.list.am:
- WebCore.order:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(Document):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::focusedOrActiveStateChanged):
- editing/FrameSelection.h:
(FrameSelection):
- html/PasswordInputType.cpp:
- html/PasswordInputType.h:
(PasswordInputType):
- page/Frame.cpp:
(WebCore::Frame::setDocument):
- platform/SecureTextInput.h: Removed.
- 9:29 AM Changeset in webkit [147919] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix; r147892 moved an export definition out of
a protective #ifdef, causing a link error on platforms which do
not define that method.
- WebCore.exp.in:
- 9:26 AM Changeset in webkit [147918] by
-
- 2 edits in trunk/Source/WTF
Build fix.
- 9:13 AM Changeset in webkit [147917] by
-
- 4 edits in trunk/Source/WebCore
[Qt] Enable text tracks from track elements
https://bugs.webkit.org/show_bug.cgi?id=113522
Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-08
Reviewed by Jocelyn Turcotte.
No new tests because they're already there. This just enables the feature.
- Target.pri:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- platform/qt/LocalizedStringsQt.cpp:
(WebCore):
(WebCore::textTrackSubtitlesText):
(WebCore::textTrackOffText):
(WebCore::textTrackNoLabelText):
- 9:05 AM Changeset in webkit [147916] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Toggle OverWrite mode when pressing the Insert key
https://bugs.webkit.org/show_bug.cgi?id=113384
Reviewed by Martin Robinson.
Perform an OverWrite command as a response to the emission of the
toggle-overwrite signal. Due to the nature of the command it will
only do that when being on a richly editable web content.
- platform/gtk/KeyBindingTranslator.cpp:
(WebCore::toggleOverwriteCallback):
- 8:30 AM Changeset in webkit [147915] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Provide more specific error description for SocketStreamError
https://bugs.webkit.org/show_bug.cgi?id=114134
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-08
Reviewed by Rob Buis.
Pass the reason of a failure to SocketStreamError instance
and notify it via SocketStreamHandleClient::didFailSocketStream().
- platform/network/blackberry/SocketStreamError.h:
(WebCore::SocketStreamError::SocketStreamError):
- platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
(WebCore::SocketStreamHandle::notifyStatusReceived):
- 8:26 AM Changeset in webkit [147914] by
-
- 3 edits5 adds in trunk
[GTK][EFL] HEAD requests changed to GET after 303 redirection
https://bugs.webkit.org/show_bug.cgi?id=110127
Patch by Youenn Fablet <youennf@gmail.com> on 2013-04-08
Reviewed by Martin Robinson.
Source/WebCore:
Made shouldRedirectAsGET always return false for HEAD requests.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::shouldRedirectAsGET):
LayoutTests:
Added tests checking HEAD redirection.
Redirected HEAD requests are expected to remain HEAD requests.
(http://tools.ietf.org/html/draft-ietf-httpbis-p2-semantics-21#section-7.4)
- http/tests/xmlhttprequest/head-redirection-expected.txt: Added.
- http/tests/xmlhttprequest/head-redirection.html: Added.
- http/tests/xmlhttprequest/resources/get_method.php: Added.
- http/tests/xmlhttprequest/resources/redirect_methods.php: Added.
- platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt: Added.
- 7:49 AM Changeset in webkit [147913] by
-
- 9 edits in trunk/Source/WebKit2
[WK2][EFL] WebView: Add callbacks to the WKViewClient to remove direct access to page viewport controller
https://bugs.webkit.org/show_bug.cgi?id=110741
Reviewed by Anders Carlsson.
Provided WKViewClient with didRequestScroll, didRenderFrame and didCompletePageTransition
callbacks so that direct access from WebView to page viewport controller is avoided.
Implementation of callbacks is also added to keep the current EFL WK2 functionality.
- UIProcess/API/C/efl/WKView.h:
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
Moved here code from deleted WebView::didCommitLoad.
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeContentsPosition):
(WebKit):
(WebKit::ViewClientEfl::didRenderFrame):
(WebKit::ViewClientEfl::didCompletePageTransition):
(WebKit::ViewClientEfl::ViewClientEfl):
- UIProcess/efl/ViewClientEfl.h:
(ViewClientEfl):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):
- UIProcess/efl/WebViewClient.cpp:
(WebKit::WebViewClient::didChangeContentsPosition):
(WebKit):
(WebKit::WebViewClient::didRenderFrame):
(WebKit::WebViewClient::didCompletePageTransition):
- UIProcess/efl/WebViewClient.h:
(WebCore):
- 6:35 AM Changeset in webkit [147912] by
-
- 12 edits in trunk/Source/WebCore
DragImage should not depend on Frame and CachedImage
https://bugs.webkit.org/show_bug.cgi?id=21357
Reviewed by Sam Weinig.
Remove Frame and CachedImage dependencies from DragImage.
- dom/Clipboard.h:
(WebCore): Add forward delcaration for CacheImage since it's not
included anymore in DragImage.h.
- page/DragController.cpp:
(WebCore::DragController::startDrag): Use
Frame::dragImageForSelection() and call
dissolveDragImageToFraction() for the returned DragImage. Pass the
font rendering mode to createDragImageForLink, instead of a Frame
that is only used to get the font rendering mode.
(WebCore::DragController::doImageDrag): Get the suggested filename
for the cached image and pass it to
createDragImageIconForCachedImageFilename().
- platform/DragImage.cpp:
(WebCore::createDragImageForLink): Receive a FontRenderingMode
instead of a Frame.
- platform/DragImage.h:
(WebCore): Remove createDragImageForSelection, change
createDragImageForLink to receive a FontRenderingMode instead of a
frame, and rename createDragImageIconForCachedImage as
createDragImageIconForCachedImageFilename since it nows received
the suggested filename of the cached image.
- platform/blackberry/DragImageBlackBerry.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Adapt to API
changes.
- platform/efl/DragImageEfl.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
- platform/gtk/DragImageGtk.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
- platform/mac/DragImageMac.mm:
(WebCore::dissolveDragImageToFraction): Return early if the passed
image is NULL.
(WebCore::createDragImageIconForCachedImageFilename): Adapt to API
changes.
(WebCore::createDragImageForLink): Ditto.
- platform/qt/DragImageQt.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
- platform/win/DragImageWin.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
(WebCore::createDragImageForLink): Ditto.
- platform/wx/DragImageWx.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
- 6:11 AM Changeset in webkit [147911] by
-
- 2 edits in trunk/Source/WebCore
[EFL] REGRESSION(r147743): Use the correct `operator new' override in RenderThemeEfl.
https://bugs.webkit.org/show_bug.cgi?id=114166
Reviewed by Alexis Menard.
r147743 disabled GLOBAL_FAST_MALLOC_NEW on the EFL port, but this has
caused some pixel tests in WK1 to crash.
The problem stems from RenderThemeEfl::applyEdjeRTLState() directly
calling `operator new(size_t)' for some allocations.
RefCounted<RenderTheme>, on its turn, has a WTF_MAKE_FAST_ALLOCATED
call which adds some `operator new' overrides to the class. Our direct
calls in applyEdjeRTLState() made the scope resolution rules choose the
WTF_MAKE_FAST_ALLOCATED version (which uses FastMalloc's allocator),
while WTF::deleteOwnedPtr() calls the global `operator delete' (which
uses the system's free() implementation).
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::applyEdjeRTLState): Explicitly choose the
global `operator new' when calling it.
- 5:57 AM Changeset in webkit [147910] by
-
- 2 edits in trunk/Source/WTF
Unreviewed trivial buildfix after r147799.
Add an ifdef guard to ensure Qt uses its own monotonicallyIncreasingTime()
implemenation instead of the GLIB based one.
- wtf/CurrentTime.cpp:
(WTF):
- 4:13 AM Changeset in webkit [147909] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] WebView's interactive property is not fully respected
https://bugs.webkit.org/show_bug.cgi?id=113066
Reviewed by Jocelyn Turcotte.
WK2 sign-off by Benjamin Poulain.
The QML WebView inherits the "interactive" property from Flickable
which is true by default, and disables the interaction with the
Flickable if set to false.
Resulting from the design of the WebView panning and flicking is
disabled by Flickable but to be consistent we also need to disable
double-tap gestures and pinch gestures since they would trigger
scale and position changes.
- UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureRequestUpdate):
(WebKit::PageViewportControllerClientQt::pinchGestureEnded):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::handleDoubleTapEvent):
- 3:32 AM Changeset in webkit [147908] by
-
- 2 edits in trunk/Tools
[EFL] Mark ShouldGoToBackForwardListItem API test as failing
https://bugs.webkit.org/show_bug.cgi?id=114161
Reviewed by Gyuyoung Kim.
Mark ShouldGoToBackForwardListItem API test as failing for EFL port
as it is crashing due to Bug 111074.
- TestWebKitAPI/PlatformEfl.cmake:
- 2:46 AM Changeset in webkit [147907] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Marked a few tests as failing.
- platform/efl/TestExpectations:
- 2:39 AM Changeset in webkit [147906] by
-
- 2 edits in trunk
Unreviewed GTK build fix.
- Source/autotools/symbols.filter: Exporting a bunch of symbols.
- 2:27 AM Changeset in webkit [147905] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] WebPage: misc build fixes
https://bugs.webkit.org/show_bug.cgi?id=114152
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-08
Reviewed by Carlos Garcia Campos.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::shouldPluginEnterFullScreen):
(BlackBerry::WebKit::WebPagePrivate::didPluginExitFullScreen):
(BlackBerry::WebKit::WebPagePrivate::onPluginStartBackgroundPlay):
(BlackBerry::WebKit::WebPagePrivate::onPluginStopBackgroundPlay):
Remove unused parameters.
(BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
(BlackBerry::WebKit::WebPage::blockZoom):
Replace TAAUTO with TASTART (this changed in r120495).
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
Rename m_fullscreenVideoNode to m_fullscreenNode (this changed in
r142220).
(BlackBerry::WebKit::WebPagePrivate::compositorDrawsRootLayer):
Rename paintingGoesToWindow() to paintsIntoWindow() (this changed in
r113514).
- 2:27 AM Changeset in webkit [147904] by
-
- 2 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk1/fast/loader/willsendrequest-returns-null-for-memory-cache-load-expected.txt: Added after r147829.
- platform/qt/TestExpectations:
- 2:02 AM Changeset in webkit [147903] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark fast/forms/select/popup-closes-on-blur.html as failing for EFL port.
- platform/efl/TestExpectations:
- 1:56 AM Changeset in webkit [147902] by
-
- 3 edits in trunk/LayoutTests
[EFL] Move some inspector tests to efl-wk1/TestExpectation
https://bugs.webkit.org/show_bug.cgi?id=114147
Unreviewed EFL gardening.
Some inspector tests fail on only EFL-WK1 since it does not support plugins yet.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-08
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 1:54 AM Changeset in webkit [147901] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Skip fast/harness/use-page-cache.html for WK2 as WKTR does not support
overriding WebKitUsesPageCachePreferenceKey yet.
- platform/wk2/TestExpectations:
- 1:46 AM Changeset in webkit [147900] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark new accessibility test introduced in r147801 as failing for EFL.
- platform/efl/TestExpectations:
- 1:38 AM Changeset in webkit [147899] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark several ref tests as failure for EFL port.
- platform/efl/TestExpectations:
- 1:28 AM UnmaintainedFeatureList edited by
- (diff)
- 1:26 AM Changeset in webkit [147898] by
-
- 5 edits in trunk/LayoutTests
Regression(r147893) Caused several editing tests to fail
https://bugs.webkit.org/show_bug.cgi?id=114143
Unreviewed.
- editing/deleting/delete-ligature-003-expected.txt:
- editing/deleting/delete-ligature-003.html:
- editing/selection/context-menu-text-selection-expected.txt:
- editing/selection/context-menu-text-selection.html:
- 12:25 AM Changeset in webkit [147897] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] rendering was broken when scrolled ewk_view_single
https://bugs.webkit.org/show_bug.cgi?id=114135
Patch by Ryuan Choi <ryuan.choi@samsung.com> on 2013-04-08
Reviewed by Gyuyoung Kim.
ewk_view_single use memcpy() to copy previous buffer for scrolling, but
memcpy() should not be used when source buffer and destination buffer are
overwrapped.
- ewk/ewk_view_single.cpp:
(_ewk_view_screen_move):
- 12:00 AM Styling Form Controls edited by
- (diff)
Apr 7, 2013:
- 11:53 PM Changeset in webkit [147896] by
-
- 19 edits in trunk/LayoutTests
Regression(r147893) Caused several editing tests to fail
https://bugs.webkit.org/show_bug.cgi?id=114143
Patch by Christophe Dumez <Christophe Dumez> on 2013-04-07
Reviewed by Benjamin Poulain.
r147893 removed some Android code from WebCore but failed to update the
layout tests accordingly. This patch remove Android-specific tests from
several editing layout tests.
- editing/deleting/paragraph-in-preserveNewline-expected.txt:
- editing/deleting/paragraph-in-preserveNewline.html:
- editing/deleting/whitespace-pre-1-expected.txt:
- editing/deleting/whitespace-pre-1.html:
- editing/execCommand/script-tests/toggle-compound-styles.js:
- editing/execCommand/toggle-compound-styles-expected.txt:
- editing/selection/5354455-1-expected.txt:
- editing/selection/5354455-1.html:
- editing/selection/click-in-margins-inside-editable-div-expected.txt:
- editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
- editing/selection/extend-after-mouse-selection-expected.txt:
- editing/selection/extend-after-mouse-selection.html:
- editing/selection/programmatic-selection-on-mac-is-directionless-expected.txt:
- editing/selection/programmatic-selection-on-mac-is-directionless.html:
- editing/selection/script-tests/click-in-margins-inside-editable-div.js:
- editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js:
- editing/selection/selection-extend-should-not-move-across-caret-on-mac-expected.txt:
- editing/selection/selection-extend-should-not-move-across-caret-on-mac.html:
- 11:31 PM Changeset in webkit [147895] by
-
- 2 edits in trunk
Modify .gitignore file to remove entries for chromium generated files
https://bugs.webkit.org/show_bug.cgi?id=114141
Reviewed by Gyuyoung Kim.
- .gitignore:
- 11:20 PM Changeset in webkit [147894] by
-
- 6 edits in trunk/Source/WTF
Remove the android code from WebKit Template Framework
https://bugs.webkit.org/show_bug.cgi?id=114138
Reviewed by Dirk Schulze.
- wtf/Assertions.cpp:
- wtf/Atomics.h:
- wtf/MathExtras.h:
- wtf/Platform.h:
- wtf/ThreadIdentifierDataPthreads.cpp:
- 9:20 PM Changeset in webkit [147893] by
-
- 11 edits in trunk/Source/WebCore
Remove the android code from WebCore
https://bugs.webkit.org/show_bug.cgi?id=114136
Reviewed by Anders Carlsson.
- WebCore.exp.in:
- dom/ViewportArguments.cpp:
(WebCore):
(WebCore::setViewportFeature):
(WebCore::viewportErrorMessageTemplate):
(WebCore::viewportErrorMessageLevel):
- dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):
- editing/EditingBehavior.h:
(WebCore::EditingBehavior::shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom):
(WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
(WebCore::EditingBehavior::shouldNavigateBackOnBackspace):
- editing/EditingBehaviorTypes.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureLongTap):
(WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):
- page/Settings.cpp:
(WebCore):
(WebCore::editingBehaviorTypeForPlatform):
- platform/graphics/FontCache.h:
(FontCache):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::getRenderStyleForStrike):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setEditingBehavior):
- 9:14 PM Changeset in webkit [147892] by
-
- 32 edits in trunk/Source
Add bounds checking for WTF::Vector::operator[]
https://bugs.webkit.org/show_bug.cgi?id=89600
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Make a few JSC classes opt-out of release mode bounds checking.
- assembler/AssemblerBuffer.h:
(AssemblerBuffer):
- assembler/AssemblerBufferWithConstantPool.h:
(AssemblerBufferWithConstantPool):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::bytecodeOffset):
(JSC):
(JSC::replaceExistingEntries):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::bytecodeOffsetForCallAtIndex):
(JSC::CodeBlock::callReturnIndexVector):
(JSC::CodeBlock::codeOrigins):
(RareData):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedEvalCodeBlock::adoptVariables):
(UnlinkedEvalCodeBlock):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
- bytecompiler/BytecodeGenerator.h:
(CallArguments):
(JSC::BytecodeGenerator::instructions):
(BytecodeGenerator):
- bytecompiler/StaticPropertyAnalysis.h:
(JSC::StaticPropertyAnalysis::create):
(JSC::StaticPropertyAnalysis::StaticPropertyAnalysis):
(StaticPropertyAnalysis):
- bytecompiler/StaticPropertyAnalyzer.h:
(StaticPropertyAnalyzer):
(JSC::StaticPropertyAnalyzer::StaticPropertyAnalyzer):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- parser/ASTBuilder.h:
(ASTBuilder):
- runtime/ArgList.h:
(MarkedArgumentBuffer):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
Source/WebCore:
Fix exports
- WebCore.exp.in:
Source/WTF:
Add a template parameter to Vector<> that controls whether
bounds checking is performed in release builds or not.
Defaults to crashing on overflow.
- wtf/Forward.h:
(WTF):
- wtf/Vector.h:
(WTF):
(Vector):
(WTF::Vector::at):
(WTF::Vector::removeLast):
(WTF::::Vector):
(WTF::=):
(WTF::::contains):
(WTF::::find):
(WTF::::reverseFind):
(WTF::::fill):
(WTF::::appendRange):
(WTF::::expandCapacity):
(WTF::::tryExpandCapacity):
(WTF::::resize):
(WTF::::shrink):
(WTF::::grow):
(WTF::::reserveCapacity):
(WTF::::tryReserveCapacity):
(WTF::::reserveInitialCapacity):
(WTF::::shrinkCapacity):
(WTF::::append):
(WTF::::tryAppend):
(WTF::::appendSlowCase):
(WTF::::uncheckedAppend):
(WTF::::appendVector):
(WTF::::insert):
(WTF::::prepend):
(WTF::::remove):
(WTF::::reverse):
(WTF::::releaseBuffer):
(WTF::::checkConsistency):
(WTF::deleteAllValues):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):
- 9:10 PM Changeset in webkit [147891] by
-
- 3 edits in trunk/LayoutTests
Remove the android part of editing/selection/rtl-move-selection-right-left.html
https://bugs.webkit.org/show_bug.cgi?id=114137
Reviewed by Anders Carlsson.
- editing/selection/rtl-move-selection-right-left-expected.txt:
- editing/selection/rtl-move-selection-right-left.html:
- 8:16 PM UnmaintainedFeatureList edited by
- (diff)
- 7:55 PM UnmaintainedFeatureList edited by
- (diff)
- 7:03 PM UnmaintainedFeatureList edited by
- (diff)
- 6:38 PM UnmaintainedFeatureList created by
- 6:09 PM Changeset in webkit [147890] by
-
- 3 edits in trunk/Websites/webkit.org
Simplify the page "Getting the Code" on WebKit.org
https://bugs.webkit.org/show_bug.cgi?id=113980
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-07
Reviewed by Sam Weinig.
- building/checkout.html:
Instead of interleaving instructions for Mac and Windows, just
copy the things that make sense and have two clear sections.
Also mention Linux, it is the exact same instructions as Mac OS X.
Make svn checkout the alternative to a download of the tarball. It is
almost impossible to do a svn checkout on slow networks nowadays.
- 6:01 PM Changeset in webkit [147889] by
-
- 2 edits in trunk/Source/WebCore
Do not allocate static AtomicStrings when searching for alternate font names
https://bugs.webkit.org/show_bug.cgi?id=114110
Reviewed by Geoffrey Garen.
FontCache's alternateFamilyName does some font name substitutions
when a font is not found for a given name.
In the vast majority of cases, no substitutions are made and
alternateFamilyName returns the null atom.
Given the usage the function had a couple of problems:
-It created 6 static AtomicString.
-It did a case insensitive comparison with 6 differents strings
before failing.
This patch aims at solving both issues.
Instead of creating all AtomicString statically, the alternate name
are simply created on the fly as needed. Because the operation is so
unfrequent, and it uses the fast constructor, doing so should not slow
down the function.
To avoid comparing the input to every string, every time, the length of
the input is first evaluated, and we only do the necessary string comparisons.
On x86_64, this reduces the binary size by 2128 bytes.
- platform/graphics/FontCache.cpp:
(WebCore::familyNameEqualIgnoringCase):
When comparing strings, we know:
-The family name is non null.
-The length of both strings is equal.
-The length is not null.
Make the comparison accordingly.
(WebCore::alternateFamilyName):
(WebCore::FontCache::getCachedFontPlatformData):
- 5:52 PM Changeset in webkit [147888] by
-
- 77 edits1 delete in trunk/Source/WebCore
Remove remaining PLATFORM(CHROMIUM)-guarded code in WebCore
https://bugs.webkit.org/show_bug.cgi?id=114081
Remove the remaining PLATFORM(CHROMIUM) build guards. There are still a couple of guards
that most likely apply only to Chromium, like OS(ANDROID) or USE(SKIA_ON_MAC_CHROMIUM),
but removal of these should go into separate patches.
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-04-07
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- config.h:
- history/PageCache.cpp:
(WebCore):
(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::shouldAccelerate):
- html/HTMLCanvasElement.h:
- html/HTMLMediaElement.cpp:
(WebCore::createFileURLForApplicationCacheResource):
(WebCore::HTMLMediaElement::loadResource):
- html/HTMLSelectElement.cpp:
(WebCore):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
- html/MediaDocument.cpp:
(WebCore::MediaDocument::defaultEventHandler):
- html/canvas/EXTDrawBuffers.cpp:
(WebCore::EXTDrawBuffers::satisfiesWebGLRequirements):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::platformLayer):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didBeginFrame):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::notifyFinished):
- page/FeatureObserver.cpp:
(WebCore::FeatureObserver::~FeatureObserver):
- platform/AsyncFileSystem.cpp:
(WebCore):
- platform/ContextMenu.h:
(ContextMenu):
- platform/ContextMenuItem.h:
- platform/Cursor.h:
- platform/DragData.cpp:
(WebCore):
- platform/DragData.h:
- platform/DragImage.h:
- platform/LocalizedStrings.h:
(WebCore):
- platform/Pasteboard.h:
(Pasteboard):
- platform/PlatformExportMacros.h:
- platform/PlatformInstrumentation.h:
(WebCore::PlatformInstrumentation::willDecodeImage):
(WebCore::PlatformInstrumentation::didDecodeImage):
(WebCore::PlatformInstrumentation::willResizeImage):
(WebCore::PlatformInstrumentation::didResizeImage):
- platform/PlatformMenuDescription.h:
(WebCore):
- platform/PlatformSpeechSynthesizer.h:
(PlatformSpeechSynthesizer):
- platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(PlatformWheelEvent):
- platform/ScrollAnimator.cpp:
(WebCore):
(WebCore::ScrollAnimator::handleWheelEvent):
- platform/ScrollAnimator.h:
(ScrollAnimator):
- platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::animationTimerFired):
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateOverhangAreas):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollPositionChanged):
- platform/Scrollbar.cpp:
- platform/SecureTextInput.cpp: Removed.
- platform/SecureTextInput.h:
(WebCore):
- platform/SuddenTermination.h:
(WebCore):
- platform/Widget.h:
(Widget):
- platform/graphics/ANGLEWebKitBridge.h:
- platform/graphics/BitmapImage.h:
- platform/graphics/FloatPoint.h:
(FloatPoint):
- platform/graphics/FloatRect.h:
(FloatRect):
- platform/graphics/FloatSize.h:
(FloatSize):
- platform/graphics/Font.cpp:
(WebCore):
(WebCore::Font::width):
- platform/graphics/Font.h:
(Font):
- platform/graphics/FontCache.cpp:
(WebCore):
- platform/graphics/FontCache.h:
(FontCache):
- platform/graphics/FontDescription.h:
- platform/graphics/FontPlatformData.cpp:
- platform/graphics/GlyphBuffer.h:
(WebCore):
(WebCore::GlyphBuffer::add):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawImageBuffer):
- platform/graphics/GraphicsContext3D.h:
(GraphicsContext3D):
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::supportsBackgroundColorContent):
- platform/graphics/Icon.h:
(Icon):
- platform/graphics/ImageSource.cpp:
- platform/graphics/ImageSource.h:
(WebCore):
- platform/graphics/IntRect.h:
(IntRect):
(WebCore):
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/PlatformLayer.h:
- platform/graphics/SimpleFontData.h:
(SimpleFontData):
(DerivedFontData):
- platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::resizeContext):
- platform/graphics/gpu/DrawingBuffer.h:
(WebCore):
(DrawingBuffer):
- platform/graphics/gpu/SharedGraphicsContext3D.cpp:
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
- platform/image-decoders/ImageDecoder.h:
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::open):
- platform/network/BlobRegistry.cpp:
(WebCore::blobRegistry):
- platform/network/BlobRegistryImpl.cpp:
- platform/network/NetworkStateNotifier.cpp:
- platform/network/NetworkStateNotifier.h:
(NetworkStateNotifier):
- platform/network/NetworkingContext.h:
(NetworkingContext):
- platform/network/ResourceHandleClient.h:
- platform/network/ResourceRequestBase.cpp:
(WebCore):
- platform/text/cf/HyphenationCF.cpp:
- plugins/PluginViewNone.cpp:
(WebCore):
- testing/Internals.cpp:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
- 5:43 PM Changeset in webkit [147887] by
-
- 5 edits in trunk/Source/JavaScriptCore
Use Vector::reserveInitialCapacity() when possible in JavaScriptCore runtime
https://bugs.webkit.org/show_bug.cgi?id=114111
Reviewed by Andreas Kling.
Almost all the code was already using Vector::reserveInitialCapacity()
and Vector::uncheckedAppend(). Fix the remaining parts.
- runtime/ArgList.h:
(MarkedArgumentBuffer): The type VectorType is unused.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
Move the variable closer to where it is needed.
- runtime/JSArray.cpp:
(JSC::JSArray::setLengthWithArrayStorage):
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertyNames):
- 4:56 PM Changeset in webkit [147886] by
-
- 2 edits in trunk/Source/WebCore
[EFL] --minimal build fails because of incorrect usage of GENERATE_THEME in CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=113902
Unreviewed.
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07
- platform/efl/DefaultTheme/CMakeLists.txt:
Put possibly empty variable after non-empty to avoid space
at the beginning of string parameter
- 4:41 PM Changeset in webkit [147885] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] --minimal build fails with error: expected
;' beforereturn'
https://bugs.webkit.org/show_bug.cgi?id=113953
Unreviewed.
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07
- ewk/ewk_security_origin.cpp:
(ewk_security_origin_web_database_quota_get): Added missing semicolon.
- 4:00 PM Changeset in webkit [147884] by
-
- 2 edits in trunk/Source/WTF
[WIN] Fix problems with export macros of AutodrainedPool
https://bugs.webkit.org/show_bug.cgi?id=114132
Reviewed by Geoffrey Garen.
Exporting an inline function results in an error with the MS compiler.
- wtf/AutodrainedPool.h:
(AutodrainedPool):
(WTF::AutodrainedPool::AutodrainedPool):
(WTF::AutodrainedPool::~AutodrainedPool):
(WTF::AutodrainedPool::cycle):
- 3:18 PM Changeset in webkit [147883] by
-
- 5 edits4 deletes in trunk/Source/WebCore
Add default implementation for KURL::fileSystemPath()
https://bugs.webkit.org/show_bug.cgi?id=108326
Reviewed by Benjamin Poulain.
The code for KURL::fileSystemPath() has been duplicated in different ports.
Add an implementation of this function to KURL.cpp for this ports and
get rid of the very similar port specific implementation files.
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformWinCE.cmake:
- platform/KURL.cpp:
(WebCore):
(WebCore::KURL::fileSystemPath):
- platform/blackberry/KURLBlackBerry.cpp: Removed.
- platform/efl/KURLEfl.cpp: Removed.
- platform/wince/KURLWinCE.cpp: Removed.
- platform/wx/KURLWx.cpp: Removed.
- 3:09 PM Changeset in webkit [147882] by
-
- 2 edits in trunk/Source/WTF
[WinCE] Add workaround for UNUSED_PARAM()
https://bugs.webkit.org/show_bug.cgi?id=113440
Reviewed by Benjamin Poulain.
The MSVC compiler for Windwos CE throws an error when
an function parameter is passed to UNUSED_PARAM() and
its type is only forward declared.
- wtf/UnusedParam.h:
- 3:08 PM Changeset in webkit [147881] by
-
- 2 edits in trunk/Source/WTF
Do not check if WTF_ARM_ARCH_VERSION is defined in WTF_ARM_ARCH_AT_LEAST macro
https://bugs.webkit.org/show_bug.cgi?id=114127
Reviewed by Benjamin Poulain.
Platform.h defines WTF_ARM_ARCH_VERSION for CPU(ARM) always and removing
the check works around a bug in older Microsoft compiler versions.
- wtf/Platform.h:
- 2:28 PM Changeset in webkit [147880] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Marked another webaudio test as flaky.
- platform/efl/TestExpectations:
- 2:19 PM Changeset in webkit [147879] by
-
- 9 edits in trunk
Remove references to Skia and V8 from CMake files
https://bugs.webkit.org/show_bug.cgi?id=114130
Reviewed by Geoffrey Garen.
.:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/WebKitPackaging.cmake:
Source/JavaScriptCore:
- shell/PlatformBlackBerry.cmake:
Source/WebCore:
- PlatformBlackBerry.cmake:
Source/WebKit:
- PlatformBlackBerry.cmake:
- 1:56 PM Changeset in webkit [147878] by
-
- 21 edits in trunk
Remove the rest of SVG_DOM_OBJC_BINDINGS
<http://webkit.org/b/114112>
Reviewed by Geoffrey Garen.
.:
- Source/autotools/SetupWebKitFeatures.m4:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
- Remove references to ENABLE_SVG_DOM_OBJC_BINDINGS.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.
Source/WebCore:
- Configurations/WebCore.xcconfig:
- Remove EXCLUDED_SOURCE_FILE_NAMES_SVG_DOM_OBJC_BINDINGS. Note that DOMHTMLIFrameElementPrivate.h should not have been in this list because the class contained methods other than just -getSVGDocument.
- WebCore.xcodeproj/project.pbxproj:
- Remove DOMHTMLFrameElementPrivate.h since the only method it contained was -[DOMHTMLFrameElement getSVGDocument], which was part of the SVG DOM Objective-C bindings.
- bindings/objc/DOM.mm:
(kitClass):
- bindings/objc/DOMEvents.mm:
(kitClass):
- bindings/objc/ExceptionHandlers.mm:
(WebCore::raiseDOMException):
- Remove code in ENABLE(SVG_DOM_OBJC_BINDINGS).
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
- Remove reference to SVG_DOM_OBJC_BINDINGS.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.
Source/WTF:
- wtf/FeatureDefines.h:
- Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.
Tools:
- Scripts/webkitperl/FeatureList.pm:
- Remove --svg-dom-objc-bindings switch.
- qmake/mkspecs/features/features.pri:
- Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
- 1:27 PM Changeset in webkit [147877] by
-
- 8 edits in trunk/LayoutTests
Unreviewed gardening.
Rebaseline several test cases that have line number information after r147872.
- http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt:
- http/tests/security/window-onerror-exception-in-iframe-expected.txt:
- inspector/console/alert-toString-exception-expected.txt:
- storage/indexeddb/exception-in-event-aborts-expected.txt:
- storage/websql/sql-error-codes-expected.txt:
- storage/websql/statement-error-callback-expected.txt:
- storage/websql/transaction-callback-exception-crash-expected.txt:
- 1:02 PM Changeset in webkit [147876] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip a few test failing due to missing Quota API support.
- platform/efl/TestExpectations:
- 12:55 PM Changeset in webkit [147875] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark a few tests as crashing on EFL port.
- platform/efl/TestExpectations:
- 12:38 PM Changeset in webkit [147874] by
-
- 1 edit5 adds in trunk/LayoutTests
Unreviewed EFL gardening.
Generate missing baselines.
- platform/efl/editing/pasteboard/paste-text-004-expected.png: Added.
- platform/efl/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
- platform/efl/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
- platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
- platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
- 12:30 PM Changeset in webkit [147873] by
-
- 8 edits1 add in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline several test cases.
- platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/efl/fast/forms/datalist/input-list-expected.txt:
- platform/efl/fast/forms/search-display-none-cancel-button-expected.png:
- platform/efl/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/efl/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
- platform/efl/fast/js/global-constructors-expected.txt:
- platform/efl/http/tests/inspector/console-websocket-error-expected.txt:
- 11:47 AM Changeset in webkit [147872] by
-
- 17 edits in trunk
Inspector should display information about non-object exceptions
https://bugs.webkit.org/show_bug.cgi?id=114123
Reviewed by Adele Peterson.
Source/JavaScriptCore:
Make sure we store the right stack information, even when throwing
a primitive.
- interpreter/CallFrame.h:
(JSC::ExecState::clearSupplementaryExceptionInfo):
(ExecState):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::throwException):
Source/WebCore:
Make use of the stack trace for line information when we're reporting
an exception
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
LayoutTests:
All these tests throw primitives as exceptions, and now they have source
and line number information
- fast/dom/exception-getting-event-handler-expected.txt:
- fast/dom/javascript-url-exception-isolation-expected.txt:
- fast/dom/nested-script-exceptions-expected.txt:
- fast/events/onerror-no-constructor-expected.txt:
- fast/events/window-onerror13-expected.txt:
- fast/events/window-onerror16-expected.txt:
- fast/events/window-onerror2-expected.txt:
- fast/events/window-onerror8-expected.txt:
- fast/js/uncaught-exception-line-number-expected.txt:
- fast/sub-pixel/inline-block-with-padding-expected.txt:
- platform/mac/fast/AppleScript/001-expected.txt:
- 11:37 AM Changeset in webkit [147871] by
-
- 3 edits2 adds in trunk
table element may get larger when its contents are recreated
https://bugs.webkit.org/show_bug.cgi?id=111342
Reviewed by Darin Adler.
Source/WebCore:
Remove anonymous table section wrappers when destroying their children.
Test: fast/table/anonymous-table-section-removed.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
LayoutTests:
- fast/table/anonymous-table-section-removed-expected.txt: Added.
- fast/table/anonymous-table-section-removed.html: Added.
- 11:31 AM Changeset in webkit [147870] by
-
- 3 edits in trunk/Source/WebCore
[WIN] Fix build without precompiled header after r145827.
- platform/ContextMenuItem.h:
- platform/PlatformMenuDescription.h:
- 11:30 AM Changeset in webkit [147869] by
-
- 2 edits in trunk/Source/WebCore
Fix compilation of LocaleWin with !ENABLE(CALENDAR_PICKER) && !ENABLE(DATE_AND_TIME_INPUT_TYPES)
- platform/text/win/LocaleWin.cpp:
(WebCore::LocaleWin::ensureShortMonthLabels):
(WebCore):
(WebCore::LocaleWin::ensureMonthLabels):
- 10:07 AM Changeset in webkit [147868] by
-
- 3 edits in trunk/Source/WebCore
[WIN] Fix build without precompiled header after r144216.
- platform/network/cf/FormDataStreamCFNet.h:
- platform/network/mac/FormDataStreamMac.h:
- 9:42 AM Changeset in webkit [147867] by
-
- 8 edits in trunk
Source/WebCore: [EFL] --minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
https://bugs.webkit.org/show_bug.cgi?id=114089
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07
Reviewed by Chris Fleizach.
Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):
- editing/FrameSelection.h:
(WebCore):
Tools: [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
https://bugs.webkit.org/show_bug.cgi?id=114089
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07
Reviewed by Chris Fleizach.
Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
- DumpRenderTree/AccessibilityController.cpp:
- DumpRenderTree/AccessibilityUIElement.cpp:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::DumpRenderTreeChrome):
- DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
Apr 6, 2013:
- 8:52 PM Changeset in webkit [147866] by
-
- 4 edits in trunk/Tools
2013-04-06 Laszlo Gombos <Laszlo Gombos>
Build fix after r147857, remove remaining USE(JSC) guards.
Unreviewed.
- DumpRenderTree/config.h:
- TestWebKitAPI/config.h:
- WebKitTestRunner/config.h:
- 6:59 PM Changeset in webkit [147865] by
-
- 2 edits in trunk/Tools
Rename sheriffbot to webkitbot
https://bugs.webkit.org/show_bug.cgi?id=114109
Reviewed by Benjamin Poulain.
Renamed since sheriffbot will be used in Blink.
- Scripts/webkitpy/tool/commands/sheriffbot.py:
(SheriffBot):
(SheriffBot.begin_work_queue):
- 6:32 PM Changeset in webkit [147864] by
-
- 1 edit4 deletes in trunk/Source/WebCore
Get rid of skia
https://bugs.webkit.org/show_bug.cgi?id=114108
Reviewed by Anders Carlsson.
- platform/graphics/filters/skia/*: Removed.
- platform/graphics/skia/*: Removed.
- platform/image-decoders/skia/*: Removed.
- platform/image-encoders/skia/*: Removed.
- 6:31 PM Changeset in webkit [147863] by
-
- 4 edits in trunk/Source/WebCore
Remove the chromium code from platform/graphics/mac
https://bugs.webkit.org/show_bug.cgi?id=114107
Reviewed by Anders Carlsson.
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
- platform/graphics/mac/FontMac.mm:
(WebCore::hasBrokenCTFontGetVerticalTranslationsForGlyphs):
- 6:30 PM Changeset in webkit [147862] by
-
- 8 edits in trunk/Source/WebCore
Clean platform/graphics/cg of the chromium bits
https://bugs.webkit.org/show_bug.cgi?id=114106
Reviewed by Anders Carlsson.
- platform/graphics/cg/BitmapImageCG.cpp:
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::roundToDevicePixels):
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(GraphicsContextPlatformPrivate):
- platform/graphics/cg/ImageBufferCG.cpp:
- platform/graphics/cg/ImageCG.cpp:
- platform/graphics/cg/PathCG.cpp:
- platform/graphics/cg/PatternCG.cpp:
- 4:48 PM Changeset in webkit [147861] by
-
- 6 edits in trunk
Remove InjectedScriptHost.evaluateReturnsEvalFunction.
Source/WebCore:
- inspector/InjectedScriptHost.h:
(InjectedScriptHost):
- inspector/InjectedScriptHost.idl:
- inspector/InjectedScriptSource.js:
(InjectedScript.prototype._evaluateOn):
LayoutTests:
Reviewed by Joseph Pecoraro.
- inspector/console/command-line-api-expected.txt:
- 4:40 PM Keeping the Tree Green edited by
- (diff)
- 4:40 PM WebInspector edited by
- (diff)
- 4:39 PM PortIntegrationArchitectureIssues edited by
- (diff)
- 4:38 PM QtWebKitGardening edited by
- (diff)
- 4:38 PM JavaScriptCore edited by
- (diff)
- 4:38 PM NewRunWebKitTests edited by
- (diff)
- 4:37 PM HackingOnNewRunWebKitTests edited by
- (diff)
- 4:36 PM TestExpectations edited by
- (diff)
- 4:36 PM AddingFeatures edited by
- (diff)
- 4:36 PM WebKitIDL edited by
- (diff)
- 4:35 PM LayoutUnit edited by
- (diff)
- 4:29 PM WikiStart edited by
- (diff)
- 4:23 PM Changeset in webkit [147860] by
-
- 9 edits in trunk/Source/WebCore
Remove the chromium code from WebCore/platform/mac
https://bugs.webkit.org/show_bug.cgi?id=114104
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-06
Reviewed by Sam Weinig.
- platform/mac/NSScrollerImpDetails.h:
(WebCore::isScrollbarOverlayAPIAvailable):
- platform/mac/NSScrollerImpDetails.mm:
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate layer]):
(WebCore::scrollAnimationEnabledForSystem):
- platform/mac/ScrollElasticityController.mm:
(WebCore):
- platform/mac/ScrollbarThemeMac.h:
(ScrollbarThemeMac):
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeMac::paint):
(WebCore):
- platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::ensuredView):
- platform/mac/WebCoreNSCellExtras.h:
- 4:19 PM Changeset in webkit [147859] by
-
- 3 edits in trunk/Source/WebCore
Remove the Chromium code from Mac's FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=114103
Reviewed by Sam Weinig.
- platform/graphics/FontPlatformData.h:
(WebCore):
(FontPlatformData):
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::setFont):
(WebCore::FontPlatformData::ctFont):
- 3:47 PM Changeset in webkit [147858] by
-
- 15 edits in trunk
Unify the many and varied stack trace mechanisms, and make the result sane.
https://bugs.webkit.org/show_bug.cgi?id=114072
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Makes JSC::StackFrame record the bytecode offset and other necessary data
rather than requiring us to perform eager evaluation of the line number, etc.
Then remove most of the users of retrieveLastCaller, as most of them were
using it to create a stack trace in a fairly incomplete and inefficient way.
StackFrame now also has a couple of helpers to get the line and column info.
- API/JSContextRef.cpp:
(JSContextCreateBacktrace):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
- interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getBytecodeOffsetForCallFrame):
(JSC::getCallerInfo):
(JSC::StackFrame::line):
(JSC::StackFrame::column):
(JSC::StackFrame::expressionInfo):
(JSC::StackFrame::toString):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::retrieveCallerFromVMCode):
- interpreter/Interpreter.h:
(StackFrame):
(Interpreter):
- runtime/Error.cpp:
(JSC::throwError):
- runtime/JSGlobalData.h:
(JSC):
(JSGlobalData):
- runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
Source/WebCore:
Now that we've fleshed out the StackFrames from Interpreter::getStackTrace
WebCore can just ask us for a stack trace rather than implementing its own
stack walking.
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
- inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::isEqual):
- inspector/ScriptCallFrame.h:
(ScriptCallFrame):
(WebCore::ScriptCallFrame::columnNumber):
Tools:
The commandline jsc executable no longer requires arguments, so
I've made run-jsc work without them.
- Scripts/run-jsc:
- 3:42 PM Changeset in webkit [147857] by
-
- 108 edits in trunk/Source
Removed v8 bindings hooks from IDL files
https://bugs.webkit.org/show_bug.cgi?id=114091
Patch by Geoffrey Garen <ggaren@apple.com> on 2013-04-06
Reviewed by Anders Carlsson and Sam Weinig.
Source/JavaScriptCore:
- heap/HeapStatistics.h:
Source/WebCore:
- Modules/encryptedmedia/MediaKeySession.idl:
- Modules/filesystem/DOMWindowFileSystem.idl:
- Modules/filesystem/WorkerContextFileSystem.idl:
- Modules/gamepad/NavigatorGamepad.idl:
- Modules/geolocation/NavigatorGeolocation.idl:
- Modules/indexeddb/DOMWindowIndexedDatabase.idl:
- Modules/indexeddb/WorkerContextIndexedDatabase.idl:
- Modules/mediastream/DOMWindowMediaStream.idl:
- Modules/mediastream/NavigatorMediaStream.idl:
- Modules/notifications/DOMWindowNotifications.idl:
- Modules/notifications/NotificationCenter.idl:
- Modules/notifications/WorkerContextNotifications.idl:
- Modules/quota/DOMWindowQuota.idl:
- Modules/speech/DOMWindowSpeech.idl:
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/AudioParam.idl:
- Modules/webaudio/DOMWindowWebAudio.idl:
- Modules/webdatabase/DOMWindowWebDatabase.idl:
- Modules/webdatabase/WorkerContextWebDatabase.idl:
- Modules/websockets/DOMWindowWebSocket.idl:
- Modules/websockets/WorkerContextWebSocket.idl:
- bindings/js/JSDOMBinding.cpp:
- bindings/js/ScriptController.h:
(ScriptController):
- bindings/scripts/test/TestNode.idl:
- bindings/scripts/test/TestObj.idl:
- css/CSSFontFaceLoadEvent.idl:
- css/CSSHostRule.idl:
- css/CSSRule.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleSheet.idl:
- css/CSSValue.idl:
- css/FontLoader.idl:
- css/StyleSheet.idl:
- css/WebKitCSSRegionRule.idl:
- dom/Clipboard.idl:
- dom/CustomElementConstructor.idl:
- dom/CustomEvent.idl:
- dom/DOMNamedFlowCollection.idl:
- dom/DOMStringMap.idl:
- dom/DataTransferItemList.idl:
- dom/Document.idl:
- dom/DocumentFragment.idl:
- dom/Element.idl:
- dom/Event.idl:
- dom/EventTarget.idl:
- dom/MessageChannel.idl:
- dom/MouseEvent.idl:
- dom/MutationRecord.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/NodeList.idl:
- dom/RequestAnimationFrameCallback.idl:
- dom/ShadowRoot.idl:
- dom/Text.idl:
- history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTreeNode):
(WebCore::HistoryItem::decodeBackForwardTree):
- html/DOMSettableTokenList.idl:
- html/DOMTokenList.idl:
- html/HTMLAllCollection.idl:
- html/HTMLAppletElement.idl:
- html/HTMLCollection.idl:
- html/HTMLDialogElement.idl:
- html/HTMLDivElement.idl:
- html/HTMLDocument.idl:
- html/HTMLElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLFormControlsCollection.idl:
- html/HTMLFormElement.idl:
- html/HTMLImageElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLObjectElement.idl:
- html/HTMLOptionsCollection.idl:
- html/HTMLSelectElement.idl:
- html/HTMLSpanElement.idl:
- html/HTMLStyleElement.idl:
- html/HTMLTemplateElement.idl:
- html/HTMLTrackElement.idl:
- html/HTMLUnknownElement.idl:
- html/MediaKeyError.idl:
- html/MediaKeyEvent.idl:
- html/MicroDataItemValue.idl:
- html/canvas/CanvasRenderingContext2D.idl:
- html/canvas/DOMPath.idl:
- html/shadow/HTMLContentElement.idl:
- html/shadow/HTMLShadowElement.idl:
- html/track/TextTrack.idl:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):
(WebCore::InspectorIndexedDBAgent::clearObjectStore):
(WebCore):
- loader/EmptyClients.h:
(EmptyFrameLoaderClient):
- loader/FrameLoaderClient.h:
(FrameLoaderClient):
- page/Console.idl:
- page/DOMWindow.idl:
- page/DOMWindowPagePopup.idl:
- page/History.idl:
- page/Location.idl:
- platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):
- testing/Internals.cpp:
(WebCore::Internals::serializeObject):
(WebCore::Internals::deserializeBuffer):
Source/WTF:
- wtf/ArrayBuffer.h:
(WTF):
(WTF::ArrayBufferContents::ArrayBufferContents):
(WTF::ArrayBufferContents::transfer):
(ArrayBufferContents):
(ArrayBuffer):
(WTF::ArrayBufferContents::~ArrayBufferContents):
- wtf/Platform.h:
- 3:05 PM Changeset in webkit [147856] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows VS2010 build fix.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 2:38 PM Changeset in webkit [147855] by
-
- 20 edits in trunk/Source
Remove the USE(SKIA_ON_MAC_CHROMIUM) guards
https://bugs.webkit.org/show_bug.cgi?id=114084
Reviewed by Ryosuke Niwa.
Source/WebCore:
Remove the USE(SKIA_ON_MAC_CHROMIUM) guards. The guards were enabled only
for the Chromium port via the features.gypi file that was removed in r147714.
- platform/graphics/FloatPoint.h:
(FloatPoint):
- platform/graphics/FloatRect.h:
(FloatRect):
- platform/graphics/FloatSize.h:
(FloatSize):
- platform/graphics/FontPlatformData.cpp:
(WebCore):
- platform/graphics/FontPlatformData.h:
(FontPlatformData):
(WebCore::FontPlatformData::hash):
- platform/graphics/IntPoint.h:
(IntPoint):
- platform/graphics/IntRect.h:
(IntRect):
(WebCore):
- platform/graphics/IntSize.h:
(IntSize):
- platform/graphics/SimpleFontData.h:
(SimpleFontData):
(WebCore::SimpleFontData::widthForGlyph):
- platform/graphics/cg/FloatPointCG.cpp:
- platform/graphics/cg/FloatRectCG.cpp:
- platform/graphics/cg/FloatSizeCG.cpp:
- platform/graphics/cg/IntPointCG.cpp:
- platform/graphics/cg/IntRectCG.cpp:
- platform/graphics/cg/IntSizeCG.cpp:
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):
- platform/graphics/mac/FontCustomPlatformData.h:
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(FontCustomPlatformData):
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataUseFeatures.in: Remove the SKIA_ON_MAC_(CHROME|CHROMIUM) reference.
- 2:21 PM Changeset in webkit [147854] by
-
- 2 edits in trunk/Tools
[EFL] build fails with error: 'UINT_MAX' was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=114086
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-06
Reviewed by Tim Horton.
- DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
- 2:19 PM Changeset in webkit [147853] by
-
- 4 edits in trunk/Tools
Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=114083
Reviewed by Ryosuke Niwa.
Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
in TestWebKitAPI and WebKitTestRunner.
- TestWebKitAPI/config.h:
- TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
(TestWebKitAPI::InjectedBundleController::platformInitialize):
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):
- 2:18 PM Changeset in webkit [147852] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove the remaining PLATFORM(CHROMIUM) guard in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=114082
Reviewed by Ryosuke Niwa.
- runtime/JSExportMacros.h: Remove the remaining PLATFORM(CHROMIUM) guard.
- 1:04 PM Changeset in webkit [147851] by
-
- 2 edits in trunk/Source/JavaScriptCore
--minimal build fails with error: control reaches end of non-void function
https://bugs.webkit.org/show_bug.cgi?id=114085
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-06
Reviewed by Oliver Hunt.
- interpreter/Interpreter.cpp: return 0 if JIT is not enabled
(JSC::getBytecodeOffsetForCallFrame):
- 12:48 PM Changeset in webkit [147850] by
-
- 5 edits in trunk
REGRESSION(r142152): Text wraps in menu
https://bugs.webkit.org/show_bug.cgi?id=113706
Reviewed by David Hyatt.
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth): Empty inline elements add their inline border/padding/margin to the width of the
line when we iterate through them in nextLineBreak(), so no need to add them again here when climbing back up
from their first child looking for border/padding/margin to add. (An empty inline element can have floating children.)
LayoutTests:
- fast/inline/inline-with-empty-inline-children-expected.txt:
- fast/inline/inline-with-empty-inline-children.html:
- 12:17 PM Changeset in webkit [147849] by
-
- 2 edits in trunk/Source/JavaScriptCore
Try to fix the Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
Added back a symbol that is exported.
- 11:58 AM Changeset in webkit [147848] by
-
- 3 edits in trunk/Source/WebKit2
Try to fix the WebKit2 build.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit):
- NetworkProcess/NetworkResourceLoader.h:
(NetworkResourceLoader): Removed a defunct function.
- 11:54 AM Changeset in webkit [147847] by
-
- 2 edits in trunk/Source/JavaScriptCore
Try to fix the Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
Removed symbols that aren't exported.
- 11:24 AM Changeset in webkit [147846] by
-
- 14 edits in trunk
Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
https://bugs.webkit.org/show_bug.cgi?id=114094
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- API/JSContextRef.cpp:
(JSContextCreateBacktrace):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
- interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::retrieveCallerFromVMCode):
- interpreter/Interpreter.h:
(StackFrame):
(JSC::StackFrame::toString):
(JSC::StackFrame::friendlyLineNumber):
(Interpreter):
- runtime/Error.cpp:
(JSC::throwError):
- runtime/JSGlobalData.h:
(JSC):
(JSGlobalData):
- runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
Source/WebCore:
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
- inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::isEqual):
- inspector/ScriptCallFrame.h:
(ScriptCallFrame):
(WebCore::ScriptCallFrame::lineNumber):
Tools:
- Scripts/run-jsc:
- 11:24 AM Changeset in webkit [147845] by
-
- 2 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r145849.
- WebCoreSupport/EditorClientWinCE.cpp:
- 11:23 AM Changeset in webkit [147844] by
-
- 4 edits in trunk/Source/WebKit
[CMake] Remove general include directories from platform specific files
Move the include directories, which are required by all CMake ports
to the general CMakeLists.txt to fix the build for Windows CE port.
- CMakeLists.txt:
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- 11:15 AM Changeset in webkit [147843] by
-
- 8 edits2 deletes in trunk/Source/WebCore
Remove VisitedLinks.{cpp|h}
https://bugs.webkit.org/show_bug.cgi?id=114095
Reviewed by Geoffrey Garen.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/VisitedLinks.cpp: Removed.
- platform/VisitedLinks.h: Removed.
- 11:10 AM Changeset in webkit [147842] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix after r146932.
- profiler/ProfilerDatabase.cpp:
(Profiler):
- 11:07 AM Changeset in webkit [147841] by
-
- 3 edits in trunk/Source/WebCore
Another build fix.
Actually remove the right files from WebCore.vcxproj.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 11:03 AM Changeset in webkit [147840] by
-
- 3 edits in trunk/Source/WebCore
Fix build.
ThreadableLoaderClientWrapper was still calling didReceiveCachedMetadata; I didn't notice it
because the file was not in the Xcode project so I went ahead and added it.
- WebCore.xcodeproj/project.pbxproj:
- loader/ThreadableLoaderClientWrapper.h:
- 10:55 AM Changeset in webkit [147839] by
-
- 19 edits2 deletes in trunk/Source/WebCore
Remove dead CachedMetadata code
https://bugs.webkit.org/show_bug.cgi?id=114093
Reviewed by Geoffrey Garen.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- loader/CachedMetadata.cpp: Removed.
- loader/CachedMetadata.h: Removed.
- loader/ResourceLoader.h:
(ResourceLoader):
- loader/SubresourceLoader.cpp:
- loader/SubresourceLoader.h:
(SubresourceLoader):
- loader/ThreadableLoaderClient.h:
- loader/WorkerThreadableLoader.cpp:
- loader/WorkerThreadableLoader.h:
(MainThreadBridge):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
- loader/cache/CachedResource.h:
(WebCore):
(CachedResource):
- platform/network/ResourceHandle.cpp:
- platform/network/ResourceHandle.h:
(ResourceHandle):
- platform/network/ResourceHandleClient.h:
(ResourceHandleClient):
- 9:57 AM Changeset in webkit [147838] by
-
- 7 edits2 deletes in trunk/Source/WebCore
Remove more dead Chromium code
https://bugs.webkit.org/show_bug.cgi?id=114090
Reviewed by Alp Toker.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/StatsCounter.cpp: Removed.
- platform/StatsCounter.h: Removed.
- 3:06 AM Changeset in webkit [147837] by
-
- 2 edits in trunk/Source/WebCore
Build fix for WinCE after r143046.
- platform/graphics/wince/ImageWinCE.cpp:
(WebCore::Image::drawPattern):
- 2:54 AM Changeset in webkit [147836] by
-
- 2 edits in trunk/Source/JavaScriptCore
Do not call getenv() on Windows CE where it does not exist.
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- 2:31 AM Changeset in webkit [147835] by
-
- 2 edits in trunk/Source/WebCore
[WinCE] Do not call missing method createDragImageFromImage()
https://bugs.webkit.org/show_bug.cgi?id=110421
Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-04-06
- platform/win/ClipboardWin.cpp:
- 2:22 AM Changeset in webkit [147834] by
-
- 2 edits in trunk/Source/WebCore
[WinCE] Compile missing NetworkStorageSession methods
https://bugs.webkit.org/show_bug.cgi?id=110419
Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-04-05
- PlatformWinCE.cmake:
Apr 5, 2013:
- 11:27 PM Changeset in webkit [147833] by
-
- 2 edits in trunk/Tools
Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114080
Reviewed by Ryosuke Niwa.
This way, the WebKit and Blink dashboard code can change as appropriate without
needing to consider the other project's needs. This still doesn't update the
buildbots to upload to the new location, or the dashboard code to pull the
results.json files from the new location, but it at least allows for changing the
UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
- TestResultServer/app.yaml:
- 9:41 PM Changeset in webkit [147832] by
-
- 8 edits in trunk/Source/WebCore
Prefer prefix ++/-- operators for non-primitive types
https://bugs.webkit.org/show_bug.cgi?id=114033
Reviewed by Alexey Proskuryakov.
Post ++/-- creates a copy of current value and it is not necessary, so use prefix instead.
- bindings/js/Dictionary.cpp:
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
- dom/ContainerNode.cpp:
(WebCore::willRemoveChildren):
- dom/Range.cpp:
(WebCore::Range::processAncestorsAndTheirSiblings):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::detachChildren):
- platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
(WebCore):
(WebCore::LoopBlinnPathProcessor::subdivideCurvesSlow):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDocumentMarkers):
- xml/XPathFunctions.cpp:
(WebCore::XPath::Function::setArguments):
- 9:21 PM Changeset in webkit [147831] by
-
- 3 edits6 adds in trunk
[CSS Exclusions] Add support for the simple case of shape-margin polygonal shape-outside
https://bugs.webkit.org/show_bug.cgi?id=113726
Reviewed by Dirk Schulze.
Source/WebCore:
Add support for computing the shape-outside shape-margin boundary for a polygon.
This change is similar to the one added for padding polygons, see bug 112592.
The algorithm used for computing the margin boundary is is provisional. It works
correctly for convex polygons and will work correctly for non self-intersecting
polygons whose margin boundary is the same shape as the original polygon.
Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html
fast/exclusions/shape-outside-floats/shape-outside-floats-left-margin-polygon.html
fast/exclusions/shape-outside-floats/shape-outside-floats-right-margin-polygon.html
- rendering/ExclusionPolygon.cpp:
(WebCore::appendArc): Generalized this method a little, to deal with margin and padding connecting arcs.
(WebCore::computeShapePaddingBounds): Pass the new appendArc() parameter.
(WebCore::computeShapeMarginBounds): Compute the margin boundary for a polygon, per the constraints summarized above.
(WebCore::ExclusionPolygon::getExcludedIntervals): Use the margin polygon for this computation.
LayoutTests:
Verify that shape-outside layout works correctly on floats, when shape-margin is specifed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon-expected.txt: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-left-margin-polygon-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-left-margin-polygon.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-right-margin-polygon-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-right-margin-polygon.html: Added.
- 8:33 PM Changeset in webkit [147830] by
-
- 2 edits2 adds7 deletes in trunk/LayoutTests
Modernize fast/events/autoscroll.html
https://bugs.webkit.org/show_bug.cgi?id=112508
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-05
Reviewed by Jer Noble.
The test fast/events/autoscroll.html was introduced in
https://bugs.webkit.org/show_bug.cgi?id=12331 (r19102) to verify the page
does not scroll when the text is selected.
It seems reasonable to test the use case with a text dump instead of a pixel test.
This should reduces the maintenance needed to keep the test useful.
- fast/events/autoscroll.html: Removed.
- fast/events/no-scroll-on-input-text-selection-expected.txt: Added.
- fast/events/no-scroll-on-input-text-selection.html: Added.
- platform/efl/fast/events/autoscroll-expected.png: Removed.
- platform/efl/fast/events/autoscroll-expected.txt: Removed.
- platform/gtk/fast/events/autoscroll-expected.png: Removed.
- platform/gtk/fast/events/autoscroll-expected.txt: Removed.
- platform/mac-wk2/TestExpectations:
- platform/mac/fast/events/autoscroll-expected.png: Removed.
- platform/mac/fast/events/autoscroll-expected.txt: Removed.
- 8:09 PM Changeset in webkit [147829] by
-
- 9 edits4 adds in trunk
Returning NULL from willSendRequest should cancel a load from the memory cache
https://bugs.webkit.org/show_bug.cgi?id=114075
Reviewed by Darin Adler.
Source/WebCore:
When a resource is loaded from the memory cache and the client does not
implement the didLoadResourceFromMemoryCache delegate method, WebKit
synthesizes the typical sequence of resource load callbacks. One of
these is willSendRequest, which gives the client the opportunity to
modify the request. We should respect these modifications.
Handling any arbitrary modification is difficult given where in the
loading process we check the memory cache (see <http://webkit.org/b/113251>),
but we can handle the common case where the client cancels the load by
returning a NULL request.
Test: fast/loader/willsendrequest-returns-null-for-memory-cache-load.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::willLoadMediaElementURL): Passed request to sendRemainingDelegateMessages.
(WebCore::FrameLoader::commitProvisionalLoad): Ditto.
(WebCore::FrameLoader::loadResourceSynchronously): Ditto.
(WebCore::FrameLoader::loadedResourceFromMemoryCache): Added an out
parameter to pass back a request potentially modified by
requestFromDelegate, which is also passed to sendRemainingDelegateMessages.
- loader/FrameLoader.h:
- loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::dispatchDidFailLoading): Added a
function to dispatch didFailLoading and to call the correct InspectorInstrumentation.
(WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages): If the
request is NULL, call dispatchDidFailLoading and return. This matches
the delegate callback sequence of a non memory cache load that is
cancelled by willSendRequest.
- loader/ResourceLoadNotifier.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
Return false if the memory cache load is cancelled by the client.
(WebCore::CachedResourceLoader::requestResource): Return early if
shouldContinueAfterNotifyingLoadedFromMemoryCache is false.
LayoutTests:
- fast/loader/resources/cached-image.html: Added.
- fast/loader/willsendrequest-returns-null-for-memory-cache-load-expected.txt: Added.
- fast/loader/willsendrequest-returns-null-for-memory-cache-load.html: Added.
- platform/wk2/TestExpectations: Expect the test to fail in WKTR due to <http://webkit.org/b/114074>.
- 7:57 PM Changeset in webkit [147828] by
-
- 3 edits in trunk/Source/JavaScriptCore
Second attempt to fix the Windows bot
Unreviewed.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 7:40 PM Changeset in webkit [147827] by
-
- 3 edits in trunk/Source/JavaScriptCore
Attempt to fix the Windows bot
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-05
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
r147825 removed the symbol for nullptr_t. Add it back.
- 7:05 PM Changeset in webkit [147826] by
-
- 4 edits in trunk/Tools
Re-enable testing on the commit queue
https://bugs.webkit.org/show_bug.cgi?id=114078
Reviewed by Darin Adler.
Re-enabled the feature and the associated tests.
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTask.run):
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(CommitQueueTaskTest._run_through_task):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(CommitQueueTest._mock_test_result):
- 6:22 PM Changeset in webkit [147825] by
-
- 3 edits in trunk/Source/JavaScriptCore
Build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 6:08 PM Changeset in webkit [147824] by
-
- 4 edits1 copy1 add in trunk
AX: VoiceOver can't press on items
https://bugs.webkit.org/show_bug.cgi?id=114071
Reviewed by Tim Horton.
Source/WebCore:
The AXScrollToVisibleAction should not be used on earlier Mac versions because
it confuses VoiceOver.
Updated existing tests.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
LayoutTests:
- platform/mac-future/accessibility: Added.
- platform/mac-future/accessibility/press-action-is-first-expected.txt: Added.
- platform/mac/accessibility/press-action-is-first-expected.txt:
- 5:49 PM Changeset in webkit [147823] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] --no-tiled-backing-store build fails because FloatPoint is not declared
https://bugs.webkit.org/show_bug.cgi?id=113618
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-05
Reviewed by Simon Fraser.
- WebProcess/Plugins/Plugin.h: Forward declared FloatPoint
- 5:42 PM Changeset in webkit [147822] by
-
- 16 edits3 deletes in trunk/Source
Stop building Objective-C bindings for the SVG DOM
https://bugs.webkit.org/show_bug.cgi?id=114076
Reviewed by Geoffrey Garen.
The DOM SVG Objective-C bindings have never been exposed as API, and not building them cuts WebCore build by 10%.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- Configurations/WebCore.xcconfig:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm:
(WebCore::createElementClassMap):
(kitClass):
- bindings/objc/DOMCSS.mm:
(kitClass):
- bindings/objc/DOMEvents.mm:
- bindings/objc/DOMSVG.h: Removed.
- bindings/objc/DOMSVGException.h: Removed.
- bindings/objc/DOMSVGPathSegInternal.mm: Removed.
- bindings/objc/ExceptionHandlers.mm:
- html/HTMLEmbedElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLObjectElement.idl:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- MigrateHeaders.make:
- 5:10 PM Changeset in webkit [147821] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should better abstract arguments
https://bugs.webkit.org/show_bug.cgi?id=114073
Reviewed by Mark Hahnenberg.
- dfg/DFGGPRInfo.h:
(GPRInfo):
(JSC::DFG::GPRInfo::toArgumentRegister):
- 5:07 PM Changeset in webkit [147820] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix.
- 5:06 PM Changeset in webkit [147819] by
-
- 1 edit1 add7 deletes in trunk/LayoutTests
Change css1/basic/comments-expected.html to be a ref-test
https://bugs.webkit.org/show_bug.cgi?id=113996
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-05
Reviewed by Jer Noble.
The test css1/basic/comments.html verifies the handling
of comments inside a CSS declaration.
The test is changed to a ref-test by simply defining the style
directly on each element on the reference.
- css1/basic/comments-expected.html: Added.
- platform/efl/css1/basic/comments-expected.png: Removed.
- platform/efl/css1/basic/comments-expected.txt: Removed.
- platform/gtk/css1/basic/comments-expected.txt: Removed.
- platform/mac/css1/basic/comments-expected.png: Removed.
- platform/mac/css1/basic/comments-expected.txt: Removed.
- platform/qt/css1/basic/comments-expected.png: Removed.
- platform/qt/css1/basic/comments-expected.txt: Removed.
- 4:53 PM Changeset in webkit [147818] by
-
- 14 edits in trunk
Unify the many and varied stack trace mechanisms, and make the result sane.
https://bugs.webkit.org/show_bug.cgi?id=114072
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Makes JSC::StackFrame record the bytecode offset and other necessary data
rather than requiring us to perform eager evaluation of the line number, etc.
Then remove most of the users of retrieveLastCaller, as most of them were
using it to create a stack trace in a fairly incomplete and inefficient way.
StackFrame now also has a couple of helpers to get the line and column info.
- API/JSContextRef.cpp:
(JSContextCreateBacktrace):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
- interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getBytecodeOffsetForCallFrame):
(JSC::getCallerInfo):
(JSC::StackFrame::line):
(JSC::StackFrame::column):
(JSC::StackFrame::expressionInfo):
(JSC::StackFrame::toString):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::retrieveCallerFromVMCode):
- interpreter/Interpreter.h:
(StackFrame):
(Interpreter):
- runtime/Error.cpp:
(JSC::throwError):
- runtime/JSGlobalData.h:
(JSC):
(JSGlobalData):
- runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
Source/WebCore:
Now that we've fleshed out the StackFrames from Interpreter::getStackTrace
WebCore can just ask us for a stack trace rather than implementing its own
stack walking.
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
- inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::isEqual):
- inspector/ScriptCallFrame.h:
(ScriptCallFrame):
(WebCore::ScriptCallFrame::columnNumber):
Tools:
The commandline jsc executable no longer requires arguments, so
I've made run-jsc work without them.
- Scripts/run-jsc:
- 4:53 PM Changeset in webkit [147817] by
-
- 5 edits in branches/safari-534.59-branch/Source
Versioning.
- 4:52 PM WebKitGTK/2.0.x edited by
- (diff)
- 4:52 PM Changeset in webkit [147816] by
-
- 3 edits3 adds in trunk
tryCacheGetByID sets StructureStubInfo accessType to an incorrect value
https://bugs.webkit.org/show_bug.cgi?id=114068
Reviewed by Geoffrey Garen.
In the case where we have a non-Value cacheable property, we set the StructureStubInfo accessType to
get_by_id_self, but then we don't patch self and instead patch in a get_by_id_self_fail. This leads to
incorrect profiling data so when the DFG compiles the function, it uses a GetByOffset rather than a GetById,
which leads to loading a GetterSetter directly out of an object.
Source/JavaScriptCore:
- jit/JITStubs.cpp:
(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
LayoutTests:
- fast/js/jit-set-profiling-access-type-only-for-get-by-id-self-expected.txt: Added.
- fast/js/jit-set-profiling-access-type-only-for-get-by-id-self.html: Added.
- fast/js/script-tests/jit-set-profiling-access-type-only-for-get-by-id-self.js: Added.
- 4:51 PM Changeset in webkit [147815] by
-
- 1 copy in tags/Safari-534.59.8
New Tag.
- 4:50 PM Changeset in webkit [147814] by
-
- 1 edit1 add in trunk/Source/WebCore/platform/gtk/po
Translation of WebKitGTK+ for Malayalam (ml)
https://bugs.webkit.org/show_bug.cgi?id=113280
Patch by Ani Peter <peter.ani@gmail.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
- ml.po: Added.
- 4:47 PM WebKitGTK/2.0.x edited by
- (diff)
- 4:46 PM Changeset in webkit [147813] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 4:44 PM Changeset in webkit [147812] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
webkit translations for gujarati
https://bugs.webkit.org/show_bug.cgi?id=113190
Patch by Sweta Kothari <swkothar@redhat.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
- gu.po:
- 4:38 PM WebKitGTK/2.0.x edited by
- (diff)
- 4:35 PM Changeset in webkit [147811] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[l10n] [hi] Updated WebKit Translation in Hindi [hi] language
https://bugs.webkit.org/show_bug.cgi?id=113180
Patch by Rajesh Ranjan <rajeshkajha@yahoo.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
- hi.po:
- 4:30 PM Changeset in webkit [147810] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 4:28 PM Changeset in webkit [147809] by
-
- 4 edits in tags/Safari-536.29.12/Source
Versioning.
- 4:26 PM Changeset in webkit [147808] by
-
- 1 copy in tags/Safari-536.29.12
New Tag.
- 4:22 PM Changeset in webkit [147807] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] FatFingers Don't check the shadow tree for all elements.
https://bugs.webkit.org/show_bug.cgi?id=114066
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-05
Reviewed by Rob Buis.
BlackBerry PR 263078
Internally reviewed by Genevieve Mak.
No need to check shadow tree since sliders use touch events.
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
- 3:52 PM Changeset in webkit [147806] by
-
- 2 edits in trunk/Source/WebCore
Setting a header or footer should cause a relayout
https://bugs.webkit.org/show_bug.cgi?id=114070
Reviewed by Sam Weinig.
Mark the RenderView as needing layout in order to adjust everything for the new
header/footer.
- page/FrameView.cpp:
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):
- 3:09 PM Changeset in webkit [147805] by
-
- 10 edits in tags/Safari-537.36.1
Merged r147793. <rdar://problem/13588964>
- 3:07 PM Changeset in webkit [147804] by
-
- 4 edits in tags/Safari-537.36.1/Source
Versioning.
- 3:03 PM Changeset in webkit [147803] by
-
- 1 copy in tags/Safari-537.36.1
New Tag.
- 2:56 PM Changeset in webkit [147802] by
-
- 10 edits4 adds in trunk
AX: Make SVG Group containers accessible elements
https://bugs.webkit.org/show_bug.cgi?id=113939
Reviewed by Simon Fraser.
Source/WebCore:
SVG group containers are currently not exposed in the AX tree.
When an SVG element has a <title> child, that is not being used for the AX label.
When hit-testing, from Accessibility, SVG groups are never returned.
All these issues are fixed for Mac and iOS.
There are two tests because right now iOS skips all the top-level accessibility tests
due to fundamental architectural differences.
Tests: accessibility/svg-group-element-with-title.html
platform/iphone-simulator/accessibility/svg-group-element-with-title.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::accessibilityDescription):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper isSVGGroupElement]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
(-[WebAccessibilityObjectWrapper accessibilityClickPoint]):
- rendering/HitTestRequest.h:
Add a new option, AccessibilityHitTest, that will allow us to override normal behavior.
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::nodeAtFloatPoint):
Allow a SVG group to be the node at a point, for accessibility hit tests.
Tools:
Implement axController.elementAtPoint for iOS.
Implement a correct version of clickPoint for iOS.
- DumpRenderTree/ios/AccessibilityControllerIOS.mm:
(AccessibilityController::elementAtPoint):
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::clickPointX):
(AccessibilityUIElement::clickPointY):
LayoutTests:
- accessibility/svg-group-element-with-title-expected.txt: Added.
- accessibility/svg-group-element-with-title.html: Added.
- platform/iphone-simulator/accessibility/svg-group-element-with-title-expected.txt: Added.
- platform/iphone-simulator/accessibility/svg-group-element-with-title.html: Added.
- 2:54 PM Changeset in webkit [147801] by
-
- 3 edits2 adds in trunk
WebSpeech: event.elapsedTime is always 1364484608
https://bugs.webkit.org/show_bug.cgi?id=114045
Reviewed by Tim Horton.
Source/WebCore:
We were calculating elapsed time incorrectly.
Test: platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::fireEvent):
LayoutTests:
- platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time-expected.txt: Added.
- platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html: Added.
- 2:51 PM Changeset in webkit [147800] by
-
- 4 edits2 adds in trunk
WebSpeech: crash at WebCore::SpeechSynthesis::speak
https://bugs.webkit.org/show_bug.cgi?id=113937
Reviewed by Tim Horton.
Source/WebCore:
Protect against the case when invalid data is passed in.
Test: platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::speak):
- Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::setVoice):
LayoutTests:
- platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance-expected.txt: Added.
- platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html: Added.
- 2:47 PM Changeset in webkit [147799] by
-
- 2 edits in trunk/Source/WTF
[GTK] Change from PLATFORM(GTK) to USE(GLIB) in WTF/CurrentTime.cpp
https://bugs.webkit.org/show_bug.cgi?id=114061
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
Now other ports using GLib can use the correct implementation
and not the fallback one without adding any other PLATFORM guards
here.
- wtf/CurrentTime.cpp:
(WTF):
- 2:34 PM Changeset in webkit [147798] by
-
- 4 edits in trunk/Source/JavaScriptCore
If CallFrame::trueCallFrame() knows that it's about to read garbage instead of a valid CodeOrigin/InlineCallFrame, then it should give up and return 0 and all callers should be robust against this
https://bugs.webkit.org/show_bug.cgi?id=114062
Reviewed by Oliver Hunt.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::canGetCodeOrigin):
(CodeBlock):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallFrame):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::getStackTrace):
- 2:19 PM Changeset in webkit [147797] by
-
- 13 edits in trunk/Source/WebCore
Throttle compositing layer flushes during page loading
https://bugs.webkit.org/show_bug.cgi?id=113786
Reviewed by Simon Fraser.
Page content can change rapidly during page loading triggering excessive layer flushes and repainting. We should avoid this unnecessary work.
This patch reduces layer flushes (and painting) during loading by 50-70% on many popular pages.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadProgressingStatusChanged):
- loader/FrameLoader.h:
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::reset):
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::isLoadProgressing):
(WebCore::ProgressTracker::progressHeartbeatTimerFired):
- loader/ProgressTracker.h:
Track if the document load is progressing. This is done with a heartbeat timer that checks every 100ms if we have received more than 1k of data.
If four heartbeats pass without progress then we consider the load stalled.
- page/FrameView.cpp:
(WebCore::FrameView::resetDeferredRepaintDelay):
Disable throttling temporary on user interaction so the page stays as responsive as possible even during loading.
(WebCore::FrameView::updateLayerFlushThrottling):
Enable throttling when the load is progressing, disable otherwise.
- page/FrameView.h:
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::canThrottleLayerFlush):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
(WebCore::GraphicsLayerCA::canThrottleLayerFlush):
Don't throttle if new tiles have been added by the tile controller. They may have stale content and need to be flushed immediately.
(WebCore::GraphicsLayerCA::noteLayerPropertyChanged):
Set the new TilesAdded change flag.
- platform/graphics/ca/GraphicsLayerCA.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::notifyFlushRequired):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::notifyFlushRequired):
(WebCore::RenderLayerCompositor::scheduleLayerFlushNow):
Factor the actual flush scheduling to private function.
(WebCore::RenderLayerCompositor::scheduleLayerFlush):
Mark the compositor for flush and return without flushing if the flushes are currently being throttled.
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
After a flush, start the throtting timer (currently 0.5s) coalescing the subsequent flushes.
(WebCore::RenderLayerCompositor::didChangeVisibleRect):
Do immediately flush if needed.
(WebCore::RenderLayerCompositor::setLayerFlushThrottlingEnabled):
Flush immediately if disabled.
(WebCore::RenderLayerCompositor::disableLayerFlushThrottlingTemporarilyForInteraction):
(WebCore::RenderLayerCompositor::isThrottlingLayerFlushes):
(WebCore::RenderLayerCompositor::startLayerFlushTimerIfNeeded):
(WebCore::RenderLayerCompositor::layerFlushTimerFired):
Flush when the timer fires timer.
- rendering/RenderLayerCompositor.h:
- 1:52 PM Changeset in webkit [147796] by
-
- 23 edits in trunk/Source/WebCore
Clean the chromium bits of WebCore's WebDatabase
https://bugs.webkit.org/show_bug.cgi?id=114010
Reviewed by Ryosuke Niwa.
- Modules/webdatabase/AbstractDatabaseServer.h:
- Modules/webdatabase/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):
- Modules/webdatabase/Database.cpp:
- Modules/webdatabase/Database.h:
(Database):
- Modules/webdatabase/DatabaseBackend.cpp:
(WebCore::DatabaseBackend::openAndVerifyVersion):
- Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::getActualVersionForTransaction):
(WebCore::DatabaseBackendBase::incrementalVacuumIfNeeded):
- Modules/webdatabase/DatabaseBackendBase.h:
(DatabaseBackendBase):
- Modules/webdatabase/DatabaseBackendSync.cpp:
(WebCore::DatabaseBackendSync::openAndVerifyVersion):
- Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::databaseExceededQuota):
- Modules/webdatabase/DatabaseManager.cpp:
- Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
- Modules/webdatabase/DatabaseServer.cpp:
(WebCore::DatabaseServer::initialize):
(WebCore::DatabaseServer::setClient):
(WebCore::DatabaseServer::databaseDirectoryPath):
(WebCore::DatabaseServer::setDatabaseDirectoryPath):
(WebCore::DatabaseServer::openDatabase):
- Modules/webdatabase/DatabaseServer.h:
- Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::changeVersion):
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::retryCanEstablishDatabase):
- Modules/webdatabase/DatabaseTracker.h:
(WebCore):
(DatabaseTracker):
- Modules/webdatabase/SQLStatementBackend.cpp:
(WebCore::SQLStatementBackend::execute):
(WebCore::SQLStatementBackend::setDatabaseDeletedError):
(WebCore::SQLStatementBackend::setVersionMismatchedError):
(WebCore::SQLStatementBackend::setFailureDueToQuota):
- Modules/webdatabase/SQLStatementBackend.h:
(SQLStatementBackend):
- Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::deliverStatementCallback):
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::executeSQL):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState):
(WebCore::SQLTransactionBackend::nextStateForCurrentStatementError):
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::acquireOriginLock):
(WebCore::SQLTransactionBackend::releaseOriginLockIfNeeded):
- Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionBackend):
- Modules/webdatabase/SQLTransactionBackendSync.cpp:
(WebCore::SQLTransactionBackendSync::begin):
(WebCore::SQLTransactionBackendSync::commit):
- 1:44 PM Changeset in webkit [147795] by
-
- 43 edits in trunk/Source
Made USE(JSC) unconditional
https://bugs.webkit.org/show_bug.cgi?id=114058
Reviewed by Anders Carlsson.
- config.h:
../ThirdParty:
- gtest/include/gtest/internal/gtest-port.h:
../WebCore:
- Modules/webdatabase/Database.cpp:
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
- bindings/js/JavaScriptCallFrame.cpp:
- bindings/js/JavaScriptCallFrame.h:
- bindings/scripts/InFilesCompiler.pm:
(generateHeadersHeader):
- css/MediaQueryListListener.cpp:
(WebCore::MediaQueryListListener::queryChanged):
- dom/ContainerNode.cpp:
(WebCore::dispatchChildRemovalEvents):
- dom/EventListener.h:
(EventListener):
(WebCore::EventListener::visitJSFunction):
- dom/EventTarget.h:
(EventTarget):
(WebCore):
(WebCore::EventTarget::visitJSEventListeners):
- dom/Node.cpp:
- dom/Node.h:
- dom/ScriptExecutionContext.cpp:
(WebCore):
(WebCore::ScriptExecutionContext::globalData):
- dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
- html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::notifyFinished):
- inspector/InjectedScriptHost.h:
(InjectedScriptHost):
(WebCore::InjectedScriptHost::evaluateReturnsEvalFunction):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
- page/Frame.cpp:
- page/Settings.cpp:
(WebCore):
(WebCore::Settings::shouldRespectPriorityInCSSAttributeSetters):
- page/Settings.h:
(Settings):
- plugins/PluginView.cpp:
(WebCore::PluginView::start):
(WebCore::PluginView::stop):
(WebCore::PluginView::performRequest):
(WebCore::PluginView::npObject):
(WebCore):
(WebCore::PluginView::bindingInstance):
(WebCore::PluginView::privateBrowsingStateChanged):
- plugins/PluginView.h:
(PluginView):
- plugins/PluginViewBase.h:
(PluginViewBase):
(WebCore::PluginViewBase::scriptObject):
- plugins/PluginViewNone.cpp:
(WebCore):
(WebCore::PluginView::bindingInstance):
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::setNPWindowIfNeeded):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::dropProtection):
../WebKit/efl:
- ewk/ewk_frame.cpp:
(ewk_frame_script_execute):
../WebKit/qt:
- Api/qwebscriptworld.cpp:
(QWebScriptWorld::QWebScriptWorld):
../WebKit2:
- Shared/linux/WebMemorySamplerLinux.cpp:
(WebKit::WebMemorySampler::sampleWebKit):
- config.h:
../WTF:
- wtf/ThreadRestrictionVerifier.h:
(WTF):
- wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):
- wtf/WTFThreadData.h:
(WTFThreadData):
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl):
- 1:41 PM Changeset in webkit [147794] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out http://trac.webkit.org/changeset/147729
It's causing a bunch of breakage on some more strict compilers:
<inline asm>:1267:2: error: ambiguous instructions require an explicit suffix (could be 'ficomps', or 'ficompl')
- offlineasm/x86.rb:
- 1:38 PM Changeset in webkit [147793] by
-
- 10 edits in trunk
Unreviewed. More VS2010 solution makefile fixes.
<rdar://problem/13588964>
- WTF.vcxproj/WTF.make:
- JavaScriptCore.vcxproj/JavaScriptCore.make:
- WebCore.vcxproj/WebCore.make:
- WebKit.vcxproj/WebKit.make:
- win/tools/WinTools.make:
- 1:29 PM Changeset in webkit [147792] by
-
- 23 edits in trunk
[EFL] --no-tiled-backing-store build fails because of not used #if USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=113627
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-05
Reviewed by Simon Fraser.
.:
- Source/cmake/OptionsEfl.cmake: Disabled 3D_GRAPHICS and WEB_GL when accelerated compositing is on
Source/WebCore:
Wrapped code with #if USE(ACCELERATED_COMPOSITING) to make it compilable
with --no-tiled-backing-store build option:
- page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::animate):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
- platform/graphics/TextTrackRepresentation.cpp:
(NullTextTrackRepresentation):
- platform/graphics/TextTrackRepresentation.h:
(TextTrackRepresentation):
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setHeaderHeight):
(WebCore::Internals::setFooterHeight):
Source/WebKit2:
Wrapped code with #if USE(ACCELERATED_COMPOSITING) to make it compilable
with --no-tiled-backing-store build option:
- UIProcess/API/C/efl/WKView.cpp:
- UIProcess/API/efl/EvasGLContext.cpp:
- UIProcess/API/efl/EvasGLContext.h:
- UIProcess/API/efl/EvasGLSurface.cpp:
- UIProcess/API/efl/EvasGLSurface.h:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::displayTimerFired):
(EwkView::takeSnapshot):
- UIProcess/API/efl/EwkView.h:
(WebKit):
(EwkView):
- UIProcess/API/efl/SnapshotImageGL.cpp:
- UIProcess/API/efl/SnapshotImageGL.h:
- UIProcess/PageViewportController.cpp:
- UIProcess/PageViewportController.h:
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeContentsSize):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::didCommitLoad):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::didChangeViewportProperties):
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):
- 1:04 PM Changeset in webkit [147791] by
-
- 4 edits in trunk/Tools
Unreviewed, rolling out r147773 and r147774.
http://trac.webkit.org/changeset/147773
http://trac.webkit.org/changeset/147774
https://bugs.webkit.org/show_bug.cgi?id=114056
Causing some exceptions on AppEngine I don't understand
(Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-05
- QueueStatusServer/config/queues.py:
- QueueStatusServer/model/queues.py:
(Queue.short_name):
(Queue.display_name):
- QueueStatusServer/model/queues_unittest.py:
(QueueTest.test_short_name):
(QueueTest.test_display_name):
(QueueTest.test_name_with_underscores):
- 12:55 PM Changeset in webkit [147790] by
-
- 1 edit5 deletes in trunk/Source/WebCore
Remove the remaining Chromium files from WebCore
https://bugs.webkit.org/show_bug.cgi?id=114055
Reviewed by Benjamin Poulain.
Removed.
- Resources/pagepopups/chromium: Removed.
- Resources/pagepopups/chromium/calendarPickerChromium.css: Removed.
- Resources/pagepopups/chromium/pickerCommonChromium.css: Removed.
- html/shadow/MediaControlsChromium.cpp: Removed.
- html/shadow/MediaControlsChromium.h: Removed.
- html/shadow/MediaControlsChromiumAndroid.cpp: Removed.
- html/shadow/MediaControlsChromiumAndroid.h: Removed.
- 12:49 PM Changeset in webkit [147789] by
-
- 2 edits in trunk/Tools
Fixed run-bindings-tests by removing V8
https://bugs.webkit.org/show_bug.cgi?id=114053
Reviewed by Benjamin Poulain.
- Scripts/run-bindings-tests:
(main):
- 12:48 PM Changeset in webkit [147788] by
-
- 1 edit6 deletes in trunk/Source/WebCore
Remove Chromium code from WebCore/css
https://bugs.webkit.org/show_bug.cgi?id=114052
Reviewed by Benjamin Poulain.
Removed.
- css/mediaControlsChromium.css: Removed.
- css/mediaControlsChromiumAndroid.css: Removed.
- css/themeChromium.css: Removed.
- css/themeChromiumAndroid.css: Removed.
- css/themeChromiumLinux.css: Removed.
- css/themeChromiumSkia.css: Removed.
- 12:45 PM Changeset in webkit [147787] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Segfault when attempting to install missing plugins
https://bugs.webkit.org/show_bug.cgi?id=114046
gst_install_plugins_async expects a null terminated list, but we weren't
adding a null terminator.
Patch by Brendan Long <self@brendanlong.com> on 2013-04-05
Reviewed by Philippe Normand.
No new tests since this just fixes a segfault.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
- 12:40 PM Changeset in webkit [147786] by
-
- 5 edits in trunk/Source/WebCore
Remove the chromium code for WebCore's indexeddb module
https://bugs.webkit.org/show_bug.cgi?id=114004
Reviewed by Ryosuke Niwa.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::close):
- Modules/indexeddb/IDBFactoryBackendInterface.cpp:
- Modules/indexeddb/IDBTracing.h:
- 12:36 PM Changeset in webkit [147785] by
-
- 1 delete in trunk/Source/WebKit/qt/v8
Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.
- 12:36 PM Changeset in webkit [147784] by
-
- 1 delete in trunk/Source/WebCore/bridge/jni/v8
Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.
- 12:34 PM Changeset in webkit [147783] by
-
- 1 delete in trunk/Source/WebCore/UseV8.cmake
Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.
- 12:34 PM Changeset in webkit [147782] by
-
- 1 delete in trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.
- 12:34 PM Changeset in webkit [147781] by
-
- 1 delete in trunk/Source/WebCore/testing/v8
Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.
- 12:34 PM Changeset in webkit [147780] by
-
- 1 delete in trunk/Source/WebCore/bindings/scripts/test/V8
Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.
- 12:33 PM Changeset in webkit [147779] by
-
- 1 delete in trunk/Source/WebCore/bindings/v8
Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.
- 12:30 PM Changeset in webkit [147778] by
-
- 1 edit4 deletes in trunk/Source/WebCore
Cleanup after git svn left empty directories.
- loader/chromium: Removed.
- page/chromium: Removed.
- page/scrolling/chromium: Removed.
- plugins/chromium: Removed.
- 12:27 PM Changeset in webkit [147777] by
-
- 1 edit1 delete in trunk/Source/WebCore
Actually delete platform/chromium.
- platform/chromium: Removed.
- 12:27 PM Changeset in webkit [147776] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] --no-tiled-backing-store build fails because of not used #if USE(COORDINATED_GRAPHICS)
https://bugs.webkit.org/show_bug.cgi?id=113629
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-05
Reviewed by Simon Fraser.
Wrapped code related to coordinated graphics with #if USE(COORDINATED_GRAPHICS)
- UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::initialize):
(WebKit):
(WebKit::WebView::paintToCairoSurface):
(WebKit::WebView::updateViewportSize):
- 12:24 PM Changeset in webkit [147775] by
-
- 4 edits6 deletes in trunk/Source/WebCore
Remove Chromium code from WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=114014
Reviewed by Anders Carlsson.
Removed.
- platform/audio/chromium: Removed.
- platform/audio/chromium/AudioBusChromium.cpp: Removed.
- platform/audio/chromium/AudioDestinationChromium.cpp: Removed.
- platform/audio/chromium/AudioDestinationChromium.h: Removed.
- platform/audio/chromium/FFTFrameOpenMAXDLAndroid.cpp: Removed.
- platform/graphics/FontPlatformData.h:
- platform/graphics/chromium: Removed.
- platform/graphics/chromium/AnimationTranslationUtil.cpp: Removed.
- platform/graphics/chromium/AnimationTranslationUtil.h: Removed.
- platform/graphics/chromium/Canvas2DLayerBridge.cpp: Removed.
- platform/graphics/chromium/Canvas2DLayerBridge.h: Removed.
- platform/graphics/chromium/Canvas2DLayerManager.cpp: Removed.
- platform/graphics/chromium/Canvas2DLayerManager.h: Removed.
- platform/graphics/chromium/CrossProcessFontLoading.h: Removed.
- platform/graphics/chromium/CrossProcessFontLoading.mm: Removed.
- platform/graphics/chromium/DeferredImageDecoder.cpp: Removed.
- platform/graphics/chromium/DeferredImageDecoder.h: Removed.
- platform/graphics/chromium/DiscardablePixelRef.cpp: Removed.
- platform/graphics/chromium/DiscardablePixelRef.h: Removed.
- platform/graphics/chromium/DrawingBufferChromium.cpp: Removed.
- platform/graphics/chromium/Extensions3DChromium.h: Removed.
- platform/graphics/chromium/FontCacheAndroid.cpp: Removed.
- platform/graphics/chromium/FontCacheChromiumLinux.cpp: Removed.
- platform/graphics/chromium/FontCacheChromiumWin.cpp: Removed.
- platform/graphics/chromium/FontChromiumWin.cpp: Removed.
- platform/graphics/chromium/FontPlatformData.h: Removed.
- platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: Removed.
- platform/graphics/chromium/FontPlatformDataChromiumWin.h: Removed.
- platform/graphics/chromium/FontRenderStyle.h: Removed.
- platform/graphics/chromium/FontUtilsChromiumWin.cpp: Removed.
- platform/graphics/chromium/FontUtilsChromiumWin.h: Removed.
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: Removed.
- platform/graphics/chromium/GraphicsLayerChromium.cpp: Removed.
- platform/graphics/chromium/GraphicsLayerChromium.h: Removed.
- platform/graphics/chromium/IconChromium.cpp: Removed.
- platform/graphics/chromium/IconChromiumAndroid.cpp: Removed.
- platform/graphics/chromium/ImageBufferDataSkia.h: Removed.
- platform/graphics/chromium/ImageChromium.cpp: Removed.
- platform/graphics/chromium/ImageDecodingStore.cpp: Removed.
- platform/graphics/chromium/ImageDecodingStore.h: Removed.
- platform/graphics/chromium/ImageFrameGenerator.cpp: Removed.
- platform/graphics/chromium/ImageFrameGenerator.h: Removed.
- platform/graphics/chromium/LayerPainterChromium.h: Removed.
- platform/graphics/chromium/LazyDecodingPixelRef.cpp: Removed.
- platform/graphics/chromium/LazyDecodingPixelRef.h: Removed.
- platform/graphics/chromium/MediaPlayerPrivateChromium.cpp: Removed.
- platform/graphics/chromium/MediaPlayerPrivateChromium.h: Removed.
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp: Removed.
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h: Removed.
- platform/graphics/chromium/PlatformIcon.h: Removed.
- platform/graphics/chromium/ScaledImageFragment.cpp: Removed.
- platform/graphics/chromium/ScaledImageFragment.h: Removed.
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Removed.
- platform/graphics/chromium/SkSizeHash.h: Removed.
- platform/graphics/chromium/TextureUploader.h: Removed.
- platform/graphics/chromium/ThreadSafeDataTransport.cpp: Removed.
- platform/graphics/chromium/ThreadSafeDataTransport.h: Removed.
- platform/graphics/chromium/TransformSkMatrix44Conversions.cpp: Removed.
- platform/graphics/chromium/TransformSkMatrix44Conversions.h: Removed.
- platform/graphics/chromium/TransparencyWin.cpp: Removed.
- platform/graphics/chromium/TransparencyWin.h: Removed.
- platform/graphics/chromium/UniscribeHelper.cpp: Removed.
- platform/graphics/chromium/UniscribeHelper.h: Removed.
- platform/graphics/chromium/UniscribeHelperTextRun.cpp: Removed.
- platform/graphics/chromium/UniscribeHelperTextRun.h: Removed.
- platform/graphics/chromium/VDMXParser.cpp: Removed.
- platform/graphics/chromium/VDMXParser.h: Removed.
- platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore):
- platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3DImpl::getOrCreateContext):
- platform/mediastream/chromium: Removed.
- platform/mediastream/chromium/MediaStreamCenterChromium.cpp: Removed.
- platform/mediastream/chromium/MediaStreamCenterChromium.h: Removed.
- platform/mediastream/chromium/RTCDTMFSenderHandlerChromium.cpp: Removed.
- platform/mediastream/chromium/RTCDTMFSenderHandlerChromium.h: Removed.
- platform/mediastream/chromium/RTCDataChannelHandlerChromium.cpp: Removed.
- platform/mediastream/chromium/RTCDataChannelHandlerChromium.h: Removed.
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp: Removed.
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h: Removed.
- platform/network/chromium: Removed.
- platform/network/chromium/AuthenticationChallenge.h: Removed.
- platform/network/chromium/AuthenticationChallengeChromium.cpp: Removed.
- platform/network/chromium/BlobRegistryProxy.cpp: Removed.
- platform/network/chromium/BlobRegistryProxy.h: Removed.
- platform/network/chromium/CookieJarChromium.cpp: Removed.
- platform/network/chromium/DNSChromium.cpp: Removed.
- platform/network/chromium/ResourceError.h: Removed.
- platform/network/chromium/ResourceHandle.cpp: Removed.
- platform/network/chromium/ResourceHandleInternal.h: Removed.
- platform/network/chromium/ResourceRequest.cpp: Removed.
- platform/network/chromium/ResourceRequest.h: Removed.
- platform/network/chromium/ResourceResponse.cpp: Removed.
- platform/network/chromium/ResourceResponse.h: Removed.
- platform/network/chromium/SocketStreamError.h: Removed.
- platform/network/chromium/SocketStreamHandle.cpp: Removed.
- platform/network/chromium/SocketStreamHandle.h: Removed.
- platform/network/chromium/SocketStreamHandleInternal.h: Removed.
- platform/sql/chromium: Removed.
- platform/sql/chromium/SQLiteFileSystemChromium.cpp: Removed.
- platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: Removed.
- platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: Removed.
- platform/text/chromium: Removed.
- platform/text/chromium/Hyphenation.cpp: Removed.
- platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: Removed.
- 12:17 PM Changeset in webkit [147774] by
-
- 2 edits in trunk/Tools
Build fix.
- QueueStatusServer/model/queues.py:
(Queue.short_name):
(Queue.display_name):
- 12:08 PM Changeset in webkit [147773] by
-
- 4 edits in trunk/Tools
Remove Chromium EWS bots from the queue status server
https://bugs.webkit.org/show_bug.cgi?id=113988
Reviewed by Benjamin Poulain.
Removed Chromium EWS bots.
- QueueStatusServer/config/queues.py:
- QueueStatusServer/model/queues.py:
(Queue.short_name):
(Queue.display_name):
- QueueStatusServer/model/queues_unittest.py:
(QueueTest.test_short_name):
(QueueTest.test_display_name):
(QueueTest.test_name_with_underscores):
- 11:57 AM Changeset in webkit [147772] by
-
- 2 edits1 delete in trunk/Source/WebCore
Remove Chromium code from WebCore/workers
https://bugs.webkit.org/show_bug.cgi?id=114050
Reviewed by Anders Carlsson.
Removed.
- workers/WorkerLoaderProxy.h:
(WorkerLoaderProxy):
- workers/chromium: Removed.
- 11:54 AM Changeset in webkit [147771] by
-
- 2 edits1 delete in trunk/Source/WebCore
Remove Chromium code from WebCore/storage
https://bugs.webkit.org/show_bug.cgi?id=114049
Reviewed by Anders Carlsson.
Removed.
- storage/StorageNamespace.cpp:
- storage/chromium: Removed.
- 11:48 AM Changeset in webkit [147770] by
-
- 2 edits in tags/Safari-537.35.9/Source/WebCore
Merged r147664. <rdar://problem/13579024>
- 11:42 AM Changeset in webkit [147769] by
-
- 2 edits in trunk/Source/WebCore
[SOUP] Remove unnecessary explicit keyword in SocketStreamError.h
https://bugs.webkit.org/show_bug.cgi?id=113913
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-05
Reviewed by Martin Robinson.
No new tests, just removing an unnecessary code.
- platform/network/soup/SocketStreamError.h:
(WebCore::SocketStreamError::SocketStreamError):
- 11:39 AM Changeset in webkit [147768] by
-
- 7 edits in trunk
[EFL] Enable indexed database
https://bugs.webkit.org/show_bug.cgi?id=107248
Patch by Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> on 2013-04-05
Reviewed by Alexis Menard.
.:
- Source/cmake/OptionsEfl.cmake:
Tools:
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 11:35 AM Changeset in webkit [147767] by
-
- 2 edits in trunk/Tools
Remove vestiges of Chromium bits from watchlists.
https://bugs.webkit.org/show_bug.cgi?id=114047
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/config/watchlist: Removed vestiges.
- 11:18 AM Changeset in webkit [147766] by
-
- 6 edits2 deletes in trunk/Source
Remove WTF_USE_GOOGLEURL-guarded code
https://bugs.webkit.org/show_bug.cgi?id=114028
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-04-05
Reviewed by Ryosuke Niwa.
Source/WebCore:
The only remaining usage of the USE(GOOGLEURL) guards is in LinkHashChromium.cpp that will
get removed when purging the Source/WebCore/platform/chromium directory.
- config.h: Remove the define that was Chromium-specific.
- platform/KURL.cpp:
(WebCore):
(WebCore::KURL::reportMemoryUsage):
(WebCore::KURL::isSafeToSendToAnotherThread):
- platform/KURL.h:
(KURL):
- platform/KURLGoogle.cpp: Removed.
- platform/KURLGooglePrivate.h: Removed.
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataUseFeatures.in: Remove GOOGLEURL from the list.
- 11:13 AM Changeset in webkit [147765] by
-
- 3 edits2 adds in trunk
[regression] Security: Heap-use-after-free in WebCore::RenderBlock::logicalRightOffsetForLine
https://bugs.webkit.org/show_bug.cgi?id=111594
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-04-05
Reviewed by David Hyatt.
Source/WebCore:
Swapping the bases was causing any floats in the right base to be
lost, so change the code so that it no longer swaps the bases.
Test: fast/ruby/float-object-doesnt-crash.html
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::removeChild): Don't swap the bases anymore.
LayoutTests:
Add test to verify that the use-after-free is fixed. Note that it will
only crash when run under a memory checking tool like ASAN.
- fast/ruby/float-object-doesnt-crash-expected.txt: Added.
- fast/ruby/float-object-doesnt-crash.html: Added.
- 11:03 AM Changeset in webkit [147764] by
-
- 4 edits in tags/Safari-537.35.9/Source
Versioning.
- 10:56 AM Changeset in webkit [147763] by
-
- 1 copy in tags/Safari-537.35.9
New Tag.
- 10:54 AM Changeset in webkit [147762] by
-
- 2 edits in trunk/Source/WebCore
Remove dead code
https://bugs.webkit.org/show_bug.cgi?id=114043
Reviewed by Beth Dakin.
- platform/PublicSuffix.h:
- 10:48 AM Changeset in webkit [147761] by
-
- 7 edits2 deletes in trunk/Source/WebCore
Remove dead Chromium code from WebCore/workers
https://bugs.webkit.org/show_bug.cgi?id=114039
Reviewed by Antti Koivisto.
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::importScripts):
- workers/WorkerLoaderProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerContextProxy::create):
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::WorkerScriptLoader):
(WebCore::WorkerScriptLoader::createResourceRequest):
- workers/WorkerScriptLoader.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
- workers/chromium/WorkerContextProxyChromium.cpp: Removed.
- workers/chromium/WorkerContextProxyChromium.h: Removed.
- 10:44 AM Changeset in webkit [147760] by
-
- 1 edit4 deletes in trunk/Source/WebCore
Remove Chromium code from WebCore/plugins
https://bugs.webkit.org/show_bug.cgi?id=114015
Reviewed by Andreas Kling.
Removed.
- plugins/chromium: Removed.
- plugins/chromium/PluginDataChromium.cpp: Removed.
- plugins/chromium/PluginDataChromium.h: Removed.
- plugins/chromium/PluginListBuilder.cpp: Removed.
- plugins/chromium/PluginListBuilder.h: Removed.
- 10:36 AM Changeset in webkit [147759] by
-
- 3 edits in trunk/Source/WebCore
ASSERTION FAILED: m_repaintRect == renderer()->clippedOverflowRectForRepaint(renderer()->containerForRepaint()) after r135816
https://bugs.webkit.org/show_bug.cgi?id=103432
Reviewed by Allan Sandfeld Jensen.
Remove optimization added in r99752 that attempted to avoid clip rect
updates for table cells. As the assertions show, this optimization
is not always correct, so remove it. Bug 108272 tracks adding it back in.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Remove m_canSkipRepaintRectsUpdateOnScroll
check when updating clip rects.
- rendering/RenderLayer.h: Remove the m_canSkipRepaintRectsUpdateOnScroll bit.
- 10:30 AM Changeset in webkit [147758] by
-
- 12 edits in trunk
[css exclusions] Dynamically removing shape-inside should cause relayout of child blocks' inline content
https://bugs.webkit.org/show_bug.cgi?id=111029
Reviewed by David Hyatt.
Source/WebCore:
Preserve a removed ExclusionShapeInsideInfo for one additional layout pass
so that it can notify descendant inline content to relayout. This patch adds
a new 'needsRemoval' boolean to ExclusionShapeInsideInfo, which is set when
a style change removes but does not replace a shape-inside. When determining
whether a block needs to relayout inline children, ExclusionShapeInsideInfos with
the needsRemoval boolean set are included, but at other times (such as during
inline layout), they are ignored.
Added tests to the existing dynamic shape testfile
fast/exclusions/shape-inside/shape-inside-dynamic-nested.html
- rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::setNeedsRemoval): Get/Set the
needsRemoval boolean.
(WebCore::ExclusionShapeInsideInfo::needsRemoval): Ditto.
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo):
Initialize the needsRemoval boolean.
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState): Propagate removed shape insides
for layout correctly. You only need to track one at a time, and a
removed shape inside should not take precedence over a set shape-inside.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange):
Set the ExclusionShapeInsideInfo needsRemoval boolean, rather than immediately
removing the info.
(WebCore::exclusionInfoRequiresRelayout): Account for the needsRemoval
boolean as another way of requiring relayout.
(WebCore::RenderBlock::updateRegionsAndExclusionsBeforeChildLayout):
Look up whether an ExclusionShapeInsideInfo has been removed.
(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout):
Remove any ExclusionShapeInsides marked for removal after a layout pass.
(WebCore):
(WebCore::RenderBlock::layoutBlock): Call the new updateRegionsAndExclusions
Before/After methods.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::exclusionShapeInsideInfo): Filter the result based
on whether it should include removed infos.
(RenderBlock):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Ditto.
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
Same as RenderBlock::layoutBlock.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Ditto.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock): Ditto.
LayoutTests:
Test that removed shape-insides correctly cause relayout in their blocks'
inline content.
- fast/exclusions/shape-inside/shape-inside-dynamic-nested-expected.html:
- fast/exclusions/shape-inside/shape-inside-dynamic-nested.html:
- 10:28 AM Changeset in webkit [147757] by
-
- 2 edits in trunk/Tools
Add James Craig to the contributors list.
- Scripts/webkitpy/common/config/committers.py:
- 10:15 AM Changeset in webkit [147756] by
-
- 15 edits6 adds in trunk
[CSS Regions] Elements in a region should be assignable to a named flow
https://bugs.webkit.org/show_bug.cgi?id=74144
Patch by Mihai Maerean <Mihai Maerean> on 2013-04-05
Reviewed by David Hyatt.
Source/WebCore:
DOM children of a region must not be rendered as children of the region, but can be collected in flow threads.
NodeRenderingContext::parentRenderer now creates the parent render flow thread if it doesn't exist.
Element::moveToFlowThreadIsNeeded is a virtual method that is overriden in PseudoElement to return false and
in SVGElement so only svg root elements can directly be collected by a render flow thread.
RenderObject::canDOMChildrenHaveRenderParent exists to optimize the code so nodes inside regions (and maybe
other types of renderers in the future) can still have renderers if they need to be in a flow thread while the
rest of renderers that can't have children skip the new instructions.
Tests: fast/regions/flow-body-in-html.html . To test the duplicate bug #103685.
fast/regions/region-content-flown-into-region.html
fast/regions/universal-selector-children-to-the-same-region.html . To test the duplicate bug #103685.
- dom/Element.cpp:
(WebCore::Element::moveToFlowThreadIsNeeded):
- dom/Element.h:
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::parentRenderer): the renderer that will be the parent for this node's renderer.
In the case of RenderFlowThreads, it may need to create it.
(WebCore::NodeRenderingContext::shouldCreateRenderer): In a region, only the children that need to be in a flow
thread should have a renderer.
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRenderingContext::moveToFlowThread):
- dom/NodeRenderingContext.h:
(NodeRenderingContext):
- dom/PseudoElement.h: pseudo-elements cannot be directly collected into a named flow.
- dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
(WebCore::Text::updateTextRenderer): Because calling textRendererIsNeeded(NodeRenderingContext(...)) on a
non-const l-value NodeRenderingContext cannot be done on a temporary object on the stack.
- dom/Text.h:
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::isContentNodeRegisteredWithAnyNamedFlow):
- rendering/FlowThreadController.h:
- rendering/RenderObject.h:
(WebCore::RenderObject::canDOMChildrenHaveRenderParent): Even if this render object can't have render children,
the children in the DOM tree may have a render parent (that is different from this render object).
- rendering/RenderRegion.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::moveToFlowThreadIsNeeded): Allow only svg root elements to be directly collected by a
render flow thread.
- svg/SVGElement.h:
(SVGElement):
LayoutTests:
- fast/regions/flow-body-in-html-expected.txt: Added.
- fast/regions/flow-body-in-html.html: Added. To test the duplicate bug #103685.
- fast/regions/region-content-flown-into-region-expected.html: Added.
- fast/regions/region-content-flown-into-region.html: Added.
- fast/regions/universal-selector-children-to-the-same-region-expected.txt: Added.
- fast/regions/universal-selector-children-to-the-same-region.html: Added. To test the duplicate bug #103685.
- 9:51 AM Changeset in webkit [147755] by
-
- 6 edits in trunk/Source/WTF
Remove more dead Chromium code from WTF
https://bugs.webkit.org/show_bug.cgi?id=114037
Reviewed by Allan Sandfeld Jensen.
- wtf/CurrentTime.cpp:
(WTF):
- wtf/DisallowCType.h:
- wtf/ExportMacros.h:
- wtf/MainThread.cpp:
- wtf/Platform.h:
- 9:40 AM Changeset in webkit [147754] by
-
- 4 edits in trunk/Source
Allow the Web Inspector to use WebSQL.
This fixes an exception on load in the Safari Web Inspector.
https://webkit.org/b/114040
rdar://problem/13581422
Reviewed by Anders Carlsson.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Added.
Source/WebKit2:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::exceededDatabaseQuota): Added.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Hook up exceededDatabaseQuota.
- 9:40 AM Changeset in webkit [147753] by
-
- 1 copy in tags/Safari-536.29.11
New Tag.
- 9:26 AM Changeset in webkit [147752] by
-
- 5 edits in trunk/Source/WebKit2
Add SPI to get a copy of the context menu at a given point.
<rdar://problem/13450908> and https://bugs.webkit.org/show_bug.cgi?id=113958
Reviewed by Andy Estes.
Add the new accessor:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::contextMenuAtPoint):
- WebProcess/WebPage/WebPage.h:
Expose the new SPI:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCopyContextMenuAtPoint):
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
- 9:13 AM Changeset in webkit [147751] by
-
- 5 edits in trunk/Source/WebCore
Fix GCC with C++11 build
https://bugs.webkit.org/show_bug.cgi?id=111579
Reviewed by Anders Carlsson.
If the destructor is private, MemoryInstrumentation can not create an inherited class.
- css/PropertySetCSSStyleDeclaration.h:
(StyleRuleCSSStyleDeclaration):
- dom/ShadowRoot.h:
(ShadowRoot):
- loader/SubresourceLoader.h:
(SubresourceLoader):
- platform/Timer.h:
- 8:52 AM Changeset in webkit [147750] by
-
- 11 edits in trunk/Source/WebCore
[Qt] Create ShadowBlur on demand.
https://bugs.webkit.org/show_bug.cgi?id=113506
Reviewed by Noam Rosenthal.
This patch creates ShadowBlur objects on demand instead of keeping a single one alive for
each GraphicsContext. This matches what other platforms does and fixes the problem with
an active shadowblur being affected by changing shadow settings on the GraphicsContext.
The method mustUseShadowBlur is moved from ShadowBlur to GraphcisContext, so that it can
be used to determine if a ShadowBlur object should even be generated.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::hasBlurredShadow):
(WebCore::GraphicsContext::mustUseShadowBlur):
- platform/graphics/GraphicsContext.h:
(GraphicsContext):
- platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::ShadowBlur):
- platform/graphics/ShadowBlur.h:
- platform/graphics/cairo/FontCairo.cpp:
(WebCore::drawGlyphsShadow):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
- platform/graphics/qt/FontQt.cpp:
(WebCore::drawQtGlyphRun):
- platform/graphics/qt/GraphicsContextQt.cpp:
(GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clearPlatformShadow):
- platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::draw):
- platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::draw):
- 8:49 AM Changeset in webkit [147749] by
-
- 12 edits5 deletes in trunk/Source/WebCore
Remove Chromium code from WebCore/page
https://bugs.webkit.org/show_bug.cgi?id=114013
Reviewed by Anders Carlsson.
Removed.
- page/Console.cpp:
(WebCore::Console::time):
(WebCore::Console::timeEnd):
- page/EventHandler.cpp:
(WebCore::shouldGesturesTriggerActive):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore):
(WebCore::EventHandler::sendScrollEventToView):
- page/FeatureObserver.cpp:
(WebCore::FeatureObserver::updateMeasurements):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::useSlowRepaints):
- page/PageConsole.cpp:
- page/PageGroup.cpp:
(WebCore::PageGroup::isLinkVisited):
(WebCore::PageGroup::addVisitedLink):
- page/Settings.cpp:
(WebCore):
- page/android: Removed.
- page/chromium: Removed.
- page/chromium/ChromeClientChromium.h: Removed.
- page/chromium/DragControllerChromium.cpp: Removed.
- page/chromium/EventHandlerChromium.cpp: Removed.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::create):
(WebCore):
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
- page/scrolling/ScrollingTree.cpp:
(WebCore):
- page/scrolling/ScrollingTree.h:
(ScrollingTree):
- page/scrolling/chromium: Removed.
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp: Removed.
- page/scrolling/chromium/ScrollingCoordinatorChromium.h: Removed.
- 8:45 AM Changeset in webkit [147748] by
-
- 7 edits18 deletes in trunk/Source/WebCore
Remove Chromium code from WebCore/rendering
https://bugs.webkit.org/show_bug.cgi?id=114017
Reviewed by Simon Fraser.
Removed.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresScrollCornerLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::paintContents):
(WebCore::shouldCompositeOverflowControls):
(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer):
- rendering/RenderMediaControlsChromium.cpp: Removed.
- rendering/RenderMediaControlsChromium.h: Removed.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):
- rendering/RenderText.cpp:
(WebCore):
(WebCore::RenderText::previousOffsetForBackwardDeletion):
- rendering/RenderThemeChromiumAndroid.cpp: Removed.
- rendering/RenderThemeChromiumAndroid.h: Removed.
- rendering/RenderThemeChromiumCommon.cpp: Removed.
- rendering/RenderThemeChromiumCommon.h: Removed.
- rendering/RenderThemeChromiumDefault.cpp: Removed.
- rendering/RenderThemeChromiumDefault.h: Removed.
- rendering/RenderThemeChromiumFontProvider.cpp: Removed.
- rendering/RenderThemeChromiumFontProvider.h: Removed.
- rendering/RenderThemeChromiumFontProviderLinux.cpp: Removed.
- rendering/RenderThemeChromiumFontProviderWin.cpp: Removed.
- rendering/RenderThemeChromiumMac.h: Removed.
- rendering/RenderThemeChromiumMac.mm: Removed.
- rendering/RenderThemeChromiumSkia.cpp: Removed.
- rendering/RenderThemeChromiumSkia.h: Removed.
- rendering/RenderThemeChromiumWin.cpp: Removed.
- rendering/RenderThemeChromiumWin.h: Removed.
- rendering/RenderThemeMacShared.mm:
(WebCore::RenderThemeMacShared::paintSliderThumb):
- 8:26 AM Changeset in webkit [147747] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Blitting wrong rect during history navigations
https://bugs.webkit.org/show_bug.cgi?id=113963
Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.
On www.bbc.com/news, we blit wrong rect during the second restoration
of the view states when we navigate back from stories to the main page.
Update the contents size and scroll position before we render and blit
if we failed to zoomAboutPoint so that UI thread can still get the
correct rect during blit.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
- 7:50 AM Changeset in webkit [147746] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] css3/filters/filter-animation-from-none-hw.html does not animate
https://bugs.webkit.org/show_bug.cgi?id=114026
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-05
Reviewed by Allan Sandfeld Jensen.
Allow the filter's blending function to take place when animating from/to none.
- platform/graphics/GraphicsLayerAnimation.cpp:
(WebCore::applyFilterAnimation):
- 7:47 AM Changeset in webkit [147745] by
-
- 2 edits in trunk/Source/WebCore
[CoordGfx] Enable filter animations
https://bugs.webkit.org/show_bug.cgi?id=114027
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-05
Reviewed by Allan Sandfeld Jensen.
Allow CoordinatedGraphicsLayer to serialize filter animations to the UI process.
Covered by animation tests in css3/filters.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::addAnimation):
- 7:45 AM Changeset in webkit [147744] by
-
- 12 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Replace map{From,To}Transformed() with ViewportAccessor
https://bugs.webkit.org/show_bug.cgi?id=113449
Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-04-05
Reviewed by Rob Buis.
This removes the WebPage/BackingStoreClient family of coordinate
transformation functions, which were widely disliked for their
naming, with ViewportAccessor API that had previously been
introduced for limited use cases. This commit takes care of the
remaining call sites and leaves us with a single API to use.
No new tests, only a clean-up/refactor of existing code & functionality.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::slowScroll):
(BlackBerry::WebKit::BackingStorePrivate::visibleContentsRect):
(BlackBerry::WebKit::BackingStorePrivate::unclippedVisibleContentsRect):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::expandedContentsSize):
- Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::clipToRect):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::scrollPosition):
(BlackBerry::WebKit::WebPagePrivate::maximumScrollPosition):
(BlackBerry::WebKit::WebPagePrivate::setScrollPosition):
(BlackBerry::WebKit::WebPagePrivate::viewportSize):
(BlackBerry::WebKit::WebPagePrivate::actualVisibleSize):
(BlackBerry::WebKit::WebPagePrivate::layoutFinished):
(BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
(BlackBerry::WebKit::WebPagePrivate::updateCursor):
(BlackBerry::WebKit::WebPagePrivate::focusNodeRect):
(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
(BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::blockZoom):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebKitSupport/BackingStoreClient.cpp:
(BlackBerry::WebKit::BackingStoreClient::transformedScrollPosition):
(BlackBerry::WebKit::BackingStoreClient::transformedMaximumScrollPosition):
(BlackBerry::WebKit::BackingStoreClient::actualVisibleSize):
(BlackBerry::WebKit::BackingStoreClient::transformedActualVisibleSize):
- WebKitSupport/BackingStoreClient.h:
(BackingStoreClient):
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::fingerRectForPoint):
(BlackBerry::WebKit::FatFingers::FatFingers):
(BlackBerry::WebKit::FatFingers::findBestPoint):
(BlackBerry::WebKit::FatFingers::findIntersectingRegions):
(BlackBerry::WebKit::FatFingers::getNodesFromRect):
- WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::sendClickAtFatFingersPoint):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
- WebKitSupport/WebKitThreadViewportAccessor.cpp:
(BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelContentsSize):
(BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelScrollPosition):
(BlackBerry::WebKit::WebKitThreadViewportAccessor::documentViewportSize):
- 6:42 AM Changeset in webkit [147743] by
-
- 2 edits in trunk/Source/WTF
[EFL] Disable GLOBAL_FAST_MALLOC_NEW by default.
https://bugs.webkit.org/show_bug.cgi?id=114031
Reviewed by Alexis Menard.
Follow what some other ports already do and avoid globally overriding
thenew' anddelete' operators with the ones in FastMalloc.
In many cases, third-party or client code allocates memory with
standard library calls but the memory gets deleted by FastMalloc,
causing a crash. The reverse (ie. memory being allocated by FastMalloc
and freed by the system libraries) is also possible.
Commits 135666 and 121018 provide more information about this, as well
as comment 6 in bug 89358.
- wtf/Platform.h:
- 6:26 AM Changeset in webkit [147742] by
-
- 2 edits in trunk/Source/WebCore
Avoid double hash table lookups in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=114030
Reviewed by Noam Rosenthal.
Use Vector::add() and leverage its returned AddResult value instead of
calling Vector::find() then Vector::set() if the key does not already
exist in the map. This results in a single hash lookup instead of two
in this case.
No new tests, no behavior change.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::SharedGLData::getShaderProgram):
(WebCore::TextureMapperGLData::getStaticVBO):
(WebCore::TextureMapperGL::drawUsingCustomFilter):
- 6:17 AM Changeset in webkit [147741] by
-
- 8 edits in trunk/Source/WebKit2
[WK2][EFL] WebView should own page position and scale factor
https://bugs.webkit.org/show_bug.cgi?id=111075
Reviewed by Andreas Kling.
View content position and content scale factor should belong to WebView
rather than to EwkView as it decreases EwkView usage inside EFL-agnostic
WebView and improves WebView encapsulation.
- UIProcess/API/C/efl/WKView.cpp:
(WKViewGetContentScaleFactor):
(WKViewSetContentScaleFactor):
New WKView API was added to set and get content scale factor.
The view content scale factor is not the same as page scale factor:
it always applies to content but not necessarily applies to the page.
The view content scale factor is calculated by viewport controller
and applies immediately for painting in UI process. Page scale factor
is updated later after the frame is rendered to accomplish the pending
scale change.
(WKViewGetContentPosition):
(WKViewSetContentPosition):
New WKView API was added to set and get content position.
Content position is set in UI units.
- UIProcess/API/C/efl/WKView.h:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
- UIProcess/API/efl/EwkView.h:
(EwkView):
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::setViewportPosition):
(WebKit::PageViewportControllerClientEfl::setPageScaleFactor):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::WebView):
(WebKit::WebView::paintToCairoSurface):
(WebKit::WebView::transformToScene):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::pageDidRequestScroll):
- UIProcess/efl/WebView.h:
(WebKit::WebView::setContentScaleFactor):
(WebKit::WebView::contentScaleFactor):
(WebView):
(WebKit::WebView::setContentPosition):
(WebKit::WebView::contentPosition):
- 5:50 AM Changeset in webkit [147740] by
-
- 7 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove unused parameters from notifyAnimationStarted() and paintContents()
https://bugs.webkit.org/show_bug.cgi?id=114022
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05
Reviewed by Carlos Garcia Campos.
Naming the 'time' and 'inClip' unused parameters only produces
compiler warnings.
- Api/WebOverlay_p.h:
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
(WebOverlayPrivateWebKitThread):
- Api/WebPage_p.h:
(BlackBerry::WebKit::WebPagePrivate::notifyAnimationStarted):
(BlackBerry::WebKit::WebPagePrivate::paintContents):
- WebKitSupport/DefaultTapHighlight.h:
(BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted):
- WebKitSupport/InspectorOverlayBlackBerry.cpp:
(BlackBerry::WebKit::InspectorOverlay::paintContents):
- WebKitSupport/InspectorOverlayBlackBerry.h:
(BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
(InspectorOverlay):
- WebKitSupport/SelectionOverlay.h:
(BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):
- 5:38 AM Changeset in webkit [147739] by
-
- 11 edits4 adds in trunk
Source/WebCore: Updating mouse cursor on style changes without emitting fake mousemove event
https://bugs.webkit.org/show_bug.cgi?id=101857
Patch by Aivo Paas <aivopaas@gmail.com> on 2013-04-05
Reviewed by Allan Sandfeld Jensen.
Mouse cursor changes in styles used to be reflected in UI through dispatching a fake
mousemove event. The old approach has some flaws: it emits a mousemove event in
javascript when there is no mouse movement involved (bug 85343); the fake mousemove
event is cancelled while there is a mouse button held down - cursor won't change
until mouse is moved or the button released (bug 53341).
The new approach does not use the fake mousemove event. Instead, it uses only the logic
needed for the actual cursor change to happen.
EventHandler::selectCursor was refactored to not take a whole mouse event but instead work with
HitTestResult so that EventHandler::updateCursor must not create a useless PlatformEvent.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=85343 (mousemove event on cursor change)
https://bugs.webkit.org/show_bug.cgi?id=53341 (no cursor change when mouse button down)
Tests: fast/events/mouse-cursor-change.html
fast/events/mouse-cursor-no-mousemove.html
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::cursorUpdateTimerFired):
(WebCore::EventHandler::updateCursor):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::scheduleCursorUpdate):
- page/EventHandler.h:
- page/FrameView.cpp:
(WebCore::FrameView::shouldSetCursor):
- page/FrameView.h:
- page/MouseEventWithHitTestResults.cpp:
(WebCore::MouseEventWithHitTestResults::isOverLink):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::isOverLink):
- rendering/HitTestResult.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleDidChange):
LayoutTests: Updating mouse cursor on style changes without emitting fake mousemove event
https://bugs.webkit.org/show_bug.cgi?id=101857
Changing CSS cursor should work no matter is mouse button is pressed or not
https://bugs.webkit.org/show_bug.cgi?id=53341
Patch by Aivo Paas <aivopaas@gmail.com> on 2013-04-05
Reviewed by Allan Sandfeld Jensen.
Added tests for changing cursor on mousemove, mousedown, mouseup and mousemove
while mouse button being held down. Also added test to verify that a mousemove
event is not fired for changing cursor when mouse is not moving.
- fast/events/mouse-cursor-change-expected.txt: Added.
- fast/events/mouse-cursor-change.html: Added.
- fast/events/mouse-cursor-no-mousemove-expected.txt: Added.
- fast/events/mouse-cursor-no-mousemove.html: Added.
- platform/mac/TestExpectations:
- 5:26 AM Changeset in webkit [147738] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] WebOverlay: fix access to m_client
https://bugs.webkit.org/show_bug.cgi?id=114003
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05
Reviewed by Rob Buis.
m_client was replace by m_overlay in r146058.
- Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
- 4:27 AM Changeset in webkit [147737] by
-
- 2 edits in trunk/Source/WebCore
[Qt] PluginsX11: exposedRect offset is applied twice when painting windowless
https://bugs.webkit.org/show_bug.cgi?id=114020
Reviewed by Simon Hausmann.
Both XGetImage and QPainter::drawImage would apply the offset.
Since the XImage will only contain the exposed rect, no need to specify
the source rect to drawImage.
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::paintUsingXPixmap):
- 4:01 AM Changeset in webkit [147736] by
-
- 7 edits in trunk/Source/WebKit/blackberry
[BlackBerry] WebOverlayPrivate: remove showDebugBorders() and showRepaintCounter()
https://bugs.webkit.org/show_bug.cgi?id=114009
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05
Reviewed by Carlos Garcia Campos.
These methods were removed in r133517 but were accidentally
introduced again in r145968.
The previous patch didn't remove them all.
- WebKitSupport/DefaultTapHighlight.cpp:
- WebKitSupport/DefaultTapHighlight.h:
(DefaultTapHighlight):
- WebKitSupport/InspectorOverlayBlackBerry.cpp:
- WebKitSupport/InspectorOverlayBlackBerry.h:
(InspectorOverlay):
- WebKitSupport/SelectionOverlay.cpp:
- WebKitSupport/SelectionOverlay.h:
(SelectionOverlay):
- 3:14 AM Changeset in webkit [147735] by
-
- 1 edit in branches/chromium/1453/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js
Merge 147314 "Web Inspector: Fixed DOM Breakpoint pane styles."
Web Inspector: Fixed DOM Breakpoint pane styles.
https://bugs.webkit.org/show_bug.cgi?id=113688
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-04-01
Reviewed by Pavel Feldman.
The required stylesheet (breakpointsList.css) was not loaded because of
the peculiar way DOMBreakpointsSidebarPane is included in two panels
(Sources and Elements) via a proxy pane. Since DOMBreakpointsSidebarPane
was never shown directly the registerRequiredCSS call in its base class
NativeBreakpointsSidebarPane constructor had no effect.
Addin a registerRequiredCSS call to the proxy pane constructor fixes the
problem.
- inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.Proxy):
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/13598005
- 3:06 AM Changeset in webkit [147734] by
-
- 1 edit in branches/chromium/1453/Source/WebCore/inspector/front-end/StylesSidebarPane.js
Merge 147088 "Web Inspector: Fixed property text indentation in ..."
Web Inspector: Fixed property text indentation in Styles sidebar.
https://bugs.webkit.org/show_bug.cgi?id=113409
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-28
Reviewed by Alexander Pavlov.
When the sidebar is too narrow and the property text wraps around it breaks the indentation.
This was introduced in r143207 which spuriously modified DOM elements order.
- inspector/front-end/StylesSidebarPane.js:
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/13568005
- 3:00 AM Changeset in webkit [147733] by
-
- 1 edit2 copies in branches/chromium/1453
Merge 147094 "Web Inspector: [REGRESSION] [Styles] Pasting a pro..."
Web Inspector: [REGRESSION] [Styles] Pasting a property in the "name" field is broken
https://bugs.webkit.org/show_bug.cgi?id=113491
Reviewed by Pavel Feldman.
Source/WebCore:
Update the CSSProperty name and value upon pasting properties into the Styles pane.
Drive-by: start editing the next/new property name after pasting.
Test: inspector/styles/paste-property.html
- inspector/front-end/StylesSidebarPane.js:
(.selectElement):
(.moveDirection.alreadyNew):
LayoutTests:
- inspector/styles/paste-property-expected.txt: Added.
- inspector/styles/paste-property.html: Added.
TBR=apavlov@chromium.org
Review URL: https://codereview.chromium.org/13719002
- 2:28 AM Changeset in webkit [147732] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: crash in InspectorDOMAgent::innerHighlightQuad after r147566
https://bugs.webkit.org/show_bug.cgi?id=113991
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-05
Reviewed by Joseph Pecoraro.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::innerHighlightQuad):
- 2:25 AM Changeset in webkit [147731] by
-
- 7 edits1 add in trunk/Source/WebCore
REGRESSION(r145279): Build fails while linking when MEDIA_STREAM is enabled
https://bugs.webkit.org/show_bug.cgi?id=113294
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-05
Reviewed by Xan Lopez.
In r145279 NamedGetter extended attribute is added to
RTCStatsResponse.idl which makes the code generator to add
prototypes for JSRTCStatsResponse::nameGetter and
JSRTCStatsResponse::canGetItemsForName to the generated
JSRTCStatsResponse header, but they are not implemented
anywhere. We need to provide a JSRTCStatsResponseCustom file with
the implementation of both functions.
- GNUmakefile.list.am: Add JSRTCStatsResponseCustom.cpp to
compilation.
- Target.pri: Ditto.
- UseJSC.cmake: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- bindings/js/JSRTCStatsResponseCustom.cpp: Added.
(WebCore):
(WebCore::JSRTCStatsResponse::canGetItemsForName):
(WebCore::JSRTCStatsResponse::nameGetter):
- 2:12 AM Changeset in webkit [147730] by
-
- 17 edits4 deletes in trunk/Source/WebCore
Remove Chromium code from WebCore/loader
https://bugs.webkit.org/show_bug.cgi?id=114011
Reviewed by Benjamin Poulain.
Removed.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
- loader/DocumentThreadableLoader.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::defaultObjectContentType):
(WebCore):
- loader/FrameLoader.h:
(FrameLoader):
- loader/FrameLoaderClient.h:
(FrameLoaderClient):
- loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
- loader/ResourceLoadScheduler.cpp:
(WebCore):
(WebCore::ResourceLoadScheduler::ResourceLoadScheduler):
(WebCore::ResourceLoadScheduler::scheduleLoad):
- loader/ResourceLoader.h:
- loader/SubresourceLoader.h:
- loader/ThreadableLoaderClient.h:
(ThreadableLoaderClient):
- loader/ThreadableLoaderClientWrapper.h:
(ThreadableLoaderClientWrapper):
- loader/appcache/ApplicationCacheHost.h:
(WebCore):
(ApplicationCacheHost):
- loader/cache/CachedRawResource.h:
(CachedRawResource):
(WebCore::CachedRawResourceClient::redirectReceived):
- loader/cache/CachedResource.cpp:
(WebCore):
(WebCore::CachedResource::load):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::didSendData):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::preload):
- loader/chromium: Removed.
- loader/chromium/CachedRawResourceChromium.cpp: Removed.
- loader/chromium/DocumentThreadableLoaderChromium.cpp: Removed.
- loader/chromium/ResourceLoaderChromium.cpp: Removed.
- loader/chromium/SubresourceLoaderChromium.cpp: Removed.
- 2:05 AM Changeset in webkit [147729] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLint should be able to use x87 instead of SSE for floating pointer
https://bugs.webkit.org/show_bug.cgi?id=112239
Reviewed by Filip Pizlo.
Implements LLInt floating point operations in x87, to ensure we support
x86 without SSE2.
X86 (except 64bit) now defaults to using x87 instructions in order to
support all 32bit x86 back to i686. The implementation uses the fucomi
instruction from i686 which sets the new minimum.
- offlineasm/x86.rb:
- 1:59 AM Changeset in webkit [147728] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] WebOverlayPrivate: remove showDebugBorders() and showRepaintCounter()
https://bugs.webkit.org/show_bug.cgi?id=114009
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05
Reviewed by Carlos Garcia Campos.
These methods were removed in r133517 but were accidentally
introduced again in r145968.
- Api/WebOverlay_p.h:
(WebOverlayPrivateWebKitThread):
- 1:25 AM Changeset in webkit [147727] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Removing a couple of expectations for tests that are now passing.
- 1:24 AM Changeset in webkit [147726] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] WebOverlay: check if platformContext is null
https://bugs.webkit.org/show_bug.cgi?id=114005
Patch by Anthony Scian <ascian@blackberry.com> on 2013-04-05
Reviewed by Carlos Garcia Campos.
RIM PR 256522
Internally reviewed by Mike Lattanzio.
The pointer returned by lockBufferDrawable can be null, so it
needs to be checked first before being used.
- Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
- 1:22 AM Changeset in webkit [147725] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][WK2] WebKitLoaderClient: add missing initializers
https://bugs.webkit.org/show_bug.cgi?id=112961
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05
Reviewed by Carlos Garcia Campos.
There are two new attributes: pluginLoadPolicy and pluginDidFail.
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
(attachLoaderClientToView):
- 1:20 AM Changeset in webkit [147724] by
-
- 2 edits3 adds in trunk
Fix GTK+ for real after r147712
Reviewed by Ryosuke Niwa.
.:
- GNUmakefile.am:
- Source/Platform: Added.
- Source/Platform/GNUmakefile.am: Added.
Source/Platform:
- GNUmakefile.am: Added.
- Platform: Added.
- 1:20 AM Changeset in webkit [147723] by
-
- 7 edits in trunk/Source/WebKit2
[WK2][EFL] Encapsulate view states set-up within WebView
https://bugs.webkit.org/show_bug.cgi?id=110877
Reviewed by Benjamin Poulain.
View states set-up is encapsulated within WebView. This change
reduces both usage of EwkView inside WebView class and usage of
WebPageProxy inside EwkView class.
New WKView API was added so that EwkView can define whether or not
the view is visible and focused.
- UIProcess/API/C/efl/WKView.cpp:
(WKViewIsFocused):
(WKViewSetIsFocused):
(WKViewIsVisible):
(WKViewSetIsVisible):
- UIProcess/API/C/efl/WKView.h:
- UIProcess/API/efl/EwkView.cpp:
(::handleEvent):
(EwkView::handleEvasObjectShow):
(EwkView::handleEwkViewFocusIn):
(EwkView::handleEwkViewFocusOut):
- UIProcess/API/efl/EwkView.h:
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::WebView):
(WebKit::WebView::setFocused):
(WebKit):
(WebKit::WebView::setVisible):
(WebKit::WebView::isViewFocused):
(WebKit::WebView::isViewVisible):
- UIProcess/efl/WebView.h:
(WebKit::WebView::isFocused):
(WebView):
(WebKit::WebView::isVisible):
- 1:10 AM Changeset in webkit [147722] by
-
- 3 edits1 add in trunk/LayoutTests
[EFL] New baseline for accessibility/aria-option-role.html
https://bugs.webkit.org/show_bug.cgi?id=114006
Unreviewed, EFL gardening.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-04-05
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/efl/accessibility/aria-option-role-expected.txt: Added.
- 1:02 AM Changeset in webkit [147721] by
-
- 3 edits1 delete in trunk/Source/WebCore
Remove Chromium code from WebCore/editing
https://bugs.webkit.org/show_bug.cgi?id=114008
Reviewed by Benjamin Poulain.
Removed.
- editing/EditingBehavior.h:
(WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
- editing/FrameSelection.h:
(WebCore):
- editing/chromium: Removed.
- editing/chromium/EditorChromium.cpp: Removed.
- editing/chromium/FrameSelectionChromium.cpp: Removed.
- 12:55 AM Changeset in webkit [147720] by
-
- 5 edits in trunk/Source/WebCore
Remove the chromium code from the filesystem module
https://bugs.webkit.org/show_bug.cgi?id=114002
Reviewed by Ryosuke Niwa.
- Modules/filesystem/DOMFileSystemBase.cpp:
(WebCore::DOMFileSystemBase::createFileSystemURL):
- Modules/filesystem/FileSystemType.h:
- Modules/filesystem/LocalFileSystem.cpp:
- Modules/filesystem/LocalFileSystem.h:
(LocalFileSystem):
- 12:48 AM Changeset in webkit [147719] by
-
- 4 edits1 delete in trunk/Source/WebCore
Remove Chromium code from Source/WebCore/dom
https://bugs.webkit.org/show_bug.cgi?id=114007
Reviewed by Benjamin Poulain.
Removed.
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
(WebCore::Document::implicitClose):
(WebCore::Document::setFocusedNode):
- dom/MessagePortChannel.h:
(MessagePortChannel):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
- dom/default/chromium: Removed.
- dom/default/chromium/PlatformMessagePortChannelChromium.cpp: Removed.
- dom/default/chromium/PlatformMessagePortChannelChromium.h: Removed.
- 12:32 AM Changeset in webkit [147718] by
-
- 1 edit4 deletes in trunk/Source/WebCore
Remove the chromium directories from WebCore/Modules
https://bugs.webkit.org/show_bug.cgi?id=114000
Reviewed by Ryosuke Niwa.
First step in cleaning the code: remove the chromium-specific files.
- Modules/filesystem/chromium/DOMFileSystemChromium.cpp: Removed.
- Modules/filesystem/chromium/DataTransferItemFileSystemChromium.cpp: Removed.
- Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp: Removed.
- Modules/filesystem/chromium/DraggedIsolatedFileSystem.h: Removed.
- Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp: Removed.
- Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h: Removed.
- Modules/speech/chromium/SpeechSynthesisChromium.cpp: Removed.
- Modules/webdatabase/chromium/DatabaseObserver.h: Removed.
- Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp: Removed.
- Modules/webdatabase/chromium/QuotaTracker.cpp: Removed.
- Modules/webdatabase/chromium/QuotaTracker.h: Removed.
- Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp: Removed.
- 12:25 AM Changeset in webkit [147717] by
-
- 2 edits in trunk
Fix GTK+ build after r147712
Unreviewed.
- GNUmakefile.am: remove the reference to
Source/Platform/GNUmakefile.am. The file has been removed.
- 12:12 AM Changeset in webkit [147716] by
-
- 3 edits1 delete in trunk/Source/WebCore
Remove Chromium code from WebCore/accessibility
https://bugs.webkit.org/show_bug.cgi?id=114001
Reviewed by Benjamin Poulain.
Removed.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::AccessibilityObject):
(WebCore::AccessibilityObject::detach):
(WebCore::AccessibilityObject::isDetached):
- accessibility/AccessibilityObject.h:
(AccessibilityObject):
- accessibility/chromium: Removed.
- accessibility/chromium/AXObjectCacheChromium.cpp: Removed.
- accessibility/chromium/AccessibilityObjectChromium.cpp: Removed.
- 12:05 AM Changeset in webkit [147715] by
-
- 20 edits4 deletes in trunk
Remove WTFURL from WebKit
https://bugs.webkit.org/show_bug.cgi?id=113994
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-05
Reviewed by Ryosuke Niwa.
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebCore:
- GNUmakefile.list.am:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- platform/KURL.cpp:
(WebCore):
(WebCore::KURL::reportMemoryUsage):
(WebCore::KURL::isSafeToSendToAnotherThread):
- platform/KURL.h:
(KURL):
(WebCore):
- platform/KURLWTFURL.cpp: Removed.
- platform/KURLWTFURLImpl.h: Removed.
- platform/cf/KURLCFNet.cpp:
(WebCore::KURL::KURL):
(WebCore::KURL::createCFURL):
(WebCore):
- platform/mac/KURLMac.mm:
(WebCore::KURL::KURL):
(WebCore::KURL::createCFURL):
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataUseFeatures.in:
Source/WTF:
Painful, but that is for the best now :(
- GNUmakefile.list.am:
- WTF.xcodeproj/project.pbxproj:
- wtf/MemoryInstrumentationParsedURL.h: Removed.
- wtf/url/api/ParsedURL.cpp: Removed.
- wtf/url/api/ParsedURL.h: Removed.
- wtf/url/api/URLBuffer.h: Removed.
- wtf/url/api/URLQueryCharsetConverter.h: Removed.
- wtf/url/api/URLString.cpp: Removed.
- wtf/url/api/URLString.h: Removed.
- wtf/url/src/RawURLBuffer.h: Removed.
- wtf/url/src/URLCanon.h: Removed.
- wtf/url/src/URLCanonEtc.cpp: Removed.
- wtf/url/src/URLCanonFilesystemurl.cpp: Removed.
- wtf/url/src/URLCanonFileurl.cpp: Removed.
- wtf/url/src/URLCanonHost.cpp: Removed.
- wtf/url/src/URLCanonICU.cpp: Removed.
- wtf/url/src/URLCanonIP.cpp: Removed.
- wtf/url/src/URLCanonInternal.cpp: Removed.
- wtf/url/src/URLCanonInternal.h: Removed.
- wtf/url/src/URLCanonMailto.cpp: Removed.
- wtf/url/src/URLCanonPath.cpp: Removed.
- wtf/url/src/URLCanonPathurl.cpp: Removed.
- wtf/url/src/URLCanonQuery.cpp: Removed.
- wtf/url/src/URLCanonRelative.cpp: Removed.
- wtf/url/src/URLCanonStdURL.cpp: Removed.
- wtf/url/src/URLCharacterTypes.cpp: Removed.
- wtf/url/src/URLCharacterTypes.h: Removed.
- wtf/url/src/URLComponent.h: Removed.
- wtf/url/src/URLFile.h: Removed.
- wtf/url/src/URLParse.cpp: Removed.
- wtf/url/src/URLParse.h: Removed.
- wtf/url/src/URLParseFile.cpp: Removed.
- wtf/url/src/URLParseInternal.h: Removed.
- wtf/url/src/URLSegments.cpp: Removed.
- wtf/url/src/URLSegments.h: Removed.
- wtf/url/src/URLUtil.cpp: Removed.
- wtf/url/src/URLUtil.h: Removed.
- wtf/url/src/URLUtilInternal.h: Removed.
Apr 4, 2013:
- 11:55 PM Changeset in webkit [147714] by
-
- 1 edit1 delete in trunk/Source/WebKit
Remove Webkit/chromium
https://bugs.webkit.org/show_bug.cgi?id=113998
Reviewed by Ryosuke Niwa.
O Knights of Ni, you are just and fair, and we will return with a shrubbery.
- chromium: Removed.
- 11:46 PM Changeset in webkit [147713] by
-
- 2 edits in trunk/Source/WebCore
WinCairo build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=113873
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-04
Reviewed by Brent Fulgham.
Removed double guards for USE(ACCELERATED_COMPOSITING),
and moved methods out of USE(ACCELERATED_COMPOSITING) guard to fix linker errors.
- page/FrameView.cpp:
(WebCore::FrameView::setWantsLayerForTopOverHangArea):
(WebCore::FrameView::setWantsLayerForBottomOverHangArea):
(WebCore::FrameView::setWantsLayerForHeader):
(WebCore::FrameView::setWantsLayerForFooter):
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):
- 11:39 PM Changeset in webkit [147712] by
-
- 1 edit2 deletes in trunk
Remove the top level gyp directory and Platform/chromium
https://bugs.webkit.org/show_bug.cgi?id=113999
Reviewed by Benjamin Poulain.
.:
- Source/Platform: Removed.
- Source/gyp: Removed.
Source/Platform:
- Platform.gyp: Removed.
- Platform.gyp/.gitignore: Removed.
- Platform.gyp/Platform.gyp: Removed.
- Platform.gypi: Removed.
- chromium: Removed.
- chromium/public: Removed.
- chromium/public/Platform.h: Removed.
- chromium/public/WebAnimation.h: Removed.
- chromium/public/WebAnimationCurve.h: Removed.
- chromium/public/WebAnimationDelegate.h: Removed.
- chromium/public/WebAudioBus.h: Removed.
- chromium/public/WebAudioDestinationConsumer.h: Removed.
- chromium/public/WebAudioDevice.h: Removed.
- chromium/public/WebBlobData.h: Removed.
- chromium/public/WebBlobRegistry.h: Removed.
- chromium/public/WebCString.h: Removed.
- chromium/public/WebCanvas.h: Removed.
- chromium/public/WebClipboard.h: Removed.
- chromium/public/WebColor.h: Removed.
- chromium/public/WebCommon.h: Removed.
- chromium/public/WebCompositorOutputSurface.h: Removed.
- chromium/public/WebCompositorSupport.h: Removed.
- chromium/public/WebContentLayer.h: Removed.
- chromium/public/WebContentLayerClient.h: Removed.
- chromium/public/WebCookie.h: Removed.
- chromium/public/WebCookieJar.h: Removed.
- chromium/public/WebData.h: Removed.
- chromium/public/WebDiscardableMemory.h: Removed.
- chromium/public/WebDragData.h: Removed.
- chromium/public/WebExternalTextureLayer.h: Removed.
- chromium/public/WebExternalTextureLayerClient.h: Removed.
- chromium/public/WebFileError.h: Removed.
- chromium/public/WebFileInfo.h: Removed.
- chromium/public/WebFileSystem.h: Removed.
- chromium/public/WebFileSystemCallbacks.h: Removed.
- chromium/public/WebFileSystemEntry.h: Removed.
- chromium/public/WebFileSystemType.h: Removed.
- chromium/public/WebFileUtilities.h: Removed.
- chromium/public/WebFilterOperation.h: Removed.
- chromium/public/WebFilterOperations.h: Removed.
- chromium/public/WebFlingAnimator.h: Removed.
- chromium/public/WebFloatAnimationCurve.h: Removed.
- chromium/public/WebFloatKeyframe.h: Removed.
- chromium/public/WebFloatPoint.h: Removed.
- chromium/public/WebFloatQuad.h: Removed.
- chromium/public/WebFloatRect.h: Removed.
- chromium/public/WebFloatSize.h: Removed.
- chromium/public/WebGamepad.h: Removed.
- chromium/public/WebGamepads.h: Removed.
- chromium/public/WebGestureCurve.h: Removed.
- chromium/public/WebGestureCurveTarget.h: Removed.
- chromium/public/WebGraphicsContext3D.h: Removed.
- chromium/public/WebGraphicsMemoryAllocation.h: Removed.
- chromium/public/WebGraphicsMemoryStats.h: Removed.
- chromium/public/WebHTTPBody.h: Removed.
- chromium/public/WebHTTPHeaderVisitor.h: Removed.
- chromium/public/WebHTTPLoadInfo.h: Removed.
- chromium/public/WebHyphenator.h: Removed.
- chromium/public/WebImage.h: Removed.
- chromium/public/WebImageLayer.h: Removed.
- chromium/public/WebInputHandler.h: Removed.
- chromium/public/WebInputHandlerClient.h: Removed.
- chromium/public/WebLayer.h: Removed.
- chromium/public/WebLayerPositionConstraint.h: Removed.
- chromium/public/WebLayerScrollClient.h: Removed.
- chromium/public/WebLayerTreeView.h: Removed.
- chromium/public/WebLocalizedString.h: Removed.
- chromium/public/WebMediaConstraints.h: Removed.
- chromium/public/WebMediaStream.h: Removed.
- chromium/public/WebMediaStreamCenter.h: Removed.
- chromium/public/WebMediaStreamCenterClient.h: Removed.
- chromium/public/WebMediaStreamSource.h: Removed.
- chromium/public/WebMediaStreamSourcesRequest.h: Removed.
- chromium/public/WebMediaStreamTrack.h: Removed.
- chromium/public/WebMessagePortChannel.h: Removed.
- chromium/public/WebMessagePortChannelClient.h: Removed.
- chromium/public/WebMimeRegistry.h: Removed.
- chromium/public/WebNonCopyable.h: Removed.
- chromium/public/WebPluginListBuilder.h: Removed.
- chromium/public/WebPoint.h: Removed.
- chromium/public/WebPrerender.h: Removed.
- chromium/public/WebPrerenderingSupport.h: Removed.
- chromium/public/WebPrivateOwnPtr.h: Removed.
- chromium/public/WebPrivatePtr.h: Removed.
- chromium/public/WebRTCConfiguration.h: Removed.
- chromium/public/WebRTCDTMFSenderHandler.h: Removed.
- chromium/public/WebRTCDTMFSenderHandlerClient.h: Removed.
- chromium/public/WebRTCDataChannelHandler.h: Removed.
- chromium/public/WebRTCDataChannelHandlerClient.h: Removed.
- chromium/public/WebRTCICECandidate.h: Removed.
- chromium/public/WebRTCPeerConnectionHandler.h: Removed.
- chromium/public/WebRTCPeerConnectionHandlerClient.h: Removed.
- chromium/public/WebRTCSessionDescription.h: Removed.
- chromium/public/WebRTCSessionDescriptionRequest.h: Removed.
- chromium/public/WebRTCStatsRequest.h: Removed.
- chromium/public/WebRTCStatsResponse.h: Removed.
- chromium/public/WebRTCVoidRequest.h: Removed.
- chromium/public/WebRect.h: Removed.
- chromium/public/WebReferrerPolicy.h: Removed.
- chromium/public/WebRenderingStats.h: Removed.
- chromium/public/WebScreenInfo.h: Removed.
- chromium/public/WebScrollbar.h: Removed.
- chromium/public/WebScrollbarLayer.h: Removed.
- chromium/public/WebScrollbarThemeGeometry.h: Removed.
- chromium/public/WebScrollbarThemePainter.h: Removed.
- chromium/public/WebSize.h: Removed.
- chromium/public/WebSocketStreamError.h: Removed.
- chromium/public/WebSocketStreamHandle.h: Removed.
- chromium/public/WebSocketStreamHandleClient.h: Removed.
- chromium/public/WebSolidColorLayer.h: Removed.
- chromium/public/WebSpeechSynthesisUtterance.h: Removed.
- chromium/public/WebSpeechSynthesisVoice.h: Removed.
- chromium/public/WebSpeechSynthesizer.h: Removed.
- chromium/public/WebSpeechSynthesizerClient.h: Removed.
- chromium/public/WebStorageArea.h: Removed.
- chromium/public/WebStorageNamespace.h: Removed.
- chromium/public/WebString.h: Removed.
- chromium/public/WebThread.h: Removed.
- chromium/public/WebThreadSafeData.h: Removed.
- chromium/public/WebTransformAnimationCurve.h: Removed.
- chromium/public/WebTransformKeyframe.h: Removed.
- chromium/public/WebTransformOperations.h: Removed.
- chromium/public/WebURL.h: Removed.
- chromium/public/WebURLError.h: Removed.
- chromium/public/WebURLLoadTiming.h: Removed.
- chromium/public/WebURLLoader.h: Removed.
- chromium/public/WebURLLoaderClient.h: Removed.
- chromium/public/WebURLRequest.h: Removed.
- chromium/public/WebURLResponse.h: Removed.
- chromium/public/WebUnitTestSupport.h: Removed.
- chromium/public/WebVector.h: Removed.
- chromium/public/WebWorkerRunLoop.h: Removed.
- chromium/public/android: Removed.
- chromium/public/android/WebSandboxSupport.h: Removed.
- chromium/public/android/WebThemeEngine.h: Removed.
- chromium/public/default: Removed.
- chromium/public/default/WebThemeEngine.h: Removed.
- chromium/public/linux: Removed.
- chromium/public/linux/WebFontFamily.h: Removed.
- chromium/public/linux/WebFontInfo.h: Removed.
- chromium/public/linux/WebFontRenderStyle.h: Removed.
- chromium/public/linux/WebSandboxSupport.h: Removed.
- chromium/public/mac: Removed.
- chromium/public/mac/WebSandboxSupport.h: Removed.
- chromium/public/mac/WebThemeEngine.h: Removed.
- chromium/public/win: Removed.
- chromium/public/win/WebSandboxSupport.h: Removed.
- chromium/public/win/WebThemeEngine.h: Removed.
- chromium/src: Removed.
- chromium/src/Platform.cpp: Removed.
- chromium/src/WebActiveGestureAnimation.cpp: Removed.
- chromium/src/WebActiveGestureAnimation.h: Removed.
- chromium/src/WebCString.cpp: Removed.
- chromium/src/WebFilterOperation.cpp: Removed.
- chromium/src/WebFilterOperations.cpp: Removed.
- chromium/src/WebFloatQuad.cpp: Removed.
- chromium/src/WebPrerenderingSupport.cpp: Removed.
- chromium/src/WebString.cpp: Removed.
- 11:20 PM Changeset in webkit [147711] by
-
- 2 edits in trunk/Tools
Remove ChromiumPublicApi pattern, and cc/message rules for it.
- Scripts/webkitpy/common/config/watchlist:
- 11:05 PM Changeset in webkit [147710] by
-
- 37 edits in trunk/Source/WebCore
Remove code for 10.5 and earlier from Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=113754
Reviewed by Benjamin Poulain.
Removed the code for 10.5 and removed if-def for 10.6.
- WebCore.xcodeproj/project.pbxproj:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
- platform/LocalizedStrings.cpp:
(WebCore::imageTitle):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setAllowsFontSmoothing):
- platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::clear):
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::boundingRect):
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore):
(WebCore::FontPlatformData::ctFont):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::supportsFullscreen):
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
- platform/graphics/mac/FontCacheMac.mm:
(WebCore):
(WebCore::fontCacheRegisteredFontsChangedNotificationCallback):
(WebCore::FontCache::platformInit):
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::supportsFullscreen):
(WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible):
(WebCore::MediaPlayerPrivateQTKit::cacheMovieScale):
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
- platform/graphics/mac/WebLayer.h:
- platform/mac/CursorMac.mm:
(WebCore::Cursor::ensurePlatformCursor):
- platform/mac/DisplaySleepDisabler.cpp:
(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
(WebCore):
- platform/mac/DisplaySleepDisabler.h:
(DisplaySleepDisabler):
- platform/mac/EmptyProtocolDefinitions.h:
- platform/mac/HTMLConverter.h:
- platform/mac/HTMLConverter.mm:
- platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenuMac::populate):
- platform/mac/ScrollElasticityController.mm:
(systemUptime):
- platform/mac/SharedTimerMac.mm:
(PowerObserver):
(WebCore::PowerObserver::PowerObserver):
(WebCore::PowerObserver::~PowerObserver):
(WebCore::PowerObserver::didReceiveSystemPowerNotification):
- platform/mac/SuddenTermination.mm:
- platform/mac/WebCoreFullScreenWindow.mm:
(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):
- platform/mac/WebFontCache.mm:
(+[WebFontCache getTraits:inFamily:]):
(+[WebFontCache internalFontWithFamily:traits:weight:size:]):
- platform/mac/WebVideoFullscreenController.mm:
(SOFT_LINK_POINTER):
(-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
- platform/mac/WebVideoFullscreenHUDWindowController.mm:
(createControlWithMediaUIControlType):
(-[WebVideoFullscreenHUDWindowController windowDidLoad]):
- platform/network/Credential.h:
- platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
- platform/network/cf/ProxyServerCFNet.cpp:
(WebCore):
(WebCore::proxyServersForURL):
- platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::chooseProxy):
- platform/network/mac/AuthenticationMac.mm:
(WebCore):
- platform/network/mac/WebCoreURLResponse.mm:
(WebCore::adjustMIMETypeIfNecessary):
- platform/text/TextChecking.h:
(WebCore):
- 10:36 PM Changeset in webkit [147709] by
-
- 3 edits in trunk/Tools
Temporarily disable the Python unittests broken by the commit queue not running layout tests
https://bugs.webkit.org/show_bug.cgi?id=113997
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Ryosuke Niwa.
Disable the tests until Ryosuke gets the time and hardware to have
a testing commit-queue.
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(CommitQueueTaskTest):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(CommitQueueTest):
- 10:24 PM Changeset in webkit [147708] by
-
- 2 edits in trunk/Source/WebCore
Qt build fix attempt after r147684.
- html/canvas/CanvasRenderingContext.cpp:
- 10:17 PM Changeset in webkit [147707] by
-
- 2 edits in trunk/Tools
Remove Chromium builders from build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=113990
Reviewed by Benjamin Poulain.
Land the part to disable triggering of Chromium builders first so that we may start
deleting more Chromium code that breaks the update step.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 9:57 PM Changeset in webkit [147706] by
-
- 1 edit1 delete in trunk
Nixed the defunct chromium folder from ManualTests
https://bugs.webkit.org/show_bug.cgi?id=113995
Reviewed by Benjamin Poulain.
- ManualTests/chromium: Removed.
- ManualTests/chromium/autofill-popup-shiftupdown.hml: Removed.
- ManualTests/chromium/drag-image-accounts-for-device-scale.html: Removed.
- ManualTests/chromium/modifiers-during-drag-and-drop.html: Removed.
- ManualTests/chromium/no-autofill-on-readonly.html: Removed.
- ManualTests/chromium/onchange-reload-popup.html: Removed.
- ManualTests/chromium/popup-menu-crash.html: Removed.
- ManualTests/chromium/select-close-popup-value-change.html: Removed.
- ManualTests/chromium/suggestions-popup-font-change.html: Removed.
- 9:53 PM Changeset in webkit [147705] by
-
- 2 edits in trunk/Tools
Remove Chromium's DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=113989
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Kent Tamura.
On second thought, let's not go to Camelot. It is a silly place.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- 9:46 PM Changeset in webkit [147704] by
-
- 1 edit1 delete in trunk/Tools
Nixed the defunct chromium folder from DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=113993
Reviewed by Ryosuke Niwa.
- DumpRenderTree/chromium: Removed.
- DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
- DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
- DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
- DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
- DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
- DumpRenderTree/chromium/ImageDiff.cpp: Removed.
- DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
- DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
- DumpRenderTree/chromium/MockPlatform.cpp: Removed.
- DumpRenderTree/chromium/MockPlatform.h: Removed.
- DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
- DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
- DumpRenderTree/chromium/Task.cpp: Removed.
- DumpRenderTree/chromium/Task.h: Removed.
- DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
- DumpRenderTree/chromium/TestEventPrinter.h: Removed.
- DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
- DumpRenderTree/chromium/TestNavigationController.h: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
- DumpRenderTree/chromium/TestRunner: Removed.
- DumpRenderTree/chromium/TestRunner/public: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
- DumpRenderTree/chromium/TestRunner/src: Removed.
- DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
- DumpRenderTree/chromium/TestShell.cpp: Removed.
- DumpRenderTree/chromium/TestShell.h: Removed.
- DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
- DumpRenderTree/chromium/TestShellMac.mm: Removed.
- DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
- DumpRenderTree/chromium/TestShellStub.cpp: Removed.
- DumpRenderTree/chromium/TestShellWin.cpp: Removed.
- DumpRenderTree/chromium/TestShellX11.cpp: Removed.
- DumpRenderTree/chromium/WebViewHost.cpp: Removed.
- DumpRenderTree/chromium/WebViewHost.h: Removed.
- DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
- DumpRenderTree/chromium/android_main_fonts.xml: Removed.
- DumpRenderTree/chromium/config.h: Removed.
- DumpRenderTree/chromium/fonts.conf: Removed.
- 9:40 PM Changeset in webkit [147703] by
-
- 1 edit1 delete in trunk/Source/WTF
Nixed the defunct chromium folder from WTF
https://bugs.webkit.org/show_bug.cgi?id=113992
Reviewed by Ryosuke Niwa.
- wtf/chromium: Removed.
- wtf/chromium/ChromiumThreading.h: Removed.
- wtf/chromium/MainThreadChromium.cpp: Removed.
- 9:39 PM Changeset in webkit [147702] by
-
- 2 edits in trunk/Source/WebCore
alternateFamilyName should return a null, not an empty value
https://bugs.webkit.org/show_bug.cgi?id=113987
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Anders Carlsson.
The string object corresponding semantically to "no-value" is
a null string, not an empty string.
Fix alternateFamilyName() accordingly.
- platform/graphics/FontCache.cpp:
(WebCore::alternateFamilyName):
(WebCore::FontCache::getCachedFontPlatformData):
- 8:46 PM Changeset in webkit [147701] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] DOMSupport::isFixedPositionOrHasFixedPositionAncestor stops traversing render tree when it hits an iframe element
https://bugs.webkit.org/show_bug.cgi?id=113944
Patch by Andrew Lo <anlo@rim.com> on 2013-04-04
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
Internal PR 320732.
When checking whether a RenderObject is fixed position or has a fixed position
ancestor, we traverse the render tree upwards.
When we reach the root of the tree, check whether the root is an
iframe and has an element owner. If so, we also need to continue iterating
up the tree from the owner to see if the iframe is a descendant of a fixed
position element.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isFixedPositionOrHasFixedPositionAncestor):
- 7:52 PM Changeset in webkit [147700] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Add support for getting page contents as string
https://bugs.webkit.org/show_bug.cgi?id=106752
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-04-04
Reviewed by Andreas Kling.
Modified ewk_view_page_contents_get() API to get page contents as string.
EWK_PAGE_CONTENTS_TYPE_STRING is added to Ewk_Page_Contents_Type.
Now, we can use both EWK_PAGE_CONTENTS_TYPE_MHTML and EWK_PAGE_CONTENTS_TYPE_STRING
for getting page contents.
- UIProcess/API/efl/ewk_view.cpp:
(Ewk_Page_Contents_Context):
(ewkViewPageContentsAsMHTMLCallback):
(ewkViewPageContentsAsStringCallback):
(ewk_view_page_contents_get):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(PageContentsAsMHTMLCallback):
(PageContentsAsStringCallback):
(TEST_F):
- 7:51 PM Changeset in webkit [147699] by
-
- 1 edit1 add7 deletes in trunk/LayoutTests
Change class_as_selector-expected.html to be a ref-test
https://bugs.webkit.org/show_bug.cgi?id=113970
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Geoffrey Garen.
The test checks style can be applied to text with a CSS class.
The reference is done by applying a style attribute directly
on each element.
- css1/basic/class_as_selector-expected.html: Added.
- platform/efl/css1/basic/class_as_selector-expected.png: Removed.
- platform/efl/css1/basic/class_as_selector-expected.txt: Removed.
- platform/gtk/css1/basic/class_as_selector-expected.txt: Removed.
- platform/mac/css1/basic/class_as_selector-expected.png: Removed.
- platform/mac/css1/basic/class_as_selector-expected.txt: Removed.
- platform/qt/css1/basic/class_as_selector-expected.png: Removed.
- platform/qt/css1/basic/class_as_selector-expected.txt: Removed.
- 7:48 PM Changeset in webkit [147698] by
-
- 2 edits in trunk/LayoutTests
Unskip 3 backface-visibility tests on OS X
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
- platform/mac/TestExpectations:
The 3 pixel tests pass on WebKit1 and WebKit2.
- 7:43 PM Changeset in webkit [147697] by
-
- 2 edits in trunk/Websites/webkit.org
Update WebKit.org's contact page
https://bugs.webkit.org/show_bug.cgi?id=113968
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Geoffrey Garen.
- contact.html:
-Add a direct link to our archives on Gmane.
-References the ports mailing-lists. This may reduces the emails
erroneously sent to webkit-dev.
-Add a link to our "reporting bug page".
-Get rid of the link to CIA. The website is dead.
- 7:39 PM Changeset in webkit [147696] by
-
- 1 edit1 delete in trunk/Tools
Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
Rubber stamped by Benjamin Poulain.
- RebaselineQueueServer: Removed.
- RebaselineQueueServer/app.yaml: Removed.
- RebaselineQueueServer/handlers: Removed.
- RebaselineQueueServer/handlers/init.py: Removed.
- RebaselineQueueServer/handlers/builderqueue.py: Removed.
- RebaselineQueueServer/handlers/pages.py: Removed.
- RebaselineQueueServer/index.yaml: Removed.
- RebaselineQueueServer/main.py: Removed.
- RebaselineQueueServer/model: Removed.
- RebaselineQueueServer/model/init.py: Removed.
- RebaselineQueueServer/model/queueentry.py: Removed.
- RebaselineQueueServer/static: Removed.
- RebaselineQueueServer/static/builder-frame-empty.html: Removed.
- RebaselineQueueServer/static/styles.css: Removed.
- RebaselineQueueServer/templates: Removed.
- RebaselineQueueServer/templates/builder-picker.html: Removed.
- RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
- RebaselineQueueServer/templates/builder-queue-list.html: Removed.
- RebaselineQueueServer/templates/home.html: Removed.
- 7:35 PM Changeset in webkit [147695] by
-
- 3 edits in trunk/Tools
Fix setup-commit-queue and temporarily disable testing on commit-queue
https://bugs.webkit.org/show_bug.cgi?id=113979
Reviewed by Benjamin Poulain.
Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
- EWSTools/setup-commit-queue.sh:
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTask.run):
- 6:32 PM WebKit Team edited by
- Updates yosin@'s knowledge area (diff)
- 6:29 PM Changeset in webkit [147694] by
-
- 2 edits in trunk/Source/WebCore
Work around a bug in the bindings generation script.
- WebCore.xcodeproj/project.pbxproj:
- 6:25 PM Changeset in webkit [147693] by
-
- 4 edits in trunk/Source/WebCore
Don't dispatch delayed click if snapshotted plugin was triggered by a click on the label
https://bugs.webkit.org/show_bug.cgi?id=113982
Reviewed by Tim Horton.
We regressed the way clicks were sent on to restarted plugins when we moved to a
Shadow Root - we were always sending the click. We should only send the click
on if the user clicked on the main plugin content, and not send it when you
click directly on the label.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Keep a reference to the container and label.
(WebCore::HTMLPlugInImageElement::partOfSnapshotLabel): New method that detects if a Node was part
of the snapshot label.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Only record the event if you should forward it on.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): New parameter to userDidClickSnapshot and member variables for shadow content.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::handleEvent): Ask the plugin if the clicked target was the snapshot label.
- 5:59 PM Changeset in webkit [147692] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed EFL build fix.
Add missing include for FloatRect.h.
- platform/efl/PlatformScreenEfl.cpp:
- 5:54 PM Changeset in webkit [147691] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
- platform/graphics/GlyphPageTreeNode.cpp:
- 5:44 PM Changeset in webkit [147690] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed EFL build fix.
We had undefined reference to `JSC::CodeOrigin::maximumBytecodeIndex'.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::findClosureCallForReturnPC):
(JSC::CodeBlock::bytecodeOffset):
- 5:37 PM Changeset in webkit [147689] by
-
- 3 edits in trunk/Source/WebCore
Another build fix.
- platform/graphics/FontCache.cpp:
- platform/graphics/SimpleFontData.cpp:
- 5:28 PM Changeset in webkit [147688] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- WebCore.xcodeproj/project.pbxproj:
- 5:26 PM Changeset in webkit [147687] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Adjust fatfinger result priority
https://bugs.webkit.org/show_bug.cgi?id=113957
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-04
Reviewed by Rob Buis.
RIM PR 224781
Internally Reviewed by Genevieve Mak.
Change fatfigner algorithm, return the clickable element rather than
its parent anchor. Modify taphighlight and context menu node selection
accordingly.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::findBestPoint):
- WebKitSupport/FatFingers.h:
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::elementForTapHighlight):
- 5:15 PM Changeset in webkit [147686] by
-
- 2 edits in trunk/Source/WebCore
Removed empty files from the build
https://bugs.webkit.org/show_bug.cgi?id=113978
Reviewed by Anders Carlsson.
Anders made a list of all the empty files that are slowing down the Mac
build, and I grepped them away.
- WebCore.xcodeproj/project.pbxproj:
- 5:08 PM Changeset in webkit [147685] by
-
- 2 edits in trunk/Tools
temporarily make flakiness dashboard work again webkit.org bots
https://bugs.webkit.org/show_bug.cgi?id=113972
Reviewed by Ojan Vafai.
This patch disables the chromium.org layout test bots TestExpectations
parsing temporarily until we can work out the right way to split into
two instances for webkit.org and chromium.org and figure out which
code to delete where :).
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- 5:08 PM Changeset in webkit [147684] by
-
- 42 edits1 copy1 add in trunk/Source/WebCore
Prune unneeded header #includes
https://bugs.webkit.org/show_bug.cgi?id=113973
Reviewed by Geoffrey Garen.
Reduce the amount of headers included by other headers by:
- Moving implicit and explicit constructors and destructors into .cpp files so member variable constructors/destructors don't have to be declared.
- Move CachedResourceClient subclasses out into separate headers so that their respective CachedResource subclasses don't have to be included by the classes that derive from those subclasses.
- Remove headers that were never needed in the first place.
- Modules/webaudio/AudioContext.h:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
- css/CSSFontFaceSource.h:
- html/canvas/CanvasPattern.cpp:
(WebCore::CanvasPattern::create):
(WebCore::CanvasPattern::CanvasPattern):
(WebCore::CanvasPattern::~CanvasPattern):
- html/canvas/CanvasPattern.h:
(WebCore::CanvasPattern::pattern):
(WebCore::CanvasPattern::originClean):
- html/parser/HTMLScriptRunner.h:
- loader/ImageLoader.h:
- loader/LinkLoader.h:
- loader/TextTrackLoader.h:
- loader/cache/CachedFont.cpp:
- loader/cache/CachedFont.h:
- loader/cache/CachedFontClient.h: Added.
(WebCore::CachedFontClient::~CachedFontClient):
(WebCore::CachedFontClient::expectedType):
(WebCore::CachedFontClient::resourceClientType):
(WebCore::CachedFontClient::fontLoaded):
- loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::setResource):
- loader/cache/CachedResourceHandle.h:
(WebCore::CachedResourceHandleBase::get):
(WebCore::CachedResourceHandleBase::operator!):
(WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
(WebCore::CachedResourceHandleBase::operator=):
(WebCore::CachedResourceHandle::CachedResourceHandle):
(WebCore::CachedResourceHandle::get):
(WebCore::CachedResourceHandle::operator->):
(WebCore::CachedResourceHandle::operator=):
(WebCore::CachedResourceHandle::operator==):
(WebCore::CachedResourceHandle::operator!=):
(WebCore::operator==):
(WebCore::operator!=):
- loader/cache/CachedSVGDocument.h:
- loader/cache/CachedSVGDocumentReference.h:
- loader/cache/CachedSVGDocumentClient.h: Added.
(WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::expectedType):
(WebCore::CachedSVGDocumentClient::resourceClientType):
- loader/cache/CachedStyleSheetClient.h:
- platform/PlatformScreen.h:
- platform/audio/HRTFElevation.cpp:
- platform/audio/HRTFKernel.cpp:
(WebCore::HRTFKernel::fftSize):
- platform/audio/HRTFKernel.h:
- platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::~ReverbConvolverStage):
- platform/audio/ReverbConvolverStage.h:
- platform/graphics/FontPlatformData.h:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/Path.cpp:
- platform/graphics/Path.h:
- platform/graphics/Pattern.cpp:
- platform/graphics/Pattern.h:
- platform/graphics/filters/FilterOperation.cpp:
(WebCore::ReferenceFilterOperation::ReferenceFilterOperation):
(WebCore::ReferenceFilterOperation::~ReferenceFilterOperation):
(WebCore::ReferenceFilterOperation::setCachedSVGDocumentReference):
- platform/graphics/filters/FilterOperation.h:
- platform/graphics/transforms/AffineTransform.h:
- plugins/DOMMimeType.h:
- rendering/RenderLayerFilterInfo.h:
- rendering/style/StyleCachedShader.h:
- svg/SVGFEImageElement.h:
- svg/SVGFontFaceUriElement.h:
- svg/SVGUseElement.h:
- xml/parser/XMLDocumentParser.h:
- 4:59 PM Changeset in webkit [147683] by
-
- 7 edits in trunk/Source
[Cairo] Stop passing raw pointers to BitmapImage::create()
https://bugs.webkit.org/show_bug.cgi?id=113945
Reviewed by Martin Robinson.
Source/WebCore:
BitmapImage::create() was updated in r147643 to take a PassRefPtr<cairo_surface_t>
in argument instead of a cairo_surface_t*. This patch updates several call sites
so that they now pass in a smart pointer instead of a raw one to avoid silent
converting from cairo_surface_t* to PassRefPtr<cairo_surface_t>.
No new tests, no behavior change.
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData): Use RefPtr to m_surface to avoid manual
memory handling.
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::~ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
- platform/graphics/cairo/ImageBufferDataCairo.h:
(ImageBufferData):
- platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(ImageGStreamer::ImageGStreamer):
- platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
Source/WebKit2:
Pass a smart pointer in to BitmapImage::create() instead of a raw one
for the cairo surface. The factory method prototype was updated for
cairo in r147643.
- Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit::ShareableBitmap::createImage):
- 4:57 PM Changeset in webkit [147682] by
-
- 4 edits2 adds in trunk
Page content missing when flipping from an empty layer to a tiled layer
https://bugs.webkit.org/show_bug.cgi?id=113977
<rdar://problem/13444219>
Source/WebCore:
Reviewed by Tim Horton.
Some articles on USA Today were missing content on load, when a large GraphicsLayer
which did not draw content needed to draw content (and become tiled in the process).
The bug was an ordering dependency in GraphicsLayerCA::commitLayerChangesBeforeSublayers().
swapFromOrToTiledLayer() sets some dirty flags, but for some properties which have
already been committed in the current flush cycle.
Fix by moving the swapFromOrToTiledLayer() to the top of the commit, which is
safe since it only consults GraphicsLayer properties, not CALayer properties.
Test: compositing/tiling/empty-to-tiled.html
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateContentsScale):
- platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
LayoutTests:
Reviewed by Tim Horton.
Ref test that adds visible content to a larger layer.
- compositing/tiling/empty-to-tiled-expected.html: Added.
- compositing/tiling/empty-to-tiled.html: Added.
- 4:56 PM Changeset in webkit [147681] by
-
- 2 edits in trunk/Source/WebCore
Regression(r147639) Causes assertion hit in HashTable
https://bugs.webkit.org/show_bug.cgi?id=113954
Reviewed by Benjamin Poulain.
Lookup the key in the hash table again after the recursive call to
getCachedFontPlatformData() as it may have altered the hash map and
invalidated the previous iterator we had.
No new tests, covered by existing tests.
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::getCachedFontPlatformData):
- 4:52 PM Changeset in webkit [147680] by
-
- 2 edits in trunk/Tools
Fix webkitpy tests after r147678.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(CommitQueueTest.test_commit_queue):
(test_manual_reject_during_processing):
- 4:35 PM Changeset in webkit [147679] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, fix a test and some results missed in r147675
- media/media-captions-expected.txt:
- media/video-controls-captions-trackmenu-localized.html:
- platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
- 4:18 PM Changeset in webkit [147678] by
-
- 2 edits1 add in trunk/Tools
The commit queue should use Mac MountainLion port
https://bugs.webkit.org/show_bug.cgi?id=113971
Reviewed by Lucas Forschler.
- EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
- Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue):
- 4:16 PM Changeset in webkit [147677] by
-
- 5 edits in trunk/Source/JavaScriptCore
Stop pretending that statements return a value
https://bugs.webkit.org/show_bug.cgi?id=113969
Reviewed by Oliver Hunt.
Expressions have an intrinsic value, which they return to their parent
in the AST.
Statements just execute for effect in sequence.
This patch moves emitBytecode into the ExpressionNode and StatementNode
subclasses, and changes the SatementNode subclass to return void. This
eliminates some cruft where we used to return 0, or try to save a bogus
register and return it, as if a statement had a consuming parent in the
AST.
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitNode):
(BytecodeGenerator):
(JSC::BytecodeGenerator::emitNodeInConditionContext):
- bytecompiler/NodesCodegen.cpp:
(JSC::ConstStatementNode::emitBytecode):
(JSC::BlockNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::CaseClauseNode::emitBytecode):
(JSC::CaseBlockNode::emitBytecodeForBlock):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ScopeNode::emitStatementsBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
(JSC::FuncDeclNode::emitBytecode):
- parser/NodeConstructors.h:
(JSC::PropertyListNode::PropertyListNode):
(JSC::ArgumentListNode::ArgumentListNode):
- parser/Nodes.h:
(Node):
(ExpressionNode):
(StatementNode):
(ConstStatementNode):
(BlockNode):
(EmptyStatementNode):
(DebuggerStatementNode):
(ExprStatementNode):
(VarStatementNode):
(IfNode):
(IfElseNode):
(DoWhileNode):
(WhileNode):
(ForNode):
(ForInNode):
(ContinueNode):
(BreakNode):
(ReturnNode):
(WithNode):
(LabelNode):
(ThrowNode):
(TryNode):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):
(FuncDeclNode):
(CaseBlockNode):
(SwitchNode):
- 3:57 PM Changeset in webkit [147676] by
-
- 2 edits in trunk/LayoutTests
Make fast/events/tabindex-focus-blur-all.html disallow Java so the test runs the same regardless of platform/port
https://bugs.webkit.org/show_bug.cgi?id=113950
Patch by Dave Michael <dmichael@chromium.org> on 2013-04-04
Reviewed by Jer Noble.
This hopefully fixes the test failure seen on Apple Mountain Lion WK2:
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r147640%20(7636)/results.html
that was introduced in https://bugs.webkit.org/show_bug.cgi?id=32292
- fast/events/resources/tabindex-focus-blur-all.js: Make the test disallow Java execution. Otherwise, <applet> is focusible on platforms that support Java by default and not focusible elsewhere.
- 3:23 PM Changeset in webkit [147675] by
-
- 35 edits in trunk
[Mac] add "automatic" text track menu item
https://bugs.webkit.org/show_bug.cgi?id=113822
Reviewed by Jer Noble.
Source/WebCore:
No new tests, existing tests updated.
- English.lproj/Localizable.strings: Add new track menu item.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_captionDisplayMode.
(WebCore::HTMLMediaElement::finishParsingChildren): LoadTextTrackResource -> ConfigureTextTracks.
(WebCore::HTMLMediaElement::scheduleDelayedAction): Ditto.
(WebCore::HTMLMediaElement::loadTimerFired): Ditto.
(WebCore::HTMLMediaElement::loadInternal): Ditto. Flag the caption menu as invalid so it will
be rebuilt again.
(WebCore::HTMLMediaElement::mediaPlayerDidAddTrack): LoadTextTrackResource -> ConfigureTextTracks.
(WebCore::HTMLMediaElement::didAddTrack): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Deal with new track display modes.
(WebCore::HTMLMediaElement::HTMLMediaElement::hasClosedCaptions): Minor cleanup.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Add some logging.
(WebCore::HTMLMediaElement::configureTextTracks): Call updateActiveTextTrackCues so cue display
is updated.
(WebCore::HTMLMediaElement::captionPreferencesChanged): Deal with new track display modes.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Add some logging.
- html/HTMLMediaElement.h: Ditto.
- html/shadow/MediaControlElementTypes.cpp: Remove trackIndexAttributeName and trackListIndexForElement.
- html/shadow/MediaControlElementTypes.h: Ditto.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Don't use track index,
everything we need is in the track<->element map now.
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Ditto. Always rebuild the
track list because clear the map each time the menu goes away because it refs every track.
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Don't set the track
index attribute on the menu items, just use the map.
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::changedClosedCaptionsVisibility): resetTrackListMenu is gone.
(WebCore::MediaControlsApple::reset): Ditto.
(WebCore::MediaControlsApple::closedCaptionTracksChanged): Ditto.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::captionMenuOffItem): New, static TextTrack used for the menu "Off" item.
(WebCore::TextTrack::captionMenuAutomaticItem): New, static TextTrack used for the menu "Automatic" item.
- html/track/TextTrack.h:
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::shouldShowCaptions): Removed, we use captionDisplayMode instead.
(WebCore::CaptionUserPreferences::captionDisplayMode): New.
(WebCore::CaptionUserPreferences::setCaptionDisplayMode): New.
(WebCore::CaptionUserPreferences::setPreferredLanguage): Make the parameter a const reference.
(WebCore::CaptionUserPreferences::textTrackSelectionScore): Return 0 if the user doesn't want
captions or subtitles.
(WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Take language as a parameter
instead of assuming that it is always the entire language list.
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMac.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::shouldShowCaptions): Removed, we use captionDisplayMode instead.
(WebCore::CaptionUserPreferencesMac::captionDisplayMode): New.
(WebCore::CaptionUserPreferencesMac::setCaptionDisplayMode): New.
(WebCore::CaptionUserPreferencesMac::setPreferredLanguage): Make the parameter a const reference.
(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Deal with "Automatic" mode.
captions or subtitles.
(WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Take language as a parameter
instead of assuming that it is always the entire language list.
(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): Insert "Off" and "Automatic" items.
- platform/LocalizedStrings.cpp:
(WebCore::textTrackAutomaticMenuItemText): New.
- platform/LocalizedStrings.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::languageOfPrimaryAudioTrack): New.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Return the language
of the main audio track.
LayoutTests:
- media/media-captions.html: Opportunistic fix - don't look at state until we get the 'canplaythrough'
event because the media engine state may not have been processed until that time.
- media/track/track-cue-container-rendering-position.html: Don't assume that a cue has been
rendered immediately when the 'canplaythrough' event comes through.
- media/track/track-cue-rendering-mode-changed.html: Ditto.
- media/track/track-in-band-expected.txt: Don't check if cues have loaded, it doesn't matter
for this test.
- media/track/track-in-band.html: Ditto.
- media/track/track-user-preferences-expected.txt: Changed name of utility function from
menuIndexForLanguage to indexOfMenuItemBeginningWith.
- media/track/track-user-preferences.html: Move menuIndexForLanguage to trackmenu-test.js and
change name to indexOfMenuItemBeginningWith. Clarify the message logged when a track loads
but it should not.
- media/trackmenu-test.js: Move some functions here from track-user-preferences.html
(trackMenuList):
(indexOfMenuItemBeginningWith):
(selectCaptionMenuItem):
- media/video-controls-captions-trackmenu-sorted.html: Update for new menu item.
- media/video-controls-captions-trackmenu.html: Ditto.
- platform/mac/media/video-controls-captions-trackmenu-expected.txt: Ditto.
- platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt: Ditto.
- 3:20 PM Changeset in webkit [147674] by
-
- 1 edit3 deletes in trunk/LayoutTests
[EFL] Unreviewed gardening. Rebaseline after r147588. Remove overridden pixel results.
- platform/efl/fast/text/international/003-expected.png: Removed.
- platform/efl/fast/text/international/text-combine-image-test-expected.png: Removed.
- platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Removed.
- 3:01 PM Changeset in webkit [147673] by
-
- 1 edit6 adds in trunk/LayoutTests
[EFL] Unreviewed gardening. Rebaseline after r147588. Update pixel expectations.
- platform/efl-wk1/fast/text/international/003-expected.png: Added.
- platform/efl-wk1/fast/text/international/text-combine-image-test-expected.png: Added.
- platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
- platform/efl-wk2/fast/text/international/003-expected.png: Added.
- platform/efl-wk2/fast/text/international/text-combine-image-test-expected.png: Added.
- platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
- 2:57 PM Changeset in webkit [147672] by
-
- 2 edits in trunk/Tools
turn off running tests on chromium linux EWS bots
https://bugs.webkit.org/show_bug.cgi?id=113959
Reviewed by Geoffrey Garen.
Now that the Chromium port is no longer being maintained
there's little point in running the tests. Soon we should
just shut this bot off altogether.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(ChromiumLinuxEWS):
- 2:57 PM Changeset in webkit [147671] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r146580): Assertion using SecurityOrigin::create, URL string is not valid
https://bugs.webkit.org/show_bug.cgi?id=113961
Reviewed by Geoff Garen.
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::createFromDatabaseIdentifier): (WebCore::SecurityOrigin::create): Don't use ParsedURLString, because http://host:80/ is normalized to http://host/, so it's not a parsed URL string.
- 2:25 PM Changeset in webkit [147670] by
-
- 4 edits3 adds in trunk
Exception stack unwinding doesn't handle inline callframes correctly
https://bugs.webkit.org/show_bug.cgi?id=113952
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
The basic problem here is that the exception stack unwinding was
attempting to be "clever" and avoid doing a correct stack walk
as it "knew" inline callframes couldn't have exception handlers.
This used to be safe as the exception handling machinery was
designed to fail gently and just claim that no handler existed.
This was "safe" and even "correct" inasmuch as we currently
don't run any code with exception handlers through the dfg.
This patch fixes the logic by simply making everything uniformly
use the safe stack walking machinery, and making the correct
boundary checks occur everywhere that they should.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::findClosureCallForReturnPC):
(JSC::CodeBlock::bytecodeOffset):
- interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::retrieveCallerFromVMCode):
LayoutTests:
Yay tests!
- fast/js/js-correct-exception-handler-expected.txt: Added.
- fast/js/js-correct-exception-handler.html: Added.
- fast/js/script-tests/js-correct-exception-handler.js: Added.
(throwEventually):
(f.g):
(f):
(test):
- 2:16 PM Changeset in webkit [147669] by
-
- 2 edits in trunk/Source/JavaScriptCore
Removed a defunct comment
https://bugs.webkit.org/show_bug.cgi?id=113948
Reviewed by Oliver Hunt.
This is also a convenient way to test the EWS.
- bytecompiler/BytecodeGenerator.cpp:
(JSC):
- 2:08 PM Changeset in webkit [147668] by
-
- 1 edit7 adds3 deletes in trunk/LayoutTests
[EFL] Unreviewed gardening. Rebaseline after r147588.
- platform/efl-wk1/fast/text/international: Added.
- platform/efl-wk1/fast/text/international/003-expected.txt: Added.
- platform/efl-wk1/fast/text/international/text-combine-image-test-expected.txt: Added.
- platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
- platform/efl-wk2/fast/text/international/003-expected.txt: Added.
- platform/efl-wk2/fast/text/international/text-combine-image-test-expected.txt: Added.
- platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
- platform/efl/fast/text/international/003-expected.txt: Removed.
- platform/efl/fast/text/international/text-combine-image-test-expected.txt: Removed.
- platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
- 1:52 PM Changeset in webkit [147667] by
-
- 5 edits in trunk
Unreviewed, rolling out r147662.
http://trac.webkit.org/changeset/147662
https://bugs.webkit.org/show_bug.cgi?id=113955
The change r147662 breaks fast/regions/fixed-pos-elem-in-
region.html (Requested by benjaminp on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-04
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth):
LayoutTests:
- fast/inline/inline-with-empty-inline-children-expected.txt:
- fast/inline/inline-with-empty-inline-children.html:
- 1:46 PM Changeset in webkit [147666] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. AppleWin port gardening.
- platform/win/TestExpectations:
- 1:19 PM Changeset in webkit [147665] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. AppleWin port gardening.
- platform/win/TestExpectations:
- platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- 12:58 PM Changeset in webkit [147664] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r147373): Auto-sizing doesn't always respect minimum width changes
https://bugs.webkit.org/show_bug.cgi?id=113947
<rdar://problem/13579024>
Reviewed by Anders Carlsson.
Reset the FrameView size to the minimum auto-sizing size
before performing auto-sizing. We were already resetting the height,
but not the width, instead using the FrameView's current width.
This means that changing the minimum width without also manually
resizing the FrameView will never see the width change.
Auto-sizing tests are not working on Mac yet.
- page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):
- 12:26 PM Changeset in webkit [147663] by
-
- 5 edits12 deletes in trunk/Source
[GTK] Remove the gyp build
https://bugs.webkit.org/show_bug.cgi?id=113942
Reviewed by Gustavo Noronha Silva.
Source/JavaScriptCore:
- JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Removed.
- JavaScriptCore.gyp/redirect-stdout.sh: Removed.
Source/ThirdParty/ANGLE:
- ANGLE.gyp/ANGLE.gyp: Removed.
- ANGLE.gypi: Removed.
Source/WebCore:
- WebCore.gyp/WebCoreGTK.gyp: Removed.
Source/WebKit/gtk:
- gyp/Configuration.gypi.in: Removed.
- gyp/Dependencies.gyp: Removed.
- gyp/GNUmakefile: Removed.
- gyp/autogen.sh: Removed.
- gyp/configure.ac: Removed.
- gyp/run-gyp: Removed.
Source/WTF:
- WTF.gyp/WTFGTK.gyp: Removed.
- 12:23 PM Changeset in webkit [147662] by
-
- 5 edits in trunk
REGRESSION(r142152): Text wraps in menu
https://bugs.webkit.org/show_bug.cgi?id=113706
Reviewed by David Hyatt.
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth): Empty inline elements add their inline border/padding/margin to the width of the
line when we iterate through them in nextLineBreak(), so no need to add them again here when climbing back up
from their first child looking for border/padding/margin to add. (An empty inline element can have floating children.)
LayoutTests:
- fast/inline/inline-with-empty-inline-children-expected.txt:
- fast/inline/inline-with-empty-inline-children.html:
- 12:15 PM Changeset in webkit [147661] by
-
- 2 edits in trunk/Source/WebCore
Changing typing style with font size delta overrides the previous font size delta
https://bugs.webkit.org/show_bug.cgi?id=113923
Reviewed by Andreas Kling.
The bug was caused by a new font size delta value overriding the old one as
opposed to being added to the old value. Fixed that in overrideWithStyle.
Also made overrideWithStyle share code with mergeStyle since there is already
code to merge text-decorations there.
Unfortunately, adding a test for this fix proved to be hard because we don't
expose any API to directly set typing style.
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::overrideWithStyle): Use mergeStyle.
(WebCore::EditingStyle::mergeStyle): Add font size deltas as opposed to simply
using the new value.
- 12:05 PM Changeset in webkit [147660] by
-
- 4 edits2 adds in trunk
AX:File upload button has wrong label
https://bugs.webkit.org/show_bug.cgi?id=113924
Reviewed by David Kilzer.
Source/WebCore:
Allow the label and value to be returned for file upload controls on iOS.
Due to the different AX APIs, we can expose a bit more information on iOS.
Test: platform/iphone-simulator/accessibility/file-upload-button.html
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper stringValueShouldBeUsedInLabel]):
(-[WebAccessibilityObjectWrapper fileUploadButtonReturnsValueInTitle]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase fileUploadButtonReturnsValueInTitle]):
(-[WebAccessibilityObjectWrapperBase accessibilityTitle]):
LayoutTests:
- platform/iphone-simulator/accessibility/file-upload-button-expected.txt: Added.
- platform/iphone-simulator/accessibility/file-upload-button.html: Added.
- 11:52 AM Changeset in webkit [147659] by
-
- 8 edits in trunk/Source
Expose settings to disable plugin snapshotting autostart and primary detection
https://bugs.webkit.org/show_bug.cgi?id=113918
Reviewed by Tim Horton.
Source/WebCore:
Three new settings:
- snapshotAllPlugIns: Do not apply any heuristics - immediately snapshot a plugin.
- primaryPlugInSnapshotDetectionEnabled: Toggle snapshotting the "main" plugin in the page.
- autostartOriginPlugInSnapshottingEnabled: Toggle snapshotting based on URL origins.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Don't tell the host that we've started
if the autostartOriginPlugInSnapshottingEnabled is false.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Don't restart a primary
plugin if primaryPlugInSnapshotDetectionEnabled is false.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Snapshot immediately if
snapshotAllPlugIns is true. Also, don't test for autostart if
autostartOriginPlugInSnapshottingEnabled is false.
- page/Settings.in: Three new settings values.
Source/WebKit2:
Three new settings: snapshotAllPlugIns, primaryPlugInSnapshotDetectionEnabled and
autostartOriginPlugInSnapshottingEnabled.
These are exposed via WKPreferences (WebKit2 only, since that's the only port actively
using the feature).
- Shared/WebPreferencesStore.h: Add macros for new settings.
- UIProcess/API/C/WKPreferences.cpp: Getters and setters for new settings.
(WKPreferencesSetSnapshotAllPlugIns):
(WKPreferencesGetSnapshotAllPlugIns):
(WKPreferencesSetAutostartOriginPlugInSnapshottingEnabled):
(WKPreferencesGetAutostartOriginPlugInSnapshottingEnabled):
(WKPreferencesSetPrimaryPlugInSnapshotDetectionEnabled):
(WKPreferencesGetPrimaryPlugInSnapshotDetectionEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Forward settings updates.
(WebKit::WebPage::addPluginView): Don't run primary plugin detection if the setting is false.
(WebKit::WebPage::didFinishLoad): Ditto.
- 11:31 AM Changeset in webkit [147658] by
-
- 4 edits in trunk/Source/JavaScriptCore
Simplified bytecode generation by merging prefix and postfix nodes
https://bugs.webkit.org/show_bug.cgi?id=113925
Reviewed by Filip Pizlo.
PostfixNode now inherits from PrefixNode, so when we detect that we're
in a context where postifx and prefix are equivalent, PostFixNode can
just call through to PrefixNode codegen, instead of duplicating the
logic.
- bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitResolve):
(JSC::PostfixNode::emitBracket):
(JSC::PostfixNode::emitDot):
- parser/NodeConstructors.h:
(JSC::PostfixNode::PostfixNode):
- parser/Nodes.h:
(JSC):
(PrefixNode):
(PostfixNode):
- 11:25 AM Changeset in webkit [147657] by
-
- 2 edits in trunk/Tools
Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
- Scripts/webkitpy/common/config/watchlist:
- 11:22 AM Changeset in webkit [147656] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-win-xp
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:22 AM Changeset in webkit [147655] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-win
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:22 AM Changeset in webkit [147654] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Remove skia code from PluginViewBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=113936
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-04
Reviewed by Rob Buis.
Skia is not used anymore by the BlackBerry port.
- plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::paint):
- 11:22 AM Changeset in webkit [147653] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-mac-snowleopard
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147652] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-mac-mountainlion
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147651] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-mac-lion
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147650] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-mac
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147649] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-linux-x86
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147648] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-linux
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147647] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-android
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:17 AM Changeset in webkit [147646] by
-
- 1 delete in trunk/LayoutTests/platform/chromium
Removed Chromium layout test results.\n\nReviewed by Anders Carlsson.\n\nI'm using a direct svn http command to try to reduce email traffic.
- 11:10 AM Changeset in webkit [147645] by
-
- 3 edits2 adds in trunk
Source/WebCore: Change RenderFrameSet::computeEdgeInfo to use m-rows/m_cols directly
https://bugs.webkit.org/show_bug.cgi?id=113825
Reviewed by Eric Seidel.
Tests: fast/frames/invalid-frameset-compute-edge.html
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::computeEdgeInfo):
LayoutTests: Change RenderFrameSet::computeEdgeInfo to use m-rows/m_cols directly
https://bugs.webkit.org/show_bug.cgi?id=113825
Reviewed by Eric Seidel.
Add test for accessing an invalid frame.
- fast/frames/invalid-frameset-compute-edge-expected.html: Added.
- fast/frames/invalid-frameset-compute-edge.html: Added.
- 11:00 AM Changeset in webkit [147644] by
-
- 2 edits in trunk/Source/WebCore
[GTK][AC] Invalid clear ClutterContent of ClutterActor
https://bugs.webkit.org/show_bug.cgi?id=113758
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-04
Reviewed by Gustavo Noronha Silva.
Using clutter_actor_set_content(actor, 0) is better to clear ClutterContent of ClutterActor.
Actually the ClutterContent referece is cleared in the API if we set 0.
No new tests since no functionality changed.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorUpdateTexture):
- 10:59 AM Changeset in webkit [147643] by
-
- 37 edits4 adds2 deletes in trunk
[Cairo] Fix canvas drawing of SVG-based patterns and remove NativeImageCairo
https://bugs.webkit.org/show_bug.cgi?id=113929
Reviewed by Martin Robinson.
Source/WebCore:
Make (Pass)NativeImagePtr typedefs to (Pass)RefPtr<cairo_surface_t> instead
of NativeImageCairo*. Now that we switch to using smart pointers,
NativeImageCairo is removed as it made no sense to make it ref counted when
it merely held a single ref counted member.
Now that Cairo is using smart pointers for (Pass)NativeImagePtr, this patch
also enables the implementation of SVGImage::nativeImageForCurrentFrame()
for USE(CAIRO) as well. This effectively fixes canvas drawing of SVG-based
patterns for Cairo-based ports.
No new tests, covered by svg/canvas/canvas-pattern-svg.html.
- GNUmakefile.list.am: Remove NativeImageCairo.* for GTK.
- PlatformEfl.cmake: Remove NativeImageCairo.* for EFL.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
Remove NativeImageCairo.* for Win.
- platform/graphics/BitmapImage.cpp:
(WebCore::FrameData::reportMemoryUsage):
Update MemoryClassInfo::addRawBuffer() call now that m_frame is a RefPtr
for USE(CAIRO).
- platform/graphics/BitmapImage.h:
(BitmapImage):
Remove factory method taking a cairo_surface_t* in argument. This is useless
now that PassNativeImagePtr is a typedef to PassRefPtr<cairo_surface_t> and
there is already a factory method taking a PassNativeImagePtr in argument.
- platform/graphics/NativeImagePtr.h:
(WebCore):
Make PassNativeImagePtr a typedef to PassRefPtr<cairo_surface_t> and
NativeImagePtr a typedef to RefPtr<cairo_surface_t>, instead of
NativeImageCairo*. Moving to smart pointers is needed to enable implementation
of SVGImage::nativeImageForCurrentFrame() for Cairo.
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::FrameData::clear):
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/cairo/ImageCairo.cpp:
(WebCore::Image::drawPattern):
Update Cairo graphics code to reflect the (Pass)NativeImagePtr type changes.
- platform/graphics/cairo/NativeImageCairo.cpp: Removed.
- platform/graphics/cairo/NativeImageCairo.h: Removed.
- platform/graphics/cairo/PatternCairo.cpp:
(WebCore::Pattern::createPlatformPattern):
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/efl/ImageEfl.cpp:
(WebCore::BitmapImage::getEvasObject):
- platform/graphics/gtk/ImageGtk.cpp:
(WebCore::BitmapImage::getGdkPixbuf):
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
- platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::create):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
- platform/gtk/DragImageGtk.cpp:
(WebCore::createDragImageFromImage):
- platform/image-decoders/cairo/ImageDecoderCairo.cpp:
(WebCore::ImageFrame::asNewNativeImage):
- platform/win/DragImageCairoWin.cpp:
(WebCore::createDragImageFromImage):
Update code to reflect the (Pass)NativeImagePtr type changes.
- svg/graphics/SVGImage.cpp:
(WebCore):
- svg/graphics/SVGImage.h:
Enable SVGImage::nativeImageForCurrentFrame() for USE(CAIRO).
Source/WebKit:
Remove outdated symbols now that NativeImageCairo was removed.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/efl:
Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
instead of NativeImageCairo*.
- ewk/ewk_history.cpp:
(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):
- ewk/ewk_settings.cpp:
(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_get):
Source/WebKit/gtk:
Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
instead of NativeImageCairo*.
- webkit/webkitfavicondatabase.cpp:
(getIconPixbufSynchronously):
Source/WebKit/win:
Remove outdated symbols now that NativeImageCairo was removed.
- WebKit.vcproj/WebKitExports.def.in:
Source/WebKit2:
Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
instead of NativeImageCairo*.
- Shared/gtk/ArgumentCodersGtk.cpp:
(CoreIPC::decodeImage):
- UIProcess/API/C/cairo/WKIconDatabaseCairo.cpp:
(WKIconDatabaseTryGetCairoSurfaceForURL):
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(getIconSurfaceSynchronously):
LayoutTests:
Add EFL / GTK pixels results for svg/canvas/canvas-pattern-svg.html now that
the test passes for cairo-based ports.
- platform/efl/svg/canvas/canvas-pattern-svg-expected.png: Added.
- platform/gtk/svg/canvas/canvas-pattern-svg-expected.png: Added.
- 10:48 AM Changeset in webkit [147642] by
-
- 2 edits in trunk/Source/WebCore
[EFL] --minimal build fails with 'error: unused variable'
https://bugs.webkit.org/show_bug.cgi?id=113903
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-04
Reviewed by Gustavo Noronha Silva.
Moved variable definition under #if where it's used
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::restartedCallback):
- 10:30 AM Changeset in webkit [147641] by
-
- 2 edits in trunk/Source/WTF
ObjcRuntimeExtras.h should use variadic templates
https://bugs.webkit.org/show_bug.cgi?id=113941
Reviewed by Andreas Kling.
Reimplement wtfObjcMsgSend and wtfCallIMP as variadic function templates.
- wtf/ObjcRuntimeExtras.h:
(wtfObjcMsgSend):
(wtfCallIMP):
- 9:40 AM Changeset in webkit [147640] by
-
- 4 edits in trunk/Source
Fix the build with GCC 4.8
https://bugs.webkit.org/show_bug.cgi?id=113147
Reviewed by Allan Sandfeld Jensen.
Source/JavaScriptCore:
Initialize JSObject* exception to suppress warnings that make
the build fail because of -Werror=maybe-uninitialized.
- runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
Source/WTF:
Disable diagnostic warning -Wunused-local-typedefs for GCC 4.8
since dummy typedefs are commonly used in the codebase.
- wtf/Compiler.h:
- 9:37 AM Changeset in webkit [147639] by
-
- 12 edits in trunk/Source/WebCore
Global FontPlatformData cache should use OwnPtr.
<http://webkit.org/b/111939>
Reviewed by Anders Carlsson.
Let the global FontPlatformData use OwnPtr instead of raw pointers + deleteAllValues().
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::invalidate):
Tweaked code for OwnPtr. Also made getCachedFontPlatformData() do one hash lookup
instead of two.
- platform/graphics/FontCache.h:
- platform/graphics/blackberry/FontCacheBlackBerry.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/chromium/FontCacheAndroid.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/skia/FontCacheSkia.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/wince/FontCacheWinCE.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/wx/FontCacheWx.cpp:
(WebCore::FontCache::createFontPlatformData):
FontCache::createFontPlatformData() now returns a PassOwnPtr.
- 9:28 AM Changeset in webkit [147638] by
-
- 2 edits in trunk/Source/WebCore
Render images with low-quality scaling while FrameView is being resized.
<http://webkit.org/b/113764>
<rdar://problem/13555154>
Reviewed by Antti Koivisto.
Have ImageQualityController ask the renderer's containing FrameView if it's currently in live
resize, and if so, paint all images with low-quality scaling. A high-quality repaint will happen
~0.5 sec after live resizing ends, piggybacking on the same mechanism we use to do JS-animated
resizing with low-quality scaling.
This reduces CPU time spent generating new tiles during live window resize, especially on Retina
systems where a lot of upscaling happens on legacy web content.
- rendering/RenderBoxModelObject.cpp:
(ImageQualityController):
Added an m_liveResizeOptimizationIsActive flag that tracks whether the ImageQualityController
is painting everything in low quality due to live window resize. It gets unset when the HQ
repaint timer fires and everything has been repainted properly.
(WebCore::ImageQualityController::highQualityRepaintTimerFired):
When the HQ repaint timer fires, check if the renderer's containing FrameView is still in
live resize, and if so, abort HQ repaint for now and reschedule the timer.
(WebCore::ImageQualityController::ImageQualityController):
(WebCore::ImageQualityController::objectDestroyed):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
- 9:18 AM Changeset in webkit [147637] by
-
- 14 edits in trunk/Source
[Qt] docs: Fix module name format
https://bugs.webkit.org/show_bug.cgi?id=113209
Patch by Sze Howe Koh <szehowe.koh@gmail.com> on 2013-04-04
Reviewed by Jocelyn Turcotte.
Make QDoc-generated documentation follow the conventions at
http://qt-project.org/wiki/Spelling_Module_Names_in_Qt_Documentation
Source/WebKit/qt:
- Api/qwebdatabase.cpp:
- Api/qwebkitglobal.cpp:
- Api/qwebpluginfactory.cpp:
- Api/qwebsettings.cpp:
- WidgetApi/qgraphicswebview.cpp:
- WidgetApi/qwebframe.cpp:
- WidgetApi/qwebpage.cpp:
- WidgetApi/qwebview.cpp:
- docs/qtwebkit-bridge.qdoc:
- docs/qtwebkit-goes-mobile.qdoc:
- docs/qtwebkit.qdoc:
Source/WebKit2:
- UIProcess/API/qt/qquickwebview.cpp:
- 9:17 AM Changeset in webkit [147636] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix closure compiler warnings in IndexedDBModel.js
https://bugs.webkit.org/show_bug.cgi?id=113926
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-04
Reviewed by Alexander Pavlov.
No new tests: no change in behaviour.
- inspector/front-end/IndexedDBModel.js:
- 9:01 AM Changeset in webkit [147635] by
-
- 3 edits2 adds in trunk
REGRESSION (r145870): Can't get insertion point to appear in some input and textareas on wordpress
https://bugs.webkit.org/show_bug.cgi?id=113591
Patch by Xidorn Quan <quanxunzhen@gmail.com> on 2013-04-04
Reviewed by Simon Fraser.
Source/WebCore:
Since a child node could overflow its ancestor, it is not wise to check
one's radii boundary before checking whether the given point intersects
its children. This patch moves the related code down to fix the bug.
Test: fast/borders/border-radius-child.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
LayoutTests:
- fast/borders/border-radius-child-expected.txt: Added.
- fast/borders/border-radius-child.html: Added.
- 8:53 AM Changeset in webkit [147634] by
-
- 2 edits in trunk/Tools
Indentation fix to get webkit-patch working again after r147625
Unreviewed.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):
(MacWK2EWS):
- 8:32 AM Changeset in webkit [147633] by
-
- 2 edits in tags/Safari-537.35.8/Source/WebKit2
Merged r147592. <rdar://problem/13540351>
- 8:29 AM Changeset in webkit [147632] by
-
- 10 edits in tags/Safari-537.35.8/Source
Merged r147579. <rdar://problem/13478573>
- 8:26 AM Changeset in webkit [147631] by
-
- 2 edits in tags/Safari-537.35.8/Source/WebKit2
Merged r147500. <rdar://problem/13159030>
- 8:23 AM Changeset in webkit [147630] by
-
- 6 edits in tags/Safari-537.35.8/Source/WebKit2
Merged r147489. <rdar://problem/12679817>
- 8:20 AM Changeset in webkit [147629] by
-
- 13 edits2 copies in tags/Safari-537.35.8
Merged r147471. <rdar://problem/13522402>
- 8:15 AM Changeset in webkit [147628] by
-
- 4 edits in trunk
[GStreamer] Virtual modifier for MediaPlayer::simulateAudioInterruption must go
https://bugs.webkit.org/show_bug.cgi?id=113851
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-04-04
Reviewed by Eric Carlson.
.:
- Source/autotools/symbols.filter: Added
_ZN7WebCore11MediaPlayer25simulateAudioInterruptionEv symbol.
Source/WebCore:
- platform/graphics/MediaPlayer.h:
(MediaPlayer): Removed virtual modifier to
simulateAudioInterruption.
- 8:14 AM Changeset in webkit [147627] by
-
- 2 edits in tags/Safari-537.35.8/Source/JavaScriptCore
Merged r147079. <rdar://problem/13519289>
- 8:12 AM Changeset in webkit [147626] by
-
- 2 edits in tags/Safari-537.35.8/Source/JavaScriptCore
Merged r147017. <rdar://problem/13519289>
- 8:06 AM Changeset in webkit [147625] by
-
- 2 edits in trunk/Tools
Turn tests back on for Mac WK1/WK2 EWS.
Unreviewed.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):
(MacWK2EWS):
- 6:26 AM Changeset in webkit [147624] by
-
- 3 edits in trunk/Tools
[GTK][WK2] MiniBrowser custom URI scheme support
https://bugs.webkit.org/show_bug.cgi?id=112419
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-04
Reviewed by Carlos Garcia Campos.
Add support for about URIs in MiniBrowser. An example about page is show
with URI "about:minibrowser", the rest of the cases it will show a
proper message explaining that the about page didn't exist.
Internally it uses "minibrowser-about" prefix instead of "about", but
from the user point of view it works with "about" prefix.
- MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
(getInternalURI): Method to convert URIs from "about" prefix to
"minibrowser-about".
(getExternalURI): Opposite method.
(webViewURIChanged): Use "about" prefix to show the URI to users.
(webViewEnterFullScreen): Ditto.
(browser_window_load_uri): Use "minibrowser-about" prefix internally.
- MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
(aboutURISchemeRequestCallback): Callback to manage about calls.
(main): Register the URI scheme to manage about URIs.
- 6:20 AM Changeset in webkit [147623] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Support -webkit-font-smoothing
https://bugs.webkit.org/show_bug.cgi?id=106009
Reviewed by Jocelyn Turcotte.
Remove false dependency on Qt 5.1 for the -webkit-font-smoothing property.
For now we are still keeping the dependency on Font::shouldUseSmoothing().
- platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- 5:05 AM Changeset in webkit [147622] by
-
- 51 edits5 adds in trunk
Regression(r142765) Broke Custom SVG cursors and SVG canvas drawing for Chromium
https://bugs.webkit.org/show_bug.cgi?id=113420
Reviewed by Stephen White.
Source/WebCore:
Introduce a PassNativeImagePtr typedef that is used in place of NativeImagePtr
for method arguments and return values. This is needed as Skia now maps
NativeImagePtr to RefPtr<NativeImageSkia> and PassNativeImagePtr to
PassRefPtr<NativeImageSkia>. We move towards ref counted smart pointers so that
SVGImage::nativeImageForCurrentFrame() can transfer ownership of the native
image to the caller if needed (e.g. for SVGImage).
Provide nativeImageForCurrentFrame() implementation for SVGImage. SVGImage no
longer holds the native image internally, to save memory. It is therefore created
when nativeImageForCurrentFrame() is called and ownership is passed to the
caller. For now, this implementation is only enabled for Skia as others are using
raw pointers for PassNativeImagePtr.
Test: svg/canvas/canvas-pattern-svg.html
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousNativeIconForPageURL):
Return a PassNativeImagePtr instead of NativeImagePtr.
- loader/icon/IconDatabase.h:
(IconDatabase):
- loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::synchronousNativeIconForPageURL):
Return a PassNativeImagePtr instead of NativeImagePtr.
- platform/chromium/DragImageChromiumSkia.cpp:
(WebCore::createDragImageFromImage):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead of a raw
one.
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage):
Store return value of nativeImageForCurrentFrame() in a RefPtr<NativeImageSkia>
instead of a NativeImagePtr. While these are equivalent, the former is more
readable in Skia-specific code.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::frameAtIndex):
Return a PassNativeImagePtr instead of a NativeImagePtr.
(WebCore::BitmapImage::nativeImageForCurrentFrame):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::create):
Take a PassNativeImagePtr in argument instead of a NativeImagePtr.
(BitmapImage): Ditto.
- platform/graphics/GraphicsContext.h:
(GraphicsContext): Ditto.
- platform/graphics/GraphicsContext3D.h:
(ImageExtractor):
Keep NativeImageSkia in a RefPtr instead of OwnPtr, now that it is refcounted.
- platform/graphics/Image.h:
(WebCore::Image::nativeImageForCurrentFrame):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/ImageBuffer.h:
(ImageBuffer):
Have copyNativeImage() return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::createFrameAtIndex):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/ImageSource.h:
Have createFrameAtIndex() return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/NativeImagePtr.h:
Map NativeImagePtr to a RefPtr<NativeImageSkia> instead of NativeImageSkia* for Skia.
Introduce new PassNativeImagePtr that maps to PassRefPtr<NativeImageSkia> for Skia
and is equivalent to NativeImagePtr for other ports. We now use smart pointers for
the native image so that SVGImage::nativeImageForCurrentFrame() can pass ownership
of the native image to the caller, unlike BitmapImage::nativeImageForCurrentFrame().
- platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
(WebCore::BitmapImage::BitmapImage):
Take a PassNativeImagePtr instead of a NativeImagePtr in argument.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage): Ditto.
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::copyNativeImage):
Take a PassNativeImagePtr instead of a NativeImagePtr in argument.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToImage):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead of a raw one.
- platform/graphics/filters/skia/FEBlendSkia.cpp:
(WebCore::FEBlend::platformApplySkia): Ditto.
- platform/graphics/filters/skia/FEColorMatrixSkia.cpp:
(WebCore::FEColorMatrix::platformApplySkia): Ditto.
- platform/graphics/filters/skia/FEComponentTransferSkia.cpp:
(WebCore::FEComponentTransfer::platformApplySkia): Ditto.
- platform/graphics/filters/skia/FEDisplacementMapSkia.cpp:
(WebCore::FEDisplacementMap::platformApplySkia): Ditto.
- platform/graphics/filters/skia/FELightingSkia.cpp:
(WebCore::FELighting::platformApplySkia): Ditto.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::nativeImageForCurrentFrame):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/qt/StillImageQt.h:
(StillImage): Ditto.
- platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
No longer need to adopt the return value of asNewNativeImage() now
that it returns a PassRefPtr instead of a raw one.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
Call NativeImageSkia::create() factory method now that the constructor
is private.
- platform/graphics/skia/ImageSkia.cpp:
(WebCore::FrameData::clear):
Just call clear() on m_frame instead of explicitely deleting it now
that it is a RefPtr.
(WebCore::Image::drawPattern):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead
of a raw one.
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::checkForSolidColor):
Store return value of frameAtIndex() in a RefPtr instead of a raw one.
(WebCore::BitmapImage::draw):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead
of a raw one.
- platform/graphics/skia/NativeImageSkia.cpp:
Add new constructor taking all members in argument. This is used for
cloning a NativeImageSkia object.
(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::deepSkBitmapCopy):
Add convenience function to make a deep copy of a SkBitmap.
- platform/graphics/skia/NativeImageSkia.h:
(WebCore):
(WebCore::NativeImageSkia::create):
(NativeImageSkia):
Make NativeImageSkia subclass RefCounted. Make the constructor private
and add a factory method instead that returns a PassRefPtr.
(WebCore::NativeImageSkia::clone):
Add a clone() method now that NativeImageSkia is refcounted and is no
longer copyable.
- platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformPattern):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead
of a raw one.
- platform/graphics/wince/ImageWinCE.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/image-decoders/ImageDecoder.h:
(ImageFrame):
Have asNewNativeImage() return a PassNativeImagePtr instead of a
NativeImagePtr.
(WebCore::ImageFrame::getAddr):
(WebCore::ImageFrame::setSkBitmap):
(WebCore::ImageFrame::getSkBitmap):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):
Update use of m_bitmap now that it is a pointer type and call
NativeImageSkia::create() to construct a NativeImageSkia object now
that the constructor is private.
- platform/image-decoders/cairo/ImageDecoderCairo.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/image-decoders/openvg/ImageDecoderOpenVG.cpp:
(WebCore::ImageFrame::asNewNativeImage): Ditto.
- platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::ImageFrame):
Initialize m_bitmap in the constructor now that it is a pointer
type and we need NativeImageSkia's default constructor to be
called.
(WebCore::ImageFrame::operator=):
Call NativeImageSkia's new clone() method to copy m_bitmap as
NativeImageSkia is now RefCounted and no longer copyable.
(WebCore::ImageFrame::clearPixelData):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
Update use of m_bitmap now that it is a pointer type.
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
Call NativeImageSkia's clone method now that it is no longer
copyable.
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setStatus):
Update use of m_bitmap now that it is a pointer type.
- platform/image-decoders/wx/ImageDecoderWx.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- svg/graphics/SVGImage.cpp:
(WebCore):
(WebCore::SVGImage::nativeImageForCurrentFrame):
Add implementation of nativeImageForCurrentFrame() for SVGImage as
it is needed for SVG custom cursor support and Canvas drawing of
patterns containing SVG images. As SVGImage no longer keep the
native image internally to save memory, the implementation creates
the native image when nativeImageForCurrentFrame() and passes
its ownership to the caller.
- svg/graphics/SVGImage.h:
Override Image::nativeImageForCurrentFrame() and remove dummy
implementation of frameAtIndex() as it is not needed / used.
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::nativeImageForCurrentFrame):
Add implementation of nativeImageForCurrentFrame() which merely
forwards the call to the Image being contained.
- svg/graphics/SVGImageForContainer.h:
Override Image::nativeImageForCurrentFrame().
Source/WebKit/chromium:
Update code now that Image::nativeImageForCurrentFrame() and
ImageFrame::asNewNativeImage() return a smart pointer instead
of a raw one.
- src/WebImageDecoder.cpp:
(WebKit::WebImageDecoder::getFrameAtIndex):
- src/WebImageSkia.cpp:
(WebKit::WebImage::fromData):
(WebKit::WebImage::framesFromData):
(WebKit::WebImage::operator=):
- tests/DeferredImageDecoderTest.cpp:
(WebCore::TEST_F):
- tests/DragImageTest.cpp:
(WebCore::TestImage::TestImage):
(WebCore::TestImage::nativeImageForCurrentFrame):
(TestImage):
- tests/ImageLayerChromiumTest.cpp:
(WebCore::TestImage::TestImage):
(WebCore::TestImage::nativeImageForCurrentFrame):
(TestImage):
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
LayoutTests:
Add layout test to check that drawing canvas patterns containing SVG images works.
- platform/chromium-linux/svg/canvas/canvas-pattern-svg-expected.png: Added.
- svg/canvas/canvas-pattern-svg-expected.txt: Added.
- svg/canvas/canvas-pattern-svg.html: Added.
- 4:11 AM Changeset in webkit [147621] by
-
- 3 edits4 adds in trunk/LayoutTests
[SOUP] inspector/timeline/timeline-receive-response-event.html fails
https://bugs.webkit.org/show_bug.cgi?id=113860
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-04
Reviewed by Xan Lopez.
Copy the results of inspector/timeline/timeline-receive-response-event.html
to the efl and gtk platform dir.
Because test files are bigger than buffer size of ResourceHandleSoup.
- platform/efl/TestExpectations:
- platform/efl/inspector/timeline/timeline-receive-response-event-expected.txt: Added.
- platform/gtk/TestExpectations:
- platform/gtk/inspector/timeline/timeline-receive-response-event-expected.txt: Added.
- 4:10 AM Changeset in webkit [147620] by
-
- 3 edits in trunk/Source/WebCore
[CSSRegions] RenderFlowThread::renderRegionForLine should use a faster search method
https://bugs.webkit.org/show_bug.cgi?id=66921
Reviewed by David Hyatt.
The RenderFlowThread::regionAtBlockOffset() function is a hot path for the code using
flow threads because it translates from block coordinates to regions.
Currently the method is O(n), using a linear search through the regions chain to find the
region where a block offset lands.
The patch improves this search by using an interval tree (PODIntervalTree). Before a flow
thread is laid out, each region is updated to hold the size of the portion of the flow it
will receive. This information is gathered inside the interval tree and used to speedup the
search in RenderFlowThread::regionAtBlockOffset(). The algorithm uses a custom adapter
simplified for looking up offsets inside the interval tree.
For now, the interval tree is cleared every time the flow thread portions list is updated.
The implementation can be improved but induces some cmplexity as we'd have to manually manage
the life cycle of the tree's nodes. The performance gains are good enough as is to make this
only optional.
Another important change is now the flow thread portion rectangles will not overflow when
using auto-height regions (or very large regions). The maximum size of the flow is set to
LayoutUnit::max()/2. Any region forcing a greater size will be capped so the thread
won't overflow.
Performance test results:
/Layout/RegionsAuto:Time ms 699.95 181.20 74.11% Better
/Layout/RegionsAutoMaxHeight:Time ms 2083.00 308.55 85.19% Better
/Layout/RegionsFixed:Time ms 726.10 223.65 69.20% Better
/Layout/RegionsFixedShort:Time ms 869.60 288.25 66.85% Better
Tests: See PerformanceTests/Layout/Regions*
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::regionAtBlockOffset):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::RegionSearchAdapter::collectIfNeeded):
(WebCore):
- rendering/RenderFlowThread.h:
(WebCore):
- 4:07 AM Changeset in webkit [147619] by
-
- 2 edits in trunk/LayoutTests
[EFL][Qt] The layout test fast/loader/url-selected-user-gesture.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=113930
Reviewed by Antti Koivisto.
- fast/loader/url-selected-user-gesture.html:
- 3:52 AM Changeset in webkit [147618] by
-
- 5 edits1 add in trunk
[Qt] WebSocket errors should be logged to console
https://bugs.webkit.org/show_bug.cgi?id=113842
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-04
Reviewed by Jocelyn Turcotte.
Source/WebCore:
Pass the reason of a failure to SocketStreamError instance
and notify it via SocketStreamHandleClient::didFailSocketStream().
Test : http/tests/inspector/console-websocket-error.html
- platform/network/qt/SocketStreamError.h:
(WebCore::SocketStreamError::SocketStreamError):
- platform/network/qt/SocketStreamHandleQt.cpp:
(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore::SocketStreamHandlePrivate::socketErrorCallback):
LayoutTests:
- platform/qt/TestExpectations:
- platform/qt/http/tests/inspector/console-websocket-error-expected.txt: Added.
- 3:47 AM Changeset in webkit [147617] by
-
- 7 edits in trunk/Source/WebKit2
[WK2][EFL] WebView should own view size
https://bugs.webkit.org/show_bug.cgi?id=110753
Reviewed by Andreas Kling.
WebView owns view size. WKViewGetSize and WKViewSetSize API
is exposed accordingly. Usage of EFL-specific ewkView inside
toolkit-agnostic WebView class is reduced.
- UIProcess/API/C/efl/WKView.cpp:
(WKViewGetSize):
(WKViewSetSize):
- UIProcess/API/C/efl/WKView.h:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::setDeviceScaleFactor):
(EwkView::size):
(EwkView::deviceSize):
(EwkView::scheduleUpdateDisplay):
(EwkView::handleEvasObjectCalculate):
- UIProcess/API/efl/EwkView.h:
(EwkView):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::setSize):
(WebKit):
(WebKit::WebView::paintToCurrentGLContext):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::viewSize):
(WebKit::WebView::dipSize):
- UIProcess/efl/WebView.h:
(WebView):
(WebKit::WebView::size):
- 2:40 AM Changeset in webkit [147616] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- 1:39 AM Changeset in webkit [147615] by
-
- 2 edits in trunk/Source/WebCore
[ATK] build fails when accessibility is turned off
https://bugs.webkit.org/show_bug.cgi?id=113699
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-04
Reviewed by Gyuyoung Kim.
- editing/atk/FrameSelectionAtk.cpp: Wrapped accessibility code in #if HAVE(ACCESSIBILITY)
- 12:59 AM Changeset in webkit [147614] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix closure compiler warnings in the profiler code HeapSnapshotDataGrids.js
https://bugs.webkit.org/show_bug.cgi?id=113922
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-04
Reviewed by Yury Semikhatsky.
No new tests: no change in behaviour.
- inspector/front-end/HeapSnapshotDataGrids.js:
- 12:30 AM Changeset in webkit [147613] by
-
- 9 edits7 adds in trunk/LayoutTests
[Mac] Unreviewed gardening. Rebaseline after r147588.
- platform/mac-lion/fast/text/international/text-combine-image-test-expected.png:
- platform/mac-lion/fast/text/international/text-combine-image-test-expected.txt:
- platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
- platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/mac-wk2/fast/text: Added.
- platform/mac-wk2/fast/text/international: Added.
- platform/mac-wk2/fast/text/international/003-expected.png: Added.
- platform/mac-wk2/fast/text/international/text-combine-image-test-expected.png: Added.
- platform/mac-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
- platform/mac/fast/text/international/003-expected.png:
- platform/mac/fast/text/international/003-expected.txt:
- platform/mac/fast/text/international/text-combine-image-test-expected.png: Added.
- platform/mac/fast/text/international/text-combine-image-test-expected.txt:
- platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
Apr 3, 2013:
- 11:02 PM Changeset in webkit [147612] by
-
- 4 edits in trunk/Source
Versioning.
- 11:00 PM Changeset in webkit [147611] by
-
- 4 edits in tags/Safari-537.35.8/Source
Versioning.
- 10:57 PM Changeset in webkit [147610] by
-
- 1 copy in tags/Safari-537.35.8
New Tag.
- 10:55 PM Changeset in webkit [147609] by
-
- 29 edits4 adds in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: put DFG data into a DFG::JITCode, and put common DFG and FTL data into something accessible from both DFG::JITCode and FTL::JITCode
https://bugs.webkit.org/show_bug.cgi?id=113905
Reviewed by Geoffrey Garen.
This removes one pointer from CodeBlock.
It also gives us a framework for having JITType-specific data in CodeBlock, by
putting it into the appropriate JITCode class (either DFG::JITCode or
FTL::JITCode). And it allows us to have DFG and FTL share some common data,
via DFG::CommonData, which is stored in both DFG::JITCode and FTL::JITCode and
always accessible via JITCode::dfgCommon().
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeBlock.cpp:
(JSC):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::performTracingFixpointIteration):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitWeakReferences):
(JSC::CodeBlock::shrinkToFit):
(JSC::CodeBlock::tallyFrequentExitSites):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan):
(JSC::DFGCodeBlocks::mark):
- dfg/DFGAssemblyHelpers.h:
- dfg/DFGCommonData.cpp: Added.
(DFG):
(JSC::DFG::CommonData::notifyCompilingStructureTransition):
(JSC::DFG::CommonData::shrinkToFit):
- dfg/DFGCommonData.h: Added.
(JSC):
(DFG):
(JSC::DFG::WeakReferenceTransition::WeakReferenceTransition):
(WeakReferenceTransition):
(CommonData):
(JSC::DFG::CommonData::CommonData):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
- dfg/DFGDriver.h:
(DFG):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
- dfg/DFGGraph.h:
(Graph):
- dfg/DFGJITCode.cpp: Added.
(DFG):
(JSC::DFG::JITCode::JITCode):
(JSC::DFG::JITCode::~JITCode):
(JSC::DFG::JITCode::dfgCommon):
(JSC::DFG::JITCode::dfg):
(JSC::DFG::JITCode::shrinkToFit):
- dfg/DFGJITCode.h: Added.
(DFG):
(JITCode):
(JSC::DFG::JITCode::appendOSREntryData):
(JSC::DFG::JITCode::osrEntryDataForBytecodeIndex):
(JSC::DFG::JITCode::appendOSRExit):
(JSC::DFG::JITCode::lastOSRExit):
(JSC::DFG::JITCode::appendSpeculationRecovery):
(JSC::DFG::JITCode::appendWatchpoint):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(JITCompiler):
(JSC::DFG::JITCompiler::addWeakReference):
(JSC::DFG::JITCompiler::noticeOSREntry):
(JSC::DFG::JITCompiler::jitCode):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExit.h:
(OSRExit):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::backwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGVariableEventStream.cpp:
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::JITCode):
(JSC::FTL::JITCode::~JITCode):
(FTL):
(JSC::FTL::JITCode::initializeCode):
(JSC::FTL::JITCode::addressForCall):
(JSC::FTL::JITCode::executableAddressAtOffset):
(JSC::FTL::JITCode::dataAddressAtOffset):
(JSC::FTL::JITCode::offsetOf):
(JSC::FTL::JITCode::size):
(JSC::FTL::JITCode::contains):
(JSC::FTL::JITCode::ftl):
(JSC::FTL::JITCode::dfgCommon):
- ftl/FTLJITCode.h:
(JITCode):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileStructureTransitionWatchpoint):
(JSC::FTL::LowerDFGToLLVM::compilePutStructure):
(JSC::FTL::LowerDFGToLLVM::compilePhantomPutStructure):
(JSC::FTL::LowerDFGToLLVM::addWeakReference):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::weakPointer):
- ftl/FTLState.cpp:
(FTL):
(JSC::FTL::State::State):
(JSC::FTL::State::dumpState):
- ftl/FTLState.h:
(State):
- heap/DFGCodeBlocks.cpp:
(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::jettison):
(JSC::DFGCodeBlocks::clearMarks):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):
(JSC::DFGCodeBlocks::traceMarkedCodeBlocks):
- jit/JITCode.cpp:
(JSC::JITCode::dfgCommon):
(JSC):
(JSC::JITCode::dfg):
(JSC::JITCode::ftl):
(JSC::DirectJITCode::DirectJITCode):
(JSC::DirectJITCode::initializeCodeRef):
(JSC::DirectJITCode::addressForCall):
(JSC::DirectJITCode::executableAddressAtOffset):
(JSC::DirectJITCode::dataAddressAtOffset):
(JSC::DirectJITCode::offsetOf):
(JSC::DirectJITCode::size):
(JSC::DirectJITCode::contains):
- jit/JITCode.h:
(DFG):
(FTL):
(JSC):
(JITCode):
(DirectJITCode):
- 10:09 PM Changeset in webkit [147608] by
-
- 4 edits in branches/dfgFourthTier
fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
https://bugs.webkit.org/show_bug.cgi?id=113921
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
The LLVM community wants us to continue including all of LLVM's C++ headers. Change
to using #pragma's to disable warnings that they cannot handle.
- ftl/FTLLLVMHeaders.h:
Tools:
Reviewed by Oliver Hunt.
The LLVM community wants us to continue including all of LLVM's C++ headers. Change
the export script to do this.
- Scripts/export-llvm-build:
- 8:52 PM Changeset in webkit [147607] by
-
- 27 edits in trunk
[EFL] Add a decoration image to search input field
https://bugs.webkit.org/show_bug.cgi?id=113552
Reviewed by Laszlo Gombos.
Source/WebCore:
Though EFL port has a decoration image for search input field, we didn't use it.
Start to show it.
Tests: fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-rtl.html
fast/css/input-search-padding.html
fast/css/text-input-with-webkit-border-radius.html
fast/css/text-overflow-input.html
fast/forms/box-shadow-override.html
fast/forms/control-restrict-line-height.html
fast/forms/input-appearance-height.html
fast/forms/placeholder-position.html
fast/forms/placeholder-pseudo-style.html
fast/forms/search-styled.html
fast/forms/search-vertical-alignment.html
fast/forms/searchfield-heights.html
fast/repaint/search-field-cancel.html
fast/replaced/width100percent-searchfield.html
- platform/efl/RenderThemeEfl.cpp:
(WebCore):
(WebCore::RenderThemeEfl::supportsDataListUI):
(WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
LayoutTests:
Rebaseline related to input search field.
- platform/efl/fast/css/input-search-padding-expected.png:
- platform/efl/fast/css/input-search-padding-expected.txt:
- platform/efl/fast/css/text-input-with-webkit-border-radius-expected.png:
- platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/efl/fast/css/text-overflow-input-expected.png:
- platform/efl/fast/css/text-overflow-input-expected.txt:
- platform/efl/fast/forms/box-shadow-override-expected.png:
- platform/efl/fast/forms/box-shadow-override-expected.txt:
- platform/efl/fast/forms/control-restrict-line-height-expected.png:
- platform/efl/fast/forms/control-restrict-line-height-expected.txt:
- platform/efl/fast/forms/input-appearance-height-expected.png:
- platform/efl/fast/forms/input-appearance-height-expected.txt:
- platform/efl/fast/forms/placeholder-position-expected.png:
- platform/efl/fast/forms/placeholder-position-expected.txt:
- platform/efl/fast/forms/placeholder-pseudo-style-expected.png:
- platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png:
- platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/efl/fast/forms/searchfield-heights-expected.png:
- platform/efl/fast/forms/searchfield-heights-expected.txt:
- platform/efl/fast/repaint/search-field-cancel-expected.png:
- platform/efl/fast/repaint/search-field-cancel-expected.txt:
- platform/efl/fast/replaced/width100percent-searchfield-expected.png:
- platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
- 7:49 PM Changeset in webkit [147606] by
-
- 1 copy in tags/Safari-537.36
New Tag.
- 7:16 PM Changeset in webkit [147605] by
-
- 8 edits in trunk/LayoutTests
Unreviewed gardening. Below tests aren't related to bug 87619. It just needs to do rebaseline.
- platform/efl/TestExpectations:
- platform/efl/fast/forms/number/number-appearance-rtl-expected.png:
- platform/efl/fast/forms/number/number-appearance-rtl-expected.txt:
- platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
- platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
- platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
- 6:52 PM Changeset in webkit [147604] by
-
- 2 edits in branches/dfgFourthTier/LayoutTests
fourthTier: Just linking LLVM into JSC causes all plugin tests to fail
https://bugs.webkit.org/show_bug.cgi?id=113915
Reviewed by nobody.
This is pretty funny. I don't know, yet, what is going on, but I don't want it to block other work.
- platform/mac/TestExpectations:
- 6:39 PM Changeset in webkit [147603] by
-
- 2 edits in trunk/Tools
Re-enable WinEWS tests.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 6:16 PM Changeset in webkit [147602] by
-
- 3 edits2 adds in trunk
Input value/placeholder is not redrawn when the input height grows
https://bugs.webkit.org/show_bug.cgi?id=113845
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/forms/text/text-height-grow.html
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::styleDidChange):
We need relayout of the inner text element.
LayoutTests:
- fast/forms/text/text-height-grow-expected.html: Added.
- fast/forms/text/text-height-grow.html: Added.
- 6:10 PM Changeset in webkit [147601] by
-
- 1 edit2 adds in trunk/LayoutTests
[GTK] Unreviewed gardening. Rebaseline after r147588.
- platform/gtk-wk1/fast/writing-mode: Added.
- platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
- 6:02 PM Changeset in webkit [147600] by
-
- 2 edits in trunk/Source/WebCore
Add comment to clarify isStackingContext() in RenderLayer.h
https://bugs.webkit.org/show_bug.cgi?id=113909
Reviewed by Simon Fraser.
It was not obvious how the implementation of isStackingContext()
was correct, a comment is appropriate here for anyone who reads
this code in the future.
Just a change in comment, no test needed.
- rendering/RenderLayer.h:
- 5:58 PM Changeset in webkit [147599] by
-
- 16 edits1 add3 deletes in trunk/LayoutTests
[Chromium] Unreviewed gardening. Rebaseline after r147588.
- platform/chromium-mac-lion/fast/text/international/003-expected.png:
- platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.png:
- platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.txt:
- platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-mac/fast/text/international/003-expected.png:
- platform/chromium-mac/fast/text/international/003-expected.txt: Added.
- platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
- platform/chromium-mac/fast/text/international/text-combine-image-test-expected.txt:
- platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/chromium-win/fast/text/international/003-expected.png:
- platform/chromium-win/fast/text/international/003-expected.txt:
- platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/fast/text/international/003-expected.txt: Removed.
- 5:45 PM Changeset in webkit [147598] by
-
- 2 edits in trunk/Source/WebKit2
Don't try to set the exception port for server connections
https://bugs.webkit.org/show_bug.cgi?id=113910
<rdar://problem/11248925>
Reviewed by Darin Adler.
Treat a SetExceptionPort message to the server connection as an invalid message.
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::receiveSourceEventHandler):
- 5:05 PM Changeset in webkit [147597] by
-
- 3 edits in trunk/Source/WebCore
[CSS Exclusions] Removed ExclusionShape dead code
https://bugs.webkit.org/show_bug.cgi?id=113904
Reviewed by Dirk Schulze.
No new tests, just removing dead code.
- rendering/ExclusionShape.cpp:
(WebCore::ExclusionShape::createExclusionShape):
- rendering/ExclusionShape.h:
(ExclusionShape):
- 4:44 PM Changeset in webkit [147596] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed. AppleWin port gardening.
- platform/win/TestExpectations:
- platform/win/fast/lists/inlineBoxWrapperNullCheck-expected.txt: Added.
- 4:16 PM Changeset in webkit [147595] by
-
- 2 edits in trunk/Source/WTF
Enable HAVE_MADV_FREE_REUSE on iOS
https://bugs.webkit.org/show_bug.cgi?id=113892
<rdar://problem/12787563>
Reviewed by Mark Rowe.
- wtf/Platform.h:
- 3:58 PM Changeset in webkit [147594] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Switch MediaPlayerPrivateBlackBerry.cpp's timer to use CLOCK_MONOTONIC
https://bugs.webkit.org/show_bug.cgi?id=113900
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-04-03
Reviewed by Rob Buis.
Internally Reviewed by Jeff Rogers.
Timers should use CLOCK_MONOTONIC to avoid undesirable effects when
the user switches the system time.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::drawBufferingAnimation):
- 3:54 PM Changeset in webkit [147593] by
-
- 2 edits in trunk/Source/WebKit2
<http://webkit.org/b/113898> Eliminate some code duplication by introducing an array of handlers to register / unregister.
Reviewed by Antti Koivisto.
- UIProcess/mac/WebContextMac.mm:
(OcclusionNotificationHandler): Structure containing the notification name, type and handler.
(WebKit::registerOcclusionNotificationHandlers): Register all of the handlers in the array.
(WebKit::unregisterOcclusionNotificationHandlers): Unregister all of the handlers in the array.
- 3:54 PM Changeset in webkit [147592] by
-
- 2 edits in trunk/Source/WebKit2
Enable process suppression when no windows in the application have drawn recently.
<http://webkit.org/b/113854> / <rdar://problem/13540351>
Reviewed by Darin Adler.
- UIProcess/mac/WebContextMac.mm:
(WebKit::applicationWindowModificationsStarted): Note that modifications are no longer stopped.
(WebKit::applicationWindowModificationsStopped): Note that modifications have stopped.
(WebKit::registerOcclusionNotificationHandlers): Register handlers for the start and stop notifications.
(WebKit::unregisterOcclusionNotificationHandlers): Unregister handlers for the start and stop notifications.
(WebKit::WebContext::canEnableProcessSuppressionForNetworkProcess): Allow suppression if the application is occluded
or the application has not drawn recently.
(WebKit::WebContext::canEnableProcessSuppressionForWebProcess): Ditto.
(WebKit::WebContext::canEnableProcessSuppressionForGlobalChildProcesses): Ditto.
- 3:35 PM Changeset in webkit [147591] by
-
- 9 edits4 adds in trunk
Unable to focus on embedded plugins such as Flash via javascript focus()
https://bugs.webkit.org/show_bug.cgi?id=32292
Patch by Dave Michael <dmichael@chromium.org> on 2013-04-03
Reviewed by Ryosuke Niwa.
Source/WebCore:
Make embed, object, and applet elements support focus() when
appropriate. Prior to this patch, javascript focus() had no effect on
embed, object, or applet elements unless tabindex or contenteditable is
set. With this patch, focus() will focus the element unless the plugin
content has failed to load (i.e., we are showing either fallback content
or an unavailable plugin indicator).
Test: plugins/focus.html
java/focus.html
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::supportsFocus):
Overridden to return true except when the plugin content has failed to load.
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInElement::useFallbackContent):
Moved up from HTMLPlugInImageElement.
(WebCore::HTMLPlugInElement::supportsFocus):
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInImageElement::useFallbackContent):
Removed. Now the implementation is inherited from HTMLPlugInElement.
LayoutTests:
Add/update testing to ensure embed, object, and applet tags now support
focus except when plugin content did not load.
- fast/events/resources/tabindex-focus-blur-all-frame1.html: Change embed and object
elements to reference an invalid plugin, to be consistent with applet. These
element types are not focusable when there is valid plugin content.
- fast/events/resources/tabindex-focus-blur-all-frame2.html: Same as above.
- fast/events/resources/tabindex-focus-blur-all-iframe1.html: Same as above.
- fast/events/resources/tabindex-focus-blur-all-iframe2.html: Same as above.
- java/focus-expected.txt: Added.
- java/focus.html: Added.
- plugins/focus-expected.txt: Added.
- plugins/focus.html: Added.
- 3:33 PM Changeset in webkit [147590] by
-
- 4 edits in tags/Safari-537.35.7/Source
Versioning.
- 3:18 PM Changeset in webkit [147589] by
-
- 1 copy in tags/Safari-537.35.7
New Tag.
- 2:53 PM Changeset in webkit [147588] by
-
- 12 edits5 adds in trunk
Element boundaries prevent Japanese line break opportunities
https://bugs.webkit.org/show_bug.cgi?id=105692
Reviewed by Darin Adler.
Source/WebCore:
Introduce use of prior context when using text break iterators
in non-ASCII path through nextBreakablePosition(). This enables
the use of line break context across an element boundary for
the non-ASCII path. Use of this context with the ASCII path was
enabled by https://bugs.webkit.org/show_bug.cgi?id=17427.
Performance tests of line layout and html5 parsing show that this
patch provides an approximately 4% improvement with Japanese and
no statistically significant regression with ASCII path. Parsing
(html5-full-render) performance is not significantly affected.
Tests: fast/text/line-break-between-text-nodes-cjk.html
fast/text/line-break-between-text-nodes-latin1.html
Expect rebaselines will be needed due to different line breaks:
fast/text/international/003.html
fast/text/international/text-combine-image-test-expected.html
fast/text/writing-mode/Kusa-Makura-background-canvas.html
- platform/text/TextBreakIterator.cpp:
(WebCore::acquireLineBreakIterator): Pass prior context to non-ICU path.
- platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::priorContextLength): Added.
(WebCore::LazyLineBreakIterator::get): Pass prior context to ICU path.
(WebCore::LazyLineBreakIterator::resetStringAndReleaseIterator): Editorial.
- platform/text/TextBreakIteratorICU.cpp:
Use prior context from line break iterators. Requires
adding new UTF16 (UChar*) text provider and reimplementing
Latin1 (LChar*) text provider. Implementation is optimized
by using generic functionality that applies to both string
sources.
(WebCore::textPinIndex): Added.
(WebCore::textNativeLength): Added.
(WebCore::textFixPointer): Added.
(WebCore::textClone): Added.
(WebCore::textExtract): Added.
(WebCore::textClose): Added.
(WebCore::textGetContext): Added.
(WebCore::textLatin1GetCurrentContext): Added.
(WebCore::textLatin1MoveInPrimaryContext): Added.
(WebCore::textLatin1SwitchToPrimaryContext): Added.
(WebCore::textLatin1MoveInPriorContext): Added.
(WebCore::textLatin1SwitchToPriorContext): Added.
(WebCore::textInChunkOrOutOfRange): Added.
(WebCore::textLatin1Access): Added.
(WebCore::textInit): Added.
(WebCore::textOpenLatin1): Added.
(WebCore::textUTF16GetCurrentContext): Added.
(WebCore::textUTF16MoveInPrimaryContext): Added.
(WebCore::textUTF16SwitchToPrimaryContext): Added.
(WebCore::textUTF16MoveInPriorContext): Added.
(WebCore::textUTF16SwitchToPriorContext): Added.
(WebCore::textUTF16Access): Added.
(WebCore::textOpenUTF16): Added.
(WebCore::acquireLineBreakIterator): Use new text providers with prior context.
- platform/text/wchar/TextBreakIteratorWchar.cpp:
(WebCore::acquireLineBreakIterator): Pass prior context to non-ICU path.
- rendering/break_lines.cpp:
(WebCore::nextBreakablePosition): Use prior context in ICU path.
LayoutTests:
- fast/text/line-break-between-text-nodes-cjk-expected.html: Added.
- fast/text/line-break-between-text-nodes-cjk.html: Added.
- fast/text/line-break-between-text-nodes-latin1-expected.html: Added.
- fast/text/line-break-between-text-nodes-latin1.html: Added.
- platform/chromium-linux/fast/text/international/003-expected.png: Rebaselined.
- platform/chromium-linux/fast/text/international/003-expected.txt: Rebaselined.
- platform/chromium-linux/fast/text/international/text-combine-image-test-expected.png: Rebaselined.
- platform/chromium-linux/fast/text/international/text-combine-image-test-expected.txt: Added (previously missing).
- platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Rebaselined.
- platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Rebaselined.
- 2:53 PM Changeset in webkit [147587] by
-
- 13 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Everyone should know about the FTL
https://bugs.webkit.org/show_bug.cgi?id=113897
Reviewed by Mark Hahnenberg.
In order to get OSR exit to work right, we need the distinction between DFG and
FTL to be clear even after compilation finishes, since they will have subtly
different OSR stories and likely use different data structures.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStubInternal):
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):
(JSC::CodeBlock::adjustedExitCountThreshold):
(JSC::CodeBlock::tallyFrequentExitSites):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::ExecState::isInlineCallFrame):
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::JITCode):
- ftl/FTLState.cpp:
(JSC::FTL::State::dumpState):
- heap/DFGCodeBlocks.cpp:
(JSC::DFGCodeBlocks::jettison):
- interpreter/Interpreter.cpp:
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
- jit/JITCode.cpp:
(WTF::printInternal):
- jit/JITCode.h:
(JSC::JITCode::topTierJIT):
(JSC::JITCode::nextTierJIT):
(JITCode):
(JSC::JITCode::isJIT):
(JSC::JITCode::isLowerTier):
(JSC::JITCode::isHigherTier):
(JSC::JITCode::isLowerOrSameTier):
(JSC::JITCode::isHigherOrSameTier):
(JSC::JITCode::isOptimizingJIT):
- jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileOptimized):
(JSC::samplingDescription):
(JSC::ProgramExecutable::compileOptimized):
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
- 2:51 PM Changeset in webkit [147586] by
-
- 4 edits2 adds in branches/safari-534.59-branch/Source/WebKit2
Fix the build after merging 147042.
- Platform/mac/StringUtilities.h: Added.
(WebKit):
- Platform/mac/StringUtilities.mm: Added.
(WebKit):
(WebKit::nsStringFromWebCoreString):
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextCopyPlugInInfoForBundleIdentifier):
- UIProcess/Plugins/PluginInfoStore.h:
(PluginInfoStore):
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::findPluginWithBundleIdentifier):
- 2:35 PM Changeset in webkit [147585] by
-
- 3 edits in trunk/LayoutTests
get_by_pname can become confused when iterating over objects with static properties
https://bugs.webkit.org/show_bug.cgi?id=113831
Reviewed by Jer Noble.
Improving the test results to make it more obvious why something failed. Also removed
absolute paths from the test.
- fast/js/dom-static-property-for-in-iteration-expected.txt:
- fast/js/dom-static-property-for-in-iteration.html:
- 2:21 PM Changeset in webkit [147584] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed VS2010 build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 2:08 PM Changeset in webkit [147583] by
-
- 10 edits2 deletes in trunk/Source
[Chromium] Bad cast from BitmapImageSingleFrameSkia to BitmapImage
https://bugs.webkit.org/show_bug.cgi?id=113492
Reviewed by Stephen White.
Source/WebCore:
Remove BitmapImageSingleFrameSkia and have ImageBufferSkia construct
BitmapImage objects instead via an intermediate NativeImageSkia.
No new tests, covered by existing tests.
- WebCore.gypi:
- platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: Remove
include for BitmapImageSingleFrameSkia.h header.
- platform/graphics/skia/BitmapImageSingleFrameSkia.cpp: Removed.
- platform/graphics/skia/BitmapImageSingleFrameSkia.h: Removed.
- platform/graphics/skia/ImageBufferSkia.cpp: Construct BitmapImage
objects instead of BitmapImageSingleFrameSkia ones.
(WebCore::ImageBuffer::copyImage):
(WebCore::drawNeedsCopy):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
- platform/graphics/skia/ImageSkia.cpp:
(WebCore::BitmapImage::BitmapImage): Implement BitmapImage constructor
that takes an NativeImageSkia* in argument.
(WebCore):
(WebCore::BitmapImage::draw): Remove m_source.initialized() check as
this will return false for BitmapImage objects constructed from a
NativeImageSkia, due to the lack of decoder.
- platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::NativeImageSkia): Add parameter to the
NativeImageSkia constructor so that the caller can request a deep copy
instead of a shallow one. This is needed by the ImageBuffer.
- platform/graphics/skia/NativeImageSkia.h:
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::setSkBitmap):
Source/WebKit/chromium:
Update test now that BitmapImageSingleFrameSkia no longer exists.
BitmapImage is now used instead.
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
- 1:57 PM Changeset in webkit [147582] by
-
- 4 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should abstract out how it does forward exits, and that code should be simplified
https://bugs.webkit.org/show_bug.cgi?id=113894
Reviewed by Mark Hahnenberg.
1) We previously had two different ways of convertingToForward, one path for
where we had a ValueRecovery for the current node and one where we didn't.
But the paths were doing exactly the same thing except that if you have a
ValueRecovery, you also find the last applicable mov hint and do some
extra things. This patch combines the two paths and bases both of them on
the previous no-ValueRecovery path, which was simpler to begin with.
2) This moves the logic into DFG::OSRExit, which further simplifies the code
and makes the logic available to the FTL.
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::convertToForward):
(DFG):
- dfg/DFGOSRExit.h:
(DFG):
(OSRExit):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
- 1:44 PM Changeset in webkit [147581] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: resultAnimationElement->m_animatedType
https://bugs.webkit.org/show_bug.cgi?id=93528
Patch by David Vest <davve@opera.com> on 2013-04-03
Reviewed by Philip Rogers.
Source/WebCore:
When the order of animation elements change within an animation
group, we can't assume that the resultElement is the same as it
was when the animation was frozen. Make sure to reset the
animation type for the resultElement before updating the
animation.
Test: svg/animations/animation-dependency-crash.html
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::progress):
LayoutTests:
- svg/animations/animation-dependency-crash-expected.txt: Added.
- svg/animations/animation-dependency-crash.html: Added.
- 1:39 PM Changeset in webkit [147580] by
-
- 3 edits in trunk/Source/WebCore
Stop unconditionally enabling JavaScript execution when closing the Web Inspector.
https://webkit.org/b/113889
rdar://problem/12281794
Reviewed by Joseph Pecoraro.
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent): Initialize m_originalScriptExecutionDisabled.
(WebCore::InspectorPageAgent::enable): Populate m_originalScriptExecutionDisabled based on current setting.
(WebCore::InspectorPageAgent::disable): Restore previous setting.
- inspector/InspectorPageAgent.h:
(InspectorPageAgent): Added m_originalScriptExecutionDisabled.
- 1:13 PM Changeset in webkit [147579] by
-
- 10 edits in trunk/Source
Cross fade into restarted plugin
https://bugs.webkit.org/show_bug.cgi?id=113868
Reviewed by Tim Horton.
Source/WebCore:
Allow a restarted plugin to fade in over its snapshot, avoiding the abrupt
flash of empty content. The WebCore part of this patch marks the plugin
element as restarted, and draws the snapshot for a short amount of time
as the plugin is restarting. After the plugin has reappeared, we stop drawing
the snapshot.
There is a little bit of drive-by whitespace removal in HTMLPlugInImageElement.
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInElement::restartedPlugin): New method indicating if the plugin has been restarted.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Initialise new timer and member variable.
(WebCore::HTMLPlugInImageElement::setDisplayState): If we are moving into a restarting state, make sure
to remember this and also start a timer so that we show the snapshot for while.
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired): No need to draw the snapshot from here on.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): Member variable to remember if we've restarted.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintContents): Only exit early from the paint if we're not a restarting
plugin, otherwise we do want to draw the snapshot if there is one.
- rendering/RenderLayerBacking.cpp:
(WebCore::isRestartedPlugin): Detects a restarted plugin.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Don't become a simple container
compositing layer if you're a restarted plugin.
Source/WebKit2:
Add a new plugin process type that indicates this is a plugin that
has been restarted from snapshotting. On Apple ports, this allows
us to animate the appearance of the plugin so that it crossfades
with the snapshot. Other ports will have to add their own fading.
- PluginProcess/PluginProcess.h: New Type: TypeRestartedProcess.
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::PluginProxy::pluginLayer): When the plugin's CALayer is created, if it
is a restarted plugin, add an opacity animation to fade it in.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin): Mark restarted plugins with the new process type.
- 1:05 PM Changeset in webkit [147578] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Adjustments to media controls appearance.
https://bugs.webkit.org/show_bug.cgi?id=113816
https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=316398
https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=316438
Updates to the BlackBerry media controls:
- extend the timeline slider.
- move the volume slider for audio elements up so it does not overlap the main panel.
- upstream some other cosmetic changes to media controls that were not previously upstreamed.
Patch by John Griggs <jgriggs@blackberry.com> on 2013-04-03
Reviewed by Rob Buis.
BlackBerry-specific, cosmetic change; No new tests required.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
(WebCore::RenderThemeBlackBerry::paintMediaPlayButton):
(WebCore::RenderThemeBlackBerry::paintMediaMuteButton):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderThumb):
- 12:53 PM Changeset in webkit [147577] by
-
- 5 edits in trunk/LayoutTests
Compositing tests failing after http://trac.webkit.org/changeset/147502
https://bugs.webkit.org/show_bug.cgi?id=113838
Reviewed by Dean Jackson.
Add (contentsOpaque 1) to the DRT text output in some expectations files due to bug 70634
"Mark GraphicsLayers as opaque when possible" [1]. The expectations in the guilty changeset
weren't updated after bug 70634 landed.
[1]: https://bugs.webkit.org/show_bug.cgi?id=70634
- compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
- platform/mac/TestExpectations:
- 12:41 PM Changeset in webkit [147576] by
-
- 3 edits in branches/dfgFourthTier/WebKitLibraries
Updated LLVM drops to include LLVM_DO_NOT_INCLUDE_CPP_HEADERS changes.
Rubber stamped by Mark Hahnenberg.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 12:29 PM Changeset in webkit [147575] by
-
- 2 edits in branches/safari-534.59-branch/Source/WebKit2
Remove include after mis-merge of r147052.
- UIProcess/API/C/WKAPICast.h:
- 12:16 PM Changeset in webkit [147574] by
-
- 3 edits in trunk/Tools
[GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
https://bugs.webkit.org/show_bug.cgi?id=113883
Reviewed by Martin Robinson.
- gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
- gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
- 12:08 PM Changeset in webkit [147573] by
-
- 3 edits in branches/chromium/1453/Source/WebCore/platform/image-decoders/gif
Merge 147392 "Simply GIFImageReader error handling"
Simply GIFImageReader error handling
https://bugs.webkit.org/show_bug.cgi?id=113718
Reviewed by Adam Barth.
When GIFImageReader encounters a parsing error it should just return
without doing any more work. Current code saves a boolean before return,
this is not necessary.
Tested with existing unit tests.
Tested locally with ASAN build with 60k GIF images.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::repetitionCount):
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::decode):
- platform/image-decoders/gif/GIFImageReader.h:
(GIFImageReader::GIFImageReader):
(GIFImageReader):
TBR=hclam@chromium.org
Review URL: https://codereview.chromium.org/13578002
- 11:58 AM Changeset in webkit [147572] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13564588> Add a temporary workaround for a build failure.
Fix suggested by Mark Rowe.
- Shared/mac/ChildProcessMac.mm:
- 11:47 AM Changeset in webkit [147571] by
-
- 8 edits in branches/safari-534.59-branch/Source/WebKit2
Merge 147052. <rdar://problem/13528851>
- 11:38 AM Changeset in webkit [147570] by
-
- 5 edits2 adds in trunk
get_by_pname can become confused when iterating over objects with static properties
https://bugs.webkit.org/show_bug.cgi?id=113831
Reviewed by Geoffrey Garen.
get_by_pname doesn't take static properties into account when using a JSPropertyNameIterator to directly
access an object's backing store. One way to fix this is to not cache any properties when iterating over
objects with static properties. This patch fixes the bug that was originally reported on swisscom.ch.
Source/JavaScriptCore:
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnNonIndexPropertyNames):
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
- runtime/PropertyNameArray.h:
(JSC::PropertyNameArray::PropertyNameArray):
(JSC::PropertyNameArray::numCacheableSlots):
(JSC::PropertyNameArray::setNumCacheableSlots):
(PropertyNameArray):
LayoutTests:
- fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
- fast/js/dom-static-property-for-in-iteration.html: Added.
- 11:27 AM Changeset in webkit [147569] by
-
- 3 edits in trunk/WebKitLibraries
[Windows, WinCairo] Unreviewed VS2010 Build Correction
- win/tools/scripts/auto-version2010.sh: Added properties svn:eol-style and svn:executable.
- win/tools/scripts/feature-defines2010.sh: Added properties svn:eol-style and svn:executable.
- 11:23 AM Changeset in webkit [147568] by
-
- 5 edits in trunk/Source/WebKit2
[WK2] XMLHttpRequest upload events don't work with NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=113887
Reviewed by Brady Eidson.
Just forward didSendData client call to WebProcess.
- NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::didSendData): (WebKit::NetworkResourceLoader::didCancelAuthenticationChallenge): Tweaked a comment.
- WebProcess/Network/WebResourceLoader.cpp: (WebKit::WebResourceLoader::didSendData):
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- 11:12 AM Changeset in webkit [147567] by
-
- 2 edits in trunk/Source/WebCore
[Gstreamer] Use gst_buffer_extract() in copyGstreamerBuffersToAudioChannel()
https://bugs.webkit.org/show_bug.cgi?id=113880
Reviewed by Philippe Normand.
copyGstreamerBuffersToAudioChannel() was mapping the GstBuffer content to memcpy
it to the AudioChannel buffer. This patch leverages gst_buffer_extract() to
simplify the code as it does exactly what we need: gst_buffer_map, memcpy,
gst_buffer_unmap and error handling.
Also replace GstBuffer NULL check by an assertion as we already make sure they
are not NULL before adding them to the list. Additionally, we now call
audioChannel->mutableData() only once instead of once per iteration. It is
a bit better as the getter does some work internally.
No new tests, no behavior change.
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::copyGstreamerBuffersToAudioChannel):
- 10:30 AM Changeset in webkit [147566] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: DOM.highlightRect() and DOM.highlightQuad() should allow for page coordinates
https://bugs.webkit.org/show_bug.cgi?id=113869
Add a new "usePageCoordinates" parameter to DOM.highlightRect() and DOM.highlightQuad()
allowing to specify that the rect or quad to highlight should be converted to page
coordinates instead of using the default viewport coordinates.
Reviewed by Timothy Hatcher.
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightQuad):
(WebCore::InspectorDOMAgent::innerHighlightQuad):
Store the "usePageCoordinates" parameter obtained from the protocol calls onto the
highlight configuration object so that it may be used within the InspectorOverlay.
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::highlightQuad):
Check the highlight configuration for the "usePageCoordinates" parameter and
apply the inverse of the page's scroll offset to the quad if it's true.
- inspector/InspectorOverlay.h:
(HighlightConfig):
(WebCore::Highlight::setDataFromConfig):
(Highlight):
- 9:43 AM Changeset in webkit [147565] by
-
- 2 edits in trunk/Source/WebCore
Add omitted reference operator of VisiblePosition in AccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=113879
Reviewed by Darin Adler.
Seems reference operator has been omitted in startOfStyleRange function, so add it.
- accessibility/AccessibilityObject.cpp:
(WebCore::startOfStyleRange):
- 9:35 AM Changeset in webkit [147564] by
-
- 2 edits in trunk/Tools
[GTK] Include Pango in jhbuild-optional.modules
https://bugs.webkit.org/show_bug.cgi?id=113878
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-03
Reviewed by Martin Robinson.
Since r147547 Pango 1.32.0 is required. Including the module in the
JHBuild optional moduleset.
- gtk/jhbuild-optional.modules: Add Pango module.
- 9:27 AM Changeset in webkit [147563] by
-
- 5 edits in trunk/Tools
[Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
https://bugs.webkit.org/show_bug.cgi?id=113864
Moving setDefersLoading from TestRunnerQt to TestRunner
requires access to the non-Qt TestRunner.
As long as we instantiate both TestRunner and TestRunnerQt,
we need a separate getter for the non-Qt TestRunner instance.
Reviewed by Simon Hausmann.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebPage::resetSettings):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree::jscTestRunner):
- DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::setDefersLoading):
Moving setDefersLoading from TestRunnerQt
to TestRunner.
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
- 9:12 AM Changeset in webkit [147562] by
-
- 2 edits in trunk/Source/WebCore
Update the localizable strings file.
Rubber-stamped by Michael Saboff.
- English.lproj/Localizable.strings:
- 8:58 AM Changeset in webkit [147561] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r147493): Fix number of arguments to AudioDestinationIOS constructor
Fixes the following build failures:
Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:84:25: error: no matching constructor for initialization of 'WebCore::AudioDestinationIOS'
return adoptPtr(new AudioDestinationIOS(callback, sampleRate));
In file included from Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:36:
Source/WebCore/platform/audio/ios/AudioDestinationIOS.h:44:5: note: candidate constructor not viable: requires 3 arguments, but 2 were provided
AudioDestinationIOS(AudioIOCallback&, unsigned numberOfOutputChannels, double sampleRate);
Source/WebCore/platform/audio/ios/AudioDestinationIOS.h:42:7: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
class AudioDestinationIOS : public AudioDestination, public AudioSessionListener {
Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:101:22: error: out-of-line definition of 'AudioDestinationIOS' does not match any declaration in 'WebCore::AudioDestinationIOS'
AudioDestinationIOS::AudioDestinationIOS(AudioIOCallback& callback, double sampleRate)
2 errors generated.
- platform/audio/ios/AudioDestinationIOS.h:
(AudioDestinationIOS): Remove numberOfOutputChannels argument.
- 8:51 AM Changeset in webkit [147560] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r147494): -[AVAudioSession setCategory:error:] takes NSError
Fixes the following build failure:
Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:151:71: error: cannot initialize a parameter of type 'NSError ' with an lvalue of type 'NSError *'
[[AVAudioSession sharedInstance] setCategory:categoryString error:error];
- platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::setCategory): Add '&' operator.
- 8:45 AM Changeset in webkit [147559] by
-
- 2 edits in trunk/Tools
[GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
https://bugs.webkit.org/show_bug.cgi?id=104779
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-03
Reviewed by Carlos Garcia Campos.
- Scripts/run-gtk-tests:
(TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
passing in current trunk.
- 8:45 AM Changeset in webkit [147558] by
-
- 8 edits2 adds in trunk
CSP blocks inline style when cloning a node
https://bugs.webkit.org/show_bug.cgi?id=112270
Patch by Felipe Zimmerle <felipe@zimmerle.org> on 2013-04-03
Reviewed by Adam Barth.
Source/WebCore:
Checks if the Element is being cloned, if so, the application of the
style is allowed otherwise it relies on default permission mechanism.
Test: http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects.html
- dom/Element.cpp:
(WebCore::Element::attributeChanged): Added parameter
AttributeModificationReason to the method signature.
(WebCore::Element::cloneAttributesFromElement): It is now calling
attributeChanged with AttributeModificationReason parameter. In this scope
it is always set to ModifiedByCloning.
(WebCode::Element::attributeChangedFromParserOrByCloning):
Added parameter AttributeModificationReason.
- dom/Element.h: Added AttributeModificationReason enum. Used to specify
whenever an attribute was set by a cloned oject or directly.
AttributeModificationReason added to attributeChanged with the default
value set to ModifiedDirectly.
- dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged): Added
AttributeModificationReason to the method signature.
(WebCore::StyledElement::styleAttributeChanged): Now it is checking the
reason of the update, if the reason is ModifiedDirectly check CSP
before set. If ModifiedByCloning set the attribute ignoring the CSP
policy.
- dom/StyledElement.h:
(StyledElement): Added AttributeModificationReason parameter to the methods:
attributeChanged and styleAttributeChanged, attributeChanged has
ModifiedDirectly as default value.
- svg/SVGElement.cpp:
(WebCore::SVGElement::attributeChanged): Added AttributeModificationReason
parameter to the method signature.
- svg/SVGElement.h:
(SVGElement): Added AttributeModificationReason parameter to the
attributeChanged signature with the default value set to:
ModifiedDirectly.
LayoutTests:
- http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects.html: Added.
- 8:18 AM Changeset in webkit [147557] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] WebKitWebNavigationAction: fix mix between dispose and finalize
https://bugs.webkit.org/show_bug.cgi?id=113794
Patch by Alban Crequy <alban.crequy@collabora.co.uk> on 2013-04-03
Reviewed by Gustavo Noronha Silva.
WebKitWebNavigationAction's dispose function was named finalize and was calling
the parent class's finalise function, causing a memory corruption. Change it to
be a proper finalize function instead.
- webkit/webkitwebnavigationaction.cpp:
(webkit_web_navigation_action_class_init):
- 8:11 AM Changeset in webkit [147556] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed 32bit buildfix after r147542.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveBinaryData):
- 8:09 AM Changeset in webkit [147555] by
-
- 2 edits in trunk/Source/WebCore
[Gstreamer] Avoid calls to g_slist_nth_data in webKitWebAudioSrcLoop()
https://bugs.webkit.org/show_bug.cgi?id=113875
Reviewed by Philippe Normand.
webKitWebAudioSrcLoop() was iterating over 2 GSLists by using a counter and then
calling g_slist_nth_data() to get the element of each GSList. This is inefficient
because calling g_slist_nth_data() will iterate the GSList up until index 'n'.
This patch improves this by keeping pointers to the current element of each list
while iterating, so that we can simply use g_slist_next() to iterate instead
of g_slist_nth_data().
No new tests, no behavior change.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop):
- 8:04 AM Changeset in webkit [147554] by
-
- 4 edits in trunk/Source/WebCore
Actions that require user gesture don't work in window.showModalDialog in Chromium
https://bugs.webkit.org/show_bug.cgi?id=113777
Reviewed by Jochen Eisinger.
In Chromium the window for showModalDialog is not modal which causes the
UserGestureIndicator to block actions in the sub window. We introduce a
RAII that saves the UserGestureIndicator and state, then resets it before
runModalDialog, and restore it when it's done.
No new tests. Can't cause user gesture inside modal dialog.
- dom/UserGestureIndicator.cpp:
(WebCore::UserGestureIndicatorDisabler::UserGestureIndicatorDisabler): Saves and resets the topmost indicator and state.
(WebCore):
(WebCore::UserGestureIndicatorDisabler::~UserGestureIndicatorDisabler): Restores topmost indicator and state.
- dom/UserGestureIndicator.h:
(WebCore):
(UserGestureIndicatorDisabler): RAII to temporarily disable UserGestureIndicator.
(UserGestureIndicator): Allow access to UserGestureIndicatorDisabler.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::showModalDialog): Disable UserGestureIndicator while runModalDialog.
- 8:02 AM Changeset in webkit [147553] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fail gracefully if an OpenGL context could not be created.
https://bugs.webkit.org/show_bug.cgi?id=113784
In case we fail to create or adopt a valid platform OpenGL context
we do not want to provide a GraphicsContext3D instance.
Otherwise we would crash as soon as the instance is being used.
Reviewed by Jocelyn Turcotte.
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3D::GraphicsContext3D):
- 7:36 AM Changeset in webkit [147552] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove defaultViewportArguments check from call site of recomputeVirtualViewportFromViewportArguments
https://bugs.webkit.org/show_bug.cgi?id=113872
Reviewed by Carlos Garcia Campos.
Carlos pointed out that recomputeVirtualViewportFromViewportArguments
already contains the check, and returns an empty IntSize if it fails.
So pick up on that to make the code a bit more DRY.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- 7:23 AM Changeset in webkit [147551] by
-
- 15 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening. Updated platform specific expected files after r147492.
- platform/qt/TestExpectations:
- platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
- platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
- platform/qt/fast/encoding/utf-16-big-endian-expected.png:
- platform/qt/fast/encoding/utf-16-big-endian-expected.txt:
- platform/qt/fast/encoding/utf-16-little-endian-expected.png:
- platform/qt/fast/encoding/utf-16-little-endian-expected.txt:
- platform/qt/fast/forms/input-value-expected.png: Added.
- platform/qt/fast/forms/input-value-expected.txt:
- platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.png:
- platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
- platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- 7:15 AM Changeset in webkit [147550] by
-
- 2 edits in trunk/Tools
Fix HAVE(QTTESTSUPPORT) logic
build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
resulting in HAVE(QTTESTSUPPORT) never being true.
Move that logic down in sanitizeFeatures.
Patch by Pierre Rossi <pierre.rossi@digia.com> on 2013-04-03
Rubber-stamped by Tor Arne Vestbø.
- qmake/mkspecs/features/features.prf:
- 6:23 AM Changeset in webkit [147549] by
-
- 3 edits in trunk/Source/WebCore
[GTK][AC] Implement matrix keyframe animations with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=110314
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-03
Reviewed by Gustavo Noronha Silva.
Clutter 1.12 doesn't support additive transform animations yet, So clutter ac backend
uses matrix animations for the case. This patch follows changeset 143369, 143343
to support matrix keyframe animations. I believe this change is easy if you understand
above two changesets.
Covered by existing animation tests.
- platform/graphics/clutter/PlatformClutterAnimation.cpp:
(WebCore::PlatformClutterAnimation::setValues):
(WebCore::PlatformClutterAnimation::addClutterKeyframeTransitionForProperty):
(WebCore):
(WebCore::PlatformClutterAnimation::addTransformTransition):
- platform/graphics/clutter/PlatformClutterAnimation.h:
(PlatformClutterAnimation):
- 6:20 AM Changeset in webkit [147548] by
-
- 11 edits2 adds in trunk
Should close select popup when the element loses focus
https://bugs.webkit.org/show_bug.cgi?id=113220
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-04-03
Reviewed by Kent Tamura.
Source/WebCore:
Test: fast/forms/select-popup-closes-on-blur.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): handle the blur event, closing
the popup menu if any.
- testing/Internals.cpp:
(WebCore::Internals::isSelectPopupVisible): utility to query the select node renderer to
find out whether the popup is open or closed.
(WebCore):
- testing/Internals.h: add the new method definition.
- testing/Internals.idl: ditto.
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in: export WebCore::HTMLNames::selectTag for Internals
LayoutTests:
- fast/forms/select/popup-closes-on-blur-expected.txt: Added.
- fast/forms/select/popup-closes-on-blur.html: Added.
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- 6:20 AM Changeset in webkit [147547] by
-
- 4 edits in trunk
[GTK] Bump required versions of some dependencies
https://bugs.webkit.org/show_bug.cgi?id=113282
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-03
Reviewed by Martin Robinson.
.:
This patch updates the following dependencies:
- libsoup 2.42.0: is the current stable release.
- glib 2.36.0: libsoup 2.42 requires 2.35.0, but we don't want to depend on unstable versions and 2.36 is the next stable version after 2.35.
- gtk+ 3.6.0: this is the previous stable release. We don't currently have any code using newer API, so we will be able to remove all the #ifdefed code.
- at-spi2 2.5.3: is the version required by gtk+ 3.6.
- GObject introspection 1.32.0: is the version required by gtk+ 3.6.
- Pango 1.32.0: it's the current stable version and the first one depending on Harfbuzz.
- Fontconfig 2.5: required by pango 1.32.0 when using Harfbuzz.
- gtk+ 2.24.10: it allows us to remove a lot of deprecated code and #ifdefs.
- Source/autotools/Versions.m4:
Tools:
- gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
- 6:12 AM Changeset in webkit [147546] by
-
- 2 edits in trunk/Tools
[GTK] gst-plugins-good fails to build with newer Linux(v4l2)
https://bugs.webkit.org/show_bug.cgi?id=113809
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-04-03
Reviewed by Philippe Normand.
Newer Linux kernels have removed some deprecated macros from v4l2
headers, causing gst-plugins-good's build to break. We don't need it
right now, so just disable it.
- gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
- 5:44 AM Changeset in webkit [147545] by
-
- 12 edits in trunk
[Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
https://bugs.webkit.org/show_bug.cgi?id=113535
Reviewed by Simon Hausmann.
Source/WebCore:
Now Qt uses the CROSS_PLATFORM_CONTEXT_MENUS
USE flag. This flag provides a full cross-platform
representation of a ContextMenu and a ContextMenuItem.
The embedder can then decide how to show this, so neither
WebCore nor WebCore/platform need to know any platform
specifics about menus.
No new tests, no behavior changes.
- Target.pri:
- platform/ContextMenu.h:
(ContextMenu):
- platform/ContextMenuItem.h:
- platform/qt/ContextMenuItemQt.cpp:
(WebCore::ContextMenuItem::platformContextMenuItem):
- platform/qt/ContextMenuQt.cpp:
(WebCore::ContextMenu::ContextMenu):
(WebCore::ContextMenu::getContextMenuItems):
(WebCore::ContextMenu::createPlatformContextMenuFromItems):
(WebCore::ContextMenu::platformContextMenu):
Source/WebKit/qt:
Adjust ContextMenuClientQt and QWebPageAdapter to use CROSS_PLATFORM_CONTEXT_MENUS
USE flag by implementing customizeMenu() instead of getCustomMenuFromDefaultItems()
and by calling menu->items() instead of menu->platformDescription().
- WebCoreSupport/ContextMenuClientQt.cpp:
(WebCore::ContextMenuClientQt::customizeMenu):
- WebCoreSupport/ContextMenuClientQt.h:
(ContextMenuClientQt):
- WebCoreSupport/QWebPageAdapter.cpp:
(descriptionForPlatformMenu):
(QWebPageAdapter::updatePositionDependentMenuActions):
Tools:
Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
- qmake/mkspecs/features/features.prf:
- 5:35 AM Changeset in webkit [147544] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Monospace font does not render in proper sizes
https://bugs.webkit.org/show_bug.cgi?id=93263
Reviewed by Jocelyn Turcotte.
Remove this patch's artificial dependency on Qt 5.1.
- platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- 5:33 AM Changeset in webkit [147543] by
-
- 3 edits in trunk/Tools
[Qt] Move logic of simple forwarding functions to TestRunner.
https://bugs.webkit.org/show_bug.cgi?id=113863
Reviewed by Simon Hausmann.
- DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::setTextDirection):
(TestRunner::goBack):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::addUserStyleSheet):
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
- 5:15 AM Changeset in webkit [147542] by
-
- 6 edits in trunk/Source/WebCore
Refine LOG messages in WebSocket related components
https://bugs.webkit.org/show_bug.cgi?id=113852
Patch by Takeshi Yoshino <tyoshino@chromium.org> on 2013-04-03
Reviewed by Kent Tamura.
Refine LOG messages by
- Make them contain method names to ease identifying where the event occurred.
- For consistency, make all messages print the pointer of the origin instance.
- Quote UTF8 data in LOG messages.
- For overloaded methods, add the type to clarify which one is run
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::contextDestroyed):
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didReceiveMessage):
(WebCore::WebSocket::didReceiveBinaryData):
(WebCore::WebSocket::didReceiveMessageError):
(WebCore::WebSocket::didUpdateBufferedAmount):
(WebCore::WebSocket::didStartClosingHandshake):
(WebCore::WebSocket::didClose):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::subprotocol):
(WebCore::WebSocketChannel::extensions):
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::bufferedAmount):
(WebCore::WebSocketChannel::close):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::disconnect):
(WebCore::WebSocketChannel::willOpenSocketStream):
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::didStartLoading):
(WebCore::WebSocketChannel::didReceiveData):
(WebCore::WebSocketChannel::didFinishLoading):
(WebCore::WebSocketChannel::didFail):
(WebCore::WebSocketChannel::appendToBuffer):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::closingTimerFired):
- Modules/websockets/WebSocketDeflater.cpp:
(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::WebSocketInflater::~WebSocketInflater):
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readServerHandshake):
- platform/network/chromium/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandleInternal::connect):
(WebCore::SocketStreamHandleInternal::send):
(WebCore::SocketStreamHandleInternal::close):
(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didSendData):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):
- 4:56 AM Changeset in webkit [147541] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Update QMAKE_MAC_SDK check for Qt 5.1
Relies on QMAKE_MAC_SDK_VERSION set in features.prf
Reviewed by Simon Hausmann.
- WebCore.pri:
- 4:56 AM Changeset in webkit [147540] by
-
- 2 edits in trunk/Tools
[Qt] Disable media support using QuickTime if deployment target != SDK
We link to a single libWebKitSystemInterface static lib, so unless the
deployment target matches the SDK let's not pretend like we'll be able
to run on anything lower than the SDK version.
Reviewed by Simon Hausmann.
- qmake/mkspecs/features/features.prf:
- 4:15 AM Changeset in webkit [147539] by
-
- 2 edits in trunk/Source/WebCore
[Qt] assignToHTMLImageElement no longer exists in Qt5
https://bugs.webkit.org/show_bug.cgi?id=113639
Patch by Kristof Provost <kristof@codepro.be> on 2013-04-03
Reviewed by Simon Hausmann.
No new tests: covered by ./Source/WebKit/qt/tests/hybridPixmap/test.html
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapRuntime::getClassRef):
- 4:06 AM Changeset in webkit [147538] by
-
- 5 edits1 copy1 add in trunk
Web Inspector: crash in WebCore::InspectorLayerTreeAgent::buildObjectForLayer if a layer is created for an anonymous RenderObject (:first-letter)
https://bugs.webkit.org/show_bug.cgi?id=113768
Source/WebCore:
The InspectorLayerTreeAgent now knows how to deal with anonymous RenderObjects
for the :first-letter and :first-line pseudo-elements.
Reviewed by Timothy Hatcher.
Test: inspector-protocol/layers/layers-anonymous.html
- inspector/Inspector.json:
Change the Layer type in the LayerTree domain to have more accurate terminology
(pseudo-element vs. pseudo-class) and a new optional isAnonymous flag for layers
associated to anonymous RenderObjects.
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
Check for anonymous RenderObjects and set the parent renderer's node as the node
for this layer since anonymous renderers have the Document as their node and this
would not be satisfactory to show in a front-end. We also check for anonymous
RenderObjects for the :first-letter and :first-line pseudo-elements and set them
in the pseudoElement property of the Layer object created such that a front-end
could correctly identify what type of pseudo-element for the associated node
yielded this layer.
(WebCore::InspectorLayerTreeAgent::idForNode):
Here we fix the actual crash by first checking if the node provided is null and
returning 0 if there's no such node. This ensures that any scenario where there
is no node associated with the RenderObject simply informs of the front-end that
no such node exists and we do not crash.
LayoutTests:
Reviewed by Timothy Hatcher.
- inspector-protocol/layers/layers-anonymous-expected.txt: Added.
- inspector-protocol/layers/layers-anonymous.html: Added.
New test for layers created for CSS anonymous boxes or blocks.
- inspector-protocol/layers/layers-generated-content.html:
Update test to use the "pseudoElement" property instead of "pseudoClass"
which was the previous, less accurate name.
- 4:06 AM Changeset in webkit [147537] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Decouple layout viewport from visual viewport
https://bugs.webkit.org/show_bug.cgi?id=113829
Reviewed by Carlos Garcia Campos.
Setting the visual viewport would force the layout viewport equal to
the visual viewport. Decouple the viewports by allowing the user to
specify a layout viewport when setting the viewport(s). The layout
viewport could be the exact same value passed for visual viewport, if
the old behavior is desired.
Also reevaluate any viewport arguments when (only) the layout viewport
changes in WebPage::setDefaultLayoutSize() since the layout viewport is
used as input to the calculation.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setScreenOrientation):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::setViewportSize):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPage::defaultLayoutSize):
- Api/WebPage.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- 3:59 AM Changeset in webkit [147536] by
-
- 13 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaselining after r147530.
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- 3:24 AM Changeset in webkit [147535] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [REGRESSION(r147117)][Elements] Copy/paste keyboard shortcuts broken in "Edit as HTML"
https://bugs.webkit.org/show_bug.cgi?id=113798
Reviewed by Yury Semikhatsky.
Stop propagation of "copy" event from the multiline editor's
CodeMirror host element so that it is not handled by
WebInspector.documentCopy().
- inspector/front-end/UIUtils.js:
(.consumeCopy):
(.cleanUpAfterEditing):
- inspector/front-end/inspector.js:
(WebInspector.addMainEventListeners):
- 2:49 AM Changeset in webkit [147534] by
-
- 4 edits in trunk/LayoutTests
[EFL] accessibility/ignore-spacer-elements.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112001
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-04-03
Reviewed by Gyuyoung Kim.
Fixed failing test. The reason of failure is different expectation of childrenCount.
- accessibility/ignore-spacer-elements.html:
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- 2:48 AM Changeset in webkit [147533] by
-
- 3 edits3 adds in trunk
With borders of differing alpha, the corners become squared off
https://bugs.webkit.org/show_bug.cgi?id=113744
Reviewed by Simon Fraser.
Source/WebCore:
paintTranslucentBorderSides should pick up borders with common color
in order: top, bottom, left and right (not top, right, bottom and
left), because willBeOverdrawn depends on the assumption, borders are
drawn in order: top, bottom, left and right.
Test: fast/borders/border-left-right-same-bottom-different-color.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
LayoutTests:
- fast/borders/border-left-right-same-bottom-different-color-expected.txt: Added.
- fast/borders/border-left-right-same-bottom-different-color.html: Added.
- platform/chromium-linux/fast/borders/border-left-right-same-bottom-different-color-expected.png: Added.
- 2:45 AM Changeset in webkit [147532] by
-
- 2 edits4 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Updated platform specific expected files.
- platform/qt/TestExpectations: Skipped failing reftest.
- platform/qt/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added after r147502.
- platform/qt/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added after r147502.
- platform/qt/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added after r147502.
- platform/qt/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added after r147502.
- 2:31 AM Changeset in webkit [147531] by
-
- 2 edits in trunk/Source/WebCore
[New Multicolumn]Remove assert in RenderMultiColumnFlowThread::createAnonymous
https://bugs.webkit.org/show_bug.cgi?id=113855
Reviewed by Antti Koivisto.
Remove CSSRegions specific assert from new multicolumn implementation.
No change in functionality, no new tests.
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::createAnonymous):
- 2:28 AM Changeset in webkit [147530] by
-
- 22 edits in trunk
X-Frame-Options: Blocked frames should not inherit their parent's SecurityOrigin.
https://bugs.webkit.org/show_bug.cgi?id=112903
Reviewed by Adam Barth.
Source/WebCore:
This change brings WebKit in line with IE and Gecko's behavior, both of
which treat the blocked frame as being cross-origin for the purposes of
access checks ('[frame].contentWindow.location.href' is inaccessible,
for example).
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
Rather than redirecting to 'about:blank', redirect to a URL which
does not inherit the SecurityOrigin of the parent.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
Before calling cancelMainResourceLoad, ensure that the frame's
document is sandboxed into a unique origin so that it doesn't inherit
the parent's SecurityOrigin.
LayoutTests:
- http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html:
- http/tests/security/XFrameOptions/x-frame-options-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- 2:19 AM Changeset in webkit [147529] by
-
- 9 edits1 add in trunk/Source
[Chromium] Implement target-densityDpi viewport property emulation
https://bugs.webkit.org/show_bug.cgi?id=110835
The value is only used in the Chromium port, when the corresponding
setting is enabled.
This is needed for supporting existing WebView-based applications
that rely on this property.
Reviewed by Adam Barth.
Source/WebCore:
- dom/ViewportArguments.cpp:
(WebCore::findTargetDensityDPIValue):
(WebCore):
(WebCore::setViewportFeature):
- dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):
Source/WebKit/chromium:
- public/WebSettings.h:
(WebSettings):
- src/ChromeClientImpl.cpp:
(WebKit):
(WebKit::calculateTargetDensityDPIFactor):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setSupportDeprecatedTargetDensityDPI):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::supportDeprecatedTargetDensityDPI):
- tests/WebFrameTest.cpp:
- tests/data/viewport-target-densitydpi-high.html: Added.
- 1:56 AM Changeset in webkit [147528] by
-
- 14 edits in trunk/LayoutTests
Unreviewed, rolling out r147409.
http://trac.webkit.org/changeset/147409
https://bugs.webkit.org/show_bug.cgi?id=113856
The baselines should be reverted after r147450. (Requested by
kadam on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-03
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- platform/qt/TestExpectations:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- 1:38 AM Changeset in webkit [147527] by
-
- 82 edits3 moves in trunk/LayoutTests
Unreviewed. Rebaseline several tests for Chromium that have better output after
r147492.
- platform/chromium-linux/editing/selection/select-missing-image-expected.png:
- platform/chromium-linux/fast/block/float/002-expected.png:
- platform/chromium-linux/fast/block/float/017-expected.png:
- platform/chromium-linux/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/chromium-linux/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-linux/fast/flexbox/023-expected.png:
- platform/chromium-linux/fast/flexbox/024-expected.png:
- platform/chromium-linux/fast/forms/input-value-expected.png:
- platform/chromium-linux/fast/forms/input-value-expected.txt:
- platform/chromium-linux/fast/invalid/012-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.png:
- platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/chromium-mac-lion/editing/selection/select-missing-image-expected.png:
- platform/chromium-mac-lion/fast/block/float/002-expected.png:
- platform/chromium-mac-lion/fast/block/float/017-expected.png:
- platform/chromium-mac-lion/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/chromium-mac-lion/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/chromium-mac-lion/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-mac-lion/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-mac-lion/fast/flexbox/023-expected.png:
- platform/chromium-mac-lion/fast/flexbox/024-expected.png:
- platform/chromium-mac-lion/fast/forms/005-expected.png:
- platform/chromium-mac-lion/fast/forms/input-value-expected.png:
- platform/chromium-mac-lion/fast/invalid/012-expected.png:
- platform/chromium-mac-lion/fast/parser/comment-in-script-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug2997-expected.png:
- platform/chromium-mac-lion/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/chromium-mac-snowleopard/fast/block/float/002-expected.png:
- platform/chromium-mac-snowleopard/fast/block/float/017-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/chromium-mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-mac-snowleopard/fast/flexbox/023-expected.png:
- platform/chromium-mac-snowleopard/fast/flexbox/024-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
- platform/chromium-mac-snowleopard/fast/invalid/012-expected.png:
- platform/chromium-mac-snowleopard/fast/parser/comment-in-script-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2997-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/chromium-mac/editing/selection/select-missing-image-expected.png:
- platform/chromium-mac/fast/block/float/002-expected.png:
- platform/chromium-mac/fast/block/float/017-expected.png:
- platform/chromium-mac/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/chromium-mac/fast/dom/HTMLImageElement/image-alt-text-expected.txt: Renamed from LayoutTests/platform/chromium/fast/dom/HTMLImageElement/image-alt-text-expected.txt.
- platform/chromium-mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/chromium-mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Renamed from LayoutTests/platform/chromium/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt.
- platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.txt:
- platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.txt:
- platform/chromium-mac/fast/flexbox/023-expected.png:
- platform/chromium-mac/fast/flexbox/024-expected.png:
- platform/chromium-mac/fast/forms/005-expected.png:
- platform/chromium-mac/fast/forms/input-value-expected.png:
- platform/chromium-mac/fast/forms/input-value-expected.txt:
- platform/chromium-mac/fast/invalid/012-expected.png:
- platform/chromium-mac/fast/parser/comment-in-script-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug2997-expected.png:
- platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.txt: Renamed from LayoutTests/platform/chromium/tables/mozilla/collapsing_borders/bug41262-3-expected.txt.
- platform/chromium-win/editing/selection/select-missing-image-expected.png:
- platform/chromium-win/fast/block/float/002-expected.png:
- platform/chromium-win/fast/block/float/017-expected.png:
- platform/chromium-win/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/chromium-win/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
- platform/chromium-win/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/chromium-win/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
- platform/chromium-win/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-win/fast/encoding/utf-16-big-endian-expected.txt:
- platform/chromium-win/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-win/fast/encoding/utf-16-little-endian-expected.txt:
- platform/chromium-win/fast/flexbox/023-expected.png:
- platform/chromium-win/fast/flexbox/024-expected.png:
- platform/chromium-win/fast/forms/input-value-expected.png:
- platform/chromium-win/fast/forms/input-value-expected.txt:
- platform/chromium-win/fast/invalid/012-expected.png:
- platform/chromium-win/fast/parser/comment-in-script-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug2997-expected.png:
- platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- platform/chromium/TestExpectations:
- 1:31 AM Changeset in webkit [147526] by
-
- 4 edits in trunk/Source/WebCore
Extract URL that doesn't inherit a parent's SecurityOrigin out into a constant.
https://bugs.webkit.org/show_bug.cgi?id=113780
Reviewed by Jochen Eisinger.
We're scheduling navigations to 'data:text/html,' in XSSAuditor in
order to end up on a page that doesn't inherit its parent's
SecurityOrigin. We'll be reusing this mechainsm to solve
http://wkbug.com/112903
This patch makes us more explicit about what we're doing and why.
It doesn't change any behavior: XSSAuditor tests should still pass.
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
Use SecurityOrigin::urlWithUniqueSecurityOrigin rather than a
literal string to make our intentions clear.
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::urlWithUniqueSecurityOrigin):
- page/SecurityOrigin.h:
Add the new static method.
- 1:21 AM Changeset in webkit [147525] by
-
- 7 edits in trunk/Source
Remove code for Mac 10.5 and earlier from WTF and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=113844
Reviewed by Benjamin Poulain.
Removed the code for 10.5 and removed if-def for 10.6.
Source/WebKit2:
- Shared/mac/PasteboardTypes.mm:
(WebKit::PasteboardTypes::forEditing):
Source/WTF:
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- wtf/Platform.h:
- wtf/ThreadingPthreads.cpp:
(WTF::initializeCurrentThreadInternal):
- wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::userDefault):
- 12:54 AM Changeset in webkit [147524] by
-
- 14 edits in trunk/LayoutTests
Unreviewed, rebaseline several tests cases for GTK that have better results
after r147492.
- platform/gtk/TestExpectations:
- platform/gtk/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/gtk/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
- platform/gtk/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/gtk/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
- platform/gtk/fast/encoding/utf-16-big-endian-expected.png:
- platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
- platform/gtk/fast/encoding/utf-16-little-endian-expected.png:
- platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
- platform/gtk/fast/forms/input-value-expected.png:
- platform/gtk/fast/forms/input-value-expected.txt:
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
Apr 2, 2013:
- 11:56 PM Changeset in webkit [147523] by
-
- 3 edits in trunk/Source/WebCore
clean up static casts in WebAccessibilityObjectWrapperMac.mm to methods like toAccessibilityList()
https://bugs.webkit.org/show_bug.cgi?id=113828
Reviewed by Tim Horton.
static_cast changed to toAccessibilityList().
- accessibility/AccessibilityList.h:
(WebCore::toAccessibilityList):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
- 11:52 PM Changeset in webkit [147522] by
-
- 6 edits in trunk/LayoutTests
Update expectations for fast/css3-text/css3-text-indent/text-indent-each-line.html
https://bugs.webkit.org/show_bug.cgi?id=113848
Mark as [ Failure ImageOnlyFailure ] for fast/css3-text/css3-text-indent/.
Unreviewed gardening.
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-02
- platform/mac/TestExpectations:
- platform/qt-mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 11:40 PM Changeset in webkit [147521] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r147370.
http://trac.webkit.org/changeset/147370
https://bugs.webkit.org/show_bug.cgi?id=113850
This patch is causing crashes in video tests on all Mac bots.
(Requested by jernoble_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-02
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
- 11:17 PM Changeset in webkit [147520] by
-
- 21 edits in trunk
AXRoleDescripton for DL is "list"; should be "description list"
https://bugs.webkit.org/show_bug.cgi?id=111665
Patch by James Craig <james@cookiecrook.com> on 2013-04-02
Reviewed by Chris Fleizach.
Source/WebCore:
Defining the role and description strings, and accessors for DL.
This previously relied on getting the role and description from the platform API.
Updated existing test coverage.
- English.lproj/Localizable.strings:
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
- platform/LocalizedStrings.cpp:
(WebCore::AXDescriptionListText):
(WebCore):
- platform/LocalizedStrings.h:
(WebCore):
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::AXDescriptionListText):
(WebCore):
- platform/chromium/LocalizedStringsChromium.cpp:
(WebCore::AXDescriptionListText):
(WebCore):
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::AXDescriptionListText):
(WebCore):
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXDescriptionListText):
(WebCore):
- platform/qt/LocalizedStringsQt.cpp:
(WebCore::AXDescriptionListText):
(WebCore):
Source/WebKit/chromium:
Defining the role and description strings.
- public/WebAccessibilityRole.h:
- src/AssertMatchingEnums.cpp:
Tools:
Defining the role and description strings.
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
LayoutTests:
Updating expectation strings for DL role description.
- platform/mac/accessibility/lists-expected.txt:
- platform/mac/accessibility/role-subrole-roledescription-expected.txt:
- platform/mac/accessibility/role-subrole-roledescription.html:
- 11:00 PM Changeset in webkit [147519] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Network] Split business logic and presentation for initiator column.
https://bugs.webkit.org/show_bug.cgi?id=113486
Reviewed by Pavel Feldman.
Currently business logic and presentation are mixed.
This prevents making cell renderer static and applying
viewport rendering, because initiator sorting function
depends on data written when cell is rendered.
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
Removed business logic. Use "initiatorInfo".
(WebInspector.NetworkDataGridNode.InitiatorComparator):
Use "initiatorInfo".
- inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.initiatorInfo):
Extracted business logic from "refreshInitiatorCell".
- 10:39 PM Changeset in webkit [147518] by
-
- 1 edit4 adds in trunk/LayoutTests
Unreviewed gardening; rebaseline mac expected results after r147470.
- platform/mac/css3/filters/effect-reference-composite-expected.png: Added.
- platform/mac/css3/filters/effect-reference-composite-expected.txt: Added.
- platform/mac/css3/filters/effect-reference-composite-hw-expected.png: Added.
- platform/mac/css3/filters/effect-reference-composite-hw-expected.txt: Added.
- 9:56 PM Changeset in webkit [147517] by
-
- 2 edits in trunk/Source/WebCore
needsLeopardMailQuirks should be removed
https://bugs.webkit.org/show_bug.cgi?id=113749
Reviewed by Benjamin Poulain.
Removed needsLeopardMailQuirks from settings.in after r147447.
- page/Settings.in:
- 8:46 PM Changeset in webkit [147516] by
-
- 2 edits1 add in trunk/LayoutTests
[EFL] Unskip and update inspector tests
https://bugs.webkit.org/show_bug.cgi?id=113840
Unreviewed gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-02
- platform/efl/TestExpectations:
- platform/efl/http/tests/inspector/console-websocket-error-expected.txt: Added.
- 7:50 PM Changeset in webkit [147515] by
-
- 2 edits in trunk/LayoutTests
Unskip filter-fallback-to-software.html on Mac WK2 Release
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-02
- platform/mac-wk2/TestExpectations:
The test seems to pass in Release. Let's see how the bots feel about that.
- 6:41 PM Changeset in webkit [147514] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG should compile a little sooner
https://bugs.webkit.org/show_bug.cgi?id=113835
Unreviewed.
Rolled out r147511 because it was based on incorrect performance
measurement.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::optimizationThresholdScalingFactor):
- 6:32 PM Changeset in webkit [147513] by
-
- 6 edits2 adds in trunk
Source/WebCore: [css3-text] Rendering -webkit-each-line value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=113259
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-02
Reviewed by Levi Weintraub.
CSS3 TEXT introduces new value, "each-line" for text-indent.
Indentation affects the first line of the block container as well as each line
after a forced line break, but does not affect lines after a soft wrap break.
This patch is the rendering part to support each-line value for text-indent.
It's prefixed and guarded by CSS3_TEXT flag.
Test: fast/css3-text/css3-text-indent/text-indent-each-line.html
- rendering/RenderBlock.h:
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::startOffsetForLine):
(WebCore::RenderBlock::endOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
Rename a parameter from firstLine to shouldIndentText.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::shouldIndentText): Return boolean according to m_shouldIndentText.
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
(WebCore::LineWidth::fitBelowFloats):
Add enum IndentTextOrNot and m_shouldIndentText.
Use m_shouldIndentText instead of m_isFirstLine.
(WebCore::requiresIndent): Decide whether text indentation is required.
(WebCore::updateLogicalInlinePositions):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests: [css3-text] Rendering -webkit-each-line value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=113259
CSS3 TEXT introduces new value, "each-line" for text-indent.
Indentation affects the first line of the block container as well as each line
after a forced line break, but does not affect lines after a soft wrap break.
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-02
Reviewed by Levi Weintraub.
- fast/css3-text/css3-text-indent/text-indent-each-line-expected.html: Added.
- fast/css3-text/css3-text-indent/text-indent-each-line.html: Added.
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 5:35 PM Changeset in webkit [147512] by
-
- 8 edits in branches/safari-536.29-branch/Source/WebKit2
Merged 147052 <rdar://problem/13528851>
- 5:34 PM Changeset in webkit [147511] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG should compile a little sooner
https://bugs.webkit.org/show_bug.cgi?id=113835
Reviewed by Michael Saboff.
2% speedup on SunSpider.
2% speedup on JSRegress.
Neutral on Octane, v8, and Kraken.
The worst-hit single sub-test is kraken-stanford-crypto-ccm.js, which gets
18% slower. Since Kraken is neutral overall in its preferred mean, I
think that's OK for now.
(Our array indexing speculation fails pathologically on
kraken-stanford-crypto-ccm.js. Compiling sooner is a regression because
it triggers those failures sooner. I'm going to file some follow-up bugs
explaining how to fix our speculations on this sub-test, at which point
compiling earlier should become a slight speedup on Kraken overall.)
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::optimizationThresholdScalingFactor): I experimented
with a few different options, including reducing the coefficient 'a'.
A simple linear reduction on instruction count worked best.
- 5:28 PM Changeset in webkit [147510] by
-
- 2 edits in trunk/LayoutTests
Compositing tests failing after http://trac.webkit.org/changeset/147502
https://bugs.webkit.org/show_bug.cgi?id=113838
Temporarily marking as failing.
- platform/mac/TestExpectations:
- 5:08 PM Changeset in webkit [147509] by
-
- 2 edits in trunk/Tools
Unreviewed. Disable running tests on Win EWS queue.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 4:34 PM Changeset in webkit [147508] by
-
- 3 edits in trunk/Source/WebKit2
Be more robust against empty message receiver names in incoming messages
https://bugs.webkit.org/show_bug.cgi?id=113833
<rdar://problem/13284433>
Reviewed by Beth Dakin.
Turns out that we either send or receive messages whose receiver names are empty. This leads to bad things when we try to look
up the message receiver name in a hash map since the empty name is used to represent an empty hash map value.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::addWorkQueueMessageReceiverOnConnectionWorkQueue):
Sprinkle assertions.
(CoreIPC::Connection::processIncomingMessage):
If the message receiver name is not valid, make sure to call didReceiveInvalidMessage on the client thread.
(CoreIPC::Connection::dispatchDidReceiveInvalidMessage):
Add new helper function.
- 4:31 PM Changeset in webkit [147507] by
-
- 2 edits1 add in trunk/PerformanceTests
Need japanese line layout performance test
https://bugs.webkit.org/show_bug.cgi?id=113811
Reviewed by Ryosuke Niwa.
Will be used by https://bugs.webkit.org/show_bug.cgi?id=105692 to test potential performance regression
for Japanese (and other CJK) line break changes.
- Layout/LineLayoutJapanese.html: Added.
- Skipped: Skip this test by default.
- 4:28 PM Changeset in webkit [147506] by
-
- 3 edits in trunk/Source/WebCore
Generalize prior line break context state and names.
https://bugs.webkit.org/show_bug.cgi?id=113823
Reviewed by Darin Adler.
No new tests required due to no behavioral change.
- platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::lastCharacter):
(WebCore::LazyLineBreakIterator::secondToLastCharacter):
(WebCore::LazyLineBreakIterator::setPriorContext):
(WebCore::LazyLineBreakIterator::updatePriorContext):
(WebCore::LazyLineBreakIterator::resetPriorContext):
(WebCore::LazyLineBreakIterator::resetStringAndReleaseIterator):
Store previous characters as prior context buffer used directly
by line break iterator implementation. Rename members to reflect
somewhat more general usage. Also fix bad indentations.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
Use renamed line break iterator methods.
- 4:17 PM Changeset in webkit [147505] by
-
- 3 edits2 adds in trunk
Padding applied twice for empty generated RenderInlines
https://bugs.webkit.org/show_bug.cgi?id=113800
Source/WebCore:
Reviewed by Levi Weintraub.
The padding for empty generated content render objects is
incorrectly applied twice. Regression from r140693.
Test: fast/css-generated-content/margin-empty-content.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth):
LayoutTests:
Reviewed by Levi Weintraub.
Add test for empty generated content with padding.
- fast/css-generated-content/margin-empty-content-expected.html: Added.
- fast/css-generated-content/margin-empty-content.html: Added.
- 4:10 PM Changeset in webkit [147504] by
-
- 4 edits2 adds in trunk
Source/WebCore: InlineIterator needs to be updated when RenderCombineText shrinks at a line break
https://bugs.webkit.org/show_bug.cgi?id=113733
Reviewed by Emil A Eklund.
Update stale InlineIterators that point beyond the end of a RenderCombineText that's
shrunk when RenderCombineText::combineText() is called.
Test: fast/text/international/combine-at-line-break-crash.html
- rendering/BidiRun.h:
(WebCore::BidiRun::BidiRun): Adding an assertion that runs are created within
the bounds of their associated RenderText.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::iteratorIsBeyondEndOfRenderCombineText): Added.
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Update stale iterators.
LayoutTests: InlineIterator needs to be updated when RenderCombineText shrinks at a line break
https://bugs.webkit.org/show_bug.cgi?id=113732
Reviewed by Emil A Eklund.
- fast/text/international/combine-at-line-break-crash-expected.txt: Added.
- fast/text/international/combine-at-line-break-crash.html: Added.
- 3:51 PM Changeset in webkit [147503] by
-
- 3 edits in trunk/LayoutTests
Use cross-port testRunner methods in fast/loader/url-selected-user-gesture.html
https://bugs.webkit.org/show_bug.cgi?id=113827
Reviewed by Benjamin Poulain.
- fast/loader/url-selected-user-gesture-expected.txt:
- fast/loader/url-selected-user-gesture.html:
- 3:31 PM Changeset in webkit [147502] by
-
- 18 edits6 copies12 adds2 deletes in trunk
[CSS Filters] Filter outsets clipped on composited layers when filter is applied after first layout
https://bugs.webkit.org/show_bug.cgi?id=109098
Reviewed by Dean Jackson.
Source/WebCore:
This patch addresses the following issues:
(1) Compositors who can compute their own filter outsets don't need WebKit to inflate the
composited layer bounds. Eventually, all platforms' compositors should be able to
compute their own filter outsets.
(2) When filter outsets change, we need to update composited layer bounds if the filters are
painted in software.
(3) When filter outsets change, we need to recompute the overlap map to promote the correct
layers to composited layers on all platforms.
Tests: css3/filters/composited-layer-bounds-after-sw-blur-animation.html
css3/filters/composited-layer-bounds-with-composited-blur.html
css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change.html
css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow.html
css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow.html
- platform/graphics/IntRectExtent.h:
(WebCore::IntRectExtent::isZero):
(IntRectExtent):
Make isZero public on IntRectExtent.
- rendering/RenderLayer.cpp:
(WebCore::hasOrHadFilters):
Helper function used to exit early from filters related code.
(WebCore::RenderLayer::updateFilters):
Move filter updating code from RenderLayer::styleChanged into this new method.
This method calls RenderLayerBacking::updateFilters instead of
RenderLayerBacking::updateGraphicsLayerGeometry. RenderLayerBacking::updateFilters lets
us know whether there was a filter paint mode change (i.e. the filters were painted in
software and are now painted in the compositor, or vice-versa). We need to know this
earlier, in RenderLayer::styleChanged, because we may need to rebuild the compositing
layers due to a filter paint mode change.
(WebCore::RenderLayer::styleChanged):
Add a condition for filters for setCompositingLayersNeedRebuild. If the filter outsets
on a layer changed, we need to rebuild the compositing layers because there could be new
overlap. Likewise, if there are or were filter outsets and the filter paint mode changed
the layer bounds (and child positions) may have changed. In either case, we don't
rebuild the compositing layers if there is an accelerated filter animation running.
Remove old code to detect a filter paint mode change from the end of
RenderLayer::styleChanged because it could never be executed. The old code counted on
RenderLayerBacking::canCompositeFilters to change on its own, but it doesn't change
unless updateFilters gets called. Thus, we could never enter the if statement that
calls setBackingNeedsRepaint.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateFilters):
Now return true if there was a filter paint mode change, so RenderLayer::styleChanged
can decide if it should rebuild the compositing layers.
Call updateOrRemoveFilterEffectRenderer and setContentsNeedDisplay if there was a
render mode change. We need to either destroy or create the software renderer and we
need to repaint the layer contents if there was a render mode change.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
Don't call updateFilters here. Call it earlier in RenderLayer::styleChanged, for reasons
explained above.
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
Make updateFilters public so RenderLayer::styleChanged can call it.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
If the platform's compositor computes filter outsets for its layers internally, do not
inflate WebKit's composited bounds for filter outsets. This results in smaller layers
on Safari. Note that we still need to include filter outsets in layer bounds for other
situations like overlap testing in WebKit and when we're painting filters in software.
Source/WTF:
- wtf/Platform.h:
Add flag for HAVE(COMPOSITOR_FILTER_OUTSETS) macro. This is used to check if a
platform's compositor expands layers internally for filter outsets when it applies
filters like drop-shadow and blur. Currently, only CoreAnimation does has this
capability.
LayoutTests:
- compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
The above tests needed rebaselining because we're now using smaller layers on Safari.
We aren't inflating layers for filter outsets since CoreAnimation does it for us
already.
- css3/filters/composited-layer-bounds-after-sw-blur-animation-expected.txt: Added.
- css3/filters/composited-layer-bounds-after-sw-blur-animation.html: Added.
- css3/filters/composited-layer-bounds-with-composited-blur-expected.txt: Added.
- css3/filters/composited-layer-bounds-with-composited-blur.html: Added.
- css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt: Added.
- css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change.html: Added.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow-expected.txt: Added.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow.html: Added.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow-expected.txt: Added.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow.html: Added.
The above tests are all new. They mostly test edge cases with filter render mode
changes, filter outset changes, and composited layer promotion due to overlap.
Before this patch, composited-layer-bounds-after-sw-blur-animation.html breaks
visibly on Safari WebKit nightly. The blur filter in the test appears clipped before
this patch. The other tests render the same before and after this patch, but now their
layer sizes are smaller.
- css3/filters/filter-change-repaint-composited-expected.png:
- css3/filters/filter-change-repaint-composited.html:
This test has been expanded with two more cases, including the original reproduction of
this bug. The test needs rebaselining on Chromium Linux and Win.
- platform/chromium-win/css3/filters/filter-change-repaint-composited-expected.png: Removed.
- platform/chromium/TestExpectations:
- platform/chromium/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added.
- platform/chromium/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added.
- platform/chromium/css3/filters/composited-layer-bounds-after-sw-blur-animation-expected.txt: Added.
- platform/chromium/css3/filters/composited-layer-bounds-with-composited-blur-expected.txt: Added.
- platform/chromium/css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt: Added.
- platform/chromium/css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow-expected.txt: Added.
- platform/chromium/css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow-expected.txt: Added.
We need different expectations for Chromium for the new tests because layer bounds
include filter outsets on Chromium but not on Safari.
- platform/chromium/css3/filters/filter-change-repaint-composited-expected.png: Added.
- platform/qt/TestExpectations:
Note that we need baselines on Qt for the new and updated tests.
- 2:52 PM Changeset in webkit [147501] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Unreviewed, rolling out r147423.
The change r147402 was reverted by r147450.
The rebaseline introduced by r147423 needs to be reverted.
- platform/mac-wk2/http/tests/security/XFrameOptions: Removed.
- platform/mac-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
- platform/mac/http/tests/security/XFrameOptions: Removed.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
- 2:49 PM Changeset in webkit [147500] by
-
- 2 edits in trunk/Source/WebKit2
[Mac][WK2] Donât let plug-ins use System V shared memory
https://bugs.webkit.org/show_bug.cgi?id=113466
<rdar://problem/13159030>
Reviewed, tweaked and landed by Alexey Proskuryakov.
Instead of allowing plug-ins to request System V shm, give them a
temporary but usable alternative if they try to request it.
- PluginProcess/mac/PluginProcessShim.mm:
- 2:31 PM WebKitGTK/2.0.x edited by
- (diff)
- 2:24 PM Changeset in webkit [147499] by
-
- 9 edits in trunk
[GTK] Make libsecret optional
https://bugs.webkit.org/show_bug.cgi?id=113821
Reviewed by Gustavo Noronha Silva.
.:
Add a configuration option to disable credential storage and thus remove
the libsecret dependency. This should make it possible to build WebKit 2.x
on Windows again.
- Source/autotools/FindDependencies.m4: Only look for libsecret if credential storage is active.
- Source/autotools/PrintBuildConfiguration.m4: Print whether or not credential storage is active.
- Source/autotools/ReadCommandLineArguments.m4: Added an option to control credential storage.
- Source/autotools/SetupAutoconfHeader.m4: Expose credential storage setting to code.
Source/WebCore:
Don't try to use libsecret if credential storage is disabled.
- platform/gtk/GRefPtrGtk.cpp: Protect libsecret sections.
- platform/gtk/GRefPtrGtk.h: Ditto.
- platform/network/gtk/CredentialBackingStore.cpp: Ditto.
- 2:23 PM Changeset in webkit [147498] by
-
- 2 edits8 adds4 deletes in trunk/LayoutTests
Unreviewed, chromium gardening.
- platform/chromium-linux/css3/filters/effect-reference-composite-expected.png: Removed.
- platform/chromium-linux/css3/filters/effect-reference-composite-expected.txt: Removed.
- platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.png: Removed.
- platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.txt: Removed.
- platform/chromium-mac/css3/filters/effect-reference-composite-expected.png: Added.
- platform/chromium-mac/css3/filters/effect-reference-composite-expected.txt: Added.
- platform/chromium-mac/css3/filters/effect-reference-composite-hw-expected.png: Added.
- platform/chromium-mac/css3/filters/effect-reference-composite-hw-expected.txt: Added.
- platform/chromium-win/css3/filters/effect-reference-composite-expected.png: Added.
- platform/chromium-win/css3/filters/effect-reference-composite-expected.txt: Added.
- platform/chromium-win/css3/filters/effect-reference-composite-hw-expected.png: Added.
- platform/chromium-win/css3/filters/effect-reference-composite-hw-expected.txt: Added.
- platform/chromium/TestExpectations:
- 2:21 PM Changeset in webkit [147497] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] API update for IntRect
https://bugs.webkit.org/show_bug.cgi?id=113824
Patch by Maxim Mogilnitsky <mmogilnitsky@rim.com> on 2013-04-02
Reviewed by Rob Buis.
Modifing IntRect and FloatRect API.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
- 2:19 PM Changeset in webkit [147496] by
-
- 1 edit2 deletes in trunk/LayoutTests
Unreviewed, rolling out r147423.
http://trac.webkit.org/changeset/147423
https://bugs.webkit.org/show_bug.cgi?id=113775
The change r147402 was reverted by r147450.
The rebaseline introduced by r147423 needs to be reverted.
- platform/mac-wk2/http/tests/security/XFrameOptions: Removed.
- platform/mac-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
- platform/mac/http/tests/security/XFrameOptions: Removed.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
- 2:18 PM Changeset in webkit [147495] by
-
- 5 edits in trunk/Source/WebCore
[CSS Exclusions] refactor shape-outside code to use isFloatingWithShapeOutside() helper method
https://bugs.webkit.org/show_bug.cgi?id=113799
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-04-02
Reviewed by Dirk Schulze.
When reviewing my patch for bug 110349, Julien mentioned that the
common test for floating with shape outside should be factored out.
This patch does that.
No new functionality, so no new tests.
- rendering/ExclusionShapeOutsideInfo.cpp:
(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Use helper method.
- rendering/RenderBox.h:
(WebCore::RenderBox::exclusionShapeOutsideInfo): Ditto.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly): Ditto.
- rendering/RenderObject.h:
(WebCore::RenderObject::hasPaintOffset): Ditto.
(WebCore::RenderObject::isFloatingWithShapeOutside): Add method to
encapsulate the common test.
- 1:49 PM Changeset in webkit [147494] by
-
- 3 edits4 adds in trunk/Source/WebCore
Add platform AudioSession and iOS platform-specific code.
https://bugs.webkit.org/show_bug.cgi?id=113813
<rdar://problem/11701792>
Reviewed by Eric Carlson.
Replace the deprecated AudioToolbox AudioSession APIs with the new AVAudioSession API.
To protect against exposing platform specific intrinsics to cross-platform code, add a
platform generic class AudioSession, with port-specific implementations. A default
implementation is provided.
Add a new listener interface to receive interruption notifications:
- platform/audio/AudioSessionListener.h: Added.
(WebCore::AudioSessionListener::AudioSessionListener):
(WebCore::AudioSessionListener::~AudioSessionListener):
Add a platform generic AudioSession class:
- platform/audio/AudioSession.cpp: Added.
(AudioSession::sharedSession): AudioSession is a singleton object, and this is its accessor.
(AudioSession::addListener): Add the parameter to the listeners set.
(AudioSession::removeListener): Remove the parameter from the listers set.
(AudioSession::beganAudioInterruption): Iterate over the parameters.
(AudioSession::endedAudioInterruption): Ditto.
(AudioSession::AudioSession): Empty stub.
(AudioSession::~AudioSession): Ditto.
(AudioSession::setCategory): Ditto.
(AudioSession::category): Ditto.
(AudioSession::sampleRate): Ditto.
(AudioSession::numberOfOutputChannels): Ditto.
(AudioSession::setActive): Ditto.
(AudioSession::preferredBufferDuration): Ditto.
(AudioSession::setPreferredBufferDuration): Ditto.
- platform/audio/AudioSession.h: Added.
Add IOS-specific AudioSession implementation:
- platform/audio/ios/AudioSessionIOS.mm: Added.
(-[WebAudioSessionHelper initWithCallback:WebCore::]): Register for interruption notifications.
(-[WebAudioSessionHelper dealloc]): Unregister for interruption notifications.
(-[WebAudioSessionHelper interruption:]): Pass to AudioSession.
(WebCore::AudioSessionPrivate::AudioSessionPrivate): Private storage for AudioSessionIOS.
(WebCore::AudioSession::AudioSession): Create AudioSessionPrivate and WebAudioSessionHelper.
(WebCore::AudioSession::~AudioSession): Simple destructor.
(WebCore::AudioSession::setCategory): Check the current categoryOverride, and refuse to overwrite
"MediaPlayback" with "AmbientSound".
(WebCore::AudioSession::setCategoryOverride): Simple setter.
(WebCore::AudioSession::categoryOverride): Simple getter.
(WebCore::AudioSession::category): Pass to AVAudioSession.
(WebCore::AudioSession::sampleRate): Ditto.
(WebCore::AudioSession::numberOfOutputChannels): Ditto.
(WebCore::AudioSession::setActive): Ditto.
(WebCore::AudioSession::preferredBufferDuration): Ditto.
(WebCore::AudioSession::setPreferredBufferDuration): Ditto.
Use the new AudioSession class in place of explicit AudioToolbox or AVAudioSession calls:
- platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestination::hardwareSampleRate): Pass to AudioSession.
(WebCore::AudioDestination::maxChannelCount): Ditto.
(WebCore::AudioDestinationIOS::AudioDestinationIOS): Register for listeners and activate.
(WebCore::AudioDestinationIOS::~AudioDestinationIOS): Unregister and deactivate.
(WebCore::AudioDestinationIOS::configure): Use AudioSession to set the buffer length.
- platform/audio/ios/AudioDestinationIOS.h:
Add the new files to the project:
- WebCore.xcodeproj/project.pbxproj:
- 1:47 PM Changeset in webkit [147493] by
-
- 2 edits3 adds in trunk/Source/WebCore
Upstream AudioDestinationIOS.
https://bugs.webkit.org/show_bug.cgi?id=113806
Reviewed by Eric Carlson.
Upstream AudioDestinationIOS from the iOS repository.
- WebCore.xcodeproj/project.pbxproj:
- platform/audio/ios/AudioDestinationIOS.cpp: Added.
(WebCore::audioDestinations):
(WebCore::AudioDestination::create):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestination::maxChannelCount):
(WebCore::AudioDestinationIOS::AudioDestinationIOS):
(WebCore::AudioDestinationIOS::~AudioDestinationIOS):
(WebCore::AudioDestinationIOS::configure):
(WebCore::AudioDestinationIOS::audioDestinationInterruptionListener):
(WebCore::AudioDestinationIOS::initializeAudioSession):
(WebCore::AudioDestinationIOS::start):
(WebCore::AudioDestinationIOS::stop):
(WebCore::AudioDestinationIOS::beganAudioInterruption):
(WebCore::AudioDestinationIOS::endedAudioInterruption):
(WebCore::AudioDestinationIOS::render):
(WebCore::AudioDestinationIOS::inputProc):
(WebCore::AudioDestinationIOS::frameSizeChangedProc):
- platform/audio/ios/AudioDestinationIOS.h: Added.
(AudioDestinationIOS):
(WebCore::AudioDestinationIOS::isPlaying):
(WebCore::AudioDestinationIOS::sampleRate):
- 1:35 PM Changeset in webkit [147492] by
-
- 30 edits in trunk
fast/dom/HTMLImageElement/image-alt-text.html and fast/dom/HTMLInputElement/input-image-alt-text.html are failing
https://bugs.webkit.org/show_bug.cgi?id=94198
Reviewed by Darin Adler.
Source/WebCore:
Fix alt text not being displayed for img elements or input of type
"image" due to insufficient size. imageSizeForError() was adding
padding for the alt text but setImageSizeForAltText() was not. The
issue was occurring in paintReplaced() because the contentWidth() /
contentHeight() would be exactly the same size as the alt text.
However, paintReplaced() first draws an outline rect where the
image should be and then reduces the usable width / height for the
alt text by 2 so that the text does not get printed over the rect
borders. However, after decreasing the usable width / height, there
is no longer enough space to draw the text.
No new tests, already covered by existing tests.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::setImageSizeForAltText): Add padding to the text size
so that the alt text can still be drawn, despite the outline rect
borders. Such padding was already used in imageSizeForError(). Also use
ceilf() for the value returned by Font::width() instead of truncating it.
This is needed because we need to fit the whole text in the image and this
may not be the case if we truncate.
(WebCore::RenderImage::paintReplaced):
LayoutTests:
Rebaseline several test cases that have better result now and add those
tests to TestExpectations for other ports since they will need a
rebaseline.
- platform/chromium/TestExpectations:
- platform/efl/fast/block/float/002-expected.png:
- platform/efl/fast/block/float/017-expected.png:
- platform/efl/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/efl/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
- platform/efl/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/efl/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
- platform/efl/fast/encoding/utf-16-big-endian-expected.png:
- platform/efl/fast/encoding/utf-16-big-endian-expected.txt:
- platform/efl/fast/encoding/utf-16-little-endian-expected.png:
- platform/efl/fast/encoding/utf-16-little-endian-expected.txt:
- platform/efl/fast/flexbox/023-expected.png:
- platform/efl/fast/flexbox/024-expected.png:
- platform/efl/fast/forms/input-value-expected.png:
- platform/efl/fast/forms/input-value-expected.txt:
- platform/efl/fast/invalid/012-expected.png:
- platform/efl/fast/lists/inlineBoxWrapperNullCheck-expected.png:
- platform/efl/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
- platform/efl/fast/parser/comment-in-script-expected.png:
- platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
- platform/efl/tables/mozilla/bugs/bug2997-expected.png:
- platform/efl/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/efl/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 1:24 PM Changeset in webkit [147491] by
-
- 8 edits1 add in trunk/Source
Add support for using ARM FFT in WebAudio
https://bugs.webkit.org/show_bug.cgi?id=109755
Reviewed by Chris Rogers.
Source/WebCore:
No new tests.
- WebCore.gyp/WebCore.gyp: Add dependency on openmax_dl when use_openmax_dl_fft is enabled.
- WebCore.gypi: Add source FFTFrameOpenMAXDLAndroid.cpp
- platform/audio/AudioArray.h:
(WebCore::AudioArray::allocate): Need 32-byte aligntment with the
OpenMAX DL FFT.
- platform/audio/FFTFrame.h:
(FFTFrame): Support OpenMAX DL FFT
- platform/audio/FFTFrameStub.cpp: Support OpenMAX DL FFT
- platform/audio/chromium/FFTFrameOpenMAXDLAndroid.cpp: Added. Implements the
necessary interface using the OpenMAX DL FFT routines.
(WebCore):
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
(WebCore::FFTFrame::contextForSize):
Source/WebKit/chromium:
- features.gypi: Support building with the OpenMAX DL FFT.
- 1:04 PM Changeset in webkit [147490] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Memory leaks in MediaPlayerPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=113762
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-04-02
Reviewed by Philippe Normand.
Don't leak strings returned by gst_element_get_name() and
gst_missing_plugin_message_get_installer_detail().
No new tests. No change in behavior.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
- 1:00 PM Changeset in webkit [147489] by
-
- 6 edits in trunk/Source/WebKit2
Add WKContextSetInvalidMessageFunction
https://bugs.webkit.org/show_bug.cgi?id=113820
<rdar://problem/12679817>
Reviewed by Tim Horton.
- UIProcess/API/C/WKContext.cpp:
(WKContextSetInvalidMessageFunction):
Call WebContext::didReceiveInvalidMessage.
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::setInvalidMessageCallback):
Set the global variable.
(WebKit::WebContext::didReceiveInvalidMessage):
Construct a message name string and call the invalid message callback.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveInvalidMessage):
Call WebContext::didReceiveInvalidMessage.
- 12:57 PM Changeset in webkit [147488] by
-
- 1 edit3 deletes in trunk/LayoutTests
Rebaseline overflowHidden.html's test results after r147245.
Unreviewed.
The patch r147245 (https://bugs.webkit.org/show_bug.cgi?id=106143) updated results for
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-02
Reviewed by Tony Chang.
Chromium, but not for the other platforms.
The new results on Mac, EFL and Win match the common reference.
- platform/efl/fast/table/overflowHidden-expected.txt: Removed.
- platform/mac/fast/table/overflowHidden-expected.txt: Removed.
- platform/win-7sp0/fast/table: Removed.
- platform/win-7sp0/fast/table/overflowHidden-expected.txt: Removed.
- 12:54 PM Changeset in webkit [147487] by
-
- 3 edits1 add in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should have the equivalent of a ValueRecovery
https://bugs.webkit.org/show_bug.cgi?id=113819
Reviewed by Mark Hahnenberg.
This adds a way of saying that we have a value, we don't want to say what
node the value came from, but we know specifics of how the value is
formatted. This is the LLVM equivalent of DFG's ValueRecovery.
- JavaScriptCore.xcodeproj/project.pbxproj:
- ftl/FTLFormattedValue.h: Added.
(FTL):
(FormattedValue):
(JSC::FTL::FormattedValue::FormattedValue):
(JSC::FTL::FormattedValue::operator!):
(JSC::FTL::FormattedValue::format):
(JSC::FTL::FormattedValue::value):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):
(JSC::FTL::LowerDFGToLLVM::speculateForward):
(JSC::FTL::LowerDFGToLLVM::weakPointer):
- 12:53 PM Changeset in webkit [147486] by
-
- 2 edits in trunk/Source/WebCore
Fix css style for CC button on android
https://bugs.webkit.org/show_bug.cgi?id=113815
Patch by Min Qin <qinmin@chromium.org> on 2013-04-02
Reviewed by Adam Barth.
The default CC button size is 16px as defined in mediaControls.css. Android should use 35px.
This change fixed that problem.
Also fixed a problem that r142947 does not change the display of fullscreen button to -webkit-flex
Android does not run media layout tests currently. Will fix the test expectations when layout tests are run in content shell.
- css/mediaControlsChromiumAndroid.css:
(video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
- 12:52 PM Changeset in webkit [147485] by
-
- 8 edits in trunk/Source
[Mac] Remove WKCreateNSURLConnectionDelegateProxy
https://bugs.webkit.org/show_bug.cgi?id=113810
Reviewed by Anders Carlsson.
This WKSI function is not used any more.
- WebCore.exp.in:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- 12:50 PM Changeset in webkit [147484] by
-
- 3 edits in trunk/LayoutTests
[CSS Regions] Remove font-smoothing from fast/regions/region-style-inline-background-color.html
https://bugs.webkit.org/show_bug.cgi?id=113814
Reviewed by James Robinson.
The test uses font smoothing and makes the test fail on Chromium Mountain Lion. This happens
because of how regions handle overflow and clipping. For now, disable the font smoothing in
the test.
- fast/regions/region-style-inline-background-color-expected.html:
- fast/regions/region-style-inline-background-color.html:
- 12:13 PM Changeset in webkit [147483] by
-
- 2 edits in trunk/Tools
Disable running tests on the MAC WK2 EWS queue.
Unreviewed.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacWK2EWS):
- 12:06 PM Changeset in webkit [147482] by
-
- 7 edits in trunk/Source/WebKit
Provide a user default that can be used to disable docking of the Web Inspector.
The user default is "WebKit Web Inspector Setting - inspectorAttachDisabled".
https://webkit.org/b/113779
rdar://problem/13446021
Reviewed by Joseph Pecoraro.
Source/WebKit/cf:
- WebCoreSupport/WebInspectorClientCF.cpp:
(WebInspectorClient::inspectorAttachDisabled): Added.
(WebInspectorClient::setInspectorAttachDisabled): Added.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient::inspectorAttachDisabled): Added.
(WebInspectorClient::setInspectorAttachDisabled): Added.
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::didResizeMainFrame):
(-[WebInspectorWindowController window]):
(-[WebInspectorWindowController showWindow:]):
Check inspectorAttachDisabled() in places where we attach or update the dock button.
Source/WebKit/win:
- WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient::inspectorAttachDisabled): Added.
(WebInspectorClient::setInspectorAttachDisabled): Added.
- 11:56 AM Changeset in webkit [147481] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should use the right abstract heap for Int32 array accesses
https://bugs.webkit.org/show_bug.cgi?id=113759
Reviewed by Mark Hahnenberg.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
- 11:54 AM Changeset in webkit [147480] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r147464.
http://trac.webkit.org/changeset/147464
https://bugs.webkit.org/show_bug.cgi?id=113812
JSSQLResultSet.cpp:131:24: error: implicit conversion loses
integer precision: 'int64_t' (aka 'long long') to 'int'
[-Werror,-Wshorten-64-to-32] (Requested by xenon on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-02
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringValue):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsAttrWithGetterException):
(WebCore::jsTestTypedefsStringAttrWithGetterException):
- 11:42 AM Changeset in webkit [147479] by
-
- 7 edits in trunk/LayoutTests
Rebaseline svg/as-image/image-respects-pageScaleFactor expectations
Unreviewed rebaseline of test expectations.
- platform/chromium-linux/svg/as-image/image-respects-pageScaleFactor-expected.png:
- platform/chromium-mac-lion/svg/as-image/image-respects-pageScaleFactor-expected.png:
- platform/chromium-mac-snowleopard/svg/as-image/image-respects-pageScaleFactor-expected.png:
- platform/chromium-mac/svg/as-image/image-respects-pageScaleFactor-expected.png:
- platform/chromium-win/svg/as-image/image-respects-pageScaleFactor-expected.png:
- platform/chromium-win/svg/as-image/image-respects-pageScaleFactor-expected.txt:
- 11:37 AM Changeset in webkit [147478] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Make Source Frame & status bar a layout boundary
https://bugs.webkit.org/show_bug.cgi?id=112353
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
No new tests: no change in behaviour.
- Add View.markAsLayoutBoundary method to mark a view as a layout
boundary. This will force this view to autoupdate its height to actual
pixel value.
- Mark both CodeMirrorTextEditor and DefaultTextEditor as a layout
boundary.
- Mark main-status-bar element with a layout-boundary class.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
- inspector/front-end/DefaultTextEditor.js:
- inspector/front-end/View.js:
(WebInspector.View.prototype.markAsLayoutBoundary):
(WebInspector.View.prototype._processWillShow):
(WebInspector.View.prototype._processWasShown):
(WebInspector.View.prototype._processOnResize):
- inspector/front-end/inspector.css:
(.layout-boundary):
- inspector/front-end/inspector.html:
- 11:36 AM Changeset in webkit [147477] by
-
- 3 edits in trunk/Source/Platform
[chromium] Initialize all fields in WebFilterOperation
https://bugs.webkit.org/show_bug.cgi?id=113807
Reviewed by James Robinson.
- chromium/public/WebFilterOperation.h:
(WebKit::WebFilterOperation::WebFilterOperation):
- chromium/src/WebFilterOperation.cpp:
(WebKit::WebFilterOperation::WebFilterOperation):
- 11:36 AM Changeset in webkit [147476] by
-
- 9 edits in trunk/Source
<rdar://problem/13551119> [WK2] Crashes in NetworkProcess when canceling loads
https://bugs.webkit.org/show_bug.cgi?id=113803
Reviewed by Darin Adler.
Stop using a delegate proxy. It hasn't been needed in years, and the extra layer
just adds bugs.
This specific issue gets fixed because connection retains its delegate is retained,
but a proxy does not.
- WebCore.exp.in:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::releaseDelegate): (WebCore::ResourceHandle::platformLoadResourceSynchronously): Removed code that was dealing with delegate proxy.
- 11:35 AM Changeset in webkit [147475] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Encapsulate SetEmbedderData/GetEmbedderData
https://bugs.webkit.org/show_bug.cgi?id=113331
Patch by John J. Barton <johnjbarton@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
Refactor to encapsulate uses of V8 Set/GetEmbedderData together
with uses of V8 Set/GetAlignedPointerInEmbedderData since these
functions operate on the same underyling array in V8.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::setContextDebugId):
(WebCore::ScriptController::contextDebugId):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::setInjectedScriptContextDebugId):
- bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextDebugData::setContextDebugData):
(WebCore):
(WebCore::V8PerContextDebugData::contextDebugId):
(WebCore::V8PerContextDebugData::createDebugData):
(WebCore::V8PerContextDebugData::getDebugData):
(WebCore::V8PerContextDebugData::setDebugData):
- bindings/v8/V8PerContextData.h:
(V8PerContextDebugData):
(WebCore):
- 11:32 AM Changeset in webkit [147474] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Adjust toolbar labels position
https://bugs.webkit.org/show_bug.cgi?id=113805
Patch by Alexei Filippov <alph@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
Move the labels 1px up to make them centered.
Also fix font centering in native memory distribution snapshot.
- inspector/front-end/inspector.css:
(.toolbar-label):
- inspector/front-end/nativeMemoryProfiler.css:
(.native-snapshot-view .data-grid td):
- 11:30 AM Changeset in webkit [147473] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, chromium expectations update.
- platform/chromium/TestExpectations:
- 11:27 AM Changeset in webkit [147472] by
-
- 1 edit in trunk/Source/WebCore/rendering/RenderLayer.cpp
Fix Windows build.
- 11:25 AM Changeset in webkit [147471] by
-
- 13 edits2 adds in trunk
Viewport constrained elements should work properly with headers and footers
https://bugs.webkit.org/show_bug.cgi?id=113743
Reviewed by Simon Fraser.
Source/WebCore:
ScrollableArea::constrainScrollPositionForOverhang() needs to take headerHeight
and footerHeight into account. It also needs to use totalContentsSize() instead of
contentsSize().
Send totalContentsSize() instead of contentsSize() and also send headerHeight()
and footerHeight().
- page/FrameView.cpp:
(WebCore::FrameView::scrollOffsetForFixedPosition):
- page/FrameView.h:
(FrameView):
The scrolling tree will also need to know about header and footer heights since it
will need these values to call
ScrollableArea::constrainScrollPositionForOverhang().
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setHeaderHeight):
(WebCore::ScrollingStateScrollingNode::setFooterHeight):
- page/scrolling/ScrollingStateScrollingNode.h:
(WebCore::ScrollingStateScrollingNode::headerHeight):
(ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::footerHeight):
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):
- page/scrolling/ScrollingTreeScrollingNode.h:
(WebCore::ScrollingTreeScrollingNode::headerHeight):
(WebCore::ScrollingTreeScrollingNode::footerHeight):
(ScrollingTreeScrollingNode):
- page/scrolling/mac/ScrollingCoordinatorMac.h:
(ScrollParameters):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinatorMac::setScrollParametersForNode):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
Use footerHeight when calculating the maxValue and use headerHeight in determining
what the minimum value is.
- platform/ScrollableArea.cpp:
(WebCore::constrainedScrollPosition):
(WebCore::ScrollableArea::constrainScrollPositionForOverhang):
- platform/ScrollableArea.h:
(ScrollableArea):
LayoutTests:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html: Added.
- 11:23 AM Changeset in webkit [147470] by
-
- 4 edits7 adds in trunk
[Skia] Enable GPU-accelerated Skia path for FEComposite filter.
https://bugs.webkit.org/show_bug.cgi?id=113797
Reviewed by Adrienne Walker.
Source/WebCore:
Tests: css3/filters/effect-reference-composite-hw.html
css3/filters/effect-reference-composite.html
- WebCore.gypi:
- platform/graphics/filters/FEComposite.h:
Enable Skia DAG hook for FEComposite.
- platform/graphics/filters/skia/FECompositeSkia.cpp: Added.
(WebCore::FEComposite::createImageFilter):
Implement skia DAG builder for FEComposite, and implement generic
skia version of composite filter.
LayoutTests:
- css3/filters/effect-reference-composite-hw.html: Added.
- css3/filters/effect-reference-composite.html: Added.
- platform/chromium-linux/css3/filters/effect-reference-composite-expected.png: Added.
- platform/chromium-linux/css3/filters/effect-reference-composite-expected.txt: Added.
- platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.png: Added.
- platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.txt: Added.
- 11:20 AM Changeset in webkit [147469] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Avoid using style.display="inline-block"
https://bugs.webkit.org/show_bug.cgi?id=113802
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
No new tests.
- Create class "inline-block" which will set "display: inline-block"
style.
- Use this class with DIV elements to get "inline-block" element.
- inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
- inspector/front-end/inspector.css:
(.inline-block):
- 11:18 AM Changeset in webkit [147468] by
-
- 3 edits2 adds in trunk
Web Inspector: [Timeline] warning markers are not propagated to coalesced records
https://bugs.webkit.org/show_bug.cgi?id=113789
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/timeline/timeline-coalescing.html
- inspector/front-end/TimelinePresentationModel.js: set childHasWarning on coalescing record if the record it replaces had warnings.
(WebInspector.TimelinePresentationModel.prototype._replaceWithCoalescedRecord):
LayoutTests:
- inspector/timeline/timeline-coalescing-expected.txt: Added.
- inspector/timeline/timeline-coalescing.html: Added.
- 11:17 AM Changeset in webkit [147467] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Create a selection from two points irregardless of the caret position.
https://bugs.webkit.org/show_bug.cgi?id=113795
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-04-02
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
PR276577
If we are to set both the base and extent of a selection, we should maintain the base upon setting the extent.
This prevents us from overwriting the previous calculation when setting extent.
Further, instead of setting and manipulating the selection, simply set up start and end VisiblePositions and
create a new directional selection so as to set the base and extent simultaneously.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setSelection):
- 11:16 AM Changeset in webkit [147466] by
-
- 8 edits2 adds in trunk
Web Inspector: memory instrumentation for external strings is broken
https://bugs.webkit.org/show_bug.cgi?id=113788
Source/WebCore:
Reviewed by Pavel Feldman.
Native memory snapshot now provides information about JS external strings.
Test: inspector/profiler/memory-instrumentation-external-string.html
- inspector/InspectorMemoryAgent.cpp:
LayoutTests:
Test that native memory snapshot contains information about extenral strings.
Reviewed by Pavel Feldman.
- inspector/profiler/memory-instrumentation-external-string-expected.txt: Added.
- inspector/profiler/memory-instrumentation-external-string.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 11:14 AM Changeset in webkit [147465] by
-
- 10 edits2 adds in trunk
Web Inspector: memory instrumentation for external arrays is broken
https://bugs.webkit.org/show_bug.cgi?id=113790
Source/WebCore:
Report pointers to external arrays as retaining ones to make sure their
size is counted correctly.
Reviewed by Pavel Feldman.
Test: inspector/profiler/memory-instrumentation-external-array.html
- inspector/InspectorMemoryAgent.cpp:
Source/WTF:
Reviewed by Pavel Feldman.
- wtf/MemoryInstrumentationArrayBufferView.h: report buffer pointer as retaining one as
we know that the pointer is not broken.
(WTF::reportMemoryUsage):
LayoutTests:
Test that JS external resources size includes size of JS external arrays
created in the inspected page.
Reviewed by Pavel Feldman.
- inspector/profiler/memory-instrumentation-external-array-expected.txt: Added.
- inspector/profiler/memory-instrumentation-external-array.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 11:12 AM Changeset in webkit [147464] by
-
- 4 edits in trunk/Source/WebCore
[JSC] Don't create a JSValue if it's not going to be used for nullable attributes
https://bugs.webkit.org/show_bug.cgi?id=112711
Reviewed by Sam Weinig.
When nullable attributes are used, it's possible that we disregard the JSValue
when null should be returned instead. This is a waste, and we should cast the
native type to a JSValue as late as possible.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(NativeValueToLocal):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringValue):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsAttrWithGetterException):
(WebCore::jsTestTypedefsStringAttrWithGetterException):
- 11:10 AM Changeset in webkit [147463] by
-
- 3 edits2 adds in trunk
[css exclusions] overflow:hidden undoes shape-outside offsets
https://bugs.webkit.org/show_bug.cgi?id=110349
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-04-02
Reviewed by Julien Chaffraix.
Source/WebCore:
When overflow: hidden was set on a float with shape-outside, the
offset from the shape-outside was being ignored. This was because the
float was being placed in the normal flow, causing the offsets to be
calculated differently. Since floats with shape outside behave like
positioned objects in many places, I have caused them to take the same
behavior as positioned objects in this case as well: the floats with
shape-outside do not get placed in the normal flow when overflow:
hidden is set.
Test: fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly): Floats that have
shape-outside should not be in the normal flow.
LayoutTests:
Add a test to make sure the float is properly positioned with
overflow: hidden.
- fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden.html: Added.
- 11:06 AM Changeset in webkit [147462] by
-
- 2 edits in tags/Safari-537.35.6/Source/WebCore
Merged r147373. <rdar://problem/13202277>
- 11:04 AM Changeset in webkit [147461] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: resource preview of html/js/css types should be on a grey background
https://bugs.webkit.org/show_bug.cgi?id=113791
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
No new tests.
- Add a css rule to set grey background for SourceFrame in resource view.
- Add "fill" style to SourceFrame element to setup its height.
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
- inspector/front-end/resourceView.css:
(.resource-view .script-view):
- 11:04 AM Changeset in webkit [147460] by
-
- 5 edits in tags/Safari-537.35.6/Source
Merged r147359. <rdar://problem/13549181>
- 11:02 AM Changeset in webkit [147459] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] Editor doesn't have yellow background in DivergedFromVM state
https://bugs.webkit.org/show_bug.cgi?id=113783
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
No new tests.
Force CodeMirrorTextEditor to have transparent background to inherit
background color from source frame.
- inspector/front-end/cm/cmdevtools.css:
(.CodeMirror):
- 11:01 AM Changeset in webkit [147458] by
-
- 4 edits in tags/Safari-537.35.6/Source
Versioning.
- 10:59 AM Changeset in webkit [147457] by
-
- 10 edits in trunk/Tools
Dashboard refactor: Move dashboard specific history related features to History.
https://bugs.webkit.org/show_bug.cgi?id=113717
Reviewed by Ojan Vafai.
Each dashboard now creates its own History object, with a custom
configuration. This changes from just overriding global functions
to passing in callbacks for generatePage, handleValidHashParameter,
and handleQueryParameterChange. Same with passing in defaultStateValues
and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
variables.
All functions related to these features are now (mostly) private
function on History.
Loader no longer needs a loadingComplete callback, since it can just
initialize the history object itself.
- TestResultServer/static-dashboards/aggregate_results.js:
(handleValidHashParameter):
- TestResultServer/static-dashboards/dashboard_base.js:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(generatePage):
(.switch.return):
(handleQueryParameterChange):
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(resetGlobals):
- TestResultServer/static-dashboards/history.js:
(.):
- TestResultServer/static-dashboards/loader.js:
(.):
- TestResultServer/static-dashboards/loader_unittests.js:
- TestResultServer/static-dashboards/timeline_explorer.js:
(generatePage):
(initCurrentBuilderTestResults):
- TestResultServer/static-dashboards/treemap.js:
(generatePage):
(.switch.return):
(handleQueryParameterChange):
- 10:58 AM Changeset in webkit [147456] by
-
- 15 edits in tags/Safari-537.35.6
Merged r147260. <rdar://problem/13536343>
- 10:53 AM Changeset in webkit [147455] by
-
- 3 edits in branches/chromium/1410/Source/WebCore
Merge 147389 "Hide non-coordinated scrollbars for Android M26"
Hide non-coordinated scrollbars for Android M26
https://bugs.webkit.org/show_bug.cgi?id=113738
Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-04-01
Reviewed by Simon Fraser.
This patch will hide any non-coordinated scrollbars on Android.
Coordinated scrollbars won't be affected.
Currently all scrollbars are coordinated on Android. The sole purpose
of this patch is to be cherry-picked to the M26 branch.
No new tests. Please revert immediately after landed.
- platform/ScrollView.cpp:
(WebCore::positionScrollbarLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::positionOverflowControlsLayers):
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/13470017
- 10:53 AM Changeset in webkit [147454] by
-
- 3 edits2 adds in trunk
Check whether popups are allowed before creating a new window
https://bugs.webkit.org/show_bug.cgi?id=113782
Reviewed by Adam Barth.
Source/WebCore:
Otherwise, firing a generated mouse event at an anchor is enough to
work around the popup blocker.
Test: fast/loader/url-selected-user-gesture.html
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNewWindowPolicy):
LayoutTests:
- fast/loader/url-selected-user-gesture-expected.txt: Added.
- fast/loader/url-selected-user-gesture.html: Added.
- 10:50 AM Changeset in webkit [147453] by
-
- 5 edits in trunk
When computing the percentage of the logical height, use the logical top and bottom
https://bugs.webkit.org/show_bug.cgi?id=113761
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/writing-mode/percentage-height-orthogonal-writing-modes.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):
LayoutTests:
- fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt:
- fast/writing-mode/percentage-height-orthogonal-writing-modes.html:
- 10:50 AM Changeset in webkit [147452] by
-
- 3 edits in tags/Safari-537.35.6/Source/WebCore
Merged r147240. <rdar://problem/13256956>
- 10:49 AM Changeset in webkit [147451] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] do not show cursor in read-only mode
https://bugs.webkit.org/show_bug.cgi?id=113793
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Alexander Pavlov.
No new tests.
Pass "nocursor" option to CodeMirror's "readonly" setting.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.setReadOnly):
- 10:47 AM Changeset in webkit [147450] by
-
- 22 edits in trunk
Unreviewed, rolling out r147402.
http://trac.webkit.org/changeset/147402
https://bugs.webkit.org/show_bug.cgi?id=112903
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
LayoutTests:
- http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html:
- http/tests/security/XFrameOptions/x-frame-options-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- 10:45 AM Changeset in webkit [147449] by
-
- 4 edits in tags/Safari-537.35.6/Source/WebCore
Merged r146995. <rdar://problem/13474743>
- 10:41 AM Changeset in webkit [147448] by
-
- 1 edit3 copies in branches/chromium/1453
Merge 147127 "RenderBox::backgroundIsKnownToBeOpaqueInRect may b..."
RenderBox::backgroundIsKnownToBeOpaqueInRect may be wrong for theme-painted elements
https://bugs.webkit.org/show_bug.cgi?id=113419
Reviewed by Simon Fraser.
Source/WebCore:
Do not consider control elements as opaque. They are typically theme painted, and we cannot assume opaqueness on the behalf of theme. It can be improved by asking the theme if it paints opaque.
Test: compositing/contents-opaque/control-layer.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):
LayoutTests:
- compositing/contents-opaque/control-layer-expected.txt: Added.
- compositing/contents-opaque/control-layer.html: Added.
- platform/chromium/compositing/contents-opaque/control-layer-expected.txt: Added.
TBR=alokp@chromium.org
BUG=223490
Review URL: https://codereview.chromium.org/13465009
- 10:35 AM Changeset in webkit [147447] by
-
- 16 edits in trunk/Source/WebKit/mac
WebKit/mac shouldn't have code for Mac 10.5 and earlier
https://bugs.webkit.org/show_bug.cgi?id=113746
Reviewed by Darin Adler.
Deleted the code for 10.5 and removed if-defs for 10.6.
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPlugin]):
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView createPlugin]):
(-[WebNetscapePluginView getVariable:forURL:value:length:]):
(-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]):
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::selectItemWritingDirectionIsNatural):
(WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection):
- WebCoreSupport/WebEditorClient.mm:
(core):
(WebEditorClient::checkTextOfParagraph):
(WebEditorClient::requestCheckingOfString):
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController _updateMenuAndDockForFullScreen]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
(-[WebHTMLView _frameOrBoundsChanged]):
(+[WebHTMLView _insertablePasteboardTypes]):
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
(writingDirectionKeyBindingsEnabled):
(-[WebHTMLView _lookUpInDictionaryFromMenu:]):
(-[WebHTMLView attachRootLayer:]):
- WebView/WebHTMLViewInternal.h:
- WebView/WebPDFDocumentExtras.mm:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
- WebView/WebResourceInternal.h:
- WebView/WebScriptDebugDelegate.h:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _preferencesChanged:]):
(+[WebView initialize]):
(clientNeedsWebViewInitThreadWorkaround):
(-[WebView validateUserInterfaceItemWithoutDelegate:]):
(-[WebView setGrammarCheckingEnabled:]):
(-[WebView isAutomaticQuoteSubstitutionEnabled]):
(-[WebView isAutomaticLinkDetectionEnabled]):
(-[WebView isAutomaticDashSubstitutionEnabled]):
(-[WebView isAutomaticTextReplacementEnabled]):
(-[WebView isAutomaticSpellingCorrectionEnabled]):
(-[WebView _searchWithSpotlightFromMenu:]):
(WebInstallMemoryPressureHandler):
- WebView/WebViewPrivate.h:
- 10:28 AM Changeset in webkit [147446] by
-
- 8 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support fast property stores
https://bugs.webkit.org/show_bug.cgi?id=113757
Reviewed by Oliver Hunt.
Simplified the task of handling property transitions and reduced amount of code
duplication between the JITs.
Added PutByOffset, PutStructure, PhantomPutStructure, WeakJSConstant, and a
stub form of StructureTransitionWatchpoint to the FTL.
Also simplified the creation of pointer constants, and fixed a bug in
speculateObject().
- dfg/DFGGraph.h:
(JSC::DFG::Graph::notifyCompilingStructureTransition):
(Graph):
- dfg/DFGJITCompiler.h:
(JITCompiler):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileWeakJSConstant):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileStructureTransitionWatchpoint):
(JSC::FTL::LowerDFGToLLVM::compilePutStructure):
(JSC::FTL::LowerDFGToLLVM::compilePhantomPutStructure):
(JSC::FTL::LowerDFGToLLVM::compilePutByOffset):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::weakPointer):
- ftl/FTLOutput.h:
(Output):
(JSC::FTL::Output::constIntPtr):
(JSC::FTL::Output::absolute):
- 10:24 AM Changeset in webkit [147445] by
-
- 2 edits in trunk/LayoutTests
webkit fails IETC grid-column-002
https://bugs.webkit.org/show_bug.cgi?id=83907
Unreviewed Mac test expectation fix.
- platform/mac/TestExpectations:
Removed grid-column-002.htm here too.
- 10:21 AM Changeset in webkit [147444] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, chromium expectations update.
- platform/chromium/TestExpectations: Mark svg/as-image/image-respects-pageScaleFactor.html as flaky.
- 10:16 AM Changeset in webkit [147443] by
-
- 5 edits in trunk/Source/WebCore
[GTK][AC] Support preserves3D css property for clutter ac backend.
https://bugs.webkit.org/show_bug.cgi?id=113318
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-02
Reviewed by Gustavo Noronha Silva.
This patch brings preserve-3D css property support to WebKitGtk+ with clutter ac backed.
Most of the code is based on Mac port's implementation. The core concept is that
if a layer has preserve-3d property false, we mark itself and its immediate children
to make them flatten. And then we remove 3D factor in a modelView matrix
when applying it to each actor.
No new tests as this is covered with existing AC tests.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(_GraphicsLayerActorPrivate):
(graphics_layer_actor_init):
(graphicsLayerActorApplyTransform):
(graphicsLayerActorNew):
(graphicsLayerActorRemoveFromSuperLayer):
(graphicsLayerActorSetDrawsContent):
(graphicsLayerActorSetFlatten):
- platform/graphics/clutter/GraphicsLayerActor.h:
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::platformLayer):
(WebCore::GraphicsLayerClutter::moveOrCopyAnimations):
(WebCore):
(WebCore::GraphicsLayerClutter::setPreserves3D):
(WebCore::GraphicsLayerClutter::flushCompositingState):
(WebCore::GraphicsLayerClutter::recursiveCommitChanges):
(WebCore::GraphicsLayerClutter::commitLayerChangesAfterSublayers):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerClutter::updateGeometry):
(WebCore::GraphicsLayerClutter::updateSublayerList):
(WebCore::GraphicsLayerClutter::updateStructuralLayer):
(WebCore::GraphicsLayerClutter::ensureStructuralLayer):
(WebCore::GraphicsLayerClutter::structuralLayerPurpose):
(WebCore::GraphicsLayerClutter::layerForSuperlayer):
- platform/graphics/clutter/GraphicsLayerClutter.h:
(CommitState):
(WebCore::GraphicsLayerClutter::CommitState::CommitState):
(GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::primaryLayer):
- 10:10 AM Changeset in webkit [147442] by
-
- 1 copy in tags/Safari-537.35.6
New Tag.
- 9:14 AM Changeset in webkit [147441] by
-
- 8 edits5 adds in trunk
HTML parser should consistently inspect the namespace of elements on the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=113723
Reviewed by Adam Barth.
Source/WebCore:
Added HTMLStackItem::matchesHTMLTag method and use that nearly
everywhere instead of HTMLStackItem::hasLocalName. The most important
of these changes is in HTMLElementStack's inScopeCommon() function,
where the use of matchesHTMLTag means that any of the inXXXScope()
calls now only match HTML tags.
Tests: html5lib/generated/run-namespace-sensitivity-data.html
html5lib/generated/run-namespace-sensitivity-write.html
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::popUntil):
(WebCore::HTMLElementStack::topmost):
(WebCore::inScopeCommon):
(WebCore::HTMLElementStack::inScope):
(WebCore::HTMLElementStack::inListItemScope):
(WebCore::HTMLElementStack::inTableScope):
(WebCore::HTMLElementStack::inButtonScope):
(WebCore::HTMLElementStack::inSelectScope):
- html/parser/HTMLElementStack.h:
(WebCore::HTMLElementStack::popUntilPopped):
- html/parser/HTMLFormattingElementList.cpp:
(WebCore::HTMLFormattingElementList::closestElementInScopeWithName):
- html/parser/HTMLStackItem.h:
(WebCore::HTMLStackItem::matchesHTMLTag):
(HTMLStackItem):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
LayoutTests:
- html5lib/generated/run-namespace-sensitivity-data-expected.txt: Added.
- html5lib/generated/run-namespace-sensitivity-data.html: Added.
- html5lib/generated/run-namespace-sensitivity-write-expected.txt: Added.
- html5lib/generated/run-namespace-sensitivity-write.html: Added.
- html5lib/resources/namespace-sensitivity.dat: Added.
- 9:00 AM Changeset in webkit [147440] by
-
- 3 edits in trunk/Source/WebCore
Report memory usage for ShadowDistributedRules.
https://bugs.webkit.org/show_bug.cgi?id=109882
Reviewed by Dimitri Glazkov.
This is a follow-up patch for r142855.
No new tests, no behavior change for layout tests.
- css/DocumentRuleSets.cpp:
(WebCore):
(WebCore::ShadowDistributedRules::reportMemoryUsage):
(WebCore::DocumentRuleSets::reportMemoryUsage):
- css/DocumentRuleSets.h:
(ShadowDistributedRules):
- 8:58 AM Changeset in webkit [147439] by
-
- 6 edits2 adds in trunk
AX: Need to get line thickness from fraction on web
https://bugs.webkit.org/show_bug.cgi?id=113720
Reviewed by David Kilzer.
Expose the line thickness property for fractions, which is needed to
help determine the type of equation.
Test: platform/mac/accessibility/mathml-line-fraction.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::mathLineThickness):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::mathLineThickness):
(WebCore):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityMathLineThickness]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- 8:48 AM Changeset in webkit [147438] by
-
- 2 edits in branches/chromium/1453/Source
Merge 147178 "[Chromium] Don't create SolidColorLayer for full t..."
[Chromium] Don't create SolidColorLayer for full transparent background
https://bugs.webkit.org/show_bug.cgi?id=113524
Reviewed by James Robinson.
Source/WebCore:
Test: GraphicsLayerChromiumTest.setContentsToSolidColor
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToSolidColor):
Source/WebKit/chromium:
- tests/GraphicsLayerChromiumTest.cpp:
(GraphicsLayerChromiumTest::setContentsToSolidColor):
TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/13430007
- 8:43 AM Changeset in webkit [147437] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed.
Enable fast/regions/region-style-inline-background-color.html on Mountain Lion as it started to pass.
- platform/chromium/TestExpectations:
- 8:24 AM Changeset in webkit [147436] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r147389.
http://trac.webkit.org/changeset/147389
https://bugs.webkit.org/show_bug.cgi?id=113738
r147389 was temporary patch for Chromium branch management, needs
revert.
- platform/ScrollView.cpp:
(WebCore::positionScrollbarLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::positionOverflowControlsLayers):
- 8:21 AM Changeset in webkit [147435] by
-
- 4 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
New results for effect-reference-hw, due to slight pixel differences from http://src.chromium.org/viewvc/chrome?view=rev&revision=191067
- platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
- platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
- platform/chromium/TestExpectations:
- 8:18 AM Changeset in webkit [147434] by
-
- 3 edits2 adds in trunk
Hang when calling setCurrentTime on SVG with cyclic animation dependency chain
https://bugs.webkit.org/show_bug.cgi?id=113485
Patch by David Vest <davve@opera.com> on 2013-04-02
Reviewed by Stephen Chenney.
Source/WebCore:
If no exact match can be found, approximateBinarySearch may return
either adjacent value to the key. Selecting the lesser value when
there is a greater one may cause interval creation to fail in a
way that causes infinite loops during seeking. Detect and amend
this condition by selecting the greater value when possible.
Test: svg/animations/animation-dependency-hang.html
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::findInstanceTime):
LayoutTests:
- svg/animations/animation-dependency-hang-expected.txt: Added.
- svg/animations/animation-dependency-hang.html: Added.
- 7:58 AM Changeset in webkit [147433] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: source location gets frozen after inspector reload
https://bugs.webkit.org/show_bug.cgi?id=113776
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
Put statusBarText item in its own container and update its contents in
ScriptsPanel._updateScriptViewStatusBarItems in similar way it's done
for statusBarItems.
No new tests.
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.statusBarText):
(WebInspector.ScriptsPanel.prototype._updateScriptViewStatusBarItems):
- 7:47 AM Changeset in webkit [147432] by
-
- 2 edits in trunk/Source/WebCore
Remove unneeded cpp file from CMake build. Rubber-stamp by Alexis Menard.
- CMakeLists.txt: Remove FFTFrameStub.cpp, since adding this file or not
to your build is a platform decision.
- 7:44 AM Changeset in webkit [147431] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [Timeline] unify logic for 3 overview modes in Timeline
https://bugs.webkit.org/show_bug.cgi?id=113708
Reviewed by Yury Semikhatsky.
- make TimelineOverviewPane logic independent on overview mode;
- show only one of 3 controls at one time;
- attach overview controls to the same parent.
- inspector/front-end/OverviewGrid.js: remove gridElement() and itemsGraphsElement(), no longer needed.
(WebInspector.OverviewGrid):
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._innerSetMode):
(WebInspector.TimelineOverviewPane.prototype._createOverviewControl):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.addFrame):
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineOverviewBase.prototype.update):
(WebInspector.TimelineOverviewBase.prototype.reset):
(WebInspector.TimelineOverviewBase.prototype.categoryVisibilityChanged):
(WebInspector.TimelineOverviewBase.prototype.addFrame):
(WebInspector.TimelineOverviewBase.prototype.getWindowTimes):
(WebInspector.TimelineEventOverview):
(WebInspector.TimelineEventOverview.prototype.categoryVisibilityChanged):
- inspector/front-end/timelinePanel.css:
- 7:41 AM Changeset in webkit [147430] by
-
- 11 edits1 add in trunk
webkit fails IETC grid-column-002
https://bugs.webkit.org/show_bug.cgi?id=83907
Reviewed by Ojan Vafai.
Source/WebCore:
Tests: fast/css-grid-layout/grid-item-column-row-get-set.html
ietestcenter/css3/grid/grid-column-002.htm
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
Don't accept 0 as a valid <integer> position.
LayoutTests:
- fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
- fast/css-grid-layout/grid-item-column-row-get-set.html:
Extended our testing to cover setting grid-{start|end|before|after} to 0.
- ietestcenter/css3/grid/grid-column-002.htm:
- ietestcenter/css3/grid/testRunnerEnableGrid.js: Added.
Needed to dynamically enable CSS Grid Layout for the test to pass. The file
hosts the boiler-plate code which will be common to all tests.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt-mac/TestExpectations:
- platform/qt/TestExpectations:
Removed grid-column-002.htm from the test expectations.
- 7:36 AM Changeset in webkit [147429] by
-
- 3 edits5 adds4 deletes in trunk/LayoutTests
[EFL] Unreviewed gardening.
- platform/efl-wk2/TestExpectations:
- platform/efl-wk2/fast/repaint/caret-with-transformation-expected.png: Added.
- platform/efl-wk2/fast/repaint/caret-with-transformation-expected.txt: Added.
- platform/efl-wk2/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
- platform/efl-wk2/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
- platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
- platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
- platform/efl-wk2/svg/css/composite-shadow-example-expected.txt: Removed.
- platform/efl-wk2/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
- platform/efl/TestExpectations:
- 7:28 AM Changeset in webkit [147428] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: allow referencing of nodes that have not been pushed to the front-end
https://bugs.webkit.org/show_bug.cgi?id=110921
Patch by Dmitry Gozman <dgozman@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
Nodes not yet pushed to front-end are referenced by BackendNodeId and retained.
One can group nodes when generating BackendNodeIds to release them all together later.
To resolve node references by BackendNodeId, frontend should use new pushNodeByBackendIdToFrontend method.
This will invalidate the generated BackendNodeId.
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::backendNodeIdForNode):
(WebCore::InspectorDOMAgent::releaseBackendNodeIds):
(WebCore::InspectorDOMAgent::pushNodeByBackendIdToFrontend):
- inspector/InspectorDOMAgent.h:
(WebCore):
(InspectorDOMAgent):
- 7:28 AM Changeset in webkit [147427] by
-
- 4 edits in trunk/LayoutTests
Web Inspector: Update test expectation for console-cross-origin-iframe-logging.html
https://bugs.webkit.org/show_bug.cgi?id=113756
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-02
Reviewed by Pavel Feldman.
Simplified errors by not including the whole URL after r145692.
- http/tests/inspector/console-cross-origin-iframe-logging-expected.txt:
- platform/efl/TestExpectations:
- platform/qt/TestExpectations:
- 6:48 AM Changeset in webkit [147426] by
-
- 10 edits8 adds in trunk
[CSS Regions] Nested auto-height regions don't layout correctly
https://bugs.webkit.org/show_bug.cgi?id=111969
Reviewed by David Hyatt.
Source/WebCore:
The patch fixes the auto-height regions processing model to work with nested named flows. Currently
this use case doesn't work correctly because the order in which the computed height value is propagated
to the regions is incorrect. For example, in the case of two flows (f1 and f2) and two auto-height
regions (r1 and r2) with r2 a member of f1:
- the normal layout phase starts
- r1 is laid out with height = 0
- f1 is laid out including r2 with height = 0; overrideLogicalHeight for r1 is computed
- f2 is laid out; overrideLogicalHeight for r2 is computed
- the constrained layout phase starts
- r1 is laid out using the overrideLogicalHeight computed in the normal phase
- f1 is laid out including r2 with its overrideLogicalHeight
- f2 is laid out
The problem appears at step 6 because the overrideLogicalheight computed during step 3 assumes r2
has a height of 0. The patch changes the algorithm to update the auto-height regions in the reverse
order of their flow threads dependecies. Here is a high level overview of the new algorithm,
considering the named flows are sorted in the order of their dependencies:
- The flows are laid out from the outer flow to the inner flow. This successfully computes the outer
non-auto-height regions size so the inner flows have the necessary information to correctly fragment
the content.
- The flows are laid out from the inner flow to the outer flow. After an inner flow is laid out it
goes into the constrained layout phase and marks the auto-height regions they need layout. This
means the outer flows will relayout if they depend on regions with auto-height regions belonging to
inner flows. This step will correctly compute the overrideLogicalHeights for the auto-height regions.
It's possible for non-auto-height regions to relayout if they depend on auto-height regions. This
will invalidate the inner flow threads and mark them as needing layout.
- The last step is to do one last layout if there are pahtological dependencies between non-auto-height
regions and auto-height regions as detected in the previous step.
The patch also removes the layout phase flag from RenderView and moves it to the flow threads. This
happens because a flow needs to update its auto-height regions overrideLogicalHeight while updating
the logical height of the regions belonging to the inner flows that are laid out by the flow (i.e. the
outer flow is in the normal phase while the inner flows are in the constrained layout phase).
There's also a new flag on the RenderFlowThread that is set when the flow needs the constrained layout
phase. This could have been placed on the flow thread controller but I think it will be useful when doing
content balancing for the new multi-column implementation.
Another change is the moment we clear the overrideLogicalHeight value on empty auto-height regions because
we don't have to relayout a flow thread once it's in the constrained phase. We need to have the correct
flow thread portions correctly computed after the artificial forced break is applied at the end of the content.
Tests: fast/regions/autoheight-mixed-nested-complex-regions.html
fast/regions/autoheight-mixed-nested-regions.html
fast/regions/autoheight-mixed-parallel-regions.html
fast/regions/autoheight-nested-regions.html
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::FlowThreadController):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads):
(WebCore):
(WebCore::FlowThreadController::registerNamedFlowContentNode):
(WebCore::FlowThreadController::unregisterNamedFlowContentNode):
(WebCore::FlowThreadController::updateFlowThreadsChainIfNecessary):
(WebCore::FlowThreadController::updateFlowThreadsNeedingLayout):
(WebCore::FlowThreadController::updateFlowThreadsNeedingTwoStepLayout):
(WebCore::FlowThreadController::resetFlowThreadsWithAutoHeightRegions):
(WebCore::FlowThreadController::updateFlowThreadsIntoConstrainedPhase):
- rendering/FlowThreadController.h:
(FlowThreadController):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::regionAtBlockOffset):
(WebCore::RenderFlowThread::applyBreakAfterContent): Apply an artificial break at the end of the content.
This way we can detect when the content ends and clear the overrideLogicalHeight on the empty auto-height regions.
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore):
(WebCore::RenderFlowThread::initializeRegionsOverrideLogicalContentHeight):
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::pageLogicalWidth):
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::maxPageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::updateLogicalHeight):
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore):
(WebCore::RenderView::layoutContentInAutoLogicalHeightRegions):
(WebCore::RenderView::layout):
- rendering/RenderView.h:
(WebCore):
(RenderView):
LayoutTests:
These tests cover various combinations of dependencies between flows and regions with
or without auto-height.
- fast/regions/autoheight-mixed-nested-complex-regions-expected.txt: Added.
- fast/regions/autoheight-mixed-nested-complex-regions.html: Added.
- fast/regions/autoheight-mixed-nested-regions-expected.txt: Added.
- fast/regions/autoheight-mixed-nested-regions.html: Added.
- fast/regions/autoheight-mixed-parallel-regions-expected.txt: Added.
- fast/regions/autoheight-mixed-parallel-regions.html: Added.
- fast/regions/autoheight-nested-regions-expected.txt: Added.
- fast/regions/autoheight-nested-regions.html: Added.
- 6:46 AM Changeset in webkit [147425] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: ignore minimum record duration filter in Timeline overview
https://bugs.webkit.org/show_bug.cgi?id=113705
Reviewed by Pavel Feldman.
- inspector/front-end/TimelineOverviewPane.js:
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._durationFilterChanged):
- 6:45 AM Changeset in webkit [147424] by
-
- 6 edits in trunk/LayoutTests
Web Inspector: add tests for grouped messages filtration in console.
https://bugs.webkit.org/show_bug.cgi?id=113766
Added console groups to console filter test. Fixed minor bugs in other tests.
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
- inspector/console/console-filter-test-expected.txt:
- inspector/console/console-filter-test.html:
- inspector/console/console-preserve-log.html:
- inspector/console/console-tests-expected.txt:
- inspector/console/console-tests.html:
- 6:44 AM Changeset in webkit [147423] by
-
- 1 edit6 adds in trunk/LayoutTests
[Mac] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=113775
Tests need platform-specific rebaselines after r147402. :(
- platform/mac-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
- 6:19 AM Changeset in webkit [147422] by
-
- 9 edits in trunk
Web Inspector: display the number of dirty render objects in Layout timeline event
https://bugs.webkit.org/show_bug.cgi?id=95331
Reviewed by Pavel Feldman.
Source/WebCore:
Count the render objects that need layout in InspectorTimelineAgent::willLayout()
and display the number in popover over Layout record in Timeline panel.
- English.lproj/localizedStrings.js:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willLayout):
(WebCore::InspectorTimelineAgent::didLayout):
- inspector/TimelineRecordFactory.cpp:
(WebCore):
(WebCore::TimelineRecordFactory::createLayoutData):
(WebCore::TimelineRecordFactory::appendLayoutRoot):
- inspector/TimelineRecordFactory.h:
(TimelineRecordFactory):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
LayoutTests:
- inspector/timeline/timeline-layout-expected.txt: rebaselined to include new properties;
- 6:15 AM Changeset in webkit [147421] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] Popover for codemirror
https://bugs.webkit.org/show_bug.cgi?id=113771
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
Implement methods TextEditor.cursorPositionToCoordinates, TextEditor.coordinatesToCursorPosition and
TextEditor.tokenAtTextPosition in CodeMirrorTextEditor to support popover
functionality. Add css classes to highlight popover anchoring text.
No new tests.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.cursorPositionToCoordinates):
(WebInspector.CodeMirrorTextEditor.prototype.coordinatesToCursorPosition):
(WebInspector.CodeMirrorTextEditor.prototype.tokenAtTextPosition):
- inspector/front-end/cm/cmdevtools.css:
(.CodeMirror .source-frame-eval-expression):
(.CodeMirror .source-frame-eval-expression-end):
(.CodeMirror .source-frame-eval-expression-start):
- 5:56 AM Changeset in webkit [147420] by
-
- 2 edits60 adds1 delete in trunk/LayoutTests
[EFL] Unreviewed gardening.
- platform/efl-wk2/TestExpectations:
- platform/efl-wk2/compositing/contents-opaque/control-layer-expected.txt: Added.
- platform/efl-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt: Added.
- platform/efl-wk2/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- platform/efl-wk2/compositing/rtl/rtl-overflow-scrolling-expected.png: Added.
- platform/efl-wk2/compositing/rtl/rtl-overflow-scrolling-expected.txt: Added.
- platform/efl-wk2/css3/flexbox/flexbox-baseline-expected.png: Added.
- platform/efl-wk2/css3/flexbox/flexbox-baseline-expected.txt: Added.
- platform/efl-wk2/editing/pasteboard/copy-paste-content-starting-and-ending-canvas-expected.txt: Added.
- platform/efl-wk2/editing/pasteboard/pasting-into-p-should-not-nest-p-expected.txt: Added.
- platform/efl-wk2/editing/selection/move-by-character-6-expected.txt: Removed.
- platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt: Added.
- platform/efl-wk2/fast/dom/icon-url-property-expected.txt: Added.
- platform/efl-wk2/fast/dynamic/002-expected.txt: Added.
- platform/efl-wk2/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Added.
- platform/efl-wk2/fast/media/mq-resolution-expected.txt: Added.
- platform/efl-wk2/fast/media/w3c/test_media_queries-expected.txt: Added.
- platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
- platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
- platform/efl-wk2/fast/repaint/moving-shadow-on-container-expected.txt: Added.
- platform/efl-wk2/fast/repaint/moving-shadow-on-path-expected.txt: Added.
- platform/efl-wk2/fast/table/overflowHidden-expected.txt: Added.
- platform/efl-wk2/fast/text/complex-text-opacity-expected.png: Added.
- platform/efl-wk2/fast/text/complex-text-opacity-expected.txt: Added.
- platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.png: Added.
- platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
- platform/efl-wk2/fast/transforms/bounding-rect-zoom-expected.txt: Added.
- platform/efl-wk2/http/tests/inspector/console-resource-errors-expected.txt: Added.
- platform/efl-wk2/http/tests/security/xssAuditor/link-opens-new-window-expected.txt: Added.
- platform/efl-wk2/inspector/styles/paste-property-expected.txt: Added.
- platform/efl-wk2/svg/css/composite-shadow-example-expected.txt: Added.
- platform/efl-wk2/svg/css/composite-shadow-with-opacity-expected.txt: Added.
- platform/efl-wk2/tables/mozilla/bugs/bug73321-expected.txt: Added.
- platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.png: Added.
- platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
- platform/efl-wk2/transforms/2d/hindi-rotated-expected.png: Added.
- platform/efl-wk2/transforms/2d/hindi-rotated-expected.txt: Added.
- 5:50 AM Changeset in webkit [147419] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding failure expectations for two Resource Timing layout tests
that regressed with r147387.
- 5:39 AM QtWebKitBuildBots edited by
- Qt Mountain Lion bot moved to Apple master (diff)
- 5:16 AM Changeset in webkit [147418] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] Implement ScrollingCoordinator::frameViewLayoutUpdated()
https://bugs.webkit.org/show_bug.cgi?id=113763
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-02
Reviewed by Rob Buis.
PR 318945
Internally reviewed by Jakob Petsovits.
And remove the BlackBerry specific methods
frameViewFrameRectDidChange and frameViewContentsSizeDidChange.
- page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp:
(WebCore::ScrollingCoordinatorBlackBerry::frameViewLayoutUpdated):
Called when the frame view has been laid out. Update the contents
rectangle and visible area of the scroll layer for the given frame
view.
- page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.h:
(ScrollingCoordinatorBlackBerry):
- platform/graphics/blackberry/LayerWebKitThread.h:
(WebCore::LayerWebKitThread::setFrameVisibleRect): Return early if
value hasn't changed.
(WebCore::LayerWebKitThread::setFrameContentsSize): Ditto.
- 5:06 AM Changeset in webkit [147417] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing tests after r147384 and r147388.
- platform/qt/TestExpectations:
- platform/qt/fast/table/overflowHidden-expected.txt: Rebaselining after 147374.
- 3:58 AM Changeset in webkit [147416] by
-
- 4 edits in trunk
Unreviewed, rolling out r147401.
http://trac.webkit.org/changeset/147401
https://bugs.webkit.org/show_bug.cgi?id=113767
The patch makes it extremely hard to set up the dependencies
properly on the GTK builders (Requested by zdobersek on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-02
.:
- Source/autotools/Versions.m4:
Tools:
- gtk/jhbuild.modules:
- 3:49 AM Changeset in webkit [147415] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Separate JavaScriptSourceFrame popover from knowledge of editor's DOM
https://bugs.webkit.org/show_bug.cgi?id=113412
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
- Use TextEditor.coordinatesToCursorPosition,
TextEditor.cursorPositionToCoordinates and TextEditor.tokenAtTextPosition to figure out
hovering area and create popover anchor.
- Use TextEditor.highlightRange/TextEditor.removeHighlight methods to
highlight hovering text in editor.
No new tests: no change in behaviour.
- inspector/front-end/DefaultTextEditor.js:
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.willHide):
(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
(WebInspector.JavaScriptSourceFrame.prototype.):
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
- inspector/front-end/inspector.css:
(.popover-anchor):
(.source-frame-eval-expression):
- 3:33 AM Changeset in webkit [147414] by
-
- 10 edits in trunk/Source/WebCore
[CSSRegions] RenderFlowThread should not be created as a Document renderer
https://bugs.webkit.org/show_bug.cgi?id=113658
Reviewed by Julien Chaffraix.
After https://bugs.webkit.org/show_bug.cgi?id=107138, RenderFlowThread should not be constructed as a renderer for Document.
Since it does not have an element associated, it will be constructed using the pattern for anonymous blocks.
However, since I do not want the flow thread to be collapsed as anonymous blocks are, i changed RenderObject::isAnonymousBlock
to return false for a RenderFlowThread (the alternative would have been to patch more call sites to prevent RenderFlowThread
collapsing as anonymous block).
Covered by existing tests.
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
- rendering/RenderFlowThread.h:
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::addChild):
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
(WebCore::RenderMultiColumnFlowThread::createAnonymous):
- rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::createAnonymous):
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
- rendering/RenderNamedFlowThread.h:
(RenderNamedFlowThread):
- rendering/RenderObject.h:
(WebCore::RenderObject::isAnonymousBlock):
- 3:21 AM Changeset in webkit [147413] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r147383.
http://trac.webkit.org/changeset/147383
https://bugs.webkit.org/show_bug.cgi?id=112369
Speculative rollout because of lots of layout test failure
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::~HTMLDocumentParser):
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::insert):
- html/parser/HTMLParserScheduler.cpp:
(WebCore::PumpSession::PumpSession):
- html/parser/HTMLParserScheduler.h:
- 2:52 AM Changeset in webkit [147412] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [HeapProfiler] Table rows do not appear when resizing.
https://bugs.webkit.org/show_bug.cgi?id=113760
Reviewed by Yury Semikhatsky.
Analysis: custom-made split-view doesn't notify content panes about
resizing.
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._updateRetainmentViewHeight):
Notify content pane about resize.
- 2:50 AM Changeset in webkit [147411] by
-
- 3 edits in trunk/Source/WebCore
[CSSRegions] Clean-up RenderFlowThread::updateRegionsFlowThreadPortionRect
https://bugs.webkit.org/show_bug.cgi?id=113659
Reviewed by Julien Chaffraix.
RenderRegion::logicalHeightOfAllFlowThreadContent already contains the
override logical content height for auto-height regions in normal layout phase.
Therefore, there is no need to explicitly override region's rect height with
the region's overrideLogicalContentHeight as the region rect already contains
the right value.
No change in functionality, covered by existing tests.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
- 2:50 AM Changeset in webkit [147410] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Empty tooltip shown when hovering over popup menu items
https://bugs.webkit.org/show_bug.cgi?id=113382
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-04-02
Reviewed by Gyuyoung Kim.
Do not show the empty tooltip box if the text is null.
- MiniBrowser/efl/main.c:
(popup_menu_populate):
- 2:47 AM Changeset in webkit [147409] by
-
- 14 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaselining after r147402.
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- platform/qt/TestExpectations:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- 2:33 AM Changeset in webkit [147408] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
rebaselined after r147390.
TestExpectation was deleted wrongly. Let me revert it.
- platform/chromium/TestExpectations:
- 2:08 AM Changeset in webkit [147407] by
-
- 1 edit7 adds15 deletes in trunk/LayoutTests
[Chromium] Unreviewed gardening.
rebaselined after r147390.
- platform/chromium-linux-x86/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Removed.
- platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Removed.
- platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Removed.
- platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug625-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/td_valign_bottom-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
- platform/chromium-linux/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
- platform/chromium-mac-lion/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Removed.
- platform/chromium-mac-snowleopard/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
- 2:01 AM Changeset in webkit [147406] by
-
- 2 edits in trunk/LayoutTests
[QT] Cleanup after r139447 and r145374.
https://bugs.webkit.org/show_bug.cgi?id=113671
Unreviewed gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-02
- platform/qt/TestExpectations:
- 1:49 AM Changeset in webkit [147405] by
-
- 2 edits1 add in trunk/LayoutTests
[Qt]REGRESSION?(r63191): http/tests/inspector/resource-har-conversion.html fails
https://bugs.webkit.org/show_bug.cgi?id=42162
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-02
Reviewed by Csaba Osztrogonác.
Copy the results of http/tests/inspector/resource-har-conversion.html
to the qt platform dir.
- platform/qt/TestExpectations:
- platform/qt/http/tests/inspector/resource-har-conversion-expected.txt: Added.
- 1:33 AM Changeset in webkit [147404] by
-
- 159 edits7 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
rebaselined after r147390.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug625-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
- platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac-lion/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
- platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
- platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium/TestExpectations:
- 1:32 AM Changeset in webkit [147403] by
-
- 82 edits in trunk/Source/WebKit2
[WK2] Remove repeating code in declaration of WK2 API classes
https://bugs.webkit.org/show_bug.cgi?id=112782
Reviewed by Benjamin Poulain.
The following two lines of code had been repeated in every WK2 API
object class:
1) static const Type APIType = SomeAPIType;
2) virtual Type type() const { return APIType; }
This patch introduces template class 'TypedAPIObject' inherited
from WebKit::APIObject and it contains the common functionality.
So the new pattern is that API object classes are inherited from
TypedAPIObject (rather than from WebKit::APIObject directly) passing
the corresponding API object type as a template parameter.
The existing API object classes are modified accordingly to the
proposed pattern.
- Shared/APIObject.h:
(WebKit):
(TypedAPIObject):
(WebKit::TypedAPIObject::~TypedAPIObject):
(WebKit::TypedAPIObject::TypedAPIObject):
- Shared/ImmutableArray.h:
(ImmutableArray):
- Shared/ImmutableDictionary.h:
(ImmutableDictionary):
- Shared/WebArchive.h:
(WebArchive):
- Shared/WebArchiveResource.h:
(WebArchiveResource):
- Shared/WebBackForwardListItem.h:
(WebBackForwardListItem):
- Shared/WebBatteryStatus.h:
(WebBatteryStatus):
- Shared/WebCertificateInfo.h:
- Shared/WebConnection.h:
(WebConnection):
- Shared/WebContextMenuItem.h:
(WebContextMenuItem):
- Shared/WebData.h:
- Shared/WebError.h:
(WebKit::WebError::errorCode):
- Shared/WebGeolocationPosition.h:
(WebGeolocationPosition):
- Shared/WebGeometry.h:
- Shared/WebGraphicsContext.h:
(WebGraphicsContext):
- Shared/WebHitTestResult.h:
- Shared/WebImage.h:
(WebImage):
- Shared/WebNetworkInfo.h:
(WebNetworkInfo):
- Shared/WebNumber.h:
- Shared/WebOpenPanelParameters.h:
(WebOpenPanelParameters):
- Shared/WebRenderLayer.h:
- Shared/WebRenderObject.h:
- Shared/WebSecurityOrigin.h:
- Shared/WebSerializedScriptValue.h:
(WebSerializedScriptValue):
- Shared/WebString.h:
- Shared/WebURL.h:
- Shared/WebURLRequest.h:
(WebURLRequest):
- Shared/WebURLResponse.h:
(WebURLResponse):
- Shared/WebUserContentURLPattern.h:
- Shared/mac/ObjCObjectGraph.h:
- UIProcess/Authentication/AuthenticationChallengeProxy.h:
(AuthenticationChallengeProxy):
- UIProcess/Authentication/AuthenticationDecisionListener.h:
(AuthenticationDecisionListener):
- UIProcess/Authentication/WebCredential.h:
(WebCredential):
- UIProcess/Authentication/WebProtectionSpace.h:
(WebProtectionSpace):
- UIProcess/Downloads/DownloadProxy.h:
(DownloadProxy):
- UIProcess/GeolocationPermissionRequestProxy.h:
(GeolocationPermissionRequestProxy):
- UIProcess/Notifications/NotificationPermissionRequest.h:
(NotificationPermissionRequest):
- UIProcess/Notifications/WebNotification.h:
(WebNotification):
- UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
- UIProcess/Plugins/WebPluginSiteDataManager.h:
(WebPluginSiteDataManager):
- UIProcess/WebApplicationCacheManagerProxy.h:
(WebApplicationCacheManagerProxy):
- UIProcess/WebBackForwardList.h:
(WebBackForwardList):
- UIProcess/WebBatteryManagerProxy.h:
(WebBatteryManagerProxy):
- UIProcess/WebContext.h:
(WebContext):
- UIProcess/WebCookieManagerProxy.h:
(WebCookieManagerProxy):
- UIProcess/WebDatabaseManagerProxy.h:
(WebDatabaseManagerProxy):
- UIProcess/WebEditCommandProxy.h:
(WebEditCommandProxy):
- UIProcess/WebFrameProxy.h:
(WebFrameProxy):
- UIProcess/WebGeolocationManagerProxy.h:
(WebGeolocationManagerProxy):
- UIProcess/WebGrammarDetail.h:
(WebGrammarDetail):
- UIProcess/WebIconDatabase.h:
(WebIconDatabase):
- UIProcess/WebInspectorProxy.h:
(WebInspectorProxy):
- UIProcess/WebKeyValueStorageManagerProxy.h:
(WebKeyValueStorageManagerProxy):
- UIProcess/WebMediaCacheManagerProxy.h:
(WebMediaCacheManagerProxy):
- UIProcess/WebNavigationData.h:
(WebNavigationData):
- UIProcess/WebNetworkInfoManagerProxy.h:
(WebNetworkInfoManagerProxy):
- UIProcess/WebOpenPanelResultListenerProxy.h:
(WebOpenPanelResultListenerProxy):
- UIProcess/WebPageGroup.h:
(WebPageGroup):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::WebPreferences):
- UIProcess/WebPreferences.h:
(WebPreferences):
- UIProcess/WebResourceCacheManagerProxy.h:
(WebResourceCacheManagerProxy):
- UIProcess/WebTextChecker.h:
(WebTextChecker):
- UIProcess/WebVibrationProxy.h:
(WebVibrationProxy):
- UIProcess/efl/WebPopupItemEfl.h:
(WebPopupItemEfl):
- UIProcess/efl/WebView.h:
- UIProcess/soup/WebSoupRequestManagerProxy.h:
(WebSoupRequestManagerProxy):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
(InjectedBundleNodeHandle):
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:
(InjectedBundleRangeHandle):
- WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
- WebProcess/InjectedBundle/InjectedBundleBackForwardList.h:
- WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h:
(InjectedBundleDOMWindowExtension):
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:
(InjectedBundleNavigationAction):
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
(InjectedBundleScriptWorld):
- WebProcess/WebPage/PageOverlay.h:
(PageOverlay):
- WebProcess/WebPage/WebFrame.h:
(WebFrame):
- WebProcess/WebPage/WebInspector.h:
(WebInspector):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/WebPageGroupProxy.h:
(WebPageGroupProxy):
- 1:28 AM Changeset in webkit [147402] by
-
- 22 edits in trunk
X-Frame-Options: Blocked frames should not inherit their parent's SecurityOrigin.
https://bugs.webkit.org/show_bug.cgi?id=112903
Reviewed by Adam Barth.
Source/WebCore:
This change brings WebKit in line with IE and Gecko's behavior, both of
which treat the blocked frame as being cross-origin for the purposes of
access checks ('[frame].contentWindow.location.href' is inaccessible,
for example).
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
Rather than redirecting to 'about:blank', redirect to
'data:text/html,<p></p>' which does not inherit the SecurityOrigin
of the parent.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
Before calling cancelMainResourceLoad, ensure that the frame's
document is sandboxed into a unique origin so that it doesn't
inherit the parent's SecurityOrigin.
LayoutTests:
- http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html:
- http/tests/security/XFrameOptions/x-frame-options-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- 1:25 AM Changeset in webkit [147401] by
-
- 4 edits in trunk
[GTK] Bump required versions of some dependencies
https://bugs.webkit.org/show_bug.cgi?id=113282
Reviewed by Martin Robinson.
.:
This patch updates the following dependencies:
- libsoup 2.42.0: is the current stable release.
- glib 2.36.0: libsoup 2.42 requires 2.35.0, but we don't want to depend on unstable versions and 2.36 is the next stable version after 2.35.
- gtk+ 3.6.0: this is the previous stable release. We don't currently have any code using newer API, so we will be able to remove all the #ifdefed code.
- at-spi2 2.5.3: is the version required by gtk+ 3.6.
- GObject introspection 1.32.0: is the version required by gtk+ 3.6.
- Pango 1.32.0: it's the current stable version and the first one depending on Harfbuzz.
- Fontconfig 2.5: required by pango 1.32.0 when using Harfbuzz.
- gtk+ 2.24.10: it allows us to remove a lot of deprecated code and #ifdefs.
- Source/autotools/Versions.m4:
Tools:
- gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
- 1:21 AM Changeset in webkit [147400] by
-
- 224 edits2 copies13 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
rebaselined after r147390.
- platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png.
- platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png.
- platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/clip-mask-negative-scale-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png:
- platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png:
- platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png:
- platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png:
- platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
- 1:12 AM Changeset in webkit [147399] by
-
- 121 edits2 copies1 add in trunk/LayoutTests
[Chromium] Unreviewed gardening.
rebaselined after r147390.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png.
- platform/chromium-linux-x86/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png.
- platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- 1:02 AM Changeset in webkit [147398] by
-
- 77 edits5 adds4 deletes in trunk/LayoutTests
[Chromium] Unreviewed gardening.
rebaselined after r147390.
- platform/chromium-linux-x86/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: Added.
- platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Removed.
- platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Removed.
- platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Removed.
- platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Removed.
- platform/chromium-linux-x86/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
- platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
- platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
- platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
- platform/chromium-mac-lion/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac-lion/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac-lion/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac-lion/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac-lion/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac-lion/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac-lion/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac-lion/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-lion/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
- platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
- platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-win/fast/borders/border-image-scaled-expected.png:
- platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
- platform/chromium-win/fast/borders/scaled-border-image-expected.png:
- platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
- 12:53 AM Changeset in webkit [147397] by
-
- 9 edits1 move1 add in trunk/LayoutTests
[Chromium] Unreviewed gardening.
rebaselined after r147390.
- platform/chromium-linux/css3/images/cross-fade-background-size-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-win/css3/images/cross-fade-background-size-expected.png: Renamed from LayoutTests/platform/chromium/css3/images/cross-fade-background-size-expected.png.
- 12:11 AM Changeset in webkit [147396] by
-
- 3 edits in trunk
[EFL][CMAKE] Move MOZ_X11 definition from OptionsCommon to OptionsEfl
https://bugs.webkit.org/show_bug.cgi?id=113685
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-02
Reviewed by Martin Robinson.
MOZ_X11 is added unconditionally in OptionsCommon for UNIX
platforms, but not all UNIX platforms use X11 for plugins,
BlackBerry doesn't. The only port using cmake that uses X11 is EFL
and it already has checks for X11, so we can just move the
definition to OptionsEfl.
- Source/cmake/OptionsCommon.cmake:
- Source/cmake/OptionsEfl.cmake:
