Timeline
Jul 15, 2013:
- 11:55 PM Changeset in webkit [152707] by
-
- 4 edits3 adds in trunk
Source/WebCore: Fix a crash in Range::processContents().
NULL ptr in WebCore::Range::processAncestorsAndTheirSiblings
https://bugs.webkit.org/show_bug.cgi?id=77614
Reviewed by Ryosuke Niwa.
This change is ported from Blink revision 153483:
https://src.chromium.org/viewvc/blink?revision=153483&view=revision
This crash can be initiated by calling Range.detach() while deleteContents()
is processing the same range. Range::processContents() should save the state
of the range since mutation events can change the state of the range.
Test: fast/dom/Range/detach-range-during-deletecontents.html
- dom/Range.cpp:
(WebCore::Range::processContents):
- dom/RangeBoundaryPoint.h:
(WebCore::RangeBoundaryPoint::RangeBoundaryPoint):
LayoutTests: NULL ptr in WebCore::Range::processAncestorsAndTheirSiblings
https://bugs.webkit.org/show_bug.cgi?id=77614
Reviewed by Ryosuke Niwa.
This change is ported from Blink revision 153483:
https://src.chromium.org/viewvc/blink?revision=153483&view=revision
- fast/dom/Range/detach-range-during-deletecontents-expected.txt: Added.
- fast/dom/Range/detach-range-during-deletecontents.html: Added.
- fast/dom/Range/resources/detach-range-during-deletecontents-iframe.xhtml: Added.
- 11:32 PM Changeset in webkit [152706] by
-
- 2 edits in trunk/Source/WTF
Add a threading assertion to AtomicString::remove
https://bugs.webkit.org/show_bug.cgi?id=118695
Reviewed by Sam Weinig.
- wtf/text/AtomicString.cpp:
(WTF::AtomicString::remove): The destructor of StringImpl remove
the string from the string table if it is atomic. This needs to be done
on the same thread as the one on which the string was added (otherwise the original
table would keep a dangling pointer to a dead string).
- 10:19 PM Changeset in webkit [152705] by
-
- 3 edits2 adds in trunk
Input element that becomes visible during a simulated click event from an associated label element doesn't get focused
https://bugs.webkit.org/show_bug.cgi?id=118700
Reviewed by Kent Tamura.
Source/WebCore:
Inspired by https://chromium.googlesource.com/chromium/blink/+/6435f70d53403b250e261a914f30d55142f81476.
The bug was caused by isMouseFocusable() check in HTMLLabelElement::defaultEventHandler not updating the layout even
though the call to dispatchSimulatedClick may have dirtied the render tree.
Explicitly update the layout so that we have up-to-date render tree.
Test: fast/forms/label/label-becomes-visible-while-clicking-on-label.html
- html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::defaultEventHandler):
LayoutTests:
Add a regression test.
- fast/forms/label/label-becomes-visible-while-clicking-on-label-expected.txt: Added.
- fast/forms/label/label-becomes-visible-while-clicking-on-label.html: Added.
- 10:01 PM Changeset in webkit [152704] by
-
- 11 edits in trunk/Source
Introduce toHTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=118672
Reviewed by Ryosuke Niwa.
To avoid direct use of static_cast, this patch introduces toHTMLIFrameElement for code cleanup.
Source/WebCore:
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- dom/Document.cpp:
(WebCore::Document::seamlessParentIFrame):
- html/HTMLIFrameElement.h:
(WebCore::toHTMLIFrameElement):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::viewCleared):
- rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::isSeamless):
(WebCore::RenderIFrame::flattenFrame):
Source/WebKit/win:
- DOMHTMLClasses.cpp:
(DOMHTMLIFrameElement::contentFrame):
Source/WebKit2:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):
- 9:56 PM Changeset in webkit [152703] by
-
- 4 edits in trunk/LayoutTests
Unreviewed rebaselines after r152701.
- editing/pasteboard/paste-noplugin-expected.txt:
- http/tests/security/contentSecurityPolicy/object-src-url-blocked-expected.txt:
- platform/mac/accessibility/plugin-expected.txt:
- 9:55 PM Changeset in webkit [152702] by
-
- 12 edits9 adds in trunk
Add support for WaveShaperNode.oversample
https://bugs.webkit.org/show_bug.cgi?id=117435
Reviewed by Kenneth Russell.
Source/WebCore:
Adapted from Blink:
https://codereview.chromium.org/15619003/
Please see specification for details:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#WaveShaperNode
.oversample specifies what type of oversampling (if any) should be used when applying the shaping curve.
The default value is "none", meaning the curve will be applied directly to the input samples.
A value of "2x" or "4x" can improve the quality of the processing by avoiding some aliasing,
with the "4x" value yielding the highest quality.
Tests: webaudio/waveshaper-oversample-2x.html
webaudio/waveshaper-oversample-4x.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/webaudio/WaveShaperDSPKernel.cpp:
(WebCore::WaveShaperDSPKernel::WaveShaperDSPKernel):
(WebCore::WaveShaperDSPKernel::lazyInitializeOversampling):
(WebCore::WaveShaperDSPKernel::process):
(WebCore::WaveShaperDSPKernel::processCurve):
(WebCore::WaveShaperDSPKernel::processCurve2x):
(WebCore::WaveShaperDSPKernel::processCurve4x):
(WebCore::WaveShaperDSPKernel::reset):
(WebCore::WaveShaperDSPKernel::latencyTime):
- Modules/webaudio/WaveShaperDSPKernel.h:
- Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::WaveShaperNode):
(WebCore::WaveShaperNode::setOversample):
(WebCore::WaveShaperNode::oversample):
- Modules/webaudio/WaveShaperNode.h:
(WebCore::WaveShaperNode::latency):
- Modules/webaudio/WaveShaperNode.idl:
- Modules/webaudio/WaveShaperProcessor.cpp:
(WebCore::WaveShaperProcessor::WaveShaperProcessor):
(WebCore::WaveShaperProcessor::setOversample):
- Modules/webaudio/WaveShaperProcessor.h:
(WebCore::WaveShaperProcessor::oversample):
- WebCore.xcodeproj/project.pbxproj:
- platform/audio/DownSampler.cpp: Added.
(WebCore::DownSampler::DownSampler):
(WebCore::DownSampler::initializeKernel):
(WebCore::DownSampler::process):
(WebCore::DownSampler::reset):
(WebCore::DownSampler::latencyFrames):
- platform/audio/DownSampler.h: Added.
- platform/audio/UpSampler.cpp: Added.
(WebCore::UpSampler::UpSampler):
(WebCore::UpSampler::initializeKernel):
(WebCore::UpSampler::process):
(WebCore::UpSampler::reset):
(WebCore::UpSampler::latencyFrames):
- platform/audio/UpSampler.h: Added.
LayoutTests:
- webaudio/resources/waveshaper-testing.js: Added.
(T0):
(T1):
(T2):
(T3):
(T4):
(generateWaveShapingCurve):
(checkShapedCurve):
(createImpulseBuffer):
(runWaveShaperOversamplingTest):
- webaudio/waveshaper-oversample-2x-expected.txt: Added.
- webaudio/waveshaper-oversample-2x.html: Added.
- webaudio/waveshaper-oversample-4x-expected.txt: Added.
- webaudio/waveshaper-oversample-4x.html: Added.
- 9:01 PM Changeset in webkit [152701] by
-
- 38 edits1 add in trunk
Update blocked/missing plug-in UI
https://bugs.webkit.org/show_bug.cgi?id=118347
<rdar://problem/14209318>
Reviewed by Sam Weinig.
Patch by Anders Carlsson, Antoine Quint, Sam Weinig, and myself.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSDefaultStyleSheets.cpp:
- css/unavailablePlugIns.css: Added.
Add new Source/WebCore/css/unavailablePlugIns.css stylesheet.
- dom/EventListener.h:
New event listener type to support the creation of an event listener
for the label and icon for missing / blocked plug-in UI.
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
Remove explicit event handling since we're now using a DOM event handler
on the label and icon in the shadow root.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
Don't populate the shadow root with plugin snapshotting elements
if we're not planning on showing a snapshot, because this means that
the shadow root was created for the unavailable plugin indicator instead.
- page/ChromeClient.h:
(WebCore::ChromeClient::shouldUnavailablePluginMessageIncludeButton):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
(WebCore::shouldUnavailablePluginMessageIncludeButton):
Rename from shouldUnavailablePluginMessageBeButton to
shouldUnavailablePluginMessageIncludeButton for accuracy.
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReasonDescription):
Set custom text to be displayed in the unavailability indicator.
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginButtonClickEvent):
(WebCore::RenderEmbeddedObject::willBeDestroyed):
(WebCore::RenderEmbeddedObject::isReplacementObscured):
(WebCore::RenderEmbeddedObjectEventListener::handleEvent):
(WebCore::RenderEmbeddedObjectEventListener::operator==):
Remove the old code used to render the missing / blocked plug-in UI in C++ in favor
of populating a shadow root in setPluginUnavailabilityReason(). We add a DOM event
listener in the shadow root to eventually call into unavailablePluginButtonClicked()
on the ChromeClient.
(WebCore::RenderEmbeddedObject::paint):
(WebCore::RenderEmbeddedObject::layout):
Paint and lay out UA shadow root children.
(WebCore::RenderEmbeddedObject::canHaveChildren):
canHaveChildren can use the existence of a UA shadow root to decide
whether a RenderEmbeddedObject can have children.
- rendering/RenderEmbeddedObject.h:
(WebCore::RenderEmbeddedObjectEventListener::create):
(WebCore::RenderEmbeddedObjectEventListener::cast):
(WebCore::RenderEmbeddedObjectEventListener::RenderEmbeddedObjectEventListener):
Create the new event listener class necessary to handle events in the shadow root.
(WebCore::RenderEmbeddedObject::pluginUnavailabilityReasonDescription): Added.
- rendering/RenderWidget.h:
Promote willBeDestroyed() to be public so we may override it in the RenderEmbeddedObject subclass.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldUnavailablePluginMessageIncludeButton):
Rename from shouldUnavailablePluginMessageBeButton to
shouldUnavailablePluginMessageIncludeButton for accuracy.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add a 6 argument -> 4 reply message handler.
(It seems that FindPlugin is getting a little out of hand.)
- Shared/APIClientTraits.cpp:
- Shared/APIClientTraits.h:
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::pluginLoadPolicy):
- UIProcess/WebLoaderClient.h:
Add an unavailability description out-argument to a new version of
pluginLoadPolicy, so clients can override the text of the unavailable
plugin indicator. Bump the WKPageLoaderClient version and update APIClientTraits.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
Plumb the unavailability description through to the WebProcess via
the FindPlugin message.
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didClose):
Make a strongly referencing copy of the list of PluginProxies, so we can
throw them away without the HashMap being mutated underneath us (see the comment).
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginProcessCrashed):
Invalidate the plug-in's widget before setting the plugin unavailability reason,
because doing so would cause the plug-in's renderer to be torn down, making
invalidate() crash.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUnavailablePluginMessageIncludeButton):
- WebProcess/WebCoreSupport/WebChromeClient.h:
Rename from shouldUnavailablePluginMessageBeButton to
shouldUnavailablePluginMessageIncludeButton for accuracy.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Acquire the unavailability description from the client
(via FindPlugin) and hand it to the RenderEmbeddedObject.
(WebKit::WebPage::canPluginHandleResponse):
Re-acquire the plugin's renderer, in case setPluginUnavailabilityReason destroyed it.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
Match new WKPageLoaderClient entry.
- 8:56 PM Changeset in webkit [152700] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Unreviewed. Add Gwang Yoon Hwang to contributor list.
- 8:32 PM Changeset in webkit [152699] by
-
- 2 edits in trunk/LayoutTests
Mark svg/custom/xlink-prefix-in-attributes.html as failing on Mac
https://bugs.webkit.org/show_bug.cgi?id=118701
Unreviewed, changing test expectations
- platform/mac/TestExpectations:
- 7:36 PM Changeset in webkit [152698] by
-
- 2 edits in trunk/Source/WebKit2
PluginProcess deny file-read-data /Library/Application Support/Macromedia/FlashPlayerTrust
https://bugs.webkit.org/show_bug.cgi?id=118690
<rdar://problem/14255963>
Patch by Simon Cooper <scooper@apple.com> on 2013-07-15
Reviewed by Dean Jackson.
Silently deny access to FlashPlayerTrust. This location contains
files containing lists of paths that Flash Player will
"allow" access to (without asking the user). Since the plugin
sandbox won't permit the access to the listed paths it is better
to silently block attempts to read these "whitelists". The
"whitelists" are created by other Adobe "installer" like
applications.
- Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
- 7:24 PM Changeset in webkit [152697] by
-
- 5 edits in branches/safari-537-branch/Source
Versioning.
- 7:22 PM Changeset in webkit [152696] by
-
- 1 copy in tags/Safari-537.51
New Tag.
- 7:17 PM Changeset in webkit [152695] by
-
- 5 edits in branches/safari-537-branch/Source
Versioning.
- 7:00 PM Changeset in webkit [152694] by
-
- 5 edits2 copies in branches/safari-537-branch/Tools
Merged r152498. <rdar://problem/13686836>
- 6:44 PM Changeset in webkit [152693] by
-
- 3 edits in branches/safari-537-branch/Source
Merged r152689. <rdar://problem/14446014>
- 6:34 PM Changeset in webkit [152692] by
-
- 45 edits18 adds in branches/dfgFourthTier/Source
fourthTier: DFG should have an SSA form for use by FTL
https://bugs.webkit.org/show_bug.cgi?id=118338
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Adds an SSA form to the DFG. We can convert ThreadedCPS form into SSA form
after breaking critical edges. The conversion algorithm follows Aycock and
Horspool, and the SSA form itself follows something I've done before, where
instead of having Phi functions specify input nodes corresponding to block
predecessors, we instead have Upsilon functions in the predecessors that
specify which value in that block goes into which subsequent Phi. Upsilons
don't have to dominate Phis (usually they don't) and they correspond to a
non-SSA "mov" into the Phi's "variable". This gives all of the good
properties of SSA, while ensuring that a bunch of CFG transformations don't
have to be SSA-aware.
So far the only DFG phases that are SSA-aware are DCE and CFA. CFG
simplification is probably SSA-aware by default, though I haven't tried it.
Constant folding probably needs a few tweaks, but is likely ready. Ditto
for CSE, though it's not clear that we'd want to use block-local CSE when
we could be doing GVN.
Currently only the FTL can generate code from the SSA form, and there is no
way to convert from SSA to ThreadedCPS or LoadStore. There probably will
never be such a capability.
In order to handle OSR exit state in the SSA, we place MovHints at Phi
points. Other than that, you can reconstruct state-at-exit by forward
propagating MovHints. Note that MovHint is the new SetLocal in SSA.
SetLocal and GetLocal only survive into SSA if they are on captured
variables, or in the case of flushes. A "live SetLocal" will be
NodeMustGenerate and will always correspond to a flush. Computing the
state-at-exit requires running SSA liveness analysis, OSR availability
analysis, and flush liveness analysis. The FTL runs all of these prior to
generating code. While OSR exit continues to be tricky, much of the logic
is now factored into separate phases and the backend has to do less work
to reason about what happened outside of the basic block that is being
lowered.
Conversion from DFG SSA to LLVM SSA is done by ensuring that we generate
code in depth-first order, thus guaranteeing that a node will always be
lowered (and hence have a LValue) before any of the blocks dominated by
that node's block have code generated. For Upsilon/Phi, we just use
alloca's. We could do something more clever there, but it's probably not
worth it, at least not now.
Finally, while the SSA form is currently only being converted to LLVM IR,
there is nothing that prevents us from considering other backends in the
future - with the caveat that this form is designed to be first lowered to
a lower-level SSA before actual machine code generation commences. So we
ought to either use LLVM (the intended path) or we will have to write our
own SSA low-level backend.
This runs all of the code that the FTL was known to run previously. No
change in performance for now. But it does open some exciting
possibilities!
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/Operands.h:
(JSC::OperandValueTraits::dump):
(JSC::Operands::fill):
(Operands):
(JSC::Operands::clear):
(JSC::Operands::operator==):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::setLiveValues):
(DFG):
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::executeEffects):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::merge):
- dfg/DFGAbstractState.h:
(AbstractState):
- dfg/DFGAdjacencyList.h:
(JSC::DFG::AdjacencyList::justOneChild):
(AdjacencyList):
- dfg/DFGBasicBlock.cpp: Added.
(DFG):
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::~BasicBlock):
(JSC::DFG::BasicBlock::ensureLocals):
(JSC::DFG::BasicBlock::isInPhis):
(JSC::DFG::BasicBlock::isInBlock):
(JSC::DFG::BasicBlock::removePredecessor):
(JSC::DFG::BasicBlock::replacePredecessor):
(JSC::DFG::BasicBlock::dump):
(JSC::DFG::BasicBlock::SSAData::SSAData):
(JSC::DFG::BasicBlock::SSAData::~SSAData):
- dfg/DFGBasicBlock.h:
(BasicBlock):
(JSC::DFG::BasicBlock::operator[]):
(JSC::DFG::BasicBlock::successor):
(JSC::DFG::BasicBlock::successorForCondition):
(SSAData):
- dfg/DFGBasicBlockInlines.h:
(DFG):
- dfg/DFGBlockInsertionSet.cpp: Added.
(DFG):
(JSC::DFG::BlockInsertionSet::BlockInsertionSet):
(JSC::DFG::BlockInsertionSet::~BlockInsertionSet):
(JSC::DFG::BlockInsertionSet::insert):
(JSC::DFG::BlockInsertionSet::insertBefore):
(JSC::DFG::BlockInsertionSet::execute):
- dfg/DFGBlockInsertionSet.h: Added.
(DFG):
(BlockInsertionSet):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::run):
- dfg/DFGCFGSimplificationPhase.cpp:
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlock):
- dfg/DFGCommon.cpp:
(WTF::printInternal):
- dfg/DFGCommon.h:
(JSC::DFG::doesKill):
(DFG):
(JSC::DFG::killStatusForDoesKill):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::isCapturedAtOrAfter):
- dfg/DFGCriticalEdgeBreakingPhase.cpp: Added.
(DFG):
(CriticalEdgeBreakingPhase):
(JSC::DFG::CriticalEdgeBreakingPhase::CriticalEdgeBreakingPhase):
(JSC::DFG::CriticalEdgeBreakingPhase::run):
(JSC::DFG::CriticalEdgeBreakingPhase::breakCriticalEdge):
(JSC::DFG::performCriticalEdgeBreaking):
- dfg/DFGCriticalEdgeBreakingPhase.h: Added.
(DFG):
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::run):
(JSC::DFG::DCEPhase::findTypeCheckRoot):
(JSC::DFG::DCEPhase::countNode):
(DCEPhase):
(JSC::DFG::DCEPhase::countEdge):
(JSC::DFG::DCEPhase::eliminateIrrelevantPhantomChildren):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGEdge.cpp:
(JSC::DFG::Edge::dump):
- dfg/DFGEdge.h:
(JSC::DFG::Edge::Edge):
(JSC::DFG::Edge::setNode):
(JSC::DFG::Edge::useKindUnchecked):
(JSC::DFG::Edge::setUseKind):
(JSC::DFG::Edge::setProofStatus):
(JSC::DFG::Edge::willNotHaveCheck):
(JSC::DFG::Edge::willHaveCheck):
(Edge):
(JSC::DFG::Edge::killStatusUnchecked):
(JSC::DFG::Edge::killStatus):
(JSC::DFG::Edge::setKillStatus):
(JSC::DFG::Edge::doesKill):
(JSC::DFG::Edge::doesNotKill):
(JSC::DFG::Edge::shift):
(JSC::DFG::Edge::makeWord):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGFlushFormat.cpp: Added.
(WTF):
(WTF::printInternal):
- dfg/DFGFlushFormat.h: Added.
(DFG):
(JSC::DFG::resultFor):
(JSC::DFG::useKindFor):
(WTF):
- dfg/DFGFlushLivenessAnalysisPhase.cpp: Added.
(DFG):
(FlushLivenessAnalysisPhase):
(JSC::DFG::FlushLivenessAnalysisPhase::FlushLivenessAnalysisPhase):
(JSC::DFG::FlushLivenessAnalysisPhase::run):
(JSC::DFG::FlushLivenessAnalysisPhase::process):
(JSC::DFG::FlushLivenessAnalysisPhase::setForNode):
(JSC::DFG::FlushLivenessAnalysisPhase::flushFormat):
(JSC::DFG::performFlushLivenessAnalysis):
- dfg/DFGFlushLivenessAnalysisPhase.h: Added.
(DFG):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
(DFG):
(JSC::DFG::Graph::addForDepthFirstSort):
(JSC::DFG::Graph::getBlocksInDepthFirstOrder):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::convertToConstant):
(JSC::DFG::Graph::valueProfileFor):
(Graph):
- dfg/DFGInsertionSet.h:
(DFG):
(JSC::DFG::InsertionSet::execute):
- dfg/DFGLivenessAnalysisPhase.cpp: Added.
(DFG):
(LivenessAnalysisPhase):
(JSC::DFG::LivenessAnalysisPhase::LivenessAnalysisPhase):
(JSC::DFG::LivenessAnalysisPhase::run):
(JSC::DFG::LivenessAnalysisPhase::process):
(JSC::DFG::LivenessAnalysisPhase::addChildUse):
(JSC::DFG::performLivenessAnalysis):
- dfg/DFGLivenessAnalysisPhase.h: Added.
(DFG):
- dfg/DFGNode.cpp:
(JSC::DFG::Node::hasVariableAccessData):
(DFG):
- dfg/DFGNode.h:
(DFG):
(Node):
(JSC::DFG::Node::hasLocal):
(JSC::DFG::Node::variableAccessData):
(JSC::DFG::Node::hasPhi):
(JSC::DFG::Node::phi):
(JSC::DFG::Node::takenBlock):
(JSC::DFG::Node::notTakenBlock):
(JSC::DFG::Node::successor):
(JSC::DFG::Node::successorForCondition):
(JSC::DFG::nodeComparator):
(JSC::DFG::nodeListDump):
(JSC::DFG::nodeMapDump):
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::dumpNodeFlags):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOSRAvailabilityAnalysisPhase.cpp: Added.
(DFG):
(OSRAvailabilityAnalysisPhase):
(JSC::DFG::OSRAvailabilityAnalysisPhase::OSRAvailabilityAnalysisPhase):
(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
(JSC::DFG::performOSRAvailabilityAnalysis):
- dfg/DFGOSRAvailabilityAnalysisPhase.h: Added.
(DFG):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPredictionInjectionPhase.cpp:
(JSC::DFG::PredictionInjectionPhase::run):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSSAConversionPhase.cpp: Added.
(DFG):
(SSAConversionPhase):
(JSC::DFG::SSAConversionPhase::SSAConversionPhase):
(JSC::DFG::SSAConversionPhase::run):
(JSC::DFG::SSAConversionPhase::forwardPhiChildren):
(JSC::DFG::SSAConversionPhase::forwardPhi):
(JSC::DFG::SSAConversionPhase::forwardPhiEdge):
(JSC::DFG::SSAConversionPhase::deduplicateChildren):
(JSC::DFG::SSAConversionPhase::addFlushedLocalOp):
(JSC::DFG::SSAConversionPhase::addFlushedLocalEdge):
(JSC::DFG::performSSAConversion):
- dfg/DFGSSAConversionPhase.h: Added.
(DFG):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
(Validate):
(JSC::DFG::Validate::validateCPS):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::flushFormat):
(VariableAccessData):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::createPhiVariables):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileUpsilon):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compilePhi):
(JSC::FTL::LowerDFGToLLVM::compileJSConstant):
(JSC::FTL::LowerDFGToLLVM::compileWeakJSConstant):
(JSC::FTL::LowerDFGToLLVM::compileGetArgument):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithDiv):
(JSC::FTL::LowerDFGToLLVM::compileArithMod):
(JSC::FTL::LowerDFGToLLVM::compileArithMinOrMax):
(JSC::FTL::LowerDFGToLLVM::compileArithAbs):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compileBitAnd):
(JSC::FTL::LowerDFGToLLVM::compileBitOr):
(JSC::FTL::LowerDFGToLLVM::compileBitXor):
(JSC::FTL::LowerDFGToLLVM::compileBitRShift):
(JSC::FTL::LowerDFGToLLVM::compileBitLShift):
(JSC::FTL::LowerDFGToLLVM::compileBitURShift):
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):
(JSC::FTL::LowerDFGToLLVM::compileInt32ToDouble):
(JSC::FTL::LowerDFGToLLVM::compileGetButterfly):
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compileGetGlobalVar):
(JSC::FTL::LowerDFGToLLVM::compileCompareEqConstant):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEqConstant):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(JSC::FTL::LowerDFGToLLVM::compileCompareLessEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreater):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreaterEq):
(JSC::FTL::LowerDFGToLLVM::compileLogicalNot):
(JSC::FTL::LowerDFGToLLVM::speculateBackward):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowDouble):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::lowStorage):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateBoolean):
(JSC::FTL::LowerDFGToLLVM::isLive):
(JSC::FTL::LowerDFGToLLVM::use):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::linkOSRExitsAndCompleteInitializationBlocks):
(JSC::FTL::LowerDFGToLLVM::setInt32):
(JSC::FTL::LowerDFGToLLVM::setJSValue):
(JSC::FTL::LowerDFGToLLVM::setBoolean):
(JSC::FTL::LowerDFGToLLVM::setStorage):
(JSC::FTL::LowerDFGToLLVM::setDouble):
(JSC::FTL::LowerDFGToLLVM::isValid):
- ftl/FTLLoweredNodeValue.h: Added.
(FTL):
(LoweredNodeValue):
(JSC::FTL::LoweredNodeValue::LoweredNodeValue):
(JSC::FTL::LoweredNodeValue::isSet):
(JSC::FTL::LoweredNodeValue::operator!):
(JSC::FTL::LoweredNodeValue::value):
(JSC::FTL::LoweredNodeValue::block):
- ftl/FTLValueFromBlock.h:
(JSC::FTL::ValueFromBlock::ValueFromBlock):
(ValueFromBlock):
- ftl/FTLValueSource.cpp:
(JSC::FTL::ValueSource::dump):
- ftl/FTLValueSource.h:
Source/WTF:
Reviewed by Mark Hahnenberg.
- Extend variadicity of PrintStream and dataLog.
- Give HashSet the ability to add a span of things.
- Give HashSet the ability to == another HashSet.
- Note FIXME's in HashTable concerning copying performance, that affects the way that the DFG now uses HashSets and HashMaps.
- Factor out the bulk-insertion logic of JSC::DFG::InsertionSet into WTF::Insertion, so that it can be used in more places.
- Create a dumper for lists and maps.
- WTF.xcodeproj/project.pbxproj:
- wtf/DataLog.h:
(WTF):
(WTF::dataLog):
- wtf/HashSet.h:
(HashSet):
(WTF):
(WTF::::add):
(WTF::=):
- wtf/HashTable.h:
(WTF::::HashTable):
(WTF::=):
- wtf/Insertion.h: Added.
(WTF):
(Insertion):
(WTF::Insertion::Insertion):
(WTF::Insertion::index):
(WTF::Insertion::element):
(WTF::Insertion::operator<):
(WTF::executeInsertions):
- wtf/ListDump.h: Added.
(WTF):
(ListDump):
(WTF::ListDump::ListDump):
(WTF::ListDump::dump):
(MapDump):
(WTF::MapDump::MapDump):
(WTF::MapDump::dump):
(WTF::listDump):
(WTF::sortedListDump):
(WTF::lessThan):
(WTF::mapDump):
(WTF::sortedMapDump):
- wtf/PrintStream.h:
(PrintStream):
(WTF::PrintStream::print):
- 6:29 PM Changeset in webkit [152691] by
-
- 2 edits in trunk/Tools
Update James Craig's email address.
- Scripts/webkitpy/common/config/contributors.json:
- 6:21 PM Changeset in webkit [152690] by
-
- 3 edits3 copies in branches/safari-537-branch
Merged r152653. <rdar://problem/14442444>
- 6:19 PM Changeset in webkit [152689] by
-
- 2 edits in trunk/Source/WebCore
Pack WebCore::Font slightly better.
<http://webkit.org/b/118681>
<rdar://problem/14446014>
Reviewed by Sam Weinig.
Knock 8 bytes off of Font by packing the members better. Reduces memory consumption by 429 kB when
viewing the full HTML5 spec at <http://whatwg.org/c>
- platform/graphics/Font.h:
(WebCore::Font::typesettingFeatures):
- 6:19 PM Changeset in webkit [152688] by
-
- 2 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r152652. <rdar://problem/14413607>
- 6:17 PM Changeset in webkit [152687] by
-
- 2 edits in branches/safari-537-branch/Source
Rollout of r152686. Previously merged.
- 6:14 PM Changeset in webkit [152686] by
-
- 2 edits in branches/safari-537-branch/Source
Merged r152382. <rdar://problem/14252733>
- 5:37 PM Changeset in webkit [152685] by
-
- 14 edits2 adds in trunk
XMLSerializer doesn't include namespaces on nodes in HTML documents
https://bugs.webkit.org/show_bug.cgi?id=16496
Patch by Rob Buis <rwlbuis@webkit.org> on 2013-07-15
Reviewed by Ryosuke Niwa.
Source/WebCore:
Introduce a xml fragment serialization mode as indicated by
http://html5.org/specs/dom-parsing.html#xmlserializer (commit 00b84d2). In this mode
the XML fragment serialization algorithm is respected, the changes in this patch do the following:
- elements are self-closing if otherwise this would lead to invalid xml syntax.
- the resulting xml is XML namespace-well-formed (http://www.w3.org/TR/xml-names11/#Conformance).
This is achieved by always, when in xml fragment serialization mode, attempting to write out the element/attribute namespace,
preventing using the XML namespace as a default namespace and special casing the use of element's in XML namespace by using the xml prefix.
The chosen approach matches FireFox 25 behavior.
Test: fast/dom/dom-serialize-namespace.html
- WebCore.order: Adapt to changed createMarkup signature.
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::MarkupAccumulator):
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces): makes sure xml namespace/prefix is known so it is never used in namespace declarations.
(WebCore::MarkupAccumulator::appendNamespace): Avoid adding namespace declarations that do not differ from current default namespace.
(WebCore::MarkupAccumulator::appendOpenTag): Print xml prefix if the element's namespace is XML to avoid conflicts.
(WebCore::MarkupAccumulator::appendAttribute):
(WebCore::MarkupAccumulator::shouldAddNamespaceAttribute): Also take into account xmlns attributes with no namespace.
(WebCore::MarkupAccumulator::shouldSelfClose): Force self-closing to create well-formed XML elements.
- editing/MarkupAccumulator.h: Use EFragmentSerialization.
(WebCore::MarkupAccumulator::inXMLFragmentSerialization):
- editing/markup.cpp:
(WebCore::createMarkup):
- editing/markup.h: Add EFragmentSerialization enum.
- xml/XMLSerializer.cpp:
(WebCore::XMLSerializer::serializeToString):
LayoutTests:
The updated tests are progressions and match FF.
- fast/dom/Element/getAttribute-check-case-sensitivity-expected.txt:
- fast/dom/Element/script-tests/getAttribute-check-case-sensitivity.js:
- fast/dom/XMLSerializer-xml-namespace-expected.txt:
- fast/dom/dom-serialize-namespace-expected.txt: Added.
- fast/dom/dom-serialize-namespace.html: Added.
- fast/xsl/xslt-processor-expected.txt:
- inspector/elements/set-outer-html-expected.txt:
- svg/custom/xlink-prefix-in-attributes-expected.txt:
- 5:32 PM Changeset in webkit [152684] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove unused columns from select query in ImageUtilities.js
https://bugs.webkit.org/show_bug.cgi?id=118694
Patch by Seokju Kwon <Seokju Kwon> on 2013-07-15
Reviewed by Timothy Hatcher.
- UserInterface/ImageUtilities.js: Remove pixelRatio and formatVersion from select query.
- 5:22 PM Changeset in webkit [152683] by
-
- 7 edits2 copies in branches/safari-537-branch
Merged r152642. <rdar://problem/14293352>
- 5:18 PM Changeset in webkit [152682] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152623. <rdar://problem/14437753>
- 5:15 PM Changeset in webkit [152681] by
-
- 12 edits in branches/safari-537-branch/Source
Merged r152613. <rdar://problem/14408012>
- 5:08 PM Changeset in webkit [152680] by
-
- 2 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r152588. <rdar://problem/14425513>
- 5:04 PM Changeset in webkit [152679] by
-
- 8 edits2 copies in branches/safari-537-branch
Merged r152580. <rdar://problem/14324391>
- 5:00 PM Changeset in webkit [152678] by
-
- 3 edits in branches/safari-537-branch/Source/JavaScriptCore
Merged r152577. <rdar://problem/13927795>
- 4:54 PM Changeset in webkit [152677] by
-
- 8 edits in branches/safari-537-branch
Merged r152573. <rdar://problem/13927795>
- 4:47 PM Changeset in webkit [152676] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152568. <rdar://problem/14421170>
- 4:47 PM Changeset in webkit [152675] by
-
- 2 edits in trunk/Tools
[EFL] Add fallback for TestWebKitAPI if opengl is not available.
https://bugs.webkit.org/show_bug.cgi?id=118583
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-15
Reviewed by Christophe Dumez.
There're many fails on efl webkit2 API test if opengl is not available.
So, add fallback to non-opengl evas engine.
- TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::initEcoreEvas):
- 4:44 PM Changeset in webkit [152674] by
-
- 3 edits2 copies in branches/safari-537-branch
Merged r152554. <rdar://problem/14305675>
- 4:42 PM Changeset in webkit [152673] by
-
- 2 edits in trunk/Source/WebCore
MediaFragmentURIParser::parseFragments shouldn't upconvert 8-bit string
https://bugs.webkit.org/show_bug.cgi?id=118692
Reviewed by Michael Saboff.
Merge https://chromium.googlesource.com/chromium/blink/+/2aa17cc56a807f7e05d386d6eb66cda25e6b0542.
- html/MediaFragmentURIParser.cpp:
(WebCore::MediaFragmentURIParser::parseFragments):
- 4:41 PM Changeset in webkit [152672] by
-
- 5 edits in trunk/Source
NetworkStorageSession::createDefaultSession is only implemented by Soup
https://bugs.webkit.org/show_bug.cgi?id=118679
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Remove NetworkStorageSession::createDefaultSession() because
NetworkStorageSession::defaultStorageSession() returns the default
session.
No new tests, no behavior change.
- platform/network/NetworkStorageSession.h:
- platform/network/soup/NetworkStorageSessionSoup.cpp:
Source/WebKit/efl:
Replace NetworkStorageSession::createDefaultSession() with
NetworkStorageSession::defaultStorageSession().
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(EWKPrivate::storageSession):
- 4:34 PM Changeset in webkit [152671] by
-
- 9 edits2 copies in branches/safari-537-branch
Merged r152547. <rdar://problem/13832062>
- 4:31 PM Changeset in webkit [152670] by
-
- 7 edits in branches/safari-537-branch
Merged r152532. <rdar://problem/14212242>
- 4:31 PM Changeset in webkit [152669] by
-
- 19 edits in trunk/Source/WebInspectorUI
Update CodeMirror to 3.14.1.
https://bugs.webkit.org/show_bug.cgi?id=118605
Reviewed by Joseph Pecoraro.
- Scripts/update-codemirror-resources.rb: Updated the list to add closebrackets.js and sorted the files.
- Tools/PrettyPrinting/CodeMirrorFormatters.js:
- Tools/PrettyPrinting/Formatter.js:
- Tools/PrettyPrinting/FormatterContentBuilder.js:
- Tools/PrettyPrinting/codemirror.css:
- Tools/PrettyPrinting/codemirror.js:
- Tools/PrettyPrinting/css.js:
- Tools/PrettyPrinting/javascript.js:
- UserInterface/External/CodeMirror/closebrackets.js:
- UserInterface/External/CodeMirror/codemirror.css:
- UserInterface/External/CodeMirror/codemirror.js:
- UserInterface/External/CodeMirror/coffeescript.js:
- UserInterface/External/CodeMirror/comment.js:
- UserInterface/External/CodeMirror/css.js:
- UserInterface/External/CodeMirror/javascript.js:
- UserInterface/External/CodeMirror/matchbrackets.js:
- UserInterface/External/CodeMirror/sql.js:
- UserInterface/External/CodeMirror/xml.js:
- 4:28 PM Changeset in webkit [152668] by
-
- 5 edits in trunk
compositionstart event should contain the text to be replaced
https://bugs.webkit.org/show_bug.cgi?id=118684
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/9e04f728a95ad7d4783b1d31c3cdc1412dd6cc4d.
DOM3 level 3 specifies compositionstart event's data to be the text to be replaced.
http://www.w3.org/TR/DOM-Level-3-Events/#event-type-compositionstart
According to the author of the Blink change, IE10 on Windows and Firefox22 on Linux confirms
to the specified behavior.
Test: fast/events/ime-composition-events-001.html
- editing/Editor.cpp:
(WebCore::Editor::setComposition):
LayoutTests:
Add a test case.
- fast/events/ime-composition-events-001-expected.txt:
- fast/events/ime-composition-events-001.html:
- 4:27 PM Changeset in webkit [152667] by
-
- 2 edits in trunk/Source/WebCore
xmlDocPtrForString shouldn't upconvert 8-bit string
https://bugs.webkit.org/show_bug.cgi?id=118693
Reviewed by Michael Saboff.
Merge https://chromium.googlesource.com/chromium/blink/+/5d9b240db74591c3689415c7b7c5180fadb379e9
Prior to this changeset, we were upconverting the entire XML document.
Let xmllib2 parse a document as iso-8859-1 when it's a 8-bit string.
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::nativeEndianUTF16Encoding):
(WebCore::xmlDocPtrForString):
- 4:23 PM Changeset in webkit [152666] by
-
- 5 edits in branches/safari-537-branch
Merged r152522. <rdar://problem/14376358>
- 4:10 PM Changeset in webkit [152665] by
-
- 16 edits in branches/safari-537-branch/Source
Merged r152520. <rdar://problem/9504664>
- 4:08 PM Changeset in webkit [152664] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152459. <rdar://problem/14211041>
- 4:04 PM Changeset in webkit [152663] by
-
- 5 edits2 copies in branches/safari-537-branch
Merged r152388. <rdar://problem/14207940>
- 4:01 PM Changeset in webkit [152662] by
-
- 2 edits in branches/safari-537-branch/Tools
Merged r152366. <rdar://problem/14281956>
- 3:58 PM Changeset in webkit [152661] by
-
- 3 edits in branches/safari-537-branch/Source/WebCore
Merged r152345. <rdar://problem/14324895>
- 3:50 PM Changeset in webkit [152660] by
-
- 3 edits2 copies in branches/safari-537-branch
Merged r152330. <rdar://problem/14297760>
- 3:42 PM Changeset in webkit [152659] by
-
- 22 edits in branches/safari-537-branch
Merged r152320. <rdar://problem/14324895>
- 3:20 PM Changeset in webkit [152658] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152316. <rdar://problem/13917901>
- 3:18 PM Changeset in webkit [152657] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152249. <rdar://problem/13917901>
- 3:15 PM Changeset in webkit [152656] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r151845. <rdar://problem/14211041>
- 1:46 PM Changeset in webkit [152655] by
-
- 2 edits in trunk/Source/WebCore
Replace WKCACFTypes include with d3d9 include.
Rubberstamped by Eric Carlson.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
- 1:44 PM Changeset in webkit [152654] by
-
- 11 deletes in trunk/WebKitLibraries/win/tools/vsprops
Unreviewed. Remove unused vsprops files.
- win/tools/vsprops/FeatureDefines.vsprops: Removed.
- win/tools/vsprops/FeatureDefinesCairo.vsprops: Removed.
- win/tools/vsprops/WinCairo.vsprops: Removed.
- win/tools/vsprops/cURL.vsprops: Removed.
- win/tools/vsprops/common.vsprops: Removed.
- win/tools/vsprops/debug.vsprops: Removed.
- win/tools/vsprops/debug_all.vsprops: Removed.
- win/tools/vsprops/debug_wincairo.vsprops: Removed.
- win/tools/vsprops/production.vsprops: Removed.
- win/tools/vsprops/release.vsprops: Removed.
- win/tools/vsprops/releaseproduction.vsprops: Removed.
- 1:07 PM Changeset in webkit [152653] by
-
- 3 edits3 adds in trunk
Text with "text-overflow:ellipsis" and an SVG font do not render correctly
https://bugs.webkit.org/show_bug.cgi?id=118669
Patch by Antoine Quint <Antoine Quint> on 2013-07-15
Reviewed by David Kilzer.
Source/WebCore:
Partial runs may be routed through the complex path in several Font functions. While incomplete,
we can check for a non-NULL run.renderingContext() and exempt runs that have it from being forced
down the complex path. A more thorough fix is already tracked by http://webkit.org/b/100050.
Adding a new testcase which is a copy of svg/text/text-overflow-ellipsis-svgfont.html with kerning
and ligatures turned on explicitly since DRT runs with those off by default and this option is required
to be on for the issue to reproduce.
Fix courtesy of Dan Bernstein.
Test: svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html
- platform/graphics/Font.cpp:
(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::selectionRectForText):
LayoutTests:
- platform/mac/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.png: Added.
- platform/mac/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.txt: Added.
- svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html: Added.
- 12:46 PM Changeset in webkit [152652] by
-
- 2 edits in trunk/Source/WebInspectorUI
Make sure to add main resources for sub-frames to the Network Timeline.
https://bugs.webkit.org/show_bug.cgi?id=118649
Reviewed by Joseph Pecoraro.
- UserInterface/TimelineManager.js:
(WebInspector.TimelineManager.prototype._mainResourceDidChange): Remove the
call to _clear() and early return for event.target.isMainFrame(). The _clear()
is already handled if needed by the call to _startAutoRecording(), so it was
redundant here and caused the erroneous addition of isMainFrame() early return.
- 11:53 AM Changeset in webkit [152651] by
-
- 2 edits in trunk/Source/WebInspectorUI
Properly handle style text changes while the color popover is open.
https://bugs.webkit.org/show_bug.cgi?id=118575
Reviewed by Joseph Pecoraro.
- UserInterface/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._colorSwatchClicked.updateCodeMirror):
The original text marker might have been cleared by a style update, in this case we need to
find the new color text marker so we know the right range for the new style color text.
- 11:48 AM Changeset in webkit [152650] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Unreviewed, fix a mismerge from r152303.
- platform/mac/TestExpectations:
- 11:22 AM Changeset in webkit [152649] by
-
- 2 edits in trunk/Source/WebCore
[Curl] Download does not replace existing file.
https://bugs.webkit.org/show_bug.cgi?id=118356
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-15
Reviewed by Brent Fulgham.
If the download target file already exists, it is not replaced after the download has finished.
At this point, the user would have already approved to replace the file, so it should be replaced.
- platform/network/curl/CurlDownload.cpp:
(CurlDownload::moveFileToDestination): Move file and replace it if it already exists.
If the new file is on a different volume, do a copy/delete operation.
- 10:53 AM Changeset in webkit [152648] by
-
- 3 edits in releases/WebKitGTK/webkit-2.0
Merge r152412 - [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
https://bugs.webkit.org/show_bug.cgi?id=111434
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-07-05
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
- UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(testNotInitialized):
(testSetDirectory):
(testClearDatabase):
(testGetFavicon):
(testGetFaviconURI): Removed gconstpointer parameter.
(testWebViewFavicon): Fixed to make it work together with the
other tests and removed gconstpointer parameter.
(testFaviconDatabase): Created to call all tests in the proper
order.
(beforeAll): Changed to call only testFaviconDatabase instead of
the separate tests.
- 10:50 AM Changeset in webkit [152647] by
-
- 2 edits in trunk/Source/WebCore
[CoordinatedGraphics] Crash at CoordinatedGraphicsScene::updateImageBacking
https://bugs.webkit.org/show_bug.cgi?id=118613
The operations of creating/removing/updating/clearing weren't in the
right sequence. Changing the order solves the issue because when an image is
replaced the old one is deleted before the new one is created, and IDs are
not unique in cairo (they're based on the image pointer).
Reviewed by Noam Rosenthal.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::syncImageBackings):
- 10:42 AM Changeset in webkit [152646] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r152627 - [GTK] [WK2] Check if the keyEventQueue is empty in WebPageProxy::getEditorCommandsForKeyEvent
https://bugs.webkit.org/show_bug.cgi?id=118530
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.
When a key event is started in the WebProcess (e.g. in the inspector)
it doesn't have an associated GdkEvent queued. Adding a check in
WebPageProxy::getEditorCommandsForKeyEvent ensures there's always a queued
key event to process.
In GTK-WK2, inspector-protocol/input/dispatchKeyEvent.html no longer crashes once
this fix is in place.
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::getEditorCommandsForKeyEvent): Ensure m_keyEventQueue is
not empty.
- 10:38 AM Changeset in webkit [152645] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r152631 - [ATK] Leak: Leak in WebKitAccessibleTextGetText
https://bugs.webkit.org/show_bug.cgi?id=118596
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.
Fixed memory leak.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getGailTextUtilForAtk):
- 10:34 AM Changeset in webkit [152644] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r152398 - [GTK] Leak: Free PangoFontDescription* in RenderThemeGtk3
https://bugs.webkit.org/show_bug.cgi?id=118386
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-04
Reviewed by Carlos Garcia Campos.
Free PangoFontDescription* allocated by gtk_style_context_get (transfer full).
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::spinButtonArrowSize):
- 10:22 AM Changeset in webkit [152643] by
-
- 9 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r144636 - [GTK] WebCore::returnString is unsafe and should be removed!
https://bugs.webkit.org/show_bug.cgi?id=110423
Reviewed by Martin Robinson.
Remove returnString() and replace it in callers with a new
function that will cache and return the values of string
properties for ATK interfaces in the private section of the
wrapper AtkObject WebKitAccessible.
- accessibility/atk/WebKitAccessibleUtil.cpp: Remove returnString().
- accessibility/atk/WebKitAccessibleUtil.h: Ditto.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(_WebKitAccessiblePrivate): New private structure to store cached
values of string property for the different ATK interfaces.
(cacheAndReturnAtkProperty): New helper function to make sure the
returned const gchar* value is previously cached in the private
section of the wrapper AtkObject.
(webkitAccessibleGetName): Use the new helper function.
(webkitAccessibleGetDescription): Ditto.
(webkitAccessibleInit): Initialize pointer to private structure.
(webkitAccessibleFinalize): Remove unneeded code.
(webkitAccessibleClassInit): Add private struct to class type/
- accessibility/atk/WebKitAccessibleWrapperAtk.h:
(_WebKitAccessible): New member pointing to the private structure,
made the new helper function cacheAndReturnAtkProperty() available
to external callers (implementation files for ATK interfaces).
(AtkCachedProperty): New enum to allow reusing code when calling
cacheAndReturnAtkProperty() to cache and return different properties.
- accessibility/atk/WebKitAccessibleInterfaceAction.cpp:
(webkitAccessibleActionGetKeybinding): Replace calls to returnString()
with calls to the new helper function cacheAndReturnAtkProperty().
(webkitAccessibleActionGetName): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:
(documentAttributeValue): Ditto.
(webkitAccessibleDocumentGetLocale): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceImage.cpp:
(webkitAccessibleImageGetImageDescription): Ditto.
Remove returnString() from WebKitAccessibleHyperlink (which is not
an AtkObject, but a GObject) as well, replacing it in callers with
simple code that will cache and return the required values in the
private section of these kind of objects.
- accessibility/atk/WebKitAccessibleHyperlink.cpp:
(_WebKitAccessibleHyperlinkPrivate): Added two new fields to cache
string values for the key binding and name properties from the
AtkAction interface, which is implemented by AtkHyperlink.
(webkitAccessibleHyperlinkActionGetKeybinding): Cache the string
value for the key binding before returning a const gchar* pointer.
(webkitAccessibleHyperlinkActionGetName): Ditto.
(webkitAccessibleHyperlinkGetURI): Do not cache the URI here, as
this function returns a gchar* that will be owned by the caller.
- 10:16 AM Changeset in webkit [152642] by
-
- 7 edits2 adds in trunk
Source/WebKit/mac: [WK2] Calling Notification.requestPermission() without a callback crashes
https://bugs.webkit.org/show_bug.cgi?id=118654
<rdar://problem/14293352>
Reviewed by Alexey Proskuryakov.
- WebCoreSupport/WebNotificationClient.mm:
(-[WebNotificationPolicyListener initWithCallback:]): The callback can be NULL, so remove the ASSERT.
(-[WebNotificationPolicyListener allow]): Check for the callback before asking it to handle the event.
(-[WebNotificationPolicyListener deny]): Ditto.
Source/WebKit2: Calling Notification.requestPermission() without a callback crashes
https://bugs.webkit.org/show_bug.cgi?id=118654
<rdar://problem/14293352>
Reviewed by Alexey Proskuryakov.
When requestPermission() is called, we short-circuit if we know the permission was already set.
The callback handler gets invoked. But now that callbacks are optional, we need to check to make
sure a callback was provided.
- WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::startRequest): Check for the callback.
LayoutTests: [WK2] Calling Notification.requestPermission() without a callback crashes
https://bugs.webkit.org/show_bug.cgi?id=118654
<rdar://problem/14293352>
Reviewed by Alexey Proskuryakov.
- http/tests/notifications/notification-request-permission-expected.txt:
- http/tests/notifications/notification-request-permission.html: Add additional subtests that check
that the call succeeds even after granting or denying permission.
- http/tests/notifications/notification-request-permission-no-callback-expected.txt: Added.
- http/tests/notifications/notification-request-permission-no-callback.html: Added. Similar test to
notification-request-permission, without the callback function.
- 9:55 AM Changeset in webkit [152641] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Tools
Merge r152298 - [ATK] Leak: leaks in AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118297
Fixed memory leak.
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-02
Reviewed by Christophe Dumez.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::stringValue):
- 9:50 AM Changeset in webkit [152640] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r152232 - [ATK] Leak: leaks in WebKitAccessibleInterfaceText
https://bugs.webkit.org/show_bug.cgi?id=118248
Fixed memory leaks.
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-01
Reviewed by Christophe Dumez.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getPangoLayoutForAtk):
(webkitAccessibleTextGetText):
- 9:43 AM WebKitGTK/2.0.x edited by
- (diff)
- 9:32 AM Changeset in webkit [152639] by
-
- 3 edits1 add in trunk/Tools
check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
https://bugs.webkit.org/show_bug.cgi?id=118592
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-15
Reviewed by Martin Robinson.
Added a suppression for pylint false positives and a unit test.
- Scripts/webkitpy/style/checkers/python.py:
(Pylinter):
- Scripts/webkitpy/style/checkers/python_unittest.py:
(PythonCheckerTest.test_check):
(PythonCheckerTest):
(PythonCheckerTest.test_pylint_false_positives):
(PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
- Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
(test_popen):
- 9:29 AM WebKitGTK/2.0.x edited by
- (diff)
- 9:28 AM Changeset in webkit [152638] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk
Merge r152483 - [GTK] webkit_set_cache_model is not turning the cache off
https://bugs.webkit.org/show_bug.cgi?id=118345
Reviewed by Gustavo Noronha Silva.
Our documentation says that WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER
disables the cache completely, but we are only setting the cache
capacities to 0. Cache capacities are not checked when resources
are added to the cache, but when it's pruned. To disable the cache
we need to call MemoryCache::setDisabled explicitly.
- webkit/webkitglobals.cpp:
(webkit_set_cache_model): Disable the cache when min dead, max
dead and total capacities are all set to 0.
- 9:25 AM WebKitGTK/2.0.x edited by
- (diff)
- 9:24 AM Changeset in webkit [152637] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r152626 - [WK2][GTK] SIGSEV in webkitWebViewBaseSizeAllocate
https://bugs.webkit.org/show_bug.cgi?id=118052
Patch by Alberto Garcia <berto@igalia.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.
We don't need to check whether the drawing area is empty or not in
order to set needsResizeOnMap.
It can also happen that the drawing area pointer is null (if
e.g. the web process crashes), which is the reason for this
SIGSEGV.
A test to prevent this was added in r88646 but was later moved to
resizeWebKitWebViewBaseFromAllocation().
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseSizeAllocate):
- 9:21 AM Changeset in webkit [152636] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r152367 - [GTK][WK2] SIGSEV in WebKit::WebPageContextMenuClient::customContextMenuItemSelected
https://bugs.webkit.org/show_bug.cgi?id=116867
Reviewed by Anders Carlsson.
We did not reset the clients on WebPageProxy::close(), so right
clicking on a link after starting the navigation to some other
page was causing crashes because code was trying to access an
already freed m_contextMenuClient.
There were some other clients that could potentially trigger the
same issues. Reset them all to null to prevent this situation.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
- 9:20 AM WebKitGTK/2.0.x edited by
- (diff)
- 9:15 AM WebKitGTK/2.0.x edited by
- (diff)
- 9:06 AM Changeset in webkit [152635] by
-
- 3 edits1 delete in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r148440 - [GTK] Remove platform specific implementation of KURL::fileSystemPath()
https://bugs.webkit.org/show_bug.cgi?id=114133
Reviewed by Martin Robinson.
r147883 added a generic implementation of this function,
which can be used by all ports to share the code.
- GNUmakefile.list.am:
- platform/KURL.cpp:
(WebCore):
- platform/gtk/KURLGtk.cpp: Removed.
- 8:59 AM Changeset in webkit [152634] by
-
- 5 edits4 deletes in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r147883 - Add default implementation for KURL::fileSystemPath()
https://bugs.webkit.org/show_bug.cgi?id=108326
Reviewed by Benjamin Poulain.
The code for KURL::fileSystemPath() has been duplicated in different ports.
Add an implementation of this function to KURL.cpp for this ports and
get rid of the very similar port specific implementation files.
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformWinCE.cmake:
- platform/KURL.cpp:
(WebCore):
(WebCore::KURL::fileSystemPath):
- platform/blackberry/KURLBlackBerry.cpp: Removed.
- platform/efl/KURLEfl.cpp: Removed.
- platform/wince/KURLWinCE.cpp: Removed.
- platform/wx/KURLWx.cpp: Removed.
- 8:36 AM Changeset in webkit [152633] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Remote inspector server should send an error page if resources not found
https://bugs.webkit.org/show_bug.cgi?id=117137
Patch by Anton Obzhirov <Anton Obzhirov> on 2013-07-15
Reviewed by Gustavo Noronha Silva.
Sometimes it is difficult to understand why remote inspector fails to deliver the content.
This patch gives an option to show error page with some basic explanation.
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::platformResourceForPath):
- 7:47 AM Changeset in webkit [152632] by
-
- 5 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed cleanup for pixel tester bot.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0-wk2/editing/deleting/delete-image-002-expected.png:
- platform/qt-5.0-wk2/editing/selection/move-by-character-004-expected.png:
- platform/qt-5.0-wk2/fast/canvas/setWidthResetAfterForcedRender-expected.png:
- 6:24 AM Changeset in webkit [152631] by
-
- 2 edits in trunk/Source/WebCore
[ATK] Leak: Leak in WebKitAccessibleTextGetText
https://bugs.webkit.org/show_bug.cgi?id=118596
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.
Fixed memory leak.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getGailTextUtilForAtk):
- 5:02 AM Changeset in webkit [152630] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening. Skipping bad pixel results.
- platform/qt-5.0-wk2/TestExpectations:
- 3:01 AM Changeset in webkit [152629] by
-
- 2 edits in trunk/Tools
[GTK] Increase the JHBuild version of GStreamer to 1.0.7
https://bugs.webkit.org/show_bug.cgi?id=115166
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-07-15
Reviewed by Philippe Normand.
- gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
- 2:44 AM Changeset in webkit [152628] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening. Skipping bad pixel results.
- platform/qt-5.0-wk2/TestExpectations:
- 2:28 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:49 AM Changeset in webkit [152627] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] [WK2] Check if the keyEventQueue is empty in WebPageProxy::getEditorCommandsForKeyEvent
https://bugs.webkit.org/show_bug.cgi?id=118530
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.
When a key event is started in the WebProcess (e.g. in the inspector)
it doesn't have an associated GdkEvent queued. Adding a check in
WebPageProxy::getEditorCommandsForKeyEvent ensures there's always a queued
key event to process.
In GTK-WK2, inspector-protocol/input/dispatchKeyEvent.html no longer crashes once
this fix is in place.
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::getEditorCommandsForKeyEvent): Ensure m_keyEventQueue is
not empty.
- 1:14 AM Changeset in webkit [152626] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][GTK] SIGSEV in webkitWebViewBaseSizeAllocate
https://bugs.webkit.org/show_bug.cgi?id=118052
Patch by Alberto Garcia <berto@igalia.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.
We don't need to check whether the drawing area is empty or not in
order to set needsResizeOnMap.
It can also happen that the drawing area pointer is null (if
e.g. the web process crashes), which is the reason for this
SIGSEGV.
A test to prevent this was added in r88646 but was later moved to
resizeWebKitWebViewBaseFromAllocation().
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseSizeAllocate):
- 1:08 AM Changeset in webkit [152625] by
-
- 2 edits in trunk/Source/WTF
Minor cleaning of AtomicString::addSlowCase
https://bugs.webkit.org/show_bug.cgi?id=118615
Reviewed by Geoffrey Garen.
Give the variable a proper name.
Add assertions to clarify the in and out states.
- wtf/text/AtomicString.cpp:
(WTF::AtomicString::addSlowCase):
Jul 14, 2013:
- 11:41 PM Changeset in webkit [152624] by
-
- 17 edits in trunk/Source/WebInspectorUI
Unreviewed, rolling out r152598.
http://trac.webkit.org/changeset/152598
https://bugs.webkit.org/show_bug.cgi?id=118658
totally broke the web inspector (JS ERROR: SyntaxError:
Expected token '}') (Requested by thorton on #webkit).
- Tools/PrettyPrinting/CodeMirrorFormatters.js:
- Tools/PrettyPrinting/Formatter.js:
- Tools/PrettyPrinting/FormatterContentBuilder.js:
- Tools/PrettyPrinting/codemirror.css:
(.CodeMirror-scrollbar-filler):
(.CodeMirror-gutters):
(.CodeMirror-vscrollbar, .CodeMirror-hscrollbar, .CodeMirror-scrollbar-filler):
(.CodeMirror-widget):
- Tools/PrettyPrinting/codemirror.js:
(window.CodeMirror):
(window.CodeMirror.):
(.do):
(moveVisually):
- Tools/PrettyPrinting/css.js:
(.):
(CodeMirror):
- Tools/PrettyPrinting/javascript.js:
(.):
- UserInterface/External/CodeMirror/codemirror.css:
(.CodeMirror-widget):
- UserInterface/External/CodeMirror/codemirror.js:
(window.CodeMirror):
(window.CodeMirror.):
- UserInterface/External/CodeMirror/coffeescript.js:
- UserInterface/External/CodeMirror/comment.js:
(.):
- UserInterface/External/CodeMirror/css.js:
(.):
(CodeMirror):
- UserInterface/External/CodeMirror/javascript.js:
(.):
- UserInterface/External/CodeMirror/matchbrackets.js:
(.):
- UserInterface/External/CodeMirror/sql.js:
- UserInterface/External/CodeMirror/xml.js:
- 11:11 PM Changeset in webkit [152623] by
-
- 2 edits in trunk/Source/WebCore
Origins with invalid ports are not marked as unique (118652)
https://bugs.webkit.org/show_bug.cgi?id=118652
<rdar://problem/14437753>
Reviewed by Sam Weinig.
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::create): Return a unique origin if the port is out of range.
- 6:27 PM Changeset in webkit [152622] by
-
- 2 edits in trunk/Source/WebCore
Another Qt build fix attempt after r152619.
- dom/QualifiedName.cpp:
(WebCore::QualifiedName::toString):
- 6:22 PM Changeset in webkit [152621] by
-
- 2 edits in trunk/Source/WebCore
Qt build fix attempt after r152619.
- dom/QualifiedName.cpp:
(WebCore::QualifiedName::toString):
- 6:01 PM Changeset in webkit [152620] by
-
- 2 edits in trunk/Websites/webkit.org
Add Company100 to team.html
https://bugs.webkit.org/show_bug.cgi?id=118633
Reviewed by Andreas Kling.
- team.html:
- 5:47 PM Changeset in webkit [152619] by
-
- 2 edits in trunk/Source/WebCore
Mac build fix attempt after r152615.
- svg/SVGFilterElement.h:
- 5:45 PM Changeset in webkit [152618] by
-
- 2 edits in trunk/Source/WebCore
Modernize QualifiedName by wrapping gNameCache in a function and using more early exits
https://bugs.webkit.org/show_bug.cgi?id=118299
Reviewed by Andreas Kling.
Address Ben's review comment.
- dom/QualifiedName.cpp:
(WebCore::QualifiedName::toString):
- 5:35 PM Changeset in webkit [152617] by
-
- 2 edits in trunk/LayoutTests
apply-style-command-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=118634
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/a30dad44ded92d24ed56761434cf6041688659a0.
Also replace CRLF to LF and get rid of svn:executable.
- editing/execCommand/apply-style-command-crash.html:
- 7:49 AM Changeset in webkit [152616] by
-
- 2 edits in trunk/Source/WebCore
HTMLTextFormControlElement::valueWithHardLineBreaks shouldn't upconvert 8-bit string
https://bugs.webkit.org/show_bug.cgi?id=118631
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/2c7c70a7bd3d61bfbf97de95c459ec9f40b46e31.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks):
- 6:59 AM Changeset in webkit [152615] by
-
- 5 edits in trunk/Source/WebCore
Add toSVGFilterElement() and use it.
https://bugs.webkit.org/show_bug.cgi?id=118653
Reviewed by Ryosuke Niwa.
We can use toSVGFilterElement() instead of using static_cast<..> to improve readability.
Blink also uses it.
No new tests, no behavior change.
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::buildPrimitives):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::resourceBoundingBox):
- rendering/svg/RenderSVGResourceFilter.h:
(WebCore::RenderSVGResourceFilter::filterUnits):
(WebCore::RenderSVGResourceFilter::primitiveUnits):
- rendering/svg/SVGResources.cpp:
(WebCore::targetReferenceFromResource):
- svg/SVGFilterElement.h:
(WebCore::toSVGFilterElement):
- 1:55 AM Changeset in webkit [152614] by
-
- 10 edits in trunk/Source
Introduce toHTMLVideoElement
https://bugs.webkit.org/show_bug.cgi?id=118582
Reviewed by Ryosuke Niwa.
To avoid direct use of static_cast, this patch introduces toHTMLVideoElement.
Source/WebCore:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::getPluginProxyParams):
- html/HTMLVideoElement.h:
(WebCore::toHTMLVideoElement):
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::descendentVideoElement):
(WebCore::ancestorVideoElement):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::enterFullscreenForVideo):
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::videoElement):
Source/WebKit/qt:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::mediaContentUrlByElementId):
- WebCoreSupport/FullScreenVideoQt.cpp:
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
Jul 13, 2013:
- 11:12 PM Changeset in webkit [152613] by
-
- 12 edits in trunk/Source
Unreviewed, rolling out r151978.
http://trac.webkit.org/changeset/151978
https://bugs.webkit.org/show_bug.cgi?id=118651
Caused regressions at least 3 websites (Requested by rniwa on
#webkit).
Source/JavaScriptCore:
- runtime/JSCJSValue.h:
- runtime/JSString.h:
Source/WebCore:
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMBinding.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GetNativeTypeFromSignature):
(JSValueToNative):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
- dom/Document.idl:
- dom/Element.idl:
- dom/Node.idl:
- 11:03 PM Changeset in webkit [152612] by
-
- 4 edits5 adds in trunk
Caret should respect text background color
https://bugs.webkit.org/show_bug.cgi?id=117493
Reviewed by Ryosuke Niwa.
Source/WebCore:
This patch allows the caret to become visible in the black background
by getting the caret color from the color of the element containing
the text, not the parent element that has the contentEditable attribute.
Test: editing/caret/caret-color.html
- editing/FrameSelection.cpp:
(WebCore::CaretBase::paintCaret):
LayoutTests:
This tests to make sure that the caret is visible in the black background
by getting the caret color from the color of the element(span) containing
the text, not the parent element(div) that has the contentEditable
attribute.
- editing/caret/caret-color-expected.txt: Added.
- editing/caret/caret-color.html: Added.
- platform/efl/editing/caret/caret-color-expected.png: Added.
- platform/mac/TestExpectations: Skip this test case.
- 6:11 PM Changeset in webkit [152611] by
-
- 8 edits in trunk/Source/WebCore
Avoid upconverting strings in various places in WebCore
https://bugs.webkit.org/show_bug.cgi?id=118632
Reviewed by Andreas Kling.
Avoid calling String::characters() in various places since it upconverts 8-bit strings to 16-bit strings.
Merge
https://chromium.googlesource.com/chromium/blink/+/a6162e2ad7c7870e22445d3c463d17e7ac871e80
https://chromium.googlesource.com/chromium/blink/+/18095209b3f467758b83894e7b14f813f6953f81
https://chromium.googlesource.com/chromium/blink/+/fefcf2b95d55f24c60fd2e95978cf4544f3c92ca
https://chromium.googlesource.com/chromium/blink/+/8e0527b0fb33998318aedfd74b3511025f7ff294
https://chromium.googlesource.com/chromium/blink/+/feaf798b04597b0849b4000fc305264895d3eac5
https://chromium.googlesource.com/chromium/blink/+/bd1a49103a6e07b1023d2c742d8217769efbffb4
- css/CSSParser.cpp:
(WebCore::CSSParser::setupParser):
(WebCore::CSSParser::parseImageSet):
(WebCore::CSSParser::rewriteSpecifiers):
- css/CSSParserValues.h:
(WebCore::CSSParserString::init):
(WebCore::CSSParserString::clear):
- dom/DatasetDOMStringMap.cpp:
(WebCore::isValidAttributeName):
(WebCore::convertAttributeNameToPropertyName):
(WebCore::propertyNameMatchesAttributeName):
(WebCore::isValidPropertyName):
(WebCore::convertPropertyNameToAttributeName):
- dom/Range.cpp:
(WebCore::Range::toString):
- dom/SecurityContext.cpp:
(WebCore::SecurityContext::parseSandboxPolicy):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::measureText):
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::markFutureAndPastNodes):
- 8:32 AM Changeset in webkit [152610] by
-
- 2 edits in trunk/Source/WebCore
parseHTMLInteger shouldn't upconvert 8-bit string
https://bugs.webkit.org/show_bug.cgi?id=118629
Reviewed by Sam Weinig.
Merge https://chromium.googlesource.com/chromium/blink/+/e0ebab23e0c16b49dc90c9c39b8bbbf4f243a01e.
- html/parser/HTMLParserIdioms.cpp:
(WebCore::parseHTMLInteger):
Jul 12, 2013:
- 8:44 PM Changeset in webkit [152609] by
-
- 2 edits in trunk/Tools
Unreviewed. Add an email address and update my domain of experts.
- Scripts/webkitpy/common/config/contributors.json:
- 4:59 PM Changeset in webkit [152608] by
-
- 4 edits in trunk/Source/WebKit/mac
Remove some dead stores pointed out by the clang static analyzer.
https://bugs.webkit.org/show_bug.cgi?id=118608
Reviewed by Anders Carlsson.
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin):
kr is never read after this point, so there is no reason to assign to it.
- Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage getPluginInfoFromPLists]):
The extensions array is only used in the while loop. Move the declaration to the first place
it is used in the while loop. Since it is always reassigned at that location, and since it
is never read after the subsequent for loop, the assignment to an array containing the empty
string is never used. Remove it.
Similarly, the value of the description is always overwritten before used to assign to
mimeClassInfo.desc or to pluginInfo.desc, so the code to assign it to the empty string is
never used. Remove it.
- WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController _placePopupWindow:]):
maxWidth is never read (and never was since it was added in r7311) after it is used on the
line above to set windowFrame.size.width.
- 4:35 PM Changeset in webkit [152607] by
-
- 2 edits in trunk/Source/WebCore
[iOS] TextTrackRepresentation not cleared when captions are disabled
https://bugs.webkit.org/show_bug.cgi?id=118623
Reviewed by Dean Jackson.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Do not return immediately
when captions are disabled so the necessary cleanup happens.
- 3:37 PM Changeset in webkit [152606] by
-
- 4 edits in trunk
Source/JavaScriptCore: Optimize addStrackTraceIfNecessary to be faster in the case when it's not necessary
https://bugs.webkit.org/show_bug.cgi?id=118328
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-07-12
Reviewed by Geoffrey Garen.
Retrieving the stack is costly. We want to get it only once. By moving the check
for the .stack property above the code to retrieve the stack, we ensure this.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::addStackTraceIfNecessary):
LayoutTests: By optimizing when the stack is added a two tests needed to be modifed to show correct results.
https://bugs.webkit.org/show_bug.cgi?id=118328
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-07-12
Reviewed by Geoffrey Garen.
- inspector/console/console-exception-stack-traces.html: This test compares the console's currect
stack with the error object's stack. The test was failing on decodeURI() and eval() which create
a new frame on the stack to execute. The console's stack was unaware of these calls and the size
of the stacks would not match. I added a check to pass if it was the specific case with decodeURI
or eval.
- 1:05 PM Changeset in webkit [152605] by
-
- 2 edits in trunk/Tools
[jhbuild] Avoid restarting from scratch failed initial checkouts
https://bugs.webkit.org/show_bug.cgi?id=118603
Patch by Emanuele Aina <Emanuele Aina> on 2013-07-12
Reviewed by Martin Robinson.
If the initial checkout is interrupted midway (eg. because the internet
connection went down) config files do not get generated and that causes
the next checkout to start from scratch (the missing files cause the
script to delete the build root and the downloaded sources).
By generating the files before invoking jhbuild, subsequent runs are able
to start where the previous run left.
- Scripts/update-webkit-libs-jhbuild:
(saveJhbuildMd5): invoke it before runJhbuild().
- 12:51 PM Changeset in webkit [152604] by
-
- 2 edits in trunk/Tools
[Windows] Remove single-worker restriction on tests.
- Scripts/webkitpy/port/win.py: Remove restriction of one worker.
- 12:30 PM Changeset in webkit [152603] by
-
- 3 edits in trunk/Source/WebCore
[Windows] Attempt to satisfy the Open Source Windows bots.
- DerivedSources.make: Restore the HAVE_AVCF macro detection.
- config.h: Return to using HAVE_AVCF to activate AVFoundation code.
- 12:05 PM Changeset in webkit [152602] by
-
- 3 edits1 delete in trunk/Tools
Unreviewed, rolling out r152599.
http://trac.webkit.org/changeset/152599
https://bugs.webkit.org/show_bug.cgi?id=118612
This patch includes a failing unit test (Requested by
mrobinson on #webkit).
- Scripts/webkitpy/style/checkers/python.py:
(Pylinter):
- Scripts/webkitpy/style/checkers/python_unittest.py:
(PythonCheckerTest.test_check):
- Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
- 11:57 AM Changeset in webkit [152601] by
-
- 2 edits in trunk/Tools
[Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=91223
Patch by Emanuele Aina <Emanuele Aina> on 2013-07-12
Reviewed by Martin Robinson.
When run on a clean checkout,
build-webkitcomplains that no
GNUmakefile exists when trying to detect the previously configured
architecture, but in this case there's no previous configuration so
the warning is pointless.
- Scripts/webkitdirs.pm:
(determineArchitecture): Redirect grep stderr to /dev/null.
- 11:54 AM Changeset in webkit [152600] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Windows] Build correction after r152573/r152577.
https://bugs.webkit.org/show_bug.cgi?id=118610
Reviewed by Oliver Hunt.
- jit/JITThunks.cpp:
(JSC::JITThunks::hostFunctionStub): Hand-feed MSVC++ the fact that we want the second
argument of the make_pair to be a function pointer.
- 11:36 AM Changeset in webkit [152599] by
-
- 3 edits1 add in trunk/Tools
check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
https://bugs.webkit.org/show_bug.cgi?id=118592
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-12
Reviewed by Martin Robinson.
Added a suppression for pylint false positives and a unit test.
- Scripts/webkitpy/style/checkers/python.py:
(Pylinter):
- Scripts/webkitpy/style/checkers/python_unittest.py:
(PythonCheckerTest.test_check):
(PythonCheckerTest):
(PythonCheckerTest.test_pylint_false_positives):
(PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
- Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
(test_popen):
- 11:31 AM Changeset in webkit [152598] by
-
- 17 edits in trunk/Source/WebInspectorUI
Update CodeMirror to 7f560afa1c (3.14+).
https://bugs.webkit.org/show_bug.cgi?id=118605
Reviewed by Sam Weinig.
- Tools/PrettyPrinting/CodeMirrorFormatters.js:
- Tools/PrettyPrinting/Formatter.js:
- Tools/PrettyPrinting/FormatterContentBuilder.js:
- Tools/PrettyPrinting/codemirror.css:
- Tools/PrettyPrinting/codemirror.js:
- Tools/PrettyPrinting/css.js:
- Tools/PrettyPrinting/javascript.js:
- UserInterface/External/CodeMirror/codemirror.css:
- UserInterface/External/CodeMirror/codemirror.js:
- UserInterface/External/CodeMirror/coffeescript.js:
- UserInterface/External/CodeMirror/comment.js:
- UserInterface/External/CodeMirror/css.js:
- UserInterface/External/CodeMirror/javascript.js:
- UserInterface/External/CodeMirror/matchbrackets.js:
- UserInterface/External/CodeMirror/sql.js:
- UserInterface/External/CodeMirror/xml.js:
- 10:56 AM Changeset in webkit [152597] by
-
- 1 copy in tags/Safari-537.50
New Tag.
- 10:53 AM Changeset in webkit [152596] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- 9:40 AM Changeset in webkit [152595] by
-
- 2 edits in trunk/Source/WTF
Improve StringImpl::constructInternal() method
https://bugs.webkit.org/show_bug.cgi?id=118503
Reviewed by Benjamin Poulain.
StringImpl::constructInternal used 'if ()' statement to decide which constructor
to invoke hence compiler had to compile both branches even though optimizer would
have then removed one of those, and as the function is inline it could affect
slightly the compilation time.
The problem is solved via template specialization.
- wtf/text/StringImpl.h:
(WTF::LChar):
(WTF::UChar):
- 9:36 AM Changeset in webkit [152594] by
-
- 12 edits in branches/safari-537-branch/Source
Merged r152571. <rdar://problem/14364171>
- 9:28 AM Changeset in webkit [152593] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=118461
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-12
Reviewed by Brent Fulgham.
- config.h: Only enable AVFOUNDATION for Windows if CoreGraphics is used.
- 9:28 AM Changeset in webkit [152592] by
-
- 5 edits in branches/safari-537-branch/Source
Versioning.
- 7:42 AM Changeset in webkit [152591] by
-
- 2 edits in trunk/Source/WebCore
[EFL] --minimal build fails while linking libwebcore_efl.so
https://bugs.webkit.org/show_bug.cgi?id=118549
Patch by Oleg Beletski <oleg.beletski@gmail.com> on 2013-07-12
Reviewed by Christophe Dumez.
- CMakeLists.txt:
Moving file plugins/PluginPackage.cpp to ENABLE_NETSCAPE_PLUGIN_API block.
- 6:16 AM Changeset in webkit [152590] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipping new failing test on Qt.
https://bugs.webkit.org/show_bug.cgi?id=118595
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-12
- platform/qt/TestExpectations:
- 5:55 AM Changeset in webkit [152589] by
-
- 4 edits in trunk/LayoutTests
Unreviewed typo fix.
- fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:
- fast/css-grid-layout/grid-element-change-columns-repaint.html:
- platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:
- 5:45 AM Changeset in webkit [152588] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Pass null for sidebarPanels and role in WebInspector.Sidebar()
https://bugs.webkit.org/show_bug.cgi?id=118589
Patch by Seokju Kwon <Seokju Kwon> on 2013-07-12
Reviewed by Timothy Hatcher.
sidebarPanels : It is necessary to get correct argument after r152141.
Without this, error messages can be displayed.
role : Could pass null for it since default value is "group".
- UserInterface/Main.js:
(WebInspector.contentLoaded):
- 3:33 AM Changeset in webkit [152587] by
-
- 2 edits in tags/Safari-537.49.1/Source/WebKit2
Build fix.
- Configurations/BaseTarget.xcconfig: Ensure that /System/Library/PrivateFrameworks is on the framework
search path.
- 3:33 AM Changeset in webkit [152586] by
-
- 5 edits in tags/Safari-537.49.1/Source
Versioning.
- 3:25 AM Changeset in webkit [152585] by
-
- 1 copy in tags/Safari-537.49.1
New tag.
- 1:22 AM Changeset in webkit [152584] by
-
- 3 edits in trunk/Source/WebCore
Insufficient viewport repaints when FrameView::paintsEntireContents
https://bugs.webkit.org/show_bug.cgi?id=118562
Reviewed by Simon Fraser.
When the frameview paints entire content, the visualOverflowRect of RenderView
should be the same as the layoutOverflowRect.
This affects the requested repaints on resize of the frameview.
- rendering/RenderView.cpp:
(WebCore::RenderView::visualOverflowRect):
- rendering/RenderView.h:
Jul 11, 2013:
- 11:42 PM WebKitGTK/Wayland edited by
- (diff)
- 6:59 PM Changeset in webkit [152583] by
-
- 2 edits in trunk/Websites/webkit.org
Add 'partner.samsung.com' to domain affiliations
https://bugs.webkit.org/show_bug.cgi?id=118580
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2013-07-11
Reviewed by Antonio Gomes.
- team.html:
- 5:50 PM Changeset in webkit [152582] by
-
- 7 edits1 add in trunk/LayoutTests
Replace simple_blank.swf with lines.swf for snapshotting tests.
https://bugs.webkit.org/show_bug.cgi?id=118581.
Reviewed by Tim Horton.
- plugins/resources/lines.swf: Added.
- plugins/snapshotting/autoplay-dominant.html:
- plugins/snapshotting/autoplay-similar-to-dominant-after-delay.html:
- plugins/snapshotting/autoplay-similar-to-dominant.html:
- plugins/snapshotting/plugin-receives-click-event.html:
- plugins/snapshotting/restart.html:
- plugins/snapshotting/simple.html:
- 4:59 PM Changeset in webkit [152581] by
-
- 9 edits in branches/dfgFourthTier/Source/JavaScriptCore
Resurrect the CLoop LLINT on the FTL branch.
https://bugs.webkit.org/show_bug.cgi?id=118144.
Reviewed by Mark Hahnenberg.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::jitType):
- Fix the CodeBlock jitType to be InterpreterThunk when !ENABLE_JIT.
- bytecode/JumpTable.h:
(JSC::SimpleJumpTable::clear):
- interpreter/StackIterator.cpp:
(JSC::StackIterator::Frame::bytecodeOffset):
(JSC::StackIterator::Frame::print):
- jit/JITCode.cpp:
(JSC):
- jit/JITExceptions.cpp:
(JSC::getExceptionLocation):
- llint/LowLevelInterpreter.cpp:
- offlineasm/cloop.rb:
- runtime/Structure.cpp:
- 4:53 PM Changeset in webkit [152580] by
-
- 8 edits2 adds in trunk
Plugins that don't support snapshotting should not all autostart.
https://bugs.webkit.org/show_bug.cgi?id=118572
<rdar://problem/14324391>.
Reviewed by Dean Jackson.
Test: plugins/snapshotting/quicktime-plugin-snapshotted.html
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Pass in information about whether or not a snapshot exists
to the shadow dom.
- plugins/PluginViewBase.h:
(WebCore::PluginViewBase::shouldNotAddLayer): This method determines whether or not we should add the plugin's layer to the tree.
It should not be added if the plugin is in it's snapshotted state but does not actually support snapshotting.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): We should only add the layer to the tree when the plugin
is actually playing. Otherwise we run into an issue where the contents of the layer initially appear on the screen briefly
on page load before we display the substitute for a plugin that doesn't support snapshotting.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::shouldNotAddLayer): This method determines whether or not we should add the plugin's layer to the tree.
It should not be added if the plugin is in it's snapshotted state but does not actually support snapshotting.
(WebKit::PluginView::pluginSnapshotTimerFired): If the plugin does not support snapshotting go straight
to the the DisplayingSnapshot state.
- WebProcess/Plugins/PluginView.h:
- platform/mac-wk2/plugins/snapshotting/quicktime-plugin-snapshotted-expected.txt: Added.
- plugins/snapshotting/quicktime-plugin-snapshotted.html: Added.
- 3:33 PM Changeset in webkit [152579] by
-
- 5 edits in trunk/Source
[mac] No API for getting the page visibility state of a WebView
https://bugs.webkit.org/show_bug.cgi?id=118578
Reviewed by Simon Fraser.
Source/WebCore:
- WebCore.exp.in: Export WebCore::Page::visibilityState().
Source/WebKit/mac:
- WebView/WebView.mm:
(kit): Added. Converts from WebCore::PageVisibilityState to WebPageVisibilityState.
(-[WebView _visibilityState]): Added.
- WebView/WebViewPrivate.h: Declared -_visibilityState.
- 3:27 PM Changeset in webkit [152578] by
-
- 2 edits in trunk/Source/WebKit2
WebResourceCacheManager::cfURLCacheHostNamesWithCallback leaks an array (pointed out by the
clang static analyzer)
https://bugs.webkit.org/show_bug.cgi?id=118533
Reviewed by Anders Carlsson.
- WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
(WebKit::WebResourceCacheManager::cfURLCacheHostNamesWithCallback):
- 2:57 PM Changeset in webkit [152577] by
-
- 3 edits in trunk/Source/JavaScriptCore
Attempt to fix the windows build.
- 2:40 PM Changeset in webkit [152576] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed gardening. Added expected failures after r152574.
- platform/gtk/TestExpectations: Added test failures.
- 12:40 PM Changeset in webkit [152575] by
-
- 2 edits in trunk/Source/WebKit2
Use GOwnPtr in PluginProcessProxyUnix to manage stdOut variable
https://bugs.webkit.org/show_bug.cgi?id=118568
Patch by Sergio Correia <Sergio Correia> on 2013-07-11
Reviewed by Martin Robinson.
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::scanPlugin):
- 11:57 AM Changeset in webkit [152574] by
-
- 4 edits in trunk
[GTK] Layout Test accessibility/deleting-iframe-destroys-axcache.html, platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html are failing
https://bugs.webkit.org/show_bug.cgi?id=118552
Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-07-11
Reviewed by Chris Fleizach.
Source/WebCore:
Do not assume always that we have a RenderText renderer when
calling to toRenderText(), since we might be executing that part
of the code due to have requested to include all the children.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement): Add
missing guard for RenderText, needed after r152537.
LayoutTests:
Remove tests that are no longer expected to crash.
- platform/gtk/TestExpectations: Removed tests.
- 11:35 AM Changeset in webkit [152573] by
-
- 8 edits in trunk
NativeExecutable cache needs to use both call and construct functions for key
https://bugs.webkit.org/show_bug.cgi?id=118545
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Make the native executable cache make use a key pair so we don't decide to
treat all subsequent functions as not being constructors.
- jit/JITThunks.cpp:
(JSC::JITThunks::hostFunctionStub):
- jit/JITThunks.h:
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::create):
- runtime/JSCell.cpp:
(JSC::JSCell::getCallData):
(JSC::JSCell::getConstructData):
LayoutTests:
Make sure we don't decide that all bound functions aren't constructors.
- fast/js/function-bind-expected.txt:
- fast/js/script-tests/function-bind.js:
- 9:17 AM Changeset in webkit [152572] by
-
- 6 edits4 adds in trunk
[CSS Regions] In a region chain with auto-height regions, lines get their length based only on the first region
https://bugs.webkit.org/show_bug.cgi?id=118531
Reviewed by Alexandru Chiculita.
Source/WebCore:
When computing the height a flow thread it's possible to overflow the maximum LayoutUnit and obtain a negative value.
This leads to invalid results during layout when computing the region range and the RenderBoxRegion info for the
descendant boxes of the flow thread.
This issue appears especially during the auto-height algorithm because it initializes the auto-height regions
height with the LayoutUnit::max() / 2 value. Summing two such regions overflows and results in a negative value.
The fix clamps the maximum height of the flow thread to LayoutUnit::max() / 2. This doesn't affect the auto-height
algorithm because regionAtBlockOffset() will still return the correct values as the auto-height regions content
is established and their height updated.
Tests: fast/regions/autoheight-correct-region-for-lines-2.html
fast/regions/autoheight-correct-region-for-lines.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateRegionsAndShapesBeforeChildLayout):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::maxPageLogicalHeight):
LayoutTests:
Add tests verifying the lines widths are correctly computed in auto-height regions with and without a max-height set.
- fast/regions/autoheight-correct-region-for-lines-2-expected.html: Added.
- fast/regions/autoheight-correct-region-for-lines-2.html: Added.
- fast/regions/autoheight-correct-region-for-lines-expected.html: Added.
- fast/regions/autoheight-correct-region-for-lines.html: Added.
- 8:43 AM Changeset in webkit [152571] by
-
- 12 edits in trunk/Source
Revert r152267 and soft link WebInspectorUI.framework again.
https://bugs.webkit.org/show_bug.cgi?id=118544
Reviewed by David Kilzer.
Source/WebCore:
- platform/mac/SoftLinking.h: Rename SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL
to SOFT_LINK_STAGED_FRAMEWORK and ASSERT since we don't want to silently
fail anymore when using this macro.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig:
- WebCoreSupport/WebInspectorClient.mm:
(useWebKitWebInspector):
Source/WebKit2:
- Configurations/WebKit2.xcconfig:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
- 8:17 AM Changeset in webkit [152570] by
-
- 5 edits in trunk/Source
[Coordinated Graphics] Parameter of commitSceneState should be const
https://bugs.webkit.org/show_bug.cgi?id=118564
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-11
Reviewed by Noam Rosenthal.
Parameter of commitSceneState should be const as there should not be any
modifications to the passed CoordinatedGraphicsState.
Source/WebCore:
- platform/graphics/texmap/coordinated/CompositingCoordinator.h:
Source/WebKit2:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::commitSceneState):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- 7:54 AM Changeset in webkit [152569] by
-
- 14 edits2 adds2 deletes in trunk
NamedFlowCollection getters should follow the same pattern as HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=118561
Patch by Radu Stavila <stavila@adobe.com> on 2013-07-11
Reviewed by Christophe Dumez.
Source/WebCore:
Modified item and namedItem methods from DOMNamedFlowCollection to return null instead of undefined.
https://www.w3.org/Bugs/Public/show_bug.cgi?id=22617
Completely removed the TreatReturnedNullObjectAs attribute as it was only used by the DOMNamedFlowCollection interface.
Test: fast/regions/webkit-named-flow-collection-empty-getters.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementationFunctionCall):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::treatReturnedNullObjectAsUndefined):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_treat_returned_null_object_as_undefined):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionTreatReturnedNullObjectAsUndefined):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj treatReturnedNullObjectAsUndefined]):
- bindings/scripts/test/TestObj.idl:
- dom/DOMNamedFlowCollection.idl:
LayoutTests:
Updated test for NamedFlowCollection getters when no named flows are created.
- fast/regions/webkit-named-flow-collection-empty-getters-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-undefined-expected.txt.
- fast/regions/webkit-named-flow-collection-empty-getters.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-undefined.html.
- 7:45 AM Changeset in webkit [152568] by
-
- 2 edits in trunk/Source/WebCore
Revert r149313: Don't check for @media rules affected by viewport changes in every layout.
<rdar://problem/14277905>
Rubber-stamped by Antti Koivisto.
This changed caused more harm than good. setFrameRect() is not the only path in FrameView
that can cause media queries to need invalidation.
- page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::layout):
- 6:56 AM WebKitIDL edited by
- (diff)
- 5:43 AM Changeset in webkit [152567] by
-
- 4 edits in trunk/Source/WebCore
Introduce isHTMLTitleElement and toHTMLTitleElement
https://bugs.webkit.org/show_bug.cgi?id=118558
Reviewed by Andreas Kling.
To enhance readability, this patch introduces isHTMLTitleElement and toHTMLTitleElement.
This also helps out to reduce duplicated use of static_cast.
- dom/Document.cpp:
(WebCore::Document::setTitle):
(WebCore::Document::removeTitle):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::removeHeadContents):
- html/HTMLTitleElement.h:
(WebCore::isHTMLTitleElement):
(WebCore::toHTMLTitleElement):
- 4:43 AM Changeset in webkit [152566] by
-
- 2 edits6 deletes in trunk/Source
Remove unused Windows CE files
https://bugs.webkit.org/show_bug.cgi?id=118557
Reviewed by Andreas Kling.
Source/WebCore:
- platform/wince/CursorWinCE.cpp: Removed.
- platform/wince/PasteboardWinCE.cpp: Removed.
- platform/wince/SearchPopupMenuWinCE.cpp: Removed.
Source/WTF:
- wtf/wince/FastMallocWinCE.h: Removed.
- wtf/wince/MemoryManager.cpp: Removed.
- wtf/wince/MemoryManager.h: Removed.
- 4:19 AM Changeset in webkit [152565] by
-
- 16 edits11 copies3 moves4 adds in trunk/Source/WebCore
Get rid of SVGPathSeg* special casing in the bindings generator
https://bugs.webkit.org/show_bug.cgi?id=118525
Reviewed by Kentaro Hara.
Have one header per SVGPathSeg* type so that we no longer need special casing
for them in the JSC bindings generator.
No new tests, no behavior change.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSSVGPathSegCustom.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(NativeToJSValue):
- svg/SVGPathElement.cpp:
- svg/SVGPathSegArc.h:
- svg/SVGPathSegArcAbs.h: Added.
(WebCore::SVGPathSegArcAbs::create):
(WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs):
(WebCore::SVGPathSegArcAbs::pathSegType):
(WebCore::SVGPathSegArcAbs::pathSegTypeAsLetter):
- svg/SVGPathSegArcRel.h: Added.
(WebCore::SVGPathSegArcRel::create):
(WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
(WebCore::SVGPathSegArcRel::pathSegType):
(WebCore::SVGPathSegArcRel::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoCubic.h:
- svg/SVGPathSegCurvetoCubicAbs.h: Added.
(WebCore::SVGPathSegCurvetoCubicAbs::create):
(WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs):
(WebCore::SVGPathSegCurvetoCubicAbs::pathSegType):
(WebCore::SVGPathSegCurvetoCubicAbs::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoCubicRel.h: Added.
(WebCore::SVGPathSegCurvetoCubicRel::create):
(WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
(WebCore::SVGPathSegCurvetoCubicRel::pathSegType):
(WebCore::SVGPathSegCurvetoCubicRel::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoCubicSmooth.h:
- svg/SVGPathSegCurvetoCubicSmoothAbs.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoCubicSmooth.h.
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::create):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::pathSegType):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoCubicSmoothRel.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoCubicSmooth.h.
(WebCore::SVGPathSegCurvetoCubicSmoothRel::create):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::pathSegType):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoQuadratic.h:
- svg/SVGPathSegCurvetoQuadraticAbs.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoQuadratic.h.
(WebCore::SVGPathSegCurvetoQuadraticAbs::create):
(WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs):
(WebCore::SVGPathSegCurvetoQuadraticAbs::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticAbs::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoQuadraticRel.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoQuadratic.h.
(WebCore::SVGPathSegCurvetoQuadraticRel::create):
(WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
(WebCore::SVGPathSegCurvetoQuadraticRel::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticRel::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoQuadraticSmoothAbs.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoQuadraticSmooth.h.
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::create):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoQuadraticSmoothRel.h: Renamed from Source/WebCore/svg/SVGPathSegCurvetoQuadraticSmooth.h.
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::create):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoAbs.h: Copied from Source/WebCore/svg/SVGPathSegLineto.h.
(WebCore::SVGPathSegLinetoAbs::create):
(WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs):
(WebCore::SVGPathSegLinetoAbs::pathSegType):
(WebCore::SVGPathSegLinetoAbs::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoHorizontal.h:
- svg/SVGPathSegLinetoHorizontalAbs.h: Copied from Source/WebCore/svg/SVGPathSegLinetoHorizontal.h.
(WebCore::SVGPathSegLinetoHorizontalAbs::create):
(WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs):
(WebCore::SVGPathSegLinetoHorizontalAbs::pathSegType):
(WebCore::SVGPathSegLinetoHorizontalAbs::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoHorizontalRel.h: Copied from Source/WebCore/svg/SVGPathSegLinetoHorizontal.h.
(WebCore::SVGPathSegLinetoHorizontalRel::create):
(WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
(WebCore::SVGPathSegLinetoHorizontalRel::pathSegType):
(WebCore::SVGPathSegLinetoHorizontalRel::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoRel.h: Renamed from Source/WebCore/svg/SVGPathSegLineto.h.
(WebCore::SVGPathSegLinetoRel::create):
(WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
(WebCore::SVGPathSegLinetoRel::pathSegType):
(WebCore::SVGPathSegLinetoRel::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoVertical.h:
- svg/SVGPathSegLinetoVerticalAbs.h: Copied from Source/WebCore/svg/SVGPathSegLinetoVertical.h.
(WebCore::SVGPathSegLinetoVerticalAbs::create):
(WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs):
(WebCore::SVGPathSegLinetoVerticalAbs::pathSegType):
(WebCore::SVGPathSegLinetoVerticalAbs::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoVerticalRel.h: Copied from Source/WebCore/svg/SVGPathSegLinetoVertical.h.
(WebCore::SVGPathSegLinetoVerticalRel::create):
(WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
(WebCore::SVGPathSegLinetoVerticalRel::pathSegType):
(WebCore::SVGPathSegLinetoVerticalRel::pathSegTypeAsLetter):
- svg/SVGPathSegListBuilder.cpp:
- svg/SVGPathSegMovetoAbs.h: Copied from Source/WebCore/svg/SVGPathSegMoveto.h.
(WebCore::SVGPathSegMovetoAbs::create):
(WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs):
(WebCore::SVGPathSegMovetoAbs::pathSegType):
(WebCore::SVGPathSegMovetoAbs::pathSegTypeAsLetter):
- svg/SVGPathSegMovetoRel.h: Renamed from Source/WebCore/svg/SVGPathSegMoveto.h.
(WebCore::SVGPathSegMovetoRel::create):
(WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
(WebCore::SVGPathSegMovetoRel::pathSegType):
(WebCore::SVGPathSegMovetoRel::pathSegTypeAsLetter):
- 3:53 AM Changeset in webkit [152564] by
-
- 2 edits in trunk/Source/WebCore
Build fix for WinCE after r152426.
- config.h:
- 3:28 AM Changeset in webkit [152563] by
-
- 2 edits in trunk/Source/WebCore
[Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont
https://bugs.webkit.org/show_bug.cgi?id=118532
Patch by Fabienne Semeria <fsemeria@nds.com> on 2013-07-11
Reviewed by Allan Sandfeld Jensen.
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
- 2:09 AM Changeset in webkit [152562] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed gardening. Added crash expectations in debug builds after r152537
- platform/gtk/TestExpectations: Added two crashing tests.
- 1:36 AM Changeset in webkit [152561] by
-
- 2 edits in trunk/Source/WebCore
[ATK] Refactor code for translating offsets between WebCore a11y and ATK
https://bugs.webkit.org/show_bug.cgi?id=118179
Reviewed by Chris Fleizach.
Encapsulate better and make more clear the translation of offsets
between our ATK implementation and WebCore's accessibility layer.
Values for offsets can differ sometimes between those two worlds
due to some extra flattening we need to do in ATK based ports to
properly expose the accessibility hierarchy to ATs, which
sometimes means adding extra text elements in the exposed text
through the AtkText interface (e.g. list items markers).
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(offsetAdjustmentForListItem): Helper function to refactor code
needed to translate offsets from WebCore to ATK worlds. Currently
related to considering list item markers in LTR text only.
(webCoreOffsetToAtkOffset): Convenience function for code
readability purposes. It just calls offsetAdjustmentForListItem.
(atkOffsetToWebCoreOffset): Likewise.
(getSelectionOffsetsForObject): Use webCoreOffsetToAtkOffset.
(webkitAccessibleTextGetCaretOffset): Use webCoreOffsetToAtkOffset
to translate an offset from WebCore to ATK before returning it.
(webkitAccessibleTextSetSelection): Use atkOffsetToWebCoreOffset
to translate an offset from WebCore to ATK before using it.
(webkitAccessibleTextSetCaretOffset): Likewise.
- 12:00 AM Changeset in webkit [152560] by
-
- 2 edits in trunk/Tools
Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=118538
Patch by Sergio Correia <Sergio Correia> on 2013-07-10
Reviewed by Christophe Dumez.
When attempting some odd url such as
foo, MiniBrowser will now show an
error message such as "Cannot resolve hostname (foo)".
Previously, it had the following behavior if MiniBrowser was started with
such urls, e.g./MiniBrowser foo:
- Debug:
It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
- Release:
No asserts, naturally, but the view would remain blank, even if we tried to
change to a valid url.
- MiniBrowser/efl/main.c:
(window_create):
Jul 10, 2013:
- 6:15 PM Changeset in webkit [152559] by
-
- 1 copy in tags/Safari-537.49
New Tag.
- 5:46 PM Changeset in webkit [152558] by
-
- 3 edits2 deletes in branches/safari-537-branch
Rollout of r152556. <rdar://problem/14305675>
- 5:31 PM Changeset in webkit [152557] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152555. <rdar://problem/14395759>
- 5:14 PM Changeset in webkit [152556] by
-
- 3 edits2 copies in branches/safari-537-branch
Merged r152554. <rdar://problem/14305675>
- 5:13 PM Changeset in webkit [152555] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/14395759> PluginProcess sometimes logs an error about being unable to load WebKit2.framework.
Reviewed by Alexey Proskuryakov.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::createPropertyListFile): Ensure that any environment variables
specified in dynamic linker load commands are passed to the subprocess that we spawn to create
the MIME type property list.
- 4:56 PM Changeset in webkit [152554] by
-
- 3 edits2 adds in trunk
Range.getClientRects() not working correctly for partially contained vertically styled text nodes
<rdar://problem/14305675>
https://bugs.webkit.org/show_bug.cgi?id=118447
Reviewed by David Hyatt.
Source/WebCore:
Original patch by Mac Murrett, tweaked by me.
Test: fast/dom/Range/getClientRects-vertical.html
- rendering/RenderText.cpp:
(WebCore::localQuadForTextBox):
Use the physical accessors rather than the logical ones to get the correct metrics.
LayoutTests:
- fast/dom/Range/getClientRects-vertical-expected.txt: Added.
- fast/dom/Range/getClientRects-vertical.html: Added.
- 4:48 PM Changeset in webkit [152553] by
-
- 58 edits2 adds in trunk/Source/WebCore
Reduce number of header includes in SVG
https://bugs.webkit.org/show_bug.cgi?id=118474
Reviewed by Rob Buis.
Reduce number of header includes in SVG. In particular, SVGAnimatedPropertyMacros.h
no longer brings SVGElement.h header include. This means that the SVGElement
class can now have animated properties.
This patch is a prerequirement to merge SVGStyledElement into SVGElement.
No new tests, no behavior change.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- svg/GradientAttributes.h:
- svg/SVGAllInOne.cpp:
- svg/SVGAnimateMotionElement.cpp:
- svg/SVGAnimateMotionElement.h:
- svg/SVGAnimatedTypeAnimator.cpp: Added.
(WebCore::SVGElementAnimatedProperties::SVGElementAnimatedProperties):
(WebCore::SVGAnimatedTypeAnimator::SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::~SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedTypeAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
- svg/SVGAnimatedTypeAnimator.h:
- svg/SVGAnimationElement.h:
- svg/SVGCursorElement.cpp:
- svg/SVGDocumentExtensions.h:
- svg/SVGElement.cpp:
- svg/SVGElementInstanceList.cpp:
- svg/SVGElementInstanceList.h:
- svg/SVGElementRareData.h:
- svg/SVGFEImageElement.cpp:
- svg/SVGFilterElement.cpp:
- svg/SVGFitToViewBox.h:
- svg/SVGFontData.cpp:
- svg/SVGFontData.h:
- svg/SVGFontElement.h:
- svg/SVGForeignObjectElement.cpp:
- svg/SVGGlyphMap.h:
- svg/SVGGradientElement.cpp:
- svg/SVGMPathElement.cpp:
- svg/SVGMPathElement.h:
- svg/SVGPathBlender.cpp:
- svg/SVGPathBlender.h:
- svg/SVGPathBuilder.cpp:
- svg/SVGPathBuilder.h:
- svg/SVGPathParser.cpp:
- svg/SVGPathParser.h:
- svg/SVGPathSegListBuilder.h:
- svg/SVGPathTraversalStateBuilder.cpp:
- svg/SVGPathTraversalStateBuilder.h:
- svg/SVGPathUtilities.h:
- svg/SVGPatternElement.cpp:
- svg/SVGPointList.h:
- svg/SVGScriptElement.cpp:
- svg/SVGStyledElement.h:
- svg/SVGTests.h:
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.cpp:
- svg/SVGTransformable.h:
- svg/SVGURIReference.cpp:
- svg/SVGURIReference.h:
- svg/SVGVKernElement.cpp:
- svg/SVGVKernElement.h:
- svg/SVGZoomAndPan.h:
- svg/properties/SVGAnimatedProperty.cpp: Added.
(WebCore::SVGAnimatedProperty::SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::commitChange):
(WebCore::SVGAnimatedProperty::animatedPropertyCache):
- svg/properties/SVGAnimatedProperty.h:
- svg/properties/SVGAnimatedPropertyMacros.h:
(WebCore::SVGSynchronizableAnimatedProperty::synchronize):
- svg/properties/SVGAnimatedStaticPropertyTearOff.h:
- svg/properties/SVGListProperty.h:
- 3:39 PM Changeset in webkit [152552] by
-
- 3 edits in trunk/Source/WebCore
Fix build against GTK+ 2.0
https://bugs.webkit.org/show_bug.cgi?id=117895
Patch by Dominique Leuenberger <dimstar@opensuse.org> on 2013-07-10
Reviewed by Martin Robinson.
GTK2 build fails for undefined GDK_IS_X11_DISPLAY
GTK 2.0 does define GDK_WINDOWING_X11,but GDK_IS_X11_DISPLAY is not
present in GTK+ 2.0. A dummy defines is sufficient, as GTK 2.0 is not
that multiple backend aware anyway...
- platform/gtk/GtkVersioning.h: Define GDK_IS_X11_DISPLAY for GTK+ 2.0 and compatibility for gtk_widget_get_preferred_size()
- plugins/gtk/gtk2xtbin.c: Include config.h
- 2:40 PM Changeset in webkit [152551] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152539. <rdar://problem/14286390>
- 2:37 PM Changeset in webkit [152550] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152548. <rdar://problem/14286329>
- 2:34 PM Changeset in webkit [152549] by
-
- 3 edits2 copies in branches/safari-537-branch
Merged r152541. <rdar://problem/14262126>
- 2:15 PM Changeset in webkit [152548] by
-
- 2 edits in trunk/Source/WebCore
Deferring layer flushes can cause painting without layout being done
https://bugs.webkit.org/show_bug.cgi?id=118493
Reviewed by Simon Fraser.
r147797 added a mechanism for the TileController to inform RenderLayerCompositor
that it had performed an action (setNeedsDisplay, etc.) that would cause CoreAnimation
to call back into us to paint in this runloop, and that it shouldn't throttle the next
layer flush.
However, if tiles were created and left unparented (because the TileController was
out-of-window), when they are later parented, we failed to inform RenderLayerCompositor
that they were about to call back for painting, and so it would happily throttle the
next layer flush, and layout would be out of date, and garbage and corruption could result.
To resolve this, rework the logic surrounding parenting existing-but-unparented tiles
to ensure that they get added to the TileController's dirtyRect.
No new tests; the bug only reproduces under specific timing circumstances, and
manifests itself as an assertion failure or garbage on the screen, so it's quite
hard to make a workable test.
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::revalidateTiles):
- Factor out the code to parent unparented tiles so that it is shared between the
created-new-tile and reparenting-existing-tile cases.
- Keep track of whether we updated the frame of a pre-existing tile.
- If the tile is dirty and needed to be parented (because either it's new
or hadn't been parented before), add it to the dirty rect list.
- If the tile changed size, add it to the dirty rect list.
(WebCore::TileController::ensureTilesForRect):
Ditto everything from revalidateTiles.
(WebCore::TileController::createTileLayer):
- Explicitly mark fresh tiles as needing display, so that we can depend on
[WebTileLayer needsDisplay] in revalidateTiles to tell us that it's dirty.
- 2:03 PM Changeset in webkit [152547] by
-
- 9 edits2 adds in trunk
[Mac] every enabled text track should be listed in the track menu
https://bugs.webkit.org/show_bug.cgi?id=118477
Reviewed by Jer Noble.
Source/WebCore:
Test: media/video-controls-captions-trackmenu-includes-enabled-track.html
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Don't select the
"Off" menu item if a track is enabled.
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu): Always include a track
that is showing in the menu. Add more diagnostic logging.
LayoutTests:
- media/trackmenu-test.js: Add some new utility functions.
- media/video-controls-captions-trackmenu-includes-enabled-track-expected.txt: Added.
- media/video-controls-captions-trackmenu-includes-enabled-track.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 1:46 PM Changeset in webkit [152546] by
-
- 2 edits in branches/safari-537-branch/Source/WTF
Merged r152429. <rdar://problem/14341205>
- 1:44 PM Changeset in webkit [152545] by
-
- 2 edits in branches/safari-537-branch/Source/WTF
Merged r152427. <rdar://problem/14341205>
- 1:40 PM Changeset in webkit [152544] by
-
- 7 edits in branches/safari-537-branch/Source
Merged r152426. <rdar://problem/14341205>
- 1:40 PM Changeset in webkit [152543] by
-
- 16 edits2 deletes in trunk
Remove ElementTimeControl and expose SVGAnimationElement
https://bugs.webkit.org/show_bug.cgi?id=118349
Reviewed by Rob Buis.
Source/WebCore:
Remove ElementTimeControl IDL interface and move its attributes
to the SVGAnimationElement IDL interface as per the latest SVG2
specification:
https://svgwg.org/svg2-draft/animate.html#InterfaceSVGAnimationElement
Also remove [NoInterfaceObject] IDL extended attribute from
SVGAnimationElement as it is not present in the specification.
This is one step towards removing IDL multiple inheritance in SVG and
complying with the latest SVG2 specification.
No new tests, covered by existing test cases.
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorObjC.pm:
- svg/ElementTimeControl.h: Removed.
- svg/ElementTimeControl.idl: Removed.
- svg/SVGAnimationElement.h:
- svg/SVGAnimationElement.idl:
LayoutTests:
Rebaseline several test cases now that SVGAnimationElement is exposed
on the global Window object.
- fast/js/global-constructors-attributes-expected.txt:
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- platform/qt/fast/js/global-constructors-attributes-expected.txt:
- svg/custom/global-constructors-expected.txt:
- 1:31 PM Changeset in webkit [152542] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: "Always enable" profiling does not work
https://bugs.webkit.org/show_bug.cgi?id=118487
Enable profiler when loading panel if profiler is enabled in inspector
settings.
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-07-10
Reviewed by Timothy Hatcher.
- inspector/front-end/ProfilesPanel.js:
- 12:30 PM Changeset in webkit [152541] by
-
- 3 edits2 adds in trunk
HTMLPluginElement's state should be Playing before firing mouse click event.
https://bugs.webkit.org/show_bug.cgi?id=118398.
<rdar://problem/14262126>
Reviewed by Dean Jackson.
Test: plugins/snapshotting/plugin-receives-click-event.html
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired):
The defaultEventHandler returns early if the state is not Playing.
This is because we only want the plugin to deal with user interaction normally if the
plugin is actually enabled (not being snapshotted).
When we click on the snapshotted plugin to start it, we mimic what would happen to the plugin
normally by dispatching another click event on top of where we just clicked.
However, we were sending the click event before setting the state to Playing which meant that our
simulated click was not being handled.
We should be setting this state before sending the click, not after.
- platform/mac-wk2/plugins/snapshotting/plugin-receives-click-event-expected.txt: Added.
- plugins/snapshotting/plugin-receives-click-event.html: Added.
- 11:42 AM Changeset in webkit [152540] by
-
- 2 edits in trunk/Source/WebCore
Fix a bug in MediaStreamDescriptor::removeVideoComponent
https://bugs.webkit.org/show_bug.cgi?id=118446
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-07-10
Reviewed by Eric Carlson.
MediaStreamDescriptor::removeVideoComponent is currently trying to
remove the 'videoComponent' from the wrong vector.
- platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::removeVideoComponent):
- 11:34 AM Changeset in webkit [152539] by
-
- 2 edits in trunk/Source/WebKit2
Some Java plugin instances can deadlock with the WebProcess on NPP_Destroy.
<rdar://problem/14286390> and https://bugs.webkit.org/show_bug.cgi?id=118535
Reviewed by Alexey Proskuryakov.
- Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::~NPObjectProxy): ASSERT this is the main thread.
(WebKit::NPObjectProxy::NP_Deallocate): If this isn't the main thread, call it again on the main thread.
- 10:02 AM Changeset in webkit [152538] by
-
- 6 edits in branches/dfgFourthTier
Merged from http://svn.webkit.org/repository/webkit/trunk
r146831 | mark.lam@apple.com | 2013-03-25 17:36:18 -0700 (Mon, 25 Mar 2013) | 19 lines
Offlineasm cloop backend compiles op+branch incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=113146.
- dfg/DFGRepatch.h:
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
- llint/LLIntOfflineAsmConfig.h:
- offlineasm/cloop.rb:
- 9:20 AM Changeset in webkit [152537] by
-
- 10 edits in trunk
AX: Allow requesting the full plain text for an object with textUnderElement()
https://bugs.webkit.org/show_bug.cgi?id=105214
Reviewed by Chris Fleizach.
Source/WebCore:
Allow specifying different function modes for textUnderElement(),
so we can effectively ask for the "normal" result (e.g to retrieve
test to be exposed as the 'title') or for the full text under the
element (without omitting any child in the subtree). This is
needed for the implementation of atk_text_get_text() in GTK/EFL.
- accessibility/AccessibilityObject.h: Add new enumeration to
specify the different modes for textUnderElement().
(WebCore::AccessibilityObject::textUnderElement): Added parameter.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::shouldUseAccessiblityObjectInnerText): Always return
'true' when using the "include all children" mode.
(WebCore::AccessibilityNodeObject::textUnderElement): Updated call
to shouldUseAccessiblityObjectInnerText().
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement): Removed
GTK specific code and expand the usage of text iterators beyond
text render objects, using it also when in the "include all
children" mode.
- accessibility/AccessibilityRenderObject.h:
- accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::getLengthForTextRange): Updated
call to textUnderElement(), preserving the previous behavior.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetText): Updated call to textUnderElement(),
using the "include all children" mode.
LayoutTests:
Removed tests that are not longer expected to fail.
- platform/gtk/TestExpectations: Removed tests.
- 8:52 AM Changeset in webkit [152536] by
-
- 2 edits in trunk/Source/WebKit/mac
Remove some dead code from WebNSURLExtras _web_hostString
https://bugs.webkit.org/show_bug.cgi?id=118519
Reviewed by Anders Carlsson.
- Misc/WebNSURLExtras.mm:
(-[NSURL _web_hostString]):
NSString initWithData:encoding: does not throw an exception when passing nil for the data, so
just delete the code that wasn't being run.
- 7:38 AM Changeset in webkit [152535] by
-
- 2 edits in trunk/Websites/planet.webkit.org
[Planet WebKit] Remove my website from the list of feeds
https://bugs.webkit.org/show_bug.cgi?id=118510
Reviewed by Andreas Kling.
With various awesome folks at Apple having taken over the Last
Week in WebKit series and my blog now featuring Last Week in
Blink, there's no reason for it to be included on the Planet
anymore.
- config.ini:
- 6:57 AM Changeset in webkit [152534] by
-
- 4 edits in trunk/Source
Remove the meshType from CoordinatedCustomFilterOperation
https://bugs.webkit.org/show_bug.cgi?id=118529
Patch by Sergio Correia <Sergio Correia> on 2013-07-10
Reviewed by Noam Rosenthal.
Following the removal of the meshType from CustomFilterOperation in r149153,
remove also the meshType from CoordinatedCustomFilterOperation.
No new tests, no new functionality.
Source/WebCore:
- platform/graphics/texmap/coordinated/CoordinatedCustomFilterOperation.h:
(WebCore::CoordinatedCustomFilterOperation::create): Remove unused meshType parameter.
(WebCore::CoordinatedCustomFilterOperation::CoordinatedCustomFilterOperation): Ditto.
Ditto.
Source/WebKit2:
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode): Remove dead comment.
(CoreIPC::::decode): Remove meshType from CoordinatedCustomFilterOperation
call.
- 3:05 AM Changeset in webkit [152533] by
-
- 4 edits4 deletes in trunk/LayoutTests
[GTK] Unreviewed gardening. Update new baselines after r152494 and r152478
https://bugs.webkit.org/show_bug.cgi?id=118527
Unreviewed GTK gardening
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-10
- platform/gtk/editing/deleting/delete-br-002-expected.txt: Updated after r152478.
- platform/gtk/editing/execCommand/outdent-blockquote-test1-expected.txt: Removed to pick general one after r152494.
- platform/gtk/editing/execCommand/outdent-blockquote-test2-expected.txt: Ditto.
- platform/gtk/editing/execCommand/outdent-blockquote-test3-expected.txt: Ditto.
- platform/gtk/editing/execCommand/outdent-blockquote-test4-expected.txt: Ditto.
- platform/gtk/fast/events/remove-target-with-shadow-in-drag-expected.txt: Updated after r152494.
- platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt: Updated after r152494.
- 1:57 AM Changeset in webkit [152532] by
-
- 7 edits in trunk
AX: AccessibilityNodeObject::supportsRequiredAttribute() should switch on CellRole
https://bugs.webkit.org/show_bug.cgi?id=117817
Patch by James Craig <james@cookiecrook.com> on 2013-07-10
Reviewed by Chris Fleizach.
Source/WebCore:
CellRole supports the required attribute now for accessibility, according to ARIA spec.
Updated existing test coverage.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::supportsRequiredAttribute):
LayoutTests:
CellRole supports the required attribute now for accessibility, according to ARIA spec.
- platform/mac/accessibility/table-attributes-expected.txt:
- platform/mac/accessibility/table-cell-spans-expected.txt:
- platform/mac/accessibility/table-cells-expected.txt:
- platform/mac/accessibility/table-sections-expected.txt:
- 1:46 AM Changeset in webkit [152531] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r151957): WebGL textures do not show
https://bugs.webkit.org/show_bug.cgi?id=118464
Reviewed by Christophe Dumez.
After r151957 decoder.frameIsCompleteAtIndex(0) doesn't trigger image decoding,
we have to call decoder.createFrameAtIndex(0) explicitly to ensure it.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- 1:41 AM Changeset in webkit [152530] by
-
- 3 edits in trunk/Tools
[GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
https://bugs.webkit.org/show_bug.cgi?id=118509
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-10
Reviewed by Martin Robinson.
In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
when trying to remove an event already removed, if another event is
processed in the middle. By using a Deque's takeFirst, we ensure the
element is removed before we dispatch it.
fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
crashes after this fix is added.
- WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
- WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
from the queue.
- 1:36 AM Changeset in webkit [152529] by
-
- 2 edits in trunk/Source/WTF
Workaround for x86 optimizer bug in MSVC 2012.
https://bugs.webkit.org/show_bug.cgi?id=118478
Reviewed by Benjamin Poulain.
This is a workaround for a bug in the x86 MSVC 2012 optimizer.
The problem is that the range comparison gets optimized out when
the templated inline function toASCIIUpper. Copying the methods
content fixes the problem.
This is unfortunately not the nicest fix, but the alternative would
be to turn off optimization for StringImpl::upper on the x86 MSVC 2012
build, which might impact overall performance negatively.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::upper):
- 1:13 AM Changeset in webkit [152528] by
-
- 1 edit4 deletes in trunk/LayoutTests
[Qt] Unreviewed gardening.
Remove platform specific expetations after r152494 because the generic is good for Qt.
- platform/qt/editing/execCommand/outdent-blockquote-test1-expected.txt: Removed after r152494.
- platform/qt/editing/execCommand/outdent-blockquote-test2-expected.txt: Removed after r152494.
- platform/qt/editing/execCommand/outdent-blockquote-test3-expected.txt: Removed after r152494.
- platform/qt/editing/execCommand/outdent-blockquote-test4-expected.txt: Removed after r152494.
- 12:41 AM Changeset in webkit [152527] by
-
- 2 edits in trunk/Source/WebCore
Change recently ratified extensions prefixes from WEBKIT_WEBGL_ to WEBGL_
https://bugs.webkit.org/show_bug.cgi?id=117786
Patch by Karol Świniarski <k.swiniarsk2@samsung.com> on 2013-07-10
Reviewed by Dean Jackson.
According to WebGL's revision 10, extensions should be named: WEBGL_lose_context,
WEBGL_depth_texture, WEBGL_compressed_texture_s3tc.
No new tests. Covered by existing tests:
LayoutTests/webgl/conformance/extensions/get-extension.html
LayoutTests/webgl/conformance/context/context-lost.html
LayoutTests/webgl/conformance/extensions/webgl-depth-texture.html
LayoutTests/webgl/conformance/extensions/webgl-compressed-texture-s3tc.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
Jul 9, 2013:
- 11:55 PM Changeset in webkit [152526] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::SVGImageElement):
- 11:10 PM Changeset in webkit [152525] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] tooltip callback doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=118522
Reviewed by Christophe Dumez.
Add missing code to connect didChangeTooltip callback.
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::ViewClientEfl):
- 10:31 PM Changeset in webkit [152524] by
-
- 13 edits in trunk/Source/WebCore
Introduce isSVGFontElement() and isSVGImageElement(), use them
https://bugs.webkit.org/show_bug.cgi?id=118504
Reviewed by Benjamin Poulain.
Let's use isFoo() to enhance readibility in svg element classes along with html's.
No new tests, there is no behavior changes.
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::getSVGFontById):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absoluteImageURL):
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
- svg/SVGElement.cpp:
(WebCore::SVGElement::viewportElement):
- svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::SVGFontElement):
- svg/SVGFontElement.h:
(WebCore::toSVGFontElement):
(WebCore::isSVGFontElement):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::associatedFontElement):
(WebCore::SVGFontFaceElement::rebuildFontFace):
- svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::invalidateGlyphCache):
- svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::SVGImageElement):
- svg/SVGImageElement.h:
(WebCore::toSVGImageElement):
(WebCore::isSVGImageElement):
- svg/SVGLocatable.cpp:
(WebCore::isViewportElement):
- svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):
- 8:32 PM Changeset in webkit [152523] by
-
- 10 edits in trunk
[EFL] Add ewk_view_device_pixel_ratio_set
https://bugs.webkit.org/show_bug.cgi?id=118521
Reviewed by Gyuyoung Kim.
Source/WebCore:
No new tests, covered by existing tests.
- dom/ViewportArguments.cpp: Remove PLATFORM(EFL) not to use deprecatedTargetDPI
- dom/ViewportArguments.h: Ditto.
- platform/efl/EflScreenUtilities.cpp: Removed getDPI() which is not used anymore.
- platform/efl/EflScreenUtilities.h: Ditto.
Source/WebKit/efl:
ewebkit and ewebkit2 have different approach about getting device pixel ratio.
ewebkit depends on deprecatedTargetDPI and ecore_x_dpi_get,
but ewebkit2 use Page::deviceScaleFactor.
This patch will add ewk_view_device_pixel_ratio_set and use Page::deviceScaleFactor()
instead of ViewportArguments::deprecatedTargetDPI like ewebkit2.
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(_ewk_view_viewport_attributes_compute): Use Page::deviceScaleFactor().
(ewk_view_viewport_attributes_get): Ditto.
(ewk_view_device_pixel_ratio_set): Added.
(ewk_view_device_pixel_ratio_get):
- ewk/ewk_view.h:
Update document of ewk_view_device_pixel_ratio_get (from ewebkit2) and
added ewk_view_device_pixel_ratio_set.
Tools:
- EWebLauncher/main.c: Added new option(-r) to test device pixel ratio.
(windowCreate):
(parseUserArguments):
- 5:39 PM Changeset in webkit [152522] by
-
- 5 edits in trunk
@readonly and @aria-readonly="false" are not exposed correctly to accessibility
https://bugs.webkit.org/show_bug.cgi?id=118475
Patch by James Craig <james@cookiecrook.com> on 2013-07-09
Reviewed by Chris Fleizach.
Source/WebCore:
Account for implicit and explicit @readonly/@aria-readonly mismatches. Updated existing test coverage.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetValueAttribute):
LayoutTests:
Updated existing test to account for implicit and explicit @readonly/@aria-readonly mismatches.
- accessibility/aria-readonly-expected.txt:
- accessibility/aria-readonly.html:
- 4:18 PM Changeset in webkit [152521] by
-
- 2 edits in trunk/Tools
Unreviewed change of my email addresses.
https://bugs.webkit.org/show_bug.cgi?id=100122
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2013-07-09
- Scripts/webkitpy/common/config/contributors.json:
- 3:58 PM Changeset in webkit [152520] by
-
- 16 edits in trunk/Source
Reviewed by Simon Fraser.
Source/WebCore:
Remember the scroll position and restore after exiting full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=61956
No new tests, adds a client callback used by WebKit and WebKit2 win.
- platform/graphics/win/FullScreenController.cpp:
(FullScreenController::enterFullScreen):
(FullScreenController::exitFullScreen):
- platform/graphics/win/FullScreenControllerClient.h:
Source/WebKit/mac:
Remember the scroll position and restore after exiting full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=61956
<rdar://problem/9544461>
Call into the main FrameView to save the scroll position before swapping the
WebView into the full-screen window, and restore the scroll position after
swapping the WebView back into the browser window.
- WebView/WebFullScreenController.h:
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController windowDidEnterFullscreen:]): Save the scroll position.
(-[WebFullScreenController exitFullscreen]): Restore the scroll position.
Source/WebKit/win:
Remember the scroll position and restore after exiting full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=61956
Add support for two new FullScreenClient callbacks for saving and restoring the
scroll position of the full-screen frame.
- WebView.cpp:
(WebView::fullScreenClientSaveScrollPosition):
(WebView::fullScreenClientRestoreScrollPosition):
- WebView.h:
Source/WebKit2:
Remember the scroll position and restore after exiting full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=61956
<rdar://problem/9544461>
Call into the main FrameView to save the scroll position before swapping the
WebView into the full-screen window, and restore the scroll position after
swapping the WebView back into the browser window.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController beganExitFullScreenAnimation]):
In WebKit2, this requires some communication between the WebProcess and the
UIProcess, so add two new messages to WebFullScreenManager to be called by
its proxy.
- UIProcess/WebFullScreenManagerProxy.h:
- UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::saveScrollPosition):
(WebKit::WebFullScreenManagerProxy::restoreScrollPosition):
- WebProcess/FullScreen/WebFullScreenManager.h:
- WebProcess/FullScreen/WebFullScreenManager.messages.in:
- WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::saveScrollPosition):
(WebKit::WebFullScreenManager::restoreScrollPosition):
- 3:47 PM Changeset in webkit [152519] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Skip cache partitioning tests, as cache partitioning is not supported on Lion
<rdar://problem/14391816>
- platform/mac-lion/TestExpectations:
- 3:08 PM Changeset in webkit [152518] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152514. <rdar://problem/14391944>
- 3:06 PM Changeset in webkit [152517] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152513. <rdar://problem/14391944>
- 2:55 PM Changeset in webkit [152516] by
-
- 2 edits in branches/safari-537-branch/Source/JavaScriptCore
Merged r152497. <rdar://problem/14241573>
- 2:49 PM Changeset in webkit [152515] by
-
- 44 edits3 copies in branches/safari-537-branch
Merged r152494. <rdar://problem/14241573>
- 2:00 PM Changeset in webkit [152514] by
-
- 2 edits in trunk/Source/WebCore
AuthenticationMac.mm does not handle NSURLAuthenticationMethodNegotiate in WebCore::mac()
https://bugs.webkit.org/show_bug.cgi?id=118518
Reviewed by Alexey Proskuryakov.
- platform/network/mac/AuthenticationMac.mm:
(WebCore::mac):
Map ProtectionSpaceAuthenticationSchemeNegotiate to NSURLAuthenticationMethodNegotiate.
- 1:17 PM Changeset in webkit [152513] by
-
- 2 edits in trunk/Source/WebCore
AuthenticationMac.mm does not handle NSURLAuthenticationMethodNegotiate
https://bugs.webkit.org/show_bug.cgi?id=118517
Reviewed by Brady Eidson.
- platform/network/mac/AuthenticationMac.mm:
(WebCore::core):
Map "NSURLAuthenticationMethodNegotiate" to ProtectionSpaceAuthenticationSchemeNegotiate.
- 12:01 PM Changeset in webkit [152512] by
-
- 9 edits2 copies in branches/safari-537-branch
Merged r152453. <rdar://problem/14291428>
- 11:54 AM Changeset in webkit [152511] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152434. <rdar://problem/14366772>
- 11:49 AM Changeset in webkit [152510] by
-
- 4 edits in branches/safari-537-branch
Merged r152433. <rdar://problem/14366120>
- 11:41 AM Changeset in webkit [152509] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152430. <rdar://problem/13881024>
- 11:37 AM Changeset in webkit [152508] by
-
- 24 edits1 copy in branches/safari-537-branch
Merged r152425. <rdar://problem/14120323>
- 11:30 AM Changeset in webkit [152507] by
-
- 3 edits2 copies in branches/safari-537-branch
Merged r152424. <rdar://problem/14364906>
- 11:27 AM Changeset in webkit [152506] by
-
- 5 edits2 copies in branches/safari-537-branch
Merged r152422. <rdar://problem/13834460>
- 11:21 AM Changeset in webkit [152505] by
-
- 3 edits in branches/safari-537-branch/Source/WebKit2
Merged r152407. <rdar://problem/13893308>
- 11:17 AM UsingGitWithWebKit edited by
- Substitute "Tools/Scripts" for "path/to" in git config core.editor … (diff)
- 11:17 AM Changeset in webkit [152504] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152403. <rdar://problem/14155051>
- 11:14 AM Changeset in webkit [152503] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152383. <rdar://problem/14351106>
- 11:07 AM Changeset in webkit [152502] by
-
- 13 edits in branches/safari-537-branch/Source
Merged r152382. <rdar://problem/14105490>
- 11:03 AM Changeset in webkit [152501] by
-
- 3 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r152380. <rdar://problem/14340027>
- 11:00 AM Changeset in webkit [152500] by
-
- 6 edits in branches/safari-537-branch/Source
Merged r152348. <rdar://problem/13936550>
- 10:56 AM Changeset in webkit [152499] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152324. <rdar://problem/14337442>
- 10:48 AM Changeset in webkit [152498] by
-
- 5 edits2 adds in trunk/Tools
DumpRenderTree should stop sending unsupported URLs to NSWorkspace
https://bugs.webkit.org/show_bug.cgi?id=118514
<rdar://problem/13686836>
Reviewed by Sam Weinig.
Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
- DumpRenderTree/DefaultPolicyDelegate.h: Added.
- DumpRenderTree/DefaultPolicyDelegate.m: Added.
(-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
- DumpRenderTree/mac/DumpRenderTree.mm:
(allocateGlobalControllers):
Allocate a DefaultPolicyDelegate object.
(resetWebViewToConsistentStateBeforeTesting):
Set the policy delegate to the default policy delegate.
- DumpRenderTree/mac/DumpRenderTreeMac.h:
Declare the defaultPolicyDelegate object.
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setCustomPolicyDelegate):
Set the policy delegate to the default delegate if setDelegate is false.
- 10:34 AM Changeset in webkit [152497] by
-
- 2 edits in trunk/Source/JavaScriptCore
Gardening to unbreak builds on the Windows bot.
Not reviewed.
- parser/ParserTokens.h:
- 10:30 AM Changeset in webkit [152496] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
PrettyPatch doesn't handle UTF-8 characters correctly
https://bugs.webkit.org/show_bug.cgi?id=45760
Reviewed by Adam Roben.
- PrettyPatch/PrettyPatch.rb: Since the diff lines are typically in UTF-8 and the results
of PrettyPatch may be served by a web server or not (for instance when accessed via
webkit-patch pretty-diff), we should use a meta tag to force the page encoding to UTF-8.
- 9:22 AM Changeset in webkit [152495] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=106558
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-09
Reviewed by Brent Fulgham.
On Windows, dispatch.h needs to be included before certain CFNetwork headers.
- WebCorePrefix.h: Include dispatch.h.
- 9:15 AM Changeset in webkit [152494] by
-
- 44 edits3 adds in trunk
Fix 30% JSBench regression (caused by adding column numbers to stack traces).
https://bugs.webkit.org/show_bug.cgi?id=118481.
Reviewed by Mark Hahnenberg and Geoffrey Garen.
Source/JavaScriptCore:
Previously, we already capture ExpressionRangeInfo that provides a divot for
each bytecode that can potentially throw an exception (and therefore generate
a stack trace). On first attempt to compute column numbers, we then do a walk
of the source string to record all line start positions in a table associated
with the SourceProvider. The column number can then be computed as
divot - lineStartFor(bytecodeOffset).
The computation of this lineStarts table is the source of the 30% JSBench
performance regression.
The new code now records lineStarts as the lexer and parser scans the source
code. These lineStarts are then used to compute the column number for the
given divot, and stored in the ExpressionRangeInfo. Similarly, we also capture
the line number at the divot point and store that in the ExpressionRangeInfo.
Hence, to look up line and column numbers, we now lookup the ExpressionRangeInfo
for the bytecodeOffset, and then compute the line and column from the values
stored in the expression info.
The strategy:
- We want to minimize perturbations to the lexer and parser. Specifically, the changes added should not change how it scans code, and generate bytecode.
- We regard the divot as the source character position we are interested in. As such, we'll capture line and lineStart (for column) at the point when we capture the divot information. This ensures that the 3 values are consistent.
How the change is done:
- Change the lexer to track lineStarts.
- Change the parser to capture line and lineStarts at the point of capturing divots.
- Change the parser and associated code to plumb these values all the way to the point that the correspoinding ExpressionRangeInfo is emitted.
- Propagate and record SourceCode firstLine and firstLineColumnOffset to the the necessary places so that we can add them as needed when reifying UnlinkedCodeBlocks into CodeBlocks.
- Compress the line and column number values in the ExpressionRangeInfo. In practice, we seldom have both large line and column numbers. Hence, we can encode both in an uint32_t most of the time. For the times when we encounter both large line and column numbers, we have a fallback to store the "fat" position info.
- Emit an ExpressionRangeInfo for UnaryOp nodes to get more line and column number coverage.
- Change the interpreter to use the new way of computing line and column.
- Delete old line and column computation code that is now unused.
Misc details:
- the old lexer was tracking both a startOffset and charPosition where charPosition equals startOffset - SourceCode.startOffset. We now use startOffset exclusively throughout the system for consistency. All offset values (including lineStart) are relative to the start of the SourceProvider string. These values will only be converted to be relative to the SourceCode.startOffset at the very last minute i.e. when the divot is stored into the ExpressionRangeInfo.
This change to use the same offset system everywhere reduces confusion
from having to convert back and forth between the 2 systems. It also
enables a lot of assertions to be used.
- Also fixed some bugs in the choice of divot positions to use. For example, both Eval and Function expressions previously used column numbers from the start of the expression but used the line number at the end of the expression. This is now fixed to use either the start or end positions as appropriate, but not a mix of line and columns from both.
- Why use ints instead of unsigneds for offsets and lineStarts inside the lexer and parser? Some tests (e.g. fast/js/call-base-resolution.html and fast/js/eval-cross-window.html) has shown that lineStart offsets can be prior to the SourceCode.startOffset. Keeping the lexer offsets as ints simplifies computations and makes it easier to maintain the assertions that (startOffset >= lineStartOffset).
However, column and line numbers are always unsigned when we publish
them to the ExpressionRangeInfo. The ints are only used inside the
lexer and parser ... well, and bytecode generator.
- For all cases, lineStart is always captured where the divot is captured. However, some sputnik conformance tests have shown that we cannot honor line breaks for assignment statements like the following:
eval("x\u000A*=\u000A-1;");
In this case, the lineStart is expected to be captured at the start of
the assignment expression instead of at the divot point in the middle.
The assignment expression is the only special case for this.
This patch has been tested against the full layout tests both with release
and debug builds with no regression.
- API/JSContextRef.cpp:
(JSContextCreateBacktrace):
- Updated to use the new StackFrame::computeLineAndColumn().
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- Added m_firstLineColumnOffset initialization.
- Plumbed the firstLineColumnOffset into the SourceCode.
- Initialized column for op_debug using the new way.
(JSC::CodeBlock::lineNumberForBytecodeOffset):
- Changed to compute line number using the ExpressionRangeInfo.
(JSC::CodeBlock::columnNumberForBytecodeOffset): Added
- Changed to compute column number using the ExpressionRangeInfo.
(JSC::CodeBlock::expressionRangeForBytecodeOffset):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::firstLineColumnOffset):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
- Plumbed firstLineColumnOffset through to the super class.
(JSC::ProgramCodeBlock::ProgramCodeBlock):
- Plumbed firstLineColumnOffset through to the super class.
(JSC::EvalCodeBlock::EvalCodeBlock):
- Plumbed firstLineColumnOffset through to the super class. But for EvalCodeBlocks, the firstLineColumnOffset is always 1 because we're starting with a new source string with no start offset.
(JSC::FunctionCodeBlock::FunctionCodeBlock):
- Plumbed firstLineColumnOffset through to the super class.
- bytecode/ExpressionRangeInfo.h:
- Added modes for encoding line and column into a single 30-bit
unsigned. The encoding is in 1 of 3 modes:
- FatLineMode: 22-bit line, 8-bit column
- FatColumnMode: 8-bit line, 22-bit column
- FatLineAndColumnMode: 32-bit line, 32-bit column
- Added modes for encoding line and column into a single 30-bit
unsigned. The encoding is in 1 of 3 modes:
(JSC::ExpressionRangeInfo::encodeFatLineMode): Added.
- Encodes line and column into the 30-bit position using FatLine mode.
(JSC::ExpressionRangeInfo::encodeFatColumnMode): Added.
- Encodes line and column into the 30-bit position using FatColumn mode.
(JSC::ExpressionRangeInfo::decodeFatLineMode): Added.
- Decodes the FatLine mode 30-bit position into line and column.
(JSC::ExpressionRangeInfo::decodeFatColumnMode): Added.
- Decodes the FatColumn mode 30-bit position into line and column.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
- Plumbed startColumn through.
(JSC::UnlinkedFunctionExecutable::link):
- Plumbed startColumn through.
(JSC::UnlinkedCodeBlock::lineNumberForBytecodeOffset):
- Computes a line number using the new way.
(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):
- Added decoding of line and column.
- Added handling of the case when we do not find a fitting expression range info for a specified bytecodeOffset. This only happens if the bytecodeOffset is below the first expression range info. In that case, we'll use the first expression range info entry.
(JSC::UnlinkedCodeBlock::addExpressionInfo):
- Added encoding of line and column.
- bytecode/UnlinkedCodeBlock.h:
- Added m_expressionInfoFatPositions in RareData.
(JSC::UnlinkedFunctionExecutable::functionStartColumn):
(JSC::UnlinkedCodeBlock::shrinkToFit):
- Removed obsoleted m_lineInfo.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCall): Plumbed line and lineStart through.
(JSC::BytecodeGenerator::emitCallEval): Plumbed line and lineStart through.
(JSC::BytecodeGenerator::emitCallVarargs): Plumbed line and lineStart through.
(JSC::BytecodeGenerator::emitConstruct): Plumbed line and lineStart through.
(JSC::BytecodeGenerator::emitDebugHook): Plumbed lineStart through.
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitNode):
(JSC::BytecodeGenerator::emitNodeInConditionContext):
- Removed obsoleted m_lineInfo.
(JSC::BytecodeGenerator::emitExpressionInfo):
- Plumbed line and lineStart through.
- Compute the line and column to be added to the expression range info.
- bytecompiler/NodesCodegen.cpp:
(JSC::ThrowableExpressionData::emitThrowReferenceError):
(JSC::ResolveNode::emitBytecode):
(JSC::ArrayNode::toArgumentList):
(JSC::BracketAccessorNode::emitBytecode):
(JSC::DotAccessorNode::emitBytecode):
(JSC::NewExprNode::emitBytecode):
(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::PostfixNode::emitResolve):
(JSC::PostfixNode::emitBracket):
(JSC::PostfixNode::emitDot):
(JSC::DeleteResolveNode::emitBytecode):
(JSC::DeleteBracketNode::emitBytecode):
(JSC::DeleteDotNode::emitBytecode):
(JSC::PrefixNode::emitResolve):
(JSC::PrefixNode::emitBracket):
(JSC::PrefixNode::emitDot):
- Plumbed line and lineStart through the above as needed.
(JSC::UnaryOpNode::emitBytecode):
- Added emission of an ExpressionRangeInfo for the UnaryOp node.
(JSC::BinaryOpNode::emitStrcat):
(JSC::ThrowableBinaryOpNode::emitBytecode):
(JSC::InstanceOfNode::emitBytecode):
(JSC::emitReadModifyAssignment):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::AssignDotNode::emitBytecode):
(JSC::ReadModifyDotNode::emitBytecode):
(JSC::AssignBracketNode::emitBytecode):
(JSC::ReadModifyBracketNode::emitBytecode):
- Plumbed line and lineStart through the above as needed.
(JSC::ConstStatementNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
- Plumbed line and lineStart through the above as needed.
- interpreter/Interpreter.cpp:
(JSC::appendSourceToError):
- Added line and column arguments for expressionRangeForBytecodeOffset().
(JSC::StackFrame::computeLineAndColumn):
- Replaces StackFrame::line() and StackFrame::column().
(JSC::StackFrame::expressionInfo):
- Added line and column arguments.
(JSC::StackFrame::toString):
- Changed to use the new StackFrame::computeLineAndColumn().
(JSC::Interpreter::getStackTrace):
- Added the needed firstLineColumnOffset arg for the StackFrame.
- interpreter/Interpreter.h:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::BinaryOpInfo::BinaryOpInfo):
(JSC::ASTBuilder::AssignmentInfo::AssignmentInfo):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createBracketAccess):
(JSC::ASTBuilder::createDotAccess):
(JSC::ASTBuilder::createRegExp):
(JSC::ASTBuilder::createNewExpr):
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createLabelStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
(JSC::ASTBuilder::appendBinaryExpressionInfo):
(JSC::ASTBuilder::appendUnaryToken):
(JSC::ASTBuilder::unaryTokenStackLastStart):
(JSC::ASTBuilder::unaryTokenStackLastLineStartPosition): Added.
(JSC::ASTBuilder::assignmentStackAppend):
(JSC::ASTBuilder::createAssignment):
(JSC::ASTBuilder::setExceptionLocation):
(JSC::ASTBuilder::makeDeleteNode):
(JSC::ASTBuilder::makeFunctionCallNode):
(JSC::ASTBuilder::makeBinaryNode):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):.
- Plumbed line, lineStart, and startColumn through the above as needed.
- parser/Lexer.cpp:
(JSC::::currentSourcePtr):
(JSC::::setCode):
- Added tracking for sourceoffset and lineStart.
(JSC::::internalShift):
(JSC::::parseIdentifier):
- Added tracking for lineStart.
(JSC::::parseIdentifierSlowCase):
(JSC::::parseString):
- Added tracking for lineStart.
(JSC::::parseStringSlowCase):
(JSC::::lex):
- Added tracking for sourceoffset.
(JSC::::sourceCode):
- parser/Lexer.h:
(JSC::Lexer::currentOffset):
(JSC::Lexer::currentLineStartOffset):
(JSC::Lexer::setOffset):
- Added tracking for lineStart.
(JSC::Lexer::offsetFromSourcePtr): Added. conversion function.
(JSC::Lexer::sourcePtrFromOffset): Added. conversion function.
(JSC::Lexer::setOffsetFromSourcePtr):
(JSC::::lexExpectIdentifier):
- Added tracking for sourceoffset and lineStart.
- parser/NodeConstructors.h:
(JSC::Node::Node):
(JSC::ResolveNode::ResolveNode):
(JSC::EvalFunctionCallNode::EvalFunctionCallNode):
(JSC::FunctionCallValueNode::FunctionCallValueNode):
(JSC::FunctionCallResolveNode::FunctionCallResolveNode):
(JSC::FunctionCallBracketNode::FunctionCallBracketNode):
(JSC::FunctionCallDotNode::FunctionCallDotNode):
(JSC::CallFunctionCallDotNode::CallFunctionCallDotNode):
(JSC::ApplyFunctionCallDotNode::ApplyFunctionCallDotNode):
(JSC::PostfixNode::PostfixNode):
(JSC::DeleteResolveNode::DeleteResolveNode):
(JSC::DeleteBracketNode::DeleteBracketNode):
(JSC::DeleteDotNode::DeleteDotNode):
(JSC::PrefixNode::PrefixNode):
(JSC::ReadModifyResolveNode::ReadModifyResolveNode):
(JSC::ReadModifyBracketNode::ReadModifyBracketNode):
(JSC::AssignBracketNode::AssignBracketNode):
(JSC::AssignDotNode::AssignDotNode):
(JSC::ReadModifyDotNode::ReadModifyDotNode):
(JSC::AssignErrorNode::AssignErrorNode):
(JSC::WithNode::WithNode):
(JSC::ForInNode::ForInNode):
- Plumbed line and lineStart through the above as needed.
- parser/Nodes.cpp:
(JSC::StatementNode::setLoc): Plumbed lineStart.
(JSC::ScopeNode::ScopeNode): Plumbed lineStart.
(JSC::ProgramNode::ProgramNode): Plumbed startColumn.
(JSC::ProgramNode::create): Plumbed startColumn.
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode): Plumbed startColumn.
(JSC::FunctionBodyNode::create): Plumbed startColumn.
- parser/Nodes.h:
(JSC::Node::startOffset):
(JSC::Node::lineStartOffset): Added.
(JSC::StatementNode::firstLine):
(JSC::StatementNode::lastLine):
(JSC::ThrowableExpressionData::ThrowableExpressionData):
(JSC::ThrowableExpressionData::setExceptionSourceCode):
(JSC::ThrowableExpressionData::divotStartOffset):
(JSC::ThrowableExpressionData::divotEndOffset):
(JSC::ThrowableExpressionData::divotLine):
(JSC::ThrowableExpressionData::divotLineStart):
(JSC::ThrowableSubExpressionData::ThrowableSubExpressionData):
(JSC::ThrowableSubExpressionData::setSubexpressionInfo):
(JSC::ThrowableSubExpressionData::subexpressionDivot):
(JSC::ThrowableSubExpressionData::subexpressionStartOffset):
(JSC::ThrowableSubExpressionData::subexpressionEndOffset):
(JSC::ThrowableSubExpressionData::subexpressionLine):
(JSC::ThrowableSubExpressionData::subexpressionLineStart):
(JSC::ThrowablePrefixedSubExpressionData::ThrowablePrefixedSubExpressionData):
(JSC::ThrowablePrefixedSubExpressionData::setSubexpressionInfo):
(JSC::ThrowablePrefixedSubExpressionData::subexpressionDivot):
(JSC::ThrowablePrefixedSubExpressionData::subexpressionStartOffset):
(JSC::ThrowablePrefixedSubExpressionData::subexpressionEndOffset):
(JSC::ThrowablePrefixedSubExpressionData::subexpressionLine):
(JSC::ThrowablePrefixedSubExpressionData::subexpressionLineStart):
(JSC::ScopeNode::startStartOffset):
(JSC::ScopeNode::startLineStartOffset):
(JSC::ProgramNode::startColumn):
(JSC::EvalNode::startColumn):
(JSC::FunctionBodyNode::startColumn):
- Plumbed line and lineStart through the above as needed.
- parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
- Plumbed line and lineStart through the above as needed.
(JSC::::parseFunctionBody):
- Plumbed startColumn.
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::LabelInfo::LabelInfo):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseAssignmentExpression):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseMemberExpression):
(JSC::::parseUnaryExpression):
- Plumbed line, lineStart, startColumn through the above as needed.
- parser/Parser.h:
(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
(JSC::Parser::tokenStart):
(JSC::Parser::tokenColumn):
(JSC::Parser::tokenEnd):
(JSC::Parser::tokenLineStart):
(JSC::Parser::lastTokenLine):
(JSC::Parser::lastTokenLineStart):
(JSC::::parse):
- parser/ParserTokens.h:
(JSC::JSTokenLocation::JSTokenLocation):
- Plumbed lineStart.
(JSC::JSTokenLocation::lineStartPosition):
(JSC::JSTokenLocation::startPosition):
(JSC::JSTokenLocation::endPosition):
- parser/SourceCode.h:
(JSC::SourceCode::SourceCode):
(JSC::SourceCode::startColumn):
(JSC::makeSource):
(JSC::SourceCode::subExpression):
- parser/SourceProvider.cpp: delete old code.
- parser/SourceProvider.h: delete old code.
- parser/SourceProviderCacheItem.h:
(JSC::SourceProviderCacheItem::closeBraceToken):
(JSC::SourceProviderCacheItem::SourceProviderCacheItem):
- Plumbed lineStart.
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::makeFunctionCallNode):
(JSC::SyntaxChecker::makeAssignNode):
(JSC::SyntaxChecker::makePrefixNode):
(JSC::SyntaxChecker::makePostfixNode):
(JSC::SyntaxChecker::makeDeleteNode):
(JSC::SyntaxChecker::createResolve):
(JSC::SyntaxChecker::createBracketAccess):
(JSC::SyntaxChecker::createDotAccess):
(JSC::SyntaxChecker::createRegExp):
(JSC::SyntaxChecker::createNewExpr):
(JSC::SyntaxChecker::createAssignResolve):
(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createContinueStatement):
(JSC::SyntaxChecker::createWithStatement):
(JSC::SyntaxChecker::createLabelStatement):
(JSC::SyntaxChecker::createThrowStatement):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::appendBinaryExpressionInfo):
(JSC::SyntaxChecker::operatorStackPop):
- Made SyntaxChecker prototype changes to match ASTBuilder due to new args added for plumbing line, lineStart, and startColumn.
- runtime/CodeCache.cpp:
(JSC::CodeCache::generateBytecode):
(JSC::CodeCache::getCodeBlock):
- Plumbed startColumn.
- runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::fromGlobalCode):
- Plumbed startColumn.
- runtime/Executable.h:
(JSC::ScriptExecutable::startColumn):
(JSC::ScriptExecutable::recordParse):
(JSC::FunctionExecutable::create):
- Plumbed startColumn.
Source/WebCore:
Test: fast/js/line-column-numbers.html
Updated the bindings to use StackFrame::computeLineAndColumn(). The old
StackFrame::line() and StackFrame::column() has been removed. The new
algorithm always computes the 2 values together anyway. Hence it is more
efficient to return them as a pair instead of doing the same computation
twice for each half of the result.
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
(WebCore::createScriptCallStackFromException):
- bindings/js/ScriptSourceCode.h:
(WebCore::ScriptSourceCode::ScriptSourceCode):
LayoutTests:
The fix now computes line and column numbers more accurately. As a result,
some of the test results need to be re-baselined. Among other fixes, one
major source of difference is that the old code was incorrectly computing
0-based column numbers. This has now been fixed to be 1-based.
Note: line numbers were always 1-based.
Also added a new test: fast/js/line-column-numbers.html, which tests line
and column numbers for source code in various configurations.
- editing/execCommand/outdent-blockquote-test1-expected.txt:
- editing/execCommand/outdent-blockquote-test2-expected.txt:
- editing/execCommand/outdent-blockquote-test3-expected.txt:
- editing/execCommand/outdent-blockquote-test4-expected.txt:
- editing/pasteboard/copy-paste-float-expected.txt:
- editing/pasteboard/paste-blockquote-before-blockquote-expected.txt:
- editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt:
- fast/dom/Window/window-resize-contents-expected.txt:
- fast/events/remove-target-with-shadow-in-drag-expected.txt:
- fast/js/line-column-numbers-expected.txt: Added.
- fast/js/line-column-numbers.html: Added.
- fast/js/script-tests/line-column-numbers.js: Added.
(try.doThrow4b):
(doThrow5b.try.innerFunc):
(doThrow5b):
(doThrow6b.try.innerFunc):
(doThrow6b):
(catch):
(try.doThrow11b):
(try.doThrow14b):
- fast/js/stack-trace-expected.txt:
- inspector/console/console-url-line-column-expected.txt:
- 8:58 AM Changeset in webkit [152493] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-mac/TestExpectations: Skip failing test after r151546.
- 6:38 AM Changeset in webkit [152492] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk2/TestExpectations: Skip flaky svg tests.
- platform/qt-mac/TestExpectations: Skip failing CSS Shape tests.
- 4:31 AM Changeset in webkit [152491] by
-
- 6 edits in trunk/Source/WebCore
Use toSVGFontElement() instead of static_cast<SVGFontElement*>
https://bugs.webkit.org/show_bug.cgi?id=118496
Reviewed by Andreas Kling.
As a step to change static_cast with toXXX, static_cast<SVGFontElement*> can
be changed with toSVGFontElement().
Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=153761
- svg/SVGFontElement.h:
(WebCore::toSVGFontElement):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::rebuildFontFace):
- svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::invalidateGlyphCache):
- svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):
- svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):
- 4:21 AM WebKitGTK/Wayland edited by
- (diff)
- 3:56 AM Changeset in webkit [152490] by
-
- 5 edits in trunk/Source/WebCore
Remove support for [PassThisToCallback] extended attribute
https://bugs.webkit.org/show_bug.cgi?id=118391
Reviewed by Kentaro Hara.
The [PassThisToCallback] Webkit-specific IDL extended attribute is supported
by the JSC bindings generator but is no longer used. The attribute is not
even documented.
We can therefore drop support for this from the generator to simplify the
code.
No new tests, no behavior change.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::callbackRequiresThisToPass):
- bindings/scripts/test/TestCallback.idl:
- 2:59 AM Changeset in webkit [152489] by
-
- 12 edits4 adds in trunk
Update Exception handling in WebAudio.
https://bugs.webkit.org/show_bug.cgi?id=118405.
Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-07-09
Reviewed by Chris Rogers.
Source/WebCore:
AudioBufferSourceNode, OscillatorNode and AnalyserNode don't
propagate exception mentioned in WebAudio spec.
Code updated to throw DOM exception as expected.
Tests: webaudio/analyser-exception.html
webaudio/audiobuffersource-exception.html
- Modules/webaudio/AnalyserNode.cpp:
(WebCore::AnalyserNode::setFftSize):
(WebCore::AnalyserNode::setMinDecibels):
(WebCore::AnalyserNode::setMaxDecibels):
(WebCore::AnalyserNode::setSmoothingTimeConstant):
- Modules/webaudio/AnalyserNode.h:
- Modules/webaudio/AnalyserNode.idl:
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::startGrain):
(WebCore::AudioBufferSourceNode::noteGrainOn):
- Modules/webaudio/AudioBufferSourceNode.h:
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createBuffer):
(WebCore::AudioContext::createScriptProcessor):
(WebCore::AudioContext::createPeriodicWave):
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::start):
(WebCore::AudioScheduledSourceNode::stop):
(WebCore::AudioScheduledSourceNode::noteOn):
(WebCore::AudioScheduledSourceNode::noteOff):
- Modules/webaudio/AudioScheduledSourceNode.h:
- Modules/webaudio/OscillatorNode.idl:
LayoutTests:
New test cases to check exception handling in AnalyserNode and
AudioBufferSourceNode.
- webaudio/analyser-exception-expected.txt: Added.
- webaudio/analyser-exception.html: Added.
- webaudio/audiobuffersource-exception-expected.txt: Added.
- webaudio/audiobuffersource-exception.html: Added.
- 2:41 AM Changeset in webkit [152488] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaselining after r152479.
- platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:
- platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt:
- 2:01 AM Changeset in webkit [152487] by
-
- 1 copy in releases/WebKitGTK/webkit-2.1.3
Tagging the WebKitGTK+ 2.1.3 release
- 1:32 AM Changeset in webkit [152486] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- 1:29 AM Changeset in webkit [152485] by
-
- 4 edits in trunk
Unreviewed. Update NEWS and Versions.m4 for 2.1.3 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.1.3.
Jul 8, 2013:
- 11:46 PM Changeset in webkit [152484] by
-
- 2 edits in trunk/Tools
KURL unit test fixture class should have a meaningful name
https://bugs.webkit.org/show_bug.cgi?id=118467
Reviewed by Sam Weinig.
- TestWebKitAPI/Tests/WebCore/KURL.cpp:
(TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
instead of the generic and inappropriate 'WebCore' name.
- 10:39 PM Changeset in webkit [152483] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] webkit_set_cache_model is not turning the cache off
https://bugs.webkit.org/show_bug.cgi?id=118345
Reviewed by Gustavo Noronha Silva.
Our documentation says that WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER
disables the cache completely, but we are only setting the cache
capacities to 0. Cache capacities are not checked when resources
are added to the cache, but when it's pruned. To disable the cache
we need to call MemoryCache::setDisabled explicitly.
- webkit/webkitglobals.cpp:
(webkit_set_cache_model): Disable the cache when min dead, max
dead and total capacities are all set to 0.
- 10:21 PM Changeset in webkit [152482] by
-
- 2 edits in trunk
Add WebInspectorUI to WebKit.xcworkspace
https://bugs.webkit.org/show_bug.cgi?id=118491
Reviewed by Sam Weinig.
- WebKit.xcworkspace/contents.xcworkspacedata:
- 10:08 PM Changeset in webkit [152481] by
-
- 4 edits in branches/dfgFourthTier/Source/JavaScriptCore
NaturalLoops + Profiler = Crash
https://bugs.webkit.org/show_bug.cgi?id=118486
Reviewed by Geoffrey Garen.
I borked dominators in:
http://trac.webkit.org/changeset/152431/branches/dfgFourthTier/Source/JavaScriptCore/dfg/DFGDominators.h
This patch also adds some debug support, and fixes the loop that adds a block to
an already-existing natural loop. Note that we currently don't take that path in
most programs, but it will arise, for example if you use 'continue' - though you'd
have to use it rather cleverly since the bytecode will not jump to the loop header
in most uses of 'continue'.
- dfg/DFGDominators.cpp:
(JSC::DFG::Dominators::dump):
(DFG):
- dfg/DFGDominators.h:
(JSC::DFG::Dominators::dominates):
(Dominators):
- dfg/DFGNaturalLoops.cpp:
(JSC::DFG::NaturalLoops::compute):
- 8:22 PM Changeset in webkit [152480] by
-
- 4 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG::AbstractState::beginBasicBlock() should set m_haveStructures if any of the valuesAtHead have either a current known structure or a non-top/non-bottom array modes
https://bugs.webkit.org/show_bug.cgi?id=118489
Reviewed by Mark Hahnenberg.
- bytecode/ArrayProfile.h:
(JSC::arrayModesAreClearOrTop):
(JSC):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::beginBasicBlock):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::hasClobberableState):
(AbstractValue):
- 8:09 PM Changeset in webkit [152479] by
-
- 83 edits in trunk
[CSS Grid Layout] Rename grid-{rows|columns} to grid-definition-{rows|columns}
https://bugs.webkit.org/show_bug.cgi?id=103336
Reviewed by Tony Chang.
Source/WebCore:
Rename -webkit-grid-{rows|columns} to -webkit-grid-definition-{rows|columns}.
The latest version of the spec has renamed these properties.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Handle the new names.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Ditto.
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty): Ditto.
- css/CSSPropertyNames.in: Add support for the new names.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty): Handle the new names.
LayoutTests:
Update tests to reflect the rename of -webkit-grid-{rows|columns} to
-webkit-grid-definition-{rows|columns}.
- fast/css-grid-layout: Mass search and replace for the new name.
- 7:48 PM Changeset in webkit [152478] by
-
- 4 edits2 adds in trunk
DeleteSelectionCommand does not handle correctly deletion with two consecutive BR element.
https://bugs.webkit.org/show_bug.cgi?id=118457
<rdar://problem/14160912>
Reviewed by Simon Fraser.
Source/WebCore:
In DeleteSelectionCommand::handleSpecialCareBRDelete we did not
handle correctly the case where we had <br><br> in the markup and
nothing was being deleted. We should consider this like
the case where the <br> is on the line by itself and remove it.
Test: editing/deleting/delete-image-followed-by-two-br.html
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
LayoutTests:
- editing/deleting/delete-image-followed-by-two-br-expected.txt: Added.
- editing/deleting/delete-image-followed-by-two-br.html: Added.
- platform/mac/editing/deleting/delete-br-002-expected.txt: Rebased.
- 6:07 PM Changeset in webkit [152477] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
CheckArray should call the right version of filterArrayModes
https://bugs.webkit.org/show_bug.cgi?id=118488
Reviewed by Filip Pizlo.
Currently in the CFA CheckArray doesn't call the right filterArrayMode which can cause
the CFA to ignore when it sees a contradiction.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- 5:31 PM Changeset in webkit [152476] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152315. <rdar://problem/13895483>
- 5:30 PM Changeset in webkit [152475] by
-
- 3 edits in branches/safari-537-branch/LayoutTests
Updating fast/js/global-constructors-attributes.html results.
- fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- 5:28 PM Changeset in webkit [152474] by
-
- 6 edits3 copies in branches/safari-537-branch
Merged r152303. <rdar://problem/14301271>
- 5:20 PM Changeset in webkit [152473] by
-
- 14 edits in branches/safari-537-branch
Merged r152267. <rdar://problem/14205300>
- 4:47 PM Changeset in webkit [152472] by
-
- 8 edits1 copy in branches/safari-537-branch/Source
Merged r152052. <rdar://problem/14351519>
- 4:41 PM Changeset in webkit [152471] by
-
- 3 edits in branches/safari-537-branch/LayoutTests
Merge r152470.
2013-07-08 Alexey Proskuryakov <ap@apple.com>
[Mac] Multiple compositing/patterns test fail
https://bugs.webkit.org/show_bug.cgi?id=118490
- platform/mac/TestExpectations: The failures appear to be WK2 only in my testing, so moved the expectations to mac-wk2.
- platform/mac-wk2/TestExpectations: Updated bug numbers.
- 4:36 PM Changeset in webkit [152470] by
-
- 3 edits in trunk/LayoutTests
[Mac] Multiple compositing/patterns test fail
https://bugs.webkit.org/show_bug.cgi?id=118490
- platform/mac/TestExpectations: The failures appear to be WK2 only in my testing, so moved the expectations to mac-wk2.
- platform/mac-wk2/TestExpectations: Updated bug numbers.
- 4:32 PM Changeset in webkit [152469] by
-
- 3 edits2 deletes in branches/safari-537-branch
Rollout of r151510. <rdar://problem/14380353>
- 4:02 PM Changeset in webkit [152468] by
-
- 4 edits in branches/safari-537-branch/Source
Merged r152306. <rdar://problem/14284360>
- 3:57 PM Changeset in webkit [152467] by
-
- 2 edits in branches/safari-537-branch/Source/JavaScriptCore
Merged r152314. <rdar://problem/14165332>
- 2:24 PM Changeset in webkit [152466] by
-
- 14 edits2 adds in trunk
NamedFlowCollection getters should return undefined when there's no NamedFlow
https://bugs.webkit.org/show_bug.cgi?id=118463
Patch by Radu Stavila <stavila@adobe.com> on 2013-07-08
Reviewed by Christophe Dumez.
Source/WebCore:
Added new TreatReturnedNullObjectAs attribute for generated methods and set it to Undefined
for the item and namedItem methods of DOMNamedFlowCollection.
Test: fast/regions/webkit-named-flow-collection-undefined.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementationFunctionCall):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::treatReturnedNullObjectAsUndefined):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_treat_returned_null_object_as_undefined):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionTreatReturnedNullObjectAsUndefined):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj treatReturnedNullObjectAsUndefined]):
- bindings/scripts/test/TestObj.idl:
- dom/DOMNamedFlowCollection.idl:
LayoutTests:
Added test that validates that NamedFlowCollection getters return undefined
when no named flows exist.
- fast/regions/webkit-named-flow-collection-undefined-expected.txt: Added.
- fast/regions/webkit-named-flow-collection-undefined.html: Added.
- 2:05 PM Changeset in webkit [152465] by
-
- 3 edits in trunk/Source/WebCore
Remove unused variables in FocusCandidate.
https://bugs.webkit.org/show_bug.cgi?id=118449
Patch by Changhun Kang <temoochin@company100.net> on 2013-07-06
Reviewed by Antonio Gomes.
The variables for parent in FocusCandidate are not used anymore.
No new tests. No change in behavior.
- page/SpatialNavigation.cpp:
(WebCore::FocusCandidate::FocusCandidate):
- page/SpatialNavigation.h:
(WebCore::FocusCandidate::FocusCandidate):
- 2:03 PM Changeset in webkit [152464] by
-
- 2 edits in trunk/Source/WebCore
AX: iOS: SVG paths are not offset by the parent bounding box
https://bugs.webkit.org/show_bug.cgi?id=118433
The path for SVG shapes is in terms of its parent's view space. We need to offset
the path by that amount so that it's in the right location.
Reviewed by Tim Horton.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::elementPath):
- 1:02 PM Changeset in webkit [152463] by
-
- 3 edits in trunk/LayoutTests
fast/repaint/fixed-right-in-page-scale.html also crashing on Mountain Lion.
https://bugs.webkit.org/show_bug.cgi?id=118479
Moved expectation to higher-level mac and marked as [ Pass Crash ].
- platform/mac-lion/TestExpectations:
- platform/mac/TestExpectations:
- 12:46 PM Changeset in webkit [152462] by
-
- 2 edits in trunk/LayoutTests
Mark fast/text/international/synthesized-italic-vertical-latin.html as failing on Lion.
https://bugs.webkit.org/show_bug.cgi?id=118480
Unreviewed TestExpectation change.
- platform/mac-lion/TestExpectations:
Mark fast/text/international/synthesized-italic-vertical-latin.html as Failure.
- 12:15 PM Changeset in webkit [152461] by
-
- 2 edits in trunk/LayoutTests
Skip fast/repaint/fixed-right-in-page-scale.html on Lion.
https://bugs.webkit.org/show_bug.cgi?id=118479
Unreviewed: test marked as crashing.
- platform/mac-lion/TestExpectations:
Skip fast/repaint/fixed-right-in-page-scale.html.
- 11:57 AM Changeset in webkit [152460] by
-
- 6 edits in trunk/Source
Unreviewed. Fix make distcheck.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add missing header files.
Source/WebCore:
- GNUmakefile.list.am: Add missing header files.
Source/WTF:
- GNUmakefile.list.am: Add missing header files.
- 11:33 AM Changeset in webkit [152459] by
-
- 2 edits in trunk/Source/WebCore
Fix TextTrackCue::cueIndex() to handle the null case of TextTrack::cues(() properly
https://bugs.webkit.org/show_bug.cgi?id=117815
<rdar://problem/14211041>
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-08
Reviewed by Eric Carlson.
Merge https://src.chromium.org/viewvc/blink?revision=153206&view=revision
No new tests, only behavior change is preventing a crash in the release build.
cueIndex() is only used for sorting cues, so returning an invalidCueIndex in the case
where track()->cues() is null makes sense and won't modify behavior.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::cueIndex):
- 11:16 AM Changeset in webkit [152458] by
-
- 15 edits2 copies in branches/safari-537-branch
Merged r151737. <rdar://problem/14294837>
- 10:19 AM Changeset in webkit [152457] by
-
- 1 edit1 move in branches/safari-537-branch/LayoutTests
Merge r151913.
2013-06-24 Brent Fulgham <Brent Fulgham>
[Mac] Unreviewed build correction after r151868
New test expecation had been placed in the wrong directory.
- platform/mac/accessibility/listitem-title-expected.txt: Copied from platform/mac/listitem-title-actual.txt.
- platform/mac/listitem-title-actual.txt: Removed.
- 10:07 AM Changeset in webkit [152456] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r152416.
http://trac.webkit.org/changeset/152416
https://bugs.webkit.org/show_bug.cgi?id=118476
Wrong fix for the bug (Requested by ap on #webkit).
- platform/text/TextEncodingRegistry.cpp:
(WebCore::newTextCodec):
- 9:57 AM WebKitIDL edited by
- Added TreatReturnedNullObjectAs attribute. (diff)
- 8:57 AM Changeset in webkit [152455] by
-
- 2 edits in trunk
[GTK] Acceleration description isn't displayed in configured options.
https://bugs.webkit.org/show_bug.cgi?id=118441
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-07-08
Reviewed by Gustavo Noronha Silva.
The acceleration_backend_description has been changed to acceleration_description from r152275.
- Source/autotools/PrintBuildConfiguration.m4:
- 8:54 AM Changeset in webkit [152454] by
-
- 2 edits in trunk
[Autoconf] Define WTF_USE_OPENGL when OpenGL was found
https://bugs.webkit.org/show_bug.cgi?id=118341
Reviewed by Gustavo Noronha Silva.
After r152275, WTF_USE_OPENGL is only defined if the accelerated compositing is enabled.
This breaks the build if disabling the accelerated compositing feature as the OpenGL-specific
code is not compiled anymore even if it's still required.
To avoid that, WTF_USE_OPENGL should be defined if OpenGL was found. The accelerated compositing
feature also relies on this condition, exiting the configuration process with an error otherwise.
- Source/autotools/SetupAutoconfHeader.m4:
- 8:53 AM Changeset in webkit [152453] by
-
- 9 edits2 adds in trunk
REGRESSION(r125294): A style rule with more than 8192 selectors can cause style corruption.
<http://webkit.org/b/118369>
<rdar://problem/14291428>
Reviewed by Antti Koivisto.
Source/WebCore:
Add a semi-hard cap of 8192 selectors per CSS rule. Rules with longer selector lists will be split into
multiple rules (with 8192 selectors per rule.) The style properties are shared behind the scenes
so it's all pretty efficient.
This does generate a different CSSOM for gigantic selector lists, I've added a test to document this.
Note that setting CSSStyleRule.selectorText with over 8192 selectors will now fail, the splitting into
multiple rules only happens when parsing full style sheets.
Test: fast/css/rule-selector-overflow.html
- css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::selectorCount):
Add a helper to count the number of selectors in a list (not the number of raw selector components.)
- css/RuleSet.h:
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
Add RuleData::maximumSelectorCount constant and cap CSSStyleRule.selectorText to that many selectors.
- css/CSSSelectorList.h:
(WebCore::CSSSelectorList::adoptSelectorArray):
- css/StyleRule.cpp:
(WebCore::StyleRule::create):
(WebCore::StyleRule::splitIntoMultipleRulesWithMaximumSelectorCount):
- css/StyleRule.h:
(WebCore::StyleRule::parserAdoptSelectorArray):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parserAppendRule):
The meat of this change. Split rules with >8K selectors into multiple rules with 8K selectors in each.
- css/StyleRule.h:
(WebCore::toStyleRule):
Added a toStyleRule() helper for good measure.
LayoutTests:
Added a test to document the new cap of 8192 selectors per CSS rule.
- fast/css/rule-selector-overflow-expected.txt: Added.
- fast/css/rule-selector-overflow.html: Added.
- 8:37 AM Changeset in webkit [152452] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Block Zoom does not zoom in on narrow paragraphs properly
https://bugs.webkit.org/show_bug.cgi?id=118472
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-07-08.
Reviewed by Rob Buis.
Internally reviewed Arvid Nilsson and Genevieve Mak.
JIRA 114653
For the narrow paragraphs on www.nytimes.com, the first best node for
block zoom under the point is deprecated due to the limits of maximum
block zoom scale(3) and default maximum WebPage zoom scale(4) and instead
it picks up an ancestor node which is wider so that it looks like doesn't
zoom in properly.
To fix that, enlarge the default maximum WebPage zoom scale slightly
and use maximumScale() instead of maxBlockZoomScale() so that we can
accept more nodes. And also we'll still clamp the new scale by
maxBlockZoomScale() when we block zoom the WebPage, in which way those
nodes can be showed in the center of the viewport and surrounded by a
few other nodes within the viewport which shows better user experience.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::maximumScale):
(BlackBerry::WebKit::WebPagePrivate::adjustedBlockZoomNodeForZoomAndExpandingRatioLimits):
- 8:36 AM Changeset in webkit [152451] by
-
- 4 edits in trunk/Source/WebCore
Introduce DECLARE_FORWARDING_ATTRIBUTE_EVENT_LISTENER() macro
https://bugs.webkit.org/show_bug.cgi?id=118408
Reviewed by Philip Rogers.
Split DEFINE_FORWARDING_ATTRIBUTE_EVENT_LISTENER() macro into separate
DECLARE and DEFINE macros to reduce the number of header includes in
SVG.
No new tests, no behavior change.
- dom/EventTarget.h:
- svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::create):
(WebCore::SVGElementInstance::toNode):
(WebCore::SVGElementInstance::ownerDocument):
- svg/SVGElementInstance.h:
- 7:12 AM Changeset in webkit [152450] by
-
- 2 edits in trunk/Source/WebCore
[Coordinated Graphics] Rename variables in UpdateAtlas
https://bugs.webkit.org/show_bug.cgi?id=118403
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-08
Reviewed by Noam Rosenthal.
As of r149292, non-composited contents layer was removed from
CoordinatedGraphics. So, the variables should be renamed for
clarification.
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):
- 6:22 AM Changeset in webkit [152449] by
-
- 4 edits1 add in trunk
Add Deque::removeLast
https://bugs.webkit.org/show_bug.cgi?id=118466
Source/WTF:
Reviewed by Andreas Kling.
Deque can remove both the first and the last element efficiently.
Test: TestWebKitAPI/Tests/WTF/Deque.cpp
- wtf/Deque.h:
(WTF::::takeLast):
(WTF::::removeLast):
Tools:
Reviewed by Andreas Kling.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
(TestWebKitAPI::TEST):
- 5:56 AM Changeset in webkit [152448] by
-
- 3 edits in trunk/Source/WebCore
[Qt] Incremental build fix after r145712.
https://bugs.webkit.org/show_bug.cgi?id=112576.
Reviewed by Jocelyn Turcotte.
- DerivedSources.pri: Added dependence to INSPECTOR_JSON.
- inspector/front-end/WebKit.qrc: Added missing JS file.
- 3:22 AM Changeset in webkit [152447] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed gardening. Update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=118462
Unreviewed GTK gardening.
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-08
- platform/gtk/TestExpectations: Skip media/track/track-legacyapi-with-automatic-mode.html
and mark media/media-element-play-after-eos.html as flaky.
- 3:13 AM Changeset in webkit [152446] by
-
- 3 edits in trunk/Source
[GTK] FrameLoaderClient: Refactor naked pointers to use smart pointers
https://bugs.webkit.org/show_bug.cgi?id=118417
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-08
Reviewed by Carlos Garcia Campos.
Use GOwnPtr and GRefPtr where possible.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidFailLoad):
- 2:02 AM Changeset in webkit [152445] by
-
- 2 edits in trunk/Source/WTF
[Qt][Windows] Buildfix after r152426.
Reviewed by Csaba Osztrogonác.
- wtf/Platform.h: Do not include WTFHeaderDetection.h on Qt build.
- 2:00 AM Changeset in webkit [152444] by
-
- 2 edits in trunk/Tools
[GTK] Leak: GFile* leaking in beginDragWithFilesCallback
https://bugs.webkit.org/show_bug.cgi?id=118412
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-08
Reviewed by Martin Robinson.
An adoptRef is required to balance ref and deref calls.
- DumpRenderTree/gtk/EventSender.cpp:
(beginDragWithFilesCallback):
- 1:37 AM Changeset in webkit [152443] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed EFL gardening.
https://bugs.webkit.org/show_bug.cgi?id=118453
Added new baseline for EFL after r151841
Patch by Krzysztof Czech <k.czech@ymail.com> on 2013-07-08
- platform/efl/accessibility/aria-tab-role-on-buttons-expected.txt: Added.
- 1:19 AM Changeset in webkit [152442] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Runtime critical warning when unloading a module that failed to load
https://bugs.webkit.org/show_bug.cgi?id=118425
Reviewed by Martin Robinson.
- Platform/gtk/ModuleGtk.cpp:
(WebKit::Module::load): Show an error message when the module
fails to load.
(WebKit::Module::unload): Check module pointer before calling
unload method.
- 12:39 AM Changeset in webkit [152441] by
-
- 10 edits in trunk
vibrate function have to return boolean value.
https://bugs.webkit.org/show_bug.cgi?id=118288
Reviewed by Gyuyoung Kim.
Source/WebCore:
According to latest Vibration API which is LC, vibrate() needs to return boolean value
and exception code is removed also. In addition, remove condition for canceling vibration
can be called when visibility state is hidden.
http://www.w3.org/TR/vibration/
No new tests. vibration/navigator-vibration.html is changed.
- Modules/vibration/NavigatorVibration.cpp:
(WebCore::NavigatorVibration::vibrate):
- Modules/vibration/NavigatorVibration.h:
- Modules/vibration/NavigatorVibration.idl:
- Modules/vibration/Vibration.cpp:
(WebCore::Vibration::vibrate):
- Modules/vibration/Vibration.h:
LayoutTests:
Update navigator-vibration.html to adjust latest spec.
Add vibration/cancelVibration-during-pattern-vibrating.html to TestExpactations
until Vibration API support visibilitychane event.
- platform/efl/TestExpectations:
- vibration/navigator-vibration-expected.txt:
- vibration/navigator-vibration.html:
Jul 7, 2013:
- 11:52 PM Changeset in webkit [152440] by
-
- 22 edits in trunk/Source/WebCore
Adopt is/toHTMLTableElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118393
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLTableElement.
This also helps out to reduce duplicated use of static_cast.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable):
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
(WebCore::AccessibilityTable::title):
- accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(webkitAccessibleTableGetCaption):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetDescription):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- dom/Position.cpp:
(WebCore::endsOfNodeAreVisuallyDistinctPositions):
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
- editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply):
- editing/htmlediting.cpp:
(WebCore::isNonTableCellHTMLBlockElement):
- editing/markup.cpp:
(WebCore::ancestorToRetainStructureAndAppearanceForBlock):
- html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::rendererIsNeeded):
- html/HTMLTableElement.h:
(WebCore::isHTMLTableElement):
(WebCore::toHTMLTableElement):
- html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::findParentTable):
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::rowIndex):
- html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::virtualItemAfter):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
- platform/mac/HTMLConverter.mm:
(-[WebHTMLConverter _computedStringForNode:property:]):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::offsetParent):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):
- 9:40 PM Changeset in webkit [152439] by
-
- 12 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Graph::clearAndDerefChild() makes no sense anymore, and neither does Nop
https://bugs.webkit.org/show_bug.cgi?id=118452
Reviewed by Sam Weinig.
Noticed that ArgumentsSimplificationPhase was converting something to a Nop and then
resetting its children using clearAndDerefChild(). Using Nop instead of Phantom is a
holdover from back when we needed a no-MustGenerate no-op. We don't anymore. Using
clearAndDerefChild() was necessary back when we did eager reference counting. We
don't need to do that anymore, and in fact clearAndDerefChild() appeared to not do
any reference counting, so it was badly named to begin with.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::freeUnnecessaryNodes):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.h:
(Graph):
- dfg/DFGNode.h:
(JSC::DFG::Node::willHaveCodeGenOrOSR):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Jul 6, 2013:
- 11:46 PM Changeset in webkit [152438] by
-
- 2 edits in trunk/Source/WTF
Fix the performance regressions introduced by r152418
https://bugs.webkit.org/show_bug.cgi?id=118438
Reviewed by Sam Weinig.
- wtf/text/StringImpl.h:
(WTF::equal):
Looping between two arbitrary pointers prevents important loop
optimizations.
- 1:08 PM Changeset in webkit [152437] by
-
- 10 edits in trunk
createElement("image") creates an HTMLImageElement, although this hack should exist in parser only
https://bugs.webkit.org/show_bug.cgi?id=88360
Reviewed by Sam Weinig.
Source/WebCore:
Create a HTMLElement when using createElement('image'), but keep the HTML5 parser constructing HTMLImageelement for it.
- html/HTMLTagNames.in:
LayoutTests:
Update tests to reflect new behavior. This matches FireFox and Opera 12.
- fast/canvas/webgl/context-lost.html:
- fast/dom/prefixed-image-tag-expected.txt:
- fast/dom/prefixed-image-tag.xhtml:
- fast/dom/wrapper-classes-expected.txt:
- fast/dom/wrapper-classes.html:
- platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
- platform/mac/fast/dom/wrapper-classes-objc.html:
- 10:12 AM Changeset in webkit [152436] by
-
- 3 edits in trunk/Tools
Update list of EFL WK2 API tests
https://bugs.webkit.org/show_bug.cgi?id=118443
Patch by Sergio Correia <Sergio Correia> on 2013-07-06
Reviewed by Christophe Dumez.
The following tests were included:
Passing:
- CloseThenTerminate
- DidAssociateFormControls
- PageVisibilityState
- ResponsivenessTimerDoesntFireEarly
- TerminateTwice
- WillLoad
Failing:
- ResizeReversePaginatedWebView
- ScrollPinningBehaviors
This patch also modified
test_webkit2_api_BINARIES list so that it is in
alphabetical order.
- TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
- TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
- 12:24 AM Changeset in webkit [152435] by
-
- 2 edits in trunk/Source/WebCore
Stop hardcoding interfaces that have indexed getters returning strings
https://bugs.webkit.org/show_bug.cgi?id=118414
Reviewed by Kentaro Hara.
Stop hardcoding the names of interfaces that have indexed getters returning
strings in the bindings generator. Now that we use the latest Web IDL indexed
getter, more information is provided in the IDL files and the generator is
able to figure out if the indexed getter is returning a DOMString on its own.
No new tests, no behavior change.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateImplementation):
Jul 5, 2013:
- 10:01 PM Changeset in webkit [152434] by
-
- 2 edits in trunk/Source/WebCore
Tons of crashes on bots after r152425
https://bugs.webkit.org/show_bug.cgi?id=118440
<rdar://problem/14366772>
Reviewed by Sam Weinig.
Null-check the frame's page and early return. It's OK to do this
because it only happens when we're being torn down.
- page/FrameView.cpp:
(WebCore::FrameView::minimumScrollPosition):
(WebCore::FrameView::maximumScrollPosition):
- 7:19 PM Changeset in webkit [152433] by
-
- 4 edits in trunk
Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
https://bugs.webkit.org/show_bug.cgi?id=118439
<rdar://problem/14366120>
Reviewed by Anders Carlsson.
- page/FrameView.cpp:
(WebCore::FrameView::maximumScrollPosition):
- Test both Page and FrameView's pagination modes.
- *Don't* clamp negatives to zero if we are paginated with scroll offset set,
like the original changelog claimed, but the code did the opposite.
- Don't clamp in *all* pagination modes; with 'direction: RTL' it's still possible
to have a negative maximum position in LTR/TB pagination modes.
- TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
(TestWebKitAPI::didLayout):
(TestWebKitAPI::TEST):
- Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
- Assert that we got the right number of pages for sanity.
- Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
so much memory that SharedMemory asserts and makes the test time out.
- Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
because paint doesn't fire if the window is offscreen.
- 6:08 PM Changeset in webkit [152432] by
-
- 7 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should better report its compile-times and it should be able to run in a mode where it doesn't spend time generating OSR exits
https://bugs.webkit.org/show_bug.cgi?id=118401
Reviewed by Sam Weinig.
Add two new OSR exit modes, which are useful only for playing with compile times:
- All OSR exits are llvm.trap().
- OSR exits don't take arguments and have no exit value marshaling.
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPlan.h:
(Plan):
- ftl/FTLIntrinsicRepository.h:
(FTL):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
- ftl/FTLOutput.h:
(JSC::FTL::Output::trap):
- runtime/Options.h:
(JSC):
- 6:01 PM Changeset in webkit [152431] by
-
- 38 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should refer to BasicBlocks by BasicBlock* and not BlockIndex
https://bugs.webkit.org/show_bug.cgi?id=118339
Reviewed by Michael Saboff.
This accomplishes two goals:
1) Simplifies a bunch of code. You can now much more directly get to a successor
or predecessor, since you just get the pointer directly. The backend(s) always
hold onto a pointer to the block they're on, so you don't have to do work to
get the block from the index.
2) It allows for the possibility of inserting blocks into the program.
Previously, if you did that, you'd have to edit all references to blocks since
those references would have outdated indexing after an insertion. Now, if you
change the indexing, you just have to invalidate some analyses and make sure
that you change each block's BasicBlock::index accordingly.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::mergeToSuccessors):
- dfg/DFGAbstractState.h:
(AbstractState):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::run):
- dfg/DFGBasicBlock.h:
(DFG):
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::size):
(JSC::DFG::BasicBlock::isEmpty):
(JSC::DFG::BasicBlock::at):
(JSC::DFG::BasicBlock::operator[]):
(JSC::DFG::BasicBlock::last):
(JSC::DFG::BasicBlock::resize):
(JSC::DFG::BasicBlock::grow):
(BasicBlock):
(JSC::DFG::BasicBlock::append):
(JSC::DFG::BasicBlock::numSuccessors):
(JSC::DFG::BasicBlock::successor):
(JSC::DFG::BasicBlock::successorForCondition):
(JSC::DFG::BasicBlock::dump):
(UnlinkedBlock):
(JSC::DFG::UnlinkedBlock::UnlinkedBlock):
(JSC::DFG::getBytecodeBeginForBlock):
(JSC::DFG::blockForBytecodeOffset):
- dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::linkBlocks):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
(JSC::DFG::CFAPhase::performForwardCFA):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::convertToJump):
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::freeUnnecessaryNodes):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlocks):
(JSC::DFG::CPSRethreadingPhase::propagatePhis):
(CPSRethreadingPhase):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::run):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::run):
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::run):
- dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::Disassembler):
(JSC::DFG::Disassembler::createDumpList):
- dfg/DFGDisassembler.h:
(JSC::DFG::Disassembler::setForBlockIndex):
- dfg/DFGDominators.cpp:
(JSC::DFG::Dominators::compute):
(JSC::DFG::Dominators::iterateForBlock):
- dfg/DFGDominators.h:
(JSC::DFG::Dominators::dominates):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::handleSuccessor):
(JSC::DFG::Graph::determineReachability):
(JSC::DFG::Graph::resetReachability):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::numBlocks):
(JSC::DFG::Graph::block):
(JSC::DFG::Graph::lastBlock):
(Graph):
(JSC::DFG::Graph::appendBlock):
(JSC::DFG::Graph::killBlock):
(DFG):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::setForBlockIndex):
- dfg/DFGNaturalLoops.cpp:
(JSC::DFG::NaturalLoop::dump):
(JSC::DFG::NaturalLoops::compute):
(JSC::DFG::NaturalLoops::loopsOf):
- dfg/DFGNaturalLoops.h:
(JSC::DFG::NaturalLoop::NaturalLoop):
(JSC::DFG::NaturalLoop::addBlock):
(JSC::DFG::NaturalLoop::header):
(JSC::DFG::NaturalLoop::at):
(JSC::DFG::NaturalLoop::operator[]):
(JSC::DFG::NaturalLoop::contains):
(NaturalLoop):
(JSC::DFG::NaturalLoops::headerOf):
(NaturalLoops):
- dfg/DFGNode.h:
(DFG):
(JSC::DFG::SwitchCase::SwitchCase):
(JSC::DFG::SwitchCase::withBytecodeIndex):
(SwitchCase):
(JSC::DFG::SwitchCase::targetBytecodeIndex):
(JSC::DFG::SwitchData::SwitchData):
(JSC::DFG::SwitchData::setFallThroughBytecodeIndex):
(JSC::DFG::SwitchData::fallThroughBytecodeIndex):
(SwitchData):
(JSC::DFG::Node::setTakenBlock):
(JSC::DFG::Node::setNotTakenBlock):
(JSC::DFG::Node::takenBlock):
(JSC::DFG::Node::notTakenBlock):
(JSC::DFG::Node::successor):
(JSC::DFG::Node::successorForCondition):
- dfg/DFGPredictionInjectionPhase.cpp:
(JSC::DFG::PredictionInjectionPhase::run):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagateForward):
(JSC::DFG::PredictionPropagationPhase::propagateBackward):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(JSC::DFG::SpeculativeJIT::linkOSREntries):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileRegExpExec):
(JSC::DFG::SpeculativeJIT::addBranch):
(JSC::DFG::SpeculativeJIT::linkBranches):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::nextBlock):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::branchDouble):
(JSC::DFG::SpeculativeJIT::branchDoubleNonZero):
(JSC::DFG::SpeculativeJIT::branch32):
(JSC::DFG::SpeculativeJIT::branchTest32):
(JSC::DFG::SpeculativeJIT::branch64):
(JSC::DFG::SpeculativeJIT::branch8):
(JSC::DFG::SpeculativeJIT::branchPtr):
(JSC::DFG::SpeculativeJIT::branchTestPtr):
(JSC::DFG::SpeculativeJIT::branchTest8):
(JSC::DFG::SpeculativeJIT::jump):
(JSC::DFG::SpeculativeJIT::addBranch):
(JSC::DFG::SpeculativeJIT::StringSwitchCase::StringSwitchCase):
(StringSwitchCase):
(JSC::DFG::SpeculativeJIT::BranchRecord::BranchRecord):
(BranchRecord):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::run):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):
(JSC::DFG::TypeCheckHoistingPhase::disableHoistingAcrossOSREntries):
- dfg/DFGUnificationPhase.cpp:
(JSC::DFG::UnificationPhase::run):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::checkOperand):
(JSC::DFG::Validate::reportValidationContext):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileJump):
(JSC::FTL::LowerDFGToLLVM::compileBranch):
(JSC::FTL::LowerDFGToLLVM::lowBlock):
- 4:21 PM Changeset in webkit [152430] by
-
- 2 edits in trunk/Source/WebCore
WKPageFindStringMatches with kWKFindOptionsBackwards still doesn't work
<rdar://problem/13881024>
https://bugs.webkit.org/show_bug.cgi?id=118436
Reviewed by Tim Horton.
- page/Page.cpp:
(WebCore::Page::findStringMatchingRanges):
- When searching backwards, use END_TO_START rather than START_TO_END.
- If there is no selection and we are searching backwards, we now select the last item, not the first.
- 4:12 PM Changeset in webkit [152429] by
-
- 2 edits in trunk/Source/WTF
[Windows] Unreviewed build correction.
- WTF.vcxproj/WTFGenerated.make: Avoid syntax error in generated
file in cases where Legible Output support is not present.
- 4:06 PM Changeset in webkit [152428] by
-
- 1 edit5 adds in trunk/Source/WebCore
Nix upstreaming - Adding Nix render theme files
https://bugs.webkit.org/show_bug.cgi?id=118368
Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2013-07-05
Reviewed by Benjamin Poulain.
All files related to render theme stuff.
No new tests. They will be uploaded on another patch during the upstreaming process.
- platform/nix/RenderThemeNix.cpp: Added.
- platform/nix/RenderThemeNix.h: Added.
- platform/nix/ScrollbarThemeNix.cpp: Added.
- platform/nix/ScrollbarThemeNix.h: Added.
- 3:57 PM Changeset in webkit [152427] by
-
- 2 edits in trunk/Source/WTF
[Windows] Unreviewed build correction.
- WTF.vcxproj/WTFGenerated.make: Use space (rather than double
quotes) when handling the no-Legible-Output case.
- 3:17 PM Changeset in webkit [152426] by
-
- 7 edits in trunk/Source
[Windows] Identify OS-level at build-time.
https://bugs.webkit.org/show_bug.cgi?id=118428
Reviewed by Anders Carlsson.
../WebCore:
- DerivedSources.make: Activate legible output features if present.
- WebCorePrefix.h: Activate MSVC 2010 workarounds for CGFloat if
building with VS2010.
- config.h: Activate legible output features if present.
../WTF:
- WTF.vcxproj/WTFGenerated.make: Check for Legible Output featurs
and set build environment as appropriate.
- wtf/Platform.h: Activate Legible Output features if present.
- 2:33 PM Changeset in webkit [152425] by
-
- 24 edits1 add in trunk
[wk2] Add API to lock the scroll position at the top or bottom of the page
https://bugs.webkit.org/show_bug.cgi?id=118429
<rdar://problem/14120323>
Reviewed by Anders Carlsson.
Test (API): WebKit2.ScrollPinningBehaviors
- WebCore.exp.in:
Expose FrameView::setScrollPinningBehavior.
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
Our pinning behavior should be DoNotPin by default.
- page/FrameView.cpp:
(WebCore::FrameView::minimumScrollPosition):
(WebCore::FrameView::maximumScrollPosition):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::minimumScrollPosition):
(WebCore::ScrollingTreeScrollingNodeMac::maximumScrollPosition):
Fix the minimum scroll position's vertical location to the maximum if
we're pinned to the bottom, and vice-versa if we're pinned to the top.
(WebCore::FrameView::setScrollPinningBehavior): Added.
If scroll pinning behavior has changed, inform ScrollingCoordinator
and update scrollbars (which will also re-pin the scroll position).
- page/FrameView.h:
Override minimumScrollPosition, add setScrollPinningBehavior,
and storage for m_scrollPinningBehavior.
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::setScrollPinningBehavior): Added.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
Our pinning behavior should be DoNotPin by default.
(WebCore::ScrollingTree::setScrollPinningBehavior):
(WebCore::ScrollingTree::scrollPinningBehavior):
Getter/setter for m_scrollPinningBehavior, scrolling-thread-safe.
- page/scrolling/ScrollingTree.h:
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::setScrollPinningBehavior):
Inform ScrollingTree of the scroll pinning behavior change.
- platform/ScrollTypes.h:
Add ScrollPinningBehavior enum.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
(TestWebKitAPI::didFinishDocumentLoadForFrame):
(TestWebKitAPI::TEST):
Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
all work correctly in the face of resizing the view and scrolling from JS.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
Pass the current ScrollPinningBehavior across to the WebPage upon creation.
- UIProcess/API/C/WKPage.cpp:
(WKPageGetScrollPinningBehavior):
(WKPageSetScrollPinningBehavior):
- UIProcess/API/C/WKPagePrivate.h:
SPI to get/set the WebPageProxy's current ScrollPinningBehavior.
Convert between WK API type and WebCore enum.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):
Send ScrollPinningBehavior when creating a WebPage.
(WebKit::WebPageProxy::setScrollPinningBehavior):
Pass ScrollPinningBehavior changes across to the WebProcess (and save it
in WebPageProxy so it can be sent back across if the WebProcess crashes).
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::scrollPinningBehavior):
Getter/setter and storage for m_scrollPinningBehavior.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Inform new FrameViews of the current ScrollPinningBehavior.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Set our ScrollPinningBehavior based on our creation parameters.
(WebKit::WebPage::setScrollPinningBehavior):
Inform the FrameView of ScrollPinningBehavior changes.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::scrollPinningBehavior): Added.
(WebKit::WebPage::setScrollPinningBehavior): Added.
Add storage for m_scrollPinningBehavior.
- WebProcess/WebPage/WebPage.messages.in:
Add SetScrollPinningBehavior message.
- 2:28 PM Changeset in webkit [152424] by
-
- 3 edits2 adds in trunk
iframe constrained by max-width in full screen
https://bugs.webkit.org/show_bug.cgi?id=118250
Patch by Zalan Bujtas <Alan Bujtas> on 2013-07-05
Reviewed by Antti Koivisto.
Ensure that contents inside iframe can go full screen properly.
Set max-width and max-height values to the default 'none', so that iframes are not
constrained when entering full screen.
Source/WebCore:
Test: fullscreen/full-screen-iframe-with-max-width-height.html
- css/fullscreen.css:
(iframe:-webkit-full-screen):
LayoutTests:
- fullscreen/full-screen-iframe-with-max-width-height-expected.txt: Added.
- fullscreen/full-screen-iframe-with-max-width-height.html: Added.
- 2:03 PM Changeset in webkit [152423] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/contributors.json:
- 1:35 PM Changeset in webkit [152422] by
-
- 5 edits2 adds in trunk
[Mac] .webkitClosedCaptionsVisible doesn't work with "Automatic" caption mode
https://bugs.webkit.org/show_bug.cgi?id=118319
Reviewed by Jer Noble.
Source/WebCore:
Track when captions are enabled with the old 'webkitClosedCaptionsVisible' attribute and
consider that when determining which track should be enabled.
Test: media/track/track-legacyapi-with-automatic-mode.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_webkitLegacyClosedCaptionOverride.
(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): Set m_webkitLegacyClosedCaptionOverride.
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): Return m_webkitLegacyClosedCaptionOverride.
- html/HTMLMediaElement.h:
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore): Don't apply "automatic"
logic when captions were enabled with .webkitClosedCaptionsVisible.
LayoutTests:
- media/track/track-legacyapi-with-automatic-mode-expected.txt: Added.
- media/track/track-legacyapi-with-automatic-mode.html: Added.
- 10:46 AM Changeset in webkit [152421] by
-
- 5 edits in tags/Safari-537.48.3/Source
Versioning.
- 10:44 AM Changeset in webkit [152420] by
-
- 1 copy in tags/Safari-537.48.3
New tag.
- 10:35 AM Changeset in webkit [152419] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Updated TestExpectations file.
Added accessibility/listitem-list.html to the list of expected
failures, which will get fixed once bug 105214 is fixed.
- platform/gtk/TestExpectations: Added new test.
- 10:25 AM Changeset in webkit [152418] by
-
- 3 edits in trunk/Source/WTF
A lot of code duplication within StringImpl 'equal' functions
https://bugs.webkit.org/show_bug.cgi?id=118415
Reviewed by Anders Carlsson.
There has been a lot of code duplication within StringImpl 'equal' functions:
the whole logic was copied to every overloaded 'equal' function.
Fixed now using templates and std::equal.
- wtf/text/StringImpl.cpp:
(WTF::equalInternal):
(WTF::equal):
- wtf/text/StringImpl.h:
(WTF::arraysEqual):
(WTF::equal):
- 9:35 AM Changeset in webkit [152417] by
-
- 2 edits in trunk/LayoutTests
[GTK] Update TestExpectations with crashing and failing tests
https://bugs.webkit.org/show_bug.cgi?id=118424
Unreviewed GTK gardening.
Updated TestExpectations with tests crashing and failing.
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-05
- platform/gtk/TestExpectations:
- 8:02 AM Changeset in webkit [152416] by
-
- 2 edits in trunk/Source/WebCore
Segmentation fault occurred when ICU data library doesn't embed the expected encoding.
https://bugs.webkit.org/show_bug.cgi?id=118410
Patch by Benjamin Dupont <bdupont@nds.com> on 2013-07-05
Reviewed by Allan Sandfeld Jensen.
- platform/text/TextEncodingRegistry.cpp:
(WebCore::newTextCodec):
- 4:23 AM Changeset in webkit [152415] by
-
- 3 edits in trunk/Source/WTF
Remove code duplication from StringImpl create()/reallocate() methods
https://bugs.webkit.org/show_bug.cgi?id=118355
Reviewed by Andreas Kling.
StringImpl create()/reallocate() methods accepting LChar and UChar used to have
duplicated code. The code duplication is removed now via used templates.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::constructInternal):
(WTF::LChar):
(WTF::StringImpl::createUninitializedInternal):
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::reallocateInternal):
(WTF::StringImpl::reallocate):
(WTF::StringImpl::createInternal):
(WTF::StringImpl::create):
- wtf/text/StringImpl.h:
- 3:29 AM WikiStart edited by
- I'm developing a Mac app embedding a WebView and another developer … (diff)
- 3:29 AM Changeset in webkit [152414] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Implement unit test callbacks: onWordLearn and onWordIgnore.
https://bugs.webkit.org/show_bug.cgi?id=118392
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-07-05
Reviewed by Christophe Dumez.
Simulate behavior of Learn and Ignore Word in the text field.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::mouseDoubleClick):
Select the entire word in the text field.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
- UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(onSpellingForKnownWord):
(onWordLearn):
(onWordIgnore):
(selectLearnSpelling):
(selectIgnoreSpelling):
- 3:26 AM Changeset in webkit [152413] by
-
- 2 edits1 add1 delete in trunk/LayoutTests
[New multicol] Change test to follow the pattern of the other tests
https://bugs.webkit.org/show_bug.cgi?id=117698
Patch by Mihai Maerean <Mihai Maerean> on 2013-07-05
Reviewed by Andreas Kling.
Test is a ref test against the old multicol code, like all the other tests in LayoutTests/fast/multicol/newmulticol/
This is a follow up of bug 116614, testing that flow threads don't end up being cloned in region based multi
columns with columns:1 where the only child has column-span:all.
- fast/multicol/newmulticol/direct-child-column-span-all-expected.html: Added.
- fast/multicol/newmulticol/direct-child-column-span-all-expected.txt: Removed.
- fast/multicol/newmulticol/direct-child-column-span-all.html:
- 3:13 AM Changeset in webkit [152412] by
-
- 4 edits in trunk
[GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
https://bugs.webkit.org/show_bug.cgi?id=111434
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-07-05
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
- UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(testNotInitialized):
(testSetDirectory):
(testClearDatabase):
(testGetFavicon):
(testGetFaviconURI): Removed gconstpointer parameter.
(testWebViewFavicon): Fixed to make it work together with the
other tests and removed gconstpointer parameter.
(testFaviconDatabase): Created to call all tests in the proper
order.
(beforeAll): Changed to call only testFaviconDatabase instead of
the separate tests.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Unskipped TestWebKitFaviconDatabase tests.
- 1:52 AM Changeset in webkit [152411] by
-
- 6 edits in trunk
[GTK] fast/text/font-kerning.html fails
https://bugs.webkit.org/show_bug.cgi?id=76048
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-07-05
Reviewed by Martin Robinson.
Added kerning to the list of features for hb_shade() according to FontDescription::kerning().
Removed font-kerning.html from gtk/TestExpectations, which was failing before this fix.
Source/WebCore:
- platform/graphics/harfbuzz/HarfBuzzFace.cpp:
(WebCore):
- platform/graphics/harfbuzz/HarfBuzzFace.h:
(HarfBuzzFace):
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::setFontFeatures):
LayoutTests:
- platform/gtk/TestExpectations:
- 1:41 AM Changeset in webkit [152410] by
-
- 2 edits in trunk/Source/WebKit2
TestWebKitFaviconDatabase/clear-database is not testing things properly
https://bugs.webkit.org/show_bug.cgi?id=118404
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-07-05
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(testClearDatabase): Check for an existing icon that can make the
test fail if clear database is not working.
- 12:36 AM Changeset in webkit [152409] by
-
- 2 edits in trunk/Source/WebCore
Build fix GTK after r152404.
https://bugs.webkit.org/show_bug.cgi?id=118407
Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-07-05
Reviewed by Christophe Dumez.
- GNUmakefile.list.am:
Jul 4, 2013:
- 11:53 PM Changeset in webkit [152408] by
-
- 2 edits in trunk/Tools
[EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
https://bugs.webkit.org/show_bug.cgi?id=118370
Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-07-04
Reviewed by Christophe Dumez.
Add fallback to software X11 engine if opengl_x11 engine creation fails.
- DumpRenderTree/efl/DumpRenderTree.cpp:
(initEcoreEvas):
- 2:17 PM Changeset in webkit [152407] by
-
- 3 edits in trunk/Source/WebKit2
Paint the page background if we haven't received our first update
https://bugs.webkit.org/show_bug.cgi?id=118402
<rdar://problem/13893308>
Reviewed by Simon Fraser.
Make sure that we always paint something when we haven't received our first update from the web process.
- UIProcess/API/mac/WKView.mm:
(-[WKView drawRect:]):
- UIProcess/DrawingAreaProxyImpl.h:
(WebKit::DrawingAreaProxyImpl::hasReceivedFirstUpdate):
- 1:28 PM Changeset in webkit [152406] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
Unreviewed, add a helpful comment for why DCE is needed in the FTL.
I believe I've now twice down the experiment of disabling DCE in the FTL,
only to realize that this can't work, and that DCE is needed. I'd kind of
like to not make that mistake again.
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- 12:53 PM Changeset in webkit [152405] by
-
- 3 edits in trunk/Source/WebKit/mac
Add a method to get unreachable URL from WebFrame.
https://bugs.webkit.org/show_bug.cgi?id=118399
Normally we could use [[WebFrame dataSource] unreachableURL] to get the failed URL. However, if the frame has not
loaded (FrameLoader::frameHasLoaded() is false), we will get a nil dataSource and we won't be able to get unreachableURL.
We can add a method to always return the unreachableURL regardless if the frame has loaded or not.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-07-04
Reviewed by Dan Bernstein.
- WebView/WebFrame.mm:
(-[WebFrame _unreachableURL]):
- WebView/WebFramePrivate.h:
- 11:48 AM Changeset in webkit [152404] by
-
- 16 edits2 deletes in trunk
Have SVGTextContentElement inherit SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=118351
Reviewed by Dirk Schulze.
Source/WebCore:
Have SVGTextContentElement inherit SVGGraphicsElement instead of
SVGStyledElement in order to match the latest SVG2 specification:
https://svgwg.org/svg2-draft/text.html#InterfaceSVGTextContentElement
This patch also removes the SVGTransformable and SVGLocatable IDL
interfaces as they are no longer needed (were merged into
SVGGraphicsElement in the latest specification).
This is one step towards getting rid of multiple inheritance in
SVG, and complying with the latest SVG2 specification.
No new tests, covered by existing tests.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorJS.pm:
(GetGnuVTableOffsetForType):
- bindings/scripts/CodeGeneratorObjC.pm:
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
- svg/SVGElement.cpp:
(WebCore::SVGElement::getBoundingBox):
- svg/SVGLocatable.idl: Removed.
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::SVGTextContentElement):
(WebCore::SVGTextContentElement::isSupportedAttribute):
(WebCore::SVGTextContentElement::isPresentationAttribute):
(WebCore::SVGTextContentElement::collectStyleForPresentationAttribute):
(WebCore::SVGTextContentElement::parseAttribute):
(WebCore::SVGTextContentElement::svgAttributeChanged):
- svg/SVGTextContentElement.h:
- svg/SVGTextContentElement.idl:
- svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::SVGTextElement):
(WebCore::SVGTextElement::animatedLocalTransform):
- svg/SVGTextElement.h:
- svg/SVGTextElement.idl:
- svg/SVGTransformable.idl: Removed.
LayoutTests:
Fix conversion to absolute (user agent) coordinates in the svg/text
tests to use SVGGraphicsElement::getScreenCTM() instead of
SVGGraphicsElement::getTransformToElement(). The previous code was
working until now due to a bug in getTransformToElement(), which
was not taking into consideration the CTM of the SVGTextElement (as
it was not recognized as a "locatable" element). Now that
SVGTextElement inherits from SVGGraphicsElement, it is properly
recognized as a "locatable" element by getTransformToElement().
- svg/text/resources/SelectionTestCase.js:
(toAbsoluteCoordinates):
- svg/text/selection-doubleclick.svg:
- 11:42 AM Changeset in webkit [152403] by
-
- 2 edits in trunk/Source/WebKit2
Crash when createPluginInternal ends up destroying the plug-in
https://bugs.webkit.org/show_bug.cgi?id=118397
<rdar://problem/14155051>
Reviewed by Simon Fraser.
Keep the WebProcessConnection object alive while calling createPluginInternal and handle
the IPC connection going away.
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPluginAsynchronously):
- 11:33 AM WebKitGTK/StartHacking edited by
- (diff)
- 11:00 AM Changeset in webkit [152402] by
-
- 3 edits in trunk/Source/WebCore
Remove PageThrottler::m_activeThrottleBlockers
https://bugs.webkit.org/show_bug.cgi?id=118375
Reviewed by Mark Rowe.
This is simply m_activityTokens.size().
Also, fold preventThrottling into addActivityToken & allowThrottling into removeActivityToken
(these should no longer be called directly, and should not be public).
- page/PageThrottler.cpp:
(WebCore::PageThrottler::PageThrottler):
- removed m_activeThrottleBlockers
(WebCore::PageThrottler::startThrottleHysteresisTimer):
- m_activeThrottleBlockers -> m_activityTokens.size()
(WebCore::PageThrottler::throttleHysteresisTimerFired):
- m_activeThrottleBlockers -> m_activityTokens.size()
(WebCore::PageThrottler::addActivityToken):
- added functionality from preventThrottling
(WebCore::PageThrottler::removeActivityToken):
- added functionality from allowThrottling
- page/PageThrottler.h:
- removed preventThrottling, allowThrottling, and m_activeThrottleBlockers.
- 8:52 AM WebKitGTK/StartHacking edited by
- Minor correction in documentation section (diff)
- 8:51 AM Changeset in webkit [152401] by
-
- 5 edits in trunk/Source/WebCore
Take document height into account when determining when it is considered visually non-empy
https://bugs.webkit.org/show_bug.cgi?id=118272
Reviewed by Darin Adler.
The current visually non-empy mechanism takes into account only the amount of contents in renderers.
Add a simple layout dependency so that we don't consider page non-empty until the document height
exceed a (low) height threshold (or the load completes).
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
Don't send layout callbacks until we have actually some content.
(WebCore::FrameView::qualifiesAsVisuallyNonEmpty):
(WebCore::FrameView::updateIsVisuallyNonEmpty):
Factor into functions.
- page/FrameView.h:
(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount):
(WebCore::FrameView::incrementVisuallyNonEmptyPixelCount):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
The size is not known but the estimate provided here is always bigger than the threshold so
the functionality is unchanged.
- 8:50 AM WebKitGTK/StartHacking edited by
- Added documentation section. (diff)
- 8:33 AM Changeset in webkit [152400] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r152399.
Add missing header include for SVGNames.h.
- svg/SVGImageElement.h:
- 7:09 AM WebKitGTK/SpeedUpBuild edited by
- Minor typo fix in gold section (diff)
- 7:07 AM WebKitGTK/SpeedUpBuild edited by
- Minor fix in gold (diff)
- 7:06 AM WebKitGTK/SpeedUpBuild edited by
- Adding gold section (diff)
- 7:00 AM WebKitGTK/StartHacking edited by
- Recommending to use the gold linker (diff)
- 6:58 AM Changeset in webkit [152399] by
-
- 4 edits in trunk/Source/WebCore
Change static_cast<SVGImageElement*> with toSVGImageElement
https://bugs.webkit.org/show_bug.cgi?id=118387
Reviewed by Andreas Kling.
As a step to change static_cast with toXXX, static_cast<SVGImageElement*> can
be changed with toSVGImageElement().
Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=153557
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::updateImageViewport):
(WebCore::RenderSVGImage::layout):
(WebCore::RenderSVGImage::paintForeground):
- svg/SVGImageElement.h:
(WebCore::toSVGImageElement):
- svg/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::dispatchLoadEvent):
- 6:18 AM Changeset in webkit [152398] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Leak: Free PangoFontDescription* in RenderThemeGtk3
https://bugs.webkit.org/show_bug.cgi?id=118386
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-04
Reviewed by Carlos Garcia Campos.
Free PangoFontDescription* allocated by gtk_style_context_get (transfer full).
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::spinButtonArrowSize):
- 5:10 AM Changeset in webkit [152397] by
-
- 7 edits in trunk
[ATK] Leak: AtkAttributeSet* should be freed
https://bugs.webkit.org/show_bug.cgi?id=118307
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-04
Reviewed by Christophe Dumez.
Source/WebCore:
Use AtkAttributeSet* instead of GSList*.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetObjectLocale):
Tools:
Fixed memory leaks for AtkAttributeSet by calling
atk_attribute_set_free().
- DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
(AccessibilityController::childElementById):
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(getAtkAttributeSetAsString):
(AccessibilityUIElement::allAttributes):
(AccessibilityUIElement::stringAttributeValue):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::childElementById):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::getAtkAttributeSetAsString):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::stringAttributeValue):
- 3:03 AM Changeset in webkit [152396] by
-
- 4 edits in trunk/Source
[ATK] Do not expose '\n' for wrapped lines with ATK_TEXT_BOUNDARY_CHAR
https://bugs.webkit.org/show_bug.cgi?id=118359
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Do not expose a '\n' character for every visual line break.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetChar): Removed wrong code.
Source/WebKit/gtk:
Added new unit test to make sure we exposed line breaks properly.
- tests/testatk.c:
(testWebkitAtkGetTextAtOffsetWithWrappedLines): New unit test.
(main): Added new test to the test suite.
- 2:12 AM Changeset in webkit [152395] by
-
- 2 edits1 delete in trunk/Source/JavaScriptCore
[CMake] Add generation of JITStubs for x86_64 MSVC
https://bugs.webkit.org/show_bug.cgi?id=116666
Reviewed by Laszlo Gombos.
Also move the generation for ARM CPU into the CMakeLists.txt,
since it's compiler specific and not dedicated to Windows CE.
- CMakeLists.txt:
- PlatformWinCE.cmake: Removed.
- 2:05 AM Changeset in webkit [152394] by
-
- 2 edits2 deletes in trunk/LayoutTests
[EFL] Gardening. Unskip tests related with editing
https://bugs.webkit.org/show_bug.cgi?id=118379
Unreviewed gardening.
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2013-07-04
- platform/efl-wk2/TestExpectations: Unskip editing/selection/doubleclick-beside-cr-span.html and editing/selection/doubleclick-whitespace.html, which are passed after r150289
- platform/efl/editing/style/5065910-expected.txt: Removed (wrong expected result).
- platform/efl/editing/style/5065910-expected.png: Removed (wrong expected result).
- 1:52 AM Changeset in webkit [152393] by
-
- 2 edits in trunk/Source/JavaScriptCore
[CMake] Add STATICALLY_LINKED_WITH_WTF to JavaScriptCore project
https://bugs.webkit.org/show_bug.cgi?id=118120
Reviewed by Gyuyoung Kim.
Since WTF is a static library linked to JavaScriptCore on all CMake ports
we need to define STATICALLY_LINKED_WITH_WTF for all of them.
This makes only a difference for Windows, since WTF_EXPORT and WTF_IMPORT
are the same on all other platforms.
- CMakeLists.txt:
- 1:08 AM Changeset in webkit [152392] by
-
- 3 edits1 delete in trunk/Source/WebCore
Port FileSystemWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=117935
Reviewed by Brent Fulgham.
Add #if !OS(WINCE) around a few lines of the code, so it can be used by the WinCE port too.
- PlatformWinCE.cmake:
- platform/win/FileSystemWin.cpp:
(WebCore::storageDirectory):
- platform/wince/FileSystemWinCE.cpp: Removed.
- 12:44 AM Changeset in webkit [152391] by
-
- 3 edits2 adds in trunk
[GStreamer] support preload="metadata"
https://bugs.webkit.org/show_bug.cgi?id=116817
Reviewed by Eric Carlson.
Source/WebCore:
Add appropriate behavior for preload="metadata". Delay enabling download buffering
until playback is started in this case. This behavior fits with the standard quite
well and this is the most exact match we can get (at least without adding too much
extra complexity). What matters mostly is that we can avoid loading the media
before playback but we have the first frame and the metadata.
Test: media/video-load-preload-metadata.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Set |m_preload| to |Auto|
so we will start download buffering if we did not start it yet.
(WebCore::MediaPlayerPrivateGStreamer::play): Ditto.
(MediaPlayerPrivateGStreamer::setDownloadBuffering): Only start download
buffering if |m_preload == Auto|. Also make sure we don't clear the download
flag once we started downloading because it would result in not well defined
behavior and it does not really makes sense.
(MediaPlayerPrivateGStreamer::setPreload): Set download buffering accordingly.
LayoutTests:
- media/video-load-preload-metadata.html: Added.
Jul 3, 2013:
- 11:48 PM WebKitGTK/2.0.x edited by
- (diff)
- 11:44 PM Changeset in webkit [152390] by
-
- 3 edits in trunk/Source/WebCore
[Coordinated Graphics] Don't use && operator in ASSERT
https://bugs.webkit.org/show_bug.cgi?id=118377
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-03
Reviewed by Noam Rosenthal.
We don't use && opeartor in ASSERT because it's impossible to know which
condition caused the assertion.
- platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp:
(WebCore::CoordinatedBackingStoreTile::swapBuffers):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):
- 11:20 PM Changeset in webkit [152389] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Support some more editing keyboard events
https://bugs.webkit.org/show_bug.cgi?id=118346
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2013-07-03
Reviewed by Gyuyoung Kim.
For editable contents, support the shortcuts for copy, page, cut, select all, undo and redo.
- platform/efl/EflKeyboardUtilities.cpp:
- 10:28 PM Changeset in webkit [152388] by
-
- 5 edits2 adds in trunk
AX: Items the img aria role aren't inserting an object replacement character
https://bugs.webkit.org/show_bug.cgi?id=118259
Source/WebCore:
Reviewed by Tim Horton.
VoiceOver relies on object replacement characters being emitted when asking for selected text.
This has worked if a real <img> is used, but if role="img" is used on a <div>, for example,
no emission is performed, which leads to missed elements in text.
Test: platform/mac/accessibility/aria-image-emits-object-replacement.html
- editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
(WebCore::TextIterator::advance):
LayoutTests:
Reviewed by Reviewed by Tim Horton.
- accessibility/non-native-image-crash-expected.txt:
- platform/mac/accessibility/aria-image-emits-object-replacement-expected.txt: Added.
- platform/mac/accessibility/aria-image-emits-object-replacement.html: Added.
- platform/mac/accessibility/img-fallsback-to-title-expected.txt:
Update expected tests where role="img" now emits replacement character.
- 9:31 PM Changeset in webkit [152387] by
-
- 6 edits in trunk/Source/WebCore
Adopt is/toHTMLMapElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118235
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLMapElement.
This also helps out to reduce duplicated use of static_cast.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
- dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
- dom/TreeScope.cpp:
(WebCore::TreeScope::getImageMap):
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::imageElement):
- html/HTMLMapElement.h:
(WebCore::isHTMLMapElement):
(WebCore::toHTMLMapElement):
- 5:47 PM Changeset in webkit [152386] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Unreviewed build correction after r15283.
- WebCorePrefix.h: Remove include directive for CGFloat.h, as it
is not present in all Windows build environments.
- 5:39 PM Changeset in webkit [152385] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Exclude unsupported QuartzCore Features.
https://bugs.webkit.org/show_bug.cgi?id=118374
Reviewed by Anders Carlsson.
- WebCore.vcxproj/WebCoreCG.props: Exclude a few non-Windows
concepts from the QuartzCore headers.
- 5:03 PM Changeset in webkit [152384] by
-
- 5 edits in trunk/Source/WebCore
Simplify PageThrottler ownership.
https://bugs.webkit.org/show_bug.cgi?id=118372
Reviewed by Sam Weinig.
- page/Page.cpp:
(WebCore::Page::~Page):
- 'clearPage' method removed - just clear the own pointer.
- page/Page.h:
- make m_pageThrottler an OwnPtr.
- page/PageThrottler.cpp:
(WebCore::PageThrottler::~PageThrottler):
- moved 'setThrottled(false)' from 'clearPage' (removed).
(WebCore::PageThrottler::throttlePage):
(WebCore::PageThrottler::unthrottlePage):
- no need to check 'm_page'
- page/PageThrottler.h:
(WebCore::PageThrottler::create):
- create a PassOwnPtr, not PassRefPtr.
- 5:01 PM Changeset in webkit [152383] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Updates to support changes in CoreGraphics libraries.
https://bugs.webkit.org/show_bug.cgi?id=118373
Reviewed by Anders Carlsson.
- WebCorePrefix.h: Include definitions for isnan/round/roundf for versions of
Visual Studio that do not provide them natively.
- 4:56 PM Changeset in webkit [152382] by
-
- 13 edits in trunk/Source
Implement mechanism to detect (partially) hidden blocked plugins.
https://bugs.webkit.org/show_bug.cgi?id=117998
Patch by Gordon Sheridan <gordon_sheridan@apple.com> on 2013-07-03
Reviewed by Dean Jackson.
Source/WebCore:
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::replacementTextRect):
Added private method for calculating the size of the replacement text for blocked plugins.
(WebCore::RenderEmbeddedObject::isReplacementObscured):
Added public method to determine if the EMBED element used for a blocked plugin is inaccessible to the user.
- rendering/RenderEmbeddedObject.h:
Declare the two new methods mentioned above.
- WebCore.exp.in:
Export RenderEmbeddedObject::isReplacementObscured().
Source/WebKit2:
- Shared/Plugins/Netscape/PluginInformation.h:
- Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::plugInInformationReplacementObscuredKey):
Add key for plugInInformation dictionaries.
(WebKit::createPluginInformationDictionary):
Add boolean parameter identifying whether the replacement for a blocked plugin is obscured, and add it to the dictionary.
- Shared/API/c/WKPluginInformation.h:
- Shared/API/c/WKPluginInformation.cpp:
(WKPluginInformationReplacementObscuredKey):
Provide the C API for the plugInInformationReplacementObscuredKey().
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
Add bool replacementObscured parameter to pass on argument to createPluginInformationDictionary().
- UIProcess/WebPageProxy.messages.in:
Add bool replacementObscured parameter to DidBlockInsecurePluginVersion() message.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Invoke isReplacementObscured() method for blocked plugins.
- 4:38 PM Changeset in webkit [152381] by
-
- 2 edits in trunk/Source/WTF
[Windows] Unreviewed build correction.
- WTF.vcxproj/copy-files.cmd: Limit path (for this file) to DOS-only to avoid
the Cygwin variant of rmdir from being used.
- 4:13 PM Changeset in webkit [152380] by
-
- 3 edits in trunk/Source/WebInspectorUI
Guard remaining calls to decodeURIComponent with a try/catch.
https://bugs.webkit.org/show_bug.cgi?id=118371
Reviewed by Joseph Pecoraro.
- UserInterface/Main.js:
(WebInspector.displayNameForURL):
(WebInspector.updateWindowTitle):
- UserInterface/Utilities.js:
(arrayResult):
(queryString):
- 3:33 PM Changeset in webkit [152379] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152375. <rdar://problem/14349560>
- 3:31 PM Changeset in webkit [152378] by
-
- 2 edits in tags/Safari-537.48.2/Source/WebKit2
Merged r152375. <rdar://problem/14349560>
- 3:30 PM Changeset in webkit [152377] by
-
- 5 edits in tags/Safari-537.48.2/Source
Versioning.
- 3:28 PM Changeset in webkit [152376] by
-
- 1 copy in tags/Safari-537.48.2
New Tag.
- 3:28 PM Changeset in webkit [152375] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/14271105> Flash Player: deny ipc-posix-sem 59918130
<rdar://problem/14349560> Flash Player: deny ipc-posix-sem MacromediaSemaphoreDig on many sites
Reviewed by Sam Weinig.
- Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb: semaphore-owner doesn't appear to work the way we need it to, removing it (at least for now).
- 1:19 PM Changeset in webkit [152374] by
-
- 2 edits in trunk/Source/WebInspectorUI
Ran update-webkit-localizable-strings.
Rubber-stamped by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js:
- 1:16 PM Changeset in webkit [152373] by
-
- 1 edit1 add in trunk/Tools
Add Makefile to WebKitLauncher
https://bugs.webkit.org/show_bug.cgi?id=118365
Reviewed by Mark Rowe.
- WebKitLauncher/Makefile: Added.
- 12:45 PM Changeset in webkit [152372] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Skipping inspector tests that had other expectations, because specific rules override
general rules, and we need to skip all inspector tests.
<rdar://problem/12318375>
- platform/mac/TestExpectations:
- 11:50 AM Changeset in webkit [152371] by
-
- 3 edits in trunk/Tools
[ATK] Leak: more leaks in AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118362
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-03
Reviewed by Christophe Dumez.
Free the memory created by g_strdup_printf.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::language):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::language):
- 11:40 AM Changeset in webkit [152370] by
-
- 2 edits in branches/safari-537-branch/Tools
Merged r152195.
- 11:06 AM Changeset in webkit [152369] by
-
- 4 edits in trunk
WebTextCheckerClient doesn't initialize output arguments.
https://bugs.webkit.org/show_bug.cgi?id=83683
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-03
Reviewed by Martin Robinson.
Source/WebKit2:
Callers of checkSpellingOfString and checkGrammarOfString expect
certain default values when no misspelled (or bad grammar) string
is found. They try to do that by initialising the reply arguments
that go into the IPC calls, but these values are ultimately ignored (see
HandleMessage.h, where the replyArguments are declared).
In the past, this seems to have led to various issues, (see
TextCheckingHelper::findFirstMisspelling in TextCheckingHelper.cpp),
where these return values are asserted and checked to be in the right range.
This patch initialises the values, so even if no available client
implements the methods (or if the implementation forgets to do it) the callers
will have their expected output.
However, and for a general case, we probably need a way to tell the caller
that any existing value in the output arguments will be ignored.
- UIProcess/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::checkSpellingOfString):
(WebKit::WebTextCheckerClient::checkGrammarOfString):
LayoutTests:
Unskip editing/pasteboard/pasting-empty-html-falls-back-to-text.html, which no longer
crashes after the fix.
- platform/gtk-wk2/TestExpectations:
- 10:45 AM Changeset in webkit [152368] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152317. <rdar://problem/14309423>
- 10:35 AM Changeset in webkit [152367] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][WK2] SIGSEV in WebKit::WebPageContextMenuClient::customContextMenuItemSelected
https://bugs.webkit.org/show_bug.cgi?id=116867
Reviewed by Anders Carlsson.
We did not reset the clients on WebPageProxy::close(), so right
clicking on a link after starting the navigation to some other
page was causing crashes because code was trying to access an
already freed m_contextMenuClient.
There were some other clients that could potentially trigger the
same issues. Reset them all to null to prevent this situation.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
- 10:28 AM Changeset in webkit [152366] by
-
- 2 edits in trunk/Tools
Xcode often gets in a state where the debugger is completely unresponsive
https://bugs.webkit.org/show_bug.cgi?id=118157
The GetPointeeData() operations we use to retrieve strings is extremely expensive.
Rather than pull the character data out of the debugger one byte at a time
through the GetPointeeData() API, retrieve the memory contents of the string through
the ReadMemory() API, and convert the retrieved memory into a python string.
Reviewed by Anders Carlsson.
- lldb/lldb_webkit.py:
(lldb_init_module.lldb_webkit):
(guess_string_length):
(ustring_to_string):
(lstring_to_string):
- 10:28 AM Changeset in webkit [152365] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Skip inspector tests, because they are failing with production builds.
<rdar://problem/12318375>
- platform/mac/TestExpectations:
- 10:10 AM Changeset in webkit [152364] by
-
- 5 edits in tags/Safari-537.48.1/Source
Versioning.
- 10:07 AM Changeset in webkit [152363] by
-
- 1 copy in tags/Safari-537.48.1
New Tag.
- 10:05 AM Changeset in webkit [152362] by
-
- 3 edits in trunk/Source/WTF
Unreviewed, rolling out r152356.
http://trac.webkit.org/changeset/152356
https://bugs.webkit.org/show_bug.cgi?id=118361
Broke JSCore tests (Requested by andersca on #webkit).
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::reallocate):
(WTF::StringImpl::create):
- wtf/text/StringImpl.h:
- 10:03 AM Changeset in webkit [152361] by
-
- 1 delete in tags/Safari-537.48.1
Remove Tag.
- 9:48 AM Changeset in webkit [152360] by
-
- 5 edits in branches/safari-537-branch/Source
Versioning.
- 9:46 AM Changeset in webkit [152359] by
-
- 5 edits in tags/Safari-537.48.1/Source
Versioning.
- 9:43 AM Changeset in webkit [152358] by
-
- 1 copy in tags/Safari-537.48.1
New Tag.
- 9:12 AM Changeset in webkit [152357] by
-
- 2 edits in trunk/Source/WebKit2
Output arguments used in IPC calls should be returned initialised
https://bugs.webkit.org/show_bug.cgi?id=118354
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-03
Reviewed by Anders Carlsson.
When Download::shouldDecodeSourceDataOfMIMEType and Download::retrieveDestinationWithSuggestedFilename
call DownloadProxy::shouldDecodeSourceDataOfMIMEType and DownloadProxy::decideDestinationWithSuggestedFilename
through IPC, they assume the output arguments result and allowOverwrite have
been initialised.
This patch initialises these arguments also in the unlikely event that a
m_webContext is not available.
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::shouldDecodeSourceDataOfMIMEType):
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
- 9:03 AM EFLWebKit edited by
- Added a short paragraph linking to the instructions on how to work … (diff)
- 8:49 AM PythonGuidelines edited by
- Added section on how to work with distros that come with Python 3 as … (diff)
- 8:38 AM Changeset in webkit [152356] by
-
- 3 edits in trunk/Source/WTF
Remove code duplication from StringImpl create()/reallocate() methods
https://bugs.webkit.org/show_bug.cgi?id=118355
Reviewed by Anders Carlsson.
StringImpl create()/reallocate() methods accepting LChar and UChar used to have
duplicated code. The code duplication is removed now via used templates.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::constructInternal):
(WTF::LChar):
(WTF::StringImpl::createUninitializedInternal):
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::reallocateInternal):
(WTF::StringImpl::reallocate):
(WTF::StringImpl::createInternal):
(WTF::StringImpl::create):
- wtf/text/StringImpl.h:
- 8:28 AM Changeset in webkit [152355] by
-
- 2 edits in trunk/Source/WebCore
Speculative build fix after r152340.
- WebCore.exp.in:
- 7:52 AM Changeset in webkit [152354] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][GTK] Invalid ASSERTs in WebResources loading code
https://bugs.webkit.org/show_bug.cgi?id=118352
Reviewed by Carlos Garcia Campos.
The WebKitWebView keeps track of the resources being loaded in a
map. A couple of ASSERTs verify that every loaded resource is
stored in that map.
The map that is cleared each time a new load starts so there is a
small chance that we get notifications for resources that
correspond to previous page loads
(and thus are not stored in the map). We should remove the ASSERT
which is not valid anymore.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewGetLoadingWebResource):
- 7:18 AM Changeset in webkit [152353] by
-
- 15 edits in trunk/Source/WebCore
Append overloading function for isFooElement
https://bugs.webkit.org/show_bug.cgi?id=118334
Reviewed by Antti Koivisto.
Node::hasTagName needs additional isElementNode() check when it is triggered.
So conversion from Element* to Node* in isFooElement should be avoided.
Therefore, to support both Node* and Element* as an argument of isFooElement,
this patch appends overloading inline function.
- css/CSSStyleSheet.cpp:
(WebCore::isAcceptableCSSStyleSheetParent):
- css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::scopeFor):
- dom/Node.cpp:
(WebCore::Node::numberOfScopedHTMLStyleChildren):
- html/HTMLAnchorElement.h:
(WebCore::isHTMLAnchorElement):
- html/HTMLAreaElement.h:
(WebCore::isHTMLAreaElement):
- html/HTMLAudioElement.h:
(WebCore::isHTMLAudioElement):
- html/HTMLFormElement.h:
(WebCore::isHTMLFormElement):
- html/HTMLImageElement.h:
(WebCore::isHTMLImageElement):
- html/HTMLInputElement.h:
(WebCore::isHTMLInputElement):
- html/HTMLLabelElement.h:
(WebCore::isHTMLLabelElement):
- html/HTMLOptGroupElement.h:
(WebCore::isHTMLOptGroupElement):
- html/HTMLOptionElement.h:
(WebCore::isHTMLOptionElement):
- html/HTMLStyleElement.h:
(WebCore::isHTMLStyleElement):
(WebCore::toHTMLStyleElement):
- html/HTMLTextAreaElement.h:
(WebCore::isHTMLTextAreaElement):
- 6:54 AM Changeset in webkit [152352] by
-
- 4 edits2 adds in trunk
Gif: zero filling should use memset instead of setRGBA for every pixel
https://bugs.webkit.org/show_bug.cgi?id=118350
Patch by Balazs Kelemen <b.kelemen@samsung.com> on 2013-07-03
Reviewed by Allan Sandfeld Jensen.
No new tests. Actually it is not covered by existing tests. Surprisingly we haven't got pixel
tests for animated images. Given that this patch is pretty trivial I don't think it's worth the
cost to start introducing such tests.
I added a manual test: animated-gif-dispose-background.html.
GIFImageDecoder::initializeFrameBuffer use a loop to fill a subrect with tranparent pixels.
This is extremely ineffecient. The use case for this code path is not frequent on the web
but it's still better to fix it.
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::zeroFillFrameRect):
- platform/image-decoders/ImageDecoder.h:
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::initFrameBuffer):
Fixed indentation in addition.
- 5:59 AM Changeset in webkit [152351] by
-
- 3 edits in trunk/Source/WebCore
TextureUnit code optimization
https://bugs.webkit.org/show_bug.cgi?id=117868
Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-07-03
Reviewed by Noam Rosenthal.
According to OpenGL ES 2.0 specification it is not possible to use both
texture2D and textureCubeMap in one texture unit.
This patch reduces amount of code, slightly increases rendering performance
and makes WebKit more consistent with OpenGL.
No new tests. Covered by existing tests:
LayoutTests/webgl/conformance/textures/tex-image-webgl.html
LayoutTests/webgl/conformance/textures/texture-complete.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::bindTexture):
(WebCore::WebGLRenderingContext::deleteTexture):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::handleNPOTTextures):
(WebCore::WebGLRenderingContext::validateTextureBinding):
(WebCore::WebGLRenderingContext::restoreCurrentTexture2D):
- html/canvas/WebGLRenderingContext.h:
- 3:50 AM Changeset in webkit [152350] by
-
- 21 edits in trunk/Source/WebCore
Stop inheriting SVGFilterPrimitiveStandardAttributes in SVG
https://bugs.webkit.org/show_bug.cgi?id=118305
Reviewed by Kentaro Hara.
Stop inheriting SVGFilterPrimitiveStandardAttributes in SVG and use
Web IDL implements instead to get rid of multiple inheritance and
follow the latest specification:
No new tests, no behavior change.
- CMakeLists.txt:
- DerivedSources.pri:
- GNUmakefile.list.am:
- svg/SVGFEBlendElement.idl:
- svg/SVGFEColorMatrixElement.idl:
- svg/SVGFEComponentTransferElement.idl:
- svg/SVGFECompositeElement.idl:
- svg/SVGFEConvolveMatrixElement.idl:
- svg/SVGFEDiffuseLightingElement.idl:
- svg/SVGFEDisplacementMapElement.idl:
- svg/SVGFEDropShadowElement.idl:
- svg/SVGFEFloodElement.idl:
- svg/SVGFEGaussianBlurElement.idl:
- svg/SVGFEImageElement.idl:
- svg/SVGFEMergeElement.idl:
- svg/SVGFEMorphologyElement.idl:
- svg/SVGFEOffsetElement.idl:
- svg/SVGFESpecularLightingElement.idl:
- svg/SVGFETileElement.idl:
- svg/SVGFETurbulenceElement.idl:
- 3:19 AM Changeset in webkit [152349] by
-
- 2 edits in trunk/Source/WTF
Fix cast-align warnings in FastMalloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=117991
Reviewed by Mark Hahnenberg.
- wtf/FastMalloc.cpp:
- 3:13 AM Changeset in webkit [152348] by
-
- 6 edits in trunk/Source
H&R Block 2010 Help window can not be reopened.
https://bugs.webkit.org/show_bug.cgi?id=118342
Patch by Zalan Bujtas <Alan Bujtas> on 2013-07-03
Reviewed by Antti Koivisto.
http://trac.webkit.org/changeset/118916 changed the window.focus() behaviour so that
only the opener can (re)focus() a particular window.
H&R Block app relies on the relaxed window.focus() rules.
Source/WebCore:
- WebCore.exp.in:
- platform/RuntimeApplicationChecks.cpp:
(WebCore::applicationIsHRBlock):
- platform/RuntimeApplicationChecks.h:
Source/WebKit/mac:
- WebView/WebView.mm:
(shouldRestrictWindowFocus):
(-[WebView _preferencesChanged:]):
- 3:06 AM Changeset in webkit [152347] by
-
- 2 edits in trunk/Source/WebCore
Further build fixing for build configurations that disable CSS regions support.
- dom/PseudoElement.h: Wrap shouldMoveToFlowThread override into the ENABLE(CSS_REGIONS) build guard.
- 3:00 AM Changeset in webkit [152346] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix after r152320 and r152345 for build configurations that enable
SVG support but disable CSS regions support.
- svg/SVGElement.cpp: Wrap shouldMoveToFlowThread override into the ENABLE(CSS_REGIONS) build guard.
- svg/SVGElement.h: Ditto.
- 2:35 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:33 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:02 AM Changeset in webkit [152345] by
-
- 3 edits in trunk/Source/WebCore
[CSS Regions] Improve implementation of elements in region being flowed to another flow thread
https://bugs.webkit.org/show_bug.cgi?id=118300
Based on patch by Zoltán Árvai <zarvai@inf.u-szeged.hu>
Patch by Radu Stavila <stavila@adobe.com> on 2013-07-03
Reviewed by Csaba Osztrogonác.
Fixed CSS_REGIONS guard.
- dom/Element.h:
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::elementInsideRegionNeedsRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
- 1:43 AM Changeset in webkit [152344] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Migrate WebKitWebContext to GTask
https://bugs.webkit.org/show_bug.cgi?id=117153
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextGetPluginThread):
(webkit_web_context_get_plugins):
(webkit_web_context_get_plugins_finish):
- 1:03 AM Changeset in webkit [152343] by
-
- 15 edits in trunk/Source/WebCore
Move SVGTests attributes parsing to SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=118292
Reviewed by Darin Adler.
Move SVGTests attributes parsing to SVGGraphicsElement instead of doing
this in each of its subclasses. SVGGraphicsElement is now the one
subclassing SVGTests after r152167.
No new tests, no behavior change.
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::isSupportedAttribute):
(WebCore::SVGAElement::parseAttribute):
- svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::isSupportedAttribute):
(WebCore::SVGCircleElement::parseAttribute):
(WebCore::SVGCircleElement::svgAttributeChanged):
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::isSupportedAttribute):
(WebCore::SVGClipPathElement::parseAttribute):
- svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::isSupportedAttribute):
(WebCore::SVGEllipseElement::parseAttribute):
(WebCore::SVGEllipseElement::svgAttributeChanged):
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::isSupportedAttribute):
(WebCore::SVGForeignObjectElement::parseAttribute):
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::isSupportedAttribute):
(WebCore::SVGGElement::parseAttribute):
(WebCore::SVGGElement::svgAttributeChanged):
- svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::isSupportedAttribute):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::isSupportedAttribute):
(WebCore::SVGImageElement::parseAttribute):
(WebCore::SVGImageElement::svgAttributeChanged):
- svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::isSupportedAttribute):
(WebCore::SVGLineElement::parseAttribute):
(WebCore::SVGLineElement::svgAttributeChanged):
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::isSupportedAttribute):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::isSupportedAttribute):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::svgAttributeChanged):
- svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::isSupportedAttribute):
(WebCore::SVGRectElement::parseAttribute):
(WebCore::SVGRectElement::svgAttributeChanged):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::svgAttributeChanged): Fall back to calling
SVGGraphicsElement::svgAttributeChanged() instead of
SVGStyledElement::svgAttributeChanged() as SVGGraphicsElement is the
parent class and it takes care of parsing SVGTests attributes now.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::isSupportedAttribute):
(WebCore::SVGUseElement::parseAttribute):
(WebCore::SVGUseElement::svgAttributeChanged):
- 12:44 AM Changeset in webkit [152342] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipping test to paint the debug bot green.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-03
- platform/qt/TestExpectations:
- 12:30 AM Changeset in webkit [152341] by
-
- 2 edits in trunk/Tools
[GTK] Let F5 refresh the page in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=117638
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-07-03
Reviewed by Carlos Garcia Campos.
Also use the correct icon for the refresh button that was already there.
- MiniBrowser/gtk/BrowserWindow.c:
(browser_window_init):
Jul 2, 2013:
- 10:54 PM Changeset in webkit [152340] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Invalidate FontCache before purging MemoryCache upon WebProcess termination/closure
https://bugs.webkit.org/show_bug.cgi?id=118280
Reviewed by Darin Adler.
Invalidate the FontCache before disabling and purging the MemoryCache in WebProcess::didClose
and WebProcess::terminate. This frees up additional references to objects that were held
by the FontCache, reducing the amount of 'LEAK: *' output when exiting MiniBrowser or
WebKitTestRunner in debug builds.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::terminate):
(WebKit::WebProcess::didClose):
- 10:30 PM Changeset in webkit [152339] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG::Node::m_opInfo2 should also be a uintptr_t
https://bugs.webkit.org/show_bug.cgi?id=118340
Reviewed by Sam Weinig.
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
- 10:21 PM Changeset in webkit [152338] by
-
- 6 edits in branches/dfgFourthTier/Source
Unreviewed, fix 32-bit build.
Source/JavaScriptCore:
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::comparePtr):
(MacroAssembler):
- dfg/DFGBinarySwitch.cpp:
(JSC::DFG::BinarySwitch::advance):
- dfg/DFGBinarySwitch.h:
(JSC::DFG::BinarySwitch::caseValue):
Source/WTF:
- wtf/Platform.h:
- 10:07 PM Changeset in webkit [152337] by
-
- 2 edits in trunk/Source/WebCore
Modernize QualifiedName by wrapping gNameCache in a function and using more early exits
https://bugs.webkit.org/show_bug.cgi?id=118299
Reviewed by Andreas Kling.
Did cleanups.
- dom/QualifiedName.cpp:
(WebCore::qualifiedNameCache): Added to wrap gNameCache.
(WebCore::QualifiedName::QualifiedName):
(WebCore::QualifiedName::QualifiedNameImpl::~QualifiedNameImpl):
(WebCore::QualifiedName::toString): Use early exit and StringBuilder.
(WebCore::QualifiedName::init): Use early exit.
- 8:45 PM Changeset in webkit [152336] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Have fewer Arrayify's
https://bugs.webkit.org/show_bug.cgi?id=118335
Reviewed by Mark Hahnenberg.
A lot of Arrayify's arise because some program saw Int32 arrays early on in
execution, but then they all got converted to Double arrays and the program
will never see Int32 arrays ever again. Prior to this change you would always
have an Arrayify in this case. But with this change, the first time that an
ArrayProfile is about to go polymorphic in computeUpdatedPrediction(), it
instead forcibly monomorphises itself to the latest-seen structure.
Thereafter it will never again perform this monomorphisation. This is
controlled by ArrayProfile::m_didPerformFirstRunPruning. This is a 5%
speed-up on Kraken/imaging-gaussian-blur with the FTL enabled, and it
unblocks a bunch of stuff we want to do in the future because it makes a
bunch of loops effect-free.
We will still want to implement Arrayify hoisting in the future, but this is
great anyway because it's better to not have Arrayifications than it is to
have hoisted Arrayifications.
- bytecode/ArrayProfile.cpp:
(JSC::ArrayProfile::computeUpdatedPrediction):
(JSC::ArrayProfile::briefDescription):
(JSC):
(JSC::ArrayProfile::briefDescriptionWithoutUpdating):
- bytecode/ArrayProfile.h:
(JSC::ArrayProfile::ArrayProfile):
(ArrayProfile):
- 8:19 PM Changeset in webkit [152335] by
-
- 2 edits in trunk/Source/WebCore
Don't set z-index: 0 on lots of elements with -webkit-overflow-scrolling: touch
https://bugs.webkit.org/show_bug.cgi?id=118337
Reviewed by Benjamin Poulain.
-webkit-overflow-scrolling: touch is an inherited property that, on iOS, controls
the behavior of overflow scrolling content, and causes overflow scrolling elements
to become CSS stacking contexts.
However, the code was too aggressive in setting style->setZIndex(0), doing so
for any element with overflow != hidden. Since the default for overflow is visible,
that meant almost every element.
Previously, this didn't really matter. However, since r125693, any renderer with non-auto
z-index gets a RenderLayer, and that RenderLayer will become a stacking context. The result
was too many RenderLayers and incorrect stacking context behavior.
Fix by ensuring that -webkit-overflow-scrolling: touch only affects elements which
are actually scrollable.
Also move the code that does this to below the code that adjust overflow style
for different elements.
- css/StyleResolver.cpp:
(WebCore::isScrollableOverflow):
(WebCore::StyleResolver::adjustRenderStyle):
- 7:45 PM Changeset in webkit [152334] by
-
- 2 edits in trunk/Tools
- 5:48 PM Changeset in webkit [152333] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r152318.
http://trac.webkit.org/changeset/152318
https://bugs.webkit.org/show_bug.cgi?id=118333
This patch broke media/track/track-automatic-subtitles.html on
Mac (Requested by dfarler on #webkit).
Source/WebCore:
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore):
LayoutTests:
- media/track/track-legacyapi-with-automatic-mode-expected.txt: Removed.
- media/track/track-legacyapi-with-automatic-mode.html: Removed.
- 5:39 PM Changeset in webkit [152332] by
-
- 11 edits in branches/safari-537-branch/Source
Merged r152328. <rdar://problem/14320278>
- 5:32 PM Changeset in webkit [152331] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding myself to contributors.json.
- Scripts/webkitpy/common/config/contributors.json:
- 5:20 PM Changeset in webkit [152330] by
-
- 3 edits2 adds in trunk
Change event should not be dispatched by clicking a scrollbar of select listbox
https://bugs.webkit.org/show_bug.cgi?id=118019
<rdar://problem/14297760>
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-02
Reviewed by Dean Jackson.
Source/WebCore:
Test: fast/forms/select/listbox-click-on-scrollbar.html
Merge the following:
http://src.chromium.org/viewvc/blink?view=revision&revision=151689
https://chromium.googlesource.com/chromium/blink/+/492549b0fcaa58a85aa0797446b62985a263704f
Previously, a select element with the multiple attribute would dispatch
an onChanged event when the scrollbar is clicked. This patch corrects this
issue by only calling listBoxOnChange(), which fires the onChanged event,
when an actual option is clicked.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childrenChanged): Updated to clear the list
of selected items when when an <option> element is added to/deleted from its <select> element.
(Without this addition, if a option was selected, and then JavaScript was used to modify
the <select> element, and then the scrollbar was clicked, an onChanged event would fire
because it remembers the previously selected option.)
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updated to
only call listBoxOnChange() if at least one option is selected.
LayoutTests:
Merge the following:
http://src.chromium.org/viewvc/blink?view=revision&revision=151689
https://chromium.googlesource.com/chromium/blink/+/492549b0fcaa58a85aa0797446b62985a263704f
- fast/forms/select/listbox-click-on-scrollbar-expected.txt: Added.
- fast/forms/select/listbox-click-on-scrollbar.html: Added.
Tests that an onChange() event is not fired when the scrollbar of a
<select multiple> element is clicked.
- 5:18 PM Changeset in webkit [152329] by
-
- 3 edits in trunk/Source/WebCore
Preparing Windows WebGL build system.
https://bugs.webkit.org/show_bug.cgi?id=118325
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.vcxproj: Added EGL files, removed unused GraphicsContext3DOpenGL.cpp.
- WebCore.vcxproj/WebCore.vcxproj.filters: Added EGL filter and files, removed unused GraphicsContext3DOpenGL.cpp.
- 5:06 PM Changeset in webkit [152328] by
-
- 11 edits in trunk/Source
The callback for WKPageGetPlugInInformation needs info about whether or not there are any
non-playing instances of the plug-in on the page
https://bugs.webkit.org/show_bug.cgi?id=118330
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.exp.in:
Expose a symbol so it can be used in WebKit2.
Source/WebKit2:
Add another key value pair to the dictionary passed to the callback.
- Shared/API/c/WKPluginInformation.cpp:
(WKPlugInInformationPageContainsNonPlayingInstanceOfPlugInKey):
- Shared/API/c/WKPluginInformation.h:
- Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::plugInInformationPageContainsNonPlayingInstanceOfPlugInKey):
(WebKit::createPlugInInformationDictionary):
Add the information about whether or not the page contains a non-playing instance of that
plug-in to the plug-in information dictionary.
- Shared/Plugins/Netscape/PluginInformation.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::containsPlugInCallback):
Check if any of the MIME types of the plug-in instances that are present on the page but are
not playing match the instance of plug-in being searched for.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::addPlugInMimeTypesFromNodeListForNonPlayingPlugIns):
Based roughly off of addPlugInsFromNodeListMatchingPlugInOrigin in
HTMLPlugInImageElement.cpp.
(WebKit::WebPage::containsPluginViewsWithPluginProcessToken):
Based roughly off of HTMLPlugInImageElement::restartSimilarPlugIns.
- 4:04 PM Changeset in webkit [152327] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Merged r152288. <rdar://problem/14338353>
- 3:54 PM Changeset in webkit [152326] by
-
- 5 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: add option to disable OSR entry in loops
https://bugs.webkit.org/show_bug.cgi?id=118329
Reviewed by Mark Hahnenberg.
This adds that option, and also makes the OSR exit reoptimization trigger rely less on
OSR entry failing. Now even if we never attempt OSR entry but our execution counter gets
high after a small number of OSR exits, we will recompile.
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::handleExitCounts):
- dfg/DFGOperations.cpp:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):
- runtime/Options.h:
(JSC):
- 3:18 PM Changeset in webkit [152325] by
-
- 2 edits in trunk/Source/WebCore
Added getProcAddress implementation for Windows in OpenGLShims.
https://bugs.webkit.org/show_bug.cgi?id=118312
Reviewed by Brent Fulgham.
- platform/graphics/OpenGLShims.cpp:
(WebCore::getProcAddress): Added for Windows.
- 3:12 PM Changeset in webkit [152324] by
-
- 2 edits in trunk/Source/WebCore
media/unsupported-rtsp.html is failing
https://bugs.webkit.org/show_bug.cgi?id=118327
Reviewed by Eric Carlson.
Fixes the media/unsupported-rtsp.html test.
Set the contentType field of contentInformationRequest in order to trigger AVFoundation to
notice that loading failed and generate an error.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::notifyFinished):
- 2:58 PM Changeset in webkit [152323] by
-
- 2 edits in trunk/Source/WebCore
Fixed compile error in non-X11 platforms using EGL.
https://bugs.webkit.org/show_bug.cgi?id=118323
Reviewed by Brent Fulgham.
- platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::createPixmapContext): Put all X11-specific code into #if PLATFORM(X11).
- 2:45 PM Changeset in webkit [152322] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed rebaseline of media/video-controls-captions-trackmenu-localized after r151697.
- platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt: Removed.
"Unknown SDH" -> "Unknown".
- 2:24 PM Changeset in webkit [152321] by
-
- 2 edits in trunk/LayoutTests
Unreviewed rebaseline of Mac Lion fast/js/global-constructors-attributes after r151914.
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
WaveTable -> PeriodicWave
- 1:43 PM Changeset in webkit [152320] by
-
- 22 edits in trunk
[CSS Regions] Improve implementation of elements in region being flowed to another flow thread
https://bugs.webkit.org/show_bug.cgi?id=118300
Patch by Radu Stavila <stavila@adobe.com> on 2013-07-02
Reviewed by David Hyatt.
Source/WebCore:
Methods that must be const have been turned back into const. Code has been better organized.
Performance is better. Tests have been added to.
- dom/Element.cpp:
(WebCore::Element::detach):
(WebCore::Element::setIsInsideRegion):
(WebCore::Element::isInsideRegion):
(WebCore::Element::shouldMoveToFlowThread):
- dom/Element.h:
- dom/ElementRareData.h:
(WebCore::ElementRareData::isInsideRegion):
(WebCore::ElementRareData::setIsInsideRegion):
(WebCore::ElementRareData::ElementRareData):
- dom/Node.cpp:
(WebCore::Node::isRegisteredWithNamedFlow):
- dom/Node.h:
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
(WebCore::NodeRenderingContext::elementInsideRegionNeedsRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
- dom/NodeRenderingContext.h:
- dom/PseudoElement.h:
- dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
- dom/Text.h:
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::unregisterNamedFlowContentNode):
(WebCore::FlowThreadController::isContentNodeRegisteredWithAnyNamedFlow):
- rendering/FlowThreadController.h:
- rendering/RenderObject.h:
- rendering/RenderRegion.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::shouldMoveToFlowThread):
- svg/SVGElement.h:
LayoutTests:
- fast/regions/flow-body-in-html.html:
- fast/regions/region-content-flown-into-region-expected.html:
- fast/regions/region-content-flown-into-region.html:
- fast/regions/universal-selector-children-to-the-same-region.html:
- 1:30 PM Changeset in webkit [152319] by
-
- 2 edits in trunk/LayoutTests
Skip cache partitioning tests on Lion.
Rubber stamped by Jeffrey Pfau.
- platform/mac-lion/TestExpectations:
http/tests/cache/partitioned-cache.html
http/tests/cache/partitioned-cache-iframe.html
- 1:28 PM Changeset in webkit [152318] by
-
- 3 edits2 adds in trunk
[Mac] .webkitClosedCaptionsVisible doesn't work with "Automatic" caption mode
https://bugs.webkit.org/show_bug.cgi?id=118319
Reviewed by Darin Adler.
Source/WebCore:
Test: media/track/track-legacyapi-with-automatic-mode.html
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore): Don't apply "automatic"
logic when captions were enabled with .webkitClosedCaptionsVisible.
LayoutTests:
- media/track/track-legacyapi-with-automatic-mode-expected.txt: Added.
- media/track/track-legacyapi-with-automatic-mode.html: Added.
- 1:07 PM Changeset in webkit [152317] by
-
- 2 edits in trunk/Source/WebKit2
security/block-test.html fails when NetworkProcess is enabled
https://bugs.webkit.org/show_bug.cgi?id=118320
<rdar://problem/14309423>
Reviewed by Geoff Garen.
- NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::wasBlocked): (WebKit::NetworkResourceLoader::cannotShowURL): Implemented missing ResourceHandleClient functions.
- 12:51 PM Changeset in webkit [152316] by
-
- 2 edits in trunk/Source/WebKit2
Fix crash when PageBanner::detachFromPage() is called from WebPage::~WebPage().
https://bugs.webkit.org/show_bug.cgi?id=118268
Reviewed by Beth Dakin.
- WebProcess/WebPage/mac/PageBannerMac.mm:
(WebKit::PageBanner::detachFromPage): Add some null checks. m_webPage->corePage()
can be null if this method is called after the web page is closed.
- 12:50 PM Changeset in webkit [152315] by
-
- 2 edits in trunk/Source/WebCore
Always flip the coordinate system before drawing NSViews from Widget::paint
https://bugs.webkit.org/show_bug.cgi?id=118318
<rdar://problem/13895483>
Reviewed by Beth Dakin.
Undo the change that would not flip on 10.9; turns out the bug was in AppKit. Also remove the
_hasCanDrawSubviewsIntoLayerOrAncestor workaround since drawing works correctly now.
Also, pass flipped:NO when creating the NSGraphicsContext to indicate that the graphics context
is unflipped as far as AppKit knows (since we flipped it earlier).
- platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):
- 12:47 PM Changeset in webkit [152314] by
-
- 2 edits in trunk/Source/JavaScriptCore
Replace RELEASE_ASSERT with ASSERT in CodeBlock:: bytecodeOffsetForCallAtIndex
https://bugs.webkit.org/show_bug.cgi?id=118316
Reviewed by Geoffrey Garen.
This is causing some crashiness in release builds. We should replace it with an ASSERT
until we track down all the places that need fixing in bug 118315.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::bytecodeOffsetForCallAtIndex):
- 12:30 PM Changeset in webkit [152313] by
-
- 3 edits2 adds in trunk
empty inlines should not affect line-wrapping
https://bugs.webkit.org/show_bug.cgi?id=25638
Reviewed by David Hyatt.
Source/WebCore:
Don't break on empty inlines if we're in the middle of a word. I took this opportunity to
refactor the series of checks we perform to establish if we can break at the current position.
Test: fast/text/whitespace/inline-whitespace-wrapping-11.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::textBeginsWithBreakablePosition):
(WebCore::canBreakAtThisPosition):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/text/whitespace/inline-whitespace-wrapping-11-expected.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-11.html: Added.
- 12:30 PM Changeset in webkit [152312] by
-
- 1 copy in tags/Safari-537.48
New Tag.
- 12:29 PM Changeset in webkit [152311] by
-
- 1 delete in tags/Safari-537.48
Remove Tag.
- 12:27 PM Changeset in webkit [152310] by
-
- 6 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r152199. <rdar://problem/14287209>
- 12:24 PM Changeset in webkit [152309] by
-
- 13 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r152141. <rdar://problem/14283900>
- 12:21 PM Changeset in webkit [152308] by
-
- 6 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r152136. <rdar://problem/13899156>
- 12:17 PM Changeset in webkit [152307] by
-
- 6 edits2 copies in trunk/Source
Implement CoordinatedSurface for Threaded Coordinated Graphics
https://bugs.webkit.org/show_bug.cgi?id=109661
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-02
Reviewed by Noam Rosenthal.
This is a preparation patch for Threaded Coordianted Graphics.
This patch implements ThreadSafeCoordinatedSurface using ImageBuffer as a
backend. Also, this patch moves common implementation to CoordinatedSurface to
prevent duplication of code.
Source/WebCore:
- platform/graphics/texmap/coordinated/CoordinatedSurface.cpp:
(WebCore::CoordinatedSurface::CoordinatedSurface):
- platform/graphics/texmap/coordinated/CoordinatedSurface.h:
(WebCore::CoordinatedSurface::size):
(WebCore::CoordinatedSurface::flags):
- platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp: Added.
(WebCore::ThreadSafeCoordinatedSurface::create):
(WebCore::ThreadSafeCoordinatedSurface::ThreadSafeCoordinatedSurface):
(WebCore::ThreadSafeCoordinatedSurface::~ThreadSafeCoordinatedSurface):
(WebCore::ThreadSafeCoordinatedSurface::paintToSurface):
(WebCore::ThreadSafeCoordinatedSurface::copyToTexture):
- platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.h: Added.
Source/WebKit2:
- Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::WebCoordinatedSurface):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
- 12:09 PM Changeset in webkit [152306] by
-
- 4 edits in trunk/Source
plainText() is O(N2)
https://bugs.webkit.org/show_bug.cgi?id=118282
<rdar://problem/14284360>
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- editing/TextIterator.cpp:
(WebCore::plainText): Linear growth for a vector data type is O(N2).
Don't do that. Luckily, StringBuilder does the right thing automatically,
so we can just delete code.
Source/WTF:
- wtf/text/StringBuilder.cpp:
(WTF::expandCapacity): Factored out this helper function to simplify
some code that was duplicated in four places.
(WTF::StringBuilder::appendUninitializedSlow):
(WTF::StringBuilder::append): Use expandCapacity(). One of the cases
was not doing anything special, and so was O(N2).
Also, always call expandCapacity() it in a standard way, calling
capacity() first, so it's easy to tell at a glance that you got it right.
- 12:00 PM Changeset in webkit [152305] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: since the FTL disassembly hacks cannot distinguish between code and data, the LLVM disassembler symbol table callback should be able to deal gracefully with arbitrary garbage
https://bugs.webkit.org/show_bug.cgi?id=118313
Reviewed by Mark Hahnenberg.
Give it a mode where we can still crash on unrecognized reference types, so that we might
implement them in the future, but by default just print some stuff and keep going.
- disassembler/LLVMDisassembler.cpp:
(JSC):
(JSC::symbolLookupCallback):
- 11:15 AM Changeset in webkit [152304] by
-
- 1 copy in tags/Safari-537.48
New Tag.
- 11:14 AM Changeset in webkit [152303] by
-
- 6 edits3 adds in trunk
constrainScrollPositionForOverhang needs to handle scrollOrigin correctly
https://bugs.webkit.org/show_bug.cgi?id=118176
<rdar://problem/14301271>
Reviewed by Anders Carlsson.
Test: compositing/geometry/fixed-position-flipped-writing-mode.html
WebCore makes use of constrainScrollPositionForOverhang not only for
constraining fixed- and sticky-positioned elements to the viewport, but
also for clamping the tile cache's visible rect.
Therefore, constrainScrollPositionForOverhang needs to correctly take
the scrollOrigin into account. The easiest way I saw to do this was to
reimplement the function in terms of a pair of rect intersections
between a virtual scrollable "viewport" and the document (with a bit
of complication from headers and footers).
The first intersection is performed, then if the viewport doesn't fit,
it is pushed down and to the right, from the origin. Next, we intersect
again, this time pushing the rect up by the amount it overflowed the document
rect from the bottom right. This performs effectively the same constraint
as previously, but handles the scrollOrigin correctly and is also somewhat
easier to read and understand (with pictures).
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
Subtract the scrollOrigin out of the offset passed to scrollOffsetForFixedPosition,
it's expecting an offset without the origin included.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::constrainScrollPositionForOverhang):
Reimplement the function as described above.
Add a test that ensures that fixed position works with a scrollable document
and direction: rtl, which is one case where scrollOrigin is set.
Disable the test on Mac WebKit1 because of https://bugs.webkit.org/show_bug.cgi?id=118269.
- compositing/geometry/fixed-position-flipped-writing-mode-expected.txt: Added.
- compositing/geometry/fixed-position-flipped-writing-mode.html: Added.
- platform/mac/compositing/geometry/fixed-position-flipped-writing-mode-expected.png: Added.
- platform/mac/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 11:00 AM Changeset in webkit [152302] by
-
- 3 edits in branches/safari-537-branch/LayoutTests
Merged r152184. <rdar://problem/14304814>
- 10:54 AM Changeset in webkit [152301] by
-
- 5 edits in branches/dfgFourthTier/Source
fourthTier: FTL should use the equivalent of llvm opt -O2 by default
https://bugs.webkit.org/show_bug.cgi?id=118311
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Use a PassManagerBuilder instead of rolling our own.
This boosts our speed-up by another 5% or so.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- runtime/Options.h:
(JSC):
Source/WTF:
Reviewed by Mark Hahnenberg.
- wtf/LLVMHeaders.h:
- 10:53 AM Changeset in webkit [152300] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Windows] Unreviewed build correction for 'DebugSuffix' target.
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj: Must pass the
DEBUGSUFFIX definition to the nmake instance to be available during script processing.
- 10:37 AM Changeset in webkit [152299] by
-
- 16 edits2 deletes in trunk/Source/WebCore
Remove SVGStyledLocatableElement class
https://bugs.webkit.org/show_bug.cgi?id=118283
Reviewed by Dirk Schulze.
Remove SVGStyledLocatableElement class and have SVGGraphicsElement
inherit SVGStyledElement directly instead. SVGStyledLocatableElement
is no longer needed and according to the specification, SVGGraphicsElement
should inherit SVGStyledElement (actually SVGElement once we merge
SVGStyledElement into SVGElement).
No new tests, no behavior change.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.order:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorJS.pm:
(GetGnuVTableOffsetForType):
- svg/SVGAllInOne.cpp:
- svg/SVGElement.cpp:
(WebCore::SVGElement::getBoundingBox):
- svg/SVGElement.h:
- svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::SVGGraphicsElement):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
- svg/SVGGraphicsElement.h:
- svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::getTransformToElement):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::localCoordinateSpaceTransform):
- svg/SVGStyledLocatableElement.cpp: Removed.
- svg/SVGStyledLocatableElement.h: Removed.
- 9:50 AM Changeset in webkit [152298] by
-
- 2 edits in trunk/Tools
[ATK] Leak: leaks in AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118297
Fixed memory leak.
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-02
Reviewed by Christophe Dumez.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::stringValue):
- 9:26 AM Changeset in webkit [152297] by
-
- 3 edits in trunk/Source/WebCore
[Curl] Crash after download.
https://bugs.webkit.org/show_bug.cgi?id=118303
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-02
Reviewed by Brent Fulgham.
We need to make sure that the Curl easy handle is removed from the Curl multi handle before it's freed.
- platform/network/curl/CurlDownload.cpp:
(CurlDownloadManager::updateHandleList): Use addToCurl() and removeFromCurl() methods.
(CurlDownloadManager::addToCurl): Add method to add easy handle to multi handle.
(CurlDownloadManager::removeFromCurl): Add method to remove easy handle from multi handle, and then delete the handle.
(CurlDownloadManager::downloadThread): Use removeFromCurl() method.
(CurlDownload::~CurlDownload):
- platform/network/curl/CurlDownload.h: Avoid deleting Curl easy handle in destructor.
- 9:21 AM Changeset in webkit [152296] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed gardening. Added new common expectations for test after r151665.
- accessibility/box-styled-lists-expected.txt: Added shared expectation.
- platform/efl/TestExpectations: Removed failure expectation.
- platform/gtk/TestExpectations: Ditto.
- 9:19 AM Changeset in webkit [152295] by
-
- 4 edits in trunk/Tools
Fix WebKitTestRunner crashes.
https://bugs.webkit.org/show_bug.cgi?id=117630
Reviewed by Darin Adler.
Create static function to dump for WebProcess unresponsiveness status,
and use it before calling TestController::runTest().
Accessing TestController::m_currentInvocation before calling
TestController::runTest() can make crash because the invocation
instance will be assigned at the function.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::run):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::dumpWebProcessUnresponsiveness):
- WebKitTestRunner/TestInvocation.h:
- 9:13 AM Changeset in webkit [152294] by
-
- 1 edit1 move1 add in trunk/LayoutTests
Unreviewed gardening. Added new baselines for GTK after revision r151841 and r151868.
- accessibility/listitem-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/listitem-title-expected.txt.
- platform/gtk/accessibility/aria-tab-role-on-buttons-expected.txt: Added.
- 8:00 AM Changeset in webkit [152293] by
-
- 4 edits in trunk/Source/WebCore
[CSSRegions] No other SVG elements except the SVGRoot must have RegionInfo objects attached
https://bugs.webkit.org/show_bug.cgi?id=118295
Patch by Radu Stavila <stavila@adobe.com> on 2013-07-02
Reviewed by Antti Koivisto.
Only the SVGRoot element can be collected in a named flow. As such, no SVG element below the root should
be attached to a RenderBoxRegionInfo object.
A larger patch's test (https://bugs.webkit.org/show_bug.cgi?id=118300) is failing because of this.
This change will be covered by that test.
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::canHaveBoxInfoInRegion):
- rendering/RenderObject.h:
(WebCore::RenderObject::isRenderSVGBlock):
- rendering/svg/RenderSVGBlock.h:
- 7:32 AM Changeset in webkit [152292] by
-
- 2 edits in trunk/WebKitLibraries
Unreviewed, rolling out r152233.
http://trac.webkit.org/changeset/152233
https://bugs.webkit.org/show_bug.cgi?id=118304
hopeful attempt to restore windows buildage (Requested by
kling on #webkit).
- win/tools/vsprops/debugsuffix.props:
- 7:04 AM Changeset in webkit [152291] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Rebaseline background blend mode default test result.
- platform/mac/css3/compositing/background-blend-mode-default-value-expected.png:
- 6:48 AM Changeset in webkit [152290] by
-
- 6 edits in trunk/Source/WebCore
is/toHTMLStyleElement should use Element* for its argument
https://bugs.webkit.org/show_bug.cgi?id=118286
Reviewed by Andreas Kling.
To reduce unnecessary call of isElementNode(), this patch replaces argument
of is/toHTMLStyleElement from Node* to Element*. Plus, use Element::hasTagName
in collectActiveStyleSheets function for minor code refactoring since
its cost is cheaper than Node::hasTagName.
- css/CSSStyleSheet.cpp:
(WebCore::isAcceptableCSSStyleSheetParent):
- css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::scopeFor):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
- dom/Node.cpp:
(WebCore::Node::numberOfScopedHTMLStyleChildren):
- html/HTMLStyleElement.h:
(WebCore::isHTMLStyleElement):
(WebCore::toHTMLStyleElement):
- 6:36 AM Changeset in webkit [152289] by
-
- 3 edits in trunk/Source/WTF
Avoid code duplication inside String::append()
https://bugs.webkit.org/show_bug.cgi?id=118290
Reviewed by Anders Carlsson.
The implementation of 'append(UChar)' had been repeated inside 'append(LChar)',
this duplication is obviated now.
- wtf/text/WTFString.cpp:
(WTF::String::appendInternal):
(WTF::String::append):
- wtf/text/WTFString.h:
- 6:31 AM Changeset in webkit [152288] by
-
- 2 edits in trunk/LayoutTests
Skip fast/dom/timer-throttling-hidden-page.html after r152202.
<http://webkit.org/b/118301>
- 5:53 AM Changeset in webkit [152287] by
-
- 2 edits in trunk/LayoutTests
Skip 3 MathML tests that are failing after r152235.
<http://webkit.org/b/118298>
- 5:20 AM Changeset in webkit [152286] by
-
- 3 edits in trunk/Source/WebCore
Unexpose EditingPropertiesToInclude in EditingStyle.h after r151772
https://bugs.webkit.org/show_bug.cgi?id=118271
Reviewed by Andreas Kling.
Don't expose EditingPropertiesToInclude in EditingStyle.h and do other cleanups as described below.
No new tests since there should be no behavioral change.
- editing/EditingStyle.cpp:
(WebCore::copyEditingProperties): Use newly defined numAllEditingProperties and numInheritableEditingProperties
instead of a magic number of 2.
(WebCore::copyPropertiesFromComputedStyle): Renamed from editingStyleFromComputedStyle. It now takes ComputedStyleExtractor and
PropertiesToInclude instead of Node* and EditingPropertiesToInclude and handles AllProperties. Also added a helper that takes Node*.
(WebCore::EditingStyle::init): Calls copyPropertiesFromComputedStyle. Unfortunately, we need to special-case EditingPropertiesInEffect
and not set background-color and text-decoration. This is required probably due to a bug elsewhere.
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::extractEditingProperties): Renamed from EditingStyle::removeAllButEditingProperties; takes PropertiesToInclude instead of
EditingPropertiesToInclude since the only caller of this function, EditingStyle::mergeInlineAndImplicitStyleOfElement, was converting
the type.
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
- editing/EditingStyle.h:
- 4:56 AM Changeset in webkit [152285] by
-
- 7 edits in trunk/Source/WebCore
Introduce toSVGInlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=118289
Reviewed by Andreas Kling.
As a step to change static_cast with toXXX, static_cast<SVGInlineTextBox*> can
be changed with toSVGInlineTextBox().
Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=153345
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::positionForPoint):
- rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paintSelectionBackground):
(WebCore::SVGInlineFlowBox::paint):
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
- rendering/svg/SVGInlineTextBox.h:
(WebCore::toSVGInlineTextBox):
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGInlineTextBoxes):
- rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
- rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::collectTextBoxesInFlowBox):
- 4:50 AM Changeset in webkit [152284] by
-
- 2 edits in trunk/Source/WebCore
Simplify SVGTextContentElement::elementFromRenderer()
https://bugs.webkit.org/show_bug.cgi?id=118284
Reviewed by Andreas Kling.
Simplify SVGTextContentElement::elementFromRenderer() by leveraging
SVGElement::isTextContent() methods instead of explicitly checking
for tag names.
No new tests, no behavior change.
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::elementFromRenderer):
- 4:19 AM Changeset in webkit [152283] by
-
- 2 edits in trunk/Source/WebCore
Fix cast-align warnings in WebCore/platform/graphics/texmap/TextureMapperGL.cpp
https://bugs.webkit.org/show_bug.cgi?id=118249
Reviewed by Allan Sandfeld Jensen.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
- 4:04 AM Changeset in webkit [152282] by
-
- 6 edits in trunk
[Qt][WK1] Support WebGL with EGL on Linux
https://bugs.webkit.org/show_bug.cgi?id=118251
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Let GraphicsContext3D work without a GraphicsSurface.
- Target.pri:
- platform/graphics/OpenGLShims.cpp:
(WebCore::getProcAddress):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
Tools:
- qmake/mkspecs/features/features.prf:
- 12:43 AM Changeset in webkit [152281] by
-
- 7 edits2 adds in trunk
[CSS-Regions] OverrideLogicalHeight used by both regions and flexbox
https://bugs.webkit.org/show_bug.cgi?id=118057
Patch by Catalin Badea <badea@adobe.com> on 2013-07-02
Reviewed by David Hyatt.
Source/WebCore:
Remove the use of overrideLogicalContentHeight() from regions and
use a local variable instead. The change was needed to avoid
overlapping with flexbox containers.
Test: fast/regions/autoheight-flexbox.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::applyBreakAfterContent):
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
(WebCore::RenderRegion::updateRegionHasAutoLogicalHeightFlag):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::updateLogicalHeight):
- rendering/RenderRegion.h:
(WebCore::RenderRegion::computedAutoHeight):
(WebCore::RenderRegion::setComputedAutoHeight):
(WebCore::RenderRegion::clearComputedAutoHeight):
(WebCore::RenderRegion::hasComputedAutoHeight):
- rendering/RenderView.cpp:
LayoutTests:
Add test for auto-height regions and flexbox containers.
- fast/regions/autoheight-flexbox-expected.html: Added.
- fast/regions/autoheight-flexbox.html: Added.
Jul 1, 2013:
- 11:03 PM Changeset in webkit [152280] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC]: Fix maybe-uninitialized gcc 4.8 warning in DFGSpeculativeJIT.cpp
https://bugs.webkit.org/show_bug.cgi?id=118278
Patch by Sergio Correia <Sergio Correia> on 2013-07-01
Reviewed by Filip Pizlo.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
Initialize valueGPR with InvalidGPRReg.
- 9:33 PM Changeset in webkit [152279] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should run LICM after AA setup
https://bugs.webkit.org/show_bug.cgi?id=118277
Reviewed by Maciej Stachowiak.
LICM queries alias analysis. Hence, just like GVN, it should run after
we have set up the alias analysis.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- 9:07 PM Changeset in webkit [152278] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should run AA passes before GVN
https://bugs.webkit.org/show_bug.cgi?id=118276
Rubber stamped by Geoffrey Garen.
These enable load elimination in GVN.
Immediately gives us a speed-up on a bunch of benchmarks I hacked to run
properly in the FTL. One example is 20% on imaging-gaussian-blur. (Fair
warning: the stock version of that benchmark won't see speed-ups -
probably slow-downs instead - because the FTL can't do OSR entry yet.)
Another example is the findGraphNode function, which now sees a 7%
speed-up, and that's without even doing LICM or other good things.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- 7:00 PM Changeset in webkit [152277] by
-
- 3 edits in trunk/Tools
[Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
https://bugs.webkit.org/show_bug.cgi?id=118267
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-07-01
Reviewed by Gyuyoung Kim.
After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
- efl/jhbuildrc:
- gtk/jhbuildrc:
- 6:01 PM Changeset in webkit [152276] by
-
- 2 edits in trunk/Source/WebCore
Windows should be included in the list of platforms that can use OpenGL ES 2.
https://bugs.webkit.org/show_bug.cgi?id=118264
Reviewed by Dean Jackson.
- platform/graphics/GraphicsContext3D.h: Added PLATFORM(WIN) to platforms using OpenGL ES 2.
- 6:00 PM Changeset in webkit [152275] by
-
- 18 edits14 deletes in trunk
[GTK] Remove unsupported AC backends
https://bugs.webkit.org/show_bug.cgi?id=117362
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-07-01
Reviewed by Martin Robinson.
.:
- Source/autotools/FindDependencies.m4: remove checks related to acceleration backend,
turn them into a check for OpenGL being available, simply.
- Source/autotools/ReadCommandLineArguments.m4: remove command line option to select
accelerated backend, it's now auto-detected.
- Source/autotools/SetupAutoconfHeader.m4: no longer defines USE_CLUTTER and
USE_TEXTURE_MAPPER_CAIRO.
- Source/autotools/SetupAutomake.m4: remove checks related to acceleration backend,
turn them into a check for OpenGL being available, simply.
- Source/autotools/Versions.m4: no longer check for clutter/clutter-gtk.
Source/WebCore:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Source/WebCore/platform/graphics/PlatformLayer.h: Removed mentions of clutter
and the texmap cairo backend.
- platform/graphics/clutter/DrawingBufferClutter.cpp: Removed.
- platform/graphics/clutter/GraphicsContext3DClutter.cpp: Removed.
- platform/graphics/clutter/GraphicsContext3DPrivate.cpp: Removed.
- platform/graphics/clutter/GraphicsContext3DPrivate.h: Removed.
- platform/graphics/clutter/GraphicsLayerActor.cpp: Removed.
- platform/graphics/clutter/GraphicsLayerActor.h: Removed.
- platform/graphics/clutter/GraphicsLayerClutter.cpp: Removed.
- platform/graphics/clutter/GraphicsLayerClutter.h: Removed.
- platform/graphics/clutter/PlatformClutterAnimation.cpp: Removed.
- platform/graphics/clutter/PlatformClutterAnimation.h: Removed.
- platform/graphics/clutter/PlatformClutterLayerClient.h: Removed.
- platform/graphics/clutter/TransformationMatrixClutter.cpp: Removed.
- Source/WebCore/platform/graphics/transforms/TransformationMatrix.h: Removed cogl
matrix type conversion.
Source/WebKit/gtk:
- GNUmakefile.am:
- WebCoreSupport/AcceleratedCompositingContext.h: removed clutter and cairo
additions.
- WebCoreSupport/AcceleratedCompositingContextCairo.cpp: Removed.
- WebCoreSupport/AcceleratedCompositingContextClutter.cpp: Removed.
- webkit/webkitglobals.cpp:
(webkitInit): removed clutter-gtk initialization.
Tools:
- gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
and cogl, so removed.
- 5:45 PM Changeset in webkit [152274] by
-
- 7 edits in branches/safari-537-branch/Source/WebKit2
Merged r152273. <rdar://problem/13078036>
- 5:08 PM Changeset in webkit [152273] by
-
- 7 edits in trunk/Source/WebKit2
Clean up private browsing session tracking
https://bugs.webkit.org/show_bug.cgi?id=118266
<rdar://problem/13078036>
Reviewed by Brady Eidson.
Instead of counting API calls, we now watch actual WebPreferences objects.
- UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetPrivateBrowsingEnabled): Removed code that used to notify WebContext. It's now done by WebPreferences.
- UIProcess/WebContext.h:
- UIProcess/WebContext.cpp: (WebKit::WebContext::ensureNetworkProcess): Instead of counting the number of times API was called, rely on WebPreferences tracking. (WebKit::WebContext::willStartUsingPrivateBrowsing): Ditto. This function is now only called when we detect a change in private browsing state. (WebKit::WebContext::willStopUsingPrivateBrowsing): Ditto. (WebKit::WebContext::createNewWebProcess): Tell the new process to create a private browsing session if needed.
- UIProcess/WebPreferences.h:
- UIProcess/WebPreferences.cpp: (WebKit::WebPreferences::addPageGroup): Count how many page groups use private browsing, and notify WebContext when a session is needed. Note that we don't notify WebContext about WebPreferences without any page groups, because it's likely that preferences will be updated by the client before groups are associated. (WebKit::WebPreferences::removePageGroup): Ditto. (WebKit::WebPreferences::updateBoolValueForKey): Perform special handling for private browsing mode changes. (WebKit::WebPreferences::updatePrivateBrowsingValue): Notify WebContext when it's time to create or destroy a private browsing session. (WebKit::WebPreferences::anyPageGroupsAreUsingPrivateBrowsing): A getter for WebContext to know when any page groups are in private browsing mode.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Don't create a private browsing session implicitly, UI process takes care of it.
- 4:36 PM Changeset in webkit [152272] by
-
- 6 edits2 copies in branches/safari-537-branch
Merged r152265. <rdar://problem/14301217>
- 4:33 PM Changeset in webkit [152271] by
-
- 3 edits in branches/safari-537-branch/Source/WebKit2
Merged r152266. <rdar://problem/14301166>
- 4:31 PM Changeset in webkit [152270] by
-
- 3 edits in branches/safari-537-branch/Source/WebKit2
Merged r152077. <rdar://problem/14270933>
- 4:21 PM Changeset in webkit [152269] by
-
- 4 edits in trunk/Source/WebCore
DrawingBuffer constructor and destructor were not defined for Windows.
I moved duplicate code from Cairo and Qt to DrawingBuffer.cpp to be used by Qt, Cairo, and Windows.
https://bugs.webkit.org/show_bug.cgi?id=118262
Reviewed by Dean Jackson.
- platform/graphics/cairo/DrawingBufferCairo.cpp: Removed duplicate DrawingBuffer constructor and destructor.
- platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer): Moved from Cairo and Qt implementation.
- platform/graphics/gpu/qt/DrawingBufferQt.cpp: Removed duplicate DrawingBuffer constructor and destructor.
- 3:44 PM Changeset in webkit [152268] by
-
- 2 edits in trunk/Source/WebCore
Fixed unreachable return when GLX or EGL are used with WebGL.
https://bugs.webkit.org/show_bug.cgi?id=118263
Reviewed by Noam Rosenthal.
- platform/graphics/opengl/GLPlatformContext.cpp:
(WebCore::createOffScreenContext): Fixed unreachable return.
- 3:23 PM Changeset in webkit [152267] by
-
- 14 edits in trunk
Link to WebInspectorUI.framework at build time instead of soft linking.
https://bugs.webkit.org/show_bug.cgi?id=118261
Reviewed by Joseph Pecoraro.
.:
- Source/Makefile: Build WebInspectorUI before WebKit and WebKit2.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig:
- WebCoreSupport/WebInspectorClient.mm:
(useWebKitWebInspector):
Source/WebKit2:
- Configurations/WebKit2.xcconfig:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
Tools:
- Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
- 2:47 PM Changeset in webkit [152266] by
-
- 3 edits in trunk/Source/WebKit2
[wk2] TiledCoreAnimationDrawingArea should support scrolling its exposed rect
https://bugs.webkit.org/show_bug.cgi?id=118173
<rdar://problem/14301166>
Reviewed by Anders Carlsson.
Offset the exposed rect passed from the WKView by the main frame's current scroll position
before sending it to our TiledBackings, so that it is in the same coordinate space as their
ordinary visibleRects.
This has the side effect of making clips-to-exposed-rect testable (though useless) in Safari.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Add updateScrolledExposedRect() and m_scrolledExposedRect.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scroll):
Call updateScrolledExposedRect when the main frame scrolls.
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
Remove a FIXME about this change.
Call updateScrolledExposedRect instead of passing down the unscrolled rect.
(WebKit::TiledCoreAnimationDrawingArea::setClipsToExposedRect):
Call updateScrolledExposedRect, because that method will short-circuit if
setClipsToExposedRect is false, so we need to update here for correctness
if we get a setExposedRect(), setClipsToExposedRect(true) pair.
(WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect):
Update m_scrolledExposedRect and propagate it to our TiledBackings.
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
Use the scrolled exposed rect.
- 2:35 PM Changeset in webkit [152265] by
-
- 6 edits2 adds in trunk
Maximum scroll position can be negative in some cases
https://bugs.webkit.org/show_bug.cgi?id=118175
<rdar://problem/14301217>
Reviewed by Anders Carlsson.
Test (API): WebKit2.ResizeReversePaginatedWebView
- page/FrameView.cpp:
(WebCore::FrameView::maximumScrollPosition):
- page/FrameView.h:
Override maximumScrollPosition() in FrameView and don't clamp to zero if
a reverse pagination mode is enabled, as it is possible (and common) to
have a negative maximum scroll position with reverse pagination.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
Drive-by adoption of toIntSize().
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
(TestWebKitAPI::didRunJavaScript):
(TestWebKitAPI::didLayout):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
Add a test that loads a vertical-lr document, paginates it horizontally
from right to left, resizes the view to fit the entire document, and
verifies that the scroll position is negative, as it must be for the
document to be enclosed by the view.
- 2:19 PM Changeset in webkit [152264] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152230. <rdar://problem/14306784>
- 2:17 PM Changeset in webkit [152263] by
-
- 3 edits in branches/safari-537-branch/Source/WebCore
Merged r152204. <rdar://problem/14205335>
- 2:16 PM Changeset in webkit [152262] by
-
- 2 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r152200. <rdar://problem/14308488>
- 2:13 PM Changeset in webkit [152261] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152187. <rdar://problem/14250167>
- 2:12 PM Changeset in webkit [152260] by
-
- 3 edits2 copies in branches/safari-537-branch
Merged r152185. <rdar://problem/13926528>
- 2:10 PM Changeset in webkit [152259] by
-
- 6 edits in branches/safari-537-branch/Source/WebKit2
Merged r152182. <rdar://problem/14255677>
- 2:09 PM Changeset in webkit [152258] by
-
- 4 edits2 copies in branches/safari-537-branch/Source/WebInspectorUI
Merged r152092. <rdar://problem/5847649>
- 2:07 PM Changeset in webkit [152257] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152075. <rdar://problem/14271105>
- 2:05 PM Changeset in webkit [152256] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152073. <rdar://problem/14194077>
- 2:04 PM Changeset in webkit [152255] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152072. <rdar://problem/13643935>
- 2:02 PM Changeset in webkit [152254] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152063. <rdar://problem/13888138>
- 2:00 PM Changeset in webkit [152253] by
-
- 13 edits in branches/safari-537-branch/Source
Merged r152234. <rdar://problem/14083280>
- 1:57 PM Changeset in webkit [152252] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152231. <rdar://problem/14321403>
- 1:54 PM Changeset in webkit [152251] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152207. <rdar://problem/14242032>
- 1:53 PM Changeset in webkit [152250] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152202. <rdar://problem/14247819>
- 1:45 PM Changeset in webkit [152249] by
-
- 2 edits in trunk/Source/WebKit2
Properly hide the header and footer banners if they are set to null.
https://bugs.webkit.org/show_bug.cgi?id=118219
Reviewed by Beth Dakin.
Call Page::addFooterWithHeight(0) to remove the parent layer that hosts the banner when
the footer banner is detached. Similarly for the header banner.
- WebProcess/WebPage/mac/PageBannerMac.mm:
(WebKit::PageBanner::detachFromPage):
- 1:43 PM Changeset in webkit [152248] by
-
- 4 edits4 copies in branches/safari-537-branch
Merged r152198. <rdar://problem/13488092>
- 1:39 PM Changeset in webkit [152247] by
-
- 4 edits2 copies in branches/safari-537-branch
Merged r152196. <rdar://problem/14259249>
- 1:38 PM Changeset in webkit [152246] by
-
- 6 edits in branches/safari-537-branch/Source/WebCore
Merged r152194. <rdar://problem/14261627>
- 1:36 PM Changeset in webkit [152245] by
-
- 11 edits in branches/safari-537-branch/Source/WebKit2
Merged r152190. <rdar://problem/14301175>
- 1:34 PM Changeset in webkit [152244] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152177. <rdar://problem/14303613>
- 1:33 PM Changeset in webkit [152243] by
-
- 8 edits in branches/safari-537-branch/Source/WebCore
Merged r152117. <rdar://problem/14278960>
- 1:30 PM Changeset in webkit [152242] by
-
- 4 edits in branches/safari-537-branch
Merged r152091. <rdar://problem/12679475>
- 1:07 PM Changeset in webkit [152241] by
-
- 14 edits1 copy in branches/safari-537-branch/Source
Merged r152065. <rdar://problem/10055712>
- 12:48 PM Changeset in webkit [152240] by
-
- 8 edits in trunk/Source/WebCore
Removed all references to DrawingBuffer methods unused since the removal of Chromium:
DrawingBuffer::prepareBackBuffer,
DrawingBuffer::requiresCopyFromBackToFrontBuffer, and
DrawingBuffer::clearPlatformLayer.
https://bugs.webkit.org/show_bug.cgi?id=118257
Reviewed by Darin Adler.
- platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:
(WebCore::DrawingBuffer::platformLayer):
- platform/graphics/cairo/DrawingBufferCairo.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- platform/graphics/clutter/DrawingBufferClutter.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::clear):
- platform/graphics/gpu/DrawingBuffer.h:
- platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::frontColorBuffer):
- platform/graphics/gpu/qt/DrawingBufferQt.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- 12:33 PM Changeset in webkit [152239] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed build correction.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Need to export tag for textarea element.
- 12:24 PM Changeset in webkit [152238] by
-
- 30 edits in trunk/Source
Remove support for consumable user gestures
https://bugs.webkit.org/show_bug.cgi?id=118247
Reviewed by Geoffrey Garen.
Source/WebCore:
The features was not enabled on any port, and is meanwhile broken, so we
should delete it.
No new tests, just deleting dead code.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::increment):
(WebCore::AccessibilityNodeObject::decrement):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press):
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeScript):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeScriptInWorld):
- dom/UserGestureIndicator.cpp:
(WebCore::isDefinite):
(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::~UserGestureIndicator):
- dom/UserGestureIndicator.h:
(WebCore::UserGestureIndicator::processingUserGesture):
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::openInNewTab):
- inspector/InspectorFrontendHost.cpp:
(WebCore::FrontendMenuProvider::contextMenuItemSelected):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::navigate):
- loader/NavigationScheduler.cpp:
(WebCore::ScheduledURLNavigation::fire):
(WebCore::ScheduledURLNavigation::didStartTimer):
(WebCore::ScheduledRedirect::fire):
(WebCore::ScheduledRefresh::fire):
(WebCore::ScheduledHistoryNavigation::fire):
(WebCore::ScheduledFormSubmission::fire):
(WebCore::ScheduledFormSubmission::didStartTimer):
- page/DOMTimer.cpp:
(WebCore::DOMTimer::DOMTimer):
(WebCore::DOMTimer::fired):
- page/DOMTimer.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::showModalDialog):
- page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
- page/EventHandler.h:
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::toggleMediaFullscreenState):
(WebCore::HitTestResult::enterFullscreenForVideo):
Source/WebKit/blackberry:
- WebKitSupport/NotificationManager.cpp:
(BlackBerry::WebKit::NotificationManager::notificationClicked):
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::evaluate):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView sendEvent:isDrawRect:]):
Source/WebKit/qt:
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::notificationClicked):
Source/WebKit/win:
- WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
Source/WebKit2:
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::didClickNotification):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performFrameLoadURLRequest):
(WebKit::PluginView::evaluate):
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle):
- 12:14 PM Changeset in webkit [152237] by
-
- 12 edits in branches/safari-537-branch/Source
Merged r151978. <rdar://problem/14102739>
- 11:54 AM Changeset in webkit [152236] by
-
- 1 edit2 adds in trunk/Websites/webkit.org
Add screenshot of the inspector color picker for the blog
- blog-files/last-week-in-webkit: Added.
- blog-files/last-week-in-webkit/Inspector_color_picker.png: Added.
- 11:41 AM Changeset in webkit [152235] by
-
- 14 edits8 adds in trunk
Add Support for mspace element
https://bugs.webkit.org/show_bug.cgi?id=115610
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-07-01
Reviewed by Chris Fleizach.
Source/WebCore:
This patch adds basic support for the MathML mspace element. This is
important to let people control spacing of mathematical formulas.
Attributes width, height and depth are implemented. For the moment,
only nonnegative width are accepted.
- CMakeLists.txt: add references to the RenderMathMLSpace files.
- GNUmakefile.list.am: ditto.
- Target.pri: ditto.
- WebCore.vcxproj/WebCore.vcxproj: ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
- WebCore.xcodeproj/project.pbxproj: ditto.
- css/mathml.css:
(mtable[columnlines="dashed"] > mtr > mtd + mtd): remove the obsolete linebreaking rule.
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::createRenderer): map mspaceTag to RenderMathMLSpace.
- mathml/mathattrs.in: add width, height and depth attributes
- mathml/mathtags.in: add mspace element
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::parseMathMLLength): fix int to float conversion.
- rendering/mathml/RenderMathMLBlock.h: declare isRenderMathMLSpace.
(WebCore::RenderMathMLBlock::isRenderMathMLSpace):
- rendering/mathml/RenderMathMLSpace.cpp: Added.
(WebCore::RenderMathMLSpace::RenderMathMLSpace):
(WebCore::RenderMathMLSpace::isChildAllowed):
(WebCore::RenderMathMLSpace::computePreferredLogicalWidths):
(WebCore::RenderMathMLSpace::updateFromElement):
(WebCore::RenderMathMLSpace::updateLogicalWidth):
(WebCore::RenderMathMLSpace::updateLogicalHeight):
(WebCore::RenderMathMLSpace::layout):
(WebCore::RenderMathMLSpace::styleDidChange):
(WebCore::RenderMathMLSpace::firstLineBoxBaseline):
- rendering/mathml/RenderMathMLSpace.h: Added.
(WebCore::RenderMathMLSpace::isRenderMathMLSpace):
(WebCore::RenderMathMLSpace::renderName):
(WebCore::toRenderMathMLSpace):
LayoutTests:
Add a reftest for the mspace element (width, height and depth) and
the parsing of MathML lengths. Import a reftest from Gecko to check
positive namedspace values.
- mathml/presentation/mspace-expected.html: Added.
- mathml/presentation/mspace-units-expected.html: Added.
- mathml/presentation/mspace-units.html: Added.
- mathml/presentation/mspace.html: Added.
- mathml/presentation/positive-namedspace-expected.html: Added.
- mathml/presentation/positive-namedspace.html: Added.
- 11:40 AM Changeset in webkit [152234] by
-
- 13 edits in trunk/Source
Audio in apps which embed WebViews is corrupted.
https://bugs.webkit.org/show_bug.cgi?id=118163
Reviewed by Maciej Stachowiak.
Source/WebCore:
Add a preference, which defaults to off, which controls whether the
AudioSessionManager will switch to a large audio buffer setting for
power-savings during <video> playback.
- WebCore.exp.in:
- page/Settings.cpp:
(WebCore::Settings::setLowPowerVideoAudioBufferSizeEnabled): Added. Simple setter.
- page/Settings.h:
(WebCore::Settings::lowPowerVideoAudioBufferSizeEnabled): Added. Simple getter.
- platform/audio/mac/AudioSessionManagerMac.cpp:
(AudioSessionManager::updateSessionState): Only set the large audio buffer
size if lowPowerVideoAudioBufferSize is enabled.
Source/WebKit/mac:
Expose the WebCore lowPowerVideoAudioBufferSizeEnabled setting to WebKit clients.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences lowPowerVideoAudioBufferSizeEnabled]):
(-[WebPreferences setLowPowerVideoAudioBufferSizeEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
Expose the WebCore lowPowerVideoAudioBufferSizeEnabled setting to WebKit2 clients.
- Shared/WebPreferencesStore.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 11:12 AM Changeset in webkit [152233] by
-
- 2 edits in trunk/WebKitLibraries
[Windows] Unreviewed correction to DEBUG_ALL target. Target was undefining DEBUG_ALL and DEBUG_INTERNAL,
which prevented proper build operation.
- win/tools/vsprops/debugsuffix.props: We should DEFINE (not UNDEFINE) the DEBUG_ALL and DEBUG_INTERNAL
macros when building with 'debugsuffix' target.
- 11:04 AM Changeset in webkit [152232] by
-
- 2 edits in trunk/Source/WebCore
[ATK] Leak: leaks in WebKitAccessibleInterfaceText
https://bugs.webkit.org/show_bug.cgi?id=118248
Fixed memory leaks.
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-01
Reviewed by Christophe Dumez.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getPangoLayoutForAtk):
(webkitAccessibleTextGetText):
- 10:53 AM Changeset in webkit [152231] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Make WebCore.make copy over QTMovieWin DLL's and PDB's.
<rdar://problem/14321403>
- WebCore.vcxproj/WebCore.make:
- 10:45 AM Changeset in webkit [152230] by
-
- 2 edits in trunk/Source/WebKit2
WKPageLoadDataWithUserData neglects to set the base URL that is passed in
<rdar://problem/14306784>
https://bugs.webkit.org/show_bug.cgi?id=118256
Reviewed by Anders Carlsson.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadData):
Pass the baseURL, not blankURL(), and remove an unnecessary multiplication by sizeof(uint8_t) which is always 1.
- 9:47 AM Changeset in webkit [152229] by
-
- 2 edits in trunk/Source/WebKit/win
[Curl] WebDownload init method is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=118241
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-01
Reviewed by Brent Fulgham.
The WebDownload::init() method called when a normal load is changed to a download
because of a decision by the policy delegate, is not implemented for Curl.
- WebDownloadCurl.cpp:
(WebDownload::init): Implement init() method.
- 9:38 AM Changeset in webkit [152228] by
-
- 3 edits in trunk/Source/WebCore
[Win] Crash when scrolling page with images.
https://bugs.webkit.org/show_bug.cgi?id=117832
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-01
Reviewed by Brent Fulgham.
Avoid access violation by returning early from method if image frame doesn't have pixel data.
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::hasPixelData): Added method to check if frame has pixel data.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::haveDecodedRow): Early return if frame doesn't have pixel data.
- 9:32 AM Changeset in webkit [152227] by
-
- 4 edits in trunk/Source/WebCore
Avoid calling RenderLayerBacking::resetContentsRect() if possible
https://bugs.webkit.org/show_bug.cgi?id=118217
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-07-01
Reviewed by Simon Fraser.
Call resetContentsRect() only if the layer has a contentsLayer.
Otherwise the contentsRect is redundant for the GraphicsLayer.
No new tests - optimization only. This is covered by plenty of existing
tests in webgl/ and compositing/.
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore::GraphicsLayerTextureMapper::hasContentsLayer):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
Added hasContentsLayer calls for TextureMapper/CoordinatedGraphics
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- 9:25 AM Changeset in webkit [152226] by
-
- 9 edits in trunk/Tools
[EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
https://bugs.webkit.org/show_bug.cgi?id=117249
Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2013-07-01
Reviewed by Brent Fulgham.
Finish converting all use cases of WEBKITOUTPUTDIR to
WEBKIT_OUTPUTDIR, which seems to be preferred these days.
- DumpRenderTree/efl/FontManagement.cpp:
(getCustomBuildDir):
(getPlatformFontsPath):
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(getOutputDir):
- Scripts/webkitdirs.pm:
(determineBaseProductDir):
(usesPerConfigurationBuildDirectory):
- Scripts/webkitpy/port/base.py:
(Port.to.setup_environ_for_server):
- Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver):
- Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
- WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::getOutputDir):
- jhbuild/jhbuildutils.py:
(get_dependencies_path):
- 8:39 AM Changeset in webkit [152225] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix cast-align warnings in JavaScriptCore/heap/HandleBlockInlines.h
https://bugs.webkit.org/show_bug.cgi?id=118242
Reviewed by Mark Hahnenberg.
- heap/HandleBlockInlines.h:
(JSC::HandleBlock::nodes):
- 8:29 AM Changeset in webkit [152224] by
-
- 2 edits in trunk/Tools
Unreviewed change of my email address.
- Scripts/webkitpy/common/config/contributors.json:
- 7:36 AM Changeset in webkit [152223] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Un-break the WebCore ChangeLog after http://trac.webkit.org/changeset/152219.
- 7:29 AM Changeset in webkit [152222] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Avoid creating a QWindow for offscreen GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=118244
Reviewed by Noam Rosenthal.
In Qt 5.0 we had to create invisible windows, but in Qt 5.1
we can now create specific offscreen surfaces.
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
- 6:31 AM Changeset in webkit [152221] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipping unsupported tests.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-01
- platform/qt/TestExpectations:
- 6:29 AM Changeset in webkit [152220] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Remove long unused Qt4 forward definitions
Unreviewed cleanu-up.
- platform/graphics/GraphicsContext3D.h:
- 6:27 AM Changeset in webkit [152219] by
-
- 5 edits in trunk/Source/WebCore
Use DeferrableOneShotTimer for deleting decoded data
https://bugs.webkit.org/show_bug.cgi?id=118150
Reviewed by Andreas Kling.
Adam Barth pointed out that the virtual function for overriding the default delay doesn't work
as expected from base class constructor.
- loader/cache/CachedResource.cpp:
(WebCore::deadDecodedDataDeletionIntervalForResourceType):
(WebCore::CachedResource::CachedResource):
Use static function instead of calling a virtual.
- loader/cache/CachedResource.h:
- loader/cache/CachedScript.cpp:
- loader/cache/CachedScript.h:
- 3:43 AM Changeset in webkit [152218] by
-
- 26 edits in trunk/Source
Adopt toHTMLTextAreaElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118226
Reviewed by Andreas Kling.
To enhance readability, this patch adopts toHTMLTextAreaElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::text):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendText):
- html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
- html/HTMLTextAreaElement.h:
(WebCore::toHTMLTextAreaElement):
- page/FocusController.cpp:
(WebCore::clearSelectionIfNeeded):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::isContentEditable):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesLogicalWidthToFitContent):
- rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):
(WebCore::RenderTextControlMultiLine::preferredContentLogicalWidth):
(WebCore::RenderTextControlMultiLine::computeControlLogicalHeight):
- testing/Internals.cpp:
(WebCore::Internals::wasLastChangeUserEdit):
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextInputElement):
(BlackBerry::WebKit::DOMSupport::inputElementText):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::elementType):
(BlackBerry::WebKit::InputHandler::boundingBoxForInputField):
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::textDidChangeInTextArea):
Source/WebKit/win:
- DOMCoreClasses.cpp:
(DOMElement::createInstance):
- DOMHTMLClasses.cpp:
(DOMHTMLTextAreaElement::form):
(DOMHTMLTextAreaElement::value):
(DOMHTMLTextAreaElement::setValue):
(DOMHTMLTextAreaElement::select):
(DOMHTMLTextAreaElement::isUserEdited):
Source/WebKit2:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::textDidChangeInTextArea):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::containsAnyFormControls):
- 1:44 AM Changeset in webkit [152217] by
-
- 3 edits in trunk/Source/WebCore
Add missing string headers that are used when LOG_DISABLED is 0.
https://bugs.webkit.org/show_bug.cgi?id=118227
Patch by Kwang Yul Seo <skyul@company100.net> on 2013-07-01
Reviewed by Andreas Kling.
Build fix for LOG_DISABLED=0.
No new tests, no behavior change.
- html/track/InbandTextTrack.cpp:
- rendering/RenderLayerCompositor.cpp:
- 1:44 AM Changeset in webkit [152216] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Use PassOwnPtr for the returned value of createBackingStore
https://bugs.webkit.org/show_bug.cgi?id=118230
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-07-01
Reviewed by Andreas Kling.
It would be better that createBackingStore returns PassOwnPtr instread of OwnPtr
to keep compatibility with c++0x.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::createBackingStore):
- 1:10 AM Applications using WebKit edited by
- Wakanda server updates (diff)
- 12:11 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
Jun 30, 2013:
- 10:30 AM Changeset in webkit [152215] by
-
- 5 edits3 adds in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining whatever can be rebaselined and adding failure expectations for other current failures.
- platform/gtk-wk1/TestExpectations:
- platform/gtk/TestExpectations:
- platform/gtk/editing/selection/user-select-all-image-with-single-click-expected.txt: Added.
- platform/gtk/editing/selection/user-select-all-with-single-click-expected.txt: Added.
- platform/gtk/fast/events/ondragenter-expected.txt: Added.
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
Jun 29, 2013:
- 1:27 PM Changeset in webkit [152214] by
-
- 5 edits in trunk/Source/WebCore
Avoid calling into Objective-C every time we get the scrollbar width
https://bugs.webkit.org/show_bug.cgi?id=118216
Reviewed by Geoffrey Garen.
Profiling shows that calling Scrollbar::isOverlayScrollbar() is somewhat
expensive, because it calls down into Objective-C. Fix by caching in
ScrollbarThemeMac whether we're using overlay scrollbars. We update this
cache on creation, and when preferences change; ScrollAnimatorMac::updateScrollerStyle()
is the function that gets called when the user changes the setting in System Preferences.
- platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::usesOverlayScrollbarsChanged):
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::preferencesChanged):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbarsChanged):
- 1:22 PM Changeset in webkit [152213] by
-
- 3 edits in trunk/Source/WebCore
Avoid calling isSimpleContainerCompositingLayer() an extra time
https://bugs.webkit.org/show_bug.cgi?id=118218
Reviewed by Tim Horton.
containsPaintedContent() called isSimpleContainerCompositingLayer(), which
is not particularly cheap. But the caller already has this information,
so pass it in.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::containsPaintedContent):
- rendering/RenderLayerBacking.h:
- 1:19 PM Changeset in webkit [152212] by
-
- 2 edits in trunk/Source/WebCore
Avoid doing work in RenderBox::outlineBoundsForRepaint() when the repaintContainer is this
https://bugs.webkit.org/show_bug.cgi?id=118215
Reviewed by Tim Horton.
When the RenderGeometryMap code path was added, RenderBox::outlineBoundsForRepaint()
actually got slower if no coordinate mapping was needed. So avoid doing work when
we can, including avoiding the FloatQuad construction.
Speeds up scrolling overflow:scroll areas with large numbers of layer children.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::outlineBoundsForRepaint):
- 8:49 AM Changeset in webkit [152211] by
-
- 14 edits in trunk/Source
Adopt is/toHTMLOptGroupElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118213
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLOptGroupElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isEnabled):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
- html/HTMLOptGroupElement.h:
(WebCore::isHTMLOptGroupElement):
(WebCore::toHTMLOptGroupElement):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
(WebCore::HTMLOptionElement::isDisabledFormControl):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::recalcListItems):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::hasImpliedEndTag):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isSelectScopeMarker):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemIsLabel):
Source/WebKit/blackberry:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openSelectPopup):
- 8:15 AM Changeset in webkit [152210] by
-
- 2 edits in trunk/Source/WebCore
Build fix for unguarded SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=118214
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-06-29
Reviewed by Christophe Dumez.
Add the SVG condition to SVGGraphicsElement.idl
No new tests required since no functionality changed.
- svg/SVGGraphicsElement.idl:
- 7:59 AM Changeset in webkit [152209] by
-
- 2 edits in trunk/Source/JavaScriptCore
Follow-up to r152206: also update HashFlags8BitBuffer in the LLInt.
- llint/LowLevelInterpreter.asm:
- 1:18 AM Changeset in webkit [152208] by
-
- 24 edits in trunk/Source
Adopt is/toHTMLOptionElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118212
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLOptionElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isSelected):
(WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
- accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::setElement):
(WebCore::AccessibilityMenuListOption::isEnabled):
(WebCore::AccessibilityMenuListOption::isSelected):
(WebCore::AccessibilityMenuListOption::setSelected):
(WebCore::AccessibilityMenuListOption::stringValue):
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
- html/HTMLCollection.cpp:
(WebCore::isMatchingElement):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::index):
- html/HTMLOptionElement.h:
(WebCore::isHTMLOptionElement):
(WebCore::toHTMLOptionElement):
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::hasPlaceholderLabelOption):
(WebCore::HTMLSelectElement::value):
(WebCore::HTMLSelectElement::setValue):
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::searchOptionsForValue):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::optionAtIndex):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::hasImpliedEndTag):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isSelectScopeMarker):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::setTextFromOption):
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemIsSelected):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks):
Source/WebKit/blackberry:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
(BlackBerry::WebKit::InputHandler::didNodeOpenPopup):
(BlackBerry::WebKit::InputHandler::openSelectPopup):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
- WebKitSupport/SelectPopupClient.cpp:
(BlackBerry::WebKit::SelectPopupClient::setValueAndClosePopup):
Source/WebKit/win:
- DOMCoreClasses.cpp:
(DOMElement::createInstance):
- DOMHTMLClasses.cpp:
(DOMHTMLOptionElement::text):
(DOMHTMLOptionElement::label):
- 12:25 AM Changeset in webkit [152207] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(151586): multipart/x-mixed-replace images are broken
https://bugs.webkit.org/show_bug.cgi?id=118169
Reviewed by Alexey Proskuryakov.
When loading multipart content the resource data will change as
the next part is loaded, so we need to make a copy of the data
before sending it to the resource.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):
Jun 28, 2013:
- 11:02 PM Changeset in webkit [152206] by
-
- 2 edits in trunk/Source/JavaScriptCore
Un-crashify JSC tests on debug bots after Anders had his way with StringImpl.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- 10:53 PM Changeset in webkit [152205] by
-
- 4 edits in trunk
Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
Source/WebKit2:
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::createServerAndClientIdentifiers):
Tools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(addFontFallbackIfPresent):
(removeFontFallbackIfPresent):
- 7:55 PM Changeset in webkit [152204] by
-
- 3 edits in trunk/Source/WebCore
[Mac] adopt new AVFoundation caption API
https://bugs.webkit.org/show_bug.cgi?id=118207
Reviewed by Dean Jackson.
No new tests, I was not able to come up with a reliable layout test.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::flushCues): New, call currentTrack->resetCueValues().
(-[WebCoreAVFMovieObserver outputSequenceWasFlushed:]): New delegate method.
- 7:41 PM Changeset in webkit [152203] by
-
- 22 edits in trunk/Source
Adopt is/toHTMLImageElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118182
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLImageElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isNativeImage):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::url):
- bindings/js/JSNodeCustom.cpp:
(WebCore::isReachableFromDOM):
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::assignToHTMLImageElement):
(JSC::Bindings::QtPixmapRuntime::toQt):
- dom/Clipboard.cpp:
(WebCore::Clipboard::setDragImage):
- dom/Node.cpp:
(WebCore::Node::enclosingLinkEventParentOrSelf):
- editing/Editor.cpp:
(WebCore::imageElementFromImageDocument):
- html/HTMLAnchorElement.cpp:
(WebCore::appendServerMapMousePosition):
- html/HTMLImageElement.h:
(WebCore::isHTMLImageElement):
(WebCore::toHTMLImageElement):
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
- html/HTMLNameCollection.cpp:
(WebCore::WindowNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatches):
- page/DragController.cpp:
(WebCore::DragController::draggableElement):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
- platform/gtk/PasteboardGtk.cpp:
(WebCore::getURLForImageNode):
- platform/mac/HTMLConverter.mm:
(+[WebHTMLConverter editingAttributedStringFromRange:]):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::updateAltText):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
(BlackBerry::WebKit::WebPage::blockZoom):
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
- 6:45 PM Changeset in webkit [152202] by
-
- 2 edits in trunk/Source/WebCore
PageThrottler::shouldThrottleTimers is wrong.
https://bugs.webkit.org/show_bug.cgi?id=118210
Reviewed by Anders Carlson.
m_throttleState == PageNotThrottledState
-> page NOT throttled, so should NOT throttle timers
m_throttleState != PageNotThrottledState
-> page NOT NOT throttled, so should throttle timers
This needs cleaning up, but for now, 1 character fix.
- page/PageThrottler.h:
(WebCore::PageThrottler::shouldThrottleTimers):
-> !=
- 6:39 PM Changeset in webkit [152201] by
-
- 11 edits in trunk
Remove String::deprecatedCharactersWithNullTermination() and related code
https://bugs.webkit.org/show_bug.cgi?id=118211
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- API/JSStringRef.cpp:
(JSStringCreateWithCharactersNoCopy):
Update call to StringImpl::createWithoutCopying.
Source/WTF:
Remove String::deprecatedCharactersWithNullTermination, StringImpl::createWithTerminatingNullCharacter
and the s_hashFlagHasTerminatingNullCharacter flag. We no longer care about whether strings have a
terminating null character.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::createFromLiteral):
(WTF::StringImpl::createWithoutCopying):
(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::sizeInBytes):
- wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl):
(WTF::StringImpl::createFromLiteral):
(WTF::StringImpl::isolatedCopy):
- wtf/text/WTFString.cpp:
- wtf/text/WTFString.h:
Tools:
Remove all hasTerminatingNullCharacter() checks.
- TestWebKitAPI/Tests/WTF/AtomicString.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/WTFString.cpp:
(TestWebKitAPI::TEST):
- 6:39 PM Changeset in webkit [152200] by
-
- 2 edits in trunk/Source/WebInspectorUI
Update Apple System fonts in auto-complete
https://bugs.webkit.org/show_bug.cgi?id=118205
<rdar://problem/14308488>
Reviewed by Joseph Pecoraro.
Update for the new Apple System font names, and remove some invalid entries.
- UserInterface/CSSKeywordCompletions.js: General cleanup. Note that
"apple-system-short-caption2" looks like it was accidentally omitted. It wasn't :)
- 6:25 PM Changeset in webkit [152199] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: AX: VoiceOver speaks all inspector search fields as 'required'
https://bugs.webkit.org/show_bug.cgi?id=118122
Patch by James Craig <james@cookiecrook.com> on 2013-06-28
Reviewed by Timothy Hatcher.
Removed bogus "required" state, and switched :valid selector to use :not(:placeholder-shown)
so that screen readers will not indicate a bogus :required/:invalid state to the user.
Minor cosmetic difference blocked by http://webkit.org/b/118162
- UserInterface/FilterBar.css:
(.filter-bar > input[type="search"]:focus):
(.filter-bar > input[type="search"]:not(:placeholder-shown)):
- UserInterface/FilterBar.js:
(WebInspector.FilterBar):
- UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel):
- UserInterface/SearchBar.css:
(.search-bar > input[type="search"]:focus):
(.search-bar > input[type="search"]:not(:placeholder-shown)):
- UserInterface/SearchBar.js:
(WebInspector.SearchBar):
- 5:09 PM Changeset in webkit [152198] by
-
- 4 edits4 adds in trunk
An element with -webkit-user-select: all should be selected on single click
https://bugs.webkit.org/show_bug.cgi?id=117864
Reviewed by Darin Adler.
Source/WebCore:
Set m_mouseDownMayStartSelect true even when the node cannot start selection
if the node was inside an element with -webkit-user-select: all.
Test: editing/selection/user-select-all-with-single-click.html
- page/EventHandler.cpp:
(WebCore::canMouseDownStartSelect):
LayoutTests:
Add tests for single clicking on an element with user-select: all.
We select the entire element regardless of whether the user had clicked on text or an image
to be consistent even though Firefox requires a double click on the latter case.
- editing/selection/user-select-all-with-image-single-click-expected.txt: Added.
- editing/selection/user-select-all-with-image-single-click.html: Added.
- editing/selection/user-select-all-with-single-click-expected.txt: Added.
- editing/selection/user-select-all-with-single-click.html: Added.
- 5:01 PM Changeset in webkit [152197] by
-
- 3 edits in trunk/Source/WebCore
Remove unused attachChildrenLazily method and make attach/detachChildren private
https://bugs.webkit.org/show_bug.cgi?id=118016
Reviewed by Darin Adler.
Merge https://chromium.googlesource.com/chromium/blink/+/009520dc31c9458e0cf71cf212fa5688c4ca68b0
No one should be manually trying to attach or detach all their children so there's
no reason for these methods to be public.
In doing this I realized that attachChildrenLazily is not used and can be removed.
I also realized that we were detaching all our children before the ShadowRoots which
is sad since the InsertionPoints will call detach() on them as well, and then when we
call ContainerNode::detach at the end of Element::detach we'll go detach them again!
This patch makes it so we only go through and detach them twice instead of three times.
In the future we should figure out a way to only do this once.
- dom/ContainerNode.h:
- dom/Element.cpp:
(WebCore::Element::detach):
- 4:57 PM Changeset in webkit [152196] by
-
- 4 edits2 adds in trunk
[Mac] Crash when loading is stopped from -didReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=118209
<rdar://problem/14259249>
Reviewed by Brady Eidson.
Test: TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): Added yet another check for reachedTerminalState().
- 4:40 PM Changeset in webkit [152195] by
-
- 2 edits in trunk/Tools
[Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=118208
Reviewed by Mark Rowe.
Newer versions of clang use a default template depth of 128, but this
is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
previous default.
Clang lowered the default to keep recursive template instantiation
from overflowing the stack (see <rdar://problem/13935016>), but
TestWebKitAPI's C++ files don't trigger a stack overflow even with the
higher limit. If for some reason this starts happening then we can
lower the limit back down.
- TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
- 4:11 PM Changeset in webkit [152194] by
-
- 6 edits in trunk/Source/WebCore
Cached pages don't update their backing scale factor when it changes
https://bugs.webkit.org/show_bug.cgi?id=118206
-and-
<rdar://problem/14261627>
Reviewed by Tim Horton.
It is not sufficient to mark pages in the PageCache as needing a full style
recalc. We also need to ensure that the RenderLayerCompositors for the CachesPages
get updated.
Keep track of whether device scale has been updated with
m_needsDeviceScaleChanged. If that has been marked true, then restore() will call
Frame::deviceOrPageScaleFactorChanged().
- history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
- history/CachedPage.h:
(WebCore::CachedPage::markForDeviceScaleChanged):
Propagate markForDeviceScaleChanged() to all of the CachedPages.
- history/PageCache.cpp:
(WebCore::PageCache::markPagesForDeviceScaleChanged):
- history/PageCache.h:
Call PageCache::markPagesForDeviceScaleChanged()
- page/Page.cpp:
(WebCore::Page::setDeviceScaleFactor):
- 3:48 PM Changeset in webkit [152193] by
-
- 2 edits in trunk/Source/WebCore
Added template parameters to std::min to fix compile errors in Visual Studio x64.
https://bugs.webkit.org/show_bug.cgi?id=118204
Reviewed by Geoffrey Garen.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeURLToDataObject): Added <unsigned> to std::min.
(WebCore::createGlobalImageFileDescriptor): Added <int> to std::min.
- 3:43 PM Changeset in webkit [152192] by
-
- 5 edits in trunk/Source/WebCore
Added WebGL files to Windows build.
https://bugs.webkit.org/show_bug.cgi?id=118200
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.vcxproj: Added WebGL files, removed unused GraphicsContext3DOpenGLES.cpp.
- WebCore.vcxproj/WebCore.vcxproj.filters: Added WebGL files, removed unused GraphicsContext3DOpenGLES.cpp.
- platform/graphics/cairo/GLContext.cpp: Only include GLContextEGL.h or GLContextGLX.h if they're needed.
- platform/graphics/cg/GraphicsContext3DCG.cpp: Only include GraphicsContext3DNEON.h if it's needed.
- 3:21 PM Changeset in webkit [152191] by
-
- 2 edits in trunk/Tools
[Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
https://bugs.webkit.org/show_bug.cgi?id=118195
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-06-28
Reviewed by Daniel Bates.
Currently, ports that use jhbuild fail to determine jhbuild directory
when "webKitBranchBuild" git configuration property is enabled. To reproduce
that issue in Efl port, enable that flag in .git/config, switch to a git branch
other than "master" and try to build webkit. The build will fail to
locate dependencies due to lack of pkg-config paths which should be set
by jhbuild.
For more details about "webKitBranchBuild" option, see:
https://trac.webkit.org/wiki/UsingGitWithWebKit
- Scripts/webkitdirs.pm:
(getJhbuildPath):
- 3:15 PM Changeset in webkit [152190] by
-
- 11 edits in trunk/Source/WebKit2
[wk2] WKView shouldn't force scrolling off if shouldClipToVisibleRect is set
https://bugs.webkit.org/show_bug.cgi?id=118174
<rdar://problem/14301175>
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView _updateViewExposedRect]):
Pass whether or not clips-to-visibleRect is enabled down to the WebPageProxy.
(-[WKView setMinimumSizeForAutoLayout:]):
Disable scrolling when using autolayout instead of when using clips-to-visibleRect.
(-[WKView setShouldClipToVisibleRect:]):
Clipping to the WKView's visibleRect does not strictly require scrolling to be disabled,
and in fact there are cases (RTL/TB pagination) where we *must* scroll, even when the view
is big enough to fit the content (the case clip-to-visibleRect was added for).
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::viewExposedRectChanged):
(WebKit::WebPageProxy::exposedRectChangedTimerFired):
Keep track of and forward to the drawing area whether or not clips-to-visibleRect is enabled.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setClipsToExposedRect): Added.
(WebKit::DrawingArea::didChangeScrollOffsetForAnyFrame): Added a missing space.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewExposedRectChanged):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Forward clips-to-visibleRect enabled state to the drawing area.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Add storage for m_clipsToExposedRect.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setClipsToExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::updateMainFrameClipsToExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
Check m_clipsToExposedRect instead of the main-frame's isScrollable() to determine
whether we should tell our TiledBackings to clip to the exposed rect we provide.
We don't need to listen to mainFrameScrollabilityChanged anymore.
- 2:48 PM Changeset in webkit [152189] by
-
- 2 edits in branches/safari-537-branch/Tools
Merged r152188. <rdar://problem/14306452>
- 2:45 PM Changeset in webkit [152188] by
-
- 2 edits in trunk/Tools
WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
https://bugs.webkit.org/show_bug.cgi?id=118201
Reviewed by Dean Jackson.
- WebKitTestRunner/mac/main.mm:
(main):
Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
setAutomaticDashSubstitutionEnabled are not exposed on WKView.
- 1:40 PM Changeset in webkit [152187] by
-
- 2 edits in trunk/Source/WebKit2
Stale occlusion state after moving page back into window
https://bugs.webkit.org/show_bug.cgi?id=118202
Reviewed by Anders Carlsson.
We need to update the occlusion state when the page goes back into the window.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
- update occlusion state.
- 1:38 PM Changeset in webkit [152186] by
-
- 9 edits in trunk/Tools
Upstream WebKit Nightly’s WebKitLauncher
https://bugs.webkit.org/show_bug.cgi?id=117418
Reviewed by Mark Rowe.
Literal patch from Nightly's OpenSource repo.
- WebKitLauncher/Configurations/Base.xcconfig:
- WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
- WebKitLauncher/Info.plist:
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitLauncherURLProtocol.m:
(+[WebKitLauncherURLProtocol load]):
(+[WebKitLauncherURLProtocol canInitWithRequest:]):
(-[WebKitLauncherURLProtocol startLoading]):
(-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
(-[WebKitLauncherURLProtocol resourceNotFound]):
- WebKitLauncher/WebKitNightlyEnablerSparkle.m:
(initializeSparkle):
- WebKitLauncher/main.m:
(determineExecutablePath):
(currentMacOSXVersion):
(main):
- WebKitLauncher/start.html:
- 12:59 PM Changeset in webkit [152185] by
-
- 3 edits2 adds in trunk
-webkit-line-break: after-white-space sometimes truncates DOM on copy & paste
https://bugs.webkit.org/show_bug.cgi?id=118164
Reviewed by Sam Weinig.
Source/WebCore:
We can't assume that all subsequent ancestors contain exactly one child since they could have been
added in the first if statement matching: currentNode->parentNode() != rootNode && isRemovableBlock(currentNode)
Exit early when we encounter such an ancestor since removing its ancestor (that contains multiple children
some of which aren't in nodesToRemove) can clobber more nodes than we're allowed to remove.
Test: editing/pasteboard/simplfiying-markup-should-not-strip-content.html
- editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::doApply):
(WebCore::SimplifyMarkupCommand::pruneSubsequentAncestorsToRemove):
LayoutTests:
Add a regression test.
- editing/pasteboard/simplfiying-markup-should-not-strip-content-expected.txt: Added.
- editing/pasteboard/simplfiying-markup-should-not-strip-content.html: Added.
- 12:55 PM Changeset in webkit [152184] by
-
- 3 edits in trunk/LayoutTests
media/video-currentTime.html flakey
https://bugs.webkit.org/show_bug.cgi?id=118198
Reviewed by Jessie Berlin.
Update video-currentTime.html so that it listens for timeupdate events, and ends the test
after the first one with a >0 currentTime. Add a 3s watchdog for the failure case.
- media/video-currentTime-expected.txt:
- media/video-currentTime.html:
- 12:09 PM Changeset in webkit [152183] by
-
- 7 edits2 adds in trunk/Source
Coordinated Graphics: Separate CoordinatedLayerTreeHost into CoordinatedLayerTreeHost and CompositingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=104360
Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-06-28
Reviewed by Noam Rosenthal.
The CoordinatedLayerTreeHost has too many responsibilities. It
implements LayerTreeHost, GraphicsLayerClient,
CoordinatedGraphicsLayerClient, CoordinatedImageBacking::Client,
UpdateAtlas::Client, GraphicsLayerFactory and
WebCustomFilterProgramProxyClient.
This refactoring reduces the responsibilities of CoordinatedLayerTreeHost.
This patch introduces a new class called CompositingCoordinator, which
takes the responsibility of managing compositing resources in
WebProcess.
CoordinatedLayerTreeHost is responsible only for the scheduling and
IPC-specific stuff, which are relevant only for WebKit2.
No new tests, covered by existing tests.
Source/WebCore:
- CMakeLists.txt:
- Target.pri:
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp: Added.
(WebCore::CompositingCoordinator::create):
(WebCore::CompositingCoordinator::~CompositingCoordinator):
(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::setRootCompositingLayer):
(WebCore::CompositingCoordinator::sizeDidChange):
(WebCore::CompositingCoordinator::flushPendingLayerChanges):
(WebCore::CompositingCoordinator::syncDisplayState):
(WebCore::CompositingCoordinator::nextAnimationServiceTime):
(WebCore::CompositingCoordinator::clearPendingStateChanges):
(WebCore::CompositingCoordinator::initializeRootCompositingLayerIfNeeded):
(WebCore::CompositingCoordinator::createRootLayer):
(WebCore::CompositingCoordinator::syncLayerState):
(WebCore::CompositingCoordinator::createImageBackingIfNeeded):
(WebCore::CompositingCoordinator::createImageBacking):
(WebCore::CompositingCoordinator::updateImageBacking):
(WebCore::CompositingCoordinator::clearImageBackingContents):
(WebCore::CompositingCoordinator::removeImageBacking):
(WebCore::CompositingCoordinator::flushPendingImageBackingChanges):
(WebCore::CompositingCoordinator::notifyAnimationStarted):
(WebCore::CompositingCoordinator::notifyFlushRequired):
(WebCore::CompositingCoordinator::paintContents):
(WebCore::CompositingCoordinator::createGraphicsLayer):
(WebCore::CompositingCoordinator::deviceScaleFactor):
(WebCore::CompositingCoordinator::pageScaleFactor):
(WebCore::CompositingCoordinator::createUpdateAtlas):
(WebCore::CompositingCoordinator::removeUpdateAtlas):
(WebCore::CompositingCoordinator::visibleContentsRect):
(WebCore::CompositingCoordinator::mainContentsLayer):
(WebCore::CompositingCoordinator::setVisibleContentsRect):
(WebCore::CompositingCoordinator::deviceOrPageScaleFactorChanged):
(WebCore::CompositingCoordinator::detachLayer):
(WebCore::CompositingCoordinator::commitScrollOffset):
(WebCore::CompositingCoordinator::renderNextFrame):
(WebCore::CompositingCoordinator::purgeBackingStores):
(WebCore::CompositingCoordinator::paintToSurface):
(WebCore::CompositingCoordinator::scheduleReleaseInactiveAtlases):
(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):
- platform/graphics/texmap/coordinated/CompositingCoordinator.h: Added.
(WebCore::CompositingCoordinator::clearRootLayer):
(WebCore::CompositingCoordinator::rootLayer):
(WebCore::CompositingCoordinator::state):
Source/WebKit2:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::~CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
(WebKit::CoordinatedLayerTreeHost::invalidate):
(WebKit::CoordinatedLayerTreeHost::forceRepaint):
(WebKit::CoordinatedLayerTreeHost::sizeDidChange):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::renderNextFrame):
(WebKit::CoordinatedLayerTreeHost::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHost::willSyncLayerState):
(WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesForAnimations):
(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):
(WebKit::CoordinatedLayerTreeHost::removeCustomFilterProgramProxy):
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush):
(WebKit::CoordinatedLayerTreeHost::createPageOverlayLayer):
(WebKit::CoordinatedLayerTreeHost::paintLayerContents):
(WebKit::CoordinatedLayerTreeHost::commitSceneState):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::CoordinatedLayerTreeHost::graphicsLayerFactory):
(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):
(WebKit::CoordinatedLayerTreeHost::commitScrollOffset):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/LayerTreeHost.h:
- 11:57 AM Changeset in webkit [152182] by
-
- 6 edits in trunk/Source/WebKit2
Make the UI process run the Java Updater
https://bugs.webkit.org/show_bug.cgi?id=118197
<rdar://problem/14255677>
Reviewed by Sam Weinig.
Patch the relevant NSWorkspace method and pipe through the request to launch the Java updater to the UI process.
- PluginProcess/PluginProcess.h:
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::replacedNSWorkspace_launchApplicationAtURL_options_configuration_error):
(WebKit::initializeCocoaOverrides):
(WebKit::PluginProcess::launchApplicationAtURL):
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.messages.in:
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::isJavaUpdaterURL):
(WebKit::shouldLaunchApplicationAtURL):
(WebKit::PluginProcessProxy::launchApplicationAtURL):
- 11:47 AM Changeset in webkit [152181] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r152135.
http://trac.webkit.org/changeset/152135
https://bugs.webkit.org/show_bug.cgi?id=118199
Rolling out temporary patch used for debugging the test bots
(Requested by rfong on #webkit).
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::load):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::load):
- 11:08 AM Changeset in webkit [152180] by
-
- 4 edits in trunk/LayoutTests
Update TestExpectations so new Shapes tests are skipped where the old ones were
https://bugs.webkit.org/show_bug.cgi?id=118192
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-28
Reviewed by Brent Fulgham.
Shapes still aren't enabled on some ports, so skip the tests there.
As part of this patch, it was discovered that they work on EFL, so the
skipping has been removed from there.
- platform/efl/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 11:07 AM Changeset in webkit [152179] by
-
- 3 edits in trunk/Tools
[EFL] back/forward keyboard shortcuts are non-intuitive
https://bugs.webkit.org/show_bug.cgi?id=118193
Patch by Balazs Kelemen <b.kelemen@samsung.com> on 2013-06-28
Reviewed by Christophe Dumez.
Changed shortcuts for go-back/go-forward to alt+left and alt+right.
- EWebLauncher/main.c:
(on_key_down):
- MiniBrowser/efl/main.c:
(on_key_down):
- 11:00 AM Changeset in webkit [152178] by
-
- 3 edits2 adds in trunk
SVG relayout problem when displayed with different image box heights
https://bugs.webkit.org/show_bug.cgi?id=118140
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-06-28
Reviewed by Philip Rogers.
Source/WebCore:
If the root element is an SVG, its position and height are affected
by the view height.
Test: svg/as-image/same-source-different-height.html
- rendering/RenderView.cpp:
(WebCore::RenderView::layout):
LayoutTests:
- svg/as-image/same-source-different-height-expected.html: Added.
- svg/as-image/same-source-different-height.html: Added.
- 10:54 AM Changeset in webkit [152177] by
-
- 2 edits in trunk/Source/WebKit2
WARN_UNUSED_RESULT can't be used in API headers, but WKBundlePageExtendIncrementalRenderingSuppression tries to
https://bugs.webkit.org/show_bug.cgi?id=118196
<rdar://problem/14303613>
Reviewed by Anders Carlsson.
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
- 10:54 AM Changeset in webkit [152176] by
-
- 3 edits in trunk/Tools
Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
https://bugs.webkit.org/show_bug.cgi?id=118194.
Reviewed by Brent Fulgham.
- DumpRenderTree/win/DumpRenderTree.cpp:
(dllLauncherEntryPoint):
- WinLauncher/WinLauncher.cpp:
(dllLauncherEntryPoint):
- 10:31 AM Changeset in webkit [152175] by
-
- 12 edits3 deletes in trunk/Source/WebCore
Allow some LayoutPoint and LayoutSize conversions to be inlined
https://bugs.webkit.org/show_bug.cgi?id=118167
Reviewed by Ryosuke Niwa.
Construction of FloatSize from LayoutSize, and FloatPoint's move(const LayoutSize&)
and moveBy(const LayoutPoint&) were not inlined, and showed up on some profiles.
Make them inlined by removing the overloaded functions, and instead providing
conversion operators from LayoutSize to FloatSize, and LayoutPoint to FloatPoint.
Do the same to allow a LayoutRect to be converted to a FloatRect.
This is nice because it removes pollution of FloatRect, FloatPoint and FloatSize with
Layout* entirely.
Remove Qt-specific conversions on LayoutRect, LayoutPoint and LayoutSize. Qt can
convert via IntRect/FloatRect as necessary.
- platform/graphics/FloatPoint.cpp:
- platform/graphics/FloatPoint.h:
(WebCore::FloatPoint::move):
(WebCore::FloatPoint::moveBy):
- platform/graphics/FloatRect.cpp:
- platform/graphics/FloatRect.h:
- platform/graphics/FloatSize.cpp:
- platform/graphics/FloatSize.h:
- platform/graphics/LayoutPoint.h:
(WebCore::LayoutPoint::operator FloatPoint):
- platform/graphics/LayoutRect.cpp:
- platform/graphics/LayoutRect.h:
(WebCore::LayoutRect::operator FloatRect):
- platform/graphics/LayoutSize.h:
(WebCore::LayoutSize::operator FloatSize):
- 10:13 AM Changeset in webkit [152174] by
-
- 3 edits in trunk/Tools
Unreviewed build fix for AppleWin port. Fix some file paths.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
- 9:50 AM Changeset in webkit [152173] by
-
- 5 edits in branches/safari-537-branch/LayoutTests
Merged r151942. <rdar://problem/14299780>
- 9:39 AM Changeset in webkit [152172] by
-
- 2 edits in trunk/LayoutTests
accessibility/media-element.html does not support platforms without subroles
https://bugs.webkit.org/show_bug.cgi?id=118187
Reviewed by Chris Fleizach.
Update the test to be more friendly with platforms not supporting subroles.
- accessibility/media-element.html: Updated test.
- 9:23 AM Changeset in webkit [152171] by
-
- 4 edits2 adds in trunk/Tools
Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
https://bugs.webkit.org/show_bug.cgi?id=118160.
Reviewed by Brent Fulgham.
- WinLauncher/AccessibilityDelegate.cpp: Added.
(AccessibilityDelegate::QueryInterface):
(AccessibilityDelegate::AddRef):
(AccessibilityDelegate::Release):
(AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
(AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
- WinLauncher/AccessibilityDelegate.h: Added.
(AccessibilityDelegate::AccessibilityDelegate):
- WinLauncher/WinLauncher.cpp:
(dllLauncherEntryPoint):
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
- 9:11 AM WebKitIDL edited by
- Remove ExtendsDOMGlobalObject and IsWorkerContext after r152168 (diff)
- 9:08 AM Changeset in webkit [152170] by
-
- 2 edits in trunk/Tools
Clean up temporary files created by the bindings test script
https://bugs.webkit.org/show_bug.cgi?id=118189
Reviewed by Kentaro Hara.
Remove temporary files created by preprocess-idls.pl script after
the bindings tests are executed.
Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.main):
- 9:07 AM Changeset in webkit [152169] by
-
- 3 edits in trunk/Source/WebKit/win
[WinCairo] Compilation error.
https://bugs.webkit.org/show_bug.cgi?id=118131
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-06-28
Reviewed by Brent Fulgham.
- Interfaces/IWebView.idl: Include needed accessibility interface.
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::AXFinishFrameLoad): Accessibility methods should not be inside FULLSCREEN_API ifdef.
- 9:01 AM Changeset in webkit [152168] by
-
- 7 edits in trunk/Source/WebCore
Get rid of IsWorkerGlobalScope and ExtendsDOMGlobalObject extended attributes
https://bugs.webkit.org/show_bug.cgi?id=118191
Reviewed by Kentaro Hara.
Remove WebKit-specific [IsWorkerGlobalScope] and [ExtendsDOMGlobalObject] IDL
extended attributes and update the JSC bindings generator to figure this out
on its own.
No new tests, no behavior change.
- bindings/scripts/CodeGeneratorJS.pm:
(IsDOMGlobalObject):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorHelperMethods):
- bindings/scripts/IDLAttributes.txt:
- page/DOMWindow.idl:
- workers/DedicatedWorkerGlobalScope.idl:
- workers/SharedWorkerGlobalScope.idl:
- workers/WorkerGlobalScope.idl:
- 8:58 AM Changeset in webkit [152167] by
-
- 80 edits1 copy2 moves in trunk
Introduce SVGGraphicsElement IDL interface
https://bugs.webkit.org/show_bug.cgi?id=118178
Reviewed by Kentaro Hara.
Source/WebCore:
Introduce SVGGraphicsElement IDL interface as per the latest SVG
specification:
SVGGraphicsElement is a merge of SVGLocatable and SVGTransformable.
This is one step towards simplifying inheritance in SVG and matching
the latest SVG2 specification.
No new tests, already covered by existing tests.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.order:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorJS.pm:
(GetGnuVTableOffsetForType):
- rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::RenderSVGEllipse):
- rendering/svg/RenderSVGEllipse.h:
- rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::RenderSVGPath):
- rendering/svg/RenderSVGPath.h:
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::pathOnlyClipping):
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
- rendering/svg/RenderSVGResourceMarker.cpp:
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::RenderSVGShape):
(WebCore::RenderSVGShape::updateShapeFromElement):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::nonScalingStrokeTransform):
(WebCore::RenderSVGShape::shouldGenerateMarkerPositions):
- rendering/svg/RenderSVGShape.h:
- rendering/svg/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer):
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- rendering/svg/RenderSVGTransformableContainer.h:
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::SVGAElement):
(WebCore::SVGAElement::parseAttribute):
(WebCore::SVGAElement::svgAttributeChanged):
(WebCore::SVGAElement::defaultEventHandler):
(WebCore::SVGAElement::supportsFocus):
(WebCore::SVGAElement::isURLAttribute):
- svg/SVGAElement.h:
- svg/SVGAElement.idl:
- svg/SVGAllInOne.cpp:
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
- svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::SVGCircleElement):
(WebCore::SVGCircleElement::parseAttribute):
(WebCore::SVGCircleElement::svgAttributeChanged):
- svg/SVGCircleElement.h:
- svg/SVGCircleElement.idl:
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::SVGClipPathElement):
(WebCore::SVGClipPathElement::parseAttribute):
(WebCore::SVGClipPathElement::svgAttributeChanged):
(WebCore::SVGClipPathElement::childrenChanged):
- svg/SVGClipPathElement.h:
- svg/SVGClipPathElement.idl:
- svg/SVGDefsElement.cpp:
(WebCore::SVGDefsElement::SVGDefsElement):
- svg/SVGDefsElement.h:
- svg/SVGDefsElement.idl:
- svg/SVGElement.h:
(WebCore::SVGElement::isSVGGraphicsElement):
- svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::SVGEllipseElement):
(WebCore::SVGEllipseElement::parseAttribute):
(WebCore::SVGEllipseElement::svgAttributeChanged):
- svg/SVGEllipseElement.h:
- svg/SVGEllipseElement.idl:
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
(WebCore::SVGForeignObjectElement::parseAttribute):
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
(WebCore::SVGForeignObjectElement::rendererIsNeeded):
- svg/SVGForeignObjectElement.h:
- svg/SVGForeignObjectElement.idl:
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::SVGGElement):
(WebCore::SVGGElement::parseAttribute):
(WebCore::SVGGElement::svgAttributeChanged):
- svg/SVGGElement.h:
- svg/SVGGElement.idl:
- svg/SVGGraphicsElement.cpp: Renamed from Source/WebCore/svg/SVGStyledTransformableElement.cpp.
(WebCore::SVGGraphicsElement::SVGGraphicsElement):
(WebCore::SVGGraphicsElement::~SVGGraphicsElement):
(WebCore::SVGGraphicsElement::getCTM):
(WebCore::SVGGraphicsElement::getScreenCTM):
(WebCore::SVGGraphicsElement::animatedLocalTransform):
(WebCore::SVGGraphicsElement::supplementalTransform):
(WebCore::SVGGraphicsElement::isSupportedAttribute):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
(WebCore::SVGGraphicsElement::nearestViewportElement):
(WebCore::SVGGraphicsElement::farthestViewportElement):
(WebCore::SVGGraphicsElement::getBBox):
(WebCore::SVGGraphicsElement::createRenderer):
(WebCore::SVGGraphicsElement::toClipPath):
- svg/SVGGraphicsElement.h: Renamed from Source/WebCore/svg/SVGStyledTransformableElement.h.
(WebCore::SVGGraphicsElement::localCoordinateSpaceTransform):
(WebCore::SVGGraphicsElement::synchronizeRequiredFeatures):
(WebCore::SVGGraphicsElement::synchronizeRequiredExtensions):
(WebCore::SVGGraphicsElement::synchronizeSystemLanguage):
(WebCore::toSVGGraphicsElement):
- svg/SVGGraphicsElement.idl: Copied from Source/WebCore/svg/SVGForeignObjectElement.idl.
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::SVGImageElement):
(WebCore::SVGImageElement::isPresentationAttribute):
(WebCore::SVGImageElement::collectStyleForPresentationAttribute):
(WebCore::SVGImageElement::parseAttribute):
(WebCore::SVGImageElement::svgAttributeChanged):
(WebCore::SVGImageElement::attach):
(WebCore::SVGImageElement::insertedInto):
(WebCore::SVGImageElement::addSubresourceAttributeURLs):
(WebCore::SVGImageElement::didMoveToNewDocument):
- svg/SVGImageElement.h:
- svg/SVGImageElement.idl:
- svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::SVGLineElement):
(WebCore::SVGLineElement::parseAttribute):
(WebCore::SVGLineElement::svgAttributeChanged):
- svg/SVGLineElement.h:
- svg/SVGLineElement.idl:
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::insertedInto):
(WebCore::SVGPathElement::removedFrom):
- svg/SVGPathElement.h:
- svg/SVGPathElement.idl:
- svg/SVGPatternElement.cpp:
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::SVGPolyElement):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::svgAttributeChanged):
- svg/SVGPolyElement.h:
- svg/SVGPolygonElement.idl:
- svg/SVGPolylineElement.idl:
- svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::SVGRectElement):
(WebCore::SVGRectElement::parseAttribute):
(WebCore::SVGRectElement::svgAttributeChanged):
- svg/SVGRectElement.h:
- svg/SVGRectElement.idl:
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::didMoveToNewDocument):
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):
- svg/SVGSVGElement.h:
- svg/SVGSVGElement.idl:
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::localCoordinateSpaceTransform):
- svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::SVGSwitchElement):
- svg/SVGSwitchElement.h:
- svg/SVGSwitchElement.idl:
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::parseAttribute):
(WebCore::SVGUseElement::insertedInto):
(WebCore::SVGUseElement::removedFrom):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::toClipPath):
(WebCore::SVGUseElement::finishParsingChildren):
- svg/SVGUseElement.h:
- svg/SVGUseElement.idl:
LayoutTests:
Rebaseline js/global-constructors-attributes.html test case now that
SVGGraphicsElement is exposed on the global Window object.
- fast/js/global-constructors-attributes-expected.txt:
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- platform/qt/fast/js/global-constructors-attributes-expected.txt:
- 8:00 AM Changeset in webkit [152166] by
-
- 2 edits in trunk/Source/WebKit2
Don't fire process-became-responsive callback when disconnecting it.
<http://webkit.org/b/118166>
Reviewed by Anders Carlsson.
When disconnecting from a web process, call ResponsivenessTimer::invalidate() instead of
stop() to avoid firing the didBecomeResponsive() callback.
This lets the UI process react faster to actually unresponsive processes.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):
- 7:52 AM WebKitIDL edited by
- Update documentation for [GlobalContext] after r152100 (diff)
- 7:49 AM Changeset in webkit [152165] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][GTK] 100% CPU usage rendering a page with animations
https://bugs.webkit.org/show_bug.cgi?id=117703
Reviewed by Martin Robinson.
Unconditionally update the value of m_lastFlushTime in
::flushAndRenderLayers. By doing that we avoid a neverending
sequence of layer flushes that happened when m_lastFlushTime==0
and flushPendingLayerChanges() was false. In that situation the
value m_lastFlushTime was never updated so a new flush was always
rescheduled.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::flushAndRenderLayers):
- 7:29 AM Changeset in webkit [152164] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipping failing tests, and mathml tests because not yet supported.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-28
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt/TestExpectations:
- 6:31 AM Changeset in webkit [152163] by
-
- 2 edits in trunk
[Autotools] Properly quote harfbuzz-icu pkg-config check
https://bugs.webkit.org/show_bug.cgi?id=118186
Patch by Sean Bright <sean@malleable.com> on 2013-06-28
Reviewed by Carlos Garcia Campos.
A secondary test was added in r150963 to check for harfbuzz-icu
when it was split into two packages, but the test is not properly
quoted. If the test fails you get an error about missing
version "./configure.9.8" instead of the expected "0.9.8."
- Source/autotools/FindDependencies.m4:
- 5:28 AM Changeset in webkit [152162] by
-
- 9 edits in trunk
Add new schemes to content utils.
https://bugs.webkit.org/show_bug.cgi?id=118181
Reviewed by Christophe Dumez.
Source/WebCore:
According to latest content handler spec, new schemes are added to it.
Those are "geo, magnet, sip, ssh and xmpp".
http://www.w3.org/html/wg/drafts/html/master/webappapis.html#custom-handlers
Tests: fast/dom/register-protocol-handler.html
fast/dom/unregister-protocol-handler.html
- Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::initProtocolHandlerWhitelist):
LayoutTests:
Add new schemes as well as change SYNTAX_ERR, SECURITY_ERR.
- fast/dom/register-protocol-handler-expected.txt:
- fast/dom/register-protocol-handler.html:
- fast/dom/unregister-protocol-handler-expected.txt:
- fast/dom/unregister-protocol-handler.html:
- platform/efl/fast/dom/register-protocol-handler-expected.txt:
- platform/efl/fast/dom/unregister-protocol-handler-expected.txt:
- 4:14 AM Changeset in webkit [152161] by
-
- 2 edits in trunk/Source/WebCore
Avoid duplicating hostWindow() call in ScrollView.cpp
https://bugs.webkit.org/show_bug.cgi?id=118168
Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2013-06-28
Reviewed by Christophe Dumez.
Remove redundant hostWindow() calls in ScrollView.cpp.
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::contentsToScreen):
(WebCore::ScrollView::screenToContents):
(WebCore::ScrollView::repaintContentRectangle):
(WebCore::ScrollView::updateOverhangAreas):
(WebCore::ScrollView::addPanScrollIcon):
(WebCore::ScrollView::removePanScrollIcon):
- 4:00 AM Changeset in webkit [152160] by
-
- 3 edits in trunk/LayoutTests
[GTK] Unreviewed gardening. Unskip and reorganize tests no longer failing in GTK-WK and GTK-WK2
https://bugs.webkit.org/show_bug.cgi?id=118180
Unreviewed GTK gardening.
Patch by Simon Pena <simon.pena@samsung.com> on 2013-06-28
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- 3:59 AM Changeset in webkit [152159] by
-
- 2 edits in trunk/Source/WebKit/gtk
Use gtk_widget_get_preferred_size instead of deprecated gtk_widget_get_requisition
https://bugs.webkit.org/show_bug.cgi?id=118177
Patch by Iago Toral Quiroga <itoral@igalia.com> on 2013-06-28
Reviewed by Carlos Garcia Campos.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::contentsSizeChanged):
- 3:18 AM Changeset in webkit [152158] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, EFL rebaseline.
SECURITY_ERR and SYNTAX_ERR have been changed with SecurityError and SyntaxError since r135162.
- platform/efl/fast/dom/register-protocol-handler-expected.txt:
- platform/efl/fast/dom/unregister-protocol-handler-expected.txt:
- 2:33 AM Changeset in webkit [152157] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix GTK build after r152156.
- GNUmakefile.list.am:
- 1:34 AM Changeset in webkit [152156] by
-
- 57 edits1 delete in trunk/Source/WebCore
Merge SVGLangSpace into SVGElement
https://bugs.webkit.org/show_bug.cgi?id=118170
Reviewed by Kentaro Hara.
Remove SVGLangSpace IDL interface and move its attributes to SVGElement
to match the latest specification and simplify inheritance in SVG:
No new tests, no behavior change.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- svg/SVGAElement.h:
- svg/SVGAElement.idl:
- svg/SVGCircleElement.h:
- svg/SVGCircleElement.idl:
- svg/SVGClipPathElement.h:
- svg/SVGClipPathElement.idl:
- svg/SVGDefsElement.h:
- svg/SVGDefsElement.idl:
- svg/SVGDescElement.h:
- svg/SVGDescElement.idl:
- svg/SVGElement.cpp:
(WebCore::SVGElement::parseAttribute):
- svg/SVGElement.h:
- svg/SVGElement.idl:
- svg/SVGEllipseElement.h:
- svg/SVGEllipseElement.idl:
- svg/SVGFEImageElement.h:
- svg/SVGFEImageElement.idl:
- svg/SVGFilterElement.h:
- svg/SVGFilterElement.idl:
- svg/SVGForeignObjectElement.h:
- svg/SVGForeignObjectElement.idl:
- svg/SVGGElement.h:
- svg/SVGGElement.idl:
- svg/SVGImageElement.h:
- svg/SVGImageElement.idl:
- svg/SVGLangSpace.idl: Removed.
- svg/SVGLineElement.h:
- svg/SVGLineElement.idl:
- svg/SVGMarkerElement.h:
- svg/SVGMarkerElement.idl:
- svg/SVGMaskElement.h:
- svg/SVGMaskElement.idl:
- svg/SVGPathElement.h:
- svg/SVGPathElement.idl:
- svg/SVGPatternElement.h:
- svg/SVGPatternElement.idl:
- svg/SVGPolyElement.h:
- svg/SVGPolygonElement.idl:
- svg/SVGPolylineElement.idl:
- svg/SVGRectElement.h:
- svg/SVGRectElement.idl:
- svg/SVGSVGElement.h:
- svg/SVGSVGElement.idl:
- svg/SVGStyleElement.h:
- svg/SVGStyleElement.idl:
- svg/SVGSwitchElement.h:
- svg/SVGSwitchElement.idl:
- svg/SVGSymbolElement.h:
- svg/SVGSymbolElement.idl:
- svg/SVGTextContentElement.h:
- svg/SVGTextContentElement.idl:
- svg/SVGTitleElement.h:
- svg/SVGTitleElement.idl:
- svg/SVGUseElement.h:
- svg/SVGUseElement.idl:
- 1:28 AM Changeset in webkit [152155] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] MiniBrowser doesn't solve the saving location when there are no XDG settings
https://bugs.webkit.org/show_bug.cgi?id=117538
Patch by Andres Gomez <Andres Gomez> on 2013-06-28
Reviewed by Carlos Garcia Campos.
If the XDG specification is not working for the "Downloads"
directory, let's use HOME as fallback.
- UIProcess/API/gtk/WebKitDownload.cpp:
(webkitDownloadDecideDestination):
- 1:20 AM Changeset in webkit [152154] by
-
- 4 edits in trunk/Source/WebCore
Use & instead of | in the value of [CallWith]
https://bugs.webkit.org/show_bug.cgi?id=118054
Reviewed by Kentaro Hara.
[CallWith=ScriptExecutionContext|ScriptState] meant that both the
ScriptExecutionContext AND the ScriptState would be passed as
arguments to the implementation (not one OR the other).
This patch changes the semantics for those IDL extended attributes
to make it less confusing. Proper usage is now:
[CallWith=ScriptExecutionContext&ScriptState]
No new tests, covered by existing bindings tests.
- bindings/scripts/CodeGenerator.pm:
(ExtendedAttributeContains):
- bindings/scripts/test/TestObj.idl:
- page/Console.idl:
- 12:34 AM Changeset in webkit [152153] by
-
- 2 edits1 add in trunk/Source/WebKit2
[EFL][WK2] Add spellcheck API tests in unit tests.
https://bugs.webkit.org/show_bug.cgi?id=118123
Patch by Dariusz Frankiewicz <Dariusz Frankiewicz> on 2013-06-28
Reviewed by Christophe Dumez.
According to discussion in bug https://bugs.webkit.org/show_bug.cgi?id=113742
we're moving spelling tests from layout tests to unit tests.
- UIProcess/API/efl/tests/resources/spelling_selection_tests.html: Added.
New file is needed to make tests, with and without spellcheck attribute.
File contains basic site with content editable fields and buttons which select
different parts of misspelled words.
- UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(countContextMenuItems):
Added method used to count number of items in context menu.
Jun 27, 2013:
- 10:47 PM Changeset in webkit [152152] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Merge a file from r151836 that was lost in the r152027 merge.
- fast/css/text-overflow-ellipsis-behind-floats-expected.html:
- 8:31 PM Changeset in webkit [152151] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
Make Graph::substituteGetLocal() out-of-line
Rubber stamped by Geoffrey Garen.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::substituteGetLocal):
(DFG):
- dfg/DFGGraph.h:
(Graph):
- 7:28 PM Changeset in webkit [152150] by
-
- 3 edits in trunk/Source/WebCore
HTMLAudioElement doesn't have to know about isVideo function
https://bugs.webkit.org/show_bug.cgi?id=118116
Reviewed by Eric Carlson.
Minor code cleanup to remove isVideo function from HTMLAudioElement.
We can use default function in HTMLMediaElement as hasVideo does.
- html/HTMLAudioElement.h:
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::isVideo):
- 7:26 PM Changeset in webkit [152149] by
-
- 58 edits in trunk/Source
Adopt is/toHTMLInputElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118130
Reviewed by Antti Koivisto.
To enhance readability, this patch adopts is/toHTMLInputElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaTimeline::valueDescription):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::isInputImage):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::valueForRange):
(WebCore::AccessibilityNodeObject::maxValueForRange):
(WebCore::AccessibilityNodeObject::minValueForRange):
(WebCore::AccessibilityNodeObject::actionElement):
(WebCore::AccessibilityNodeObject::titleElementText):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):
(WebCore::AccessibilityNodeObject::text):
(WebCore::AccessibilityNodeObject::colorValue):
(WebCore::accessibleNameForNode):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isFileUploadButton):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::url):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::element):
- accessibility/ios/AccessibilityObjectIOS.mm:
(WebCore::AccessibilityObject::accessibilityPasswordFieldLength):
- bindings/js/JSHTMLInputElementCustom.cpp:
(WebCore::JSHTMLInputElement::selectionStart):
(WebCore::JSHTMLInputElement::setSelectionStart):
(WebCore::JSHTMLInputElement::selectionEnd):
(WebCore::JSHTMLInputElement::setSelectionEnd):
(WebCore::JSHTMLInputElement::selectionDirection):
(WebCore::JSHTMLInputElement::setSelectionDirection):
(WebCore::JSHTMLInputElement::setSelectionRange):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::isInPasswordField):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):
- html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::getTextFieldValues):
- html/HTMLInputElement.h:
(WebCore::isHTMLInputElement):
(WebCore::toHTMLInputElement):
- html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::isKeyboardFocusable):
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::mediaControlElementType):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- page/Chrome.cpp:
(WebCore::Chrome::setToolTip):
- page/EventHandler.cpp:
(WebCore::isSubmitImage):
(WebCore::EventHandler::handleMousePressEvent):
- page/FocusController.cpp:
(WebCore::clearSelectionIfNeeded):
- platform/gtk/PasteboardGtk.cpp:
(WebCore::getURLForImageNode):
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
- platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::paintSliderTrack):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::isContentEditable):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::hasLineIfEmpty):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesLogicalWidthToFitContent):
- rendering/RenderButton.cpp:
(WebCore::RenderButton::updateFromElement):
(WebCore::RenderButton::canHaveGeneratedChildren):
- rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::isOpen):
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::updateFromElement):
(WebCore::RenderFileUploadControl::maxFilenameWidth):
(WebCore::RenderFileUploadControl::paintObject):
(WebCore::RenderFileUploadControl::uploadButton):
(WebCore::RenderFileUploadControl::fileTextValue):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::updateAltText):
- testing/Internals.cpp:
(WebCore::Internals::selectColorInColorChooser):
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
- WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::findPasswordFormFields):
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isPasswordElement):
(BlackBerry::WebKit::DOMSupport::inputElementText):
(BlackBerry::WebKit::DOMSupport::isDateTimeInputField):
(BlackBerry::WebKit::DOMSupport::isColorInputField):
(BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesNoAutocomplete):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::elementType):
(BlackBerry::WebKit::InputHandler::setInputValue):
(BlackBerry::WebKit::InputHandler::extractedTextRequest):
(BlackBerry::WebKit::InputHandler::showTextInputTypeSuggestionBox):
Source/WebKit/efl:
- ewk/ewk_view.cpp:
(ewk_view_input_method_state_set):
Source/WebKit/mac:
- DOM/WebDOMOperations.mm:
(-[DOMHTMLInputElement _setAutofilled:]):
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::focusedNodeChanged):
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::textFieldDidBeginEditing):
(WebEditorClient::textFieldDidEndEditing):
(WebEditorClient::textDidChangeInTextField):
(WebEditorClient::doTextFieldCommandFromEvent):
(WebEditorClient::textWillBeDeletedInTextField):
- WebView/WebHTMLRepresentation.mm:
(inputElementFromDOMElement):
Source/WebKit/qt:
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
- WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::inputMethodQuery):
Source/WebKit/win:
- DOMCoreClasses.cpp:
(DOMElement::createInstance):
- DOMHTMLClasses.cpp:
(DOMHTMLInputElement::form):
(DOMHTMLInputElement::disabled):
(DOMHTMLInputElement::readOnly):
(DOMHTMLInputElement::setType):
(DOMHTMLInputElement::value):
(DOMHTMLInputElement::setValue):
(DOMHTMLInputElement::setValueForUser):
(DOMHTMLInputElement::select):
(DOMHTMLInputElement::setSelectionStart):
(DOMHTMLInputElement::selectionStart):
(DOMHTMLInputElement::setSelectionEnd):
(DOMHTMLInputElement::selectionEnd):
(DOMHTMLInputElement::isTextField):
(DOMHTMLInputElement::rectOnScreen):
(DOMHTMLInputElement::replaceCharactersInRange):
(DOMHTMLInputElement::selectedRange):
(DOMHTMLInputElement::setAutofilled):
(DOMHTMLInputElement::isAutofilled):
(DOMHTMLInputElement::isUserEdited):
- WebFrame.cpp:
(inputElementFromDOMElement):
Source/WebKit2:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focusedNodeChanged):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::textFieldDidBeginEditing):
(WebKit::WebEditorClient::textFieldDidEndEditing):
(WebKit::WebEditorClient::textDidChangeInTextField):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::containsAnyFormControls):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
- 7:00 PM Changeset in webkit [152148] by
-
- 6 edits in trunk/Source/WebCore
Use DeferrableOneShotTimer for deleting decoded data
https://bugs.webkit.org/show_bug.cgi?id=118150
Reviewed by Andreas Kling.
Up to 1% of page load time can be used under CachedScript::script() for restarting
the decoded data deletion timer.
Using DeferrableOneShotTimer instead of a plain Timer avoids unnecessary low level timer access.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::destroyDecodedDataIfNeeded):
(WebCore::CachedResource::decodedDataDeletionTimerFired):
(WebCore::CachedResource::decodedDataDeletionTimerDelay):
Adopt DeferrableOneShotTimer.
- loader/cache/CachedResource.h:
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::script):
(WebCore::CachedScript::decodedDataDeletionTimerDelay):
Keep using zero delay for scripts.
- platform/Timer.h:
(WebCore::DeferrableOneShotTimer::stop):
Avoid unnecessary restart after stopping and starting again.
- 6:53 PM Changeset in webkit [152147] by
-
- 14 edits5 copies1 add in trunk/Source/WebKit2
[EFL][WK2] Add WK2 C API to handle touch events.
https://bugs.webkit.org/show_bug.cgi?id=108915
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-06-27
Reviewed by Gyuyoung Kim.
Touch events for our target platforms differ (XInput2, Wayland, Tizen) so
for the EFL port we want to be able to feed events manually.
To keep our current API for desktop EFL/Enlightenment working, we convert
our currently limited EFL events to the new EFL specific C EwkTouchPoint
and EwkTouchEvent type.
EwkTouchPoint and EwkTouchEvent are exposed as WKTouchPointRef and
WKTouchEventRef, so they are opaque in the applications.
The WKViewSendTouchEvent can be used for any use-case (platform/product)
not involving the EFL events.
At the same time we make sure to avoid using WK2 internals in our EFL API
implementation.
- PlatformEfl.cmake:
- Shared/API/c/efl/WKBaseEfl.h:
- Shared/APIObject.h:
- Shared/NativeWebTouchEvent.h:
(WebKit::NativeWebTouchEvent::nativeEvent):
- Shared/efl/NativeWebTouchEventEfl.cpp:
(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
- Shared/efl/WebEventFactory.cpp:
(WebKit::toWebPlatformTouchPointState):
(WebKit::toWebEventType):
(WebKit::toWebEventModifiers):
(WebKit::WebEventFactory::createWebTouchEvent):
- Shared/efl/WebEventFactory.h:
- UIProcess/API/C/efl/WKAPICastEfl.h:
- UIProcess/API/C/efl/WKEventEfl.cpp: Added.
(WKTouchPointCreate):
(WKTouchEventCreate):
- UIProcess/API/C/efl/WKEventEfl.h: Added.
- UIProcess/API/C/efl/WKViewEfl.cpp:
(WKViewSendTouchEvent):
- UIProcess/API/C/efl/WKViewEfl.h:
- UIProcess/API/efl/EwkView.cpp:
(toWKTouchPointState):
(toWKEventModifiers):
(EwkView::feedTouchEvent):
(EwkView::feedTouchEvents):
- UIProcess/efl/EwkTouchEvent.cpp: Added.
(WebKit::EwkTouchEvent::EwkTouchEvent):
- UIProcess/efl/EwkTouchEvent.h: Added.
(WebKit::EwkTouchEvent::create):
(WebKit::EwkTouchEvent::eventType):
(WebKit::EwkTouchEvent::touchPoints):
(WebKit::EwkTouchEvent::modifiers):
(WebKit::EwkTouchEvent::timestamp):
(WebKit::EwkTouchEvent::type):
- UIProcess/efl/EwkTouchPoint.cpp: Added.
(WebKit::EwkTouchPoint::EwkTouchPoint):
- UIProcess/efl/EwkTouchPoint.h: Added.
(WebKit::EwkTouchPoint::create):
(WebKit::EwkTouchPoint::id):
(WebKit::EwkTouchPoint::state):
(WebKit::EwkTouchPoint::screenPosition):
(WebKit::EwkTouchPoint::position):
(WebKit::EwkTouchPoint::radius):
(WebKit::EwkTouchPoint::rotationAngle):
(WebKit::EwkTouchPoint::forceFactor):
(WebKit::EwkTouchPoint::type):
- UIProcess/efl/WebViewEfl.cpp:
(WebKit::WebViewEfl::sendTouchEvent):
- UIProcess/efl/WebViewEfl.h:
- 6:17 PM Changeset in webkit [152146] by
-
- 3 edits in branches/safari-537-branch/Tools
Merged r152144. <rdar://problem/13529880>
- 6:16 PM Changeset in webkit [152145] by
-
- 3 edits in branches/safari-537-branch/Tools
Merged r151954. <rdar://problem/14250356>
- 6:02 PM Changeset in webkit [152144] by
-
- 3 edits in trunk/Tools
[Mac] Add Mavericks system font to Test systems
https://bugs.webkit.org/show_bug.cgi?id=118109
Reviewed by Simon Fraser.
OS X Mavericks uses a different font for system controls. Tell DRT and
WKTR about them otherwise they use a fallback font. Unfortunately the
fonts are hidden (not found in the list of available fonts) so I
had to add them manually.
Even though there is only one at the moment, I implemented this
as a set so it will be easier to add new fonts if necessary.
- DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet): Fixed typo.
(systemHiddenFontFamilySet): New method that returns the system control font.
(drt_NSFontManager_availableFonts): Merge the hidden fonts.
- WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::allowedFontFamilySet): Fixed typo.
(WTR::systemHiddenFontFamilySet): As above.
(WTR::wtr_NSFontManager_availableFonts):
- 5:33 PM Changeset in webkit [152143] by
-
- 10 edits in trunk
Get rid of the last uses of deprecatedCharactersWithNullTermination()
https://bugs.webkit.org/show_bug.cgi?id=118159
Reviewed by Andreas Kling.
Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
Source/WebKit/win:
- COMPropertyBag.h:
(::GetPropertyInfo):
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::runOpenPanel):
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::updateWindowTitle):
- WebDownloadCFNet.cpp:
(WebDownload::didFinish):
- WebKitSystemBits.cpp:
(WebVolumeFreeSize):
- WebLocalizableStrings.cpp:
(LocalizedString::operator LPCTSTR):
- WebView.cpp:
(WebView::setToolTip):
Tools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(findFontFallback):
- 5:19 PM Changeset in webkit [152142] by
-
- 29 edits in trunk/Source
Add a new String::charactersWithNullTermination() function that returns a vector
https://bugs.webkit.org/show_bug.cgi?id=118155
Reviewed by Andreas Kling.
Source/WebCore:
Change calls to deprecatedCharactersWithNullTermination() to charactersWithNullTermination().data()
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::getLinkedFonts):
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/win/IconWin.cpp:
(WebCore::Icon::createIconForFiles):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime):
- platform/graphics/wince/FontPlatformData.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- platform/network/curl/CurlDownload.cpp:
(CurlDownload::moveFileToDestination):
- platform/network/win/CookieJarWin.cpp:
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
- platform/network/win/DownloadBundleWin.cpp:
(WebCore::DownloadBundle::appendResumeData):
(WebCore::DownloadBundle::extractResumeData):
- platform/network/win/ResourceHandleWin.cpp:
(WebCore::createInternetHandle):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::fileLoadTimer):
- platform/text/win/LocaleWin.cpp:
(WebCore::LCIDFromLocaleInternal):
- platform/text/win/TextCodecWin.cpp:
(WebCore::TextCodecWin::enumerateSupportedEncodings):
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getWebLocData):
(WebCore::createGlobalData):
(WebCore::setFileDescriptorData):
(WebCore::getURL):
(WebCore::setCFData):
- platform/win/ContextMenuWin.cpp:
(WebCore::ContextMenu::createPlatformContextMenuFromItems):
- platform/win/DragImageWin.cpp:
(WebCore::createDragImageIconForCachedImageFilename):
- platform/win/FileSystemWin.cpp:
(WebCore::getFindData):
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::pathGetFileName):
(WebCore::openTemporaryFile):
(WebCore::openFile):
- platform/win/MIMETypeRegistryWin.cpp:
(WebCore::mimeTypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
- platform/win/PasteboardWin.cpp:
(WebCore::createGlobalImageFileDescriptor):
(WebCore::createGlobalHDropContent):
- platform/win/PathWalker.cpp:
(WebCore::PathWalker::PathWalker):
- platform/win/SSLKeyGeneratorWin.cpp:
(WebCore::WebCore::signedPublicKeyAndChallengeString):
- platform/win/SharedBufferWin.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):
- platform/wince/FileSystemWinCE.cpp:
(WebCore::getFileInfo):
(WebCore::fileExists):
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::makeAllDirectories):
(WebCore::openTemporaryFile):
(WebCore::openFile):
- plugins/win/PluginDatabaseWin.cpp:
(WebCore::PluginDatabase::getPluginPathsInDirectories):
(WebCore::addMozillaPluginDirectories):
(WebCore::addAdobeAcrobatPluginDirectory):
(WebCore::addJavaPluginDirectory):
- plugins/win/PluginPackageWin.cpp:
(WebCore::getVersionInfo):
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::handlePostReadFile):
Source/WTF:
This new String::charactersWithNullTermination() function returns a new Vector<UChar>
and does not modify the underlying string data.
- wtf/text/WTFString.cpp:
(WTF::String::charactersWithNullTermination):
- wtf/text/WTFString.h:
- 5:17 PM Changeset in webkit [152141] by
-
- 13 edits in trunk/Source/WebInspectorUI
Web Inspector: AX: Add container ARIA roles (toolbar, main, labeled regions, etc.)
so the layout is more discoverable to screen reader users
https://bugs.webkit.org/show_bug.cgi?id=118104
Patch by James Craig <james@cookiecrook.com> on 2013-06-27
Reviewed by Timothy Hatcher.
Made the basic layout (toolbar, sidebars, main) of the Web Inspector understandable
and navigable with VoiceOver.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/ButtonNavigationItem.js:
- UserInterface/CSSStyleDetailsSidebarPanel.js:
- UserInterface/DashboardManager.js:
- UserInterface/Main.js:
- UserInterface/NavigationBar.js:
- UserInterface/NavigationItem.js:
- UserInterface/NavigationSidebarPanel.js:
- UserInterface/RadioButtonNavigationItem.js:
- UserInterface/Sidebar.js:
- UserInterface/SidebarPanel.js:
- UserInterface/Toolbar.js:
- 5:14 PM Changeset in webkit [152140] by
-
- 5 edits6 adds in trunk
Implement parsing of MathML lengths.
https://bugs.webkit.org/show_bug.cgi?id=118053
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-06-27
Reviewed by Chris Fleizach.
Source/WebCore:
A parsing function for MathML lengths, similar to Gecko's one, is
implemented. It is currently only used to parse mfrac@linethickness but
will be convenient to parse other MathML attributes in the future.
Tests: mathml/presentation/mfrac-linethickness1.html
mathml/presentation/mfrac-linethickness2.html
mathml/presentation/mfrac-linethickness3.html
- rendering/mathml/RenderMathMLBlock.cpp: add parsing functions
(WebCore::parseMathMLLength): parsing MathML Length (number unit)
(WebCore::parseNamedSpace): parsing MathML namedspaces
- rendering/mathml/RenderMathMLBlock.h: declare parsing functions
- rendering/mathml/RenderMathMLFraction.cpp: use the parsing function for linethickness
(WebCore::RenderMathMLFraction::updateFromElement):
LayoutTests:
Add some reftests for mfrac@linethickness. Better tests for the parsing
of MathML lengths will be provided when mspace is implemented
(bug 115610)
- mathml/presentation/mfrac-linethickness1-expected-mismatch.html: Added.
- mathml/presentation/mfrac-linethickness1.html: Added.
- mathml/presentation/mfrac-linethickness2-expected.html: Added.
- mathml/presentation/mfrac-linethickness2.html: Added.
- mathml/presentation/mfrac-linethickness3-expected-mismatch.html: Added.
- mathml/presentation/mfrac-linethickness3.html: Added.
- 5:02 PM Changeset in webkit [152139] by
-
- 8 edits3 adds in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should know how to find natural loops
https://bugs.webkit.org/show_bug.cgi?id=118152
Reviewed by Mark Hahnenberg.
There are a bunch of things we can do when we know where the loops are.
Previously we didn't. With this patch, we do.
This patch adds the classic dominator based natural loop finder.
The only client of this right now is the DFG::Disassembler. It prints out
a summary of the analysis for each block.
This will become more important when I do
https://bugs.webkit.org/show_bug.cgi?id=118151, which definitely requires
this kind of analysis, at least if we want to do the optimization over
DFG IR (and I'm pretty sure we do).
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAnalysis.h: Added.
(DFG):
(Analysis):
(JSC::DFG::Analysis::Analysis):
(JSC::DFG::Analysis::invalidate):
(JSC::DFG::Analysis::computeIfNecessary):
(JSC::DFG::Analysis::isValid):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
- dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::createDumpList):
- dfg/DFGDominators.cpp:
(JSC::DFG::Dominators::Dominators):
(JSC::DFG::Dominators::compute):
- dfg/DFGDominators.h:
(Dominators):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::invalidateCFG):
(DFG):
- dfg/DFGGraph.h:
(Graph):
- dfg/DFGNaturalLoops.cpp: Added.
(DFG):
(JSC::DFG::NaturalLoop::dump):
(JSC::DFG::NaturalLoops::NaturalLoops):
(JSC::DFG::NaturalLoops::~NaturalLoops):
(JSC::DFG::NaturalLoops::compute):
(JSC::DFG::NaturalLoops::loopsOf):
(JSC::DFG::NaturalLoops::dump):
- dfg/DFGNaturalLoops.h: Added.
(DFG):
(NaturalLoop):
(JSC::DFG::NaturalLoop::NaturalLoop):
(JSC::DFG::NaturalLoop::addBlock):
(JSC::DFG::NaturalLoop::header):
(JSC::DFG::NaturalLoop::size):
(JSC::DFG::NaturalLoop::at):
(JSC::DFG::NaturalLoop::operator[]):
(JSC::DFG::NaturalLoop::contains):
(NaturalLoops):
(JSC::DFG::NaturalLoops::numLoops):
(JSC::DFG::NaturalLoops::loop):
(JSC::DFG::NaturalLoops::headerOf):
- 4:41 PM Changeset in webkit [152138] by
-
- 2 edits in trunk/LayoutTests
[Mac WK2] compositing/repaint/positioned-movement.html flaky, missing repaint
https://bugs.webkit.org/show_bug.cgi?id=118153
Update the expectation to reflect that the test is also flakey on release and other
platforms
- platform/mac-wk2/TestExpectations:
- 4:31 PM Changeset in webkit [152137] by
-
- 2 edits in trunk/Source/WebCore
Remove call to deprecatedCharactersWithNullTermination() in WebGL code
https://bugs.webkit.org/show_bug.cgi?id=118154
Reviewed by Dean Jackson.
Remove an unneeded call to deprecatedCharactersWithNullTermination(). Ultimately,
the string we used to call it on gets converted to an UTF-8 CString that has a null character anyway.
- html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::cacheActiveAttribLocations):
- 4:04 PM Changeset in webkit [152136] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: AX: Console log of the Inspector does not announce output for screen readers
https://bugs.webkit.org/show_bug.cgi?id=115976
Patch by James Craig <james@cookiecrook.com> on 2013-06-27
Reviewed by Timothy Hatcher.
Main console log area (div.console-messages) is now an ARIA live region (role="log")
so screen readers speak plain text updates.
Also added contextual labels (e.g. input/output) but speech output verification of
those is currently blocked by http://webkit.org/b/118096
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/ConsoleCommand.js:
(WebInspector.ConsoleCommand.prototype.toMessageElement):
- UserInterface/ConsoleCommandResult.js:
(WebInspector.ConsoleCommandResult.prototype.toMessageElement):
- UserInterface/LogContentView.css:
(@media reader):
- UserInterface/LogContentView.js:
(WebInspector.LogContentView):
- 4:00 PM Changeset in webkit [152135] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Temporarily add some stderr output to Media Engine load methods to determine which engine buildbots are using for layout tests.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::load):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::load):
- 3:56 PM Changeset in webkit [152134] by
-
- 4 edits in trunk/Source/WebCore
Stop using deprecatedCharactersWithNullTermination in SQLite code
https://bugs.webkit.org/show_bug.cgi?id=118146
Reviewed by Filip Pizlo.
Turns out SQLite uses UTF-8 internally so we might just as well use the SQLite functions
that take UTF-8 strings and do the conversion ourselves. This has the added advantage that we can
use String::utf8() which returns a null-terminated string.
Require a version of SQLite newer than 3.6.16 so we can remove two workarounds. 3.6.16 was released
4 years ago so supported port is likely to have it.
- platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
Use sqlite3_open instead of sqlite3_open16.
- platform/sql/SQLiteFileSystem.h:
Fix parameter name capitalization.
- platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
Use sqlite3_prepare_v2. Also, pass the length of the string (including the null character), since
that lets SQLite avoid a buffer copy. Remove a workaround for versions of SQLite older than 3.6.16.
- 3:43 PM Changeset in webkit [152133] by
-
- 10 edits in trunk/Tools
Sync up w3c import script with changes in Blink
https://bugs.webkit.org/show_bug.cgi?id=118149
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-27
Reviewed by Dirk Pranke.
This is a port of the following blink changes:
https://codereview.chromium.org/15366004
https://chromiumcodereview.appspot.com/15592005
https://codereview.chromium.org/16021006
https://codereview.chromium.org/15590004
https://codereview.chromium.org/15901008
https://codereview.chromium.org/16171009
https://codereview.chromium.org/16465007
https://codereview.chromium.org/15981013
- Scripts/webkitpy/common/checkout/checkout_unittest.py:
(setUp):
(test_commit_message_for_this_commit):
- Scripts/webkitpy/port/base.py:
(Port):
- Scripts/webkitpy/port/test.py:
- Scripts/webkitpy/w3c/test_converter.py:
(W3CTestConverter.init):
(W3CTestConverter.read_webkit_prefixed_css_property_list):
(W3CTestConverter.convert_for_webkit):
(W3CTestConverter.convert_css):
(W3CTestConverter.convert_html):
(W3CTestConverter.convert_testharness_paths):
(W3CTestConverter.convert_prefixed_properties):
(W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
- Scripts/webkitpy/w3c/test_converter_unittest.py:
- Scripts/webkitpy/w3c/test_importer.py:
(main):
(configure_logging):
(configure_logging.LogHandler):
(configure_logging.LogHandler.format):
(parse_args):
(TestImporter.init):
(TestImporter.find_importable_tests):
(TestImporter.import_tests):
(TestImporter.setup_destination_directory):
(TestImporter.remove_deleted_files):
- Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
(TestImporterTest.test_import_dir_with_no_tests):
(TestImporterTest):
- Scripts/webkitpy/w3c/test_parser.py:
(TestParser.load_file):
(TestParser.analyze_test):
(TestParser.support_files):
- Scripts/webkitpy/w3c/test_parser_unittest.py:
- 3:40 PM Changeset in webkit [152132] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Unnecessary root layer commits occur during html5 video playback
https://bugs.webkit.org/show_bug.cgi?id=118147
Patch by Andrew Lo <anlo@blackberry.com> on 2013-06-27
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson, John Griggs.
Only request layer commits when layer properties change in
GraphicsLayerBlackBerry::updateContentsRect and
GraphicsLayerBlackBerry::setContentsToMedia.
JIRA112749.
- platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::setContentsToMedia):
(WebCore::GraphicsLayerBlackBerry::updateContentsRect):
- 3:33 PM Changeset in webkit [152131] by
-
- 15 edits1 move4 adds in branches/dfgFourthTier/Source
fourthTier: JSC's disassembly infrastructure should be able to disassemble the code that LLVM generates
https://bugs.webkit.org/show_bug.cgi?id=118148
Source/JavaScriptCore:
Reviewed by Anders Carlsson.
Oh boy. UDis86 cannot disassemble the AVX (or whatever it's called) stuff
that LLVM generates for floating point. So the right decision is to
switch to the LLVM disassembler, right? Wrong!! LLVM's disassembler
cannot disassemble the load-from-absolute-address-into-%rax instructions
that our JIT generates quite a lot of.
So, this keeps the UDis86 disassembler, but adds the LLVM disassembler,
and requires the caller of disassemble() to hint which one is likely to
be less wrong for the given code.
Maybe in the future LLVM will catch up to UDis86, but it's definitely not
there right now.
This now allows us to disassemble all of the code that LLVM generates.
- JavaScriptCore.xcodeproj/project.pbxproj:
- disassembler/Disassembler.cpp:
(JSC::disassemble):
- disassembler/Disassembler.h:
(JSC::tryToDisassemble):
(JSC):
- disassembler/LLVMDisassembler.cpp: Added.
(JSC):
(JSC::symbolLookupCallback):
(JSC::tryToDisassembleWithLLVM):
- disassembler/LLVMDisassembler.h: Added.
(JSC):
(JSC::tryToDisassembleWithLLVM):
- disassembler/UDis86Disassembler.cpp:
(JSC::tryToDisassembleWithUDis86):
- disassembler/UDis86Disassembler.h: Added.
(JSC):
(JSC::tryToDisassembleWithUDis86):
- disassembler/X86Disassembler.cpp: Added.
(JSC):
(JSC::tryToDisassemble):
- ftl/FTLAbbreviatedTypes.h:
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLJITCode.h:
- ftl/FTLJITFinalizer.h:
- ftl/FTLLLVMHeaders.h: Removed.
- ftl/FTLLink.cpp:
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/Options.h:
(JSC):
Source/WTF:
Reviewed by Anders Carlsson.
We now use LLVM for two things: disassembler and FTL. Separate out the question
of whether we have LLVM (HAVE(LLVM)) from whether we want to use the LLVM
disassembler (USE(LLVM_DISASSEMBLER)) and whether we enable the FTL
(ENABLE(FTL_JIT)).
Also move the cruft for including LLVM headers into WTF since now we use it in
a bunch of places, not all related to FTL. There's no obvious place to put that
file in JSC so I put it in WTF.
- WTF.xcodeproj/project.pbxproj:
- wtf/LLVMHeaders.h: Copied from Source/JavaScriptCore/ftl/FTLLLVMHeaders.h.
- wtf/Platform.h:
- 3:20 PM Changeset in webkit [152130] by
-
- 9 edits2 copies in branches/safari-537-branch
Merged r152038. <rdar://problem/14282525>
- 3:19 PM Changeset in webkit [152129] by
-
- 7 edits in branches/safari-537-branch/Source
Merged r152035. <rdar://problem/14280545>
- 3:18 PM Changeset in webkit [152128] by
-
- 5 edits2 copies2 deletes in branches/safari-537-branch/Source/WebCore
Merged r152004. <rdar://problem/14278574>
- 3:17 PM Changeset in webkit [152127] by
-
- 2 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r151991. <rdar://problem/14260788>
- 3:17 PM Changeset in webkit [152126] by
-
- 3 edits3 copies in branches/safari-537-branch
Merged r152868. <rdar://problem/14230704>
- 3:16 PM Changeset in webkit [152125] by
-
- 6 edits3 copies in branches/safari-537-branch
Merged r151841. <rdar://problem/12476099>
- 3:15 PM Changeset in webkit [152124] by
-
- 7 edits in branches/safari-537-branch/Source/WebCore
Merged r151778. <rdar://problem/9524530>
- 3:14 PM Changeset in webkit [152123] by
-
- 8 edits in branches/safari-537-branch/Source
Merged r151745. <rdar://problem/9524530>
- 1:33 PM Changeset in webkit [152122] by
-
- 18 edits19 adds12 deletes in trunk
[CSS Shapes] New positioning model: basic support for rectangle shape-outside
https://bugs.webkit.org/show_bug.cgi?id=118080
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-27
Reviewed by David Hyatt.
Source/WebCore:
With the latest Editor's Draft of the CSS Shapes specification,
shape-outside no longer affects the positioning of floats. This is the
first step in changing the implementation to reflect this
specification change. The bulk of this change is reverting the code
that was needed to position floats based on the bounding box of the
shape.
Tests: csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState): Revert changes to support float
positioning from shape-outside.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::blockSelectionGaps): Ditto.
(WebCore::RenderBlock::insertFloatingObject): Ditto.
(WebCore::RenderBlock::positionNewFloats): Ditto.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Instead of
converting to shape bounding box coordinates, convert to the
float's margin box coordinates.
(WebCore::RenderBlock::logicalRightOffsetForLine): Ditto.
(WebCore::positionForPointRespectingEditingBoundaries): Revert changes
to support float positioning from shape-outside.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::xPositionForFloatIncludingMargin): Ditto.
(WebCore::RenderBlock::yPositionForFloatIncludingMargin): Ditto.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Instead
of converting to shape bounding box coordinates, convert to the
float's margin box coordinates.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer): Revert changes to support
float positioning from shape-outside.
(WebCore::RenderBox::offsetFromContainer): Ditto.
(WebCore::RenderBox::computeRectForRepaint): Ditto.
(WebCore::RenderBox::layoutOverflowRectForPropagation): Ditto.
- rendering/RenderBoxModelObject.cpp: Ditto.
- rendering/RenderBoxModelObject.h: Ditto.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint): Ditto.
(WebCore::RenderInline::computeRectForRepaint): Ditto.
(WebCore::RenderInline::mapLocalToContainer): Ditto.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition): Ditto.
(WebCore::RenderLayer::calculateClipRects): Ditto.
(WebCore::RenderLayer::shouldBeNormalFlowOnly): Ditto.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::offsetForInFlowPosition): Ditto.
- rendering/RenderObject.h: Ditto.
- rendering/shapes/ShapeInfo.h: Make m_renderer protected, since we
now need it in the subclass to compute the segments.
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::computeSegmentsForLine): Update segment
computation to use the float's margin box instead of the shape's
bounding box for computing the deltas.
(WebCore::ShapeOutsideInfo::leftSegmentMarginBoxDelta): This used to
be leftSegmentShapeBoundingBoxDelta, which has been renamed in the
obvious way.
(WebCore::ShapeOutsideInfo::rightSegmentMarginBoxDelta): This used to
be rightSegmentShapeBoundingBoxDelta, which has been renamed in the
obvious way.
- rendering/shapes/ShapeOutsideInfo.h: Revert changes to support float
positioning from shape-outside.
- rendering/style/RenderStyle.h: Ditto.
LayoutTests:
Added new tests for the new model. These tests are also spec tests, so
their canonical location is now in the CSS WG's repository. They have
been imported to WebKit using the import-w3c-tests script, and that's
why they live under the csswg directory.
The new tests replace the shape-outside-floats-simple-rectangle.html
test, which was anything but simple.
Tests that have not been rewritten yet have been marked as skipped.
Tests for the old positioning behavior that are not applicable to the
new behavior have been deleted.
- TestExpectations: Skip all the tests that need to be rewritten.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html: Added.
- csswg/submitted/shapes/shape-outside/w3c-import.log: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-margin-is-ignored-expected.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-margin-is-ignored.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y-expected.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden-expected.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-overhang-expected.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-overhang.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-positioning-expected.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-positioning.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rectangle-expected.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rectangle.html: Removed.
- 1:02 PM Changeset in webkit [152121] by
-
- 4 edits in trunk/Source/WebCore
RenderLayerCompositor destructor is fragile
https://bugs.webkit.org/show_bug.cgi?id=118143
Reviewed by Simon Fraser.
With iOS tile cache implementation deleting RenderLayerCompositor may end up starting a deleted timer.
This corrupts the timer heap and leads to a crash later. This happens because GraphicsLayers destructor
calls back to the RenderLayerCompositor that is being deleted. This is pretty fragile in general.
No test as there is no known way to repro this with plain webkit.
- platform/Timer.cpp:
(WebCore::TimerBase::TimerBase):
(WebCore::TimerBase::~TimerBase):
(WebCore::TimerBase::setNextFireTime):
- platform/Timer.h:
Assert that the timer is alive before starting it. This turns bugs like this into clear crash stacks
instead of hard-to-debug timer heap corruptions.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::~RenderLayerCompositor):
Take care to delete owned GraphicsLayers before proceeding with the rest of the destructor.
- 12:36 PM Changeset in webkit [152120] by
-
- 34 edits in trunk/Source/WebCore
Update SVG interfaces to stop inheriting from SVGURIReference and SVGTests
https://bugs.webkit.org/show_bug.cgi?id=118142
Reviewed by Ryosuke Niwa.
Stop inheriting from SVGURIReference and SVGTests and use IDL implements statements
instead. This is one step towards getting rid of multiple inheritance in SVG (which
is no longer supported by Web IDL) and matching the latest specification:
No new tests, no behavior change.
- CMakeLists.txt:
- DerivedSources.pri:
- GNUmakefile.list.am:
- svg/SVGAElement.idl:
- svg/SVGAltGlyphElement.idl:
- svg/SVGAnimationElement.idl:
- svg/SVGCircleElement.idl:
- svg/SVGClipPathElement.idl:
- svg/SVGCursorElement.idl:
- svg/SVGDefsElement.idl:
- svg/SVGEllipseElement.idl:
- svg/SVGFEImageElement.idl:
- svg/SVGFilterElement.idl:
- svg/SVGForeignObjectElement.idl:
- svg/SVGGElement.idl:
- svg/SVGGlyphRefElement.idl:
- svg/SVGGradientElement.idl:
- svg/SVGImageElement.idl:
- svg/SVGLineElement.idl:
- svg/SVGMPathElement.idl:
- svg/SVGMaskElement.idl:
- svg/SVGPathElement.idl:
- svg/SVGPatternElement.idl:
- svg/SVGPolygonElement.idl:
- svg/SVGPolylineElement.idl:
- svg/SVGRectElement.idl:
- svg/SVGSVGElement.idl:
- svg/SVGScriptElement.idl:
- svg/SVGSwitchElement.idl:
- svg/SVGTRefElement.idl:
- svg/SVGTextContentElement.idl:
- svg/SVGTextPathElement.idl:
- svg/SVGUseElement.idl:
- 11:37 AM Changeset in webkit [152119] by
-
- 2 edits in trunk/Websites/webkit.org
Update required tools for Windows instructions.
- building/tools.html:
- 11:16 AM Changeset in webkit [152118] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should be able to dump disassembly
https://bugs.webkit.org/show_bug.cgi?id=118141
Reviewed by Geoffrey Garen.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- 11:13 AM Changeset in webkit [152117] by
-
- 8 edits in trunk/Source/WebCore
Polish context menus for media elements
https://bugs.webkit.org/show_bug.cgi?id=118078
<rdar://problem/14278960>
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-27
Reviewed by Eric Carlson.
No new tests: media/context-menu-action.html,
which has been disabled by bug 116651, is used to test context menus.
- English.lproj/Localizable.strings: Changed "Fullscreen" to "Full Screen"
and added strings "Show Controls" and "Hide Controls".
- page/ContextMenuController.cpp: Updated to include a new context menu item
that toggles betweeen "Show Controls" and "Hide Controls".
- platform/ContextMenuItem.h:
- platform/LocalizedStrings.cpp:
- platform/LocalizedStrings.h:
- platform/efl/LocalizedStringsEfl.cpp:
- platform/gtk/LocalizedStringsGtk.cpp:
- platform/qt/LocalizedStringsQt.cpp:
Added equivalents of localized strings "Show Controls" and "Hide Controls".
- 11:08 AM Changeset in webkit [152116] by
-
- 9 edits2 copies in tags/Safari-537.47
Merged r152038. <rdar://problem/14282525>
- 11:01 AM Changeset in webkit [152115] by
-
- 7 edits in tags/Safari-537.47/Source
Merged r152035. <rdar://problem/14280545>
- 10:57 AM Changeset in webkit [152114] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
Unreviewed, fix build for LLVM ToT.
This doesn't affect those using the binary drops, but if you're building from
LLVM ToT you'll get link errors. These arise because we expect there to be a
libLLVMArchive, but that is no longer built by LLVM ToT. This casues the linker
to fall back on the system's libLLVMArchive, which is incompatible with the
other LLVM libs we pull in.
Also, we didn't need that library anyway and shouldn't have been linking
against it.
- Configurations/JavaScriptCore.xcconfig:
- 10:49 AM Changeset in webkit [152113] by
-
- 2 edits in trunk/Tools
[webkitpy] AbstractPatchSequencingCommand should have _prepare_state
https://bugs.webkit.org/show_bug.cgi?id=118128
Reviewed by Ryosuke Niwa.
It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
https://bugs.webkit.org/show_bug.cgi?id=117831
- Scripts/webkitpy/tool/commands/download.py:
(AbstractPatchSequencingCommand):
(AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
(AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
(AbstractPatchSequencingCommand._prepare_state): Added.
- 10:47 AM Changeset in webkit [152112] by
-
- 5 edits2 copies2 deletes in tags/Safari-537.47/Source/WebCore
Merged r152004. <rdar://problem/14278574>
- 10:45 AM Changeset in webkit [152111] by
-
- 2 edits in tags/Safari-537.47/Source/WebInspectorUI
Merged r151991. <rdar://problem/14260788>
- 10:44 AM Changeset in webkit [152110] by
-
- 3 edits in trunk/Source/WebKit2
Fix cast-align warnings in WebKit2/Platform/CoreIPC
https://bugs.webkit.org/show_bug.cgi?id=117987
Reviewed by Rob Buis, WK2 signed-off by Anders Carlsson.
- Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::decode):
- Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::encode):
- 10:42 AM Changeset in webkit [152109] by
-
- 3 edits3 copies in tags/Safari-537.47
Merged r151868. <rdar://problem/14230704>
- 10:40 AM Changeset in webkit [152108] by
-
- 6 edits3 copies in tags/Safari-537.47
Merged r151841. <rdar://problem/12476099>
- 10:37 AM Changeset in webkit [152107] by
-
- 7 edits in tags/Safari-537.47/Source/WebCore
Merged r151778. <rdar://problem/9524530>
- 10:34 AM Changeset in webkit [152106] by
-
- 8 edits in tags/Safari-537.47/Source
Merged r151745. <rdar://problem/9524530>
- 9:51 AM Changeset in webkit [152105] by
-
- 4 edits2 adds in trunk
AX: IOS: crash while navigating with SVG
https://bugs.webkit.org/show_bug.cgi?id=118101
Source/WebCore:
Need to check if the SVG path exists before copying it.
Reviewed by Stephen Chenney.
Test: platform/iphone-simulator/accessibility/svg-path-crash.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::elementPath):
- rendering/svg/RenderSVGShape.h:
(WebCore::RenderSVGShape::hasPath):
LayoutTests:
Reviewed by Stephen Chenney.
- platform/iphone-simulator/accessibility/svg-path-crash-expected.txt: Added.
- platform/iphone-simulator/accessibility/svg-path-crash.html: Added.
- 9:44 AM Changeset in webkit [152104] by
-
- 2 edits in trunk/Tools
[Qt] Build overrides -j when given --makeargs="-sj40"
https://bugs.webkit.org/show_bug.cgi?id=116897
Patch by Brendan Long <b.long@cablelabs.com> on 2013-06-27
Reviewed by Csaba Osztrogonác.
- Scripts/webkitdirs.pm:
(buildQMakeProjects):
Change regex checking for -j* to also check for -*j*
- 9:33 AM Changeset in webkit [152103] by
-
- 3 edits in trunk/Source/WebCore
Removing the redundant checks after r152078
https://bugs.webkit.org/show_bug.cgi?id=118117
Patch by Seokju Kwon <Seokju Kwon> on 2013-06-27
Reviewed by Simon Fraser.
Avoided redundant checks in RenderLayerCompositor::reasonsForCompositing() after r152078.
No new tests as no functionality change.
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logReasonsForCompositing):
- 9:32 AM Changeset in webkit [152102] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] We should clear all markers when input changes a word
https://bugs.webkit.org/show_bug.cgi?id=118136
JIRA115313.
For the case where a letter is added to the middle of a misspelled word, we were
sending incorrect offsets to clear spelling markers. However, since this
expanded the current word, it overlaps entirely the previous spelling marker so
no issue is found. However, if the keypress is backspace, the incorrect range
is smaller, causing an overlap which recreates the marker over the last character.
Setting shouldEraseMarkersAfterChangeSelection to follow continuous spell checking,
which will clear all markers regardless of overlap.
This patch also sustains spelling markers after the user taps to move the caret onto
the word, which is a nice gain as it was asked for previously.
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-06-27
Reviewed by Rob Buis.
Internally Reviewed by Mike Fenton
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldEraseMarkersAfterChangeSelection):
- 9:19 AM Changeset in webkit [152101] by
-
- 3 edits in trunk/LayoutTests
[GTK] Unreviewed gardening. Unskip tests no longer timing out.
https://bugs.webkit.org/show_bug.cgi?id=118135
Unreviewed GTK gardening.
Patch by Simon Pena <simon.pena@samsung.com> on 2013-06-27
- platform/gtk-wk1/TestExpectations:
- platform/gtk/TestExpectations:
- 8:46 AM Changeset in webkit [152100] by
-
- 40 edits4 copies4 moves in trunk
Remove [NoInterfaceObject] from WorkerGlobalScope
https://bugs.webkit.org/show_bug.cgi?id=118071
Reviewed by Kentaro Hara.
.:
Update GENERATE_BINDINGS CMake macro to take 2 additional parameters
now needed by the preprocess-idls.pl script.
- Source/cmake/WebKitMacros.cmake:
Source/WebCore:
Expose WorkerGlobalScope interface in worker environment as per the latest
specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#the-workerglobalscope-common-interface
Also expose the SharedWorkerGlobalScope interface when the JavaScript global environment is a
shared worker environment, and the DedicatedWorkerGlobalScope interface when the JavaScript
global environment is a dedicated worker environment:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#sharedworkerglobalscope
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#dedicatedworkerglobalscope
The semantics of the [GlobalContext] IDL extended attribute has changed to support this
use case. The value for the extended attribute is now the name of the interface to which the
Constructor attribute should be added (Window, WorkerGlobalScope, SharedWorkerGlobalScope...).
It is possible to specify several interface names by using '&' as separator. For e.g.
[GlobalContext=DOMWindow&WorkerGlobalScope].
Tests: fast/js/global-constructors-attributes-dedicated-worker.html
fast/js/global-constructors-attributes-shared-worker.html
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- Modules/websockets/WebSocket.idl:
- UseJSC.cmake:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorHelperMethods):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/generate-bindings.pl:
(checkIfIDLAttributesExists):
- bindings/scripts/preprocess-idls.pl:
- dom/MessageChannel.idl:
- dom/MessageEvent.idl:
- fileapi/Blob.idl:
- fileapi/FileReader.idl:
- fileapi/FileReaderSync.idl:
- html/DOMURL.idl:
- html/canvas/ArrayBuffer.idl:
- html/canvas/DataView.idl:
- html/canvas/Float32Array.idl:
- html/canvas/Float64Array.idl:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.idl:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.idl:
- html/canvas/Uint8ClampedArray.idl:
- page/EventSource.idl:
- workers/DedicatedWorkerGlobalScope.idl:
- workers/SharedWorkerGlobalScope.idl:
- workers/WorkerGlobalScope.idl:
- workers/WorkerLocation.idl:
- xml/XMLHttpRequest.idl:
Tools:
Update bindings test script to pass 2 additional parameters
now needed by the preprocess-idls.pl script.
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):
LayoutTests:
Split fast/js/global-constructors-attributes-worker.html test into 2 for both
shared and dedicated workers, as the output is now different.
- fast/js/global-constructors-attributes-dedicated-worker-expected.txt: Copied from LayoutTests/fast/js/global-constructors-attributes-worker-expected.txt.
- fast/js/global-constructors-attributes-dedicated-worker.html: Copied from LayoutTests/fast/js/global-constructors-attributes-worker.html.
- fast/js/global-constructors-attributes-shared-worker-expected.txt: Renamed from LayoutTests/fast/js/global-constructors-attributes-worker-expected.txt.
- fast/js/global-constructors-attributes-shared-worker.html: Renamed from LayoutTests/fast/js/global-constructors-attributes-worker.html.
- fast/js/script-tests/global-constructors-attributes.js:
(.self.postMessage):
(.self.onconnect.self.postMessage):
(.self.onconnect):
- platform/efl/fast/js/global-constructors-attributes-dedicated-worker-expected.txt: Copied from LayoutTests/platform/gtk/fast/js/global-constructors-attributes-worker-expected.txt.
- platform/efl/fast/js/global-constructors-attributes-shared-worker-expected.txt: Copied from LayoutTests/platform/gtk/fast/js/global-constructors-attributes-worker-expected.txt.
- platform/gtk/fast/js/global-constructors-attributes-dedicated-worker-expected.txt: Renamed from LayoutTests/platform/gtk/fast/js/global-constructors-attributes-worker-expected.txt.
- platform/gtk/fast/js/global-constructors-attributes-shared-worker-expected.txt: Renamed from LayoutTests/platform/efl/fast/js/global-constructors-attributes-worker-expected.txt.
- 8:42 AM Changeset in webkit [152099] by
-
- 7 edits2 deletes in trunk/Source
Unreviewed, rolling out r152074.
http://trac.webkit.org/changeset/152074
https://bugs.webkit.org/show_bug.cgi?id=118137
It caused lots of layout and API test crash on Qt Wk2.
(Requested by kadam on #webkit).
Source/WebCore:
- CMakeLists.txt:
- Target.pri:
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp: Removed.
- platform/graphics/texmap/coordinated/CompositingCoordinator.h: Removed.
Source/WebKit2:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::~CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
(WebKit::CoordinatedLayerTreeHost::invalidate):
(WebKit::CoordinatedLayerTreeHost::forceRepaint):
(WebKit::CoordinatedLayerTreeHost::sizeDidChange):
(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):
(WebKit::CoordinatedLayerTreeHost::clearPendingStateChanges):
(WebKit::CoordinatedLayerTreeHost::initializeRootCompositingLayerIfNeeded):
(WebKit::CoordinatedLayerTreeHost::syncLayerState):
(WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesIfNeeded):
(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):
(WebKit::CoordinatedLayerTreeHost::removeCustomFilterProgramProxy):
(WebKit::CoordinatedLayerTreeHost::detachLayer):
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush):
(WebKit::CoordinatedLayerTreeHost::syncDisplayState):
(WebKit::CoordinatedLayerTreeHost::didPerformScheduledLayerFlush):
(WebKit::CoordinatedLayerTreeHost::createPageOverlayLayer):
(WebKit::CoordinatedLayerTreeHost::createImageBackingIfNeeded):
(WebKit::CoordinatedLayerTreeHost::createImageBacking):
(WebKit::CoordinatedLayerTreeHost::updateImageBacking):
(WebKit::CoordinatedLayerTreeHost::clearImageBackingContents):
(WebKit::CoordinatedLayerTreeHost::removeImageBacking):
(WebKit::CoordinatedLayerTreeHost::flushPendingImageBackingChanges):
(WebKit::CoordinatedLayerTreeHost::notifyAnimationStarted):
(WebKit::CoordinatedLayerTreeHost::notifyFlushRequired):
(WebKit::CoordinatedLayerTreeHost::paintContents):
(WebKit::CoordinatedLayerTreeHost::createGraphicsLayer):
(WebKit::CoordinatedLayerTreeHost::deviceScaleFactor):
(WebKit::CoordinatedLayerTreeHost::pageScaleFactor):
(WebKit::CoordinatedLayerTreeHost::createUpdateAtlas):
(WebKit::CoordinatedLayerTreeHost::removeUpdateAtlas):
(WebKit::CoordinatedLayerTreeHost::visibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::mainContentsLayer):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::CoordinatedLayerTreeHost::graphicsLayerFactory):
(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):
(WebKit::CoordinatedLayerTreeHost::renderNextFrame):
(WebKit::CoordinatedLayerTreeHost::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHost::paintToSurface):
(WebKit::CoordinatedLayerTreeHost::scheduleReleaseInactiveAtlases):
(WebKit::CoordinatedLayerTreeHost::releaseInactiveAtlasesTimerFired):
(WebKit::CoordinatedLayerTreeHost::commitScrollOffset):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::setVisibleContentsRect):
(WebKit::LayerTreeHost::renderNextFrame):
(WebKit::LayerTreeHost::purgeBackingStores):
- 8:11 AM Changeset in webkit [152098] by
-
- 2 edits in trunk/Source/WebCore
Avoid duplicating hostWindow() call in FrameView::setFrameRect()
https://bugs.webkit.org/show_bug.cgi?id=118115
Patch by Seokju Kwon <Seokju Kwon> on 2013-06-27
Reviewed by Christophe Dumez.
Remove a redundant call in FrameView::setFrameRect().
No function change, no tests.
- page/FrameView.cpp:
(WebCore::FrameView::scheduleAnimation):
- 7:35 AM Changeset in webkit [152097] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=118100
Unreviewed Qt gardening.
Moved hover-display-block-none.html from fast/regions to fast/css.
Patch by Seokju Kwon <Seokju Kwon> on 2013-06-27
- platform/qt/TestExpectations:
- 7:19 AM Changeset in webkit [152096] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebase the previous test.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-27
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- 6:48 AM Changeset in webkit [152095] by
-
- 8 edits in trunk
Fixing some compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=117791
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-06-27
Reviewed by Martin Robinson.
Source/WebCore:
No new tests needed.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetTextForOffset): Fixed warning about
uninitialized variable.
Source/WebKit2:
- UIProcess/API/gtk/tests/WebExtensionTest.cpp: Properly
initialized GDBusInterfaceVTable.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkitWebPageCreate): Added missing fields to the
WKBundlePageLoaderClient.
Tools:
- GNUmakefile.am: Silenced format warning.
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
(TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
Solved warning about uninitialized variable.
- 6:31 AM Changeset in webkit [152094] by
-
- 7 edits2 moves in trunk/Source
Use consistent file names for WidgetBackingStoreGtkX11 class
https://bugs.webkit.org/show_bug.cgi?id=118124
Patch by Iago Toral Quiroga <itoral@igalia.com> on 2013-06-27
Reviewed by Carlos Garcia Campos.
Source/WebCore:
- GNUmakefile.list.am:
- PlatformGTK.cmake:
- platform/gtk/GtkWidgetBackingStoreX11.cpp: Removed.
- platform/gtk/GtkWidgetBackingStoreX11.h: Removed.
- platform/gtk/WidgetBackingStoreGtkX11.cpp: Added.
(WebCore::WidgetBackingStoreGtkX11::create):
(WebCore::WidgetBackingStoreGtkX11::WidgetBackingStoreGtkX11):
(WebCore::WidgetBackingStoreGtkX11::~WidgetBackingStoreGtkX11):
(WebCore::WidgetBackingStoreGtkX11::cairoSurface):
(WebCore::WidgetBackingStoreGtkX11::scroll):
- platform/gtk/WidgetBackingStoreGtkX11.h: Added.
Source/WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.cpp:
Source/WebKit2:
- UIProcess/cairo/BackingStoreCairo.cpp:
- 5:46 AM Changeset in webkit [152093] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebase and skipping failing tests.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-27
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt/TestExpectations:
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- 4:07 AM Changeset in webkit [152092] by
-
- 4 edits2 adds in trunk/Source/WebInspectorUI
Web Inspector: Display color picker in popover on color swatch click
https://bugs.webkit.org/show_bug.cgi?id=117919
Patch by Matthew Holden <jftholden@yahoo.com> on 2013-06-27
Reviewed by Timothy Hatcher.
Includes fixes from second code review.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/CSSColorPicker.css: Added.
(.colorpicker-container):
(.colorpicker-fill-parent):
(.colorpicker-top):
(.colorpicker-color):
(.colorpicker-bottom span):
(.colorpicker-text):
(.colorpicker-color-text-value):
(.colorpicker-hue):
(.colorpicker-fill):
(.colorpicker-range-container):
(.colorpicker-range-container *):
(.colorpicker-range-container label):
(.colorpicker-range-container input):
(.colorpicker-saturation):
(.colorpicker-value):
(.colorpicker-dragger):
(.colorpicker-slider):
(.colorpicker-container .swatch):
(.colorpicker-container .swatch-inner):
- UserInterface/CSSColorPicker.js: Added.
(WebInspector.CSSColorPicker.consume):
(WebInspector.CSSColorPicker.move):
(WebInspector.CSSColorPicker.start):
(WebInspector.CSSColorPicker.stop):
(WebInspector.CSSColorPicker.makeDraggable):
(WebInspector.CSSColorPicker.hueDrag):
(WebInspector.CSSColorPicker.colorDragStart):
(WebInspector.CSSColorPicker.colorDrag):
(WebInspector.CSSColorPicker.alphaDrag):
(WebInspector.CSSColorPicker.colorSwatchClicked):
(WebInspector.CSSColorPicker):
(WebInspector.CSSColorPicker.prototype.get element):
(WebInspector.CSSColorPicker.prototype.set color):
(WebInspector.CSSColorPicker.prototype.get color):
(WebInspector.CSSColorPicker.prototype.get outputColorFormat):
(WebInspector.CSSColorPicker.prototype.get colorHueOnly):
(WebInspector.CSSColorPicker.prototype.set displayText):
(WebInspector.CSSColorPicker.prototype.shown):
(WebInspector.CSSColorPicker.prototype._updateHelperLocations):
(WebInspector.CSSColorPicker.prototype._updateDisplay):
(WebInspector.CSSColorPicker.hsvaToRGBA):
(WebInspector.CSSColorPicker.rgbaToHSVA):
- UserInterface/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype.didDismissPopover):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText.colorTextMarker):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText):
- UserInterface/Main.html:
- 4:03 AM Changeset in webkit [152091] by
-
- 4 edits in trunk
Notify the debugger about functions created from source code via new Function() or WebCore::JSLazyEventListener.
https://bugs.webkit.org/show_bug.cgi?id=118063
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::fromGlobalCode): Call Debugger::sourceParsed.
LayoutTests:
- inspector/debugger/debugger-script-preprocessor-expected.txt: Updated.
- 3:36 AM Changeset in webkit [152090] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline fast/js/global-constructors-attributes.html for EFL port
after r151914. WaveTable was renamed to PeriodicWave.
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- 3:35 AM Changeset in webkit [152089] by
-
- 2 edits in trunk/Source/WebCore
Buildfix for !ENABLE(SVG) builds.
Reviewed by Csaba Osztrogonác.
Moving RenderObject::hasAspectRatio() outside from ENABLE(SVG) guard.
- rendering/RenderObject.h:
(WebCore::RenderObject::hasAspectRatio):
- 3:30 AM Changeset in webkit [152088] by
-
- 9 edits in trunk/Source/WebCore
Adopt is/toHTMLLabelElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118113
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLLabelElement.
This also helps out to reduce duplicated use of static_cast.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::labelChanged):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::labelForElement):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::labelElementContainer):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesLabelForAttribute):
- dom/Element.cpp:
(WebCore::Element::updateLabel):
- dom/TreeScope.cpp:
(WebCore::TreeScope::labelElementForId):
- html/HTMLLabelElement.h:
(WebCore::isHTMLLabelElement):
(WebCore::toHTMLLabelElement):
- html/LabelsNodeList.cpp:
(WebCore::LabelsNodeList::nodeMatches):
- 3:28 AM Changeset in webkit [152087] by
-
- 4 edits in trunk/Source/WebCore
[curl] Fix unused variable/parameter warnings
https://bugs.webkit.org/show_bug.cgi?id=118050
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-06-27
Reviewed by Christophe Dumez.
Commented out unused parameters and removed an unused variable in the curl backend.
No tests required.
- platform/network/curl/CredentialStorageCurl.cpp:
(WebCore::CredentialStorage::getFromPersistentStorage):
- platform/network/curl/DNSCurl.cpp:
(WebCore::prefetchDNS):
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::curl_lock_callback):
(WebCore::curl_unlock_callback):
(WebCore::headerCallback):
(WebCore::ResourceHandleManager::downloadTimerCallback):
- 3:10 AM Changeset in webkit [152086] by
-
- 3 edits in trunk/Source/WebCore
Fix cast-align warnings in WebCore/platform/graphics/cairo
https://bugs.webkit.org/show_bug.cgi?id=117990
Reviewed by Rob Buis.
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::checkForSolidColor):
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
- 3:05 AM Changeset in webkit [152085] by
-
- 2 edits in trunk/Source/WebCore
[curl] Add "set-cookie" to appendable headers
https://bugs.webkit.org/show_bug.cgi?id=118061
Patch by Szabolcs Dávid <davidsz@inf.u-szeged.hu> on 2013-06-27
Reviewed by Christophe Dumez.
Mark set-cookie as an appendable header.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::isAppendableHeader):
- 1:49 AM Changeset in webkit [152084] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] [WK2] Check value of WEBKIT_INJECTED_BUNDLE_PATH
https://bugs.webkit.org/show_bug.cgi?id=118055
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-06-27
Reviewed by Carlos Garcia Campos.
If the directory pointed at by WEBKIT_INJECTED_BUNDLE_PATH does
not exist, fall back to the system directory.
This makes MiniBrowser work outside the build tree.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(injectedBundleDirectory):
- 12:49 AM Changeset in webkit [152083] by
-
- 9 edits3 adds in trunk
Source/WebCore: Remove ENABLE_CSS_COMPOSITING guards around -webkit-background-blend mode related code. The same flag guards -webkit-blend-mode code, but those guards are not touched by this change.
https://bugs.webkit.org/show_bug.cgi?id=117619
Patch by Horia Iosif Olaru <olaru@adobe.com> on 2013-06-27
Reviewed by Dean Jackson.
Test: css3/compositing/effect-background-blend-mode-tiled.html
- WebCore.exp.in:
- bindings/generic/RuntimeEnabledFeatures.h:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
LayoutTests: Add an extra test to check if tiled background images get blended as expected. This test passed before this change. The tests for this change are the existing background-blend-mode tests.
https://bugs.webkit.org/show_bug.cgi?id=117619
Patch by Horia Iosif Olaru <olaru@adobe.com> on 2013-06-27
Reviewed by Dean Jackson.
- css3/compositing/effect-background-blend-mode-tiled-expected.txt: Added.
- css3/compositing/effect-background-blend-mode-tiled.html: Added.
- platform/mac/css3/compositing/effect-background-blend-mode-tiled-expected.png: Added.
- 12:28 AM Changeset in webkit [152082] by
-
- 2 edits in trunk/Tools
Fix bindings tests after r152080
https://bugs.webkit.org/show_bug.cgi?id=118118
Reviewed by Gyuyoung Kim.
r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
accordingly.
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):
- 12:00 AM Changeset in webkit [152081] by
-
- 6 edits in trunk
[BlackBerry] Handle testRunner.setCustomPolicyDelegate()
https://bugs.webkit.org/show_bug.cgi?id=117982
Patch by Carlos Garcia Campos <cargarcia@blackberry.com> on 2013-06-26
Reviewed by Rob Buis.
Source/WebKit/blackberry:
Take custom policy into account when deciding the policy for
navigation actions.
Fixes test fast/loader/onload-policy-ignore-for-frame.html.
- Api/DumpRenderTreeClient.h:
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
If custom policy is enabled ignore the navigation action when it's
not permissive.
Tools:
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
m_policyDelegateIsPermissive.
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
Reset m_policyDelegateIsPermissive.
(BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
m_policyDelegateIsPermissive.
- DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
Return whether custom policy is enabled.
(BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
Return whether custom policy is permissive.
Jun 26, 2013:
- 11:21 PM Changeset in webkit [152080] by
-
- 99 edits26 moves in trunk/Source
Rename WorkerContext to WorkerGlobalScope
https://bugs.webkit.org/show_bug.cgi?id=118059
Reviewed by Kentaro Hara.
Source/WebCore:
Rename WorkerContext / SharedWorkerContext / DedicatedWorkerContext to
WorkerGlobalScope / SharedWorkerGlobalScope / DedicatedWorkerGlobalScope
to match the latest specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#workerglobalscope
Those interfaces have [NoInterfaceObject] IDL extended attribute so the
name did not matter much so far. However, the specification was updated
and [NoInterfaceObject] was removed. We should therefore rename those
interfaces as a preparation for this change.
No new tests, no behavior change as these interfaces are not exposed to
JavaScript yet.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Modules/filesystem/WorkerGlobalScopeFileSystem.cpp: Renamed from Source/WebCore/Modules/filesystem/WorkerContextFileSystem.cpp.
(WebCore::WorkerGlobalScopeFileSystem::webkitRequestFileSystem):
(WebCore::WorkerGlobalScopeFileSystem::webkitRequestFileSystemSync):
(WebCore::WorkerGlobalScopeFileSystem::webkitResolveLocalFileSystemURL):
(WebCore::WorkerGlobalScopeFileSystem::webkitResolveLocalFileSystemSyncURL):
- Modules/filesystem/WorkerGlobalScopeFileSystem.h: Renamed from Source/WebCore/Modules/filesystem/WorkerContextFileSystem.h.
- Modules/filesystem/WorkerGlobalScopeFileSystem.idl: Renamed from Source/WebCore/Modules/filesystem/WorkerContextFileSystem.idl.
- Modules/indexeddb/IDBFactory.cpp:
- Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp: Renamed from Source/WebCore/Modules/indexeddb/WorkerContextIndexedDatabase.cpp.
(WebCore::WorkerGlobalScopeIndexedDatabase::WorkerGlobalScopeIndexedDatabase):
(WebCore::WorkerGlobalScopeIndexedDatabase::~WorkerGlobalScopeIndexedDatabase):
(WebCore::WorkerGlobalScopeIndexedDatabase::supplementName):
(WebCore::WorkerGlobalScopeIndexedDatabase::from):
(WebCore::WorkerGlobalScopeIndexedDatabase::indexedDB):
- Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h: Renamed from Source/WebCore/Modules/indexeddb/WorkerContextIndexedDatabase.h.
- Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.idl: Renamed from Source/WebCore/Modules/indexeddb/WorkerContextIndexedDatabase.idl.
- Modules/notifications/Notification.cpp:
- Modules/notifications/NotificationCenter.cpp:
- Modules/notifications/WorkerGlobalScopeNotifications.cpp: Renamed from Source/WebCore/Modules/notifications/WorkerContextNotifications.cpp.
(WebCore::WorkerGlobalScopeNotifications::WorkerGlobalScopeNotifications):
(WebCore::WorkerGlobalScopeNotifications::~WorkerGlobalScopeNotifications):
(WebCore::WorkerGlobalScopeNotifications::supplementName):
(WebCore::WorkerGlobalScopeNotifications::from):
(WebCore::WorkerGlobalScopeNotifications::webkitNotifications):
- Modules/notifications/WorkerGlobalScopeNotifications.h: Renamed from Source/WebCore/Modules/notifications/WorkerContextNotifications.h.
- Modules/notifications/WorkerGlobalScopeNotifications.idl: Renamed from Source/WebCore/Modules/notifications/WorkerContextNotifications.idl.
- Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::allowDatabaseAccess):
(WebCore::DatabaseContext::databaseExceededQuota):
- Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.cpp.
(WebCore::WorkerGlobalScopeWebDatabase::openDatabase):
(WebCore::WorkerGlobalScopeWebDatabase::openDatabaseSync):
- Modules/webdatabase/WorkerGlobalScopeWebDatabase.h: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.h.
(WebCore::WorkerGlobalScopeWebDatabase::WorkerGlobalScopeWebDatabase):
(WebCore::WorkerGlobalScopeWebDatabase::~WorkerGlobalScopeWebDatabase):
- Modules/webdatabase/WorkerGlobalScopeWebDatabase.idl: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.idl.
- Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::create):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasksCallback):
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
(WebCore::workerGlobalScopeDidSend):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::workerGlobalScopeDidGetBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::bufferedAmount):
(WebCore::workerGlobalScopeDidConnect):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect):
(WebCore::workerGlobalScopeDidReceiveMessage):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessage):
(WebCore::workerGlobalScopeDidReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
(WebCore::workerGlobalScopeDidUpdateBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didUpdateBufferedAmount):
(WebCore::workerGlobalScopeDidStartClosingHandshake):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
(WebCore::workerGlobalScopeDidClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
(WebCore::workerGlobalScopeDidReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::create):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::~WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::waitForMethodCompletion):
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
(WebCore::WorkerThreadableWebSocketChannel::create):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::create):
- Target.pri:
- UseJSC.cmake:
- WebCore.order:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/cpp/WebDOMEventTarget.cpp:
(toWebKit):
- bindings/cpp/WebDOMEventTarget.h:
- bindings/generic/ActiveDOMCallback.cpp:
- bindings/js/DOMRequestState.h:
(WebCore::DOMRequestState::DOMRequestState):
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::scriptExecutionContext):
(WebCore::toJSDOMGlobalObject):
- bindings/js/JSDedicatedWorkerGlobalScopeCustom.cpp: Renamed from Source/WebCore/bindings/js/JSDedicatedWorkerContextCustom.cpp.
(WebCore::JSDedicatedWorkerGlobalScope::postMessage):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSEventTargetCustom.cpp:
(WebCore::toJS):
- bindings/js/JSWorkerGlobalScopeBase.cpp: Renamed from Source/WebCore/bindings/js/JSWorkerContextBase.cpp.
(WebCore::JSWorkerGlobalScopeBase::JSWorkerGlobalScopeBase):
(WebCore::JSWorkerGlobalScopeBase::finishCreation):
(WebCore::JSWorkerGlobalScopeBase::destroy):
(WebCore::JSWorkerGlobalScopeBase::scriptExecutionContext):
(WebCore::toJS):
(WebCore::toJSDedicatedWorkerGlobalScope):
(WebCore::toJSSharedWorkerGlobalScope):
(WebCore::toJSWorkerGlobalScope):
- bindings/js/JSWorkerGlobalScopeBase.h: Renamed from Source/WebCore/bindings/js/JSWorkerContextBase.h.
(WebCore::JSWorkerGlobalScopeBase::impl):
(WebCore::JSWorkerGlobalScopeBase::createStructure):
- bindings/js/JSWorkerGlobalScopeCustom.cpp: Renamed from Source/WebCore/bindings/js/JSWorkerContextCustom.cpp.
(WebCore::JSWorkerGlobalScope::visitChildren):
(WebCore::JSWorkerGlobalScope::getOwnPropertySlotDelegate):
(WebCore::JSWorkerGlobalScope::getOwnPropertyDescriptorDelegate):
(WebCore::JSWorkerGlobalScope::importScripts):
(WebCore::JSWorkerGlobalScope::setTimeout):
(WebCore::JSWorkerGlobalScope::setInterval):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
- bindings/js/ScheduledAction.h:
- bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::startForWorkerGlobalScope):
(WebCore::ScriptProfiler::stopForWorkerGlobalScope):
- bindings/js/ScriptProfiler.h:
- bindings/js/ScriptState.cpp:
(WebCore::scriptStateFromWorkerGlobalScope):
- bindings/js/ScriptState.h:
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::~WorkerScriptController):
(WebCore::WorkerScriptController::initScript):
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::setException):
(WebCore::WorkerScriptController::forbidExecution):
(WebCore::WorkerScriptController::isExecutionForbidden):
(WebCore::WorkerScriptController::disableEval):
(WebCore::WorkerScriptController::attachDebugger):
(WebCore::WorkerScriptController::detachDebugger):
- bindings/js/WorkerScriptController.h:
(WebCore::WorkerScriptController::workerGlobalScopeWrapper):
(WebCore::WorkerScriptController::initScriptIfNeeded):
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
(WebCore::WorkerScriptDebugServer::removeListener):
(WebCore::WorkerScriptDebugServer::runEventLoopWhilePaused):
- bindings/js/WorkerScriptDebugServer.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/preprocess-idls.pl:
- dom/ActiveDOMObject.cpp:
- dom/EventTarget.h:
- dom/EventTargetFactory.in:
- dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::createdMessagePort):
(WebCore::ScriptExecutionContext::destroyedMessagePort):
(WebCore::ScriptExecutionContext::vm):
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::isWorkerGlobalScope):
- inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createForWorker):
(WebCore::InjectedScriptManager::canAccessInspectedWorkerGlobalScope):
- inspector/InjectedScriptManager.h:
- inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::addMessageToConsole):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didStartWorkerGlobalScopeImpl):
(WebCore::InspectorInstrumentation::willEvaluateWorkerScript):
(WebCore::InspectorInstrumentation::workerGlobalScopeTerminatedImpl):
(WebCore::InspectorInstrumentation::instrumentingAgentsForWorkerGlobalScope):
(WebCore::InspectorInstrumentation::instrumentingAgentsForNonDocumentContext):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didStartWorkerGlobalScope):
(WebCore::InspectorInstrumentation::workerGlobalScopeTerminated):
- inspector/InspectorProfilerAgent.cpp:
(WebCore::WorkerProfilerAgent::WorkerProfilerAgent):
(WebCore::WorkerProfilerAgent::startProfiling):
(WebCore::WorkerProfilerAgent::stopProfiling):
(WebCore::InspectorProfilerAgent::create):
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorRuntimeAgent.h:
- inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::proxy):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::connectToWorkerGlobalScope):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::disconnectFromWorkerGlobalScope):
(WebCore::InspectorWorkerAgent::connectToWorker):
(WebCore::InspectorWorkerAgent::disconnectFromWorker):
(WebCore::InspectorWorkerAgent::didStartWorkerGlobalScope):
(WebCore::InspectorWorkerAgent::workerGlobalScopeTerminated):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):
- inspector/InspectorWorkerAgent.h:
- inspector/InstrumentingAgents.cpp:
(WebCore::instrumentationForWorkerGlobalScope):
- inspector/InstrumentingAgents.h:
- inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::create):
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::interruptAndDispatchInspectorCommands):
(WebCore::WorkerDebuggerAgent::injectedScriptForEval):
- inspector/WorkerDebuggerAgent.h:
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
- inspector/WorkerInspectorController.h:
- inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::injectedScriptForEval):
(WebCore::WorkerRuntimeAgent::pauseWorkerGlobalScope):
- inspector/WorkerRuntimeAgent.h:
(WebCore::WorkerRuntimeAgent::create):
- loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
(WebCore::WorkerThreadableLoader::loadResourceSynchronously):
(WebCore::workerGlobalScopeDidSendData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
(WebCore::workerGlobalScopeDidReceiveResponse):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
(WebCore::workerGlobalScopeDidReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::workerGlobalScopeDidFinishLoading):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
(WebCore::workerGlobalScopeDidFail):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
(WebCore::workerGlobalScopeDidFailAccessControlCheck):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailAccessControlCheck):
(WebCore::workerGlobalScopeDidFailRedirectCheck):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
- loader/WorkerThreadableLoader.h:
(WebCore::WorkerThreadableLoader::create):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::removeRequestFromCache):
- platform/blackberry/LocalFileSystemBlackBerry.cpp:
(WebCore::openFileSystem):
(WebCore::LocalFileSystem::deleteFileSystem):
- platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:
(WebCore::WorkerAsyncFileSystemBlackBerry::WorkerAsyncFileSystemBlackBerry):
(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystem):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystem):
- platform/blackberry/WorkerAsyncFileSystemBlackBerry.h:
(WebCore::WorkerAsyncFileSystemBlackBerry::create):
- platform/blackberry/WorkerAsyncFileWriterBlackBerry.h:
- platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.cpp:
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::postTaskToWorkerThread):
- platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.h:
- platform/blackberry/WorkerPlatformFileWriterClient.cpp:
(WebCore::WorkerPlatformFileWriterClient::postTaskToWorkerThreadIfNeeded):
- platform/blackberry/WorkerPlatformFileWriterClient.h:
- workers/DedicatedWorkerGlobalScope.cpp: Renamed from Source/WebCore/workers/DedicatedWorkerContext.cpp.
(WebCore::DedicatedWorkerGlobalScope::create):
(WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope):
(WebCore::DedicatedWorkerGlobalScope::~DedicatedWorkerGlobalScope):
(WebCore::DedicatedWorkerGlobalScope::interfaceName):
(WebCore::DedicatedWorkerGlobalScope::postMessage):
(WebCore::DedicatedWorkerGlobalScope::importScripts):
(WebCore::DedicatedWorkerGlobalScope::thread):
- workers/DedicatedWorkerGlobalScope.h: Renamed from Source/WebCore/workers/DedicatedWorkerContext.h.
- workers/DedicatedWorkerGlobalScope.idl: Renamed from Source/WebCore/workers/DedicatedWorkerContext.idl.
- workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):
(WebCore::DedicatedWorkerThread::runEventLoop):
- workers/DedicatedWorkerThread.h:
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::SharedWorkerProxy::workerGlobalScopeClosed):
(WebCore::SharedWorkerProxy::workerGlobalScopeDestroyed):
(WebCore::SharedWorkerConnectTask::performTask):
(WebCore::SharedWorkerScriptLoader::notifyFinished):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
- workers/SharedWorkerGlobalScope.cpp: Renamed from Source/WebCore/workers/SharedWorkerContext.cpp.
(WebCore::createConnectEvent):
(WebCore::SharedWorkerGlobalScope::create):
(WebCore::SharedWorkerGlobalScope::SharedWorkerGlobalScope):
(WebCore::SharedWorkerGlobalScope::~SharedWorkerGlobalScope):
(WebCore::SharedWorkerGlobalScope::interfaceName):
(WebCore::SharedWorkerGlobalScope::thread):
(WebCore::SharedWorkerGlobalScope::logExceptionToConsole):
- workers/SharedWorkerGlobalScope.h: Renamed from Source/WebCore/workers/SharedWorkerContext.h.
(WebCore::SharedWorkerGlobalScope::name):
- workers/SharedWorkerGlobalScope.idl: Renamed from Source/WebCore/workers/SharedWorkerContext.idl.
- workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::createWorkerGlobalScope):
- workers/SharedWorkerThread.h:
- workers/Worker.cpp:
(WebCore::Worker::Worker):
(WebCore::Worker::postMessage):
(WebCore::Worker::terminate):
(WebCore::Worker::notifyFinished):
- workers/Worker.h:
- workers/WorkerGlobalScope.cpp: Renamed from Source/WebCore/workers/WorkerContext.cpp.
(WebCore::CloseWorkerGlobalScopeTask::create):
(WebCore::CloseWorkerGlobalScopeTask::performTask):
(WebCore::CloseWorkerGlobalScopeTask::isCleanupTask):
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
(WebCore::WorkerGlobalScope::~WorkerGlobalScope):
(WebCore::WorkerGlobalScope::applyContentSecurityPolicyFromString):
(WebCore::WorkerGlobalScope::scriptExecutionContext):
(WebCore::WorkerGlobalScope::virtualURL):
(WebCore::WorkerGlobalScope::virtualCompleteURL):
(WebCore::WorkerGlobalScope::completeURL):
(WebCore::WorkerGlobalScope::userAgent):
(WebCore::WorkerGlobalScope::disableEval):
(WebCore::WorkerGlobalScope::location):
(WebCore::WorkerGlobalScope::close):
(WebCore::WorkerGlobalScope::navigator):
(WebCore::WorkerGlobalScope::hasPendingActivity):
(WebCore::WorkerGlobalScope::postTask):
(WebCore::WorkerGlobalScope::setTimeout):
(WebCore::WorkerGlobalScope::clearTimeout):
(WebCore::WorkerGlobalScope::clearInspector):
(WebCore::WorkerGlobalScope::setInterval):
(WebCore::WorkerGlobalScope::clearInterval):
(WebCore::WorkerGlobalScope::importScripts):
(WebCore::WorkerGlobalScope::errorEventTarget):
(WebCore::WorkerGlobalScope::logExceptionToConsole):
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):
(WebCore::WorkerGlobalScope::addMessageToWorkerConsole):
(WebCore::WorkerGlobalScope::isContextThread):
(WebCore::WorkerGlobalScope::isJSExecutionForbidden):
(WebCore::WorkerGlobalScope::eventTargetData):
(WebCore::WorkerGlobalScope::ensureEventTargetData):
(WebCore::WorkerGlobalScope::Observer::Observer):
(WebCore::WorkerGlobalScope::Observer::~Observer):
(WebCore::WorkerGlobalScope::Observer::stopObserving):
(WebCore::WorkerGlobalScope::registerObserver):
(WebCore::WorkerGlobalScope::unregisterObserver):
(WebCore::WorkerGlobalScope::notifyObserversOfStop):
(WebCore::WorkerGlobalScope::eventQueue):
- workers/WorkerGlobalScope.h: Renamed from Source/WebCore/workers/WorkerContext.h.
(WebCore::WorkerGlobalScope::isSharedWorkerGlobalScope):
(WebCore::WorkerGlobalScope::isDedicatedWorkerGlobalScope):
(WebCore::WorkerGlobalScope::url):
(WebCore::WorkerGlobalScope::groupSettings):
(WebCore::WorkerGlobalScope::script):
(WebCore::WorkerGlobalScope::clearScript):
(WebCore::WorkerGlobalScope::thread):
(WebCore::WorkerGlobalScope::self):
(WebCore::WorkerGlobalScope::workerInspectorController):
(WebCore::WorkerGlobalScope::optionalNavigator):
(WebCore::WorkerGlobalScope::optionalLocation):
(WebCore::WorkerGlobalScope::isClosing):
- workers/WorkerGlobalScope.idl: Renamed from Source/WebCore/workers/WorkerContext.idl.
- workers/WorkerGlobalScopeProxy.h: Renamed from Source/WebCore/workers/WorkerContextProxy.h.
(WebCore::WorkerGlobalScopeProxy::~WorkerGlobalScopeProxy):
(WebCore::WorkerGlobalScopeProxy::PageInspector::~PageInspector):
(WebCore::WorkerGlobalScopeProxy::connectToInspector):
(WebCore::WorkerGlobalScopeProxy::disconnectFromInspector):
(WebCore::WorkerGlobalScopeProxy::sendMessageToInspector):
- workers/WorkerLoaderProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::MessageWorkerGlobalScopeTask::create):
(WebCore::MessageWorkerGlobalScopeTask::MessageWorkerGlobalScopeTask):
(WebCore::MessageWorkerGlobalScopeTask::performTask):
(WebCore::WorkerGlobalScopeDestroyedTask::create):
(WebCore::WorkerGlobalScopeDestroyedTask::WorkerGlobalScopeDestroyedTask):
(WebCore::WorkerGlobalScopeDestroyedTask::performTask):
(WebCore::WorkerTerminateTask::performTask):
(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::WorkerGlobalScopeProxy::create):
(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::~WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::workerObjectDestroyedInternal):
(WebCore::connectToWorkerGlobalScopeInspectorTask):
(WebCore::WorkerMessagingProxy::connectToInspector):
(WebCore::disconnectFromWorkerGlobalScopeInspectorTask):
(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::dispatchOnInspectorBackendTask):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyedInternal):
(WebCore::WorkerMessagingProxy::terminateWorkerGlobalScope):
- workers/WorkerMessagingProxy.h:
- workers/WorkerObjectProxy.h:
- workers/WorkerReportingProxy.h:
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::run):
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks):
(WebCore::WorkerRunLoop::Task::performTask):
- workers/WorkerRunLoop.h:
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::runEventLoop):
(WebCore::WorkerThreadShutdownFinishTask::performTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):
(WebCore::WorkerThread::stop):
- workers/WorkerThread.h:
(WebCore::WorkerThread::workerGlobalScope):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::usesDashboardBackwardCompatibilityMode):
(WebCore::XMLHttpRequest::responseXML):
Source/WebKit/qt:
Update calls to ScriptExecutionContext::isWorkerContext() as it was
renamed to ScriptExecutionContext::isWorkerGlobalScope().
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::show):
(WebCore::NotificationPresenterClientQt::toPage):
(WebCore::NotificationPresenterClientQt::toFrame):
- 11:15 PM Changeset in webkit [152079] by
-
- 3 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r152065.
- WebCoreSupport/ChromeClientWinCE.cpp:
(WebKit::ChromeClientWinCE::AXStartFrameLoad):
(WebKit::ChromeClientWinCE::AXFinishFrameLoad):
- WebCoreSupport/ChromeClientWinCE.h:
- 11:02 PM Changeset in webkit [152078] by
-
- 2 edits in trunk/Source/WebCore
Avoid redundant checks for Compositing reasons in RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=118114
Patch by Sanjoy Pal <sanjoy.pal@samsung.com> on 2013-06-26
Reviewed by Anders Carlsson.
A RenderObject can be any one of the Video, Canvas, Plugin or Iframe.
Hence removing the redundant checks.
No new tests as no functionality change.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::reasonsForCompositing):
- 9:37 PM Changeset in webkit [152077] by
-
- 3 edits in trunk/Source/WebKit2
Sometimes the Flash Player plugin cannot make outgoing connections
https://bugs.webkit.org/show_bug.cgi?id=118110
<rdar://problem/14270933>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-26
Reviewed by Alexey Proskuryakov.
Allow outgoing and incoming UDP data. Tidy up the QuickTime
profile as it gets the UDP ability from the common profile.
- Resources/PlugInSandboxProfiles/com.apple.QuickTime Plugin.plugin.sb:
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
- 8:30 PM Changeset in webkit [152076] by
-
- 7 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support hole/OOB PutByVal's
https://bugs.webkit.org/show_bug.cgi?id=118112
Reviewed by Geoffrey Garen.
Added a common code generator for the out-of-bounds case that is reused by
all contiguous-like arrays (Int32, Double, Contiguous).
This is relatively straight-forward, except that it's the first time that
the FTL has to call DFG operations that take more than two arguments.
- ftl/FTLAbbreviations.h:
(JSC::FTL::functionType):
(JSC::FTL::buildCall):
- ftl/FTLAbstractHeapRepository.h:
(FTL):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
(FTL):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::contiguousPutByValOutOfBounds):
(JSC::FTL::LowerDFGToLLVM::vmCall):
- ftl/FTLOutput.h:
(JSC::FTL::Output::call):
- 8:07 PM Changeset in webkit [152075] by
-
- 2 edits in trunk/Source/WebKit2
Flash Player: deny ipc-posix-sem 59918130
https://bugs.webkit.org/show_bug.cgi?id=118107
<rdar://problem/14271105>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-26
Reviewed by Alexey Proskuryakov.
Allow same-sandbox scoped semaphores on Mavericks. Permit the
named semaphore for older releases.
- Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
- 7:50 PM Changeset in webkit [152074] by
-
- 7 edits2 adds in trunk/Source
Coordinated Graphics: Separate CoordinatedLayerTreeHost into CoordinatedLayerTreeHost and CompositingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=104360
Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-06-26
Reviewed by Noam Rosenthal.
The CoordinatedLayerTreeHost has too many responsibilities. It
implements LayerTreeHost, GraphicsLayerClient,
CoordinatedGraphicsLayerClient, CoordinatedImageBacking::Client,
UpdateAtlas::Client, GraphicsLayerFactory and
WebCustomFilterProgramProxyClient.
This refactoring reduces the responsibilities of CoordinatedLayerTreeHost.
This patch introduces a new class called CompositingCoordinator, which
takes the responsibility of managing compositing resources in
WebProcess.
CoordinatedLayerTreeHost is responsible only for the scheduling and
IPC-specific stuff, which are relevant only for WebKit2.
No new tests, covered by existing tests.
Source/WebCore:
- CMakeLists.txt:
- Target.pri:
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp: Added.
(WebCore::CompositingCoordinator::create):
(WebCore::CompositingCoordinator::~CompositingCoordinator):
(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::setRootCompositingLayer):
(WebCore::CompositingCoordinator::sizeDidChange):
(WebCore::CompositingCoordinator::flushPendingLayerChanges):
(WebCore::CompositingCoordinator::syncDisplayState):
(WebCore::CompositingCoordinator::nextAnimationServiceTime):
(WebCore::CompositingCoordinator::clearPendingStateChanges):
(WebCore::CompositingCoordinator::initializeRootCompositingLayerIfNeeded):
(WebCore::CompositingCoordinator::createRootLayer):
(WebCore::CompositingCoordinator::syncLayerState):
(WebCore::CompositingCoordinator::createImageBackingIfNeeded):
(WebCore::CompositingCoordinator::createImageBacking):
(WebCore::CompositingCoordinator::updateImageBacking):
(WebCore::CompositingCoordinator::clearImageBackingContents):
(WebCore::CompositingCoordinator::removeImageBacking):
(WebCore::CompositingCoordinator::flushPendingImageBackingChanges):
(WebCore::CompositingCoordinator::notifyAnimationStarted):
(WebCore::CompositingCoordinator::notifyFlushRequired):
(WebCore::CompositingCoordinator::paintContents):
(WebCore::CompositingCoordinator::createGraphicsLayer):
(WebCore::CompositingCoordinator::deviceScaleFactor):
(WebCore::CompositingCoordinator::pageScaleFactor):
(WebCore::CompositingCoordinator::createUpdateAtlas):
(WebCore::CompositingCoordinator::removeUpdateAtlas):
(WebCore::CompositingCoordinator::visibleContentsRect):
(WebCore::CompositingCoordinator::mainContentsLayer):
(WebCore::CompositingCoordinator::setVisibleContentsRect):
(WebCore::CompositingCoordinator::deviceOrPageScaleFactorChanged):
(WebCore::CompositingCoordinator::detachLayer):
(WebCore::CompositingCoordinator::commitScrollOffset):
(WebCore::CompositingCoordinator::renderNextFrame):
(WebCore::CompositingCoordinator::purgeBackingStores):
(WebCore::CompositingCoordinator::paintToSurface):
(WebCore::CompositingCoordinator::scheduleReleaseInactiveAtlases):
(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):
- platform/graphics/texmap/coordinated/CompositingCoordinator.h: Added.
(WebCore::CompositingCoordinator::clearRootLayer):
(WebCore::CompositingCoordinator::rootLayer):
(WebCore::CompositingCoordinator::state):
Source/WebKit2:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::~CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
(WebKit::CoordinatedLayerTreeHost::invalidate):
(WebKit::CoordinatedLayerTreeHost::forceRepaint):
(WebKit::CoordinatedLayerTreeHost::sizeDidChange):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::renderNextFrame):
(WebKit::CoordinatedLayerTreeHost::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHost::willSyncLayerState):
(WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesForAnimations):
(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):
(WebKit::CoordinatedLayerTreeHost::removeCustomFilterProgramProxy):
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush):
(WebKit::CoordinatedLayerTreeHost::createPageOverlayLayer):
(WebKit::CoordinatedLayerTreeHost::paintLayerContents):
(WebKit::CoordinatedLayerTreeHost::commitSceneState):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::CoordinatedLayerTreeHost::graphicsLayerFactory):
(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):
(WebKit::CoordinatedLayerTreeHost::commitScrollOffset):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/LayerTreeHost.h:
- 7:48 PM Changeset in webkit [152073] by
-
- 2 edits in trunk/Source/WebKit2
Silverlight deny ipc-posix-sem LC_Mutex playing Amazon Prime videos
https://bugs.webkit.org/show_bug.cgi?id=118102
<rdar://problem/14194077>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-26
Reviewed by Alexey Proskuryakov.
Allow same-sandbox scoped semaphores on Mavericks. Permit the
named semaphore for older releases.
- Resources/PlugInSandboxProfiles/com.microsoft.SilverlightPlugin.sb:
- 7:46 PM Changeset in webkit [152072] by
-
- 2 edits in trunk/Source/WebKit2
Update ColorSync shared memory names in plug-in sandbox profile
https://bugs.webkit.org/show_bug.cgi?id=118099
Patch by Simon Cooper <scooper@apple.com> on 2013-06-26
Reviewed by Alexey Proskuryakov.
Update the common profile to use the names used in Mavericks
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
- 7:11 PM Changeset in webkit [152071] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL][REGRESSION] Crash after r151540 with debug build
https://bugs.webkit.org/show_bug.cgi?id=118111
Reviewed by Gyuyoung Kim.
- ewk/ewk_view.cpp:
(ewk_view_scroll): Fixed ASSERT conditions wrongly refactored.
- 7:00 PM Changeset in webkit [152070] by
-
- 5 edits2 adds in trunk
Vibration cannot be canceled during pattern vibration.
https://bugs.webkit.org/show_bug.cgi?id=117822
Reviewed by Gyuyoung Kim.
Source/WebCore:
Vibration can not cancel during pattern vibration is working. If resting time which are
even numbers of pattern m_isVibraing will be false and cancel will thus return early.
In addition, m_timerStart needs to be stopped in the cancelVibration().
If cancelVibration() is called right after m_timerStart is fired, timerStartFired
function can be called even if vibration is already canceled because of timing issue of timer.
Test: vibration/cancelVibration-during-pattern-vibrating.html
- Modules/vibration/Vibration.cpp:
(WebCore::Vibration::vibrate):
(WebCore::Vibration::cancelVibration):
(WebCore::Vibration::suspendVibration):
(WebCore::Vibration::resumeVibration):
(WebCore::Vibration::stopVibration):
(WebCore::Vibration::timerStartFired):
(WebCore::Vibration::timerStopFired):
- Modules/vibration/Vibration.h:
LayoutTests:
Add a test case for vibration cancelation during pattern vibration.
In addition, restore visibilityState before executing cancelVibration-after-pagevisibility-changed-to-hidden.html.
- vibration/cancelVibration-after-pagevisibility-changed-to-hidden.html:
- vibration/cancelVibration-during-pattern-vibrating-expected.txt: Added.
- vibration/cancelVibration-during-pattern-vibrating.html: Added.
- 6:08 PM Changeset in webkit [152069] by
-
- 44 edits in trunk
Deprecate StringImpl::charactersWithNullTermination
https://bugs.webkit.org/show_bug.cgi?id=118108
Reviewed by Beth Dakin.
Source/WebCore:
Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
- html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::cacheActiveAttribLocations):
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::getLinkedFonts):
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/win/IconWin.cpp:
(WebCore::Icon::createIconForFiles):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime):
- platform/graphics/wince/FontPlatformData.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- platform/network/curl/CurlDownload.cpp:
(CurlDownload::moveFileToDestination):
- platform/network/win/CookieJarWin.cpp:
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
- platform/network/win/DownloadBundleWin.cpp:
(WebCore::DownloadBundle::appendResumeData):
(WebCore::DownloadBundle::extractResumeData):
- platform/network/win/ResourceHandleWin.cpp:
(WebCore::createInternetHandle):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::fileLoadTimer):
- platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
- platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
- platform/text/win/LocaleWin.cpp:
(WebCore::LCIDFromLocaleInternal):
- platform/text/win/TextCodecWin.cpp:
(WebCore::TextCodecWin::enumerateSupportedEncodings):
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getWebLocData):
(WebCore::createGlobalData):
(WebCore::setFileDescriptorData):
(WebCore::getURL):
(WebCore::setCFData):
- platform/win/ContextMenuWin.cpp:
(WebCore::ContextMenu::createPlatformContextMenuFromItems):
- platform/win/DragImageWin.cpp:
(WebCore::createDragImageIconForCachedImageFilename):
- platform/win/FileSystemWin.cpp:
(WebCore::getFindData):
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::pathGetFileName):
(WebCore::openTemporaryFile):
(WebCore::openFile):
- platform/win/MIMETypeRegistryWin.cpp:
(WebCore::mimeTypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
- platform/win/PasteboardWin.cpp:
(WebCore::createGlobalImageFileDescriptor):
(WebCore::createGlobalHDropContent):
- platform/win/PathWalker.cpp:
(WebCore::PathWalker::PathWalker):
- platform/win/SSLKeyGeneratorWin.cpp:
(WebCore::WebCore::signedPublicKeyAndChallengeString):
- platform/win/SharedBufferWin.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):
- platform/wince/FileSystemWinCE.cpp:
(WebCore::getFileInfo):
(WebCore::fileExists):
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::makeAllDirectories):
(WebCore::openTemporaryFile):
(WebCore::openFile):
- plugins/win/PluginDatabaseWin.cpp:
(WebCore::PluginDatabase::getPluginPathsInDirectories):
(WebCore::addMozillaPluginDirectories):
(WebCore::addAdobeAcrobatPluginDirectory):
(WebCore::addJavaPluginDirectory):
- plugins/win/PluginPackageWin.cpp:
(WebCore::getVersionInfo):
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::handlePostReadFile):
Source/WebKit/win:
Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
- COMPropertyBag.h:
(::GetPropertyInfo):
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::runOpenPanel):
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::updateWindowTitle):
- WebDownloadCFNet.cpp:
(WebDownload::didFinish):
- WebKitSystemBits.cpp:
(WebVolumeFreeSize):
- WebLocalizableStrings.cpp:
(LocalizedString::operator LPCTSTR):
- WebView.cpp:
(WebView::setToolTip):
Source/WebKit2:
Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::createServerAndClientIdentifiers):
Source/WTF:
The optimization in String and StringImpl to keep track of whether a string
has a null terminator isn't worth it; in most cases we call charactersWithNullTermination() on
temporary strings which ends up copying strings anyway.
A better solution is to have a charactersWithNullTermination() function that returns a Vector<UChar>,
which is similar to what we have for String::utf8() and String::ascii(). This will be done in a follow-up patch.
- wtf/text/WTFString.cpp:
(WTF::String::deprecatedCharactersWithNullTermination):
- wtf/text/WTFString.h:
Tools:
Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
- DumpRenderTree/win/DumpRenderTree.cpp:
(findFontFallback):
(addFontFallbackIfPresent):
(removeFontFallbackIfPresent):
- 5:59 PM Changeset in webkit [152068] by
-
- 5 edits in branches/safari-537-branch/Source
Versioning.
- 5:52 PM Changeset in webkit [152067] by
-
- 5 edits in tags/Safari-537.47/Source
Versioning.
- 5:40 PM Changeset in webkit [152066] by
-
- 1 copy in tags/Safari-537.47
New Tag.
- 5:39 PM Changeset in webkit [152065] by
-
- 14 edits1 add in trunk/Source
Add an accessibility delegate interface to AppleWin port.
https://bugs.webkit.org/show_bug.cgi?id=118094.
Reviewed by Brent Fulgham.
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters:
- Interfaces/AccessibilityDelegate.idl: Added.
- Interfaces/IWebView.idl:
- Interfaces/WebKit.idl:
- WebCoreSupport/WebChromeClient.cpp: Add methods that call into the AccessibilityDelegate.
(WebChromeClient::AXStartFrameLoad):
(WebChromeClient::AXFinishFrameLoad):
- WebCoreSupport/WebChromeClient.h:
- WebView.cpp: Add support for setting and getting the AccessibilityDelegate from the WebView.
(WebView::close):
(WebView::setAccessibilityDelegate):
(WebView::accessibilityDelegate):
- WebView.h:
- accessibility/win/AXObjectCacheWin.cpp: We call the page client's AXStartFrameLoad and AXFinishFrameLoad methods here, which will in turn call the AccessibilityDelegate's callbacks.
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
- loader/EmptyClients.h:
(WebCore::EmptyChromeClient::AXStartFrameLoad):
(WebCore::EmptyChromeClient::AXFinishFrameLoad):
- page/ChromeClient.h:
- 5:07 PM Changeset in webkit [152064] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152020. <rdar://problem/14278229>
- 5:03 PM Changeset in webkit [152063] by
-
- 2 edits in trunk/Source/WebKit2
QuickTime plug-in cannot update com.apple.quicktime.plugin.preferences.plist file
https://bugs.webkit.org/show_bug.cgi?id=118098
<rdar://problem/13888138>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-26
Reviewed by Alexey Proskuryakov.
Allow the preference file to be written
- Resources/PlugInSandboxProfiles/com.apple.QuickTime Plugin.plugin.sb:
- 4:44 PM Changeset in webkit [152062] by
-
- 3 edits2 copies in branches/safari-537-branch
Merged r151998. <rdar://problem/14272548>
- 4:39 PM Changeset in webkit [152061] by
-
- 9 edits6 copies in branches/safari-537-branch
Merged r151997. <rdar://problem/14223569>
- 4:34 PM Changeset in webkit [152060] by
-
- 5 edits in branches/safari-537-branch/Source/WebCore
Merged r151994. <rdar://problem/14241270>
- 4:32 PM Changeset in webkit [152059] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r151986. <rdar://problem/14272659>
- 4:31 PM Changeset in webkit [152058] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r151971. <rdar://problem/12885400>
- 4:28 PM Changeset in webkit [152057] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Merged r151953. <rdar://problem/14248148>
- 4:28 PM Changeset in webkit [152056] by
-
- 5 edits in branches/safari-537-branch/Source/WebKit2
Merged r151952. <rdar://problem/13927918>
- 4:26 PM Changeset in webkit [152055] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r151950. <rdar://problem/14121247>
- 4:25 PM Changeset in webkit [152054] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r151948. <rdar://problem/14036864>
- 4:23 PM Changeset in webkit [152053] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r151944. <rdar://problem/14193693>
- 4:23 PM Changeset in webkit [152052] by
-
- 8 edits1 add in trunk/Source
Add JSStringCreateWithCharactersNoCopy SPI
https://bugs.webkit.org/show_bug.cgi?id=118074
<rdar://problem/14279905>
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- API/JSStringRef.cpp:
(JSStringCreateWithCharactersNoCopy):
Create a new OpaqueJSString, using the newly added StringImpl::createWithoutCopying function.
- API/JSStringRefPrivate.h: Added.
Add a home for the JSStringCreateWithCharactersNoCopy function.
- API/OpaqueJSString.h:
(OpaqueJSString::OpaqueJSString):
Just call isolatedCopy on the passed in string.
- API/tests/testapi.c:
Add an API test for JSStringCreateWithCharactersNoCopy.
- JavaScriptCore.xcodeproj/project.pbxproj:
Add new files.
Source/WTF:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::createFromLiteral):
Use the new ConstructWithoutCopying constructor, passing DoesHaveTerminatingNullCharacter to it.
Change the other createFromLiteral overload to just call the first.
(WTF::StringImpl::createWithoutCopying):
Add helper functions for creating strings that shouldn't copy their underlying data.
- wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl):
Rename the ConstructFromLiteralTag constructor enum to ConstructWithoutCopyingTag. Change the constructor
to take an enum that states whether the string has a terminating null character or not.
(WTF::StringImpl::createFromLiteral):
Call createWithoutCopying.
(WTF::StringImpl::requiresCopy):
Rename this from isASCIILiteral() and make it more generic so it can handle 16-bit strings as well.
(WTF::StringImpl::isolatedCopy):
If this string doesn't have to be copied, just create a new StringImpl object that references the current data.
- 4:22 PM Changeset in webkit [152051] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r151943. <rdar://problem/14084234>
- 4:21 PM Changeset in webkit [152050] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r151941. <rdar://problem/14223823>
- 4:19 PM Changeset in webkit [152049] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r151940. <rdar://problem/13938149>
- 4:17 PM Changeset in webkit [152048] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r151939. <rdar://problem/14166577>
- 4:14 PM Changeset in webkit [152047] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r151938. <rdar://problem/14163582>
- 4:09 PM Changeset in webkit [152046] by
-
- 3 edits2 copies in branches/safari-537-branch
Merged r151934. <rdar://problem/14230128>
- 4:07 PM Changeset in webkit [152045] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL::canCompile(Graph&) should not consider nodes that won't be compiled
https://bugs.webkit.org/show_bug.cgi?id=118097
Reviewed by Mark Hahnenberg.
This increases coverage to include programs that have unprofiled paths. Those paths will
often have nodes that appear to do untyped speculations, and the FTL sometimes doesn't
support those; except that it doesn't matter since the reason why they were untyped is
that they were unprofiled and anyway we won't run them because we'll exit before them.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- 4:07 PM Changeset in webkit [152044] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r151927. <rdar://problem/14223539>
- 4:04 PM Changeset in webkit [152043] by
-
- 25 edits11 copies3 deletes in branches/safari-537-branch/LayoutTests
Merged r151924. <rdar://problem/14248148>
- 4:03 PM Changeset in webkit [152042] by
-
- 2 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r151918. <rdar://problem/14244539>
- 4:02 PM Changeset in webkit [152041] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r151916. <rdar://problem/14246763>
- 4:00 PM Changeset in webkit [152040] by
-
- 4 edits2 copies in branches/safari-537-branch
Merged r151894. <rdar://problem/13008605>
- 3:56 PM Changeset in webkit [152039] by
-
- 4 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support ArrayifyToStructure
https://bugs.webkit.org/show_bug.cgi?id=118095
Reviewed by Mark Hahnenberg.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
(FTL):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArrayifyToStructure):
(LowerDFGToLLVM):
- 3:51 PM Changeset in webkit [152038] by
-
- 9 edits2 adds in trunk
Potential use-after-free after neutering AudioBuffer's underlying ArrayBuffer.
https://bugs.webkit.org/show_bug.cgi?id=118040
Reviewed by Filip Pizlo.
Source/WebCore:
Test: webaudio/audiobuffer-neuter.html
When creating an AudioBuffer's backing ArrayBufferView objects, mark them as 'unneuterable',
meaning the underlying data will be copied in a neuter scenario rather than transferred. This
means the underlying assumtions of the webaudio code can continue to assume that the memory
areas owned by the ArrayBufferView will be present until the AudioBuffer is itself destroyed.
In order to not expose the 'unneuterable' behavior to JavaScript, return a fresh Float32Array
wrapper around the ArrayBuffer object, rather than our own.
- Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::AudioBuffer): Mark the newly created channels as not neuterable.
(WebCore::AudioBuffer::getChannelData): Return a new Float32Array object rather than a pointer to our own.
- Modules/webaudio/AudioBuffer.h:
Source/WTF:
Add support for 'unneuterable' ArrayBufferViews. Views marked as such will have their underlying
ArrayBuffer objects copied rather than transferred to a new view.
- wtf/ArrayBuffer.cpp:
(WTF::ArrayBuffer::transfer): Check whether the associated views are neuterable, and if not
clone the ArrayBuffer rather than transferring it.
- wtf/ArrayBuffer.h:
(WTF::ArrayBufferContents::copyTo): Added. Utility function.
- wtf/ArrayBufferView.cpp:
(WTF::ArrayBufferView::ArrayBufferView):
(WTF::ArrayBufferView::neuter):
- wtf/ArrayBufferView.h:
(WTF::ArrayBufferView::setNeuterable):
(WTF::ArrayBufferView::isNeuterable):
LayoutTests:
- webaudio/audiobuffer-neuter.html: Added.
- webaudio/audiobuffer-neuter-expected.txt: Added.
- 3:36 PM Changeset in webkit [152037] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Unreviewed build correction after r152035.
- page/CaptionUserPreferencesMediaAF.cpp: Don't attempt to include CoreText.h if we do not have MediaAccessibility Framework.
- 3:16 PM Changeset in webkit [152036] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support ForwardCheckStructure/ForwardStructureTransitionWatchpoint and doing so shouldn't break V8/crypto
https://bugs.webkit.org/show_bug.cgi?id=118091
Reviewed by Mark Hahnenberg.
I was going to just add ForwardCheckStructure/ForwardStructureTransitionWatchpoint support,
which is trivial. But doing so increases coverage a lot, and revealed long-standing bugs in
the FTL. I then fixed those bugs, also:
- The FTL should not attempt to compile a block that is not reachable according to the CFA. This is analogous to terminating basic block compilation if the CFA becomes !isValid(). Attempting to compile such a block means that you're running on broken CFA state, and the CFA will become inconsistent with the code you're generating, leading to some strangeness. For example, the FTL relies on the CFA to tell it that we gave up compiling a node and hence don't have LValue's for that node (by virtue of us giving up due to !isValid()). But the CFA's isValid() bit will not be set correctly for blocks that weren't visited by the CFA at all, and the CFA expects you to know this because it expects that you already checked BasicBlock::cfaHasVisited.
- SetLocal needs to change the ValueSource of the operand to indicate that its value has been stashed in the local (i.e. the "reference" corresponding to the operand in FTL speak). This is because although OSR exit already knows that the value of the operand is stored in the Node, and it already knows what LValue corresponds to the node, OSR exit will also assume that if the Node dies then the value-at-exit for that operand should be Dead (i.e. jsUndefined). But the Node dying, and the local dying, are two distinct things; in particular the local always outlives the Node in the case of a SetLocal. So, we just need to have SetLocal have the ValueSource be BlahInLocal rather than HaveNode, to ensure that OSR exit knows that the darn thing is really live until the end of the basic block, as opposed to until whenever the Node dies (which could be at any time).
- PutByOffset was erroneously storing to an offset from the base object, rather than an offset from the storage. Note that the storage will be the base object (exactly - i.e. same node, same value) for inline stores, but will be a distinct thing for out-of-line stores.
- At-head set-up of OSR exit state was using ValueInLocals for variables forced double, when it should have been using DoubleInLocals.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compilePutByOffset):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
- 3:02 PM Changeset in webkit [152035] by
-
- 7 edits in trunk/Source
../WebCore: [Windows] Enable CaptionUserPreferencesMediaAF on Windows.
https://bugs.webkit.org/show_bug.cgi?id=118076
Reviewed by Eric Carlson.
- WebCore.vcxproj/WebCore.vcxproj: Enable building the CaptionUserPreferencesMediaAF source file.
- page/CaptionUserPreferencesMediaAF.cpp: Add soft-link commands for CoreText symbols needed in the implementation for Windows.
- platform/LocalizedStrings.cpp: Enable Text Track-related strings on Windows.
- platform/LocalizedStrings.h: Ditto.
../WTF: [Windows] Enable CaptionUserPreferenceMediaAF on Windows.
https://bugs.webkit.org/show_bug.cgi?id=118076
Reviewed by Eric Carlson.
- wtf/Platform.h: Enable Media Accessibility Framework in Windows build environments that support it.
- 2:47 PM Changeset in webkit [152034] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r151879. <rdar://problem/13560876>
- 2:45 PM Changeset in webkit [152033] by
-
- 11 edits1 copy in branches/safari-537-branch/Source
Merged r151877. <rdar://problem/13560876>
- 2:42 PM Changeset in webkit [152032] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r151881. <rdar://problem/14136687>
- 2:41 PM Changeset in webkit [152031] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r151875. <rdar://problem/14202130>
- 2:38 PM Changeset in webkit [152030] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r151873. <rdar://problem/14229987>
- 2:38 PM Changeset in webkit [152029] by
-
- 2 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r151861. <rdar://problem/14233755>
- 2:35 PM Changeset in webkit [152028] by
-
- 5 edits in branches/safari-537-branch
Merged r151852. <rdar://problem/14231548>
- 2:33 PM Changeset in webkit [152027] by
-
- 6 edits in branches/safari-537-branch
Merged r151836. <rdar://problem/14043357>
- 2:26 PM Changeset in webkit [152026] by
-
- 33 edits in branches/safari-537-branch
Merged r151832. <rdar://problem/14160571>
- 2:20 PM Changeset in webkit [152025] by
-
- 4 edits2 copies in branches/safari-537-branch
Merged r151822. <rdar://problem/14225079>
- 2:14 PM Changeset in webkit [152024] by
-
- 3 edits2 copies in branches/safari-537-branch
Merged r151821. <rdar://problem/14118228>
- 2:11 PM Changeset in webkit [152023] by
-
- 3 edits2 copies in branches/safari-537-branch
Merged r151812. <rdar://problem/13977070>
- 2:09 PM Changeset in webkit [152022] by
-
- 3 edits2 copies in branches/safari-537-branch
Merged r151807. <rdar://problem/13860717>
- 2:07 PM Changeset in webkit [152021] by
-
- 6 edits in branches/safari-537-branch/Source
Merged r151804. <rdar://problem/14063409>
- 2:04 PM Changeset in webkit [152020] by
-
- 2 edits in trunk/Source/WebCore
Speed up SVG sprites by only painting the source rect in SVGImage::draw
https://bugs.webkit.org/show_bug.cgi?id=118070
Reviewed by Tim Horton.
Merge https://chromium.googlesource.com/chromium/blink/+/d359ab67fdd76a877d666dca91c311505dd27bbf.
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::draw):
- 2:04 PM Changeset in webkit [152019] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r151803. <rdar://problem/14067600>
- 2:02 PM Changeset in webkit [152018] by
-
- 1 edit1 delete in trunk/Tools
Remove detect-mismached-virtual-const.
https://bugs.webkit.org/show_bug.cgi?id=117999
Reviewed by Anders Carlsson.
Clang warns on mismatched virtual const, so there's no need for this
script any more.
- Scripts/detect-mismatched-virtual-const: Removed.
- 2:02 PM Changeset in webkit [152017] by
-
- 5 edits2 copies in branches/safari-537-branch
Merged r151796. <rdar://problem/14191593>
- 1:59 PM Changeset in webkit [152016] by
-
- 6 edits in branches/safari-537-branch/Source/WebKit2
Merged r151795. <rdar://problem/14112329>
- 1:59 PM Changeset in webkit [152015] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r151793. <rdar://problem/14212635>
- 1:58 PM Changeset in webkit [152014] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support PutByVal
https://bugs.webkit.org/show_bug.cgi?id=118075
Reviewed by Mark Hahnenberg.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
- 1:55 PM Changeset in webkit [152013] by
-
- 9 edits in branches/safari-537-branch
Merged r151776. <rdar://problem/13730458>
- 1:51 PM Changeset in webkit [152012] by
-
- 2 edits2 adds in trunk/Tools
Added a code coverage report.
https://bugs.webkit.org/show_bug.cgi?id=117941
Reviewed by Joseph Pecoraro.
- CodeCoverage: Added.
- CodeCoverage/results-template.html: Added.
- Scripts/generate-coverage-data: Generate and open the new report.
- 1:51 PM Changeset in webkit [152011] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r151785. <rdar://problem/14218781>
- 1:47 PM Changeset in webkit [152010] by
-
- 9 edits2 deletes in branches/safari-537-branch
Merged r151774. <rdar://problem/14209720>
- 1:46 PM Changeset in webkit [152009] by
-
- 8 edits in branches/safari-537-branch/Source/WebKit2
Merged r151767. <rdar://problem/14159371>
- 1:43 PM Changeset in webkit [152008] by
-
- 8 edits in branches/safari-537-branch/Source/WebKit2
Merged r151748. <rdar://problem/14166644>
- 1:41 PM Changeset in webkit [152007] by
-
- 3 edits2 copies in branches/safari-537-branch
Merged r151719. <rdar://problem/14198987>
- 12:49 PM Changeset in webkit [152006] by
-
- 3 edits in trunk/Source/WebCore
BUILD FIX (r151981): Include HTMLAudioElement.h for ENABLE(PLUGIN_PROXY_FOR_VIDEO)
- css/StyleResolver.cpp:
- Include HTMLAudioElement.h.
- Sort headers.
- rendering/RenderLayerCompositor.cpp:
- Include HTMLAudioElement.h.
- 12:39 PM Changeset in webkit [152005] by
-
- 3 edits2 adds in trunk
getComputedStyle().width wrong after text changed
https://bugs.webkit.org/show_bug.cgi?id=106611
Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-06-26
Reviewed by Dean Jackson.
Source/WebCore:
When a new RenderText is created, NodeRenderingContext::createRendererForTextIfNeeded() sets a style to the RenderText.
If a font in the new style needs transcode (e.g. Meiryo), styleDidChange() calls transformText().
It sets a preferredLogicalWidthsDirty flag.
After that, createRendererForTextIfNeeded() inserts the RenderText to its parent renderer.
However, RenderObjectChildList::insertChildNode() doesn't set a preferredLogicalWidthsDirty flag of owner
because a preferredLogicalWidthsDirty flag of the RenderText is already true.
Inserting new child should always sets a preferredLogicalWidthsDirty flag.
Therefore, this patch called setPreferredLogicalWidthsDirty() of owner.
Test: fast/dynamic/empty-absolute-innerhtml-transcoding-text.html
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::insertChildNode):
LayoutTests:
- fast/dynamic/empty-absolute-innerhtml-transcoding-text-expected.html: Added.
- fast/dynamic/empty-absolute-innerhtml-transcoding-text.html: Added.
- 11:49 AM Changeset in webkit [152004] by
-
- 5 edits2 moves in trunk/Source/WebCore
Prepare CaptionUserPreferencesMac for use on Windows port.
https://bugs.webkit.org/show_bug.cgi?id=118069
Reviewed by Eric Carlson.
- WebCore.vcxproj/WebCore.vcxproj: Add new files.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Update for new file name.
- page/CaptionUserPreferencesMac.h: Removed.
- page/CaptionUserPreferencesMac.mm: Removed.
- page/CaptionUserPreferencesMediaAF.cpp: Copied from page/CaptionUserPreferencesMac.mm.
- page/CaptionUserPreferencesMediaAF.h: Copied from page/CaptionUserPreferencesMac.h.
- page/PageGroup.cpp:
(WebCore::PageGroup::captionPreferences): Updated to new class name.
- 11:17 AM Changeset in webkit [152003] by
-
- 2 edits in trunk/Source/WebCore
Remove unneccesary cast to Node* in MediaControlTextTrackContainerElement::updateDisplay
https://bugs.webkit.org/show_bug.cgi?id=118020
Reviewed by Christophe Dumez.
Merge https://chromium.googlesource.com/chromium/blink/+/2de89f61bb316f5e166b45ce71bb2b293dbf575d
TextTrackCue is a Node, there's no reason to static_cast from it to Node*.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
- 11:13 AM Changeset in webkit [152002] by
-
- 2 edits in trunk/Source/WebCore
RenderBox::hasRenderOverflow should return bool instead of RenderOverflow*
https://bugs.webkit.org/show_bug.cgi?id=118041
Reviewed by Christophe Dumez.
Merge https://chromium.googlesource.com/chromium/blink/+/1683b58c855b745463acbf18086e32279db5000f.
- rendering/RenderBox.h:
(WebCore::RenderBox::hasRenderOverflow):
(WebCore::RenderBox::hasHorizontalLayoutOverflow):
(WebCore::RenderBox::hasVerticalLayoutOverflow):
- 11:06 AM Changeset in webkit [152001] by
-
- 2 edits in trunk/Source/WebCore
Remove unneeded static_casts from SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=118018
Reviewed by Christophe Dumez.
Merge https://chromium.googlesource.com/chromium/blink/+/adc5b8bec2d8c6a857b3c930ca7484f76cad1367
SelectorChecker::checkOne casts to StyledElement just to call classNames, but
this method is on Element so there's no reason for this. The cast here also
looks pretty suspect. The method also casts to HTMLFrameElementBase to call
containsFullScreenElement which is also on Element so the cast can be removed.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- 10:55 AM Changeset in webkit [152000] by
-
- 2 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r151846. <rdar://problem/13955160>
- 10:52 AM Changeset in webkit [151999] by
-
- 5 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r151738. <rdar://problem/13439854>
- 10:47 AM Changeset in webkit [151998] by
-
- 3 edits2 adds in trunk
Set Attr.ownerDocument in Element#setAttributeNode()
https://bugs.webkit.org/show_bug.cgi?id=118031
Reviewed by Andreas Kling.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/fa739fe5369f55bbdcb3fa123cb64df36b8ae414.
Adopt Attr node as needed.
Test: fast/dom/Attr/set-attribute-node-from-iframe.html
- dom/Element.cpp:
(WebCore::Element::setAttributeNode):
LayoutTests:
Add a regression test.
- fast/dom/Attr/set-attribute-node-from-iframe-expected.txt: Added.
- fast/dom/Attr/set-attribute-node-from-iframe.html: Added.
- 10:31 AM Changeset in webkit [151997] by
-
- 9 edits6 adds in trunk
Flex boxes (both old and new) don't handle max-height images correctly.
https://bugs.webkit.org/show_bug.cgi?id=118000
Reviewed by Beth Dakin.
Source/WebCore:
Tests: css3/flexbox/image-percent-max-height.html
fast/flexbox/image-percent-max-height.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::dirtyForLayoutFromPercentageHeightDescendants):
(WebCore::RenderBlock::layoutBlockChildren):
Pull the percentage height descendant code that dirties those descendants
out of layoutBlockChildren and into a protected helper function,
dirtyForLayoutFromPercentageHeightDescendants, that can be called from the
flex box code.
Also patch dirtyForLayoutFromPercentageHeightDescendants so that it will dirty
preferred logical widths when a child has an aspect ratio, since we know that
percentage height changes will potentially affect the preferred widths of the image and
its ancestor blocks.
- rendering/RenderBlock.h:
Declaration of the new dirtyForLayoutFromPercentageHeightDescendants function.
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
Make the old flex box code call dirtyForLayoutFromPercentageHeightDescendants so
that everything is dirtied properly.
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
Remove the isReplaced()/percentage height/width dirtying now that the old flexible
box is using the same dirtying mechanism as RenderBlock.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
Patch the new flexible box code to use the dirtying mechanism that RenderBlock
uses for percentage heights/widths on replaced descendants.
- rendering/RenderObject.h:
(WebCore::RenderObject::hasAspectRatio):
Pulled the static helper function from RenderReplaced into a full-blown method
on RenderObject, so that dirtyForLayoutFromPercentageHeightDescendants can call
it to check if an object has an aspect ratio.
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox):
(WebCore::RenderReplaced::computeIntrinsicRatioInformation):
Patch the call sites of the static helper function to use hasAspectRatio instead
and get rid of the static in the cpp file.
LayoutTests:
- css3/flexbox/image-percent-max-height-expected.html: Added.
- css3/flexbox/image-percent-max-height.html: Added.
- css3/flexbox/resources/hero.png: Added.
- fast/flexbox/image-percent-max-height-expected.html: Added.
- fast/flexbox/image-percent-max-height.html: Added.
- fast/flexbox/resources/hero.png: Added.
- 10:23 AM Changeset in webkit [151996] by
-
- 12 edits in trunk/Source
Adopt is/toHTMLAreaElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=117980
Reviewed by Antonio Gomes.
To enhance readibility, this patch adopts is/toHTMLAreaElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedUIElementForPage):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::addImageMapChildren):
- html/HTMLAreaElement.h:
(WebCore::isHTMLAreaElement):
(WebCore::toHTMLAreaElement):
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::mapMouseEvent):
- page/FocusController.cpp:
(WebCore::FocusController::advanceFocusDirectionally):
- page/SpatialNavigation.cpp:
(WebCore::FocusCandidate::FocusCandidate):
(WebCore::areElementsOnSameLine):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absoluteLinkURL):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintAreaElementFocusRing):
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::elementForTapHighlight):
- 10:18 AM Changeset in webkit [151995] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] ASSERT(!m_tileMatrixNeedsUpdate) in BackingStorePrivate::render()
https://bugs.webkit.org/show_bug.cgi?id=118062
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-06-26.
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.
JIRA426949
requestLayoutIfNeeded() can cause zoomAboutPoint() when the layout
is finished and make the tile matrix stale. We need requestLayoutIfNeeded()
before we updateTileMatrixIfNeeded() so that we can fix the ASSERT and
also pass the valid TileIndexList to render().
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::render):
- 10:03 AM Changeset in webkit [151994] by
-
- 5 edits in trunk/Source/WebCore
[Mac] Document URL is not updated by HSTS
<rdar://problem/14241270> and https://bugs.webkit.org/show_bug.cgi?id=118003
Patch started by Alexey Proskuryakov, finished by Brady Eidson.
Reviewed by Brady Eidson and then Alexey Proskuryakov.
Synthesize a response and properly handle willSendRequest when the URL changes in a way that's typical for HSTS.
- platform/network/mac/WebCoreURLResponse:
- platform/network/mac/WebCoreURLResponse:
(WebCore::synthesizeRedirectResponseIfNecessary): Synthesize a redirect response and when the URL changes in a way that's
typical for HSTS connections.
- platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Call synthesizeRedirectResponseIfNecessary.
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]): Ditto.
- 9:28 AM Changeset in webkit [151993] by
-
- 2 edits in trunk/LayoutTests
editing/selection/doubleclick-crash.html can be flaky
https://bugs.webkit.org/show_bug.cgi?id=118017
Reviewed by Jessie Berlin.
Merge https://chromium.googlesource.com/chromium/blink/+/45ac882064589ac41a63762905f0618fc035cd44.
- editing/selection/doubleclick-crash.html:
- 9:05 AM Changeset in webkit [151992] by
-
- 2 edits in trunk/Source/WebCore
[CSS Regions] fast/regions/seamless-iframe-flowed-into-regions.html asserts
https://bugs.webkit.org/show_bug.cgi?id=117797
Reviewed by Antti Koivisto.
The seamless iframes inherit the current RenderFlowThread during layout. This means getting
the LayoutState object from the flow thread RenderView object is not always correct.
For RenderObjects inside the seamless iframes the view()/LayoutState object is different than the one
of the RenderFlowThread. The patch changes the code to use the correct LayoutState object during
layout when pushing a new state.
Tests: covered by fast/regions/seamless-iframe-flowed-into-regions.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::currentActiveRenderBox):
(WebCore::RenderFlowThread::pushFlowThreadLayoutState):
(WebCore::RenderFlowThread::popFlowThreadLayoutState):
- 9:00 AM Changeset in webkit [151991] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: stepping through while paused in debugger makes a popover appear
https://bugs.webkit.org/show_bug.cgi?id=117994
There is no obvious need to call tokenTrackingControllerNewHighlightCandidate when the
active call frame changes and it leads to an extraneous display of the popover.
Reviewed by Timothy Hatcher.
- UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._activeCallFrameDidChange):
- 8:38 AM Changeset in webkit [151990] by
-
- 2 edits in trunk/Source/WebCore
Remove many static_casts to Element types from AccessibilityNodeObject
https://bugs.webkit.org/show_bug.cgi?id=118021
Reviewed by Chris Fleizach.
Merge https://chromium.googlesource.com/chromium/blink/+/ecd837f94996a20fdb8798e24f26cf6edea2a423.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::alternativeTextForWebArea):
(WebCore::AccessibilityNodeObject::text):
- 8:18 AM Changeset in webkit [151989] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Convert versus AsIs should have no bearing on whether we can do the SaneChain optimization for double array GetByVals
https://bugs.webkit.org/show_bug.cgi?id=118028
Reviewed by Sam Weinig.
The SaneChain optimization allows us to get rid of the NaN check on loading from
a double array, if the result is used in an arithmetic op that wouldn't
distinguish between NaN and undefined. Normally the NaN check would be needed
because NaN is the hole marker.
The SaneChain optimization definitely requires that you're an Original array,
since we need to watchpoint the array prototype chain. And so it also needs to
be a JSArray, and not an object that has indexed double properties. We also
require an in-bounds access, since the backend is only capable of the
optimization in the in-bounds case (though we could extend it to OOB in the
future). But whether the array is being converted or is as-is isn't relevant.
Either way, if it's a double original array in-bounds access by the time that
the array check (or conversion!) completes, we can do the optimization.
Ever-so-slight speed-up on Kraken/imaging-gaussian-blur.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- 7:28 AM Changeset in webkit [151988] by
-
- 30 edits in trunk/Source/WebCore
Stop inheriting SVGExternalResourcesRequired, SVGFitToViewBox and SVGZoomAndPan
https://bugs.webkit.org/show_bug.cgi?id=118029
Reviewed by Kentaro Hara.
Stop inheriting SVGExternalResourcesRequired, SVGFitToViewBox and SVGZoomAndPan
in the IDL and use implements statements instead.
This is one step towards getting rid of multiple inheritance in the SVG code
and matching the latest specification:
http://www.w3.org/TR/SVG2/types.html#BasicDOMInterfaces
There is no webexposed behavior change.
No new tests, no behavior change.
- svg/SVGAnimationElement.idl:
- svg/SVGCircleElement.idl:
- svg/SVGClipPathElement.idl:
- svg/SVGCursorElement.idl:
- svg/SVGDefsElement.idl:
- svg/SVGEllipseElement.idl:
- svg/SVGFEImageElement.idl:
- svg/SVGFilterElement.idl:
- svg/SVGForeignObjectElement.idl:
- svg/SVGGElement.idl:
- svg/SVGGradientElement.idl:
- svg/SVGImageElement.idl:
- svg/SVGLineElement.idl:
- svg/SVGMPathElement.idl:
- svg/SVGMarkerElement.idl:
- svg/SVGMaskElement.idl:
- svg/SVGPathElement.idl:
- svg/SVGPatternElement.idl:
- svg/SVGPolygonElement.idl:
- svg/SVGPolylineElement.idl:
- svg/SVGRectElement.idl:
- svg/SVGSVGElement.idl:
- svg/SVGScriptElement.idl:
- svg/SVGSwitchElement.idl:
- svg/SVGSymbolElement.idl:
- svg/SVGTextContentElement.idl:
- svg/SVGUseElement.idl:
- svg/SVGViewSpec.idl:
- 4:45 AM Changeset in webkit [151987] by
-
- 1 edit1 delete in trunk/Tools
gdb: Remove the webcore.py pretty printer.
https://bugs.webkit.org/show_bug.cgi?id=117992
Reviewed by Jochen Eisinger.
webcore.py has been only a placeholder for backwards compatibility
for almost 3 years. It should be safe enough to remove it now.
- gdb/webcore.py: Removed.
- 3:49 AM Changeset in webkit [151986] by
-
- 2 edits in trunk/Source/WebCore
Use-after-free in RadioInputType::handleKeydownEvent
https://bugs.webkit.org/show_bug.cgi?id=118035
Reviewed by Kent Tamura.
Use RefPtr for inputElement since setFocusedNode could blow it away.
- html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):
- 3:39 AM Changeset in webkit [151985] by
-
- 23 edits in trunk
Get rid of multiple inheritence for SVGViewElement interface
https://bugs.webkit.org/show_bug.cgi?id=118014
Reviewed by Kentaro Hara.
Source/WebCore:
Web IDL no longer supports multiple inheritence. As per the latest
specification SVGViewElement should only inherit from SVGElement.
'implements' statements are used for the rest. This patch refactors
the IDL files to match the latest specification:
http://www.w3.org/TR/SVG2/linking.html#InterfaceSVGViewElement
Note that there is a WebExposed change as SVGZoomAndPan used to be
exposed on the Window and it is not anymore. SVGZoomAndPan merely
supplements SVGViewElement and should not be exposed to JavaScript
according to the latest specification.
No new tests, covered by existing tests.
- CMakeLists.txt:
- DerivedSources.pri:
- GNUmakefile.list.am:
- svg/SVGExternalResourcesRequired.idl:
- svg/SVGFitToViewBox.idl:
- svg/SVGViewElement.idl:
- svg/SVGZoomAndPan.idl:
LayoutTests:
Update / Rebaseline several SVG test cases now that SVGZoomAndPan interface
is no longer exposed.
- fast/js/global-constructors-attributes-expected.txt:
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- platform/qt/fast/js/global-constructors-attributes-expected.txt:
- svg/custom/global-constructors-expected.txt:
- svg/custom/js-svg-constructors-expected.txt:
- svg/custom/js-svg-constructors.svg:
- svg/custom/script-tests/global-constructors.js:
- svg/dom/SVGViewSpec-defaults-expected.txt:
- svg/dom/SVGViewSpec-expected.txt:
- svg/dom/resources/viewspec-parser.js:
(zoomAndPanToString):
(viewSpecToString):
- svg/dom/script-tests/SVGViewSpec-defaults.js:
- svg/dom/script-tests/SVGViewSpec.js:
(continueTesting):
- 1:22 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:18 AM Changeset in webkit [151984] by
-
- 2 edits in trunk/Tools
Creating cURL watchlist and adding myself to it.
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-26
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/common/config/watchlist:
- 1:16 AM Changeset in webkit [151983] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK] [WK2] Cannot make debug builds of the stable branch
https://bugs.webkit.org/show_bug.cgi?id=117979
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-06-25
Reviewed by Carlos Garcia Campos.
Add missing source files to WebKitPluginProcess.
- GNUmakefile.list.am:
- 1:14 AM Changeset in webkit [151982] by
-
- 4 edits in trunk/Source/WebCore
Mark SVG(Circle|Path|Rect)Element::createRenderer() with OVERRIDE
https://bugs.webkit.org/show_bug.cgi?id=118037
Reviewed by Philip Rogers.
Merge https://chromium.googlesource.com/chromium/blink/+/e8196920e769ab0786b2b4b21d3fdc2d87afef0d.
- svg/SVGCircleElement.h:
- svg/SVGPathElement.h:
- svg/SVGRectElement.h:
- 12:46 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:44 AM Changeset in webkit [151981] by
-
- 11 edits in trunk/Source
Adopt is/toHTMLAudioElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=117985
Reviewed by Jer Noble.
To enhance readibility, this patch adopts is/toHTMLAudioElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- bindings/js/JSNodeCustom.cpp:
(WebCore::isReachableFromDOM):
- css/CSSDefaultStyleSheets.cpp:
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
- html/HTMLAudioElement.h:
(WebCore::isHTMLAudioElement):
(WebCore::toHTMLAudioElement):
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::mediaElement):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):
Source/WebKit/mac:
- Plugins/WebPluginController.mm:
- 12:24 AM Changeset in webkit [151980] by
-
- 3 edits in trunk/Source/WebCore
Refactoring: Fold Document::focusedNodeRemoved into Document::removeFocusedNodeOfSubtree
https://bugs.webkit.org/show_bug.cgi?id=118036
Reviewed by Kent Tamura.
Merge https://chromium.googlesource.com/chromium/blink/+/3391beabe75548cc638a6c88982f913621a4410f.
- dom/Document.cpp:
(WebCore::Document::removeFocusedNodeOfSubtree):
- dom/Document.h:
Jun 25, 2013:
- 11:37 PM WebKitGTK/StartHacking edited by
- (diff)
- 11:35 PM WebKitGTK/StartHacking edited by
- Estimated size of a debug build added (diff)
- 9:16 PM Changeset in webkit [151979] by
-
- 21 edits26 adds in branches/dfgFourthTier
fourthTier: DFG should support switch_string
https://bugs.webkit.org/show_bug.cgi?id=117967
Source/JavaScriptCore:
Reviewed by Sam Weinig.
Add a reusable binary switch creator.
Implement switch on string using three modes:
- Binary switch on StringImpl* in the case of identifiers.
- Trie of binary switches on characters in the case of a not-too-big switch over not-too-big 8-bit strings.
- Hash lookup if all else fails.
Anywhere from a 2x to 3x speed-up on microbenchmarks that stress
string switches. 25-35% speed-up on HashMap tests. 4% speed-up on
pdfjs.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/JumpTable.h:
(StringJumpTable):
(JSC::StringJumpTable::clear):
- dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::propagate):
- dfg/DFGBinarySwitch.cpp: Added.
(DFG):
(JSC::DFG::BinarySwitch::BinarySwitch):
(JSC::DFG::BinarySwitch::advance):
(JSC::DFG::BinarySwitch::build):
- dfg/DFGBinarySwitch.h: Added.
(DFG):
(BinarySwitch):
(JSC::DFG::BinarySwitch::caseIndex):
(JSC::DFG::BinarySwitch::caseValue):
(JSC::DFG::BinarySwitch::fallThrough):
(JSC::DFG::BinarySwitch::Case::Case):
(Case):
(JSC::DFG::BinarySwitch::Case::operator<):
(JSC::DFG::BinarySwitch::BranchCode::BranchCode):
(BranchCode):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGLazyJSValue.cpp:
(JSC::DFG::LazyJSValue::getValue):
(JSC::DFG::equalToStringImpl):
(DFG):
(JSC::DFG::LazyJSValue::strictEqual):
(JSC::DFG::LazyJSValue::dump):
- dfg/DFGLazyJSValue.h:
(JSC::DFG::LazyJSValue::knownStringImpl):
(LazyJSValue):
(JSC::DFG::LazyJSValue::stringImpl):
(JSC::DFG::LazyJSValue::switchLookupValue):
- dfg/DFGNode.cpp:
(WTF::printInternal):
- dfg/DFGNode.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitSwitchChar):
(JSC::DFG::SpeculativeJIT::StringSwitchCase::operator<):
(DFG):
(JSC::DFG::SpeculativeJIT::emitBinarySwitchStringRecurse):
(JSC::DFG::SpeculativeJIT::emitSwitchStringOnString):
(JSC::DFG::SpeculativeJIT::emitSwitchString):
(JSC::DFG::SpeculativeJIT::emitSwitch):
(JSC::DFG::SpeculativeJIT::addBranch):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::branch8):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::StringSwitchCase::StringSwitchCase):
(StringSwitchCase):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileSwitch):
- runtime/Options.h:
(JSC):
Source/WTF:
Reviewed by Sam Weinig.
Make it possible to compare a RefPtr<StringImpl> and a StringImpl* without
having to ref the StringImpl.
- wtf/text/StringHash.h:
(WTF::StringHash::equal):
LayoutTests:
Reviewed by Sam Weinig.
- fast/js/regress/script-tests/switch-string-basic-big-var.js: Added.
(foo):
(make):
- fast/js/regress/script-tests/switch-string-basic-big.js: Added.
(foo):
(make):
- fast/js/regress/script-tests/switch-string-basic-var.js: Added.
(foo):
(make):
- fast/js/regress/script-tests/switch-string-basic.js: Added.
(foo):
- fast/js/regress/script-tests/switch-string-big-length-tower-var.js: Added.
(foo):
- fast/js/regress/script-tests/switch-string-length-tower-var.js: Added.
(foo):
- fast/js/regress/script-tests/switch-string-length-tower.js: Added.
(foo):
- fast/js/regress/script-tests/switch-string-short.js: Added.
(foo):
- fast/js/regress/switch-string-basic-big-expected.txt: Added.
- fast/js/regress/switch-string-basic-big-var-expected.txt: Added.
- fast/js/regress/switch-string-basic-big-var.html: Added.
- fast/js/regress/switch-string-basic-big.html: Added.
- fast/js/regress/switch-string-basic-expected.txt: Added.
- fast/js/regress/switch-string-basic-var-expected.txt: Added.
- fast/js/regress/switch-string-basic-var.html: Added.
- fast/js/regress/switch-string-basic.html: Added.
- fast/js/regress/switch-string-big-length-tower-var-expected.txt: Added.
- fast/js/regress/switch-string-big-length-tower-var.html: Added.
- fast/js/regress/switch-string-length-tower-expected.txt: Added.
- fast/js/regress/switch-string-length-tower-var-expected.txt: Added.
- fast/js/regress/switch-string-length-tower-var.html: Added.
- fast/js/regress/switch-string-length-tower.html: Added.
- fast/js/regress/switch-string-short-expected.txt: Added.
- fast/js/regress/switch-string-short.html: Added.
- 8:48 PM Changeset in webkit [151978] by
-
- 12 edits in trunk/Source
JSString should remember AtomicString
https://bugs.webkit.org/show_bug.cgi?id=117386
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Added JSValue::toAtomicString and JSString::atomicString. These two functions allow WebCore to update
JSString's m_value to set isAtomic flag and avoid the AtomicStringTable lookups in subsequent attempts
to obtain the AtomicString of the same value.
- runtime/JSCJSValue.h:
- runtime/JSString.h:
(JSC::JSString::atomicString):
(JSC::JSValue::toAtomicString):
Source/WebCore:
Added "Atomic" attribute as a WebKit extension to WebIDL, and deployed it in Element.idl and Node.idl so that
the binding code can use newly added JSValue::toAtomic to update JSString's m_value.
- bindings/js/JSDOMBinding.cpp:
(WebCore::valueToAtomicStringWithNullCheck): Added.
(WebCore::valueToAtomicStringWithUndefinedOrNullCheck): Added.
- bindings/js/JSDOMBinding.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GetNativeTypeFromSignature): Return const AtomicString& when either Atomic attribute is specified or the type is
Reflect. Note that setAttribute and getAttribute both use AtomicString for all arguments.
(JSValueToNative): Use AtomicString equivalents when possible when converting DOMString to a WebCore object.
- bindings/scripts/IDLAttributes.txt: Added "Atomic" attribute.
- bindings/scripts/test/JS/JSTestObj.cpp: Baselined test cases.
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
- dom/Document.idl:
- dom/Element.idl:
- dom/Node.idl:
- 6:22 PM Changeset in webkit [151977] by
-
- 2 edits in branches/safari-537-branch/Source/WTF
Merged r151755. <rdar://problem/14209227>
- 6:09 PM Changeset in webkit [151976] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r151747. <rdar://problem/14187667>
- 6:06 PM Changeset in webkit [151975] by
-
- 14 edits in trunk/Source
Adopt is/toHTMLAnchorElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=117973
Reviewed by Andreas Kling.
To enhance readibility, this patch adopts is/toHTMLAnchorElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::anchorElement):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::internalLinkElement):
(WebCore::AccessibilityRenderObject::url):
(WebCore::AccessibilityRenderObject::stringValueForMSAA):
(WebCore::AccessibilityRenderObject::isLinked):
- css/CSSDefaultStyleSheets.cpp:
(WebCore::elementCanUseSimpleDefaultStyle):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- dom/Document.cpp:
(WebCore::Document::updateBaseURL):
- dom/TreeScope.cpp:
(WebCore::TreeScope::findAnchor):
- dom/VisitedLinkState.cpp:
(WebCore::linkHashForElement):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):
- html/HTMLAnchorElement.h:
(WebCore::isHTMLAnchorElement):
(WebCore::toHTMLAnchorElement):
- page/DragController.cpp:
(WebCore::DragController::draggableElement):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absoluteLinkURL):
(WebCore::HitTestResult::isLiveLink):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::getTextDecorationColors):
Source/WebKit/blackberry:
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
- 5:58 PM Changeset in webkit [151974] by
-
- 3 edits in branches/safari-537-branch/Source/JavaScriptCore
Merged r151786. <rdar://problem/14149317>
- 5:36 PM Changeset in webkit [151973] by
-
- 7 edits in branches/safari-537-branch/Source
Merged r151929. <rdar://problem/14250527>
- 5:30 PM Changeset in webkit [151972] by
-
- 4 edits in branches/safari-537-branch/Source/WebKit2
Merged r151760. <rdar://problem/14197983>
- 2:48 PM Changeset in webkit [151971] by
-
- 2 edits in trunk/Source/WebCore
Don't snapshot plug-ins that come from the same host as the page
https://bugs.webkit.org/show_bug.cgi?id=117969
<rdar://problem/12885400>
Reviewed by Tim Horton.
If a page is serving plug-in content directly, then that content
is typically very important to the page. For example, embedding
a video or audio player. In this case, don't snapshot the plug-ins.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Add a test
that compares the plug-in's URL against the main page's URL and don't snapshot
if they are the same.
- 11:18 AM Changeset in webkit [151970] by
-
- 2 edits in branches/safari-537-branch/Source/JavaScriptCore
Merged r151923. <rdar://problem/14250711>
- 11:17 AM Changeset in webkit [151969] by
-
- 2 edits in tags/Safari-537.46.6/Source/JavaScriptCore
Merged r151923. <rdar://problem/14250711>
- 11:15 AM Changeset in webkit [151968] by
-
- 5 edits in tags/Safari-537.46.6/Source
Versioning.
- 11:12 AM Changeset in webkit [151967] by
-
- 1 copy in tags/Safari-537.46.6
New Tag.
- 10:45 AM Changeset in webkit [151966] by
-
- 9 edits in trunk/Source/WebCore
Added PLATFORM(WIN) to many places where it was missing for compiling WebGL for Windows.
https://bugs.webkit.org/show_bug.cgi?id=117955
Reviewed by Brent Fulgham.
- platform/graphics/GraphicsContext3D.cpp:
- platform/graphics/OpenGLShims.cpp:
- platform/graphics/cairo/GraphicsContext3DCairo.cpp: Include new location of ShaderLang.h on Windows as of r151854.
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):
- platform/graphics/opengl/Extensions3DOpenGL.h:
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: Added PLATFORM(WIN) when necessary to each file.
- 9:16 AM Changeset in webkit [151965] by
-
- 3 edits1 move2 deletes in trunk/LayoutTests
[AX][ATK] Update accessibility baselines after r151953
https://bugs.webkit.org/show_bug.cgi?id=117983
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-06-25
Reviewed by Chris Fleizach.
Updating aria-option-role-expected.txt for EFL and GTK after the changes in aria-option-role.html test (r151953).
Moving platform aria-checkbox-text.html to LayoutTests/accessibility. Baseline is the same for mac, gtk, efl. Windows port has it's own specific version.
- accessibility/aria-checkbox-text-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-checkbox-text-expected.txt.
- platform/efl/accessibility/aria-checkbox-text-expected.txt: Removed.
- platform/efl/accessibility/aria-option-role-expected.txt:
- platform/gtk/accessibility/aria-checkbox-text-expected.txt: Removed.
- platform/gtk/accessibility/aria-option-role-expected.txt:
- 8:24 AM Changeset in webkit [151964] by
-
- 2 edits in trunk/Source/WebCore
Fixes a typo in renderTextDecorationFlagsToCSSValue
https://bugs.webkit.org/show_bug.cgi?id=117989
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2013-06-25
Reviewed by Gyuyoung Kim.
Return value should be PassRefPtr instead of RefPtr.
Backported from Blink:
https://src.chromium.org/viewvc/blink?view=rev&revision=152994
No new tests, no behavior change.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationFlagsToCSSValue):
- 6:09 AM Changeset in webkit [151963] by
-
- 2 edits in trunk/Tools
Unreviewed, change my email address for watch list.
- Scripts/webkitpy/common/config/watchlist:
- 5:57 AM Changeset in webkit [151962] by
-
- 2 edits in trunk/Source/WebCore
"application/x-mimearchive" should be included in finding remoteWebArchive while document loading
https://bugs.webkit.org/show_bug.cgi?id=117734
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-06-25
Reviewed by Alexey Proskuryakov.
"application/x-mimearchive" is also used while checking for
RemoteArchive.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::continueAfterContentPolicy):
- 5:23 AM WebKitGTK/StartHacking edited by
- (diff)
- 5:22 AM WebKitGTK/StartHacking edited by
- (diff)
- 5:09 AM WebKitEFLLayoutTest edited by
- Change the guide of layout test dependencies to use the install script. (diff)
- 5:04 AM EFLWebKit edited by
- Change the guide of base dependencies to use the install script. (diff)
- 4:35 AM Changeset in webkit [151961] by
-
- 1 edit1 add in trunk/Tools
[EFL] Add a script to install dependencies.
https://bugs.webkit.org/show_bug.cgi?id=117968
Reviewed by Christophe Dumez.
Add a script which installs basic dependencies for building WebKit EFL.
The dependencies are from the current EFLWebKit wiki page.
After this patch is landed, the wiki page will be updated to use
this script.
- efl/install-dependencies: Added.
- 3:57 AM Changeset in webkit [151960] by
-
- 2 edits in trunk/LayoutTests
[GTK] Add bug report into TestExpectations for fast/text/international/synthesized-italic-vertical-latin.html
https://bugs.webkit.org/show_bug.cgi?id=117976
Unreviewed gardening.
TestExpectations was missing a bug number for a skip test (http://webkit.org/b/117975).
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-06-25
- platform/gtk/TestExpectations:
- 2:17 AM Changeset in webkit [151959] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing inspector test.
- platform/qt/TestExpectations:
- 2:00 AM Changeset in webkit [151958] by
-
- 3 edits in trunk/Source/WebCore
HTMLMediaElement should inherit from MediaPlayerClient privately
https://bugs.webkit.org/show_bug.cgi?id=117874
Reviewed by Andreas Kling.
Fixing FIXME: HTMLMediaElement was stuck with public inheritance from
MediaPlayerClient due to the Chromium and Qt port.
The Qt port is changed to not cast from MediaPlayerClient to HTMLMediaElement.
- html/HTMLMediaElement.h:
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::commitLoad):
- 1:44 AM Changeset in webkit [151957] by
-
- 10 edits in trunk/Source/WebCore
Checking if frame is complete and access duration doesn't need a decode
https://bugs.webkit.org/show_bug.cgi?id=116041
Reviewed by Allan Sandfeld Jensen.
This change is to avoid image decoding for these two operations:
- frameIsCompleteAtIndex
- frameDurationAtIndex
These two operations are moved to ImageDecoder interface and are now const
to prevent future regression.
We are now able to check if a frame is complete by parsing the entire GIF file
without decoding. This also provides information like frame duration such that
controller the animation doesn't require any decoding.
Based on the Blink patch by Hin-Chung Lam <hclam@google.com>
https://src.chromium.org/viewvc/blink?revision=149883&view=revision
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::frameIsCompleteAtIndex):
(WebCore::BitmapImage::frameDurationAtIndex):
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::frameDurationAtIndex):
(WebCore::ImageSource::frameHasAlphaAtIndex):
(WebCore::ImageSource::frameIsCompleteAtIndex):
- platform/graphics/ImageSource.h:
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::frameHasAlphaAtIndex):
(WebCore::ImageDecoder::frameIsCompleteAtIndex):
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::frameDurationAtIndex):
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::frameIsCompleteAtIndex):
(WebCore::GIFImageDecoder::frameDurationAtIndex):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::gifComplete):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::initFrameBuffer):
- platform/image-decoders/gif/GIFImageDecoder.h:
- platform/image-decoders/gif/GIFImageReader.h:
(GIFImageReader::frameContext):
(GIFImageReader::parseCompleted):
