Context Navigation

← Previous Period
Next Period →

Timeline

Dec 9, 2013:

11:19 PM Changeset in webkit [160351] by msaboff@apple.com

5 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: ctiNativeCallFallback and friends should renamed ...NativeTailCall
https://bugs.webkit.org/show_bug.cgi?id=125485

Not yet reviewed.

Changed ctiNativeCallFallback to ctiNativeTailCall and nativeCallFallbackGenerator
to nativeTailCallGenerator to be more descriptive of what is happening.

jit/JITThunks.cpp:

(JSC::JITThunks::ctiNativeTailCall):

jit/JITThunks.h:
jit/ThunkGenerators.cpp:

(JSC::nativeTailCallGenerator):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):
(JSC::arrayIteratorNextThunkGenerator):

jit/ThunkGenerators.h:

10:54 PM Changeset in webkit [160350] by msaboff@apple.com

1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog

Fixed spelling errors in the ChangeLog entry for
CStack Branch: Fix baseline JIT for basic operation

9:57 PM Changeset in webkit [160349] by akling@apple.com

4 edits in trunk/Source/WebCore

Clear out font width measurement caches on memory pressure.
<https://webkit.org/b/125481>

The data kept in WidthCaches can be regenerated on demand. Throwing
it away when we're under memory pressure buys us ~4MB on Membuster3.

Reviewed by Antti Koivisto.

9:52 PM Changeset in webkit [160348] by fpizlo@apple.com

5 edits in trunk/Source/JavaScriptCore

Impose and enforce some basic rules of sanity for where Phi functions are allowed to occur and where their (optional) corresponding MovHints can be
https://bugs.webkit.org/show_bug.cgi?id=125480

Reviewed by Geoffrey Garen.

Previously, if you wanted to insert some speculation right after where a value was
produced, you'd get super confused if that value was produced by a Phi node. You can't
necessarily insert speculations after a Phi node because Phi nodes appear in this
special sequence of Phis and MovHints that establish the OSR exit state for a block.
So, you'd probably want to search for the next place where it's safe to insert things.
We already do this "search for beginning of next bytecode instruction" search by
looking at the next node that has a different CodeOrigin. But this would be hard for a
Phi because those Phis and MovHints have basically random CodeOrigins and they can all
have different CodeOrigins.

This change imposes some sanity for this situation:

Phis must have unset CodeOrigins.

In each basic block, all nodes that have unset CodeOrigins must come before all nodes that have set CodeOrigins.

This all ends up working out just great because prior to this change we didn't have a
use for unset CodeOrigins. I think it's appropriate to make "unset CodeOrigin" mean
that we're in the prologue of a basic block.

It's interesting what this means for block merging, which we don't yet do in SSA.
Consider merging the edge A->B. One possibility is that the block merger is now
required to clean up Phi/Upsilons, and reascribe the MovHints to have the CodeOrigin of
the A's block terminal. But an answer that might be better is that the originless
nodes at the top of the B are just given the origin of the terminal and we keep the
Phis. That would require changing the above rules. We'll see how it goes, and what we
end up picking...

Overall, this special-things-at-the-top rule is analogous to what other SSA-based
compilers do. For example, LLVM has rules mandating that Phis appear at the top of a
block.

bytecode/CodeOrigin.cpp:

(JSC::CodeOrigin::dump):

dfg/DFGOSRExitBase.h:

(JSC::DFG::OSRExitBase::OSRExitBase):

dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):

dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::validateSSA):

7:24 PM Changeset in webkit [160347] by fpizlo@apple.com

24 edits
5 adds in trunk/Source/JavaScriptCore

Reveal array bounds checks in DFG IR
https://bugs.webkit.org/show_bug.cgi?id=125253

Reviewed by Oliver Hunt and Mark Hahnenberg.

In SSA mode, this reveals array bounds checks and the load of array length in DFG IR,
making this a candidate for LICM.

This also fixes a long-standing performance bug where the JSObject slow paths would
always create contiguous storage, rather than type-specialized storage, when doing a
"storage creating" storage, like:

var o = {};
o[0] = 42;

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/ExitKind.cpp:

(JSC::exitKindToString):
(JSC::exitKindIsCountable):

bytecode/ExitKind.h:
dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

dfg/DFGArrayMode.cpp:

(JSC::DFG::permitsBoundsCheckLowering):
(JSC::DFG::ArrayMode::permitsBoundsCheckLowering):

dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::lengthNeedsStorage):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGNodeType.h:
dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSSALoweringPhase.cpp: Added.

(JSC::DFG::SSALoweringPhase::SSALoweringPhase):
(JSC::DFG::SSALoweringPhase::run):
(JSC::DFG::SSALoweringPhase::handleNode):
(JSC::DFG::SSALoweringPhase::lowerBoundsCheck):
(JSC::DFG::performSSALowering):

dfg/DFGSSALoweringPhase.h: Added.
dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileContiguousPutByVal):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCheckInBounds):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::LowerDFGToLLVM::contiguousPutByValOutOfBounds):

runtime/JSObject.cpp:

(JSC::JSObject::convertUndecidedForValue):
(JSC::JSObject::createInitialForValueAndSet):
(JSC::JSObject::putByIndexBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLength):

runtime/JSObject.h:
tests/stress/float32array-out-of-bounds.js: Added.

(make):
(foo):
(test):

tests/stress/int32-object-out-of-bounds.js: Added.

(make):
(foo):
(test):

tests/stress/int32-out-of-bounds.js: Added.

(foo):
(test):

6:08 PM Changeset in webkit [160346] by weinig@apple.com

6 edits
1 delete in trunk/Source/WTF

Remove FixedArray
https://bugs.webkit.org/show_bug.cgi?id=125478

Reviewed by Anders Carlsson.

GNUmakefile.list.am:
WTF.vcxproj/WTF.vcxproj:
WTF.vcxproj/WTF.vcxproj.filters:
WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/FixedArray.h: Removed.

5:47 PM Changeset in webkit [160345] by Seokju Kwon

2 edits in trunk/Source/WebCore

Web Inspector: Remove enabled() in InspectorRuntimeAgent.
https://bugs.webkit.org/show_bug.cgi?id=125476

Reviewed by Joseph Pecoraro.

Dead code. It's never called anywhere.

No new tests, no behavior change.

inspector/InspectorRuntimeAgent.h:

5:28 PM Changeset in webkit [160344] by weinig@apple.com

24 edits in trunk/Source

Replace use of WTF::FixedArray with std::array
https://bugs.webkit.org/show_bug.cgi?id=125475

Reviewed by Anders Carlsson.

../JavaScriptCore:

bytecode/CodeBlockHash.cpp:

(JSC::CodeBlockHash::dump):

bytecode/Opcode.cpp:

(JSC::OpcodeStats::~OpcodeStats):

dfg/DFGCSEPhase.cpp:
ftl/FTLAbstractHeap.h:
heap/MarkedSpace.h:
parser/ParserArena.h:
runtime/CodeCache.h:
runtime/DateInstanceCache.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

runtime/JSGlobalObject.h:
runtime/JSString.h:
runtime/LiteralParser.h:
runtime/NumericStrings.h:
runtime/RegExpCache.h:
runtime/SmallStrings.h:

../WebCore:

crypto/parameters/CryptoAlgorithmAesCbcParams.h:
platform/graphics/GlyphMetricsMap.h:

../WTF:

wtf/AVLTree.h:
wtf/Bitmap.h:
wtf/SixCharacterHash.cpp:

(WTF::integerToSixCharacterHashString):

wtf/SixCharacterHash.h:

4:37 PM Changeset in webkit [160343] by msaboff@apple.com

2 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: Change nativeForGenerator fallBack bool to an enum
https://bugs.webkit.org/show_bug.cgi?id=125473

Reviewed by Filip Pizlo.

Change the "bool fallBack" to an enum name ThunkEntryType with values
EnterViaCall and EnterViaJump to indicate how the thunk will be entered.

jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):
(JSC::nativeCallFallbackGenerator):

4:12 PM Changeset in webkit [160342] by timothy_horton@apple.com

1 edit
1 delete in trunk/Tools

Remove dead extract_reference_link.py (and the reftests module)
https://bugs.webkit.org/show_bug.cgi?id=125116

Reviewed by Ryosuke Niwa.

This code doesn't seem to have ever been used.

Scripts/webkitpy/layout_tests/reftests/init.py: Removed.
Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.

4:11 PM Changeset in webkit [160341] by andersca@apple.com

3 edits
6 adds in trunk/Source/WebKit2

Begin working on a UserData class intended to replace UserMessageCoders
https://bugs.webkit.org/show_bug.cgi?id=125471

Reviewed by Sam Weinig.

Shared/APIFrameHandle.cpp: Added.
Shared/APIFrameHandle.h: Added.

Add a new API::FrameHandle class that represents a frame.

Shared/APIObject.h:
Shared/APIPageHandle.cpp: Added.
Shared/APIPageHandle.h: Added.

Add a new API::PageHandle class that represents a page.

Shared/UserData.cpp: Added.

(WebKit::UserData::UserData):
(WebKit::UserData::~UserData):
(WebKit::UserData::encode):
(WebKit::UserData::decode):

Shared/UserData.h: Added.

Add a UserData class that can be encoded and decoded. This will be used for sending data

between the web process and UI process without doing any of the Page -> BundlePage etc conversions.

WebKit2.xcodeproj/project.pbxproj:

3:50 PM Changeset in webkit [160340] by msaboff@apple.com

12 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: Fix baseline JIT for basic operation
https://bugs.webkit.org/show_bug.cgi?id=125470

Not yet reviewed.

Fixed compileOpCall and it's slow case to properly adjust the stack pointer before
and after a call.

Cleaned up the calling convention in the various thunks. Adjusted the stack
pointer at the end of the arity fixup thunk to account for the frame moving.

Added ctiNativeCallFallback() thunk generator for when another thunk that can't
perform its operation inline needs to make a native call. This thunk generator
differes from ctiNativeCall() in that it doesn't emit a funciton prologue, thus
allowing the original thunk to jump to the "fallback" thunk. I'm open to another
name beside "fallback". Maybe "ctiNativeTailCall()".

Fixed the OSR entry handling in the LLInt prologue macro to properly account
for the callee saving the caller frame pointer.

Added stack alignement check function for use in debug builds to find and break
if the stack pointer is not appropriately aligned.

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::checkStackPointerAlignment):

jit/JIT.cpp:

(JSC::JIT::privateCompile):

jit/JIT.h:

(JSC::JIT::frameRegisterCountFor):

jit/JITCall.cpp:

(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_enter):

jit/JITThunks.cpp:

(JSC::JITThunks::ctiNativeCallFallback):

jit/JITThunks.h:
jit/ThunkGenerators.cpp:

(JSC::slowPathFor):
(JSC::nativeForGenerator):
(JSC::nativeCallFallbackGenerator):
(JSC::arityFixup):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):
(JSC::arrayIteratorNextThunkGenerator):

jit/ThunkGenerators.h:
llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter64.asm:

3:48 PM Changeset in webkit [160339] by Lucas Forschler

2 edits in tags/Safari-538.8.1/Source/WebKit/mac

Merge 160326 for <rdar://problem/15615561>.

3:45 PM Changeset in webkit [160338] by benjamin@webkit.org

7 edits
4 adds in trunk/Source/WebCore

Refactor the CFURLConnectionClient to be the synchronous implementation of an abstract network delegate
https://bugs.webkit.org/show_bug.cgi?id=125379

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-12-09
Reviewed by Alexey Proskuryakov.

WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
platform/network/ResourceHandle.h:
platform/network/ResourceHandleInternal.h:
platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):

platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp: Added.

(WebCore::ResourceHandleCFURLConnectionDelegate::ResourceHandleCFURLConnectionDelegate):
(WebCore::ResourceHandleCFURLConnectionDelegate::~ResourceHandleCFURLConnectionDelegate):
(WebCore::ResourceHandleCFURLConnectionDelegate::willSendRequestCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didReceiveResponseCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didReceiveDataCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didFinishLoadingCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didFailCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::willCacheResponseCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didReceiveChallengeCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didSendBodyDataCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::shouldUseCredentialStorageCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::canRespondToProtectionSpaceCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didReceiveDataArrayCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::makeConnectionClient):

platform/network/cf/ResourceHandleCFURLConnectionDelegate.h: Added.
platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp: Added.

(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::SynchronousResourceHandleCFURLConnectionDelegate):
(WebCore::synthesizeRedirectResponseIfNecessary):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::willSendRequest):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveData):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didFinishLoading):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didFail):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::willCacheResponse):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveChallenge):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didSendBodyData):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::shouldUseCredentialStorageCallback):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::canRespondToProtectionSpace):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveDataArray):

platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h: Added.

3:44 PM Changeset in webkit [160337] by rniwa@webkit.org

5 edits
1 delete in trunk

REGRESSION(r136280): input[type=image] should assume coords of 0,0 when activated without physically clicking
https://bugs.webkit.org/show_bug.cgi?id=125392

Reviewed by Darin Adler.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/3c33d42207cd209bb171083ba66c225f694f2101

Activating an image button with the keyboard or element.click() should result in selected coords of (0,0) per
http://www.w3.org/TR/2013/CR-html5-20130806/forms.html#image-button-state-(type=image)
"If the user activates the control without explicitly selecting a coordinate, then the coordinate (0,0) must be assumed."

New behavior also matches that of Internet Explorer and Firefox.

Tests: fast/forms/input-image-submit.html

html/ImageInputType.cpp:

(WebCore::ImageInputType::handleDOMActivateEvent): Set m_clickLocation to (0, 0) for simulated events.

LayoutTests:

fast/events/stopPropagation-submit-expected.txt:
fast/forms/input-image-submit.html:
platform/gtk/fast/events/stopPropagation-submit-expected.txt: Removed.

3:36 PM Changeset in webkit [160336] by jer.noble@apple.com

28 edits
5 adds in trunk

[MSE] Add support for VideoPlaybackMetrics.
https://bugs.webkit.org/show_bug.cgi?id=125380

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-video-playback-quality.html

Add a new object type VideoPlaybackQuality to be returned by
HTMLMediaElement.getVideoPlaybackQuality().

HTMLMediaElements must separately track a droppedVideoFrame count, as
certain operations on SourceBuffer will drop incoming frames, which must
be accounted for. Reset this count when the media engine changes, which is
indicitive of a new media load requset starting.

Add the new VideoPlaybackQuality class:

Modules/mediasource/VideoPlaybackQuality.cpp: Added.

(WebCore::VideoPlaybackQuality::create):
(WebCore::VideoPlaybackQuality::VideoPlaybackQuality):

Modules/mediasource/VideoPlaybackQuality.h: Added.

(WebCore::VideoPlaybackQuality::creationTime):
(WebCore::VideoPlaybackQuality::totalVideoFrames):
(WebCore::VideoPlaybackQuality::droppedVideoFrames):
(WebCore::VideoPlaybackQuality::corruptedVideoFrames):
(WebCore::VideoPlaybackQuality::totalFrameDelay):

Modules/mediasource/VideoPlaybackQuality.idl: Added.

Add support for the new class to HTMLMediaElement:

html/HTMLMediaElement.cpp:

(HTMLMediaElement::shouldUseVideoPluginProxy):
(HTMLMediaElement::getVideoPlaybackQuality):

html/HTMLMediaElement.h:
html/HTMLMediaElement.idl:

Report the video quality metrics from the MediaPlayer:

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::totalVideoFrames):
(WebCore::MediaPlayer::droppedVideoFrames):
(WebCore::MediaPlayer::corruptedVideoFrames):
(WebCore::MediaPlayer::totalFrameDelay):

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::totalVideoFrames):
(WebCore::MediaPlayerPrivateInterface::droppedVideoFrames):
(WebCore::MediaPlayerPrivateInterface::corruptedVideoFrames):
(WebCore::MediaPlayerPrivateInterface::totalFrameDelay):

Correctly report the dropped frame count:

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::TrackBuffer::TrackBuffer): needsRandomAccessFlag defaults to true.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Check the sync status of the incoming sample.
(WebCore::SourceBuffer::didDropSample): Notify the media element of a dropped frame.

Modules/mediasource/SourceBuffer.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(HTMLMediaElement::mediaPlayerEngineUpdated): Reset m_droppedFrameCount.
(HTMLMediaElement::getVideoPlaybackQuality): Return a new VideoPlaybackQuality object.

html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::incrementDroppedFrameCount): Simple incrementer.

platform/MediaSample.h:

(WebCore::MediaSample::isSync): Convenience function.
(WebCore::MediaSample::isNonDisplaying): Ditto.

Add support in the AVFoundation MediaSource Engine:

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::totalVideoFrames):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::droppedVideoFrames):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::corruptedVideoFrames):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::totalFrameDelay):

Add support in the Mock MediaSource Engine:

platform/mock/mediasource/MockBox.h:
platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::totalVideoFrames): Simple accessor.
(WebCore::MockMediaPlayerMediaSource::droppedVideoFrames): Ditto.
(WebCore::MockMediaPlayerMediaSource::corruptedVideoFrames): Ditto.
(WebCore::MockMediaPlayerMediaSource::totalFrameDelay): Ditto.

platform/mock/mediasource/MockMediaPlayerMediaSource.h:
platform/mock/mediasource/MockMediaSourcePrivate.cpp:

(WebCore::MockMediaSourcePrivate::MockMediaSourcePrivate):

platform/mock/mediasource/MockMediaSourcePrivate.h:
platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockSourceBufferPrivate::enqueueSample): Increment the frame counts based on

the incoming sample.

platform/mock/mediasource/MockSourceBufferPrivate.h:

Add the new files to the project:

bindings/gobject/GNUmakefile.am:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
GNUMakefile.list.am:
CMakeLists.txt:

LayoutTests:

media/media-source/media-source-video-playback-quality-expected.txt: Added.
media/media-source/media-source-video-playback-quality.html: Added.
media/media-source/mock-media-source.js:

(var):

3:27 PM Changeset in webkit [160335] by Simon Fraser

2 edits in trunk/Source/WebCore

Avoid divide by zero in scrollbar code, and protect against Obj-C exceptions
https://bugs.webkit.org/show_bug.cgi?id=125469
<rdar://problem/15535772>

Reviewed by Beth Dakin.

In ScrollbarThemeMac::setPaintCharacteristicsForScrollbar(), proportion could
end up as NaN if scrollbar->totalSize() were zero. Protect against that.

Also wrap functions that call into Objective-C with BEGIN_BLOCK_OBJC_EXCEPTIONS/
END_BLOCK_OBJC_EXCEPTIONS.

platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::ScrollbarThemeMac::setPaintCharacteristicsForScrollbar):
(WebCore::scrollbarPainterPaint):

3:27 PM Changeset in webkit [160334] by commit-queue@webkit.org

5 edits in trunk/Source/JavaScriptCore

Remove miscellaneous unnecessary build statements
https://bugs.webkit.org/show_bug.cgi?id=125466

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-09
Reviewed by Darin Adler.

DerivedSources.make:
JavaScriptCore.vcxproj/build-generated-files.sh:
JavaScriptCore.xcodeproj/project.pbxproj:
make-generated-sources.sh:

3:27 PM Changeset in webkit [160333] by Lucas Forschler

1 copy in tags/Safari-538.8.1

New Tag.

3:11 PM Changeset in webkit [160332] by fpizlo@apple.com

3 edits in trunk/WebKitLibraries

Unreviewed, update LLVM binary drops to r196830.

LLVMIncludesMountainLion.tar.bz2:
LLVMLibrariesMountainLion.tar.bz2:

2:38 PM Changeset in webkit [160331] by Lucas Forschler

5 edits in branches/safari-537.74-branch/Source

Versioning.

2:06 PM Changeset in webkit [160330] by rniwa@webkit.org

14 edits
6 adds in trunk

Implement Document.cloneNode()
https://bugs.webkit.org/show_bug.cgi?id=11646

Reviewed by Darin Adler.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/dc7879025e01d63be9fcf6a84ca6c9b8b5768a80

Implement the behavior specified in the current DOM4 working draft:
http://www.w3.org/TR/2013/WD-dom-20131107/#dom-node-clonenode

Tests: fast/dom/Document/clone-node.html

fast/dom/HTMLDocument/clone-node-quirks-mode.html
svg/custom/clone-node.html

dom/Document.cpp:

(WebCore::Document::cloneNode):
(WebCore::Document::cloneDocumentWithoutChildren):
(WebCore::Document::cloneDataFromDocument):

dom/Document.h:
html/HTMLDocument.cpp:

(WebCore::HTMLDocument::cloneDocumentWithoutChildren):

html/HTMLDocument.h:
svg/SVGDocument.cpp:

(WebCore::SVGDocument::cloneDocumentWithoutChildren):

svg/SVGDocument.h:

LayoutTests:

dom/xhtml/level3/core/documentgetinputencoding04-expected.txt:
dom/xhtml/level3/core/documentgetxmlencoding05-expected.txt:
dom/xhtml/level3/core/nodeisequalnode01-expected.txt:
dom/xhtml/level3/core/nodeisequalnode21-expected.txt:
dom/xhtml/level3/core/nodeisequalnode25-expected.txt:
dom/xhtml/level3/core/nodeisequalnode26-expected.txt:
fast/dom/Document/clone-node-expected.txt: Added.
fast/dom/Document/clone-node.html: Added.
fast/dom/HTMLDocument/clone-node-quirks-mode-expected.txt: Added.
fast/dom/HTMLDocument/clone-node-quirks-mode.html: Added.
svg/custom/clone-node-expected.txt: Added.
svg/custom/clone-node.html: Added.

2:04 PM Changeset in webkit [160329] by Lucas Forschler

1 copy in branches/safari-537.74-branch

New Branch.

2:02 PM Changeset in webkit [160328] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

CSE should work in SSA
https://bugs.webkit.org/show_bug.cgi?id=125430

Reviewed by Oliver Hunt and Mark Hahnenberg.

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::run):
(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

1:15 PM Changeset in webkit [160327] by akling@apple.com

2 edits in trunk/Source/WebCore

REGRESSION(r160260): Memory pressure signal causes web process to hang.
<https://webkit.org/b/125465>

Reviewed by Tim Horton.

This command caused all of my web processes to hang:

notifyutil -p org.WebKit.lowMemory

This only happens when the cache pruning code encounters a resource
using purgeable memory.

loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::pruneLiveResourcesToSize):

Grab the next CachedResource pointer before continuing the loop.

12:38 PM Changeset in webkit [160326] by weinig@apple.com

2 edits in trunk/Source/WebKit/mac

Fix the build of projects including <WebKit/WebUIDelegatePrivate.h>

Rubber-stamped by Dan Bernstein.

WebView/WebAllowDenyPolicyListener.h:

Use TARGET_OS_IPHONE rather than PLATFORM(IOS) in an exposed header.

12:20 PM Changeset in webkit [160325] by commit-queue@webkit.org

2 edits
1 delete in trunk/Source/JavaScriptCore

Remove docs/make-bytecode-docs.pl
https://bugs.webkit.org/show_bug.cgi?id=125462

This sript is very old and no longer outputs useful data since the
op code definitions have moved from Interpreter.cpp.

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-09
Reviewed by Darin Adler.

DerivedSources.make:
docs/make-bytecode-docs.pl: Removed.

12:17 PM Changeset in webkit [160324] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[WinCairo] OpenGL compile error.
https://bugs.webkit.org/show_bug.cgi?id=125383

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-12-09
Reviewed by Darin Adler.

platform/graphics/opengl/Extensions3DOpenGLES.h: Define GL_HALF_FLOAT_ARB on Windows when OPENGL_ES_2 is used.

12:16 PM Changeset in webkit [160323] by mario.prada@samsung.com

22 edits in trunk

[ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
https://bugs.webkit.org/show_bug.cgi?id=125456

Reviewed by Chris Fleizach.

Tools:

Return 'AXSection' for section roles instead of 'AXDiv'.

DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

Update expectations for GTK and EFL that were expecting AXDiv for
section roles, so they now expect AXSection.

accessibility/adjacent-continuations-cause-assertion-failure-expected.txt:
accessibility/div-within-anchors-causes-crash-expected.txt:
platform/efl-wk1/accessibility/image-map2-expected.txt:
platform/efl-wk1/accessibility/transformed-element-expected.txt:
platform/efl-wk2/accessibility/image-map2-expected.txt:
platform/efl-wk2/accessibility/transformed-element-expected.txt:
platform/efl/accessibility/media-emits-object-replacement-expected.txt:
platform/gtk/accessibility/aria-roles-unignored-expected.txt:
platform/gtk/accessibility/aria-roles-unignored.html:
platform/gtk/accessibility/entry-and-password-expected.txt:
platform/gtk/accessibility/image-map2-expected.txt:
platform/gtk/accessibility/media-emits-object-replacement-expected.txt:
platform/gtk/accessibility/object-with-title-expected.txt:
platform/gtk/accessibility/object-with-title.html:
platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:
platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt:
platform/gtk/accessibility/spans-paragraphs-and-divs.html:
platform/gtk/accessibility/transformed-element-expected.txt:

11:45 AM Changeset in webkit [160322] by commit-queue@webkit.org

12 edits in trunk

Fix handling of 'inherit' and 'initial' for grid lines.
https://bugs.webkit.org/show_bug.cgi?id=125223

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-12-09
Reviewed by Darin Adler.

'initial' and 'inherit' are always allowed values for CSS properties.
As the CSSParser handles them automatically, those 2 values were never
taken care of in StyleResolver, leading to crashes.

Source/WebCore:

Added tests cases for 'inherit' and 'initial' to the following tests:

fast/css-grid-layout/grid-item-column-row-get-set.html
fast/css-grid-layout/grid-item-end-after-get-set.html
fast/css-grid-layout/grid-item-start-before-get-set.html

Patch backported from Blink: https://src.chromium.org/viewvc/blink?revision=149257&view=revision

css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

rendering/style/RenderStyle.h:
rendering/style/StyleGridItemData.cpp:

(WebCore::StyleGridItemData::StyleGridItemData):

LayoutTests:

Patch backported from Blink: https://src.chromium.org/viewvc/blink?revision=149257&view=revision

fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
fast/css-grid-layout/grid-item-column-row-get-set.html:
fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
fast/css-grid-layout/grid-item-end-after-get-set.html:
fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
fast/css-grid-layout/grid-item-start-before-get-set.html:
fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js:

11:30 AM Changeset in webkit [160321] by ryuan.choi@samsung.com

6 edits in trunk/Source/WebKit2

[EFL][WK2] LayoutTests are broken after r160301
https://bugs.webkit.org/show_bug.cgi?id=125447

Reviewed by Darin Adler.

r160301 moved FullScreenManagerProxyClient logic to WebViewEfl, child class
of CoordinatedGraphics::WebView, because implementations are EFL specific.
However, CoordinatedGraphics::WebView creates WebPageProxy in constructor and
WebPageProxy requires FullScreenManagerProxyClient in constructor.
So, All WK2/Efl based applications got crashed

This patch adds virtual methods for FullScreenManagerProxyClient to CoordinatedGraphics::WebView
so that WebPageProxy can get FullScreenManagerProxyClient instance without
pure viertual methods.

UIProcess/API/C/CoordinatedGraphics/WKView.cpp:

(WKViewExitFullScreen):

UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::fullScreenManagerProxyClient):
(WebKit::WebView::requestExitFullScreen):
renamed from exitFullScreen not to conflict with methods of FullScreenManagerProxyClient.

UIProcess/CoordinatedGraphics/WebView.h:
UIProcess/efl/WebViewEfl.cpp:
UIProcess/efl/WebViewEfl.h:

11:21 AM Changeset in webkit [160320] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Web Inspector: Inspector.json and CodeGenerator tweaks
https://bugs.webkit.org/show_bug.cgi?id=125321

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-09
Reviewed by Timothy Hatcher.

inspector/protocol/Runtime.json:

Runtime.js was depending on Network.FrameId. This is a layering
violation, so ideally we can fix this later. For now, just copy
the FrameId type into Runtime. They are strings so all is good.

inspector/CodeGeneratorInspector.py:

(Generator.EventMethodStructTemplate.append_epilog):

inspector/CodeGeneratorInspectorStrings.py:

Improve --help usage information.
Make the script work with a single domain json file.
Add ASCIILiteral's where appropriate.

11:01 AM Changeset in webkit [160319] by commit-queue@webkit.org

3 edits in trunk/Tools

check-webkit-style should check for extra newlines at EOF
https://bugs.webkit.org/show_bug.cgi?id=125424

Patch by Brian J. Burg <Brian Burg> on 2013-12-09
Reviewed by Darin Adler.

Report a style violation if extraneous newlines are added
to the end of a C++ file. There should only be one newline at EOF.

Scripts/webkitpy/style/checkers/cpp.py:

(check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
(check_for_extra_new_line_at_eof): Added.
(_process_lines): Added new check and renamed existing EOF check.

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_extra_newlines_at_eof): Added.
(CppStyleTest.test_extra_newlines_at_eof.do_test): Added.

10:57 AM Changeset in webkit [160318] by commit-queue@webkit.org

3 edits in trunk/Tools

check-webkit-style: ternary operator in macro call identified as initialization list
https://bugs.webkit.org/show_bug.cgi?id=125443

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-12-09
Reviewed by Ryosuke Niwa.

Do not match initialization list when questionmark is placed before :

Scripts/webkitpy/style/checkers/cpp.py:

(check_member_initialization_list):

10:51 AM Changeset in webkit [160317] by rniwa@webkit.org

1 edit
4 adds in trunk/LayoutTests

Add a test for style sharing if grandparents matches different rule chain and nth-last child
https://bugs.webkit.org/show_bug.cgi?id=125397

Reviewed by Darin Adler.

Add the test from https://chromium.googlesource.com/chromium/blink/+/30ff49bf63cdec31070ab4eda8784564f56789d4
and https://chromium.googlesource.com/chromium/blink/+/3cb1724bb52f3607006ddd0a89d356da23766115
so that we may not introduce the same regressions in WebKit.

fast/css/nth-last-child-recalc-expected.html: Added.
fast/css/nth-last-child-recalc.html: Added.
fast/css/style-sharing-grand-parent-invalidate-expected.txt: Added.
fast/css/style-sharing-grand-parent-invalidate.html: Added.

10:40 AM Changeset in webkit [160316] by jdiggs@igalia.com

11 edits
16 adds in trunk

AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
https://bugs.webkit.org/show_bug.cgi?id=125451

Reviewed by Mario Sanchez Prada.

Source/WebKit/gtk:

tests/testatk.c: Remove the tests which now exist as layout tests. Note that the

tests for atk_text_get_text_{before,after}_offset were removed without equivalents
added to the layout tests. The same is true for the END AtkTextBoundary types. Both
have been deprecated in ATK and are not being used by AT-SPI2 assistive technologies.
(testGetTextFunction):
(main):

Tools:

Create the needed callbacks for DRT and WKTR.

DumpRenderTree/AccessibilityUIElement.cpp:

(characterAtOffsetCallback): added
(wordAtOffsetCallback): added
(lineAtOffsetCallback): added
(sentenceAtOffsetCallback): added
(AccessibilityUIElement::getJSClass):

DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(stringAtOffset): added
(AccessibilityUIElement::characterAtOffset): added
(AccessibilityUIElement::wordAtOffset): added
(AccessibilityUIElement::lineAtOffset): added
(AccessibilityUIElement::sentenceAtOffset): added

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::characterAtOffset): added
(WTR::AccessibilityUIElement::wordAtOffset): added
(WTR::AccessibilityUIElement::lineAtOffset): added
(WTR::AccessibilityUIElement::sentenceAtOffset): added

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::stringAtOffset): added
(WTR::AccessibilityUIElement::characterAtOffset): added
(WTR::AccessibilityUIElement::wordAtOffset): added
(WTR::AccessibilityUIElement::lineAtOffset): added
(WTR::AccessibilityUIElement::sentenceAtOffset): added

LayoutTests:

New tests and expectations based on the tests and expectations found in atktest.c.
These were done as platform-specific tests because only ATK-based assistive technologies
seem to have any need for this support.

platform/gtk/accessibility/text-at-offset-embedded-objects-expected.txt: Added.
platform/gtk/accessibility/text-at-offset-embedded-objects.html: Added.
platform/gtk/accessibility/text-at-offset-newlines-expected.txt: Added.
platform/gtk/accessibility/text-at-offset-newlines.html: Added.
platform/gtk/accessibility/text-at-offset-preformatted-expected.txt: Added.
platform/gtk/accessibility/text-at-offset-preformatted.html: Added.
platform/gtk/accessibility/text-at-offset-simple-expected.txt: Added.
platform/gtk/accessibility/text-at-offset-simple.html: Added.
platform/gtk/accessibility/text-at-offset-special-chars-expected.txt: Added.
platform/gtk/accessibility/text-at-offset-special-chars.html: Added.
platform/gtk/accessibility/text-at-offset-textarea-expected.txt: Added.
platform/gtk/accessibility/text-at-offset-textarea.html: Added.
platform/gtk/accessibility/text-at-offset-textinput-expected.txt: Added.
platform/gtk/accessibility/text-at-offset-textinput.html: Added.
platform/gtk/accessibility/text-at-offset-wrapped-lines-expected.txt: Added.
platform/gtk/accessibility/text-at-offset-wrapped-lines.html: Added.

10:36 AM Changeset in webkit [160315] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Fix sh4 LLINT build.
https://bugs.webkit.org/show_bug.cgi?id=125454

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-12-09
Reviewed by Michael Saboff.

In LLINT, sh4 backend implementation didn't handle properly conditional jumps using
a LabelReference instance. This patch fixes it through sh4LowerMisplacedLabels phase.
Also, to avoid the need of a 4th temporary gpr, this phase is triggered later in
getModifiedListSH4.

offlineasm/sh4.rb:

10:30 AM Changeset in webkit [160314] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Nix] Fix file name typo in PlatformNix.cmake
https://bugs.webkit.org/show_bug.cgi?id=125457

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-09
Reviewed by Gustavo Noronha Silva.

Wrong file name introduced in http://trac.webkit.org/changeset/160310.

PlatformNix.cmake:

10:30 AM Changeset in webkit [160313] by Michał Pakuła vel Rutka

8 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add failure test expectations and rebaselines for failing tests.

platform/efl-wk2/TestExpectations:
platform/efl/TestExpectations:
platform/efl-wk1/fast/forms/validation-message-appearance-expected.png: Rebaseline after r159915.
platform/efl-wk2/fast/forms/validation-message-appearance-expected.png: Ditto.
platform/efl/fast/forms/validation-message-appearance-expected.txt: Ditto.
platform/efl/fast/parser/entity-comment-in-textarea-expected.png: Rebaseline after r159192.
platform/efl/fast/parser/entity-comment-in-textarea-expected.txt: Ditto.

8:18 AM Changeset in webkit [160312] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GStreamer] Memory leak due to incorrect use of gst_tag_list_merge in TextCombinerGStreamer
https://bugs.webkit.org/show_bug.cgi?id=125452

Patch by Brendan Long <b.long@cablelabs.com> on 2013-12-09
Reviewed by Philippe Normand.

No new tests because this fixes a memory leak.

platform/graphics/gstreamer/TextCombinerGStreamer.cpp:

(webkitTextCombinerPadEvent): Use gst_tag_list_insert instead of gst_tag_list_merge, since we don't want to create a new list.

6:17 AM Changeset in webkit [160311] by Chris Fleizach

4 edits
2 adds in trunk

AX: WebKit ignores @alt on IMG elements with role="text"
https://bugs.webkit.org/show_bug.cgi?id=125363

Reviewed by Mario Sanchez Prada.

Source/WebCore:

If an <img> element has a different role, the alt attribute should still be used in the
name calculation if present.

Test: accessibility/alt-tag-on-image-with-nonimage-role.html

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::usesAltTagForTextComputation):
(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::accessibilityDescription):
(WebCore::AccessibilityNodeObject::text):

accessibility/AccessibilityNodeObject.h:

LayoutTests:

accessibility/alt-tag-on-image-with-nonimage-role-expected.txt: Added.
accessibility/alt-tag-on-image-with-nonimage-role.html: Added.

6:10 AM Changeset in webkit [160310] by Martin Robinson

14 edits
2 adds in trunk/Source

[WK2][Soup] Use didReceiveBuffer instead of didReceiveData
https://bugs.webkit.org/show_bug.cgi?id=118598

Reviewed by Gustavo Noronha Silva.

Original patch by Kwang Yul Seo <skyul@company100.net> and Csaba OsztrogonÃ¡c <Csaba Osztrogonác>.

Switch from using didReceiveData to didReceiveBuffer for the Soup backend and
let SharedBuffer wrap a SoupBuffer. This is necessary because the NetworkProcess
only supports getting data via SharedBuffer.

Source/WebCore:

GNUmakefile.list.am: Add the new SharedBufferSoup.cpp file to the list.
PlatformEfl.cmake:
PlatformGTK.cmake:
PlatformNix.cmake:
platform/SharedBuffer.cpp: We no longer used the no-op version of the platformFoo methods.
platform/SharedBuffer.h: Ditto.
platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: Use didReceiveBuffer instead of didReceiveData.
platform/network/ResourceHandleInternal.h: Have only a m_soupBuffer member instead of three to manage the buffer.
platform/network/soup/GOwnPtrSoup.cpp: Add support for SoupBuffer.
platform/network/soup/GOwnPtrSoup.h: Ditto.
platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::WebCoreSynchronousLoader::didReceiveData): ASSERT_NOT_REACHED here, since it should never be
called now.
(WebCore::WebCoreSynchronousLoader::didReceiveBuffer): Handle this call properly.
(WebCore::ResourceHandle::ensureReadBuffer): Now we package up our buffer into a SoupBuffer.
(WebCore::redirectSkipCallback): Use the new m_soupBuffer member.
(WebCore::cleanupSoupRequestOperation): Ditto.
(WebCore::nextMultipartResponsePartCallback): Ditto.
(WebCore::sendRequestCallback): Ditto.
(WebCore::readCallback):

platform/soup/SharedBufferSoup.cpp: Added.

Source/WebKit/gtk:

webkit/webkitdownload.cpp:

(DownloadClient::didReceiveData): Replace with ASSERT_NOT_REACHED.
(DownloadClient::didReceiveBuffer): Use this to process incoming data.

4:42 AM Changeset in webkit [160309] by commit-queue@webkit.org

5 edits
2 adds in trunk

Source/WebCore: DataCloneError exception is not thrown when postMessage's second parameter is the source
port or the target port.

https://bugs.webkit.org/show_bug.cgi?id=124708

Patch by Michal Poteralski <m.poteralski@samsung.com> on 2013-12-09
Reviewed by Alexey Proskuryakov.

According to specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/web-messaging.html#dom-window-postmessage

If the method was invoked with a second argument transfer then if any of the objects in the
transfer are either the source port or the target port (if any), then a DataCloneError
exception should be thrown. Currently an InvalidStateError exception is thrown what is an
incorrect behaviour.

The proposed solution is change to the correct the exception value.

Tests: fast/dom/Window/postMessage-clone-port-error.html

dom/MessagePort.cpp:

(WebCore::MessagePort::postMessage): Improve exception value

LayoutTests: DataCloneError exception is not thrown when postMessage's second parameter
is the source port or the target port.

https://bugs.webkit.org/show_bug.cgi?id=124708

Patch by Michal Poteralski <m.poteralski@samsung.com> on 2013-12-09
Reviewed by Alexey Proskuryakov.

Added layout test to check correctness of value thrown by postMessage:

fast/dom/Window/postMessage-clone-port-error-expected.txt: Added.
fast/dom/Window/postMessage-clone-port-error.html: Added.

4:28 AM Changeset in webkit [160308] by svillar@igalia.com

7 edits in trunk/Source/WebKit2

[WK2] Add UNIX_DOMAIN_SOCKETS specific bits for supporting NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=110093

Reviewed by Martin Robinson.

Original patch by Balazs Kelemen <kbalazs@webkit.org>.

Adds the UNIX specific bits to support connections to the
NetworkProcess. Since the process of creating the pair of sockets
is exactly the same as in the PluginProcess, I've decided to
refactor it in ConnectionUnix::createPlatformConnection(). This
can be reused later to create a cross-platform solution and remove
all the ifdefs (see bug 110978).

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):

Platform/CoreIPC/Connection.h:
Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::createPlatformConnection):

PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::createWebProcessConnection):

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::networkProcessCrashedOrFailedToLaunch):
(WebKit::NetworkProcessProxy::didCreateNetworkConnectionToWebProcess):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensureNetworkProcessConnection):

4:06 AM Changeset in webkit [160307] by kseo@webkit.org

4 edits in trunk/Source/WebKit2

[WK2][Soup] Support cache model in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=118343

Reviewed by Carlos Garcia Campos.

Original patch by Kwang Yul Seo <skyul@company100.net> and Csaba Osztrogonác <Csaba Osztrogonác>.

Copied cache model code from WebProcess.
NetworkProcess is configured not to use the WebCore memory cache.

NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::getCacheDiskFreeSize):
(WebKit::getMemorySize):
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
Initialize soup cache.
(WebKit::NetworkProcess::platformSetCacheModel):
Copied code from WebProcess::platformSetCacheModel but removed
WebCore memory cache initialization because NetworkProcess does not use
the WebCore memory cache.
(WebKit::NetworkProcess::clearCacheForAllOrigins):
Copied code from WebProcess::clearCacheForAllOrigins.

NetworkProcess/unix/NetworkProcessMainUnix.cpp:

Copied initialization code from WebProcessMainGtk.cpp.
(WebKit::NetworkProcessMain):

WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformSetCacheModel):
Don't set the disk cache if NetworkProcess is used.
(WebKit::WebProcess::platformClearResourceCaches):
Don't clear the non-existing disk cache. (if NetworkProcess is used)
(WebKit::WebProcess::platformInitializeWebProcess):
Don't initialize the disk cache if NetworkProcess is used.

3:49 AM Changeset in webkit [160306] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

Unreviewed. Fix the GTK+ build with NetworkProcess enabled.

GNUmakefile.list.am: Add missing file to compilation.

3:45 AM Changeset in webkit [160305] by Gustavo Noronha Silva

3 edits in trunk/LayoutTests

accessibility/press-targets-center-point.html should not depend on font layout
https://bugs.webkit.org/show_bug.cgi?id=125387

Reviewed by Chris Fleizach.

accessibility/press-targets-center-point.html: use explicit sizes for heights (and width

for vertical writing mode), so that font layout does not alter the results.

platform/gtk/TestExpectations: remove failure expectation for accessibility/press-targets-center-point.html

1:55 AM Changeset in webkit [160304] by Gustavo Noronha Silva

2 edits in trunk/Source/WebKit2

[GTK] run-webkit-tests may DOS the system, specially in debug builds
https://bugs.webkit.org/show_bug.cgi?id=125436

Reviewed by Martin Robinson.

GNUmakefile.am: use -no-fast-install for WebKitWebProcess and WebKitPluginProcess so

they do not need to be relinked the first time they are executed in-tree.

1:54 AM Changeset in webkit [160303] by zandobersek@gmail.com

5 edits
1 delete in trunk/Source/WebKit2

[GTK][WK2] Move WebFullScreenManagerProxyGtk logic to PageClientImpl
https://bugs.webkit.org/show_bug.cgi?id=125440

Reviewed by Martin Robinson.

Make PageClientImpl a WebFullScreenManagerProxyClient. This brings the GTK port in line
with changes in r160296 and fixes the WK2 build for that port.

GNUmakefile.list.am:
UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::fullScreenManagerProxyClient):
(WebKit::PageClientImpl::closeFullScreenManager):
(WebKit::PageClientImpl::isFullScreen):
(WebKit::PageClientImpl::enterFullScreen):
(WebKit::PageClientImpl::exitFullScreen):
(WebKit::PageClientImpl::beganEnterFullScreen):
(WebKit::PageClientImpl::beganExitFullScreen):

UIProcess/API/gtk/PageClientImpl.h:
UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreateWebPage):

UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:

1:37 AM Changeset in webkit [160302] by commit-queue@webkit.org

8 edits in trunk

[WK2][Gtk] Add support for ENABLE_NETWORK_PROCESS to the build system
https://bugs.webkit.org/show_bug.cgi?id=118231

Patch by Brian Holt <brian.holt@samsung.com> on 2013-12-09
Reviewed by Martin Robinson.

Original patch by Kwang Yul Seo <skyul@company100.net>.

Disabled ENABLE_NETWORK_PROCESS by default.

Source/autotools/SetupAutomake.m4:
Source/autotools/SetupWebKitFeatures.m4:

Source/WebKit2:

Add source files to the build system and build NetworkProcess executable.

GNUmakefile.am:
GNUmakefile.list.am:
NetworkProcess/unix/NetworkProcessMainUnix.cpp:
UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

Dec 8, 2013:

11:46 PM Changeset in webkit [160301] by ryuan.choi@samsung.com

6 edits
1 delete in trunk/Source/WebKit2

[EFL][WK2] Move FullScreenManager logic to WebViewEfl
https://bugs.webkit.org/show_bug.cgi?id=125438

Reviewed by Gyuyoung Kim.

This patch fixed build break on EFL port Since r160296.

PlatformEfl.cmake: Removed WebFullScreenManagerProxyEfl.cpp.
UIProcess/WebFullScreenManagerProxy.cpp: Removed EFL specific code.

(WebKit::WebFullScreenManagerProxy::WebFullScreenManagerProxy):

UIProcess/WebFullScreenManagerProxy.h: Ditto.
UIProcess/efl/WebFullScreenManagerProxyEfl.cpp: Removed file and moved logic to WebViewEfl.
UIProcess/efl/WebViewEfl.cpp:

(WebKit::WebViewEfl::WebViewEfl):
(WebKit::WebViewEfl::setEwkView): Removed call to setWebView().
(WebKit::WebViewEfl::fullScreenManagerProxyClient):
(WebKit::WebViewEfl::isFullScreen):
(WebKit::WebViewEfl::enterFullScreen):
(WebKit::WebViewEfl::exitFullScreen):

UIProcess/efl/WebViewEfl.h:

9:44 PM Changeset in webkit [160300] by weinig@apple.com

4 edits in trunk/Source/WebKit2

Remove WebContext::sharedProcessContext()
https://bugs.webkit.org/show_bug.cgi?id=125437

Reviewed by Dan Bernstein.

UIProcess/API/ios/WKGeolocationProviderIOS.mm:
UIProcess/WebContext.cpp:
UIProcess/WebContext.h:

9:13 PM Changeset in webkit [160299] by rniwa@webkit.org

5 edits in trunk

getComputedStyle border-radius shorthand omits vertical radius information
https://bugs.webkit.org/show_bug.cgi?id=125394

Reviewed by Andreas Kling.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/4c2866855dddbb28bb7d978ad627acc368af23d0

getComputedStyle of border-radius shows the vertical radius components if they differ from their horizontal counterpants.
We were incorrectly detecting this case and over simplifying the results of getComputedStyle.
This patch ensures we only hide the vertical values if they are identical to the horizontal values.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::getBorderRadiusShorthandValue):

LayoutTests:

fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand-expected.txt:
fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand.html:

8:51 PM Changeset in webkit [160298] by weinig@apple.com

3 edits in trunk/Tools

32-bit MiniBrowser doesn't build
https://bugs.webkit.org/show_bug.cgi?id=125420

Reviewed by Dan Bernstein.

MiniBrowser/mac/AppDelegate.h:
MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate applicationWillTerminate:]):

8:23 PM Changeset in webkit [160297] by weinig@apple.com

3 edits
1 delete in trunk/Source/WebKit2

Fix the iOS build.

UIProcess/API/ios/PageClientImplIOS.h:
UIProcess/API/ios/PageClientImplIOS.mm:
UIProcess/ios/WebFullScreenManagerProxyIOS.mm: Removed.

8:11 PM Changeset in webkit [160296] by weinig@apple.com

11 edits
1 delete in trunk/Source/WebKit2

[Cocoa] Remove knowledge of the WKView from the WebFullScreenManagerProxy by adding a proper client
https://bugs.webkit.org/show_bug.cgi?id=125427

Reviewed by Dan Bernstein.

UIProcess/API/mac/PageClientImpl.h:
UIProcess/API/mac/PageClientImpl.mm:

UIProcess/API/mac/WKView.mm:

Remove call to setWebView() and do some cleanup.

UIProcess/API/mac/WKViewInternal.h:

Convert to property syntax and re-arrange.

UIProcess/PageClient.h:

Expose access to the new client.

UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::create):
(WebKit::WebFullScreenManagerProxy::WebFullScreenManagerProxy):
(WebKit::WebFullScreenManagerProxy::invalidate):
(WebKit::WebFullScreenManagerProxy::close):
(WebKit::WebFullScreenManagerProxy::isFullScreen):
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):

UIProcess/WebFullScreenManagerProxy.h:

Use the new client.

UIProcess/WebPageProxy.cpp:

Pass the new client.

UIProcess/mac/WebFullScreenManagerProxyMac.mm:

Removed. Now goes through the client.

WebKit2.xcodeproj/project.pbxproj:

Remove WebFullScreenManagerProxyMac.mm.

5:08 PM Changeset in webkit [160295] by fpizlo@apple.com

17 edits in trunk/Source/JavaScriptCore

Add the notion of ConstantStoragePointer to DFG IR
https://bugs.webkit.org/show_bug.cgi?id=125395

Reviewed by Oliver Hunt.

This pushes more typed array folding into StrengthReductionPhase, and enables CSE on
storage pointers. Previously, you might have separate nodes for the same storage
pointer and this would cause some bad register pressure in the DFG. Note that this
was really a theoretical problem and not, to my knowledge a practical one - so this
patch is basically just a clean-up.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::constantStoragePointerCSE):
(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGNode.h:

(JSC::DFG::Node::convertToConstantStoragePointer):
(JSC::DFG::Node::hasStoragePointer):
(JSC::DFG::Node::storagePointer):

dfg/DFGNodeType.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileConstantStoragePointer):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):
(JSC::DFG::StrengthReductionPhase::foldTypedArrayPropertyToConstant):
(JSC::DFG::StrengthReductionPhase::prepareToFoldTypedArray):

dfg/DFGWatchpointCollectionPhase.cpp:

(JSC::DFG::WatchpointCollectionPhase::handle):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileConstantStoragePointer):
(JSC::FTL::LowerDFGToLLVM::compileGetIndexedPropertyStorage):

5:06 PM Changeset in webkit [160294] by fpizlo@apple.com

6 edits
2 adds in trunk/Source/JavaScriptCore

FTL should support UntypedUse versions of Compare nodes
https://bugs.webkit.org/show_bug.cgi?id=125426

Reviewed by Oliver Hunt.

This adds UntypedUse versions of all comparisons except CompareStrictEq, which is
sufficiently different that I thought I'd do it in another patch.

This also extends our ability to abstract over comparison kind and removes a bunch of
copy-paste code.

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLIntrinsicRepository.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(JSC::FTL::LowerDFGToLLVM::compileCompareLessEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreater):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreaterEq):
(JSC::FTL::LowerDFGToLLVM::compare):
(JSC::FTL::LowerDFGToLLVM::nonSpeculativeCompare):

ftl/FTLOutput.h:

(JSC::FTL::Output::icmp):
(JSC::FTL::Output::equal):
(JSC::FTL::Output::notEqual):
(JSC::FTL::Output::above):
(JSC::FTL::Output::aboveOrEqual):
(JSC::FTL::Output::below):
(JSC::FTL::Output::belowOrEqual):
(JSC::FTL::Output::greaterThan):
(JSC::FTL::Output::greaterThanOrEqual):
(JSC::FTL::Output::lessThan):
(JSC::FTL::Output::lessThanOrEqual):
(JSC::FTL::Output::fcmp):
(JSC::FTL::Output::doubleEqual):
(JSC::FTL::Output::doubleNotEqualOrUnordered):
(JSC::FTL::Output::doubleLessThan):
(JSC::FTL::Output::doubleLessThanOrEqual):
(JSC::FTL::Output::doubleGreaterThan):
(JSC::FTL::Output::doubleGreaterThanOrEqual):
(JSC::FTL::Output::doubleEqualOrUnordered):
(JSC::FTL::Output::doubleNotEqual):
(JSC::FTL::Output::doubleLessThanOrUnordered):
(JSC::FTL::Output::doubleLessThanOrEqualOrUnordered):
(JSC::FTL::Output::doubleGreaterThanOrUnordered):
(JSC::FTL::Output::doubleGreaterThanOrEqualOrUnordered):

tests/stress/untyped-equality.js: Added.

(foo):

tests/stress/untyped-less-than.js: Added.

(foo):

12:09 PM Changeset in webkit [160293] by commit-queue@webkit.org

2 edits in trunk/Tools

[WK2] Add ENABLE_NETWORK_PROCESS flag
https://bugs.webkit.org/show_bug.cgi?id=125421

Add support to build with the Network Process enabled.

Patch by Brian Holt <brian.holt@samsung.com> on 2013-12-08
Reviewed by Martin Robinson.

Scripts/webkitperl/FeatureList.pm:

11:01 AM Changeset in webkit [160292] by fpizlo@apple.com

25 edits
4 adds in trunk

Fold typedArray.length if typedArray is constant
https://bugs.webkit.org/show_bug.cgi?id=125252

Source/JavaScriptCore:

Reviewed by Sam Weinig.

This was meant to be easy. The problem is that there was no good place for putting
the folding of typedArray.length to a constant. You can't quite do it in the
bytecode parser because at that point you don't yet know if typedArray is really
a typed array. You can't do it as part of constant folding because the folder
assumes that it can opportunistically forward-flow a constant value without changing
the IR; this doesn't work since we need to first change the IR to register a
desired watchpoint and only after that can we introduce that constant. We could have
done it in Fixup but that would have been awkward since Fixup's code for turning a
GetById of "length" into GetArrayLength is already somewhat complex. We could have
done it in CSE but CSE is already fairly gnarly and will probably get rewritten.

So I introduced a new phase, called StrengthReduction. This phase should have any
transformations that don't requite CFA or CSE and that it would be weird to put into
those other phases.

I also took the opportunity to refactor some of the other folding code.

This also adds a test, but the test couldn't quite be a LayoutTests/js/regress so I
introduced the notion of JavaScriptCore/tests/stress.

The goal of this patch isn't really to improve performance or anything like that.
It adds an optimization for completeness, and in doing so it unlocks a bunch of new
possibilities. The one that I'm most excited about is revealing array length checks
in DFG IR, which will allow for array bounds check hoisting and elimination.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::tryGetFoldableView):
(JSC::DFG::Graph::tryGetFoldableViewForChild1):

dfg/DFGGraph.h:
dfg/DFGNode.h:

(JSC::DFG::Node::hasTypedArray):
(JSC::DFG::Node::typedArray):

dfg/DFGNodeType.h:
dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::jumpForTypedArrayOutOfBounds):
(JSC::DFG::SpeculativeJIT::compileConstantIndexedPropertyStorage):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGStrengthReductionPhase.cpp: Added.

(JSC::DFG::StrengthReductionPhase::StrengthReductionPhase):
(JSC::DFG::StrengthReductionPhase::run):
(JSC::DFG::StrengthReductionPhase::handleNode):
(JSC::DFG::StrengthReductionPhase::foldTypedArrayPropertyToConstant):
(JSC::DFG::performStrengthReduction):

dfg/DFGStrengthReductionPhase.h: Added.
dfg/DFGWatchpointCollectionPhase.cpp:

(JSC::DFG::WatchpointCollectionPhase::handle):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetIndexedPropertyStorage):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::LowerDFGToLLVM::typedArrayLength):

jsc.cpp:

(GlobalObject::finishCreation):
(functionTransferArrayBuffer):

runtime/ArrayBufferView.h:
tests/stress: Added.
tests/stress/fold-typed-array-properties.js: Added.

(foo):

Tools:

Reviewed by Sam Weinig.

Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
should put tests that run just like JSRegress but don't run as part of LayoutTests.
Currently I'm using it for tests that require some surgical support from jsc.cpp.

Scripts/run-javascriptcore-tests:

10:57 AM Changeset in webkit [160291] by weinig@apple.com

3 edits in trunk/Source/WebKit2

[Cocoa] Remove webProcessPlugInInitialize: from the WKWebProcessPlugIn protocol
https://bugs.webkit.org/show_bug.cgi?id=125405

Reviewed by Dan Bernstein.

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::load):

10:26 AM Changeset in webkit [160290] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[WK2] Guard include of SecItemShim.h with ENABLE(SEC_ITEM_SHIM)
https://bugs.webkit.org/show_bug.cgi?id=125415

Patch by Brian Holt <brian.holt@samsung.com> on 2013-12-08
Reviewed by Gustavo Noronha Silva.

NetworkProcess/NetworkProcess.cpp:
UIProcess/Network/NetworkProcessProxy.cpp:

10:22 AM Changeset in webkit [160289] by Carlos Garcia Campos

7 edits in trunk/Source/WebCore

[GTK] Do not skip attributes with only custom setter
https://bugs.webkit.org/show_bug.cgi?id=125417

Reviewed by Gustavo Noronha Silva.

For attributes with a custom setter, we now generate the code as a
read-only attribute with a getter method, unless it also has a
custom getter in which case the attribute is skipped.

bindings/gobject/GNUmakefile.am: Generate WebKitDOMMediaController

that is now required by an attribute having a custom setter.

bindings/gobject/WebKitDOMCustom.cpp: Remove methods that are now generated.
bindings/gobject/WebKitDOMCustom.h: Ditto.
bindings/gobject/WebKitDOMCustom.symbols: Ditto.
bindings/gobject/webkitdom.symbols: Add new symbols.
bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute): Do not skip attributes having a custom setter.
(GetWriteableProperties): Do not include attributes having a
custom setter.
(GenerateProperty): Do not return early for attributes having
custom setter.
(GenerateFunctions): Do not generate setter for attributes having
a custom setter.

10:16 AM Changeset in webkit [160288] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

[GTK] Do not generate new dispatch_event methods marked as deprecated
https://bugs.webkit.org/show_bug.cgi?id=125416

Reviewed by Gustavo Noronha Silva.

bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction): Skip dispatch_event methods for objects
implementing EventTarget interface unless they are already
deprecated.
(GenerateFunction): Pass also the parentNode to SkipFunction().

8:51 AM Changeset in webkit [160287] by zandobersek@gmail.com

2 edits in trunk/Tools

[gdb] Update printers for WTF::CString, JSC::JSString
https://bugs.webkit.org/show_bug.cgi?id=124600

Reviewed by Gustavo Noronha Silva.

Update the two printers after they fell behind the changes in implementation.

gdb/webkit.py:

(WTFCStringPrinter.to_string):
(JSCJSStringPrinter.to_string):

8:50 AM Changeset in webkit [160286] by zandobersek@gmail.com

1 edit
1 add in trunk/Tools

[webkitpy] Add a WestonDriver unit test
https://bugs.webkit.org/show_bug.cgi?id=125408

Reviewed by Gustavo Noronha Silva.

Add a webkitpy unit test for the Weston driver.

Scripts/webkitpy/port/westondriver_unittest.py: Added.

(WestonDriverTest):
(WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
(WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
the server environment contains proper WAYLAND and GDK_BACKEND entries.
(WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
the driver cleans up the temporary directory.
(WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
(WestonDriverTest.test_stop.FakeWestonProcess.terminate):

7:30 AM Changeset in webkit [160285] by commit-queue@webkit.org

2 edits in trunk/Tools

[Gtk] install-dependencies doesn't install libgtk-3-dev
https://bugs.webkit.org/show_bug.cgi?id=125320

Patch by Brendan Long <b.long@cablelabs.com> on 2013-12-08
Reviewed by Gustavo Noronha Silva.

gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion

5:09 AM Changeset in webkit [160284] by zandobersek@gmail.com

2 edits
1 delete in trunk/LayoutTests

Unreviewed GTK gardening.

Removing the baseline added in r160283. It's not really required, the failure is originating
in an unnecessary and wrong patch that's applied on the Freetype source tree that's used in the
GTK's Jhbuild setup. That patch will be removed in the near future, but until then the failure
of accessibility/press-targers-center-point.html should be handled through an expectation.

platform/gtk/TestExpectations:
platform/gtk/accessibility/press-targets-center-point-expected.txt: Removed.

2:09 AM Changeset in webkit [160283] by zandobersek@gmail.com

2 edits
1 add in trunk/LayoutTests

Unreviewed GTK gardening. Adding expectations for the current test failures.
Adding a GTK-specific baseline for a recently introduced a11y test.

platform/gtk/TestExpectations:
platform/gtk/accessibility/press-targets-center-point-expected.txt: Added.

Dec 7, 2013:

10:43 PM Changeset in webkit [160282] by jer.noble@apple.com

12 edits
2 adds in trunk

[MSE] Bring end-of-stream algorithm section up to current spec.
https://bugs.webkit.org/show_bug.cgi?id=125270

Reviewed by Darin Adler.

Source/WebCore:

Test: media/media-source/media-source-end-of-stream.html

Separate the "endOfStream()" method from the "end of stream algorithm".

Modules/mediasource/MediaSource.cpp:

(WebCore::SourceBufferIsUpdating): Added predicate function.
(WebCore::MediaSource::endOfStream): Call streamEndedWithError().
(WebCore::MediaSource::streamEndedWithError): Added.

Modules/mediasource/MediaSource.h:
Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBufferTimerFired): Call streamEndedWithError().
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Ditto.

Modules/mediasource/SourceBuffer.h:
html/HTMLMediaElement.cpp:

(HTMLMediaElement::mediaLoadingFailedFatally): Renamed from mediaEngineError.
(HTMLMediaElement::mediaLoadingFailed): Call renamed method.

html/HTMLMediaElement.h:
platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::markEndOfStream): Set load state to Loaded.

platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::setNetworkState): Simple setter.

platform/mock/mediasource/MockMediaPlayerMediaSource.h:
platform/mock/mediasource/MockMediaSourcePrivate.cpp:

(WebCore::MockMediaSourcePrivate::MockMediaSourcePrivate): Set the intitial duration to NaN.
(WebCore::MockMediaSourcePrivate::markEndOfStream): Set load state to Loaded.

LayoutTests:

media/media-source/media-source-end-of-stream-expected.txt: Added.
media/media-source/media-source-end-of-stream.html: Added.

10:39 PM Changeset in webkit [160281] by jer.noble@apple.com

7 edits in trunk/Source/WebCore

[MSE][Mac] Crash when removing MediaSource from HTMLMediaElement.
https://bugs.webkit.org/show_bug.cgi?id=125269

Reviewed by Sam Weinig.

Fixes the media/media-source/media-source-fastseek.html test when run with MallocScribble enabled.

It's possible for a SourceBufferPrivateAVFObjC to outlive its MediaSourcePrivateAVFObjC, so
make sure to clear the pointer from the former to the latter when the latter is destroyed.
That means we now have to check to see if the pointer to the latter is still valid at every
call site.

As a drive-by fix, rename m_parent to m_mediaSource to more accurately reflect what the pointer
points to.

platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::~MediaSourcePrivateAVFObjC): Clear the SourceBuffer's backpointer.

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:

(WebCore::SourceBufferPrivateAVFObjC::clearMediaSource):

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC): Rename m_parent -> m_mediaSource.
(WebCore::SourceBufferPrivateAVFObjC::append): Check m_mediaSource before calling.
(WebCore::SourceBufferPrivateAVFObjC::removedFromMediaSource): Ditto.
(WebCore::SourceBufferPrivateAVFObjC::readyState): Ditto.
(WebCore::SourceBufferPrivateAVFObjC::setReadyState): Ditto.
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled): Ditto.
(WebCore::SourceBufferPrivateAVFObjC::flushAndEnqueueNonDisplayingSamples): Ditto.
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample): Ditto.
(WebCore::SourceBufferPrivateAVFObjC::setActive): Ditto.

platform/mock/mediasource/MockMediaSourcePrivate.cpp:

(WebCore::MockMediaSourcePrivate::~MockMediaSourcePrivate): Clear the SourceBuffer's backpointer.

platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockSourceBufferPrivate::MockSourceBufferPrivate): Rename m_parent -> m_mediaSource.
(WebCore::MockSourceBufferPrivate::removedFromMediaSource): Check m_mediaSource before calling.
(WebCore::MockSourceBufferPrivate::readyState): Ditto.
(WebCore::MockSourceBufferPrivate::setReadyState): Ditto.
(WebCore::MockSourceBufferPrivate::setActive): Ditto.

platform/mock/mediasource/MockSourceBufferPrivate.h:

(WebCore::MockSourceBufferPrivate::clearMediaSource):

10:17 PM Changeset in webkit [160280] by weinig@apple.com

7 edits in trunk/Source/WebKit2

[Cocoa] Make WKWebProcessPlugInController work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=125404

Reviewed by Dan Bernstein.

Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

Shared/mac/ObjCObjectGraphCoders.mm:
WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

(-[WKWebProcessPlugInController dealloc]):
(didCreatePage):
(willDestroyPage):
(-[WKWebProcessPlugInController _setPrincipalClassInstance:]):
(-[WKWebProcessPlugInController API::]):

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h:

(WebKit::wrapper):

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInPrivate.h:
WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::load):

9:53 PM Changeset in webkit [160279] by zoltan@webkit.org

2 edits in trunk/Source/WebCore

Remove statusWithDirection static function from RenderBlockLineLayout
https://bugs.webkit.org/show_bug.cgi?id=125372

Reviewed by Andreas Kling.

I run into a FIXME about using BidiStatus constructor rather than statusWithDirection,
once it's implemented. BidiStatus has got the appropriate constructor now, so I removed
statusWithDirection and updated the code to use the constructor of BidiStatus.

No new tests, no behavior change.

rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRunsForSegment):

9:23 PM Changeset in webkit [160278] by mitz@apple.com

3 edits
2 adds in trunk/Source/WebKit2

[Cocoa] WebData has a generic wrapper
https://bugs.webkit.org/show_bug.cgi?id=125402

Reviewed by Sam Weinig.

Added WKNSData, an NSData subclass that confroms to WKObject and wraps a WebData.

Shared/Cocoa/APIObject.mm:

(API::Object::newObject): Allocate a WKNSData if the API::Object is data.

Shared/Cocoa/WKNSData.h: Added.

(WebKit::wrapper): Added. Returns a WebData’s wrapper as an NSData.

Shared/Cocoa/WKNSData.mm: Added.

(-[WKNSData dealloc]): Calls the WebData destructor.
(-[WKNSData length]): Added.
(-[WKNSData bytes]): Added.
(-[WKNSData copyWithZone:]): Retains self.
(-[WKNSData _apiObject]): Returns the wrapped WebData.

WebKit2.xcodeproj/project.pbxproj: Added references to new files.

9:22 PM Changeset in webkit [160277] by weinig@apple.com

8 edits in trunk/Source/WebKit2

[Cocoa] Make WKWebProcessPlugInBrowserContextController work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=125403

Reviewed by Dan Bernstein.

Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

Shared/mac/ObjCObjectGraphCoders.mm:

(WebKit::InjectedBundleObjCObjectGraphDecoderImpl::decode):

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

(didCreatePage):
(willDestroyPage):
(setUpBundleClient):
(-[WKWebProcessPlugInController _initWithPrincipalClassInstance:bundle:]):

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController dealloc]):
(-[WKWebProcessPlugInBrowserContextController mainFrameDocument]):
(-[WKWebProcessPlugInBrowserContextController selectedRange]):
(-[WKWebProcessPlugInBrowserContextController API::]):
(-[WKWebProcessPlugInBrowserContextController _bundlePageRef]):
(-[WKWebProcessPlugInBrowserContextController handle]):
(+[WKWebProcessPlugInBrowserContextController lookUpBrowsingContextFromHandle:]):

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:

(WebKit::wrapper):

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h:
WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::load):

7:00 PM Changeset in webkit [160276] by weinig@apple.com

2 edits in trunk/Tools

[Cocoa] Convert a few more parts of MiniBrowser over to the Objective-C API
https://bugs.webkit.org/show_bug.cgi?id=125401

Reviewed by Dan Bernstein.

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController fetch:]):
(-[WK2BrowserWindowController reload:]):
(-[WK2BrowserWindowController goBack:]):
(-[WK2BrowserWindowController goForward:]):
(-[WK2BrowserWindowController validateUserInterfaceItem:]):
(-[WK2BrowserWindowController currentZoomFactor]):
(-[WK2BrowserWindowController setCurrentZoomFactor:]):
(-[WK2BrowserWindowController zoomIn:]):
(-[WK2BrowserWindowController zoomOut:]):
(-[WK2BrowserWindowController canResetZoom]):
(-[WK2BrowserWindowController resetZoom:]):
(-[WK2BrowserWindowController toggleZoomMode:]):
(-[WK2BrowserWindowController updateTextFieldFromURL:]):

6:36 PM Changeset in webkit [160275] by weinig@apple.com

5 edits in trunk/Tools

Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup
https://bugs.webkit.org/show_bug.cgi?id=125400

Reviewed by Dan Bernstein.

MiniBrowser/mac/AppDelegate.h:
MiniBrowser/mac/AppDelegate.m:
MiniBrowser/mac/WK2BrowserWindowController.h:
MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
(-[WK2BrowserWindowController dealloc]):
(createNewPage):
(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
(-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
(-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
(-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate

9:39 AM Changeset in webkit [160274] by Gustavo Noronha Silva

2 edits in trunk/Tools

[GTK] Run each gtest subtest separately instead of in one go
https://bugs.webkit.org/show_bug.cgi?id=125386

Reviewed by Martin Robinson.

This is what other ports are doing (except they build each test as a separate binary)
and will help with the timeouts we sometimes hit because it applies to the full test
run.

Scripts/run-gtk-tests:

(TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
(TestRunner._run_google_test): run a single subtest from a gtest binary.
(TestRunner._run_google_test_suite): call the binary once per subtest.

8:50 AM Changeset in webkit [160273] by ChangSeok Oh

2 edits in trunk/Source/WebCore

Unreviewed. Build fix for gtk port after r160260.

loader/cache/CachedImage.h: Add missing a header.

8:33 AM Changeset in webkit [160272] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[Win][64-bit] Hitting breakpoint assembler instruction in callToJavaScript.
https://bugs.webkit.org/show_bug.cgi?id=125382

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-12-07
Reviewed by Michael Saboff.

The WinCairo results from run-javascriptcore-tests are the same as the WinCairo 32-bits results, when removing these breakpoints.

jit/JITStubsMSVC64.asm: Remove breakpoint instructions.

6:54 AM Changeset in webkit [160271] by commit-queue@webkit.org

6 edits in trunk/Tools

Move PrettyPatch related code to prettypatch.py
https://bugs.webkit.org/show_bug.cgi?id=124937

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-12-07
Reviewed by Ryosuke Niwa.

This code seems to have a better place here than in Port, since PrettyPatch already knows
pretty_patch_path, and this also unifies the usage of PrettyPatch

Scripts/webkitpy/common/prettypatch.py:

(PrettyPatch.init):
(PrettyPatch.pretty_diff):
(PrettyPatch):
(PrettyPatch.pretty_patch_available):
(PrettyPatch.check_pretty_patch):
(PrettyPatch.pretty_patch_text):

Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter.create_text_diff_and_write_result):

Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

Scripts/webkitpy/port/base.py:

(Port.init):
(Port.wdiff_available):
(Port.check_image_diff):
(Port.wdiff_text):

Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_pretty_patch_os_error):
(PortTest.test_pretty_patch_script_error):

5:03 AM Changeset in webkit [160270] by Gustavo Noronha Silva

4 edits in trunk/Source

Fix API test expectation following 160220.

Rubber-stamped by Martin Robinson.

Source/WebKit/gtk:

tests/testatkroles.c:

(finish_loading): rename variable documentFrame -> document.
(test_webkit_atk_get_role_document_frame): check for ATK_ROLE_DOCUMENT_WEB instead of
ATK_ROLE_DOCUMENT_FRAME.
(test_webkit_atk_get_role_heading): rename variable documentFrame -> document.
(test_webkit_atk_get_role_image): ditto.
(test_webkit_atk_get_role_link): ditto.
(test_webkit_atk_get_role_list_and_item): ditto.
(test_webkit_atk_get_role_paragraph): ditto.
(test_webkit_atk_get_role_section): ditto.
(test_webkit_atk_get_role_table): ditto.
(test_webkit_atk_get_role_separator): ditto.
(test_webkit_atk_get_role_combobox): ditto.
(test_webkit_atk_get_role_form): ditto.
(test_webkit_atk_get_role_check_box): ditto.
(test_webkit_atk_get_role_entry): ditto.
(test_webkit_atk_get_role_label): ditto.
(test_webkit_atk_get_role_listbox): ditto.
(test_webkit_atk_get_role_password_text): ditto.
(test_webkit_atk_get_role_push_button): ditto.
(test_webkit_atk_get_role_radio_button): ditto.

Source/WebKit2:

UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp:

(testAtspiBasicHierarchy): check for ATK_ROLE_DOCUMENT_WEB instead of ATK_ROLE_DOCUMENT_FRAME.

3:50 AM Changeset in webkit [160269] by Gustavo Noronha Silva

2 edits in trunk/Source/WebCore

ubuntu software center hits _XReadEvents() error
https://bugs.webkit.org/show_bug.cgi?id=123480

Reviewed by Martin Robinson.

platform/gtk/WidgetBackingStoreGtkX11.cpp:

(WebCore::WidgetBackingStoreGtkX11::~WidgetBackingStoreGtkX11): clear the surface
before freeing the associated pixmap.

Dec 6, 2013:

10:41 PM Changeset in webkit [160268] by msaboff@apple.com

2 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: Fix Specialized Thunks to use function prologues and epilogues
https://bugs.webkit.org/show_bug.cgi?id=125381

Not yet reviewed.

Changed the entry / exit sequences to use emitFunctionPrologue() and
functionEpilogue().

jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::returnJSValue):
(JSC::SpecializedThunkJIT::returnDouble):
(JSC::SpecializedThunkJIT::returnInt32):
(JSC::SpecializedThunkJIT::returnJSCell):

9:46 PM Changeset in webkit [160267] by msaboff@apple.com

15 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: Enable basic JavaScript functionality in LLInt
https://bugs.webkit.org/show_bug.cgi?id=125378

Reviewed by Filip Pizlo.

This provides basic LLInt only functionality for X86_64. It runs simple scripts.
There are several places where the code is tagged with "&&&& FIXME: ..." comments
as placeholders where more work needs to be done.

Added X86 compliant prologue / epilogues at the head and tail of functions.
Changed LLInt calls to leave the caller framePointer in callFrame register and
pass the callee framePointer (-16) in SP so that the callee receiving prologue
will make store the ReturnPC and CallerFrame at the right location in the call
frame header. Created a stack pointer sanity check macro (checkStackPointerAlignment)
in the LLInt that will cause a breakpoint on failure.

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLLink.cpp:

(JSC::FTL::compileEntry):
(JSC::FTL::link):

ftl/FTLThunks.cpp:

(JSC::FTL::osrExitGenerationThunkGenerator):
(JSC::FTL::slowPathCallThunkGenerator):

interpreter/Interpreter.cpp:

(JSC::unwindCallFrame):

interpreter/ProtoCallFrame.cpp:

(JSC::ProtoCallFrame::init):

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitFunctionPrologue):
(JSC::AssemblyHelpers::emitFunctionEpilogue):

jit/JIT.cpp:

(JSC::JIT::privateCompile):

jit/JITCall.cpp:

(JSC::JIT::privateCompileClosureCall):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):

jit/Repatch.cpp:

(JSC::linkClosureCall):

jit/ThunkGenerators.cpp:

(JSC::slowPathFor):
(JSC::nativeForGenerator):

llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter64.asm:

6:55 PM Changeset in webkit [160266] by mitz@apple.com

2 edits in trunk/Tools

[Mac] MiniBrowser Debug builds are compiled with -Os
https://bugs.webkit.org/show_bug.cgi?id=125376

Reviewed by Tim Horton.

MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for

the Debug configuration at the project level.

6:14 PM Changeset in webkit [160265] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

[mac] Keep around more decoded image data, since it's purgeable
https://bugs.webkit.org/show_bug.cgi?id=125273
<rdar://problem/13205438>

Unreviewed patch to fix review comments...

platform/graphics/BitmapImage.h:

Dan noticed that these return statements were improperly indented.

5:42 PM Changeset in webkit [160264] by enrica@apple.com

5 edits in trunk/Source/WebKit2

Make insertText message asynchronous for iOS.

Reviewed by Benjamin Poulain.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::insertText):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::insertText):

5:01 PM Changeset in webkit [160263] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

[MSE][Mac] Disable AVFoundation when enabling the MockMediaPlayerMediaSource.
https://bugs.webkit.org/show_bug.cgi?id=125338

Reviewed by Darin Adler.

The MediaSource API has some assumptions which break if more than one installed
media engine supports MediaSources at the same time. So when enabling the mock
media source engine in DRT or WKTR, disable AVFoundation so that only the mock
engine will support media source loading.

testing/Internals.cpp:

(WebCore::Internals::initializeMockMediaSource):

4:57 PM Changeset in webkit [160262] by Antti Koivisto

2 edits in trunk/Source/WebCore

Use NeverDestroyed instead of DEFINE_STATIC_LOCAL

Reviewed by Anders Carlsson.

rendering/RenderText.cpp:

(WebCore::originalTextMap):

4:56 PM Changeset in webkit [160261] by jer.noble@apple.com

16 edits in trunk

[MSE] Add a runtime-setting for the MediaSource constructor.
https://bugs.webkit.org/show_bug.cgi?id=125336

Reviewed by Eric Carlson.

Source/WebCore:

Add a Setting to enable the MediaSource constructor.

Modules/mediasource/MediaSource.idl:
page/Settings.in:

Source/WebKit/mac:

Add a private WebPreference which controls the WebCore mediaSourceEnabled setting.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences mediaSourceEnabled]):
(-[WebPreferences setMediaSourceEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Add a private WKPreferences API to control the WebCore mediaSourceEnabled setting.

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetMediaSourceEnabled):
(WKPreferencesGetMediaSourceEnabled):

UIProcess/API/C/WKPreferencesPrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Enable MediaSource in DRT and WKTR.

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

4:45 PM Changeset in webkit [160260] by timothy_horton@apple.com

7 edits in trunk/Source/WebCore

[mac] Keep around more decoded image data, since it's purgeable
https://bugs.webkit.org/show_bug.cgi?id=125273
<rdar://problem/13205438>

Reviewed by Simon Fraser.

No new tests, just an optimization.

Instead of throwing away decoded image data eagerly, allow the operating
system to manage the memory via the standard purgeability mechanism,
where it can.

This improves the performance on some pathological cases (extremely large
animated GIFs) by up to 8x.

loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::pruneLiveResourcesToSize):
Don't prune live resources' decoded data if it is purgeable.

platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedDataIfNecessary):
Don't eagerly throw away decoded image data if it's purgeable.

loader/cache/CachedImage.h:
loader/cache/CachedResource.h:

(WebCore::CachedResource::decodedDataIsPurgeable):

platform/graphics/BitmapImage.h:
platform/graphics/Image.h:

(WebCore::Image::decodedDataIsPurgeable):

4:33 PM Changeset in webkit [160259] by Antti Koivisto

8 edits in trunk/Source/WebCore

Save original text for RenderText to a map
https://bugs.webkit.org/show_bug.cgi?id=125278

Reviewed by Darin Adler.

Currently the original text is fetched from the Text node. This is one of the few things
where we use the RenderText node pointer and is stopping Text nodes from being anonymous.

It is very rare of original text to differ from the actual text so we can just squirrel the
original to a map when it differs. This is also simplifies the code.

rendering/RenderQuote.cpp:

(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::updateDepth):

rendering/RenderText.cpp:

(WebCore::originalTextMap):
(WebCore::RenderText::RenderText):
(WebCore::RenderText::~RenderText):
(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::originalText):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::setText):

rendering/RenderText.h:
rendering/RenderTextFragment.cpp:
rendering/RenderTextFragment.h:

4:10 PM Changeset in webkit [160258] by jer.noble@apple.com

9 edits
2 deletes in trunk/Source/WebCore

[MSE] Refactor MediaSourceBase back into MediaSource
https://bugs.webkit.org/show_bug.cgi?id=125245

Reviewed by Eric Carlson.

Now that the legacy WebKitMediaSource has been removed, there is no reason to have
a separate MediaSource and MediaSourceBase. Re-integrate the two.

Copy all the methods from MediaSource into MediaSourceBase, and rename the class MediaSource:

Modules/mediasource/MediaSource.cpp: Copied from MediaSourceBase.cpp.

(WebCore::MediaSource::create): Copied from MediaSource.cpp.
(WebCore::MediaSource::addSourceBuffer): Ditto.
(WebCore::MediaSource::removeSourceBuffer): Ditto.
(WebCore::MediaSource::isTypeSupported): Ditto.
(WebCore::MediaSource::eventTargetInterface): Ditto.
(WebCore::MediaSource::sourceBufferDidChangeAcitveState): Ditto.

Modules/mediasource/MediaSource.h: Copied from MediaSourceBase.h.

(WebCore::MediaSource::sourceBuffers): Copied from MediaSource.h.
(WebCore::MediaSource::activeSourceBuffers): Copied from MediaSource.h.

Modules/mediasource/MediaSourceBase.cpp: Removed.
Modules/mediasource/MediaSourceBase.h: Removed.

Change all references to MediaSourceBase into MediaSource:

Modules/mediasource/DOMURLMediaSource.cpp:

(WebCore::DOMURLMediaSource::createObjectURL):

Modules/mediasource/DOMURLMediaSource.h:
Modules/mediasource/MediaSourceRegistry.cpp:

(WebCore::MediaSourceRegistry::registerURL):
(WebCore::MediaSourceRegistry::unregisterURL):

Modules/mediasource/MediaSourceRegistry.h:

Remove MediaSourceBase.cpp/h from the project file:

WebCore.xcodeproj/project.pbxproj:
GNUmakefile.list.am:

3:20 PM Changeset in webkit [160257] by fpizlo@apple.com

5 edits
3 adds in trunk

FTL should support all of Branch/LogicalNot
https://bugs.webkit.org/show_bug.cgi?id=125370

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLIntrinsicRepository.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::boolify):

LayoutTests:

js/regress/logical-not-expected.txt: Added.
js/regress/logical-not.html: Added.
js/regress/script-tests/logical-not.js: Added.

(foo):

3:14 PM Changeset in webkit [160256] by commit-queue@webkit.org

5 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed, rolling out r159543.
http://trac.webkit.org/changeset/159543
https://bugs.webkit.org/show_bug.cgi?id=125371

Build fix for mac no longer needed (Requested by rfong on
#webkit).

ANGLE.xcodeproj/project.pbxproj:
src/compiler/glslang_tab.cpp:

(yysyntax_error):
(glslang_parse):

src/compiler/glslang_tab.h:
src/compiler/preprocessor/ExpressionParser.cpp:

(yy_symbol_print):
(yy_stack_print):
(yy_reduce_print):
(yytnamerr):
(yysyntax_error):
(yydestruct):
(yyparse):

3:06 PM Changeset in webkit [160255] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

r159827 broke plug-in snapshotting
https://bugs.webkit.org/show_bug.cgi?id=125365

Reviewed by Dean Jackson.

No new tests, covered by existing tests.

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Return early if there is NOT

a page, not if there IS a page.

2:56 PM Changeset in webkit [160254] by Brent Fulgham

12 edits in trunk/Source

../JavaScriptCore: [Win] Support compiling with VS2013
https://bugs.webkit.org/show_bug.cgi?id=125353

Reviewed by Anders Carlsson.

API/tests/testapi.c: Use C99 defines if available.
jit/JITOperations.cpp: Don't attempt to define C linkage when

returning a C++ object.

../WebCore: [Win] Support compiling with VS2013
https://bugs.webkit.org/show_bug.cgi?id=125353

Reviewed by Anders Carlsson.

loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create): Use nullptr
(WebCore::LegacyWebArchive::createFromSelection): Ditto

../WebKit: [Win] Support compiling with VS2013.
https://bugs.webkit.org/show_bug.cgi?id=125353

Reviewed by Anders Carlsson.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Provide

proper exports for VS2013 build.

../WTF: [Win] Support compiling with VS2013
https://bugs.webkit.org/show_bug.cgi?id=125353

Reviewed by Anders Carlsson.

wtf/Compiler.h: Show proper features for VS2012 and VS2013.
wtf/MathExtras.h: Don't implement common C99 routines when

they are available through the runtime libraries.

wtf/RetainPtr.h:

(WTF::RetainPtr::operator bool): Added.

wtf/StdLibExtras.h: Use Microsoft's version of make_unique

when it exists.

2:54 PM Changeset in webkit [160253] by msaboff@apple.com

15 edits in branches/jsCStack/Source/JavaScriptCore

Merged from trunk r160244: <http://trac.webkit.org/changeset/160244>

Split sizing of VarArgs frames from loading arguments for the frame
https://bugs.webkit.org/show_bug.cgi?id=125331

Reviewed by Filip Pizlo.

Split loadVarargs into sizeAndAllocFrameForVarargs() and loadVarargs() in
preparation for moving onto the C stack. sizeAndAllocFrameForVarargs() will
compute the size of the callee frame and allocate it, while loadVarargs()
actually loads the argument values.

As part of moving onto the C stack, sizeAndAllocFrameForVarargs() will be
changed to a function that just computes the size. The caller will use that
size to allocate the new frame on the stack before calling loadVargs() and
actually making the call.

interpreter/Interpreter.cpp: (JSC::sizeAndAllocFrameForVarargs): (JSC::loadVarargs):
interpreter/Interpreter.h:
jit/JIT.h:
jit/JITCall.cpp: (JSC::JIT::compileLoadVarargs):
jit/JITCall32_64.cpp: (JSC::JIT::compileLoadVarargs):
jit/JITInlines.h: (JSC::JIT::callOperation):
jit/JITOperations.cpp:
jit/JITOperations.h:
llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL):
llint/LLIntSlowPaths.h:
llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/VM.h:

2:54 PM Changeset in webkit [160252] by fpizlo@apple.com

6 edits
3 adds in trunk

FTL should support generic ByVal accesses
https://bugs.webkit.org/show_bug.cgi?id=125368

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

dfg/DFGGraph.h:

(JSC::DFG::Graph::isStrictModeFor):
(JSC::DFG::Graph::ecmaModeFor):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLIntrinsicRepository.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):

LayoutTests:

js/regress/by-val-generic-expected.txt: Added.
js/regress/by-val-generic.html: Added.
js/regress/script-tests/by-val-generic.js: Added.

(foo):

2:43 PM Changeset in webkit [160251] by jer.noble@apple.com

9 edits
4 copies
6 adds in trunk/Source/WebCore

[MSE][Mac] Add a new MSE-compatible MediaPlayerPrivate implementation, MediaPlayerPrivateMediaSourceAVFObjC
https://bugs.webkit.org/show_bug.cgi?id=123378

Reviewed by Eric Carlson.

Add an AVFoundation implementation of MediaPlayerPrivate which creates and uses
MediaSourcePrivate and SourceBufferPrivate subclasses.

Add the new media engine to the list of installed engines:

platform/MediaSample.h:
platform/graphics/MediaPlayer.cpp:

(WebCore::installedMediaEngines):

platform/graphics/MediaPlayer.h:

Add the new files to the project:

WebCore.xcodeproj/project.pbxproj:

Drive by fix for ports who implement seekDouble():

platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::seekWithTolerance):

Add new Video and AudioTrackPrivate types which handle their own enable state:

platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.cpp: Added

(WebCore::AudioTrackPrivateMediaSourceAVFObjC::AudioTrackPrivateMediaSourceAVFObjC):
(WebCore::AudioTrackPrivateMediaSourceAVFObjC::resetPropertiesFromTrack):
(WebCore::AudioTrackPrivateMediaSourceAVFObjC::setAssetTrack):
(WebCore::AudioTrackPrivateMediaSourceAVFObjC::assetTrack):
(WebCore::AudioTrackPrivateMediaSourceAVFObjC::setEnabled):

platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.h: Added
platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.cpp: Added.

(WebCore::VideoTrackPrivateMediaSourceAVFObjC::VideoTrackPrivateMediaSourceAVFObjC):
(WebCore::VideoTrackPrivateMediaSourceAVFObjC::resetPropertiesFromTrack):
(WebCore::VideoTrackPrivateMediaSourceAVFObjC::setAssetTrack):
(WebCore::VideoTrackPrivateMediaSourceAVFObjC::assetTrack):
(WebCore::VideoTrackPrivateMediaSourceAVFObjC::setSelected):

platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h: Added.

Add a new MediaPlayerPrivate which can handle MediaSource objects:

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h: Added.
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: Added.

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::~MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::registerMediaEngine):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::create):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isAvailable):
(WebCore::mimeTypeCache):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::getSupportedTypes):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::load):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cancelLoad):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::prepareToPlay):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::platformMedia):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::platformLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::play):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::playInternal):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::pause):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::pauseInternal):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::paused):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsScanning):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::naturalSize):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasVideo):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasAudio):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVisible):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationDouble):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentTimeDouble):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::startTimeDouble):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::initialTime):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekWithTolerance):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seeking):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setRateDouble):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::networkState):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::readyState):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekable):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::maxTimeSeekableDouble):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::minTimeSeekable):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::buffered):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::didLoadingProgress):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setSize):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::paint):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasAvailableVideoFrame):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsAcceleratedRendering):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::acceleratedRenderingStateChanged):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::movieLoadType):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::prepareForRendering):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::engineDescription):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::languageOfPrimaryAudioTrack):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::extraMemoryCost):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::destroyLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateDuration):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateStates):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setReadyState):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setNetworkState):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addDisplayLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeDisplayLayer):

Add a new MediaSourcePrivate implementation:

platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h: Added.

(WebCore::MediaSourcePrivateAVFObjC::player):
(WebCore::MediaSourcePrivateAVFObjC::activeSourceBuffers):

platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm: Added.

(WebCore::MediaSourcePrivateAVFObjC::create):
(WebCore::MediaSourcePrivateAVFObjC::MediaSourcePrivateAVFObjC):
(WebCore::MediaSourcePrivateAVFObjC::~MediaSourcePrivateAVFObjC):
(WebCore::MediaSourcePrivateAVFObjC::addSourceBuffer):
(WebCore::MediaSourcePrivateAVFObjC::removeSourceBuffer):
(WebCore::MediaSourcePrivateAVFObjC::duration):
(WebCore::MediaSourcePrivateAVFObjC::setDuration):
(WebCore::MediaSourcePrivateAVFObjC::markEndOfStream):
(WebCore::MediaSourcePrivateAVFObjC::unmarkEndOfStream):
(WebCore::MediaSourcePrivateAVFObjC::readyState):
(WebCore::MediaSourcePrivateAVFObjC::setReadyState):
(WebCore::MediaSourcePrivateAVFObjC::sourceBufferPrivateDidChangeActiveState):
(WebCore::MediaSourcePrivateAVFObjCHasAudio):
(WebCore::MediaSourcePrivateAVFObjC::hasAudio):
(WebCore::MediaSourcePrivateAVFObjCHasVideo):
(WebCore::MediaSourcePrivateAVFObjC::hasVideo):
(WebCore::MediaSourcePrivateAVFObjC::seekToTime):

Add a new SourceBufferPrivate implementation:

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h: Added.
platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: Added.

(-[WebAVStreamDataParserListener initWithParser:parent:WebCore::]):
(-[WebAVStreamDataParserListener dealloc]):
(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:]):
(-[WebAVStreamDataParserListener streamDataParser:didFailToParseStreamDataWithError:]):
(-[WebAVStreamDataParserListener streamDataParser:didProvideMediaData:forTrackID:mediaType:flags:]):
(-[WebAVStreamDataParserListener streamDataParser:didReachEndOfTrackWithTrackID:mediaType:]):
(WebCore::MediaSampleAVFObjC::create):
(WebCore::MediaSampleAVFObjC::~MediaSampleAVFObjC):
(WebCore::MediaSampleAVFObjC::MediaSampleAVFObjC):
(WebCore::MediaSampleAVFObjC::platformSample):
(WebCore::CMSampleBufferIsRandomAccess):
(WebCore::MediaSampleAVFObjC::flags):
(WebCore::MediaDescriptionAVFObjC::create):
(WebCore::MediaDescriptionAVFObjC::~MediaDescriptionAVFObjC):
(WebCore::MediaDescriptionAVFObjC::MediaDescriptionAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::create):
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::didParseStreamDataAsAsset):
(WebCore::SourceBufferPrivateAVFObjC::didFailToParseStreamDataWithError):
(WebCore::callProcessCodedFrameForEachSample):
(WebCore::SourceBufferPrivateAVFObjC::didProvideMediaDataForTrackID):
(WebCore::SourceBufferPrivateAVFObjC::processCodedFrame):
(WebCore::SourceBufferPrivateAVFObjC::didReachEndOfTrackWithTrackID):
(WebCore::SourceBufferPrivateAVFObjC::setClient):
(WebCore::SourceBufferPrivateAVFObjC::append):
(WebCore::SourceBufferPrivateAVFObjC::abort):
(WebCore::SourceBufferPrivateAVFObjC::removedFromMediaSource):
(WebCore::SourceBufferPrivateAVFObjC::readyState):
(WebCore::SourceBufferPrivateAVFObjC::setReadyState):
(WebCore::SourceBufferPrivateAVFObjC::evictCodedFrames):
(WebCore::SourceBufferPrivateAVFObjC::isFull):
(WebCore::SourceBufferPrivateAVFObjC::hasVideo):
(WebCore::SourceBufferPrivateAVFObjC::hasAudio):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::createNonDisplayingCopy):
(WebCore::SourceBufferPrivateAVFObjC::flushAndEnqueueNonDisplayingSamples):
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample):
(WebCore::SourceBufferPrivateAVFObjC::isReadyForMoreSamples):
(WebCore::SourceBufferPrivateAVFObjC::setActive):
(WebCore::SourceBufferPrivateAVFObjC::fastSeekTimeForMediaTime):
(WebCore::SourceBufferPrivateAVFObjC::seekToTime):

platform/mac/PlatformClockCM.h:

Add a SOFT_LINK_CLASS_OPTIONAL macro:

platform/mac/SoftLinking.h:

2:31 PM Changeset in webkit [160250] by ap@apple.com

2 edits in trunk/Source/WebCore

Remove some duplicate checks from SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=125358

Reviewed by Geoffrey Garen.

There is no need to call inherits() before WebCore's toXXX(JSValue) functions.

Also, the result of toArrayBuffer() is a raw pointer, not a RefPtr (it's confusing
because toArrayBufferView returns a RefPtr).

bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal):

2:31 PM Changeset in webkit [160249] by jer.noble@apple.com

2 edits in trunk/LayoutTests

Unreviewed gardening; revert r160237 after r160247 made it unnecessary.

platform/mac/TestExpectations:

2:27 PM Changeset in webkit [160248] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Remove Image::decodedSize()
https://bugs.webkit.org/show_bug.cgi?id=125327

Reviewed by Simon Fraser.

Missed a comment when removing this code.

svg/graphics/SVGImage.h:

2:22 PM Changeset in webkit [160247] by jer.noble@apple.com

5 edits in trunk/Tools

Strip out extraneous logging from AppleGVA in media tests.
https://bugs.webkit.org/show_bug.cgi?id=125357

Reviewed by Simon Fraser.

Add a mechanism for stripping out abritrary regular expressions from test input and output.

Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._run_compare_test): Strip out logging

Scripts/webkitpy/port/base.py:

(Port.logging_patterns_to_strip): Return an empty list by default.

Scripts/webkitpy/port/driver.py:

(DriverOutput.strip_patterns): Apply the port specific patterns to the text.

Scripts/webkitpy/port/mac.py:

(MacPort.logging_patterns_to_strip): Return a complete list.

2:05 PM Changeset in webkit [160246] by fpizlo@apple.com

5 edits
6 adds in trunk

FTL should support hole/OOB array accesses
https://bugs.webkit.org/show_bug.cgi?id=118077

Reviewed by Oliver Hunt and Mark Hahnenberg.

Source/JavaScriptCore:

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLIntrinsicRepository.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::baseIndex):

LayoutTests:

js/regress/double-get-by-val-out-of-bounds-expected.txt: Added.
js/regress/double-get-by-val-out-of-bounds.html: Added.
js/regress/get-by-val-out-of-bounds-expected.txt: Added.
js/regress/get-by-val-out-of-bounds.html: Added.
js/regress/script-tests/double-get-by-val-out-of-bounds.js: Added.

(foo):

js/regress/script-tests/get-by-val-out-of-bounds.js: Added.

(foo):

1:40 PM Changeset in webkit [160245] by mitz@apple.com

3 edits in trunk/Source/WebKit2

<rdar://problem/15606872> REGRESSION (r160148): Mail throws an exception during launch
https://bugs.webkit.org/show_bug.cgi?id=125362

Reviewed by Sam Weinig.

There were two problems in how WKConnection was made to work with WKObject: first,
API::Object::newObject() was not updated to allocate the correct wrapper class, and second,
WebConnection has subclasses with additional data members, which don’t fit in the object
storage ivar.

Shared/Cocoa/APIObject.mm:

(API::Object::newObject): Changed to allocate a WKConnection of the required size.

UIProcess/API/Cocoa/WKConnection.mm:

Removed _connection ivar.
(-[WKConnection dealloc]): Changed to use -_connection accessor instead of ivar.
(-[WKConnection setDelegate:]): Ditto.
(-[WKConnection sendMessageWithName:body:]): Ditto.
(-[WKConnection remoteObjectRegistry]): Ditto.
(-[WKConnection _connection]): Added.
(-[WKConnection _apiObject]): Changed to return the object in the instance extra storage.

1:38 PM Changeset in webkit [160244] by msaboff@apple.com

15 edits in trunk/Source/JavaScriptCore

Split sizing of VarArgs frames from loading arguments for the frame
https://bugs.webkit.org/show_bug.cgi?id=125331

Reviewed by Filip Pizlo.

Split loadVarargs into sizeAndAllocFrameForVarargs() and loadVarargs() in
preparation for moving onto the C stack. sizeAndAllocFrameForVarargs() will
compute the size of the callee frame and allocate it, while loadVarargs()
actually loads the argument values.

As part of moving onto the C stack, sizeAndAllocFrameForVarargs() will be
changed to a function that just computes the size. The caller will use that
size to allocate the new frame on the stack before calling loadVargs() and
actually making the call.

interpreter/Interpreter.cpp:

(JSC::sizeAndAllocFrameForVarargs):
(JSC::loadVarargs):

interpreter/Interpreter.h:
jit/JIT.h:
jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):

jit/JITCall32_64.cpp:

(JSC::JIT::compileLoadVarargs):

jit/JITInlines.h:

(JSC::JIT::callOperation):

jit/JITOperations.cpp:
jit/JITOperations.h:
llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

llint/LLIntSlowPaths.h:
llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/VM.h:

1:02 PM Changeset in webkit [160243] by commit-queue@webkit.org

9 edits in trunk

[CSS Shapes] ShapeOutsideInfo needs to use the parent's writing mode when calculating offsets
https://bugs.webkit.org/show_bug.cgi?id=124680

Patch by Rob Buis <rob.buis@samsung.com> on 2013-12-06
Reviewed by Dirk Schulze.

Source/WebCore:

Do not take the writing-mode property on the float into account for shape-outside.
Add a virtual method writingMode() in order to do this for shape-outside but
keep old behavior (element writingMode) for shape-inside.

Change existing test floats/shape-outside-floats-different-writing-modes.html to test the
new behavior.

rendering/shapes/ShapeInfo.cpp:

(WebCore::::computedShape):

rendering/shapes/ShapeInfo.h:

(WebCore::ShapeInfo::writingMode):

rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::writingMode):

rendering/shapes/ShapeOutsideInfo.h:

LayoutTests:

Make sure the writing-mode property on the float is not taken into account for shape-outside.
Adapt highlight-shape-outside.html so it sets the writing-mode on the container div, not the float.
However because of earlier unreliability in EFL/GTK, skip the test for now.

TestExpectations:
fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html:
inspector-protocol/model/highlight-shape-outside-expected.txt:
inspector-protocol/model/highlight-shape-outside.html:

12:59 PM Changeset in webkit [160242] by fpizlo@apple.com

4 edits
3 adds in trunk

FTL should support all of ValueToInt32
https://bugs.webkit.org/show_bug.cgi?id=125283

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileValueToInt32):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::isCell):

LayoutTests:

js/regress/put-by-val-machine-int-expected.txt: Added.
js/regress/put-by-val-machine-int.html: Added.
js/regress/script-tests/put-by-val-machine-int.js: Added.

(foo):

12:57 PM Changeset in webkit [160241] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Remove Staging Workaround
https://bugs.webkit.org/show_bug.cgi?id=125354

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-06
Reviewed by Timothy Hatcher.

inspector/CodeGeneratorInspector.py:

12:55 PM Changeset in webkit [160240] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Simplify ScriptFunctionCall by removing dead code.
https://bugs.webkit.org/show_bug.cgi?id=125274

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-06
Reviewed by Timothy Hatcher.

bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::call):

bindings/js/ScriptFunctionCall.h:

12:38 PM Changeset in webkit [160239] by dino@apple.com

2 edits in trunk/Tools

Updating ANGLE should point to instructions
https://bugs.webkit.org/show_bug.cgi?id=125361

Reviewed by Eric Carlson.

Point to https://trac.webkit.org/wiki/UpdatingANGLE when
someone wants to patch ANGLE.

Scripts/webkitpy/common/config/watchlist:

12:30 PM Changeset in webkit [160238] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

FTL shouldn't have a doubleToUInt32 path
https://bugs.webkit.org/show_bug.cgi?id=125360

Reviewed by Mark Hahnenberg.

This code existed because I incorrectly thought it was necessary. It's now basically
dead.

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compilePutByVal):

12:21 PM UpdatingANGLE edited by dino@apple.com

(diff)

12:20 PM UpdatingANGLE created by dino@apple.com

12:17 PM Changeset in webkit [160237] by eric.carlson@apple.com

2 edits
1 delete in trunk/LayoutTests

Unreviewed gardening, correct previous fix.

platform/mac-mountainlion/TestExpectations: Removed.
platform/mac/TestExpectations: Mark plugins/quicktime-plugin-replacement.html as flakey

on Mavericks.

12:11 PM WikiStart edited by dino@apple.com

Add link to new ANGLE page (diff)

11:59 AM Changeset in webkit [160236] by dbates@webkit.org

50 edits
2 adds in trunk/Source/WebCore

[iOS] Upstream WebCore/rendering changes
https://bugs.webkit.org/show_bug.cgi?id=125239

Reviewed by Simon Fraser.

WebCore.xcodeproj/project.pbxproj:
rendering/InlineBox.cpp:

(WebCore::InlineBox::previousOnLineExists): Added.

rendering/InlineBox.h:
rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintCompositionBackground): Modified to query RenderStyle
on iOS for the composition fill color. Added FIXME to make this platform-independent.
(WebCore::InlineTextBox::paintDecoration): Added iOS-specific decoration code.
(WebCore::lineStyleForMarkerType):
(WebCore::InlineTextBox::paintDocumentMarkers): Added iOS-specific code. Also, added
FIXME to make this code platform-independent.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paint): Ditto.
(WebCore::positionForPointRespectingEditingBoundaries): Added iOS-specific code.

rendering/RenderBlock.h: Changed access control of logical{Left, Right}SelectionOffset()

from private to protected so that these methods can be used from RenderImage::collectSelectionRects().

rendering/RenderBox.cpp:

(WebCore::RenderBox::borderRadii): Added.
(WebCore::RenderBox::paintBoxDecorations): Added iOS-specific workaround. See <rdar://problem/6209763>
for more details.
(WebCore::RenderBox::computeRectForRepaint): Added iOS-specific code.
(WebCore::customContainingBlockWidth): Added; guarded by PLATFORM(IOS).
(WebCore::customContainingBlockHeight): Added; guarded by PLATFORM(IOS).
(WebCore::customContainingBlockLogicalWidth): Added; guarded by PLATFORM(IOS).
(WebCore::customContainingBlockLogicalHeight): Added; guarded by PLATFORM(IOS).
(WebCore::customContainingBlockAvailableLogicalHeight): Added; guarded by PLATFORM(IOS).
(WebCore::RenderBox::availableLogicalHeightUsing): Added iOS-specific code; calls customContainingBlockAvailableLogicalHeight().
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned): Added iOS-specific code; calls customContainingBlockLogicalWidth().
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned): Added iOS-specific code; calls customContainingBlockLogicalHeight().
(WebCore::RenderBox::layoutOverflowRectForPropagation): Added iOS-specific code.

rendering/RenderBox.h:
rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::stickyPositionOffset): Use FrameView::customFixedPositionLayoutRect()
instead of FrameView::viewportConstrainedVisibleContentRect().

rendering/RenderButton.cpp:

(WebCore::RenderButton::layout): Added; iOS-specific. Includes FIXME comment.
See <rdar://problem/7675493> for more details.

rendering/RenderElement.cpp:

(WebCore::RenderElement::styleWillChange): Added iOS-specific code.
(WebCore::RenderElement::styleDidChange): Modified to only call areCursorsEqual() and
EventHandler::scheduleCursorUpdate() on a non-iOS port.

rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing): Added iOS-specific code.
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason): This method has an empty implementation for iOS.
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReasonWithDescription): Ditto.

rendering/RenderFileUploadControl.cpp:

(WebCore::nodeHeight):
(WebCore::RenderFileUploadControl::maxFilenameWidth): Added iOS-specific code.
(WebCore::RenderFileUploadControl::paintObject): Ditto.
(WebCore::RenderFileUploadControl::fileTextValue): Ditto.

rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::positionFrames): Ditto; Also added FIXME comment as this code may not
be specific to iOS.

rendering/RenderIFrame.h: Added iOS-specific workaround to RenderObject::renderName(). Added

FIXME comment to determine whether this workaround is still applicable.

rendering/RenderImage.cpp:

(WebCore::RenderImage::collectSelectionRects): Added; guarded by PLATFORM(IOS).
(WebCore::RenderImage::paintAreaElementFocusRing): This method has an empty implementation for iOS.

rendering/RenderImage.h:
rendering/RenderInline.cpp:

(WebCore::RenderInline::absoluteQuadsForSelection): Added; guarded by PLATFORM(IOS).

rendering/RenderInline.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer): Added iOS-specific member initialization.
(WebCore::RenderLayer::~RenderLayer): Added iOS-specific code.
(WebCore::RenderLayer::willBeDestroyed): Added; iOS-specific.
(WebCore::RenderLayer::hasAcceleratedTouchScrolling): Ditto.
(WebCore::RenderLayer::handleTouchEvent): Ditto.
(WebCore::RenderLayer::registerAsTouchEventListenerForScrolling): Ditto.
(WebCore::RenderLayer::unregisterAsTouchEventListenerForScrolling): Ditto.
(WebCore::RenderLayer::updateNeedsCompositedScrolling): Added iOS-specific code as we use UIKit
to composite our scroll bars.
(WebCore::RenderLayer::scrollTo): Added iOS-specific code.
(WebCore::RenderLayer::scrollRectToVisible): Ditto.
(WebCore::RenderLayer::styleChanged): Modified to make use of the passed StyleDifference on iOS.
(WebCore::RenderLayer::visibleContentRect): Added; iOS-specific.
(WebCore::RenderLayer::didStartScroll): Ditto.
(WebCore::RenderLayer::didEndScroll): Ditto.
(WebCore::RenderLayer::didUpdateScroll): Ditto.
(WebCore::RenderLayer::invalidateScrollbarRect): Added iOS-specific code.
(WebCore::RenderLayer::invalidateScrollCornerRect): Ditto.
(WebCore::RenderLayer::verticalScrollbarWidth): Ditto.
(WebCore::RenderLayer::horizontalScrollbarHeight): Ditto.
(WebCore::RenderLayer::updateScrollableAreaSet): Ditto.
(WebCore::RenderLayer::updateScrollInfoAfterLayout): Add iOS-specific workaround with FIXME. See
<rdar://problem/15579797> for more details.
(WebCore::RenderLayer::paintOverflowControls): Added iOS-specific code.
(WebCore::RenderLayer::calculateClipRects): Ditto.

rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): Modified to not apply page scale on iOS
as we apply a page scale at a different time in the code.
(WebCore::RenderLayerBacking::layerWillBeDestroyed): Added; guarded by PLATFORM(IOS).
(WebCore::layerOrAncestorIsTransformedOrScrolling): Added iOS-specific variant with FIXME comment.
(WebCore::RenderLayerBacking::shouldClipCompositedBounds): Added iOS-specific code.
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Ditto.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Ditto.
(WebCore::RenderLayerBacking::registerScrollingLayers): Ditto.
(WebCore::RenderLayerBacking::updateScrollingLayers): Ditto.
(WebCore::RenderLayerBacking::containsPaintedContent): Call RenderLayer::hasBoxDecorationsOrBackground()
when building on iOS Simulator.
(WebCore::RenderLayerBacking::parentForSublayers): Added iOS-specific code and FIXME comment.
(WebCore::RenderLayerBacking::paintsIntoWindow): Opt-into coordinated graphics code path.
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): Added iOS-specific code.
(WebCore::RenderLayerBacking::paintIntoLayer): Compile-out ASSERT_NOT_REACHED for iOS and added FIXME comment.

rendering/RenderLayerBacking.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::scheduleLayerFlush): Added iOS-specific code.
(WebCore::RenderLayerCompositor::chromeClient): Added; guarded by PLATFORM(IOS).
(WebCore::RenderLayerCompositor::flushPendingLayerChanges): Added iOS-specific code.
(WebCore::scrollbarHasDisplayNone): Added; iOS-specific.
(WebCore::updateScrollingLayerWithClient): Ditto.
(WebCore::RenderLayerCompositor::updateCustomLayersAfterFlush): Ditto.
(WebCore::RenderLayerCompositor::didFlushChangesForLayer): Added iOS-specific code.
(WebCore::RenderLayerCompositor::didChangeVisibleRect): Ditto.
(WebCore::RenderLayerCompositor::addToOverlapMap): Don't apply page scale factor on iOS. We apply
the page scale factor at a different time in the code. Also, added FIXME comment.
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Added iOS-specific workaround.
See <rdar://problem/8348337> for more details.
(WebCore::RenderLayerCompositor::setIsInWindow): Use non-Mac code path for iOS.
(WebCore::RenderLayerCompositor::allowsIndependentlyCompositedFrames): Added iOS-specific code.
(WebCore::RenderLayerCompositor::requiresCompositingLayer): Ditto.
(WebCore::RenderLayerCompositor::requiresOwnBackingStore): Ditto.
(WebCore::RenderLayerCompositor::reasonsForCompositing): Ditto.
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation): Opt-into calling
AnimationController::isRunningAnimationOnRenderer() on iOS.
(WebCore::RenderLayerCompositor::requiresCompositingForScrolling): Added; guarded by PLATFORM(IOS).
(WebCore::isStickyInAcceleratedScrollingLayerOrViewport): Added iOS-specific code.
(WebCore::isViewportConstrainedFixedOrStickyLayer): Ditto.
(WebCore::RenderLayerCompositor::requiresCompositingForPosition): Use FrameView::customFixedPositionLayoutRect()
instead of FrameView::viewportConstrainedVisibleContentRect().
(WebCore::RenderLayerCompositor::contentsScaleMultiplierForNewTiles): Ditto.
(WebCore::RenderLayerCompositor::ensureRootLayer): Ditto.
(WebCore::RenderLayerCompositor::computeFixedViewportConstraints): Use FrameView::customFixedPositionLayoutRect()
instead of FrameView::viewportConstrainedVisibleContentRect().
(WebCore::RenderLayerCompositor::computeStickyViewportConstraints): Ditto.
(WebCore::RenderLayerCompositor::registerOrUpdateViewportConstrainedLayer): This method has an empty implementation for iOS
as we batch update viewport-constrained layers in the iOS-specific method, RenderLayerCompositor::updateCustomLayersAfterFlush().
(WebCore::RenderLayerCompositor::unregisterViewportConstrainedLayer): Ditto.
(WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers): Added; guarded by PLATFORM(IOS).
(WebCore::RenderLayerCompositor::unregisterAllViewportConstrainedLayers): Ditto.
(WebCore::RenderLayerCompositor::registerAllScrollingLayers): Ditto.
(WebCore::RenderLayerCompositor::unregisterAllScrollingLayers): Ditto.
(WebCore::RenderLayerCompositor::scrollingLayerAddedOrUpdated): Ditto.
(WebCore::RenderLayerCompositor::scrollingLayerRemoved): Ditto.
(WebCore::RenderLayerCompositor::startInitialLayerFlushTimerIfNeeded): Ditto.

rendering/RenderLayerCompositor.h:
rendering/RenderLayerFilterInfo.h: Added iOS-specific Clang workaround to ignore

an unused private field.

rendering/RenderMenuList.cpp:

(WebCore::selectedOptionCount): Added; guarded by PLATFORM(IOS).
(WebCore::RenderMenuList::RenderMenuList): On iOS we don't make use of RenderMenuList::m_popupIsVisible.
(WebCore::RenderMenuList::~RenderMenuList): On iOS we don't make use of RenderMenuList::m_popup.
(WebCore::RenderMenuList::adjustInnerStyle): Add iOS-specific code.
(RenderMenuList::updateFromElement): On iOS we don't make use of RenderMenuList::m_popup.
(RenderMenuList::setTextFromOption): Add iOS-specific code.
(RenderMenuList::showPopup): Define RenderMenuList::showPopup() to ASSERT_NOT_REACHED() on iOS as
we don't make use of RenderMenuList::m_popup.
(RenderMenuList::hidePopup): This method has an empty implementation for iOS as we don't make use
of RenderMenuList::m_popup.
(RenderMenuList::popupDidHide): This method has an empty implementation for iOS as we don't make use
of RenderMenuList::m_popupIsVisible.

rendering/RenderMenuList.h:
rendering/RenderObject.cpp:

(WebCore::RenderObject::columnNumberForOffset): Added; guarded by PLATFORM(IOS). Also, added a FIXME comment to
make this function return an unsigned integer instead of a signed integer.
(WebCore::RenderObject::collectSelectionRects): Added; guarded by PLATFORM(IOS).
(WebCore::RenderObject::destroy): Added iOS-specific code.
(WebCore::RenderObject::innerLineHeight): Added.
(WebCore::RenderObject::willRenderImage): Added iOS-specific code.

rendering/RenderObject.h: Change the access control of RenderObject::drawLineForBoxSide() from protected to

public so that it can be used from RenderThemeIOS::adjustMenuListButtonStyle().
(WebCore::RenderObject::absoluteQuadsForSelection):

rendering/RenderScrollbar.h: Change the access control of RenderScrollbar::getScrollbarPseudoStyle() from

private to public so that it can be used from the iOS-specific static function, scrollbarHasDisplayNone,
defined in RenderLayerCompositor.cpp.

rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::itemText): Added iOS-specific code.

rendering/RenderText.cpp:

(WebCore::RenderText::collectSelectionRects): Added; guarded by PLATFORM(IOS).
(WebCore::RenderText::setTextInternal): Added iOS-specific code.

rendering/RenderText.h:
rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::adjustInnerTextStyle): Ditto.
(WebCore::RenderTextControl::canScroll): Added; guarded by PLATFORM(IOS).
(WebCore::RenderTextControl::innerLineHeight): Ditto.

rendering/RenderTextControl.h:
rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::getAvgCharWidth): Compile-out code when building for iOS.
(WebCore::RenderTextControlMultiLine::createInnerTextStyle): Added iOS-specific code.

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout): Ditto.
(WebCore::RenderTextControlSingleLine::getAvgCharWidth): Compile-out code when building for iOS.
(WebCore::RenderTextControlSingleLine::preferredContentLogicalWidth): Ditto.

rendering/RenderTextLineBoxes.cpp:

(WebCore::lineDirectionPointFitsInBox): Ditto.
(WebCore::RenderTextLineBoxes::positionForPoint): Added iOS-specific code.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintBorderOnly): Ditto.
(WebCore::RenderTheme::paintDecorations): Modified to call the control-specific paint*Decorations().

rendering/RenderTheme.h:

(WebCore::RenderTheme::paintCheckboxDecorations): Added.
(WebCore::RenderTheme::paintRadioDecorations): Added.
(WebCore::RenderTheme::paintButtonDecorations): Added.
(WebCore::RenderTheme::paintTextFieldDecorations): Added.
(WebCore::RenderTheme::paintTextAreaDecorations): Added.
(WebCore::RenderTheme::paintMenuListDecorations): Added.
(WebCore::RenderTheme::paintPushButtonDecorations): Added.
(WebCore::RenderTheme::paintSquareButtonDecorations): Added.
(WebCore::RenderTheme::paintFileUploadIconDecorations): Added.
(WebCore::RenderTheme::paintSliderThumbDecorations): Added.
(WebCore::RenderTheme::paintSearchFieldDecorations): Added.

rendering/RenderThemeIOS.h: Added.
rendering/RenderThemeIOS.mm: Added.
rendering/RenderThemeMac.h: Don't compile the contents of this file when building for iOS.
rendering/RenderThemeMac.mm: Ditto.
rendering/RenderVideo.cpp:

(WebCore::RenderVideo::calculateIntrinsicSize): Compile-out code when building for iOS.

rendering/RenderView.cpp:

(WebCore::RenderView::availableLogicalHeight): Add iOS-specific workaround. See <rdar://problem/7166808>.
(WebCore::fixedPositionOffset): Added; used in iOS-specific code (e.g. RenderView::mapLocalToContainer()).
(WebCore::RenderView::mapLocalToContainer): Use WebCore::fixedPositionOffset() instead of
FrameView::scrollOffsetForFixedPosition().
(WebCore::RenderView::pushMappingToContainer): Ditto.
(WebCore::RenderView::mapAbsoluteToLocalPoint): Ditto.
(WebCore::RenderView::repaintViewRectangle): Ditto.
(WebCore::RenderView::computeRectForRepaint): Ditto.
(WebCore::isFixedPositionInViewport): Added; used in RenderView::hasCustomFixedPosition().
(WebCore::RenderView::hasCustomFixedPosition): Added; guarded by PLATFORM(IOS).

rendering/RenderView.h:
rendering/RenderWidget.cpp:

(WebCore::RenderWidget::willBeDestroyed): Added iOS-specific code.

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox): Ditto.

rendering/break_lines.cpp: Only include header <CoreServices/CoreServices.h> when building for Mac.

11:31 AM Changeset in webkit [160235] by zoltan@webkit.org

11 edits in trunk/Source/WebCore

Clean up the includes of RenderBlock.h
https://bugs.webkit.org/show_bug.cgi?id=125351

Reviewed by Darin Adler.

I turned some header includes into forward declarations. I also removed /
moved out some includes, which don't belong to RenderBlock.h anymore.

No new tests, no behavior change.

editing/VisibleUnits.cpp:
html/HTMLInputElement.cpp:
html/HTMLTextAreaElement.cpp:
html/TextFieldInputType.cpp:
html/TextInputType.cpp:
rendering/InlineElementBox.cpp:
rendering/RenderBlock.h:
rendering/RenderBlockFlow.cpp:
rendering/line/LineBreaker.h:
rendering/line/LineWidth.cpp:

11:28 AM Changeset in webkit [160234] by fpizlo@apple.com

1 copy in branches/jsCStack

Create a branch to allow for greater collaboration on the still-incomplete JS-on-C-stack patch(es).

11:28 AM Changeset in webkit [160233] by eric.carlson@apple.com

1 edit
1 add in trunk/LayoutTests

plugins/quicktime-plugin-replacement.html is flakey on OS X Mavericks
https://bugs.webkit.org/show_bug.cgi?id=125356

Reviewed by Jer Noble.

platform/mac-mountainlion/TestExpectations: Added. Mark test as flakey.

11:04 AM Changeset in webkit [160232] by Michał Pakuła vel Rutka

3 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for failing tests.

platform/efl-wk2/TestExpectations:
platform/efl/TestExpectations:

11:02 AM Changeset in webkit [160231] by mitz@apple.com

2 edits in trunk/Tools

[Mac] Transition MiniBrowser to the Cocoa API: load delegate
https://bugs.webkit.org/show_bug.cgi?id=125334

Reviewed by Darin Adler.

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
title property.
(-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
(-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
(-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
window title with the title property changes.
(-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
set the load delegate instead of the load client.
(-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
(-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
(-[WK2BrowserWindowController updateCommittedURL]): Ditto.
(-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
Implemented this load delegate method.
(-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
Ditto.
(-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
(-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
(-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
(-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
(-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
Ditto.
(-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
Ditto.
(-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.

10:56 AM Changeset in webkit [160230] by commit-queue@webkit.org

3 edits in trunk/Tools

Remove function from style/checkers/cpp.py.
https://bugs.webkit.org/show_bug.cgi?id=125341

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-06
Reviewed by Darin Adler.

Corrects a FIXME: by removing a function from cpp.py.

Scripts/webkitpy/style/checkers/cpp.py:

(CppChecker.init):
(CppChecker.check):

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTestBase.process_file_data):

10:54 AM Changeset in webkit [160229] by commit-queue@webkit.org

3 edits in trunk/Tools

check-webkit-style: false positive warning for indentation of #ifdef code.
https://bugs.webkit.org/show_bug.cgi?id=125254

Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-12-06
Reviewed by Darin Adler.

Scripts/webkitpy/style/checkers/cpp.py:

(check_member_initialization_list):

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_member_initialization_list):

10:54 AM Changeset in webkit [160228] by commit-queue@webkit.org

7 edits in trunk/Source

Define SHA1 hash size in SHA1.h and use it at various places.
https://bugs.webkit.org/show_bug.cgi?id=125345

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-12-06
Reviewed by Darin Adler.

Use SHA1::hashSize instead of local variables.

Source/JavaScriptCore:

bytecode/CodeBlockHash.cpp:

(JSC::CodeBlockHash::CodeBlockHash): use SHA1::hashSize

Source/WebCore:

Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::getExpectedWebSocketAccept):

platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::HostTLSCertificateSet::computeCertificateHash):

Source/WTF:

wtf/SHA1.h: define SHA1 hash size

10:21 AM Changeset in webkit [160227] by mitz@apple.com

6 edits
3 adds in trunk/Source

[Cocoa] Add load delegate methods for responding to authentication challenges
https://bugs.webkit.org/show_bug.cgi?id=125333

Reviewed by Darin Adler.

Source/WebCore:

WebCore.exp.in: Exported core(NSURLCredential *).

Source/WebKit2:

Shared/Cocoa/APIObject.mm:

(API::Object::newObject): Allocate a WKNSURLAuthenticationChallenge if the object is an
AuthenticationChallengeProxy.

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(canAuthenticateAgainstProtectionSpaceInFrame): Implemented this WKPageLoaderClient callback
by calling the load delegate.
(didReceiveAuthenticationChallengeInFrame): Ditto.
(setUpPageLoaderClient): Set the above callbacks in the client structure.

UIProcess/API/Cocoa/WKBrowsingContextLoadDelegatePrivate.h: Added. Declares two new

delegate methods.

UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.h: Added.

(WebKit::wrapper): Added. Returns an AuthenticationChallengeProxy’s wrapper as an
NSURLAuthenticationChallenge.

UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.mm: Added.

(-[WKNSURLAuthenticationChallenge _web_createTarget]): Override this WKObject method to
return a copy of the challenge with the sender set to a shared instance of
WKNSURLAuthenticationChallengeSender.
(-[WKNSURLAuthenticationChallenge _web_authenticationChallengeProxy]): Added. Returns the
wrapped object.
(-[WKNSURLAuthenticationChallengeSender cancelAuthenticationChallenge:]): Added. Calls
AuthenticationDecisionListener::cancel.
(-[WKNSURLAuthenticationChallengeSender continueWithoutCredentialForAuthenticationChallenge:]):
Added. Calls AuthenticationDecisionListener::useCredential, passing nullptr.
(-[WKNSURLAuthenticationChallengeSender useCredential:forAuthenticationChallenge:]): Added.
Calls AuthenticationDecisionListener::useCredential, passing the credential.

WebKit2.xcodeproj/project.pbxproj: Added references to new files.

10:13 AM Changeset in webkit [160226] by dbates@webkit.org

15 edits in trunk/Source/WebCore

Rename {adjust, paint}SearchFieldDecoration, {adjust, paint}SearchFieldResultsDecoration
https://bugs.webkit.org/show_bug.cgi?id=125191

Reviewed by Joseph Pecoraro.

Towards upstreaming the iOS concept of render theme decorations, we should rename
RenderTheme::{adjust, paint}SearchFieldDecorationStyle and RenderTheme::{adjust, paint}SearchFieldResultsDecoration
to avoid ambiguity with the iOS concept.

platform/efl/RenderThemeEfl.cpp:
platform/efl/RenderThemeEfl.h:
platform/gtk/RenderThemeGtk.cpp:
platform/gtk/RenderThemeGtk.h:
rendering/RenderTheme.cpp:
rendering/RenderTheme.h:
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:
rendering/RenderThemeSafari.cpp:
rendering/RenderThemeSafari.h:
rendering/RenderThemeWin.cpp:
rendering/RenderThemeWin.h:
rendering/RenderThemeWinCE.cpp:
rendering/RenderThemeWinCE.h:

9:46 AM Changeset in webkit [160225] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Unreviewed ATK gardening

accessibility/document-attributes.html started failing after r160220.

Patch by Lukasz Gajowy <l.gajowy@samsung.com> on 2013-12-06

platform/efl/TestExpectations:
platform/gtk/TestExpectations:

9:40 AM Changeset in webkit [160224] by akling@apple.com

14 edits in trunk/Source/WebCore

Make remaining CSSValue constructors return PassRef.
<https://webkit.org/b/125337>

Tweak the remaining CSSValue create() helpers to return PassRef
instead of PassRefPtr in the cases where nullptr is never returned.

Reviewed by Anders Carlsson.

9:28 AM Changeset in webkit [160223] by roger_fong@apple.com

7 edits in trunk/Source/WebCore

Hook into some shader symbol logic following the ANGLE update in r159533.
https://bugs.webkit.org/show_bug.cgi?id=125332.

Reviewed by Brent Fulgham.

No new functionality added.

html/canvas/WebGLRenderingContext.cpp: Add some error checking for errors related to

shader symbols that exist across both vertex and fragment shaders.

(WebCore::WebGLRenderingContext::linkProgram):

platform/graphics/ANGLEWebKitBridge.cpp: Add logic for handling varyings

and add new fields to the ANGLEShaderSymbol struct.

(WebCore::getSymbolInfo):

platform/graphics/ANGLEWebKitBridge.h:
platform/graphics/GraphicsContext3D.h: Add those same fields to the SymbolInfo struct

as well so that we can access them from our shader source map.
Also add a map of varyings along side the uniforms and attributes.

(WebCore::GraphicsContext3D::SymbolInfo::SymbolInfo):
(WebCore::GraphicsContext3D::ShaderSourceEntry::symbolMap):

platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::areProgramSymbolsValid): Will be filled in later, this method

will use the shader source map to check for issues with unused varyings and precisions
mismatches of shader symbols that exist across both the vertex and fragment shaders.

9:18 AM Changeset in webkit [160222] by Chris Fleizach

3 edits in trunk/Tools

Fix spelling error in style checker: beggining
https://bugs.webkit.org/show_bug.cgi?id=125347

Reviewed by Anders Carlsson.

Scripts/webkitpy/style/checkers/cpp.py:

(check_member_initialization_list):

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_member_initialization_list):

6:54 AM Changeset in webkit [160221] by msaboff@apple.com

3 edits in trunk/Source/JavaScriptCore

REGRESSION(r160213): Crash in js/dom/JSON-parse.html
https://bugs.webkit.org/show_bug.cgi?id=125335

Reviewed by Mark Lam.

Changed _llint_op_catch to materialize the VM via the scope chain instead of
the CodeBlock. CallFrames always have a scope chain, but may have a null CodeBlock.

llint/LowLevelInterpreter32_64.asm:

(_llint_op_catch):

llint/LowLevelInterpreter64.asm:

(_llint_op_catch):

5:58 AM Changeset in webkit [160220] by commit-queue@webkit.org

6 edits
3 adds in trunk

[ATK] Missing aria roles mappings
https://bugs.webkit.org/show_bug.cgi?id=117729

Patch by Lukasz Gajowy <l.gajowy@samsung.com> on 2013-12-06
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Added a few mappings from ARIA roles to ATK roles.

Test: accessibility/aria-mappings.html

accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

Tools:

Added new mappings to AccessibilityUIElementAtk.cpp.

DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

Added new test, checking whether ARIA roles to ATK roles mappings work properly.

accessibility/aria-mappings-expected.txt: Added.
accessibility/aria-mappings.html: Added.
platform/mac/accessibility/aria-mappings-expected.txt: Added.

4:41 AM Changeset in webkit [160219] by Csaba Osztrogonác

2 edits in trunk/Tools

Typo fix after r160218.

Scripts/webkitpy/test/main.py:

(main):

3:29 AM Changeset in webkit [160218] by Csaba Osztrogonác

2 edits in trunk/Tools

Unreviewed fix after r160206.

Scripts/webkitpy/test/main.py:

(main): sys.platform can be win32 or cygwin too on Windows.

3:21 AM Changeset in webkit [160217] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Build fix after r160207, remove the BitmapImage::decodeSize symbol export
https://bugs.webkit.org/show_bug.cgi?id=125342

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-12-06
Reviewed by Csaba Osztrogonác.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

3:20 AM Changeset in webkit [160216] by Philippe Normand

2 edits in trunk/Source/WebCore

[GStreamer] webkitwebaudiosrc element needs to emit stream-start, caps and segment events
https://bugs.webkit.org/show_bug.cgi?id=123015

Reviewed by Martin Robinson.

When the source element starts emitting buffers send along various
events to notify downstream elements.

No new tests, change covered by existing webaudio tests.

platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webkit_web_audio_src_init): Initialize segment.
(webKitWebAudioSrcConstructed): Give an explicit name to each
queue added in front of the interleave element.
(webKitWebAudioSrcLoop): Before sending the first buffers push
stream-start, caps and segment events on each queue's sinkpad.

3:08 AM Changeset in webkit [160215] by berto@igalia.com

2 edits in trunk

[GTK] Enable web audio by default
https://bugs.webkit.org/show_bug.cgi?id=124888

Reviewed by Martin Robinson.

When building with ./configure, enable_web_audio defaults to
"no". However the basic functionality has been working for months
so it's safe to enable it now.

Source/autotools/ReadCommandLineArguments.m4:

1:06 AM Changeset in webkit [160214] by Philippe Normand

4 edits in trunk/Source/WebCore

[GStreamer] Audio/Video sink management is incoherent
https://bugs.webkit.org/show_bug.cgi?id=125304

Reviewed by Gustavo Noronha Silva.

Allow subclasses of MediaPlayerPrivateGStreamerBase to create
custom audio/video sinks in a coherent manner using
create{Audio,Video}Sink methods. Convenience getters are also
available. Also removed some un-needed member variables in the
playbin-based player.

No new tests, existing media tests cover this change.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::audioSink):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

(WebCore::MediaPlayerPrivateGStreamerBase::createAudioSink):

Dec 5, 2013:

9:32 PM Changeset in webkit [160213] by msaboff@apple.com

6 edits in trunk/Source/JavaScriptCore

JSC: Simplify interface between throw and catch handler
https://bugs.webkit.org/show_bug.cgi?id=125328

Reviewed by Geoffrey Garen.

Simplified the throw - catch interface. The throw side is only responsible for
jumping to the appropriate op_catch handler or returnFromJavaScript for uncaught
exceptions. The handler uses the exception values like VM.callFrameForThrow
as appropriate and no longer relies on the throw side putting anything in
registers.

jit/CCallHelpers.h:

(JSC::CCallHelpers::jumpToExceptionHandler):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_catch):

llint/LowLevelInterpreter32_64.asm:

(_llint_op_catch):
(_llint_throw_from_slow_path_trampoline):

llint/LowLevelInterpreter64.asm:

(_llint_op_catch):
(_llint_throw_from_slow_path_trampoline):

9:20 PM Changeset in webkit [160212] by gyuyoung.kim@samsung.com

8 edits in trunk/Source

Introduce IMAGE_TYPE_CASTS, and use it
https://bugs.webkit.org/show_bug.cgi?id=125330

Reviewed by Ryosuke Niwa.

Source/WebCore:

As a step to use TYPE_CASTS_BASE, this cl introduce IMAGE_TYPE_CASTS.
BitmapImage and SVGImage can use it to generate toFoo() type case helper functions.

No new tests, no behavior changes.

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::imageSizeForRenderer):
(WebCore::CachedImage::resumeAnimatingImagesForLoader):

platform/graphics/BitmapImage.h:
platform/graphics/Image.h:
platform/mac/DragImageMac.mm:

(WebCore::createDragImageFromImage):

svg/graphics/SVGImage.h:

Source/WebKit2:

As a step to use TYPE_CASTS_BASE, this cl introduce IMAGE_TYPE_CASTS.
BitmapImage, SVGImage can use it to generate toFoo() type case helper functions.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginSnapshotTimerFired):

9:15 PM Changeset in webkit [160211] by mark.lam@apple.com

4 edits in trunk/Source

C Loop LLINT layout test regressions.
https://bugs.webkit.org/show_bug.cgi?id=125314.

Reviewed by Geoffrey Garen.

The regression was due to the ENABLE_LLINT_C_LOOP flag not being included
in the build of the WebKit and WebKit2 components. As a result, some fields
in JSC::VM were ifdef'ed out in WebCore and JSC, but not in WebKit and
WebKit2. This resulted in VM::m_initializingObjectClass having 2 different
offsets depending on whether it is accessed from WebCore and JSC or from
WebKit and WebKit2, and chaos ensued.

This issue will manifest when we pass --cloop to build-webkit.
The fix is simply to add ENABLE_LLINT_C_LOOP to FEATURE_DEFINES for WebKit
and WebKit2.

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

7:37 PM Changeset in webkit [160210] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

Remove USE(LOCKFREE_THREADSAFEREFCOUNTED) from Atomics.cpp since it is
no longer defined.
https://bugs.webkit.org/show_bug.cgi?id=124502

Patch by Iain Lane <iain.lane@canonical.com> on 2013-12-05
Reviewed by Anders Carlsson.

wtf/Atomics.cpp:

7:18 PM Changeset in webkit [160209] by zoltan@webkit.org

3 edits in trunk/Source/WebCore

Clean up the forwarding headers of RenderBlock.h
https://bugs.webkit.org/show_bug.cgi?id=125323

Reviewed by Ryosuke Niwa.

In this patch, I removed the unnecessary forwarding headers from RenderBlock.h, and moved some to RenderBlockFlow.h.

No new tests, no behavior change.

rendering/RenderBlock.h: Remove unnecessary forwarding headers.
rendering/RenderBlockFlow.h: Moved some forwarding headers from RenderBlock.h

7:03 PM Changeset in webkit [160208] by oliver@apple.com

83 edits in trunk/Source

Refactor static getter function prototype to include thisValue in addition to the base object
https://bugs.webkit.org/show_bug.cgi?id=124461

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add thisValue parameter to static getter prototype, and switch
from JSValue to EncodedJSValue for parameters and return value.

Currently none of the static getters use the thisValue, but
separating out the refactoring will prevent future changes
from getting lost in the noise of refactoring. This means
that this patch does not result in any change in behaviour.

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:

(JSC::::asCallbackObject):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):

jit/JITOperations.cpp:
runtime/JSActivation.cpp:

(JSC::JSActivation::argumentsGetter):

runtime/JSActivation.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::argumentsGetter):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::lengthGetter):
(JSC::JSFunction::nameGetter):

runtime/JSFunction.h:
runtime/JSObject.h:

(JSC::PropertySlot::getValue):

runtime/NumberConstructor.cpp:

(JSC::numberConstructorNaNValue):
(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):
(JSC::numberConstructorMaxValue):
(JSC::numberConstructorMinValue):

runtime/PropertySlot.h:
runtime/RegExpConstructor.cpp:

(JSC::asRegExpConstructor):
(JSC::regExpConstructorDollar1):
(JSC::regExpConstructorDollar2):
(JSC::regExpConstructorDollar3):
(JSC::regExpConstructorDollar4):
(JSC::regExpConstructorDollar5):
(JSC::regExpConstructorDollar6):
(JSC::regExpConstructorDollar7):
(JSC::regExpConstructorDollar8):
(JSC::regExpConstructorDollar9):
(JSC::regExpConstructorInput):
(JSC::regExpConstructorMultiline):
(JSC::regExpConstructorLastMatch):
(JSC::regExpConstructorLastParen):
(JSC::regExpConstructorLeftContext):
(JSC::regExpConstructorRightContext):

runtime/RegExpObject.cpp:

(JSC::asRegExpObject):
(JSC::regExpObjectGlobal):
(JSC::regExpObjectIgnoreCase):
(JSC::regExpObjectMultiline):
(JSC::regExpObjectSource):

Source/WebCore:

Change bindings codegen to produce static getter functions
with the correct types. Also update the many custom implementations
to the new type.

No change in behaviour.

bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::cssPropertyGetterPixelOrPosPrefixCallback):
(WebCore::cssPropertyGetterCallback):

bindings/js/JSDOMBinding.cpp:

(WebCore::objectToStringFunctionGetter):

bindings/js/JSDOMBinding.h:
bindings/js/JSDOMMimeTypeArrayCustom.cpp:

(WebCore::JSDOMMimeTypeArray::nameGetter):

bindings/js/JSDOMPluginArrayCustom.cpp:

(WebCore::JSDOMPluginArray::nameGetter):

bindings/js/JSDOMPluginCustom.cpp:

(WebCore::JSDOMPlugin::nameGetter):

bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::nameGetter):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::nonCachingStaticFunctionGetter):
(WebCore::childFrameGetter):
(WebCore::indexGetter):
(WebCore::namedItemGetter):

bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::JSHTMLAllCollection::nameGetter):

bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::JSHTMLCollection::nameGetter):

bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

bindings/js/JSHTMLFormControlsCollectionCustom.cpp:

(WebCore::JSHTMLFormControlsCollection::nameGetter):

bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::nameGetter):

bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::nameGetter):

bindings/js/JSHistoryCustom.cpp:

(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):

bindings/js/JSJavaScriptCallFrameCustom.cpp:

(WebCore::JSJavaScriptCallFrame::scopeType):

bindings/js/JSLocationCustom.cpp:

(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):

bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::nameGetter):

bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeList::nameGetter):

bindings/js/JSPluginElementFunctions.cpp:

(WebCore::pluginElementPropertyGetter):

bindings/js/JSPluginElementFunctions.h:
bindings/js/JSRTCStatsResponseCustom.cpp:

(WebCore::JSRTCStatsResponse::nameGetter):

bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::nameGetter):

bindings/js/JSStyleSheetListCustom.cpp:

(WebCore::JSStyleSheetList::nameGetter):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateParametersCheck):

bridge/runtime_array.cpp:

(JSC::RuntimeArray::lengthGetter):
(JSC::RuntimeArray::indexGetter):

bridge/runtime_array.h:
bridge/runtime_method.cpp:

(JSC::RuntimeMethod::lengthGetter):

bridge/runtime_method.h:
bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::fallbackObjectGetter):
(JSC::Bindings::RuntimeObject::fieldGetter):
(JSC::Bindings::RuntimeObject::methodGetter):

bridge/runtime_object.h:

Source/WebKit2:

Update the WK2 JSC usage to the new static getter API

WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::callMethod):

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::callNPJSObject):
(WebKit::constructWithConstructor):
(WebKit::JSNPObject::propertyGetter):
(WebKit::JSNPObject::methodGetter):

WebProcess/Plugins/Netscape/JSNPObject.h:
WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::getOrCreateNPObject):
(WebKit::NPRuntimeObjectMap::finalize):

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::frameForContext):
(WebKit::WebFrame::counterValue):

6:52 PM Changeset in webkit [160207] by timothy_horton@apple.com

9 edits in trunk/Source/WebCore

Remove Image::decodedSize()
https://bugs.webkit.org/show_bug.cgi?id=125327

Reviewed by Sam Weinig.

No new tests, just removing dead code.

platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::resetAnimation):

platform/graphics/BitmapImage.h:
platform/graphics/GeneratedImage.h:
platform/graphics/Image.h:
platform/graphics/cg/PDFDocumentImage.cpp:
platform/graphics/cg/PDFDocumentImage.h:
svg/graphics/SVGImage.h:
svg/graphics/SVGImageForContainer.h:

5:50 PM Changeset in webkit [160206] by Csaba Osztrogonác

2 edits in trunk/Tools

Disable WebKit2 webkitpy unittests on Windows
https://bugs.webkit.org/show_bug.cgi?id=125318

Reviewed by Ryosuke Niwa.

Scripts/webkitpy/test/main.py:

(main):

5:47 PM Changeset in webkit [160205] by fpizlo@apple.com

11 edits
12 adds in trunk

FTL should use cvttsd2si directly for double-to-int32 conversions
https://bugs.webkit.org/show_bug.cgi?id=125275

Source/JavaScriptCore:

Reviewed by Michael Saboff.

Wow. This was an ordeal. Using cvttsd2si was actually easy, but I learned, and
sometimes even fixed, some interesting things:

The llvm.x86.sse2.cvttsd2si intrinsic can actually result in LLVM emitting a vcvttsd2si. I guess the intrinsic doesn't actually imply the instruction.

That whole thing about branchTruncateDoubleToUint32? Yeah we don't need that. It's better to use branchTruncateDoubleToInt32 instead. It has the right semantics for all of its callers (err, its one-and-only caller), and it's more likely to take fast path. This patch kills branchTruncateDoubleToUint32.

"a[i] = v; v = a[i]". Does this change v? OK, assume that 'a[i]' is a pure-ish operation - like an array access with 'i' being an integer index and we're not having a bad time. Now does this change v? CSE assumes that it doesn't. That's wrong. If 'a' is a typed array - the most sensible and pure kind of array - then this can be a truncating cast. For example 'v' could be a double and 'a' could be an integer array.

"v1 = a[i]; v2 = a[i]". Is v1 === v2 assuming that 'a[i]' is pure-ish? The answer is no. You could have a different arrayMode in each access. I know this sounds weird, but with concurrent JIT that might happen.

This patch adds tests for all of this stuff, except for the first issue (it's weird
but probably doesn't matter) and the last issue (it's too much of a freakshow).

assembler/MacroAssemblerARM64.h:
assembler/MacroAssemblerARMv7.h:
assembler/MacroAssemblerX86Common.h:
dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

ftl/FTLAbbreviations.h:

(JSC::FTL::vectorType):
(JSC::FTL::getUndef):
(JSC::FTL::buildInsertElement):

ftl/FTLIntrinsicRepository.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::doubleToInt32):
(JSC::FTL::LowerDFGToLLVM::doubleToUInt32):
(JSC::FTL::LowerDFGToLLVM::sensibleDoubleToInt32):

ftl/FTLOutput.h:

(JSC::FTL::Output::insertElement):
(JSC::FTL::Output::hasSensibleDoubleToInt):
(JSC::FTL::Output::sensibleDoubleToInt):

LayoutTests:

Reviewed by Michael Saboff.

js/regress/double-to-int32-typed-array-expected.txt: Added.
js/regress/double-to-int32-typed-array-no-inline-expected.txt: Added.
js/regress/double-to-int32-typed-array-no-inline.html: Added.
js/regress/double-to-int32-typed-array.html: Added.
js/regress/double-to-uint32-typed-array-expected.txt: Added.
js/regress/double-to-uint32-typed-array-no-inline-expected.txt: Added.
js/regress/double-to-uint32-typed-array-no-inline.html: Added.
js/regress/double-to-uint32-typed-array.html: Added.
js/regress/script-tests/double-to-int32-typed-array-no-inline.js: Added.

(foo):
(test):

js/regress/script-tests/double-to-int32-typed-array.js: Added.

(foo):
(test):

js/regress/script-tests/double-to-uint32-typed-array-no-inline.js: Added.

(foo):
(test):

js/regress/script-tests/double-to-uint32-typed-array.js: Added.

(foo):
(test):

5:19 PM Changeset in webkit [160204] by commit-queue@webkit.org

51 edits in trunk/Source

Unreviewed, rolling out r160133.
http://trac.webkit.org/changeset/160133
https://bugs.webkit.org/show_bug.cgi?id=125325

broke bindings tests on all the bots (Requested by thorton on
#webkit).

Source/JavaScriptCore:

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:

(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):

jit/JITOperations.cpp:
runtime/JSActivation.cpp:

(JSC::JSActivation::argumentsGetter):

runtime/JSActivation.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::argumentsGetter):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::lengthGetter):
(JSC::JSFunction::nameGetter):

runtime/JSFunction.h:
runtime/JSObject.h:

(JSC::PropertySlot::getValue):

runtime/NumberConstructor.cpp:

(JSC::numberConstructorNaNValue):
(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):
(JSC::numberConstructorMaxValue):
(JSC::numberConstructorMinValue):

runtime/PropertySlot.h:
runtime/RegExpConstructor.cpp:

(JSC::regExpConstructorDollar1):
(JSC::regExpConstructorDollar2):
(JSC::regExpConstructorDollar3):
(JSC::regExpConstructorDollar4):
(JSC::regExpConstructorDollar5):
(JSC::regExpConstructorDollar6):
(JSC::regExpConstructorDollar7):
(JSC::regExpConstructorDollar8):
(JSC::regExpConstructorDollar9):
(JSC::regExpConstructorInput):
(JSC::regExpConstructorMultiline):
(JSC::regExpConstructorLastMatch):
(JSC::regExpConstructorLastParen):
(JSC::regExpConstructorLeftContext):
(JSC::regExpConstructorRightContext):

runtime/RegExpObject.cpp:

(JSC::regExpObjectGlobal):
(JSC::regExpObjectIgnoreCase):
(JSC::regExpObjectMultiline):
(JSC::regExpObjectSource):

Source/WebCore:

bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::cssPropertyGetterPixelOrPosPrefixCallback):
(WebCore::cssPropertyGetterCallback):

bindings/js/JSDOMBinding.cpp:

(WebCore::objectToStringFunctionGetter):

bindings/js/JSDOMBinding.h:
bindings/js/JSDOMMimeTypeArrayCustom.cpp:

(WebCore::JSDOMMimeTypeArray::nameGetter):

bindings/js/JSDOMPluginArrayCustom.cpp:

(WebCore::JSDOMPluginArray::nameGetter):

bindings/js/JSDOMPluginCustom.cpp:

(WebCore::JSDOMPlugin::nameGetter):

bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::nameGetter):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::nonCachingStaticFunctionGetter):
(WebCore::childFrameGetter):
(WebCore::indexGetter):
(WebCore::namedItemGetter):

bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::JSHTMLAllCollection::nameGetter):

bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::JSHTMLCollection::nameGetter):

bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

bindings/js/JSHTMLFormControlsCollectionCustom.cpp:

(WebCore::JSHTMLFormControlsCollection::nameGetter):

bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::nameGetter):

bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::nameGetter):

bindings/js/JSHistoryCustom.cpp:

(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):

bindings/js/JSJavaScriptCallFrameCustom.cpp:

(WebCore::JSJavaScriptCallFrame::scopeType):

bindings/js/JSLocationCustom.cpp:

(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):

bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::nameGetter):

bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeList::nameGetter):

bindings/js/JSPluginElementFunctions.cpp:

(WebCore::pluginElementPropertyGetter):

bindings/js/JSPluginElementFunctions.h:
bindings/js/JSRTCStatsResponseCustom.cpp:

(WebCore::JSRTCStatsResponse::nameGetter):

bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::nameGetter):

bindings/js/JSStyleSheetListCustom.cpp:

(WebCore::JSStyleSheetList::nameGetter):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateParametersCheck):

bridge/runtime_array.cpp:

(JSC::RuntimeArray::lengthGetter):
(JSC::RuntimeArray::indexGetter):

bridge/runtime_array.h:
bridge/runtime_method.cpp:

(JSC::RuntimeMethod::lengthGetter):

bridge/runtime_method.h:
bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::fallbackObjectGetter):
(JSC::Bindings::RuntimeObject::fieldGetter):
(JSC::Bindings::RuntimeObject::methodGetter):

bridge/runtime_object.h:

Source/WebKit2:

WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::callMethod):

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::callNPJSObject):
(WebKit::constructWithConstructor):
(WebKit::JSNPObject::propertyGetter):
(WebKit::JSNPObject::methodGetter):

WebProcess/Plugins/Netscape/JSNPObject.h:
WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::getOrCreateNPObject):
(WebKit::NPRuntimeObjectMap::finalize):

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::counterValue):

5:09 PM Changeset in webkit [160203] by Seokju Kwon

7 edits in trunk/Source

Web Inspector: Remove 'cookiesString' output from Page.getCookies
https://bugs.webkit.org/show_bug.cgi?id=125268

Reviewed by Timothy Hatcher.

Remove 'cookiesString' output from Page.getCookies protocol.
It is no longer meaningful because it is an unused parameter.

Source/WebCore:

No new tests, no behavior change.

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies):

inspector/InspectorPageAgent.h:
inspector/protocol/Page.json:

Source/WebInspectorUI:

UserInterface/CookieStorageContentView.js:

(WebInspector.CookieStorageContentView.prototype.update):

UserInterface/InspectorBackendCommands.js:

4:57 PM Changeset in webkit [160202] by commit-queue@webkit.org

8 edits in trunk/Source

Web Inspector: expose node and frame snapshot capabilities.
https://bugs.webkit.org/show_bug.cgi?id=124326

Patch by Brian J. Burg <Brian Burg> on 2013-12-05
Reviewed by Joseph Pecoraro.

Source/WebCore:

This adds snapshotRect() and snapshotNode() to the Page domain.
Both methods create snapshots using FrameSnapshotting APIs
and send images to the inspector frontend as a data URL.

Remove the unimplemented Page.captureScreenshot API.

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::snapshotNode): Added.
(WebCore::InspectorPageAgent::snapshotRect): Added.

inspector/InspectorPageAgent.h:
inspector/protocol/Page.json: Added new protocol APIs.

Source/WebInspectorUI:

Add method signatures for snapshotNode() and snapshotRect().
Remove method signature for unimplemented Page.captureScreenshot.

UserInterface/InspectorBackendCommands.js:

4:25 PM Changeset in webkit [160201] by bshafiei@apple.com

5 edits in branches/safari-537.60-branch/Source

Versioning.

3:48 PM Changeset in webkit [160200] by betravis@adobe.com

7 edits in trunk

Source/WebCore: [CSS Shapes] Enable CSS Shapes on Windows

https://bugs.webkit.org/show_bug.cgi?id=89957

Reviewed by Brent Fulgham.

css/CSSPropertyNames.in: Tweak to ensure shapes properties are regenerated.

WebKitLibraries: [CSS Shapes] Enable CSS Shapes on Windows
https://bugs.webkit.org/show_bug.cgi?id=89957

Reviewed by Brent Fulgham.

Turn on CSS_SHAPES on Windows now that bug 121883 has been fixed.

win/tools/vsprops/FeatureDefines.props:
win/tools/vsprops/FeatureDefinesCairo.props:

LayoutTests: [CSS Shapes] Enable CSS Shapes on Windows
https://bugs.webkit.org/show_bug.cgi?id=89957

Reviewed by Brent Fulgham.

Turning shapes tests back on on Windows builds.

platform/win/TestExpectations: Enable shapes tests.

3:45 PM Changeset in webkit [160199] by roger_fong@apple.com

7 edits in trunk

[WebGL] Make sure we satisfy uniform and varying packing restrictions.
https://bugs.webkit.org/show_bug.cgi?id=125124.
<rdar://problem/15203291>

Reviewed by Brent Fulgham.

Tests covered by WebGL Khronos conformance tests:
webgl/1.0.2/conformance/glsl/misc/shader-uniform-packing-restrictions.html
webgl/1.0.2/conformance/glsl/misc/shader-varying-packing-restrictions.html

platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

src/compiler/Compiler.cpp:

Add a check to enforcePackingRestrictions to ensure we make sure packing restrictions for varyings are satisfied as well.
(TCompiler::TCompiler):
(TCompiler::Init):
(TCompiler::compile):
(TCompiler::enforcePackingRestrictions):

src/compiler/ShHandle.h: Keep track of maximum varying vectors.
platform/mac/TestExpectations: Unskip some 1.0.2 WebGL conformance tests that should now be passing.

Skip conformance/ogles/GL/build/build_009_to_016.html which is a faulty test and has too many varyings in one shader.

3:37 PM Changeset in webkit [160198] by Alexandru Chiculita

12 edits
6 adds in trunk

Web Inspector: [CSS Regions] Show a list of containing regions when clicking a node that is part of a flow
https://bugs.webkit.org/show_bug.cgi?id=124614

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

Added a new function in DOMTreeManager called getNodeContentFlowInfo that can be used
to retrieve an object with the following structure:
{

"regionFlow": <Reference to the ContentFlow object referenced by the -webkit-flow-from property of the node>,
"contentFlow": <Reference to the ContentFlow object referenced by the -webkit-flow-into property of

the node or a parent of the node>,

"regions": [ list of DOMNodes representing the regions containers of the node. The node is split across all these regions. ]

}

Also, used this method to display a two new sections in the Computed Styles panel.

Section "Flows": can have up to two Simple Rows: "Region Flow" and "Content Flow".
Section "Container Regions" contains a DOMTreeDataGrid with the list of regions.

The sections are only visible when there's content to display.

Next to the "Region Flow" simple row I've added an arrow that will take the user to the "ContentFlowDOMTreeContentView" of the
ContentFlow. The same happens for the "Content Flow", but in this case the element will also be highlighted.

Part of the patch I've added the DOMTreeDataGridNode. LayerTreeDataGrid has a lot of CSS in common with it, so I
will make another patch to refactor LayerTreeDataGrid to use DOMTreeDataGridNode as a base class.

Localizations/en.lproj/localizedStrings.js:
UserInterface/ComputedStyleDetailsPanel.css: Added.

(.details-section > .content > .group > .row.simple.content-flow-link > .label):
(.details-section > .content > .group > .row.simple.content-flow-link > .value):
(.details-section > .content > .group > .row.simple.content-flow-link > .value > div):
(.details-section > .content > .group > .row.simple.content-flow-link > .value > div > .icon):
(.details-section > .content > .group > .row.simple.content-flow-link > .value > div > span):
(.details-section > .content > .group > .row.simple.content-flow-link > .value > div > .go-to-arrow):
(.details-section > .content > .group > .row.simple.content-flow-link:hover > .value > div > .go-to-arrow):

UserInterface/ComputedStyleDetailsPanel.js:

(WebInspector.ComputedStyleDetailsPanel):
(WebInspector.ComputedStyleDetailsPanel.prototype.get regionFlow):
(WebInspector.ComputedStyleDetailsPanel.prototype.set regionFlow):
(WebInspector.ComputedStyleDetailsPanel.prototype.get contentFlow):
(WebInspector.ComputedStyleDetailsPanel.prototype.set contentFlow):
(WebInspector.ComputedStyleDetailsPanel.prototype.get containerRegions):
(WebInspector.ComputedStyleDetailsPanel.prototype.set containerRegions):
(WebInspector.ComputedStyleDetailsPanel.prototype.refresh):
(WebInspector.ComputedStyleDetailsPanel.prototype._computedStyleShowAllCheckboxValueChanged):
(WebInspector.ComputedStyleDetailsPanel.prototype._resetFlowDetails):
(WebInspector.ComputedStyleDetailsPanel.prototype._refreshFlowDetails.contentFlowInfoReady):
(WebInspector.ComputedStyleDetailsPanel.prototype._refreshFlowDetails):
(WebInspector.ComputedStyleDetailsPanel.prototype._goToRegionFlowArrowWasClicked):
(WebInspector.ComputedStyleDetailsPanel.prototype._goToContentFlowArrowWasClicked):

UserInterface/DOMTreeDataGrid.css: Added.

(.dom-tree-data-grid .data-grid):
(.dom-tree-data-grid .data-grid table.data):
(.dom-tree-data-grid .data-container):
(.dom-tree-data-grid .data-container tr):
(.dom-tree-data-grid .data-container td > div):
(.dom-tree-data-grid .data-container .name-column):
(.dom-tree-data-grid .data-container .name-column .icon):
(.dom-tree-data-grid .data-container .name-column .label):
(.dom-tree-data-grid .data-container tr:hover .name-column .label):
(.dom-tree-data-grid .data-container .go-to-arrow):
(.dom-tree-data-grid .data-container tr:hover .go-to-arrow):
(.dom-tree-data-grid .data-container tbody > tr:nth-child(2n)):
(.dom-tree-data-grid .data-container tbody > tr:nth-child(2n+1)):

UserInterface/DOMTreeDataGrid.js: Added.

(WebInspector.DOMTreeDataGrid):
(WebInspector.DOMTreeDataGrid.prototype._onmousemove):
(WebInspector.DOMTreeDataGrid.prototype._onmouseout):

UserInterface/DOMTreeDataGridNode.js: Added.

(WebInspector.DOMTreeDataGridNode):
(WebInspector.DOMTreeDataGridNode.prototype.get domNode):
(WebInspector.DOMTreeDataGridNode.prototype.createCellContent):
(WebInspector.DOMTreeDataGridNode.prototype._updateNodeName):
(WebInspector.DOMTreeDataGridNode.prototype._makeNameCell):
(WebInspector.DOMTreeDataGridNode.prototype._updateNameCellData):
(WebInspector.DOMTreeDataGridNode.prototype._goToArrowWasClicked):

UserInterface/DOMTreeManager.js:

(WebInspector.DOMTreeManager.prototype.unregisteredNamedFlowContentElement):
(WebInspector.DOMTreeManager.prototype.nodeRequested):
(WebInspector.DOMTreeManager.prototype._coerceRemoteArrayOfDOMNodes):
(WebInspector.DOMTreeManager.prototype.domNodeResolved):
(WebInspector.DOMTreeManager.prototype.regionNodesAvailable):
(WebInspector.DOMTreeManager.prototype.get if):
(WebInspector.DOMTreeManager.prototype.get var):
(WebInspector.DOMTreeManager.prototype.backendFunction.getComputedProperty):
(WebInspector.DOMTreeManager.prototype.backendFunction.getContentFlowName):
(WebInspector.DOMTreeManager.prototype.):

UserInterface/DataGrid.css:

(.data-grid.no-header > table.header):
(.data-grid.no-header .data-container):

UserInterface/DetailsSection.js:

(WebInspector.DetailsSection):

UserInterface/InspectorBackend.js:

(InspectorBackendClass.prototype._wrap):

UserInterface/Main.html:
UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype.showContentFlowDOMTree):

UserInterface/RuntimeManager.js:

(WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
(WebInspector.RuntimeManager.prototype.getPropertiesForRemoteObject):

LayoutTests:

Added a new test to check the new WebInspector function called DOMTreeManager.getNodeContentFlowInfo.

http/tests/inspector-protocol/resources/InspectorTest.js:

When testing the inspector code, we want to catch and log any uncaught exceptions or console.errors/asserts.
(InspectorTest.importInspectorScripts.console.error.window.onerror):
(InspectorTest.importInspectorScripts.console.assert):
(InspectorTest.importInspectorScripts):

inspector-protocol/model/content-node-region-info-expected.txt: Added.
inspector-protocol/model/content-node-region-info.html: Added.

3:33 PM Changeset in webkit [160197] by Chris Fleizach

3 edits in trunk/Source/WebKit2

AX: Seed: safari extension installation crashes safari under voice over and freezes voice over
https://bugs.webkit.org/show_bug.cgi?id=125308

Reviewed by Anders Carlsson.

Much like Javascript alerts, we need to allow accessibility clients to continue to interact with the WebProcess thread
when using dispatchDecidePolicyResponses.

Platform/CoreIPC/MessageSender.h:

(CoreIPC::MessageSender::sendSync):

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

3:12 PM Changeset in webkit [160196] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

32bit buildfix after r160151
https://bugs.webkit.org/show_bug.cgi?id=125298

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-12-05
Reviewed by Csaba Osztrogonác.

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::handleDataReceived):

3:04 PM Changeset in webkit [160195] by matthew_hanson@apple.com

5 edits in tags/Safari-538.8/Source/ThirdParty/ANGLE

Merge r160194.

2:55 PM Changeset in webkit [160194] by matthew_hanson@apple.com

5 edits in trunk/Source/ThirdParty/ANGLE

Fix ANGLE build failures by re-comitting the changes in http://trac.webkit.org/changeset/154223
on top of the library updates introduced by http://trac.webkit.org/changeset/159533.

Rubber-stamped by Babak Shafiei.

src/compiler/glslang.l:
src/compiler/glslang_lex.cpp:
src/compiler/preprocessor/Tokenizer.cpp:
src/compiler/preprocessor/Tokenizer.l:

2:30 PM Changeset in webkit [160193] by andersca@apple.com

3 edits in trunk/Source/WebKit2

"Use Selection for Find" doesn't work in PDF viewed in Safari
https://bugs.webkit.org/show_bug.cgi?id=125319
<rdar://problem/15486983>

Reviewed by Tim Horton.

WebProcess/Plugins/PDF/PDFPlugin.h:
WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFLayerControllerDelegate writeItemsToPasteboard:withTypes:]):
Pass NSGeneralPboard to writeItemsToPasteboard.

(WebKit::PDFPlugin::handleEditingCommand):
Handle takeFindStringFromSelection by getting the current selection string and writing it to the find pasteboard.

(WebKit::PDFPlugin::isEditingCommandEnabled):
Handle takeFindStringFromSelection.

(WebKit::PDFPlugin::writeItemsToPasteboard):
Update this to take a pasteboard name.

1:59 PM Changeset in webkit [160192] by bshafiei@apple.com

1 copy in tags/Safari-537.60.11

New tag.

1:38 PM Changeset in webkit [160191] by andersca@apple.com

6 edits in trunk/Source/WebKit2

WebKit2 API should use weak ownership for delegate properties rather than assign
https://bugs.webkit.org/show_bug.cgi?id=125316
<rdar://problem/15560614>

Reviewed by Dan Bernstein.

Use WeakObjCPtr for the delegates.

UIProcess/API/Cocoa/WKBrowsingContextController.h:
UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didCommitLoadForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didStartProgress):
(didChangeProgress):
(didFinishProgress):
(didChangeBackForwardList):
(setUpPagePolicyClient):
(-[WKBrowsingContextController loadDelegate]):
(-[WKBrowsingContextController setLoadDelegate:]):
(-[WKBrowsingContextController policyDelegate]):
(-[WKBrowsingContextController setPolicyDelegate:]):
(-[WKBrowsingContextController historyDelegate]):
(-[WKBrowsingContextController setHistoryDelegate:]):

UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h:
UIProcess/API/Cocoa/WKConnection.mm:

(didReceiveMessage):
(didClose):
(-[WKConnection delegate]):
(-[WKConnection setDelegate:]):

UIProcess/API/Cocoa/WKProcessGroup.mm:

(didCreateConnection):
(getInjectedBundleInitializationUserData):
(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):
(-[WKProcessGroup delegate]):
(-[WKProcessGroup setDelegate:]):

1:15 PM Changeset in webkit [160190] by Brent Fulgham

4 edits in branches/safari-537.60-branch/Source/WebKit

../WebKit: Merge build fix r160188

2013-12-05 Brent Fulgham <Brent Fulgham>

[Win] Avoid copying compiled-in resources to DSTROOT
https://bugs.webkit.org/show_bug.cgi?id=125309

Reviewed by Jer Noble.

WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Only copy Info.plist to the final WebKit.resource bundle. The PNG and RC files are compiled into the WebKit.dll library.

../WebKit/win: Merge r160184

2013-12-04 Brent Fulgham <Brent Fulgham>

[Win] Exiting from Media Full Screen mode via 'escape' key does not work properly
https://bugs.webkit.org/show_bug.cgi?id=125272

Reviewed by Jer Noble.

WebView.cpp: (WebView::fullScreenClientWillExitFullScreen): Change to webkitCancelFullScreen method call to more closely match Media Control behavior.

12:44 PM Changeset in webkit [160189] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Cropping and drawing ImageBuffers results in uninitialized data being shown
https://bugs.webkit.org/show_bug.cgi?id=125271

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-12-05
Reviewed by Simon Fraser.

createCroppedImageIfNecessary() crops to the bottom left of the ImageBuffer
backing store instead of the top left. In addition, ImageBuffer::draw()
draws the entire ImageBuffer's backing store instead of just the relevant
portion of it.

No new tests are necessary because the existing tests already test this
functionality

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::createCroppedImageIfNecessary): Crop to the top left of the
backing store
(WebCore::ImageBuffer::draw): Draw only the logical portion of the
backing store

12:42 PM Changeset in webkit [160188] by Brent Fulgham

2 edits in trunk/Source/WebKit

[Win] Avoid copying compiled-in resources to DSTROOT
https://bugs.webkit.org/show_bug.cgi?id=125309

Reviewed by Jer Noble.

WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Only copy Info.plist to the final WebKit.resource bundle.

The PNG and RC files are compiled into the WebKit.dll library.

12:40 PM Changeset in webkit [160187] by andersca@apple.com

4 edits in trunk

Tweak WeakObjCPtr
https://bugs.webkit.org/show_bug.cgi?id=125311

Reviewed by Darin Adler.

Source/WebKit2:

Make it possible to use WeakObjCPtr with pointer types such as id. Also,
add a getAutoreleased() member that will load the weak pointer and retain + autorelease it.

Shared/mac/WeakObjCPtr.h:

(WebKit::WeakObjCPtr::WeakObjCPtr):
(WebKit::WeakObjCPtr::operator=):
(WebKit::WeakObjCPtr::get):
(WebKit::WeakObjCPtr::getAutoreleased):

Tools:

Split up tests into more logical groups. Add new tests for new functionality.

TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:

12:33 PM Changeset in webkit [160186] by mark.lam@apple.com

22 edits in trunk/Source/JavaScriptCore

Make the C Loop LLINT work with callToJavaScript.
https://bugs.webkit.org/show_bug.cgi?id=125294.

Reviewed by Michael Saboff.

Changed the C Loop LLINT to dispatch to an Executable via its JITCode instance which is consistent with how the ASM LLINT works.
Changed CLoop::execute() to take an Opcode instead of an OpcodeID. This makes it play nice with the use of JITCode for dispatching.
Introduce a callToJavaScript and callToNativeFunction for the C Loop LLINT. These will call JSStack::pushFrame() and popFrame() to setup and teardown the CallFrame.
Also introduced a C Loop returnFromJavaScript which is just a replacement for ctiOpThrowNotCaught which had the same function.
Remove a lot of #if ENABLE(LLINT_C_LOOP) code now that the dispatch mechanism is consistent.

This patch has been tested with both configurations of COMPUTED_GOTOs
on and off.

interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall):
(JSC::CachedCall::call):
(JSC::CachedCall::setArgument):

interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::setThis):
(JSC::CallFrameClosure::setArgument):
(JSC::CallFrameClosure::resetCallFrame):

interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):

interpreter/Interpreter.h:
interpreter/JSStack.h:
interpreter/JSStackInlines.h:

(JSC::JSStack::pushFrame):

interpreter/ProtoCallFrame.h:

(JSC::ProtoCallFrame::scope):
(JSC::ProtoCallFrame::callee):
(JSC::ProtoCallFrame::thisValue):
(JSC::ProtoCallFrame::argument):
(JSC::ProtoCallFrame::setArgument):

jit/JITCode.cpp:

(JSC::JITCode::execute):

jit/JITCode.h:
jit/JITExceptions.cpp:

(JSC::genericUnwind):

llint/LLIntCLoop.cpp:

(JSC::LLInt::CLoop::initialize):

llint/LLIntCLoop.h:
llint/LLIntEntrypoint.cpp:

(JSC::LLInt::setFunctionEntrypoint):
(JSC::LLInt::setEvalEntrypoint):
(JSC::LLInt::setProgramEntrypoint):

Inverted the check for vm.canUseJIT(). This allows the JIT case to be #if'd out nicely when building the C Loop LLINT.
llint/LLIntOpcode.h:
llint/LLIntThunks.cpp:

(JSC::doCallToJavaScript):
(JSC::executeJS):
(JSC::callToJavaScript):
(JSC::executeNative):
(JSC::callToNativeFunction):

llint/LLIntThunks.h:
llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

runtime/Executable.h:

(JSC::ExecutableBase::offsetOfNumParametersFor):
(JSC::ExecutableBase::hostCodeEntryFor):
(JSC::ExecutableBase::jsCodeEntryFor):
(JSC::ExecutableBase::jsCodeWithArityCheckEntryFor):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
(JSC::ProgramExecutable::generatedJITCode):

runtime/JSArray.cpp:

(JSC::AVLTreeAbstractorForArrayCompare::compare_key_key):

runtime/StringPrototype.cpp:

(JSC::replaceUsingRegExpSearch):

runtime/VM.cpp:

(JSC::VM::getHostFunction):

12:27 PM Changeset in webkit [160185] by zoltan@webkit.org

3 edits in trunk/LayoutTests

[CSS Shapes] Update negative-arguments inset parsing test to test for the argument not for the commas
https://bugs.webkit.org/show_bug.cgi?id=125310

Reviewed by Rob Buis.

Fix typo in the negative-arguments inset tests, remove commas.

fast/shapes/parsing/parsing-shape-lengths-expected.txt:
fast/shapes/parsing/parsing-shape-lengths.html:

12:14 PM Changeset in webkit [160184] by Brent Fulgham

2 edits in trunk/Source/WebKit/win

[Win] Exiting from Media Full Screen mode via 'escape' key does not work properly
https://bugs.webkit.org/show_bug.cgi?id=125272

Reviewed by Jer Noble.

WebView.cpp:

(WebView::fullScreenClientWillExitFullScreen): Change to webkitCancelFullScreen method call
to more closely match Media Control behavior.

11:48 AM Changeset in webkit [160183] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Remove stale ScriptGlobalObject methods
https://bugs.webkit.org/show_bug.cgi?id=125276

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-05
Reviewed by Sam Weinig.

bindings/js/ScriptObject.cpp:

(WebCore::ScriptGlobalObject::set):

bindings/js/ScriptObject.h:

11:45 AM Changeset in webkit [160182] by rniwa@webkit.org

6 edits
2 adds in trunk

Change how the form element pointer affects parsing template elements, to reduce weirdness in templates
https://bugs.webkit.org/show_bug.cgi?id=125279

Reviewed by Antti Koivisto.

Source/WebCore:

Faithfully update the HTML5 parser after http://html5.org/tools/web-apps-tracker?from=8330&to=8331.

Test: fast/dom/HTMLTemplateElement/no-form-association-2.html

html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLFormElement): Don't the form element pointer if the context
element or its ancestor is a template element.
(WebCore::HTMLConstructionSite::insideTemplateElement): Added.
(WebCore::HTMLConstructionSite::createHTMLElement): Renamed openElementsContainTemplateElement to
insideTemplateElement to reflect the true semantics of the boolean.

html/parser/HTMLConstructionSite.h:

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody): Ignore the form element pointer if there
is a template element on the stack of open elements. This faithfully reflects what's being said in the
specification. We should probably make isParsingTemplateContents more efficient by storing a boolean
and then wrap from() in some helper function but that should probbaly happen in a separate patch.
(WebCore::HTMLTreeBuilder::processStartTagForInBody): Ditto.
(WebCore::HTMLTreeBuilder::processStartTagForInTable): Ditto.
(WebCore::HTMLTreeBuilder::processEndTagForInBody): Don't unset or rely on the form element pointer
when there is a template element on the stack of open elements.

html/parser/HTMLTreeBuilder.h:

(WebCore::HTMLTreeBuilder::isParsingTemplateContents): Added a trivial implementation for when
TEMPLATE_ELEMENT is disabled.
(WebCore::HTMLTreeBuilder::isParsingFragmentOrTemplateContents): Merged two implementations.

LayoutTests:

Added a regression test. Someone should port this test into web-platform-tests once the latest spec.
change has been refelcted to a working draft version of the HTML5 specification.

fast/dom/HTMLTemplateElement/no-form-association-2-expected.txt: Added.
fast/dom/HTMLTemplateElement/no-form-association-2.html: Added.

11:23 AM Changeset in webkit [160181] by commit-queue@webkit.org

11 edits in trunk

[MediaStream] Firing negotiationneeded event upon track add/remove on MediaStream
https://bugs.webkit.org/show_bug.cgi?id=125243

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-12-05
Reviewed by Eric Carlson.

Spec states that: In particular, if an RTCPeerConnection object is consuming a MediaStream on which a track is
added, by, e.g., the addTrack() method being invoked, the RTCPeerConnection object must fire the
"negotiationneeded" event. Removal of media components must also trigger "negotiationneeded".

Source/WebCore:

Existing tests updated.

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::addObserver):
(WebCore::MediaStream::removeObserver):

Modules/mediastream/MediaStream.h:
Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::~RTCPeerConnection):
(WebCore::RTCPeerConnection::addStream):
(WebCore::RTCPeerConnection::removeStream):
(WebCore::RTCPeerConnection::didAddOrRemoveTrack):

Modules/mediastream/RTCPeerConnection.h:
platform/mock/RTCPeerConnectionHandlerMock.cpp:

(WebCore::RTCPeerConnectionHandlerMock::addStream):

LayoutTests:

fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt:
fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:

10:32 AM Changeset in webkit [160180] by Hugo Parente Lima

2 edits in trunk/Tools/Scripts

[Unreviewed] Turn on executable bits of Tools/Scripts/run-nix-tests and Tools/Scripts/update-webkitnix-libs

9:57 AM Changeset in webkit [160179] by Beth Dakin

3 edits in trunk/Source/WebCore

Bad repaints on twitter when the tile cache has a margin
https://bugs.webkit.org/show_bug.cgi?id=125263
-and corresponding-
<rdar://problem/15576884>

Reviewed by Tim Horton.

When tiles that used to be margin tiles become real-content tiles, they need to be
invalidated.

Two new helper functions will make it so that we don’t have to manually factor out
the margin from the bounds in more than one place in the code.

platform/graphics/ca/mac/TileController.h:
platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::boundsWithoutMargin):
(WebCore::TileController::boundsAtLastRevalidateWithoutMargin):

Here is one existing place where we used to factor out the margin, but now we can

call boundsWithoutMargin().
(WebCore::TileController::adjustRectAtTileIndexForMargin):

And here is where we invalidate the formerly-margin tiles.
(WebCore::TileController::revalidateTiles):

9:54 AM Changeset in webkit [160178] by zoltan@webkit.org

2 edits in trunk/Source/WebCore

Remove the forward declaration of BidiContext class from RenderBlock.h
https://bugs.webkit.org/show_bug.cgi?id=125265

Reviewed by Csaba Osztrogonác.

No new tests, no behavior change.

rendering/RenderBlock.h: BidiContext is not used in RenderBlock.h

9:18 AM Changeset in webkit [160177] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Cairo] Avoid extra copy when drawing images
https://bugs.webkit.org/show_bug.cgi?id=124209

Patch by Aloisio Almeida Jr <aloisio.almeida@openbossa.org> on 2013-12-05
Reviewed by Carlos Garcia Campos.

This commit applies some changes proposed after the original patch has
been landed. It fixes the logic to create the subsurface (as it was
inverted). It also remove an unnecessary RefPtr variable to hold the
subsurface.

No new tests. It's an enhancement. Already covered by existing tests.

platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::drawSurfaceToContext):

8:48 AM Changeset in webkit [160176] by zoltan@webkit.org

4 edits in trunk

[CSS Shapes] Fix inset when only a subset of the arguments are defined
https://bugs.webkit.org/show_bug.cgi?id=125277

Reviewed by David Hyatt.

Source/WebCore:

I thought Length's default value is fixed-0, but actually it's auto-0. For the optional arguments
of inset shape, we need to use fixed-0, so I updated the code and the tests to use that explicitly.

No new tests, I updated the old ones.

css/BasicShapeFunctions.cpp:

(WebCore::basicShapeForValue):

LayoutTests:

fast/shapes/shape-outside-floats/shape-outside-floats-inset.html:

8:27 AM Changeset in webkit [160175] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Fix JavaScriptCore build if cloop is enabled after r160094
https://bugs.webkit.org/show_bug.cgi?id=125292

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-12-05
Reviewed by Michael Saboff.

Move ProtoCallFrame outside the JIT guard.

jit/JITCode.h:

6:50 AM Changeset in webkit [160174] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

[GTK] Do not use deprecated gtk-doc 'Rename to' tag
https://bugs.webkit.org/show_bug.cgi?id=125303

Reviewed by Philippe Normand.

GObject introspection rename-to annotation is available in
since version 0.6.3 so we should use that instead.

bindings/gobject/WebKitDOMEventTarget.h:

6:32 AM Changeset in webkit [160173] by Carlos Garcia Campos

2 edits in trunk/Tools

[GTK] Fix gtk-doc warnings when generating DOM bindings API docs
https://bugs.webkit.org/show_bug.cgi?id=125302

Reviewed by Philippe Normand.

gtk/generate-webkitdom-doc-files:

(WebKitDOMDocGeneratorSections.write_footer): Add a new section
containing a private subsection for WEBKIT_API, WEBKIT_DEPRECATED
and WEBKIT_DEPRECATED_FOR macros.

5:31 AM Changeset in webkit [160172] by Carlos Garcia Campos

3 edits in trunk/Source/WebCore

[GTK] Add missing symbols to WebKitDOMDeprecated.symbols
https://bugs.webkit.org/show_bug.cgi?id=125300

Reviewed by Philippe Normand.

Add webkit_dom_html_element_get_id and
webkit_dom_html_element_set_id to the symbols files.

bindings/gobject/WebKitDOMDeprecated.symbols:
bindings/gobject/webkitdom.symbols:

5:28 AM Changeset in webkit [160171] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit/gtk

[GTK] Fix GObject introspection warnings in webkitspellchecker
https://bugs.webkit.org/show_bug.cgi?id=125299

Reviewed by Philippe Normand.

webkit/webkitspellchecker.cpp: Add missing ':' after some

gobject-introspection annotations.

4:38 AM Changeset in webkit [160170] by commit-queue@webkit.org

2 edits in trunk/Tools

Fix cross compilation on x86
https://bugs.webkit.org/show_bug.cgi?id=125295

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-12-05
Reviewed by Zoltan Herczeg.

Certain compiler flags should not be added when cross compilation is enabled.

Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary):
(generateBuildSystemFromCMakeProject):

4:34 AM Changeset in webkit [160169] by Michał Pakuła vel Rutka

3 edits in trunk/LayoutTests

Unreviewed EFL gardening

After bumping GStreamer version to 1.2.1 in r160151 some video related WebGL conformance test started to pass.

platform/efl-wk2/TestExpectations:
platform/efl/TestExpectations:

4:14 AM Changeset in webkit [160168] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

Unreviewed. Update GObject DOM bindings symbols file after r159711.

bindings/gobject/webkitdom.symbols:

4:00 AM Changeset in webkit [160167] by commit-queue@webkit.org

2 edits in trunk/Tools

Remove duplicated/dead code from cpp style checker unit tests.
https://bugs.webkit.org/show_bug.cgi?id=125226

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-05
Reviewed by Ryosuke Niwa.

Remove the first definition of OrderOfIncludesTest class as it is
overwritten by the second. Remove a duplicated assert statement
from the second class.

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(OrderOfIncludesTest.setUp):
(OrderOfIncludesTest.test_try_drop_common_suffixes):

The last assert was duplicated.

3:07 AM Changeset in webkit [160166] by commit-queue@webkit.org

1 edit
1 delete in trunk/Tools

Remove Scripts/generate-qt-inspector-resource.
https://bugs.webkit.org/show_bug.cgi?id=125288

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-05
Reviewed by Andreas Kling.

Scripts/generate-qt-inspector-resource: Removed. There is no QT anymore.

We don't need this file.

2:32 AM Changeset in webkit [160165] by commit-queue@webkit.org

9 edits in trunk/Tools

Remove certain methods from TestExpectations and use TestExpectationsModel instead of them
https://bugs.webkit.org/show_bug.cgi?id=125218

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-12-05
Reviewed by Ryosuke Niwa.

Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:

(LayoutTestFinder.skip_tests):

Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.run_tests):
(LayoutTestRunner._update_summary_with_result):

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._test_is_slow):

Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator._insert_failure_summaries):

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.get_rebaselining_failures):

Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(assert_exp):
(MiscTests.test_multiple_results):
(MiscTests.test_category_expectations):
(MiscTests.test_get_modifiers):
(MiscTests.test_get_expectations_string):
(MiscTests.test_expectation_to_string):
(MiscTests.test_get_test_set):
(MiscTests.test_more_specific_override_resets_skip):
(SkippedTests.check):

Scripts/webkitpy/layout_tests/models/test_run_results.py:

(TestRunResults.init):
(summarize_results):

Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineExpectations._tests_to_rebaseline):

12:49 AM Changeset in webkit [160164] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

[GTK] Move platform sources free of layering violations under libPlatform
https://bugs.webkit.org/show_bug.cgi?id=117509

Reviewed by Carlos Garcia Campos.

GNUmakefile.list.am: Move additional source files located in the platform layer under libPlatform.

All moved sources are free of layering violations and thus ready for the migration.

12:47 AM Changeset in webkit [160163] by commit-queue@webkit.org

1 edit
1 delete in trunk/Source/WebCore

Remove bridge/testqtbindings.cpp.
https://bugs.webkit.org/show_bug.cgi?id=125287

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-05
Reviewed by Alexey Proskuryakov.

bridge/testqtbindings.cpp: Removed. There is no QT anymore.

We don't need this file.

12:47 AM Changeset in webkit [160162] by zandobersek@gmail.com

4 edits in trunk/Source/WebKit2

[GTK][WK2] Clean up WorkQueueGtk
https://bugs.webkit.org/show_bug.cgi?id=125177

Reviewed by Carlos Garcia Campos.

Clean up the GTK implementation of the WorkQueue class a bit.

registerSocketEventHandler doesn't take a condition argument anymore -- G_IO_IN was the only condition ever passed into

that method so that is now the hard-coded default.

Clean up the declarations of GTK-specific bits in the WorkQueue header file. SocketEventSourceIterator typedef is removed

and auto will be used instead.

WorkQueue::dispatchOnTermination and WorkQueue::SocketEventSource::performWorkOnTermination methods were unused and now removed.
WorkQueue::SocketEventSource doesn't expect a GIO condition anymore, and WorkQueue::SocketEventSource::checkCondition is removed.

G_IO_IN condition was the only one used is now hard-coded into the check in WorkQueue::SocketEventSource::eventCallback.

Removed an unnecessary non-null assertion for the heap-allocated SocketEventSource.
Removed a technically duplicated assertion that a file descriptor is already present in the event sources map. Moved the

assertion before the HashMap::find() call.

Removed two unnecessary assertions that non-null values are being returned by g_idle_source_new() and g_timeout_source_new().

Both functions are guaranteed to return non-null values.

Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::open):

Platform/WorkQueue.h:
Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::SocketEventSource::SocketEventSource):
(WorkQueue::SocketEventSource::eventCallback):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):

Dec 4, 2013:

11:41 PM Changeset in webkit [160161] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

Report error when #else is used in message receiver generator's input.
https://bugs.webkit.org/show_bug.cgi?id=124147

Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-12-04
Reviewed by Csaba Osztrogonác.

Scripts/webkit2/messages_unittest.py:

(UnsupportedPrecompilerDirectiveTest):
(UnsupportedPrecompilerDirectiveTest.test_error_at_else):
(UnsupportedPrecompilerDirectiveTest.test_error_at_elif):

Scripts/webkit2/parser.py:

(parse):

10:44 PM Changeset in webkit [160160] by Samuel White

4 edits in trunk/LayoutTests

Layout Test platform/mac/accessibility/search-predicate-element-count.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=125195

Reviewed by Chris Fleizach.

Our test checks for AccessibilityObject::isOnscreen which makes sure an element is currently scrolled to a visible
location onscreen. This test was flaky because sometimes elements we thought would be visible weren't. To resolve
this I've moved the elements that are tested for visibility to the very top of the document so they have a tiny
vertical offset and will ALWAYS be visible.

platform/mac/TestExpectations:
platform/mac/accessibility/search-predicate-element-count-expected.txt:
platform/mac/accessibility/search-predicate-element-count.html:

9:11 PM Changeset in webkit [160159] by commit-queue@webkit.org

3 edits
4 adds in trunk

% unit heights don't work if parent block height is set in vh
https://bugs.webkit.org/show_bug.cgi?id=118516

Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-12-04
Reviewed by Simon Fraser.

From Blink r156449 by <srinivasa.ragavan.venkateswaran@intel.com>

Source/WebCore:

An element having height as percentage needs to have the
containingblock's height or availableheight to calculate its
own height. The containing block having a height set in vh
unit was not being considered for calculating the child's
height.

Tests: fast/css/viewport-percentage-compute-box-height.html

fast/css/viewport-percentage-compute-box-width.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):
Correct child's height(in pecentage) was not being calculated
incase of parent having height set in vh unit. Added condition
to calculate the containing block height in terms of viewport size.

LayoutTests:

fast/css/viewport-percentage-compute-box-height-expected.html: Added.
fast/css/viewport-percentage-compute-box-height.html: Added.
fast/css/viewport-percentage-compute-box-width-expected.html: Added.
fast/css/viewport-percentage-compute-box-width.html: Added.

Added new tests for verifying that percentage unit height/width works
if parent block height/width is set in vh/vw units.

8:35 PM Changeset in webkit [160158] by roger_fong@apple.com

2 edits in trunk/Source/WebCore

[Windows] Unreviewed build fix. Copy headers from rendering/line to build directory.

WebCore.vcxproj/copyForwardingHeaders.cmd:

7:57 PM Changeset in webkit [160157] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

bgColor, setBgColor, alinkColor, setAlinkColor, and etc... on HTMLBodyElement are useless
https://bugs.webkit.org/show_bug.cgi?id=125208

Rubber-stamped by Anders Carlsson.

Address Darin's comment to use fastGetAttribute instead of getAttribute.

html/HTMLDocument.cpp:

(WebCore::HTMLDocument::bgColor):
(WebCore::HTMLDocument::fgColor):
(WebCore::HTMLDocument::alinkColor):
(WebCore::HTMLDocument::linkColor):
(WebCore::HTMLDocument::vlinkColor):

7:42 PM Changeset in webkit [160156] by rniwa@webkit.org

7 edits in trunk

Enable HTMLTemplateElement by default
https://bugs.webkit.org/show_bug.cgi?id=123851

Reviewed by Antti Koivisto.

Source/autotools/SetupWebKitFeatures.m4:
Source/cmake/WebKitFeatures.cmake:

Source/WTF:

wtf/FeatureDefines.h:

Tools:

Scripts/webkitperl/FeatureList.pm:

7:36 PM Changeset in webkit [160155] by matthew_hanson@apple.com

5 edits in trunk/Source

Versioning.

7:23 PM Changeset in webkit [160154] by matthew_hanson@apple.com

5 edits in trunk/Source

Versioning.

7:18 PM Changeset in webkit [160153] by matthew_hanson@apple.com

1 copy in tags/Safari-538.8

New Tag.

7:08 PM Changeset in webkit [160152] by commit-queue@webkit.org

23 edits
2 adds
3 deletes in trunk/Source

Consolidate various frame snapshot capabilities.
https://bugs.webkit.org/show_bug.cgi?id=124325

Patch by Brian J. Burg <Brian Burg> on 2013-12-04
Reviewed by Darin Adler.

Source/WebCore:

Various snapshot creation methods had duplicated code and were split
between Frame, DragImage, and platform-specific implementationss.
This patch puts WebCore snapshot methods into FrameSnapshotting
and removes platform implementations where possible.

DragImage methods reuse snapshot methods where possible. Inspector
will be able to take snapshots without using drag images.

No new tests, this is a refactoring.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.exp.in:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm:

(-[DOMNode renderedImage]):
(-[DOMRange renderedImageForcingBlackText:]):

dom/Clipboard.cpp:

(WebCore::Clipboard::createDragImage):

dom/ClipboardMac.mm:

(WebCore::Clipboard::createDragImage):

page/DragController.cpp:

(WebCore::DragController::startDrag):

page/Frame.cpp:
page/Frame.h:
page/FrameSnapshotting.cpp: Added.

(WebCore::ScopedFramePaintingState::ScopedFramePaintingState):
(WebCore::ScopedFramePaintingState::~ScopedFramePaintingState):
(WebCore::snapshotFrameRect): Move most buffer logic to here.
(WebCore::snapshotSelection): Moved from Frame.
(WebCore::snapshotNode): Moved from Frame.

page/FrameSnapshotting.h: Added.
page/mac/FrameMac.mm: Removed.
page/mac/FrameSnapshottingMac.h: Removed.
page/mac/FrameSnapshottingMac.mm: Removed.
page/win/FrameWin.cpp: remove duplicate implementation.
page/win/FrameWin.h: Fix an incorrect parameter name.
platform/DragImage.cpp:

(WebCore::ScopedNodeDragState::ScopedNodeDragState):
(WebCore::ScopedNodeDragState::~ScopedNodeDragState):
(WebCore::createDragImageFromSnapshot): Boilerplate buffer conversion.
(WebCore::createDragImageForNode):
(WebCore::createDragImageForSelection):
(WebCore::ScopedFrameSelectionState::ScopedFrameSelectionState):
(WebCore::ScopedFrameSelectionState::~ScopedFrameSelectionState):
(WebCore::createDragImageForRange): Moved from Frame.
(WebCore::createDragImageForImage): Moved from FrameSnapshottingMac.
(WebCore::createDragImageForLink): use nullptr.

Source/WebKit/ios:

WebCoreSupport/WebFrameIOS.mm: use new header file.

Source/WebKit/mac:

Use new platform-independent methods instead of Mac methods.

WebView/WebHTMLView.mm:

(-[WebHTMLView _selectionDraggingImage]):
(-[WebHTMLView selectionImageForcingBlackText:]):

Source/WebKit/win:

DOMCoreClasses.cpp:

(DOMElement::renderedImage): use createDragImageForNode.

7:05 PM Changeset in webkit [160151] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] Bumping GStreamer version to 1.2.1
https://bugs.webkit.org/show_bug.cgi?id=125155

Patch by Jozsef Berta <jberta@inf.u-szeged.hu> on 2013-12-04
Reviewed by Gyuyoung Kim.

efl/jhbuild.modules: Set the GStreamer version to 1.2.1

6:05 PM Changeset in webkit [160150] by fpizlo@apple.com

17 edits
8 adds in trunk

Fold constant typed arrays
https://bugs.webkit.org/show_bug.cgi?id=125205

Source/JavaScriptCore:

Reviewed by Oliver Hunt and Mark Hahnenberg.

If by some other mechanism we have a typed array access on a compile-time constant
typed array pointer, then fold:

Array bounds checks. Specifically, fold the load of length.

Loading the vector.

This needs to install a watchpoint on the array itself because of the possibility of
neutering. Neutering is ridiculous. We do this without bloating the size of
ArrayBuffer or JSArrayBufferView in the common case (i.e. the case where you
allocated an array that didn't end up becoming a compile-time constant). To install
the watchpoint, we slowDownAndWasteMemory and then create an incoming reference to
the ArrayBuffer, where that incoming reference is from a watchpoint object. The
ArrayBuffer already knows about such incoming references and can fire the
watchpoints that way.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
dfg/DFGDesiredWatchpoints.cpp:

(JSC::DFG::ArrayBufferViewWatchpointAdaptor::add):
(JSC::DFG::DesiredWatchpoints::addLazily):

dfg/DFGDesiredWatchpoints.h:

(JSC::DFG::GenericSetAdaptor::add):
(JSC::DFG::GenericSetAdaptor::hasBeenInvalidated):
(JSC::DFG::ArrayBufferViewWatchpointAdaptor::hasBeenInvalidated):
(JSC::DFG::GenericDesiredWatchpoints::reallyAdd):
(JSC::DFG::GenericDesiredWatchpoints::areStillValid):
(JSC::DFG::GenericDesiredWatchpoints::isStillValid):
(JSC::DFG::GenericDesiredWatchpoints::shouldAssumeMixedState):
(JSC::DFG::DesiredWatchpoints::isStillValid):
(JSC::DFG::DesiredWatchpoints::shouldAssumeMixedState):
(JSC::DFG::DesiredWatchpoints::isValidOrMixed):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::tryGetFoldableView):

dfg/DFGGraph.h:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::jumpForTypedArrayOutOfBounds):
(JSC::DFG::SpeculativeJIT::emitTypedArrayBoundsCheck):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileConstantIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):

dfg/DFGSpeculativeJIT.h:
dfg/DFGWatchpointCollectionPhase.cpp:

(JSC::DFG::WatchpointCollectionPhase::handle):
(JSC::DFG::WatchpointCollectionPhase::addLazily):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetIndexedPropertyStorage):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::LowerDFGToLLVM::typedArrayLength):

runtime/ArrayBuffer.cpp:

(JSC::ArrayBuffer::transfer):

runtime/ArrayBufferNeuteringWatchpoint.cpp: Added.

(JSC::ArrayBufferNeuteringWatchpoint::ArrayBufferNeuteringWatchpoint):
(JSC::ArrayBufferNeuteringWatchpoint::~ArrayBufferNeuteringWatchpoint):
(JSC::ArrayBufferNeuteringWatchpoint::finishCreation):
(JSC::ArrayBufferNeuteringWatchpoint::destroy):
(JSC::ArrayBufferNeuteringWatchpoint::create):
(JSC::ArrayBufferNeuteringWatchpoint::createStructure):

runtime/ArrayBufferNeuteringWatchpoint.h: Added.

(JSC::ArrayBufferNeuteringWatchpoint::set):

runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

LayoutTests:

Reviewed by Oliver Hunt and Mark Hahnenberg.

js/regress/fixed-typed-array-storage-expected.txt: Added.
js/regress/fixed-typed-array-storage-var-index-expected.txt: Added.
js/regress/fixed-typed-array-storage-var-index.html: Added.
js/regress/fixed-typed-array-storage.html: Added.
js/regress/script-tests/fixed-typed-array-storage-var-index.js: Added.

(foo):

js/regress/script-tests/fixed-typed-array-storage.js: Added.

(foo):

6:03 PM Changeset in webkit [160149] by commit-queue@webkit.org

2 edits in trunk/Tools

Update jhbuild revision.
https://bugs.webkit.org/show_bug.cgi?id=124966

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-04
Reviewed by Gyuyoung Kim.

Used version of Jhbuild failed to create directories and caused
update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.

jhbuild/jhbuild-wrapper:

5:43 PM Changeset in webkit [160148] by weinig@apple.com

5 edits in trunk/Source/WebKit2

[Cocoa] Make WKConnection work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=125266

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/WKConnection.mm:

(-[WKConnection dealloc]):
(didReceiveMessage):
(didClose):
(setUpClient):
(-[WKConnection delegate]):
(-[WKConnection setDelegate:]):
(-[WKConnection sendMessageWithName:body:]):
(-[WKConnection remoteObjectRegistry]):
(-[WKConnection API::]):

UIProcess/API/Cocoa/WKConnectionInternal.h:

(WebKit::wrapper):

UIProcess/API/Cocoa/WKProcessGroup.mm:

(didCreateConnection):

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

(-[WKWebProcessPlugInController _initWithPrincipalClassInstance:bundleRef:]):
(-[WKWebProcessPlugInController connection]):
(-[WKWebProcessPlugInController _bundleRef]):

5:30 PM Changeset in webkit [160147] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Remove spaces on a blank line to have ResourceHandleCFNet.cpp identical to iOS

Unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-12-04

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::platformLoadResourceSynchronously):

5:26 PM Changeset in webkit [160146] by andersca@apple.com

4 edits
2 adds in trunk

Add a WeakObjCPtr class
https://bugs.webkit.org/show_bug.cgi?id=125267

Reviewed by Geoffrey Garen.

Source/WebKit2:

WeakObjCPtr is a zeroing weak reference class template that will be used for delegates.

Shared/mac/WeakObjCPtr.h: Added.

(WebKit::WeakObjCPtr::WeakObjCPtr):
(WebKit::WeakObjCPtr::~WeakObjCPtr):
(WebKit::WeakObjCPtr::operator=):
(WebKit::WeakObjCPtr::get):

WebKit2.xcodeproj/project.pbxproj:

Tools:

Add API tests for WeakObjCPtr.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.

(TEST):

4:52 PM Changeset in webkit [160145] by Antoine Quint

2 edits in trunk/Source/WebInspectorUI

Web Inspector: ColorWheel uses old Color constructor
https://bugs.webkit.org/show_bug.cgi?id=125260

Reviewed by Joseph Pecoraro.

Update to new WebInspector.Color constructor signature and use a clear color.

UserInterface/ColorWheel.js:

(WebInspector.ColorWheel.prototype.get tintedColor):
(WebInspector.ColorWheel.prototype.get rawColor):

4:21 PM Changeset in webkit [160144] by bshafiei@apple.com

5 edits in branches/safari-537.60-branch/Source

Versioning.

4:17 PM Changeset in webkit [160143] by Antoine Quint

2 edits in trunk/Source/WebInspectorUI

Web Inspector: color picker doesn't work with "blue"
https://bugs.webkit.org/show_bug.cgi?id=125262

Reviewed by Joseph Pecoraro.

Under certain circumstances rounding issues would have us compare
two equal numbers that differ by 0.00000001 and sometime trip this
if statement and yield a null color. We now add a little fudge to
the test and also return a clear color rather than null to match what
we do in the getters for "tintedColor" and "rawColor".

UserInterface/ColorWheel.js:

(WebInspector.ColorWheel.prototype._colorAtPointWithBrightness):

4:17 PM Changeset in webkit [160142] by Antoine Quint

2 edits in trunk/Source/WebInspectorUI

Web Inspector: use only two decimals for opacity in rgba/hsla colors
https://bugs.webkit.org/show_bug.cgi?id=125261

Reviewed by Joseph Pecoraro.

UserInterface/ColorPicker.js:

(WebInspector.ColorPicker.prototype._updateColor):

4:13 PM Changeset in webkit [160141] by ryuan.choi@samsung.com

2 edits in trunk/Source/WebKit2

Unreviewed EFL build fix after r160135

CMakeLists.txt: Added rendering/line to include lists.

4:06 PM Changeset in webkit [160140] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r160116.
http://trac.webkit.org/changeset/160116
https://bugs.webkit.org/show_bug.cgi?id=125264

Change doesn't work as intended. See bug comments for details.
(Requested by bfulgham on #webkit).

runtime/InitializeThreading.cpp:

(JSC::initializeThreading):

4:06 PM Changeset in webkit [160139] by bshafiei@apple.com

1 copy in tags/Safari-537.60.10

New tag.

4:03 PM Changeset in webkit [160138] by Antti Koivisto

4 edits in trunk/Source/WebCore

Move pseudo element construction out from Element
https://bugs.webkit.org/show_bug.cgi?id=125257

Reviewed by Anders Carlsson.

This is logically part of the style resolve/render tree construction. This will make future
refactoring easier.

dom/Element.cpp:
dom/Element.h:
style/StyleResolveTree.cpp:

(WebCore::Style::beforeOrAfterPseudoElement):
(WebCore::Style::setBeforeOrAfterPseudoElement):
(WebCore::Style::clearBeforeOrAfterPseudoElement):
(WebCore::Style::needsPseudeElement):
(WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded):
(WebCore::Style::attachRenderTree):
(WebCore::Style::updateBeforeOrAfterPseudoElement):
(WebCore::Style::resolveTree):

3:43 PM Changeset in webkit [160137] by andersca@apple.com

8 edits in trunk

Make the estimatedProgress property observable using KVO
https://bugs.webkit.org/show_bug.cgi?id=125259

Reviewed by Dan Bernstein.

Source/WebKit2:

UIProcess/API/Cocoa/WKBrowsingContextController.mm:
UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::PageLoadState):
(WebKit::PageLoadState::reset):
(WebKit::PageLoadState::activeURL):
(WebKit::PageLoadState::estimatedProgress):
(WebKit::PageLoadState::setPendingAPIRequestURL):
(WebKit::PageLoadState::clearPendingAPIRequestURL):
(WebKit::PageLoadState::didStartProgress):
(WebKit::PageLoadState::didChangeProgress):
(WebKit::PageLoadState::didFinishProgress):

UIProcess/PageLoadState.h:

Move m_estimatedProgress to the page load state and call the observers when it changes.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::estimatedProgress):
(WebKit::WebPageProxy::didStartProgress):
(WebKit::WebPageProxy::didChangeProgress):
(WebKit::WebPageProxy::didFinishProgress):
(WebKit::WebPageProxy::resetState):
Call through to m_pageLoadState.

UIProcess/WebPageProxy.h:

Tools:

Bind the progress indicator value to the "estimatedProgress" property.

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController dealloc]):
(-[WK2BrowserWindowController awakeFromNib]):

3:26 PM Changeset in webkit [160136] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[WK2] Including SecItemShim.h should be guarded by ENABLE(SEC_ITEM_SHIM)
https://bugs.webkit.org/show_bug.cgi?id=125255

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-04
Reviewed by Anders Carlsson.

UIProcess/WebProcessProxy.cpp:
WebProcess/WebProcess.cpp:

3:21 PM Changeset in webkit [160135] by zoltan@webkit.org

8 edits
2 adds in trunk/Source/WebCore

Move TrailingObjects class into its own h/cpp
https://bugs.webkit.org/show_bug.cgi?id=124956

Reviewed by David Hyatt.

Since I moved space-ignoring inline functions into MidpointState in r160074,
I can nicely separate TrailingObjects class from BreakingContextInlineHeader.h.
This change improves the readability, and it's part of the RenderBlockLineLayout
refactoring campaign, which is tracked under bug #121261.

No new tests, no behavior change.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.xcodeproj/project.pbxproj:
rendering/RenderBlock.h:
rendering/RenderBlockFlow.h:
rendering/line/BreakingContextInlineHeaders.h:
rendering/line/TrailingObjects.cpp: Added.

(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):

rendering/line/TrailingObjects.h: Added.

(WebCore::TrailingObjects::TrailingObjects):
(WebCore::TrailingObjects::setTrailingWhitespace):
(WebCore::TrailingObjects::clear):
(WebCore::TrailingObjects::appendBoxIfNeeded):

3:20 PM Changeset in webkit [160134] by Antoine Quint

2 edits
4 adds in trunk/Source/WebInspectorUI

Web Inspector: "data detectors" menu on hover for actionable tokens
https://bugs.webkit.org/show_bug.cgi?id=124363

Reviewed by Timothy Hatcher.

Add a new WebInspector.HoverMenu class to display an overlay menu that is presented
with respect to a target frame that it draws itself around adding a customizable
action button to its right. The menu uses fade animations as it's presented and
dismissed and a single delegation method is fired when the button is pressed. Finally,
just like a popover, it automatically dismisses itself upon scrolling anywhere
outside of its bounds.

UserInterface/HoverMenu.css: Added.
UserInterface/HoverMenu.js: Added.

(WebInspector.HoverMenu):
(WebInspector.HoverMenu.prototype.get element):
(WebInspector.HoverMenu.prototype.dismiss):
(WebInspector.HoverMenu.prototype.handleEvent):
(WebInspector.HoverMenu.prototype._handleClickEvent):

UserInterface/Images/HoverMenuButton.png: Added.
UserInterface/Images/HoverMenuButton@2x.png: Added.
UserInterface/Main.html:

3:20 PM Changeset in webkit [160133] by oliver@apple.com

51 edits in trunk/Source

Refactor static getter function prototype to include thisValue in addition to the base object
https://bugs.webkit.org/show_bug.cgi?id=124461

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add thisValue parameter to static getter prototype, and switch
from JSValue to EncodedJSValue for parameters and return value.

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:

(JSC::::asCallbackObject):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):

jit/JITOperations.cpp:
runtime/JSActivation.cpp:

(JSC::JSActivation::argumentsGetter):

runtime/JSActivation.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::argumentsGetter):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::lengthGetter):
(JSC::JSFunction::nameGetter):

runtime/JSFunction.h:
runtime/JSObject.h:

(JSC::PropertySlot::getValue):

runtime/NumberConstructor.cpp:

(JSC::numberConstructorNaNValue):
(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):
(JSC::numberConstructorMaxValue):
(JSC::numberConstructorMinValue):

runtime/PropertySlot.h:
runtime/RegExpConstructor.cpp:

runtime/RegExpObject.cpp:

(JSC::asRegExpObject):
(JSC::regExpObjectGlobal):
(JSC::regExpObjectIgnoreCase):
(JSC::regExpObjectMultiline):
(JSC::regExpObjectSource):

Source/WebCore:

Change bindings codegen to produce static getter functions
with the correct types. Also update the many custom implementations
to the new type.

No change in behaviour.

bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::cssPropertyGetterPixelOrPosPrefixCallback):
(WebCore::cssPropertyGetterCallback):

bindings/js/JSDOMBinding.cpp:

(WebCore::objectToStringFunctionGetter):

bindings/js/JSDOMBinding.h:
bindings/js/JSDOMMimeTypeArrayCustom.cpp:

(WebCore::JSDOMMimeTypeArray::nameGetter):

bindings/js/JSDOMPluginArrayCustom.cpp:

(WebCore::JSDOMPluginArray::nameGetter):

bindings/js/JSDOMPluginCustom.cpp:

(WebCore::JSDOMPlugin::nameGetter):

bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::nameGetter):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::nonCachingStaticFunctionGetter):
(WebCore::childFrameGetter):
(WebCore::indexGetter):
(WebCore::namedItemGetter):

bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::JSHTMLAllCollection::nameGetter):

bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::JSHTMLCollection::nameGetter):

bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

bindings/js/JSHTMLFormControlsCollectionCustom.cpp:

(WebCore::JSHTMLFormControlsCollection::nameGetter):

bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::nameGetter):

bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::nameGetter):

bindings/js/JSHistoryCustom.cpp:

(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):

bindings/js/JSJavaScriptCallFrameCustom.cpp:

(WebCore::JSJavaScriptCallFrame::scopeType):

bindings/js/JSLocationCustom.cpp:

(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):

bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::nameGetter):

bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeList::nameGetter):

bindings/js/JSPluginElementFunctions.cpp:

(WebCore::pluginElementPropertyGetter):

bindings/js/JSPluginElementFunctions.h:
bindings/js/JSRTCStatsResponseCustom.cpp:

(WebCore::JSRTCStatsResponse::nameGetter):

bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::nameGetter):

bindings/js/JSStyleSheetListCustom.cpp:

(WebCore::JSStyleSheetList::nameGetter):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateParametersCheck):

bridge/runtime_array.cpp:

(JSC::RuntimeArray::lengthGetter):
(JSC::RuntimeArray::indexGetter):

bridge/runtime_array.h:
bridge/runtime_method.cpp:

(JSC::RuntimeMethod::lengthGetter):

bridge/runtime_method.h:
bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::fallbackObjectGetter):
(JSC::Bindings::RuntimeObject::fieldGetter):
(JSC::Bindings::RuntimeObject::methodGetter):

bridge/runtime_object.h:

Source/WebKit2:

Update the WK2 JSC usage to the new static getter API

WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::callMethod):

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::callNPJSObject):
(WebKit::constructWithConstructor):
(WebKit::JSNPObject::propertyGetter):
(WebKit::JSNPObject::methodGetter):

WebProcess/Plugins/Netscape/JSNPObject.h:
WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::getOrCreateNPObject):
(WebKit::NPRuntimeObjectMap::finalize):

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::frameForContext):
(WebKit::WebFrame::counterValue):

3:16 PM Changeset in webkit [160132] by Antoine Quint

5 edits in trunk/Source/WebInspectorUI

Web Inspector: edited color should serialize back to original format when possible
https://bugs.webkit.org/show_bug.cgi?id=125244

Reviewed by Joseph Pecoraro.

Profoundly reworked WebInspector.Color to be more efficient and more flexible when
serializing the color to the various supported formats.

UserInterface/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
Use new WebInspector.Color.fromString() factory and check for a null return value
rather than an exception to identify invalid color tokens.

UserInterface/Color.js:

(WebInspector.Color):
Rewrote WebInspector.Color such that it would have, at all times, a canonical
representation in terms of either RGBA or HSLA depending on the format used to
create the color. The new constructor parameters lets the user pass a format
and the RGBA or HSLA components, allowing to bypass the string-only creation
system which was sub-optimal for the new color picker. Additionally, the toString()
method now can provide the most accurate serialization of the color based on the
provided format with a fallback mechanism to RGB/RGBA in cases where the desired
format would incur a loss of fidelity. Finally, simplified the API to only feature
essential features.

(WebInspector.Color.fromString):
New factory method used to create a color from a string.

UserInterface/ColorPicker.js:

(WebInspector.ColorPicker.prototype.set color):
Keep track of the original color format so that we can use it as the preferred format
when serializing the updated color in _updateColor().

(WebInspector.ColorPicker.prototype._updateColor):
Use the original color format as the prefered formation for color serialization. Also,
use the new WebInspector.Color constructor in lieu of the removed .fromRGBA factory.

(WebInspector.ColorPicker.prototype._updateSliders):
Use the new WebInspector.Color constructor in lieu of the removed .fromRGBA factory.

UserInterface/ColorWheel.js:

(WebInspector.ColorWheel.prototype._colorAtPointWithBrightness):
Use the new WebInspector.Color constructor in lieu of the removed .fromRGB factory.

3:07 PM Changeset in webkit [160131] by dbates@webkit.org

2 edits in trunk/Source/JavaScriptCore

[iOS] Enable Objective-C ARC when building JSC tools for iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=125170

Reviewed by Geoffrey Garen.

API/tests/testapi.mm:
Configurations/ToolExecutable.xcconfig:

2:53 PM Changeset in webkit [160130] by zoltan@webkit.org

5 edits
10 adds in trunk

[CSS Shapes] Support inset for shape-outside
<https://webkit.org/b/125112>

Reviewed by David Hyatt.

Source/WebCore:

This patch adds inset support for shape-outside. Parsing has previously landed in r159968.
Specification: http://dev.w3.org/csswg/css-shapes/#supported-basic-shapes

Tests: fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-bottom-left.html

fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-bottom-right.html
fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-top-left.html
fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-top-right.html
fast/shapes/shape-outside-floats/shape-outside-floats-inset.html

platform/LengthSize.h:

(WebCore::LengthSize::floatSize): Add conversion to FloatSize.

rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape): Handle inset case.

LayoutTests:

fast/shapes/resources/rounded-rectangle.js: Add support to generate partially rounded rectangles.

(scanConvertRoundedRectangleOutside):
(genLeftRoundedRectFloatShapeOutsideRefTest):
(genRightRoundedRectFloatShapeOutsideRefTest):

fast/shapes/shape-outside-floats/shape-outside-floats-inset-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-bottom-left-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-bottom-left.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-bottom-right-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-bottom-right.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-top-left-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-top-left.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-top-right-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-top-right.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-inset.html: Added.

2:51 PM Changeset in webkit [160129] by andersca@apple.com

7 edits in trunk

Add a loading property to WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=125256

Reviewed by Dan Bernstein.

Source/WebKit2:

UIProcess/API/Cocoa/WKBrowsingContextController.h:

Add loading property.

UIProcess/API/Cocoa/WKBrowsingContextConteroller.mm:

Implement willChangeIsLoading and didChangeIsLoading and call the relevant KVO methods.

(-[WKBrowsingContextController isLoading]):
Call through to the PageLoadState.

UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::reset):
Use setState.

(WebKit::PageLoadState::isLoading):
Call isLoadingState.

(WebKit::PageLoadState::didStartProvisionalLoad):
Use setState.

(WebKit::PageLoadState::didFailProvisionalLoad):
Use setState.

(WebKit::PageLoadState::didCommitLoad):
Use setState.

(WebKit::PageLoadState::didFinishLoad):
Use setState.

(WebKit::PageLoadState::didFailLoad):
Use setState.

(WebKit::PageLoadState::isLoadingState):
Helper function for determining whether a state is a loading state or not.

(WebKit::PageLoadState::setState):
If setting the state will cause "isLoading" to change, call out to the observers.

UIProcess/PageLoadState.h:

Tools:

Bind the progress indicator visibility to the "loading" property.

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController dealloc]):
(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController didStartProgress]):
(-[WK2BrowserWindowController didFinishProgress]):

2:42 PM Changeset in webkit [160128] by commit-queue@webkit.org

14 edits in trunk

Source/WebKit2: [EFL][GTK][WK2] Remove unnecessary reinterpret_casts when setting API clients
https://bugs.webkit.org/show_bug.cgi?id=125231

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-04
Reviewed by Anders Carlsson.

After r159988, WKClients have to be instantiated with a specific
version of that client and its Base field has to used when setting it.
Eg:

WKFullScreenClientV0 wkClient = {

{

0, version
this, clientInfo

},

willEnterFullScreen,
willExitFullScreen

};
WKViewSetFullScreenClientGtk(this, &wkClient.base);

So we don't need the reinterpret_casts introduced in r160075.

UIProcess/API/gtk/WebKitFullscreenClient.cpp:

(attachFullScreenClientToView): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base

UIProcess/API/gtk/WebKitRequestManagerClient.cpp:

(attachRequestManagerClientToContext): Ditto.

UIProcess/API/gtk/WebKitTextChecker.cpp:

(WebKitTextChecker::WebKitTextChecker): Ditto.

UIProcess/API/gtk/WebKitWebInspector.cpp:

(webkitWebInspectorCreate): Ditto.

UIProcess/efl/BatteryProvider.cpp:

(BatteryProvider::BatteryProvider): Ditto.

UIProcess/efl/NetworkInfoProvider.cpp:

(NetworkInfoProvider::NetworkInfoProvider): Ditto.

UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::PageUIClientEfl): Ditto.

UIProcess/efl/RequestManagerClientEfl.cpp:

(WebKit::RequestManagerClientEfl::RequestManagerClientEfl): Ditto.

UIProcess/efl/TextCheckerClientEfl.cpp:

(TextCheckerClientEfl::TextCheckerClientEfl): Ditto.

UIProcess/efl/VibrationClientEfl.cpp:

(VibrationClientEfl::VibrationClientEfl): Ditto.

UIProcess/efl/ViewClientEfl.cpp:

(WebKit::ViewClientEfl::ViewClientEfl): Ditto.

Tools: [EFL][WK2] Buildfix after r160104
https://bugs.webkit.org/show_bug.cgi?id=125231

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-04
Reviewed by Anders Carlsson.

TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:

(TestWebKitAPI::TEST): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base

TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:

(TestWebKitAPI::setViewClient): Ditto.

2:24 PM Changeset in webkit [160127] by betravis@adobe.com

6 edits in trunk

Web Inspector: [CSS Shapes] Support raster shape visualizations
https://bugs.webkit.org/show_bug.cgi?id=124080

Reviewed by Joseph Pecoraro.

Source/WebCore:

Create an inspector visualization for a shape created from an image.
The visualization takes each line of the image, combining where possible.

Test added to inspector-protocol/model/highlight-shape-outside.html

rendering/shapes/RasterShape.cpp:

(WebCore::RasterShapeIntervals::buildBoundsPath): Create a path representing the
RasterShapeIntervals.

rendering/shapes/RasterShape.h:

LayoutTests:

Add a test for data sent to the inspector for a raster shape.

inspector-protocol/model/highlight-shape-outside-expected.txt:
inspector-protocol/model/highlight-shape-outside.html:

2:18 PM Changeset in webkit [160126] by zoltan@webkit.org

3 edits in trunk/Source/WebCore

[CSS Shapes] Remove explicit numbering from BasicShape::Type and CSSBasicShape::Type enums
https://bugs.webkit.org/show_bug.cgi?id=125163

Reviewed by Rob Buis.

I don't see any reason to have explicit numbering for the Type enum in our [CSS]BasicShape classes.
I removed numbering, which will decrease for instance the merge conflicts on Type changes.

No new tests, no behavior change.

css/CSSBasicShapes.h:
rendering/style/BasicShapes.h:

2:18 PM Changeset in webkit [160125] by commit-queue@webkit.org

14 edits in trunk/Source/WebKit2

[GTK][WK2] Fix build after r160104
https://bugs.webkit.org/show_bug.cgi?id=125240

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-04
Reviewed by Anders Carlsson.

Using specific version of API client when instantiating them.
Applied that same change to the following files:

UIProcess/API/gtk/WebKitContextMenuClient.cpp:
UIProcess/API/gtk/WebKitCookieManager.cpp:
UIProcess/API/gtk/WebKitDownloadClient.cpp:
UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
UIProcess/API/gtk/WebKitFindController.cpp:
UIProcess/API/gtk/WebKitFormClient.cpp:
UIProcess/API/gtk/WebKitGeolocationProvider.cpp:
UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
UIProcess/API/gtk/WebKitLoaderClient.cpp:
UIProcess/API/gtk/WebKitPolicyClient.cpp:
UIProcess/API/gtk/WebKitUIClient.cpp:
WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

2:16 PM Changeset in webkit [160124] by commit-queue@webkit.org

3 edits in trunk/Tools

check-webkit-style detected some ternary statements as initialization lists
https://bugs.webkit.org/show_bug.cgi?id=125246

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-12-04
Reviewed by Dean Jackson.

The regular expression that check-webkit-tests uses to detect initialization
lists was too broad, resulting in false positives. This patch makes the
regex more specific

Scripts/webkitpy/style/checkers/cpp.py:

(check_member_initialization_list):

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_member_initialization_list):

2:13 PM Changeset in webkit [160123] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Fixed the 32-bit Mac build.

Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData):

2:00 PM Changeset in webkit [160122] by mitz@apple.com

2 edits in trunk/Source/WebKit2

[Mac] When NSError user info is missing NSErrorPeerCertificateChainKey, ArgumentCoder should extract it from NSURLErrorFailingURLPeerTrustErrorKey
https://bugs.webkit.org/show_bug.cgi?id=125251

Reviewed by Anders Carlsson.

Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData): If the user info doesn’t include
NSURLErrorFailingURLPeerTrustErrorKey, copy the peer certificate chain from the peer trust
under NSURLErrorFailingURLPeerTrustErrorKey. On the decoding side, it will appear under the
NSURLErrorFailingURLPeerTrustErrorKey, because a trust object can’t be fully serialized.

1:35 PM Changeset in webkit [160121] by commit-queue@webkit.org

10 edits in trunk

Allow ImageBuffer to use an IOSurface that is larger than necessary
https://bugs.webkit.org/show_bug.cgi?id=124626

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-12-04
Reviewed by Simon Fraser.

Source/WebCore:

Because creating ImageBuffer's backing store can be so expensive, it
would be beneficial to have a pool of pre-created backing stores
available. However, this means that ImageBuffer might have to use a
backing store that is larger than the exact dimensions that it needs.
This patch adds a field, m_backingStoreSize, to CG's ImageBufferData
class, and uses this new field when performing ImageBuffer operations
to allow for larger-than-necessary backing stores. Content is always
drawn in the top left corner of the backing store.

No new tests are necessary because there is no behavior change.

platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::baseTransform): The base transform has to put
content at the top left corner instead of bottom left

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::createCroppedImageIfNecessary): Convenience function to figure out
the dimensions of the backing texture in user space
(WebCore::ImageBuffer::ImageBuffer): Set up new m_backingStoreSize member
(WebCore::maybeCropToBounds): Some ImageBuffer API functions require
outputting an image with logical size. This function performs the cropping
(WebCore::ImageBuffer::copyImage): Updated for larger-than-necessary
backing stores
(WebCore::ImageBuffer::copyNativeImage): Ditto
(WebCore::ImageBuffer::draw): Ditto
(WebCore::ImageBuffer::clip): Ditto
(WebCore::ImageBuffer::putByteArray): Ditto
(WebCore::ImageBuffer::toDataURL): Ditto

platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData): Ditto
(WebCore::ImageBufferData::putData): Ditto

platform/graphics/cg/ImageBufferDataCG.h: New m_backingStoreSize field

LayoutTests:

Update tests to be more robust with respect to accelerated vs
non-accelerated ImageBuffers.

fast/canvas/script-tests/canvas-fillPath-shadow.js: Don't sample a canvas at exactly

the corner of a drawn shape (because the corner might be antialiased). Instead, sample
a single pixel inside the shape

fast/canvas/script-tests/canvas-scale-shadowBlur.js: Don't sample a canvas at exactly

the edge of the blur radius. Instead, sample a single pixel past the blur radius.

fast/canvas/script-tests/canvas-scale-strokePath-shadow.js:

(shouldBeAround): Allow this test to be less strict when sampling inside a blurred region

platform/mac/fast/canvas/canvas-scale-shadowBlur-expected.txt: Matching update w/r/t

canvas-scale-shadowBlur.js

1:29 PM Changeset in webkit [160120] by Brent Fulgham

2 edits in branches/safari-537.60-branch/Source/WebKit

Merge r160118.

2013-12-04 Brent Fulgham <Brent Fulgham>

[Win] Correct WebKit.make copy command to land resources in proper directory.
https://bugs.webkit.org/show_bug.cgi?id=125249

Reviewed by Tim Horton.

WebKit.vcxproj/WebKit.make: Correct the copy command.

1:25 PM Changeset in webkit [160119] by dino@apple.com

9 edits
6 adds
2 deletes in trunk

Source/WebCore: [WebGL] Support for texImage2D of type HALF_FLOAT_OES
https://bugs.webkit.org/show_bug.cgi?id=110936

Reviewed by Brent Fulgham.

Add support for the HALF_FLOAT_OES texture format from texImage2D
and texSubImage2D.

A lot of this patch comes from the original patch on the bug
by Nayan Kumar, and the Blink commit:
https://codereview.chromium.org/13842017

Tests: fast/canvas/webgl/oes-texture-half-float-with-canvas.html

fast/canvas/webgl/oes-texture-half-float-with-image.html
fast/canvas/webgl/oes-texture-half-float-with-video.html

html/canvas/OESTextureHalfFloat.idl: New HALF_FLOAT_OES constant value.
html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateTexFunc): Remove the code that
would bail if half-float values were used.

platform/graphics/GraphicsContext3D.cpp:
Return appropriate DataFormats for half floating point types.
Copy the float -> half-float code from Blink
New pack functions for half floats
platform/graphics/GraphicsContext3D.h: New format types.
platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::texSubImage2D): Use GL_HALF_FLOAT_ARB if we're passed
a HALF_FLOAT_OES.

LayoutTests: [WebGL] Support for texImage2D/texSubImage2D of type HALF_FLOAT_OES
https://bugs.webkit.org/show_bug.cgi?id=110936

Reviewed by Brent Fulgham.

New tests for half-float textures.

fast/canvas/webgl/oes-texture-half-float-expected.txt:
fast/canvas/webgl/oes-texture-half-float-not-supported-expected.txt: Removed.
fast/canvas/webgl/oes-texture-half-float-not-supported.html: Removed.
fast/canvas/webgl/oes-texture-half-float-with-canvas-expected.txt: Added.
fast/canvas/webgl/oes-texture-half-float-with-canvas.html: Added.
fast/canvas/webgl/oes-texture-half-float-with-image-expected.txt: Added.
fast/canvas/webgl/oes-texture-half-float-with-image.html: Added.
fast/canvas/webgl/oes-texture-half-float-with-video-expected.txt: Added.
fast/canvas/webgl/oes-texture-half-float-with-video.html: Added.
fast/canvas/webgl/oes-texture-half-float.html:

1:21 PM Changeset in webkit [160118] by Brent Fulgham

2 edits in trunk/Source/WebKit

[Win] Correct WebKit.make copy command to land resources in proper directory.
https://bugs.webkit.org/show_bug.cgi?id=125249

Reviewed by Tim Horton.

WebKit.vcxproj/WebKit.make: Correct the copy command.

1:04 PM Changeset in webkit [160117] by mitz@apple.com

22 edits in trunk/Source

Replace USE(SECURITY_FRAMEWORK) with finer-grained defines
https://bugs.webkit.org/show_bug.cgi?id=125242

Reviewed by Sam Weinig.

Source/WebKit2:

Configurations/WebKit2.xcconfig: Removed “-framework Security” from the linker flags, now

that it’s included in the target’s Link Binary with Libraries build phase.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeConnection): Changed to use ENABLE(SEC_ITEM_SHIM).

NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcess): Ditto.

Shared/Authentication/AuthenticationManager.cpp: Changed to use HAVE(SEC_IDENTITY).
Shared/Authentication/mac/AuthenticationManager.mac.mm: Ditto.
Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::typeFromCFTypeRef): Removed use of USE(SECURITY_FRAMEWORK) since all CF platforms
use it. Added HAVE(SEC_KEYCHAIN) where needed.
(CoreIPC::encode): Ditto.
(CoreIPC::decode): Ditto.

Shared/cf/ArgumentCodersCF.h: Ditto.
Shared/mac/SecItemShim.cpp: Chanegd to use ENABLE(SEC_ITEM_SHIM).
Shared/mac/SecItemShim.h: Ditto.
Shared/mac/SecItemShim.messages.in: Ditto.
UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::connectionWillOpen): Ditto.

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connectionWillOpen): Ditto.

UIProcess/mac/SecItemShimProxy.cpp: Ditto.
UIProcess/mac/SecItemShimProxy.h: Ditto,
UIProcess/mac/SecItemShimProxy.messages.in: Ditto.
WebKit2.xcodeproj/project.pbxproj: Link Security.framework unconditionally.
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection): Changed to use ENABLE(SEC_ITEM_SHIM).

WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeProcess): Ditto.

config.h: Defined ENABLE_SEC_ITEM_SHIM.

Source/WTF:

wtf/Platform.h: Removed definitions of WTF_USE_SECURITY_FRAMEWORK, and defined

HAVE_SEC_IDENTITY and HAVE_SEC_KEYCHAIN.

12:43 PM Changeset in webkit [160116] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Use ThreadingOnce class to encapsulate pthread_once functionality.
https://bugs.webkit.org/show_bug.cgi?id=125228

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-12-04
Reviewed by Brent Fulgham.

runtime/InitializeThreading.cpp:

(JSC::initializeThreading):

12:40 PM Changeset in webkit [160115] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Remove unneeded semicolons.
https://bugs.webkit.org/show_bug.cgi?id=125083.

Rubber-stamped by Filip Pizlo.

debugger/Debugger.h:

(JSC::Debugger::detach):
(JSC::Debugger::sourceParsed):
(JSC::Debugger::exception):
(JSC::Debugger::atStatement):
(JSC::Debugger::callEvent):
(JSC::Debugger::returnEvent):
(JSC::Debugger::willExecuteProgram):
(JSC::Debugger::didExecuteProgram):
(JSC::Debugger::didReachBreakpoint):

12:34 PM Changeset in webkit [160114] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Fix the Apple Windows build after <http://trac.webkit.org/changeset/160113>
(https://bugs.webkit.org/show_bug.cgi?id=125193)

rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::paintMenuList): Substitute paintInfo for i.

12:17 PM Changeset in webkit [160113] by dbates@webkit.org

18 edits in trunk/Source/WebCore

Rename RenderTheme::paintMenuListButton()
https://bugs.webkit.org/show_bug.cgi?id=125193

Reviewed by Simon Fraser.

Towards upstreaming the iOS concept of render theme decorations we should rename
RenderTheme::paintMenuListButton() to RenderTheme::paintMenuListButtonDecorations()
to better describe its purpose.

Also, fix code style issues.

platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintMenuListButtonDecorations):

platform/blackberry/RenderThemeBlackBerry.h:
platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMenuListButtonDecorations):

platform/efl/RenderThemeEfl.h:
platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::paintMenuListButtonDecorations):

platform/gtk/RenderThemeGtk.h:
platform/nix/RenderThemeNix.h:
rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintDecorations): Rename argument o, r to renderer and rect, respectively.

rendering/RenderTheme.h:

(WebCore::RenderTheme::paintMenuListButtonDecorations):

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuListButtonDecorations): Rename argument o, r to renderer and rect,
respectively; also remove extraneous white space and substitute 1 for 1.0f.

rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintMenuListButtonDecorations): Ditto.

rendering/RenderThemeSafari.h:
rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::paintMenuList): Rename argument o, i, r to renderer, paintInfo, and rect,
respectively.
(WebCore::RenderThemeWin::paintMenuListButtonDecorations): Ditto.

rendering/RenderThemeWin.h:
rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::paintMenuList): Ditto.
(WebCore::RenderThemeWinCE::paintMenuListButtonDecorations): Ditto.

rendering/RenderThemeWinCE.h:

11:56 AM Changeset in webkit [160112] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

[Win][64-bit] Link error.
https://bugs.webkit.org/show_bug.cgi?id=125234

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-12-04
Reviewed by Brent Fulgham.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Changed 64-bit version of symbol.

11:33 AM Changeset in webkit [160111] by aestes@apple.com

6 edits in trunk/Source

[iOS] Build projects with $(ARCHS_STANDARD_32_64_BIT)
https://bugs.webkit.org/show_bug.cgi?id=125236

Reviewed by Sam Weinig.

$(ARCHS_STANDARD_32_64_BIT) is what we want for both device and simulator builds.

Source/JavaScriptCore:

Configurations/DebugRelease.xcconfig:

Source/WebCore:

Configurations/DebugRelease.xcconfig:

Source/WebKit/mac:

Configurations/DebugRelease.xcconfig:

11:31 AM Changeset in webkit [160110] by mihnea@adobe.com

1 edit
2 adds in trunk/LayoutTests

[CSSRegions] Test dynamic change of position for out-of-flow transformed element
https://bugs.webkit.org/show_bug.cgi?id=124978

Reviewed by Alexandru Chiculita.

Test that a 3D transformed absolutely positioned element inside a named flow
whose position is dynamic changed is displayed in the right position in the associated region.

compositing/regions/abs-transformed-dynamic-update-expected.html: Added.
compositing/regions/abs-transformed-dynamic-update.html: Added.

11:29 AM Changeset in webkit [160109] by fpizlo@apple.com

27 edits
19 adds in trunk

Infer constant closure variables
https://bugs.webkit.org/show_bug.cgi?id=124630

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Captured variables that are assigned once (not counting op_enter's Undefined
initialization) and that are contained within a function that has thus far only been
entered once are now constant folded. It's pretty awesome.

This involves a watchpoint on the assignment to variables and a watchpoint on entry
into the function. The former is reused from global variable constant inference and the
latter is reused from one-time closure inference.

GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

bytecode/Instruction.h:

(JSC::Instruction::Instruction):

bytecode/Opcode.h:

(JSC::padOpcodeName):

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedInstruction::UnlinkedInstruction):

bytecode/VariableWatchpointSet.h:

(JSC::VariableWatchpointSet::invalidate):

bytecode/Watchpoint.h:

(JSC::WatchpointSet::invalidate):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitInitLazyRegister):
(JSC::BytecodeGenerator::emitMove):
(JSC::BytecodeGenerator::emitNewFunctionInternal):
(JSC::BytecodeGenerator::createArgumentsIfNecessary):

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::watchableVariable):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::inferredConstant):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::tryGetActivation):
(JSC::DFG::Graph::tryGetRegisters):

dfg/DFGGraph.h:
jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

jit/JIT.h:
jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_captured_mov):
(JSC::JIT::emit_op_new_captured_func):
(JSC::JIT::emitSlow_op_captured_mov):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_captured_mov):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

runtime/CommonSlowPaths.h:
runtime/ConstantMode.h: Added.
runtime/JSGlobalObject.h:
runtime/JSScope.cpp:

(JSC::abstractAccess):

runtime/SymbolTable.cpp:

(JSC::SymbolTableEntry::prepareToWatch):

LayoutTests:

Reviewed by Geoffrey Garen.

This adds both correctness and performance tests for constant closure variable
inference.

js/regress/infer-closure-const-then-mov-expected.txt: Added.
js/regress/infer-closure-const-then-mov-no-inline-expected.txt: Added.
js/regress/infer-closure-const-then-mov-no-inline.html: Added.
js/regress/infer-closure-const-then-mov.html: Added.
js/regress/infer-closure-const-then-put-to-scope-expected.txt: Added.
js/regress/infer-closure-const-then-put-to-scope-no-inline-expected.txt: Added.
js/regress/infer-closure-const-then-put-to-scope-no-inline.html: Added.
js/regress/infer-closure-const-then-put-to-scope.html: Added.
js/regress/infer-closure-const-then-reenter-expected.txt: Added.
js/regress/infer-closure-const-then-reenter-no-inline-expected.txt: Added.
js/regress/infer-closure-const-then-reenter-no-inline.html: Added.
js/regress/infer-closure-const-then-reenter.html: Added.
js/regress/script-tests/infer-closure-const-then-mov-no-inline.js: Added.
js/regress/script-tests/infer-closure-const-then-mov.js: Added.
js/regress/script-tests/infer-closure-const-then-put-to-scope-no-inline.js: Added.

(thingy.):
(thingy):

js/regress/script-tests/infer-closure-const-then-put-to-scope.js: Added.

(thingy.):
(thingy):

js/regress/script-tests/infer-closure-const-then-reenter-no-inline.js: Added.

(.return.foo):
(foo):

js/regress/script-tests/infer-closure-const-then-reenter.js: Added.

(.return.foo):
(foo):

11:17 AM Changeset in webkit [160108] by mhahnenberg@apple.com

4 edits in trunk/Tools

run-jsc-stress-tests can only run locally
https://bugs.webkit.org/show_bug.cgi?id=124551

Reviewed by Filip Pizlo.

Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was

killed before the lock directory was removed, future executions wouldn't make any progress. Also
added a couple more signals to handle gracefully at shutdown.

Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.

The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
toward the end of the script to make it easier to tell which of the various modes do what.

11:15 AM Changeset in webkit [160107] by Csaba Osztrogonác

14 edits in trunk

[EFL][WK2] Buildfix after r160104
https://bugs.webkit.org/show_bug.cgi?id=125233

Reviewed by Anders Carlsson.

Source/WebKit2:

UIProcess/API/efl/ewk_cookie_manager.cpp:

(EwkCookieManager::EwkCookieManager):

UIProcess/API/efl/ewk_favicon_database.cpp:

(EwkFaviconDatabase::EwkFaviconDatabase):

UIProcess/efl/ContextHistoryClientEfl.cpp:

(WebKit::ContextHistoryClientEfl::ContextHistoryClientEfl):

UIProcess/efl/ContextMenuClientEfl.cpp:

(ContextMenuClientEfl::ContextMenuClientEfl):

UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::DownloadManagerEfl):

UIProcess/efl/FindClientEfl.cpp:

(WebKit::FindClientEfl::FindClientEfl):

UIProcess/efl/FormClientEfl.cpp:

(WebKit::FormClientEfl::FormClientEfl):

UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::PageLoadClientEfl):

UIProcess/efl/PagePolicyClientEfl.cpp:

(WebKit::PagePolicyClientEfl::PagePolicyClientEfl):

UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::PageUIClientEfl):

Tools:

TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:

(TestWebKitAPI::setPageLoaderClient):

11:02 AM Changeset in webkit [160106] by aestes@apple.com

12 edits in trunk/Source/WebKit/ios

[iOS] Upstream build fixes in Source/WebKit/ios/
https://bugs.webkit.org/show_bug.cgi?id=125230

Reviewed by Sam Weinig.

DefaultDelegates/WebDefaultUIKitDelegate.m:

(-[WebDefaultUIKitDelegate webViewDidReceiveMobileDocType:]):

Misc/WebNSStringDrawing.mm:

(needsBidiLayout):
(-[NSString web_drawAtPoint:forWidth:withFont:ellipsis:letterSpacing:includeEmoji:measureOnly:renderedStringOut:drawUnderline:]):
(-[NSString web_drawInRect:withFont:ellipsis:alignment:letterSpacing:lineSpacing:includeEmoji:truncationRect:measureOnly:renderedStringOut:drawUnderline:]):

Misc/WebUIKitSupport.mm:

(WebKitInitialize):

WebCoreSupport/WebChromeClientIOS.h:
WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::didReceiveMobileDocType):
(WebChromeClientIOS::focusedElementChanged):

WebCoreSupport/WebFrameIOS.mm:

(-[WebFrame clearSelection]):
(-[WebFrame selectionState]):
(-[WebFrame collapseSelection]):
(-[WebFrame extendSelection:]):
(-[WebFrame selectionRects]):
(-[WebFrame setRangedSelectionWithExtentPoint:]):
(-[WebFrame setRangedSelectionExtentPoint:baseIsStart:allowFlipping:]):
(-[WebFrame setSelectionWithBasePoint:extentPoint:baseIsStart:allowFlipping:]):
(-[WebFrame setSelectionWithFirstPoint:secondPoint:]):
(-[WebFrame ensureRangedSelectionContainsInitialStartPoint:initialEndPoint:]):
(-[WebFrame aggressivelyExpandSelectionToWordContainingCaretSelection]):
(-[WebFrame expandSelectionToSentence]):
(-[WebFrame setBaseWritingDirection:]):
(-[WebFrame moveSelectionToStart]):
(-[WebFrame moveSelectionToEnd]):
(-[WebFrame moveSelectionToPoint:]):
(-[WebFrame setSelectionGranularity:]):
(-[WebFrame smartExtendRangedSelection:]):
(-[WebFrame previousUnperturbedDictationResultBoundaryFromPosition:]):
(-[WebFrame nextUnperturbedDictationResultBoundaryFromPosition:]):

WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::didSetSearchingForNode):
(WebInspectorClient::setupRemoteConnection):
(WebInspectorClient::teardownRemoteConnection):

WebCoreSupport/WebVisiblePosition.mm:

(-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]):
(-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]):
(-[DOMHTMLInputElement startPosition]):
(-[DOMHTMLInputElement endPosition]):
(-[DOMHTMLTextAreaElement startPosition]):
(-[DOMHTMLTextAreaElement endPosition]):

WebView/WebPDFViewIOS.mm:

(+[WebPDFView shadowColor]):
(+[WebPDFView backgroundColor]):
(-[WebPDFView _checkPDFTitle]):

WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):

WebView/WebUIKitDelegate.h:

11:02 AM Changeset in webkit [160105] by Brent Fulgham

3 edits in trunk/Source/JavaScriptCore

[Win] Unreviewed project file gardening.

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Remove deleted files from project.
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Put files in proper directory

folders to match the directory structure of the source code.

10:49 AM Changeset in webkit [160104] by andersca@apple.com

133 edits in trunk

Deprecate all unversioned client structs in favor of having explicit versioned structs
https://bugs.webkit.org/show_bug.cgi?id=125203

Reviewed by Dan Bernstein.

Source/WebKit2:

Deprecate all the "current version" enums and unversioned client structs.

Shared/API/c/WKConnectionRef.cpp:

(WKConnectionSetConnectionClient):

Shared/API/c/WKConnectionRef.h:
UIProcess/API/C/WKContext.cpp:

(WKContextSetClient):
(WKContextSetInjectedBundleClient):
(WKContextSetHistoryClient):
(WKContextSetDownloadClient):
(WKContextSetConnectionClient):

UIProcess/API/C/WKContext.h:
UIProcess/API/C/WKContextConnectionClient.h:
UIProcess/API/C/WKContextDownloadClient.h:
UIProcess/API/C/WKContextHistoryClient.h:
UIProcess/API/C/WKContextInjectedBundleClient.h:
UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerSetClient):

UIProcess/API/C/WKCookieManager.h:
UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerSetClient):

UIProcess/API/C/WKDatabaseManager.h:
UIProcess/API/C/WKGeolocationManager.cpp:

(WKGeolocationManagerSetProvider):

UIProcess/API/C/WKGeolocationManager.h:
UIProcess/API/C/WKIconDatabase.cpp:

(WKIconDatabaseSetIconDatabaseClient):

UIProcess/API/C/WKIconDatabase.h:
UIProcess/API/C/WKOriginDataManager.cpp:

(WKOriginDataManagerSetChangeClient):

UIProcess/API/C/WKOriginDataManager.h:
UIProcess/API/C/WKPage.cpp:

(WKPageSetPageContextMenuClient):
(WKPageSetPageFindClient):
(WKPageSetPageFindMatchesClient):
(WKPageSetPageFormClient):
(WKPageSetPageLoaderClient):
(WKPageSetPagePolicyClient):
(WKPageSetPageUIClient):

UIProcess/API/C/WKPage.h:
UIProcess/API/C/WKPageContextMenuClient.h:
UIProcess/API/C/WKPageFindClient.h:
UIProcess/API/C/WKPageFindMatchesClient.h:
UIProcess/API/C/WKPageFormClient.h:
UIProcess/API/C/WKPageLoaderClient.h:
UIProcess/API/C/WKPagePolicyClient.h:
UIProcess/API/C/WKPageUIClient.h:
UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(setUpPagePolicyClient):

UIProcess/API/Cocoa/WKConnection.mm:

(setUpClient):

UIProcess/API/Cocoa/WKProcessGroup.mm:

(setUpConnectionClient):
(setUpInectedBundleClient):
(setUpHistoryClient):

UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage):

UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::createNewPage):
(WebKit::WebUIClient::mouseDidMoveOverElement):

UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetClient):

WebProcess/InjectedBundle/API/c/WKBundle.h:
WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetContextMenuClient):
(WKBundlePageSetEditorClient):
(WKBundlePageSetFormClient):
(WKBundlePageSetPageLoaderClient):
(WKBundlePageSetResourceLoadClient):
(WKBundlePageSetPolicyClient):
(WKBundlePageSetUIClient):
(WKBundlePageSetFullScreenClient):
(WKBundlePageSetDiagnosticLoggingClient):

WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/InjectedBundle/API/c/WKBundlePageBanner.h:
WebProcess/InjectedBundle/API/c/WKBundlePageContextMenuClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePageEditorClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePageFormClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePageFullScreenClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(WKBundlePageOverlayCreate):
(WKBundlePageOverlaySetAccessibilityClient):

WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
WebProcess/InjectedBundle/API/c/WKBundlePagePolicyClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePageResourceLoadClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:
WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.h:
WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:

(WKBundlePageBannerCreateBannerWithCALayer):

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

(setUpBundleClient):

Tools:

Update for WebKit2 API changes.

MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

TestWebKitAPI/InjectedBundleController.cpp:

(TestWebKitAPI::InjectedBundleController::initialize):

TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:

(TestWebKitAPI::setInjectedBundleClient):

TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):

TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):

TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:

(TestWebKitAPI::setInjectedBundleClient):

TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:

(TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):

TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:

(TestWebKitAPI::setContextDownloadClient):
(TestWebKitAPI::setPagePolicyClient):

TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/Find.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/FindMatches.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:

(TestWebKitAPI::setupGeolocationProvider):
(TestWebKitAPI::setupView):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:

(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::setInjectedBundleClient):

TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:

(TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):

TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:

(TestWebKitAPI::setInjectedBundleClient):

TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:

(TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):

TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:

(TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage):

TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:

(TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):

TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:

(TestWebKitAPI::setPageLoaderClient):

TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:

(TestWebKitAPI::setPageLoaderClient):

TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:

(TestWebKitAPI::setPageLoaderClient):

TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:

(TestWebKitAPI::setPageLoaderClient):

TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:

(TestWebKitAPI::setPageLoaderClient):

TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:

(TestWebKitAPI::setInjectedBundleClient):

TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:

(TestWebKitAPI::ParentFrameTest::didCreatePage):

TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:

(TestWebKitAPI::setInjectedBundleClient):

TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:

(TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):

TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:

(TestWebKitAPI::setInjectedBundleClient):
(TestWebKitAPI::setPageLoaderClient):

TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:

(TestWebKitAPI::setPageLoaderClient):

TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:

(TestWebKitAPI::setPageLoaderClient):

TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:

(TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):

TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:

(TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):

TestWebKitAPI/Tests/WebKit2/WKConnection.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp:

(TestWebKitAPI::WKConnectionTest::initialize):

TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:

(TestWebKitAPI::setPageLoaderClient):

TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:

(TestWebKitAPI::setInjectedBundleClient):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:

(TestWebKitAPI::WebKit2WillLoadTest::setInjectedBundleClient):

TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:

(TestWebKitAPI::setInjectedBundleClient):

TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:

(TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):

TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:

(TestWebKitAPI::setInjectedBundleClient):

TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:

(TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):

TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:

(TestWebKitAPI::didCreateConnection):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:

(TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):

TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
TestWebKitAPI/mac/WebKitAgnosticTest.mm:

(TestWebKitAPI::setPageLoaderClient):

WebKitTestRunner/GeolocationProviderMock.cpp:

(WTR::GeolocationProviderMock::GeolocationProviderMock):

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::initialize):

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
(WTR::TestController::createWebViewWithOptions):

10:48 AM Changeset in webkit [160103] by Joseph Pecoraro

2 edits in trunk/Source/JavaScriptCore

Unreviewed Windows build fix attempt 2 after r160099.

JavaScriptCore.vcxproj/copy-files.cmd:

10:41 AM Changeset in webkit [160102] by Joseph Pecoraro

3 edits in trunk/Source/WebCore

Unreviewed Windows build fix attempt after r160099.

WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.vcxproj/copyForwardingHeaders.cmd:

10:35 AM Changeset in webkit [160101] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Fix build warnings in DownloadAuthenticationClient.cpp
https://bugs.webkit.org/show_bug.cgi?id=124920

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-04
Reviewed by Alexey Proskuryakov.

Fix unused parameter warnings in DownloadAuthenticationClient.cpp

Shared/Downloads/DownloadAuthenticationClient.cpp:

(WebKit::DownloadAuthenticationClient::receivedCredential):
(WebKit::DownloadAuthenticationClient::receivedRequestToContinueWithoutCredential):
(WebKit::DownloadAuthenticationClient::receivedCancellation):

10:30 AM Changeset in webkit [160100] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

REGRESSION (r160094): Fix lots of crashes for sh4 architecture.
https://bugs.webkit.org/show_bug.cgi?id=125227

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-12-04
Reviewed by Michael Saboff.

llint/LowLevelInterpreter32_64.asm: Do not use t4 and t5 as they match a0 and a1.
offlineasm/registers.rb: Add t7, t8 and t9 in register list for sh4 port.
offlineasm/sh4.rb: Rearrange RegisterID list and add the missing ones.

10:20 AM Changeset in webkit [160099] by Joseph Pecoraro

66 edits
7 copies
1 move
11 adds
1 delete in trunk/Source

Web Inspector: Push Remote Inspector debugging connection management into JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=124613

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Move the ENABLE(REMOTE_INSPECTOR) remote debugger connection management
into JavaScriptCore (originally from WebKit/mac). Include enhancements:

allow for different types of remote debuggable targets, eventually at least a JSContext, WebView, WKView.
allow debuggables to be registered and debugged on any thread. Unlike WebViews, JSContexts may be run entirely off of the main thread.
move the remote connection (XPC connection) itself off of the main thread, it doesn't need to be on the main thread.

Make JSContext @class and JavaScriptCore::JSContextRef
"JavaScript" Remote Debuggables.

inspector/remote/RemoteInspectorDebuggable.h: Added.
inspector/remote/RemoteInspectorDebuggable.cpp: Added.

(Inspector::RemoteInspectorDebuggable::RemoteInspectorDebuggable):
(Inspector::RemoteInspectorDebuggable::~RemoteInspectorDebuggable):
(Inspector::RemoteInspectorDebuggable::init):
(Inspector::RemoteInspectorDebuggable::update):
(Inspector::RemoteInspectorDebuggable::setRemoteDebuggingAllowed):
(Inspector::RemoteInspectorDebuggable::info):
RemoteInspectorDebuggable defines a debuggable target. As long as
something creates a debuggable and is set to allow remote inspection
it will be listed in remote debuggers. For the different types of
debuggables (JavaScript and Web) there is different basic information
that may be listed.

inspector/InspectorFrontendChannel.h: Added.

(Inspector::InspectorFrontendChannel::~InspectorFrontendChannel):
The only thing a debuggable needs for remote debugging is an
InspectorFrontendChannel a way to send messages to a remote frontend.
This class provides that method, and is vended to the
RemoteInspectorDebuggable when a remote connection is setup.

inspector/remote/RemoteInspector.h: Added.
inspector/remote/RemoteInspector.mm: Added.

Singleton, created at least when the first Debuggable is created.
This class manages the list of debuggables, any connection to a
remote debugger proxy (XPC service "com.apple.webinspector").

(Inspector::dispatchAsyncOnQueueSafeForAnyDebuggable):
(Inspector::RemoteInspector::shared):
(Inspector::RemoteInspector::RemoteInspector):
(Inspector::RemoteInspector::nextAvailableIdentifier):
(Inspector::RemoteInspector::registerDebuggable):
(Inspector::RemoteInspector::unregisterDebuggable):
(Inspector::RemoteInspector::updateDebuggable):
Debuggable management. When debuggables are added, removed, or updated
we stash a copy of the debuggable information and push an update to
debuggers. Stashing a copy of the information in the RemoteInspector
is a thread safe way to avoid walking over all debuggables to gather
the information when it is needed.

(Inspector::RemoteInspector::start):
(Inspector::RemoteInspector::stop):
Runtime API to enable / disable the feature.

(Inspector::RemoteInspector::listingForDebuggable):
(Inspector::RemoteInspector::pushListingNow):
(Inspector::RemoteInspector::pushListingSoon):
Pushing a listing to remote debuggers.

(Inspector::RemoteInspector::sendMessageToRemoteFrontend):
(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
(Inspector::RemoteInspector::xpcConnectionFailed):
(Inspector::RemoteInspector::xpcConnectionUnhandledMessage):
XPC setup, send, and receive handling.

(Inspector::RemoteInspector::updateHasActiveDebugSession):
Applications being debugged may want to know when a debug
session is active. This provides that notification.

(Inspector::RemoteInspector::receivedSetupMessage):
(Inspector::RemoteInspector::receivedDataMessage):
(Inspector::RemoteInspector::receivedDidCloseMessage):
(Inspector::RemoteInspector::receivedGetListingMessage):
(Inspector::RemoteInspector::receivedIndicateMessage):
(Inspector::RemoteInspector::receivedConnectionDiedMessage):
Dispatching incoming remote debugging protocol messages.
These are wrapping above the inspector protocol messages.

inspector/remote/RemoteInspectorConstants.h: Added.

Protocol messages and dictionary keys inside the messages.

(Inspector::RemoteInspectorDebuggableInfo::RemoteInspectorDebuggableInfo):

inspector/remote/RemoteInspectorDebuggableConnection.h: Added.
inspector/remote/RemoteInspectorDebuggableConnection.mm: Added.

This is a connection between the RemoteInspector singleton and a RemoteInspectorDebuggable.

(Inspector::RemoteInspectorDebuggableConnection::RemoteInspectorDebuggableConnection):
(Inspector::RemoteInspectorDebuggableConnection::~RemoteInspectorDebuggableConnection):
Allow for dispatching messages on JavaScript debuggables on a dispatch_queue
instead of the main queue.

(Inspector::RemoteInspectorDebuggableConnection::destination):
(Inspector::RemoteInspectorDebuggableConnection::connectionIdentifier):
Needed in the remote debugging protocol to identify the remote debugger.

(Inspector::RemoteInspectorDebuggableConnection::dispatchSyncOnDebuggable):
(Inspector::RemoteInspectorDebuggableConnection::dispatchAsyncOnDebuggable):
(Inspector::RemoteInspectorDebuggableConnection::setup):
(Inspector::RemoteInspectorDebuggableConnection::closeFromDebuggable):
(Inspector::RemoteInspectorDebuggableConnection::close):
(Inspector::RemoteInspectorDebuggableConnection::sendMessageToBackend):
(Inspector::RemoteInspectorDebuggableConnection::sendMessageToFrontend):
The connection is a thin channel between the two sides that can be closed
from either side, so there is some logic around multi-threaded access.

inspector/remote/RemoteInspectorXPCConnection.h: Added.

(Inspector::RemoteInspectorXPCConnection::Client::~Client):

inspector/remote/RemoteInspectorXPCConnection.mm: Added.

(Inspector::RemoteInspectorXPCConnection::RemoteInspectorXPCConnection):
(Inspector::RemoteInspectorXPCConnection::~RemoteInspectorXPCConnection):
(Inspector::RemoteInspectorXPCConnection::close):
(Inspector::RemoteInspectorXPCConnection::deserializeMessage):
(Inspector::RemoteInspectorXPCConnection::handleEvent):
(Inspector::RemoteInspectorXPCConnection::sendMessage):
This is a connection between the RemoteInspector singleton and an XPC service
named "com.apple.webinspector". This handles serialization of the dictionary
messages to and from the service. The receiving is done on a non-main queue.

API/JSContext.h:
API/JSContext.mm:

(-[JSContext name]):
(-[JSContext setName:]):
ObjC API to enable/disable JSContext remote inspection and give a name.

API/JSContextRef.h:
API/JSContextRef.cpp:

(JSGlobalContextGetName):
(JSGlobalContextSetName):
C API to give a JSContext a name.

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::setName):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::name):
Shared handling of the APIs above.

runtime/JSGlobalObjectDebuggable.cpp: Added.

(JSC::JSGlobalObjectDebuggable::JSGlobalObjectDebuggable):
(JSC::JSGlobalObjectDebuggable::name):
(JSC::JSGlobalObjectDebuggable::connect):
(JSC::JSGlobalObjectDebuggable::disconnect):
(JSC::JSGlobalObjectDebuggable::dispatchMessageFromRemoteFrontend):

runtime/JSGlobalObjectDebuggable.h: Added.

Stub for the actual remote debugging implementation. We will push
down the appropriate WebCore/inspector peices suitable for debugging
just a JavaScript context.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
GNUmakefile.am:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:

Update build files.

Source/WebCore:

Make a WebCore::Page a "Web" Remote Debuggable.

bindings/js/JSDOMGlobalObject.cpp:

Disable JavaScript context inspection on JSGlobalObjects inside WebCore::Page's.

page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::remoteInspectionAllowed):
(WebCore::Page::setRemoteInspectionAllowed):
(WebCore::Page::remoteInspectorInformationDidChange):

page/Page.h:
page/PageDebuggable.h:
page/PageDebuggable.cpp: Added.

(WebCore::PageDebuggable::PageDebuggable):
(WebCore::PageDebuggable::name):
(WebCore::PageDebuggable::url):
(WebCore::PageDebuggable::hasLocalDebugger):
(WebCore::PageDebuggable::connect):
(WebCore::PageDebuggable::disconnect):
(WebCore::PageDebuggable::dispatchMessageFromRemoteFrontend):
(WebCore::PageDebuggable::setIndicating):
Make a page a "Web" debuggable.

GNUmakefile.list.am:
WebCore.exp.in:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:

Misc.

inspector/InspectorClient.h:

(WebCore::InspectorClient::indicate):
(WebCore::InspectorClient::hideIndicate):
Forward indicate methods to WebKit clients.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::didChangeTitle):
(WebCore::FrameLoader::dispatchDidCommitLoad):
Push updates when remote debuggable information like the Page's
URL or title change.

ForwardingHeaders/inspector/InspectorFrontendChannel.h:
inspector/InspectorForwarding.h:

Re-export Inspector::InspectorFrontendChannel as WebCore::InspectorFrontendChannel
to avoid needlessly updating code all over the place.

inspector/CodeGeneratorInspectorStrings.py:
inspector/InspectorWorkerAgent.cpp:
inspector/WorkerInspectorController.cpp:
testing/Internals.cpp:

Update include names.

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):
Make the "Inspect Element" context menu work correctly when there is a
remote inspector instead of a local inspector.

Source/WebKit:

WebKit.xcodeproj/project.pbxproj:

Source/WebKit/blackberry:

WebCoreSupport/InspectorClientBlackBerry.h:

Source/WebKit/cf:

WebCoreSupport/WebInspectorClientCF.cpp:

(WebInspectorClient::sendMessageToFrontend):

Source/WebKit/efl:

WebCoreSupport/InspectorClientEfl.h:

Source/WebKit/gtk:

WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/ios:

WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::inspectorDestroyed):

Source/WebKit/mac:

Remove the old ENABLE(REMOTE_INSPECTOR) connection management implementation.

WebCoreSupport/WebInspectorClient.h:
WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::indicate):
(WebInspectorClient::hideIndicate):
Hook up WebView indication through this new path.

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidReceiveTitle):

WebCoreSupport/WebInspectorClient.h:
WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::inspectorDestroyed):

WebInspector/remote/WebInspectorClientRegistry.h: Removed.
WebInspector/remote/WebInspectorClientRegistry.mm: Removed.
WebInspector/remote/WebInspectorRelayDefinitions.h: Removed.
WebInspector/remote/WebInspectorRemoteChannel.h: Removed.
WebInspector/remote/WebInspectorRemoteChannel.mm: Removed.
WebInspector/remote/WebInspectorServer.h: Removed.
WebInspector/remote/WebInspectorServer.mm: Removed.
WebInspector/remote/WebInspectorServerWebViewConnection.h: Removed.
WebInspector/remote/WebInspectorServerWebViewConnection.mm: Removed.
WebInspector/remote/WebInspectorServerWebViewConnectionController.h: Removed.
WebInspector/remote/WebInspectorServerWebViewConnectionController.mm: Removed.
WebInspector/remote/WebInspectorXPCWrapper.h: Removed.
WebInspector/remote/WebInspectorXPCWrapper.m: Removed.
WebKit.exp:
WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(+[WebView _enableRemoteInspector]):
(+[WebView _disableRemoteInspector]):
(+[WebView _disableAutoStartRemoteInspector]):
(+[WebView _isRemoteInspectorEnabled]):
(+[WebView _hasRemoteInspectorSession]):
(-[WebView allowsRemoteInspection]):
(-[WebView setAllowsRemoteInspection:]):
(-[WebView setIndicatingForRemoteInspector:]):
(-[WebView setHostApplicationBundleId:name:]):
(-[WebView _didCommitLoadForFrame:]):

WebView/WebViewData.h:
WebView/WebViewData.mm:

(-[WebViewPrivate init]):
(-[WebViewPrivate dealloc]):

WebView/WebViewInternal.h:
WebView/WebViewPrivate.h:

Remove old REMOTE_INSPECTOR.

Source/WebKit/win:

WebCoreSupport/WebInspectorClient.h:

Source/WebKit/wince:

WebCoreSupport/InspectorClientWinCE.h:

Source/WebKit2:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

WebProcess/com.apple.WebProcess.sb.in:

Allow the WebProcess to access the "com.apple.webinspector" named
XPC service to expose its WebCore::Page's to remote debuggers.

Source/WTF:

wtf/ios/WebCoreThread.cpp:
wtf/ios/WebCoreThread.h:

Expose WebThreadRun/WebThreadRunSync iOS methods defined in WebCore through
WTF so that JavaScriptCore can use it. Another such method already existed.

10:20 AM Changeset in webkit [160098] by Joseph Pecoraro

2 edits in trunk/Source/WebCore

Web Inspector: Add missing folders and files to Xcode project
https://bugs.webkit.org/show_bug.cgi?id=124802

Reviewed by Timothy Hatcher.

WebCore.xcodeproj/project.pbxproj:

10:00 AM Changeset in webkit [160097] by dfarler@apple.com

2 edits in trunk/Source/WebKit2

Use All-iOS target when building WK2 on iOS
<rdar://problem/15574494>

Reviewed by David Kilzer.

Makefile:

Add -target All-iOS to OTHER_OPTIONS if iphoneos or iphonesimulator
is in the SDKROOT make option.

9:49 AM Changeset in webkit [160096] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[texmap] Borders on rotating images are hidden/wrongly rendered with edge distance antialiasing
https://bugs.webkit.org/show_bug.cgi?id=124653

Patch by José Dapena Paz <jdapena@igalia.com> on 2013-12-04
Reviewed by Noam Rosenthal.

Texture mapper edge distance antialiasing texture sampling was causing
borders to be shaded (and made them almost disappear in some cases).
This was because calculation of sampling happened on vertex shader, so
the border of the texture would go to the border of the inflation area.

What algorithm should do is sampling the border pixel for all the
inflation area (it is the closest pixel to all the samples in
inflation area), and then use the standard sampling for the other
parts of the texture.

No new test because this is already covered by test
transforms/3d/point-mapping/3d-point-mapping.html

platform/graphics/texmap/TextureMapperShaderProgram.cpp: fix edge

distance antialiasing texture sampling.

9:40 AM Changeset in webkit [160095] by mario.prada@samsung.com

1 edit
1 move
1 delete in trunk/LayoutTests

Unreviewed GTK gardening. Updated expectations for GTK and share them with EFL.

accessibility/multiselect-list-reports-active-option-expected.txt: Renamed from LayoutTests/platform/efl/multiselect-list-reports-active-option-expected.txt.
platform/gtk/accessibility/multiselect-list-reports-active-option-expected.txt: Removed.

8:40 AM Changeset in webkit [160094] by msaboff@apple.com

26 edits
2 adds in trunk/Source/JavaScriptCore

Move the setting up of callee's callFrame from pushFrame to callToJavaScript thunk
https://bugs.webkit.org/show_bug.cgi?id=123999

Reviewed by Filip Pizlo.

Changed LLInt and/or JIT enabled ports to allocate the stack frame in the
callToJavaScript stub. Added an additional stub, callToNativeFunction that
allocates a stack frame in a similar way for calling native entry points
that take a single ExecState* argument. These stubs are implemented
using common macros in LowLevelInterpreter{32_64,64}.asm. There are also
Windows X86 and X86-64 versions in the corresponding JitStubsXX.h.
The stubs allocate and create a sentinel frame, then create the callee's
frame, populating the header and arguments from the passed in ProtoCallFrame*.
It is assumed that the caller of either stub does a check for enough stack space
via JSStack::entryCheck().

For ports using the C-Loop interpreter, the prior method for allocating stack
frame and invoking functions is used, namely with JSStack::pushFrame() and
::popFrame().

Made spelling changes "sentinal" -> "sentinel".

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall):
(JSC::CachedCall::setThis):
(JSC::CachedCall::setArgument):

interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::resetCallFrame):

interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):

interpreter/Interpreter.h:
interpreter/JSStack.h:
interpreter/JSStackInlines.h:

(JSC::JSStack::entryCheck):
(JSC::JSStack::pushFrame):
(JSC::JSStack::popFrame):

interpreter/ProtoCallFrame.cpp: Added.

(JSC::ProtoCallFrame::init):

interpreter/ProtoCallFrame.h: Added.

(JSC::ProtoCallFrame::codeBlock):
(JSC::ProtoCallFrame::setCodeBlock):
(JSC::ProtoCallFrame::setScope):
(JSC::ProtoCallFrame::setCallee):
(JSC::ProtoCallFrame::argumentCountIncludingThis):
(JSC::ProtoCallFrame::argumentCount):
(JSC::ProtoCallFrame::setArgumentCountIncludingThis):
(JSC::ProtoCallFrame::setPaddedArgsCount):
(JSC::ProtoCallFrame::clearCurrentVPC):
(JSC::ProtoCallFrame::setThisValue):
(JSC::ProtoCallFrame::setArgument):

jit/JITCode.cpp:

(JSC::JITCode::execute):

jit/JITCode.h:
jit/JITOperations.cpp:
jit/JITStubs.h:
jit/JITStubsMSVC64.asm:
jit/JITStubsX86.h:
llint/LLIntOffsetsExtractor.cpp:
llint/LLIntThunks.h:
llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/ArgList.h:

(JSC::ArgList::data):

runtime/JSArray.cpp:

(JSC::AVLTreeAbstractorForArrayCompare::compare_key_key):

runtime/StringPrototype.cpp:

(JSC::replaceUsingRegExpSearch):

8:13 AM Changeset in webkit [160093] by commit-queue@webkit.org

2 edits
2 adds in trunk/Tools

Style checker for .messages.in files (WTF:: prefix)
https://bugs.webkit.org/show_bug.cgi?id=125142

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-04
Reviewed by Anders Carlsson.

A new style checker for .messages.in files, that checks for the use of WTF::
prefix in these files. (Also checks for tabs as these files were previously
handled as text files.)

Scripts/webkitpy/style/checker.py:

(CheckerDispatcher._create_checker):

New checker is returned for .messages.in files.

Scripts/webkitpy/style/checkers/messagesin.py: Added. The new style checker class.

(MessagesInChecker):
(MessagesInChecker.init):
(MessagesInChecker.check):
(MessagesInChecker.check_WTF_prefix):

Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added. Unit test for the new style checker class.

(MessagesInCheckerStyleTestCase):
(test_checker):
(test_checker.error_handler_for_test):
(MessagesInCheckerTestCase):
(MessagesInCheckerTestCase.test_init):
(MessagesInCheckerTestCase.test_init.error_handler_for_test):

6:43 AM Changeset in webkit [160092] by commit-queue@webkit.org

14 edits in trunk/Source/JavaScriptCore

Remove stdio.h from JSC files.
https://bugs.webkit.org/show_bug.cgi?id=125220

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-04
Reviewed by Michael Saboff.

interpreter/VMInspector.cpp:
jit/JITArithmetic.cpp:
jit/JITArithmetic32_64.cpp:
jit/JITCall.cpp:
jit/JITCall32_64.cpp:
jit/JITPropertyAccess.cpp:
jit/JITPropertyAccess32_64.cpp:
runtime/Completion.cpp:
runtime/IndexingType.cpp:
runtime/Lookup.h:
runtime/Operations.cpp:
runtime/Options.cpp:
runtime/RegExp.cpp:

6:42 AM Changeset in webkit [160091] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Avoid to add zero offset in BaseIndex.
https://bugs.webkit.org/show_bug.cgi?id=125215

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-04
Reviewed by Michael Saboff.

When using cloop do not generate offsets additions for BaseIndex if the offset is zero.

offlineasm/cloop.rb:

5:49 AM Changeset in webkit [160090] by commit-queue@webkit.org

3 edits in trunk/Tools

Style checker requires alphabetical ordering in cmake lists even it contains variable.
https://bugs.webkit.org/show_bug.cgi?id=124918

Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-12-04
Reviewed by Csaba Osztrogonác.

Scripts/webkitpy/style/checkers/cmake_unittest.py:

(CMakeCheckerTest.test_check):

Scripts/webkitpy/style/checkers/cmake.py:

(CMakeChecker._check_list_order):
This will ignore lines with variable substitution.

4:30 AM Changeset in webkit [160089] by commit-queue@webkit.org

4 edits in trunk

Allow --cloop option to work correctly in case of EFL.
https://bugs.webkit.org/show_bug.cgi?id=125217

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-04
Reviewed by Zoltan Herczeg.

Source/cmake/OptionsEfl.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmakeconfig.h.cmake:

4:20 AM Changeset in webkit [160088] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.2.3

Tagging the WebKitGTK+ 2.2.3 release

3:54 AM Changeset in webkit [160087] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.2

Unreviewed. Update NEWS and Versions.m4 for 2.2.3 release.

Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

NEWS: Add release notes.

3:20 AM Changeset in webkit [160086] by commit-queue@webkit.org

3 edits in trunk/Tools

check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
https://bugs.webkit.org/show_bug.cgi?id=124731

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-04
Reviewed by Zoltan Herczeg.

Scripts/webkitpy/style/checkers/cpp.py:

(check_spacing):

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):

3:19 AM Changeset in webkit [160085] by commit-queue@webkit.org

3 edits in trunk/Tools

Remove codecs and os dependencies from filereader.py in webkitpy/style.
https://bugs.webkit.org/show_bug.cgi?id=124719

Although TextFileReader requires a FileSystem it circumvents it in two places!
We should use the FileSystem only and remove codecs and os imports.

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-04
Reviewed by Zoltan Herczeg.

Scripts/webkitpy/common/system/filesystem.py:

(FileSystem.open_stdin): Moved from TextFileReader

Scripts/webkitpy/style/filereader.py:

(TextFileReader._read_lines): use FileSystem instead of calling codecs.open directly
(TextFileReader._process_directory): use FileSystem instead of calling os.walk directly

3:11 AM Changeset in webkit [160084] by commit-queue@webkit.org

3 edits in trunk/Tools

check-webkit-style should check member initialization indentation.
https://bugs.webkit.org/show_bug.cgi?id=124820

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-04
Reviewed by Zoltan Herczeg.

check-webkit-style should check member initialization indentation
belongs to webkit coding style:
http://www.webkit.org/coding/coding-style.html#punctuation-member-init

Scripts/webkitpy/style/checkers/cpp.py:

(check_member_initialization_list): Add new method to check member
initialization list.
(check_style): Add the call of the new method.
(check_language): Move self initialization checking into the new method.
(CppChecker): Add a new category for initialization list.

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_runtime_selfinit):
(CppStyleTest.test_deprecated_cast):
(WebKitStyleTest.test_member_initialization_list): Add new testcases for
the new feature.

3:08 AM Changeset in webkit [160083] by commit-queue@webkit.org

8 edits in trunk/Tools

style-bot should reject Committer additions to committers.py
https://bugs.webkit.org/show_bug.cgi?id=107574

Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-12-04
Reviewed by Zoltan Herczeg.

The style check when executed in non-interactive mode (probably by a
bot) will raise an additional error if the contributors.json file is
modified. Non-interactive mode information is propagated to the
Dispatcher, which creates a special JSON checker for the
contributors.json file.

Scripts/webkitpy/style/checker.py:

(check_webkit_style_configuration):
(CheckerDispatcher._create_checker):
(CheckerDispatcher.dispatch):
(StyleProcessorConfiguration.init):
(StyleProcessor.process):

Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherSkipTest._assert_should_skip_without_warning):
(CheckerDispatcherDispatchTest.dispatch):
(StyleProcessorConfigurationTest._style_checker_configuration):
(StyleProcessor_EndToEndTest.test_init):
(StyleProcessor_EndToEndTest.test_process):
(StyleProcessor_CodeCoverageTest.MockDispatcher.dispatch):
(StyleProcessor_CodeCoverageTest.setUp):

Scripts/webkitpy/style/checkers/jsonchecker.py:

(JSONChecker.line_number_from_json_exception):
(JSONContributorsChecker):
(JSONContributorsChecker.check):

Scripts/webkitpy/style/error_handlers_unittest.py:

(DefaultStyleErrorHandlerTest._style_checker_configuration):

Scripts/webkitpy/style/optparser.py:

(CommandOptionValues.init):
(ArgumentParser._create_option_parser):
(ArgumentParser.parse):

Scripts/webkitpy/tool/commands/upload_unittest.py:

(test_post):
(test_upload):

Scripts/webkitpy/tool/steps/checkstyle.py:

(CheckStyle.run):

1:57 AM Changeset in webkit [160082] by commit-queue@webkit.org

8 edits in trunk/Source/JavaScriptCore

Fix !ENABLE(JAVASCRIPT_DEBUGGER) build.
https://bugs.webkit.org/show_bug.cgi?id=125083

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-12-04
Reviewed by Mark Lam.

debugger/Debugger.cpp:
debugger/Debugger.h:

(JSC::Debugger::Debugger):
(JSC::Debugger::needsOpDebugCallbacks):
(JSC::Debugger::needsExceptionCallbacks):
(JSC::Debugger::detach):
(JSC::Debugger::sourceParsed):
(JSC::Debugger::exception):
(JSC::Debugger::atStatement):
(JSC::Debugger::callEvent):
(JSC::Debugger::returnEvent):
(JSC::Debugger::willExecuteProgram):
(JSC::Debugger::didExecuteProgram):
(JSC::Debugger::didReachBreakpoint):

debugger/DebuggerPrimitives.h:
jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_debug):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_debug):

llint/LLIntOfflineAsmConfig.h:
llint/LowLevelInterpreter.asm:

1:56 AM Changeset in webkit [160081] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r159314 - [Cairo] Avoid extra copy when drawing images
https://bugs.webkit.org/show_bug.cgi?id=124209

Patch by Aloisio Almeida Jr <aloisio.almeida@openbossa.org> on 2013-11-14
Reviewed by Martin Robinson.

To solve the bug #58309 a cairo subsurface is being used to limit the
source image boundaries.
In many cases, when a cairo subsurface is used for drawing an image,
it occurs an image copy, causing performance penalty. In the case of
the function PlatformContextCairo::drawSurfaceToContext, the image
copy always happens.
So, we should use the subsurface only when it's really necessary.
In cases where we're drawing the whole image, the subsurface is
unnecessary.

The proposed patch avoid the use of subsurfaces when sampling the whole
image.

No new tests. It's an enhancement. Already covered by existing tests.

platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::drawSurfaceToContext):

1:52 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

1:47 AM Changeset in webkit [160080] by Carlos Garcia Campos

12 edits in releases/WebKitGTK/webkit-2.2/Source

Merge r154819 - [cairo] canvas drawing on itself doesn't work with accelerated canvas
https://bugs.webkit.org/show_bug.cgi?id=118808

Reviewed by Martin Robinson.

Source/WebCore:

When copying an accelerated image, we try to get its dimensions with
cairo_image_surface_get_width/cairo_image_surface_get_height. As
surface is not an image, this returns width and height of 0.

Many other places use cairo_image_surface_get although the surface may
be a gl surface.

This patch fixes those issues by implementing a cairoSurfaceSize
helper that returns the surface size whatever type it is.

It use cairo_surface_create_similar instead of
cairo_image_surface_create in copyCairoImageSurface. It also calls
cairo_paint in encodeImage when a drawing over a black background is
needed.

It copies the surface to an image surface if needed in extractImage.

No new tests. Covered by existing tests.

platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::checkForSolidColor):

platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::copyCairoImageSurface):
(WebCore::cairoSurfaceSize):

platform/graphics/cairo/CairoUtilities.h:
platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

platform/graphics/gtk/GdkCairoUtilities.cpp:

(cairoSurfaceToGdkPixbuf):

platform/graphics/gtk/GdkCairoUtilities.h:
platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::encodeImage):

platform/graphics/gtk/ImageGtk.cpp:

(WebCore::BitmapImage::getGdkPixbuf):

platform/gtk/DragIcon.cpp:

(WebCore::DragIcon::setImage):

Source/WebKit/gtk:

Change cairoImageSurfaceToGdkPixbuf to cairoSurfaceToGdkPixbuf.

webkit/webkitfavicondatabase.cpp:

(getIconPixbufSynchronously):

1:30 AM Changeset in webkit [160079] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore

Merge r154892 - Cleaning errorDescriptionForValue after r154839
https://bugs.webkit.org/show_bug.cgi?id=120531

Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-30
Reviewed by Darin Adler.

Changed the assert to ASSERT_NOT_REACHED, now that r154839 has landed. errorDescriptionForValue
can assert again that the parameterized JSValue is !isEmpty().

runtime/ExceptionHelpers.cpp:

(JSC::errorDescriptionForValue):

1:27 AM Changeset in webkit [160078] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore

Merge r154839 - REGRESSION(r153222, 32-bit): NULL JSValue() seen when running peacekeeper benchmark.
https://bugs.webkit.org/show_bug.cgi?id=120080

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-08-29
Reviewed by Michael Saboff.

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emitSlow_op_get_argument_by_val): Revert changes introduced by r153222 in this function.

1:26 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

1:21 AM Changeset in webkit [160077] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r159939 - [GTK] Fails to build with freetype 2.5.1
https://bugs.webkit.org/show_bug.cgi?id=125074

Patch by Andres Gomez <Andres Gomez> on 2013-12-02
Reviewed by Carlos Garcia Campos.

FreeType specifies a canonical way of including their own
headers. Now, we are following this recommendation so the
compilation won't be broken again due to an upgrade in FeeType's
including paths.

platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:

1:18 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

1:14 AM Changeset in webkit [160076] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

Typo fix after r160074 to fix debug builds.

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-04
Reviewed by Csaba Osztrogonác.

platform/text/BidiResolver.h:

(WebCore::MidpointState::stopIgnoringSpaces):

12:56 AM Changeset in webkit [160075] by Csaba Osztrogonác

72 edits in trunk

[EFL][WK2] Fix build after API::Client changes
https://bugs.webkit.org/show_bug.cgi?id=125206

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-04
Reviewed by Csaba Osztrogonác.

Source/WebKit2:

CMakeLists.txt:
GNUmakefile.list.am:
Shared/API/c/WKDeclarationSpecifiers.h:
UIProcess/API/C/CoordinatedGraphics/WKView.cpp:

(WKViewSetViewClient):

UIProcess/API/C/CoordinatedGraphics/WKView.h:
UIProcess/API/C/WKBatteryManager.cpp:

(WKBatteryManagerSetProvider):

UIProcess/API/C/WKBatteryManager.h:
UIProcess/API/C/WKNetworkInfoManager.cpp:

(WKNetworkInfoManagerSetProvider):

UIProcess/API/C/WKNetworkInfoManager.h:
UIProcess/API/C/WKTextChecker.cpp:

(WKTextCheckerSetClient):

UIProcess/API/C/WKTextChecker.h:
UIProcess/API/C/WKVibration.cpp:

(WKVibrationSetProvider):

UIProcess/API/C/WKVibration.h:
UIProcess/API/C/efl/WKPageEfl.cpp:

(WKPageSetUIPopupMenuClient):

UIProcess/API/C/efl/WKPageEfl.h:
UIProcess/API/C/gtk/WKFullScreenClientGtk.cpp:

(WKViewSetFullScreenClientGtk):

UIProcess/API/C/gtk/WKFullScreenClientGtk.h:
UIProcess/API/C/gtk/WKInspectorClientGtk.cpp:

(WKInspectorSetInspectorClientGtk):

UIProcess/API/C/gtk/WKInspectorClientGtk.h:
UIProcess/API/C/soup/WKSoupRequestManager.cpp:

(WKSoupRequestManagerSetClient):

UIProcess/API/C/soup/WKSoupRequestManager.h:
UIProcess/API/gtk/WebKitFullscreenClient.cpp:

(attachFullScreenClientToView):

UIProcess/API/gtk/WebKitRequestManagerClient.cpp:

(attachRequestManagerClientToContext):

UIProcess/API/gtk/WebKitTextChecker.cpp:

(WebKitTextChecker::WebKitTextChecker):

UIProcess/API/gtk/WebKitWebInspector.cpp:

(webkitWebInspectorCreate):

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseInitializeFullScreenClient):

UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::initializeClient):

UIProcess/CoordinatedGraphics/WebView.h:
UIProcess/CoordinatedGraphics/WebViewClient.cpp:

(WebKit::WebViewClient::viewNeedsDisplay):
(WebKit::WebViewClient::didChangeContentsSize):
(WebKit::WebViewClient::webProcessCrashed):
(WebKit::WebViewClient::webProcessDidRelaunch):
(WebKit::WebViewClient::didChangeContentsPosition):
(WebKit::WebViewClient::didRenderFrame):
(WebKit::WebViewClient::didCompletePageTransition):
(WebKit::WebViewClient::didChangeViewportAttributes):
(WebKit::WebViewClient::didChangeTooltip):
(WebKit::WebViewClient::didFindZoomableArea):
(WebKit::WebViewClient::doneWithTouchEvent):

UIProcess/CoordinatedGraphics/WebViewClient.h:
UIProcess/WebBatteryManagerProxy.cpp:

(WebKit::WebBatteryManagerProxy::initializeProvider):

UIProcess/WebBatteryManagerProxy.h:
UIProcess/WebBatteryProvider.cpp:

(WebKit::WebBatteryProvider::startUpdating):
(WebKit::WebBatteryProvider::stopUpdating):

UIProcess/WebBatteryProvider.h:
UIProcess/WebInspectorProxy.h:
UIProcess/WebNetworkInfoManagerProxy.cpp:

(WebKit::WebNetworkInfoManagerProxy::initializeProvider):

UIProcess/WebNetworkInfoManagerProxy.h:
UIProcess/WebNetworkInfoProvider.cpp:

(WebKit::WebNetworkInfoProvider::startUpdating):
(WebKit::WebNetworkInfoProvider::stopUpdating):
(WebKit::WebNetworkInfoProvider::bandwidth):
(WebKit::WebNetworkInfoProvider::isMetered):

UIProcess/WebNetworkInfoProvider.h:
UIProcess/WebPageProxy.h:
UIProcess/WebTextChecker.cpp:

(WebKit::WebTextChecker::setClient):

UIProcess/WebTextChecker.h:
UIProcess/WebTextCheckerClient.cpp:

(WebKit::WebTextCheckerClient::continuousSpellCheckingAllowed):
(WebKit::WebTextCheckerClient::continuousSpellCheckingEnabled):
(WebKit::WebTextCheckerClient::setContinuousSpellCheckingEnabled):
(WebKit::WebTextCheckerClient::grammarCheckingEnabled):
(WebKit::WebTextCheckerClient::setGrammarCheckingEnabled):
(WebKit::WebTextCheckerClient::uniqueSpellDocumentTag):
(WebKit::WebTextCheckerClient::closeSpellDocumentWithTag):
(WebKit::WebTextCheckerClient::checkSpellingOfString):
(WebKit::WebTextCheckerClient::checkGrammarOfString):
(WebKit::WebTextCheckerClient::spellingUIIsShowing):
(WebKit::WebTextCheckerClient::toggleSpellingUIIsShowing):
(WebKit::WebTextCheckerClient::updateSpellingUIWithMisspelledWord):
(WebKit::WebTextCheckerClient::updateSpellingUIWithGrammarString):
(WebKit::WebTextCheckerClient::guessesForWord):
(WebKit::WebTextCheckerClient::learnWord):
(WebKit::WebTextCheckerClient::ignoreWord):

UIProcess/WebTextCheckerClient.h:
UIProcess/WebVibrationProvider.cpp:

(WebKit::WebVibrationProvider::vibrate):
(WebKit::WebVibrationProvider::cancelVibration):

UIProcess/WebVibrationProvider.h:
UIProcess/WebVibrationProxy.cpp:

(WebKit::WebVibrationProxy::initializeProvider):

UIProcess/WebVibrationProxy.h:
UIProcess/efl/BatteryProvider.cpp:

(BatteryProvider::BatteryProvider):

UIProcess/efl/NetworkInfoProvider.cpp:

(NetworkInfoProvider::NetworkInfoProvider):

UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::PageUIClientEfl):

UIProcess/efl/RequestManagerClientEfl.cpp:

(WebKit::RequestManagerClientEfl::RequestManagerClientEfl):

UIProcess/efl/TextCheckerClientEfl.cpp:

(TextCheckerClientEfl::TextCheckerClientEfl):

UIProcess/efl/VibrationClientEfl.cpp:

(VibrationClientEfl::VibrationClientEfl):

UIProcess/efl/ViewClientEfl.cpp:

(WebKit::ViewClientEfl::ViewClientEfl):

UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::initializeUIPopupMenuClient):

UIProcess/efl/WebUIPopupMenuClient.cpp:

(WebUIPopupMenuClient::showPopupMenu):
(WebUIPopupMenuClient::hidePopupMenu):

UIProcess/efl/WebUIPopupMenuClient.h:
UIProcess/gtk/WebFullScreenClientGtk.cpp:

(WebKit::WebFullScreenClientGtk::willEnterFullScreen):
(WebKit::WebFullScreenClientGtk::willExitFullScreen):

UIProcess/gtk/WebFullScreenClientGtk.h:
UIProcess/gtk/WebInspectorClientGtk.cpp:

(WebKit::WebInspectorClientGtk::openWindow):
(WebKit::WebInspectorClientGtk::didClose):
(WebKit::WebInspectorClientGtk::bringToFront):
(WebKit::WebInspectorClientGtk::inspectedURLChanged):
(WebKit::WebInspectorClientGtk::attach):
(WebKit::WebInspectorClientGtk::detach):
(WebKit::WebInspectorClientGtk::didChangeAttachedHeight):

UIProcess/gtk/WebInspectorClientGtk.h:
UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::initializeInspectorClientGtk):

UIProcess/soup/WebSoupRequestManagerClient.cpp:

(WebKit::WebSoupRequestManagerClient::didReceiveURIRequest):
(WebKit::WebSoupRequestManagerClient::didFailToLoadURIRequest):

UIProcess/soup/WebSoupRequestManagerClient.h:
UIProcess/soup/WebSoupRequestManagerProxy.cpp:

(WebKit::WebSoupRequestManagerProxy::initializeClient):

UIProcess/soup/WebSoupRequestManagerProxy.h:

Tools:

TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:

(TestWebKitAPI::setViewClient):

12:29 AM Changeset in webkit [160074] by zoltan@webkit.org

4 edits in trunk/Source/WebCore

Move space-ignoring inline functions into MidpointState
<https://webkit.org/b/124957>

Reviewed by David Hyatt.

Since:

The following inline functions were used only with a mandatory LineMidpointState argument: startIgnoringSpaces, stopIgnoringSpaces, ensureLineBoxInsideIgnoredSpaces, deprecatedAddMidpoint.
TrailingObjects class uses these functions. Since they're inline in BreakingContextInlineHeaders.h, it's hard to separate TrailingObjects into it's own file. (blocks bug #124956) I made these functions as a member of LineMidpointState, and I also updated the call sites.

No new tests, no behavior change.

platform/text/BidiResolver.h:

(WebCore::MidpointState::startIgnoringSpaces):
(WebCore::MidpointState::stopIgnoringSpaces):
(WebCore::MidpointState::ensureLineBoxInsideIgnoredSpaces):
(WebCore::MidpointState::deprecatedAddMidpoint):

rendering/RenderBlock.h:
rendering/line/BreakingContextInlineHeaders.h:

(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):
(WebCore::BreakingContext::handleBR):
(WebCore::BreakingContext::handleOutOfFlowPositioned):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::BreakingContext::handleEmptyInline):
(WebCore::BreakingContext::handleReplaced):
(WebCore::ensureCharacterGetsLineBox):
(WebCore::BreakingContext::handleText):

Dec 3, 2013:

11:56 PM Changeset in webkit [160073] by zoltan@webkit.org

4 edits in trunk/Source/WebCore

Remove BreakingContext's friendship from RenderBlockFlow
<https://webkit.org/b/124958>

Reviewed by David Hyatt.

BreakingContext uses only 2 functions from RenderBlockFlow: insertFloatingObject/positionNewFloatOnLine. I added helper
functions to LineBreaker, what is already a friend of RenderBlockFlow, so BreakingContext doesn't need to be anymore.

No new tests, no behavior change.

rendering/RenderBlockFlow.h:
rendering/line/BreakingContextInlineHeaders.h:

(WebCore::BreakingContext::handleFloat):

rendering/line/LineBreaker.h:

(WebCore::LineBreaker::insertFloatingObject):
(WebCore::LineBreaker::positionNewFloatOnLine):

11:44 PM Changeset in webkit [160072] by rniwa@webkit.org

5 edits in trunk/Source/WebCore

bgColor, setBgColor, alinkColor, setAlinkColor, and etc... on HTMLBodyElement are useless
https://bugs.webkit.org/show_bug.cgi?id=125208

Reviewed by Antti Koivisto.

Merge https://chromium.googlesource.com/chromium/blink/+/49b1eeabbbf573d5271288c66d2b566cf33a09cf

These member functions of HTMLBodyElement were only used by corresponding functions in HTMLDocument
since they had the Reflect option specified in HTMLBodyElement.idl.

Removed the functions and directly called getAttribute and setAttribute in relevant functions in
HTMLDocument. The optimization to avoid assignment is no longer needed here since we've added that
optimization to setAttributeInternal a while ago.

html/HTMLBodyElement.cpp:
html/HTMLBodyElement.h:
html/HTMLDocument.cpp:

(WebCore::HTMLDocument::bgColor):
(WebCore::HTMLDocument::setBgColor):
(WebCore::HTMLDocument::fgColor):
(WebCore::HTMLDocument::setFgColor):
(WebCore::HTMLDocument::alinkColor):
(WebCore::HTMLDocument::setAlinkColor):
(WebCore::HTMLDocument::linkColor):
(WebCore::HTMLDocument::setLinkColor):
(WebCore::HTMLDocument::vlinkColor):
(WebCore::HTMLDocument::setVlinkColor):

html/HTMLDocument.h:

10:50 PM Changeset in webkit [160071] by mitz@apple.com

2 edits in trunk/Tools

Fixed a test timing out after r160040.

TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:

(-[SimpleLoadFailDelegate browsingContextController:didFailProvisionalLoadWithError:]):
Updated for the delegate method rename.

9:33 PM Changeset in webkit [160070] by akling@apple.com

4 edits in trunk/Source/WebCore

Add a CSSProperty::isDirectionAwareProperty() helper.
<https://webkit.org/b/125202>

Move the block of case labels for checking whether a CSS property ID
is a directional property into a separate function. Also removed an
outdated comment about CSS variables.

Reviewed by Antti Koivisto.

9:25 PM Changeset in webkit [160069] by Simon Fraser

3 edits in trunk/Source/WebKit2

WKContentView should just use InitializeWebKit2()
https://bugs.webkit.org/show_bug.cgi?id=125209

Reviewed by Benjamin Poulain.

Rather than calling an motley selection of init fuctions,
WKContentView should use the one true init function, InitializeWebKit2().

Shared/WebKit2Initialize.cpp: On iOS, we need to call InitWebCoreThreadSystemInterface().

(WebKit::InitializeWebKit2):

UIProcess/API/ios/WKContentView.mm: Remove various unused #imports.

(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

9:24 PM Changeset in webkit [160068] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Revert the inadvertently committed change.

html/HTMLElement.idl:

9:20 PM Changeset in webkit [160067] by rniwa@webkit.org

5 edits in trunk/Source/WebCore

Remove nodeIsDetachedFromDocument and visualWordMovementEnabled in FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=125210

Reviewed by Antti Koivisto.

Inspired by https://chromium.googlesource.com/chromium/blink/+/92409870f0ff8fafe31217830db0838a9e1ffb98

Removed some unused code.

editing/FrameSelection.cpp:

(WebCore::FrameSelection::textWasReplaced):

editing/FrameSelection.h:
page/Settings.in:

9:05 PM Changeset in webkit [160066] by Seokju Kwon

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove '_attachedWindowHeight' property in InspectorFrontendHostStub.js
https://bugs.webkit.org/show_bug.cgi?id=125204

Reviewed by Timothy Hatcher.

'_attachedWindowHeight' property is not used anywhere, so remove it.

UserInterface/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub):

8:21 PM Changeset in webkit [160065] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

Potential crash in RenderView::selectionBounds and RenderView::repaintSelection
https://bugs.webkit.org/show_bug.cgi?id=125207

Reviewed by Simon Fraser.

Merge https://chromium.googlesource.com/chromium/blink/+/f9e6e288a5aa959f05c374806121aaf0fc52d440

Update style in FrameSelection instead of RenderView's member functions. These are the last two
member functions of RenderView that updates the style.

editing/FrameSelection.cpp:

(WebCore::FrameSelection::focusedOrActiveStateChanged):
(WebCore::FrameSelection::bounds):

rendering/RenderView.cpp:

(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::repaintSelection):

7:23 PM Changeset in webkit [160064] by mrowe@apple.com

11 edits in trunk/Source/WebCore

<https://webkit.org/b/125143> Improve the formatting in the generated Objective-C headers.

Add a space between @property and any parenthesized attributes.
Prefer strong over retain when specifying memory management semantics.

Reviewed by Darin Adler.

bindings/objc/PublicDOMInterfaces.h:
bindings/scripts/CodeGeneratorObjC.pm:

(GetPropertyAttributes): Generate strong instead of retain. Include a
space before the parenthesis.

bindings/scripts/test/ObjC/DOMTestActiveDOMObject.h:
bindings/scripts/test/ObjC/DOMTestEventConstructor.h:
bindings/scripts/test/ObjC/DOMTestException.h:
bindings/scripts/test/ObjC/DOMTestInterface.h:
bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
bindings/scripts/test/ObjC/DOMTestTypedefs.h:
bindings/scripts/test/ObjC/DOMattribute.h:

6:19 PM Changeset in webkit [160063] by mark.lam@apple.com

4 edits in trunk/Source

testapi test crashes on Windows in WTF::Vector<wchar_t,64,WTF::UnsafeVectorOverflow>::size().
https://bugs.webkit.org/show_bug.cgi?id=121972.

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

interpreter/JSStack.cpp:

(JSC::JSStack::~JSStack):

Reverting the change from r160004 since it's better to fix OSAllocatorWin to be consistent with OSAllocatorPosix.

Source/WTF:

wtf/OSAllocatorWin.cpp:

(WTF::OSAllocator::decommit):
(WTF::OSAllocator::releaseDecommitted):

Added a check to ensure that the bytes to decommit / release is not 0. On Windows, a 0 length passed to VirtualFree() has a special meaning, and it's not "decommit / release nothing" as one would expect. Adding this check makes OSAllocatorWin consistent with OSAllocatorPosix for these 2 functions.

5:18 PM Changeset in webkit [160062] by mark.lam@apple.com

5 edits
1 add in trunk/Source/JavaScriptCore

Fix LLINT_C_LOOP build for Win64.
https://bugs.webkit.org/show_bug.cgi?id=125186.

Reviewed by Michael Saboff.

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
jit/JITOperationsMSVC64.cpp: Added.

(JSC::getHostCallReturnValueWithExecState):

Win64 will build JITStubMSVC64.asm even when !ENABLE(JIT). This results in a linkage error due to a missing getHostCallReturnValueWithExecState(). So, we add a stub getHostCallReturnValueWithExecState() here to satisfy that linkage. This function will never be called. The alternative to providing such a stub is to make the MSVC project recognize if the JIT is enabled or not, and exclude JITStubMSVC64.asm if it's not enabled. We don't currently set ENABLE(JIT) via the MSVC project and the work to do that is too much trouble for what we're trying to achieve here. So, we're opting for this simpler workaround instead.

llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

Don't build callToJavaScript if we're building the C loop. Otherwise, the C loop won't build if !ENABLE(COMPUTE_GOTO_OPCODES).

4:51 PM Changeset in webkit [160061] by ap@apple.com

20 edits
4 adds in trunk

Update WebCrypto JWK mapping to newer proposal
https://bugs.webkit.org/show_bug.cgi?id=124218

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/jwk-export-use-values.html

crypto/subtle/jwk-import-use-values.html

"extractable" renamed to "ext" in JWK.
New values for "use" mapping, which can now be combined into comma separated lists,

and cover all possible WebCrypto usages.

bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::JSCryptoKeySerializationJWK::reconcileUsages):
(WebCore::JSCryptoKeySerializationJWK::reconcileExtractable):
(WebCore::JSCryptoKeySerializationJWK::addJWKAlgorithmToJSON):
(WebCore::processUseValue):
(WebCore::JSCryptoKeySerializationJWK::addJWKUseToJSON):
(WebCore::JSCryptoKeySerializationJWK::serialize):

LayoutTests:

crypto/subtle/jwk-export-use-values-expected.txt: Added.
crypto/subtle/jwk-export-use-values.html: Added.
crypto/subtle/jwk-import-use-values-expected.txt: Added.
crypto/subtle/jwk-import-use-values.html: Added.

New tests for "use" mapping.

crypto/subtle/aes-cbc-import-jwk.html:
crypto/subtle/aes-cbc-unwrap-rsa.html:
crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html:
crypto/subtle/aes-cbc-wrap-rsa.html:
crypto/subtle/aes-export-key-expected.txt:
crypto/subtle/aes-export-key.html:
crypto/subtle/hmac-export-key-expected.txt:
crypto/subtle/hmac-export-key.html:
crypto/subtle/hmac-import-jwk.html:
crypto/subtle/import-jwk-expected.txt:
crypto/subtle/import-jwk.html:
crypto/subtle/rsa-export-key-expected.txt:
crypto/subtle/rsa-export-key.html:
crypto/subtle/rsa-export-private-key-expected.txt:
crypto/subtle/rsa-export-private-key.html:
crypto/subtle/rsa-oaep-key-manipulation-expected.txt:
crypto/subtle/rsa-oaep-key-manipulation.html:

4:51 PM Changeset in webkit [160060] by matthew_hanson@apple.com

3 edits in tags/Safari-538.7.1/Source/JavaScriptCore

Merge of 159593.

4:36 PM Changeset in webkit [160059] by andersca@apple.com

2 edits in trunk/Source/WebKit2

PageOverlayClientImpl should be a proper API::Client
https://bugs.webkit.org/show_bug.cgi?id=125199

Reviewed by Tim Horton.

WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(PageOverlayClientImpl::PageOverlayClientImpl):
(PageOverlayClientImpl::setAccessibilityClient):
(PageOverlayClientImpl::willMoveToWebPage):
(PageOverlayClientImpl::didMoveToWebPage):
(PageOverlayClientImpl::drawRect):
(PageOverlayClientImpl::mouseEvent):
(PageOverlayClientImpl::copyAccessibilityAttributeValue):
(PageOverlayClientImpl::copyAccessibilityAttributeNames):
(WKBundlePageOverlayCreate):
(WKBundlePageOverlaySetAccessibilityClient):

4:19 PM Changeset in webkit [160058] by matthew_hanson@apple.com

5 edits in tags/Safari-538.7.1/Source

Versioning.

4:13 PM Changeset in webkit [160057] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Initialize the PageBannerClientImpl API::Client
https://bugs.webkit.org/show_bug.cgi?id=125198

Reviewed by Tim Horton.

WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:

(PageBannerClientImpl::PageBannerClientImpl):

3:56 PM Changeset in webkit [160056] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

ARM64: Crash in JIT code due to improper reuse of cached memory temp register
https://bugs.webkit.org/show_bug.cgi?id=125181

Reviewed by Geoffrey Garen.

Changed load8() and load() to invalidate the memory temp CachedTempRegister when the
destination of an absolute load is the memory temp register since the source address
is also the memory temp register. Change branch{8,32,64} of an AbsoluteAddress with
a register to use the dataTempRegister as the destinate of the absolute load to
reduce the chance that we need to invalidate the memory temp register cache.
In the process, found and fixed an outright bug in branch8() where we'd load into
the data temp register and then compare and branch on the memory temp register.

assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::load8):
(JSC::MacroAssemblerARM64::branch32):
(JSC::MacroAssemblerARM64::branch64):
(JSC::MacroAssemblerARM64::branch8):
(JSC::MacroAssemblerARM64::load):

3:54 PM Changeset in webkit [160055] by matthew_hanson@apple.com

1 copy in tags/Safari-538.7.1

New tag.

3:44 PM Changeset in webkit [160054] by bshafiei@apple.com

5 edits in branches/safari-537.60-branch/Source

Versioning.

3:41 PM Changeset in webkit [160053] by ryuan.choi@samsung.com

2 edits in trunk

[EFL] Disable RTTI for release build
https://bugs.webkit.org/show_bug.cgi?id=125138

Reviewed by Gyuyoung Kim.

Binary size will be reduced about 1M bytes without RTTI.
ewebkit.so : 43,449,275 -> 42,510,224
ewebkit2.so: 46,715,870 -> 45,653,989

Source/cmake/OptionsEfl.cmake: Added -fno-rtti option to CMAKE_CXX_FLAGS_RELEASE.

3:28 PM Changeset in webkit [160052] by timothy_horton@apple.com

5 edits in trunk/Source/WebKit2

Remote Layer Tree: Force repaint
https://bugs.webkit.org/show_bug.cgi?id=125189
<rdar://problem/15541789>

Reviewed by Anders Carlsson.

WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::forceRepaint):

WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::forceRepaint):
Implement WebProcess-synchronous force repaint.
We don't need the async variant because it is only needed
to synchronize with the WebProcess-side threaded scrolling
tree, which is not a component of the remote layer tree model.
The UI process will not handle the callback until after
RemoteLayerTreeHost::commit is complete, ensuring that the commit
is actually done.

3:26 PM Changeset in webkit [160051] by fpizlo@apple.com

2 edits in trunk/Tools

REGRESSION: repro scripts disappear when you rerun tests
https://bugs.webkit.org/show_bug.cgi?id=125184

Reviewed by Mark Hahnenberg.

This bug made it difficult to quickly see if a test that recently failed is still
failing while also running a new batch of tests.

Repro scripts are supposed to stay around until you delete them explicitly. This
patch accomplishes that.

Scripts/run-jsc-stress-tests:

3:25 PM Changeset in webkit [160050] by Simon Fraser

7 edits in trunk/Source

Remove some iOS-related documentScale code
https://bugs.webkit.org/show_bug.cgi?id=125194

Source/WebCore:

Reviewed by Enrica Casucci.

Remove exports of nonexistent documentScale-related functions on Frame.

WebCore.exp.in:

Source/WebKit2:

Reviewed by Enrica Casucci.

Upstream bits of removal of Frame::documentScale on iOS.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Whitespace.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::didFinishZooming): Don't call setDocumentScale().

WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h: Remove minimumDocumentScale().
WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm: Ditto.

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea): We delegate page scaling on iOS.
(WebKit::RemoteLayerTreeDrawingArea::setDeviceScaleFactor):

3:21 PM Changeset in webkit [160049] by ap@apple.com

2 edits in trunk/LayoutTests

Layout Test platform/mac/accessibility/search-predicate-element-count.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=125195

platform/mac/TestExpectations: Marking as such.

3:20 PM Changeset in webkit [160048] by commit-queue@webkit.org

3 edits in trunk/Tools

[Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
https://bugs.webkit.org/show_bug.cgi?id=125111

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-12-03
Reviewed by Filip Pizlo.

Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.

Scripts/run-javascriptcore-tests: Enable api test and stress test for WinCairo.
Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.

3:19 PM Changeset in webkit [160047] by andersca@apple.com

2 edits in trunk/Source/WebKit2

PageBannerClientImpl should be an API::Client
https://bugs.webkit.org/show_bug.cgi?id=125190

Reviewed by Tim Horton.

WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:

(PageBannerClientImpl::PageBannerClientImpl):
(PageBannerClientImpl::~PageBannerClientImpl):
(WKBundlePageBannerCreateBannerWithCALayer):

3:03 PM Changeset in webkit [160046] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

Fix regression caused by r158599
https://bugs.webkit.org/show_bug.cgi?id=125188

Reviewed by Jer Noble.

html/HTMLMediaElement.cpp:

(HTMLMediaElement::clearMediaPlayer): Do not clear m_player when PLUGIN_PROXY_FOR_VIDEO

is enabled.

2:50 PM Changeset in webkit [160045] by commit-queue@webkit.org

15 edits in trunk/Source/WebCore

Nix Upstream: Updating WebCore files
https://bugs.webkit.org/show_bug.cgi?id=124981

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-12-03
Reviewed by Benjamin Poulain.

Just to sync our github repo files and the trunk, as part of the upstream process

No new tests needed.

PlatformNix.cmake:
css/mediaControlsNix.css:

(audio):
(video::-webkit-media-controls):
(audio::-webkit-media-controls-enclosure, video::-webkit-media-controls-enclosure):
(video::-webkit-media-controls-enclosure):
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(video:-webkit-full-page-media):
(audio:-webkit-full-page-media, video:-webkit-full-page-media):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-overlay-play-button, video::-webkit-media-controls-overlay-play-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
(input[type="range"]::-webkit-media-slider-container):
(input[type="range"]::-webkit-media-slider-container > div):
(input[type="range"]::-webkit-media-slider-thumb):
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-fullscreen-volume-slider, video::-webkit-media-controls-fullscreen-volume-slider):
(audio::-webkit-media-controls-fullscreen-volume-min-button, video::-webkit-media-controls-fullscreen-volume-min-button):
(audio::-webkit-media-controls-fullscreen-volume-max-button, video::-webkit-media-controls-fullscreen-volume-max-button):
(video::-webkit-media-text-track-container):
(video::cue):
(video::-webkit-media-text-track-region):
(video::-webkit-media-text-track-region-container):
(video::-webkit-media-text-track-region-container.scrolling):
(video::-webkit-media-text-track-display):
(video::cue(:future)):
(video::-webkit-media-text-track-container b):
(video::-webkit-media-text-track-container u):
(video::-webkit-media-text-track-container i):

editing/Editor.cpp:

(WebCore::Editor::cut):
(WebCore::Editor::copy):
(WebCore::Editor::copyImage):

editing/Editor.h:
html/HTMLCanvasElement.h:
platform/Cursor.h:
platform/audio/FFTFrame.h:
platform/audio/nix/AudioBusNix.cpp:

(WebCore::AudioBus::loadPlatformResource):

platform/graphics/GLContext.h:
platform/nix/CursorNix.cpp:

(WebCore::Cursor::ensurePlatformCursor):

platform/nix/GamepadsNix.cpp:

(WebCore::sampleGamepads):

platform/nix/RenderThemeNix.cpp:

(WebCore::toIntSize):
(WebCore::toNixRect):
(WebCore::RenderThemeNix::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeNix::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeNix::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeNix::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeNix::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeNix::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeNix::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeNix::platformInactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeNix::platformActiveTextSearchHighlightColor):
(WebCore::RenderThemeNix::platformInactiveTextSearchHighlightColor):
(WebCore::RenderThemeNix::platformFocusRingColor):
(WebCore::RenderThemeNix::platformTapHighlightColor):
(WebCore::RenderThemeNix::paintButton):
(WebCore::RenderThemeNix::paintTextField):
(WebCore::RenderThemeNix::paintCheckbox):
(WebCore::RenderThemeNix::setCheckboxSize):
(WebCore::RenderThemeNix::paintRadio):
(WebCore::RenderThemeNix::setRadioSize):
(WebCore::RenderThemeNix::paintMenuList):
(WebCore::RenderThemeNix::paintProgressBar):
(WebCore::RenderThemeNix::paintSliderTrack):
(WebCore::RenderThemeNix::paintSliderThumb):
(WebCore::RenderThemeNix::paintInnerSpinButton):
(WebCore::RenderThemeNix::paintMeter):
(WebCore::RenderThemeNix::extraMediaControlsStyleSheet):
(WebCore::RenderThemeNix::paintMediaPlayButton):
(WebCore::RenderThemeNix::paintMediaMuteButton):
(WebCore::RenderThemeNix::paintMediaSeekBackButton):
(WebCore::RenderThemeNix::paintMediaSeekForwardButton):
(WebCore::RenderThemeNix::paintMediaSliderTrack):
(WebCore::RenderThemeNix::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeNix::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeNix::paintMediaRewindButton):

platform/nix/RenderThemeNix.h:
rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

2:43 PM Changeset in webkit [160044] by commit-queue@webkit.org

6 edits in trunk/Source

Typo: FixedPositionConstaint -> FixedPositionConstraint
https://bugs.webkit.org/show_bug.cgi?id=125171

Patch by Ralph Thomas <ralpht@gmail.com> on 2013-12-03
Reviewed by Simon Fraser.

Source/WebCore:

No new tests, no change in behavior.

page/scrolling/ScrollingConstraints.h:
page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:

(WebCore::ScrollingCoordinatorCoordinatedGraphics::updateViewportConstrainedNode):

page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::updateViewportConstrainedNode):

Source/WebKit/ios:

WebCoreSupport/WebFixedPositionContent.mm:

(-[WebFixedPositionContent scrollOrZoomChanged:]):

2:38 PM Changeset in webkit [160043] by rniwa@webkit.org

2 edits in trunk/Tools

Add a script to automatically configure a git clone
https://bugs.webkit.org/show_bug.cgi?id=110073

Revert the change to use https for now since git.webkit.org is setup with http.

Scripts/webkitpy/tool/commands/setupgitclone.py:

(SetupGitClone.execute):

2:38 PM Changeset in webkit [160042] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

jit/JITArithmetic.cpp doesn't build for non-X86 ports
https://bugs.webkit.org/show_bug.cgi?id=125185

Rubber stamped by Mark Hahnenberg.

Removed unused declarations and related UNUSED_PARAM().

jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_mod):

2:35 PM Changeset in webkit [160041] by Manuel Rego Casasnovas

2 edits in trunk/PerformanceTests

[CSS Regions] Fix Layout/RegionsSelection.html in Mac platform
https://bugs.webkit.org/show_bug.cgi?id=124963

Reviewed by Ryosuke Niwa.

Layout/RegionsSelection.html introduced in r159488 was not working in
Mac platform because of it was trying to use mouse events out of the
window dimensions. Use collapse() and extend() methods from Selection
object to solve the issue.

Layout/resources/regions.js: Use collapse() and extend() instead of

mouse events.

2:32 PM Changeset in webkit [160040] by mitz@apple.com

3 edits in trunk/Source/WebKit2

[Cocoa] Give two load delegate methods more conventional names
https://bugs.webkit.org/show_bug.cgi?id=125183

Reviewed by Anders Carlsson.

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(didFailProvisionalLoadWithErrorForFrame): Updated for rename.
(didFailLoadWithErrorForFrame): Ditto.

UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h: Renamed

-browsingContextControllerDidFailProvisionalLoad:withError: to
-browsingContextController:didFailProvisionalLoadWithError: and
-browsingContextControllerDidFailLoad:withError: to
-browsingContextController:didFailLoadWithError:.

2:29 PM Changeset in webkit [160039] by rniwa@webkit.org

2 edits
1 add in trunk/Tools

Add a script to automatically configure a git clone
https://bugs.webkit.org/show_bug.cgi?id=110073

Reviewed by Benjamin Poulain.

Added "webkit-patch setup-git-clone" to setup a brand new Git clone.

This command runs various commands listed on http://trac.webkit.org/wiki/UsingGitWithWebKit

Scripts/webkitpy/tool/commands/init.py:
Scripts/webkitpy/tool/commands/setupgitclone.py: Added.

(SetupGitClone):
(SetupGitClone.execute):

2:24 PM Changeset in webkit [160038] by fpizlo@apple.com

5 edits in trunk/Source/JavaScriptCore

ObjectAllocationProfile is racy and the DFG should be cool with that
https://bugs.webkit.org/show_bug.cgi?id=125172
<rdar://problem/15233487>

Reviewed by Mark Hahnenberg.

We would previously sometimes get a null Structure because checking if the profile is non-null and loading
the structure from it were two separate operations.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::setFuturePossibleStructure):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

runtime/JSFunction.h:

(JSC::JSFunction::allocationProfile):
(JSC::JSFunction::allocationStructure):

2:19 PM Changeset in webkit [160037] by rniwa@webkit.org

3 edits
8 adds in trunk/LayoutTests/imported/w3c

Import the XHTML parsing and serialization tests for template elements
https://bugs.webkit.org/show_bug.cgi?id=125131

Reviewed by Antti Koivisto.

Import the tests for parsing XHTML documents and fragments at f744661dbd0c29bb6a54c1530f9843838eec1300
after self-closing link elements in template-child-nodes-div.xhtml and template-child-nodes-nested.xhtml
as these two files would encounter parser errors otherwise (I'll be merging these changes back into
the web-platform-tests repository later).

This completes the importation of W3C tests for the HTML template element.

html-templates/additions-to-parsing-xhtml-documents: Added.
html-templates/additions-to-parsing-xhtml-documents/node-document-expected.txt: Added.
html-templates/additions-to-parsing-xhtml-documents/node-document.html: Added.
html-templates/additions-to-parsing-xhtml-documents/template-child-nodes-expected.txt: Added.
html-templates/additions-to-parsing-xhtml-documents/template-child-nodes.html: Added.
html-templates/additions-to-serializing-xhtml-documents: Added.
html-templates/additions-to-serializing-xhtml-documents/outerhtml-expected.txt: Added.
html-templates/additions-to-serializing-xhtml-documents/outerhtml.html: Added.
html-templates/resources/template-child-nodes-div.xhtml:
html-templates/resources/template-child-nodes-nested.xhtml:

1:53 PM Changeset in webkit [160036] by andersca@apple.com

9 edits in trunk

Deprecate WKNotificationProvider
https://bugs.webkit.org/show_bug.cgi?id=125178

Reviewed by Sam Weinig.

Source/WebKit2:

Shared/API/c/WKDeclarationSpecifiers.h:

Add WK_DEPRECATED and WK_ENUM_DEPRECATED macros so we can things as deprecated.

UIProcess/API/C/WKNotificationManager.cpp:

(WKNotificationManagerSetProvider):

UIProcess/API/C/WKNotificationManager.h:

WKNotificationManagerSetProvider now takes a WKNotificationProviderBase.

UIProcess/API/C/WKNotificationProvider.h:

Deprecate WKNotificationProvider and kWKNotificationProviderCurrentVersion.

Tools:

Update for WebKit2 changes.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

WebKitTestRunner/WebNotificationProvider.cpp:

(WTR::WebNotificationProvider::provider):

WebKitTestRunner/WebNotificationProvider.h:

1:50 PM Changeset in webkit [160035] by Brent Fulgham

2 edits in trunk/Tools

[Win] Support 64-bit Application Support Libraries Location
https://bugs.webkit.org/show_bug.cgi?id=125179

Reviewed by Tim Horton.

Enable the user to specify a location for 64-bit support libraries (such as libxml2, ICU, etc.)
on Windows until an official distribution is available that properly creates registry settings
to specify these locations.

Scripts/webkitdirs.pm:

(setupAppleWinEnv): Notify user to set WEBKIT_64_SUPPORT environment variable if needed.
(setupCygwinEnv): Report WEWBKIT_64_SUPPORT path when running 64-bit builds.
(appleApplicationSupportPath): Add WEBKIT_64_SUPPORT location to runtime environment when
running 64-bit builds.

1:49 PM Changeset in webkit [160034] by bshafiei@apple.com

1 copy in tags/Safari-537.60.9

New tag.

1:21 PM Changeset in webkit [160033] by beidson@apple.com

9 edits in trunk/Source/WebKit2

Indexed Database work should be done on a non-main queue
https://bugs.webkit.org/show_bug.cgi?id=125127

Reviewed by Darin Adler.

Add a non-main WorkQueue to the DatabaseProcess:

DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::DatabaseProcess):
(WebKit::DatabaseProcess::queue):

DatabaseProcess/DatabaseProcess.h:

DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::UniqueIDBDatabase):
(WebKit::UniqueIDBDatabase::enqueueDatabaseQueueRequest): Add an AsyncRequest to the deque then schedule performing

the requests on the background WorkQueue.

(WebKit::UniqueIDBDatabase::processDatabaseRequestQueue): Processes all enqueued database requests.
(WebKit::UniqueIDBDatabase::getOrEstablishIDBDatabaseMetadata): Renamed from getIDBDatabaseMetadata().
(WebKit::UniqueIDBDatabase::getOrEstablishIDBDatabaseMetadataInternal): For doing i/o on a background queue/thread.

DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

Add a creator that takes the abort handler as an argument, and rename requestedCompleted()
to completeRequest(). This makes more sense in more situations:

Shared/AsyncRequest.cpp:

(WebKit::AsyncRequest::AsyncRequest):
(WebKit::AsyncRequest::setAbortHandler):

Shared/AsyncRequest.h:

(WebKit::AsyncRequest::completeRequest):

Update for the AsyncRequest rename:

WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::didGetOrEstablishIDBDatabaseMetadata):

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata):

12:58 PM Changeset in webkit [160032] by Samuel White

7 edits
2 adds in trunk

AXPress event coordinates are always sent as (0, 0)
https://bugs.webkit.org/show_bug.cgi?id=76677

Reviewed by Simon Fraser.

Make sure a press targets an element's center point.

accessibility/press-targets-center-point-expected.txt: Added.
accessibility/press-targets-center-point.html: Added.

Set the coordinates of a simulated press equal to the center of the target
element when the simulated press does not have a related mouse event.

Test: accessibility/press-targets-center-point.html

dom/Element.cpp: (WebCore::Element::clientRect): (WebCore::Element::screenRect):
dom/Element.h:
dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchSimulatedClick):
dom/MouseEvent.cpp: (WebCore::SimulatedMouseEvent::create): (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
dom/MouseEvent.h:

12:37 PM Changeset in webkit [160031] by timothy_horton@apple.com

4 edits
4 deletes in trunk/Source/WebKit2

Remove TiledCoreAnimationDrawingArea(Proxy)IOS
https://bugs.webkit.org/show_bug.cgi?id=125176

Reviewed by Simon Fraser.

Remove unused code.

UIProcess/API/ios/WKContentView.mm:
UIProcess/ios/TiledCoreAnimationDrawingAreaProxyIOS.h: Removed.
UIProcess/ios/TiledCoreAnimationDrawingAreaProxyIOS.mm: Removed.
Shared/DrawingAreaInfo.h:
WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

WebProcess/WebPage/ios/TiledCoreAnimationDrawingAreaIOS.h: Removed.
WebProcess/WebPage/ios/TiledCoreAnimationDrawingAreaIOS.mm: Removed.

12:21 PM Changeset in webkit [160030] by dino@apple.com

17 edits
6 adds in trunk

[WebGL] Implement OES texture float linear
https://bugs.webkit.org/show_bug.cgi?id=124871

Reviewed by Brent Fulgham.

Source/WebCore:

Implement the OES_texture_float_linear extension. Generally
we'd also enable OES_texture_half_float_linear at the same
time, but that's blocked on webkit.org/b/110936.

Test: fast/canvas/webgl/oes-texture-float-linear.html

CMakeLists.txt: Add new files.
DerivedSources.cpp: Ditto.
DerivedSources.make: Generate new file from IDL.
GNUmakefile.list.am: Add new files.
WebCore.vcxproj/WebCore.vcxproj: Ditto.
WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
WebCore.xcodeproj/project.pbxproj: New files for OESTextureFloatLinear.

bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS): Map the new name into the appropriate type.

html/canvas/OESTextureFloatLinear.cpp: Added. This is a very simple class

that's mostly empty.
(WebCore::OESTextureFloatLinear::OESTextureFloatLinear):
(WebCore::OESTextureFloatLinear::~OESTextureFloatLinear):
(WebCore::OESTextureFloatLinear::getName):
(WebCore::OESTextureFloatLinear::create):

html/canvas/OESTextureFloatLinear.h: Added.
html/canvas/OESTextureFloatLinear.idl: Added.

html/canvas/WebGLExtension.h: Declare the new name in the enum of extensions.

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::drawArrays): Call new name.
(WebCore::WebGLRenderingContext::drawElements): Call new name.
(WebCore::WebGLRenderingContext::getExtension): Create the new extension if asked.
(WebCore::WebGLRenderingContext::checkTextureCompleteness): Renamed from handleNPOTTextures. Now
checks for the type of the texture too.

html/canvas/WebGLRenderingContext.h: Member variable for new extension.

html/canvas/WebGLTexture.cpp:

(WebCore::WebGLTexture::WebGLTexture):
(WebCore::WebGLTexture::needToUseBlackTexture): Takes an extra parameter which indicates
if it has an extension enabled.
(WebCore::WebGLTexture::update): Note it is a float type when updating.

html/canvas/WebGLTexture.h: New flag to indicate float type.

platform/graphics/Extensions3D.h: New flag type.
platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::supportsExtension): Add a comment about the extension.

LayoutTests:

Add the Khronos test files for this extension.

Add the JS test file for OES_texture_float_linear and OES_texture_half_float_linear
even though it's only used for the former at the moment.

fast/canvas/webgl/oes-texture-float-linear.html: Added.
fast/canvas/webgl/resources/oes-texture-float-and-half-float-linear.js: Added.

12:18 PM Changeset in webkit [160029] by ap@apple.com

5 edits
2 adds in trunk

Support exporting private WebCrypto RSA keys
https://bugs.webkit.org/show_bug.cgi?id=124483

Reviewed by Anders Carlsson.

Source/WebCore:

Test: crypto/subtle/rsa-export-private-key.html

It might be better to have our own bignum implementation in WTF, but we currently
don't, and the need for this computation is Common Crypto specific anyway.

crypto/CommonCryptoUtilities.h:
crypto/CommonCryptoUtilities.cpp:

(WebCore::CCBigNum::CCBigNum):
(WebCore::CCBigNum::~CCBigNum):
(WebCore::CCBigNum::operator=):
(WebCore::CCBigNum::data):
(WebCore::CCBigNum::operator-):
(WebCore::CCBigNum::operator%):
(WebCore::CCBigNum::inverse):
Added a minimal wrapper around CommonCrypto BigNum.

crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::getPrivateKeyComponents): Compute missing parts using CCBigNum.
(WebCore::CryptoKeyRSA::exportData): Implemented private key case.

LayoutTests:

crypto/subtle/rsa-export-private-key-expected.txt: Added.
crypto/subtle/rsa-export-private-key.html: Added.

12:12 PM Changeset in webkit [160028] by andersca@apple.com

4 edits
2 deletes in trunk/Source/WebKit2

Remove old WebKit::APIClient cruft
https://bugs.webkit.org/show_bug.cgi?id=125173

Reviewed by Antti Koivisto.

Shared/APIClient.h:
Shared/APIClientTraits.cpp: Removed.
Shared/APIClientTraits.h: Removed.
WebKit2.xcodeproj/project.pbxproj:
WebProcess/Plugins/PDF/PDFPlugin.mm:

12:05 PM Changeset in webkit [160027] by ap@apple.com

2 edits in trunk/LayoutTests

WebCrypto HMAC doesn't check key algorithm's hash
https://bugs.webkit.org/show_bug.cgi?id=125114

Update layout test result for a last minute change in test content.

crypto/subtle/hmac-check-algorithm-expected.txt:

12:01 PM Changeset in webkit [160026] by enrica@apple.com

2 edits in trunk/Source/WebKit2

Build fix for iOS.

Reviewed by Tim Horton.

Shared/WebCoreArgumentCoders.cpp: Added missing header.

11:51 AM Changeset in webkit [160025] by commit-queue@webkit.org

21 edits in trunk/Source/WebInspectorUI

Web Inspector: restore navigation panel state across reloads and reopens
https://bugs.webkit.org/show_bug.cgi?id=122125

Patch by Brian J. Burg <Brian Burg> on 2013-12-03
Reviewed by Timothy Hatcher.

The previous strategy for restoring content views after inspector
re-open did not consider the active sidebar and its selection, and
tried to recreate the appropriate selection from the saved content
view. However, doesn't work for tree elements in the sidebar panel
that don't change views when selected, such as script breakpoints,
special breakpoints, call stack, timeline sections, etc.

This patch implements a new strategy that saves the navigation
sidebar panel's view state by serializing the identity of the
selected element's represented object. Relevant represented
object classes implement the saveIdentityToCookie() method. Each
represented object class also adds a TypeIdentifier property to
its constructor, to aid inexact matching based on represented
object type, rather than its complete identity.

When restoring, the navigation sidebar attempts to match added
tree elements against the pending cookie, and selects the element
if it matches. A represented object matches if its serialized
identity matches the previously saved serialized identity.

The inspector view state is now only saved on the page hide event
(for saving across reopen) and when the main frame commits its
provisional load (for saving across same-page reloads). It
consolidates similar view state settings into a single setting.

UserInterface/ApplicationCacheFrame.js:

(WebInspector.ApplicationCacheFrame): Add cookie keys and type identifier.
(WebInspector.ApplicationCacheFrame.prototype.saveIdentityToCookie): Added.

UserInterface/ApplicationCacheManager.js: remove objectForCookie().
UserInterface/Breakpoint.js:

(WebInspector.Breakpoint): Add cookie keys and type identifier.
(WebInspector.Breakpoint.prototype.saveIdentityToCookie):

UserInterface/CookieStorageObject.js:

(WebInspector.CookieStorageObject.prototype.saveIdentityToCookie): Added.

UserInterface/DOMStorageObject.js:

(WebInspector.DOMStorageObject): Add cookie keys and type identifier.
(WebInspector.DOMStorageObject.prototype.saveIdentityToCookie): Added.

UserInterface/DatabaseObject.js:

(WebInspector.DatabaseObject): Add cookie keys and type identifier.
(WebInspector.DatabaseObject.prototype.saveIdentityToCookie): Added.

UserInterface/DatabaseTableObject.js:

(WebInspector.DatabaseTableObject): Add cookie keys and type identifier.
(WebInspector.DatabaseTableObject.prototype.saveIdentityToCookie): Added.

UserInterface/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype.saveStateToCookie): Added.
(WebInspector.DebuggerSidebarPanel.prototype.restoreStateFromCookie): Added.

UserInterface/Frame.js:

(WebInspector.Frame): Add cookie keys and type identifier.
(WebInspector.Frame.prototype.saveIdentityToCookie): Added.

UserInterface/FrameResourceManager.js: remove objectForCookie().
UserInterface/InstrumentSidebarPanel.js:

(WebInspector.InstrumentSidebarPanel.prototype.showTimelineForRecordType):
Return the shown timeline, if any.

(WebInspector.InstrumentSidebarPanel.prototype.saveStateToCookie): Added.
(WebInspector.InstrumentSidebarPanel.prototype.restoreStateFromCookie): Added.
(WebInspector.InstrumentSidebarPanel.prototype.showProfile):
Return the shown profile, if any.

UserInterface/Main.js:

(WebInspector): Added cookie keys for the selected sidebar and
typeidentifier of the sidebar's selected tree element.

(WebInspector.contentLoaded): Remove callbacks for
resolveAndShowPendingContentViewCookie(). Consolidate all saved
inspector view state into one Setting. Move special-cased
restoring of the console to the restoration method. Move saving
of last opened navigation panel to the saving method.

(WebInspector._mainResourceDidChange): Try to restore saved view
state when the main resource changes.

(WebInspector._provisionalLoadCommitted): Update the saved view
state when the navigation commits. This is the last chance to save
it before the main resource changes and the navigation panel view
state is discarded and rebuilt.

(WebInspector._pageHidden): Update the saved view state when the
inspector page is hidden, but before state is discarded.

(WebInspector._navigationSidebarPanelSelected): Don't save last
navigation sidebar panel.
(WebInspector._updateCookieForInspectorViewState): Renamed from
_updateCurrentContentViewCookie. It delegates view state
serialization to the currently open navigation sidebar, rather
than the current content view.

(WebInspector._contentBrowserRepresentedObjectsDidChange): Don't
spuriously serialize the current view state cookie on every
ContentView change.

(WebInspector._restoreInspectorViewStateFromCookie): Renamed from
_showContentViewForCookie. It now restores a specific navigation
panel and delegates remaining view state restoration to the panel
itself. Last-resort selection of any tree element with the same
type identifier was moved to the navigation panel's restore method.

UserInterface/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel):
(WebInspector.NavigationSidebarPanel.prototype.set contentTreeOutline):
(WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline):
Save references to all created TreeOutlines in a Set, so we can
restore any tree's selection.

(WebInspector.NavigationSidebarPanel.prototype.saveStateToCookie):
Added. Find the selected tree element from all tree outlines and
ask it to serialize its identity.

(WebInspector.NavigationSidebarPanel.prototype.restoreStateFromCookie):
Added. Eagerly search existing tree elements for a matching
representedObject. If none exists, save the pending cookie and
schedule last-resort matching using the provided timeout interval.

(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
Check if the added tree element matches a pending view state
cookie, if one exists.

(WebInspector.NavigationSidebarPanel.prototype.treeElementMatchesCookie):
Added. Check if the tree element's representedObject matches the
pending view state cookie.

(WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):
Added. For each provided tree element, check if the tree
element's represented object produces the same serialized identity
as the pending view state cookie that we are trying to resolve.
If a match is found (possibly by relaxing to matching anything
with the same type), select the tree element and clear both the
pending view state cookie and last-resort selection timer.

UserInterface/Resource.js:

(WebInspector.Resource): Add cookie keys and type identifier.
(WebInspector.Resource.prototype.saveIdentityToCookie): Added.

UserInterface/ResourceClusterContentView.js:

(WebInspector.ResourceClusterContentView.prototype.saveToCookie):
(WebInspector.ResourceClusterContentView.prototype.restoreFromCookie):
Since identity state is serialized by the representedObject, these
methods only need to save view-specific state, such as the visible
subview. Remove extraneous state.

UserInterface/Script.js:

(WebInspector.Script): Add cookie keys and type identifier.
(WebInspector.Script.prototype.saveIdentityToCookie): Added.

UserInterface/StorageManager.js: remove objectForCookie().
UserInterface/TimelineManager.js: remove objectForCookie().
UserInterface/TimelinesContentView.js:

(WebInspector.TimelinesContentView.prototype.saveToCookie):
(WebInspector.TimelinesContentView.prototype.restoreFromCookie):
Since identity state is serialized by the representedObject, these
methods only need to save view-specific state, such as the visible
subview. Remove extraneous state.

UserInterface/TreeOutline.js: Add TreeOutline.prototype.constructor

so other code can assume the constructor property exists.

11:44 AM Changeset in webkit [160024] by rniwa@webkit.org

3 edits
2 adds in trunk

XML fragment parsing algorithm doesn't use the context element's default namespace URI
https://bugs.webkit.org/show_bug.cgi?id=125132

Reviewed by Darin Adler.

Source/WebCore:

Always use the context element's namespace as the default namespace URI when one is not specified by xmlns.

The new behavior matches that of Internet Explorer and the specified behavior in HTML5:
http://www.w3.org/TR/2013/CR-html5-20130806/the-xhtml-syntax.html#parsing-xhtml-fragments

"The default namespace is the namespace for which the DOM isDefaultNamespace() method on the element would
return true."

Test: fast/parser/fragment-parsing-in-document-without-xmlns.html

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

LayoutTests:

Added a test for parsing a markup fragment inside a XHTML document without xmlns.
The parsed fragment should use the context element's namespace as the default namespace.

fast/parser/fragment-parsing-in-document-without-xmlns-expected.txt: Added.
fast/parser/fragment-parsing-in-document-without-xmlns.html: Added.

11:43 AM Changeset in webkit [160023] by commit-queue@webkit.org

5 edits in trunk/Source

Remove some CSS Variables leftovers
https://bugs.webkit.org/show_bug.cgi?id=125167

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-03
Reviewed by Darin Adler.

Source/WebCore:

No new tests needed. Only removing leftover code.

css/CSSBasicShapes.cpp:
css/CSSBasicShapes.h:

Source/WebKit/blackberry:

WebCoreSupport/AboutDataEnableFeatures.in:

11:37 AM Changeset in webkit [160022] by commit-queue@webkit.org

32 edits in trunk/Source/WebKit2

Remove WTF:: prefix from types in messages.in files.
https://bugs.webkit.org/show_bug.cgi?id=124578

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-03
Reviewed by Anders Carlsson.

The WTF:: prefixes are removed from the messages.in files, and the
messages.py now handles unprefixed non-template WTF classes (only
the WTF::String class is used currently). Tests are also updated.

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
NetworkProcess/NetworkConnectionToWebProcess.messages.in:
NetworkProcess/NetworkProcess.messages.in:
PluginProcess/PluginControllerProxy.messages.in:
PluginProcess/PluginProcess.messages.in:
Scripts/webkit2/messages.py:

(forward_declarations_and_headers):
(class_template_headers):
(argument_coder_headers_for_type):

Scripts/webkit2/messages_unittest.py:

(std):

Shared/Network/CustomProtocols/CustomProtocolManager.messages.in:
UIProcess/Downloads/DownloadProxy.messages.in:
UIProcess/Plugins/PluginProcessProxy.messages.in:
UIProcess/Storage/StorageManager.messages.in:
UIProcess/WebContext.messages.in:
UIProcess/WebCookieManagerProxy.messages.in:
UIProcess/WebDatabaseManagerProxy.messages.in:
UIProcess/WebIconDatabase.messages.in:
UIProcess/WebInspectorProxy.messages.in:
UIProcess/WebMediaCacheManagerProxy.messages.in:
UIProcess/WebPageProxy.messages.in:
UIProcess/WebProcessProxy.messages.in:
WebProcess/Cookies/WebCookieManager.messages.in:
WebProcess/Geolocation/WebGeolocationManager.messages.in:
WebProcess/MediaCache/WebMediaCacheManager.messages.in:
WebProcess/Notifications/WebNotificationManager.messages.in:
WebProcess/Plugins/PluginProcessConnection.messages.in:
WebProcess/Plugins/PluginProxy.messages.in:
WebProcess/Storage/StorageAreaMap.messages.in:
WebProcess/WebCoreSupport/WebDatabaseManager.messages.in:
WebProcess/WebPage/WebInspector.messages.in:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebProcess.messages.in:
WebProcess/soup/WebSoupRequestManager.messages.in:

11:37 AM Changeset in webkit [160021] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Checking second-to-last bit in address is a typo
https://bugs.webkit.org/show_bug.cgi?id=125162

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-12-03
Reviewed by Darin Adler.

After talking with the original author of this line,
is was a typo to make sure that the second-to-last bit
in an address is 0. Instead, we want to make sure that
the address is aligned to a 4-byte boundary

No behavior change, so no test is necessary

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer):

11:36 AM Changeset in webkit [160020] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Tweak build fixes.

Shared/APIClient.h:

11:34 AM Changeset in webkit [160019] by Brent Fulgham

2 edits in branches/safari-537.60-branch/Source/WebKit

Merge r160017.

2013-12-03 Brent Fulgham <Brent Fulgham>

[Win] WebKit.make Makefile doesn't copy resource bundle to DSTROOT
https://bugs.webkit.org/show_bug.cgi?id=125160

Reviewed by Tim Horton.

WebKit.vcxproj/WebKit.make: Add copy command for resource bundle.

11:31 AM Changeset in webkit [160018] by dbates@webkit.org

2 edits in trunk/Source/ThirdParty/ANGLE

ANGLE fails to build with trunk clang: unused constant kTraceBufferLen
https://bugs.webkit.org/show_bug.cgi?id=125164
https://code.google.com/p/angleproject/issues/detail?id=534

Reviewed by Darin Adler.

Move the definition of the constant kTraceBufferLen under the macro
guard TRACE_ENABLED since it's only referenced in code guarded by
TRACE_ENABLED.

src/compiler/debug.cpp:

11:26 AM Changeset in webkit [160017] by Brent Fulgham

2 edits in trunk/Source/WebKit

[Win] WebKit.make Makefile doesn't copy resource bundle to DSTROOT
https://bugs.webkit.org/show_bug.cgi?id=125160

Reviewed by Tim Horton.

WebKit.vcxproj/WebKit.make: Add copy command for resource bundle.

11:04 AM WebKitGTK/2.2.x edited by vjaquez@igalia.com

(diff)

10:51 AM Changeset in webkit [160016] by mhahnenberg@apple.com

2 edits
1 add in trunk/Tools

run-jsc-stress-tests only supports host environments that have make installed
https://bugs.webkit.org/show_bug.cgi?id=124550

Reviewed by Darin Adler.

This might not be the case for all hosts, so this patch implements an alternate "backend"
for run-jsc-stress-tests to use normal shell commands rather than Makefiles. To remain at
least somewhat competitive with the make-based test runner, the shell backend uses subshells
run in the background to allow tests to run in parallel. Since the concurrency primitives
in shell scripting are rather coarse, the overhead of this parallelism is higher than that
of the make-based runner.

Scripts/jsc-stress-test-helpers/shell-runner.sh: Added. This is the runner that is copied into

the bundle and controls all of the parallel aspects of the shell-based test runner.

Scripts/run-jsc-stress-tests:

10:44 AM Changeset in webkit [160015] by Chris Fleizach

2 edits in trunk/Source/WebKit/mac

AX: Crash in accessibilityRoot when Document goes away
https://bugs.webkit.org/show_bug.cgi?id=125113

Reviewed by Tim Horton.

The AXObjectCache can sometimes be null if the render tree has been detached from the document.

WebView/WebFrame.mm:

(-[WebFrame accessibilityRoot]):

10:28 AM Changeset in webkit [160014] by stavila@adobe.com

3 edits
4 adds in trunk

The overflow border of a relatively positioned element inside a region is not painted
https://bugs.webkit.org/show_bug.cgi?id=124919

Source/WebCore:

Relative positioned elements have self-painting layers that don't propagate the visual overflow
so the layer's position should be used when determining the clipping rectangle for box decorations.

Reviewed by Mihnea Ovidenie.

Test: fast/regions/relative-borders-overflow.html

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::decorationsClipRectForBoxInRegion):

LayoutTests:

Added new tests for correct painting of the borders of a relatively positioned element inside a region.

Reviewed by Mihnea Ovidenie.

fast/regions/relative-borders-overflow-expected.html: Added.
fast/regions/relative-borders-overflow.html: Added.
fast/regions/relative-in-absolute-borders-overflow-expected.html: Added.
fast/regions/relative-in-absolute-borders-overflow.html: Added.

10:09 AM Changeset in webkit [160013] by Seokju Kwon

3 edits in trunk/Source/WebCore

Web Inspector: Get rid of 'hasFrontend()' in InspectorController and WorkerInspectorController
https://bugs.webkit.org/show_bug.cgi?id=125135

Reviewed by Darin Adler.

Remove 'hasFrontend()' from InspectorController and WorkerInspectorController
as it's never called.

No new tests, no behavior changes.

inspector/InspectorController.h:
inspector/WorkerInspectorController.h:

10:08 AM Changeset in webkit [160012] by Seokju Kwon

7 edits in trunk/Source/WebCore

Web Inspector: webViewResized() is not used anywhere in WebInspectorUI
https://bugs.webkit.org/show_bug.cgi?id=125137

Reviewed by Darin Adler.

Remove leftover code.

No new tests, no behavior changes.

inspector/InspectorController.cpp:
inspector/InspectorController.h:
inspector/InspectorOverlay.cpp:
inspector/InspectorOverlay.h:
inspector/InspectorPageAgent.cpp:
inspector/InspectorPageAgent.h:

9:40 AM Changeset in webkit [160011] by Chris Fleizach

1 edit
2 adds in trunk/LayoutTests

AX: aria-hidden=false does not work as expected
https://bugs.webkit.org/show_bug.cgi?id=98787

Reviewed by Beth Dakin.

These tests were part of this patch added over a year ago, but the patch was rolled out, and when it was rolled back in
the tests were never added. So I'm adding them back again.

accessibility/aria-hidden-negates-no-visibility.html: Added.
platform/mac/accessibility/aria-hidden-negates-no-visibility-expected.txt: Added.

9:29 AM Changeset in webkit [160010] by commit-queue@webkit.org

3 edits
2 adds in trunk

ASSERTION FAILED: !value

(value->isPrimitiveValue()) in WebCore::StyleProperties::getLayeredShorthandValue.

https://bugs.webkit.org/show_bug.cgi?id=125146

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-03
Reviewed by Darin Adler.

Source/WebCore:

Do not presume that |yValue| is primitive if |value| is implicit in StylePropertySerializer.
An implicit y-value can become explicit if specified as a separate longhand.
At the same time, its new value can be non-primitive.

Backported from Blink:
http://src.chromium.org/viewvc/blink?view=rev&rev=153678

Test: fast/css/webkit-mask-crash-implicit.html

css/StyleProperties.cpp:

(WebCore::StyleProperties::getLayeredShorthandValue):

LayoutTests:

fast/css/webkit-mask-crash-implicit-expected.txt: Added.
fast/css/webkit-mask-crash-implicit.html: Added.

9:26 AM Changeset in webkit [160009] by rwlbuis@webkit.org

2 edits in trunk/Source/WebCore

Fix build break after r160007.

rendering/style/BasicShapes.cpp:

(WebCore::BasicShape::canBlend):

9:25 AM Changeset in webkit [160008] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Fix EFL build error in WK2 (159965)
https://bugs.webkit.org/show_bug.cgi?id=125153

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-12-03
Reviewed by Darin Adler.

Shared/APIClient.h:

9:18 AM Changeset in webkit [160007] by rwlbuis@webkit.org

17 edits
2 adds in trunk

[css shapes] layout for new ellipse syntax
https://bugs.webkit.org/show_bug.cgi?id=124621

Source/WebCore:

Reviewed by Dirk Schulze.

Implement support for doing layout with the new ellipse shape syntax,
including basic animation support.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000.html

rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape): Convert new ellipse to a layout shape.

rendering/style/BasicShapes.cpp:

(WebCore::BasicShape::canBlend): Ignore ellipses with values that

cannot be interpolated.

(WebCore::BasicShapeEllipse::floatValueForRadiusInBox): Helper function to calculate

either radiusX or radiusY, shared by clip-path and shape code paths.

(WebCore::BasicShapeEllipse::path):

rendering/style/BasicShapes.h:

LayoutTests:

Add a new test for the new ellipse syntax. Also update existing shape-inside, animation, and clip-path tests to
test the new ellipse syntax for clipping and shape-inside.

Reviewed by Dirk Schulze.

animations/resources/animation-test-helpers.js:

(parseBasicShape):

css3/masking/clip-path-animation-expected.txt:
css3/masking/clip-path-animation.html:
css3/masking/clip-path-ellipse.html:
fast/shapes/shape-inside/shape-inside-animation-expected.txt:
fast/shapes/shape-inside/shape-inside-animation.html:
fast/shapes/shape-inside/shape-inside-ellipse-padding.html:
fast/shapes/shape-inside/shape-inside-ellipse.html:
fast/shapes/shape-inside/shape-inside-empty-expected.html:
fast/shapes/shape-inside/shape-inside-empty.html:
fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
fast/shapes/shape-outside-floats/shape-outside-animation.html:
fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000.html: Added.

9:15 AM Changeset in webkit [160006] by commit-queue@webkit.org

3 edits in trunk/Tools

Remove function from TextChecker
https://bugs.webkit.org/show_bug.cgi?id=125148

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-03
Reviewed by Darin Adler.

The process_file_data is used only from the unit tests, so it is simply moved there.

Scripts/webkitpy/style/checkers/text.py:

(TextChecker.check):

Scripts/webkitpy/style/checkers/text_unittest.py:

(TextStyleTestCase.process_file_data):
(TextStyleTestCase.assertNoError):
(TextStyleTestCase.assertError):

9:12 AM Changeset in webkit [160005] by commit-queue@webkit.org

14 edits
1 copy
7 adds in trunk

Add an MathMLSelectElement class to implement <maction> and <semantics>.
<https://webkit.org/b/120058>

Patch by Frédéric Wang <fred.wang@free.fr> on 2013-12-03
Reviewed by Chris Fleizach.

Source/WebCore:

Tests: mathml/presentation/maction-dynamic.html

mathml/presentation/maction.html
mathml/presentation/semantics.html

This adds a new MathMLSelectElement class to prepare the implementation
of the <maction> and <semantics> elements, for which only one "selected"
child is visible. We now simply display the first child of the
<semantics> element instead of hiding the annotations and this allows to
handle the use case of SVG-in-MathML as generated by Instiki when
bug 124128 is fixed ; Gecko's selection algorithm will be implemented
later (bug 100626). We now also rely on the @actiontype and @selection
attributes to select the visible <maction> child ; It remains to deal
with the user interaction (bug 85734).

CMakeLists.txt: add the new files.
GNUmakefile.list.am: ditto
Target.pri: ditto
WebCore.vcxproj/WebCore.vcxproj: ditto
WebCore.vcxproj/WebCore.vcxproj.filters: ditto
WebCore.xcodeproj/project.pbxproj: ditto
css/mathml.css: remove the CSS rule for annotation/annotation-xml.
mathml/MathMLAllInOne.cpp: add the new cpp file.
mathml/MathMLSelectElement.cpp: Added.

(WebCore::MathMLSelectElement::MathMLSelectElement):
(WebCore::MathMLSelectElement::create):
(WebCore::MathMLSelectElement::createRenderer):
(WebCore::MathMLSelectElement::childShouldCreateRenderer):
(WebCore::MathMLSelectElement::finishParsingChildren):
(WebCore::MathMLSelectElement::childrenChanged):
(WebCore::MathMLSelectElement::attributeChanged):
(WebCore::MathMLSelectElement::updateSelectedChild): basic implementation for maction, semantics, maction@actiontype and maction@selection.

mathml/MathMLSelectElement.h: Added.
mathml/mathattrs.in: add actiontype and selection attributes.
mathml/mathtags.in: set element classes for maction, semantics, annotation and annotation-xml.

LayoutTests:

New tests for the selection of the visible child in the <maction> and <semantics> elements.

mathml/presentation/maction-dynamic-expected.html: Added.
mathml/presentation/maction-dynamic.html: Added.
mathml/presentation/maction-expected.html: Added.
mathml/presentation/maction.html: Added.
mathml/presentation/semantics-expected.html: Added.
mathml/presentation/semantics.html: Added.

9:09 AM Changeset in webkit [160004] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

testapi test crashes on Windows in WTF::Vector<wchar_t,64,WTF::UnsafeVectorOverflow>::size()
https://bugs.webkit.org/show_bug.cgi?id=121972

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-12-03
Reviewed by Michael Saboff.

The reason for the crash is that the wrong memory block is decommitted.
This can happen if no memory has been committed in the reserved block before the JSStack object is destroyed.
In the JSStack destructor, the pointer to decommit then points to the end of the block (or the start of the next), and the decommit size is zero.
If there is a block just after the block we are trying to decommit, this block will be decommitted, since Windows will decommit the whole block,
if the decommit size is zero (see VirtualFree). When somebody tries to read/write to this block later, we crash.

interpreter/JSStack.cpp:

(JSC::JSStack::~JSStack): Don't decommit memory if nothing has been committed.

7:53 AM Changeset in webkit [160003] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Guard JIT include.
https://bugs.webkit.org/show_bug.cgi?id=125063

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-03
Reviewed by Filip Pizlo.

llint/LLIntThunks.cpp:

7:02 AM Changeset in webkit [160002] by Seokju Kwon

2 edits in trunk/Source/WebKit2

Debug build fix : Add '<algorithm>' for 'std::is_sorted' after r159965.
https://bugs.webkit.org/show_bug.cgi?id=125140

Reviewed by Csaba Osztrogonác.

Shared/APIClient.h:

6:24 AM Changeset in webkit [160001] by commit-queue@webkit.org

2 edits
6 adds in trunk/Source/WebCore

Nix Upstream: Adding missing nix new files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=124987

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-12-03
Reviewed by Benjamin Poulain.

No new tests needed.

PlatformNix.cmake:
platform/nix/ErrorsNix.cpp: Added.
platform/nix/ErrorsNix.h: Added.
platform/nix/FileSystemNix.cpp: Added.
platform/nix/MIMETypeRegistryNix.cpp: Added.
platform/nix/SharedTimerNix.cpp: Added.
platform/nix/TemporaryLinkStubs.cpp: Added.

4:44 AM Changeset in webkit [160000] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Fix EFL build with INPUT_TYPE_COLOR disabled.
https://bugs.webkit.org/show_bug.cgi?id=125065

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-12-03
Reviewed by Zoltan Herczeg.

UIProcess/API/efl/ewk_color_picker.cpp:

4:42 AM Changeset in webkit [159999] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Correct broken build on efl port with --no-netscape-plugin-api
configuration.
https://bugs.webkit.org/show_bug.cgi?id=123997

Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-12-03
Reviewed by Zoltan Herczeg.

Build failed on efl port with --no-netscape-plugin-api configuration
as ld did not found some methods. The configuration uses a minimal
empty implementation of the class, which is now extended with empty
method implementations.

plugins/PluginPackageNone.cpp:

(WebCore::PluginPackage::createPackage):

Returns NULL pointer.

(WebCore::PluginPackage::hash):

Returns 0.

(WebCore::PluginPackage::equal):

Returns true (equals).

(WebCore::PluginPackage::compare):

Returns 0 (equals).

(WebCore::PluginPackage::~PluginPackage):

Do nothing.

4:40 AM Changeset in webkit [159998] by commit-queue@webkit.org

2 edits in trunk/Tools

Remove get_test() and reference test names directly instead.
https://bugs.webkit.org/show_bug.cgi?id=124962

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-12-03
Reviewed by Csaba Osztrogonác.

Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(Base.init):
(Base.get_basic_tests):
(assert_exp):
(MiscTests.test_multiple_results):
(MiscTests.test_category_expectations):
(MiscTests.test_get_modifiers):
(MiscTests.test_get_expectations_string):
(MiscTests.test_get_test_set):
(MiscTests.test_parse_warning):
(MiscTests.test_pixel_tests_flag.match):

4:30 AM Changeset in webkit [159997] by Csaba Osztrogonác

3 edits in trunk/Tools

Style Checker false pass.
https://bugs.webkit.org/show_bug.cgi?id=112456

Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-12-03
Reviewed by Csaba Osztrogonác.

Scripts/webkitpy/style/checkers/changelog.py:

(ChangeLogChecker.check_entry):
simple regex fix to check "No new tests (...)."

Scripts/webkitpy/style/checkers/changelog_unittest.py:

(ChangeLogCheckerTest.test_no_new_tests):

2:29 AM Changeset in webkit [159996] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

Add spatial navigation API in EFL port
https://bugs.webkit.org/show_bug.cgi?id=125002

Patch by Dariusz Frankiewicz <Dariusz Frankiewicz> on 2013-12-03
Reviewed by Gyuyoung Kim.

API enables capability of turning on and off spatial navigation
and check is state.
Spatial navigation is the ability to navigate between focusable
elements by keyboard.

UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_spatial_navigation_enabled_set):
(ewk_settings_spatial_navigation_enabled_get):

UIProcess/API/efl/ewk_settings.h:
UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

2:28 AM Changeset in webkit [159995] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Merge mips and arm/sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions.
https://bugs.webkit.org/show_bug.cgi?id=125067

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-12-03
Reviewed by Michael Saboff.

jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):

jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):

12:01 AM Changeset in webkit [159994] by zandobersek@gmail.com

29 edits in trunk/Source/WebKit2

Build fixes for GCC-using ports after r159965 and later
https://bugs.webkit.org/show_bug.cgi?id=125136

GCC doesn't process API::ClientTraits template instantiations unless they're done
inside the API namespace.

Shared/WebConnectionClient.h:
UIProcess/Notifications/WebNotificationProvider.h:
UIProcess/WebContextClient.h:
UIProcess/WebContextConnectionClient.h:
UIProcess/WebContextInjectedBundleClient.h:
UIProcess/WebCookieManagerProxyClient.h:
UIProcess/WebDatabaseManagerProxyClient.h:
UIProcess/WebDownloadClient.h:
UIProcess/WebFindClient.h:
UIProcess/WebFormClient.h:
UIProcess/WebGeolocationProvider.h:
UIProcess/WebHistoryClient.h:
UIProcess/WebIconDatabaseClient.h:
UIProcess/WebLoaderClient.h:
UIProcess/WebOriginDataManagerProxyChangeClient.h:
UIProcess/WebPageContextMenuClient.h:
UIProcess/WebPolicyClient.h:
UIProcess/WebUIClient.h:
WebProcess/InjectedBundle/InjectedBundleClient.h:
WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h:
WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:
WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

Dec 2, 2013:

10:20 PM Changeset in webkit [159993] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Build fix.

UIProcess/API/ios/WKGeolocationProviderIOS.mm:

(-[WKGeolocationProviderIOS initWithContext:]):

9:53 PM Changeset in webkit [159992] by commit-queue@webkit.org

6 edits
2 copies in trunk/Source/WebKit2

Add ability to iterate over API::Array
https://bugs.webkit.org/show_bug.cgi?id=124533

Patch by Martin Hock <mhock@apple.com> on 2013-12-02
Reviewed by Sam Weinig.

GNUmakefile.list.am:
Shared/APIArray.h:
Shared/FilterIterator.h:
Shared/IteratorPair.h:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::toStringVector):

WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):

8:25 PM Changeset in webkit [159991] by mitz@apple.com

4 edits
2 adds in trunk/Source/WebKit2

[Cocoa] WebProtectionSpace has a generic wrapper
https://bugs.webkit.org/show_bug.cgi?id=125125

Reviewed by Anders Carlsson.

Added WKNSURLProtectionSpace.

Shared/Cocoa/APIObject.mm:

(API::Object::newObject): Allocate a WKNSURLProtectionSpace if the object is a
WebProtectionSpace.

Shared/Cocoa/WKNSURLProtectionSpace.h: Added.

(WebKit::wrapper): Added. Returns a WebProtecitonSpace’s wrapper as an NSURLProtectionSpace.

Shared/Cocoa/WKNSURLProtectionSpace.mm: Added.

(-[WKNSURLProtectionSpace copyWithZone:]): Retains self.

UIProcess/Authentication/WebProtectionSpace.h:

(WebKit::WebProtectionSpace::protectionSpace): Added an accessor for the
WebCore::ProtectionSpace.

WebKit2.xcodeproj/project.pbxproj: Added references to new files.

8:19 PM Changeset in webkit [159990] by fpizlo@apple.com

2 edits in trunk/Tools

run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
https://bugs.webkit.org/show_bug.cgi?id=125130

Reviewed by Geoffrey Garen.

Scripts/run-jsc-stress-tests:

7:19 PM Changeset in webkit [159989] by akling@apple.com

5 edits in trunk/Source/WebCore

Avoid setting style twice for generated image content.
<https://webkit.org/b/125128>

Take care of a FIXME I added in r158097 and avoid redundant work in
ImageContentData::createRenderer().

I changed the inheritance helper RenderImage::setPseudoStyle() into
a new createStyleInheritingFromPseudoStyle() function instead so it
can be used from both PseudoElement and ImageContentData.

Reviewed by Antti Koivisto.

6:36 PM Changeset in webkit [159988] by andersca@apple.com

91 edits in trunk/Source/WebKit2

Replace uses of WebKit::APIClient with API::Client
https://bugs.webkit.org/show_bug.cgi?id=125129

Reviewed by Andreas Kling.

Shared/API/c/WKConnectionRef.cpp:

(WKConnectionSetConnectionClient):

Shared/WebConnection.cpp:

(WebKit::WebConnection::initializeConnectionClient):

Shared/WebConnection.h:
Shared/WebConnectionClient.cpp:

(WebKit::WebConnectionClient::didReceiveMessage):
(WebKit::WebConnectionClient::didClose):

Shared/WebConnectionClient.h:
UIProcess/API/C/WKContext.cpp:

(WKContextSetClient):
(WKContextSetInjectedBundleClient):
(WKContextSetHistoryClient):
(WKContextSetDownloadClient):
(WKContextSetConnectionClient):

UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerSetClient):

UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerSetClient):

UIProcess/API/C/WKGeolocationManager.cpp:

(WKGeolocationManagerSetProvider):

UIProcess/API/C/WKIconDatabase.cpp:

(WKIconDatabaseSetIconDatabaseClient):

UIProcess/API/C/WKNotificationManager.cpp:

(WKNotificationManagerSetProvider):

UIProcess/API/C/WKOriginDataManager.cpp:

(WKOriginDataManagerSetChangeClient):

UIProcess/API/C/WKPage.cpp:

(WKPageSetPageContextMenuClient):
(WKPageSetPageFindClient):
(WKPageSetPageFindMatchesClient):
(WKPageSetPageFormClient):
(WKPageSetPagePolicyClient):
(WKPageSetPageUIClient):

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(setUpPagePolicyClient):

UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::initializeProvider):

UIProcess/Notifications/WebNotificationManagerProxy.h:
UIProcess/Notifications/WebNotificationProvider.cpp:

(WebKit::WebNotificationProvider::show):
(WebKit::WebNotificationProvider::cancel):
(WebKit::WebNotificationProvider::didDestroyNotification):
(WebKit::WebNotificationProvider::clearNotifications):
(WebKit::WebNotificationProvider::addNotificationManager):
(WebKit::WebNotificationProvider::removeNotificationManager):
(WebKit::WebNotificationProvider::notificationPermissions):

UIProcess/Notifications/WebNotificationProvider.h:
UIProcess/WebContext.cpp:

(WebKit::WebContext::initializeClient):
(WebKit::WebContext::initializeInjectedBundleClient):
(WebKit::WebContext::initializeConnectionClient):
(WebKit::WebContext::initializeHistoryClient):
(WebKit::WebContext::initializeDownloadClient):

UIProcess/WebContext.h:
UIProcess/WebContextClient.cpp:

(WebKit::WebContextClient::plugInAutoStartOriginHashesChanged):
(WebKit::WebContextClient::networkProcessDidCrash):
(WebKit::WebContextClient::plugInInformationBecameAvailable):

UIProcess/WebContextClient.h:
UIProcess/WebContextConnectionClient.cpp:

(WebKit::WebContextConnectionClient::didCreateConnection):

UIProcess/WebContextConnectionClient.h:
UIProcess/WebContextInjectedBundleClient.cpp:

(WebKit::WebContextInjectedBundleClient::didReceiveMessageFromInjectedBundle):
(WebKit::WebContextInjectedBundleClient::didReceiveSynchronousMessageFromInjectedBundle):
(WebKit::WebContextInjectedBundleClient::getInjectedBundleInitializationUserData):

UIProcess/WebContextInjectedBundleClient.h:
UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::initializeClient):

UIProcess/WebCookieManagerProxy.h:
UIProcess/WebCookieManagerProxyClient.cpp:

(WebKit::WebCookieManagerProxyClient::cookiesDidChange):

UIProcess/WebCookieManagerProxyClient.h:
UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::initializeClient):

UIProcess/WebDatabaseManagerProxy.h:
UIProcess/WebDatabaseManagerProxyClient.cpp:

(WebKit::WebDatabaseManagerProxyClient::didModifyOrigin):
(WebKit::WebDatabaseManagerProxyClient::didModifyDatabase):

UIProcess/WebDatabaseManagerProxyClient.h:
UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::didStart):
(WebKit::WebDownloadClient::didReceiveAuthenticationChallenge):
(WebKit::WebDownloadClient::didReceiveResponse):
(WebKit::WebDownloadClient::didReceiveData):
(WebKit::WebDownloadClient::shouldDecodeSourceDataOfMIMEType):
(WebKit::WebDownloadClient::decideDestinationWithSuggestedFilename):
(WebKit::WebDownloadClient::didCreateDestination):
(WebKit::WebDownloadClient::didFinish):
(WebKit::WebDownloadClient::didFail):
(WebKit::WebDownloadClient::didCancel):
(WebKit::WebDownloadClient::processDidCrash):

UIProcess/WebDownloadClient.h:
UIProcess/WebFindClient.cpp:

(WebKit::WebFindClient::didFindString):
(WebKit::WebFindClient::didFailToFindString):
(WebKit::WebFindClient::didCountStringMatches):
(WebKit::WebFindMatchesClient::didFindStringMatches):
(WebKit::WebFindMatchesClient::didGetImageForMatchResult):

UIProcess/WebFindClient.h:
UIProcess/WebFormClient.cpp:

(WebKit::WebFormClient::willSubmitForm):

UIProcess/WebFormClient.h:
UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::initializeProvider):

UIProcess/WebGeolocationManagerProxy.h:
UIProcess/WebGeolocationProvider.cpp:

(WebKit::WebGeolocationProvider::startUpdating):
(WebKit::WebGeolocationProvider::stopUpdating):
(WebKit::WebGeolocationProvider::setEnableHighAccuracy):

UIProcess/WebGeolocationProvider.h:
UIProcess/WebHistoryClient.cpp:

(WebKit::WebHistoryClient::didNavigateWithNavigationData):
(WebKit::WebHistoryClient::didPerformClientRedirect):
(WebKit::WebHistoryClient::didPerformServerRedirect):
(WebKit::WebHistoryClient::didUpdateHistoryTitle):
(WebKit::WebHistoryClient::populateVisitedLinks):

UIProcess/WebHistoryClient.h:
UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::initializeIconDatabaseClient):

UIProcess/WebIconDatabase.h:
UIProcess/WebIconDatabaseClient.cpp:

(WebKit::WebIconDatabaseClient::didChangeIconForPageURL):
(WebKit::WebIconDatabaseClient::didRemoveAllIcons):
(WebKit::WebIconDatabaseClient::iconDataReadyForPageURL):

UIProcess/WebIconDatabaseClient.h:
UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage):

UIProcess/WebLoaderClient.h:
UIProcess/WebOriginDataManagerProxy.cpp:

(WebKit::WebOriginDataManagerProxy::setChangeClient):

UIProcess/WebOriginDataManagerProxy.h:
UIProcess/WebOriginDataManagerProxyChangeClient.cpp:

(WebKit::WebOriginDataManagerProxyChangeClient::didChange):

UIProcess/WebOriginDataManagerProxyChangeClient.h:
UIProcess/WebPageContextMenuClient.cpp:

(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
(WebKit::WebPageContextMenuClient::customContextMenuItemSelected):
(WebKit::WebPageContextMenuClient::contextMenuDismissed):
(WebKit::WebPageContextMenuClient::showContextMenu):
(WebKit::WebPageContextMenuClient::hideContextMenu):

UIProcess/WebPageContextMenuClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializePolicyClient):
(WebKit::WebPageProxy::initializeFormClient):
(WebKit::WebPageProxy::initializeUIClient):
(WebKit::WebPageProxy::initializeFindClient):
(WebKit::WebPageProxy::initializeFindMatchesClient):
(WebKit::WebPageProxy::initializeContextMenuClient):

UIProcess/WebPageProxy.h:
UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForResponse):
(WebKit::WebPolicyClient::unableToImplementPolicy):

UIProcess/WebPolicyClient.h:
UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::createNewPage):
(WebKit::WebUIClient::showPage):
(WebKit::WebUIClient::close):
(WebKit::WebUIClient::takeFocus):
(WebKit::WebUIClient::focus):
(WebKit::WebUIClient::unfocus):
(WebKit::WebUIClient::runJavaScriptAlert):
(WebKit::WebUIClient::runJavaScriptConfirm):
(WebKit::WebUIClient::runJavaScriptPrompt):
(WebKit::WebUIClient::setStatusText):
(WebKit::WebUIClient::mouseDidMoveOverElement):
(WebKit::WebUIClient::unavailablePluginButtonClicked):
(WebKit::WebUIClient::didNotHandleKeyEvent):
(WebKit::WebUIClient::didNotHandleWheelEvent):
(WebKit::WebUIClient::toolbarsAreVisible):
(WebKit::WebUIClient::setToolbarsAreVisible):
(WebKit::WebUIClient::menuBarIsVisible):
(WebKit::WebUIClient::setMenuBarIsVisible):
(WebKit::WebUIClient::statusBarIsVisible):
(WebKit::WebUIClient::setStatusBarIsVisible):
(WebKit::WebUIClient::isResizable):
(WebKit::WebUIClient::setIsResizable):
(WebKit::WebUIClient::setWindowFrame):
(WebKit::WebUIClient::windowFrame):
(WebKit::WebUIClient::runBeforeUnloadConfirmPanel):
(WebKit::WebUIClient::didDraw):
(WebKit::WebUIClient::pageDidScroll):
(WebKit::WebUIClient::exceededDatabaseQuota):
(WebKit::WebUIClient::runOpenPanel):
(WebKit::WebUIClient::decidePolicyForGeolocationPermissionRequest):
(WebKit::WebUIClient::decidePolicyForNotificationPermissionRequest):
(WebKit::WebUIClient::headerHeight):
(WebKit::WebUIClient::footerHeight):
(WebKit::WebUIClient::drawHeader):
(WebKit::WebUIClient::drawFooter):
(WebKit::WebUIClient::printFrame):
(WebKit::WebUIClient::runModal):
(WebKit::WebUIClient::saveDataToFileInDownloadsFolder):
(WebKit::WebUIClient::shouldInterruptJavaScript):
(WebKit::WebUIClient::showColorPicker):
(WebKit::WebUIClient::hideColorPicker):

UIProcess/WebUIClient.h:
UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetClient):

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::initializeClient):

WebProcess/InjectedBundle/InjectedBundle.h:
WebProcess/InjectedBundle/InjectedBundleClient.cpp:

(WebKit::InjectedBundleClient::didCreatePage):
(WebKit::InjectedBundleClient::willDestroyPage):
(WebKit::InjectedBundleClient::didInitializePageGroup):
(WebKit::InjectedBundleClient::didReceiveMessage):
(WebKit::InjectedBundleClient::didReceiveMessageToPage):

WebProcess/InjectedBundle/InjectedBundleClient.h:
WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:

(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):

WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp:

(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):

WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h:
WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::shouldBeginEditing):
(WebKit::InjectedBundlePageEditorClient::shouldEndEditing):
(WebKit::InjectedBundlePageEditorClient::shouldInsertNode):
(WebKit::InjectedBundlePageEditorClient::shouldInsertText):
(WebKit::InjectedBundlePageEditorClient::shouldDeleteRange):
(WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange):
(WebKit::InjectedBundlePageEditorClient::shouldApplyStyle):
(WebKit::InjectedBundlePageEditorClient::didBeginEditing):
(WebKit::InjectedBundlePageEditorClient::didEndEditing):
(WebKit::InjectedBundlePageEditorClient::didChange):
(WebKit::InjectedBundlePageEditorClient::didChangeSelection):
(WebKit::InjectedBundlePageEditorClient::willWriteToPasteboard):
(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):
(WebKit::InjectedBundlePageEditorClient::didWriteToPasteboard):

WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::didFocusTextField):
(WebKit::InjectedBundlePageFormClient::textFieldDidBeginEditing):
(WebKit::InjectedBundlePageFormClient::textFieldDidEndEditing):
(WebKit::InjectedBundlePageFormClient::textDidChangeInTextField):
(WebKit::InjectedBundlePageFormClient::textDidChangeInTextArea):
(WebKit::InjectedBundlePageFormClient::shouldPerformActionInTextField):
(WebKit::InjectedBundlePageFormClient::willSendSubmitEvent):
(WebKit::InjectedBundlePageFormClient::willSubmitForm):
(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):
(WebKit::InjectedBundlePageFormClient::shouldNotifyOnFormChanges):

WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:
WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::willLoadURLRequest):
(WebKit::InjectedBundlePageLoaderClient::willLoadDataRequest):
(WebKit::InjectedBundlePageLoaderClient::shouldGoToBackForwardListItem):
(WebKit::InjectedBundlePageLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCommitLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishProgress):
(WebKit::InjectedBundlePageLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didSameDocumentNavigationForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveTitleForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRemoveFrameFromHierarchy):
(WebKit::InjectedBundlePageLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRunInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didDetectXSSForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didLayout):
(WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCancelClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didHandleOnloadEventsForFrame):
(WebKit::InjectedBundlePageLoaderClient::globalObjectIsAvailableForFrame):
(WebKit::InjectedBundlePageLoaderClient::willDisconnectDOMWindowExtensionFromGlobalObject):
(WebKit::InjectedBundlePageLoaderClient::didReconnectDOMWindowExtensionToGlobalObject):
(WebKit::InjectedBundlePageLoaderClient::willDestroyGlobalObjectForDOMWindowExtension):
(WebKit::InjectedBundlePageLoaderClient::shouldForceUniversalAccessFromLocalURL):
(WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):
(WebKit::InjectedBundlePageLoaderClient::willDestroyFrame):

WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:

(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForResponse):
(WebKit::InjectedBundlePagePolicyClient::unableToImplementPolicy):

WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:

(WebKit::InjectedBundlePageResourceLoadClient::didInitiateLoadForResource):
(WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame):
(WebKit::InjectedBundlePageResourceLoadClient::didReceiveResponseForResource):
(WebKit::InjectedBundlePageResourceLoadClient::didReceiveContentLengthForResource):
(WebKit::InjectedBundlePageResourceLoadClient::didFinishLoadForResource):
(WebKit::InjectedBundlePageResourceLoadClient::didFailLoadForResource):
(WebKit::InjectedBundlePageResourceLoadClient::shouldCacheResponse):
(WebKit::InjectedBundlePageResourceLoadClient::shouldUseCredentialStorage):

WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::willAddMessageToConsole):
(WebKit::InjectedBundlePageUIClient::willSetStatusbarText):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptAlert):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptConfirm):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptPrompt):
(WebKit::InjectedBundlePageUIClient::mouseDidMoveOverElement):
(WebKit::InjectedBundlePageUIClient::pageDidScroll):
(WebKit::InjectedBundlePageUIClient::shouldGenerateFileForUpload):
(WebKit::InjectedBundlePageUIClient::generateFileForUpload):
(WebKit::InjectedBundlePageUIClient::statusBarIsVisible):
(WebKit::InjectedBundlePageUIClient::menuBarIsVisible):
(WebKit::InjectedBundlePageUIClient::toolbarsAreVisible):
(WebKit::InjectedBundlePageUIClient::didReachApplicationCacheOriginQuota):
(WebKit::InjectedBundlePageUIClient::didExceedDatabaseQuota):
(WebKit::InjectedBundlePageUIClient::plugInStartLabelTitle):
(WebKit::InjectedBundlePageUIClient::plugInStartLabelSubtitle):
(WebKit::InjectedBundlePageUIClient::plugInExtraStyleSheet):
(WebKit::InjectedBundlePageUIClient::plugInExtraScript):

WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::initializeInjectedBundleContextMenuClient):
(WebKit::WebPage::initializeInjectedBundleEditorClient):
(WebKit::WebPage::initializeInjectedBundleFormClient):
(WebKit::WebPage::initializeInjectedBundleLoaderClient):
(WebKit::WebPage::initializeInjectedBundlePolicyClient):
(WebKit::WebPage::initializeInjectedBundleResourceLoadClient):
(WebKit::WebPage::initializeInjectedBundleUIClient):
(WebKit::WebPage::initializeInjectedBundleFullScreenClient):
(WebKit::WebPage::initializeInjectedBundleDiagnosticLoggingClient):

WebProcess/WebPage/WebPage.h:

5:32 PM Changeset in webkit [159987] by mark.lam@apple.com

12 edits in trunk/Source

Build failure when disabling JIT, YARR_JIT, and ASSEMBLER.
https://bugs.webkit.org/show_bug.cgi?id=123809.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Also fixed build when disabling the DISASSEMBLER.
Added some needed #if's and some comments.

assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::finalizeCodeWithDisassembly):

dfg/DFGDisassembler.cpp:
dfg/DFGDisassembler.h:

(JSC::DFG::Disassembler::Disassembler):
(JSC::DFG::Disassembler::setStartOfCode):
(JSC::DFG::Disassembler::setForBlockIndex):
(JSC::DFG::Disassembler::setForNode):
(JSC::DFG::Disassembler::setEndOfMainPath):
(JSC::DFG::Disassembler::setEndOfCode):
(JSC::DFG::Disassembler::dump):
(JSC::DFG::Disassembler::reportToProfiler):

disassembler/Disassembler.cpp:
disassembler/X86Disassembler.cpp:
jit/FPRInfo.h:
jit/GPRInfo.h:
jit/JITDisassembler.cpp:
jit/JITDisassembler.h:

(JSC::JITDisassembler::JITDisassembler):
(JSC::JITDisassembler::setStartOfCode):
(JSC::JITDisassembler::setForBytecodeMainPath):
(JSC::JITDisassembler::setForBytecodeSlowPath):
(JSC::JITDisassembler::setEndOfSlowPath):
(JSC::JITDisassembler::setEndOfCode):
(JSC::JITDisassembler::dump):
(JSC::JITDisassembler::reportToProfiler):

Source/WTF:

wtf/Platform.h:
Ensure that the ASSEMBLER is enabled when the DISASSEMBLER is enabled.

5:27 PM Changeset in webkit [159986] by beidson@apple.com

2 edits in trunk/Source/WebCore

Possible crash in ProgressTracker::progressHeartbeatTimerFired(Timer<ProgressTracker>*)
https://bugs.webkit.org/show_bug.cgi?id=125110

Reviewed by Darin Adler.

FrameLoader::loadProgressingStatusChanged() might be called while the Frame has a null FrameView.

It’s unclear how to reproduce, but there’s no harm in a null check.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadProgressingStatusChanged):

5:12 PM Changeset in webkit [159985] by enrica@apple.com

17 edits in trunk/Source/WebKit2

Merging some more iOS WebKit2 stuff.
https://bugs.webkit.org/show_bug.cgi?id=125119

Reviewed by Tim Horton.

Shared/EditorState.h:
Shared/NativeWebKeyboardEvent.h:
Shared/NativeWebMouseEvent.h:
Shared/NativeWebTouchEvent.h:
Shared/mac/RemoteLayerBackingStore.h:
Shared/mac/RemoteLayerTreePropertyApplier.mm:
UIProcess/Launcher/mac/ProcessLauncherMac.mm:
UIProcess/PageClient.h:
UIProcess/ios/TiledCoreAnimationDrawingAreaProxyIOS.mm:
UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
UIProcess/mac/SecItemShimProxy.messages.in:
WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

5:11 PM Changeset in webkit [159984] by andersca@apple.com

7 edits in trunk/Source/WebKit2

Add versioned structs for the remaining clients
https://bugs.webkit.org/show_bug.cgi?id=125123

Reviewed by Andreas Kling.

UIProcess/API/C/WKContext.h:
UIProcess/API/C/WKContextConnectionClient.h:
UIProcess/API/C/WKContextDownloadClient.h:
UIProcess/API/C/WKContextHistoryClient.h:
UIProcess/API/C/WKContextInjectedBundleClient.h:
UIProcess/API/C/WKOriginDataManager.h:

4:54 PM Changeset in webkit [159983] by andersca@apple.com

3 edits
4 adds in trunk/Source/WebKit2

Move WKContext clients to separate files
https://bugs.webkit.org/show_bug.cgi?id=125121

Reviewed by Andreas Kling.

UIProcess/API/C/WKContext.h:
UIProcess/API/C/WKContextConnectionClient.h: Added.
UIProcess/API/C/WKContextDownloadClient.h: Added.
UIProcess/API/C/WKContextHistoryClient.h: Added.
UIProcess/API/C/WKContextInjectedBundleClient.h: Added.
WebKit2.xcodeproj/project.pbxproj:

4:43 PM Changeset in webkit [159982] by weinig@apple.com

8 edits in trunk/Source/WebKit2

WebPageGroups should keep track of what processes they are being used by
https://bugs.webkit.org/show_bug.cgi?id=124556

Reviewed by Anders Carlsson.

UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):

UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::addProcess):
(WebKit::WebPageGroup::disconnectProcess):

UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::sendToAllProcessesInGroup):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::webPageGroup):
(WebKit::WebProcessProxy::addWebPageGroup):

UIProcess/WebProcessProxy.h:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::webPageGroup):

4:40 PM Changeset in webkit [159981] by andersca@apple.com

26 edits in trunk/Source/WebKit2

Add versioned structs for all clients except the ones in WKContext.h
https://bugs.webkit.org/show_bug.cgi?id=125120

Reviewed by Andreas Kling.

Shared/API/c/WKConnectionRef.h:
UIProcess/API/C/WKCookieManager.h:
UIProcess/API/C/WKDatabaseManager.h:
UIProcess/API/C/WKGeolocationManager.h:
UIProcess/API/C/WKIconDatabase.h:
UIProcess/API/C/WKNotificationProvider.h:
UIProcess/API/C/WKPageContextMenuClient.h:
UIProcess/API/C/WKPageFindClient.h:
UIProcess/API/C/WKPageFindMatchesClient.h:
UIProcess/API/C/WKPageFormClient.h:
UIProcess/API/C/WKPageLoaderClient.h:
UIProcess/API/C/WKPagePolicyClient.h:
UIProcess/API/C/WKPageUIClient.h:
WebProcess/InjectedBundle/API/c/WKBundle.h:
WebProcess/InjectedBundle/API/c/WKBundlePageBanner.h:
WebProcess/InjectedBundle/API/c/WKBundlePageContextMenuClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePageEditorClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePageFormClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePageFullScreenClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
WebProcess/InjectedBundle/API/c/WKBundlePagePolicyClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePageResourceLoadClient.h:
WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:

4:36 PM Changeset in webkit [159980] by Samuel White

18 edits
2 adds in trunk

AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
https://bugs.webkit.org/show_bug.cgi?id=124561

Reviewed by Chris Fleizach.

Added test to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute
works as it should and updated existing test that has exposes this new attribute.

platform/mac/accessibility/bounds-for-range-expected.txt:
platform/mac/accessibility/search-predicate-element-count-expected.txt: Added.
platform/mac/accessibility/search-predicate-element-count.html: Added.

Added ability to fetch the number of elements that match a specific criteria. This will enable VoiceOver
to interface with WebKit much more dynamically. We can now get an idea of how many interesting elements
exist on a page, and then fetch them in chunks as needed.

Test: platform/mac/accessibility/search-predicate-element-count.html

accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isAccessibilityTextSearchMatch):
accessibility/AccessibilityObject.h: (WebCore::AccessibilitySearchCriteria::AccessibilitySearchCriteria):
accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (accessibilitySearchCriteriaForSearchPredicateParameterizedAttribute): (-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.

DumpRenderTree/AccessibilityUIElement.cpp: (uiElementCountForSearchPredicateCallback): (uiElementForSearchPredicateCallback): (AccessibilityUIElement::getJSClass):
DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: (AccessibilityUIElement::uiElementCountForSearchPredicate):
DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::uiElementCountForSearchPredicate):
DumpRenderTree/mac/AccessibilityUIElementMac.mm: (searchPredicateParameterizedAttributeForSearchCriteria): (AccessibilityUIElement::uiElementCountForSearchPredicate): (AccessibilityUIElement::uiElementForSearchPredicate):
DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::uiElementCountForSearchPredicate):
WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::searchPredicateParameterizedAttributeForSearchCriteria): (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate): (WTR::AccessibilityUIElement::uiElementForSearchPredicate):

4:10 PM Changeset in webkit [159979] by Bem Jones-Bey

32 edits
12 adds in trunk

[css shapes] Layout support for new circle shape syntax
https://bugs.webkit.org/show_bug.cgi?id=124619

Reviewed by Dirk Schulze.

Source/WebCore:

Implement support for doing layout with the new circle shape syntax,
inclduing basic animation support.

Tests: fast/shapes/shape-outside-floats/shape-outside-floats-circle-000.html

fast/shapes/shape-outside-floats/shape-outside-floats-circle-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-circle-002.html
fast/shapes/shape-outside-floats/shape-outside-floats-circle-003.html
fast/shapes/shape-outside-floats/shape-outside-floats-circle-004.html
fast/shapes/shape-outside-floats/shape-outside-floats-circle-005.html

css/BasicShapeFunctions.cpp:

(WebCore::floatValueForCenterCoordinate): Used by both the CSS Shapes

layout code and the clip path code.

css/BasicShapeFunctions.h:
css/CSSBasicShapes.cpp:

(WebCore::buildCircleString): Update to use appendLiteral, and remove

call to reserveCapacity - if we find that it's actually slow when
doing performance tests, we can hopefully do something smarter and
less ugly than that.

css/CSSParser.cpp:

(WebCore::CSSParser::parseShapeRadius): Fix a logic error that caused

the radius keywords not to work properly.

rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape): Convert new circle to a layout shape.

rendering/style/BasicShapes.cpp:

(WebCore::BasicShape::canBlend): Ignore circles with values that

cannot be interpolated.

(WebCore::BasicShapeCircle::floatValueForRadiusInBox): Convert circle

radius keywords to a float value.

(WebCore::BasicShapeCircle::path):
(WebCore::BasicShapeCircle::blend):

rendering/style/BasicShapes.h:

(WebCore::BasicShapeCenterCoordinate::canBlend):
(WebCore::BasicShapeRadius::canBlend):

LayoutTests:

Add a few tests for the new circle syntax. The old tests in
LayoutTests/csswg will be removed when the old syntax is removed.

Also update existing shape-inside, animation, and clip-path tests to
test the new syntax.

animations/resources/animation-test-helpers.js:

(parseBasicShape):

LayoutTests/animations/resources/animation-test-helpers.js:
LayoutTests/css3/masking/clip-path-animation-expected.txt:
LayoutTests/css3/masking/clip-path-animation.html:
LayoutTests/css3/masking/clip-path-circle-filter.html:
LayoutTests/css3/masking/clip-path-circle-overflow-hidden.html:
LayoutTests/css3/masking/clip-path-circle-overflow.html:
LayoutTests/css3/masking/clip-path-circle-relative-overflow.html:
LayoutTests/css3/masking/clip-path-circle.html:
LayoutTests/css3/masking/clip-path-restore.html:
LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt:
LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt:
LayoutTests/fast/shapes/parsing/parsing-test-utils.js:
LayoutTests/fast/shapes/shape-inside/shape-inside-animation-expected.txt:
LayoutTests/fast/shapes/shape-inside/shape-inside-animation.html:
LayoutTests/fast/shapes/shape-inside/shape-inside-calc-crash-expected.txt:
LayoutTests/fast/shapes/shape-inside/shape-inside-calc-crash.html:
LayoutTests/fast/shapes/shape-inside/shape-inside-circle-padding.html:
LayoutTests/fast/shapes/shape-inside/shape-inside-circle.html:
LayoutTests/fast/shapes/shape-inside/shape-inside-dynamic-nested.html:
LayoutTests/fast/shapes/shape-inside/shape-inside-empty-expected.html:
LayoutTests/fast/shapes/shape-inside/shape-inside-empty.html:
fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
fast/shapes/shape-outside-floats/shape-outside-animation.html:
fast/shapes/shape-outside-floats/shape-outside-floats-circle-000-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-circle-000.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-circle-001-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-circle-001.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-circle-002-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-circle-002.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-circle-003-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-circle-003.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-circle-004-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-circle-004.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-circle-005-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-circle-005.html: Added.

3:55 PM Changeset in webkit [159978] by commit-queue@webkit.org

3 edits in trunk/Tools

Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
https://bugs.webkit.org/show_bug.cgi?id=124714

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-12-02
Reviewed by Ryosuke Niwa.

Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

Scripts/webkitpy/layout_tests/models/test_failures.py:

(TestFailure.write_failure):
(FailureText):
(FailureText.write_failure):
(FailureAudio):
(FailureAudio.write_failure):
(FailureCrash.write_failure):
(FailureMissingResult):
(FailureTextMismatch):
(FailureMissingImageHash.write_failure):
(FailureMissingImage.write_failure):
(FailureImageHashMismatch.write_failure):
(FailureReftestMismatch.write_failure):
(FailureReftestMismatchDidNotOccur.write_failure):
(FailureMissingAudio):
(FailureAudioMismatch):

3:52 PM Changeset in webkit [159977] by commit-queue@webkit.org

5 edits in trunk/Tools

Remove the stderr_write attribute from StyleProcessorConfiguration
https://bugs.webkit.org/show_bug.cgi?id=124703

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-02
Reviewed by Ryosuke Niwa.

Remove the stderr_write attribute from this class in checker and
replace its use with calls to a logging module logger. We Should
use logging module instead of writing to stderr directly.

Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.

(check_webkit_style_configuration):
(CheckerDispatcher.dispatch): Remove FIXME comment.
(StyleProcessorConfiguration):
(StyleProcessorConfiguration.init):
(StyleProcessorConfiguration.write_style_error):

Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.

There is an "ERROR" prefix in log messiges from now.
(StyleProcessorConfigurationTest):
(StyleProcessorConfigurationTest._style_checker_configuration):
(StyleProcessorConfigurationTest.test_init):
(StyleProcessorConfigurationTest.test_write_style_error_emacs):
(StyleProcessorConfigurationTest.test_write_style_error_vs7):
(StyleProcessor_EndToEndTest.with):
(StyleProcessor_EndToEndTest.test_init):
(StyleProcessor_EndToEndTest.test_process):
(StyleProcessor_CodeCoverageTest.setUp):

Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.

(DefaultStyleErrorHandler.call):

Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification.

There is an "ERROR" prefix in log messiges from now.
(DefaultStyleErrorHandlerTest):
(DefaultStyleErrorHandlerTest.setUp):
(DefaultStyleErrorHandlerTest._mock_increment_error_count):
(DefaultStyleErrorHandlerTest._style_checker_configuration):
(DefaultStyleErrorHandlerTest._check_initialized):
(DefaultStyleErrorHandlerTest.test_non_reportable_error):
(DefaultStyleErrorHandlerTest.test_max_reports_per_category):
(DefaultStyleErrorHandlerTest.test_line_numbers):

3:48 PM Changeset in webkit [159976] by andersca@apple.com

3 edits
9 adds in trunk/Source/WebKit2

Split bundle page clients out into separate headers
https://bugs.webkit.org/show_bug.cgi?id=125115

Reviewed by Andreas Kling.

WebKit2.xcodeproj/project.pbxproj:
WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/InjectedBundle/API/c/WKBundlePageContextMenuClient.h: Added.
WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h: Added.
WebProcess/InjectedBundle/API/c/WKBundlePageEditorClient.h: Added.
WebProcess/InjectedBundle/API/c/WKBundlePageFormClient.h: Added.
WebProcess/InjectedBundle/API/c/WKBundlePageFullScreenClient.h: Added.
WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h: Added.
WebProcess/InjectedBundle/API/c/WKBundlePagePolicyClient.h: Added.
WebProcess/InjectedBundle/API/c/WKBundlePageResourceLoadClient.h: Added.
WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h: Added.

3:43 PM Changeset in webkit [159975] by ap@apple.com

3 edits
2 adds in trunk

WebCrypto HMAC doesn't check key algorithm's hash
https://bugs.webkit.org/show_bug.cgi?id=125114

Reviewed by Anders Carlsson.

Source/WebCore:

Test: crypto/subtle/hmac-check-algorithm.html

crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches): Check it.

LayoutTests:

crypto/subtle/hmac-check-algorithm-expected.txt: Added.
crypto/subtle/hmac-check-algorithm.html: Added.

3:30 PM Changeset in webkit [159974] by beidson@apple.com

2 edits in trunk/Source/WebCore

Possible crash in ProgressTracker::progressHeartbeatTimerFired(Timer<ProgressTracker>*)
https://bugs.webkit.org/show_bug.cgi?id=125110

Reviewed by Darin Adler.

It’s possible to have a null m_originatingProgressFrame when the heartbeat timer fires.

On the surface this seems impossible because the only time m_originatingProgressFrame is cleared
out the heartbeat timer is also stopped.

But there’s likely still a race condition in multi-threaded environments.

There’s no harm in null-checking m_originatingProgressFrame before accessing its loader.

loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::progressHeartbeatTimerFired):

3:17 PM Changeset in webkit [159973] by fpizlo@apple.com

5 edits in trunk/Source/JavaScriptCore

Baseline JIT calls to CommonSlowPaths shouldn't restore the last result
https://bugs.webkit.org/show_bug.cgi?id=125107

Reviewed by Mark Hahnenberg.

Just killing dead code.

jit/JITArithmetic.cpp:

(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emitSlow_op_urshift):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emitSlow_op_dec):
(JSC::JIT::emitSlow_op_mod):
(JSC::JIT::emit_op_mod):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emitSlow_op_div):

jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emitSlow_op_dec):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_sub):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emitSlow_op_div):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_strcat):
(JSC::JIT::emitSlow_op_get_callee):
(JSC::JIT::emitSlow_op_create_this):
(JSC::JIT::emitSlow_op_to_this):
(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emitSlow_op_to_number):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emitSlow_op_to_number):
(JSC::JIT::emitSlow_op_get_callee):
(JSC::JIT::emitSlow_op_create_this):
(JSC::JIT::emitSlow_op_to_this):

3:03 PM Changeset in webkit [159972] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[WK2] Improve readability of 'generate_message_handler' function
https://bugs.webkit.org/show_bug.cgi?id=125085

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-02
Reviewed by Sam Weinig.

Scripts/webkit2/messages.py:

(generate_message_handler):

2:59 PM Changeset in webkit [159971] by commit-queue@webkit.org

2 edits
7 adds in trunk/Source/Platform

Nix Upstream: Updating Platform files
https://bugs.webkit.org/show_bug.cgi?id=124982

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-12-02
Reviewed by Benjamin Poulain.

Adding new Platform files that are missing in the trunk.

PlatformNix.cmake:
nix/public/AudioDestinationConsumer.h: Added.

(Nix::AudioDestinationConsumer::~AudioDestinationConsumer):

nix/public/MediaConstraints.h: Added.
nix/public/MediaStream.h: Added.
nix/public/MediaStreamAudioSource.h: Added.
nix/public/MediaStreamCenter.h: Added.
nix/public/MediaStreamSource.h: Added.
nix/public/PrivatePtr.h: Added.

2:56 PM Changeset in webkit [159970] by beidson@apple.com

2 edits in trunk/Source/WebCore

Add more CachedPage null checks
https://bugs.webkit.org/show_bug.cgi?id=125106

Reviewed by Sam Weinig.

Only some functions in PageCache.cpp null-check the CachedPages in HistoryItems.

Every part that manipulates the CachedPage should.

history/PageCache.cpp:

(WebCore::PageCache::markPagesForVistedLinkStyleRecalc):
(WebCore::PageCache::markPagesForFullStyleRecalc):
(WebCore::PageCache::markPagesForDeviceScaleChanged):
(WebCore::PageCache::markPagesForCaptionPreferencesChanged):

2:53 PM Changeset in webkit [159969] by commit-queue@webkit.org

3 edits
2 adds in trunk/Tools

Add JavaScript style checker and teach checker.py about .js files
https://bugs.webkit.org/show_bug.cgi?id=125049

Patch by Brian J. Burg <Brian Burg> on 2013-12-02
Reviewed by Joseph Pecoraro.

Add a JavaScript file type, extension, and checker (JSChecker).
Use TextChecker for JavaScript tests, libraries, website resources,
etc. and use JSChecker for files within WebInspectorUI/UserInterface.

Amended tests for TextChecker to reflect the rule above.

Scripts/webkitpy/style/checker.py:

(_all_categories): Add categories defined by JSChecker.
(FileType): Add file type for JS and re-number the enum.
(CheckerDispatcher._file_type): Detect .js files as JavaScript.
(CheckerDispatcher._create_checker):
Create a JSChecker or TextChecker depending on the file's path.

Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherDispatchTest.assert_checker_js): Added.
(CheckerDispatcherDispatchTest.test_js_paths): Added.
(CheckerDispatcherDispatchTest.test_text_paths): Add new test paths
that end in .js but should be checked with TextChecker.

Scripts/webkitpy/style/checkers/js.py: Added.

(JSChecker):
(JSChecker.init):
(JSChecker.check):

Scripts/webkitpy/style/checkers/js_unittest.py: Added.

(JSTestCase):
(JSTestCase.assertNoError):
(JSTestCase.assertNoError.error_for_test):
(JSTestCase.assertError):
(JSTestCase.assertError.error_for_test):
(JSTestCase.test_no_error):
(JSTestCase.test_error):

2:48 PM Changeset in webkit [159968] by zoltan@webkit.org

19 edits in trunk

[CSS Shapes] Support inset parsing
https://bugs.webkit.org/show_bug.cgi?id=124903

Reviewed by David Hyatt.

Source/WebCore:

In this patch I added support for inset shape parsing for CSS Shapes. Inset is defined
by CSS Shapes Level 1 (http://dev.w3.org/csswg/css-shapes-1/#supported-basic-shapes).
Inset is going to be used by shape-outside (bug #124905), and eventually by shape-inside.

No new tests, I updated existing tests to cover the changes.

css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape): Add support for inset.
(WebCore::basicShapeForValue): Add support for inset.

css/CSSBasicShapes.cpp:

(WebCore::buildInsetString): Create inset css string.
(WebCore::CSSBasicShapeInset::cssText): Convert inset shape to a CSS string.
(WebCore::CSSBasicShapeInset::equals): Compare two inset rectangles.
(WebCore::CSSBasicShapeInset::serializeResolvingVariables): Create an inset string, with CSS variables resolved.
(WebCore::CSSBasicShapeInset::hasVariableReference): Determine if this inset has any CSS Variable references.

css/CSSBasicShapes.h: Add inset class.

(WebCore::CSSBasicShapeInset::create):
(WebCore::CSSBasicShapeInset::top):
(WebCore::CSSBasicShapeInset::right):
(WebCore::CSSBasicShapeInset::bottom):
(WebCore::CSSBasicShapeInset::left):
(WebCore::CSSBasicShapeInset::topLeftRadius):
(WebCore::CSSBasicShapeInset::topRightRadius):
(WebCore::CSSBasicShapeInset::bottomRightRadius):
(WebCore::CSSBasicShapeInset::bottomLeftRadius):
(WebCore::CSSBasicShapeInset::setTop):
(WebCore::CSSBasicShapeInset::setRight):
(WebCore::CSSBasicShapeInset::setBottom):
(WebCore::CSSBasicShapeInset::setLeft):
(WebCore::CSSBasicShapeInset::setTopLeftRadius):
(WebCore::CSSBasicShapeInset::setTopRightRadius):
(WebCore::CSSBasicShapeInset::setBottomRightRadius):
(WebCore::CSSBasicShapeInset::setBottomLeftRadius):
(WebCore::CSSBasicShapeInset::CSSBasicShapeInset):

css/CSSParser.cpp:

(WebCore::completeBorderRadii): Move static function before parseInsetBorderRadius.
(WebCore::CSSParser::parseInsetRoundedCorners): I added this helper function for parsing the rounded corners
(WebCore::CSSParser::parseBasicShapeInset): Parse inset.
(WebCore::CSSParser::parseBasicShape): Add call to parse inset.

css/CSSParser.h:
css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Add constructor for LengthSize.
(WebCore::CSSPrimitiveValue::init): Initialize LengthSize.

css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::create): Add support for creating PrimitiveValue from LengthSize.

css/CSSValuePool.h:

(WebCore::CSSValuePool::createValue): Add support for LengthSize.

platform/LengthSize.h:

(WebCore::LengthSize::blend): Add blend for LengthSize.

rendering/shapes/ShapeInsideInfo.cpp:

(WebCore::ShapeInsideInfo::isEnabledFor): Keep inset disabled for shape-inside now.

rendering/style/BasicShapes.cpp:

(WebCore::BasicShapeInset::path): Calculate path for an inset.
(WebCore::BasicShapeInset::blend): Blend two insets.

rendering/style/BasicShapes.h: Add higher level inset.

(WebCore::BasicShapeInset::create):
(WebCore::BasicShapeInset::top):
(WebCore::BasicShapeInset::right):
(WebCore::BasicShapeInset::bottom):
(WebCore::BasicShapeInset::left):
(WebCore::BasicShapeInset::topLeftRadius):
(WebCore::BasicShapeInset::topRightRadius):
(WebCore::BasicShapeInset::bottomRightRadius):
(WebCore::BasicShapeInset::bottomLeftRadius):
(WebCore::BasicShapeInset::setTop):
(WebCore::BasicShapeInset::setRight):
(WebCore::BasicShapeInset::setBottom):
(WebCore::BasicShapeInset::setLeft):
(WebCore::BasicShapeInset::setTopLeftRadius):
(WebCore::BasicShapeInset::setTopRightRadius):
(WebCore::BasicShapeInset::setBottomRightRadius):
(WebCore::BasicShapeInset::setBottomLeftRadius):
(WebCore::BasicShapeInset::BasicShapeInset):

LayoutTests:

fast/shapes/parsing/parsing-shape-inside-expected.txt:
fast/shapes/parsing/parsing-shape-lengths-expected.txt:
fast/shapes/parsing/parsing-shape-lengths.html:
fast/shapes/parsing/parsing-shape-outside-expected.txt:
fast/shapes/parsing/parsing-test-utils.js:

2:42 PM Changeset in webkit [159967] by timothy_horton@apple.com

7 edits in trunk/Source/WebKit2

Remote Layer Tree: Support cloning layers
https://bugs.webkit.org/show_bug.cgi?id=124874
<rdar://problem/15349468>

Reviewed by Simon Fraser.

We use PlatformCALayer::clone for CSS reflections, so implement it.

Also, since many reflections testcases also use masks,
working on this revealed that masks weren't working, because
we weren't flushing mask layers.

Shared/mac/RemoteLayerTreePropertyApplier.mm:

(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):

Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
Rename maskLayer->maskLayerID since it's a LayerID.

UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::commit):
Don't try to look up the layer if it's null.

Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::notePropertiesChanged):

Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
Keep track of all properties that have ever been changed on a layer.

WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::create):
(PlatformCALayerRemote::PlatformCALayerRemote):
(PlatformCALayerRemote::clone):
Copy all of the layer properties from the original to the clone,
and mark all properties that have ever been modified as
needing to be flushed to the UI process.

(PlatformCALayerRemote::recursiveBuildTransaction):
Flush our mask layer, if we have one.

(PlatformCALayerRemote::setMask):

WebProcess/WebPage/mac/PlatformCALayerRemote.h:

Store the mask layer we're given. Our owning GraphicsLayer will
hold on to it for us.

2:36 PM Changeset in webkit [159966] by ap@apple.com

9 edits
7 adds in trunk

Support WebCrypto AES-KW
https://bugs.webkit.org/show_bug.cgi?id=125105

Reviewed by Sam Weinig.

Source/WebCore:

Tests: crypto/subtle/aes-kw-key-manipulation.html

crypto/subtle/aes-kw-wrap-unwrap-aes.html

WebCore.xcodeproj/project.pbxproj: Added new files.

crypto/CryptoAlgorithmIdentifier.h: (WebCore::CryptoAlgorithmIdentifier): Added AES-KW.

It's not standardized yet, but there appears to be a consensus that it will be specified.

bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForSign):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveBits):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey):
Added AES-KW cases everywhere.

bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
(WebCore::JSCryptoKeySerializationJWK::keySizeIsValid):
(WebCore::JSCryptoKeySerializationJWK::addJWKAlgorithmToJSON):
Support importing/exporting AES-KW keys in JWK.

bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::JSSubtleCrypto::importKey):
(WebCore::JSSubtleCrypto::exportKey):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey):
Added some accidentally forgotten std::moves.

crypto/algorithms/CryptoAlgorithmAES_KW.cpp: Added.
crypto/algorithms/CryptoAlgorithmAES_KW.h: Added.
crypto/mac/CryptoAlgorithmAES_KWMac.cpp: Added.

crypto/keys/CryptoKeyAES.cpp: (WebCore::CryptoKeyAES::CryptoKeyAES): Allow AES-KW

as valid algorithm for AES keys.

crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Register AES-KW.

LayoutTests:

crypto/subtle/aes-kw-key-manipulation-expected.txt: Added.
crypto/subtle/aes-kw-key-manipulation.html: Added.
crypto/subtle/aes-kw-wrap-unwrap-aes-expected.txt: Added.
crypto/subtle/aes-kw-wrap-unwrap-aes.html: Added.

2:35 PM Changeset in webkit [159965] by andersca@apple.com

11 edits in trunk/Source/WebKit2

WKPageLoaderClient should be versioned
https://bugs.webkit.org/show_bug.cgi?id=125104

Reviewed by Sam Weinig.

Add multiple versions of the WKPageLoaderClient struct. In a subsequent patch,
WKPageLoaderClient and kWKPageLoaderClientCurrentVersion will be deprecated. Instead,
users of the API are supposed to explicitly choose a version and a versioned struct.

Shared/APIClient.h:

Add a new API::Client class with a new ClientTraits template that uses std::tuple for versions.

Shared/APIClientTraits.cpp:
Shared/APIClientTraits.h:

Remove WKPageLoaderClient interface sizes.

UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient):
Add an explicit cast to WKPageLoaderClientBase. In an upcoming patch, WKPageSetPageLoaderClient
will be changed to take a WKPageLoaderClientBase instead.

UIProcess/API/C/WKPageLoaderClient.h:

Add new versions.

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(setUpPageLoaderClient):
Use an explicit version.

UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didCommitLoadForFrame):
(WebKit::WebLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::WebLoaderClient::didFinishLoadForFrame):
(WebKit::WebLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didSameDocumentNavigationForFrame):
(WebKit::WebLoaderClient::didReceiveTitleForFrame):
(WebKit::WebLoaderClient::didFirstLayoutForFrame):
(WebKit::WebLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebLoaderClient::didLayout):
(WebKit::WebLoaderClient::didRemoveFrameFromHierarchy):
(WebKit::WebLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::WebLoaderClient::didRunInsecureContentForFrame):
(WebKit::WebLoaderClient::didDetectXSSForFrame):
(WebKit::WebLoaderClient::canAuthenticateAgainstProtectionSpaceInFrame):
(WebKit::WebLoaderClient::didReceiveAuthenticationChallengeInFrame):
(WebKit::WebLoaderClient::didStartProgress):
(WebKit::WebLoaderClient::didChangeProgress):
(WebKit::WebLoaderClient::didFinishProgress):
(WebKit::WebLoaderClient::processDidBecomeUnresponsive):
(WebKit::WebLoaderClient::interactionOccurredWhileProcessUnresponsive):
(WebKit::WebLoaderClient::processDidBecomeResponsive):
(WebKit::WebLoaderClient::processDidCrash):
(WebKit::WebLoaderClient::didChangeBackForwardList):
(WebKit::WebLoaderClient::shouldGoToBackForwardListItem):
(WebKit::WebLoaderClient::willGoToBackForwardListItem):
(WebKit::WebLoaderClient::didFailToInitializePlugin):
(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
(WebKit::WebLoaderClient::pluginLoadPolicy):
Go through client.base everywhere.

UIProcess/WebLoaderClient.h:

Add API::ClientTraits specialization. Change WebLoaderClient to derive from API::Client<WKPageLoaderClientBase>.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeLoaderClient):
This now takes a WKPageLoaderClientBase*.

2:33 PM Changeset in webkit [159964] by mhahnenberg@apple.com

2 edits in trunk/Tools

run-jsc-stress-tests always copies the VM
https://bugs.webkit.org/show_bug.cgi?id=125092

Reviewed by Filip Pizlo.

This can be slow, especially with full debug builds. It should just symlink the VM into the
bundle by default and do a full copy only when asked.

Scripts/run-jsc-stress-tests:

2:31 PM Changeset in webkit [159963] by Beth Dakin

2 edits in trunk/Source/WebKit

Attempted build fix. I think this is no longer needed.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

2:25 PM Changeset in webkit [159962] by bshafiei@apple.com

5 edits in branches/safari-537.60-branch/Source

Versioning.

2:21 PM Changeset in webkit [159961] by Brent Fulgham

2 edits in trunk/Tools

[Win] Port run-jsc-stress-tests
https://bugs.webkit.org/show_bug.cgi?id=124801

Reviewed by Filip Pizlo.

Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl

command on Windows so that stress tests can run.

2:06 PM WebInspectorCodingStyleGuide edited by timothy@apple.com

(diff)

1:53 PM Changeset in webkit [159960] by Beth Dakin

11 edits in trunk/Source

Add a setting to opt into a mode where the background extends and fixed elements
don't move on rubber-band
https://bugs.webkit.org/show_bug.cgi?id=124745

Reviewed by Tim Horton.

Source/WebCore:

New setting backgroundShouldExtendBeyondPage() will cause the tile cache to have a
margin, and it will also cause fixed elements and backgrounds to stick to the
viewport on scroll instead of sticking to the document.

WebCore.exp.in:
page/FrameView.cpp:

(WebCore::FrameView::scrollBehaviorForFixedElements):

page/Settings.in:
rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):

Source/WebKit:

Keep Windows happy.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit2:

Add SPI to enable the new setting.

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetBackgroundShouldExtendBeyondPage):
(WKPreferencesGetBackgroundShouldExtendBeyondPage):

UIProcess/API/C/WKPreferencesPrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

1:44 PM Changeset in webkit [159959] by bshafiei@apple.com

1 copy in tags/Safari-537.60.8

New tag.

1:41 PM Changeset in webkit [159958] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[MediaStream] Use iterator-based loops instead of index-based loops
https://bugs.webkit.org/show_bug.cgi?id=125021

Patch by Roger Zanoni <rogerzanoni@gmail.com> on 2013-12-02
Reviewed by Eric Carlson.

Also, changing iterator variable names from iter to it and
initializing an 'end' variable in each loop instead of evaluating
'collection.end()' multiple times.

No new tests, covered by existing ones.

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::cloneMediaStreamTrackVector):
(WebCore::MediaStream::haveTrackWithSource):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::trackDidEnd):
(WebCore::MediaStream::scheduledEventTimerFired):

1:15 PM Changeset in webkit [159957] by mhahnenberg@apple.com

2 edits in trunk/Tools

Build fix after r159955

Scripts/run-jsc-stress-tests:

12:56 PM Changeset in webkit [159956] by timothy_horton@apple.com

5 edits in trunk/Source/WebKit2

Remote Layer Tree: Hook up setLayerTreeStateIsFrozen
https://bugs.webkit.org/show_bug.cgi?id=124872

Reviewed by Brent Fulgham.

setLayerTreeStateIsFrozen is the mechanism used to ensure that
layer property changes (including new backing store) aren't committed
while e.g. the page is reconfigured for printing.

WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::RemoteLayerTreeContext):
(WebKit::RemoteLayerTreeContext::flushLayers):
(WebKit::RemoteLayerTreeContext::setIsFlushingSuspended):

WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen):

12:55 PM Changeset in webkit [159955] by mhahnenberg@apple.com

3 edits
1 delete in trunk/Tools

run-jsc-stress-tests should be able to package its tests and move them places
https://bugs.webkit.org/show_bug.cgi?id=124549

Reviewed by Filip Pizlo.

Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation

of grep -i -q

Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.

We now also copy whatever VM was specified, along with its associated framework, into this directory.
All of the generated scripts now are completely relative within the results directory. This allows
run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
tarball of the generated results directory. Also refactored several portions of the script into
separate functions to make it easier to run them conditionally depending on which mode we're running in.

12:52 PM Changeset in webkit [159954] by commit-queue@webkit.org

13 edits in trunk

[css shapes] Parse new ellipse shape syntax
https://bugs.webkit.org/show_bug.cgi?id=124620

Patch by Rob Buis <rob.buis@samsung.com> on 2013-12-02
Reviewed by Dirk Schulze.

Source/WebCore:

Implement parsing of the new ellipse shape syntax. This closely follows the patch
for the new circle syntax (https://bugs.webkit.org/show_bug.cgi?id=124618), with
some refactoring of functionality shared by both.

Updated existing parsing tests to cover this.

css/BasicShapeFunctions.cpp:

(WebCore::BasicShapeRadiusToCSSValue):
(WebCore::valueForBasicShape):
(WebCore::CSSValueToBasicShapeRadius):
(WebCore::basicShapeForValue):

css/CSSBasicShapes.cpp:

(WebCore::buildEllipseString):
(WebCore::CSSBasicShapeEllipse::cssText):
(WebCore::CSSBasicShapeEllipse::equals):
(WebCore::buildDeprecatedEllipseString):
(WebCore::CSSDeprecatedBasicShapeEllipse::cssText):
(WebCore::CSSDeprecatedBasicShapeEllipse::equals):

css/CSSBasicShapes.h:

(WebCore::CSSDeprecatedBasicShapeEllipse::create):
(WebCore::CSSDeprecatedBasicShapeEllipse::centerX):
(WebCore::CSSDeprecatedBasicShapeEllipse::centerY):
(WebCore::CSSDeprecatedBasicShapeEllipse::radiusX):
(WebCore::CSSDeprecatedBasicShapeEllipse::radiusY):
(WebCore::CSSDeprecatedBasicShapeEllipse::setCenterX):
(WebCore::CSSDeprecatedBasicShapeEllipse::setCenterY):
(WebCore::CSSDeprecatedBasicShapeEllipse::setRadiusX):
(WebCore::CSSDeprecatedBasicShapeEllipse::setRadiusY):
(WebCore::CSSDeprecatedBasicShapeEllipse::CSSDeprecatedBasicShapeEllipse):

css/CSSParser.cpp:

(WebCore::CSSParser::parseBasicShapeEllipse):
(WebCore::CSSParser::parseDeprecatedBasicShapeEllipse):
(WebCore::CSSParser::parseBasicShape):

css/CSSParser.h:
rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

rendering/style/BasicShapes.cpp:

(WebCore::DeprecatedBasicShapeEllipse::path):
(WebCore::DeprecatedBasicShapeEllipse::blend):
(WebCore::BasicShapeEllipse::path):
(WebCore::BasicShapeEllipse::blend):

rendering/style/BasicShapes.h:

(WebCore::BasicShapeEllipse::centerX):
(WebCore::BasicShapeEllipse::centerY):
(WebCore::BasicShapeEllipse::radiusX):
(WebCore::BasicShapeEllipse::radiusY):
(WebCore::BasicShapeEllipse::setCenterX):
(WebCore::BasicShapeEllipse::setCenterY):
(WebCore::BasicShapeEllipse::setRadiusX):
(WebCore::BasicShapeEllipse::setRadiusY):
(WebCore::BasicShapeEllipse::BasicShapeEllipse):
(WebCore::DeprecatedBasicShapeEllipse::create):
(WebCore::DeprecatedBasicShapeEllipse::DeprecatedBasicShapeEllipse):

LayoutTests:

Test that the new ellipse syntax is properly parsed.

fast/shapes/parsing/parsing-shape-inside-expected.txt:
fast/shapes/parsing/parsing-shape-outside-expected.txt:
fast/shapes/parsing/parsing-test-utils.js:

12:44 PM Changeset in webkit [159953] by Brent Fulgham

2 edits in branches/safari-537.60-branch/Source/WebKit

Merge r159941.

2013-12-02 Brent Fulgham <Brent Fulgham>

[Win] WebKit Project doesn't copy resource bundle
https://bugs.webkit.org/show_bug.cgi?id=125078

Reviewed by Jer Noble.

WebKit.vcxproj/WebKit/WebKitPostBuild.cmd:

12:40 PM Changeset in webkit [159952] by Antoine Quint

2 edits in trunk/Source/WebInspectorUI

Web Inspector: popover can overlap target frame
https://bugs.webkit.org/show_bug.cgi?id=125069

Reviewed by Joseph Pecoraro.

Fix a regression introduced in http://trac.webkit.org/changeset/159286. We should only
offset the frame of the popover in the y-axis if the target edge is on the x-axis, and
vice versa. We also remove the needsToDrawBackground check since it incorrectly disregarded
the anchor point. We now always draw the background which is a lot safer and guarantees
we'll always draw an adequate frame and anchor point.

UserInterface/Popover.js:

(WebInspector.Popover.prototype._update):
(WebInspector.Popover.prototype._bestMetricsForEdge):

12:28 PM Changeset in webkit [159951] by ap@apple.com

4 edits in trunk/Source/WebCore

Add support for WebCrypto RSA-OAEP
https://bugs.webkit.org/show_bug.cgi?id=125084

Build fix.

crypto/CommonCryptoUtilities.h:
crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
crypto/mac/CryptoKeyRSAMac.cpp:

12:11 PM Changeset in webkit [159950] by commit-queue@webkit.org

5 edits in trunk

Use GenericEventQueue in TrackListBase and reduce code duplication with scheduleTrackEvent()
https://bugs.webkit.org/show_bug.cgi?id=124811

Patch by Brendan Long <b.long@cablelabs.com> on 2013-12-02
Reviewed by Eric Carlson.

Source/WebCore:

No new tests because this is just refactoring.

html/track/TrackListBase.cpp:

(TrackListBase::TrackListBase): Replace event code with a GenericEventQueue.
(TrackListBase::scheduleTrackEvent): Factor out duplicate code in schedule{Add,Remove}TrackEvent functions.
(TrackListBase::scheduleAddTrackEvent): Same.
(TrackListBase::scheduleRemoveTrackEvent): Same.
(TrackListBase::scheduleChangeEvent): Use GenericEventQueue.

html/track/TrackListBase.h: Replace event code with GenericEventQueue.

LayoutTests:

platform/mac/TestExpectations: Unskip onremovetrack test which was fixed a long time ago.

12:05 PM Changeset in webkit [159949] by ap@apple.com

2 edits in trunk/Source/WebCore

Add support for WebCrypto RSA-OAEP
https://bugs.webkit.org/show_bug.cgi?id=125084

Build fix.

WebCore.xcodeproj/project.pbxproj: Fix an automatic merge failure by re-adding

CryptoAlgorithmRsaOaepParams.h.

12:00 PM Changeset in webkit [159948] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Remote Layer Tree: Disable direct image compositing
https://bugs.webkit.org/show_bug.cgi?id=124875
<rdar://problem/15446024>

Reviewed by Simon Fraser.

WebProcess/WebPage/mac/GraphicsLayerCARemote.h:

Image-as-layer-contents is not implemented for the remote layer tree.

11:58 AM Changeset in webkit [159947] by vjaquez@igalia.com

2 edits in trunk/Source/WebCore

[Gstreamer] update webkitvideosink metadata
https://bugs.webkit.org/show_bug.cgi?id=125082

Reviewed by Philippe Normand.

No new tests, no behavior changes.

platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkit_video_sink_class_init):

11:55 AM Changeset in webkit [159946] by Antoine Quint

7 edits in trunk/Source/WebInspectorUI

Web Inspector: add a method to add padding around a WebInspector.Rect
https://bugs.webkit.org/show_bug.cgi?id=125072

Reviewed by Joseph Pecoraro.

Add a new WebInspector.Rect.prototype.pad() method which does not alter
the rectangle it's called and returns a new rect much like .inset(). I've
checked all call sites and there was no reuse of the rectangle that was
padded so this patch won't have any side effects.

UserInterface/Breakpoint.js:

(WebInspector.Breakpoint.prototype._showEditBreakpointPopover):

UserInterface/CSSStyleDeclarationTextEditor.js:
UserInterface/Geometry.js:

(WebInspector.Rect.prototype.pad):

UserInterface/LayerTreeSidebarPanel.js:

(WebInspector.LayerTreeSidebarPanel.prototype._updatePopoverForSelectedNode):

UserInterface/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._showPopover):

UserInterface/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):

11:55 AM Changeset in webkit [159945] by vjaquez@igalia.com

4 edits in trunk/Source/WebCore

Simplify MediaPlayerPrivateGStreamerBase::createVideoSink()
https://bugs.webkit.org/show_bug.cgi?id=125077

Remove the method's unused parameter.
Remove the GStreamer 0.10.22 run-time validation, since we are using
GStreamer 1.0 officially.
Remove the creation of a spurious Bin for the video sink, since
either the fpssink or the webkitsink are valid sink elements.
Change fpsink to a GRefPtr.

Now, createVideoSink() returns a simple pointer to the created sink
element.

Reviewed by Philippe Normand.

No new tests, no behavior changes.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
(WebCore::MediaPlayerPrivateGStreamerBase::decodedFrameCount):
(WebCore::MediaPlayerPrivateGStreamerBase::droppedFrameCount):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

11:50 AM Changeset in webkit [159944] by ap@apple.com

11 edits
12 adds in trunk

Add support for WebCrypto RSA-OAEP
https://bugs.webkit.org/show_bug.cgi?id=125084

Reviewed by Sam Weinig.

Source/WebCore:

Tests: crypto/subtle/rsa-oaep-key-manipulation.html

crypto/subtle/rsa-oaep-plaintext-length.html
crypto/subtle/rsa-oaep-wrap-unwrap-aes.html

WebCore.xcodeproj/project.pbxproj: Added new files.

bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::createRsaOaepParams):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
Added RSA-OAEP parameters.

bindings/js/JSCryptoKeySerializationJWK.cpp:

crypto/CommonCryptoUtilities.cpp: Added. (WebCore::getCommonCryptoDigestAlgorithm):
crypto/CommonCryptoUtilities.h: Added.

Extracted some shared code and forward declarations for CommonCrypto.

crypto/CryptoAlgorithmParameters.h: (WebCore::CryptoAlgorithmParameters::Class):
crypto/parameters/CryptoAlgorithmRsaOaepParams.h: Added.

Added RsaOaepParams.

crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp: Added.
crypto/algorithms/CryptoAlgorithmRSA_OAEP.h: Added.
crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp: Added.

crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::getCommonCryptoHMACAlgorithm):
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
crypto/mac/CryptoKeyMac.cpp:
crypto/mac/CryptoKeyRSAMac.cpp:

Use CommonCryptoUtilities.

crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Register RSA-OAEP.

LayoutTests:

crypto/subtle/rsa-oaep-key-manipulation-expected.txt: Added.
crypto/subtle/rsa-oaep-key-manipulation.html: Added.
crypto/subtle/rsa-oaep-plaintext-length-expected.txt: Added.
crypto/subtle/rsa-oaep-plaintext-length.html: Added.
crypto/subtle/rsa-oaep-wrap-unwrap-aes-expected.txt: Added.
crypto/subtle/rsa-oaep-wrap-unwrap-aes.html: Added.

11:49 AM Changeset in webkit [159943] by fpizlo@apple.com

18 edits
4 adds in trunk

Stores to local captured variables should be intercepted
https://bugs.webkit.org/show_bug.cgi?id=124883

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Previously, in bytecode, you could assign to a captured variable just as you would
assign to any other kind of variable. This complicates closure variable constant
inference because we don't have any place where we can intercept stores to captured
variables in the LLInt.

This patch institutes a policy that only certain instructions can store to captured
variables. If you interpret those instructions and you are required to notifyWrite()
then you need to check if the relevant variable is captured. Those instructions are
tracked in CodeBlock.cpp's VerifyCapturedDef. The main one is simply op_captured_mov.
In the future, we'll probably modify those instructions to have a pointer directly to
the VariableWatchpointSet; but for now we just introduce the captured instructions as
placeholders.

In order to validate that the placeholders are inserted correctly, this patch improves
the CodeBlock validation to be able to inspect every def in the bytecode. To do that,
this patch refactors the liveness analysis' use/def calculator to be reusable; it now
takes a functor for each use or def.

In the process of refactoring the liveness analysis, I noticed that op_enter was
claiming to def all callee registers. That's wrong; it only defs the non-temporary
variables. Making that change revealed preexisting bugs in the liveness analysis, since
now the validator would pick up cases where the bytecode claimed to use a temporary and
the def calculator never noticed the definition (or the converse - where the bytecode
was actually not using a temporary but the liveness analysis thought that it was a
use). This patch fixes a few of those bugs.

GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::stepOverInstruction):

bytecode/BytecodeUseDef.h: Added.

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::isCaptured):
(JSC::CodeBlock::validate):

bytecode/CodeBlock.h:
bytecode/Opcode.h:

(JSC::padOpcodeName):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::resolveCallee):
(JSC::BytecodeGenerator::emitMove):
(JSC::BytecodeGenerator::isCaptured):
(JSC::BytecodeGenerator::local):
(JSC::BytecodeGenerator::constLocal):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitLazyNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionInternal):

bytecompiler/BytecodeGenerator.h:

(JSC::Local::Local):
(JSC::Local::isCaptured):
(JSC::Local::captureMode):
(JSC::BytecodeGenerator::captureMode):
(JSC::BytecodeGenerator::emitNode):
(JSC::BytecodeGenerator::pushOptimisedForIn):

bytecompiler/NodesCodegen.cpp:

(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
(JSC::ForInNode::emitBytecode):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/SymbolTable.h:

(JSC::SymbolTable::isCaptured):

LayoutTests:

Reviewed by Mark Hahnenberg.

js/regress/captured-assignments-expected.txt: Added.
js/regress/captured-assignments.html: Added.
js/regress/script-tests/captured-assignments.js: Added.

11:09 AM Changeset in webkit [159942] by fpizlo@apple.com

29 edits in trunk/Source/JavaScriptCore

Instead of watchpointing activation allocation, we should watchpoint entry into functions that have captured variables
https://bugs.webkit.org/show_bug.cgi?id=125052

Reviewed by Mark Hahnenberg.

This makes us watch function entry rather than activation creation. We only incur the
costs of doing so for functions that have captured variables, and only on the first two
entries into the function. This means that closure variable constant inference will
naturally work even for local uses of the captured variable, like:

(function(){

var blah = 42;
... stuff
function () { ... blah /* we can fold this to 42 */ }
... blah we can also fold this to 42.

})();

Previously, only the nested use would have been foldable.

bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

bytecode/Opcode.h:

(JSC::padOpcodeName):

bytecode/Watchpoint.h:

(JSC::WatchpointSet::touch):
(JSC::InlineWatchpointSet::touch):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGNode.h:

(JSC::DFG::Node::hasSymbolTable):

dfg/DFGNodeType.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGWatchpointCollectionPhase.cpp:

(JSC::DFG::WatchpointCollectionPhase::handle):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

jit/JIT.h:
jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_touch_entry):

llint/LowLevelInterpreter.asm:
runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

runtime/CommonSlowPaths.h:
runtime/JSActivation.h:

(JSC::JSActivation::create):

runtime/SymbolTable.cpp:

(JSC::SymbolTable::SymbolTable):

runtime/SymbolTable.h:

10:47 AM Changeset in webkit [159941] by Brent Fulgham

2 edits in trunk/Source/WebKit

[Win] WebKit Project doesn't copy resource bundle
https://bugs.webkit.org/show_bug.cgi?id=125078

Reviewed by Jer Noble.

WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Correct post-build step

to copy WebKit.resources to build target.

10:23 AM Changeset in webkit [159940] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[JSC] Get rid of some unused parameters in LLIntSlowPaths.cpp macros
https://bugs.webkit.org/show_bug.cgi?id=125075

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-02
Reviewed by Michael Saboff.

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::handleHostCall): added UNUSED_PARAM(pc).
(JSC::LLInt::setUpCall): Doesn't pass 'pc' to LLINT_CALL macros.
(JSC::LLInt::LLINT_SLOW_PATH_DECL): Ditto.

9:49 AM Changeset in webkit [159939] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[GTK] Fails to build with freetype 2.5.1
https://bugs.webkit.org/show_bug.cgi?id=125074

Patch by Andres Gomez <Andres Gomez> on 2013-12-02
Reviewed by Carlos Garcia Campos.

FreeType specifies a canonical way of including their own
headers. Now, we are following this recommendation so the
compilation won't be broken again due to an upgrade in FeeType's
including paths.

platform/graphics/freetype/FontPlatformDataFreeType.cpp:
platform/graphics/freetype/SimpleFontDataFreeType.cpp:
platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:

9:28 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

9:20 AM Changeset in webkit [159938] by lauro.neto@openbossa.org

5 edits
1 move
1 add
1 delete in trunk/LayoutTests

[MediaStream] Update layout tests to newer spec.
https://bugs.webkit.org/show_bug.cgi?id=124985

Reviewed by Eric Carlson.

TestExpectations:
fast/mediastream/MediaStream-onended-expected.txt: Removed.
fast/mediastream/MediaStreamTrack-onended-expected.txt: Added.
fast/mediastream/MediaStreamTrack-onended.html: Renamed from LayoutTests/fast/mediastream/MediaStream-onended.html.
fast/mediastream/RTCPeerConnection-ice-expected.txt:
fast/mediastream/RTCPeerConnection-state-expected.txt:
fast/mediastream/RTCSessionDescription-expected.txt:

9:14 AM Changeset in webkit [159937] by commit-queue@webkit.org

7 edits in trunk/Source/JavaScriptCore

Remove stdio.h from JSC files.
https://bugs.webkit.org/show_bug.cgi?id=125066

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-02
Reviewed by Michael Saboff.

Remove stdio.h, when it is not necessary to be included.

bytecode/CodeBlock.cpp:
bytecode/StructureSet.h:
profiler/LegacyProfiler.cpp:
profiler/Profile.cpp:
profiler/ProfileNode.cpp:
yarr/YarrInterpreter.cpp:

8:51 AM Changeset in webkit [159936] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Unused include files when building without JIT.
https://bugs.webkit.org/show_bug.cgi?id=125062

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-02
Reviewed by Michael Saboff.

We should organize the includes, and guard JIT methods
in ValueRecovery.

bytecode/ValueRecovery.cpp: Guard include files.
bytecode/ValueRecovery.h: Guard JIT methods.

8:41 AM Changeset in webkit [159935] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[MIPS] Small stack frame causes regressions.
https://bugs.webkit.org/show_bug.cgi?id=124945

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-12-02
Reviewed by Michael Saboff.

Fix stack space for LLInt on MIPS.

llint/LowLevelInterpreter32_64.asm:

8:38 AM Changeset in webkit [159934] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

jsc: implement a native readFile function
https://bugs.webkit.org/show_bug.cgi?id=125059

Patch by Brian J. Burg <Brian Burg> on 2013-12-02
Reviewed by Filip Pizlo.

This adds a native readFile() function to jsc, used to slurp
an entire file into a JavaScript string.

jsc.cpp:

(GlobalObject::finishCreation): Add readFile() to globals.
(functionReadFile): Added.

7:36 AM Changeset in webkit [159933] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

JSC does not build if OPCODE_STATS is enabled.
https://bugs.webkit.org/show_bug.cgi?id=125011

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-02
Reviewed by Filip Pizlo.

bytecode/Opcode.cpp:

6:19 AM Changeset in webkit [159932] by Chris Fleizach

4 edits
2 adds in trunk

AX: Crash at WebCore::commonTreeScope
https://bugs.webkit.org/show_bug.cgi?id=125042

Reviewed by Mario Sanchez Prada.

Source/WebCore:

When an AX text marker that references a node in a detached document is used to create a text marker range, a crash occurs
because the method to determine commonTreeScopes does not account for when there are no common tree scopes.

Test: platform/mac/accessibility/ordered-textmarker-crash.html

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::visiblePositionRangeForUnorderedPositions):

dom/TreeScope.cpp:

(WebCore::commonTreeScope):

LayoutTests:

platform/mac/accessibility/ordered-textmarker-crash-expected.txt: Added.
platform/mac/accessibility/ordered-textmarker-crash.html: Added.

5:58 AM Changeset in webkit [159931] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Fix a crash in the webaudio source provider when the audio track is going away.
https://bugs.webkit.org/show_bug.cgi?id=124975

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-02
Reviewed by Philippe Normand.

Merged https://chromium.googlesource.com/chromium/blink/+/b21838b32bf11b1a972dfc449ddde71115490c23

Before this patch, it was hitting a use-after-free crash when the audio
track in the media stream is going away and the webaudio mediastreamsourcenode
is still running.

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource): Passing audio track
pointer to MediaStreamAudioSourceNode constructor.

Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::create):
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):

Modules/webaudio/MediaStreamAudioSourceNode.h: Added

MediaStreamTrack class variable and change the constructor to receive
it as parameter.

3:34 AM Changeset in webkit [159930] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Adding failure expectations for the

fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html reftest.

3:30 AM Changeset in webkit [159929] by gyuyoung.kim@samsung.com

3 edits in trunk/LayoutTests

Unreviewed, EFL rebaseline since r159915.

Error messages are changed. So, test results need to be updated.

platform/efl/fast/forms/validation-message-appearance-expected.txt:
platform/efl/fast/forms/validationMessage-expected.txt:

3:27 AM Changeset in webkit [159928] by commit-queue@webkit.org

2 edits in trunk

[GTK] Remove unneeded autoconf macros
https://bugs.webkit.org/show_bug.cgi?id=125044

Compilers that do not support const/inline/volatile and
systems with pre-C89-headers are anyway not supported.

Patch by Adrian Bunk <bunk@stusta.de> on 2013-12-02
Reviewed by Gustavo Noronha Silva.

Source/autotools/CheckSystemAndBasicDependencies.m4:

2:47 AM Changeset in webkit [159927] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk

Merge r159926 - [GTK] GTK2 paint code path does not render AC layers
https://bugs.webkit.org/show_bug.cgi?id=124967

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-12-02
Reviewed by Carlos Garcia Campos.

webkit/webkitwebview.cpp:

(webkit_web_view_expose_event): also paint AC layers when painting the widget,
when AC is on.

2:45 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

2:44 AM Changeset in webkit [159926] by Gustavo Noronha Silva

2 edits in trunk/Source/WebKit/gtk

[GTK] GTK2 paint code path does not render AC layers
https://bugs.webkit.org/show_bug.cgi?id=124967

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-12-02
Reviewed by Carlos Garcia Campos.

webkit/webkitwebview.cpp:

(webkit_web_view_expose_event): also paint AC layers when painting the widget,
when AC is on.

2:40 AM Changeset in webkit [159925] by commit-queue@webkit.org

12 edits
1 add in trunk

[ATK] Support active state for listbox elements.
https://bugs.webkit.org/show_bug.cgi?id=125009

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2013-12-02
Reviewed by Chris Fleizach.

Source/WebCore:

Added support for ATK_STATE_ACTIVE for listbox elements.

accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(setAtkStateSetFromCoreObject):

Tools:

Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.

DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isSelectedOptionActive):

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::isSelectedOptionActive):

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isSelectedOptionActive):

WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::isSelectedOptionActive):

LayoutTests:

Establish expectations for the test (all PASS).

accessibility/multiselect-list-reports-active-option-expected.txt: Added.
platform/efl-wk1/TestExpectations:
platform/efl-wk2/TestExpectations:

2:24 AM Changeset in webkit [159924] by zandobersek@gmail.com

2 edits in trunk/Tools

Unreviewed GTK gardening.

Scripts/run-gtk-tests:

(TestRunner): Skip two unit tests that are causing the subsequent test to crash.

2:12 AM Changeset in webkit [159923] by Seokju Kwon

3 edits in trunk/Source/WebCore

Web Inspector: Remove unused functions from InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=125061

Reviewed by Antoine Quint.

Get rid of unused functions, redundant inclusion and forward declaration.

No new tests, no behavior changes.

inspector/InspectorAgent.cpp:
inspector/InspectorAgent.h:

2:04 AM Changeset in webkit [159922] by Carlos Garcia Campos

46 edits in releases/WebKitGTK/webkit-2.2

Merge r155201 - REGRESSION(149636, merged in 153145): ToThis conversion doesn't work in the DFG
https://bugs.webkit.org/show_bug.cgi?id=120781

Reviewed by Mark Hahnenberg.

Roll this back in with a build fix.

Use some method table hacks to detect if the CheckStructure optimization is valid for to_this.

Introduce a FinalObjectUse and use it for ToThis->Identity conversion.

This looks like it might be perf-neutral on the major benchmarks, but it
introduces some horrible performance cliffs. For example if you add methods to
the Array prototype, you'll get horrible performance cliffs. As in virtual calls
to C++ every time you call a JS function even if it's inlined.
LongSpider/3d-cube appears to hit this.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGRepatch.cpp:

(JSC::DFG::emitPutTransitionStub):

dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculateFinalObject):
(JSC::DFG::SpeculativeJIT::speculate):

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGUseKind.cpp:

(WTF::printInternal):

dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):
(JSC::DFG::isCell):

2:00 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

1:58 AM Changeset in webkit [159921] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix build warning in EventHandler.cpp
https://bugs.webkit.org/show_bug.cgi?id=125010

Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-12-02
Reviewed by Csaba Osztrogonác.

page/EventHandler.cpp:

(WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):

1:38 AM WebKitGTK/2.2.x edited by Andres Gomez

(diff)

1:28 AM Changeset in webkit [159920] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk

Merge r159843 - REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
https://bugs.webkit.org/show_bug.cgi?id=124954

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-11-28
Reviewed by Carlos Garcia Campos.

tests/testwebview.c: new test to ensure setting and getting source mode work as intended.
webkit/webkitwebview.cpp:

(webkit_web_view_get_view_source_mode): actually return the value we query from WebCore.

1:26 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

1:24 AM Changeset in webkit [159919] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r159615 - [GTK] Cannot scroll in option menu when it larger than the screen
https://bugs.webkit.org/show_bug.cgi?id=124671

Reviewed by Martin Robinson.

The problem is that the popup menu is not resized to fit in the
screen, so it doesn't scroll and some of the items are offscreen
so they can't be selected either. GTK+ automatically resizes the
popup menus to fit in the work area, but only when the menu is
already positioned.

platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::popUp): Schedule a resize of the popup
menu right after showing it once it has a position.

1:21 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

1:20 AM Changeset in webkit [159918] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r159811 - [GTK] Programs/WebKit2APITests/TestWebKitSettings unit test is failing
https://bugs.webkit.org/show_bug.cgi?id=124924

Reviewed by Carlos Garcia Campos.

'Chrome'/'Chromium' substrings were removed from the user agent string in r159572, meaning the unit
test shouldn't check for those two substrings anymore. Instead, 'Safari' (as until now) and 'AppleWebKit'
substrings should be checked for.

UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettingsUserAgent):

1:18 AM Changeset in webkit [159917] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/LayoutTests

Merge r159686 - Unreviewed GTK gardening.
Adding failure expectations for tests that regressed with r159572.

platform/gtk/TestExpectations:

1:17 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

1:15 AM Changeset in webkit [159916] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r159572 - [GTK] Remove Chromium as user agent and claim to be Safari in OS X
https://bugs.webkit.org/show_bug.cgi?id=124229

Reviewed by Martin Robinson.

http://www.duolingo.com/ doesn't get render correctly because it uses
Chrome/Chromium specific variables, added after it was forked. Because
of this, it is necessary to remove the Chrome/Chromium identification
in the user agent. Also, from now on, by default, The GTK+ port will
claim to be Safari in OS X to avoid loading wrong resources.

platform/gtk/UserAgentGtk.cpp:

(WebCore::standardUserAgent):

1:08 AM Changeset in webkit [159915] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

HTML5 required attribute validation messages implemented.
https://bugs.webkit.org/show_bug.cgi?id=125003

Patch by Attila Dusnoki <adusnoki@inf.u-szeged.hu> on 2013-12-02
Reviewed by Gyuyoung Kim.

platform/efl/LocalizedStringsEfl.cpp:

(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageValueMissingForCheckboxText):
(WebCore::validationMessageValueMissingForFileText):
(WebCore::validationMessageValueMissingForMultipleFileText):
(WebCore::validationMessageValueMissingForRadioText):
(WebCore::validationMessageValueMissingForSelectText):
(WebCore::validationMessageBadInputForNumberText):

12:59 AM Changeset in webkit [159914] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore

Merge r158687 - Fix register allocation inside control flow in GetByVal String
https://bugs.webkit.org/show_bug.cgi?id=123816

Reviewed by Geoffrey Garen.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

12:58 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

12:56 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

12:26 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

Dec 1, 2013:

11:48 PM Changeset in webkit [159913] by ChangSeok Oh

5 edits in trunk/Source/WebKit2

Unreviewed Gtk port Build fix after r159903

UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::layerHostingModeDidChange):
(WebKit::DrawingAreaProxyImpl::update):
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidUpdateBackingStoreState):

UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:

(WebKit::WebFullScreenManagerProxy::invalidate):

UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::setAcceleratedCompositingWindowId):

9:44 PM Changeset in webkit [159912] by akling@apple.com

3 edits in trunk/Source/WebCore

SVG: Intersection/enclosure checks should use RenderElement.
<https://webkit.org/b/125058>

Make RenderSVGModelObject's checkIntersection() and checkEnclosure()
take RenderElement* instead of RenderObject*. They are only ever
called with SVGElement's renderers.

Reviewed by Sam Weinig.

9:43 PM Changeset in webkit [159911] by akling@apple.com

2 edits in trunk/Source/WebCore

Remove unreachable labels for -webkit-margin-*-collapse properties.
<https://webkit.org/b/125057>

The following properties are implemented in DeprecatedStyleBuilder
and should not have case labels in the applyProperty() switch:

-webkit-margin-before-collapse
-webkit-margin-top-collapse
-webkit-margin-after-collapse
-webkit-margin-bottom-collapse

This seems counter-intuitive, but they are actually *not* like other
directional properties. In this case, before/after are only aliases
for top/bottom, and do not depend on writing-mode or text-direction.
See also r68561, where the aliases were originally added.

Reviewed by Anders Carlsson.

9:41 PM Changeset in webkit [159910] by akling@apple.com

2 edits in trunk/Source/WebCore

CSSFunctionValue constructors should return PassRef.
<https://webkit.org/b/125054>

Make CSSFunctionValue::create() helpers return PassRef instead of
PassRefPtr since they will never return null.

Reviewed by Anders Carlsson.

7:36 PM Changeset in webkit [159909] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Unreviewed, rolling out r159764.
http://trac.webkit.org/changeset/159764
https://bugs.webkit.org/show_bug.cgi?id=125055

appears to hurt html5-full-render times (Requested by kling on
#webkit).

html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertTextNode):

html/parser/HTMLConstructionSite.h:

7:36 PM Changeset in webkit [159908] by weinig@apple.com

9 edits in trunk/Source/WebKit2

Give UserMessageEncoders WebProcessProxy reference (like the decoders already have)
https://bugs.webkit.org/show_bug.cgi?id=125053

Reviewed by Dan Bernstein.

Give the UserMessageEncoders a process reference.
Switch UserMessageDecoders to storing a process reference, rather than pointer.

Shared/UserMessageCoders.h:
Shared/mac/ObjCObjectGraphCoders.h:
Shared/mac/ObjCObjectGraphCoders.mm:
UIProcess/WebConnectionToWebProcess.cpp:
UIProcess/WebContext.cpp:
UIProcess/WebContextUserMessageCoders.h:
UIProcess/WebPageProxy.cpp:
WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

6:47 PM Changeset in webkit [159907] by akling@apple.com

2 edits in trunk/Source/WebCore

Make more computed style helpers return PassRef.
<https://webkit.org/b/125043>

Reduce branchiness in computed style code by making more of the
file-local helpers return PassRef instead of PassRefPtr.

Reviewed by Anders Carlsson.

5:53 PM Changeset in webkit [159906] by weinig@apple.com

2 edits in trunk/Source/WebKit2

[Cocoa] The PageLoadState::Observer is not being set on iOS
https://bugs.webkit.org/show_bug.cgi?id=125051

Reviewed by Dan Bernstein.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::platformInitialize):
Add missing call to _finishInitialization.

5:16 PM Changeset in webkit [159905] by ryuan.choi@samsung.com

9 edits in trunk/Source/WebKit2

Unreviewed EFL Build fix attempt after r159903

UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::layerHostingModeDidChange):
(WebKit::CoordinatedDrawingAreaProxy::update):
(WebKit::CoordinatedDrawingAreaProxy::didUpdateBackingStoreState):
(WebKit::CoordinatedDrawingAreaProxy::sendUpdateBackingStoreState):
(WebKit::CoordinatedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState):

UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::~CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHostProxy::renderNextFrame):
(WebKit::CoordinatedLayerTreeHostProxy::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHostProxy::commitScrollOffset):

UIProcess/WebTextChecker.cpp:

(WebKit::WebTextChecker::checkSpelling):
(WebKit::WebTextChecker::changeSpellingToWord):

UIProcess/WebTextChecker.h:
UIProcess/WebVibrationProxy.cpp:

(WebKit::WebVibrationProxy::WebVibrationProxy):
(WebKit::WebVibrationProxy::~WebVibrationProxy):

UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:

(WebKit::WebFullScreenManagerProxy::invalidate):

UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::setThemePath):
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::cancelComposition):

5:04 PM Changeset in webkit [159904] by weinig@apple.com

4 edits in trunk/Source/WebKit2

Fix the iOS build.

UIProcess/API/ios/WKContentView.mm:
UIProcess/API/ios/WKInteractionView.mm:
UIProcess/ios/WebPageProxyIOS.mm:

4:50 PM Changeset in webkit [159903] by weinig@apple.com

33 edits in trunk/Source/WebKit2

[CTTE] The WebPageProxy's WebProcessProxy is never null so it should be stored in a Ref
https://bugs.webkit.org/show_bug.cgi?id=125047

Reviewed by Dan Bernstein.

UIProcess/API/C/WKPage.cpp:
UIProcess/API/C/mac/WKPagePrivateMac.cpp:
UIProcess/API/Cocoa/WKBrowsingContextController.mm:
UIProcess/API/mac/WKView.mm:
UIProcess/Downloads/DownloadProxy.cpp:
UIProcess/Downloads/DownloadProxy.h:
UIProcess/Downloads/DownloadProxyMap.cpp:
UIProcess/Downloads/DownloadProxyMap.h:
UIProcess/DrawingAreaProxy.cpp:
UIProcess/GeolocationPermissionRequestManagerProxy.cpp:
UIProcess/Network/NetworkProcessProxy.cpp:
UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:
UIProcess/Notifications/WebNotificationManagerProxy.cpp:
UIProcess/WebContext.cpp:
UIProcess/WebContext.h:
UIProcess/WebEditCommandProxy.cpp:
UIProcess/WebFrameProxy.cpp:
UIProcess/WebFullScreenManagerProxy.cpp:
UIProcess/WebInspectorProxy.cpp:
UIProcess/WebPageGroup.h:
UIProcess/WebPageProxy.cpp:
UIProcess/WebPageProxy.h:
UIProcess/WebProcessProxy.cpp:
UIProcess/WebProcessProxy.h:
UIProcess/cf/WebPageProxyCF.cpp:
UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
UIProcess/mac/RemoteLayerTreeHost.mm:
UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
UIProcess/mac/WebFullScreenManagerProxyMac.mm:
UIProcess/mac/WebInspectorProxyMac.mm:
UIProcess/mac/WebPageProxyMac.mm:

4:50 PM Changeset in webkit [159902] by mitz@apple.com

4 edits in trunk/Tools

[Mac] Transition MiniBrowser to the Cocoa API: policy delegate
https://bugs.webkit.org/show_bug.cgi?id=125046

Reviewed by Sam Weinig.

MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
(-[BrowserAppDelegate openDocument:]): Ditto.

MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the

interface to the implementation.

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
the policy client.
(-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
Moved policy client implementation into this delegate method.
(-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
Ditto.
(-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
Ditto.

3:40 PM Changeset in webkit [159901] by ryuan.choi@samsung.com

3 edits in trunk/Source/WebKit2

[EFL][CoordinatedGraphics] Clear m_contentsSize when new contents are loaded
https://bugs.webkit.org/show_bug.cgi?id=125033

Reviewed by Gyuyoung Kim.

m_contentsSize should be cleared when new contents are loaded so that PageViewportController
would take care of newly loaded contents with same size as previous one.
It's because PageViewportController is cleared not to make wrong behaviour
while loading when new contents are committed.

UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):
Improve tests to check contents,size,changed signal when loaded contents having
same size with previous one.

UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::didCommitLoadForMainFrame): Cleared m_contentsSize.

11:14 AM WebInspectorCodingStyleGuide edited by Brian Burg

Fix tt styles, add links to mechanization tracking bug, repository … (diff)

11:00 AM WebInspectorCodingStyleGuide edited by Brian Burg

Add protected (diff)

10:46 AM WikiStart edited by Brian Burg

Move and relabel Web Inspector links; add inspector style guide (diff)

9:03 AM Changeset in webkit [159900] by mitz@apple.com

3 edits
2 deletes in trunk/Tools

[Mac] Remove the MiniBrowser injected bundle
https://bugs.webkit.org/show_bug.cgi?id=125041

Reviewed by Anders Carlsson.

It had no ops!

MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):

MiniBrowser/mac/WebBundle/Info.plist: Removed.
MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.

5:45 AM Changeset in webkit [159899] by Philippe Normand

4 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r159896.

UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextCreatePageForWebView):

UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed):

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseUpdatePreferences):

12:07 AM Changeset in webkit [159898] by ryuan.choi@samsung.com

4 edits in trunk/Source/WebKit2

Unreviewed build fix after r159896.

UIProcess/API/efl/ewk_settings.cpp:

(EwkSettings::preferences):

UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::CoordinatedDrawingAreaProxy):

UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):

Nov 30, 2013:

11:05 PM Changeset in webkit [159897] by ryuan.choi@samsung.com

4 edits in trunk/Source/WebCore

[EFL] Implement scrollbarThickness for opaque scrollbar
https://bugs.webkit.org/show_bug.cgi?id=125034

Reviewed by Gyuyoung Kim.

Implemented scrollbarThickness to support opaque scrollbar.
Now, edj can decide whether to support opaque scrollbar by adding scrollbar.thickness.
In addition, added OVERRIDE/FINAL keyword and removed unnecessary destructor
in ScrollbarThemeEfl.cpp.

No new tests, no behavior changes with default theme.

platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::loadTheme):
Update thickness of scrollbar when theme was loaded.

platform/efl/ScrollbarThemeEfl.cpp:
platform/efl/ScrollbarThemeEfl.h:

(WebCore::ScrollbarThemeEfl::setScrollbarThickness):
(WebCore::ScrollbarThemeEfl::scrollbarThickness):
(WebCore::ScrollbarThemeEfl::registerScrollbar):
(WebCore::ScrollbarThemeEfl::unregisterScrollbar):

10:40 PM Changeset in webkit [159896] by weinig@apple.com

17 edits in trunk/Source/WebKit2

[CTTE] The WebPageProxy's WebPageGroup is never null so it should be stored in a Ref
https://bugs.webkit.org/show_bug.cgi?id=125038

Reviewed by Dan Bernstein.

UIProcess/API/C/WKPage.cpp:

(WKPageGetPageGroup):

UIProcess/API/C/mac/WKPagePrivateMac.cpp:

(WKPageIsURLKnownHSTSHost):

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController browsingContextGroup]):

UIProcess/API/mac/WKView.mm:

(-[WKView _preferencesDidChange]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::createWebPage):

UIProcess/WebContext.h:
UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorPageGroups::inspectorLevel):
(WebKit::WebInspectorPageGroups::isInspectorPageGroup):
(WebKit::WebInspectorPageGroups::inspectorPageGroupLevel):
(WebKit::WebInspectorProxy::isInspectorPage):

UIProcess/WebInspectorProxy.h:
UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::createNonNull):

UIProcess/WebPageGroup.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
(WebKit::WebPageProxy::preferencesDidChange):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::pageGroup):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

UIProcess/WebProcessProxy.h:
UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::windowFrameDidChange):

UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::pageIsProcessSuppressible):

10:24 PM Changeset in webkit [159895] by mitz@apple.com

6 edits in trunk/Source/WebKit2

Added a version of +[NSURL _web_URLWithWTFString:relativeToURL:] that doesn’t take a base URL and switched all callers to it.
https://bugs.webkit.org/show_bug.cgi?id=125040

Reviewed by Sam Weinig.

Shared/Cocoa/WKNSURLExtras.h: Declared new method.
Shared/Cocoa/WKNSURLExtras.mm:

(urlWithWTFString): Added helper function.
(+[NSURL _web_URLWithWTFString:]): Added.
(+[NSURL _web_URLWithWTFString:relativeToURL:]): Changed to use helper function.

UIProcess/API/Cocoa/WKBackForwardListItem.mm:

(-[WKBackForwardListItem URL]): Changed to call new method.
(-[WKBackForwardListItem originalURL]): Ditto.

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController activeURL]): Ditto.
(-[WKBrowsingContextController provisionalURL]): Ditto.
(-[WKBrowsingContextController committedURL]): Ditto.
(-[WKBrowsingContextController unreachableURL]): Ditto.
(setUpPagePolicyClient): Ditto.

UIProcess/API/Cocoa/WKNavigationData.mm:

(-[WKNavigationData destinationURL]): Ditto.

10:02 PM Changeset in webkit [159894] by mitz@apple.com

4 edits in trunk/Source/WebKit2

[Cocoa] Stop using the WKPageRef API in WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=125036

Reviewed by Sam Weinig.

Shared/Cocoa/WKNSURLExtras.h: Declared new method.
Shared/Cocoa/WKNSURLExtras.mm:

(-[NSURL _web_originalDataAsWTFString]): Added. Returns a WTF::String with the receiver’s
bytes.

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadRequest:userData:]):
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]):
(-[WKBrowsingContextController loadHTMLString:baseURL:userData:]):
(-[WKBrowsingContextController loadAlternateHTMLString:baseURL:forUnreachableURL:]):
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
(-[WKBrowsingContextController stopLoading]):
(-[WKBrowsingContextController reload]):
(-[WKBrowsingContextController reloadFromOrigin]):
(-[WKBrowsingContextController goForward]):
(-[WKBrowsingContextController canGoForward]):
(-[WKBrowsingContextController goBack]):
(-[WKBrowsingContextController canGoBack]):
(-[WKBrowsingContextController activeURL]):
(-[WKBrowsingContextController provisionalURL]):
(-[WKBrowsingContextController committedURL]):
(-[WKBrowsingContextController title]):
(-[WKBrowsingContextController textZoom]):
(-[WKBrowsingContextController setTextZoom:]):
(-[WKBrowsingContextController pageZoom]):
(-[WKBrowsingContextController setPageZoom:]):
(setUpPageLoaderClient):
(setUpPagePolicyClient):
(-[WKBrowsingContextController setLoadDelegate:]):
(-[WKBrowsingContextController setPolicyDelegate:]):
(-[WKBrowsingContextController _pageRef]):
(-[WKBrowsingContextController setPaginationMode:]):
(-[WKBrowsingContextController paginationMode]):
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]):
(-[WKBrowsingContextController paginationBehavesLikeColumns]):
(-[WKBrowsingContextController setPageLength:]):
(-[WKBrowsingContextController pageLength]):
(-[WKBrowsingContextController setGapBetweenPages:]):
(-[WKBrowsingContextController gapBetweenPages]):
(-[WKBrowsingContextController pageCount]):

7:52 PM Changeset in webkit [159893] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r159865.
http://trac.webkit.org/changeset/159865
https://bugs.webkit.org/show_bug.cgi?id=125037

the position of mouse events are wrong at MiniBrowser/efl
(Requested by ryuan on #webkit).

UIProcess/API/efl/EwkView.cpp:

(EwkView::displayTimerFired):
(EwkView::createGLSurface):
(EwkView::handleEvasObjectCalculate):

7:33 PM Changeset in webkit [159892] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

[Win] Some JavaScript date tests are failing.
https://bugs.webkit.org/show_bug.cgi?id=124946

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-30
Reviewed by Brent Fulgham.

Use native Win32 api functions to compute Daylight saving time offset.

wtf/DateMath.cpp:

(WTF::UnixTimeToFileTime): Added method to calculate Win32 specific struct FILETIME from time_t value.
(WTF::calculateDSTOffset): Use native Win32 api functions to compute Daylight saving time offset.

6:25 PM Changeset in webkit [159891] by weinig@apple.com

7 edits in trunk/Source/WebKit2

[CTTE] The WebPageProxy's WebBackForwardList is never null so it should be stored in a Ref
https://bugs.webkit.org/show_bug.cgi?id=125035

Reviewed by Dan Bernstein.

UIProcess/API/C/WKPage.cpp:

(WKPageGetBackForwardList):

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController backForwardList]): Remove null check.

UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::currentItem): Constify.
(WebKit::WebBackForwardList::backItem): Constify.
(WebKit::WebBackForwardList::forwardItem): Constify.
(WebKit::WebBackForwardList::itemAtIndex): Constify.

UIProcess/WebBackForwardList.h:

(WebKit::WebBackForwardList::create):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::backForwardList):

12:15 PM Changeset in webkit [159890] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r159889.

UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::viewWidget): Adjust the static cast of the PageClient reference to PageClientImpl.

11:14 AM Changeset in webkit [159889] by weinig@apple.com

15 edits in trunk/Source/WebKit2

[CTTE] WebPageProxy should store the PageClient as a reference
https://bugs.webkit.org/show_bug.cgi?id=125030

Reviewed by Dan Bernstein.

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreateWebPage):

UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

UIProcess/CoordinatedGraphics/WebPageProxyCoordinatedGraphics.cpp:

(WebKit::WebPageProxy::didFindZoomableArea):

UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):

UIProcess/WebContext.cpp:

(WebKit::WebContext::createWebPage):

UIProcess/WebContext.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::setViewNeedsDisplay):
(WebKit::WebPageProxy::displayView):
(WebKit::WebPageProxy::canScrollView):
(WebKit::WebPageProxy::scrollView):
(WebKit::WebPageProxy::updateViewState):
(WebKit::WebPageProxy::viewStateDidChange):
(WebKit::WebPageProxy::viewSize):
(WebKit::WebPageProxy::startDrag):
(WebKit::WebPageProxy::handleTouchEvent):
(WebKit::WebPageProxy::preferencesDidChange):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::closePage):
(WebKit::WebPageProxy::setWindowFrame):
(WebKit::WebPageProxy::getWindowFrame):
(WebKit::WebPageProxy::screenToWindow):
(WebKit::WebPageProxy::windowToScreen):
(WebKit::WebPageProxy::pageDidRequestScroll):
(WebKit::WebPageProxy::pageTransitionViewportReady):
(WebKit::WebPageProxy::didRenderFrame):
(WebKit::WebPageProxy::didChangeViewportProperties):
(WebKit::WebPageProxy::handleDownloadRequest):
(WebKit::WebPageProxy::didChangeContentSize):
(WebKit::WebPageProxy::showColorPicker):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::canUndoRedo):
(WebKit::WebPageProxy::executeUndoRedo):
(WebKit::WebPageProxy::clearAllEditCommands):
(WebKit::WebPageProxy::setFindIndicator):
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::internalShowContextMenu):
(WebKit::WebPageProxy::registerEditCommand):
(WebKit::WebPageProxy::setToolTip):
(WebKit::WebPageProxy::setCursor):
(WebKit::WebPageProxy::setCursorHiddenUntilMouseMoves):
(WebKit::WebPageProxy::didReceiveEvent):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
(WebKit::WebPageProxy::initializeCreationParameters):
(WebKit::WebPageProxy::enterAcceleratedCompositingMode):
(WebKit::WebPageProxy::exitAcceleratedCompositingMode):
(WebKit::WebPageProxy::updateAcceleratedCompositingMode):
(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):
(WebKit::WebPageProxy::recommendedScrollbarStyleDidChange):
(WebKit::WebPageProxy::updateBackingStoreDiscardableState):
(WebKit::WebPageProxy::showCorrectionPanel):
(WebKit::WebPageProxy::dismissCorrectionPanel):
(WebKit::WebPageProxy::dismissCorrectionPanelSoon):
(WebKit::WebPageProxy::recordAutocorrectionResponse):
(WebKit::WebPageProxy::showDictationAlternativeUI):
(WebKit::WebPageProxy::removeDictationAlternatives):
(WebKit::WebPageProxy::dictationAlternatives):

UIProcess/WebPageProxy.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

UIProcess/WebProcessProxy.h:
UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::getEditorCommandsForKeyEvent):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::interpretKeyEvent):
(WebKit::WebPageProxy::mainDocumentDidReceiveMobileDocType):
(WebKit::WebPageProxy::didGetTapHighlightGeometries):
(WebKit::WebPageProxy::didChangeViewportArguments):
(WebKit::WebPageProxy::startAssistingNode):
(WebKit::WebPageProxy::stopAssistingNode):
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::insertDictatedText):
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::setPromisedData):
(WebKit::WebPageProxy::interpretQueuedKeyEvent):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::makeFirstResponder):
(WebKit::WebPageProxy::colorSpace):
(WebKit::WebPageProxy::pluginFocusOrWindowFocusChanged):
(WebKit::WebPageProxy::setPluginComplexTextInputState):
(WebKit::WebPageProxy::executeSavedCommandBySelector):
(WebKit::WebPageProxy::wkView):
(WebKit::WebPageProxy::intrinsicContentSizeDidChange):
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):

10:55 AM Changeset in webkit [159888] by weinig@apple.com

6 edits in trunk/Source/WebKit2

[RTTE] The PermissionRequestManagerProxies should use WebPageProxy references.
https://bugs.webkit.org/show_bug.cgi?id=125029

Reviewed by Dan Bernstein.

UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::GeolocationPermissionRequestManagerProxy):
(WebKit::GeolocationPermissionRequestManagerProxy::invalidateRequests):
(WebKit::GeolocationPermissionRequestManagerProxy::didReceiveGeolocationPermissionDecision):

UIProcess/GeolocationPermissionRequestManagerProxy.h:
UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:

(WebKit::NotificationPermissionRequestManagerProxy::NotificationPermissionRequestManagerProxy):
(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests):
(WebKit::NotificationPermissionRequestManagerProxy::didReceiveNotificationPermissionDecision):

UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
Do some additional modernization while we are here.

10:49 AM Changeset in webkit [159887] by mitz@apple.com

2 edits in trunk/Source/WebKit2

<rdar://problem/15560240> ResourceError encoding drops NSURL-valued keys in the NSError’s userInfo, including NSErrorFailingURLKey
https://bugs.webkit.org/show_bug.cgi?id=125016

Reviewed by Anders “happy name day” Carlsson.

Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData): Encode all string- and URL-valued keys as a dictionary.
(CoreIPC::::decodePlatformData): Decode user info as a dictionary.

9:23 AM Changeset in webkit [159886] by fpizlo@apple.com

28 edits in trunk/Source/JavaScriptCore

Finally remove those DFG_ENABLE things
https://bugs.webkit.org/show_bug.cgi?id=125025

Rubber stamped by Sam Weinig.

This removes a bunch of unused and untested insanity.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::tallyFrequentExitSites):

dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
(JSC::DFG::ByteCodeParser::getArrayModeConsideringSlowPath):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::parse):

dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::convertToJump):
(JSC::DFG::CFGSimplificationPhase::fixJettisonedPredecessors):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGCommon.h:

(JSC::DFG::verboseCompilationEnabled):
(JSC::DFG::logCompilationChanges):
(JSC::DFG::shouldDumpGraphAtEachPhase):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):

dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::initialize):
(JSC::DFG::InPlaceAbstractState::endBasicBlock):
(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):
(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

dfg/DFGOSRExitCompiler.cpp:
dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::adjustAndJumpToTarget):

dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::run):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::propagateForward):
(JSC::DFG::PredictionPropagationPhase::propagateBackward):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):

dfg/DFGSlowPathGenerator.h:

(JSC::DFG::SlowPathGenerator::generate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

dfg/DFGVariableEventStream.h:

(JSC::DFG::VariableEventStream::appendAndLog):

dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

jit/JIT.cpp:

(JSC::JIT::privateCompile):

9:05 AM Changeset in webkit [159885] by mrowe@apple.com

3 edits in trunk/Websites/webkit.org

<https://webkit.org/b/125027> Update the analytics account used by webkit.org

Switch to a Google Analytics id that's accessible to someone that's involved with the WebKit project.

Reviewed by Sam Weinig.

footer.inc: Remove the old analytics code.
header.inc: Add the new stuff.

Nov 29, 2013:

11:41 PM Changeset in webkit [159884] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit2

Unreviewed build fix for EFL and GTK WK2 builds.

Scripts/generate-forwarding-headers.pl: Add Cocoa to the list of platform prefixes.

8:17 PM Changeset in webkit [159883] by fpizlo@apple.com

6 edits in trunk/Source/JavaScriptCore

FTL IC should nop-fill to make up the difference between the actual IC size and the requested patchpoint size
https://bugs.webkit.org/show_bug.cgi?id=124960

Reviewed by Sam Weinig.

assembler/LinkBuffer.h:

(JSC::LinkBuffer::size):

assembler/X86Assembler.h:

(JSC::X86Assembler::fillNops):

dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dumpHeader):

ftl/FTLCompile.cpp:

(JSC::FTL::generateICFastPath):

jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dumpHeader):

8:13 PM Changeset in webkit [159882] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit2

Fix build warnings in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=125012

Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-11-29
Reviewed by Anders Carlsson.

fix unused parameter warnings in the following files:

Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::SocketEventSource::eventCallback):

Shared/API/c/WKDeprecatedFunctions.cpp:

(WKArrayIsMutable):

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::unavailablePluginButtonClicked):
(WebKit::WebChromeClient::didAddHeaderLayer):
(WebKit::WebChromeClient::didAddFooterLayer):

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createJavaAppletWidget):

6:04 PM Changeset in webkit [159881] by weinig@apple.com

10 edits in trunk/Source/WebKit2

[Cocoa] Add a little template magic to the inline API::Object storage to remove the need for all the reinterpret_casts
https://bugs.webkit.org/show_bug.cgi?id=125024

Reviewed by Dan Bernstein.

Introduce API::ObjectStorage which wraps std::aligned_storage and adds some convenience functions
to reinterpret the data as the corresponding type. Deploy it everywhere we were previously using
std::aligned_storage.

Shared/Cocoa/WKNSArray.mm:
Shared/Cocoa/WKNSDictionary.mm:
Shared/Cocoa/WKObject.h:
UIProcess/API/Cocoa/WKBackForwardList.mm:
UIProcess/API/Cocoa/WKBackForwardListItem.mm:
UIProcess/API/Cocoa/WKBrowsingContextController.mm:
UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:
UIProcess/API/Cocoa/WKNavigationData.mm:
UIProcess/API/Cocoa/WKProcessGroup.mm:

5:46 PM Changeset in webkit [159880] by weinig@apple.com

2 edits in trunk/Source/WebKit2

Fix crashing API tests.

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController dealloc]):

4:56 PM Changeset in webkit [159879] by weinig@apple.com

2 edits in trunk/Source/WebKit2

Fix some style boo-boos.

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadDelegate]):
(-[WKBrowsingContextController setLoadDelegate:]):
(-[WKBrowsingContextController policyDelegate]):
(-[WKBrowsingContextController setPolicyDelegate:]):

4:53 PM Changeset in webkit [159878] by weinig@apple.com

2 edits in trunk/Source/WebKit2

Fix the iOS build.

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadDelegate]):
(-[WKBrowsingContextController policyDelegate]):
(-[WKBrowsingContextController setPolicyDelegate:]):

4:27 PM Changeset in webkit [159877] by weinig@apple.com

9 edits in trunk/Source/WebKit2

[Cocoa] Make WKBrowsingContextController work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=125022

Reviewed by Dan Bernstein.

Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

Shared/mac/ObjCObjectGraphCoders.mm:

Add support for WKProcessGroup.

(WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
Replace call to _browsingContextControllerForPageRef: with wrapper.

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline.

(-[WKBrowsingContextController dealloc]):
Add explicit destructor call.

(-[WKBrowsingContextController setLoadDelegate:]):
(-[WKBrowsingContextController setPolicyDelegate:]):
Lazily set up the load and policy clients only once a delegate has been set to allow
continued use of the C-SPI clients for WebKitTestRunner.

(-[WKBrowsingContextController _finishInitialization]):
Move remaining work that was done in the initialize (setting up the observer) here,
and have the WebPageProxy call it.

UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h:

(WebKit::wrapper):
Add wrapper() helper and declare conformance to the WKObject protocol. Remove no longer used
_initWithPageRef: and _browsingContextControllerForPageRef: helpers.

UIProcess/API/Cocoa/WKProcessGroup.mm:

(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):
Switch to using wrapper().

UIProcess/API/ios/WKContentView.mm:
UIProcess/API/mac/WKView.mm:

Stop caching the WKBrowsingContextController, as it no long makes sense since it is the same object
as the WebPageProxy.

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::platformInitialize):
Inform the wrapper that it is safe to finish initialization.

3:21 PM Changeset in webkit [159876] by mitz@apple.com

8 edits
2 adds in trunk/Source/WebKit2

[Cocoa] Add a way to recover from load errors
https://bugs.webkit.org/show_bug.cgi?id=125020

Reviewed by Sam Weinig.

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(createErrorWithRecoveryAttempter): Added this helper function. It creates an NSError from
the given error, adding two keys to the user info dictionary: the context controller under
the recovery attempter key, and the frame under a private key.
(didFailProvisionalLoadWithErrorForFrame): Changed to use createErrorWithRecoveryAttempter.
(didFailLoadWithErrorForFrame): Ditto.
(-[WKBrowsingContextController attemptRecoveryFromError:]): Implemented this
WKErrorRecoveryAttempting protocol method by loading the failing URL from the error into the
frame from the error.

UIProcess/API/Cocoa/WKErrorRecoveryAttempting.h: Added. Defines a protocol for attempting

recovery from errors and declares the error user info dictionary key under which an object
conforming to this protocol may be stored.

UIProcess/API/Cocoa/WKErrorRecoveryAttempting.m: Added. Defines

WKRecoveryAttempterErrorKey.

UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::loadURL): Added. Sends the LoadURLInFrame message to the page.

UIProcess/WebFrameProxy.h:

WebKit2.xcodeproj/project.pbxproj: Added references to new files.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURLInFrame): Added. Loads the URL in the given frame.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in: Added LoadURLInFrame.

1:15 PM Changeset in webkit [159875] by mitz@apple.com

3 edits in trunk/Source/WebKit2

[Cocoa] Expose loadAlternateHTMLString via the API
https://bugs.webkit.org/show_bug.cgi?id=125019

Reviewed by Sam Weinig.

UIProcess/API/Cocoa/WKBrowsingContextController.h: Declared new method.
UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadAlternateHTMLString:baseURL:forUnreachableURL:]): Added.
Calls WebPageProxy::loadAlternateHTMLString.

12:54 PM Changeset in webkit [159874] by weinig@apple.com

2 edits
22 moves in trunk/Source/WebKit2

Move API files shared between Mac and iOS to the Cocoa directory
https://bugs.webkit.org/show_bug.cgi?id=125017

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/WKBrowsingContextController.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h.
UIProcess/API/Cocoa/WKBrowsingContextController.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm.
UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerPrivate.h.
UIProcess/API/Cocoa/WKBrowsingContextGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.h.
UIProcess/API/Cocoa/WKBrowsingContextGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm.
UIProcess/API/Cocoa/WKBrowsingContextGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupInternal.h.
UIProcess/API/Cocoa/WKBrowsingContextGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupPrivate.h.
UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextLoadDelegate.h.
UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h.
UIProcess/API/Cocoa/WKConnection.h: Copied from Source/WebKit2/UIProcess/API/mac/WKConnection.h.
UIProcess/API/Cocoa/WKConnection.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKConnection.mm.
UIProcess/API/Cocoa/WKConnectionInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKConnectionInternal.h.
UIProcess/API/Cocoa/WKProcessGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroup.h.
UIProcess/API/Cocoa/WKProcessGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm.
UIProcess/API/Cocoa/WKProcessGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h.
UIProcess/API/Cocoa/WKProcessGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupPrivate.h.
UIProcess/API/Cocoa/WKTypeRefWrapper.h: Copied from Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.h.
UIProcess/API/Cocoa/WKTypeRefWrapper.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.mm.
UIProcess/API/Cocoa/WKView.h: Copied from Source/WebKit2/UIProcess/API/mac/WKView.h.
UIProcess/API/Cocoa/WKViewPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h.
UIProcess/API/Cocoa/WebKit2.h: Copied from Source/WebKit2/UIProcess/API/mac/WebKit2.h.
UIProcess/API/mac/WKBrowsingContextController.h: Removed.
UIProcess/API/mac/WKBrowsingContextController.mm: Removed.
UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Removed.
UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Removed.
UIProcess/API/mac/WKBrowsingContextGroup.h: Removed.
UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed.
UIProcess/API/mac/WKBrowsingContextGroupInternal.h: Removed.
UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Removed.
UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Removed.
UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Removed.
UIProcess/API/mac/WKConnection.h: Removed.
UIProcess/API/mac/WKConnection.mm: Removed.
UIProcess/API/mac/WKConnectionInternal.h: Removed.
UIProcess/API/mac/WKProcessGroup.h: Removed.
UIProcess/API/mac/WKProcessGroup.mm: Removed.
UIProcess/API/mac/WKProcessGroupInternal.h: Removed.
UIProcess/API/mac/WKProcessGroupPrivate.h: Removed.
UIProcess/API/mac/WKTypeRefWrapper.h: Removed.
UIProcess/API/mac/WKTypeRefWrapper.mm: Removed.
UIProcess/API/mac/WKView.h: Removed.
UIProcess/API/mac/WKViewPrivate.h: Removed.
UIProcess/API/mac/WebKit2.h: Removed.
WebKit2.xcodeproj/project.pbxproj:

10:50 AM Moving to Git edited by kallisti5@unixzen.com

(diff)

9:25 AM Changeset in webkit [159873] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports.
https://bugs.webkit.org/show_bug.cgi?id=124936

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-29
Reviewed by Zoltan Herczeg.

The moveDoubleToInts implementations in ARM, MIPS and SH4 macro assemblers do not clobber
src FPRegister and are likely to be more efficient than the current generic implementation
using the stack.

jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::returnDouble):

6:32 AM Changeset in webkit [159872] by commit-queue@webkit.org

3 edits in trunk/Tools

check-webkit-style should check for extraneous newline between config.h and primary header.
https://bugs.webkit.org/show_bug.cgi?id=124821

Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-11-29
Reviewed by Csaba Osztrogonác.

Scripts/webkitpy/style/checkers/cpp.py:

(check_include_line):

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(OrderOfIncludesTest.test_check_line_break_after_own_header):
(OrderOfIncludesTest):
(OrderOfIncludesTest.test_check_line_break_before_own_header):

6:16 AM Changeset in webkit [159871] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

Merge arm and sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions.
https://bugs.webkit.org/show_bug.cgi?id=124892

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-29
Reviewed by Zoltan Herczeg.

assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::call): Pick a scratch register instead of getting it as a
parameter. The sh4 port was the only one to have this call(Address, RegisterID) prototype.

jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall): Use argumentGPRx and merge arm and sh4 paths.

jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator): Use argumentGPRx and merge arm and sh4 paths.

4:23 AM Changeset in webkit [159870] by Michał Pakuła vel Rutka

3 edits in trunk/LayoutTests

Unreviewed EFL gardening

Accessibility rebaselines after r159848.

platform/efl-wk1/accessibility/table-detection-expected.txt:
platform/efl-wk2/accessibility/table-detection-expected.txt:

4:06 AM Changeset in webkit [159869] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove Symbian specific code.
https://bugs.webkit.org/show_bug.cgi?id=124939

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-11-29
Reviewed by Zoltan Herczeg.

Symbian is not supported, remove leftover code.

plugins/npapi.h:

3:41 AM Changeset in webkit [159868] by Csaba Osztrogonác

2 edits in trunk/Tools

test-webkit-scripts should show the failing tests and use an appropriate exit code
https://bugs.webkit.org/show_bug.cgi?id=124840

Patch by Jozsef Berta <jberta@inf.u-szeged.hu> on 2013-11-29
Reviewed by Ryosuke Niwa.

A fixme in test-webkit-scripts asked that the script should display success or failiure
and exit with a 0 or 1 value accordingly after all of the tests have completed.

Scripts/test-webkit-scripts:

(ScriptsTester.run_test_script):
The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
because at this point we don't need to pass on more information other than success or failiure.
(ScriptsTester.main):
The return values are now stored for each script and when all tests have completed successfully,
the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.

3:38 AM Changeset in webkit [159867] by commit-queue@webkit.org

4 edits
2 moves in trunk

[ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
https://bugs.webkit.org/show_bug.cgi?id=124923

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-29
Reviewed by Mario Sanchez Prada.

Tools:

Added missing implementation of isAttributeSettable. Using
ATK_STATE_EDITABLE for checking whether attribute is settable.

DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isAttributeSettable):

WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isAttributeSettable):

LayoutTests:

Test could be reused by EFL and GTK as well.

accessibility/content-editable-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/content-editable-expected.txt.
accessibility/content-editable.html: Renamed from LayoutTests/platform/mac/accessibility/content-editable.html.

3:26 AM WebKitGTK/2.2.x edited by vjaquez@igalia.com

changeset 159572 is controversial (diff)

2:51 AM Changeset in webkit [159866] by commit-queue@webkit.org

3 edits in trunk

[cmake] Fix cmake warning: Argument not separated from preceding token by whitespace
https://bugs.webkit.org/show_bug.cgi?id=124899

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-29
Reviewed by Gyuyoung Kim.

Source/cmake/FindCairo.cmake:
Source/cmake/FindGStreamer.cmake:

12:37 AM Changeset in webkit [159865] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL] viewport must be same with the size of webview
https://bugs.webkit.org/show_bug.cgi?id=124965

Patch by Hunseop Jeong <Hunseop Jeong> on 2013-11-29
Reviewed by Gyuyoung Kim.

Currently, size of the viewport is larger than size of webview.
Changed the size of viewport with size of webview, because viewport is translated by wrong calculation.

UIProcess/API/efl/EwkView.cpp:

(EwkView::displayTimerFired): Changed to use the (0,0).
(EwkView::createGLSurface): Modified to use the viewSize instead of the boundsEnd.
(EwkView::handleEvasObjectCalculate): Removed the WKViewSetUserViewportTranslation.

Nov 28, 2013:

11:51 PM Changeset in webkit [159864] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[CoordinatedGraphics][WK2] Correct wrong usage of m_contentPosition variable in the WebView.
https://bugs.webkit.org/show_bug.cgi?id=118548

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-11-28
Reviewed by Noam Rosenthal.

CoordinatedGraphics uses its own scaling logic - contents scaling - and
WebView of CoordinatedGraphics maintains contents position by scaling
with contents scaling factor.
However transformToScene() and updateViewportSize() of WebView regard
the contents position as a non-scaled value, so it should be fixed.

UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::transformToScene):
(WebKit::WebView::updateViewportSize):

7:42 PM Changeset in webkit [159863] by ryuan.choi@samsung.com

5 edits in trunk/Source/WebKit2

[EFL] PageViewportController does not need to be unique_ptr instance
https://bugs.webkit.org/show_bug.cgi?id=124993

Reviewed by Gyuyoung Kim.

PageViewportController and PageViewportControllerEfl have same life cycle
with EwkView. So, we don't need to make them as unique_ptr instance.

UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::handleEvasObjectCalculate):
(EwkView::scrollBy):

UIProcess/API/efl/EwkView.h:

(EwkView::pageViewportController):

UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didCommitLoadForFrame):

UIProcess/efl/ViewClientEfl.cpp:

(WebKit::ViewClientEfl::didChangeContentsSize):
(WebKit::ViewClientEfl::didChangeContentsPosition):
(WebKit::ViewClientEfl::didRenderFrame):
(WebKit::ViewClientEfl::didCompletePageTransition):
(WebKit::ViewClientEfl::didChangeViewportAttributes):

5:35 PM Changeset in webkit [159862] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[GTK] Build fix after r159859
https://bugs.webkit.org/show_bug.cgi?id=124992

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-28
Reviewed by Gyuyoung Kim.

UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::didCommitLoadForMainFrame): Added.

UIProcess/API/gtk/PageClientImpl.h:

5:02 PM Changeset in webkit [159861] by jinwoo7.song@samsung.com

3 edits in trunk/Source/WebKit2

[EFL] Build fix after r159859
https://bugs.webkit.org/show_bug.cgi?id=124991

Reviewed by Gyuyoung Kim.

Redefined newly added pure virtual function in PageClient class after r159859.

UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::didCommitLoadForMainFrame):

UIProcess/CoordinatedGraphics/WebView.h:

3:25 PM Changeset in webkit [159860] by gyuyoung.kim@samsung.com

7 edits in trunk/Source/WebCore

Rename InlineIterator::m_obj and make it private
https://bugs.webkit.org/show_bug.cgi?id=124837

Reviewed by Antti Koivisto.

InlineIterator has been exported m_obj as public though there is a getter function.
Besides *object* name isn't ambigious. So, changed it with m_renderer and renderer().
Additionally, setRenderer() is added as well.

No new tests, no behavior changes.

rendering/InlineIterator.h:

(WebCore::InlineIterator::setObject):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::InlineBidiResolver::appendRun):

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::appendRunsForObject):
(WebCore::constructBidiRunsForLine):
(WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::matchedEndLine):

rendering/line/BreakingContextInlineHeaders.h:

(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):
(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::currentObject):
(WebCore::BreakingContext::initializeForCurrentObject):
(WebCore::BreakingContext::handleBR):
(WebCore::BreakingContext::handleOutOfFlowPositioned):
(WebCore::BreakingContext::handleFloat):
(WebCore::BreakingContext::handleEmptyInline):
(WebCore::BreakingContext::handleReplaced):
(WebCore::iteratorIsBeyondEndOfRenderCombineText):
(WebCore::ensureCharacterGetsLineBox):
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::canBreakAtThisPosition):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
(WebCore::checkMidpoints):
(WebCore::BreakingContext::handleEndOfLine):

rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::skipTrailingWhitespace):
(WebCore::LineBreaker::skipLeadingWhitespace):

rendering/line/LineInlineHeaders.h:

(WebCore::skipNonBreakingSpace):
(WebCore::requiresLineBox):

2:23 PM WebKitGTK/Debugging edited by Andres Gomez

(diff)

1:01 PM Changeset in webkit [159859] by weinig@apple.com

14 edits
1 add in trunk/Source/WebKit2

Perform some spring cleaning to WKContentView and WKView
https://bugs.webkit.org/show_bug.cgi?id=124961

Reviewed by Dan Bernstein.

Store the PageClientImpl in a std::unique_ptr.
Remove the WKBrowsingContextController internal load delegate. Replace its use with a new PageClient function, didCommitLoadForMainFrame.
Fix typo in the WKContentViewDelegate. contentViewdidCommitLoadForMainFrame -> contentViewDidCommitLoadForMainFrame.
Add initializers for WKContentView and WKView that take WKContextRefs and WKPageGroupRefs to match the Mac WKView. These are needed for WebKitTestRunner.
Require a WKProcessGroup (or WKContextRef) and a WKBrowsingContextGroup (or WKPageGroupRef).
Stop caching the WKProcessGroup and WKBrowsingContextGroup on the WKContentView.
Remove incorrect implementations of initWithCoder.
Make WKContentView lazily create its WKBrowsingContextController wrapper.

UIProcess/API/ios/PageClientImplIOS.h:
UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::mainDocumentDidReceiveMobileDocType):

UIProcess/API/ios/WKContentView.h:
UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithCoder:]):
(-[WKContentView initWithFrame:processGroup:browsingContextGroup:]):
(-[WKContentView browsingContextController]):
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
(-[WKContentView _didCommitLoadForMainFrame]):
(-[WKContentView _didReceiveMobileDocTypeForMainFrame]):
(-[WKContentView _didChangeViewportArguments:WebCore::]):
(-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]):
(-[WKContentView _pageRef]):
(-[WKContentView initWithFrame:contextRef:pageGroupRef:]):
(-[WKContentView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

UIProcess/API/ios/WKContentViewInternal.h:
UIProcess/API/ios/WKContentViewPrivate.h: Added.
UIProcess/API/ios/WKView.mm:

(-[WKView initWithFrame:processGroup:browsingContextGroup:]):
(-[WKView initWithFrame:processGroup:browsingContextGroup:relatedToView:]):
(-[WKView contentViewDidCommitLoadForMainFrame:]):
(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
(-[WKView pageRef]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

UIProcess/API/mac/PageClientImpl.h:
UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didCommitLoadForMainFrame):

UIProcess/API/mac/WKBrowsingContextController.mm:

(didCommitLoadForFrame):

UIProcess/API/mac/WKBrowsingContextControllerInternal.h:
UIProcess/API/mac/WKViewPrivate.h:
UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):

12:59 PM Changeset in webkit [159858] by Antti Koivisto

1 edit
2 deletes in trunk/LayoutTests

Remove an oddly named css variables test

Rubber-stamped by Andreas Kling.

css3/filters/reference-filter-update-after-remove-expected.txt: Removed.
css3/filters/reference-filter-update-after-remove.html: Removed.

12:55 PM Changeset in webkit [159857] by commit-queue@webkit.org

5 edits
1 add in trunk/Source/WTF

Nix Upstream: Updating Nix WTF files
https://bugs.webkit.org/show_bug.cgi?id=124980

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Just to sync our private repo files and the trunk, as part of the upstream process.

wtf/DisallowCType.h:
wtf/PlatformNix.cmake:
wtf/nix/FeatureDefinesNix.h:
wtf/nix/PlatformNix.h:
wtf/nix/RunLoopNix.cpp: Added.

12:53 PM Changeset in webkit [159856] by Antti Koivisto

158 edits
2 moves in trunk

Rename StylePropertySet to StyleProperties
https://bugs.webkit.org/show_bug.cgi?id=124990

Reviewed by Andreas Kling.

"Set" does not add useful information here. Use less clunky plural name.

12:33 PM Changeset in webkit [159855] by nrotem@apple.com

4 edits in trunk/Source/JavaScriptCore

Revert the X86 assembler peephole changes
https://bugs.webkit.org/show_bug.cgi?id=124988

Reviewed by Csaba Osztrogonác.

assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::add32):
(JSC::MacroAssemblerX86::add64):
(JSC::MacroAssemblerX86::or32):

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::branchAdd32):

assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::or32):
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::or64):
(JSC::MacroAssemblerX86_64::xor64):

11:43 AM Changeset in webkit [159854] by commit-queue@webkit.org

2 edits
2 adds in trunk/Source/WebCore

Nix Upstream: Adding EditorNix to WebCore
https://bugs.webkit.org/show_bug.cgi?id=124984

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Csaba Osztrogonác.

No new tests needed.

PlatformNix.cmake:
editing/nix/EditorNix.cpp: Added.

11:35 AM Changeset in webkit [159853] by Csaba Osztrogonác

274 edits
2 adds in trunk/LayoutTests

RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase EFL results (and the remaining Mac) after r159848.

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

fast/table/anonymous-table-section-removed.html: Updated.
platform/efl/accessibility/table-attributes-expected.txt: Added.
platform/efl/accessibility/table-sections-expected.txt: Added.
platform/efl/fast/forms/input-value-expected.png:
platform/efl/fast/forms/input-value-expected.txt:
platform/efl/fast/table/[...]:
platform/efl/tables/[...]:
platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
platform/mac-mountainlion/fast/forms/input-value-expected.txt:
platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt:

11:33 AM Changeset in webkit [159852] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Building EFL Webkit again with mediastream enabled
https://bugs.webkit.org/show_bug.cgi?id=124930

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Csaba Osztrogonác.

CMakeLists.txt:

11:03 AM Changeset in webkit [159851] by Csaba Osztrogonác

147 edits in trunk/LayoutTests

RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase GTK results after r159848.

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

platform/mac/accessibility/table-detection-expected.txt:
platform/mac/fast/forms/input-value-expected.txt:
platform/mac/fast/table/[...]:
platform/mac/tables/[...]:

10:54 AM Changeset in webkit [159850] by Csaba Osztrogonác

269 edits in trunk/LayoutTests

RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase GTK results after r159848.

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

platform/gtk/accessibility/table-detection-expected.txt:
platform/gtk/fast/forms/input-value-expected.png:
platform/gtk/fast/forms/input-value-expected.txt:
platform/gtk/fast/table/[...]:
platform/gtk/tables/[...]:

9:43 AM Changeset in webkit [159849] by zoltan@webkit.org

2 edits in trunk/Source/WebCore

[Win] Update vcxproj.filters, since LineInfo.h and LineLayoutState.h have been moved to rendering/line
https://bugs.webkit.org/show_bug.cgi?id=124959

Reviewed by Brent Fulgham.

Update WebCore.vcxproj.filters, since LineInfo.h (r155628) and LineLayoutState.h (158121) have been moved to rendering/line.

No new tests, no behavior change.

WebCore.vcxproj/WebCore.vcxproj.filters:

9:40 AM Changeset in webkit [159848] by Csaba Osztrogonác

4 edits in trunk

RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Source/WebCore:

Use border spacing at the end of all sections.

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

Skipped tests enabled.

TestExpectations:

8:55 AM Changeset in webkit [159847] by commit-queue@webkit.org

6 edits in trunk/Tools

Unreviewed, rolling out r159839.
http://trac.webkit.org/changeset/159839
https://bugs.webkit.org/show_bug.cgi?id=124974

run-webkit-tests doesn't generate pretty diff (Requested by
Ossy on #webkit).

Scripts/webkitpy/common/prettypatch.py:

(PrettyPatch.init):
(PrettyPatch.pretty_diff):

Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter.create_text_diff_and_write_result):

Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

Scripts/webkitpy/port/base.py:

(Port.init):
(Port.pretty_patch_available):
(Port.check_pretty_patch):
(Port.variable):
(Port.variable.pretty_patch_text):

Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_pretty_patch_os_error):
(PortTest.test_pretty_patch_script_error):

8:35 AM Changeset in webkit [159846] by Michał Pakuła vel Rutka

2 edits
2 adds in trunk/LayoutTests

Unreviewed EFL gardening

platform/efl/TestExpectations: Added test expectations for failing tests.
platform/efl/fast/forms/search/search-size-with-decorations-expected.png: Added.
platform/efl/fast/forms/search/search-size-with-decorations-expected.txt: Added.

8:20 AM Changeset in webkit [159845] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Buildfix after r159824 for GCC 4.6
https://bugs.webkit.org/show_bug.cgi?id=124968

Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Added explicit "friend class", because GCC 4.6 doesn't support extended friend declaration (c++11)

Shared/APIObject.h:

8:19 AM Changeset in webkit [159844] by Antti Koivisto

3 edits in trunk/LayoutTests

No need to skip css variables tests as they were removed.

platform/mac/TestExpectations:
platform/win/TestExpectations:

8:02 AM Changeset in webkit [159843] by Gustavo Noronha Silva

3 edits in trunk/Source/WebKit/gtk

REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
https://bugs.webkit.org/show_bug.cgi?id=124954

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-11-28
Reviewed by Carlos Garcia Campos.

tests/testwebview.c: new test to ensure setting and getting source mode work as intended.
webkit/webkitwebview.cpp:

(webkit_web_view_get_view_source_mode): actually return the value we query from WebCore.

7:46 AM Changeset in webkit [159842] by Antti Koivisto

60 edits
3 deletes in trunk

Remove feature: CSS variables
https://bugs.webkit.org/show_bug.cgi?id=114119

Reviewed by Andreas Kling.

Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Reviewed by Andreas Kling.

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Reviewed by Andreas Kling.

The feature is unmaintained and it is getting in the way of refactoring. Code quality is not up to
WebKit standards either.

Configurations/FeatureDefines.xcconfig:
GNUmakefile.list.am:
WebCore.xcodeproj/project.pbxproj:
css/CSSBasicShapes.cpp:
css/CSSBasicShapes.h:
css/CSSCalculationValue.cpp:

(WebCore::unitCategory):
(WebCore::hasDoubleValue):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::determineCategory):
(WebCore::CSSCalcBinaryOperation::primitiveType):

css/CSSCalculationValue.h:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSGrammar.y.in:
css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::validCalculationUnit):
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::realLex):

css/CSSParser.h:
css/CSSParserMode.h:
css/CSSParserValues.cpp:

(WebCore::CSSParserValue::createCSSValue):

css/CSSParserValues.h:
css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::customCSSText):
(WebCore::CSSPrimitiveValue::equals):

css/CSSPrimitiveValue.h:
css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertToLength):

css/CSSProperty.cpp:
css/CSSProperty.h:

(WebCore::CSSProperty::CSSProperty):

css/CSSReflectValue.cpp:
css/CSSReflectValue.h:
css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

css/CSSValue.h:

(WebCore::CSSValue::setCssText):

css/CSSValueList.cpp:
css/CSSValueList.h:
css/CSSVariableValue.h: Removed.
css/Pair.h:
css/Rect.h:
css/StylePropertySet.cpp:

(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::PropertyReference::cssName):

css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyProperty):

css/StyleResolver.h:
css/WebKitCSSTransformValue.cpp:
css/WebKitCSSTransformValue.h:

(WebCore::WebKitCSSTransformValue::equals):

css/makeprop.pl:
page/Settings.cpp:

(WebCore::Settings::Settings):

page/Settings.h:
rendering/style/RenderStyle.h:
rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

rendering/style/StyleRareInheritedData.h:
rendering/style/StyleVariableData.h: Removed.
testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

testing/InternalSettings.h:
testing/InternalSettings.idl:

Source/WebKit/mac:

Reviewed by Andreas Kling.

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Reviewed by Andreas Kling.

Configurations/FeatureDefines.xcconfig:

Source/WTF:

Reviewed by Andreas Kling.

wtf/FeatureDefines.h:

Tools:

Reviewed by Andreas Kling.

Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Reviewed by Andreas Kling.

fast/css/variables: Removed.
fast/css/variables/border-width-expected.html: Removed.
fast/css/variables/border-width.html: Removed.
fast/css/variables/build-supports-variables-expected.txt: Removed.
fast/css/variables/build-supports-variables.html: Removed.
fast/css/variables/calc-expected.html: Removed.
fast/css/variables/calc-inside-calc-expected.html: Removed.
fast/css/variables/calc-inside-calc.html: Removed.
fast/css/variables/calc-invalid-value-expected.html: Removed.
fast/css/variables/calc-invalid-value.html: Removed.
fast/css/variables/calc-invalid-variable-expected.html: Removed.
fast/css/variables/calc-invalid-variable.html: Removed.
fast/css/variables/calc-negated-variable-expected.html: Removed.
fast/css/variables/calc-negated-variable.html: Removed.
fast/css/variables/calc-vw-crash-expected.txt: Removed.
fast/css/variables/calc-vw-crash.html: Removed.
fast/css/variables/calc.html: Removed.
fast/css/variables/case-sensitive-expected.html: Removed.
fast/css/variables/case-sensitive.html: Removed.
fast/css/variables/colors-test-expected.html: Removed.
fast/css/variables/colors-test.html: Removed.
fast/css/variables/complex-cycle-expected.html: Removed.
fast/css/variables/complex-cycle.html: Removed.
fast/css/variables/computed-style-expected.html: Removed.
fast/css/variables/computed-style.html: Removed.
fast/css/variables/deferred-image-load-from-variable-expected.txt: Removed.
fast/css/variables/deferred-image-load-from-variable.html: Removed.
fast/css/variables/inherited-values-expected.html: Removed.
fast/css/variables/inherited-values.html: Removed.
fast/css/variables/inline-styles-expected.html: Removed.
fast/css/variables/inline-styles.html: Removed.
fast/css/variables/invalid-font-reference-expected.txt: Removed.
fast/css/variables/invalid-font-reference.html: Removed.
fast/css/variables/invalid-shorthand-expected.html: Removed.
fast/css/variables/invalid-shorthand.html: Removed.
fast/css/variables/invalid-value-list-crash-expected.txt: Removed.
fast/css/variables/invalid-value-list-crash.html: Removed.
fast/css/variables/invalid-variable-value-expected.html: Removed.
fast/css/variables/invalid-variable-value.html: Removed.
fast/css/variables/multi-level-cycle-expected.html: Removed.
fast/css/variables/multi-level-cycle.html: Removed.
fast/css/variables/redefinition-expected.html: Removed.
fast/css/variables/redefinition.html: Removed.
fast/css/variables/root-background-size-expected.html: Removed.
fast/css/variables/root-background-size.html: Removed.
fast/css/variables/shorthand-expected.html: Removed.
fast/css/variables/shorthand.html: Removed.
fast/css/variables/simple-cycle-expected.html: Removed.
fast/css/variables/simple-cycle.html: Removed.
fast/css/variables/transform-test-expected.html: Removed.
fast/css/variables/transform-test.html: Removed.
fast/css/variables/undefined-expected.html: Removed.
fast/css/variables/undefined.html: Removed.
fast/css/variables/use-before-defined-expected.html: Removed.
fast/css/variables/use-before-defined.html: Removed.
fast/css/variables/var-filter-expected.txt: Removed.
fast/css/variables/var-filter.html: Removed.
fast/css/variables/var-inside-box-reflect-expected.html: Removed.
fast/css/variables/var-inside-box-reflect.html: Removed.
fast/css/variables/var-inside-pair-expected.html: Removed.
fast/css/variables/var-inside-pair.html: Removed.
fast/css/variables/var-inside-quad-expected.html: Removed.
fast/css/variables/var-inside-quad.html: Removed.
fast/css/variables/var-inside-shape-expected.html: Removed.
fast/css/variables/var-inside-shape.html: Removed.
fast/css/variables/var-inside-shorthand-expected.html: Removed.
fast/css/variables/var-inside-shorthand.html: Removed.
fast/css/variables/variable-chain-expected.html: Removed.
fast/css/variables/variable-chain.html: Removed.
fast/css/variables/variable-unparseable-value-crash-expected.txt: Removed.
fast/css/variables/variable-unparseable-value-crash.html: Removed.

7:27 AM Changeset in webkit [159841] by commit-queue@webkit.org

4 edits in trunk/LayoutTests

[EFL] Layout tests need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124879

Unreviewed, EFL rebaseline.

EFL tests need to be rebaselined after r159747

Patch by Jongwoo Choi <jw0330.choi@samsung.com> on 2013-11-28

platform/efl/fast/table/011-expected.txt:
platform/efl/fast/table/border-collapsing/004-expected.txt:
platform/efl/fast/table/tableInsideCaption-expected.txt:

7:15 AM Changeset in webkit [159840] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Updating RTCPeerConnectionHandlerMock after r159769
https://bugs.webkit.org/show_bug.cgi?id=124947

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Philippe Normand.

Adding its create function back, in order to run RTCPeerConnection LayoutTests.

No new tests needed.

platform/mock/RTCPeerConnectionHandlerMock.cpp:

(WebCore::RTCPeerConnectionHandlerMock::create):

platform/mock/RTCPeerConnectionHandlerMock.h:

7:14 AM Changeset in webkit [159839] by commit-queue@webkit.org

6 edits in trunk/Tools

Move PrettyPatch related code to prettypatch.py
https://bugs.webkit.org/show_bug.cgi?id=124937

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-28
Reviewed by Ryosuke Niwa.

This code seems to have a better place here than in Port, since PrettyPatch already knows
pretty_patch_path, and this also unifies the usage of PrettyPatch

Scripts/webkitpy/common/prettypatch.py:

(PrettyPatch.init):
(PrettyPatch.pretty_diff):
(PrettyPatch):
(PrettyPatch.pretty_patch_available):
(PrettyPatch.check_pretty_patch):
(PrettyPatch.pretty_patch_text):

Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter.create_text_diff_and_write_result):

Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

Scripts/webkitpy/port/base.py:

(Port.init):
(Port.wdiff_available):
(Port.check_image_diff):
(Port.wdiff_text):

Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_pretty_patch_os_error):
(PortTest.test_pretty_patch_script_error):

6:20 AM WebKitGTK/2.2.x edited by Gustavo Noronha Silva

(diff)

6:09 AM WebKitGTK/2.2.x edited by Gustavo Noronha Silva

(diff)

5:46 AM Changeset in webkit [159838] by commit-queue@webkit.org

2 edits in trunk/Tools

Checkout should own the scm object in Host
https://bugs.webkit.org/show_bug.cgi?id=124943

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-28
Reviewed by Ryosuke Niwa.

Scripts/webkitpy/common/host.py:

(Host.init):
(Host.initialize_scm):
(Host.scm):

5:41 AM WebKitGTK/2.2.x edited by Gustavo Noronha Silva

(diff)

4:40 AM Changeset in webkit [159837] by Gustavo Noronha Silva

9 edits in trunk

[GTK] Support custom types for drag and drop data
https://bugs.webkit.org/show_bug.cgi?id=124659

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-11-27
Reviewed by Martin Robinson.

Source/WebCore:

Covered by fast/events/drag-customData.html.

platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::unknownTypes): returns a hash map with all custom types set.
(WebCore::DataObjectGtk::clearAllExceptFilenames): clear custom types.

platform/gtk/DataObjectGtk.h:

(WebCore::DataObjectGtk::hasUnknownTypeData): returns whether custom types are set.
(WebCore::DataObjectGtk::unknownTypeData): returns the data for a custom type.
(WebCore::DataObjectGtk::setUnknownTypeData): sets the data for a custom type.

platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeString): handle unknown types as custom.
(WebCore::Pasteboard::writePasteboard): ditto.
(WebCore::Pasteboard::hasData): also check for custom types.
(WebCore::Pasteboard::types): also obtain the list of custom types.
(WebCore::Pasteboard::readString): handle unknown types as custom.

platform/gtk/PasteboardHelper.cpp:

(WebCore::initGdkAtoms): new unknown atom.
(WebCore::PasteboardHelper::PasteboardHelper): add custom type to the list of targets.
(WebCore::PasteboardHelper::fillSelectionData): turns any custom types' data into a GVariant, which
is in turn serialized to a single string for GtkSelectionData to hold.
(WebCore::PasteboardHelper::targetListForDataObject): add custom data to the target list if any is
set.
(WebCore::PasteboardHelper::fillDataObjectFromDropData): retrieve the custom types and their data
from the serialized GVariant string held by GtkSelectionData.
(WebCore::PasteboardHelper::dropAtomsForContext): handle custom types.

Source/WebKit2:

Shared/gtk/ArgumentCodersGtk.cpp:

(CoreIPC::encodeDataObject): encode the unknown types data.
(CoreIPC::decodeDataObject): decode the unknown types data.

LayoutTests:

platform/gtk/TestExpectations: remove failure expectation for test that now passes.

4:22 AM WebKitGTK/2.2.x edited by tpopela@redhat.com

(diff)

2:28 AM Changeset in webkit [159836] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

Typo fix after r159834 to fix 32 bit builds.

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Nov 27, 2013:

11:40 PM Changeset in webkit [159835] by nrotem@apple.com

4 edits in trunk/Source/JavaScriptCore

Add a bunch of early exits and local optimizations to the x86 assembler.
https://bugs.webkit.org/show_bug.cgi?id=124904

Reviewed by Filip Pizlo.

assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::add32):
(JSC::MacroAssemblerX86::add64):
(JSC::MacroAssemblerX86::or32):

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::or32):

assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::or32):
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::or64):
(JSC::MacroAssemblerX86_64::xor64):

11:10 PM Changeset in webkit [159834] by fpizlo@apple.com

31 edits
12 adds in trunk

Infer one-time scopes
https://bugs.webkit.org/show_bug.cgi?id=124812

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This detects JSActivations that are created only once. The JSActivation pointer is then
baked into the machine code.

This takes advantage of the one-time scope inference to reduce the number of
indirections needed to get to a closure variable in case where the scope is only
allocated once. This isn't really a speed-up since in the common case the total number
of instruction bytes needed to load the scope from the stack is about equal to the
number of instruction bytes needed to materialize the absolute address of a scoped
variable. But, this is a necessary prerequisite to
https://bugs.webkit.org/show_bug.cgi?id=124630, so it's probably a good idea anyway.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):

bytecode/Instruction.h:
bytecode/Opcode.h:

(JSC::padOpcodeName):

bytecode/Watchpoint.h:

(JSC::WatchpointSet::notifyWrite):
(JSC::InlineWatchpointSet::notifyWrite):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolveScope):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getLocalLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::tryGetRegisters):

dfg/DFGGraph.h:
dfg/DFGNode.h:

(JSC::DFG::Node::varNumber):
(JSC::DFG::Node::hasSymbolTable):
(JSC::DFG::Node::symbolTable):

dfg/DFGNodeType.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGWatchpointCollectionPhase.cpp:

(JSC::DFG::WatchpointCollectionPhase::handle):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetClosureRegisters):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/JSActivation.h:

(JSC::JSActivation::create):

runtime/JSScope.cpp:

(JSC::abstractAccess):
(JSC::JSScope::abstractResolve):

runtime/JSScope.h:

(JSC::ResolveOp::ResolveOp):

runtime/JSVariableObject.h:

(JSC::JSVariableObject::registers):

runtime/SymbolTable.cpp:

(JSC::SymbolTable::SymbolTable):

runtime/SymbolTable.h:

LayoutTests:

Reviewed by Oliver Hunt.

js/regress/infer-one-time-closure-expected.txt: Added.
js/regress/infer-one-time-closure-ten-vars-expected.txt: Added.
js/regress/infer-one-time-closure-ten-vars.html: Added.
js/regress/infer-one-time-closure-two-vars-expected.txt: Added.
js/regress/infer-one-time-closure-two-vars.html: Added.
js/regress/infer-one-time-closure.html: Added.
js/regress/infer-one-time-deep-closure-expected.txt: Added.
js/regress/infer-one-time-deep-closure.html: Added.
js/regress/script-tests/infer-one-time-closure-ten-vars.js: Added.
js/regress/script-tests/infer-one-time-closure-two-vars.js: Added.
js/regress/script-tests/infer-one-time-closure.js: Added.
js/regress/script-tests/infer-one-time-deep-closure.js: Added.

8:34 PM Changeset in webkit [159833] by weinig@apple.com

7 edits in trunk/Source/WebKit2

Give the PageClient a chance to handle geolocation permission requests if the UIClient doesn't handle it
https://bugs.webkit.org/show_bug.cgi?id=124955

Reviewed by Dan Bernstein.

Use the new PageClient function to remove the need for WKContentView to take over the WKPageUIClient.

UIProcess/API/ios/PageClientImplIOS.h:
UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):

UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]):
(-[WKContentView _commonInitWithProcessGroup:browsingContextGroup:]):

UIProcess/API/ios/WKContentViewInternal.h:
UIProcess/PageClient.h:

(WebKit::PageClient::decidePolicyForGeolocationPermissionRequest):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):

7:23 PM Changeset in webkit [159832] by weinig@apple.com

3 edits in trunk/Source/WebKit2

Fix the iOS build.

UIProcess/API/ios/WKGeolocationProviderIOS.mm:
UIProcess/API/ios/WKGeolocationProviderIOSObjCSecurityOrigin.mm:

7:14 PM Changeset in webkit [159831] by weinig@apple.com

4 edits
1 add in trunk/Source/WebKit

Fix the iOS build.

../WebKit:

WebKit.xcodeproj/project.pbxproj:

../WebKit/mac:

WebView/WebAllowDenyPolicyListener.h: Added.
WebView/WebUIDelegatePrivate.h:

Move the WebAllowDenyPolicyListener protocol to its own file.

6:25 PM Changeset in webkit [159830] by weinig@apple.com

3 edits in trunk/Source/WebKit2

Add accessors for the WKProcessGroup and WKBrowsingContextGroup on the WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=124953

Reviewed by Dan Bernstein.

UIProcess/API/mac/WKBrowsingContextController.h:
UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController processGroup]):
(-[WKBrowsingContextController browsingContextGroup]):
Add accessors.

6:03 PM Changeset in webkit [159829] by weinig@apple.com

6 edits
1 add in trunk/Source/WebKit2

Make WKProcessGroup work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=124952

Reviewed by Dan Bernstein.

Shared/Cocoa/APIObject.mm:

(API::Object::newObject):
Add support for WKProcessGroup.

UIProcess/API/mac/WKProcessGroup.mm:

(-[WKProcessGroup initWithInjectedBundleURL:]):
(-[WKProcessGroup dealloc]):
(-[WKProcessGroup API::]):
(-[WKProcessGroup _contextRef]):
(-[WKProcessGroup _geolocationProvider]):
Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline

UIProcess/API/mac/WKProcessGroupInternal.h: Added.

(WebKit::wrapper):
Add wrapper() helper and declare conformance to the WKObject protocol.

UIProcess/WebContext.cpp:

(WebKit::WebContext::create):
(WebKit::WebContext::WebContext):

UIProcess/WebContext.h:

Make the WebContext constructor public (for use with Object::constructInWrapper) and remove unused ProcessModel parameter.

WebKit2.xcodeproj/project.pbxproj:

Add new file.

5:20 PM Changeset in webkit [159828] by commit-queue@webkit.org

2 edits in trunk

[EFL] The remote inspector does not show the base page.
https://bugs.webkit.org/show_bug.cgi?id=124942

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-27
Reviewed by Gyuyoung Kim.

On EFL the remote inspector does not show the base page about
which pages are available for debug. This should be fixed for
further inspector development.

Source/PlatformEfl.cmake:

5:05 PM Changeset in webkit [159827] by eric.carlson@apple.com

37 edits
9 adds in trunk

Allow the QuickTime plug-in to be replaced by script in an isolated word
https://bugs.webkit.org/show_bug.cgi?id=124900

Reviewed by Dean Jackson.

Source/WebCore:

Test: plugins/quicktime-plugin-replacement.html

CMakeLists.txt: Add new Modules path.
DerivedSources.make: Add new files.
GNUmakefile.am: Add new Modules path.
GNUmakefile.list.am: Add new header.
WebCore.vcxproj/WebCore.vcxproj: Add new header.
WebCore.vcxproj/WebCoreCommon.props: Add new Modules path.
WebCore.xcodeproj/project.pbxproj: Add new files.

Modules/plugins: Added.
Modules/plugins/PluginReplacement.h: Added. Defines the interface for a plug-in replacement.

Create a replacement for the QuickTime plug-in.

Modules/plugins/QuickTimePluginReplacement.cpp: Added.
Modules/plugins/QuickTimePluginReplacement.css: Added.
Modules/plugins/QuickTimePluginReplacement.h: Added.
Modules/plugins/QuickTimePluginReplacement.idl: Added.
Modules/plugins/QuickTimePluginReplacement.js: Added.

Allow plug-in replacement to be enabled at runtime.

bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setPluginReplacementEnabled):
(WebCore::RuntimeEnabledFeatures::pluginReplacementEnabled):

bindings/js/JSDOMBinding.h:

(WebCore::toJS): Add toJS(... const String& ...).

bindings/js/JSPluginElementFunctions.cpp:

(WebCore::pluginScriptObject): Give a plug-in replacement a first shot at defining the

script interface.

html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget): Call base class requestObject.

html/HTMLMediaElement.cpp:

(HTMLMediaElement::fileSize): New, passthrough to media engine.

html/HTMLMediaElement.h:

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget): Call base class requestObject.

Moved some logic that was previously used only for creating a plug-in snapshot to the base
class so it can be shared by a plug-in replacement.

html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::HTMLPlugInElement): Initialize timer used to swap renderers.
(WebCore::HTMLPlugInElement::createRenderer): Allow plug-in replacement to create the renderer.
(WebCore::HTMLPlugInElement::swapRendererTimerFired): Create a shadow root.
(WebCore::HTMLPlugInElement::setDisplayState): Set the new state, prime the swap renderer

timer if necessary.

(WebCore::HTMLPlugInElement::didAddUserAgentShadowRoot): Tell the plug-in replacement to

install itself in the new shadow DOM.

(WebCore::registeredPluginReplacements): Return vector of all registered plug-in replacements.
(WebCore::registerPluginReplacement): Add a plug-in replacement.
(WebCore::pluginReplacementForType): Find a plug-in replacement for a MIME type.
(WebCore::HTMLPlugInElement::requestObject): If there is a plug-in replacement for the MIME type,

create it and set the display state.

(WebCore::HTMLPlugInElement::scriptObjectForPluginReplacement): Return the script object for

the current plug-in replacement, if any.

html/HTMLPlugInElement.h:

Move some plug-in snapshot code into the base class.

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): No need to initialize timer.
(WebCore::HTMLPlugInImageElement::setDisplayState): Call base class.
(WebCore::HTMLPlugInImageElement::createRenderer): Ditto.
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Ditto.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Remove unnecessary class name.
(WebCore::HTMLPlugInImageElement::requestObject): New.

html/HTMLPlugInImageElement.h:

html/HTMLVideoElement.h: Make createRenderer public so the QuickTime plug-in replacement can

call it.

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::fileSize): New.

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h:

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::extraMemoryCost): totalBytes returns an unsigned long long.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::fileSize):

platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes): Return an unsigned long long.

platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::totalBytes): Ditto.

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup): Backup the plug-in replacement runtime setting.
(WebCore::InternalSettings::Backup::restoreTo): Restore it.
(WebCore::InternalSettings::setPluginReplacementEnabled): Set it.

testing/InternalSettings.h:
testing/InternalSettings.idl:

LayoutTests:

platform/efl/TestExpectations: Skip the new test.
platform/gtk/TestExpectations: Ditto.
platform/wincairo/TestExpectations: Ditto.
plugins/quicktime-plugin-replacement.html: Added.
plugins/quicktime-plugin-replacement-expected.txt: Added.
plugins/resources/orange.mov: Replace movie compressed with ancient (and deprecated)

animated gif codec with one compressed with H.264 codec.

4:22 PM Changeset in webkit [159826] by fpizlo@apple.com

7 edits in trunk/Source/JavaScriptCore

Finally fix some obvious Bartlett bugs
https://bugs.webkit.org/show_bug.cgi?id=124951

Reviewed by Mark Hahnenberg.

Sanitize the stack (i.e. zero parts of it known to be dead) at three key points:

At beginning of OSR entry.

Just as we finish preparing OSR entry. This clears those slots on the stack that could have been live in baseline but that are known to be dead in DFG.

This is as much as a 2x speed-up on splay if you run it in certain modes, and run it
for a long enough interval. It appears to fix all instances of the dreaded exponential
heap growth that splay gets into when some stale pointer stays around.

This doesn't have much of an effect on real-world programs. This bug has only ever
manifested in splay and for that reason we thus far opted against fixing it. But splay
is, for what it's worth, the premiere GC stress test in JavaScript - so making sure we
can run it without pathologies - even when you tweak its configuration - is probably
fairly important.

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

dfg/DFGOSREntry.h:
heap/Heap.cpp:

(JSC::Heap::markRoots):

interpreter/JSStack.cpp:

(JSC::JSStack::JSStack):
(JSC::JSStack::sanitizeStack):

interpreter/JSStack.h:

3:15 PM Changeset in webkit [159825] by fpizlo@apple.com

15 edits
1 add in trunk

Do bytecode validation as part of testing
https://bugs.webkit.org/show_bug.cgi?id=124913

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Also fix some small bugs in the bytecode liveness analysis that I found by doing
this validation thingy.

bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::isValidRegisterForLiveness):
(JSC::BytecodeLivenessAnalysis::runLivenessFixpoint):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::validate):
(JSC::CodeBlock::beginValidationDidFail):
(JSC::CodeBlock::endValidationDidFail):

bytecode/CodeBlock.h:
runtime/Executable.cpp:

(JSC::ScriptExecutable::prepareForExecutionImpl):

runtime/Options.h:

Source/WTF:

Reviewed by Oliver Hunt.

GNUmakefile.list.am:
WTF.vcxproj/WTF.vcxproj:
WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/FastBitVector.cpp: Added.

(WTF::FastBitVector::dump):

wtf/FastBitVector.h:

(WTF::FastBitVector::resize):
(WTF::FastBitVector::bitCount):
(WTF::FastBitVector::arrayLength):

Tools:

Reviewed by Oliver Hunt.

Scripts/run-jsc-stress-tests:

2:48 PM Changeset in webkit [159824] by weinig@apple.com

7 edits
1 add in trunk/Source/WebKit2

Make WKBrowsingContextGroup work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=124948

Reviewed by Dan Bernstein.

Adds mechanism to use the inline data wrapping mechanism when the Objective-C wrapper is created by the caller (rather than by Object::newObject).
Adopts the mechanism for WKBrowsingContextGroup.

Shared/APIObject.h:

(API::Object::constructInWrapper):
Add a helper which does a forwarding placement-new into the API::Object of the passed in wrapper, after which it sets up m_wrapper.

(API::TypedObject::operator new):
Add a operator new to for placement-new. Also make TypedObject friends with Object so that constructInWrapper can call this.

Shared/Cocoa/APIObject.mm:

(API::Object::newObject):
Add support for WKBrowsingContextGroup.

UIProcess/API/mac/WKBrowsingContextGroup.mm:

(-[WKBrowsingContextGroup API::]):
(-[WKBrowsingContextGroup dealloc]):
(-[WKBrowsingContextGroup initWithIdentifier:]):
(-[WKBrowsingContextGroup allowsJavaScript]):
(-[WKBrowsingContextGroup setAllowsJavaScript:]):
(-[WKBrowsingContextGroup allowsJavaScriptMarkup]):
(-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]):
(-[WKBrowsingContextGroup allowsPlugIns]):
(-[WKBrowsingContextGroup setAllowsPlugIns:]):
(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]):
(-[WKBrowsingContextGroup removeAllUserStyleSheets]):
(-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]):
(-[WKBrowsingContextGroup removeAllUserScripts]):
(-[WKBrowsingContextGroup _pageGroupRef]):
Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline (modeled on WKBackForwardList).

UIProcess/API/mac/WKBrowsingContextGroupInternal.h: Added.

(WebKit::wrapper):
Add wrapper() helper and declare conformance to the WKObject protocol.

UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::create):
(WebKit::WebPageGroup::WebPageGroup):

UIProcess/WebPageGroup.h:

Make the WebPageGroup constructor public (for use with Object::constructInWrapper) and move being set in the webPageGroupMap()
to the constructor.

WebKit2.xcodeproj/project.pbxproj:

Add new file.

1:03 PM Changeset in webkit [159823] by commit-queue@webkit.org

7 edits
2 adds in trunk

Adding MediaConstraintsMock class
https://bugs.webkit.org/show_bug.cgi?id=124902

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-27
Reviewed by Eric Carlson.

Validate constraints used in RTCPeerConnection LayoutTests

Source/WebCore:

Existing test was updated.

CMakeLists.txt:
GNUmakefile.list.am:
platform/mock/MediaConstraintsMock.cpp: Added.
platform/mock/MediaConstraintsMock.h: Added.
platform/mock/MockMediaStreamCenter.cpp:

(WebCore::MockMediaStreamCenter::validateRequestConstraints): Now using MediaConstraintsMock
(WebCore::MockMediaStreamCenter::createMediaStream): Ditto.

platform/mock/RTCPeerConnectionHandlerMock.cpp:

(WebCore::RTCPeerConnectionHandlerMock::initialize): Ditto.

LayoutTests:

fast/mediastream/RTCPeerConnection-expected.txt:

12:19 PM Changeset in webkit [159822] by betravis@adobe.com

10 edits in trunk

[CSS Shapes] Shape-Inside Should Default to 'auto'
https://bugs.webkit.org/show_bug.cgi?id=124851

Reviewed by Alexandru Chiculita.

Source/WebCore:

The current shape-inside specification has the property default to the 'auto'
value, not 'outside-shape'.

Updated tests are under fast/shapes.

rendering/style/RenderStyle.cpp:
rendering/style/RenderStyle.h:

LayoutTests:

Update tests to reflect a default shape-inside value of 'auto'.

fast/shapes/css-shapes-disabled-expected.txt:
fast/shapes/css-shapes-disabled.html:
fast/shapes/parsing/parsing-shape-inside-expected.txt:
fast/shapes/parsing/parsing-shape-inside.html:
fast/shapes/parsing/parsing-shape-lengths-expected.txt:
fast/shapes/parsing/parsing-shape-lengths.html:

12:17 PM Changeset in webkit [159821] by hmuller@adobe.com

3 edits
2 adds in trunk

[CSS Shapes] shape-inside rectangle layout can fail
https://bugs.webkit.org/show_bug.cgi?id=124784

Reviewed by Andreas Kling.

Source/WebCore:

Apply LayoutUnit::fromFloatCeil() consistently in RectangleShape::firstIncludedIntervalLogicalTop().

Test: fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html

rendering/shapes/RectangleShape.cpp:

(WebCore::RectangleShape::firstIncludedIntervalLogicalTop):

LayoutTests:

Regression test.

fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top-expected.html: Added.
fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html: Added.

11:02 AM Changeset in webkit [159820] by commit-queue@webkit.org

2 edits
2 deletes in trunk/Source

Remove Qt-specific .qrc files
https://bugs.webkit.org/show_bug.cgi?id=124944

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-27
Reviewed by Andreas Kling.

Source/WebCore:

No new tests needed.

WebCore.qrc: Removed.

Source/WebKit2:

WebKit2.qrc: Removed.

9:41 AM Changeset in webkit [159819] by commit-queue@webkit.org

2 edits in trunk/Tools

[GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
https://bugs.webkit.org/show_bug.cgi?id=124940

Patch by Andres Gomez <Andres Gomez> on 2013-11-27
Reviewed by Martin Robinson.

xserver-font-utils is needed for building gtk port dependencies
with jhbuild.

gtk/install-dependencies: Added xserver-font-utils to jhbuild

dependecies.

9:24 AM Changeset in webkit [159818] by commit-queue@webkit.org

2 edits in trunk/Tools

[GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
https://bugs.webkit.org/show_bug.cgi?id=124938

Patch by Andres Gomez <Andres Gomez> on 2013-11-27
Reviewed by Philippe Normand.

Added needed git dependency for building the gtk port with
jhbuild. Also, the dependencies needed for building the gtk port
are now sorted alphabetically.

gtk/install-dependencies: Added git as jhbuild dependency and

sorted dependencies alphabetically.

8:35 AM Changeset in webkit [159817] by commit-queue@webkit.org

3 edits in trunk/Source/WTF

Remove Sparc specific code.
https://bugs.webkit.org/show_bug.cgi?id=124941

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-11-27
Reviewed by Michael Saboff.

Sparc is not supported, remove leftover code.

wtf/Platform.h:
wtf/dtoa/utils.h:

8:23 AM WebKitGTK/Releasing edited by Andres Gomez

(diff)

8:22 AM WebKitGTK/StartHacking edited by Andres Gomez

(diff)

8:16 AM WebKitGTK/Releasing edited by Andres Gomez

(diff)

8:12 AM Changeset in webkit [159816] by rniwa@webkit.org

2 edits in trunk/PerformanceTests

Build fix after r159805.

resources/runner.js:

8:09 AM WebKitGTK/StableRelease created by Andres Gomez

8:02 AM WebKitGTK edited by Andres Gomez

(diff)

7:55 AM Changeset in webkit [159815] by commit-queue@webkit.org

2 edits in trunk/Tools

run_webkit_tests.py: error: no such option: --wincairo
https://bugs.webkit.org/show_bug.cgi?id=124927

Patch by Jozsef Berta <jberta@inf.u-szeged.hu> on 2013-11-27
Reviewed by Ryosuke Niwa.

BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports

the layout testing on wincairo, so it is turned off.

7:10 AM Changeset in webkit [159814] by akling@apple.com

2 edits in trunk/Source/JavaScriptCore

Structure::m_staticFunctionReified should be a single bit.
<https://webkit.org/b/124912>

Shave 8 bytes off of JSC::Structure by jamming m_staticFunctionReified
into the bitfield just above.

Reviewed by Antti Koivisto.

7:05 AM Changeset in webkit [159813] by akling@apple.com

2 edits in trunk/Source/JavaScriptCore

JSActivation constructor should use NotNull placement new.
<https://webkit.org/b/124909>

Knock a null check outta the storage initialization loop.

Reviewed by Antti Koivisto.

6:34 AM Changeset in webkit [159812] by Michał Pakuła vel Rutka

3 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for flaky tests.

platform/efl-wk2/TestExpectations:
platform/efl/TestExpectations:

5:04 AM Changeset in webkit [159811] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit2

[GTK] Programs/WebKit2APITests/TestWebKitSettings unit test is failing
https://bugs.webkit.org/show_bug.cgi?id=124924

Reviewed by Carlos Garcia Campos.

UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettingsUserAgent):

4:21 AM WebKitGTK/SpeedUpBuild edited by Manuel Rego Casasnovas

Fix typo (diff)

3:48 AM WebKitGTK/SpeedUpBuild edited by Manuel Rego Casasnovas

Add documentation about icecc (diff)

2:47 AM Changeset in webkit [159810] by calvaris@igalia.com

3 edits
2 adds in trunk

[GStreamer] Invalid command line error when visiting www.chessbase.com
https://bugs.webkit.org/show_bug.cgi?id=124715

Reviewed by Philippe Normand.

Source/WebCore:

We were not handling the HTTP errors in the WebKit GStreamer
source and therefore the 404 error page was being 'decoded'. As no
decoder could be found (for obvious reasons), playback failed, but
it should be failing for the source not being found instead of the
decoding problem.

Test: http/tests/media/video-error-does-not-exist.html

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::handleResponseReceived): Handle HTTP errors in
the source and raise a GStreamer error to the pipeline.

LayoutTests:

Copied and adapted for HTTP from
media/video-error-does-not-exist.html.

http/tests/media/video-error-does-not-exist-expected.txt: Added.
http/tests/media/video-error-does-not-exist.html: Added.

12:43 AM Changeset in webkit [159809] by svillar@igalia.com

8 edits
2 adds in trunk

[CSS Grid Layout] Fix positioning of grid items with margins
https://bugs.webkit.org/show_bug.cgi?id=124345

Reviewed by David Hyatt.

From Blink r157925 and r158041 by <jchaffraix@chromium.org>

Source/WebCore:

Test: fast/css-grid-layout/grid-item-margin-resolution.html

Adds margin start/before to the positions of grid items (removing
several FIXME's in the current code). This means calling
findChildLogicalPosition() after the layout in order to have the
right values for the margins.

In order to match flexbox and author's intents we're also
including the margins of grid items in the intrinsic size of the
grid. That's why flexbox's marginLogicalPositionForChild() is
moved up to RenderBlock in order to share it with RenderGrid.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::marginIntrinsicLogicalWidthForChild): Moved
from RenderFlexibleBox::marginLogicalWidthForChild().

rendering/RenderBlock.h:
rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computePreferredTrackWidth):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::findChildLogicalPosition):

LayoutTests:

New test case for grid items margin resolution. Extended the
preferred logical widths checks with grid items with margins.

fast/css-grid-layout/grid-item-margin-resolution-expected.txt: Added.
fast/css-grid-layout/grid-item-margin-resolution.html: Added.
fast/css-grid-layout/grid-preferred-logical-widths-expected.txt:
fast/css-grid-layout/grid-preferred-logical-widths.html:

12:31 AM Changeset in webkit [159808] by svillar@igalia.com

7 edits
2 adds in trunk

[CSS Grid Layout] Support grid-definition-{rows|columns} repeat() syntax
https://bugs.webkit.org/show_bug.cgi?id=103312

Reviewed by Andreas Kling.

PerformanceTests:

Use the repeat() syntax to build the huge grids used by the
performance tests.

Layout/auto-grid-lots-of-data.html:
Layout/fixed-grid-lots-of-data.html:

Source/WebCore:

Added support for the repeat() syntax inside
grid-definition-{rows|columns} by just adding the repeated values
to our list of column|row definitions.

The parsing of <track-name> was refactored in a new function as
it's used now in three different places. The <track-size> parsing
was also refactored to share it with the repeat() parsing.

Test: fast/css-grid-layout/grid-element-repeat-get-set.html

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTrackNames):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseGridTrackRepeatFunction):
(WebCore::CSSParser::parseGridTrackSize):

css/CSSParser.h:

LayoutTests:

Based on Blink r153155 by <jchaffraix@chromium.org>. Some code was
refactored in a helper function to have a more compact test.

fast/css-grid-layout/grid-element-repeat-get-set-expected.txt: Added.
fast/css-grid-layout/grid-element-repeat-get-set.html: Added.

Nov 26, 2013:

10:14 PM Changeset in webkit [159807] by rniwa@webkit.org

2 edits
2 adds in trunk/LayoutTests

Windows rebaselines after r158547.

platform/win/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
platform/win/editing/selection/drag-text-delay-expected.txt: Added.
platform/win/editing/selection/extend-selection-home-end-expected.txt:

10:05 PM Changeset in webkit [159806] by marcelo.lira@openbossa.org

19 edits
14 adds in trunk

Nix upstreaming - Adding build files and supporting scripts
https://bugs.webkit.org/show_bug.cgi?id=118367

Reviewed by Ryosuke Niwa.

CMakeLists.txt:
Source/CMakeLists.txt:
Source/cmake/FindEGL.cmake:
Source/cmake/FindOpenGLES2.cmake: Added.
Source/cmake/OptionsCommon.cmake:
Source/cmake/OptionsNix.cmake: Added.

Source/Platform:

CMakeLists.txt: Added.
PlatformNix.cmake: Added.

Source/WebCore:

No new tests needed.

CMakeLists.txt:
PlatformNix.cmake: Added.

Source/WTF:

wtf/FeatureDefines.h:
wtf/Platform.h:
wtf/PlatformNix.cmake: Added.

Tools:

Scripts/build-webkit:
Scripts/run-nix-tests: Added.
Scripts/run-webkit-tests:
Scripts/update-webkit-libs-jhbuild:
Scripts/update-webkitnix-libs: Added.
Scripts/webkitdirs.pm:

(determineArchitecture):
(argumentsForConfiguration):
(jscProductDir):
(builtDylibPathForName):
(determineIsNix):
(isNix):
(isAppleWebKit):
(launcherPath):
(launcherName):
(checkRequiredSystemConfig):
(copyInspectorFrontendFiles):
(jhbuildWrapperPrefixIfNeeded):
(buildCMakeProjectOrExit):
(cmakeBasedPortName):

Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.port):
(EflWK2Port.build_webkit_command):
(NixPort):
(NixPort.build_webkit_command):

Scripts/webkitpy/port/factory.py:

(platform_options):
(PortFactory):

Scripts/webkitpy/port/nix.py: Added.

(NixPort):
(NixPort._wk2_port_name):
(NixPort.determine_full_port_name):
(NixPort.init):
(NixPort._port_flag_for_scripts):
(NixPort.setup_test_run):
(NixPort.setup_environ_for_server):
(NixPort.default_timeout_ms):
(NixPort.clean_up_test_run):
(NixPort._generate_all_test_configurations):
(NixPort._path_to_driver):
(NixPort._path_to_image_diff):
(NixPort._image_diff_command):
(NixPort._search_paths):
(NixPort.show_results_html_file):
(NixPort._port_specific_expectations_files):
(NixPort.default_baseline_search_path):

Scripts/webkitpy/port/nix_unittest.py: Added.

(NixPortTest):
(NixPortTest._assert_search_path):
(NixPortTest._assert_expectations_files):
(NixPortTest.test_baseline_search_path):
(NixPortTest.test_expectations_files):
(NixPortTest.test_default_timeout_ms):

jhbuild/jhbuild-wrapper:

(determine_platform):

nix/common.py: Added.

(script_path):
(top_level_path):

nix/jhbuild.modules: Added.
nix/jhbuildrc: Added.

9:33 PM Changeset in webkit [159805] by rniwa@webkit.org

10 edits in trunk

Record subtest values in Dromaeo tests
https://bugs.webkit.org/show_bug.cgi?id=124498

Reviewed by Andreas Kling.

PerformanceTests:

Made Dromaeo's test runner report values in DRT.progress via newly added PerfTestRunner.reportValues.

Dromaeo/resources/dromaeorunner.js:

(.): Moved the definition out of DRT.setup.
(DRT.setup): Ditto.
(DRT.testObject): Extracted from DRT.setup. Set the subtest name and continueTesting.
continueTesting is set true for subtests; i.e. when name is specified.
(DRT.progress): Call PerfTestRunner.reportValues to report subtest results.
(DRT.teardown): Call PerfTestRunner.reportValues instead of measureValueAsync.

resources/runner.js: Made various changes for newly added PerfTestRunner.reportValues.

(.): Moved the initialization of completedIterations, results, jsHeapResults, and mallocHeapResults into
start since they need to be initialized before running each subtest. Initialize logLines here since we
need to use the same logger for all subtests.
(.start): Initialize the variables mentioned above here. Also respect doNotLogStart used by reportValues.
(ignoreWarmUpAndLog): Added doNotLogProgress. Used by reportValues since it reports all values at once.
(finish): Compute the metric name such as FrameFrame and Runs from unit. Also don't log or notify done
when continueTesting is set on the test object.
(PerfTestRunner.reportValues): Added. Reports all values for the main/sub test.

Tools:

Supported parsing subtest results.

Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of

which contains a dictionary with its name and an ordered list of subtest's metrics.
(PerfTest.init): Initialize _metrics as a list.
(PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
(PerfTest._run_with_driver):
(PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.

Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
(TestPerfTest.test_parse_output): Ditto.
(TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
assertions to ensure subtest results are parsed properly.
(TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.

Scripts/webkitpy/performance_tests/perftestsrunner.py:

(_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
adding new results.

Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:

(TestWithSubtestsData): Added.
(TestDriver.run_test):
(MainTest.test_run_test_with_subtests): Added.

LayoutTests:

Rebaselined the test.

fast/harness/perftests/runs-per-second-log-expected.txt:

9:13 PM Changeset in webkit [159804] by rniwa@webkit.org

5 edits in trunk

Enable HTML template element on Windows ports
https://bugs.webkit.org/show_bug.cgi?id=124758

Reviewed by Andreas Kling.

Tools:

Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

Enable TEMPLATE_ELEMENT. Also removed UNDO_MANAGER since that feature has been removed
from the tree in r133326.

win/tools/vsprops/FeatureDefines.props:
win/tools/vsprops/FeatureDefinesCairo.props:

8:36 PM Changeset in webkit [159803] by rniwa@webkit.org

8 edits
1 delete in trunk

Remove replay performance tests as it's not actively maintained
https://bugs.webkit.org/show_bug.cgi?id=124764

Reviewed by Andreas Kling.

PerformanceTests:

Removed the replay performance tests. We can add them back when time comes.

Replay/Chinese/chinaz.com.replay: Removed.
Replay/Chinese/www.163.com.replay: Removed.
Replay/Chinese/www.alipay.com.replay: Removed.
Replay/Chinese/www.baidu.com.replay: Removed.
Replay/Chinese/www.csdn.net.replay: Removed.
Replay/Chinese/www.douban.com.replay: Removed.
Replay/Chinese/www.hao123.com.replay: Removed.
Replay/Chinese/www.xinhuanet.com.replay: Removed.
Replay/Chinese/www.xunlei.com.replay: Removed.
Replay/Chinese/www.youku.com.replay: Removed.
Replay/English/beatonna.livejournal.com.replay: Removed.
Replay/English/cakewrecks.blogspot.com.replay: Removed.
Replay/English/chemistry.about.com.replay: Removed.
Replay/English/digg.com.replay: Removed.
Replay/English/en.wikipedia.org-rorschach_test.replay: Removed.
Replay/English/icanhascheezburger.com.replay: Removed.
Replay/English/imgur.com-gallery.replay: Removed.
Replay/English/online.wsj.com.replay: Removed.
Replay/English/stockoverflow.com-best-comment.replay: Removed.
Replay/English/www.alibaba.com.replay: Removed.
Replay/English/www.amazon.com-kindle.replay: Removed.
Replay/English/www.apple.com.replay: Removed.
Replay/English/www.cnet.com.replay: Removed.
Replay/English/www.dailymotion.com.replay: Removed.
Replay/English/www.ehow.com-prevent-fire.replay: Removed.
Replay/English/www.filestube.com-amy-adams.replay: Removed.
Replay/English/www.foxnews.replay: Removed.
Replay/English/www.huffingtonpost.com.replay: Removed.
Replay/English/www.imdb.com-twilight.replay: Removed.
Replay/English/www.mozilla.com-all-order.replay: Removed.
Replay/English/www.php.net.replay: Removed.
Replay/English/www.reddit.com.replay: Removed.
Replay/English/www.telegraph.co.uk.replay: Removed.
Replay/English/www.w3.org-htmlcss.replay: Removed.
Replay/English/www.w3schools.com-html.replay: Removed.
Replay/English/www.youtube.com-music.replay: Removed.
Replay/French/www.orange.fr.replay: Removed.
Replay/Italian/www.repubblica.it.replay: Removed.
Replay/Japanese/2ch.net-newsplus.replay: Removed.
Replay/Japanese/entameblog.seesaa.net.replay: Removed.
Replay/Japanese/ja.wikipedia.org.replay: Removed.
Replay/Japanese/www.hatena.ne.jp.replay: Removed.
Replay/Japanese/www.livedoor.com.replay: Removed.
Replay/Japanese/www.nicovideo.jp.replay: Removed.
Replay/Japanese/www.rakuten.co.jp.replay: Removed.
Replay/Japanese/www.yahoo.co.jp.replay: Removed.
Replay/Korean/www.naver.com.replay: Removed.
Replay/Persian/blogfa.com.replay: Removed.
Replay/Polish/www.wp.pl.replay: Removed.
Replay/Portuguese/www.uol.com.br.replay: Removed.
Replay/Russian/lenta.ru.replay: Removed.
Replay/Russian/vkontakte.ru-help.replay: Removed.
Replay/Russian/www.ixbt.com.replay: Removed.
Replay/Russian/www.kp.ru.replay: Removed.
Replay/Russian/www.liveinternet.ru.replay: Removed.
Replay/Russian/www.pravda.ru.replay: Removed.
Replay/Russian/www.rambler.ru.replay: Removed.
Replay/Russian/www.ucoz.ru.replay: Removed.
Replay/Russian/www.yandex.ru.replay: Removed.
Replay/Spanish/www.taringa.net.replay: Removed.
Replay/Swedish/www.flashback.se.replay: Removed.
Replay/Swedish/www.tradera.com.replay: Removed.
Replay/www.google.com.replay: Removed.
Replay/www.techcrunch.com.replay: Removed.
Replay/www.youtube.com.replay: Removed.

Tools:

Removed the feature.

Scripts/webkitpy/performance_tests/perftest.py:

(SingleProcessPerfTest.init):
(PerfTestFactory):

Scripts/webkitpy/performance_tests/perftest_unittest.py:
Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):
(PerfTestsRunner._collect_tests):

Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.test_collect_tests_with_ignored_skipped_list):
(MainTest.test_default_args):

Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_unittest2):

Scripts/webkitpy/thirdparty/init_unittest.py:

(ThirdpartyTest.test_imports):

8:32 PM Changeset in webkit [159802] by rniwa@webkit.org

1 edit
12 adds in trunk/LayoutTests/imported/w3c

Import W3C tests for cloning template elements and default stylesheet for template element
https://bugs.webkit.org/show_bug.cgi?id=124882

Reviewed by Andreas Kling.

Imported tests under html-templates/additions-to-the-steps-to-clone-a-node and
html-templates/additions-to-the-css-user-agent-style-sheet at d38dbd5b492808811bc0fe04a8cc49f28863c5cc.

Renamed and replicated css-user-agent-style-sheet-test-001-ref.html as -00*-expected.html for ref testing.

html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-001-expected.html: Added.
html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-001.html: Added.
html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-002-expected.html: Added.
html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-002.html: Added.
html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-003-expected.html: Added.
html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-003.html: Added.
html-templates/additions-to-the-steps-to-clone-a-node/template-clone-children-expected.txt: Added.
html-templates/additions-to-the-steps-to-clone-a-node/template-clone-children.html: Added.
html-templates/additions-to-the-steps-to-clone-a-node/templates-copy-document-owner-expected.txt: Added.
html-templates/additions-to-the-steps-to-clone-a-node/templates-copy-document-owner.html: Added.

8:05 PM Changeset in webkit [159801] by fpizlo@apple.com

2 edits in trunk/Tools

Enable aggressive DFG validation in testing
https://bugs.webkit.org/show_bug.cgi?id=124911

Rubber stamped by Ryosuke Niwa.

This enables validation testing in non-concurrent-JIT runs.

Scripts/run-jsc-stress-tests:

7:50 PM Changeset in webkit [159800] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Don't parent the TileController root layer in two places
https://bugs.webkit.org/show_bug.cgi?id=124873

Reviewed by Brent Fulgham.

platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::TileController):
The TileController's layer is already parented by callers of
TileController::create, and in a special way. TileController
shouldn't parent itself, anyway...

7:35 PM Changeset in webkit [159799] by commit-queue@webkit.org

3 edits in trunk/Source/WTF

ASSERT_WITH_SECURITY_IMPLICATION should crash in a distinct way.
https://bugs.webkit.org/show_bug.cgi?id=124757

Change ASSERT_WITH_SECURITY_IMPLICATION to access a different address from CRASH()
in order to help screen fuzzing bugs.

Patch by Drew Yao <ayao@apple.com> on 2013-11-26
Reviewed by Brent Fulgham.

wtf/Assertions.cpp:
wtf/Assertions.h:

6:47 PM Changeset in webkit [159798] by fpizlo@apple.com

37 edits
1 add in trunk/Source/JavaScriptCore

Restructure global variable constant inference so that it could work for any kind of symbol table variable
https://bugs.webkit.org/show_bug.cgi?id=124760

Reviewed by Oliver Hunt.

This changes the way global variable constant inference works so that it can be reused
for closure variable constant inference. Some of the premises that originally motivated
this patch are somewhat wrong, but it led to some simplifications anyway and I suspect
that we'll be able to fix those premises in the future. The main point of this patch is
to make it easy to reuse global variable constant inference for closure variable
constant inference, and this will be possible provided we can also either (a) infer
one-shot closures (easy) or (b) infer closure variables that are always assigned prior
to first use.

One of the things that this patch is meant to enable is constant inference for closure
variables that may be part of a multi-shot closure. Closure variables may be
instantiated multiple times, like:

function foo() {

var WIDTH = 45;
function bar() {

... use WIDTH ...

}
...

}

Even if foo() is called many times and WIDTH is assigned to multiple times, that
doesn't change the fact that it's a constant. The goal of closure variable constant
inference is to catch any case where a closure variable has been assigned at least once
and its value has never changed. This patch doesn't implement that, but it does change
global variable constant inference to have most of the powers needed to do that. Note
that most likely we will use this functionality only to implement constant inference
for one-shot closures, but the resulting machinery is still simpler than what we had
before.

This involves three changes:

The watchpoint object now contains the inferred value. This involves creating a new kind of watchpoint set, the VariableWatchpointSet. We will reuse this object for closure variables.

Writing to a variable that is watchpointed still involves these three states that we proceed through monotonically (Uninitialized->Initialized->Invalidated) but now, the Initialized->Invalidated state transition only happens if we change the variable's value, rather than store to the variable. Repeatedly storing the same value won't change the variable's state.

On 64-bit systems (the only systems on which we do concurrent JIT), you no longer need fancy fencing to get a consistent view of the watchpoint in the JIT. The state of the VariableWatchpointSet for the purposes of constant folding is entirely encapsulated in the VariableWatchpointSet::m_inferredValue. If that is JSValue() then you cannot fold (either because the set is uninitialized or because it's invalidated - doesn't matter which); on the other hand if the value is anything other than JSValue() then you can fold, and that's the value you fold to. Simple!

This also changes the way that DFG IR deals with variable watchpoints. It's now
oblivious to global variables. You install a watchpoint using VariableWatchpoint and
you notify write using NotifyWrite. Easy!

Note that this will requires some more tweaks because of the fact that op_enter will
store Undefined into every captured variable. Hence it won't even work for one-shot
closures. One-shot closures are easily fixed by introducing another state (so we'll
have Uninitialized->Undefined->Initialized->Invalidated). Multi-shot closures will
require static analysis. One-shot closures are clearly a higher priority.

GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/Instruction.h:
bytecode/VariableWatchpointSet.h: Added.

(JSC::VariableWatchpointSet::VariableWatchpointSet):
(JSC::VariableWatchpointSet::~VariableWatchpointSet):
(JSC::VariableWatchpointSet::inferredValue):
(JSC::VariableWatchpointSet::notifyWrite):
(JSC::VariableWatchpointSet::invalidate):
(JSC::VariableWatchpointSet::finalizeUnconditionally):
(JSC::VariableWatchpointSet::addressOfInferredValue):

bytecode/Watchpoint.h:
dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGNode.h:

(JSC::DFG::Node::hasRegisterPointer):
(JSC::DFG::Node::hasVariableWatchpointSet):
(JSC::DFG::Node::variableWatchpointSet):

dfg/DFGNodeType.h:
dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithMod):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGWatchpointCollectionPhase.cpp:

(JSC::DFG::WatchpointCollectionPhase::handle):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNotifyWrite):

jit/JIT.h:
jit/JITOperations.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emitNotifyWrite):
(JSC::JIT::emitPutGlobalVar):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitNotifyWrite):
(JSC::JIT::emitPutGlobalVar):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::addGlobalVar):
(JSC::JSGlobalObject::addFunction):

runtime/JSGlobalObject.h:
runtime/JSScope.h:

(JSC::ResolveOp::ResolveOp):

runtime/JSSymbolTableObject.h:

(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

runtime/SymbolTable.cpp:

(JSC::SymbolTableEntry::inferredValue):
(JSC::SymbolTableEntry::prepareToWatch):
(JSC::SymbolTableEntry::addWatchpoint):
(JSC::SymbolTableEntry::notifyWriteSlow):
(JSC::SymbolTable::visitChildren):
(JSC::SymbolTable::WatchpointCleanup::WatchpointCleanup):
(JSC::SymbolTable::WatchpointCleanup::~WatchpointCleanup):
(JSC::SymbolTable::WatchpointCleanup::finalizeUnconditionally):

runtime/SymbolTable.h:

(JSC::SymbolTableEntry::watchpointSet):
(JSC::SymbolTableEntry::notifyWrite):

6:13 PM Changeset in webkit [159797] by commit-queue@webkit.org

10 edits
5 adds in trunk

[MediaStream API] HTMLMediaElement should be able to use MediaStream as source
https://bugs.webkit.org/show_bug.cgi?id=121943

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-26
Reviewed by Eric Carlson.

Source/WebCore:

Implement MediaStream direct assignment to Media Elements using the new 'srcObject'
attribute: http://www.w3.org/TR/mediacapture-streams/#direct-assignment-to-media-elements

Test: fast/mediastream/MediaStream-MediaElement-srcObject.html

CMakeLists.txt: Added new HTMLMediaElementMediaStream.h and .cpp to cmake build.
DerivedSources.make: Added HTMLMediaElementMediaStream.idl.
GNUmakefile.list.am: Added new HTMLMediaElementMediaStream* to autotools build.
WebCore.xcodeproj/project.pbxproj: Added new files.
Modules/mediastream/HTMLMediaElementMediaStream.cpp: Added.

(WebCore::HTMLMediaElementMediaStream::srcObject): implements srcObject getter.
(WebCore::HTMLMediaElementMediaStream::setSrcObject): implements srcObject setter.

Modules/mediastream/HTMLMediaElementMediaStream.h: Added.
Modules/mediastream/HTMLMediaElementMediaStream.idl: Added.
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setSrcObject): This is an initial implementation, and
is still incomplete, that will be addressed in a separate bug: https://webkit.org/b/124896

html/HTMLMediaElement.h: Added m_mediaStreamSrcObject class variable

and its corresponding getter.

Source/WebKit2:

Add mediastream module and platform to cmake include directories.

CMakeLists.txt:

LayoutTests:

Add layout tests to MediaStream direct assignment to HTMLMediaElement
using brand new srcObject attribute.

fast/mediastream/MediaStream-MediaElement-srcObject-expected.txt: Added.
fast/mediastream/MediaStream-MediaElement-srcObject.html: Added.

5:27 PM Changeset in webkit [159796] by commit-queue@webkit.org

6 edits in trunk/Tools

Moved methods which belong to Checkout into checkout.py
https://bugs.webkit.org/show_bug.cgi?id=124889

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-26
Reviewed by Ryosuke Niwa.

Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.scripts_directory):
(Checkout):
(Checkout.script_path):
(Checkout.commit_message_for_this_commit):
(Checkout.apply_patch):

Scripts/webkitpy/common/checkout/checkout_unittest.py:

(test_commit_message_for_this_commit):
(CheckoutTest.test_apply_patch):

Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.absolute_path):

Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(SCMTest._setup_webkittools_scripts_symlink):

Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.create_patch):

5:22 PM Changeset in webkit [159795] by fpizlo@apple.com

8 edits in trunk/Source/JavaScriptCore

Create a new SymbolTable every time code is loaded so that the watchpoints don't get reused
https://bugs.webkit.org/show_bug.cgi?id=124824

Reviewed by Oliver Hunt.

This helps with one shot closure inference as well as closure variable constant
inference, since without this, if code was reloaded from the cache then we would
think that the first run was actually an Nth run. This would cause us to think that
the watchpoint(s) should all be invalidated.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::stronglyVisitStrongReferences):

bytecode/CodeBlock.h:

(JSC::CodeBlock::symbolTable):

runtime/Executable.cpp:

(JSC::FunctionExecutable::symbolTable):

runtime/Executable.h:
runtime/SymbolTable.cpp:

(JSC::SymbolTable::clone):

runtime/SymbolTable.h:

3:55 PM Changeset in webkit [159794] by Brent Fulgham

3 edits in trunk/Source/WebCore

Use child iterator to find operators in RenderMathMLRow::layout().
<https://webkit.org/b/124108>

Replace manual children walk with childrenOfType<RenderMathMLBlock>.
Minor update to fix build.

Patch by Andreas Kling <akling@apple.com> on 2013-11-26
Reviewed by Martin Robinson.

3:36 PM Changeset in webkit [159793] by akling@apple.com

3 edits in trunk/Source/WebCore

RenderObject: Inline isBody() and isHR().
<https://webkit.org/b/124901>

Together these account for ~0.3% of samples on HTML5-8266.
Almost all of it is call overhead.

Reviewed by Anders Carlsson.

3:05 PM Changeset in webkit [159792] by betravis@adobe.com

36 edits
6 adds in trunk

[CSS Shapes] Layout using [<box>

<shape>] value

https://bugs.webkit.org/show_bug.cgi?id=124428

Reviewed by David Hyatt.

Source/WebCore:

When a box value is supplied, use it to size and position the shape. Otherwise,
use a default value (content-box for shape-inside, margin-box for shape-outside).
This patch extends the sizing and positioning code used for the box patch (Bug 124227)
to also apply to shapes. With this patch, we also no longer use the box-sizing
property to size and position shapes.

Tests: fast/shapes/shape-outside-floats/shape-outside-shape-boxes-001.html

fast/shapes/shape-outside-floats/shape-outside-shape-boxes-002.html
fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): Adjust for ShapeValues storing
BasicShape::ReferenceBox as their box value, rather than a CSSValueID.

css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyShape::applyValue): Ditto.

rendering/shapes/ShapeInfo.h:

(WebCore::ShapeInfo::setShapeSize): Adjust for BasicShapes with reference boxes
as well as plain box values. Also, remove old box-sizing code.
(WebCore::ShapeInfo::logicalTopOffset): Ditto.
(WebCore::ShapeInfo::logicalLeftOffset): Ditto.

rendering/shapes/ShapeInsideInfo.h:
rendering/shapes/ShapeOutsideInfo.h:
rendering/style/ShapeValue.h:

(WebCore::ShapeValue::createBoxValue): Adjust for boxes being stored as
BasicShape::ReferenceBoxes.
(WebCore::ShapeValue::box): Ditto.
(WebCore::ShapeValue::ShapeValue): Ditto.

LayoutTests:

Adding tests to make sure that shapes properly size and position themselves across box values
and writing modes. Some shape-outside tests needed to be updated to explicitly size themselves
to content-box, as they were relying on that being the default value. Some shape-inside tests
needed to be adjusted as box-sizing no longer affects the shape size and position.

csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001.html:

Explicitly size to content-box.

csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-004.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-010.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-011.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-012.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-014.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-015.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-016.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-017.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-018.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html: Ditto.
fast/shapes/shape-inside/shape-inside-box-sizing-expected.html: Small test cleanup.
fast/shapes/shape-inside/shape-inside-box-sizing.html: Modify shapes to provide their sizing box.
fast/shapes/shape-inside/shape-inside-empty-expected.html: Small test cleanup.
fast/shapes/shape-inside/shape-inside-empty.html: Modify shapes to provide their sizing box.
fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html: Ditto.
fast/shapes/shape-outside-floats/shape-outside-shape-boxes-001-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-shape-boxes-001.html: Added.
fast/shapes/shape-outside-floats/shape-outside-shape-boxes-002-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-shape-boxes-002.html: Added.
fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003.html: Added.
inspector-protocol/model/highlight-shape-outside.html: Modify shapes to provide their sizing box.

2:58 PM Changeset in webkit [159791] by commit-queue@webkit.org

45 edits in trunk/Source/WebCore

ImageBuffer::create should return a std::unique_ptr instead of OwnPtr.
https://bugs.webkit.org/show_bug.cgi?id=124822

Patch by Brian J. Burg <Brian Burg> on 2013-11-26
Reviewed by Andreas Kling.

Replace all uses of OwnPtr<ImageBuffer> and PassOwnPtr<ImageBuffer> with
std::unique_ptr<ImageBuffer>. Replace calls to OwnPtr::clear() and
OwnPtr::release() with reset() and std::move(). Remove unnecessary includes.

No new tests. This is a mechanical refactoring.

css/CSSFilterImageValue.cpp:

(WebCore::CSSFilterImageValue::image):

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::setSurfaceSize):

html/HTMLCanvasElement.h:
html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

html/canvas/CanvasRenderingContext2D.h:
html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache):
(WebCore::WebGLRenderingContext::LRUImageBufferCache::imageBuffer):

html/canvas/WebGLRenderingContext.h:
html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

page/Frame.cpp:

(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):

platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::drawPattern):

platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::drawPattern):

platform/graphics/GradientImage.h:
platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::createCompatibleBuffer):

platform/graphics/GraphicsContext.h:
platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::createCompatibleBuffer):

platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::create):

platform/graphics/ShadowBlur.cpp:
platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::putByteArray):

platform/graphics/cg/PDFDocumentImage.h:
platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

platform/graphics/filters/Filter.h:

(WebCore::Filter::setSourceImage):

platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::clearResult):

platform/graphics/filters/FilterEffect.h:
platform/graphics/texmap/TextureMapper.cpp:

(WebCore::BitmapTexture::updateContents):

platform/graphics/texmap/TextureMapperImageBuffer.h:
rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintProgressBar):

rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::invalidateBufferedForeground):

rendering/svg/RenderSVGImage.h:
rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

rendering/svg/RenderSVGResourceClipper.h:
rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):

rendering/svg/RenderSVGResourceFilter.h:
rendering/svg/RenderSVGResourceGradient.cpp: Remove method parameter wrapping/indentation.

(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):
(WebCore::RenderSVGResourceGradient::applyResource):

rendering/svg/RenderSVGResourceGradient.h:
rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

rendering/svg/RenderSVGResourceMasker.h:
rendering/svg/RenderSVGResourcePattern.cpp: Remove method parameter wrapping/indentation.

(WebCore::RenderSVGResourcePattern::buildPattern):
(WebCore::RenderSVGResourcePattern::createTileImage):

rendering/svg/RenderSVGResourcePattern.h: Remove method parameter wrapping/indentation.
rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::createImageBuffer):
(WebCore::SVGRenderingContext::createImageBufferForPattern):
(WebCore::SVGRenderingContext::clipToImageBuffer):
(WebCore::SVGRenderingContext::bufferForeground):

rendering/svg/SVGRenderingContext.h:
svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::nativeImageForCurrentFrame):
(WebCore::SVGImage::drawPatternForContainer):

12:24 PM Changeset in webkit [159790] by oliver@apple.com

5 edits in trunk

Crash in JSC::ASTBuilder::Expression JSC::Parser<JSC::Lexer<unsigned char> >::parseUnaryExpression<JSC::ASTBuilder>(JSC::ASTBuilder&)
https://bugs.webkit.org/show_bug.cgi?id=124886

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Make sure the error macros propagate an existing error before
trying to create a new error message. We need to do this as
the parser state may not be safe for any specific error message
if we are already unwinding due to an error.

parser/Parser.cpp:

LayoutTests:

Add tests

js/parser-syntax-check-expected.txt:
js/script-tests/parser-syntax-check.js:

12:11 PM Changeset in webkit [159789] by eric.carlson@apple.com

3 edits
2 adds in trunk

video.currentSrc should return empty when no resource is loaded
https://bugs.webkit.org/show_bug.cgi?id=124898

Reviewed by Dan Bernstein.

Source/WebCore:

Test: media/video-currentsrc-cleared.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::prepareForLoad): Set m_currentSrc to empty in

preparation for attempting to load a new url.

LayoutTests:

media/video-currentsrc-cleared-expected.txt: Added.
media/video-currentsrc-cleared.html: Added.

12:07 PM Changeset in webkit [159788] by mitz@apple.com

31 edits in trunk/Source/WebKit2

Some WebKit2 headers are not self-contained
https://bugs.webkit.org/show_bug.cgi?id=124884

Reviewed by Anders Carlsson.

Shared/API/Cocoa/WKRemoteObjectInterface.h: Added import.
Shared/API/Cocoa/WKRemoteObjectRegistry.h: Ditto.
Shared/API/c/WKContextMenuItemTypes.h: Added include.
Shared/API/c/WKFindOptions.h: Ditto.
Shared/API/c/WKMutableArray.h: Ditto.
Shared/API/c/WKPageLoadTypes.h: Ditto.
Shared/API/c/WKPageVisibilityTypes.h: Ditto.

Shared/API/c/WKPluginInformation.cpp:

(WKPluginInformationBundleIdentifierKey): Made this API function always be defined. When
the Netscape plug-in API is not enabled, it returns 0.
(WKPluginInformationBundleVersionKey): Ditto.
(WKPluginInformationBundleShortVersionKey): Ditto.
(WKPluginInformationPathKey): Ditto.
(WKPluginInformationDisplayNameKey): Ditto.
(WKPluginInformationDefaultLoadPolicyKey): Ditto.
(WKPluginInformationUpdatePastLastBlockedVersionIsKnownAvailableKey): Ditto.
(WKPluginInformationHasSandboxProfileKey): Ditto.
(WKPluginInformationFrameURLKey): Ditto.
(WKPluginInformationMIMETypeKey): Ditto.
(WKPluginInformationPageURLKey): Ditto.
(WKPluginInformationPluginspageAttributeURLKey): Ditto.
(WKPluginInformationPluginURLKey): Ditto.
(WKPlugInInformationReplacementObscuredKey): Ditto.

Shared/API/c/WKString.h: Added include.
UIProcess/API/C/WKCredentialTypes.h: Ditto.
UIProcess/API/C/WKPageContextMenuClient.h: Ditto.
UIProcess/API/C/WKPageLoaderClient.h: Added includes.
UIProcess/API/C/WKPagePolicyClient.h: Ditto.
UIProcess/API/C/WKPageUIClient.h: Ditto.

UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerGetTypeID): Fixed the !ENABLE(NETSCAPE_PLUGIN_API) build.

UIProcess/API/C/mac/WKContextPrivateMac.h: Removed use of ENABLE() from this private

header.

UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextCopyPlugInInfoForBundleIdentifier): Made this API function always be defined.
When the Netscape plug-in API is not enabled, it returns 0.
(WKContextGetInfoForInstalledPlugIns): Made this API function always be defined.

UIProcess/API/C/mac/WKInspectorPrivateMac.h: Added imports.
UIProcess/API/C/mac/WKPagePrivateMac.h: Added include.
UIProcess/API/Cocoa/WKBackForwardListItem.h: Added import.
UIProcess/API/Cocoa/WKNavigationData.h: Ditto.
UIProcess/API/cpp/WKRetainPtr.h: Replaced use of WARN_UNUSED_RETURN in this private header

with an equivalent macro defined in the header.

WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: Added include.
WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:

(WKBundleInspectorGetTypeID): Made this API function always be defined. When the Inspector
is not enabled, it returns the Null type.
(WKBundleInspectorShow): Made this API function always be defined.
(WKBundleInspectorClose): Ditto.
(WKBundleInspectorEvaluateScriptForTest): Ditto.
(WKBundleInspectorSetPageProfilingEnabled): Ditto.

WebProcess/InjectedBundle/API/c/WKBundleInspector.h: Removed use of ENABLE() from this

private header.

WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Added includes.
WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Added include.

WebProcess/Plugins/Netscape/mac/WKNPAPIPlugInContainer.mm:

(-[WKNPAPIPlugInContainer openPlugInPreferencePane]): Fixed the !ENABLE(NETSCAPE_PLUGIN_API)
build.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createJavaAppletWidget): Ditto.

WebProcess/WebPage/mac/WebInspectorMac.mm: Fixed the !ENABLE(INSPECTOR) build.

11:19 AM Changeset in webkit [159787] by hmuller@adobe.com

5 edits
4 adds in trunk

[CSS Shapes] Support for shape-margin in BoxShape
https://bugs.webkit.org/show_bug.cgi?id=124788

Source/WebCore:

Reviewed by Andreas Kling.

Corrected BoxShape's internal shape-margin/padding bounds FloatRoundedRect
initialization. Tests for the padding bounds will be added when the rest of
shape-padding for box shapes implementation is ready.

Tests: fast/shapes/shape-outside-floats/shape-outside-margin-boxes-001.html

fast/shapes/shape-outside-floats/shape-outside-margin-boxes-002.html

rendering/shapes/BoxShape.cpp: Use constructor shape-margin,shape-padding parameters.

(WebCore::BoxShape::BoxShape):

rendering/shapes/BoxShape.h:
rendering/shapes/Shape.cpp:

(WebCore::createBoxShape): Pass the shape-margin and shape-padding values along to the BoxShape constructor.
(WebCore::Shape::createShape): Ditto.

LayoutTests:

Verify that shape-margin has the expected effect on the four possible shape-outside box values
for left and right floats.

Reviewed by Andreas Kling.

fast/shapes/shape-outside-floats/shape-outside-margin-boxes-001-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-margin-boxes-001.html: Added.
fast/shapes/shape-outside-floats/shape-outside-margin-boxes-002-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-margin-boxes-002.html: Added.

10:34 AM Changeset in webkit [159786] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove unnecessary webaudio include from MediaStreamSource header
https://bugs.webkit.org/show_bug.cgi?id=124897

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-26
Reviewed by Eric Carlson.

AudioDestinationConsumer.h is included but not used anywhere in
MediaStreamSource implementation.

platform/mediastream/MediaStreamSource.h:

9:47 AM Changeset in webkit [159785] by Gustavo Noronha Silva

2 edits in trunk/Source/WebCore/platform/gtk/po

Updated Brazilian Portuguese translation of WebKitGTK+ - November 02, 2013
https://bugs.webkit.org/show_bug.cgi?id=123694

Patch by Enrico Nicoletto <liverig@gmail.com> on 2013-11-26
Reviewed by Gustavo Noronha.

pt_BR.po: updated.

9:21 AM Changeset in webkit [159784] by Michał Pakuła vel Rutka

2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for failing accessibility tests.

platform/efl/TestExpectations:

9:10 AM Changeset in webkit [159783] by nrotem@apple.com

2 edits in trunk/Source/JavaScriptCore

Optimize away OR with zero - a common ASM.js pattern.
https://bugs.webkit.org/show_bug.cgi?id=124869

Reviewed by Filip Pizlo.

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

8:20 AM Changeset in webkit [159782] by akling@apple.com

2 edits in trunk/Source/WebCore

Avoid unnecessary copy-on-write in FillLayer style application.
<https://webkit.org/b/124878>

We ended up with a lot of cloned StyleBackgroundData objects on
HTML5-8266. This happened because we always forced a copy-on-write
when applying background-image:inherit / background-image:initial.

This patch adds early returns to both functions. In the "inherit"
case, we bail early if the target style already has the same fill
layer data as its parent style.

In the "initial" case, we optimize for the single-FillLayer case
and add an early return if the relevant value is either unset or
equal to the templatized initial value.

2.46 MB progression on HTML5-8266 locally.

Reviewed by Antti Koivisto.

6:09 AM Changeset in webkit [159781] by Michał Pakuła vel Rutka

4 edits in trunk/LayoutTests

Unreviewed ATK gardening

Rebaseline accessibility tests after r159747.

platform/efl-wk1/accessibility/table-detection-expected.txt:
platform/efl-wk2/accessibility/table-detection-expected.txt:
platform/gtk/accessibility/table-detection-expected.txt:

12:29 AM Changeset in webkit [159780] by Antoine Quint

6 edits in trunk/Source

Web Inspector: Allow showing a context menu on all mouse events.
https://bugs.webkit.org/show_bug.cgi?id=124747

Reviewed by Joseph Pecoraro.

Source/WebCore:

Add a new InspectorFrontendHost::dispatchEventAsContextMenuEvent(Event*) method
to let the inspector front-end dispatch a native contextmenu event that will allow
for a context menu to be shown from within a non-contextmenu event handler.

inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent):
Check that we're dealing with a mouse event, get the frame for the event target
and the event's location to call ContextMenuController::showContextMenuAt()
which will handle the new contextmenu event dispatch to the original event target.

inspector/InspectorFrontendHost.h:
inspector/InspectorFrontendHost.idl:

Source/WebInspectorUI:

Automatically dispatch a contextmenu event in case WebInspector.ContextMenu.prototype.show()
is called outside of a contextmenu event handler and would therefore not show the expected
context menu (except in the Remote Web Inspector where this already works).

UserInterface/ContextMenu.js:

(WebInspector.ContextMenu.prototype.show):
Check whether the event is a contextmenu event, and if not, add an event listener for a manually
dispatched contextmenu event such that we may then call InspectorFrontendHost.showContextMenu()
in a contextmenu event handler.

(WebInspector.ContextMenu.prototype.handleEvent):
Call InspectorFrontendHost.showContextMenu() now that we received the manually dispatched
contextmenu event.

Nov 25, 2013:

9:54 PM Changeset in webkit [159779] by weinig@apple.com

17 edits in trunk/Source/WebCore

Convert some Shape code to use references
https://bugs.webkit.org/show_bug.cgi?id=124876

Reviewed by Andreas Kling.

inspector/InspectorOverlay.cpp:
rendering/FloatingObjects.cpp:
rendering/LayoutState.cpp:
rendering/RenderBlock.cpp:
rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp:
rendering/RenderBox.cpp:
rendering/RenderBox.h:
rendering/line/BreakingContextInlineHeaders.h:
rendering/line/LineWidth.cpp:
rendering/shapes/ShapeInfo.cpp:
rendering/shapes/ShapeInfo.h:
rendering/shapes/ShapeInsideInfo.cpp:
rendering/shapes/ShapeInsideInfo.h:
rendering/shapes/ShapeOutsideInfo.cpp:
rendering/shapes/ShapeOutsideInfo.h:

Replace yet more pointers with references.

9:46 PM Changeset in webkit [159778] by ryuan.choi@samsung.com

2 edits in trunk

[EFL] E_DBus should be an optional
https://bugs.webkit.org/show_bug.cgi?id=124881

Reviewed by Gyuyoung Kim.

Source/cmake/OptionsEfl.cmake:

Checked E_DBus when only ENABLE_BATTERY_STATUS is on.

6:21 PM Changeset in webkit [159777] by Alexandru Chiculita

3 edits in trunk/Source/WebInspectorUI

Web Inspector: [CSS Regions] A page with many flows should collapse the resources tree
https://bugs.webkit.org/show_bug.cgi?id=122926

Reviewed by Timothy Hatcher.

Refactored the code in FrameTreeElement._shouldGroupIntoFolders to make it easy to track
more types of resources. Added the content flows as another type of resource that would trigger the
collapsing.

UserInterface/DOMTreeManager.js:

(WebInspector.DOMTreeManager.prototype.namedFlowRemoved): Added code to remove the content nodes from
a flow that has been removed.

UserInterface/FrameTreeElement.js:

(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushCategory):
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushResourceType):
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders):

6:16 PM Changeset in webkit [159776] by ryuan.choi@samsung.com

4 edits
1 delete in trunk

[EFL] Use Config mode of find_package for EFL 1.8
https://bugs.webkit.org/show_bug.cgi?id=124555

Reviewed by Gyuyoung Kim.

EFL 1.8 changed VERSION macro so it's difficult to use tricky approach
which parses header files to know the version. Instead, EFL 1.8 supports
FooConfig.cmake such as EinaConfig.cmake.

This patch tries to use a config mode if it is available.
If config mode is not available with Eo, FindFoo.cmake will be used without
version requirement.

Source/cmake/FindEo.cmake: Removed.

EoConfig.cmake is only preffered for EFL 1.8.

Source/cmake/OptionsEfl.cmake:

Tools:

MiniBrowser/efl/CMakeLists.txt:

Added optional config mode and made version requirement optional.

4:47 PM Changeset in webkit [159775] by mitz@apple.com

7 edits in trunk/Source/WebKit2

[Cocoa] Use class extensions for IPI
https://bugs.webkit.org/show_bug.cgi?id=124870

Reviewed by Sam Weinig.

UIProcess/API/mac/WKBrowsingContextController.mm: Reordered methods so that the Private

cateogry isn’t stuck between the API methods and the internal methods.
(-[WKBrowsingContextController setPaginationMode:]):
(-[WKBrowsingContextController paginationMode]):
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]):
(-[WKBrowsingContextController paginationBehavesLikeColumns]):
(-[WKBrowsingContextController setPageLength:]):
(-[WKBrowsingContextController pageLength]):
(-[WKBrowsingContextController setGapBetweenPages:]):
(-[WKBrowsingContextController gapBetweenPages]):
(-[WKBrowsingContextController pageCount]):
(-[WKBrowsingContextController handle]):

UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Changed Internal category into

a class extension.

UIProcess/API/mac/WKConnection.mm:
UIProcess/API/mac/WKConnectionInternal.h: Changed Internal category into a class

extension.

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h: Ditto.

4:21 PM Changeset in webkit [159774] by commit-queue@webkit.org

2 edits in trunk/Tools

[GTK] Search functionality in MiniBrowser provides feedback on search fail
https://bugs.webkit.org/show_bug.cgi?id=122681

Patch by Andres Gomez <Andres Gomez> on 2013-11-25
Reviewed by Mario Sanchez Prada.

When using the search functionality in MiniBrowser, if the search
fails, the entry background color gets red to report the user
about the failing condition. When the entry is cleaned or the
search is again succesful the background turns back to its
original color.

MiniBrowser/gtk/BrowserSearchBar.c:

(setFailedStyleForEntry): Added.
(doSearch): Sets the entry's background to its original style if
there is no text to search.
(findControllerFailedToFindTextCallback): Added.
(findControllerFoundTextCallback): Added.
(browser_search_bar_init): Creates and adds a new CSS provider to
the text entry so we can change its style based on the success
condition of the search.
(browserSearchBarFinalize): Frees the new CSS provider.
(browser_search_bar_new): Connects the two new handlers to the
"failed-to-find-text" and "found-text" signals emitted by the
WebKitFindController.

4:20 PM Changeset in webkit [159773] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Fixed the iOS build.

UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadDelegateInternal]):
(-[WKBrowsingContextController setLoadDelegateInternal:]):

3:55 PM Changeset in webkit [159772] by simon.pena@samsung.com

2 edits in trunk/Source/WebCore

[EFL] X11Helper::createPixmap doesn't initialise out value handleId
https://bugs.webkit.org/show_bug.cgi?id=124722

Reviewed by Gyuyoung Kim.

The overloaded functions X11Helper::createPixmap don't initialise out
value handleId, and they do early returns on error situations. Since
the functions are void and they don't communicate their failure in any
way, returning an out value without initialising it could make the
error go farther unnoticed. With the variable being initialised, it can
be reliably checked for errors when the function returns.

platform/graphics/surfaces/glx/X11Helper.cpp:

(WebCore::X11Helper::createPixmap): Initialise handleId to 0.

3:50 PM Changeset in webkit [159771] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

Mark URLRegistry's lookup() as const and its child classes as final
https://bugs.webkit.org/show_bug.cgi?id=124865

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.

No new tests needed. No behavior changes.

Modules/mediasource/MediaSourceRegistry.cpp:

(WebCore::MediaSourceRegistry::lookup): marked as const.

Modules/mediasource/MediaSourceRegistry.h: MediaSourceRegistry

marked as final.

Modules/mediastream/MediaStreamRegistry.cpp:

(WebCore::MediaStreamRegistry::lookup): marked as const.

Modules/mediastream/MediaStreamRegistry.h: MediaStreamRegistry

marked as final.

fileapi/Blob.cpp:
html/URLRegistry.h: lookup() marked as const.

(WebCore::URLRegistry::lookup): marked as const.

3:50 PM Changeset in webkit [159770] by mitz@apple.com

9 edits in trunk/Source/WebKit2

[Cocoa] Remove some indirection that was only necessary for supporting the legacy Objective-C runtime
https://bugs.webkit.org/show_bug.cgi?id=123065

Reviewed by Sam Weinig.

UIProcess/API/mac/WKBrowsingContextController.h: Removed _data ivar and

WKBrowsingContextControllerData class declaration.

UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController dealloc]): Removed
WKBrowsingContextControllerData class and moved ivars directly into
WKBrowsingContextController, declaring them in the @implementation. Removed ivar and
accessors for the delegate properties, letting the compiler synthesize them.
(-[WKBrowsingContextController _pageRef]): Removed indirection via _data.
(-[WKBrowsingContextController loadRequest:userData:]): Removed indirection via -_pageRef.
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]): Ditto.
(-[WKBrowsingContextController loadHTMLString:baseURL:userData:]): Ditto.
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]): Ditto.
(-[WKBrowsingContextController stopLoading]): Ditto.
(-[WKBrowsingContextController reload]): Ditto.
(-[WKBrowsingContextController reloadFromOrigin]): Ditto.
(-[WKBrowsingContextController goForward]): Ditto.
(-[WKBrowsingContextController canGoForward]): Ditto.
(-[WKBrowsingContextController goBack]): Ditto.
(-[WKBrowsingContextController canGoBack]): Ditto.
(-[WKBrowsingContextController goToBackForwardListItem:]): Ditto.
(-[WKBrowsingContextController backForwardList]): Ditto.
(-[WKBrowsingContextController activeURL]): Ditto.
(-[WKBrowsingContextController provisionalURL]): Ditto.
(-[WKBrowsingContextController committedURL]): Ditto.
(-[WKBrowsingContextController unreachableURL]): Removed idirection via _data.
(-[WKBrowsingContextController estimatedProgress]): Removed indirection via -_pageRef.
(-[WKBrowsingContextController title]): Ditto.
(-[WKBrowsingContextController textZoom]): Ditto.
(-[WKBrowsingContextController setTextZoom:]): Ditto.
(-[WKBrowsingContextController pageZoom]): Ditto.
(-[WKBrowsingContextController setPageZoom:]): Ditto.
(-[WKBrowsingContextController setPaginationMode:]): Ditto.
(-[WKBrowsingContextController paginationMode]): Ditto.
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]): Ditto.
(-[WKBrowsingContextController paginationBehavesLikeColumns]): Ditto.
(-[WKBrowsingContextController setPageLength:]): Ditto.
(-[WKBrowsingContextController pageLength]): Ditto.
(-[WKBrowsingContextController setGapBetweenPages:]): Ditto.
(-[WKBrowsingContextController gapBetweenPages]): Ditto.
(-[WKBrowsingContextController pageCount]): Ditto.
(-[WKBrowsingContextController handle]): Ditto.
(-[WKBrowsingContextController _initWithPageRef:]): Removed indirection via _data.

UIProcess/API/mac/WKBrowsingContextGroup.h: Removed _data ivar and

WKBrowsingContextGroupData class declaration.

UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed WKBrowsingContextGroupData class and

moved _pageGroupRef ivar directly into WKBrowsingContextGroup, declaring it in the
@implementation.
(-[WKBrowsingContextGroup initWithIdentifier:]): Removed indirection via _data.
(-[WKBrowsingContextGroup allowsJavaScript]): Removed indirection via -_pageGroupRef.
(-[WKBrowsingContextGroup setAllowsJavaScript:]): Ditto.
(-[WKBrowsingContextGroup allowsJavaScriptMarkup]): Ditto.
(-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]): Ditto.
(-[WKBrowsingContextGroup allowsPlugIns]): Ditto.
(-[WKBrowsingContextGroup setAllowsPlugIns:]): Ditto.
(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]): Ditto.
(-[WKBrowsingContextGroup removeAllUserStyleSheets]): Ditto.
(-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]): Ditto.
(-[WKBrowsingContextGroup removeAllUserScripts]): Ditto.
(-[WKBrowsingContextGroup _pageGroupRef]): Removed indirection via _data.

UIProcess/API/mac/WKConnection.h: Removed _data ivar and WKConnectionData class declaration.
UIProcess/API/mac/WKConnection.mm: Removed WKConnectionData class and moved _connectionRef

ivar directly into WKConnection, declaring it in the @implementation. Removed ivar and
accessors for the delegate property, letting the compiler synthesize them.
(-[WKConnection dealloc]): Removed indirection via _data.
(-[WKConnection sendMessageWithName:body:]): Ditto.
(-[WKConnection remoteObjectRegistry]): Ditto.
(didReceiveMessage): Ditto.
(-[WKConnection _initWithConnectionRef:]): Ditto.

UIProcess/API/mac/WKProcessGroup.h: Replaced forward declaration of WKConnection with an

import. Removed _data ivar and WKProcessGroupData class declaration.

UIProcess/API/mac/WKProcessGroup.mm: Removed WKProcessGroupData class and moved

_contextRef ivar directly into WKProcessGroup, declaring it in the @implementation. Removed
ivar and accessors for the delegate property, letting the compiler synthesize them.
(-[WKProcessGroup initWithInjectedBundleURL:]): Removed indirection via _data.
(-[WKProcessGroup dealloc]): Ditto.
(-[WKProcessGroup _contextRef]): Ditto.
(-[WKProcessGroup _geolocationProvider]): Ditto.

3:21 PM Changeset in webkit [159769] by commit-queue@webkit.org

14 edits in trunk/Source/WebCore

[MediaStream] Use std::unique_ptr instead of OwnPtr/PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=124858

Patch by Sergio Correia <Sergio Correia> on 2013-11-25
Reviewed by Eric Carlson.

Another step of the OwnPtr/PassOwnPtr => std::unique_ptr conversion,
now targeting mediastream-related code.

No new tests, covered by existing ones.

Modules/mediastream/RTCDTMFSender.cpp:
Modules/mediastream/RTCDTMFSender.h:
Modules/mediastream/RTCDataChannel.cpp:
Modules/mediastream/RTCDataChannel.h:
Modules/mediastream/RTCPeerConnection.cpp:
Modules/mediastream/RTCPeerConnection.h:
platform/mediastream/MediaStreamSource.cpp:
platform/mediastream/RTCPeerConnectionHandler.cpp:
platform/mediastream/RTCPeerConnectionHandler.h:
platform/mediastream/RTCPeerConnectionHandlerClient.h:
platform/mock/RTCNotifiersMock.cpp:
platform/mock/RTCPeerConnectionHandlerMock.cpp:
platform/mock/RTCPeerConnectionHandlerMock.h:

3:08 PM Changeset in webkit [159768] by commit-queue@webkit.org

5 edits
1 add in trunk/Source/WebKit

[Win] WebKit version in user agent string is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=124454

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-25
Reviewed by Brent Fulgham.

Source/WebKit:

Generate WebKitVersion.h file from mac's Version.xcconfig file.

WebKit.vcxproj/WebKit/WebKit.vcxproj:
WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
WebKit.vcxproj/WebKit/WebKitVersion.cmd: Added.

Source/WebKit/win:

WebView.cpp: Use WebKit version from WebKitVersion.h in user agent.

(webKitVersionString):

2:55 PM Changeset in webkit [159767] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

MediaStreamRegistry should store MediaStreams instead of MediaStreamPrivates
https://bugs.webkit.org/show_bug.cgi?id=124860

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.

MediaStreamRegistry::lookup() should return a MediaStream instead of MediaStreamPrivate.

No new tests needed. No behavior changes.

Modules/mediastream/MediaStreamRegistry.cpp:

(WebCore::MediaStreamRegistry::registerURL): m_privateStreams -> m_mediaStreams
(WebCore::MediaStreamRegistry::unregisterURL): Ditto.
(WebCore::MediaStreamRegistry::lookup): Override URLRegistry::lookup() instead of add a
new method MediaStream::lookupMediaStreamPrivate().

Modules/mediastream/MediaStreamRegistry.h:
html/HTMLMediaElement.cpp:

(HTMLMediaElement::loadResource): call lookup() instead of lookupMediaStreamPrivate()

2:08 PM Changeset in webkit [159766] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[WinCairo] Compile fails when GSTREAMER is not used.
https://bugs.webkit.org/show_bug.cgi?id=124853

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-25
Reviewed by Philippe Normand.

platform/graphics/gstreamer/GStreamerUtilities.cpp: Don't include GStreamerUtilities.h when GSTREAMER is not used.

2:02 PM Changeset in webkit [159765] by commit-queue@webkit.org

21 edits in trunk/Source/WebKit2

Unreviewed, rolling out r159740.
http://trac.webkit.org/changeset/159740
https://bugs.webkit.org/show_bug.cgi?id=124859

Crashing xmlhttprequest/access-control-repeated-failed-
preflight-crash.html on Mavericks and Mountain Lion -
ASSERT(m_pageGroup) WebPage.cpp:352 (Requested by dino_ on
#webkit).

Scripts/webkit2/messages.py:

(struct_or_class):

Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
Shared/mac/ObjCObjectGraphCoders.h:
Shared/mac/ObjCObjectGraphCoders.mm:

(WebKit::ObjCObjectGraphEncoder::baseEncode):
(WebKit::WebContextObjCObjectGraphEncoderImpl::WebContextObjCObjectGraphEncoderImpl):
(WebKit::WebContextObjCObjectGraphEncoderImpl::encode):
(WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode):
(WebKit::WebContextObjCObjectGraphEncoder::WebContextObjCObjectGraphEncoder):
(WebKit::WebContextObjCObjectGraphEncoder::encode):

UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::encodeMessageBody):

UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::didReceiveSyncMessage):

UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):

UIProcess/WebPageGroup.cpp:
UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::sendToAllProcessesInGroup):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::postMessageToInjectedBundle):
(WebKit::WebPageProxy::initializeCreationParameters):

UIProcess/WebPageProxy.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::createWebPage):

UIProcess/WebProcessProxy.h:
WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::webPageGroup):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

1:53 PM Changeset in webkit [159764] by akling@apple.com

3 edits in trunk/Source/WebCore

Deduplicate shortish Text node strings during tree construction.
<https://webkit.org/b/124855>

Let HTMLConstructionSite keep a hash set of already seen strings over
its lifetime. Use this to deduplicate the strings inside Text nodes
for any string up to 64 characters of length.

This optimization already sort-of existed for whitespace-only Texts,
but those are laundered in the AtomicString table which we definitely
don't want to pollute with every single Text. It might be a good idea
to stop using the AtomicString table for all-whitespace Text too.

3.82 MB progression on HTML5-8266 locally.

Reviewed by Anders Carlsson.

1:36 PM Changeset in webkit [159763] by dino@apple.com

2 edits in trunk/LayoutTests

RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Skipping these tests for now, since Ossy + Laszlo checked
in a lot of rebaselines and I didn't want to roll
everything out.

TestExpectations:

1:29 PM Changeset in webkit [159762] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove unnecessary MediaStreamTrackDescriptor forward declaration
https://bugs.webkit.org/show_bug.cgi?id=124854

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.

No new tests needed. No behavior changed.

Modules/mediastream/VideoStreamTrack.h:

12:53 PM Changeset in webkit [159761] by mitz@apple.com

1 edit in trunk/Source/WebKit2/ChangeLog

Fixed a typo in the change log.

12:52 PM Changeset in webkit [159760] by mitz@apple.com

52 edits in trunk

[Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
https://bugs.webkit.org/show_bug.cgi?id=124850

Reviewed by Brady Eidson.

Source/WebKit2:

Guarded all Cocoa API headers and implementatiosn with WK_API_ENABLED. Left the WKView class
unguarded, but limited its API.

Shared/API/Cocoa/WKFoundation.h: Replaced OBJ_VISIBLE with an explicit attribute.
Shared/API/Cocoa/WKRemoteObjectCoder.mm: Moved #if WK_API_ENABLED before the rest of the

imports.

Shared/API/Cocoa/WKRemoteObjectInterface.mm: Ditto.
Shared/API/Cocoa/WKRemoteObjectRegistry.mm: Ditto.
Shared/API/Cocoa/WKRemoteObjectRegistryPrivate.h: Ditto.
UIProcess/API/mac/WKBrowsingContextController.h: Guarded all declarations with

WK_API_ENABLED, changed to use WK_API_CLASS instead of WK_EXPORT.

UIProcess/API/mac/WKBrowsingContextController.mm: Guarded everything with WK_API_ENABLED.

(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController setPolicyDelegate:]):
(-[WKBrowsingContextController backForwardList]):
(didChangeBackForwardList):
(setUpPageLoaderClient):
(setUpPagePolicyClient):
(-[WKBrowsingContextController _initWithPageRef:]):

UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Ditto.
UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Ditto.
UIProcess/API/mac/WKBrowsingContextGroup.h: Guarded all declarations with WK_API_ENABLED,

chanegd to use WK_API_CLASS instead of WK_EXPORT.

UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed redundant import, guarded everything

with WK_API_ENABLED.

UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Guarded with WK_API_ENABLED.
UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Added necessary import.
UIProcess/API/mac/WKConnection.h: Guarded all declarations with WK_API_ENABLED, chanegd to

use WK_API_CLASS instead of WK_EXPORT.

UIProcess/API/mac/WKConnection.mm: Guarded everything with WK_API_ENABLED.

(-[WKConnection remoteObjectRegistry]):
(didReceiveMessage):

UIProcess/API/mac/WKConnectionInternal.h: Guarded the delcarations with WK_API_ENABLED.
UIProcess/API/mac/WKProcessGroup.h: Ditto. Also changed to use WK_API_CLASS instead of

WK_EXPORT.

UIProcess/API/mac/WKProcessGroup.mm: Guarded everything with WK_API_ENABLED.

(-[WKProcessGroup initWithInjectedBundleURL:]):

UIProcess/API/mac/WKProcessGroupPrivate.h: Guarded the declarations with WK_API_ENABLED.
UIProcess/API/mac/WKTypeRefWrapper.h: Moved #if WK_API_ENABLED before the rest of the

imports, changed to use WK_API_CLASS instead of WK_EXPORT.

UIProcess/API/mac/WKTypeRefWrapper.mm: Removed empty line after #import "config.h".
UIProcess/API/mac/WKView.h: Added #if WK_API_ENABLED around API that uses other Cocoa API

types.

UIProcess/API/mac/WKView.mm: Added #if WK_API_ENABLED around implementations of methods

that are only declared when the API is enabled.

UIProcess/API/mac/WKViewInternal.h: Reordered imports.
UIProcess/mac/WKFullScreenWindowController.mm: Added comment to #endif.
UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess): Guarded use of
WKBrowsingContextController with WK_API_ENABLED.
(WebKit::WebContext::platformInitializeNetworkProcess): Ditto.

UIProcess/mac/WebContextMenuProxyMac.mm: Removed newline between imports.
WebProcess/InjectedBundle/API/mac/WKDOMDocument.h: Moved #if WK_API_ENABLED before the

rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.

WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm: Removed newline after #import

"config.h".

WebProcess/InjectedBundle/API/mac/WKDOMElement.h: Moved #if WK_API_ENABLED before the

rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.

WebProcess/InjectedBundle/API/mac/WKDOMElement.mm: Removed newline after #import

"config.h".

WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm: Ditto.
WebProcess/InjectedBundle/API/mac/WKDOMNode.h: Moved #if WK_API_ENABLED before the

rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.

WebProcess/InjectedBundle/API/mac/WKDOMNode.mm: Removed redundant import.
WebProcess/InjectedBundle/API/mac/WKDOMRange.h: Moved #if WK_API_ENABLED before the

rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.

WebProcess/InjectedBundle/API/mac/WKDOMRange.mm: Removed newline and redundant import.
WebProcess/InjectedBundle/API/mac/WKDOMText.h: Moved #if WK_API_ENABLED before the

rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.

WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h: Ditto.
WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm: Removed newline after

#import "config.h".

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h: Moved #if WK_API_ENABLED before

the rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm: Removed newline and redundant

imports.

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h: Moved #if

WK_API_ENABLED before the rest of the imports, and changed to use WK_API_CLASS instead of
WK_EXPORT.

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm: Removed

newline after #import "config.h".

Tools:

Added #if WK_API_ENABLED guards around tests that use the Objective-C API.

TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:

11:10 AM Changeset in webkit [159759] by mitz@apple.com

2 edits in trunk/Source/WebInspectorUI

Set the svn:ignore property on the Xcode project to ignore the workspace and user data.

WebInspectorUI.xcodeproj: Added property svn:ignore.

10:50 AM Changeset in webkit [159758] by robert@webkit.org

2 edits in trunk/Source/WebCore

Remove code now unnecessary after r159575
https://bugs.webkit.org/show_bug.cgi?id=124809

Reviewed by Antti Koivisto.

Covered by existing tests fast/block/margin-collapse/self-collapsing-block-with-float*

rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::skipLeadingWhitespace):

10:46 AM Changeset in webkit [159757] by robert@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add complex line layout path version of empty-clear-blocks.html
https://bugs.webkit.org/show_bug.cgi?id=124808

Reviewed by Sam Weinig.

fast/block/margin-collapse/empty-clear-blocks-complex-expected.html: Added.
fast/block/margin-collapse/empty-clear-blocks-complex.html: Added.

10:41 AM Changeset in webkit [159756] by commit-queue@webkit.org

3 edits
1 add in trunk/Tools

Unreviewed, rolling out r159752 and r159754.
http://trac.webkit.org/changeset/159752
http://trac.webkit.org/changeset/159754
https://bugs.webkit.org/show_bug.cgi?id=124847

Broke linux test bots. (Requested by mhahnenberg on #webkit).

Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
Scripts/run-javascriptcore-tests:
Scripts/run-jsc-stress-tests:

10:24 AM Changeset in webkit [159755] by Csaba Osztrogonác

20 edits in trunk/LayoutTests

Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Rebaseline the rest of EFL and GTK tests.

platform/efl/tables/mozilla/bugs/bug10296-1-expected.txt:
platform/efl/tables/mozilla/bugs/bug26178-expected.txt:
platform/efl/tables/mozilla/bugs/bug27038-1-expected.txt:
platform/efl/tables/mozilla/bugs/bug278385-expected.txt:
platform/efl/tables/mozilla/bugs/bug55789-expected.txt:
platform/efl/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
platform/efl/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
platform/efl/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
platform/efl/tables/mozilla_expected_failures/core/captions1-expected.txt:
platform/efl/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
platform/efl/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
platform/efl/tables/mozilla_expected_failures/other/test4-expected.txt:
platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:

10:02 AM Changeset in webkit [159754] by mhahnenberg@apple.com

2 edits in trunk/Tools

Followup fix after r159752

Scripts/run-jsc-stress-tests: We need to handle Release builds too.

9:34 AM Changeset in webkit [159753] by Csaba Osztrogonác

265 edits
1 add in trunk/LayoutTests

Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Rebaseline efl tests (+mac corrections).

platform/efl/fast/forms/input-align-expected.png:
platform/efl/fast/forms/input-align-expected.txt:
platform/efl/fast/forms/input-value-expected.png:
platform/efl/fast/forms/input-value-expected.txt:
platform/efl/fast/table/border-collapsing/004-vertical-expected.png:
platform/efl/fast/table/border-collapsing/004-vertical-expected.txt:
platform/efl/fast/table/floating-th-expected.png:
platform/efl/fast/table/floating-th-expected.txt:
platform/efl/fast/table/frame-and-rules-expected.png:
platform/efl/fast/table/frame-and-rules-expected.txt:
platform/efl/fast/table/multiple-captions-display-expected.png:
platform/efl/fast/table/multiple-captions-display-expected.txt:
platform/efl/fast/table/rowindex-expected.png:
platform/efl/fast/table/rowindex-expected.txt:
platform/efl/fast/table/table-display-types-expected.png:
platform/efl/fast/table/table-display-types-expected.txt:
platform/efl/fast/table/table-display-types-strict-expected.png:
platform/efl/fast/table/table-display-types-strict-expected.txt:
platform/efl/fast/table/table-display-types-vertical-expected.png:
platform/efl/fast/table/table-display-types-vertical-expected.txt:
platform/efl/tables/mozilla/bugs/bug119786-expected.png:
platform/efl/tables/mozilla/bugs/bug119786-expected.txt:
platform/efl/tables/mozilla/bugs/bug13118-expected.png:
platform/efl/tables/mozilla/bugs/bug13118-expected.txt:
platform/efl/tables/mozilla/bugs/bug19061-1-expected.png:
platform/efl/tables/mozilla/bugs/bug19061-1-expected.txt:
platform/efl/tables/mozilla/bugs/bug19061-2-expected.png:
platform/efl/tables/mozilla/bugs/bug19061-2-expected.txt:
platform/efl/tables/mozilla/bugs/bug220536-expected.png:
platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
platform/efl/tables/mozilla/bugs/bug27038-2-expected.png:
platform/efl/tables/mozilla/bugs/bug27038-2-expected.txt:
platform/efl/tables/mozilla/bugs/bug27038-3-expected.png:
platform/efl/tables/mozilla/bugs/bug27038-3-expected.txt: Added.
platform/efl/tables/mozilla/bugs/bug30418-expected.png:
platform/efl/tables/mozilla/bugs/bug30418-expected.txt:
platform/efl/tables/mozilla/bugs/bug3263-expected.png:
platform/efl/tables/mozilla/bugs/bug3263-expected.txt:
platform/efl/tables/mozilla/bugs/bug38916-expected.png:
platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
platform/efl/tables/mozilla/bugs/bug46268-3-expected.png:
platform/efl/tables/mozilla/bugs/bug46268-3-expected.txt:
platform/efl/tables/mozilla/bugs/bug46268-5-expected.png:
platform/efl/tables/mozilla/bugs/bug46268-5-expected.txt:
platform/efl/tables/mozilla/bugs/bug46268-expected.png:
platform/efl/tables/mozilla/bugs/bug46268-expected.txt:
platform/efl/tables/mozilla/bugs/bug46924-expected.png:
platform/efl/tables/mozilla/bugs/bug46924-expected.txt:
platform/efl/tables/mozilla/bugs/bug57378-expected.png:
platform/efl/tables/mozilla/bugs/bug57378-expected.txt:
platform/efl/tables/mozilla/dom/appendTbodyExpand1-expected.png:
platform/efl/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
platform/efl/tables/mozilla/marvin/backgr_position-table-expected.png:
platform/efl/tables/mozilla/marvin/backgr_position-table-expected.txt:
platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.png:
platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.txt:
platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
platform/efl/tables/mozilla/marvin/body_tfoot-expected.png:
platform/efl/tables/mozilla/marvin/body_tfoot-expected.txt:
platform/efl/tables/mozilla/marvin/body_thead-expected.png:
platform/efl/tables/mozilla/marvin/body_thead-expected.txt:
platform/efl/tables/mozilla/marvin/table_rules_groups-expected.png:
platform/efl/tables/mozilla/marvin/table_rules_groups-expected.txt:
platform/efl/tables/mozilla/marvin/tbody_align_center-expected.png:
platform/efl/tables/mozilla/marvin/tbody_align_center-expected.txt:
platform/efl/tables/mozilla/marvin/tbody_align_char-expected.png:
platform/efl/tables/mozilla/marvin/tbody_align_char-expected.txt:
platform/efl/tables/mozilla/marvin/tbody_align_justify-expected.png:
platform/efl/tables/mozilla/marvin/tbody_align_justify-expected.txt:
platform/efl/tables/mozilla/marvin/tbody_align_left-expected.png:
platform/efl/tables/mozilla/marvin/tbody_align_left-expected.txt:
platform/efl/tables/mozilla/marvin/tbody_align_right-expected.png:
platform/efl/tables/mozilla/marvin/tbody_align_right-expected.txt:
platform/efl/tables/mozilla/marvin/tbody_char-expected.png:
platform/efl/tables/mozilla/marvin/tbody_char-expected.txt:
platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.txt:
platform/efl/tables/mozilla/marvin/tfoot_align_center-expected.png:
platform/efl/tables/mozilla/marvin/tfoot_align_center-expected.txt:
platform/efl/tables/mozilla/marvin/tfoot_align_char-expected.png:
platform/efl/tables/mozilla/marvin/tfoot_align_char-expected.txt:
platform/efl/tables/mozilla/marvin/tfoot_align_justify-expected.png:
platform/efl/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
platform/efl/tables/mozilla/marvin/tfoot_align_left-expected.png:
platform/efl/tables/mozilla/marvin/tfoot_align_left-expected.txt:
platform/efl/tables/mozilla/marvin/tfoot_align_right-expected.png:
platform/efl/tables/mozilla/marvin/tfoot_align_right-expected.txt:
platform/efl/tables/mozilla/marvin/tfoot_char-expected.png:
platform/efl/tables/mozilla/marvin/tfoot_char-expected.txt:
platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
platform/efl/tables/mozilla/marvin/thead_align_center-expected.png:
platform/efl/tables/mozilla/marvin/thead_align_center-expected.txt:
platform/efl/tables/mozilla/marvin/thead_align_char-expected.png:
platform/efl/tables/mozilla/marvin/thead_align_char-expected.txt:
platform/efl/tables/mozilla/marvin/thead_align_justify-expected.png:
platform/efl/tables/mozilla/marvin/thead_align_justify-expected.txt:
platform/efl/tables/mozilla/marvin/thead_align_left-expected.png:
platform/efl/tables/mozilla/marvin/thead_align_left-expected.txt:
platform/efl/tables/mozilla/marvin/thead_align_right-expected.png:
platform/efl/tables/mozilla/marvin/thead_align_right-expected.txt:
platform/efl/tables/mozilla/marvin/thead_char-expected.png:
platform/efl/tables/mozilla/marvin/thead_char-expected.txt:
platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.txt:
platform/efl/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/efl/tables/mozilla/marvin/thead_valign_top-expected.txt:
platform/efl/tables/mozilla/marvin/x_table-expected.png:
platform/efl/tables/mozilla/marvin/x_table-expected.txt:
platform/efl/tables/mozilla/marvin/x_table_border-expected.png:
platform/efl/tables/mozilla/marvin/x_table_border-expected.txt:
platform/efl/tables/mozilla/marvin/x_table_border_none-expected.png:
platform/efl/tables/mozilla/marvin/x_table_border_none-expected.txt:
platform/efl/tables/mozilla/marvin/x_table_border_px-expected.png:
platform/efl/tables/mozilla/marvin/x_table_border_px-expected.txt:
platform/efl/tables/mozilla/marvin/x_table_frame_void-expected.png:
platform/efl/tables/mozilla/marvin/x_table_frame_void-expected.txt:
platform/efl/tables/mozilla/marvin/x_tbody_align_center-expected.png:
platform/efl/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
platform/efl/tables/mozilla/marvin/x_tbody_align_char-expected.png:
platform/efl/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
platform/efl/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
platform/efl/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
platform/efl/tables/mozilla/marvin/x_tbody_align_left-expected.png:
platform/efl/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
platform/efl/tables/mozilla/marvin/x_tbody_align_right-expected.png:
platform/efl/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
platform/efl/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
platform/efl/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
platform/efl/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
platform/efl/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
platform/efl/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
platform/efl/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
platform/efl/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
platform/efl/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
platform/efl/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
platform/efl/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
platform/efl/tables/mozilla/marvin/x_tfoot_class-expected.png:
platform/efl/tables/mozilla/marvin/x_tfoot_class-expected.txt:
platform/efl/tables/mozilla/marvin/x_tfoot_id-expected.png:
platform/efl/tables/mozilla/marvin/x_tfoot_id-expected.txt:
platform/efl/tables/mozilla/marvin/x_tfoot_style-expected.png:
platform/efl/tables/mozilla/marvin/x_tfoot_style-expected.txt:
platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
platform/efl/tables/mozilla/marvin/x_thead_align_center-expected.png:
platform/efl/tables/mozilla/marvin/x_thead_align_center-expected.txt:
platform/efl/tables/mozilla/marvin/x_thead_align_char-expected.png:
platform/efl/tables/mozilla/marvin/x_thead_align_char-expected.txt:
platform/efl/tables/mozilla/marvin/x_thead_align_justify-expected.png:
platform/efl/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
platform/efl/tables/mozilla/marvin/x_thead_align_left-expected.png:
platform/efl/tables/mozilla/marvin/x_thead_align_left-expected.txt:
platform/efl/tables/mozilla/marvin/x_thead_align_right-expected.png:
platform/efl/tables/mozilla/marvin/x_thead_align_right-expected.txt:
platform/efl/tables/mozilla/marvin/x_thead_class-expected.png:
platform/efl/tables/mozilla/marvin/x_thead_class-expected.txt:
platform/efl/tables/mozilla/marvin/x_thead_id-expected.png:
platform/efl/tables/mozilla/marvin/x_thead_id-expected.txt:
platform/efl/tables/mozilla/marvin/x_thead_style-expected.png:
platform/efl/tables/mozilla/marvin/x_thead_style-expected.txt:
platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.png:
platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
platform/efl/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
platform/efl/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
platform/efl/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
platform/efl/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
platform/efl/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
platform/efl/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
platform/efl/tables/mozilla_expected_failures/bugs/bug8499-expected.png:
platform/efl/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.png:
platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
platform/mac-mountainlion/fast/forms/input-value-expected.txt:
platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt:
platform/mac/fast/forms/input-value-expected.txt:

9:29 AM Changeset in webkit [159752] by mhahnenberg@apple.com

3 edits
1 delete in trunk/Tools

run-jsc-stress-tests should be able to package its tests and move them places
https://bugs.webkit.org/show_bug.cgi?id=124549

Reviewed by Filip Pizlo.

Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation

of grep -i -q

Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.

9:02 AM Changeset in webkit [159751] by Csaba Osztrogonác

271 edits
1 add in trunk/LayoutTests

Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Rebase GTK results after r159747.

platform/gtk/fast/forms/input-value-expected.png:
platform/gtk/fast/forms/input-value-expected.txt:
platform/gtk/fast/table/011-expected.txt:
platform/gtk/fast/table/border-collapsing/004-expected.txt:
platform/gtk/fast/table/border-collapsing/004-vertical-expected.png:
platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
platform/gtk/fast/table/floating-th-expected.png:
platform/gtk/fast/table/floating-th-expected.txt:
platform/gtk/fast/table/frame-and-rules-expected.png:
platform/gtk/fast/table/frame-and-rules-expected.txt:
platform/gtk/fast/table/rowindex-expected.png:
platform/gtk/fast/table/rowindex-expected.txt:
platform/gtk/fast/table/table-display-types-expected.png:
platform/gtk/fast/table/table-display-types-expected.txt:
platform/gtk/fast/table/table-display-types-strict-expected.png:
platform/gtk/fast/table/table-display-types-strict-expected.txt:
platform/gtk/fast/table/table-display-types-vertical-expected.png:
platform/gtk/fast/table/table-display-types-vertical-expected.txt:
platform/gtk/fast/table/tableInsideCaption-expected.txt:
platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt:
platform/gtk/tables/mozilla/bugs/bug119786-expected.png:
platform/gtk/tables/mozilla/bugs/bug119786-expected.txt:
platform/gtk/tables/mozilla/bugs/bug13118-expected.png:
platform/gtk/tables/mozilla/bugs/bug13118-expected.txt:
platform/gtk/tables/mozilla/bugs/bug19061-1-expected.png:
platform/gtk/tables/mozilla/bugs/bug19061-1-expected.txt:
platform/gtk/tables/mozilla/bugs/bug19061-2-expected.png:
platform/gtk/tables/mozilla/bugs/bug19061-2-expected.txt:
platform/gtk/tables/mozilla/bugs/bug220536-expected.png:
platform/gtk/tables/mozilla/bugs/bug220536-expected.txt:
platform/gtk/tables/mozilla/bugs/bug26178-expected.png:
platform/gtk/tables/mozilla/bugs/bug26178-expected.txt:
platform/gtk/tables/mozilla/bugs/bug27038-1-expected.txt:
platform/gtk/tables/mozilla/bugs/bug27038-2-expected.png:
platform/gtk/tables/mozilla/bugs/bug27038-2-expected.txt:
platform/gtk/tables/mozilla/bugs/bug27038-3-expected.png:
platform/gtk/tables/mozilla/bugs/bug27038-3-expected.txt: Added.
platform/gtk/tables/mozilla/bugs/bug278385-expected.txt:
platform/gtk/tables/mozilla/bugs/bug30418-expected.png:
platform/gtk/tables/mozilla/bugs/bug30418-expected.txt:
platform/gtk/tables/mozilla/bugs/bug3263-expected.png:
platform/gtk/tables/mozilla/bugs/bug3263-expected.txt:
platform/gtk/tables/mozilla/bugs/bug38916-expected.png:
platform/gtk/tables/mozilla/bugs/bug38916-expected.txt:
platform/gtk/tables/mozilla/bugs/bug46268-3-expected.png:
platform/gtk/tables/mozilla/bugs/bug46268-3-expected.txt:
platform/gtk/tables/mozilla/bugs/bug46268-5-expected.png:
platform/gtk/tables/mozilla/bugs/bug46268-5-expected.txt:
platform/gtk/tables/mozilla/bugs/bug46268-expected.png:
platform/gtk/tables/mozilla/bugs/bug46268-expected.txt:
platform/gtk/tables/mozilla/bugs/bug46924-expected.png:
platform/gtk/tables/mozilla/bugs/bug46924-expected.txt:
platform/gtk/tables/mozilla/bugs/bug55789-expected.txt:
platform/gtk/tables/mozilla/bugs/bug57378-expected.png:
platform/gtk/tables/mozilla/bugs/bug57378-expected.txt:
platform/gtk/tables/mozilla/dom/appendTbodyExpand1-expected.png:
platform/gtk/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.png:
platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.txt:
platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.png:
platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt:
platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
platform/gtk/tables/mozilla/marvin/body_tfoot-expected.png:
platform/gtk/tables/mozilla/marvin/body_tfoot-expected.txt:
platform/gtk/tables/mozilla/marvin/body_thead-expected.png:
platform/gtk/tables/mozilla/marvin/body_thead-expected.txt:
platform/gtk/tables/mozilla/marvin/table_rules_groups-expected.png:
platform/gtk/tables/mozilla/marvin/table_rules_groups-expected.txt:
platform/gtk/tables/mozilla/marvin/tbody_align_center-expected.png:
platform/gtk/tables/mozilla/marvin/tbody_align_center-expected.txt:
platform/gtk/tables/mozilla/marvin/tbody_align_char-expected.png:
platform/gtk/tables/mozilla/marvin/tbody_align_char-expected.txt:
platform/gtk/tables/mozilla/marvin/tbody_align_justify-expected.png:
platform/gtk/tables/mozilla/marvin/tbody_align_justify-expected.txt:
platform/gtk/tables/mozilla/marvin/tbody_align_left-expected.png:
platform/gtk/tables/mozilla/marvin/tbody_align_left-expected.txt:
platform/gtk/tables/mozilla/marvin/tbody_align_right-expected.png:
platform/gtk/tables/mozilla/marvin/tbody_align_right-expected.txt:
platform/gtk/tables/mozilla/marvin/tbody_char-expected.png:
platform/gtk/tables/mozilla/marvin/tbody_char-expected.txt:
platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.txt:
platform/gtk/tables/mozilla/marvin/tfoot_align_center-expected.png:
platform/gtk/tables/mozilla/marvin/tfoot_align_center-expected.txt:
platform/gtk/tables/mozilla/marvin/tfoot_align_char-expected.png:
platform/gtk/tables/mozilla/marvin/tfoot_align_char-expected.txt:
platform/gtk/tables/mozilla/marvin/tfoot_align_justify-expected.png:
platform/gtk/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
platform/gtk/tables/mozilla/marvin/tfoot_align_left-expected.png:
platform/gtk/tables/mozilla/marvin/tfoot_align_left-expected.txt:
platform/gtk/tables/mozilla/marvin/tfoot_align_right-expected.png:
platform/gtk/tables/mozilla/marvin/tfoot_align_right-expected.txt:
platform/gtk/tables/mozilla/marvin/tfoot_char-expected.png:
platform/gtk/tables/mozilla/marvin/tfoot_char-expected.txt:
platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
platform/gtk/tables/mozilla/marvin/thead_align_center-expected.png:
platform/gtk/tables/mozilla/marvin/thead_align_center-expected.txt:
platform/gtk/tables/mozilla/marvin/thead_align_char-expected.png:
platform/gtk/tables/mozilla/marvin/thead_align_char-expected.txt:
platform/gtk/tables/mozilla/marvin/thead_align_justify-expected.png:
platform/gtk/tables/mozilla/marvin/thead_align_justify-expected.txt:
platform/gtk/tables/mozilla/marvin/thead_align_left-expected.png:
platform/gtk/tables/mozilla/marvin/thead_align_left-expected.txt:
platform/gtk/tables/mozilla/marvin/thead_align_right-expected.png:
platform/gtk/tables/mozilla/marvin/thead_align_right-expected.txt:
platform/gtk/tables/mozilla/marvin/thead_char-expected.png:
platform/gtk/tables/mozilla/marvin/thead_char-expected.txt:
platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.txt:
platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.txt:
platform/gtk/tables/mozilla/marvin/x_table-expected.png:
platform/gtk/tables/mozilla/marvin/x_table-expected.txt:
platform/gtk/tables/mozilla/marvin/x_table_border-expected.png:
platform/gtk/tables/mozilla/marvin/x_table_border-expected.txt:
platform/gtk/tables/mozilla/marvin/x_table_border_none-expected.png:
platform/gtk/tables/mozilla/marvin/x_table_border_none-expected.txt:
platform/gtk/tables/mozilla/marvin/x_table_border_px-expected.png:
platform/gtk/tables/mozilla/marvin/x_table_border_px-expected.txt:
platform/gtk/tables/mozilla/marvin/x_table_frame_void-expected.png:
platform/gtk/tables/mozilla/marvin/x_table_frame_void-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tbody_align_center-expected.png:
platform/gtk/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tbody_align_char-expected.png:
platform/gtk/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tbody_align_left-expected.png:
platform/gtk/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tbody_align_right-expected.png:
platform/gtk/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
platform/gtk/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
platform/gtk/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
platform/gtk/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
platform/gtk/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
platform/gtk/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
platform/gtk/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
platform/gtk/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
platform/gtk/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tfoot_class-expected.png:
platform/gtk/tables/mozilla/marvin/x_tfoot_class-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tfoot_id-expected.png:
platform/gtk/tables/mozilla/marvin/x_tfoot_id-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tfoot_style-expected.png:
platform/gtk/tables/mozilla/marvin/x_tfoot_style-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
platform/gtk/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
platform/gtk/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
platform/gtk/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
platform/gtk/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
platform/gtk/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
platform/gtk/tables/mozilla/marvin/x_thead_align_center-expected.png:
platform/gtk/tables/mozilla/marvin/x_thead_align_center-expected.txt:
platform/gtk/tables/mozilla/marvin/x_thead_align_char-expected.png:
platform/gtk/tables/mozilla/marvin/x_thead_align_char-expected.txt:
platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.png:
platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
platform/gtk/tables/mozilla/marvin/x_thead_align_left-expected.png:
platform/gtk/tables/mozilla/marvin/x_thead_align_left-expected.txt:
platform/gtk/tables/mozilla/marvin/x_thead_align_right-expected.png:
platform/gtk/tables/mozilla/marvin/x_thead_align_right-expected.txt:
platform/gtk/tables/mozilla/marvin/x_thead_class-expected.png:
platform/gtk/tables/mozilla/marvin/x_thead_class-expected.txt:
platform/gtk/tables/mozilla/marvin/x_thead_id-expected.png:
platform/gtk/tables/mozilla/marvin/x_thead_id-expected.txt:
platform/gtk/tables/mozilla/marvin/x_thead_style-expected.png:
platform/gtk/tables/mozilla/marvin/x_thead_style-expected.txt:
platform/gtk/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
platform/gtk/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
platform/gtk/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
platform/gtk/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
platform/gtk/tables/mozilla/marvin/x_thead_valign_top-expected.png:
platform/gtk/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
platform/gtk/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
platform/gtk/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
platform/gtk/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
platform/gtk/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.png:
platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.png:
platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.png:
platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:

8:04 AM Changeset in webkit [159750] by Csaba Osztrogonác

117 edits
2 adds in trunk/LayoutTests

Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Rebase Mac results after r159747.

platform/mac/tables/mozilla/bugs/bug119786-expected.txt:
platform/mac/tables/mozilla/bugs/bug19061-2-expected.txt:
platform/mac/tables/mozilla/bugs/bug220536-expected.txt: Added.
platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt:
platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt:
platform/mac/tables/mozilla/bugs/bug27038-3-expected.txt: Added.
platform/mac/tables/mozilla/bugs/bug278385-expected.txt:
platform/mac/tables/mozilla/bugs/bug30418-expected.txt:
platform/mac/tables/mozilla/bugs/bug38916-expected.txt:
platform/mac/tables/mozilla/bugs/bug46268-3-expected.txt:
platform/mac/tables/mozilla/bugs/bug46268-5-expected.txt:
platform/mac/tables/mozilla/bugs/bug46268-expected.txt:
platform/mac/tables/mozilla/bugs/bug46924-expected.txt:
platform/mac/tables/mozilla/bugs/bug55789-expected.txt:
platform/mac/tables/mozilla/bugs/bug57378-expected.txt:
platform/mac/tables/mozilla/marvin/table_rules_groups-expected.txt:
platform/mac/tables/mozilla/marvin/tbody_align_center-expected.txt:
platform/mac/tables/mozilla/marvin/tbody_align_char-expected.txt:
platform/mac/tables/mozilla/marvin/tbody_align_justify-expected.txt:
platform/mac/tables/mozilla/marvin/tbody_align_left-expected.txt:
platform/mac/tables/mozilla/marvin/tbody_align_right-expected.txt:
platform/mac/tables/mozilla/marvin/tbody_char-expected.txt:
platform/mac/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
platform/mac/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
platform/mac/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
platform/mac/tables/mozilla/marvin/tbody_valign_top-expected.txt:
platform/mac/tables/mozilla/marvin/tfoot_align_center-expected.txt:
platform/mac/tables/mozilla/marvin/tfoot_align_char-expected.txt:
platform/mac/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
platform/mac/tables/mozilla/marvin/tfoot_align_left-expected.txt:
platform/mac/tables/mozilla/marvin/tfoot_align_right-expected.txt:
platform/mac/tables/mozilla/marvin/tfoot_char-expected.txt:
platform/mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
platform/mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
platform/mac/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
platform/mac/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
platform/mac/tables/mozilla/marvin/thead_align_center-expected.txt:
platform/mac/tables/mozilla/marvin/thead_align_char-expected.txt:
platform/mac/tables/mozilla/marvin/thead_align_justify-expected.txt:
platform/mac/tables/mozilla/marvin/thead_align_left-expected.txt:
platform/mac/tables/mozilla/marvin/thead_align_right-expected.txt:
platform/mac/tables/mozilla/marvin/thead_char-expected.txt:
platform/mac/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
platform/mac/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
platform/mac/tables/mozilla/marvin/thead_valign_middle-expected.txt:
platform/mac/tables/mozilla/marvin/thead_valign_top-expected.txt:
platform/mac/tables/mozilla/marvin/x_table-expected.txt:
platform/mac/tables/mozilla/marvin/x_table_border-expected.txt:
platform/mac/tables/mozilla/marvin/x_table_border_none-expected.txt:
platform/mac/tables/mozilla/marvin/x_table_border_px-expected.txt:
platform/mac/tables/mozilla/marvin/x_table_frame_void-expected.txt:
platform/mac/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
platform/mac/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
platform/mac/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
platform/mac/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
platform/mac/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
platform/mac/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
platform/mac/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
platform/mac/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
platform/mac/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
platform/mac/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
platform/mac/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
platform/mac/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
platform/mac/tables/mozilla/marvin/x_tfoot_class-expected.txt:
platform/mac/tables/mozilla/marvin/x_tfoot_id-expected.txt:
platform/mac/tables/mozilla/marvin/x_tfoot_style-expected.txt:
platform/mac/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
platform/mac/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
platform/mac/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
platform/mac/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
platform/mac/tables/mozilla/marvin/x_thead_align_center-expected.txt:
platform/mac/tables/mozilla/marvin/x_thead_align_char-expected.txt:
platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
platform/mac/tables/mozilla/marvin/x_thead_align_left-expected.txt:
platform/mac/tables/mozilla/marvin/x_thead_align_right-expected.txt:
platform/mac/tables/mozilla/marvin/x_thead_class-expected.txt:
platform/mac/tables/mozilla/marvin/x_thead_id-expected.txt:
platform/mac/tables/mozilla/marvin/x_thead_style-expected.txt:
platform/mac/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
platform/mac/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
platform/mac/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
platform/mac/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
platform/mac/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
platform/mac/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
platform/mac/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:

7:48 AM Changeset in webkit [159749] by commit-queue@webkit.org

4 edits in trunk/Tools

EWS creates 0 byte sized log files
https://bugs.webkit.org/show_bug.cgi?id=107606

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-25
Reviewed by Ryosuke Niwa.

There was a modification in r138264, that tried to make less log,
because some of the messeges were duplicated. After this the EWS
created the log file (with the same name as the bugID) but doesn't
write anything into it, even if there were errors during the build.
From now only creates the log file only if there is some error.

Scripts/webkitpy/tool/bot/queueengine.py:

(QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
there is nothing to log. Open the log file only if a ScriptError was raised to
avoid to make empty log files for bugs.
(QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
because of changes in r138264. Teeing is used for locally testing purposes and
this feature is not used anymore.
(QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
teeing anymore. It is a necessary change because of QueueEngine._open_work_log
change.

Scripts/webkitpy/tool/bot/queueengine_unittest.py:

(LoggingDelegate): The order of the callbacks was changed by this patch.
(QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
so we have to update this test.
(QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
this patch.

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
to be able to handle it in QueueEngine.run. Without this change, the existing
exception handler never run (the process_work_item method never raise ScriptError)
We can get the error message only from the ScriptError at this point.

7:28 AM Changeset in webkit [159748] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

[arm][mips] Fix crash in dfg-arrayify-elimination layout jsc test.
https://bugs.webkit.org/show_bug.cgi?id=124839

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-25
Reviewed by Michael Saboff.

In ARM EABI and MIPS, 64-bit values have to be aligned on stack too.

jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

jit/JITInlines.h:

(JSC::JIT::callOperation): Add missing EABI_32BIT_DUMMY_ARG.

6:57 AM Changeset in webkit [159747] by Csaba Osztrogonác

33 edits in trunk

Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Source/WebCore:

Based on Chromium fix https://chromium.googlesource.com/chromium/blink/+/eb615069267f895c59bc576f9d65b3fa5add41e9

Rebaseline needed for table related tests (100+).

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

First tuple of rebaselined tests for mac. Rebaseline needed for table related tests (100+).

fast/table/anonymous-table-section-removed.html:
platform/mac/accessibility/table-detection-expected.txt:
platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
platform/mac/fast/forms/input-value-expected.txt:
platform/mac/fast/table/011-expected.txt:
platform/mac/fast/table/border-collapsing/004-expected.txt:
platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
platform/mac/fast/table/floating-th-expected.txt:
platform/mac/fast/table/frame-and-rules-expected.txt:
platform/mac/fast/table/multiple-captions-display-expected.txt:
platform/mac/fast/table/rowindex-expected.txt:
platform/mac/fast/table/table-display-types-expected.txt:
platform/mac/fast/table/table-display-types-strict-expected.txt:
platform/mac/fast/table/table-display-types-vertical-expected.txt:
platform/mac/fast/table/tableInsideCaption-expected.txt:
platform/mac/tables/mozilla/bugs/bug10296-1-expected.txt:
platform/mac/tables/mozilla/bugs/bug13118-expected.txt:
platform/mac/tables/mozilla/bugs/bug19061-1-expected.txt:
platform/mac/tables/mozilla/bugs/bug3263-expected.txt:
platform/mac/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
platform/mac/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
platform/mac/tables/mozilla/marvin/backgr_position-table-expected.txt:
platform/mac/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
platform/mac/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
platform/mac/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
platform/mac/tables/mozilla/marvin/backgr_simple-table-expected.txt:
platform/mac/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
platform/mac/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
platform/mac/tables/mozilla/marvin/body_tfoot-expected.txt:
platform/mac/tables/mozilla/marvin/body_thead-expected.txt:

6:03 AM Changeset in webkit [159746] by commit-queue@webkit.org

6 edits
2 adds in trunk

[GStreamer] Seeking fails on media content provided by servers not supporting Range requests
https://bugs.webkit.org/show_bug.cgi?id=85994

Patch by Andres Gomez <Andres Gomez> on 2013-11-25
Reviewed by Philippe Normand.

Source/WebCore:

Based on the patch written by Andre Moreira Magalhaes.

When the GStreamer web source was doing a "Range" request we were
expecting to receive a 206 status reply with the "Content-Range"
header and just the requested data. Supporting "Range" requests is
not mandatory so, for the servers not supporting it they will be
replying with a 200 status and the whole content of the media
element. Now, we are properly handling these replies too.

Test: http/tests/media/media-seeking-no-ranges-server.html

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::handleResponseReceived): Do not fail when
receiving 200 as response for HTTP range requests.
(StreamingClient::handleDataReceived): Manually seek on stream
when receiving the full data after a seek.

LayoutTests:

Added test to check that seeking media files on http servers not
supporting "Range" requests doesn't trigger an error.

http/tests/media/media-seeking-no-ranges-server-expected.txt: Added.
http/tests/media/media-seeking-no-ranges-server.html: Added.
http/tests/media/resources/load-video.php: Added support for new

"ranges" paramenter.

http/tests/media/resources/serve-video.php: Added support for

new "ranges" paramenter. When "ranges" is "no" we always answer
the HTTP status "200 OK" and send the whole file.

platform/mac/TestExpectations: New test skipped in Mac port as

media playback download control is passed to AVFoundation that
doesn't like fancy PHP URLs like the one used in the test and, in
addition, they won't care about HTTP servers not supporting
"Range" requests.

4:14 AM Changeset in webkit [159745] by stavila@adobe.com

2 edits in trunk/Source/WebCore

Removed obsolete FIXME after the landing of visual overflow patch (https://bugs.webkit.org/show_bug.cgi?id=118665).
https://bugs.webkit.org/show_bug.cgi?id=124833

Reviewed by Mihnea Ovidenie.

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::layoutBlock):

3:36 AM Changeset in webkit [159744] by mario.prada@samsung.com

3 edits in trunk/LayoutTests

Unreviewed GTK gardening. Removed expectations for test that is no
longer failing for the GTK bots, according to the flakiness dashboard.

platform/gtk-wk2/TestExpectations: Removed expectation.
platform/gtk/TestExpectations: Ditto.

3:19 AM Changeset in webkit [159743] by zandobersek@gmail.com

3 edits
2 deletes in trunk/LayoutTests

Unreviewed GTK gardening.
Managing current failures and removing redundant baselines.

platform/gtk-wk2/TestExpectations:
platform/gtk/TestExpectations:
platform/gtk/fast/dom/gc-attribute-node-expected.txt: Removed.
platform/gtk/fast/repaint/increasing-region-content-height-expected.txt: Removed.

1:52 AM Changeset in webkit [159742] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[EFL] Need to update EFL TestExpectations file
https://bugs.webkit.org/show_bug.cgi?id=124825

Unreviewed, EFL gardening.

webgl/1.0.2/conformance/extensions/webgl-compressed-texture-s3tc.html
webgl/conformance/extensions/webgl-compressed-texture-s3tc.html
Above two tests are passed in Webkit2 layout test after r158798.

Patch by Jongwoo Choi <jw0330.choi@samsung.com> on 2013-11-25

platform/efl-wk1/TestExpectations:
platform/efl/TestExpectations:

12:22 AM Changeset in webkit [159741] by svillar@igalia.com

3 edits in trunk/Source/WebCore

[CSS Grid Layout] Cache several vectors to avoid malloc/free churn
https://bugs.webkit.org/show_bug.cgi?id=123995

Reviewed by Dean Jackson.

From Blink r158228 by <jchaffraix@chromium.org>

Laying-out the grid items means a lot of calls to
distributeSpaceToTracks() and
resolveContentBasedTrackSizingFunctionsForItems() as they're
called in a loop. This means that there is a lot of malloc/free
going on there. By moving the vectors used by these methods to a
new class which is kept during the whole layout process we save a
lot of those calls.

This obviously mean that the price we pay for a significant
perfomance improvement is that we keep the maximum allocation till
the end of each layout, but it's an amount of memory that we have
to allocate anyway. The improvement in the
auto-grid-lots-of-data.html perf test is ~24% (165 runs/s vs 207
runs/s).

No new tests required as we're just refactoring code to a new
helper class. Nevertheless the performance improvement is backed
by the perf test mentioned above.

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::GridSizingData::GridSizingData):
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::distributeSpaceToTracks):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::findChildLogicalPosition):

rendering/RenderGrid.h:

Nov 24, 2013:

7:09 PM Changeset in webkit [159740] by weinig@apple.com

21 edits in trunk/Source/WebKit2

WebPageGroup's should keep track of what processes they are being used by
https://bugs.webkit.org/show_bug.cgi?id=124556

Reviewed by Dan Bernstein.

Scripts/webkit2/messages.py:

(struct_or_class):
Mark WebPageGroupData as a struct.

Shared/UserMessageCoders.h:
Shared/mac/ObjCObjectGraphCoders.h:
Shared/mac/ObjCObjectGraphCoders.mm:
WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
UIProcess/WebConnectionToWebProcess.cpp:
UIProcess/WebContext.cpp:
UIProcess/WebContextUserMessageCoders.h:
UIProcess/WebPageProxy.cpp:
UIProcess/WebPageProxy.h:

Pass the WebProcess/WebProcessProxy to both encode and decode.

Shared/WebPageCreationParameters.h:

Pass the page group by ID when creating a page, as it will have had its own
creation message sent already.

UIProcess/WebPageGroup.cpp:
UIProcess/WebPageGroup.h:

Keep track of processes.

UIProcess/WebProcessProxy.cpp:
UIProcess/WebProcessProxy.h:

Keep track of the page groups used by the process.

WebProcess/WebPage/WebPage.cpp:

Get the already create page group on creation.

WebProcess/WebProcess.cpp:
WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

Explicitly create page groups in the WebProcess.

6:00 PM Changeset in webkit [159739] by jinwoo7.song@samsung.com

13 edits
1 add in trunk/LayoutTests

Unreviewed EFL gardening. Rebaselining various tests under fast/

platform/efl/fast/backgrounds/background-position-parsing-expected.png:
platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
platform/efl/fast/css/empty-pseudo-class-expected.png:
platform/efl/fast/css/empty-pseudo-class-expected.txt:
platform/efl/fast/css/fieldset-display-row-expected.txt:
platform/efl/fast/css/first-child-pseudo-class-expected.png:
platform/efl/fast/css/first-child-pseudo-class-expected.txt:
platform/efl/fast/css/last-child-pseudo-class-expected.png:
platform/efl/fast/css/last-child-pseudo-class-expected.txt:
platform/efl/fast/css/only-child-pseudo-class-expected.png:
platform/efl/fast/css/only-child-pseudo-class-expected.txt:

4:10 PM Changeset in webkit [159738] by jinwoo7.song@samsung.com

4 edits in trunk/LayoutTests

Unreviewed EFL gardening. Rebaselining after r159579.

platform/efl/css1/formatting_model/vertical_formatting-expected.txt:
platform/efl/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
platform/efl/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:

3:12 PM Changeset in webkit [159737] by beidson@apple.com

12 edits
2 copies
2 adds in trunk/Source

DatabaseProcess: Add "UniqueIDBDatabase" that multiple WebProcesses can connect to
https://bugs.webkit.org/show_bug.cgi?id=124819

Reviewed by Dan Bernstein.

Source/WebCore:

Modules/indexeddb/IDBDatabaseBackend.cpp:

(WebCore::IDBDatabaseBackend::~IDBDatabaseBackend): Unregister from the IDBFactory.

Source/WebKit2:

UniqueIDBDatabase instances are per-DatabaseProcess, so it manages the set of them.

DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::getOrCreateUniqueIDBDatabase):
(WebKit::DatabaseProcess::removeUniqueIDBDatabase):

DatabaseProcess/DatabaseProcess.h:

DatabaseProcess/DatabaseToWebProcessConnection.h:

Start forwarding things along to the appropriate UniqueIDBDatabase.

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::~DatabaseProcessIDBConnection):
(WebKit::DatabaseProcessIDBConnection::disconnectedFromWebProcess):
(WebKit::DatabaseProcessIDBConnection::establishConnection):
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata):

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:

A class that represents a single concrete IDB database that multiple WebProcesses can connect to.

DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::UniqueIDBDatabase):
(WebKit::UniqueIDBDatabase::~UniqueIDBDatabase):
(WebKit::UniqueIDBDatabase::registerConnection):
(WebKit::UniqueIDBDatabase::unregisterConnection):
(WebKit::UniqueIDBDatabase::getIDBDatabaseMetadata):

DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

(WebKit::UniqueIDBDatabase::create):
(WebKit::UniqueIDBDatabase::identifier):

A class to help uniquely identify an IDBDatabase that can be expanded as needed.
Importantly, it knows how to be used as a key in a HashMap.

DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.cpp: Added.

(WebKit::UniqueIDBDatabaseIdentifier::UniqueIDBDatabaseIdentifier):
(WebKit::UniqueIDBDatabaseIdentifier::isHashTableDeletedValue):
(WebKit::UniqueIDBDatabaseIdentifier::hash):
(WebKit::UniqueIDBDatabaseIdentifier::isNull):
(WebKit::operator==):

DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.h: Added.

(WebKit::UniqueIDBDatabaseIdentifier::databaseName):
(WebKit::UniqueIDBDatabaseIdentifier::openingOrigin):
(WebKit::UniqueIDBDatabaseIdentifier::mainFrameOrigin):
(WebKit::UniqueIDBDatabaseIdentifierHash::hash):
(WebKit::UniqueIDBDatabaseIdentifierHash::equal):
(WebKit::UniqueIDBDatabaseIdentifierHashTraits::isEmptyValue):

Shared/SecurityOriginData.cpp:

(WebKit::operator==):

Shared/SecurityOriginData.h:

UIProcess/WebContext.cpp:

WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::open):
(WebKit::WebIDBFactoryBackend::removeIDBDatabaseBackend):

WebKit2.xcodeproj/project.pbxproj:

1:46 PM Changeset in webkit [159736] by fpizlo@apple.com

3 edits
3 adds in trunk

Fix more fallout from failed attempts at div/mod DFG strength reductions
https://bugs.webkit.org/show_bug.cgi?id=124813

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithMod):

LayoutTests:

js/dfg-mod-1-int.html: Added.
js/dfg-mod-1-int-expected.txt: Added.
js/script-tests/dfg-mod-1-int.js: Added.

(foo):

11:14 AM Changeset in webkit [159735] by timothy_horton@apple.com

2 edits in trunk/Source/WTF

Upstream USE(IOSURFACE) from the iOS port
https://bugs.webkit.org/show_bug.cgi?id=124814

Reviewed by Sam Weinig.

Some code guarded by USE(IOSURFACE) was recently upstreamed,
but not the definition of WTF_USE_IOSURFACE itself.

wtf/Platform.h:

10:20 AM Changeset in webkit [159734] by commit-queue@webkit.org

9 edits in trunk/Source/WebKit2

[WK2][GTK] Adding SpatialNavigation setting to webkit2
https://bugs.webkit.org/show_bug.cgi?id=114298

Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk>, Arunprasad Rajkumar <arurajku@cisco.com> on 2013-11-24
Reviewed by Anders Carlsson.

Adding SpatialNavigation support to WebPreferencesStore allows us
to toggle that feature on WebKitSettings.

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetSpatialNavigationEnabled):
(WKPreferencesGetSpatialNavigationEnabled):

UIProcess/API/C/WKPreferences.h:
UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_set_enable_spatial_navigation):
(webkit_settings_get_enable_spatial_navigation):

UIProcess/API/gtk/WebKitSettings.h:
UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

7:24 AM Changeset in webkit [159733] by gyuyoung.kim@samsung.com

18 edits in trunk/Source/WebCore

Generate toHTMLMarquee|OListElement() to cleanup static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=124707

Reviewed by Darin Adler.

As a step to use toFoo(), we need to generate toHTMLMarquee|OListElement().
Besides this patch cleans up remaining static_cast<> usage.

No new tests, no behavior changes.

css/StyleResolver.cpp:

(WebCore::StyleResolver::State::initElement):
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::findSiblingForStyleSharing):

dom/Attr.cpp:

(WebCore::Attr::style):

dom/Element.cpp:

(WebCore::Element::removeAttribute):

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):

editing/EditingStyle.cpp:

(WebCore::EditingStyle::wrappingStyleForSerialization):

editing/Editor.cpp:

(WebCore::Editor::applyEditingStyleToElement):

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

html/HTMLMarqueeElement.h:
html/HTMLOListElement.h:
html/HTMLTagNames.in:
inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForElementInfo):

page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

rendering/RenderCounter.cpp:

(WebCore::planCounter):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

rendering/RenderListItem.cpp:

(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::updateListMarkerNumbers):

rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::marqueeSpeed):

12:34 AM Changeset in webkit [159732] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r156291): TileController tiles don't always repaint when they resize
https://bugs.webkit.org/show_bug.cgi?id=124796

Reviewed by Simon Fraser.

In removing platformCALayerDidCreateTiles, r156291 also removed
the call to setNeedsDisplay when tiles are resized, without
putting it somewhere else.

platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::setNeedsDisplay):
Use hasStaleContent when invalidating a whole tile, just
like we do for partial tile repaints.

(WebCore::TileController::setTileNeedsDisplayInRect):
Mark hasStaleContent for any unparented layers, so they'll be painted
when they are reparented.

(WebCore::TileController::ensureTilesForRect):
Invalidate the whole tile when it changes size.

Nov 23, 2013:

8:20 AM Changeset in webkit [159731] by robert@webkit.org

2 edits in trunk/LayoutTests

Remove lint from expected result.

Unreviewed.

platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:

6:35 AM Changeset in webkit [159730] by calvaris@igalia.com

41 edits
3 deletes in trunk

[GStreamer] Remove 0.10 codepath
https://bugs.webkit.org/show_bug.cgi?id=124534

Reviewed by Philippe Normand.

Source/cmake/OptionsEfl.cmake: Removed GST_API_VERSION_1

definition.

Source/WebCore:

All GStreamer ports are using 1.0 now so we remove the 0.10
codepath.

GNUmakefile.list.am:
PlatformEfl.cmake:
PlatformGTK.cmake:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters: Removed

GStreamerVersioning.

platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(onGStreamerWavparsePadAddedCallback): Removed.
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
Replaced webkitGstPipelineGetBus and removed 0.10 codepath.
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
Replaced webkitGstPipelineGetBus.

platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::copyGstreamerBuffersToAudioChannel):
(WebCore::onAppsinkPullRequiredCallback): Removed 0.10 codepath.
(WebCore::AudioFileReader::~AudioFileReader): Replaced
webkitGstPipelineGetBus and removed 0.10 codepath.
(WebCore::AudioFileReader::handleSample): Left as only codepath.
(WebCore::AudioFileReader::handleBuffer): Removed.
(WebCore::AudioFileReader::handleNewDeinterleavePad): Removed 0.10
codepath.
(WebCore::AudioFileReader::plugDeinterleave): Replaced
getGstAudioCaps.
(WebCore::AudioFileReader::decodeAudioForBusCreation): Replaced
webkitGstPipelineGetBus.
(WebCore::AudioFileReader::createBus): Removed 0.10 codepath.

platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(getGStreamerMonoAudioCaps):
(webKitWebAudioGStreamerChannelPosition): Removed 0.10 codepath.
(webkit_web_audio_src_class_init): Replaced
setGstElementClassMetadata.
(webkit_web_audio_src_init):
(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcFinalize):
(webKitWebAudioSrcLoop): Removed 0.10 codepath.

platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:

Removed checks for 1.0 as it is the only codepath now.

platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::GstElement):
(WTF::GstPad):
(WTF::GstPadTemplate):
(WTF::GstTask):
(WTF::GstBus):
(WTF::GstElementFactory):
(WTF::adoptGRef): Replaced gstObjectIsFloating.
(WTF::refGRef): Replaced webkitGstObjectRefSink.
(WTF::GstTagList):
(WTF::GstSample): Removed checks for 1.0 as it is the only
codepath now.

platform/graphics/gstreamer/GRefPtrGStreamer.h: Removed checks

for 1.0 as it is the only codepath now.

platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::webkitGstGhostPadFromStaticTemplate):
(WebCore::getVideoSizeAndFormatFromCaps):
(WebCore::createGstBuffer):
(WebCore::createGstBufferForData):
(WebCore::getGstBufferDataPointer):
(WebCore::mapGstBuffer):
(WebCore::unmapGstBuffer): Moved here from GstVersioning and added
to WebCore namespace.

platform/graphics/gstreamer/GStreamerUtilities.h:

(WebCore::webkitGstCheckVersion): Moved here from GstVersioning
and added to WebCore namespace.

platform/graphics/gstreamer/GStreamerVersioning.cpp: Removed.
platform/graphics/gstreamer/GStreamerVersioning.h: Removed.
platform/graphics/gstreamer/ImageGStreamer.h: Removed checks for

1.0 as it is the only codepath now.

platform/graphics/gstreamer/ImageGStreamerCairo.cpp:

(ImageGStreamer::ImageGStreamer): Removed 0.10 codepath.
(ImageGStreamer::~ImageGStreamer): Removed checks for 1.0 as it is
the only codepath now.

platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:
platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:

Removed checks for 1.0 as it is the only codepath now.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::setAudioStreamPropertiesCallback): Removed 0.10 codepath.
(WebCore::mediaPlayerPrivateTextChangedCallback): Removed checks
for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::isAvailable): Replaced
gPlaybinName.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Removed checks for 1.0 and replaced webkitGstPipelineGetBus.
(WebCore::MediaPlayerPrivateGStreamer::duration): Removed 0.10
codepath.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):
Removed checks for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::buffered): Replaced
gPercentMax.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Removed
0.10 codepath.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents):
Removed checks for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::totalBytes): Removed 0.10
codepath.
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Replaced
gPlaybinName and webkitGstPipelineGetBus and removed checks for
1.0.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Removed checks for 1.0 as it is the only codepath now.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::paint): Removed 0.10
codepath.

platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
platform/graphics/gstreamer/TextCombinerGStreamer.h:
platform/graphics/gstreamer/TextSinkGStreamer.cpp:
platform/graphics/gstreamer/TextSinkGStreamer.h:
platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Removed

checks for 1.0 as it is the only codepath now.

platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkRender): Removed 0.10 codepath and added WebCore
as createGstBuffer namespace.
(webkitVideoSinkSetCaps): Removed 0.10 codepath.
(webkitVideoSinkProposeAllocation): Removed checks for 1.0 as it
is the only codepath now.
(webkitVideoSinkMarshalVoidAndMiniObject): Removed as it was 0.10.
(webkit_video_sink_class_init): Removed 0.10 codepath and replaced
setGstElementClassMetadata.

platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:

Removed checks for 1.0 as it is the only codepath now.

platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:

(webkit_media_src_class_init): Replaced
setGstElementClassMetadata.
(webKitMediaSrcAddSrc): Added WebCore namespace to
webkitGstGhostPadFromStaticTemplate.
(MediaSourceClientGstreamer::didReceiveData): Added WebCore
namespace to createGstBufferForData.

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

Removed 0.10 codepath.
(webKitWebSrcQuery): Removed as it was 0.10 only.
(void webkit_web_src_class_init): Replaced setGstElementClassMetadata.
(webkit_web_src_init): Removed haveAppSrc27 private attribute and
0.10 codepath.
(webKitWebSrcStop): Removed checks for 1.0 as it is the only
codepath now.
(webKitWebSrcSetProperty):
(webKitWebSrcUriGetType):
(webKitWebSrcGetProtocols):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri): Removed 0.10 codepath.
(StreamingClient::createReadBuffer): Removed checks for 1.0 and
replaced getGstBufferSize.
(StreamingClient::handleResponseReceived): Removed 0.10 codepath
and replaced notifyGstTagsOnPad.
(StreamingClient::handleDataReceived): Removed 0.10 codepath and
replaced setGstBufferSize and gst_buffer_get_size.

Source/WebKit:

PlatformEfl.cmake: Removed FullscreenVideoControllerEfl.cpp.

Source/WebKit/efl:

WebCoreSupport/FullscreenVideoControllerEfl.cpp: Removed.

Source/WTF:

wtf/Platform.h: Removed macro for GStreamer 1.0 as it is the

only codepath now.

3:05 AM Changeset in webkit [159729] by robert@webkit.org

2 edits in trunk/LayoutTests

Rebaseline empty-clear-blocks.html after r159575

Unreviewed, rebaselining.

platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:

Nov 22, 2013:

11:11 PM Changeset in webkit [159728] by beidson@apple.com

7 edits
1 copy
1 add in trunk/Source/WebKit2

Add DatabaseProcessCreationParameters, starting with the database path.
https://bugs.webkit.org/show_bug.cgi?id=124804

Reviewed by Dean Jackson and Benjamin Poulain.

DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::initializeDatabaseProcess):

DatabaseProcess/DatabaseProcess.h:

(WebKit::DatabaseProcess::indexedDatabaseDirectory):

DatabaseProcess/DatabaseProcess.messages.in:

Shared/Databases/DatabaseProcessCreationParameters.cpp: Added.

(WebKit::DatabaseProcessCreationParameters::DatabaseProcessCreationParameters):
(WebKit::DatabaseProcessCreationParameters::encode):
(WebKit::DatabaseProcessCreationParameters::decode):

Shared/Databases/DatabaseProcessCreationParameters.h: Added.

UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureDatabaseProcess):

WebKit2.xcodeproj/project.pbxproj:
Scripts/webkit2/messages.py:

(struct_or_class):

10:03 PM Changeset in webkit [159727] by ryuan.choi@samsung.com

5 edits in trunk/Source/WebKit2

[EFL] Build break after r159724
https://bugs.webkit.org/show_bug.cgi?id=124806

Reviewed by Tim Horton.

Platform/CoreIPC/Connection.h: Include atomic header.
UIProcess/CoordinatedGraphics/WebView.cpp: Rename didChangeContentsSize to didChangeContentSize.

(WebKit::WebView::didChangeContentSize):

UIProcess/CoordinatedGraphics/WebView.h: Ditto.
WebProcess/InjectedBundle/API/c/WKBundlePage.h: Adjust TARGET_OS_IPHONE macro.

8:50 PM Changeset in webkit [159726] by rniwa@webkit.org

4 edits
1 add
1 delete in trunk

Layout Test editing/deleting/password-delete-performance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=124781

Reviewed by Alexey Proskuryakov.

PerformanceTests:

Add a new performance test to replace editing/deleting/password-delete-performance.html.
We skip this test by default since it's a micro benchmark.

Interactive/DeletingInPasswordField.html: Added.
Skipped:

LayoutTests:

Removed the test that has been timing out.

TestExpectations:
editing/deleting/password-delete-performance.html: Removed.

7:43 PM Changeset in webkit [159725] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Attempt build fixes for 32-bit after 159724.

There's probably a better fix, but this will work for now.

UIProcess/API/mac/WKView.h:

7:29 PM Changeset in webkit [159724] by enrica@apple.com

101 edits
50 adds
2 deletes in trunk/Source/WebKit2

Upstream iOS WebKit2 to OpenSource (part 3).
https://bugs.webkit.org/show_bug.cgi?id=124803

Reviewed by Anders Carlsson and Tim Horton.

6:54 PM Changeset in webkit [159723] by mhahnenberg@apple.com

6 edits in trunk/Source/JavaScriptCore

JSC Obj-C API should have real documentation
https://bugs.webkit.org/show_bug.cgi?id=124805

Reviewed by Geoffrey Garen.

Massaging the header comments into proper headerdocs.

API/JSContext.h:
API/JSExport.h:
API/JSManagedValue.h:
API/JSValue.h:
API/JSVirtualMachine.h:

6:27 PM TestExpectations edited by Andres Gomez

(diff)

4:57 PM Changeset in webkit [159722] by jer.noble@apple.com

4 edits in trunk/Source

[Mac] Can't drag full-screen video to another monitor
https://bugs.webkit.org/show_bug.cgi?id=124798

Reviewed by Geoffrey Garen.

Source/WebCore:

Make full screen windows movable by default. Previously, we wanted non-movable full screen
windows since they were in the same space and were just placed atop non-full screen windows.
Now that all our supported Mac platforms have explicit full screen support, we can remove this
non-movable restriction.

platform/mac/WebCoreFullScreenWindow.mm:

(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):

Source/WebKit2:

Make full screen windows resizable by default. This allows the window to be resized when
moved between monitors with different resolutions.

UIProcess/API/mac/WKView.mm:

(-[WKView createFullScreenWindow]):

4:36 PM Changeset in webkit [159721] by fpizlo@apple.com

20 edits in trunk/Source/JavaScriptCore

CodeBlock::m_numCalleeRegisters shouldn't also mean frame size, frame size needed for exit, or any other unrelated things
https://bugs.webkit.org/show_bug.cgi?id=124793

Reviewed by Mark Hahnenberg.

Now m_numCalleeRegisters always refers to the number of locals that the attached
bytecode uses. It never means anything else.

For frame size, we now have it lazily computed from m_numCalleeRegisters for the
baseline engines and we have it stored in DFG::CommonData for the optimizing JITs.

For frame-size-needed-at-exit, we store that in DFG::CommonData, too.

The code no longer implies that there is any arithmetic relationship between
m_numCalleeRegisters and frameSize. Previously it implied that the latter is greater
than the former.

The code no longer implies that there is any arithmetic relationship between the
frame Size and the frame-size-needed-at-exit. Previously it implied that the latter
is greater that the former.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::frameRegisterCount):

bytecode/CodeBlock.h:
dfg/DFGCommonData.h:

(JSC::DFG::CommonData::CommonData):
(JSC::DFG::CommonData::requiredRegisterCountForExecutionAndExit):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::frameRegisterCount):
(JSC::DFG::Graph::requiredRegisterCountForExit):
(JSC::DFG::Graph::requiredRegisterCountForExecutionAndExit):

dfg/DFGGraph.h:
dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):

dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

ftl/FTLLink.cpp:

(JSC::FTL::link):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):

ftl/FTLOSREntry.cpp:

(JSC::FTL::prepareOSREntry):

interpreter/CallFrame.cpp:

(JSC::CallFrame::frameExtentInternal):

interpreter/JSStackInlines.h:

(JSC::JSStack::pushFrame):

jit/JIT.h:

(JSC::JIT::frameRegisterCountFor):

jit/JITOperations.cpp:
llint/LLIntEntrypoint.cpp:

(JSC::LLInt::frameRegisterCountFor):

llint/LLIntEntrypoint.h:

4:17 PM Changeset in webkit [159720] by Brent Fulgham

4 edits in trunk/Source/WebCore

[Win] Clean up ColorSpace handling in Windows code
https://bugs.webkit.org/show_bug.cgi?id=124795

Reviewed by Tim Horton.

Functionality covered by existing fast/css/color test suite.

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::safeRGBColorSpaceRef): Handle case of Windows CG implementation not
handling sRGB correctly.
(WebCore::sRGBColorSpaceRef): Use new helper function.

platform/graphics/win/FontCGWin.cpp:

(WebCore::Font::drawGlyphs): Pass correct color space to fill functions.

platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::platformInit): Initialize color space to value passed
via the style to the constructor.

4:07 PM Changeset in webkit [159719] by benjamin@webkit.org

2 edits in trunk/Source/WebKit2

[WK2] Another build fix for NetworkProcess on iOS
https://bugs.webkit.org/show_bug.cgi?id=124797

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-22
Reviewed by Alexey Proskuryakov.

NetworkProcess/NetworkResourceLoader.h:

3:47 PM Changeset in webkit [159718] by benjamin@webkit.org

4 edits in trunk/Source/WebKit2

[WK2] Fix the build of the NetworkProcess on iOS
https://bugs.webkit.org/show_bug.cgi?id=124794

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-22
Reviewed by Alexey Proskuryakov.

NetworkProcess/AsynchronousNetworkLoaderClient.cpp:

(WebKit::AsynchronousNetworkLoaderClient::didReceiveBuffer):

NetworkProcess/NetworkResourceLoader.h:
NetworkProcess/SynchronousNetworkLoaderClient.cpp:

(WebKit::SynchronousNetworkLoaderClient::willSendRequest):

3:43 PM Changeset in webkit [159717] by ap@apple.com

15 edits
2 moves in trunk/Source/WebCore

WebCrypto algorithms should check that key algorithm matches
https://bugs.webkit.org/show_bug.cgi?id=123628

Reviewed by Anders Carlsson.

No change in behavior yet, because we have one algorithm per key class.
Will be tested once more algorithms are added.

WebCore.xcodeproj/project.pbxproj: Updated for file renames.

bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::createRsaKeyParamsWithHash):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):

bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::createRSAKeyParametersWithHash):
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):

crypto/CryptoAlgorithmParameters.h:

(WebCore::CryptoAlgorithmParameters::ENUM_CLASS):

crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHash.h: Copied from Source/WebCore/crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h.
crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h: Removed.

Renamed RsaSsaKeyParams to RsaKeyParamsWithHash, because other algorithms (like RSA-OAEP)
are in the same boat. Depending on where the spec goes, we might need to introduce
algorithm specific RSA parameter classes later, but let's reduce copy/pasted code at
least for now.

crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Moved to the correct directory.
crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Copied from Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp.

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign): Factored out Mac specific
code, leaving type casting to cross-platform files.
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify): Ditto.

crypto/CryptoAlgorithmRegistry.h:

(WebCore::CryptoAlgorithmRegistry::registerAlgorithm):

crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
Reduce copy/pasting in registration code.

crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::keyAlgorithmMatches): Check key type and algorithm.
(WebCore::CryptoAlgorithmAES_CBC::encrypt): Cross platform type casting code.
Maybe we'll find a way to autogenerate or eliminate it one day.
(WebCore::CryptoAlgorithmAES_CBC::decrypt): Ditto.

crypto/algorithms/CryptoAlgorithmAES_CBC.h:
crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):

crypto/algorithms/CryptoAlgorithmHMAC.h:
crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):

crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
Same changes for all algorithms that have keys.

2:57 PM Changeset in webkit [159716] by Manuel Rego Casasnovas

2 edits in trunk

[GTK] Review enabled/disabled CSS features for release builds
https://bugs.webkit.org/show_bug.cgi?id=124791

Reviewed by Martin Robinson.

Enable and disable some CSS features according to what last versions of
Safari ship or not.

Source/autotools/SetupWebKitFeatures.m4: Enable ENABLE_CSS_REGIONS and

ENABLE_CSS_STICKY_POSITION. Disable ENABLE_CSS_EXCLUSIONS and
ENABLE_CSS_SHAPES.

2:52 PM Changeset in webkit [159715] by andersca@apple.com

4 edits
6 adds in trunk/Source/WebKit2

Move the remaining page loader clients out into separate files
https://bugs.webkit.org/show_bug.cgi?id=124792

Reviewed by Dan Bernstein.

UIProcess/API/C/WKPage.h:
UIProcess/API/C/WKPageContextMenuClient.h: Added.
UIProcess/API/C/WKPageFindClient.h: Added.
UIProcess/API/C/WKPageFindMatchesClient.h: Added.
UIProcess/API/C/WKPageFormClient.h: Added.
UIProcess/API/C/WKPageLoaderClient.h:
UIProcess/API/C/WKPagePolicyClient.h: Added.
UIProcess/API/C/WKPageUIClient.h: Added.
WebKit2.xcodeproj/project.pbxproj:

2:24 PM Changeset in webkit [159714] by commit-queue@webkit.org

4 edits
2 adds in trunk

Fire "change" event on TextTrackList when a TextTrack's mode changes
https://bugs.webkit.org/show_bug.cgi?id=124789

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-22
Reviewed by Eric Carlson.

Source/WebCore:

Since AudioTrackList and VideoTrackList already have this event, the
interesting bits are in TrackListBase::scheduleChangeEvent(), and we
just need to call it for TextTrackList changes.

Test: media/track/track-change-event.html

html/HTMLMediaElement.cpp:

(HTMLMediaElement::textTrackModeChanged): Call TrackListBase::scheduleChangeEvent().

html/track/TextTrackList.idl: Add onchange event listener.

LayoutTests:

media/track/track-change-event-expected.txt: Added.
media/track/track-change-event.html: Added.

2:03 PM Changeset in webkit [159713] by fpizlo@apple.com

17 edits in trunk/Source/JavaScriptCore

Combine SymbolTable and SharedSymbolTable
https://bugs.webkit.org/show_bug.cgi?id=124761

Reviewed by Geoffrey Garen.

SymbolTable was never used directly; we now always used SharedSymbolTable. So, this
gets rid of SymbolTable and renames SharedSymbolTable to SymbolTable.

bytecode/CodeBlock.h:

(JSC::CodeBlock::symbolTable):

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::symbolTable):
(JSC::UnlinkedCodeBlock::symbolTable):
(JSC::UnlinkedCodeBlock::finishCreation):

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::symbolTable):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::symbolTableFor):

runtime/Arguments.h:

(JSC::Arguments::finishCreation):

runtime/Executable.h:

(JSC::FunctionExecutable::symbolTable):

runtime/JSActivation.h:

(JSC::JSActivation::create):
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::registersOffset):
(JSC::JSActivation::allocationSize):

runtime/JSSymbolTableObject.h:

(JSC::JSSymbolTableObject::symbolTable):
(JSC::JSSymbolTableObject::JSSymbolTableObject):
(JSC::JSSymbolTableObject::finishCreation):

runtime/JSVariableObject.h:

(JSC::JSVariableObject::JSVariableObject):

runtime/SymbolTable.cpp:

(JSC::SymbolTable::destroy):
(JSC::SymbolTable::SymbolTable):

runtime/SymbolTable.h:

(JSC::SymbolTable::create):
(JSC::SymbolTable::createStructure):

runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

1:59 PM Changeset in webkit [159712] by andersca@apple.com

3 edits
1 add in trunk/Source/WebKit2

Move WKPageLoaderClient out into a separate header
https://bugs.webkit.org/show_bug.cgi?id=124790

Reviewed by Dan Bernstein.

UIProcess/API/C/WKPage.h:
UIProcess/API/C/WKPageLoaderClient.h: Added.
WebKit2.xcodeproj/project.pbxproj:

1:44 PM Changeset in webkit [159711] by commit-queue@webkit.org

7 edits in trunk

Add TextTrackList::getTrackById().
https://bugs.webkit.org/show_bug.cgi?id=124785

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-22
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-id.html

html/track/TextTrackList.cpp: Add getTrackById()

(TextTrackList::getTrackById):

html/track/TextTrackList.h: Same.
html/track/TextTrackList.idl: Same.

LayoutTests:

Update this test to make it more interesting. It now checks that the "id"
changes when the <track> id changes, makes sure TextTrack::id is readonly,
and looks the track up by id with getTrackById().

media/track/track-id-expected.txt:
media/track/track-id.html:

1:22 PM Changeset in webkit [159710] by dino@apple.com

2 edits in trunk/Tools

Speculative Mountain Lion build fix.

MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate openDocument:]):

1:09 PM Changeset in webkit [159709] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

Remove residual references to "dynamicGlobalObject".
https://bugs.webkit.org/show_bug.cgi?id=124787.

Reviewed by Filip Pizlo.

JavaScriptCore.order:
interpreter/CallFrame.h:

12:57 PM Changeset in webkit [159708] by andersca@apple.com

2 edits in trunk/Tools

Fix Mountain Lion bug.

MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate openDocument:]):

12:38 PM Changeset in webkit [159707] by andersca@apple.com

2 edits in trunk/Tools

MiniBrowser should use the blocks-based NSOpenPanel API
https://bugs.webkit.org/show_bug.cgi?id=124786

Reviewed by Simon Fraser.

MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate frontmostBrowserWindowController]):
Account for windows that don't have a BrowserWindowController.

(-[BrowserAppDelegate openDocument:]):

12:31 PM Changeset in webkit [159706] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

Ensure that arity fixups honor stack alignment requirements.
https://bugs.webkit.org/show_bug.cgi?id=124756.

Reviewed by Geoffrey Garen.

The LLINT and all the JITs rely on CommonSlowPaths::arityCheckFor() to
compute the arg count adjustment for the arity fixup. We take advantage
of this choke point and introduce the stack alignment padding there in
the guise of additional args.

The only cost of this approach is that the padding will also be
initialized to undefined values as if they were args. Since arity fixups
are considered a slow path that is rarely taken, this cost is not a
concern.

runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):

runtime/VM.h:

(JSC::VM::isSafeToRecurse):

12:18 PM Changeset in webkit [159705] by fpizlo@apple.com

5 edits
1 delete in trunk

BytecodeGenerator should align the stack according to native conventions
https://bugs.webkit.org/show_bug.cgi?id=124735

Source/JavaScriptCore:

Reviewed by Mark Lam.

Rolling this back in because it actually fixed fast/dom/gc-attribute-node.html, but
our infrastructure misleads peole into thinking that fixing a test constitutes
breaking it.

bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):

bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):

LayoutTests:

Reviewed by Mark Lam.

platform/mac/fast/dom/gc-attribute-node-expected.txt: Removed.

12:06 PM Changeset in webkit [159704] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Fix 32-bit build.

UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController _initWithPageRef:]):

11:48 AM Changeset in webkit [159703] by mitz@apple.com

5 edits in trunk/Source/WebKit2

Debug builds unconditionally dump remote layer tree transactions to stderr.

Reviewed by Sam Weinig.

Platform/Logging.h: Declared RemoteLayerTree logging channel.
Shared/mac/RemoteLayerTreeTransaction.h: Declared description().
Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::dump): Changed to use description().
(WebKit::RemoteLayerTreeTransaction::description): Returns a CString with the description.

UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::commit): Changed to use logging instead of calling dump().

11:35 AM Changeset in webkit [159702] by hmuller@adobe.com

7 edits
4 adds in trunk

[CSS Shapes] When the <box> value is set, derive radii from border-radius
https://bugs.webkit.org/show_bug.cgi?id=124228

Reviewed by Dean Jackson.

Source/WebCore:

Add support for BoxShape elliptical corners.

Tests: fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001.html

fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002.html

platform/graphics/FloatRoundedRect.h:

(WebCore::FloatRoundedRect::bottomLeftCorner): Corrected a copy-and-pasteO.

rendering/shapes/BoxShape.cpp:

(WebCore::BoxShape::getExcludedIntervals): Returned interval now depends on the top and bottom of the line.

rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape): Rounded rect parameters are now specified with a RoundedRect parameter.

rendering/shapes/Shape.h:
rendering/shapes/ShapeInfo.cpp:

(WebCore::::computedShape): Pass style's rounded border to createShape().

LayoutTests:

fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001-expected.txt: Added.
fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001.html: Added.
fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002-expected.txt: Added.
fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002.html: Added.

11:33 AM Changeset in webkit [159701] by andersca@apple.com

4 edits in trunk/Source/WebKit2

Send out the right KVO callbacks when the page title changes
https://bugs.webkit.org/show_bug.cgi?id=124753

Reviewed by Simon Fraser.

UIProcess/API/mac/WKBrowsingContextController.mm:

(PageLoadStateObserver::PageLoadStateObserver):
New class that sends the right KVO notifications when the load state changes.

(-[WKBrowsingContextController dealloc]):
Remove the observer.

(-[WKBrowsingContextController _initWithPageRef:]):
Allocate the observer and add it.

UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::~PageLoadState):
Assert that we don't have any observers left.

(WebKit::PageLoadState::addObserver):
Add the observer to the list.

(WebKit::PageLoadState::removeObserver):
Remove the observer from the list.

(WebKit::PageLoadState::reset):
Call title change callbacks.

(WebKit::PageLoadState::setTitle):
Ditto.

(WebKit::PageLoadState::callObserverCallback):
Helper function to dispatch callbacks to observers.

UIProcess/PageLoadState.h:

Add new members.

11:31 AM Changeset in webkit [159700] by Lucas Forschler

5 edits in branches/safari-537.60-branch/Source

Versioning.

11:28 AM Changeset in webkit [159699] by Lucas Forschler

1 copy in tags/Safari-537.60.7

New Tag.

11:14 AM Changeset in webkit [159698] by Brent Fulgham

2 edits in branches/safari-537.60-branch/Source/WebCore

Merge r159691

2013-11-21 Brent Fulgham <Brent Fulgham>

[Win] Avoid deadlock when interacting with some AVFoundationCF content
<rdar://problem/15482977> and https://bugs.webkit.org/show_bug.cgi?id=124752

Prevent deadlock caused by conflict over the "mapLock" mutex. Notification handling in the file,
which modify assets and make other changes, are required to happen on the main thread. This
patch enforces this requirement.

Reviewed by Eric Carlson.

platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: (WebCore::NotificationCallbackData::NotificationCallbackData): Added (WebCore::AVFWrapper::processNotification): Moved logic from 'notificationCallback', which was sometimes happening on a background thread. (WebCore::AVFWrapper::notificationCallback): Dispatch calls to main thread.

10:24 AM Changeset in webkit [159697] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

Get rid of CodeBlock::dumpStatistics()
https://bugs.webkit.org/show_bug.cgi?id=124762

Reviewed by Mark Hahnenberg.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):

bytecode/CodeBlock.h:

9:46 AM Changeset in webkit [159696] by commit-queue@webkit.org

3 edits in trunk/Tools

Unreviewed, rolling out r159690.
http://trac.webkit.org/changeset/159690
https://bugs.webkit.org/show_bug.cgi?id=124782

Broke webkitpy tests (Requested by ap on #webkit).

Scripts/webkitpy/tool/bot/queueengine.py:

(QueueEngine.run):
(QueueEngine._open_work_log):
(QueueEngine._ensure_work_log_closed):

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.review_patch):

9:44 AM Changeset in webkit [159695] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Several missing/incorrect guards for LOG_DISABLED=0 against Release build (Mac)
https://bugs.webkit.org/show_bug.cgi?id=78735

Patch by Andres Gomez <Andres Gomez> on 2013-11-22
Reviewed by Mario Sanchez Prada.

In a "Debug" build the CString.h header comes from another
indirect dependency. Now, we explicitly add this missing include.

page/CaptionUserPreferencesMediaAF.cpp: Explicitly adding

missing include.

9:38 AM Changeset in webkit [159694] by ap@apple.com

2 edits in trunk/LayoutTests

Layout Test editing/deleting/password-delete-performance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=124781

TestExpectations: Skipped it, running a test that almost always times out makes little sense.

9:34 AM Changeset in webkit [159693] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r159652.
http://trac.webkit.org/changeset/159652
https://bugs.webkit.org/show_bug.cgi?id=124778

broke fast/dom/gc-attribute-node.html (Requested by ap on
#webkit).

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):

bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):

bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):
(JSC::CallArguments::newArgument):

9:27 AM Changeset in webkit [159692] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[curl] Fix of SSL certificate chain storage
https://bugs.webkit.org/show_bug.cgi?id=124768

Patch by Robert Sipka <sipka@inf.u-szeged.hu> on 2013-11-22
Reviewed by Brent Fulgham.

Change the certificates storage type into ListHashSet
from HashSet to keep the chain order in each case.
This ensures that there is no difference between the stored
and the recieved certificate chain.

platform/network/curl/SSLHandle.cpp:

(WebCore::allowsAnyHTTPSCertificateHosts):
(WebCore::sslIgnoreHTTPSCertificate):
(WebCore::pemData):
(WebCore::certVerifyCallback):

9:23 AM Changeset in webkit [159691] by Brent Fulgham

2 edits in trunk/Source/WebCore

[Win] Avoid deadlock when interacting with some AVFoundationCF content
<rdar://problem/15482977> and https://bugs.webkit.org/show_bug.cgi?id=124752

Prevent deadlock caused by conflict over the "mapLock" mutex. Notification handling in the file,
which modify assets and make other changes, are required to happen on the main thread. This
patch enforces this requirement.

Reviewed by Eric Carlson.

platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::NotificationCallbackData::NotificationCallbackData): Added
(WebCore::AVFWrapper::processNotification): Moved logic from 'notificationCallback', which was
sometimes happening on a background thread.
(WebCore::AVFWrapper::notificationCallback): Dispatch calls to main thread.

8:26 AM Changeset in webkit [159690] by commit-queue@webkit.org

3 edits in trunk/Tools

EWS creates 0 byte sized log files
https://bugs.webkit.org/show_bug.cgi?id=107606

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-22
Reviewed by Ryosuke Niwa.

Scripts/webkitpy/tool/bot/queueengine.py:

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

8:07 AM Changeset in webkit [159689] by rniwa@webkit.org

5 edits
59 adds in trunk/LayoutTests

Import more W3C tests for parsing template elements
https://bugs.webkit.org/show_bug.cgi?id=124763

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Imported more W3c tests for HTML template element at 12a1164ae919f29f6ba2d0c8a63f0eafb6b599aa
after applying fixes proposed at https://github.com/w3c/web-platform-tests/pull/442.

html-templates/definitions/template-contents-expected.txt: Added.
html-templates/definitions/template-contents-owner-document-type-expected.txt: Added.
html-templates/definitions/template-contents-owner-document-type.html: Added.
html-templates/definitions/template-contents-owner-test-001-expected.txt: Added.
html-templates/definitions/template-contents-owner-test-001.html: Added.
html-templates/definitions/template-contents-owner-test-002-expected.txt: Added.
html-templates/definitions/template-contents-owner-test-002.html: Added.
html-templates/definitions/template-contents.html: Added.
html-templates/innerhtml-on-templates/innerhtml-expected.txt: Added.
html-templates/innerhtml-on-templates/innerhtml.html: Added.
html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-a-foster-parent-element-expected.txt: Added.
html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-a-foster-parent-element.html: Added.
html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-not-a-foster-parent-element-expected.txt: Added.
html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-not-a-foster-parent-element.html: Added.
html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/generating-of-implied-end-tags-expected.txt: Added.
html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/generating-of-implied-end-tags.html: Added.
html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-body-token-expected.txt: Added.
html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-body-token.html: Added.
html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-frameset-token-expected.txt: Added.
html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-frameset-token.html: Added.
html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-head-token-expected.txt: Added.
html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-head-token.html: Added.
html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-html-token-expected.txt: Added.
html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-html-token.html: Added.
html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-body-expected.txt: Added.
html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-body.html: Added.
html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-html-expected.txt: Added.
html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-html.html: Added.
html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/template-end-tag-without-start-one-expected.txt: Added.
html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/template-end-tag-without-start-one.html: Added.
html-templates/parsing-html-templates/additions-to-the-in-frameset-insertion-mode/end-tag-frameset-expected.txt: Added.
html-templates/parsing-html-templates/additions-to-the-in-frameset-insertion-mode/end-tag-frameset.html: Added.
html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/generating-of-implied-end-tags-expected.txt: Added.
html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/generating-of-implied-end-tags.html: Added.
html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/template-end-tag-without-start-one-expected.txt: Added.
html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/template-end-tag-without-start-one.html: Added.
html-templates/parsing-html-templates/additions-to-the-in-table-insertion-mode/end-tag-table-expected.txt: Added.
html-templates/parsing-html-templates/additions-to-the-in-table-insertion-mode/end-tag-table.html: Added.
html-templates/parsing-html-templates/appending-to-a-template/template-child-nodes-expected.txt: Added.
html-templates/parsing-html-templates/appending-to-a-template/template-child-nodes.html: Added.
html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-body-context-expected.txt: Added.
html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-body-context.html: Added.
html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-context-expected.txt: Added.
html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-context.html: Added.
html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-row-context-expected.txt: Added.
html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-row-context.html: Added.
html-templates/parsing-html-templates/creating-an-element-for-the-token/template-owner-document-expected.txt: Added.
html-templates/parsing-html-templates/creating-an-element-for-the-token/template-owner-document.html: Added.

LayoutTests:

Updated the testharness.js/css to bc4639ba51b62158d94bb4fc6884b23453f3f7a1.

resources/testharness.css:
resources/testharness.js:
resources/testharnessreport.js: Use innerText instead of innerHTML to avoid interpreting markup inside

the status and message as HTML.

8:01 AM Changeset in webkit [159688] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[WinCairo] Compile error when ACCELERATED_COMPOSITING is not used.
https://bugs.webkit.org/show_bug.cgi?id=124773

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-22
Reviewed by Brent Fulgham.

rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations): Added USE(ACCELERATED_COMPOSITING) guard.

7:12 AM Changeset in webkit [159687] by zandobersek@gmail.com

6 edits
5 adds in trunk/LayoutTests

Unreviewed GTK gardening.
Rebaselining after r159575 and r159579.

platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
platform/gtk/editing/deleting/delete-by-word-001-expected.txt: Added.
platform/gtk/editing/deleting/delete-by-word-002-expected.txt: Added.
platform/gtk/editing/input/option-page-up-down-expected.txt: Added.
platform/gtk/editing/input/scroll-viewport-page-up-down-expected.txt: Added.
platform/gtk/editing/undo/undo-deleteWord-expected.txt: Added.
platform/gtk/fast/block/float/024-expected.txt:
platform/gtk/fast/block/margin-collapse/025-expected.txt:
platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:

7:00 AM Changeset in webkit [159686] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.
Adding failure expectations for tests that regressed with r159572.

platform/gtk/TestExpectations:

3:03 AM Changeset in webkit [159685] by svillar@igalia.com

4 edits
3 adds in trunk

[CSS Grid Layout] Improve content-sized track layout
https://bugs.webkit.org/show_bug.cgi?id=124408

Reviewed by Dean Jackson.

PerformanceTests:

From Blink r156122 by <jchaffraix@chromium.org>

New test to check the performance of layouting grids with content sized tracks.

Layout/auto-grid-lots-of-data.html: Added.

Source/WebCore:

Test: fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html

From Blink r156122 & r157633 by <jchaffraix@chromium.org>

Added a couple of optimizations to speed up the layout of content
based tracks. The idea is to narrow down the conditions for
relayouting when the height of a grid area changes. We basically
just need to layout tracks with percentage heights as they're the
only ones that change.

A new performance test is attached to demonstrate the effect of
these optimizations. We get a ~1000% improvement on a i7 M620
going from 14.5 runs/s to 165 runs/s.

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::logicalContentHeightForChild):
(WebCore::RenderGrid::layoutGridItems):

LayoutTests:

From Blink r157633 by <jchaffraix@chromium.org>

New test to verify that grid items with percentage logical
{min|max}-height resolve their sizes properly.

fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic-expected.txt: Added.
fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html: Added.

1:25 AM Changeset in webkit [159684] by svillar@igalia.com

9 edits
1 add in trunk

[CSS Grid Layout] Run the content-sized tracks sizing algorithm only when required
https://bugs.webkit.org/show_bug.cgi?id=124039

Reviewed by Dean Jackson.

PerformanceTests:

From Blink r156028 and r156168 by <jchaffraix@chromium.org>.

New performance tests for layouts in grids with fixed size tracks.

Layout/fixed-grid-lots-of-data.html: Added.

Source/WebCore:

The current code runs the content sized track sizing algorithm all
the time, which forces a layout even when the track is not
content-sized. This change improves the situation by applying two
optimizations. In the first one, we bail out the algorithm if we
detect that we don't need to run it. And by the second one we
reduce the amount of recomputations by only iterating over the
content sized tracks instead of all of them. Both changes follow
the ideas introduced in Blink r156028 and r156168 by
<jchaffraix@chromium.org>.

As we changed the way we iterate over children (we use the
GridIterator now) the way they're stored in the RenderGrid changes
too. If a item spans through several "cells" inside the grid, we
will have a reference to it on each of them.

These two changes account for a ~3200% improvement on a i7 M620 in
the test that accompanies this change (15.5 vs 520 run/s).

New perf test: PerformanceTests/Layout/fixed-grid-lots-of-data.html

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Keep track
of content sized tracks and only iterate over them.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Early return if there are no tracks to pass to the algorithm.

rendering/RenderGrid.h:
rendering/style/GridLength.h:

(WebCore::GridLength::isContentSized):

rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::isContentSized):

LayoutTests:

From Blink r156028 and r156168 by <jchaffraix@chromium.org>.

Subtle baseline change due to grids triggering less layouts, which
changes the frame rects between 2 subsequent layouts thus changing
the repaint rectangles.

fast/css-grid-layout/grid-item-change-column-repaint-expected.txt:
fast/css-grid-layout/grid-item-change-row-repaint-expected.txt:

1:22 AM Changeset in webkit [159683] by Manuel Rego Casasnovas

2 edits in trunk/Source/WebCore

[CSS Regions] Move code after early break in RenderRegion::repaintFlowThreadContentRectangle
https://bugs.webkit.org/show_bug.cgi?id=124743

Reviewed by Mihnea Ovidenie.

No new tests, covered by existing tests.

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::repaintFlowThreadContentRectangle): Variable
flippedFlowThreadPortionRect is not used before the early break, so we
can move it after and save some unneeded operations.

12:28 AM Changeset in webkit [159682] by Manuel Rego Casasnovas

2 edits in trunk/Source/WebCore

[CSS Regions] Use hasOverflowClip() in RenderRegion
https://bugs.webkit.org/show_bug.cgi?id=124746

Reviewed by Mihnea Ovidenie.

Implement the suggested FIXME in RenderRegion using hasOverflowClip().

No new tests, covered by existing tests.

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::overflowRectForFlowThreadPortion): Use
hasOverflowClip().
(WebCore::RenderRegion::rectFlowPortionForBox): Ditto.

Nov 21, 2013:

9:12 PM Changeset in webkit [159681] by commit-queue@webkit.org

3 edits
2 deletes in trunk/Source

Remove ANGLEGenerated from Windows build.
https://bugs.webkit.org/show_bug.cgi?id=124759

Patch by Alex Christensen <achristensen@webkit.org> on 2013-11-21
Reviewed by Darin Adler.

Source/ThirdParty/ANGLE:

ANGLE.vcxproj/ANGLEGenerated.vcxproj: Removed.
ANGLE.vcxproj/ANGLEGenerated.vcxproj.filters: Removed.

Source/WebKit:

WebKit.vcxproj/WebKit.sln:

Remove references to ANGLEGenerated.vcxproj.

9:03 PM Changeset in webkit [159680] by commit-queue@webkit.org

6 edits
2 adds in trunk

Map the dir attribute to the CSS direction property.
https://bugs.webkit.org/show_bug.cgi?id=124572.

Patch by Frédéric Wang <fred.wang@free.fr> on 2013-11-21
Reviewed by Darin Adler.

Source/WebCore:

Test: mathml/presentation/mstyle-css-attributes.html

mathml/MathMLElement.cpp:

(WebCore::MathMLElement::isPresentationAttribute): reorder attributes
(WebCore::MathMLElement::collectStyleForPresentationAttribute): reorder tags that accept dir
(WebCore::MathMLElement::isMathMLToken): add an inline function to test that a tag corresponds to a MathML Token Element.

mathml/MathMLElement.h:

Follow-up work to address Darin's comments.

LayoutTests:

mathml/presentation/direction-overall-expected.html: test that dir does not apply to msqrt
mathml/presentation/direction-overall.html:
mathml/presentation/mstyle-css-attributes-expected.html: Added.
mathml/presentation/mstyle-css-attributes.html: Added.

Add more tests for presentation attributes on mstyle.

9:01 PM Changeset in webkit [159679] by commit-queue@webkit.org

116 edits in trunk

Remove ENABLE_WORKERS
https://bugs.webkit.org/show_bug.cgi?id=105784

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

Source/autotools/SetupWebKitFeatures.m4:
Source/cmake/WebKitFeatures.cmake:
Source/cmakeconfig.h.cmake:

Source/WebCore:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

Source/WebKit:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/efl:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

ewk/ewk_settings.cpp:

(ewk_settings_memory_cache_clear):

Source/WebKit/win:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

WebWorkersPrivate.cpp:

(WebWorkersPrivate::workerThreadCount):

Source/WTF:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

wtf/FeatureDefines.h:
wtf/nix/FeatureDefinesNix.h:

Tools:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

win/tools/vsprops/FeatureDefines.props:
win/tools/vsprops/FeatureDefinesCairo.props:

8:42 PM Changeset in webkit [159678] by alex.christensen@flexsim.com

2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix after r159632.

platform/network/curl/SSLHandle.cpp:

(WebCore::certVerifyCallback):
Fixed template syntax.

8:24 PM Changeset in webkit [159677] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix a typo (requriements->requirements).

runtime/StackAlignment.h:

8:22 PM Changeset in webkit [159676] by Darin Adler

2 edits in trunk/Tools

Try to fix buildbot Dashboard for people who have not hidden anything.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

Add a null check for hidden platforms.

8:17 PM Changeset in webkit [159675] by commit-queue@webkit.org

7 edits in trunk/Tools

Remove chrome/chromium related things from webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=124493

Patch by Peter Szanka <h868064@stud.u-szeged.hu> on 2013-11-21
Reviewed by Darin Adler.

Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(PortTest.assert_mock_port_works):

Scripts/webkitpy/port/base.py:

(Port.to.setup_environ_for_server):

Scripts/webkitpy/port/mac_unittest.py:

(test_tests_for_other_platforms):

Scripts/webkitpy/port/mock_drt.py:

(MockTestShell.output_for_test):

Scripts/webkitpy/tool/bot/irc_command.py:

(Restart.execute):

Scripts/webkitpy/tool/bot/ircbot_unittest.py:

(IRCBotTest.test_help):

8:05 PM Changeset in webkit [159674] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix build after r159656
https://bugs.webkit.org/show_bug.cgi?id=124755

Patch by Sergio Correia <Sergio Correia> on 2013-11-21
Reviewed by Gyuyoung Kim.

Page title was moved to page load state.

UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:

(WebKit::WebInspectorServer::buildPageList):

7:56 PM Changeset in webkit [159673] by alex.christensen@flexsim.com

1 edit
1 add in trunk/Source/ThirdParty/ANGLE

Unreviewed build fix.

src/libGLESv2/Constants.h: Added from checkout a60e0805721f62c28a55faf2df74472cc5fc91fc.

7:49 PM Changeset in webkit [159672] by commit-queue@webkit.org

3 edits in trunk/Tools

In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=124717

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-21
Reviewed by Ryosuke Niwa.

Scripts/webkitpy/style/filereader.py:

(TextFileReader.process_file):

Scripts/webkitpy/style/filereader_unittest.py:

(TextFileReaderTest.test_process_filedoes_not_exist):

7:17 PM Changeset in webkit [159671] by betravis@adobe.com

13 edits in trunk

Web Inspector: [CSS Shapes] Refactor highlighting code to decrease Shapes API surface
https://bugs.webkit.org/show_bug.cgi?id=124737

Reviewed by Timothy Hatcher.

Source/WebCore:

Add a virtual method to Shapes, buildPath, that can be used to build the
path (in the Shape coordinate system) for display in the Inspector. This allows us
to remove methods such as type(), polygon(), and logicalRx/Ry() which exposed the
inner workings of the Shapes classes. Also covers the addition of the BoxShape type.

Refactoring, existing test is inspector-protocol/model/highlight-shape-outside.html.

inspector/InspectorOverlay.cpp:

(WebCore::appendPathCommandAndPoints): Points need to be translated from shape space
to renderer space using ShapeInfo.
(WebCore::buildObjectForShapeOutside): Add the ShapeOutsideInfo to the path info struct.

rendering/shapes/BoxShape.cpp:

(WebCore::BoxShape::buildPath): Build the path for a BoxShape.

rendering/shapes/BoxShape.h:
rendering/shapes/PolygonShape.cpp:

(WebCore::PolygonShape::buildPath): Build the path for a PolygonShape.

rendering/shapes/PolygonShape.h:
rendering/shapes/RasterShape.h:
rendering/shapes/RectangleShape.cpp:

(WebCore::RectangleShape::buildPath): Build the path for a RectangleShape.

rendering/shapes/RectangleShape.h:
rendering/shapes/Shape.h:

LayoutTests:

The shapes paths are now drawn in shape-coordinate space before being translated to
renderer space. With different writing modes, shapes may have their coordinates
translated. For example, a rectangle specified as four points [top left, top right,
bottom right, bottom left] in vertical-lr space would appear as [top left, bottom left,
bottom right, top right] in horizontal-tb space. Adjusting the previous tests, and
adding a test for the new box value.

inspector-protocol/model/highlight-shape-outside-expected.txt:
inspector-protocol/model/highlight-shape-outside.html:

7:12 PM Changeset in webkit [159670] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

CodeBlock::m_numCalleeRegisters need to honor native stack alignment.
https://bugs.webkit.org/show_bug.cgi?id=124754.

Reviewed by Filip Pizlo.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::newRegister):

dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

7:04 PM Changeset in webkit [159669] by mrowe@apple.com

13 edits in trunk

<https://webkit.org/b/124702> Stop overriding VALID_ARCHS.

All modern versions of Xcode set it appropriately for our needs.

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

Configurations/Base.xcconfig:

Source/WebCore:

Configurations/Base.xcconfig:

Source/WebInspectorUI:

Configurations/Base.xcconfig:

Source/WebKit/mac:

Configurations/Base.xcconfig:

Source/WebKit2:

Configurations/Base.xcconfig:

Tools:

MiniBrowser/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/Base.xcconfig:

7:01 PM Changeset in webkit [159668] by commit-queue@webkit.org

2 edits
2 adds in trunk/Tools

webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
https://bugs.webkit.org/show_bug.cgi?id=124676

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-21
Reviewed by Daniel Bates.

checkForArgumentAndRemoveFromArrayRef functions was removing wrong
elements when there were more then one occurrence of that argument.
E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
{b, a}, when it should be {b, c}.

Scripts/webkitdirs.pm:

(checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.

Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:

Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.

7:01 PM Changeset in webkit [159667] by ryumiel@company100.net

4 edits in trunk/Source

[GTK] Unreviewed buildfix after r159614 and r159656.

Source/WebCore:

bindings/gobject/WebKitDOMCustom.cpp: Add missing header

Source/WebKit2:

UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::buildPageList): Use the page load state to get page title.

6:59 PM Changeset in webkit [159666] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix WinCairo unreachable code warnings in SimpleLineLayout.cpp
https://bugs.webkit.org/show_bug.cgi?id=124704

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-21
Reviewed by Antti Koivisto.

Fix unreachable code warnings using conditional directives.

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

6:57 PM Changeset in webkit [159665] by mrowe@apple.com

12 edits in trunk/Source

<https://webkit.org/b/124701> Fix an error in a few Xcode configuration setting files.

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig:

Source/WebCore:

Configurations/Base.xcconfig:

Source/WebKit/mac:

Configurations/Base.xcconfig:

Source/WebKit2:

Configurations/Base.xcconfig:

Source/WTF:

Configurations/Base.xcconfig:

6:56 PM Changeset in webkit [159664] by rniwa@webkit.org

2 edits in trunk/Tools

Update build-webkit after r159550.

Scripts/webkitperl/FeatureList.pm:

6:55 PM Changeset in webkit [159663] by mrowe@apple.com

8 edits in trunk/Source

<https://webkit.org/b/124700> Fix some deprecation warnings.

Reviewed by Anders Carlsson.

Source/WebCore:

platform/mac/HTMLConverter.mm:

(fileWrapperForURL): Move off a deprecated NSFileWrapper method.

Source/WebKit/mac:

Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::startStream): Move off a deprecated NSData method.

WebView/WebDataSource.mm:

(-[WebDataSource _fileWrapperForURL:]): Move off a deprecated NSFileWrapper method.

WebView/WebHTMLView.mm:

(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.

Source/WebKit2:

UIProcess/API/mac/WKView.mm:

(-[WKView namesOfPromisedFilesDroppedAtDestination:]): Move off a deprecated NSFileWrapper method.

6:53 PM Changeset in webkit [159662] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[EFL] Layout tests with editing need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124751

Unreviewed, EFL rebaseline.

editing/input/reveal-caret-of-multiline-contenteditable.html test is rebaselined after r137239.
editing/selection/5354455-2.html test is rebaselined after r133000.
Rebaseline the expected results to suit editing-related performance in EFL.

Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-21

platform/efl-wk1/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
platform/efl/editing/selection/5354455-2-expected.txt:

6:38 PM Changeset in webkit [159661] by Lucas Forschler

2 edits in trunk/Tools

Update apple builders.

6:20 PM Changeset in webkit [159660] by rniwa@webkit.org

2 edits
49 adds in trunk/LayoutTests

Import some W3C tests for HTML template element
https://bugs.webkit.org/show_bug.cgi?id=124699

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Imported the shared resources for web-platform-tests/html-templates as well as tests under
serializing-html-templates and template-element at a274ad93ef5dc02ac042e0a5d58327d4135178ac.

ChangeLog: Added.
html-templates/resources/end-template-tag-in-body.html: Added.
html-templates/resources/end-template-tag-in-head.html: Added.
html-templates/resources/frameset-end-tag.html: Added.
html-templates/resources/head-template-contents-div-no-end-tag.html: Added.
html-templates/resources/head-template-contents-table-no-end-tag.html: Added.
html-templates/resources/html-start-tag.html: Added.
html-templates/resources/template-child-nodes-div.xhtml: Added.
html-templates/resources/template-child-nodes-nested.xhtml: Added.
html-templates/resources/template-contents-attribute.html: Added.
html-templates/resources/template-contents-body.html: Added.
html-templates/resources/template-contents-div-no-end-tag.html: Added.
html-templates/resources/template-contents-empty.html: Added.
html-templates/resources/template-contents-frameset.html: Added.
html-templates/resources/template-contents-head.html: Added.
html-templates/resources/template-contents-html.html: Added.
html-templates/resources/template-contents-nested.html: Added.
html-templates/resources/template-contents-table-no-end-tag.html: Added.
html-templates/resources/template-contents-text.html: Added.
html-templates/resources/template-contents.html: Added.
html-templates/resources/template-descendant-body.html: Added.
html-templates/resources/template-descendant-frameset.html: Added.
html-templates/resources/template-descendant-head.html: Added.
html-templates/resources/two-templates.html: Added.
html-templates/serializing-html-templates/outerhtml-expected.txt: Added.
html-templates/serializing-html-templates/outerhtml.html: Added.
html-templates/template-element/content-attribute-expected.txt: Added.
html-templates/template-element/content-attribute.html: Added.
html-templates/template-element/node-document-changes-expected.txt: Added.
html-templates/template-element/node-document-changes.html: Added.
html-templates/template-element/template-as-a-descendant-expected.txt: Added.
html-templates/template-element/template-as-a-descendant.html: Added.
html-templates/template-element/template-content-expected.txt: Added.
html-templates/template-element/template-content-node-document-expected.txt: Added.
html-templates/template-element/template-content-node-document.html: Added.
html-templates/template-element/template-content.html: Added.
html-templates/template-element/template-descendant-body-expected.txt: Added.
html-templates/template-element/template-descendant-body.html: Added.
html-templates/template-element/template-descendant-frameset-expected.txt: Added.
html-templates/template-element/template-descendant-frameset.html: Added.
html-templates/template-element/template-descendant-head-expected.txt: Added.
html-templates/template-element/template-descendant-head.html: Added.
html-templates/testcommon.js: Added.

LayoutTests:

imported/w3c/: Added.
platform/win/TestExpectations: Skip the imported tests since the template element is disabled on Windows.

6:12 PM Changeset in webkit [159659] by dino@apple.com

3 edits in trunk/Tools

Don't fetch hidden platforms on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=124750

Reviewed by Tim Horton.

If a platform is hidden, don't fetch its data. If it
becomes unhidden, try to fetch immediately (unless
you've recently fetched).

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

5:29 PM Changeset in webkit [159658] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Didn't mean to commit this.

UIProcess/PageLoadState.h:

5:16 PM Changeset in webkit [159657] by Brent Fulgham

2 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed gardening to hide annoying *.user files when.

ANGLE.vcxproj: Added property svn:ignore.

5:13 PM Changeset in webkit [159656] by andersca@apple.com

6 edits in trunk/Source/WebKit2

Move page title handling to the page load state
https://bugs.webkit.org/show_bug.cgi?id=124748

Reviewed by Dan Bernstein.

UIProcess/API/C/WKPage.cpp:

(WKPageCopyTitle):

UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::reset):
(WebKit::PageLoadState::didCommitLoad):
(WebKit::PageLoadState::title):
(WebKit::PageLoadState::setTitle):

UIProcess/PageLoadState.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveTitleForFrame):

UIProcess/WebPageProxy.h:

5:11 PM Changeset in webkit [159655] by msaboff@apple.com

4 edits in trunk/Source/JavaScriptCore

ARM64: Implement push/pop equivalents in LLInt
https://bugs.webkit.org/show_bug.cgi?id=124721

Reviewed by Filip Pizlo.

Added pushLRAndFP and popLRAndFP that push and pop the link register and frame pointer register.
These ops emit code just like what the compiler emits in the prologue and epilogue. Also changed
pushCalleeSaves and popCalleeSaves to use the same store pair and load pair instructions to do
the actually pushing and popping. Finally changed the implementation of push and pop to raise
an exception since we don't have (or need) a single register push or pop.

llint/LowLevelInterpreter64.asm:
offlineasm/arm64.rb:
offlineasm/instructions.rb:

4:46 PM Changeset in webkit [159654] by msaboff@apple.com

3 edits in trunk/Source/JavaScriptCore

JSC: Removed unused opcodes from offline assembler
https://bugs.webkit.org/show_bug.cgi?id=124749

Reviewed by Mark Hahnenberg.

Removed the unused, X86 only peekq and pokeq.

offlineasm/instructions.rb:
offlineasm/x86.rb:

4:31 PM Changeset in webkit [159653] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

REGRESSION(159395) Fix branch8(…, AbsoluteAddress, …) in ARM64 MacroAssembler
https://bugs.webkit.org/show_bug.cgi?id=124688

Reviewed by Geoffrey Garen.

Changed handling of the address for the load8() in the branch8(AbsoluteAddress) to be like
the rest of the branchXX(AbsoluteAddress) fucntions.

assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::branch8):

3:55 PM Changeset in webkit [159652] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

BytecodeGenerator should align the stack according to native conventions
https://bugs.webkit.org/show_bug.cgi?id=124735

Reviewed by Mark Lam.

bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):

bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):

3:24 PM Changeset in webkit [159651] by dbates@webkit.org

2 edits in trunk/Source/WebCore

[iOS] Build fix; export symbol for WebCore::provideDeviceOrientationTo()

Add the symbol ZN7WebCore26provideDeviceOrientationToEPNS_4PageEPNS_23DeviceOrientationClientE.

WebCore.exp.in:

3:21 PM Changeset in webkit [159650] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard
https://bugs.webkit.org/show_bug.cgi?id=124741

Reviewed by Alexey Proskuryakov.

Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard around code that is unused
when building with feature NETWORK_CFDATA_ARRAY_CALLBACK.

Additionally, add a declaration for allocateSegment() with attribute WARN_UNUSED_RETURN
to have the compiler warn when the return value of this function is unused. Together with
warnings treated as errors this change will prevent a memory leak.

platform/SharedBuffer.cpp:

3:20 PM Changeset in webkit [159649] by dbates@webkit.org

5 edits in trunk/Source

Remove unused functions from WebCore and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124739

Reviewed by Alexey Proskuryakov.

Source/WebCore:

editing/markup.cpp: Remove unused functions isHTMLBlockElement and

ancestorToRetainStructureAndAppearanceWithNoRenderer.

rendering/InlineElementBox.cpp: Append newline to the end of the file.

Source/WebKit2:

Remove unused functions autoreleased({WKURLRequestRef, WKURLResponseRef}).

UIProcess/API/mac/WKBrowsingContextController.mm:

3:19 PM Changeset in webkit [159648] by dbates@webkit.org

16 edits
11 adds in trunk/Source/WebCore

Only generate isObservable() when IDL specifies GenerateIsReachable
https://bugs.webkit.org/show_bug.cgi?id=124729

Reviewed by Geoffrey Garen.

We should only generate the static inline function isObservable() when the IDL
specifies GenerateIsReachable. Otherwise, this function is unused.

Added a new test IDL TestGenerateIsReachable.idl and expected results to test that
we generate isObservable() when an IDL specifies GenerateIsReachable. Additionally,
rebased existing test results.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/test/CPP/WebDOMTestGenerateIsReachable.cpp: Added.
bindings/scripts/test/CPP/WebDOMTestGenerateIsReachable.h: Added.
bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.cpp: Added.
bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.h: Added.
bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachablePrivate.h: Added.
bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Removed unused function isObservable().
bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
bindings/scripts/test/JS/JSTestEventTarget.cpp: Ditto.
bindings/scripts/test/JS/JSTestException.cpp: Ditto.
bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp: Added.
bindings/scripts/test/JS/JSTestGenerateIsReachable.h: Added.
bindings/scripts/test/JS/JSTestInterface.cpp: Removed unused function isObservable().
bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: Ditto.
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
bindings/scripts/test/JS/JSTestTypedefs.cpp: Ditto.
bindings/scripts/test/JS/JSattribute.cpp: Ditto.
bindings/scripts/test/JS/JSreadonly.cpp: Ditto.
bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.h: Added.
bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.mm: Added.
bindings/scripts/test/ObjC/DOMTestGenerateIsReachableInternal.h: Added.
bindings/scripts/test/TestGenerateIsReachable.idl: Added.

2:31 PM Changeset in webkit [159647] by Csaba Osztrogonác

37 edits
4 moves in trunk/Source/WebKit2

Rename PlatformCertificateInfo to CertificateInfo
https://bugs.webkit.org/show_bug.cgi?id=124150

Reviewed by Darin Adler.

GNUmakefile.list.am:
NetworkProcess/AsynchronousNetworkLoaderClient.cpp:

(WebKit::AsynchronousNetworkLoaderClient::didReceiveResponse):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
NetworkProcess/NetworkResourceLoader.cpp:
NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):

NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):

PlatformEfl.cmake:
PlatformGTK.cmake:
Shared/API/c/mac/WKCertificateInfoMac.mm:

(WKCertificateInfoCreateWithCertficateChain):
(WKCertificateInfoGetCertificateChain):

Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):
(WebKit::AuthenticationManager::useCredentialForChallenge):

Shared/Authentication/AuthenticationManager.h:
Shared/Authentication/AuthenticationManager.messages.in:
Shared/Authentication/mac/AuthenticationManager.mac.mm:

(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):

Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

Shared/WebCertificateInfo.h:

(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::certificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):

Shared/mac/CertificateInfo.h: Renamed from Source/WebKit2/Shared/mac/PlatformCertificateInfo.h.

(WebKit::CertificateInfo::certificateChain):

Shared/mac/CertificateInfo.mm: Renamed from Source/WebKit2/Shared/mac/PlatformCertificateInfo.mm.

(WebKit::CertificateInfo::CertificateInfo):
(WebKit::CertificateInfo::encode):
(WebKit::CertificateInfo::decode):
(WebKit::CertificateInfo::dump):

Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

Shared/soup/CertificateInfo.cpp: Renamed from Source/WebKit2/Shared/soup/PlatformCertificateInfo.cpp.

(WebKit::CertificateInfo::CertificateInfo):
(WebKit::CertificateInfo::~CertificateInfo):
(WebKit::CertificateInfo::encode):
(WebKit::CertificateInfo::decode):

Shared/soup/CertificateInfo.h: Renamed from Source/WebKit2/Shared/soup/PlatformCertificateInfo.h.

(WebKit::CertificateInfo::certificate):
(WebKit::CertificateInfo::tlsErrors):

Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

UIProcess/API/gtk/WebKitCertificateInfo.cpp:

(webkitCertificateInfoGetCertificateInfo):

UIProcess/API/gtk/WebKitCertificateInfoPrivate.h:
UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_tls_info):

UIProcess/Authentication/AuthenticationChallengeProxy.cpp:

(WebKit::AuthenticationChallengeProxy::useCredential):

UIProcess/WebContext.cpp:

(WebKit::WebContext::allowSpecificHTTPSCertificateForHost):

UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didCommitLoad):

UIProcess/WebFrameProxy.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):

WebProcess/Network/WebResourceLoader.h:
WebProcess/Network/WebResourceLoader.messages.in:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:
WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::allowSpecificHTTPSCertificateForHost):

2:28 PM Changeset in webkit [159646] by Csaba Osztrogonác

4 edits in trunk/Source/WebKit2

[EFL][GTK][WK2] Build fix after r159641
https://bugs.webkit.org/show_bug.cgi?id=124742

Patch by Sergio Correia <Sergio Correia> on 2013-11-21
Reviewed by Csaba Osztrogonác.

Should fetch activeURL from page load state.

UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewUpdateURI):

UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:

(WebKit::WebInspectorServer::buildPageList):

UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::buildPageList):

2:26 PM WebKitGTK/Debugging edited by Andres Gomez

(diff)

1:57 PM Changeset in webkit [159645] by Beth Dakin

9 edits in trunk/Source/WebCore

Add a new mode to extend the tile cache beyond the page
https://bugs.webkit.org/show_bug.cgi?id=124216

Reviewed by Simon Fraser.

This patch makes it possible to give the tile cache a margin of tiles. If there is
a margin of tiles, this patch paints those tiles with the background color. Note
that this patch does not actually give the tile cache a margin at this time.

You opt into a margined tiled cache by called setTileMargins() with number of
pixels that the margin on that side should be.

platform/graphics/TiledBacking.h:
platform/graphics/ca/mac/TileController.h:
platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::TileController):
(WebCore::TileController::tilesWouldChangeForVisibleRect):

TileController::bounds() now computes the bounds INCLUDING the margin.
(WebCore::TileController::bounds):

adjustRectAtTileIndexForMargin() is a new function that is required to get the
rect size for tiles in the margin right. rectForTileIndex() assumes all tiles
strive to be the size of m_tileSize, but now margin tiles will be whatever the
margin sizes were set to.
(WebCore::TileController::adjustRectAtTileIndexForMargin):
(WebCore::TileController::rectForTileIndex):

This is another instance where m_tileSize is not always the right size to use.
(WebCore::TileController::getTileIndexRangeForRect):

The tile coverage rect now might include the margin tiles. Only include them in
slow-scrolling mode if the current position is within one tile of the edge.
(WebCore::TileController::computeTileCoverageRect):

tileSizeForCoverageRect() does not make sense in a world where the coverage rect
will include margin. Instead, this patch implements the current strategy more
explicitly by returning the visibleRect in the slow scrolling case, and in the
process this patch also re-names tileSizeForCoverageRect() to computeTileSize()
since it no longer takes a coverageRect.
(WebCore::TileController::computeTileSize):
(WebCore::TileController::revalidateTiles):

New setters and getters for the tile margins on each side.
(WebCore::TileController::setTileMargins):
(WebCore::TileController::hasMargins):
(WebCore::TileController::topMarginHeight):
(WebCore::TileController::bottomMarginHeight):
(WebCore::TileController::leftMarginWidth):
(WebCore::TileController::rightMarginWidth):

New function to add margin onto the composited bounds if there is one.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::tiledBackingHasMargin):
(WebCore::RenderLayerBacking::paintContents):
(WebCore::RenderLayerBacking::compositedBoundsIncludingMargin):

rendering/RenderLayerBacking.h:

Do not set masks to bounds if there is a margin on the root layer.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::mainFrameBackingIsTiledWithMargin):

rendering/RenderLayerCompositor.h:

Allow background color to paint into the margin tiles.

rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

1:55 PM Changeset in webkit [159644] by ap@apple.com

6 edits
4 adds in trunk

Implement WebCrypto wrapKey
https://bugs.webkit.org/show_bug.cgi?id=124738

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html

crypto/subtle/aes-cbc-wrap-rsa.html

bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::exportKey): Factored out the actual operation that can be chained with
encryption for wrapKey.
(WebCore::JSSubtleCrypto::exportKey):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey): Fixed a memory leak in failure code path.

crypto/SubtleCrypto.idl: Added wrapKey.

LayoutTests:

crypto/subtle/aes-cbc-wrap-rsa-expected.txt: Added.
crypto/subtle/aes-cbc-wrap-rsa-non-extractable-expected.txt: Added.
crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html: Added.
crypto/subtle/aes-cbc-wrap-rsa.html: Added.

crypto/subtle/aes-export-key-expected.txt:
crypto/subtle/hmac-export-key-expected.txt:

There is no longer a console message, the error is in an exception.

1:11 PM Changeset in webkit [159643] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, preemptive build fix.

runtime/StackAlignment.h:

(JSC::stackAlignmentBytes):
(JSC::stackAlignmentRegisters):

1:07 PM Changeset in webkit [159642] by fpizlo@apple.com

4 edits
1 add in trunk/Source/JavaScriptCore

JSC should know what the stack alignment conventions are
https://bugs.webkit.org/show_bug.cgi?id=124736

Reviewed by Mark Lam.

GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
runtime/StackAlignment.h: Added.

(JSC::stackAlignmentBytes):
(JSC::stackAlignmentRegisters):

12:30 PM Changeset in webkit [159641] by andersca@apple.com

6 edits in trunk/Source/WebKit2

Fetch all page loading related URLs from the page load state
https://bugs.webkit.org/show_bug.cgi?id=124732

Reviewed by Dan Bernstein.

UIProcess/API/C/WKPage.cpp:

(WKPageCopyActiveURL):
(WKPageCopyProvisionalURL):
(WKPageCopyCommittedURL):

UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController unreachableURL]):

UIProcess/PageLoadState.h:

(WebKit::PageLoadState::provisionalURL):
(WebKit::PageLoadState::url):
(WebKit::PageLoadState::unreachableURL):

UIProcess/WebPageProxy.cpp:
UIProcess/WebPageProxy.h:

12:03 PM Changeset in webkit [159640] by stavila@adobe.com

1 edit
2 adds in trunk/LayoutTests

Added test for :hover and javascript events on the visual overflow of a region.

[CSS Regions] Content in a region's visible overflow does not trigger :hover state, nor JavaScript events
https://bugs.webkit.org/show_bug.cgi?id=112010

Reviewed by Antti Koivisto.

fast/regions/hover-and-js-in-visual-overflow-expected.html: Added.
fast/regions/hover-and-js-in-visual-overflow.html: Added.

12:00 PM Changeset in webkit [159639] by beidson@apple.com

8 edits
2 adds in trunk/Source/WebKit2

Hook up WebProcess-side of getOrEstablishIDBDatabaseMetadata
https://bugs.webkit.org/show_bug.cgi?id=124698

Reviewed by Anders Carlsson.

With this change the IDB API in WebKit2 using the DatabaseProcess finally does something observable:
window.indexedDB.open() sends an error to Javascript.

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata): Continue calling back to the

WebProcess with dummy data, but include the request ID for reference.

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:

Add a new class that wraps a completion callback function and gives it a unique integer identifier.
It also allows for wrapping an abort callback function (in case a connection is lost, for example).
It is templated to flexibly handle any callback function signature.

Shared/AsyncRequest.cpp: Added.

(WebKit::generateRequestID):
(WebKit::AsyncRequest::AsyncRequest):
(WebKit::AsyncRequest::~AsyncRequest):
(WebKit::AsyncRequest::setAbortHandler):
(WebKit::AsyncRequest::requestAborted):
(WebKit::AsyncRequest::clearAbortHandler):

Shared/AsyncRequest.h: Added.

(WebKit::AsyncRequest::requestID):
(WebKit::AsyncRequest::requestCompleted):

WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata): Wrap the completion handler in an

AsyncRequest and save off the request for later use.

(WebKit::WebIDBServerConnection::didGetOrEstablishIDBDatabaseMetadata): Send the results to the AsyncRequest.

WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:

WebKit2.xcodeproj/project.pbxproj:

11:43 AM Changeset in webkit [159638] by andersca@apple.com

4 edits in trunk/Source/WebKit2

Move activeURL getter to PageLoadState
https://bugs.webkit.org/show_bug.cgi?id=124690

Reviewed by Tim Horton.

UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::activeURL):

UIProcess/PageLoadState.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::activeURL):

11:05 AM Changeset in webkit [159637] by ap@apple.com

13 edits
4 adds in trunk

Implement WebCrypto unwrapKey
https://bugs.webkit.org/show_bug.cgi?id=124725

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/aes-cbc-unwrap-failure.html

crypto/subtle/aes-cbc-unwrap-rsa.html

bindings/js/JSCryptoAlgorithmDictionary.cpp:
bindings/js/JSCryptoAlgorithmDictionary.h:

Removed calls for wrap/unwrap parameter parsing, these are just the same as encrypt/decrypt.

bindings/js/JSCryptoOperationData.cpp:

(WebCore::cryptoOperationDataFromJSValue):

bindings/js/JSCryptoOperationData.h:
crypto/CryptoKeySerialization.h:

More Vector<char> elimination.

bindings/js/JSDOMPromise.cpp:
bindings/js/JSDOMPromise.h:

Removed unneccessary copy constructor and assignment operator, they are no diffdrent
than compiler generated ones.

bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::cryptoKeyUsagesFromJSValue): Minor style fixes.
(WebCore::JSSubtleCrypto::encrypt): Ditto.
(WebCore::JSSubtleCrypto::decrypt): Ditto.
(WebCore::JSSubtleCrypto::sign): Ditto.
(WebCore::JSSubtleCrypto::verify): Ditto.
(WebCore::JSSubtleCrypto::generateKey): Ditto.
(WebCore::importKey): Separated actual import operation and the parts that read
arguments from ExecState, and call the promise. Logically, this should be outside
of bindings code even, but JWK makes that quite challenging.
(WebCore::JSSubtleCrypto::importKey): This only does the more mundane arguments
and return parts now.
(WebCore::JSSubtleCrypto::exportKey): Minor style fixes.
(WebCore::JSSubtleCrypto::unwrapKey): Chain decrypt and import.

crypto/CryptoAlgorithm.cpp:

(WebCore::CryptoAlgorithm::encryptForWrapKey):
(WebCore::CryptoAlgorithm::decryptForUnwrapKey):

crypto/CryptoAlgorithm.h:

There are algorithms that expose wrap/unwrap, but not encrypt/decrypt. These will
override these new functions, and leave encrypt/decrypt to raise NOT_SUPPORTED_ERR.

crypto/SubtleCrypto.idl: Added unwrapKey.

LayoutTests:

crypto/subtle/aes-cbc-unwrap-failure-expected.txt: Added.
crypto/subtle/aes-cbc-unwrap-failure.html: Added.
crypto/subtle/aes-cbc-unwrap-rsa-expected.txt: Added.
crypto/subtle/aes-cbc-unwrap-rsa.html: Added.

11:02 AM Changeset in webkit [159636] by commit-queue@webkit.org

2 edits in trunk/Tools

Unreviewed, rolling out r159633.
http://trac.webkit.org/changeset/159633
https://bugs.webkit.org/show_bug.cgi?id=124726

it broke 10 webkitpy tests (Requested by dino_ on #webkit).

Scripts/webkitpy/style/checker.py:

(check_webkit_style_configuration):
(CheckerDispatcher.dispatch):
(StyleProcessorConfiguration):
(StyleProcessorConfiguration.init):
(StyleProcessorConfiguration.write_style_error):

10:32 AM Changeset in webkit [159635] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

[MIPS] Build fails since r159545.
https://bugs.webkit.org/show_bug.cgi?id=124716

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-11-21
Reviewed by Michael Saboff.

Add missing implementations in MacroAssembler and LLInt for MIPS.

assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::sync):

assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::store8):
(JSC::MacroAssemblerMIPS::memoryFence):

offlineasm/mips.rb:

10:21 AM Changeset in webkit [159634] by Simon Fraser

5 edits in trunk/Source/WebKit2

Clean up WebKit2 initialization
https://bugs.webkit.org/show_bug.cgi?id=124696

Reviewed by Sam Weinig.

Call InitializeWebKit2() everywhere we need to do one-time
initialization in WebKit2, rather than having a hotch-potch
of init code.

Shared/APIObject.cpp:

(API::Object::Object):

UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

UIProcess/Launcher/mac/ProcessLauncherMac.mm: Removed an unused #include.
UIProcess/WebContext.cpp:

(WebKit::WebContext::create):

9:44 AM Changeset in webkit [159633] by commit-queue@webkit.org

2 edits in trunk/Tools

Remove the stderr_write attribute from StyleProcessorConfiguration.
https://bugs.webkit.org/show_bug.cgi?id=124703

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-21
Reviewed by Brent Fulgham.

Scripts/webkitpy/style/checker.py:

(check_webkit_style_configuration):
(CheckerDispatcher.dispatch):
(StyleProcessorConfiguration):
(StyleProcessorConfiguration.init):
(StyleProcessorConfiguration.write_style_error):

9:43 AM Changeset in webkit [159632] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[curl]Improve ssl certificate storage and check
https://bugs.webkit.org/show_bug.cgi?id=124569

Patch by Robert Sipka <sipka@inf.u-szeged.hu> on 2013-11-21
Reviewed by Brent Fulgham.

Storage and check the whole certificate chain, not just the root certificate.

platform/network/curl/SSLHandle.cpp:

(WebCore::allowsAnyHTTPSCertificateHosts):
(WebCore::sslIgnoreHTTPSCertificate):
(WebCore::pemData):
(WebCore::certVerifyCallback):

9:41 AM Changeset in webkit [159631] by mitz@apple.com

21 edits in trunk/Source/WebKit2

Reverted r159603, as it appears to have caused Safari’s Web processes to crash on launch.

Requested by Sam Weinig.

Scripts/webkit2/messages.py:

(struct_or_class):

Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
Shared/mac/ObjCObjectGraphCoders.h:
Shared/mac/ObjCObjectGraphCoders.mm:

UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::encodeMessageBody):

UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::didReceiveSyncMessage):

UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):

UIProcess/WebPageGroup.cpp:
UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::sendToAllProcessesInGroup):

UIProcess/WebPageProxy.cpp:

UIProcess/WebPageProxy.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::createWebPage):

UIProcess/WebProcessProxy.h:
WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::webPageGroup):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

9:36 AM Changeset in webkit [159630] by commit-queue@webkit.org

15 edits in trunk/Source

[WinCairo] Building ANGLE libraries fails.
https://bugs.webkit.org/show_bug.cgi?id=124679

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-21
Reviewed by Brent Fulgham.

Source/ThirdParty/ANGLE:

Added/removed files to/from project, and re-added constants.h file.

ANGLE.vcxproj/libEGL.vcxproj:
ANGLE.vcxproj/libEGL.vcxproj.filters:
ANGLE.vcxproj/libGLESv2.vcxproj:
ANGLE.vcxproj/libGLESv2.vcxproj.filters:
ANGLE.vcxproj/libGLESv2Common.props:
ANGLE.vcxproj/translator_common.vcxproj:
ANGLE.vcxproj/translator_common.vcxproj.filters:
ANGLE.vcxproj/translator_glsl.vcxproj:
ANGLE.vcxproj/translator_glsl.vcxproj.filters:
ANGLE.vcxproj/translator_hlsl.vcxproj:
ANGLE.vcxproj/translator_hlsl.vcxproj.filters:
src/libGLESv2/libGLESv2.def:

Source/WebKit:

WebKit.vcxproj/WebKit/WebKitCFLite.props: Link with translator_hlsl.lib.

9:11 AM Changeset in webkit [159629] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

Fix sh4 build after r159545.
https://bugs.webkit.org/show_bug.cgi?id=124713

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-21
Reviewed by Michael Saboff.

Add missing implementations in macro assembler and LLINT for sh4.

assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::store8):
(JSC::MacroAssemblerSH4::memoryFence):

assembler/SH4Assembler.h:

(JSC::SH4Assembler::synco):

offlineasm/sh4.rb: Handle "memfence" opcode.

8:50 AM Changeset in webkit [159628] by stavila@adobe.com

1 edit
4 adds in trunk/LayoutTests

Added test for the overflow of a region being painted across multiple tiles.
Added test for correct repainting of a region's overflow.

[CSS Regions] Overflow areas from regions do not redraw
https://bugs.webkit.org/show_bug.cgi?id=117329

Reviewed by Antti Koivisto.

fast/regions/regions-overflow-tile-expected.html: Added.
fast/regions/regions-overflow-tile.html: Added.
fast/repaint/repaint-regions-overflow-expected.txt: Added.
fast/repaint/repaint-regions-overflow.html: Added.

8:48 AM WebKitGTK/Debugging edited by Andres Gomez

(diff)

8:45 AM WebKitGTK/Debugging edited by Andres Gomez

(diff)

8:44 AM WebKitGTK/Debugging edited by Andres Gomez

(diff)

8:13 AM BuildingGtk edited by Andres Gomez

(diff)

8:12 AM BuildingGtk edited by Andres Gomez

(diff)

8:12 AM BuildingGtk edited by Andres Gomez

(diff)

8:11 AM BuildingGtk edited by Andres Gomez

(diff)

8:00 AM WebKitGTK/StartHacking edited by Andres Gomez

(diff)

7:43 AM Changeset in webkit [159627] by stavila@adobe.com

1 edit
2 adds in trunk/LayoutTests

[CSS Regions] Float get sliced if its container has forced break and is less tall than float
https://bugs.webkit.org/show_bug.cgi?id=124205

Added test for the case when a float is overflowing a region due to a forced break.

Reviewed by Antti Koivisto.

fast/regions/float-slicing-on-forced-break-expected.html: Added.
fast/regions/float-slicing-on-forced-break.html: Added.

7:17 AM Changeset in webkit [159626] by commit-queue@webkit.org

3 edits
2 adds in trunk

Fix hover area for divs with css transforms
https://bugs.webkit.org/show_bug.cgi?id=124647

Patch by Mihai Maerean <Mihai Maerean> on 2013-11-21
Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

Non transformed layers are now being hit last, not through or in-between transformed layers.
The paint order says that the divs creating stacking contexts (including transforms) are painted after the
other siblings so they should be hit tested in the reverse order. Also, a rotated div in a non-rotated parent
should be hit in its entire area, not hit its parent's background, even if the z-coordinate is negative where
the mouse is located.

Test: transforms/3d/hit-testing/hover-rotated-negative-z.html

rendering/RenderLayer.cpp:

(WebCore::computeZOffset):

LayoutTests:

transforms/3d/hit-testing/hover-rotated-negative-z.html: Added.
transforms/3d/hit-testing/hover-rotated-negative-z-expected.txt: Added.

6:58 AM Changeset in webkit [159625] by stavila@adobe.com

1 edit
2 adds in trunk/LayoutTests

Created test for positioned fragmented content which overflows the regions.

[CSS Regions] Fragmented content that is relatively positioned get sliced (and overflows in the next region)
https://bugs.webkit.org/show_bug.cgi?id=117122

Reviewed by Antti Koivisto.

fast/regions/positioned-fragmented-content-expected.html: Added.
fast/regions/positioned-fragmented-content.html: Added.

6:57 AM Changeset in webkit [159624] by stavila@adobe.com

1 edit
2 adds in trunk/LayoutTests

Added test for visual overflow with transformed content in regions.

[CSS Regions] Transform applied to content node causes overflow to be hidden
https://bugs.webkit.org/show_bug.cgi?id=116242

Reviewed by Antti Koivisto.

fast/regions/region-visual-overflow-transform-expected.html: Added.
fast/regions/region-visual-overflow-transform.html: Added.

6:53 AM Changeset in webkit [159623] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK] Release compilation fails when defining "LOG_DISABLED=0"
https://bugs.webkit.org/show_bug.cgi?id=124661

Patch by Andres Gomez <Andres Gomez> on 2013-11-21
Reviewed by Mario Sanchez Prada.

In a "Debug" build the CString.h header comes from another
indirect dependency. Now, we explicitly add this missing include.

html/HTMLTrackElement.cpp: Explicitly adding missing include.

6:52 AM Changeset in webkit [159622] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Fix accessibility media-element expectation
https://bugs.webkit.org/show_bug.cgi?id=124711

Unreviewed EFL gardening.

Changing main element AXRole AXUnknown -> AXEmbedded.

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2013-11-21

platform/efl/accessibility/media-element-expected.txt:

6:25 AM Changeset in webkit [159621] by Michał Pakuła vel Rutka

5 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Update baselines after r159575.

platform/efl/fast/block/float/024-expected.txt:
platform/efl/fast/block/margin-collapse/025-expected.txt:
platform/efl/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
platform/efl/fast/block/margin-collapse/empty-clear-blocks-expected.txt:

5:52 AM Changeset in webkit [159620] by rniwa@webkit.org

3 edits
2 adds in trunk

Fix Range.insertNode when the inserted node is in the same container as the Range
https://bugs.webkit.org/show_bug.cgi?id=123957

Reviewed by Antti Koivisto.

Source/WebCore:

Inspired by https://chromium.googlesource.com/chromium/blink/+/fb6ca1f488703e8d4f20ce6449cc8ea210be6edb

When a node from the same container is inserted, we can't simply adjust m_end with the offset.
Compute m_start and m_end from the inserted nodes instead.

Also, don't adjust m_start and m_end to nodes outside of the document if the inserted nodes had been
removed by mutation events.

Test: fast/dom/Range/range-insertNode-same-container.html

dom/Range.cpp:

(WebCore::Range::insertNode):

LayoutTests:

Merge https://chromium.googlesource.com/chromium/blink/+/fb6ca1f488703e8d4f20ce6449cc8ea210be6edb

Used better labels between divs, and added more evalAndLog and shouldBe so that
the expected result is self-explanatory.

fast/dom/Range/range-insertNode-same-container-expected.txt: Added.
fast/dom/Range/range-insertNode-same-container.html: Added.

5:46 AM Changeset in webkit [159619] by rniwa@webkit.org

4 edits
2 adds in trunk

nextBoundary and previousBoundary are very slow when there is a password field
https://bugs.webkit.org/show_bug.cgi?id=123973

Reviewed by Antti Koivisto.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/57366eec5e3edea54062d4e74c0e047f8681dbad

When iterating through DOM nodes nextBoundary and previousBoundary convert the contents of nodes using
text security to a sequence of 'x' characters. The SimplifiedBackwardsTextIterator and TextIterator
may iterate past node boundaries. Before this patch, the transformation was done looking at the starting
node rather than the current node. In some situations, this replaced all boundaries with 'x' and caused
the text iterator to continue iterating and transforming until the extent of the document.

Test: editing/deleting/password-delete-performance.html

editing/TextIterator.h:

(WebCore::SimplifiedBackwardsTextIterator::node):

editing/VisibleUnits.cpp:

(WebCore::previousBoundary):
(WebCore::nextBoundary):

LayoutTests:

editing/deleting/password-delete-performance-expected.txt: Added.
editing/deleting/password-delete-performance.html: Added.

5:43 AM Changeset in webkit [159618] by rniwa@webkit.org

3 edits
2 adds in trunk

HTML parser should not associate elements inside templates with forms
https://bugs.webkit.org/show_bug.cgi?id=117779

Reviewed by Antti Koivisto.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/45aadf7ee7ee010327eb692066cf013315ef3ed7

When parsing <form><template><input>, the previous behavior was to associate the <input> with the <form>,
even though they're not in the same tree (or even the same document).

This patch changes that by checking, prior to creating a form control element, whether the element to be
created lives in a document with a browsing context.

We don't update m_form as needed to faithfully match the HTML5 specification's form element pointer
http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#form-element-pointer
and its algorithm for creating and inserting nodes:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#creating-and-inserting-nodes

While this leaves isindex's reference to form element pointer stale:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#isindex
The HTML5 specification matches the behaviors of Chrome and Firefox so we leave it as is.

Test: fast/dom/HTMLTemplateElement/no-form-association.html

html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::createHTMLElement):

LayoutTests:

fast/dom/HTMLTemplateElement/no-form-association-expected.txt: Added.
fast/dom/HTMLTemplateElement/no-form-association.html: Added.

5:22 AM Changeset in webkit [159617] by rniwa@webkit.org

4 edits in trunk/Tools

PerfTestRunner._generate_results_dict shouldn't depend on test objects
https://bugs.webkit.org/show_bug.cgi?id=124623

Removed the dependency on test objects from results JSON generation.
This allows single test.run to return metrics for multiple tests

Reviewed by Antti Koivisto.

Scripts/webkitpy/performance_tests/perftest.py:

(PerfTestMetric.init): Takes the test path and test name.
(PerfTestMetric.path): Added.
(PerfTestMetric.test_file_name): Added.
(PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
(PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
The path is going to have the names of subtests at the end once we support them.

Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
(TestPerfTestMetric.test_init_set_time_metric): Ditto.
(TestPerfTestMetric.test_has_values): Ditto.
(TestPerfTestMetric.test_append): Ditto.

Scripts/webkitpy/performance_tests/perftestsrunner.py:

(_generate_results_dict): Only use metrics.
(_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.

4:56 AM WebKitGTK/StartHacking edited by Andres Gomez

(diff)

4:26 AM Changeset in webkit [159616] by Manuel Rego Casasnovas

2 edits in trunk/Tools

REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
https://bugs.webkit.org/show_bug.cgi?id=124697

Reviewed by Ryosuke Niwa.

Scripts/webkitdirs.pm:

(checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
before trying to access to the first element.

12:52 AM Changeset in webkit [159615] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

[GTK] Cannot scroll in option menu when it larger than the screen
https://bugs.webkit.org/show_bug.cgi?id=124671

Reviewed by Martin Robinson.

platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::popUp): Schedule a resize of the popup
menu right after showing it once it has a position.

12:38 AM Changeset in webkit [159614] by Carlos Garcia Campos

12 edits
3 copies in trunk

[GTK] Mark all deprecated symbols in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=124406

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Move deprecated API from WebKitDOMCustom to a new file
WebKitDOMDeprecated leaving in WebKitDOMCustom only the
non-deprecated API that is not autogenerated. Also added the
deprecation decorations and tags in the documentation.

bindings/gobject/GNUmakefile.am:
bindings/gobject/WebKitDOMCustom.cpp:
bindings/gobject/WebKitDOMCustom.h:
bindings/gobject/WebKitDOMCustom.symbols:
bindings/gobject/WebKitDOMDeprecated.cpp: Copied from Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp.

(webkit_dom_blob_webkit_slice):
(webkit_dom_html_element_get_id):
(webkit_dom_html_element_set_id):
(webkit_dom_html_element_get_class_name):
(webkit_dom_html_element_set_class_name):
(webkit_dom_html_element_get_class_list):
(webkit_dom_html_form_element_dispatch_form_change):
(webkit_dom_html_form_element_dispatch_form_input):
(webkit_dom_webkit_named_flow_get_overflow):
(webkit_dom_element_get_webkit_region_overflow):
(webkit_dom_webkit_named_flow_get_content_nodes):
(webkit_dom_webkit_named_flow_get_regions_by_content_node):
(webkit_dom_bar_info_get_property):
(webkit_dom_bar_info_class_init):
(webkit_dom_bar_info_init):
(webkit_dom_bar_info_get_visible):
(webkit_dom_console_get_memory):
(webkit_dom_css_style_declaration_get_property_css_value):
(webkit_dom_document_get_webkit_hidden):
(webkit_dom_document_get_webkit_visibility_state):
(webkit_dom_html_document_open):
(webkit_dom_html_element_set_item_id):
(webkit_dom_html_element_get_item_id):
(webkit_dom_html_element_get_item_ref):
(webkit_dom_html_element_get_item_prop):
(webkit_dom_html_element_set_item_scope):
(webkit_dom_html_element_get_item_scope):
(webkit_dom_html_element_get_item_type):
(webkit_dom_html_style_element_set_scoped):
(webkit_dom_html_style_element_get_scoped):
(webkit_dom_html_properties_collection_get_property):
(webkit_dom_html_properties_collection_class_init):
(webkit_dom_html_properties_collection_init):
(webkit_dom_html_properties_collection_item):
(webkit_dom_html_properties_collection_named_item):
(webkit_dom_html_properties_collection_get_length):
(webkit_dom_html_properties_collection_get_names):
(webkit_dom_node_get_attributes):
(webkit_dom_node_has_attributes):
(webkit_dom_memory_info_get_property):
(webkit_dom_memory_info_class_init):
(webkit_dom_memory_info_init):
(webkit_dom_memory_info_get_total_js_heap_size):
(webkit_dom_memory_info_get_used_js_heap_size):
(webkit_dom_memory_info_get_js_heap_size_limit):
(webkit_dom_micro_data_item_value_class_init):
(webkit_dom_micro_data_item_value_init):
(webkit_dom_performance_get_memory):
(webkit_dom_property_node_list_get_property):
(webkit_dom_property_node_list_class_init):
(webkit_dom_property_node_list_init):
(webkit_dom_property_node_list_item):
(webkit_dom_property_node_list_get_length):
(webkit_dom_html_media_element_get_start_time):
(webkit_dom_html_media_element_get_initial_time):
(webkit_dom_html_head_element_get_profile):
(webkit_dom_html_head_element_set_profile):
(webkit_dom_processing_instruction_get_data):
(webkit_dom_processing_instruction_set_data):

bindings/gobject/WebKitDOMDeprecated.h: Copied from Source/WebCore/bindings/gobject/WebKitDOMCustom.h.
bindings/gobject/WebKitDOMDeprecated.symbols: Copied from Source/WebCore/bindings/gobject/WebKitDOMCustom.symbols.
bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction): Do not include deprecation guards in the cpp file.

bindings/scripts/gobject-generate-headers.pl: Do not create

fordward declarations for non-existent classes like Custom and
Deprecated.

bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(webkit_dom_test_event_target_dispatch_event):

Tools:

Scripts/webkitpy/style/checker.py: Add special case for

WebKitDOMDeprecated.

gtk/generate-gtkdoc:

(get_webkit2_options): Use the prefix of the methods as namespace,
since this is what gtkdoc expects to sort the index.
(get_webkit1_options): Ditto.
(get_webkitdom_options): Ditto.

gtk/generate-webkitdom-doc-files:

(WebKitDOMDocGenerator): Add a global list of deleted objects.
(WebKitDOMDocGenerator.write_deleted_classes): New method to write
the documentation for classes that are deprecated because they
have been removed.
(WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
for deleted classes too.
(WebKitDOMDocGeneratorSections.init): Build a list of
deprecated symbols using the given symbols file.
(WebKitDOMDocGeneratorSections._deleted_class): Returns the
deleted class corresponding to the given function.
(WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
dictionary of deprecated symbols for every class.
(WebKitDOMDocGeneratorSections.write_section): Add also the
deprecated symbols in every section.
(WebKitDOMDocGeneratorSections.write_deleted_classes): Add
sections for deleted classes too.

Nov 20, 2013:

11:52 PM Changeset in webkit [159613] by jae.park@company100.net

6 edits in trunk/Source/WebCore

[CoordinatedGraphics] Use std::unique_ptrs rather than OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=124692

Reviewed by Noam Rosenthal.

No new tests, covered by existing ones.

platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::TiledBackingStore):

platform/graphics/TiledBackingStore.h:
platform/graphics/TiledBackingStoreBackend.h:
platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::createBackingStore):

platform/graphics/texmap/coordinated/CoordinatedTile.h:

11:46 PM Changeset in webkit [159612] by commit-queue@webkit.org

3 edits in trunk/Tools

check-webkit-style should support C++11 rvalue references.
https://bugs.webkit.org/show_bug.cgi?id=123406

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-20
Reviewed by Brent Fulgham.

Scripts/webkitpy/style/checkers/cpp.py:

(check_style):

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(Cpp11StyleTest):
(Cpp11StyleTest.test_rvaule_reference_at_end_of_line):

11:04 PM Changeset in webkit [159611] by beidson@apple.com

15 edits
1 copy in trunk/Source

Add more infrastructure for ServerConnection communication between Web and Database processes
https://bugs.webkit.org/show_bug.cgi?id=124693

Reviewed by Anders Carlsson.

Source/WebCore:

WebCore.exp.in:

Source/WebKit2:

DatabaseProcess/DatabaseToWebProcessConnection.cpp:

(WebKit::DatabaseToWebProcessConnection::establishIDBConnection):
(WebKit::DatabaseToWebProcessConnection::removeDatabaseProcessIDBConnection): Added for WebProcess to be able

to invalidate the DatabaseProcess side of a server connection.

DatabaseProcess/DatabaseToWebProcessConnection.h:
DatabaseProcess/DatabaseToWebProcessConnection.messages.in:

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::DatabaseProcessIDBConnection):
(WebKit::DatabaseProcessIDBConnection::disconnectedFromWebProcess): Added for future cleanup.
(WebKit::DatabaseProcessIDBConnection::establishConnection):
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata): Callback to the WebProcess, even if

it is just dummy data for now.

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:

(WebKit::DatabaseProcessIDBConnection::create):

WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::create): Register the new object with the WebToDatabaseProcessConnection.
(WebKit::WebIDBServerConnection::~WebIDBServerConnection): Remove from the WebToDatabaseProcessConnection.
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::didGetOrEstablishIDBDatabaseMetadata): Callback from the DatabaseProcess,

a no-op for now.

WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in: Copied from Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.messages.in.

WebProcess/Databases/WebToDatabaseProcessConnection.cpp:

(WebKit::WebToDatabaseProcessConnection::didReceiveMessage):
(WebKit::WebToDatabaseProcessConnection::didClose):
(WebKit::WebToDatabaseProcessConnection::registerWebIDBServerConnection): Hold a collection of all

server connections for messaging.

(WebKit::WebToDatabaseProcessConnection::removeWebIDBServerConnection): Remove a connection from the collection,

and also message the DatabaseProcess that it’s gone away.

WebProcess/Databases/WebToDatabaseProcessConnection.h:

Project files, etc etc:

DerivedSources.make:
Scripts/webkit2/messages.py:

(struct_or_class):

WebKit2.xcodeproj/project.pbxproj:

11:00 PM Changeset in webkit [159610] by rniwa@webkit.org

4 edits in trunk

Hoist <template> to head when found between </head> and <body> for consistency with <script>
https://bugs.webkit.org/show_bug.cgi?id=123949

Reviewed by Antti Koivisto.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/835fb468fd211054a920fb7612a6dc5043662495

Move template elements between head and body elements into the head to be consistent with script elements.
The HTML5 specification was changed in http://html5.org/tools/web-apps-tracker?from=8217&to=8218.

Inline comments below are cited from https://www.w3.org/Bugs/Public/show_bug.cgi?id=23002
and https://codereview.chromium.org/25900003 for clarity.

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTag): Add the template element to the list of elements to be hoisted into
the head element.
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):

Replace the assertion that isParsingFragment is true when item->node() == m_tree.openElements()->rootNode() since,
with this change, we can now invoke resetInsertionMode when parsing a normal document (not fragment) and there is
only the html element on the stack of open elements.

For the second change, consider: <head></head><template>

This example breaks in the old HTML parser because the template element is handled by "after head" state which
pushes the head element back on, processes the template element for "in head", then pops the head element off.
EOF is reached, which processes a fake close tag for the template element, which pops the template element off
and resets the insertion mode appropriately

The problem here is that "reset the insertion mode" is going to inspect the bottom-most element on the stack which
is now the html element and it will set the mode to "before head". Nothing good happens after this.

We fix this problem by having the reset algorithm check if the head element pointer is set, and if so, go to after
head instead of before head.

LayoutTests:

Merge https://chromium.googlesource.com/chromium/blink/+/835fb468fd211054a920fb7612a6dc5043662495
and added two more test cases discussed in https://www.w3.org/Bugs/Public/show_bug.cgi?id=23002.

html5lib/resources/template.dat:

10:57 PM Changeset in webkit [159609] by stavila@adobe.com

51 edits
1 copy
18 adds
5 deletes in trunk

[CSS Regions] Implement visual overflow for first & last regions
https://bugs.webkit.org/show_bug.cgi?id=118665

Source/WebCore:

In order to properly propagate the visual overflow of elements flowed inside regions,
the responsiblity of painting and hit-testing content inside flow threads has been
moved to the flow thread layer's level.
Each region keeps the associated overflow with each box in the RenderBoxRegionInfo
structure, including one for the flow thread itself. This data is used during
painting and hit-testing.

Reviewed by David Hyatt.

Tests: fast/regions/overflow-first-and-last-regions-in-container-hidden.html

fast/regions/overflow-first-and-last-regions.html
fast/regions/overflow-nested-regions.html
fast/regions/overflow-region-float.html
fast/regions/overflow-region-inline.html
fast/regions/overflow-region-transform.html

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::setLayoutOverflow):
(WebCore::InlineFlowBox::setVisualOverflow):

rendering/InlineFlowBox.h:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::estimateRegionRangeForBoxChild):
(WebCore::RenderBlock::updateRegionRangeForBoxChild):

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::hasNextPage):
(WebCore::RenderBlockFlow::relayoutForPagination):

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::positionNewFloatOnLine):

rendering/RenderBox.cpp:

(WebCore::RenderBox::borderBoxRectInRegion):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::addVisualOverflow):
(WebCore::RenderBox::isUnsplittableForPagination):
(WebCore::RenderBox::overflowRectForPaintRejection):

rendering/RenderBox.h:

(WebCore::RenderBox::canHaveOutsideRegionRange):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

rendering/RenderBoxModelObject.h:
rendering/RenderBoxRegionInfo.h:

(WebCore::RenderBoxRegionInfo::createOverflow):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::objectShouldPaintInFlowRegion):
(WebCore::RenderFlowThread::mapFromLocalToFlowThread):
(WebCore::RenderFlowThread::mapFromFlowThreadToLocal):
(WebCore::RenderFlowThread::decorationsClipRectForBoxInRegion):
(WebCore::RenderFlowThread::flipForWritingModeLocalCoordinates):
(WebCore::RenderFlowThread::addRegionsOverflowFromChild):
(WebCore::RenderFlowThread::addRegionsVisualOverflow):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):

rendering/RenderFlowThread.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::expandClipRectForRegionAndReflection):
(WebCore::expandClipRectForDescendantsAndReflection):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintForegroundForFragments):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::calculateRects):
(WebCore::RenderLayer::intersectsDamageRect):
(WebCore::RenderLayer::updateDescendantsLayerListsIfNeeded):
(WebCore::RenderLayer::repaintIncludingDescendants):
(WebCore::RenderLayer::paintNamedFlowThreadInsideRegion):
(WebCore::RenderLayer::paintFlowThreadIfRegion):
(WebCore::RenderLayer::hitTestFlowThreadIfRegion):

rendering/RenderLayer.h:

(WebCore::ClipRect::inflateX):
(WebCore::ClipRect::inflateY):
(WebCore::ClipRect::inflate):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):

rendering/RenderListItem.cpp:

(WebCore::RenderListItem::addOverflowFromChildren):

rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
(WebCore::RenderMultiColumnSet::repaintFlowThreadContent):

rendering/RenderMultiColumnSet.h:
rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::createStyle):
(WebCore::RenderNamedFlowFragment::namedFlowThread):

rendering/RenderNamedFlowFragment.h:
rendering/RenderOverflow.h:
rendering/RenderRegion.cpp:

(WebCore::RenderRegion::flowThreadPortionOverflowRect):
(WebCore::RenderRegion::flowThreadPortionLocation):
(WebCore::RenderRegion::regionContainerLayer):
(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
(WebCore::RenderRegion::computeOverflowFromFlowThread):
(WebCore::RenderRegion::repaintFlowThreadContent):
(WebCore::RenderRegion::repaintFlowThreadContentRectangle):
(WebCore::RenderRegion::insertedIntoTree):
(WebCore::RenderRegion::ensureOverflowForBox):
(WebCore::RenderRegion::rectFlowPortionForBox):
(WebCore::RenderRegion::addLayoutOverflowForBox):
(WebCore::RenderRegion::addVisualOverflowForBox):
(WebCore::RenderRegion::layoutOverflowRectForBox):
(WebCore::RenderRegion::visualOverflowRectForBox):
(WebCore::RenderRegion::visualOverflowRectForBoxForPropagation):

rendering/RenderRegion.h:
rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paint):

LayoutTests:

Rebased some tests due to regions layers changes.
Updated some tests to increase clarity. Some of them were only passing because two
regions were close together and the fact that an element was being painted
inside the wrong region was not visible. Floats are now also unsplittable.

bottom-overflow-out-of-first-region
float-pushed-width-change-2
float-pushed-width-change
webkit-flow-float-unable-to-push

Changed top-overflow-out-of-second-region to reftest.

Added new tests for testing the visual overflow in different situations
(transformed, inline, opacity, floating).

Reviewed by David Hyatt.

fast/regions/bottom-overflow-out-of-first-region-expected.html:
fast/regions/bottom-overflow-out-of-first-region.html:
fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html:
fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html:
fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt:
fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt:
fast/regions/element-inflow-fixed-from-outflow-static-expected.txt:
fast/regions/element-outflow-static-from-inflow-fixed-expected.txt:
fast/regions/float-pushed-width-change-2-expected.html:
fast/regions/float-pushed-width-change-2.html:
fast/regions/float-pushed-width-change-expected.html:
fast/regions/float-pushed-width-change.html:
fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Added.
fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Added.
fast/regions/layers/regions-promoted-to-layers-expected.txt: Added.
fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Added.
fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Added.
fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Added.
fast/regions/outline-sides-in-region-expected.html:
fast/regions/outline-sides-in-region.html:
fast/regions/overflow-first-and-last-regions-expected.html: Added.
fast/regions/overflow-first-and-last-regions-in-container-hidden-expected.html: Added.
fast/regions/overflow-first-and-last-regions-in-container-hidden.html: Added.
fast/regions/overflow-first-and-last-regions.html: Added.
fast/regions/overflow-last-region-expected.html: Removed.
fast/regions/overflow-last-region.html: Removed.
fast/regions/overflow-nested-regions-expected.html: Added.
fast/regions/overflow-nested-regions.html: Added.
fast/regions/overflow-region-float-expected.html: Added.
fast/regions/overflow-region-float.html: Added.
fast/regions/overflow-region-inline-expected.html: Added.
fast/regions/overflow-region-inline.html: Added.
fast/regions/overflow-region-transform-expected.html: Added.
fast/regions/overflow-region-transform.html: Added.
fast/regions/overflow-scrollable-rotated-fragment-expected.html:
fast/regions/overflow-scrollable-rotated-fragment.html:
fast/regions/top-overflow-out-of-second-region-expected.html: Copied from LayoutTests/fast/regions/top-overflow-out-of-second-region.html.
fast/regions/top-overflow-out-of-second-region.html:
fast/regions/webkit-flow-float-unable-to-push-expected.html:
fast/regions/webkit-flow-float-unable-to-push.html:
platform/gtk/fast/regions/text-region-split-vertical-rl-expected.txt: Removed.
platform/gtk/TestExpectations: Add new test expectations for failing tests.
platform/efl/TestExpectations: Add new test expectations for failing tests.
platform/mac-wk2/TestExpectations:
platform/mac/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.

10:22 PM Changeset in webkit [159608] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Test a template element appearing after a closing body tag in html5lib
https://bugs.webkit.org/show_bug.cgi?id=123864

Reviewed by Antti Koivisto.

Merge https://chromium.googlesource.com/chromium/blink/+/019d5daa14314972ac6b3e42e9446823ad9cffd2

html5lib/resources/template.dat:

10:10 PM Changeset in webkit [159607] by rniwa@webkit.org

4 edits in trunk

[HTML parser] reset insertion mode appropriate must check for "in select in table" mode
https://bugs.webkit.org/show_bug.cgi?id=123850

Reviewed by Antti Koivisto.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/2cb7523df57dfb48111f6aa16b7138cd54024ba7

The HTML specification has been updated to detect encountering a template element inside of a select element,
which in turn is inside of a table element. In this case, the select element will cause the parser to be in
"InSelectInTable" mode. Thus when the template element closes, it should return to that mode.

The fix here is that resetInsertionModeAppropriately must continue looking up the stack if the first node is
select element to see whether the select element is inside of a table element.

See also: http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#reset-the-insertion-mode-appropriately

Test: html5lib/resources/template.dat

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):

LayoutTests:

html5lib/resources/template.dat:

9:46 PM Changeset in webkit [159606] by mark.lam@apple.com

2 edits in trunk/Source/WebCore

Build fix for last commit.
https://bugs.webkit.org/show_bug.cgi?id=124634.

Not reviewed.

No new tests.

bindings/js/JSCryptoAlgorithmBuilder.cpp:

9:29 PM Changeset in webkit [159605] by mark.lam@apple.com

63 edits
3 adds
1 delete in trunk/Source

Introducing VMEntryScope to update the VM stack limit.
https://bugs.webkit.org/show_bug.cgi?id=124634.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Introduced USE(SEPARATE_C_AND_JS_STACK) (defined in Platform.h). Currently, it is hardcoded to use separate C and JS stacks. Once we switch to using the C stack for JS frames, we'll need to fix this to only be enabled when ENABLE(LLINT_C_LOOP).

Stack limits are now tracked in the VM.

Logically, there are 2 stack limits:

m_stackLimit for the native C stack, and
m_jsStackLimit for the JS stack.

If USE(SEPARATE_C_AND_JS_STACK), then the 2 limits are the same
value, and are implemented as 2 fields in a union.

The VM native stackLimit is set as follows:
1. Initially, the VM sets it to the limit of the stack of the thread that instantiated the VM. This allows the parser and bytecode generator to run before we enter the VM to execute JS code.

Upon entry into the VM to execute JS code (via one of the Interpreter::execute...() functions), we instantiate a VMEntryScope that sets the VM's stackLimit to the limit of the current thread's stack. The VMEntryScope will automatically restore the previous entryScope and stack limit upon destruction.

If USE(SEPARATE_C_AND_JS_STACK), the JSStack's methods will set the VM's
jsStackLimit whenever it grows or shrinks.

The VM now provides a isSafeToRecurse() function that compares the current stack pointer against its native stackLimit. This subsumes and obsoletes the VMStackBounds class.

The VMEntryScope class also subsumes DynamicGlobalObjectScope for tracking the JSGlobalObject that we last entered the VM with.

Renamed dynamicGlobalObject() to vmEntryGlobalObject() since that is the value that the function retrieves.

Changed JIT and LLINT code to do stack checks against the jsStackLimit in the VM class instead of the JSStack.

API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

API/JSContextRef.cpp:

(JSGlobalContextRetain):
(JSGlobalContextRelease):

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitNode):
(JSC::BytecodeGenerator::emitNodeInConditionContext):

debugger/Debugger.cpp:

(JSC::Debugger::detach):
(JSC::Debugger::recompileAllJSFunctions):
(JSC::Debugger::pauseIfNeeded):

debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::vmEntryGlobalObject):

debugger/DebuggerCallFrame.h:
dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

dfg/DFGOSREntry.cpp:
ftl/FTLLink.cpp:

(JSC::FTL::link):

ftl/FTLOSREntry.cpp:
heap/Heap.cpp:

(JSC::Heap::lastChanceToFinalize):
(JSC::Heap::deleteAllCompiledCode):

interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall):

interpreter/CallFrame.cpp:

(JSC::CallFrame::vmEntryGlobalObject):

interpreter/CallFrame.h:
interpreter/Interpreter.cpp:

(JSC::unwindCallFrame):
(JSC::Interpreter::unwind):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::debug):

interpreter/JSStack.cpp:

(JSC::JSStack::JSStack):
(JSC::JSStack::growSlowCase):

interpreter/JSStack.h:
interpreter/JSStackInlines.h:

(JSC::JSStack::shrink):
(JSC::JSStack::grow):

Moved these inlined functions here from JSStack.h. It reduces some #include dependencies of JSSTack.h which had previously resulted in some EWS bots' unhappiness with this patch.

(JSC::JSStack::updateStackLimit):

jit/JIT.cpp:

(JSC::JIT::privateCompile):

jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):

jit/JITCall32_64.cpp:

(JSC::JIT::compileLoadVarargs):

jit/JITOperations.cpp:
llint/LLIntSlowPaths.cpp:
llint/LowLevelInterpreter.asm:
parser/Parser.cpp:

(JSC::::Parser):

parser/Parser.h:

(JSC::Parser::canRecurse):

runtime/CommonSlowPaths.h:
runtime/Completion.cpp:

(JSC::evaluate):

runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

runtime/JSGlobalObject.cpp:
runtime/JSGlobalObject.h:
runtime/StringRecursionChecker.h:

(JSC::StringRecursionChecker::performCheck):

runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::releaseExecutableMemory):
(JSC::VM::throwException):

runtime/VM.h:

(JSC::VM::addressOfJSStackLimit):
(JSC::VM::jsStackLimit):
(JSC::VM::setJSStackLimit):
(JSC::VM::stackLimit):
(JSC::VM::setStackLimit):
(JSC::VM::isSafeToRecurse):

runtime/VMEntryScope.cpp: Added.

(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):
(JSC::VMEntryScope::requiredCapacity):

runtime/VMEntryScope.h: Added.

(JSC::VMEntryScope::globalObject):

runtime/VMStackBounds.h: Removed.

Source/WebCore:

No new tests.

Renamed dynamicGlobalObject() to vmEntryGlobalObject().
Replaced uses of DynamicGlobalObjectScope with VMEntryScope.

ForwardingHeaders/runtime/VMEntryScope.h: Added.
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
bindings/js/JSCryptoAlgorithmBuilder.cpp:

(WebCore::JSCryptoAlgorithmBuilder::add):

bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::create):

bindings/js/JSDOMBinding.cpp:

(WebCore::firstDOMWindow):

bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

bindings/js/JavaScriptCallFrame.h:

(WebCore::JavaScriptCallFrame::vmEntryGlobalObject):

bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::recompileAllJSFunctions):

bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::evaluateBreakpointAction):
(WebCore::ScriptDebugServer::handlePause):

bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):

bindings/objc/WebScriptObject.mm:

(WebCore::addExceptionToConsole):

bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

bridge/objc/objc_instance.mm:

(ObjcInstance::moveGlobalExceptionToExecState):

bridge/objc/objc_runtime.mm:

(JSC::Bindings::convertValueToObjcObject):

bridge/objc/objc_utility.mm:

(JSC::Bindings::convertValueToObjcValue):

Source/WebKit/mac:

WebView/WebScriptDebugger.mm:

(WebScriptDebugger::sourceParsed):

Source/WTF:

wtf/Platform.h:
wtf/StackBounds.h:

(WTF::StackBounds::StackBounds):

8:45 PM Changeset in webkit [159604] by gyuyoung.kim@samsung.com

19 edits in trunk/Source/WebCore

Generate toHTMLFooElement() to clean up static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=124571

Reviewed by Ryosuke Niwa.

Though there are a lot of clean up commits before, there are still
use of static_cast<HTMLFooElement*>. To clean up them, we need to generate
toHTMLDetails|Meta|Summary|TableCaptionElement().

Additionally, other static_cast<> are removed as well.

No new tests, no behavior changes.

html/HTMLDetailsElement.h:
html/HTMLMediaElement.cpp:

(HTMLMediaElement::selectNextSourceChild):

html/HTMLMetaElement.h:
html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk):

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::isDisabledFormControl):

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateWidgetCallback):

html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::detailsElement):

html/HTMLSummaryElement.h:
html/HTMLTableCaptionElement.h:
html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::caption):

html/HTMLTagNames.in:
html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::summaryElement):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::handleFallbackContent):

loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):

page/DragController.cpp:

(WebCore::DragController::canProcessDrag):

page/Frame.cpp:

(WebCore::Frame::searchForLabelsBeforeElement):

page/SpatialNavigation.cpp:

(WebCore::frameOwnerElement):

8:09 PM Changeset in webkit [159603] by weinig@apple.com

21 edits in trunk/Source/WebKit2

WebPageGroup's should keep track of what processes they are being used by
https://bugs.webkit.org/show_bug.cgi?id=124556

Reviewed by Dan Bernstein.

Scripts/webkit2/messages.py:

(struct_or_class):
Mark WebPageGroupData as a struct.

Shared/UserMessageCoders.h:
Shared/mac/ObjCObjectGraphCoders.h:
Shared/mac/ObjCObjectGraphCoders.mm:
WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
UIProcess/WebConnectionToWebProcess.cpp:
UIProcess/WebContext.cpp:
UIProcess/WebContextUserMessageCoders.h:
UIProcess/WebPageProxy.cpp:
UIProcess/WebPageProxy.h:

Pass the WebProcess/WebProcessProxy to both encode and decode.

Shared/WebPageCreationParameters.h:

Pass the page group by ID when creating a page, as it will have had its own
creation message sent already.

UIProcess/WebPageGroup.cpp:
UIProcess/WebPageGroup.h:

Keep track of processes.

UIProcess/WebProcessProxy.cpp:
UIProcess/WebProcessProxy.h:

Keep track of the page groups used by the process.

WebProcess/WebPage/WebPage.cpp:

Get the already created page group on creation.

WebProcess/WebProcess.cpp:
WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

Explicitly create page groups in the WebProcess.

6:00 PM Changeset in webkit [159602] by dino@apple.com

4 edits in trunk/Tools

Allow settings to be shown/hidden on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=124694

Reviewed by Tim Horton.

In preparation for more options/buttons, allow the page to
show or hide all the interactive things using a little gear icon
in the top left corner.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:

(Settings.prototype.toggleSettingsDisplay):

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(div.cellButton.hide):
(div.cellButton.unhide):
(.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
(.settings):
(.settings:hover):
(.settings-visible .settings):

5:59 PM Changeset in webkit [159601] by dino@apple.com

2 edits in trunk/Tools

No need to base64 SVG on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=124687

Reviewed by Tim Horton.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:

(.status-line.good .bubble.pictogram):

5:59 PM Changeset in webkit [159600] by dino@apple.com

3 edits in trunk/Tools

Make links look more like links on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=124686

Reviewed by Tim Horton.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:

(.queue-view .queueLabel:hover):

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:

(.status-line.linked .label:hover):

5:39 PM Changeset in webkit [159599] by commit-queue@webkit.org

2 edits in trunk/Tools

Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
https://bugs.webkit.org/show_bug.cgi?id=124581

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-20
Reviewed by Daniel Bates.

Some subroutines are replicating code from checkForArgument
functions instead of reusing them as is being done by all other functions.

Scripts/webkitdirs.pm:

(determineXcodeSDK): Added.
(determinePassedConfiguration): Added.
(determinePassedArchitecture): Added.
(checkForArgumentAndRemoveFromARGV): Added.
(checkForArgumentAndRemoveFromARGVGettingValue): Added.

5:28 PM Changeset in webkit [159598] by beidson@apple.com

8 edits in trunk/Source/WebKit2

IDB related cleanup in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124691

Reviewed by Enrica Casucci.

WebIDBServerConnection.cpp should use the WebCore namespace and get rid of "WebCore::" throughout
"backendIndentifier" should be renamed to "serverConnectionIdentifier" throughout

DatabaseProcess/DatabaseToWebProcessConnection.cpp:

(WebKit::DatabaseToWebProcessConnection::establishIDBConnection):

DatabaseProcess/DatabaseToWebProcessConnection.h:
DatabaseProcess/DatabaseToWebProcessConnection.messages.in:

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::DatabaseProcessIDBConnection):

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:

(WebKit::DatabaseProcessIDBConnection::create):

WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::generateServerConnectionIdentifier):
(WebKit::WebIDBServerConnection::WebIDBServerConnection):
(WebKit::WebIDBServerConnection::openTransaction):
(WebKit::WebIDBServerConnection::setIndexKeys):
(WebKit::WebIDBServerConnection::createObjectStore):
(WebKit::WebIDBServerConnection::createIndex):
(WebKit::WebIDBServerConnection::deleteIndex):
(WebKit::WebIDBServerConnection::get):
(WebKit::WebIDBServerConnection::put):
(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::count):
(WebKit::WebIDBServerConnection::deleteRange):
(WebKit::WebIDBServerConnection::clearObjectStore):
(WebKit::WebIDBServerConnection::deleteObjectStore):
(WebKit::WebIDBServerConnection::changeDatabaseVersion):
(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):
(WebKit::WebIDBServerConnection::cursorPrefetchIteration):
(WebKit::WebIDBServerConnection::cursorPrefetchReset):

WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:

5:11 PM Changeset in webkit [159597] by beidson@apple.com

3 edits in trunk/Source/WebKit2

Add argument coders for IDBDatabaseMetadata classes
https://bugs.webkit.org/show_bug.cgi?id=124689

Reviewed by Anders Carlsson.

Add coders for:

IDBDatabaseMetadata
IDBIndexMetadata
IDBKeyPath
IDBObjectStoreMetadata

Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

Shared/WebCoreArgumentCoders.h:

5:07 PM Changeset in webkit [159596] by rniwa@webkit.org

5 edits
2 adds in trunk

Clear TemplateContentDocumentFragment::m_host when HTMLTemplateElement is destroyed
https://bugs.webkit.org/show_bug.cgi?id=122806

Reviewed by Antti Koivisto.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/858ed5f6341de9d900768c1f4668fcfce870c52e

The document fragment of a template element outlives the element itself.
Clear the host property on the document fragment when that happens.

Test: fast/dom/HTMLTemplateElement/content-outlives-template-crash.html

dom/TemplateContentDocumentFragment.h:
html/HTMLTemplateElement.cpp:

(WebCore::HTMLTemplateElement::~HTMLTemplateElement):

html/HTMLTemplateElement.h:

LayoutTests:

fast/dom/HTMLTemplateElement/content-outlives-template-crash-expected.txt: Added.
fast/dom/HTMLTemplateElement/content-outlives-template-crash.html: Added.

4:54 PM Changeset in webkit [159595] by commit-queue@webkit.org

3 edits
2 deletes in trunk/Tools

Delete baseline optimizer
https://bugs.webkit.org/show_bug.cgi?id=122333

Patch by Jozsef Berta <jberta@inf.u-szeged.hu> on 2013-11-20
Reviewed by Ryosuke Niwa.

Scripts/webkitpy/common/checkout/baselineoptimizer.py: Removed.
Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: Removed.
Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest.execute):
(AbstractParallelRebaselineCommand._files_to_add):
(AbstractParallelRebaselineCommand._rebaseline):

Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineJson.test_rebaseline_all):
(TestRebaselineJson.test_rebaseline_debug):
(TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):

4:42 PM Changeset in webkit [159594] by Lucas Forschler

5 edits in branches/safari-537.73-branch/Source

Versioning.

4:42 PM Changeset in webkit [159593] by msaboff@apple.com

3 edits in trunk/Source/JavaScriptCore

[Win] JavaScript JIT crash (with DFG enabled).
https://bugs.webkit.org/show_bug.cgi?id=124675

Reviewed by Geoffrey Garen.

Similar to the change in r159427, changed linkClosureCall to use regT0/regT1 (payload/tag) for the callee.
linkForThunkGenerator already expected the callee in regT0/regT1, but changed the comment to reflect that.

jit/Repatch.cpp:

(JSC::linkClosureCall):

jit/ThunkGenerators.cpp:

(JSC::linkForThunkGenerator):

4:41 PM Changeset in webkit [159592] by Lucas Forschler

1 copy in tags/Safari-537.73.13

New Tag.

4:28 PM Changeset in webkit [159591] by Chris Fleizach

16 edits
2 adds in trunk

AX: Implement CSS -webkit-alt property (text alternative for generated content pseudo-elements ::before and ::after)
https://bugs.webkit.org/show_bug.cgi?id=120188

Reviewed by Dean Jackson.

Source/WebCore:

Add a -webkit-alt CSS property that can be used to label Image content or Text content for accessibility clients.

To accomplish this, it sets the string in the RenderStyle. Then when the ContentData creates an anonymous renderer,
it sets that string on the TextFragment or RenderImage, which can be queried by accessibility code.

Test: platform/mac/accessibility/webkit-alt-for-css-content.html

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::alternativeText):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):
(WebCore::objectInclusionFromAltText):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

css/CSSComputedStyleDeclaration.cpp:

(WebCore::altTextToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseAlt):

css/CSSParser.h:
css/CSSPropertyNames.in:
css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

rendering/RenderImage.h:

(WebCore::RenderImage::altText):
(WebCore::RenderImage::setAltText):

rendering/RenderTextFragment.h:
rendering/style/ContentData.cpp:

(WebCore::ImageContentData::createRenderer):
(WebCore::TextContentData::createRenderer):

rendering/style/ContentData.h:

(WebCore::ContentData::setAltText):
(WebCore::ContentData::altText):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setContent):
(WebCore::RenderStyle::setContentAltText):
(WebCore::RenderStyle::contentAltText):

rendering/style/RenderStyle.h:
rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

platform/mac/accessibility/webkit-alt-for-css-content-expected.txt: Added.
platform/mac/accessibility/webkit-alt-for-css-content.html: Added.

4:05 PM Changeset in webkit [159590] by roger_fong@apple.com

2 edits in trunk/Source/WebCore

Use compile flag SH_UNFOLD_SHORT_CIRCUIT when compiling shaders.
https://bugs.webkit.org/show_bug.cgi?id=124684.

Reviewed by Brent Fulgham.

Existing test webgl/1.0.2/conformance/glsl/misc/shader-with-short-circuiting-operators.html

platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

3:55 PM Changeset in webkit [159589] by dino@apple.com

3 edits in trunk/LayoutTests

Unreviewed. Updated expected result following
https://bugs.webkit.org/show_bug.cgi?id=124666

platform/mac/fast/block/margin-collapse/empty-clear-blocks-expected.png:
platform/mac/fast/block/margin-collapse/empty-clear-blocks-expected.txt:

3:36 PM Changeset in webkit [159588] by Lucas Forschler

5 edits
2 copies in branches/safari-537.73-branch

Merged r159481. <rdar://problem/15517466>

3:25 PM Changeset in webkit [159587] by commit-queue@webkit.org

8 edits
2 adds in trunk/Source/WebCore

[curl] Improve detecting and handling of SSL related errors
https://bugs.webkit.org/show_bug.cgi?id=119436

Patch by Robert Sipka <sipka@inf.u-szeged.hu> on 2013-11-20
Reviewed by Brent Fulgham.

Set the exact SSL verification error on CURL
and store the enabled domain with certificate.

WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
platform/network/ResourceHandle.h:
platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

platform/network/curl/ResourceError.h:

(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::sslErrors):
(WebCore::ResourceError::setSSLErrors):

platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate):

platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::ResourceHandleManager::initializeHandle):

platform/network/curl/SSLHandle.cpp: Added.

(WebCore::allowsAnyHTTPSCertificateHosts):
(WebCore::sslIgnoreHTTPSCertificate):
(WebCore::sslCertificateFlag):
(WebCore::pemData):
(WebCore::certVerifyCallback):
(WebCore::sslctxfun):
(WebCore::setSSLVerifyOptions):

platform/network/curl/SSLHandle.h: Added.

3:22 PM Changeset in webkit [159586] by andersca@apple.com

4 edits in trunk

Enable PageLoadTest assertions again
https://bugs.webkit.org/show_bug.cgi?id=124681

Reviewed by Tim Horton.

Source/WebKit2:

Remove an overzealous assertion and re-enable assertions in PageLoadState again.

UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::didCommitLoad):
Remove assertion - it's fine for a page to have a null URL.

(WebKit::PageLoadState::didFinishLoad):
Ditto.

(WebKit::PageLoadState::didFailLoad):
Update the state.

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Actually install all-content-in-one-iframe.html, noticed while debugging this assertion.

2:55 PM Changeset in webkit [159585] by Bem Jones-Bey

16 edits in trunk

[css shapes] Parse new circle shape syntax
https://bugs.webkit.org/show_bug.cgi?id=124618

Reviewed by Antti Koivisto.

Source/WebCore:

Implement parsing of the new cicle shape syntax. The implementation of
the old syntax has been move aside as deprecated, and will be removed
once the new syntax is stable.

Updated existing parsing tests to cover this.

css/BasicShapeFunctions.cpp:

(WebCore::valueForCenterCoordinate): Create a CSSPrimitiveValue from a

BasicShapeCenterCoordinate.

(WebCore::valueForBasicShape): Convert new basic shape and rename old

one.

(WebCore::convertToCenterCoordinate): Create a

BasicShapeCenterCoordinate from a CSSPrimitiveValue.

(WebCore::basicShapeForValue): Convert new shape value and rename old

one.

css/CSSBasicShapes.cpp:

(WebCore::buildCircleString): Build a new circle string.
(WebCore::CSSBasicShapeCircle::cssText): Serialize the new circle

shape.

(WebCore::CSSBasicShapeCircle::equals): Compare new circle shapes.
(WebCore::CSSBasicShapeCircle::serializeResolvingVariables):

css/CSSBasicShapes.h:

(WebCore::CSSBasicShapeCircle::CSSBasicShapeCircle): Add class for new

circle shape.

(WebCore::CSSDeprecatedBasicShapeCircle::create): Renamed to move out

of the way of the new circle implementation.

(WebCore::CSSDeprecatedBasicShapeCircle::centerX): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::centerY): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::radius): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::setCenterX): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::setCenterY): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::setRadius): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::CSSDeprecatedBasicShapeCircle): Ditto.

css/CSSParser.cpp:

(WebCore::CSSParser::parseShapeRadius): Parse the radius for the new

circle syntax. Will also be used by the new ellipse syntax.

(WebCore::CSSParser::parseBasicShapeCircle): Parse the new circle

syntax.

(WebCore::CSSParser::parseDeprecatedBasicShapeCircle): Rename to make

way for the new implementation.

(WebCore::isDeprecatedBasicShape): Check if we have a new circle or an

old circle.

(WebCore::CSSParser::parseBasicShape): Update to parse the new circle

syntax.

css/CSSParser.h:
css/CSSValueKeywords.in: Add support for the new circle keywords.
rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

rendering/style/BasicShapes.cpp: Deprecate old circle and add stub

for layout code.

(WebCore::DeprecatedBasicShapeCircle::path): Rename to make way for

the new implementation.

(WebCore::DeprecatedBasicShapeCircle::blend): Rename to make way for

the new implementation.

(WebCore::BasicShapeCircle::path): Create path for new circle shape.
(WebCore::BasicShapeCircle::blend): Interpolate the new circle shape.

rendering/style/BasicShapes.h:

(WebCore::BasicShapeCenterCoordinate::BasicShapeCenterCoordinate):

Represent an x or y coordinate for the center of a new circle,
since it can be either a keyword along with an offset that cannot
be resolved until layout time or an ordinary Length. This will
also be used by the new ellipse implementation.

(WebCore::BasicShapeCenterCoordinate::keyword):
(WebCore::BasicShapeCenterCoordinate::length):
(WebCore::BasicShapeCenterCoordinate::blend): Interpolate.
(WebCore::BasicShapeRadius::BasicShapeRadius): Represent the radius of

a new circle shape since it can either be a straightforward Length or
a keyword that cannot be resolved until layout time.

(WebCore::BasicShapeRadius::value):
(WebCore::BasicShapeRadius::type):
(WebCore::BasicShapeRadius::blend): Interpolate.
(WebCore::BasicShapeCircle::centerX):
(WebCore::BasicShapeCircle::centerY):
(WebCore::BasicShapeCircle::radius):
(WebCore::BasicShapeCircle::setCenterX):
(WebCore::BasicShapeCircle::setCenterY):
(WebCore::BasicShapeCircle::setRadius):
(WebCore::BasicShapeCircle::BasicShapeCircle): New circle class.
(WebCore::DeprecatedBasicShapeCircle::create): Rename to make room for

new circle implementation.

(WebCore::DeprecatedBasicShapeCircle::DeprecatedBasicShapeCircle): Ditto.

LayoutTests:

Test that the new circle shape syntax is properly parsed.

fast/shapes/parsing/parsing-shape-inside-expected.txt:
fast/shapes/parsing/parsing-shape-outside-expected.txt:
fast/shapes/parsing/parsing-test-utils.js:
fast/masking/parsing-clip-path-shape-expected.txt:
fast/masking/parsing-clip-path-shape.html:

2:22 PM Changeset in webkit [159584] by andersca@apple.com

4 edits in trunk/Source/WebKit2

PageLoadState should keep track of unreachable URLs
https://bugs.webkit.org/show_bug.cgi?id=124677

Reviewed by Dan Bernstein.

UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::reset):
(WebKit::PageLoadState::didStartProvisionalLoad):
(WebKit::PageLoadState::didFailProvisionalLoad):
(WebKit::PageLoadState::setUnreachableURL):

UIProcess/PageLoadState.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadAlternateHTMLString):

2:21 PM Changeset in webkit [159583] by hmuller@adobe.com

7 edits
4 adds in trunk/Source/WebCore

[CSS Shapes] Add BoxShape and FloatRoundingRect classes
https://bugs.webkit.org/show_bug.cgi?id=124368

Reviewed by Dean Jackson.

Added the BoxShape class. It's now used to represent shape-outside box
values: [margin/border/padding/content]-box. BoxShape depends on a new
FloatRoundedRect class, which is a float analog of the existing (int)
RoundedRect class. The FloatRoundedRect class contains the same basic
methods and accessors as BorderRect and adds a set of four methods,
for example topLeftCorner(), that return a FloatRect that represents the
bounds of one elliptical corner. I also added a method, xInterceptsAtY()
that returns two X coordinates of the intersection between a horizontal
line and the rounded rectangle.

No new tests, this is just an internal refactoring.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/FloatRoundedRect.cpp: Added.

(WebCore::FloatRoundedRect::FloatRoundedRect):
(WebCore::FloatRoundedRect::Radii::isZero):
(WebCore::FloatRoundedRect::Radii::scale):
(WebCore::FloatRoundedRect::Radii::expand):
(WebCore::cornerRectIntercept):
(WebCore::FloatRoundedRect::xInterceptsAtY):

platform/graphics/FloatRoundedRect.h: Added.

(WebCore::FloatRoundedRect::Radii::Radii):
(WebCore::FloatRoundedRect::Radii::setTopLeft):
(WebCore::FloatRoundedRect::Radii::setTopRight):
(WebCore::FloatRoundedRect::Radii::setBottomLeft):
(WebCore::FloatRoundedRect::Radii::setBottomRight):
(WebCore::FloatRoundedRect::Radii::topLeft):
(WebCore::FloatRoundedRect::Radii::topRight):
(WebCore::FloatRoundedRect::Radii::bottomLeft):
(WebCore::FloatRoundedRect::Radii::bottomRight):
(WebCore::FloatRoundedRect::Radii::expand):
(WebCore::FloatRoundedRect::Radii::shrink):
(WebCore::FloatRoundedRect::rect):
(WebCore::FloatRoundedRect::radii):
(WebCore::FloatRoundedRect::isRounded):
(WebCore::FloatRoundedRect::isEmpty):
(WebCore::FloatRoundedRect::setRect):
(WebCore::FloatRoundedRect::setRadii):
(WebCore::FloatRoundedRect::move):
(WebCore::FloatRoundedRect::inflate):
(WebCore::FloatRoundedRect::expandRadii):
(WebCore::FloatRoundedRect::shrinkRadii):
(WebCore::FloatRoundedRect::topLeftCorner):
(WebCore::FloatRoundedRect::topRightCorner):
(WebCore::FloatRoundedRect::bottomLeftCorner):
(WebCore::FloatRoundedRect::bottomRightCorner):
(WebCore::operator==):

rendering/shapes/BoxShape.cpp: Added.

(WebCore::BoxShape::BoxShape):
(WebCore::BoxShape::getExcludedIntervals):
(WebCore::BoxShape::getIncludedIntervals):
(WebCore::BoxShape::firstIncludedIntervalLogicalTop):

rendering/shapes/BoxShape.h: Added.
rendering/shapes/Shape.cpp:

(WebCore::createBoxShape):
(WebCore::Shape::createShape):

1:44 PM Changeset in webkit [159582] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Remote Layer Tree: 100% repro crasher on the IPC thread when creating lots of layers
https://bugs.webkit.org/show_bug.cgi?id=124643

Reviewed by Anders Carlsson.

Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::sendOutgoingMessage):
Dynamically allocate storage for the message if needed.

1:29 PM Changeset in webkit [159581] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

machMessageSize uses sizeof(mach_msg_ool_ports_descriptor_t) for out-of-line *memory*
https://bugs.webkit.org/show_bug.cgi?id=124644

Reviewed by Anders Carlsson.

Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::machMessageSize):
mach_msg_ool_descriptor_t is the correct type, given that
out-of-line memory descriptors use the mach_msg_ool_descriptor_t
member of the mach_msg_descriptor_t union.

1:24 PM Changeset in webkit [159580] by dino@apple.com

4 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=124637

Unreviewed. Adding HTMLTemplateElement to global constructor
test, but this time for more platforms. I'm not sure if
GTK and EFL need this too.

platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
platform/mac/js/dom/global-constructors-attributes-expected.txt:
platform/win/js/dom/global-constructors-attributes-expected.txt:

1:23 PM Changeset in webkit [159579] by Antti Koivisto

5 edits
4 adds in trunk

Simple line layout should support floats
https://bugs.webkit.org/show_bug.cgi?id=124666

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/text/simple-lines-float-compare.html

fast/text/simple-lines-float.html

rendering/line/LineWidth.h:

(WebCore::LineWidth::logicalLeftOffset):

Expose the left offset so we don't need to recompute it.

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):
(WebCore::SimpleLineLayout::computeLineLeft):

Include the left offset from floats.

(WebCore::SimpleLineLayout::createTextRuns):

Keep the flow height updated during the loop as LineWidth reads the current position from there.

rendering/SimpleLineLayoutResolver.h:

(WebCore::SimpleLineLayout::RunResolver::Run::rect):
(WebCore::SimpleLineLayout::RunResolver::Run::baseline):
(WebCore::SimpleLineLayout::RunResolver::RunResolver):
(WebCore::SimpleLineLayout::RunResolver::lineIndexForHeight):

We now bake the border and the padding to the line left offset. No need to add it during resolve.

LayoutTests:

fast/text/simple-lines-float-compare-expected.html: Added.
fast/text/simple-lines-float-compare.html: Added.
fast/text/simple-lines-float-expected.html: Added.
fast/text/simple-lines-float.html: Added.

1:18 PM Changeset in webkit [159578] by ap@apple.com

27 edits in trunk/Source/WebCore

Use std::function callbacks in CryptoAlgorithm instead of JS promises
https://bugs.webkit.org/show_bug.cgi?id=124673

Reviewed by Anders Carlsson.

To implement key wrapping/unwrapping, we'll need to chain existing operations.
It's much easier to do with C++ callbacks than with functions fulfilling JS
promises directly.

Also, this will decouple CryptoAlgorithm from JS, which is nice.

SubtleCrypto IDL says that all functions return Promise<any>, but in reality,
there is very little polymorphism, the only function whose return type depends
on algorithm is generateKey (it can create a Key or a KeyPair).

bindings/js/JSDOMPromise.cpp:

(WebCore::PromiseWrapper::PromiseWrapper):
(WebCore::PromiseWrapper::operator=):

bindings/js/JSDOMPromise.h:

Made it copyable, as each crypto function wraps the promise in success and failure
functional objects now.

bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::digest):
(WebCore::JSSubtleCrypto::generateKey):
(WebCore::JSSubtleCrypto::importKey):
(WebCore::JSSubtleCrypto::exportKey):

crypto/CryptoAlgorithm.cpp:

(WebCore::CryptoAlgorithm::encrypt):
(WebCore::CryptoAlgorithm::decrypt):
(WebCore::CryptoAlgorithm::sign):
(WebCore::CryptoAlgorithm::verify):
(WebCore::CryptoAlgorithm::digest):
(WebCore::CryptoAlgorithm::generateKey):
(WebCore::CryptoAlgorithm::deriveKey):
(WebCore::CryptoAlgorithm::deriveBits):
(WebCore::CryptoAlgorithm::importKey):

crypto/CryptoAlgorithm.h:
crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):

crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::generateKey):
(WebCore::CryptoAlgorithmAES_CBC::importKey):

crypto/algorithms/CryptoAlgorithmAES_CBC.h:
crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::generateKey):
(WebCore::CryptoAlgorithmHMAC::importKey):

crypto/algorithms/CryptoAlgorithmHMAC.h:
crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::generateKey):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):

crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
crypto/algorithms/CryptoAlgorithmSHA1.cpp:

(WebCore::CryptoAlgorithmSHA1::digest):

crypto/algorithms/CryptoAlgorithmSHA1.h:
crypto/algorithms/CryptoAlgorithmSHA224.cpp:

(WebCore::CryptoAlgorithmSHA224::digest):

crypto/algorithms/CryptoAlgorithmSHA224.h:
crypto/algorithms/CryptoAlgorithmSHA256.cpp:

(WebCore::CryptoAlgorithmSHA256::digest):

crypto/algorithms/CryptoAlgorithmSHA256.h:
crypto/algorithms/CryptoAlgorithmSHA384.cpp:

(WebCore::CryptoAlgorithmSHA384::digest):

crypto/algorithms/CryptoAlgorithmSHA384.h:
crypto/algorithms/CryptoAlgorithmSHA512.cpp:

(WebCore::CryptoAlgorithmSHA512::digest):

crypto/algorithms/CryptoAlgorithmSHA512.h:
crypto/keys/CryptoKeyRSA.h:
crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::transformAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):

crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):

crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::generatePair):

1:15 PM Changeset in webkit [159577] by msaboff@apple.com

4 edits in trunk/Source/JavaScriptCore

ARMv7: Crash due to use after free of AssemblerBuffer
https://bugs.webkit.org/show_bug.cgi?id=124611

Reviewed by Geoffrey Garen.

Changed JITFinalizer constructor to take a MacroAssemblerCodePtr instead of a Label.
In finalizeFunction(), we use that value instead of calculating it from the label.

assembler/MacroAssembler.cpp:
dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::JITFinalizer):
(JSC::DFG::JITFinalizer::finalizeFunction):

dfg/DFGJITFinalizer.h:

1:02 PM Changeset in webkit [159576] by mrowe@apple.com

2 edits in trunk/Tools

Remove some obsolete logic from WebKit.app.

Reviewed by Alexey Proskuryakov.

WebKitLauncher/WebKitNightlyEnabler.m:

(poseAsWebKitApp): Remove a pre-10.6 codepath.
(enableWebKitNightlyBehaviour): Remove a 10.4-specific codepath.

11:26 AM Changeset in webkit [159575] by robert@webkit.org

10 edits
2 adds in trunk

REGRESSION(r127163): Respect clearance set on ancestors when placing floats
https://bugs.webkit.org/show_bug.cgi?id=119979

Reviewed by David Hyatt.

Source/WebCore:

Refactor the way self-collapsing blocks with clearance are positioned so that they
get the correct logical-top position during margin-collapsing.

Test: fast/block/margin-collapse/self-collapsing-block-with-float-descendants.html

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::clearFloats):
(WebCore::RenderBlockFlow::marginOffsetForSelfCollapsingBlock):
(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::clearFloatsIfNeeded):
(WebCore::RenderBlockFlow::handleAfterSideOfBlock):

rendering/RenderBlockFlow.h:

LayoutTests:

fast/block/float/clear-negative-margin-top-expected.html:
fast/block/float/clear-negative-margin-top.html:
fast/block/margin-collapse/self-collapsing-block-with-float-descendants-expected.html: Added.
fast/block/margin-collapse/self-collapsing-block-with-float-descendants.html: Added.
platform/mac/fast/block/float/024-expected.txt:
platform/mac/fast/block/margin-collapse/025-expected.txt:
platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
platform/mac/fast/block/margin-collapse/empty-clear-blocks-expected.txt:

11:08 AM WebKitGTK/2.2.x edited by vjaquez@igalia.com

I would like to integrate this patch in the release, but, as mrobinson … (diff)

11:03 AM Changeset in webkit [159574] by dino@apple.com

2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=124637

Unreviewed. Adding HTMLTemplateElement to global constructor
test after r159550.

js/dom/global-constructors-attributes-expected.txt:

11:01 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

10:57 AM Changeset in webkit [159573] by dino@apple.com

3 edits in trunk/LayoutTests

Unreviewed. Trying to fix tests added in r159545.

js/regress/global-var-const-infer-fire-from-opt.html:
js/regress/global-var-const-infer.html:

10:44 AM Changeset in webkit [159572] by vjaquez@igalia.com

2 edits in trunk/Source/WebCore

[GTK] Remove Chromium as user agent and claim to be Safari in OS X
https://bugs.webkit.org/show_bug.cgi?id=124229

Reviewed by Martin Robinson.

platform/gtk/UserAgentGtk.cpp:

(WebCore::standardUserAgent):

10:32 AM Changeset in webkit [159571] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Fix CPU(ARM_TRADITIONAL) build after r159545.
https://bugs.webkit.org/show_bug.cgi?id=124649

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-20
Reviewed by Michael Saboff.

Add missing memoryFence, load8 and store8 implementations in macro assembler.

assembler/ARMAssembler.h:

(JSC::ARMAssembler::dmbSY):

assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::load8):
(JSC::MacroAssemblerARM::store8):
(JSC::MacroAssemblerARM::memoryFence):

10:26 AM Changeset in webkit [159570] by commit-queue@webkit.org

21 edits in trunk/Source/WebCore

Unreviewed, rolling out r159551.
http://trac.webkit.org/changeset/159551
https://bugs.webkit.org/show_bug.cgi?id=124669

made many tests asserts (Requested by anttik on #webkit).

html/HTMLDetailsElement.h:
html/HTMLMediaElement.cpp:

(HTMLMediaElement::selectNextSourceChild):

html/HTMLMetaElement.h:
html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk):

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::isDisabledFormControl):

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateWidgetCallback):

html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::detailsElement):

html/HTMLSummaryElement.h:
html/HTMLTableCaptionElement.h:
html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::caption):
(WebCore::HTMLTableElement::tHead):
(WebCore::HTMLTableElement::tFoot):
(WebCore::HTMLTableElement::lastBody):

html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::rowIndex):

html/HTMLTableSectionElement.h:
html/HTMLTagNames.in:
html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::summaryElement):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::handleFallbackContent):

loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):

page/DragController.cpp:

(WebCore::DragController::canProcessDrag):

page/Frame.cpp:

(WebCore::Frame::searchForLabelsBeforeElement):

page/SpatialNavigation.cpp:

(WebCore::frameOwnerElement):

10:24 AM Changeset in webkit [159569] by zoltan@webkit.org

6 edits
2 moves in trunk/Source/WebCore

Move LineWidth.{h,cpp} into rendering/line
<https://webkit.org/b/124448>

Reviewed by David Hyatt.

In r159354 I introduced line directory. Now it's time to move the helper classes of RenderBlockLineLayout into 'line' subdirectory.

No new tests, no behavior change.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
rendering/line/LineWidth.cpp: Renamed from Source/WebCore/rendering/LineWidth.cpp.

(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::fitsOnLineIncludingExtraWidth):
(WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace):
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
(WebCore::LineWidth::commit):
(WebCore::LineWidth::applyOverhang):
(WebCore::LineWidth::fitBelowFloats):
(WebCore::LineWidth::setTrailingWhitespaceWidth):
(WebCore::LineWidth::updateCurrentShapeSegment):
(WebCore::LineWidth::computeAvailableWidthFromLeftAndRight):
(WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace):

rendering/line/LineWidth.h: Renamed from Source/WebCore/rendering/LineWidth.h.

(WebCore::LineWidth::currentWidth):
(WebCore::LineWidth::uncommittedWidth):
(WebCore::LineWidth::committedWidth):
(WebCore::LineWidth::availableWidth):
(WebCore::LineWidth::addUncommittedWidth):
(WebCore::LineWidth::shouldIndentText):

10:09 AM Changeset in webkit [159568] by beidson@apple.com

7 edits in trunk/Source/WebCore

Alphabetization followup to r159567

Reviewed by style-bot :(

Modules/indexeddb/IDBDatabaseBackend.h:
Modules/indexeddb/IDBIndex.h:
Modules/indexeddb/IDBObjectStore.h:
Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
inspector/InspectorIndexedDBAgent.cpp:

10:02 AM Changeset in webkit [159567] by beidson@apple.com

13 edits
1 move in trunk/Source/WebCore

Rename IDBMetadata.h to IDBDatabaseMetadata.h
https://bugs.webkit.org/show_bug.cgi?id=124668

Reviewed by Dean Jackson.

GNUmakefile.list.am:
WebCore.xcodeproj/project.pbxproj:

Modules/indexeddb/IDBDatabase.h:
Modules/indexeddb/IDBDatabaseBackend.h:

Modules/indexeddb/IDBDatabaseMetadata.h: Renamed from Source/WebCore/Modules/indexeddb/IDBMetadata.h.

(WebCore::IDBIndexMetadata::IDBIndexMetadata):
(WebCore::IDBObjectStoreMetadata::IDBObjectStoreMetadata):
(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):

Modules/indexeddb/IDBIndex.h:
Modules/indexeddb/IDBObjectStore.h:
Modules/indexeddb/IDBServerConnection.h:
Modules/indexeddb/IDBTransaction.h:
Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
Modules/indexeddb/leveldb/IDBIndexWriterLevelDB.h:
inspector/InspectorIndexedDBAgent.cpp:

9:57 AM Changeset in webkit [159566] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Remove bogus assertions in updateNameForTreeScope and updateNameForDocument
https://bugs.webkit.org/show_bug.cgi?id=124639

Reviewed by Darin Adler.

Removed assertions. We can't assert that the element in a tree scope or a document
since these two functions are called from removedFrom.

dom/Element.cpp:

(WebCore::Element::updateNameForTreeScope):
(WebCore::Element::updateNameForDocument):

9:02 AM Changeset in webkit [159565] by Michał Pakuła vel Rutka

2 edits in trunk/LayoutTests

Unreviewed EFL gardening

platform/efl/TestExpectations: Add new test expectations for failing tests.

8:02 AM Changeset in webkit [159564] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

[armv7][arm64] Speculative build fix after r159545.
https://bugs.webkit.org/show_bug.cgi?id=124646

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-20
Reviewed by Filip Pizlo.

assembler/ARMv7Assembler.h:
assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::memoryFence):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::memoryFence):

8:00 AM Changeset in webkit [159563] by beidson@apple.com

14 edits in trunk/Source

Cleanup getOrEstablishIDBDatabaseMetadata and stub it out in WK2
https://bugs.webkit.org/show_bug.cgi?id=124635

Reviewed by Tim Horton.

Source/WebCore:

getOrEstablishIDBDatabaseMetadata() should not have to take a database name parameter because the
server connection should already know what database name it represents.

Modules/indexeddb/IDBDatabaseBackend.cpp:

(WebCore::IDBDatabaseBackend::openInternalAsync):

Modules/indexeddb/IDBServerConnection.h:
Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:

(WebCore::IDBServerConnectionLevelDB::IDBServerConnectionLevelDB):
(WebCore::IDBServerConnectionLevelDB::getOrEstablishIDBDatabaseMetadata):

Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:

Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:

(WebCore::IDBFactoryBackendLevelDB::deleteDatabase):
(WebCore::IDBFactoryBackendLevelDB::open):

Source/WebKit2:

Stub out the message for getOrEstablishIDBDatabaseMetadata in the DatabaseProcess.

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::establishConnection):
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata):

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:

Shared/SecurityOriginData.cpp:

(WebKit::SecurityOriginData::fromSecurityOrigin):

Shared/SecurityOriginData.h:

WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::WebIDBServerConnection):
(WebKit::WebIDBServerConnection::deleteDatabase):
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):

WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:

7:49 AM Changeset in webkit [159562] by commit-queue@webkit.org

4 edits in trunk/Tools

Moved stray urls from svn.py and statusserver.py into common.config.urls
https://bugs.webkit.org/show_bug.cgi?id=124650

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-20
Reviewed by Ryosuke Niwa.

Scripts/webkitpy/common/checkout/scm/svn.py:

(SVNRepository):

Scripts/webkitpy/common/config/urls.py:
Scripts/webkitpy/common/net/statusserver.py:

(StatusServer.init):

Scripts/webkitpy/performance_tests/perftestsrunner.py:

(_generate_results_dict):

7:44 AM Changeset in webkit [159561] by commit-queue@webkit.org

5 edits
1 add in trunk

[EFL] <video> and <audio> should be accessible.
https://bugs.webkit.org/show_bug.cgi?id=124494

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2013-11-20
Reviewed by Gyuyoung Kim.

Source/WebCore:

Adding descriptions of media-element controls.

platform/efl/LocalizedStringsEfl.cpp:

(WebCore::localizedMediaControlElementString):

LayoutTests:

Added new accessibility baseline for accessibility/media-elemen.html.

platform/efl-wk1/TestExpectations: test is no longer failing.
platform/efl-wk2/TestExpectations: test is no longer failing.
platform/efl/accessibility/media-element-expected.txt: Added.

7:14 AM Changeset in webkit [159560] by Antti Koivisto

3 edits in trunk/Source/WebCore

Don't paint simple text runs outside the paint rect
https://bugs.webkit.org/show_bug.cgi?id=124651

Reviewed by Anders Carlsson.

This speeds up partial paints for long text paragraphs.
Also add the same optimization for hit testing.

rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow):

Iterate over the run range that needs painting.

(WebCore::SimpleLineLayout::hitTestFlow):

Iterate over the line range that needs painting.

rendering/SimpleLineLayoutResolver.h:

(WebCore::SimpleLineLayout::Range::Range):
(WebCore::SimpleLineLayout::Range::begin):
(WebCore::SimpleLineLayout::Range::end):

Add Range type.

(WebCore::SimpleLineLayout::RunResolver::Iterator::Iterator):
(WebCore::SimpleLineLayout::RunResolver::Iterator::operator++):
(WebCore::SimpleLineLayout::RunResolver::Iterator::advance):
(WebCore::SimpleLineLayout::RunResolver::Iterator::advanceLines):

Optimize case where runCount==lineCount. In this case we can just directly jump
to the right run/line.

(WebCore::SimpleLineLayout::RunResolver::begin):
(WebCore::SimpleLineLayout::RunResolver::end):
(WebCore::SimpleLineLayout::RunResolver::lineIndexForHeight):
(WebCore::SimpleLineLayout::RunResolver::rangeForRect):

Get the range corresponding to a rect. This currently cares about y coordinates only.

(WebCore::SimpleLineLayout::LineResolver::Iterator::operator++):
(WebCore::SimpleLineLayout::LineResolver::Iterator::operator*):
(WebCore::SimpleLineLayout::LineResolver::rangeForRect):

6:55 AM Changeset in webkit [159559] by Antoine Quint

3 edits
4 adds in trunk

Cannot animate "points" attribute for <svg:polygon>
https://bugs.webkit.org/show_bug.cgi?id=21371

Reviewed by Antti Koivisto.

Source/WebCore:

Ensure we use animated list of points for SVG <polygon> and <polyline> elements
when we build the path used to draw them, otherwise the animated changes won't
be rendered and the base value will be used.

Tests: svg/animations/polygon-set.svg

svg/animations/polyline-set.svg

rendering/svg/SVGPathData.cpp:

(WebCore::updatePathFromPolygonElement):
(WebCore::updatePathFromPolylineElement):

LayoutTests:

New tests covering the actual application of the animated value
for the "points" attribute of the SVG <polygon> and <polyline> elements.

svg/animations/polygon-set-expected.svg: Added.
svg/animations/polygon-set.svg: Added.
svg/animations/polyline-set-expected.svg: Added.
svg/animations/polyline-set.svg: Added.

3:12 AM Changeset in webkit [159558] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Configurability test of prototype's properties in fast/dom/webidl-operations-on-node-prototype.html is wrong
https://bugs.webkit.org/show_bug.cgi?id=124602

Reviewed by Darin Adler.

The test case landed in r159100 checks, among other tests, for configurability of properties on the Node's
interface prototype object. The test deletes the tested property from the prototype object and checks that
the property is undefined. This works for the Node's prototype object but is not technically correct since
there might be a property with the same identifier that's located upwards on the prototype chain.

Rather than testing that the property on the prototype object is undefined after it is deleted, a failure
should be reported if the value of the property remains the same even after it's deleted from the object.

fast/dom/webidl-operations-on-node-prototype.html:

2:35 AM Changeset in webkit [159557] by commit-queue@webkit.org

2 edits in trunk/Source/ThirdParty/ANGLE

ANGLE doesn't build with bison 3.0
https://bugs.webkit.org/show_bug.cgi?id=124642

Patch by Sergio Correia <Sergio Correia> on 2013-11-20
Reviewed by Gyuyoung Kim.

This is a reedition of r154109, now that ANGLE source has been updated
in r159533.

src/compiler/glslang.y: Use %lex-param to set YYLEX_PARAM and stop

using the deprecated YYID macro.

2:35 AM Changeset in webkit [159556] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

[GTK] Do not use deprecated callbacks in WebKitPolicyClient
https://bugs.webkit.org/show_bug.cgi?id=124648

Reviewed by Philippe Normand.

Fixes compile warnings for uninitialized callbacks.

UIProcess/API/gtk/WebKitPolicyClient.cpp:

(decidePolicyForNavigationAction): Add originatingFrame parameter.
(decidePolicyForNewWindowAction): Renamed for consistency.
(decidePolicyForResponse): Add canShowMIMEType parameter.
(attachPolicyClientToView): Add new callbacks.

1:48 AM Changeset in webkit [159555] by Carlos Garcia Campos

2 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed. Fix GTK build.

GNUmakefile.am: Remove duplicated entries.

1:22 AM Changeset in webkit [159554] by commit-queue@webkit.org

4 edits in trunk

Unreviewed, rolling out r159496.
http://trac.webkit.org/changeset/159496
https://bugs.webkit.org/show_bug.cgi?id=124641

It caused warning and build break with cmake lower than 2.8.8
(Requested by ryuan on #webkit).

Source/cmake/OptionsEfl.cmake:

Tools:

MiniBrowser/efl/CMakeLists.txt:

12:47 AM Changeset in webkit [159553] by abucur@adobe.com

11 edits in trunk/Source/WebCore

[CSSRegions] Move region styling code into RenderNamedFlowFragment
https://bugs.webkit.org/show_bug.cgi?id=122957

Reviewed by Mihnea Ovidenie.

The patch moves all the region styling functionality outside of RenderRegion
to RenderNamedFlowFragment and outside of RenderFlowThread to RenderNamedFlowThread.
This generates a couple of undesired casts that will be removed in later patches
when everything CSS Regions specific will be located inside RenderNamedFlowThread
and RenderNamedFlowFragment (e.g. the move of the isValid flag, the auto-height
code etc.).

The painting function was also moved from RenderRegion to RenderNamedFlowFragment. It
was only used by the CSS Regions code. The new multi-column implementation has its own
painting mechanism.

Tests: No changed functionality, just refactorings.

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::removeFlowChildInfo):
(WebCore::RenderFlowThread::clearRenderBoxRegionInfoAndCustomStyle):

rendering/RenderFlowThread.h:
rendering/RenderInline.cpp:

(WebCore::RenderInline::updateAlwaysCreateLineBoxes):

rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::RenderNamedFlowFragment):
(WebCore::RenderNamedFlowFragment::styleDidChange):
(WebCore::RenderNamedFlowFragment::checkRegionStyle):
(WebCore::RenderNamedFlowFragment::computeStyleInRegion):
(WebCore::RenderNamedFlowFragment::computeChildrenStyleInRegion):
(WebCore::RenderNamedFlowFragment::setObjectStyleInRegion):
(WebCore::RenderNamedFlowFragment::clearObjectStyleInRegion):
(WebCore::RenderNamedFlowFragment::setRegionObjectsRegionStyle):
(WebCore::RenderNamedFlowFragment::restoreRegionObjectsOriginalStyle):
(WebCore::shouldPaintRegionContentsInPhase):
(WebCore::RenderNamedFlowFragment::paintObject):

rendering/RenderNamedFlowFragment.h:
rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::checkRegionsWithStyling):
(WebCore::RenderNamedFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderNamedFlowThread::removeFlowChildInfo):

rendering/RenderNamedFlowThread.h:
rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::styleDidChange):
(WebCore::RenderRegion::attachRegion):

rendering/RenderRegion.h:
rendering/RenderTreeAsText.cpp:

(WebCore::writeRenderRegionList):

12:30 AM Changeset in webkit [159552] by rgabor@webkit.org

2 edits in trunk/Tools

[EFL] libseccomp-2.0.0 doesn't support ARM architecture
https://bugs.webkit.org/show_bug.cgi?id=124412

Reviewed by Gyuyoung Kim.

Update libseccomp to a newer 2.1.0 version.

efl/jhbuild.modules:

Nov 19, 2013:

11:21 PM Changeset in webkit [159551] by gyuyoung.kim@samsung.com

21 edits in trunk/Source/WebCore

Generate toHTMLFooElement() to clean up static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=124571

Reviewed by Darin Adler.

Though there are a lot of clean up commits before, there are still
use of static_cast<HTMLFooElement*>. To clean up them, we need to generate
toHTMLDetails|Meta|Summary|TableSection|TableCaptionElement().

Additionally, other static_cast<> are removed as well.

No new tests, no behavior changes.

html/HTMLDetailsElement.h:
html/HTMLMediaElement.cpp:

(HTMLMediaElement::selectNextSourceChild):

html/HTMLMetaElement.h:
html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk):

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::isDisabledFormControl):

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateWidgetCallback):

html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::detailsElement):

html/HTMLSummaryElement.h:
html/HTMLTableCaptionElement.h:
html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::caption):
(WebCore::HTMLTableElement::tHead):
(WebCore::HTMLTableElement::tFoot):
(WebCore::HTMLTableElement::lastBody):

html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::rowIndex):

html/HTMLTableSectionElement.h:
html/HTMLTagNames.in:
html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::summaryElement):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::handleFallbackContent):

loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):

page/DragController.cpp:

(WebCore::DragController::canProcessDrag):

page/Frame.cpp:

(WebCore::Frame::searchForLabelsBeforeElement):

page/SpatialNavigation.cpp:

(WebCore::frameOwnerElement):

10:57 PM Changeset in webkit [159550] by rniwa@webkit.org

10 edits in trunk

Enable HTMLTemplateElement on Mac port
https://bugs.webkit.org/show_bug.cgi?id=124637

Reviewed by Tim Horton.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Enabled the feature.

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

LayoutTests:

Unskip template element tests except fast/dom/HTMLTemplateElement/cycles-in-shadow.html
which depends on ENABLE(SHADOW_DOM).

platform/mac/TestExpectations:

10:01 PM Changeset in webkit [159549] by mrowe@apple.com

2 edits in trunk/Tools

<rdar://problem/15487072> Modernize WebKit.app's OS X version checking logic.

Gestalt is deprecated on recent OS X versions so we should switch off it.

Reviewed by Sam Weinig.

WebKitLauncher/main.m:

(currentMacOSXVersion): Retrieve the version string from SystemVersion.plist.
(currentMacOSXMajorVersion): Split the version string at the periods, retrieve the first
two components, then join them back up.
(main): Switch to using currentMacOSXMajorVersion to make it clearer which part of
the version we care about.

9:59 PM Changeset in webkit [159548] by jinwoo7.song@samsung.com

2 edits in trunk/Source/WebCore

Remove unused member function declaration in DocumentOrderedMap.h
https://bugs.webkit.org/show_bug.cgi?id=124629

Reviewed by Ryosuke Niwa.

checkConsistency() is not used anywhere.

dom/DocumentOrderedMap.h:

9:57 PM Changeset in webkit [159547] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, remove completely bogus assertion.

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::addFunction):

9:53 PM Changeset in webkit [159546] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, debug build fix.

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::addFunction):

9:49 PM Changeset in webkit [159545] by fpizlo@apple.com

52 edits
6 adds in trunk

Infer constant global variables
https://bugs.webkit.org/show_bug.cgi?id=124464

Source/JavaScriptCore:

Reviewed by Sam Weinig.

All global variables that are candidates for watchpoint-based constant inference (i.e.
not 'const' variables) will now have WatchpointSet's associated with them and those
are used to drive the inference by tracking three states of each variable:

Uninitialized: the variable's value is Undefined and the WatchpointSet state is

ClearWatchpoint.

Initialized: the variable's value was set to something (could even be explicitly set

to Undefined) and the WatchpointSet state is IsWatching.

Invalidated: the variable's value was set to something else (could even be the same

thing as before but the point is that a put operation did execute again) and the
WatchpointSet is IsInvalidated.

If the compiler tries to compile a GetGlobalVar and the WatchpointSet state is
IsWatching, then the current value of the variable can be folded in place of the get,
and a watchpoint on the variable can be registered.

We handle race conditions between the mutator and compiler by mandating that:

The mutator changes the WatchpointSet state after executing the put.

There is no opportunity to install code or call functions between when the mutator executes a put and changes the WatchpointSet state.

The compiler checks the WatchpointSet state prior to reading the value.

The concrete algorithm used by the mutator is:

Store the new value into the variable. --- Execute a store-store fence.
Bump the state (ClearWatchpoing becomes IsWatching, IsWatching becomes IsInvalidated); the IsWatching->IsInvalidated transition may end up firing watchpoints.

The concrete algorithm that the compiler uses is:

Load the state. If it's *not* IsWatching, then give up on constant inference. --- Execute a load-load fence.
Load the value of the variable and use that for folding, while also registering a DesiredWatchpoint. The various parts of this step can be done in any order.

The desired watchpoint registration will fail if the watchpoint set is already
invalidated. Now consider the following interesting interleavings:

Uninitialized->M1->M2->C1->C2: Compiler sees IsWatching because of the mutator's store

operation, and the variable is folded. The fencing ensures that C2 sees the value
stored in M1 - i.e. we fold on the value that will actually be watchpointed. If
before the compilation is installed the mutator executes another store then we
will be sure that it will be a complete sequence of M1+M2 since compilations get
installed at safepoints and never "in the middle" of a put_to_scope. Hence that
compilation installation will be invalidated. If the M1+M2 sequence happens after
the code is installed, then the code will be invalidated by triggering a jettison.

Uninitialized->M1->C1->C2->M2: Compiler sees Uninitialized and will not fold. This is

a sensible outcome since if the compiler read the variable's value, it would have
seen Undefined.

Uninitialized->C1->C2->M1->M2: Compiler sees Uninitialized and will not fold.
Uninitialized->C1->M1->C2->M2: Compiler sees Uninitialized and will not fold.
Uninitialized->C1->M1->M2->C2: Compiler sees Uninitialized and will not fold.
Uninitialized->M1->C1->M2->C2: Compiler sees Uninitialized and will not fold.

IsWatched->M1->M2->C1->C2: Compiler sees IsInvalidated and will not fold.

IsWatched->M1->C1->C2->M2: Compiler will fold, but will also register a desired

watchpoint, and that watchpoint will get invalidated before the code is installed.

IsWatched->M1->C1->M2->C2: As above, will fold but the code will get invalidated.
IsWatched->C1->C2->M1->M2: As above, will fold but the code will get invalidated.
IsWatched->C1->M1->C2->M2: As above, will fold but the code will get invalidated.
IsWatched->C1->M1->M2->C2: As above, will fold but the code will get invalidated.

Note that this kind of reasoning shows why having the mutator first bump the state and
then store the new value would be wrong. If we had done that (M1 = bump state, M2 =
execute put) then we could have the following deadly interleavings:

Uninitialized->M1->C1->C2->M2:
Uninitialized->M1->C1->M2->C2: Mutator bumps the state to IsWatched and then the

compiler folds Undefined, since M2 hasn't executed yet. Although C2 will set the
watchpoint, M1 didn't notify it - it mearly initiated watching. M2 then stores a
value other than Undefined, and you're toast.

You could fix this sort of thing by making the Desired Watchpoints machinery more
sophisticated, for example having it track the value that was folded; if the global
variable's value was later found to be different then we could invalidate the
compilation. You could also fix it by having the compiler also check that the value of
the variable is not Undefined before folding. While those all sound great, I decided
to instead just use the right interleaving since that results in less code and feels
more intuitive.

This is a 0.5% speed-up on SunSpider, mostly due to a 20% speed-up on math-cordic.
It's a 0.6% slow-down on LongSpider, mostly due to a 25% slow-down on 3d-cube. This is
because 3d-cube takes global variable assignment slow paths very often. Note that this
3d-cube slow-down doesn't manifest as much in SunSpider (only 6% there). This patch is
also a 1.5% speed-up on V8v7 and a 2.8% speed-up on Octane v1, mostly due to deltablue
(3.7%), richards (4%), and mandreel (26%). This is a 2% speed-up on Kraken, mostly due
to a 17.5% speed-up on imaging-gaussian-blur. Something that really illustrates the
slam-dunk-itude of this patch is the wide range of speed-ups on JSRegress. Casual JS
programming often leads to global-var-based idioms and those variables tend to be
assigned once, leading to excellent constant folding opportunities in an optimizing
JIT. This is very evident in the speed-ups on JSRegress.

assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::dmbSY):

assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::dmbSY):

assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::memfence):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load8):
(JSC::MacroAssemblerARMv7::memfence):

assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::load8):
(JSC::MacroAssemblerX86::store8):

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::getUnusedRegister):
(JSC::MacroAssemblerX86Common::store8):
(JSC::MacroAssemblerX86Common::memoryFence):

assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::load8):
(JSC::MacroAssemblerX86_64::store8):

assembler/X86Assembler.h:

(JSC::X86Assembler::movb_rm):
(JSC::X86Assembler::movzbl_mr):
(JSC::X86Assembler::mfence):
(JSC::X86Assembler::X86InstructionFormatter::threeByteOp):
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp8):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

bytecode/Watchpoint.cpp:

(JSC::WatchpointSet::WatchpointSet):
(JSC::WatchpointSet::add):
(JSC::WatchpointSet::notifyWriteSlow):

bytecode/Watchpoint.h:

(JSC::WatchpointSet::state):
(JSC::WatchpointSet::isStillValid):
(JSC::WatchpointSet::addressOfSetIsNotEmpty):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getJSConstantForValue):
(JSC::DFG::ByteCodeParser::getJSConstant):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGNode.h:

(JSC::DFG::Node::isStronglyProvedConstantIn):
(JSC::DFG::Node::hasIdentifierNumberForCheck):
(JSC::DFG::Node::hasRegisterPointer):

dfg/DFGNodeFlags.h:
dfg/DFGNodeType.h:
dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNotifyPutGlobalVar):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLAbbreviatedTypes.h:
ftl/FTLAbbreviations.h:

(JSC::FTL::buildFence):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLIntrinsicRepository.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNotifyPutGlobalVar):

ftl/FTLOutput.h:

(JSC::FTL::Output::fence):

jit/JIT.h:
jit/JITOperations.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emitPutGlobalVar):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitSlow_op_put_to_scope):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitPutGlobalVar):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitSlow_op_put_to_scope):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
llvm/LLVMAPIFunctions.h:
offlineasm/arm.rb:
offlineasm/arm64.rb:
offlineasm/cloop.rb:
offlineasm/instructions.rb:
offlineasm/x86.rb:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::addGlobalVar):
(JSC::JSGlobalObject::addFunction):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::addVar):
(JSC::JSGlobalObject::addConst):

runtime/JSScope.cpp:

(JSC::abstractAccess):

runtime/JSSymbolTableObject.h:

(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

runtime/SymbolTable.cpp:

(JSC::SymbolTableEntry::couldBeWatched):
(JSC::SymbolTableEntry::prepareToWatch):
(JSC::SymbolTableEntry::notifyWriteSlow):

runtime/SymbolTable.h:

LayoutTests:

Reviewed by Sam Weinig.

js/regress/global-var-const-infer-expected.txt: Added.
js/regress/global-var-const-infer-fire-from-opt-expected.txt: Added.
js/regress/global-var-const-infer-fire-from-opt.html: Added.
js/regress/global-var-const-infer.html: Added.
js/regress/script-tests/global-var-const-infer-fire-from-opt.js: Added.

(foo):
(setA):
(setB):
(check):

js/regress/script-tests/global-var-const-infer.js: Added.

(foo):
(check):

9:19 PM Changeset in webkit [159544] by Seokju Kwon

2 edits in trunk/Source/WebCore

Removal of redundant function call in Editor::insertTextWithoutSendingTextEvent
https://bugs.webkit.org/show_bug.cgi?id=124563

Reviewed by Brent Fulgham.

No new tests needed, no behavior change.

editing/Editor.cpp:

(WebCore::Editor::insertTextWithoutSendingTextEvent):

9:08 PM Changeset in webkit [159543] by roger_fong@apple.com

5 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed. Build fix for Mac.

src/compiler/glslang_tab.cpp:

(yysyntax_error):
(yyerror):

src/compiler/glslang_tab.h:
src/compiler/preprocessor/ExpressionParser.cpp:

(yysyntax_error):

9:04 PM Changeset in webkit [159542] by Martin Robinson

2 edits in trunk/Source/ThirdParty/ANGLE

Fix the GTK+ build after the ANGLE update in r159533

GNUmakefile.am: Update the source list.

7:50 PM Changeset in webkit [159541] by gyuyoung.kim@samsung.com

2 edits in trunk/Source/WebCore

Fix build break after r159533.

CMakeLists.txt: Update ANGLE files.

7:19 PM Changeset in webkit [159540] by commit-queue@webkit.org

3 edits
1 add in trunk/Tools

Unreviewed, rolling out r159538.
http://trac.webkit.org/changeset/159538
https://bugs.webkit.org/show_bug.cgi?id=124627

it broke run-jsc-stress-tests (Requested by mhahnenberg on
#webkit).

Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
Scripts/run-javascriptcore-tests:
Scripts/run-jsc-stress-tests:

7:13 PM Changeset in webkit [159539] by roger_fong@apple.com

2 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed. Prospective build fix for GTK port following r159533.

GNUmakefile.am:

6:51 PM Changeset in webkit [159538] by mhahnenberg@apple.com

3 edits
1 delete in trunk/Tools

run-jsc-stress-tests should be able to package its tests and move them places
https://bugs.webkit.org/show_bug.cgi?id=124549

Reviewed by Geoff Garen and Filip Pizlo.

Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. This script was just a ruby reimplementation

of grep -i -q

Scripts/run-javascriptcore-tests: Pass through the --make-bundle flag.
Scripts/run-jsc-stress-tests: Added the new concept of a "bundle", which is a collection of all tests and any

other files that those tests require to run in any environment along with a fixed root directory into which these
files and their expected directory structure are cloned. The default Bundle class is basically
a no-op so that it functions like run-jsc-stress-tests prior to this patch. MovableBundle is a Bundle that knows
how to translate local paths to bundle paths and does all the work of moving each test file into the right place
inside the .tests directory. After all the test files have been created in jsc-stress-results MovableBundle
creates a tarball of the entire directory for easy relocation. The --make-bundle flag causes run-jsc-stress-tests
to use MovableBundle instead of just Bundle.

6:50 PM Changeset in webkit [159537] by Lucas Forschler

5 edits in branches/safari-537.73-branch/Source

Versioning.

6:49 PM Changeset in webkit [159536] by Lucas Forschler

1 copy in tags/Safari-537.73.12

New Tag.

6:40 PM Changeset in webkit [159535] by commit-queue@webkit.org

6 edits in trunk/LayoutTests

[EFL] Layout tests need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124622

Unreviewed, EFL rebaseline.

EFL tests are rebaselined after r106181, r128728 and r133754.

Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-19

platform/efl-wk2/TestExpectations:
platform/efl/fast/replaced/applet-disabled-positioned-expected.txt:
platform/efl/fast/replaced/applet-rendering-java-disabled-expected.txt:
platform/efl/fast/text/shaping/shaping-script-order-expected.txt:
platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:

6:12 PM Changeset in webkit [159534] by commit-queue@webkit.org

4 edits in trunk/Source

Implement spin control on WinCE port.
https://bugs.webkit.org/show_bug.cgi?id=123254

Patch by Zhuang Zhigang <zhuangzg@cn.fujitsu.com> on 2013-11-19
Reviewed by Brent Fulgham.

rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeWinCE::paintInnerSpinButton):

rendering/RenderThemeWinCE.h:

5:52 PM Changeset in webkit [159533] by roger_fong@apple.com

135 edits
23 adds
8 deletes in trunk/Source

Update ANGLE sources.
https://bugs.webkit.org/show_bug.cgi?id=124615.

Reviewed by Dean Jackson.

Tests covered by Khronos WebGL conformance tests.

Update ANGLE to checkout a60e0805721f62c28a55faf2df74472cc5fc91fc.
Modify xcodeproj files as necessary, update plist.
Stop using DerivedSources.make and just use the generated sources that are checked into ANGLE.
Add a note to bison generated files indicating that Apple elects to distribute said files under the BSD license:
ExpressionParser.cpp, glslang_tab.cpp, glslang_tab.h.

ANGLE.plist:
ANGLE.xcodeproj/project.pbxproj:
DerivedSources.make: Removed.
platform/graphics/ANGLEWebKitBridge.cpp: Resolve a build error that resulted from updating ANGLE.

(WebCore::getSymbolInfo):
(WebCore::ANGLEWebKitBridge::compileShaderSource):

include/EGL/egl.h:
include/EGL/eglsoftlinking.h: Removed.
include/GLES2/gl2.h:
include/GLES2/gl2softlinking.h: Removed.
include/GLSLANG/ShaderLang.h:
include/KHR/khrplatform.h:
src/ANGLE.sln: Added.
src/build_angle.gypi:
src/common/debug.h:
src/common/event_tracer.cpp: Added.

(gl::TraceGetTraceCategoryEnabledFlag):
(gl::TraceAddTraceEvent):

src/common/event_tracer.h: Added.
src/common/version.h:
src/compiler/CodeGen.cpp: Added.

(ConstructCompiler):
(DeleteCompiler):

src/compiler/CodeGenGLSL.cpp: Removed.
src/compiler/CodeGenHLSL.cpp: Removed.
src/compiler/Common.h:

(NewPoolTString):

src/compiler/Compiler.cpp:

(TCompiler::Init):
(TCompiler::compile):
(TCompiler::InitBuiltInSymbolTable):
(TCompiler::clearResults):
(TCompiler::collectVariables):

src/compiler/ConstantUnion.h:
src/compiler/DetectDiscontinuity.cpp:
src/compiler/InfoSink.h:
src/compiler/InitializeDll.cpp:

(InitProcess):
(DetachProcess):

src/compiler/InitializeDll.h:
src/compiler/InitializeGLPosition.cpp: Added.

(InitializeGLPosition::visitAggregate):
(InitializeGLPosition::insertCode):

src/compiler/InitializeGLPosition.h: Added.

(InitializeGLPosition::InitializeGLPosition):
(InitializeGLPosition::visitBinary):
(InitializeGLPosition::visitUnary):
(InitializeGLPosition::visitSelection):
(InitializeGLPosition::visitLoop):
(InitializeGLPosition::visitBranch):

src/compiler/InitializeGlobals.h:
src/compiler/InitializeParseContext.cpp:

(InitializeParseContextIndex):
(FreeParseContextIndex):
(SetGlobalParseContext):
(GetGlobalParseContext):

src/compiler/InitializeParseContext.h:
src/compiler/IntermTraverse.cpp:

(TIntermSymbol::traverse):
(TIntermConstantUnion::traverse):
(TIntermBinary::traverse):
(TIntermUnary::traverse):
(TIntermAggregate::traverse):
(TIntermSelection::traverse):
(TIntermLoop::traverse):
(TIntermBranch::traverse):

src/compiler/Intermediate.cpp:

(GetHigherPrecision):
(getOperatorString):
(TIntermLoop::replaceChildNode):
(TIntermBranch::replaceChildNode):
(TIntermBinary::replaceChildNode):
(TIntermUnary::replaceChildNode):
(TIntermAggregate::replaceChildNode):
(TIntermSelection::replaceChildNode):
(TIntermOperator::isAssignment):
(TIntermediate::promoteConstantUnion):

src/compiler/MapLongVariableNames.cpp:
src/compiler/MapLongVariableNames.h:
src/compiler/NodeSearch.h: Added.

(sh::NodeSearchTraverser::NodeSearchTraverser):
(sh::NodeSearchTraverser::found):
(sh::NodeSearchTraverser::search):
(sh::FindDiscard::visitBranch):
(sh::FindSideEffectRewriting::visitBinary):

src/compiler/OutputGLSLBase.cpp:

(TOutputGLSLBase::visitSelection):
(TOutputGLSLBase::visitAggregate):
(TOutputGLSLBase::visitLoop):

src/compiler/OutputGLSLBase.h:
src/compiler/OutputHLSL.cpp:

(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitBinary):
(sh::OutputHLSL::visitSelection):
(sh::OutputHLSL::visitBranch):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::addConstructor):

src/compiler/OutputHLSL.h:
src/compiler/ParseContext.cpp: Added.

(TParseContext::parseVectorFields):
(TParseContext::parseMatrixFields):
(TParseContext::recover):
(TParseContext::error):
(TParseContext::warning):
(TParseContext::trace):
(TParseContext::assignError):
(TParseContext::unaryOpError):
(TParseContext::binaryOpError):
(TParseContext::precisionErrorCheck):
(TParseContext::lValueErrorCheck):
(TParseContext::constErrorCheck):
(TParseContext::integerErrorCheck):
(TParseContext::globalErrorCheck):
(TParseContext::reservedErrorCheck):
(TParseContext::constructorErrorCheck):
(TParseContext::voidErrorCheck):
(TParseContext::boolErrorCheck):
(TParseContext::samplerErrorCheck):
(TParseContext::structQualifierErrorCheck):
(TParseContext::parameterSamplerErrorCheck):
(TParseContext::containsSampler):
(TParseContext::arraySizeErrorCheck):
(TParseContext::arrayQualifierErrorCheck):
(TParseContext::arrayTypeErrorCheck):
(TParseContext::arrayErrorCheck):
(TParseContext::nonInitConstErrorCheck):
(TParseContext::nonInitErrorCheck):
(TParseContext::paramErrorCheck):
(TParseContext::extensionErrorCheck):
(TParseContext::supportsExtension):
(TParseContext::isExtensionEnabled):
(TParseContext::findFunction):
(TParseContext::executeInitializer):
(TParseContext::areAllChildConst):
(TParseContext::addConstructor):
(TParseContext::foldConstConstructor):
(TParseContext::constructBuiltIn):
(TParseContext::constructStruct):
(TParseContext::addConstVectorNode):
(TParseContext::addConstMatrixNode):
(TParseContext::addConstArrayNode):
(TParseContext::addConstStruct):
(TParseContext::enterStructDeclaration):
(TParseContext::exitStructDeclaration):
(TParseContext::structNestingErrorCheck):
(TParseContext::addIndexExpression):
(PaParseStrings):

src/compiler/ParseContext.h: Added.

(TParseContext::TParseContext):
(TParseContext::numErrors):
(TParseContext::infoSink):
(TParseContext::pragma):
(TParseContext::extensionBehavior):

src/compiler/ParseHelper.cpp: Removed.
src/compiler/ParseHelper.h: Removed.
src/compiler/PoolAlloc.cpp:

(InitializePoolIndex):
(FreePoolIndex):
(GetGlobalPoolAllocator):
(SetGlobalPoolAllocator):

src/compiler/PoolAlloc.h:

(pool_allocator::pool_allocator):

src/compiler/SearchSymbol.h:
src/compiler/ShHandle.h:

(TCompiler::getVaryings):

src/compiler/ShaderLang.cpp:

(checkVariableMaxLengths):
(ShInitialize):
(ShFinalize):
(ShConstructCompiler):
(ShCompile):
(ShGetInfo):
(ShGetVariableInfo):
(ShCheckVariablesWithinPackingLimits):

src/compiler/SymbolTable.cpp:

(TSymbolTable::~TSymbolTable):

src/compiler/SymbolTable.h:

(TSymbol::TSymbol):
(TSymbolTableLevel::insert):
(TSymbolTable::push):
(TSymbolTable::pop):
(TSymbolTable::findBuiltIn):
(TSymbolTable::relateToExtension):
(TSymbolTable::setDefaultPrecision):
(TSymbolTable::getDefaultPrecision):
(TSymbolTable::supportsPrecision):

src/compiler/Types.h:

(NewPoolTFieldList):
(TType::TType):
(TType::setNominalSize):
(TPublicType::setAggregate):

src/compiler/UnfoldShortCircuit.cpp:

(sh::UnfoldShortCircuit::visitBinary):
(sh::UnfoldShortCircuit::visitSelection):

src/compiler/UnfoldShortCircuit.h:
src/compiler/UnfoldShortCircuitAST.cpp: Added.

(UnfoldShortCircuitAST::visitBinary):
(UnfoldShortCircuitAST::updateTree):

src/compiler/UnfoldShortCircuitAST.h: Added.

(UnfoldShortCircuitAST::UnfoldShortCircuitAST):
(UnfoldShortCircuitAST::NodeUpdateEntry::NodeUpdateEntry):

src/compiler/Uniform.cpp:

(sh::Uniform::Uniform):

src/compiler/Uniform.h:
src/compiler/ValidateLimitations.cpp:

(ValidateLimitations::validateFunctionCall):
(ValidateLimitations::validateOperation):

src/compiler/VariableInfo.cpp:

(TVariableInfo::TVariableInfo):
(CollectVariables::CollectVariables):
(CollectVariables::visitSymbol):
(CollectVariables::visitAggregate):

src/compiler/VariableInfo.h:
src/compiler/debug.cpp:
src/compiler/depgraph/DependencyGraph.cpp:
src/compiler/depgraph/DependencyGraphBuilder.cpp:

(TDependencyGraphBuilder::visitBinary):

src/compiler/generate_parser.sh:
src/compiler/glslang.l:
src/compiler/glslang.y:
src/compiler/glslang_lex.cpp:

(input):
(yyerror):
(int_constant):
(float_constant):
(glslang_scan):

src/compiler/glslang_tab.cpp:

(yysyntax_error):
(glslang_parse):

src/compiler/glslang_tab.h:
src/compiler/intermediate.h:

(TIntermSymbol::hasSideEffects):
(TIntermSymbol::replaceChildNode):
(TIntermConstantUnion::hasSideEffects):
(TIntermConstantUnion::getIConst):
(TIntermConstantUnion::getFConst):
(TIntermConstantUnion::getBConst):
(TIntermConstantUnion::replaceChildNode):
(TIntermOperator::hasSideEffects):
(TIntermBinary::hasSideEffects):
(TIntermUnary::hasSideEffects):
(TIntermAggregate::hasSideEffects):
(TIntermSelection::hasSideEffects):
(TIntermTraverser::~TIntermTraverser):
(TIntermTraverser::incrementDepth):
(TIntermTraverser::decrementDepth):
(TIntermTraverser::getParentNode):

src/compiler/localintermediate.h:
src/compiler/parseConst.cpp:
src/compiler/preprocessor/ExpressionParser.cpp:

(yy_symbol_print):
(yy_stack_print):
(yy_reduce_print):
(yystrlen):
(yystpcpy):
(yytnamerr):
(yysyntax_error):
(yydestruct):
(yyparse):

src/compiler/preprocessor/ExpressionParser.y:
src/compiler/preprocessor/Preprocessor.cpp:

(pp::Preprocessor::setMaxTokenLength):
(pp::Preprocessor::lex):

src/compiler/preprocessor/Preprocessor.h:
src/compiler/preprocessor/Tokenizer.cpp:

(pp::Tokenizer::Tokenizer):
(pp::Tokenizer::lex):

src/compiler/preprocessor/Tokenizer.h:

(pp::Tokenizer::setMaxTokenLength):

src/compiler/preprocessor/Tokenizer.l:
src/compiler/preprocessor/generate_parser.sh:
src/compiler/preprocessor/preprocessor.vcxproj: Added.
src/compiler/preprocessor/preprocessor.vcxproj.filters: Added.
src/compiler/timing/RestrictFragmentShaderTiming.cpp:
src/compiler/translator.vcxproj: Added.
src/compiler/translator.vcxproj.filters: Added.
src/compiler/util.cpp:

(atof_clamp):
(atoi_clamp):

src/compiler/util.h:
src/libEGL/Surface.cpp:

(egl::Surface::checkForOutOfDateSwapChain):

src/libEGL/libEGL.cpp:
src/libEGL/libEGL.rc:
src/libEGL/libEGL.vcxproj: Added.
src/libEGL/libEGL.vcxproj.filters: Added.
src/libGLESv2/Buffer.cpp:

(gl::Buffer::bufferData):
(gl::Buffer::bufferSubData):
(gl::Buffer::size):
(gl::Buffer::getIndexRangeCache):

src/libGLESv2/Buffer.h:
src/libGLESv2/Context.cpp:

(gl::Context::applyTextures):
(gl::Context::getBoundFramebufferTextureSerials):

src/libGLESv2/Context.h:

(gl::Context::getRenderer):

src/libGLESv2/Framebuffer.h:
src/libGLESv2/ProgramBinary.cpp:

(gl::DiscardWorkaround):
(gl::ProgramBinary::load):
(gl::ProgramBinary::link):
(gl::ProgramBinary::linkAttributes):
(gl::AttributeSorter::AttributeSorter):
(gl::ProgramBinary::initAttributesByLayout):
(gl::ProgramBinary::sortAttributesByLayout):

src/libGLESv2/ProgramBinary.h:
src/libGLESv2/Renderbuffer.cpp:

(gl::RenderbufferTexture2D::getTextureSerial):
(gl::RenderbufferTextureCubeMap::getTextureSerial):
(gl::Renderbuffer::getTextureSerial):

src/libGLESv2/Renderbuffer.h:

(gl::RenderbufferStorage::getTextureSerial):

src/libGLESv2/Shader.cpp:

(gl::Shader::parseVaryings):
(gl::Shader::uncompile):

src/libGLESv2/Shader.h:
src/libGLESv2/Texture.cpp:

(gl::TextureCubeMap::storage):

src/libGLESv2/Uniform.cpp:

(gl::Uniform::Uniform):
(gl::Uniform::~Uniform):
(gl::Uniform::isArray):
(gl::Uniform::elementCount):

src/libGLESv2/Uniform.h:
src/libGLESv2/constants.h: Removed.
src/libGLESv2/libGLESv2.def:
src/libGLESv2/libGLESv2.rc:
src/libGLESv2/libGLESv2.vcxproj: Added.
src/libGLESv2/libGLESv2.vcxproj.filters: Added.
src/libGLESv2/precompiled.h:
src/libGLESv2/renderer/Image11.cpp:

(rx::Image11::generateMipmap):
(rx::Image11::loadData):
(rx::Image11::loadCompressedData):
(rx::Image11::copy):
(rx::Image11::createStagingTexture):
(rx::Image11::map):

src/libGLESv2/renderer/Image11.h:
src/libGLESv2/renderer/IndexBuffer.cpp:

(rx::IndexBufferInterface::mapBuffer):
(rx::StaticIndexBufferInterface::getIndexRangeCache):

src/libGLESv2/renderer/IndexBuffer.h:
src/libGLESv2/renderer/IndexBuffer11.cpp:

(rx::IndexBuffer11::mapBuffer):

src/libGLESv2/renderer/IndexDataManager.cpp:

(rx::IndexDataManager::prepareIndexData):
(rx::IndexDataManager::getCountingIndices):

src/libGLESv2/renderer/IndexRangeCache.cpp: Added.

(rx::IndexRangeCache::addRange):
(rx::IndexRangeCache::invalidateRange):
(rx::IndexRangeCache::findRange):
(rx::IndexRangeCache::clear):
(rx::IndexRangeCache::IndexRange::IndexRange):
(rx::IndexRangeCache::IndexRange::operator<):
(rx::IndexRangeCache::IndexBounds::IndexBounds):

src/libGLESv2/renderer/IndexRangeCache.h: Added.
src/libGLESv2/renderer/InputLayoutCache.cpp:

(rx::InputLayoutCache::InputLayoutCache):
(rx::InputLayoutCache::clear):
(rx::InputLayoutCache::markDirty):
(rx::InputLayoutCache::applyVertexBuffers):
(rx::InputLayoutCache::hashInputLayout):
(rx::InputLayoutCache::compareInputLayouts):

src/libGLESv2/renderer/InputLayoutCache.h:

(rx::InputLayoutCache::InputLayoutKey::begin):
(rx::InputLayoutCache::InputLayoutKey::end):

src/libGLESv2/renderer/RenderTarget11.cpp:

(rx::RenderTarget11::getTexture):
(rx::RenderTarget11::getRenderTargetView):
(rx::RenderTarget11::getDepthStencilView):
(rx::RenderTarget11::getShaderResourceView):

src/libGLESv2/renderer/RenderTarget11.h:
src/libGLESv2/renderer/Renderer.cpp:

(rx::Renderer::initializeCompiler):

src/libGLESv2/renderer/Renderer.h:
src/libGLESv2/renderer/Renderer11.cpp:

(rx::Renderer11::initialize):
(rx::Renderer11::applyPrimitiveType):
(rx::Renderer11::applyRenderTarget):
(rx::Renderer11::drawLineLoop):
(rx::Renderer11::drawTriangleFan):
(rx::Renderer11::applyUniforms):
(rx::Renderer11::clear):
(rx::Renderer11::markAllStateDirty):
(rx::Renderer11::copyImage):
(rx::Renderer11::compileToExecutable):
(rx::Renderer11::getRenderTargetResource):
(rx::Renderer11::blitRenderbufferRect):

src/libGLESv2/renderer/Renderer11.h:
src/libGLESv2/renderer/Renderer9.cpp:

(rx::Renderer9::initialize):
(rx::Renderer9::setViewport):
(rx::Renderer9::drawLineLoop):
(rx::Renderer9::compileToExecutable):

src/libGLESv2/renderer/Renderer9.h:
src/libGLESv2/renderer/SwapChain.h:
src/libGLESv2/renderer/SwapChain11.cpp:

(rx::SwapChain11::resetOffscreenTexture):
(rx::SwapChain11::reset):
(rx::SwapChain11::swapRect):

src/libGLESv2/renderer/SwapChain9.cpp:

(rx::convertInterval):

src/libGLESv2/renderer/TextureStorage11.cpp:

(rx::TextureStorage11::IsTextureFormatRenderable):
(rx::TextureStorage11::generateMipmapLayer):
(rx::TextureStorage11_Cube::getRenderTarget):

src/libGLESv2/renderer/VertexBuffer.cpp:

(rx::VertexBufferInterface::storeVertexAttributes):
(rx::VertexBufferInterface::storeRawData):
(rx::VertexBufferInterface::reserveVertexSpace):
(rx::StaticVertexBufferInterface::lookupAttribute):
(rx::StaticVertexBufferInterface::storeVertexAttributes):

src/libGLESv2/renderer/VertexBuffer.h:
src/libGLESv2/renderer/VertexBuffer11.cpp:

(rx::VertexBuffer11::getSpaceRequired):

src/libGLESv2/renderer/VertexBuffer11.h:
src/libGLESv2/renderer/VertexBuffer9.cpp:

(rx::VertexBuffer9::storeVertexAttributes):
(rx::VertexBuffer9::getSpaceRequired):
(rx::VertexBuffer9::requiresConversion):
(rx::VertexBuffer9::getVertexSize):
(rx::VertexBuffer9::spaceRequired):

src/libGLESv2/renderer/VertexBuffer9.h:
src/libGLESv2/renderer/VertexDataManager.cpp:

(rx::elementsInBuffer):
(rx::StreamingBufferElementCount):
(rx::VertexDataManager::prepareVertexData):

src/libGLESv2/renderer/VertexDataManager.h:
src/libGLESv2/renderer/renderer11_utils.cpp:

(gl_d3d11::ConvertTextureFormat):

src/libGLESv2/renderer/shaders/compiled/clear11vs.h:
src/libGLESv2/renderer/shaders/compiled/clearmultiple11ps.h:
src/libGLESv2/renderer/shaders/compiled/clearsingle11ps.h:
src/libGLESv2/renderer/shaders/compiled/componentmaskps.h:
src/libGLESv2/renderer/shaders/compiled/flipyvs.h:
src/libGLESv2/renderer/shaders/compiled/luminanceps.h:
src/libGLESv2/renderer/shaders/compiled/passthrough11vs.h:
src/libGLESv2/renderer/shaders/compiled/passthroughlum11ps.h:
src/libGLESv2/renderer/shaders/compiled/passthroughlumalpha11ps.h:
src/libGLESv2/renderer/shaders/compiled/passthroughps.h:
src/libGLESv2/renderer/shaders/compiled/passthroughrgb11ps.h:
src/libGLESv2/renderer/shaders/compiled/passthroughrgba11ps.h:
src/libGLESv2/renderer/shaders/compiled/standardvs.h:
src/libGLESv2/renderer/shaders/generate_shaders.bat:
src/libGLESv2/utilities.cpp:

(gl::ComputeTypeSize):

src/libGLESv2/utilities.h:
src/third_party/murmurhash/MurmurHash3.cpp:

(rotl32):
(rotl64):
(getblock):
(fmix):
(MurmurHash3_x86_32):
(MurmurHash3_x86_128):
(MurmurHash3_x64_128):

src/third_party/murmurhash/MurmurHash3.h:
src/third_party/trace_event: Added.
src/third_party/trace_event/trace_event.h: Added.

(gl::TraceEvent::TraceID::TraceID):
(gl::TraceEvent::TraceID::data):
(gl::TraceEvent::TraceStringWithCopy::TraceStringWithCopy):
(gl::TraceEvent::TraceStringWithCopy::operator const char* ):
(gl::TraceEvent::setTraceValue):
(gl::TraceEvent::addTraceEvent):
(gl::TraceEvent::TraceEndOnScopeClose::TraceEndOnScopeClose):
(gl::TraceEvent::TraceEndOnScopeClose::~TraceEndOnScopeClose):
(gl::TraceEvent::TraceEndOnScopeClose::initialize):
(gl::TraceEvent::TraceEndOnScopeClose::addEventIfEnabled):
(gl::TraceEvent::SamplingStateScope::SamplingStateScope):
(gl::TraceEvent::SamplingStateScope::~SamplingStateScope):
(gl::TraceEvent::SamplingStateScope::current):
(gl::TraceEvent::SamplingStateScope::set):

4:35 PM Changeset in webkit [159532] by msaboff@apple.com

3 edits in trunk/Source/JavaScriptCore

REGRESSION(158384) ARMv7 point checks too restrictive for native calls to traditional ARM code
https://bugs.webkit.org/show_bug.cgi?id=124612

Reviewed by Geoffrey Garen.

Removed ASSERT checks (i.e. lower bit set) for ARM Thumb2 destination addresses related to
calls since we are calling native ARM traditional functions like sin() and cos().

assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::linkCall):
(JSC::ARMv7Assembler::relinkCall):

assembler/MacroAssemblerCodeRef.h:

4:29 PM Changeset in webkit [159531] by commit-queue@webkit.org

7 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r159459.
http://trac.webkit.org/changeset/159459
https://bugs.webkit.org/show_bug.cgi?id=124616

tons of assertions on launch (Requested by thorton on
#webkit).

API/JSContext.mm:

(-[JSContext setException:]):
(-[JSContext wrapperForObjCObject:]):
(-[JSContext wrapperForJSObject:]):

API/JSContextRef.cpp:

(JSContextGroupRelease):
(JSGlobalContextRelease):

API/JSManagedValue.mm:

(-[JSManagedValue initWithValue:]):
(-[JSManagedValue value]):

API/JSObjectRef.cpp:

(JSObjectIsFunction):
(JSObjectCopyPropertyNames):

API/JSValue.mm:

(containerValueToObject):

API/JSWrapperMap.mm:

(tryUnwrapObjcObject):

3:58 PM Changeset in webkit [159530] by Lucas Forschler

5 edits in branches/safari-537.73-branch/Source

Versioning.

3:54 PM Changeset in webkit [159529] by matthew_hanson@apple.com

2 edits in tags/Safari-538.7/Source/JavaScriptCore

Merge of 159515.

3:48 PM Changeset in webkit [159528] by fpizlo@apple.com

11 edits in trunk/Source

Rename WatchpointSet::notifyWrite() should be renamed to WatchpointSet::fireAll()
https://bugs.webkit.org/show_bug.cgi?id=124609

Source/JavaScriptCore:

Rubber stamped by Mark Lam.

notifyWrite() is a thing that SymbolTable does. WatchpointSet uses that terminology
because it was original designed to match exactly SymbolTable's semantics. But now
it's a confusing term.

bytecode/Watchpoint.cpp:

(JSC::WatchpointSet::fireAllSlow):

bytecode/Watchpoint.h:

(JSC::WatchpointSet::fireAll):
(JSC::InlineWatchpointSet::fireAll):

interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

runtime/JSFunction.cpp:

(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::haveABadTime):

runtime/Structure.h:

(JSC::Structure::notifyTransitionFromThisStructure):

runtime/SymbolTable.cpp:

(JSC::SymbolTableEntry::notifyWriteSlow):

Source/WebCore:

Rubber stamped by Mark Lam.

No new tests because no new behavior.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::create):

3:47 PM Changeset in webkit [159527] by matthew_hanson@apple.com

5 edits in tags/Safari-538.7/Source/JavaScriptCore

Merge of 159508.

3:38 PM Changeset in webkit [159526] by betravis@adobe.com

15 edits in trunk

[CSS Shapes] Parse [<box>

<shape>] values

https://bugs.webkit.org/show_bug.cgi?id=124426

Reviewed by Dirk Schulze.

Source/WebCore:

Shape values can now have an optional box specifying the coordinate sytem to use
for sizing and positioning the shape. This patch adds the functionality to support
parsing these new values.

css/BasicShapeFunctions.cpp:

(WebCore::valueForBox): Added function to convert between BasicShape::ReferenceBox
and CSSPrimitiveValue (which wraps a CSSValueID).
(WebCore::boxForValue): Ditto.
(WebCore::valueForBasicShape): Translations between CSSBasicShape and BasicShape
must now include the reference box.
(WebCore::basicShapeForValue): Ditto.

css/BasicShapeFunctions.h:
css/CSSBasicShapes.cpp:

(WebCore::buildRectangleString): Include the box in the built CSS string.
(WebCore::CSSBasicShapeRectangle::cssText): Ditto.
(WebCore::CSSBasicShapeRectangle::equals): Include the box in comparisions.
(WebCore::buildCircleString):
(WebCore::CSSBasicShapeCircle::cssText):
(WebCore::CSSBasicShapeCircle::equals):
(WebCore::buildEllipseString):
(WebCore::CSSBasicShapeEllipse::cssText):
(WebCore::CSSBasicShapeEllipse::equals):
(WebCore::buildPolygonString):
(WebCore::CSSBasicShapePolygon::cssText):
(WebCore::CSSBasicShapePolygon::equals):
(WebCore::buildInsetRectangleString):
(WebCore::CSSBasicShapeInsetRectangle::cssText):
(WebCore::CSSBasicShapeInsetRectangle::equals):

css/CSSBasicShapes.h:

(WebCore::CSSBasicShape::box): BasicShapes now have an reference box.
(WebCore::CSSBasicShape::setBox): Ditto.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): Shape-inside can also
parse the box values.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): The shape properties use parseShapeProperty,
while minor adjustments were made to parseBasicShape's return type.
(WebCore::isBoxValue): Is the CSSValueID one of the box values.
(WebCore::CSSParser::parseShapeProperty): Parse one of the shape properties
and return an appropriate CSSValue.
(WebCore::CSSParser::parseBasicShape): Return a CSSBasicShape rather than
adding a ShapeValue to the style.

css/CSSParser.h:
rendering/style/BasicShapes.h:

(WebCore::BasicShape::box): Add a box to BasicShape and getters/setters.
(WebCore::BasicShape::setBox): Ditto.
(WebCore::BasicShape::BasicShape): Ditto.

LayoutTests:

Test that <box> <shape> and <shape> <box> values are both supported and successfully parsed.
Currently, we order the parsed result as <shape> <box> when the value is output through
the CSSOM. Also test that other combinations with shapes and boxes are not parsed.

fast/shapes/parsing/parsing-shape-inside-expected.txt:
fast/shapes/parsing/parsing-shape-inside.html:
fast/shapes/parsing/parsing-shape-outside-expected.txt:
fast/shapes/parsing/parsing-shape-outside.html:
fast/shapes/parsing/parsing-test-utils.js:

3:06 PM Changeset in webkit [159525] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

[Mac] 9 WebGL conformance failures after r159518.
https://bugs.webkit.org/show_bug.cgi?id=124608

Reviewed by Dean Jackson.

Once we removed the CIImage drawing path, there was no longer any reason to flip the
CGImageRef before drawing to the provided GraphicsContext.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):

2:57 PM Changeset in webkit [159524] by matthew_hanson@apple.com

14 edits
1 copy in tags/Safari-538.7/Source/JavaScriptCore

Rollout r159483. This change effectively adds r159351 back into the tag.

2:50 PM Changeset in webkit [159523] by Chris Fleizach

2 edits in trunk/Source/WebCore

Web Speech API crashes onboundary event handling with reload
https://bugs.webkit.org/show_bug.cgi?id=124607

Reviewed by Tim Horton.

If the page goes away, we need to cleanup the Mac platform synthesizer object, because
NSSpeechSynthesizer is retained elsewhere to handle the callbacks (so it doesn't automatically
get torn down).

The layout tests for speech rely on a Mock synthesizer, so there is no good way to test this
Mac platform specific behavior.

platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper invalidate]):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):

2:27 PM Changeset in webkit [159522] by mitz@apple.com

2 edits in trunk/Tools

<rdar://problem/15139479> Reenable the JSC Objective-C API tests on Mountain Lion once the bots are running Xcode 5

Rubber-stamped by Mark Rowe.

Reverted r156840.

TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:

1:59 PM Changeset in webkit [159521] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

REGRESSION (r159395): Error compiling for ARMv7
https://bugs.webkit.org/show_bug.cgi?id=124552

Reviewed by Geoffrey Garen.

Fixed the implementation of branch8(RelationalCondition cond, AbsoluteAddress address, TrustedImm32 right)
to materialize and use address similar to other ARMv7 branchXX() functions.

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branch8):

1:55 PM Changeset in webkit [159520] by mark.lam@apple.com

34 edits
5 adds in trunk

Add tracking of endColumn for Executables.
https://bugs.webkit.org/show_bug.cgi?id=124245.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Fixed computation of columns to take into account the startColumn from <script> tags. Previously, we were only computing the column relative to the char after the <script> tag. Now, the column number that JSC computes is always the column number you'll see when viewing the source in a text editor (assuming the first column position is 1, not 0).

Previously, unlinkedExecutables kept the a base-1 startColumn for ProgramExecutables and EvalExecutables, but uses base-0 columns for FunctionExecutables. This has been fixed so that they all use base-0 columns. When the executable gets linked, the column is adjusted into a base-1 value.

In the UnlinkedFunctionExecutable, renamed m_functionStartOffset to m_unlinkedFunctionNameStart because it actually points to the start column in the name part of the function declaration.

Similarly, renamed m_functionStartColumn to m_unlinkedBodyStartColumn
because it points to the first character in the function body. This is
usually '{' except for functions created from "global code" which
excludes its braces. See FunctionExecutable::fromGlobalCode().

The exclusion of braces for the global code case is needed so that

computed start and end columns will more readily map to what a JS
developer would expect them to be. Otherwise, the first column of the
function source will not be 1 (includes prepended characters added in
constructFunctionSkippingEvalEnabledCheck()).

Also, similarly, a m_unlinkedBodyEndColumn has been added to track the
end column of the UnlinkedFunctionExecutable.

For unlinked executables, end column values are either:
1. Relative to the start of the last line if (last line != first line).
2. Relative to the start column position if (last line == first line).

The second case is needed so that we can add an appropriate adjustment
to the end column value (just like we do for the start column) when we
link the executable.

This is not new to this patch, but it worth noting that the lineCount values used through this patch has the following meaning:
- a lineCount of 0 means the source for this code block is on 1 line.
- a lineCount of N means there are N + l lines of source.

This interpretation is janky, but was present before this patch. We can
clean that up later in another patch.

JavaScriptCore.xcodeproj/project.pbxproj:
In order to implement WebCore::Internals::parserMetaData(), we need to move some seemingly unrelated header files from the Project section to the Private section so that they can be #include'd by the forwarding CodeBlock.h from WebCore.
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::sourceCodeForTools):
(JSC::CodeBlock::CodeBlock):

bytecode/UnlinkedCodeBlock.cpp:

(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

m_isFromGlobalCode is needed to support the exclusion of the open brace / prepended code for functions created from "global code".

(JSC::UnlinkedFunctionExecutable::link):
(JSC::UnlinkedFunctionExecutable::fromGlobalCode):
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::create):
(JSC::UnlinkedFunctionExecutable::unlinkedFunctionNameStart):
(JSC::UnlinkedFunctionExecutable::unlinkedBodyStartColumn):
(JSC::UnlinkedFunctionExecutable::unlinkedBodyEndColumn):
(JSC::UnlinkedFunctionExecutable::recordParse):
(JSC::UnlinkedCodeBlock::recordParse):
(JSC::UnlinkedCodeBlock::endColumn):

bytecompiler/NodesCodegen.cpp:

(JSC::FunctionBodyNode::emitBytecode):

parser/ASTBuilder.h:

(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::setFunctionNameStart):

parser/Lexer.cpp:

(JSC::::shiftLineTerminator):

Removed an unused SourceCode Lexer<T>::sourceCode() function.
parser/Lexer.h:

(JSC::Lexer::positionBeforeLastNewline):
(JSC::Lexer::prevTerminator):

Added tracking of m_positionBeforeLastNewline in the Lexer to enable us to exclude the close brace / appended code for functions created from "global code".
parser/Nodes.cpp:

(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):
(JSC::FunctionBodyNode::setEndPosition):

setEndPosition() is needed to fixed up the end position so that we can exclude the close brace / appended code for functions created from "global code".
parser/Nodes.h:

(JSC::ProgramNode::startColumn):
(JSC::ProgramNode::endColumn):
(JSC::EvalNode::startColumn):
(JSC::EvalNode::endColumn):
(JSC::FunctionBodyNode::setFunctionNameStart):
(JSC::FunctionBodyNode::functionNameStart):
(JSC::FunctionBodyNode::endColumn):

parser/Parser.cpp:

(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):

parser/Parser.h:

(JSC::Parser::positionBeforeLastNewline):
(JSC::::parse):

Subtracted 1 from startColumn here to keep the node column values consistently base-0. See note 2 above.

(JSC::parse):

parser/SourceProviderCacheItem.h:

(JSC::SourceProviderCacheItem::SourceProviderCacheItem):

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::setFunctionNameStart):

runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

runtime/CodeCache.h:
runtime/Executable.cpp:

(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::ProgramExecutable::initializeGlobalProperties):
(JSC::FunctionExecutable::fromGlobalCode):

runtime/Executable.h:

(JSC::ExecutableBase::isEvalExecutable):
(JSC::ExecutableBase::isProgramExecutable):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::endColumn):
(JSC::ScriptExecutable::recordParse):
(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::bodyIncludesBraces):

runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

runtime/FunctionPrototype.cpp:

(JSC::insertSemicolonIfNeeded):
(JSC::functionProtoFuncToString):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):

Source/WebCore:

Test: js/dom/script-start-end-locations.html

ForwardingHeaders/bytecode: Added.
ForwardingHeaders/bytecode/CodeBlock.h: Added.
WebCore.exp.in:
testing/Internals.cpp:

(WebCore::GetCallerCodeBlockFunctor::GetCallerCodeBlockFunctor):
(WebCore::GetCallerCodeBlockFunctor::operator()):
(WebCore::GetCallerCodeBlockFunctor::codeBlock):
(WebCore::Internals::parserMetaData):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Added an exported symbol to make the Win32 build happy. The Win64 symbol is currently a copy of the Win32 one. It'll need to be updated if the mangled symbol is different for Win64.

LayoutTests:

fast/events/window-onerror2-expected.txt:
inspector-protocol/debugger/setBreakpoint-actions-expected.txt:
js/dom/script-start-end-locations-expected.txt: Added.
js/dom/script-start-end-locations.html: Added.
js/dom/script-tests/script-start-end-locations.js: Added.
js/dom/stack-trace-expected.txt:
js/dom/stack-trace.html:
Changed tabs to spaces. The tabs were making it hard to visually confirm the exected column values for 2 functions.

1:39 PM Changeset in webkit [159519] by jer.noble@apple.com

20 edits
4 adds in trunk

[MSE] Support fastSeek() in MediaSource.
https://bugs.webkit.org/show_bug.cgi?id=124422

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-fastseek.html

Modules/mediasource/MediaSource.cpp:
Modules/mediasource/MediaSource.h:

Add support for "seek to the next fastest time" in MediaSource by
returning the time of the nearest Sync sample.

Move the data structure logic out of SourceBuffer and into it's own
class:

Modules/mediasource/SampleMap.cpp: Added.

(WebCore::SampleIsLessThanMediaTimeComparator::operator()):
(WebCore::SampleIsGreaterThanMediaTimeComparator::operator()):
(WebCore::SampleIsRandomAccess::operator()):
(WebCore::SamplePresentationTimeIsWithinRangeComparator::operator()):
(WebCore::SampleMap::addSample):
(WebCore::SampleMap::removeSample):
(WebCore::SampleMap::findSampleContainingPresentationTime):
(WebCore::SampleMap::findSampleAfterPresentationTime):
(WebCore::SampleMap::findSampleWithDecodeTime):
(WebCore::SampleMap::reverseFindSampleContainingPresentationTime):
(WebCore::SampleMap::reverseFindSampleBeforePresentationTime):
(WebCore::SampleMap::reverseFindSampleWithDecodeTime):
(WebCore::SampleMap::findSyncSamplePriorToPresentationTime):
(WebCore::SampleMap::findSyncSamplePriorToDecodeIterator):
(WebCore::SampleMap::findSyncSampleAfterPresentationTime):
(WebCore::SampleMap::findSyncSampleAfterDecodeIterator):
(WebCore::SampleMap::findSamplesBetweenPresentationTimes):
(WebCore::SampleMap::findDependentSamples):

Modules/mediasource/SampleMap.h: Added.

(WebCore::SampleMap::presentationBegin):
(WebCore::SampleMap::presentationEnd):
(WebCore::SampleMap::decodeBegin):
(WebCore::SampleMap::decodeEnd):
(WebCore::SampleMap::reversePresentationBegin):
(WebCore::SampleMap::reversePresentationEnd):
(WebCore::SampleMap::reverseDecodeBegin):
(WebCore::SampleMap::reverseDecodeEnd):

Add logic to find and return the time of the next & previous sync
sample, within the threshold provided:

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::TrackBuffer::TrackBuffer):
(WebCore::SourceBuffer::sourceBufferPrivateSeekToTime):
(WebCore::SourceBuffer::sourceBufferPrivateFastSeekTimeForMediaTime):
(WebCore::SourceBuffer::appendBufferTimerFired):
(WebCore::SourceBuffer::setActive):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
(WebCore::SourceBuffer::sourceBufferPrivateDidBecomeReadyForMoreSamples):
(WebCore::SourceBuffer::provideMediaData):

Modules/mediasource/SourceBuffer.h:
platform/graphics/SourceBufferPrivate.h:

(WebCore::SourceBufferPrivate::setActive):

platform/graphics/SourceBufferPrivateClient.h:

(WebCore::SourceBufferPrivateClient::sourceBufferPrivateFastSeekTimeForMediaTime):
(WebCore::SourceBufferPrivateClient::sourceBufferPrivateSeekToTime):

Add new files to the project:

WebCore.xcodeproj/project.pbxproj:

Drive-by fixes in HTMLMediaElement:

html/HTMLMediaSource.h:
html/HTMLMediaElement.cpp:

(HTMLMediaElement::finishSeek): Cause the MediaSource to check the ready state of all its buffers.
(HTMLMediaElement::selectNextSourceChild): Pass in whether the source element has a MediaSource URL.

Implement the seekWithTolerance behavior in MockMediaPlayerMediaSource:

platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::maxTimeSeekableDouble):
(WebCore::MockMediaPlayerMediaSource::currentTimeDouble):
(WebCore::MockMediaPlayerMediaSource::seekWithTolerance):
(WebCore::MockMediaPlayerMediaSource::advanceCurrentTime):

platform/mock/mediasource/MockMediaPlayerMediaSource.h:
platform/mock/mediasource/MockMediaSourcePrivate.cpp:

(WebCore::MockMediaSourcePrivate::seekToTime):

platform/mock/mediasource/MockMediaSourcePrivate.h:
platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockMediaSample::flags):
(WebCore::MockSourceBufferPrivate::setActive):
(WebCore::MockSourceBufferPrivate::fastSeekTimeForMediaTime):
(WebCore::MockSourceBufferPrivate::seekToTime):

platform/mock/mediasource/MockSourceBufferPrivate.h:

LayoutTests:

media/media-source/media-source-fastseek-expected.txt: Added.
media/media-source/media-source-fastseek.html: Added.
media/media-source/mock-media-source.js:

(var):

1:37 PM Changeset in webkit [159518] by jer.noble@apple.com

9 edits in trunk/Source/WebCore

[Mac] 10X slower than Chrome when drawing a video into a canvas
https://bugs.webkit.org/show_bug.cgi?id=124599

Reviewed by Dean Jackson.

Improve performance by creating a CGImageRef which directly references the CVPixelBuffer provided
by AVPlayerItemVideoOutput:

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::CVPixelBufferGetBytePointerCallback):
(WebCore::CVPixelBufferReleaseBytePointerCallback):
(WebCore::CVPixelBufferReleaseInfoCallback):
(WebCore::createImageFromPixelBuffer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateLastImage):

Additionally, when asked to paint with an AVPlayerItemVideoOutput, block until the output notifies
its delegate that a pixel buffer is available:

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::globalPullDelegateQueue):
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::nativeImageForCurrentTime):
(WebCore::MediaPlayerPrivateAVFoundationObjC::waitForVideoOutputMediaDataWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange):
(-[WebCoreAVFPullDelegate initWithCallback:]):
(-[WebCoreAVFPullDelegate outputMediaDataWillChange:]):
(-[WebCoreAVFPullDelegate outputSequenceWasFlushed:]):

To further optimize video -> canvas drawing, add a method which can return a PassNativeImage to be
drawn directly onto the canvas, rather than rendering into an intermediary context:

html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::nativeImageForCurrentTime):

html/HTMLVideoElement.h:
html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::nativeImageForCurrentTime):

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::nativeImageForCurrentTime):

1:23 PM Changeset in webkit [159517] by beidson@apple.com

10 edits
3 deletes in trunk/Source/WebCore

Consolidate IDBBackingStore*Interface and IDBBackingStore*LevelDB
https://bugs.webkit.org/show_bug.cgi?id=124597

Reviewed by Alexey Proskuryakov.

The Interface abstraction doesn’t make sense anymore, as LevelDB will be the only implementor.

Modules/indexeddb/IDBBackingStoreCursorInterface.h: Removed.
Modules/indexeddb/IDBBackingStoreInterface.h: Removed.
Modules/indexeddb/IDBBackingStoreTransactionInterface.h: Removed.

Modules/indexeddb/IDBServerConnection.h:

Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.h:

(WebCore::IDBBackingStoreCursorLevelDB::key):
(WebCore::IDBBackingStoreCursorLevelDB::primaryKey):
(WebCore::IDBBackingStoreCursorLevelDB::recordIdentifier):

Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::getOrEstablishIDBDatabaseMetadata):
(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseVersion):
(WebCore::IDBBackingStoreLevelDB::deleteDatabase):
(WebCore::IDBBackingStoreLevelDB::createObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteObjectStore):
(WebCore::IDBBackingStoreLevelDB::getRecord):
(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::clearObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::createIndex):
(WebCore::IDBBackingStoreLevelDB::deleteIndex):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::IDBBackingStoreLevelDB::findKeyInIndex):
(WebCore::IDBBackingStoreLevelDB::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStoreLevelDB::keyExistsInIndex):
(WebCore::IDBBackingStoreLevelDB::makeIndexWriters):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreCursor):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexCursor):

Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:

Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.h:

(WebCore::IDBBackingStoreTransactionLevelDB::levelDBTransactionFrom):

Modules/indexeddb/leveldb/IDBIndexWriterLevelDB.cpp:

(WebCore::IDBIndexWriterLevelDB::writeIndexKeys):
(WebCore::IDBIndexWriterLevelDB::verifyIndexKeys):
(WebCore::IDBIndexWriterLevelDB::addingKeyAllowed):

Modules/indexeddb/leveldb/IDBIndexWriterLevelDB.h:

Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:

(WebCore::IDBServerConnectionLevelDB::get):
(WebCore::IDBServerConnectionLevelDB::openCursor):
(WebCore::IDBServerConnectionLevelDB::count):
(WebCore::IDBServerConnectionLevelDB::deleteRange):

WebCore.xcodeproj/project.pbxproj:

1:14 PM Changeset in webkit [159516] by commit-queue@webkit.org

20 edits in trunk/Source/WebCore

Get rid of bare new in SVGAnimatedColorAnimator::constructFromString()
https://bugs.webkit.org/show_bug.cgi?id=124595

Patch by Sergio Correia <Sergio Correia> on 2013-11-19
Reviewed by Darin Adler.

Use std::unique_ptr instead, to manage the arguments passed to the create
methods of SVGAnimatedType.

No new tests, covered by existing tests.

svg/SVGAnimatedAngle.cpp:

(WebCore::SVGAnimatedAngleAnimator::constructFromString): Replace bare
pointer with std::unique_ptr.

svg/SVGAnimatedBoolean.cpp:

(WebCore::SVGAnimatedBooleanAnimator::constructFromString): Ditto.

svg/SVGAnimatedColor.cpp:

(WebCore::SVGAnimatedColorAnimator::constructFromString): Ditto.

svg/SVGAnimatedEnumeration.cpp:

(WebCore::SVGAnimatedEnumerationAnimator::constructFromString): Ditto.

svg/SVGAnimatedInteger.cpp:

(WebCore::SVGAnimatedIntegerAnimator::constructFromString): Ditto.

svg/SVGAnimatedIntegerOptionalInteger.cpp:

(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::constructFromString):
Ditto.

svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::constructFromString): Ditto.

svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::constructFromString): Ditto.

svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::constructFromString): Ditto.

svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::constructFromString): Ditto.

svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::constructFromString):
Ditto.

svg/SVGAnimatedPointList.cpp:

(WebCore::SVGAnimatedPointListAnimator::constructFromString): Ditto.

svg/SVGAnimatedPreserveAspectRatio.cpp:

(WebCore::SVGAnimatedPreserveAspectRatioAnimator::constructFromString):
Ditto.

svg/SVGAnimatedRect.cpp:

(WebCore::SVGAnimatedRectAnimator::constructFromString): Ditto.

svg/SVGAnimatedString.cpp:

(WebCore::SVGAnimatedStringAnimator::constructFromString): Ditto.

svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::constructFromString):
Ditto.

svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::createAngleAndEnumeration): Use
std::unique_ptr instead of bare pointer as parameter.
(WebCore::SVGAnimatedType::createBoolean): Ditto.
(WebCore::SVGAnimatedType::createColor): Ditto.
(WebCore::SVGAnimatedType::createEnumeration): Ditto.
(WebCore::SVGAnimatedType::createInteger): Ditto.
(WebCore::SVGAnimatedType::createIntegerOptionalInteger): Ditto.
(WebCore::SVGAnimatedType::createLength): Ditto.
(WebCore::SVGAnimatedType::createLengthList): Ditto.
(WebCore::SVGAnimatedType::createNumber): Ditto.
(WebCore::SVGAnimatedType::createNumberList): Ditto.
(WebCore::SVGAnimatedType::createNumberOptionalNumber): Ditto.
(WebCore::SVGAnimatedType::createPointList): Ditto.
(WebCore::SVGAnimatedType::createPreserveAspectRatio): Ditto.
(WebCore::SVGAnimatedType::createRect): Ditto.
(WebCore::SVGAnimatedType::createString): Ditto.
(WebCore::SVGAnimatedType::createTransformList): Ditto.

svg/SVGAnimatedType.h: Use std::unique_ptr as parameter in the

create methods.

svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValue): Make
helper return std::unique_ptr instead of bare pointer.
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValues): Ditto.

12:59 PM Changeset in webkit [159515] by dino@apple.com

2 edits in trunk/Source/JavaScriptCore

MarkedSpace::resumeAllocating needs to delay release
https://bugs.webkit.org/show_bug.cgi?id=124596

Reviewed by Geoffrey Garen.

heap/MarkedSpace.cpp:

(JSC::MarkedSpace::resumeAllocating): Add DelayedReleaseScope protection.

12:34 PM Changeset in webkit [159514] by Antoine Quint

2 edits in trunk/Source/WebInspectorUI

Web Inspector: layer info sidebar should convert to MB for very large layers
https://bugs.webkit.org/show_bug.cgi?id=124570

Reviewed by Timothy Hatcher.

Setting higherResolution to true (its default value if omitted) when calling
Number.bytesToString() would always result in a KB-formatted string instead
since it didn't check for a < 1024 value as well.

UserInterface/Utilities.js:

(Number.bytesToString):

12:15 PM Changeset in webkit [159513] by hmuller@adobe.com

3 edits in trunk/Source/WebCore

[CSS Shapes] Refactor RectangleShape
https://bugs.webkit.org/show_bug.cgi?id=124416

Privatize and rename the FloatRoundedRect class defined in RectangleShape.h.
The new class is called RectangleShape::ShapeBounds. This change enables
creating a proper FloatRoundedRect analog of the existing RoundedRect class;
part of adding support for box shapes, per the latest CSS spec.

Reviewed by Dean Jackson.

No new tests, just refactoring.

rendering/shapes/RectangleShape.cpp:

(WebCore::RectangleShape::ShapeBounds::paddingBounds):
(WebCore::RectangleShape::ShapeBounds::marginBounds):
(WebCore::RectangleShape::ShapeBounds::cornerInterceptForWidth):
(WebCore::RectangleShape::shapePaddingBounds):
(WebCore::RectangleShape::shapeMarginBounds):
(WebCore::RectangleShape::getExcludedIntervals):
(WebCore::RectangleShape::getIncludedIntervals):
(WebCore::RectangleShape::firstIncludedIntervalLogicalTop):

rendering/shapes/RectangleShape.h:

(WebCore::RectangleShape::ShapeBounds::ShapeBounds):
(WebCore::RectangleShape::ShapeBounds::rx):
(WebCore::RectangleShape::ShapeBounds::ry):

12:14 PM Changeset in webkit [159512] by commit-queue@webkit.org

18 edits in trunk/Source/WebCore

Mark classes deriving from SVGAnimatedTypeAnimator as FINAL
https://bugs.webkit.org/show_bug.cgi?id=124456

Patch by Sergio Correia <Sergio Correia> on 2013-11-19
Reviewed by Darin Adler.

Also add OVERRIDE to their virtual methods appropriately and remove
existing empty virtual destructors.

No new tests, covered by existing ones.

svg/SVGAnimatedAngle.h:
svg/SVGAnimatedBoolean.h:
svg/SVGAnimatedColor.h:
svg/SVGAnimatedEnumeration.h:
svg/SVGAnimatedInteger.h:
svg/SVGAnimatedIntegerOptionalInteger.h:
svg/SVGAnimatedLength.h:
svg/SVGAnimatedLengthList.h:
svg/SVGAnimatedNumber.h:
svg/SVGAnimatedNumberList.h:
svg/SVGAnimatedNumberOptionalNumber.h:
svg/SVGAnimatedPath.h:
svg/SVGAnimatedPointList.h:
svg/SVGAnimatedPreserveAspectRatio.h:
svg/SVGAnimatedRect.h:
svg/SVGAnimatedString.h:
svg/SVGAnimatedTransformList.h:

12:08 PM Changeset in webkit [159511] by beidson@apple.com

13 edits
3 moves
2 adds
2 deletes in trunk/Source

Add WebIDBServerConnection and DatabaseProcessIDBConnection stubs
https://bugs.webkit.org/show_bug.cgi?id=124562

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Export some more symbols and headers for WK2 to use.

WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Also remove Web/DatabaseProcessDatabaseBackend stubs, as that is no longer the abstraction layer.

DatabaseProcess/DatabaseToWebProcessConnection.cpp:

(WebKit::DatabaseToWebProcessConnection::didReceiveMessage):
(WebKit::DatabaseToWebProcessConnection::establishIDBConnection):

DatabaseProcess/DatabaseToWebProcessConnection.h:
DatabaseProcess/DatabaseToWebProcessConnection.messages.in:

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp: Renamed from Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.cpp.

(WebKit::DatabaseProcessIDBConnection::DatabaseProcessIDBConnection):
(WebKit::DatabaseProcessIDBConnection::~DatabaseProcessIDBConnection):
(WebKit::DatabaseProcessIDBConnection::establishConnection):
(WebKit::DatabaseProcessIDBConnection::messageSenderConnection):

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h: Renamed from Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.h.

(WebKit::DatabaseProcessIDBConnection::create):

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in: Renamed from Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.messages.in.

Shared/Databases/IndexedDB/IDBUtilities.cpp:

(WebKit::uniqueDatabaseIdentifier): Modified to take two security origin arguments.

Shared/Databases/IndexedDB/IDBUtilities.h:

WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::open):

WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp: Added. Stubbed out all the pure virtual methods.

(WebKit::generateBackendIdentifier):
(WebKit::WebIDBServerConnection::WebIDBServerConnection):
(WebKit::WebIDBServerConnection::~WebIDBServerConnection):
(WebKit::WebIDBServerConnection::isClosed):
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::deleteDatabase):
(WebKit::WebIDBServerConnection::close):
(WebKit::WebIDBServerConnection::openTransaction):
(WebKit::WebIDBServerConnection::beginTransaction):
(WebKit::WebIDBServerConnection::commitTransaction):
(WebKit::WebIDBServerConnection::resetTransaction):
(WebKit::WebIDBServerConnection::rollbackTransaction):
(WebKit::WebIDBServerConnection::setIndexKeys):
(WebKit::WebIDBServerConnection::createObjectStore):
(WebKit::WebIDBServerConnection::createIndex):
(WebKit::WebIDBServerConnection::deleteIndex):
(WebKit::WebIDBServerConnection::get):
(WebKit::WebIDBServerConnection::put):
(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::count):
(WebKit::WebIDBServerConnection::deleteRange):
(WebKit::WebIDBServerConnection::clearObjectStore):
(WebKit::WebIDBServerConnection::deleteObjectStore):
(WebKit::WebIDBServerConnection::changeDatabaseVersion):
(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):
(WebKit::WebIDBServerConnection::cursorPrefetchIteration):
(WebKit::WebIDBServerConnection::cursorPrefetchReset):
(WebKit::WebIDBServerConnection::messageSenderConnection):

WebProcess/Databases/IndexedDB/WebIDBServerConnection.h: Added.

WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp: Removed.
WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h: Removed.

WebProcess/Databases/WebToDatabaseProcessConnection.cpp:

DerivedSources.make:
WebKit2.xcodeproj/project.pbxproj:

11:55 AM Changeset in webkit [159510] by dino@apple.com

2 edits in trunk/LayoutTests

fast/forms/form-associated-element-crash.html often times out on Mavericks WK1
https://bugs.webkit.org/show_bug.cgi?id=124593

Marked as occasionally timing out.

platform/mac/TestExpectations:

11:25 AM Changeset in webkit [159509] by Michał Pakuła vel Rutka

3 edits in trunk/Source/WebKit2

Unreviewed EFL and GTK build fix attempt after r159507

CMakeLists.txt: Changed Platform/CoreIPC/DataReference.cpp to Platform/IPC/DataReference.cpp
GNUmakefile.list.am: Ditto

11:10 AM Changeset in webkit [159508] by mhahnenberg@apple.com

5 edits in trunk/Source/JavaScriptCore

IncrementalSweeper needs to use DelayedReleaseScope too
https://bugs.webkit.org/show_bug.cgi?id=124558

Reviewed by Filip Pizlo.

It does sweeping too, so it needs to use it. Also refactored an
ASSERT that should have caught this sooner.

heap/DelayedReleaseScope.h:

(JSC::DelayedReleaseScope::isInEffectFor):

heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::doSweep):

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep):

heap/MarkedSpace.cpp:

(JSC::MarkedSpace::sweep):

10:32 AM Changeset in webkit [159507] by andersca@apple.com

2 edits
2 moves in trunk/Source/WebKit2

Move DataReference to Platform/IPC.

Platform/IPC/DataReference.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/DataReference.cpp.
Platform/IPC/DataReference.h: Renamed from Source/WebKit2/Platform/CoreIPC/DataReference.h.
WebKit2.xcodeproj/project.pbxproj:

10:20 AM Changeset in webkit [159506] by andersca@apple.com

4 edits in trunk/Source/WebKit2

Add and call PageLoadState::reset
https://bugs.webkit.org/show_bug.cgi?id=124591

Reviewed by Dan Bernstein.

UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::reset):

UIProcess/PageLoadState.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidCrash):

10:14 AM Changeset in webkit [159505] by Antoine Quint

2 edits in trunk/Source/WebInspectorUI

Remove some unused utilities from Utilities.js
https://bugs.webkit.org/show_bug.cgi?id=124590

Reviewed by Darin Adler.

Remove some methods and properties that were no longer used through the codebase.

UserInterface/Utilities.js:

9:36 AM Changeset in webkit [159504] by commit-queue@webkit.org

7 edits
4 adds in trunk

Map the dir attribute to the CSS direction property.
https://bugs.webkit.org/show_bug.cgi?id=124572.

Patch by Frédéric Wang <fred.wang@free.fr> on 2013-11-19
Reviewed by Darin Adler.

Source/WebCore:

Tests: mathml/presentation/direction-overall.html

mathml/presentation/direction-token.html
mathml/presentation/direction.html

mathml/MathMLElement.cpp:

(WebCore::MathMLElement::isPresentationAttribute): add dir
(WebCore::MathMLElement::collectStyleForPresentationAttribute): map dir

mathml/mathattrs.in: add the dir attribute
mathml/mathtags.in: add the mstyle tag (needed to use mstyleTag)

LayoutTests:

mathml/presentation/direction-expected.html: add more tests.
mathml/presentation/direction-overall-expected.html: Added.
mathml/presentation/direction-overall.html: Added.
mathml/presentation/direction-token-expected.html: Added.
mathml/presentation/direction-token.html: Added.
mathml/presentation/direction.html: add more tests.

9:22 AM Changeset in webkit [159503] by commit-queue@webkit.org

68 edits in trunk/Source/WebCore

[SVG] Convert OwnPtr/PassOwnPtr to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=124382

Patch by Sergio Correia <Sergio Correia> on 2013-11-19
Reviewed by Darin Adler.

The files modified are mostly under WebCore/svg/; in a few cases, some
"external" files needed changes as well.

No new tests, covered by existing ones.

css/CSSFontFaceSource.cpp:
loader/cache/CachedImage.cpp:
loader/cache/CachedImage.h:
platform/graphics/SimpleFontData.cpp:
platform/graphics/SimpleFontData.h:
rendering/svg/RenderSVGResourceContainer.cpp:
svg/SVGAnimateElement.cpp:
svg/SVGAnimateElement.h:
svg/SVGAnimatedAngle.cpp:
svg/SVGAnimatedAngle.h:
svg/SVGAnimatedBoolean.cpp:
svg/SVGAnimatedBoolean.h:
svg/SVGAnimatedColor.cpp:
svg/SVGAnimatedColor.h:
svg/SVGAnimatedEnumeration.cpp:
svg/SVGAnimatedEnumeration.h:
svg/SVGAnimatedInteger.cpp:
svg/SVGAnimatedInteger.h:
svg/SVGAnimatedIntegerOptionalInteger.cpp:
svg/SVGAnimatedIntegerOptionalInteger.h:
svg/SVGAnimatedLength.cpp:
svg/SVGAnimatedLength.h:
svg/SVGAnimatedLengthList.cpp:
svg/SVGAnimatedLengthList.h:
svg/SVGAnimatedNumber.cpp:
svg/SVGAnimatedNumber.h:
svg/SVGAnimatedNumberList.cpp:
svg/SVGAnimatedNumberList.h:
svg/SVGAnimatedNumberOptionalNumber.cpp:
svg/SVGAnimatedNumberOptionalNumber.h:
svg/SVGAnimatedPath.cpp:
svg/SVGAnimatedPath.h:
svg/SVGAnimatedPointList.cpp:
svg/SVGAnimatedPointList.h:
svg/SVGAnimatedPreserveAspectRatio.cpp:
svg/SVGAnimatedPreserveAspectRatio.h:
svg/SVGAnimatedRect.cpp:
svg/SVGAnimatedRect.h:
svg/SVGAnimatedString.cpp:
svg/SVGAnimatedString.h:
svg/SVGAnimatedTransformList.cpp:
svg/SVGAnimatedTransformList.h:
svg/SVGAnimatedType.cpp:
svg/SVGAnimatedType.h:
svg/SVGAnimatedTypeAnimator.cpp:
svg/SVGAnimatedTypeAnimator.h:
svg/SVGAnimatorFactory.h:
svg/SVGDocumentExtensions.cpp:
svg/SVGDocumentExtensions.h:
svg/SVGFontData.h:
svg/SVGFontElement.cpp:
svg/SVGFontElement.h:
svg/SVGGraphicsElement.cpp:
svg/SVGGraphicsElement.h:
svg/SVGPathByteStreamSource.h:
svg/SVGPathParser.h:
svg/SVGPathSegListSource.h:
svg/SVGPathStringSource.h:
svg/SVGPathUtilities.cpp:
svg/SVGPathUtilities.h:
svg/animation/SMILTimeContainer.cpp:
svg/animation/SMILTimeContainer.h:
svg/graphics/SVGImage.cpp:
svg/graphics/SVGImage.h:
svg/graphics/SVGImageCache.h:
svg/properties/SVGAttributeToPropertyMap.cpp:
svg/properties/SVGAttributeToPropertyMap.h:

9:15 AM Changeset in webkit [159502] by zoltan@webkit.org

2 edits in trunk/Source/WebCore

Add LineInlineHeaders.h to WebCore.xcodeproj
<https://webkit.org/b/124460>

Reviewed by Csaba Osztrogonác.

LineInlineHeaders.h (r159354) hasn't been added to WebCore.xcodeproj. This patch adds to it.

No new tests, no behavior change.

WebCore.xcodeproj/project.pbxproj:

9:11 AM Changeset in webkit [159501] by Michał Pakuła vel Rutka

2 edits in trunk/LayoutTests

Unreviewed EFL gardening

platform/efl/TestExpectations: Add new failure test expectations.

6:55 AM Changeset in webkit [159500] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[AX] Use std::unique_ptr to manage AXComputedObjectAttributeCache
https://bugs.webkit.org/show_bug.cgi?id=124404

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-19
Reviewed by Mario Sanchez Prada.

Convert OwnPtr/PassOwnPtr to std::unique_ptr.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::startCachingComputedObjectAttributesUntilTreeMutates):
(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):

accessibility/AXObjectCache.h:

(WebCore::AXComputedObjectAttributeCache::AXComputedObjectAttributeCache):

6:01 AM Changeset in webkit [159499] by Csaba Osztrogonác

275 edits in trunk

Unreviewed typo fix after r159494.

5:15 AM Changeset in webkit [159498] by rniwa@webkit.org

3 edits in trunk/Tools

Yet another build fix. Just allow any character.
There are just too many special characters to be listed here.

Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest._lines_to_ignore_in_parser_result):

Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTest.test_parse_output_with_subtests)

5:05 AM Changeset in webkit [159497] by rniwa@webkit.org

3 edits in trunk/Tools

Another build fix. Allow ':' in subtest names.

Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest._lines_to_ignore_in_parser_result):

Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTest.test_parse_output_with_subtests)

4:38 AM Changeset in webkit [159496] by ryuan.choi@samsung.com

4 edits in trunk

[EFL] Use Config mode of find_package for EFL 1.8
https://bugs.webkit.org/show_bug.cgi?id=124555

Reviewed by Gyuyoung Kim.

EFL 1.8 changed VERSION macro so it's difficult to use tricky approach
which parses header file to know the version. Instead, EFL 1.8 supports
Config mode of find_package using XXXConfig.cmake such as EinaConfig.cmake.

This patch tries to use Config mode if it is available after checking Eo.

Source/cmake/OptionsEfl.cmake:

Tools:

MiniBrowser/efl/CMakeLists.txt: Introduced a config mode to find elementary.

4:22 AM Changeset in webkit [159495] by rniwa@webkit.org

3 edits in trunk/Tools

Build fix. Subtest names need to be more permissive.

Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest._lines_to_ignore_in_parser_result):

Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTest.test_parse_output_with_subtests)

4:14 AM Changeset in webkit [159494] by Csaba Osztrogonác

275 edits in trunk

Unreviewed. Set svn:eol-style=native for Windows project files.

3:45 AM Changeset in webkit [159493] by gyuyoung.kim@samsung.com

2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Adding a crash expectation.

platform/efl/TestExpectations:

3:30 AM Changeset in webkit [159492] by gyuyoung.kim@samsung.com

2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Adding a crash expectation for a test regarding
object-fit.

platform/efl/TestExpectations:

3:12 AM BuildingGtk edited by tomeu.vizoso@collabora.com

(diff)

3:08 AM Changeset in webkit [159491] by gyuyoung.kim@samsung.com

2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. descent-clip-in-scaled-page.html is being passed
after enabling subpixel layout on EFL port.

platform/efl/TestExpectations:

2:37 AM Changeset in webkit [159490] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Adding failure expectations for the remaining layout test failures.

platform/gtk/TestExpectations:

1:43 AM Changeset in webkit [159489] by rniwa@webkit.org

8 edits in trunk/Source/WebCore

Add more assertions with security implications in DocumentOrderedMap
https://bugs.webkit.org/show_bug.cgi?id=124559

Reviewed by Antti Koivisto.

Assert that newly added elements and existing elements in the document ordered map are in the same tree scope
as the document ordered map. Also exit early if we're about to add an element in a wrong document to the map.
We don't exit early in get() because the damage has already been done at that point (the element may have been
deleted already).

dom/Document.cpp:

(WebCore::Document::addImageElementByLowercasedUsemap):

dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::add): Assert that the newly added element is in the current tree scope.
Also exit early if either the element is not in the tree scope or not in the right document.
While this doesn't make the function completely fault safe, it'll catch when we try to add a detached node.
(WebCore::DocumentOrderedMap::remove): Convert existing assertions to ones with security implication.
(WebCore::DocumentOrderedMap::get): Assert with security implication that the element we're about to return
is in the current tree scope. The element may have already been deleted if we ever hit these assertions.
(WebCore::DocumentOrderedMap::getAllElementsById): Convert an existing assertion to an assertion with security
implication.

dom/DocumentOrderedMap.h:
dom/TreeScope.cpp:

(WebCore::TreeScope::addElementById):
(WebCore::TreeScope::addElementByName):
(WebCore::TreeScope::addImageMap):
(WebCore::TreeScope::addLabel):

html/HTMLDocument.cpp:

(WebCore::HTMLDocument::addDocumentNamedItem):
(WebCore::HTMLDocument::addWindowNamedItem):

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::insertedInto): Set InTreeScope flag before calling addImageElementByLowercasedUsemap.

html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::insertedInto): Ditto for addImageMap.

1:28 AM Changeset in webkit [159488] by Manuel Rego Casasnovas

3 edits
1 add in trunk/PerformanceTests

[CSS Regions] Add performance test for selection
https://bugs.webkit.org/show_bug.cgi?id=119230

Reviewed by Ryosuke Niwa.

Add new performance test for selection in CSS Regions. It checks a
selection from the first region to the last one, passing through all the
regions.

Test is skipped for now while implementation of selection in CSS Regions
is still evolving.

Layout/RegionsSelection.html: Added.
Layout/resources/regions.js:

(.):

Skipped:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed