Timeline
Jan 20, 2014:
- 10:25 PM Changeset in webkit [162427] by
-
- 8 edits1 delete in trunk
[CMAKE] Remove Nix from CMake scripts
https://bugs.webkit.org/show_bug.cgi?id=127264
Reviewed by Anders Carlsson.
.:
- CMakeLists.txt:
- Source/CMakeLists.txt:
- Source/cmake/FindEGL.cmake:
- Source/cmake/OptionsCommon.cmake:
Source/Platform:
- CMakeLists.txt: Removed.
Source/WebCore:
- CMakeLists.txt:
- 9:26 PM Changeset in webkit [162426] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Move isEwkViewEvasObject back to ewk_view.cpp
https://bugs.webkit.org/show_bug.cgi?id=127261
Reviewed by Gyuyoung Kim.
isEwkViewEvasObject is general check routine of EFL and mainly used in
ewk_view.cpp but it was in EwkView.cpp since separated EwkView.cpp from ewk_view.cpp
This patch moves it to EwkView.h as inline function with small refactoring.
In addition, this patch added EINA_UNLIKELY keyword in cold paths.
- UIProcess/API/efl/EwkView.cpp:
(defaultSmartClassInstance):
(toSmartData):
(toEwkView): Moved it from bottom not to expose it to header file.
- UIProcess/API/efl/EwkView.h:
- UIProcess/API/efl/ewk_view.cpp:
(isEwkViewEvasObject):
(toEwkViewChecked):
- 8:21 PM Changeset in webkit [162425] by
-
- 3 edits in trunk/LayoutTests
Change image failures from [ Failure ] to [ ImageOnlyFailure ] where needed.
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- 7:27 PM Changeset in webkit [162424] by
-
- 11 edits in branches/jsCStack/Source/JavaScriptCore
IC status classes should directly query exit site information
https://bugs.webkit.org/show_bug.cgi?id=127326
Not yet reviewed.
This consolidates all of the reasoning about whether or not to inline an IC at the IR level.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFromLLInt):
(JSC::CallLinkStatus::computeFor):
- bytecode/CallLinkStatus.h:
- bytecode/CodeBlock.h:
(JSC::CodeBlock::hasExitSite):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::hasExitSite):
(JSC::GetByIdStatus::computeFor):
- bytecode/GetByIdStatus.h:
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::hasExitSite):
(JSC::PutByIdStatus::computeFor):
- bytecode/PutByIdStatus.h:
- bytecode/StructureSet.h:
(JSC::StructureSet::StructureSet):
(JSC::StructureSet::add):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
- 7:26 PM Changeset in webkit [162423] by
-
- 3 edits in trunk/LayoutTests
Add missing expectations to subpixel failures.
- platform/mac/TestExpectations:
- 6:56 PM Changeset in webkit [162422] by
-
- 5 edits in trunk/Source/WebInspectorUI
Add the recording button back to the Timelines sidebar.
https://bugs.webkit.org/show_bug.cgi?id=127314
Reviewed by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js: Updated.
- UserInterface/TimelineContentView.js:
(WebInspector.TimelineContentView.prototype.get navigationItems):
(WebInspector.TimelineContentView.prototype._update):
(WebInspector.TimelineContentView.prototype._updateTimes):
(WebInspector.TimelineContentView.prototype._startUpdatingCurrentTime):
(WebInspector.TimelineContentView.prototype._recordingTimesUpdated):
(WebInspector.TimelineContentView.prototype._clearTimeline):
(WebInspector.TimelineContentView.prototype._recordingReset):
Add a clear button and reset the time ruler and views when the recording resets.
- UserInterface/TimelineSidebarPanel.css:
(.sidebar > .panel.timeline > .status-bar):
(.sidebar > .panel.timeline > .status-bar > .record-glyph):
(.sidebar > .panel.timeline > .status-bar > .record-glyph.recording):
(.sidebar > .panel.timeline > .status-bar > .record-glyph:hover):
(.sidebar > .panel.timeline > .status-bar > .record-glyph.recording:hover):
(.sidebar > .panel.timeline > .status-bar > .record-glyph.forced):
(.sidebar > .panel.timeline > .status-bar > .record-glyph.recording.forced):
(.sidebar > .panel.timeline > .status-bar > .record-status):
Add styles for the recording button and status message.
- UserInterface/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype._contentBrowserCurrentContentViewDidChange):
(WebInspector.TimelineSidebarPanel.prototype._recordingStarted):
(WebInspector.TimelineSidebarPanel.prototype._recordingStopped):
(WebInspector.TimelineSidebarPanel.prototype._recordGlyphMousedOver):
(WebInspector.TimelineSidebarPanel.prototype._recordGlyphMousedOut):
(WebInspector.TimelineSidebarPanel.prototype._recordGlyphClicked):
Add support for the recording button and status message.
- 6:56 PM Changeset in webkit [162421] by
-
- 7 edits in trunk/Source/WebInspectorUI
Make the TimelineRecordTreeElement location subtitle live.
https://bugs.webkit.org/show_bug.cgi?id=127270
Reviewed by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js: Updated.
- UserInterface/SourceCodeLocation.js:
(WebInspector.SourceCodeLocation.prototype.originalLocationString):
(WebInspector.SourceCodeLocation.prototype.formattedLocationString):
(WebInspector.SourceCodeLocation.prototype.displayLocationString):
(WebInspector.SourceCodeLocation.prototype.updateDisplayString):
(WebInspector.SourceCodeLocation.prototype._locationString):
Support for a new nameStyle enum and a prefix for the location string.
Passing the prefix here lets it be italicized with the line number.
Support column number for SourceCode's without a URL too.
- UserInterface/TimelineRecordTreeElement.js:
(WebInspector.TimelineRecordTreeElement):
(WebInspector.TimelineRecordTreeElement.prototype.onattach):
Create a subtitle span to update the location inside. Update the tooltip on attach.
- 6:56 PM Changeset in webkit [162420] by
-
- 8 edits in trunk/Source/WebInspectorUI
Generate better display names for timer and event Timeline records.
Also support AnimationFrameRequested and AnimationFrameCanceled.
https://bugs.webkit.org/show_bug.cgi?id=127258
Reviewed by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js: Updated.
- UserInterface/LayoutTimelineRecord.js:
(WebInspector.LayoutTimelineRecord.EventType.displayName):
Generate past tense names that better match other names.
- UserInterface/ScriptTimelineDataGridNode.js:
(WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent):
Pass the details to displayName.
- UserInterface/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.EventType.displayName):
Generate better names for timer and event records. Also add missing animation frame types.
- UserInterface/ScriptTimelineView.js:
(WebInspector.ScriptTimelineView.prototype._processPendingRecords):
Pass true to WebInspector.TimelineRecordTreeElement to include timer identifiers in the title.
- UserInterface/SourceCodeTimelineTreeElement.js:
(WebInspector.SourceCodeTimelineTreeElement):
Pass includeTimerIdentifierInMainTitle through to TimelineRecordTreeElement.
- UserInterface/TimelineManager.js:
(WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
Include AnimationFrameRequested and AnimationFrameCanceled.
- UserInterface/TimelineRecordTreeElement.js:
(WebInspector.TimelineRecordTreeElement):
Use displayName functions instead and support includeTimerIdentifierInMainTitle.
- 6:56 PM Changeset in webkit [162419] by
-
- 10 edits3 copies4 adds in trunk/Source/WebInspectorUI
Implement basic versions of the TimelineOverview graphs.
https://bugs.webkit.org/show_bug.cgi?id=127184
Reviewed by Joseph Pecoraro.
- UserInterface/LayoutTimelineOverviewGraph.css: Added.
(.timeline-overview-graph.layout > .timeline-record-bar):
(.timeline-overview-graph.layout > .timeline-record-bar > .segment):
- UserInterface/LayoutTimelineOverviewGraph.js: Added.
(WebInspector.LayoutTimelineOverviewGraph.prototype.reset):
(WebInspector.LayoutTimelineOverviewGraph.prototype.updateLayout):
(WebInspector.LayoutTimelineOverviewGraph.prototype._layoutTimelineRecordAdded):
- UserInterface/Main.html: Added new files.
- UserInterface/NetworkTimelineOverviewGraph.css: Added.
(.timeline-overview-graph.network):
(.timeline-overview-graph.network > .graph-row):
(.timeline-overview-graph.network > .graph-row > .bar):
(.timeline-overview-graph.network > .graph-row > .bar.inactive):
(.timeline-overview-graph.network > .graph-row > .bar.unfinished):
(.timeline-overview-graph.network > .graph-row > .bar:not(.inactive)):
(.timeline-overview-graph.network:nth-child(even) > .graph-row > .bar:not(.inactive)):
- UserInterface/NetworkTimelineOverviewGraph.js: Added.
(WebInspector.NetworkTimelineOverviewGraph.prototype.reset):
(WebInspector.NetworkTimelineOverviewGraph.prototype.updateLayout.updateElementPosition):
(WebInspector.NetworkTimelineOverviewGraph.prototype.updateLayout.createBar):
(WebInspector.NetworkTimelineOverviewGraph.prototype.updateLayout):
(WebInspector.NetworkTimelineOverviewGraph.prototype._networkTimelineRecordAdded.compareByStartTime):
(WebInspector.NetworkTimelineOverviewGraph.prototype._networkTimelineRecordAdded.insertObjectIntoSortedArray):
(WebInspector.NetworkTimelineOverviewGraph.prototype._networkTimelineRecordAdded):
- UserInterface/ScriptTimelineOverviewGraph.css: Added.
(.timeline-overview-graph.script > .timeline-record-bar):
(.timeline-overview-graph.script > .timeline-record-bar > .segment):
- UserInterface/ScriptTimelineOverviewGraph.js: Added.
(WebInspector.ScriptTimelineOverviewGraph.prototype.reset):
(WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
(WebInspector.ScriptTimelineOverviewGraph.prototype._scriptTimelineRecordAdded):
- UserInterface/TimelineContentView.js:
(WebInspector.TimelineContentView.prototype._showTimelineView):
(WebInspector.TimelineContentView.prototype._update):
(WebInspector.TimelineContentView.prototype._recordingReset):
Create and keep the graphs informed.
- UserInterface/TimelineDataGridNode.js:
(WebInspector.TimelineDataGridNode):
(WebInspector.TimelineDataGridNode.prototype.refreshGraph):
Combine records that might overlap.
- UserInterface/TimelineOverview.css:
(.timeline-overview > .graphs-container):
(.timeline-overview > .graphs-container > .timeline-overview-graph):
(.timeline-overview > .graphs-container > .timeline-overview-graph:nth-child(even)):
(.timeline-overview > .graphs-container > .timeline-overview-graph:not(:first-child)):
Add the graph rows with alternating stripe.
- UserInterface/TimelineOverview.js:
(WebInspector.TimelineOverview):
(WebInspector.TimelineOverview.prototype.set startTime):
(WebInspector.TimelineOverview.prototype.get currentTime):
(WebInspector.TimelineOverview.prototype.set currentTime):
(WebInspector.TimelineOverview.prototype.updateLayout):
(WebInspector.TimelineOverview.prototype.updateLayoutIfNeeded):
Track currentTime in a member variable and let TimelineOverview manage the current time marker.
- UserInterface/TimelineOverviewGraph.js: Added.
(WebInspector.TimelineOverviewGraph):
(WebInspector.TimelineOverviewGraph.prototype.get zeroTime):
(WebInspector.TimelineOverviewGraph.prototype.set zeroTime):
(WebInspector.TimelineOverviewGraph.prototype.get startTime):
(WebInspector.TimelineOverviewGraph.prototype.set startTime):
(WebInspector.TimelineOverviewGraph.prototype.get endTime):
(WebInspector.TimelineOverviewGraph.prototype.set endTime):
(WebInspector.TimelineOverviewGraph.prototype.get currentTime):
(WebInspector.TimelineOverviewGraph.prototype.set currentTime):
(WebInspector.TimelineOverviewGraph.prototype.reset):
(WebInspector.TimelineOverviewGraph.prototype.updateLayout):
(WebInspector.TimelineOverviewGraph.prototype.updateLayoutIfNeeded):
(WebInspector.TimelineOverviewGraph.prototype.needsLayout):
- UserInterface/TimelineRecordBar.css:
(.timeline-record-bar > .segment):
(.timeline-record-bar.unfinished > .segment):
(.timeline-record-bar > .segment.inactive + .segment):
(.timeline-record-bar.timeline-record-type-network > .segment.inactive):
- UserInterface/TimelineRecordBar.js:
(WebInspector.TimelineRecordBar):
(WebInspector.TimelineRecordBar.recordsCannotBeCombined):
(WebInspector.TimelineRecordBar.prototype.get records):
(WebInspector.TimelineRecordBar.prototype.set records):
(WebInspector.TimelineRecordBar.prototype.refresh):
Make TimelineRecordBar support multiple records.
- UserInterface/TimelineRuler.css:
(.timeline-ruler > .markers):
(.timeline-ruler > .selection-handle):
(.timeline-ruler > .shaded-area):
Add some z-index values to stay above graph elements.
- 6:56 PM Changeset in webkit [162418] by
-
- 10 edits in trunk/Source/WebInspectorUI
Clean up Timelines code by using ES6 features and less global access of TimelineRecording.
Also don't recreate Timeline objects when TimelineRecording is reset, reset them instead.
https://bugs.webkit.org/show_bug.cgi?id=127157
Reviewed by Joseph Pecoraro.
- UserInterface/LayoutTimelineView.js:
(WebInspector.LayoutTimelineView.prototype.reset):
- UserInterface/NetworkTimeline.js:
(WebInspector.NetworkTimeline):
(WebInspector.NetworkTimeline.prototype.reset):
- UserInterface/NetworkTimelineView.js:
(WebInspector.NetworkTimelineView.prototype.reset):
- UserInterface/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView.prototype._networkTimelineRecordAdded):
- UserInterface/ScriptTimelineView.js:
(WebInspector.ScriptTimelineView.prototype.reset):
- UserInterface/Timeline.js:
(WebInspector.Timeline):
(WebInspector.Timeline.prototype.reset):
- UserInterface/TimelineContentView.js:
(WebInspector.TimelineContentView.set createPathComponent):
(WebInspector.TimelineContentView.set var):
(WebInspector.TimelineContentView.prototype.showOverviewTimelineView):
(WebInspector.TimelineContentView.prototype.showTimelineView):
(WebInspector.TimelineContentView.prototype._showTimelineView):
(WebInspector.TimelineContentView.prototype._update):
(WebInspector.TimelineContentView.prototype._recordingReset):
- UserInterface/TimelineRecording.js:
(WebInspector.TimelineRecording.prototype.reset):
- 6:56 PM Changeset in webkit [162417] by
-
- 5 edits in trunk/Source/WebInspectorUI
Improve WebInspector.TimelineOverview by not putting WebInspector.TimelineRuler in a scroll area.
https://bugs.webkit.org/show_bug.cgi?id=127145
Reviewed by Joseph Pecoraro.
- UserInterface/TimelineOverview.css:
(.timeline-overview > .scroll-container):
(.timeline-overview > .timeline-ruler):
(.timeline-overview > .scroll-container > .scroll-width-sizer):
- UserInterface/TimelineOverview.js:
(WebInspector.TimelineOverview):
(WebInspector.TimelineOverview.prototype.get startTime):
(WebInspector.TimelineOverview.prototype.set startTime):
(WebInspector.TimelineOverview.prototype.get secondsPerPixel):
(WebInspector.TimelineOverview.prototype.set secondsPerPixel):
(WebInspector.TimelineOverview.prototype.get scrollStartTime):
(WebInspector.TimelineOverview.prototype.set scrollStartTime):
(WebInspector.TimelineOverview.prototype.get visibleDuration):
(WebInspector.TimelineOverview.prototype.revealMarker):
(WebInspector.TimelineOverview.prototype.updateLayout):
(WebInspector.TimelineOverview.prototype._handleScrollEvent):
(WebInspector.TimelineOverview.prototype._handleWheelEvent):
- UserInterface/TimelineRuler.js:
(WebInspector.TimelineRuler.MinimumSelectionTimeRange): Reduce to 10ms now that super zoom has no performance impact.
- 6:56 PM Changeset in webkit [162416] by
-
- 15 edits2 copies3 adds in trunk/Source/WebInspectorUI
Implement the discrete Script and Layout timeline views.
https://bugs.webkit.org/show_bug.cgi?id=127063
Reviewed by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js: Updated.
- UserInterface/DataGrid.js:
(WebInspector.DataGrid): Support hidden columns by default.
(WebInspector.DataGrid.prototype.updateLayout): Set the column width to zero for hidden columns.
- UserInterface/LayoutTimelineDataGrid.js:
(WebInspector.LayoutTimelineDataGrid): Pass the right parameters to the superclass.
- UserInterface/LayoutTimelineRecord.js:
(WebInspector.LayoutTimelineRecord.prototype.saveIdentityToCookie): Added.
- UserInterface/LayoutTimelineView.css: Copied from Source/WebInspectorUI/UserInterface/ScriptTimelineDataGrid.js.
(.timeline-view.layout > .data-grid):
(.timeline-view.layout > .data-grid .eventType-column):
(.sidebar > .panel.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.layout .item .subtitle):
- UserInterface/LayoutTimelineView.js: Added.
(WebInspector.LayoutTimelineView):
(WebInspector.LayoutTimelineView.prototype.get navigationSidebarTreeOutlineLabel):
(WebInspector.LayoutTimelineView.prototype.shown):
(WebInspector.LayoutTimelineView.prototype.hidden):
(WebInspector.LayoutTimelineView.prototype.updateLayout):
(WebInspector.LayoutTimelineView.prototype.matchTreeElementAgainstCustomFilters):
(WebInspector.LayoutTimelineView.prototype._layoutTimelineRecordAdded):
(WebInspector.LayoutTimelineView.prototype._dataGridFiltersDidChange):
(WebInspector.LayoutTimelineView.prototype._treeElementSelected):
- UserInterface/Main.html: Added new files.
- UserInterface/ScriptTimelineDataGrid.js:
(WebInspector.ScriptTimelineDataGrid): Pass the right parameters to the superclass.
- UserInterface/ScriptTimelineDataGridNode.js:
(WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent): Fix up how we create the link.
- UserInterface/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.prototype.saveIdentityToCookie): Added.
- UserInterface/ScriptTimelineView.css: Copied from Source/WebInspectorUI/UserInterface/ScriptTimelineDataGrid.js.
(.timeline-view.script > .data-grid):
(.timeline-view.script > .data-grid .eventType-column):
(.sidebar > .panel.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.script .item .subtitle):
- UserInterface/ScriptTimelineView.js: Added.
(WebInspector.ScriptTimelineView):
(WebInspector.ScriptTimelineView.prototype.get navigationSidebarTreeOutlineLabel):
(WebInspector.ScriptTimelineView.prototype.shown):
(WebInspector.ScriptTimelineView.prototype.hidden):
(WebInspector.ScriptTimelineView.prototype.updateLayout):
(WebInspector.ScriptTimelineView.prototype.matchTreeElementAgainstCustomFilters):
(WebInspector.ScriptTimelineView.prototype._scriptTimelineRecordAdded):
(WebInspector.ScriptTimelineView.prototype._dataGridFiltersDidChange):
(WebInspector.ScriptTimelineView.prototype._treeElementSelected):
- UserInterface/SourceCodeTimelineTreeElement.js:
(WebInspector.SourceCodeTimelineTreeElement):
Moved code to TimelineRecordTreeElement. Subclass from it.
- UserInterface/TimelineContentView.js:
(WebInspector.TimelineContentView.prototype.matchTreeElementAgainstCustomFilters): Support TimelineRecordTreeElement.
(WebInspector.TimelineContentView.prototype._timeRangeSelectionChanged): Update zeroTime for all views.
- UserInterface/TimelineDataGrid.css:
(.data-grid.timeline td .icon):
(.data-grid.timeline td .go-to-arrow):
(.data-grid.timeline tr:hover .go-to-arrow):
(.data-grid.timeline td .subtitle):
(.data-grid.timeline td .subtitle::before):
(.data-grid.timeline:focus tr.selected td .subtitle):
- UserInterface/TimelineRecord.js:
(WebInspector.TimelineRecord.prototype.saveIdentityToCookie): Added.
- UserInterface/TimelineRecordTreeElement.js: Added.
(WebInspector.TimelineRecordTreeElement):
(WebInspector.TimelineRecordTreeElement.prototype.get record):
(WebInspector.TimelineRecordTreeElement.prototype.get filterableData):
Factored out from SourceCodeTimelineTreeElement.
- UserInterface/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.looslyCompareRepresentedObjects):
(WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject):
Find TreeElements via a loose lookup based on represented objects that might contain the represented object we are
really looking for.
- 6:55 PM Changeset in webkit [162415] by
-
- 11 edits2 adds in trunk/Source/WebInspectorUI
Implement the discrete Network timeline view.
https://bugs.webkit.org/show_bug.cgi?id=127022
Reviewed by Joseph Pecoraro.
- UserInterface/DataGrid.js:
(WebInspector.DataGrid): Align the labels of the column headers to match the data.
(WebInspector.DataGridNode.prototype.get selectable): Prevent selection when hidden.
- UserInterface/DetailsSection.css:
(.details-section > .header): Bump the font size to match data grid header sizes.
- UserInterface/Main.html: Add new files.
- UserInterface/NetworkTimelineView.css: Added.
(.timeline-view.network > .data-grid):
(.sidebar > .panel.timeline.timeline-content-view-showing > .content .item.resource .subtitle):
Hide the domain subtitle when the content view is showing which also has the domain.
- UserInterface/NetworkTimelineView.js: Added.
(WebInspector.NetworkTimelineView):
(WebInspector.NetworkTimelineView.prototype.get navigationSidebarTreeOutlineLabel):
(WebInspector.NetworkTimelineView.prototype.shown):
(WebInspector.NetworkTimelineView.prototype.hidden):
(WebInspector.NetworkTimelineView.prototype.updateLayout):
(WebInspector.NetworkTimelineView.prototype.matchTreeElementAgainstCustomFilters):
(WebInspector.NetworkTimelineView.prototype._networkTimelineRecordAdded):
(WebInspector.NetworkTimelineView.prototype._dataGridFiltersDidChange):
(WebInspector.NetworkTimelineView.prototype._treeElementSelected):
- UserInterface/ResourceTimelineDataGridNode.js:
(WebInspector.ResourceTimelineDataGridNode.prototype._needsRefresh):
Call dataGridNodeNeedsRefresh on the TimelineDataGrid so things can be batched with
one request animation frame.
- UserInterface/TimelineContentView.js:
(WebInspector.TimelineContentView): Create a NetworkTimelineView.
(WebInspector.TimelineContentView.prototype.matchTreeElementAgainstCustomFilters):
- UserInterface/TimelineDataGrid.css:
(.data-grid.timeline table):
(.data-grid.timeline th):
(.data-grid.timeline th:not(:last-child)):
(.data-grid.timeline th.sortable:active):
(.data-grid.timeline th.sort-descending):
(.data-grid.timeline .data-container):
(.data-grid.timeline td):
(.data-grid.timeline td:last-child):
(.data-grid.timeline td:not(:last-child)):
(.data-grid.timeline:focus tr.selected td:not(:last-child)):
(.data-grid.timeline th.sort-descending > div:first-child):
(.data-grid.timeline th.sort-descending > div:first-child::after):
(.data-grid.timeline td.error):
(.data-grid.timeline tr.selected td.error):
(.data-grid.timeline > .navigation-bar-container):
(.data-grid.timeline:hover > .navigation-bar-container):
(.data-grid.timeline > .navigation-bar-container > .navigation-bar):
- UserInterface/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid):
(WebInspector.TimelineDataGrid.createColumnScopeBar):
(WebInspector.TimelineDataGrid.prototype.reset):
(WebInspector.TimelineDataGrid.prototype.shown):
(WebInspector.TimelineDataGrid.prototype.hidden):
(WebInspector.TimelineDataGrid.prototype.callFramePopoverAnchorElement):
(WebInspector.TimelineDataGrid.prototype.updateLayout):
(WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters):
(WebInspector.TimelineDataGrid.prototype.addRowInSortOrder):
(WebInspector.TimelineDataGrid.prototype.shouldIgnoreSelectionEvent):
(WebInspector.TimelineDataGrid.prototype.dataGridNodeNeedsRefresh):
(WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
(WebInspector.TimelineDataGrid.prototype._sort):
(WebInspector.TimelineDataGrid.prototype._sortComparator):
Add support for sorting, batch refresh and managing of a TreeOutlineDataGridSynchronizer.
- UserInterface/TimelineSidebarPanel.css:
(.sidebar > .panel.timeline > .title-bar): Bump the font size to match data grid header sizes.
- UserInterface/TimelineView.js:
(WebInspector.TimelineView.prototype.matchTreeElementAgainstCustomFilters): Added stub.
- UserInterface/TreeOutlineDataGridSynchronizer.js:
(WebInspector.TreeOutlineDataGridSynchronizer.prototype.get treeOutline):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype.get dataGrid):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype.get enabled):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype.set enabled):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype.treeElementForDataGridNode):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype.dataGridNodeForTreeElement):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeOutlineScrolled):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridScrolled):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridNodeSelected):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridNodeExpanded):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridNodeCollapsed):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeElementSelected):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeElementAdded):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeElementRemoved):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeElementExpanded):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeElementCollapsed):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeElementHiddenChanged):
Added support for disabling the synchronizer when the client can do a better job.
- 6:55 PM Changeset in webkit [162414] by
-
- 5 edits in trunk/Source/WebInspectorUI
Filter the Timeline overview graph and sidebar based on the current time selection.
https://bugs.webkit.org/show_bug.cgi?id=126955
Reviewed by Joseph Pecoraro.
- UserInterface/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.updateFilter):
(WebInspector.NavigationSidebarPanel.prototype.hasCustomFilters):
(WebInspector.NavigationSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
(WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.matchTextFilter):
(WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement):
Add support for custom filters implemented by subclasses.
- UserInterface/TimelineContentView.js:
(WebInspector.TimelineContentView.prototype.matchTreeElementAgainstCustomFilters.checkTimeBounds):
(WebInspector.TimelineContentView.prototype.matchTreeElementAgainstCustomFilters):
(WebInspector.TimelineContentView.prototype._timeRangeSelectionChanged):
Filter known tree element types by time.
- UserInterface/TimelineSidebarPanel.css:
(.sidebar > .panel.timeline > .empty-content-placeholder):
Position the empty placeholder with the content.
- UserInterface/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype.hasCustomFilters):
(WebInspector.TimelineSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
Defer filtering to the TimelineContentView.
- 6:55 PM Changeset in webkit [162413] by
-
- 9 edits in trunk/Source/WebInspectorUI
Implement state cookie support for WebInspector.TimelineSidebarPanel.
https://bugs.webkit.org/show_bug.cgi?id=126921
Reviewed by Joseph Pecoraro.
- UserInterface/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.prototype.restoreStateFromCookie):
Drive-by fix to pass along relaxedMatchDelay to the superclass.
- UserInterface/Main.js:
(WebInspector.loaded):
(WebInspector._provisionalLoadStarted):
Listen for ProvisionalLoadStarted instead of ProvisionalLoadCommitted to save the cookie
before the TimelineRecording is reset and clears the UI.
- UserInterface/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.get restoringState): Added.
(WebInspector.NavigationSidebarPanel.prototype.restoreStateFromCookie.finalAttemptToRestoreViewStateFromCookie):
Delete _pendingViewStateCookie since this was the final attempt.
(WebInspector.NavigationSidebarPanel.prototype.restoreStateFromCookie):
(WebInspector.NavigationSidebarPanel.prototype._isTreeElementWithoutRepresentedObject): Block string represented objects.
(WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):
- UserInterface/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView.prototype._treeElementSelected):
- UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype.treeElementForRepresentedObject):
Drive-by fix to null check parentFrame since it can be null. Was causing an exception while working on this.
- UserInterface/SourceCodeTimeline.js:
(WebInspector.SourceCodeTimeline):
(WebInspector.SourceCodeTimeline.prototype.saveIdentityToCookie):
- UserInterface/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype.canShowDifferentContentView):
(WebInspector.TimelineSidebarPanel.prototype.saveStateToCookie):
(WebInspector.TimelineSidebarPanel.prototype.restoreStateFromCookie):
- UserInterface/TreeOutline.js:
(TreeOutline.prototype._forgetTreeElement):
Drive-by fix to clear selectedTreeElement if it is removed from the tree. Was causing removed TreeElements to be
saved as a cookie since it was still the selected item.
- 6:55 PM Changeset in webkit [162412] by
-
- 5 edits2 copies2 adds in trunk/Source/WebInspectorUI
Implement bar graph rendering for WebInspector.OverviewTimelineView.
https://bugs.webkit.org/show_bug.cgi?id=126831
Reviewed by Joseph Pecoraro.
- UserInterface/Main.html: Added new files.
- UserInterface/OverviewTimelineView.css:
(.timeline-view.overview > .data-grid td.graph-column):
(.timeline-view.overview > .data-grid td.graph-column > div):
(.timeline-view.overview > .data-grid td.graph-column .timeline-record-bar):
Position the bars in the DataGrid cells.
- UserInterface/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView.prototype.updateLayout):
(WebInspector.OverviewTimelineView.prototype._addResourceToTreeIfNeeded):
(WebInspector.OverviewTimelineView.prototype._sourceCodeTimelineAdded):
Create the proper DataGridNodes for resources and source code timelines.
- UserInterface/ResourceTimelineDataGridNode.js:
(WebInspector.ResourceTimelineDataGridNode):
(WebInspector.ResourceTimelineDataGridNode.prototype.get records):
(WebInspector.ResourceTimelineDataGridNode.prototype.get resource):
(WebInspector.ResourceTimelineDataGridNode.prototype.get data):
(WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
(WebInspector.ResourceTimelineDataGridNode.prototype.refresh):
(WebInspector.ResourceTimelineDataGridNode.prototype._needsRefresh):
(WebInspector.ResourceTimelineDataGridNode.prototype._goToResource):
Simplify by deferring the graph logic to the new TimelineDataGridNode base class.
- UserInterface/SourceCodeTimelineTimelineDataGridNode.js: Added.
(WebInspector.SourceCodeTimelineTimelineDataGridNode):
(WebInspector.SourceCodeTimelineTimelineDataGridNode.prototype.get records):
(WebInspector.SourceCodeTimelineTimelineDataGridNode.prototype.get sourceCodeTimeline):
(WebInspector.SourceCodeTimelineTimelineDataGridNode.prototype.get data):
- UserInterface/TimelineDataGridNode.js: Added.
(WebInspector.TimelineDataGridNode):
(WebInspector.TimelineDataGridNode.prototype.get records):
(WebInspector.TimelineDataGridNode.prototype.get data):
(WebInspector.TimelineDataGridNode.prototype.createCellContent):
(WebInspector.TimelineDataGridNode.prototype.refresh):
(WebInspector.TimelineDataGridNode.prototype.refreshGraph):
(WebInspector.TimelineDataGridNode.prototype.needsGraphRefresh):
Handles the graph column and manages the records and their bars.
- UserInterface/TimelineRecordBar.css: Added.
(.timeline-record-bar):
(.timeline-record-bar > .segment):
(.timeline-record-bar:not(.has-inactive-segment) > .segment):
(.timeline-record-bar.unfinished > .segment):
(.timeline-record-bar > .segment.inactive + .segment):
(:focus .selected .timeline-record-bar > .segment):
(.timeline-record-bar > .segment.inactive):
(.timeline-record-bar.timeline-record-type-network > .segment):
(.timeline-record-bar.timeline-record-type-layout > .segment):
(.timeline-record-bar.timeline-record-type-script > .segment):
- UserInterface/TimelineRecordBar.js: Added.
(WebInspector.TimelineRecordBar):
(WebInspector.TimelineRecordBar.prototype.get element):
(WebInspector.TimelineRecordBar.prototype.refresh):
(WebInspector.TimelineRecordBar.prototype._updateElementPosition):
- 6:55 PM Changeset in webkit [162411] by
-
- 6 edits in trunk/Source/WebInspectorUI
Update the current WebInspector.TimelineView when time range changes.
https://bugs.webkit.org/show_bug.cgi?id=126667
Reviewed by Joseph Pecoraro.
- UserInterface/TimelineContentView.js:
(WebInspector.TimelineContentView.prototype._showTimelineView):
(WebInspector.TimelineContentView.prototype._update):
(WebInspector.TimelineContentView.prototype._startUpdatingCurrentTime):
(WebInspector.TimelineContentView.prototype._stopUpdatingCurrentTime):
(WebInspector.TimelineContentView.prototype._recordingStarted):
(WebInspector.TimelineContentView.prototype._recordingStopped):
(WebInspector.TimelineContentView.prototype._recordingReset):
(WebInspector.TimelineContentView.prototype._timeRangeSelectionChanged):
- UserInterface/TimelineOverview.js:
(WebInspector.TimelineOverview):
(WebInspector.TimelineOverview.prototype.updateLayout):
(WebInspector.TimelineOverview.prototype.updateLayoutIfNeeded):
(WebInspector.TimelineOverview.prototype._updateElementWidth):
(WebInspector.TimelineOverview.prototype._handleWheelEvent):
(WebInspector.TimelineOverview.prototype._timeRangeSelectionChanged):
- UserInterface/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype.updateLayoutIfNeeded):
- UserInterface/TimelineView.js:
(WebInspector.TimelineView):
(WebInspector.TimelineView.prototype.get zeroTime):
(WebInspector.TimelineView.prototype.set zeroTime):
(WebInspector.TimelineView.prototype.get startTime):
(WebInspector.TimelineView.prototype.set startTime):
(WebInspector.TimelineView.prototype.get endTime):
(WebInspector.TimelineView.prototype.set endTime):
(WebInspector.TimelineView.prototype.get currentTime):
(WebInspector.TimelineView.prototype.set currentTime.checkIfLayoutIsNeeded):
(WebInspector.TimelineView.prototype.set currentTime):
(WebInspector.TimelineView.prototype.updateLayout):
(WebInspector.TimelineView.prototype.updateLayoutIfNeeded):
(WebInspector.TimelineView.prototype.needsLayout):
- 6:55 PM Changeset in webkit [162410] by
-
- 5 edits in trunk/Source/WebInspectorUI
Implement time range selection for TimelineOverview and TimelineRuler.
https://bugs.webkit.org/show_bug.cgi?id=126035
Reviewed by Joseph Pecoraro.
- UserInterface/TimelineContentView.js:
(WebInspector.TimelineContentView.prototype._update):
(WebInspector.TimelineContentView.prototype._recordingReset):
Properly update start time and the selection start time on reset.
- UserInterface/TimelineOverview.js:
(WebInspector.TimelineOverview):
(WebInspector.TimelineOverview.prototype.get selectionStartTime):
(WebInspector.TimelineOverview.prototype.set selectionStartTime):
(WebInspector.TimelineOverview.prototype.get selectionDuration):
(WebInspector.TimelineOverview.prototype.set selectionDuration):
Added selection getters and setters.
- UserInterface/TimelineRuler.css:
(.timeline-ruler.allows-time-range-selection):
(.timeline-ruler > *):
(.timeline-ruler > .header):
(.timeline-ruler > .selection-drag):
(.timeline-ruler > .selection-drag:active):
(.timeline-ruler > .selection-handle):
(.timeline-ruler > .selection-handle.left):
(.timeline-ruler > .selection-handle.right):
(.timeline-ruler > .shaded-area):
(.timeline-ruler > .shaded-area.left):
(.timeline-ruler > .shaded-area.right):
Added styles for the selection elements and tweaked pointer-events to allow
events on elements we expect.
- UserInterface/TimelineRuler.js:
(WebInspector.TimelineRuler):
(WebInspector.TimelineRuler.prototype.get allowsTimeRangeSelection): Added.
(WebInspector.TimelineRuler.prototype.set allowsTimeRangeSelection): Added.
(WebInspector.TimelineRuler.prototype.get selectionStartTime): Added.
(WebInspector.TimelineRuler.prototype.set selectionStartTime): Added.
(WebInspector.TimelineRuler.prototype.get selectionEndTime): Added.
(WebInspector.TimelineRuler.prototype.set selectionEndTime): Added.
(WebInspector.TimelineRuler.prototype.updateLayout):
(WebInspector.TimelineRuler.prototype._needsMarkerLayout.update):
(WebInspector.TimelineRuler.prototype._needsMarkerLayout):
(WebInspector.TimelineRuler.prototype._needsSelectionLayout.update):
(WebInspector.TimelineRuler.prototype._needsSelectionLayout):
(WebInspector.TimelineRuler.prototype._recalculate):
(WebInspector.TimelineRuler.prototype._updatePositionOfElement):
(WebInspector.TimelineRuler.prototype._updateMarkers):
(WebInspector.TimelineRuler.prototype._updateSelection): Added.
(WebInspector.TimelineRuler.prototype._dispatchTimeRangeSelectionChangedEvent):
(WebInspector.TimelineRuler.prototype._timelineMarkerTimeChanged):
(WebInspector.TimelineRuler.prototype._handleMouseDown): Added.
(WebInspector.TimelineRuler.prototype._handleMouseMove): Added.
(WebInspector.TimelineRuler.prototype._handleMouseUp): Added.
(WebInspector.TimelineRuler.prototype._handleSelectionHandleMouseDown): Added.
(WebInspector.TimelineRuler.prototype._handleSelectionHandleMouseMove): Added.
(WebInspector.TimelineRuler.prototype._handleSelectionHandleMouseUp): Added.
Create selection elements and handle mouse events for drag and move.
- 6:55 PM Changeset in webkit [162409] by
-
- 2 edits in trunk/Source/WebInspectorUI
Support scroll to zoom in TimelineOverview.
https://bugs.webkit.org/show_bug.cgi?id=125909
Reviewed by Joseph Pecoraro.
- UserInterface/TimelineOverview.js:
(WebInspector.TimelineOverview):
(WebInspector.TimelineOverview.prototype._handleWheelEvent):
- 6:55 PM Changeset in webkit [162408] by
-
- 8 edits1 copy1 move1 add in trunk/Source/WebInspectorUI
Add the start of the TimelineOverview class.
TimelineOverview currently has a time ruler and tracks the current recording time.
https://bugs.webkit.org/show_bug.cgi?id=125878
Reviewed by Joseph Pecoraro.
- UserInterface/Main.html:
- UserInterface/TimelineContentView.css:
(.content-view.timeline > .timeline-overview):
- UserInterface/TimelineContentView.js:
(WebInspector.TimelineContentView):
(WebInspector.TimelineContentView.prototype.updateLayout):
(WebInspector.TimelineContentView.prototype._update):
(WebInspector.TimelineContentView.prototype._recordingStarted):
(WebInspector.TimelineContentView.prototype._recordingStopped):
(WebInspector.TimelineContentView.prototype._recordingReset):
- UserInterface/TimelineManager.js:
(WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
(WebInspector.TimelineManager.prototype.eventRecorded):
- UserInterface/TimelineMarker.js: Renamed from Source/WebInspectorUI/UserInterface/TimelineEventMarker.js.
(WebInspector.TimelineMarker):
(WebInspector.TimelineMarker.prototype.get time):
(WebInspector.TimelineMarker.prototype.set time):
(WebInspector.TimelineMarker.prototype.get type):
- UserInterface/TimelineOverview.css: Added.
(.timeline-overview > .scroll-container):
(.timeline-overview > .scroll-container > .timeline-ruler):
- UserInterface/TimelineOverview.js: Added.
(WebInspector.TimelineOverview):
(WebInspector.TimelineOverview.prototype.get element):
(WebInspector.TimelineOverview.prototype.get startTime):
(WebInspector.TimelineOverview.prototype.set startTime):
(WebInspector.TimelineOverview.prototype.get secondsPerPixel):
(WebInspector.TimelineOverview.prototype.set secondsPerPixel):
(WebInspector.TimelineOverview.prototype.get endTime):
(WebInspector.TimelineOverview.prototype.set endTime):
(WebInspector.TimelineOverview.prototype.addMarker):
(WebInspector.TimelineOverview.prototype.revealMarker):
(WebInspector.TimelineOverview.prototype.updateLayout):
(WebInspector.TimelineOverview.prototype._updateElementWidth):
(WebInspector.TimelineOverview.prototype._needsLayout):
- UserInterface/TimelineRecording.js:
(WebInspector.TimelineRecording.prototype.get startTime):
(WebInspector.TimelineRecording.prototype.get endTime):
(WebInspector.TimelineRecording.prototype.reset):
- UserInterface/TimelineRuler.css:
(.timeline-ruler > .markers):
(.timeline-ruler > .markers > .marker):
(.timeline-ruler > .markers > .marker.current-time):
(.timeline-ruler > .markers > .marker.current-time::before):
(.timeline-ruler > .markers > .marker.load-event):
(.timeline-ruler > .markers > .marker.dom-content-event):
(.timeline-ruler > .markers > .marker.timestamp):
- UserInterface/TimelineRuler.js:
(WebInspector.TimelineRuler):
(WebInspector.TimelineRuler.prototype.updateLayout):
(WebInspector.TimelineRuler.prototype._needsLayout):
(WebInspector.TimelineRuler.prototype._needsMarkerLayout.update):
(WebInspector.TimelineRuler.prototype._needsMarkerLayout):
(WebInspector.TimelineRuler.prototype._recalculate):
(WebInspector.TimelineRuler.prototype._updateLeftPositionOfElement):
(WebInspector.TimelineRuler.prototype._updateMarkers):
(WebInspector.TimelineRuler.prototype._timelineMarkerTimeChanged):
- 6:54 PM Changeset in webkit [162407] by
-
- 4 edits1 move1 add1 delete in trunk/Source/WebInspectorUI
Clean up and refactor TimelineDecorations into TimelineRuler.
https://bugs.webkit.org/show_bug.cgi?id=125709
Reviewed by Joseph Pecoraro.
- UserInterface/Main.html:
- UserInterface/OverviewTimelineView.css:
(.timeline-view.overview > .timeline-ruler):
(.timeline-view.overview > .timeline-ruler > .header):
(.timeline-view.overview > .timeline-ruler > .event-markers):
Updated class names and border sides.
- UserInterface/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView):
(WebInspector.OverviewTimelineView.prototype.updateLayout):
Call updateLayout on the TimelineRuler.
- UserInterface/TimelineRuler.css: Renamed from Source/WebInspectorUI/UserInterface/TimelineDecorations.css.
(.timeline-ruler):
(.timeline-ruler > .header):
(.timeline-ruler > .header > .divider):
(.timeline-ruler > .header > .divider > .label):
(.timeline-ruler > .event-markers):
(.timeline-ruler > .event-markers > .event-marker-tooltip):
(.timeline-ruler > .event-markers > .event-marker):
(.timeline-ruler > .event-markers > .event-marker.load-event):
(.timeline-ruler > .event-markers > .event-marker.dom-content-event):
(.timeline-ruler > .event-markers > .event-marker.timestamp):
Updated class names and border sides.
- UserInterface/TimelineRuler.js: Renamed from Source/WebInspectorUI/UserInterface/TimelineDecorations.js.
(WebInspector.TimelineRuler):
(WebInspector.TimelineRuler.prototype.get element):
(WebInspector.TimelineRuler.prototype.get headerElement):
(WebInspector.TimelineRuler.prototype.get allowsClippedLabels):
(WebInspector.TimelineRuler.prototype.set allowsClippedLabels):
(WebInspector.TimelineRuler.prototype.get zeroTime):
(WebInspector.TimelineRuler.prototype.set zeroTime):
(WebInspector.TimelineRuler.prototype.get startTime):
(WebInspector.TimelineRuler.prototype.set startTime):
(WebInspector.TimelineRuler.prototype.get duration):
(WebInspector.TimelineRuler.prototype.set duration):
(WebInspector.TimelineRuler.prototype.get endTime):
(WebInspector.TimelineRuler.prototype.set endTime):
(WebInspector.TimelineRuler.prototype.get secondsPerPixel):
(WebInspector.TimelineRuler.prototype.set secondsPerPixel):
(WebInspector.TimelineRuler.prototype.updateLayout.removeDividerAndSelectNext):
(WebInspector.TimelineRuler.prototype.updateLayout):
(WebInspector.TimelineRuler.prototype._needsLayout):
(WebInspector.TimelineRuler.prototype._recalculate):
Refactor so the times are stored on TimelineRuler and not passed in each time an update is needed.
Support dividers that don't always start at the zero position, allowing a sliding time ruler.
Support for a non-pinned ruler where the end time is not fixed and the scale is specified in
seconds-per-pixel.
- 6:54 PM Changeset in webkit [162406] by
-
- 2 edits in trunk/Source/WebInspectorUI
Improve scroll performance of WebInspector.TreeOutlineDataGridSynchronizer.
https://bugs.webkit.org/show_bug.cgi?id=126660
Reviewed by Joseph Pecoraro.
- UserInterface/TreeOutlineDataGridSynchronizer.js:
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeOutlineScrolled):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridScrolled):
Ignore scroll events triggered by our internal use of setting scrollTop.
- 6:54 PM Changeset in webkit [162405] by
-
- 10 edits1 add in trunk/Source/WebInspectorUI
Add a synchronized DataGrid to the OverviewTimelineView.
The DataGrid is synchronized with the sidebar TreeOutline to appear as one when the view
and sidebar are both showing. The two scroll, expand and collapse in sync when the view
is showing. When the view is not showing the sidebar can scroll independently.
https://bugs.webkit.org/show_bug.cgi?id=124429
Reviewed by Joseph Pecoraro.
- UserInterface/DataGrid.js:
(WebInspector.DataGrid):
(WebInspector.DataGrid.createSortableDataGrid):
(WebInspector.DataGrid.prototype._copyTextForDataGridNode):
(WebInspector.DataGridNode.prototype.createCellContent):
Handle undefined/null cells better by substituting empty strings.
(WebInspector.DataGridNode.prototype.collapse):
(WebInspector.DataGridNode.prototype.expand):
Fire events on the DataGrid for expand and collapse.
- UserInterface/Main.html: Include TreeOutlineDataGridSynchronizer.js.
- UserInterface/NavigationSidebarPanel.css:
(.sidebar > .panel.navigation > .content): Shorten by 1px to match the content view height.
Needed to keep scrolling in sync. The clipping looks better too.
- UserInterface/OverviewTimelineView.css:
(.timeline-view.overview > .data-grid):
(.timeline-view.overview > .data-grid table.header):
(.timeline-view.overview > .data-grid .data-container):
Style the DataGrid to to not have a header.
- UserInterface/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView):
(WebInspector.OverviewTimelineView.prototype.shown):
(WebInspector.OverviewTimelineView.prototype._addResourceToTreeIfNeeded):
(WebInspector.OverviewTimelineView.prototype._sourceCodeTimelineAdded):
Create the DataGrid and some placeholder nodes. Hook up TreeOutlineDataGridSynchronizer.
- UserInterface/TimelineContentView.css:
(.content-view.timeline > .view-container > .timeline-view > .data-grid td):
(.content-view.timeline > .view-container > .timeline-view > .data-grid table.data):
Style the DataGrid to match the height of TreeElements in the sidebar.
- UserInterface/TimelineSidebarPanel.css:
(.sidebar > .panel.timeline.timeline-content-view-showing > .content):
Hide the scrollbar off the right when the view is showing. The view will show the scrollbar.
- UserInterface/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel):
(WebInspector.TimelineSidebarPanel.prototype._timelinesTreeElementSelected):
(WebInspector.TimelineSidebarPanel.prototype._contentBrowserCurrentContentViewDidChange):
- UserInterface/TreeOutline.js:
(TreeOutline.prototype.removeChildAtIndex):
(TreeOutline.prototype.removeChildren):
(TreeOutline.prototype.removeChildrenRecursive):
(TreeElement.prototype.set hidden):
Add event callbacks for onhidden and onremove.
- UserInterface/TreeOutlineDataGridSynchronizer.js: Added.
(WebInspector.TreeOutlineDataGridSynchronizer):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype.associate):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype.synchronize):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeOutlineScrolled):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridScrolled):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridNodeSelected):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridNodeExpanded):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridNodeCollapsed):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeElementSelected):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeElementAdded):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeElementRemoved):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeElementExpanded):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeElementCollapsed):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeElementHiddenChanged):
- 6:54 PM Changeset in webkit [162404] by
-
- 6 edits4 copies9 adds in trunk/Source/WebInspectorUI
Start fleshing out the Overview Timeline view.
This gets the overview populating in the Timeline sidebar. The graph side is still empty.
https://bugs.webkit.org/show_bug.cgi?id=124005
Reviewed by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js: Updated.
- UserInterface/Frame.js:
(WebInspector.Frame.prototype.addResource):
- UserInterface/Images/TimelineRecordAnimation.svg: Added.
- UserInterface/Images/TimelineRecordEvent.svg: Added.
- UserInterface/Images/TimelineRecordLayout.svg: Added.
- UserInterface/Images/TimelineRecordPaint.svg: Added.
- UserInterface/Images/TimelineRecordScriptEvaluated.svg: Added.
- UserInterface/Images/TimelineRecordStyle.svg: Added.
- UserInterface/Images/TimelineRecordTimer.svg: Added.
- UserInterface/Main.html:
- UserInterface/OverviewTimelineView.js: Added.
(WebInspector.OverviewTimelineView):
(WebInspector.OverviewTimelineView.prototype.get navigationSidebarTreeOutlineLabel):
(WebInspector.OverviewTimelineView.prototype._childFrameWasAdded):
(WebInspector.OverviewTimelineView.prototype._mainResourceDidChange):
(WebInspector.OverviewTimelineView.prototype._provisionalResourceWasAdded):
(WebInspector.OverviewTimelineView.prototype._resourceWasAdded):
(WebInspector.OverviewTimelineView.prototype._compareTreeElementsByDetails):
(WebInspector.OverviewTimelineView.prototype._compareTreeElementsByStartTime):
(WebInspector.OverviewTimelineView.prototype._insertTreeElement):
(WebInspector.OverviewTimelineView.prototype._addResourceToTreeIfNeeded):
(WebInspector.OverviewTimelineView.prototype._sourceCodeTimelineAdded):
(WebInspector.OverviewTimelineView.prototype._treeElementSelected):
- UserInterface/SourceCodeTimelineTreeElement.js: Added.
(WebInspector.SourceCodeTimelineTreeElement):
(WebInspector.SourceCodeTimelineTreeElement.prototype.get sourceCodeTimeline):
- UserInterface/TimelineContentView.js:
(WebInspector.TimelineContentView.createPathComponent):
(WebInspector.TimelineContentView):
(WebInspector.TimelineContentView.prototype.showOverviewTimelineView):
(WebInspector.TimelineContentView.prototype.showTimelineView):
(WebInspector.TimelineContentView.prototype.get supportsSplitContentBrowser):
(WebInspector.TimelineContentView.prototype.get selectionPathComponents):
(WebInspector.TimelineContentView.prototype._pathComponentSelected):
(WebInspector.TimelineContentView.prototype._showTimelineView):
(WebInspector.TimelineContentView.prototype._recordingReset):
- UserInterface/TimelineIcons.css:
(.style-record .icon): Added.
(.layout-record .icon): Added.
(.paint-record .icon): Added.
(.evaluated-record .icon): Added.
(.event-record .icon): Added.
(.timer-record .icon): Added.
(.animation-record .icon): Added.
- UserInterface/TimelineView.css: Added.
(.timeline-view):
- UserInterface/TimelineView.js: Added.
(WebInspector.TimelineView):
(WebInspector.TimelineView.prototype.get navigationSidebarTreeOutline):
(WebInspector.TimelineView.prototype.get navigationSidebarTreeOutlineLabel):
(WebInspector.TimelineView.prototype.reset):
(WebInspector.TimelineView.prototype.shown):
(WebInspector.TimelineView.prototype.hidden):
- 6:54 PM Changeset in webkit [162403] by
-
- 9 edits2 copies1 move8 adds in trunk/Source/WebInspectorUI
Start fleshing out the new TimelineSidebarPanel and TimelineContentView.
https://bugs.webkit.org/show_bug.cgi?id=124003
Reviewed by Joseph Pecoraro.
- UserInterface/ContentView.js:
(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):
- UserInterface/FrameContentView.js:
- UserInterface/Images/CloseTimeline.png: Added.
- UserInterface/Images/CloseTimeline@2x.png: Added.
- UserInterface/Images/ColorsLarge.png: Added.
- UserInterface/Images/ColorsLarge@2x.png: Added.
- UserInterface/Images/NetworkLarge.png: Added.
- UserInterface/Images/NetworkLarge@2x.png: Added.
- UserInterface/Images/ScriptLarge.png: Added.
- UserInterface/Images/ScriptLarge@2x.png: Added.
- UserInterface/Main.html:
- UserInterface/Main.js:
(WebInspector.sidebarPanelForRepresentedObject):
(WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
- UserInterface/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.showDefaultContentView):
- UserInterface/ResourceClusterContentView.js:
- UserInterface/TimelineContentView.css: Added.
(.content-view.timeline > .view-container):
- UserInterface/TimelineContentView.js: Added.
(WebInspector.TimelineContentView):
- UserInterface/TimelineIcons.css: Renamed from Source/WebInspectorUI/UserInterface/InstrumentIcons.css.
(.network-icon.large .icon): Added.
(.colors-icon.large .icon): Added.
(.script-icon.large .icon): Added.
- UserInterface/TimelineSidebarPanel.css:
(.sidebar > .panel.timeline > .navigation-bar):
(.sidebar > .panel.timeline > .title-bar):
(.sidebar > .panel.timeline > .title-bar.timelines):
(.sidebar > .panel.timeline > .title-bar.timeline-events):
(.sidebar > .panel.timeline > .timelines-content):
(.sidebar > .panel.timeline > .timelines-content .close-button):
(.sidebar > .panel.timeline > .timelines-content li.item.selected .close-button):
(.sidebar > .panel.timeline > .timelines-content .close-button:active):
(.sidebar > .panel.timeline > .content):
- UserInterface/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.createTimelineTreeElement):
(WebInspector.TimelineSidebarPanel):
(WebInspector.TimelineSidebarPanel.prototype.showDefaultContentView):
(WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject):
(WebInspector.TimelineSidebarPanel.prototype.get contentTreeOutlineLabel):
(WebInspector.TimelineSidebarPanel.prototype.set contentTreeOutlineLabel):
(WebInspector.TimelineSidebarPanel.prototype.showTimelineOverview):
(WebInspector.TimelineSidebarPanel.prototype.showTimelineView):
(WebInspector.TimelineSidebarPanel.prototype._timelinesTreeElementSelected):
- 6:54 PM Changeset in webkit [162402] by
-
- 5 edits in trunk/Source/WebInspectorUI
Correctly track time bounds of WebInspector.Timeline and WebInspector.TimelineRecording.
The startTime and endTime were not correct when Network timeline needed to be taken into
account (due to its dynamic loading nature.) This creates a network Timeline for the purposes
of tracking the ResourceTimelineRecords and getting accurate start and end times.
Also changes the way TimelineRecord tracks the inactive portion of time, needed for later
work on the timeline graphs.
https://bugs.webkit.org/show_bug.cgi?id=126676
Reviewed by Joseph Pecoraro.
- UserInterface/ResourceTimelineRecord.js:
(WebInspector.ResourceTimelineRecord.prototype.get updatesDynamically):
(WebInspector.ResourceTimelineRecord.prototype.get usesActiveStartTime):
(WebInspector.ResourceTimelineRecord.prototype.get startTime):
(WebInspector.ResourceTimelineRecord.prototype.get activeStartTime):
(WebInspector.ResourceTimelineRecord.prototype.get endTime):
- UserInterface/Timeline.js:
(WebInspector.Timeline):
(WebInspector.Timeline.prototype.get startTime):
(WebInspector.Timeline.prototype.get endTime):
(WebInspector.Timeline.prototype.addRecord):
(WebInspector.Timeline.prototype._updateTimesIfNeeded):
(WebInspector.Timeline.prototype._recordUpdated):
- UserInterface/TimelineRecord.js:
(WebInspector.TimelineRecord.prototype.get startTime):
(WebInspector.TimelineRecord.prototype.get activeStartTime):
(WebInspector.TimelineRecord.prototype.get endTime):
(WebInspector.TimelineRecord.prototype.get inactiveDuration):
(WebInspector.TimelineRecord.prototype.get activeDuration):
(WebInspector.TimelineRecord.prototype.get updatesDynamically):
(WebInspector.TimelineRecord.prototype.get usesActiveStartTime):
- UserInterface/TimelineRecording.js:
(WebInspector.TimelineRecording.prototype._timelineTimesUpdated):
- 6:53 PM Changeset in webkit [162401] by
-
- 3 edits2 copies in trunk/Source/WebInspectorUI
Implement TimelineRecording and per-call-site timelines.
Keep track of timeline records per global timeline and per source code location.
This will be used to display them in the UI in later patches.
https://bugs.webkit.org/show_bug.cgi?id=123367
Reviewed by Joseph Pecoraro.
- UserInterface/Main.html:
- UserInterface/SourceCodeTimeline.js: Added.
(WebInspector.SourceCodeTimeline):
(WebInspector.SourceCodeTimeline.prototype.get sourceCode):
(WebInspector.SourceCodeTimeline.prototype.get sourceCodeLocation):
(WebInspector.SourceCodeTimeline.prototype.get recordType):
(WebInspector.SourceCodeTimeline.prototype.get recordEventType):
- UserInterface/Timeline.js: Added.
(WebInspector.Timeline):
(WebInspector.Timeline.prototype.get records):
(WebInspector.Timeline.prototype.addRecord):
- UserInterface/TimelineRecording.js:
(WebInspector.TimelineRecording):
(WebInspector.TimelineRecording.prototype.get timelines): Added.
(WebInspector.TimelineRecording.prototype.sourceCodeTimelinesForSourceCode): Added.
(WebInspector.TimelineRecording.prototype.addEventMarker): Implemented.
(WebInspector.TimelineRecording.prototype.addRecord): Implemented.
(WebInspector.TimelineRecording.prototype._keyForRecord): Added.
- 6:53 PM Changeset in webkit [162400] by
-
- 5 edits1 add in trunk/Source/WebInspectorUI
Add support for multiple Timeline recordings.
We also don't explicitly add ResourceTimelineRecords anymore. These will be tracked automatically in a later patch.
https://bugs.webkit.org/show_bug.cgi?id=123366
Reviewed by Joseph Pecoraro.
- UserInterface/DashboardManager.js:
(WebInspector.DashboardManager.prototype._mainResourceDidChange): Check for currentRecording.
- UserInterface/InspectorFrontendAPI.js:
(InspectorFrontendAPI.isTimelineProfilingEnabled): Check for currentRecording.
- UserInterface/Main.html:
- UserInterface/TimelineManager.js:
(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype.get currentRecording): Added.
(WebInspector.TimelineManager.prototype.startRecording): Make a new recording and push it onto the recording array.
Add the current recording to the event.
(WebInspector.TimelineManager.prototype.stopRecording): Add the current recording to the event.
(WebInspector.TimelineManager.prototype.eventRecorded.processRecord): Check for currentRecording. Add the markers
to the current recording.
(WebInspector.TimelineManager.prototype._addRecord): Add the record to the current recording.
(WebInspector.TimelineManager.prototype._startAutoRecording): Clean up. Don't add ResourceTimelineRecord. Clear recordings.
(WebInspector.TimelineManager.prototype._stopAutoRecordingSoon): Check for _currentRecording.
(WebInspector.TimelineManager.prototype._resetAutoRecordingDeadTimeTimeout): Ditto.
(WebInspector.TimelineManager.prototype._mainResourceDidChange): Don't add ResourceTimelineRecord anymore.
(WebInspector.TimelineManager.prototype._resourceWasAdded): Removed.
- UserInterface/TimelineRecording.js: Added.
(WebInspector.TimelineRecording): Added.
(WebInspector.TimelineRecording.prototype.addEventMarker): Added.
(WebInspector.TimelineRecording.prototype.addRecord): Added.
- 6:53 PM Changeset in webkit [162399] by
-
- 5 edits in trunk/Source/WebInspectorUI
Track callFrames and sourceCodeLocation per TimelineRecord.
https://bugs.webkit.org/show_bug.cgi?id=123359
Reviewed by Joseph Pecoraro.
- UserInterface/LayoutTimelineRecord.js:
(WebInspector.LayoutTimelineRecord): Pass callFrames and sourceCodeLocation to superclass.
- UserInterface/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord): Pass callFrames and sourceCodeLocation to superclass.
- UserInterface/TimelineManager.js:
(WebInspector.TimelineManager.prototype.eventRecorded.processRecord): Add "Payload" suffix to better track what is a protocol object.
Pass the callFrames and sourceCodeLocation to all the new TimelineRecords.
(WebInspector.TimelineManager.prototype.eventRecorded): Add "Payload" suffix.
- UserInterface/TimelineRecord.js:
(WebInspector.TimelineRecord):
(WebInspector.TimelineRecord.prototype.get callFrames): Added.
(WebInspector.TimelineRecord.prototype.get initiatorCallFrame): Added.
(WebInspector.TimelineRecord.prototype.get sourceCodeLocation): Added.
- 6:53 PM Changeset in webkit [162398] by
-
- 4 edits in trunk/Source/WebInspectorUI
Change how the load and content ready event timestamps are tracked.
https://bugs.webkit.org/show_bug.cgi?id=123356
Reviewed by Joseph Pecoraro.
- UserInterface/DashboardManager.js:
(WebInspector.DashboardManager.prototype._updateTime): Use the timestamps on the main frame.
- UserInterface/Frame.js:
(WebInspector.Frame):
(WebInspector.Frame.prototype.get domContentReadyEventTimestamp): Added.
(WebInspector.Frame.prototype.get loadEventTimestamp): Added.
(WebInspector.Frame.prototype.markDOMContentReadyEvent): Added.
(WebInspector.Frame.prototype.markLoadEvent): Added.
- UserInterface/TimelineManager.js:
(WebInspector.TimelineManager.prototype.eventRecorded.processRecord): Use markLoadEvent and markDOMContentReadyEvent.
Do it for all frames, not just the main frame.
(WebInspector.TimelineManager.prototype.pageDidLoad): Call markLoadEvent on the Frame.
- 6:53 PM Changeset in webkit [162397] by
-
- 7 edits2 moves39 deletes in trunk/Source/WebInspectorUI
Remove a lot of the current Timelines code to make room for a new implementation.
https://bugs.webkit.org/show_bug.cgi?id=123368
Reviewed by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/ContentView.js:
(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):
- UserInterface/DashboardView.js:
(WebInspector.DashboardView.prototype._networkItemWasClicked):
- UserInterface/InspectorFrontendAPI.js:
(InspectorFrontendAPI.setTimelineProfilingEnabled):
(InspectorFrontendAPI.stopProfilingJavaScript):
- UserInterface/InstrumentSidebarPanel.js: Removed.
- UserInterface/Main.html:
- UserInterface/Main.js:
(WebInspector.contentLoaded):
(WebInspector.sidebarPanelForRepresentedObject):
(WebInspector.openURL):
- UserInterface/Object.js:
(WebInspector.Object.addEventListener):
- UserInterface/TimelineManager.js:
(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype.startRecording):
(WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
(WebInspector.TimelineManager.prototype.eventRecorded):
(WebInspector.TimelineManager.prototype.objectForCookie):
(WebInspector.TimelineManager.prototype._addRecord):
- UserInterface/TimelinesObject.js: Removed.
- UserInterface/TimelineOverview.css: Removed.
- UserInterface/TimelineOverview.js: Removed.
- UserInterface/TimelineSidebarPanel.css: Added.
- UserInterface/TimelineSidebarPanel.js: Added.
(WebInspector.TimelineSidebarPanel):
- UserInterface/TimelinesContentView.css: Removed.
- UserInterface/TimelinesContentView.js: Removed.
- 6:25 PM Changeset in webkit [162396] by
-
- 4 edits in trunk/Source/WebCore
Remove an unused PageGroup function
https://bugs.webkit.org/show_bug.cgi?id=127327
Reviewed by Andreas Kling.
- WebCore.exp.in:
- page/PageGroup.cpp:
- page/PageGroup.h:
- 5:51 PM Changeset in webkit [162395] by
-
- 7 edits in trunk/Source/WebCore
Move user style sheet handling to UserContentController
https://bugs.webkit.org/show_bug.cgi?id=127322
<rdar://problem/15861296>
Reviewed by Andreas Kling.
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::updateInjectedStyleSheetCache):
- page/PageGroup.cpp:
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
(WebCore::PageGroup::removeAllUserContent):
- page/PageGroup.h:
- page/UserContentController.cpp:
(WebCore::UserContentController::addUserStyleSheet):
(WebCore::UserContentController::removeUserStyleSheet):
(WebCore::UserContentController::removeUserStyleSheets):
(WebCore::UserContentController::removeAllUserContent):
(WebCore::UserContentController::invalidateInjectedStyleSheetCacheInAllFrames):
- page/UserContentController.h:
(WebCore::UserContentController::userStyleSheets):
- 5:31 PM Changeset in webkit [162394] by
-
- 21 edits in trunk/Source/WebCore
Add a nicer way to iterate over all the attributes of an element
https://bugs.webkit.org/show_bug.cgi?id=127266
Reviewed by Geoffrey Garen.
When using Element::attributeAt() in a loop, the compiler had to generate two kinds of
accessor:
-If the element data is unique, the length and data comes from the attribute Vector.
-If the element data is shared, the data comes from the tail of elementData itself.
The choice was done for every access, which caused the assembly to be a little
hard to follow.
This patch unify the data access by doing everything as a array pointer with offset (getting
that data from Vector when necessary).
To make it easier to do the right thing, a new iterator was added so that range-based loops
can replace all the faulty cases.
- css/SelectorChecker.cpp:
(WebCore::anyAttributeMatches):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::checkExactAttribute):
- dom/DatasetDOMStringMap.cpp:
(WebCore::DatasetDOMStringMap::getNames):
(WebCore::DatasetDOMStringMap::item):
(WebCore::DatasetDOMStringMap::contains):
- dom/Element.cpp:
(WebCore::Element::normalizeAttributes):
(WebCore::Element::detachAllAttrNodesFromElement):
(WebCore::Element::cloneAttributesFromElement):
- dom/Element.h:
(WebCore::Element::attributesIterator):
- dom/ElementData.cpp:
(WebCore::ElementData::isEquivalent):
(WebCore::ElementData::findAttributeIndexByNameSlowCase):
- dom/ElementData.h:
(WebCore::AttributeConstIterator::AttributeConstIterator):
(WebCore::AttributeConstIterator::operator*):
(WebCore::AttributeConstIterator::operator->):
(WebCore::AttributeConstIterator::operator++):
(WebCore::AttributeConstIterator::operator==):
(WebCore::AttributeConstIterator::operator!=):
(WebCore::AttributeIteratorAccessor::AttributeIteratorAccessor):
(WebCore::AttributeIteratorAccessor::begin):
(WebCore::AttributeIteratorAccessor::end):
(WebCore::ElementData::attributesIterator):
- dom/Node.cpp:
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupNamespaceURI):
(WebCore::Node::lookupNamespacePrefix):
(WebCore::Node::compareDocumentPosition):
- dom/StyledElement.cpp:
(WebCore::StyledElement::makePresentationAttributeCacheKey):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendElement):
- editing/markup.cpp:
(WebCore::completeURLs):
(WebCore::StyledMarkupAccumulator::appendElement):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parametersForPlugin):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parametersForPlugin):
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::innerPatchNode):
(WebCore::DOMPatchSupport::createDigest):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
- inspector/InspectorNodeFinder.cpp:
(WebCore::InspectorNodeFinder::matchesElement):
- page/PageSerializer.cpp:
(WebCore::isCharsetSpecifyingNode):
- xml/XPathNodeSet.cpp:
(WebCore::XPath::NodeSet::traversalSort):
- xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
- 5:10 PM Changeset in webkit [162393] by
-
- 7 edits in trunk/Source/JavaScriptCore
JSC Parser: Shrink BindingNode.
<https://webkit.org/b/127253>
The "divot" and "end" source locations are always identical for
BindingNodes, so store only "start" and "end" instead.
1.19 MB progression on Membuster3.
Reviewed by Geoff Garen.
- bytecompiler/NodesCodegen.cpp:
(JSC::BindingNode::bindValue):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createBindingLocation):
- parser/NodeConstructors.h:
(JSC::BindingNode::create):
(JSC::BindingNode::BindingNode):
- parser/Nodes.h:
(JSC::BindingNode::divotStart):
(JSC::BindingNode::divotEnd):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::createBindingPattern):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::operatorStackPop):
- 5:04 PM Changeset in webkit [162392] by
-
- 2 edits in trunk/LayoutTests
platform/mac/accessibility/iframe-aria-hidden.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=127323
- platform/mac-wk2/TestExpectations: Marked as such.
- 4:51 PM Changeset in webkit [162391] by
-
- 2 edits in trunk/Tools
Force float division when calculating CSS px value.
Reviewed by Simon Fraser.
Note that in Python 3, this is the default behavior.
- lldb/lldb_webkit.py:
(WebCoreLayoutUnitProvider.to_string):
- 4:46 PM Changeset in webkit [162390] by
-
- 5 edits in trunk/Source/JavaScriptCore
op_captured_mov and op_new_captured_func in UnlinkedCodeBlocks should use the IdentifierMap instead of the strings directly
https://bugs.webkit.org/show_bug.cgi?id=127311
<rdar://problem/15853958>
Reviewed by Andreas Kling.
This makes UnlinkedCodeBlocks use 32-bit instruction streams again.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedInstruction::UnlinkedInstruction):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::emitInitLazyRegister):
(JSC::BytecodeGenerator::createArgumentsIfNecessary):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::watchableVariable):
(JSC::BytecodeGenerator::hasWatchableVariable):
- 4:45 PM Changeset in webkit [162389] by
-
- 9 edits1 delete in trunk/Source/JavaScriptCore
Removing CodeBlock::opDebugBytecodeOffsetForLineAndColumn() and friends.
<https://webkit.org/b/127321>
Reviewed by Geoffrey Garen.
We're changing plans and will be going with CodeBlock level breakpoints
instead of bytecode level breakpoints. As a result, we no longer need
the services of CodeBlock::opDebugBytecodeOffsetForLineAndColumn() (and
friends). This patch will remove that unused code.
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
- bytecode/CodeBlock.h:
- bytecode/LineColumnInfo.h: Removed.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::dumpExpressionRangeInfo):
- bytecode/UnlinkedCodeBlock.h:
- 4:41 PM Changeset in webkit [162388] by
-
- 5 edits1 add in branches/jsCStack/Source/JavaScriptCore
ArithSqrt in FTL
https://bugs.webkit.org/show_bug.cgi?id=127320
Patch by Matthew Mirman <mmirman@apple.com> on 2014-01-20
Reviewed by Filip Pizlo.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode): Added
(JSC::FTL::LowerDFGToLLVM::compileArithSin): Simplified implementation
(JSC::FTL::LowerDFGToLLVM::compileArithCos): Simplified implementation
(JSC::FTL::LowerDFGToLLVM::compileArithSqrt): Added
- ftl/FTLOutput.h:
(JSC::FTL::Output::doubleSqrt): Added
- tests/stress/ftl-arithsqrt.js: Added.
(foo):
- 4:37 PM Changeset in webkit [162387] by
-
- 2 edits in trunk/LayoutTests
Fix an erroneous paste in TestExpectations.
- platform/mac-wk2/TestExpectations:
- 4:27 PM Changeset in webkit [162386] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Amount of scrolling is different from movement of touch when device pixel ratio is not 1.
https://bugs.webkit.org/show_bug.cgi?id=127268
Reviewed by Gyuyoung Kim.
Amount of scrolling should be same with movement of touch even though
device pixel ratio is not 1, so apply device pixel ratio to the new
position of scrollBy().
- UIProcess/API/efl/EwkView.cpp:
(EwkView::scrollBy):
- 4:11 PM Changeset in webkit [162385] by
-
- 4 edits in trunk/Source/WebCore
Do refactor in collectGradientAttributes() and renderStyleForLengthResolve()
https://bugs.webkit.org/show_bug.cgi?id=126869
Reviewed by Dirk Schulze.
Some SVG functions have done a first iteration by using a boolean flag. This is
one of poor implementations. This patch fix it by extracting a logic into a new method.
Additionally it would be good to use do-while() loop instead of using while() in
renderStyleForLengthResolving() because a first condition is always true.
Merge r165358 from blink.
- svg/SVGLengthContext.cpp:
(WebCore::renderStyleForLengthResolving):
- svg/SVGLinearGradientElement.cpp:
(WebCore::setGradientAttributes):
(WebCore::SVGLinearGradientElement::collectGradientAttributes):
- svg/SVGRadialGradientElement.cpp:
(WebCore::setGradientAttributes):
(WebCore::SVGRadialGradientElement::collectGradientAttributes):
- 4:08 PM Changeset in webkit [162384] by
-
- 6 edits in trunk/Source/WebCore
UserContentController should keep track of user scripts
https://bugs.webkit.org/show_bug.cgi?id=127317
<rdar://problem/15861296>
Reviewed by Andreas Kling.
Move handling of user scripts from PageGroup to UserContentController.
- page/Frame.cpp:
(WebCore::Frame::injectUserScripts):
- page/PageGroup.cpp:
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeAllUserContent):
- page/PageGroup.h:
- page/UserContentController.cpp:
(WebCore::UserContentController::addUserScript):
(WebCore::UserContentController::removeUserScript):
(WebCore::UserContentController::removeUserScripts):
(WebCore::UserContentController::removeAllUserContent):
- page/UserContentController.h:
(WebCore::UserContentController::userScripts):
- 3:42 PM Changeset in webkit [162383] by
-
- 2 edits in trunk/LayoutTests
svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=127316
- platform/mac-wk2/TestExpectations: Marked as such.
- 3:39 PM Changeset in webkit [162382] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Setting m_pageScaleFactor directly in WebPageProxy::scalePage
https://bugs.webkit.org/show_bug.cgi?id=127090
Reviewed by Simon Fraser.
When the client side sets the scale factor, the UIProcess will send the message to WebProcess and only after
WebPageProxy::pageScaleFactorDidChange is called the desired scale factor is returned correctly by
WebPageProxy::pageScaleFactor.
This will avoid the client side retrieve a wrong scale factor while UIProcess and WebProcess gets synchronized.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::scalePage):
- 3:38 PM Changeset in webkit [162381] by
-
- 4 edits1 delete in trunk/LayoutTests
Subpixel layout: 100000px overflows while calculating layout positions.
https://bugs.webkit.org/show_bug.cgi?id=126896
Reviewed by Simon Fraser.
Test case is adjusted to subpixel layout.
- fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:
- platform/efl/TestExpectations:
- platform/gtk/fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction-expected.txt: Removed.
- platform/mac/TestExpectations:
- 3:21 PM Changeset in webkit [162380] by
-
- 7 edits in trunk/Source/WebCore
Give each page a UserContentController
https://bugs.webkit.org/show_bug.cgi?id=127315
Reviewed by Andreas Kling.
Add a UserContentController object to PageGroup and have the page group set it on any
pages that are added to the page group.
This is another step towards moving handling of user content away from PageGroup and make it
possible for each page to have different user content.
- page/Page.cpp:
(WebCore::Page::~Page):
(WebCore::Page::setUserContentController):
- page/Page.h:
(WebCore::Page::userContentController):
- page/PageGroup.cpp:
(WebCore::PageGroup::PageGroup):
(WebCore::PageGroup::addPage):
(WebCore::PageGroup::removePage):
- page/PageGroup.h:
- page/UserContentController.cpp:
(WebCore::UserContentController::addPage):
(WebCore::UserContentController::removePage):
- page/UserContentController.h:
- 2:41 PM Changeset in webkit [162379] by
-
- 16 edits2 adds in trunk/Source
Add AVKit fullscreen video interface.
https://bugs.webkit.org/show_bug.cgi?id=126818
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-01-20
Reviewed by Eric Carlson.
Source/WebCore:
No new tests, no observable change in functionality.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- html/HTMLMediaElement.h:
Add ability for fullscreen to borrow the AVPlayerLayer.
- page/Settings.cpp:
- page/Settings.h:
(WebCore::Settings::setMediaPlaybackFullscreenAVKit):
(WebCore::Settings::mediaPlaybackFullscreenAVKit):
Add a disabled setting.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::supportsFullscreen):
Enabled fullscreen for iOS.
- platform/ios/WebVideoFullscreenControllerAVKit.h: Added.
- platform/ios/WebVideoFullscreenControllerAVKit.mm: Added.
(-[WebAVPlayerController init]):
(-[WebAVPlayerController dealloc]):
(-[WebAVPlayerController forwardingTargetForSelector:]):
(-[WebAVPlayerController shouldDismissForDone]):
(-[WebAVPlayerController play:]):
(-[WebAVPlayerController pause:]):
(-[WebAVPlayerController togglePlayback:]):
(-[WebAVPlayerController isPlaying]):
(-[WebAVPlayerController setPlaying:]):
(+[WebAVPlayerController keyPathsForValuesAffectingPlaying]):
(-[WebAVPlayerController seekToTime:]):
(-[WebAVPlayerController updateTimingWithCurrentTime:]):
(-[WebAVPlayerController effectiveRate]):
(-[WebAVPlayerController setMediaElement:]):
(-[WebAVPlayerController handleEvent:]):
(-[WebVideoFullscreenController init]):
(-[WebVideoFullscreenController dealloc]):
(-[WebVideoFullscreenController setMediaElement:]):
(-[WebVideoFullscreenController mediaElement]):
(-[WebVideoFullscreenController enterFullscreen:]):
(-[WebVideoFullscreenController exitFullscreen]):
Add WebAVPlayerController for HTMLMediaElememt to interface with AVPlayerViewController.
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::supportsFullscreenForNode):
Enable *FullscreenForNode for HTMLMediaElement for iOS
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences mediaPlaybackFullscreenAVKit]):
(-[WebPreferences setMediaPlaybackFullscreenAVKit:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
(-[WebView _enterFullscreenForNode:WebCore::]):
- WebView/WebViewInternal.h:
Add a disabled pref mediaPlaybackFullscreenAVKit.
Use WebVideoFullscreenControllerAVKit on iOS
- 2:33 PM Changeset in webkit [162378] by
-
- 2 edits in trunk/LayoutTests
svg/filters/feComponentTransfer-style-crash.xhtml is flaky
https://bugs.webkit.org/show_bug.cgi?id=127310
- platform/mac/TestExpectations: Marked it as such.
- 2:17 PM Changeset in webkit [162377] by
-
- 2 edits in trunk/Source/JavaScriptCore
CodeBlockSet::traceMarked doesn't need to visit the ownerExecutable
https://bugs.webkit.org/show_bug.cgi?id=127301
Reviewed by Oliver Hunt.
We used to just call CodeBlock::visitAggregate, but now we call visitChildren
on the ownerExecutable, which is unnecessary.
- heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::traceMarked):
- 2:05 PM Changeset in webkit [162376] by
-
- 8 edits in trunk/Source/WebCore
Replace uses of std::forward<T>(), std::unique_ptr<T>::clear() that landed in r162368
https://bugs.webkit.org/show_bug.cgi?id=127306
Reviewed by Darin Adler.
Address the post-landing reviews of the r162368 commit that moved WebAudio source code to using std::unique_ptr.
std::move() should be used instead of std::forward<T>() in HRTFKernel::create().
Instead of calling std::unique_ptr<T>::reset(), nullptr should be assigned to that smart pointer to reset it.
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::uninitialize):
- Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::uninitialize):
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::setFormat):
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::uninitialize):
- platform/audio/AudioChannel.h:
(WebCore::AudioChannel::set):
- platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader):
- platform/audio/HRTFKernel.h:
(WebCore::HRTFKernel::create):
- 1:53 PM Changeset in webkit [162375] by
-
- 5 edits1 add in branches/jsCStack/Source/JavaScriptCore
ArithCos in FTL
https://bugs.webkit.org/show_bug.cgi?id=127136
Patch by Matthew Mirman <mmirman@apple.com> on 2014-01-20
Reviewed by Filip Pizlo.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithCos):
- ftl/FTLOutput.h:
(JSC::FTL::Output::doubleCos):
- tests/stress/ftl-arithcos.js: Added.
(foo):
- 1:36 PM Changeset in webkit [162374] by
-
- 39 edits in trunk/Source/WebCore
Modernize WebCore/inspector with nullptr
https://bugs.webkit.org/show_bug.cgi?id=127303
Reviewed by Anders Carlsson.
Ran clang-modernize -use-nullptr over WebCore/inspector.
- inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
- inspector/ConsoleMessage.h:
- inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::findMagicComment):
- inspector/DOMEditor.cpp:
(WebCore::DOMEditor::SetOuterHTMLAction::SetOuterHTMLAction):
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchDocument):
(WebCore::DOMPatchSupport::patchNode):
(WebCore::DOMPatchSupport::diff):
(WebCore::DOMPatchSupport::innerPatchChildren):
- inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorApplicationCacheAgent::assertFrameWithDocumentLoader):
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::disable):
(WebCore::InspectorCanvasAgent::notifyRenderingContextWasWrapped):
(WebCore::InspectorCanvasAgent::frameNavigated):
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::didFinishXHRLoading):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::inspectedPageDestroyed):
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::disable):
(WebCore::InspectorDOMDebuggerAgent::discardAgent):
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::findStorageArea):
- inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::findByFileName):
(WebCore::InspectorDatabaseAgent::databaseForId):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::addMessageToConsole):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::didContinue):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):
- inspector/InspectorFrontendHost.cpp:
(WebCore::FrontendMenuProvider::disconnect):
(WebCore::InspectorFrontendHost::InspectorFrontendHost):
(WebCore::InspectorFrontendHost::disconnectClient):
- inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::~InspectorHeapProfilerAgent):
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::assertDocument):
(WebCore::assertIDBFactory):
(WebCore::InspectorIndexedDBAgent::requestData):
- inspector/InspectorInstrumentation.cpp:
(WebCore::frameForScriptExecutionContext):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseButCanceledImpl):
(WebCore::InspectorInstrumentation::consoleAgentEnabled):
(WebCore::InspectorInstrumentation::unregisterInstrumentingAgents):
(WebCore::InspectorInstrumentation::retrieveTimelineAgent):
(WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
(WebCore::InspectorInstrumentation::instrumentingAgentsForWorkerGlobalScope):
(WebCore::InspectorInstrumentation::instrumentingAgentsForNonDocumentContext):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::instrumentingAgentsForContext):
(WebCore::InspectorInstrumentation::instrumentingAgentsForFrame):
(WebCore::InspectorInstrumentation::instrumentingAgentsForDocument):
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::disable):
- inspector/InspectorNodeFinder.cpp:
(WebCore::InspectorNodeFinder::searchUsingXPath):
- inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForElementInfo):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResourceContent):
(WebCore::InspectorPageAgent::sharedBufferContent):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::frameForId):
(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin):
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::~InspectorProfilerAgent):
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForResourceResponse):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::disable):
- inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
- inspector/InspectorStyleSheet.cpp:
(ParsedStyleSheet::ruleSourceDataAt):
(WebCore::buildSourceRangeObject):
(WebCore::asCSSRuleList):
(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::populateAllProperties):
(WebCore::InspectorStyle::extractSourceData):
(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::ruleForId):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::styleForId):
(WebCore::InspectorStyleSheet::inspectorStyleForId):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
- inspector/InspectorStyleSheet.h:
(WebCore::InspectorCSSId::asProtocolValue):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::willComposite):
(WebCore::InspectorTimelineAgent::page):
- inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
- inspector/InstrumentingAgents.cpp:
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::reset):
- inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::xhrReplayData):
(WebCore::NetworkResourcesData::removeCachedResource):
(WebCore::NetworkResourcesData::resourceDataForRequestId):
- inspector/PageConsoleAgent.cpp:
(WebCore::PageConsoleAgent::~PageConsoleAgent):
- inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::disable):
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::~PageRuntimeAgent):
(WebCore::PageRuntimeAgent::didCreateMainWorldContext):
(WebCore::PageRuntimeAgent::reportExecutionContextCreation):
- inspector/ScriptArguments.cpp:
(WebCore::ScriptArguments::globalState):
- inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::~WorkerRuntimeAgent):
- 1:33 PM Changeset in webkit [162373] by
-
- 7 edits1 add in trunk/Tools
build.webkit.org/dashboard should display information about patches in EWS
https://bugs.webkit.org/show_bug.cgi?id=127006
Reviewed by Ryosuke Niwa.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Bugzilla.js: Added.
(Bugzilla.prototype.detailsURLForAttachment):
Added a class for Bugzilla. So far, the only thing it can do is build patch URLs,
which is needed when one wants to do something with a patch EWS is stuck on.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
Create a Bugzilla instance.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
(EWS.prototype.jsonQueueLengthURL):
(EWS.prototype.jsonQueueStatusURL):
Build JSON ULRs here, not in EWSQueue, as this is how other classes are structured.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
(EWSQueue.prototype.get statusPageURL): Changed to use a URL provided by EWS instead
of second guessing.
(EWSQueue.prototype.get chartsPageURL): Added.
(EWSQueue.prototype.get loadedDetailedStatus): Tells whether we currently have
additional data already loaded (it's reset with every update).
(EWSQueue.prototype.get patches): Get patch queue.
(EWSQueue.prototype.get bots): Get bots.
(EWSQueue.prototype.update): Changed to use a specialized cheaper URL.
(EWSQueue.prototype.loadDetailedStatus): Load and transform detailed status JSON.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
(EWSQueueView.prototype.update.appendQueue): Add a popover is there are any patches
in the queue.
(EWSQueueView.prototype.addLinkToRow): A helper to build the popover.
(EWSQueueView.prototype.addTextToRow): Ditto.
(EWSQueueView.prototype._addQueueHeadingToPopover): Ditto.
(EWSQueueView.prototype._addBotsHeadingToPopover): Ditto.
(EWSQueueView.prototype._addDividerToPopover): Ditto.
(EWSQueueView.prototype._timeIntervalString): A helper to format a timestamp into a
relative string.
(EWSQueueView.prototype._popoverContentForEWSQueue): Build the popover.
(EWSQueueView.prototype._presentPopoverForEWSQueue): Start loading data, and present
it when done.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
Added rules for EWS popover. Removed a duplicate rule for build-logs-popover.
Changed a few difficult to read padding styles to padding-left.
- 1:29 PM Changeset in webkit [162372] by
-
- 6 edits2 adds in trunk/Source/WebCore
Add empty UserContentController class
https://bugs.webkit.org/show_bug.cgi?id=127300
<rdar://problem/15861296>
Reviewed by Dan Bernstein.
This is the first step towards moving handling of user scripts and style sheets from
the page group to a separate objects and ultimately make them be settable per page instead of per page group.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- page/UserContentController.cpp: Added.
(WebCore::UserContentController::create):
(WebCore::UserContentController::UserContentController):
(WebCore::UserContentController::~UserContentController):
- page/UserContentController.h: Added.
- 1:18 PM Changeset in webkit [162371] by
-
- 2 edits in trunk/Tools
Fix webkitpy tests.
- Scripts/webkitpy/common/net/web_mock.py: (MockBrowser.set_handle_robots):
Added a mock implementation, as we now call this function.
- 1:17 PM Changeset in webkit [162370] by
-
- 4 edits in trunk/Source/WebKit2
[GTK][WK2] Move the rest of GTK's WorkQueue implementation to std::function
https://bugs.webkit.org/show_bug.cgi?id=127273
Reviewed by Anders Carlsson.
Move to using std::function and move semantics in WorkQueue::registerSocketEventHandler
and WorkQueue::SocketEventSource.
- Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::open):
- Platform/WorkQueue.h:
- Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::SocketEventSource::SocketEventSource):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::dispatchOnSource): Use std::move instead of std::forward<T>.
(WorkQueue::dispatch): Ditto.
(WorkQueue::dispatchAfter): Ditto.
- 1:15 PM Changeset in webkit [162369] by
-
- 37 edits in trunk/Source/WebCore
Run clang-modernize and let it add a bunch of missing overrides in WebCore/inspector
https://bugs.webkit.org/show_bug.cgi?id=127206
Reviewed by Anders Carlsson.
Let clang-modernize add overrides.
- inspector/DOMEditor.cpp:
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorCSSAgent.h:
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMStorageAgent.h:
- inspector/InspectorDatabaseAgent.cpp:
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::getHeapSnapshot):
(WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):
- inspector/InspectorHeapProfilerAgent.h:
- inspector/InspectorHistory.cpp:
- inspector/InspectorIndexedDBAgent.cpp:
- inspector/InspectorIndexedDBAgent.h:
- inspector/InspectorInputAgent.h:
- inspector/InspectorLayerTreeAgent.h:
- inspector/InspectorMemoryAgent.h:
- inspector/InspectorPageAgent.h:
- inspector/InspectorProfilerAgent.cpp:
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorResourceAgent.h:
- inspector/InspectorRuntimeAgent.h:
- inspector/InspectorStyleSheet.h:
- inspector/InspectorTimelineAgent.h:
- inspector/InspectorWorkerAgent.cpp:
- inspector/InspectorWorkerAgent.h:
- inspector/PageConsoleAgent.h:
- inspector/PageDebuggerAgent.h:
- inspector/PageRuntimeAgent.h:
- inspector/WorkerConsoleAgent.h:
- inspector/WorkerDebuggerAgent.cpp:
- inspector/WorkerInspectorController.cpp:
- inspector/WorkerRuntimeAgent.h:
- 12:36 PM Changeset in webkit [162368] by
-
- 84 edits in trunk/Source/WebCore
Move WebAudio source code to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127274
Reviewed by Eric Carlson.
Move from using OwnPtr and PassOwnPtr to using std::unique_ptr and move semantics
in the WebAudio module and the WebAudio code in the platform layer.
- Modules/webaudio/AsyncAudioDecoder.cpp:
- Modules/webaudio/AsyncAudioDecoder.h:
- Modules/webaudio/AudioBasicInspectorNode.cpp:
(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):
- Modules/webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):
- Modules/webaudio/AudioBasicProcessorNode.h:
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
- Modules/webaudio/AudioContext.cpp:
- Modules/webaudio/AudioContext.h:
- Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::AudioDestinationNode):
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::addInput):
(WebCore::AudioNode::addOutput):
(WebCore::AudioNode::checkNumberOfChannelsForInput):
- Modules/webaudio/AudioNode.h:
- Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::BiquadFilterNode):
- Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::createKernel):
(WebCore::BiquadProcessor::getFrequencyResponse):
- Modules/webaudio/BiquadProcessor.h:
- Modules/webaudio/ChannelMergerNode.cpp:
(WebCore::ChannelMergerNode::ChannelMergerNode):
- Modules/webaudio/ChannelSplitterNode.cpp:
(WebCore::ChannelSplitterNode::ChannelSplitterNode):
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::ConvolverNode):
(WebCore::ConvolverNode::uninitialize):
(WebCore::ConvolverNode::setBuffer):
- Modules/webaudio/ConvolverNode.h:
- Modules/webaudio/DefaultAudioDestinationNode.h:
- Modules/webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):
- Modules/webaudio/DelayProcessor.cpp:
(WebCore::DelayProcessor::createKernel):
- Modules/webaudio/DelayProcessor.h:
- Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::initialize):
(WebCore::DynamicsCompressorNode::uninitialize):
- Modules/webaudio/DynamicsCompressorNode.h:
- Modules/webaudio/GainNode.cpp:
(WebCore::GainNode::GainNode):
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::setFormat):
- Modules/webaudio/MediaElementAudioSourceNode.h:
- Modules/webaudio/MediaStreamAudioDestinationNode.h:
- Modules/webaudio/MediaStreamAudioSource.cpp:
- Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
- Modules/webaudio/MediaStreamAudioSourceNode.h:
- Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::OscillatorNode):
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::uninitialize):
(WebCore::PannerNode::setPanningModel):
- Modules/webaudio/PannerNode.h:
- Modules/webaudio/PeriodicWave.cpp:
(WebCore::PeriodicWave::createBandLimitedTables):
- Modules/webaudio/PeriodicWave.h:
- Modules/webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::RealtimeAnalyser):
(WebCore::RealtimeAnalyser::setFftSize):
- Modules/webaudio/RealtimeAnalyser.h:
- Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::ScriptProcessorNode):
- Modules/webaudio/WaveShaperDSPKernel.cpp:
(WebCore::WaveShaperDSPKernel::lazyInitializeOversampling):
- Modules/webaudio/WaveShaperDSPKernel.h:
- Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::WaveShaperNode):
- Modules/webaudio/WaveShaperProcessor.cpp:
(WebCore::WaveShaperProcessor::createKernel):
- Modules/webaudio/WaveShaperProcessor.h:
- platform/audio/AudioBus.cpp:
(WebCore::AudioBus::AudioBus):
(WebCore::AudioBus::copyWithGainFrom):
- platform/audio/AudioBus.h:
- platform/audio/AudioChannel.cpp:
- platform/audio/AudioChannel.h:
(WebCore::AudioChannel::AudioChannel):
(WebCore::AudioChannel::set):
- platform/audio/AudioDSPKernelProcessor.h:
- platform/audio/AudioDestination.h:
- platform/audio/AudioResampler.cpp:
(WebCore::AudioResampler::AudioResampler):
(WebCore::AudioResampler::configureChannels):
- platform/audio/AudioResampler.h:
- platform/audio/AudioSession.h:
- platform/audio/DynamicsCompressor.cpp:
(WebCore::DynamicsCompressor::setNumberOfChannels):
- platform/audio/DynamicsCompressor.h:
- platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::setNumberOfChannels):
- platform/audio/DynamicsCompressorKernel.h:
- platform/audio/FFTFrame.cpp:
(WebCore::FFTFrame::createInterpolatedFrame):
- platform/audio/FFTFrame.h:
- platform/audio/HRTFDatabase.cpp:
(WebCore::HRTFDatabase::HRTFDatabase):
- platform/audio/HRTFDatabase.h:
- platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader):
(WebCore::HRTFDatabaseLoader::load):
- platform/audio/HRTFDatabaseLoader.h:
- platform/audio/HRTFElevation.cpp:
(WebCore::HRTFElevation::createForSubject):
(WebCore::HRTFElevation::createByInterpolatingSlices):
- platform/audio/HRTFElevation.h:
(WebCore::HRTFElevation::HRTFElevation):
- platform/audio/HRTFKernel.cpp:
(WebCore::HRTFKernel::HRTFKernel):
(WebCore::HRTFKernel::createImpulseResponse):
(WebCore::HRTFKernel::createInterpolatedKernel):
- platform/audio/HRTFKernel.h:
(WebCore::HRTFKernel::create):
(WebCore::HRTFKernel::HRTFKernel):
- platform/audio/MultiChannelResampler.cpp:
(WebCore::MultiChannelResampler::MultiChannelResampler):
- platform/audio/MultiChannelResampler.h:
- platform/audio/Panner.cpp:
(WebCore::Panner::create):
- platform/audio/Panner.h:
- platform/audio/Reverb.cpp:
(WebCore::Reverb::initialize):
- platform/audio/Reverb.h:
- platform/audio/ReverbConvolver.h:
- platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::ReverbConvolverStage):
- platform/audio/ReverbConvolverStage.h:
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestination::create):
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
- platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestination::create):
- platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::AudioSession):
- platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::create):
- platform/audio/mac/AudioDestinationMac.h:
- platform/audio/mac/AudioSessionMac.cpp:
(WebCore::AudioSession::AudioSession):
- 12:26 PM Changeset in webkit [162367] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix build.
- heap/BlockAllocator.h:
- 11:55 AM Changeset in webkit [162366] by
-
- 10 edits12 adds in trunk
Region based multicol: support explicit column breaks
https://bugs.webkit.org/show_bug.cgi?id=123993
Patch by Morten Stenshorne <mstensho@opera.com> on 2014-01-20
Reviewed by David Hyatt.
Source/WebCore:
Merely supporting insertion of explicit (forced) column breaks in
the region based multicol implementation is really simple: just
hook up with what the CSS regions code is already doing.
However, there is one complication: column balancing. In order to
balance columns as nicely as possible when there are explicit
breaks, we need to figure out between which explicit breaks the
implicit breaks will occur (if there's room for any at all).
Tests: fast/multicol/newmulticol/break-after.html
fast/multicol/newmulticol/break-before.html
fast/multicol/newmulticol/breaks-2-columns-3-no-balancing.html
fast/multicol/newmulticol/breaks-2-columns-3.html
fast/multicol/newmulticol/breaks-3-columns-3.html
fast/multicol/newmulticol/fixed-height-fill-balance-2.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::applyBeforeBreak):
(WebCore::RenderBlockFlow::applyAfterBreak): Use the already
existing region breaking code when inserting breaks in region
based multicol.
- rendering/RenderFlowThread.h:
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::relayoutForPagination): Avoid
re-balancing if the multicol's contents were not laid out. Apart
from being good for performance, this is now necessary because of
how explicit breaks are implemented.
(WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
Detect if the contents are going to be laid out, or skipped, so
that we can tell if we need to (re-)balance the columns
afterwards.
- rendering/RenderMultiColumnBlock.h:
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::addForcedRegionBreak):
Locate the appropriate multi-column set and call its
addForcedBreak().
- rendering/RenderMultiColumnFlowThread.h:
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::findRunWithTallestColumns):
(WebCore::RenderMultiColumnSet::distributeImplicitBreaks): Figure
out how many implicit breaks each single "content run" should
contain. The taller the content run, the more implicit breaks.
(WebCore::RenderMultiColumnSet::calculateBalancedHeight): This is
now a const method that only does half of what the old
calculateBalancedHeight() did. The rest (such as actually storing
the new column height) is done by recalculateBalancedHeight().
(WebCore::RenderMultiColumnSet::clearForcedBreaks): Needs to be
called between each layout pass, to clear the list of "content
runs".
(WebCore::RenderMultiColumnSet::addForcedBreak): Only useful when
columns are to be balanced. It receives explicit (forced) breaks
and stores them as "content runs". When layout is done, we'll go
through the list of content runs, and see where implicit breaks
should be inserted (if there's room for any). The goal is to
insert implicit breaks in such a way that the final columns become
as short as possible.
(WebCore::RenderMultiColumnSet::recalculateBalancedHeight):
Calculates and sets a new balanced column height. This used to be
done directly in calculateBalancedHeight(), but that method is now
const and it now only calculates the new height and returns it.
(WebCore::RenderMultiColumnSet::prepareForLayout):
- rendering/RenderMultiColumnSet.h: Remove old data members
intended for forced breaks (they were unused), and introduce a
"content run" vector instead. A new content run is triggered by an
explicit break. This is only used when column balancing is
enabled. When not balanced, RenderMultiColumnSet doesn't need to
do anything when explicit breaks are inserted.
LayoutTests:
- fast/multicol/newmulticol/break-after-expected.html: Added.
- fast/multicol/newmulticol/break-after.html: Added.
- fast/multicol/newmulticol/break-before-expected.html: Added.
- fast/multicol/newmulticol/break-before.html: Added.
- fast/multicol/newmulticol/breaks-2-columns-3-expected.html: Added.
- fast/multicol/newmulticol/breaks-2-columns-3-no-balancing-expected.html: Added.
- fast/multicol/newmulticol/breaks-2-columns-3-no-balancing.html: Added.
- fast/multicol/newmulticol/breaks-2-columns-3.html: Added.
- fast/multicol/newmulticol/breaks-3-columns-3-expected.html: Added.
- fast/multicol/newmulticol/breaks-3-columns-3.html: Added.
- fast/multicol/newmulticol/fixed-height-fill-balance-2-expected.html: Added.
- fast/multicol/newmulticol/fixed-height-fill-balance-2.html: Added.
- 11:39 AM Changeset in webkit [162365] by
-
- 3 edits in trunk/Tools
Update style checker and tests to deal with override instead of OVERRIDE
https://bugs.webkit.org/show_bug.cgi?id=127175
Reviewed by Anders Carlsson.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_braces): Use override instead of OVERRIDE.
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_brace_at_begin_of_line): Ditto.
- 11:33 AM Changeset in webkit [162364] by
-
- 5 edits in branches/safari-537.60-branch/Source
Versioning.
- 11:32 AM Changeset in webkit [162363] by
-
- 1 copy in tags/Safari-537.60.14
New Tag.
- 11:31 AM Changeset in webkit [162362] by
-
- 3 edits in trunk/Source/JavaScriptCore
Stop using ThreadCondition in BlockAllocator
https://bugs.webkit.org/show_bug.cgi?id=126313
Reviewed by Sam Weinig.
- heap/BlockAllocator.cpp:
(JSC::BlockAllocator::~BlockAllocator):
(JSC::BlockAllocator::waitForDuration):
(JSC::BlockAllocator::blockFreeingThreadMain):
- heap/BlockAllocator.h:
(JSC::BlockAllocator::deallocate):
- 11:25 AM Changeset in webkit [162361] by
-
- 4 edits in trunk/Source/WebInspectorUI
Fix jumping to a text position when showing a resource.
https://bugs.webkit.org/show_bug.cgi?id=127271
Reviewed by Joseph Pecoraro.
- UserInterface/FrameContentView.js:
(WebInspector.FrameContentView.prototype.showSourceCode): Just use showResponse's arguments
which already does the same logic to call revealPosition.
- UserInterface/ResourceClusterContentView.js:
(WebInspector.ResourceClusterContentView.prototype.restoreFromCookie): This was the bug.
lineNumber and columnNumber need honored here. They were only honored by FrameContentView.
- UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype.showSourceCode): Use showContentViewForRepresentedObject
which also accepts a cookie and handles creating the content view for us.
- 11:23 AM Changeset in webkit [162360] by
-
- 9 edits4 adds in trunk
Allow MediaSessionManager to restrict 'preload' behavior
https://bugs.webkit.org/show_bug.cgi?id=127297
Reviewed by Jer Noble.
Source/WebCore:
Tests: media/video-restricted-no-preload-auto.html
media/video-restricted-no-preload-metadata.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): Apply restrictions to preload attribute before
passing to media engine.
(WebCore::HTMLMediaElement::loadResource): Ditto.
- html/HTMLMediaSession.cpp:
(WebCore::HTMLMediaSession::effectivePreloadForElement): New, limit preload according to restrictions.
- html/HTMLMediaSession.h:
- platform/audio/MediaSessionManager.h:
- platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::resetRestrictions): Limit preload to metadata only. Drive-by
static deviceClass initialization cleanup.
- testing/Internals.cpp:
(WebCore::Internals::setMediaSessionRestrictions): Support MetadataPreloadingNotPermitted and
AutoPreloadingNotPermitted.
LayoutTests:
- media/video-restricted-no-preload-auto-expected.txt: Added.
- media/video-restricted-no-preload-auto.html: Added.
- media/video-restricted-no-preload-metadata-expected.txt: Added.
- media/video-restricted-no-preload-metadata.html: Added.
- 10:53 AM Changeset in webkit [162359] by
-
- 3 edits in trunk/LayoutTests
Fix test expectations for css3/compositing/background-blend-mode-data-uri-svg-image.html
https://bugs.webkit.org/show_bug.cgi?id=127298
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
Reviewed by Mihnea Ovidenie.
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- 10:37 AM Changeset in webkit [162358] by
-
- 4 edits1 add in trunk/Tools
EWS should provide better information to Dashboard via JSON
https://bugs.webkit.org/show_bug.cgi?id=127265
Reviewed by Ryosuke Niwa.
- QueueStatusServer/app.yaml: Updated version.
- QueueStatusServer/main.py:
- QueueStatusServer/handlers/queuelengthjson.py:
Added a way to cheaply get only the queue length, which is all the dashboard
needs unless a popover is opened.
- QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
that we will need. Changed some field names to be more meaningful. Fixed bot listing
to understand that a bot can be reprurposed and used in a different queue.
- 10:24 AM Changeset in webkit [162357] by
-
- 3 edits in trunk/Tools
Make uploading results to EWS work despite robots.txt
https://bugs.webkit.org/show_bug.cgi?id=127296
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/net/statusserver.py: (StatusServer.init): Disable
checking robots.txt.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
Removed a comment saying that we would want to stop doing this. Not checking
robots.txt is more efficient than checking it.
- 9:27 AM Changeset in webkit [162356] by
-
- 19 edits in trunk/Source/WebCore
Let RenderImage construct its RenderImageResource.
<https://webkit.org/b/127290>
Everyone who creates a RenderImage immediately follows up with
creating a RenderImageResource and assigning it to the image.
Let the RenderImage constructor do this instead, and make the
imageResource() accessors return references. This exposed a
number of unnecessary null checks.
Also modernized the touched code with std::unique_ptr.
Reviewed by Antti Koivisto.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::createElementRenderer):
(WebCore::HTMLImageElement::didAttachRenderers):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::createElementRenderer):
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::didAttachRenderers):
(WebCore::HTMLVideoElement::parseAttribute):
- html/ImageInputType.cpp:
(WebCore::ImageInputType::createInputRenderer):
(WebCore::ImageInputType::attach):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::renderImageResource):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::~RenderImage):
(WebCore::RenderImage::styleDidChange):
(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::updateIntrinsicSizeIfNeeded):
(WebCore::RenderImage::updateInnerContentRect):
(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::notifyFinished):
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::foregroundIsKnownToBeOpaqueInRect):
(WebCore::RenderImage::minimumReplacedHeight):
(WebCore::RenderImage::computeIntrinsicRatioInformation):
(WebCore::RenderImage::embeddedContentBox):
- rendering/RenderImage.h:
(WebCore::RenderImage::imageResource):
(WebCore::RenderImage::cachedImage):
- rendering/RenderImageResource.h:
- rendering/RenderImageResourceStyleImage.h:
- rendering/RenderMedia.cpp:
(WebCore::RenderMedia::RenderMedia):
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
- rendering/RenderSnapshottedPlugIn.h:
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::calculateIntrinsicSize):
- rendering/style/ContentData.cpp:
(WebCore::ImageContentData::createContentRenderer):
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::RenderSVGImage):
(WebCore::RenderSVGImage::~RenderSVGImage):
(WebCore::RenderSVGImage::updateImageViewport):
(WebCore::RenderSVGImage::paint):
(WebCore::RenderSVGImage::paintForeground):
- rendering/svg/RenderSVGImage.h:
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::didAttachRenderers):
- 9:25 AM Changeset in webkit [162355] by
-
- 2 edits in trunk/Source/WTF
Remove an unused member variable
https://bugs.webkit.org/show_bug.cgi?id=127295
Reviewed by Antti Koivisto.
- wtf/MainThread.cpp:
(WTF::FunctionWithContext::FunctionWithContext):
(WTF::FunctionWithContext::operator == ):
(WTF::dispatchFunctionsFromMainThread):
- 9:21 AM Changeset in webkit [162354] by
-
- 2 edits in trunk/Source/WebCore
Update overlay scrollbars in single pass
https://bugs.webkit.org/show_bug.cgi?id=127289
Reviewed by Anders Carlsson.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
Multi-pass scrollbar resolution is only needed for traditional scrollbars. Overlay scrollbars don't affect layout.
- 9:19 AM Changeset in webkit [162353] by
-
- 2 edits in trunk/Source/WTF
Remove MutexTryLocker
https://bugs.webkit.org/show_bug.cgi?id=127294
Reviewed by Antti Koivisto.
MutexTryLocker has been replaced with std::unique_lock with std::try_to_lock everywhere now.
- wtf/ThreadingPrimitives.h:
- 9:10 AM Changeset in webkit [162352] by
-
- 5 edits in trunk/Source/JavaScriptCore
Convert GCThreadSharedData over to STL threading primitives
https://bugs.webkit.org/show_bug.cgi?id=127256
Reviewed by Andreas Kling.
- heap/GCThread.cpp:
(JSC::GCThread::waitForNextPhase):
(JSC::GCThread::gcThreadMain):
- heap/GCThreadSharedData.cpp:
(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::~GCThreadSharedData):
(JSC::GCThreadSharedData::startNextPhase):
(JSC::GCThreadSharedData::endCurrentPhase):
(JSC::GCThreadSharedData::didStartMarking):
(JSC::GCThreadSharedData::didFinishMarking):
- heap/GCThreadSharedData.h:
- heap/SlotVisitor.cpp:
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drainFromShared):
- 9:02 AM Changeset in webkit [162351] by
-
- 2 edits in trunk/Source/WebCore
Never send a non-http(s) referrer header even with a referrer policy
https://bugs.webkit.org/show_bug.cgi?id=127172
Reviewed by Alexey Proskuryakov.
This mirrors the code SecurityPolicy::shouldHideReferrer which is used
for ReferrerPolicyDefault.
No new tests, only affects an embedder that registers other schemes,
e.g. chrome://
- page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::generateReferrerHeader):
- 9:02 AM Changeset in webkit [162350] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WTF
Merge r162306 - [GLIB] GVariant floating references are not correctly handled by GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=127246
Reviewed by Martin Robinson.
Source/WTF:
GRefPtr should always use g_variant_ref_sink to deal with GVariant
floating references. In case of full references,
g_variant_ref_sink calls g_variant_ref, so it's safe to use it always.
- wtf/gobject/GRefPtr.cpp:
(WTF::refGPtr): Use g_variant_ref_sink().
- 8:43 AM Changeset in webkit [162349] by
-
- 6 edits2 adds in releases/WebKitGTK/webkit-2.2
Merge r162073 - [GTK] Web process sometimes crashes when printing in synchronous mode
https://bugs.webkit.org/show_bug.cgi?id=126979
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
When printing synchronously in GTK+ we need to make sure that we
have a list of Printers before starting the print operation. Getting
the list of printers is done synchronously by GTK+, but using a
nested main loop that might process IPC messages comming from the
UI process like EndPrinting. When the EndPrinting message is
received while the printer list is being populated, the print
operation is finished unexpectely and the web process crashes. The
PrinterListGtk class gets the list of printers in the constructor
so we just need to ensure there's an instance alive during the
synchronous print operation. In case of asynchronous printing the
printer list will be created during the print operation without
any risk, because the EndPrinting message is not sent until the
printing callback has been received in the UI process.
- GNUmakefile.list.am: Add new files to compilation.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::print): Ensure PrinterListGtk is created
before the synchronous printing and destroyed afterwards.
- WebProcess/WebPage/gtk/PrinterListGtk.cpp: Added.
(WebKit::PrinterListGtk::shared): Return the singleton.
(WebKit::PrinterListGtk::enumeratePrintersFunction): Callback
called by gtk_enumerate_printers() when a new printer is found.
(WebKit::PrinterListGtk::PrinterListGtk): Call
gtk_enumerate_printers() in syhchronous mode.
(WebKit::PrinterListGtk::~PrinterListGtk):
(WebKit::PrinterListGtk::addPrinter): Add the printer to the list
and set the default printer if needed.
(WebKit::PrinterListGtk::findPrinter): Find the printer for the
given name.
- WebProcess/WebPage/gtk/PrinterListGtk.h: Added.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: Use
PrinterListGtk class to find the printer instead of calling
gtk_enumerate_printers().
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Unskip
/webkit2/WebKitPrintOperation/close-after-print.
- 8:38 AM WebKitGTK/2.2.x edited by
- (diff)
- 8:36 AM Changeset in webkit [162348] by
-
- 5 edits2 adds in trunk
Source/WebCore: [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend
when having -webkit-background-blending applied. Turns out the problem was
the blending parameter not being passed to WebCore::CrossfadeGeneratedImage::draw
https://bugs.webkit.org/show_bug.cgi?id=126887
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
Reviewed by Dirk Schulze.
Test: css3/compositing/background-blend-mode-crossfade-image.html
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::draw): set blendMode on context.
LayoutTests: Reapply:
[CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend
when having -webkit-background-blending applied. Tests now use SVG rects, instead
of circles.
https://bugs.webkit.org/show_bug.cgi?id=126887
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
Reviewed by Dirk Schulze.
- css3/compositing/background-blend-mode-crossfade-image-expected.html:
- css3/compositing/background-blend-mode-crossfade-image.html:
- platform/efl/TestExpectations: Pass efl as blendMode is not implemented.
- platform/mac/TestExpectations: Mark added test as ImageOnlyFailure due to slight differences between the result and the blending formula.
- 8:36 AM Changeset in webkit [162347] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r162188 - [GTK] Remove the weak pointer added to the web view in WebKitPrintOperation
https://bugs.webkit.org/show_bug.cgi?id=127098
Reviewed by Martin Robinson.
If the print operation finishes and the web view is still alive,
the weak pointer added to the view should be removed.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(_WebKitPrintOperationPrivate::~_WebKitPrintOperationPrivate):
- 8:34 AM Changeset in webkit [162346] by
-
- 9 edits1 add in trunk/LayoutTests
[CSS Grid Layout] Simplify grid-columns-rows-get-set{-multiple}.html tests
https://bugs.webkit.org/show_bug.cgi?id=127055
Reviewed by Andreas Kling.
The testing code was refactored in 4 new functions that allow us
to write each test case in a single line significantly reducing
the amount of boilerplate and improving maintenance.
- fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
- fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
- fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
- fast/css-grid-layout/grid-columns-rows-get-set.html:
- fast/css-grid-layout/named-grid-line-get-set-expected.txt:
- fast/css-grid-layout/named-grid-line-get-set.html:
- fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
(testInherit):
(testInitial):
- fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
- fast/css-grid-layout/resources/grid-definitions-parsing-utils.js: Added.
(testGridDefinitionsValues):
(testGridDefinitionsSetJSValues):
(testNonGridDefinitionsSetJSValues):
(checkGridDefinitionsSetJSValues): Helper function for testGridDefinitions*.
(testGridDefinitionsSetBadJSValues):
- 8:32 AM WebKitGTK/2.2.x edited by
- (diff)
- 8:28 AM Changeset in webkit [162345] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r162057 - [GTK] UI process crashes when closing the window right after printing with javascript
https://bugs.webkit.org/show_bug.cgi?id=126981
Reviewed by Gustavo Noronha Silva.
The UI process crashes because when the page is closed, the web
view is destroyed before the print operation has actually
finished. Use a weak pointer to make sure the web view pointer is
set to NULL when the it's destroyed and emit the finished callback
always so that the user can clean up the operation even when the
web view has been closed.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(drawPagesForPrintingCompleted):
- 8:28 AM Changeset in webkit [162344] by
-
- 3 edits2 adds in trunk
Null-pointer dereference in WebCore::CSSValue::isPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=124769
Reviewed by Andreas Kling.
Source/WebCore:
Test: fast/gradients/crash-on-no-position-separator.html
The function parseFillPosition() may not return valid values for
centerX and centerY if the input data is malformed. We need to
check that we get a valid pair of positions before checking that
they're actually valid primitive values in the assertions.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseRadialGradient):
LayoutTests:
Checks that invalid position declarations (like skiping the comma
separator) do not make the engine crash.
- fast/gradients/crash-on-no-position-separator-expected.txt: Added.
- fast/gradients/crash-on-no-position-separator.html: Added.
- 8:25 AM Changeset in webkit [162343] by
-
- 6 edits in releases/WebKitGTK/webkit-2.2
Merge r162056 - [GTK] UI process crashes when the web process crashes while printing
https://bugs.webkit.org/show_bug.cgi?id=126977
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
When the web process crashes, the printing callback is
invalidated, so the function is called with a NULL error.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(drawPagesForPrintingCompleted): Check wkError is not NULL before
trying to use it.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewPrintFrame): Set the print mode of the operation
before emitting the print signal.
Tools:
Add new test case to check that closing the window right after
printing works. It's skipped for now, because this patch only
fixes the UI process crash, but not the web process one.
- Scripts/run-gtk-tests:
(TestRunner): Skip
/webkit2/WebKitPrintOperation/close-after-print.
- TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
(testPrintOperationPrintPrinter):
(findPrintToFilePrinter):
(testPrintOperationPrint):
(testPrintOperationErrors):
(testPrintOperationCloseAfterPrint):
(beforeAll):
- 8:20 AM WebKitGTK/2.2.x edited by
- (diff)
- 8:18 AM Changeset in webkit [162342] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r162059 - [SOUP] [WK2] - Disable MemoryCache when the DOCUMENT_VIEWER cache model is set
https://bugs.webkit.org/show_bug.cgi?id=126577
Patch by Tomas Popela <tpopela@redhat.com> on 2014-01-15
Reviewed by Carlos Garcia Campos.
As in http://trac.webkit.org/changeset/152483, but this time for
WebKit2. When WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER is set we need to
disable the MemoryCache completely to prevent caching of the resources.
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformSetCacheModel):
- 8:15 AM Changeset in webkit [162341] by
-
- 7 edits2 adds in trunk
Source/WebCore: Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
The problem consisted in the drawing path using the default
blending parameter at all times.
https://bugs.webkit.org/show_bug.cgi?id=118894
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
Reviewed by Dirk Schulze.
Test: css3/compositing/background-blend-mode-data-uri-svg-image.html
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer): Pass blendMode to Image::drawPattern.
- svg/graphics/SVGImage.h: Add a blendMode parameter to drawPatternForContainer.
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern): Pass blendMode to drawPatternForContainer call.
LayoutTests: Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
Tests now use rectangles instead of circles for SVGs.
https://bugs.webkit.org/show_bug.cgi?id=118894
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
Reviewed by Dirk Schulze.
- css3/compositing/background-blend-mode-data-uri-svg-image-expected.html:
- css3/compositing/background-blend-mode-data-uri-svg-image.html:
- platform/efl/TestExpectations: pass tests for efl, blendMode is not implemented.
- platform/mac/TestExpectations: marking test as ImageOnlyFailure due to slight pixel inconsistencies between the result and the formula.
- 8:13 AM WebKitGTK/2.2.x edited by
- (diff)
- 7:42 AM Changeset in webkit [162340] by
-
- 4 edits11 deletes in trunk
Subpixel layout: setSimpleLineLayoutEnabled() produces different layout when line position has CSS px fractions.
https://bugs.webkit.org/show_bug.cgi?id=126892
Reviewed by Antti Koivisto.
SimpleLineLayout needs to copy normal linebox layout's subpixel rounding strategy to produce
the same layout.
Source/WebCore:
Covered by existing tests.
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintFlow):
LayoutTests:
- platform/mac/TestExpectations: Unskipping some SimpleLineLayout tests.
- 6:42 AM HackingGtk edited by
- Added link to GRefPtr (diff)
- 6:36 AM Changeset in webkit [162339] by
-
- 4 edits in releases/WebKitGTK/webkit-2.2
Merge r161555 - [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=126686
Reviewed by Martin Robinson.
Source/WebKit2:
We are currently writing the downloads directly into the
destination, and when a download fails or is cancelled after the
destination has been decided, the partial file is left on the
disk. Deleting the final file is not safe because there might be a
race condition, so we can use an intermediate file like other
browsers do, a file in the same directory than the target
destination but with .wkdownload suffix, that is removed when the
download fails or is cancelled. If the download finishes
successfully the intermediate file is renamed to the final
destination.
- Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::deleteIntermediateFileInNeeded): Delete
the intermdiate file if it's been created already.
(WebKit::DownloadClient::downloadFailed): Call deleteIntermediateFileInNeeded.
(WebKit::DownloadClient::didReceiveResponse): Do not create a
SoupMessage for the given ResourceResponse that is not used, cache
the ResourceResponse instead. Create the intermediate file and use
it instead of the final destination.
(WebKit::DownloadClient::didReceiveData): Use the cached
ResourceResponse directly.
(WebKit::DownloadClient::didFinishLoading): Rename the
intermediate file to the final destination and write the metadata
in the final target destination.
(WebKit::DownloadClient::cancel): Handle the download cancellation
here, removing the intermediate file is needed and cancelling the
ResourceHandle and the download.
(WebKit::DownloadClient::handleResponseLater):
(WebKit::Download::cancel): Let the client handle the cancellation.
Tools:
Test that partial files are not left on disk after a download has
been cancelled after the destination has been decided. To make
sure the download is cancelled after the destination has been
decided and before the operation finishes, we cancel the download
in the destination decided callback, and we use an infinite
resource that writes chunks to the response body and never
completes the body.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
(addContentDispositionHTTPHeaderToResponse): Helper function to
add the Content-Disposition to the response headers.
(writeNextChunkIdle): Write next chunk to response body.
(writeNextChunk): Write next chunk in an idle to avoid flooding
the network with the inifnite resource.
(serverCallback): Add an inifinite resource.
(testDownloadRemoteFileError): Check that partial file is not
present after the download has been cancelled.
- 6:30 AM WebKitGTK/2.2.x edited by
- (diff)
- 6:23 AM WebKitGTK/2.2.x edited by
- (diff)
- 6:09 AM Changeset in webkit [162338] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add test expectations for failing tests.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 6:07 AM Changeset in webkit [162337] by
-
- 4 edits in releases/WebKitGTK/webkit-2.2
Merge r161176 - [SOUP] willSendRequest doesn't work after a redirect
https://bugs.webkit.org/show_bug.cgi?id=126290
Reviewed by Martin Robinson.
Source/WebCore:
The problem is that we are creating the new soup request for the
redirect before calling ResourceHandleClient::willSendRequest() so
that any change made to the request by the client is ignored.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::doRedirect): Create the new soup request and soup
message for the redirect after calling willSendRequest() on the
client.
Source/WebKit2:
Add test cases to test send-request signal in case of
redirection.
- UIProcess/API/gtk/tests/TestResources.cpp:
(testWebResourceSendRequest):
(serverCallback):
- 6:05 AM GRefPtr edited by
- (diff)
- 6:03 AM GRefPtr edited by
- (diff)
- 6:02 AM GRefPtr edited by
- (diff)
- 5:53 AM GRefPtr edited by
- (diff)
- 5:49 AM GRefPtr edited by
- Reword some parts, add when-to-use section (diff)
- 5:29 AM Changeset in webkit [162336] by
-
- 10 edits83 moves7 adds1 delete in releases/WebKitGTK/webkit-2.2
Merge r161366 - [GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=126342
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2014-01-04
Reviewed by Gustavo Noronha Silva.
.:
- GNUmakefile.am: Remove unused variable.
Source/WebKit/gtk:
- tests/GNUmakefile.am: Removed.
Source/WebKit2:
- UIProcess/API/gtk/tests/GNUmakefile.am: Removed.
Tools:
- Scripts/run-gtk-tests: Update to refer to the new build locations.
- Scripts/webkitpy/style/checker.py: Update the style checker.
- Scripts/webkitpy/style/checker_unittest.py:
- TestWebKitAPI/GNUmakefile.am:
- TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
- TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
- TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
- TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
- TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
- TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
- TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
- TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
- TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
- TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
- TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
- TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
- TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
- TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
- TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
- TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
- TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
- TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
- TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
- TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
- TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
- TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
- TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
- TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
- TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
- TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
- TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
- TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
- TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
- TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
- TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
- TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
- TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
- TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
- TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
- TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
- TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
- TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
- 3:59 AM Changeset in webkit [162335] by
-
- 4 edits in releases/WebKitGTK/webkit-2.2/Source
Merge r160270 - Fix API test expectation following 160220.
Rubber-stamped by Martin Robinson.
Source/WebKit/gtk:
- tests/testatkroles.c:
(finish_loading): rename variable documentFrame -> document.
(test_webkit_atk_get_role_document_frame): check for ATK_ROLE_DOCUMENT_WEB instead of
ATK_ROLE_DOCUMENT_FRAME.
(test_webkit_atk_get_role_heading): rename variable documentFrame -> document.
(test_webkit_atk_get_role_image): ditto.
(test_webkit_atk_get_role_link): ditto.
(test_webkit_atk_get_role_list_and_item): ditto.
(test_webkit_atk_get_role_paragraph): ditto.
(test_webkit_atk_get_role_section): ditto.
(test_webkit_atk_get_role_table): ditto.
(test_webkit_atk_get_role_separator): ditto.
(test_webkit_atk_get_role_combobox): ditto.
(test_webkit_atk_get_role_form): ditto.
(test_webkit_atk_get_role_check_box): ditto.
(test_webkit_atk_get_role_entry): ditto.
(test_webkit_atk_get_role_label): ditto.
(test_webkit_atk_get_role_listbox): ditto.
(test_webkit_atk_get_role_password_text): ditto.
(test_webkit_atk_get_role_push_button): ditto.
(test_webkit_atk_get_role_radio_button): ditto.
Source/WebKit2:
- UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp:
(testAtspiBasicHierarchy): check for ATK_ROLE_DOCUMENT_WEB instead of ATK_ROLE_DOCUMENT_FRAME.
- 3:59 AM Changeset in webkit [162334] by
-
- 3 edits2 adds in trunk
Col width is not honored when dynamically updated and it would make table narrower
https://bugs.webkit.org/show_bug.cgi?id=104711
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2014-01-20
Reviewed by Antti Koivisto.
Source/WebCore:
Increasing the table width by increasing the colgroup width
was working but decreasing the table width by decreasing the
colgroup width is not working.
Test: fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::styleDidChange):
When colgroup width is defined table cell should adjust according to
that. On decreasing colgroup width the cells maxPreferredLogicalWidth
was still set to the earlier value. Setting the
setPreferredLogicalWidthsDirty to true so that cells pref width is
calculated again.
LayoutTests:
- fast/dom/HTMLTableColElement/resize-table-width-using-col-width-expected.txt: Added.
- fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html: Added.
Added new test case to verify that table cell width decreases by
decreasing the colgroup width.
- 3:58 AM Changeset in webkit [162333] by
-
- 6 edits3 adds in releases/WebKitGTK/webkit-2.2
Merge r160220 - [ATK] Missing aria roles mappings
https://bugs.webkit.org/show_bug.cgi?id=117729
Patch by Lukasz Gajowy <l.gajowy@samsung.com> on 2013-12-06
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Added a few mappings from ARIA roles to ATK roles.
Test: accessibility/aria-mappings.html
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
Tools:
Added new mappings to AccessibilityUIElementAtk.cpp.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
LayoutTests:
Added new test, checking whether ARIA roles to ATK roles mappings work properly.
- accessibility/aria-mappings-expected.txt: Added.
- accessibility/aria-mappings.html: Added.
- platform/mac/accessibility/aria-mappings-expected.txt: Added.
- 3:43 AM Changeset in webkit [162332] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore
Merge r160997 - webkit gtk 2.2.3 stable tarball compilation error
https://bugs.webkit.org/show_bug.cgi?id=125987
Reviewed by Gustavo Noronha Silva.
Only try including <gdk/gdkwayland.h> and using GDK_IS_WAYLAND_DISPLAY if the Wayland support has been
enabled and when not compiling with GTK+ 2 (which occurs when building for libPlatformGtk2).
- platform/graphics/GLContext.cpp:
(WebCore::GLContext::createContextForWindow):
- 3:40 AM Changeset in webkit [162331] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.2
Merge r161138 - [GTK] Split WebKit2APITests/TestWebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=126284
Reviewed by Philippe Normand.
Source/WebKit2:
WebKitWebView test is too big already making more difficult to
handle timeouts and skipped tests. Split it in 3 by moving
UIClient and auth tests to their own files.
- UIProcess/API/gtk/tests/GNUmakefile.am:
- UIProcess/API/gtk/tests/TestAuthentication.cpp: Added.
(testWebViewAuthenticationRequest):
(testWebViewAuthenticationCancel):
(testWebViewAuthenticationLoadCancelled):
(testWebViewAuthenticationFailure):
(testWebViewAuthenticationNoCredential):
(testWebViewAuthenticationStorage):
(testWebViewAuthenticationSuccess):
(serverCallback):
(beforeAll):
(afterAll):
- UIProcess/API/gtk/tests/TestUIClient.cpp: Added.
(testWebViewCreateReadyClose):
(checkMimeTypeForFilter):
(testWebViewAllowModalDialogs):
(testWebViewDisallowModalDialogs):
(testWebViewJavaScriptDialogs):
(testWebViewWindowProperties):
(testWebViewMouseTarget):
(testWebViewPermissionRequests):
(testWebViewFileChooserRequest):
(beforeAll):
(afterAll):
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(beforeAll):
(afterAll):
Tools:
Skip only WebKitWebView/mouse-target and all TestAuthentication
tests that are timing out when running under xvfb.
- Scripts/run-gtk-tests:
(TestRunner):
- 3:31 AM Changeset in webkit [162330] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Tools
Merge r155605 - [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
https://bugs.webkit.org/show_bug.cgi?id=121218
Reviewed by Philippe Normand.
Skipping the entire suite was added to skip tests when they can't
be run because of the environment, for example to skip the a11y
tests when the at-spi daemons fail to start. This is no longer
true for all the cases, so we can disable the tests that are
impossible to run instead of skipping them.
- Scripts/run-gtk-tests:
(TestRunner.init): Initialize the skipped tests list.
(TestRunner._setup_testing_environment): Add
TestWebKitAccessibility path to the list of disabled tests when
at-spi daemon fail to start.
(TestRunner._should_run_test_program): Check first if the test
program is disabled and then whether it's skipped honoring the
skipped command line option.
- 3:18 AM GRefPtr edited by
- (diff)
- 3:14 AM Changeset in webkit [162329] by
-
- 2 edits in trunk/Source/WebCore
[CoordinatedGraphics] Segmentation fault at CoordinatedGraphicsScene::clearImageBackingContents
https://bugs.webkit.org/show_bug.cgi?id=125776
Patch by Edit Balint <edbalint@inf.u-szeged.hu> on 2014-01-20
Reviewed by Csaba Osztrogonác.
Unexpected behavior occurs in some test cases which leads to segmentation fault.
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::removeImageBacking):
- 3:09 AM Changeset in webkit [162328] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Tools
Merge r155038 - REGRESSION (r132328): /WebKit2APITests/TestWebKitAccessibility unit test is failing
https://bugs.webkit.org/show_bug.cgi?id=100408
Unreviewed gardening. Unskip TestWebKitAccessibility after
manually checking that it's running properly in the bot.
- Scripts/run-gtk-tests:
(TestRunner): Unskipped TestWebKitAccessibility.
- 3:08 AM GRefPtr edited by
- Add page outline macro (diff)
- 3:07 AM Changeset in webkit [162327] by
-
- 7 edits3 adds in releases/WebKitGTK/webkit-2.2
Merge r155428 - [GTK] Test /webkit/atk/getTextInParagraphAndBodyModerate fails
https://bugs.webkit.org/show_bug.cgi?id=105538
Reviewed by Chris Fleizach.
Source/WebCore:
Expose '\n' for linebreaks when they were explicitly set by the
author of the web content with a <br> tag.
Tests: accessibility/paragraph-with-linebreaks.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::shouldAddSpaceBeforeAppendingNextElement): Helper
function to decide when to append spaces when building the text
under an element, considering line breaks.
(WebCore::AccessibilityNodeObject::textUnderElement): Use the
shouldAddSpaceBeforeAppendingNextElement() function here.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement): Return the
renderer's text for accessibility objects exposing <br> elements.
- html/parser/HTMLParserIdioms.h:
(WebCore::isHTMLSpaceButNotLineBreak): New helper function, useful
to be passed to other functions like simplifyWhiteSpace().
Tools:
Unskip passing test getTextInParagraphAndBodyModerate.
- Scripts/run-gtk-tests:
(TestRunner): Unskip pasing test.
LayoutTests:
Added new Layout test and platform specific expectations.
- platform/efl/accessibility/paragraph-with-linebreaks-expected.txt: Added.
- platform/gtk/accessibility/paragraph-with-linebreaks-expected.txt: Added.
- accessibility/paragraph-with-linebreaks.html: Added.
- 3:03 AM GRefPtr created by
- Initial version
- 2:57 AM Changeset in webkit [162326] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Marked media/audio-concurrent-supported.html as flaky.
Marked js/dom/string-replacement-outofmemory.html as slow on the release configuration as well.
- platform/gtk/TestExpectations:
- 2:53 AM Changeset in webkit [162325] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Tools
Merge r160987 - [GTK] run-gtk-tests should always run glib tests with -k option
https://bugs.webkit.org/show_bug.cgi?id=126132
Reviewed by Philippe Normand.
With -k command line option, gtester continues running all other
test cases after a failure.
- Scripts/run-gtk-tests:
(TestRunner._run_test_glib): Use -k option when runing glib tests
to not stop on failure.
- 2:51 AM Changeset in webkit [162324] by
-
- 4 edits in releases/WebKitGTK/webkit-2.2
Merge r158002 - [GTK] [WebKit2] CanHandleRequest API test fails
https://bugs.webkit.org/show_bug.cgi?id=88453
Patch by Anton Obzhirov <Anton Obzhirov> on 2013-10-25
Reviewed by Martin Robinson.
Source/WebKit2:
Make WebPage::platformCanHandleRequest return false by default
for unknown schemes.
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformCanHandleRequest):
Tools:
- Scripts/run-gtk-tests:
(TestRunner):
- 2:37 AM Changeset in webkit [162323] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r160965 - [GTK] Test /webkit2/WebKitWebResource/mime-type fails when run after /webkit2/WebKitWebView/resources
https://bugs.webkit.org/show_bug.cgi?id=126119
Reviewed by Martin Robinson.
The problem is that when the blank.ico resource is loaded from the
disk cache, the mime type is null, because the soup cache doesn't
cache sniffed mime types. This doesn't happen when a resource is
loaded form the memory cache, because the ResourceResponse is
cached, not only the headers. I think the disk cache should also
cache the sniffed content type, but that needs to be done in
soup. For now we can workaround the issue in the unit test by
making sure that resources that can be cached, also include the
Content-Type header, this way the mime type won't be sniffed and
it will be cached as a HTTP header in the disk cache.
- UIProcess/API/gtk/tests/TestResources.cpp:
(serverCallback): Add Content-Type header for resources that can
be cached.
- 2:35 AM Changeset in webkit [162322] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r160904 - [GTK] Some unit tests using web extensions fail when run alone
https://bugs.webkit.org/show_bug.cgi?id=126002
Reviewed by Gustavo Noronha Silva.
The problem is that the page is created before the dbus connection
has been established, and we are connecting to web-page-created
signal once we have a valid dbus connection. We should connect to
the signal before connecting to dbus and queue any request to emit
a dbus signal until the connection is set. This also fixes the
WebExtensions tests when using the network process because a new
web process is launched for every test case.
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(DelayedSignal::DelayedSignal): Helper struct to queue signal
emissions requested before the dbus connection has been
established.
(emitDocumentLoaded): Emit the dbus DocumentLoaded signal.
(documentLoadedCallback): Queue the signal emission if we still
don't have a connection or call emitDocumentLoaded otherwise.
(emitURIChanged): Emit the dbus URIChanged signal.
(uriChangedCallback): Queue the signal emission if we still don't
have a connection or call emitURIChanged otherwise.
(pageCreatedCallback): Pass the web extension as user data to
document-loaded and uri-changed callbacks.
(busAcquiredCallback): Set the connection as user data of the web
extension and process any delayed signal emission pending.
(webkit_web_extension_initialize): Connect to web-page-create
signal before connecting to dbus.
- 2:32 AM Changeset in webkit [162321] by
-
- 3 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r160540 - [GTK] Add a unit tests to WebKit2 to test node names
https://bugs.webkit.org/show_bug.cgi?id=125686
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/tests/DOMNodeTest.cpp:
(WebKitDOMNodeTest::testTagNames):
(WebKitDOMNodeTest::runTest):
(registerTests):
- UIProcess/API/gtk/tests/TestDOMNode.cpp:
(testWebKitDOMNodeTagNames):
(beforeAll):
- 2:30 AM Changeset in webkit [162320] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r160481 - [GTK] WebProcess tests are failing with newer glib
https://bugs.webkit.org/show_bug.cgi?id=125621
Reviewed by Martin Robinson.
Newer versions of glib unset the DISPLAY env variable in
g_test_dbus_up(). The WebProcess needs the DISPLAY variable to
work, and it's important to keep its value when running the tests
under Xvfb.
- UIProcess/API/gtk/tests/WebProcessTestRunner.cpp:
(WebProcessTestRunner::WebProcessTestRunner): Restore the DISPLAY
env variable after calling g_test_dbus_up().
- 2:26 AM Changeset in webkit [162319] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r160480 - [GTK] Make sure unit tests don't use GVFS and dconf
https://bugs.webkit.org/show_bug.cgi?id=125620
Reviewed by Martin Robinson.
They should use the local vfs and the gsettings memory backend.
- UIProcess/API/gtk/tests/TestMain.cpp:
(main):
- 2:02 AM Changeset in webkit [162318] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/ThirdParty/ANGLE
Merge r160705 - [GTK] Some ANGLE headers missing from dist
https://bugs.webkit.org/show_bug.cgi?id=125782
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-12-17
Reviewed by Carlos Garcia Campos.
- GNUmakefile.am: add a few headers that were missing from the build,
causing build failures when the system headers were incompatible.
- 1:57 AM Changeset in webkit [162317] by
-
- 7 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore
Merge r160223 - Hook into some shader symbol logic following the ANGLE update in r159533.
https://bugs.webkit.org/show_bug.cgi?id=125332.
Reviewed by Brent Fulgham.
No new functionality added.
- html/canvas/WebGLRenderingContext.cpp: Add some error checking for errors related to
shader symbols that exist across both vertex and fragment shaders.
(WebCore::WebGLRenderingContext::linkProgram):
- platform/graphics/ANGLEWebKitBridge.cpp: Add logic for handling varyings
and add new fields to the ANGLEShaderSymbol struct.
(WebCore::getSymbolInfo):
- platform/graphics/ANGLEWebKitBridge.h:
- platform/graphics/GraphicsContext3D.h: Add those same fields to the SymbolInfo struct
as well so that we can access them from our shader source map.
Also add a map of varyings along side the uniforms and attributes.
(WebCore::GraphicsContext3D::SymbolInfo::SymbolInfo):
(WebCore::GraphicsContext3D::ShaderSourceEntry::symbolMap):
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::areProgramSymbolsValid): Will be filled in later, this method
will use the shader source map to check for issues with unused varyings and precisions
mismatches of shader symbols that exist across both the vertex and fragment shaders.
- 1:57 AM WebKitGTK/2.2.x edited by
- (diff)
- 1:53 AM Changeset in webkit [162316] by
-
- 4 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore
Merge r156971 - [WebGL] program should not be able to link if a bad shader is attached
https://bugs.webkit.org/show_bug.cgi?id=94036
Reviewed by Darin Adler.
If you attempt to link a program when bad shaders are attached, the
link should fail. WebGL also requires that the previously linked
program should remain intact. We were doing the former, but not
the latter.
Fix this by not calling glLinkProgram if we know we have bad
shaders, and synthesize a bad link status instead.
Test: WebGL conformance test conformance/programs/program-test.html
(found in LayoutTests/webgl)
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::compileShader): Mark a shader as valid
if it compiled ok.
(WebCore::WebGLRenderingContext::linkProgram): Don't call into GraphicsContext3D::linkProgram
if we know that we don't have valid shaders.
- html/canvas/WebGLShader.cpp:
(WebCore::WebGLShader::WebGLShader): Initialize m_isValid.
- html/canvas/WebGLShader.h:
(WebCore::WebGLShader::isValid): New member variable getter and setter.
(WebCore::WebGLShader::setValid):
- 1:44 AM Changeset in webkit [162315] by
-
- 135 edits3 moves20 adds5 deletes in releases/WebKitGTK/webkit-2.2/Source
Merge r159533 - Update ANGLE sources.
https://bugs.webkit.org/show_bug.cgi?id=124615.
Reviewed by Dean Jackson.
Tests covered by Khronos WebGL conformance tests.
Update ANGLE to checkout a60e0805721f62c28a55faf2df74472cc5fc91fc.
Modify xcodeproj files as necessary, update plist.
Stop using DerivedSources.make and just use the generated sources that are checked into ANGLE.
Add a note to bison generated files indicating that Apple elects to distribute said files under the BSD license:
ExpressionParser.cpp, glslang_tab.cpp, glslang_tab.h.
- ANGLE.plist:
- ANGLE.xcodeproj/project.pbxproj:
- DerivedSources.make: Removed.
- platform/graphics/ANGLEWebKitBridge.cpp: Resolve a build error that resulted from updating ANGLE.
(WebCore::getSymbolInfo):
(WebCore::ANGLEWebKitBridge::compileShaderSource):
- include/EGL/egl.h:
- include/EGL/eglsoftlinking.h: Removed.
- include/GLES2/gl2.h:
- include/GLES2/gl2softlinking.h: Removed.
- include/GLSLANG/ShaderLang.h:
- include/KHR/khrplatform.h:
- src/ANGLE.sln: Added.
- src/build_angle.gypi:
- src/common/debug.h:
- src/common/event_tracer.cpp: Added.
(gl::TraceGetTraceCategoryEnabledFlag):
(gl::TraceAddTraceEvent):
- src/common/event_tracer.h: Added.
- src/common/version.h:
- src/compiler/CodeGen.cpp: Added.
(ConstructCompiler):
(DeleteCompiler):
- src/compiler/CodeGenGLSL.cpp: Removed.
- src/compiler/CodeGenHLSL.cpp: Removed.
- src/compiler/Common.h:
(NewPoolTString):
- src/compiler/Compiler.cpp:
(TCompiler::Init):
(TCompiler::compile):
(TCompiler::InitBuiltInSymbolTable):
(TCompiler::clearResults):
(TCompiler::collectVariables):
- src/compiler/ConstantUnion.h:
- src/compiler/DetectDiscontinuity.cpp:
- src/compiler/InfoSink.h:
- src/compiler/InitializeDll.cpp:
(InitProcess):
(DetachProcess):
- src/compiler/InitializeDll.h:
- src/compiler/InitializeGLPosition.cpp: Added.
(InitializeGLPosition::visitAggregate):
(InitializeGLPosition::insertCode):
- src/compiler/InitializeGLPosition.h: Added.
(InitializeGLPosition::InitializeGLPosition):
(InitializeGLPosition::visitBinary):
(InitializeGLPosition::visitUnary):
(InitializeGLPosition::visitSelection):
(InitializeGLPosition::visitLoop):
(InitializeGLPosition::visitBranch):
- src/compiler/InitializeGlobals.h:
- src/compiler/InitializeParseContext.cpp:
(InitializeParseContextIndex):
(FreeParseContextIndex):
(SetGlobalParseContext):
(GetGlobalParseContext):
- src/compiler/InitializeParseContext.h:
- src/compiler/IntermTraverse.cpp:
(TIntermSymbol::traverse):
(TIntermConstantUnion::traverse):
(TIntermBinary::traverse):
(TIntermUnary::traverse):
(TIntermAggregate::traverse):
(TIntermSelection::traverse):
(TIntermLoop::traverse):
(TIntermBranch::traverse):
- src/compiler/Intermediate.cpp:
(GetHigherPrecision):
(getOperatorString):
(TIntermLoop::replaceChildNode):
(TIntermBranch::replaceChildNode):
(TIntermBinary::replaceChildNode):
(TIntermUnary::replaceChildNode):
(TIntermAggregate::replaceChildNode):
(TIntermSelection::replaceChildNode):
(TIntermOperator::isAssignment):
(TIntermediate::promoteConstantUnion):
- src/compiler/MapLongVariableNames.cpp:
- src/compiler/MapLongVariableNames.h:
- src/compiler/NodeSearch.h: Added.
(sh::NodeSearchTraverser::NodeSearchTraverser):
(sh::NodeSearchTraverser::found):
(sh::NodeSearchTraverser::search):
(sh::FindDiscard::visitBranch):
(sh::FindSideEffectRewriting::visitBinary):
- src/compiler/OutputGLSLBase.cpp:
(TOutputGLSLBase::visitSelection):
(TOutputGLSLBase::visitAggregate):
(TOutputGLSLBase::visitLoop):
- src/compiler/OutputGLSLBase.h:
- src/compiler/OutputHLSL.cpp:
(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitBinary):
(sh::OutputHLSL::visitSelection):
(sh::OutputHLSL::visitBranch):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::addConstructor):
- src/compiler/OutputHLSL.h:
- src/compiler/ParseContext.cpp: Added.
(TParseContext::parseVectorFields):
(TParseContext::parseMatrixFields):
(TParseContext::recover):
(TParseContext::error):
(TParseContext::warning):
(TParseContext::trace):
(TParseContext::assignError):
(TParseContext::unaryOpError):
(TParseContext::binaryOpError):
(TParseContext::precisionErrorCheck):
(TParseContext::lValueErrorCheck):
(TParseContext::constErrorCheck):
(TParseContext::integerErrorCheck):
(TParseContext::globalErrorCheck):
(TParseContext::reservedErrorCheck):
(TParseContext::constructorErrorCheck):
(TParseContext::voidErrorCheck):
(TParseContext::boolErrorCheck):
(TParseContext::samplerErrorCheck):
(TParseContext::structQualifierErrorCheck):
(TParseContext::parameterSamplerErrorCheck):
(TParseContext::containsSampler):
(TParseContext::arraySizeErrorCheck):
(TParseContext::arrayQualifierErrorCheck):
(TParseContext::arrayTypeErrorCheck):
(TParseContext::arrayErrorCheck):
(TParseContext::nonInitConstErrorCheck):
(TParseContext::nonInitErrorCheck):
(TParseContext::paramErrorCheck):
(TParseContext::extensionErrorCheck):
(TParseContext::supportsExtension):
(TParseContext::isExtensionEnabled):
(TParseContext::findFunction):
(TParseContext::executeInitializer):
(TParseContext::areAllChildConst):
(TParseContext::addConstructor):
(TParseContext::foldConstConstructor):
(TParseContext::constructBuiltIn):
(TParseContext::constructStruct):
(TParseContext::addConstVectorNode):
(TParseContext::addConstMatrixNode):
(TParseContext::addConstArrayNode):
(TParseContext::addConstStruct):
(TParseContext::enterStructDeclaration):
(TParseContext::exitStructDeclaration):
(TParseContext::structNestingErrorCheck):
(TParseContext::addIndexExpression):
(PaParseStrings):
- src/compiler/ParseContext.h: Added.
(TParseContext::TParseContext):
(TParseContext::numErrors):
(TParseContext::infoSink):
(TParseContext::pragma):
(TParseContext::extensionBehavior):
- src/compiler/ParseHelper.cpp: Removed.
- src/compiler/ParseHelper.h: Removed.
- src/compiler/PoolAlloc.cpp:
(InitializePoolIndex):
(FreePoolIndex):
(GetGlobalPoolAllocator):
(SetGlobalPoolAllocator):
- src/compiler/PoolAlloc.h:
(pool_allocator::pool_allocator):
- src/compiler/SearchSymbol.h:
- src/compiler/ShHandle.h:
(TCompiler::getVaryings):
- src/compiler/ShaderLang.cpp:
(checkVariableMaxLengths):
(ShInitialize):
(ShFinalize):
(ShConstructCompiler):
(ShCompile):
(ShGetInfo):
(ShGetVariableInfo):
(ShCheckVariablesWithinPackingLimits):
- src/compiler/SymbolTable.cpp:
(TSymbolTable::~TSymbolTable):
- src/compiler/SymbolTable.h:
(TSymbol::TSymbol):
(TSymbolTableLevel::insert):
(TSymbolTable::push):
(TSymbolTable::pop):
(TSymbolTable::findBuiltIn):
(TSymbolTable::relateToExtension):
(TSymbolTable::setDefaultPrecision):
(TSymbolTable::getDefaultPrecision):
(TSymbolTable::supportsPrecision):
- src/compiler/Types.h:
(NewPoolTFieldList):
(TType::TType):
(TType::setNominalSize):
(TPublicType::setAggregate):
- src/compiler/UnfoldShortCircuit.cpp:
(sh::UnfoldShortCircuit::visitBinary):
(sh::UnfoldShortCircuit::visitSelection):
- src/compiler/UnfoldShortCircuit.h:
- src/compiler/UnfoldShortCircuitAST.cpp: Added.
(UnfoldShortCircuitAST::visitBinary):
(UnfoldShortCircuitAST::updateTree):
- src/compiler/UnfoldShortCircuitAST.h: Added.
(UnfoldShortCircuitAST::UnfoldShortCircuitAST):
(UnfoldShortCircuitAST::NodeUpdateEntry::NodeUpdateEntry):
- src/compiler/Uniform.cpp:
(sh::Uniform::Uniform):
- src/compiler/Uniform.h:
- src/compiler/ValidateLimitations.cpp:
(ValidateLimitations::validateFunctionCall):
(ValidateLimitations::validateOperation):
- src/compiler/VariableInfo.cpp:
(TVariableInfo::TVariableInfo):
(CollectVariables::CollectVariables):
(CollectVariables::visitSymbol):
(CollectVariables::visitAggregate):
- src/compiler/VariableInfo.h:
- src/compiler/debug.cpp:
- src/compiler/depgraph/DependencyGraph.cpp:
- src/compiler/depgraph/DependencyGraphBuilder.cpp:
(TDependencyGraphBuilder::visitBinary):
- src/compiler/generate_parser.sh:
- src/compiler/glslang.l:
- src/compiler/glslang.y:
- src/compiler/glslang_lex.cpp:
(input):
(yyerror):
(int_constant):
(float_constant):
(glslang_scan):
- src/compiler/glslang_tab.cpp:
(yysyntax_error):
(glslang_parse):
- src/compiler/glslang_tab.h:
- src/compiler/intermediate.h:
(TIntermSymbol::hasSideEffects):
(TIntermSymbol::replaceChildNode):
(TIntermConstantUnion::hasSideEffects):
(TIntermConstantUnion::getIConst):
(TIntermConstantUnion::getFConst):
(TIntermConstantUnion::getBConst):
(TIntermConstantUnion::replaceChildNode):
(TIntermOperator::hasSideEffects):
(TIntermBinary::hasSideEffects):
(TIntermUnary::hasSideEffects):
(TIntermAggregate::hasSideEffects):
(TIntermSelection::hasSideEffects):
(TIntermTraverser::~TIntermTraverser):
(TIntermTraverser::incrementDepth):
(TIntermTraverser::decrementDepth):
(TIntermTraverser::getParentNode):
- src/compiler/localintermediate.h:
- src/compiler/parseConst.cpp:
- src/compiler/preprocessor/ExpressionParser.cpp:
(yy_symbol_print):
(yy_stack_print):
(yy_reduce_print):
(yystrlen):
(yystpcpy):
(yytnamerr):
(yysyntax_error):
(yydestruct):
(yyparse):
- src/compiler/preprocessor/ExpressionParser.y:
- src/compiler/preprocessor/Preprocessor.cpp:
(pp::Preprocessor::setMaxTokenLength):
(pp::Preprocessor::lex):
- src/compiler/preprocessor/Preprocessor.h:
- src/compiler/preprocessor/Tokenizer.cpp:
(pp::Tokenizer::Tokenizer):
(pp::Tokenizer::lex):
- src/compiler/preprocessor/Tokenizer.h:
(pp::Tokenizer::setMaxTokenLength):
- src/compiler/preprocessor/Tokenizer.l:
- src/compiler/preprocessor/generate_parser.sh:
- src/compiler/preprocessor/preprocessor.vcxproj: Added.
- src/compiler/preprocessor/preprocessor.vcxproj.filters: Added.
- src/compiler/timing/RestrictFragmentShaderTiming.cpp:
- src/compiler/translator.vcxproj: Added.
- src/compiler/translator.vcxproj.filters: Added.
- src/compiler/util.cpp:
(atof_clamp):
(atoi_clamp):
- src/compiler/util.h:
- src/libEGL/Surface.cpp:
(egl::Surface::checkForOutOfDateSwapChain):
- src/libEGL/libEGL.cpp:
- src/libEGL/libEGL.rc:
- src/libEGL/libEGL.vcxproj: Added.
- src/libEGL/libEGL.vcxproj.filters: Added.
- src/libGLESv2/Buffer.cpp:
(gl::Buffer::bufferData):
(gl::Buffer::bufferSubData):
(gl::Buffer::size):
(gl::Buffer::getIndexRangeCache):
- src/libGLESv2/Buffer.h:
- src/libGLESv2/Context.cpp:
(gl::Context::applyTextures):
(gl::Context::getBoundFramebufferTextureSerials):
- src/libGLESv2/Context.h:
(gl::Context::getRenderer):
- src/libGLESv2/Framebuffer.h:
- src/libGLESv2/ProgramBinary.cpp:
(gl::DiscardWorkaround):
(gl::ProgramBinary::load):
(gl::ProgramBinary::link):
(gl::ProgramBinary::linkAttributes):
(gl::AttributeSorter::AttributeSorter):
(gl::ProgramBinary::initAttributesByLayout):
(gl::ProgramBinary::sortAttributesByLayout):
- src/libGLESv2/ProgramBinary.h:
- src/libGLESv2/Renderbuffer.cpp:
(gl::RenderbufferTexture2D::getTextureSerial):
(gl::RenderbufferTextureCubeMap::getTextureSerial):
(gl::Renderbuffer::getTextureSerial):
- src/libGLESv2/Renderbuffer.h:
(gl::RenderbufferStorage::getTextureSerial):
- src/libGLESv2/Shader.cpp:
(gl::Shader::parseVaryings):
(gl::Shader::uncompile):
- src/libGLESv2/Shader.h:
- src/libGLESv2/Texture.cpp:
(gl::TextureCubeMap::storage):
- src/libGLESv2/Uniform.cpp:
(gl::Uniform::Uniform):
(gl::Uniform::~Uniform):
(gl::Uniform::isArray):
(gl::Uniform::elementCount):
- src/libGLESv2/Uniform.h:
- src/libGLESv2/constants.h: Removed.
- src/libGLESv2/libGLESv2.def:
- src/libGLESv2/libGLESv2.rc:
- src/libGLESv2/libGLESv2.vcxproj: Added.
- src/libGLESv2/libGLESv2.vcxproj.filters: Added.
- src/libGLESv2/precompiled.h:
- src/libGLESv2/renderer/Image11.cpp:
(rx::Image11::generateMipmap):
(rx::Image11::loadData):
(rx::Image11::loadCompressedData):
(rx::Image11::copy):
(rx::Image11::createStagingTexture):
(rx::Image11::map):
- src/libGLESv2/renderer/Image11.h:
- src/libGLESv2/renderer/IndexBuffer.cpp:
(rx::IndexBufferInterface::mapBuffer):
(rx::StaticIndexBufferInterface::getIndexRangeCache):
- src/libGLESv2/renderer/IndexBuffer.h:
- src/libGLESv2/renderer/IndexBuffer11.cpp:
(rx::IndexBuffer11::mapBuffer):
- src/libGLESv2/renderer/IndexDataManager.cpp:
(rx::IndexDataManager::prepareIndexData):
(rx::IndexDataManager::getCountingIndices):
- src/libGLESv2/renderer/IndexRangeCache.cpp: Added.
(rx::IndexRangeCache::addRange):
(rx::IndexRangeCache::invalidateRange):
(rx::IndexRangeCache::findRange):
(rx::IndexRangeCache::clear):
(rx::IndexRangeCache::IndexRange::IndexRange):
(rx::IndexRangeCache::IndexRange::operator<):
(rx::IndexRangeCache::IndexBounds::IndexBounds):
- src/libGLESv2/renderer/IndexRangeCache.h: Added.
- src/libGLESv2/renderer/InputLayoutCache.cpp:
(rx::InputLayoutCache::InputLayoutCache):
(rx::InputLayoutCache::clear):
(rx::InputLayoutCache::markDirty):
(rx::InputLayoutCache::applyVertexBuffers):
(rx::InputLayoutCache::hashInputLayout):
(rx::InputLayoutCache::compareInputLayouts):
- src/libGLESv2/renderer/InputLayoutCache.h:
(rx::InputLayoutCache::InputLayoutKey::begin):
(rx::InputLayoutCache::InputLayoutKey::end):
- src/libGLESv2/renderer/RenderTarget11.cpp:
(rx::RenderTarget11::getTexture):
(rx::RenderTarget11::getRenderTargetView):
(rx::RenderTarget11::getDepthStencilView):
(rx::RenderTarget11::getShaderResourceView):
- src/libGLESv2/renderer/RenderTarget11.h:
- src/libGLESv2/renderer/Renderer.cpp:
(rx::Renderer::initializeCompiler):
- src/libGLESv2/renderer/Renderer.h:
- src/libGLESv2/renderer/Renderer11.cpp:
(rx::Renderer11::initialize):
(rx::Renderer11::applyPrimitiveType):
(rx::Renderer11::applyRenderTarget):
(rx::Renderer11::drawLineLoop):
(rx::Renderer11::drawTriangleFan):
(rx::Renderer11::applyUniforms):
(rx::Renderer11::clear):
(rx::Renderer11::markAllStateDirty):
(rx::Renderer11::copyImage):
(rx::Renderer11::compileToExecutable):
(rx::Renderer11::getRenderTargetResource):
(rx::Renderer11::blitRenderbufferRect):
- src/libGLESv2/renderer/Renderer11.h:
- src/libGLESv2/renderer/Renderer9.cpp:
(rx::Renderer9::initialize):
(rx::Renderer9::setViewport):
(rx::Renderer9::drawLineLoop):
(rx::Renderer9::compileToExecutable):
- src/libGLESv2/renderer/Renderer9.h:
- src/libGLESv2/renderer/SwapChain.h:
- src/libGLESv2/renderer/SwapChain11.cpp:
(rx::SwapChain11::resetOffscreenTexture):
(rx::SwapChain11::reset):
(rx::SwapChain11::swapRect):
- src/libGLESv2/renderer/SwapChain9.cpp:
(rx::convertInterval):
- src/libGLESv2/renderer/TextureStorage11.cpp:
(rx::TextureStorage11::IsTextureFormatRenderable):
(rx::TextureStorage11::generateMipmapLayer):
(rx::TextureStorage11_Cube::getRenderTarget):
- src/libGLESv2/renderer/VertexBuffer.cpp:
(rx::VertexBufferInterface::storeVertexAttributes):
(rx::VertexBufferInterface::storeRawData):
(rx::VertexBufferInterface::reserveVertexSpace):
(rx::StaticVertexBufferInterface::lookupAttribute):
(rx::StaticVertexBufferInterface::storeVertexAttributes):
- src/libGLESv2/renderer/VertexBuffer.h:
- src/libGLESv2/renderer/VertexBuffer11.cpp:
(rx::VertexBuffer11::getSpaceRequired):
- src/libGLESv2/renderer/VertexBuffer11.h:
- src/libGLESv2/renderer/VertexBuffer9.cpp:
(rx::VertexBuffer9::storeVertexAttributes):
(rx::VertexBuffer9::getSpaceRequired):
(rx::VertexBuffer9::requiresConversion):
(rx::VertexBuffer9::getVertexSize):
(rx::VertexBuffer9::spaceRequired):
- src/libGLESv2/renderer/VertexBuffer9.h:
- src/libGLESv2/renderer/VertexDataManager.cpp:
(rx::elementsInBuffer):
(rx::StreamingBufferElementCount):
(rx::VertexDataManager::prepareVertexData):
- src/libGLESv2/renderer/VertexDataManager.h:
- src/libGLESv2/renderer/renderer11_utils.cpp:
(gl_d3d11::ConvertTextureFormat):
- src/libGLESv2/renderer/shaders/compiled/clear11vs.h:
- src/libGLESv2/renderer/shaders/compiled/clearmultiple11ps.h:
- src/libGLESv2/renderer/shaders/compiled/clearsingle11ps.h:
- src/libGLESv2/renderer/shaders/compiled/componentmaskps.h:
- src/libGLESv2/renderer/shaders/compiled/flipyvs.h:
- src/libGLESv2/renderer/shaders/compiled/luminanceps.h:
- src/libGLESv2/renderer/shaders/compiled/passthrough11vs.h:
- src/libGLESv2/renderer/shaders/compiled/passthroughlum11ps.h:
- src/libGLESv2/renderer/shaders/compiled/passthroughlumalpha11ps.h:
- src/libGLESv2/renderer/shaders/compiled/passthroughps.h:
- src/libGLESv2/renderer/shaders/compiled/passthroughrgb11ps.h:
- src/libGLESv2/renderer/shaders/compiled/passthroughrgba11ps.h:
- src/libGLESv2/renderer/shaders/compiled/standardvs.h:
- src/libGLESv2/renderer/shaders/generate_shaders.bat:
- src/libGLESv2/utilities.cpp:
(gl::ComputeTypeSize):
- src/libGLESv2/utilities.h:
- src/third_party/murmurhash/MurmurHash3.cpp:
(rotl32):
(rotl64):
(getblock):
(fmix):
(MurmurHash3_x86_32):
(MurmurHash3_x86_128):
(MurmurHash3_x64_128):
- src/third_party/murmurhash/MurmurHash3.h:
- src/third_party/trace_event: Added.
- src/third_party/trace_event/trace_event.h: Added.
(gl::TraceEvent::TraceID::TraceID):
(gl::TraceEvent::TraceID::data):
(gl::TraceEvent::TraceStringWithCopy::TraceStringWithCopy):
(gl::TraceEvent::TraceStringWithCopy::operator const char* ):
(gl::TraceEvent::setTraceValue):
(gl::TraceEvent::addTraceEvent):
(gl::TraceEvent::TraceEndOnScopeClose::TraceEndOnScopeClose):
(gl::TraceEvent::TraceEndOnScopeClose::~TraceEndOnScopeClose):
(gl::TraceEvent::TraceEndOnScopeClose::initialize):
(gl::TraceEvent::TraceEndOnScopeClose::addEventIfEnabled):
(gl::TraceEvent::SamplingStateScope::SamplingStateScope):
(gl::TraceEvent::SamplingStateScope::~SamplingStateScope):
(gl::TraceEvent::SamplingStateScope::current):
(gl::TraceEvent::SamplingStateScope::set):
- 1:12 AM Changeset in webkit [162314] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/ThirdParty/ANGLE
Merge r158807 - kTraceBufferLen is unused in default builds
https://bugs.webkit.org/show_bug.cgi?id=123941
<rdar://problem/15409804>
Reviewed by Tim Horton.
kTraceBufferLen is not used in debug.cpp if TRACE_ENABLED is
not defined. This causes a warning in newer builds of clang.
For now, skip warnings on unused variables until we
update from ANGLE.
- src/compiler/debug.cpp: Add unused-variable ignore pragma.
- 1:02 AM Changeset in webkit [162313] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore
Merge r160269 - ubuntu software center hits _XReadEvents() error
https://bugs.webkit.org/show_bug.cgi?id=123480
Reviewed by Martin Robinson.
- platform/gtk/WidgetBackingStoreGtkX11.cpp:
(WebCore::WidgetBackingStoreGtkX11::~WidgetBackingStoreGtkX11): clear the surface
before freeing the associated pixmap.
- 12:58 AM Changeset in webkit [162312] by
-
- 3 edits2 adds in trunk
Region based multicol: tall line causes taller multicol container than necessary
https://bugs.webkit.org/show_bug.cgi?id=122550
Source/WebCore:
Detect and report all column breaks, also when there's no pagination strut involved.
This may end up becoming the overall smallest space shortage in some cases,
so we need to report it, to avoid column height over-stretching.
Patch by Morten Stenshorne <mstensho@opera.com> on 2014-01-20
Reviewed by David Hyatt.
Test: fast/multicol/newmulticol/balance10.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
LayoutTests:
Patch by Morten Stenshorne <mstensho@opera.com> on 2014-01-20
Reviewed by David Hyatt.
- fast/multicol/newmulticol/balance10-expected.txt: Added.
- fast/multicol/newmulticol/balance10.html: Added.
- 12:57 AM Changeset in webkit [162311] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2
Merge r160215 - [GTK] Enable web audio by default
https://bugs.webkit.org/show_bug.cgi?id=124888
Reviewed by Martin Robinson.
When building with ./configure, enable_web_audio defaults to
"no". However the basic functionality has been working for months
so it's safe to enable it now.
- Source/autotools/ReadCommandLineArguments.m4:
- 12:57 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:52 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:49 AM Changeset in webkit [162310] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Tools
Merge r158866 - [Gtk] Disable LTO when building cairo
https://bugs.webkit.org/show_bug.cgi?id=123954
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-07
Reviewed by Martin Robinson.
Cairo always uses LTO, when it detects compiler support.
LTO is buggy in many/all versions of GCC and shouldn't be enabled by
default. This patch disables LTO when building cairo library.
With gcc 4.7.3, for example, the build fails with the following message:
'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
- gtk/jhbuild.modules:
- 12:46 AM Changeset in webkit [162309] by
-
- 3 edits1 move1 add in releases/WebKitGTK/webkit-2.2
Merge r154736 - Http tests fails on Debian with Apache 2.4
https://bugs.webkit.org/show_bug.cgi?id=120352
Reviewed by Andreas Kling.
Tools:
Select httpd.conf file for debian based on version, matching Fedora behavior.
- Scripts/webkitpy/port/base.py:
(Port._apache_config_file_name_for_platform):
LayoutTests:
Added an apache 2.4 configuration file adapted from Fedora's,
and renamed the 2.2 file to have consistent naming.
- http/conf/debian-httpd-2.2.conf: Renamed from LayoutTests/http/conf/apache2-debian-httpd.conf.
- http/conf/debian-httpd-2.4.conf: Added.
- 12:43 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:40 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:38 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:37 AM Changeset in webkit [162308] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore
Merge r160354 - [GTK] REGRESSION: www.yahoo.com redirects to the mobile version after UA change
https://bugs.webkit.org/show_bug.cgi?id=125444
Reviewed by Martin Robinson.
- platform/gtk/UserAgentGtk.cpp:
(WebCore::platformVersionForUAString): more correctly pretend we're Mac OS X.
(WebCore::standardUserAgent): ditto.
- 12:35 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:28 AM Changeset in webkit [162307] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed. Additional build fixes after r162276 and r163304.
- Platform/WorkQueue.h:
- Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::EventSource::EventSource):
(WorkQueue::dispatchOnSource):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):
- 12:01 AM Changeset in webkit [162306] by
-
- 4 edits in trunk/Source
[GLIB] GVariant floating references are not correctly handled by GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=127246
Reviewed by Martin Robinson.
Source/WebCore:
Do not adopt GVariant floating references, they will be converted
to a full reference by GRefPtr.
- platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::fillSelectionData):
(WebCore::PasteboardHelper::fillDataObjectFromDropData):
Source/WTF:
GRefPtr should always use g_variant_ref_sink to deal with GVariant
floating references. In case of full references,
g_variant_ref_sink calls g_variant_ref, so it's safe to use it always.
- wtf/gobject/GRefPtr.cpp:
(WTF::refGPtr): Use g_variant_ref_sink().
Jan 19, 2014:
- 11:25 PM Changeset in webkit [162305] by
-
- 2 edits in trunk/Source/WebCore
Use unsigned type for the size of CSSParserValueList
https://bugs.webkit.org/show_bug.cgi?id=127211
Reviewed by Andreas Kling.
- css/CSSParser.cpp: Changed variable type from int to unsigned.
(WebCore::CSSParser::parseValue):
- 11:03 PM Changeset in webkit [162304] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed GTK build fix after r162276.
Updating the WorkQueue implementation to use std::function and std::chrono.
- Platform/WorkQueue.h:
- Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::dispatchOnSource):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):
- 10:44 PM Changeset in webkit [162303] by
-
- 8 edits in trunk
[EFL][WK1] Remove and refactor the APIs which use single and base keyword
https://bugs.webkit.org/show_bug.cgi?id=127214
Reviewed by Gyuyoung Kim.
Source/WebKit/efl:
Since removed ewk_vie_tiled, we don't need to use single or base in the API name.
Removed them and clean up the code.
- ewk/ewk_view.cpp:
(ewk_view_smart_set):
(_ewk_view_smart_class_new):
(ewk_view_add):
- ewk/ewk_view.h:
- ewk/ewk_view_private.h:
Removed the class names and macro to distinguish single or tiled.
- tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::init):
Tools:
Followed the changes of API.
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(drtViewAdd):
- EWebLauncher/main.c:
(windowCreate):
- 10:34 PM Changeset in webkit [162302] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Add touch events option to MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=127262
Reviewed by Gyuyoung Kim.
As a default, touch events are disabled and mouse events are enabled.
If touch events option sets to true, touch events are enabled and mouse
events are disabled.
- MiniBrowser/efl/main.c:
(window_create):
(elm_main):
- 8:42 PM Changeset in webkit [162301] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed debug build fix on EFL port after r162300.
- Platform/efl/DispatchQueueWorkItemEfl.h:
(TimerWorkItem::create):
- 8:13 PM Changeset in webkit [162300] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] build fix after r162276
https://bugs.webkit.org/show_bug.cgi?id=127259
Reviewed by Anders Carlsson.
- Platform/efl/DispatchQueueEfl.cpp:
(DispatchQueue::performTimerWork):
(DispatchQueue::getNextTimeOut):
- Platform/efl/DispatchQueueWorkItemEfl.h:
(WorkItem::create):
(WorkItem::WorkItem):
(TimerWorkItem::create):
(TimerWorkItem::TimerWorkItem):
- Platform/efl/WorkQueueEfl.cpp:
(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):
- 5:26 PM Changeset in webkit [162299] by
-
- 6 edits2 adds in branches/jsCStack/Source/JavaScriptCore
FTL should ascribe range meta-data when loading array.length
https://bugs.webkit.org/show_bug.cgi?id=126543
Not yet reviewed.
The main thing this accomplishes is we now have Output::load32NonNegative() which is
a 32-bit integer load that promises that the value is not negative. We then use that
for all length loads.
But underneath that, we have the notion of ValueRange, which is a simplified
encapsulation of LLVM "range" metadata.
I considered making the range meta-data part of AbstractHeap. It would make sense
there. But considering that we just use this for basically one thing (the length), it
feels like conflating this with the AbstractHeap would result in some
overengineering. We should revisit this if we ever have other ranges.
- JavaScriptCore.xcodeproj/project.pbxproj:
- ftl/FTLCommonValues.cpp:
(JSC::FTL::CommonValues::CommonValues):
- ftl/FTLCommonValues.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileStringCharAt):
(JSC::FTL::LowerDFGToLLVM::compileStringCharCodeAt):
(JSC::FTL::LowerDFGToLLVM::compileSwitch):
(JSC::FTL::LowerDFGToLLVM::typedArrayLength):
(JSC::FTL::LowerDFGToLLVM::boolify):
(JSC::FTL::LowerDFGToLLVM::contiguousPutByValOutOfBounds):
- ftl/FTLOutput.h:
(JSC::FTL::Output::ascribeRange):
(JSC::FTL::Output::nonNegative32):
(JSC::FTL::Output::load32NonNegative):
- ftl/FTLValueRange.cpp: Added.
(JSC::FTL::ValueRange::decorateInstruction):
- ftl/FTLValueRange.h: Added.
(JSC::FTL::ValueRange::ValueRange):
(JSC::FTL::ValueRange::begin):
(JSC::FTL::ValueRange::end):
- 5:18 PM Changeset in webkit [162298] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r162293
Fix debug build.
[ 13%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/html/parser/HTMLTreeBuilder.cpp.o
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp: In member function ‘void WebCore::HTMLTreeBuilder::processStartTagForInTable(WebCore::AtomicHTMLToken*)’:
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: error: no match for ‘operator!’ in ‘!(WebCore::HTMLTreeBuilder::InsertionMode)12’
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note: candidate is:
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note: operator!(bool) <built-in>
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note: no known conversion for argument 1 from ‘WebCore::HTMLTreeBuilder::InsertionMode’ to ‘bool’
make[2]: * [Source/WebCore/CMakeFiles/WebCore.dir/html/parser/HTMLTreeBuilder.cpp.o] Error 1
make[1]: * [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2
make: * [all] Error 2
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInTable): Fix ASSERT.
- 4:07 PM Changeset in webkit [162297] by
-
- 3 edits in trunk/Tools
Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
https://bugs.webkit.org/show_bug.cgi?id=126080
Reviewed by Sam Weinig.
This changes the output of printing LayoutUnits to be in px but it also
preserves the original LayoutUnit value.
This will lead to lldb output like: (and it works even when subpixel is disabled)
(const WebCore::LayoutRect) $0 = {
m_location = { x = 2.25px (144), y = 1px (64)}
m_size = { width = 13.75px (880), height = 20px (1280) }
And gdb output like:
m_frameRect = {
m_location = LayoutPoint(0px (0), 0px(0)),
m_size = LayoutSize(8px (512), 5px (320))
}
This patch is based on patch by Bem Jones-Bey and for Blink by cbiesinger@chromium.org.
- gdb/webkit.py:
(WebCoreLayoutUnitPrinter):
(WebCoreLayoutUnitPrinter.init):
(WebCoreLayoutUnitPrinter.to_string):
(WebCoreLayoutSizePrinter):
(WebCoreLayoutSizePrinter.init):
(WebCoreLayoutSizePrinter.to_string):
(WebCoreLayoutPointPrinter):
(WebCoreLayoutPointPrinter.init):
(WebCoreLayoutPointPrinter.to_string):
(add_pretty_printers):
- lldb/lldb_webkit.py:
(lldb_init_module):
(WebCoreLayoutUnit_SummaryProvider):
(WebCoreLayoutSize_SummaryProvider):
(WebCoreLayoutPoint_SummaryProvider):
(WebCoreLayoutUnitProvider):
(WebCoreLayoutUnitProvider.init):
(WebCoreLayoutUnitProvider.to_string):
(WebCoreLayoutSizeProvider):
(WebCoreLayoutSizeProvider.init):
(WebCoreLayoutSizeProvider.get_width):
(WebCoreLayoutSizeProvider.get_height):
(WebCoreLayoutPointProvider):
(WebCoreLayoutPointProvider.init):
(WebCoreLayoutPointProvider.get_x):
(WebCoreLayoutPointProvider.get_y):
- 12:37 PM Changeset in webkit [162296] by
-
- 17 edits in trunk/Source/WebCore
Stop using MutexTryLocker in WebCore
https://bugs.webkit.org/show_bug.cgi?id=127254
Reviewed by Andreas Kling.
Instead use std::mutex and std::unique_lock with the std::try_to_lock constructor.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::setBuffer):
- Modules/webaudio/AudioBufferSourceNode.h:
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::insertEvent):
(WebCore::AudioParamTimeline::cancelScheduledValues):
(WebCore::AudioParamTimeline::valueForContextTime):
(WebCore::AudioParamTimeline::valuesForTimeRange):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
- Modules/webaudio/AudioParamTimeline.h:
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::process):
(WebCore::ConvolverNode::reset):
(WebCore::ConvolverNode::setBuffer):
- Modules/webaudio/ConvolverNode.h:
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::setFormat):
(WebCore::MediaElementAudioSourceNode::process):
(WebCore::MediaElementAudioSourceNode::lock):
(WebCore::MediaElementAudioSourceNode::unlock):
- Modules/webaudio/MediaElementAudioSourceNode.h:
- Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::setFormat):
(WebCore::MediaStreamAudioSourceNode::process):
- Modules/webaudio/MediaStreamAudioSourceNode.h:
- Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::process):
(WebCore::OscillatorNode::setPeriodicWave):
- Modules/webaudio/OscillatorNode.h:
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::process):
(WebCore::PannerNode::setPanningModel):
- Modules/webaudio/PannerNode.h:
- Modules/webaudio/WaveShaperProcessor.cpp:
(WebCore::WaveShaperProcessor::setCurve):
(WebCore::WaveShaperProcessor::setOversample):
(WebCore::WaveShaperProcessor::process):
- Modules/webaudio/WaveShaperProcessor.h:
- 11:13 AM Changeset in webkit [162295] by
-
- 2 edits in trunk/Source/WebCore
Does not build with SVG disabled
https://bugs.webkit.org/show_bug.cgi?id=127248
Reviewed by Sam Weinig.
Add missing #if ENABLE(SVG) guard.
- dom/ElementData.h:
- 11:00 AM Changeset in webkit [162294] by
-
- 3 edits in trunk/LayoutTests
Unreviewed Apple Windows port gardering.
A few more missing newlines.
- platform/win/svg/batik/masking/maskRegions-expected.txt:
- platform/win/svg/batik/text/textPosition-expected.txt:
- 11:00 AM Changeset in webkit [162293] by
-
- 3 edits in trunk/Source/WebCore
Use a strong enum for HTMLTreeBuilder::InsertionMode
https://bugs.webkit.org/show_bug.cgi?id=127252
Reviewed by Antti Koivisto.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::constructTree):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processTemplateStartTag):
(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::closeTheCell):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption):
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::defaultForInitial):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
- html/parser/HTMLTreeBuilder.h:
- 10:42 AM Changeset in webkit [162292] by
-
- 3 edits in trunk/Source/WebCore
Convert LoaderRunLoopCF.cpp and WebCoreThreadRun.cpp over to modern threading primitives
https://bugs.webkit.org/show_bug.cgi?id=127251
Reviewed by Antti Koivisto.
Also add a condition to the loaderRunLoop() function to protect against spurious wake-ups.
- platform/ios/wak/WebCoreThreadRun.cpp:
- platform/network/cf/LoaderRunLoopCF.cpp:
(WebCore::loaderRunLoopMutex):
(WebCore::loaderRunLoopConditionVariable):
(WebCore::runLoaderThread):
(WebCore::loaderRunLoop):
- 10:20 AM Changeset in webkit [162291] by
-
- 3 edits in trunk/Source/WebCore
Modernize ReverbConvolver
https://bugs.webkit.org/show_bug.cgi?id=127250
Reviewed by Andreas Kling.
Use std::unique_ptr instead of OwnPtr and the STL threading primitives instead of the WTF ones.
- platform/audio/ReverbConvolver.cpp:
(WebCore::ReverbConvolver::ReverbConvolver):
(WebCore::ReverbConvolver::~ReverbConvolver):
(WebCore::ReverbConvolver::backgroundThreadEntry):
(WebCore::ReverbConvolver::process):
- platform/audio/ReverbConvolver.h:
Jan 18, 2014:
- 10:53 PM Changeset in webkit [162290] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Rename GestureEventIOS.{cpp,h} to GestureEvent.{cpp,h} to fix the build
InFilesCompiler.pm assumes that <interface name>.h exists for each
interface it processes. We renamed GestureEvent.h to GestureEventIOS.h
but kept the interface named GestureEvent, so a non-existant file was
being referenced by InFilesCompiler.pm (this was hard to detect since
GestureEvent.h still existed in the SDK due to not having submitted
WebKitAdditions recently).
Since we cannot rename the GestureEvent interface, and since there is
no conflicting GestureEvent in open source, we can just rename
GestureEventIOS.{cpp,h} back to GestureEvent.{cpp,h}.
- dom/ios/TouchEvents.cpp: Updated to include GestureEvent.cpp.
- 10:47 PM Changeset in webkit [162289] by
-
- 2 edits in trunk/Tools
Add robots.txt to http://webkit-queues.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=127240
- QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
- 10:43 PM Changeset in webkit [162288] by
-
- 2 edits1 add in trunk/Tools
Add robots.txt to http://webkit-queues.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=127240
Reviewed by Ryosuke Niwa.
- QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
- QueueStatusServer/robots.txt: Added.
- 10:39 PM Changeset in webkit [162287] by
-
- 2 edits in trunk/Source/WebCore
Memory leak in JSSubtleCrypto::wrapKey
https://bugs.webkit.org/show_bug.cgi?id=127241
Reviewed by Sam Weinig.
- bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::wrapKey):
Delete algorithmPtr and parametersPtr that aren't smart pointers because of lambdas.
- 9:16 PM Changeset in webkit [162286] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS Production build.
- Configurations/WebCore.xcconfig:
- 6:32 PM Changeset in webkit [162285] by
-
- 48 edits in trunk/LayoutTests
Unreviewed Apple Windows port gardering.
Add missing newlines.
- platform/win/css1/box_properties/margin_right-expected.txt:
- platform/win/css1/box_properties/padding-expected.txt:
- platform/win/css1/box_properties/padding_left-expected.txt:
- platform/win/css1/box_properties/padding_right-expected.txt:
- platform/win/css1/box_properties/padding_top-expected.txt:
- platform/win/css1/font_properties/font-expected.txt:
- platform/win/css1/formatting_model/vertical_formatting-expected.txt:
- platform/win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/win/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
- platform/win/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
- platform/win/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
- platform/win/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
- platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
- platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
- platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
- platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
- platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
- platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
- platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
- platform/win/fast/borders/bidi-012-expected.txt:
- platform/win/fast/css/empty-pseudo-class-expected.txt:
- platform/win/fast/css/fieldset-display-row-expected.txt:
- platform/win/fast/css/first-child-pseudo-class-expected.txt:
- platform/win/fast/css/last-child-pseudo-class-expected.txt:
- platform/win/fast/css/only-child-pseudo-class-expected.txt:
- platform/win/fast/forms/file/file-input-disabled-expected.txt:
- platform/win/fast/inline/inline-box-background-expected.txt:
- platform/win/fast/inline/inline-box-background-long-image-expected.txt:
- platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
- platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:
- platform/win/fast/lists/003-vertical-expected.txt:
- platform/win/fast/multicol/vertical-rl/float-multicol-expected.txt:
- platform/win/fast/multicol/vertical-rl/nested-columns-expected.txt:
- platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
- platform/win/svg/batik/filters/feTile-expected.txt:
- platform/win/svg/batik/masking/maskRegions-expected.txt:
- platform/win/svg/batik/paints/gradientLimit-expected.txt:
- platform/win/svg/batik/text/textDecoration-expected.txt:
- platform/win/svg/batik/text/textEffect-expected.txt:
- platform/win/svg/batik/text/textLength-expected.txt:
- platform/win/svg/batik/text/textPosition-expected.txt:
- platform/win/svg/batik/text/verticalText-expected.txt:
- platform/win/transforms/2d/hindi-rotated-expected.txt:
- 5:11 PM Changeset in webkit [162284] by
-
- 3 edits in trunk/Source/JavaScriptCore
CodeBlock: Size m_callLinkInfos and m_byValInfos to fit earlier.
<https://webkit.org/b/127239>
Reviewed by Anders Carlsson.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::setNumberOfByValInfos):
(JSC::CodeBlock::setNumberOfCallLinkInfos):
Use resizeToFit() instead of grow() for these vectors, since
we know the final size here.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shrinkToFit):
No need to shrink here anymore. We were not even shrinking
m_byValInfo before!
- 3:59 PM Changeset in webkit [162283] by
-
- 2 edits in trunk/Tools
Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
https://bugs.webkit.org/show_bug.cgi?id=127217
Reviewed by Daniel Bates.
The syntax File::Temp->tempdir() was explicitly made invalid
following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
which was included in File::Temp v2.30, shipped with Perl v5.18.0.
Use File::Temp::tempdir() instead.
- Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
- 3:55 PM Changeset in webkit [162282] by
-
- 27 edits26 adds in trunk/LayoutTests
Unreviewed Apple Windows port gardering.
Rebaseline subpixel layout results.
- platform/win/TestExpectations:
- platform/win/css1/box_properties/margin_right-expected.txt: Added.
- platform/win/css1/box_properties/padding-expected.txt: Added.
- platform/win/css1/box_properties/padding_left-expected.txt: Added.
- platform/win/css1/box_properties/padding_right-expected.txt: Added.
- platform/win/css1/box_properties/padding_top-expected.txt: Added.
- platform/win/css1/font_properties/font-expected.txt:
- platform/win/css1/formatting_model/vertical_formatting-expected.txt: Added.
- platform/win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt: Added.
- platform/win/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt: Added.
- platform/win/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt: Added.
- platform/win/css2.1/t0804-c5510-padn-00-b-ag-expected.txt: Added.
- platform/win/css2.1/t0905-c414-flt-wrap-00-e-expected.txt: Added.
- platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
- platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
- platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
- platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
- platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
- platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
- platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
- platform/win/fast/borders/bidi-012-expected.txt:
- platform/win/fast/css/empty-pseudo-class-expected.txt: Added.
- platform/win/fast/css/fieldset-display-row-expected.txt: Added.
- platform/win/fast/css/first-child-pseudo-class-expected.txt: Added.
- platform/win/fast/css/last-child-pseudo-class-expected.txt: Added.
- platform/win/fast/css/only-child-pseudo-class-expected.txt: Added.
- platform/win/fast/forms/file/file-input-disabled-expected.txt:
- platform/win/fast/forms/range/slider-mouse-events-expected.txt:
- platform/win/fast/inline/inline-box-background-expected.txt:
- platform/win/fast/inline/inline-box-background-long-image-expected.txt:
- platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
- platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:
- platform/win/fast/lists/003-vertical-expected.txt:
- platform/win/fast/multicol/vertical-rl/float-multicol-expected.txt:
- platform/win/fast/multicol/vertical-rl/nested-columns-expected.txt:
- platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
- platform/win/svg/batik/filters/feTile-expected.txt: Added.
- platform/win/svg/batik/masking/maskRegions-expected.txt: Added.
- platform/win/svg/batik/paints/gradientLimit-expected.txt:
- platform/win/svg/batik/text/textDecoration-expected.txt: Added.
- platform/win/svg/batik/text/textEffect-expected.txt: Added.
- platform/win/svg/batik/text/textLength-expected.txt: Added.
- platform/win/svg/batik/text/textPosition-expected.txt: Added.
- platform/win/svg/batik/text/verticalText-expected.txt: Added.
- platform/win/transforms/2d/hindi-rotated-expected.txt:
- 3:35 PM Changeset in webkit [162281] by
-
- 2 edits in trunk/Source/JavaScriptCore
CodeBlock: Size m_function{Exprs,Decls} to fit from creation.
<https://webkit.org/b/127238>
Reviewed by Anders Carlsson.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
Use resizeToFit() instead of grow() for m_functionExprs and
m_functionDecls since we know they will never change size.
(JSC::CodeBlock::shrinkToFit):
No need to shrink them here anymore.
- 3:31 PM Changeset in webkit [162280] by
-
- 19 edits in trunk/Source/WebCore
[CodeGeneratorJS] Sort output of StructureFlags and function parameters
https://bugs.webkit.org/show_bug.cgi?id=127226
Reviewed by Alexey Proskuryakov.
The order of the keys in a hash is undefined and subject to change
between different Perl versions, so we have to sort them to make
sure that the output is always the same.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateParametersCheckExpression):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
- bindings/scripts/test/JS/JSTestEventConstructor.h:
- bindings/scripts/test/JS/JSTestEventTarget.h:
- bindings/scripts/test/JS/JSTestException.h:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
- bindings/scripts/test/JS/JSTestNode.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
- bindings/scripts/test/JS/JSTestTypedefs.h:
- bindings/scripts/test/JS/JSattribute.h:
- bindings/scripts/test/JS/JSreadonly.h:
- 3:20 PM Changeset in webkit [162279] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove unused CodeBlock::m_additionalIdentifiers member.
<https://webkit.org/b/127237>
Reviewed by Anders Carlsson.
- bytecode/CodeBlock.h:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::shrinkToFit):
Remove m_additionalIdentifiers, nothing uses it.
- 3:10 PM Changeset in webkit [162278] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove two unused CodeBlock functions.
<https://webkit.org/b/127235>
Kill copyPostParseDataFrom() and copyPostParseDataFromAlternative()
since they are not used.
Reviewed by Anders Carlsson.
- bytecode/CodeBlock.cpp:
- bytecode/CodeBlock.h:
- 3:09 PM Changeset in webkit [162277] by
-
- 3 edits in trunk/Source/JavaScriptCore
CodeBlock: Size m_exceptionHandlers to fit from creation.
<https://webkit.org/b/127234>
Avoid allocation churn for CodeBlock::m_exceptionHandlers.
Reviewed by Anders Carlsson.
- bytecode/CodeBlock.h:
Removed unused CodeBlock::allocateHandlers() function.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
Use resizeToFit() instead of grow() for m_exceptionHandlers
since we know it's never going to change size.
(JSC::CodeBlock::shrinkToFit):
No need to shrink m_exceptionHandlers here since it's already
the perfect size.
- 3:00 PM Changeset in webkit [162276] by
-
- 15 edits in trunk/Source
Replace a couple of uses of WTF::Function with std::function
https://bugs.webkit.org/show_bug.cgi?id=127218
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::dispatch):
(WebCore::ScrollingThread::dispatchBarrier):
(WebCore::ScrollingThread::shared):
(WebCore::ScrollingThread::createThreadIfNeeded):
(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):
- page/scrolling/ScrollingThread.h:
- page/scrolling/mac/ScrollingThreadMac.mm:
(WebCore::ScrollingThread::initializeRunLoop):
Source/WebKit2:
- Platform/IPC/mac/ConnectionMac.cpp:
(IPC::createDataAvailableSource):
- Platform/WorkQueue.h:
- Platform/mac/WorkQueueMac.cpp:
(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):
- Shared/ChildProcess.cpp:
(WebKit::didCloseOnConnectionWorkQueue):
- UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::scheduleDatabaseUpdate):
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
- 2:48 PM Changeset in webkit [162275] by
-
- 25 edits in trunk/Source/WebCore
Modernize HTML parser code
https://bugs.webkit.org/show_bug.cgi?id=127236
Reviewed by Andreas Kling.
- html/parser/AtomicHTMLToken.h:
- html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::emitRule):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::detach):
(WebCore::HTMLDocumentParser::stopParsing):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
- html/parser/HTMLDocumentParser.h:
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::pushCommon):
- html/parser/HTMLElementStack.h:
(WebCore::HTMLElementStack::ElementRecord::releaseNext):
(WebCore::HTMLElementStack::ElementRecord::setNext):
- html/parser/HTMLMetaCharsetParser.cpp:
(WebCore::HTMLMetaCharsetParser::HTMLMetaCharsetParser):
- html/parser/HTMLMetaCharsetParser.h:
- html/parser/HTMLParserScheduler.h:
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
- html/parser/HTMLPreloadScanner.h:
- html/parser/HTMLResourcePreloader.cpp:
(WebCore::HTMLResourcePreloader::takeAndPreload):
(WebCore::HTMLResourcePreloader::preload):
- html/parser/HTMLResourcePreloader.h:
(WebCore::PreloadRequest::PreloadRequest):
- html/parser/HTMLScriptRunner.h:
- html/parser/HTMLToken.h:
(WebCore::HTMLToken::beginDOCTYPE):
(WebCore::HTMLToken::releaseDoctypeData):
- html/parser/HTMLTokenizer.h:
- html/parser/HTMLTreeBuilder.h:
- html/parser/HTMLViewSourceParser.cpp:
(WebCore::HTMLViewSourceParser::HTMLViewSourceParser):
- html/parser/HTMLViewSourceParser.h:
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
- html/parser/XSSAuditor.h:
- html/parser/XSSAuditorDelegate.h:
(WebCore::XSSInfo::XSSInfo):
- loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::checkForHeadCharset):
(WebCore::TextResourceDecoder::checkForMetaCharset):
- loader/TextResourceDecoder.h:
- 2:17 PM Changeset in webkit [162274] by
-
- 8 edits in trunk/Source/WebCore
Make ElementData JIT friendly
https://bugs.webkit.org/show_bug.cgi?id=127209
Reviewed by Geoffrey Garen.
The offsets of ElementData's flags were not accessible by the JIT. This patch
refactor ElementData to use explicit flags so that they can be used from
the code generators.
- dom/Element.cpp:
(WebCore::Element::synchronizeAllAttributes):
(WebCore::Element::synchronizeAttribute):
(WebCore::Element::attributeChanged):
(WebCore::Element::removeAttribute):
- dom/ElementData.cpp:
(WebCore::ElementData::destroy):
(WebCore::ElementData::ElementData):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::ElementData::arraySizeAndFlagsFromOther):
- dom/ElementData.h:
(WebCore::ElementData::hasName):
(WebCore::ElementData::isUnique):
(WebCore::ElementData::updateFlag):
(WebCore::ElementData::arraySize):
(WebCore::ElementData::setHasNameAttribute):
(WebCore::ElementData::styleAttributeIsDirty):
(WebCore::ElementData::setStyleAttributeIsDirty):
(WebCore::ElementData::presentationAttributeStyleIsDirty):
(WebCore::ElementData::setPresentationAttributeStyleIsDirty):
(WebCore::ElementData::animatedSVGAttributesAreDirty):
(WebCore::ElementData::setAnimatedSVGAttributesAreDirty):
(WebCore::ElementData::length):
(WebCore::ElementData::attributeBase):
(WebCore::ElementData::presentationAttributeStyle):
- dom/StyledElement.cpp:
(WebCore::StyledElement::synchronizeStyleAttributeInternal):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
- dom/StyledElement.h:
(WebCore::StyledElement::invalidateStyleAttribute):
(WebCore::StyledElement::presentationAttributeStyle):
- svg/SVGElement.cpp:
(WebCore::SVGElement::synchronizeAnimatedSVGAttribute):
- svg/SVGElement.h:
(WebCore::SVGElement::invalidateSVGAttributes):
- 1:24 PM Changeset in webkit [162273] by
-
- 4 edits in trunk
Subpixel layout: IntRect::infiniteRect() overflows when subpixel layout is enabled.
https://bugs.webkit.org/show_bug.cgi?id=126899
Reviewed by Tim Horton.
Use LayoutUnits when setting the infinite values on IntRect::infiniteRect() to ensure
it won't overflow later when the IntRect gets converted to LayoutRect.
Source/WebCore:
Covered by existing tests.
- platform/graphics/IntRect.h:
(WebCore::IntRect::infiniteRect):
LayoutTests:
- platform/mac/TestExpectations: Unskipping svg test (failed with subpixel on)
- 1:15 PM Changeset in webkit [162272] by
-
- 7 edits37 deletes in trunk
Remove support for the viewsource attribute
https://bugs.webkit.org/show_bug.cgi?id=127232
Reviewed by Andreas Kling.
Source/WebCore:
The 'viewsource' attribute on frames is nonstandard, not used by anyone (the inspector has
its own syntax highlighting) and not audited.
This patch removes parsing of the viewsource attribute and the associated tests. A subsequent
patch will remove the code as well.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseAttribute):
Source/WTF:
- wtf/FeatureDefines.h:
LayoutTests:
- .gitattributes:
- fast/frames/resources/viewsource-fake-image-file.png: Removed.
- fast/frames/resources/viewsource-frame-1.html: Removed.
- fast/frames/resources/viewsource-frame-2.html: Removed.
- fast/frames/resources/viewsource-frame-3.html: Removed.
- fast/frames/resources/viewsource-frame-4.html: Removed.
- fast/frames/resources/viewsource-frame-5.html: Removed.
- fast/frames/resources/viewsource-frame-unfinished-script.html: Removed.
- fast/frames/resources/viewsource-frame-unfinished-textarea.html: Removed.
- fast/frames/viewsource-attribute.html: Removed.
- fast/frames/viewsource-empty-attribute-value-expected.txt: Removed.
- fast/frames/viewsource-empty-attribute-value.html: Removed.
- fast/frames/viewsource-linebreak-expected.txt: Removed.
- fast/frames/viewsource-linebreak.html: Removed.
- fast/frames/viewsource-link-on-href-value-expected.txt: Removed.
- fast/frames/viewsource-link-on-href-value.html: Removed.
- fast/frames/viewsource-on-image-file.html: Removed.
- fast/frames/viewsource-plain-text-tags-expected.txt: Removed.
- fast/frames/viewsource-plain-text-tags.html: Removed.
- fast/frames/viewsource-unfinished-tags-expected.txt: Removed.
- fast/frames/viewsource-unfinished-tags.html: Removed.
- fast/frames/viewsource-xml-expected.txt: Removed.
- fast/frames/viewsource-xml.html: Removed.
- http/tests/security/resources/view-source-no-refresh.php: Removed.
- http/tests/security/view-source-javascript-url-in-document-expected.txt: Removed.
- http/tests/security/view-source-javascript-url-in-document.html: Removed.
- http/tests/security/view-source-no-javascript-url-expected.txt: Removed.
- http/tests/security/view-source-no-javascript-url.html: Removed.
- http/tests/security/view-source-no-refresh-expected.txt: Removed.
- http/tests/security/view-source-no-refresh.html: Removed.
- platform/efl/fast/frames/viewsource-attribute-expected.png: Removed.
- platform/efl/fast/frames/viewsource-attribute-expected.txt: Removed.
- platform/efl/fast/frames/viewsource-on-image-file-expected.png: Removed.
- platform/efl/fast/frames/viewsource-on-image-file-expected.txt: Removed.
- platform/mac/fast/frames/viewsource-attribute-expected.png: Removed.
- platform/mac/fast/frames/viewsource-attribute-expected.txt: Removed.
- platform/mac/fast/frames/viewsource-on-image-file-expected.png: Removed.
- platform/mac/fast/frames/viewsource-on-image-file-expected.txt: Removed.
- platform/win/TestExpectations:
- 1:14 PM Changeset in webkit [162271] by
-
- 31 edits2 copies in trunk/Source/WebKit2
Flesh out session APIs (still not enabled at API level).
https://bugs.webkit.org/show_bug.cgi?id=126918
Patch by Martin Hock <mhock@apple.com> on 2014-01-18
Reviewed by Alexey Proskuryakov.
- CMakeLists.txt:
- GNUmakefile.list.am:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::destroyPrivateBrowsingSession):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/RemoteNetworkingContext.h:
- NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
- NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
- Shared/SessionTracker.cpp: Copied from Source/WebKit2/UIProcess/APISession.cpp.
(WebKit::sessionMap):
(WebKit::identifierBase):
(WebKit::SessionTracker::getSessionMap):
(WebKit::SessionTracker::getIdentifierBase):
(WebKit::SessionTracker::session):
(WebKit::SessionTracker::destroySession):
(WebKit::SessionTracker::setIdentifierBase):
- Shared/SessionTracker.h: Copied from Source/WebKit2/UIProcess/APISession.h.
(WebKit::SessionTracker::isEphemeralID):
- Shared/mac/CookieStorageShim.cpp:
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):
- UIProcess/APISession.cpp:
(API::generateID):
(API::Session::defaultSession):
(API::Session::legacyPrivateSession):
(API::Session::Session):
(API::Session::create):
(API::Session::isEphemeral):
(API::Session::getID):
- UIProcess/APISession.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
- UIProcess/WebContext.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::sessionID):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage):
- UIProcess/WebProcessProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::legacySessionID):
(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):
- WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):
- WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 1:11 PM Changeset in webkit [162270] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add a hasBreakpointFlag arg to the op_debug bytecode.
https://bugs.webkit.org/show_bug.cgi?id=127230.
Reviewed by Geoffrey Garen.
This is in anticipation of upcoming changes to support bytecode level
breakpoints. This patch adds the flag to the op_debug bytecode and
initializes it, but does not use it yet.
- bytecode/Opcode.h:
(JSC::padOpcodeName):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
- llint/LowLevelInterpreter.asm:
- 12:35 PM Changeset in webkit [162269] by
-
- 6 edits in trunk/Source/WebCore
XMLTreeViewer shouldn't use the view source mode
https://bugs.webkit.org/show_bug.cgi?id=127229
Reviewed by Andreas Kling.
Add the relevant styles from view-source.css to XMLViewer.css.
- xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
- xml/XMLViewer.css:
(body):
(.comment):
(.tag):
(.attribute-name):
(.attribute-value):
- xml/XMLViewer.js:
(createComment):
(createTag):
(createAttribute):
- 12:32 PM Changeset in webkit [162268] by
-
- 5 edits in trunk/Source/WebKit
Another build fix attempt for Windows and EFL WebKit1.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/efl:
- ewk/ewk_paint_context.cpp:
(ewk_paint_context_paint_contents):
- ewk/ewk_view.cpp:
(_ewk_view_smart_repaints_process):
- 12:19 PM Changeset in webkit [162267] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build fix attempt for Windows.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 11:41 AM Changeset in webkit [162266] by
-
- 3 edits in trunk/Source/JavaScriptCore
JavaScriptCore uses PLATFORM(MAC) when it means OS(DARWIN)
https://bugs.webkit.org/show_bug.cgi?id=99683
Reviewed by Anders Carlsson.
- jit/ThunkGenerators.cpp:
- tools/CodeProfile.cpp:
(JSC::symbolName):
(JSC::CodeProfile::sample):
- 11:16 AM Changeset in webkit [162265] by
-
- 2 edits in trunk/Source/WebCore
Remove unused "touchDragDropEnabled" setting.
<https://webkit.org/b/127227>
Reviewed by Sam Weinig.
- page/Settings.in:
- 11:15 AM Changeset in webkit [162264] by
-
- 44 edits in trunk/Source
Web Inspector: Page should use std::unique_ptr for InspectorController
https://bugs.webkit.org/show_bug.cgi?id=127068
Reviewed by Joseph Pecoraro.
Source/WebCore:
Make Page and WorkerGlobalScope keep a std::unique_ptr to InspectorController
and WorkerInspectorController. Store page references and return controller
references where possible.
Convert call sites to use an InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
Convert InspectorOverlay to keep Page references.
- WebCore.exp.in:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsProfiling):
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
- dom/Node.cpp:
(WebCore::Node::inspect):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::setInspectorFrontendClient):
(WebCore::InspectorController::hasInspectorFrontendClient):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::inspectedPage):
(WebCore::InspectorController::developerExtrasEnabled):
- inspector/InspectorController.h:
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::canAttachWindow):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowWidth):
(WebCore::InspectorFrontendClientLocal::openInNewTab):
(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::highlightQuad):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):
(WebCore::InspectorOverlay::drawQuadHighlight):
(WebCore::InspectorOverlay::overlayPage):
(WebCore::InspectorOverlay::reset):
- inspector/InspectorOverlay.h:
- inspector/InstrumentingAgents.cpp:
(WebCore::instrumentationForPage): remove null checks.
(WebCore::instrumentationForWorkerGlobalScope): remove null checks.
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
- inspector/WorkerInspectorController.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::showContextMenu):
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::addInspectElementItem):
- page/FrameView.cpp:
(WebCore::FrameView::sendResizeEventIfNeeded):
- page/Page.cpp:
(WebCore::Page::Page):
- page/Page.h:
(WebCore::Page::inspectorController):
- page/PageDebuggable.cpp:
(WebCore::PageDebuggable::hasLocalDebugger):
(WebCore::PageDebuggable::parentProcessIdentifier):
(WebCore::PageDebuggable::connect):
(WebCore::PageDebuggable::disconnect):
(WebCore::PageDebuggable::dispatchMessageFromRemoteFrontend):
(WebCore::PageDebuggable::setIndicating):
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::syncDisplayState):
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::inspectorHighlightObject):
(WebCore::Internals::emitInspectorDidBeginFrame):
(WebCore::Internals::emitInspectorDidCancelFrame):
(WebCore::Internals::openDummyInspectorFrontend):
(WebCore::Internals::closeDummyInspectorFrontend):
(WebCore::Internals::setInspectorResourcesDataSizeLimits):
(WebCore::Internals::setJavaScriptProfilingEnabled):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
- workers/WorkerGlobalScope.h: remove clearInspector().
(WebCore::WorkerGlobalScope::workerInspectorController):
- workers/WorkerMessagingProxy.cpp:
(WebCore::connectToWorkerGlobalScopeInspectorTask):
(WebCore::disconnectFromWorkerGlobalScopeInspectorTask):
(WebCore::dispatchOnInspectorBackendTask):
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::performTask):
Source/WebKit/efl:
Convert call sites to use a InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateInWebInspector):
- WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorClientEfl::openInspectorFrontend):
- ewk/ewk_view.cpp:
(ewk_view_inspector_show):
(ewk_view_inspector_close):
Source/WebKit/gtk:
Convert call sites to use a InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::paintWebView):
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::openInspectorFrontend):
- webkit/webkitwebinspector.cpp:
(webkit_web_inspector_set_property):
(webkit_web_inspector_get_property):
(webkit_web_inspector_show):
(webkit_web_inspector_inspect_node):
(webkit_web_inspector_inspect_coordinates):
(webkit_web_inspector_close):
(webkit_web_inspector_execute_script):
Source/WebKit/mac:
Convert call sites to use a InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::openInspectorFrontend):
(-[WebInspectorWindowController destroyInspectorView:]):
- WebInspector/WebInspector.mm:
(-showWindow):
(-isJavaScriptProfilingEnabled):
(-setJavaScriptProfilingEnabled:):
(-close:):
(-evaluateInFrontend:callId:script:):
- WebInspector/WebNodeHighlighter.mm:
(-[WebNodeHighlighter highlight]):
Source/WebKit/win:
Convert call sites to use a InspectorController reference.
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::destroyInspectorView):
(WebInspectorFrontendClient::onClose):
- WebInspector.cpp:
(WebInspector::show):
(WebInspector::close):
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
(WebInspector::evaluateInFrontend):
- WebNodeHighlight.cpp:
(WebNodeHighlight::update):
Source/WebKit2:
Convert call sites to use a InspectorController reference.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::drawRect):
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
(WebKit::WebInspectorFrontendClient::closeWindow):
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::createInspectorPage):
(WebKit::WebInspector::show):
(WebKit::WebInspector::close):
(WebKit::WebInspector::evaluateScriptForTest):
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::showResources):
(WebKit::WebInspector::showMainResourceForFrame):
(WebKit::WebInspector::startJavaScriptDebugging):
(WebKit::WebInspector::stopJavaScriptDebugging):
(WebKit::WebInspector::setJavaScriptProfilingEnabled):
(WebKit::WebInspector::startJavaScriptProfiling):
(WebKit::WebInspector::stopJavaScriptProfiling):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):
(WebKit::WebInspector::dispatchMessageFromRemoteFrontend):
(WebKit::WebInspector::remoteFrontendConnected):
(WebKit::WebInspector::remoteFrontendDisconnected):
- 10:57 AM Changeset in webkit [162263] by
-
- 4 edits in trunk/Tools
build.webkit.org/dashboard should have image diff links in test results popovers
https://bugs.webkit.org/show_bug.cgi?id=127188
Reviewed by Timothy Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.layoutTestImagesURLForIteration):
(Buildbot.prototype.layoutTestImageDiffURLForIteration):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.loadLayoutTestResults):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
- 10:50 AM Changeset in webkit [162262] by
-
- 3 edits in trunk/LayoutTests
media/video-size.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=124932
- platform/efl/TestExpectations:
- platform/TestExpectations:
Moving flakiness expectation to cross-platform file, as it also fails on Mac in the same way.
- 10:43 AM Changeset in webkit [162261] by
-
- 2 edits in trunk/LayoutTests
media/video-display-aspect-ratio.html fails
https://bugs.webkit.org/show_bug.cgi?id=35297
- platform/mac/TestExpectations: Marking as flaky.
- 10:42 AM Changeset in webkit [162260] by
-
- 16 edits in trunk
Remove ENABLE_THREADED_HTML_PARSER defines everywhere
https://bugs.webkit.org/show_bug.cgi?id=127225
Reviewed by Andreas Kling.
This concludes the removal of over 8.8 million lines of threaded parser code.
.:
- Source/autotools/SetupWebKitFeatures.m4:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 10:30 AM Changeset in webkit [162259] by
-
- 6 edits2 adds in trunk/Source/WebKit2
Make WKRenderingProgressEvents a shareable API.
https://bugs.webkit.org/show_bug.cgi?id=127213
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-18
Reviewed by Dan Bernstein.
Move WKRenderingProgressEvents from UIProcess to Shared, so that an inject bundle
could also use this enum when listening to layout milestones.
- Shared/API/Cocoa/WKRenderingProgressEvents.h: Added.
(NS_OPTIONS):
- Shared/API/Cocoa/WKRenderingProgressEventsInternal.h: Added.
(renderingProgressEvents):
- UIProcess/API/Cocoa/WKBrowsingContextController.h: Move WKRenderingProgressEvents to Shared/API/Cocoa/WKRenderingProgressEvents.h.
- UIProcess/API/Cocoa/WKBrowsingContextController.mm: Move renderingProgressEvents() to WKRenderingProgressEventsInternal.h.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h: Add
webProcessPlugInBrowserContextController:renderingProgressDidChange: to load delegate.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(didLayout):
(setUpPageLoaderClient): Also listen to didLayout callback for layout milestones.
- 10:25 AM Changeset in webkit [162258] by
-
- 11 edits in trunk/Source/WebCore
Remove the remaining threaded parser code
https://bugs.webkit.org/show_bug.cgi?id=127224
Reviewed by Andreas Kling.
- dom/Document.cpp:
(WebCore::Document::decrementActiveParserCount):
- html/parser/AtomicHTMLToken.h:
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::detach):
(WebCore::HTMLDocumentParser::stopParsing):
(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::resumeParsingAfterYield):
(WebCore::HTMLDocumentParser::forcePlaintextForTextDocument):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::end):
(WebCore::HTMLDocumentParser::finish):
(WebCore::HTMLDocumentParser::textPosition):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
- html/parser/HTMLDocumentParser.h:
- html/parser/HTMLParserIdioms.cpp:
- html/parser/HTMLParserIdioms.h:
- html/parser/HTMLTokenizer.cpp:
- html/parser/HTMLTokenizer.h:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoading):
(WebCore::DocumentLoader::checkLoadComplete):
- page/Settings.in:
- 10:06 AM Changeset in webkit [162257] by
-
- 5 edits in trunk/Source/WebCore
Remove threaded parser code from the preload scanners
https://bugs.webkit.org/show_bug.cgi?id=127222
Reviewed by Andreas Kling.
- html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::CSSPreloadScanner):
Use nullptr.
(WebCore::CSSPreloadScanner::scan):
Move scanCommon here and simplify the code.
- html/parser/CSSPreloadScanner.h:
Remove scanCommon.
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::tagIdFor):
TagId is a strong enum now, update enum values.
(WebCore::TokenPreloadScanner::initiatorFor):
Ditto.
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
Ditto.
(WebCore::TokenPreloadScanner::StartTagScanner::match):
Indent this.
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
TagId is a strong enum now, update enum values.
(WebCore::TokenPreloadScanner::StartTagScanner::charset):
Ditto.
(WebCore::TokenPreloadScanner::StartTagScanner::resourceType):
Ditto.
(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):
Ditto.
(WebCore::TokenPreloadScanner::scan):
Merge scan and scanCommon.
- html/parser/HTMLPreloadScanner.h:
- 9:55 AM Changeset in webkit [162256] by
-
- 9 edits1 add1 delete in trunk/Source/JavaScriptCore
Adding UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn()..
https://bugs.webkit.org/show_bug.cgi?id=127127.
Reviewed by Geoffrey Garen.
In order to implement bytecode level breakpoints, we need a mechanism
for computing the best fit op_debug bytecode offset for any valid given
line and column value in the source. The "best fit" op_debug bytecode
in this case is defined below in the comment for
UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn().
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::opDebugBytecodeOffsetForLineAndColumn):
- Convert the line and column to unlinked line and column values and pass them to UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn() to do the real work.
- bytecode/CodeBlock.h:
- bytecode/LineColumnInfo.h: Added.
(JSC::LineColumnInfo::operator <):
(JSC::LineColumnInfo::LineColumnPair::LineColumnPair):
(JSC::LineColumnInfo::operator ==):
(JSC::LineColumnInfo::operator !=):
(JSC::LineColumnInfo::operator <=):
(JSC::LineColumnInfo::operator >):
(JSC::LineColumnInfo::operator >=):
- bytecode/LineInfo.h: Removed.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::decodeExpressionRangeLineAndColumn):
- Factored this out of expressionRangeForBytecodeOffset() so that it can be called from multiple places.
(JSC::dumpLineColumnEntry):
(JSC::UnlinkedCodeBlock::dumpExpressionRangeInfo):
(JSC::UnlinkedCodeBlock::dumpOpDebugLineColumnInfoList):
- Some dumpers for debugging use only.
(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):
(JSC::UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn):
- Finds the earliest op_debug bytecode whose line and column matches the specified line and column values. If an exact match is not found, then finds the nearest op_debug bytecode that precedes the specified line and column values. If there are more than one op_debug at that preceding line and column value, then the earliest of those op_debug bytecodes will be be selected. The offset of the selected bytecode will be returned.
We want the earliest one because when we have multiple op_debug bytecodes
that map to a given line and column, a debugger user would expect to break
on the first one and step through the rest thereafter if needed.
(JSC::compareLineColumnInfo):
(JSC::UnlinkedCodeBlock::opDebugLineColumnInfoList):
- Creates the sorted opDebugLineColumnInfoList on demand. This list is stored in the UnlinkedCodeBlock's rareData.
- bytecode/UnlinkedCodeBlock.h:
- 9:19 AM Changeset in webkit [162255] by
-
- 2 edits10 deletes in trunk
Remove Nix files from WebCore
https://bugs.webkit.org/show_bug.cgi?id=127176
Patch by Lauro Neto <lauro.neto@openbossa.org> on 2014-01-18
Reviewed by Anders Carlsson.
.:
- Source/cmake/OptionsNix.cmake: Removed.
Source/WebCore:
- PlatformNix.cmake: Removed.
- css/mediaControlsNix.css: Removed.
- css/mediaControlsNixFullscreen.css: Removed.
- editing/nix/EditorNix.cpp: Removed.
- page/nix/EventHandlerNix.cpp: Removed.
- platform/audio/nix/AudioBusNix.cpp: Removed.
- platform/audio/nix/AudioDestinationNix.cpp: Removed.
- platform/audio/nix/AudioDestinationNix.h: Removed.
- platform/audio/nix/FFTFrameNix.cpp: Removed.
- platform/graphics/nix/IconNix.cpp: Removed.
- platform/graphics/nix/ImageNix.cpp: Removed.
- platform/nix/CursorNix.cpp: Removed.
- platform/nix/DragDataNix.cpp: Removed.
- platform/nix/DragImageNix.cpp: Removed.
- platform/nix/ErrorsNix.cpp: Removed.
- platform/nix/ErrorsNix.h: Removed.
- platform/nix/FileSystemNix.cpp: Removed.
- platform/nix/GamepadsNix.cpp: Removed.
- platform/nix/LanguageNix.cpp: Removed.
- platform/nix/LocalizedStringsNix.cpp: Removed.
- platform/nix/MIMETypeRegistryNix.cpp: Removed.
- platform/nix/NixKeyboardUtilities.cpp: Removed.
- platform/nix/NixKeyboardUtilities.h: Removed.
- platform/nix/PasteboardNix.cpp: Removed.
- platform/nix/PlatformKeyboardEventNix.cpp: Removed.
- platform/nix/PlatformScreenNix.cpp: Removed.
- platform/nix/RenderThemeNix.cpp: Removed.
- platform/nix/RenderThemeNix.h: Removed.
- platform/nix/ScrollbarThemeNix.cpp: Removed.
- platform/nix/ScrollbarThemeNix.h: Removed.
- platform/nix/SharedTimerNix.cpp: Removed.
- platform/nix/SoundNix.cpp: Removed.
- platform/nix/TemporaryLinkStubs.cpp: Removed.
- platform/nix/WidgetNix.cpp: Removed.
- platform/nix/support/MultiChannelPCMData.cpp: Removed.
- platform/text/nix/TextBreakIteratorInternalICUNix.cpp: Removed.
- 9:11 AM Changeset in webkit [162254] by
-
- 9 edits in trunk/Source/WebCore
Remove DocumentParser::pinToMainThread() and related code
https://bugs.webkit.org/show_bug.cgi?id=127221
Reviewed by Andreas Kling.
- dom/Document.cpp:
(WebCore::Document::setContent):
- dom/DocumentParser.h:
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
- html/parser/HTMLDocumentParser.h:
- html/parser/HTMLParserOptions.cpp:
(WebCore::HTMLParserOptions::HTMLParserOptions):
- html/parser/HTMLParserOptions.h:
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTag):
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
- 9:00 AM Changeset in webkit [162253] by
-
- 7 edits2 deletes in trunk/Source/WebCore
Remove HTMLParserThread
https://bugs.webkit.org/show_bug.cgi?id=127220
Reviewed by Andreas Kling.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/parser/HTMLDocumentParser.cpp:
- html/parser/HTMLParserThread.cpp: Removed.
- html/parser/HTMLParserThread.h: Removed.
- 8:50 AM Changeset in webkit [162252] by
-
- 2 edits in trunk/Source/WebCore
GC soon after responding to fake memory pressure.
<https://webkit.org/b/127210>
Ask JSC to garbage collect "soon" after handling the fake memory
pressure signal on Mac. This seems to stabilize the post-pressure
numbers on Membuster3 a bit on my laptop. The difference is mostly
made up of JSC::CodeBlock objects.
Reviewed by Geoffrey Garen.
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::install):
- 8:48 AM Changeset in webkit [162251] by
-
- 11 edits10 deletes in trunk/Source/WebCore
Remove files only used by the threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=127219
<rdar://problem/13331277>
Reviewed by Andreas Kling.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/parser/AtomicHTMLToken.h:
- html/parser/BackgroundHTMLInputStream.cpp: Removed.
- html/parser/BackgroundHTMLInputStream.h: Removed.
- html/parser/BackgroundHTMLParser.cpp: Removed.
- html/parser/BackgroundHTMLParser.h: Removed.
- html/parser/CompactHTMLToken.cpp: Removed.
- html/parser/CompactHTMLToken.h: Removed.
- html/parser/HTMLDocumentParser.cpp:
- html/parser/HTMLDocumentParser.h:
- html/parser/HTMLIdentifier.cpp: Removed.
- html/parser/HTMLIdentifier.h: Removed.
- html/parser/HTMLParserIdioms.h:
- html/parser/HTMLPreloadScanner.h:
- html/parser/HTMLTreeBuilderSimulator.cpp: Removed.
- html/parser/HTMLTreeBuilderSimulator.h: Removed.
- 1:04 AM Changeset in webkit [162250] by
-
- 3 edits in trunk/Source/JavaScriptCore
Inspector scripts are not compatible with Python v3
https://bugs.webkit.org/show_bug.cgi?id=127128
Reviewed by Benjamin Poulain.
- inspector/scripts/generate-combined-inspector-json.py: Turn print statements into print function calls.
- inspector/scripts/jsmin.py: Try importing the StringIO class from the StringIO module (which will work for
Python v2) or, on import error, import the class from the io module (which will work for Python v3).
- 12:22 AM Changeset in webkit [162249] by
-
- 2 edits in trunk
[GTK] Bump the minimum required Clang version to 3.3
https://bugs.webkit.org/show_bug.cgi?id=127178
Reviewed by Martin Robinson.
- Source/autotools/CheckSystemAndBasicDependencies.m4: Require Clang 3.3 or later when using the Clang compiler to
build the GTK port. Building with Clang 3.2 doesn't work anymore and there's no point in fixing that, as we should
support the latest two versions of Clang (3.3 and 3.4), just like we do with GCC (4.7 and 4.8).
Jan 17, 2014:
- 11:26 PM Changeset in webkit [162248] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
Fix 32-bit C loop LLINT.
https://bugs.webkit.org/show_bug.cgi?id=127086.
Reviewed by Geoffrey Garen.
- llint/LowLevelInterpreter32_64.asm:
- 10:54 PM Changeset in webkit [162247] by
-
- 2 edits in branches/jsCStack/Tools
Unreviewed, run Mozilla tests with the FTL.
All of those tests pass. Because the FTL is now awesome.
- Scripts/run-jsc-stress-tests:
- 10:32 PM Changeset in webkit [162246] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
FTL mishandles (-2147483648 % 0) | 0
https://bugs.webkit.org/show_bug.cgi?id=127215
Not yet reviewed.
This fixes:
jsc-layout-tests.yaml/js/script-tests/dfg-mod-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc.js.layout-ftl-eager-no-cjit
Now the FTL passes all JSC layout tests.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithDivMod):
- 10:27 PM Changeset in webkit [162245] by
-
- 30 edits2 deletes in trunk/Source/WebKit2
Unreviewed, rolling out r162237 and r162241.
http://trac.webkit.org/changeset/162237
http://trac.webkit.org/changeset/162241
https://bugs.webkit.org/show_bug.cgi?id=127216
Broke lots of API tests (Requested by ap on #webkit).
- CMakeLists.txt:
- GNUmakefile.list.am:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::destroyPrivateBrowsingSession):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/RemoteNetworkingContext.h:
- NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::privateBrowsingStorageSession):
(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::privateBrowsingSession):
(WebKit::privateBrowsingStorageSessionIdentifierBase):
(WebKit::RemoteNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::destroyPrivateBrowsingSession):
- NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:
(WebKit::RemoteNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::privateBrowsingSession):
- Shared/SessionTracker.cpp: Removed.
- Shared/SessionTracker.h: Removed.
- UIProcess/APISession.cpp:
(API::Session::Session):
(API::Session::create):
(API::Session::isEphemeral):
- UIProcess/APISession.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
- UIProcess/WebContext.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage):
- UIProcess/WebProcessProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::privateSession):
(WebKit::identifierBase):
(WebKit::WebFrameNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):
- WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::privateSession):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):
- WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 9:48 PM Changeset in webkit [162244] by
-
- 3 edits in branches/jsCStack/Source/JavaScriptCore
FTL should update machine virtual registers in runtime meta-data according to the captured stackmap
https://bugs.webkit.org/show_bug.cgi?id=125725
Reviewed by Michael Saboff.
This is pretty awesome - it closes the loop on our FTL stackwalking story. We use
an alloca for storing all of the things that the runtime will want to discover
during a stack walk, like the closure pointer for inlined closure calls and the
arguments to inlined functions. We then pass that alloca as an argument to a
stackmap in the prologue, and LLVM reports the alloca's frame offset using a
stackmap direct entry. We call this the "localsOffset". Previously we just used
this to update some OSR exit meta-data. Now we also use it to properly adjust the
ValueRecovery meta-data in inline call frames.
Currently we only have to do this for inline call frames and OSR exits, but in the
future we'll use similar techniques for activations. This bug doesn't cover that
since the FTL doesn't support compiling functions that create activations, yet.
This change makes us incorporate localsOffset into all of the relevant things that
the FTL supports.
This fixes:
jsc-layout-tests.yaml/js/script-tests/dfg-inline-arguments-use-from-all-the-places.js.layout-ftl-eager-no-cjit
With this fix, the FTL only fails one of the JSC layout tests.
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::withLocalsOffset):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- 9:33 PM Changeset in webkit [162243] by
-
- 2 edits in trunk/Source/WebKit
Build fix for the CMake GTK+ build
- PlatformGTK.cmake: We need to include ProgressTrackerClientGtk in the source list.
- 9:10 PM Changeset in webkit [162242] by
-
- 8 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Fix Baseline JIT for X86-32
https://bugs.webkit.org/show_bug.cgi?id=127201
Reviewed by Geoffrey Garen.
Most of the changes are to follow calling convention (emiting function prologues and
epilogues) and making room on the stack for outgoing arguments.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::unwind):
- jit/JIT.cpp:
(JSC::JIT::privateCompile): Eliminated stack alignment check before moving the stack
pointer down for locals since it will not be aligned at that time. The move will align
the stack pointer.
(JSC::JIT::frameRegisterCountFor): Changed to allocate the outgoing register space
after rounding the number of local registers as the outgoing register count will
properly align the local registers.
- jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_ret): Changed to emit epilogue.
(JSC::JIT::emit_op_ret_object_or_this): Changed to emit epilogue.
(JSC::JIT::compileLoadVarargs): Alignment changes matching what is in
JITCall.cpp::JIT::compileLoadVarargs.
(JSC::JIT::compileCallEvalSlowCase): Changed to use the stack pointer to fill-in the
new callee frame.
(JSC::JIT::compileOpCall): Changed to use the stack pointer to fill-in the
new callee frame.
(JSC::JIT::compileOpCallSlowCase): Code to restore the stack pointer after the call.
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_ret_object_or_this): Remove dead code in 64 bit path found while
working on this patch.
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall): Changes to follow native calling convention,
allocate space and populate outgoing args and pass the caller to operationVMHandleException.
(JSC::JIT::emit_op_end): Emit the epilogue.
- jit/ThunkGenerators.cpp:
(JSC::slowPathFor): Allocate stack space for arguments.
(JSC::arityFixup): Changes to match 64 bit code.
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL): Whitespace cleanup.
- 9:06 PM Changeset in webkit [162241] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix on EFL port after r162237
The EFL port disabled NETWORK_PROCESS yet and use -Werror=unused-function.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
Guarded legacySessionID with ENABLE(NETWORK_PROCESS)
- 9:05 PM Changeset in webkit [162240] by
-
- 13 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: X86-32 Fix LLInt
https://bugs.webkit.org/show_bug.cgi?id=127071
Reviewed by Filip Pizlo.
This fixes X86-32 compilation issues in JITCall32_64.cpp and JITPropertyAccess32_64.cpp.
Fixed the 32 bit LLInt to work with X86. Since X86 passes arguments on the stack,
calls (e.g. LLInt CCall2, JITOperations::getHostCallReturnValue) need to make an
outgoing argument area on the stack, populate the arguments and then make the call.
Much of the argument and call logic is based on the alignment of the stack pointer
and call frame register. The stack pointer at the time of a call needs to be
stackAlignmentBytes() (16 byte) aligned. The call frame register, which points at
the current call frame will be at an alignment that is stackAlignmentBytes() minus
what gets pushed on the stack as part of the call, i.e. the caller PC and caller
frame pointer. For us this is JSStack::CallerFrameAndPCSize * sizeof(Register).
Using roundLocalRegisterCountForFramePointerOffset() eliminates the need for
maxFrameExtentForSlowPathCall needing additional bytes to pad out the stack
to be aligned.
Tested on X86-32 with LLInt only testapi. Tested on X86-64 with all javascript tests.
- assembler/MaxFrameExtentForSlowPathCall.h:
- interpreter/ProtoCallFrame.cpp:
(JSC::ProtoCallFrame::init):
- interpreter/ProtoCallFrame.h:
(JSC::ProtoCallFrame::setPaddedArgCount):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileCallEval):
(JSC::JIT::compileOpCallSlowCase):
- jit/JITOperations.cpp:
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LLIntEntrypoint.cpp:
(JSC::LLInt::frameRegisterCountFor):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/StackAlignment.h:
(JSC::roundArgumentCountToAlignFrame):
(JSC::roundLocalRegisterCountForFramePointerOffset):
- 7:54 PM Changeset in webkit [162239] by
-
- 8 edits in branches/jsCStack/Source/JavaScriptCore
FTL watchpoint tests that use dfgIncrement() and friends fail because numberOfDFGCompiles() returns zero with --testTheFTL=true and right after the first FTL OSR exit but just before recompilation is triggered
https://bugs.webkit.org/show_bug.cgi?id=127163
Reviewed by Michael Saboff.
We just need to track if we had ever compiled with the FTL. Also rework the various
bool's in CodeBlock so that they are bitfields if possible. To that end, make sure
we only write to them from the main thread.
This fixes a bunch of LayoutTests with --ftl-jit. Now only two fail.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::numberOfDFGCompiles):
- bytecode/CodeBlock.h:
- dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::setOptimizationThresholdBasedOnCompilationResult):
- dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalizeCommon):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
- dfg/DFGPlan.h:
- dfg/DFGTierUpCheckInjectionPhase.cpp:
(JSC::DFG::TierUpCheckInjectionPhase::run):
- 6:31 PM Changeset in webkit [162238] by
-
- 3 edits in trunk/Source/WebCore
Micro-optimize RenderBoxModelObject::computedCSSPadding().
<https://webkit.org/b/127208>
Make computedCSSPadding() take the Length as a const reference
to avoid creating a temporary copy. This was showing up (0.2%)
on DoYouEvenBench.
Reviewed by Anders Carlsson.
- rendering/RenderBoxModelObject.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computedCSSPadding):
- 6:17 PM Changeset in webkit [162237] by
-
- 30 edits2 copies in trunk/Source/WebKit2
Flesh out session APIs (still not enabled at API level).
https://bugs.webkit.org/show_bug.cgi?id=126918
Patch by Martin Hock <mhock@apple.com> on 2014-01-17
Reviewed by Alexey Proskuryakov.
- CMakeLists.txt:
- GNUmakefile.list.am:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::destroyPrivateBrowsingSession):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/RemoteNetworkingContext.h:
- NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
- NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
- Shared/SessionTracker.cpp: Copied from Source/WebKit2/UIProcess/APISession.cpp.
(WebKit::sessionMap):
(WebKit::identifierBase):
(WebKit::SessionTracker::getSessionMap):
(WebKit::SessionTracker::getIdentifierBase):
(WebKit::SessionTracker::session):
(WebKit::SessionTracker::destroySession):
(WebKit::SessionTracker::setIdentifierBase):
- Shared/SessionTracker.h: Copied from Source/WebKit2/UIProcess/APISession.h.
(WebKit::SessionTracker::isEphemeralID):
- UIProcess/APISession.cpp:
(API::generateID):
(API::Session::defaultSession):
(API::Session::legacyPrivateSession):
(API::Session::Session):
(API::Session::create):
(API::Session::isEphemeral):
(API::Session::getID):
- UIProcess/APISession.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
- UIProcess/WebContext.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::sessionID):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage):
- UIProcess/WebProcessProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::legacySessionID):
(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):
- WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):
- WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 6:08 PM Changeset in webkit [162236] by
-
- 4 edits in trunk/Tools
build.webkit.org/dashboard should have diff links in test results popovers
https://bugs.webkit.org/show_bug.cgi?id=126986
Reviewed by Tim Horton.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.layoutTestCrashLogURLForIteration):
(Buildbot.prototype.layoutTestStderrURLForIteration):
(Buildbot.prototype.layoutTestDiffURLForIteration):
(Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.loadLayoutTestResults):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
- 5:58 PM Changeset in webkit [162235] by
-
- 6 edits in trunk/Source
Add a callOnMainThreadAndWait variant in SocketStreamHandle
https://bugs.webkit.org/show_bug.cgi?id=127180
Reviewed by Geoffrey Garen.
Source/WebCore:
WTF::callOnMainThreadAndWait was only used inside SocketStreamHandleCFNet.cpp,
so add an improved version there which is implemented in terms of callOnMainThread and
with the bonus of handling spurious wake-ups correctly (the old version didn't).
- platform/network/cf/SocketStreamHandle.h:
- platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::callOnMainThreadAndWait):
(WebCore::SocketStreamHandle::pacExecutionCallback):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
Source/WTF:
Remove callOnMainThreadAndWait from WTF.
- wtf/MainThread.cpp:
- wtf/MainThread.h:
- 5:47 PM Changeset in webkit [162234] by
-
- 15 edits in trunk/Source
Clean up PageCache classes
https://bugs.webkit.org/show_bug.cgi?id=127202
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::~CachedFrameBase):
(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::clear):
(WebCore::CachedFrame::setCachedFramePlatformData):
- history/CachedFrame.h:
- history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
- history/CachedPage.h:
- history/HistoryItem.h:
(WebCore::HistoryItem::isInPageCache):
- history/PageCache.cpp:
(WebCore::PageCache::add):
(WebCore::PageCache::take):
(WebCore::PageCache::remove):
- history/PageCache.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
- loader/HistoryController.cpp:
(WebCore::HistoryController::invalidateCurrentItemCachedPage):
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::savePlatformDataToCachedFrame):
(WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
Source/WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::savePlatformDataToCachedFrame):
- 5:18 PM Changeset in webkit [162233] by
-
- 2 edits in trunk/Source/WebCore
Work around a preprocessor warning in mediaControlsApple.js
https://bugs.webkit.org/show_bug.cgi?id=127204
Reviewed by Dan Bernstein.
- Modules/mediacontrols/mediaControlsApple.js: Changed to String().
- 4:36 PM Changeset in webkit [162232] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS build after <http://trac.webkit.org/changeset/162184>
(https://bugs.webkit.org/show_bug.cgi?id=126856)
Remove symbol for WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator(unsigned short const*, int).
Add symbol for WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator(WTF::StringView).
- WebCore.exp.in:
- 4:34 PM Changeset in webkit [162231] by
-
- 9 edits2 deletes in trunk/Source
Remove unused TOUCH_ADJUSTMENT code.
<https://webkit.org/b/127181>
Source/WebCore:
There are no ports using the ENABLE(TOUCH_ADJUSTMENT) feature
anymore, so nuke it from orbit.
Reviewed by Anders Carlsson.
- page/EventHandler.cpp:
- page/EventHandler.h:
- page/Settings.in:
- page/TouchAdjustment.cpp: Removed.
- page/TouchAdjustment.h: Removed.
- testing/Internals.cpp:
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2:
Reviewed by Anders Carlsson.
- WebProcess/WebPage/CoordinatedGraphics/WebPageCoordinatedGraphics.cpp:
(WebKit::WebPage::findZoomableAreaForPoint):
- 4:05 PM Changeset in webkit [162230] by
-
- 16 edits2 adds in trunk
Need a way to test the tile cache with margins enabled
https://bugs.webkit.org/show_bug.cgi?id=127194
-and corresponding-
<rdar://problem/15571327>
Reviewed by Tim Horton.
Source/WebCore:
This patch adds a new function to InternalSettings that will allow layout tests to
flip the setting Settings::setBackgroundShouldExtendBeyondPage(). This patch also
makes changing that setting take effect immediately.
To make this setting dynamic, we can no longer generate the Setting function, so
we have to export the symbol manually.
- WebCore.exp.in:
This new function on FrameView will call into RenderLayerBacking to add or remove
margins.
- page/FrameView.cpp:
(WebCore::FrameView::setBackgroundExtendsBeyondPage):
- page/FrameView.h:
Again, we’re no longer using the boiler-plate generated Setting functions, so now
we can call into FrameView to make the background extend.
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setBackgroundShouldExtendBeyondPage):
- page/Settings.h:
(WebCore::Settings::backgroundShouldExtendBeyondPage):
- page/Settings.in:
Whenever tile margins are set, call setNeedsRevalidateTiles() to make the change
dynamic.
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::setTileMargins):
Move the call to TiledBacking::setTileMargins() into a helper function so that the
same code can be used for FrameView.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::setTiledBackingHasMargins):
- rendering/RenderLayerBacking.h:
New InternalSetting.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setBackgroundShouldExtendBeyondPage):
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
Source/WebKit:
Attempt to keep Windows building.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
LayoutTests:
- platform/mac-wk2/tiled-drawing/simple-document-with-margin-tiles-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/simple-document-with-margin-tiles.html: Added.
- 3:49 PM Changeset in webkit [162229] by
-
- 3 edits in trunk/Source/WebKit2
Fix build.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- 3:43 PM Changeset in webkit [162228] by
-
- 3 edits in trunk/Tools
Add the bare minimum support for branches to the bot-watchers dashboard
https://bugs.webkit.org/show_bug.cgi?id=127124
This patch simply introduces the notion of branches into the bot-watchers dashboard.
Subsequent patches will build functionality on top of this simple bit of infrastructure.
Reviewed by Timothy Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue): store the branch property in the BuildbotQueue constructor
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
Initialize the Dashboard.Branch object
- 3:17 PM Changeset in webkit [162227] by
-
- 25 edits in trunk/Source
Remove another unused FrameLoaderClient callback
https://bugs.webkit.org/show_bug.cgi?id=127192
Reviewed by Dan Bernstein.
Source/WebCore:
FrameLoaderClient::dispatchDocumentElementAvailable() was only used by the Chromium port, so remove it.
- html/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure):
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded):
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
Source/WebKit/efl:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
- WebCoreSupport/FrameLoaderClientEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- WebCoreSupport/FrameLoaderClientGtk.h:
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
Source/WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit/wince:
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
- WebCoreSupport/FrameLoaderClientWinCE.h:
- 2:59 PM Changeset in webkit [162226] by
-
- 9 edits in trunk/Source
Remove FrameLoaderClient::didPerformFirstNavigation()
https://bugs.webkit.org/show_bug.cgi?id=127191
Reviewed by Dan Bernstein.
Source/WebCore:
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
- loader/HistoryController.cpp:
(WebCore::HistoryController::updateBackForwardListClippedAtTarget):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- 2:49 PM Changeset in webkit [162225] by
-
- 14 edits in trunk/Source/WebKit
Remove didPerformFirstNavigation from all FrameLoaderClient subclasses
https://bugs.webkit.org/show_bug.cgi?id=127190
Reviewed by Dan Bernstein.
Source/WebKit/efl:
According to the EFl maintainers, this is not used by any applications so it's safe to remove it.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
- WebCoreSupport/FrameLoaderClientEfl.h:
- ewk/ewk_frame.cpp:
- ewk/ewk_frame_private.h:
Source/WebKit/gtk:
Removing this shouldn't have any bad effects, but if that is the case it's possible to
set the cache model in didCommitLoadForFrame, similar to what is done in r162224.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- WebCoreSupport/FrameLoaderClientGtk.h:
Source/WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit/wince:
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
- WebCoreSupport/FrameLoaderClientWinCE.h:
- 2:38 PM Changeset in webkit [162224] by
-
- 7 edits in trunk/Source
Move didPerformFirstNavigation() logic to -[WebView _didCommitLoadForFrame:]
https://bugs.webkit.org/show_bug.cgi?id=127189
Reviewed by Dan Bernstein.
Source/WebCore:
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::didPerformFirstNavigation):
Add an empty implementation of didPerformFirstNavigation() to make it easier to remove it from subclasses.
Source/WebKit/mac:
This is a first step towards completely eliminating the didPerformFirstNavigation() client callback.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
Remove didPerformFirstNavigation() implementation.
- WebView/WebView.mm:
(-[WebView _checkDidPerformFirstNavigation]):
Check if we have both a current item and a previous item which indicates that we've navigated once.
The old code was called before there was a current item but since this is called from _didCommitLoadForFrame
we have to check that there's a current item as well.
(-[WebView _didCommitLoadForFrame:]):
Call _didCommitLoadForFrame.
- WebView/WebViewData.h:
Add new ivar.
- 2:22 PM Changeset in webkit [162223] by
-
- 7 edits in trunk/PerformanceTests
[CSS Regions] Minor fixes in regions performance tests
https://bugs.webkit.org/show_bug.cgi?id=127041
Reviewed by Ryosuke Niwa.
Fix minor issues in CSS Regions performance tests.
- Layout/RegionsAuto.html: Change type to lower case.
- Layout/RegionsAutoMaxHeight.html: Ditto.
- Layout/RegionsFixed.html: Ditto.
- Layout/RegionsFixedShort.html: Ditto.
- Layout/RegionsSelection.html: Ditto. Move test methods from regions.js.
- Layout/resources/regions.js: Remove moved methods.
- 1:54 PM Changeset in webkit [162222] by
-
- 7 edits in trunk/Tools
platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
https://bugs.webkit.org/show_bug.cgi?id=127141
Reviewed by Alexey Proskuryakov.
Make sure to reset the notification handler each time.
- DumpRenderTree/AccessibilityController.cpp:
(AccessibilityController::resetToConsistentState):
- DumpRenderTree/AccessibilityController.h:
- DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
(AccessibilityController::platformResetToConsistentState):
- DumpRenderTree/ios/AccessibilityControllerIOS.mm:
(AccessibilityController::platformResetToConsistentState):
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::~AccessibilityController):
(AccessibilityController::platformResetToConsistentState):
(AccessibilityController::removeNotificationListener):
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::platformResetToConsistentState):
- 1:36 PM Changeset in webkit [162221] by
-
- 2 edits in trunk/Source/WebCore
[iOS] HTMLMediaSession should set AudioSession category
https://bugs.webkit.org/show_bug.cgi?id=127137
Reviewed by Sam Weinig.
- html/HTMLMediaSession.cpp:
(WebCore::initializeAudioSession): New, set the audio session to "media" on iOS.
(WebCore::HTMLMediaSession::HTMLMediaSession): Call initializeAudioSession.
- 1:31 PM Changeset in webkit [162220] by
-
- 2 edits in trunk/Websites/webkit.org
Host DoYouEvenBench on webkit.org
https://bugs.webkit.org/show_bug.cgi?id=127185
Reviewed by Benjamin Poulain.
The previous patch didn't quite work due to cross-origin restrictions.
Simply add a hyperlink to a trac page.
- perf/DoYouEvenBench/index.html:
- 1:24 PM Changeset in webkit [162219] by
-
- 2 edits in trunk/Source/WebKit/mac
More iOS build fix.
- WebView/WebPreferences.mm: (-[WebPreferences _synchronizeWebStoragePolicyWithCookiePolicy]):
NSHTTPCookieAcceptPolicyExclusivelyFromMainDocumentDomain is not part of NSHTTPCookieAcceptPolicy enum.
- 1:13 PM Changeset in webkit [162218] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS build after <http://trac.webkit.org/changeset/162178>
(https://bugs.webkit.org/show_bug.cgi?id=127147)
Declare WebMediaSessionHelper outside of namespace WebCore to resolve error that
"Objective-C declarations may only appear in global scope".
- platform/audio/ios/MediaSessionManagerIOS.mm:
- 1:11 PM Changeset in webkit [162217] by
-
- 6 edits6 adds in trunk
[CSS Shapes] Stacked floats with shape-outside should allow inline content to interact with the non-outermost float
https://bugs.webkit.org/show_bug.cgi?id=122576
Reviewed by David Hyatt.
Source/WebCore:
Make inline content interact with stacked floats with shape-outside
per the spec. This means that content can interact with floats on the
line that are not the outermost float.
This refactors ComputeFloatOffsetAdapter into a superclass and two
subclasses: one adaptor for determining the offset for float layout,
and one for determining the offset for inline layout.
The logic in LineWidth::shrinkAvailableWidthForNewFloatIfNeeded has
been updated to handle stacked floats with shape-outside properly and
has been considerably simplified in the process. It was previously
doing a whole bunch of unnecessary work.
Tests: fast/shapes/shape-outside-floats/shape-outside-floats-stacked-000.html
fast/shapes/shape-outside-floats/shape-outside-floats-stacked-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-stacked-002.html
- rendering/FloatingObjects.cpp:
(WebCore::ComputeFloatOffsetAdapter::~ComputeFloatOffsetAdapter):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter::ComputeFloatOffsetForFloatLayoutAdapter):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter::~ComputeFloatOffsetForFloatLayoutAdapter):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter::ComputeFloatOffsetForLineLayoutAdapter):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter::~ComputeFloatOffsetForLineLayoutAdapter):
(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatingObject::FloatLeft>::updateOffsetIfNeeded):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatingObject::FloatRight>::updateOffsetIfNeeded):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatTypeValue>::heightRemaining):
(WebCore::shapeInfoForFloat):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatLeft>::updateOffsetIfNeeded):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatRight>::updateOffsetIfNeeded):
- rendering/line/LineWidth.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):
- rendering/shapes/ShapeOutsideInfo.h:
LayoutTests:
Tests for shape-outside on stacked floats and interaction with inline
content.
- fast/shapes/shape-outside-floats/shape-outside-floats-stacked-000-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-stacked-000.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-stacked-001-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-stacked-001.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-stacked-002-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-stacked-002.html: Added.
- 1:10 PM Changeset in webkit [162216] by
-
- 3 edits1 copy1 add in trunk
Host DoYouEvenBench on webkit.org
https://bugs.webkit.org/show_bug.cgi?id=127185
Reviewed by Benjamin Poulain.
PerformanceTests:
Compute the resources directory relative to the benchmark-runner's location
so that we can load tests even if the runner HTML was located elsewhere.
- DoYouEvenBench/Full.html:
- DoYouEvenBench/resources/benchmark-runner.js:
(BenchmarkState._containingDirectory):
Websites/webkit.org:
Added webkit.org/perf/DoYouEvenBench.
- perf/DoYouEvenBench: Added.
- perf/DoYouEvenBench/index.html: Copied from PerformanceTests/DoYouEvenBench/Full.html.
- 12:56 PM Changeset in webkit [162215] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Add CSS Grid Layout as experimental feature
https://bugs.webkit.org/show_bug.cgi?id=127089
Reviewed by Martin Robinson.
Allow CSS Grid Layout to be enabled through the environment variable WEBKITGTK_EXPERIMENTAL_FEATURES.
Example: WEBKITGTK_EXPERIMENTAL_FEATURES="CSS_GRID_LAYOUT=1"
- UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsConstructed): Use new experimental feature to enable or disable CSS Grid Layout.
- UIProcess/gtk/ExperimentalFeatures.cpp: Add new experimental feature.
- UIProcess/gtk/ExperimentalFeatures.h: Ditto.
- 12:43 PM Changeset in webkit [162214] by
-
- 3 edits3 moves in trunk/PerformanceTests
DoYouEvenBench: Move flightjs-example-app and todomvc into resources
https://bugs.webkit.org/show_bug.cgi?id=127183
Rubber-stamped by Anders Carlsson.
- DoYouEvenBench/InteractiveRunner.html: Copied from PerformanceTests/DoYouEvenBench/benchmark.html.
- DoYouEvenBench/benchmark.html: Removed.
- DoYouEvenBench/flightjs-example-app: Removed.
- DoYouEvenBench/flightjs-example-app/LICENSE.md: Removed.
- DoYouEvenBench/flightjs-example-app/README.md: Removed.
- DoYouEvenBench/flightjs-example-app/app: Removed.
- DoYouEvenBench/flightjs-example-app/app/boot: Removed.
- DoYouEvenBench/flightjs-example-app/app/boot/page.js: Removed.
- DoYouEvenBench/flightjs-example-app/app/component_data: Removed.
- DoYouEvenBench/flightjs-example-app/app/component_data/compose_box.js: Removed.
- DoYouEvenBench/flightjs-example-app/app/component_data/mail_items.js: Removed.
- DoYouEvenBench/flightjs-example-app/app/component_data/move_to.js: Removed.
- DoYouEvenBench/flightjs-example-app/app/component_ui: Removed.
- DoYouEvenBench/flightjs-example-app/app/component_ui/compose_box.js: Removed.
- DoYouEvenBench/flightjs-example-app/app/component_ui/folders.js: Removed.
- DoYouEvenBench/flightjs-example-app/app/component_ui/mail_controls.js: Removed.
- DoYouEvenBench/flightjs-example-app/app/component_ui/mail_items.js: Removed.
- DoYouEvenBench/flightjs-example-app/app/component_ui/move_to_selector.js: Removed.
- DoYouEvenBench/flightjs-example-app/app/component_ui/with_select.js: Removed.
- DoYouEvenBench/flightjs-example-app/app/css: Removed.
- DoYouEvenBench/flightjs-example-app/app/css/custom.css: Removed.
- DoYouEvenBench/flightjs-example-app/app/data.js: Removed.
- DoYouEvenBench/flightjs-example-app/app/templates.js: Removed.
- DoYouEvenBench/flightjs-example-app/components: Removed.
- DoYouEvenBench/flightjs-example-app/components/bootstrap: Removed.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/css: Removed.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.css: Removed.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.min.css: Removed.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap.css: Removed.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap.min.css: Removed.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/img: Removed.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/img/glyphicons-halflings-white.png: Removed.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/img/glyphicons-halflings.png: Removed.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/js: Removed.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/js/bootstrap.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/js/bootstrap.min.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/.gitignore: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/CHANGES: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/CONTRIBUTORS.md: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/LICENSE: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/README.md: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/component.json: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-sham.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-sham.min.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-shim.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-shim.min.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/package.json: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h-kill.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h-matchers.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/index.html: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine-html.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine.css: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine_favicon.png: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/json2.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-array.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-date.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-function.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-object.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-string.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/flight: Removed.
- DoYouEvenBench/flightjs-example-app/components/flight/.travis.yml: Removed.
- DoYouEvenBench/flightjs-example-app/components/flight/lib: Removed.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/advice.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/component.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/compose.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/index.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/logger.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/registry.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/utils.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/flight/tools: Removed.
- DoYouEvenBench/flightjs-example-app/components/flight/tools/debug: Removed.
- DoYouEvenBench/flightjs-example-app/components/flight/tools/debug/debug.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight: Removed.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight/LICENSE.md: Removed.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight/README.md: Removed.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight/bower.json: Removed.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight/lib: Removed.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight/lib/jasmine-flight.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/jasmine-jquery: Removed.
- DoYouEvenBench/flightjs-example-app/components/jasmine-jquery/lib: Removed.
- DoYouEvenBench/flightjs-example-app/components/jasmine-jquery/lib/jasmine-jquery.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/jquery: Removed.
- DoYouEvenBench/flightjs-example-app/components/jquery/component.json: Removed.
- DoYouEvenBench/flightjs-example-app/components/jquery/composer.json: Removed.
- DoYouEvenBench/flightjs-example-app/components/jquery/jquery.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/jquery/jquery.min.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/mustache: Removed.
- DoYouEvenBench/flightjs-example-app/components/mustache/mustache.js: Removed.
- DoYouEvenBench/flightjs-example-app/components/requirejs: Removed.
- DoYouEvenBench/flightjs-example-app/components/requirejs/require.js: Removed.
- DoYouEvenBench/flightjs-example-app/index.html: Removed.
- DoYouEvenBench/flightjs-example-app/karma.conf.js: Removed.
- DoYouEvenBench/flightjs-example-app/package.json: Removed.
- DoYouEvenBench/flightjs-example-app/requireMain.js: Removed.
- DoYouEvenBench/resources/benchmark-runner.js:
- DoYouEvenBench/resources/flightjs-example-app: Copied from PerformanceTests/DoYouEvenBench/flightjs-example-app.
- DoYouEvenBench/resources/todomvc: Copied from PerformanceTests/DoYouEvenBench/todomvc.
- DoYouEvenBench/todomvc: Removed.
- DoYouEvenBench/todomvc/architecture-examples: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower.json: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular-mocks: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular-mocks/angular-mocks.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular/angular.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.css: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/bg.png: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/index.html: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/app.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/controllers: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/controllers/todoCtrl.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoBlur.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoEscape.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoFocus.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/services: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/services/todoStorage.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/readme.md: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/test: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/test/config: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/test/config/testacular.conf.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/test/package.json: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/test/readme.md: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit/directivesSpec.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit/todoCtrlSpec.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower.json: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone.localStorage: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone.localStorage/backbone.localStorage.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone/backbone.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/jquery: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/jquery/jquery.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.css: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/bg.png: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/underscore: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/underscore/underscore.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/index.html: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/app.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/collections: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/collections/todos.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/models: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/models/todo.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/routers: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/routers/router.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/views: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/views/app-view.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/views/todo-view.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/backbone/readme.md: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower.json: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter/localstorage_adapter.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/handlebars: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/handlebars/handlebars.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/jquery: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/jquery/jquery.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.css: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/bg.png: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/index.html: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/app.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers/todo_controller.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers/todos_controller.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/libs: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/libs/ember-data.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models/store.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models/todo.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/router.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/views: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/views/edit_todo_view.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/readme.md: Removed.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/test.html: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower.json: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/handlebars: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/handlebars/handlebars.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/jquery: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/jquery/jquery.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.css: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/bg.png: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery/css: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery/css/app.css: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery/index.html: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery/js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery/js/app.js: Removed.
- DoYouEvenBench/todomvc/architecture-examples/jquery/readme.md: Removed.
- DoYouEvenBench/todomvc/labs: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower.json: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/LICENSE: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/README.md: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/director.js: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/director.min.js: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/ender.js: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/JSXTransformer.js: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/bower.json: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/react.js: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/react.min.js: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.css: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.js: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/bg.png: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/index.html: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/js: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/js/app.jsx: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/js/footer.jsx: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/js/todoItem.jsx: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/js/utils.jsx: Removed.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/readme.md: Removed.
- DoYouEvenBench/todomvc/license.md: Removed.
- DoYouEvenBench/todomvc/readme.md: Removed.
- DoYouEvenBench/todomvc/vanilla-examples: Removed.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs: Removed.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower.json: Removed.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components: Removed.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common: Removed.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.css: Removed.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.js: Removed.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/bg.png: Removed.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/index.html: Removed.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js: Removed.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/app.js: Removed.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/controller.js: Removed.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/helpers.js: Removed.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/model.js: Removed.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/store.js: Removed.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/view.js: Removed.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/readme.md: Removed.
- Skipped:
- 12:33 PM Changeset in webkit [162213] by
-
- 4 edits4 adds in trunk
[CSS3] Add rendering support for -webkit-text-align-last
https://bugs.webkit.org/show_bug.cgi?id=99584
Reviewed by David Hyatt.
Source/WebCore:
Add support for the text-align-last CSS3 property, according to the latest specification:
http://dev.w3.org/csswg/css-text-3/#text-align-last-property
Tests: fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify.html
fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::textAlignmentForLine):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout):
LayoutTests:
- fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify-expected.html: Added.
- fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify.html: Added.
- fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify-expected.html: Added.
- fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify.html: Added.
- 12:29 PM Changeset in webkit [162212] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS build after <http://trac.webkit.org/changeset/162208>
(https://bugs.webkit.org/show_bug.cgi?id=127139)
MAC_OS_X_VERSION_MIN_REQUIRED isn't defined when building for iOS. Instead, explicitly
check that we're not PLATFORM(IOS) to avoid defining the enum value CFHTTPCookieStorageAcceptPolicyExclusivelyFromMainDocumentDomain.
- platform/network/cf/CookieJarCFNet.cpp:
- 12:26 PM Changeset in webkit [162211] by
-
- 2 edits in trunk/Tools
[GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
https://bugs.webkit.org/show_bug.cgi?id=82329
Reviewed by Carlos Garcia Campos.
Unskip, this is working fine now.
- Scripts/run-gtk-tests:
(TestRunner):
- 12:13 PM Changeset in webkit [162210] by
-
- 12 edits in trunk
[CSS Shapes] Basic shapes' computed position should be a horizontal and vertical offset
https://bugs.webkit.org/show_bug.cgi?id=127010
Reviewed by Rob Buis.
Source/WebCore:
This patch updates the computed position values used for blending to be a horizontal
left offset and a vertical top offset. When positions include a center, bottom, or
right position offset, it is converted to the appropriate top/left coordinate as
a calc expression. Serialized values still use the original bottom/right directions
when present, and also omit the top/left keywords where possible.
Updated parsing and animation tests.
- css/BasicShapeFunctions.cpp:
(WebCore::valueForCenterCoordinate): Use the simplified BasicShapeCenterCoordinate,
which includes an offset and whether the direction is from the top/left or bottom/right.
(WebCore::valueForBasicShape): Ditto.
(WebCore::convertToCenterCoordinate): Ditto.
(WebCore::basicShapeForValue): Ditto.
(WebCore::floatValueForCenterCoordinate): Ditto.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc): Remove the RenderBox parameter, which is no longer needed.
- rendering/style/BasicShapes.cpp:
(WebCore::BasicShapeCenterCoordinate::updateComputedLength): Calculate the computed
position offset for this center coordinate.
(WebCore::BasicShapeRectangle::blend): Remove the RenderBox parameter.
(WebCore::DeprecatedBasicShapeCircle::blend): Ditto.
(WebCore::BasicShapeCircle::blend): Ditto.
(WebCore::DeprecatedBasicShapeEllipse::blend): Ditto.
(WebCore::BasicShapeEllipse::blend): Ditto.
(WebCore::BasicShapePolygon::blend): Ditto.
(WebCore::BasicShapeInsetRectangle::blend): Ditto.
(WebCore::BasicShapeInset::blend): Ditto.
- rendering/style/BasicShapes.h:
(WebCore::BasicShapeCenterCoordinate::BasicShapeCenterCoordinate): Simplify
BasicShapeCenterCoordinate to contain an offset and a direction. Also add a
computed length, which is an offset from the top/left direction.
(WebCore::BasicShapeCenterCoordinate::direction):
(WebCore::BasicShapeCenterCoordinate::computedLength):
(WebCore::BasicShapeCenterCoordinate::blend):
LayoutTests:
Update existing parsing and animation tests. For parsing tests, top / left keywords
are omitted whenever possible. For animation tests, animations to bottom / right
offsets will use calc values based from the top / left direction.
- animations/resources/animation-test-helpers.js:
(parseBasicShape): Parse non-numerical arguments to the shape function.
(basicShapeParametersMatch): Match non-numerical arguments to the shape function.
- fast/shapes/parsing/parsing-shape-inside-expected.txt: Update serialized values
to omit top / left keywords when possible.
- fast/shapes/parsing/parsing-shape-outside-expected.txt: Update serialized values
to omit top / left keywords when possible.
- fast/shapes/parsing/parsing-test-utils.js: Modify shape parsing test expectations.
- fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: Ditto.
- fast/shapes/shape-outside-floats/shape-outside-animation.html: Ditto.
- 11:55 AM Changeset in webkit [162209] by
-
- 2 edits in trunk/Source/JavaScriptCore
String::is8Bit() crashes if m_impl is null, handle this.
- API/OpaqueJSString.h:
(OpaqueJSString::OpaqueJSString):
- 11:34 AM Changeset in webkit [162208] by
-
- 2 edits in trunk/Source/WebCore
More non-Mac build fix.
- platform/network/cf/CookieJarCFNet.cpp:
- 11:32 AM Changeset in webkit [162207] by
-
- 3 edits2 adds in trunk
Unprefix text-emphasis CSS properties
https://bugs.webkit.org/show_bug.cgi?id=127160
Reviewed by Sam Weinig.
Source/WebCore:
Add synonym CSS properties. We don't want to delete the old ones because
we've shipped with them included.
Test: fast/css3-text/css3-text-decoration/text-decoration-unprefix.html
- css/CSSPropertyNames.in:
LayoutTests:
Add a reftest to compare the prefixed and unprefixed properties
- fast/css3-text/css3-text-decoration/text-decoration-unprefix-expected.html: Added.
- fast/css3-text/css3-text-decoration/text-decoration-unprefix.html: Added.
- 11:25 AM Changeset in webkit [162206] by
-
- 3 edits in trunk/Source/JavaScriptCore
Try to fix the Windows build.
- API/OpaqueJSString.cpp:
(OpaqueJSString::~OpaqueJSString):
(OpaqueJSString::characters):
- API/OpaqueJSString.h:
(OpaqueJSString::OpaqueJSString):
- 9:44 AM Changeset in webkit [162205] by
-
- 5 edits in trunk/Source/JavaScriptCore
Get rid of OpaqueJSString::deprecatedCharacters()
https://bugs.webkit.org/show_bug.cgi?id=127161
Reviewed by Sam Weinig.
Handle OpaqueJSString::m_string being either 8-bit or 16-bit and add extra
code paths for the 8-bit cases.
Unfortunately, JSStringGetCharactersPtr is still expected to return a 16-bit character pointer.
Handle this by storing a separate 16-bit string and initializing it on demand when JSStringGetCharactersPtr
is called and the backing string is 8-bit.
This has the nice side effect of making JSStringGetCharactersPtr thread-safe when it wasn't before.
(In theory, someone could have a JSStringRef backed by an 8-bit string and call JSStringGetCharactersPtr on it
causing an unsafe upconversion to a 16-bit string).
- API/JSStringRef.cpp:
(JSStringGetCharactersPtr):
Call OpaqueJSString::characters.
(JSStringGetUTF8CString):
Add a code path that handles 8-bit strings.
(JSStringIsEqual):
Call OpaqueJSString::equal.
- API/JSStringRefCF.cpp:
(JSStringCreateWithCFString):
Reformat the code to use an early return instead of putting most of the code inside the body of an if statement.
(JSStringCopyCFString):
Create an 8-bit CFStringRef if possible.
- API/OpaqueJSString.cpp:
(OpaqueJSString::create):
Use nullptr.
(OpaqueJSString::~OpaqueJSString):
Free m_characters.
(OpaqueJSString::characters):
Do the up-conversion and store the result in m_characters.
(OpaqueJSString::equal):
New helper function.
- API/OpaqueJSString.h:
(OpaqueJSString::is8Bit):
New function that returns whether a string is 8-bit or not.
(OpaqueJSString::characters8):
(OpaqueJSString::characters16):
Add getters.
- 9:34 AM Changeset in webkit [162204] by
-
- 2 edits in trunk/Source/WebKit2
Support WebSelections in WK2 on iOS.
https://bugs.webkit.org/show_bug.cgi?id=127015
<rdar://problem/15843090>
Reviewed by Dan Bernstein.
Removing unused variable in selectWithGesture that
causes Release build to fail after r162103.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture):
- 9:21 AM Changeset in webkit [162203] by
-
- 3 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=127138
Add more delegate callback methods to WKWebProcessPlugInLoadDelegate.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-17
Reviewed by Sam Weinig.
Add more WKWebProcessPlugInLoadDelegate callback methods so that a injected
bundle can listen/react to more frame loading events.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h: Add more delegate callback methods for
WKWebProcessPlugInLoadDelegate.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(didCommitLoadForFrame):
(didFinishDocumentLoadForFrame):
(didFailLoadWithErrorForFrame):
(didSameDocumentNavigationForFrame):
(didLayoutForFrame):
(setUpPageLoaderClient):
- 8:00 AM Changeset in webkit [162202] by
-
- 5 edits in trunk/LayoutTests
Unreviewed EFL gardening
- platform/efl/js/dom/dom-static-property-for-in-iteration-expected.txt: Rebaseline after r153772 and r154057.
- platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Rebaseline after r153772 and r154127.
- platform/efl/js/dom/global-constructors-attributes-expected.txt: Ditto.
- platform/efl/js/dom/global-constructors-attributes-shared-worker-expected.txt: Ditto.
- 6:37 AM Changeset in webkit [162201] by
-
- 2 edits in trunk/Source/WebCore
[GTK] WebKitGtk/testcopyandpaste fails in debug builds
https://bugs.webkit.org/show_bug.cgi?id=127173
Reviewed by Carlos Garcia Campos.
Remove duplicate "PasteGlobalSelection" entry.
- editing/EditorCommand.cpp:
(WebCore::createCommandMap):
- 6:32 AM Changeset in webkit [162200] by
-
- 2 edits in trunk/Source/WebCore
Pack ResourceRequest harder.
<https://webkit.org/b/126982>
Re-arrange the members of ResourceRequest to reduce padding,
shrinking it by 8 bytes.
Reviewed by Anders Carlsson.
- platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::ResourceRequestBase):
- 6:04 AM Changeset in webkit [162199] by
-
- 2 edits in trunk/Tools
[GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
https://bugs.webkit.org/show_bug.cgi?id=82328
Reviewed by Carlos Garcia Campos.
This was caused by the icon database being corrupted in the
Release bot. After removing it the test works fine so it can be
run again.
- Scripts/run-gtk-tests:
(TestRunner):
- 4:24 AM Changeset in webkit [162198] by
-
- 60 edits in trunk/Source
Remove workaround for compilers not supporting deleted functions
https://bugs.webkit.org/show_bug.cgi?id=127166
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-17
Reviewed by Andreas Kling.
Source/JavaScriptCore:
- inspector/InspectorAgentRegistry.h:
Source/WebCore:
- bindings/js/JSLazyEventListener.h:
- dom/ContainerNode.h:
- dom/Document.h:
- dom/Element.h:
- rendering/InlineFlowBox.h:
- rendering/InlineTextBox.h:
- rendering/RenderButton.h:
- rendering/RenderCombineText.h:
- rendering/RenderElement.h:
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.h:
- rendering/RenderFrame.h:
- rendering/RenderFrameBase.h:
- rendering/RenderFrameSet.h:
- rendering/RenderHTMLCanvas.h:
- rendering/RenderIFrame.h:
- rendering/RenderLineBreak.h:
- rendering/RenderListBox.h:
- rendering/RenderListMarker.h:
- rendering/RenderMedia.h:
- rendering/RenderMenuList.h:
- rendering/RenderSnapshottedPlugIn.h:
- rendering/RenderTableCell.h:
- rendering/RenderTableRow.h:
- rendering/RenderTableSection.h:
- rendering/RenderText.h:
- rendering/RenderTextControl.h:
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.h:
- rendering/RenderVideo.h:
- rendering/RenderWidget.h:
- rendering/svg/RenderSVGBlock.h:
- rendering/svg/RenderSVGForeignObject.h:
- rendering/svg/RenderSVGImage.h:
- rendering/svg/RenderSVGInline.h:
- rendering/svg/RenderSVGRect.h:
- rendering/svg/RenderSVGResourceClipper.h:
- rendering/svg/RenderSVGResourceFilter.h:
- rendering/svg/RenderSVGResourceFilterPrimitive.h:
- rendering/svg/RenderSVGResourceGradient.h:
- rendering/svg/RenderSVGResourceLinearGradient.h:
- rendering/svg/RenderSVGResourceMarker.h:
- rendering/svg/RenderSVGResourceMasker.h:
- rendering/svg/RenderSVGResourcePattern.h:
- rendering/svg/RenderSVGResourceRadialGradient.h:
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGShape.h:
- rendering/svg/RenderSVGTSpan.h:
- rendering/svg/RenderSVGText.h:
- rendering/svg/RenderSVGTextPath.h:
- rendering/svg/RenderSVGTransformableContainer.h:
- rendering/svg/RenderSVGViewportContainer.h:
- xml/XPathValue.h:
Source/WTF:
- wtf/Compiler.h:
- wtf/Noncopyable.h:
- wtf/PassRefPtr.h:
- 3:46 AM WebKitGTK/2.2.x edited by
- (diff)
- 3:02 AM Changeset in webkit [162197] by
-
- 5 edits in trunk/Source/WebCore
[ATK] Modernize the for loops in ATK AX code
https://bugs.webkit.org/show_bug.cgi?id=127120
Reviewed by Mario Sanchez Prada.
Update the for loops to be range-based in ATK accessibility code.
This work is complementary to r161979.
- accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp:
(webkitAccessibleHypertextGetLink):
- accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):
- accessibility/atk/WebKitAccessibleUtil.cpp:
(accessibilityTitle):
(accessibilityDescription):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(getNChildrenForTable):
(getChildForTable):
(getIndexInParentForCellInRow):
- 1:41 AM Changeset in webkit [162196] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
Fix wrong test expectations added in r162128.
- platform/efl-wk2/TestExpectations:
- 1:23 AM Changeset in webkit [162195] by
-
- 2 edits in trunk/PerformanceTests
Build fix. Skip HTML files that are not tests.
- Skipped:
- 1:18 AM Changeset in webkit [162194] by
-
- 9 edits in trunk/LayoutTests
Allow grammar checking tests to be able to run asynchronously
https://bugs.webkit.org/show_bug.cgi?id=127099
Reviewed by Ryosuke Niwa.
Some grammar checking tests have already used asynchronous text checking path.
Due to WebKit tends to use asynchronous spell checking, this patch adapts grammar
checking tests that used synchronous path to be able to run asynchronously.
Additionally, the tests description was fixed.
- editing/spelling/grammar-edit-word-expected.txt:
- editing/spelling/grammar-edit-word.html:
- editing/spelling/grammar-expected.txt:
- editing/spelling/grammar-markers.html:
- editing/spelling/grammar.html:
- editing/spelling/markers-expected.txt:
- editing/spelling/markers.html:
- platform/mac-wk2/TestExpectations:
Marking markers.html as failing for mac-wk2 due to bug 125690.
- 1:15 AM Changeset in webkit [162193] by
-
- 3 edits in trunk/Source/WebCore
[Soup] Remove unnecessary using-directives for the std namespace
https://bugs.webkit.org/show_bug.cgi?id=127122
Reviewed by Martin Robinson.
- platform/network/soup/ResourceRequestSoup.cpp: Remove the unnecessary using-directive for the std namespace
as no symbols from that namespace are in use in this implementation file.
- platform/network/soup/ResourceResponseSoup.cpp: Ditto.
- 12:16 AM Changeset in webkit [162192] by
-
- 5 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r162185, r162186, and r162187.
http://trac.webkit.org/changeset/162185
http://trac.webkit.org/changeset/162186
http://trac.webkit.org/changeset/162187
https://bugs.webkit.org/show_bug.cgi?id=127164
Broke JSStringCreateWithCharactersNoCopy, as evidenced by a
JSC API test (Requested by ap on #webkit).
- API/JSStringRef.cpp:
(JSStringGetCharactersPtr):
(JSStringGetUTF8CString):
(JSStringIsEqual):
- API/JSStringRefCF.cpp:
(JSStringCreateWithCFString):
(JSStringCopyCFString):
- API/OpaqueJSString.cpp:
(OpaqueJSString::create):
(OpaqueJSString::identifier):
- API/OpaqueJSString.h:
(OpaqueJSString::create):
(OpaqueJSString::characters):
(OpaqueJSString::deprecatedCharacters):
(OpaqueJSString::OpaqueJSString):
Jan 16, 2014:
- 11:59 PM Changeset in webkit [162191] by
-
- 5 edits in trunk/Tools
Test results popovers at http://build.webkit.org/dashboard should link to stderr
https://bugs.webkit.org/show_bug.cgi?id=126929
Reviewed by Timothy Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
(Buildbot.prototype.layoutTestStderrURLForIteration): Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
Add a link to stderr output if present.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
(.test-results-popover .additional-link): Style with light grey (will use the same style
for diff links).
- 11:50 PM Changeset in webkit [162190] by
-
- 7 edits4 adds in trunk/Source/WebKit2
[SOUP] Add stubs for CustomProtocol classes
https://bugs.webkit.org/show_bug.cgi?id=126343
Reviewed by Gustavo Noronha Silva.
- CMakeLists.txt:
- GNUmakefile.am:
- GNUmakefile.list.am:
- PlatformGTK.cmake:
- Shared/Network/CustomProtocols/soup/CustomProtocolManagerSoup.cpp: Added.
(WebKit::generateCustomProtocolID):
(WebKit::WebSoupRequestAsyncData::WebSoupRequestAsyncData):
(WebKit::WebSoupRequestAsyncData::~WebSoupRequestAsyncData):
(WebKit::WebSoupRequestAsyncData::requestFailed):
(WebKit::WebSoupRequestAsyncData::releaseTask):
(WebKit::CustomProtocolManager::supplementName):
(WebKit::CustomProtocolManager::CustomProtocolManager):
(WebKit::CustomProtocolManager::initializeConnection):
(WebKit::CustomProtocolManager::initialize):
- Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode): Move
urlSchemesRegisteredForCustomProtocols encoding out of platform
ifdefs, since it's already guarded by ENABLE(CUSTOM_PROTOCOLS).
(WebKit::NetworkProcessCreationParameters::decode): Ditto.
- Shared/Network/NetworkProcessCreationParameters.h: Ditto.
- UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp: Added.
(WebKit::CustomProtocolManagerProxy::CustomProtocolManagerProxy):
(WebKit::CustomProtocolManagerProxy::startLoading):
(WebKit::CustomProtocolManagerProxy::stopLoading):
- 11:31 PM Changeset in webkit [162189] by
-
- 6 edits in trunk/Source
On iOS, zooming in with a TileController-backed main frame makes hundreds of tiles
https://bugs.webkit.org/show_bug.cgi?id=126531
<rdar://problem/15745862>
Reviewed by Anders Carlsson.
Source/WebCore:
- platform/graphics/ca/mac/TileController.h:
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::tilesWouldChangeForVisibleRect):
(WebCore::TileController::scaledExposedRect):
(WebCore::TileController::computeTileCoverageRect):
(WebCore::TileController::revalidateTiles):
(WebCore::TileController::updateTileCoverageMap):
Scale the FrameView-space exposedRect into document space, to match the visibleRect.
Flipping on WKView's clipsToExposedRect now works correctly even in Safari
or MiniBrowser with zooming.
Source/WebKit2:
- UIProcess/API/ios/WKContentView.mm:
(-[WKContentView _updateViewExposedRect]):
(-[WKContentView setViewportSize:]):
(-[WKContentView didFinishScrollTo:]):
(-[WKContentView didScrollTo:]):
(-[WKContentView didZoomToScale:]):
Because zooming is performed by the UIScrollView, we need to transform
the exposedRect's offset in order to get it in FrameView-relative coordinates.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didFinishZooming):
Save the pageScaleFactor when it changes.
- 11:19 PM Changeset in webkit [162188] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Remove the weak pointer added to the web view in WebKitPrintOperation
https://bugs.webkit.org/show_bug.cgi?id=127098
Reviewed by Martin Robinson.
If the print operation finishes and the web view is still alive,
the weak pointer added to the view should be removed.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(_WebKitPrintOperationPrivate::~_WebKitPrintOperationPrivate):
- 11:08 PM Changeset in webkit [162187] by
-
- 2 edits in trunk/Source/JavaScriptCore
Export OpaqueJSString destructor.
- API/OpaqueJSString.h:
- 11:05 PM Changeset in webkit [162186] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix.
- API/OpaqueJSString.h:
- 10:50 PM Changeset in webkit [162185] by
-
- 5 edits in trunk/Source/JavaScriptCore
Get rid of OpaqueJSString::deprecatedCharacters()
https://bugs.webkit.org/show_bug.cgi?id=127161
Reviewed by Sam Weinig.
Handle OpaqueJSString::m_string being either 8-bit or 16-bit and add extra
code paths for the 8-bit cases.
Unfortunately, JSStringGetCharactersPtr is still expected to return a 16-bit character pointer.
Handle this by storing a separate 16-bit string and initializing it on demand when JSStringGetCharactersPtr
is called. This has the nice side effect of making JSStringGetCharactersPtr thread-safe when it wasn't before.
(In theory, someone could have a JSStringRef backed by an 8-bit string and call JSStringGetCharactersPtr on it
causing an unsafe upconversion to a 16-bit string).
- API/JSStringRef.cpp:
(JSStringGetCharactersPtr):
Call OpaqueJSString::characters.
(JSStringGetUTF8CString):
Add a code path that handles 8-bit strings.
(JSStringIsEqual):
Call OpaqueJSString::equal.
- API/JSStringRefCF.cpp:
(JSStringCreateWithCFString):
Reformat the code to use an early return instead of putting most of the code inside the body of an if statement.
(JSStringCopyCFString):
Create an 8-bit CFStringRef if possible.
- API/OpaqueJSString.cpp:
(OpaqueJSString::create):
Use nullptr.
(OpaqueJSString::~OpaqueJSString):
Free m_characters.
(OpaqueJSString::characters):
Do the up-conversion and store the result in m_characters.
(OpaqueJSString::equal):
New helper function.
- API/OpaqueJSString.h:
(OpaqueJSString::is8Bit):
New function that returns whether a string is 8-bit or not.
(OpaqueJSString::characters8):
(OpaqueJSString::characters16):
Add getters.
- 10:22 PM Changeset in webkit [162184] by
-
- 15 edits in trunk/Source
TextBreakIterator's should support Latin-1 for all iterator types (Part 3)
https://bugs.webkit.org/show_bug.cgi?id=126856
Reviewed by Ryosuke Niwa.
Change all the TextBreakIterator creation functions to take StringViews. Remove a few
now unnecessary up-conversions to UTF-16 in the process.
../WebCore:
- dom/CharacterData.cpp:
- editing/TextCheckingHelper.cpp:
- editing/VisibleUnits.cpp:
- platform/graphics/StringTruncator.cpp:
- platform/graphics/mac/ComplexTextController.cpp:
- platform/text/TextBoundaries.cpp:
- platform/text/TextBreakIterator.cpp:
- platform/text/TextBreakIterator.h:
- rendering/RenderText.cpp:
../WebKit/ios:
- Misc/WebNSStringDrawing.mm:
../WebKit2:
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::nextWordOffset):
(WebKit::TextChecker::checkTextOfParagraph):
- 10:06 PM Changeset in webkit [162183] by
-
- 9 edits in trunk
Automate DoYouEvenBench
https://bugs.webkit.org/show_bug.cgi?id=124497
Reviewed by Geoffrey Garen.
PerformanceTests:
Enable DoYouEvenBench/Full.html on perf bots by default.
Put a space between the time and ms, and fixed a typo in runner.js so that the aggregator name will be reported.
- DoYouEvenBench/Full.html:
- Skipped:
- resources/runner.js:
Tools:
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTestMetric.init): Added the aggregator name as an argument.
(PerfTestMetric.aggregator): Added.
(PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
should be parsed as the metric and the aggregator respectively.
(PerfTest._run_with_driver): Pass in the aggregator name.
(PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
which generates subtests of subtests within a single test file.
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(test_parse_output_with_subtests_and_total): Added.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(_generate_results_dict): Add the aggregator name to the JSON when one is available.
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.
- 9:27 PM Changeset in webkit [162182] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] EwkView can not be shown without re-sizing once it is hidden.
https://bugs.webkit.org/show_bug.cgi?id=127084
Reviewed by Gyuyoung Kim.
Visibility of EwkView can not be controlled by evas_object_show/hide
because EwkView can be shown only if re-sizing is requested, so modify
codes to show EwkView directly if we do not wait for re-sizing.
Additionally, we have to set default value of m_pendingSurfaceResize
to true for accelerated mode to prevent to show black empty view for
the first request to show.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::handleEvasObjectShow):
- 7:42 PM Changeset in webkit [162181] by
-
- 1 edit3 deletes in branches/jsCStack/LayoutTests
Unreviewed, remove sstepanov_container because it is too slow.
- js/regress/script-tests/stepanov_container.js: Removed.
- js/regress/stepanov_container-expected.txt: Removed.
- js/regress/stepanov_container.html: Removed.
- 7:23 PM Changeset in webkit [162180] by
-
- 209 edits in trunk/Source/WebCore
Run clang-modernize and let it add a bunch of missing overrides.
Rubber-stamped by Sam Weinig.
- dom/BeforeLoadEvent.h:
- dom/ClassNodeList.h:
- dom/Comment.h:
- dom/CompositionEvent.h:
- dom/DecodedDataDocumentParser.h:
- dom/DeviceMotionEvent.h:
- dom/DeviceOrientationEvent.h:
- dom/DocumentMarker.cpp:
- dom/DocumentType.h:
- dom/EntityReference.h:
- dom/FocusEvent.h:
- dom/HashChangeEvent.h:
- dom/MessageEvent.h:
- dom/MouseEvent.h:
- dom/MouseRelatedEvent.h:
- dom/MutationEvent.h:
- dom/NameNodeList.h:
- dom/Notation.h:
- dom/OverflowEvent.h:
- dom/PendingScript.h:
- dom/PopStateEvent.h:
- dom/ProcessingInstruction.h:
- dom/ScriptElement.h:
- dom/ScriptExecutionContext.cpp:
- dom/ScriptableDocumentParser.h:
- dom/ScriptedAnimationController.h:
- dom/StringCallback.cpp:
- dom/WheelEvent.h:
- html/FTPDirectoryDocument.h:
- html/FileInputType.cpp:
- html/HTMLAppletElement.h:
- html/HTMLBRElement.h:
- html/HTMLBaseElement.h:
- html/HTMLBodyElement.h:
- html/HTMLButtonElement.h:
- html/HTMLDocument.h:
- html/HTMLEmbedElement.h:
- html/HTMLFormControlsCollection.h:
- html/HTMLFrameElement.h:
- html/HTMLFrameSetElement.h:
- html/HTMLHRElement.h:
- html/HTMLIFrameElement.h:
- html/HTMLKeygenElement.cpp:
- html/HTMLKeygenElement.h:
- html/HTMLLinkElement.h:
- html/HTMLMarqueeElement.h:
- html/HTMLObjectElement.h:
- html/HTMLOutputElement.h:
- html/HTMLParamElement.h:
- html/HTMLScriptElement.h:
- html/HTMLStyleElement.h:
- html/HTMLSummaryElement.h:
- html/HTMLTrackElement.h:
- html/HTMLViewSourceDocument.h:
- html/ImageDocument.cpp:
- html/ImageDocument.h:
- html/MediaDocument.cpp:
- html/MediaDocument.h:
- html/MediaKeyEvent.h:
- html/PluginDocument.cpp:
- html/RadioNodeList.h:
- html/TextDocument.h:
- html/canvas/EXTDrawBuffers.h:
- html/canvas/EXTTextureFilterAnisotropic.h:
- html/canvas/OESElementIndexUint.h:
- html/canvas/OESStandardDerivatives.h:
- html/canvas/OESTextureFloat.h:
- html/canvas/OESTextureFloatLinear.h:
- html/canvas/OESTextureHalfFloat.h:
- html/canvas/OESTextureHalfFloatLinear.h:
- html/canvas/OESVertexArrayObject.h:
- html/canvas/WebGLBuffer.h:
- html/canvas/WebGLCompressedTextureATC.h:
- html/canvas/WebGLCompressedTexturePVRTC.h:
- html/canvas/WebGLCompressedTextureS3TC.h:
- html/canvas/WebGLContextEvent.h:
- html/canvas/WebGLContextObject.h:
- html/canvas/WebGLDebugRendererInfo.h:
- html/canvas/WebGLDebugShaders.h:
- html/canvas/WebGLDepthTexture.h:
- html/canvas/WebGLFramebuffer.cpp:
- html/canvas/WebGLFramebuffer.h:
- html/canvas/WebGLLoseContext.h:
- html/canvas/WebGLProgram.h:
- html/canvas/WebGLRenderbuffer.h:
- html/canvas/WebGLRenderingContext.cpp:
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLShader.h:
- html/canvas/WebGLSharedObject.h:
- html/canvas/WebGLTexture.h:
- html/canvas/WebGLVertexArrayObjectOES.h:
- html/parser/HTMLDocumentParser.h:
- html/parser/HTMLViewSourceParser.h:
- html/shadow/DetailsMarkerControl.h:
- html/shadow/MediaControls.h:
- html/shadow/MediaControlsApple.h:
- html/shadow/MeterShadowElement.h:
- html/shadow/ProgressShadowElement.h:
- html/shadow/SliderThumbElement.h:
- html/track/LoadableTextTrack.h:
- html/track/TrackEvent.h:
- svg/SVGAElement.h:
- svg/SVGAnimateColorElement.h:
- svg/SVGAnimateElement.h:
- svg/SVGAnimateMotionElement.h:
- svg/SVGAnimateTransformElement.h:
- svg/SVGAnimationElement.h:
- svg/SVGCircleElement.h:
- svg/SVGClipPathElement.h:
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGCursorElement.h:
- svg/SVGDefsElement.h:
- svg/SVGDescElement.h:
- svg/SVGEllipseElement.h:
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.h:
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEDistantLightElement.h:
- svg/SVGFEDropShadowElement.h:
- svg/SVGFEFloodElement.h:
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.h:
- svg/SVGFELightElement.h:
- svg/SVGFEMergeElement.h:
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEOffsetElement.h:
- svg/SVGFEPointLightElement.h:
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFESpotLightElement.h:
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/SVGFontData.h:
- svg/SVGForeignObjectElement.h:
- svg/SVGGlyphElement.h:
- svg/SVGGlyphRefElement.h:
- svg/SVGGradientElement.h:
- svg/SVGHKernElement.h:
- svg/SVGImageElement.h:
- svg/SVGImageLoader.h:
- svg/SVGLineElement.h:
- svg/SVGLinearGradientElement.h:
- svg/SVGMPathElement.h:
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.h:
- svg/SVGMissingGlyphElement.h:
- svg/SVGPathBuilder.h:
- svg/SVGPathByteStreamBuilder.h:
- svg/SVGPathByteStreamSource.h:
- svg/SVGPathElement.h:
- svg/SVGPathSegArcAbs.h:
- svg/SVGPathSegArcRel.h:
- svg/SVGPathSegClosePath.h:
- svg/SVGPathSegCurvetoCubicAbs.h:
- svg/SVGPathSegCurvetoCubicRel.h:
- svg/SVGPathSegCurvetoCubicSmoothAbs.h:
- svg/SVGPathSegCurvetoCubicSmoothRel.h:
- svg/SVGPathSegCurvetoQuadraticAbs.h:
- svg/SVGPathSegCurvetoQuadraticRel.h:
- svg/SVGPathSegCurvetoQuadraticSmoothAbs.h:
- svg/SVGPathSegCurvetoQuadraticSmoothRel.h:
- svg/SVGPathSegLinetoAbs.h:
- svg/SVGPathSegLinetoHorizontalAbs.h:
- svg/SVGPathSegLinetoHorizontalRel.h:
- svg/SVGPathSegLinetoRel.h:
- svg/SVGPathSegLinetoVerticalAbs.h:
- svg/SVGPathSegLinetoVerticalRel.h:
- svg/SVGPathSegListBuilder.h:
- svg/SVGPathSegListSource.h:
- svg/SVGPathSegMovetoAbs.h:
- svg/SVGPathSegMovetoRel.h:
- svg/SVGPathStringSource.h:
- svg/SVGPathTraversalStateBuilder.h:
- svg/SVGPatternElement.h:
- svg/SVGPolyElement.h:
- svg/SVGRadialGradientElement.h:
- svg/SVGRectElement.h:
- svg/SVGSVGElement.h:
- svg/SVGScriptElement.h:
- svg/SVGStopElement.h:
- svg/SVGStyleElement.h:
- svg/SVGSwitchElement.h:
- svg/SVGSymbolElement.h:
- svg/SVGTRefElement.h:
- svg/SVGTSpanElement.h:
- svg/SVGTextContentElement.h:
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.h:
- svg/SVGTextPositioningElement.h:
- svg/SVGTitleElement.h:
- svg/SVGUseElement.h:
- svg/SVGVKernElement.h:
- svg/SVGViewElement.h:
- svg/SVGZoomEvent.h:
- svg/animation/SVGSMILElement.cpp:
- svg/animation/SVGSMILElement.h:
- svg/graphics/SVGImageChromeClient.h:
- svg/graphics/filters/SVGFEImage.h:
- svg/graphics/filters/SVGFilter.h:
- svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:
- svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:
- svg/properties/SVGPathSegListPropertyTearOff.h:
- 6:32 PM Changeset in webkit [162179] by
-
- 2 edits in trunk/Tools
platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
https://bugs.webkit.org/show_bug.cgi?id=127141
Reviewed by Alexey Proskuryakov.
Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::~AccessibilityController):
- 6:12 PM Changeset in webkit [162178] by
-
- 8 edits in trunk
REGRESSION(r162145): media/video-controls-visible-audio-only.html fails
https://bugs.webkit.org/show_bug.cgi?id=127147
Source/WebCore:
Reviewed by Eric Carlson.
Reset the MediaSessionManager's restrictions to their default values before
each run.
Add a new virtual method "resetRestrictions()" so that each port-specific
MediaSessionManager can reset the restrictions to their default values.
Call this from Internals::resetToConsistentState() so that tests which change
the restrictions don't affect later tests.
- platform/audio/MediaSessionManager.cpp:
(WebCore::MediaSessionManager::MediaSessionManager):
(WebCore::MediaSessionManager::resetRestrictions):
- platform/audio/MediaSessionManager.h:
(WebCore::MediaSessionManager::~MediaSessionManager):
- platform/audio/ios/MediaSessionManagerIOS.h:
- platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::resetRestrictions):
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
LayoutTests:
Re-enable media/video-controls-visible-audio-only.html.
Reviewed by Eric Carlson.
- platform/mac/TestExpectations:
- 5:58 PM Changeset in webkit [162177] by
-
- 3 edits in trunk/Source/WebKit2
Build Fix: Use standard architectures when building for iOS
Even though we don't use the plug-in services on iOS, we still need
them to build (we won't install them). Be sure we specify valid iOS
architectures when doing so.
- Configurations/PluginService.32.xcconfig:
- Configurations/PluginService.64.xcconfig:
- 5:51 PM Changeset in webkit [162176] by
-
- 2 edits in trunk/Source/WebCore
Compile fix for WinCairo after r162138.
https://bugs.webkit.org/show_bug.cgi?id=127140
Patch by Alex Christensen <achristensen@webkit.org> on 2014-01-16
Reviewed by Beth Dakin.
- page/FrameView.cpp:
(WebCore::FrameView::extendedBackgroundRect):
Use unscaledDocumentRect for extendedBackgroundRect without accelerated compositing.
- 5:45 PM Changeset in webkit [162175] by
-
- 2 edits in trunk/Source/WebKit2
Crash when destroying WKInteractionView.
https://bugs.webkit.org/show_bug.cgi?id=127153
<rdar://problem/15840761>
Reviewed by Anders Carlsson.
UIWKSelectionAssistant is a RetainPtr and it is being
deallocated after the view and its gesture recognizers
have been destroyed.
The parent class UIWebSelectionAssistant assumes to be
deallocated before the view is gone.
We deallocate the interaction assistants explicitly to
fix the problem.
- UIProcess/API/ios/WKInteractionView.mm:
(-[WKInteractionView dealloc]):
- 5:20 PM Changeset in webkit [162174] by
-
- 14 edits in trunk/Source
IDB: delete object store support
<rdar://problem/15779641> and https://bugs.webkit.org/show_bug.cgi?id=127123
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- Modules/indexeddb/IDBTransactionBackendOperations.h:
(WebCore::DeleteObjectStoreOperation::transaction):
Source/WebKit2:
Pipe through Web -> Database -> Web process messaging for delete object store.
Perform dropping the object store in the backing store.
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::deleteObjectStore):
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::didDeleteObjectStore):
(WebKit::UniqueIDBDatabase::deleteObjectStore):
(WebKit::UniqueIDBDatabase::deleteObjectStoreInBackingStore):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
- DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteObjectStore):
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::deleteObjectStore):
(WebKit::WebIDBServerConnection::didDeleteObjectStore):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:
- 5:09 PM Changeset in webkit [162173] by
-
- 2 edits in trunk/Source/WebKit/mac
[iOS] MobileSafari build fix. Declare iOS-specific method mainFrameIconURL
For now, add mainFrameIconURL() to WebView.h. We should further investigate its
usage and API/SPI status.
- WebView/WebView.h:
- 5:04 PM Changeset in webkit [162172] by
-
- 4 edits2 deletes in trunk/Source/WTF
Remove Nix from WTF
https://bugs.webkit.org/show_bug.cgi?id=127150
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-16
Reviewed by Alexey Proskuryakov.
- wtf/DisallowCType.h:
- wtf/FeatureDefines.h:
- wtf/Platform.h:
- wtf/PlatformNix.cmake: Removed.
- wtf/nix: Removed.
- 4:59 PM Changeset in webkit [162171] by
-
- 2 edits in trunk/Source/WebCore
More non-Mac build fix.
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::copyCookiesForURLWithFirstPartyURL):
- 4:46 PM Changeset in webkit [162170] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- platform/network/cf/CookieJarCFNet.cpp: Remove a spurious semicolon.
- 4:41 PM Changeset in webkit [162169] by
-
- 2 edits in trunk/Source/WebCore
Another iOS build fix.
- platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::m_objcObserver):
- 4:40 PM Changeset in webkit [162168] by
-
- 5 edits in branches/safari-537.74-branch/Source
Versioning.
- 4:38 PM Changeset in webkit [162167] by
-
- 1 copy in tags/Safari-537.74.8
New Tag.
- 4:33 PM Changeset in webkit [162166] by
-
- 18 edits in trunk
[Mac] [iOS] Add support for CFHTTPCookieStorageAcceptPolicyExclusivelyFromMainDocumentDomain
https://bugs.webkit.org/show_bug.cgi?id=127139
Reviewed by Brady Eidson.
Source/WebCore:
- platform/ios/WebCoreSystemInterfaceIOS.mm:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Pass first party URL down, because reading cookies depends on it when this policy
in in action.
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::copyCookiesForURLWithFirstPartyURL):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
Use a new CFNetwork API that takes first party URL.
- platform/network/mac/CookieJarMac.mm:
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
Pass first party URL (and null in deleteCookie, as there is none).
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
Removed a call to shouldRelaxThirdPartyCookiePolicy(), which no longer exists
in trunk.
Source/WebKit/mac:
- WebView/WebPreferences.mm: (-[WebPreferences _synchronizeWebStoragePolicyWithCookiePolicy]):
Handle the new case.
Source/WebKit2:
- Shared/HTTPCookieAcceptPolicy.h:
- UIProcess/API/C/WKAPICast.h:
(WebKit::toHTTPCookieAcceptPolicy):
(WebKit::toAPI):
- UIProcess/API/C/WKCookieManager.h:
Added the policy to appropriate switches and enums.
WebKitLibraries:
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMavericks.a:
- libWebKitSystemInterfaceMountainLion.a:
Update WebKitSystemInterface.
- 4:22 PM Changeset in webkit [162165] by
-
- 4 edits in trunk/Source/WebKit
Use final instead of FINAL
Unreviewed build fix.
Source/WebKit/efl:
- WebCoreSupport/ProgressTrackerClientEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/ProgressTrackerClientGtk.h:
- 4:13 PM Changeset in webkit [162164] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS build after r162150.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformInit):
- 3:59 PM Changeset in webkit [162163] by
-
- 2 edits in trunk/Source/WebKit2
Fix build after r162161. One FINAL was still present.
- Shared/cf/KeyedDecoder.h:
- 3:55 PM Changeset in webkit [162162] by
-
- 2 edits in trunk/Source/WebKit/mac
[iOS] Fix UIKit build warning about undefined macro ENABLE_NETSCAPE_PLUGIN_API
- WebView/WebFramePrivate.h: Wrap use of ENABLE_NETSCAPE_PLUGIN_API in TARGET_OS_IPHONE.
- 3:28 PM Changeset in webkit [162161] by
-
- 2 edits in trunk/Source/WTF
Remove FINAL macro
https://bugs.webkit.org/show_bug.cgi?id=127149
Reviewed by Tim Horton.
- wtf/Compiler.h:
- 3:25 PM Changeset in webkit [162160] by
-
- 2 edits in trunk/Source/WebCore
glReadPixels should use UNSIGNED_BYTE on iOS
https://bugs.webkit.org/show_bug.cgi?id=127148
Reviewed by Benjamin Poulain.
We were incorrectly mapping GL_UNSIGNED_INT_8_8_8_8_REV to
GL_RGBA on iOS. It's only used in glReadPixels, so should
be GL_UNSIGNED_BYTE.
This is covered by lots of tests in the Khronos test suite,
that now pass on iOS.
- platform/graphics/ios/GraphicsContext3DIOS.h:
- 3:15 PM Changeset in webkit [162159] by
-
- 3 edits in trunk/Tools
EWS shouldn't comment on Bugzilla for failing builds or style errors
https://bugs.webkit.org/show_bug.cgi?id=127079
Reviewed by Anders Carlsson.
Since patch authors and reviewers could retrieve this information from bubbles,
we shouldn't spam the Bugzilla with useless comments.
We still post style errors but not python paths we used since it's a pure noise.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem._post_reject_message_on_bug):
- Scripts/webkitpy/tool/commands/queues.py:
(StyleQueue.review_patch):
- 3:08 PM Changeset in webkit [162158] by
-
- 563 edits in trunk/Source
Change all uses of FINAL to final now that all our compilers support it
https://bugs.webkit.org/show_bug.cgi?id=127142
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- inspector/JSGlobalObjectInspectorController.h:
- inspector/agents/InspectorAgent.h:
- inspector/remote/RemoteInspector.h:
- inspector/remote/RemoteInspectorDebuggableConnection.h:
- inspector/scripts/CodeGeneratorInspector.py:
(Generator.go):
- runtime/JSGlobalObjectDebuggable.h:
- runtime/JSPromiseReaction.cpp:
Source/WebCore:
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/indexeddb/IDBCursorBackendOperations.h:
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/IDBTransaction.h:
- Modules/indexeddb/IDBTransactionBackendOperations.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
- Modules/mediasource/MediaSource.h:
- Modules/mediasource/MediaSourceRegistry.h:
- Modules/mediasource/SourceBuffer.h:
- Modules/mediasource/SourceBufferList.h:
- Modules/mediastream/AudioStreamTrack.h:
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStreamRegistry.h:
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/RTCDTMFSender.h:
- Modules/mediastream/RTCDataChannel.h:
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/UserMediaRequest.h:
- Modules/mediastream/VideoStreamTrack.h:
- Modules/notifications/Notification.h:
- Modules/speech/SpeechSynthesisUtterance.h:
- Modules/webaudio/AudioContext.h:
- Modules/webaudio/AudioNode.h:
- Modules/websockets/WebSocket.h:
- accessibility/AccessibilityList.h:
- accessibility/AccessibilityListBoxOption.h:
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilitySearchFieldButtons.h:
- accessibility/AccessibilitySlider.h:
- bindings/js/JSCryptoAlgorithmBuilder.h:
- bindings/js/JSCryptoKeySerializationJWK.h:
- bindings/js/JSDOMGlobalObjectTask.cpp:
- bindings/js/JSDOMGlobalObjectTask.h:
- bindings/js/JSLazyEventListener.h:
- bindings/js/ScriptDebugServer.h:
- bindings/js/WorkerScriptDebugServer.h:
- crypto/algorithms/CryptoAlgorithmAES_CBC.h:
- crypto/algorithms/CryptoAlgorithmAES_KW.h:
- crypto/algorithms/CryptoAlgorithmHMAC.h:
- crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
- crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
- crypto/algorithms/CryptoAlgorithmSHA1.h:
- crypto/algorithms/CryptoAlgorithmSHA224.h:
- crypto/algorithms/CryptoAlgorithmSHA256.h:
- crypto/algorithms/CryptoAlgorithmSHA384.h:
- crypto/algorithms/CryptoAlgorithmSHA512.h:
- crypto/keys/CryptoKeyAES.h:
- crypto/keys/CryptoKeyDataOctetSequence.h:
- crypto/keys/CryptoKeyDataRSAComponents.h:
- crypto/keys/CryptoKeyHMAC.h:
- crypto/keys/CryptoKeyRSA.h:
- crypto/keys/CryptoKeySerializationRaw.h:
- crypto/parameters/CryptoAlgorithmAesCbcParams.h:
- crypto/parameters/CryptoAlgorithmAesKeyGenParams.h:
- crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
- crypto/parameters/CryptoAlgorithmHmacParams.h:
- crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h:
- crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHash.h:
- crypto/parameters/CryptoAlgorithmRsaOaepParams.h:
- crypto/parameters/CryptoAlgorithmRsaSsaParams.h:
- css/CSSCanvasValue.h:
- css/CSSFontSelector.h:
- css/CSSStyleSheet.h:
- dom/Attr.h:
- dom/BeforeUnloadEvent.h:
- dom/CDATASection.h:
- dom/CharacterData.h:
- dom/ChildNodeList.h:
- dom/Clipboard.cpp:
- dom/Comment.h:
- dom/DatasetDOMStringMap.h:
- dom/Document.h:
- dom/DocumentEventQueue.cpp:
- dom/DocumentEventQueue.h:
- dom/DocumentType.h:
- dom/Element.h:
- dom/EntityReference.h:
- dom/EventContext.h:
- dom/EventTarget.h:
- dom/FocusEvent.h:
- dom/LiveNodeList.h:
- dom/MessagePort.h:
- dom/MouseEvent.h:
- dom/Node.h:
- dom/Notation.h:
- dom/ProcessingInstruction.h:
- dom/PseudoElement.h:
- dom/ShadowRoot.h:
- dom/StaticNodeList.h:
- dom/StyledElement.h:
- dom/TemplateContentDocumentFragment.h:
- dom/Text.h:
- dom/WebKitNamedFlow.h:
- editing/ios/EditorIOS.mm:
- editing/mac/EditorMac.mm:
- editing/markup.cpp:
- fileapi/Blob.cpp:
- fileapi/FileReader.h:
- html/ClassList.h:
- html/DOMSettableTokenList.h:
- html/FTPDirectoryDocument.cpp:
- html/FormAssociatedElement.cpp:
- html/FormAssociatedElement.h:
- html/HTMLAllCollection.h:
- html/HTMLAnchorElement.h:
- html/HTMLAppletElement.h:
- html/HTMLAreaElement.h:
- html/HTMLAudioElement.h:
- html/HTMLBDIElement.h:
- html/HTMLBRElement.h:
- html/HTMLBaseElement.h:
- html/HTMLBaseFontElement.h:
- html/HTMLBodyElement.h:
- html/HTMLButtonElement.h:
- html/HTMLCanvasElement.h:
- html/HTMLDListElement.h:
- html/HTMLDataListElement.h:
- html/HTMLDetailsElement.h:
- html/HTMLDirectoryElement.h:
- html/HTMLDocument.h:
- html/HTMLElement.h:
- html/HTMLEmbedElement.h:
- html/HTMLFieldSetElement.h:
- html/HTMLFontElement.h:
- html/HTMLFormControlElement.h:
- html/HTMLFormElement.h:
- html/HTMLFrameElement.h:
- html/HTMLFrameSetElement.h:
- html/HTMLHRElement.h:
- html/HTMLHeadElement.h:
- html/HTMLHeadingElement.h:
- html/HTMLHtmlElement.h:
- html/HTMLIFrameElement.h:
- html/HTMLImageElement.h:
- html/HTMLInputElement.h:
- html/HTMLKeygenElement.cpp:
- html/HTMLKeygenElement.h:
- html/HTMLLIElement.h:
- html/HTMLLabelElement.h:
- html/HTMLLegendElement.h:
- html/HTMLLinkElement.h:
- html/HTMLMapElement.h:
- html/HTMLMarqueeElement.h:
- html/HTMLMenuElement.h:
- html/HTMLMetaElement.h:
- html/HTMLMeterElement.h:
- html/HTMLModElement.h:
- html/HTMLNameCollection.h:
- html/HTMLOListElement.h:
- html/HTMLObjectElement.h:
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.h:
- html/HTMLOptionsCollection.h:
- html/HTMLOutputElement.h:
- html/HTMLParagraphElement.h:
- html/HTMLParamElement.h:
- html/HTMLPlugInElement.h:
- html/HTMLPreElement.h:
- html/HTMLProgressElement.h:
- html/HTMLQuoteElement.h:
- html/HTMLScriptElement.h:
- html/HTMLSelectElement.h:
- html/HTMLSourceElement.h:
- html/HTMLStyleElement.h:
- html/HTMLSummaryElement.h:
- html/HTMLTableCaptionElement.h:
- html/HTMLTableCellElement.h:
- html/HTMLTableColElement.h:
- html/HTMLTableElement.h:
- html/HTMLTableRowElement.h:
- html/HTMLTableRowsCollection.h:
- html/HTMLTableSectionElement.h:
- html/HTMLTemplateElement.h:
- html/HTMLTextAreaElement.h:
- html/HTMLTextFormControlElement.h:
- html/HTMLTitleElement.h:
- html/HTMLTrackElement.h:
- html/HTMLUListElement.h:
- html/HTMLUnknownElement.h:
- html/HTMLVideoElement.h:
- html/HTMLViewSourceDocument.h:
- html/ImageDocument.cpp:
- html/ImageDocument.h:
- html/LabelableElement.h:
- html/LabelsNodeList.h:
- html/MediaController.h:
- html/MediaDocument.cpp:
- html/MediaDocument.h:
- html/MediaFragmentURIParser.h:
- html/PluginDocument.cpp:
- html/PluginDocument.h:
- html/RangeInputType.h:
- html/TextDocument.h:
- html/parser/TextDocumentParser.h:
- html/parser/TextViewSourceParser.h:
- html/shadow/DetailsMarkerControl.h:
- html/shadow/MediaControlElementTypes.h:
- html/shadow/MediaControlElements.h:
- html/shadow/MeterShadowElement.h:
- html/shadow/ProgressShadowElement.h:
- html/shadow/SliderThumbElement.h:
- html/shadow/SpinButtonElement.h:
- html/shadow/TextControlInnerElements.h:
- html/shadow/YouTubeEmbedShadowElement.h:
- html/track/TextTrack.h:
- html/track/TextTrackCue.h:
- html/track/TextTrackCueGeneric.cpp:
- html/track/TextTrackCueGeneric.h:
- html/track/TrackListBase.h:
- html/track/WebVTTElement.h:
- inspector/CommandLineAPIModule.h:
- inspector/InjectedScriptCanvasModule.h:
- inspector/InspectorConsoleAgent.cpp:
- inspector/InspectorController.h:
- inspector/InspectorDebuggerAgent.h:
- inspector/PageConsoleAgent.cpp:
- inspector/PageInjectedScriptHost.h:
- inspector/PageInjectedScriptManager.h:
- inspector/WorkerInspectorController.h:
- loader/SinkDocument.cpp:
- loader/SinkDocument.h:
- loader/appcache/DOMApplicationCache.h:
- loader/cache/CachedCSSStyleSheet.h:
- loader/cache/CachedFont.h:
- loader/cache/CachedRawResource.h:
- loader/cache/CachedSVGDocument.h:
- loader/cache/CachedScript.h:
- loader/cache/CachedShader.h:
- loader/cache/CachedTextTrack.h:
- loader/cache/CachedXSLStyleSheet.h:
- loader/icon/IconLoader.h:
- mathml/MathMLSelectElement.h:
- page/DOMTimer.h:
- page/DOMWindow.h:
- page/EventSource.h:
- page/Frame.h:
- page/FrameView.h:
- page/MainFrame.h:
- page/PageDebuggable.h:
- page/PageSerializer.cpp:
- page/Performance.h:
- page/SuspendableTimer.h:
- page/animation/KeyframeAnimation.h:
- page/scrolling/ScrollingStateFixedNode.h:
- page/scrolling/ScrollingStateScrollingNode.h:
- page/scrolling/ScrollingStateStickyNode.h:
- platform/ClockGeneric.h:
- platform/efl/ScrollbarThemeEfl.h:
- platform/graphics/BitmapImage.h:
- platform/graphics/CrossfadeGeneratedImage.h:
- platform/graphics/GradientImage.h:
- platform/graphics/SimpleFontData.h:
- platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
- platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h:
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/win/PlatformCALayerWin.h:
- platform/graphics/cg/PDFDocumentImage.h:
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
- platform/graphics/gstreamer/MediaSourceGStreamer.h:
- platform/graphics/gstreamer/SourceBufferPrivateGStreamer.h:
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
- platform/ios/WebSafeGCActivityCallbackIOS.h:
- platform/ios/WebSafeIncrementalSweeperIOS.h:
- platform/mac/PlatformClockCA.h:
- platform/mac/PlatformClockCM.h:
- platform/mac/ScrollAnimatorMac.h:
- platform/mediastream/MediaStreamTrackPrivate.h:
- platform/mediastream/mac/MediaStreamCenterMac.h:
- platform/mock/MockMediaStreamCenter.h:
- platform/mock/RTCDataChannelHandlerMock.h:
- platform/mock/RTCPeerConnectionHandlerMock.h:
- platform/mock/mediasource/MockBox.h:
- platform/mock/mediasource/MockMediaSourcePrivate.h:
- platform/mock/mediasource/MockSourceBufferPrivate.cpp:
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h:
- platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h:
- platform/text/LocaleNone.cpp:
- platform/text/PlatformLocale.cpp:
- rendering/EllipsisBox.h:
- rendering/FilterEffectRenderer.h:
- rendering/InlineElementBox.h:
- rendering/InlineFlowBox.h:
- rendering/InlineTextBox.h:
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
- rendering/RenderBox.h:
- rendering/RenderButton.h:
- rendering/RenderCombineText.h:
- rendering/RenderCounter.h:
- rendering/RenderDeprecatedFlexibleBox.h:
- rendering/RenderDetailsMarker.h:
- rendering/RenderElement.h:
- rendering/RenderEmbeddedObject.h:
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.h:
- rendering/RenderFlexibleBox.h:
- rendering/RenderFlowThread.h:
- rendering/RenderFrame.h:
- rendering/RenderFrameSet.h:
- rendering/RenderFullScreen.cpp:
- rendering/RenderFullScreen.h:
- rendering/RenderGrid.h:
- rendering/RenderHTMLCanvas.h:
- rendering/RenderIFrame.h:
- rendering/RenderImage.h:
- rendering/RenderInline.h:
- rendering/RenderLayer.h:
- rendering/RenderLayerFilterInfo.h:
- rendering/RenderLineBreak.h:
- rendering/RenderListBox.h:
- rendering/RenderListItem.h:
- rendering/RenderListMarker.h:
- rendering/RenderMedia.h:
- rendering/RenderMediaControlElements.h:
- rendering/RenderMenuList.h:
- rendering/RenderMeter.h:
- rendering/RenderMultiColumnBlock.h:
- rendering/RenderMultiColumnFlowThread.h:
- rendering/RenderMultiColumnSet.h:
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderNamedFlowThread.h:
- rendering/RenderProgress.h:
- rendering/RenderQuote.h:
- rendering/RenderRegion.h:
- rendering/RenderRegionSet.h:
- rendering/RenderReplaced.h:
- rendering/RenderReplica.h:
- rendering/RenderRuby.h:
- rendering/RenderRubyBase.h:
- rendering/RenderRubyRun.h:
- rendering/RenderRubyText.h:
- rendering/RenderScrollbar.h:
- rendering/RenderScrollbarPart.h:
- rendering/RenderSearchField.h:
- rendering/RenderSlider.h:
- rendering/RenderSnapshottedPlugIn.h:
- rendering/RenderTable.h:
- rendering/RenderTableCaption.h:
- rendering/RenderTableCell.h:
- rendering/RenderTableCol.h:
- rendering/RenderTableRow.h:
- rendering/RenderTableSection.h:
- rendering/RenderText.h:
- rendering/RenderTextControl.h:
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.h:
- rendering/RenderTextFragment.h:
- rendering/RenderTextTrackCue.h:
- rendering/RenderVideo.h:
- rendering/RenderView.h:
- rendering/RenderWidget.h:
- rendering/RootInlineBox.h:
- rendering/TrailingFloatsRootInlineBox.h:
- rendering/mathml/RenderMathMLBlock.h:
- rendering/mathml/RenderMathMLFenced.h:
- rendering/mathml/RenderMathMLFraction.h:
- rendering/mathml/RenderMathMLMath.h:
- rendering/mathml/RenderMathMLOperator.h:
- rendering/mathml/RenderMathMLRoot.h:
- rendering/mathml/RenderMathMLRow.h:
- rendering/mathml/RenderMathMLScripts.h:
- rendering/mathml/RenderMathMLSpace.h:
- rendering/mathml/RenderMathMLSquareRoot.h:
- rendering/shapes/ShapeInsideInfo.h:
- rendering/shapes/ShapeOutsideInfo.h:
- rendering/style/ContentData.h:
- rendering/style/StyleCachedImage.h:
- rendering/style/StyleCachedImageSet.h:
- rendering/style/StyleGeneratedImage.h:
- rendering/svg/RenderSVGBlock.h:
- rendering/svg/RenderSVGContainer.h:
- rendering/svg/RenderSVGEllipse.h:
- rendering/svg/RenderSVGForeignObject.h:
- rendering/svg/RenderSVGGradientStop.h:
- rendering/svg/RenderSVGHiddenContainer.h:
- rendering/svg/RenderSVGImage.h:
- rendering/svg/RenderSVGInline.h:
- rendering/svg/RenderSVGInlineText.h:
- rendering/svg/RenderSVGModelObject.h:
- rendering/svg/RenderSVGPath.h:
- rendering/svg/RenderSVGRect.h:
- rendering/svg/RenderSVGResourceClipper.h:
- rendering/svg/RenderSVGResourceContainer.h:
- rendering/svg/RenderSVGResourceFilter.h:
- rendering/svg/RenderSVGResourceFilterPrimitive.h:
- rendering/svg/RenderSVGResourceGradient.h:
- rendering/svg/RenderSVGResourceLinearGradient.h:
- rendering/svg/RenderSVGResourceMarker.h:
- rendering/svg/RenderSVGResourceMasker.h:
- rendering/svg/RenderSVGResourcePattern.h:
- rendering/svg/RenderSVGResourceRadialGradient.h:
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGShape.cpp:
- rendering/svg/RenderSVGShape.h:
- rendering/svg/RenderSVGTSpan.h:
- rendering/svg/RenderSVGText.h:
- rendering/svg/RenderSVGTextPath.h:
- rendering/svg/RenderSVGTransformableContainer.h:
- rendering/svg/RenderSVGViewportContainer.h:
- rendering/svg/SVGInlineFlowBox.h:
- rendering/svg/SVGInlineTextBox.h:
- rendering/svg/SVGRootInlineBox.h:
- rendering/svg/SVGTextRunRenderingContext.h:
- svg/SVGAElement.h:
- svg/SVGAltGlyphDefElement.h:
- svg/SVGAltGlyphElement.h:
- svg/SVGAltGlyphItemElement.h:
- svg/SVGAnimateColorElement.h:
- svg/SVGAnimateMotionElement.h:
- svg/SVGAnimateTransformElement.h:
- svg/SVGAnimatedAngle.h:
- svg/SVGAnimatedBoolean.h:
- svg/SVGAnimatedColor.h:
- svg/SVGAnimatedEnumeration.h:
- svg/SVGAnimatedInteger.h:
- svg/SVGAnimatedIntegerOptionalInteger.h:
- svg/SVGAnimatedLength.h:
- svg/SVGAnimatedLengthList.h:
- svg/SVGAnimatedNumber.h:
- svg/SVGAnimatedNumberList.h:
- svg/SVGAnimatedNumberOptionalNumber.h:
- svg/SVGAnimatedPath.h:
- svg/SVGAnimatedPointList.h:
- svg/SVGAnimatedPreserveAspectRatio.h:
- svg/SVGAnimatedRect.h:
- svg/SVGAnimatedString.h:
- svg/SVGAnimatedTransformList.h:
- svg/SVGCircleElement.h:
- svg/SVGClipPathElement.h:
- svg/SVGCursorElement.h:
- svg/SVGDefsElement.h:
- svg/SVGDescElement.h:
- svg/SVGDocument.h:
- svg/SVGElement.h:
- svg/SVGEllipseElement.h:
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.h:
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEDistantLightElement.h:
- svg/SVGFEDropShadowElement.h:
- svg/SVGFEFloodElement.h:
- svg/SVGFEFuncAElement.h:
- svg/SVGFEFuncBElement.h:
- svg/SVGFEFuncGElement.h:
- svg/SVGFEFuncRElement.h:
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.h:
- svg/SVGFEMergeElement.h:
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEOffsetElement.h:
- svg/SVGFEPointLightElement.h:
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFESpotLightElement.h:
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterElement.h:
- svg/SVGFontElement.h:
- svg/SVGFontFaceElement.h:
- svg/SVGFontFaceFormatElement.h:
- svg/SVGFontFaceNameElement.h:
- svg/SVGFontFaceSrcElement.h:
- svg/SVGFontFaceUriElement.h:
- svg/SVGForeignObjectElement.h:
- svg/SVGGElement.h:
- svg/SVGGlyphElement.h:
- svg/SVGGlyphRefElement.h:
- svg/SVGHKernElement.h:
- svg/SVGImageElement.h:
- svg/SVGLineElement.h:
- svg/SVGLinearGradientElement.h:
- svg/SVGMPathElement.h:
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.h:
- svg/SVGMetadataElement.h:
- svg/SVGMissingGlyphElement.h:
- svg/SVGPathElement.h:
- svg/SVGPathStringBuilder.h:
- svg/SVGPatternElement.h:
- svg/SVGPolygonElement.h:
- svg/SVGPolylineElement.h:
- svg/SVGRadialGradientElement.h:
- svg/SVGRectElement.h:
- svg/SVGSVGElement.h:
- svg/SVGScriptElement.h:
- svg/SVGSetElement.h:
- svg/SVGStopElement.h:
- svg/SVGStyleElement.h:
- svg/SVGSwitchElement.h:
- svg/SVGSymbolElement.h:
- svg/SVGTRefElement.h:
- svg/SVGTSpanElement.h:
- svg/SVGTextContentElement.h:
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.h:
- svg/SVGTitleElement.h:
- svg/SVGUnknownElement.h:
- svg/SVGUseElement.h:
- svg/SVGVKernElement.h:
- svg/SVGViewElement.h:
- svg/animation/SVGSMILElement.h:
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageForContainer.h:
- svg/graphics/filters/SVGFilter.h:
- workers/AbstractWorker.h:
- workers/SharedWorker.h:
- workers/Worker.h:
- workers/WorkerEventQueue.cpp:
- workers/WorkerEventQueue.h:
- workers/WorkerGlobalScope.h:
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestUpload.h:
- xml/XPathFunctions.cpp:
- xml/XPathPath.h:
- xml/XPathPredicate.h:
- xml/XSLStyleSheet.h:
Source/WebKit/ios:
- WebCoreSupport/WebDiskImageCacheClientIOS.h:
Source/WebKit/mac:
- WebCoreSupport/WebUserMediaClient.h:
- WebView/WebScriptDebugger.h:
Source/WebKit2:
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
- NetworkProcess/RemoteNetworkingContext.h:
- Shared/API/Cocoa/RemoteObjectRegistry.h:
- Shared/APIArray.h:
- Shared/APIString.h:
- Shared/AsyncRequest.h:
- Shared/AsyncTask.h:
- Shared/cf/KeyedEncoder.h:
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/efl/WebViewEfl.h:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Storage/StorageAreaImpl.h:
- WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
- WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h:
- 3:00 PM Changeset in webkit [162157] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r162145): media/video-controls-visible-audio-only.html fails
https://bugs.webkit.org/show_bug.cgi?id=127147
- platform/mac/TestExpectations: Marking it as flaky while Jer investigates.
- 2:55 PM Changeset in webkit [162156] by
-
- 2 edits in trunk/Source/JavaScriptCore
throwing an objc object (or general binding object) triggers an assertion
https://bugs.webkit.org/show_bug.cgi?id=127146
Reviewed by Alexey Proskuryakov.
This is simply a bogus assertion as we can't guarantee a bindings object
won't intercept assignment to .stack
- interpreter/Interpreter.cpp:
(JSC::Interpreter::unwind):
- 2:54 PM Changeset in webkit [162155] by
-
- 1 edit2 deletes in trunk/Source/Platform
Remove Nix from Source/Platform
https://bugs.webkit.org/show_bug.cgi?id=127132
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-16
Reviewed by Anders Carlsson.
- PlatformNix.cmake: Removed.
- nix: Removed.
- 2:40 PM Changeset in webkit [162154] by
-
- 8 edits in branches/jsCStack
JSC layout tests should run with the FTL
https://bugs.webkit.org/show_bug.cgi?id=127144
Source/JavaScriptCore:
Not yet reviewed.
Note that this currently leads to the following failures with --ftl-jit. I will
fix them in future commits.
jsc-layout-tests.yaml/js/script-tests/dfg-call-function-hit-watchpoint.js.layout-ftl
jsc-layout-tests.yaml/js/script-tests/dfg-call-function-hit-watchpoint.js.layout-ftl-no-cjit
jsc-layout-tests.yaml/js/script-tests/dfg-call-function-hit-watchpoint.js.layout-ftl-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/dfg-call-method-hit-watchpoint.js.layout-ftl
jsc-layout-tests.yaml/js/script-tests/dfg-call-method-hit-watchpoint.js.layout-ftl-no-cjit
jsc-layout-tests.yaml/js/script-tests/dfg-inline-arguments-use-from-all-the-places.js.layout-ftl-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/dfg-mod-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc.js.layout-ftl-eager-no-cjit
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::numberOfDFGCompiles):
- dfg/DFGTierUpCheckInjectionPhase.cpp:
(JSC::DFG::TierUpCheckInjectionPhase::run):
- runtime/Options.h:
Tools:
Not yet reviewed.
- Scripts/run-jsc-stress-tests:
LayoutTests:
Not yet reviewed.
- js/script-tests/dfg-add-not-number.js:
- 2:21 PM Changeset in webkit [162153] by
-
- 5 edits in tags/Safari-538.12.1/Source
Versioning.
- 2:18 PM Changeset in webkit [162152] by
-
- 1 copy in tags/Safari-538.12.1
New Tag.
- 2:05 PM Changeset in webkit [162151] by
-
- 2 edits in trunk/Source/WebKit2
Fix the build after r162148
- Shared/cf/KeyedEncoder.h: s/OVERRIDE/override/
- 1:56 PM Changeset in webkit [162150] by
-
- 6 edits in trunk/Source/WebCore
Draw all underline segments in a particular run in the same call
https://bugs.webkit.org/show_bug.cgi?id=127082
Reviewed by Simon Fraser.
Instead of running CGContextFillRect() in a loop, we can instead call CGContextFillRects()
In my tests, this seems to have about 0.5% speedup.
This patch creates some redundant code, but I think that refactoring would make the code
much less readable. I also am hesitant to make drawLineForText call drawLinesForText because
of the overhead of the vector that would be needed.
As there is no behavior change, no new tests are necessary
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLinesForText):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformInit):
- platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::drawLinesForText):
- rendering/InlineTextBox.cpp:
(WebCore::drawSkipInkUnderline):
- 1:52 PM Changeset in webkit [162149] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: add more context to Object.addEventListener assertions
https://bugs.webkit.org/show_bug.cgi?id=127125
Reviewed by Joseph Pecoraro.
Log invalid event type and listener parameters, and log the other
parameters so the callsite is easier to figure out.
- UserInterface/Object.js:
(WebInspector.Object.addEventListener):
- 1:45 PM Changeset in webkit [162148] by
-
- 12 edits1 copy1 add in trunk/Source
Use KeyedCoding as a persistent storage mechanism for blobs
https://bugs.webkit.org/show_bug.cgi?id=127012
Reviewed by Anders Carlsson.
Source/WebCore:
Add basic KeyedDecoder interface that is the inverse of KeyedEncoder:
- platform/KeyedCoding.h:
(WebCore::KeyedDecoder::decodeVerifiedEnum):
(WebCore::KeyedDecoder::decodeObject):
(WebCore::KeyedDecoder::decodeObjects):
Use KeyedEncoder/Decoder to encode/decode IDBKeyPath:
- Modules/indexeddb/IDBKeyPath.cpp:
(WebCore::IDBKeyPath::encode):
(WebCore::IDBKeyPath::decode):
- Modules/indexeddb/IDBKeyPath.h:
- WebCore.exp.in:
Source/WebKit2:
Add a way to get the encoded buffer to save:
- Shared/cf/KeyedEncoder.cpp:
(WebKit::KeyedEncoder::finishEncoding):
- Shared/cf/KeyedEncoder.h:
Add a WebKit KeyedDecoder for CF platforms that can decode the previously encoded buffer:
- Shared/cf/KeyedDecoder.cpp: Added.
(WebKit::KeyedDecoder::KeyedDecoder):
(WebKit::KeyedDecoder::~KeyedDecoder):
(WebKit::KeyedDecoder::decodeInt64):
(WebKit::KeyedDecoder::decodeUInt32):
(WebKit::KeyedDecoder::decodeString):
(WebKit::KeyedDecoder::beginObject):
(WebKit::KeyedDecoder::endObject):
(WebKit::KeyedDecoder::beginArray):
(WebKit::KeyedDecoder::beginArrayElement):
(WebKit::KeyedDecoder::endArrayElement):
(WebKit::KeyedDecoder::endArray):
- Shared/cf/KeyedDecoder.h:
Create a WebKit KeyedEncoder/Decoder and use to encode/decode IDBKeyPaths:
- DatabaseProcess/IndexedDB/IDBSerialization.cpp:
(WebKit::serializeIDBKeyPath):
(WebKit::deserializeIDBKeyPath):
- DatabaseProcess/IndexedDB/IDBSerialization.h:
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createObjectStore):
- WebKit2.xcodeproj/project.pbxproj:
- 1:30 PM Changeset in webkit [162147] by
-
- 2 edits in trunk/Source/WebKit2
Stop copying WKOriginDataManager.cpp into WebKit2.framework
https://bugs.webkit.org/show_bug.cgi?id=127100
Reviewed by Sam Weinig.
The file was mistakenly added to the 'All' target. Remove it.
- WebKit2.xcodeproj/project.pbxproj:
- 1:30 PM Changeset in webkit [162146] by
-
- 5 edits in trunk/Source/WebKit2
[iOS] Install WebKit2 XPC services correctly
https://bugs.webkit.org/show_bug.cgi?id=127097
Reviewed by Anders Carlsson.
- Configurations/PluginService.32.xcconfig: Set SKIP_INSTALL to YES on iOS.
- Configurations/PluginService.64.xcconfig: Ditto.
- Configurations/PluginService.Development.xcconfig: Ditto.
- WebKit2.xcodeproj/project.pbxproj: Modified the "Add XPCServices symlink"
build phase to only execute on OS X. Modified the
"Copy XPC services for engineering builds" build phase to copy files
directly to WebKit2.framework/XPCServices/ on iOS, and modified its
output file paths to omit "Versions/A/" (since OS X will have a
XPCServices symlink at the root of the framework bundle).
- 1:26 PM Changeset in webkit [162145] by
-
- 10 edits2 adds in trunk
Allow MediaSessionManager to restrict inline <video> playback
https://bugs.webkit.org/show_bug.cgi?id=127113
Reviewed by Jer Noble.
Source/WebCore:
Test: media/video-fullscreeen-only-playback.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updatePlayState): Drive-by change to not tell the media session that
playback is starting if the media player is already playing. Enter fullscreen if the media
session says it is required.
- html/HTMLMediaSession.cpp:
(WebCore::HTMLMediaSession::clientWillBeginPlayback): Make it const.
(WebCore::HTMLMediaSession::requiresFullscreenForVideoPlayback): New, see if the specified
media element must be played in fullscreen based on the media session settings, document
settings, and attributes.
- html/HTMLMediaSession.h:
- platform/audio/MediaSession.h: pauseSession shouldn't be virtual.
- platform/audio/MediaSessionManager.cpp:
(WebCore::MediaSessionManager::sessionWillBeginPlayback): Return immediately if ConcurrentPlaybackNotPermitted
is not set.
(WebCore::MediaSessionManager::sessionRestrictsInlineVideoPlayback): New.
- platform/audio/MediaSessionManager.h:
- platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::MediaSessionManageriOS): Set InlineVideoPlaybackRestricted if
running on an iPhone or iPod class device.
- testing/Internals.cpp:
(WebCore::Internals::setMediaSessionRestrictions): Support InlineVideoPlaybackRestricted.
LayoutTests:
- media/video-fullscreeen-only-playback-expected.txt: Added.
- media/video-fullscreeen-only-playback.html: Added.
- 1:23 PM Changeset in webkit [162144] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: CallFrame is missing saveIdentityToCookie, or should be excluded
https://bugs.webkit.org/show_bug.cgi?id=126791
Reviewed by Timothy Hatcher.
- UserInterface/CallFrame.js: Add a dummy saveIdentityToCookie() implementation.
- 1:07 PM Changeset in webkit [162143] by
-
- 2 edits in trunk/Source/WebKit2
Build fix for mac following r162141.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h: Switch OVERRIDE to override.
- 12:57 PM Changeset in webkit [162142] by
-
- 5 edits1 add in branches/jsCStack/Source/JavaScriptCore
ArithSin in FTL
https://bugs.webkit.org/show_bug.cgi?id=127129
Patch by Matthew Mirman <mmirman@apple.com> on 2014-01-16
Reviewed by Filip Pizlo.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithSin):
- ftl/FTLOutput.h:
(JSC::FTL::Output::doubleSin):
- tests/stress/ftl-arithsin.js: Added.
- 12:48 PM Changeset in webkit [162141] by
-
- 18 edits in trunk
Add support for handling WebGL load policies.
https://bugs.webkit.org/show_bug.cgi?id=126935
<rdar://problem/15790448>.
Reviewed by Timothy Horton.
Boiler plate code for getting the load policy logic from WebProcess to the UIProcess.
- UIProcess/API/C/WKAPICast.h:
(WebKit::toWebGLLoadPolicy):
- UIProcess/API/C/WKPageLoaderClient.h: Define a new WKPageLoaderClientV4 struct.
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(setUpPageLoaderClient):
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::webGLLoadPolicy):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::webGLPolicyForURL):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::webGLPolicyForURL):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::webGLPolicyForURL): We use a sendSync to get the load policy value from the UIProcess.
- WebProcess/WebPage/WebPage.h:
- WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.
(WTR::TestController::createWebViewWithOptions):
Rename webGLPolicyForSite to webGLPolicyForURL.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::webGLPolicyForURL):
- 12:11 PM Changeset in webkit [162140] by
-
- 3 edits in trunk/Source/WebCore
Guarding HTMLMediaSession with ENABLE(VIDEO)
https://bugs.webkit.org/show_bug.cgi?id=127126
Reviewed by Eric Carlson.
No new tests needed.
- html/HTMLMediaSession.cpp:
- html/HTMLMediaSession.h:
- 11:42 AM Changeset in webkit [162139] by
-
- 1157 edits in trunk
Remove workaround for compilers not supporting explicit override control
https://bugs.webkit.org/show_bug.cgi?id=127111
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-16
Reviewed by Anders Carlsson.
Now all compilers support explicit override control, this workaround can be removed.
Source/JavaScriptCore:
- API/JSAPIWrapperObject.mm:
- API/JSCallbackObject.h:
- API/JSManagedValue.mm:
- API/JSScriptRef.cpp:
- bytecode/CodeBlock.h:
- bytecode/CodeBlockJettisoningWatchpoint.h:
- bytecode/ProfiledCodeBlockJettisoningWatchpoint.h:
- bytecode/StructureStubClearingWatchpoint.h:
- dfg/DFGArrayifySlowPathGenerator.h:
- dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
- dfg/DFGFailedFinalizer.h:
- dfg/DFGJITCode.h:
- dfg/DFGJITFinalizer.h:
- dfg/DFGSaneStringGetByValSlowPathGenerator.h:
- dfg/DFGSlowPathGenerator.h:
- dfg/DFGSpeculativeJIT64.cpp:
- heap/Heap.h:
- heap/IncrementalSweeper.h:
- heap/SuperRegion.h:
- inspector/InspectorValues.h:
- inspector/JSGlobalObjectInspectorController.h:
- inspector/agents/InspectorAgent.h:
- inspector/remote/RemoteInspector.h:
- inspector/remote/RemoteInspectorDebuggableConnection.h:
- inspector/scripts/CodeGeneratorInspector.py:
(Generator.go):
- jit/ClosureCallStubRoutine.h:
- jit/ExecutableAllocatorFixedVMPool.cpp:
- jit/GCAwareJITStubRoutine.h:
- jit/JITCode.h:
- jit/JITToDFGDeferredCompilationCallback.h:
- parser/Nodes.h:
- parser/SourceProvider.h:
- runtime/DataView.h:
- runtime/GCActivityCallback.h:
- runtime/GenericTypedArrayView.h:
- runtime/JSGlobalObjectDebuggable.h:
- runtime/JSPromiseReaction.cpp:
- runtime/RegExpCache.h:
- runtime/SimpleTypedArrayController.h:
- runtime/SymbolTable.h:
- runtime/WeakMapData.h:
Source/WebCore:
- Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h:
- Modules/encryptedmedia/CDMPrivateAVFoundation.h:
- Modules/encryptedmedia/CDMPrivateAVFoundation.mm:
- Modules/encryptedmedia/MediaKeyMessageEvent.h:
- Modules/encryptedmedia/MediaKeyNeededEvent.h:
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/encryptedmedia/MediaKeys.h:
- Modules/geolocation/Geolocation.h:
- Modules/indexeddb/DOMWindowIndexedDatabase.h:
- Modules/indexeddb/IDBCursorBackendOperations.h:
- Modules/indexeddb/IDBCursorWithValue.h:
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
- Modules/indexeddb/IDBOpenDBRequest.h:
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/IDBTransaction.h:
- Modules/indexeddb/IDBTransactionBackendOperations.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
- Modules/indieui/UIRequestEvent.h:
- Modules/mediasource/MediaSource.h:
- Modules/mediasource/MediaSourceRegistry.h:
- Modules/mediasource/SourceBuffer.h:
- Modules/mediasource/SourceBufferList.h:
- Modules/mediastream/AudioStreamTrack.h:
- Modules/mediastream/MediaConstraintsImpl.h:
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStreamRegistry.h:
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/MediaStreamTrackEvent.h:
- Modules/mediastream/MediaStreamTrackSourcesRequest.h:
- Modules/mediastream/RTCDTMFSender.h:
- Modules/mediastream/RTCDataChannel.h:
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/RTCSessionDescriptionRequestImpl.h:
- Modules/mediastream/RTCStatsRequestImpl.h:
- Modules/mediastream/RTCStatsResponse.h:
- Modules/mediastream/RTCVoidRequestImpl.h:
- Modules/mediastream/UserMediaRequest.h:
- Modules/mediastream/VideoStreamTrack.h:
- Modules/networkinfo/NetworkInfoConnection.h:
- Modules/notifications/DOMWindowNotifications.h:
- Modules/notifications/Notification.h:
- Modules/notifications/NotificationCenter.h:
- Modules/plugins/QuickTimePluginReplacement.h:
- Modules/speech/SpeechRecognition.h:
- Modules/speech/SpeechRecognitionError.h:
- Modules/speech/SpeechRecognitionEvent.h:
- Modules/speech/SpeechSynthesis.h:
- Modules/speech/SpeechSynthesisUtterance.h:
- Modules/webaudio/AnalyserNode.h:
- Modules/webaudio/AudioBasicInspectorNode.h:
- Modules/webaudio/AudioBasicProcessorNode.h:
- Modules/webaudio/AudioBufferSourceNode.h:
- Modules/webaudio/AudioContext.h:
- Modules/webaudio/AudioDestinationNode.h:
- Modules/webaudio/AudioNode.h:
- Modules/webaudio/AudioNodeInput.h:
- Modules/webaudio/AudioParam.h:
- Modules/webaudio/AudioProcessingEvent.h:
- Modules/webaudio/BiquadDSPKernel.h:
- Modules/webaudio/BiquadProcessor.h:
- Modules/webaudio/ChannelMergerNode.h:
- Modules/webaudio/ChannelSplitterNode.h:
- Modules/webaudio/ConvolverNode.h:
- Modules/webaudio/DefaultAudioDestinationNode.h:
- Modules/webaudio/DelayDSPKernel.h:
- Modules/webaudio/DelayProcessor.h:
- Modules/webaudio/DynamicsCompressorNode.h:
- Modules/webaudio/GainNode.h:
- Modules/webaudio/MediaElementAudioSourceNode.h:
- Modules/webaudio/MediaStreamAudioDestinationNode.h:
- Modules/webaudio/MediaStreamAudioSourceNode.h:
- Modules/webaudio/OfflineAudioCompletionEvent.h:
- Modules/webaudio/OfflineAudioDestinationNode.h:
- Modules/webaudio/OscillatorNode.h:
- Modules/webaudio/PannerNode.h:
- Modules/webaudio/ScriptProcessorNode.h:
- Modules/webaudio/WaveShaperDSPKernel.h:
- Modules/webaudio/WaveShaperProcessor.h:
- Modules/webdatabase/DatabaseTask.h:
- Modules/webdatabase/SQLTransaction.h:
- Modules/webdatabase/SQLTransactionBackend.h:
- Modules/websockets/CloseEvent.h:
- Modules/websockets/WebSocket.h:
- Modules/websockets/WebSocketChannel.h:
- Modules/websockets/WebSocketDeflateFramer.cpp:
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
- accessibility/AccessibilityARIAGrid.h:
- accessibility/AccessibilityARIAGridCell.h:
- accessibility/AccessibilityARIAGridRow.h:
- accessibility/AccessibilityImageMapLink.h:
- accessibility/AccessibilityList.h:
- accessibility/AccessibilityListBox.h:
- accessibility/AccessibilityListBoxOption.h:
- accessibility/AccessibilityMediaControls.h:
- accessibility/AccessibilityMenuList.h:
- accessibility/AccessibilityMenuListOption.h:
- accessibility/AccessibilityMenuListPopup.h:
- accessibility/AccessibilityMockObject.h:
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityProgressIndicator.h:
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilitySVGRoot.h:
- accessibility/AccessibilityScrollView.h:
- accessibility/AccessibilityScrollbar.h:
- accessibility/AccessibilitySearchFieldButtons.h:
- accessibility/AccessibilitySlider.h:
- accessibility/AccessibilitySpinButton.h:
- accessibility/AccessibilityTable.h:
- accessibility/AccessibilityTableCell.h:
- accessibility/AccessibilityTableColumn.h:
- accessibility/AccessibilityTableHeaderContainer.h:
- accessibility/AccessibilityTableRow.h:
- bindings/js/JSCryptoAlgorithmBuilder.h:
- bindings/js/JSCryptoKeySerializationJWK.h:
- bindings/js/JSDOMGlobalObjectTask.h:
- bindings/js/JSEventListener.h:
- bindings/js/JSLazyEventListener.h:
- bindings/js/JSMutationCallback.h:
- bindings/js/PageScriptDebugServer.h:
- bindings/js/ScriptDebugServer.h:
- bindings/js/WebCoreTypedArrayController.h:
- bindings/js/WorkerScriptDebugServer.h:
- bridge/c/c_class.h:
- bridge/c/c_instance.h:
- bridge/c/c_runtime.h:
- bridge/runtime_root.h:
- crypto/algorithms/CryptoAlgorithmAES_CBC.h:
- crypto/algorithms/CryptoAlgorithmAES_KW.h:
- crypto/algorithms/CryptoAlgorithmHMAC.h:
- crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
- crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
- crypto/algorithms/CryptoAlgorithmSHA1.h:
- crypto/algorithms/CryptoAlgorithmSHA224.h:
- crypto/algorithms/CryptoAlgorithmSHA256.h:
- crypto/algorithms/CryptoAlgorithmSHA384.h:
- crypto/algorithms/CryptoAlgorithmSHA512.h:
- crypto/keys/CryptoKeyAES.h:
- crypto/keys/CryptoKeyHMAC.h:
- crypto/keys/CryptoKeyRSA.h:
- crypto/keys/CryptoKeySerializationRaw.h:
- crypto/parameters/CryptoAlgorithmAesCbcParams.h:
- crypto/parameters/CryptoAlgorithmAesKeyGenParams.h:
- crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
- crypto/parameters/CryptoAlgorithmHmacParams.h:
- crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h:
- crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHash.h:
- crypto/parameters/CryptoAlgorithmRsaOaepParams.h:
- crypto/parameters/CryptoAlgorithmRsaSsaParams.h:
- css/CSSBasicShapes.h:
- css/CSSCanvasValue.h:
- css/CSSCharsetRule.h:
- css/CSSComputedStyleDeclaration.h:
- css/CSSCrossfadeValue.h:
- css/CSSFilterImageValue.h:
- css/CSSFontFaceRule.h:
- css/CSSFontSelector.h:
- css/CSSGroupingRule.h:
- css/CSSHostRule.h:
- css/CSSImportRule.h:
- css/CSSMediaRule.h:
- css/CSSPageRule.h:
- css/CSSStyleRule.h:
- css/CSSStyleSheet.h:
- css/CSSSupportsRule.h:
- css/CSSUnknownRule.h:
- css/FontLoader.cpp:
- css/FontLoader.h:
- css/PropertySetCSSStyleDeclaration.h:
- css/WebKitCSSFilterRule.h:
- css/WebKitCSSKeyframeRule.h:
- css/WebKitCSSKeyframesRule.h:
- css/WebKitCSSRegionRule.h:
- css/WebKitCSSViewportRule.h:
- dom/Attr.h:
- dom/BeforeTextInsertedEvent.h:
- dom/BeforeUnloadEvent.h:
- dom/CDATASection.h:
- dom/CharacterData.h:
- dom/ChildNodeList.h:
- dom/Clipboard.cpp:
- dom/ClipboardEvent.h:
- dom/ContainerNode.h:
- dom/DOMImplementation.cpp:
- dom/DatasetDOMStringMap.h:
- dom/DeviceMotionController.h:
- dom/DeviceOrientationController.h:
- dom/Document.h:
- dom/DocumentEventQueue.cpp:
- dom/DocumentEventQueue.h:
- dom/DocumentFragment.h:
- dom/Element.h:
- dom/ErrorEvent.h:
- dom/EventContext.h:
- dom/EventTarget.h:
- dom/FocusEvent.h:
- dom/KeyboardEvent.h:
- dom/LiveNodeList.h:
- dom/MessagePort.h:
- dom/MouseEvent.h:
- dom/MutationRecord.cpp:
- dom/Node.h:
- dom/PageTransitionEvent.h:
- dom/ProcessingInstruction.h:
- dom/ProgressEvent.h:
- dom/PseudoElement.h:
- dom/ScriptExecutionContext.h:
- dom/ShadowRoot.h:
- dom/StaticNodeList.h:
- dom/StyledElement.h:
- dom/TagNodeList.h:
- dom/TemplateContentDocumentFragment.h:
- dom/Text.h:
- dom/TextEvent.h:
- dom/TouchEvent.h:
- dom/TransitionEvent.h:
- dom/UIEvent.h:
- dom/WebKitAnimationEvent.h:
- dom/WebKitNamedFlow.h:
- dom/WebKitTransitionEvent.h:
- editing/AppendNodeCommand.h:
- editing/ApplyBlockElementCommand.h:
- editing/ApplyStyleCommand.h:
- editing/BreakBlockquoteCommand.h:
- editing/CompositeEditCommand.h:
- editing/DeleteButton.h:
- editing/DeleteFromTextNodeCommand.h:
- editing/EditCommand.h:
- editing/InsertIntoTextNodeCommand.h:
- editing/InsertNodeBeforeCommand.h:
- editing/InsertTextCommand.h:
- editing/MergeIdenticalElementsCommand.h:
- editing/RemoveCSSPropertyCommand.h:
- editing/RemoveNodeCommand.h:
- editing/ReplaceNodeWithSpanCommand.h:
- editing/SetNodeAttributeCommand.h:
- editing/SetSelectionCommand.h:
- editing/SpellChecker.h:
- editing/SpellingCorrectionCommand.cpp:
- editing/SpellingCorrectionCommand.h:
- editing/SplitElementCommand.h:
- editing/SplitTextNodeCommand.h:
- editing/WrapContentsInDummySpanCommand.h:
- editing/ios/EditorIOS.mm:
- editing/markup.cpp:
- fileapi/Blob.cpp:
- fileapi/Blob.h:
- fileapi/File.h:
- fileapi/FileReader.h:
- fileapi/FileThreadTask.h:
- history/BackForwardList.h:
- html/BaseButtonInputType.h:
- html/BaseCheckableInputType.h:
- html/BaseChooserOnlyDateAndTimeInputType.h:
- html/BaseClickableWithKeyInputType.h:
- html/BaseDateAndTimeInputType.h:
- html/BaseTextInputType.h:
- html/ButtonInputType.h:
- html/CheckboxInputType.h:
- html/ClassList.h:
- html/ColorInputType.h:
- html/DOMSettableTokenList.h:
- html/DateInputType.h:
- html/DateTimeInputType.h:
- html/DateTimeLocalInputType.h:
- html/EmailInputType.h:
- html/FTPDirectoryDocument.cpp:
- html/FileInputType.h:
- html/FormAssociatedElement.cpp:
- html/FormAssociatedElement.h:
- html/HTMLAnchorElement.h:
- html/HTMLAppletElement.h:
- html/HTMLAreaElement.h:
- html/HTMLBRElement.h:
- html/HTMLBaseElement.h:
- html/HTMLBodyElement.h:
- html/HTMLButtonElement.h:
- html/HTMLCanvasElement.h:
- html/HTMLDetailsElement.cpp:
- html/HTMLDetailsElement.h:
- html/HTMLDivElement.h:
- html/HTMLDocument.h:
- html/HTMLElement.h:
- html/HTMLEmbedElement.h:
- html/HTMLFieldSetElement.h:
- html/HTMLFontElement.h:
- html/HTMLFormControlElement.h:
- html/HTMLFormControlElementWithState.h:
- html/HTMLFormControlsCollection.h:
- html/HTMLFormElement.h:
- html/HTMLFrameElement.h:
- html/HTMLFrameElementBase.h:
- html/HTMLFrameOwnerElement.h:
- html/HTMLFrameSetElement.h:
- html/HTMLHRElement.h:
- html/HTMLHtmlElement.h:
- html/HTMLIFrameElement.h:
- html/HTMLImageElement.h:
- html/HTMLImageLoader.h:
- html/HTMLInputElement.cpp:
- html/HTMLInputElement.h:
- html/HTMLKeygenElement.h:
- html/HTMLLIElement.h:
- html/HTMLLabelElement.h:
- html/HTMLLegendElement.h:
- html/HTMLLinkElement.h:
- html/HTMLMapElement.h:
- html/HTMLMarqueeElement.h:
- html/HTMLMediaElement.h:
- html/HTMLMediaSession.h:
- html/HTMLMediaSource.h:
- html/HTMLMetaElement.h:
- html/HTMLMeterElement.h:
- html/HTMLModElement.h:
- html/HTMLOListElement.h:
- html/HTMLObjectElement.h:
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.h:
- html/HTMLOutputElement.h:
- html/HTMLParagraphElement.h:
- html/HTMLParamElement.h:
- html/HTMLPlugInElement.h:
- html/HTMLPlugInImageElement.h:
- html/HTMLPreElement.h:
- html/HTMLProgressElement.h:
- html/HTMLQuoteElement.h:
- html/HTMLScriptElement.h:
- html/HTMLSelectElement.h:
- html/HTMLSourceElement.h:
- html/HTMLStyleElement.h:
- html/HTMLSummaryElement.h:
- html/HTMLTableCaptionElement.h:
- html/HTMLTableCellElement.h:
- html/HTMLTableColElement.h:
- html/HTMLTableElement.h:
- html/HTMLTablePartElement.h:
- html/HTMLTableRowsCollection.h:
- html/HTMLTableSectionElement.h:
- html/HTMLTemplateElement.h:
- html/HTMLTextAreaElement.h:
- html/HTMLTextFormControlElement.h:
- html/HTMLTitleElement.h:
- html/HTMLTrackElement.h:
- html/HTMLUListElement.h:
- html/HTMLUnknownElement.h:
- html/HTMLVideoElement.h:
- html/HiddenInputType.h:
- html/ImageDocument.cpp:
- html/ImageInputType.h:
- html/LabelableElement.h:
- html/LabelsNodeList.h:
- html/MediaController.h:
- html/MonthInputType.h:
- html/NumberInputType.h:
- html/PasswordInputType.h:
- html/PluginDocument.h:
- html/RadioInputType.h:
- html/RangeInputType.h:
- html/ResetInputType.h:
- html/SearchInputType.h:
- html/SubmitInputType.h:
- html/TelephoneInputType.h:
- html/TextFieldInputType.h:
- html/TextInputType.h:
- html/TimeInputType.h:
- html/URLInputType.h:
- html/WeekInputType.h:
- html/canvas/CanvasRenderingContext2D.cpp:
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/WebGLRenderingContext.h:
- html/parser/HTMLDocumentParser.h:
- html/parser/TextDocumentParser.h:
- html/shadow/DetailsMarkerControl.h:
- html/shadow/InsertionPoint.h:
- html/shadow/MediaControlElementTypes.h:
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControls.h:
- html/shadow/MediaControlsApple.h:
- html/shadow/MediaControlsGtk.h:
- html/shadow/MeterShadowElement.h:
- html/shadow/ProgressShadowElement.h:
- html/shadow/SliderThumbElement.cpp:
- html/shadow/SliderThumbElement.h:
- html/shadow/SpinButtonElement.h:
- html/shadow/TextControlInnerElements.h:
- html/shadow/YouTubeEmbedShadowElement.h:
- html/track/AudioTrack.h:
- html/track/AudioTrackList.h:
- html/track/InbandGenericTextTrack.h:
- html/track/InbandTextTrack.h:
- html/track/InbandWebVTTTextTrack.h:
- html/track/LoadableTextTrack.h:
- html/track/TextTrack.h:
- html/track/TextTrackCue.h:
- html/track/TextTrackCueGeneric.cpp:
- html/track/TextTrackCueGeneric.h:
- html/track/TextTrackList.h:
- html/track/TrackListBase.h:
- html/track/VideoTrack.h:
- html/track/VideoTrackList.h:
- html/track/WebVTTElement.h:
- inspector/CommandLineAPIModule.h:
- inspector/InjectedScriptCanvasModule.h:
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorCSSAgent.h:
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorConsoleAgent.cpp:
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMStorageAgent.h:
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorHeapProfilerAgent.h:
- inspector/InspectorIndexedDBAgent.cpp:
- inspector/InspectorIndexedDBAgent.h:
- inspector/InspectorInputAgent.h:
- inspector/InspectorLayerTreeAgent.h:
- inspector/InspectorMemoryAgent.h:
- inspector/InspectorPageAgent.h:
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorResourceAgent.h:
- inspector/InspectorTimelineAgent.h:
- inspector/InspectorWorkerAgent.h:
- inspector/PageConsoleAgent.cpp:
- inspector/PageConsoleAgent.h:
- inspector/PageInjectedScriptHost.h:
- inspector/PageInjectedScriptManager.h:
- inspector/PageRuntimeAgent.h:
- inspector/WorkerConsoleAgent.h:
- inspector/WorkerDebuggerAgent.h:
- inspector/WorkerInspectorController.h:
- inspector/WorkerRuntimeAgent.h:
- loader/DocumentLoader.h:
- loader/EmptyClients.h:
- loader/FrameNetworkingContext.h:
- loader/ImageLoader.h:
- loader/NavigationScheduler.cpp:
- loader/NetscapePlugInStreamLoader.h:
- loader/PingLoader.h:
- loader/ResourceLoader.h:
- loader/SubresourceLoader.h:
- loader/WorkerThreadableLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp:
- loader/appcache/ApplicationCacheGroup.h:
- loader/appcache/DOMApplicationCache.h:
- loader/archive/cf/LegacyWebArchive.h:
- loader/cache/CachedCSSStyleSheet.h:
- loader/cache/CachedFont.h:
- loader/cache/CachedFontClient.h:
- loader/cache/CachedImage.h:
- loader/cache/CachedImageClient.h:
- loader/cache/CachedRawResource.h:
- loader/cache/CachedRawResourceClient.h:
- loader/cache/CachedSVGDocument.h:
- loader/cache/CachedSVGDocumentClient.h:
- loader/cache/CachedScript.h:
- loader/cache/CachedShader.h:
- loader/cache/CachedStyleSheetClient.h:
- loader/cache/CachedTextTrack.h:
- loader/cache/CachedXSLStyleSheet.h:
- loader/icon/IconLoader.h:
- mathml/MathMLElement.h:
- mathml/MathMLInlineContainerElement.h:
- mathml/MathMLMathElement.h:
- mathml/MathMLSelectElement.h:
- mathml/MathMLTextElement.h:
- page/CaptionUserPreferencesMediaAF.h:
- page/Chrome.h:
- page/DOMTimer.h:
- page/DOMWindow.h:
- page/DOMWindowExtension.h:
- page/EventSource.h:
- page/Frame.h:
- page/FrameView.h:
- page/PageDebuggable.h:
- page/PageSerializer.cpp:
- page/Performance.h:
- page/SuspendableTimer.h:
- page/animation/ImplicitAnimation.h:
- page/animation/KeyframeAnimation.h:
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ScrollingConstraints.h:
- page/scrolling/ScrollingStateFixedNode.h:
- page/scrolling/ScrollingStateScrollingNode.h:
- page/scrolling/ScrollingStateStickyNode.h:
- page/scrolling/ScrollingTreeScrollingNode.h:
- page/scrolling/ThreadedScrollingTree.h:
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
- page/scrolling/ios/ScrollingCoordinatorIOS.h:
- page/scrolling/ios/ScrollingTreeIOS.h:
- page/scrolling/ios/ScrollingTreeScrollingNodeIOS.h:
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingTreeFixedNode.h:
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
- page/scrolling/mac/ScrollingTreeStickyNode.h:
- pdf/ios/PDFDocument.cpp:
- pdf/ios/PDFDocument.h:
- platform/CalculationValue.h:
- platform/ClockGeneric.h:
- platform/MainThreadTask.h:
- platform/PODIntervalTree.h:
- platform/PODRedBlackTree.h:
- platform/RefCountedSupplement.h:
- platform/ScrollView.h:
- platform/Scrollbar.h:
- platform/Timer.h:
- platform/animation/TimingFunction.h:
- platform/audio/AudioDSPKernelProcessor.h:
- platform/audio/EqualPowerPanner.h:
- platform/audio/HRTFPanner.h:
- platform/audio/ios/AudioDestinationIOS.h:
- platform/audio/mac/AudioDestinationMac.h:
- platform/audio/nix/AudioDestinationNix.h:
- platform/efl/RenderThemeEfl.h:
- platform/efl/ScrollbarEfl.h:
- platform/efl/ScrollbarThemeEfl.h:
- platform/graphics/AudioTrackPrivate.h:
- platform/graphics/BitmapImage.h:
- platform/graphics/CrossfadeGeneratedImage.h:
- platform/graphics/FloatPolygon.h:
- platform/graphics/GeneratedImage.h:
- platform/graphics/GradientImage.h:
- platform/graphics/GraphicsLayer.h:
- platform/graphics/InbandTextTrackPrivate.h:
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/SimpleFontData.h:
- platform/graphics/VideoTrackPrivate.h:
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/VideoTrackPrivateAVF.h:
- platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.h:
- platform/graphics/avfoundation/cf/InbandTextTrackPrivateLegacyAVCF.h:
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
- platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
- platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/TileController.h:
- platform/graphics/ca/win/LegacyCACFLayerTreeHost.h:
- platform/graphics/ca/win/PlatformCALayerWin.h:
- platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:
- platform/graphics/cg/PDFDocumentImage.h:
- platform/graphics/efl/GraphicsContext3DPrivate.h:
- platform/graphics/egl/GLContextFromCurrentEGL.h:
- platform/graphics/filters/DistantLightSource.h:
- platform/graphics/filters/FEComposite.h:
- platform/graphics/filters/FEDisplacementMap.h:
- platform/graphics/filters/FEFlood.h:
- platform/graphics/filters/FilterOperation.h:
- platform/graphics/filters/PointLightSource.h:
- platform/graphics/filters/SpotLightSource.h:
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
- platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
- platform/graphics/ios/InbandTextTrackPrivateAVFIOS.h:
- platform/graphics/ios/MediaPlayerPrivateIOS.h:
- platform/graphics/ios/TextTrackRepresentationIOS.h:
- platform/graphics/surfaces/GLTransportSurface.h:
- platform/graphics/surfaces/egl/EGLContext.h:
- platform/graphics/surfaces/egl/EGLSurface.h:
- platform/graphics/surfaces/egl/EGLXSurface.h:
- platform/graphics/surfaces/glx/GLXContext.h:
- platform/graphics/surfaces/glx/GLXSurface.h:
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- platform/graphics/texmap/TextureMapperGL.h:
- platform/graphics/texmap/TextureMapperImageBuffer.h:
- platform/graphics/texmap/TextureMapperLayer.h:
- platform/graphics/texmap/TextureMapperTiledBackingStore.h:
- platform/graphics/texmap/coordinated/CompositingCoordinator.h:
- platform/graphics/texmap/coordinated/CoordinatedBackingStore.h:
- platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
- platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
- platform/graphics/texmap/coordinated/CoordinatedTile.h:
- platform/graphics/texmap/coordinated/UpdateAtlas.cpp:
- platform/gtk/RenderThemeGtk.h:
- platform/ios/DeviceMotionClientIOS.h:
- platform/ios/DeviceOrientationClientIOS.h:
- platform/ios/ScrollAnimatorIOS.h:
- platform/ios/ScrollbarThemeIOS.h:
- platform/ios/WebSafeGCActivityCallbackIOS.h:
- platform/ios/WebSafeIncrementalSweeperIOS.h:
- platform/mac/PlatformClockCA.h:
- platform/mac/PlatformClockCM.h:
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollbarThemeMac.h:
- platform/mediastream/MediaStreamTrackPrivate.h:
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
- platform/mediastream/mac/AVAudioCaptureSource.h:
- platform/mediastream/mac/AVMediaCaptureSource.h:
- platform/mediastream/mac/AVVideoCaptureSource.h:
- platform/mediastream/mac/MediaStreamCenterMac.h:
- platform/mock/DeviceMotionClientMock.h:
- platform/mock/DeviceOrientationClientMock.h:
- platform/mock/MockMediaStreamCenter.h:
- platform/mock/RTCDataChannelHandlerMock.h:
- platform/mock/RTCNotifiersMock.h:
- platform/mock/RTCPeerConnectionHandlerMock.h:
- platform/mock/mediasource/MockMediaPlayerMediaSource.h:
- platform/mock/mediasource/MockMediaSourcePrivate.h:
- platform/mock/mediasource/MockSourceBufferPrivate.cpp:
- platform/mock/mediasource/MockSourceBufferPrivate.h:
- platform/network/BlobRegistryImpl.h:
- platform/network/BlobResourceHandle.cpp:
- platform/network/BlobResourceHandle.h:
- platform/network/ResourceHandle.h:
- platform/network/SynchronousLoaderClient.h:
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h:
- platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h:
- platform/nix/RenderThemeNix.h:
- platform/nix/ScrollbarThemeNix.h:
- platform/text/LocaleICU.h:
- platform/text/LocaleNone.cpp:
- platform/text/PlatformLocale.cpp:
- platform/text/mac/LocaleMac.h:
- platform/text/win/LocaleWin.h:
- platform/win/PopupMenuWin.h:
- plugins/PluginView.h:
- rendering/AutoTableLayout.h:
- rendering/ClipPathOperation.h:
- rendering/EllipsisBox.h:
- rendering/FilterEffectRenderer.h:
- rendering/FixedTableLayout.h:
- rendering/InlineElementBox.h:
- rendering/InlineFlowBox.h:
- rendering/InlineTextBox.h:
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.h:
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.h:
- rendering/RenderButton.h:
- rendering/RenderCombineText.h:
- rendering/RenderCounter.h:
- rendering/RenderDeprecatedFlexibleBox.h:
- rendering/RenderDetailsMarker.h:
- rendering/RenderElement.h:
- rendering/RenderEmbeddedObject.h:
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.h:
- rendering/RenderFlexibleBox.h:
- rendering/RenderFlowThread.h:
- rendering/RenderFrame.h:
- rendering/RenderFrameSet.h:
- rendering/RenderFullScreen.h:
- rendering/RenderGrid.h:
- rendering/RenderHTMLCanvas.h:
- rendering/RenderIFrame.h:
- rendering/RenderImage.h:
- rendering/RenderImageResourceStyleImage.h:
- rendering/RenderInline.h:
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerFilterInfo.h:
- rendering/RenderLayerModelObject.h:
- rendering/RenderLineBreak.h:
- rendering/RenderListBox.h:
- rendering/RenderListItem.h:
- rendering/RenderListMarker.h:
- rendering/RenderMedia.h:
- rendering/RenderMenuList.h:
- rendering/RenderMeter.h:
- rendering/RenderMultiColumnBlock.h:
- rendering/RenderMultiColumnFlowThread.h:
- rendering/RenderMultiColumnSet.h:
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderNamedFlowThread.h:
- rendering/RenderObject.h:
- rendering/RenderProgress.h:
- rendering/RenderQuote.h:
- rendering/RenderRegion.h:
- rendering/RenderRegionSet.h:
- rendering/RenderReplaced.h:
- rendering/RenderReplica.h:
- rendering/RenderRuby.h:
- rendering/RenderRubyRun.h:
- rendering/RenderRubyText.h:
- rendering/RenderScrollbar.h:
- rendering/RenderScrollbarPart.h:
- rendering/RenderScrollbarTheme.h:
- rendering/RenderSearchField.h:
- rendering/RenderSlider.h:
- rendering/RenderSnapshottedPlugIn.h:
- rendering/RenderTable.h:
- rendering/RenderTableCaption.h:
- rendering/RenderTableCell.h:
- rendering/RenderTableCol.h:
- rendering/RenderTableRow.h:
- rendering/RenderTableSection.h:
- rendering/RenderText.h:
- rendering/RenderTextControl.h:
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.h:
- rendering/RenderTextFragment.h:
- rendering/RenderTextTrackCue.h:
- rendering/RenderThemeIOS.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeSafari.h:
- rendering/RenderThemeWin.h:
- rendering/RenderVideo.h:
- rendering/RenderView.h:
- rendering/RenderWidget.h:
- rendering/RootInlineBox.h:
- rendering/mathml/RenderMathMLBlock.h:
- rendering/mathml/RenderMathMLFenced.h:
- rendering/mathml/RenderMathMLFraction.h:
- rendering/mathml/RenderMathMLMath.h:
- rendering/mathml/RenderMathMLOperator.h:
- rendering/mathml/RenderMathMLRoot.h:
- rendering/mathml/RenderMathMLRow.h:
- rendering/mathml/RenderMathMLScripts.h:
- rendering/mathml/RenderMathMLSpace.h:
- rendering/mathml/RenderMathMLSquareRoot.h:
- rendering/mathml/RenderMathMLUnderOver.h:
- rendering/shapes/BoxShape.h:
- rendering/shapes/PolygonShape.h:
- rendering/shapes/RasterShape.h:
- rendering/shapes/RectangleShape.h:
- rendering/shapes/ShapeInsideInfo.h:
- rendering/shapes/ShapeOutsideInfo.h:
- rendering/style/BasicShapes.h:
- rendering/style/ContentData.h:
- rendering/style/StyleCachedImage.h:
- rendering/style/StyleCachedImageSet.h:
- rendering/style/StyleGeneratedImage.h:
- rendering/style/StylePendingImage.h:
- rendering/svg/RenderSVGBlock.h:
- rendering/svg/RenderSVGContainer.h:
- rendering/svg/RenderSVGForeignObject.h:
- rendering/svg/RenderSVGGradientStop.h:
- rendering/svg/RenderSVGHiddenContainer.h:
- rendering/svg/RenderSVGImage.h:
- rendering/svg/RenderSVGInline.h:
- rendering/svg/RenderSVGInlineText.h:
- rendering/svg/RenderSVGModelObject.h:
- rendering/svg/RenderSVGPath.h:
- rendering/svg/RenderSVGResourceClipper.h:
- rendering/svg/RenderSVGResourceContainer.h:
- rendering/svg/RenderSVGResourceFilter.h:
- rendering/svg/RenderSVGResourceGradient.h:
- rendering/svg/RenderSVGResourceLinearGradient.h:
- rendering/svg/RenderSVGResourceMarker.h:
- rendering/svg/RenderSVGResourceMasker.h:
- rendering/svg/RenderSVGResourcePattern.h:
- rendering/svg/RenderSVGResourceRadialGradient.h:
- rendering/svg/RenderSVGResourceSolidColor.h:
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGShape.cpp:
- rendering/svg/RenderSVGShape.h:
- rendering/svg/RenderSVGText.h:
- rendering/svg/RenderSVGTextPath.h:
- rendering/svg/RenderSVGViewportContainer.h:
- rendering/svg/SVGInlineFlowBox.h:
- rendering/svg/SVGInlineTextBox.h:
- rendering/svg/SVGRootInlineBox.h:
- rendering/svg/SVGTextRunRenderingContext.h:
- storage/StorageAreaImpl.h:
- storage/StorageNamespaceImpl.h:
- svg/SVGAElement.h:
- svg/SVGAltGlyphDefElement.h:
- svg/SVGAltGlyphElement.h:
- svg/SVGAltGlyphItemElement.h:
- svg/SVGAnimateElement.h:
- svg/SVGAnimateMotionElement.h:
- svg/SVGAnimateTransformElement.h:
- svg/SVGAnimatedAngle.h:
- svg/SVGAnimatedBoolean.h:
- svg/SVGAnimatedColor.h:
- svg/SVGAnimatedEnumeration.h:
- svg/SVGAnimatedInteger.h:
- svg/SVGAnimatedIntegerOptionalInteger.h:
- svg/SVGAnimatedLength.h:
- svg/SVGAnimatedLengthList.h:
- svg/SVGAnimatedNumber.h:
- svg/SVGAnimatedNumberList.h:
- svg/SVGAnimatedNumberOptionalNumber.h:
- svg/SVGAnimatedPath.h:
- svg/SVGAnimatedPointList.h:
- svg/SVGAnimatedPreserveAspectRatio.h:
- svg/SVGAnimatedRect.h:
- svg/SVGAnimatedString.h:
- svg/SVGAnimatedTransformList.h:
- svg/SVGAnimationElement.h:
- svg/SVGCircleElement.h:
- svg/SVGClipPathElement.h:
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGCursorElement.h:
- svg/SVGDefsElement.h:
- svg/SVGDocument.h:
- svg/SVGElement.h:
- svg/SVGElementInstance.h:
- svg/SVGEllipseElement.h:
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.h:
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEDropShadowElement.h:
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.h:
- svg/SVGFELightElement.h:
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEOffsetElement.h:
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/SVGFontElement.h:
- svg/SVGFontFaceElement.h:
- svg/SVGFontFaceFormatElement.h:
- svg/SVGFontFaceNameElement.h:
- svg/SVGFontFaceSrcElement.h:
- svg/SVGFontFaceUriElement.h:
- svg/SVGForeignObjectElement.h:
- svg/SVGGElement.h:
- svg/SVGGlyphElement.h:
- svg/SVGGlyphRefElement.h:
- svg/SVGGradientElement.h:
- svg/SVGGraphicsElement.h:
- svg/SVGHKernElement.h:
- svg/SVGImageElement.h:
- svg/SVGLineElement.h:
- svg/SVGLinearGradientElement.h:
- svg/SVGMPathElement.h:
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.h:
- svg/SVGMetadataElement.h:
- svg/SVGPathElement.h:
- svg/SVGPathStringBuilder.h:
- svg/SVGPatternElement.h:
- svg/SVGPolyElement.h:
- svg/SVGRadialGradientElement.h:
- svg/SVGRectElement.h:
- svg/SVGSVGElement.h:
- svg/SVGScriptElement.h:
- svg/SVGSetElement.h:
- svg/SVGStopElement.h:
- svg/SVGStyleElement.h:
- svg/SVGSwitchElement.h:
- svg/SVGSymbolElement.h:
- svg/SVGTRefElement.cpp:
- svg/SVGTRefElement.h:
- svg/SVGTSpanElement.h:
- svg/SVGTextContentElement.h:
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.h:
- svg/SVGTextPositioningElement.h:
- svg/SVGTitleElement.h:
- svg/SVGTransformable.h:
- svg/SVGUnknownElement.h:
- svg/SVGUseElement.h:
- svg/SVGVKernElement.h:
- svg/SVGViewElement.h:
- svg/animation/SVGSMILElement.h:
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageForContainer.h:
- svg/graphics/filters/SVGFilter.h:
- svg/properties/SVGAnimatedListPropertyTearOff.h:
- svg/properties/SVGAnimatedTransformListPropertyTearOff.h:
- svg/properties/SVGListPropertyTearOff.h:
- svg/properties/SVGPathSegListPropertyTearOff.h:
- svg/properties/SVGPropertyTearOff.h:
- testing/InternalSettings.cpp:
- testing/Internals.cpp:
- testing/MockCDM.cpp:
- testing/MockCDM.h:
- workers/AbstractWorker.h:
- workers/DedicatedWorkerGlobalScope.h:
- workers/DedicatedWorkerThread.h:
- workers/SharedWorker.h:
- workers/SharedWorkerGlobalScope.h:
- workers/SharedWorkerThread.h:
- workers/Worker.h:
- workers/WorkerEventQueue.cpp:
- workers/WorkerEventQueue.h:
- workers/WorkerGlobalScope.h:
- workers/WorkerMessagingProxy.h:
- workers/WorkerObjectProxy.h:
- workers/WorkerScriptLoader.h:
- workers/WorkerThread.cpp:
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestUpload.h:
- xml/XPathFunctions.cpp:
- xml/XPathPath.h:
- xml/XPathPredicate.h:
- xml/XSLStyleSheet.h:
Source/WebKit/efl:
- WebCoreSupport/InspectorClientEfl.h:
- WebCoreSupport/ProgressTrackerClientEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/EditorClientGtk.h:
- WebCoreSupport/InspectorClientGtk.h:
- WebCoreSupport/ProgressTrackerClientGtk.h:
Source/WebKit/ios:
- Misc/EmojiFallbackFontSelector.h:
- Storage/WebSQLiteDatabaseTrackerClient.h:
- WebCoreSupport/PopupMenuIOS.h:
- WebCoreSupport/SearchPopupMenuIOS.h:
- WebCoreSupport/WebChromeClientIOS.h:
- WebCoreSupport/WebDiskImageCacheClientIOS.h:
Source/WebKit/mac:
- Storage/WebDatabaseManagerClient.h:
- Storage/WebStorageTrackerClient.h:
- WebCoreSupport/WebAlternativeTextClient.h:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebContextMenuClient.h:
- WebCoreSupport/WebDeviceOrientationClient.h:
- WebCoreSupport/WebDragClient.h:
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameNetworkingContext.h:
- WebCoreSupport/WebGeolocationClient.h:
- WebCoreSupport/WebIconDatabaseClient.h:
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebNotificationClient.h:
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebProgressTrackerClient.h:
- WebCoreSupport/WebUserMediaClient.h:
- WebView/WebScriptDebugger.h:
- WebView/WebViewData.h:
Source/WebKit/win:
- AccessibleDocument.h:
- FullscreenVideoController.cpp:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameNetworkingContext.h:
- WebCoreSupport/WebInspectorClient.h:
- WebHistory.h:
Source/WebKit/wince:
- WebCoreSupport/ChromeClientWinCE.h:
- WebCoreSupport/ContextMenuClientWinCE.h:
- WebCoreSupport/DragClientWinCE.h:
- WebCoreSupport/EditorClientWinCE.h:
- WebCoreSupport/FrameLoaderClientWinCE.h:
- WebCoreSupport/FrameNetworkingContextWinCE.h:
- WebCoreSupport/InspectorClientWinCE.h:
- WebCoreSupport/PlatformStrategiesWinCE.h:
Source/WebKit2:
- DatabaseProcess/DatabaseProcess.h:
- DatabaseProcess/DatabaseToWebProcessConnection.h:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
- NetworkProcess/AsynchronousNetworkLoaderClient.h:
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcessPlatformStrategies.h:
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/RemoteNetworkingContext.h:
- NetworkProcess/SynchronousNetworkLoaderClient.h:
- NetworkProcess/mac/DiskCacheMonitor.h:
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/PluginProcess.h:
- PluginProcess/WebProcessConnection.h:
- Shared/API/Cocoa/RemoteObjectRegistry.h:
- Shared/APIObject.h:
- Shared/AsyncRequest.h:
- Shared/AsyncTask.h:
- Shared/Authentication/AuthenticationManager.h:
- Shared/ChildProcess.h:
- Shared/ChildProcessProxy.h:
- Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
- Shared/Downloads/Download.h:
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
- Shared/WebConnection.h:
- Shared/WebResourceBuffer.h:
- Shared/cf/KeyedEncoder.h:
- Shared/mac/SecItemShim.h:
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/ios/PageClientImplIOS.h:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
- UIProcess/CoordinatedGraphics/WebView.h:
- UIProcess/Databases/DatabaseProcessProxy.h:
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/DrawingAreaProxy.h:
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Notifications/WebNotificationManagerProxy.h:
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Scrolling/RemoteScrollingTree.h:
- UIProcess/Storage/StorageManager.h:
- UIProcess/WebApplicationCacheManagerProxy.h:
- UIProcess/WebBatteryManagerProxy.h:
- UIProcess/WebConnectionToWebProcess.h:
- UIProcess/WebContext.h:
- UIProcess/WebCookieManagerProxy.h:
- UIProcess/WebDatabaseManagerProxy.h:
- UIProcess/WebFullScreenManagerProxy.h:
- UIProcess/WebGeolocationManagerProxy.h:
- UIProcess/WebIconDatabase.h:
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebKeyValueStorageManager.h:
- UIProcess/WebMediaCacheManagerProxy.h:
- UIProcess/WebNetworkInfoManagerProxy.h:
- UIProcess/WebOriginDataManagerProxy.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.h:
- UIProcess/WebResourceCacheManagerProxy.h:
- UIProcess/WebVibrationProxy.h:
- UIProcess/efl/PageViewportControllerClientEfl.h:
- UIProcess/efl/WebViewEfl.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/SecItemShimProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/ViewGestureController.h:
- UIProcess/mac/WebColorPickerMac.h:
- UIProcess/soup/WebSoupRequestManagerProxy.h:
- WebProcess/ApplicationCache/WebApplicationCacheManager.h:
- WebProcess/Battery/WebBatteryManager.h:
- WebProcess/Cookies/WebCookieManager.h:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- WebProcess/Databases/WebToDatabaseProcessConnection.h:
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
- WebProcess/FileAPI/BlobRegistryProxy.h:
- WebProcess/Geolocation/WebGeolocationManager.h:
- WebProcess/IconDatabase/WebIconDatabaseProxy.h:
- WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:
- WebProcess/MediaCache/WebMediaCacheManager.h:
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Network/WebResourceLoadScheduler.h:
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/NetworkInfo/WebNetworkInfoManager.h:
- WebProcess/Notifications/WebNotificationManager.h:
- WebProcess/OriginData/WebOriginDataManager.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/PDF/PDFPluginAnnotation.h:
- WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.h:
- WebProcess/Plugins/PDF/PDFPluginPasswordField.h:
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h:
- WebProcess/Plugins/PluginProcessConnection.h:
- WebProcess/Plugins/PluginProcessConnectionManager.h:
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginView.h:
- WebProcess/ResourceCache/WebResourceCacheManager.h:
- WebProcess/Scrolling/RemoteScrollingCoordinator.h:
- WebProcess/Storage/StorageAreaImpl.h:
- WebProcess/Storage/StorageAreaMap.h:
- WebProcess/Storage/StorageNamespaceImpl.h:
- WebProcess/WebConnectionToUIProcess.h:
- WebProcess/WebCoreSupport/WebAlternativeTextClient.h:
- WebProcess/WebCoreSupport/WebBatteryClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/WebColorChooser.h:
- WebProcess/WebCoreSupport/WebContextMenuClient.h:
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
- WebProcess/WebCoreSupport/WebDeviceProximityClient.h:
- WebProcess/WebCoreSupport/WebDragClient.h:
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebCoreSupport/WebGeolocationClient.h:
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
- WebProcess/WebCoreSupport/WebNavigatorContentUtilsClient.h:
- WebProcess/WebCoreSupport/WebNetworkInfoClient.h:
- WebProcess/WebCoreSupport/WebNotificationClient.h:
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- WebProcess/WebCoreSupport/WebPopupMenu.h:
- WebProcess/WebCoreSupport/WebProgressTrackerClient.h:
- WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
- WebProcess/WebCoreSupport/WebVibrationClient.h:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/EventDispatcher.h:
- WebProcess/WebPage/ViewGestureGeometryCollector.h:
- WebProcess/WebPage/WebBackForwardListProxy.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
- WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
- WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebProcess.h:
- WebProcess/soup/WebSoupRequestManager.h:
Source/WTF:
- wtf/Compiler.h:
- wtf/FilePrintStream.h:
- wtf/RunLoop.h:
- wtf/StringPrintStream.h:
Tools:
- DumpRenderTree/gtk/fonts/fonts.conf:
- Scripts/do-webcore-rename:
Removed this rename operation from the list of contemplated future renames.
- TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
- TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
- 11:34 AM Changeset in webkit [162138] by
-
- 2 edits in trunk/Source/WebCore
Speculative Win Cairo build fix.
These need to be inside an ifdef.
- page/FrameView.cpp:
(WebCore::FrameView::hasExtendedBackground):
(WebCore::FrameView::extendedBackgroundRect):
- 11:23 AM Changeset in webkit [162137] by
-
- 2 edits in trunk/Source/WTF
Source/WTF/wtf/Atomics.h:300: Error: bad register name `%bpl'
https://bugs.webkit.org/show_bug.cgi?id=126985
Reviewed by Csaba Osztrogonác.
Use the 'q' constraint to force using a register that allows
access to its lower byte.
- wtf/Atomics.h:
(WTF::weakCompareAndSwap):
- 11:06 AM Changeset in webkit [162136] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: add probe breakpoint action to popup breakpoint editor
https://bugs.webkit.org/show_bug.cgi?id=126931
Reviewed by Timothy Hatcher.
Add probes to the breakpoint action dropdown.
Reuse the "evaluate JavaScript" input UI.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/BreakpointAction.js:
- UserInterface/BreakpointActionView.js:
(WebInspector.BreakpointActionView.displayStringForType):
(WebInspector.BreakpointActionView.prototype._updateBody.switch.break):
- 10:47 AM Changeset in webkit [162135] by
-
- 19 edits6 adds in trunk
text-emphasis-position CSS property doesn't recognize 'left' and 'right'
https://bugs.webkit.org/show_bug.cgi?id=126611
Reviewed by Simon Fraser.
Source/WebCore:
This patch allows the text-emphasis-position to accept the "left" and
"right" CSS values. In horizontal writing modes, these values no not
change behavior. In vertical writing modes, however, these values specify
which side to place the emphasis mark. Similarly, in vertical writing
modes, the "above" and "below" values should not change behavior.
However, in order to keep existing behavior, if neither "left" nor "right"
is specified, we should draw as if the appropriate value were
specified ("over" -> "right" and "under" -> "left"). Note that this
will have to be updated when we implement the
"text-orientation: sideways-left" CSS property.
Tests: fast/text/emphasis-horizontal-left-right.html
fast/text/emphasis-vertical-over-right.html
fast/text/emphasis-vertical-over-under.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderEmphasisPositionFlagsToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTextEmphasisPosition):
- css/CSSParser.h:
- css/CSSPrimitiveValueMappings.h:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::valueToEmphasisPosition):
(WebCore::ApplyPropertyTextEmphasisPosition::applyValue):
(WebCore::ApplyPropertyTextEmphasisPosition::createHandler):
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove):
(WebCore::InlineTextBox::paint):
- rendering/InlineTextBox.h:
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
- rendering/style/StyleRareInheritedData.h:
LayoutTests:
With regards to text-emphasis-position, "left" and "right" are only valid in
vertical writing modes, and "over" and "under" are only valid in horizontal
writing modes.
In order to keep in line with existing pages, specifying "under" without
"left" or "right" should draw text as if "under left" was specified (and
vice-versa).
The default value for text-emphasis-position should be "over right".
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/parsing-text-emphasis-expected.txt:
- fast/css/parsing-text-emphasis.html:
- fast/text/emphasis-horizontal-left-right-expected.html: Added.
- fast/text/emphasis-horizontal-left-right.html: Added.
- fast/text/emphasis-vertical-over-right-expected.html: Added.
- fast/text/emphasis-vertical-over-right.html: Added.
- fast/text/emphasis-vertical-over-under-expected.html: Added.
- fast/text/emphasis-vertical-over-under.html: Added.
- 10:21 AM Changeset in webkit [162134] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add failure test expectations for tests introduced in r162117.
- platform/efl-wk2/TestExpectations:
- 9:43 AM Changeset in webkit [162133] by
-
- 2 edits in trunk/Tools
Stop run-jsc from consuming stderr output
https://bugs.webkit.org/show_bug.cgi?id=127115
Reviewed by Mark Lam.
Simple patch to make run-jsc easier to deal with
- Scripts/run-jsc:
- 9:33 AM Changeset in webkit [162132] by
-
- 7 edits2 adds in trunk
AX: WebKit is not firing AXMenuOpenedNotification
https://bugs.webkit.org/show_bug.cgi?id=126993
Reviewed by Mario Sanchez Prada.
Source/WebCore:
To monitor for menu open notifications, we need to know which children are added to
the render tree, so the childrenChanged() method has been updated to allow for that.
Once we know the new child, we can then check what kind of role it has.
I also found a flakiness issue with DRT where posting a notification back to DRT
would sometimes cause a new notification to be queued, which would then be lost when the
queue was cleared. This was fixed by copying the notifications to post before iterating them.
Test: platform/mac/accessibility/aria-menu-open-notification.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::checkForOpenMenu):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::notificationPostTimerFired):
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::childrenChanged):
- accessibility/AccessibilityNodeObject.h:
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::styleWillChange):
LayoutTests:
- platform/mac/accessibility/aria-menu-open-notification-expected.txt: Added.
- platform/mac/accessibility/aria-menu-open-notification.html: Added.
- 9:07 AM Changeset in webkit [162131] by
-
- 2 edits in trunk/LayoutTests
Merged some more subpixel skipped tests. Unreviewed.
webkit.org/b/126891 is a duplicate of webkit.org/b/126892
- platform/mac/TestExpectations:
- 9:03 AM Changeset in webkit [162130] by
-
- 9 edits2 adds in trunk
AX: WebKit is not firing AXMenuItemSelectedNotification
https://bugs.webkit.org/show_bug.cgi?id=127081
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Monitor for when a menu item either gains focus() or has aria-selected set,
in which case, we need to fire a specific notification.
Test: platform/mac/accessibility/aria-menu-item-selected-notification.html
- accessibility/AXObjectCache.cpp:
(WebCore::nodeHasRole):
This method was declared in the header, but never implemented, leading to compilation issues.
(WebCore::AXObjectCache::handleMenuItemSelected):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
Allow the core class to handle focus changes first, then pass off to platform
(WebCore::AXObjectCache::selectedChildrenChanged):
- accessibility/AXObjectCache.h:
- accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
Allow menu items to expose a description attribute.
LayoutTests:
- platform/mac/accessibility/aria-menu-item-selected-notification-expected.txt: Added.
- platform/mac/accessibility/aria-menu-item-selected-notification.html: Added.
- 8:14 AM Changeset in webkit [162129] by
-
- 2 edits in trunk/WebKitLibraries
Subpixel layout: Enable subpixel layout for Apple Windows.
https://bugs.webkit.org/show_bug.cgi?id=127074
Reviewed by Antti Koivisto.
This should make the Apple Windows bots happier. It probably still needs rebaselining.
- win/tools/vsprops/FeatureDefines.props:
- 7:25 AM Changeset in webkit [162128] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add failure test expectations for media tests.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 7:07 AM Changeset in webkit [162127] by
-
- 2 edits in trunk/Source/WTF
Fix unnecessary checks for Clang compiler if the compiler is MSVC.
https://bugs.webkit.org/show_bug.cgi?id=127037
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-16
Reviewed by Csaba Osztrogonác.
Inside the #if defined(_MSC_VER) there's no need for checking whether the compiler is not Clang.
- wtf/Compiler.h:
- 7:06 AM Changeset in webkit [162126] by
-
- 2 edits in trunk/Source/WTF
Require at least GCC version 4.7
https://bugs.webkit.org/show_bug.cgi?id=127049
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-16
Reviewed by Csaba Osztrogonác.
r161770 added a template alias, so the minimum GCC version is 4.7 now.
Also fixed a typo in the error message about old MSVC version.
- wtf/Compiler.h:
- 7:01 AM Changeset in webkit [162125] by
-
- 2 edits in trunk/Tools
Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
https://bugs.webkit.org/show_bug.cgi?id=126323
Patch by Eva Balazsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2014-01-16
Reviewed by Csaba Osztrogonác.
- gtk/generate-feature-defines-files:
- 6:59 AM Changeset in webkit [162124] by
-
- 2 edits in trunk/LayoutTests
[EFL] Rebaselining after r161404
https://bugs.webkit.org/show_bug.cgi?id=127105
Unreviewed gardening.
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2014-01-16
- platform/efl/editing/selection/after-line-wrap-expected.txt:
- 6:14 AM Changeset in webkit [162123] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Implement TestController::setHidden
https://bugs.webkit.org/show_bug.cgi?id=127036
Reviewed by Gyuyoung Kim.
WebKitTestRunner needs TestController::setHidden implementation to
properly handle page visibility API layout tests after r161105.
- WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::TestController::setHidden):
- 3:12 AM Changeset in webkit [162122] by
-
- 2 edits in trunk/Tools
[GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
https://bugs.webkit.org/show_bug.cgi?id=127083
Reviewed by Carlos Garcia Campos.
When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
The progress entry is then reset back to 0 in that callback and the timeout source is removed.
The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
BrowserWindow object is being finalized, preventing the callback from firing.
- MiniBrowser/gtk/BrowserWindow.c:
(resetEntryProgress):
(webViewLoadProgressChanged):
(browserWindowFinalize):
- 2:53 AM Changeset in webkit [162121] by
-
- 5 edits in trunk/Source/WebKit2
Expose scrollView on WKView
https://bugs.webkit.org/show_bug.cgi?id=127085
Patch by Ian Henderson <ianh@apple.com> on 2014-01-16
Reviewed by Antti Koivisto.
Expose WKView's scroll view as a property. In order to support
clients calling setDelegate:, we create a forwarder object that sends
delegate methods to both WKView (the "internal delegate") and the
publicly-exposed delegate (the "external delegate").
- UIProcess/API/Cocoa/WKView.h:
- UIProcess/API/ios/WKScrollView.h:
- UIProcess/API/ios/WKScrollView.mm:
(-[WKScrollViewDelegateForwarder initWithInternalDelegate:externalDelegate:]):
(-[WKScrollViewDelegateForwarder methodSignatureForSelector:]):
(-[WKScrollViewDelegateForwarder respondsToSelector:]):
(-[WKScrollViewDelegateForwarder forwardInvocation:]):
(-[WKScrollView setInternalDelegate:]):
(-[WKScrollView setDelegate:]):
(-[WKScrollView delegate]):
Pretend like _externalDelegate is the real delegate to avoid exposing
our internal delegate or forwarder object.
(-[WKScrollView _updateDelegate]):
(-[WKScrollView dealloc]):
- UIProcess/API/ios/WKViewIOS.mm:
(-[WKView scrollView]):
(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
- 2:22 AM Changeset in webkit [162120] by
-
- 14 edits1 delete in trunk/Source
[iOS] Fix build issues with exported headers
Source/WebCore:
- Configurations/WebCore.xcconfig: Allowed UIKit to link against
WebCore.
- page/ios/WebEventRegion.h: Removed ENABLE(TOUCH_EVENTS), which are
always enabled on iOS.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Removed WebPluginPrivate.h from
the project.
Source/WebKit/ios:
- Misc/WebNSStringExtrasIOS.h: Changed PLATFORM(IOS) to
TARGET_OS_IPHONE.
Source/WebKit/mac:
- DOM/WebDOMOperationsPrivate.h: Changed PLATFORM(IOS) to
TARGET_OS_IPHONE.
- MigrateHeaders.make: Excluded WAKScrollView.h from normal replacement
rules so that WebCoreFrameScrollView won't inadvertently get changed to
WebKitFrameScrollView.
- Plugins/WebPlugin.h: Moved contents of WebPluginPrivate.h to here in
order to maintain source compatibility.
- Plugins/WebPluginController.mm: Removed an import of WebPluginPrivate.h.
- Plugins/WebPluginPrivate.h: Removed.
- Storage/WebDatabaseManagerPrivate.h: Replaced ENABLE(SQL_DATABASE)
with ENABLE_SQL_DATABASE.
- WebView/WebViewPrivate.h: Added declaration of
-[WebView _touchEventRegions] for source compatibility.
- 1:09 AM Changeset in webkit [162119] by
-
- 8 edits in trunk/Source/WebCore
Rename functions in SVGDocumentExtension
https://bugs.webkit.org/show_bug.cgi?id=127046
Reviewed by Sam Weinig.
Change some function names in SVGDocumentExtension
to make them more descriptive.
Simple refactoring. No new tests.
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::registerResource):
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isIdOfPendingResource):
(WebCore::SVGDocumentExtensions::isElementWithPendingResources):
(WebCore::SVGDocumentExtensions::isPendingResource):
(WebCore::SVGDocumentExtensions::clearHasPendingResourcesIfPossible):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removePendingResource):
(WebCore::SVGDocumentExtensions::removePendingResourceForRemoval):
(WebCore::SVGDocumentExtensions::markPendingResourcesForRemoval):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResourcesForRemovalMap): The name is not great but a bit more descriptive.
- svg/SVGDocumentExtensions.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::buildPendingResourcesIfNeeded):
- svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::buildPendingResource):
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::buildPendingResource):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::buildPendingResource):
Jan 15, 2014:
- 11:37 PM Changeset in webkit [162118] by
-
- 10 edits in trunk/Source
[GTK][EFL][NIX] Do not use PrintContext, Frame and DocumentLoader in Errors
https://bugs.webkit.org/show_bug.cgi?id=127047
Reviewed by Martin Robinson.
Source/WebCore:
Using PrintContext, Frame and DocumentLoader in platform is a
layering violation.
Change printing error methods to receive a failing URL instead of
receiving a PrintContext that was used only to get the failing
URL.
- platform/efl/ErrorsEfl.cpp:
(WebCore::printError):
(WebCore::printerNotFoundError):
(WebCore::invalidPageRangeToPrint):
- platform/efl/ErrorsEfl.h:
- platform/gtk/ErrorsGtk.cpp:
(WebCore::printError):
(WebCore::printerNotFoundError):
(WebCore::invalidPageRangeToPrint):
- platform/gtk/ErrorsGtk.h:
- platform/nix/ErrorsNix.cpp:
(WebCore::printError):
(WebCore::printerNotFoundError):
(WebCore::invalidPageRangeToPrint):
- platform/nix/ErrorsNix.h:
Source/WebKit2:
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::WebPrintOperationGtk::frameURL): Helper function to get
the URL of the frame being printed.
(WebKit::WebPrintOperationGtk::print): Use frameURL() as failing
URL for printing errors.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
- 11:33 PM Changeset in webkit [162117] by
-
- 11 edits26 adds in trunk
[CSS Regions] Enable accelerated compositing for fixed elements in named flows
https://bugs.webkit.org/show_bug.cgi?id=125144
Reviewed by David Hyatt.
Source/WebCore:
Add support for compositing for fixed positioned element that are collected
inside a named flow. Prior to this patch, the fixed positioned elements were
positioned and sized properly but only in the non-compositing scenario.
Tests: compositing/regions/abs-in-named-flow-from-fixed-in-named-flow.html
compositing/regions/fixed-in-diff-named-flows-zIndex.html
compositing/regions/fixed-in-named-flow-clip-descendant.html
compositing/regions/fixed-in-named-flow-from-abs-in-named-flow.html
compositing/regions/fixed-in-named-flow-from-outflow.html
compositing/regions/fixed-in-named-flow-got-transformed-parent.html
compositing/regions/fixed-in-named-flow-lost-transformed-parent.html
compositing/regions/fixed-in-named-flow-overlap-composited.html
compositing/regions/fixed-in-named-flow-position-changed.html
compositing/regions/fixed-in-named-flow-transformed-parent.html
compositing/regions/fixed-in-named-flow-zIndex.html
compositing/regions/fixed-in-named-flow.html
compositing/regions/fixed-transformed-in-named-flow.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::regionForCompositedLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirementsForNamedFlowFixed):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTreeForNamedFlowFixed):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
- rendering/RenderLayerCompositor.h:
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderNamedFlowThread.h:
LayoutTests:
Added new tests and made the existing tests for fixed positioned elements use the
non-compositing mode.
- compositing/regions/abs-in-named-flow-from-fixed-in-named-flow-expected.txt: Added.
- compositing/regions/abs-in-named-flow-from-fixed-in-named-flow.html: Added.
- compositing/regions/fixed-in-diff-named-flows-zIndex-expected.html: Added.
- compositing/regions/fixed-in-diff-named-flows-zIndex.html: Added.
- compositing/regions/fixed-in-named-flow-clip-descendant-expected.txt: Added.
- compositing/regions/fixed-in-named-flow-clip-descendant.html: Added.
- compositing/regions/fixed-in-named-flow-expected.txt: Added.
- compositing/regions/fixed-in-named-flow-from-abs-in-named-flow-expected.txt: Added.
- compositing/regions/fixed-in-named-flow-from-abs-in-named-flow.html: Added.
- compositing/regions/fixed-in-named-flow-from-outflow-expected.txt: Added.
- compositing/regions/fixed-in-named-flow-from-outflow.html: Added.
- compositing/regions/fixed-in-named-flow-got-transformed-parent-expected.txt: Added.
- compositing/regions/fixed-in-named-flow-got-transformed-parent.html: Added.
- compositing/regions/fixed-in-named-flow-lost-transformed-parent-expected.txt: Added.
- compositing/regions/fixed-in-named-flow-lost-transformed-parent.html: Added.
- compositing/regions/fixed-in-named-flow-overlap-composited-expected.txt: Added.
- compositing/regions/fixed-in-named-flow-overlap-composited.html: Added.
- compositing/regions/fixed-in-named-flow-position-changed-expected.html: Added.
- compositing/regions/fixed-in-named-flow-position-changed.html: Added.
- compositing/regions/fixed-in-named-flow-transformed-parent-expected.txt: Added.
- compositing/regions/fixed-in-named-flow-transformed-parent.html: Added.
- compositing/regions/fixed-in-named-flow-zIndex-expected.html: Added.
- compositing/regions/fixed-in-named-flow-zIndex.html: Added.
- compositing/regions/fixed-in-named-flow.html: Added.
- compositing/regions/fixed-transformed-in-named-flow-expected.txt: Added.
- compositing/regions/fixed-transformed-in-named-flow.html: Added.
- fast/regions/repaint/element-in-named-flow-absolute-from-fixed.html:
- fast/regions/repaint/element-in-named-flow-fixed-from-absolute.html:
- fast/regions/repaint/element-inflow-fixed-from-outflow-static.html:
- fast/regions/repaint/element-outflow-static-from-inflow-fixed.html:
- 11:19 PM Changeset in webkit [162116] by
-
- 4 edits in trunk/Source
Fix the iOS build after r162114
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-15
Source/WebCore:
- WebCore.exp.in: Move the symbol to the right section and add the missing symbols for iOS.
Source/WebKit/mac:
- WebView/WebViewPrivate.h: I forgot to remove the declaration, fix that.
- 11:00 PM Changeset in webkit [162115] by
-
- 3 edits4 adds in trunk
[CSS Regions] Fix painting when the composited region has overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=124887
Patch by Mihai Maerean <Mihai Maerean> on 2014-01-15
Reviewed by Alexandru Chiculita.
Source/WebCore:
When the layer of the region is composited, the region receives a GraphicsLayer of its own
so the clipping coordinates (caused by overflow:hidden) must be relative to the
GraphicsLayer coordinates in which the region gets painted.
Also, while the painting is done relative to the location of the region's content box, the
clipping is bound to the padding box of the region.
Tests: compositing/regions/paint-inside-composited-region-overflow-hidden-versus-div.html
compositing/regions/paint-inside-composited-region-overflow-hidden-versus-region.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintFlowThreadIfRegion):
LayoutTests:
- compositing/regions/paint-inside-composited-region-overflow-hidden-versus-div.html: Added.
- compositing/regions/paint-inside-composited-region-overflow-hidden-versus-div-expected.html: Added.
- compositing/regions/paint-inside-composited-region-overflow-hidden-versus-region.html: Added.
- compositing/regions/paint-inside-composited-region-overflow-hidden-versus-region-expected.html: Added.
- 10:42 PM Changeset in webkit [162114] by
-
- 13 edits3 adds in trunk/Source
Move user agent code to WebCore and unify some code between OS X and iOS
https://bugs.webkit.org/show_bug.cgi?id=127080
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-15
Reviewed by Sam Weinig.
Source/WebCore:
Move the duplicated code from WebView and WebPageProxy to two files
in WebCore: UserAgentMac and UserAgentIOS.
- Configurations/WebCore.xcconfig:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- page/ios/UserAgentIOS.mm: Added.
(WebCore::platformSystemRootDirectory):
(WebCore::osMarketingVersion):
(WebCore::standardUserAgentWithApplicationName):
- page/mac/UserAgent.h: Added.
- page/mac/UserAgentMac.mm: Added.
(WebCore::systemMarketingVersionForUserAgentString):
(WebCore::standardUserAgentWithApplicationName):
- platform/ios/WebCoreSystemInterfaceIOS.h:
- platform/ios/WebCoreSystemInterfaceIOS.mm:
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- WebView/WebView.mm:
(userVisibleWebKitVersionString):
(+[WebView _standardUserAgentWithApplicationName:]):
(-[WebView _setUIWebViewUserAgentWithBuildVersion:]):
Source/WebKit2:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::userVisibleWebKitVersionString):
(WebKit::WebPageProxy::standardUserAgent):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::standardUserAgent):
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 9:27 PM Changeset in webkit [162113] by
-
- 2 edits in trunk/Source/WebCore
Fix windows build.
- platform/text/TextAllInOne.cpp:
- 9:05 PM Changeset in webkit [162112] by
-
- 11 edits in trunk/Source
[iOS] Clean up REMOTE_INSPECTOR code in OpenSource after the iOS merge
https://bugs.webkit.org/show_bug.cgi?id=127069
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-15
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj:
Export XPCConnection because it is needed by RemoteInspector.h.
- inspector/remote/RemoteInspectorXPCConnection.h:
- inspector/remote/RemoteInspector.h:
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::startDisabled):
(Inspector::RemoteInspector::shared):
Allow RemoteInspector singleton to start disabled.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(+[WebView _enableRemoteInspector]):
(+[WebView _disableRemoteInspector]):
(+[WebView _disableAutoStartRemoteInspector]):
(+[WebView _isRemoteInspectorEnabled]):
(+[WebView _hasRemoteInspectorSession]):
(-[WebView allowsRemoteInspection]):
Implement with RemoteInspector.h SPIs.
(-[WebView setAllowsRemoteInspection:]):
(-[WebView setHostApplicationBundleId:name:]):
Still unimplemented, update comment.
(-[WebView _didCommitLoadForFrame:]):
Remove dead path, WebCore now pushes updates on navigations.
- WebView/WebViewData.h:
- WebView/WebViewData.mm:
(-[WebViewPrivate init]):
Remove now unused ivar.
- 8:29 PM Changeset in webkit [162111] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Use timestamp when event occurs for touch events.
https://bugs.webkit.org/show_bug.cgi?id=126424
Reviewed by Gyuyoung Kim.
Current time is used for touch event's timestamp instead of timestamp
when event occurs. Timestamp of touch event is used to implement flick
gesture, so it should be real value for accurate gesture processing.
- UIProcess/API/efl/EwkView.cpp:
Function names for handling touch events are changed to distinguish
mouse events and multi events.
(EwkView::setTouchEventsEnabled):
(EwkView::feedTouchEvents):
(EwkView::handleMouseDownForTouch):
(EwkView::handleMouseUpForTouch):
(EwkView::handleMouseMoveForTouch):
(EwkView::handleMultiDownForTouch):
(EwkView::handleMultiUpForTouch):
(EwkView::handleMultiMoveForTouch):
- UIProcess/API/efl/EwkView.h:
- UIProcess/API/efl/GestureRecognizer.cpp:
(WebKit::GestureHandler::handlePan):
(WebKit::GestureRecognizer::processTouchEvent):
(WebKit::GestureRecognizer::noGesture):
(WebKit::GestureRecognizer::singleTapGesture):
(WebKit::GestureRecognizer::doubleTapGesture):
(WebKit::GestureRecognizer::panGesture):
(WebKit::GestureRecognizer::pinchGesture):
- UIProcess/API/efl/GestureRecognizer.h:
- 8:06 PM Changeset in webkit [162110] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. EFL Gardening.
- platform/efl-wk1/TestExpectations:
Unskipped some tests in svg/dynamic-updates which are passing now.
- 7:59 PM Changeset in webkit [162109] by
-
- 8 edits1 delete in trunk/Source/WebCore
TextBreakIterator's should support Latin-1 for all iterator types (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=126856
Reviewed by Ryosuke Niwa.
Move the contents of TextBreakIteratorICU.cpp to TextBreakIterator.cpp and remove TextBreakIteratorICU.cpp.
- CMakeLists.txt:
- GNUmakefile.list.am:
- PlatformGTK.cmake:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/text/TextBreakIterator.cpp:
- platform/text/TextBreakIteratorICU.cpp: Removed.
- 7:40 PM Changeset in webkit [162108] by
-
- 4 edits in trunk/Source/WebCore
MediaSessionManager shouldn't use std::map
https://bugs.webkit.org/show_bug.cgi?id=127003
Reviewed by Sam Weinig.
No new tests, no functional change.
Use an array instead of std::map.
- platform/audio/MediaSessionManager.cpp:
(WebCore::MediaSessionManager::MediaSessionManager):
(WebCore::MediaSessionManager::addRestriction):
(WebCore::MediaSessionManager::removeRestriction):
(WebCore::MediaSessionManager::restrictions):
(WebCore::MediaSessionManager::sessionWillBeginPlayback):
- platform/audio/MediaSessionManager.h:
- 6:18 PM Changeset in webkit [162107] by
-
- 9 edits in trunk/Source
Change Page, FocusController to use ViewState
https://bugs.webkit.org/show_bug.cgi?id=126533
Unreviewed rollout, this caused a regression.
Source/WebCore:
- WebCore.exp.in:
- page/FocusController.cpp:
(WebCore::FocusController::FocusController):
(WebCore::FocusController::setFocused):
(WebCore::FocusController::setActive):
(WebCore::FocusController::setContentIsVisible):
- page/FocusController.h:
(WebCore::FocusController::isActive):
(WebCore::FocusController::isFocused):
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::setIsInWindow):
(WebCore::Page::setIsVisuallyIdle):
(WebCore::Page::setIsVisible):
(WebCore::Page::visibilityState):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):
- page/Page.h:
(WebCore::Page::isVisible):
(WebCore::Page::isInWindow):
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setActive):
(WebKit::WebPage::setViewIsVisible):
(WebKit::WebPage::setFocused):
(WebKit::WebPage::setIsInWindow):
(WebKit::WebPage::setViewStateInternal):
(WebKit::WebPage::setIsVisuallyIdle):
- WebProcess/WebPage/WebPage.h:
- 6:04 PM Changeset in webkit [162106] by
-
- 2 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=127072
Don't autorelease wrapper object (WebProcessPlugInScriptWorld) for InjectedBundleScriptWorld::normalWorld().
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-15
Reviewed by Geoffrey Garen.
In [WKWebProcessPlugInScriptWorld normalWorld], InjectedBundleScriptWorld::normalWorld() returns a static
instance, autoreleasing its wrapper object could cause a dangling pointer and crash later.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.mm:
(+[WKWebProcessPlugInScriptWorld normalWorld]):
- 5:51 PM Changeset in webkit [162105] by
-
- 3 edits in trunk/Source/WebCore
[WebGL] Resizing and entering/exiting full screen draws garbage
https://bugs.webkit.org/show_bug.cgi?id=127077
Reviewed by Dean Jackson.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs): Simplified logic regarding FBO switching.
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Make sure a few things
are turned off that might affect blitting data from one FBO to another.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture): Actually turn dithering off!
(WebCore::GraphicsContext3D::reshape): Mark the context as dirty when resizing so that
the GL view is redrawn during resizing events.
- 5:06 PM Changeset in webkit [162104] by
-
- 5 edits in trunk/Source/WebKit2
[iOS] Properly exclude the shim dylibs this time
https://bugs.webkit.org/show_bug.cgi?id=127075
Reviewed by Anders Carlsson.
BaseLegacyProcess.xcconfig was setting EXCLUDED_SOURCE_FILE_NAMES in
conflict with what I added in r161918, and I misspelled the setting
name in two instances. Fix these two bugs.
Also remove a vestigial OTHER_LDFLAGS from WebContentProcess.xcconfig
while we're here.
- Configurations/BaseLegacyProcess.xcconfig:
- Configurations/NetworkProcess.xcconfig:
- Configurations/PluginProcess.xcconfig:
- Configurations/WebContentProcess.xcconfig:
- 4:52 PM Changeset in webkit [162103] by
-
- 16 edits2 adds in trunk/Source/WebKit2
Support WebSelections in WK2 on iOS.
https://bugs.webkit.org/show_bug.cgi?id=127015
Reviewed by Benjamin Poulain.
This is the first step towards adding support for selections in
non editable content on iOS for WK2.
In particular, this patch adds the basic plumbing to decide which
gesture recognizers are enabled and adds empty stubs for the gestures
that we'll need to support.
There are two separate assistants for selections, one to be used
in editable text (UIWKTextInteractionAssistant) and one for non editable
text (UIWKSelectionAssistant) and they are mutually exclusive.
UIWKSelectionAssistant is created at the time the view is created,
and swapped with UIWKTextInteraction assistant
only when an editable element is focused and the keyboard appears on screen.
gestureRecognizerShouldBegin is the delegate call used to decide which gestures
should begin based on the position the gesture occurred at.
We want to avoid as much as possible synchronous calls to the WebProcess to
retrieve information about the content and in order to do so, we take advantage
of the order in which the gesture recognizers will trigger, based on the delay
configured at initialization.
The first gesture to trigger is highlightLongPress, followed by longpress in the
active assistant and longpress in the WKInteractionView.
There are two different scenarios for highlighlongpress based on which assistant is
currently active.
UIWKSelectionAssistant is active:
We send a request to the WebProcess to get information on the position
and we return YES, allowing the gesture to start.
We delegate to the WebProcess the proper handling of highlight based on the element.
When longPress gesture fires for the assistant, we assume we have received the reply to our
previous request, if not we fetch the information synchronously.
We are then able to make an informed decision about whether
or not to start the gesture. If the reply is NO, the third and last long press
gesture can be evaluated to decide whether to show the action sheet or simply generate
a click event.
UIWKTextInteractionAssistant is active:
In this case we must have information about the position immediately and we issue
a synchronous request to the WebProcess.
If we are not interacting with the same node, we return NO.
Then the longpress gesture fires for the assistant which performs the same check.
If the node is the same, the loupe gesture will start, otherwise the last longpress
gesture will be evaluated to decide about showing the action sheet or generating a
click event.
- Scripts/webkit2/messages.py:
- Shared/InteractionInformationAtPosition.cpp: Added.
(WebKit::InteractionInformationAtPosition::encode):
(WebKit::InteractionInformationAtPosition::decode):
- Shared/InteractionInformationAtPosition.h: Added.
(WebKit::InteractionInformationAtPosition::InteractionInformationAtPosition):
- UIProcess/API/ios/PageClientImplIOS.h:
- UIProcess/API/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::positionInformationDidChange):
- UIProcess/API/ios/WKContentView.mm:
(-[WKContentView _positionInformationDidChange:]):
- UIProcess/API/ios/WKContentViewInternal.h:
- UIProcess/API/ios/WKInteractionView.h:
- UIProcess/API/ios/WKInteractionView.mm:
(-[WKInteractionView initWithFrame:]):
(-[WKInteractionView dealloc]):
(-[WKInteractionView gestureRecognizer:canPreventGestureRecognizer:]):
(-[WKInteractionView gestureRecognizer:canBePreventedByGestureRecognizer:]):
(isSamePair):
(-[WKInteractionView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKInteractionView _showImageSheet]):
(-[WKInteractionView _showLinkSheet]):
(-[WKInteractionView _actionForLongPress]):
(-[WKInteractionView ensurePositionInformationIsUpToDate:]):
(-[WKInteractionView gestureRecognizerShouldBegin:]):
(-[WKInteractionView hasSelectablePositionAtPoint:]):
(-[WKInteractionView pointIsInAssistedNode:]):
(-[WKInteractionView _longPressRecognized:]):
(-[WKInteractionView _doubleTapRecognized:]):
(-[WKInteractionView _twoFingerDoubleTapRecognized:]):
(-[WKInteractionView _twoFingerPanRecognized:]):
(-[WKInteractionView useSelectionAssistantWithMode:]):
(-[WKInteractionView _positionInformationDidChange:]):
(-[WKInteractionView interactionAssistant]):
(-[WKInteractionView _startAssistingKeyboard]):
(-[WKInteractionView _stopAssistingKeyboard]):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didReceivePositionInformation):
(WebKit::WebPageProxy::getPositionInformation):
(WebKit::WebPageProxy::requestPositionInformation):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::getPositionInformation):
(WebKit::WebPage::requestPositionInformation):
- 4:27 PM Changeset in webkit [162102] by
-
- 10 edits3 deletes in tags/Safari-538.12
Rollout r161455. <rdar://problem/15828719>
- 4:14 PM Changeset in webkit [162101] by
-
- 2 edits in tags/Safari-538.12/Source/WebCore
Rollout r161778. <rdar://problem/15828719>
- 4:08 PM Changeset in webkit [162100] by
-
- 2 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=127066
Add WKBrowsingContextHandle.h to WebKit2 private headers.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-15
Reviewed by Dan Bernstein.
Add WKBrowsingContextHandle.h to WebKit2 private headers so that WebKit2 client
can use WKBrowsingContextHandle class.
- WebKit2.xcodeproj/project.pbxproj:
- 4:07 PM Changeset in webkit [162099] by
-
- 6 edits in trunk
Remove unnecessary call to webGLContextCreated
https://bugs.webkit.org/show_bug.cgi?id=127000
Reviewed by Brent Fulgham.
Source/WebCore:
Note that the functionality of webGLContextCreated will be handled by webGLPolicyForSite now.
Tests: Unskipping tests skipped in r162002.
- html/HTMLCanvasElement.cpp: Remove webGLContextCreated call.
(WebCore::HTMLCanvasElement::getContext):
- loader/FrameLoaderClient.h:
Have the returned load policy default to WebGLAllow so as to not break clients that don't implement the method.
(WebCore::FrameLoaderClient::webGLPolicyForSite):
webGLPolicyForSite is now assuming the role of webGLContextCreated as well, pass in the whole site URL instead of just the host.
- page/ChromeClient.h: Remove webGLContextCreated method.
(WebCore::ChromeClient::decrementActivePageCount):
LayoutTests:
- platform/mac/TestExpectations: Unskipping tests skipped in r162002.
- 3:51 PM Changeset in webkit [162098] by
-
- 14 edits in trunk/Source/WebCore
Repeating background images should continue into margin tiles
https://bugs.webkit.org/show_bug.cgi?id=127021
-and corresponding-
<rdar://problem/15571300>
Reviewed by Simon Fraser.
This patch makes repeating background images continue into margin tiles.
RenderObject::repaintRectangle() now takes an addition bool parameter which
indicates whether or not the repaint rect should be clipped to the layer size.
- WebCore.exp.in:
These new functions on FrameView provide a way for code in the render tree to know
if the TiledBacking has a margin. tiledBacking() is now const. It should have
always been const, and it needs to be const to make these new functions const.
- page/FrameView.cpp:
(WebCore::FrameView::tiledBacking):
(WebCore::FrameView::hasExtendedBackground):
(WebCore::FrameView::extendedBackgroundRect):
- page/FrameView.h:
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::tiledBacking):
If we’re painting the root background and it is an extended background, we need to
inflate the repaint rect to span the extended background.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::repaintLayerRectsForImage):
To get the phase right on repeated background images on a page with margin tiles,
we need to make sure we factor the size of the margin tiles into the left and top
values that we use when calculating background image geometry.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
setBackingNeedsRepaintInRect() now takes GraphicsLayer::ShouldClipToLayer as a
parameter, just like setBackingNeedsRepaint().
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
setContentsNeedDisplayInRect() also takes a GraphicsLayer::ShouldClipToLayer now,
and it passes that information down to the GraphicsLayer.
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
- rendering/RenderLayerBacking.h:
These two RenderObject functions now take an optional bool parameter which
indicates whether or not the rect should be clipped to the layer size. They use a
bool instead of the GraphicsLayer enum in order to avoid including GraphicsLayer.h
from within RenderObject.h. This seems like a simpler solution than adding a new
stand-alone file for this very simple enum.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaintRectangle):
- rendering/RenderObject.h:
RenderView::backgroundRect needs to return the extendedBackgroundRect when it had
one.
- rendering/RenderView.cpp:
(WebCore::RenderView::backgroundRect):
- 3:26 PM Changeset in webkit [162097] by
-
- 5 edits in trunk/Source/WebKit2
toStringVector static function definition should not be redundant.
https://bugs.webkit.org/show_bug.cgi?id=126872.
Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-15
Reviewed by Anders Carlsson.
toStringVector function was declared twice in InjectedBundle.cpp and WebPageGroup.cpp as static.
In order to remove redundant definition this function was moved into API::Array.
- Shared/APIArray.cpp:
(API::Array::toStringVector):
- Shared/APIArray.h:
- UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::addUserStyleSheet):
(WebKit::WebPageGroup::addUserScript):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
- 3:22 PM Changeset in webkit [162096] by
-
- 15 edits3 adds in trunk
Web Inspector: capture probe samples on the backend
https://bugs.webkit.org/show_bug.cgi?id=126668
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
Add the 'probe' breakpoint action to the protocol. Change the setBreakpoint
commands to return a list of assigned breakpoint action identifiers
Add a type for breakpoint action identifiers. Add an event for sending
captured probe samples to the inspector frontend.
- inspector/protocol/Debugger.json:
Source/WebCore:
Test: inspector-protocol/debugger/setProbe-multiple-actions.html
Add the probe breakpoint action type. A probe action
evaluates an expression on the script call frame, and
the result is aggregated on a per-probe basis. Each
evaluated expression result is called a probe sample.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::evaluateBreakpointAction): Teach
the debug server to evaluate a probe.
(WebCore::ScriptDebugServer::dispatchDidSampleProbe): Added.
(WebCore::ScriptDebugServer::handleBreakpointHit): Increment a hit count.
(WebCore::ScriptDebugServer::getActionsForBreakpoint):
- bindings/js/ScriptDebugServer.h:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::objectGroupForBreakpointAction): Added. Create an object
group for each breakpoint action. Currently only probes make objects.
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::enable): Remove stale comment.
(WebCore::breakpointActionTypeForString): Add new case.
(WebCore::InspectorDebuggerAgent::breakpointActionsFromProtocol): Make
this a member function instead of a static function, so it can increment
the breakpoint action identifier counter.
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl): Propagate the
assigned breakpoint action identifiers.
(WebCore::InspectorDebuggerAgent::setBreakpoint): Propagate the
assigned breakpoint action identifiers.
(WebCore::InspectorDebuggerAgent::removeBreakpoint): Release object
groups for any actions that were associated with the removed breakpoint.
(WebCore::InspectorDebuggerAgent::didSampleProbe): Added.
(WebCore::InspectorDebuggerAgent::clearResolvedBreakpointState): Renamed from clear().
(WebCore::InspectorDebuggerAgent::didClearGlobalObject): Renamed from reset().
- inspector/InspectorDebuggerAgent.h:
- inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::didClearMainFrameWindowObject):
- inspector/ScriptBreakpoint.h:
(WebCore::ScriptBreakpointAction::ScriptBreakpointAction): Add identifier member.
- inspector/ScriptDebugListener.h:
Source/WebInspectorUI:
- UserInterface/InspectorJSBackendCommands.js: Add probe enumeration value.
LayoutTests:
Add protocol tests for setting and hitting the probe breakpoint action type.
- inspector-protocol/debugger/setBreakpoint-actions-expected.txt:
- inspector-protocol/debugger/setBreakpoint-actions.html:
- inspector-protocol/debugger/setProbe-multiple-actions-expected.txt: Added.
- inspector-protocol/debugger/setProbe-multiple-actions.html: Added.
- inspector-protocol/resources/probe-helper.js: Added.
(ProbeHelper.simplifiedProbeSample):
- 3:01 PM Changeset in webkit [162095] by
-
- 9 edits in tags/Safari-538.12/Source
Rollout 161609. <rdar://problem/15826281>
- 2:58 PM Changeset in webkit [162094] by
-
- 2 edits in trunk/Source/WebKit/mac
More iOS build fixing.
- WebView/WebPreferences.mm: (-[WebPreferences _invalidateCachedPreferences]):
Removed a now unused local variable.
- 2:53 PM Changeset in webkit [162093] by
-
- 2 edits in trunk/Source/WebKit/mac
Build fix for iOS.
- WebView/WebPreferences.mm: (-[WebPreferences _invalidateCachedPreferences]):
Update a remaining call site of _updatePrivateBrowsingStateFram:to:.
- 2:43 PM Changeset in webkit [162092] by
-
- 2 edits in trunk/Tools
DumpRenderTree doesn't disable web preferences autosave
https://bugs.webkit.org/show_bug.cgi?id=127062
Reviewed by Dan Bernstein.
- DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
Do it.
- 2:35 PM Changeset in webkit [162091] by
-
- 2 edits in trunk/Source/WebKit/mac
Crash when multiple WebView instances have different PrivateBrowsing settings
https://bugs.webkit.org/show_bug.cgi?id=127019
- WebView/WebPreferences.mm: (-[WebPreferences _updatePrivateBrowsingStateTo:]):
Added a null check to fix Safari crash on startup when extensions are enabled.
- 2:25 PM Changeset in webkit [162090] by
-
- 2 edits in trunk/Tools
Improve filter-build-webkit, especially for iOS builds
https://bugs.webkit.org/show_bug.cgi?id=81046
Reviewed by Joseph Pecoraro.
Lots of updates to the filtering rules, mostly from the
iOS build output. Other highlights include:
- ignoring escape sequences for color ouput
- detecting escaped spaces in file name regexps
- Scripts/filter-build-webkit:
(shouldIgnoreLine):
- 2:16 PM Changeset in webkit [162089] by
-
- 12 edits1 add in branches/jsCStack/Source/JavaScriptCore
reentrant-caching sometimes fails with LLInt disabled
https://bugs.webkit.org/show_bug.cgi?id=126781
Reviewed by Michael Saboff.
The lookupExceptionHandler->genericUnwind->handleUncaughtException paths need to
be resilient against the frame from which we claim to be throwing the exception
being the sentinel frame.
Also attempted to add a test that pinpoints the problem, but it didn't cause a
crash either before or after my change. That's fine, I figured it would be good to
have more coverage for madness like this.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileExceptionHandlers):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::unwind):
- interpreter/Interpreter.h:
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArguments):
- jit/JIT.cpp:
(JSC::JIT::privateCompileExceptionHandlers):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/Repatch.cpp:
(JSC::tryBuildGetByIDList):
- jit/ThunkGenerators.cpp:
(JSC::throwExceptionFromCallSlowPathGenerator):
- llint/LowLevelInterpreter64.asm:
- tests/stress/recurse-infinitely-on-getter.js: Added.
(.var):
- 1:39 PM Changeset in webkit [162088] by
-
- 8 edits in trunk
REGRESSION (r158369): Some pop-up windows open at incorrect size (affects GMail, theblaze.com)
https://bugs.webkit.org/show_bug.cgi?id=126289
Reviewed by Anders Carlson.
Partial revert of https://bugs.webkit.org/show_bug.cgi?id=123557.
On window.open, update page when the UIProcess sends the create message
Source/WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::creationParameters):
- UIProcess/WebPageProxy.h:
- creation paraments are not preserved at window.open.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::reinitializeWebPage):
(WebKit::WebPage::setViewState):
(WebKit::WebPage::setViewStateInternal):
- WebProcess/WebPage/WebPage.h:
- add interface to update page.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage):
- if we try to create a page that already exists, update the current page's view state.
LayoutTests:
- platform/mac-wk2/TestExpectations:
- test is bad (results in DRT don't reflect in browser behaviour).
- 1:30 PM Changeset in webkit [162087] by
-
- 3 edits in trunk/Source/WebKit/mac
Crash when multiple WebView instances have different PrivateBrowsing settings
https://bugs.webkit.org/show_bug.cgi?id=127019
Reviewed by Sam Weinig.
- WebView/WebView.mm: (-[WebView _preferencesChanged:]): Don't delete a private
browsing session simply because one preferences object doesn't use private browsing.
There could be others that do.
- WebView/WebPreferences.mm: Track how many WebPreferences objects use private
browsing, and only delete the private session when there are none any more.
- 1:21 PM Changeset in webkit [162086] by
-
- 2 edits in trunk/Source/WTF
[GTK] v2.3.3 fails to build in Debian / FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=126502
Reviewed by Mark Lam.
- wtf/Platform.h: Add LLINT support to FreeBSD.
- 12:13 PM Changeset in webkit [162085] by
-
- 2 edits in trunk/Source/WebCore
[WebGL] Validation function for compressed formats incorrect
https://bugs.webkit.org/show_bug.cgi?id=127023
Reviewed by Dean Jackson.
No new tests. Covered by existing WebGL compressed texture tests.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData): Revise to match specifications.
- 12:09 PM Changeset in webkit [162084] by
-
- 17 edits3 deletes in trunk/Source
Remove the CSS selector profiler.
<https://webkit.org/b/127039>
Source/WebCore:
The selector profiler was painting a mostly fictional picture of what
selectors we were spending time on. It never really grokked the fast
path selectors, nor did it understand recent additions like the extra
cascading pass or the selector JIT.
Somewhat ironically, this may end up making some selectors run faster
since it removes a number of brances in hot code.
Reviewed by Sam Weinig.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
- css/ElementRuleCollector.h:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorInstrumentation.h:
- inspector/protocol/CSS.json:
Source/WebInspectorUI:
Purge selector profiler code from the new Web Inspector UI.
Reviewed by Sam Weinig.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/CSSSelectorProfileObject.js: Removed.
- UserInterface/CSSSelectorProfileType.js: Removed.
- UserInterface/CSSSelectorProfileView.js: Removed.
- UserInterface/ContentView.js:
(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):
- UserInterface/InspectorWebBackendCommands.js:
- UserInterface/InstrumentSidebarPanel.js:
(WebInspector.InstrumentSidebarPanel):
(WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedOver):
(WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedDown):
(WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphClicked):
(WebInspector.InstrumentSidebarPanel.prototype._profileTypeWasSelected):
(WebInspector.InstrumentSidebarPanel.prototype._profilesCleared):
- UserInterface/Main.html:
- UserInterface/ProfileManager.js:
(WebInspector.ProfileManager):
(WebInspector.ProfileManager.prototype.initialize):
(WebInspector.ProfileManager.prototype._checkForInterruptions):
(WebInspector.ProfileManager.prototype._attemptToResumeProfiling):
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
- 11:01 AM Changeset in webkit [162083] by
-
- 4 edits7 adds in trunk
[SVG] Accept HTML and MathML namespaces as valid requiredExtensions
https://bugs.webkit.org/show_bug.cgi?id=88188
Patch by Frédéric Wang <fred.wang@free.fr> on 2014-01-15
Reviewed by Chris Fleizach.
Source/WebCore:
When HTML and MathML are used as foreign objects of an SVG image, it is
important for Web authors to be able to specify a fallback content for
SVG-only readers or browsers without MathML support. We rely on the
requiredExtensions for that purpose and we use the XHTML/MathML
namespaces as suggested in SVG Tiny 1.2 and implemented in Gecko.
Tests: svg/custom/conditional-processing-1.svg
svg/custom/conditional-processing-2.html
svg/dom/SVGTests.html
- svg/SVGSwitchElement.cpp: Remove an incorrect FIXME comment and replace it with a reference to bug 74749.
(WebCore::SVGSwitchElement::childShouldCreateRenderer):
- svg/SVGTests.cpp: Check if the list of required extensions contains only the XHTML/MathML namespaces.
(WebCore::SVGTests::hasExtension):
(WebCore::SVGTests::isValid):
LayoutTests:
conditional-processing-1 verifies that indeed a renderer object is only
created for the first "valid" SVG element of a <switch>, contrary to
what an incorrect FIXME comment said. conditional-processing-2 verifies
that the <switch> takes into account XHTML and MathML namespaces in the
requiredExtensions attribute to decide which SVG element is "valid".
SVGTests.html verifies the SVGTests interface of SVG DOM: three
SVGStringList attributes (already tested in svg/dom/SVGStringList.html)
and the hasExtension() function.
- svg/custom/conditional-processing-1-expected.svg: Added.
- svg/custom/conditional-processing-1.svg: Added.
- svg/custom/conditional-processing-2-expected.html: Added.
- svg/custom/conditional-processing-2.html: Added.
- svg/dom/SVGTests-expected.txt: Added.
- svg/dom/SVGTests.html: Added.
- svg/dom/script-tests/SVGTests.js: Added.
- 11:00 AM Changeset in webkit [162082] by
-
- 2 edits1 copy1 delete in trunk/LayoutTests
AX: Merge layout test from Mac and GTK checking accessibility roles
https://bugs.webkit.org/show_bug.cgi?id=126685
Fix Mac test results.
- platform/mac-mountainlion/platform/mac/accessibility/role-subrole-roledescription-expected.txt: Removed.
This test was merged into another, but its Mountain Lion results were not moved accordingly.
- platform/mac-mountainlion/accessibility/roles-exposed-expected.txt: Copied from LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt.
Custom results with a different role for "dl".
- platform/mac/accessibility/roles-exposed-expected.txt: Changed to have results that
are correct forward looking.
- 10:37 AM Changeset in webkit [162081] by
-
- 2 edits in trunk/Source/WebKit/mac
[iOS] Missing RenderObject::style() symbol in WebDOMOperations.mm
Fixes the following linker error:
Undefined symbols for architecture x86_64:
"ZNK7WebCore12RenderObject5styleEv", referenced from:
-[DOMNode(WebDOMNodeOperations) isHorizontalWritingMode] in WebDOMOperations.o
- DOM/WebDOMOperations.mm: Include RenderElement.h instead of
RenderObject.h since the inline RenderObject::style() method
moved to the former header.
- 10:29 AM Changeset in webkit [162080] by
-
- 6 edits2 deletes in trunk
Unreviewed, rolling out r162066.
http://trac.webkit.org/changeset/162066
https://bugs.webkit.org/show_bug.cgi?id=127056
The added test still fails on some bots (Requested by ap on
#webkit).
Source/WebCore:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern):
LayoutTests:
- css3/compositing/background-blend-mode-data-uri-svg-image-expected.html: Removed.
- css3/compositing/background-blend-mode-data-uri-svg-image.html: Removed.
- platform/efl/TestExpectations:
- 10:23 AM Changeset in webkit [162079] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix intialization order of ResourceResponse constructor
Fixes the following build failure:
WebCore/platform/network/mac/ResourceResponseMac.mm:83:7: error: field 'm_nsResponse' will be initialized after field 'm_initLevel' [-Werror,-Wreorder]
, m_nsResponse(nsResponse)
- platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::ResourceResponse): Reorder member
initializers to match the order that they are defined in the
header.
- 10:11 AM Changeset in webkit [162078] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Comment out part of r162036 which broke WebGL on many ports.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
- 10:03 AM Changeset in webkit [162077] by
-
- 2 edits1 delete in trunk/LayoutTests
Unreviewed test correctino for webgl compressed textures.
- fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt:
- platform/mac-mountainlion/fast/canvas: Removed.
- platform/mac-mountainlion/fast/canvas/webgl: Removed.
- platform/mac-mountainlion/fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Removed.
- 9:53 AM Changeset in webkit [162076] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add failure test expectations for reftests added in r161626.
- platform/efl/TestExpectations:
- 9:46 AM Changeset in webkit [162075] by
-
- 3 edits in trunk/Source/WebKit/mac
Unreviewed, rolling out r162054.
http://trac.webkit.org/changeset/162054
https://bugs.webkit.org/show_bug.cgi?id=127053
Causes assertion failures in DumpRenderTree (Requested by ap
on #webkit).
- WebView/WebPreferences.mm:
(-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
(-[WebPreferences initWithCoder:]):
(+[WebPreferences standardPreferences]):
(-[WebPreferences dealloc]):
(-[WebPreferences setPrivateBrowsingEnabled:]):
(-[WebPreferences _invalidateCachedPreferences]):
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
- 9:45 AM Changeset in webkit [162074] by
-
- 3 edits in trunk/Source/WTF
Get rid of RefCountedCustomAllocated
https://bugs.webkit.org/show_bug.cgi?id=127051
Reviewed by Antti Koivisto.
It's not used anywhere anymore, get rid of it.
- wtf/RefCounted.h:
- wtf/SizeLimits.cpp:
- 9:37 AM Changeset in webkit [162073] by
-
- 7 edits2 adds in trunk
[GTK] Web process sometimes crashes when printing in synchronous mode
https://bugs.webkit.org/show_bug.cgi?id=126979
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
When printing synchronously in GTK+ we need to make sure that we
have a list of Printers before starting the print operation. Getting
the list of printers is done synchronously by GTK+, but using a
nested main loop that might process IPC messages comming from the
UI process like EndPrinting. When the EndPrinting message is
received while the printer list is being populated, the print
operation is finished unexpectely and the web process crashes. The
PrinterListGtk class gets the list of printers in the constructor
so we just need to ensure there's an instance alive during the
synchronous print operation. In case of asynchronous printing the
printer list will be created during the print operation without
any risk, because the EndPrinting message is not sent until the
printing callback has been received in the UI process.
- GNUmakefile.list.am: Add new files to compilation.
- PlatformGTK.cmake: Ditto.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::print): Ensure PrinterListGtk is created
before the synchronous printing and destroyed afterwards.
- WebProcess/WebPage/gtk/PrinterListGtk.cpp: Added.
(WebKit::PrinterListGtk::shared): Return the singleton.
(WebKit::PrinterListGtk::enumeratePrintersFunction): Callback
called by gtk_enumerate_printers() when a new printer is found.
(WebKit::PrinterListGtk::PrinterListGtk): Call
gtk_enumerate_printers() in syhchronous mode.
(WebKit::PrinterListGtk::~PrinterListGtk):
(WebKit::PrinterListGtk::addPrinter): Add the printer to the list
and set the default printer if needed.
(WebKit::PrinterListGtk::findPrinter): Find the printer for the
given name.
- WebProcess/WebPage/gtk/PrinterListGtk.h: Added.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: Use
PrinterListGtk class to find the printer instead of calling
gtk_enumerate_printers().
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Unskip
/webkit2/WebKitPrintOperation/close-after-print.
- 9:22 AM Changeset in webkit [162072] by
-
- 2 edits in trunk/LayoutTests
Merged some subpixel skipped tests. Unreviewed.
webkit.org/b/126894 is a duplicate of webkit.org/b/126892
- platform/mac/TestExpectations:
- 9:19 AM Changeset in webkit [162071] by
-
- 3 edits in trunk/Source/WebCore
WordMeasurement is a struct, not a class
https://bugs.webkit.org/show_bug.cgi?id=125373
Reviewed by Anders Carlsson.
Change class to struct, because there is no reason for WordMeasurement to be a class.
No new tests, no behavior change.
- rendering/RenderBlockFlow.h:
- rendering/line/BreakingContextInlineHeaders.h:
- 9:10 AM Changeset in webkit [162070] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed test fix for Mountain Lion WebGL behavior.
Add Mountain Lion expected output matching ML's output of INVALID_OPERATION for improperly-sized textures.
- platform/mac-mountainlion/fast/canvas: Added.
- platform/mac-mountainlion/fast/canvas/webgl: Added.
- platform/mac-mountainlion/fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Added.
- 9:03 AM Changeset in webkit [162069] by
-
- 5 edits2 adds in trunk/Source/WebKit/gtk
[GTK][WK1] Add ProgressTrackerClient implementation
https://bugs.webkit.org/show_bug.cgi?id=127048
Reviewed by Anders Carlsson.
In r162034, the progress tracker client was separated from FrameLoaderClient into the
ProgressTrackerClient class. This patch adds the WebKit layer implementation of that
class for GTK-WK1 that's practically identical to the client implementation that was
in use under WebKit::FrameLoaderClient.
- GNUmakefile.am:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- WebCoreSupport/FrameLoaderClientGtk.h:
- WebCoreSupport/ProgressTrackerClientGtk.cpp: Added.
(WebKit::ProgressTrackerClient::ProgressTrackerClient):
(WebKit::ProgressTrackerClient::progressTrackerDestroyed):
(WebKit::ProgressTrackerClient::progressStarted):
(WebKit::ProgressTrackerClient::progressEstimateChanged):
(WebKit::ProgressTrackerClient::progressFinished):
- WebCoreSupport/ProgressTrackerClientGtk.h: Added.
- webkit/webkitwebview.cpp:
(webkit_web_view_init):
- 9:01 AM Changeset in webkit [162068] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed GTK gardening. Removing an unneeded GTK-specific baseline
for a layout test that was fixed proper in r161549.
- platform/gtk/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt: Removed.
- 5:15 AM Changeset in webkit [162067] by
-
- 1 edit2 moves1 add2 deletes in trunk/LayoutTests
AX: Merge layout test from Mac and GTK checking accessibility roles
https://bugs.webkit.org/show_bug.cgi?id=126685
Reviewed by Chris Fleizach.
Merged GTK and Mac tests into one cross-platform test that is
aware of the platform-specific differences by declaring which
elements are supported in which platforms and which platform
specific roles (if it's the case) should be expected.
- accessibility/roles-exposed-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt.
- accessibility/roles-exposed.html: Added.
- platform/gtk/accessibility/roles-exposed.html: Removed.
- platform/mac/accessibility/role-subrole-roledescription.html: Removed.
- platform/mac/accessibility/roles-exposed-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/role-subrole-roledescription-expected.txt.
- 4:32 AM Changeset in webkit [162066] by
-
- 6 edits2 adds in trunk
Source/WebCore: Reapplying:
Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
The problem consisted in the drawing path using the default
blending parameter at all times.
https://bugs.webkit.org/show_bug.cgi?id=118894
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-15
Reviewed by Dirk Schulze.
Test: css3/compositing/background-blend-mode-data-uri-svg-image.html
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer): Pass blendMode to Image::drawPattern.
- svg/graphics/SVGImage.h: Add a blendMode parameter to drawPatternForContainer.
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern): Pass blendMode to drawPatternForContainer call.
LayoutTests: Reapplying:
Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
Tests now use rectangles instead of circles for SVGs.
https://bugs.webkit.org/show_bug.cgi?id=118894
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-15
Reviewed by Dirk Schulze.
- css3/compositing/background-blend-mode-data-uri-svg-image-expected.html:
- css3/compositing/background-blend-mode-data-uri-svg-image.html:
- platform/efl/TestExpectations: pass tests for efl, blendMode is not implemented.
- 3:26 AM Changeset in webkit [162065] by
-
- 4 edits2 adds in trunk/PerformanceTests
[CSS Regions] Add performance tests for selection with mixed content
https://bugs.webkit.org/show_bug.cgi?id=126427
Reviewed by Ryosuke Niwa.
Add new performance tests for selection in CSS Regions mixing regular
content with regions. 2 new tests are added, one checking select all
command and another simulating a user selection passing through all the
paragraphs (similar to Layout/RegionsSelection.html).
Test are skipped for now while implementation of selection in CSS
Regions is still evolving.
- Layout/RegionsExtendingSelectionMixedContent.html: Added.
- Layout/RegionsSelectAllMixedContent.html: Added.
- Layout/resources/regions.css:
(.regular):
- Layout/resources/regions.js:
- Skipped:
- 2:30 AM Changeset in webkit [162064] by
-
- 3 edits2 adds in trunk
[CSS Regions] Hit-testing goes through clipped layer in fast/regions/overflow-first-and-last-regions-in-container-hidden.html
https://bugs.webkit.org/show_bug.cgi?id=126886
Reviewed by Mihnea Ovidenie.
Source/WebCore:
Currently, when hit testing a location inside a flow thread we ignore the clipping rectangle of
the region. This leads to false positives when the location is over the clipped out content of a
flow thread. The patch verifies that the location is inside the clipping rectangle of the region before
forwarding the hit test verification to the flow thread layer.
Test: fast/regions/hover-and-js-in-visual-overflow-hidden.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestFlowThreadIfRegion):
LayoutTests:
Add a test that verifies you can't hover an element flowed inside a region but found inside
the hidden overflow of the region.
- fast/regions/hover-and-js-in-visual-overflow-hidden-expected.html: Added.
- fast/regions/hover-and-js-in-visual-overflow-hidden.html: Added.
- 2:28 AM Changeset in webkit [162063] by
-
- 3 edits in trunk/Source/WebCore
Suspend resource requests during computedStyle
https://bugs.webkit.org/show_bug.cgi?id=127034
Reviewed by Andreas Kling.
We have some cases where getting computed style leads to crashes in loadPendingImages.
This is probably caused by load callbacks resulting in re-entering WebKit and killing the StyleResolver.
As a speculative fix suspend resource loads (and so callbacks) when getting the computed style.
We do similar suspension during style recalc for the same reason.
- dom/Document.cpp:
(WebCore::Document::styleForElementIgnoringPendingStylesheets):
- loader/ResourceLoadScheduler.h:
(WebCore::ResourceLoadScheduler::Suspender::Suspender):
(WebCore::ResourceLoadScheduler::Suspender::~Suspender):
- 2:14 AM Changeset in webkit [162062] by
-
- 7 edits3 adds in trunk
DocumentFragment should be constructable.
https://bugs.webkit.org/show_bug.cgi?id=115641
Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-15
Reviewed by Ryosuke Niwa.
Source/WebCore:
http://www.w3.org/TR/2013/WD-dom-20131107/#interface-documentfragment
This allows us to donew DocumentFragmentinstead of
document.createDocumentFragment().
Backported from Blink: https://chromium.googlesource.com/chromium/blink/+/86855c44a5a127716840fb377281b1c428e5eb2d%5E%21
Test: fast/dom/DocumentFragment/document-fragment-constructor.html
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::create):
- dom/DocumentFragment.h:
- dom/DocumentFragment.idl:
LayoutTests:
- fast/dom/DocumentFragment/document-fragment-constructor-expected.txt: Added.
- fast/dom/DocumentFragment/document-fragment-constructor.html: Added.
- fast/dom/dom-constructors-expected.txt:
- fast/dom/dom-constructors.html:
- 2:01 AM Changeset in webkit [162061] by
-
- 6 edits2 adds in trunk/Source/WebKit
[EFL][WK1] Implement ProgressTrackerClientEfl to fix the crash
https://bugs.webkit.org/show_bug.cgi?id=127031
Reviewed by Gyuyoung Kim.
Source/WebKit:
- PlatformEfl.cmake: Added ProgressTrackerClientEfl.cpp into source lists.
Source/WebKit/efl:
Implmemented and moved ProgressTrackerClient logic from FrameLoaderClientEfl.
ProgressTrackerClient should be indenpendent instance since r162034
- WebCoreSupport/FrameLoaderClientEfl.cpp:
- WebCoreSupport/FrameLoaderClientEfl.h:
- WebCoreSupport/ProgressTrackerClientEfl.cpp:
(WebCore::ProgressTrackerClientEfl::ProgressTrackerClientEfl):
(WebCore::ProgressTrackerClientEfl::progressTrackerDestroyed):
(WebCore::ProgressTrackerClientEfl::progressStarted):
(WebCore::ProgressTrackerClientEfl::progressEstimateChanged):
(WebCore::ProgressTrackerClientEfl::progressFinished):
- WebCoreSupport/ProgressTrackerClientEfl.h: Added.
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
- 1:58 AM WebKitGTK/2.2.x edited by
- (diff)
- 1:55 AM Changeset in webkit [162060] by
-
- 4 edits in trunk/Tools
[EFL] Change test font installed path to webkitgtk-font-tests
https://bugs.webkit.org/show_bug.cgi?id=126723
Reviewed by Gyuyoung Kim.
I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
hard-coded in FontManagement.cpp#105
- DumpRenderTree/PlatformEfl.cmake:
- WebKitTestRunner/PlatformEfl.cmake:
- efl/jhbuild.modules:
- 1:45 AM Changeset in webkit [162059] by
-
- 2 edits in trunk/Source/WebKit2
[SOUP] [WK2] - Disable MemoryCache when the DOCUMENT_VIEWER cache model is set
https://bugs.webkit.org/show_bug.cgi?id=126577
Patch by Tomas Popela <tpopela@redhat.com> on 2014-01-15
Reviewed by Carlos Garcia Campos.
As in http://trac.webkit.org/changeset/152483, but this time for
WebKit2. When WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER is set we need to
disable the MemoryCache completely to prevent caching of the resources.
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformSetCacheModel):
- 12:01 AM Changeset in webkit [162058] by
-
- 9 edits2 adds in trunk
Make DoYouEvenBench runnable by run-perf-tests
https://bugs.webkit.org/show_bug.cgi?id=127030
Reviewed by Andreas Kling.
PerformanceTests:
Added Full.html that runs 5 iterations of DoYouEvenBench. This is the canonical DoYouEvenBench,
which is also runnable by run-perf-tests.
- DoYouEvenBench/Full.html: Added.
- DoYouEvenBench/benchmark.html:
(startTest): Updated the code to account for the fact old measuredValues is pushed down to tests
property and we now have total property so that we don't have to manually compute the total.
- DoYouEvenBench/resources/benchmark-report.js: Added. When we're inside a DRT/WTR, use
PerfTestRunner to output that can be parsed by run-perf-tests. Do the same when the query part
or the fragment part of the current URL is "webkit" for debugging purposes.
- DoYouEvenBench/resources/benchmark-runner.js:
(BenchmarkRunner):
(BenchmarkRunner.prototype._appendFrame): Position the frame at (0, 0) inside DRT and WTR since
we have exactly 800px by 600px inside those two test runners. Also always insert the iframe as
the first child of body to avoid inserting it after the pre inserted by the test runner.
(BenchmarkRunner.prototype.step): Initializes _measuredValues.
(BenchmarkRunner.prototype.runAllSteps): Merged callNextStep in benchmark.html.
(BenchmarkRunner.prototype.runMultipleIterations): Added.
(BenchmarkRunner.prototype._runTestAndRecordResults): Compute the grand total among suites.
Also push down the sync and async time into tests property for consistency.
(BenchmarkRunner.prototype._finalize):
- Dromaeo/resources/dromaeorunner.js:
(DRT.testObject): Renamed dromaeoIterationCount to customIterationCount as this option is also
used by DoYouEvenBench.
- resources/runner.js: Ditto.
(.finish): Spit out the aggregator name.
Tools:
Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
":Total" to appear at the end of a test name. We don't do anything with it for now.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
to the JSON in a follow up patch for the perf dashboard.
(PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
LayoutTests:
Use customIterationCount as it has been renamed from dromaeoIterationCount.
- fast/harness/perftests/runs-per-second-iterations.html:
Jan 14, 2014:
- 11:56 PM Changeset in webkit [162057] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] UI process crashes when closing the window right after printing with javascript
https://bugs.webkit.org/show_bug.cgi?id=126981
Reviewed by Gustavo Noronha Silva.
The UI process crashes because when the page is closed, the web
view is destroyed before the print operation has actually
finished. Use a weak pointer to make sure the web view pointer is
set to NULL when the it's destroyed and emit the finished callback
always so that the user can clean up the operation even when the
web view has been closed.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(drawPagesForPrintingCompleted):
- 11:47 PM Changeset in webkit [162056] by
-
- 6 edits in trunk
[GTK] UI process crashes when the web process crashes while printing
https://bugs.webkit.org/show_bug.cgi?id=126977
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
When the web process crashes, the printing callback is
invalidated, so the function is called with a NULL error.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(drawPagesForPrintingCompleted): Check wkError is not NULL before
trying to use it.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewPrintFrame): Set the print mode of the operation
before emitting the print signal.
Tools:
Add new test case to check that closing the window right after
printing works. It's skipped for now, because this patch only
fixes the UI process crash, but not the web process one.
- Scripts/run-gtk-tests:
(TestRunner): Skip
/webkit2/WebKitPrintOperation/close-after-print.
- TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
(testPrintOperationPrintPrinter):
(findPrintToFilePrinter):
(testPrintOperationPrint):
(testPrintOperationErrors):
(testPrintOperationCloseAfterPrint):
(beforeAll):
- 11:41 PM Changeset in webkit [162055] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r161980.
CachedResourcesLoader.h should not belong to the CSS_SHADERS flag since it is used
out of the flag so it causes a compile failure when svg and css shaders are concurrently disabled.
- css/StyleResolver.cpp:
- 11:18 PM Changeset in webkit [162054] by
-
- 3 edits in trunk/Source/WebKit/mac
Crash when multiple WebView instances have different PrivateBrowsing settings
https://bugs.webkit.org/show_bug.cgi?id=127019
Reviewed by Sam Weinig.
- WebView/WebView.mm: (-[WebView _preferencesChanged:]): Don't delete a private
browsing session simply because one preferences object doesn't use private browsing.
There could be others that do.
- WebView/WebPreferences.mm: Track how many WebPreferences objects use private
browsing, and only delete the private session when there are none any more.
- 11:00 PM Changeset in webkit [162053] by
-
- 3 edits in trunk/Source/WebKit/mac
Fix the iOS build after r162034.
- WebCoreSupport/WebProgressTrackerClient.mm:
- WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
- 10:51 PM Changeset in webkit [162052] by
-
- 4 edits in trunk/Source/WebCore
Pack ResourceResponse harder.
<https://webkit.org/b/127005>
Re-arrange the members of ResourceResponse to reduce padding,
shrinking it by 8 bytes.
This nudges CachedResource and CachedImage into smaller size
classes, yielding a ~700 kB progression on Membuster3.
Reviewed by Anders Carlsson.
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::ResourceResponseBase):
- platform/network/ResourceResponseBase.h:
- platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
- 10:50 PM Changeset in webkit [162051] by
-
- 23 edits2 deletes in trunk
Remove unnecessary WebkitCSSSVGDocumentValue
https://bugs.webkit.org/show_bug.cgi?id=126997
Reviewed by Andreas Kling.
Source/WebCore:
Removing redundant code path. WebkitCSSSVGDocumentValue
can be expressed by a CSSPrimitiveValue.
No new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.order:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFilter):
- css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createFilterOperations):
- css/StyleResolver.h:
- css/WebKitCSSSVGDocumentValue.cpp: Removed.
- css/WebKitCSSSVGDocumentValue.h: Removed.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForFilter):
- css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::customCSSText):
LayoutTests:
Update results after use of CSSPrimitiveValue.
- css3/filters/filter-property-computed-style-expected.txt:
- css3/filters/filter-property-expected.txt:
- css3/filters/filter-property-parsing-expected.txt:
- css3/filters/script-tests/filter-property-computed-style.js:
- css3/filters/script-tests/filter-property-parsing.js:
- css3/filters/script-tests/filter-property.js:
- fast/filter-image/parse-filter-image-expected.txt:
- fast/filter-image/parse-filter-image.html:
- 10:43 PM Changeset in webkit [162050] by
-
- 5 edits4 adds in trunk
[CSSRegions] Incorrect repaint of fixed element with transformed parent
https://bugs.webkit.org/show_bug.cgi?id=125756
Reviewed by Simon Fraser.
Source/WebCore:
When collecting the layers for fixed positioned elements with named flow
as a containing block, use layers collection at named flow layer level
instead of relying on the positioned elements collection.
With this approach, there are situations with nested named flows laid out in
auto-height regions and thus assuming 2 step layouts, in which is enough to lay
out the inner named flow once instead of twice with a performance gain.
In such situations, the layers lists for the inner named flow are not yet updated
when collectFixedPositionedLayers is called to paint the fixed positioned layers.
Therefore I called updateLayerListsIfNeeded for all named flows layers, via the flow thread controller, before inspecting the named flow layers to avoid hitting the assertions when
accessing the named flows layers lists.
Tests: fast/regions/repaint/fixed-in-named-flow-cb-changed.html
fast/regions/repaint/fixed-in-named-flow-cb-changed2.html
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::updateNamedFlowsLayerListsIfNeeded):
(WebCore::FlowThreadController::collectFixedPositionedLayers):
- rendering/FlowThreadController.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintFixedLayersInNamedFlows):
LayoutTests:
Add tests for a fixed positioned element with a parent that:
- dynamically gets a transform, in which case the fixed positioned element should be positioned
relative to its parent
- dynamically loses its transform, in which case the fixed positioned element should be positioned
relative to the view.
- fast/regions/repaint/fixed-in-named-flow-cb-changed-expected.html: Added.
- fast/regions/repaint/fixed-in-named-flow-cb-changed.html: Added.
- fast/regions/repaint/fixed-in-named-flow-cb-changed2-expected.html: Added.
- fast/regions/repaint/fixed-in-named-flow-cb-changed2.html: Added.
- 10:36 PM Changeset in webkit [162049] by
-
- 4 edits in trunk
Unreviewed test fix.
Source/WebCore:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateCompressedTexDimensions): Emit
error state expected by Khronos test suite.
LayoutTests:
- fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Use same
failure mode as the khronos test suite.
- 10:34 PM Changeset in webkit [162048] by
-
- 2 edits in trunk/Source/WebKit/mac
Stop cmp from spewing useless info during postprocess-headers.sh.
- postprocess-headers.sh: Pass -s to silence cmp since we only care about the
exit status.
- 10:31 PM Changeset in webkit [162047] by
-
- 20 edits4 copies in trunk/Source
IDB: create object store support
<rdar://problem/15779639> and https://bugs.webkit.org/show_bug.cgi?id=127011
Reviewed by Anders Carlsson.
Source/WebCore:
Split the 3 objects declared in IDBDatabaseMetadata into their own header files:
- Modules/indexeddb/IDBDatabaseMetadata.h:
- Modules/indexeddb/IDBIndexMetadata.h:
(WebCore::IDBIndexMetadata::IDBIndexMetadata):
- Modules/indexeddb/IDBObjectStoreMetadata.h:
(WebCore::IDBObjectStoreMetadata::IDBObjectStoreMetadata):
Add cross thread copying for IDBDatabaseMetadata:
- platform/CrossThreadCopier.cpp:
(WebCore::IDBIndexMetadata>::copy):
(WebCore::IDBObjectStoreMetadata>::copy):
- platform/CrossThreadCopier.h:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit2:
Add messaging/callback infrastructure for creating object stores:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::createObjectStore):
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::createObjectStore):
(WebKit::WebIDBServerConnection::didCreateObjectStore):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::didChangeDatabaseVersion):
(WebKit::UniqueIDBDatabase::didCreateObjectStore):
(WebKit::UniqueIDBDatabase::didCompleteBoolRequest):
(WebKit::UniqueIDBDatabase::createObjectStore):
(WebKit::UniqueIDBDatabase::createObjectStoreInBackingStore):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
- DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
Add serialization helpers to save/restore an IDBKeyPath to/from disk:
- DatabaseProcess/IndexedDB/IDBSerialization.cpp:
(WebKit::serializeIDBKeyPath):
(WebKit::deserializeIDBKeyPath):
- DatabaseProcess/IndexedDB/IDBSerialization.h:
Add object store metadata to the schema, and save/restore the metadata:
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createAndPopulateInitialMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::extractExistingMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createObjectStore):
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
- Scripts/webkit2/messages.py:
(struct_or_class):
- WebKit2.xcodeproj/project.pbxproj:
- 10:21 PM Changeset in webkit [162046] by
-
- 6 edits5 adds in branches/jsCStack/Source/JavaScriptCore
FTL slow path calls in inline caches should be down with exceptions
https://bugs.webkit.org/show_bug.cgi?id=127020
Not yet reviewed.
This just adds the relatively straight-forward glue code for emitting an exception
check on FTL IC slow paths and then jumping to the exception handling path.
Note that half of the attached tests failed before this change, often in very
funny ways, since the FTL IC slow paths previously just ignored exceptions. The
other half of the tests were some combination of accidental passes (because if you
ignore the exception but someone else along some path checks it then it will be
thrown and things will seem OK) and inadequate FTL coverage (so they would have
failed if the FTL supported GetByIdFlush for example).
Also updated some copyright notices that I previously forgot about.
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- ftl/FTLJITFinalizer.cpp:
- ftl/FTLSlowPathCall.cpp:
(JSC::FTL::storeCodeOrigin):
(JSC::FTL::callOperation):
- ftl/FTLSlowPathCall.h:
- ftl/FTLState.h:
- tests/stress/get-by-id-throw-from-getter-through-optimized-code.js: Added.
(foo):
(makeWithGetter.return):
(makeWithGetter):
- tests/stress/get-by-id-throw-from-unexpected-getter-through-optimized-code-that-does-not-exit.js: Added.
(foo):
(makeWithGetter.return):
(makeWithGetter):
- tests/stress/get-by-id-throw-from-unexpected-getter-through-optimized-code.js: Added.
(foo):
(makeWithGetter.return):
(makeWithGetter):
- tests/stress/ic-throw-through-optimized-code.js: Added.
(foo):
- tests/stress/put-by-id-throw-through-optimized-code.js: Added.
(foo):
- 10:10 PM Changeset in webkit [162045] by
-
- 2 edits in trunk
Only use color in make output when it’s going to a terminal.
Reviewed by Mark Rowe.
- Makefile.shared:
- 9:43 PM Changeset in webkit [162044] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Unreviewed build fix after r162034
- GNUmakefile.list.am:
- 8:26 PM Changeset in webkit [162043] by
-
- 4 edits in trunk/Source
[iOS] Crash in NavigatorBase::vendor loading apple.com
https://bugs.webkit.org/show_bug.cgi?id=127028
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-14
Reviewed by Daniel Bates.
Source/WebCore:
Export function pointers to be filled in with WebKitSystemInterface functions.
- WebCore.exp.in:
Source/WebKit/mac:
Fill in iOS WebKitSystemInterface functions.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 8:22 PM Changeset in webkit [162042] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix for CMake based ports after r162034.
- CMakeLists.txt:
- 7:56 PM Changeset in webkit [162041] by
-
- 4 edits in trunk/Source
Build fix after r162034
Rubber-stamped by Benjamin Poulain.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebProgressTrackerClient.cpp:
- 7:39 PM Changeset in webkit [162040] by
-
- 2 edits in trunk/LayoutTests
Merged some subpixel skipped tests. Unreviewed.
webkit.org/b/126893 is a duplicate of webkit.org/b/126892
- platform/mac/TestExpectations:
- 7:08 PM Changeset in webkit [162039] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Resource finish time is sometimes earlier than response received time.
https://bugs.webkit.org/show_bug.cgi?id=127027
Reviewed by Joseph Pecoraro.
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didFinishLoading): Use currentTime() and not the
passed in finishTime.
- 7:04 PM Changeset in webkit [162038] by
-
- 2 edits in trunk/Source/WebCore
Follow up build fix attempt.
- WebCore.exp.in:
- 6:59 PM Changeset in webkit [162037] by
-
- 1 copy in tags/Safari-538.12
New Tag.
- 6:58 PM Changeset in webkit [162036] by
-
- 6 edits in trunk/Source/WebCore
Add support for handling WebGL load policies.
https://bugs.webkit.org/show_bug.cgi?id=126935
<rdar://problem/15790448>.
Reviewed by Brent Fulgham.
- WebCore.xcodeproj/project.pbxproj: Copy over HTMLCanvasElement.h to the private headers directory.
- html/HTMLCanvasElement.cpp: Show the policy dialog and retrieve policies as necessary.
(WebCore::HTMLCanvasElement::getContext): Make sure that WebGL is allowed on the site.
If it isn't, be sure to notify the frame loader client that
the site is trying to create a WebGL context.
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::webGLPolicyForHost): Used to get the WebGL load policy for a site.
- loader/FrameLoaderTypes.h:
- page/ChromeClient.h:
(WebCore::ChromeClient::webGLContextCreated): Called when a site is creating a WebGL context.
- 6:57 PM Changeset in webkit [162035] by
-
- 7 edits3 adds in branches/jsCStack/Source/JavaScriptCore
FTL should be cool with runtime functions throwing exceptions
https://bugs.webkit.org/show_bug.cgi?id=127018
Reviewed by Geoffrey Garen.
This just adds the appropriate exception throwing off-ramp to the FTL. There's no
way to express that off-ramp in LLVM IR, so we just use a stackmap that we fill
with a jump to our own off-ramp. It's easy!
The throw-through-optimized-code test already worked because the architecture of
the FTL allows our existing unwinding to "just work". The
runtime-throw-through-optimized-code test used to crash but now works. The
empty-function test currently covers the case where there won't be any exception
handlers, though that will cease to be the case once we have real stack checks.
But even then the test will be useful - an overly optimizable function leads to
many otherwise-needed stackmaps not being emitted, so this will always test some
fun corner cases in FTL::fixFunctionBasedOnStackMaps().
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::entrypoint):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLJITFinalizer.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::callCheck):
- ftl/FTLState.h:
- tests/stress/empty-function.js: Added.
(foo):
- tests/stress/runtime-throw-through-optimized-code.js: Added.
(foo):
(bar):
- tests/stress/throw-through-optimized-code.js: Added.
(foo):
(bar):
- 6:43 PM Changeset in webkit [162034] by
-
- 14 edits3 copies1 add in trunk/Source
Create separate progress tracker clients
https://bugs.webkit.org/show_bug.cgi?id=127025
Reviewed by Sam Weinig.
Source/WebCore:
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::~ProgressTracker):
- loader/ProgressTrackerClient.h:
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebCoreSupport/WebProgressTrackerClient.h: Copied from Source/WebCore/loader/ProgressTrackerClient.h.
- WebCoreSupport/WebProgressTrackerClient.mm: Added.
(WebProgressTrackerClient::WebProgressTrackerClient):
(WebProgressTrackerClient::progressTrackerDestroyed):
(WebProgressTrackerClient::willChangeEstimatedProgress):
(WebProgressTrackerClient::didChangeEstimatedProgress):
(WebProgressTrackerClient::progressStarted):
(WebProgressTrackerClient::progressEstimateChanged):
(WebProgressTrackerClient::progressFinished):
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Source/WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebCoreSupport/WebProgressTrackerClient.cpp: Copied from Source/WebCore/loader/ProgressTrackerClient.h.
(WebKit::WebProgressTrackerClient::WebProgressTrackerClient):
(WebKit::WebProgressTrackerClient::progressTrackerDestroyed):
(WebKit::WebProgressTrackerClient::progressStarted):
(WebKit::WebProgressTrackerClient::progressEstimateChanged):
(WebKit::WebProgressTrackerClient::progressFinished):
- WebProcess/WebCoreSupport/WebProgressTrackerClient.h: Copied from Source/WebCore/loader/ProgressTrackerClient.h.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- 6:26 PM Changeset in webkit [162033] by
-
- 2 edits in trunk/Source/WTF
And yet another build fix.
- wtf/SizeLimits.cpp:
- 6:21 PM Changeset in webkit [162032] by
-
- 2 edits in trunk/Source/WTF
Another build fix.
- wtf/SizeLimits.cpp:
- 6:03 PM Changeset in webkit [162031] by
-
- 3 edits in trunk/Source/WebCore
[WebGL] WebGLRenderingContext::validateCompressedTexDimensions improperly calculates values
https://bugs.webkit.org/show_bug.cgi?id=126926
Reviewed by Dean Jackson.
Test coverage in fast/canvas/webgl/webgl-compressed-texture-size-limit.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::compressedTexImage2D): Pass target to
validation function.
(WebCore::WebGLRenderingContext::validateCompressedTexDimensions): Revise
calculation to also confirm size is in bounds.
(WebCore::WebGLRenderingContext::validateCompressedTexSubDimensions): Pass
target to validation function.
- html/canvas/WebGLRenderingContext.h: Modify signature.
- 5:58 PM Changeset in webkit [162030] by
-
- 2 edits in trunk/Source/WebCore
On iOS, we never want to make scrollbar layers
https://bugs.webkit.org/show_bug.cgi?id=127024
<rdar://problem/15745768>
Reviewed by Dean Jackson.
On platforms that delegate scrolling, don't try to make layers
for scrollbars.
This fixes a crash in RenderLayerCompositor::updateOverflowControlsLayers()
where m_overflowControlsHostLayer is null.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldCompositeOverflowControls):
- 5:39 PM Changeset in webkit [162029] by
-
- 4 edits in trunk/Source/WebKit
Correct grave mistake in updating the pbxproj file rather than xcconfig.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig:
- 5:35 PM Changeset in webkit [162028] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Make WebPageProxy's setUserAgent private
https://bugs.webkit.org/show_bug.cgi?id=127013
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-14
Reviewed by Anders Carlsson.
- UIProcess/WebPageProxy.h:
The API to modify the user agent already has 3 "setters":
-standardUserAgent
-setApplicationNameForUserAgent
-setCustomUserAgent
The method WebPageProxy::setUserAgent() is supposed to be internal, not used directly.
Using it directly would cause unexpected behaviors, for example:
-Set the user agent with setUserAgent.
-Set CustomUserAgent.
-Reset CustomUserAgent.
->The user agent is now standardUserAgent instead of the user agent defined initially.
- 4:52 PM Changeset in webkit [162027] by
-
- 6 edits in trunk/Source
Source/WebCore: Avoid PLATFORM() macros in exported headers.
- platform/ios/WebEvent.h:
Source/WebKit/ios: Avoid PLATFORM() macros in exported headers.
- WebView/WebPDFViewPlaceholder.h:
Source/WebKit/mac: #define ENABLE_DASHBOARD_SUPPORT for iOS.
- WebView/WebViewPrivate.h:
- 4:46 PM Changeset in webkit [162026] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Build fix for 32-bit simulator and device
CGFloat is defined to be float, double for 32-bit, and 64-bit devices respectively.
Because WebCore::createCGColorWithDeviceWhite() takes CGFloat arguments we need to
list both the float and double-variants of this symbol in WebCore.exp.in. Currently
we only list the version whose arguments are of type double.
- WebCore.exp.in:
- 4:28 PM Changeset in webkit [162025] by
-
- 2 edits in trunk/Source/WebKit
Attempt to fix 32-bit Mac build.
- WebKit.xcodeproj/project.pbxproj:
- 4:17 PM Changeset in webkit [162024] by
-
- 9 edits in trunk/Source
Source/WebCore: Clean up exports and headers for iOS.
Don't use ENABLE() macro in an exported header.
- platform/ios/wak/WAKResponder.h:
Source/WebKit/ios: Clean up exports and headers for iOS.
- Misc/WebNSStringDrawing.h: Don't use PLATFORM() macro in an exported header.
- WebCoreSupport/WebFrameIOS.h: Ditto.
- WebCoreSupport/WebSelectionRect.h: Ditto.
Source/WebKit/mac: Clean up exports and headers for iOS.
Need to export WebArchivePboardType on Mac and iOS.
- WebKit.exp:
- WebKit.mac.exp:
- 4:13 PM Changeset in webkit [162023] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Move symbol ZN7WebCore34registerQLPreviewConverterIfNeededEP5NSURLP8NSStringP6NSData to
section USE(QUICK_LOOK)
- WebCore.exp.in:
- 4:07 PM Changeset in webkit [162022] by
-
- 3 edits in trunk/Source/WebCore
Clean up DNSResolveQueue
https://bugs.webkit.org/show_bug.cgi?id=127007
Reviewed by Geoffrey Garen.
Move the shared() getter out of line and make it use NeverDestroyed.
Add a Timer member variable instead of inheriting from TimerBase.
Use std::atomic<int> for the m_requestsInFlight member variable.
- platform/network/DNSResolveQueue.cpp:
(WebCore::DNSResolveQueue::shared):
(WebCore::DNSResolveQueue::DNSResolveQueue):
(WebCore::DNSResolveQueue::add):
(WebCore::DNSResolveQueue::timerFired):
- platform/network/DNSResolveQueue.h:
(WebCore::DNSResolveQueue::decrementRequestCount):
- 4:00 PM Changeset in webkit [162021] by
-
- 2 edits in trunk/Source/WebKit/mac
Fix header availability checks on iOS
https://bugs.webkit.org/show_bug.cgi?id=127016
Reviewed by Andy Estes.
Make DOMTouch* and DOMGesture* headers public headers on iOS,
and fix MigrateHeaders.make to skip availability checks when
building for iOS.
- MigrateHeaders.make:
- 4:00 PM Changeset in webkit [162020] by
-
- 2 edits in trunk/Source/WebCore
Two more exports for iOS.
- WebCore.exp.in:
- 3:22 PM Changeset in webkit [162019] by
-
- 2 edits in trunk/Source/WebKit/mac
Need to #import <WebCore/QuickLook.h>.
- WebView/WebDataSource.mm:
- 3:05 PM Changeset in webkit [162018] by
-
- 2 edits in trunk/Source/WTF
[iOS] Enable WTF_USE_UIKIT_EDITING
- wtf/Platform.h:
- 3:03 PM Changeset in webkit [162017] by
-
- 13 edits in trunk/Source/JavaScriptCore
Copying should be generational
https://bugs.webkit.org/show_bug.cgi?id=126555
Reviewed by Geoffrey Garen.
This patch adds support for copying to our generational collector. Eden collections
always trigger copying. Full collections use our normal fragmentation-based heuristics.
The way this works is that the CopiedSpace now has the notion of an old generation set of CopiedBlocks
and a new generation of CopiedBlocks. During each mutator cycle new CopiedSpace allocations reside
in the new generation. When a collection occurs, those blocks are moved to the old generation.
One key thing to remember is that both new and old generation objects in the MarkedSpace can
refer to old or new generation allocations in CopiedSpace. This is why we must fire write barriers
when assigning to an old (MarkedSpace) object's Butterfly.
- heap/CopiedAllocator.h:
(JSC::CopiedAllocator::tryAllocateDuringCopying):
- heap/CopiedBlock.h:
(JSC::CopiedBlock::CopiedBlock):
(JSC::CopiedBlock::didEvacuateBytes):
(JSC::CopiedBlock::isOld):
(JSC::CopiedBlock::didPromote):
- heap/CopiedBlockInlines.h:
(JSC::CopiedBlock::reportLiveBytes):
(JSC::CopiedBlock::reportLiveBytesDuringCopying):
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::CopiedSpace):
(JSC::CopiedSpace::~CopiedSpace):
(JSC::CopiedSpace::init):
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::didStartFullCollection):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::size):
(JSC::CopiedSpace::capacity):
(JSC::CopiedSpace::isPagedOut):
- heap/CopiedSpace.h:
(JSC::CopiedSpace::CopiedGeneration::CopiedGeneration):
- heap/CopiedSpaceInlines.h:
(JSC::CopiedSpace::contains):
(JSC::CopiedSpace::recycleEvacuatedBlock):
(JSC::CopiedSpace::allocateBlock):
(JSC::CopiedSpace::startedCopying):
- heap/CopyVisitor.cpp:
(JSC::CopyVisitor::copyFromShared):
- heap/CopyVisitorInlines.h:
(JSC::CopyVisitor::allocateNewSpace):
(JSC::CopyVisitor::allocateNewSpaceSlow):
- heap/GCThreadSharedData.cpp:
(JSC::GCThreadSharedData::didStartCopying):
- heap/Heap.cpp:
(JSC::Heap::copyBackingStores):
- heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::copyLater):
- heap/TinyBloomFilter.h:
(JSC::TinyBloomFilter::add):
- 3:01 PM Changeset in webkit [162016] by
-
- 4 edits in trunk/Source
[iOS] Enable QuickLook
https://bugs.webkit.org/show_bug.cgi?id=126954
Reviewed by David Kilzer.
Source/WebKit/mac:
Remove empty implementation for quickLookContentForURL: since we always enable QuickLook on iOS.
- WebView/WebView.mm:
(-[WebView quickLookContentForURL:]):
Source/WTF:
- wtf/Platform.h:
- 2:56 PM Changeset in webkit [162015] by
-
- 5 edits in trunk/Source/WebKit
Source/WebKit/ios: Remove .objc_class_name_WebInspectorXPCWrapper from export on iOS build.
- WebKit.iOS.exp:
Source/WebKit/mac: Move some Mac-only exports to WebKit.mac.exp for iOS build.
- WebKit.exp:
- WebKit.mac.exp:
- 2:55 PM Changeset in webkit [162014] by
-
- 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog
Updated review status on some bugs
- 2:44 PM Changeset in webkit [162013] by
-
- 3 edits in trunk/Source/WebKit/mac
Move some Mac-only exports to WebKit.mac.exp for iOS build.
- WebKit.exp:
- WebKit.mac.exp:
- 2:38 PM Changeset in webkit [162012] by
-
- 2 edits in trunk/Source/WebCore
One more buildfix after r161999.
- Modules/webaudio/MediaStreamAudioSource.h:
- 2:34 PM Changeset in webkit [162011] by
-
- 7 edits in trunk/Source
Source/WebCore: Export ZN7WebCore11FileChooser16chooseMediaFilesERKN3WTF6VectorINS1_6StringELm0ENS1_15CrashOnOverflowEEERKS3_PNS_4IconE
to fix WK1 iOS linking.
- WebCore.exp.in:
Source/WebKit/ios: Fix WK1 iOS build: need implementations of these functions in WebInspectorClientIOS.
- WebCoreSupport/WebInspectorClientIOS.mm:
(WebInspectorClient::indicate):
(WebInspectorClient::hideIndication):
Source/WebKit/mac: Fix iOS WK1 linking.
- Configurations/WebKit.xcconfig: We do need WebOpenPanelResultListener
on iOS.
- WebCoreSupport/WebOpenPanelResultListener.mm: Need <WebCore/Icon.h>
- 2:33 PM Changeset in webkit [162010] by
-
- 2 edits in trunk/Tools
[WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
https://bugs.webkit.org/show_bug.cgi?id=127002
Reviewed by David Kilzer.
- Scripts/webkitdirs.pm:
(setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
- 2:20 PM Changeset in webkit [162009] by
-
- 4 edits in trunk/Source
Source/WebCore: iOS build fixing: export required by iOS WebKit1.
- WebCore.exp.in:
Source/WebKit/mac: iOS build fixing: link WebKit against Security.framework on iOS.
- Configurations/WebKit.xcconfig:
- 2:18 PM Changeset in webkit [162008] by
-
- 4 edits1 add in trunk/Source/WebKit
[WK1] Allow generated export files on iOS
https://bugs.webkit.org/show_bug.cgi?id=127008
Reviewed by Simon Fraser.
Source/WebKit:
Modify the export file generation rule to read from
a shared and platform-specific input file.
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Add a new Mac-only symbol file.
- WebKit.exp: To begin, move the WebIcon* into the Mac-specific exports.
- WebKit.mac.exp: Added. New file holds Mac-only symbols.
- 2:13 PM Changeset in webkit [162007] by
-
- 27 edits in trunk
Unreviewed, rolling out r162000.
http://trac.webkit.org/changeset/162000
https://bugs.webkit.org/show_bug.cgi?id=127009
API versioning is wrong (Requested by rfong on #webkit).
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
- loader/FrameLoaderClient.h:
- loader/FrameLoaderTypes.h:
- page/ChromeClient.h:
Source/WebKit2:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKPageLoaderClient.h:
- UIProcess/API/C/WKPageUIClient.h:
- UIProcess/WebLoaderClient.cpp:
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
- UIProcess/WebUIClient.h:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
Tools:
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):
- 2:11 PM Changeset in webkit [162006] by
-
- 3 edits3 adds in trunk
ASSERTION FAILED: !hasError() in JSC::Parser<LexerType>::createSavePoint().
https://bugs.webkit.org/show_bug.cgi?id=126990.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseConstDeclarationList):
- We were missing an error check after attempting to parse an initializer expression. This is now fixed.
LayoutTests:
- js/dom/parse-syntax-error-in-initializer-expected.txt: Added.
- js/dom/parse-syntax-error-in-initializer.html: Added.
- js/resources/parse-syntax-error-in-initializer.js: Added.
- Added bug test case as a regression test.
- 2:10 PM Changeset in webkit [162005] by
-
- 2 edits in trunk/Source/WebKit2
Speculative buildfix after r161999.
- Shared/APIObject.h:
- 1:53 PM Changeset in webkit [162004] by
-
- 5 edits in branches/safari-537.60-branch/Source
Versioning.
- 1:50 PM Changeset in webkit [162003] by
-
- 1 copy in tags/Safari-537.60.13
New Tag.
- 1:46 PM Changeset in webkit [162002] by
-
- 2 edits in trunk/LayoutTests
Skip some tests that now fail after r162000.
https://bugs.webkit.org/show_bug.cgi?id=127000.
- platform/mac/TestExpectations:
- 1:42 PM Changeset in webkit [162001] by
-
- 5 edits in trunk/Source/WebCore
[CSS Shapes] Move CSSPrimitiveValue <-> LayoutBox Conversion to CSSPrimitiveValueMappings
https://bugs.webkit.org/show_bug.cgi?id=126719
Reviewed by Dirk Schulze.
The standard location for conversions to/from CSSPrimitiveValues is CSSPrimitiveValueMappings.
This patch moves the conversion for LayoutBoxes from BasicShapeFunctions to
CSSPrimitiveValueMappings.h.
Refactoring, no new tests.
- css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape):
(WebCore::basicShapeForValue):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LayoutBox):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
- 1:41 PM Changeset in webkit [162000] by
-
- 27 edits in trunk
Add support for handling WebGL load policies.
https://bugs.webkit.org/show_bug.cgi?id=126935
<rdar://problem/15790448>.
Reviewed by Brent Fulgham.
- WebCore.xcodeproj/project.pbxproj: Copy over HTMLCanvasElement.h to the private headers directory.
- html/HTMLCanvasElement.cpp: Show the policy dialog and retrieve policies as necessary.
(WebCore::HTMLCanvasElement::getContext): Make sure that WebGL is allowed on the site.
If it isn't, be sure to notify the frame loader client that
the site is trying to create a WebGL context.
Boiler plate code for sending messages to and from the UI and Web Process.
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::webGLPolicyForHost): Used to get the WebGL load policy for a site.
- loader/FrameLoaderTypes.h:
- page/ChromeClient.h:
(WebCore::ChromeClient::webGLContextCreated): Called when a site is creating a WebGL context.
- UIProcess/API/C/WKAPICast.h:
(WebKit::toWebGLLoadPolicy):
- UIProcess/API/C/WKPageLoaderClient.h:
- UIProcess/API/C/WKPageUIClient.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::webGLLoadPolicy):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::webGLContextCreated):
(WebKit::WebPageProxy::webGLPolicyForHost):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::webGLContextCreated):
- UIProcess/WebUIClient.h:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::webGLContextCreated):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::webGLPolicyForHost):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp: A sendSync is used here to get the webGLPolicyForHost message sent between the Web and UI process.
In the future this will be replaced with a strategy is non-blocking.
(WebKit::WebPage::getWebGLPolicyForHost):
- WebProcess/WebPage/WebPage.h:
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
- 1:38 PM Changeset in webkit [161999] by
-
- 9 edits1 delete in trunk/Source
Get rid of ThreadRestrictionVerifier
https://bugs.webkit.org/show_bug.cgi?id=127004
Reviewed by Sam Weinig.
Source/WebCore:
Remove now unneeded calls.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::defaultIcon):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::getOrCreateIconRecord):
(WebCore::IconDatabase::readFromDatabase):
Source/WTF:
The ThreadRestrictionVerifier mechanism has been turned off for a while
since it doesn't really have a good solution for objects that are passed between threads.
Instead of having dead code in the tree, just get rid of it.
- GNUmakefile.list.am:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/RefCounted.h:
(WTF::RefCountedBase::ref):
(WTF::RefCountedBase::hasOneRef):
(WTF::RefCountedBase::refCount):
(WTF::RefCountedBase::derefBase):
- wtf/ThreadRestrictionVerifier.h: Removed.
- 1:19 PM Changeset in webkit [161998] by
-
- 3 edits in trunk/Source/WebKit2
WebKit2 leaks sudden termination assertions when a page with unload handlers is closed.
<https://webkit.org/b/126974> / <rdar://problem/15812954>
When a page with an unload handler is loaded, the web process tells the UI process that it
should disable sudden termination. However, when the page is closed the connection between
the web and UI process is torn down before the web content has a chance to tell the UI
process to reenable sudden termination.
Reviewed by Anders Carlsson.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::~WebProcessProxy): Balance any outstanding disableSuddenTermination calls.
(WebKit::WebProcessProxy::enableSuddenTermination): Decrement the count.
(WebKit::WebProcessProxy::disableSuddenTermination): Increment the count.
- UIProcess/WebProcessProxy.h:
- 12:59 PM Changeset in webkit [161997] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Directly allocate NSMutableDictionary in QLPreviewConverterDictionary() and QLContentDictionary()
https://bugs.webkit.org/show_bug.cgi?id=126999
<rdar://problem/15810305>
Reviewed by Joseph Pecoraro.
Fixes an issue where we may crash when subsequently accessing WebCore::QLPreviewConverterDictionary()
or WebCore::QLContentDictionary(). Currently neither of these functions retain'ed the NSMutable dictionary
returned by [NSMutableDictionary dictionary]. Instead, we should allocate and initialize NSMutableDictionary
directly to ensure that the dictionary is retained.
- platform/network/ios/QuickLook.mm:
(QLPreviewConverterDictionary):
(QLContentDictionary):
- 12:52 PM Changeset in webkit [161996] by
-
- 4 edits2 adds in trunk
Source/WebCore: [WebGL] Invalid range checking in WebGLRenderingContext::validateTexFuncLevel
https://bugs.webkit.org/show_bug.cgi?id=126925
Reviewed by Dean Jackson.
Added fast/canvas/webgl/webgl-compressed-texture-size-limit.html.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateTexFuncLevel): Avoid off-by-one error
LayoutTests: [WebGL] Invalid range checking in WebGLRenderContext::validateTexFunctionLevel
https://bugs.webkit.org/show_bug.cgi?id=126925
Reviewed by Dean Jackson.
- fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils): Add missing 'waitForComposite' implementatino.
- fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Added.
- fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Added.
- 12:28 PM Changeset in webkit [161995] by
-
- 4 edits in trunk/Source/WebCore
WebCore icon database appears to leak sudden termination assertions
<https://webkit.org/b/126971> / <rdar://problem/15808797>
Introduce an RAII wrapper around disableSuddenTermination / enableSuddenTermination
and adopt it in IconDatabase to address the incorrect management of sudden termination.
IconDatabase now owns up to two SuddenTerminationDisabler objects. One ensures that
sudden termination is disabled while we're waiting on the sync timer to fire. The second
ensures that sudden termination is disabled while we're waiting on the sync thread to
process any pending work.
Reviewed by Alexey Proskuryakov.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::wakeSyncThread): Disable sudden termination until the sync thread
has finished this unit of work.
(WebCore::IconDatabase::scheduleOrDeferSyncTimer): Disable sudden termination until the
sync timer has fired.
(WebCore::IconDatabase::syncTimerFired): Clear the member variable to reenable sudden termination.
(WebCore::IconDatabase::syncThreadMainLoop): Taken ownership of the SuddenTerminationDisabler
instance when we start processing a unit of work. Discard the object when our work is complete.
- loader/icon/IconDatabase.h:
- platform/SuddenTermination.h:
(WebCore::SuddenTerminationDisabler::SuddenTerminationDisabler): Disable sudden termination when created.
(WebCore::SuddenTerminationDisabler::~SuddenTerminationDisabler): Enable it when destroyed.
- 12:23 PM Changeset in webkit [161994] by
-
- 12 edits in trunk/Source
Web Inspector: For Remote Inspection link WebProcess's to their parent UIProcess
https://bugs.webkit.org/show_bug.cgi?id=126995
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-14
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::listingForDebuggable):
For each WebView, list the parent process. Listing the parent per WebView
is already supported back when we supported processes that could host WebViews
for multiple applications.
- inspector/remote/RemoteInspectorConstants.h:
Add a separate key for the bundle identifier, separate from application identifier.
- inspector/remote/RemoteInspectorDebuggable.cpp:
(Inspector::RemoteInspectorDebuggable::info):
- inspector/remote/RemoteInspectorDebuggable.h:
(Inspector::RemoteInspectorDebuggableInfo::RemoteInspectorDebuggableInfo):
(Inspector::RemoteInspectorDebuggableInfo::hasParentProcess):
If a RemoteInspectorDebuggable has a non-zero parent process identifier
it is a proxy for the parent process.
Source/WebCore:
- inspector/InspectorClient.h:
(WebCore::InspectorClient::parentProcessIdentifier):
Client method intended for WebKit2 so a WebProcess can link to its UIProcess.
- page/PageDebuggable.h:
- page/PageDebuggable.cpp:
(WebCore::PageDebuggable::parentProcessIdentifier):
Provide parent process identifier if there is one.
Source/WebKit2:
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::parentProcessIdentifier):
WebProcesses are proxies for a parent UIProcess.
- 12:17 PM Changeset in webkit [161993] by
-
- 2 edits in trunk/Source/WTF
Enable the experimental selector code generator by default
https://bugs.webkit.org/show_bug.cgi?id=126953
Reviewed by Gavin Barraclough.
- wtf/Platform.h:
Enable CSS_SELECTOR_JIT on OS X x86_64 by default.
The feature is not ready to ship but it is stable enough to enable
for the bots and nightly.
- 12:14 PM Changeset in webkit [161992] by
-
- 2 edits in trunk/Source/WebKit2
iOS WebKit2 build fixes, part 3
- WebKit2.xcodeproj/project.pbxproj:
Remove some files from the 'All' target that should never have been a part of it.
- 12:07 PM Changeset in webkit [161991] by
-
- 4 edits in trunk/Source
iOS WebKit2 build fixes, part 2
- WebKit2.xcodeproj/project.pbxproj:
Add some missing files.
- WebCore.exp.in:
Export some more symbols.
- 11:50 AM Changeset in webkit [161990] by
-
- 2 edits in trunk/Tools
[GTK] Skip FontConfig initialization in WebKitTestRunner if requested
https://bugs.webkit.org/show_bug.cgi?id=120110
Reviewed by Martin Robinson.
Skip the FontConfig settings initialization in WebKitTestRunner if the
WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
This is useful when profiling the WebKitTestRunner execution, where at the startup
this step takes considerable amount of time and disturbs the profiling output.
- WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::initializeFontConfigSetting):
- 11:41 AM Changeset in webkit [161989] by
-
- 12 edits2 copies in branches/safari-537.60-branch
Merge r154470
2013-08-22 Simon Fraser <Simon Fraser>
compositing/geometry/bounds-ignores-hidden-dynamic.html has incorrect initial rendering
https://bugs.webkit.org/show_bug.cgi?id=119825
Source/WebCore:
Reviewed by Tim Horton.
r137526 and some earlier commits attempted to avoid unconditionally
repainting layers when their size changes, because this was causing
TiledBacking layers to repaint when the document size changed.
However, the approach required that we have good information about
whether size changes require a repaint, which in some cases is hard
to determine, especially when RenderLayer changes affect our
decisions about which layers are composited.
Fix by pushing the decision about whether to repaint on size change
into GraphicsLayer. The default is to repaint on size change,
but GraphicsLayer provides a function that can be overridden to
modify this behavior; GraphicsLayerCA does so to avoid repaints
when layers with TiledBackings get resized.
Test: compositing/repaint/repaint-on-layer-grouping-change.html
- WebCore.exp.in: WebKit2 needs GraphicsLayer::setSize, which is no longer inline.
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setOffsetFromRenderer): (WebCore::GraphicsLayer::setSize):
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::shouldRepaintOnSizeChange):
- platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::shouldRepaintOnSizeChange):
- platform/graphics/ca/GraphicsLayerCA.h:
- rendering/RenderLayerBacking.h: No longer need m_boundsConstrainedByClipping
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::updateCompositedBounds): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): setSize takes care of repainting for us now, so we can remove all the conditional code.
LayoutTests:
Reviewed by Tim Horton.
Test that dumps repaint rects on layers after visibility changes affect
the layer hierarchy.
- compositing/repaint/repaint-on-layer-grouping-change-expected.txt: Added.
- compositing/repaint/repaint-on-layer-grouping-change.html: Added.
- compositing/repaint/resize-repaint-expected.txt: Update result.
- 11:21 AM Changeset in webkit [161988] by
-
- 12 edits in trunk
Add ENABLE(WEB_REPLAY) feature flag to the build system
https://bugs.webkit.org/show_bug.cgi?id=126949
Patch by Brian J. Burg <Brian Burg> on 2014-01-14
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h: for now, disable the flag by default.
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 11:19 AM Changeset in webkit [161987] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore::MediaSourcePrivateAVFObjC::hasAudio const + 13
https://bugs.webkit.org/show_bug.cgi?id=126768
Reviewed by Eric Carlson.
Null-check m_mediaSourcePrivate before calling.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasVideo):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasAudio):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):
- 11:13 AM Changeset in webkit [161986] by
-
- 5 edits in trunk/Tools
REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
https://bugs.webkit.org/show_bug.cgi?id=126702
Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-14
Reviewed by Alexey Proskuryakov.
Resolve regression and remove a FIXME comment that is already fixed.
- Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.open_text_file_for_reading):
- Scripts/webkitpy/common/system/filesystem_unittest.py:
(RealFileSystemTest.test_read_and_write_file):
- Scripts/webkitpy/style/filereader.py:
(TextFileReader._read_lines):
- Scripts/webkitpy/style/filereader_unittest.py:
(TextFileReaderTest.test_count_delete_only_file):
(TextFileReaderTest):
(TextFileReaderTest.test_process_malformed_file):
- 10:59 AM Changeset in webkit [161985] by
-
- 1 edit1 move in trunk/Source/WebKit2
Move WKView.mm to WKViewIOS.mm as 161950 was supposed to do.
- UIProcess/API/ios/WKView.mm: Removed.
- UIProcess/API/ios/WKViewIOS.mm: Copied from UIProcess/API/ios/WKView.mm.
- 10:59 AM Changeset in webkit [161984] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Playback rate is not set when pipeline is not ready.
https://bugs.webkit.org/show_bug.cgi?id=126692
Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-14
Reviewed by Philippe Normand.
No new tests. Covered by existing tests.
Added new method updatePlaybackRate which is called when playback rate change is possible.
Added m_lastPlaybackRate in order to retrieve last correct playback rate and notify upper
layers about that setting playback rate failed.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::updatePlaybackRate):
(WebCore::MediaPlayerPrivateGStreamer::setRate):
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 10:42 AM Changeset in webkit [161983] by
-
- 2 edits in trunk/Source/WTF
[Win] Application name in user agent string is truncated.
https://bugs.webkit.org/show_bug.cgi?id=126810
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-01-14
Reviewed by Anders Carlsson.
- wtf/text/StringConcatenate.h:
(WTF::tryMakeString): Add missing 8 bit check for last argument.
- 10:39 AM Changeset in webkit [161982] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r161978.
http://trac.webkit.org/changeset/161978
https://bugs.webkit.org/show_bug.cgi?id=126992
Test case causes crash on some hardware (Requested by bfulgham
on #webkit).
Source/WebCore:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateTexFuncLevel):
LayoutTests:
- fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils):
- fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Removed.
- fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Removed.
- 10:19 AM Changeset in webkit [161981] by
-
- 6 edits4 deletes in trunk
Unreviewed, rolling out r161964 and r161965.
http://trac.webkit.org/changeset/161964
http://trac.webkit.org/changeset/161965
https://bugs.webkit.org/show_bug.cgi?id=126988
Tests do not pass on the bots because of slight color
differences. The tests should be redone with squared results
and blending that leads to stable colors. (Requested by krit_
on #webkit).
Source/WebCore:
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::draw):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern):
LayoutTests:
- css3/compositing/background-blend-mode-crossfade-image-expected.html: Removed.
- css3/compositing/background-blend-mode-crossfade-image.html: Removed.
- css3/compositing/background-blend-mode-data-uri-svg-image-expected.html: Removed.
- css3/compositing/background-blend-mode-data-uri-svg-image.html: Removed.
- 10:16 AM Changeset in webkit [161980] by
-
- 11 edits4 adds in trunk
[CSS Shapes] Shape images are now <image> types, not just URIs
https://bugs.webkit.org/show_bug.cgi?id=125224
Reviewed by Andreas Kling.
Source/WebCore:
Added support for image-set valued shapes. Added an optional ResourceLoaderOptions
parameter to CSSImageSetValue::cachedImageSet() to enable CORS-enabled fetch of
image-set images. This change is based on a similar patch for ordinary shape image values:
https://bugs.webkit.org/show_bug.cgi?id=123114.
Tests: fast/shapes/shape-inside/shape-inside-image-set.html
fast/shapes/shape-outside-floats/shape-outside-image-set.html
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::cachedImageSet):
- css/CSSImageSetValue.h:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseShapeProperty):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyShape::applyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingShapeImage):
- css/StyleResolver.h:
- rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape):
LayoutTests:
- fast/shapes/shape-inside/shape-inside-image-set-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-image-set.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-image-set-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-image-set.html: Added.
- 10:09 AM Changeset in webkit [161979] by
-
- 19 edits in trunk/Source/WebCore
AX: Modernize AccessibilityChildrenVector loops
https://bugs.webkit.org/show_bug.cgi?id=126915
Reviewed by Anders Carlsson.
Change appropriate for loops to use the new style.
Use auto where appropriate.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedImageMapUIElement):
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addRowDescendant):
- accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::rowIndexRange):
- accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):
(WebCore::AccessibilityARIAGridRow::parentTable):
(WebCore::AccessibilityARIAGridRow::headerObject):
- accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::addChildren):
(WebCore::AccessibilityListBox::setSelectedChildren):
(WebCore::AccessibilityListBox::selectedChildren):
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::listBoxOptionIndex):
- accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::didUpdateActiveOption):
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::addChildren):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::insertChild):
(WebCore::AccessibilityNodeObject::selectedRadioButton):
(WebCore::AccessibilityNodeObject::selectedTabItem):
(WebCore::AccessibilityNodeObject::ariaLabeledByText):
- accessibility/AccessibilityObject.cpp:
(WebCore::appendChildrenToArray):
(WebCore::AccessibilityObject::clearChildren):
(WebCore::AccessibilityObject::ariaTreeRows):
(WebCore::AccessibilityObject::ariaTreeItemContent):
(WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::ariaFlowToElements):
(WebCore::AccessibilityRenderObject::isTabItemSelected):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::AccessibilityRenderObject::ariaOwnsElements):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::addRemoteSVGChildren):
(WebCore::AccessibilityRenderObject::updateAttachmentViewParents):
(WebCore::AccessibilityRenderObject::addHiddenChildren):
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::ariaListboxVisibleChildren):
(WebCore::AccessibilityRenderObject::tabChildren):
(WebCore::AccessibilityRenderObject::mathRadicandObject):
(WebCore::AccessibilityRenderObject::mathRootIndexObject):
(WebCore::AccessibilityRenderObject::mathNumeratorObject):
(WebCore::AccessibilityRenderObject::mathDenominatorObject):
(WebCore::AccessibilityRenderObject::mathUnderObject):
(WebCore::AccessibilityRenderObject::mathOverObject):
(WebCore::AccessibilityRenderObject::mathBaseObject):
(WebCore::AccessibilityRenderObject::mathSubscriptObject):
(WebCore::AccessibilityRenderObject::mathSuperscriptObject):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::visibleRows):
(WebCore::AccessibilityTable::cells):
(WebCore::AccessibilityTable::cellForColumnAndRow):
- accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::headerObject):
- accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::addChildren):
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::headerObject):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
(-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
(-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(convertMathPairsToNSArray):
(-[WebAccessibilityObjectWrapperBase accessibilityTitle]):
(-[WebAccessibilityObjectWrapperBase accessibilityDescription]):
(-[WebAccessibilityObjectWrapperBase accessibilityHelpText]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(convertToNSArray):
(convertStringsToNSArray):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
- 9:53 AM Changeset in webkit [161978] by
-
- 4 edits2 adds in trunk
Source/WebCore: [WebGL] Invalid range checking in WebGLRenderingContext::validateTexFuncLevel
https://bugs.webkit.org/show_bug.cgi?id=126925
Reviewed by Dean Jackson.
Added fast/canvas/webgl/webgl-compressed-texture-size-limit.html.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateTexFuncLevel): Avoid off-by-one error
LayoutTests: [WebGL] Invalid range checking in WebGLRenderContext::validateTexFunctionLevel
https://bugs.webkit.org/show_bug.cgi?id=126925
Reviewed by Dean Jackson.
- fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils): Add missing 'waitForComposite' implementatino.
- fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Added.
- fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Added.
- 9:41 AM Changeset in webkit [161977] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Mac TestExpectations update.
<https://webkit.org/b/126890> is duplicate of <https://webkit.org/b/126889>
- platform/mac/TestExpectations: Mark it as such.
- 9:30 AM Changeset in webkit [161976] by
-
- 8 edits in trunk/Source/WebKit2
[GTK] Test /webkit2/WebKitWebContext/languages crashes with network process enabled
https://bugs.webkit.org/show_bug.cgi?id=126130
Reviewed by Anders Carlsson.
We need to notify the network process when the user preferred
languages have changed to update the SoupSession accordingly.
- NetworkProcess/NetworkProcess.h: Add
userPreferredLanguagesChanged when using soup network backend.
- NetworkProcess/NetworkProcess.messages.in: Add
UserPreferredLanguagesChanged message when using soup network
backend.
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::userPreferredLanguagesChanged): Update
the SoupSession to use the given languages.
(WebKit::NetworkProcess::platformInitializeNetworkProcess): Call
userPreferredLanguagesChanged() when initialization parameters
contain languages.
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
Remove unnedded WebCore prefix.
(WebKit::NetworkProcess::clearCacheForAllOrigins): Simplify using
a single line.
- Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode): Encode the
languages vector.
(WebKit::NetworkProcessCreationParameters::decode): Decode the
languages vector.
- Shared/Network/NetworkProcessCreationParameters.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::languageChanged): Send a message also to the
network process.
- UIProcess/soup/WebContextSoup.cpp:
(WebKit::WebContext::platformInitializeNetworkProcess): Set
languages initial parameter.
- 9:16 AM Changeset in webkit [161975] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
Fix 64-bit C Loop LLINT for !ENABLE(COMPUTED_GOTO_OPCODES).
https://bugs.webkit.org/show_bug.cgi?id=126959.
Reviewed by Michael Saboff.
- llint/LowLevelInterpreter.asm:
- The LLINT sanitizeStackForVM() is not needed by the C loop, and will cause a build failure in the non-computed goto C loop build. This is now fixed by excluding the LLINT sanitizeStackForVM() from the C loop build.
- 9:02 AM Changeset in webkit [161974] by
-
- 5 edits in trunk/Source
[SOUP] SoupNetworkSession::setAcceptLanguages should receive a const reference
https://bugs.webkit.org/show_bug.cgi?id=126966
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
We don't really need to modify the Vector just to ignore the C
locale.
- platform/network/soup/SoupNetworkSession.cpp:
(WebCore::buildAcceptLanguages): Rework it to not modify the
passed vector to ignore the C locale when it's present.
(WebCore::SoupNetworkSession::setAcceptLanguages): Use const Vector<String>&.
- platform/network/soup/SoupNetworkSession.h:
Source/WebKit2:
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::setSoupSessionAcceptLanguage): Use const Vector<String>&.
- 8:41 AM Changeset in webkit [161973] by
-
- 2 edits in trunk/Source/WebCore
HTMLMediaElement::potentiallyPlaying can be more simple.
https://bugs.webkit.org/show_bug.cgi?id=111
Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-14
Reviewed by Eric Carlson.
Tests: No new tests, just refactorings.
Expression is simplified because the first 'if' statement depends on the same condition
as pausedToBuffer value.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- 8:29 AM Changeset in webkit [161972] by
-
- 2 edits1 copy in tags/Safari-538.11.1/Source/JavaScriptCore
Merged r161574. <rdar://problem/15762689>
- 8:29 AM Changeset in webkit [161971] by
-
- 5 edits in trunk/Source
Remove deprecated DeferrableOneShotTimer constructor.
<https://webkit.org/b/126984>
Source/WebCore:
Remove the deprecated constructor for callback functions that take
the timer by pointer instead of by reference.
This shrinks DeferrableOneShotTimer by 8 bytes.
Reviewed by Anders Carlsson.
- platform/Timer.h:
(WebCore::DeferrableOneShotTimer::DeferrableOneShotTimer):
Source/WebKit2:
Reviewed by Anders Carlsson.
- WebProcess/Plugins/PluginView.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginSnapshotTimerFired):
Take the timer by reference so we can use the new constructor.
- 8:21 AM Changeset in webkit [161970] by
-
- 4 edits2 copies in tags/Safari-538.11.1
Merged r161404. <rdar://problem/15398575>
- 8:03 AM Changeset in webkit [161969] by
-
- 5 edits in tags/Safari-538.11.1/Source
Versioning.
- 8:00 AM Changeset in webkit [161968] by
-
- 1 copy in tags/Safari-538.11.1
New Tag.
- 7:58 AM Changeset in webkit [161967] by
-
- 7 edits in trunk/Source/WebCore
Make CachedSVGDocument independent of CSS Filters
https://bugs.webkit.org/show_bug.cgi?id=126133
Reviewed by Antti Koivisto.
Clean-up the pendingSVGDocuments code in StyleResolver.
CachedSVGDocumentReference is responsible for requesting the
SVG document instead of WebKitCSSSVGDocumentValue.
CachedSVGDocumentReference can be used by other SVG resource like
clip-path and mask now so that these may load external resources
as well.
WebKitCSSSVGDocumentValue does not provide any further value
and will be removed in the next patch.
Refactoring, no new test cases.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::createFilterOperations):
- css/StyleResolver.h: Replace Map with a Set.
(WebCore::StyleResolver::State::pendingSVGDocuments): Use the Set from now on.
- loader/cache/CachedSVGDocumentReference.cpp:
(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::load):
- loader/cache/CachedSVGDocumentReference.h: Is responsible for
requesting the SVG document.
(WebCore::CachedSVGDocumentReference::create):
(WebCore::CachedSVGDocumentReference::loadRequested):
- platform/graphics/filters/FilterOperation.cpp:
(WebCore::ReferenceFilterOperation::createCachedSVGDocumentReference):
- platform/graphics/filters/FilterOperation.h:
- 7:45 AM Changeset in webkit [161966] by
-
- 4 edits in trunk
[ATK] AXChildrenChanged notification handling is a performance black hole
https://bugs.webkit.org/show_bug.cgi?id=126970
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Remove code that is causing a huge performance problem when
loading big pages, just to be able to emit the children-changed:add
signal at the exact time a child is added.
This removal does not imply that the signal won't be ever emitted,
just that it will be emitted a bit later (when the new child is
asynchronously added to the tree), which should be good enough
anyway for Accessible Technologies, without impacting perfformance
in such a negative way.
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::postPlatformNotification): Removed
extremely expensive referring loop when AXChildrenChanged is received.
LayoutTests:
Because of the removal of the referring test when
AXChildrenChanged is received, the children-changed:add signal is
now emitted later, so we need to reorder the expectations.
- accessibility/children-changed-sends-notification-expected.txt: Updated.
- 7:41 AM Changeset in webkit [161965] by
-
- 3 edits2 adds in trunk
Source/WebCore: [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend
when having -webkit-background-blending applied. Turns out the problem was
the blending parameter not being passed to WebCore::CrossfadeGeneratedImage::draw
https://bugs.webkit.org/show_bug.cgi?id=126887
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-14
Reviewed by Dirk Schulze.
Test: css3/compositing/background-blend-mode-crossfade-image.html
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::draw): set blendMode on context.
LayoutTests: [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend
when having -webkit-background-blending applied.
https://bugs.webkit.org/show_bug.cgi?id=126887
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-14
Reviewed by Dirk Schulze.
- css3/compositing/background-blend-mode-crossfade-image-expected.html: Added.
- css3/compositing/background-blend-mode-crossfade-image.html: Added.
- 7:38 AM Changeset in webkit [161964] by
-
- 5 edits2 adds in trunk
Source/WebCore: Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
The problem consisted in the drawing path using the default
blending parameter at all times.
https://bugs.webkit.org/show_bug.cgi?id=118894
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-14
Reviewed by Dirk Schulze.
Test: css3/compositing/background-blend-mode-data-uri-svg-image.html
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer): Pass blendMode to Image::drawPattern.
- svg/graphics/SVGImage.h: Add a blendMode parameter to drawPatternForContainer.
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern): Pass blendMode to drawPatternForContainer call.
LayoutTests: Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
https://bugs.webkit.org/show_bug.cgi?id=118894
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-14
Reviewed by Dirk Schulze.
- css3/compositing/background-blend-mode-data-uri-svg-image-expected.html: Added.
- css3/compositing/background-blend-mode-data-uri-svg-image.html: Added.
- 7:35 AM Changeset in webkit [161963] by
-
- 2 edits in trunk/Source/WebCore
Remove accidentally added PLATFORM(QT) from Source/WebCore/editing/EditorCommand.cpp after r161638
https://bugs.webkit.org/show_bug.cgi?id=126980
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-14
Reviewed by Andreas Kling.
- editing/EditorCommand.cpp:
(WebCore::createCommandMap):
- 7:20 AM Changeset in webkit [161962] by
-
- 3 edits in trunk/Source/JavaScriptCore
[EFL] FTL buildfix, add missing includes
https://bugs.webkit.org/show_bug.cgi?id=126641
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-14
Reviewed by Csaba Osztrogonác.
- ftl/FTLOSREntry.cpp:
- ftl/FTLOSRExitCompiler.cpp:
- 7:13 AM Changeset in webkit [161961] by
-
- 1 edit2 adds in trunk/LayoutTests
[CSSRegions] Test dynamic change of position for fixed element in named flow
https://bugs.webkit.org/show_bug.cgi?id=126807
Reviewed by Dirk Schulze.
- fast/regions/fixed-in-named-flow-position-changed-expected.html: Added.
- fast/regions/fixed-in-named-flow-position-changed.html: Added.
- 6:51 AM Changeset in webkit [161960] by
-
- 3 edits in trunk/Source/WebCore
[CSSRegions] The list of fixed positioned layers in named flows should be sorted by z-index
https://bugs.webkit.org/show_bug.cgi?id=126978
Reviewed by Antti Koivisto.
Return the list of fixed positioned layers sorted by z-index from
FlowThreadController::collectFixedPositionedLayers instead of manually sort it
every time we need it (RenderLayer::paintFixedLayersInNamedFlows, RenderLayer::hitTestFixedLayersInNamedFlows).
Refactoring covered by existing regions tests.
- rendering/FlowThreadController.cpp:
(WebCore::compareZIndex):
(WebCore::FlowThreadController::collectFixedPositionedLayers):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintFixedLayersInNamedFlows):
(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):
- 6:20 AM Changeset in webkit [161959] by
-
- 2 edits9 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Added missing baselines for some regions tests.
- platform/gtk/TestExpectations: Unskip tests as new baselines have been added.
- platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
- platform/gtk/fast/regions/region-dynamic-after-before-expected.txt: Added.
- platform/gtk/fast/regions/region-generated-content-before-after-expected.txt: Added.
- platform/gtk/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
- platform/gtk/fast/regions/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
- platform/gtk/fast/regions/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
- platform/gtk/fast/regions/repaint/region-painting-invalidation-expected.txt: Added.
- platform/gtk/fast/regions/repaint/region-painting-via-layout-expected.txt: Added.
- platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Added.
- 5:26 AM Changeset in webkit [161958] by
-
- 2 edits in trunk/Source/WebCore
Pack ResourceLoaderOptions harder.
<https://webkit.org/b/126972>
Make all ResourceLoaderOptions members bitfields to reduce padding,
shrinking it from 28 to 4 bytes.
Reviewed by Antti Koivisto.
- loader/ResourceLoaderOptions.h:
- 5:14 AM Changeset in webkit [161957] by
-
- 1 edit5 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Added missing baselines for some regions tests.
- platform/gtk/fast/regions/auto-size/autoheight-regions-mark-expected.txt: Added.
- platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
- platform/gtk/fast/regions/flows-dependency-same-flow-expected.txt: Added.
- platform/gtk/fast/regions/iframe-html-collected-expected.txt: Added.
- 3:51 AM Changeset in webkit [161956] by
-
- 2 edits2 adds in trunk/Tools
[GTK] Parse Valgrind xml leak files
https://bugs.webkit.org/show_bug.cgi?id=119446
Reviewed by Alejandro G. Castro.
Parse the xml files generated by Valgrind to yield useful
information about the memory leaks.
- Scripts/webkitpy/port/gtk.py:
(GtkPort.init):
(GtkPort.setup_test_run): Clear the previous output files before new
run.
(GtkPort.print_leaks_summary):
- Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
Parse the xml files generated by Valgrind and summarise leaks
into an easily understandable list.
(get_text_of):
(get_CDATA_of):
(gather_frames):
(ValgrindError):
(ValgrindError.init):
(ValgrindError.str):
(ValgrindError.unique_string):
(ValgrindError.error_hash):
(ValgrindError.hash):
(ValgrindError.eq):
(LeakDetectorValgrind):
(LeakDetectorValgrind.init):
(LeakDetectorValgrind._parse_leaks_output):
(LeakDetectorValgrind.leaks_files_in_results_directory):
(LeakDetectorValgrind.clean_leaks_files_from_results_directory):
(LeakDetectorValgrind.parse_and_print_leaks_detail):
- Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
(make_mock_valgrind_output):
(make_mock_incomplete_valgrind_output):
(make_mock_valgrind_results):
(make_mock_valgrind_results_incomplete):
(make_mock_valgrind_results_empty):
(make_mock_valgrind_results_misformatted):
(mock_run_cppfilt_command):
(LeakDetectorValgrindTest):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
- 2:39 AM Changeset in webkit [161955] by
-
- 2 edits in trunk/Source/WebCore
Pack ResourceError harder.
<https://webkit.org/b/126969>
Re-arrange the members of ResourceError to reduce padding,
shrinking it by 8 bytes.
Reviewed by Antti Koivisto.
- platform/network/ResourceErrorBase.h:
(WebCore::ResourceErrorBase::ResourceErrorBase):
- 2:35 AM Changeset in webkit [161954] by
-
- 4 edits in trunk/Source/WebCore
Pack RenderLayer harder.
<https://webkit.org/b/126967>
Re-arrange the members of ScrollableArea a bit so that RenderLayer
can combine its bitfields with the ones in ScrollableArea.
This makes RenderLayer fit into a snugger size class, saving 32 bytes
per layer.
296 kB progression on Membuster3.
Reviewed by Antti Koivisto.
- platform/ScrollableArea.cpp:
- platform/ScrollableArea.h:
Put bitfield members at the end of ScrollableArea so inheriting
classes can synergize with the padding.
- rendering/RenderLayer.h:
Make m_blendMode a bitfield to avoid bloating the class.
- 12:35 AM Changeset in webkit [161953] by
-
- 2 edits in trunk/Source/JavaScriptCore
Web Inspector: RemoteInspector::updateDebuggable may miss a push
https://bugs.webkit.org/show_bug.cgi?id=126965
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-14
Reviewed by Timothy Hatcher.
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::updateDebuggable):
Always push an update. If a debuggable went from allowed to
not allowed, we would have missed pushing an update.
Jan 13, 2014:
- 11:48 PM Changeset in webkit [161952] by
-
- 16 edits in trunk/LayoutTests
Make spelling tests added in r141354 to be able to run asynchronously
https://bugs.webkit.org/show_bug.cgi?id=126895
Reviewed by Ryosuke Niwa.
As we started running spelling tests asynchronously, invoke 'finishJSTest()'
when all operations are completed, for example, required spelling markers have appeared.
It might happen later then during 'initSpellTest' testing callback.
Due to the tests perform other checks that do not affect expectation order (selection,
context menu suggestion items), the asynchronous operations were pushed back to the end of
the tests to be sure that those won't break expectation order.
- editing/spelling/context-menu-suggestions-multiword-selection-expected.txt:
- editing/spelling/context-menu-suggestions-multiword-selection.html:
- editing/spelling/context-menu-suggestions-subword-selection-expected.txt:
- editing/spelling/context-menu-suggestions-subword-selection.html:
- editing/spelling/resources/util.js:
- editing/spelling/spelling-changed-text-expected.txt:
- editing/spelling/spelling-changed-text.html:
- editing/spelling/spelling-double-clicked-word-expected.txt:
- editing/spelling/spelling-double-clicked-word.html:
- editing/spelling/spelling-exactly-selected-word-expected.txt:
- editing/spelling/spelling-exactly-selected-word.html:
- editing/spelling/spelling-with-whitespace-selection-expected.txt:
- editing/spelling/spelling-with-whitespace-selection.html:
- editing/spelling/spelling-with-punctuation-selection-expected.txt:
- editing/spelling/spelling-with-punctuation-selection.html:
Additionally fix description format and get rid of context click, needless after r148282.
- 11:15 PM Changeset in webkit [161951] by
-
- 2 edits in trunk/Source/WebCore
iOS WebCore build fixes
Add WebKit and WebKit2 as allowable clients of WebCore.
- Configurations/WebCore.xcconfig:
- 11:02 PM Changeset in webkit [161950] by
-
- 17 edits in trunk/Source
iOS WebKit2 build fixes, part 1
- WebCore.xcodeproj/project.pbxproj:
Move some headers to 'private', from 'project'.
- Configurations/WebKit2.xcconfig:
- NetworkProcess/NetworkResourceLoader.cpp:
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/RemoteNetworkingContext.h:
- Shared/WebEventConversion.h:
- UIProcess/API/ios/WKGeolocationProviderIOS.mm:
- UIProcess/API/ios/WKInteractionView.mm:
(-[WKTextPosition isEqual:]):
- UIProcess/API/ios/WKViewIOS.mm: Renamed from Source/WebKit2/UIProcess/API/ios/WKView.mm.
- UIProcess/ios/WebPageProxyIOS.mm:
- UIProcess/ios/WebProcessProxyIOS.mm:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::elementDidFocus):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- 10:58 PM Changeset in webkit [161949] by
-
- 3 edits in trunk/Tools
Update the LLINT CLoop Bot build infrastructure
https://bugs.webkit.org/show_bug.cgi?id=126604
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileLLINTCLoop):
(RunLLINTCLoopTests):
(BuildAndTestLLINTCLoopFactory):
(BuildAndTestLLINTCLoopFactory.init):
- 10:54 PM Changeset in webkit [161948] by
-
- 4 edits in trunk
[EFL][WK2] Disable failing API tests
https://bugs.webkit.org/show_bug.cgi?id=126960
Reviewed by Gyuyoung Kim.
Source/WebKit2:
Disable color picker test until bug 119120 is resolved.
- UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:
(TEST_F):
Tools:
Disable WKViewUserViewportToContents test until bug 126261 is resolved.
- TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
(TestWebKitAPI::TEST):
- 10:06 PM Changeset in webkit [161947] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r161907.
http://trac.webkit.org/changeset/161907
https://bugs.webkit.org/show_bug.cgi?id=126963
fast/canvas/webgl/webgl-compressed-texture-size-limit.html
fails on many bots (Requested by ap on #webkit).
Source/WebCore:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateTexFuncLevel):
LayoutTests:
- fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils):
- fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Removed.
- fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Removed.
- 9:57 PM Changeset in webkit [161946] by
-
- 2 edits in trunk/LayoutTests
Layout Test plugins/plugin-document-load-prevented-userscript.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=126962
- platform/mac-wk2/TestExpectations: Marking as such.
- 9:53 PM Changeset in webkit [161945] by
-
- 11 edits3 adds in branches/jsCStack/Source/JavaScriptCore
FTL PutByVal should have a complete story for OOB
https://bugs.webkit.org/show_bug.cgi?id=126961
Not yet reviewed.
Previously, the DFG would handle OOB by just ignoring the store, while the FTL
would handle it by speculating. This blind speculation in the FTL caused many
recompiles in Octane/gbemu.
This patch makes both the DFG and FTL speculate on OOB, but we switch to ignoring
the store if we have a frequent exit site.
Speculating is slightly better because it allows us to hoist and fold the checks.
It also makes it easier to reason about the store (that is, we know that it must
have happened).
This also fixes the handling of FTL OSR exits in the profiler.
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine):
- dfg/DFGArrayMode.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::attemptToMakeGetArrayLength):
- dfg/DFGSSALoweringPhase.cpp:
(JSC::DFG::SSALoweringPhase::handleNode):
(JSC::DFG::SSALoweringPhase::lowerBoundsCheck):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- tests/stress/int16-put-by-val-in-and-out-of-bounds.js: Added.
(foo):
(test):
- tests/stress/int16-put-by-val-in-bounds-then-exit-out-of-bounds.js: Added.
(foo):
(test):
- tests/stress/int16-put-by-val-out-of-bounds-bounds-then-do-in-bounds.js: Added.
(foo):
(test):
- 9:16 PM Changeset in webkit [161944] by
-
- 4 edits in trunk/Source/WebCore
Fix typedef of DragDataRef from id back to id<NSDraggingInfo>
<http://webkit.org/b/126958>
<rdar://problem/14814649>
Reviewed by Mark Rowe.
- WebCore.exp.in: Export different symbols based on
has_feature(objc_protocol_qualifier_mangling) since clang
mangles the type differently with that change.
- platform/DragData.h:
- platform/mac/DragDataMac.mm:
(WebCore::DragData::DragData):
- Revert r154493 by switching back to id<NSDraggingInfo>.
- 9:07 PM Changeset in webkit [161943] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] ewk_view_page_contents_get() API test is failing
https://bugs.webkit.org/show_bug.cgi?id=126957
Reviewed by Gyuyoung Kim.
As the day in 'Date' field may be one digit or two digit,
the data length may also be varied by one byte.
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(EWK2ViewTest::PageContentsAsMHTMLCallback):
- 8:51 PM Changeset in webkit [161942] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
Gardening: fix bad merge of https://bugs.webkit.org/show_bug.cgi?id=126790
on top of https://bugs.webkit.org/show_bug.cgi?id=126932.
Not reviewed.
- llint/LowLevelInterpreter.asm:
- the 2 patches implemented the same change in callToJavaScriptPrologue() and callToJavaScriptEpilogue(), but svn merged the changes without reporting a conflict. The result is a redundant push of lr and pop of cfr. This is now fixed.
- 7:59 PM Changeset in webkit [161941] by
-
- 13 edits in trunk/Source
Unreviewed, rolling out r161939.
http://trac.webkit.org/changeset/161939
https://bugs.webkit.org/show_bug.cgi?id=126956
didn't work with mac, of course (Requested by thorton on
#webkit).
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit2:
- NetworkProcess/NetworkResourceLoader.cpp:
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/RemoteNetworkingContext.h:
- Shared/WebEventConversion.h:
- UIProcess/API/ios/WKGeolocationProviderIOS.mm:
- UIProcess/API/ios/WKInteractionView.mm:
(-[WKTextPosition isEqual:]):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- 7:52 PM Changeset in webkit [161940] by
-
- 2 edits in trunk/Source/WebKit2
Update WebPageProxyIOS's user agent string
https://bugs.webkit.org/show_bug.cgi?id=126933
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-13
Reviewed by Darin Adler.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::standardUserAgent):
Send a more reasonable user agent. The previous one was forcing
iOS 5.1's iPad user-agent.
- 7:35 PM Changeset in webkit [161939] by
-
- 13 edits in trunk/Source
iOS WebKit2 build fixes
- NetworkProcess/NetworkResourceLoader.cpp:
- NetworkProcess/NetworkResourceLoader.h:
Introduce/clarify some confusion about CFNETWORK vs. PLATFORM(IOS).
- NetworkProcess/RemoteNetworkingContext.h:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
Get rid of an override of something that doesn't exist anymore.
- WebKit2.xcodeproj/project.pbxproj:
Add some files. It's likely there are more missing, but this is a start.
- Shared/WebEventConversion.h:
- WebProcess/WebPage/WebPage.h:
Use WebKitAdditions.
- UIProcess/API/ios/WKGeolocationProviderIOS.mm:
Something bizarre is happening with internal deprecation warnings.
- UIProcess/API/ios/WKInteractionView.mm:
(-[WKTextPosition isEqual:]):
Fix a typo.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
Remove an override of something that doesn't exist anymore.
- WebCore.xcodeproj/project.pbxproj:
Make some headers private instead of project for WK2's use.
- 6:43 PM Changeset in webkit [161938] by
-
- 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog
Updated ChangeLog review status for patches which have been reviewed.
- 6:41 PM Changeset in webkit [161937] by
-
- 3 edits in trunk/Source/WebKit/mac
Fix the Mac build. WebViewPrivate.h declares quickLookContentForURL:
for iOS, but the implementation conditionalizes on USE(QUICK_LOOK),
which we are confused about.
- WebView/WebView.mm:
(-[WebView quickLookContentForURL:]):
- WebView/WebViewPrivate.h:
- 6:10 PM Changeset in webkit [161936] by
-
- 9 edits in trunk/Source
Source/WebCore: Make NetworkStateNotifier.h a private header, needed by iOS.
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit/mac: Fix the remaining compiler errors in iOS WK1.
- WebView/WebFrame.mm:
(vectorForDictationPhrasesArray): Need this function on iOS.
(-[WebFrame setSelectedDOMRange:affinity:closeTyping:]): We're already inside
a huge if PLATFORM(IOS) block.
(-[WebFrame resetTextAutosizingBeforeLayout]): Document now exposes RenderView.
- WebView/WebFrameInternal.h: Declare vectorForDictationPhrasesArray() (not a good place for it!)
- WebView/WebView.mm: #import cleanup for iOS.
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Declare autoStartRemoteInspector
here but this needs cleaning up (<rdar://problem/15810991>).
(-[WebView setHostApplicationBundleId:name:]): No [WebView sharedWebInspectorServer] any more.
(-[WebView _didCommitLoadForFrame:]): Ditto.
- WebView/WebViewData.h: Add allowsRemoteInspection.
- WebView/WebViewData.mm: Initialize allowsRemoteInspection
(-[WebViewPrivate init]):
- WebView/WebViewPrivate.h: Fumbled #ifdef.
- 6:02 PM Changeset in webkit [161935] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r161916.
http://trac.webkit.org/changeset/161916
https://bugs.webkit.org/show_bug.cgi?id=126952
it is a lie - still fails on some configs (Requested by dino
on #webkit).
- platform/mac/TestExpectations:
- 6:01 PM Changeset in webkit [161934] by
-
- 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog
Updated the ChangeLog review status for a few prior commits.
- 5:42 PM Changeset in webkit [161933] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Do not store reference variables as a pointer in private data structure
https://bugs.webkit.org/show_bug.cgi?id=126945
Reviewed by Gyuyoung Kim.
Remove pageSettings, mainFrame and storageSession variables from Ewk_View_Private_Data.
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(_ewk_view_smart_add):
(_ewk_view_smart_repaints_process):
(_ewk_view_smart_calculate):
(ewk_view_fixed_layout_size_set):
(ewk_view_fixed_layout_size_get):
(ewk_view_bg_color_set):
(ewk_view_setting_user_agent_set):
(ewk_view_setting_user_stylesheet_set):
(ewk_view_setting_auto_load_images_set):
(ewk_view_setting_auto_shrink_images_set):
(ewk_view_setting_enable_scripts_set):
(ewk_view_setting_enable_plugins_set):
(ewk_view_setting_enable_frame_flattening_set):
(ewk_view_setting_scripts_can_open_windows_set):
(ewk_view_setting_scripts_can_close_windows_set):
(ewk_view_setting_scripts_can_access_clipboard_set):
(ewk_view_setting_resizable_textareas_set):
(ewk_view_setting_private_browsing_set):
(ewk_view_setting_application_cache_set):
(ewk_view_setting_caret_browsing_set):
(ewk_view_setting_encoding_default_set):
(ewk_view_setting_encoding_detector_set):
(ewk_view_setting_enable_developer_extras_set):
(ewk_view_setting_font_minimum_size_set):
(ewk_view_setting_font_minimum_logical_size_set):
(ewk_view_setting_font_default_size_set):
(ewk_view_setting_font_monospace_size_set):
(ewk_view_font_family_name_set):
(ewk_view_setting_spatial_navigation_set):
(ewk_view_setting_local_storage_set):
(ewk_view_setting_page_cache_set):
(ewk_view_setting_local_storage_database_path_set):
(ewk_view_setting_minimum_timer_interval_set):
(ewk_view_setting_enable_webgl_set):
(ewk_view_setting_enable_hyperlink_auditing_set):
(ewk_view_setting_allow_universal_access_from_file_urls_set):
(ewk_view_setting_allow_file_access_from_file_urls_set):
(ewk_view_layout_if_needed_recursive):
(ewk_view_paint):
(ewk_view_paint_contents):
(ewk_view_js_object_add):
(ewk_view_page_rect_get):
(ewk_view_soup_session_get):
(ewk_view_soup_session_set):
(ewk_view_setting_enable_xss_auditor_set):
(ewk_view_setting_should_display_captions_set):
(ewk_view_setting_should_display_subtitles_set):
(ewk_view_setting_should_display_text_descriptions_set):
(ewk_view_setting_enable_fullscreen_set):
(ewk_view_setting_tiled_backing_store_enabled_set):
(ewk_view_setting_tiled_backing_store_enabled_get):
(ewk_view_tiled_backing_store_invalidate):
(EWKPrivate::storageSession):
- 5:37 PM Changeset in webkit [161932] by
-
- 5 edits in branches/safari-537.74-branch/Source
Versioning.
- 5:27 PM Changeset in webkit [161931] by
-
- 15 edits in trunk/Source
More work towards getting iOS WK1 building.
Source/WebCore:
Some more Private headers for iOS.
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit/ios:
- WebCoreSupport/WebFrameIOS.mm:
(-[WebFrame imageForNode:allowDownsampling:drawContentBehindTransparentNodes:]): Stub out this
function, since it should use recently-refactored node snapshotting code. Covered by <rdar://problem/15808709>.
Source/WebKit/mac:
- DOM/WebDOMOperations.mm: Need RenderObject.h.
- DOM/WebDOMOperationsPrivate.h:
- History/WebBackForwardList.mm: Need Foundation/NSGeometry.h for NSRect
(-[WebBackForwardList dictionaryRepresentation]): Fix array iteration to match
other code.
- Misc/WebIconDatabase.h: #ifdef out functions that return NSImages.
- Plugins/WebPluginController.mm: Need <WebCore/AudioSession.h>
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::transitionToCommittedForNewPage): Some new code to
handle the error case.
- WebView/WebFrameView.mm: Avoid including some headers which pull in AppKit classes.
- WebView/WebHTMLView.mm: Ditto.
(-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]): Handle
different return type of createDragImageForSelection().
- WebView/WebPolicyDelegatePrivate.h:
- WebView/WebPreferences.mm: <WebCore/AudioSession.h> and <AudioToolbox/AudioSession.h>
- 5:21 PM Changeset in webkit [161930] by
-
- 1 copy in tags/Safari-537.74.7
New Tag.
- 5:13 PM Changeset in webkit [161929] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build fix for Win64.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Corrected 64-bit linker symbols.
- 5:09 PM Changeset in webkit [161928] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Build Fix: Don't build the 'All-iOS' target on iOS. Just use 'All'.
- Makefile:
- 5:08 PM Changeset in webkit [161927] by
-
- 14 edits in branches/jsCStack/Source/JavaScriptCore
CStack: Fix 64-bit C Loop LLINT.
https://bugs.webkit.org/show_bug.cgi?id=126790.
Reviewed by Geoffrey Garen.
- Fixed miscellaneous bugs relevant for the C Loop LLINT (details below).
- Simplified CLoop::execute() by making it more emulate CPU calls as well. This is done by automatically synthesizing an opcode label at the return point after the call to JS code. The "lr" register (named after the ARM link register) will be set to that return opcode label before the call. The call itself is implemented as an opcode dispatch.
- heap/Heap.cpp:
(JSC::Heap::markRoots):
- Fixed typo: LLINT_CLOOP ==> LLINT_C_LOOP.
- interpreter/JSStack.cpp:
(JSC::JSStack::gatherConservativeRoots):
- Previously, we were declaring a span from baseOfStack() to topOfStack(). baseOfStack() points to the highest slot in the stack. topOfStack() points to the word below the lowest slot in the stack. The ConservativeRoots class will invert the high and low pointers to ensure that it iterates from low to high. However, with this span, the GC will miss not scan the highest slot in the stack, and will instead scan the slot below the stack which is technically outside the stack.
The span is now fixed to be from topOfStack() + 1 to highAddress().
highAddress() points at the slot above the highest slot in the stack.
This means GC will now correctly scan the stack from its lowest to its
highest slots (inclusive).
(JSC::JSStack::sanitizeStack):
- Similar to the gatherConservativeRoots() case, sanitizeStack() is nullifying a span of stack that starts at 2 past the lowest slot in the stack.
This is because topOfStack() points at the slot below the lowest slot
in the stack. m_lastStackTop() points to an old topOfStack() i.e. it
potentially points to a slot that is not in the region of memory
allocated for the stack.
We now add 1 to both of these values to ensure that we're zeroing a
region that is in the stack's allocated memory, and stop at the slot
(inclusive) just below the stack's current lowest used slot.
- interpreter/JSStack.h:
- interpreter/JSStackInlines.h:
- Made topOfStack() public because CLoop::execute() needs it.
- The LLINT assembly (in CLoop::execute()) now takes care of pushing and popping the stack. Hence, we no longer need JSStack's pushFrame, popFrame, and stack fence infrastruture which relies on pushFrame and popFrame. These are now removed.
- llint/LLIntOpcode.h:
- Added new pseudo opcodes:
- llint_return_to_host: this is the pseudo return address for returning to the host i.e. return from CLoop::execute().
- llint_cloop_did_return_from_js_X: these are synthesized by the cloop offlineasm as needed i.e. every time it needs to generate code for a cloopCallJSFunction "instruction". These are the opcodes that will serve as the return point that we store in lr and return to when we see a "ret" opcode.
While the offlineasm automatically generates these in LLIntAssembly.h,
we have to manually add the declaration of these opcodes here. If we end
up generating more or less in the future (due to changes in the LLINT
assembly code), then we'll get compiler errors that will tell us to
update this list.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::llint_stack_check_at_vm_entry):
- llint/LLIntSlowPaths.h:
- This slow path isn't needed for the non C loop build because the stack is finite sized and grows itself on access. For the C loop, we need this check function to give the JSStack a chance to grow the stack.
- llint/LowLevelInterpreter64.asm:
- Added call to llint_stack_check_at_vm_entry in doCallToJavaScript().
- Fixed up calls and stack adjustments.
- In makeHostFunctionCall(), the non C loop build will push lr and cfr when we call the host function. That's why we adjust the sp by 16 before the call. For the C loop build, we need to set the lr and cfr ourselves here.
- In nativeCallTrampoline(), unlike makeHostFunctionCall(), the return address and cfr has already been set in the frame. Hence, we didn't have to do anything extra. Also got rid of the distinct block for the C_LOOP and just reuse the block for ARM64 since it is exactly what the C_LOOP needs for the most part.
- llint/LowLevelInterpreter.asm:
- Added push/pop or lr and cfr as needed.
- In callTargetFunction(), make the C_LOOP use the same code as other targets except for the call instruction.
- Same for slowPathForCall().
- In prologue(), exclude the OSR check code for the C_LOOP build since it is not needed. Also added popping of cfr and lr since I'm working through this logic already.
- llint/LowLevelInterpreter.cpp:
(JSC::CLoopRegister::operator Register*):
(JSC::CLoop::execute):
- Added TRACE_OPCODE() for debugging use only.
- Simplified some CLoopRegister names.
- Initialize the needed registers and incoming arguments before entering the interpreter loop.
- Added llint_return_to_host as the exit opcode for returning from CLoop::execute(). We set it as the value for lr (the return address) before we enter the interpreter loop.
- Updated the getHostCallReturnValue opcode handler to match the current getHostCallReturnValue and getHostCallReturnValueWithExecState code in JITOperations.cpp.
- offlineasm/cloop.rb:
- Updated C loop register names.
- Added tracking of the number of cloop_did_return_from_js labels.
- Added push, pop, and change the implementation of the cloopCallJSFunction pseudo instruction to use synthesized cloop_did_return_from_js opcodes / labels as return addresses.
- runtime/Executable.cpp:
- Fix C loop build breaker by a prior patch.
- runtime/VM.cpp:
(JSC::VM::VM):
- Fixed typo: LLINT_CLOOP ==> LLINT_C_LOOP.
- 5:05 PM Changeset in webkit [161926] by
-
- 1 edit10 adds in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r161669.
- platform/efl/css3/masking/clip-path-circle-border-box-expected.png: Added.
- platform/efl/css3/masking/clip-path-circle-border-box-expected.txt: Added.
- platform/efl/css3/masking/clip-path-circle-bounding-box-expected.png: Added.
- platform/efl/css3/masking/clip-path-circle-bounding-box-expected.txt: Added.
- platform/efl/css3/masking/clip-path-circle-content-box-expected.png: Added.
- platform/efl/css3/masking/clip-path-circle-content-box-expected.txt: Added.
- platform/efl/css3/masking/clip-path-circle-margin-box-expected.png: Added.
- platform/efl/css3/masking/clip-path-circle-margin-box-expected.txt: Added.
- platform/efl/css3/masking/clip-path-circle-padding-box-expected.png: Added.
- platform/efl/css3/masking/clip-path-circle-padding-box-expected.txt: Added.
- 5:02 PM Changeset in webkit [161925] by
-
- 2 edits in trunk/Source/WebCore
Highlighting password field then making a Sticky Note via Safari Services exposes password
https://bugs.webkit.org/show_bug.cgi?id=126946
Reviewed by Enrica Casucci.
Using the Services menu has a slightly different codepath than Editor::copy() does. This
patch duplicates the canCopy() check that Editor::copy() does.
Testing is not possible because the Services menu is not accessible to our tests.
- editing/mac/EditorMac.mm:
(WebCore::Editor::stringSelectionForPasteboard):
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):
(WebCore::Editor::dataSelectionForPasteboard):
- 5:00 PM Changeset in webkit [161924] by
-
- 3 edits in trunk/Source/WebCore
[WebGL] Crash due to forceLostContext
https://bugs.webkit.org/show_bug.cgi?id=126947
Reviewed by Dean Jackson.
Covered by webgl/conformance/textures/origin-clean-conformance.html.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::isContextLost): Make const.
(WebCore::WebGLRenderingContext::platformLayer): Don't attempt to use
a lost context.
- html/canvas/WebGLRenderingContext.h: isContextLost should be const.
- 4:53 PM Changeset in webkit [161923] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaseline after r161696.
- platform/efl/css1/text_properties/word_spacing-expected.png:
- platform/efl/css1/text_properties/word_spacing-expected.txt:
- 4:43 PM Changeset in webkit [161922] by
-
- 11 edits in trunk
[CMake] Mark all dependency include paths and libraries as advanced variables
https://bugs.webkit.org/show_bug.cgi?id=126504
Reviewed by Daniel Bates.
.:
- Source/cmake/FindATK.cmake: Mark result variable as advanced.
- Source/cmake/FindCairo.cmake: Ditto.
- Source/cmake/FindEGL.cmake: Ditto.
- Source/cmake/FindEnchant.cmake: Ditto.
- Source/cmake/FindGLIB.cmake: Ditto.
- Source/cmake/FindGStreamer.cmake: Ditto.
- Source/cmake/FindHarfBuzz.cmake: Ditto.
- Source/cmake/FindLibSoup.cmake: Ditto.
Source/WebKit2:
- CMakeLists.txt: Mark the LIBRT_LIBRARIES variable as advanced.
- 4:42 PM Changeset in webkit [161921] by
-
- 2 edits in trunk
[GTK][CMake] Add a 'check' target
https://bugs.webkit.org/show_bug.cgi?id=126770
Reviewed by Daniel Bates.
- Source/PlatformGTK.cmake: Add a 'check' target that calls run-gtk-tests.
- 4:38 PM Changeset in webkit [161920] by
-
- 2 edits in trunk/Source/WebCore
[GTK][CMake] WebCorePlatform build can sometimes fail due to missing generated headers
https://bugs.webkit.org/show_bug.cgi?id=126911
Reviewed by Daniel Bates.
- PlatformGTK.cmake: Add an explicit dependency from WebCorePlatform to WebCore.
- 4:37 PM Changeset in webkit [161919] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][CMake] Circular dependency in generation of WebKitEnumTypes.h
https://bugs.webkit.org/show_bug.cgi?id=126912
Reviewed by Daniel Bates.
- PlatformGTK.cmake: Remove the circular dependency by generating WebKitEnumTypes.h with
all installed headers except for WebKitEnumTypes.h itself.
- 4:33 PM Changeset in webkit [161918] by
-
- 8 edits4 adds in trunk/Source/WebKit2
[iOS] Exclude shims and PluginProcess.app from the WebKit2 build
https://bugs.webkit.org/show_bug.cgi?id=126936
Reviewed by Daniel Bates.
- Configurations/All.xcconfig: Added. Excluded PluginProcess.app from
being copied into WebKit2.framework on iOS.
- Configurations/NetworkProcess.xcconfig: Excluded SecItemShim.dylib
from being copied into NetworkProcess.app on iOS.
- Configurations/PluginProcess.xcconfig: Excluded
PluginProcessShim.dylib from being copied into PluginProcess.app and
set SKIP_INSTALL to YES on iOS.
- Configurations/PluginProcessShim.xcconfig: Added. Linked the shim
against necessary frameworks on Mac.
- Configurations/SecItemShim.xcconfig: Ditto.
- Configurations/WebProcessShim.xcconfig: Ditto.
- Configurations/WebContentProcess.xcconfig: Excluded
WebProcessShim.dylib from being copied into WebProcess.app on iOS.
- PluginProcess/mac/PluginProcessShim.mm: Added #if !PLATFORM(IOS) guards.
- Shared/mac/CookieStorageShimLibrary.cpp: Ditto.
- WebProcess/mac/SecItemShimLibrary.mm: Ditto.
- WebKit2.xcodeproj/project.pbxproj: Removed Mac-only frameworks from
the shims' 'Link Binary with Libraries' build phases. Added new xcconfigs.
- 4:27 PM Changeset in webkit [161917] by
-
- 3 edits in trunk/Source/WebCore
Use the Selector Code Generator for resolving style
https://bugs.webkit.org/show_bug.cgi?id=126199
Reviewed by Ryosuke Niwa.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
- css/RuleSet.h:
- 4:14 PM Changeset in webkit [161916] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Unskipping WebGL 1.0.2/conformance/ogles/GL/build/build_009_to_016.html
It now passes.
- platform/mac/TestExpectations:
- 4:02 PM Changeset in webkit [161915] by
-
- 7 edits in trunk/Source/WebKit2
[EFL][WK2] Replace usage of DEFINE_STATIC_LOCAL with NeverDestroyed
https://bugs.webkit.org/show_bug.cgi?id=126882
Reviewed by Gyuyoung Kim.
- Shared/efl/ProcessExecutablePathEfl.cpp:
(WebKit::executablePathOfWebProcess):
(WebKit::executablePathOfPluginProcess):
(WebKit::executablePathOfNetworkProcess):
- UIProcess/API/efl/EwkView.cpp:
(wkPageToEvasObjectMap):
- UIProcess/API/efl/ewk_context.cpp:
(contextMap):
- UIProcess/API/efl/ewk_page_group.cpp:
(pageGroupMap):
- UIProcess/efl/TextCheckerClientEfl.cpp:
(TextCheckerClientEfl::instance):
- UIProcess/efl/TextCheckerClientEfl.h:
- 3:50 PM Changeset in webkit [161914] by
-
- 6 edits in trunk/Source/JavaScriptCore
Performance regression on dromaeo due to generational marking
https://bugs.webkit.org/show_bug.cgi?id=126901
Reviewed by Oliver Hunt.
We were seeing some performance regression with ENABLE_GGC == 0, so this patch
ifdefs out more things to get rid of the additional overhead.
- heap/Heap.cpp:
(JSC::Heap::markRoots):
(JSC::Heap::writeBarrier):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::clearMarks):
(JSC::MarkedBlock::clearMarksWithCollectionType):
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::resetAllocators):
- heap/MarkedSpace.h:
(JSC::MarkedSpace::didAllocateInBlock):
- heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::internalAppend):
(JSC::SlotVisitor::reportExtraMemoryUsage):
- 3:23 PM Changeset in webkit [161913] by
-
- 4 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Fix unwind on branch for X86-64
https://bugs.webkit.org/show_bug.cgi?id=126932
Reviewed by Geoffrey Garen.
Added code to push bp ; move sp, bp as the first instructions in callToJavaScript.
This complies with what happens at the top of most functions. This added push
is used to restore bp in the prologue. The values for the return PC and save BP in
the sentinel frame are only used for unwinding. Made similar mods to other platforms.
Added eh_frame directives to LLInt global labels to get unwinding through them working
as well.
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter.cpp:
- llint/LowLevelInterpreter64.asm:
- 3:03 PM Changeset in webkit [161912] by
-
- 3 edits in trunk/Source/WebKit/mac
[iOS] Remove duplicate inclusions of header WAKView.h
following <http://trac.webkit.org/changeset/161910>
- WebView/WebFrameView.h:
- WebView/WebHTMLView.h:
- 2:59 PM Changeset in webkit [161911] by
-
- 2 edits in trunk/Source/WebCore
Update the SelectorQuery code using compiled selector after r161196
https://bugs.webkit.org/show_bug.cgi?id=126860
Reviewed by Andreas Kling.
Update tree traversal code to the current traversal functions.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
(WebCore::SelectorDataList::executeCompiledSelectorCheckerWithContext):
- 2:55 PM Changeset in webkit [161910] by
-
- 18 edits in trunk/Source
Various iOS WebKit1 build fixes.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: iOS WebKit1 needs various
headers to be Private.
Source/WebKit/mac:
- Configurations/WebKit.xcconfig: Add more Mac-only files
to the excluded files list for iOS.
- DefaultDelegates/WebDefaultUIDelegate.m: Don't include WebJavaScriptTextInputPanel.h
on iOS
- History/WebHistory.h: NSCalendarDate doesn't exist on iOS.
- Misc/WebDownload.h: Need WAKAppKitStubs.h
- Misc/WebNSViewExtras.m: No WebNSPasteboardExtras on iOS
- Storage/WebDatabaseManagerClient.mm: Need DatabaseTracker.h, no harm
in including it for all platforms.
- WebCoreSupport/WebEditorClient.h: Remove useless comment.
- WebCoreSupport/WebEditorClient.mm:
(nsStringWithoutCopying): Moved
(WebEditorClient::checkTextOfParagraph): Modernized.
- WebInspector/WebNodeHighlightView.mm: Need FloatQuad.h.
- WebView/WebDataSource.mm: Need WebFrameViewInternal.h
- WebView/WebDocument.h: Needs WAKView.h.
- WebView/WebFrameView.h: Ditto.
- WebView/WebHTMLView.h: Ditto.
- WebView/WebPDFDocumentExtras.mm:
(allScriptsInPDFDocument): No PDFDocument on iOS.
- WebView/WebPolicyDelegate.h:
- WebView/WebView.h: Fix incorrect #if.
- 2:33 PM Changeset in webkit [161909] by
-
- 5 edits in trunk/Source/WebCore
Map RootInlineBox to containing region via bit+hashmap.
<https://webkit.org/b/126917>
The vas majority of RootInlineBox objects don't have a containing
RenderRegion, so let's store that in a bit+hashmap configuration
instead of having a dedicated pointer member for it.
148 kB progression on Membuster3.
Reviewed by Antti Koivisto.
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
Added m_hasContainingRegion bit.
(WebCore::containingRegionMap):
Global map between RootInlineBox and RenderRegion.
(WebCore::RootInlineBox::~RootInlineBox):
Remove self from aforementioned global map if needed.
(WebCore::RootInlineBox::paint):
Tweak a condition to avoid double hash lookup.
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::containingRegion):
(WebCore::RootInlineBox::clearContainingRegion):
(WebCore::RootInlineBox::setContainingRegion):
Store the containing region in a bit+hashmap.
- 2:29 PM Changeset in webkit [161908] by
-
- 9 edits in trunk/Source/WebKit
[iOS] More build fixes for WebKit
Source/WebKit:
Add iOS-specific logic to build phases: "Symlink WebKitPluginHost in to place" and "Migrate Headers".
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/Base.xcconfig: Removed extraneous definition of SUPPORTED_PLATFORMS.
- Configurations/WebKit.xcconfig: Exclude more Mac-specific files when building for iOS:
CarbonUtils.m, CarbonWindowAdapter.mm, CarbonWindowContentView.m, CarbonWindowFrame.m,
HIViewAdapter.m, HIWebView.mm, MailQuirksUserScript.js, OutlookQuirksUserScript.js,
PopupMenuMac.mm, SearchPopupMenuMac.mm, WebClipView.mm, WebInspectorClient.mm,
WebNetscapeContainerCheckContextInfo.mm, WebNetscapeContainerCheckPrivate.mm, WebRenderNode.mm,
WebStringTruncator.mm, and WebTextCompletionController.mm. I haven't verified the Mac-specific
nature of each of these files. We may be able to reduce this list upon further investigation.
- WebView/WebDocument.h: Include header <WebKit/WAKView.h> for definition of WAKView.
- WebView/WebFrameView.h: Ditto.
- WebView/WebUIDelegate.h: Ditto.
- WebView/WebView.h: Ditto.
- 2:27 PM Changeset in webkit [161907] by
-
- 4 edits2 adds in trunk
Source/WebCore: [WebGL] Invalid range checking in WebGLRenderingContext::validateTexFuncLevel
https://bugs.webkit.org/show_bug.cgi?id=126925
Reviewed by Dean Jackson.
Added fast/canvas/webgl/webgl-compressed-texture-size-limit.html.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateTexFuncLevel): Avoid off-by-one error
LayoutTests: [WebGL] Invalid range checking in WebGLRenderContext::validateTexFunctionLevel
https://bugs.webkit.org/show_bug.cgi?id=126925
Reviewed by Dean Jackson.
- fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils): Add missing 'waitForComposite' implementatino.
- fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Added.
- fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Added.
- 2:20 PM Changeset in webkit [161906] by
-
- 88 edits6 adds in trunk/LayoutTests
Update Mountain Lion test results for subpixel layout chanegs.
Patch by Zalan Bujtas.
- platform/mac-mountainlion/compositing: Added.
- platform/mac-mountainlion/compositing/contents-opaque: Added.
- platform/mac-mountainlion/compositing/contents-opaque/control-layer-expected.txt: Added.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-23-expected.txt:
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-24-expected.txt:
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-68-expected.txt:
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-69-expected.txt:
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-23-expected.txt:
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-24-expected.txt:
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-68-expected.txt:
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-69-expected.txt:
- platform/mac-mountainlion/editing/selection/3690703-2-expected.txt:
- platform/mac-mountainlion/editing/selection/3690703-expected.txt:
- platform/mac-mountainlion/editing/selection/3690719-expected.txt:
- platform/mac-mountainlion/fast/block/margin-collapse/103-expected.txt:
- platform/mac-mountainlion/fast/css/continuationCrash-expected.txt:
- platform/mac-mountainlion/fast/css/css2-system-fonts-expected.txt:
- platform/mac-mountainlion/fast/css/margin-top-bottom-dynamic-expected.txt: Added.
- platform/mac-mountainlion/fast/css/text-overflow-input-expected.txt:
- platform/mac-mountainlion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
- platform/mac-mountainlion/fast/forms/basic-inputs-expected.txt:
- platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt:
- platform/mac-mountainlion/fast/forms/basic-textareas-quirks-expected.txt:
- platform/mac-mountainlion/fast/forms/box-shadow-override-expected.txt:
- platform/mac-mountainlion/fast/forms/button-cannot-be-nested-expected.txt: Added.
- platform/mac-mountainlion/fast/forms/button-positioned-expected.txt:
- platform/mac-mountainlion/fast/forms/button-sizes-expected.txt:
- platform/mac-mountainlion/fast/forms/button-style-color-expected.txt:
- platform/mac-mountainlion/fast/forms/button-table-styles-expected.txt:
- platform/mac-mountainlion/fast/forms/button-text-transform-expected.txt:
- platform/mac-mountainlion/fast/forms/button-white-space-expected.txt:
- platform/mac-mountainlion/fast/forms/control-restrict-line-height-expected.txt:
- platform/mac-mountainlion/fast/forms/fieldset-align-expected.txt:
- platform/mac-mountainlion/fast/forms/file/input-file-re-render-expected.txt:
- platform/mac-mountainlion/fast/forms/form-element-geometry-expected.txt:
- platform/mac-mountainlion/fast/forms/input-appearance-height-expected.txt:
- platform/mac-mountainlion/fast/forms/input-button-sizes-expected.txt:
- platform/mac-mountainlion/fast/forms/input-disabled-color-expected.txt:
- platform/mac-mountainlion/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/mac-mountainlion/fast/forms/input-readonly-dimmed-expected.txt:
- platform/mac-mountainlion/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/mac-mountainlion/fast/forms/input-value-expected.txt:
- platform/mac-mountainlion/fast/forms/listbox-hit-test-zoomed-expected.txt:
- platform/mac-mountainlion/fast/forms/minWidthPercent-expected.txt:
- platform/mac-mountainlion/fast/forms/search-rtl-expected.txt:
- platform/mac-mountainlion/fast/forms/search-vertical-alignment-expected.txt:
- platform/mac-mountainlion/fast/forms/searchfield-heights-expected.txt:
- platform/mac-mountainlion/fast/forms/select-baseline-expected.txt: Added.
- platform/mac-mountainlion/fast/forms/textAreaLineHeight-expected.txt:
- platform/mac-mountainlion/fast/forms/validation-message-appearance-expected.txt:
- platform/mac-mountainlion/fast/html/details-no-summary4-expected.txt:
- platform/mac-mountainlion/fast/html/details-open-javascript-expected.txt:
- platform/mac-mountainlion/fast/html/details-open2-expected.txt:
- platform/mac-mountainlion/fast/html/details-open4-expected.txt:
- platform/mac-mountainlion/fast/html/details-replace-summary-child-expected.txt:
- platform/mac-mountainlion/fast/html/details-replace-text-expected.txt:
- platform/mac-mountainlion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt:
- platform/mac-mountainlion/fast/text/textIteratorNilRenderer-expected.txt:
- platform/mac-mountainlion/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/mac-mountainlion/svg/custom/inline-svg-in-xhtml-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug1188-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug138725-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug18359-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug24200-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug28928-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug30692-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug33855-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug46368-2-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug51037-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug51727-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug52505-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug59354-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug7342-expected.txt:
- platform/mac-mountainlion/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/mac-mountainlion/tables/mozilla/core/margins-expected.txt:
- platform/mac-mountainlion/tables/mozilla/dom/tableDom-expected.txt:
- platform/mac-mountainlion/tables/mozilla/other/move_row-expected.txt:
- platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
- platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
- platform/mac-mountainlion/transforms/2d/zoom-menulist-expected.txt:
- 2:02 PM Changeset in webkit [161905] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Fix up WebKit build phases
Add iOS-specific logic to build phrases "Generate 64-bit Export File" and "Migrate Headers".
- WebKit.xcodeproj/project.pbxproj:
- 2:01 PM Changeset in webkit [161904] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Fix up WebKit build phases
Add iOS-specific logic to build phrases "Generate 64-bit Export File" and "Migrate Headers".
- WebKit.xcodeproj/project.pbxproj:
- 12:56 PM Changeset in webkit [161903] by
-
- 2 edits in trunk/Source/WebCore
Add uint8_t specialization for WebCore::writeLittleEndian()
https://bugs.webkit.org/show_bug.cgi?id=126924
Reviewed by Darin Adler.
Specialize WebCore::writeLittleEndian() for datatype uint8_t so as to avoid
a compiler warning when right shifting a uint8_t by 8 because the result of
such a computation is undefined.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::writeLittleEndian<uint8_t>): Added.
- 12:54 PM Changeset in webkit [161902] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing
exports needed for Windows build after r161899.
- 12:21 PM Changeset in webkit [161901] by
-
- 2 edits in trunk/Source/WebCore
r161638 broke the Windows build
https://bugs.webkit.org/show_bug.cgi?id=126916
- DerivedSources.make:
- 12:10 PM Changeset in webkit [161900] by
-
- 2 edits in trunk/Source/JavaScriptCore
Web Inspector: protocol generator should support integer-typed declarations
https://bugs.webkit.org/show_bug.cgi?id=126828
Reviewed by Joseph Pecoraro.
Add new binding classes for parameter/ad-hoc and normal integer type declarations.
- inspector/scripts/CodeGeneratorInspector.py:
(TypeBindings.create_type_declaration_):
(TypeBindings.create_type_declaration_.PlainInteger):
(TypeBindings.create_type_declaration_.PlainInteger.resolve_inner):
(TypeBindings.create_type_declaration_.PlainInteger.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.PlainInteger.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.PlainInteger.get_code_generator):
(TypeBindings.create_type_declaration_.PlainInteger.get_validator_call_text):
(TypeBindings.create_type_declaration_.PlainInteger.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.PlainInteger.get_type_model):
(TypeBindings.create_type_declaration_.PlainInteger.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.PlainInteger.get_array_item_c_type_text):
(TypeBindings.create_type_declaration_.TypedefInteger):
(TypeBindings.create_type_declaration_.TypedefInteger.resolve_inner):
(TypeBindings.create_type_declaration_.TypedefInteger.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.TypedefInteger.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.generate_type_builder.int):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.register_use):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.get_generate_pass_id):
(TypeBindings.create_type_declaration_.TypedefInteger.get_validator_call_text):
(TypeBindings.create_type_declaration_.TypedefInteger.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.TypedefInteger.get_type_model):
(TypeBindings.create_type_declaration_.TypedefInteger.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.TypedefInteger.get_array_item_c_type_text):
- 11:42 AM Changeset in webkit [161899] by
-
- 18 edits6 adds in trunk
Allow MediaSessionManager to restrict media playback
https://bugs.webkit.org/show_bug.cgi?id=126780
Reviewed by Jer Noble.
Source/WebCore:
Test: media/video-concurrent-playback.html
- WebCore.exp.in: Export functions needed by Internals.
Add HTMLMediaSession.
- WebCore.xcodeproj/project.pbxproj:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Add a media session object to manage HTMLMediaElement restrictions.
- html/HTMLMediaSession.cpp: Added.
- html/HTMLMediaSession.h: Added.
Move media restriction management to a MediaSession.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Use the media session to manage restrictions.
(WebCore::HTMLMediaElement::parseAttribute): Ditto.
(WebCore::HTMLMediaElement::insertedInto): Ditto.
(WebCore::HTMLMediaElement::parseAttribute): Ditto.
(WebCore::HTMLMediaElement::loadInternal): Ditto.
(WebCore::HTMLMediaElement::loadResource): Ditto.
(WebCore::HTMLMediaElement::setReadyState): Ditto.
(WebCore::HTMLMediaElement::autoplay): Ditto.
(WebCore::HTMLMediaElement::play): Ditto.
(WebCore::HTMLMediaElement::pause): Ditto
(WebCore::HTMLMediaElement::pauseInternal): Ditto
(WebCore::HTMLMediaElement::suspend): Ditto
(WebCore::HTMLMediaElement::resume): Ditto.
(WebCore::HTMLMediaElement::updatePlayState): Tell media session playback is about to start.
(WebCore::HTMLMediaElement::deliverNotification): Ditto.
(WebCore::HTMLMediaElement::webkitShowPlaybackTargetPicker): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerIsFullscreenPermitted): Ditto.
(WebCore::HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture): Ditto.
(WebCore::HTMLMediaElement::pausePlayback): New, allows the media session to pause playback.
- html/HTMLMediaElement.h:
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::webkitEnterFullscreen): Use the media session to manage restrictions.
- platform/audio/MediaSession.cpp:
(WebCore::MediaSession::beginInterruption): Add logging.
(WebCore::MediaSession::endInterruption): Ditto.
(WebCore::MediaSession::pauseSession): New, allows the session manager to pause playback.
- platform/audio/MediaSession.h:
Add per-media type restrictions.
- platform/audio/MediaSessionManager.cpp:
(WebCore::MediaSessionManager::MediaSessionManager): Initialize restrictions.
(WebCore::MediaSessionManager::addRestriction): New.
(WebCore::MediaSessionManager::removeRestriction): New.
(WebCore::MediaSessionManager::restrictions): New.
(WebCore::MediaSessionManager::sessionWillBeginPlayback): New. If only one session if the same
type is allowed to play, pause all others.
- platform/audio/MediaSessionManager.h:
- platform/audio/ios/MediaSessionManagerIOS.h: Added.
- platform/audio/ios/MediaSessionManagerIOS.mm: Added.
(WebCore::MediaSessionManager::sharedManager):
(WebCore::m_objcObserver):
(-[WebAVAudioSessionHelper initWithCallback:]):
(-[WebAVAudioSessionHelper dealloc]):
(-[WebAVAudioSessionHelper interruption:]):
- platform/audio/mac/AudioDestinationMac.h: Add pausePlayback.
Allow tests to set media session restrictions.
- testing/Internals.cpp:
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- media/video-concurrent-playback-expected.txt: Added.
- media/video-concurrent-playback.html: Added.
- 11:34 AM Changeset in webkit [161898] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Mac WK2 gardering after r161882.
- platform/mac-wk2/fast/dynamic/012-expected.txt:
- 11:32 AM Changeset in webkit [161897] by
-
- 2 edits in trunk/Source/WebKit/mac
Include WAKAppKitStubs.h to get NSSelectionAffinity.
- WebView/WebEditingDelegate.h:
- 11:17 AM Changeset in webkit [161896] by
-
- 2 edits in trunk/Source/WebCore
Fix the build more.
- xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent):
- 11:13 AM Changeset in webkit [161895] by
-
- 2 edits in trunk/Source/WebKit/mac
DOMTouch* etc should not be public headers on iOS.
- MigrateHeaders.make:
- 11:11 AM Changeset in webkit [161894] by
-
- 2 edits in trunk/Source/WebCore
Fix the build.
- xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent):
- 11:07 AM Changeset in webkit [161893] by
-
- 2 edits in trunk/Source/WebInspectorUI
Snap time dividers to nearest numbers instead of just dividing the time span into max density slices.
https://bugs.webkit.org/show_bug.cgi?id=125081
Reviewed by Joseph Pecoraro.
- UserInterface/TimelineDecorations.js:
(WebInspector.TimelineDecorations.prototype.updateHeaderTimes): Snap the time slice to a nearest number.
(WebInspector.TimelineDecorations.prototype.updateEventMarkers): Rename boundarySpan to timeSpan.
- 10:46 AM Changeset in webkit [161892] by
-
- 2 edits1 move in trunk/Source/WebCore
Fix copy of SystemMemory.h in iOS WebKit build.
Move SystemMemory.h from platform/SystemMemory.h to platform/ios/SystemMemory.h.
Add it to the project file.
Make it a Private header.
Add PLATFORM(IOS) #idfefs around its contents.
- WebCore.xcodeproj/project.pbxproj:
- platform/ios/SystemMemory.h: Renamed from Source/WebCore/platform/SystemMemory.h.
- 10:41 AM Changeset in webkit [161891] by
-
- 14 edits in trunk
Dispatch a progress event before dispatching abort, error or timeout event
https://bugs.webkit.org/show_bug.cgi?id=126575
Source/WebCore:
Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-13
Reviewed by Alexey Proskuryakov.
Added sending of progress event after readystatechange event (switching to DONE state) in case of abort, error or timeout.
Fixed assertions in XMLHttpRequestProgressEventThrottle and XMLHttpRequestUpload.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::dispatchErrorEvents): added sending of progress event before the specific error event
- xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): fixed assertion
- xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::dispatchProgressEvent): fixed assertion
LayoutTests:
Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-13
Reviewed by Alexey Proskuryakov.
Updated onloadend-event-after-abort.html and onloadend-event-after-error.html to check for progress event.
Fixed the other tests to cope with additional progress event.
- http/tests/xmlhttprequest/onabort-progressevent-attributes.html:
- http/tests/xmlhttprequest/onloadend-event-after-abort-expected.txt:
- http/tests/xmlhttprequest/onloadend-event-after-abort.html:
- http/tests/xmlhttprequest/onloadend-event-after-error-expected.txt:
- http/tests/xmlhttprequest/onloadend-event-after-error.html:
- http/tests/xmlhttprequest/simple-cross-origin-progress-events-expected.txt:
- http/tests/xmlhttprequest/simple-cross-origin-progress-events.html:
- http/tests/xmlhttprequest/upload-onloadend-event-after-abort.html:
- http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events-expected.txt:
- 10:25 AM Changeset in webkit [161890] by
-
- 25 edits2 adds in trunk/Source
[SOUP] Add SoupNetworkSession class to wrap a SoupSession
https://bugs.webkit.org/show_bug.cgi?id=126813
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Add SoupNetworkSession class that wraps a SoupSession and move all
the code related to the SoupSession from ResourceHandle to
SoupNetworkSession, including the static methods to get the
default session and create testing and private sessions.
- GNUmakefile.list.am: Add new files to compilation.
- PlatformEfl.cmake: Ditto.
- PlatformGTK.cmake: Ditto.
- platform/network/NetworkStorageSession.h: Use SoupNetworkSession
instead of SoupSession.
- platform/network/ResourceHandle.h:
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookieJarForSession): Use SoupNetworkSession to get the
SoupSession.
- platform/network/soup/DNSSoup.cpp:
(WebCore::DNSResolveQueue::platformResolve): Ditto.
- platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::NetworkStorageSession): Use
SoupNetworkSession instead of SoupSession.
(WebCore::NetworkStorageSession::~NetworkStorageSession):
(WebCore::NetworkStorageSession::defaultStorageSession): Create a
NetworkStorageSession with a NULL SoupNetworkSession which means
that the default SoupNetworkSession will be used.
(WebCore::NetworkStorageSession::createPrivateBrowsingSession):
Call SoupNetworkSession::createPrivateBrowsingSession() to create
the private session.
(WebCore::NetworkStorageSession::switchToNewTestingSession): Call
SoupNetworkSession::createTestingSession() to create the testing
session.
(WebCore::NetworkStorageSession::soupNetworkSession): Return the
SoupNetworkSession or the default one.
(WebCore::NetworkStorageSession::setSoupNetworkSession): Set a new
SoupNetworkSession.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sessionFromContext): Use SoupNetworkSession to get the
SoupSession.
(WebCore::ResourceHandleInternal::soupSession): Simply call
sessionFromContext(), since ensureSessionIsInitialized() is no
longer needed, because the SoupSession are now initialized in the
SoupNetworkSession constructor.
(WebCore::ResourceHandle::didStartRequest): Function to notify the
ResourceHandle that current request has just started for web timing.
- platform/network/soup/SoupNetworkSession.cpp: Added.
(WebCore::soupLogPrinter): Logger callback.
(WebCore::SoupNetworkSession::defaultSession): Return a reference
to the default SoupNetworkSession.
(WebCore::SoupNetworkSession::createPrivateBrowsingSession):
Create a new private session.
(WebCore::SoupNetworkSession::createTestingSession): Create a new
testing session.
(WebCore::SoupNetworkSession::createForSoupSession): Create a new
SoupNetworkSession for the given SoupSession.
(WebCore::authenticateCallback): Callback emitted by the
SoupSession when the request needs authentication.
(WebCore::requestStartedCallback): Callback emitted by the
SoupSession when as request has just started.
(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::~SoupNetworkSession):
(WebCore::SoupNetworkSession::setupLogger): Helper private
function to setup the logger.
(WebCore::SoupNetworkSession::setCookieJar): Set a new CookieJar
in the session replacing the existing one.
(WebCore::SoupNetworkSession::cookieJar): Return the current
CookieJar of the session.
(WebCore::SoupNetworkSession::setCache): Set a disk cache.
(WebCore::SoupNetworkSession::cache): Return the current disk cache.
(WebCore::SoupNetworkSession::setSSLPolicy): Set the SSL policy.
(WebCore::SoupNetworkSession::sslPolicy): Get the current SSL policy.
(WebCore::SoupNetworkSession::setHTTPProxy): Set the HTTP proxy.
(WebCore::SoupNetworkSession::httpProxy): Get the current HTTP proxy.
(WebCore::SoupNetworkSession::setupHTTPProxyFromEnvironment): Set
the HTTP proxy using the environment variables.
(WebCore::buildAcceptLanguages): Helper function build the accept
language string in the format expected by soup (RFC 2616).
(WebCore::SoupNetworkSession::setAcceptLanguages): Set the accept
language for the given list of languages.
- platform/network/soup/SoupNetworkSession.h: Added.
(WebCore::SoupNetworkSession::soupSession): Return the SoupSession.
Source/WebKit/efl:
Use the new SoupNetworkSession API.
- ewk/ewk_cookies.cpp:
(ewk_cookies_file_set):
- ewk/ewk_main.cpp:
(_ewk_init_body):
- ewk/ewk_network.cpp:
(ewk_network_proxy_uri_set):
(ewk_network_proxy_uri_get):
(ewk_network_tls_certificate_check_get):
(ewk_network_tls_certificate_check_set):
(ewk_network_tls_ca_certificates_path_get):
(ewk_network_tls_ca_certificates_path_set):
(ewk_network_default_soup_session_get):
- ewk/ewk_view.cpp:
(ewk_view_soup_session_get):
(ewk_view_soup_session_set):
Source/WebKit/gtk:
- webkit/webkitglobals.cpp:
(webkit_get_default_session): Use the new SoupNetworkSession API
to get the default SoupSession
Source/WebKit2:
Use the new SoupNetworkSession API.
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::platformSetCacheModel):
(WebKit::NetworkProcess::clearCacheForAllOrigins):
- NetworkProcess/unix/NetworkProcessMainUnix.cpp:
(WebKit::NetworkProcessMain):
- WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:
(WebKit::WebCookieManager::setCookiePersistentStorage):
- WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformClearResourceCaches):
(WebKit::setSoupSessionAcceptLanguage):
(WebKit::WebProcess::platformInitializeWebProcess):
- WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestManager::registerURIScheme):
- 10:21 AM Changeset in webkit [161889] by
-
- 8 edits in trunk
[WebGL] Error messages should use source code labels, not internal mangled symbols.
https://bugs.webkit.org/show_bug.cgi?id=126832
Reviewed by Dean Jackson.
Source/WebCore:
Revised fast/canvas/webgl/glsl-conformance.html.
- platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::getSymbolInfo): Correct missing 'break'.
(WebCore::ANGLEWebKitBridge::compileShaderSource): Call 'getSymbolInfo'
for SH_VARYINGS.
- platform/graphics/GraphicsContext3D.h: Add new declarations.
- platform/graphics/filters/CustomFilterValidatedProgram.cpp: Add case
for SHADER_SYMBOL_TYPE_VARYING. This is a no-op to match existing
behavior.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::compileShader): Demangle log output.
(WebCore::GraphicsContext3D::mappedSymbolName): Added.
(WebCore::GraphicsContext3D::getUnmangledInfoLog): Added.
(WebCore::GraphicsContext3D::getProgramInfoLog): Demangle log output.
(WebCore::GraphicsContext3D::getShaderInfoLog): Demangle log output.
LayoutTests:
- fast/canvas/webgl/glsl-conformance.html: Add log to program output
showing error message to confirm proper labels are being used.
- fast/canvas/webgl/glsl-conformance-expected.txt: updated.
- 10:20 AM Changeset in webkit [161888] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Include RenderElement.h to fix BaseChooserOnlyDateAndTimeInputType.cpp
Fixes the following build failure:
Undefined symbols for architecture x86_64:
"ZNK7WebCore13ContainerNode8rendererEv", referenced from:
ZN7WebCore35BaseChooserOnlyDateAndTimeInputType22handleDOMActivateEventEPNS_5EventE in BaseChooserOnlyDateAndTimeInputType.o
- html/BaseChooserOnlyDateAndTimeInputType.cpp: Include
RenderElement.h.
- 10:20 AM Changeset in webkit [161887] by
-
- 4 edits in trunk/Source/WebKit
[iOS] Build Fix: switch back to calling postprocess-headers.sh
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- postprocess-headers.sh:
- 9:46 AM Changeset in webkit [161886] by
-
- 4 edits in trunk/Source/WTF
Move another deprecated symbol to DeprecatedSymbolsUsedBySafari.mm
https://bugs.webkit.org/show_bug.cgi?id=126909
Reviewed by Ryosuke Niwa.
- wtf/MainThread.cpp:
- wtf/MainThread.h:
- wtf/mac/DeprecatedSymbolsUsedBySafari.mm:
(WTF::callOnMainThread):
- 9:34 AM Changeset in webkit [161885] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Build Fix: copy iOS-specific generated headers
- Configurations/WebCore.xcconfig: Excluded DOMTouch* and DOMGesture* headers on Mac.
- WebCore.xcodeproj/project.pbxproj:
- 9:24 AM Changeset in webkit [161884] by
-
- 1225 edits1 copy29 adds2 deletes in trunk/LayoutTests
Unreviewed MAC gardening. Rebaselining after subpixel layout is enabled (r161882).
- css3/background/background-repeat-space-content-expected.html:
- css3/background/background-repeat-space-padding-expected.html:
- css3/masking/mask-repeat-space-content-expected.html:
- css3/masking/mask-repeat-space-padding-expected.html:
- fast/regions/auto-size/autoheight-correct-region-for-lines-2.html:
- fast/regions/overflow-region-transform.html:
- platform/mac/TestExpectations:
- platform/mac/accessibility/image-link-expected.txt:
- platform/mac/accessibility/internal-link-anchors2-expected.txt:
- platform/mac/accessibility/svg-bounds-expected.txt:
- platform/mac/accessibility/svg-remote-element-expected.txt:
- platform/mac/accessibility/table-attributes-expected.txt:
- platform/mac/accessibility/table-cell-spans-expected.txt:
- platform/mac/accessibility/table-cells-expected.txt:
- platform/mac/accessibility/table-detection-expected.txt:
- platform/mac/accessibility/table-sections-expected.txt:
- platform/mac/compositing/contents-opaque/control-layer-expected.txt: Added.
- platform/mac/compositing/direct-image-compositing-expected.txt:
- platform/mac/compositing/layer-creation/overlap-animation-container-expected.txt:
- platform/mac/compositing/overflow/theme-affects-visual-overflow-expected.txt:
- platform/mac/compositing/shadows/shadow-drawing-expected.txt:
- platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/mac/css1/basic/inheritance-expected.txt:
- platform/mac/css1/box_properties/acid_test-expected.txt:
- platform/mac/css1/box_properties/clear_float-expected.txt:
- platform/mac/css1/box_properties/float_on_text_elements-expected.txt:
- platform/mac/css1/box_properties/margin-expected.txt:
- platform/mac/css1/box_properties/margin_bottom-expected.txt:
- platform/mac/css1/box_properties/margin_right-expected.txt:
- platform/mac/css1/box_properties/margin_top-expected.txt:
- platform/mac/css1/box_properties/padding-expected.txt:
- platform/mac/css1/box_properties/padding_bottom-expected.txt:
- platform/mac/css1/box_properties/padding_left-expected.txt:
- platform/mac/css1/box_properties/padding_right-expected.txt:
- platform/mac/css1/box_properties/padding_top-expected.txt:
- platform/mac/css1/box_properties/width-expected.txt:
- platform/mac/css1/color_and_background/background_attachment-expected.txt:
- platform/mac/css1/font_properties/font-expected.txt:
- platform/mac/css1/font_properties/font_size-expected.txt:
- platform/mac/css1/font_properties/font_weight-expected.txt:
- platform/mac/css1/formatting_model/floating_elements-expected.txt:
- platform/mac/css1/formatting_model/horizontal_formatting-expected.txt:
- platform/mac/css1/formatting_model/inline_elements-expected.txt:
- platform/mac/css1/formatting_model/replaced_elements-expected.txt:
- platform/mac/css1/formatting_model/vertical_formatting-expected.txt:
- platform/mac/css1/text_properties/text_indent-expected.txt:
- platform/mac/css1/text_properties/vertical_align-expected.txt:
- platform/mac/css1/units/percentage_units-expected.txt:
- platform/mac/css2.1/20110323/block-replaced-width-001-expected.txt:
- platform/mac/css2.1/20110323/floating-replaced-height-008-expected.txt:
- platform/mac/css2.1/20110323/inline-block-replaced-height-008-expected.txt:
- platform/mac/css2.1/20110323/inline-replaced-height-008-expected.txt:
- platform/mac/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
- platform/mac/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
- platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/mac/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
- platform/mac/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
- platform/mac/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
- platform/mac/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
- platform/mac/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
- platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
- platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
- platform/mac/css2.1/t1002-c5523-width-02-b-g-expected.txt:
- platform/mac/css2.1/t100801-c544-valgn-00-a-ag-expected.txt:
- platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.txt:
- platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
- platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.txt:
- platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.txt:
- platform/mac/css2.1/t1506-c525-font-wt-00-b-expected.txt:
- platform/mac/css2.1/t1508-c527-font-09-b-expected.txt:
- platform/mac/css2.1/t1602-c43-center-00-d-ag-expected.txt:
- platform/mac/css3/flexbox/flexbox-baseline-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-25-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-70-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-25-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-70-expected.txt:
- platform/mac/css3/unicode-bidi-isolate-basic-expected.txt:
- platform/mac/editing/inserting/before-after-input-element-expected.txt:
- platform/mac/editing/inserting/editing-empty-divs-expected.txt:
- platform/mac/editing/pasteboard/4806874-expected.txt:
- platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
- platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/mac/editing/pasteboard/input-field-1-expected.txt:
- platform/mac/editing/selection/3690703-2-expected.txt:
- platform/mac/editing/selection/3690703-expected.txt:
- platform/mac/editing/selection/3690719-expected.txt:
- platform/mac/editing/selection/4397952-expected.txt:
- platform/mac/editing/selection/4895428-3-expected.txt:
- platform/mac/editing/selection/4975120-expected.txt:
- platform/mac/editing/selection/5240265-expected.txt:
- platform/mac/editing/selection/5354455-2-expected.txt:
- platform/mac/editing/selection/caret-ltr-2-expected.txt:
- platform/mac/editing/selection/caret-ltr-2-left-expected.txt:
- platform/mac/editing/selection/caret-ltr-expected.txt:
- platform/mac/editing/selection/caret-ltr-right-expected.txt:
- platform/mac/editing/selection/caret-rtl-2-expected.txt:
- platform/mac/editing/selection/caret-rtl-2-left-expected.txt:
- platform/mac/editing/selection/caret-rtl-expected.txt:
- platform/mac/editing/selection/caret-rtl-right-expected.txt:
- platform/mac/editing/selection/collapse-selection-in-bidi-expected.txt:
- platform/mac/editing/selection/drag-select-1-expected.txt:
- platform/mac/editing/selection/drag-start-event-client-x-y-expected.txt:
- platform/mac/editing/selection/mixed-editability-10-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-2-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-3-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/mac/editing/selection/select-text-overflow-ellipsis-expected.txt:
- platform/mac/editing/selection/selection-button-text-expected.txt:
- platform/mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
- platform/mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
- platform/mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
- platform/mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
- platform/mac/fast/backgrounds/background-inherit-color-bug-expected.txt:
- platform/mac/fast/backgrounds/background-position-parsing-expected.txt:
- platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt:
- platform/mac/fast/block/basic/001-expected.txt:
- platform/mac/fast/block/basic/011-expected.txt:
- platform/mac/fast/block/basic/014-expected.txt:
- platform/mac/fast/block/basic/015-expected.txt:
- platform/mac/fast/block/basic/016-expected.txt:
- platform/mac/fast/block/basic/019-expected.txt:
- platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
- platform/mac/fast/block/float/013-expected.txt:
- platform/mac/fast/block/float/025-expected.txt:
- platform/mac/fast/block/float/026-expected.txt:
- platform/mac/fast/block/float/027-expected.txt:
- platform/mac/fast/block/float/028-expected.txt:
- platform/mac/fast/block/float/032-expected.txt:
- platform/mac/fast/block/float/centered-float-avoidance-complexity-expected.txt:
- platform/mac/fast/block/float/float-avoidance-expected.txt:
- platform/mac/fast/block/float/float-in-float-painting-expected.txt:
- platform/mac/fast/block/float/nopaint-after-layer-destruction2-expected.txt:
- platform/mac/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
- platform/mac/fast/block/margin-collapse/100-expected.txt:
- platform/mac/fast/block/margin-collapse/103-expected.txt:
- platform/mac/fast/block/positioning/047-expected.txt:
- platform/mac/fast/block/positioning/051-expected.txt:
- platform/mac/fast/block/positioning/inline-block-relposition-expected.txt:
- platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt:
- platform/mac/fast/borders/bidi-002-expected.txt:
- platform/mac/fast/borders/bidi-009a-expected.txt:
- platform/mac/fast/borders/bidi-012-expected.txt:
- platform/mac/fast/borders/fieldsetBorderRadius-expected.txt:
- platform/mac/fast/borders/rtl-border-01-expected.txt:
- platform/mac/fast/borders/rtl-border-02-expected.txt:
- platform/mac/fast/borders/rtl-border-03-expected.txt:
- platform/mac/fast/box-sizing/box-sizing-expected.txt:
- platform/mac/fast/clip/overflow-border-radius-composited-expected.txt:
- platform/mac/fast/clip/overflow-border-radius-transformed-expected.txt:
- platform/mac/fast/css-generated-content/011-expected.txt:
- platform/mac/fast/css-generated-content/012-expected.txt:
- platform/mac/fast/css-generated-content/013-expected.txt:
- platform/mac/fast/css-generated-content/014-expected.txt:
- platform/mac/fast/css-generated-content/015-expected.txt:
- platform/mac/fast/css-generated-content/details-summary-before-after-expected.txt:
- platform/mac/fast/css-generated-content/inline-display-types-expected.txt:
- platform/mac/fast/css/003-expected.txt:
- platform/mac/fast/css/004-expected.txt:
- platform/mac/fast/css/005-expected.txt:
- platform/mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Removed.
- platform/mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Removed.
- platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
- platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
- platform/mac/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt:
- platform/mac/fast/css/continuationCrash-expected.txt:
- platform/mac/fast/css/css1_forward_compatible_parsing-expected.txt:
- platform/mac/fast/css/css2-system-fonts-expected.txt:
- platform/mac/fast/css/empty-pseudo-class-expected.txt:
- platform/mac/fast/css/ex-after-font-variant-expected.txt:
- platform/mac/fast/css/fieldset-display-row-expected.txt:
- platform/mac/fast/css/first-child-pseudo-class-expected.txt:
- platform/mac/fast/css/first-line-text-decoration-expected.txt:
- platform/mac/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
- platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
- platform/mac/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt:
- platform/mac/fast/css/h1-in-section-elements-expected.txt:
- platform/mac/fast/css/hsl-color-expected.txt:
- platform/mac/fast/css/hsla-color-expected.txt:
- platform/mac/fast/css/inline-properties-important-expected.txt:
- platform/mac/fast/css/input-search-padding-expected.txt:
- platform/mac/fast/css/invalid-percentage-property-expected.txt:
- platform/mac/fast/css/last-child-pseudo-class-expected.txt:
- platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
- platform/mac/fast/css/line-height-expected.txt:
- platform/mac/fast/css/margin-top-bottom-dynamic-expected.txt:
- platform/mac/fast/css/non-standard-checkbox-size-expected.txt:
- platform/mac/fast/css/only-child-pseudo-class-expected.txt:
- platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
- platform/mac/fast/css/percentage-non-integer-expected.txt:
- platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt:
- platform/mac/fast/css/rgb-float-expected.txt:
- platform/mac/fast/css/rtl-ordering-expected.txt:
- platform/mac/fast/css/selector-set-attribute-expected.txt:
- platform/mac/fast/css/text-align-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
- platform/mac/fast/css/text-overflow-input-expected.txt:
- platform/mac/fast/css/transform-default-parameter-expected.txt:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:
- platform/mac/fast/css/word-space-extra-expected.txt:
- platform/mac/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Added.
- platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
- platform/mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
- platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
- platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
- platform/mac/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
- platform/mac/fast/dom/clone-node-dynamic-style-expected.txt:
- platform/mac/fast/dom/isindex-001-expected.txt:
- platform/mac/fast/dom/isindex-002-expected.txt:
- platform/mac/fast/dynamic/012-expected.txt:
- platform/mac/fast/dynamic/anchor-lock-expected.txt:
- platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
- platform/mac/fast/encoding/utf-16-big-endian-expected.txt:
- platform/mac/fast/encoding/utf-16-little-endian-expected.txt:
- platform/mac/fast/events/context-no-deselect-expected.txt:
- platform/mac/fast/events/document-elementFromPoint-expected.txt:
- platform/mac/fast/events/pointer-events-2-expected.txt:
- platform/mac/fast/flexbox/flex-hang-expected.txt:
- platform/mac/fast/forms/001-expected.txt:
- platform/mac/fast/forms/006-expected.txt:
- platform/mac/fast/forms/007-expected.txt:
- platform/mac/fast/forms/basic-buttons-expected.txt:
- platform/mac/fast/forms/basic-inputs-expected.txt:
- platform/mac/fast/forms/basic-textareas-expected.txt:
- platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
- platform/mac/fast/forms/blankbuttons-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/button-cannot-be-nested-expected.txt:
- platform/mac/fast/forms/button-default-title-expected.txt:
- platform/mac/fast/forms/button-generated-content-expected.txt:
- platform/mac/fast/forms/button-positioned-expected.txt:
- platform/mac/fast/forms/button-sizes-expected.txt:
- platform/mac/fast/forms/button-style-color-expected.txt:
- platform/mac/fast/forms/button-table-styles-expected.txt:
- platform/mac/fast/forms/button-text-transform-expected.txt:
- platform/mac/fast/forms/button-white-space-expected.txt:
- platform/mac/fast/forms/color/input-appearance-color-expected.txt:
- platform/mac/fast/forms/control-restrict-line-height-expected.txt:
- platform/mac/fast/forms/encoding-test-expected.txt:
- platform/mac/fast/forms/fieldset-align-expected.txt:
- platform/mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
- platform/mac/fast/forms/fieldset-with-float-expected.txt:
- platform/mac/fast/forms/file/file-input-direction-expected.txt:
- platform/mac/fast/forms/file/file-input-disabled-expected.txt:
- platform/mac/fast/forms/file/input-file-re-render-expected.txt:
- platform/mac/fast/forms/float-before-fieldset-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/formmove-expected.txt:
- platform/mac/fast/forms/formmove2-expected.txt:
- platform/mac/fast/forms/formmove3-expected.txt:
- platform/mac/fast/forms/indeterminate-expected.txt:
- platform/mac/fast/forms/input-align-expected.txt:
- platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
- platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
- platform/mac/fast/forms/input-appearance-disabled-expected.txt:
- platform/mac/fast/forms/input-appearance-focus-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/mac/fast/forms/input-appearance-readonly-expected.txt:
- platform/mac/fast/forms/input-appearance-selection-expected.txt:
- platform/mac/fast/forms/input-appearance-visibility-expected.txt:
- platform/mac/fast/forms/input-appearance-width-expected.txt:
- platform/mac/fast/forms/input-baseline-expected.txt:
- platform/mac/fast/forms/input-button-sizes-expected.txt:
- platform/mac/fast/forms/input-disabled-color-expected.txt:
- platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
- platform/mac/fast/forms/input-readonly-empty-expected.txt:
- platform/mac/fast/forms/input-spaces-expected.txt:
- platform/mac/fast/forms/input-table-expected.txt:
- platform/mac/fast/forms/input-text-click-inside-expected.txt:
- platform/mac/fast/forms/input-text-click-outside-expected.txt:
- platform/mac/fast/forms/input-text-double-click-expected.txt:
- platform/mac/fast/forms/input-text-drag-down-expected.txt:
- platform/mac/fast/forms/input-text-option-delete-expected.txt:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/mac/fast/forms/input-text-word-wrap-expected.txt:
- platform/mac/fast/forms/input-value-expected.txt:
- platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt:
- platform/mac/fast/forms/menulist-clip-expected.txt:
- platform/mac/fast/forms/minWidthPercent-expected.txt:
- platform/mac/fast/forms/number/number-appearance-rtl-expected.txt:
- platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
- platform/mac/fast/forms/placeholder-position-expected.txt:
- platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/mac/fast/forms/range/input-appearance-range-expected.txt:
- platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/mac/fast/forms/search-rtl-expected.txt:
- platform/mac/fast/forms/search-vertical-alignment-expected.txt:
- platform/mac/fast/forms/search/search-size-with-decorations-expected.txt:
- platform/mac/fast/forms/searchfield-heights-expected.txt:
- platform/mac/fast/forms/select-baseline-expected.txt:
- platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
- platform/mac/fast/forms/targeted-frame-submission-expected.txt:
- platform/mac/fast/forms/text-style-color-expected.txt:
- platform/mac/fast/forms/textAreaLineHeight-expected.txt:
- platform/mac/fast/forms/textfield-focus-ring-expected.txt:
- platform/mac/fast/forms/textfield-overflow-expected.txt:
- platform/mac/fast/forms/validation-message-appearance-expected.txt:
- platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
- platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
- platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
- platform/mac/fast/gradients/crash-on-zero-radius-expected.txt:
- platform/mac/fast/gradients/generated-gradients-expected.txt:
- platform/mac/fast/gradients/radial-centered-expected.txt:
- platform/mac/fast/gradients/simple-gradients-expected.txt:
- platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
- platform/mac/fast/html/details-add-child-1-expected.txt:
- platform/mac/fast/html/details-add-child-2-expected.txt:
- platform/mac/fast/html/details-add-details-child-1-expected.txt:
- platform/mac/fast/html/details-add-details-child-2-expected.txt:
- platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-1-expected.txt:
- platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-10-expected.txt:
- platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-2-expected.txt:
- platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-3-expected.txt:
- platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-4-expected.txt:
- platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-5-expected.txt:
- platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-6-expected.txt:
- platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-7-expected.txt:
- platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-8-expected.txt:
- platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-9-expected.txt:
- platform/mac/fast/html/details-add-summary-child-1-expected.txt:
- platform/mac/fast/html/details-add-summary-child-2-expected.txt:
- platform/mac/fast/html/details-marker-style-expected.txt:
- platform/mac/fast/html/details-nested-1-expected.txt:
- platform/mac/fast/html/details-nested-2-expected.txt:
- platform/mac/fast/html/details-no-summary1-expected.txt:
- platform/mac/fast/html/details-no-summary2-expected.txt:
- platform/mac/fast/html/details-no-summary3-expected.txt:
- platform/mac/fast/html/details-no-summary4-expected.txt:
- platform/mac/fast/html/details-open-javascript-expected.txt:
- platform/mac/fast/html/details-open1-expected.txt:
- platform/mac/fast/html/details-open2-expected.txt:
- platform/mac/fast/html/details-open3-expected.txt:
- platform/mac/fast/html/details-open4-expected.txt:
- platform/mac/fast/html/details-open5-expected.txt:
- platform/mac/fast/html/details-open6-expected.txt:
- platform/mac/fast/html/details-position-expected.txt:
- platform/mac/fast/html/details-remove-child-1-expected.txt:
- platform/mac/fast/html/details-remove-child-2-expected.txt:
- platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-1-expected.txt:
- platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-2-expected.txt:
- platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-3-expected.txt:
- platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-4-expected.txt:
- platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-5-expected.txt:
- platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-6-expected.txt:
- platform/mac/fast/html/details-remove-summary-child-1-expected.txt:
- platform/mac/fast/html/details-remove-summary-child-2-expected.txt:
- platform/mac/fast/html/details-replace-summary-child-expected.txt:
- platform/mac/fast/html/details-replace-text-expected.txt:
- platform/mac/fast/html/details-writing-mode-expected.txt:
- platform/mac/fast/images/imagemap-focus-ring-zoom-expected.txt:
- platform/mac/fast/images/repaint-subrect-grid-expected.txt:
- platform/mac/fast/images/zoomed-img-size-expected.txt:
- platform/mac/fast/inline-block/inline-block-vertical-align-expected.txt:
- platform/mac/fast/inline/002-expected.txt:
- platform/mac/fast/inline/continuation-outlines-expected.txt:
- platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
- platform/mac/fast/inline/inline-borders-with-bidi-override-expected.txt:
- platform/mac/fast/inline/inline-box-background-expected.txt:
- platform/mac/fast/inline/inline-box-background-long-image-expected.txt:
- platform/mac/fast/inline/inline-box-background-repeat-x-expected.txt:
- platform/mac/fast/inline/inline-box-background-repeat-y-expected.txt:
- platform/mac/fast/inline/outline-continuations-expected.txt:
- platform/mac/fast/inline/positionedLifetime-expected.txt:
- platform/mac/fast/invalid/010-expected.txt:
- platform/mac/fast/invalid/014-expected.txt:
- platform/mac/fast/invalid/junk-data-expected.txt:
- platform/mac/fast/invalid/missing-end-tag-expected.txt:
- platform/mac/fast/invalid/nestedh3s-expected.txt:
- platform/mac/fast/layers/video-layer-expected.txt:
- platform/mac/fast/line-grid/line-align-left-edges-expected.txt:
- platform/mac/fast/line-grid/line-grid-contains-value-expected.txt:
- platform/mac/fast/lists/003-expected.txt:
- platform/mac/fast/lists/003-vertical-expected.txt:
- platform/mac/fast/lists/008-expected.txt:
- platform/mac/fast/lists/008-vertical-expected.txt:
- platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
- platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
- platform/mac/fast/multicol/break-properties-expected.txt:
- platform/mac/fast/multicol/client-rects-expected.txt:
- platform/mac/fast/multicol/column-break-with-balancing-expected.txt:
- platform/mac/fast/multicol/float-multicol-expected.txt:
- platform/mac/fast/multicol/float-paginate-complex-expected.txt:
- platform/mac/fast/multicol/layers-in-multicol-expected.txt:
- platform/mac/fast/multicol/nested-columns-expected.txt:
- platform/mac/fast/multicol/overflow-across-columns-expected.txt:
- platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.txt:
- platform/mac/fast/multicol/overflow-unsplittable-expected.txt:
- platform/mac/fast/multicol/scrolling-overflow-expected.txt:
- platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
- platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
- platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.txt:
- platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
- platform/mac/fast/multicol/span/clone-flexbox-expected.txt:
- platform/mac/fast/multicol/span/clone-summary-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
- platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
- platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
- platform/mac/fast/multicol/span/span-margin-collapsing-expected.txt:
- platform/mac/fast/multicol/table-vertical-align-expected.txt:
- platform/mac/fast/multicol/vertical-lr/break-properties-expected.txt:
- platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
- platform/mac/fast/multicol/vertical-lr/float-multicol-expected.txt:
- platform/mac/fast/multicol/vertical-lr/nested-columns-expected.txt:
- platform/mac/fast/multicol/vertical-rl/break-properties-expected.txt:
- platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
- platform/mac/fast/multicol/vertical-rl/float-multicol-expected.txt:
- platform/mac/fast/multicol/vertical-rl/nested-columns-expected.txt:
- platform/mac/fast/overflow/007-expected.txt:
- platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
- platform/mac/fast/overflow/overflow-rtl-expected.txt:
- platform/mac/fast/overflow/overflow-rtl-vertical-expected.txt:
- platform/mac/fast/overflow/overflow_hidden-expected.txt:
- platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/mac/fast/overflow/scrollRevealButton-expected.txt:
- platform/mac/fast/parser/bad-xml-slash-expected.txt:
- platform/mac/fast/parser/entity-comment-in-style-expected.txt:
- platform/mac/fast/parser/style-script-head-test-expected.txt:
- platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
- platform/mac/fast/reflections/reflection-with-zoom-expected.txt:
- platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.png: Added.
- platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
- platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
- platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
- platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
- platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.png: Added.
- platform/mac/fast/regions/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/mac/fast/regions/selection/selecting-text-through-different-region-flows-expected.png: Added.
- platform/mac/fast/repaint/control-clip-expected.txt:
- platform/mac/fast/repaint/delete-into-nested-block-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
- platform/mac/fast/repaint/search-field-cancel-expected.txt:
- platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
- platform/mac/fast/repaint/transform-translate-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
- platform/mac/fast/replaced/table-percent-height-expected.txt:
- platform/mac/fast/replaced/width100percent-button-expected.txt:
- platform/mac/fast/replaced/width100percent-checkbox-expected.txt:
- platform/mac/fast/replaced/width100percent-radio-expected.txt:
- platform/mac/fast/replaced/width100percent-textarea-expected.txt:
- platform/mac/fast/ruby/ruby-inline-table-expected.txt:
- platform/mac/fast/selectors/032-expected.txt:
- platform/mac/fast/selectors/166-expected.txt:
- platform/mac/fast/selectors/unqualified-hover-quirks-expected.txt:
- platform/mac/fast/selectors/unqualified-hover-strict-expected.txt:
- platform/mac/fast/shapes/shape-inside/shape-inside-circle-expected.png: Added.
- platform/mac/fast/shapes/shape-inside/shape-inside-circle-padding-expected.png: Added.
- platform/mac/fast/shapes/shape-inside/shape-inside-ellipse-expected.png: Added.
- platform/mac/fast/shapes/shape-inside/shape-inside-ellipse-padding-expected.png: Added.
- platform/mac/fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-002-expected.png: Added.
- platform/mac/fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top-expected.png: Added.
- platform/mac/fast/table/009-expected.txt:
- platform/mac/fast/table/014-expected.txt:
- platform/mac/fast/table/040-expected.txt:
- platform/mac/fast/table/040-vertical-expected.txt:
- platform/mac/fast/table/041-expected.txt:
- platform/mac/fast/table/absolute-table-at-bottom-expected.txt:
- platform/mac/fast/table/append-cells2-expected.txt:
- platform/mac/fast/table/border-collapsing/004-expected.txt:
- platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/mac/fast/table/colspanMinWidth-expected.txt:
- platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/mac/fast/table/frame-and-rules-expected.txt:
- platform/mac/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
- platform/mac/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
- platform/mac/fast/table/nested-percent-height-table-expected.txt:
- platform/mac/fast/table/overflowHidden-expected.txt:
- platform/mac/fast/table/percent-heights-expected.txt:
- platform/mac/fast/table/remove-td-display-none-expected.txt:
- platform/mac/fast/table/spanOverlapRepaint-expected.txt:
- platform/mac/fast/table/table-display-types-strict-expected.txt:
- platform/mac/fast/table/table-hspace-align-center-expected.txt:
- platform/mac/fast/table/text-field-baseline-expected.txt:
- platform/mac/fast/text/basic/012-expected.txt:
- platform/mac/fast/text/basic/013-expected.txt:
- platform/mac/fast/text/basic/generic-family-reset-expected.txt:
- platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
- platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
- platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/mac/fast/text/line-breaks-expected.txt:
- platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
- platform/mac/fast/text/vertical-rl-rtl-linebreak-expected.txt:
- platform/mac/fast/text/whitespace/024-expected.txt:
- platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
- platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
- platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:
- platform/mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt:
- platform/mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt:
- platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/mac/fast/transforms/transforms-with-zoom-expected.txt:
- platform/mac/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
- platform/mac/fast/writing-mode/broken-ideographic-font-expected.txt:
- platform/mac/fast/writing-mode/fieldsets-expected.txt:
- platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
- platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
- platform/mac/http/tests/misc/acid3-expected.txt:
- platform/mac/http/tests/misc/iframe404-expected.txt:
- platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt:
- platform/mac/mathml/presentation/mo-stretch-expected.txt:
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-strict-expected.txt:
- platform/mac/media/controls-styling-strict-expected.txt:
- platform/mac/media/controls-without-preload-expected.txt:
- platform/mac/media/media-controls-clone-expected.txt:
- platform/mac/media/video-no-audio-expected.txt:
- platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
- platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
- platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt:
- platform/mac/platform/mac/fast/text/x-height-expected.txt: Added.
- platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
- platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt:
- platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt:
- platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt:
- platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt:
- platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
- platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
- platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
- platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
- platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
- platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
- platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
- platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
- platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
- platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
- platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
- platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
- platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
- platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
- platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
- platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
- platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt:
- platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
- platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
- platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-direction-ltr-expected.txt:
- platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-text-07-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
- platform/mac/svg/as-border-image/svg-as-border-image-2-expected.txt:
- platform/mac/svg/as-border-image/svg-as-border-image-expected.txt:
- platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
- platform/mac/svg/as-image/svg-non-integer-scaled-image-expected.txt:
- platform/mac/svg/batik/filters/filterRegions-expected.txt:
- platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
- platform/mac/svg/batik/paints/patternRegionA-expected.txt:
- platform/mac/svg/batik/paints/patternRegions-expected.txt:
- platform/mac/svg/batik/text/smallFonts-expected.txt:
- platform/mac/svg/batik/text/textAnchor-expected.txt:
- platform/mac/svg/batik/text/textAnchor2-expected.txt:
- platform/mac/svg/batik/text/textAnchor3-expected.txt:
- platform/mac/svg/batik/text/textDecoration2-expected.txt:
- platform/mac/svg/batik/text/textEffect2-expected.txt:
- platform/mac/svg/batik/text/textEffect3-expected.txt:
- platform/mac/svg/batik/text/textFeatures-expected.txt:
- platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
- platform/mac/svg/batik/text/textLayout-expected.txt:
- platform/mac/svg/batik/text/textLayout2-expected.txt:
- platform/mac/svg/batik/text/textOnPath2-expected.txt:
- platform/mac/svg/batik/text/textOnPath3-expected.txt:
- platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
- platform/mac/svg/batik/text/textPCDATA-expected.txt:
- platform/mac/svg/batik/text/textPosition2-expected.txt: Added.
- platform/mac/svg/batik/text/textProperties-expected.txt:
- platform/mac/svg/batik/text/textProperties2-expected.txt:
- platform/mac/svg/batik/text/textStyles-expected.txt:
- platform/mac/svg/batik/text/xmlSpace-expected.txt:
- platform/mac/svg/carto.net/button-expected.txt:
- platform/mac/svg/carto.net/colourpicker-expected.txt:
- platform/mac/svg/carto.net/combobox-expected.txt:
- platform/mac/svg/carto.net/scrollbar-expected.txt:
- platform/mac/svg/carto.net/selectionlist-expected.txt:
- platform/mac/svg/carto.net/slider-expected.txt:
- platform/mac/svg/carto.net/tabgroup-expected.txt:
- platform/mac/svg/carto.net/textbox-expected.txt:
- platform/mac/svg/carto.net/window-expected.txt:
- platform/mac/svg/clip-path/clip-path-pixelation-expected.txt:
- platform/mac/svg/css/shadow-changes-expected.txt:
- platform/mac/svg/css/text-shadow-multiple-expected.txt:
- platform/mac/svg/custom/SVGPoint-matrixTransform-expected.txt:
- platform/mac/svg/custom/bug45331-expected.txt:
- platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
- platform/mac/svg/custom/dominant-baseline-modes-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
- platform/mac/svg/custom/font-face-cascade-order-expected.txt:
- platform/mac/svg/custom/font-face-simple-expected.txt:
- platform/mac/svg/custom/fractional-rects-expected.txt:
- platform/mac/svg/custom/getTransformToElement-expected.txt:
- platform/mac/svg/custom/glyph-setting-d-attribute-expected.txt:
- platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt:
- platform/mac/svg/custom/image-parent-translation-expected.txt:
- platform/mac/svg/custom/image-small-width-height-expected.txt:
- platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
- platform/mac/svg/custom/invalid-css-expected.txt:
- platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.txt:
- platform/mac/svg/custom/js-late-gradient-creation-expected.txt:
- platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
- platform/mac/svg/custom/js-late-pattern-creation-expected.txt:
- platform/mac/svg/custom/js-update-container-expected.txt:
- platform/mac/svg/custom/junk-data-expected.txt:
- platform/mac/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt:
- platform/mac/svg/custom/linking-a-03-b-transform-expected.txt:
- platform/mac/svg/custom/linking-a-03-b-viewBox-expected.txt:
- platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
- platform/mac/svg/custom/linking-a-03-b-viewTarget-expected.txt:
- platform/mac/svg/custom/linking-a-03-b-zoomAndPan-expected.txt:
- platform/mac/svg/custom/linking-uri-01-b-expected.txt:
- platform/mac/svg/custom/marker-default-width-height-expected.txt:
- platform/mac/svg/custom/missing-xlink-expected.txt:
- platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt:
- platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
- platform/mac/svg/custom/object-sizing-expected.txt:
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
- platform/mac/svg/custom/path-bad-data-expected.txt:
- platform/mac/svg/custom/path-textPath-simulation-expected.txt:
- platform/mac/svg/custom/pattern-incorrect-tiling-expected.txt:
- platform/mac/svg/custom/pattern-rotate-expected.txt:
- platform/mac/svg/custom/pattern-rotate-gaps-expected.txt:
- platform/mac/svg/custom/pattern-with-transformation-expected.txt:
- platform/mac/svg/custom/pointer-events-text-css-transform-expected.txt:
- platform/mac/svg/custom/rootmost-svg-xy-attrs-expected.txt:
- platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/mac/svg/custom/shapes-supporting-markers-expected.txt:
- platform/mac/svg/custom/stroked-pattern-expected.txt: Added.
- platform/mac/svg/custom/style-attribute-font-size-expected.txt:
- platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
- platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
- platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
- platform/mac/svg/custom/text-clip-expected.txt:
- platform/mac/svg/custom/text-ctm-expected.txt:
- platform/mac/svg/custom/text-dom-01-f-expected.txt:
- platform/mac/svg/custom/text-filter-expected.txt:
- platform/mac/svg/custom/text-hit-test-expected.txt:
- platform/mac/svg/custom/text-letter-spacing-expected.txt:
- platform/mac/svg/custom/text-repaint-including-stroke-expected.txt:
- platform/mac/svg/custom/text-rotation-expected.txt:
- platform/mac/svg/custom/text-tref-03-b-change-href-dom-expected.txt:
- platform/mac/svg/custom/text-tref-03-b-change-href-expected.txt:
- platform/mac/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt:
- platform/mac/svg/custom/text-tref-03-b-tref-removal-expected.txt:
- platform/mac/svg/custom/text-whitespace-handling-expected.txt:
- platform/mac/svg/custom/text-x-dx-lists-expected.txt:
- platform/mac/svg/custom/text-x-dy-lists-expected.txt:
- platform/mac/svg/custom/text-x-override-in-tspan-child-expected.txt:
- platform/mac/svg/custom/tref-own-content-removal-expected.txt:
- platform/mac/svg/custom/tref-update-expected.txt:
- platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt:
- platform/mac/svg/custom/use-detach-expected.txt:
- platform/mac/svg/custom/use-dynamic-append-expected.txt:
- platform/mac/svg/custom/use-font-face-crash-expected.txt:
- platform/mac/svg/custom/use-modify-container-in-target-expected.txt:
- platform/mac/svg/custom/use-modify-target-container-expected.txt:
- platform/mac/svg/custom/use-modify-target-symbol-expected.txt:
- platform/mac/svg/custom/use-recursion-1-expected.txt:
- platform/mac/svg/custom/use-recursion-2-expected.txt:
- platform/mac/svg/custom/use-recursion-3-expected.txt:
- platform/mac/svg/custom/use-recursion-4-expected.txt:
- platform/mac/svg/custom/viewBox-hit-expected.txt:
- platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
- platform/mac/svg/hixie/error/002-expected.txt:
- platform/mac/svg/hixie/error/012-expected.txt:
- platform/mac/svg/hixie/error/013-expected.txt:
- platform/mac/svg/hixie/perf/001-expected.txt:
- platform/mac/svg/hixie/perf/002-expected.txt:
- platform/mac/svg/hixie/perf/003-expected.txt:
- platform/mac/svg/hixie/perf/004-expected.txt: Added.
- platform/mac/svg/hixie/perf/005-expected.txt: Added.
- platform/mac/svg/hixie/perf/006-expected.txt: Added.
- platform/mac/svg/hixie/perf/007-expected.txt:
- platform/mac/svg/hixie/text/001-expected.txt:
- platform/mac/svg/hixie/text/003-expected.txt:
- platform/mac/svg/hixie/text/003a-expected.txt:
- platform/mac/svg/hixie/text/003b-expected.txt:
- platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
- platform/mac/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
- platform/mac/svg/text/append-text-node-to-tspan-expected.txt:
- platform/mac/svg/text/bidi-embedded-direction-expected.txt:
- platform/mac/svg/text/bidi-reorder-value-lists-expected.txt:
- platform/mac/svg/text/bidi-text-query-expected.txt:
- platform/mac/svg/text/bidi-tspans-expected.txt:
- platform/mac/svg/text/font-size-below-point-five-expected.txt:
- platform/mac/svg/text/modify-text-node-in-tspan-expected.txt:
- platform/mac/svg/text/non-bmp-positioning-lists-expected.txt:
- platform/mac/svg/text/remove-text-node-from-tspan-expected.txt:
- platform/mac/svg/text/remove-tspan-from-text-expected.txt:
- platform/mac/svg/text/scaled-font-expected.txt:
- platform/mac/svg/text/scaling-font-with-geometric-precision-expected.txt:
- platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
- platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
- platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
- platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
- platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.txt:
- platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.txt:
- platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.txt:
- platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.txt:
- platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
- platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
- platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
- platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
- platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
- platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
- platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
- platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
- platform/mac/svg/text/select-x-list-1-expected.txt:
- platform/mac/svg/text/select-x-list-2-expected.txt:
- platform/mac/svg/text/select-x-list-3-expected.txt:
- platform/mac/svg/text/select-x-list-4-expected.txt:
- platform/mac/svg/text/select-x-list-with-tspans-1-expected.txt:
- platform/mac/svg/text/select-x-list-with-tspans-2-expected.txt:
- platform/mac/svg/text/select-x-list-with-tspans-3-expected.txt:
- platform/mac/svg/text/select-x-list-with-tspans-4-expected.txt:
- platform/mac/svg/text/selection-doubleclick-expected.txt:
- platform/mac/svg/text/selection-tripleclick-expected.txt: Copied from LayoutTests/platform/mac/svg/text/selection-doubleclick-expected.txt.
- platform/mac/svg/text/small-fonts-2-expected.txt:
- platform/mac/svg/text/small-fonts-3-expected.txt:
- platform/mac/svg/text/small-fonts-expected.txt:
- platform/mac/svg/text/small-fonts-in-html5-expected.txt:
- platform/mac/svg/text/text-align-01-b-expected.txt:
- platform/mac/svg/text/text-align-02-b-expected.txt:
- platform/mac/svg/text/text-align-03-b-expected.txt:
- platform/mac/svg/text/text-align-04-b-expected.txt:
- platform/mac/svg/text/text-align-05-b-expected.txt:
- platform/mac/svg/text/text-align-06-b-expected.txt:
- platform/mac/svg/text/text-altglyph-01-b-expected.txt:
- platform/mac/svg/text/text-deco-01-b-expected.txt:
- platform/mac/svg/text/text-fonts-01-t-expected.txt:
- platform/mac/svg/text/text-fonts-02-t-expected.txt:
- platform/mac/svg/text/text-hkern-expected.txt:
- platform/mac/svg/text/text-intro-05-t-expected.txt:
- platform/mac/svg/text/text-midpoint-split-bug-expected.txt:
- platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.txt:
- platform/mac/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.txt:
- platform/mac/svg/text/text-path-01-b-expected.txt:
- platform/mac/svg/text/text-path-middle-align-expected.txt:
- platform/mac/svg/text/text-repaint-rects-expected.txt:
- platform/mac/svg/text/text-spacing-01-b-expected.txt:
- platform/mac/svg/text/text-text-01-b-expected.txt:
- platform/mac/svg/text/text-text-03-b-expected.txt:
- platform/mac/svg/text/text-text-04-t-expected.txt:
- platform/mac/svg/text/text-text-05-t-expected.txt:
- platform/mac/svg/text/text-text-06-t-expected.txt:
- platform/mac/svg/text/text-text-07-t-expected.txt:
- platform/mac/svg/text/text-text-08-b-expected.txt:
- platform/mac/svg/text/text-tref-01-b-expected.txt:
- platform/mac/svg/text/text-tselect-01-b-expected.txt:
- platform/mac/svg/text/text-tselect-02-f-expected.txt:
- platform/mac/svg/text/text-tspan-01-b-expected.txt:
- platform/mac/svg/text/text-viewbox-rescale-expected.txt:
- platform/mac/svg/text/text-ws-01-t-expected.txt:
- platform/mac/svg/text/text-ws-02-t-expected.txt:
- platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.txt:
- platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.txt:
- platform/mac/svg/transforms/svg-css-transforms-expected.txt:
- platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
- platform/mac/svg/wicd/rightsizing-grid-expected.txt:
- platform/mac/svg/wicd/sizing-flakiness-expected.txt:
- platform/mac/svg/wicd/test-rightsizing-a-expected.txt:
- platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
- platform/mac/svg/wicd/test-scalable-background-image1-expected.txt:
- platform/mac/svg/wicd/test-scalable-background-image2-expected.txt:
- platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt:
- platform/mac/svg/zoom/page/zoom-background-images-expected.txt:
- platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
- platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
- platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
- platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
- platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
- platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-as-image-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-as-object-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
- platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt:
- platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
- platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
- platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
- platform/mac/tables/mozilla/bugs/bug10269-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug10296-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1055-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug106816-expected.txt:
- platform/mac/tables/mozilla/bugs/bug113235-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug113424-expected.txt:
- platform/mac/tables/mozilla/bugs/bug11384q-expected.txt:
- platform/mac/tables/mozilla/bugs/bug11384s-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
- platform/mac/tables/mozilla/bugs/bug126742-expected.txt:
- platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
- platform/mac/tables/mozilla/bugs/bug13118-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
- platform/mac/tables/mozilla/bugs/bug139524-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug159108-expected.txt:
- platform/mac/tables/mozilla/bugs/bug17130-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug17130-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug17138-expected.txt:
- platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
- platform/mac/tables/mozilla/bugs/bug19061-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug19061-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
- platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2886-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
- platform/mac/tables/mozilla/bugs/bug3309-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug3309-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug33137-expected.txt:
- platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
- platform/mac/tables/mozilla/bugs/bug39209-expected.txt:
- platform/mac/tables/mozilla/bugs/bug42187-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4284-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4429-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46480-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46480-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
- platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
- platform/mac/tables/mozilla/bugs/bug52506-expected.txt:
- platform/mac/tables/mozilla/bugs/bug5538-expected.txt:
- platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
- platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
- platform/mac/tables/mozilla/bugs/bug60749-expected.txt:
- platform/mac/tables/mozilla/bugs/bug6304-expected.txt:
- platform/mac/tables/mozilla/bugs/bug67915-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug69187-expected.txt:
- platform/mac/tables/mozilla/bugs/bug7112-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug7112-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug73321-expected.txt:
- platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
- platform/mac/tables/mozilla/bugs/bug8032-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug83786-expected.txt:
- platform/mac/tables/mozilla/bugs/bug8381-expected.txt:
- platform/mac/tables/mozilla/bugs/bug9271-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug9271-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
- platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
- platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/mac/tables/mozilla/core/bloomberg-expected.txt:
- platform/mac/tables/mozilla/core/margins-expected.txt:
- platform/mac/tables/mozilla/core/misc-expected.txt:
- platform/mac/tables/mozilla/dom/tableDom-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_index-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/mac/tables/mozilla/other/move_row-expected.txt:
- platform/mac/tables/mozilla/other/test3-expected.txt:
- platform/mac/tables/mozilla/other/test6-expected.txt:
- platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Added.
- platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug3166-18-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug61042-1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug61042-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
- platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions3-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/standards1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
- platform/mac/transforms/2d/hindi-rotated-expected.txt:
- platform/mac/transforms/2d/zoom-menulist-expected.txt:
- platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
- platform/mac/transforms/svg-vs-css-expected.txt:
- 9:19 AM Changeset in webkit [161883] by
-
- 2 edits in trunk/Source/WTF
Fix Windows build.
- wtf/ThreadingWin.cpp:
(WTF::initializeThreading):
- 9:17 AM Changeset in webkit [161882] by
-
- 8 edits in trunk/Source
Enable SUBPIXEL_LAYOUT on Mac
<https://webkit.org/b/126283>
Reviewed by Simon Fraser.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 8:47 AM Changeset in webkit [161881] by
-
- 9 edits in trunk/Tools
Remove wdiff
https://bugs.webkit.org/show_bug.cgi?id=124766
Patch by Daniel Batyai <Dániel Bátyai> on 2014-01-13
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
(ResultsJSONParserTest):
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter):
(TestResultWriter.create_text_diff_and_write_result):
- Scripts/webkitpy/layout_tests/models/test_run_results.py:
(summarize_results):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_output_diffs):
- Scripts/webkitpy/port/base.py:
(Port.init):
(Port.driver_stop_timeout):
(Port.check_image_diff):
(Port.repository_paths):
(Port._path_to_lighttpd_php):
- Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_default_child_processes):
(PortTest.test_pretty_patch_script_error):
- Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.test_diff_image_crashed):
- Scripts/webkitpy/port/test.py:
(TestPort.operating_system):
- 8:40 AM Changeset in webkit [161880] by
-
- 2 edits in trunk/Tools
Build fix for the GTK+ CMake port
- TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
- 8:38 AM Changeset in webkit [161879] by
-
- 5 edits1 add in trunk/Source/WTF
Remove AtomicallyInitializedStatic
https://bugs.webkit.org/show_bug.cgi?id=126864
Reviewed by Andreas Kling.
Remove the lockAtomicallyInitializedStaticMutex and unlockAtomicallyInitializedStaticMutex functions
everywhere except on Mac (where they unfortunately were used by Safari).
On Mac, add them to a separate file which will hold functions and symbols that we would like
to remove but that are used by Safari. Reimplement them in terms of std::call_once and std::mutex.
- WTF.xcodeproj/project.pbxproj:
- wtf/Threading.h:
- wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
- wtf/ThreadingWin.cpp:
(WTF::initializeThreading):
- wtf/mac/DeprecatedSymbolsUsedBySafari.mm: Added.
(WTF::atomicallyInitializedStaticMutex):
(WTF::lockAtomicallyInitializedStaticMutex):
(WTF::unlockAtomicallyInitializedStaticMutex):
- 8:15 AM Changeset in webkit [161878] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r161715): Use of uninitialized value $ENV{"PLATFORM_NAME"}
https://bugs.webkit.org/show_bug.cgi?id=126873
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-01-13
Reviewed by Csaba Osztrogonác.
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
- 6:33 AM Changeset in webkit [161877] by
-
- 5 edits in trunk/Source/WebCore
CTTE: Autoscroll renderer is always a RenderBox.
<https://webkit.org/b/126884>
Reviewed by Antti Koivisto.
- page/EventHandler.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::autoscrollRenderer):
Make autoscrollRenderer() return a RenderBox*.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed):
Only check if the autoscroll renderer is being torn down
in RenderBox::willBeDestroyed() since it's not relevant for
other renderer types.
- 5:29 AM WebKitEFLLayoutTest edited by
- (diff)
- 4:52 AM Changeset in webkit [161876] by
-
- 7 edits2 adds in trunk
Text should be constructable.
https://bugs.webkit.org/show_bug.cgi?id=115640
Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-13
Reviewed by Csaba Osztrogonác.
Source/WebCore:
http://dom.spec.whatwg.org/#interface-text
Make Text constructable so that one can do "new Text('abc')"
instead of "document.createTexte('abc')".
Backported from Blink: https://chromium.googlesource.com/chromium/blink/+/cdd5a914daf3862379a5ce4596149bd690d0fa08
Test: fast/dom/Text/text-constructor.html
- dom/Text.cpp:
(WebCore::Text::create):
- dom/Text.h:
- dom/Text.idl:
LayoutTests:
- fast/dom/Text/text-constructor-expected.txt: Added.
- fast/dom/Text/text-constructor.html: Added.
- fast/dom/dom-constructors-expected.txt:
- fast/dom/dom-constructors.html:
- 3:50 AM Changeset in webkit [161875] by
-
- 2 edits in trunk/Tools
[GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=126881
Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-01-13
Reviewed by Carlos Garcia Campos.
- MiniBrowser/gtk/BrowserWindow.c:
(browser_window_new):
Explicitly cast GtkWindow to gpointer* in call to
g_object_add_weak_pointer to avoid compiler warnings.
- 3:29 AM Changeset in webkit [161874] by
-
- 1 copy in releases/WebKitGTK/webkit-2.3.4
Tagging the WebKitGTK+ 2.3.4 release
- 3:19 AM Changeset in webkit [161873] by
-
- 19 edits in trunk/Source/WebCore
Avoid unnecessary copies of AccessibilityObject::AccessibilityChildrenVector
https://bugs.webkit.org/show_bug.cgi?id=126876
Reviewed by Andreas Kling.
AccessibilityObject::children() returns a reference to the Vector of that AccessibilityObject's children.
The majority of callsites stores the return value in a temporary value instead of a reference, causing
a copy each time. A reference to the return value should be used instead.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedImageMapUIElement):
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addRowDescendant):
- accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::rowIndexRange):
(WebCore::AccessibilityARIAGridCell::columnIndexRange):
- accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::headerObject):
- accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::setSelectedChildren):
- accessibility/AccessibilityListBox.h:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::insertChild):
(WebCore::AccessibilityNodeObject::selectedRadioButton):
(WebCore::AccessibilityNodeObject::selectedTabItem):
- accessibility/AccessibilityObject.cpp:
(WebCore::appendChildrenToArray):
(WebCore::AccessibilityObject::ariaTreeRows):
(WebCore::AccessibilityObject::ariaTreeItemContent):
(WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::addRemoteSVGChildren):
(WebCore::AccessibilityRenderObject::addHiddenChildren):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::ariaListboxVisibleChildren):
(WebCore::AccessibilityRenderObject::tabChildren):
(WebCore::AccessibilityRenderObject::mathRadicandObject):
(WebCore::AccessibilityRenderObject::mathRootIndexObject):
(WebCore::AccessibilityRenderObject::mathNumeratorObject):
(WebCore::AccessibilityRenderObject::mathDenominatorObject):
(WebCore::AccessibilityRenderObject::mathUnderObject):
(WebCore::AccessibilityRenderObject::mathOverObject):
(WebCore::AccessibilityRenderObject::mathBaseObject):
(WebCore::AccessibilityRenderObject::mathSubscriptObject):
(WebCore::AccessibilityRenderObject::mathSuperscriptObject):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::cellForColumnAndRow):
- accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::headerObject):
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::headerObject):
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::getListObject):
(WebCore::notifyChildrenSelectionChange):
- accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp:
(webkitAccessibleHypertextGetLink):
(webkitAccessibleHypertextGetNLinks):
- accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:
(listObjectForSelection):
(optionFromList):
(webkitAccessibleSelectionSelectAllSelection):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(getNChildrenForTable):
(getChildForTable):
(webkitAccessibleRefChild):
(getIndexInParentForCellInRow):
(getInterfaceMaskFromObject):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
(-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
(-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- 2:45 AM Changeset in webkit [161872] by
-
- 4 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r161696. Adding failure expectations
for a few reference tests that were introduced in r161573 and r161626.
- platform/gtk/TestExpectations:
- platform/gtk/css1/text_properties/word_spacing-expected.png:
- platform/gtk/css1/text_properties/word_spacing-expected.txt:
- 2:44 AM Changeset in webkit [161871] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r161855.
http://trac.webkit.org/changeset/161855
https://bugs.webkit.org/show_bug.cgi?id=126880
Sister commit of r161852 (Requested by kling on #webkit).
- wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
- 2:25 AM Changeset in webkit [161870] by
-
- 4 edits in trunk
Unreviewed. Update NEWS and Versions.m4 for 2.3.4 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.3.4.
- 2:12 AM Changeset in webkit [161869] by
-
- 4 edits in trunk/Source/WTF
Unreviewed, rolling out r161852.
http://trac.webkit.org/changeset/161852
https://bugs.webkit.org/show_bug.cgi?id=126877
Broke ToT with system Safari (Requested by kling on #webkit).
- wtf/Threading.h:
- wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
(WTF::lockAtomicallyInitializedStaticMutex):
(WTF::unlockAtomicallyInitializedStaticMutex):
- wtf/ThreadingWin.cpp:
(WTF::lockAtomicallyInitializedStaticMutex):
(WTF::unlockAtomicallyInitializedStaticMutex):
(WTF::initializeThreading):
- 1:54 AM Changeset in webkit [161868] by
-
- 3 edits in trunk/Tools
Remove parsing of old-run-webkit-tests output from master.cfg
https://bugs.webkit.org/show_bug.cgi?id=126690
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-13
Reviewed by Csaba Osztrogonác.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
Removed parsing of ORWT output, as it is not used anymore.
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
Updated unit tests accordingly.
- 1:46 AM Changeset in webkit [161867] by
-
- 7 edits2 adds in trunk
Comment should be consructable.
https://bugs.webkit.org/show_bug.cgi?id=115642
Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-13
Reviewed by Andreas Kling.
Source/WebCore:
http://dom.spec.whatwg.org/#comment
This allows us to donew Comment('abc')instead ofdocument.createComment('abc').
Backported from Blink: https://chromium.googlesource.com/chromium/blink/+/06e4a37f6b11348606de5405edac1ada97499d2a%5E%21
Test: fast/dom/Comment/comment-constructor.html
- dom/Comment.cpp:
(WebCore::Comment::create):
- dom/Comment.h:
- dom/Comment.idl:
LayoutTests:
- fast/dom/Comment/comment-constructor-expected.txt: Added.
- fast/dom/Comment/comment-constructor.html: Added.
- fast/dom/dom-constructors-expected.txt:
- fast/dom/dom-constructors.html:
- 1:23 AM Changeset in webkit [161866] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Changes in r161686 are exposing a bug in GCC where the global .cfi_startproc directive
is not inserted early enough into the generated assembler code when building in debug mode, causing
compilation failures on ports using the GCC compilers. To work around the problem, only utilize the
OFFLINE_ASM_* macros that use .cfi_ directives when compiling with Clang.
- llint/LowLevelInterpreter.cpp:
- 1:02 AM Changeset in webkit [161865] by
-
- 7 edits in trunk
Unreviewed, rolling out r161808.
http://trac.webkit.org/changeset/161808
https://bugs.webkit.org/show_bug.cgi?id=126874
This patch make several files to be always regenerated on
every make (Requested by KaL on #webkit).
Source/WebCore:
- GNUmakefile.am:
- bindings/gobject/GNUmakefile.am:
Source/WebKit/gtk:
- GNUmakefile.am:
Tools:
- WebKitTestRunner/GNUmakefile.am:
- 12:12 AM Changeset in webkit [161864] by
-
- 2 edits in trunk/Tools
[GTK] Make MiniBrowser windows non-transient by default
https://bugs.webkit.org/show_bug.cgi?id=126840
Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-01-13
Reviewed by Carlos Garcia Campos.
Instead of making new browser windows transient as soon as they are
created, save the pointer to the parent window and set the transient
state later on when handling the "run-as-modal" signal. This makes
it easier to use the MiniBrowser to do tests involving multiple
windows, and will be useful as well when multi-web-process mode is
enabled for the GTK port.
- MiniBrowser/gtk/BrowserWindow.c:
(webViewRunAsModal): Set the parent window using
gtk_window_set_transient_for() using the saved parent
window.
(browser_window_new): Save the parent window using
g_object_set_data() instead of making the new window
transient immediately.
Jan 12, 2014:
- 11:20 PM Changeset in webkit [161863] by
-
- 12 edits in branches/jsCStack/Source/JavaScriptCore
internal-js-tests.yaml/Octane/mandreel.js.default-ftl fails about 1/30 times with "TypeError: undefined is not an object"
https://bugs.webkit.org/show_bug.cgi?id=126797
Not yet reviewed.
This bug was a hilarious combination of concurrent JIT (making it a flake),
LLInt->JIT OSR, and the FTL's register preservation wrapper.
Consider that a CodeBlock with a LLInt JITCode may get called, and while running,
it may decide to tier up to the baseline JIT. At that point, the old JITCode gets
summarily deleted and replaced by the baseline JITCode. This used to be "correct"
because the LLInt's JITCode only held a reference to an immortal entrypoint thunk.
But not anymore: now the LLInt's JITCode may also hold references to register
preservation wrappers, which get generated lazily.
So consider that the FTL calls a LLInt'd CodeBlock and that LLInt JITCode lazily
creates a register preservation wrapper. That register preservation wrapper is on
the stack and the stack will have a return PC that points to it. Then the LLInt
code decides to tier up to the baseline JIT. This causes the LLInt JITCode to get
deleted. That means that the register preservation wrapper also gets deleted. Now
all it takes is for some more executable memory to get allocated, and when that
baseline JIT frame (that used to be a LLInt frame) returns, it returns into what
it *thinks* is a register preservation wrapper - except now it's something else!
Hilariously, the thing that we'd return into in mandreel was a PutByVal stub. When
the concurrent JIT interleaved itself in such a way as to make this case happen
(i.e. the FTL code for runMandreel was compiled just as some mandreel init routine
was *about* to get tiered up to baseline JIT), then the baseline code would
*always* allocate a PutByVal stub right where the register preservation wrapper's
return site used to be. Thus, returning from the baseline code for that
initialization function would cause it to jump to a PutByVal stub for one of the
PutByVal's in that same function. Somehow, we'd always end up returning to a valid
instruction rather than into the middle of something. That PutByVal stub would
then do a type check on some random variable that it thought was the base - it
would of course fail - and then the slow path would try to do conversions - that
would result in it seeing undefined - and then usually we would crash while trying
to throw the exception.
The solution is to make the return site of the register preservation thunk be
always immortal. We already had a standalone immortal return ramp for that thunk
for use by FTL OSR exit. I figure it doesn't hurt to just always use that immortal
return site.
This bug took several days to track down. I don't think I can add more tests for
this, although I'll think about it. Basically the lesson here is that running big
tests like Mandreel over and over again with the concurrent JIT enabled shakes out
interesting bugs.
This change also adds some useful debug flags, like --breakOnThrow=true, which
causes us to CRASH() whenever an exception is thrown. Without this, this bug was
basically impossible to figure out: we would wind up somewhere in
handleUncaughtException and then that code would go *completely berserk* because
the stack is of course totally screwed up once we "returned" into that PutByVal
stub.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType):
(JSC::CodeBlock::CodeBlock):
- dfg/DFGCompilationMode.h:
(JSC::DFG::isFTL):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::reportCompileTimes):
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPlan.h:
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- jit/JITExceptions.cpp:
(JSC::genericUnwind):
- jit/RegisterPreservationWrapperGenerator.cpp:
(JSC::generateRegisterPreservationWrapper):
(JSC::generateRegisterRestoration):
- jit/RegisterPreservationWrapperGenerator.h:
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
- runtime/Options.h:
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::throwException):
- 10:29 PM Changeset in webkit [161862] by
-
- 7 edits in trunk
Unreviewed, rolling out r161843.
http://trac.webkit.org/changeset/161843
https://bugs.webkit.org/show_bug.cgi?id=126871
Caused CSS custom filter tests to assert (Requested by smfr on
#webkit).
Source/WebCore:
- platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::getSymbolInfo):
(WebCore::ANGLEWebKitBridge::compileShaderSource):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getShaderInfoLog):
LayoutTests:
- fast/canvas/webgl/glsl-conformance-expected.txt:
- fast/canvas/webgl/glsl-conformance.html:
- 10:26 PM Changeset in webkit [161861] by
-
- 29 edits in trunk/Source
Unreviewed, rolling out r161840.
http://trac.webkit.org/changeset/161840
https://bugs.webkit.org/show_bug.cgi?id=126870
Caused jsscore and layout test failures (Requested by smfr on
#webkit).
Source/JavaScriptCore:
- API/JSValueRef.cpp:
(JSValueMakeFromJSONString):
- bindings/ScriptValue.cpp:
(Deprecated::jsToInspectorValue):
- inspector/InspectorValues.cpp:
- runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
- runtime/Identifier.h:
(JSC::Identifier::characters):
- runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::append):
Source/WebCore:
- bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):
- editing/CompositeEditCommand.cpp:
(WebCore::containsOnlyWhitespace):
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertText):
- editing/VisibleUnits.cpp:
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):
- html/parser/HTMLParserIdioms.cpp:
(WebCore::stripLeadingAndTrailingHTMLSpaces):
(WebCore::parseHTMLNonNegativeInteger):
- inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::createSearchRegexSource):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters):
- inspector/InspectorStyleTextEditor.cpp:
(WebCore::InspectorStyleTextEditor::insertProperty):
(WebCore::InspectorStyleTextEditor::internalReplaceProperty):
- platform/Length.cpp:
(WebCore::newCoordsArray):
- platform/LinkHash.cpp:
(WebCore::visitedLinkHash):
- platform/graphics/Color.cpp:
(WebCore::Color::parseHexColor):
(WebCore::Color::Color):
- platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
- platform/text/TextEncodingRegistry.cpp:
(WebCore::atomicCanonicalTextEncodingName):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::constructTextRun):
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::width):
- svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::registerLigaturesInGlyphCache):
- xml/XPathFunctions.cpp:
(WebCore::XPath::FunId::evaluate):
- xml/XPathNodeSet.h:
Source/WTF:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::replace):
- wtf/text/WTFString.h:
(WTF::String::isAllSpecialCharacters):
- 10:18 PM Changeset in webkit [161860] by
-
- 4 edits in trunk/Source
Fix build warnings by unused parameter
https://bugs.webkit.org/show_bug.cgi?id=126867
Reviewed by Gyuyoung Kim.
Source/WebCore:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
(WebCore::IDBServerConnectionLevelDB::changeDatabaseVersion): Remove unused parameter 'operation'.
Source/WebKit/efl:
- WebCoreSupport/EditorClientEfl.h:
(WebCore::EditorClientEfl::checkTextOfParagraph): Remove unused parameter 'checkingTypes'.
- 8:37 PM Changeset in webkit [161859] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for WinCairo.
- WebCore.vcxproj/WebCoreCairo.props: Add missing include path
to locate SelectorCompiler.h.
- 8:31 PM Changeset in webkit [161858] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test maintenance.
- platform/mac/TestExpectations: Re-enable the typedarray/data-view-test.html
WebGL test now that it works properly.
- 8:09 PM Changeset in webkit [161857] by
-
- 7 edits in trunk
[EFL][WK2] Make API tests work again
https://bugs.webkit.org/show_bug.cgi?id=126769
Patch by Sergio Correia <Sergio Correia> on 2014-01-12
Reviewed by Gyuyoung Kim.
The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
[E]WebKit2, respectively, and this causes problems because the logic to find
where WebProcess is to look in the same directory of the running process and
then proceed to use LIBEXECDIR (typically /usr/loca/bin).
This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
Gtk port, which allows us to look for WebProcess initially in this directory,
if it's defined.
.:
- Source/cmake/OptionsEfl.cmake: Define WEBKIT_EXEC_PATH, to be used by
[E]WebKit2 tests.
Source/WebKit2:
- Shared/efl/ProcessExecutablePathEfl.cpp:
(WebKit::findProcessPath): Change the logic to look initially in
WEBKIT_EXEC_PATH, then proceed with the existing checks.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:
(EWK2UnitTest::EWK2UnitTestEnvironment::EWK2UnitTestEnvironment):
Define WEBKIT_EXEC_PATH to be used by EWebKit2 tests.
Tools:
- TestWebKitAPI/efl/main.cpp:
(main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
- 8:03 PM Changeset in webkit [161856] by
-
- 2 edits in trunk/Source/WebKit
Try to fix the Windows build after r161852.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 7:55 PM Changeset in webkit [161855] by
-
- 2 edits in trunk/Source/WTF
Fix an assertion failure in initializeDates() when launching Safari, which was introduced in r161852.
Reviewed by Andy Estes.
- wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading): Set isInitialized to true.
- 7:18 PM Changeset in webkit [161854] by
-
- 2 edits in trunk/Source/WebCore
Fix iOS build breakage from http://trac.webkit.org/changeset/161844
https://bugs.webkit.org/show_bug.cgi?id=126866
Reviewed by Simon Fraser.
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::cursorMovementIterator): Use initializeIterator instead of createSharedIterator,
which does not exist.
- 6:42 PM Changeset in webkit [161853] by
-
- 4 edits in trunk/Source
Add PLATFORM(COCOA) and USE(FOUNDATION)
https://bugs.webkit.org/show_bug.cgi?id=126859
Reviewed by Anders Carlsson.
Source/WebCore:
config.h: Use PLATFORM(COCOA) instead of PLATFORM(MAC) PLATFORM(IOS) to set USE(FILE_LOCK). Would be nice to use OS(DARWIN), but that would be
a change in behavior that might be incorrect. Removed bogus comments in
the USE(NEW_THEME) setting code. Removed redundant code to set USE(CA),
which exactly duplicates code that already exists in Platform.h.
Source/WTF:
- wtf/Platform.h: Added PLATFORM(COCOA), which for now is set at exactly the same
times that PLATFORM(MAC) is. Added USE(FOUNDATION), which is set at the same times
that PLATFORM(COCOA) is. Re-organize the PLATFORM(MAC) and PLATFORM(IOS) settings
in the header so they are a bit easier to read. Put HAVE_LANGINFO_H in with the
rest of the OS(UNIX) settings and put HAVE_READLINE in with the rest of the
OS(DARWIN) settings. Tweak formatting a bit.
- 6:36 PM Changeset in webkit [161852] by
-
- 4 edits in trunk/Source/WTF
Remove AtomicallyInitializedStatic
https://bugs.webkit.org/show_bug.cgi?id=126864
Reviewed by Darin Adler.
- wtf/Threading.h:
- wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
- wtf/ThreadingWin.cpp:
(WTF::initializeThreading):
- 6:29 PM Changeset in webkit [161851] by
-
- 89 edits in trunk/Source
Add deprecatedCharacters as a synonym for characters and convert most call sites
https://bugs.webkit.org/show_bug.cgi?id=126858
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- API/JSStringRef.cpp:
(JSStringGetCharactersPtr):
(JSStringGetUTF8CString):
(JSStringIsEqual):
- API/JSStringRefCF.cpp:
(JSStringCopyCFString):
- API/OpaqueJSString.h:
(OpaqueJSString::characters):
(OpaqueJSString::deprecatedCharacters):
(OpaqueJSString::length):
(OpaqueJSString::OpaqueJSString):
- inspector/InspectorValues.cpp:
(Inspector::InspectorValue::parseJSON):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseInt):
- runtime/StringPrototype.cpp:
(JSC::localeCompare):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
Use deprecatedCharacters instead of characters.
Source/WebCore:
- Modules/indexeddb/IDBKeyPath.cpp:
(WebCore::IDBKeyPathLexer::IDBKeyPathLexer):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::setExtensions):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasMisspelling):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::write):
- dom/CharacterData.cpp:
(WebCore::CharacterData::parserAppendData):
- dom/Document.cpp:
(WebCore::Document::parseQualifiedName):
- editing/Editor.cpp:
(WebCore::Editor::misspelledWordAtCaretOrRange):
(WebCore::Editor::misspelledSelectionString):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
- editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
(WebCore::TextCheckingHelper::findFirstBadGrammar):
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
- editing/TextCheckingHelper.h:
(WebCore::TextCheckingParagraph::textDeprecatedCharacters):
- editing/TextIterator.cpp:
(WebCore::collapsedSpaceLength):
(WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
(WebCore::containsKanaLetters):
(WebCore::SearchBuffer::SearchBuffer):
- editing/TextIterator.h:
(WebCore::TextIterator::characters):
- editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::characterAfter):
- editing/VisibleUnits.cpp:
(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::wordBreakIteratorForMaxOffsetBoundary):
(WebCore::visualWordPosition):
(WebCore::previousBoundary):
(WebCore::nextBoundary):
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::BlobBuilder::append):
- html/FormDataList.cpp:
(WebCore::FormDataList::appendString):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::normalizeSpaces):
- html/parser/HTMLParserIdioms.cpp:
(WebCore::parseImagesWithScaleFromSrcsetAttribute):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
- loader/appcache/ManifestParser.cpp:
(WebCore::parseManifest):
- page/ContentSecurityPolicy.cpp:
(WebCore::isSourceListNone):
(WebCore::CSPSourceList::parse):
(WebCore::NonceDirective::parse):
(WebCore::MediaListDirective::parse):
(WebCore::CSPDirectiveList::parse):
(WebCore::CSPDirectiveList::parseReportURI):
(WebCore::CSPDirectiveList::parseReflectedXSS):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::serializeCSSStyleSheet):
- platform/Length.cpp:
(WebCore::newCoordsArray):
(WebCore::newLengthArray):
- platform/LinkHash.cpp:
(WebCore::visitedURL):
(WebCore::visitedLinkHash):
- platform/SharedBuffer.cpp:
(WebCore::utf8Buffer):
- platform/URL.cpp:
(WebCore::URL::port):
(WebCore::encodeHostnames):
- platform/graphics/StringTruncator.cpp:
(WebCore::centerTruncateToBuffer):
(WebCore::rightTruncateToBuffer):
(WebCore::rightClipToCharacterBuffer):
(WebCore::rightClipToWordBuffer):
(WebCore::leftTruncateToBuffer):
(WebCore::truncateString):
(WebCore::StringTruncator::width):
- platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
- platform/network/FormDataBuilder.cpp:
(WebCore::FormDataBuilder::addFilenameToMultiPartHeader):
- platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::bindBlob):
(WebCore::SQLiteStatement::bindText):
- platform/text/DecodeEscapeSequences.h:
(WebCore::decodeEscapeSequences):
- platform/text/TextBreakIterator.cpp:
(WebCore::numGraphemeClusters):
(WebCore::numCharactersInGraphemeClusters):
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::setUpIteratorWithRules):
- platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::encode):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::constructTextRun):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
- rendering/RenderText.cpp:
(WebCore::maxWordFragmentWidth):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::computeCanUseSimpleFontCodePath):
- rendering/RenderText.h:
(WebCore::RenderText::characters):
(WebCore::RenderText::deprecatedCharacters):
- rendering/line/BreakingContextInlineHeaders.h:
(WebCore::tryHyphenating):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::constructTextRun):
- rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::processRenderSVGInlineText):
- rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
- rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::measureCharacterRange):
(WebCore::SVGTextMetrics::SVGTextMetrics):
- rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):
- svg/SVGAngle.cpp:
(WebCore::SVGAngle::setValueAsString):
- svg/SVGAnimateMotionElement.cpp:
(WebCore::parsePoint):
- svg/SVGAnimationElement.cpp:
(WebCore::parseKeySplines):
- svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::parseViewBox):
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
- svg/SVGGlyphMap.h:
(WebCore::SVGGlyphMap::addGlyph):
(WebCore::SVGGlyphMap::collectGlyphsForString):
- svg/SVGGlyphRefElement.cpp:
(WebCore::SVGGlyphRefElement::parseAttribute):
- svg/SVGLength.cpp:
(WebCore::SVGLength::setValueAsString):
- svg/SVGLengthList.cpp:
(WebCore::SVGLengthList::parse):
- svg/SVGNumberList.cpp:
(WebCore::SVGNumberList::parse):
- svg/SVGParserUtilities.cpp:
(WebCore::parseNumberFromString):
(WebCore::parseNumberOptionalNumber):
(WebCore::parseRect):
(WebCore::pointsListFromSVGData):
(WebCore::parseGlyphName):
(WebCore::parseKerningUnicodeString):
(WebCore::parseDelimitedString):
- svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::parse):
- svg/SVGStringList.cpp:
(WebCore::SVGStringList::parse):
- svg/SVGTransformList.cpp:
(WebCore::SVGTransformList::parse):
- svg/SVGTransformable.cpp:
(WebCore::SVGTransformable::parseTransformType):
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::parseViewSpec):
- svg/SVGZoomAndPan.h:
(WebCore::SVGZoomAndPan::parseAttribute):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
- xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::parseString):
- xml/XSLTUnicodeSort.cpp:
(WebCore::xsltUnicodeSortFunction):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doWrite):
(WebCore::parseAttributes):
Use deprecatedCharacters instead of characters.
Source/WebKit/mac:
- History/BinaryPropertyList.cpp:
(BinaryPropertyListSerializer::appendStringObject):
Use deprecatedCharacters instead of characters.
Source/WebKit2:
- Shared/APIString.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::checkTextOfParagraph):
(WebKit::WebPageProxy::checkSpellingOfString):
(WebKit::WebPageProxy::checkGrammarOfString):
- WebProcess/WebPage/EncoderAdapter.cpp:
(WebKit::EncoderAdapter::encodeString):
Use deprecatedCharacters instead of characters.
Source/WTF:
- wtf/text/AtomicString.cpp:
(WTF::HashAndUTF8CharactersTranslator::equal):
(WTF::SubstringTranslator::hash):
(WTF::SubstringTranslator::equal):
- wtf/text/AtomicString.h:
(WTF::AtomicString::characters):
- wtf/text/Base64.cpp:
(WTF::base64Decode):
(WTF::base64URLDecode):
- wtf/text/StringBuilder.h:
(WTF::StringBuilder::characters):
(WTF::StringBuilder::deprecatedCharacters):
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::upper):
(WTF::StringImpl::lower):
(WTF::StringImpl::find):
(WTF::StringImpl::findIgnoringCase):
- wtf/text/StringImpl.h:
(WTF::StringImpl::characters):
(WTF::StringImpl::deprecatedCharacters):
(WTF::StringImpl::getCharacters<UChar>):
(WTF::equalIgnoringNullity):
- wtf/text/WTFString.cpp:
(WTF::String::append):
(WTF::String::appendInternal):
(WTF::String::insert):
(WTF::String::truncate):
(WTF::String::percentage):
- wtf/text/WTFString.h:
(WTF::String::characters):
(WTF::String::deprecatedCharacters):
(WTF::String::getCharactersWithUpconvert<UChar>):
(WTF::append):
Use deprecatedCharacters instead of characters.
- 6:27 PM Changeset in webkit [161850] by
-
- 9 edits in trunk/Source
Add type checking to isEqual methods
https://bugs.webkit.org/show_bug.cgi?id=126862
Reviewed by Anders Carlsson.
Source/WebCore:
- page/ios/WebEventRegion.mm:
(-[WebEventRegion isEqual:]): Add type checking on the argument.
Add a FIXME about the lack of a hash method override. Formatted to match
the usual WebKit coding style.
Source/WebKit/ios:
- WebCoreSupport/WebVisiblePosition.mm:
(-[WebVisiblePosition isEqual:]): Add type checking on the argument.
Add a FIXME about the lack of a hash method override. Simplified by
removing the unneeded local variables.
Source/WebKit/mac:
- WebCoreSupport/WebSecurityOrigin.mm:
(-[WebSecurityOrigin isEqual:]): Added a FIXME about the lack of a hash method
override. Tweaked formatting.
- WebView/WebDashboardRegion.mm:
(-[WebDashboardRegion isEqual:]): Added type checking on the argument. Added a
FIXME about the lack of a hash method override.
Source/WebKit2:
- UIProcess/API/ios/WKInteractionView.mm:
(-[WKTextRange isEqual:]): Added type checking for the argument. The old
code asserted instead, and it's not clear what guarantees that assertion is
true. Added a FIXME about the lack of a hash method. Added another FIXME
about the fact that this method ignores much of the object state. Removed
an unneeded extra fetch of the isRange property. Deleted some dead code.
(-[WKTextPosition isEqual:]): Ditto.
- 6:23 PM Changeset in webkit [161849] by
-
- 5 edits in trunk/Source
Remove the last remaining uses of AtomicallyInitializedStatic
https://bugs.webkit.org/show_bug.cgi?id=126863
Reviewed by Darin Adler.
Source/WebKit2:
- Shared/mac/SecItemShim.cpp:
(WebKit::responseMap):
Source/WTF:
- wtf/HashTable.cpp:
(WTF::hashTableStatsMutex):
(WTF::HashTableStats::recordCollisionAtCount):
(WTF::HashTableStats::dumpStats):
- wtf/unicode/icu/CollatorICU.cpp:
(WTF::cachedCollatorMutex):
(WTF::Collator::createCollator):
(WTF::Collator::releaseCollator):
- 6:07 PM Changeset in webkit [161848] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the 32-bit build.
- platform/text/icu/UTextProviderLatin1.cpp:
(WebCore::uTextLatin1Clone):
(WebCore::uTextLatin1Extract):
(WebCore::uTextLatin1MapNativeIndexToUTF16):
- 6:01 PM Changeset in webkit [161847] by
-
- 5 edits in trunk/Source/WebCore
Remove all uses of AtomicallyInitializedStatic from WebCore
https://bugs.webkit.org/show_bug.cgi?id=126861
Reviewed by Darin Adler.
- Modules/indexeddb/IDBPendingTransactionMonitor.cpp:
(WebCore::transactions):
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::originMap):
- platform/text/TextEncodingRegistry.cpp:
(WebCore::encodingRegistryMutex):
(WebCore::newTextCodec):
(WebCore::atomicCanonicalTextEncodingName):
(WebCore::dumpTextEncodingNameMap):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::DefaultSharedWorkerRepository::instance):
- 5:44 PM Changeset in webkit [161846] by
-
- 2 edits in trunk/Source/WebCore
Use an std::atomic<uint32_t> when computing IDBDatabase transaction IDs
https://bugs.webkit.org/show_bug.cgi?id=126853
Reviewed by Sam Weinig.
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::nextTransactionId):
- 5:38 PM Changeset in webkit [161845] by
-
- 2 edits in trunk/Tools
[iOS] Fix the build
For now, ensure we build WebKit System Interface before we build WebKit.
We'll remove this constraint and the constraint to build WebKit Additions
in a subsequent commit.
- Scripts/build-webkit:
- 5:28 PM Changeset in webkit [161844] by
-
- 9 edits in trunk/Source/WebCore
TextBreakIterator's should support Latin-1 for all iterator types (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=126856
Reviewed by Darin Adler.
- Do some initial cleanup before adding complete Latin-1 support.
- platform/text/TextBreakIterator.cpp:
Remove non-ICU acquireLineBreakIterator() implementation.
- platform/text/TextBreakIterator.h:
- Changes acquireLineBreakIterator() to take a StringView.
- platform/text/TextBreakIteratorICU.cpp:
- Refactor iterator initialization and setting of text on the iterator.
- Add support for using a Latin-1 provider (this is not currently used).
- platform/text/icu/UTextProviderLatin1.cpp:
- platform/text/icu/UTextProviderLatin1.h:
- Add back non-context aware Latin-1 provider (from r129662).
- Rename context aware provider.
- platform/text/icu/UTextProviderUTF16.cpp:
- platform/text/icu/UTextProviderUTF16.h:
- Rename context aware provider.
- 5:26 PM Changeset in webkit [161843] by
-
- 7 edits in trunk
[WebGL] Error messages should use source code labels, not internal mangled symbols.
https://bugs.webkit.org/show_bug.cgi?id=126832
Reviewed by Dean Jackson.
Source/WebCore:
Revised fast/canvas/webgl/glsl-conformance.html.
- platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::getSymbolInfo): Correct missing 'break'.
(WebCore::ANGLEWebKitBridge::compileShaderSource): Call 'getSymbolInfo'
for SH_VARYINGS.
- platform/graphics/GraphicsContext3D.h: Add new declarations.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::compileShader): Demangle log output.
(WebCore::GraphicsContext3D::mappedSymbolName): Added.
(WebCore::GraphicsContext3D::getUnmangledInfoLog): Added.
(WebCore::GraphicsContext3D::getProgramInfoLog): Demangle log output.
(WebCore::GraphicsContext3D::getShaderInfoLog): Demangle log output.
LayoutTests:
- fast/canvas/webgl/glsl-conformance.html: Add log to program output
showing error message to confirm proper labels are being used.
- fast/canvas/webgl/glsl-conformance-expected.txt: updated.
- 4:57 PM Changeset in webkit [161842] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the Windows build after r161839.
- WebCore.vcxproj/WebCoreCommon.props:
- 3:52 PM Changeset in webkit [161841] by
-
- 2 edits in trunk/Source/ThirdParty
Fix the Mac build after r161777.
- gtest/xcode/Config/General.xcconfig: AspenFamily.xcconfig excludes
macosx from SUPPORTED_PLATFORMS, so add it back in ourselves.
- 3:23 PM Changeset in webkit [161840] by
-
- 29 edits in trunk/Source
Reduce use of String::characters
https://bugs.webkit.org/show_bug.cgi?id=126854
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- API/JSValueRef.cpp:
(JSValueMakeFromJSONString): Use characters16 instead of characters for 16-bit case.
Had to remove length check because an empty string could be either 8 bit or 16 bit.
Don't need a null string check before calling is8Bit because JSStringRef can't hold
a null string.
- bindings/ScriptValue.cpp:
(Deprecated::jsToInspectorValue): Use the existing string here instead of creating
a new one by calling characters and length on the old string. I think this may be
left over from when string types were not the same in JavaScriptCore and WebCore.
Also rewrite the property names loop to use modern for syntax and fewer locals.
- inspector/InspectorValues.cpp:
(Inspector::escapeChar): Changed to use appendLiteral instead of hard-coding string
lengths. Moved handling of "<" and ">" in here instead of at the call site.
(Inspector::doubleQuoteString): Simplify the code so there is no use of characters
and length. This is still an inefficient way of doing this job and could use a rethink.
- runtime/DatePrototype.cpp:
(JSC::formatLocaleDate): Use RetainPtr, createCFString, and the conversion from
CFStringRef to WTF::String to remove a lot of unneeded code.
- runtime/Identifier.h: Removed unneeded Identifier::characters function.
- runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::append): Use characters16 instead of characters function here,
since we have already checked is8Bit above.
Source/WebCore:
- bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):
Get rid of unneeded code to turn a WTF::String into an NSString, since that's
built into the WTF::String class.
- editing/CompositeEditCommand.cpp:
(WebCore::containsOnlyWhitespace): Use WTF::String's [] operator instead of
an explicit call to the characters function. Small performance cost.
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertText): Ditto.
- editing/VisibleUnits.cpp:
(WebCore::startOfParagraph): Use reverseFind instead of writing our own loop.
(WebCore::endOfParagraph): Use find instead of writing our own loop.
- html/parser/HTMLParserIdioms.cpp:
(WebCore::stripLeadingAndTrailingHTMLSpaces): Use characters16 instead of
characters since we have already checked is8Bit.
(WebCore::parseHTMLNonNegativeInteger): Ditto. Replace the length check with
a check of isNull since a zero length string could be 8 bit, but it's not
safe to call is8Bit on a null WTF::String. (That should probably be fixed.)
- inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::createSearchRegexSource): Use StringBuilder
instead of String in code that builds up a string one character at a time.
The old way was ridiculously slow because it allocated a new string for every
character; the new way still isn't all that efficient, but it's better. Also
changed to use strchr instead of WTF::String::find for special characters.
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters): Use WTF::String's
[] operator instead of an explicit call to the characters function.
- inspector/InspectorStyleTextEditor.cpp:
(WebCore::InspectorStyleTextEditor::insertProperty): Ditto.
(WebCore::InspectorStyleTextEditor::internalReplaceProperty): Ditto.
- platform/Length.cpp:
(WebCore::newCoordsArray): Ditto.
- platform/LinkHash.cpp:
(WebCore::visitedLinkHash): Use characters16 instead of characters since
we have already checked is8Bit. Replace the length check with a check of
isNull (as above in parseHTMLNonNegativeInteger).
- platform/graphics/Color.cpp:
(WebCore::Color::parseHexColor): Use characters16 since we already checked is8Bit.
(WebCore::Color::Color): Ditto.
- platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun): Use characters16 instead of characters since
we have already checked is8Bit. Replace the length check with a check of
isNull (as above in parseHTMLNonNegativeInteger).
- platform/text/TextEncodingRegistry.cpp:
(WebCore::atomicCanonicalTextEncodingName): Use characters16 instead of
characters since we already checked is8Bit. Also use isEmpty instead of !length.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::constructTextRun): Use characters16 instead of characters
since we have already checked is8Bit. Replace the length check with a check of
isNull (as above in parseHTMLNonNegativeInteger).
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::width): Check for zero length instead of checking
for null characters.
- svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::registerLigaturesInGlyphCache): Rewrite ligatures
for loop and give local variables a better name. Construct the substring with
the substring function. Still a really inefficient approach -- allocating a new
string for every character is absurdly expensive.
- xml/XPathFunctions.cpp:
(WebCore::XPath::FunId::evaluate): Use String instead of StringBuilder. Still
not all that efficient, but better than before. Use substring to construct the
substring.
- xml/XPathNodeSet.h: Added begin and end functions so we can use a C++11 for
loop with this class.
Source/WTF:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::replace): Use characters16 here since is8Bit was already checked.
- wtf/text/WTFString.h:
(WTF::String::isAllSpecialCharacters): Use characters16 here since is8Bit was
already checked. Also renamed "len" to "length".
- 3:04 PM Changeset in webkit [161839] by
-
- 5 edits12 adds in trunk
Use the Selector Code Generator for matching in SelectorQuery
https://bugs.webkit.org/show_bug.cgi?id=126185
Reviewed by Ryosuke Niwa.
Source/WebCore:
Compile selectors on demand and use the generated binary to perform
element matching in SelectorQuery.
Tests: fast/selectors/querySelector-long-adjacent-backtracking.html
fast/selectors/querySelector-long-child-backtracking.html
fast/selectors/querySelector-mixed-child-adjacent-backtracking.html
fast/selectors/querySelector-multiple-simple-child-backtracking.html
fast/selectors/querySelector-simple-adjacent-backtracking.html
fast/selectors/querySelector-simple-child-backtracking.html
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
(WebCore::SelectorDataList::executeCompiledSelectorCheckerWithContext):
(WebCore::SelectorDataList::execute):
- dom/SelectorQuery.h:
LayoutTests:
Add some tests for longer backtracking cases typically not covered by the other tests.
- fast/selectors/querySelector-long-adjacent-backtracking-expected.txt: Added.
- fast/selectors/querySelector-long-adjacent-backtracking.html: Added.
- fast/selectors/querySelector-long-child-backtracking-expected.txt: Added.
- fast/selectors/querySelector-long-child-backtracking.html: Added.
- fast/selectors/querySelector-mixed-child-adjacent-backtracking-expected.txt: Added.
- fast/selectors/querySelector-mixed-child-adjacent-backtracking.html: Added.
- fast/selectors/querySelector-multiple-simple-child-backtracking-expected.txt: Added.
- fast/selectors/querySelector-multiple-simple-child-backtracking.html: Added.
- fast/selectors/querySelector-simple-adjacent-backtracking-expected.txt: Added.
- fast/selectors/querySelector-simple-adjacent-backtracking.html: Added.
- fast/selectors/querySelector-simple-child-backtracking-expected.txt: Added.
- fast/selectors/querySelector-simple-child-backtracking.html: Added.
- 2:07 PM Changeset in webkit [161838] by
-
- 2 edits in trunk/Source/WebCore
Simplify creation of XMLHttpRequestStaticData
https://bugs.webkit.org/show_bug.cgi?id=126852
Reviewed by Sam Weinig.
Add a staticData() getter that does the initialization and get rid of the explicit
calls to initializeXMLHttpRequestStaticData().
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData):
(WebCore::staticData):
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::isAllowedHTTPHeader):
- 1:38 PM Changeset in webkit [161837] by
-
- 2 edits in trunk/Source/WebCore
Final WebCore link error: update a symbol in WebCoreSystemInterfaceIOS.mm.
- platform/ios/WebCoreSystemInterfaceIOS.mm:
- 1:37 PM Changeset in webkit [161836] by
-
- 2 edits in trunk/Source/WebKit2
Added a reference to WebContentService/Info-OSX.plist to the project.
- WebKit2.xcodeproj/project.pbxproj:
- 1:31 PM Changeset in webkit [161835] by
-
- 2 edits in trunk/Source/WebCore
Use std::call_once instead of AtomicallyInitializedStatic in DatabaseBackendBase
https://bugs.webkit.org/show_bug.cgi?id=126851
Reviewed by Sam Weinig.
- Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::guidMutex):
(WebCore::guidToVersionMap):
(WebCore::updateGuidVersionMap):
(WebCore::guidToDatabaseMap):
(WebCore::guidForOriginAndName):
(WebCore::DatabaseBackendBase::DatabaseBackendBase):
(WebCore::DatabaseBackendBase::closeDatabase):
(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::getCachedVersion):
(WebCore::DatabaseBackendBase::setCachedVersion):
- 1:23 PM Changeset in webkit [161834] by
-
- 2 edits1 move in trunk/Source/WebKit2
OS X build fix.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist: Copied from WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist.
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist: Removed.
- 1:14 PM Changeset in webkit [161833] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the Windows build after r161830.
- platform/network/NetworkStateNotifier.h:
- 1:09 PM Changeset in webkit [161832] by
-
- 2 edits in trunk/Source/WebCore
Don't build JSTouch* and JSGesture* files on Mac.
- Configurations/WebCore.xcconfig:
- 1:04 PM Changeset in webkit [161831] by
-
- 2 edits in trunk/Source/WebKit2
Build Fix: Objective-C GC should be unsupported in iOS WebKit2
- Configurations/Base.xcconfig:
- 12:59 PM Changeset in webkit [161830] by
-
- 3 edits in trunk/Source/WebCore
Clean up NetworkStateNotifier class
https://bugs.webkit.org/show_bug.cgi?id=126850
Reviewed by Andreas Kling.
Use std::call_once instead of AtomicallyInitializedStatic and a std::function
instead of a custom function pointer typedef.
- platform/network/NetworkStateNotifier.cpp:
(WebCore::networkStateNotifier):
(WebCore::NetworkStateNotifier::addNetworkStateChangeListener):
(WebCore::NetworkStateNotifier::notifyNetworkStateChange):
- platform/network/NetworkStateNotifier.h:
- 12:54 PM Changeset in webkit [161829] by
-
- 7 edits2 copies in trunk/Source/WebKit2
[iOS] Upstream WebKit2 xcconfig changes to fix the build
- Configurations/All-iOS.xcconfig: Added.
- Configurations/Base.xcconfig:
- Configurations/BaseLegacyProcess.xcconfig:
- Configurations/BaseTarget.xcconfig:
- Configurations/BaseXPCService.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/WebContentService.xcconfig:
- Configurations/iOS.xcconfig: Added.
- 12:50 PM Changeset in webkit [161828] by
-
- 2 edits in trunk/Source/WebCore
Add implementations of Frame::viewportArguments() and
Frame::setViewportArguments().
- page/ios/FrameIOS.mm:
(WebCore::Frame::viewportArguments):
(WebCore::Frame::setViewportArguments):
- 12:38 PM Changeset in webkit [161827] by
-
- 2 edits in trunk/Source/WebCore
Add JSWebKitPlaybackTargetAvailabilityEvent.* to the project.
- WebCore.xcodeproj/project.pbxproj:
- 12:38 PM Changeset in webkit [161826] by
-
- 2 edits1 add in trunk/Source/WebCore
Stub out some DragImage functions for iOS.
- WebCore.xcodeproj/project.pbxproj:
- platform/ios/DragImageIOS.mm: Added.
(WebCore::dragImageSize):
(WebCore::scaleDragImage):
(WebCore::createDragImageFromImage):
- 12:12 PM Changeset in webkit [161825] by
-
- 2 edits in trunk/Source/WebCore
We need DragImage.cpp code even when ENABLE_DRAG_SUPPORT is
not defined, because these are actually generic snapshotting
functions.
- platform/DragImage.cpp:
- 12:12 PM Changeset in webkit [161824] by
-
- 3 edits in trunk/Source/WebCore
Fix linker errors: add DateTimeFormat.cpp to the project,
and make DateInputType::DateInputType not inline.
- WebCore.xcodeproj/project.pbxproj:
- html/DateInputType.cpp:
(WebCore::DateInputType::DateInputType):
- platform/DragImage.cpp:
- 12:12 PM Changeset in webkit [161823] by
-
- 2 edits in trunk/Source/WebCore
Fix a bunch of linker errors related to exported functions.
I removed some iOS symbols from the .exp.in file; we may have
to add some back.
- WebCore.exp.in:
- 12:12 PM Changeset in webkit [161822] by
-
- 2 edits in trunk/Source/WebCore
Add generated JSTouch* and JSGestureEvent.* files to the project.
- WebCore.xcodeproj/project.pbxproj:
- 12:06 PM Changeset in webkit [161821] by
-
- 3 edits in trunk/Source/WebCore
Move implementation of AuthenticationChallenge::setAuthenticationClient() to source file for USE(CFNETWORK)
<http://webkit.org/b/126848>
Reviewed by Simon Fraser.
- platform/network/cf/AuthenticationCF.cpp:
(WebCore::AuthenticationChallenge::setAuthenticationClient):
Move implementation to here...
- platform/network/cf/AuthenticationChallenge.h: ...from here.
Remove duplicate header definitions inside USE(CFNETWORK).
- 12:04 PM Changeset in webkit [161820] by
-
- 2 edits in trunk/Source/JavaScriptCore
[iOS] Enable the JSC Objective-C API
Rubber-stamped by Simon Fraser.
- API/JSBase.h:
- 11:50 AM Changeset in webkit [161819] by
-
- 2 edits in trunk/Source/WebCore
Fix windows.
- WebCore.vcxproj/WebCore.vcxproj:
- 11:45 AM Changeset in webkit [161818] by
-
- 7 edits in trunk/Source
Replace more uses of AtomicallyInitializedStatic with std::call_once
https://bugs.webkit.org/show_bug.cgi?id=126847
Reviewed by Sam Weinig.
Source/WebCore:
- crypto/CryptoAlgorithmRegistry.cpp:
(WebCore::CryptoAlgorithmRegistry::shared):
(WebCore::registryMutex):
(WebCore::CryptoAlgorithmRegistry::getIdentifierForName):
(WebCore::CryptoAlgorithmRegistry::nameForIdentifier):
(WebCore::CryptoAlgorithmRegistry::create):
(WebCore::CryptoAlgorithmRegistry::registerAlgorithm):
- crypto/CryptoAlgorithmRegistry.h:
- inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::interruptAndDispatchInspectorCommands):
- workers/WorkerThread.cpp:
(WebCore::threadSetMutex):
(WebCore::workerThreads):
(WebCore::WorkerThread::workerThreadCount):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::~WorkerThread):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):
Source/WTF:
- wtf/Forward.h:
Forward declare NeverDestroyed.
- 11:24 AM Changeset in webkit [161817] by
-
- 11 edits7 adds in trunk/Source
Split ICU UText providers out into their own files
https://bugs.webkit.org/show_bug.cgi?id=126834
Reviewed by Anders Carlsson.
Moves the implementation of our custom UText providers out into
their own files.
- UTextProviderLatin1.h/cpp contains the Latin-1 provider.
- UTextProviderUTF16.h/cpp contains the UTF-16 provider.
- UTextProvider.h/cpp contains code common to all the providers.
- CMakeLists.txt:
- GNUmakefile.list.am:
- PlatformGTK.cmake:
- WebCore.vcxproj/WebCoreCommon.props:
- WebCore.vcxproj/copyForwardingHeaders.cmd:
- WebCore.xcodeproj/project.pbxproj:
- platform/text/TextAllInOne.cpp:
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::setUpIterator):
(WebCore::wordBreakIterator):
(WebCore::acquireLineBreakIterator):
(WebCore::sentenceBreakIterator):
(WebCore::setUpIteratorWithRules):
- platform/text/icu: Added.
- platform/text/icu/UTextProvider.cpp: Added.
(WebCore::fixPointer):
(WebCore::uTextCloneImpl):
- platform/text/icu/UTextProvider.h: Added.
(WebCore::uTextProviderContext):
(WebCore::uTextInitialize):
(WebCore::uTextAccessPinIndex):
(WebCore::uTextAccessInChunkOrOutOfRange):
- platform/text/icu/UTextProviderLatin1.cpp: Added.
- platform/text/icu/UTextProviderLatin1.h: Added.
- platform/text/icu/UTextProviderUTF16.cpp: Added.
- platform/text/icu/UTextProviderUTF16.h: Added.
- 11:15 AM Changeset in webkit [161816] by
-
- 13 edits in trunk
Unreviewed. Fix make distcheck.
Source/JavaScriptCore:
- GNUmakefile.am: Add inline-and-minify-stylesheets-and-scripts.py
to EXTRA_DIST and fix InjectedScriptSource.h generation rule.
- GNUmakefile.list.am: Move InjectedScriptSource.h to
built_nosources to make sure it's not disted.
Source/WebCore:
- GNUmakefile.list.am: Add missing files.
Source/WebKit/gtk:
- GNUmakefile.am: Add enum types template files to EXTRA_DIST.
Source/WebKit2:
- GNUmakefile.am: Add WebKit2InspectorGResourceBundle.xml to
EXTRA_DIST.
- GNUmakefile.list.am: Removed deleted files and add missing ones.
- NetworkProcess/unix/NetworkProcessMainUnix.cpp: Move
ProxyResolverSoup.h to EFL platform ifdef, because GTK port doesn't
build the proxy resolver.
Tools:
- gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py
to EXTRA_DIST.
- 11:01 AM Changeset in webkit [161815] by
-
- 2 edits in trunk/Source/WebCore
Fix some CoreVideo linker errors on iOS by softlinking with more CoreVideo
symbols.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
- 10:55 AM Changeset in webkit [161814] by
-
- 3 edits2 adds in trunk
REGRESSION(r160806): line-height is not applied when only present in :link style.
<http://webkit.org/b/126839>
<rdar://problem/15799899>
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/css/line-height-link-style.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::CascadedProperties::Property::apply):
Use the CSSValue for SelectorChecker::MatchLink when applying
style inside a link.
LayoutTests:
- fast/css/line-height-link-style-expected.txt: Added.
- fast/css/line-height-link-style.html: Added.
- 10:47 AM Changeset in webkit [161813] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Fix link errors for iOS: Part 3
- WebCore.exp.in:
- Move some Mac-only symbols to Mac-only section.
- WebCore.xcodeproj/project.pbxproj:
- Add missing references to AuthenticationCF.cpp and CookieJarCFNet.cpp.
- 9:33 AM Changeset in webkit [161812] by
-
- 3 edits in trunk/Source/WebCore
Remove unsafe uses of AtomicallyInitializedStatic
https://bugs.webkit.org/show_bug.cgi?id=126838
Reviewed by Andreas Kling.
AtomicStrings are per thread so any static initialization of them is potentially dangerous
unless it's certain that they're only ever used from the same thread.
This goes against using them with AtomicallyInitializedStatic, so just create AtomicStrings where needed.
(This is highly unlikely to have any real negative performance impact since these two functions
aren't called very frequently).
- loader/CrossOriginAccessControl.cpp:
(WebCore::passesAccessControlCheck):
- page/PerformanceResourceTiming.cpp:
(WebCore::passesTimingAllowCheck):
- 9:29 AM Changeset in webkit [161811] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix link errors for iOS: Part 2
- WebCore.exp.in:
- Move some Mac-only symbols to Mac-only section.
- 9:13 AM Changeset in webkit [161810] by
-
- 2 edits in trunk/Source/WebCore
[iOS] First of many iOS fixes to WebCore.exp.in
- WebCore.exp.in:
- Move some Mac-only symbols to Mac-only section.
- Upstream some changes to iOS-only section.
- 8:56 AM Changeset in webkit [161809] by
-
- 4 edits in trunk/Source/WebCore
[iOS] Don't link to Mac-only frameworks when building iOS
<http://webkit.org/b/126841>
- Configurations/WebCore.xcconfig:
(OTHER_LDFLAGS_iphonesimulator): Remove common frameworks that
are already in the Xcode project.
(OTHER_LDFLAGS_macosx): Add Mac-only frameworks removed from the
Xcode project.
- Configurations/WebCoreTestShim.xcconfig:
(OTHER_LDFLAGS[sdk=macosx*]): Link to Carbon.framework for Mac
since it was removed from the Xcode project.
- WebCore.xcodeproj/project.pbxproj: Remove Mac-only frameworks.
- 8:15 AM Changeset in webkit [161808] by
-
- 7 edits in trunk
Source/WebCore: --disable-dependency-tracking causes build failure due to missing directories
https://bugs.webkit.org/show_bug.cgi?id=94488
Patch by Tobias Mueller <tobiasmue@gnome.org> on 2014-01-12
Reviewed by Gustavo Noronha Silva.
Ensure output directory existing
before generating DerivedSources. This allows for
--disable-dependency-tracking to be run.
- GNUmakefile.am: Added new target DerivedSources/ANGLE which is a directory to be created
- bindings/gobject/GNUmakefile.am: Added new target DerivedSources/webkitdom which is a directory to be created
Source/WebKit/gtk: --disable-dependency-tracking causes build failure due to missing directories
https://bugs.webkit.org/show_bug.cgi?id=94488
Patch by Tobias Mueller <tobiasmue@gnome.org> on 2014-01-12
Reviewed by Gustavo Noronha Silva.
Autotools build fix: Ensure output directory existing
before generating DerivedSources. This allows for
--disable-dependency-tracking to be run.
- GNUmakefile.am: Added a new target of the directory in which files are meant to be stored ($(GENSOURCES_WEBKIT)).
Tools: --disable-dependency-tracking causes build failure due to missing directories
https://bugs.webkit.org/show_bug.cgi?id=94488
Patch by Tobias Mueller <tobiasmue@gnome.org> on 2014-01-12
Reviewed by Gustavo Noronha Silva.
Autotools build fix: Ensure output directory existing
before generating DerivedSources. This allows for
--disable-dependency-tracking to be run.
- WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
- 8:09 AM Changeset in webkit [161807] by
-
- 2 edits in trunk/Source/WebCore
[iOS] WebFontCache is Mac-only
- WebCore.exp.in: Move export to Mac-only section.
- 8:09 AM Changeset in webkit [161806] by
-
- 2 edits2 adds in trunk/Source/WebCore
[iOS] Upstream WebEventRegion.{h|mm} to fix the build
- WebCore.xcodeproj/project.pbxproj: Add to project.
- page/ios/WebEventRegion.h: Added.
- page/ios/WebEventRegion.mm: Added.
(-[WebEventRegion initWithPoints::::]):
(-[WebEventRegion copyWithZone:]):
(-[WebEventRegion description]):
(-[WebEventRegion hitTest:]):
(-[WebEventRegion isEqual:]):
(-[WebEventRegion quad]):
- 12:45 AM Changeset in webkit [161805] by
-
- 4 edits in trunk
[GTK] Fix return value of WebKitDownload::created-destination
https://bugs.webkit.org/show_bug.cgi?id=126741
Reviewed by Martin Robinson.
Source/WebKit2:
WebKitDownload::created-destination signal should be void instead
of gboolean. This doesn't break the API/ABI.
- UIProcess/API/gtk/WebKitDownload.cpp:
(webkit_download_class_init):
(webkitDownloadDestinationCreated):
Tools:
- TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return
value of several callbacks.
Jan 11, 2014:
- 11:31 PM Changeset in webkit [161804] by
-
- 2 edits in trunk/Source/WebKit2
Support bool argument for encoding/decoding invocations.
https://bugs.webkit.org/show_bug.cgi?id=126823
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-11
Reviewed by Sam Weinig.
For remote invocation method argument, current we support int, double and ObjC
object, this patch add support for bool type too.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeInvocation):
(decodeInvocationArguments):
- 11:15 PM Changeset in webkit [161803] by
-
- 3 edits in trunk/WebKitLibraries
[Mac] [Windows] Stop scheduling network requests in WebCore
https://bugs.webkit.org/show_bug.cgi?id=126789
<rdar://problem/15114727>
Update Windows WKSI.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib32/WebKitSystemInterface.lib:
- 11:15 PM Changeset in webkit [161802] by
-
- 2 edits in trunk/Source/WTF
Unreviewed build fix for ports using GCC after r161770.
- wtf/IteratorAdaptors.h:
(WTF::FilterIterator::operator*): Replicating r161797, the const qualifier for
FilterIterator::operator*() is removed since it clashes with some iterator types
that are also const, causing compilation failures with GCC.
- 10:30 PM Changeset in webkit [161801] by
-
- 4 edits in trunk/Source
Use std::call_once instead of AtomicallyInitializedStatic when creating a HTTP header set
https://bugs.webkit.org/show_bug.cgi?id=126837
Reviewed by Sam Weinig.
Source/WebCore:
Use std::call_once when constructing the HTTPHeaderSet.
- loader/CrossOriginAccessControl.cpp:
(WebCore::isOnAccessControlResponseHeaderWhitelist):
Source/WTF:
- wtf/HashSet.h:
(WTF::HashSet::HashSet):
Add a HashSet constructor that takes an initializer list.
- 9:59 PM Changeset in webkit [161800] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Do not link to ApplicationServices.framework for iOS
<http://webkit.org/b/126835>
Reviewed by Dan Bernstein.
- Configurations/WebCore.xcconfig:
(OTHER_LDFLAGS_macosx): Add -framework ApplicationServices.
- WebCore.xcodeproj/project.pbxproj: Remove reference to
ApplicationServices.framework.
- 9:27 PM Changeset in webkit [161799] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Build fix for StyleResolver.cpp
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setCompositionFillColor): Added.
- 8:56 PM Changeset in webkit [161798] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix build of RenderLayerCompositor::registerAllViewportConstrainedLayers()
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers):
Fix use of std::make_unique<>() and add an adoptPtr() call.
- 8:33 PM Changeset in webkit [161797] by
-
- 2 edits in trunk/Source/WTF
Fix the EFL build.
- wtf/IteratorAdaptors.h:
(WTF::TransformIterator::operator*):
- 8:20 PM Changeset in webkit [161796] by
-
- 23 edits in trunk
[Mac] [Windows] Stop scheduling network requests in WebCore
https://bugs.webkit.org/show_bug.cgi?id=126789
<rdar://problem/15114727>
Source/WebCore:
Reviewed by Sam Weinig.
We'll just send all requests to CFNetwork now, along with associated priorities.
- WebCore.exp.in: WebKitSystemInterface functions are changing to support priorities
for more than just pipelining.
- loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::scheduleLoad):
- platform/ios/WebCoreSystemInterfaceIOS.mm:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/network/ResourceHandle.h: For syncronous requests, make it so that they
don't count against HTTP connection limit, to avoid the possibility of hanging the process.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::initializeMaximumHTTPConnectionCountPerHost):
(WebCore::initializeHTTPConnectionSettingsOnStartup):
- platform/network/cf/ResourceRequestCFNet.h:
(WebCore::toPlatformRequestPriority):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
Source/WebKit/mac:
Reviewed by Sam Weinig.
- WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Updated
for new WKSI function names.
Source/WebKit2:
Reviewed by Sam Weinig.
- NetworkProcess/mac/NetworkResourceLoadSchedulerMac.mm:
(WebKit::NetworkResourceLoadScheduler::platformInitializeMaximumHTTPConnectionCountPerHost):
We no longer need the trick with 7 connections, as synchronous requests always have
the right of way.
- UIProcess/API/C/WKContext.cpp: Removed long obsolete functions.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface):
Updated for new WKSI function names.
WebKitLibraries:
Update WKSI.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMavericks.a:
- libWebKitSystemInterfaceMountainLion.a:
- 8:13 PM Changeset in webkit [161795] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Fix build failure in WebCore::findEndWordBoundary()
Filed Bug 126830 for the proper fix:
<http://webkit.org/b/126830>
- editing/VisibleUnits.cpp:
(WebCore::endWordBoundary): Switch back to using
WebCore::findWordBoundary() on iOS.
- platform/text/mac/TextBoundaries.mm:
(WebCore::findEndWordBoundary): Add FIXME for iOS implementation
that doesn't use NSAttributedString.
- 7:53 PM Changeset in webkit [161794] by
-
- 3 edits1 add in trunk/LayoutTests
[WebGL] Correct uniform input validation for texture sampler uniforms
https://bugs.webkit.org/show_bug.cgi?id=126775
Reviewed by Anders Carlsson.
- fast/canvas/webgl/uniform-samplers-test-expected.txt: Added.
- fast/canvas/webgl/uniform-samplers-test.html: Corrected resource
includes when moving from khronos suite to our fast suite.
- resources/js-test-pre.js:
(expectTrue): Added.
- 7:23 PM Changeset in webkit [161793] by
-
- 3 edits in trunk/Source/JavaScriptCore
Try again to fix the build.
- inspector/InspectorAgentRegistry.cpp:
- inspector/InspectorAgentRegistry.h:
- 7:00 PM Changeset in webkit [161792] by
-
- 3 edits in trunk/Source/JavaScriptCore
Try to prevent the Vector copy constructor from being instantiated.
- inspector/InspectorAgentRegistry.cpp:
(Inspector::InspectorAgentRegistry::InspectorAgentRegistry):
- inspector/InspectorAgentRegistry.h:
- 6:56 PM Changeset in webkit [161791] by
-
- 3 edits in trunk/Source/JavaScriptCore
Try something else.
- inspector/InspectorAgentRegistry.cpp:
(Inspector::InspectorAgentRegistry::~InspectorAgentRegistry):
- inspector/InspectorAgentRegistry.h:
- 6:51 PM Changeset in webkit [161790] by
-
- 6 edits in trunk/Source/WebCore
[iOS] Move text autosizing code from RenderBlock to RenderBlockFlow
https://bugs.webkit.org/show_bug.cgi?id=126829
Reviewed by Sam Weinig.
Some newly-upstreamed iOS text autosizing code needs to move to
RenderBlockFlow in order to build.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::RenderBlockFlow):
(WebCore::isVisibleRenderText):
(WebCore::resizeTextPermitted):
(WebCore::RenderBlockFlow::immediateLineCount):
(WebCore::isNonBlocksOrNonFixedHeightListItems):
(WebCore::oneLineTextMultiplier):
(WebCore::textMultiplier):
(WebCore::RenderBlockFlow::adjustComputedFontSizes):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::resetComputedFontSize):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::adjustComputedFontSizesOnBlocks):
(WebCore::RenderObject::resetTextAutosizing):
- 6:51 PM Changeset in webkit [161789] by
-
- 5 edits3 adds in trunk
[JSC] Revise typed array implementations to match ECMAScript and WebGL Specification
https://bugs.webkit.org/show_bug.cgi?id=126754
Patch by Dean Jackson <dino@apple.com> on 2014-01-11
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
The ECMAScript specification forbids calling the typed array
constructors without using "new". Change the call data to return
none so we throw and exception in these cases.
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):
LayoutTests:
New test which checks that we throw an exception when calling
any of the typed array constructors without using "new".
- js/script-tests/typedarray-constructors.js: Added.
- js/typedarray-constructors-expected.txt: Added.
- js/typedarray-constructors.html: Added.
- resources/standalone-pre.js: Add missing 'shouldNotThrow'
method (duplicated from resources/js-test-pre.js)
- 6:49 PM Changeset in webkit [161788] by
-
- 3 edits in trunk/Source/JavaScriptCore
Try to fix the build by introducing a constructor.
- inspector/InspectorAgentRegistry.cpp:
(Inspector::InspectorAgentRegistry::InspectorAgentRegistry):
- inspector/InspectorAgentRegistry.h:
- 6:43 PM Changeset in webkit [161787] by
-
- 2 edits in trunk/Source/JavaScriptCore
- inspector/InspectorAgentRegistry.h:
Remove an unused function.
- 6:25 PM Changeset in webkit [161786] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix the build
Only call CGContextFlush() when building for OS X < 10.9.
- platform/graphics/cg/ImageBufferBackingStoreCache.cpp:
(WebCore::ImageBufferBackingStoreCache::deallocate):
- 5:54 PM Changeset in webkit [161785] by
-
- 4 edits1 add in trunk
Add support for null StringViews
https://bugs.webkit.org/show_bug.cgi?id=126827
Reviewed by Anders Carlsson.
Source/WTF:
- Do some style cleanup while in the neighborhood.
- wtf/text/StringView.h:
(WTF::StringView::StringView):
Add default constructor to create a null StringView.
(WTF::StringView::isNull):
Add isNull(), matching the semantics of String.
(WTF::StringView::operator bool):
Add an explicit operator bool() to allow use in if-statements.
Tools:
Add new test for StringView.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/StringView.cpp: Added.
(TestWebKitAPI::TEST):
- 4:54 PM Changeset in webkit [161784] by
-
- 39 edits in trunk/Source
InspectorAgentRegistry should use std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=126826
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- inspector/InspectorAgentRegistry.cpp:
(Inspector::InspectorAgentRegistry::append):
- inspector/InspectorAgentRegistry.h:
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
- inspector/agents/InspectorAgent.h:
Source/WebCore:
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorCSSAgent.h:
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMDebuggerAgent.cpp:
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMStorageAgent.h:
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorHeapProfilerAgent.cpp:
- inspector/InspectorHeapProfilerAgent.h:
- inspector/InspectorIndexedDBAgent.h:
- inspector/InspectorInputAgent.h:
- inspector/InspectorLayerTreeAgent.h:
- inspector/InspectorMemoryAgent.cpp:
- inspector/InspectorMemoryAgent.h:
- inspector/InspectorPageAgent.cpp:
- inspector/InspectorPageAgent.h:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::create):
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorResourceAgent.h:
- inspector/InspectorTimelineAgent.h:
- inspector/InspectorWorkerAgent.cpp:
- inspector/InspectorWorkerAgent.h:
- inspector/PageConsoleAgent.h:
- inspector/PageDebuggerAgent.cpp:
- inspector/PageDebuggerAgent.h:
- inspector/PageRuntimeAgent.h:
- inspector/WorkerConsoleAgent.h:
- inspector/WorkerDebuggerAgent.cpp:
- inspector/WorkerDebuggerAgent.h:
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
- inspector/WorkerRuntimeAgent.h:
- 2:56 PM Changeset in webkit [161783] by
-
- 8 edits1 copy1 add in trunk/Source/WebCore
Extract the FormatConverter class out of GraphicsContext3D.cpp and into its own file
https://bugs.webkit.org/show_bug.cgi?id=126820
Patch by Sam Weinig <sam@webkit.org> on 2014-01-11
Reviewed by Anders Carlsson.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/FormatConverter.cpp: Copied from Source/WebCore/platform/graphics/GraphicsContext3D.cpp.
(WebCore::convertFloatToHalfFloat):
(WebCore::FormatConverter::convert):
- platform/graphics/FormatConverter.h: Copied from Source/WebCore/platform/graphics/GraphicsContext3D.cpp.
(WebCore::FormatConverter::FormatConverter):
(WebCore::FormatConverter::success):
- platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):
(WebCore::GraphicsContext3D::computeImageSizeInBytes):
(WebCore::GraphicsContext3D::packImageData):
(WebCore::GraphicsContext3D::extractImageData):
(WebCore::GraphicsContext3D::extractTextureData):
(WebCore::GraphicsContext3D::packPixels):
- platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::hasAlpha):
(WebCore::GraphicsContext3D::hasColor):
- 1:58 PM Changeset in webkit [161782] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
Eliminate obviously redundant InvalidationPoints
https://bugs.webkit.org/show_bug.cgi?id=126825
Not yet reviewed.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::invalidationPointElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- 1:03 PM Changeset in webkit [161781] by
-
- 1 edit1 add in branches/jsCStack/Source/JavaScriptCore
Unreviewed, add a test for InvalidationPoint in the FTL.
Probably there are other tests that cover this in various ways and it's possible
that we're just not running those tests in the FTL, yet. But anyway I think it's
good to have an FTL-specific test for this.
- tests/stress/invalidation-point.js: Added.
(foo):
(Thingy):
(Thingy.prototype.f):
(possiblyDoBadThings.Thingy.prototype.f):
(possiblyDoBadThings):
- 12:59 PM Changeset in webkit [161780] by
-
- 2 edits in trunk/Source/WebCore
Fix updateScrollingLayerWithClient() for iOS.
- rendering/RenderLayerCompositor.cpp:
(WebCore::updateScrollingLayerWithClient):
- 12:59 PM Changeset in webkit [161779] by
-
- 11 edits in trunk/Source
Unfork GraphicsContext::drawNativeImage for iOS
https://bugs.webkit.org/show_bug.cgi?id=126824
Reviewed by Dean Jackson.
GraphicsContext::drawNativeImage had a different signature for iOS,
which required #ifdefs at all the call sites. Unfork by passing the "scale"
parameter everywhere (it's only used on iOS).
Source/WebCore:
- WebCore.exp.in:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
- platform/graphics/GraphicsContext.h:
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::BitmapImage::draw):
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::paintToCanvas):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformInit):
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::draw):
- platform/graphics/ios/IconIOS.mm:
(WebCore::Icon::paint):
Source/WebKit2:
- Shared/API/c/cg/WKImageCG.cpp:
(WKImageCreateFromCGImage):
- 12:59 PM Changeset in webkit [161778] by
-
- 2 edits in trunk/Source/WebCore
Work around USE(CFNETWORK) build failure on iOS.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForResponseToAuthenticationChallenge):
- 12:56 PM Changeset in webkit [161777] by
-
- 3 edits1 add in trunk/Source/ThirdParty
[iOS] Upstream gtest
<http://webkit.org/b/126811>
Reviewed by Mark Rowe.
- gtest/xcode/Config/General.xcconfig: Include iOS.xcconfig.
- gtest/xcode/Config/iOS.xcconfig: Added.
- gtest/xcode/gtest.xcodeproj/project.pbxproj: Add iOS.xcconfig.
Sort.
- 12:31 PM Changeset in webkit [161776] by
-
- 4 edits in branches/jsCStack/Source/JavaScriptCore
FTL tier-up should behave the same with CountExecution's as it does without
https://bugs.webkit.org/show_bug.cgi?id=126822
Not yet reviewed.
CountExecution nodes are inserted by the profiler. Prior to this change, their
presence would change how we inserted CheckTierUp nodes, since a CountExecution
might be inserted before a LoopHint thereby making it so the LoopHint was no
longer at the top of a loop header. This makes the code resilient against such
things. The result is that when you enable the profiler, you get the same OSR
behavior as with the profiler disabled.
- dfg/DFGNode.h:
(JSC::DFG::Node::isSemanticallySkippable):
- dfg/DFGOSREntrypointCreationPhase.cpp:
(JSC::DFG::OSREntrypointCreationPhase::run):
- dfg/DFGTierUpCheckInjectionPhase.cpp:
(JSC::DFG::TierUpCheckInjectionPhase::run):
- 12:05 PM Changeset in webkit [161775] by
-
- 2 edits in trunk/Source/WebCore
Fix LegacyWebArchive.cpp:567:91: error: calling 'utf8' with incomplete return type 'WTF::CString'
- loader/archive/cf/LegacyWebArchive.cpp:
- 12:03 PM Changeset in webkit [161774] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix the easy half of the build errors in RenderBlock.cpp
- rendering/RenderBlock.cpp:
(WebCore::isNonBlocksOrNonFixedHeightListItems):
(WebCore::oneLineTextMultiplier):
(WebCore::textMultiplier):
(WebCore::RenderBlock::adjustComputedFontSizes):
- 11:56 AM Changeset in webkit [161773] by
-
- 7 edits in trunk/Source/WebCore
Change touch-related headers to include WebKitAdditions headers,
which have been renamed to have IOS suffixes.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ios/TouchConstructors.cpp:
- dom/Touch.h:
- dom/TouchEvent.h:
- dom/TouchList.h:
- dom/ios/TouchEvents.cpp:
- 11:48 AM Changeset in webkit [161772] by
-
- 2 edits in trunk
[Mac] xcodebuild color output is suppressed when using make
https://bugs.webkit.org/show_bug.cgi?id=126815
Reviewed by Anders Carlsson.
WHen using make, xcodebuild’s output is piped through a filter, which causes it not to
format its output with color and emphasis.
- Makefile.shared: Pass COLOR_DIAGNOSTICS=YES to xcodebuild to force color output on. Due to
xcodebuild limitations, this restores some of the formatting, but not all of it.
- 11:31 AM Changeset in webkit [161771] by
-
- 8 edits in trunk/Source/WebCore
ScriptDebugServer should use a separate member function for its timer handler
https://bugs.webkit.org/show_bug.cgi?id=126819
Reviewed by Sam Weinig.
It's weird to have subclasses override a timer handler and sometimes invoke
the timer handler directly so make it a separate member function instead.
- bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::recompileAllJSFunctions):
- bindings/js/PageScriptDebugServer.h:
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::recompileAllJSFunctionsTimerFired):
- bindings/js/ScriptDebugServer.h:
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
- bindings/js/WorkerScriptDebugServer.h:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::start):
- 11:17 AM Changeset in webkit [161770] by
-
- 10 edits2 moves in trunk/Source
Clean up iterator filter / iterator range code
https://bugs.webkit.org/show_bug.cgi?id=126817
Reviewed by Anders Carlsson.
Source/WebKit2:
- Shared/APIArray.h:
Update elementsOfType() to use combination of FilterIterator and TransformIterator
(now that FilterIterator no longer has a transform predicate) and make use of the
makeFoo() helpers.
Source/WTF:
- Renames IteratorPair to IteratorRange.
- Splits FilterIterator into FilterIterator (which now only filters) and TransformIterator (which does the transform part of the old FilterIterator). Move both of these to IteratorAdaptors.h
- GNUmakefile.list.am:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/FilterIterator.h: Removed.
Add/remove files.
- wtf/HashMap.h:
(WTF::HashMap::keys):
(WTF::HashMap::values):
- wtf/RefPtrHashMap.h:
Update for rename to IteratorRange. Simplify by using makeIteratorRange().
- wtf/IteratorAdaptors.h: Copied from wtf/FilterIterator.h.
(WTF::FilterIterator::FilterIterator):
(WTF::FilterIterator::operator*):
(WTF::makeFilterIterator):
(WTF::TransformIterator::TransformIterator):
(WTF::TransformIterator::operator++):
(WTF::TransformIterator::operator*):
(WTF::TransformIterator::operator==):
(WTF::TransformIterator::operator!=):
(WTF::makeTransformIterator):
Split up filtering and transforming. Add makeFilterIterator() and makeTransformIterator()
helpers.
- wtf/IteratorPair.h: Removed.
- wtf/IteratorRange.h: Copied from wtf/IteratorPair.h.
(WTF::IteratorRange::IteratorRange):
(WTF::makeIteratorRange):
Renamed to IteratorRange and adds makeIteratorRange() helper.
- 11:16 AM Changeset in webkit [161769] by
-
- 4 edits in trunk/Source
Simplify Timer and DeferrableOneShotTimer using std::function
https://bugs.webkit.org/show_bug.cgi?id=126816
Reviewed by Sam Weinig.
Source/WebCore:
- platform/Timer.h:
(WebCore::Timer::Timer):
Source/WebKit2:
Add another unexported symbol.
- Configurations/WebKit2.xcconfig:
- 10:19 AM Changeset in webkit [161768] by
-
- 133 edits in trunk/Source/WebCore
CTTE Timer and DeferrableOneShotTimer
https://bugs.webkit.org/show_bug.cgi?id=126814
Reviewed by Antti Koivisto.
Add new Timer and DeferrableOneShotTimer constructors whose member function pointers
take a reference instead of a pointer.
Also, convert a bunch of classes over to using these new constructors.
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::keyRequestTimerFired):
(WebCore::MediaKeySession::addKeyTimerFired):
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::GeoNotifier::timerFired):
(WebCore::Geolocation::resumeTimerFired):
- Modules/geolocation/Geolocation.h:
- Modules/indexeddb/IDBTransactionBackend.cpp:
(WebCore::IDBTransactionBackend::taskTimerFired):
- Modules/indexeddb/IDBTransactionBackend.h:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::appendBufferTimerFired):
- Modules/mediasource/SourceBuffer.h:
- Modules/notifications/Notification.cpp:
(WebCore::Notification::taskTimerFired):
- Modules/notifications/Notification.h:
- Modules/notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::NotificationRequestCallback::timerFired):
- Modules/notifications/NotificationCenter.h:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::notificationPostTimerFired):
- accessibility/AXObjectCache.h:
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::beginLoadTimerFired):
- css/CSSFontSelector.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::evictionTimerFired):
- css/CSSImageGeneratorValue.h:
- dom/Document.cpp:
(WebCore::Document::visualUpdatesSuppressionTimerFired):
(WebCore::Document::styleRecalcTimerFired):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::sharedObjectPoolClearTimerFired):
(WebCore::Document::styleResolverThrowawayTimerFired):
(WebCore::Document::updateFocusAppearanceTimerFired):
(WebCore::Document::resetHiddenFocusElementTimer):
(WebCore::Document::pendingTasksTimerFired):
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::loadEventDelayTimerFired):
(WebCore::Document::didAssociateFormControlsTimerFired):
- dom/Document.h:
- dom/EventSender.h:
(WebCore::EventSender::timerFired):
- dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueue::timerFired):
- dom/GenericEventQueue.h:
- dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::timerFired):
- dom/ScriptRunner.h:
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::animationTimerFired):
- dom/ScriptedAnimationController.h:
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::timerFired):
- editing/AlternativeTextController.h:
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::caretBlinkTimerFired):
- editing/FrameSelection.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- html/HTMLMediaElement.h:
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::swapRendererTimerFired):
- html/HTMLPlugInElement.h:
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired):
(WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired):
- html/HTMLPlugInImageElement.h:
- html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::errorEventTimerFired):
- html/HTMLSourceElement.h:
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::loadTimerFired):
- html/HTMLTrackElement.h:
- html/MediaController.cpp:
(MediaController::asyncEventTimerFired):
(MediaController::clearPositionTimerFired):
(MediaController::timeupdateTimerFired):
- html/MediaController.h:
- html/MediaDocument.cpp:
(WebCore::MediaDocument::replaceMediaElementTimerFired):
- html/MediaDocument.h:
- html/parser/HTMLParserScheduler.cpp:
(WebCore::HTMLParserScheduler::continueNextChunkTimerFired):
- html/parser/HTMLParserScheduler.h:
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlSeekButtonElement::seekTimerFired):
- html/shadow/MediaControlElementTypes.h:
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::transitionTimerFired):
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::hideFullscreenControlsTimerFired):
- html/shadow/MediaControls.h:
- html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::loadTimerFired):
- html/track/LoadableTextTrack.h:
- inspector/InspectorCSSAgent.cpp:
(WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::timerFired):
(WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask):
(WebCore::ChangeRegionOversetTask::timerFired):
- inspector/InspectorDOMAgent.cpp:
(WebCore::RevalidateStyleAttributeTask::RevalidateStyleAttributeTask):
(WebCore::RevalidateStyleAttributeTask::timerFired):
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorBackendDispatchTask::InspectorBackendDispatchTask):
(WebCore::InspectorBackendDispatchTask::timerFired):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkTimerFired):
- loader/FrameLoader.h:
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::timerFired):
- loader/ImageLoader.h:
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::linkLoadTimerFired):
(WebCore::LinkLoader::linkLoadingErrorTimerFired):
- loader/LinkLoader.h:
- loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::timerFired):
- loader/NavigationScheduler.h:
- loader/PingLoader.cpp:
(WebCore::PingLoader::PingLoader):
- loader/PingLoader.h:
(WebCore::PingLoader::timeoutTimerFired):
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::progressHeartbeatTimerFired):
- loader/ProgressTracker.h:
- loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::requestTimerFired):
- loader/ResourceLoadScheduler.h:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::decodedDataDeletionTimerFired):
(WebCore::CachedResource::CachedResourceCallback::timerFired):
- loader/cache/CachedResource.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
- loader/cache/CachedResourceLoader.h:
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::syncTimerFired):
- loader/icon/IconDatabase.h:
- page/AutoscrollController.cpp:
(WebCore::AutoscrollController::autoscrollTimerFired):
- page/AutoscrollController.h:
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::timerFired):
- page/CaptionUserPreferences.h:
- page/DeviceController.cpp:
(WebCore::DeviceController::fireDeviceEvent):
- page/DeviceController.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::cursorUpdateTimerFired):
(WebCore::EventHandler::autoHideCursorTimerFired):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
(WebCore::EventHandler::hoverTimerFired):
- page/EventHandler.h:
- page/EventSource.cpp:
(WebCore::EventSource::connectTimerFired):
- page/EventSource.h:
- page/FrameView.cpp:
(WebCore::FrameView::deferredRepaintTimerFired):
(WebCore::FrameView::layoutTimerFired):
(WebCore::FrameView::postLayoutTimerFired):
- page/FrameView.h:
- page/PageThrottler.cpp:
(WebCore::PageThrottler::throttleHysteresisTimerFired):
- page/PageThrottler.h:
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
(WebCore::AnimationControllerPrivate::animationTimerFired):
- page/animation/AnimationControllerPrivate.h:
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::autoscrollTimerFired):
- platform/Scrollbar.h:
- platform/Timer.h:
(WebCore::Timer::Timer):
(WebCore::DeferrableOneShotTimer::DeferrableOneShotTimer):
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::advanceAnimation):
- platform/graphics/BitmapImage.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::reloadTimerFired):
- platform/graphics/MediaPlayer.h:
- platform/graphics/ca/mac/LayerPool.h:
- platform/graphics/ca/mac/LayerPool.mm:
(WebCore::LayerPool::pruneTimerFired):
- platform/graphics/cg/ImageBufferBackingStoreCache.cpp:
(WebCore::ImageBufferBackingStoreCache::timerFired):
- platform/graphics/cg/ImageBufferBackingStoreCache.h:
- platform/graphics/cg/SubimageCacheWithTimer.cpp:
(WebCore::SubimageCacheWithTimer::invalidateCacheTimerFired):
- platform/graphics/cg/SubimageCacheWithTimer.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::seekTimerFired):
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):
- platform/mock/DeviceOrientationClientMock.cpp:
(WebCore::DeviceOrientationClientMock::timerFired):
- platform/mock/DeviceOrientationClientMock.h:
- platform/network/NetworkStateNotifier.h:
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::failureTimerFired):
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/mac/NetworkStateNotifierMac.cpp:
(WebCore::NetworkStateNotifier::networkStateChangeTimerFired):
- rendering/ImageQualityController.cpp:
(WebCore::ImageQualityController::highQualityRepaintTimerFired):
- rendering/ImageQualityController.h:
- rendering/RenderButton.cpp:
(WebCore::RenderButton::timerFired):
- rendering/RenderButton.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::layerFlushTimerFired):
(WebCore::RenderLayerCompositor::paintRelatedMilestonesTimerFired):
- rendering/RenderLayerCompositor.h:
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::timerFired):
- rendering/RenderMarquee.h:
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::regionLayoutUpdateEventTimerFired):
(WebCore::RenderNamedFlowThread::regionOversetChangeEventTimerFired):
- rendering/RenderNamedFlowThread.h:
- rendering/RenderProgress.cpp:
(WebCore::RenderProgress::animationTimerFired):
- rendering/RenderProgress.h:
- 8:58 AM Changeset in webkit [161767] by
-
- 4 edits in trunk/Source/WebCore
- dom/Touch.h:
- dom/TouchEvent.h:
- dom/TouchList.h:
- 8:58 AM Changeset in webkit [161766] by
-
- 3 edits in trunk/Source/WebCore
No need to include <ApplicationServices/ApplicationServices.h> in
the header. Can use <CoreGraphics/CoreGraphics.h> in the .cpp file.
- platform/graphics/cg/ImageBufferBackingStoreCache.cpp:
- platform/graphics/cg/ImageBufferBackingStoreCache.h:
- 8:58 AM Changeset in webkit [161765] by
-
- 4 edits in trunk/Source/WebCore
Fix DOM headers: TARGET_OS_EMBEDDED -> TARGET_OS_IPHONE
and a drive-by cleanup of DOMUIKitExtensions.mm #includes.
- bindings/objc/DOMPrivate.h:
- bindings/objc/DOMUIKitExtensions.h:
- bindings/objc/DOMUIKitExtensions.mm:
- 8:29 AM Changeset in webkit [161764] by
-
- 2 edits in trunk/Source/WebCore
Fix use of GL_HALF_FLOAT_ARB on iOS.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::texSubImage2D):
- 8:29 AM Changeset in webkit [161763] by
-
- 2 edits in trunk/Source/WebCore
Fix build of SourceBufferPrivateAVFObjC.mm on iOS.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
- 8:29 AM Changeset in webkit [161762] by
-
- 2 edits in trunk/Source/WebCore
Fix use of nonexistent kCGColorSpaceSRGB on iOS.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::sRGBColorSpaceRef):
- 7:51 AM Changeset in webkit [161761] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Some ScriptDebugServer Cleanup
https://bugs.webkit.org/show_bug.cgi?id=126793
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-11
Reviewed by Timothy Hatcher.
- bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::didContinue):
(WebCore::PageScriptDebugServer::runEventLoopWhilePaused):
Move the special iOS WebThread EventLoop nesting handling here.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::handlePause):
- bindings/js/ScriptDebugServer.h:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorDebuggerAgent.h:
Remove unused headers and functions.
- 6:17 AM Changeset in webkit [161760] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Add USE(IOSURFACE_CANVAS_BACKING_STORE) to fix build
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer): The 'width' and 'height'
variables are only used by code protected by
USE(IOSURFACE_CANVAS_BACKING_STORE).
- 5:02 AM Changeset in webkit [161759] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Multisampling is not available on iOS
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- 12:52 AM Changeset in webkit [161758] by
-
- 23 edits in trunk/Source/WebKit2
[EFL][WK2] Use nullptr instead of 0 in EFL API layer
https://bugs.webkit.org/show_bug.cgi?id=126806
Reviewed by Anders Carlsson.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::create):
- UIProcess/API/efl/ewk_auth_request.cpp:
(ewk_auth_request_suggested_username_get):
(ewk_auth_request_realm_get):
(ewk_auth_request_host_get):
- UIProcess/API/efl/ewk_back_forward_list.cpp:
(ewk_back_forward_list_current_item_get):
(ewk_back_forward_list_previous_item_get):
(ewk_back_forward_list_next_item_get):
(ewk_back_forward_list_item_at_index_get):
(ewk_back_forward_list_n_back_items_copy):
(ewk_back_forward_list_n_forward_items_copy):
- UIProcess/API/efl/ewk_back_forward_list_item.cpp:
(ewk_back_forward_list_item_url_get):
(ewk_back_forward_list_item_title_get):
(ewk_back_forward_list_item_original_url_get):
- UIProcess/API/efl/ewk_context.cpp:
(ewk_context_cookie_manager_get):
(ewk_context_database_manager_get):
(ewk_context_favicon_database_get):
(ewk_context_storage_manager_get):
(ewk_context_new_with_injected_bundle_path):
- UIProcess/API/efl/ewk_context_menu.cpp:
(ewk_context_menu_items_get):
- UIProcess/API/efl/ewk_context_menu_item.cpp:
(ewk_context_menu_item_new_with_submenu):
(ewk_context_menu_item_title_get):
(ewk_context_menu_item_parent_menu_get):
(ewk_context_menu_item_submenu_get):
- UIProcess/API/efl/ewk_download_job.cpp:
(ewk_download_job_request_get):
(ewk_download_job_response_get):
(ewk_download_job_destination_get):
(ewk_download_job_suggested_filename_get):
- UIProcess/API/efl/ewk_error.cpp:
(ewk_error_url_get):
(ewk_error_description_get):
- UIProcess/API/efl/ewk_file_chooser_request.cpp:
(ewk_file_chooser_request_accepted_mimetypes_get):
- UIProcess/API/efl/ewk_form_submission_request.cpp:
(ewk_form_submission_request_field_names_get):
(ewk_form_submission_request_field_value_get):
- UIProcess/API/efl/ewk_navigation_data.cpp:
(ewk_navigation_data_title_get):
(ewk_navigation_data_original_request_get):
(ewk_navigation_data_url_get):
- UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
(ewk_navigation_policy_frame_name_get):
(ewk_navigation_policy_request_get):
- UIProcess/API/efl/ewk_object.cpp:
(ewk_object_ref):
- UIProcess/API/efl/ewk_popup_menu.cpp:
(ewk_popup_menu_items_get):
- UIProcess/API/efl/ewk_popup_menu_item.cpp:
(ewk_popup_menu_item_text_get):
(ewk_popup_menu_item_tooltip_get):
(ewk_popup_menu_item_accessibility_text_get):
- UIProcess/API/efl/ewk_security_origin.cpp:
(ewk_security_origin_host_get):
(ewk_security_origin_protocol_get):
- UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_default_text_encoding_name_get):
- UIProcess/API/efl/ewk_url_request.cpp:
(ewk_url_request_url_get):
(ewk_request_cookies_first_party_get):
(ewk_url_request_http_method_get):
- UIProcess/API/efl/ewk_url_response.cpp:
(ewk_url_response_url_get):
(ewk_url_response_mime_type_get):
- UIProcess/API/efl/ewk_url_scheme_request.cpp:
(ewk_url_scheme_request_scheme_get):
(ewk_url_scheme_request_url_get):
(ewk_url_scheme_request_path_get):
- UIProcess/API/efl/ewk_view.cpp:
(toEwkViewChecked):
(EWKViewGetWKView):
(ewk_view_smart_add):
(ewk_view_add_with_context):
(ewk_view_context_get):
(ewk_view_page_group_get):
(ewk_view_url_get):
(ewk_view_favicon_get):
(ewk_view_settings_get):
(ewk_view_title_get):
(ewk_view_theme_get):
(ewk_view_back_forward_list_get):
(ewk_view_custom_encoding_get):
(ewk_view_user_agent_get):
- 12:34 AM Changeset in webkit [161757] by
-
- 5 edits in tags/Safari-538.10.3/Source
Versioning.
- 12:31 AM Changeset in webkit [161756] by
-
- 1 copy in tags/Safari-538.10.3
New tag.
- 12:11 AM Changeset in webkit [161755] by
-
- 2 edits in trunk/Source/WebKit/efl
Build fix.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::progressStarted):
Jan 10, 2014:
- 11:43 PM Changeset in webkit [161754] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix build for HTMLImageElement::willRespondToMouseClickEvents()
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::willRespondToMouseClickEvents):
- 11:38 PM Changeset in webkit [161753] by
-
- 2 edits in trunk/Source/WebCore
Fix test crashes.
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::~ProgressTracker):
Comment out the call to progressTrackerDestroyed for now.
- 11:34 PM Changeset in webkit [161752] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix build for RenderEmbeddedObject::canHaveChildren()
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::canHaveChildren):
- 11:33 PM Changeset in webkit [161751] by
-
- 19 edits in trunk/Source
Tweak ProgressTrackerClient functions
https://bugs.webkit.org/show_bug.cgi?id=126808
Reviewed by Sam Weinig.
Source/WebCore:
Rename the three progress state related member functions since it's up to the various
WebKit implementations to decide what to do - not everyone wants to post a notification.
Also add an originating progress frame parameter since WebKit2 doesn't report progress for
subframe navigation and we need to be able to keep track of that.
Finally, tweak ProgressTracker::completeProgress to get rid of an unnecessary hash lookup.
- loader/EmptyClients.h:
- loader/ProgressTracker.cpp:
(WebCore::ProgressItem::ProgressItem):
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::incrementProgress):
(WebCore::ProgressTracker::completeProgress):
- loader/ProgressTrackerClient.h:
Source/WebKit/efl:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::progressStarted):
(WebCore::FrameLoaderClientEfl::progressEstimateChanged):
(WebCore::FrameLoaderClientEfl::progressFinished):
- WebCoreSupport/FrameLoaderClientEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::progressStarted):
(WebKit::FrameLoaderClient::progressEstimateChanged):
(WebKit::FrameLoaderClient::progressFinished):
- WebCoreSupport/FrameLoaderClientGtk.h:
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::progressStarted):
(WebFrameLoaderClient::progressEstimateChanged):
(WebFrameLoaderClient::progressFinished):
Source/WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::progressStarted):
(WebFrameLoaderClient::progressEstimateChanged):
(WebFrameLoaderClient::progressFinished):
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::progressStarted):
(WebKit::WebFrameLoaderClient::progressEstimateChanged):
(WebKit::WebFrameLoaderClient::progressFinished):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- 11:27 PM Changeset in webkit [161750] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix COMPILE_ASSERT by updating struct SameSizeAsStyleRareInheritedData
- rendering/style/StyleRareInheritedData.cpp:
- 11:05 PM Changeset in webkit [161749] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix build of SubframeLoader.cpp
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
(WebCore::SubframeLoader::loadPlugin):
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
- 10:56 PM Changeset in webkit [161748] by
-
- 2 edits in trunk/Source/WebCore
Fix Mac after r161747. One part of that is iOS specific.
Unreviewed build fix.
- bindings/js/GCController.cpp:
(WebCore::GCController::releaseExecutableMemory):
- 10:53 PM Changeset in webkit [161747] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Fix GCController::releaseExecutableMemory
https://bugs.webkit.org/show_bug.cgi?id=126805
Reviewed by Sam Weinig and Mark Lam.
VM::dynamicGlobalObject has since been replaced by VMEntryScope.
Update to check entryScope instead of the dynamicGlobalObject.
Also, make this non-iOS only.
- bindings/js/GCController.h:
- bindings/js/GCController.cpp:
(WebCore::GCController::releaseExecutableMemory):
- 10:41 PM Changeset in webkit [161746] by
-
- 3 edits in trunk/Source/WebCore
Fix HTMLMediaElement.o for iOS. Unreviewed build fix.
There is now local variable mediaElement. Just call the
functions since they are methods on this class.
Fix RequireUserGestureToShowPlaybackTargetPickerRestriction typos.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- 10:33 PM Changeset in webkit [161745] by
-
- 2 edits in trunk/Source/WebKit2
Convert HandleMessage.h to use variadic templates
https://bugs.webkit.org/show_bug.cgi?id=126469
Reviewed by Anders Carlsson.
- Platform/IPC/HandleMessage.h:
(IPC::callMemberFunctionImpl):
(IPC::callMemberFunction):
Replace massive copy and pasted code with variadic magic.
- 10:33 PM Changeset in webkit [161744] by
-
- 27 edits1 add in trunk/Source
Move progress tracking functions from FrameLoaderClient to a new ProgressTrackerClient
https://bugs.webkit.org/show_bug.cgi?id=126801
Reviewed by Sam Weinig.
Source/WebCore:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):
- loader/EmptyClients.h:
- loader/FrameLoaderClient.h:
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::~ProgressTracker):
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::progressCompleted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::incrementProgress):
- loader/ProgressTracker.h:
- loader/ProgressTrackerClient.h: Added.
(WebCore::ProgressTrackerClient::~ProgressTrackerClient):
(WebCore::ProgressTrackerClient::progressTrackerDestroyed):
(WebCore::ProgressTrackerClient::willChangeEstimatedProgress):
(WebCore::ProgressTrackerClient::didChangeEstimatedProgress):
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):
- page/Page.h:
Source/WebKit/efl:
- WebCoreSupport/FrameLoaderClientEfl.h:
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
Source/WebKit/gtk:
- WebCoreSupport/FrameLoaderClientGtk.h:
- webkit/webkitwebview.cpp:
(webkit_web_view_init):
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Source/WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebView.cpp:
(WebView::initWithFrame):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- 10:18 PM Changeset in webkit [161743] by
-
- 2 edits in trunk/Source/WebCore
Fix RenderObject.o for iOS. Unreviewed build fix.
r156285 renamed firstChild() to firstChildSlow(), so update
occurances in IOS_TEXT_AUTOSIZING code. Also account for a
RenderObject::style reference / pointer change.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::traverseNext):
(WebCore::includeNonFixedHeight):
- 10:08 PM Changeset in webkit [161742] by
-
- 2 edits in trunk/Source/WebCore
Fix MediaPlayerPrivateMediaSourceAVFObjC.o for iOS. Unreviewed build fix.
Import CALayer, which Mac must have been getting some other way.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
- 10:02 PM Changeset in webkit [161741] by
-
- 2 edits in trunk/Source/WebCore
Fix TileGrid.o for iOS. Unreviewed build fix.
Explicitly use namespace std in std::pair.
- platform/ios/TileGrid.mm:
(WebCore::isFartherAway):
(WebCore::TileGrid::dropDistantTiles):
- 9:59 PM Changeset in webkit [161740] by
-
- 2 edits in trunk/Source/WebCore
Fix RenderImage.o for iOS. Unreviewed build fix.
inlineBoxWrapper() returns an InlineElementBox type, which is an InlineBox but
without including InlineElementBox.h, iOS didn't know what an InlineElementBox was!
- rendering/RenderImage.cpp:
- 9:53 PM Changeset in webkit [161739] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix macros in Scrollbar::supportsUpdateOnSecondaryThread()
Fixes the following build error:
WebCore/platform/Scrollbar.cpp:552:22: error: 'MAC_OS_X_VERSION_MIN_REQUIRED' is not defined, evaluates to 0 [-Werror,-Wundef]
#if PLATFORM(MAC) && MAC_OS_X_VERSION_MIN_REQUIRED >= 101000 && ENABLE(ASYNC_SCROLLING)
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::supportsUpdateOnSecondaryThread):
- 9:50 PM Changeset in webkit [161738] by
-
- 2 edits in trunk/Source/WebCore
Fix RenderFileUploadControl.o for iOS. Unreviewed build fix.
WebCore::theme() returns a reference now, not a pointer.
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
- 9:48 PM Changeset in webkit [161737] by
-
- 12 edits in branches/jsCStack
FTL should work with the bytecode profiler
https://bugs.webkit.org/show_bug.cgi?id=126804
Source/JavaScriptCore:
Reviewed by Sam Weinig.
Implement CountExecution in FTL and make the FTL report a compilation with some kind
of description to the database. This still leaves a lot to be desired; for example
the descriptions we report don't have disassembly. But, this small step already
allows for some basic profiling.
- dfg/DFGPlan.cpp:
(JSC::DFG::profilerCompilationKindForMode):
(JSC::DFG::Plan::Plan):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCountExecution):
- profiler/ProfilerCompilation.cpp:
(JSC::Profiler::Compilation::addDescription):
- profiler/ProfilerCompilation.h:
- profiler/ProfilerCompilationKind.cpp:
(WTF::printInternal):
- profiler/ProfilerCompilationKind.h:
Tools:
Reviewed by Sam Weinig.
Teach this that there are more JITs.
- Scripts/display-profiler-output:
- 9:45 PM Changeset in webkit [161736] by
-
- 2 edits2 adds in trunk/Source/WebCore
Fix HTMLPlugInImageElement.o for iOS. Unreviewed build fix.
Forgot to upstream YouTubeEmbedShadowElement.*. Do so and
add the files to the Xcode project so they build.
- WebCore.xcodeproj/project.pbxproj:
- html/shadow/YouTubeEmbedShadowElement.cpp: Added.
(WebCore::YouTubeEmbedShadowElement::create):
(WebCore::YouTubeEmbedShadowElement::YouTubeEmbedShadowElement):
(WebCore::YouTubeEmbedShadowElement::pluginElement):
(WebCore::YouTubeEmbedShadowElement::shadowPseudoId):
- html/shadow/YouTubeEmbedShadowElement.h: Added.
- 9:34 PM Changeset in webkit [161735] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Update EditorIOS.mm to switch from pointers to references
- editing/ios/EditorIOS.mm:
(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
(WebCore::Editor::insertParagraphSeparatorInQuotedContent):
(WebCore::styleForSelectionStart):
(WebCore::Editor::selectionInWebArchiveFormat):
(WebCore::Editor::writeImageToPasteboard):
(WebCore::Editor::WebContentReader::readWebArchive):
(WebCore::Editor::WebContentReader::readRTFD):
(WebCore::Editor::WebContentReader::readRTF):
(WebCore::uniqueURLWithRelativePart):
(WebCore::Editor::WebContentReader::readPlainText):
(WebCore::Editor::webContentFromPasteboard):
(WebCore::Editor::createFragmentAndAddResources):
(WebCore::Editor::createFragmentForImageResourceAndAddResource):
- 9:33 PM Changeset in webkit [161734] by
-
- 3 edits in branches/jsCStack/Source/JavaScriptCore
Unreviewed, unbreak all tests by undoing some assertions junk in
http://trac.webkit.org/changeset/161732 and changing typo "node->function()"
which should have been "node->executable()".
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCheckExecutable):
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
(JSC::Options::initialize):
- 9:18 PM Changeset in webkit [161733] by
-
- 27 edits2 moves5 adds in trunk/Source
Web Inspector: Push InspectorAgent down into JSC, give JSC an InspectorController
https://bugs.webkit.org/show_bug.cgi?id=126763
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Introduce JSGlobalObjectInspectorController. This is the InspectorController
for a JSContext. It is created by the JSGlobalObject Remote Inspector Debuggable
when a remote frontend connects, and is destroyed when the remote frontend
disconnects of the JSGlobalObject is destroyed.
- inspector/JSGlobalObjectInspectorController.h: Added.
- inspector/JSGlobalObjectInspectorController.cpp: Added.
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::~JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
(Inspector::JSGlobalObjectInspectorController::dispatchMessageFromFrontend):
(Inspector::JSGlobalObjectInspectorController::functionCallHandler):
(Inspector::JSGlobalObjectInspectorController::evaluateHandler):
Create/destory agents, create/destroy dispatches, implement InspectorEnvironment.
- runtime/JSGlobalObjectDebuggable.h:
- runtime/JSGlobalObjectDebuggable.cpp:
(JSC::JSGlobalObjectDebuggable::~JSGlobalObjectDebuggable):
(JSC::JSGlobalObjectDebuggable::connect):
(JSC::JSGlobalObjectDebuggable::disconnect):
(JSC::JSGlobalObjectDebuggable::dispatchMessageFromRemoteFrontend):
Forward actions to the InspectorController object.
- inspector/agents/InspectorAgent.h: Renamed from Source/WebCore/inspector/InspectorAgent.h.
- inspector/agents/InspectorAgent.cpp: Renamed from Source/WebCore/inspector/InspectorAgent.cpp.
(Inspector::InspectorAgent::InspectorAgent):
(Inspector::InspectorAgent::~InspectorAgent):
(Inspector::InspectorAgent::didCreateFrontendAndBackend):
(Inspector::InspectorAgent::inspect):
(Inspector::InspectorAgent::evaluateForTestInFrontend):
Implement InspectorAgent in JavaScriptCore in namespace Inspector.
- JavaScriptCore.xcodeproj/project.pbxproj:
- CMakeLists.txt:
- ChangeLog:
- GNUmakefile.am:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.vcxproj/copy-files.cmd:
Add files and new inspector/agents subdirectory.
Source/WebCore:
No new tests, no observable change in functionality.
- CMakeLists.txt:
- ForwardingHeaders/inspector/InspectorAgent.h: Added.
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorAllInOne.cpp:
InspectorAgent moved to JavaScriptCore.
- inspector/PageConsoleAgent.cpp:
(WebCore::PageConsoleAgent::PageConsoleAgent):
(WebCore::PageConsoleAgent::~PageConsoleAgent):
- inspector/PageConsoleAgent.h:
(WebCore::PageConsoleAgent::create):
- inspector/InspectorApplicationCacheAgent.cpp:
- inspector/InspectorApplicationCacheAgent.h:
InspectorAgent was not used by these files, remove it.
- inspector/CommandLineAPIHost.cpp:
- inspector/CommandLineAPIHost.h:
(WebCore::CommandLineAPIHost::init):
- inspector/InspectorInstrumentation.cpp:
- inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::inspectorAgent):
(WebCore::InstrumentingAgents::setInspectorAgent):
Switch to Inspector::InspectorAgent where applicable.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorController.h:
Manually add InspectorAgent to the InstrumentingAgents. It is one
of the agents that is always available in InstrumentingAgents.
- 9:06 PM Changeset in webkit [161732] by
-
- 6 edits1 add in branches/jsCStack/Source/JavaScriptCore
FTL should enough things to compile inlined closure calls (like CheckExecutable and GetScope)
https://bugs.webkit.org/show_bug.cgi?id=126799
Reviewed by Oliver Hunt.
Added FTL support for CheckExecutable and GetScope because I wanted to compile
closure calls. But then I realized that closure call inlining was broken because
the baseline JIT would link the closure stubs to the slow path, thereby causing
the DFG's profiling to think that all closure calls are actually virtual calls.
Also fixed some hash() computing stuff to make debugging easier.
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCheckExecutable):
(JSC::FTL::LowerDFGToLLVM::compileGetScope):
- jit/Repatch.cpp:
(JSC::linkClosureCall):
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
(JSC::Options::initialize):
(JSC::Options::setOption):
- tests/stress/inline-closure-call.js: Added.
(bar):
- 9:02 PM Changeset in webkit [161731] by
-
- 3 edits2 adds in trunk/Source/WebCore
Add TextAutoSizing.* for iOS, and fix DeviceOrientationController creation.
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::Document):
- rendering/TextAutoSizing.cpp: Added.
(WebCore::cloneRenderStyleWithState):
(WebCore::TextAutoSizingKey::TextAutoSizingKey):
(WebCore::TextAutoSizingKey::~TextAutoSizingKey):
(WebCore::TextAutoSizingKey::operator=):
(WebCore::TextAutoSizingKey::ref):
(WebCore::TextAutoSizingKey::deref):
(WebCore::TextAutoSizingValue::numNodes):
(WebCore::TextAutoSizingValue::addNode):
(WebCore::TextAutoSizingValue::adjustNodeSizes):
(WebCore::TextAutoSizingValue::reset):
- rendering/TextAutoSizing.h: Added.
(WebCore::TextAutoSizingKey::doc):
(WebCore::TextAutoSizingKey::style):
(WebCore::TextAutoSizingKey::isValidDoc):
(WebCore::TextAutoSizingKey::isValidStyle):
(WebCore::TextAutoSizingKey::deletedKeyDoc):
(WebCore::TextAutoSizingKey::deletedKeyStyle):
(WebCore::operator==):
(WebCore::TextAutoSizingHash::hash):
(WebCore::TextAutoSizingHash::equal):
(WebCore::TextAutoSizingValue::create):
(WebCore::TextAutoSizingValue::TextAutoSizingValue):
- 8:44 PM Changeset in webkit [161730] by
-
- 2 edits in trunk/Source/WebCore
Fix GraphicsLayerCA.o for iOS. Unreviewed build fix.
Use of systemMemoryLevel was missing include of SystemMemory.h.
- platform/graphics/ca/GraphicsLayerCA.cpp:
- 8:41 PM Changeset in webkit [161729] by
-
- 4 edits in trunk/Source/WebCore
Fix iOS build.
- bindings/objc/DOM.mm:
(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
- bindings/objc/DOMExtensions.h:
- platform/DragImage.h:
- 8:41 PM Changeset in webkit [161728] by
-
- 4 edits in trunk/Source/WebCore
Fix iOS build.
Generated DOMTouch* and DOMGesture* files need to be in the project.
Exclude them on Mac via EXCLUDED_SOURCE_FILE_NAMES_macosx.
Use TARGET_OS_IPHONE instead of TARGET_OS_EMBEDDED in DOMPrivate.h
- Configurations/WebCore.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMPrivate.h:
- 8:39 PM Changeset in webkit [161727] by
-
- 2 edits in trunk/Source/WebCore
Fix RenderThemeIOS.o for iOS. Unreviewed build fix.
Typo referring to generated name. Should be "iOS" not "IOS".
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::mediaControlsScript):
- 8:31 PM Changeset in webkit [161726] by
-
- 2 edits in trunk/Source/WebCore
Fix WebAccessibilityObjectWrapperIOS.o for iOS. Unreviewed build fix.
The upstreamed WebAccessibilityObjectWrapperIOS.mm was out of date, e.g.
it was using GSFonts. Just upstream a newer version of the file. Also
explicitly namespace qualify std::pair.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(AXAttributeStringSetStyle):
- 8:26 PM Changeset in webkit [161725] by
-
- 3 edits in trunk/Source/WebCore
Remove willRespondToTouchEvents() which was used by chromium port
https://bugs.webkit.org/show_bug.cgi?id=126739
Reviewed by Alexey Proskuryakov.
willRespondToTouchEvents() was added to check if a node listens to touch events in r126945.
However, it is not used anywhere after chromium port is removed.
- dom/Node.cpp:
- dom/Node.h:
- 8:17 PM Changeset in webkit [161724] by
-
- 2 edits in trunk/Source/WebCore
Fix SystemVersionMac.o for iOS. Unreviewed build fix.
Add missing expected function. Maybe we can avoid including
this file entirely on iOS, there was already a FIXME.
- platform/mac/SystemVersionMac.mm:
(WebCore::systemMarketingVersion):
- 8:13 PM Changeset in webkit [161723] by
-
- 2 edits in trunk/Source/WebCore
Fix JSDOMWindowBase.o for iOS. Unreviewed build fix.
Add missing iOS method declarations.
- bindings/js/JSDOMWindowBase.h:
- 8:06 PM Changeset in webkit [161722] by
-
- 3 edits3 deletes in trunk
Unreviewed, rolling out r161702.
http://trac.webkit.org/changeset/161702
https://bugs.webkit.org/show_bug.cgi?id=126803
Broke multiple tests (Requested by ap on #webkit).
Source/JavaScriptCore:
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):
LayoutTests:
- js/script-tests/typedarray-constructors.js: Removed.
- js/typedarray-constructors-expected.txt: Removed.
- js/typedarray-constructors.html: Removed.
- 8:05 PM Changeset in webkit [161721] by
-
- 2 edits in trunk/Source/WebCore
Fix InputType.o for iOS. Unreviewed build fix.
The RuntimeEnabledFeatures function pointer type should have a
const qualifier, because the implementations are all const.
- html/InputType.cpp:
- 7:58 PM Changeset in webkit [161720] by
-
- 2 edits in trunk/Source/WebCore
Fix MediaPlayerPrivateIOS.o for iOS. Unreviewed build fix.
Add missing MediaPlayerProxy Objective C methods and forward declarations.
- platform/graphics/mac/MediaPlayerProxy.h:
- 7:49 PM Changeset in webkit [161719] by
-
- 2 edits in trunk/Source/WebCore
Fix FrameSelection.o for iOS. Unreviewed build fix.
r160966 renamed rendererIsEditable to hasEditableStyle.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelectionFromNone):
- 7:46 PM Changeset in webkit [161718] by
-
- 2 edits in trunk/Source/WebCore
Fix DragData.o for iOS. Unreviewed build fix.
String m_pasteboardName is unused on iOS, so ifdef it out.
- platform/DragData.h:
- 7:32 PM Changeset in webkit [161717] by
-
- 2 edits in trunk/Source/WebCore
Fix FrameIOS.o for iOS. Unreviewed build fix.
Remove stale include to file that no longer exists. It was not needed.
- page/ios/FrameIOS.mm:
- 7:29 PM Changeset in webkit [161716] by
-
- 2 edits in trunk/Source/WebCore
Fix MonthInputType.o for iOS. Unreviewed build fix.
When ENABLE_INPUT_MULTIPLE_FIELDS_UI was removed in r150876,
the wrong class name lingered. Fix it to be the base class.
- html/TimeInputType.cpp:
(WebCore::TimeInputType::TimeInputType):
- 6:26 PM Changeset in webkit [161715] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Build fix: make sure WTF_PLATFORM_IOS is defined when preprocessing
- DerivedSources.make:
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
- 6:25 PM Changeset in webkit [161714] by
-
- 2 edits in trunk/Source/WebCore
Use TARGET_OS_IPHONE in this API file, and #if TARGET_OS_MAC
for a non-iOS function.
- bindings/objc/DOMExtensions.h:
- 6:19 PM Changeset in webkit [161713] by
-
- 12 edits in trunk/Source
Clean up architectures in xcconfig files
<http://webkit.org/b/126794>
Reviewed by Andy Estes.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- Configurations/JavaScriptCore.xcconfig: Remove armv6, ppc.
- Configurations/ToolExecutable.xcconfig: Sort.
- Add new arch.
Source/WebCore:
- Configurations/Base.xcconfig:
- Configurations/WebCore.xcconfig: Remove armv6.
- DerivedSources.make: Remove armv6, armv7f. Sort.
- Add new arch.
Source/WebKit/mac:
- Configurations/WebKit.xcconfig: Remove armv6, armv7f, ppc.
- Add new arch.
Source/WTF:
- Configurations/Base.xcconfig:
- Add new arch.
- 6:16 PM Changeset in webkit [161712] by
-
- 3 edits in trunk/Source/WebCore
Fix iOS build
- Configurations/WebCore.xcconfig:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue):
- 5:59 PM Changeset in webkit [161711] by
-
- 3 edits in trunk/Source/WebCore
Fix iOS build.
- html/DateTimeLocalInputType.h:
(WebCore::DateTimeLocalInputType::DateTimeLocalInputType):
- loader/ios/DiskImageCacheIOS.h:
- 5:59 PM Changeset in webkit [161710] by
-
- 4 edits in trunk/Source/WebCore
iOS build fix: add StyleRareInheritedData::compositionFillColor
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
- 5:50 PM Changeset in webkit [161709] by
-
- 2 edits in trunk/Source/WebCore
Fix MonthInputType.o for iOS. Unreviewed build fix.
Incorrect base class name. Must have been typo'd when upstreaming.
- html/MonthInputType.h:
(WebCore::MonthInputType::MonthInputType):
- 5:33 PM Changeset in webkit [161708] by
-
- 2 edits in trunk/Source/WebCore
Fix RenderButton.o for iOS. Unreviewed build fix.
Missing prototype in header for override of the layout method.
- rendering/RenderButton.h:
- 5:29 PM Changeset in webkit [161707] by
-
- 3 edits in trunk/Source/WebCore
A couple of iOS build fixes.
- accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
- 5:29 PM Changeset in webkit [161706] by
-
- 2 edits in trunk/Source/WebCore
Fix iOS build.
- loader/ResourceLoader.h:
- 5:29 PM Changeset in webkit [161705] by
-
- 8 edits in branches/jsCStack/Source/JavaScriptCore
It should be easier to diagnose FTL performance issues due to register preservation thunks
https://bugs.webkit.org/show_bug.cgi?id=126798
Not yet reviewed.
You can now use --verboseFTLToJSThunk=true --verboseFTLFailure=true to figure out
which code blocks are rejected by the FTL and yet get called from functions that
were FTL compiled. Any such rejections in major benchmarks should be fixed.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::verboseCapabilities):
(JSC::FTL::canCompile):
- jit/RegisterPreservationWrapperGenerator.cpp:
(JSC::generateRegisterPreservationWrapper):
- runtime/Executable.cpp:
(JSC::ExecutableBase::dump):
- runtime/Executable.h:
- runtime/Options.cpp:
(JSC::Options::initialize):
- runtime/Options.h:
- 5:26 PM Changeset in webkit [161704] by
-
- 2 edits in trunk/Source/WebCore
Fix PlatformScreenIOS.mm for iOS. Unreviewed build fix.
PlatformScreen.h removed screenVerticalDPI and screenHorizontalDPI in r132419,
so remove the stale implementations on iOS. Also, add a notImplemented version
of screenColorProfile, which matches Mac and is unused in WebCore for this port.
- platform/ios/PlatformScreenIOS.mm:
(WebCore::screenColorProfile):
- 5:19 PM Changeset in webkit [161703] by
-
- 4 edits in trunk/Source/WebCore
CTTE FrameTree
https://bugs.webkit.org/show_bug.cgi?id=126795
Reviewed by Tim Horton.
- page/Frame.cpp:
(WebCore::Frame::Frame):
- page/FrameTree.cpp:
(WebCore::FrameTree::transferChild):
(WebCore::FrameTree::appendChild):
(WebCore::FrameTree::actuallyAppendChild):
(WebCore::FrameTree::uniqueChildName):
(WebCore::FrameTree::scopedChild):
(WebCore::FrameTree::scopedChildCount):
(WebCore::FrameTree::child):
(WebCore::FrameTree::find):
(WebCore::FrameTree::isDescendantOf):
(WebCore::FrameTree::traverseNext):
(WebCore::FrameTree::traverseNextWithWrap):
(WebCore::FrameTree::traversePreviousWithWrap):
(WebCore::FrameTree::deepLastChild):
(WebCore::FrameTree::top):
- page/FrameTree.h:
(WebCore::FrameTree::FrameTree):
- 5:09 PM Changeset in webkit [161702] by
-
- 3 edits3 adds in trunk
[JSC] Revise typed array implementations to match ECMAScript and WebGL Specification
https://bugs.webkit.org/show_bug.cgi?id=126754
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
The ECMAScript specification forbids calling the typed array
constructors without using "new". Change the call data to return
none so we throw and exception in these cases.
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):
LayoutTests:
New test which checks that we throw an exception when calling
any of the typed array constructors without using "new".
- js/script-tests/typedarray-constructors.js: Added.
- js/typedarray-constructors-expected.txt: Added.
- js/typedarray-constructors.html: Added.
- 5:05 PM Changeset in webkit [161701] by
-
- 2 edits in trunk/Source/WebCore
Fix iOS build.
- platform/graphics/ImageSource.h:
(WebCore::ImageSource::acceleratedImageDecodingEnabled):
(WebCore::ImageSource::setAcceleratedImageDecodingEnabled):
- 4:55 PM Changeset in webkit [161700] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed EFL build fix after r161678.
static_cast a size_t to unsigned long for %lu format string.
- page/Console.cpp:
(WebCore::internalAddMessage):
- 4:53 PM Changeset in webkit [161699] by
-
- 38 edits in trunk
Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.
.:
- CMakeLists.txt:
- Source/cmake/OptionsCommon.cmake:
Source/JavaScriptCore:
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::cacheFlush):
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):
(JSC::ARMv7Assembler::cacheFlush):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):
- heap/MachineStackMarker.cpp:
(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
(JSC::freePlatformThreadRegisters):
- jit/ExecutableAllocator.h:
Source/WebCore:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::readPixels):
- platform/graphics/ImageBuffer.cpp:
- platform/graphics/ImageBufferData.h:
- platform/graphics/IntPoint.h:
- platform/graphics/IntRect.h:
- platform/graphics/IntSize.h:
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/NativeImagePtr.h:
- platform/graphics/OpenGLESShims.h:
- platform/graphics/Path.cpp:
(WebCore::Path::addPathForRoundedRect):
- platform/graphics/Path.h:
- platform/graphics/PlatformLayer.h:
- platform/graphics/filters/CustomFilterValidatedProgram.cpp:
- platform/graphics/filters/CustomFilterValidatedProgram.h:
- platform/graphics/filters/FilterOperation.h:
- platform/graphics/gpu/DrawingBuffer.cpp:
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
- platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::getGraphicsResetStatusARB):
- platform/graphics/opengl/Extensions3DOpenGLES.h:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
- platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::reshapeFBOs):
- platform/network/NetworkStateNotifier.h:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/ResourceRequestBase.cpp:
Tools:
- DumpRenderTree/DumpRenderTree.h:
- DumpRenderTree/PixelDumpSupport.cpp:
- 4:44 PM Changeset in webkit [161698] by
-
- 3 edits1 add in trunk/Source/WebCore
Fix CharsetData.cpp build for iOS
https://bugs.webkit.org/show_bug.cgi?id=126792
Reviewed by Mark Rowe.
CharsetData.cpp should have an empty CharsetTable list for iOS.
Achieve this with an iOS-specific encodings.txt file.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- platform/text/mac/ios-encodings.txt: Added.
- 4:38 PM Changeset in webkit [161697] by
-
- 8 edits in trunk/Source/WebCore
CTTE in NavigationScheduler
https://bugs.webkit.org/show_bug.cgi?id=126788
Reviewed by Tim Horton.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::frameScheduledNavigationImpl):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigationImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::frameScheduledNavigation):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigation):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::frameScheduledNavigation):
(WebCore::InspectorPageAgent::frameClearedScheduledNavigation):
- inspector/InspectorPageAgent.h:
- loader/NavigationScheduler.cpp:
(WebCore::ScheduledNavigation::shouldStartTimer):
(WebCore::ScheduledNavigation::didStartTimer):
(WebCore::ScheduledNavigation::didStopTimer):
(WebCore::NavigationScheduler::NavigationScheduler):
(WebCore::NavigationScheduler::clear):
(WebCore::NavigationScheduler::shouldScheduleNavigation):
(WebCore::NavigationScheduler::scheduleRedirect):
(WebCore::NavigationScheduler::mustLockBackForwardList):
(WebCore::NavigationScheduler::scheduleLocationChange):
(WebCore::NavigationScheduler::scheduleFormSubmission):
(WebCore::NavigationScheduler::scheduleRefresh):
(WebCore::NavigationScheduler::scheduleHistoryNavigation):
(WebCore::NavigationScheduler::timerFired):
(WebCore::NavigationScheduler::schedule):
(WebCore::NavigationScheduler::startTimer):
(WebCore::NavigationScheduler::cancel):
- loader/NavigationScheduler.h:
- page/Frame.cpp:
(WebCore::Frame::Frame):
- 4:31 PM Changeset in webkit [161696] by
-
- 19 edits7 adds in trunk
CSS word-spacing property does not obey percentages
https://bugs.webkit.org/show_bug.cgi?id=126674
Reviewed by Simon Fraser.
Source/WebCore:
One change between CSS2.1 and CSS3 is that the word-spacing CSS property can
take percentages (of the width of the space character) in CSS3. In order to
implement this, the datatype must be changed from a float to a Length, which
can hold percentage values. Then, during layout, we can query the width of
the space character and update the Font's word-spacing value appropriately.
However, the RenderStyle still holds on to the Length (as a rare inherited
value).
Tests: fast/css3-text/css3-word-spacing-percentage/word-spacing-change-font.html
fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage-parse.html
fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue): Use Font's computed value instead
of style's Length value.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): word-spacing and letter-spacing no longer are
parsed the same way.
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyWordSpacing::applyValue): Construct a length from a given
CSSValue and set the style's word spacing with it.
(WebCore::ApplyPropertyWordSpacing::createHandler):
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): Use ApplyPropertyWordSpacing.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun): Use Font's computed value instead
of style's Length value.
- rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths): Ditto.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor): Opt-out of the SimpleLineLayout
if either the percentage or the length is nonzero.
- rendering/line/BreakingContextInlineHeaders.h:
(WebCore::BreakingContext::handleText): Use Font's computed value instead
of style's Length value.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::wordSpacing):
(WebCore::RenderStyle::setWordSpacing): Consult the Font's space with to compute
percentage values, but hold on to the original Length.
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareInheritedData.cpp:
- rendering/style/StyleRareInheritedData.h: Hold on to the specified Length
LayoutTests:
See per-file description
- fast/css3-text/css3-word-spacing-percentage/word-spacing-change-font-expected.html: Added.
- fast/css3-text/css3-word-spacing-percentage/word-spacing-change-font.html: Added.
Make sure that if Javascript changes the font after initial layout, that the word-spacing
value gets appropriately updated.
- fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage-expected.html: Added.
- fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage-parse-expected.txt: Added.
- fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage-parse.html: Added.
Make sure that the CSSOM yields the correct percentage values when queried.
- fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage.html: Added.
Try some specific values of percentages (-100%, 0%, and 100%).
- css1/text_properties/word_spacing.html: Updated to not disregard percentages
- css2.1/20110323/c541-word-sp-001-expected.html:
- css2.1/20110323/c541-word-sp-001.htm: Ditto
- platform/mac/css1/text_properties/word_spacing-expected.png:
- platform/mac/css1/text_properties/word_spacing-expected.txt: Ditto
- 4:29 PM Changeset in webkit [161695] by
-
- 1 edit1 add in branches/jsCStack/Source/JavaScriptCore
Unreviewed, add a test for the case where LLVM finds a constant folding
opportunity that the DFG missed, and it involves a large constant, and then we
exit with the large constant folded into a stackmap for an OSR exit.
We fixed this incidentally as part of http://trac.webkit.org/changeset/161543, but
it only showed up as part of new tests specific to add/sub recovery and as a
Octane/gbemu *slow-down* because gbemu had such a constant. It seems like we
should have an explicit test for this since it's a really gross bug to have in a
rather critical code path.
- tests/stress/exit-after-llvm-folds-large-int-constant.js: Added.
(foo):
- 4:19 PM Changeset in webkit [161694] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS build.
- platform/audio/mac/MediaSessionManagerMac.cpp:
- 4:17 PM Changeset in webkit [161693] by
-
- 2 edits in trunk/Source/WebCore
iOS doesn't have <OpenGL/gl.h>; fix iOS build.
- platform/graphics/opengl/TemporaryOpenGLSetting.cpp:
- 4:16 PM Changeset in webkit [161692] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Build Fix: Properly add $SDKROOT/usr/local/include/ to the search path when building PublicDOMInterfaces.h
- bindings/scripts/CodeGeneratorObjC.pm:
(ReadPublicInterfaces):
- 3:55 PM Changeset in webkit [161691] by
-
- 22 edits in trunk/Source
Web Inspector: Remove unimplemented or static ScriptDebugServer features
https://bugs.webkit.org/show_bug.cgi?id=126784
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-10
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/protocol/Debugger.json:
Source/WebCore:
These features are unimplemented in the backend, and unused by the
current frontend. Most deal with features that were supported by v8
and are as yet unimplemented by JSC. If we decide to add such features
we can reimplement without conforming to an old implementation.
- bindings/js/ScriptDebugServer.cpp:
- bindings/js/ScriptDebugServer.h:
- bindings/js/ScriptProfiler.h:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::disable):
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::reload):
(WebCore::InspectorPageAgent::frameNavigated):
- inspector/InspectorPageAgent.h:
- inspector/InspectorProfilerAgent.cpp:
- inspector/InspectorProfilerAgent.h:
- inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::didClearMainFrameWindowObject):
- inspector/protocol/Page.json:
- inspector/protocol/Profiler.json:
Source/WebInspectorUI:
- UserInterface/InspectorJSBackendCommands.js:
- UserInterface/InspectorWebBackendCommands.js:
- UserInterface/Legacy/6.0/InspectorWebBackendCommands.js:
- UserInterface/Legacy/7.0/InspectorWebBackendCommands.js:
- Versions/Inspector-iOS-6.0.json:
- Versions/Inspector-iOS-7.0.json:
- 3:54 PM Changeset in webkit [161690] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Remove unused variable from TileGrid::dropTilesBetweenRects()
Fixes the following build error:
WebCore/platform/ios/TileGrid.mm:88:23: error: unused variable 'end' [-Werror,-Wunused-variable]
TileMap::iterator end = m_tiles.end();
- platform/ios/TileGrid.mm:
(WebCore::TileGrid::dropTilesBetweenRects): Remove unused
variable now that the for loop uses an auto iterator.
- 3:54 PM Changeset in webkit [161689] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: support negative numbers in secondsToString and bytesToString.
https://bugs.webkit.org/show_bug.cgi?id=125708
Reviewed by Joseph Pecoraro.
- UserInterface/Utilities.js:
(Number.secondsToString): Use Math.abs in the size checks.
(Number.bytesToString): Ditto.
- 3:53 PM Changeset in webkit [161688] by
-
- 18 edits5 adds in trunk
Implement OES texture half float linear
https://bugs.webkit.org/show_bug.cgi?id=125060
Reviewed by Brent Fulgham.
Source/WebCore:
Test: fast/canvas/webgl/oes-texture-half-float-linear.html
- CMakeLists.txt: Add new files.
- DerivedSources.cpp: Ditto.
- DerivedSources.make: Generate new file from IDL.
- GNUmakefile.list.am: Add new files.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: New files for OESTextureHalfFloatLinear.
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS): Map from extension name to native object.
- html/canvas/OESTextureHalfFloatLinear.cpp: Added. New files. These are boiler-plate.
- html/canvas/OESTextureHalfFloatLinear.h: Added.
- html/canvas/OESTextureHalfFloatLinear.idl: Added.
- html/canvas/WebGLExtension.h: Add new enum for the new extension.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension): Create the extension object if the
context is asked for one.
(WebCore::WebGLRenderingContext::getSupportedExtensions): Add the new extension to the
list of supported extensions. Actually remember to do it this time :)
(WebCore::WebGLRenderingContext::checkTextureCompleteness): Need to check for the half-float
extension as well, and update the log message.
- html/canvas/WebGLRenderingContext.h: New extension object.
- html/canvas/WebGLTexture.cpp:
(WebCore::WebGLTexture::WebGLTexture):
(WebCore::WebGLTexture::needToUseBlackTexture): Check for half-float type.
(WebCore::WebGLTexture::update): Mark a texture as half-float if necessary.
- html/canvas/WebGLTexture.h:
- platform/graphics/Extensions3D.h: Add a comment about the new extension.
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension): This extension is available
when GL_ARB_texture_float is supported, so add the name to the translation.
LayoutTests:
Exercise the OES_texture_half_float_linear extension. The new test
is copied from the official Khronos WebGL repository.
- fast/canvas/webgl/oes-texture-float-linear-expected.txt: Change the console log
messages, which now also mention half float linear.
- fast/canvas/webgl/oes-texture-half-float-linear-expected.txt: Added.
- fast/canvas/webgl/oes-texture-half-float-linear.html: Added.
- 3:48 PM Changeset in webkit [161687] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: cycle clicked breakpoints between enabled, auto-continue, and disabled
https://bugs.webkit.org/show_bug.cgi?id=126669
Reviewed by Joseph Pecoraro.
It's time-consuming to change a breakpoint's auto-continue setting through the
breakpoint editor popup. This patch enables the user to toggle between enabled,
auto-continue, and disabled by clicking on the breakpoint wedge in the sidebar
tree and in the source text editor gutter. The auto-continue option is only
cycled when the breakpoint has associated actions.
Clean up the breakpoint editor dialog so it hides irrelevant options when
no breakpoint actions have been added.
Automatically unset auto-continue when the last breakpoint action is removed.
Rename the delegate textEditorBreakpointToggled to textEditorBreakpointClicked, since
the behavior of the click depends on breakpoint state not available in the text editor.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Breakpoint.js:
(WebInspector.Breakpoint.prototype.cycleToNextMode): Added.
(WebInspector.Breakpoint.prototype.toggleAutoContinue): Added.
(WebInspector.Breakpoint.prototype.appendContextMenuItems): Add auto-continue options.
(WebInspector.Breakpoint.prototype.removeAction):
(WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):
(WebInspector.Breakpoint.prototype._popoverActionsAddActionButtonClicked):
(WebInspector.Breakpoint.prototype.breakpointActionViewAppendActionView):
(WebInspector.Breakpoint.prototype.breakpointActionViewRemoveActionView):
(WebInspector.Breakpoint.prototype.willDismissPopover):
- UserInterface/BreakpointTreeElement.css:
(.item.breakpoint .status > .status-image.auto-continue):
(.item.breakpoint .status > .status-image.disabled):
- UserInterface/BreakpointTreeElement.js:
(WebInspector.BreakpointTreeElement):
(WebInspector.BreakpointTreeElement.prototype.onenter):
(WebInspector.BreakpointTreeElement.prototype.onspace):
(WebInspector.BreakpointTreeElement.prototype._updateStatus):
(WebInspector.BreakpointTreeElement.prototype._breakpointLocationDidChange):
(WebInspector.BreakpointTreeElement.prototype._statusImageElementClicked):
- UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype.close):
(WebInspector.SourceCodeTextEditor.prototype._breakpointInfoForBreakpoint):
(WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointClicked):
- UserInterface/TextEditor.css:
(.text-editor > .CodeMirror .breakpoint-auto-continue:not(.breakpoint-disabled) .CodeMirror-linenumber::before):
- UserInterface/TextEditor.js:
(WebInspector.TextEditor.prototype._setBreakpointStylesOnLine.updateStyles):
(WebInspector.TextEditor.prototype._setBreakpointStylesOnLine):
(WebInspector.TextEditor.prototype.updateStyles):
(WebInspector.TextEditor.prototype._removeBreakpointFromLineAndColumn):
(WebInspector.TextEditor.prototype._documentMouseUp):
- 3:47 PM Changeset in webkit [161686] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION(C stack work): stack traces no longer work in CrashTracer, lldb, and other tools
https://bugs.webkit.org/show_bug.cgi?id=126764
Reviewed by Geoffrey Garen.
Updated callToJavaScript and cllToNativeFunction to properly replicate the caller's
return PC and frame pointer in the sentinel frame. For X86-64, added .cfi_
directives to create eh_frame info for all LLInt symbols so that the various
unwinding code understands that we are using a separate JS stack referenced
by BP and at what offsets in that frame the prior PC (register 16) and prior
BP (register 6) can be found. These two changes are sufficient for stack tracing
to work for Mac OSX.
- llint/LowLevelInterpreter.cpp:
- llint/LowLevelInterpreter64.asm:
- 3:36 PM Changeset in webkit [161685] by
-
- 2 edits in trunk/Tools
[iOS] Fix project build order
Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
time of writing.
- Scripts/build-webkit:
- 3:28 PM Changeset in webkit [161684] by
-
- 3 edits1 copy in trunk
Source/WebCore: [WebGL] Correct uniform input validation for texture sampler uniform
https://bugs.webkit.org/show_bug.cgi?id=126775
Reviewed by Dean Jackson.
Added fast/canvas/webgl/uniform-samplers-test.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::uniform1iv): Access Int32Array data properly.
LayoutTests: [WebGL] Correct uniform input validation for texture sampler uniforms.
https://bugs.webkit.org/show_bug.cgi?id=126775
Reviewed by Dean Jackson.
- fast/canvas/webgl/uniform-samplers-test.html: Add a test that
shows that we can set sampler uniforms using Int32Array types.
- 3:17 PM Changeset in webkit [161683] by
-
- 5 edits3 adds in branches/jsCStack/Source/JavaScriptCore
DFG should insert Phantoms when it uses conversion nodes
https://bugs.webkit.org/show_bug.cgi?id=126777
Reviewed by Oliver Hunt.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixupUntypedSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixEdge):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(JSC::DFG::FixupPhase::addPhantomsIfNecessary):
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::dumpNodeFlags):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
- tests/stress/exit-after-int32-to-double.js: Added.
(foo):
- tests/stress/exit-after-int52-to-double.js: Added.
(foo):
- tests/stress/exit-after-int52-to-value.js: Added.
(foo):
(makeWeirdObject):
- 2:54 PM Changeset in webkit [161682] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Unreviewed build fix after r161644.
- Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::setFormat):
- 2:52 PM Changeset in webkit [161681] by
-
- 4 edits in trunk/Source/WebCore
Remove an unused FrameLoader function
https://bugs.webkit.org/show_bug.cgi?id=126785
Reviewed by Beth Dakin.
- WebCore.exp.in:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::setState):
- loader/FrameLoader.h:
- 2:48 PM Changeset in webkit [161680] by
-
- 22 edits in trunk/Source/WebCore
Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypesForEncoding):
- platform/PlatformKeyboardEvent.h:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- platform/PlatformMouseEvent.h:
- platform/PlatformTouchEvent.h:
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
- platform/PlatformTouchPoint.h:
- platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimator::create):
- platform/URL.cpp:
(WebCore::URL::parse):
(WebCore::portAllowed):
- platform/Widget.h:
- platform/graphics/ANGLEWebKitBridge.h:
- platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
- platform/graphics/DisplayRefreshMonitor.h:
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatRect.h:
- platform/graphics/FloatSize.h:
- platform/graphics/FontCache.h:
- platform/graphics/FontPlatformData.h:
- platform/graphics/GlyphBuffer.h:
- platform/graphics/Gradient.cpp:
- platform/graphics/Gradient.h:
- platform/graphics/GraphicsContext.h:
- platform/graphics/GraphicsContext3D.h:
- 2:24 PM Changeset in webkit [161679] by
-
- 6 edits in trunk/Source/WebKit2
Remove dead code
https://bugs.webkit.org/show_bug.cgi?id=126782
Reviewed by Tim Horton.
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 2:16 PM Changeset in webkit [161678] by
-
- 4 edits in trunk/Source/WebCore
Clean up and fix some issues with stdout formatting of console messages.
- Fix URLs not printing line numbers unless column number is > 0.
- Change "CONSOLEAPI" to "CONSOLE" for the source.
- Clean up how console.trace outputs and print URL, line and column for each frame.
- Print "(unknown)" for anonymous and native code call frames.
https://bugs.webkit.org/show_bug.cgi?id=126767
Reviewed by Joseph Pecoraro.
- page/Console.cpp:
(WebCore::internalAddMessage):
- page/PageConsole.cpp:
(WebCore::PageConsole::printSourceURLAndPosition):
(WebCore::PageConsole::printMessageSourceAndLevelPrefix):
- page/PageConsole.h:
- 2:13 PM Changeset in webkit [161677] by
-
- 2 edits in trunk/Source/WebInspectorUI
Clean up some areas of TreeOutline.
https://bugs.webkit.org/show_bug.cgi?id=123924
Reviewed by Joseph Pecoraro.
- UserInterface/TreeOutline.js:
(TreeOutline.prototype.appendChild): Don't force create _childrenListNode, it will be created
when the tree element is expanded. Only attach if _childrenListNode already exists.
(TreeOutline.prototype.insertChild): Ditto.
(TreeOutline.prototype.getCachedTreeElement): Check the value of treeElementIdentifier
not just the existence of the property. It should never be null/undefined/0, but be safe.
(TreeOutline.prototype.findTreeElement): Null check isAncestor, it isn't required.
- 2:11 PM Changeset in webkit [161676] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fill in missing WebCoreThread function pointers
https://bugs.webkit.org/show_bug.cgi?id=126776
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-10
Reviewed by Timothy Hatcher.
- platform/ios/wak/WebCoreThreadSystemInterface.cpp:
(InitWebCoreThreadSystemInterface):
- 2:10 PM Changeset in webkit [161675] by
-
- 8 edits2 adds in trunk/Source
Clear unparented tiled layers on memory pressure.
https://bugs.webkit.org/show_bug.cgi?id=126737
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-10
Reviewed by Simon Fraser.
Source/WebCore:
TileController hold unparented tiles for a short period of time (1 -3 sec); we should clear these unparented
tiles immediately if we are under memory pressure.
The patch does 3 things to improve the behavior:
1) When the system free memory is low (<35%), reduce the tiling threshold. This could reduce
the peak memory usage when system is under low memory since we will convert more web layers into
tiled backing.
2) Under memory pressure, immediately clear all unparented tiles.
3) Add a cap (16 tiles) to limit the total number of unparented tiles in TileController's.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj: Add a new class TileControllerMemoryHandler.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::requiresTiledLayer): Use a smaller tiling threshold if the system free memory is low.
- platform/graphics/ca/mac/TileController.h:
(WebCore::TileController::numberOfUnparentedTiles):
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::startedNewCohort):
(WebCore::TileController::removeUnparentedTilesNow): Remove all unparentd tiles.
- platform/ios/MemoryPressureHandlerIOS.mm:
- platform/ios/TileControllerMemoryHandlerIOS.cpp: Added.
(WebCore::TileControllerMemoryHandler::removeTileController):
(WebCore::TileControllerMemoryHandler::totalUnparentedTiledLayers):
(WebCore::TileControllerMemoryHandler::tileControllerGainUnparentedTiles):
(WebCore::TileControllerMemoryHandler::trimUnparentedTilesToTarget): Trims the number of unparented tiles until
it reaches the target.
(WebCore::tileControllerMemoryHandler):
- platform/ios/TileControllerMemoryHandlerIOS.h: Added.
(WebCore::TileControllerMemoryHandler::TileControllerMemoryHandler):
Source/WebKit/mac:
- WebView/WebView.mm:
(+[WebView _handleMemoryWarning]): Clear all unparented tiles when under memory pressure.
- 2:06 PM Changeset in webkit [161674] by
-
- 2 edits in trunk/Source/WebInspectorUI
Fix an exception in WebInspector.Color.
https://bugs.webkit.org/show_bug.cgi?id=126765
Reviewed by Joseph Pecoraro.
- UserInterface/Color.js:
(WebInspector.Color.fromString): Check hasOwnPrperty before using the nickname color array.
(WebInspector.Color.prototype._toNicknameString): Ditto.
- 1:42 PM Changeset in webkit [161673] by
-
- 6 edits in trunk/Source
[CSS Blending] Log blending as a layer creation reason in the WI
https://bugs.webkit.org/show_bug.cgi?id=126159
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-10
Reviewed by Timothy Hatcher.
Source/WebCore:
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
- inspector/protocol/LayerTree.json:
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._populateListOfCompositingReasons):
- 1:37 PM Changeset in webkit [161672] by
-
- 10 edits in trunk
[EFL][JSC] Enable udis86 disassembler on efl.
https://bugs.webkit.org/show_bug.cgi?id=125502
Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-01-10
Reviewed by Michael Saboff.
Enable udis86 disassembler on efl and fix build warnings.
.:
- Source/cmake/OptionsEfl.cmake: Enable udis86 disassembler.
Source/JavaScriptCore:
- CMakeLists.txt: Add udis86 disassembler source files.
- disassembler/udis86/udis86_decode.c:
(decode_modrm_rm):
Build warning fixes.
- disassembler/udis86/udis86_syn-att.c:
(gen_operand):
Build warning fixes.
- disassembler/udis86/udis86_syn-intel.c:
(gen_operand):
Build warning fixes.
- disassembler/udis86/udis86_types.h: Correct FMT64 for uint64_t.
Source/WTF:
- wtf/Platform.h: Enable udis86 disassembler on EFL.
- 1:37 PM Changeset in webkit [161671] by
-
- 2 edits in trunk/Source/WebCore
Fix some iOS build errors during bindings generation.
- bindings/objc/PublicDOMInterfaces.h: Included
WebKitAdditions/PublicDOMInterfacesIOS.h and change
-[DOMRGBColor color] to return a CGColorRef on iOS.
- 1:31 PM Changeset in webkit [161670] by
-
- 2 edits in trunk/Source/WebCore
Prevent some resources from showing up in Web Inspector as years in duration.
No WebKit port passed a monotonic time to InspectorInstrumentation::didFinishLoading -- except Chromium.
https://bugs.webkit.org/show_bug.cgi?id=126760
Reviewed by Joseph Pecoraro.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didFinishLoadingImpl):
Revert part of r102961 to use finishTime as-is and not expect a monotonic time.
- 1:29 PM Changeset in webkit [161669] by
-
- 4 edits16 adds in trunk
Make clipping path from basic-shapes relative to <box> value
https://bugs.webkit.org/show_bug.cgi?id=126206
Reviewed by Simon Fraser.
Source/WebCore:
Tests: css3/masking/clip-path-circle-border-box.html
css3/masking/clip-path-circle-bounding-box.html
css3/masking/clip-path-circle-content-box.html
css3/masking/clip-path-circle-margin-box.html
css3/masking/clip-path-circle-padding-box.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setupClipPath): Add switch to differ between boxes
and use different reference boxes to size the clipping path.
LayoutTests:
Add new tests to check that different reference boxes are chosen for sizing and
positioning the clipping path.
- css3/masking/clip-path-circle-border-box.html: Added.
- css3/masking/clip-path-circle-bounding-box.html: Added.
- css3/masking/clip-path-circle-content-box.html: Added.
- css3/masking/clip-path-circle-margin-box.html: Added.
- css3/masking/clip-path-circle-padding-box.html: Added.
- platform/mac/css3/masking/clip-path-circle-border-box-expected.png: Added.
- platform/mac/css3/masking/clip-path-circle-border-box-expected.txt: Added.
- platform/mac/css3/masking/clip-path-circle-bounding-box-expected.png: Added.
- platform/mac/css3/masking/clip-path-circle-bounding-box-expected.txt: Added.
- platform/mac/css3/masking/clip-path-circle-content-box-expected.png: Added.
- platform/mac/css3/masking/clip-path-circle-content-box-expected.txt: Added.
- platform/mac/css3/masking/clip-path-circle-margin-box-expected.png: Added.
- platform/mac/css3/masking/clip-path-circle-margin-box-expected.txt: Added.
- platform/mac/css3/masking/clip-path-circle-padding-box-expected.png: Added.
- platform/mac/css3/masking/clip-path-circle-padding-box-expected.txt: Added.
- platform/mac/css3/masking/mask-luminance-png-expected.png: Added.
- 1:22 PM Changeset in webkit [161668] by
-
- 9 edits10 adds in trunk
Source/WebCore: Correctly set XHR loadend attributes (loaded and total).
https://bugs.webkit.org/show_bug.cgi?id=120828
Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-10
Reviewed by Alexey Proskuryakov.
Added correct initialization of lengthComputable, loaded and total attributes
to XHR ProgressEvent events (load, loadstart, loadend, abort, error and timeout).
XMLHttpRequestProgressEventThrottle and XMLHttpRequestUpload now keep persistent knowledge
of m_loaded and m_total values with this patch.
Code refactoring to handle event dispatching in case of error in a single manner.
XMLHttpRequestProgressEventThrottle::dispatchProgressEvent is renamed as dispatchThrottledProgressEvent
XMLHttpRequestProgressEventThrottle::dispatchEventAndLoadend is replaced by dispatchProgressEvent(const AtomicString&)
Fixed assertion issues over bug 120828 patch
Tests: http/tests/xmlhttprequest/loadstart-event-init.html
http/tests/xmlhttprequest/onabort-progressevent-attributes.html
http/tests/xmlhttprequest/onload-progressevent-attributes.html
http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html
http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::callReadyStateChangeListener): changed readystatechange event from ProgressEvent to Event (not cancellable, not bubblable) to better match the spec
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::abort): code refactoring to handle error event dispatching in a single way
(WebCore::XMLHttpRequest::networkError): code refactoring to handle error event dispatching in a single way
(WebCore::XMLHttpRequest::abortError): code refactoring to handle error event dispatching in a single way
(WebCore::XMLHttpRequest::didSendData):
(WebCore::XMLHttpRequest::didReceiveData):
(WebCore::XMLHttpRequest::dispatchErrorEvents): dispatch progress events in case of error
(WebCore::XMLHttpRequest::didTimeout): code refactoring to handle error event dispatching in a single way
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestProgressEventThrottle.cpp: before the patch, the fact that a progress event is being throttled is stored indirectly (m_loaded or m_total not equal to zero). With the patch, this information is stored in m_hasThrottledProgressEvent. The m_loaded and m_total values are no longer set back to zero after a progress event is dispatched. This allows using these values to correctly initialize other ProgressEvent events (in particular loadend, abort, timeout...)
(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchThrottledProgressEvent): always update the new m_loaded and m_total values. If progress event is not sent as part of the function call, store the fact that a progress event is being throttled through m_hasThrottledProgressEvent.
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): used to send any ProgressEvent event that is not be throttled
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent): after the call, no progress event is throttled anymore
(WebCore::XMLHttpRequestProgressEventThrottle::fired): after the call, no progress event is throttled anymore
(WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch):
(WebCore::XMLHttpRequestProgressEventThrottle::suspend):
- xml/XMLHttpRequestProgressEventThrottle.h: introduced m_hasThrottledProgressEvent which stores whether a progress event is being throttled and m_computableLength which is used to initialize ProgressEvent computableLength
- xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
(WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
- xml/XMLHttpRequestUpload.h: introduced m_loaded, m_total and m_lengthComputable, similarly to XMLHttpRequestProgressEventThrottle
LayoutTests: Correctly set XHR loadend event attributes (loaded and total).
https://bugs.webkit.org/show_bug.cgi?id=120828
Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-10
Reviewed by Alexey Proskuryakov.
Tests for abort, load, loadstart and loadend ProgressEvent events for XMLHttpRequest and XMLHttpRequestUpload
- fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Changed to correct event values
- http/tests/xmlhttprequest/loadstart-event-init-expected.txt: Added.
- http/tests/xmlhttprequest/loadstart-event-init.html: Added.
- http/tests/xmlhttprequest/onabort-progressevent-attributes-expected.txt: Added.
- http/tests/xmlhttprequest/onabort-progressevent-attributes.html: Added.
- http/tests/xmlhttprequest/onload-progressevent-attributes-expected.txt: Added.
- http/tests/xmlhttprequest/onload-progressevent-attributes.html: Added.
- http/tests/xmlhttprequest/upload-onabort-progressevent-attributes-expected.txt: Added.
- http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html: Added.
- http/tests/xmlhttprequest/upload-onload-progressevent-attributes-expected.txt: Added.
- http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html: Added.
- 1:12 PM Changeset in webkit [161667] by
-
- 3 edits in trunk/Source/WebCore
[CSS Shapes] Change parseBasicShape to return a CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=126713
Reviewed by Dirk Schulze.
Avoid the duplicated code wrapping the CSSBasicShape in a CSSPrimitiveValue
by having parseBasicShape return a CSSPrimitiveValue reference.
Refactoring, no new tests.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseShapeProperty):
(WebCore::CSSParser::parseClipPath):
(WebCore::CSSParser::parseBasicShape):
- css/CSSParser.h:
- 1:10 PM Changeset in webkit [161666] by
-
- 29 edits in trunk
Move platformName property from testRunner to accessibilityController
https://bugs.webkit.org/show_bug.cgi?id=126689
Reviewed by Chris Fleizach.
Tools:
Move the platformName property from the testRunner into
accessibilityController, since this is a concept that has only be
used by accessibility tests since it got added, and also because
the real intention was not to distinguish among "ports" (mac, win,
gtk, efl) but between platforms (atk, mac, win).
This change will be very useful to merge GTK's roles-exposed.html
and Mac's role-subrole-roledescription.html into one single test,
since we will be specifying in the test itself which elements are
supported in which accessibility "platform". In this context,
being able to check accessibilityController.platformName directly
against a list of supported accessibility platforms (e.g. "atk,mac")
will certainly maintain the code cleaner and simpler.
- DumpRenderTree/TestRunner.h:
(TestRunner::platformName): Removed.
- DumpRenderTree/TestRunner.cpp:
(getPlatformNameCallback): Removed.
(TestRunner::staticValues): Removed platformName
- DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::platformName): Removed.
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::platformName): Removed.
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::platformName): Removed.
- DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::platformName): Removed.
- DumpRenderTree/AccessibilityController.h:
(AccessibilityController::platformName): Added.
- DumpRenderTree/AccessibilityController.cpp:
(getPlatformNameCallback): Added.
(AccessibilityController::getJSClass): Added platformName.
- DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
(AccessibilityController::platformName): Added, returning "atk".
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::platformName): Ditto, returning "mac".
- DumpRenderTree/ios/AccessibilityControllerIOS.mm:
(AccessibilityController::platformName): Ditto, returning "ios".
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::platformName): Ditto, returning "win".
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
(platformName): Removed.
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner::platformName): Removed.
- WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
(TestRunner::platformName): Removed.
- WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
(TestRunner::platformName): Removed.
- WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
(TestRunner::platformName): Removed.
- WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
(TestRunner::platformName): Removed.
- WebKitTestRunner/InjectedBundle/AccessibilityController.h:
(WTR:AccessibilityController::platformName): Added.
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
(platformName): Added.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::AccessibilityController::platformName): Added, returning "atk".
- WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
(WTR::AccessibilityController::platformName): Added, returning "mac".
LayoutTests:
Updated tests and expectations affected by the move of
platformName from TestRunner to AccessibilityController.
- accessibility/canvas-fallback-content.html:
- accessibility/ignore-spacer-elements.html:
- accessibility/platform-name.html:
- platform/efl/accessibility/platform-name-expected.txt:
- platform/gtk/accessibility/platform-name-expected.txt:
- 1:08 PM Changeset in webkit [161665] by
-
- 2 edits in trunk/Source/WebCore
Possible crash in ApplicationCache::removeResource.
https://bugs.webkit.org/show_bug.cgi?id=126695
Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-10
Reviewed by Alexey Proskuryakov.
No new tests.
Iterator variable was used after it was removed.
- loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::removeResource):
- 12:51 PM Changeset in webkit [161664] by
-
- 2 edits in trunk/Source/WebCore
Another build fix for the Production Mac build following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)
Move the logic for appending the port-specific IDL files {Touch, TouchEvent, TouchList}.idl to the
list of binding IDLs (BINDING_IDLS) before the definition of variables DOM_CLASSES and JS_DOM_HEADERS
so that we generate the DOM and JS bindings for these IDLs.
- DerivedSources.make:
- 12:47 PM Changeset in webkit [161663] by
-
- 5 edits6 deletes in trunk
Remove supportMultipleWindows setting
https://bugs.webkit.org/show_bug.cgi?id=126772
Reviewed by Beth Dakin.
Source/WebCore:
This setting was added in https://bugs.webkit.org/show_bug.cgi?id=99716 for the Chromium port
and is unused by everyone else so get rid of it.
- loader/FrameLoader.cpp:
(WebCore::createWindow):
- page/ContextMenuController.cpp:
(WebCore::openNewWindow):
- page/Settings.in:
LayoutTests:
- fast/dom/HTMLAnchorElement/anchor-no-multiple-windows-expected.txt: Removed.
- fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html: Removed.
- fast/dom/Window/window-open-no-multiple-windows-expected.txt: Removed.
- fast/dom/Window/window-open-no-multiple-windows.html: Removed.
- fast/forms/post-popup-no-multiple-windows-expected.txt: Removed.
- fast/forms/post-popup-no-multiple-windows.html: Removed.
- 12:41 PM Changeset in webkit [161662] by
-
- 29 edits in trunk/Source
Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.
Source/WebCore:
- dom/TouchEvent.cpp:
(WebCore::TouchEvent::TouchEvent):
(WebCore::TouchEvent::initTouchEvent):
- dom/TouchEvent.h:
- dom/ViewportArguments.cpp:
- dom/ViewportArguments.h:
- history/HistoryItem.h:
- loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::createResourceHandle):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading):
- page/NavigatorBase.cpp:
- page/Settings.cpp:
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::create):
- platform/Cursor.cpp:
- platform/Cursor.h:
(WebCore::Cursor::Cursor):
- platform/DragData.h:
- platform/DragImage.h:
- plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintsIntoWindow):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):
- testing/Internals.cpp:
(WebCore::Internals::getCurrentCursorInfo):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::load):
- workers/Worker.cpp:
(WebCore::Worker::create):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::importScripts):
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::createResourceRequest):
- workers/WorkerScriptLoader.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setCursor):
- 12:40 PM Changeset in webkit [161661] by
-
- 12 edits in trunk
Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.
.:
- CMakeLists.txt:
Source/WebCore:
- Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::initProtocolHandlerWhitelist):
- UseJSC.cmake:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
- bindings/js/GCController.cpp:
(WebCore::GCController::GCController):
(WebCore::GCController::garbageCollectSoon):
- bindings/js/GCController.h:
Source/WebKit2:
- Scripts/generate-forwarding-headers.pl:
Tools:
- Scripts/webkitpy/common/config/watchlist:
- 12:38 PM Changeset in webkit [161660] by
-
- 4 edits in trunk/Source
Fix the WebCore, WebKit build targets following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)
Source/WebCore:
Tell Xcode that the supported platforms for all WebKit targets are iOS and OS X.
- Configurations/Base.xcconfig:
Source/WebKit/mac:
Tell Xcode that the supported platforms for all WebCore targets are iOS and OS X.
- Configurations/Base.xcconfig:
- 11:50 AM Changeset in webkit [161659] by
-
- 4 edits5 deletes in trunk
Remove the BlackBerry files outside WebCore
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
.:
- ManualTests/blackberry: Removed.
- Source/cmake/OptionsBlackBerry.cmake: Removed.
Source/JavaScriptCore:
- PlatformBlackBerry.cmake: Removed.
- runtime/GCActivityCallbackBlackBerry.cpp: Removed.
- shell/PlatformBlackBerry.cmake: Removed.
Tools:
- DumpRenderTree/blackberry: Removed.
LayoutTests:
- platform/blackberry: Removed.
- 11:32 AM Changeset in webkit [161658] by
-
- 4 edits in trunk/Source
[iOS] Upstream iOS changes to MigrateHeaders.make
https://bugs.webkit.org/show_bug.cgi?id=126731
Reviewed by David Kilzer.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Mark an iOS-specific header at
Private that will later be migrated by WebKit.
Source/WebKit/mac:
- MigrateHeaders.make: Migrate iOS-specific headers when building for iOS.
- 11:13 AM Changeset in webkit [161657] by
-
- 2 edits in trunk/Source/WebCore
Fix the Production Mac build following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)
Substitute JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production_ for JAVASCRIPTCORE_PRIVATE_HEADERS_Production_.
- Configurations/WebCore.xcconfig:
- 11:12 AM Changeset in webkit [161656] by
-
- 6 edits in trunk/Tools
Remove knowledge of Blackberry from build scripts
https://bugs.webkit.org/show_bug.cgi?id=126766
Reviewed by Anders Carlsson.
Remove isBlackBerry() and references to it, and rmeove
blackberry-related stuff from the watchlist.
- Scripts/build-webkit:
- Scripts/webkit-build-directory:
- Scripts/webkitdirs.pm:
(determineBaseProductDir):
(argumentsForConfiguration):
(builtDylibPathForName):
(isAppleWebKit):
(buildCMakeProjectOrExit):
(cmakeBasedPortArguments):
(cmakeBasedPortName):
- Scripts/webkitperl/FeatureList.pm:
- Scripts/webkitpy/common/config/watchlist:
- 11:07 AM Changeset in webkit [161655] by
-
- 2 edits in trunk/Source/WebCore
Add a missing include.
- Modules/webdatabase/DatabaseManager.h:
- 11:02 AM Changeset in webkit [161654] by
-
- 4 edits in trunk/Source/WebCore
Use STL threading primitives in DatabaseDetails and DatabaseManager
https://bugs.webkit.org/show_bug.cgi?id=126759
Reviewed by Geoffrey Garen.
- Modules/webdatabase/DatabaseDetails.h:
(WebCore::DatabaseDetails::DatabaseDetails):
(WebCore::DatabaseDetails::threadID):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::existingDatabaseContextFor):
(WebCore::DatabaseManager::registerDatabaseContext):
(WebCore::DatabaseManager::unregisterDatabaseContext):
(WebCore::DatabaseManager::didConstructDatabaseContext):
(WebCore::DatabaseManager::didDestructDatabaseContext):
(WebCore::DatabaseManager::addProposedDatabase):
(WebCore::DatabaseManager::removeProposedDatabase):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::detailsForNameAndOrigin):
- Modules/webdatabase/DatabaseManager.h:
- 10:59 AM Changeset in webkit [161653] by
-
- 4 edits7 deletes in trunk
Unreviewed, rolling out r161629.
http://trac.webkit.org/changeset/161629
https://bugs.webkit.org/show_bug.cgi?id=126762
Fails svg/custom/conditional-processing-2.html (Requested by
ap on #webkit).
Source/WebCore:
- svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::childShouldCreateRenderer):
- svg/SVGTests.cpp:
(WebCore::SVGTests::hasExtension):
(WebCore::SVGTests::isValid):
LayoutTests:
- svg/custom/conditional-processing-1-expected.txt: Removed.
- svg/custom/conditional-processing-1.svg: Removed.
- svg/custom/conditional-processing-2-expected.txt: Removed.
- svg/custom/conditional-processing-2.html: Removed.
- svg/dom/SVGTests-expected.txt: Removed.
- svg/dom/SVGTests.html: Removed.
- svg/dom/script-tests/SVGTests.js: Removed.
- 10:53 AM Changeset in webkit [161652] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix since r161589.
The changeset causes a compile failure with --no-svg.
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::drawGlyphBuffer):
- 10:49 AM Changeset in webkit [161651] by
-
- 3 edits in trunk/Tools
[iOS] Fix up simulator build and enable default features
Rubber-stamped by Joseph Pecoraro.
- Scripts/webkitdirs.pm:
(determineArchitecture):
(determinePassedArchitecture):
- Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
by default only in iOS).
- 10:38 AM Changeset in webkit [161650] by
-
- 7 edits2 deletes in trunk/Source/JavaScriptCore
Removed Blackberry #ifdefs and platform code from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=126757
Reviewed by Sam Weinig.
- PlatformBlackBerry.cmake: Removed.
- heap/HeapTimer.cpp:
- heap/HeapTimer.h:
- heap/IncrementalSweeper.cpp:
- heap/IncrementalSweeper.h:
- jsc.cpp:
(main):
- runtime/GCActivityCallbackBlackBerry.cpp: Removed.
- runtime/MemoryStatistics.cpp:
(JSC::globalMemoryStatistics):
- 10:22 AM Changeset in webkit [161649] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
[WebGL] Removing unnecessary pointer checks
https://bugs.webkit.org/show_bug.cgi?id=124046
Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2014-01-10
Reviewed by Brent Fulgham.
We do not need to check for a null array three times in
the same call. Let's just do it once!
No new tests. Covered by existing ones.
- html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::associateBufferData):
- 10:22 AM Changeset in webkit [161648] by
-
- 2 edits in trunk/Source/WebCore
Speculative build fix for Windows following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)
Patch by Daniel Bates <dabates@apple.com> on 2014-01-10
Reviewed by David Kilzer.
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
- 10:20 AM Changeset in webkit [161647] by
-
- 2 edits in trunk/Source/WebCore
Speculative build fix for Windows following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
- 10:15 AM Changeset in webkit [161646] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test correction after r161605.
- platform/mac/TestExpectations: Reactivate tests fixed by
- 10:12 AM Changeset in webkit [161645] by
-
- 2 edits in trunk/Source/WebCore
[WebGL] Wrong condition order in the if statement
https://bugs.webkit.org/show_bug.cgi?id=125000
Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2014-01-10
Reviewed by Brent Fulgham.
We should only pay the cost of string comparison once. The
current logic requires a string comparison every time we
pass through the function. Instead, by reordering the statements
we can short-circuit through the boolean test after the initial
setup is complete.
No new tests. No behaviour changes.
- platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::supportsExtension):
- 9:50 AM Changeset in webkit [161644] by
-
- 8 edits in trunk/Source/WebCore
CTTE in AudioContext::AutoLocker
https://bugs.webkit.org/show_bug.cgi?id=126758
Reviewed by Antti Koivisto.
- Modules/webaudio/AudioBasicInspectorNode.cpp:
(WebCore::AudioBasicInspectorNode::connect):
(WebCore::AudioBasicInspectorNode::disconnect):
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::setBuffer):
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::refNode):
(WebCore::AudioContext::deleteMarkedNodes):
(WebCore::AudioContext::removeMarkedSummingJunction):
- Modules/webaudio/AudioContext.h:
(WebCore::AudioContext::AutoLocker::AutoLocker):
(WebCore::AudioContext::AutoLocker::~AutoLocker):
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::connect):
(WebCore::AudioNode::disconnect):
(WebCore::AudioNode::setChannelCount):
(WebCore::AudioNode::setChannelCountMode):
(WebCore::AudioNode::setChannelInterpretation):
(WebCore::AudioNode::enableOutputsIfNecessary):
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::setFormat):
- Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::setOversample):
- 9:45 AM Changeset in webkit [161643] by
-
- 6 edits in trunk/Source/WebCore
Use element iterators more
https://bugs.webkit.org/show_bug.cgi?id=126756
Reviewed by Anders Carlsson.
- dom/VisitedLinkState.cpp:
(WebCore::VisitedLinkState::invalidateStyleForAllLinks):
(WebCore::VisitedLinkState::invalidateStyleForLink):
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::renderMeter):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::renderProgress):
- html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::ensureInsertionPointList):
- style/StyleResolveTree.cpp:
- 9:37 AM Changeset in webkit [161642] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the iOS build after <http://trac.webkit.org/changeset/161589>
(https://bugs.webkit.org/show_bug.cgi?id=126654)
- platform/audio/ios/AudioSessionIOS.mm: Import header PassOwnPtr.h so that we can use adoptPtr().
- 9:19 AM Changeset in webkit [161641] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the build after <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)
Substitute tab characters for space characters.
- DerivedSources.make:
- 9:17 AM Changeset in webkit [161640] by
-
- 3 edits in trunk/WebKitLibraries
[WinCairo] Crash when rendering (in pixman dll)
https://bugs.webkit.org/show_bug.cgi?id=126750
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-01-10
Reviewed by Brent Fulgham.
Since we link with cairo.lib, and the gstreamer installation also comes with cairo.lib,
we link with the wrong cairo.lib, and loads gstreamers cairo dll, instead of our own.
We should user our own cairo dll for rendering.
- win/tools/vsprops/GStreamer32.props: Put gstreamer lib path last, so we link with the correct cairo.lib.
- win/tools/vsprops/GStreamer64.props: Ditto.
- 9:07 AM Changeset in webkit [161639] by
-
- 4 edits in trunk/Source/WebCore
DOMWindow::showModalDialog should use std::function
https://bugs.webkit.org/show_bug.cgi?id=126753
Reviewed by Antti Koivisto.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::DialogHandler::dialogCreated):
(WebCore::JSDOMWindow::showModalDialog):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::showModalDialog):
- page/DOMWindow.h:
- 9:06 AM Changeset in webkit [161638] by
-
- 107 edits2 copies27 adds in trunk
[iOS] Upstream WebCore and Tools miscellaneous changes
https://bugs.webkit.org/show_bug.cgi?id=126698
Reviewed by David Kilzer.
Source/WebCore:
- Configurations/Base.xcconfig:
- Configurations/WebCore.xcconfig:
- Configurations/WebCoreTestSupport.xcconfig:
- Configurations/iOS.xcconfig: Added.
- DerivedSources.make:
- English.lproj/Localizable.strings:
- Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.cpp: Copied from Source/WebCore/editing/TextAffinity.h.
(WebCore::stringForPlaybackTargetAvailability):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::WebKitPlaybackTargetAvailabilityEvent):
- Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h: Added.
(WebCore::WebKitPlaybackTargetAvailabilityEventInit::WebKitPlaybackTargetAvailabilityEventInit):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::~WebKitPlaybackTargetAvailabilityEvent):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::create):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::availability):
- Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.idl: Copied from Source/WebCore/editing/DeleteButton.h.
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::canSuspend):
(WebCore::Geolocation::suspend):
(WebCore::Geolocation::resume):
(WebCore::Geolocation::resumeTimerFired):
(WebCore::Geolocation::resetAllGeolocationPermission):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::setIsAllowed):
(WebCore::Geolocation::positionChanged):
(WebCore::Geolocation::setError):
- Modules/geolocation/Geolocation.h:
- Modules/geolocation/NavigatorGeolocation.cpp:
(WebCore::NavigatorGeolocation::resetAllGeolocationPermission):
- Modules/geolocation/NavigatorGeolocation.h:
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore::SpeechSynthesis::speak):
- Modules/speech/SpeechSynthesis.h:
(WebCore::SpeechSynthesis::userGestureRequiredForSpeechStart):
(WebCore::SpeechSynthesis::removeBehaviorRestriction):
- Modules/webaudio/AudioContext.cpp:
- Modules/webaudio/AudioContext.h:
- Modules/webaudio/AudioScheduledSourceNode.cpp:
- Modules/webdatabase/Database.cpp:
- Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::incrementalVacuumIfNeeded):
- Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::DatabaseContext):
(WebCore::DatabaseContext::databaseThread):
(WebCore::DatabaseContext::setPaused):
- Modules/webdatabase/DatabaseContext.h:
- Modules/webdatabase/DatabaseManagerClient.h:
- Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseTask::performTask):
(WebCore::Database::DatabaseTransactionTask::shouldPerformWhilePaused):
- Modules/webdatabase/DatabaseTask.h:
- Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::DatabaseThread):
(WebCore::DatabaseThread::requestTermination):
(WebCore::DatabaseUnpauseTask::create):
(WebCore::DatabaseUnpauseTask::shouldPerformWhilePaused):
(WebCore::DatabaseUnpauseTask::DatabaseUnpauseTask):
(WebCore::DatabaseUnpauseTask::doPerformTask):
(WebCore::DatabaseUnpauseTask::debugTaskName):
(WebCore::DatabaseThread::setPaused):
(WebCore::DatabaseThread::handlePausedQueue):
(WebCore::DatabaseThread::databaseThread):
- Modules/webdatabase/DatabaseThread.h:
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):
(WebCore::DatabaseTracker::removeDeletedOpenedDatabases):
(WebCore::isZeroByteFile):
(WebCore::DatabaseTracker::deleteDatabaseFileIfEmpty):
(WebCore::DatabaseTracker::openDatabaseMutex):
(WebCore::DatabaseTracker::emptyDatabaseFilesRemovalTaskWillBeScheduled):
(WebCore::DatabaseTracker::emptyDatabaseFilesRemovalTaskDidFinish):
(WebCore::DatabaseTracker::setDatabasesPaused):
- Modules/webdatabase/DatabaseTracker.h:
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::shouldPerformWhilePaused):
- Modules/webdatabase/SQLTransactionBackend.h:
- Resources/DictationPhraseWithAlternativesDot.png: Added.
- Resources/DictationPhraseWithAlternativesDot@2x.png: Added.
- Resources/SpellingDot.png: Added.
- Resources/SpellingDot@2x.png: Added.
- Resources/decrementArrow.tiff: Added.
- Resources/hScrollControl_left.png: Added.
- Resources/hScrollControl_middle.png: Added.
- Resources/hScrollControl_right.png: Added.
- Resources/incrementArrow.tiff: Added.
- Resources/markedLeft.png: Added.
- Resources/markedMiddle.png: Added.
- Resources/markedRight.png: Added.
- Resources/vScrollControl_bottom.png: Added.
- Resources/vScrollControl_middle.png: Added.
- Resources/vScrollControl_top.png: Added.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/GCController.cpp:
(WebCore::GCController::garbageCollectNow):
(WebCore::GCController::releaseExecutableMemory):
- bindings/js/GCController.h:
- bindings/js/JSCallbackData.h:
(WebCore::JSCallbackData::~JSCallbackData):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsProfiling):
(WebCore::JSDOMWindowBase::shouldInterruptScriptBeforeTimeout):
(WebCore::JSDOMWindowBase::commonVM):
(WebCore::JSDOMWindowBase::commonVMExists):
(WebCore::JSDOMWindowBase::commonVMInternal):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::touch):
(WebCore::JSDOMWindow::touchList):
- bindings/js/JSDeviceOrientationEventCustom.cpp:
(WebCore::JSDeviceOrientationEvent::webkitCompassHeading):
(WebCore::JSDeviceOrientationEvent::webkitCompassAccuracy):
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):
- bindings/js/JSMainThreadExecState.h:
- bindings/js/JSTouchCustom.cpp:
- bindings/js/JSTouchListCustom.cpp:
- bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::didContinue):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::initializeThreading):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::handlePause):
- bindings/js/ios/TouchConstructors.cpp: Added.
- bindings/objc/DOM.mm:
(WebCore::wkQuadFromFloatQuad):
(WebCore::kit):
(WebCore::min4):
(WebCore::max4):
(WebCore::emptyQuad):
(-[WKQuadObject initWithQuad:]):
(-[WKQuadObject quad]):
(-[WKQuadObject boundingBox]):
(-[DOMNode boundingBox]):
(-[DOMNode absoluteQuad]):
(-[DOMNode absoluteQuadAndInsideFixedPosition:]):
(-[DOMNode boundingBoxUsingTransforms]):
(-[DOMNode lineBoxQuads]):
(-[DOMNode _linkElement]):
(-[DOMNode hrefURL]):
(-[DOMNode hrefTarget]):
(-[DOMNode hrefFrame]):
(-[DOMNode hrefLabel]):
(-[DOMNode hrefTitle]):
(-[DOMNode boundingFrame]):
(-[DOMNode innerFrameQuad]):
(-[DOMNode computedFontSize]):
(-[DOMNode nextFocusNode]):
(-[DOMNode previousFocusNode]):
(-[DOMRange boundingBox]):
(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
(-[DOMElement _font]):
(-[DOMHTMLLinkElement _mediaQueryMatchesForOrientation:]):
(-[DOMHTMLLinkElement _mediaQueryMatches]):
- bindings/objc/DOMEvents.h:
- bindings/objc/DOMEvents.mm:
(kitClass):
- bindings/objc/DOMExtensions.h:
- bindings/objc/DOMHTML.mm:
(-[DOMHTMLElement scrollYOffset]):
(-[DOMHTMLElement setScrollXOffset:scrollYOffset:]):
(-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
(-[DOMHTMLElement absolutePosition::::]):
(-[DOMHTMLInputElement _autocapitalizeType]):
(-[DOMHTMLTextAreaElement _autocapitalizeType]):
(-[DOMHTMLInputElement setValueWithChangeEvent:]):
(-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]):
- bindings/objc/DOMInternal.h:
- bindings/objc/DOMInternal.mm:
(wrapperCacheLock):
(getDOMWrapper):
(addDOMWrapper):
(removeDOMWrapper):
- bindings/objc/DOMPrivate.h:
- bindings/objc/DOMUIKitExtensions.h: Added.
- bindings/objc/DOMUIKitExtensions.mm: Added.
- bindings/objc/PublicDOMInterfaces.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackImplementation):
- bindings/scripts/CodeGeneratorObjC.pm:
(ReadPublicInterfaces):
(GetClassName):
(IsCoreFoundationType):
(GetObjCType):
(AddIncludesForType):
(GenerateHeader):
(GenerateImplementation):
(WriteData):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
- bridge/objc/objc_class.mm:
(JSC::Bindings::ObjcClass::fieldNamed):
- bridge/objc/objc_instance.mm:
- config.h:
- dom/Document.cpp:
(WebCore::Document::addAutoSizingNode):
- dom/Document.h:
- dom/Document.idl:
- dom/ios/TouchEvents.cpp: Added.
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle):
- editing/CompositeEditCommand.cpp:
(WebCore::EditCommandComposition::unapply):
(WebCore::CompositeEditCommand::apply):
(WebCore::CompositeEditCommand::inputText):
(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
(WebCore::CompositeEditCommand::moveParagraphs):
- editing/CompositeEditCommand.h:
- editing/DeleteButton.h:
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::enable):
(WebCore::DeleteButtonController::disable):
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::doApply):
- editing/DeleteSelectionCommand.h:
- editing/EditAction.h:
- editing/EditCommand.h:
(WebCore::EditCommand::isInsertTextCommand):
- editing/EditingStyle.cpp:
- editing/Editor.cpp:
(WebCore::ClearTextCommand::ClearTextCommand):
(WebCore::ClearTextCommand::editingAction):
(WebCore::ClearTextCommand::CreateAndApply):
(WebCore::Editor::handleTextEvent):
(WebCore::Editor::clearText):
(WebCore::Editor::insertDictationPhrases):
(WebCore::Editor::setDictationPhrasesAsChildOfElement):
(WebCore::Editor::confirmMarkedText):
(WebCore::Editor::setTextAsChildOfElement):
(WebCore::Editor::notifyComponentsOnChangedSelection):
(WebCore::Editor::ensureLastEditCommandHasCurrentSelectionIfOpenForMoreTyping):
(WebCore::Editor::copy):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::setComposition):
(WebCore::Editor::showSpellingGuessPanel):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::markMisspellingsOrBadGrammar):
(WebCore::Editor::changeBackToReplacedString):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):
(WebCore::Editor::setIgnoreCompositionSelectionChange):
(WebCore::Editor::changeSelectionAfterCommand):
(WebCore::Editor::shouldChangeSelection):
(WebCore::Editor::respondToChangedSelection):
(WebCore::Editor::resolveTextCheckingTypeMask):
- editing/Editor.h:
- editing/EditorCommand.cpp:
(WebCore::executeClearText):
(WebCore::enabledCopy):
(WebCore::enabledCut):
(WebCore::enabledClearText):
(WebCore::createCommandMap):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::modifyExtendingRight):
(WebCore::FrameSelection::modifyExtendingForward):
(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingForward):
(WebCore::FrameSelection::modifyExtendingLeft):
(WebCore::FrameSelection::modifyExtendingBackward):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::modifyMovingBackward):
(WebCore::FrameSelection::setSelectedRange):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
(WebCore::FrameSelection::updateAppearance):
(WebCore::FrameSelection::shouldDeleteSelection):
(WebCore::FrameSelection::revealSelection):
(WebCore::FrameSelection::setSelectionFromNone):
(WebCore::FrameSelection::shouldChangeSelection):
(WebCore::FrameSelection::expandSelectionToElementContainingCaretSelection):
(WebCore::FrameSelection::elementRangeContainingCaretSelection):
(WebCore::FrameSelection::expandSelectionToWordContainingCaretSelection):
(WebCore::FrameSelection::wordRangeContainingCaretSelection):
(WebCore::FrameSelection::expandSelectionToStartOfWordContainingCaretSelection):
(WebCore::FrameSelection::characterInRelationToCaretSelection):
(WebCore::FrameSelection::characterBeforeCaretSelection):
(WebCore::FrameSelection::characterAfterCaretSelection):
(WebCore::FrameSelection::wordOffsetInRange):
(WebCore::FrameSelection::spaceFollowsWordInRange):
(WebCore::FrameSelection::selectionAtDocumentStart):
(WebCore::FrameSelection::selectionAtSentenceStart):
(WebCore::FrameSelection::selectionAtWordStart):
(WebCore::FrameSelection::rangeByMovingCurrentSelection):
(WebCore::FrameSelection::rangeByExtendingCurrentSelection):
(WebCore::FrameSelection::selectRangeOnElement):
(WebCore::FrameSelection::wordSelectionContainingCaretSelection):
(WebCore::FrameSelection::actualSelectionAtSentenceStart):
(WebCore::FrameSelection::rangeByAlteringCurrentSelection):
(WebCore::FrameSelection::clearCurrentSelection):
(WebCore::FrameSelection::setCaretBlinks):
(WebCore::FrameSelection::setCaretColor):
- editing/FrameSelection.h:
(WebCore::FrameSelection::suppressCloseTyping):
(WebCore::FrameSelection::restoreCloseTyping):
(WebCore::FrameSelection::setUpdateAppearanceEnabled):
(WebCore::FrameSelection::suppressScrolling):
(WebCore::FrameSelection::restoreScrolling):
- editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doReapply):
- editing/InsertIntoTextNodeCommand.h:
- editing/InsertTextCommand.h:
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
- editing/TextAffinity.h:
- editing/TextCheckingHelper.cpp:
- editing/TextGranularity.h:
- editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::ensureLastEditCommandHasCurrentSelectionIfOpenForMoreTyping):
(WebCore::TypingCommand::markMisspellingsAfterTyping):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::FriendlyEditCommand::setEndingSelection):
(WebCore::TypingCommand::setEndingSelectionOnLastInsertCommand):
- editing/TypingCommand.h:
- editing/VisiblePosition.h:
(WebCore::operator<):
(WebCore::operator>):
(WebCore::operator<=):
(WebCore::operator>=):
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
- editing/VisibleUnits.cpp:
(WebCore::previousBoundary):
(WebCore::nextBoundary):
(WebCore::startOfDocument):
(WebCore::endOfDocument):
(WebCore::directionIsDownstream):
(WebCore::atBoundaryOfGranularity):
(WebCore::withinTextUnitOfGranularity):
(WebCore::nextCharacterBoundaryInDirection):
(WebCore::nextWordBoundaryInDirection):
(WebCore::nextSentenceBoundaryInDirection):
(WebCore::nextLineBoundaryInDirection):
(WebCore::nextParagraphBoundaryInDirection):
(WebCore::nextDocumentBoundaryInDirection):
(WebCore::positionOfNextBoundaryOfGranularity):
(WebCore::enclosingTextUnitOfGranularity):
(WebCore::distanceBetweenPositions):
(WebCore::wordRangeFromPosition):
(WebCore::closestWordBoundaryForPosition):
- editing/VisibleUnits.h:
- editing/ios/DictationCommandIOS.cpp: Added.
- editing/ios/DictationCommandIOS.h: Added.
(WebCore::DictationCommandIOS::create):
(WebCore::DictationCommandIOS::editingAction):
- editing/mac/FrameSelectionMac.mm:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
- fileapi/AsyncFileStream.cpp:
- generate-export-file: Added.
- inspector/InspectorCounters.h:
- inspector/InspectorFrontendHost.h:
- make-export-file-generator:
- plugins/PluginPackage.h:
- plugins/PluginViewBase.h:
(WebCore::PluginViewBase::willProvidePluginLayer):
(WebCore::PluginViewBase::attachPluginLayer):
(WebCore::PluginViewBase::detachPluginLayer):
- style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
- style/StyleResolveTree.cpp:
(WebCore::Style::elementImplicitVisibility):
- testing/Internals.cpp:
(WebCore::Internals::getCurrentCursorInfo):
(WebCore::Internals::isSelectPopupVisible):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- MigrateHeaders.make:
Tools:
- Scripts/check-for-inappropriate-objc-class-names:
- Scripts/check-for-webkit-framework-include-consistency:
- 8:55 AM Changeset in webkit [161637] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS build after <http://trac.webkit.org/changeset/161589>
(https://bugs.webkit.org/show_bug.cgi?id=126654)
- platform/graphics/ios/MediaPlayerPrivateIOS.h:
(WebCore::MediaPlayerPrivateIOS::engineDescription): Adding missing return keyword.
- 8:31 AM Changeset in webkit [161636] by
-
- 3 edits in trunk/Source/WebCore
[CSS Regions] Remove unused CSSParser::parseFlowThread
https://bugs.webkit.org/show_bug.cgi?id=126749
Reviewed by Antti Koivisto.
There are two versions of CSSParser::parseFlowThread. Remove the unused one:
bool parseFlowThread(const String& flowName);
Tests: No tests, code cleanup.
- css/CSSParser.cpp:
- css/CSSParser.h:
- 8:27 AM Changeset in webkit [161635] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Build fix after r161589.
https://bugs.webkit.org/show_bug.cgi?id=126747
Patch by Alex Christensen <achristensen@webkit.org> on 2014-01-10
Reviewed by Anders Carlsson.
- platform/network/ResourceHandle.cpp:
Include NotImplemented.h for all platforms.
- 8:19 AM Changeset in webkit [161634] by
-
- 9 edits in trunk/Source/WebCore
Convert some for loops over to range-based for
https://bugs.webkit.org/show_bug.cgi?id=126752
Reviewed by Antti Koivisto.
- inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
- loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::clearStorageID):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::clearStorageID):
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::fillResourceList):
- loader/appcache/ApplicationCacheResource.cpp:
(WebCore::ApplicationCacheResource::estimatedSizeInStorage):
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
- loader/archive/ArchiveFactory.cpp:
(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::styleAvailable):
(WebCore::AnimationControllerPrivate::startTimeResponse):
- 7:40 AM Changeset in webkit [161633] by
-
- 5 edits in trunk/Source/WebCore
Tighten up two functions in the inspector code
https://bugs.webkit.org/show_bug.cgi?id=126751
Reviewed by Antti Koivisto.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::frameStartedLoadingImpl):
(WebCore::InspectorInstrumentation::frameStoppedLoadingImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::frameStartedLoading):
(WebCore::InspectorInstrumentation::frameStoppedLoading):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::frameStartedLoading):
(WebCore::InspectorPageAgent::frameStoppedLoading):
- inspector/InspectorPageAgent.h:
- 6:30 AM Changeset in webkit [161632] by
-
- 2 edits in trunk/Source/WebInspectorUI
Add missing function stub in InspectorFrontendHostStub.js
https://bugs.webkit.org/show_bug.cgi?id=126745
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-10
Reviewed by Timothy Hatcher.
- UserInterface/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.debuggableType):
The function debuggableType() was added to InspectorFrontendHost.idl and InspectorFrontendHost.cpp
in r160887, but not to InspectorFrontendHostStub.js.
- 4:47 AM Changeset in webkit [161631] by
-
- 5 edits in trunk/LayoutTests
[CSSRegions] Disable accelerated compositing for fixed elements in regions tests
https://bugs.webkit.org/show_bug.cgi?id=126743
Reviewed by Dirk Schulze.
Once we enable the support of accelerated compositing for fixed positioned elements in regions
in https://bugs.webkit.org/show_bug.cgi?id=125144, those tests will be added into compositing/regions as well.
- fast/regions/fixed-inside-fixed-in-named-flow-expected.html:
- fast/regions/fixed-inside-fixed-in-named-flow.html:
- fast/regions/fixed-pos-elem-in-region-expected.html:
- fast/regions/fixed-pos-elem-in-region.html:
- 4:33 AM Changeset in webkit [161630] by
-
- 3 edits2 adds in trunk
Crash when mutating SVG text with transform
https://bugs.webkit.org/show_bug.cgi?id=126744
Reviewed by Dirk Schulze.
Source/WebCore:
Test: svg/custom/mutation-text-transform-crash.html
Text-transform property triggers subtreeTextDidChange when an SVG text renderer is
being added to the render tree. The function assumes the child is already fully in the tree
but in this case we are still in middle of adding it.
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::subtreeTextDidChange):
Bail out if the changed RenderSVGInlineText can't be found from m_layoutAttributes.
This means that subtreeChildWasAdded hasn't been invoked yet for it and there is nothing
to update. The required updates will happen in subtreeChildWasAdded.
LayoutTests:
- svg/custom/mutation-text-transform-crash-expected.txt: Added.
- svg/custom/mutation-text-transform-crash.html: Added.
- 4:03 AM Changeset in webkit [161629] by
-
- 4 edits7 adds in trunk
[SVG] Accept HTML and MathML namespaces as valid requiredExtensions
https://bugs.webkit.org/show_bug.cgi?id=88188
Patch by Frédéric Wang <fred.wang@free.fr> on 2014-01-10
Reviewed by Dirk Schulze.
Source/WebCore:
When HTML and MathML are used as foreign objects of an SVG image, it is
important for Web authors to be able to specify a fallback content for
SVG-only readers or browsers without MathML support. We rely on the
requiredExtensions for that purpose and we use the XHTML/MathML
namespaces as suggested in SVG Tiny 1.2 and implemented in Gecko.
Tests: svg/custom/conditional-processing-1.svg
svg/custom/conditional-processing-2.html
svg/dom/SVGTests.html
- svg/SVGSwitchElement.cpp: Remove an incorrect FIXME comment and replace it with a reference to bug 74749.
(WebCore::SVGSwitchElement::childShouldCreateRenderer):
- svg/SVGTests.cpp: Check if the list of required extensions contains only the XHTML/MathML namespaces.
(WebCore::SVGTests::hasExtension):
(WebCore::SVGTests::isValid):
LayoutTests:
conditional-processing-1 verifies that indeed a renderer object is only
created for the first "valid" SVG element of a <switch>, contrary to
what an incorrect FIXME comment said. conditional-processing-2 verifies
that the <switch> takes into account XHTML and MathML namespaces in the
requiredExtensions attribute to decide which SVG element is "valid".
SVGTests.html verifies the SVGTests interface of SVG DOM: three
SVGStringList attributes (already tested in svg/dom/SVGStringList.html)
and the hasExtension() function.
- svg/custom/conditional-processing-1-expected.txt: Added.
- svg/custom/conditional-processing-1.svg: Added.
- svg/custom/conditional-processing-2-expected.txt: Added.
- svg/custom/conditional-processing-2.html: Added.
- svg/dom/SVGTests-expected.txt: Added.
- svg/dom/SVGTests.html: Added.
- svg/dom/script-tests/SVGTests.js: Added.
- 3:30 AM Changeset in webkit [161628] by
-
- 18 edits15 adds in trunk
Add support for blendmode to Core Animation layer.
Patch by Rik Cabanier, Dean Jackson and Mihai Tica.
https://bugs.webkit.org/show_bug.cgi?id=99200
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-10
Reviewed by Dirk Schulze.
Source/WebCore:
Tests: css3/compositing/blend-mode-layers.html
css3/compositing/blend-mode-overflow.html
css3/compositing/blend-mode-reflection.html
css3/compositing/blend-mode-should-not-have-compositing-layer.html
css3/compositing/blend-mode-simple.html
- WebCore.exp.in: export PlatformCALayer::setBlendMode for WebKit::PlatformCALayerRemote
- WebCore.xcodeproj/project.pbxproj: Add PlatformCAFiltersMac.h
- platform/graphics/GraphicsLayer.cpp: add blendMode member
(WebCore::GraphicsLayer::GraphicsLayer):
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::blendMode):
(WebCore::GraphicsLayer::setBlendMode):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setBlendMode):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): add call to updateBlendMode()
(WebCore::GraphicsLayerCA::updateBlendMode):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/PlatformCAFilters.h:
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/mac/PlatformCAFiltersMac.h: Added.
- platform/graphics/ca/mac/PlatformCAFiltersMac.mm:
(PlatformCAFilters::setBlendingFiltersOnLayer): set a compositing CAFilter on CALayer
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::setBlendMode): call to PlatformCAFilters::setBlendingFiltersOnLayer
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::updateBlendMode):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::setBlendMode):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::CompositingState::CompositingState): add m_subtreeHasBlending member
(WebCore::RenderLayerCompositor::computeCompositingRequirements): promote layer if subtree has blending
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore::RenderLayerCompositor::logReasonsForCompositing): log blending reason
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): add blending reason
- rendering/RenderLayerCompositor.h:
LayoutTests:
- css3/compositing/blend-mode-layers.html: Added.
- css3/compositing/blend-mode-overflow-expected.txt: Added.
- css3/compositing/blend-mode-overflow.html: Added.
- css3/compositing/blend-mode-reflection.html: Added.
- css3/compositing/blend-mode-should-not-have-compositing-layer-expected.txt: Added.
- css3/compositing/blend-mode-should-not-have-compositing-layer.html: Added.
- css3/compositing/blend-mode-simple.html: Added.
- css3/compositing/should-have-compositing-layer-expected.txt:
- platform/efl/TestExpectations: Efl doesn't support blend modes at the moment.
- platform/mac/css3/compositing/blend-mode-layers-expected.png: Added.
- platform/mac/css3/compositing/blend-mode-layers-expected.txt: Added.
- platform/mac/css3/compositing/blend-mode-overflow-expected.png: Added.
- platform/mac/css3/compositing/blend-mode-reflection-expected.png: Added.
- platform/mac/css3/compositing/blend-mode-reflection-expected.txt: Added.
- platform/mac/css3/compositing/blend-mode-simple-expected.png: Added.
- platform/mac/css3/compositing/blend-mode-simple-expected.txt: Added.
- 3:17 AM Changeset in webkit [161627] by
-
- 2 edits in trunk/Source/WTF
[EFL] Enable the DFG_JIT on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=126742
Patch by Hunseop Jeong <Hunseop Jeong> on 2014-01-10
Reviewed by Gyuyoung Kim.
Turn on ENABLE_DFG_JIT on ARMv7 for EFL.
- wtf/Platform.h:
- 2:38 AM Changeset in webkit [161626] by
-
- 8 edits10 adds in trunk
[CSS Regions] Implement visual overflow computation for inline elements
https://bugs.webkit.org/show_bug.cgi?id=125291
Reviewed by David Hyatt.
Source/WebCore:
The patch implements visual overflow computation for inline elements per region. The algorithm
uses the container region of each root line box to determine the lines in a region generated by
a RenderInline. The overflow of a RenderInline inside a region is the smallest rectangle that fits
all the line boxes belonging to that region.
The patch also correctly flips for writing mode the overflow of a renderer before clipping with it.
Tests: fast/regions/overflow-in-variable-width-regions-inline-bt.html
fast/regions/overflow-in-variable-width-regions-inline-continuation.html
fast/regions/overflow-in-variable-width-regions-inline-lr.html
fast/regions/overflow-in-variable-width-regions-inline-rl.html
fast/regions/overflow-in-variable-width-regions-inline.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::objectShouldPaintInFlowRegion):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::updateAlwaysCreateLineBoxes): Always create line boxes for RenderInline
(WebCore::RenderInline::linesVisualOverflowBoundingBoxInRegion):
- rendering/RenderInline.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::visualOverflowRectForBox):
(WebCore::RenderRegion::visualOverflowRectForBoxForPropagation):
- rendering/RenderRegion.h:
LayoutTests:
Tests for inline elements overflow correct painting inside regions.
- fast/regions/overflow-in-variable-width-regions-inline-bt-expected.html: Added.
- fast/regions/overflow-in-variable-width-regions-inline-bt.html: Added.
- fast/regions/overflow-in-variable-width-regions-inline-continuation-expected.html: Added.
- fast/regions/overflow-in-variable-width-regions-inline-continuation.html: Added.
- fast/regions/overflow-in-variable-width-regions-inline-expected.html: Added.
- fast/regions/overflow-in-variable-width-regions-inline-lr-expected.html: Added.
- fast/regions/overflow-in-variable-width-regions-inline-lr.html: Added.
- fast/regions/overflow-in-variable-width-regions-inline-rl-expected.html: Added.
- fast/regions/overflow-in-variable-width-regions-inline-rl.html: Added.
- fast/regions/overflow-in-variable-width-regions-inline.html: Added.
- 1:11 AM Changeset in webkit [161625] by
-
- 3 edits in trunk/Source/WebKit2
Implement NetworkResourceLoader::receivedCancellation
https://bugs.webkit.org/show_bug.cgi?id=126129
Reviewed Alexey Proskuryakov.
Implement ResourceHandleClient::receivedCancellation() in the
network process to cancel the load when cancellation is received
from the authentication manager like the web process does.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::receivedCancellation): Cancel the load.
- NetworkProcess/NetworkResourceLoader.h:
- 12:00 AM Changeset in webkit [161624] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Add APIs for setting and getting the default text encoding name
https://bugs.webkit.org/show_bug.cgi?id=126736
Reviewed by Gyuyoung Kim.
Add APIs to set and get the default text encoding name.
- UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_default_text_encoding_name_get):
(ewk_settings_default_text_encoding_name_set):
- UIProcess/API/efl/ewk_settings.h:
- UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):
Jan 9, 2014:
- 11:26 PM Changeset in webkit [161623] by
-
- 4 edits2 adds in trunk
[Mac] .mp3 media document controls missing their background
https://bugs.webkit.org/show_bug.cgi?id=126683
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-document-audio-controls-visible.html
<video> elements in a media document are created with an intrinsic size of 300x1,
with the expectation that either the size will be updated if the media has a video
track, or the controls will visibly overflow if the media is audio-only. Since the
shadow root is a flex-box, the panel was being collapsed to 1px high, so give the panel
a minimum height to prevent that. Also, disable "fading out" the controls in a
media document for an audio-only file by adding a "no-video" class to the panel
and adding a media document-only rule to force the controls to always be visible.
- Modules/mediacontrols/mediaControlsApple.css:
(video:-webkit-full-page-media::-webkit-media-controls-panel.no-video):
(audio::-webkit-media-controls-panel):
- Modules/mediacontrols/mediaControlsApple.js:
(Controller): Call updateHasVideo().
(Controller.prototype.addVideoListeners): Add video track listeners.
(Controller.prototype.removeVideoListeners): Remove same.
(Controller.prototype.updateHasVideo): Add a 'no-video' class to the panel if
the video element has no video tracks.
LayoutTests:
- media/media-document-audio-controls-visible-expected.txt: Added.
- media/media-document-audio-controls-visible.html: Added.
- 11:19 PM Changeset in webkit [161622] by
-
- 6 edits in trunk/Source/WebCore
Clean up ProgressTracker a little
https://bugs.webkit.org/show_bug.cgi?id=126738
Reviewed by Dan Bernstein.
Use Frame& where the frame can never be null, avoid an extra hash lookup and
switch the m_progressItems map over to std::unique_ptr.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::frameStartedLoading):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameProgressTracker::~FrameProgressTracker):
(WebCore::FrameLoader::FrameProgressTracker::progressStarted):
(WebCore::FrameLoader::FrameProgressTracker::progressCompleted):
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::progressCompleted):
(WebCore::ProgressTracker::incrementProgress):
- loader/ProgressTracker.h:
- loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::didReceiveData):
- 10:22 PM Changeset in webkit [161621] by
-
- 2 edits in trunk/Source/WebCore
Fix a build break on EFL debug build
https://bugs.webkit.org/show_bug.cgi?id=126735
Reviewed by Anders Carlsson.
No new tests, just build fix.
- platform/ThreadTimers.cpp:
(WebCore::ThreadTimers::sharedTimerFiredInternal): Add parentheses.
- 9:03 PM Changeset in webkit [161620] by
-
- 3 edits in trunk/Source/WebCore
Remove unused FrameLoader member functions
https://bugs.webkit.org/show_bug.cgi?id=126734
Reviewed by Andreas Kling.
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- 8:18 PM Changeset in webkit [161619] by
-
- 3 edits in trunk/Tools
Rollout 161618.
- 8:08 PM Changeset in webkit [161618] by
-
- 3 edits in trunk/Tools
Update the LLINT CLoop bot infrastructure.
This will require a build master restart.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileLLINTCLoop):
(RunLLINTCloopTests):
(BuildAndTestLLINTCLoopFactory):
(BuildAndTestLLINTCLoopFactory.init):
- 6:50 PM Changeset in webkit [161617] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Windows build fix for r161563.
Remove stale forward declaration causing namespace ambiguity
later on in a Windows AllInOne file that picked it up. Also
remove a few stale functions that are not used and accidentally
got added back in when the file changed names.
- bindings/js/ScriptGlobalObject.h:
- 6:45 PM Changeset in webkit [161616] by
-
- 2 edits in trunk/Source/WebCore
[WebGL] Expose texture_float_linear and texture_half_float to getSupportedExtensions
https://bugs.webkit.org/show_bug.cgi?id=126732
Reviewed by Tim Horton.
When I added support for these two extensions, I forgot to add their
names to the list in getSupportedExtensions.
Covered by the Khronos test: conformance/extensions/get-extension.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getSupportedExtensions): Add OES_texture_float_linear
and OES_texture_half_float if the WebGL context supports them.
- 6:28 PM Changeset in webkit [161615] by
-
- 31 edits in trunk/Source
Marking should be generational
https://bugs.webkit.org/show_bug.cgi?id=126552
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Re-marking the same objects over and over is a waste of effort. This patch implements
the sticky mark bit algorithm (along with our already-present write barriers) to reduce
overhead during garbage collection caused by rescanning objects.
There are now two collection modes, EdenCollection and FullCollection. EdenCollections
only visit new objects or objects that were added to the remembered set by a write barrier.
FullCollections are normal collections that visit all objects regardless of their
generation.
In this patch EdenCollections do not do anything in CopiedSpace. This will be fixed in
https://bugs.webkit.org/show_bug.cgi?id=126555.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
- bytecode/CodeBlock.h:
(JSC::CodeBlockSet::mark):
- dfg/DFGOperations.cpp:
- heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::add):
(JSC::CodeBlockSet::traceMarked):
(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
- heap/CodeBlockSet.h:
- heap/CopiedBlockInlines.h:
(JSC::CopiedBlock::reportLiveBytes):
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::didStartFullCollection):
- heap/CopiedSpace.h:
(JSC::CopiedSpace::heap):
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::didAbandon):
(JSC::Heap::markRoots):
(JSC::Heap::copyBackingStores):
(JSC::Heap::addToRememberedSet):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):
(JSC::Heap::didAllocate):
(JSC::Heap::writeBarrier):
- heap/Heap.h:
(JSC::Heap::isInRememberedSet):
(JSC::Heap::operationInProgress):
(JSC::Heap::shouldCollect):
(JSC::Heap::isCollecting):
(JSC::Heap::isWriteBarrierEnabled):
(JSC::Heap::writeBarrier):
- heap/HeapOperation.h:
- heap/MarkStack.cpp:
(JSC::MarkStackArray::~MarkStackArray):
(JSC::MarkStackArray::clear):
(JSC::MarkStackArray::fillVector):
- heap/MarkStack.h:
- heap/MarkedAllocator.cpp:
(JSC::isListPagedOut):
(JSC::MarkedAllocator::isPagedOut):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):
(JSC::MarkedAllocator::reset):
- heap/MarkedAllocator.h:
(JSC::MarkedAllocator::MarkedAllocator):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::clearMarks):
(JSC::MarkedBlock::clearRememberedSet):
(JSC::MarkedBlock::clearMarksWithCollectionType):
(JSC::MarkedBlock::lastChanceToFinalize):
- heap/MarkedBlock.h: Changed atomSize to 16 bytes because we have no objects smaller
than 16 bytes. This is also to pay for the additional Bitmap for the remembered set.
(JSC::MarkedBlock::didConsumeEmptyFreeList):
(JSC::MarkedBlock::setRemembered):
(JSC::MarkedBlock::clearRemembered):
(JSC::MarkedBlock::atomicClearRemembered):
(JSC::MarkedBlock::isRemembered):
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::~MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::visitWeakSets):
(JSC::MarkedSpace::reapWeakSets):
(JSC::VerifyMarked::operator()):
(JSC::MarkedSpace::clearMarks):
- heap/MarkedSpace.h:
(JSC::ClearMarks::operator()):
(JSC::ClearRememberedSet::operator()):
(JSC::MarkedSpace::didAllocateInBlock):
(JSC::MarkedSpace::clearRememberedSet):
- heap/SlotVisitor.cpp:
(JSC::SlotVisitor::~SlotVisitor):
(JSC::SlotVisitor::clearMarkStack):
- heap/SlotVisitor.h:
(JSC::SlotVisitor::markStack):
(JSC::SlotVisitor::sharedData):
- heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::internalAppend):
(JSC::SlotVisitor::unconditionallyAppend):
(JSC::SlotVisitor::copyLater):
(JSC::SlotVisitor::reportExtraMemoryUsage):
(JSC::SlotVisitor::heap):
- jit/Repatch.cpp:
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):
- runtime/JSPropertyNameIterator.h:
(JSC::StructureRareData::setEnumerationCache):
- runtime/JSString.cpp:
(JSC::JSString::visitChildren):
- runtime/StructureRareDataInlines.h:
(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::setObjectToStringValue):
- runtime/WeakMapData.cpp:
(JSC::WeakMapData::visitChildren):
Source/WTF:
- wtf/Bitmap.h:
(WTF::WordType>::count): Added a cast that became necessary when Bitmap
is used with smaller types than int32_t.
- 6:02 PM Changeset in webkit [161614] by
-
- 2 edits in trunk/Source/WebCore
Revert r161611, incorrect fix, will fix better.
- bindings/js/ScriptGlobalObject.h:
- 5:57 PM Changeset in webkit [161613] by
-
- 5 edits in trunk/Source/WebCore
[Mac] Scrubbing performance of HD content with software decoding is poor.
https://bugs.webkit.org/show_bug.cgi?id=126705
Reviewed by Eric Carlson.
Instead of issuing a new seek before the previous one completes, wait until that seek's
completion handler is called, and then issue the new seek. This has the added benefit of
coalescing multiple incoming seeks so that only the last one is acted upon.
Save the parameters passed into seekToTime and bind them together in a std::function
to be replayed once the in-flight seek completes. To handle the case where a completion
handler fires after the media player is destroyed, add a weakPtrFactory and pass a
WeakPtr into the completion handler.
Clean up some ivars which are no longer necessary: remove m_seekCount and m_seekTime.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Initialize the
WeakPtrFactory.
(WebCore::MediaPlayerPrivateAVFoundation::seekWithTolerance):
(WebCore::MediaPlayerPrivateAVFoundation::seeking): m_seekTime -> m_seeking.
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createWeakPtr):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime):
(WebCore::MediaPlayerPrivateAVFoundationObjC::finishSeek):
- 5:49 PM Changeset in webkit [161612] by
-
- 9 edits1 move in trunk/Source/WebCore
[MSE][Mac] Report the intrinsic size of the media element
https://bugs.webkit.org/show_bug.cgi?id=125156
Reviewed by Eric Carlson.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::naturalSize): Pass to MediaSourcePrivateAVFObjC.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::sizeChanged): Added; Pass to MediaPlayer.
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
(WebCore::MediaSourcePrivateAVFObjC::naturalSize): Return the union of the naturalSizes of all active buffers.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::didParseStreamDataAsAsset): Notify the media player that the size changed.
(WebCore::SourceBufferPrivateAVFObjC::naturalSize): Return the size of the selected video track.
- platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.mm: Renamed from Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.cpp.
(WebCore::VideoTrackPrivateMediaSourceAVFObjC::assetTrack): Made const.
(WebCore::VideoTrackPrivateMediaSourceAVFObjC::naturalSize): Return the size of the AVAssetTrack.
- 5:45 PM Changeset in webkit [161611] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Windows build fix for r161563.
Remove stale forward declaration causing namespace ambiguity
later on in a Windows AllInOne file that picked it up.
- bindings/js/ScriptGlobalObject.h:
- 5:38 PM Changeset in webkit [161610] by
-
- 16 edits4 copies3 adds in trunk/Source
Enable async scrolling for iOS
https://bugs.webkit.org/show_bug.cgi?id=126730
Source/WebCore:
Reviewed by Tim Horton.
Turn on ENABLE_ASYNC_SCROLLING for iOS.
Disable rubber-banding and scrollbar-related Mac code for PLATFORM(IOS),
provide stubs for scrolling nodes and scrolling state nodes, and an
iOS scrolling tree, and scrolling coordinator.
Move crollingCoordinator::create() into the platform implementation file.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::create):
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setScrollbarPaintersFromScrollbars):
- page/scrolling/ScrollingStateScrollingNode.h:
- page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::isScrollingTreeIOS):
- page/scrolling/ThreadedScrollingTree.h:
- page/scrolling/ios/ScrollingCoordinatorIOS.h: Copied from Source/WebKit2/UIProcess/Scrolling/RemoteScrollingTree.h.
- page/scrolling/ios/ScrollingCoordinatorIOS.mm: Copied from Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm.
(WebCore::ScrollingCoordinator::create):
(WebCore::ScrollingCoordinatorIOS::ScrollingCoordinatorIOS):
(WebCore::ScrollingCoordinatorIOS::~ScrollingCoordinatorIOS):
(WebCore::ScrollingCoordinatorIOS::pageDestroyed):
(WebCore::ScrollingCoordinatorIOS::commitTreeStateIfNeeded):
(WebCore::ScrollingCoordinatorIOS::scheduleTreeStateCommit):
(WebCore::ScrollingCoordinatorIOS::scrollingStateTreeCommitterTimerFired):
(WebCore::ScrollingCoordinatorIOS::commitTreeState):
(WebCore::ScrollingCoordinatorIOS::createScrollingTreeNode):
- page/scrolling/ios/ScrollingTreeIOS.cpp: Added.
(WebCore::ScrollingTreeIOS::create):
(WebCore::ScrollingTreeIOS::ScrollingTreeIOS):
(WebCore::ScrollingTreeIOS::~ScrollingTreeIOS):
(WebCore::derefScrollingCoordinator):
(WebCore::ScrollingTreeIOS::invalidate):
(WebCore::ScrollingTreeIOS::commitNewTreeState):
(WebCore::ScrollingTreeIOS::updateMainFrameScrollPosition):
(WebCore::ScrollingTreeIOS::createNode):
- page/scrolling/ios/ScrollingTreeIOS.h: Copied from Source/WebCore/page/scrolling/ThreadedScrollingTree.h.
- page/scrolling/ios/ScrollingTreeScrollingNodeIOS.h: Added.
- page/scrolling/ios/ScrollingTreeScrollingNodeIOS.mm: Added.
(WebCore::ScrollingTreeScrollingNodeIOS::create):
(WebCore::ScrollingTreeScrollingNodeIOS::ScrollingTreeScrollingNodeIOS):
(WebCore::ScrollingTreeScrollingNodeIOS::~ScrollingTreeScrollingNodeIOS):
(WebCore::ScrollingTreeScrollingNodeIOS::updateBeforeChildren):
(WebCore::ScrollingTreeScrollingNodeIOS::updateAfterChildren):
(WebCore::ScrollingTreeScrollingNodeIOS::scrollPosition):
(WebCore::ScrollingTreeScrollingNodeIOS::setScrollPosition):
(WebCore::ScrollingTreeScrollingNodeIOS::setScrollPositionWithoutContentEdgeConstraints):
(WebCore::ScrollingTreeScrollingNodeIOS::setScrollLayerPosition):
(WebCore::ScrollingTreeScrollingNodeIOS::minimumScrollPosition):
(WebCore::ScrollingTreeScrollingNodeIOS::maximumScrollPosition):
(WebCore::ScrollingTreeScrollingNodeIOS::scrollBy):
(WebCore::ScrollingTreeScrollingNodeIOS::scrollByWithoutContentEdgeConstraints):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinator::create):
- page/scrolling/mac/ScrollingTreeFixedNode.mm:
- page/scrolling/mac/ScrollingTreeStickyNode.mm:
Source/WebKit2:
Reviewed by Tim Horton.
Turn on ENABLE_ASYNC_SCROLLING for iOS.
On iOS, create ScrollingTreeScrollingNodeIOS nodes.
- UIProcess/Scrolling/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::createNode):
- UIProcess/Scrolling/RemoteScrollingTree.h:
Source/WTF:
Reviewed by Tim Horton.
Turn on ENABLE_ASYNC_SCROLLING for iOS.
- wtf/FeatureDefines.h:
- 5:34 PM Changeset in webkit [161609] by
-
- 9 edits in trunk/Source
Source/WebCore: text-decoration-skip: ink does not work with line wraps
https://bugs.webkit.org/show_bug.cgi?id=126729
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2014-01-09
Reviewed by Simon Fraser.
InlineTextBox's m_start and m_length fields are offsets into the renderer's string,
not the generated TextRun. Because of this distinction, when multiple InlineTextBoxes
were constructed for the same element, all the subsequent elements would use incorrect
indices and therefore not have skipping decorations.
Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-multiline.html
- platform/graphics/Font.h:
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::dashesForIntersectionsWithRect):
- rendering/InlineTextBox.cpp:
(WebCore::drawSkipInkUnderline):
(WebCore::InlineTextBox::paintDecoration):
- rendering/TextPainter.cpp:
(WebCore::TextPainter::dashesForIntersectionsWithRect):
- rendering/TextPainter.h:
Source/WebKit2: Change Page, FocusController to use ViewState
https://bugs.webkit.org/show_bug.cgi?id=126533
Reviewed by Tim Horton.
These classes currently maintain a set of separate fields to represent the view state;
combine these into a single field, and allow WebPage to send the combined update rather
than individual changes.
Maintain existing interface for WebKit1 clients.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- Combined separate calls to Page::setViewState.
(WebKit::WebPage::updateIsInWindow):
- Simplied from setIsInWindow.
(WebKit::WebPage::setViewState):
- Combined separate calls to Page::setViewState.
- WebProcess/WebPage/WebPage.h:
- Declare updateIsInWindow.
- 5:29 PM Changeset in webkit [161608] by
-
- 7 edits2 adds in trunk
text-decoration-skip: ink does not work with line wraps
https://bugs.webkit.org/show_bug.cgi?id=126729
Reviewed by Simon Fraser.
Source/WebCore:
InlineTextBox's m_start and m_length fields are offsets into the renderer's string,
not the generated TextRun. Because of this distinction, when multiple InlineTextBoxes
were constructed for the same element, all the subsequent elements would use incorrect
indices and therefore not have skipping decorations.
Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-multiline.html
- platform/graphics/Font.h:
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::dashesForIntersectionsWithRect):
- rendering/InlineTextBox.cpp:
(WebCore::drawSkipInkUnderline):
(WebCore::InlineTextBox::paintDecoration):
- rendering/TextPainter.cpp:
(WebCore::TextPainter::dashesForIntersectionsWithRect):
- rendering/TextPainter.h:
LayoutTests:
This test compares rending of a single element that wraps lines with one element per line.
Both elements have text-decoration-skip:ink turned on.
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-multiline-expected.html: Added.
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-multiline.html: Added.
- 5:24 PM Changeset in webkit [161607] by
-
- 1 edit12 deletes in trunk/Source/WebCore
Remove remaining blackberry files I could find in WebCore
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- Resources/blackberry: Removed.
- css/mediaControlsBlackBerry.css: Removed.
- css/mediaControlsBlackBerryFullscreen.css: Removed.
- css/themeBlackBerry.css: Removed.
- editing/blackberry: Removed.
- history/blackberry: Removed.
- html/shadow/MediaControlsBlackBerry.cpp: Removed.
- html/shadow/MediaControlsBlackBerry.h: Removed.
- page/blackberry: Removed.
- page/scrolling/blackberry: Removed.
- plugins/blackberry: Removed.
- 5:18 PM Changeset in webkit [161606] by
-
- 2 edits in trunk/Source/WebKit2
Upstream iOS changes after r161530
https://bugs.webkit.org/show_bug.cgi?id=126728
Reviewed by Dean Jackson.
- UIProcess/API/ios/WKContentView.mm:
(-[WKContentView setViewportSize:]):
(-[WKContentView didFinishScrollTo:]):
(-[WKContentView didScrollTo:]):
Adopt the new approach.
- 5:12 PM Changeset in webkit [161605] by
-
- 4 edits in trunk/Source/WebCore
[WebGL] Return filtered results for getProgramParameter for ACTIVE_ATTRIBUTES and ACTIVE_UNIFORMS
https://bugs.webkit.org/show_bug.cgi?id=126718
<rdar://problem/15202048>
Reviewed by Dean Jackson.
Covered by webgl/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002.html and
webgl/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003.html.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getActiveAttrib): Added loging.
(WebCore::WebGLRenderingContext::getActiveUniform): Added logging.
(WebCore::WebGLRenderingContext::getAttribLocation): Drive-by-fix. Return
-1 on link failure (an invalid location) rather than 0 (a valid
location) when link fails.
(WebCore::WebGLRenderingContext::getProgramParameter): Use new
method to return filtered count.
(WebCore::WebGLRenderingContext::getUniformLocation): Use nullptr
rather than returning 0.
- platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::ActiveShaderSymbolCounts::ActiveShaderSymbolCounts):
(WebCore::GraphicsContext3D::ActiveShaderSymbolCounts::countForType):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::precisionsMatch): Drive-by-fix. Don't
copy giant objects to read a single value.
(WebCore::GraphicsContext3D::compileShader): Release filtered count
when we change shader source code.
(WebCore::GraphicsContext3D::getActiveAttribImpl): Renamed from getActiveAttrib.
(WebCore::GraphicsContext3D::getActiveAttrib): Maps filtered indices to
real OpenGL indices.
(WebCore::GraphicsContext3D::getActiveUniformImpl): Renamed from getActiveUniform.
(WebCore::GraphicsContext3D::getActiveUniform): Maps filtered indices to
real OpenGL indices.
(WebCore::GraphicsContext3D::originalSymbolName): Use C++11 loop.
(WebCore::GraphicsContext3D::getAttribLocation): Added logging.
(WebCore::GraphicsContext3D::getNonBuiltinActiveSymbolCount): Added.
(WebCore::GraphicsContext3D::getShaderiv): Const correctness.
(WebCore::GraphicsContext3D::getShaderInfoLog): Ditto.
(WebCore::GraphicsContext3D::getShaderSource): Ditto.
- 4:55 PM Changeset in webkit [161604] by
-
- 13 edits2 adds in trunk
[CSS Shapes] First line gets incorrectly adjusted in shape-inside due to rounding
https://bugs.webkit.org/show_bug.cgi?id=126601
Reviewed by Bem Jones-Bey.
Source/WebCore:
In order to get consistent results of the first fit position of the content in shapes,
firstIncludedIntervalLogicalTop should take a FloatSize rather than LayoutSize for
minLogicalIntervalSize, because LayoutSize clamps the float value to int, when subpixel-layout
is disabled, thus firstIncludedIntervalLogicalTop could end up calculating with an unprecize
value. This change modifies firstIncludedIntervalLogicalTop to take FloatSize consistently.
Test: fast/shapes/shape-inside/shape-inside-polygon-rounded-first-fit.html
- rendering/shapes/BoxShape.cpp:
(WebCore::BoxShape::firstIncludedIntervalLogicalTop):
- rendering/shapes/BoxShape.h:
- rendering/shapes/PolygonShape.cpp:
(WebCore::PolygonShape::firstIncludedIntervalLogicalTop):
- rendering/shapes/PolygonShape.h:
- rendering/shapes/RasterShape.cpp:
(WebCore::RasterShape::firstIncludedIntervalLogicalTop):
- rendering/shapes/RasterShape.h:
- rendering/shapes/RectangleShape.cpp:
(WebCore::RectangleShape::firstIncludedIntervalLogicalTop):
- rendering/shapes/RectangleShape.h:
- rendering/shapes/Shape.h:
- rendering/shapes/ShapeInsideInfo.cpp:
(WebCore::ShapeInsideInfo::adjustLogicalLineTop):
(WebCore::ShapeInsideInfo::computeFirstFitPositionForFloat):
LayoutTests:
- fast/shapes/shape-inside/shape-inside-polygon-rounded-first-fit-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-polygon-rounded-first-fit.html: Added.
- 4:46 PM Changeset in webkit [161603] by
-
- 3 edits33 adds in trunk/Source/WebCore
[iOS] Upstream WAK
https://bugs.webkit.org/show_bug.cgi?id=126724
Reviewed by David Kilzer.
- Configurations/WebCore.xcconfig: Excluded new iOS-specific Private
headers on the Mac build.
- WebCore.xcodeproj/project.pbxproj: Added new files to the project.
- platform/ios/wak/WAKAppKitStubs.h: Added.
- platform/ios/wak/WAKAppKitStubs.m: Added.
- platform/ios/wak/WAKClipView.h: Added.
- platform/ios/wak/WAKClipView.m: Added.
- platform/ios/wak/WAKResponder.h: Added.
- platform/ios/wak/WAKResponder.m: Added.
- platform/ios/wak/WAKScrollView.h: Added.
- platform/ios/wak/WAKScrollView.mm: Added.
- platform/ios/wak/WAKView.h: Added.
- platform/ios/wak/WAKView.mm: Added.
- platform/ios/wak/WAKViewPrivate.h: Added.
- platform/ios/wak/WAKWindow.h: Added.
- platform/ios/wak/WAKWindow.mm: Added.
- platform/ios/wak/WKContentObservation.cpp: Added.
- platform/ios/wak/WKContentObservation.h: Added.
- platform/ios/wak/WKGraphics.h: Added.
- platform/ios/wak/WKGraphics.mm: Added.
- platform/ios/wak/WKTypes.h: Added.
- platform/ios/wak/WKUtilities.c: Added.
- platform/ios/wak/WKUtilities.h: Added.
- platform/ios/wak/WKView.h: Added.
- platform/ios/wak/WKView.mm: Added.
- platform/ios/wak/WKViewPrivate.h: Added.
- platform/ios/wak/WebCoreThread.h: Added.
- platform/ios/wak/WebCoreThread.mm: Added.
- platform/ios/wak/WebCoreThreadInternal.h: Added.
- platform/ios/wak/WebCoreThreadMessage.h: Added.
- platform/ios/wak/WebCoreThreadRun.cpp: Added.
- platform/ios/wak/WebCoreThreadRun.h: Added.
- platform/ios/wak/WebCoreThreadSafe.h: Added.
- platform/ios/wak/WebCoreThreadSystemInterface.cpp: Added.
- platform/ios/wak/WebCoreThreadSystemInterface.h: Added.
- 4:43 PM Changeset in webkit [161602] by
-
- 2 edits in trunk/Source/WebCore
Another attempt to fix the Windows build following <http://trac.webkit.org/changeset/161589>
(https://bugs.webkit.org/show_bug.cgi?id=126654)
- platform/network/cf/ResourceRequest.h: Always declare ResourceRequest::updateFromDelegatePreservingOldHTTPBody()
instead of only declaring it when building without CFNetwork.
- 4:31 PM Changeset in webkit [161601] by
-
- 18 edits2 deletes in trunk/Source/WTF
Remove Blackberry and QNX bits from WTF
https://bugs.webkit.org/show_bug.cgi?id=126726
Reviewed by Benjamin Poulain.
- wtf/Assertions.cpp:
- wtf/Atomics.h:
- wtf/CurrentTime.cpp:
(WTF::currentCPUTime):
- wtf/DateMath.cpp:
- wtf/DisallowCType.h:
- wtf/FeatureDefines.h:
- wtf/InlineASM.h:
- wtf/MathExtras.h:
- wtf/NumberOfCores.cpp:
(WTF::numberOfProcessorCores):
- wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):
- wtf/Platform.h:
- wtf/PlatformBlackBerry.cmake: Removed.
- wtf/RAMSize.cpp:
(WTF::computeRAMSize):
- wtf/StackBounds.cpp:
- wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
(WTF::initializeCurrentThreadInternal):
- wtf/blackberry/MainThreadBlackBerry.cpp: Removed.
- wtf/blackberry/RunLoopBlackBerry.cpp: Removed.
- wtf/text/AtomicString.h:
- wtf/text/StringImpl.h:
- wtf/text/WTFString.h:
- 4:26 PM Changeset in webkit [161600] by
-
- 4 edits in branches/jsCStack
Merge trunk r161446.
- 4:15 PM Changeset in webkit [161599] by
-
- 12 edits in branches/jsCStack/Source/JavaScriptCore
DFG and FTL should have separate compilation worklists
https://bugs.webkit.org/show_bug.cgi?id=126722
Reviewed by Mark Hahnenberg.
There are a number of architectural changes here:
- DFGDriver.cpp is now the only place that decides whether or not to do a concurrent compile. Previously this decision was oddly squirreled away in VM.cpp.
- VM no longer points to a worklist. That was always kind of weird since there was only one worklist per process anyway.
- There are now two worklists: one for all DFG compiles and one for all FTL compiles.
- The FTL worklist is now parallel by default.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::checkIfOptimizationThresholdReached):
- dfg/DFGCommon.h:
- dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
(JSC::DFG::compile):
- dfg/DFGDriver.h:
- dfg/DFGOperations.cpp:
- dfg/DFGWorklist.cpp:
(JSC::DFG::initializeGlobalDFGWorklistOnce):
(JSC::DFG::ensureGlobalDFGWorklist):
(JSC::DFG::existingGlobalDFGWorklistOrNull):
(JSC::DFG::initializeGlobalFTLWorklistOnce):
(JSC::DFG::ensureGlobalFTLWorklist):
(JSC::DFG::existingGlobalFTLWorklistOrNull):
(JSC::DFG::ensureGlobalWorklistFor):
- dfg/DFGWorklist.h:
- jit/JITOperations.cpp:
- runtime/Options.h:
- runtime/VM.cpp:
(JSC::cleanWorklist):
(JSC::VM::~VM):
(JSC::prepareToDiscardCodeFor):
(JSC::VM::prepareToDiscardCode):
(JSC::VM::gatherConservativeRoots):
- runtime/VM.h:
- 4:15 PM Changeset in webkit [161598] by
-
- 3 edits in trunk/Source/WebCore
Attempt to fix the Windows build following <http://trac.webkit.org/changeset/161589>
(https://bugs.webkit.org/show_bug.cgi?id=126654)
For some reason, the Windows build is unhappy that NeverDestroyed<FontCache> calls the private constructor
FontCache::FontCache() despite being a friend class of FontCache. Use DEFINE_STATIC_LOCAL instead of
NeverDestroyed<> for now. I'll look to investigate this issue offline.
- platform/graphics/FontCache.cpp:
(WebCore::fontCache):
- platform/graphics/FontCache.h:
- 4:13 PM Changeset in webkit [161597] by
-
- 1 edit7 deletes in trunk/Source/WebCore
Remove blackberry from WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- platform/blackberry: Removed.
- platform/graphics/blackberry: Removed.
- platform/graphics/filters/blackberry: Removed.
- platform/image-decoders/blackberry: Removed.
- platform/mediastream/blackberry: Removed.
- platform/network/blackberry: Removed.
- platform/text/blackberry: Removed.
- 4:05 PM Changeset in webkit [161596] by
-
- 5 edits in branches/safari-537.74-branch/Source
Versioning.
- 4:04 PM Changeset in webkit [161595] by
-
- 2 edits in trunk/Source/WebCore
Fix a copy-paste mistake in an include guard.
Rubber-stamped by Sam Weinig.
- crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHash.h:
- 4:03 PM Changeset in webkit [161594] by
-
- 1 copy in tags/Safari-537.74.6
New Tag.
- 4:02 PM Changeset in webkit [161593] by
-
- 5 edits in trunk/Source/WebCore
History::StateObjectType should be a strong enum
https://bugs.webkit.org/show_bug.cgi?id=126725
Reviewed by Beth Dakin.
- bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):
- loader/HistoryController.cpp:
(WebCore::HistoryController::pushState):
- page/History.cpp:
(WebCore::History::stateObjectAdded):
- page/History.h:
- 3:59 PM Changeset in webkit [161592] by
-
- 3 edits in trunk/Source/WebCore
Attempt to fix the Mountain Lion Release (32-bit) build following <http://trac.webkit.org/changeset/161589>
(https://bugs.webkit.org/show_bug.cgi?id=126654)
- platform/ios/WebEvent.h:
- platform/ios/WebEvent.mm:
- 3:56 PM Changeset in webkit [161591] by
-
- 1 edit2 deletes in trunk/Source/WebKit
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.
- PlatformBlackBerry.cmake: Removed.
- blackberry: Removed.
- 3:12 PM Changeset in webkit [161590] by
-
- 3 edits in branches/safari-537.74-branch/LayoutTests
Merge r161581. Rebaseline after 161568.
- 3:02 PM DeveloperTips edited by
- (diff)
- 2:59 PM Changeset in webkit [161589] by
-
- 214 edits23 copies50 adds in trunk/Source
[iOS] Upstream WebCore/platform changes
https://bugs.webkit.org/show_bug.cgi?id=126654
Rubber-stamped by David Kilzer.
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- platform/ContentFilter.h:
- platform/DragData.h:
- platform/FileChooser.cpp:
(WebCore::FileChooser::chooseMediaFiles):
- platform/FileChooser.h:
- platform/FileSystem.cpp:
(WebCore::setMetadataURL):
- platform/FileSystem.h:
- platform/KillRingNone.cpp:
- platform/LocalizedStrings.cpp:
(WebCore::fileButtonChooseMediaFileLabel):
(WebCore::fileButtonChooseMultipleMediaFilesLabel):
(WebCore::fileButtonNoMediaFileSelectedLabel):
(WebCore::fileButtonNoMediaFilesSelectedLabel):
- platform/LocalizedStrings.h:
- platform/Logging.h:
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedNonImageMimeTypes):
(WebCore::initializeUnsupportedTextMIMETypes):
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::MemoryPressureHandler):
- platform/MemoryPressureHandler.h:
- platform/PlatformKeyboardEvent.h:
(WebCore::PlatformKeyboardEvent::event):
- platform/PlatformMouseEvent.h:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
- platform/PlatformScreen.h:
- platform/RuntimeApplicationChecks.cpp:
(WebCore::mainBundleIsEqualTo):
- platform/RuntimeApplicationChecksIOS.h: Copied from Source/WebCore/platform/graphics/StringTruncator.h.
- platform/RuntimeApplicationChecksIOS.mm: Added.
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleTouchEvent):
- platform/ScrollAnimator.h:
- platform/ScrollTypes.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::unscaledVisibleContentSize):
(WebCore::ScrollView::visibleContentRect):
- platform/ScrollView.h:
(WebCore::ScrollView::actualScrollX):
(WebCore::ScrollView::actualScrollY):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::handleTouchEvent):
(WebCore::ScrollableArea::isPinnedInBothDirections):
(WebCore::ScrollableArea::isPinnedHorizontallyInDirection):
(WebCore::ScrollableArea::isPinnedVerticallyInDirection):
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::isTouchScrollable):
(WebCore::ScrollableArea::isOverflowScroll):
(WebCore::ScrollableArea::didStartScroll):
(WebCore::ScrollableArea::didEndScroll):
(WebCore::ScrollableArea::didUpdateScroll):
(WebCore::ScrollableArea::setIsUserScroll):
(WebCore::ScrollableArea::isHorizontalScrollerPinnedToMinimumPosition):
(WebCore::ScrollableArea::isHorizontalScrollerPinnedToMaximumPosition):
(WebCore::ScrollableArea::isVerticalScrollerPinnedToMinimumPosition):
(WebCore::ScrollableArea::isVerticalScrollerPinnedToMaximumPosition):
- platform/Scrollbar.cpp:
- platform/Scrollbar.h:
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::createPurgeableBuffer):
(WebCore::SharedBuffer::data):
- platform/SharedBuffer.h:
(WebCore::SharedBuffer::shouldUsePurgeableMemory):
- platform/SuddenTermination.h:
- platform/Supplementable.h:
(WebCore::Supplementable::provideSupplement):
(WebCore::Supplementable::removeSupplement):
(WebCore::Supplementable::requireSupplement):
- platform/SystemMemory.h: Copied from Source/WebCore/platform/graphics/StringTruncator.h.
- platform/ThreadCheck.h:
- platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):
(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):
- platform/ThreadGlobalData.h:
- platform/ThreadTimers.cpp:
(WebCore::ThreadTimers::ThreadTimers):
(WebCore::ThreadTimers::sharedTimerFiredInternal):
- platform/Timer.cpp:
(WebCore::TimerBase::start):
(WebCore::TimerBase::stop):
(WebCore::TimerBase::setNextFireTime):
- platform/Timer.h:
(WebCore::TimerBase::isActive):
- platform/URL.cpp:
(WebCore::enableURLSchemeCanonicalization):
(WebCore::equal):
(WebCore::URL::parse):
- platform/URL.h:
- platform/Widget.h:
- platform/audio/ios/AudioDestinationIOS.cpp:
- platform/audio/ios/AudioDestinationIOS.h:
- platform/audio/ios/AudioFileReaderIOS.cpp: Copied from Source/WebCore/platform/audio/mac/AudioFileReaderMac.cpp.
(WebCore::createAudioBufferList):
(WebCore::destroyAudioBufferList):
(WebCore::AudioFileReader::AudioFileReader):
(WebCore::AudioFileReader::~AudioFileReader):
(WebCore::AudioFileReader::readProc):
(WebCore::AudioFileReader::getSizeProc):
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):
- platform/audio/ios/AudioFileReaderIOS.h: Copied from Source/WebCore/platform/graphics/StringTruncator.h.
(WebCore::AudioFileReader::data):
(WebCore::AudioFileReader::dataSize):
- platform/audio/ios/AudioSessionIOS.mm:
(SOFT_LINK_POINTER):
(-[WebAudioSessionHelper initWithCallback:WebCore::]):
(-[WebAudioSessionHelper dealloc]):
(-[WebAudioSessionHelper interruption:]):
(WebCore::AudioSession::setCategory):
- platform/audio/mac/AudioDestinationMac.cpp:
- platform/audio/mac/AudioFileReaderMac.cpp:
(WebCore::AudioFileReader::AudioFileReader):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):
- platform/audio/mac/AudioSessionMac.cpp:
- platform/audio/mac/MediaSessionManagerMac.cpp:
(MediaSessionManager::updateSessionState):
- platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::SharedBuffer):
- platform/cf/URLCF.cpp:
- platform/cocoa/KeyEventCocoa.mm:
(WebCore::windowsKeyCodeForCharCode):
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::destroyDecodedDataIfNecessary):
(WebCore::BitmapImage::cacheFrame):
(WebCore::BitmapImage::cacheFrameInfo):
(WebCore::BitmapImage::updateSize):
(WebCore::BitmapImage::originalSize):
(WebCore::BitmapImage::originalSizeRespectingOrientation):
(WebCore::BitmapImage::dataChanged):
(WebCore::BitmapImage::ensureFrameInfoIsCached):
(WebCore::BitmapImage::frameAtIndex):
(WebCore::BitmapImage::frameIsCompleteAtIndex):
(WebCore::BitmapImage::frameDurationAtIndex):
(WebCore::BitmapImage::frameHasAlphaAtIndex):
(WebCore::BitmapImage::frameOrientationAtIndex):
(WebCore::BitmapImage::startAnimation):
(WebCore::BitmapImage::internalAdvanceAnimation):
- platform/graphics/BitmapImage.h:
(WebCore::FrameData::FrameData):
- platform/graphics/Color.cpp:
(WebCore::Color::isDark):
- platform/graphics/Color.h:
- platform/graphics/DisplayRefreshMonitor.h:
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatRect.h:
- platform/graphics/FloatSize.h:
- platform/graphics/Font.cpp:
(WebCore::Font::drawText):
(WebCore::Font::width):
- platform/graphics/Font.h:
- platform/graphics/FontCache.cpp:
(initFontCacheLockOnce):
(FontLocker::FontLocker):
(FontLocker::~FontLocker):
(WebCore::fontCache):
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontDataIfNeeded):
(WebCore::FontCache::purgeInactiveFontData):
- platform/graphics/FontCache.h:
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::drawSimpleText):
(WebCore::Font::drawGlyphBuffer):
- platform/graphics/FontGlyphs.h:
- platform/graphics/FontPlatformData.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- platform/graphics/FontPlatformData.h:
(WebCore::FontPlatformData::font):
(WebCore::FontPlatformData::roundsGlyphAdvances):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::hashTableDeletedFontValue):
- platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::drawRaisedEllipse):
(WebCore::GraphicsContext::drawText):
(WebCore::GraphicsContext::drawBidiText):
(WebCore::GraphicsContext::clipRoundedRect):
(WebCore::GraphicsContext::emojiDrawingEnabled):
(WebCore::GraphicsContext::setEmojiDrawingEnabled):
- platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContextState::GraphicsContextState):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::willBeDestroyed):
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::contentsLayerForMedia):
(WebCore::GraphicsLayer::pixelAlignmentOffset):
(WebCore::GraphicsLayer::hasFlattenedPerspectiveTransform):
- platform/graphics/Icon.h:
- platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
- platform/graphics/ImageSource.h:
(WebCore::ImageSource::isSubsampled):
- platform/graphics/IntPoint.h:
- platform/graphics/IntRect.h:
- platform/graphics/IntSize.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines):
(WebCore::MediaPlayer::isCurrentPlaybackTargetWireless):
(WebCore::MediaPlayer::showPlaybackTargetPicker):
(WebCore::MediaPlayer::hasWirelessPlaybackTargets):
(WebCore::MediaPlayer::wirelessVideoPlaybackDisabled):
(WebCore::MediaPlayer::setWirelessVideoPlaybackDisabled):
(WebCore::MediaPlayer::setHasPlaybackTargetAvailabilityListeners):
(WebCore::MediaPlayer::currentPlaybackTargetIsWirelessChanged):
(WebCore::MediaPlayer::playbackTargetAvailabilityChanged):
(WebCore::MediaPlayer::attributeChanged):
(WebCore::MediaPlayer::readyForPlayback):
(WebCore::MediaPlayer::volumeChanged):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerCurrentPlaybackTargetIsWirelessChanged):
(WebCore::MediaPlayerClient::mediaPlayerPlaybackTargetAvailabilityChanged):
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::volume):
(WebCore::MediaPlayerPrivateInterface::isCurrentPlaybackTargetWireless):
(WebCore::MediaPlayerPrivateInterface::showPlaybackTargetPicker):
(WebCore::MediaPlayerPrivateInterface::hasWirelessPlaybackTargets):
(WebCore::MediaPlayerPrivateInterface::wirelessVideoPlaybackDisabled):
(WebCore::MediaPlayerPrivateInterface::setWirelessVideoPlaybackDisabled):
(WebCore::MediaPlayerPrivateInterface::setHasPlaybackTargetAvailabilityListeners):
(WebCore::MediaPlayerPrivateInterface::attributeChanged):
(WebCore::MediaPlayerPrivateInterface::readyForPlayback):
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData):
- platform/graphics/SimpleFontData.h:
- platform/graphics/StringTruncator.cpp:
(WebCore::centerTruncateToBuffer):
(WebCore::rightTruncateToBuffer):
(WebCore::rightClipToCharacterBuffer):
(WebCore::rightClipToWordBuffer):
(WebCore::leftTruncateToBuffer):
(WebCore::truncateString):
(WebCore::StringTruncator::centerTruncate):
(WebCore::StringTruncator::rightTruncate):
(WebCore::StringTruncator::leftTruncate):
(WebCore::StringTruncator::rightClipToCharacter):
(WebCore::StringTruncator::rightClipToWord):
- platform/graphics/StringTruncator.h:
- platform/graphics/TextTrackRepresentation.cpp:
- platform/graphics/WidthIterator.h:
(WebCore::WidthIterator::supportsTypesettingFeatures):
- platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
(WebCore::AVTrackPrivateAVFObjCImpl::label):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeLoaded):
(WebCore::wkAVAssetResolvedURL):
- platform/graphics/blackberry/FontBlackBerry.cpp:
(WebCore::Font::drawComplexText):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::supportsAcceleratedFilterAnimations):
(WebCore::GraphicsLayerCA::setContentsToImage):
(WebCore::GraphicsLayerCA::contentsLayerForMedia):
(WebCore::GraphicsLayerCA::computeVisibleRect):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateContentsRects):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::setupContentsLayer):
(WebCore::GraphicsLayerCA::mediaLayerMustBeUpdatedOnMainThread):
(WebCore::GraphicsLayerCA::computePixelAlignment):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/PlatformCAFilters.h:
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:
(WebCore::currentRunLoop):
(WebCore::LayerFlushScheduler::schedule):
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(-[WebAnimationDelegate animationDidStart:]):
(PlatformCALayerMac::setContentsScale):
(PlatformCALayer::isWebLayer):
(PlatformCALayer::setBoundsOnMainThread):
(PlatformCALayer::setPositionOnMainThread):
(PlatformCALayer::setAnchorPointOnMainThread):
(PlatformCALayer::setTileSize):
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::platformCALayerPaintContents):
(WebCore::TileController::removeAllTiles):
(WebCore::TileController::removeAllSecondaryTiles):
(WebCore::TileController::removeTilesInCohort):
(WebCore::TileController::revalidateTiles):
(WebCore::TileController::createTileLayer):
- platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::Font::drawComplexText):
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::FrameData::clear):
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::copyUnscaledFrameAtIndex):
- platform/graphics/cg/ColorCG.cpp:
(WebCore::createCGColorWithDeviceWhite):
(WebCore::createCGColorWithDeviceRGBA):
(WebCore::Color::Color):
- platform/graphics/cg/FloatPointCG.cpp:
- platform/graphics/cg/FloatRectCG.cpp:
- platform/graphics/cg/FloatSizeCG.cpp:
- platform/graphics/cg/GradientCG.cpp:
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::sRGBColorSpaceRef):
(WebCore::setStrokeAndFillColor):
(WebCore::GraphicsContext::platformInit):
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::createIOSurface):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::draw):
(WebCore::jpegUTI):
(WebCore::utiFromMIMEType):
- platform/graphics/cg/ImageBufferDataCG.cpp:
(WebCore::ImageBufferData::getData):
(WebCore::ImageBufferData::putData):
- platform/graphics/cg/ImageBufferDataCG.h:
- platform/graphics/cg/ImageCG.cpp:
(WebCore::drawPatternCallback):
(WebCore::Image::drawPattern):
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::ImageSource):
(WebCore::imageSourceOptions):
(WebCore::ImageSource::imageSourceOptions):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::originalSize):
(WebCore::ImageSource::createFrameAtIndex):
- platform/graphics/cg/ImageSourceCGMac.mm:
- platform/graphics/cg/IntPointCG.cpp:
- platform/graphics/cg/IntRectCG.cpp:
- platform/graphics/cg/IntSizeCG.cpp:
- platform/graphics/cg/PDFDocumentImage.cpp:
- platform/graphics/cg/PathCG.cpp:
- platform/graphics/cg/PatternCG.cpp:
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::platformIsEqual):
(WebCore::FontPlatformData::setFont):
(WebCore::FontPlatformData::allowsLigatures):
(WebCore::FontPlatformData::ctFont):
- platform/graphics/ios/DisplayRefreshMonitorIOS.mm: Added.
(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):
- platform/graphics/ios/FontCacheIOS.mm: Added.
- platform/graphics/ios/FontServicesIOS.h: Added.
- platform/graphics/ios/FontServicesIOS.mm: Added.
(WebCore::FontServicesIOS::FontServicesIOS):
- platform/graphics/ios/GraphicsContext3DIOS.h: Added.
- platform/graphics/ios/IconIOS.mm: Copied from Source/WebCore/platform/mac/DisplaySleepDisabler.cpp.
- platform/graphics/ios/InbandTextTrackPrivateAVFIOS.h: Copied from Source/WebCore/platform/graphics/cg/ImageBufferDataCG.h.
(WebCore::InbandTextTrackPrivateAVFIOS::create):
(WebCore::InbandTextTrackPrivateAVFIOS::internalID):
- platform/graphics/ios/InbandTextTrackPrivateAVFIOS.mm: Copied from Source/WebCore/platform/graphics/mac/IntRectMac.mm.
(WebCore::InbandTextTrackPrivateAVFIOS::InbandTextTrackPrivateAVFIOS):
(WebCore::InbandTextTrackPrivateAVFIOS::~InbandTextTrackPrivateAVFIOS):
(WebCore::InbandTextTrackPrivateAVFIOS::kind):
- platform/graphics/ios/MediaPlayerPrivateIOS.h: Added.
- platform/graphics/ios/MediaPlayerPrivateIOS.mm: Added.
- platform/graphics/ios/SimpleFontDataIOS.mm: Added.
(WebCore::fontFamilyShouldNotBeUsedForArabic):
(WebCore::fontHasVerticalGlyphs):
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformCharWidthInit):
(WebCore::SimpleFontData::platformCreateScaledFontData):
(WebCore::SimpleFontData::containsCharacters):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/ios/TextTrackRepresentationIOS.h: Copied from Source/WebCore/platform/graphics/TextTrackRepresentation.cpp.
- platform/graphics/ios/TextTrackRepresentationIOS.mm: Added.
- platform/graphics/mac/ColorMac.h:
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
- platform/graphics/mac/FloatPointMac.mm:
- platform/graphics/mac/FloatRectMac.mm:
- platform/graphics/mac/FloatSizeMac.mm:
- platform/graphics/mac/FontCacheMac.mm:
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::drawComplexText):
(WebCore::Font::fontDataForCombiningCharacterSequence):
- platform/graphics/mac/FontCustomPlatformData.cpp:
- platform/graphics/mac/FontMac.mm:
(WebCore::showLetterpressedGlyphsWithAdvances):
(WebCore::Font::drawGlyphs):
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::GlyphPage::fill):
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::setRenderbufferStorageFromDrawable):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::endPaint):
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::createDotPattern):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
- platform/graphics/mac/IconMac.mm:
- platform/graphics/mac/ImageMac.mm:
(WebCore::BitmapImage::invalidatePlatformData):
- platform/graphics/mac/IntPointMac.mm:
- platform/graphics/mac/IntRectMac.mm:
- platform/graphics/mac/IntSizeMac.mm:
- platform/graphics/mac/MediaPlayerProxy.h:
- platform/graphics/mac/SimpleFontDataCoreText.cpp:
- platform/graphics/mac/SimpleFontDataMac.mm:
- platform/graphics/mac/WebGLLayer.h:
- platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer copyImageSnapshotWithColorSpace:]):
(-[WebGLLayer display]):
- platform/graphics/mac/WebLayer.mm:
(WebCore::drawLayerContents):
(-[WebSimpleLayer display]):
(-[WebSimpleLayer drawInContext:]):
- platform/graphics/mac/WebTiledLayer.mm:
(+[WebTiledLayer shouldDrawOnMainThread]):
(-[WebTiledLayer display]):
(-[WebTiledLayer drawInContext:]):
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::blitFramebuffer):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):
(WebCore::Extensions3DOpenGL::supportsExtension):
(WebCore::Extensions3DOpenGL::drawBuffersEXT):
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::clearDepth):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::multiply):
- platform/graphics/win/FontWin.cpp:
(WebCore::Font::drawComplexText):
- platform/graphics/wince/FontWinCE.cpp:
(WebCore::Font::drawComplexText):
- platform/ios/ContentFilterIOS.mm: Copied from Source/WebCore/platform/ContentFilter.h.
- platform/ios/DeviceMotionClientIOS.h: Added.
(WebCore::DeviceMotionClientIOS::create):
- platform/ios/DeviceMotionClientIOS.mm: Added.
- platform/ios/DeviceOrientationClientIOS.h: Added.
(WebCore::DeviceOrientationClientIOS::create):
- platform/ios/DeviceOrientationClientIOS.mm: Added.
- platform/ios/KeyEventIOS.mm:
- platform/ios/MIMETypeRegistryIOS.mm: Copied from Source/WebCore/platform/network/mac/CredentialStorageMac.mm.
- platform/ios/MemoryPressureHandlerIOS.mm: Added.
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::write):
(WebCore::Pasteboard::resourceMIMEType):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::read):
(WebCore::supportedImageTypes):
(WebCore::Pasteboard::supportedPasteboardTypes):
(WebCore::Pasteboard::hasData):
(WebCore::Pasteboard::readString):
- platform/ios/PlatformEventFactoryIOS.h: Copied from Source/WebCore/platform/mac/DisplaySleepDisabler.h.
- platform/ios/PlatformEventFactoryIOS.mm: Added.
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::write):
- platform/ios/PlatformScreenIOS.mm: Added.
- platform/ios/PlatformSpeechSynthesizerIOS.mm: Added.
- platform/ios/SSLKeyGeneratorIOS.cpp: Added.
- platform/ios/ScrollAnimatorIOS.h: Copied from Source/WebCore/platform/mac/DisplaySleepDisabler.h.
- platform/ios/ScrollAnimatorIOS.mm: Added.
- platform/ios/ScrollViewIOS.mm: Added.
- platform/ios/ScrollbarThemeIOS.h: Added.
- platform/ios/ScrollbarThemeIOS.mm: Added.
- platform/ios/SelectionRect.cpp: Added.
- platform/ios/SelectionRect.h: Added.
- platform/ios/SoundIOS.mm: Copied from Source/WebCore/platform/text/mac/CharsetData.h.
- platform/ios/SystemMemoryIOS.cpp: Added.
- platform/ios/ThemeIOS.h: Copied from Source/WebCore/platform/KillRingNone.cpp.
- platform/ios/ThemeIOS.mm: Copied from Source/WebCore/platform/KillRingNone.cpp.
- platform/ios/TileCache.h: Added.
(WebCore::TileCache::isSpeculativeTileCreationEnabled):
- platform/ios/TileCache.mm: Added.
- platform/ios/TileGrid.h: Added.
- platform/ios/TileGrid.mm: Added.
- platform/ios/TileGridTile.h: Copied from Source/WebCore/platform/ContentFilter.h.
- platform/ios/TileGridTile.mm: Added.
- platform/ios/TileLayer.h: Copied from Source/WebCore/platform/mac/DisplaySleepDisabler.h.
- platform/ios/TileLayer.mm: Added.
- platform/ios/TileLayerPool.mm: Added.
- platform/ios/WebCoreMotionManager.h: Copied from Source/WebCore/platform/KillRingNone.cpp.
- platform/ios/WebCoreMotionManager.mm: Added.
- platform/ios/WebCoreSystemInterfaceIOS.h: Added.
- platform/ios/WebCoreSystemInterfaceIOS.mm: Added.
- platform/ios/WebEvent.h: Added.
- platform/ios/WebEvent.mm: Added.
- platform/ios/WidgetIOS.mm: Added.
- platform/mac/DisplaySleepDisabler.cpp:
(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
(WebCore::DisplaySleepDisabler::~DisplaySleepDisabler):
- platform/mac/DisplaySleepDisabler.h:
- platform/mac/FileSystemMac.mm:
- platform/mac/KillRingMac.mm:
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::install):
(WebCore::MemoryPressureHandler::releaseMemory):
- platform/mac/PlatformClockCM.mm:
(PlatformClockCM::PlatformClockCM):
- platform/mac/SoftLinking.h:
- platform/mac/SystemVersionMac.mm:
- platform/mac/WebCoreFullScreenPlaceholderView.h:
- platform/mac/WebCoreFullScreenPlaceholderView.mm:
- platform/mac/WebCoreFullScreenWarningView.h:
- platform/mac/WebCoreFullScreenWarningView.mm:
- platform/mac/WebCoreFullScreenWindow.h:
- platform/mac/WebCoreFullScreenWindow.mm:
- platform/mac/WebCoreNSCellExtras.h:
- platform/mac/WebCoreNSCellExtras.m:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebFontCache.mm:
(+[WebFontCache fontWithFamily:traits:size:]):
- platform/network/BlobRegistry.cpp:
- platform/network/BlobRegistryImpl.cpp:
- platform/network/Credential.h:
- platform/network/CredentialStorage.cpp:
(WebCore::CredentialStorage::set):
(WebCore::CredentialStorage::clearCredentials):
- platform/network/CredentialStorage.h:
- platform/network/NetworkStateNotifier.h:
- platform/network/ResourceHandle.cpp:
(WebCore::builtinResourceHandleConstructorMap):
(WebCore::ResourceHandle::continueWillSendRequest):
(WebCore::ResourceHandle::continueDidReceiveResponse):
(WebCore::ResourceHandle::continueShouldUseCredentialStorage):
(WebCore::ResourceHandle::continueCanAuthenticateAgainstProtectionSpace):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setDefaultAllowCookies):
(WebCore::ResourceRequestBase::defaultAllowCookies):
- platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::ResourceRequestBase):
- platform/network/cf/CredentialStorageCFNet.cpp:
(WebCore::CredentialStorage::saveToPersistentStorage):
- platform/network/cf/DNSCFNet.cpp:
- platform/network/cf/ProxyServerCFNet.cpp:
- platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::setMainResourceRequest):
(WebCore::ResourceRequest::isMainResourceRequest):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::applyWebArchiveHackForMail):
(WebCore::initializeHTTPConnectionSettingsOnStartup):
- platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::reportErrorToClient):
- platform/network/ios/NetworkStateNotifierIOS.cpp: Copied from Source/WebCore/platform/KillRingNone.cpp.
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
(WebCore::NetworkStateNotifier::setIsOnLine):
- platform/network/ios/QuickLook.h: Added.
- platform/network/ios/QuickLook.mm: Added.
- platform/network/ios/ResourceHandleIOS.mm: Added.
- platform/network/ios/WebCoreURLResponseIOS.h: Copied from Source/WebCore/platform/graphics/StringTruncator.h.
- platform/network/ios/WebCoreURLResponseIOS.mm: Added.
- platform/network/mac/AuthenticationMac.mm:
(WebCore::mac):
- platform/network/mac/CredentialStorageMac.mm:
(WebCore::CredentialStorage::saveToPersistentStorage):
- platform/network/mac/ResourceErrorMac.mm:
(dictionaryThatCanCode):
(-[WebCustomNSURLError encodeWithCoder:]):
(NSErrorFromCFError):
(WebCore::ResourceError::nsError):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::synchronousWillSendRequestEnabled):
(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::schedule):
(WebCore::ResourceHandle::unschedule):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::updateNSURLRequest):
(WebCore::ResourceRequest::applyWebArchiveHackForMail):
(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):
- platform/network/mac/UTIUtilities.mm:
- platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
(-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]):
(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
(-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):
(-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
(-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
(-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
- platform/sql/SQLiteDatabase.h:
(WebCore::SQLiteDatabase::sqlite3Handle):
- platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::truncateDatabaseFile):
- platform/sql/SQLiteFileSystem.h:
- platform/sql/SQLiteTransaction.cpp:
(WebCore::SQLiteTransaction::begin):
(WebCore::SQLiteTransaction::commit):
(WebCore::SQLiteTransaction::rollback):
(WebCore::SQLiteTransaction::stop):
- platform/sql/ios/SQLiteDatabaseTracker.cpp: Added.
- platform/sql/ios/SQLiteDatabaseTracker.h: Copied from Source/WebCore/platform/MemoryPressureHandler.cpp.
- platform/sql/ios/SQLiteDatabaseTrackerClient.h: Copied from Source/WebCore/platform/KillRingNone.cpp.
- platform/text/PlatformLocale.cpp:
- platform/text/PlatformLocale.h:
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::cursorMovementIterator):
- platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerEncodingNames):
(WebCore::TextCodecICU::registerCodecs):
- platform/text/TextEncodingRegistry.cpp:
(WebCore::extendTextCodecMaps):
- platform/text/cf/HyphenationCF.cpp:
(WebCore::canHyphenate):
- platform/text/ios/LocalizedDateCache.h: Copied from Source/WebCore/platform/MemoryPressureHandler.h.
- platform/text/ios/LocalizedDateCache.mm: Added.
- platform/text/mac/CharsetData.h:
- platform/text/mac/LocaleMac.h:
- platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::formatDateTime):
(WebCore::LocaleMac::maximumWidthForDateType):
- platform/text/mac/TextBoundaries.mm:
(WebCore::isSkipCharacter):
(WebCore::isWhitespaceCharacter):
(WebCore::isWordDelimitingCharacter):
(WebCore::isSymbolCharacter):
(WebCore::isAmbiguousBoundaryCharacter):
(WebCore::tokenizerForString):
(WebCore::findSimpleWordBoundary):
(WebCore::findComplexWordBoundary):
(WebCore::findWordBoundary):
(WebCore::findNextWordFromIndex):
- platform/text/mac/TextCodecMac.cpp:
- platform/text/mac/TextCodecMac.h:
Source/WTF:
- wtf/MainThread.cpp:
(WTF::canAccessThreadLocalDataForThread):
- wtf/MainThread.h:
- 2:53 PM Changeset in webkit [161588] by
-
- 14 edits in trunk/Source/WebCore
Web Inspector: Consolidate developerExtrasEnabled to just InspectorEnvironment
https://bugs.webkit.org/show_bug.cgi?id=126717
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-09
Reviewed by Timothy Hatcher.
They all route to InspectorEnvironment::developerExtrasEnabled, so make
InspectorEnvironment available to all agents through InstrumentingAgents
and use that where needed.
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
- inspector/InspectorAgent.h:
(WebCore::InspectorAgent::create):
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::didFinishXHRLoading):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::enabled):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::frameDocumentUpdatedImpl):
(WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
(WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
- inspector/InstrumentingAgents.cpp:
(WebCore::InstrumentingAgents::InstrumentingAgents):
- inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::create):
(WebCore::InstrumentingAgents::inspectorEnvironment):
- inspector/PageConsoleAgent.cpp:
- inspector/PageConsoleAgent.h:
- inspector/WorkerConsoleAgent.cpp:
- inspector/WorkerConsoleAgent.h:
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
- 2:51 PM Changeset in webkit [161587] by
-
- 2 edits1 copy in tags/Safari-538.10.2/Source/JavaScriptCore
Merged r161574. <rdar://problem/15762689>
- 2:49 PM Changeset in webkit [161586] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Remove Unnecessary InspectorAgent parameters
https://bugs.webkit.org/show_bug.cgi?id=126712
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-09
Reviewed by Timothy Hatcher.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::create):
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):
- inspector/InspectorPageAgent.h:
- 2:23 PM Changeset in webkit [161585] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed Windows build fix for r161563.
Copy all scripts, some may not be .py.
- JavaScriptCore.vcxproj/copy-files.cmd:
- 2:14 PM Changeset in webkit [161584] by
-
- 2 edits in trunk/Source/WebCore
Remove an accidentally left-behind static_cast.
- dom/ElementDescendantIterator.h:
(WebCore::ElementDescendantIteratorAdapter<ElementType>::beginAt):
- 2:10 PM Changeset in webkit [161583] by
-
- 6 edits in trunk/Source/WebCore
Replace ElementIteratorAdapter find() with beginAt()
https://bugs.webkit.org/show_bug.cgi?id=126714
Reviewed by Andreas Kling.
ElementIteratorAdapter find() would return iterator for the argument element if it was
of correct type and in the right subtree. This is not really what you would expect from find()
so replace it with a simple beginAt() iterator construction function.
- dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::getAllElementsById):
- dom/ElementChildIterator.h:
(WebCore::ElementChildIteratorAdapter<ElementType>::beginAt):
(WebCore::ElementChildConstIteratorAdapter<ElementType>::beginAt):
- dom/ElementDescendantIterator.h:
(WebCore::ElementDescendantIteratorAdapter<ElementType>::beginAt):
(WebCore::ElementDescendantConstIteratorAdapter<ElementType>::beginAt):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formElementIndex):
- html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::rowAfter):
- 2:07 PM Changeset in webkit [161582] by
-
- 15 edits in branches/jsCStack/Source/JavaScriptCore
CStack: Rename "host zone" to "reserved zone".
https://bugs.webkit.org/show_bug.cgi?id=126716.
Reviewed by Michael Saboff.
The "zone" is used as a reserve of stack memory for:
- nominal host code stack usage.
- stack space for error handling.
- initial stack space for pushing VMEntrySentinel frames.
The "zone" may reside on the C stack and on the C loop JSStack depending
on context. Hence, the name "host zone" is not quite accurate, and we'll
rename it to "reserved zone".
- interpreter/JSStack.cpp:
(JSC::JSStack::JSStack):
(JSC::JSStack::growSlowCase):
(JSC::JSStack::releaseExcessCapacity):
(JSC::JSStack::setReservedZoneSize):
- interpreter/JSStack.h:
- interpreter/JSStackInlines.h:
(JSC::JSStack::shrink):
- runtime/ErrorHandlingScope.cpp:
(JSC::ErrorHandlingScope::ErrorHandlingScope):
(JSC::ErrorHandlingScope::~ErrorHandlingScope):
- runtime/ErrorHandlingScope.h:
- runtime/JSLock.cpp:
(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):
- runtime/JSLock.h:
- runtime/Options.h:
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::updateStackLimitWithReservedZoneSize):
- runtime/VM.h:
(JSC::VM::reservedZoneSize):
- runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):
- runtime/VMEntryScope.h:
- 2:05 PM Changeset in webkit [161581] by
-
- 3 edits in trunk/LayoutTests
Rebaseline after r161568.
- platform/mac/fast/images/pdf-as-image-landscape-expected.png:
- platform/mac/fast/images/pdf-as-image-landscape-expected.txt:
- 1:31 PM Changeset in webkit [161580] by
-
- 4 edits in branches/safari-537.74-branch/Source/WebCore
Merge r161568: <rdar://problem/15784802>
- 1:26 PM Changeset in webkit [161579] by
-
- 4 edits2 copies in tags/Safari-538.10.2
Merged r161404. <rdar://problem/15398575>
- 1:23 PM Changeset in webkit [161578] by
-
- 5 edits in tags/Safari-538.10.2/Source
Versioning.
- 1:21 PM Changeset in webkit [161577] by
-
- 7 edits in trunk/Source
REGRESSION (r160152): Selection drag snapshot doesn't appear or has the wrong content on Retina
https://bugs.webkit.org/show_bug.cgi?id=125375
Reviewed by Darin Adler.
Source/WebCore:
Move scaling of drag images by the device scale factor out of DragClient
and into WebCore. This removes several redundant copies and scaling operations.
Fix scaling bugs that were cancelled out by over-allocating the backing store.
- page/DragController.cpp:
(WebCore::DragController::startDrag): Scale the drag image for a link
according to the device scale factor before giving it to the OS.
(WebCore::DragController::doImageDrag): Scale the drag image for an image
according to the device scale factor before giving it to the OS.
- page/FrameSnapshotting.cpp:
(WebCore::snapshotFrameRect): Don't pre-scale or clip the snapshot. The
ImageBuffer does this already.
- platform/DragImage.cpp:
(WebCore::createDragImageFromSnapshot): Don't scale the backing store
when copying an ImageBuffer into an Image.
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::copyImage): Draw the image in user-space coordinates,
not in backing-store coordinates. Remove unnecessary assertions. Crop the
buffer before drawing the image into it.
Source/WebKit2:
Remove scaling from WebDragClient because it is now selectively
performed by WebCore according to the drag image source.
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag): Don't scale the provided drag image.
- 1:19 PM Changeset in webkit [161576] by
-
- 1 copy in tags/Safari-538.10.2
New Tag.
- 1:10 PM Changeset in webkit [161575] by
-
- 38 edits3 adds in branches/jsCStack
CStack: Need a separate stack limit for the JS stack and the C stack.
https://bugs.webkit.org/show_bug.cgi?id=126320.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
The purpose of this patch is mainly to change the way we compute the stack
limit for JS stack checks. Previously, we tally up the stack usage per
session of VM re-entry as tracked by the VMEntryScope, and we ensure that
the total usage does not exceed Options::maxStackSize(), and of course, is
also capped by the amount of native C stack available. The usage tracking
here does not count host / native function stack usage against the max
stack usage.
The new way is to compute a limit as an offset from the VMEntryScope of
the first entry into the VM. Options::maxPerThreadStackUsage()
will provide that offset. Any host / native function stack usage after
we've entered the VM will be counted against the max stack usage.
This patch supplants parts or all of the following previously committed
patches:
r161104: https://bugs.webkit.org/show_bug.cgi?id=126266
Rename VM::entryScope to firstEntryScope.
r161232: https://bugs.webkit.org/show_bug.cgi?id=126321
Introducing Options::maxStackSize().
r161172: https://bugs.webkit.org/show_bug.cgi?id=126331
Refactor to split the tracking of the jsStackLimit from the
native stackLimit.
r161174: https://bugs.webkit.org/show_bug.cgi?id=126334
Introduce tracking of the top VMEntryScope.
r161361: https://bugs.webkit.org/show_bug.cgi?id=126487
The fixed up jsStackLimit in doCallToJavaScript should not
exceed the native stack limit.
r161180: https://bugs.webkit.org/show_bug.cgi?id=126320
Need a separate stack limit for the JS stack and the C stack.
This was for the old way of tracking chunks of stack usage
per VMEntryScope.
Details of this patch:
- Renamed VM::firstEntryScope back to VM::entryScope. Removed the tracking of topEntryScope and related code.
- Renamed Options::maxStackSize() to maxPerThreadStackUsage(). Added Options::hostZoneSize() and Options::errorModeHostZoneSize().
- The VM now tracks its current hostZoneSize and stack limits. VM::m_stackLimit is computed when the hostZoneSize is set via VM::updateStackLimitWithHostZoneSize().
In the C Loop LLINT case, the VM also provides a setJSStackLimit()
since VM::m_stackLimit and VM::m_jsStackLimit are 2 different values
in that case.
- Replaced Interpreter::ErrorHandlingMode with ErrorHandlingScope. The ErrorHandlingScope constructor will set the VM host zone size to Options::errorModeHostZoneSize(), and restore the previous host zone size.
The destructor for ErrorHandlingScope will restore the previous stack
limit. We can enter multiple ErrorHandlingScopes. Only the destruction
of the very first one will restore the stack limit with the non-error
mode host zone.
- LLINT C loop JSStack changes: 5.1 Replaced calls to roundUpToAllocationSize() with WTF::roundUpToMultipleOf().
roundUpToAllocationSize() is redundant and is now removed.
5.2 Removed enable/disableErrorStackReserve() and updateStackLimit().
Their function is now handled by JSStack::setHostZoneSize().
5.3 Added accounting for a host zone in the LLINT C loop JSStack.
This includes growing the JS stack to allow space for the host zone
whenever the host zone size is adjusted via JSStack::setHostZoneSize().
Note: though setHostZoneSize() is based on disableErrorStackReserve(),
we don't retain the logic to shrink the stack there. That logic was
always dead code: we only call shrink() if m_end + 1 < m_useableTop,
but shrink() will only shrink the stack if m_end is pointing to the
base of the stack i.e. the 2 conditions are mutually exclusive, and
no work to shrink the stack will ever be done here.
m_useableTop is no longer needed and is now removed.
5.4 Change all non C loop code to reference VM::stackLimit() instead of
VM::jsStackLimit(). Though the 2 are the same for non C loop builds,
this makes it more straightforward. We now only reference the
jsStackLimit in 2 cases:
- LLINT and JIT code performing stack checks where they expect the jsStackLimit to be a pseudonym for the stackLimit in non C loop builds.
- In the C loop build, the JSStack itself sets VM::m_jsStackLimit() when it adjusts its host zone size.
In all other cases, we work directly with VM::stackLimit().
- Simplify the tracking of VM::stackPointerAtVMEntry. We now set VM::stackPointerAtVMEntry when we install a VMEntryScope if and only if it isn't already set.
When we drop the API locks, we'll save the current stackPointerAtVMEntry
and stack limit value, and clear stackPointerAtVMEntry to allow a new
thread acquiring the API locks to re-set it when it installs a VMEntryScope.
When we re-acquire the API locks again, we'll restore the previously saved
stackPointerAtVMEntry and stack limit.
With this change, we also no longer need the stackPointerAtVMEntry fix up
code in doCallToJavaScript(). That code is now removed.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
- debugger/DebuggerCallFrame.cpp:
- heap/Heap.cpp:
(JSC::Heap::lastChanceToFinalize):
(JSC::Heap::deleteAllCompiledCode):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::vmEntryGlobalObject):
- interpreter/Interpreter.cpp:
- interpreter/Interpreter.h:
- interpreter/JSStack.cpp:
(JSC::JSStack::JSStack):
(JSC::JSStack::~JSStack):
(JSC::JSStack::growSlowCase):
(JSC::JSStack::releaseExcessCapacity):
(JSC::JSStack::setHostZoneSize):
(JSC::JSStack::lowAddress):
- interpreter/JSStack.h:
- interpreter/JSStackInlines.h:
(JSC::JSStack::ensureCapacityFor):
(JSC::JSStack::shrink):
- jit/ExecutableAllocator.h:
- jit/JITOperations.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter64.asm:
- parser/ParserError.h:
(JSC::ParserError::toErrorObject):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/ErrorHandlingScope.cpp: Added.
(JSC::ErrorHandlingScope::ErrorHandlingScope):
(JSC::ErrorHandlingScope::~ErrorHandlingScope):
- runtime/ErrorHandlingScope.h: Added.
- runtime/ExceptionHelpers.cpp:
(JSC::throwStackOverflowError):
(JSC::throwTerminatedExecutionException):
- runtime/JSLock.cpp:
(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):
- runtime/JSLock.h:
- runtime/Options.h:
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::releaseExecutableMemory):
(JSC::VM::updateStackLimitWithHostZoneSize):
- runtime/VM.h:
- runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):
- runtime/VMEntryScope.h:
Source/WebCore:
No new tests.
- ForwardingHeaders/runtime/ErrorHandlingScope.h: Added.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
- Updated to use ErrorHandlingScope instead of Interpreter::ErrorHandlingMode.
Source/WTF:
- wtf/StackBounds.h:
(WTF::StackBounds::recursionLimit):
- Previously, StackBounds::recursionLimit() only takes a host zone size which it uses to compute the client's desired stack limit. Now, there's an alternate version that also allows the client to explicitly specify its desired stack limit in addition to its hostZoneSize requirement. In both cases, StackBounds::recursionLimit() will cap the limit (with allowance for the hostZoneSize) to be within its bounds, and return the capped limit.
LayoutTests:
- js/large-expressions-expected.txt:
- js/script-tests/large-expressions.js:
- Changed expected result to reflect the much more constrained stack size now that the JS stack limit also limits stack usage by host / native functions.
- 12:41 PM Changeset in webkit [161574] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
AI for CreateArguments should pass through non-SpecEmpty input values
https://bugs.webkit.org/show_bug.cgi?id=126709
Reviewed by Mark Hahnenberg.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- tests/stress/use-arguments-as-object-pointer.js: Added.
(foo):
- 12:30 PM Changeset in webkit [161573] by
-
- 3 edits2 adds in trunk
Narrow underlines are too tall
https://bugs.webkit.org/show_bug.cgi?id=126708
Reviewed by Simon Fraser.
Source/WebCore:
I made a typo in r158392 and used was settings the line rect's
height equal to its width. No one noticed because of the subsequent
if statement.
Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-tall-underlines.html
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::computeLineBoundsAndAntialiasingModeForText):
LayoutTests:
This test clips to a region that should not be drawn in, then draws a scaled underline. It then compares
the output to an empty element.
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-tall-underlines-expected.html: Added.
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-tall-underlines.html: Added.
- 12:22 PM Changeset in webkit [161572] by
-
- 3 edits in trunk/Source/WebCore
DocumentOrderedMap should use iterator
https://bugs.webkit.org/show_bug.cgi?id=126696
Reviewed by Andreas Kling.
- dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesId):
(WebCore::keyMatchesName):
(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::keyMatchesLowercasedUsemap):
(WebCore::keyMatchesLabelForAttribute):
(WebCore::keyMatchesWindowNamedItem):
(WebCore::keyMatchesDocumentNamedItem):
Switch to Element references.
(WebCore::DocumentOrderedMap::add):
(WebCore::DocumentOrderedMap::remove):
(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getAllElementsById):
Use element iterator instead of ElementTraversal.
- dom/DocumentOrderedMap.h:
- 12:20 PM Changeset in webkit [161571] by
-
- 5 edits in trunk/Source/WebKit2
WebKit2 View Gestures: Support plugins that take over the page scale gesture
https://bugs.webkit.org/show_bug.cgi?id=126399
<rdar://problem/15738928>
Reviewed by Sam Weinig.
Teach ViewGestureController how to handle WebFrame::handlesPageScaleGesture=true,
which is used so that PDFPlugin can deal with magnification itself.
- UIProcess/mac/ViewGestureController.cpp:
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::didCollectGeometryForMagnificationGesture):
(WebKit::ViewGestureController::handleMagnificationGesture):
(WebKit::ViewGestureController::endMagnificationGesture):
(WebKit::ViewGestureController::didCollectGeometryForSmartMagnificationGesture):
If the WebFrame is going to handle the page scale gesture itself (which currently
simply means that it is a main-frame PDFPlugin), send the magnification information
straight through to it. Also, don't provide smart-zoom in this case, since there
is currently no way to collect geometry information from the plugin.
- UIProcess/mac/ViewGestureController.h:
- UIProcess/mac/ViewGestureController.messages.in:
- WebProcess/WebPage/ViewGestureGeometryCollector.cpp:
(WebKit::ViewGestureGeometryCollector::collectGeometryForMagnificationGesture):
(WebKit::ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture):
Retrieve WebFrame::handlesPageScaleGesture and return it to the UI process.
- 12:20 PM Changeset in webkit [161570] by
-
- 18 edits in trunk/Source/WebCore
Margin tiles are not repainted when background color changes
https://bugs.webkit.org/show_bug.cgi?id=126541
-and corresponding-
<rdar://problem/15578131>
Reviewed by Simon Fraser.
This patch adds an optional parameter to GraphicsLayer::setNeedsDisplayInRect,
RenderLayerBacking::setContentsNeedDisplay(), and
RenderLayer::setBackingNeedsRepaint() that is used to determine whether or not to
clip the invalidation rect to the size of the layer. Then whenever the margin
needs to be repainted, we can call setNeedsDisplayInRect() with a rect that
includes the margin, and also indicate that it should not be clipped.
GraphicsLayer now takes an optional parameter which is an enum called
ShouldClipToLayer.
- WebCore.exp.in:
- platform/graphics/GraphicsLayer.h:
- platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplayInRect):
- platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setNeedsDisplayInRect):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setNeedsDisplayInRect):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
Make TileController::bounds() a virtual function, and declare it on TiledBacking
so that we can call it from RenderLayerBacking.
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/mac/TileController.h:
RenderLayer also now takes an optional parameter which is an enum called
ShouldClipToLayer.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
If the margin needs to be repainted, call GraphicsLayer::setNeedsDisplayInRect
with a big enough rect and a ShouldClipToLayer value of DoNotClipToLayer.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
- rendering/RenderLayerBacking.h:
Whenever all of the root contents need to be repainted the margin will also need
to be repainted, so call setBackingNeedsRepaint() with the new parameter
indicating the the invalidation should NOT be clipped to the layer size.
- rendering/RenderView.cpp:
(WebCore::RenderView::repaintRootContents):
- 12:16 PM Changeset in webkit [161569] by
-
- 19 edits in trunk/Source/WebCore
[CSS Shapes] Factor the ReferenceBox type out of BasicShapes
https://bugs.webkit.org/show_bug.cgi?id=126648
Reviewed by Dirk Schulze.
Moving ReferenceBox out of BasicShapes and into RenderStyleConstants
as the LayoutBox enum. Most of the changes are removing the BasicShape
namespace.
Refactoring, no new tests.
- css/BasicShapeFunctions.cpp:
(WebCore::valueForBox):
(WebCore::boxForValue):
(WebCore::valueForBasicShape):
(WebCore::basicShapeForValue):
- css/BasicShapeFunctions.h:
- css/CSSBasicShapes.cpp:
(WebCore::CSSBasicShapeRectangle::cssText):
(WebCore::CSSBasicShapeRectangle::equals):
(WebCore::CSSBasicShapeCircle::cssText):
(WebCore::CSSBasicShapeCircle::equals):
(WebCore::CSSDeprecatedBasicShapeCircle::cssText):
(WebCore::CSSDeprecatedBasicShapeCircle::equals):
(WebCore::CSSBasicShapeEllipse::cssText):
(WebCore::CSSBasicShapeEllipse::equals):
(WebCore::CSSDeprecatedBasicShapeEllipse::cssText):
(WebCore::CSSDeprecatedBasicShapeEllipse::equals):
(WebCore::CSSBasicShapePolygon::cssText):
(WebCore::CSSBasicShapePolygon::equals):
(WebCore::CSSBasicShapeInsetRectangle::cssText):
(WebCore::CSSBasicShapeInsetRectangle::equals):
(WebCore::CSSBasicShapeInset::cssText):
- css/CSSBasicShapes.h:
(WebCore::CSSBasicShape::layoutBox):
(WebCore::CSSBasicShape::setLayoutBox):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseShapeProperty):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
- rendering/ClipPathOperation.h:
(WebCore::ShapeClipPathOperation::setReferenceBox):
(WebCore::ShapeClipPathOperation::referenceBox):
(WebCore::ShapeClipPathOperation::ShapeClipPathOperation):
(WebCore::BoxClipPathOperation::create):
(WebCore::BoxClipPathOperation::referenceBox):
(WebCore::BoxClipPathOperation::BoxClipPathOperation):
- rendering/shapes/Shape.cpp:
(WebCore::Shape::createLayoutBoxShape):
- rendering/shapes/Shape.h:
- rendering/shapes/ShapeInfo.cpp:
(WebCore::ShapeInfo<RenderType>::computedShape):
- rendering/shapes/ShapeInfo.h:
(WebCore::ShapeInfo::setShapeSize):
(WebCore::ShapeInfo::logicalTopOffset):
(WebCore::ShapeInfo::logicalLeftOffset):
- rendering/shapes/ShapeInsideInfo.h:
- rendering/shapes/ShapeOutsideInfo.h:
- rendering/style/BasicShapes.cpp:
(WebCore::BasicShape::canBlend):
(WebCore::BasicShape::referenceBoxSize):
- rendering/style/BasicShapes.h:
(WebCore::BasicShape::layoutBox):
(WebCore::BasicShape::setLayoutBox):
(WebCore::BasicShape::BasicShape):
- rendering/style/RenderStyleConstants.h:
- rendering/style/ShapeValue.h:
(WebCore::ShapeValue::createLayoutBoxValue):
(WebCore::ShapeValue::layoutBox):
(WebCore::ShapeValue::ShapeValue):
- 12:14 PM Changeset in webkit [161568] by
-
- 4 edits in trunk/Source/WebCore
PDFDocumentImage can be very slow to do the initial paint
https://bugs.webkit.org/show_bug.cgi?id=126633
<rdar://problem/15770980>
Reviewed by Simon Fraser.
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::PDFDocumentImage):
(WebCore::PDFDocumentImage::size):
(WebCore::transformContextForPainting):
(WebCore::PDFDocumentImage::computeBoundsForCurrentPage):
(WebCore::applyRotationForPainting):
(WebCore::PDFDocumentImage::drawPDFPage):
- platform/graphics/cg/PDFDocumentImage.h:
- platform/graphics/mac/PDFDocumentImageMac.mm:
(WebCore::PDFDocumentImage::computeBoundsForCurrentPage):
Store rotation from the PDF in degrees, since it can
only be 0, 90, 180, or 270, and don't do any trig to
perform the rotation, to avoid introducing minor rounding
issues in the size.
Once we're going to paint, if the difference between the
computed scale for each axis is due only to integer rounding
of the image size, use the same scale for both axes, to avoid
a CG slow-path which occurs whenever the scale is nonuniform.
- 12:09 PM Changeset in webkit [161567] by
-
- 4 edits in trunk/Source/WebCore
Disconnect child frames iteratively
https://bugs.webkit.org/show_bug.cgi?id=126700
Reviewed by Andreas Kling.
Use descendant iterator instead of recursion for traversal.
- dom/ContainerNode.cpp:
(WebCore::willRemoveChild):
(WebCore::willRemoveChildren):
(WebCore::ContainerNode::disconnectDescendantFrames):
- dom/ContainerNodeAlgorithms.cpp:
(WebCore::assertConnectedSubrameCountIsConsistent):
(WebCore::collectFrameOwners):
(WebCore::disconnectSubframes):
Get rid of the strange ChildFrameDisconnector class in favor of a function.
- dom/ContainerNodeAlgorithms.h:
(WebCore::disconnectSubframesIfNeeded):
- 11:38 AM Changeset in webkit [161566] by
-
- 6 edits in trunk
[Cocoa] Promote WKBackForwardList{,Item}.h to public
https://bugs.webkit.org/show_bug.cgi?id=126707
Reviewed by Sam Weinig.
Source/WebKit2:
- UIProcess/API/Cocoa/WKBackForwardList.h: Stopped including the C API header.
- UIProcess/API/Cocoa/WKBackForwardListItem.h: Ditto.
- WebKit2.xcodeproj/project.pbxproj: Made the headers public.
Tools:
- Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
left behind in the build products directory after a private header is made public.
- 11:25 AM Changeset in webkit [161565] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Windows build fix for r161563.
Remove reference to removed file.
- bindings/js/JSBindingsAllInOne.cpp:
- 11:14 AM Changeset in webkit [161564] by
-
- 3 edits in trunk/Source/JavaScriptCore
Constructors for Objective-C classes do not work properly with instanceof
https://bugs.webkit.org/show_bug.cgi?id=126670
Reviewed by Oliver Hunt.
This bug is due to the fact that the JS constructors created for Objective-C classes via the JSC
API inherit from JSCallbackObject, which overrides hasInstance with its own customHasInstance.
JSCallbackObject::customHasInstance only checks the JSClassRefs for hasInstance callbacks.
If it doesn't find any callbacks, it returns false.
This patch adds a hasInstance callback to constructors created for Objective-C wrapper classes.
- API/JSWrapperMap.mm:
(constructorHasInstance):
(constructorWithCustomBrand):
(allocateConstructorForCustomClass):
- API/tests/testapi.mm:
- 11:00 AM Changeset in webkit [161563] by
-
- 69 edits9 copies10 moves11 adds6 deletes in trunk/Source
Web Inspector: Move InjectedScript classes into JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=126598
Source/JavaScriptCore:
Reviewed by Timothy Hatcher.
Part 1: Extract InspectorInstrumentationCookie class from InspectorInstrumentation.
Part 2: Move InjectedScriptSource and generation into JavaScriptCore.
Part 3: Update CodeGeneratorInspector to avoid inlining virtual destructors.
Part 4: Move all inspector scripts into JavaScriptCore and update generators.
Part 5: Move InjectedScript classes into JavaScriptCore
Part 6: Put it all together. Make WebCore use the JavaScriptCore InjectedScript files.
There are pieces of logic that WebCore wants to hook into in the InjectedScript
execution (e.g. for CommandLineAPIModule and InspectorInstrumentation). Create
hooks for those in a base class called InspectorEnvironment. For now, the
InspectorControllers (Page, JSGlobalObject, Worker) will be the InspectorEnvironments
and provide answers to its hooks.
- inspector/InspectorEnvironment.h: Added.
New hooks needed by WebCore in various places. Mostly stubbed in JavaScriptCore.
- inspector/InjectedScript.cpp: Renamed from Source/WebCore/inspector/InjectedScript.cpp.
- inspector/InjectedScript.h: Added.
- inspector/InjectedScriptBase.cpp: Renamed from Source/WebCore/inspector/InjectedScriptBase.cpp.
- inspector/InjectedScriptBase.h: Renamed from Source/WebCore/inspector/InjectedScriptBase.h.
- inspector/InjectedScriptModule.cpp: Renamed from Source/WebCore/inspector/InjectedScriptModule.cpp.
- inspector/InjectedScriptModule.h: Renamed from Source/WebCore/inspector/InjectedScriptModule.h.
Cleanup the style of these files (nullptr, formatting, whitespace, etc).
Use the InspectorEnvironments call/evaluate function for ScriptFunctionCalls and checking access
- inspector/InjectedScriptManager.cpp: Renamed from Source/WebCore/inspector/InjectedScriptManager.cpp.
- inspector/InjectedScriptManager.h: Renamed from Source/WebCore/inspector/InjectedScriptManager.h.
Take an InspectorEnvironment with multiple hooks, instead of a single hook function.
- inspector/InjectedScriptHost.cpp: Added.
- inspector/InjectedScriptHost.h: Added.
- inspector/JSInjectedScriptHost.cpp: Renamed from Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp.
- inspector/JSInjectedScriptHost.h: Added.
- inspector/JSInjectedScriptHostPrototype.cpp: Added.
- inspector/JSInjectedScriptHostPrototype.h: Added.
Implementation of InjectedScriptHost which is passed into the script (InjectedScriptSource.js)
that we inject into the page. This is mostly copied from the original autogenerated code,
then simplified and cleaned up. InjectedScriptHost can be subclasses to provide specialized
implementations of isHTMLAllCollection and type for Web/DOM types unknown to a pure JS context.
For OS X be sure to export the scripts as if they are private headers.
- GNUmakefile.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- inspector/scripts/cssmin.py: Renamed from Source/WebCore/inspector/Scripts/cssmin.py.
- inspector/scripts/inline-and-minify-stylesheets-and-scripts.py: Renamed from Source/WebCore/inspector/Scripts/inline-and-minify-stylesheets-and-scripts.py.
- inspector/scripts/jsmin.py: Renamed from Source/WebCore/inspector/Scripts/jsmin.py.
- inspector/scripts/xxd.pl: Renamed from Source/WebCore/inspector/xxd.pl.
This avoids build errors about duplicate exported virtual inlined methods
are included from multiple places. Just put empty destructors in the
implementation file instead of inlined.
- inspector/scripts/CodeGeneratorInspector.py:
(Generator):
(Generator.go):
- inspector/scripts/CodeGeneratorInspectorStrings.py:
Move InjectedScriptSource.js and derived sources generation.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- inspector/InjectedScriptSource.js: Renamed from Source/WebCore/inspector/InjectedScriptSource.js.
Source/WebCore:
Reviewed by Timothy Hatcher.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.list.am:
- UseJSC.cmake:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Remove old InjectedScript files.
- ForwardingHeaders/inspector/InjectedScript.h: Added.
- ForwardingHeaders/inspector/InjectedScriptBase.h: Added.
- ForwardingHeaders/inspector/InjectedScriptHost.h: Added.
- ForwardingHeaders/inspector/InjectedScriptManager.h: Added.
- ForwardingHeaders/inspector/InjectedScriptModule.h: Added.
- ForwardingHeaders/inspector/InspectorEnvironment.h: Added.
Expose headers to WebCore.
- inspector/InspectorController.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::developerExtrasEnabled):
(WebCore::InspectorController::canAccessInspectedScriptState):
(WebCore::InspectorController::functionCallHandler):
(WebCore::InspectorController::evaluateHandler):
(WebCore::InspectorController::willCallInjectedScriptFunction):
(WebCore::InspectorController::didCallInjectedScriptFunction):
- inspector/WorkerInspectorController.h:
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::functionCallHandler):
(WebCore::WorkerInspectorController::evaluateHandler):
(WebCore::WorkerInspectorController::willCallInjectedScriptFunction):
(WebCore::WorkerInspectorController::didCallInjectedScriptFunction):
Make both InspectorControllers in WebCore be InspectorEnvironments.
- bindings/js/JSMainThreadExecState.h:
- bindings/js/JSMainThreadExecState.cpp:
(WebCore::evaluateHandlerFromAnyThread):
Make JSC::evaluate wrapper like the existing JSC::call wrapper.
These will be the ScriptFunctionCall implementations when debugging
a WebCore::Page or worker, instead of the pure JSC versions.
- inspector/PageInjectedScriptHost.h: Copied from Source/WebCore/inspector/CommandLineAPIModule.h.
- inspector/PageInjectedScriptHost.cpp: Copied from Source/WebCore/inspector/PageInjectedScriptManager.cpp.
(WebCore::PageInjectedScriptHost::type):
(WebCore::PageInjectedScriptHost::isHTMLAllCollection):
WebCore InjectedScriptHost implementation for DOM type handling.
- inspector/PageInjectedScriptManager.h:
- inspector/PageInjectedScriptManager.cpp:
(WebCore::PageInjectedScriptManager::PageInjectedScriptManager):
(WebCore::PageInjectedScriptManager::discardInjectedScriptsFor):
WebCore InjectedScriptManager implementation for CommandLineAPI and
specialized DOMWindow injected script management.
- bindings/js/JSBindingsAllInOne.cpp:
- inspector/CommandLineAPIHost.cpp:
- inspector/CommandLineAPIHost.h:
- inspector/CommandLineAPIModule.cpp:
(WebCore::CommandLineAPIModule::host):
- inspector/CommandLineAPIModule.h:
- inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
- inspector/ConsoleMessage.h:
- inspector/InjectedScriptCanvasModule.cpp:
(WebCore::InjectedScriptCanvasModule::InjectedScriptCanvasModule):
- inspector/InjectedScriptCanvasModule.h:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorCanvasAgent.cpp:
- inspector/InspectorCanvasAgent.h:
(WebCore::InspectorCanvasAgent::create):
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorDebuggerAgent.h:
(WebCore::InspectorDebuggerAgent::injectedScriptManager):
- inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::create):
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
- inspector/InspectorHeapProfilerAgent.h:
- inspector/InspectorIndexedDBAgent.cpp:
- inspector/InspectorIndexedDBAgent.h:
(WebCore::InspectorIndexedDBAgent::create):
- inspector/InspectorPageAgent.cpp:
- inspector/InspectorPageAgent.h:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::PageProfilerAgent::PageProfilerAgent):
(WebCore::InspectorProfilerAgent::create):
(WebCore::WorkerProfilerAgent::WorkerProfilerAgent):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorRuntimeAgent.cpp:
- inspector/InspectorRuntimeAgent.h:
(WebCore::InspectorRuntimeAgent::injectedScriptManager):
- inspector/PageConsoleAgent.cpp:
(WebCore::PageConsoleAgent::PageConsoleAgent):
- inspector/PageConsoleAgent.h:
(WebCore::PageConsoleAgent::create):
- inspector/PageDebuggerAgent.cpp:
- inspector/PageDebuggerAgent.h:
- inspector/PageRuntimeAgent.cpp:
- inspector/PageRuntimeAgent.h:
(WebCore::PageRuntimeAgent::create):
- inspector/WorkerConsoleAgent.cpp:
(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):
- inspector/WorkerConsoleAgent.h:
(WebCore::WorkerConsoleAgent::create):
- inspector/WorkerDebuggerAgent.cpp:
- inspector/WorkerDebuggerAgent.h:
- inspector/WorkerRuntimeAgent.cpp:
- inspector/WorkerRuntimeAgent.h:
(WebCore::WorkerRuntimeAgent::create):
Switch to using the Inspector namespace and JSC InjectedScript files.
- bindings/js/JSInjectedScriptManager.cpp: Removed.
- inspector/InjectedScript.h: Removed.
- inspector/InjectedScriptHost.cpp: Removed.
- inspector/InjectedScriptHost.h: Removed.
- inspector/InjectedScriptHost.idl: Removed.
With the updated location switch to using the appropriate INSPECTOR_SCRIPTS_DIR
variable which defines where the scripts are.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Currently InjectedScriptBase uses InspectorInstrumentation directly
to track calling into JavaScript for timeline purposes. We will remove
the direct call from InjectedScriptBase and extracting the Cookie class
will make that easier.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorInstrumentation.h:
- inspector/InspectorInstrumentationCookie.cpp: Added.
(WebCore::InspectorInstrumentationCookie::InspectorInstrumentationCookie):
(WebCore::InspectorInstrumentationCookie::operator=):
(WebCore::InspectorInstrumentationCookie::~InspectorInstrumentationCookie):
- inspector/InspectorInstrumentationCookie.h: Added.
(WebCore::InspectorInstrumentationCookie::isValid):
(WebCore::InspectorInstrumentationCookie::instrumentingAgents):
(WebCore::InspectorInstrumentationCookie::hasMatchingTimelineAgentId):
- 10:46 AM Changeset in webkit [161562] by
-
- 2 edits in trunk/Source/JavaScriptCore
Regression: failing RegExp tests on 32 bit architectures.
https://bugs.webkit.org/show_bug.cgi?id=126699
Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2014-01-09
Reviewed by Michael Saboff.
Fix setRegExpConstructor functions for 32 bit architectures.
- runtime/RegExpConstructor.cpp:
(JSC::setRegExpConstructorInput):
(JSC::setRegExpConstructorMultiline):
- 10:34 AM Changeset in webkit [161561] by
-
- 2 edits in trunk/Source/WebKit2
Revert back to using the -n option when producing symbolic links to the GTK-specific
API directories under Source/WebKit2/. Removing the option in r161497 resulted in
recursive links being created under those directories since the links were dereferenced.
To actually ensure that the link is created anew, remove it so it is reconstructed.
Rubber-stamped by Carlos Garcia Campos.
- GNUmakefile.am:
- 10:31 AM Changeset in webkit [161560] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r161429?): Frequent crashes on media/track/media-element-enqueue-event-crash.html
https://bugs.webkit.org/show_bug.cgi?id=117756
- platform/mac/TestExpectations: Skipping the test, it crashes very frequently.
- 9:55 AM Changeset in webkit [161559] by
-
- 2 edits in trunk/Source/WebKit2
Crash when starting a download before the network process has been launched
https://bugs.webkit.org/show_bug.cgi?id=126258
Reviewed by Anders Carlsson.
We need to ensure there's a network process running before
starting a new download like we do when using the web process.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::download): Use ChildProcessProxy::send()
instead of using the connection to make sure messages are queued
if the process is still launching.
(WebKit::WebContext::createDownloadProxy): Call
ensureNetworkProcess() before creating the download proxy.
- 9:23 AM Changeset in webkit [161558] by
-
- 6 edits2 adds in trunk
Cannot select multiple non-adjacent items in a multiple select control with the keyboard only
https://bugs.webkit.org/show_bug.cgi?id=15816
Patch by Pascal Jacquemart <p.jacquemart@samsung.com> on 2014-01-09
Reviewed by Chris Fleizach.
Source/WebCore:
Test: fast/forms/listbox-non-contiguous-keyboard-selection.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::HTMLSelectElement):
New member m_allowsNonContiguousSelection defaults to false
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
Tracking CTRL modifier to start multiple non contiguous selection
- html/HTMLSelectElement.h: New member m_allowsNonContiguousSelection
(WebCore::HTMLSelectElement::allowsNonContiguousSelection): New getter
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::addFocusRingRects):
Following implementation made for spatial navigation
LayoutTests:
- fast/forms/listbox-non-contiguous-keyboard-selection-expected.txt: Added.
- fast/forms/listbox-non-contiguous-keyboard-selection.html: Added.
- platform/mac/TestExpectations:
Multiple non contiguous selection with keyboard not enabled on Mac
- 9:21 AM Changeset in webkit [161557] by
-
- 31 edits in trunk/Source
Unreviewed, rolling out r161540.
http://trac.webkit.org/changeset/161540
https://bugs.webkit.org/show_bug.cgi?id=126704
Caused assertion failures on multiple tests (Requested by ap
on #webkit).
Source/JavaScriptCore:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
- bytecode/CodeBlock.h:
(JSC::CodeBlockSet::mark):
- dfg/DFGOperations.cpp:
- heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::add):
(JSC::CodeBlockSet::traceMarked):
- heap/CodeBlockSet.h:
- heap/CopiedBlockInlines.h:
(JSC::CopiedBlock::reportLiveBytes):
- heap/CopiedSpace.cpp:
- heap/CopiedSpace.h:
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::didAbandon):
(JSC::Heap::markRoots):
(JSC::Heap::copyBackingStores):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):
(JSC::Heap::didAllocate):
- heap/Heap.h:
(JSC::Heap::shouldCollect):
(JSC::Heap::isCollecting):
(JSC::Heap::isWriteBarrierEnabled):
(JSC::Heap::writeBarrier):
- heap/HeapOperation.h:
- heap/MarkStack.cpp:
(JSC::MarkStackArray::~MarkStackArray):
- heap/MarkStack.h:
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::isPagedOut):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):
- heap/MarkedAllocator.h:
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::reset):
- heap/MarkedBlock.cpp:
- heap/MarkedBlock.h:
(JSC::MarkedBlock::lastChanceToFinalize):
(JSC::MarkedBlock::didConsumeEmptyFreeList):
(JSC::MarkedBlock::clearMarks):
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::~MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::visitWeakSets):
(JSC::MarkedSpace::reapWeakSets):
- heap/MarkedSpace.h:
(JSC::ClearMarks::operator()):
(JSC::MarkedSpace::clearMarks):
- heap/SlotVisitor.cpp:
(JSC::SlotVisitor::~SlotVisitor):
- heap/SlotVisitor.h:
(JSC::SlotVisitor::sharedData):
- heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::internalAppend):
(JSC::SlotVisitor::copyLater):
(JSC::SlotVisitor::reportExtraMemoryUsage):
- jit/Repatch.cpp:
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):
- runtime/JSPropertyNameIterator.h:
(JSC::StructureRareData::setEnumerationCache):
- runtime/JSString.cpp:
(JSC::JSString::visitChildren):
- runtime/StructureRareDataInlines.h:
(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::setObjectToStringValue):
- runtime/WeakMapData.cpp:
(JSC::WeakMapData::visitChildren):
Source/WTF:
- wtf/Bitmap.h:
(WTF::WordType>::count):
- 9:19 AM Changeset in webkit [161556] by
-
- 21 edits10 deletes in trunk
Web Inspector: Remove unused overriding protocols.
https://bugs.webkit.org/show_bug.cgi?id=126630
Reviewed by Timothy Hatcher.
Source/WebCore:
No new tests, No change in behavior.
Remove unused overriding protocols as these are not used anymore in Frontned.
-Page.setGeolocationOverride
-Page.clearGeolocationOverride
-Page.canOverrideGeolocation
-Page.setDeviceOrientationOverride
-Page.clearDeviceOrientationOverride
-Page.canOverrideGeolocation
-Network.setUserAgentOverride
- Modules/geolocation/GeolocationController.cpp:
(WebCore::GeolocationController::GeolocationController):
(WebCore::GeolocationController::create):
(WebCore::GeolocationController::positionChanged):
(WebCore::provideGeolocationTo):
- Modules/geolocation/GeolocationController.h:
- dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::DeviceOrientationController):
(WebCore::DeviceOrientationController::create):
(WebCore::DeviceOrientationController::didChangeDeviceOrientation):
(WebCore::provideDeviceOrientationTo):
- dom/DeviceOrientationController.h:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorInstrumentation.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
- inspector/InspectorPageAgent.h:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::disable):
- inspector/InspectorResourceAgent.h:
- inspector/protocol/Network.json:
- inspector/protocol/Page.json:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::userAgent):
Source/WebInspectorUI:
Update InspectorWebBackendCommands.js after removing unused overriding protocols.
- UserInterface/InspectorWebBackendCommands.js:
- UserInterface/Legacy/6.0/InspectorWebBackendCommands.js:
- UserInterface/Legacy/7.0/InspectorWebBackendCommands.js:
- Versions/Inspector-iOS-6.0.json:
- Versions/Inspector-iOS-7.0.json:
LayoutTests:
- http/tests/inspector/extensions-useragent-expected.txt: Removed.
- http/tests/inspector/extensions-useragent.html: Removed.
- inspector/device-orientation-success-expected.txt: Removed.
- inspector/device-orientation-success.html: Removed.
- inspector/geolocation-error-expected.txt: Removed.
- inspector/geolocation-error.html: Removed.
- inspector/geolocation-success-expected.txt: Removed.
- inspector/geolocation-success.html: Removed.
- inspector/geolocation-watchPosition-expected.txt: Removed.
- inspector/geolocation-watchPosition.html: Removed.
- 8:27 AM WebKitGTK/2.2.x edited by
- (diff)
- 8:08 AM Changeset in webkit [161555] by
-
- 4 edits in trunk
[SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=126686
Reviewed by Martin Robinson.
Source/WebKit2:
We are currently writing the downloads directly into the
destination, and when a download fails or is cancelled after the
destination has been decided, the partial file is left on the
disk. Deleting the final file is not safe because there might be a
race condition, so we can use an intermediate file like other
browsers do, a file in the same directory than the target
destination but with .wkdownload suffix, that is removed when the
download fails or is cancelled. If the download finishes
successfully the intermediate file is renamed to the final
destination.
- Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::deleteIntermediateFileInNeeded): Delete
the intermdiate file if it's been created already.
(WebKit::DownloadClient::downloadFailed): Call deleteIntermediateFileInNeeded.
(WebKit::DownloadClient::didReceiveResponse): Do not create a
SoupMessage for the given ResourceResponse that is not used, cache
the ResourceResponse instead. Create the intermediate file and use
it instead of the final destination.
(WebKit::DownloadClient::didReceiveData): Use the cached
ResourceResponse directly.
(WebKit::DownloadClient::didFinishLoading): Rename the
intermediate file to the final destination and write the metadata
in the final target destination.
(WebKit::DownloadClient::cancel): Handle the download cancellation
here, removing the intermediate file is needed and cancelling the
ResourceHandle and the download.
(WebKit::DownloadClient::handleResponseLater):
(WebKit::Download::cancel): Let the client handle the cancellation.
Tools:
Test that partial files are not left on disk after a download has
been cancelled after the destination has been decided. To make
sure the download is cancelled after the destination has been
decided and before the operation finishes, we cancel the download
in the destination decided callback, and we use an infinite
resource that writes chunks to the response body and never
completes the body.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
(addContentDispositionHTTPHeaderToResponse): Helper function to
add the Content-Disposition to the response headers.
(writeNextChunkIdle): Write next chunk to response body.
(writeNextChunk): Write next chunk in an idle to avoid flooding
the network with the inifnite resource.
(serverCallback): Add an inifinite resource.
(testDownloadRemoteFileError): Check that partial file is not
present after the download has been cancelled.
- 7:50 AM Changeset in webkit [161554] by
-
- 2 edits in trunk/Source/JavaScriptCore
Shrink WatchpointSet.
<https://webkit.org/b/126694>
Reorder the members of WatchpointSet, shrinking it by 8 bytes.
767 kB progression on Membuster3.
Reviewed by Antti Koivisto.
- bytecode/Watchpoint.h:
- 4:06 AM Changeset in webkit [161553] by
-
- 8 edits in trunk/Source/WebCore
[CSSRegions] Move regions auto-size code into RenderNamedFlowFragment
https://bugs.webkit.org/show_bug.cgi?id=122959
Reviewed by Mihnea Ovidenie.
Move the auto-height logic from RenderRegion to RenderNamedFlowFragment because it's
used only by the CSS Regions implementation.
Bug 126642 covers the auto-height logic move from RenderFlowThread to RenderNamedFlowThread.
Tests: No new tests, just refactorings.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::styleDidChange):
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::isAutoLogicalHeightRegionsCountConsistent):
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight):
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):
- rendering/RenderMultiColumnSet.h:
- rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::RenderNamedFlowFragment):
(WebCore::RenderNamedFlowFragment::styleDidChange):
(WebCore::RenderNamedFlowFragment::incrementAutoLogicalHeightCount):
(WebCore::RenderNamedFlowFragment::decrementAutoLogicalHeightCount):
(WebCore::RenderNamedFlowFragment::updateRegionHasAutoLogicalHeightFlag):
(WebCore::RenderNamedFlowFragment::updateLogicalHeight):
(WebCore::RenderNamedFlowFragment::pageLogicalHeight):
(WebCore::RenderNamedFlowFragment::layoutBlock):
(WebCore::RenderNamedFlowFragment::attachRegion):
(WebCore::RenderNamedFlowFragment::detachRegion):
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
(WebCore::RenderRegion::isLastRegion):
(WebCore::RenderRegion::styleDidChange):
(WebCore::RenderRegion::attachRegion):
(WebCore::RenderRegion::detachRegion):
- rendering/RenderRegion.h:
- rendering/RenderRegionSet.h:
- rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderRegionList):
- 2:32 AM Changeset in webkit [161552] by
-
- 2 edits in trunk/Tools
Move myself to the committers list.
Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 2:20 AM Changeset in webkit [161551] by
-
- 3 edits in trunk/Source/WebCore
Switch HTMLTableRowsCollection from Traversal<> to iterators
https://bugs.webkit.org/show_bug.cgi?id=126684
Reviewed by Andreas Kling.
This is the last remaining client of Traversal<> outside the iterator implementation.
- dom/ElementChildIterator.h:
(WebCore::ElementChildIteratorAdapter<ElementType>::find):
(WebCore::ElementChildConstIteratorAdapter<ElementType>::find):
Add find with the same semantics as ElementDescendantIterator::find.
- html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::rowAfter):
(WebCore::HTMLTableRowsCollection::lastRow):
- 12:44 AM Changeset in webkit [161550] by
-
- 13 edits3 adds in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r161521.
- platform/gtk/css1/text_properties/letter_spacing-expected.png:
- platform/gtk/css1/text_properties/letter_spacing-expected.txt:
- platform/gtk/css1/text_properties/word_spacing-expected.png:
- platform/gtk/css1/text_properties/word_spacing-expected.txt:
- platform/gtk/css2.1/t1604-c542-letter-sp-00-b-a-expected.txt:
- platform/gtk/fast/text/basic/013-expected.png:
- platform/gtk/fast/text/basic/013-expected.txt:
- platform/gtk/fast/text/text-letter-spacing-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/text-spacing-01-b-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Added.
- platform/gtk/svg/batik/text/textLayout-expected.txt: Added.
- platform/gtk/svg/custom/text-letter-spacing-expected.png:
- platform/gtk/svg/custom/text-letter-spacing-expected.txt:
- platform/gtk/svg/text/text-spacing-01-b-expected.png:
- platform/gtk/svg/text/text-spacing-01-b-expected.txt: Added.
- 12:05 AM Changeset in webkit [161549] by
-
- 4 edits in trunk
REGRESSION(r161176): http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html is failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=126518
Reviewed by Martin Robinson.
Source/WebCore:
Clear the credentials before calling willSendRequest on the client
to avoid sending the credentials to the API layer, but apply them
again to the request right before creating the new SoupRequest.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::continueAfterWillSendRequest):
(WebCore::doRedirect):
LayoutTests:
Unskip
http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html
and http/tests/security/redirect-BLOCKED-to-localURL.html.
- platform/gtk/TestExpectations:
Jan 8, 2014:
- 11:14 PM Changeset in webkit [161548] by
-
- 3 edits in trunk/Source/WebKit2
WebKit2 EFL build fix after r161530
https://bugs.webkit.org/show_bug.cgi?id=126678
Reviewed by Tim Horton.
Add PLATFORM(MAC) guards around setExposedRect() and exposedRect()
in DrawingArea and WebFrameLoaderClient.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
- WebProcess/WebPage/DrawingArea.h:
- 10:25 PM Changeset in webkit [161547] by
-
- 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog
Indicate that r161225 and r161125 were reviewed by Michael Saboff.
- 10:15 PM Changeset in webkit [161546] by
-
- 4 edits in branches/jsCStack/Source/JavaScriptCore
FTL should be able to be parallel
https://bugs.webkit.org/show_bug.cgi?id=126679
Not yet reviewed.
Fix some bugs that got in the way of saying JSC_numberOfCompilerThreads=7 or some
such.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::livenessAnalysis): This wasn't thread-safe. Now it is.
- dfg/DFGWorklist.cpp:
(JSC::DFG::initializeGlobalWorklistOnce): FTL is now parallelizable.
- llvm/library/LLVMExports.cpp:
(initializeAndGetJSCLLVMAPI): Make LLVM parallelizable.
- 9:41 PM Changeset in webkit [161545] by
-
- 2 edits in trunk/Tools
[GTK] Unreviewed build fix after r161522.
- TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
- 8:25 PM Changeset in webkit [161544] by
-
- 2 edits in trunk/Source/JavaScriptCore
Reverting accidental GC logging
- heap/Heap.cpp:
- 8:11 PM Changeset in webkit [161543] by
-
- 7 edits9 adds in branches/jsCStack/Source/JavaScriptCore
FTL should not use the inputs of an add or sub as the live-at-exit values in an overflow check, if the values aren't live after
https://bugs.webkit.org/show_bug.cgi?id=126545
Not yet reviewed.
Introduces the notion of an ExitValue that is computed by doing some math on two
exit arguments. This gets used by LowerDFGToLLVM by tracking the
AvailableRecoveries - i.e. the set of ways we know how to recover the value of a
node by performing math on LValue's - and then trying to pick an AvailableRecovery
if we try to exit with an Availability pointing to a Node that isn't a constant.
The compileArithAddOrSub() code adds AvailableRecoveries for the ways you could
recovery the left or right operand by using the result.
Doing this uncovered a bug in stackmap constant parsing where we were casting a
32-bit value to 16-bit, thereby losing the top bits.
- JavaScriptCore.xcodeproj/project.pbxproj:
- ftl/FTLAvailableRecovery.cpp: Added.
(JSC::FTL::AvailableRecovery::dump):
- ftl/FTLAvailableRecovery.h: Added.
(JSC::FTL::AvailableRecovery::AvailableRecovery):
(JSC::FTL::AvailableRecovery::node):
(JSC::FTL::AvailableRecovery::format):
(JSC::FTL::AvailableRecovery::opcode):
(JSC::FTL::AvailableRecovery::left):
(JSC::FTL::AvailableRecovery::right):
- ftl/FTLExitValue.cpp:
(JSC::FTL::ExitValue::dumpInContext):
- ftl/FTLExitValue.h:
(JSC::FTL::ExitValue::recovery):
(JSC::FTL::ExitValue::isRecovery):
(JSC::FTL::ExitValue::leftRecoveryArgument):
(JSC::FTL::ExitValue::rightRecoveryArgument):
(JSC::FTL::ExitValue::recoveryFormat):
(JSC::FTL::ExitValue::recoveryOpcode):
(JSC::FTL::ExitValue::valueFormat):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithAddOrSub):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::doesKill):
(JSC::FTL::LowerDFGToLLVM::addAvailableRecovery):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- ftl/FTLRecoveryOpcode.cpp: Added.
(WTF::printInternal):
- ftl/FTLRecoveryOpcode.h: Added.
- ftl/FTLStackMaps.h:
- tests/stress/add-constant-overflow-recovery.js: Added.
(foo):
- tests/stress/add-int52-constant-overflow-recovery.js: Added.
(foo):
- tests/stress/add-int52-large-constant-overflow-recovery.js: Added.
(foo):
- tests/stress/add-overflow-recovery.js: Added.
(foo):
- tests/stress/add-small-constant-overflow-recovery.js: Added.
(foo):
- 8:01 PM Changeset in webkit [161542] by
-
- 5 edits7 adds in trunk/Source/WebKit2
Stub for Session API
https://bugs.webkit.org/show_bug.cgi?id=126626
Patch by Martin Hock <mhock@apple.com> on 2014-01-08
Reviewed by Sam Weinig.
- Shared/API/c/WKBase.h:
- Shared/API/c/WKSharedAPICast.h:
- Shared/APIObject.h:
- UIProcess/API/C/WKSessionRef.cpp: Added.
(WKSessionGetTypeID):
(WKSessionGetEphemeral):
- UIProcess/API/C/WKSessionRef.h: Added.
- UIProcess/API/Cocoa/WKSession.h: Added.
- UIProcess/API/Cocoa/WKSession.mm: Added.
(-[WKSession dealloc]):
(-[WKSession ephemeral]):
(-[WKSession API::]):
- UIProcess/API/Cocoa/WKSessionInternal.h: Added.
(WebKit::wrapper):
- UIProcess/APISession.cpp: Added.
(API::Session::Session):
(API::Session::create):
(API::Session::isEphemeral):
(API::Session::~Session):
- UIProcess/APISession.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 7:56 PM Changeset in webkit [161541] by
-
- 9 edits10 deletes in trunk
Unreviewed, rolling out r161532.
http://trac.webkit.org/changeset/161532
https://bugs.webkit.org/show_bug.cgi?id=126677
Caused lots of assertion failures (Requested by ap on
#webkit).
Source/WebCore:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::callReadyStateChangeListener):
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::abort):
(WebCore::XMLHttpRequest::networkError):
(WebCore::XMLHttpRequest::abortError):
(WebCore::XMLHttpRequest::didSendData):
(WebCore::XMLHttpRequest::didReceiveData):
(WebCore::XMLHttpRequest::didTimeout):
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchEventAndLoadEnd):
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::fired):
(WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch):
(WebCore::XMLHttpRequestProgressEventThrottle::suspend):
- xml/XMLHttpRequestProgressEventThrottle.h:
- xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
(WebCore::XMLHttpRequestUpload::dispatchEventAndLoadEnd):
- xml/XMLHttpRequestUpload.h:
LayoutTests:
- fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
- http/tests/xmlhttprequest/loadstart-event-init-expected.txt: Removed.
- http/tests/xmlhttprequest/loadstart-event-init.html: Removed.
- http/tests/xmlhttprequest/onabort-progressevent-attributes-expected.txt: Removed.
- http/tests/xmlhttprequest/onabort-progressevent-attributes.html: Removed.
- http/tests/xmlhttprequest/onload-progressevent-attributes-expected.txt: Removed.
- http/tests/xmlhttprequest/onload-progressevent-attributes.html: Removed.
- http/tests/xmlhttprequest/upload-onabort-progressevent-attributes-expected.txt: Removed.
- http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html: Removed.
- http/tests/xmlhttprequest/upload-onload-progressevent-attributes-expected.txt: Removed.
- http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html: Removed.
- 7:49 PM Changeset in webkit [161540] by
-
- 31 edits in trunk/Source
Marking should be generational
https://bugs.webkit.org/show_bug.cgi?id=126552
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Re-marking the same objects over and over is a waste of effort. This patch implements
the sticky mark bit algorithm (along with our already-present write barriers) to reduce
overhead during garbage collection caused by rescanning objects.
There are now two collection modes, EdenCollection and FullCollection. EdenCollections
only visit new objects or objects that were added to the remembered set by a write barrier.
FullCollections are normal collections that visit all objects regardless of their
generation.
In this patch EdenCollections do not do anything in CopiedSpace. This will be fixed in
https://bugs.webkit.org/show_bug.cgi?id=126555.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
- bytecode/CodeBlock.h:
(JSC::CodeBlockSet::mark):
- dfg/DFGOperations.cpp:
- heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::add):
(JSC::CodeBlockSet::traceMarked):
(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
- heap/CodeBlockSet.h:
- heap/CopiedBlockInlines.h:
(JSC::CopiedBlock::reportLiveBytes):
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::didStartFullCollection):
- heap/CopiedSpace.h:
(JSC::CopiedSpace::heap):
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::didAbandon):
(JSC::Heap::markRoots):
(JSC::Heap::copyBackingStores):
(JSC::Heap::addToRememberedSet):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):
(JSC::Heap::didAllocate):
(JSC::Heap::writeBarrier):
- heap/Heap.h:
(JSC::Heap::isInRememberedSet):
(JSC::Heap::operationInProgress):
(JSC::Heap::shouldCollect):
(JSC::Heap::isCollecting):
(JSC::Heap::isWriteBarrierEnabled):
(JSC::Heap::writeBarrier):
- heap/HeapOperation.h:
- heap/MarkStack.cpp:
(JSC::MarkStackArray::~MarkStackArray):
(JSC::MarkStackArray::clear):
(JSC::MarkStackArray::fillVector):
- heap/MarkStack.h:
- heap/MarkedAllocator.cpp:
(JSC::isListPagedOut):
(JSC::MarkedAllocator::isPagedOut):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):
(JSC::MarkedAllocator::reset):
- heap/MarkedAllocator.h:
(JSC::MarkedAllocator::MarkedAllocator):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::clearMarks):
(JSC::MarkedBlock::clearRememberedSet):
(JSC::MarkedBlock::clearMarksWithCollectionType):
(JSC::MarkedBlock::lastChanceToFinalize):
- heap/MarkedBlock.h: Changed atomSize to 16 bytes because we have no objects smaller
than 16 bytes. This is also to pay for the additional Bitmap for the remembered set.
(JSC::MarkedBlock::didConsumeEmptyFreeList):
(JSC::MarkedBlock::setRemembered):
(JSC::MarkedBlock::clearRemembered):
(JSC::MarkedBlock::atomicClearRemembered):
(JSC::MarkedBlock::isRemembered):
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::~MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::visitWeakSets):
(JSC::MarkedSpace::reapWeakSets):
(JSC::VerifyMarked::operator()):
(JSC::MarkedSpace::clearMarks):
- heap/MarkedSpace.h:
(JSC::ClearMarks::operator()):
(JSC::ClearRememberedSet::operator()):
(JSC::MarkedSpace::didAllocateInBlock):
(JSC::MarkedSpace::clearRememberedSet):
- heap/SlotVisitor.cpp:
(JSC::SlotVisitor::~SlotVisitor):
(JSC::SlotVisitor::clearMarkStack):
- heap/SlotVisitor.h:
(JSC::SlotVisitor::markStack):
(JSC::SlotVisitor::sharedData):
- heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::internalAppend):
(JSC::SlotVisitor::unconditionallyAppend):
(JSC::SlotVisitor::copyLater):
(JSC::SlotVisitor::reportExtraMemoryUsage):
(JSC::SlotVisitor::heap):
- jit/Repatch.cpp:
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):
- runtime/JSPropertyNameIterator.h:
(JSC::StructureRareData::setEnumerationCache):
- runtime/JSString.cpp:
(JSC::JSString::visitChildren):
- runtime/StructureRareDataInlines.h:
(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::setObjectToStringValue):
- runtime/WeakMapData.cpp:
(JSC::WeakMapData::visitChildren):
Source/WTF:
- wtf/Bitmap.h:
(WTF::WordType>::count): Added a cast that became necessary when Bitmap
is used with smaller types than int32_t.
- 7:47 PM Changeset in webkit [161539] by
-
- 10 edits5 adds in trunk/LayoutTests
Unreviewed EFL gardening. Rebaseline after r161521.
- platform/efl/css1/text_properties/letter_spacing-expected.png:
- platform/efl/css1/text_properties/letter_spacing-expected.txt:
- platform/efl/css1/text_properties/word_spacing-expected.png:
- platform/efl/css1/text_properties/word_spacing-expected.txt:
- platform/efl/fast/text/basic/013-expected.png:
- platform/efl/fast/text/basic/013-expected.txt:
- platform/efl/fast/text/text-letter-spacing-expected.txt:
- platform/efl/svg/W3C-SVG-1.1/text-spacing-01-b-expected.png:
- platform/efl/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Added.
- platform/efl/svg/batik/text/textLayout-expected.txt: Added.
- platform/efl/svg/custom/text-letter-spacing-expected.png: Added.
- platform/efl/svg/custom/text-letter-spacing-expected.txt: Added.
- platform/efl/svg/text/text-spacing-01-b-expected.png:
- platform/efl/svg/text/text-spacing-01-b-expected.txt: Added.
- 6:37 PM Changeset in webkit [161538] by
-
- 5 edits in trunk
[JS] Should be able to create a promise by calling the Promise constructor as a function
https://bugs.webkit.org/show_bug.cgi?id=126561
Patch by Sam Weinig <sam@webkit.org> on 2014-01-08
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- runtime/JSPromiseConstructor.cpp:
(JSC::JSPromiseConstructor::getCallData):
Add support for calling the Promise constructor as a function (e.g. var p = Promise(...), note
the missing "new").
LayoutTests:
- js/dom/Promise-types-expected.txt:
- js/dom/Promise-types.html:
Add test for using calling a Promise constructor as a function.
- 6:21 PM Changeset in webkit [161537] by
-
- 3 edits in trunk/Source/WebCore
Clean up confusing names and calculations in image-dragging functions
https://bugs.webkit.org/show_bug.cgi?id=126661
Reviewed by Timothy Hatcher.
No new tests.
- page/DragController.cpp:
(WebCore::DragController::doImageDrag): rename variables and
simplify the calculation of the image's scaled origin.
- platform/DragImage.cpp:
(WebCore::fitDragImageToMaxSize): rename variables.
- 6:14 PM Changeset in webkit [161536] by
-
- 4 edits in trunk/Source
[GTK] Add xdg.origin.url extended attribute to downloads
https://bugs.webkit.org/show_bug.cgi?id=126638
Reviewed by Carlos Garcia Campos.
This is proposed by fdo in
http://www.freedesktop.org/wiki/CommonExtendedAttributes/
Source/WebKit/gtk:
- webkit/webkitdownload.cpp:
(webkit_download_open_stream_for_uri):
Source/WebKit2:
- Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::didReceiveResponse):
- 6:13 PM Changeset in webkit [161535] by
-
- 3 edits in trunk/Tools
Missleading style error when mixing system and non-system header include lines.
https://bugs.webkit.org/show_bug.cgi?id=126564
Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2014-01-08
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_include_line):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(OrderOfIncludesTest.test_check_alphabetical_include_order):
(OrderOfIncludesTest.test_public_primary_header):
- 6:12 PM Changeset in webkit [161534] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Remove InspectorClient::captureScreenshot()
https://bugs.webkit.org/show_bug.cgi?id=126616
Reviewed by Joseph Pecoraro.
No new tests, No change in behavior.
Remove leftover mothod as Page.captureScreenshot API was removed in r160202.
- inspector/InspectorClient.h:
- 6:12 PM Changeset in webkit [161533] by
-
- 5 edits in trunk/Source/WebKit2
Make WK2 build when ENABLE(ASYNC_SCROLLING) is not defined
https://bugs.webkit.org/show_bug.cgi?id=126675
Reviewed by Tim Horton.
We need a stub RemoteScrollingCoordinatorTransaction outside
the #ifdef so that RemoteLayerTreeDrawingAreaProxy messages
work.
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::RemoteScrollingCoordinatorTransaction::encode):
(WebKit::RemoteScrollingCoordinatorTransaction::decode):
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
- 6:11 PM Changeset in webkit [161532] by
-
- 9 edits10 adds in trunk
Source/WebCore: Correctly set XHR loadend attributes (loaded and total).
https://bugs.webkit.org/show_bug.cgi?id=120828
Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-08
Reviewed by Alexey Proskuryakov.
Added correct initialization of lengthComputable, loaded and total attributes
to XHR ProgressEvent events (load, loadstart, loadend, abort, error and timeout).
XMLHttpRequestProgressEventThrottle and XMLHttpRequestUpload now keep persistent knowledge
of m_loaded and m_total values with this patch.
Code refactoring to handle event dispatching in case of error in a single manner.
XMLHttpRequestProgressEventThrottle::dispatchProgressEvent is renamed as dispatchThrottledProgressEvent
XMLHttpRequestProgressEventThrottle::dispatchEventAndLoadend is replaced by dispatchProgressEvent(const AtomicString&)
Tests: http/tests/xmlhttprequest/loadstart-event-init.html
http/tests/xmlhttprequest/onabort-progressevent-attributes.html
http/tests/xmlhttprequest/onload-progressevent-attributes.html
http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html
http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::callReadyStateChangeListener): changed readystatechange event from ProgressEvent to Event (not cancellable, not bubblable) to better match the spec
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::abort): code refactoring to handle error event dispatching in a single way
(WebCore::XMLHttpRequest::networkError): code refactoring to handle error event dispatching in a single way
(WebCore::XMLHttpRequest::abortError): code refactoring to handle error event dispatching in a single way
(WebCore::XMLHttpRequest::didSendData):
(WebCore::XMLHttpRequest::didReceiveData):
(WebCore::XMLHttpRequest::dispatchErrorEvents): dispatch progress events in case of error
(WebCore::XMLHttpRequest::didTimeout): code refactoring to handle error event dispatching in a single way
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestProgressEventThrottle.cpp: before the patch, the fact that a progress event is being throttled is stored indirectly (m_loaded or m_total not equal to zero). With the patch, this information is stored in m_hasThrottledProgressEvent. The m_loaded and m_total values are no longer set back to zero after a progress event is dispatched. This allows using these values to correctly initialize other ProgressEvent events (in particular loadend, abort, timeout...)
(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchThrottledProgressEvent): always update the new m_loaded and m_total values. If progress event is not sent as part of the function call, store the fact that a progress event is being throttled through m_hasThrottledProgressEvent.
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): used to send any ProgressEvent event that is not be throttled
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent): after the call, no progress event is throttled anymore
(WebCore::XMLHttpRequestProgressEventThrottle::fired): after the call, no progress event is throttled anymore
(WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch):
(WebCore::XMLHttpRequestProgressEventThrottle::suspend):
- xml/XMLHttpRequestProgressEventThrottle.h: introduced m_hasThrottledProgressEvent which stores whether a progress event is being throttled and m_computableLength which is used to initialize ProgressEvent computableLength
- xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
(WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
- xml/XMLHttpRequestUpload.h: introduced m_loaded, m_total and m_lengthComputable, similarly to XMLHttpRequestProgressEventThrottle
LayoutTests: Correctly set XHR loadend event attributes (loaded and total).
https://bugs.webkit.org/show_bug.cgi?id=120828
Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-08
Reviewed by Alexey Proskuryakov.
Tests for abort, load, loadstart and loadend ProgressEvent events for XMLHttpRequest and XMLHttpRequestUpload
- fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Changed to correct event values
- http/tests/xmlhttprequest/loadstart-event-init-expected.txt: Added.
- http/tests/xmlhttprequest/loadstart-event-init.html: Added.
- http/tests/xmlhttprequest/onabort-progressevent-attributes-expected.txt: Added.
- http/tests/xmlhttprequest/onabort-progressevent-attributes.html: Added.
- http/tests/xmlhttprequest/onload-progressevent-attributes-expected.txt: Added.
- http/tests/xmlhttprequest/onload-progressevent-attributes.html: Added.
- http/tests/xmlhttprequest/upload-onabort-progressevent-attributes-expected.txt: Added.
- http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html: Added.
- http/tests/xmlhttprequest/upload-onload-progressevent-attributes-expected.txt: Added.
- http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html: Added.
- 5:55 PM Changeset in webkit [161531] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack: stack frame gets unaligned before call to operationVMHandleException
https://bugs.webkit.org/show_bug.cgi?id=126673
Reviewed by Mark Lam.
Moves the epilogue to after the check for an exception. Modified the call to
operationVMHandleException() to take the caller's frame since the callee frame hasn't
been popped off yet.
- jit/ThunkGenerators.cpp:
(JSC::nativeForGenerator):
- 5:38 PM Changeset in webkit [161530] by
-
- 24 edits in trunk/Source
TileController can fail to receive exposedRect from the drawing area if set at the wrong time
https://bugs.webkit.org/show_bug.cgi?id=126536
Reviewed by Simon Fraser.
- Configurations/WebKit2.xcconfig:
- UIProcess/API/mac/WKView.mm:
(-[WKView _updateViewExposedRect]):
- UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::setExposedRect):
(WebKit::DrawingAreaProxy::exposedRectChangedTimerFired):
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::exposedRect):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
- UIProcess/WebPageProxy.h:
Move exposedRect stuff from WebPageProxy to DrawingAreaProxy.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Push the exposedRect down into WebCore.
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::updateScrolledExposedRect):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
Get rid of "clipsToExposedRect", we just use infinite-ness of the rect
to indicate that now.
Don't scroll an infinite rect; it won't work.
- WebCore.exp.in:
Export some things.
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::setExposedRect):
Store the exposed rect on FrameView. When it changes, if the main frame
has a TiledBacking, inform it of the change.
- page/FrameView.h:
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/mac/TileController.h:
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
(WebCore::TileController::tilesWouldChangeForVisibleRect):
(WebCore::TileController::computeTileCoverageRect):
(WebCore::TileController::revalidateTiles):
(WebCore::TileController::updateTileCoverageMap):
Make use of the fact that we can test if a rect is infinite
instead of having a separate boolean property for that.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::computeTileCoverage):
Push the FrameView's cached exposed rect down into the TiledBacking when it is created.
We only support clipping for the main frame TileController for now.
- 5:25 PM Changeset in webkit [161529] by
-
- 10 edits in trunk/Source/WebKit2
Add ENABLE(ASYNC_SCROLLING) guards around WK2 scrolling files
https://bugs.webkit.org/show_bug.cgi?id=126672
Reviewed by Tim Horton.
Protected WK2 scrolling files with ENABLE(ASYNC_SCROLLING) guards.
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.h:
- UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
- UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h:
- UIProcess/Scrolling/RemoteScrollingTree.cpp:
- UIProcess/Scrolling/RemoteScrollingTree.h:
- WebProcess/Scrolling/RemoteScrollingCoordinator.h:
- WebProcess/Scrolling/RemoteScrollingCoordinator.messages.in:
- WebProcess/Scrolling/RemoteScrollingCoordinator.mm:
- 5:19 PM Changeset in webkit [161528] by
-
- 2 edits in trunk
[GTK] [CMake] Specify the executable and library output locations in the build
https://bugs.webkit.org/show_bug.cgi?id=126671
Reviewed by Gustavo Noronha Silva.
- Source/cmake/OptionsGTK.cmake: Explicitly specify the output locations.
- 5:07 PM Changeset in webkit [161527] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] Add API to execute js script
https://bugs.webkit.org/show_bug.cgi?id=101904
Reviewed by Gyuyoung Kim.
Add ewk_view_script_execute() which provides a way to execute user
script.
- UIProcess/API/efl/ewk_context.cpp:
Added JS Global Contexta which is required to deserialize to the script
value from the callback.
(EwkContext::EwkContext):
(EwkContext::~EwkContext):
(EwkContext::jsGlobalContext):
- UIProcess/API/efl/ewk_context_private.h:
- UIProcess/API/efl/ewk_view.cpp:
(Ewk_View_Script_Execute_Callback_Context::Ewk_View_Script_Execute_Callback_Context):
(runJavaScriptCallback):
(ewk_view_script_execute):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
Added unit test for ewk_view_script_execute.
(scriptExecuteCallback):
(TEST_F):
- 4:59 PM Changeset in webkit [161526] by
-
- 6 edits1 delete in trunk/Source/WebKit
[EFL] Merge ewk_view_single into ewk_view
https://bugs.webkit.org/show_bug.cgi?id=126508
Reviewed by Gyuyoung Kim.
Source/WebKit:
- PlatformEfl.cmake: Removed ewk_view_single.cpp.
Source/WebKit/efl:
Since ewk_view_tiled is removed at r161134, we don't need to keep
ewk_view_single out of ewk_view.cpp.
This patch moves the logic of ewk_view_single to ewk_view and refactors it.
In addition, replaces 0.00001 to episilon.
- ewk/ewk_view.cpp:
(_ewk_view_smart_add):
(_ewk_view_smart_resize): Merged with the logic of ewk_view_single.
(_ewk_view_screen_move): Moved from ewk_view_single.cpp.
(_ewk_view_scroll_process): Ditto.
(_ewk_view_smart_scrolls_process): Ditto.
(_ewk_view_smart_repaints_process): Ditto.
(_ewk_view_smart_calculate): Removed unnecessary check routine for scrolls_process.
(_ewk_view_smart_zoom_weak_set):
(_ewk_view_smart_zoom_weak_smooth_scale_set):
(ewk_view_base_smart_set): Merged smart method of ewk_view_single.
(ewk_view_single_smart_set):
(_ewk_view_single_smart_class_new):
(ewk_view_single_add):
(ewk_view_bg_color_set):
(ewk_view_pre_render_region):
(ewk_view_scrolls_process):
- ewk/ewk_view.h:
- ewk/ewk_view_private.h: Removed unncessary functions.
- ewk/ewk_view_single.cpp: Removed.
- 4:35 PM Changeset in webkit [161525] by
-
- 4 edits in trunk/Source
[EFL] Move efl API test binaries to TestWebKitAPI/EWebKit|EWebKit2
https://bugs.webkit.org/show_bug.cgi?id=126615
Reviewed by Martin Robinson.
Now EFL API test binaries created in *bin* directory with other executables.
It would be good to move them to their folder. This patch moves them to
*TestWebKitAPI/EWebKit|EWebKit2* directories.
Source/WebKit:
- PlatformEfl.cmake:
Source/WebKit2:
- PlatformEfl.cmake:
- 3:37 PM Changeset in webkit [161524] by
-
- 3 edits in trunk/Tools
[EFL] Unreviewed build fix after r161522.
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/PlatformEfl.cmake:
- 2:52 PM Changeset in webkit [161523] by
-
- 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog
Indicate that r161515 has been reviewed by Geoff.
- 2:44 PM Changeset in webkit [161522] by
-
- 2 edits2 deletes in trunk/Tools
Remove WKConnectionRef tests
https://bugs.webkit.org/show_bug.cgi?id=126666
Reviewed by Dan Bernstein.
The WKConnectionRef is poorly designed but thankfully not used anywhere.
Remove the API tests as a first step towards killing the entire thing.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
- 2:22 PM Changeset in webkit [161521] by
-
- 22 edits in trunk
a fractional value of the css letter-spacing property is not rendered as expected
https://bugs.webkit.org/show_bug.cgi?id=20606
Reviewed by Simon Fraser.
Source/WebCore:
This turns on fractional letter-spacing and word-spacing CSS values.
It is taken mostly from Blink r153727 and iOS. Updating the relevant
types is all that is necessary
Existing tests have been updated.
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- platform/graphics/Font.cpp:
(WebCore::Font::Font):
(WebCore::Font::width):
- platform/graphics/Font.h:
(WebCore::Font::wordSpacing):
(WebCore::Font::letterSpacing):
(WebCore::Font::setWordSpacing):
(WebCore::Font::setLetterSpacing):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::wordSpacing):
(WebCore::RenderStyle::letterSpacing):
(WebCore::RenderStyle::setWordSpacing):
(WebCore::RenderStyle::setLetterSpacing):
- rendering/style/RenderStyle.h:
LayoutTests:
Manually verified that these tests are correct after enabling fractional letter-spacing and word spacing
- platform/mac/css1/text_properties/letter_spacing-expected.png:
- platform/mac/css1/text_properties/letter_spacing-expected.txt:
- platform/mac/css1/text_properties/word_spacing-expected.png:
- platform/mac/css1/text_properties/word_spacing-expected.txt:
- platform/mac/fast/text/basic/013-expected.png:
- platform/mac/fast/text/basic/013-expected.txt:
- platform/mac/fast/text/text-letter-spacing-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-spacing-01-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
- platform/mac/svg/batik/text/textLayout-expected.txt:
- platform/mac/svg/custom/text-letter-spacing-expected.png:
- platform/mac/svg/custom/text-letter-spacing-expected.txt:
- platform/mac/svg/text/text-spacing-01-b-expected.png:
- platform/mac/svg/text/text-spacing-01-b-expected.txt:
- 1:45 PM Changeset in webkit [161520] by
-
- 2 edits2 deletes in trunk/Tools
Unreviewed, rolling out r161512.
http://trac.webkit.org/changeset/161512
https://bugs.webkit.org/show_bug.cgi?id=126655
Broke webkitpy tests (Requested by ap on #webkit).
Patch by Commit Queue <commit-queue@webkit.org> on 2014-01-08
- Scripts/webkitpy/port/gtk.py:
(GtkPort.init):
(GtkPort.setup_test_run):
(GtkPort._port_specific_expectations_files):
- Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
- Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
- 1:38 PM Changeset in webkit [161519] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r161517.
http://trac.webkit.org/changeset/161517
https://bugs.webkit.org/show_bug.cgi?id=126659
The fix didn't completely remove the problem and is now
standing in the way of the rollout of the offending patch
(Requested by zdobersek on #webkit).
Patch by Commit Queue <commit-queue@webkit.org> on 2014-01-08
- Scripts/webkitpy/port/gtk.py:
(GtkPort.init):
- 1:19 PM Changeset in webkit [161518] by
-
- 19 edits1 add in trunk/Source
Add WTF::StringView and use it for grammar checking
https://bugs.webkit.org/show_bug.cgi?id=126644
Reviewed by Antti Koivisto.
Source/WebCore:
Use a StringView in TextCheckerClient::checkTextOfParagraph to avoid upconverting strings unnecessarily.
- editing/TextCheckingHelper.cpp:
(WebCore::checkTextOfParagraph):
Pass a StringView to TextCheckerClient::checkTextOfParagraph.
- loader/EmptyClients.h:
Update for TextCheckerClient changes.
- platform/text/TextCheckerClient.h:
Change TextCheckerClient::checkTextOfParagraph to take a StringView.
Source/WebKit/efl:
Update to match WebCore changes.
- WebCoreSupport/EditorClientEfl.h:
(WebCore::EditorClientEfl::checkTextOfParagraph):
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::checkTextOfParagraph):
Update to match the new signature.
(nsStringWithoutCopying):
New function that creates an NSString that references StringView data
without copying the data. (If this function proves to be useful elsewhere, it could
potentially be added to StringView).
Source/WebKit2:
Use a StringView and remove a FIXME.
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::checkTextOfParagraph):
- WebProcess/WebCoreSupport/WebEditorClient.h:
Source/WTF:
Add a new StringView class which is an immutable reference to either an 8-bit or a 16-bit string.
This makes it easier to pass substrings around without having to either copy string data
or upconvert and use UChar pointers.
The StringView class is very loosely based on the std::string_view class which is proposed for a future version of C++,
see http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3609.html for more details.
- GNUmakefile.list.am:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/Forward.h:
- wtf/text/StringView.h: Added.
(WTF::StringView::StringView):
(WTF::StringView::empty):
(WTF::StringView::characters8):
(WTF::StringView::characters16):
(WTF::StringView::isEmpty):
(WTF::StringView::length):
(WTF::StringView::is8Bit):
(WTF::StringView::substring):
(WTF::StringView::toString):
(WTF::StringView::toStringWithoutCopying):
(WTF::StringView::encodedCharacters):
- 1:03 PM Changeset in webkit [161517] by
-
- 2 edits in trunk/Tools
Unreviewed. Attempting to fix webkitpy tests after r161512.
- Scripts/webkitpy/port/gtk.py:
(GtkPort.init): Construct LeakDetectorValgrin only if leak detection is enabled.
- 12:44 PM Changeset in webkit [161516] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html
https://bugs.webkit.org/show_bug.cgi?id=52016
- platform/mac/TestExpectations: Mark it as such.
- 12:02 PM Changeset in webkit [161515] by
-
- 3 edits in branches/jsCStack/Source/JavaScriptCore
Make it possible to disable the disabling of AVX
https://bugs.webkit.org/show_bug.cgi?id=126652
Not yet reviewed.
Who knows, maybe some newer Intel chips will actually run AVX code properly.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
- runtime/Options.h:
- 11:30 AM Changeset in webkit [161514] by
-
- 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog
Indicate that r161487 has been reviewed by Geoff.
- 11:20 AM Changeset in webkit [161513] by
-
- 2 edits in trunk/Source/WebKit/win
[WinCairo] Compile error.
https://bugs.webkit.org/show_bug.cgi?id=126534
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-01-08
Reviewed by Brent Fulgham.
- WebKitPrefix.h: Define STDC_LIMIT_MACROS, so INTMAX_MAX will be defined (needed by std C++ library).
- 10:30 AM Changeset in webkit [161512] by
-
- 2 edits2 adds in trunk/Tools
[GTK] Parse Valgrind xml leak files
https://bugs.webkit.org/show_bug.cgi?id=119446
Reviewed by Alejandro G. Castro.
Parse the xml files generated by Valgrind to yield useful
information about the memory leaks.
- Scripts/webkitpy/port/gtk.py:
(GtkPort.init):
(GtkPort.setup_test_run): Clear the previous output files before new
run.
(GtkPort.print_leaks_summary):
- Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
Parse the xml files generated by Valgrind and summarise leaks
into an easily understandable list.
(get_text_of):
(get_CDATA_of):
(gather_frames):
(ValgrindError):
(ValgrindError.init):
(ValgrindError.str):
(ValgrindError.unique_string):
(ValgrindError.error_hash):
(ValgrindError.hash):
(ValgrindError.eq):
(LeakDetectorValgrind):
(LeakDetectorValgrind.init):
(LeakDetectorValgrind._parse_leaks_output):
(LeakDetectorValgrind.leaks_files_in_results_directory):
(LeakDetectorValgrind.clean_leaks_files_from_results_directory):
(LeakDetectorValgrind.parse_and_print_leaks_detail):
- Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
(make_mock_valgrind_output):
(make_mock_incomplete_valgrind_output):
(make_mock_valgrind_results):
(make_mock_valgrind_results_incomplete):
(make_mock_valgrind_results_empty):
(make_mock_valgrind_results_misformatted):
(LeakDetectorValgrindTest):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
- 10:29 AM Changeset in webkit [161511] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing
exports needed for Windows build.
- 9:48 AM Changeset in webkit [161510] by
-
- 3 edits in trunk/Tools
Unreviewed, rolling out r161427.
http://trac.webkit.org/changeset/161427
https://bugs.webkit.org/show_bug.cgi?id=126645
Emits a stye error on any newly added files (Requested by ap
on #webkit).
- Scripts/webkitpy/style/checkers/cpp.py:
(check_style):
(CppChecker):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_other):
- 9:14 AM Changeset in webkit [161509] by
-
- 3 edits1 delete in trunk/Tools
Remove run-webkit-tests wrapper script as all platform are using NRWT now.
https://bugs.webkit.org/show_bug.cgi?id=126580
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-08
Reviewed by Csaba Osztrogonác.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests): Passing --debug-rwt-logging here instead of the
run-webkit-tests script.
- Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
- Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
- 8:42 AM Changeset in webkit [161508] by
-
- 1 edit in tags/Safari-538.10.1/Source/WTF/ChangeLog
Merged r160453. <rdar://problem/15544065>
- 8:38 AM Changeset in webkit [161507] by
-
- 5 edits in tags/Safari-538.10.1/Source
Versioning.
- 8:17 AM Changeset in webkit [161506] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Windows build fix attempt after r161481.
- WebCore.vcxproj/copyForwardingHeaders.cmd:
- 8:17 AM Changeset in webkit [161505] by
-
- 1 copy in tags/Safari-538.10.1
New Tag.
- 8:15 AM Changeset in webkit [161504] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: ARM64 DFG produces the wrong answer for X % 0
https://bugs.webkit.org/show_bug.cgi?id=126612
Reviewed by Geoffrey Garen.
Added check for zero divisor. If shouldCheckOverflow() is true, the zero divisor
check is an overflow speculation check. If shouldCheckOverflow() is false, a
zero divisor causes us to set the result to 0.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithMod):
- 8:02 AM Changeset in webkit [161503] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
setFileInputFiles.html was removed after r161380. string-replacement-outofmemory.html,
toString-and-valueOf-override.html and exceptions-thrown-in-callbacks.html
were moved into other directory.
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- 7:45 AM Changeset in webkit [161502] by
-
- 2 edits in trunk/Tools
Update the list of non-committer u-szeged contributors
https://bugs.webkit.org/show_bug.cgi?id=126640
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-08
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/common/config/contributors.json:
- 7:43 AM Changeset in webkit [161501] by
-
- 2 edits in trunk/Source/WebCore
Deploy RenderPtr in RenderMathMLOperator::updateFromElement().
<https://webkit.org/b/126628>
Reviewed by Antti Koivisto.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateFromElement):
Use RenderPtr/createRenderer for renderer creation.
Removed an unnecessary null check (text is always created.)
Also use RenderStyle::createAnonymousStyleWithDisplay()
helper to shorten down the code a bit.
- 7:24 AM Changeset in webkit [161500] by
-
- 7 edits in trunk
Fix some compilation warnings
https://bugs.webkit.org/show_bug.cgi?id=126635
Reviewed by Csaba Osztrogonác.
Source/WebCore:
Remove code that is no longer being used.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- platform/gtk/PopupMenuGtk.cpp:
- platform/gtk/RedirectedXCompositeWindow.h:
Tools:
- GtkLauncher/main.c:
(createWindow): This function is not supposed to receive any
parameter, yet we are passing one.
- 7:23 AM Changeset in webkit [161499] by
-
- 2 edits in trunk/Tools
[GTK][WK2] unskip passing unit tests
https://bugs.webkit.org/show_bug.cgi?id=126637
Reviewed by Carlos Garcia Campos.
Unskip TestResources and TestAuthentication unit tests since they
are passing both under Xvfb and X.
- Scripts/run-gtk-tests:
(TestRunner):
- 7:21 AM Changeset in webkit [161498] by
-
- 6 edits1 copy1 add in trunk
[EFL] Make FTL buildable
https://bugs.webkit.org/show_bug.cgi?id=125777
Patch by Dániel Bátyai <Dániel Bátyai> on 2014-01-08
Reviewed by Csaba Osztrogonác.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- CMakeLists.txt:
- ftl/FTLOSREntry.cpp:
- ftl/FTLOSRExitCompiler.cpp:
- llvm/library/config_llvm.h:
- 7:13 AM Changeset in webkit [161497] by
-
- 7 edits in trunk/Source
[Automake] Scripts for generated build targets do not necessarily produce their output
https://bugs.webkit.org/show_bug.cgi?id=126378
Reviewed by Carlos Garcia Campos.
Source/JavaScriptCore:
- GNUmakefile.am: Touch the build targets that are generated through helper scripts that don't
assure the output is generated every time the script is invoked, most commonly due to unchanged
input. This assures the build targets are up-to-date and can't be older that their dependencies,
which would result in constant regeneration at every build.
Source/WebCore:
- GNUmakefile.am: Touch the build targets that are generated through helper scripts that don't
assure the output is generated every time the script is invoked, most commonly due to unchanged
- bindings/gobject/GNUmakefile.am: Simply move the gdom-gen-symbols file into the output file
instead of copying it if the contents differ and removing it. This again ensures that the output
file is always newer than its dependencies, even if the input hasn't changed.
Source/WebKit2:
- GNUmakefile.am: Don't pass the -n option to the ln command that links the build's include
directories to actual source directories. This doesn't replace the original symbolic link,
which can lead to the actual link being older than its dependencies and subsequent constant
relinking at every build.
- 6:35 AM Changeset in webkit [161496] by
-
- 4 edits in trunk
REGRESSION(r160304): [GTK] Disable libtool fast install
https://bugs.webkit.org/show_bug.cgi?id=126381
Reviewed by Gustavo Noronha Silva.
.:
Don't disable the libtool fast-install mode unconditionally by
default.
If the fast-install mode is disabled, binaries are generated ready
to use the libraries directly from the build tree. If we use the
GNU linker, those binaries are then relinked when they are
installed.
However, libtool fails to do it properly when an installation
prefix is set with DESTDIR, and ends up installing the libtool
wrappers instead of the actual binaries.
- Source/autotools/SetupLibtool.m4:
Tools:
Disable the libtool fast-install mode in developer/test builds.
In this mode binaries are generated ready to be used directly from
the build tree. Otherwise they would need to be relinked when they
are executed, which can take a lot of resources, particularly in
debug builds.
- Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary):
- 6:22 AM Changeset in webkit [161495] by
-
- 2 edits in trunk/Source/WebCore
Remove invalid comments from mathtags.ing
https://bugs.webkit.org/show_bug.cgi?id=126629
Patch by Frédéric Wang <fred.wang@free.fr> on 2014-01-08
Reviewed by Chris Fleizach.
- mathml/mathtags.in:
- 4:02 AM Changeset in webkit [161494] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
Updated Brazilian Portuguese translation of WebKitGTK+ - December 30, 2013
https://bugs.webkit.org/show_bug.cgi?id=126315
Patch by Enrico Nicoletto <liverig@gmail.com> on 2014-01-08
Reviewed by Gustavo Noronha.
- pt_BR.po: updated translation.
- 3:20 AM Changeset in webkit [161493] by
-
- 4 edits in trunk/Source/WebCore
RenderMathMLRow::createAnonymousWithParentRenderer() should return RenderPtr.
<https://webkit.org/b/126631>
Reviewed by Antti Koivisto.
- rendering/mathml/RenderMathMLRow.h:
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):
Tweak to return RenderPtr<RenderMathMLRow> and removed comment(!)
about how this should return a smart pointer. Also take the
parent renderer as a RenderMathMLRoot& instead of a RenderObject*
since that's all we ever pass.
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::addChild):
Updated for new createAnonymousWithParentRenderer() signature.
- 2:58 AM Changeset in webkit [161492] by
-
- 4 edits in trunk/Source/WebCore
AX: Make roleValue() return DescriptionListRole for <dl> elements
https://bugs.webkit.org/show_bug.cgi?id=126579
Reviewed by Chris Fleizach.
Implement AccessibilityList::roleValue() so it will return
ListRole or DescriptionListRole depending on the type of list.
No new tests needed, as no new functionality was added and ports
should still be exposing the right role for <dl> elements
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::roleValue): Implemented.
- accessibility/AccessibilityList.h:
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole): Removed extra checks for objects with ListRole role.
- 1:47 AM Changeset in webkit [161491] by
-
- 3 edits in trunk/Source/WebCore
createMathMLOperator() should return RenderPtr.
<https://webkit.org/b/126622>
Reviewed by Antti Koivisto.
- rendering/mathml/RenderMathMLFenced.h:
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::createMathMLOperator):
Make this return a RenderPtr<RenderMathMLOperator>.
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
Updated for the new createMathMLOperator() signature.
- 12:45 AM Changeset in webkit [161490] by
-
- 2 edits in trunk/Tools
Unreviewed GTK gardening.
- Scripts/run-gtk-tests:
(TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
- 12:33 AM Changeset in webkit [161489] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html is very flaky
https://bugs.webkit.org/show_bug.cgi?id=126624
- platform/mac/TestExpectations: Mark it as such.
- 12:26 AM Changeset in webkit [161488] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Add a flaky expectation for perf/accessibility-title-ui-element.html and a failure expectation
for http/tests/media/video-auth.html.
- platform/gtk/TestExpectations:
Jan 7, 2014:
- 11:59 PM Changeset in webkit [161487] by
-
- 3 edits in branches/jsCStack/Source/JavaScriptCore
Disable AVX in the FTL
https://bugs.webkit.org/show_bug.cgi?id=126620
Not yet reviewed.
- ftl/FTLAbbreviations.h:
(JSC::FTL::addTargetDependentFunctionAttr):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
- 11:50 PM Changeset in webkit [161486] by
-
- 5 edits in branches/safari-537.74-branch/Source
Versioning.
- 11:47 PM Changeset in webkit [161485] by
-
- 1 copy in tags/Safari-537.74.5
New tag.
- 11:33 PM Changeset in webkit [161484] by
-
- 5 edits in trunk
REGRESSION (r161195): Acid2 regression tests frequently fail
https://bugs.webkit.org/show_bug.cgi?id=126432
Source/WebCore:
Reviewed by Anders Carlsson.
We would occasionally dump the render tree before the actual last resource on the page was loaded.
The problematic resource is an image loaded by an <object> tag nested as fallback of another <object>.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderFallbackContent):
Force style recalc when rendering fallback content. The current mechanism for triggering the fallback content load
requires a style recalc.
LayoutTests:
Reviewed by Anders Carlsson.
- TestExpectations: acid2 is no longer flaky.
- fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: whitespace change.
- 11:02 PM Changeset in webkit [161483] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack: Call linking should log call linking for DFG and FTL code blocks if --showDFGDisassembly=true
https://bugs.webkit.org/show_bug.cgi?id=126617
Not yet reviewed.
- jit/Repatch.cpp:
(JSC::linkFor):
- 10:42 PM Changeset in webkit [161482] by
-
- 4 edits in trunk/Source/WebCore
createAnonymousMathMLBlock() should return RenderPtr.
<https://webkit.org/b/126583>
Reviewed by Antti Koivisto.
- rendering/mathml/RenderMathMLBlock.h:
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::createAnonymousMathMLBlock):
Make this return a RenderPtr<RenderMathMLBlock> and removed the
EDisplay argument since it was always using the default (FLEX.)
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::addChild):
Updated for the new createAnonymousMathMLBlock() signature.
- 9:45 PM Changeset in webkit [161481] by
-
- 22 edits2 copies6 adds in trunk
Teach MediaSessionManager to manage interruptions
https://bugs.webkit.org/show_bug.cgi?id=126530
Reviewed by Sam Weinig.
Source/WebCore:
Tests: media/video-interruption-active-when-element-created.html
media/video-interruption-with-resume-allowing-play.html
media/video-interruption-with-resume-not-allowing-play.html
- WebCore.exp.in: Export functions needed by Internals.
Add MediaSession and MediaSessionManager.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Automatically pause/play for interruptions. Move media restriction management to a MediaSession.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Get rid of m_loadInitiatedByUserGesture and m_userStartedPlayback,
they aren't needed.
(WebCore::HTMLMediaElement::load): Ditto.
(WebCore::HTMLMediaElement::loadInternal): Use the media session to manage restrictions.
(WebCore::HTMLMediaElement::play): Remove redundant iOS code. Postpone playback if called
during an interruption.
(WebCore::HTMLMediaElement::pause): Remember to not resume playback when it ends if called during
an interruption.
(WebCore::HTMLMediaElement::potentiallyPlaying): Rearrange code to make it easier to understand.
(WebCore::HTMLMediaElement::couldPlayIfEnoughData): Ditto.
(WebCore::HTMLMediaElement::pausedForUserInteraction): Return true if paused because of an interruption.
(WebCore::HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture): Be explicit about
which restrictions are removed.
(WebCore::HTMLMediaElement::mediaType): MediaSessionManager::<Type> -> MediaSession::<Type>.
(WebCore::HTMLMediaElement::beginInterruption): New.
(WebCore::HTMLMediaElement::endInterruption): Ditto.
- html/HTMLMediaElement.h:
Pulled MediaSessionManagerToken out of MediaSessionManager.cpp, added functionality to manage interruptions.
- platform/audio/MediaSession.cpp: Added.
(WebCore::MediaSession::create):
(WebCore::MediaSession::MediaSession):
(WebCore::MediaSession::~MediaSession):
(WebCore::MediaSession::beginInterruption): Inform client of interruption state change.
(WebCore::MediaSession::endInterruption): Ditto.
- platform/audio/MediaSession.h: Added.
- platform/audio/MediaSessionManager.cpp:
(WebCore::MediaSessionManager::MediaSessionManager): Initialize interruption counter.
(WebCore::MediaSessionManager::has): MediaType is defined in MediaSession.
(WebCore::MediaSessionManager::count): Ditto.
(WebCore::MediaSessionManager::beginInterruption): Inform all clients of interruption start if
not already in an interruption.
(WebCore::MediaSessionManager::endInterruption): Inform all clients if interruption has ended.
(WebCore::MediaSessionManager::addSession): Renamed from addToken. Set session interruption state.
(WebCore::MediaSessionManager::removeSession): Renamed from removeToken.
- platform/audio/MediaSessionManager.h:
- platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestinationMac::AudioDestinationMac): MediaSessionManagerToken -> MediaSession.
- platform/audio/mac/AudioDestinationMac.h:
- platform/audio/mac/MediaSessionManagerMac.cpp:
(MediaSessionManager::updateSessionState): Ditto.
Make it possible for tests to begin and end interruptions.
- testing/Internals.cpp:
(WebCore::Internals::beginMediaSessionInterruption):
(WebCore::Internals::endMediaSessionInterruption):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- CMakeLists.txt: Add ${WEBCORE_DIR}/platform/animation to WebCore include directories.
Source/WebKit2:
- CMakeLists.txt: Add ${WEBCORE_DIR}/platform/animation to WebCore include directories.
LayoutTests:
- media/video-interruption-active-when-element-created-expected.txt: Added.
- media/video-interruption-active-when-element-created.html: Added.
- media/video-interruption-with-resume-allowing-play-expected.txt: Added.
- media/video-interruption-with-resume-allowing-play.html: Added.
- media/video-interruption-with-resume-not-allowing-play-expected.txt: Added.
- media/video-interruption-with-resume-not-allowing-play.html: Added.
- 7:58 PM Changeset in webkit [161480] by
-
- 4 edits in trunk/PerformanceTests
DoYouEvenBench: Turn BenchmarkRunner into a real class
https://bugs.webkit.org/show_bug.cgi?id=126613
Reviewed by Stephanie Lewis.
Made BenchmarkRunner an instantiatable class. Made tests.js simply create an array of suite objects
instead of calling BenchmarkRunner.Suite now that we can have mulitple instances of BenchmarkRunner.
- DoYouEvenBench/benchmark.html:
(formatTestName): Moved and renamed from BenchmarkRunner._testName.
(createUIForSuites): Extracted from a giant blob of code.
(startTest): Ditto.
- DoYouEvenBench/resources/benchmark-runner.js:
(BenchmarkRunner): Added.
(BenchmarkRunner.prototype.waitForElement):
(BenchmarkRunner.prototype._removeFrame):
(BenchmarkRunner.prototype._appendFrame):
(BenchmarkRunner.prototype._waitAndWarmUp):
(BenchmarkRunner.prototype._runTest):
(BenchmarkState.prototype.prepareCurrentSuite):
(BenchmarkRunner.prototype.step):
(BenchmarkRunner.prototype._runTestAndRecordResults):
(BenchmarkRunner.prototype._finalize):
- DoYouEvenBench/resources/tests.js:
- 7:26 PM Changeset in webkit [161479] by
-
- 14 edits in trunk/Source/WebKit/mac
[iOS] Clean up some exported headers
https://bugs.webkit.org/show_bug.cgi?id=126403
Reviewed by Simon Fraser.
Public header files that are completely excluded on iOS don't need
!TARGET_OS_IPHONE guards since they are already listed in
EXCLUDED_SOURCE_FILE_NAMES.
I also took the opportunity to sort EXCLUDED_SOURCE_FILE_NAMES and to
clean up some #imports.
- Configurations/WebKit.xcconfig:
- Misc/WebCache.h:
- Misc/WebIconDatabasePrivate.h:
- Misc/WebLocalizableStrings.h:
- Misc/WebNSEventExtras.h:
- Misc/WebNSPasteboardExtras.h:
- Misc/WebNSWindowExtras.h:
- Panels/WebPanelAuthenticationHandler.h:
- Plugins/WebPluginsPrivate.h:
- Storage/WebDatabaseManagerPrivate.h:
- WebCoreSupport/WebJavaScriptTextInputPanel.h:
- WebCoreSupport/WebKeyGenerator.h:
- WebCoreSupport/WebSecurityOriginPrivate.h:
- WebView/WebDashboardRegion.h:
- WebView/WebDynamicScrollBarsView.h:
- WebView/WebFrameView.h:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebResourceLoadDelegatePrivate.h:
- WebView/WebView.h:
- 6:41 PM Changeset in webkit [161478] by
-
- 2 edits1 add in trunk/Source/WebKit2
[EFL][WK2] Fix failing ewk_view_page_contents_get() API test
https://bugs.webkit.org/show_bug.cgi?id=126609
Reviewed by Gyuyoung Kim.
Compare the amount of bytes in the expected result file with
the size of callback data from the API since the 'Date' field
and the boundaries will be different on each case.
Refered the test case of GTK port.
- UIProcess/API/efl/tests/resources/resultMHTML.mht: Added.
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(EWK2ViewTest::PageContentsAsMHTMLCallback):
- 6:20 PM Changeset in webkit [161477] by
-
- 18 edits2 deletes in trunk
Web Inspector: Remove leftover 'device metrics' code
https://bugs.webkit.org/show_bug.cgi?id=126607
Reviewed by Joseph Pecoraro.
Source/WebCore:
No new tests, No changes in behavior.
Removes unused code related to 'device metrics'.
- css/MediaQueryEvaluator.cpp:
(WebCore::device_heightMediaFeatureEval):
(WebCore::device_widthMediaFeatureEval):
- inspector/InspectorClient.h:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorInstrumentation.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::didLayout):
- inspector/InspectorPageAgent.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
- page/Screen.cpp:
(WebCore::Screen::height):
(WebCore::Screen::width):
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processSubtree):
Source/WebKit/blackberry:
Clean up after removing InspectorClient::overrideDeviceMetrics().
- WebCoreSupport/InspectorClientBlackBerry.cpp:
- WebCoreSupport/InspectorClientBlackBerry.h:
Source/WebKit/mac:
- WebKit.order: Update after removing InspectorClient::overrideDeviceMetrics().
Source/WebKit2:
- mac/WebKit2.order: Update after removing InspectorClient::overrideDeviceMetrics().
LayoutTests:
- inspector/styles/override-screen-size-expected.txt: Removed.
- inspector/styles/override-screen-size.html: Removed.
- 5:35 PM Changeset in webkit [161476] by
-
- 2 edits in trunk/Source/WebKit2
Fix the build. The WebKit2 project copied all of WebKit2/Scripts/webkit2 into WebKit2.framework/PrivateHeaders,
but that's bad because there are test result files in there now. Fix by having the project copy specific
.py files into rivateHeaders/webkit2
- WebKit2.xcodeproj/project.pbxproj:
- 5:16 PM Changeset in webkit [161475] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test fix: Correct whitespace around ]
- platform/mac/TestExpectations: "Debug]" should be "Debug ]"
- 5:03 PM Changeset in webkit [161474] by
-
- 7 edits1 copy2 adds in trunk/Source/WebKit2
Make it possible for MessageReceivers to pass messages to their superclass, and use it for RemoteLayerTreeDrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=126558
Reviewed by Anders Carlsson.
In a message.in file it's now possible to say:
messages -> Subclass : Superclass { ... } and the generated code will
call Superclass::didReceiveMessage().
Use this to have RemoteLayerTreeDrawingAreaProxy pass messages up to
DrawingAreaProxy.
- Scripts/webkit2/messages.py:
(generate_message_handler):
- Scripts/webkit2/model.py:
(MessageReceiver.init):
- Scripts/webkit2/parser.py:
(parse):
- UIProcess/DrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.messages.in:
- 5:03 PM Changeset in webkit [161473] by
-
- 4 edits2 copies1 add in trunk/Source/WebKit2
Add message-generation test for non-legacy message receiver
https://bugs.webkit.org/show_bug.cgi?id=126603
Reviewed by Anders Carlsson.
Add expected output files for a non-legacy message receiver, and add
testing for same.
- Scripts/webkit2/LegacyMessageReceiver-expected.cpp: Copied from Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp.
- Scripts/webkit2/LegacyMessages-expected.h: Added.
- Scripts/webkit2/MessageReceiver-expected.cpp:
(WebKit::WebPage::didReceiveMessage):
(WebKit::WebPage::didReceiveSyncMessage):
- Scripts/webkit2/messages_unittest.py:
(MessagesTest.setUp):
(ParsingTest.test_receiver):
(HeaderTest.test_header):
(ReceiverImplementationTest.test_receiver_implementation):
- Scripts/webkit2/test-legacy-messages.in: Copied from Source/WebKit2/Scripts/webkit2/test-messages.in.
- Scripts/webkit2/test-messages.in:
- 5:03 PM Changeset in webkit [161472] by
-
- 2 edits3 adds in trunk/Source/WebKit2
Move expected results out of messages_unittest.py into separate files
https://bugs.webkit.org/show_bug.cgi?id=126602
Reviewed by Anders Carlsson.
Uninline the test input and output from messages_unittest.py to make
it easier to add more tests.
- Scripts/webkit2/MessageReceiver-expected.cpp: Added.
(WebKit::WebPage::didReceiveWebPageMessage):
(WebKit::WebPage::didReceiveSyncWebPageMessage):
- Scripts/webkit2/Messages-expected.h: Added.
- Scripts/webkit2/messages_unittest.py:
(ParsingTest.test_receiver):
- Scripts/webkit2/test-messages.in: Added.
- 4:51 PM Changeset in webkit [161471] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Add a scheduler for the CLoop bot.
- 4:42 PM Changeset in webkit [161470] by
-
- 12 edits in trunk/Source/WebKit/mac
[iOS] Upstream WebKit support for various features
https://bugs.webkit.org/show_bug.cgi?id=126413
Reviewed by Sam Weinig.
Upstream iOS WebKit changes needed for these features:
- ENABLE(DELETION_UI)
- ENABLE(TOUCH_EVENTS)
- USE(QUICK_LOOK)
- USE(UIKIT_EDITING)
- ENABLE(DISK_IMAGE_CACHE)
- ENABLE(IOS_TEXT_AUTOSIZING)
- ENABLE(ICONDATABASE)
- ENABLE(DASHBOARD_SUPPORT)
- DefaultDelegates/WebDefaultEditingDelegate.m:
- Misc/WebCache.mm:
- WebCoreSupport/WebChromeClient.h:
- WebView/WebDataSource.mm:
(-[WebDataSource dealloc]):
- WebView/WebEditingDelegatePrivate.h:
- WebView/WebFrame.mm:
(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView maintainsInactiveSelection]):
(-[WebHTMLView touch:]):
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
(-[WebView _cacheFrameLoadDelegateImplementations]):
(-[WebView quickLookContentForURL:]):
(-[WebView _touchEventRegions]):
- WebView/WebViewPrivate.h:
- 4:42 PM Changeset in webkit [161469] by
-
- 4 edits in trunk/Source/WebKit/mac
[iOS] Upstream a bug fix for plugin-backed media elements
https://bugs.webkit.org/show_bug.cgi?id=126412
Reviewed by Eric Carlson.
Media elements backed by plug-ins should outlive being removed from the
document, like their native counterparts do.
- Plugins/WebPluginController.h:
- Plugins/WebPluginController.mm:
(-[NSView isMediaPlugInProxyView]):
(-[NSView setIsMediaPlugInProxyView:]):
(-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
(-[WebPluginController mediaPlugInProxyViewCreated:]):
(-[WebPluginController destroyPlugin:]):
- WebCoreSupport/WebFrameLoaderClient.mm:
(pluginView):
- 4:42 PM Changeset in webkit [161468] by
-
- 5 edits in trunk/Source
[iOS] Upstream remainder of minimal-ui viewport changes
https://bugs.webkit.org/show_bug.cgi?id=126410
Reviewed by Sam Weinig.
Source/WebCore:
- dom/ViewportArguments.h:
Source/WebKit/ios:
- WebCoreSupport/WebChromeClientIOS.mm:
(dictionaryForViewportArguments):
- WebKit.iOS.exp:
- 4:35 PM Changeset in webkit [161467] by
-
- 5 edits1 add in branches/jsCStack/Source/JavaScriptCore
Merge trunk r161465.
- 4:30 PM Changeset in webkit [161466] by
-
- 1 edit1 add in branches/jsCStack/Source/JavaScriptCore
Add a test that got lost in some merge.
- tests/stress/phantom-arguments-set-local-then-exit-in-same-block.js: Added.
- 4:27 PM Changeset in webkit [161465] by
-
- 5 edits1 add in trunk/Source/JavaScriptCore
DFG fixup phase should be responsible for inserting ValueToInt32's as needed and it should use Phantom to keep the original values alive in case of OSR exit
https://bugs.webkit.org/show_bug.cgi?id=126600
Reviewed by Michael Saboff.
This fixes an embarrassing OSR exit liveness bug. It also simplifies the code. We were
already using FixupPhase as the place where conversion nodes get inserted. ValueToInt32
was the only exception to that rule, and that was one of the reasons why we had this bug.
Henceforth ValueToInt32 is only inserted by FixupPhase, and only when it is necessary:
we have a BitOp that will want a ToInt32 conversion and the operand is not predicted to
already be an int32. If FixupPhase inserts any ValueToInt32's then the BitOp will no
longer appear to use the original operand, which will make OSR exit think that the
original operand is dead. We work around this they way we always do: insert a Phantom on
the original operands right after the BitOp. This ensures that any OSR exit in any of the
ValueToInt32's or in the BitOp itself will have values for the original inputs.
- dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::BackwardsPropagationPhase::propagate):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::fixBinaryIntEdges):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- tests/stress/bit-op-value-to-int32-input-liveness.js: Added.
(foo):
- 4:12 PM Changeset in webkit [161464] by
-
- 5 edits4 adds3 deletes in trunk
createElementNS handles element name 'xmlns' correctly.
https://bugs.webkit.org/show_bug.cgi?id=126553
Patch by Victor Costan <costan@gmail.com> on 2014-01-07
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Tests: fast/dom/createElementNS-namespace-errors.html
fast/dom/setAttributeNS-namespace-errors.html
- dom/Document.cpp:
(WebCore::Document::hasValidNamespaceForElements): updated to match DOM3/DOM4 spec.
(WebCore::Document::hasValidNamespaceForAttributes): updated to match DOM3/DOM4 spec.
LayoutTests:
- fast/dom/createElementNS-namespace-errors-expected.txt: Added.
- fast/dom/createElementNS-namespace-errors.html: Added. Covers all the corner cases in the DOM4 spec.
- fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js: Removed.
- fast/dom/setAttributeNS-expected.txt: Updated to match cleaned up test.
- fast/dom/setAttributeNS-namespace-errors-expected.txt: Added.
- fast/dom/setAttributeNS-namespace-errors.html: Added. Covers all the corner cases in the DOM4 spec.
- fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt: Removed.
- fast/dom/setAttributeNS-prefix-and-null-namespace.html: Removed. Subsumed by setAttributeNS-namespace-errors.
- fast/dom/setAttributeNS.html: Cleaned up.
- 4:09 PM Changeset in webkit [161463] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Update buiddir to be unique.
- 4:08 PM Changeset in webkit [161462] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
fix Typo.
- 4:04 PM Changeset in webkit [161461] by
-
- 3 edits in trunk/Tools
Add buildbot infrasctructure for building and testing JSC cloop
https://bugs.webkit.org/show_bug.cgi?id=126604
Reviewed by Geoffrey Garen.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileCLOOP):
(RunCLOOPTests):
(RunCLOOPTests.countFailures):
(BuildAndTestCLOOP):
- 3:46 PM Changeset in webkit [161460] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Typo "clipboarPrefixString"
https://bugs.webkit.org/show_bug.cgi?id=126595
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-07
Reviewed by Sam Weinig.
- UserInterface/ConsoleCommandResult.js:
(WebInspector.ConsoleCommandResult.prototype.toMessageElement):
(WebInspector.ConsoleCommandResult.prototype.get clipboardPrefixString):
- UserInterface/ConsoleMessageImpl.js:
(WebInspector.ConsoleMessageImpl.prototype.get clipboardPrefixString):
(WebInspector.ConsoleMessageImpl.prototype.toClipboardString):
- 3:37 PM Changeset in webkit [161459] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/contributors.json:
- 3:22 PM Changeset in webkit [161458] by
-
- 2 edits3 adds1 delete in trunk/PerformanceTests
DoYouEvenBench: Extract tests and runner code from benchmark.js/html
https://bugs.webkit.org/show_bug.cgi?id=126596
Reviewed by Stephanie Lewis.
Extracted benchmark-runner.js and tests.js out of benchmark.js and benchmark.html.
Added a "client" interface to BenchmarkRunner so that benchmark.html could register necessary hooks to
update its UI. Also made BenchmarkRunner store a tree of results so that the serialization of test names
could be isolated from BenchmarkRunner itself in the future.
- DoYouEvenBench/benchmark.html:
Moved the code to instantiate and update UI here from benchmark.js. The test code was moved out of this
file into resources/tests.js.
- DoYouEvenBench/resources/benchmark-runner.js: Renamed from PerformanceTests/DoYouEvenBench/benchmark.js.
(SimplePromise): Moved from benchmark.js
(SimplePromise.prototype.then): Ditto.
(SimplePromise.prototype.resolve): Ditto.
(BenchmarkTestStep): Added. Wraps each test step.
(BenchmarkRunner.suite): Moved from benchmark.js.
(BenchmarkRunner.setClient): Added.
(BenchmarkRunner.waitForElement): Moved.
(BenchmarkRunner._removeFrame): Ditto.
(BenchmarkRunner._appendFrame): Ditto. Set the width and the height of the iframe as they're more than
presentational as they affect performance.
(BenchmarkRunner._waitAndWarmUp): Ditto.
(BenchmarkRunner._runTest): Ditto.
(BenchmarkRunner._testName): Ditto.
(BenchmarkState): Ditto.
(BenchmarkState.prototype.currentSuite): Ditto.
(BenchmarkState.prototype.currentTest): Ditto.
(BenchmarkState.prototype.next): Ditto.
(BenchmarkState.prototype.isFirstTest): Ditto.
(BenchmarkState.prototype.prepareCurrentSuite): Ditto.
(BenchmarkRunner.step): Ditto.
(BenchmarkRunner._runTestAndRecordResults): Ditto. Note the code to update the UI has been move to
benchmark.html. Also moved the code to accumulate the totals here from _finalize.
(BenchmarkRunner._finalize): Moved.
- DoYouEvenBench/resources/tests.js: Copied from PerformanceTests/DoYouEvenBench/benchmark.html.
Uses BenchmarkTestStep instead of an array for each test step.
- 2:31 PM Changeset in webkit [161457] by
-
- 2 edits in trunk/Source/WebCore
PlatformLayer containing scrollbars does not disappear when setting overflow:hidden on page root, until resize.
https://bugs.webkit.org/show_bug.cgi?id=116051
Reviewed by Simon Fraser.
Move the pre-existing call to addedOrRemovedScrollbar() outside of the else-statement
in updateScrollbars() so that changes made in the if-statement cause the scrollbar
layers to be updated. The scrollbarAddedOrRemoved local variable guarding access to
addedOrRemovedScrollbar() is already being set (but never checked) inside the if-statement.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
- 2:27 PM Changeset in webkit [161456] by
-
- 9 edits2 copies in branches/safari-537.74-branch
Merged r160479. <rdar://problems/15754470>
- 2:24 PM Changeset in webkit [161455] by
-
- 11 edits3 adds in trunk
HTML5 video tag Does Not Load in Apache htaccess/htpasswd Protected Directory
https://bugs.webkit.org/show_bug.cgi?id=40382
Reviewed by Eric Carlson.
Source/WebCore:
Test: http/tests/media/video-auth.html
Adopt a new AVFoundation API to handle authentication challenge generated while loading
media through an AVAsset. The authentication request comes through as a
NSURLAuthenticationChallenge, and is wrapped in a WebCore::AuthenticationChallenge
by MediaPlayerPrivateAVFoundationObjC, and is sent up to the HTMLMediaElement to handle.
The HTMLMediaElement creates a ResourceRequest, and passes the challenge up to the
ResourceLoadNotifier.
To allow the HTMLMediaElement to initiate handling an AuthenticationChallenge without
actually creating a ResourceLoader, allow ResourceLoaderDelegate to accept a unique
identifier and a DocumentLoader in lieu of a ResourceLoader.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- html/HTMLMediaElement.h:
- loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge):
(WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge):
- loader/ResourceLoadNotifier.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::shouldWaitForResponseToAuthenticationChallenge):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerShouldWaitForResponseToAuthenticationChallenge):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForResponseToAuthenticationChallenge):
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForResponseToAuthenticationChallenge:]):
LayoutTests:
- http/tests/media/resources/video-auth.php: Added.
- http/tests/media/video-auth-expected.txt: Added.
- http/tests/media/video-auth.html: Added.
- platform/mac/TestExpectations:
- 2:06 PM Changeset in webkit [161454] by
-
- 5 edits in trunk/Tools
Popovers at build.webkit.org/dashboard could have titles
https://bugs.webkit.org/show_bug.cgi?id=126495
Reviewed by Timothy Hatcher.
Added titles to all popovers except for pending revisions one, which I would like
to improve more (probably add an ETA).
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for
adding a title to base class.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
a divider to a separate function.
(BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
(BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
title from above function.
(BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
variable to "content" to match all other code.
(BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
(BuildbotQueueView.prototype._addDividerToPopover): Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
(BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
(BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
- 1:50 PM Changeset in webkit [161453] by
-
- 6 edits in branches/jsCStack/Source/JavaScriptCore
--showDFGDisassembly=true shouldn't show baseline JIT stubs
https://bugs.webkit.org/show_bug.cgi?id=126593
Not yet reviewed.
- assembler/LinkBuffer.cpp:
(JSC::shouldShowDisassemblyFor):
- assembler/LinkBuffer.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByVal):
(JSC::JIT::privateCompilePutByVal):
- jit/JITStubRoutine.h:
- jit/Repatch.cpp:
(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::tryBuildGetByIDList):
(JSC::emitPutReplaceStub):
(JSC::emitPutTransitionStub):
(JSC::tryRepatchIn):
(JSC::linkClosureCall):
- 1:27 PM Changeset in webkit [161452] by
-
- 28 edits in trunk/Source
Unreviewed, rolling out r161447.
http://trac.webkit.org/changeset/161447
https://bugs.webkit.org/show_bug.cgi?id=126592
needs some more work (Requested by thorton on #webkit).
Source/WebCore:
- WebCore.exp.in:
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
- page/FrameView.h:
- platform/graphics/GraphicsLayerClient.h:
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/PlatformCALayerClient.h:
- platform/graphics/ca/mac/TileController.h:
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
(WebCore::TileController::tilesWouldChangeForVisibleRect):
(WebCore::TileController::setExposedRect):
(WebCore::TileController::setClipsToExposedRect):
(WebCore::TileController::computeTileCoverageRect):
(WebCore::TileController::revalidateTiles):
(WebCore::TileController::updateTileCoverageMap):
- rendering/RenderLayerBacking.cpp:
(WebCore::computeTileCoverage):
- rendering/RenderLayerBacking.h:
Source/WebKit2:
- UIProcess/API/mac/WKView.mm:
(-[WKView _updateViewExposedRect]):
- UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
- UIProcess/DrawingAreaProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::viewExposedRectChanged):
(WebKit::WebPageProxy::exposedRectChangedTimerFired):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::viewExposedRect):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setExposedRect):
(WebKit::DrawingArea::setClipsToExposedRect):
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewExposedRectChanged):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::setClipsToExposedRect):
(WebKit::RemoteLayerTreeDrawingArea::updateScrolledExposedRect):
(WebKit::RemoteLayerTreeDrawingArea::updateMainFrameClipsToExposedRect):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setClipsToExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::updateMainFrameClipsToExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
- 1:07 PM Changeset in webkit [161451] by
-
- 2 edits in trunk/Source/WTF
[ASAN] Building with trunk clang corrupts sandbox profile with comment from Compiler.h
https://bugs.webkit.org/show_bug.cgi?id=124532
Reviewed by David Kilzer.
- wtf/Compiler.h:
Remove this quirk - it does nothing.
- 1:05 PM Changeset in webkit [161450] by
-
- 4 edits in trunk/Source/JavaScriptCore
Repatch write barrier slow path call doesn't align the stack in the presence of saved registers
https://bugs.webkit.org/show_bug.cgi?id=126093
Reviewed by Geoffrey Garen.
- jit/Repatch.cpp: Reworked the stack alignment code for calling out to C code on the write barrier slow path.
We need to properly account for the number of reused registers that were saved to the stack, so we have to
pass the ScratchRegisterAllocator around.
(JSC::storeToWriteBarrierBuffer):
(JSC::writeBarrier):
(JSC::emitPutReplaceStub):
(JSC::emitPutTransitionStub):
- jit/ScratchRegisterAllocator.h: Previously the ScratchRegisterAllocator only knew whether or not it had
reused registers, but not how many. In order to correctly align the stack for calls to C slow paths for
the write barriers in inline caches we need to know how the stack is aligned. So now ScratchRegisterAllocator
tracks how many registers it has reused.
(JSC::ScratchRegisterAllocator::ScratchRegisterAllocator):
(JSC::ScratchRegisterAllocator::allocateScratch):
(JSC::ScratchRegisterAllocator::didReuseRegisters):
(JSC::ScratchRegisterAllocator::numberOfReusedRegisters):
(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
- llint/LowLevelInterpreter64.asm: Random typo fix.
- 12:59 PM Changeset in webkit [161449] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
Merge trunk r161438.
- 12:52 PM Changeset in webkit [161448] by
-
- 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog
Indicate that r161445 has been reviewed.
- 12:52 PM Changeset in webkit [161447] by
-
- 28 edits in trunk/Source
TileController can fail to receive exposedRect from the drawing area if set at the wrong time
https://bugs.webkit.org/show_bug.cgi?id=126536
Reviewed by Anders Carlsson.
Move exposedRect to FrameView so it can be pushed in from WebKit before we have
a TiledBacking, and can be retrieved by the TiledBacking when it needs to.
- WebCore.exp.in:
Export some things.
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::setExposedRect):
- page/FrameView.h:
Store the exposed rect on FrameView. When it changes, if the main frame
has a TiledBacking, inform it of the change.
- platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::exposedRect):
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/PlatformCALayerClient.h:
Plumbing so that TileController can retrieve the exposedRect from FrameView.
- platform/graphics/ca/mac/TileController.h:
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
(WebCore::TileController::platformCALayerExposedRect):
(WebCore::TileController::tilesWouldChangeForVisibleRect):
(WebCore::TileController::exposedRectDidChange):
(WebCore::TileController::computeTileCoverageRect):
(WebCore::TileController::revalidateTiles):
(WebCore::TileController::updateTileCoverageMap):
Don't store the exposed rect or clipsToExposedRect on TileController.
Instead, retrieve it from our client.
Make use of the fact that we can test if a rect is infinite
instead of having a separate boolean property for that.
- rendering/RenderLayerBacking.cpp:
(WebCore::computeTileCoverage):
(WebCore::RenderLayerBacking::exposedRect):
Hand the FrameView's exposedRect back to our GraphicsLayer.
We only support clipping for the main frame TileController for now.
- rendering/RenderLayerBacking.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _updateViewExposedRect]):
- UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::setExposedRect):
(WebKit::DrawingAreaProxy::exposedRectChangedTimerFired):
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::exposedRect):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
- UIProcess/WebPageProxy.h:
Move exposedRect stuff from WebPageProxy to DrawingAreaProxy.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Push the exposedRect down into WebCore.
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::updateScrolledExposedRect):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
Get rid of "clipsToExposedRect", we just use infinite-ness of the rect
to indicate that now.
Don't scroll an infinite rect; it won't work.
- 12:47 PM Changeset in webkit [161446] by
-
- 2 edits in trunk/Source/JavaScriptCore
r161364 caused JSC tests regression on non-DFG builds (e.g. C Loop and Windows).
https://bugs.webkit.org/show_bug.cgi?id=126589.
Reviewed by Filip Pizlo.
After the removal of ENABLE(VALUE_PROFILER), the LLINT is now expecting the
relevant opcode operands to point to ValueProfiler data structures and will
write profiling data into them. Hence, we need to allocate these data
structures even though the profiling data won't be used in non-DFG builds.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- 12:16 PM Changeset in webkit [161445] by
-
- 7 edits in branches/jsCStack/Source/JavaScriptCore
FTL OSR entry should only check input variable types after it has set up OSR exit availability of those OSR entry values
https://bugs.webkit.org/show_bug.cgi?id=126587
Not yet reviewed.
At the prologue of OSR entry, DFG IR knows where the arguments are but has no idea
where the locals are. So, before OSR entry starts doing speculation checks, it
should establish (via MovHints) where the locals are. Then it can do the checks
(namely, the SetArgument/SetLocal's).
Also make things a bit easier to debug by making verboseOSR() print OSR exit
disassemblies.
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::finalizeCodeWithDisassembly):
- dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
- dfg/DFGOSREntrypointCreationPhase.cpp:
(JSC::DFG::OSREntrypointCreationPhase::run):
- dfg/DFGOSRExitCompiler.cpp:
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- 12:03 PM Changeset in webkit [161444] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectation update.
- platform/mac/TestExpectations: Mark webgl/1.0.2/conformance/rendering/gl-scissor-test.html as flaky on
Mavericks Debug.
- 12:01 PM Changeset in webkit [161443] by
-
- 5 edits in trunk/Source/WebCore
REGRESSION(r161381): [GTK] Rendering is broken in GTK after r161381
https://bugs.webkit.org/show_bug.cgi?id=126570
Reviewed by Tim Horton.
Use LayoutRect::infiniteRect() instead of IntRect::infiniteRect()
when a LayoutRect is expected.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::fragmentsBoundingBox):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayerBacking.cpp:
(WebCore::clipBox):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::clippedByAncestor):
- 11:39 AM Changeset in webkit [161442] by
-
- 2 edits in branches/safari-537.74-branch/Source/WebCore
Merge 161050: <rdar://problem/15754482>
- 11:36 AM Changeset in webkit [161441] by
-
- 4 edits in trunk/Tools
There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126472
Reviewed by Timothy Hatcher.
Added a delay when quickly switching to a different popover, making it easier to
move mouse pointer from active element to its popover without accidentally opening
a different popover.
Used this code to add a delay before creating a popover. This doesn't change UI
behavior, as there was alerady a delay before it became visible, but it avoids
flooding buildbot server with http requests when quickly moving the mouse over
dashboard page.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
Fixed a case where popover could get stuck. If content was updated while fade-out
transition was already in place, the transition was removed for no good reason.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
(PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
(.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
popover delay from 1s to 800ms.
- 11:35 AM Changeset in webkit [161440] by
-
- 7 edits in trunk/Tools
Improve display of failed builds at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126542
<rdar://problem/15753550>
Reviewed by Timothy Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
Instead of hardcoding step name, look for the first step that failed.
While at it, added a popover with more links. There are multiple, and it's good
to have a choice of which one to look at in each situation.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.get successful): Being successful is not the opposite
of having failed. Many iterations are interrupted for whatever reason internal to
Buildbot, and these are suppoed to be orange, not red.
(BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
not only WillRetry ones.
(BuildbotIteration.prototype.get failed): Changed to only include iterations that
actually failed, more likely indicating a problem with code base.
(BuildbotIteration.prototype.get firstFailedStepName):
(BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
(BuildbotIteration.prototype.get failureLogs): Ditto.
(BuildbotIteration.prototype.update): Store complete results for the failed step.
Not every failure stops the iteration, so we could have multiple failed steps,
but let's see if seeing just the first one will be enough.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
terms of successful iterations.
(BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
terms of successful iterations.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
Removed code to create a path to build output, we now take it from results JSON.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
Added styles for the new popover.
- 11:30 AM Changeset in webkit [161439] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: ARM64 Crash running ecma/FunctionObjects/15.3.1.1-3.js
https://bugs.webkit.org/show_bug.cgi?id=126585
Reviewed by Geoffrey Garen.
We were improperly using a shifted add/subtract for operations with the stack
pointer as the destination. Broadened the cases where we use the extended
register version of add/subtract to include when the destination is the
stack pointer. In the ARM64 documentation, the immediate and extended register
forms of add and subtract are the right variants to manipulate the stack pointer.
- assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::add):
(JSC::ARM64Assembler::sub):
- 11:14 AM Changeset in webkit [161438] by
-
- 2 edits in trunk/Source/JavaScriptCore
ASSERT in compileArithNegate on pdfjs
https://bugs.webkit.org/show_bug.cgi?id=126584
Reviewed by Mark Hahnenberg.
Check negative zero when we should check it, not when we shouldn't check it. :-/
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithNegate):
- 11:10 AM Changeset in webkit [161437] by
-
- 3 edits3 adds in trunk
pushFinallyContext saves wrong m_labelScopes size
https://bugs.webkit.org/show_bug.cgi?id=124529
Remove free label scopes before saving finally context.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::pushFinallyContext):
LayoutTests:
- js/script-tests/try-return-finally-break.js: Added.
(foo):
- js/try-return-finally-break-expected.txt: Added.
- js/try-return-finally-break.html: Added.
- 10:59 AM Changeset in webkit [161436] by
-
- 16 edits in trunk
[CSS Shapes] Change default value from 'auto' to 'none'
https://bugs.webkit.org/show_bug.cgi?id=126544
Reviewed by Sam Weinig.
Source/WebCore:
Update the CSS infrastructure to accept 'none' as the default value
for shape-inside and shape-outside.
Updated existing parsing tests.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseShapeProperty):
- rendering/style/ShapeValue.h:
LayoutTests:
Change the default value to 'none', and replace 'none' with 'auto' in the
list of invalid values.
- fast/shapes/css-shapes-disabled-expected.txt:
- fast/shapes/css-shapes-disabled.html:
- fast/shapes/parsing/parsing-shape-inside-expected.txt:
- fast/shapes/parsing/parsing-shape-inside.html:
- fast/shapes/parsing/parsing-shape-lengths-expected.txt:
- fast/shapes/parsing/parsing-shape-lengths.html:
- fast/shapes/parsing/parsing-shape-margin-expected.txt:
- fast/shapes/parsing/parsing-shape-outside-expected.txt:
- fast/shapes/parsing/parsing-shape-outside.html:
- fast/shapes/parsing/parsing-shape-padding-expected.txt:
- fast/shapes/parsing/parsing-test-utils.js:
- 10:47 AM Changeset in webkit [161435] by
-
- 3 edits in branches/jsCStack/Source/JavaScriptCore
Merge trunk r161411.
- 10:30 AM Changeset in webkit [161434] by
-
- 3 edits2 adds in trunk
[CSS Shapes] shape-outside layout incorrect when line spans rounded box rounded corners
https://bugs.webkit.org/show_bug.cgi?id=126528
Reviewed by Andreas Kling.
Source/WebCore:
BoxShape::getExcludedIntervals() now checks for the special case where the line spans the
top and bottom rounded corners - which implies that the excluded interval is the box's
horizontal extent.
Test: fast/shapes/shape-outside-floats/shape-outside-line-spans-box-corners.html
- rendering/shapes/BoxShape.cpp:
(WebCore::BoxShape::getExcludedIntervals):
LayoutTests:
Verify that a line that spans a shape-outside box's top and bottom rounded corners begins
at the box's right edge.
- fast/shapes/shape-outside-floats/shape-outside-line-spans-box-corners-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-line-spans-box-corners.html: Added.
- 10:29 AM Changeset in webkit [161433] by
-
- 1 edit2 adds in branches/jsCStack/Source/JavaScriptCore
Really merge r161399.
- dfg/DFGArithMode.cpp: Added.
- dfg/DFGArithMode.h: Added.
- 10:04 AM Changeset in webkit [161432] by
-
- 2 edits in trunk/Source/WebCore
Debug biuld fix.
Replace actionTag with mactionTag in assertions.
- mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::getSelectedActionChildAndIndex):
(WebCore::MathMLSelectElement::getSelectedActionChild):
- 10:00 AM WebKitGTK/SpeedUpBuild edited by
- Explain how to set more jobs with icecc (diff)
- 9:57 AM Changeset in webkit [161431] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Disable JIT stack alignment check for ARM64
https://bugs.webkit.org/show_bug.cgi?id=126550
Unreviewed comment only change.
Added comment to checkStackPointerAlignment() suggested by Darin Adler.
- 9:49 AM Changeset in webkit [161430] by
-
- 11 edits6 adds in trunk
Add Support for the semantics element.
https://bugs.webkit.org/show_bug.cgi?id=100626
Source/WebCore:
Patch by Frédéric Wang <fred.wang@free.fr> on 2014-01-07
Reviewed by Chris Fleizach.
Tests: mathml/presentation/semantics-2.html
mathml/presentation/semantics-3.html
mathml/presentation/semantics-4.html
This provides a complete support for the semantics element. When the first child is a content MathML, an annotation can be selected and displayed. The selection algorithm is identical to Gecko's one. The recognized annotations are text (e.g. LaTeX), presentation MathML, SVG and HTML.
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::childShouldCreateRenderer):
(WebCore::MathMLElement::attributeChanged):
(WebCore::MathMLElement::isPresentationMathML):
- mathml/MathMLElement.h:
(WebCore::MathMLElement::isMathMLToken):
(WebCore::MathMLElement::isSemanticAnnotation):
(WebCore::MathMLElement::isPresentationMathML):
(WebCore::MathMLElement::updateSelectedChild):
- mathml/MathMLInlineContainerElement.h:
- mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::getSelectedActionChildAndIndex):
(WebCore::MathMLSelectElement::getSelectedActionChild):
(WebCore::MathMLSelectElement::getSelectedSemanticsChild):
(WebCore::MathMLSelectElement::updateSelectedChild):
(WebCore::MathMLSelectElement::toggle):
- mathml/MathMLSelectElement.h:
- mathml/MathMLTextElement.h:
- mathml/mathattrs.in:
- mathml/mathtags.in:
LayoutTests:
Patch by Frédéric Wang <fred.wang@free.fr> on 2014-01-07
Reviewed by Chris Fleizach.
- TestExpectations:
- mathml/presentation/semantics-2-expected.html: Added.
- mathml/presentation/semantics-2.html: Added.
- mathml/presentation/semantics-3-expected.html: Added.
- mathml/presentation/semantics-3.html: Added.
- mathml/presentation/semantics-4-expected.html: Added.
- mathml/presentation/semantics-4.html: Added.
- 9:39 AM Changeset in webkit [161429] by
-
- 5 edits in trunk/Source/JavaScriptCore
Heap::collect shouldn't be responsible for sweeping
https://bugs.webkit.org/show_bug.cgi?id=126556
Reviewed by Geoffrey Garen.
Sweeping happens at an awkward time during collection due to the fact that destructors can
cause arbitrary reentry into the VM. This patch separates collecting and sweeping, and delays
sweeping until after collection has completely finished.
- heap/Heap.cpp:
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):
(JSC::Heap::collectIfNecessaryOrDefer):
- heap/Heap.h:
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::sweep):
- runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::doWork):
- 9:34 AM Changeset in webkit [161428] by
-
- 2 edits in trunk/Source/WebCore
Fix compilation issue with GLES2 after http://webkit.org/b/126548
https://bugs.webkit.org/show_bug.cgi?id=126578
Patch by Pascal Jacquemart <p.jacquemart@samsung.com> on 2014-01-07
Reviewed by Brent Fulgham
- platform/graphics/opengl/TemporaryOpenGLSetting.cpp: added GLES2/gl2.h include
- 8:59 AM Changeset in webkit [161427] by
-
- 3 edits in trunk/Tools
defined constants should use all uppercase names with words separated by underscores.
https://bugs.webkit.org/show_bug.cgi?id=126055
Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2014-01-07
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_style):
(CppChecker):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_define_constants):
- 7:29 AM Changeset in webkit [161426] by
-
- 2 edits in trunk
Unreviewed GTK/CMake build fix: use the correct location for docs-build.stamp
in output and dependencies declarations, so docs are not built needlessly
every build.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2014-01-07
- Source/PlatformGTK.cmake:
- 7:24 AM Changeset in webkit [161425] by
-
- 21 edits in trunk/Source/WebCore
Remove some extra includes from XML.
https://bugs.webkit.org/show_bug.cgi?id=126572
Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-07
Reviewed by Anders Carlsson.
No new tests, no functionality changed.
- xml/XMLHttpRequest.cpp:
- xml/XMLHttpRequestUpload.cpp:
- xml/XMLHttpRequestUpload.h:
- xml/XPathEvaluator.cpp:
- xml/XPathExpression.cpp:
- xml/XPathExpressionNode.cpp:
- xml/XPathFunctions.cpp:
- xml/XPathNodeSet.cpp:
- xml/XPathParser.cpp:
- xml/XPathPath.cpp:
- xml/XPathPredicate.cpp:
- xml/XPathPredicate.h:
- xml/XPathResult.cpp:
- xml/XPathValue.cpp:
- xml/XPathVariableReference.cpp:
- xml/XSLImportRule.cpp:
- xml/XSLStyleSheetLibxslt.cpp:
- xml/XSLTProcessorLibxslt.cpp:
- xml/parser/XMLDocumentParser.cpp:
- xml/parser/XMLDocumentParserLibxml2.cpp:
- 7:10 AM Changeset in webkit [161424] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/contributors.json:
- 7:08 AM Changeset in webkit [161423] by
-
- 3 edits in trunk/Tools
Remove the WinCE buildbot from build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=126517
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(appendCustomBuildFlags):
- 7:00 AM Changeset in webkit [161422] by
-
- 2 edits3 adds in trunk/LayoutTests
[GTK] fast/repaint/repaint-regions-overflow.html is failing
https://bugs.webkit.org/show_bug.cgi?id=124835
Unreviewed gardening.
Added new baseline for failing test.
- platform/gtk/TestExpectations: Unskipped faling test.
- platform/gtk/fast/regions/repaint/repaint-regions-overflow-expected.txt: Added.
- 6:55 AM Changeset in webkit [161421] by
-
- 2 edits in trunk/Tools
[EFL] Change ATK version to 2.11.4
https://bugs.webkit.org/show_bug.cgi?id=126573
Reviewed by Gyuyoung Kim.
ATK 2.11.4 introduces some new roles, that are already being used by WebKit.
- efl/jhbuild.modules:
- 6:02 AM Changeset in webkit [161420] by
-
- 4 edits in trunk/Source/WebCore
Add toHTMLTableSectionElement() functions, and use it
https://bugs.webkit.org/show_bug.cgi?id=126418
Reviewed by Andreas Kling.
HTMLTableSectionElement covers tbody, tfoot, and thead tags. So, we can't
generate isHTMLTableSectionElement() by using template. This patch add
toHTMLTableSectionElement() manually in order to cleanup static_cast<>.
No new tests, no behavior change.
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::tHead):
(WebCore::HTMLTableElement::tFoot):
(WebCore::HTMLTableElement::lastBody):
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::rowIndex):
- html/HTMLTableSectionElement.h:
- html/HTMLTagNames.in:
- 4:52 AM Changeset in webkit [161419] by
-
- 2 edits in trunk/Tools
[GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
https://bugs.webkit.org/show_bug.cgi?id=117275
Reviewed by Carlos Garcia Campos.
If we are not using the internal jhbuild we must not use the
jhbuild-wrapper script, else it will try to download and install
it.
- Scripts/run-launcher:
- 3:59 AM Changeset in webkit [161418] by
-
- 54 edits in trunk/Source/WebCore
Remove some extra includes from SVG.
https://bugs.webkit.org/show_bug.cgi?id=126565
Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-07
Reviewed by Dirk Schulze.
No new tests, no functionality changed.
- rendering/svg/RenderSVGBlock.cpp:
- rendering/svg/RenderSVGContainer.cpp:
- rendering/svg/RenderSVGEllipse.cpp:
- rendering/svg/RenderSVGEllipse.h:
- rendering/svg/RenderSVGHiddenContainer.cpp:
- rendering/svg/RenderSVGImage.cpp:
- rendering/svg/RenderSVGImage.h:
- rendering/svg/RenderSVGInlineText.cpp:
- rendering/svg/RenderSVGModelObject.cpp:
- rendering/svg/RenderSVGPath.cpp:
- rendering/svg/RenderSVGRect.cpp:
- rendering/svg/RenderSVGResource.cpp:
- rendering/svg/RenderSVGResourceClipper.cpp:
- rendering/svg/RenderSVGResourceClipper.h:
- rendering/svg/RenderSVGResourceContainer.cpp:
- rendering/svg/RenderSVGResourceFilter.cpp:
- rendering/svg/RenderSVGResourceFilter.h:
- rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
- rendering/svg/RenderSVGResourceFilterPrimitive.h:
- rendering/svg/RenderSVGResourceGradient.cpp:
- rendering/svg/RenderSVGResourceGradient.h:
- rendering/svg/RenderSVGResourceLinearGradient.cpp:
- rendering/svg/RenderSVGResourceMarker.cpp:
- rendering/svg/RenderSVGResourceMarker.h:
- rendering/svg/RenderSVGResourceMasker.cpp:
- rendering/svg/RenderSVGResourceMasker.h:
- rendering/svg/RenderSVGResourcePattern.cpp:
- rendering/svg/RenderSVGResourcePattern.h:
- rendering/svg/RenderSVGResourceRadialGradient.cpp:
- rendering/svg/RenderSVGResourceSolidColor.cpp:
- rendering/svg/RenderSVGResourceSolidColor.h:
- rendering/svg/RenderSVGRoot.cpp:
- rendering/svg/RenderSVGShape.cpp:
- rendering/svg/RenderSVGText.cpp:
- rendering/svg/RenderSVGTransformableContainer.cpp:
- rendering/svg/SVGInlineFlowBox.cpp:
- rendering/svg/SVGInlineTextBox.cpp:
- rendering/svg/SVGRenderSupport.cpp:
- rendering/svg/SVGRenderTreeAsText.cpp:
- rendering/svg/SVGRenderingContext.cpp:
- rendering/svg/SVGResources.cpp:
- rendering/svg/SVGResourcesCache.cpp:
- rendering/svg/SVGResourcesCycleSolver.cpp:
- rendering/svg/SVGRootInlineBox.cpp:
- rendering/svg/SVGTextChunk.cpp:
- rendering/svg/SVGTextChunkBuilder.cpp:
- rendering/svg/SVGTextLayoutAttributes.h:
- rendering/svg/SVGTextLayoutAttributesBuilder.h:
- rendering/svg/SVGTextLayoutEngine.cpp:
- rendering/svg/SVGTextLayoutEngine.h:
- rendering/svg/SVGTextMetricsBuilder.h:
- rendering/svg/SVGTextQuery.cpp:
- rendering/svg/SVGTextRunRenderingContext.cpp:
- 3:28 AM Changeset in webkit [161417] by
-
- 16 edits2 adds in trunk
[ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
https://bugs.webkit.org/show_bug.cgi?id=125855
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Test: accessibility/aria-checked-mixed-value.html
Expose ATK_STATE_INDETERMINATE to support aria-checked mixed state
for radio and checkbox types.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(setAtkStateSetFromCoreObject):
Tools:
Added new function isIndeterminate for testing aria-checked mixed state.
I provided respective, but empty function in mac port. Mac testing it differently.
- DumpRenderTree/AccessibilityUIElement.cpp:
(getIsIndeterminate):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::isIndeterminate):
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added empty function.
(AccessibilityUIElement::isIndeterminate):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added empty function.
(AccessibilityUIElement::isIndeterminate):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added empty function.
(AccessibilityUIElement::isIndeterminate):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isIndeterminate):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::isIndeterminate):
LayoutTests:
- accessibility/aria-checked-mixed-value-expected.txt: Added.
- accessibility/aria-checked-mixed-value.html: Added.
- platform/mac/TestExpectations: Skipped it, missing implementation.
- platform/win/TestExpectations: Skipped it, missing implementation.
- 2:06 AM Changeset in webkit [161416] by
-
- 2 edits in trunk/Source/WebKit2
Crash when trying to register a custom scheme before network process has been launched
https://bugs.webkit.org/show_bug.cgi?id=126385
Reviewed by Anders Carlsson.
WebContext::registerSchemeForCustomProtocol() uses
sendToNetworkingProcess() to send the message to the appropriate
networking process. In the case of using web process,
sendToNetworkingProcess() first checks if there's already a web
process, doing nothing otherwise, but when using the network
process it assumes there's already a network process. In both
cases it's safe to do nothing, because the schemes will be passed
as creation parameters to the process when launched.
- UIProcess/WebContext.h:
(WebKit::WebContext::sendToNetworkingProcess):
- 1:46 AM Changeset in webkit [161415] by
-
- 4 edits in trunk/Source
<https://webkit.org/b/126562> DOMProgressEvent has unspecified availability
Reviewed by Ryosuke Niwa.
Source/WebCore:
- bindings/objc/PublicDOMInterfaces.h: Add DOMProgressEvent. It first appeared in 10.6.
Source/WebKit/mac:
- MigrateHeaders.make: Ensure that public DOM headers do not have unspecified availability.
- 1:42 AM Changeset in webkit [161414] by
-
- 2 edits in trunk/Source/JavaScriptCore
<https://webkit.org/b/126567> Remove the legacy WebKit availability macros
They're no longer used.
Reviewed by Ryosuke Niwa.
- API/WebKitAvailability.h:
- 1:36 AM Changeset in webkit [161413] by
-
- 6 edits in trunk/Source/WebKit2
WebKit2 EFL build fix after r161387
https://bugs.webkit.org/show_bug.cgi?id=126566
Reviewed by Andreas Kling.
Add missing ASYNC_SCROLLING macro.
- UIProcess/WebPageProxy.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- 12:46 AM Changeset in webkit [161412] by
-
- 2 edits in trunk/Source/WebCore
Another Mountain Lion build fix.
The Mountain Lion version of NS_DEPRECATED_MAC generates a reference to a nonexistent
availability macro when the introduced and deprecated versions are the same. Follow
AppKit's lead in working around this by defining the macros that will be referenced
for the various possible OS version numbers. This isn't an issue on newer versions of
OS X as the Foundation availability macros expand directly in to attributes rather
than in to the legacy availability maros.
- bindings/objc/WebKitAvailability.h:
- 12:22 AM Changeset in webkit [161411] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
SetLocal for a FlushedArguments should not claim that the dataFormat is DataFormatJS
https://bugs.webkit.org/show_bug.cgi?id=126563
Reviewed by Gavin Barraclough.
This was a rookie arguments simplification mistake: the SetLocal needs to record the fact
that although it set JSValue(), OSR should think it set Arguments. DataFormatArguments
conveys this, and dataFormatFor(FlushFormat) will do the right thing.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- tests/stress/phantom-arguments-set-local-then-exit-in-same-block.js: Added.
(foo):
Jan 6, 2014:
- 11:26 PM Changeset in webkit [161410] by
-
- 2 edits in trunk/Source/WebCore
Mountain Lion build fix.
- bindings/objc/WebKitAvailability.h: #define AVAILABILITY_INTERNALMAC_TBD so that
the TBD version works on Mountain Lion. Newer OS versions use a slightly different set
of macros that already support this version. Add a missing #include so that defintions
of the Foundation availability macros can be found even if no other Foundation headers
were included first.
- 11:19 PM Changeset in webkit [161409] by
-
- 83 edits5 adds in branches/jsCStack
Source/JavaScriptCore: Merge trunk r161072, r161126, r161218, r161353, r161356, r161364, 161399.
Source/WTF: Merge trunk r161364.
LayoutTests: Merge trunk r161072.
- 11:11 PM Changeset in webkit [161408] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r161401.
http://trac.webkit.org/changeset/161401
https://bugs.webkit.org/show_bug.cgi?id=126418
REGRESSION(r161401): Break layout test on mac-wk1(Debug)
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::tHead):
(WebCore::HTMLTableElement::tFoot):
(WebCore::HTMLTableElement::lastBody):
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::rowIndex):
- html/HTMLTableSectionElement.h:
- 10:09 PM Changeset in webkit [161407] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: ARM64 Crash in llint_function_for_call_arity_check running 3d-raytrace.js
https://bugs.webkit.org/show_bug.cgi?id=126557
Reviewed by Geoffrey Garen.
We were crashing due the to definition of t5 in the offline assembler not
matching the definition of regT5 in GPRInfo.h. The crash was due to passing
the stub return address to the fixup thunk in regT5, but it contained garbage.
I changed the definitions of t4, t5 and t6 in the ARM64 back end of the offline
assembler to match GPRInfo.h.
- offlineasm/arm64.rb:
- 10:09 PM Changeset in webkit [161406] by
-
- 45 edits in trunk/Source/WebCore
<https://webkit.org/b/126500> Move Objective-C DOM bindings off the legacy WebKit availability macros
The legacy WebKit availability macros are verbose, confusing, and provide no benefit
over using the system availability macros directly. The original vision was that
they'd serve a cross-platform purpose but that never came to be.
The OS X version used in the new availability macros is based on the mapping in
JavaScriptCore/WebKitAvailability.h.
Part of <rdar://problem/15512304>.
Reviewed by Sam Weinig.
- bindings/objc/DOMCSS.h:
- bindings/objc/DOMEventException.h:
- bindings/objc/DOMException.h:
- bindings/objc/DOMExtensions.h:
- bindings/objc/DOMObject.h:
- bindings/objc/DOMRangeException.h:
- bindings/objc/DOMXPathException.h:
- bindings/objc/PublicDOMInterfaces.h:
- bindings/objc/WebScriptObject.h:
- bindings/scripts/CodeGeneratorObjC.pm:
(ReadPublicInterfaces):
(GenerateHeader): Tag enums with WK_ENUM_AVAILABLE_MAC and classes with WEBKIT_CLASS_AVAILABLE_MAC.
Remove the #ifs that we were previously generating now that enums are appropriately tagged.
- bindings/scripts/test/ObjC/DOMTestActiveDOMObject.h:
- bindings/scripts/test/ObjC/DOMTestActiveDOMObjectInternal.h:
- bindings/scripts/test/ObjC/DOMTestCallback.h:
- bindings/scripts/test/ObjC/DOMTestCallbackInternal.h:
- bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.h:
- bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h:
- bindings/scripts/test/ObjC/DOMTestEventConstructor.h:
- bindings/scripts/test/ObjC/DOMTestEventConstructorInternal.h:
- bindings/scripts/test/ObjC/DOMTestEventTarget.h:
- bindings/scripts/test/ObjC/DOMTestEventTargetInternal.h:
- bindings/scripts/test/ObjC/DOMTestException.h:
- bindings/scripts/test/ObjC/DOMTestExceptionInternal.h:
- bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.h:
- bindings/scripts/test/ObjC/DOMTestGenerateIsReachableInternal.h:
- bindings/scripts/test/ObjC/DOMTestInterface.h:
- bindings/scripts/test/ObjC/DOMTestInterfaceInternal.h:
- bindings/scripts/test/ObjC/DOMTestMediaQueryListListener.h:
- bindings/scripts/test/ObjC/DOMTestMediaQueryListListenerInternal.h:
- bindings/scripts/test/ObjC/DOMTestNamedConstructor.h:
- bindings/scripts/test/ObjC/DOMTestNamedConstructorInternal.h:
- bindings/scripts/test/ObjC/DOMTestNode.h:
- bindings/scripts/test/ObjC/DOMTestNodeInternal.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObjInternal.h:
- bindings/scripts/test/ObjC/DOMTestOverloadedConstructors.h:
- bindings/scripts/test/ObjC/DOMTestOverloadedConstructorsInternal.h:
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h:
- bindings/scripts/test/ObjC/DOMTestTypedefs.h:
- bindings/scripts/test/ObjC/DOMTestTypedefsInternal.h:
- bindings/scripts/test/ObjC/DOMattribute.h:
- bindings/scripts/test/ObjC/DOMattributeInternal.h:
- bindings/scripts/test/ObjC/DOMreadonly.h:
- bindings/scripts/test/ObjC/DOMreadonlyInternal.h:
- 10:07 PM Changeset in webkit [161405] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Fix nativeForGenerator() for non-X86 platforms
https://bugs.webkit.org/show_bug.cgi?id=126551
Reviewed by Geoffrey Garen.
Removed the explicit saving and restoring of the return address and call frame register
from the non-X86 paths of nativeForGenerator() as these are no longer needed.
The function prologue and epilogue now perform calling convention consistent saving
and restoring of these values.
- jit/ThunkGenerators.cpp:
(JSC::nativeForGenerator):
- 9:40 PM Changeset in webkit [161404] by
-
- 4 edits2 adds in trunk
REGRESSION(r157851): trailing space inside an editable region could be erroneously collapsed
https://bugs.webkit.org/show_bug.cgi?id=126549
Reviewed by Sam Weinig.
Source/WebCore:
The regression was caused by erroneous use of m_currentCharacterIsSpace in place of m_currentCharacterIsWS.
See the following two lines before the refactoring:
http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp?rev=157850#L3074
http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp?rev=157850#L3198
I've also cross-checked other places where m_currentCharacterIsSpace and m_currentCharacterIsWS are used.
Test: editing/inserting/inserting-trailing-space-and-letter.html
- rendering/line/BreakingContextInlineHeaders.h:
(WebCore::BreakingContext::handleText):
LayoutTests:
Added a regression test and reverted the erroneous rebaseline in r157851.
- editing/inserting/inserting-trailing-space-and-letter-expected.html: Added.
- editing/inserting/inserting-trailing-space-and-letter.html: Added.
- platform/mac/editing/selection/after-line-wrap-expected.txt:
- 9:24 PM Changeset in webkit [161403] by
-
- 39 edits2 adds in branches/jsCStack
PerformanceTests/SunSpider: Merge trunk r160411.
Source/JavaScriptCore: Merge trunk r160394, r160407, r160411, r160587.
Tools: Merge trunk r160411.
- 9:19 PM Changeset in webkit [161402] by
-
- 14 edits in trunk/Source
Web Inspector: Remove canOverrideDeviceMetrics and setDeviceMetricsOverride from protocol
https://bugs.webkit.org/show_bug.cgi?id=126149
Reviewed by Joseph Pecoraro.
Source/WebCore:
No new tests, No changes in behavior.
These are not used anywhere in WebInspectorUI.
So, it removes unused Protocols and APIs.
- inspector/InspectorClient.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::disable):
- inspector/InspectorPageAgent.h:
- inspector/protocol/Page.json:
Source/WebInspectorUI:
- UserInterface/InspectorWebBackendCommands.js: Remove unused codes.
- UserInterface/Legacy/6.0/InspectorWebBackendCommands.js: Ditto.
- UserInterface/Legacy/7.0/InspectorWebBackendCommands.js: Ditto.
- Versions/Inspector-iOS-6.0.json: Ditto.
- Versions/Inspector-iOS-7.0.json: Ditto.
Source/WebKit/blackberry:
- WebCoreSupport/InspectorClientBlackBerry.cpp: Remove dead codes.
- WebCoreSupport/InspectorClientBlackBerry.h: Ditto.
- 9:15 PM Changeset in webkit [161401] by
-
- 4 edits in trunk/Source/WebCore
Add toHTMLTableSectionElement() functions, and use it
https://bugs.webkit.org/show_bug.cgi?id=126418
Reviewed by Anders Carlsson.
HTMLTableSectionElement covers tbody, tfoot, and thead tags. So, we can't
generate isHTMLTableSectionElement() by using template. This patch add
toHTMLTableSectionElement() manually in order to cleanup static_cast<>.
No new tests, no behavior change.
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::tHead):
(WebCore::HTMLTableElement::tFoot):
(WebCore::HTMLTableElement::lastBody):
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::rowIndex):
- html/HTMLTableSectionElement.h:
- html/HTMLTagNames.in:
- 8:58 PM Changeset in webkit [161400] by
-
- 7 edits in branches/jsCStack/Source/JavaScriptCore
Merge of trunk r160493
2013-12-11 Filip Pizlo <fpizlo@apple.com>
ARM64: Hang running pdfjs test, suspect DFG generated code for "in"
https://bugs.webkit.org/show_bug.cgi?id=124727
<rdar://problem/15566923>
Reviewed by Michael Saboff.
Get rid of In's hackish use of StructureStubInfo. Previously it was using hotPathBegin,
and it was the only IC that used that field, which was wasteful. Moreover, it used it
to store two separate locations: the label for patching the jump and the label right
after the jump. The code was relying on those two being the same label, which is true
on X86 and some other platforms, but it isn't true on ARM64.
This gets rid of hotPathBegin and makes In express those two locations as offsets from
the callReturnLocation, which is analogous to what the other IC's do.
This fixes a bug where any successful In patching would result in a trivially infinite
loop - and hence a hang - on ARM64.
- bytecode/StructureStubInfo.h:
- dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h: (JSC::DFG::InRecord::InRecord):
- dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileIn):
- jit/JITInlineCacheGenerator.cpp: (JSC::JITByIdGenerator::finalize):
- jit/Repatch.cpp: (JSC::replaceWithJump): (JSC::patchJumpToGetByIdStub): (JSC::tryCachePutByID): (JSC::tryBuildPutByIdList): (JSC::tryRepatchIn): (JSC::resetGetByID): (JSC::resetPutByID): (JSC::resetIn):
- 8:52 PM Changeset in webkit [161399] by
-
- 16 edits2 adds in trunk/Source/JavaScriptCore
Make the different flavors of integer arithmetic more explicit, and don't rely on (possibly stale) results of the backwards propagator to decide integer arithmetic semantics
https://bugs.webkit.org/show_bug.cgi?id=125519
Reviewed by Geoffrey Garen.
Adds the Arith::Mode enum to arithmetic nodes, which makes it explicit what sorts of
checks and overflows the node should do. Previously this would be deduced from
backwards analysis results.
This also makes "unchecked" variants really mean that you want the int32 wrapped
result, so ArithIMul is now done in terms of ArithMul(Unchecked). That means that the
constant folder needs to compute exactly the result implied by ArithMode, instead of
just folding the double result.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGArithMode.cpp: Added.
(WTF::printInternal):
- dfg/DFGArithMode.h: Added.
(JSC::DFG::doesOverflow):
(JSC::DFG::shouldCheckOverflow):
(JSC::DFG::shouldCheckNegativeZero):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasArithMode):
(JSC::DFG::Node::arithMode):
(JSC::DFG::Node::setArithMode):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArithMod):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileAddSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithDivMod):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):
- 8:48 PM Changeset in webkit [161398] by
-
- 36 edits7 adds in branches/jsCStack/Source/JavaScriptCore
- 8:45 PM Changeset in webkit [161397] by
-
- 3 edits in trunk/Source/WebCore
<https://webkit.org/b/126559> Be more correct in dealing with NSControlSize
Reviewed by Ryosuke Niwa.
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::scrollbarControlSizeToNSControlSize): Helper function to map from ScrollbarControlSize
to NSControlSize.
(WebCore::ScrollbarThemeMac::registerScrollbar): Use the helper rather than casting.
(WebCore::ScrollbarThemeMac::scrollbarThickness): Use the helper.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::progressBarRectForBounds): Update the type of the local to NSControlSize.
(WebCore::RenderThemeMac::paintProgressBar): Ditto.
- 8:00 PM Changeset in webkit [161396] by
-
- 3 edits in trunk/Tools
<https://webkit.org/b/126560> Fix incorrectness in use of some AppKit enums
Reviewed by Ryosuke Niwa.
- DumpRenderTree/mac/DumpRenderTree.mm:
(-[DRTMockScroller rectForPart:]): Move to using an if with early return instead of a switch
with a single case. This avoids the potential for warnings about unhandled cases.
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView): Cast the argument to NSBackingStoreType.
- 7:52 PM Changeset in webkit [161395] by
-
- 1 edit1 add in branches/jsCStack/Source/JavaScriptCore
Finish merging r160292: add more forgotten files.
- tests/stress/fold-typed-array-properties.js: Added.
- 7:44 PM Changeset in webkit [161394] by
-
- 1 edit2 adds in branches/jsCStack/Source/JavaScriptCore
Finish merging r160292: add forgotten files.
- dfg/DFGStrengthReductionPhase.cpp: Added.
- dfg/DFGStrengthReductionPhase.h: Added.
- 7:42 PM Changeset in webkit [161393] by
-
- 25 edits in branches/jsCStack
Source/JavaScriptCore: Merge trunk r160292.
Tools: Merge trunk r160292.
- 7:17 PM Changeset in webkit [161392] by
-
- 6 edits15 adds in branches/jsCStack
Source/JavaScriptCore: Merge trunk r160238, r160242, r160246, r160252, r160257.
LayoutTests: Merge trunk r160242, r160246, r160252, r160257.
- 6:04 PM Changeset in webkit [161391] by
-
- 2 edits1 delete in trunk/LayoutTests
[WebGL] Unreviewed build fix for Mountain Lion drivers.
- platform/mac-mountainlion/TestExpectations: Removed. Moved test to the mac/TestExpectations file.
- platform/mac/TestExpectations: Add failure entry for MountainLion test.
- 5:55 PM Changeset in webkit [161390] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Disable JIT stack alignment check for ARM64
https://bugs.webkit.org/show_bug.cgi?id=126550
Reviewed by Mark Lam.
Since ARM64 enforces strict stack alignment, the need for checkStackPointerAlignment()
is not needed. Also, the implementation of checkStackPointerAlignment() would
need to be reworked given the limits on the operations that can be done with
the stack pointer register in ARM64. Therefore conditionally disabled
checkStackPointerAlignment() for ARM64.
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::checkStackPointerAlignment):
- 5:44 PM Changeset in webkit [161389] by
-
- 11 edits2 adds in trunk/Source/WebCore
[WebGL] Be safer about toggling OpenGL state by using a scoped object to control setting lifetime.
https://bugs.webkit.org/show_bug.cgi?id=126548
Reviewed by Anders Carlsson.
No new tests since there is no change in behavior.
- GNUmakefile.list.am: Updated to build new TemporaryOpenGLSetting files.
- PlatformBlackBerry.cmake: Ditto
- PlatformEfl.cmake: Ditto
- PlatformGTK.cmake: Ditto
- PlatformNix.cmake: Ditto
- WebCore.vcxproj/WebCore.vcxproj: Ditto
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto
- WebCore.xcodeproj/project.pbxproj: Ditto
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Use new object.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture): Ditto
(WebCore::GraphicsContext3D::reshape): Ditto
- platform/graphics/opengl/TemporaryOpenGLSetting.cpp: Added.
(WebCore::TemporaryOpenGLSetting::TemporaryOpenGLSetting):
(WebCore::TemporaryOpenGLSetting::~TemporaryOpenGLSetting):
- platform/graphics/opengl/TemporaryOpenGLSetting.h: Added.
- 5:41 PM Changeset in webkit [161388] by
-
- 1 edit1 add in trunk/LayoutTests
[WebGL] Unreviewed build fix for Mountain Lion drivers.
Add new TestExpectations file for Mountain Lion.
- platform/mac-mountainlion/TestExpectations: Added.
- 4:57 PM Changeset in webkit [161387] by
-
- 17 edits in trunk/Source
Hook up the RemoteScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=126547
Source/WebCore:
Reviewed by Tim Horton.
Export lots of scrolling-related symbols for use by WebKit2.
- WebCore.exp.in:
Source/WebKit2:
Reviewed by Tim Horton.
Hook up the RemoteScrollingCoordinator in WebKit2.
When the RemoteLayerTreeDrawingArea is in use, WebPageProxy creates
a RemoteScrollingCoordinator, and hands it mouseWheel events. It then
scrolls via a RemoteScrollingTree constructed from state tree commits from the
WebProcess.
Scrolling tree commits happen via a transaction received by RemoteLayerTreeDrawingAreaProxy,
atomically with layer tree transactions.
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::RemoteScrollingCoordinatorTransaction::encode): Fix encoding for some
cases seen in WebKitTestRunner where a page has no ScrollingCoordinator.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage): Create the RemoteScrollingCoordinatorProxy
when using a remote layer tree drawing area.
(WebKit::WebPageProxy::handleWheelEvent): Pass to the scrolling coordinator.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::scrollingCoordinatorProxy):
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h: Include the RemoteScrollingCoordinatorTransaction.
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.messages.in:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::getLayer): It's valid to get a 0 layerID (e.g. when
a layer disappears) so handle this case.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createScrollingCoordinator): Override to create the
RemoteScrollingCoordinator in the WebProcess.
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scrollingCoordinator): Not inline to avoid polluting the
header with #includes.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h: Say that we want a ScrollingCoordinator.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers): Add the scrollingTransaction to the
message.
- 4:56 PM Changeset in webkit [161386] by
-
- 2 edits in trunk/Source/WebKit2
Use hasEnabledVerticalScrollbar instead of hasEnabledHorizontalScrollbar.
https://bugs.webkit.org/show_bug.cgi?id=126546
Reviewed by Simon Fraser.
hasEnabledHorizontalScrollbar is used twice.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<WebCore::ScrollableAreaParameters>::encode):
- 4:52 PM Changeset in webkit [161385] by
-
- 15 edits1 delete in trunk/Source
Web Inspector: Remove support for FileSystem in Frontend.
https://bugs.webkit.org/show_bug.cgi?id=126369
Reviewed by Joseph Pecoraro.
Source/WebCore:
No new tests, No change in behavior.
Remove leftover codes from protocol after r156692.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- inspector/InspectorFrontendClient.h:
- inspector/InspectorFrontendClientLocal.h:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/protocol/FileSystem.json: Removed.
Source/WebInspectorUI:
Update InspectorWebBackendCommands after removing 'FileSystem' domain.
- UserInterface/InspectorWebBackendCommands.js:
- UserInterface/Legacy/6.0/InspectorWebBackendCommands.js:
- UserInterface/Legacy/7.0/InspectorWebBackendCommands.js:
- Versions/Inspector-iOS-6.0.json:
- Versions/Inspector-iOS-7.0.json:
- 4:42 PM Changeset in webkit [161384] by
-
- 3 edits2 adds in trunk
[CSS Regions][CSS Shapes] ASSERTION FAILED: m_segmentRanges.size() < m_segments.size()
https://bugs.webkit.org/show_bug.cgi?id=125770
Reviewed by Bem Jones-Bey.
Source/WebCore:
When we have an e.g. up-side-down triangle, when the content doesn't fit in the bottom part of the shape,
and the adjusted content flows into the next region with a shape, we need to update the actual shape
and region. Since it wasn't updated, it led to a shape mismatch, which led to assert/layout error.
Test: fast/regions/shape-inside/shape-inside-on-multiple-regions-bottom-adjustment.html
- rendering/RenderBlockLineLayout.cpp:
(WebiCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread): Update current shape
and region, when adjustment occured.
LayoutTests:
- fast/regions/shape-inside/shape-inside-on-multiple-regions-bottom-adjustment-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-multiple-regions-bottom-adjustment.html: Added.
- 4:35 PM Changeset in webkit [161383] by
-
- 3 edits in trunk/LayoutTests
Unreviewed test correction.
- webgl/1.0.2/resources/webgl_test_files/conformance/renderbuffers/framebuffer-object-attachment.html: Remove commented-out
line from debugging code.
- webgl/1.0.2/resources/webgl_test_files/conformance/resources/webgl-test-utils.js:
(WebGLTestUtils): Return to normal behavior of exiting immediately on test failure.
- 4:05 PM Changeset in webkit [161382] by
-
- 8 edits1 delete in trunk/Source/WebCore
Web Inspector: Get rid of Inspector/BindingVisitors.h
https://bugs.webkit.org/show_bug.cgi?id=126374
Reviewed by Joseph Pecoraro.
No new tests, No change in behavior.
In r161204, methods related to BindingVisitors was removed.
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptProfiler.h:
- inspector/BindingVisitors.h: Removed.
- inspector/InspectorCanvasAgent.cpp:
- inspector/InspectorMemoryAgent.cpp:
- 3:50 PM Changeset in webkit [161381] by
-
- 10 edits in trunk/Source/WebCore
Add {IntRect, FloatRect}::infiniteRect() and ::isInfinite()
https://bugs.webkit.org/show_bug.cgi?id=126537
Reviewed by Simon Fraser.
- platform/graphics/FloatRect.h:
(WebCore::FloatRect::infiniteRect):
(WebCore::FloatRect::isInfinite):
- platform/graphics/IntRect.h:
(WebCore::IntRect::infiniteRect):
(WebCore::IntRect::isInfinite):
Add infiniteRect() and isInfinite() to FloatRect and IntRect.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setNeedsDisplay):
- rendering/PaintInfo.h:
(WebCore::PaintInfo::applyTransform):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::fragmentsBoundingBox):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayerBacking.cpp:
(WebCore::clipBox):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::clippedByAncestor):
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::renderSubtreeToImageBuffer):
Adopt the new functions.
- 3:35 PM Changeset in webkit [161380] by
-
- 9 edits2 deletes in trunk
Web Inspector: Get rid of DOM.setFileInputFiles from Protocol
https://bugs.webkit.org/show_bug.cgi?id=126312
Reviewed by Joseph Pecoraro.
Source/WebCore:
No new tests, No changes in behavior.
It is a dead code as all ports in WebKit don't support it.
And this patch removes all things related to DOM.setFileInputFiles in Frontend.
- inspector/InspectorClient.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
- inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
- inspector/protocol/DOM.json:
Source/WebInspectorUI:
Update InspectorWebBackendCommands.js after removing DOM.setFileInputFiles.
- UserInterface/InspectorWebBackendCommands.js:
LayoutTests:
- inspector-protocol/dom/setFileInputFiles-expected.txt: Removed.
- inspector-protocol/dom/setFileInputFiles.html: Removed.
- 3:28 PM Changeset in webkit [161379] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test update after r161375.
- platform/mac/TestExpectations: Activate several tests that are now known to pass.
- 3:23 PM Changeset in webkit [161378] by
-
- 2 edits in trunk/Source/WebCore
[WebGL] Revise String Concatenation (Follow-up to r161247)
https://bugs.webkit.org/show_bug.cgi?id=126411
Reviewed by Dean Jackson.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getUniformLocation): Use more efficient string
concatenation per Darin Adler's suggestion.
- 3:04 PM Changeset in webkit [161377] by
-
- 11 edits in trunk/Source/JavaScriptCore
Add write barriers to the LLInt
https://bugs.webkit.org/show_bug.cgi?id=126527
Reviewed by Filip Pizlo.
This patch takes a similar approach to how write barriers work in the baseline JIT.
We execute the write barrier at the beginning of the opcode so we don't have to
worry about saving and restoring live registers across write barrier slow path calls
to C code.
- llint/LLIntOfflineAsmConfig.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::llint_write_barrier_slow):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/arm64.rb:
- offlineasm/instructions.rb:
- offlineasm/x86.rb:
- 2:46 PM Changeset in webkit [161376] by
-
- 2 edits in trunk/Source/WebKit2
Another build fix.
Need to look in the WebProcess/Scrolling directory for .messages.in files.
- DerivedSources.make:
- 2:43 PM Changeset in webkit [161375] by
-
- 4 edits in trunk
[WebGL] FBO Depth Buffer Attachment Function Improperly Clearing with 0
https://bugs.webkit.org/show_bug.cgi?id=126538
<rdar://problem/15201336>
Reviewed by Dean Jackson.
Tested by webgl/1.0.2/resources/webgl_test_files/conformance/renderbuffers/framebuffer-object-attachment.html
- html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::initializeAttachments): Clear depth buffer with 1.0f (rather than 0), to match expected
default (clear) buffer state for OpenGL. Using 0 would require us to flip the clear mask for the depth attachment
type.
- 2:38 PM Changeset in webkit [161374] by
-
- 2 edits in trunk/Source/WebKit2
Fix the build.
Need to add RemoteScrollingCoordinator to MESSAGE_RECEIVERS so that
RemoteScrollingCoordinatorMessages.h gets generated.
- DerivedSources.make:
- 2:19 PM Changeset in webkit [161373] by
-
- 8 edits2 copies10 adds in trunk/Source
Add new files for UI-side scrolling
https://bugs.webkit.org/show_bug.cgi?id=126532
Source/WebCore:
Reviewed by Anders Carlson.
- WebCore.xcodeproj/project.pbxproj: Make lots of scrolling-related headers Private
so WebKit2 can include them.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::scheduleUpdateScrollPositionForNode): Callback that
indicates that the given node has been scrolled asynchronously. Currently only
handles the main frame.
- page/scrolling/ScrollingCoordinator.h: Add support for type-casts of a remote subclass
in another namespace.
(WebCore::ScrollingCoordinator::isRemoteScrollingCoordinator):
- page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::isRemoteScrollingTree):
Source/WebKit2:
Reviewed by Anders Carlson.
Add RemoteScrollingCoordinator, RemoteScrollingCoordinatorProxy,
RemoteScrollingCoordinatorTransaction, RemoteScrollingTree.
These allow the scrolling tree to be used in the UI process.
RemoteScrollingCoordinator builds a ScrollingStateTree, which is
encoded by RemoteScrollingCoordinatorTransaction. Decoding the
transaction recreates that ScrollingStateTree in the UI process,
and RemoteScrollingCoordinatorProxy "commits" that to update
the RemoteScrollingTree.
New classes are not hooked up to anything yet.
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp: Added.
(ArgumentCoder<ScrollingStateNode>::encode):
(ArgumentCoder<ScrollingStateNode>::decode):
(ArgumentCoder<ScrollingStateScrollingNode>::encode):
(ArgumentCoder<ScrollingStateScrollingNode>::decode):
(ArgumentCoder<ScrollingStateFixedNode>::encode):
(ArgumentCoder<ScrollingStateFixedNode>::decode):
(ArgumentCoder<ScrollingStateStickyNode>::encode):
(ArgumentCoder<ScrollingStateStickyNode>::decode):
(WebKit::encodeNodeAndDescendants):
(WebKit::RemoteScrollingCoordinatorTransaction::encode):
(WebKit::RemoteScrollingCoordinatorTransaction::decode):
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.h: Added.
(WebKit::RemoteScrollingCoordinatorTransaction::setStateTreeToEncode):
(WebKit::RemoteScrollingCoordinatorTransaction::scrollingStateTree):
- UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp: Added.
(WebKit::RemoteScrollingCoordinatorProxy::RemoteScrollingCoordinatorProxy):
(WebKit::RemoteScrollingCoordinatorProxy::~RemoteScrollingCoordinatorProxy):
(WebKit::RemoteScrollingCoordinatorProxy::layerTreeHost):
(WebKit::RemoteScrollingCoordinatorProxy::updateScrollingTree):
(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):
(WebKit::RemoteScrollingCoordinatorProxy::handleWheelEvent):
(WebKit::RemoteScrollingCoordinatorProxy::scrollPositionChanged):
- UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h: Added.
- UIProcess/Scrolling/RemoteScrollingTree.cpp: Added.
(WebKit::RemoteScrollingTree::create):
(WebKit::RemoteScrollingTree::RemoteScrollingTree):
(WebKit::RemoteScrollingTree::~RemoteScrollingTree):
(WebKit::RemoteScrollingTree::tryToHandleWheelEvent):
(WebKit::RemoteScrollingTree::handleWheelEventPhase):
(WebKit::RemoteScrollingTree::updateMainFrameScrollPosition):
(WebKit::RemoteScrollingTree::createNode):
- UIProcess/Scrolling/RemoteScrollingTree.h: Added.
(WebKit::RemoteScrollingTree::scrollingCoordinatorProxy):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Scrolling/RemoteScrollingCoordinator.h: Added.
(WebKit::RemoteScrollingCoordinator::create):
- WebProcess/Scrolling/RemoteScrollingCoordinator.messages.in: Added.
- WebProcess/Scrolling/RemoteScrollingCoordinator.mm: Added.
(WebKit::RemoteScrollingCoordinator::RemoteScrollingCoordinator):
(WebKit::RemoteScrollingCoordinator::~RemoteScrollingCoordinator):
(WebKit::RemoteScrollingCoordinator::scheduleTreeStateCommit):
(WebKit::RemoteScrollingCoordinator::createScrollingTreeNode):
(WebKit::RemoteScrollingCoordinator::isRubberBandInProgress):
(WebKit::RemoteScrollingCoordinator::setScrollPinningBehavior):
(WebKit::RemoteScrollingCoordinator::buildTransaction):
(WebKit::RemoteScrollingCoordinator::scrollPositionChangedForNode):
- 2:18 PM Changeset in webkit [161372] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack: JSLock drop and grab lock APIs should be private.
https://bugs.webkit.org/show_bug.cgi?id=126539.
Reviewed by Mark Hahnenberg.
We want the dropping and re-acquisition of the VM API lock to be via the
DropAllLocks raii object. Hence, we should not publicly publishing the
APIs for dropping and re-acquiring the locks.
- runtime/JSLock.h:
- 2:03 PM Changeset in webkit [161371] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r161195): Acid2 regression tests frequently fail
https://bugs.webkit.org/show_bug.cgi?id=126432
- TestExpectations: Marking them as flaky.
- 1:52 PM Changeset in webkit [161370] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[GTK] [CMake] Improve the way that translations are built with the built-in gettext support CMake
https://bugs.webkit.org/show_bug.cgi?id=126453
Reviewed by Gustavo Noronha Silva.
- CMakeLists.txt: Use the built-in CMake support for gettext to simplify the way we
build translation files and to automatically take care of installing them. Also adjust
the pot file build location to make the CMake build more similar to autotools.
- 1:48 PM Changeset in webkit [161369] by
-
- 3 edits in branches/jsCStack/Source/JavaScriptCore
Follow up patch to remove the need for VMEntryScope::m_prevFirstEntryScope.
https://bugs.webkit.org/show_bug.cgi?id=126266.
Reviewed by Geoffrey Garen.
There can only be one firstEntryScope. Instead of saving the previous value of
VM::firstEntryScope, we now check if the firstEntryScope is the same as this
VMEntryScope in its destructor. If so, we will set VM::firstEntryScope to 0.
- runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):
- runtime/VMEntryScope.h:
- 1:31 PM Changeset in webkit [161368] by
-
- 4 edits in trunk/Source
Small build fix for the GTK+ CMake port
Source/WebKit:
- PlatformGTK.cmake: Include a missing GeoClue include directory.
Source/WebKit2:
- PlatformGTK.cmake: Include a missing GeoClue include directory.
- 1:30 PM Changeset in webkit [161367] by
-
- 4 edits in trunk/Source/WebKit2
Rename DrawingArea::supportsThreadedScrolling() to supportsAsyncScrolling()
https://bugs.webkit.org/show_bug.cgi?id=126529
Reviewed by Tim Horton.
Change function name from using "threaded" to "async" terminology.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::supportsAsyncScrolling):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- 1:14 PM Changeset in webkit [161366] by
-
- 11 edits85 copies7 adds2 deletes in trunk
[GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=126342
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2014-01-04
Reviewed by Gustavo Noronha Silva.
.:
- GNUmakefile.am: Remove unused variable.
- Source/PlatformGTK.cmake: No longer include the old unit tests directories.
Source/WebKit/gtk:
- tests/CMakeLists.txt: Removed.
- tests/GNUmakefile.am: Removed.
Source/WebKit2:
- UIProcess/API/gtk/tests/CMakeLists.txt: Removed.
- UIProcess/API/gtk/tests/GNUmakefile.am: Removed.
Tools:
- CMakeLists.txt: Include the new unit tests subdirectories.
- Scripts/run-gtk-tests: Update to refer to the new build locations.
- Scripts/webkitpy/style/checker.py: Update the style checker.
- Scripts/webkitpy/style/checker_unittest.py:
- TestWebKitAPI/GNUmakefile.am:
- TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
- TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
- TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
- TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
- TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
- TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
- TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
- TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
- TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
- TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
- TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
- TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
- TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
- TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
- TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
- TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
- TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
- TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
- TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
- TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
- TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
- TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
- TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
- TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
- TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
- TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
- TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
- TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
- TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
- TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
- TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
- TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
- TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
- TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
- TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
- TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
- TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
- TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
- TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
- TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
- 1:00 PM Changeset in webkit [161365] by
-
- 12 edits in trunk
[JS] Implement Promise.all()
https://bugs.webkit.org/show_bug.cgi?id=126510
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Add Promise.all() implementation and factor out performing resolves and rejects
on deferreds to share a bit of code. Also moves the abruptRejection helper to
JSPromiseDeferred so it can be used in JSPromiseFunctions.
- runtime/CommonIdentifiers.h:
- runtime/JSPromiseConstructor.cpp:
(JSC::JSPromiseConstructorFuncCast):
(JSC::JSPromiseConstructorFuncResolve):
(JSC::JSPromiseConstructorFuncReject):
(JSC::JSPromiseConstructorFuncAll):
- runtime/JSPromiseDeferred.cpp:
(JSC::updateDeferredFromPotentialThenable):
(JSC::performDeferredResolve):
(JSC::performDeferredReject):
(JSC::abruptRejection):
- runtime/JSPromiseDeferred.h:
- runtime/JSPromiseFunctions.cpp:
(JSC::promiseAllCountdownFunction):
(JSC::createPromiseAllCountdownFunction):
- runtime/JSPromiseFunctions.h:
- runtime/JSPromiseReaction.cpp:
(JSC::ExecutePromiseReactionMicrotask::run):
LayoutTests:
Enabled and fix the existing Promise.all() test case.
- Promise.all() and Promise.all({}) should reject by my reading of the spec.
Also removes the Promise.all() shim used by the crypto tests.
- crypto/subtle/resources/common.js:
- js/dom/Promise-static-all-expected.txt:
- js/dom/Promise-static-all.html:
- 12:41 PM Changeset in webkit [161364] by
-
- 31 edits in trunk/Source
Get rid of ENABLE(VALUE_PROFILER). It's on all the time now.
Rubber stamped by Mark Hahnenberg.
Source/JavaScriptCore:
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpValueProfiling):
(JSC::CodeBlock::dumpArrayProfiling):
(JSC::CodeBlock::dumpRareCaseProfile):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::setNumParameters):
(JSC::CodeBlock::shrinkToFit):
(JSC::CodeBlock::shouldOptimizeNow):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::valueProfileForBytecodeOffset):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):
- bytecode/LazyOperandValueProfile.cpp:
- bytecode/LazyOperandValueProfile.h:
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- bytecode/ValueProfile.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::newArrayProfile):
(JSC::BytecodeGenerator::newArrayAllocationProfile):
(JSC::BytecodeGenerator::emitProfiledOpcode):
- jit/GPRInfo.h:
- jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
- jit/JIT.h:
- jit/JITArithmetic.cpp:
(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emit_op_div):
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_div):
- jit/JITCall.cpp:
(JSC::JIT::emitPutCallResult):
- jit/JITCall32_64.cpp:
(JSC::JIT::emitPutCallResult):
- jit/JITInlines.h:
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResultWithProfile):
(JSC::JIT::emitValueProfilingSite):
(JSC::JIT::emitArrayProfilingSiteForBytecodeIndex):
(JSC::JIT::emitArrayProfileStoreToHoleSpecialCase):
(JSC::JIT::emitArrayProfileOutOfBoundsSpecialCase):
(JSC::arrayProfileSaw):
(JSC::JIT::chooseArrayMode):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_argument_by_val):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_argument_by_val):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_get_from_scope):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_get_from_scope):
- llint/LLIntOfflineAsmConfig.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- profiler/ProfilerBytecodeSequence.cpp:
(JSC::Profiler::BytecodeSequence::BytecodeSequence):
- runtime/CommonSlowPaths.cpp:
Source/WTF:
- wtf/Platform.h:
- 12:35 PM Changeset in webkit [161363] by
-
- 4 edits in trunk/Tools
Gtk and Efl API test results confuse the dashboard
https://bugs.webkit.org/show_bug.cgi?id=126535
Reviewed by Tim Horton.
Added "API tests" step as "platform api tests".
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.platformAPITestResultsURLForIteration):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration):
(BuildbotIteration.prototype.update):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
(BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
- 12:33 PM Changeset in webkit [161362] by
-
- 5 edits in trunk/Source/WTF
Remove using directives for the std namespace from WTF
https://bugs.webkit.org/show_bug.cgi?id=126524
Reviewed by Alexey Proskuryakov.
Remove the using directives for the std namespace throughout the WTF code.
The more explicit std:: nested name specifier should be used instead.
- wtf/MediaTime.cpp:
(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::create):
(WTF::StringImpl::lower):
(WTF::StringImpl::upper):
(WTF::StringImpl::foldCase):
(WTF::StringImpl::find):
(WTF::StringImpl::findIgnoringCase):
(WTF::reverseFindInner):
(WTF::StringImpl::reverseFind):
(WTF::reverseFindIgnoringCaseInner):
(WTF::StringImpl::reverseFindIgnoringCase):
(WTF::StringImpl::replace):
(WTF::StringImpl::utf8ForCharacters):
(WTF::StringImpl::utf8ForRange):
- wtf/text/WTFString.cpp:
(WTF::String::append):
(WTF::String::appendInternal):
(WTF::String::insert):
(WTF::String::substringSharingImpl):
(WTF::String::fromUTF8):
(WTF::toIntegralType):
- wtf/win/RunLoopWin.cpp:
- 12:23 PM Changeset in webkit [161361] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack: jsStackLimit fixup should not exceed native stack limit.
https://bugs.webkit.org/show_bug.cgi?id=126487.
Reviewed by Michael Saboff.
In doCallToJavaScript, we fixup VM::m_jsStackLimit once we know what the
stackPointerAtVMEntry is. However, we also need to ensure that the fixed
up jsStackLimit does not exceed the native stack limit. This check was
missing, and resulted in an assertion failure when running testapi on
platforms that have smaller stacks. This is now fixed.
- llint/LowLevelInterpreter64.asm:
- 12:10 PM Changeset in webkit [161360] by
-
- 4 edits in trunk/Tools
build.webkit.org/dashboard should still function if localStorage is disabled
https://bugs.webkit.org/show_bug.cgi?id=126511
Reviewed by Alexey Proskuryakov.
If localStorage is disabled, we should carry on with a warning.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
Don't show the gear if localStorage isn't working.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
(QueueView.prototype._updateHiddenState):
Bail if localStorage isn't working.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
(Settings.prototype.available):
- 12:03 PM Changeset in webkit [161359] by
-
- 3 edits in trunk
[GTK] configure errors out when building with libc++
https://bugs.webkit.org/show_bug.cgi?id=126431
Reviewed by Martin Robinson.
Ease up the Clang and libstdc++ combination test to only fail if libstdc++ < 4.8.1 is actually used.
This allows for libc++ to be used as well. The test is moved into SetupCompilerFlags.m4 and is done
after the CXXFLAGS variable is properly set up, that is when all the C++ compiler options are determined.
- Source/autotools/CheckSystemAndBasicDependencies.m4:
- Source/autotools/SetupCompilerFlags.m4:
- 11:44 AM Changeset in webkit [161358] by
-
- 11 edits in trunk/Source/WebKit2
Add support to retrieve the autocorrection context.
https://bugs.webkit.org/show_bug.cgi?id=126479
Reviewed by Sam Weinig.
We are adding the support to retrieve the input context for autocorrection
and input methods on iOS. The implementation is provided both via synchronous
and asynchronous calls to the WebProcess.
- Platform/IPC/HandleMessage.h: Added template with zero input parameters and six reply parameters.
- UIProcess/API/ios/WKInteractionView.mm:
(autocorrectionData):
(-[WKInteractionView requestAutocorrectionRectsForString:withCompletionHandler:]):
(autocorrectionResult):
(-[WKInteractionView applyAutocorrection:toString:withCompletionHandler:]):
(autocorrectionContext):
(-[WKInteractionView requestAutocorrectionContextWithCompletionHandler:]):
(-[WKInteractionView hasMarkedText]):
(-[WKInteractionView _startAssistingNode]):
(+[WKAutocorrectionContext autocorrectionContextWithData:markedText:selectedText:afterText:selectedRangeInMarkedText:]):
(-[WKAutocorrectionContext dealloc]):
- UIProcess/AutoCorrectionCallback.h:
(WebKit::AutocorrectionContextCallback::create):
(WebKit::AutocorrectionContextCallback::~AutocorrectionContextCallback):
(WebKit::AutocorrectionContextCallback::performCallbackWithReturnValue):
(WebKit::AutocorrectionContextCallback::invalidate):
(WebKit::AutocorrectionContextCallback::AutocorrectionContextCallback):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetState):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::autocorrectionContextCallback):
(WebKit::WebPageProxy::requestAutocorrectionContext):
(WebKit::WebPageProxy::getAutocorrectionContext):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::computeAutocorrectionContext):
(WebKit::WebPage::requestAutocorrectionContext):
(WebKit::WebPage::getAutocorrectionContext):
- 11:29 AM Changeset in webkit [161357] by
-
- 19 edits1 add1 delete in trunk/Source
Move ViewState to WebCore
https://bugs.webkit.org/show_bug.cgi?id=126488
Reviewed by Anders Carlson.
This change also partial reverts handling of LayerHostingMode, making this
a separate message again. With hindsight the new way of doing this wasn't
in all ways simpler, and it won't make sense to move this to WebCore.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- page/ViewState.h: Added.
- Moved from WebKit2, will be used by Page & FocusController.
Source/WebKit2:
- Shared/ViewState.h: Removed.
- Moved to WebCore.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- Added layerHostingMode.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::viewLayerHostingMode):
- UIProcess/PageClient.h:
(WebKit::PageClient::viewLayerHostingMode):
- Revert isLayerWindowServerHosted -> viewLayerHostingMode.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- Added back m_layerHostingMode.
(WebKit::WebPageProxy::updateViewState):
- Removed IsLayerWindowServerHosted from ViewState.
(WebKit::WebPageProxy::viewStateDidChange):
- Added SetLayerHostingMode message.
(WebKit::WebPageProxy::initializeCreationParameters):
- Pass layerHostingMode.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::isInWindow):
(WebKit::WebPageProxy::isViewVisible):
- ViewState moved to WebCore.
- WebKit2.xcodeproj/project.pbxproj:
- Removed ViewState.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setLayerHostingMode):
(WebKit::PluginView::platformViewStateDidChange):
- Separated setLayerHostingMode from platformViewStateDidChange.
- WebProcess/Plugins/PluginView.h:
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::viewStateDidChange):
(WebKit::DrawingArea::setLayerHostingMode):
- Added virtual function, overridden in TiledCoreAnimationDrawingArea.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setLayerHostingMode):
- Separated setLayerHostingMode from platformViewStateDidChange.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::isVisible):
(WebKit::WebPage::layerHostingMode):
- ViewState moved to WebCore.
- WebProcess/WebPage/WebPage.messages.in:
- Added SetLayerHostingMode message.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::viewStateDidChange):
- viewStateDidChange no longer calls setLayerHostingMode (this is called by WebPage).
- 11:20 AM Changeset in webkit [161356] by
-
- 5 edits in trunk/Source/JavaScriptCore
LLInt shouldn't check for ENABLE(JIT).
Rubber stamped by Mark Hahnenberg.
- llint/LLIntCommon.h:
- llint/LLIntOfflineAsmConfig.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
- 11:19 AM Changeset in webkit [161355] by
-
- 2 edits in trunk/Tools
Set VSINSTALLDIR in win ews start script.
https://bugs.webkit.org/show_bug.cgi?id=126407
Reviewed by Brent Fulgham.
- EWSTools/start-queue-win.sh:
- 11:01 AM Changeset in webkit [161354] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] [CMake] Parallel builds still fail when building WebKit2 GObject API unit tests
https://bugs.webkit.org/show_bug.cgi?id=126465
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/tests/CMakeLists.txt: Explicitly link the libWebKit2APITestCore static object against
WebKit2, which seems to be necessary on my new system. Also create an explicit dependency between the
injected bundle tests and WebKit2, because they need to use the generated headers.
- 10:56 AM Changeset in webkit [161353] by
-
- 4 edits in trunk/Source/JavaScriptCore
LLInt shouldnt check for ENABLE(JAVASCRIPT_DEBUGGER).
Rubber stamped by Mark Hahnenberg.
- debugger/Debugger.h:
(JSC::Debugger::Debugger):
- llint/LLIntOfflineAsmConfig.h:
- llint/LowLevelInterpreter.asm:
- 10:33 AM Changeset in webkit [161352] by
-
- 2 edits in trunk/Tools
Adding myself as a reviewer.
Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 10:33 AM Changeset in webkit [161351] by
-
- 9 edits2 adds in trunk
[CMake] [GTK] Fix the build for the WebKitGTK+ developer configuration
https://bugs.webkit.org/show_bug.cgi?id=126505
Reviewed by Gustavo Noronha Silva.
.:
- Source/cmake/FindGLIB.cmake: Add support for finding the gio-unix include directory location.
- Source/cmake/FindGUdev.cmake: Added.
- Source/cmake/FindGeoClue.cmake: Added.
- Source/cmake/OptionsGTK.cmake: When gamepad is enabled look for gio-unix and GUdev. When
geolocation is enabled look for GeoClue.
Source/WebCore:
- CMakeLists.txt: Add missing IDLS and source files to the lists.
- PlatformGTK.cmake: Add missing include directories and source files to the lists.
Use the GeoClue, GUdev, and gio-unix include paths and libraries and sort the list
of WebCore include directories.
- UseJSC.cmake: Align the sourced list with the contents of the bindings/js directory.
Source/WebKit:
- PlatformGTK.cmake: Add the geoclue platform directory to the include directory list.
- 10:25 AM Changeset in webkit [161350] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Refactor NSActivity handling code from ChildProcess to UserActivity
https://bugs.webkit.org/show_bug.cgi?id=126330
Unreviewed speculative Windows build fix.
- WebCore.vcxproj/WebCore.vcxproj:
- Added UserActivity.cpp/.h.
- 9:41 AM Changeset in webkit [161349] by
-
- 2 edits in trunk/Source/WTF
DoublyLinkedLists can't be concatenated
https://bugs.webkit.org/show_bug.cgi?id=125976
Reviewed by Filip Pizlo.
- wtf/DoublyLinkedList.h:
(WTF::DoublyLinkedList<T>::append):
- 9:37 AM Changeset in webkit [161348] by
-
- 3 edits in trunk/Source/WebCore
[Win] Link error.
https://bugs.webkit.org/show_bug.cgi?id=126526
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-01-06
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.vcxproj: Include UserActivity files in build.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- 9:22 AM Changeset in webkit [161347] by
-
- 2 edits in trunk/Source/WebKit/mac
Mountain Lion build fix after r161332.
- Carbon/HIWebView.h: Mountain Lion's version of CF_AVAILABLE_MAC doesn't accept a message
argument so remove it.
- 8:29 AM Changeset in webkit [161346] by
-
- 5 edits in trunk/Source
Versioning.
- 8:25 AM Changeset in webkit [161345] by
-
- 1 copy in tags/Safari-538.11
New Tag.
- 7:23 AM Changeset in webkit [161344] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations:
Mark accessibility/menu-list-sends-change-notification.html as flaky.
- 7:07 AM Changeset in webkit [161343] by
-
- 2 edits in trunk/Source/WebCore
[Nix] Adding screenRect implementation to PlatformScreenNix
https://bugs.webkit.org/show_bug.cgi?id=126231
Reviewed by Csaba Osztrogonác.
No new tests needed.
- platform/nix/PlatformScreenNix.cpp:
(WebCore::screenRect):
- 6:27 AM Changeset in webkit [161342] by
-
- 5 edits in trunk/Source/WebCore
[Nix] Adding missing platform #ifs to WebCore files
https://bugs.webkit.org/show_bug.cgi?id=126227
Reviewed by Csaba Osztrogonác.
No new tests needed.
- loader/EmptyClients.h:
- page/ChromeClient.h:
- page/DragController.cpp:
(WebCore::DragController::startDrag):
- platform/LocalizedStrings.h:
- 6:07 AM Changeset in webkit [161341] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding failure expectations for the set of currently failing tests.
- platform/gtk/TestExpectations:
- 4:44 AM Changeset in webkit [161340] by
-
- 2 edits in trunk/Tools
Unreviewed. Unbreaking JSC tests after r161328.
- Scripts/webkitdirs.pm:
(cmakeBasedPortName): Only recognize the GTK port as CMake-based if actually building
through the CMake build system (i.e. passing --gtkcmake to build-webkit).
- 3:22 AM Changeset in webkit [161339] by
-
- 2 edits in trunk/Source/WebCore
[Nix] Adding new strings to LocalizedStringsNix
https://bugs.webkit.org/show_bug.cgi?id=126228
Reviewed by Csaba Osztrogonác.
No new tests needed.
- platform/nix/LocalizedStringsNix.cpp:
(WebCore::submitButtonDefaultLabel):
(WebCore::inputElementAltText):
(WebCore::resetButtonDefaultLabel):
(WebCore::defaultDetailsSummaryText):
(WebCore::searchableIndexIntroduction):
(WebCore::fileButtonChooseFileLabel):
(WebCore::fileButtonChooseMultipleFilesLabel):
(WebCore::fileButtonNoFileSelectedLabel):
(WebCore::fileButtonNoFilesSelectedLabel):
(WebCore::contextMenuItemTagOpenLinkInNewWindow):
(WebCore::contextMenuItemTagDownloadLinkToDisk):
(WebCore::contextMenuItemTagCopyLinkToClipboard):
(WebCore::contextMenuItemTagOpenImageInNewWindow):
(WebCore::contextMenuItemTagDownloadImageToDisk):
(WebCore::contextMenuItemTagCopyImageToClipboard):
(WebCore::contextMenuItemTagCopyImageUrlToClipboard):
(WebCore::contextMenuItemTagOpenVideoInNewWindow):
(WebCore::contextMenuItemTagOpenAudioInNewWindow):
(WebCore::contextMenuItemTagDownloadVideoToDisk):
(WebCore::contextMenuItemTagDownloadAudioToDisk):
(WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
(WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
(WebCore::contextMenuItemTagToggleMediaControls):
(WebCore::contextMenuItemTagShowMediaControls):
(WebCore::contextMenuitemTagHideMediaControls):
(WebCore::contextMenuItemTagToggleMediaLoop):
(WebCore::contextMenuItemTagEnterVideoFullscreen):
(WebCore::contextMenuItemTagMediaPlay):
(WebCore::contextMenuItemTagMediaPause):
(WebCore::contextMenuItemTagMediaMute):
(WebCore::contextMenuItemTagOpenFrameInNewWindow):
(WebCore::contextMenuItemTagCopy):
(WebCore::contextMenuItemTagDelete):
(WebCore::contextMenuItemTagSelectAll):
(WebCore::contextMenuItemTagUnicode):
(WebCore::contextMenuItemTagInputMethods):
(WebCore::contextMenuItemTagGoBack):
(WebCore::contextMenuItemTagGoForward):
(WebCore::contextMenuItemTagStop):
(WebCore::contextMenuItemTagReload):
(WebCore::contextMenuItemTagCut):
(WebCore::contextMenuItemTagPaste):
(WebCore::contextMenuItemTagNoGuessesFound):
(WebCore::contextMenuItemTagIgnoreSpelling):
(WebCore::contextMenuItemTagLearnSpelling):
(WebCore::contextMenuItemTagSearchWeb):
(WebCore::contextMenuItemTagLookUpInDictionary):
(WebCore::contextMenuItemTagOpenLink):
(WebCore::contextMenuItemTagIgnoreGrammar):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckSpelling):
(WebCore::contextMenuItemTagCheckSpellingWhileTyping):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagFontMenu):
(WebCore::contextMenuItemTagBold):
(WebCore::contextMenuItemTagItalic):
(WebCore::contextMenuItemTagUnderline):
(WebCore::contextMenuItemTagOutline):
(WebCore::contextMenuItemTagInspectElement):
(WebCore::contextMenuItemTagRightToLeft):
(WebCore::contextMenuItemTagLeftToRight):
(WebCore::contextMenuItemTagWritingDirectionMenu):
(WebCore::contextMenuItemTagTextDirectionMenu):
(WebCore::contextMenuItemTagDefaultDirection):
(WebCore::searchMenuNoRecentSearchesText):
(WebCore::searchMenuRecentSearchesText):
(WebCore::searchMenuClearRecentSearchesText):
(WebCore::AXDefinitionText):
(WebCore::AXDescriptionListText):
(WebCore::AXDescriptionListTermText):
(WebCore::AXDescriptionListDetailText):
(WebCore::AXFooterRoleDescriptionText):
(WebCore::AXSearchFieldCancelButtonText):
(WebCore::AXButtonActionVerb):
(WebCore::AXRadioButtonActionVerb):
(WebCore::AXTextFieldActionVerb):
(WebCore::AXCheckedCheckBoxActionVerb):
(WebCore::AXUncheckedCheckBoxActionVerb):
(WebCore::AXLinkActionVerb):
(WebCore::unknownFileSizeText):
(WebCore::imageTitle):
(WebCore::AXListItemActionVerb):
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
(WebCore::localizedMediaTimeDescription):
(WebCore::mediaElementLoadingStateText):
(WebCore::mediaElementLiveBroadcastStateText):
(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageRangeOverflowText):
(WebCore::validationMessageRangeUnderflowText):
(WebCore::validationMessageStepMismatchText):
(WebCore::validationMessageTooLongText):
(WebCore::validationMessageTypeMismatchText):
(WebCore::validationMessageTypeMismatchForEmailText):
(WebCore::validationMessageTypeMismatchForMultipleEmailText):
(WebCore::validationMessageTypeMismatchForURLText):
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageValueMissingForCheckboxText):
(WebCore::validationMessageValueMissingForFileText):
(WebCore::validationMessageValueMissingForMultipleFileText):
(WebCore::validationMessageValueMissingForRadioText):
(WebCore::validationMessageValueMissingForSelectText):
(WebCore::validationMessageBadInputForNumberText):
(WebCore::missingPluginText):
(WebCore::AXMenuListPopupActionVerb):
(WebCore::AXMenuListActionVerb):
(WebCore::multipleFileUploadText):
(WebCore::crashedPluginText):
(WebCore::blockedPluginByContentSecurityPolicyText):
(WebCore::insecurePluginVersionText):
(WebCore::inactivePluginText):
(WebCore::unacceptableTLSCertificate):
(WebCore::textTrackClosedCaptionsText):
(WebCore::textTrackSubtitlesText):
(WebCore::textTrackOffMenuItemText):
(WebCore::textTrackAutomaticMenuItemText):
(WebCore::textTrackNoLabelText):
(WebCore::snapshottedPlugInLabelTitle):
(WebCore::snapshottedPlugInLabelSubtitle):
- 3:17 AM Changeset in webkit [161338] by
-
- 37 edits in trunk/Source
Use unsigned consistently, and check for invalid casts when calling into SharedBuffer from other code.
https://bugs.webkit.org/show_bug.cgi?id=124579
Patch by László Langó <lango@inf.u-szeged.hu> on 2014-01-06
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.exp.in:
- loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::didReceiveData):
- loader/NetscapePlugInStreamLoader.h:
- loader/PingLoader.h:
- loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::ResourceBuffer):
- loader/ResourceBuffer.h:
(WebCore::ResourceBuffer::create):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::addDataOrBuffer):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didReceiveDataOrBuffer):
(WebCore::ResourceLoader::willStopBufferingData):
- loader/ResourceLoader.h:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveData):
- loader/SubresourceLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didReceiveData):
- loader/appcache/ApplicationCacheGroup.h:
- loader/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::didReceiveDataArray):
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::SharedBuffer):
- platform/SharedBuffer.h:
(WebCore::SharedBuffer::create):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(ResourceHandleStreamingClient::didReceiveData):
- platform/network/BlobResourceHandle.cpp:
- platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::didReceiveData):
(WebCore::ResourceHandleClient::willStopBufferingData):
- platform/network/SynchronousLoaderClient.cpp:
(WebCore::SynchronousLoaderClient::didReceiveData):
- platform/network/SynchronousLoaderClient.h:
- platform/network/blackberry/BlobStream.cpp:
(WebCore::BlobStream::didReceiveData):
- platform/network/blackberry/BlobStream.h:
- platform/network/blackberry/ResourceHandleBlackBerry.cpp:
(WebCore::WebCoreSynchronousLoader::didReceiveData):
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::WebCoreSynchronousLoader::didReceiveData):
- platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
(-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willStopBufferingData:]):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::WebCoreSynchronousLoader::didReceiveData):
- platform/network/win/ResourceHandleWin.cpp:
(WebCore::WebCoreSynchronousLoader::didReceiveData):
Source/WebKit/gtk:
- webkit/webkitdownload.cpp:
(DownloadClient::didReceiveData):
Source/WebKit/win:
- WebKitDLL.cpp:
(loadResourceIntoBuffer):
Source/WebKit2:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveData):
(WebKit::NetworkResourceLoader::willStopBufferingData):
- NetworkProcess/NetworkResourceLoader.h:
- Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::didReceiveData):
- 2:39 AM Changeset in webkit [161337] by
-
- 4 edits in trunk/Source/WebCore
RenderBlock::clone() should return RenderPtr.
<https://webkit.org/b/126513>
Reviewed by Antti Koivisto.
- rendering/RenderBlock.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone):
Tweaked to return RenderPtr<RenderBlock>.
(WebCore::RenderBlock::splitBlocks):
Store cloned RenderBlocks in RenderPtrs. Use leakPtr() to sink
them into ownership-taking APIs that still use raw pointers.
- rendering/RenderPtr.h:
Add a simple static_pointer_cast for RenderPtr&&.
- 1:49 AM Changeset in webkit [161336] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Fix ChangeLog authors that got mixed up in last commit.
- 1:47 AM Changeset in webkit [161335] by
-
- 3 edits in trunk/Source/WebCore
RenderInline::clone() should return RenderPtr.
<https://webkit.org/b/126514>
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2014-01-06
Reviewed by Antti Koivisto.
- rendering/RenderInline.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clone):
Tweaked to return RenderPtr<RenderInline>.
(WebCore::RenderInline::splitInlines):
Store cloned RenderInlines in RenderPtrs. Use leakPtr() to sink
them into ownership-taking APIs that still use raw pointers.
- 1:04 AM Changeset in webkit [161334] by
-
- 3 edits3 adds in trunk
<hr> appears gray instead of green because of color attribute is defined followed by noshade attribute
https://bugs.webkit.org/show_bug.cgi?id=17674
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2014-01-06
Reviewed by Simon Fraser.
Source/WebCore:
The noshade attribute is a boolean attribute and when set on hr element
it shows a gray color. When there is color attribute the default gray
color should be replaced by the color mentioned by the color attribute.
Firefox and IE show the same behaviour but Webkit is different. Making
the behaviour of Webkit similiar to Firefox and IE's behaviour.
Test: fast/dom/HTMLHrElement/hr-color-noshade-attribute.html
- html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::collectStyleForPresentationAttribute):
When the color attribute is present that value is applied and the
default gray color is ignored. Incase of no color attribute the default
gray color is applied.
LayoutTests:
- fast/dom/HTMLHrElement: Added.
- fast/dom/HTMLHrElement/hr-color-noshade-attribute-expected.txt: Added.
- fast/dom/HTMLHrElement/hr-color-noshade-attribute.html: Added.
Added new test cases to test the functionality of noshade and color
attribute of hr element when color attribute is present along with
noshade attribute, invalid color attribute and color noshade attributes
added via javascript.
- 12:56 AM Changeset in webkit [161333] by
-
- 2 edits in trunk
[GTK] Use libc++ for C++11 on darwin
https://bugs.webkit.org/show_bug.cgi?id=126325
Reviewed by Martin Robinson.
- Source/autotools/SetupCompilerFlags.m4: Don't default to libstdc++ when compiling with Clang.
Instead, the compiler should determine itself what standard library to use, except on Darwin,
where libc++ should be enforced. The standard library of user's choosing can still be enforced
through the CXXFLAGS environment variable.
- 12:15 AM Changeset in webkit [161332] by
-
- 13 edits2 adds in trunk/Source
<https://webkit.org/b/126499> Move WebKit off the legacy WebKit availability macros
The legacy WebKit availability macros are verbose, confusing, and provide no benefit
over using the system availability macros directly. The original vision was that
they'd serve a cross-platform purpose but that never came to be.
Since WebKit1 is API on OS X but SPI on iOS, some indirection is still needed in the
availability macros to allow the headers to advertise the API as unavailable on OS X
without interfering with the ability to build on iOS. This is achieved by defining
WEBKIT-prefixed versions of the Foundation availability macros that are defined to
their NS-prefixed equivalents. The installed headers are post-processed to map these
macros back to their Foundation equivalents.
Part of <rdar://problem/15512304>.
Source/WebCore:
Reviewed by Sam Weinig.
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/WebKitAvailability.h: Added. This lives at the WebCore level since it
will be needed by the Objective-C DOM bindings.
Source/WebKit:
Reviewed by Sam Weinig.
- WebKit.xcodeproj/project.pbxproj: Change the Postprocess Headers build phase to
invoke mac/postprocess-headers.sh.
Source/WebKit/mac:
The OS X version used in the new availability macros is based on the mapping in
JavaScriptCore/WebKitAvailability.h.
Reviewed by Sam Weinig.
- Carbon/CarbonUtils.h:
- Carbon/HIWebView.h:
- MigrateHeaders.make: Migrate WebKitAvailability.h from WebCore as an API header.
- Plugins/WebPlugin.h:
- Plugins/WebPluginViewFactory.h:
- WebView/WebFrameLoadDelegate.h:
- WebView/WebResourceLoadDelegatePrivate.h:
- WebView/WebUIDelegate.h:
- postprocess-headers.sh: Added. Extracted from the Xcode project. Extended to map the
WEBKIT-prefixed macros to their NS-prefixed equivalents on OS X and to remove them on iOS.
Jan 5, 2014:
- 11:54 PM Changeset in webkit [161331] by
-
- 4 edits in trunk/Source/WebKit/efl
[EFL] Fix failing WebKit1 API test of ewk_view_setting_tiled_backing_store
https://bugs.webkit.org/show_bug.cgi?id=126509
Reviewed by Gyuyoung Kim.
In WebKit1 EFL port, unit test was using a webview based on tiled backing store,
so ewk_view_setting_tiled_backing_store_enabled_set() was set as true as default.
As we do not need to use tiled backing store, we disable tiled backing store
and remove unnecessary EwkViewType in unit test webview.
- tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::init):
- tests/UnitTestUtils/EWKTestView.h:
- tests/test_ewk_view.cpp: Fix wrong comment in the unit test.
- 8:18 PM Changeset in webkit [161330] by
-
- 6 edits in trunk
[JS] Implement Promise.race()
https://bugs.webkit.org/show_bug.cgi?id=126506
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- runtime/CommonIdentifiers.h:
Add identifier for "cast".
- runtime/JSPromiseConstructor.cpp:
(JSC::abruptRejection):
Helper for the RejectIfAbrupt abstract operation.
(JSC::JSPromiseConstructorFuncRace):
Add implementation of Promise.race()
LayoutTests:
Enabled and fix the existing Promise.race() test case.
- Promise.race() and Promise.race({}) should reject by my reading of the spec.
- js/dom/Promise-static-race-expected.txt:
- js/dom/Promise-static-race.html:
- 8:09 PM Changeset in webkit [161329] by
-
- 3 edits in trunk/Source/WebKit2
Add encoding of ViewportConstraint and ScrollingParameter types
https://bugs.webkit.org/show_bug.cgi?id=126497
Reviewed by Andreas Kling.
Add encoding/decoding of ScrollableAreaParameters, FixedPositionViewportConstraints
and StickyPositionViewportConstraints.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<WebCore::ScrollableAreaParameters>::encode):
(IPC::ArgumentCoder<WebCore::ScrollableAreaParameters>::decode):
(IPC::ArgumentCoder<WebCore::FixedPositionViewportConstraints>::encode):
(IPC::ArgumentCoder<WebCore::FixedPositionViewportConstraints>::decode):
(IPC::ArgumentCoder<WebCore::StickyPositionViewportConstraints>::encode):
(IPC::ArgumentCoder<WebCore::StickyPositionViewportConstraints>::decode):
- Shared/WebCoreArgumentCoders.h:
- 8:09 PM Changeset in webkit [161328] by
-
- 3 edits in trunk/Tools
[GTK][CMake] Add support for building the GTK+ port with cmake to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=126212
Reviewed by Daniel Bates.
Allow building the GTK+ cmake port with --gtkcmake.
- Scripts/build-webkit: Use the new isGtkCMake function to head down the CMake path
when appropriate. Skip the autotoos path when isGtkAutotools is false.
- Scripts/webkitdirs.pm: Add an isGtkCMake path in addition to the newly renamed isGtkAutotools.
Add isGtk which checks isGtkCMake isGtkAutotools (determineArchitecture): Use the CMake path for GTK+ when appropriate.
(argumentsForConfiguration): use --gtkcmake when appropriate.
(jscProductDir): Look in the CMake directory when appropriate.
(builtDylibPathForName): CMake builds the library into a different directory, so handle that.
(determineIsGtkCMake): Added.
(isGtkCMake): Added.
(isGtkAutotools): Renamed from isGtk.
(isGtk): New function which returns isGtkAutotools isGtkCMake. (determineIsGtkAutotools): Renamed from determineIsGtk.
(cmakeBasedPortName): Added a GTK+ path.
- 8:08 PM Changeset in webkit [161327] by
-
- 17 edits1 move in trunk/Source
Move responsibility for remote layer tree committing to RemoteLayerTreeDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=126501
Source/WebCore:
Reviewed by Sam Weinig.
Add type-safe casting to GraphicsLayer.
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::isGraphicsLayerCA):
(WebCore::GraphicsLayer::isGraphicsLayerCARemote):
- platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA::isGraphicsLayerCA):
Source/WebKit2:
Reviewed by Sam Weinig.
Soon we shall need to do atomic commits of both the remote layer tree, and
the remote scrolling tree. Pave the way by moving responsibility for remote
layer tree committing to RemoteLayerTreeDrawingArea.
So move the flushing logic from RemoteLayerTreeHost to RemoteLayerTreeDrawingArea.
After this change, RemoteLayerTreeHost doesn't do much and could possibly be
removed in future.
Also add type-safe casting to GraphicsLayer and DrawingArea.
- DerivedSources.make: Out with RemoteLayerTreeHost, in with RemoteLayerTreeDrawingAreaProxy
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
(WebKit::RemoteLayerTreeDrawingAreaProxy::remoteLayerTreeHost):
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.messages.in: Renamed from Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.messages.in.
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy): Add message receiver.
(WebKit::RemoteLayerTreeDrawingAreaProxy::~RemoteLayerTreeDrawingAreaProxy): Remove message receiver.
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree): Hand the transaction off to the layer
tree host.
- UIProcess/mac/RemoteLayerTreeHost.h:
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::RemoteLayerTreeHost): No longer a message receiver.
(WebKit::RemoteLayerTreeHost::~RemoteLayerTreeHost):
(WebKit::RemoteLayerTreeHost::updateLayerTree):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::type):
- WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::RemoteLayerTreeContext):
(WebKit::RemoteLayerTreeContext::flushOutOfTreeLayers):
(WebKit::RemoteLayerTreeContext::buildTransaction):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::setRootCompositingLayer):
(WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::RemoteLayerTreeDrawingArea::forceRepaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
(WebKit::RemoteLayerTreeDrawingArea::layerFlushTimerFired):
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
- 5:29 PM Changeset in webkit [161326] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: ARM64 Fix other prologue and epilogue macros in LLInt
https://bugs.webkit.org/show_bug.cgi?id=126507
Reviewed by Mark Lam.
Fixed preserveCallerPCAndCFR() and restoreCallerPCAndCFR() for ARM64. Fixed
functionPrologue() so that the new callframe is set up from the stack pointer.
- llint/LowLevelInterpreter.asm:
- 4:25 PM Changeset in webkit [161325] by
-
- 13 edits in trunk
[GTK] [CMake] Ensure that the autotools build and the CMake install the same files
https://bugs.webkit.org/show_bug.cgi?id=116379
Reviewed by Gustavo Noronha Silva.
.:
- Source/PlatformGTK.cmake: Install the documentation.
- Source/cmake/OptionsCommon.cmake: Add a LIBEXEC variable for WebKit2 executables, and
don't use the default locations on GTK+. We will get them from the CMake-provided GNU installation
variables.
- Source/cmake/OptionsGTK.cmake: Setup the installation variables using the ones provided
by CMake's GNU installation directory support. Fix the definition of DATADIR. Always install
the jsc binary.
Source/JavaScriptCore:
- PlatformGTK.cmake: Install API headers, gir files, and the pkg-config file.
Source/WebCore:
- PlatformGTK.cmake: Reformat some install directives to be consistent with the rest of them.
Install the GObject DOM bindings headers.
Source/WebKit:
- PlatformGTK.cmake: Install API headers, gir files, and the pkg-config file. Move
a couple installed and generated headers to the installed headers list.
Source/WebKit2:
- CMakeLists.txt: Install the plugin process to the new LIBEXEC directory, which
for non-GTK+ platforms is the same as EXEC.
- PlatformGTK.cmake: Install API headers, gir files, and the pkg-config file. Move
a couple installed and generated headers to the installed headers list. Rename the
headers list to be consistent with the WebKit1 build. No longer use a variable for
the name of the plugin process, as it's unnecessary.
- 11:17 AM Changeset in webkit [161324] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[GTK] Updated Dutch translation
https://bugs.webkit.org/show_bug.cgi?id=126365
Patch by Reinout van Schouwen <reinouts@gnome.org> on 2014-01-05
Reviewed by Gustavo Noronha.
- nl.po: Updated.
- 3:45 AM Changeset in webkit [161323] by
-
- 4 edits in trunk/Source/WebCore
Use lineageOfType to simplify two rendering helpers.
<https://webkit.org/b/126498>
Reviewed by Antti Koivisto.
- rendering/RenderRuby.cpp:
(WebCore::findRubyRunParent):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::findTreeRootObject):
Simplify two functions that walk their parent chain to find the
closest ancestor of a certain type.
- rendering/RenderRubyRun.h:
Add requisite isRendererOfType<RenderRubyRun>().
- 2:34 AM Changeset in webkit [161322] by
-
- 5 edits in trunk
[GTK] Stop installing WebKit2 C API headers
https://bugs.webkit.org/show_bug.cgi?id=126489
Reviewed by Martin Robinson.
.:
- GNUmakefile.am:
Source/WebKit2:
We are not actually maintaining the API/ABI compatibility of the
WebKit2 C API, it's only used internally by the public GTK+ API
and nobody is using it.
- GNUmakefile.am:
- GNUmakefile.list.am:
- 1:46 AM Changeset in webkit [161321] by
-
- 2 edits in trunk/Source/WebCore
Fix the Mac build too.
- page/PageThrottler.h:
- 1:27 AM Changeset in webkit [161320] by
-
- 2 edits in trunk/Source/WebCore
Weekend URTBF after r161319 to make non Mac builds work again.
- page/PageThrottler.h:
- 12:28 AM Changeset in webkit [161319] by
-
- 13 edits in trunk/Source
Move process suppression of WebProcess to Page (from UIProcess)
https://bugs.webkit.org/show_bug.cgi?id=126480
Reviewed by Sam Weinig.
Let each page take a UserActivity rather than having to coalesce this state, and take different activity
tokens for normal visibility and suppression disabled, so we can see why the process is not suppressed.
Source/WebCore:
- WebCore.exp.in:
- page/Page.cpp:
(WebCore::Page::setIsVisuallyIdle):
- page/Page.h:
- setThrottled -> setIsVisuallyIdle.
- page/PageThrottler.cpp:
(WebCore::PageThrottler::PageThrottler):
- Initialize m_visuallyNonIdle.
(WebCore::PageThrottler::~PageThrottler):
- setThrottled -> setIsVisuallyIdle.
(WebCore::PageThrottler::setIsVisuallyIdle):
- Use m_visuallyNonIdle to disable supression when the page is not visually idle.
- page/PageThrottler.h:
- setThrottled -> setIsVisuallyIdle, added m_visuallyNonIdle.
Source/WebKit2:
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::platformInitialize):
- Don't start with process supression disabled; this is unnecessary, message from the UIProcess should wake.
- UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::updateProcessSuppressionState):
- Don't send explicit messages to supress the WebProcess, it handles this for itself.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- call setIsVisuallyIdle.
(WebKit::WebPage::setViewState):
- call setIsVisuallyIdle.
(WebKit::WebPage::updatePreferences):
- Use m_suppressionDisabled to disable supression if the WebPreference is set.
(WebKit::WebPage::setIsVisuallyIdle):
- setThrottled -> setIsVisuallyIdle.
- WebProcess/WebPage/WebPage.h:
- setThrottled -> setIsVisuallyIdle, added m_suppressionDisabled.
- WebProcess/WebProcess.cpp:
- WebProcess/WebProcess.h:
(WebKit::WebProcess::shouldForceScreenFontSubstitution):
- Removed setProcessSuppressionEnabled - WebPage now detects the supression change.
Jan 4, 2014:
- 11:29 PM Changeset in webkit [161318] by
-
- 6 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: ARM64 needs push/pop pair macro assembler instructions
https://bugs.webkit.org/show_bug.cgi?id=126474
Reviewed by Mark Lam.
Added templated ldp() and stp() instruction generators to the ARM64 assembler.
Added popPair() and pushPair() to the ARM64 macro assembler. Added ARM64
version of emitFunctionPrologue() and emitFunctionEpilogue() to AssemblyHelpers.h
that use the pushPair() and popPair() macro instructions. Added disassembler support
for the newly added load/store pair instructions.
Verified that we correctly generate the new instructions and that they disassemble
the same as what the debugger shows.
- assembler/ARM64Assembler.h:
(JSC::isInt7):
(JSC::isInt11):
(JSC::PairPostIndex::PairPostIndex):
(JSC::PairPostIndex::operator int):
(JSC::PairPreIndex::PairPreIndex):
(JSC::PairPreIndex::operator int):
(JSC::ARM64Assembler::memPairOffsetShift):
(JSC::ARM64Assembler::ldp):
(JSC::ARM64Assembler::stp):
(JSC::ARM64Assembler::loadStoreRegisterPairPostIndex):
(JSC::ARM64Assembler::loadStoreRegisterPairPreIndex):
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::popPair):
(JSC::MacroAssemblerARM64::pushPair):
- disassembler/ARM64/A64DOpcode.cpp:
(JSC::ARM64Disassembler::A64DOpcode::appendRegisterName):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreRegisterPair::opName):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreRegisterPair::format):
- disassembler/ARM64/A64DOpcode.h:
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreRegisterPair::rt2):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreRegisterPair::immediate7):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreRegisterPair::offsetMode):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreRegisterPair::lBit):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitFunctionPrologue):
(JSC::AssemblyHelpers::emitFunctionEpilogue):
- 6:15 PM Changeset in webkit [161317] by
-
- 2 edits in trunk/Source/JavaScriptCore
Use Compiler macros instead of raw "final" and "override"
https://bugs.webkit.org/show_bug.cgi?id=126490
Patch by Yusuke Suzuki <Yusuke Suzuki> on 2014-01-04
Reviewed by Sam Weinig.
- runtime/JSPromiseReaction.cpp:
- 4:28 PM Changeset in webkit [161316] by
-
- 4 edits in trunk/Source/WebCore
Move a few more functions from RenderBlock to RenderBlockFlow
https://bugs.webkit.org/show_bug.cgi?id=126494
Reviewed by Andreas Kling.
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::adjustInlineDirectionLineBounds):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::textAlignmentForLine):
(WebCore::RenderBlockFlow::updateLogicalWidthForAlignment):
(WebCore::RenderBlockFlow::startAlignedOffsetForLine):
These are only used by RenderBlockFlow, so move them there.
- 1:48 PM Changeset in webkit [161315] by
-
- 9 edits in trunk/Source/WebCore
Prepare the ScrollingTree for remote use
https://bugs.webkit.org/show_bug.cgi?id=126493
Reviewed by Sam Weinig.
When committing the scrolling tree, we clone the ScrollingStateTree
to hand off to another thread, or (in future) to encode to send to the
UI process. During this cloning process, two types of layer transformations
take place: for threaded scrolling, we replace GraphicsLayer with PlatformLayers.
For remote scrolling, we'll replace GraphicsLayers with PlatformLayerIDs.
Allow the ScrollingCoordinator to specify which type of transformation occurs
by giving ScrollingStateTree a LayerRepresentation::Type member,
which is consulted during ScrollingStateNode cloning.
Also only copy layers that have changed to avoid setting dirty bits.
Expose some other stuff on ScrollingStateTree which will be needed for
remote scrolling.
- page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::syncLayerPositionForViewportRect):
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::ScrollingStateNode):
- page/scrolling/ScrollingStateNode.h:
(WebCore::LayerRepresentation::operator GraphicsLayer::PlatformLayerID):
(WebCore::LayerRepresentation::toRepresentation):
(WebCore::ScrollingStateNode::changedProperties):
(WebCore::ScrollingStateNode::setChangedProperties):
(WebCore::ScrollingStateNode::parentNodeID):
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
- page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::syncLayerPositionForViewportRect):
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::ScrollingStateTree):
(WebCore::ScrollingStateTree::commit):
(WebCore::ScrollingStateTree::setRemovedNodes):
(WebCore::ScrollingStateTree::stateNodeForID):
- page/scrolling/ScrollingStateTree.h:
(WebCore::ScrollingStateTree::nodeCount):
(WebCore::ScrollingStateTree::nodeMap):
(WebCore::ScrollingStateTree::preferredLayerRepresentation):
(WebCore::ScrollingStateTree::setPreferredLayerRepresentation):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::commitTreeState):
- 12:53 PM Changeset in webkit [161314] by
-
- 6 edits in trunk/Source/WebCore
Move LineBreaker functions to LineBreaker.cpp
https://bugs.webkit.org/show_bug.cgi?id=126491
Reviewed by Simon Fraser.
- Moves LineBreaker::nextLineBreak() and LineBreaker::nextSegmentBreak() to LineBreaker.cpp from RenderBlockLineLayout.cpp
- Moves requiresIndent() to LineWidth.h/cpp from RenderBlockLineLayout.cpp so it can be shared.
- Adds missing inline specifier to BreakingContext::handleEndOfLine() to avoid duplicate symbols.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::updateLogicalInlinePositions):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
- rendering/line/BreakingContextInlineHeaders.h:
(WebCore::BreakingContext::handleEndOfLine):
- rendering/line/LineBreaker.cpp:
(WebCore::LineBreaker::nextLineBreak):
(WebCore::LineBreaker::nextSegmentBreak):
- rendering/line/LineWidth.cpp:
(WebCore::requiresIndent):
- rendering/line/LineWidth.h:
- 10:31 AM Changeset in webkit [161313] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: ARM64 add of stack pointer not valid as second source operand
https://bugs.webkit.org/show_bug.cgi?id=126486
Reviewed by Mark Lam.
Swap the source operands in add64() if the second argument is the stack pointer
to work around ARM64 limitations for using the stack pointer as a second source operand.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::add64):
- 10:30 AM Changeset in webkit [161312] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: slowPathFor() should emit an epilogue instead of popping the callFrameRegister
https://bugs.webkit.org/show_bug.cgi?id=126478
Reviewed by Mark Lam.
Changed the pop(callFrameRegister) to emitFunctionEpilogue().
- jit/ThunkGenerators.cpp:
(JSC::slowPathFor):
- 9:46 AM Changeset in webkit [161311] by
-
- 8 edits1 add in trunk
[GTK] [CMake] Improve the way we locate gobject-introspection
https://bugs.webkit.org/show_bug.cgi?id=126452
Reviewed by Philippe Normand.
.:
- Source/cmake/FindGObjectIntrospection.cmake: Added.
- Source/cmake/OptionsGTK.cmake: Load the new FindGObjectIntrospection file.
Source/JavaScriptCore:
- PlatformGTK.cmake: Use the new introspection variables.
Source/WebKit:
- PlatformGTK.cmake: Use the new introspection variables.
Source/WebKit2:
- PlatformGTK.cmake: Use the new introspection variables.
- 9:44 AM Changeset in webkit [161310] by
-
- 6 edits in trunk
[GTK] [CMake] Fix the video and audio build
https://bugs.webkit.org/show_bug.cgi?id=126464
Reviewed by Philippe Normand.
.:
- Source/cmake/OptionsGTK.cmake: GStreamer files look for USE(GSTREAMER) and USE(WEBAUDIO_GSTREAMER),
so define those when appropriate. Web audio is one by default in autotools, so turn it on for cmake
as well.
Source/WebCore:
- PlatformGTK.cmake: Complete the audio and video source lists.
Tools:
- GtkLauncher/CMakeLists.txt: Add GStreamer includes and libraries, since GtkLauncher uses it.
- 9:26 AM Changeset in webkit [161309] by
-
- 65 edits in trunk/Source
Explicitly use the std:: nested name specifier when using std::pair, std::make_pair
https://bugs.webkit.org/show_bug.cgi?id=126439
Reviewed by Andreas Kling.
Source/JavaScriptCore:
Instead of relying on std::pair and std::make_pair symbols being present in the current scope
through the pair and make_pair symbols, the std:: specifier should be used explicitly.
- bytecode/Opcode.cpp:
(JSC::compareOpcodePairIndices):
(JSC::OpcodeStats::~OpcodeStats):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::makeBinaryNode):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseIfStatement):
- runtime/Structure.cpp:
(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
(JSC::StructureTransitionTable::add):
Source/WebCore:
Instead of relying on std::pair and std::make_pair symbols being present in the current scope
through the pair and make_pair symbols, the std:: specifier should be used explicitly.
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged):
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::rowIndexRange):
(WebCore::AccessibilityARIAGridCell::columnIndexRange):
- accessibility/AccessibilityARIAGridCell.h:
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::mathPrescripts):
(WebCore::AccessibilityRenderObject::mathPostscripts):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::cellForColumnAndRow):
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::rowIndexRange):
(WebCore::AccessibilityTableCell::columnIndexRange):
- accessibility/AccessibilityTableCell.h:
- accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(webkitAccessibleTableGetColumnAtIndex):
(webkitAccessibleTableGetRowAtIndex):
(webkitAccessibleTableGetColumnExtentAt):
(webkitAccessibleTableGetRowExtentAt):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityHeaderElements]):
(-[WebAccessibilityObjectWrapper accessibilityRowRange]):
(-[WebAccessibilityObjectWrapper accessibilityColumnRange]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(convertMathPairsToNSArray):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- bindings/js/SerializedScriptValue.cpp:
- dom/ContainerNode.cpp:
- dom/StyledElement.cpp:
(WebCore::attributeNameSort):
- html/MediaFragmentURIParser.cpp:
(WebCore::MediaFragmentURIParser::parseTimeFragment):
- html/parser/HTMLMetaCharsetParser.h:
- inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
(WebCore::ContentSearchUtils::searchInTextByLines):
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::diff):
(WebCore::DOMPatchSupport::innerPatchChildren):
- inspector/DOMPatchSupport.h:
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::enable):
(WebCore::InspectorAgent::evaluateForTestInFrontend):
- inspector/InspectorAgent.h:
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::brokenImage):
- loader/cache/CachedImage.h:
- platform/URL.cpp:
(WebCore::findHostnamesInMailToURL):
(WebCore::encodeHostnames):
- platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::getCachedFontData):
- platform/graphics/WidthIterator.cpp:
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::adopt):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::parseCacheControlDirectives):
(WebCore::parseCacheHeader):
- platform/text/AtomicStringKeyedMRUCache.h:
- platform/text/LineBreakIteratorPoolICU.h:
- rendering/InlineFlowBox.h:
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):
(WebCore::RenderImage::paintReplaced):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::cachedCollapsedBorder):
- rendering/RenderTableSection.h:
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):
- svg/SVGAnimatedAngle.cpp:
(WebCore::SVGAnimatedAngleAnimator::constructFromString):
(WebCore::SVGAnimatedAngleAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):
- svg/SVGAnimatedIntegerOptionalInteger.cpp:
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::constructFromString):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateAnimatedValue):
- svg/SVGAnimatedNumberOptionalNumber.cpp:
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::constructFromString):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue):
- svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::createIntegerOptionalInteger):
(WebCore::SVGAnimatedType::createNumberOptionalNumber):
- svg/SVGAnimatedType.h:
(WebCore::SVGAnimatedType::integerOptionalInteger):
(WebCore::SVGAnimatedType::numberOptionalNumber):
- svg/SVGAnimatedTypeAnimator.h:
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValues):
- svg/SVGParserUtilities.h:
- svg/animation/SMILTimeContainer.h:
Source/WebKit/mac:
Instead of relying on std::pair and std::make_pair symbols being present in the current scope
through the pair and make_pair symbols, the std:: specifier should be used explicitly.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
Source/WebKit2:
Instead of relying on std::pair and std::make_pair symbols being present in the current scope
through the pair and make_pair symbols, the std:: specifier should be used explicitly.
- Shared/mac/ArgumentCodersMac.mm:
(IPC::encode):
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::show):
(WebKit::WebNotificationManagerProxy::cancel):
(WebKit::WebNotificationManagerProxy::didDestroyNotification):
- UIProcess/Notifications/WebNotificationManagerProxy.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
- UIProcess/WebContext.h:
Source/WTF:
- wtf/VectorTraits.h: Stop bringing std::pair into the current scope.
Jan 3, 2014:
- 11:43 PM Changeset in webkit [161308] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix EFL build.
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::setHasChangedProperties):
- 8:59 PM Changeset in webkit [161307] by
-
- 9 edits in trunk/Source/WebKit2
Build brake after 161045 on EFL port with WebKit2 and gcc 4.6.3
https://bugs.webkit.org/show_bug.cgi?id=126383
Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-03
Reviewed by Sam Weinig.
Class identifier was missing.
- DatabaseProcess/DatabaseProcess.h:
- NetworkProcess/NetworkProcess.h:
- PluginProcess/PluginProcess.h:
- Shared/mac/CookieStorageShim.h:
- UIProcess/Plugins/PluginProcessManager.h:
- UIProcess/WebPageProxy.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- WebProcess/WebProcess.h:
- 7:55 PM Changeset in webkit [161306] by
-
- 12 edits in trunk/Source/WebCore
Clean up the means of committing the scrolling state tree
https://bugs.webkit.org/show_bug.cgi?id=126482
Reviewed by Tim Horton.
ScrollingStateNodes would manually call scrollingStateTree().setHasChangedProperties()
after setPropertyChanged() in lots of places, which was repetitive, and
AsyncScrollingCoordinator manually called scheduleTreeStateCommit() in many places.
Clean up both of these with a clearer trigger for state tree commits.
ScrollingStateNodes::setPropertyChanged() calls ScrollingStateTree::setHasChangedProperties(),
which turns around and tells the ScrollingCoordinator that the state tree became dirty.
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::AsyncScrollingCoordinator):
(WebCore::AsyncScrollingCoordinator::scrollingStateTreePropertiesChanged):
(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::AsyncScrollingCoordinator::updateScrollingNode):
(WebCore::AsyncScrollingCoordinator::updateViewportConstrainedNode):
(WebCore::AsyncScrollingCoordinator::setScrollLayerForNode):
(WebCore::AsyncScrollingCoordinator::setCounterScrollingLayerForNode):
(WebCore::AsyncScrollingCoordinator::setHeaderLayerForNode):
(WebCore::AsyncScrollingCoordinator::setFooterLayerForNode):
(WebCore::AsyncScrollingCoordinator::setNonFastScrollableRegionForNode):
(WebCore::AsyncScrollingCoordinator::setWheelEventHandlerCountForNode):
(WebCore::AsyncScrollingCoordinator::setScrollBehaviorForFixedElementsForNode):
(WebCore::AsyncScrollingCoordinator::setScrollbarPaintersFromScrollbarsForNode):
(WebCore::AsyncScrollingCoordinator::setSynchronousScrollingReasons):
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::updateConstraints):
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::setPropertyChanged):
(WebCore::ScrollingStateNode::setLayer):
- page/scrolling/ScrollingStateNode.h:
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::setViewportRect):
(WebCore::ScrollingStateScrollingNode::setTotalContentsSize):
(WebCore::ScrollingStateScrollingNode::setScrollOrigin):
(WebCore::ScrollingStateScrollingNode::setScrollableAreaParameters):
(WebCore::ScrollingStateScrollingNode::setFrameScaleFactor):
(WebCore::ScrollingStateScrollingNode::setNonFastScrollableRegion):
(WebCore::ScrollingStateScrollingNode::setWheelEventHandlerCount):
(WebCore::ScrollingStateScrollingNode::setSynchronousScrollingReasons):
(WebCore::ScrollingStateScrollingNode::setScrollBehaviorForFixedElements):
(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition):
(WebCore::ScrollingStateScrollingNode::setHeaderHeight):
(WebCore::ScrollingStateScrollingNode::setFooterHeight):
(WebCore::ScrollingStateScrollingNode::setCounterScrollingLayer):
(WebCore::ScrollingStateScrollingNode::setHeaderLayer):
(WebCore::ScrollingStateScrollingNode::setFooterLayer):
- page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::updateConstraints):
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::create):
(WebCore::ScrollingStateTree::ScrollingStateTree):
(WebCore::ScrollingStateTree::setHasChangedProperties):
(WebCore::ScrollingStateTree::didRemoveNode):
- page/scrolling/ScrollingStateTree.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::scheduleTreeStateCommit):
- page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
(WebCore::ScrollingStateScrollingNode::setScrollbarPaintersFromScrollbars):
- 7:41 PM Changeset in webkit [161305] by
-
- 4 edits in trunk/Source/WebCore
Try to fix CoordinatedGraphics build after r161303. Remove implementations
which are now in the cross-platform file.
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
(WebCore::ScrollingCoordinatorCoordinatedGraphics::detachFromStateTree):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::updateViewportConstrainedNode):
- page/scrolling/coordinatedgraphics/ScrollingStateNodeCoordinatedGraphics.cpp:
- page/scrolling/coordinatedgraphics/ScrollingStateScrollingNodeCoordinatedGraphics.cpp:
- 6:18 PM Changeset in webkit [161304] by
-
- 2 edits in trunk/Source/JavaScriptCore
[super dealloc] missing in Source/JavaScriptCore/API/tests/testapi.mm, fails to build with -Werror,-Wobjc-missing-super-calls
https://bugs.webkit.org/show_bug.cgi?id=126454
Reviewed by Geoffrey Garen.
- API/tests/testapi.mm:
(-[TextXYZ dealloc]):
add [super dealloc]
(-[EvilAllocationObject dealloc]):
add [super dealloc]
- 6:04 PM Changeset in webkit [161303] by
-
- 13 edits in trunk/Source/WebCore
Simplify ScrollingStateNode references to various layer types
https://bugs.webkit.org/show_bug.cgi?id=126477
Reviewed by Tim Horton.
ScrollingStateNodes referenced both GraphicsLayer and PlatformLayers, in
confusing ways. In the main thread they have a GraphicsLayer*, but need
to check to see if the underlying PlatformLayer changed. Then, when
cloned to commit to the scrolling thread, they drop the GraphicsLayer
and store a PlatformLayer.
Hide the complexity (and prepare for the future) by adding LayerRepresentation,
which wraps various different flavors of layers, and knows how to check whether
the PlatformLayer underlying a GraphicsLayer changed.
ScrollingStateNode layer setters then just take and compare LayerRepresentations.
Copy constructors convert to a PlatformLayer representation (though not really
in the right place currently), and ScrollingTreeNodes get PlatformLayers.
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::updateScrollingNode):
(WebCore::AsyncScrollingCoordinator::setScrollLayerForNode):
- page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::syncLayerPositionForViewportRect):
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::ScrollingStateNode):
(WebCore::ScrollingStateNode::setLayer):
- page/scrolling/ScrollingStateNode.h:
(WebCore::LayerRepresentation::LayerRepresentation):
(WebCore::LayerRepresentation::operator GraphicsLayer*):
(WebCore::LayerRepresentation::operator PlatformLayer*):
(WebCore::LayerRepresentation::operator GraphicsLayer::PlatformLayerID):
(WebCore::LayerRepresentation::operator ==):
(WebCore::LayerRepresentation::toPlatformLayer):
(WebCore::LayerRepresentation::representsGraphicsLayer):
(WebCore::LayerRepresentation::representsPlatformLayer):
(WebCore::LayerRepresentation::representsPlatformLayerID):
(WebCore::ScrollingStateNode::layer):
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setCounterScrollingLayer):
(WebCore::ScrollingStateScrollingNode::setHeaderLayer):
(WebCore::ScrollingStateScrollingNode::setFooterLayer):
- page/scrolling/ScrollingStateScrollingNode.h:
- page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::syncLayerPositionForViewportRect):
- page/scrolling/mac/ScrollingStateNodeMac.mm:
- page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
- page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::updateBeforeChildren):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::updateBeforeChildren):
- page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::updateBeforeChildren):
- 6:01 PM Changeset in webkit [161302] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix on non-Mac port
- Shared/API/c/WKDeprecatedFunctions.cpp: Add ENABLE(MAC) guard for "WKContextPrivateMac.h".
- 5:57 PM Changeset in webkit [161301] by
-
- 12 edits in trunk/Source/WebKit2
Simplify process suppression state calculation
https://bugs.webkit.org/show_bug.cgi?id=126473
Reviewed by Geoffrey Garen & Sam Weinig.
Don't check the application occlusion state (this is covered by the pages already),
and let the page check visually idle. Remove layers of functions.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didFinishLaunching):
- Let the network process nap if all processes in its context are napping.* (* Except not really. We currently leak a boost onto the process anyway.)
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didFinishLaunching):
- Let the plugin process nap if all processes in all contexts are napping.
- UIProcess/WebContext.h:
- Remove canEnableProcessSuppressionForNetworkProcess & canEnableProcessSuppressionForWebProcess
- canEnableProcessSuppressionForGlobalChildProcesses -> processSuppressionIsEnabledForAllContexts
- combine updateProcessSuppressionStateOfChildProcesses & updateProcessSuppressionStateOfGlobalChildProcesses
-> updateProcessSuppressionState
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::isProcessSuppressible):
- WebProcess is supressible if IsVisuallyIdle.
(WebKit::WebPageProxy::viewStateDidChange):
- WebProcessProxy should updateProcessSuppressionState when IsVisuallyIdle changes.
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage):
(WebKit::WebProcessProxy::addExistingWebPage):
(WebKit::WebProcessProxy::pageSuppressibilityChanged):
(WebKit::WebProcessProxy::pagePreferencesChanged):
- pageIsProcessSuppressible -> isProcessSuppressible
- UIProcess/WebProcessProxy.h:
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::updateProcessSuppressionState):
- Update supression state of network & plugin processes.
(WebKit::WebContext::processSuppressionIsEnabledForAllContexts):
- Changed iterator style, made a static member of WebContext.
- UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::updateProcessSuppressionState):
- Ask the WebContext to update supression state.
- UIProcess/mac/WindowServerConnection.h:
- UIProcess/mac/WindowServerConnection.mm:
(WebKit::WindowServerConnection::windowServerConnectionStateChanged):
(WebKit::WindowServerConnection::WindowServerConnection):
- Remove application occlusion state.
- 5:27 PM Changeset in webkit [161300] by
-
- 3 edits in branches/jsCStack/Source/JavaScriptCore
cstack Branch: ARM64 LLInt fails to compile due to instructions limitations with sp
https://bugs.webkit.org/show_bug.cgi?id=126423
Reviewed by Filip Pizlo.
Disabled the checkStackPointerAlignment macro for ARM64 since it will fault on any
improper changes to the stack pointer that result in bad alignment.
Changed uses of sp to either move into a temp register for certain operations, or
changed the order of subtract operands. The operand ordering includes branch
compare pseudo ops. In the process discovered that sanitizeStackForVM was plain
wrong and never executed the clear loop, so I fixed that while changing the operand
ordering of the compares.
The ARM64 build also complains that we are doing a compare and branch to a
non-local label so I changed branchIfException to branch around a jmp to
a possible global label.
Tested on X86-64.
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter64.asm:
- 5:20 PM Changeset in webkit [161299] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r161274.
http://trac.webkit.org/changeset/161274
https://bugs.webkit.org/show_bug.cgi?id=126475
Volates ECMA and WebGL Specification (Requested by bfulgham on
#webkit).
- webgl/1.0.2/resources/webgl_test_files/conformance/typedarrays/data-view-test.html:
- 4:58 PM Changeset in webkit [161298] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Make emitPutToCallFrameHeaderBeforePrologue and friends work for all platforms
https://bugs.webkit.org/show_bug.cgi?id=126421
Reviewed by Filip Pizlo.
Added new helper prologueStackPointerDelta() that returns the amount the stack
pointer should be adjusted when accessing a CallFrame via the stack pointer
before the function prologue has been executed.
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::prologueStackPointerDelta):
(JSC::AssemblyHelpers::emitFunctionEpilogue):
(JSC::AssemblyHelpers::emitPutToCallFrameHeaderBeforePrologue):
(JSC::AssemblyHelpers::emitPutPayloadToCallFrameHeaderBeforePrologue):
(JSC::AssemblyHelpers::emitPutTagToCallFrameHeaderBeforePrologue):
- 4:52 PM Changeset in webkit [161297] by
-
- 2 edits in trunk/Source/WebCore
[WebGL] Blit operation from Multisample FBO to rendering FBO must ignore GL_SCISSOR test
https://bugs.webkit.org/show_bug.cgi?id=126470
<rdar://problem/15201370>
Reviewed by Dean Jackson.
Covered by webgl/1.0.2/resources/webgl_test_files/conformance/rendering/gl-scissor-test.html
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Temporarily deactivate the GL_SCISSOR
test while we do our blit, then reactivate if necessary.
- 4:35 PM Changeset in webkit [161296] by
-
- 10 edits in trunk/Source/WebKit2
[iOS] [WK2] TileController creates all tiles on first paint, making it slow and consuming lots of memory
https://bugs.webkit.org/show_bug.cgi?id=126457
Reviewed by Simon Fraser.
Instead of making all of the tiles all of the time, we should use the
view-exposed-rect mechanism to inform TileController about what portion
of the WKContentView is currently exposed by the WKScrollView.
- UIProcess/API/ios/WKContentView.h:
- UIProcess/API/ios/WKContentView.mm:
(-[WKContentView setViewportSize:]):
(-[WKContentView didFinishScrollTo:]):
(-[WKContentView didScrollTo:]):
Inform the WebPageProxy that our exposed rect changed.
- UIProcess/API/ios/WKView.mm:
(-[WKView scrollViewDidScroll:]):
Inform the WKContentView that we've scrolled at all.
Rename the existing WKContentView didScrollTo: to didFinishScrollTo:,
because it is expected to only fire when a scroll lands. Add didScrollTo:,
which fires continually as scrolling progresses.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::viewExposedRectChanged):
(WebKit::WebPageProxy::exposedRectChangedTimerFired):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::viewExposedRect):
- UIProcess/mac/WebPageProxyMac.mm:
Move view-exposed-rect stuff to WebPageProxy so it can be built on both
Mac and iOS, and un-!PLATFORM(IOS) some of the related members.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::setExposedRect):
(WebKit::RemoteLayerTreeDrawingArea::setClipsToExposedRect):
(WebKit::RemoteLayerTreeDrawingArea::updateScrolledExposedRect):
(WebKit::RemoteLayerTreeDrawingArea::updateMainFrameClipsToExposedRect):
(WebKit::RemoteLayerTreeDrawingArea::mainFrameTiledBacking):
Steal TiledCoreAnimationDrawingArea's exposed-rect code.
Note that on iOS, we don't need to manually offset the exposed rect by
the scroll position, because the scroll position is already baked into
the exposed rect, and WebCore's notion of the scroll position will be
inaccurate until the scroll lands.
- 4:24 PM Changeset in webkit [161295] by
-
- 2 edits in trunk/Tools
It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126467
Reviewed by Geoffrey Garen.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
(StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
pointer, or to tap.
- 4:20 PM Changeset in webkit [161294] by
-
- 2 edits in trunk/Source/WebCore
[WebGL] CGLPixelFormat should specify SampleBuffer and Sample count when using MSAA
https://bugs.webkit.org/show_bug.cgi?id=126468
Reviewed by Dean Jackson.
Covered by webgl/1.0.2/resources/webgl_test_files/conformance/rendering/gl-scissor-test.html
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::setPixelFormat): Add kCGLPFAMultisample, kCGLPFASampleBuffers (and count), and
kCGLPFASamples (and count) to our pixel format when 'antialias=true'.
(WebCore::GraphicsContext3D::GraphicsContext3D): Pass a new 'antialias' flag to the setPixelFormat
method so we can turn on MSAA features when needed.
- 4:15 PM Changeset in webkit [161293] by
-
- 14 edits in trunk/Source
Give all PlatformCALayers a PlatformLayerID, not just remote ones
https://bugs.webkit.org/show_bug.cgi?id=126466
Reviewed by Tim Horton.
Source/WebCore:
The ScrollingStateTree has references to both GraphicsLayers and PlatformLayers
which is confusing, and is necessary because the underlying PlatformLayer
inside a GraphicsLayer can change. In order to hide some of this complexity,
expose GraphicsLayer::primaryLayerID() which is a PlatformLayerID that clients
can hold onto to test for underlying layer swapping.
Also constify LayerType m_layerType on PlatformCALayer, which required
cleaning up the construction of PlatformCALayerMac in the case where a
PlatformCALayerMac is wrapping an existing CALayer (which happens for video).
- WebCore.exp.in:
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::primaryLayerID):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::primaryLayerID):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::generateLayerID):
(WebCore::PlatformCALayer::PlatformCALayer):
- platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::layerID):
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::create):
(PlatformCALayerMac::PlatformCALayerMac):
(PlatformCALayerMac::commonInit):
Source/WebKit2:
The ScrollingStateTree has references to both GraphicsLayers and PlatformLayers
which is confusing, and is necessary because the underlying PlatformLayer
inside a GraphicsLayer can change. In order to hide some of this complexity,
expose GraphicsLayer::primaryLayerID() which is a PlatformLayerID that clients
can hold onto to test for underlying layer swapping.
GraphicsLayerCARemote and PlatformCALayerRemote can now just use the
primaryLayerID() function exposed via the base class.
- WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp:
- WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::PlatformCALayerRemote):
(PlatformCALayerRemote::recursiveBuildTransaction):
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
- 4:04 PM Changeset in webkit [161292] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Expose session state API
https://bugs.webkit.org/show_bug.cgi?id=126463
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKBrowsingContextController.h: Declared new property and method.
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController sessionState]): Added. Calls WebPageProxy::sessionStateData.
(-[WKBrowsingContextController restoreFromSessionState:]): Added. Calls
WebPageProxy::restoreFromSessionState.
- 4:03 PM Changeset in webkit [161291] by
-
- 6 edits in trunk/Source/WebKit2
Remove SPI, user default for disabling process suppression
https://bugs.webkit.org/show_bug.cgi?id=126458
Reviewed by Sam Weinig.
- Shared/API/c/WKDeprecatedFunctions.cpp:
(WKContextGetProcessSuppressionEnabled):
(WKContextSetProcessSuppressionEnabled):
- depracated SPI.
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
- depracated SPI.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
- removed m_processSuppressionEnabled.
- UIProcess/WebContext.h:
- removed setProcessSuppressionEnabled, processSuppressionEnabled implementation, processSuppressionEnabledChanged, m_processSuppressionEnabled.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitialize):
- removed m_processSuppressionEnabled.
(WebKit::WebContext::processSuppressionEnabled):
- check whether all pages in all processes are suppressible.
(WebKit::WebContext::canEnableProcessSuppressionForNetworkProcess):
- removed call to omitProcessSuppression, m_processSuppressionEnabled -> processSuppressionEnabled().
(WebKit::WebContext::canEnableProcessSuppressionForWebProcess):
- removed call to omitProcessSuppression, processSuppressionEnabled (we don't care if a page in a difference process is not suppresible).
(WebKit::WebContext::canEnableProcessSuppressionForGlobalChildProcesses):
- removed call to omitProcessSuppression, s_processSuppressionEnabledForAllContexts -> processSuppressionIsEnabledForAllContexts().
- 3:38 PM Changeset in webkit [161290] by
-
- 3 edits in trunk/Tools
build.webkit.org/dashboard says "failed build" even if it's another step that failed
https://bugs.webkit.org/show_bug.cgi?id=126461
Reviewed by Geoffrey Garen.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
build page if it's not the compilation that failed. Use text from buildbot for description.
Show a yellow icon if it's a different kind of failure.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
- 3:25 PM Changeset in webkit [161289] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][CoordinatedGraphics] Removing repeated protected keyword in WebView
https://bugs.webkit.org/show_bug.cgi?id=126462
Reviewed by Simon Fraser.
- UIProcess/CoordinatedGraphics/WebView.h:
- 3:19 PM Changeset in webkit [161288] by
-
- 6 edits in trunk/Source/WebCore
Add lineageOfType renderer iterator and start using it.
<https://webkit.org/b/126456>
Add a convenient way to iterate over a renderers ancestry *including*
the starting point renderer (if it meets the type criteria.)
This works just like lineageOfType for Elements.
Reviewed by Geoffrey Garen.
- rendering/RenderAncestorIterator.h:
(WebCore::lineageOfType):
Added. Returns an adapter for walking a renderer's entire lineage
matching any renderer of the given type.
- rendering/RenderBoxModelObject.h:
- rendering/RenderLayerModelObject.h:
Add the requisite isRendererOfType<T> helpers.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::enclosingFloatPaintingLayer):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::enclosingLayer):
(WebCore::RenderObject::enclosingBox):
(WebCore::RenderObject::enclosingBoxModelObject):
Simplify with lineageOfType. Added some FIXMEs about functions
that should return references instead of pointers.
- 3:05 PM Changeset in webkit [161287] by
-
- 2 edits in trunk/Source/WebCore
Small build fix for the GTK+ CMake port
- PlatformGTK.cmake: Add an IDL file that is missing from the list of IDLs
used to generate GObject DOM bindings.
- 2:28 PM Changeset in webkit [161286] by
-
- 12 edits1 add in trunk/Source/WebCore
[iOS] Upstream WebCore/css changes
https://bugs.webkit.org/show_bug.cgi?id=126237
Reviewed by Simon Fraser.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue): Added iOS-specific code and FIXME comment.
- css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext): Ditto.
(WebCore::CSSParser::parseValue): Ditto.
- css/CSSPropertyNames.in: Added property -webkit-composition-fill-color. Also added FIXME comment.
- css/CSSValueKeywords.in: Added iOS-specific -apple-system-* values.
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): Added iOS-specific code and FIXME comments.
- css/MediaFeatureNames.h: Added media feature -webkit-video-playable-inline.
- css/MediaQueryEvaluator.cpp:
(WebCore::isRunningOnIPhoneOrIPod): Added. Also added FIXME comment.
(WebCore::video_playable_inlineMediaFeatureEval): Added.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement): Substitute toHTMLMediaElement() for toMediaElement().
(WebCore::StyleResolver::applyProperty): Added iOS-specific code and FIXME comment.
- css/html.css: Added iOS-specific CSS styles.
(input, textarea, keygen, select, button, isindex):
(isindex):
(input[type="date"]):
(input[type="datetime"]):
(input[type="datetime-local"]):
(input[type="month"]):
(input[type="time"]):
(textarea):
(input:-webkit-autofill):
(input[type="radio"], input[type="checkbox"]):
(input[type="button"], input[type="submit"], input[type="reset"], input[type="file"]::-webkit-file-upload-button, button):
(input[type="range"]::-webkit-slider-thumb, input[type="range"]::-webkit-media-slider-thumb):
(input[type="range"]::-webkit-slider-thumb:active):
(input:disabled, textarea:disabled):
(input[readonly], textarea[readonly]):
(textarea::-webkit-input-placeholder):
(input[type="checkbox"]):
(input[type="radio"]):
(input[type="checkbox"]:checked, input[type="radio"]:checked):
(input[type="checkbox"]:checked:disabled, input[type="radio"]:checked:disabled):
(select:focus):
(select):
- css/mathml.css: Added iOS-specific CSS styles.
(math, mfenced > *):
(mo, mfenced):
- css/mediaControlsiOS.css: Added.
- css/svg.css: Added iOS-specific CSS styles.
(text, tspan, tref):
- 1:45 PM Changeset in webkit [161285] by
-
- 2 edits in trunk/Source/WebCore
[WebGL] glScissor test is not accounted for when generating internal rendering textures.
https://bugs.webkit.org/show_bug.cgi?id=126455
<rdar://problem/15744206>
Reviewed by Dean Jackson.
Covered by webgl/1.0.2/conformance/rendering/gl-scissor-test.html
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture): Check state of GL_SCISSOR_TEST and GL_DITHER, deactivate them during
our internal drawing, then turn them back on for further processing.
- 1:40 PM Changeset in webkit [161284] by
-
- 3 edits in trunk/Tools
setup-git-clone fails to get email address from git
https://bugs.webkit.org/show_bug.cgi?id=126446
Reviewed by Ryosuke Niwa.
The setup-git-clone command fails to get an email address from git
because of a bug in VCSUtils. This patch fixes that bug, and also
makes it so that when VCSUtils fails for real because of a local
misconfiguration, the error message is actually presented to the user
of setup-git-clone.
- Scripts/VCSUtils.pm:
(gitConfig): Call isGit() instead of accessing $isGit directly to make
sure that $isGit is properly initialized.
- Scripts/webkitpy/tool/commands/setupgitclone.py:
(SetupGitClone.execute): Pull out username and email acquistion to
it's own method.
(SetupGitClone._get_username_and_email): Catch the exception thrown
when VCSUtils fails and print out the error message so that the
user actually knows why the command failed.
- 1:28 PM Changeset in webkit [161283] by
-
- 2 edits in trunk/Source/WebCore
Maybe fix Windows build.
- WebCore.vcxproj/copyForwardingHeaders.cmd:
- 1:25 PM Changeset in webkit [161282] by
-
- 2 edits in trunk/Source/WebKit
Attempt to fix EFL build.
- CMakeLists.txt:
- 1:02 PM Changeset in webkit [161281] by
-
- 2 edits in trunk/Tools
It feels too hard to get rid of a popover at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126451
Reviewed by Simon Fraser.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
(.popover.fade-out): Reduced the timeout - 200 ms is enough to not have flicker
when moving the mouse from an element to its popover.
- 12:50 PM Changeset in webkit [161280] by
-
- 6 edits2 adds in trunk/Source/WebCore
[MediaControls][iOS] Enable JavaScript Media Controls on iOS.
https://bugs.webkit.org/show_bug.cgi?id=126440
Reviewed by Eric Carlson.
Drive-by misspelling fix, and add a convenience function to check if the
controls are currently hidden:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handleWrapperMouseMove):
(Controller.prototype.handleWrapperMouseOut):
(Controller.prototype.updatePlaying):
(Controller.prototype.controlsAreHidden): Added.
Add a new subclass of Controller for iOS and a matching CSS:
- Modules/mediacontrols/mediaControlsiOS.css: Added.
- Modules/mediacontrols/mediaControlsiOS.js: Added.
(createControls): Override the createControls() in mediaControlsApple.js.
(ControllerIOS): Define a new class.
(ControllerIOS.prototype.inheritFrom): Convenience method to mixin parent
prototype methods.
(ControllerIOS.prototype.createBase): Override, listen for touches instead of mouse events.
(ControllerIOS.prototype.createControls): Ditto.
(ControllerIOS.prototype.configureInlineControls): Override, only add play, timeline, and full
screen butttons.
(ControllerIOS.prototype.configureFullScreenControls): Override, and add no buttons.
(ControllerIOS.prototype.handlePlayButtonTouchStart): Activate.
(ControllerIOS.prototype.handlePlayButtonTouchEnd): De-activate and do action.
(ControllerIOS.prototype.handlePlayButtonTouchCancel): De-activate and cancel.
(ControllerIOS.prototype.handleWrapperTouchStart): Show controls.
(ControllerIOS.prototype.handlePanelTouchStart): Disable video selection.
(ControllerIOS.prototype.handlePanelTouchEnd): Re-enable video selection.
(ControllerIOS.prototype.handlePanelTouchCancel): Ditto.
Drive-by fix to enable the JavaScript controls when the plugin is disabled:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
Add the iOS JavaScript by appending it to the generic (Apple) JavaScript:
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::mediaControlsScript):
Add new files to project:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- 12:45 PM Changeset in webkit [161279] by
-
- 3 edits in trunk/Source/WebCore
Allow the ChromeClient to provide a custom ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=126450
Reviewed by Tim Horton.
Some platforms will want to provide a custom ScrollingCoordinator, so let
them do so by asking ChromeClient first for one.
- page/ChromeClient.h:
(WebCore::ChromeClient::createScrollingCoordinator):
- page/Page.cpp:
(WebCore::Page::scrollingCoordinator):
- 12:22 PM Changeset in webkit [161278] by
-
- 2 edits in trunk/Source/WebCore
Deploy more child renderer iterators in RenderBlockFlow.
<https://webkit.org/b/126434>
Reviewed by Sam Weinig.
- rendering/RenderBlockFlow.cpp:
(WebCore::shouldCheckLines):
Make this helper take a RenderBlockFlow instead of a RenderObject
and simplified it a bit. RenderDeprecatedFlexibleBox does not
derive from RenderBlockFlow so those checks can be omitted.
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlockFlow::lineAtIndex):
(WebCore::RenderBlockFlow::lineCount):
(WebCore::RenderBlockFlow::clearTruncation):
Use childrenOfType to iterate over block and block-flow children.
Tweaked some early return/continue to reduce nesting.
- 12:16 PM Changeset in webkit [161277] by
-
- 2 edits in trunk/Tools
Please add a way to quick peek at failing tests at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=122181
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._presentNoChangePopover): Update one more place for
popover.present signature change.
- 12:05 PM Changeset in webkit [161276] by
-
- 11 edits in trunk/Source/WebCore
Allow different types of ScrollingTrees to have different types of ScrollingTreeNode subclasses
https://bugs.webkit.org/show_bug.cgi?id=126445
Reviewed by Tim Horton.
Make it possible to have ScrollingTree subclasses with different subclasses of ScrollingTreeNodes,
by giving ScrollingTree a pure virtual createNode() function. ThreadedScrollingTree implements
this, and then delegates node creation to its AsyncScrollingCoordinator (since we have
a ScrollingCoordinatorMac but no real need for a ThreadedScrollingTreeMac).
Also made ThreadedScrollingTree's m_scrollingCoordinator an AsyncScrollingCoordinator,
since by definition a threaded scrolling tree uses an async coordinator.
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateTreeFromStateNode):
- page/scrolling/ScrollingTree.h:
- page/scrolling/ScrollingTreeScrollingNode.h:
- page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::create):
(WebCore::ThreadedScrollingTree::ThreadedScrollingTree):
(WebCore::ThreadedScrollingTree::createNode):
- page/scrolling/ThreadedScrollingTree.h:
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::createScrollingTreeNode):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::create):
- 11:52 AM Changeset in webkit [161275] by
-
- 2 edits in trunk/Source/WebCore
Refactor NSActivity handling code from ChildProcess to UserActivity
https://bugs.webkit.org/show_bug.cgi?id=126330
Unreviewed build fix.
- platform/UserActivity.h:
- case fix.
- 11:47 AM Changeset in webkit [161274] by
-
- 2 edits in trunk/LayoutTests
Revise WebGL DataView test to match ECMAScript Draft Specification
https://bugs.webkit.org/show_bug.cgi?id=126032
Based on the ECMAScript specification, we believe that the current test is wrong. We are working to get this
fixed upstream.
Reviewed by Dean Jackson.
- webgl/1.0.2/resources/webgl_test_files/conformance/typedarrays/data-view-test.html: Do not
prohibit using DataView as a function.
- 11:32 AM Changeset in webkit [161273] by
-
- 12 edits1 add in trunk/Tools
Please add a way to quick peek at failing tests at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=122181
Reviewed by Timothy Hatcher and Timothy Horton.
Detailed results are saved by run-webkit-tests to full_results.json (which is actually
JSONP). Dashboard will load them on demand.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.layoutTestResultsURLForIteration): Moved from WebKitBuildbot.js
and made it use a function from WebKitBuildbot that builds results directory path.
(Buildbot.prototype.layoutTestFullResultsURLForIteration): Added a function that builds
a URL for full_results.json.
(Buildbot.prototype.layoutTestCrashLogForIteration): Added a function that builds
a URL for a crash log.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.loadLayoutTestResults): Load and cache layout test results for
the iteration.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Updated for changed
popover API (see below).
(BuildbotQueueView.prototype._presentPopoverForRevisionRange): Ditto.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Added a check
for iterations that were interrupted (previously, they were displayed incorrectly,
often as passes). Install popover trackers for failure bubbles for which we can currently
display something useful.
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Build
a popover for layout test regressions when we have the data loaded on demand.
We have test paths, special indicators for crashes/timeouts, and links to test history
at flakiness dashboard.
(BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Show
the popover for layout test regressions. Just shows "Loading..." until the data is
loaded.
(BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): List
types of failures if there are multiple. There is a lot of similarity with
appendBuilderQueueStatus(), but I couldn't find a good way to share the code.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
Create a global test history object, which is used for links in layout test popover.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
Changed the API to be more like WebInspector again, allowing for changing content
of an existing popover. As the size of a popover can change, making the mouse pointer
enter it without a mousenter event, install a handler for mousewheel instead, and block
document scrolling from this event handler when needed.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
(StatusLineView.prototype.get statusBubbleElement): Added an accessor for status
bubble element, making it possible to install a popover on it.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
(JSON.load): Added the ability to load JSONP by providing an optional callback name.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Switched from
building a complete results URL to only building one for root results path. This is
the part that depends on specific buildbot installation, everything relative to it
is the same.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: Added.
Build a path to test history page. In the future, we may consider adding code to
load the data and display it inline.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
Added styles for this new popover.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added
a new file, WebKitTestHistory.js.
- 11:13 AM Changeset in webkit [161272] by
-
- 7 edits in trunk/Source/WebKit2
Define WebProcess::usesNetworkProcess unconditionally
https://bugs.webkit.org/show_bug.cgi?id=126208
Reviewed by Martin Robinson.
Returning false when network process is not enabled like
WebContext does. This way we reduce the amount of ifdefs used when
checking whether network process is in use.
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess): Remove #ifdef
and only setup network features when not using network process.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::isAvailable): Remove #ifdef.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::downloadManager):
(WebKit::WebProcess::shouldTerminate):
(WebKit::WebProcess::usesNetworkProcess):
- WebProcess/WebProcess.h:
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformSetCacheModel): Remove #ifdef.
(WebKit::WebProcess::platformInitializeWebProcess): Ditto.
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformSetCacheModel): Ditto.
(WebKit::WebProcess::platformClearResourceCaches): Ditto.
(WebKit::WebProcess::platformInitializeWebProcess): Ditto.
(WebKit::WebProcess::platformTerminate): Only remove the language
observer when not using network process.
(WebKit::WebProcess::setIgnoreTLSErrors): Assert when this is
called with network process enabled.
(WebKit::WebProcess::allowSpecificHTTPSCertificateForHost): Ditto.
- 11:06 AM Changeset in webkit [161271] by
-
- 11 edits3 adds in trunk/Source
Source/WebCore: Refactor NSActivity handling code from ChildProcess to UserActivity
https://bugs.webkit.org/show_bug.cgi?id=126330
Reviewed by Sam Weinig.
UserActivity is a mechanism to express to the operating system (where appropriate)
that a user initiated activity is taking place, and as such that resources should be
made available to the process accordingly.
Currently we hold a single NSActivity, at the WebKit layer. This refactoring allows us
to hold different activity tokens for different user actions (which simplifies the
handling, and aides debugging since the token can more accurately express the activity
taking place), and also will allow us to avoid the layering difficulty of calling back
up the stack to WebKit to register that an activity is taking place.
- WebCore.xcodeproj/project.pbxproj:
- added new files.
- platform/UserActivity.cpp: Added.
(WebCore::UserActivity::UserActivity):
- nop implementation - ignore description.
(WebCore::UserActivity::beginActivity):
(WebCore::UserActivity::endActivity):
- nop implementation - just inc/dec m_count.
- platform/UserActivity.h: Added.
(WebCore::UserActivity::isActive):
- returns true if one or more instance of this activity is in progress.
- platform/mac/UserActivityMac.mm: Added.
(WebCore::UserActivity::UserActivity):
- constructor accepts one argument, a description string.
(WebCore::UserActivity::isValid):
- used by assertions.
(WebCore::UserActivity::beginActivity):
(WebCore::UserActivity::endActivity):
- track start/end of an activity - calls to these methods should be balanced.
(WebCore::UserActivity::hysteresisTimerFired):
- used to implement hysteresis in releasing NSActivity.
Source/WebKit2: VibrationPattern should allocate an single vector instance for single integer input
https://bugs.webkit.org/show_bug.cgi?id=126417
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2014-01-03
Reviewed by Gyuyoung Kim.
Fix a vibration unit test regression after r161139. Also remove unnecessary test cases.
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(EWK2ViewTest::loadVibrationHTMLString):
(TEST_F):
Source/WTF: Refactor NSActivity handling code from ChildProcess to UserActivity
https://bugs.webkit.org/show_bug.cgi?id=126330
Reviewed by Sam Weinig.
UserActivity is a mechanism to express to the operating system (where appropriate)
that a user initiated activity is taking place, and as such that resources should be
made available to the process accordingly.
Currently we hold a single NSActivity, at the WebKit layer. This refactoring allows us
to hold different activity tokens for different user actions (which simplifies the
handling, and aides debugging since the token can more accurately express the activity
taking place), and also will allow us to avoid the layering difficulty of calling back
up the stack to WebKit to register that an activity is taking place.
- wtf/Platform.h:
- added HAVE_NS_ACTIVITY.
- 11:05 AM Changeset in webkit [161270] by
-
- 4 edits in branches/jsCStack/Source/JavaScriptCore
Unreviewed, some trivial 32-bit build fixes.
32-bit is still broken but this takes care of some easy things. This is part of
the work for https://bugs.webkit.org/show_bug.cgi?id=116888.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::storePtr):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
- jit/RegisterPreservationWrapperGenerator.cpp:
(JSC::generateRegisterRestoration):
- 10:59 AM Changeset in webkit [161269] by
-
- 3 edits2 adds in trunk
Line ending conversion should be able to handle strings with null chars
https://bugs.webkit.org/show_bug.cgi?id=126202
This is a merge from Blink.
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: http/tests/local/formdata/send-form-data-with-string-containing-null.html
- platform/text/LineEnding.cpp: (WebCore::normalizeToCROrLF): Do it right.
LayoutTests:
- http/tests/local/formdata/send-form-data-with-string-containing-null-expected.txt: Added.
- http/tests/local/formdata/send-form-data-with-string-containing-null.html: Added.
- 10:49 AM Changeset in webkit [161268] by
-
- 3 edits in trunk/Tools
REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214
https://bugs.webkit.org/show_bug.cgi?id=126430
Reviewed by Martin Robinson.
- Scripts/run-gtk-tests:
(TestRunner._setup_testing_environment):
- gtk/common.py: Use common.tests_library_build_path() instead.
(tests_library_build_path): Helper funtion that returns the path
where the tests libraries are built.
- 10:41 AM Changeset in webkit [161267] by
-
- 2 edits in trunk/Source/WebCore
WebKit-GTK 1.8.1 does not build on OS X 10.7
https://bugs.webkit.org/show_bug.cgi?id=88407
Reviewed by Carlos Garcia Campos.
Replace non-portable 'echo -n' with 'true'.
- GNUmakefile.am:
- 9:37 AM Changeset in webkit [161266] by
-
- 2 edits in trunk/WebKitLibraries
[WinCairo] Enable video using GStreamer.
https://bugs.webkit.org/show_bug.cgi?id=126015
Reviewed by Darin Adler.
- win/tools/vsprops/FeatureDefinesCairo.props:
Define ENABLE_MEDIA_CONTROLS_SCRIPT, ENABLE_VIDEO_TRACK, and ENABLE_VIDEO.
- 9:35 AM Changeset in webkit [161265] by
-
- 2 edits in trunk/Websites/webkit.org
Added GStreamer to list of required tools for compiling webkit.
https://bugs.webkit.org/show_bug.cgi?id=126319
Reviewed by Philippe Normand.
- building/tools.html:
Mentioned that QuickTime and QuickTime SDK are only required for AppleWin.
Added GStreamer installers to list of required tools for WinCairo.
- 9:21 AM Changeset in webkit [161264] by
-
- 3 edits in trunk/Source/WebCore
[WinCairo] Compile error.
https://bugs.webkit.org/show_bug.cgi?id=126428
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-01-03
Reviewed by Brent Fulgham.
The NativeImagePtr type is not an CGImageRef on WinCairo, cannot use CFRetain.
- loader/cache/MemoryCache.cpp: Replace USE(CF) with USE(CG).
- loader/cache/MemoryCache.h: Ditto.
- 9:03 AM Changeset in webkit [161263] by
-
- 2 edits in trunk
[CMake] The forwarding headers generated by WebKitMacros.m4 are incompatible with the headers generated by generate-forwarding-headers.pl
https://bugs.webkit.org/show_bug.cgi?id=126361
Reviewed by Philippe Normand.
Make the forwarding headers generated by WebKitMacros.m4 compatible with the headers
generated by the WebKit2 forwarding headers generation script.
- Source/cmake/WebKitMacros.cmake: Try to convert absolute paths in the forwarding headers
to ones that are relative to the Source directory.
- 9:02 AM Changeset in webkit [161262] by
-
- 2 edits in trunk/Tools
[CMake] Build TestWebKitAPI tests into a directory structure
https://bugs.webkit.org/show_bug.cgi?id=126358
Reviewed by Gyuyoung Kim.
WebKitGTK+ builds the TestWebKitAPI tests into a "TestWebKitAPI" directory. This
is useful for keeping the "bin" directory tidy during building and will make it easier
to integrate the CMake build into the existing WebKitGTK+ scripts.
- TestWebKitAPI/CMakeLists.txt: Set the output directory of all TestWebKitAPI binaries
and make the names simpler now that the directory identifies what category the test is in.
- 9:00 AM Changeset in webkit [161261] by
-
- 4 edits in trunk/Tools
Provide a visual clue when element has a popover at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126281
Reviewed by Timothy Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
(PopoverTracker): Add a class name to elements with popovers.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(*): We have -webkit-user-select:none, so let's also not show text selection cursor.
I might have broke that recently.
(*:link): Show hand cursor over links.
(.popover-tracking:hover): Put a shadow on hover over element with popovers.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
(.status-line .message .revision-number): Show text selection cursor on our only
selectable text element.
(.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
a white shadow than with a dark one on hover.
- 8:57 AM Changeset in webkit [161260] by
-
- 9 edits in trunk/Source/WebCore
[CSS Shapes] Simplify FloatRoundedRect, BoxShape construction
https://bugs.webkit.org/show_bug.cgi?id=125995
Reviewed by Andreas Kling.
Cleanup of various internal Shape issues:
- Removed unnecessary Shape() initialization list entries in Shape subclasses per https://bugs.webkit.org/show_bug.cgi?id=125548#c2.
- Used const references instead of pointers for non-deprecated Shape:createShape() logic.
- Replaced createShape() overloads for Rasters and Boxes with functions named createRasterShape() and createBoxShape().
- Added a FloatRoundedRect::Radii() constructor to reduce the parameter list length of the FloatRoundedRect constructor in createBoxShape().
There are no new tests, this is just internal refactoring.
- platform/graphics/FloatRoundedRect.h:
(WebCore::FloatRoundedRect::Radii::Radii):
- rendering/shapes/BoxShape.h:
(WebCore::BoxShape::BoxShape):
- rendering/shapes/PolygonShape.h:
(WebCore::PolygonShape::PolygonShape):
- rendering/shapes/RasterShape.h:
(WebCore::RasterShape::RasterShape):
- rendering/shapes/RectangleShape.h:
(WebCore::RectangleShape::RectangleShape):
- rendering/shapes/Shape.cpp:
(WebCore::createInsetShape):
(WebCore::Shape::createShape):
(WebCore::Shape::createRasterShape):
(WebCore::Shape::createBoxShape):
- rendering/shapes/Shape.h:
- rendering/shapes/ShapeInfo.cpp:
(WebCore::ShapeInfo<RenderType>::computedShape):
- 3:44 AM Changeset in webkit [161259] by
-
- 3 edits in trunk/Source/WebCore
Remove unused Document::openSearchDescriptionURL().
<https://webkit.org/b/126419>
Reviewed by Antti Koivisto.
- dom/Document.h:
- dom/Document.cpp:
Scrub leftovers from the defunct Chromium port.
- 1:06 AM Changeset in webkit [161258] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Add failure and flakiness expectations for a couple of tests.
- platform/gtk/svg/custom/object-no-size-attributes-expected.txt: Rebaseline.
- 12:45 AM Changeset in webkit [161257] by
-
- 4 edits in trunk/Source
VibrationPattern should allocate an single vector instance for single integer input
https://bugs.webkit.org/show_bug.cgi?id=126417
Reviewed by Gyuyoung Kim.
Source/WebCore:
When the Vibration pattern is set with a single integer, the VibrationPattern should
be set with this integer as a vibration time. But the VibrationPattern(unsigned vector) was
initialized with a single parameter, the vibration time, so the time was used to set
the size of vector.
- Modules/vibration/NavigatorVibration.cpp:
(WebCore::NavigatorVibration::vibrate):
Source/WebKit2:
Fix a vibration unit test regression after r161139. Also remove unnecessary test cases.
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(EWK2ViewTest::loadVibrationHTMLString):
(TEST_F):
- 12:42 AM Changeset in webkit [161256] by
-
- 10 edits in trunk
[GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown
https://bugs.webkit.org/show_bug.cgi?id=124652
Reviewed by Martin Robinson.
Source/WebKit2:
- UIProcess/API/gtk/WebKitPolicyClient.cpp:
(decidePolicyForResponse): Pass canShowMIMEType to
webkitResponsePolicyDecisionCreate.
- UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp:
(webkit_response_policy_decision_is_mime_type_supported): Return
canShowMIMEType.
(webkitResponsePolicyDecisionCreate): Set the canShowMIMEType
member from the given parameter.
- UIProcess/API/gtk/WebKitResponsePolicyDecision.h:
- UIProcess/API/gtk/WebKitResponsePolicyDecisionPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewDecidePolicy): Use the new API instead of
webkit_web_view_can_show_mime_type() since it's more efficient.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
- UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp:
(testResponsePolicy): Test the new API.
Tools:
- MiniBrowser/gtk/BrowserWindow.c:
(webViewDecidePolicy): Use the new API instead of
webkit_web_view_can_show_mime_type().
Jan 2, 2014:
- 11:56 PM Changeset in webkit [161255] by
-
- 15 edits in trunk
REGRESSION(r160304): [GTK] Disable libtool fast install
https://bugs.webkit.org/show_bug.cgi?id=126381
Reviewed by Martin Robinson.
.:
After r160304 we are building some of our binaries that are
installed with the -no-fast-install ld flag. This makes that the
binaries are installed with the source code path hardcoded in
binary RPATH. Disabling fast install globally, the libtool script
always relinks the binaries right before being installed.
- Source/autotools/SetupLibtool.m4: Add AC_DISABLE_FAST_INSTALL.
Source/JavaScriptCore:
Remove -no-fast-install ld flag since fast install is now disabled
globally.
- GNUmakefile.am:
Source/WebKit/gtk:
- tests/GNUmakefile.am:
Source/WebKit2:
Remove -no-fast-install ld flag since fast install is now disabled
globally.
- GNUmakefile.am:
- UIProcess/API/gtk/tests/GNUmakefile.am:
Tools:
Remove -no-fast-install ld flag since fast install is now disabled
globally.
- GNUmakefile.am:
- GtkLauncher/GNUmakefile.am:
- MiniBrowser/gtk/GNUmakefile.am:
- TestWebKitAPI/GNUmakefile.am:
- WebKitTestRunner/GNUmakefile.am:
- 11:48 PM Changeset in webkit [161254] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Remove defaultPageGroupIdentifier not to make the confusion
https://bugs.webkit.org/show_bug.cgi?id=126249
Reviewed by Gyuyoung Kim.
ewk_page_group_create always creates new page group,
but the identifiers of page groups will be same as "defaultPageGroupIdentifier" when passed 0 or "".
It is unnecessary and just makes the confusion.
This patch let WebPageGroup generate unique identifier if 0 or "" is passed as argument.
- UIProcess/API/efl/ewk_page_group.cpp:
(EwkPageGroup::create):
- UIProcess/API/efl/ewk_page_group_private.h:
- 11:40 PM Changeset in webkit [161253] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Switch from WTF::Function to std::function in WebProcessTest
https://bugs.webkit.org/show_bug.cgi?id=126397
Reviewed by Anders Carlsson.
Use std::function<> and std::bind() instead of WTF::Function and WTF::bind,
following the effort of using STL concepts where possible.
- UIProcess/API/gtk/tests/WebProcessTest.cpp:
(WebProcessTest::add):
- UIProcess/API/gtk/tests/WebProcessTest.h:
- 9:21 PM Changeset in webkit [161252] by
-
- 2 edits in trunk/Source/WebCore
IconController.cpp needs to include <wtf/text/CString.h>
https://bugs.webkit.org/show_bug.cgi?id=126415
Reviewed by Gyuyoung Kim.
Build fails in IconController.cpp when ICONDATABASE is disabled.
WebKit/Source/WebCore/loader/icon/IconController.cpp:124:110: error: invalid use of incomplete type ‘class WTF::CString’
IconController.cpp needs #include <wtf/text/CString.h>.
No new tests. Just build fix.
- loader/icon/IconController.cpp: Add #include statement.
- 8:40 PM Changeset in webkit [161251] by
-
- 3 edits in trunk/Source/WebCore
[EFL] Previous scrollbar is remained sometimes
https://bugs.webkit.org/show_bug.cgi?id=126414
Reviewed by Gyuyoung Kim.
- platform/efl/ScrollbarEfl.cpp:
(ScrollbarEfl::invalidate):
Updated scrollbar visibility in Scrollbar::invalidate().
- platform/efl/ScrollbarEfl.h:
Removed show()/hide() which never been called() for scrollbar.
- 7:50 PM Changeset in webkit [161250] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself to EFL and related watch lists.
- Scripts/webkitpy/common/config/watchlist:
- 6:52 PM Changeset in webkit [161249] by
-
- 2 edits in trunk
[CMake][EFL] Fix some typos in OptionsEfl.cmake
https://bugs.webkit.org/show_bug.cgi?id=126376
Reviewed by Gyuyoung Kim.
- Source/cmake/WebKitFeatures.cmake: Correct a wrong word and remove comma(,).
- 6:16 PM Changeset in webkit [161248] by
-
- 4 edits in trunk/LayoutTests
[WebGL] Correct symbol lookup logic to handle 1-element arrays
https://bugs.webkit.org/show_bug.cgi?id=126411
<rdar://problem/15394564>
Patch by Brent Fulgham <Brent Fulgham> on 2014-01-02
Reviewed by Dean Jackson.
- webgl/1.0.2/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Add test for accessing the
single-element array.
- 6:11 PM Changeset in webkit [161247] by
-
- 4 edits in trunk
[WebGL] Correct symbol lookup logic to handle 1-element arrays
https://bugs.webkit.org/show_bug.cgi?id=126411
<rdar://problem/15394564>
Reviewed by Dean Jackson.
Source/WebCore:
Tested by revisions to webgl/1.0.2/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getUniformLocation): Revise to
handle access to zeroeth element of the array.
LayoutTests:
- webgl/1.0.2/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Add test for accessing the
single-element array.
- 6:09 PM Changeset in webkit [161246] by
-
- 13 edits2 adds in trunk/Source/WebKit2
Propagate WindowServer modifications state to WebProcess
https://bugs.webkit.org/show_bug.cgi?id=126356
Reviewed by Sam Weinig.
This will be necessary to move control of process suppression to the WebProcess.
IsVisuallyIdle implies the process has stopped painting, or painted rects are
occluded and not actually being composited. State is provided on a per
WindowServer connection basis, and as such may produce (safe) false positives.
- Shared/ViewState.h:
- added IsVisuallyIdle.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::isVisuallyIdle):
- added, on mac checks WindowServerConnection.
- UIProcess/PageClient.h:
(WebKit::PageClient::isVisuallyIdle):
- base implementation purely based on isViewVisible.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::windowServerConnectionStateChanged):
- broadcast the state change.
- UIProcess/WebContext.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateViewState):
(WebKit::WebPageProxy::viewStateDidChange):
- propagate IsVisuallyIdle.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::windowServerConnectionStateChanged):
- broadcast the state change.
- UIProcess/WebProcessProxy.h:
- add windowServerConnectionStateChanged.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::updateProcessSuppressionStateOfGlobalChildProcesses):
- moved from static in fle to static member of class.
(WebKit::WebContext::platformInitialize):
- no need to enableOcclusionNotifications.
(WebKit::WebContext::canEnableProcessSuppressionForNetworkProcess):
(WebKit::WebContext::canEnableProcessSuppressionForWebProcess):
(WebKit::WebContext::canEnableProcessSuppressionForGlobalChildProcesses):
- changed to call WindowServerConnection.
(WebKit::WebContext::processSuppressionEnabledChanged):
- don't remove/reregister occlusion notifications.
- UIProcess/mac/WindowServerConnection.h: Added.
(WebKit::WindowServerConnection::applicationIsOccluded):
(WebKit::WindowServerConnection::applicationWindowModificationsHaveStopped):
- accessors.
- UIProcess/mac/WindowServerConnection.mm: Added.
(WebKit::WindowServerConnection::applicationBecameOccluded):
(WebKit::WindowServerConnection::applicationWindowModificationsStopped):
(WebKit::WindowServerConnection::applicationBecameVisible):
(WebKit::WindowServerConnection::applicationWindowModificationsStarted):
- handle notifications from the WindowServer.
(WebKit::WindowServerConnection::windowServerConnectionStateChanged):
- broadcast the state change.
(WebKit::WindowServerConnection::shared):
- accessor for singleton object.
(WebKit::WindowServerConnection::WindowServerConnection):
- constructor inizializes fields & register notification handlers.
- WebKit2.xcodeproj/project.pbxproj:
- added new files.
- config.h:
- added HAVE_WINDOW_SERVER_OCCLUSION_NOTIFICATIONS.
- 6:00 PM Changeset in webkit [161245] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r161140.
- platform/efl/fast/table/dynamic-caption-add-before-child-expected.png:
- platform/efl/fast/table/dynamic-caption-add-before-child-expected.txt:
- 5:32 PM Changeset in webkit [161244] by
-
- 3 edits2 adds in trunk
Crash in WebCore::translateIntersectionPointsToSkipInkBoundaries
https://bugs.webkit.org/show_bug.cgi?id=126252
Reviewed by Alexey Proskuryakov.
Source/WebCore:
lastIntermediate was a iterator pointing into a Vector, which was being re-used
even while appending to the Vector. If any of the append operators triggered
a realloc, the iterator would point to the old free'ed memory.
Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-crash-many-gaps.html
- rendering/InlineTextBox.cpp:
(WebCore::translateIntersectionPointsToSkipInkBoundaries):
LayoutTests:
This test causes intermediateTuples, a Vector of tuples of floats, to have enough
entries to cause a realloc. In my tests, the realloc seems to always allocate the
next area of memory (without unmapping any old pages), so this test only crashes
if guardMalloc is used.
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-crash-many-gaps-expected.txt: Added.
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-crash-many-gaps.html: Added.
- 5:19 PM Changeset in webkit [161243] by
-
- 2 edits in trunk/Tools
[GTK] fixing ycm_extra_conf.py file
https://bugs.webkit.org/show_bug.cgi?id=126371
It's an attempt to fix three problems with the current ycm_extra_conf file.
The current implementation assumes that it's a symlink, which is not true.
Usually python creates a pyc file, and this is what you get in file.
the .pyc is not a symlink, and the current implementation doesn't work
if that's the case.
It also assumes that the user is in the root folder.
If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an
exception since "flag" doesn't exists.
All those things were fixed.
Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2014-01-02
Reviewed by Martin Robinson.
- gtk/ycm_extra_conf.py:
(transform_relative_paths_to_absolute_paths):
- 5:18 PM Changeset in webkit [161242] by
-
- 2 edits in trunk/Source/WebCore
[WebGL] Correct symbol lookup logic to handle 1-element arrays
https://bugs.webkit.org/show_bug.cgi?id=126411
<rdar://problem/15394564>
Reviewed by Dean Jackson.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getUniformLocation): Revise code to handle the case of single-element
arrays.
- 4:40 PM Changeset in webkit [161241] by
-
- 79 edits32 adds22 deletes in trunk
Update Promises to the https://github.com/domenic/promises-unwrapping spec
https://bugs.webkit.org/show_bug.cgi?id=120954
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Update Promises to the revised spec. Notable changes:
- JSPromiseResolver is gone.
- TaskContext has been renamed Microtask and now has a virtual run() function.
- Instead of using custom InternalFunction subclasses, JSFunctions are used with PrivateName properties for internal slots.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- interpreter/CallFrame.h:
(JSC::ExecState::promiseConstructorTable):
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
- runtime/CommonIdentifiers.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
(JSC::JSGlobalObject::queueMicrotask):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::promiseConstructor):
(JSC::JSGlobalObject::promisePrototype):
(JSC::JSGlobalObject::promiseStructure):
- runtime/JSPromise.cpp:
(JSC::JSPromise::create):
(JSC::JSPromise::JSPromise):
(JSC::JSPromise::finishCreation):
(JSC::JSPromise::visitChildren):
(JSC::JSPromise::reject):
(JSC::JSPromise::resolve):
(JSC::JSPromise::appendResolveReaction):
(JSC::JSPromise::appendRejectReaction):
(JSC::triggerPromiseReactions):
- runtime/JSPromise.h:
(JSC::JSPromise::status):
(JSC::JSPromise::result):
(JSC::JSPromise::constructor):
- runtime/JSPromiseCallback.cpp: Removed.
- runtime/JSPromiseCallback.h: Removed.
- runtime/JSPromiseConstructor.cpp:
(JSC::constructPromise):
(JSC::JSPromiseConstructor::getCallData):
(JSC::JSPromiseConstructorFuncCast):
(JSC::JSPromiseConstructorFuncResolve):
(JSC::JSPromiseConstructorFuncReject):
- runtime/JSPromiseConstructor.h:
- runtime/JSPromiseDeferred.cpp: Added.
(JSC::JSPromiseDeferred::create):
(JSC::JSPromiseDeferred::JSPromiseDeferred):
(JSC::JSPromiseDeferred::finishCreation):
(JSC::JSPromiseDeferred::visitChildren):
(JSC::createJSPromiseDeferredFromConstructor):
(JSC::updateDeferredFromPotentialThenable):
- runtime/JSPromiseDeferred.h: Added.
(JSC::JSPromiseDeferred::createStructure):
(JSC::JSPromiseDeferred::promise):
(JSC::JSPromiseDeferred::resolve):
(JSC::JSPromiseDeferred::reject):
- runtime/JSPromiseFunctions.cpp: Added.
(JSC::deferredConstructionFunction):
(JSC::createDeferredConstructionFunction):
(JSC::identifyFunction):
(JSC::createIdentifyFunction):
(JSC::promiseAllCountdownFunction):
(JSC::createPromiseAllCountdownFunction):
(JSC::promiseResolutionHandlerFunction):
(JSC::createPromiseResolutionHandlerFunction):
(JSC::rejectPromiseFunction):
(JSC::createRejectPromiseFunction):
(JSC::resolvePromiseFunction):
(JSC::createResolvePromiseFunction):
(JSC::throwerFunction):
(JSC::createThrowerFunction):
- runtime/JSPromiseFunctions.h: Added.
- runtime/JSPromisePrototype.cpp:
(JSC::JSPromisePrototypeFuncThen):
(JSC::JSPromisePrototypeFuncCatch):
- runtime/JSPromiseReaction.cpp: Added.
(JSC::createExecutePromiseReactionMicroTask):
(JSC::ExecutePromiseReactionMicroTask::run):
(JSC::JSPromiseReaction::create):
(JSC::JSPromiseReaction::JSPromiseReaction):
(JSC::JSPromiseReaction::finishCreation):
(JSC::JSPromiseReaction::visitChildren):
- runtime/JSPromiseReaction.h: Added.
(JSC::JSPromiseReaction::createStructure):
(JSC::JSPromiseReaction::deferred):
(JSC::JSPromiseReaction::handler):
- runtime/JSPromiseResolver.cpp: Removed.
- runtime/JSPromiseResolver.h: Removed.
- runtime/JSPromiseResolverConstructor.cpp: Removed.
- runtime/JSPromiseResolverConstructor.h: Removed.
- runtime/JSPromiseResolverPrototype.cpp: Removed.
- runtime/JSPromiseResolverPrototype.h: Removed.
- runtime/Microtask.h: Added.
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::~VM):
- runtime/VM.h:
Source/WebCore:
- ForwardingHeaders/runtime/JSPromiseDeferred.h: Added.
- ForwardingHeaders/runtime/JSPromiseResolver.h: Removed.
- bindings/js/JSDOMGlobalObjectTask.cpp:
(WebCore::JSGlobalObjectTask::JSGlobalObjectTask):
- bindings/js/JSDOMGlobalObjectTask.h:
- bindings/js/JSDOMPromise.cpp:
(WebCore::DeferredWrapper::DeferredWrapper):
(WebCore::DeferredWrapper::promise):
(WebCore::DeferredWrapper::resolve):
(WebCore::DeferredWrapper::reject):
- bindings/js/JSDOMPromise.h:
(WebCore::DeferredWrapper::resolve):
(WebCore::DeferredWrapper::reject):
(WebCore::DeferredWrapper::resolve<String>):
(WebCore::DeferredWrapper::resolve<bool>):
(WebCore::char>>):
(WebCore::DeferredWrapper::reject<String>):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::queueTaskToEventLoop):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::digest):
(WebCore::JSSubtleCrypto::generateKey):
(WebCore::JSSubtleCrypto::importKey):
(WebCore::JSSubtleCrypto::exportKey):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey):
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):
- bindings/js/JSWorkerGlobalScopeBase.h:
LayoutTests:
- crypto/subtle/argument-conversion.html:
- crypto/subtle/resources/common.js:
- crypto/subtle/sha-1.html:
- crypto/subtle/sha-224.html:
- crypto/subtle/sha-256.html:
- crypto/subtle/sha-384.html:
- crypto/subtle/sha-512.html:
- js/dom/Promise-already-fulfilled-expected.txt: Removed.
- js/dom/Promise-already-fulfilled.html: Removed.
- js/dom/Promise-already-rejected.html:
- js/dom/Promise-already-resolved.html:
- js/dom/Promise-catch-expected.txt:
- js/dom/Promise-catch-in-workers-expected.txt:
- js/dom/Promise-catch.html:
- js/dom/Promise-chain.html:
- js/dom/Promise-exception-expected.txt:
- js/dom/Promise-exception.html:
- js/dom/Promise-expected.txt:
- js/dom/Promise-fulfill-expected.txt: Removed.
- js/dom/Promise-fulfill-in-workers-expected.txt: Removed.
- js/dom/Promise-fulfill-in-workers.html: Removed.
- js/dom/Promise-fulfill.html: Removed.
- js/dom/Promise-init-callback-receiver-expected.txt: Added.
- js/dom/Promise-init-callback-receiver.html: Added.
- js/dom/Promise-init-expected.txt:
- js/dom/Promise-init-in-workers-expected.txt:
- js/dom/Promise-init.html:
- js/dom/Promise-onFulfilled-deep-expected.txt: Added.
- js/dom/Promise-onFulfilled-deep.html: Added.
- js/dom/Promise-onRejected-deep-expected.txt: Added.
- js/dom/Promise-onRejected-deep.html: Added.
- js/dom/Promise-reject.html:
- js/dom/Promise-resolve-chain.html:
- js/dom/Promise-resolve-expected.txt:
- js/dom/Promise-resolve-in-workers-expected.txt:
- js/dom/Promise-resolve-state-expected.txt: Added.
- js/dom/Promise-resolve-state-in-workers-expected.txt: Added.
- js/dom/Promise-resolve-state-in-workers.html: Added.
- js/dom/Promise-resolve-state.html: Added.
- js/dom/Promise-resolve-with-itself-expected.txt: Added.
- js/dom/Promise-resolve-with-itself.html: Added.
- js/dom/Promise-resolve-with-then-exception.html:
- js/dom/Promise-resolve-with-then-fulfill-expected.txt:
- js/dom/Promise-resolve-with-then-fulfill.html:
- js/dom/Promise-resolve-with-then-reject-expected.txt:
- js/dom/Promise-resolve-with-then-reject.html:
- js/dom/Promise-resolve.html:
- js/dom/Promise-simple-expected.txt:
- js/dom/Promise-simple-fulfill-expected.txt: Removed.
- js/dom/Promise-simple-fulfill-inside-callback-expected.txt: Removed.
- js/dom/Promise-simple-fulfill-inside-callback.html: Removed.
- js/dom/Promise-simple-fulfill.html: Removed.
- js/dom/Promise-simple-in-workers-expected.txt:
- js/dom/Promise-simple-resolve-expected.txt: Added.
- js/dom/Promise-simple-resolve.html: Added.
- js/dom/Promise-simple.html:
- js/dom/Promise-static-all-expected.txt: Added.
- js/dom/Promise-static-all.html: Added.
- js/dom/Promise-static-cast-expected.txt: Added.
- js/dom/Promise-static-cast.html: Added.
- js/dom/Promise-static-fulfill-expected.txt: Removed.
- js/dom/Promise-static-fulfill.html: Removed.
- js/dom/Promise-static-race-expected.txt: Added.
- js/dom/Promise-static-race.html: Added.
- js/dom/Promise-static-resolve.html:
- js/dom/Promise-then-callback-receiver-expected.txt: Added.
- js/dom/Promise-then-callback-receiver.html: Added.
- js/dom/Promise-then-expected.txt:
- js/dom/Promise-then-in-workers-expected.txt:
- js/dom/Promise-then-without-callbacks.html:
- js/dom/Promise-then.html:
- js/dom/Promise-types-expected.txt:
- js/dom/Promise-types.html:
- js/dom/Promise.html:
- js/resources/Promise-catch-in-workers.js:
- js/resources/Promise-fulfill-in-workers.js: Removed.
- js/resources/Promise-init-in-workers.js:
- js/resources/Promise-reject-in-workers.js:
- js/resources/Promise-resolve-in-workers.js:
- js/resources/Promise-resolve-state-in-workers.js: Added.
- js/resources/Promise-simple-in-workers.js:
- js/resources/Promise-then-in-workers.js:
- js/resources/Promise-then-without-callbacks-in-workers.js:
- 4:24 PM Changeset in webkit [161240] by
-
- 7 edits in trunk/Source/JavaScriptCore
Add support for StoreBarrier and friends to the FTL
https://bugs.webkit.org/show_bug.cgi?id=126040
Reviewed by Filip Pizlo.
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileStoreBarrier):
(JSC::FTL::LowerDFGToLLVM::compileConditionalStoreBarrier):
(JSC::FTL::LowerDFGToLLVM::compileStoreBarrierWithNullCheck):
(JSC::FTL::LowerDFGToLLVM::loadMarkByte):
(JSC::FTL::LowerDFGToLLVM::emitStoreBarrier):
- heap/Heap.cpp:
(JSC::Heap::Heap):
- heap/Heap.h:
(JSC::Heap::writeBarrierBuffer):
- 4:10 PM Changeset in webkit [161239] by
-
- 3 edits in trunk/Source/WebCore
ImageBufferBackingStoreCache should use DeferrableOneShotTimer
https://bugs.webkit.org/show_bug.cgi?id=126155
Reviewed by Anders Carlsson.
Since ImageBufferBackingStoreCache's purge timer is pushed out every time
a backing store is deallocated, we can easily waste a lot of time rescheduling
the timer. Since it's a cache purge timer and doesn't need that kind of precision,
adopt DeferrableOneShotTimer, which is much more performant when deferred frequently.
- platform/graphics/cg/ImageBufferBackingStoreCache.cpp:
(WebCore::ImageBufferBackingStoreCache::ImageBufferBackingStoreCache):
(WebCore::ImageBufferBackingStoreCache::timerFired):
(WebCore::ImageBufferBackingStoreCache::schedulePurgeTimer):
- platform/graphics/cg/ImageBufferBackingStoreCache.h:
- 3:58 PM Changeset in webkit [161238] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
Addressed review comments in https://bugs.webkit.org/show_bug.cgi?id=126393#c5.
Reviewed by Michael Saboff.
- offlineasm/cloop.rb:
- 3:50 PM Changeset in webkit [161237] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
Address review comments in https://bugs.webkit.org/show_bug.cgi?id=126409#c3
- llint/LowLevelInterpreter32_64.asm:
- 3:35 PM Changeset in webkit [161236] by
-
- 2 edits in trunk/Tools
Bindings tests results links are broken at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126402
Reviewed by Tim Horton.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.bindingsTestResultsURLForIteration): Fixed a typo that was there
since the beginning.
- 3:32 PM Changeset in webkit [161235] by
-
- 4 edits5 adds in trunk
Allow ImageBuffer to re-use IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=125477
Source/WebCore:
Reviewed by Geoff Garen. Modifications reviewed by Tim Horton.
This patch is taken from r160945, but the modifications to ImageBufferCG.cpp
have been reverted.
This test adds a static class, ImageBufferBackingStoreCache, that vends
IOSurfaces. It remembers IOSurfaces that have been returned to it until
a configurable timeout.
The storage used by this class is in the form of a HashMap from a
bucketed size to the IOSurface. There are many other data structures
that could be used, but this implementation gives a 80% hit rate on
normal browsing of some example sites with Canvas and
text-decoration-skip: ink. Because the buckets are fairly
small (rounding the width and height up to multiples of 8), traversing the
bucket contents takes on average 2 steps.
Test: fast/canvas/canvas-backing-store-reuse.html
- WebCore.xcodeproj/project.pbxproj: Added new caching class
- platform/graphics/cg/ImageBufferBackingStoreCache.cpp: Added.
(WebCore::createIOSurface): Copied from ImageBufferCG.cpp
(WebCore::ImageBufferBackingStoreCache::timerFired): Forget the cache
contents
(WebCore::ImageBufferBackingStoreCache::schedulePurgeTimer):
(WebCore::ImageBufferBackingStoreCache::get): Static getter
(WebCore::ImageBufferBackingStoreCache::ImageBufferBackingStoreCache):
(WebCore::ImageBufferBackingStoreCache::insertIntoCache): Memory-management
creation function
(WebCore::ImageBufferBackingStoreCache::takeFromCache): Memory-management
deletion function
(WebCore::ImageBufferBackingStoreCache::isAcceptableSurface): Does this cached
IOSurface fit the bill?
(WebCore::ImageBufferBackingStoreCache::tryTakeFromCache): Lookup
a bucket and walk through its contents
(WebCore::ImageBufferBackingStoreCache::getOrAllocate): Public function
for clients who want a IOSurface from the cache
(WebCore::ImageBufferBackingStoreCache::deallocate): Public
function for clients to return an IOSurface to the pool
- platform/graphics/cg/ImageBufferBackingStoreCache.h: Added.
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::~ImageBuffer):
PerformanceTests:
Reviewed by Geoff Garen.
This test times creating a variety of different sizes of canvases
once some have already been created. The second creation of the
canvases should re-use the existing IOSurfaces.
- Canvas/reuse.html: Added.
LayoutTests:
Reviewed by Geoff Garen.
Now that we're re-using the backing store of canvases, this
test makes sure that if we draw to a canvas, then destroy it,
then create a new canvas (which should share the same backing
store) that it doesn't have the stale data in it
- fast/canvas/canvas-backing-store-reuse-expected.txt: Added.
- fast/canvas/canvas-backing-store-reuse.html: Added.
- 3:28 PM Changeset in webkit [161234] by
-
- 3 edits in branches/jsCStack/Source/JavaScriptCore
CStack LLInt 32-bit should build
https://bugs.webkit.org/show_bug.cgi?id=126409
Not yet reviewed.
And the stuff we do to make it build should at least try to be correct.
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 3:24 PM Changeset in webkit [161233] by
-
- 2 edits in trunk/Tools
"+" is very confusing at http://build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126400
Reviewed by Tim Horton.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._appendPendingRevisionCount): Instead of listing open
source and internal counts separately, simply add them. One can always open a popover
for more detail.
- 3:20 PM Changeset in webkit [161232] by
-
- 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog
Added a missing word in a change comment, and updated review status for:
https://bugs.webkit.org/show_bug.cgi?id=126321
https://bugs.webkit.org/show_bug.cgi?id=126328
https://bugs.webkit.org/show_bug.cgi?id=126334
https://bugs.webkit.org/show_bug.cgi?id=126405
- 3:14 PM Changeset in webkit [161231] by
-
- 2 edits in trunk/Source/WebCore
Video-seek-with-negative-playback was flaky.
https://bugs.webkit.org/show_bug.cgi?id=126379
Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-02
Reviewed by Eric Carlson.
No new tests. Covered by existing tests.
m_player->setRate() should be called before updating m_playbackRate, because potentiallyPlaying() depends
on endedPlayback(), which checks m_playbackRate.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setPlaybackRate):
- 2:57 PM Changeset in webkit [161230] by
-
- 13 edits1 add in trunk/Source/JavaScriptCore
Storing new CopiedSpace memory into a JSObject should fire a write barrier
https://bugs.webkit.org/show_bug.cgi?id=126025
Reviewed by Filip Pizlo.
Technically this is creating a pointer between a (potentially) old generation object and a young
generation chunk of memory, thus there needs to be a barrier.
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGOperations.cpp:
- heap/CopyWriteBarrier.h: Added. This class functions similarly to the WriteBarrier class. It
acts as a proxy for pointers to CopiedSpace. Assignments to the field cause a write barrier to
fire for the object that is the owner of the CopiedSpace memory. This is to ensure during nursery
collections that objects with new backing stores are visited, even if they are old generation objects.
(JSC::CopyWriteBarrier::CopyWriteBarrier):
(JSC::CopyWriteBarrier::operator!):
(JSC::CopyWriteBarrier::operator UnspecifiedBoolType*):
(JSC::CopyWriteBarrier::get):
(JSC::CopyWriteBarrier::operator*):
(JSC::CopyWriteBarrier::operator->):
(JSC::CopyWriteBarrier::set):
(JSC::CopyWriteBarrier::setWithoutWriteBarrier):
(JSC::CopyWriteBarrier::clear):
- heap/Heap.h:
- runtime/JSArray.cpp:
(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::shiftCountWithArrayStorage):
(JSC::JSArray::unshiftCountWithArrayStorage):
- runtime/JSCell.h:
(JSC::JSCell::unvalidatedStructure):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::slowDownAndWasteMemory):
- runtime/JSObject.cpp:
(JSC::JSObject::copyButterfly):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::putByIndex):
(JSC::JSObject::enterDictionaryIndexingModeWhenArrayStorageAlreadyExists):
(JSC::JSObject::createInitialIndexedStorage):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes):
(JSC::JSObject::countElements):
(JSC::JSObject::increaseVectorLength):
(JSC::JSObject::ensureLengthSlow):
- runtime/JSObject.h:
(JSC::JSObject::butterfly):
(JSC::JSObject::setStructureAndButterfly):
(JSC::JSObject::setButterflyWithoutChangingStructure):
(JSC::JSObject::JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
- runtime/MapData.cpp:
(JSC::MapData::ensureSpaceForAppend):
- runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
- 2:43 PM Changeset in webkit [161229] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack: Interpreter::executeCall() should check for exceptions after calling callToNativeFunction().
https://bugs.webkit.org/show_bug.cgi?id=126405.
Not yet reviewed.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
- executeCall() was expecting to return a non-null JSValue but neglected to check if an exception was thrown during a call to callToNativeFunction. We now check if an exception was thrown, and if so, we set the result to jsNull() the same way that JITCode::execute() does.
- 2:35 PM Changeset in webkit [161228] by
-
- 23 edits in trunk/Source
Source/WebCore: [iOS] Tapping any link crashes in WebCore::EventHandler::mouseMoved()
(also crashes when scrolling certain sites)
https://bugs.webkit.org/show_bug.cgi?id=126401
<rdar://problem/15739334>
Patch by Daniel Bates <dabates@apple.com> on 2014-01-02
Reviewed by Tim Horton.
- page/ios/EventHandlerIOS.mm:
(WebCore::currentEventSlot): Make the shared variable have static-storage duration.
Source/WebKit/mac: Remove WindowIsVisible
https://bugs.webkit.org/show_bug.cgi?id=126270
Reviewed by Tim Horton.
We currently track visibility in two ways - ViewState::IsVisible and ViewState::WindowIsVisible.
The latter detects that the content is hidden in fewer cases than the former, and as such, the
former is always preferable.
This affects the hidden state provided to FocusController::contentAreaDidShowOrHide and to
Plugin::windowVisibilityChanged.
- WebView/WebView.mm:
(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):
- rename ContainingWindowIsVisible -> ContentIsVisible.
Source/WebKit2: Remove WindowIsVisible
https://bugs.webkit.org/show_bug.cgi?id=126270
Reviewed by Tim Horton.
We currently track visibility in two ways - ViewState::IsVisible and ViewState::WindowIsVisible.
The latter detects that the content is hidden in fewer cases than the former, and as such, the
former is always preferable.
This affects the hidden state provided to FocusController::contentAreaDidShowOrHide and to
Plugin::windowVisibilityChanged.
- Shared/ViewState.h:
- remove WindowIsVisible.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
- remove isWindowVisible.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidMiniaturize:]):
(-[WKView _windowDidDeminiaturize:]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
- remove ViewState::WindowIsVisible.
- UIProcess/PageClient.h:
- remove isWindowVisible.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateViewState):
- remove handling of ViewState::WindowIsVisible.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setIsVisible):
(WebKit::PluginView::didInitializePlugin):
- WebProcess/Plugins/PluginView.h:
- setWindowIsVisible -> setIsVisible.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setViewIsVisible):
(WebKit::WebPage::setViewState):
(WebKit::WebPage::windowAndWebPageAreFocused):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::isVisible):
- remove m_windowIsVisible, setWindowIsVisible (implementation moved to setViewIsVisible).
- 2:32 PM Changeset in webkit [161227] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Tapping any link crashes in WebCore::EventHandler::mouseMoved()
(also crashes when scrolling certain sites)
https://bugs.webkit.org/show_bug.cgi?id=126401
<rdar://problem/15739334>
Reviewed by Tim Horton.
- page/ios/EventHandlerIOS.mm:
(WebCore::currentEventSlot): Make the shared variable have static-storage duration.
- 2:20 PM Changeset in webkit [161226] by
-
- 8 edits in trunk/Source/WebKit2
Refactor ViewState handling for drawing area / plugins
https://bugs.webkit.org/show_bug.cgi?id=126272
Reviewed by Tim Horton.
Instead of all ViewState changes being handled by the WebPage, notify the DrawingArea & PluginView to better encapsulate.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::viewStateDidChange):
(WebKit::PluginView::platformViewStateDidChange):
- added, handle changes in ViewState relevant to PluginView.
(WebKit::PluginView::didInitializePlugin):
- helper function removed.
- WebProcess/Plugins/PluginView.h:
- added/removed function declarations.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::viewStateDidChange):
- declare viewStateDidChange.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setActive):
- no need to notify plugin.
(WebKit::WebPage::setViewIsVisible):
- no need to notify drawing area.
(WebKit::WebPage::setViewState):
- send viewStateDidChange to drawing area / plugin.
(WebKit::WebPage::setWindowIsVisible):
- no need to notify plugin.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::layerHostingMode):
- removed setLayerHostingMode.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- declare viewStateDidChange.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::viewStateDidChange):
- added, handle changes in ViewState relevant to DrawingArea.
- 2:16 PM Changeset in webkit [161225] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
Address review feedback in https://bugs.webkit.org/show_bug.cgi?id=126387#c3
- llint/LowLevelInterpreter.asm:
- 2:15 PM Changeset in webkit [161224] by
-
- 2 edits in trunk/Source/WebKit2
Merge didMoveOnscreen / page visibility to isVisible
https://bugs.webkit.org/show_bug.cgi?id=126268
Build fix.
- UIProcess/WebContext.h: Removed some accidental input.
- 2:06 PM Changeset in webkit [161223] by
-
- 17 edits in trunk/Source
Merge didMoveOnscreen / page visibility to isVisible
https://bugs.webkit.org/show_bug.cgi?id=126268
Reviewed by Tim Horton.
The onscreen state most closely tracks view visibility (though currently
also tracks a mix of in-window state). Make more consistent, simplify,
and move all animation suspension logic to Page, so it can be controlled
by the PageThrottler.
Source/WebCore:
- WebCore.exp.in:
- page/EventHandler.cpp:
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
- page/FrameView.cpp:
(WebCore::FrameView::shouldSetCursor):
- page/Page.cpp:
(WebCore::Page::Page):
- initialize new variables.
(WebCore::Page::setIsVisible):
- merge setVisibilityState, didMoveOnscreen, willMoveOffscreen.
(WebCore::Page::setIsPrerender):
- switches visibility state from hidden to prerender.
(WebCore::Page::visibilityState):
- computed from m_isVisible, m_isPrerender.
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):
- m_visibilityState -> m_isVisible.
- page/Page.h:
- remove didMoveOnscreen/willMoveOffscreen m_isOnscreen & m_visibilityState -> m_isVisible & m_isPrerender setVisibilityState -> setIsVisible & setIsPrerender.
(WebCore::Page::isVisible):
- isOnscreen -> isVisible.
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setPageVisibilityState):
- setVisibilityState -> setIsVisible.
Source/WebKit/efl:
- ewk/ewk_view.cpp:
(ewk_view_visibility_state_set):
- setVisibilityState -> setIsVisible/setIsPrerender.
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setPageVisibility):
- setVisibilityState -> setIsVisible/setIsPrerender.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _updateVisibilityState]):
- _setVisibilityState:isInitialState: -> _setIsVisibile:isInitialState:.
(-[WebView _setIsVisible:isInitialState:]):
- added.
(-[WebView _setVisibilityState:isInitialState:]):
- setVisibilityState -> setIsVisible/setIsPrerender.
(-[WebView viewWillMoveToWindow:]):
(-[WebView viewDidMoveToWindow]):
- remove redundant calls to willMoveOffscreen/didMoveOnscreen (this is handled by _updateVisibilityState).
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setViewIsVisible):
- updateVisibilityState -> setIsVisible.
(WebKit::WebPage::setIsInWindow):
- remove redundant willMoveOffscreen/didMoveOnscreen calls - this is handled by setIsVisible.
(WebKit::WebPage::setMayStartMediaWhenInWindow):
- isOnscreen -> isInWindow. We start media when the view is in a window, not when the view is visible.
(WebKit::WebPage::setVisibilityStatePrerender):
- setVisibilityState -> setIsPrerender.
- 1:34 PM Changeset in webkit [161222] by
-
- 17 edits in trunk/Source/WebCore
Update bindings test results
- 1:00 PM Changeset in webkit [161221] by
-
- 4 edits in trunk/Source/WebKit/gtk
[GTK] Fix mismatched header guards in private WK1 header files
https://bugs.webkit.org/show_bug.cgi?id=126390
Reviewed by Martin Robinson.
Fix three mismatched header guards that are producing warnings when building with Clang.
- webkit/webkitsecurityoriginprivate.h:
- webkit/webkitviewportattributesprivate.h:
- webkit/webkitwebnavigationactionprivate.h:
- 12:56 PM Changeset in webkit [161220] by
-
- 27 edits in trunk/Source
Refactor PutPropertySlot to be aware of custom properties
https://bugs.webkit.org/show_bug.cgi?id=126187
Reviewed by Antti Koivisto.
Source/JavaScriptCore:
Refactor PutPropertySlot, making the constructor take the thisValue
used as a target. This results in a wide range of boilerplate changes
to pass the new parameter.
- API/JSObjectRef.cpp:
(JSObjectSetProperty):
- dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
- jit/JITOperations.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/Arguments.cpp:
(JSC::Arguments::putByIndex):
- runtime/ArrayPrototype.cpp:
(JSC::putProperty):
(JSC::arrayProtoFuncPush):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::putToPrimitiveByIndex):
- runtime/JSCell.cpp:
(JSC::JSCell::putByIndex):
- runtime/JSFunction.cpp:
(JSC::JSFunction::put):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::putByIndex):
- runtime/JSONObject.cpp:
(JSC::Walker::walk):
- runtime/JSObject.cpp:
(JSC::JSObject::putByIndex):
(JSC::JSObject::putDirectNonIndexAccessor):
(JSC::JSObject::deleteProperty):
- runtime/JSObject.h:
(JSC::JSObject::putDirect):
- runtime/Lookup.h:
(JSC::putEntry):
(JSC::lookupPut):
- runtime/PutPropertySlot.h:
(JSC::PutPropertySlot::PutPropertySlot):
(JSC::PutPropertySlot::setCustomProperty):
(JSC::PutPropertySlot::thisValue):
(JSC::PutPropertySlot::isCacheable):
Source/WebCore:
Update the bindings code generation and custom objects
to the new function signatures
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::put):
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject setValue:forKey:]):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterface::putByIndex):
- bridge/NP_jsobject.cpp:
(_NPN_SetProperty):
Source/WebKit/mac:
Update for new method signatures.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::setProperty):
Source/WebKit2:
Update for new method signatures.
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::setProperty):
- 12:42 PM Changeset in webkit [161219] by
-
- 15 edits in branches/jsCStack/Source/JavaScriptCore
CStack: Get the C Loop LLINT to build again.
https://bugs.webkit.org/show_bug.cgi?id=126393.
Not yet reviewed.
- jit/JITCode.cpp:
(JSC::DirectJITCode::addressForCall):
- #if ENABLE(JIT) out the use of RegisterPreservationWrappers.
- llint/LLIntCLoop.cpp:
(JSC::LLInt::CLoop::initialize):
- Update CLoop::initialize() to call the new CLoop::execute().
- llint/LLIntCLoop.h:
- CLoop::execute() now takes the arguments for callToJavaScript, and it effectively acts as the gateway for re-entering the VM in place for callToJavaScript (and callToNativeFunction).
CLoop::execute() should set up the "CPU" execution environment i.e.
CLoopRegisters should be initialized with the incoming args, stack
pointer, base pointer, and return address. We'll take care of this
part in a subsequent patch.
- llint/LLIntOpcode.h:
- Added C loop only llint opcodes llint_call_to_javascript, and llint_call_to_native_function. These will be used as the opcodeID for the llint interpreter blob for callToJavaScript and callToNativeFunction.
Meanwhile, the LLINT thunk will provide C functions for callToJavaScript
and callToNativeFunction which calls CLoop::execute() with the opcodeID
for llint_call_to_javascript and llint_call_to_native_function
respectively.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::llint_throw_stack_overflow_error):
- Changed llint_throw_stack_overflow_error()'s return type so that it is easier for the C Loop LLINT to generate boilerplate code to call it.
The return value is not used by anyone. But since this is code that
rarely executed, we'll opt to take this small hit of returning an
unused value rather than having to spin some way to make the C Loop
offlineasm smarter only for handling this one case.
- llint/LLIntSlowPaths.h:
- llint/LLIntThunks.cpp:
(JSC::callToJavaScript):
(JSC::callToNativeFunction):
- Updated to call the new CLoop::execute().
We're going to try to use the doCallToJavaScript code defined in the
LLINT assembly instead of spinning our own version in C++ as we did
previously.
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter.cpp:
(JSC::CLoopRegister::operator ExecState*):
(JSC::CLoopRegister::operator Instruction*):
(JSC::CLoopRegister::operator VM*):
(JSC::CLoopRegister::operator ProtoCallFrame*):
- Added these cast operators to the CLoopRegister to simplify the C Loop call slow path boilerplate.
(JSC::CLoop::execute):
- llint/LowLevelInterpreter64.asm:
- offlineasm/cloop.rb:
- Define C Loop registers to match ARM as expected by the code.
- Replaced a #error with a RELEASE_ASSERT_NOT_REACHED().
- Reworked the call slow path boilerplate to take advantage of the CLoopRegister cast operators. We need this in order to be able to call slow path functions that take different argument types e.g. llint_throw_stack_overflow_error().
- runtime/CommonSlowPaths.cpp:
(JSC::setupArityCheckData):
- runtime/VM.cpp:
(JSC::VM::getHostFunction):
- runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::requiredCapacity):
- 12:15 PM Changeset in webkit [161218] by
-
- 13 edits in trunk/Source/JavaScriptCore
Rationalize DFG DCE
https://bugs.webkit.org/show_bug.cgi?id=125523
Reviewed by Mark Hahnenberg.
Adds the ability to DCE more things. It's now the case that if a node is completely
pure, we clear NodeMustGenerate and the node becomes a DCE candidate.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::cleanVariables):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::clobbersWorld):
- dfg/DFGNodeType.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAdd):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileValueAdd):
- 12:11 PM Changeset in webkit [161217] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
Some crashes in C stack on Mountain Lion, for example on crypto-aes, due to misaligned stack
https://bugs.webkit.org/show_bug.cgi?id=126394
Not yet reviewed.
The specialized math thunks currently ensure that inside the thunk, the stack is aligned. But when they
call the wrapper, the wrapper previously didn't align the stack. This patch fixes that.
I think that we can drop the wrappers on X86-64 and maybe on other platforms as well. I'll leave that to
a future patch.
- jit/ThunkGenerators.cpp:
- 12:06 PM Changeset in webkit [161216] by
-
- 3 edits in trunk/Tools
Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
https://bugs.webkit.org/show_bug.cgi?id=126391
Reviewed by Dan Bernstein.
Make it conditional, as trac.webkit.org doesn't work when withCredentials is enabled.
One can request credentials use via Initialization.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac):
(Trac.prototype.update):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
(loadXML):
- 12:03 PM Changeset in webkit [161215] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r160846.
http://trac.webkit.org/changeset/160846
https://bugs.webkit.org/show_bug.cgi?id=126395
Breaks build scripts for Windows when Visual Studio is not
installed in Program Files (Requested by rfong on #webkit).
- Scripts/webkitdirs.pm:
(visualStudioInstallDir):
- 11:45 AM Changeset in webkit [161214] by
-
- 3 edits in trunk/Tools
[GTK] [CMake] run-gtk-tests should run with the cmake build
https://bugs.webkit.org/show_bug.cgi?id=126341
Reviewed by Carlos Garcia Campos.
- Scripts/run-gtk-tests:
(TestRunner.init): Use the new calling conventions for the common script.
(TestRunner._setup_testing_environment): Ditto.
- gtk/common.py:
(set_build_types): Added set_build_types, to avoid having build_type arguments
for all functions in common.
(binary_build_path): Added this function which gets the path to the built binaries.
(get_build_path): Removed the build_types argument.
(build_path): Removed the build_types argument and call get_build_path directly now.
- 11:42 AM Changeset in webkit [161213] by
-
- 2 edits in trunk/Tools
https://bugs.webkit.org/show_bug.cgi?id=126391
Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
Rubber-stamped by Dan Bernstein.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
(loadXML): Quick and dirty fix, with a FIXME.
- 11:41 AM Changeset in webkit [161212] by
-
- 11 edits2 copies in trunk/Source
Add AsyncScrollingCoordinator, which is a base class for threaded and future remote ScrollingCoordinators
https://bugs.webkit.org/show_bug.cgi?id=126389
Source/WebCore:
Reviewed by Tim Horton.
Add AsyncScrollingCoordinator, a ScrollingCoordinator that knows about ScrollingStateTrees
and ScrollingTrees, but leaves it up to subclasses to decide when and how to commit.
- WebCore.xcodeproj/project.pbxproj: Added AsyncScrollingCoordinator.*
- page/scrolling/AsyncScrollingCoordinator.cpp: Copied from Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm.
(WebCore::AsyncScrollingCoordinator::AsyncScrollingCoordinator):
(WebCore::AsyncScrollingCoordinator::~AsyncScrollingCoordinator):
(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::AsyncScrollingCoordinator::scrollableAreaScrollbarLayerDidChange):
(WebCore::AsyncScrollingCoordinator::attachToStateTree):
(WebCore::AsyncScrollingCoordinator::detachFromStateTree):
(WebCore::AsyncScrollingCoordinator::clearStateTree):
(WebCore::AsyncScrollingCoordinator::syncChildPositions):
(WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView):
(WebCore::AsyncScrollingCoordinator::updateScrollingNode):
(WebCore::AsyncScrollingCoordinator::updateViewportConstrainedNode):
(WebCore::AsyncScrollingCoordinator::setScrollLayerForNode):
(WebCore::AsyncScrollingCoordinator::setCounterScrollingLayerForNode):
(WebCore::AsyncScrollingCoordinator::setHeaderLayerForNode):
(WebCore::AsyncScrollingCoordinator::setFooterLayerForNode):
(WebCore::AsyncScrollingCoordinator::setNonFastScrollableRegionForNode):
(WebCore::AsyncScrollingCoordinator::setWheelEventHandlerCountForNode):
(WebCore::AsyncScrollingCoordinator::setScrollBehaviorForFixedElementsForNode):
(WebCore::AsyncScrollingCoordinator::setScrollbarPaintersFromScrollbarsForNode):
(WebCore::AsyncScrollingCoordinator::setSynchronousScrollingReasons):
(WebCore::AsyncScrollingCoordinator::updateMainFrameScrollLayerPosition):
(WebCore::AsyncScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView):
(WebCore::AsyncScrollingCoordinator::isRubberBandInProgress):
(WebCore::AsyncScrollingCoordinator::setScrollPinningBehavior):
(WebCore::AsyncScrollingCoordinator::scrollingStateTreeAsText):
- page/scrolling/AsyncScrollingCoordinator.h: Copied from Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h.
(WebCore::AsyncScrollingCoordinator::scrollingTree):
(WebCore::AsyncScrollingCoordinator::setScrollingTree):
(WebCore::AsyncScrollingCoordinator::scrollingStateTree):
(WebCore::AsyncScrollingCoordinator::releaseScrollingTree):
- page/scrolling/ScrollingCoordinator.h: Add casting support.
(WebCore::ScrollingCoordinator::isAsyncScrollingCoordinator):
- page/scrolling/ThreadedScrollingTree.h: commitNewTreeState() needs to be public.
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm: Lots of code moved to AsyncScrollingCoordinator.
(WebCore::ScrollingCoordinatorMac::ScrollingCoordinatorMac):
(WebCore::ScrollingCoordinatorMac::~ScrollingCoordinatorMac):
(WebCore::ScrollingCoordinatorMac::pageDestroyed):
(WebCore::ScrollingCoordinatorMac::commitTreeStateIfNeeded):
(WebCore::ScrollingCoordinatorMac::handleWheelEvent):
(WebCore::ScrollingCoordinatorMac::scheduleTreeStateCommit):
(WebCore::ScrollingCoordinatorMac::commitTreeState):
(WebCore::ScrollingCoordinatorMac::updateTiledScrollingIndicator):
Source/WebKit2:
Reviewed by Tim Horton.
Add AsyncScrollingCoordinator, a ScrollingCoordinator that knows about ScrollingStateTrees
and ScrollingTrees, but leaves it up to subclasses to decide when and how to commit.
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::addScrollingTreeForPage): The ScrollingTree is exposed on
AsyncScrollingCoordinator now, not ScrollingCoordinator, so we have to cast here.
- WebProcess/WebPage/WebPage.cpp: m_useThreadedScrolling -> m_useAsyncScrolling terminology change.
(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences): Cast to AsyncScrollingCoordinator in order
to get to the ScrollingTree.
- 11:20 AM Changeset in webkit [161211] by
-
- 4 edits in branches/jsCStack/Source/JavaScriptCore
Refactor LLInt C stack frame munging helpers so that 32-bit code paths can use them
https://bugs.webkit.org/show_bug.cgi?id=126387
Not yet reviewed.
This gets us closer to the 32-bit LLInt working on the C stack by enabling the
32-bit code paths to use the low-level stack/frame pointer munging helpers. This
patch doesn't completely ensure that these helpers actually work - the 32-bit
build is still broken - but it's a good change to land separately since it affects
64-bit code paths as well.
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 10:45 AM Changeset in webkit [161210] by
-
- 3 edits in trunk/Source/WebCore
Simplify the insides of DocumentSharedObjectPool and reduce memory usage.
Merging Blink r164152 by Elliott Sprehn.
Instead of storing an OwnPtr to an object that has a pointer to the
ShareableElementData as well as a pointer into the ShareableElementData
and the length we can just store a RefPtr to the SharableElementData.
This also reduces the memory usage of the pool by 2 pointers per entry.
- dom/DocumentSharedObjectPool.h:
- dom/DocumentSharedObjectPool.cpp:
(WebCore::attributeHash):
(WebCore::hasSameAttributes):
(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):
- 10:11 AM Changeset in webkit [161209] by
-
- 14 edits in trunk
Support <box> values computed style for 'clip-path' property
https://bugs.webkit.org/show_bug.cgi?id=126148
Reviewed by Simon Fraser.
Source/WebCore:
Calculate computed style for 'clip-path' property.
Updated tests to check for computed style.
- css/BasicShapeFunctions.cpp: Add box value bounding-box.
(WebCore::valueForBox):
(WebCore::boxForValue):
- css/CSSComputedStyleDeclaration.cpp: Return the computed style
for 'clip-path'.
(WebCore::ComputedStyleExtractor::propertyValue):
- css/DeprecatedStyleBuilder.cpp: Create CSSValueLists for 'clip-th'.
(WebCore::ApplyPropertyClipPath::applyValue):
- rendering/ClipPathOperation.h: Add bounding-box value.
(WebCore::ShapeClipPathOperation::pathForReferenceRect):
(WebCore::ShapeClipPathOperation::setReferenceBox):
(WebCore::ShapeClipPathOperation::referenceBox):
(WebCore::BoxClipPathOperation::create):
(WebCore::BoxClipPathOperation::pathForReferenceRect):
(WebCore::BoxClipPathOperation::referenceBox):
(WebCore::BoxClipPathOperation::BoxClipPathOperation):
- rendering/shapes/ShapeInfo.h: Add bounding-box value.
(WebCore::ShapeInfo::setShapeSize):
(WebCore::ShapeInfo::logicalTopOffset):
(WebCore::ShapeInfo::logicalLeftOffset):
- rendering/style/BasicShapes.cpp: Add bounding-box value.
(WebCore::BasicShape::referenceBoxSize):
- rendering/style/BasicShapes.h:
LayoutTests:
Test computed style of 'clip-path' property.
- fast/masking/parsing-clip-path-shape.html:
- 7:51 AM Changeset in webkit [161208] by
-
- 9 edits in trunk/Source/WebCore
Always resolve style from root
https://bugs.webkit.org/show_bug.cgi?id=126380
Reviewed by Andreas Kling.
Forced style resolve that does not start from the root is never really correct.
Remove the few remaining instances.
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::setResetStyleInheritance):
Update style asynchronously.
- dom/ShadowRoot.h:
- dom/Text.h:
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::createElementRenderer):
(WebCore::HTMLPlugInImageElement::documentWillSuspendForPageCache):
(WebCore::HTMLPlugInImageElement::documentDidResumeFromPageCache):
Delete the render tree synchronously on suspend and rebuild it asynchronously on resume.
No need for m_customStyleForPageCache hack.
- html/HTMLPlugInImageElement.h:
Remove m_customStyleForPageCache.
- style/StyleResolveTree.cpp:
- style/StyleResolveTree.h:
Remove Element version of resolveTree from the interface.
- svg/SVGUseElement.h:
- 7:50 AM Changeset in webkit [161207] by
-
- 11 edits2 deletes in trunk/Source/WebCore
Remove PlaceholderDocument
https://bugs.webkit.org/show_bug.cgi?id=126382
Reviewed by Andreas Kling.
Remove PlaceholderDocument class and replace it with a bit in Document.
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::createRenderTree):
- dom/Document.h:
Also make Synthesized a construction flag instead of a boolean parameter.
(WebCore::Document::createNonRenderedPlaceholder):
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::HTMLDocument):
- html/HTMLDocument.h:
(WebCore::HTMLDocument::create):
(WebCore::HTMLDocument::createSynthesizedDocument):
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::createDocument):
- loader/PlaceholderDocument.cpp: Removed.
- loader/PlaceholderDocument.h: Removed.
- pdf/ios/PDFDocument.h:
(WebCore::PDFDocument::PDFDocument):
- 5:09 AM WebKitGTK/StartHacking edited by
- Link to SpeedUpBuild for ld.gold instructions (diff)
- 5:08 AM WebKitGTK/SpeedUpBuild edited by
- Add information about how to configure ld.gold with update-alternatives (diff)
- 3:43 AM Changeset in webkit [161206] by
-
- 2 edits in trunk/Source/JavaScriptCore
Attempt to fix the build of WebCore's code generator on CMake based system
https://bugs.webkit.org/show_bug.cgi?id=126271
Reviewed by Sam Weinig.
- CMakeLists.txt:
- 1:49 AM Changeset in webkit [161205] by
-
- 8 edits in trunk/Source/WebCore
Remove public attachRenderTree
https://bugs.webkit.org/show_bug.cgi?id=126368
Reviewed by Andreas Kling.
Remove the remaining explicit render tree construction.
- dom/Document.cpp:
(WebCore::Document::createRenderTree):
Use recalcStyle() instead of calling attachRenderTree directly.
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::addText):
Remove forgotten attachTextRenderer.
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::InsertionPoint):
Remove willAttachRenderers/didAttachRenderers hack.
- html/shadow/InsertionPoint.h:
(WebCore::toInsertionPoint):
- loader/PlaceholderDocument.cpp:
(WebCore::PlaceholderDocument::createRenderTree):
Seriously, nothing to do here.
- style/StyleResolveTree.cpp:
(WebCore::Style::attachDistributedChildren):
(WebCore::Style::attachChildren):
(WebCore::Style::detachDistributedChildren):
(WebCore::Style::detachChildren):
Making attaching and detaching distributed insertion point children part of ResolveTree internals.
- style/StyleResolveTree.h:
Remove interfaces with no clients.
Jan 1, 2014:
- 10:21 PM Changeset in webkit [161204] by
-
- 2 edits in trunk/Source/WebCore
Remove stale ScriptProfiler methods
https://bugs.webkit.org/show_bug.cgi?id=126373
Reviewed by Darin Adler.
No new tests, No change behavior.
- bindings/js/ScriptProfiler.h: Remove dead code.
- 7:22 PM Changeset in webkit [161203] by
-
- 6 edits in trunk/Source
Remove ChromeClient::fullScreenRendererChanged().
<https://webkit.org/b/126370>
This hook was added in r75277 to notify WebFullScreenController when
the full screen renderer changed. In r110216 the code was refactored,
making this notification unnecessary.
Reviewed by Antti Koivisto.
- 6:07 PM Changeset in webkit [161202] by
-
- 2 edits in trunk/Source/WebCore
Fix the build by exposing some more scrolling state node headers
as Private in WebCore.framework.
- WebCore.xcodeproj/project.pbxproj:
- 5:30 PM Changeset in webkit [161201] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Unreviewed build fix after r160903 when ACCESSIBILITY is disabled
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::children):
- 4:52 PM Changeset in webkit [161200] by
-
- 4 edits in trunk/Source/WebCore
RenderScrollbar: Map of scrollbar parts should use RenderPtr.
<https://webkit.org/b/126367>
Turn RenderScrollbar::m_parts into HashMap of RenderPtrs. This makes
renderer destruction automatic and lets us remove some code.
Reviewed by Antti Koivisto.
- rendering/RenderPtr.h:
Add HashTraits for RenderPtr so we can use them as values in
WTF hash tables.
- rendering/RenderScrollbar.h:
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::~RenderScrollbar):
(WebCore::RenderScrollbar::setParent):
(WebCore::RenderScrollbar::updateScrollbarParts):
(WebCore::RenderScrollbar::updateScrollbarPart):
Remove now-unneeded kludges of logic to manually delete scrollbar
part renderers in various scenarios.
- 4:31 PM Changeset in webkit [161199] by
-
- 4 edits in trunk/Source/WebCore
Remove reattachRenderTree
https://bugs.webkit.org/show_bug.cgi?id=126366
Reviewed by Andreas Kling.
Remove the last remaining client.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseAttribute):
Reconstruct render tree asynchronously.
(WebCore::HTMLSelectElement::scrollToSelection):
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer):
(WebCore::HTMLSelectElement::selectOption):
It is not safe to cast the renderer based on usesMenuList test. Switch to RenderObject::isMenuList test.
(WebCore::HTMLSelectElement::parseMultipleAttribute):
Reconstruct render tree asynchronously.
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::defaultEventHandler):
- style/StyleResolveTree.cpp:
- style/StyleResolveTree.h:
Remove the function.
- 3:20 PM Changeset in webkit [161198] by
-
- 11 edits2 adds in trunk/Source
Create a ThreadedScrollingTree subclass of ScrollingTree, and push all knowledge of the scrolling thread into it
https://bugs.webkit.org/show_bug.cgi?id=126362
Reviewed by Sam Weinig.
Eventually we'll have a ScrollingTree in situations where there is no scrolling
thread, so make the ScrollingTree base class thread-agnostic (but threadsafe),
and subclass it in ThreadedScrollingTree for scrolling-thread-specific functionality.
The ScrollingTree base class also no longer needs to know about the
ScrollingCoordinator.
ScrollingCoordinatorMac creates a ThreadedScrollingTree.
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj: Add ThreadedScrollingTree.*
Make some headers Private that we'll need in WebKit2 soon.
- page/scrolling/ScrollingStateTree.h: Drive-by cleanup: clone() was unimplemented.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::~ScrollingTree):
(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously): Wrap up some logic that
involves taking the mutex, so ThreadedScrollingTree can conveniently call it.
(WebCore::ScrollingTree::handleWheelEvent):
(WebCore::ScrollingTree::commitNewTreeState):
(WebCore::ScrollingTree::setMainFrameScrollPosition):
(WebCore::ScrollingTree::isHandlingProgrammaticScroll):
- page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::isThreadedScrollingTree):
(WebCore::ScrollingTree::invalidate):
- page/scrolling/ThreadedScrollingTree.cpp: Added.
(WebCore::ThreadedScrollingTree::create):
(WebCore::ThreadedScrollingTree::ThreadedScrollingTree):
(WebCore::ThreadedScrollingTree::~ThreadedScrollingTree):
(WebCore::ThreadedScrollingTree::tryToHandleWheelEvent):
(WebCore::ThreadedScrollingTree::handleWheelEvent):
(WebCore::derefScrollingCoordinator):
(WebCore::ThreadedScrollingTree::invalidate):
(WebCore::ThreadedScrollingTree::commitNewTreeState):
(WebCore::ThreadedScrollingTree::updateMainFrameScrollPosition):
(WebCore::ThreadedScrollingTree::handleWheelEventPhase):
- page/scrolling/ThreadedScrollingTree.h: Added.
(WebCore::ThreadedScrollingTree::isThreadedScrollingTree):
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::ScrollingCoordinatorMac):
(WebCore::ScrollingCoordinatorMac::handleWheelEvent):
Source/WebKit2:
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::addScrollingTreeForPage):
(WebKit::EventDispatcher::wheelEvent):
- WebProcess/WebPage/EventDispatcher.h:
- 3:18 PM Changeset in webkit [161197] by
-
- 3 edits in trunk/Source/WebCore
FrameView: Store scroll corner renderer in a RenderPtr.
<https://webkit.org/b/126364>
Make FrameView::m_scrollCorner a RenderPtr<RenderScrollbarPart> and
remove two manual destroy() calls.
Reviewed by Antti Koivisto.
- 1:48 PM Changeset in webkit [161196] by
-
- 19 edits in trunk/Source/WebCore
Remove elementChildren/elementDescendants shorthands
https://bugs.webkit.org/show_bug.cgi?id=126363
Reviewed by Anders Carlsson.
Just use childrenOfType<Element>/descendantsOfType<Element> instead. They are not that much longer
and consistency is valuable.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canvasHasFallbackContent):
(WebCore::siblingWithAriaRole):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable):
- css/StyleInvalidationAnalysis.cpp:
(WebCore::StyleInvalidationAnalysis::invalidateStyle):
- dom/ChildNodeList.cpp:
(WebCore::ChildNodeList::namedItem):
- dom/Document.cpp:
(WebCore::Document::buildAccessKeyMap):
(WebCore::Document::childrenChanged):
- dom/Element.cpp:
(WebCore::Element::resetComputedStyle):
- dom/ElementChildIterator.h:
- dom/ElementDescendantIterator.h:
- dom/SelectorQuery.cpp:
(WebCore::elementsForLocalName):
(WebCore::anyElement):
(WebCore::SelectorDataList::executeSingleTagNameSelectorData):
(WebCore::SelectorDataList::executeSingleClassNameSelectorData):
(WebCore::SelectorDataList::executeSingleSelectorData):
(WebCore::SelectorDataList::executeSingleMultiSelectorData):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::removeHeadContents):
- editing/markup.cpp:
(WebCore::completeURLs):
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::refreshElementsIfNeeded):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::containsJavaApplet):
- loader/PlaceholderDocument.cpp:
(WebCore::PlaceholderDocument::createRenderTree):
- rendering/RenderChildIterator.h:
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::getElementById):
- svg/SVGUseElement.cpp:
(WebCore::subtreeContainsDisallowedElement):
(WebCore::removeDisallowedElementsFromSubtree):
- 1:20 PM Changeset in webkit [161195] by
-
- 11 edits in trunk
Do less synchronous render tree construction
https://bugs.webkit.org/show_bug.cgi?id=126359
Source/WebCore:
Reviewed by Anders Carlsson.
Remove some now-unnecessary attachRenderTree calls.
- html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::parseAttribute):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderFallbackContent):
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::didAddUserAgentShadowRoot):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::willRecalcStyle):
(WebCore::HTMLPlugInImageElement::createShadowIFrameSubtree):
(WebCore::HTMLPlugInImageElement::restartSnapshottedPlugIn):
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::createContainingTable):
(WebCore::HTMLViewSourceDocument::addSpanWithClassName):
(WebCore::HTMLViewSourceDocument::addLine):
(WebCore::HTMLViewSourceDocument::finishLine):
(WebCore::HTMLViewSourceDocument::addBase):
(WebCore::HTMLViewSourceDocument::addLink):
- xml/XMLErrors.cpp:
(WebCore::XMLErrors::insertErrorMessageBlock):
LayoutTests:
- fast/html/object-image-nested-fallback.html: Update test to work with asynchronous load failures.
- fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: Whitespace change.
- 11:53 AM Changeset in webkit [161194] by
-
- 13 edits in trunk/Source/WebCore
Updating the scrolling tree should use references to state nodes
https://bugs.webkit.org/show_bug.cgi?id=126360
Reviewed by Anders Carlsson.
Change functions related to ScrollingTreeNode updating to take
const references to state nodes rather than pointers.
- page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::hasChangedProperty):
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
(WebCore::ScrollingTree::updateTreeFromStateNode): The node can be nil so
this continues to take a pointer.
(WebCore::ScrollingTree::removeDestroyedNodes):
- page/scrolling/ScrollingTree.h:
- page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::updateAfterChildren):
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):
- page/scrolling/ScrollingTreeScrollingNode.h:
- page/scrolling/mac/ScrollingTreeFixedNode.h:
- page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::updateBeforeChildren):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::updateBeforeChildren):
(WebCore::ScrollingTreeScrollingNodeMac::updateAfterChildren):
- page/scrolling/mac/ScrollingTreeStickyNode.h:
- page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::updateBeforeChildren):
- 10:36 AM Changeset in webkit [161193] by
-
- 22 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Updating test baselines after the introduction of lazy render tree attaching,
enabling the saturated layout arithmetics for the GTK port, and other changes.
- platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
- platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt:
- platform/gtk/fast/block/float/016-expected.txt:
- platform/gtk/fast/css-generated-content/table-row-group-to-inline-expected.txt:
- platform/gtk/fast/dynamic/011-expected.txt:
- platform/gtk/fast/forms/formmove3-expected.txt:
- platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/gtk/fast/invalid/001-expected.txt:
- platform/gtk/fast/invalid/003-expected.txt:
- platform/gtk/fast/invalid/004-expected.txt:
- platform/gtk/fast/invalid/007-expected.txt:
- platform/gtk/fast/invalid/019-expected.txt:
- platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
- platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
- platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
- platform/gtk/fast/ruby/ruby-base-merge-block-children-crash-expected.txt:
- platform/gtk/fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction-expected.txt:
- platform/gtk/fast/table/empty-cells-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug113235-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug647-expected.txt:
- platform/gtk/tables/mozilla/other/wa_table_tr_align-expected.txt:
- 10:34 AM Changeset in webkit [161192] by
-
- 16 edits in trunk/Source
Add a typedef for PlatformLayerID on GraphicsLayer, and migrate RemoteLayerTreeTransaction to use it
https://bugs.webkit.org/show_bug.cgi?id=126346
Source/WebCore:
Reviewed by Tim Horton.
Remote scrolling tree code is soon going to use RemoteLayerTreeTransaction::LayerID,
so it makes more sense to put this layerID type on GraphicsLayer as
GraphicsLayer::PlatformLayerID.
Also add some type cast macros for PlatformCALayer and subclasses, and use them
where appropriate.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setName):
- platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::isPlatformCALayerMac):
(WebCore::PlatformCALayer::isPlatformCALayerRemote):
(WebCore::PlatformCALayer::PlatformCALayer):
- platform/graphics/ca/mac/PlatformCALayerMac.h:
Source/WebKit2:
Reviewed by Tim Horton.
Remote scrolling tree code is soon going to use RemoteLayerTreeTransaction::LayerID,
so it makes more sense to put this layerID type on GraphicsLayer as
GraphicsLayer::PlatformLayerID.
Also add some type cast macros for PlatformCALayer and subclasses, and use them
where appropriate.
- Shared/mac/RemoteLayerTreePropertyApplier.h:
- Shared/mac/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::rootLayerID):
(WebKit::RemoteLayerTreeTransaction::changedLayers):
(WebKit::RemoteLayerTreeTransaction::destroyedLayers):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::decode):
(WebKit::RemoteLayerTreeTransaction::setRootLayerID):
(WebKit::RemoteLayerTreeTransaction::setDestroyedLayerIDs):
(WebKit::RemoteLayerTreeTextStream::operator<<):
(WebKit::dumpChangedLayers):
(WebKit::RemoteLayerTreeTransaction::description):
- UIProcess/mac/RemoteLayerTreeHost.h:
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit):
(WebKit::RemoteLayerTreeHost::getLayer):
- WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp:
(WebKit::GraphicsLayerCARemote::primaryLayerID):
- WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(generateLayerID):
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
(WebKit::PlatformCALayerRemote::layerID):
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
- 10:26 AM Changeset in webkit [161191] by
-
- 13 edits in trunk/Source/WebCore
ScrollingStateNodes should have a reference to the ScrollingStateTree
https://bugs.webkit.org/show_bug.cgi?id=126348
Reviewed by Sam Weinig.
Make ScrollingStateNodes always belong to a ScrollingStateTree, and thus
have a reference to the tree rather than a pointer. When cloning nodes,
they are adopted by a new ScrollingStateTree, which adds them to its
node map (which didn't happen before).
In subclasses access the ScrollingStateTree through a member function.
- page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::create):
(WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode):
(WebCore::ScrollingStateFixedNode::clone):
(WebCore::ScrollingStateFixedNode::updateConstraints):
- page/scrolling/ScrollingStateFixedNode.h:
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::ScrollingStateNode):
(WebCore::ScrollingStateNode::cloneAndReset):
(WebCore::ScrollingStateNode::cloneAndResetChildren):
(WebCore::ScrollingStateNode::willBeRemovedFromStateTree):
- page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::scrollingStateTree):
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::create):
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::clone):
(WebCore::ScrollingStateScrollingNode::setViewportRect):
(WebCore::ScrollingStateScrollingNode::setTotalContentsSize):
(WebCore::ScrollingStateScrollingNode::setScrollOrigin):
(WebCore::ScrollingStateScrollingNode::setScrollableAreaParameters):
(WebCore::ScrollingStateScrollingNode::setFrameScaleFactor):
(WebCore::ScrollingStateScrollingNode::setNonFastScrollableRegion):
(WebCore::ScrollingStateScrollingNode::setWheelEventHandlerCount):
(WebCore::ScrollingStateScrollingNode::setSynchronousScrollingReasons):
(WebCore::ScrollingStateScrollingNode::setScrollBehaviorForFixedElements):
(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition):
(WebCore::ScrollingStateScrollingNode::setHeaderHeight):
(WebCore::ScrollingStateScrollingNode::setFooterHeight):
- page/scrolling/ScrollingStateScrollingNode.h:
- page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::create):
(WebCore::ScrollingStateStickyNode::ScrollingStateStickyNode):
(WebCore::ScrollingStateStickyNode::clone):
(WebCore::ScrollingStateStickyNode::updateConstraints):
- page/scrolling/ScrollingStateStickyNode.h:
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::commit):
(WebCore::ScrollingStateTree::addNode):
- page/scrolling/ScrollingStateTree.h:
- page/scrolling/mac/ScrollingStateNodeMac.mm:
(WebCore::ScrollingStateNode::setScrollLayer):
- page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
(WebCore::ScrollingStateScrollingNode::setCounterScrollingLayer):
(WebCore::ScrollingStateScrollingNode::setHeaderLayer):
(WebCore::ScrollingStateScrollingNode::setFooterLayer):
(WebCore::ScrollingStateScrollingNode::setScrollbarPaintersFromScrollbars):
- 10:14 AM Changeset in webkit [161190] by
-
- 11 edits in trunk/Source/WebCore
Give ScrollingStateNodes a nodeType()
https://bugs.webkit.org/show_bug.cgi?id=126347
Reviewed by Tim Horton.
When we start serializing ScrollingStateNodes to send to the UI process,
it's more convenient if they have a nodeType member rather than virtual functions,
so give them one, and fix the casting macros to use it. This allows us to use
a switch() on node creation, so the compiler will tell us if we forgot to create
a node type.
- page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode):
- page/scrolling/ScrollingStateFixedNode.h:
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::ScrollingStateNode):
- page/scrolling/ScrollingStateNode.h: const ScrollingNodeType field
(can't be modified after construction), and move the m_scrollingStateTree
member after it (the awkward protected:/private: will be cleaned up in a later patch).
(WebCore::ScrollingStateNode::nodeType):
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
- page/scrolling/ScrollingStateScrollingNode.h:
- page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::ScrollingStateStickyNode):
- page/scrolling/ScrollingStateStickyNode.h:
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateTreeFromStateNode):
- 7:41 AM Changeset in webkit [161189] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] [CMake] Fix the WEBKIT_SRC_DIR define when building the WebKit2 GObject API unit tests
https://bugs.webkit.org/show_bug.cgi?id=126350
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/tests/CMakeLists.txt: Fix the define.
- 7:35 AM Changeset in webkit [161188] by
-
- 6 edits in trunk
[GTK] Rename libtestnetscapeplugin to libTestNetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=126349
Reviewed by Carlos Garcia Campos.
All CMake ports use "libTestNetscapePlugin," so choosing the same
name in the autotools port will make the transition easier.
Source/WebKit2:
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextGetPlugins): Use the new plugin library name.
Tools:
- GNUmakefile.am: Rename the plugin library.
LayoutTests:
- platform/gtk/plugins/plugin-javascript-access-expected.txt: Change the plugin name.
- 5:35 AM Changeset in webkit [161187] by
-
- 2 edits in trunk/Tools
[GTK][WK2] Back items are shown in reverse order in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=126354
Reviewed by Carlos Garcia Campos.
The latest visited site for backward history should be placed on the top of a history stack
as a common behavior. However currently its order is reverse.
- MiniBrowser/gtk/BrowserWindow.c:
(browserWindowUpdateNavigationActions):
Dec 31, 2013:
- 5:08 PM Changeset in webkit [161186] by
-
- 2 edits in trunk/Source/WebKit2
[Gtk] WebKitWebInspector has build warnings due to uninitialized didChangeAttachedWidth member
https://bugs.webkit.org/show_bug.cgi?id=126353
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitWebInspector.cpp:
(webkitWebInspectorCreate): Initialize didChangeAttachedWidth to null.
- 3:46 PM Changeset in webkit [161185] by
-
- 115 edits1 copy1 add in trunk/Source/WebKit
[iOS] Upstream PLATFORM(IOS) changes to Source/WebKit/
https://bugs.webkit.org/show_bug.cgi?id=125746
Reviewed by David Kilzer.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Added WebDatabaseManagerInternal.h
and iOS.xcconfig.
Source/WebKit/ios:
- WebCoreSupport/WebVisiblePosition.mm:
(-[WebVisiblePosition positionAtStartOrEndOfWord]): Changed a comment
to mention iOS rather than iPhone.
Source/WebKit/mac:
This is a straight upstreaming of the various PLATFORM(IOS) changes
made to Source/WebKit/ with the following modifications:
- Includes of <Cocoa/Cocoa.h> were generally replaced with an include
of <Foundation/Foundation.h> followed by an include of
<AppKit/AppKit.h> on non-iOS platforms. This assumes that nobody was
relying on <Cocoa/Cocoa.h>'s inclusion of <CoreData/CoreData.h>.
- Includes of <Cocoa/Cocoa.h> and <Foundation/Foundation.h> were
removed from files that include WebKitPrefix.h.
- Instances of 'iPhone (OS)' in comments were replaced with 'iOS', and
other sensitive terms were elided.
- Various PLATFORM(IOS) blocks were simplified. For instance:
#if !PLATFORM(IOS)
...
#endif
#if PLATFORM(IOS)
...
#endif
Was simplified to:
#if !PLATFORM(IOS)
...
#else
...
#endif
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebKit.xcconfig:
- Configurations/iOS.xcconfig: Added.
- DOM/WebDOMOperations.mm:
- DefaultDelegates/WebDefaultContextMenuDelegate.mm:
- DefaultDelegates/WebDefaultEditingDelegate.m:
- DefaultDelegates/WebDefaultPolicyDelegate.m:
- DefaultDelegates/WebDefaultUIDelegate.h:
- DefaultDelegates/WebDefaultUIDelegate.m:
- History/WebBackForwardList.mm:
- History/WebHistory.mm:
- History/WebHistoryItem.mm:
- History/WebURLsWithTitles.m:
- Misc/WebCache.mm:
- Misc/WebDownload.mm:
- Misc/WebElementDictionary.mm:
- Misc/WebIconDatabase.mm:
- Misc/WebIconDatabaseInternal.h:
- Misc/WebKitNSStringExtras.mm:
- Misc/WebKitSystemBits.m:
- Misc/WebKitVersionChecks.h:
- Misc/WebKitVersionChecks.m:
- Misc/WebLocalizableStrings.mm:
- Misc/WebNSArrayExtras.h:
- Misc/WebNSArrayExtras.m:
- Misc/WebNSControlExtras.h:
- Misc/WebNSControlExtras.m:
- Misc/WebNSDictionaryExtras.h:
- Misc/WebNSDictionaryExtras.m:
- Misc/WebNSEventExtras.m:
- Misc/WebNSFileManagerExtras.mm:
- Misc/WebNSImageExtras.h:
- Misc/WebNSImageExtras.m:
- Misc/WebNSPasteboardExtras.mm:
- Misc/WebNSPrintOperationExtras.h:
- Misc/WebNSPrintOperationExtras.m:
- Misc/WebNSURLExtras.mm:
- Misc/WebNSViewExtras.m:
- Misc/WebNSWindowExtras.m:
- Panels/WebAuthenticationPanel.h:
- Panels/WebAuthenticationPanel.m:
- Panels/WebPanelAuthenticationHandler.m:
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
- Plugins/WebBasePluginPackage.h:
- Plugins/WebBasePluginPackage.mm:
- Plugins/WebJavaPlugIn.h:
- Plugins/WebPluginContainerCheck.mm:
- Plugins/WebPluginController.h:
- Plugins/WebPluginController.mm:
- Plugins/WebPluginDatabase.mm:
- Plugins/WebPluginPackage.mm:
- Plugins/WebPluginsPrivate.m:
- Storage/WebDatabaseManager.mm:
- Storage/WebDatabaseManagerClient.h:
- Storage/WebDatabaseManagerClient.mm:
- Storage/WebDatabaseManagerInternal.h: Added.
- Storage/WebStorageManager.mm:
- WebCoreSupport/CorrectionPanel.h:
- WebCoreSupport/WebAlternativeTextClient.h:
- WebCoreSupport/WebApplicationCache.mm:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
- WebCoreSupport/WebContextMenuClient.mm:
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebCoreSupport/WebFrameNetworkingContext.h:
- WebCoreSupport/WebFrameNetworkingContext.mm:
- WebCoreSupport/WebGeolocationClient.h:
- WebCoreSupport/WebGeolocationClient.mm:
- WebCoreSupport/WebJavaScriptTextInputPanel.m:
- WebCoreSupport/WebKeyGenerator.mm:
- WebCoreSupport/WebNotificationClient.mm:
- WebCoreSupport/WebOpenPanelResultListener.mm:
- WebCoreSupport/WebSecurityOrigin.mm:
- WebCoreSupport/WebSystemInterface.mm:
- WebKitPrefix.h:
- WebView/WebArchive.mm:
- WebView/WebClipView.h:
- WebView/WebDataSource.mm:
- WebView/WebDelegateImplementationCaching.h:
- WebView/WebDelegateImplementationCaching.mm:
- WebView/WebDeviceOrientation.mm:
- WebView/WebDocumentInternal.h:
- WebView/WebDocumentLoaderMac.mm:
- WebView/WebDynamicScrollBarsViewInternal.h:
- WebView/WebFormDelegate.m:
- WebView/WebFrame.mm:
- WebView/WebFrameInternal.h:
- WebView/WebFrameView.mm:
- WebView/WebFullScreenController.h:
- WebView/WebFullScreenController.mm:
- WebView/WebHTMLRepresentation.mm:
- WebView/WebHTMLView.mm:
- WebView/WebHTMLViewInternal.h:
- WebView/WebPDFDocumentExtras.h:
- WebView/WebPDFDocumentExtras.mm:
- WebView/WebPDFRepresentation.h:
- WebView/WebPDFRepresentation.mm:
- WebView/WebPDFView.h:
- WebView/WebPDFView.mm:
- WebView/WebPreferences.mm:
- WebView/WebResource.mm:
- WebView/WebTextCompletionController.h:
- WebView/WebTextIterator.mm:
- WebView/WebView.mm:
- WebView/WebViewData.h:
- WebView/WebViewData.mm:
- WebView/WebViewInternal.h:
- 8:40 AM Changeset in webkit [161184] by
-
- 37 edits in trunk/Source/WebCore
Out-of-line RenderStyle substructure copying helpers.
<https://webkit.org/b/126340>
This shrinks the .access() calls by moving memory allocation logic
out-of-line, though I'm really doing this to make Instruments.app
allocations output more readable.
Writes to e.g 'font' or 'color' will now be grouped under a single
StyleInheritedData::copy() call instead of being spread out over
setFontDescription(), setLineHeight(), setColor(), etc.
Reviewed by Anders Carlsson.
- 8:16 AM Changeset in webkit [161183] by
-
- 3 edits in trunk/Source/WebCore
RenderListItem should store its marker in a RenderPtr.
<https://webkit.org/b/126298>
Make RenderListItem::m_marker a RenderPtr<RenderListMarker> and
remove two manual destroy() calls. Tweaked code to reduce nesting.
Reviewed by Anders Carlsson.
- 8:14 AM Changeset in webkit [161182] by
-
- 8 edits in trunk
[GTK] Make the output directory of GObject unit tests binaries consistent with the CMake build
https://bugs.webkit.org/show_bug.cgi?id=126297
Reviewed by Philippe Normand.
Source/WebKit/gtk:
- tests/GNUmakefile.am: Build the tests in the new directory.
Source/WebKit2:
- UIProcess/API/gtk/tests/GNUmakefile.am: Build the tests in the new directory.
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(startTestServer): Update the search path to reflect the new directory.
- UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp:
(startTestServer): Update the search path to reflect the new directory.
Tools:
- Scripts/run-gtk-tests: Looks for the tests in the new directories.
(TestRunner): Ditto.
(TestRunner._run_test): Ditto.
- 6:05 AM Changeset in webkit [161181] by
-
- 132 edits in trunk/Source/WebCore
Element's renderer factory should return RenderPtrs.
<https://webkit.org/b/126318>
Rename Element::createRenderer() to createElementRenderer() and have
it return RenderPtr<RenderElement>. Propagate signature until it
builds again.
We leakPtr() the renderer at two call sites when handing things over
to raw pointer API. This'll get tidied up in subsequent patches.
Reviewed by Sam Weinig.
- 2:26 AM Changeset in webkit [161180] by
-
- 8 edits in branches/jsCStack/Source/JavaScriptCore
CStack: Need a separate stack limit for the JS stack and the C stack.
https://bugs.webkit.org/show_bug.cgi?id=126320.
Not yet reviewed.
With this patch, we now accurately track how much JS stack space the
VM has used, and cap that at the value specified by Options::maxStackSize().
The JS stack space is measured in chunks, one for each VMEntryScope. Each
VMEntryScope will also keep a running total of the sum of all the stack
usage of previous VMEntryScopes to simplify the calculation of the total
usage.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
- In Interpreter::execute() for programs, we were installing the VMEntryScope even if we end up only processing a JSON object. This poses a problem because the code that processes the JSON object will call functions that will re-enter the VM thereby installing another VMEntryScope. Each VMEntryScope expects VM.topCallFrame and VM.stackPointerAtVMEntry to be set up properly for the previous VMEntryScope. However, in this case, we've installed the VMEntryScope for a potential ProgramExecutable but never executed a program to initialize its values for VM.topCallFrame and VM.stackPointerAtVMEntry. This in turn causes a crash when the second VMEntryScope makes use of VM.topCallFrame.
The fix is simply to defer installation of the VMEntryScope for the
program till we are actually sure that we will attempt to execute a
program.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL(stack_check)):
- In llint_stack_check(), we pop the frame that we failed to set up before throwing the StackOverflowError. Added an update of topCallFrame here to reflect this popping action.
- llint/LowLevelInterpreter64.asm:
- The VMEntryScope will have to calculate and set up a jsStackLimit value before we actually know what the stack pointer is at the point when we re-enter the VM. So, instead of using the real stackPointerAtVMEntry for the jsStackLimit calculation, we use an estimate.
doCallToJavaScript() here will set VM.stackPointerAtVMEntry to its
real value. But before it does that, it needs to adjust VM.jsStackLimit
by the delta between the estimate and the real stackPointerAtVMEntry.
- If doCallToJavaScript() fails its stack check for incoming args, it also needs to clear VM.stackPointerAtVMEntry so that C code can assert that the various pointers into the stack remain consistent.
By consistent, I mean that, given that the stack grows down, and that
VM.stackPointerAtVMEntry and VM.topCallFrame are properly initialized,
then the following should always be true:
let topOfStack = VM.topCallFrame->topOfFrame();
stackPointerAtVMEntry >= topOfStack >= stack pointer in a C helper function
and
JSStack.containsAddress(stackPointerAtVMEntry)
and
JSStack.containsAddress(topOfStack)
Clearing VM.stackPointerAtVMEntry, if the stack check in doCallToJavaScript()
fails, indicates we failed to enter the current VMEntryScope and that we
should be using the previous VMEntryScope's stackPointerAtVMEntry and
topCallFrame for the above assertions.
NOTE: These assertions are done in VMEntryScope::updateStackLimits().
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):
(JSC::VMEntryScope::stackUsageFor):
(JSC::VMEntryScope::updateStackLimits):
(JSC::VMEntryScope::currentStackPointer):
(JSC::VMEntryScope::requiredCapacity):
- requiredCapacity() now computes the excess amount C stack capacity that we have available, and discount it in the computation of the JS stack limit. By excess, I mean the amount of unused C stack space that exceeds the amount of unused JS stack space capacity.
- runtime/VMEntryScope.h:
- 12:34 AM Changeset in webkit [161179] by
-
- 2 edits in trunk/Source/WebCore
[SOUP] Return early in ResourceHandle::receivedCancellation if the load has already cancelled
https://bugs.webkit.org/show_bug.cgi?id=126287
Reviewed by Martin Robinson.
This situation can happen when using the network process, because
the ReceivedCancellation message can be received when the resource
loader has already been removed, but the authentication challenge
still has a reference to the ResourceHandleClient.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::receivedCancellation):
- 12:32 AM Changeset in webkit [161178] by
-
- 2 edits in trunk/Source/WebCore
[SOUP] The initiating page is lost after a redirection
https://bugs.webkit.org/show_bug.cgi?id=126293
Reviewed by Martin Robinson.
The initiating page id is attached to the initial soup request
object, but not to the one created after a redirection.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::createSoupRequestAndMessageForHandle): Call
setSoupRequestInitiatingPageIDFromNetworkingContext() here if the
soup request is created successfully.
(WebCore::ResourceHandle::start): Remove the call to
setSoupRequestInitiatingPageIDFromNetworkingContext().
- 12:30 AM Changeset in webkit [161177] by
-
- 2 edits in trunk/Source/WebCore
[SOUP] Implement ResourceHandle::continueWillSendRequest()
https://bugs.webkit.org/show_bug.cgi?id=126291
Reviewed by Martin Robinson.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::continueAfterWillSendRequest): Helper function that
continues with the load after willSendRequest has been called.
(WebCore::doRedirect): Call continueAfterWillSendRequest() when
client doesn't use async callbacks.
(WebCore::ResourceHandle::continueWillSendRequest): Call
continueAfterWillSendRequest().
- 12:28 AM Changeset in webkit [161176] by
-
- 4 edits in trunk/Source
[SOUP] willSendRequest doesn't work after a redirect
https://bugs.webkit.org/show_bug.cgi?id=126290
Reviewed by Martin Robinson.
Source/WebCore:
The problem is that we are creating the new soup request for the
redirect before calling ResourceHandleClient::willSendRequest() so
that any change made to the request by the client is ignored.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::doRedirect): Create the new soup request and soup
message for the redirect after calling willSendRequest() on the
client.
Source/WebKit2:
Add test cases to test send-request signal in case of
redirection.
- UIProcess/API/gtk/tests/TestResources.cpp:
(testWebResourceSendRequest):
(serverCallback):
