Timeline
Mar 14, 2008:
- 11:06 PM Changeset in webkit [31073] by
-
- 6 edits in trunk
PGO build fixes.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
WebCore:
PGO build fixes.
- WebCore.vcproj/WebCore.vcproj:
WebKit/win:
PGO build fixes.
- WebKit.vcproj/WebKit.vcproj:
- 6:05 PM Changeset in webkit [31072] by
-
- 8 edits in trunk/JavaScriptCore
Add logic to track whether a function uses a locally scoped eval or requires a closure
Reviewed by Maciej
Now that we limit eval we can track those uses of eval that operate
in the local scope and functions that require a closure. We track
this information during initial parsing to avoid yet another tree
walk.
- 5:21 PM Changeset in webkit [31071] by
-
- 5 edits2 adds in trunk
WebCore:
Reviewed by Sam.
<rdar://problem/5794989>
https://bugs.webkit.org/show_bug.cgi?id=17792
REGRESSION (Safari 3.0.4-3.1): Ordering tickets from Sweden's biggest train operator doesn't work
Pass the frame loader that should be used for looking up the frame name to FrameLoader::createWindow
so that somewindow.open calls where the active window and 'somewindow' differ return the correct frame.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow):
- loader/FrameLoader.h:
LayoutTests:
Reviewed by Sam.
<rdar://problem/5794989>
https://bugs.webkit.org/show_bug.cgi?id=17792
REGRESSION (Safari 3.0.4-3.1): Ordering tickets from Sweden's biggest train operator doesn't work
Add tests.
- fast/dom/Window/window-open-self-from-other-frame-expected.txt: Added.
- fast/dom/Window/window-open-self-from-other-frame.html: Added.
- 3:57 PM Changeset in webkit [31070] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog
- 3:54 PM Changeset in webkit [31069] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
- fix <rdar://problem/5797836> shadow offsets are smaller than specified
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setShadow): Made the workaround for <rdar://problem/5643663> unconditional.
- 2:06 PM Changeset in webkit [31068] by
-
- 3 edits in trunk/WebCore
Fix it right this time
- platform/MainThread.cpp: Cast to unsigned so we can use %u in the format string.
- platform/mac/MainThreadMac.mm:
- 1:57 PM Changeset in webkit [31067] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Brian Dash's rubberstamp
Remove a class declaration for a class that has never existed
- WebView/WebResource.h:
- 1:47 PM Changeset in webkit [31066] by
-
- 2 edits in trunk/WebCore
Mac build fix
- platform/mac/MainThreadMac.mm: Corrected a typo.
- 1:34 PM Changeset in webkit [31065] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=17834 REGRESSION: floated first-letter does not work when included in table
Test: fast/css/first-letter-float.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): Changed the search for the first text node to stop at a float if that float is an existing first- letter.
LayoutTests:
Reviewed by Darin Adler.
- test for http://bugs.webkit.org/show_bug.cgi?id=17834 REGRESSION: floated first-letter does not work when included in table
- fast/css/first-letter-float.html: Added.
- platform/mac-leopard/fast/css/first-letter-float-expected.checksum: Added.
- platform/mac-leopard/fast/css/first-letter-float-expected.png: Added.
- platform/mac/fast/css/first-letter-float-expected.txt: Added.
- 1:15 PM Changeset in webkit [31064] by
-
- 2 edits in trunk/WebCore
Fix Mac build
- WebCore.xcodeproj/project.pbxproj:
- 12:53 PM Changeset in webkit [31063] by
-
- 12 edits1 copy in trunk/WebCore
Make most of callOnMainThread's implementation be cross-platform
I took the non-platform-specific parts of MainThreadWin.cpp and moved
them to a new MainThread.cpp. Each platform is now responsible for
implementing one function, scheduleDispatchFunctionsOnMainThread,
which is supposed to set things up so that
dispatchFunctionsFromMainThread gets called from the main thread in
the near future.
Reviewed by Alexey.
- GNUmakefile.am: Added MainThread.cpp to the project.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- WebCoreSources.bkl: Ditto.
- platform/MainThread.cpp:
- Copied from WebCore/platform/win/MainThreadWin.cpp.
- Removed the Windows-specific parts.
(WebCore::callOnMainThread): Changed to call
scheduleDispatchFunctionsOnMainThread instead of PostMessage.
- platform/gtk/MainThreadGtk.cpp: (WebCore::timeoutFired): Renamed from callFunctionOnMainThread. Now just calls dispatchFunctionsFromMainThread. (WebCore::scheduleDispatchFunctionsOnMainThread): Added. Calls through to g_timeout_add.
- platform/mac/MainThreadMac.mm: Renamed WebCoreFunctionWrapper to WebCoreMainThreadCaller. (-[WebCoreMainThreadCaller call]): Calls through to dispatchFunctionsFromMainThread. (WebCore::scheduleDispatchFunctionsOnMainThread): Makes a new WebCoreMainThreadCaller and calls performSelectorOnMainThread on it.
- platform/qt/MainThreadQt.cpp: Removed PerformFunctionEvent. (WebCore::MainThreadInvoker::event): Chagned to call through to dispatchFunctionsFromMainThread. (WebCore::scheduleDispatchFunctionsOnMainThread): Sends an empty event to the MainThreadInvoker.
- platform/win/MainThreadWin.cpp:
- Removed the non-Windows-specific parts.
- Removed some unnecessary initialization of static variables to 0.
(WebCore::ThreadingWindowWndProc): Changed to call
dispatchFunctionsFromMainThread.
(WebCore::scheduleDispatchFunctionsOnMainThread): Calls through to
PostMessage.
- platform/wx/MainThreadWx.cpp: (WebCore::scheduleDispatchFunctionsOnMainThread): Added.
- 12:28 PM Changeset in webkit [31062] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Beth Dakin.
Fixed another problem with Vector::shrinkCapacity.
moveOverlapping isn't good enough for the case where the buffer hasn't
changed, because it still destroys the contents of the buffer.
- wtf/Vector.h: (WTF::::shrinkCapacity): Changed to explicitly check whether the call to allocateBuffer produced a new buffer. If it didn't, there's no need to move.
- 12:05 PM Changeset in webkit [31061] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Beth Dakin.
Fixed a few problems with Vector::shrinkCapacity that I noticed in testing.
- wtf/Vector.h: (WTF::VectorBufferBase::deallocateBuffer): Clear our m_buffer pointer when we deallocate m_buffer, in case we're not asked to reallocate a new buffer. (Otherwise, we would use a stale m_buffer if we were asked to perform any operations after shrinkCapacity was called.)
(WTF::VectorBuffer::allocateBuffer): Made VectorBuffer with inline
capacity aware that calls to allocateBuffer might be shrinks, rather
than grows, so we shouldn't allocate a new buffer on the heap unless
our inline buffer is too small.
(WTF::::shrinkCapacity): Call resize() instead of just setting m_size,
so destructors run. Call resize before reallocating the buffer to make
sure that we still have access to the objects we need to destroy. Call
moveOverlapping instead of move, since a call to allocateBuffer on an
inline buffer may produce identical storage.
- 11:28 AM Changeset in webkit [31060] by
-
- 5 edits in trunk/WebCore
Reviewed by Geoff.
Fix for <rdar://problem/5728171> Potential PLT speedup: don't
realloc every time inside NamedAttrMap::addAttribute
The speed-up for this turned out to be so small that it is mostly
imperceptible. It is likely that it is a tiny boost, though, and
the new code is much cleaner.
- dom/Element.cpp: (WebCore::Element::setAttributeMap): attrs is now called m_attributes
- dom/NamedAttrMap.cpp: The array attrs is now the Vector of RefPtrs called m_attributes, and there is no longer any need for the len member variable. (WebCore::NamedAttrMap::NamedAttrMap): (WebCore::NamedAttrMap::item): (WebCore::NamedAttrMap::getAttributeItem): (WebCore::NamedAttrMap::clearAttributes): (WebCore::NamedAttrMap::operator=): (WebCore::NamedAttrMap::addAttribute): (WebCore::NamedAttrMap::removeAttribute): (WebCore::NamedAttrMap::mapsEquivalent):
- dom/NamedAttrMap.h: Same. (WebCore::NamedAttrMap::length): (WebCore::NamedAttrMap::attributeItem): (WebCore::NamedAttrMap::shrinkToLength): (WebCore::NamedAttrMap::reserveCapacity):
- html/HTMLTokenizer.cpp: One of the benefits of the old array was that it never took up more memory than it needed to. So the tokenizer utilizes new member functions on NamedAttrMap (shrinkToLength and reserveCapacity) to try to keep memory usage at a minimum. (WebCore::Token::addAttribute): (WebCore::HTMLTokenizer::processToken):
- 8:21 AM Changeset in webkit [31059] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix typos.
- 8:19 AM Changeset in webkit [31058] by
-
- 2 edits in trunk/WebCore
BUILD FIX when ENABLE(MAC_JAVA_BINDINGS) set to 0.
- page/mac/FrameMac.mm: Move up #if ENABLE(MAC_JAVA_BINDINGS) guard to comment out unused code.
- 7:59 AM Changeset in webkit [31057] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Darin.
Get rid of a localime() call on platforms that have better alternatives.
- kjs/DateMath.h: Added getLocalTime();
- kjs/DateMath.cpp: (KJS::getLocalTime): (KJS::getDSTOffsetSimple): Implementation moved from getDSTOffsetSimple().
- kjs/date_object.cpp: (KJS::DateObjectImp::callAsFunction): Switched to getLocalTime().
- 7:34 AM Changeset in webkit [31056] by
-
- 26 edits1 add1 delete in trunk
Unify concept of enabling the Mac Java bridge.
Reviewed by Darin and Anders.
- wtf/Platform.h: Define ENABLE_MAC_JAVA_BRIDGE here.
WebCore:
Unify concept of enabling the Mac Java bridge.
Reviewed by Darin and Anders.
No test cases added since there is no change in functionality.
- DerivedSources.make: Added check for ENABLE_MAC_JAVA_BRIDGE macro. If defined as "1", add WebCore.JNI.exp to WEBCORE_EXPORT_DEPENDENCIES.
- WebCore.JNI.exp: Added.
- WebCore.base.exp: Moved exported JNI methods to WebCore.JNI.exp.
- bridge/jni/jni_class.cpp: Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
- bridge/jni/jni_class.h: Ditto.
- bridge/jni/jni_instance.cpp: Ditto.
- bridge/jni/jni_instance.h: Ditto.
- bridge/jni/jni_jsobject.cpp: Ditto.
- bridge/jni/jni_jsobject.h: Ditto.
- bridge/jni/jni_objc.mm: Ditto.
- bridge/jni/jni_runtime.cpp: Ditto.
- bridge/jni/jni_runtime.h: Ditto.
- bridge/jni/jni_utility.cpp: Ditto.
- bridge/jni/jni_utility.h: Ditto.
- bridge/runtime.cpp: Removed unused #include statements.
- bridge/runtime.h: (KJS::Bindings::Instance::BindingLanguage): Added #if ENABLE(MAC_JAVA_BRIDGE) guard for JavaLanguage enum. Also added #if PLATFORM(MAC) guard for ObjectiveCLanguage enum to match corresponding code in runtime.cpp.
- config.h: Removed definition of HAVE_JNI.
- loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
- page/Frame.cpp: (WebCore::Frame::Frame): Ditto.
- page/Frame.h: (WebCore::Frame::initJavaJSBindings): Ditto.
- page/mac/FrameMac.mm: (WebCore::Frame::createScriptInstanceForWidget): Ditto. (WebCore::Frame::initJavaJSBindings): Ditto.
WebKit/mac:
Unify concept of enabling the Mac Java bridge.
Reviewed by Darin and Anders.
- Plugins/WebPluginJava.h: Removed unused file.
- WebCoreSupport/WebFrameLoaderClient.h: (WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
- WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method. (WebFrameLoaderClient::javaApplet): Ditto.
- 1:09 AM Changeset in webkit [31055] by
-
- 2 edits in trunk/WebKit/qt
Fix the Qt build.
- 12:13 AM Changeset in webkit [31054] by
-
- 3 edits in trunk/WebCore
- html/PreloadScanner.h: Corrected license.
- html/PreloadScanner.cpp: Corrected license.
Mar 13, 2008:
- 11:22 PM Developer Tools Hitlist edited by
- (diff)
- 9:40 PM Changeset in webkit [31053] by
-
- 2 edits in trunk/WebKitTools
2008-03-13 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Darin.
Correct paths to vsprops files so they use the environment
variable, rather than hard-coded path.
http://bugs.webkit.org/show_bug.cgi?id=17797.
- WinLauncher/WinLauncher.vcproj: Correct paths to vsprops.
- 9:19 PM Changeset in webkit [31052] by
-
- 2 edits in trunk/WebCore
Reviewed by darin. Landed by eseidel.
- platform/FloatConversion.h: Include a header to get CoreGraphics types when using CoreGraphics types.
- 9:19 PM Changeset in webkit [31051] by
-
- 4 edits in trunk/WebCore
Reviewed by eseidel. Landed by eseidel.
- WebCore.xcodeproj/project.pbxproj:
- css/CSSParser.cpp:
- css/makeprop.pl: Move CSSPropertyNames.c to CSSPropertyNames.cpp
- 8:47 PM Changeset in webkit [31050] by
-
- 2 edits in trunk/WebCore
Reviewed by eseidel. Landed by eseidel.
- platform/Arena.h: Use statement1;statement2 instead of (statement1,statement2) in CLEAR_UNUSED.
- 8:44 PM Changeset in webkit [31049] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by eseidel. Landed by eseidel.
- wtf/FastMalloc.cpp: #include <wtf/HashSet.h> outside of any namespaces.
- 8:43 PM Changeset in webkit [31048] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by eseidel. Landed by eseidel
- pcre/pcre_exec.cpp: Fix misnamed variable, allowing -DDEBUG build to succeed.
- wtf/ThreadingPthreads.cpp: #include <sys/time.h> for gettimeofday in non-pch build.
- 8:07 PM Changeset in webkit [31047] by
-
- 4 edits in trunk/LayoutTests
Reviewed by Mitz.
Update test results for the preload patch. Load order for some resources changed,
this does not affect the substance of these tests.
- platform/mac-leopard/security/block-test-expected.txt:
- security/block-test-expected.txt:
- webarchive/loading/cache-expired-subresource-expected.txt:
- 7:47 PM Changeset in webkit [31046] by
-
- 2 edits in trunk/WebCore
2008-03-13 Tommi Komulainen <tommi.komulainen@iki.fi>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=17821
[SOUP] POST requests are empty
Send the HTTP request body as well.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start):
- 4:16 PM Changeset in webkit [31045] by
-
- 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj
Fix the build.
- 3:14 PM Changeset in webkit [31044] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=17819 Border-collapse: collapse later cell wins on PC, earlier cell on Mac
Test: fast/table/border-collapsing/equal-precedence-resolution.html
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): When calling compareBorders() with borders that may have the same precedence, made sure to pass the border belonging to the earlier (in document order) element first, since compareBorders() prefers the first argument when there is a tie. (WebCore::RenderTableCell::collapsedRightBorder): Ditto. (WebCore::RenderTableCell::collapsedTopBorder): Ditto.
LayoutTests:
Reviewed by Dave Hyatt.
- test for http://bugs.webkit.org/show_bug.cgi?id=17819 Border-collapse: collapse later cell wins on PC, earlier cell on Mac
- fast/table/border-collapsing/equal-precedence-resolution.html: Added.
- platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.checksum: Added.
- platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.png: Added.
- platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.txt: Added.
- 3:07 PM Changeset in webkit [31043] by
-
- 2 edits in trunk/WebKit/win
Another Windows build fix after r31034
- WebKitDLL.cpp: (loadResourceIntoBuffer): Use SharedBuffer::create.
- 2:40 PM Changeset in webkit [31042] by
-
- 5 edits in trunk
Build fixes after r31034
WebCore:
wx build fix and Windows leak fix after r31034
- platform/graphics/wx/ImageWx.cpp: (WebCore::Image::loadPlatformResource): Use SharedBuffer::create.
- platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile): Ditto (we were leaking the SharedBuffer here before).
WebKit/win:
Windows build fix after r31034
- WebFrame.cpp: (WebFrame::loadData): Use SharedBuffer::create. (WebFrame::loadHTMLString): Ditto.
- 2:31 PM Changeset in webkit [31041] by
-
- 3 edits in trunk/WebCore
Reviewed by Eric.
Correct a few issues spotted by Mike Belshe.
- html/PreloadScanner.cpp: (WebCore::PreloadScanner::tokenize):
- loader/loader.cpp: (WebCore::Loader::cancelRequests):
- 2:26 PM Changeset in webkit [31040] by
-
- 4 edits in trunk
Fix GTK+ build for SharedBuffer changes.
WebCore:
2008-03-13 Rodney Dawes <dobey@wayofthemonkey.com>
Fix GTK+ build for SharedBuffer changes.
- platform/graphics/gtk/ImageGtk.cpp: (Image::loadPlatformResource):
WebKit/gtk:
2008-03-13 Rodney Dawes <dobey@wayofthemonkey.com>
Fix GTK+ build for SharedBuffer changes.
- webkit/webkitwebview.cpp: (webkit_web_view_load_string):
- 2:24 PM Changeset in webkit [31039] by
-
- 5 edits1 delete in trunk
WebCore:
More PGO build fixes.
- WebCorePrefix.cpp:
WebKit/win:
More PGO build fixes.
- WebKit.vcproj/WebKit.pgd: Removed.
- WebKit.vcproj/WebKit.vcproj:
- WebKitPrefix.cpp:
- 2:20 PM Changeset in webkit [31038] by
-
- 16 edits3 adds in trunk
WebCore:
Reviewed by Darin.
Make page loads go fast.
- Implement speculative preloading. When a script load blocks the main parser, use a side parser to pick up more resources.
- Implement per-host load queues, prioritize scripts and stylesheets over images.
Depending on content and network latency this may speed things up quite a bit.
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp: (WebCore::Document::implicitClose): Clear the preloads after laoding completes.
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute): (WebCore::HTMLLinkElement::tokenizeRelAttribute):
- html/HTMLLinkElement.h: Make tokenizeRelAttribute() public static so it can be used from elsewhere. Eliminate a pointless bitfield so I can get references.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::write):
- html/HTMLTokenizer.h: Spin up the preload scanner whenever a script load blocks the parser. One scanner tracks the end of the document while temporary ones are created as needed to scan document.write() output.
- html/PreloadScanner.cpp: Added. (WebCore::PreloadScanner::PreloadScanner): (WebCore::PreloadScanner::~PreloadScanner): (WebCore::PreloadScanner::begin): (WebCore::PreloadScanner::end): (WebCore::PreloadScanner::reset): (WebCore::PreloadScanner::write): (WebCore::isWhitespace): (WebCore::PreloadScanner::clearLastCharacters): (WebCore::PreloadScanner::rememberCharacter): (WebCore::PreloadScanner::lastCharactersMatch): (WebCore::legalEntityFor): (WebCore::PreloadScanner::consumeEntity): (WebCore::PreloadScanner::tokenize): (WebCore::PreloadScanner::processAttribute): (WebCore::PreloadScanner::emitCharacter): (WebCore::PreloadScanner::tokenizeCSS): (WebCore::PreloadScanner::emitTag): (WebCore::PreloadScanner::emitCSSRule):
- html/PreloadScanner.h: Added. (WebCore::PreloadScanner::inProgress): (WebCore::PreloadScanner::): HTML5 tokenization plus some glue code. Fake CSS parsing thrown in just for fun.
- loader/Cache.cpp: (WebCore::Cache::pruneDeadResources): Preloads have zero refcount, avoid kicking them out too early.
- loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::ref):
- loader/CachedResource.h: (WebCore::CachedResource::): (WebCore::CachedResource::preloadResult): (WebCore::CachedResource::setRequestedFromNetworkingLayer): (WebCore::CachedResource::canDelete): (WebCore::CachedResource::isPreloaded): (WebCore::CachedResource::increasePreloadCount): (WebCore::CachedResource::decreasePreloadCount): Keep track which resources are preloads. Avoid deleting them. Track at which point of the loading preloads get utilized to enable some interesting statistics.
- loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader): (WebCore::DocLoader::checkForReload): (WebCore::DocLoader::registerPreload): (WebCore::DocLoader::clearPreloads): (WebCore::DocLoader::printPreloadStats):
- loader/DocLoader.h: Ensure we utilize preloaded resources during reloads. Keep a list of all preloads in the document. Clear the preloads after parsing is complete. Some debug statistics.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense): Avoid signaling that loading is complete too early.
- loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::Loader::~Loader): (WebCore::Loader::determinePriority): (WebCore::Loader::load): (WebCore::Loader::scheduleServePendingRequests): (WebCore::Loader::requestTimerFired): (WebCore::Loader::servePendingRequests): (WebCore::Loader::cancelRequests): (WebCore::Loader::Host::Host): (WebCore::Loader::Host::~Host): (WebCore::Loader::Host::addRequest): (WebCore::Loader::Host::hasRequests): (WebCore::Loader::Host::servePendingRequests): (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail): (WebCore::Loader::Host::didReceiveResponse): (WebCore::Loader::Host::didReceiveData): (WebCore::Loader::Host::cancelPendingRequests): (WebCore::Loader::Host::cancelRequests):
- loader/loader.h: (WebCore::Loader::): Distribute load requests to per-host priority queues. Limit the number of loads issued to the networking layer so we have better changes of getting important requests through first. Prioritize scripts > stylesheets > images.
WebKit/mac:
Reviewed by Darin.
- ForwardingHeaders/wtf/Deque.h: Added.
- 2:01 PM Changeset in webkit [31037] by
-
- 8 edits in trunk/WebCore
This patch makes full page zoom work pretty well. It fixes repainting so that it works when transforms
are set on the RenderView. It also implements the "smart layout" behavior that other browsers support when
zooming. The page will still try to constrain to the viewport size even when zoomed.
Reviewed by john
- dom/Document.cpp: (WebCore::Document::recalcStyle): Make sure to test for transform changes even when there is no zoom. This fixes repainting issues caused by jumping from a zoomed state back to the standard size.
- page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): Adjust for the zoom factor (the render tree is in unzoomed coordinates, but the scrollbars of the view need to handle zoomed coordinates).
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight): Fix the body-sizing-to-the-view-height quirk so that it takes the zoom factor into account when stretching to fill the viewport.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::setHasVisibleContent): Remove the FIXMEs now that absoluteClippedOverflowRect works with transforms on the RenderView.
- rendering/RenderView.cpp: (WebCore::RenderView::calcHeight): (WebCore::RenderView::calcWidth): Make sure the calculated width/height take the zoom factor into account in order to get the "smart layout" behavior.
(WebCore::RenderView::layout):
When deciding whether children have to get a relayout, we need to check the zoomed width/height and not just
the viewport size.
(WebCore::RenderView::computeAbsoluteRepaintRect):
Patched to take into account transforms set on the RenderView.
(WebCore::RenderView::docHeight):
(WebCore::RenderView::docWidth):
Patched to just always use m_width and m_height initially, since those have already been adjusted for
the zoom factor.
(WebCore::RenderView::zoomedHeight):
(WebCore::RenderView::zoomedWidth):
- rendering/RenderView.h: New helper methods for obtaining the adjusted width/height of the viewport taking into account the zoom factor.
- 1:02 PM Changeset in webkit [31036] by
-
- 2 edits in trunk/WebCore
Build fix.
- WebCore.base.exp:
- 12:08 PM Changeset in webkit [31035] by
-
- 8 edits in trunk
WebCore:
Reviewed by Adam.
Get rid of actualRequest, it is not used anymore. Also, get rid of
initialRequest and replace all uses with originalRequest because those are
the same thing.
- loader/DocumentLoader.cpp:
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::originalRequestURL):
WebKit/mac:
Reviewed by Adam.
Call originalRequest, not initialRequest.
- WebView/WebDataSource.mm: (-[WebDataSource initialRequest]):
WebKit/win:
Reviewed by Adam.
Call originalRequest instead of initialRequest.
- WebDataSource.cpp: (WebDataSource::initialRequest):
- 12:00 PM Changeset in webkit [31034] by
-
- 8 edits in trunk/WebCore
Reviewed by Anders
Convert SharedBuffer to start with a refCount of 1
- loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::willStopBufferingData):
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultIcon): (WebCore::IconDatabase::getImageDataForIconURLFromSQLDatabase):
- loader/loader.cpp: (WebCore::Loader::didReceiveData):
- platform/SharedBuffer.h: (WebCore::SharedBuffer::create): Make all constructors private, add ::create() calls
- platform/SharedBuffer.cpp: (WebCore::SharedBuffer::SharedBuffer): Revert to default RefCounted constructor to start with a ref count of 1 (WebCore::SharedBuffer::copy):
- platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::wrapNSData): (WebCore::SharedBuffer::SharedBuffer): Revert to default RefCounted constructor to start with a ref count of 1
- 11:42 AM BuildingOnWindows edited by
- Removed note about PGO (this was fixed in r31033) (diff)
- 11:37 AM Changeset in webkit [31033] by
-
- 6 edits in trunk
PGO build fixes.
Disable PGO for normal release builds.
Added work-in-progress Release_PGOInstrument/Release_PGOOptimize targets.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
WebCore:
PGO build fixes.
Disable PGO for normal release builds.
Added work-in-progress Release_PGOInstrument/Release_PGOOptimize targets.
- WebCore.vcproj/WebCore.vcproj:
WebKit/win:
PGO build fixes.
Disable PGO for normal release builds.
Added work-in-progress Release_PGOInstrument/Release_PGOOptimize targets.
- WebKit.vcproj/WebKit.vcproj:
- 11:32 AM Changeset in webkit [31032] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Geoff.
Adding new functionality to Vector. Currently all of the shrink and
resize functions on Vector only shrink the size of the Vector, not
the capacity. For the Vector to take up as little memory as
possible, though, it is necessary to be able to shrink the capacity
as well. So this patch adds that functionality.
I need this for a speed up I am working on, and Geoff wants to use
it in a speed up he is working on also, so he asked me to commit it
now.
- wtf/Vector.h: (WTF::VectorBufferBase::allocateBuffer): (WTF::::shrinkCapacity):
- 11:18 AM Changeset in webkit [31031] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin.
Make a bunch of DocumentLoader setters/getters inline.
- loader/DocumentLoader.cpp:
- loader/DocumentLoader.h: (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isCommitted): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::response): (WebCore::DocumentLoader::mainDocumentError): (WebCore::DocumentLoader::setResponse): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::setIsClientRedirect): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::responses): (WebCore::DocumentLoader::triggeringAction): (WebCore::DocumentLoader::setTriggeringAction): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::setLastCheckedRequest): (WebCore::DocumentLoader::lastCheckedRequest): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::setLoadingFromCachedPage): (WebCore::DocumentLoader::isLoadingFromCachedPage):
- 9:17 AM Changeset in webkit [31030] by
-
- 2 edits in trunk/JavaScriptCore
Attempt at fixing the Qt/Windows build bot. Quote using double-quotes
instead of single quotes.
- 8:19 AM Changeset in webkit [31029] by
-
- 2 edits in trunk/WebCore
2008-03-13 Rodney Dawes <dobey@wayofthemonkey.com>
Fix builds without SVG enabled.
- page/Frame.cpp: (Frame::shouldApplyTextZoom): (Frame::shouldApplyPageZoom):
- 7:49 AM Changeset in webkit [31028] by
-
- 15 edits in trunk/WebKit/mac
Reviewed by John Sullivan.
- cleanup after removing the bridge
- DOM/WebDOMOperations.mm: (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.
- Misc/WebCoreStatistics.mm: (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of _frameLoader method. (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): Ditto.
- Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame method. Without this we could leave a stale frame pointer around. (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single caller of the _isMainFrame method. (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of _frameLoader method. (WebFrameLoaderClient::createFrame): Moved code here from _addChild.
- WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others turned out to be unused. (core): Added overload for DocumentFragment. (kit): Ditto. (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and to FrameLoader with _private->coreFrame->loader(). (-[WebFrame _attachScriptDebugger]): Ditto. (-[WebFrame _clearCoreFrame]): Added. (-[WebFrame _updateBackground]): More of the same. (-[WebFrame _unmarkAllBadGrammar]): Ditto. (-[WebFrame _unmarkAllMisspellings]): Ditto. (-[WebFrame _hasSelection]): Ditto. (-[WebFrame _atMostOneFrameHasSelection]): Ditto. (-[WebFrame _findFrameWithSelection]): Ditto. (-[WebFrame _dataSource]): Ditto. (-[WebFrame _addData:]): Streamlined code a bit. (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto. (-[WebFrame _receivedData:textEncodingName:]): Ditto. (-[WebFrame _isDescendantOfFrame:]): Ditto. (-[WebFrame _bodyBackgroundColor]): Ditto. (-[WebFrame _isFrameSet]): Ditto. (-[WebFrame _firstLayoutDone]): Ditto. (-[WebFrame _loadType]): Ditto. (-[WebFrame _isDisplayingStandaloneImage]): Ditto. (-[WebFrame name]): Ditto. (-[WebFrame DOMDocument]): Ditto. (-[WebFrame frameElement]): Ditto. (-[WebFrame provisionalDataSource]): Ditto. (-[WebFrame dataSource]): Ditto. (-[WebFrame loadRequest:]): Ditto. (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto. (-[WebFrame loadArchive:]): Ditto. (-[WebFrame stopLoading]): Ditto. (-[WebFrame reload]): Ditto. (-[WebFrame findFrameNamed:]): Ditto. (-[WebFrame parentFrame]): Ditto. (-[WebFrame childFrames]): Ditto. (-[WebFrame windowObject]): Ditto. (-[WebFrame globalContext]): Ditto.
- WebView/WebFrameInternal.h: Added overloads of core and kit. Removed method declarations.
- WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame. (formElementFromDOMElement): Ditto. (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto. (inputElementFromDOMElement): Ditto. (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto. (-[WebHTMLRepresentation elementIsPassword:]): Ditto. (-[WebHTMLRepresentation formForElement:]): Ditto. (-[WebHTMLRepresentation currentForm]): Ditto. (-[WebHTMLRepresentation controlsInForm:]): Ditto. (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto. (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
- WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Call createFragmentFromText directly instead of via WebFrame. (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Moved layout calls here from WebFrame. (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto. (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection. (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity. (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange. (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit. (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Moved code here from WebFrame. (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto. (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto. (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto. (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto. (-[WebHTMLView unmarkAllTextMatches]): Ditto. (-[WebHTMLView rectsForTextMatches]): Ditto.
- WebView/WebHTMLViewInternal.h: Removed unused method declarations.
- WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of _frameLoader method.
- WebView/WebRenderNode.mm: (copyRenderNode): Moved code here from WebFrame. (-[WebRenderNode initWithWebFrameView:]): Ditto.
- WebView/WebResource.mm: (-[WebResource _stringValue]): Moved code here from WebFrame.
- WebView/WebView.mm: (-[WebView _close]): Use core function intsead of _frameLoader method. (-[WebView setCustomTextEncodingName:]): Ditto. (-[WebView setHostWindow:]): Moved code here from WebFrame. (aeDescFromJSValue): Moved this here from WebFrame. (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.
- 5:17 AM Changeset in webkit [31027] by
-
- 7 edits in trunk
Fix the Qt build.
- 1:51 AM QtWebKitContrib edited by
- (diff)
- 1:50 AM QtWebKitContrib edited by
- (diff)
- 12:11 AM Changeset in webkit [31026] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
Fix <rdar://problem/5784773>
Crash loading QT movies @ apple.com/ipodtouch/features.html with a PAC file (WebKitThreadingException)
Make bridged RuntimeObjects get collected on the main thread only. This is necessary
because clients of the bridged objects are unlikely to prepared for a collection on
non-main thread, which can happen with a PAC file.
- bridge/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp):
Mar 12, 2008:
- 11:19 PM Google Summer of Code 2008 edited by
- Removed a completed task (diff)
- 11:13 PM Changeset in webkit [31025] by
-
- 2 edits in trunk/WebCore
Fix Bug 17815: Inspector's DOM tree should descend into subframes
Reviewed by Tim.
- page/inspector/DocumentPanel.js:
(WebInspector.DocumentPanel.revealNode): Changed to provide
_isAncestorIncludingParentFramesWithinPanel and
_parentNodeOrFrameElementWithinPanel for the isAncestor and getParent
parameters to findTreeElement so that parent frames will be searched.
(WebInspector.DocumentPanel.updateBreadcrumb):
- Changed while loop to for loop
- Use _parentNodeOrFrameElementWithinPanel instead of Node.parentNode to move to the next node
- The loop now ends when we reach the DocumentPanel's document node
- Traversal past other Document nodes is now allowed
- We add the "start" class to the final crumb after the loop exits
(WebInspector.DocumentPanel._getDocumentForNode): Added. Simple helper
that returns the node itself if the node is a Document node, or the
node's ownerDocument otherwise.
(WebInspector.DocumentPanel._parentNodeOrFrameElementWithinPanel):
Added. Returns the node's parent node or, in the case of a Document
node, the node's window's owning frame element, but will not return a
node that is in a parent frame of the DocumentPanel's Document.
(WebInspector.DocumentPanel._isAncestorIncludingParentFramesWithinPanel):
Added. Returns true if a is an ancestor of b if a is an ancestor of a
frame element whose subframe(s) contain b.
(WebInspector.DOMNodeTreeElement): We now consider ourselves to have
children if we have a contentDocument.
(WebInspector.DOMNodeTreeElement.onpopulate): Moved the appendChild
loop into a function so that we can add both children of our
contentDocument and children of our node to the tree.
(WebInspector.DOMNodeTreeElement.ondblclick): Changed so that we get
the rootDOMNode by traversing the tree outline hierarchy instead of
the DOM hierarchy so that we can easily jump up to a parent frame.
- 11:13 PM Changeset in webkit [31024] by
-
- 3 edits in trunk/WebCore
Update the styles/metrics panes and breadcrumb after editing DOM attributes
Reviewed by Tim.
- page/inspector/DocumentPanel.js: (WebInspector.DocumentPanel.set focusedDOMNode): Moved code to update the parts of the DocumentPanel other than the DOM tree into a new function, _focusedNodeChanged. (WebInspector.DocumentPanel._focusedNodeChanged): Added. The forceUpdate parameter specifies whether the update should occur even if the focused node hasn't changed since the last update. (WebInspector.DocumentPanel.updateBreadcrumb): Added a forceUpdate parameter. If forceUpdate is true, we always rebuild the breadcrumbs. (WebInspector.DocumentPanel.updateStyles): Added a forceUpdate parameter. If forceUpdate is true, we always rebuild the styles pane. (WebInspector.DOMNodeTreeElement._attributeEditingCommitted): Added a call to DocumentPanel._focusedNodeChanged. We have to force the update because we haven't changed the focused node (the attributes of the node have changed).
- page/inspector/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.update): Added a forceUpdate parameter. If forceUpdate is true we always rebuild the styles.
- 11:05 PM Changeset in webkit [31023] by
-
- 2 edits in trunk/WebKit/win
Fix build.
- WebKit.vcproj/WebKit.vcproj:
- 10:49 PM Changeset in webkit [31022] by
-
- 3 edits in trunk/WebKitLibraries
New version of WebKitSystemInterface.lib with
more compiler warnings suppressed.
- win/lib/WebKitSystemInterface.lib:
- win/tools/vsprops/common.vsprops:
- 10:40 PM Changeset in webkit [31021] by
-
- 3 edits in trunk/WebCore
Further Gtk and Qt build fixes.
- 10:39 PM Changeset in webkit [31020] by
-
- 1 edit in trunk/WebKit/win/WebKitPrefix.cpp
Touch file to build WebKit.
- 10:30 PM Changeset in webkit [31019] by
-
- 3 edits in trunk/WebCore
Fix Gtk and Qt builds.
- 10:26 PM Changeset in webkit [31018] by
-
- 2 edits in trunk/WebCore
Mac build fix.
- 10:02 PM Changeset in webkit [31017] by
-
- 2 edits in trunk/WebCore
Build fix.
- page/win/FrameWin.cpp:
- 9:29 PM BuildingOnWindows edited by
- Added a note about Release build being broken in VC++ Express (diff)
- 9:20 PM Changeset in webkit [31016] by
-
- 2 edits in trunk/WebCore
Build fix.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::bindingInstance):
- 8:50 PM Changeset in webkit [31015] by
-
- 2 edits in trunk/WebKit/win
<rdar://problem/5795843>
CFURLDownload needs to be cancelled if we don't have a destination path
to save resume information.
Reviewed by Brady.
- WebDownload.cpp: (WebDownload::cancelForResume):
- 8:48 PM Changeset in webkit [31014] by
-
- 43 edits4 deletes in trunk
WebCore:
Reviewed by Anders.
- http://bugs.webkit.org/show_bug.cgi?id=17640 eliminate WebCoreFrameBridge
- WebCore.base.exp: Added more exports, needed by code moved from WebCoreFrameBridge to WebFrame in WebKit.
- WebCore.xcodeproj/project.pbxproj: Added more headers, same reason. Also deleted WebCoreFrameBridge.h and WebCoreFrameBridge.mm.
- page/Frame.cpp: (WebCore::Frame::Frame): Added call to initJavaJSBindings(), formerly handled by the WebCoreFrameBridge.
- page/Frame.h: Added initJavaJSBindings function.
- page/mac/FrameMac.mm: (WebCore::updateRenderingForBindings): Moved here from WebCoreFrameBridge. (WebCore::Frame::initJavaJSBindings): Ditto; code was in the init function.
- page/mac/WebCoreFrameBridge.h: Removed.
- page/mac/WebCoreFrameBridge.mm: Removed.
WebKit:
Reviewed by Anders.
- http://bugs.webkit.org/show_bug.cgi?id=17640 eliminate WebCoreFrameBridge
- StringsNotToBeLocalized.txt: Updated for recent changes.
- WebKit.xcodeproj/project.pbxproj: Removed WebFrameBridge.h and WebFrameBridge.mm.
WebKit/mac:
Reviewed by Anders.
- http://bugs.webkit.org/show_bug.cgi?id=17640 eliminate WebCoreFrameBridge
Moved all the code from the bridge into WebFrame. This need not be the final
home of these methods -- they can be moved closer to their callers and improved
further -- but it eliminates the bridge without requiring a rewrite of the code.
It's a fairly mechanical process (just adding underscores to method names really).
There's even a chance that some of the methods are unused. Those we can remove
after checking if that's so.
- DOM/WebDOMOperations.mm: (-[DOMNode markupString]): Use WebFrame rather than bridge. (-[DOMDocument webFrame]): Changed to use the core and kit functions instead of using the bridge. (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge. (-[DOMRange markupString]): Ditto.
- DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.
- DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
- History/WebHistoryItem.mm: Ditto.
- MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
- Misc/WebCoreStatistics.mm: (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.
- Misc/WebElementDictionary.mm: Removed unneeded import.
- Misc/WebKitStatistics.m: (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
- Misc/WebKitStatisticsPrivate.h: Ditto.
- Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
- Misc/WebNSPasteboardExtras.mm: Ditto.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame rather than bridge.
- Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
- Plugins/WebNetscapePluginStream.mm: Ditto.
- Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than bridge to get to the WebCore::Frame.
- Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
- Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame rather than bridge.
- WebCoreSupport/WebEditorClient.mm: (selectorForKeyEvent): Tweaked comment.
- WebCoreSupport/WebFrameBridge.h: Removed.
- WebCoreSupport/WebFrameBridge.mm: Removed.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion. (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code. I could remove this function entirely, but it looks like the Qt port is using it.
- WebCoreSupport/WebViewFactory.mm: Removed unneeded import.
- WebView/WebArchiver.mm: (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge. (+[WebArchiver archiveNode:]): Ditto. (+[WebArchiver archiveSelectionInFrame:]): Ditto.
- WebView/WebDataSource.mm: (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto. (-[WebDataSource _documentFragmentWithArchive:]): Ditto. (-[WebDataSource subresources]): Ditto. (-[WebDataSource subresourceForURL:]): Ditto.
- WebView/WebDataSourceInternal.h: Removed _bridge method.
- WebView/WebFrame.mm: (-[WebFramePrivate dealloc]): Removed code to release the bridge. (core): Go directly to the core frame, not via the bridge. (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Remove the code to deal with the bridge. (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the shouldCreateRenderers flag, formerly on the bridge. (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge. (aeDescFromJSValue): Moved here from bridge. (-[WebFrame _domain]): Ditto. (-[WebFrame _addData:]): Ditto. (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto. (-[WebFrame _nodesFromList:]): Ditto. (-[WebFrame _markupStringFromNode:nodes:]): Ditto. (-[WebFrame _markupStringFromRange:nodes:]): Ditto. (-[WebFrame _selectedString]): Ditto. (-[WebFrame _stringForRange:]): Ditto. (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto. (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto. (-[WebFrame _sendScrollEvent]): Ditto. (-[WebFrame _drawRect:]): Ditto. (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto. (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto. (-[WebFrame _copyRenderNode:copier:]): Ditto. (-[WebFrame _copyRenderTree:]): Ditto. (inputElementFromDOMElement): Ditto. (formElementFromDOMElement): Ditto. (-[WebFrame _elementWithName:inForm:]): Ditto. (-[WebFrame _elementDoesAutoComplete:]): Ditto. (-[WebFrame _elementIsPassword:]): Ditto. (-[WebFrame _formForElement:]): Ditto. (-[WebFrame _currentForm]): Ditto. (-[WebFrame _controlsInForm:]): Ditto. (-[WebFrame _searchForLabels:beforeElement:]): Ditto. (-[WebFrame _matchLabels:againstElement:]): Ditto. (-[WebFrame _URLWithAttributeString:]): Ditto. (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto. (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto. (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto. (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto. (-[WebFrame _unmarkAllTextMatches]): Ditto. (-[WebFrame _rectsForTextMatches]): Ditto. (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto. (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto. (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto. (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto. (-[WebFrame _firstRectForDOMRange:]): Ditto. (-[WebFrame _scrollDOMRangeToVisible:]): Ditto. (-[WebFrame _baseURL]): Ditto. (-[WebFrame _stringWithData:]): Ditto. (+[WebFrame _stringWithData:textEncodingName:]): Ditto. (-[WebFrame _needsLayout]): Ditto. (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto. (-[WebFrame _accessibilityTree]): Ditto. (-[WebFrame _setBaseBackgroundColor:]): Ditto. (-[WebFrame _setDrawsBackground:]): Ditto. (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]): Ditto. (-[WebFrame _selectionGranularity]): Ditto. (-[WebFrame _convertToNSRange:]): Ditto. (-[WebFrame _convertToDOMRange:]): Ditto. (-[WebFrame _convertNSRangeToDOMRange:]): Ditto. (-[WebFrame _convertDOMRangeToNSRange:]): Ditto. (-[WebFrame _markDOMRange]): Ditto. (-[WebFrame _markedTextNSRange]): Ditto. (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto. (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto. (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto. (-[WebFrame _documentFragmentWithText:inContext:]): Ditto. (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto. (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto. (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto. (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto. (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto. (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto. (-[WebFrame _visiblePositionForPoint:]): Ditto. (-[WebFrame _characterRangeAtPoint:]): Ditto. (-[WebFrame _typingStyle]): Ditto. (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto. (-[WebFrame _fontForSelection:]): Ditto. (-[WebFrame _dragSourceMovedTo:]): Ditto. (-[WebFrame _dragSourceEndedAt:operation:]): Ditto. (-[WebFrame _getData:andResponse:forURL:]): Ditto. (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto. (-[WebFrame _canProvideDocumentSource]): Ditto. (-[WebFrame _canSaveAsWebArchive]): Ditto. (-[WebFrame _receivedData:textEncodingName:]): Ditto. (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting function. Couldn't just keep the bridge method because this was already here with the same name. (-[WebFrame _selectedNSRange]): Ditto. (-[WebFrame _selectNSRange:]): Ditto. (-[WebFrame dealloc]): Remove bridge-related code. (-[WebFrame finalize]): Ditto.
- WebView/WebFrameInternal.h: Added all the method declarations from the bridge. Removed the bridge parameter from the init method. Removed the #if blocks that tried to make this header work in non-C++ ObjC files -- they were broken and unused. Removed the _bridge method.
- WebView/WebFrameView.mm: Removed the _bridge method.
- WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge field. (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge. (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto. (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto. (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto. (-[WebHTMLRepresentation documentSource]): Ditto. (-[WebHTMLRepresentation DOMDocument]): Ditto. (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto. (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto. (-[WebHTMLRepresentation elementIsPassword:]): Ditto. (-[WebHTMLRepresentation formForElement:]): Ditto. (-[WebHTMLRepresentation currentForm]): Ditto. (-[WebHTMLRepresentation controlsInForm:]): Ditto. (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto. (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
- WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.
- WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge. (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto. (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto. (-[WebHTMLView _updateTextSizeMultiplier]): Ditto. (-[WebHTMLView _frameOrBoundsChanged]): Ditto. (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto. (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto. (-[WebHTMLView drawSingleRect:]): Ditto. (-[WebHTMLView draggedImage:movedTo:]): Ditto. (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto. (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto. (-[WebHTMLView knowsPageRange:]): Ditto. (-[WebHTMLView accessibilityAttributeValue:]): Ditto. (-[WebHTMLView accessibilityFocusedUIElement]): Ditto. (-[WebHTMLView accessibilityHitTest:]): Ditto. (-[WebHTMLView _accessibilityParentForSubview:]): Ditto. (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto. (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto. (-[WebHTMLView _changeSpellingToWord:]): Ditto. (-[WebHTMLView startSpeaking:]): Ditto. (-[WebHTMLView _updateFontPanel]): Ditto. (-[WebHTMLView _canSmartCopyOrDelete]): Ditto. (-[WebHTMLView _layoutIfNeeded]): Ditto. (-[WebHTMLView characterIndexForPoint:]): Ditto. (-[WebHTMLView firstRectForCharacterRange:]): Ditto. (-[WebHTMLView selectedRange]): Ditto. (-[WebHTMLView markedRange]): Ditto. (-[WebHTMLView attributedSubstringFromRange:]): Ditto. (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. (-[WebHTMLView insertText:]): Ditto. (-[WebTextCompleteController _insertMatch:]): Ditto. (-[WebTextCompleteController doCompletion]): Ditto. (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto. (-[WebHTMLView string]): Ditto. (-[WebHTMLView selectedString]): Ditto. (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto. (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto. (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto. (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto. (-[WebHTMLView unmarkAllTextMatches]): Ditto. (-[WebHTMLView rectsForTextMatches]): Ditto.
- WebView/WebRenderNode.mm: (-[WebRenderNode initWithWebFrameView:]): Ditto.
- WebView/WebResource.mm: (-[WebResource _stringValue]): Ditto.
- WebView/WebScriptDebugDelegate.mm: Removed unneeded include.
- WebView/WebView.mm: (-[WebView _dashboardRegions]): Use WebFrame instead of bridge. (-[WebView setProhibitsMainFrameScrolling:]): Ditto. (-[WebView _setInViewSourceMode:]): Ditto. (-[WebView _inViewSourceMode]): Ditto. (-[WebView _executeCoreCommandByName:value:]): Ditto. (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto. (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto. (-[WebView scrollDOMRangeToVisible:]): Ditto. (-[WebView setSelectedDOMRange:affinity:]): Ditto. (-[WebView setEditable:]): Ditto. (-[WebView setTypingStyle:]): Ditto. (-[WebView typingStyle]): Ditto. (-[WebView replaceSelectionWithNode:]): Ditto. (-[WebView replaceSelectionWithText:]): Ditto. (-[WebView replaceSelectionWithMarkupString:]): Ditto. (-[WebView replaceSelectionWithArchive:]): Ditto. (-[WebView _insertNewlineInQuotedContent]): Ditto. (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.
- 8:40 PM Changeset in webkit [31013] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders Carlsson.
Don't go through the Document just to get the frame Element.
- page/DOMWindow.cpp: (WebCore::DOMWindow::frameElement):
- 8:18 PM Changeset in webkit [31012] by
-
- 20 edits in trunk/WebCore
Reviewed by Geoff and Sam.
More Instance cleanup:
- Make Instance inherit from RefCounted instead of doing its own refcounting.
- Make all Instance subclasses private, add static create methods.
- Have Instance start out with a refcount of 1.
- Get rid of Instance::createBindingForLanguageInstance and call the individual instance constructor methods instead.
- Fix many methods to take and return PassRefPtr<Instance> to ensure that the refcounting is done correctly.
- bridge/c/c_instance.h: (KJS::Bindings::CInstance::create):
- bridge/c/c_utility.cpp: (KJS::Bindings::convertNPVariantToValue):
- bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
- bridge/jni/jni_instance.h: (KJS::Bindings::JavaInstance::create):
- bridge/jni/jni_jsobject.cpp: (JavaJSObject::convertJObjectToValue):
- bridge/jni/jni_runtime.cpp: (JavaField::valueFromInstance): (JavaArray::valueAt):
- bridge/objc/objc_instance.h: (KJS::Bindings::ObjcInstance::create):
- bridge/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue):
- bridge/qt/qt_instance.cpp: (KJS::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp): (KJS::Bindings::QtInstance::getQtInstance): (KJS::Bindings::QtInstance::getRuntimeObject):
- bridge/qt/qt_instance.h:
- bridge/runtime.cpp: (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::createRuntimeObject):
- bridge/runtime.h:
- bridge/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp):
- bridge/runtime_object.h:
- page/Frame.h:
- page/mac/FrameMac.mm: (WebCore::Frame::createScriptInstanceForWidget):
- page/win/FrameWin.cpp: (WebCore::Frame::createScriptInstanceForWidget):
- plugins/PluginView.h:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::bindingInstance):
- 5:25 PM Changeset in webkit [31011] by
-
- 2 edits in trunk/WebCore
Suggested by Darin Adler. Reviewed by Dave Hyatt.
- speed up BidiIterator::direction()
- rendering/bidi.cpp: (WebCore::BidiIterator::current): Made inline and corrected the out-of-bounds condition to work with 0-length text and offsets beyond the end of the text. (WebCore::BidiIterator::direction): Changed to call current() and not call the virtual method isListMarker() most of the time. (WebCore::addMidpoint): Removed unnecessary null-check of smidpoints. (WebCore::appendRunsForObject): Ditto.
- 4:00 PM Changeset in webkit [31010] by
-
- 2 edits in trunk/WebCore
Make URLs not be underlined while editing them in the DOM view
Reviewed by Tim.
- page/inspector/inspector.css:
- 4:00 PM Changeset in webkit [31009] by
-
- 4 edits in trunk/WebCore
Part of Bug 17224: DOM nodes/attributes should be editable
<http://bugs.webkit.org/show_bug.cgi?id=17224>
<rdar://problem/5732825>
We now start editing if the user single-clicks on an attribute,
attribute value, or text node while the parent element is selected.
Previously, we started editing on double-click regardless of the
selection state of the element.
URLs in the DOM tree are now followed on Alt/Option-click, rather than
on just click.
Reviewed by Tim.
- English.lproj/InspectorLocalizedStrings.js: Added four new localized strings.
- page/inspector/DocumentPanel.js:
(WebInspector.DOMNodeTreeElement.onattach): Call new
_makeURLSActivateOnModifiedClick.
(WebInspector.DOMNodeTreeElement._makeURLsActivateOnModifiedClick):
Added. Changes the tooltip of each link in this element to indicate
that Alt/Option-click will follow the URL, and sets the
followOnAltClick property on each link.
(WebInspector.DOMNodeTreeElement.onselect): Mark that we're being
selected.
(WebInspector.DOMNodeTreeElement.onmousedown): If we're not currently
being selected, start editing.
(WebInspector.DOMNodeTreeElement.ondblclick): We no longer start
editing here. We block re-rooting of the tree if we're currently
editing.
(WebInspector.DOMNodeTreeElement._startEditing):
- Don't do anything if we're not focused
- Pass the event down to _startEditingAttribute.
(WebInspector.DOMNodeTreeElement._startEditingAttribute): Don't do
anything if the event target is a URL and the Alt/Option key is
pressed -- in this case we want to follow the link.
(WebInspector.DOMNodeTreeElement._updateTitle): Call
_makeURLsActivateOnClick again since the anchor elements have all been
recreated.
- page/inspector/inspector.js: (WebInspector.documentClick): If the anchor as a followOnAltClick property and the Alt/Option key is not pressed, do nothing.
- 3:23 PM Changeset in webkit [31008] by
-
- 2 edits in trunk/WebCore
Fixed the initial value of zoom factor.
Reviewed by Adam.
- page/Frame.cpp: (WebCore::FramePrivate::FramePrivate):
- 3:13 PM Google Summer of Code 2008 edited by
- Fix typo (diff)
- 2:41 PM Changeset in webkit [31007] by
-
- 7 edits in trunk/WebCore
Make full page zoom vaguely work. This patch uses the CSS transform system to turn on full page zoom at the
document level. There are many many bugs that I'm going to file to track all the issues (most of the issues
are just bugs with transforms themselves).
Reviewed by Adam Roben
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
- dom/Document.cpp: (WebCore::Document::recalcStyle):
- page/Frame.cpp: (WebCore::Frame::shouldApplyTextZoom): (WebCore::Frame::shouldApplyPageZoom):
- page/Frame.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::setHasVisibleContent): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer):
- rendering/RenderLayer.h:
- 2:33 PM Changeset in webkit [31006] by
-
- 1 edit in trunk/WebKit/win/WebKitPrefix.cpp
Touch file to force WebKit rebuild
- 1:57 PM Changeset in webkit [31005] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- 12:40 PM Changeset in webkit [31004] by
-
- 2 edits in trunk/WebKit/gtk
2008-03-12 Tommi Komulainen <tommi.komulainen@iki.fi>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=17799
WebView signals should use more specific types
- webkit/webkitwebview.cpp: Use WEBKIT_TYPE_WEB_FRAME argument type in "script-alert", "script-confirm", "script-script-prompt" signals so that it gets more clearly documented rather than just plain GObject.
- 12:14 PM Changeset in webkit [31003] by
-
- 13 edits in trunk
WebCore:
Make the zoom factor a float and not a percent.
Reviewed by antti
- WebCore.base.exp:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
- page/Frame.cpp: (WebCore::Frame::zoomFactor): (WebCore::Frame::setZoomFactor):
- page/Frame.h:
- page/FramePrivate.h:
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale):
WebKit/mac:
Make the zoom factor a float and not a percent.
Reviewed by antti
- WebView/WebView.mm: (-[WebView _setZoomMultiplier:isTextOnly:]):
WebKit/win:
Make the zoom factor a float and not a percent.
Reviewed by antti
- WebFrame.cpp: (WebFrame::setTextSizeMultiplier):
WebKit/wx:
Make the zoom factor a float and not a percent.
Reviewed by antti
- WebView.cpp: (wxWebView::IncreaseTextSize): (wxWebView::DecreaseTextSize):
- 12:10 PM Changeset in webkit [31002] by
-
- 3 edits in trunk/WebKit/win
Build fix.
- WebKit.vcproj/WebKit.pgd:
- WebKit.vcproj/WebKit.vcproj:
- 11:50 AM Changeset in webkit [31001] by
-
- 1 edit in trunk/WebKit/mac/WebView/WebFrame.mm
Speculative fix for build bustage. Will be another 20-30 mins before I can get compiled enough to know for sure.
- 11:50 AM Changeset in webkit [31000] by
-
- 2 edits in trunk/WebKitTools
VSExpress build fix
- WinLauncher/WinLauncher.vcproj:
- 11:45 AM Changeset in webkit [30999] by
-
- 9 edits in branches/Safari-3-1-branch/WebCore
Merge r30992.
- 11:33 AM Changeset in webkit [30998] by
-
- 12 edits in trunk
WebCore:
Eliminate setTextMultiplier from the bridge. Make Webkit just call setZoomFactor on the frame directly.
Reviewed by Tim H.
- WebCore.base.exp:
- page/mac/WebCoreFrameBridge.h:
- page/mac/WebCoreFrameBridge.mm:
WebKit/mac:
This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
New API is added that is parallel to the text zoom public API. You can get/set a pageSizeMultiplier and you
can zoom the page in, out or reset it to the standard size.
In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
and set the common zoom factor. In other words you can't combine text zoom and page zoom. One will always
win.
Reviewed by Tim H.
- WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
- WebView/WebDocumentInternal.h:
- WebView/WebHTMLView.mm: (-[WebHTMLView viewDidMoveToSuperview]):
- WebView/WebPDFView.h:
- WebView/WebPDFView.mm: (-[WebPDFView _zoomOut:]): (-[WebPDFView _zoomIn:]): (-[WebPDFView _resetZoom:]): (-[WebPDFView _canZoomOut]): (-[WebPDFView _canZoomIn]): (-[WebPDFView _canResetZoom]):
- WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView setTextSizeMultiplier:]): (-[WebView textSizeMultiplier]): (-[WebView _setZoomMultiplier:isTextOnly:]): (-[WebView _zoomMultiplier:]): (-[WebView _realZoomMultiplier]): (-[WebView _realZoomMultiplierIsTextOnly]): (-[WebView _canZoomOut:]): (-[WebView _canZoomIn:]): (-[WebView _zoomOut:isTextOnly:]): (-[WebView _zoomIn:isTextOnly:]): (-[WebView _canResetZoom:]): (-[WebView _resetZoom:isTextOnly:]): (-[WebView canMakeTextSmaller]): (-[WebView makeTextSmaller:]): (-[WebView canMakeTextLarger]): (-[WebView makeTextLarger:]): (-[WebView canMakeTextStandardSize]): (-[WebView makeTextStandardSize:]): (-[WebView setPageSizeMultiplier:]): (-[WebView pageSizeMultiplier]): (-[WebView canZoomPageIn]): (-[WebView zoomPageIn:]): (-[WebView canZoomPageOut]): (-[WebView zoomPageOut:]): (-[WebView canResetPageZoom]): (-[WebView resetPageZoom:]): (-[WebView _searchWithSpotlightFromMenu:]):
- WebView/WebViewInternal.h:
- WebView/WebViewPrivate.h:
- 11:31 AM Changeset in webkit [30997] by
-
- 13 edits in trunk
WebCore:
Reviewed by Darin Adler and Sam Weinig.
- <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
Use CTFontCopyGraphicsFont and CTFontGetPlatformFont on Leopard instead
of wkGetCGFontFromNSFont and wkGetNSFontATSUFontId, relying on NSFont
and CTFontRef being toll-free bridged.
- WebCore.Tiger.exp:
- WebCore.base.exp:
- platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs): Changed to use the cgFont() accessor.
- platform/graphics/mac/FontPlatformData.h: Made m_cgFont a RetainPtr on Leopard. (WebCore::toCTFontRef): Added a function that encapsulates the toll-free bridging. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::cgFont): Added this accessor method.
- platform/graphics/mac/FontPlatformDataMac.mm: (WebCore::FontPlatformData::FontPlatformData): Changed to use CoreText API on Leopard. (WebCore::FontPlatformData::setFont): Ditto.
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::initFontData): (WebCore::pathFromFont): (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformWidthForGlyph):
- platform/mac/WebCoreSystemInterface.mm:
WebKit/mac:
Reviewed by Darin Adler and Sam Weinig.
- <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and WKGetNSFontATSUFontId Tiger-only.
WebKitLibraries:
Reviewed by Darin Adler and Sam Weinig.
- <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- 11:06 AM Changeset in webkit [30996] by
-
- 2 edits in trunk/WebKitTools
2008-03-12 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Alp Toker.
Run testkjs in the correct productsDir in the GTK+ port.
- Scripts/run-javascriptcore-tests:
- 10:56 AM Changeset in webkit [30995] by
-
- 4 edits in trunk/WebKit/win
Re-enabled PGO.
Rubber stamped by Mark Rowe.
- WebKit.vcproj/WebKit.pgd:
- WebKit.vcproj/WebKit.vcproj:
- WebKitPrefix.cpp: touched this file to force a re-build.
- 10:40 AM Google Summer of Code 2008 edited by
- (diff)
- 10:20 AM Changeset in webkit [30994] by
-
- 2 edits in trunk/JavaScriptCore
2008-03-12 Alp Toker <alp@atoker.com>
Another autotools testkjs build fix attempt.
- GNUmakefile.am:
- 9:38 AM Changeset in webkit [30993] by
-
- 2 edits in trunk/WebKit/mac
- fix http://bugs.webkit.org/show_bug.cgi?id=17794 REGRESSION (r30980): 23 tests hanging on the Mac buildbot
- WebView/WebFrame.mm: (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set up pointer from the bridge to the frame. (My next check-in removes the bridge entirely, but we need this until then.)
- 9:16 AM Changeset in webkit [30992] by
-
- 9 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/5607382> CrashTracer: [REGRESSION] 2290 crashes in Safari at com.apple.WebCore: -[WebCoreAXObject isWebArea] + 8
The problem was that we lost track of the AX cache for a subframe when Frame::disconnectOwnerElement() was
called, so we were unable to locate the AXObjects to de-register from AppKit's accessibility registry.
Also saw that cache clearing was missing from Document::detach(), and fixed that.
Also added a debug-only check that AXObjectCache::remove() not finding the AXObject is expected.
Lastly, RenderWidget::destroy() now skips trying to remove the AXObject if accessibility has never been enabled.
- dom/Document.cpp: (WebCore::Document::attach): Assert that there is no AX cache (since there is no renderer).
(WebCore::Document::detach):
Destroy the AX cache installed on this document.
(WebCore::Document::clearAXObjectCache):
New. Destroy the AX cache associated with this document.
(WebCore::Document::axObjectCache):
Added some comments.
- dom/Document.h: Declare clearAXObjectCache().
- page/Frame.cpp: (WebCore::Frame::disconnectOwnerElement): Destroy the AX cache associated with this frame's document.
- page/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::remove):
- page/mac/WebCoreAXObject.mm: (-[WebCoreAXObject initWithRenderer:]): (-[WebCoreAXObject detach]):
- rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::~RenderObject):
- rendering/RenderObject.h: (WebCore::RenderObject::setHasAXObject): (WebCore::RenderObject::hasAXObject): Add debug-only check that AXObjectCache::remove() not finding the AXObject is expected.
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): Skip call to remove the AXObject if accessibility has never been enabled. A simple speed optimization in the very common case that the accessibility APIs are not being used. Same as in RenderObject::destroy().
- 9:12 AM Changeset in webkit [30991] by
-
- 2 edits in trunk/JavaScriptCore
2008-03-12 Alp Toker <alp@atoker.com>
Attempt to fix the autotools testkjs build on systems with
non-standard include paths.
- GNUmakefile.am:
- 8:08 AM Changeset in webkit [30990] by
-
- 2 edits in trunk
Credit the original patch author in the r30989 ChangeLogs
- 8:03 AM Changeset in webkit [30989] by
-
- 6 edits4 adds in trunk
2008-03-12 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
Add Pango font backend.
- 3:01 AM QtWebKitHacking created by
- 2:54 AM QtWebKitTodo edited by
- (diff)
- 1:47 AM Changeset in webkit [30988] by
-
- 4 edits in trunk/WebKit/qt
Fix compilation against Qt 4.3
- 1:17 AM QtWebKitContrib edited by
- (diff)
- 1:12 AM Changeset in webkit [30987] by
-
- 4 edits2 adds in trunk
WebCore:
Reviewed by Oliver.
<rdar://problem/5770834> Crash at InsertTextCommand::prepareForTextInsertion() doing RemoveFormat in a certain list
Fixes some (but not all) of the instances of:
<rdar://problem/5659795> CrashTracer: [REGRESSION] 187 crashes in Safari at com.apple.WebCore: WebCore::InsertTextCommand::prepareForTextInsertion + 241
<rdar://problem/5779631> CrashTracer: [USER] 25 crashes in Mail at WebCore::InsertTextCommand::prepareForTextInsertion
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): applyStyle may have destroyed content that held the old endingSelection(), so we must recompute it. Added a FIXME. Added a few comments.
- editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply): Added a FIXME.
LayoutTests:
Reviewed by Oliver.
<rdar://problem/5770834> Crash at InsertTextCommand::prepareForTextInsertion() doing RemoveFormat in a certain list
- editing/execCommand/5770834-1-expected.txt: Added.
- editing/execCommand/5770834-1.html: Added.
- 1:07 AM Changeset in webkit [30986] by
-
- 5 edits3 copies2 adds in trunk
Reviewed by Darin.
<rdar://problem/5640615> REGRESSION (Safari 2-3): Changing subframe encoding rules broke
some sites.
Other browsers' behavior keeps changing; let's implement what Firefox and Opera do now:
if the frame and subframe belong to the same site, then the encoding is inherited from parent
frame to subframe. Otherwise, it is not.
Always inheriting the encoding would cause a security problem.
Tests: http/tests/misc/frame-default-enc-different-domain.html
http/tests/misc/frame-default-enc-same-domain.html
fast/encoding/frame-default-enc.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::write): Also removed a check for m_frame->document() being non-null - this function also has code that uses it without checking, so it must be safe.
- 1:04 AM Changeset in webkit [30985] by
-
- 2 edits in trunk/WebKit/win
Fix build.
- WebKit.vcproj/WebKit.vcproj:
- 12:51 AM Changeset in webkit [30984] by
-
- 2 edits in trunk/WebCore
Gtk build fix.
- 12:40 AM Changeset in webkit [30983] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin.
<rdar://problem/5787743> REGRESSION: Crash at WTF::Collator::CreateCollator() running fast/js/kde/StringObject.html on Windows
- wtf/unicode/icu/CollatorICU.cpp: (WTF::Collator::createCollator): Check for null (== user default) m_locale before calling strcmp.
- 12:00 AM Changeset in webkit [30982] by
-
- 1 edit in trunk/WebKit/win/WebKitPrefix.cpp
Touch a file in WebKitWin to cause it to build
Mar 11, 2008:
- 10:40 PM Changeset in webkit [30981] by
-
- 9 edits1 add in trunk
Disable LTCG/PGO for grammar.cpp and nodes.cpp.
PGO on these files causes us to hang.
Copy newer vsprops files from relative WebKitLibraries path to environment variable based path.
Reviewed by Oliver.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
WebCore:
Disable LTCG/PGO for all of WebCore for now.
We'll re-enable this as part of follow-on PGO work.
Reviewed by Oliver.
- WebCore.vcproj/WebCore.vcproj:
WebKit/win:
Use PGO to build WebKit.dll.
Reviewed by Oliver.
- WebKit.vcproj/WebKit.pgd: Added.
- WebKit.vcproj/WebKit.vcproj:
WebKitLibraries:
Disable two PGO/LTCG specific warnings.
Reviewed by Oliver.
- win/tools/vsprops/common.vsprops:
- 10:27 PM Changeset in webkit [30980] by
-
- 19 edits in trunk
WebCore:
Reviewed by Sam.
- remove all bridge-related things from WebCore except the bridge itself
- WebCore.base.exp: Removed the bridge and setBridge functions.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent): Removed call to the bridge's close method.
- page/Frame.cpp: (WebCore::Frame::~Frame): Removed call to setBridge(0). (WebCore::FramePrivate::FramePrivate): Removed initialization of m_bridge.
- page/Frame.h: Removed setBridge and bridge functions.
- page/FramePrivate.h: Removed m_bridge pointer.
- page/mac/FrameMac.mm: Removed setBridge and bridge functions.
- page/mac/WebCoreFrameBridge.h: Added setWebCoreFrame: method. Removed bridgeForDOMDocument: and clearFrame methods.
- page/mac/WebCoreFrameBridge.mm: Ditto. (-[WebCoreFrameBridge close]): Changed to set m_frame to 0 directly. (-[WebCoreFrameBridge setWebCoreFrame:]): Added.
WebKit/mac:
Reviewed by Sam.
- remove all bridge-related things from WebCore except the bridge itself
- DOM/WebDOMOperations.mm: (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
- DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
- Plugins/WebPluginController.mm: Ditto.
- WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the init and close methods. Added a setWebFrame: method.
- WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge setWebFrame:]): Added.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion. (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the bridge here. Soon we will be able to remove this entirely! (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved into WebFrame from the bridge.
- WebView/WebFrame.mm: (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's now owned by the frame. (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script debugger under GC without this! (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to use WebFrameLoaderClient instead of the bridge. (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added. This is code that used to live in the bridge's init function. (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto. (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto. (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since the WebView is now the bridge's owner. (-[WebFrame _updateBackground]): Changed this one call site that was calling the WebCore::Frame::bridge function directly to use the kit function instead. (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge. This code won't last long -- we're eliminating the bridge soon. (-[WebFrame finalize]): Ditto.
- WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods for creating frames.
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom where we have to allocate a WebFrameBridge and then immediately release it.
- 10:13 PM Changeset in webkit [30979] by
-
- 5 edits in trunk
WebCore:
- restored some code I removed in the Range change; this code can't go until the rest of the Range fix is in
- dom/Range.cpp: (WebCore::Range::commonAncestorContainer): Added back the check for 0 that I removed erroneously in the Range patch. (WebCore::Range::processContents): Left in assertions I used to debug this.
LayoutTests:
Reviewed by Beth Dakin.
Update test to catch the SECURITY_ERR thrown by
CanvasRenderingContext2D::getImageData() and
HTMLCanvasElement::toDataURL() on a tainted canvas
- http/tests/security/canvas-remote-read-remote-image-expected.txt:
- http/tests/security/canvas-remote-read-remote-image.html:
- 8:51 PM Changeset in webkit [30978] by
-
- 3 edits in trunk/LayoutTests
- update expected result changed by recent Range patch
- platform/mac/editing/execCommand/4920488-expected.txt: Removed incorrect exception log.
- platform/qt/editing/execCommand/4920488-expected.txt: Ditto.
- 6:31 PM Changeset in webkit [30977] by
-
- 2 edits in trunk/WebCore
- fix Release build
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::setContentsPos): Don't use NSMakePoint.
- 6:23 PM Changeset in webkit [30976] by
-
- 31 edits1 add in trunk
WebCore:
Reviewed by Anders.
- simplify Mac code for ScrollView, since it's used only for FrameView and not in two different modes like it was historically
- remove code depending on the bridge to get from an NSView to a WebCore::Frame
- bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _rectOnScreen]): getDocumentView -> documentView.
- bridge/jni/jni_jsobject.cpp: (createRootObject): Instead of using WebCoreViewFactory to find the frame given and NSView, use the WebCoreFrameView interface to do it.
- editing/mac/EditorMac.mm: (WebCore::Editor::paste): getDocumentView -> documentView.
- editing/mac/SelectionControllerMac.mm: (WebCore::SelectionController::notifyAccessibilityForSelectionChange): Ditto.
- page/FrameView.h: Fixed comment.
- page/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): Removed uneeded typecasts to ScrollView* since FrameView is derived from ScrollView.
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): getDocumentView -> documentView.
- page/mac/FrameMac.mm: (WebCore::Frame::imageFromRect): Ditto.
- page/mac/WebCoreAXObject.mm: (-[WebCoreAXObject position]): Ditto. (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto. (-[WebCoreAXObject rendererForView:]): Updated code that used to use WebCoreBridgeHolder to use WebCoreFrameView instead.
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): getDocumentView -> documentView.
- page/mac/WebCoreFrameView.h: Removed the WebCoreScrollbarMode type; we just use WebCore::ScrollbarMode directly. Renamed the WebCoreFrameView protocol to WebCoreFrameScrollView, since it's a protocol for the scroll view, not the frame view itself. Replaced WebCoreBridgeHolder protocol with WebCoreFrameView protocol, which returns a WebCore::Frame directly rather than a bridge.
- page/mac/WebCoreViewFactory.h: Eliminated the bridgeForView method.
- platform/ScrollView.h: Moved the constructor and destructor out of the class-specific #if blocks. Renamed Mac-specific function that gets the NSView for from getDocumentView to documentView and a scrollView function that returns an appropriately classed NSScrollView.
- platform/graphics/MediaPlayer.h: Changed type of parentWidget to FrameView instead of Widget.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): Removed unnecessary cast.
- platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): getDocumentView -> documentView.
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::ScrollView): Added. (WebCore::ScrollView::~ScrollView): Added. (WebCore::ScrollView::scrollView): Added. (WebCore::ScrollView::visibleWidth): Removed unused non-NSScrollView case. (WebCore::ScrollView::visibleHeight): Ditto. (WebCore::ScrollView::visibleContentRect): Ditto. (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): Ditto. (WebCore::ScrollView::contentsWidth): Ditto. (WebCore::ScrollView::contentsHeight): Ditto. (WebCore::ScrollView::contentsX): Ditto. (WebCore::ScrollView::contentsY): Ditto. (WebCore::ScrollView::scrollOffset): Ditto. (WebCore::ScrollView::scrollRectIntoViewRecursively): Ditto. (WebCore::ScrollView::setContentsPos): Ditto. (WebCore::ScrollView::setVScrollbarMode): Ditto. (WebCore::ScrollView::setHScrollbarMode): Ditto. (WebCore::ScrollView::setScrollbarsMode): Ditto. (WebCore::ScrollView::vScrollbarMode): Ditto. (WebCore::ScrollView::hScrollbarMode): Ditto. (WebCore::ScrollView::suppressScrollbars): Ditto. (WebCore::ScrollView::addChild): Ditto. (WebCore::ScrollView::resizeContents): Ditto. (WebCore::ScrollView::updateContents): Ditto. (WebCore::ScrollView::contentsToWindow): Ditto. (WebCore::ScrollView::windowToContents): Ditto. (WebCore::ScrollView::setStaticBackground): Ditto. (WebCore::ScrollView::documentView): Renamed and removed unused case. (WebCore::ScrollView::scrollbarUnderMouse): Removed incorrect comment.
- platform/mac/WidgetMac.mm: (WebCore::Widget::getOuterView): Update for protocol name change.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintCheckbox): getDocumentView -> documentView. (WebCore::RenderThemeMac::paintRadio): Ditto. (WebCore::RenderThemeMac::paintButton): Ditto. (WebCore::RenderThemeMac::paintMenuList): Ditto. (WebCore::RenderThemeMac::paintSliderThumb): Ditto. (WebCore::RenderThemeMac::paintSearchField): Ditto. (WebCore::RenderThemeMac::paintSearchFieldCancelButton): Ditto. (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): Ditto. (WebCore::RenderThemeMac::paintSearchFieldResultsButton): Ditto.
WebKit:
Reviewed by Anders.
- WebKit.xcodeproj/project.pbxproj: Change WebDynamicScrollBarsView.m to be Obj-C++. We can rename the file later.
WebKit/mac:
Reviewed by Anders.
- remove code depending on the bridge to get from an NSView to a WebCore::Frame
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call to setView. A couple lines later, there is a call to _install, which sets the view to the scroll view.
- WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method.
- WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of this file, since it's used by Safari.
- WebView/WebDynamicScrollBarsViewInternal.h: Added.
- WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): Ditto. (-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto. (-[WebDynamicScrollBarsView allowsScrolling]): Ditto. (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto. (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto. (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto. (-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto. (-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto. (-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto. (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto. (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto. (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto. (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto. (-[WebDynamicScrollBarsView setScrollingMode:]): Ditto. (-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto.
- WebView/WebFrameView.mm: (-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method.
- WebView/WebView.mm: (-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h. (-[WebView alwaysShowVerticalScroller]): Ditto. (-[WebView setAlwaysShowHorizontalScroller:]): Ditto. (-[WebView alwaysShowHorizontalScroller]): Ditto.
- 5:48 PM Changeset in webkit [30975] by
-
- 14 edits in trunk
WebCore:
Reviewed by Adam Roben.
Split CookieJarWin.cpp into CFNet and non-CFNet versions to
reduce the massive amount of conditionalization in the file.
(see http://bugs.webkit.org/show_bug.cgi?id=17788)
- WebCore.vcproj/WebCore.vcproj:
- platform/network/win/CookieJarCFNetWin.cpp: Copied from WebCore/platform/network/win/CookieJarWin.cpp. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
- platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
WebKit/mac:
Reviewed by Sam.
- eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore
- WebCoreSupport/WebChromeClient.h: Added new virtual functions that replace bridge methods.
- WebCoreSupport/WebChromeClient.mm: Added lots of BEGIN_BLOCK_OBJC_EXCEPTIONS to recently-created functions. (WebChromeClient::firstResponder): Moved code here from the bridge. (WebChromeClient::makeFirstResponder): Ditto. (WebChromeClient::runOpenPanel): Ditto. (WebChromeClient::willPopUpMenu): Ditto.
- WebCoreSupport/WebFrameBridge.h: Removed almost everything. What's left is related to creating the bridge and connecting it to WebCore, which will go next when I eliminate use of the bridge to get to/from the Frame*.
- WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge close]): Moved the code to track the bridge count here instead of the dealloc and finalize methods.
- 5:40 PM Google Summer of Code 2008 edited by
- (diff)
- 5:28 PM Changeset in webkit [30974] by
-
- 3 edits1 copy in trunk/WebCore
2008-03-11 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
Split CookieJarWin.cpp into CFNet and non-CFNet versions to
reduce the massive amount of conditionalization in the file.
(see http://bugs.webkit.org/show_bug.cgi?id=17788)
- WebCore.vcproj/WebCore.vcproj:
- platform/network/win/CookieJarCFNetWin.cpp: Copied from WebCore/platform/network/win/CookieJarWin.cpp. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
- platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
- 5:12 PM Google Summer of Code 2008 edited by
- (diff)
- 5:02 PM Writing Layout Tests for DumpRenderTree edited by
- (diff)
- 4:56 PM Google Summer of Code 2008 edited by
- (diff)
- 4:43 PM Changeset in webkit [30973] by
-
- 27 edits in trunk
WebCore:
Reviewed by Mitz.
- make some Range improvements (preparation for Range support for DOM mutation)
Made constructors private, added create functions.
Made refcount start at 1 rather than starting at 0 and being incremented.
Made Range use two Position objects for the start/end container/offset pairs.
- WebCore.base.exp: Updated.
- dom/Document.cpp: (WebCore::Document::createRange): Changed to use Range::create. (WebCore::Document::removeMarkers): Updated for Range::first/pastLastNode name change.
- dom/Position.cpp: (WebCore::Position::formatForDebugger): Updated for member variable name change. (WebCore::Position::showTreeForThis): Ditto. (WebCore::startPosition): Changed to use Range::startPosition. (WebCore::endPosition): Changed to use Range::endPosition.
- dom/Position.h: Made the data members public and renamed them to container and offset. But since offset() is already a function, temporarily used posOffset for the data member. Later we'll get rid of offset(). Made more functions inline. Removed the constructor that takes a PositionIterator.
- dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position): Added. Replaces the constructor that used to be in Position.
- dom/PositionIterator.h: Added conversion operator to produce a Position. Removed friend declaration for Position.
- dom/Range.cpp: (WebCore::Range::Range): Updated constructors for data member changes and made them use a refcount of 1. (WebCore::Range::create): Added. (WebCore::Range::startContainer): Updated to eliminate use of m_detached; detached is now indicated by m_start.container of 0. Also updated to use m_start instead of the old m_startContainer. (WebCore::Range::startOffset): Ditto. (WebCore::Range::endContainer): Ditto. (WebCore::Range::endOffset): Ditto. (WebCore::Range::commonAncestorContainer): Ditto. (WebCore::Range::collapsed): Ditto. (WebCore::Range::setStart): Ditto. (WebCore::Range::setEnd): Ditto. (WebCore::Range::collapse): Ditto. (WebCore::Range::isPointInRange): Ditto. (WebCore::Range::comparePoint): Ditto. (WebCore::Range::compareNode): Ditto. (WebCore::Range::compareBoundaryPoints): Ditto. (WebCore::Range::boundaryPointsValid): Ditto. (WebCore::Range::deleteContents): Ditto. (WebCore::Range::intersectsNode): Ditto. (WebCore::Range::processContents): Ditto. (WebCore::Range::extractContents): Ditto. (WebCore::Range::cloneContents): Ditto. (WebCore::Range::insertNode): Ditto. (WebCore::Range::toString): Ditto. (WebCore::Range::text): Ditto. (WebCore::Range::createContextualFragment): Ditto. (WebCore::Range::detach): Ditto. (WebCore::Range::checkNodeBA): Changed to use switch statements instead of multiple calls to the virtual nodeType() function. (WebCore::Range::cloneRange): Ditto. (WebCore::Range::setStartAfter): Ditto. (WebCore::Range::setEndBefore): Ditto. (WebCore::Range::setEndAfter): Ditto. (WebCore::Range::selectNode): Ditto. (WebCore::Range::selectNodeContents): Ditto. (WebCore::Range::surroundContents): Ditto. (WebCore::Range::setStartBefore): Ditto. (WebCore::Range::checkDeleteExtract): Ditto. (WebCore::Range::containedByReadOnly): Ditto. (WebCore::Range::firstNode): Ditto. (WebCore::Range::editingStartPosition): Ditto. (WebCore::Range::pastLastNode): Ditto. (WebCore::Range::addLineBoxRects): Ditto. (WebCore::Range::formatForDebugger): Ditto. (WebCore::operator==): Ditto. (WebCore::rangeOfContents): Ditto. (WebCore::Range::maxStartOffset): Ditto. (WebCore::Range::maxEndOffset): Ditto.
- dom/Range.h: Made constructors private. Added create functions. Added getters for startContainer/Offset and endContainer/Offset that return 0 instead of an exception for detached ranges that are inline and don't require an ExceptionCode out parameter. Changed the parameters to setStart and setEnd to PassRefPtr. Removed isDetached function. Made ActionType and processContents private. Made startPosition and endPosition inlines and have then return const&. Renamed startNode and pastEndNode to firstNode and pastLastNode to reduce the chance of confusion with startContainer/endContainer. Used Position for m_start and m_end instead of separate container and offset members. Changed maxStartOffset and maxEndOffset into int to match other offsets.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Changed to use Range::create. (WebCore::ApplyStyleCommand::applyInlineStyle): Ditto.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::inputText): Ditto. (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Ditto.
- editing/Editor.cpp: (WebCore::Editor::fontForSelection): Changed for pastLastNode name change. (WebCore::Editor::setComposition): Changed to use Range::create. (WebCore::paragraphAlignedRangeForRange): Ditto. (WebCore::markMisspellingsOrBadGrammar): Changed to get rid of check for isDetached and check for 0 from startContainer instead. (WebCore::Editor::compositionRange): Changed to use Range::create.
- editing/EditorCommand.cpp: (WebCore::unionDOMRanges): Ditto.
- editing/Selection.cpp: (WebCore::Selection::toRange): Ditto.
- editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): Changed for firstNode and pastLastNode name change. (WebCore::TextIterator::range): Changed to use Range::create. (WebCore::SimplifiedBackwardsTextIterator::range): Ditto. (WebCore::TextIterator::subrange): Ditto.
- editing/VisiblePosition.cpp: (WebCore::makeRange): Ditto.
- editing/VisiblePosition.h: Added now-needed include.
- editing/htmlediting.cpp: (WebCore::indexForVisiblePosition): Changed to use Range::create. (WebCore::avoidIntersectionWithNode): Changed to get rid of check for isDetached and check for 0 instead and to use Range::create.
- editing/markup.cpp: (WebCore::renderedText): Changed to use Range::create. (WebCore::createMarkup): Changed to no longer use isDetached and also for new firstNode/pastEndNode names. (WebCore::createFragmentFromText): Ditto.
- editing/visible_units.cpp: (WebCore::previousBoundary): Changed to use Range::create.
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge convertToNSRange:]): Changed to no longer use isDetached().
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::visiblePositionForIndex): Changed to use Range::create. (WebCore::RenderTextControl::indexForVisiblePosition): Ditto.
WebKit/mac:
Reviewed by Mitz.
- update code affected by Range changes
- Misc/WebNSAttributedStringExtras.mm: (+[NSAttributedString _web_attributedStringFromRange:]): Update for name changes.
- WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]): Use Range::create.
- WebView/WebHTMLView.mm: (-[WebHTMLView attributedString]): Ditto.
- 4:32 PM Changeset in webkit [30972] by
-
- 4 edits in trunk/WebCore
2008-03-11 Daniel Zucker <zucker@wake3.com>
Reviewed by Adam Roben.
There are a handful of placed where the use of CFNetwork-specific
calls are protected by PLATFORM(CF). Revise to use the more specific
USE(CFNETWORK) macro. (See http://bugs.webkit.org/show_bug.cgi?id=17783)
- platform/network/ProtectionSpace.cpp: Change PLATFORM(CF) to USE(CFNETWORK)
- platform/network/ResourceHandle.cpp: Change PLATFORM(CF) to USE(CFNETWORK)
- platform/network/win/CookieJarWin.cpp: Correct error in InternetGetCookie call. Conditionalize 'cookiesEnabled' the same as all other implementations in this file.
- 4:06 PM Changeset in webkit [30971] by
-
- 2 edits in trunk
Fix version comparison from previous checkin
- 4:06 PM Changeset in webkit [30970] by
-
- 6 edits6 adds in trunk
2008-03-11 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
Add libsoup HTTP backend.
- GNUmakefile.am:
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/soup/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge):
- platform/network/soup/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
- platform/network/soup/ResourceHandleSoup.cpp: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::dataCallback): (WebCore::parseDataUrl): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::bufferedData): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::setDefersLoading): (WebCore::ResourceHandle::loadsBlocked): (WebCore::ResourceHandle::willLoadFromCache):
- platform/network/soup/ResourceRequest.h: Copied from WebCore/platform/network/curl/ResourceRequest.h. (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest):
- platform/network/soup/ResourceResponse.h: Added. (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::setResponseFired): (WebCore::ResourceResponse::responseFired): (WebCore::ResourceResponse::doUpdateResourceResponse):
- 3:53 PM Changeset in webkit [30969] by
-
- 4 edits in trunk
2008-03-11 Rodney Dawes <dobey@wayofthemonkey.com>
WebCore:
Fix Qt build.
- plugins/qt/PluginDataQt.cpp: (PluginData::initPlugins)
WebKit/qt:
Fix the Qt build.
- WebCoreSupport/FrameLoaderClientQt.cpp: (FrameLoaderClientQt::CreatePlugin):
- 2:43 PM Changeset in webkit [30968] by
-
- 3 edits1 delete in trunk/WebKitSite
2008-03-11 Robert Blaut <webkit@blaut.biz>
Reviewed by Darin Adler.
Fix bug http://bugs.webkit.org/show_bug.cgi?id=17280
Patch deletes an obsolete hitlist.html page and other references to it
- nav.inc: removed menu link to hitlist.html
- projects/compat/hitlist.html: Removed.
- projects/compat/index.html: removed reference to hitlist.html
- 2:28 PM Changeset in webkit [30967] by
-
- 4 edits in trunk
2008-03-11 Brent Fulgham <bfulgham@gmail.com>
WebKit/win:
Reviewed by Adam Roben.
Enabled WinLauncher as part of normal Windows build.
http://bugs.webkit.org/show_bug.cgi?id=17715.
- WebKit.vcproj/WebKit.sln: Add WinLauncher to the set of things build during a Windows build.
WebKitTools:
Reviewed by Adam Roben.
Enabled WinLauncher as part of normal Windows build.
http://bugs.webkit.org/show_bug.cgi?id=17715.
- WinLauncher/WinLauncher.vcproj: Update to use vsprops so that it can find the proper libraries to link against.
- 12:59 PM Changeset in webkit [30966] by
-
- 3 edits in trunk/WebCore
Make attribute quoting in DOM view more consistent with source view
Two changes which make the DOM view more consistent with source view:
1) We now quote all attribute values, including URLs
2) The quotes around the values are now purple, matching the left and
right angle brackets that surround the tag
One bug fixed by these changes:
1) The entire URL is selected for editing when you double-click a URL
that is an attribute value. Previously, the first and last
characters were not included in the selection.
Reviewed by Darin.
- page/inspector/DocumentPanel.js: (WebInspector.DOMNodeTreeElement._startEditingAttribute): Don't need to account for the quotes around attribute values anymore because the quotes are now outside the webkit-html-attribute-value span.
- page/inspector/utilities.js: (nodeTitleInfo): Quote all attribute values, including URLs, and place the quotes outside the webkit-html-attribute-value span.
- 12:59 PM Changeset in webkit [30965] by
-
- 5 edits in trunk/WebCore
Stop including pthread.h in WebCore on Windows
Reviewed by Darin.
- WebCore.vcproj/WebCore.vcproj:
- Changed the include path to not contain pthreads/
- Let VS remove a duplicate FileConfiguration element
- Let VS have its way with the file ordering
- WebCorePrefix.h: Made the #include of pthread.h be compiled out on Windows.
- loader/FTPDirectoryDocument.cpp: Added a Windows-specific #define of localtime_r (pthread.h was providing a macro that substituted plain old localtime before, but localtime_s is "more secure", so I went with that).
- loader/FTPDirectoryParser.cpp: Ditto for gmtime_r.
- 12:58 PM Changeset in webkit [30964] by
-
- 5 edits1 move in trunk
Roll out r30961 since it breaks the default site icon on Windows
- 12:10 PM Google Summer of Code 2008 edited by
- (diff)
- 12:08 PM Google Summer of Code 2008 edited by
- (diff)
- 12:07 PM Google Summer of Code 2008 edited by
- (diff)
- 11:52 AM Developer Tools Hitlist edited by
- (diff)
- 11:37 AM Developer Tools Hitlist edited by
- Added a high-level task for a JavaScript profiler (diff)
- 11:30 AM Changeset in webkit [30963] by
-
- 6 edits in trunk/WebCore
Reviewed by Darin Adler.
- clean up line layout code
- platform/graphics/GraphicsContext.cpp: (WebCore::TextRunIterator::increment): Removed the resolver parameter. (WebCore::GraphicsContext::drawBidiText): Adjusted for changes to createBidiRunsForLine(), which no longer takes a start parameter.
- platform/text/BidiResolver.h: (WebCore::BidiResolver::): Made Noncopyable and removed the m_adjustEmbedding member variable. (WebCore::BidiResolver::position): Added. Returns the resolver's current position. (WebCore::BidiResolver::setPosition): Added. Sets the resolver's current position without changing any other state. (WebCore::BidiResolver::increment): Added. Advances the resolver to the next position, allowing the iterator to push and pop embedding. (WebCore::BidiResolver::appendRun): Removed the resolver parameter in the call to increment(). (WebCore::BidiResolver::embed): Removed code to save, set and restore m_adjustEmbedding. (WebCore::BidiResolver::createBidiRunsForLine): Changed to not take a 'start' iterator. Instead, start at the current position. Removed code to set m_adjustEmbedding. Changed for noncopyability.
- rendering/RenderBlock.h:
- rendering/bidi.cpp: (WebCore::bidiNext): Made the resolver parameter optional. Changed to null-check the 'end of inline' pointer only twice. (WebCore::bidiFirst): Made the resolver parameter optional. (WebCore::BidiIterator::increment): Ditto. (WebCore::BidiState::increment): Added. Overrides the default BidiResolver::increment() method by passing the resolver to BidiIterator::increment(). (WebCore::checkMidpoints): Removed the resolver parameter. (WebCore::BidiState::appendRun): Removed code to save, set and restore m_adjustEmbedding. Adjusted for change to increment(). (WebCore::RenderBlock::bidiReorderLine): Removed the 'start' parameter and unreachable code. (WebCore::buildCompactRuns): Adjusted for changes to BidiResolver/ (WebCore::RenderBlock::layoutInlineChildren): Moved code to initialize the resolver from this method to determineStartPosition(). Unified the resolver with the 'start' iterator. Removed unreachable code. Moved one statement from the beginning of the while loop to the end. (WebCore::RenderBlock::determineStartPosition): Moved code to initialize the resolver from layoutInlineChildren() into this method. (WebCore::RenderBlock::matchedEndLine): Adjusted for the resolver and the 'start' iterator being one object. (WebCore::skipNonBreakingSpace): Made the parameter const. (WebCore::requiresLineBox): Ditto. (WebCore::RenderBlock::generatesLineBoxesForInlineChild): Adjusted for the change to BidiIterator::increment(). (WebCore::RenderBlock::skipWhitespace): Made two versions of this method, one for BidiIterator and one for BidiState. (WebCore::shouldSkipWhitespaceAfterStartObject): Removed the resolver parameter. (WebCore::RenderBlock::findNextLineBreak): Removed the resolver parameter. Removed calls to setAdjustEmbedding(). Removed the 'previous' variable and changed the 'last' variable to do its job.
- rendering/bidi.h:
- 11:19 AM Developer Tools Hitlist edited by
- (diff)
- 11:08 AM Google Summer of Code 2008 edited by
- (diff)
- 10:38 AM Developer Tools Hitlist edited by
- Made high-level list unordered, since they were only rough priorities … (diff)
- 10:38 AM Developer Tools Hitlist edited by
- Changed a bug number (diff)
- 10:35 AM Developer Tools Hitlist edited by
- Added bugs for the unfiled high-level tasks (diff)
- 10:24 AM Developer Tools Hitlist edited by
- Added a list of high-level improvements (some still need bugs filed) (diff)
- 10:11 AM Developer Tools Hitlist edited by
- Shuffling some priorities (diff)
- 10:02 AM Developer Tools Hitlist edited by
- (diff)
- 10:01 AM Developer Tools Hitlist edited by
- (diff)
- 9:55 AM Developer Tools Hitlist edited by
- Added a link to DeveloperToolsHitList bugs (diff)
- 9:46 AM Developer Tools Hitlist edited by
- Added the Inspector UI Refresh (diff)
- 9:43 AM Developer Tools Hitlist created by
- Initial version
- 9:06 AM WikiStart edited by
- Added a link to a new Developer Tools Hitlist page (and moved dev. … (diff)
- 8:54 AM Changeset in webkit [30962] by
-
- 3 edits in trunk/WebCore
Part of Bug 17224: DOM nodes/attributes should be editable
<http://bugs.webkit.org/show_bug.cgi?id=17224>
<rdar://problem/5732825>
This patch makes text nodes editable via double-click.
Reviewed by Tim.
- page/inspector/DocumentPanel.js:
(WebInspector.DOMNodeTreeElement._startEditing):
- Moved most of this code to _startEditingAttribute
- Calls _startEditingTextNode or _startEditingAttribute as appropriate
(WebInspector.DOMNodeTreeElement._startEditingAttribute): Added. Code
came from _startEditing.
(WebInspector.DOMNodeTreeElement._startEditingTextNode): Added.
(WebInspector.DOMNodeTreeElement._textNodeEditingCommitted): Added.
(WebInspector.DOMNodeTreeElement._editingCancelled): Renamed from
_attributeEditingCancelled.
- page/inspector/utilities.js: (nodeTitleInfo): Wrap text nodes in a webkit-html-text-node span so that we can easily recognize/edit them.
- 8:38 AM Changeset in webkit [30961] by
-
- 5 edits1 move in trunk
r25512 inlined the urlIcon to improve the startup time of Safari on Mac. Inlining is
not suitable for platforms where this icon is themable. E.g. the Qt platform is allowing
to theme this icon and the Gtk+ platform will probably end up with themable icons
as well.
Remove dead code from the windows port and move the urlIcon from the windows
directory to the Resource directory to be used by Qt and other ports.
Ifdef the usage of the built-in icon in IconDatabase.cpp and for Qt do not use
it. Gtk+ currently has no proper implementation of Image::loadPlatformResource but
once it does it wants to use this for getting the urlIcon as well.
- 7:59 AM Changeset in webkit [30960] by
-
- 3 edits2 adds in trunk/WebCore
2008-03-11 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Darin.
Implemented HTML media element support for QtWebKit, using Phonon.
- 6:50 AM Changeset in webkit [30959] by
-
- 2 edits in trunk/WebKit/qt
Fix the Qt build (silly typo).
- 5:52 AM Changeset in webkit [30958] by
-
- 2 edits in trunk/WebKit/qt
2008-03-11 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Moved obscuring progress bar to the lower right corner.
- 5:51 AM Changeset in webkit [30957] by
-
- 2 edits in trunk/WebKit/qt
2008-03-11 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Added reload action and grouped stop and reload actions together.
- 4:38 AM Changeset in webkit [30956] by
-
- 2 edits in trunk/WebKit/qt
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- Set a Icon on the QAction if we have one.
- 1:17 AM Changeset in webkit [30955] by
-
- 2 edits in trunk/WebKit/qt
Fix the Qt build.
- 12:20 AM Changeset in webkit [30954] by
-
- 10 edits in trunk
WebCore:
Reviewed by Beth Dakin.
Throw a SECURITY_ERR when accessing a tainted canvas
by CanvasRenderingContext2D::getImageData() and
HTMLCanvasElement::toDataURL().
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData):
- html/CanvasRenderingContext2D.h:
- html/CanvasRenderingContext2D.idl:
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::toDataURL):
- html/HTMLCanvasElement.h:
- html/HTMLCanvasElement.idl:
LayoutTests:
Reviewed by Beth Dakin.
Update test to catch the SECURITY_ERR thrown by
CanvasRenderingContext2D::getImageData() and
HTMLCanvasElement::toDataURL() on a tainted canvas
- http/tests/security/canvas-remote-read-remote-image-expected.txt:
- http/tests/security/canvas-remote-read-remote-image.html:
Mar 10, 2008:
- 11:28 PM Changeset in webkit [30953] by
-
- 2 edits in trunk/JavaScriptCore
- Windows build fix
- kjs/function.cpp: (KJS::decode): Initialize variable.
- 9:42 PM Changeset in webkit [30952] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Sam.
<rdar://problem/5779984> REGRESSION (r30391): GMail: Safari won't display the Edit Link dialog
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::hasCSSPropertyNamePrefix): Fixed a typo. The code was only comparing the first character of the prefix to the first character of the property name.
LayoutTests:
Reviewed by Sam.
<rdar://problem/5779984> REGRESSION (r30391): GMail: Safari won't display the Edit Link dialog
- editing/pasteboard/5780697-2-expected.txt: Added.
- editing/pasteboard/5780697-2.html: Added.
- editing/selection/5779984-1-expected.txt: Added.
- editing/selection/5779984-1.html: Added.
- 8:40 PM Changeset in webkit [30951] by
-
- 2 edits in trunk/WebCore
Reviewed by Beth.
Hold off on initializing the frame to avoid the RenderView getting
a null FrameView. This could potentially cause problems.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 5:48 PM Changeset in webkit [30950] by
-
- 2 edits in trunk/WebCore
- try to fix Qt build
- bridge/qt/qt_runtime.cpp: (KJS::Bindings::convertQVariantToValue): Change KJS::UChar to UChar.
- 5:45 PM Changeset in webkit [30949] by
-
- 15 edits in trunk/WebCore
Reviewed by Antti.
- fix <rdar://problem/3059610> VIP: links opened in new frame, window, or tab should be redrawn as visited immediately
- fix <rdar://problem/4382809> Going "back" a page doesn't change the color of the visited URL at directory.umi
- fix http://bugs.webkit.org/show_bug.cgi?id=4941 Visited links should be marked as visited
- fix http://bugs.webkit.org/show_bug.cgi?id=7960 REGRESSION: Visited link color doesn't displayed after loading page from cache
We now mark all links on a page as "changed" at the appropriate times.
- WebCore.base.exp: Update since I made completeURL be a const member function.
- css/CSSStyleSelector.cpp: Got rid of some unneeded globals that could be turned into locals. Also changed some static data members to file-scoped globals with internal linkage. Renamed the globals to get rid of the m_ prefix. Changed the prefix on m_styleNotYetAvailable to s_styleNotYetAvailable. (WebCore::CSSStyleSelector::CSSStyleSelector): Updated for name changes. (WebCore::parseUASheet): Tweak the comment. (WebCore::CSSStyleSelector::loadDefaultStyle): Updated for name changes and to use local variables instead of globals where possible. (WebCore::CSSStyleSelector::checkPseudoState): Made this a member function so it can store the link in a hash. Also changed it to have a return value instead of having it modify a global variable. Added code to put the hash into a set so we can tell later if this is one of the links that affects this page. (WebCore::CSSStyleSelector::canShareStyleWithElement): Updated for the change to checkPseudoState. (WebCore::CSSStyleSelector::matchUARules): Updated for name changes. (WebCore::CSSStyleSelector::styleForElement): Ditto. (WebCore::CSSStyleSelector::adjustRenderStyle): Ditto. (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Changed code to read the SVG style sheet to use a boolean global and put it right here in the function since this is the only code that needs to know about it. (WebCore::CSSStyleSelector::checkOneSelector): Updated for name changes. (WebCore::colorForCSSValue): Moved code inside the function that is not needed anywhere else. (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Updaed for the change to checkPseudoState. (WebCore::CSSStyleSelector::allVisitedStateChanged): Added. Calls setChanged on all links if there were any in the set. (WebCore::CSSStyleSelector::visitedStateChanged): Added. Calls setChanged on all links if the one that changed is in the set.
- css/CSSStyleSelector.h: Removed unused StyleSelector class and State enum. Made CSSStyleSelector derive from Noncopyable. Made lots of member functions private that didn't need to be public, and removed others that could be made into non-member functions. Changed pseudoStyleRulesForElement to take a const String& instead of a StringImpl*. Added new allVisitedStateChanged and visitedStateChanged functions. Got rid of unneeded friend declarations.
- dom/Document.cpp: (WebCore::Document::completeURL): Made const. (WebCore::findSlashDotDotSlash): Moved here from PageGroup. (WebCore::findSlashSlash): Ditto. (WebCore::findSlashDotSlash): Ditto. (WebCore::containsColonSlashSlash): (WebCore::cleanPath): Ditto. (WebCore::matchLetter): Ditto. (WebCore::needsTrailingSlash): Ditto. (WebCore::Document::visitedLinkHash): Moved this here from PageGroup. This is the poor-man's completeURL function. The idea of putting it here is that this way it can be alongside the real completeURL function. Later we should figure out a way to make this function share more code with the real thing and match behavior.
- dom/Document.h: Marked completeURL function const. Added visitedLinkHash function.
- page/DOMWindow.cpp: (WebCore::DOMWindow::getMatchedCSSRules): Updated for change to CSSStyleSelector.
- page/Page.cpp: (WebCore::Page::allVisitedStateChanged): Added. Calls allVisitedStateChanged on all style selectors. (WebCore::Page::visitedStateChanged): Ditto.
- page/Page.h: Added the above functions.
- page/PageGroup.cpp: (WebCore::PageGroup::isLinkVisited): Changed to take a visitedLinkHash parameter. The CSSStyleSelector now handles actually computing the hash, and it does so by calling code in Document. (WebCore::PageGroup::addVisitedLink): Refactored so the two overloaded copies share a bit more code. Added code that calls visitedStateChanged if a new link was added. (WebCore::PageGroup::removeVisitedLinks): Added code to call allVisitedStateChanged if any visited links are removed.
- page/PageGroup.h: Include StringHash.h instead of having the AlreadyHashed struct definition here.
- platform/text/StringHash.h: (WebCore::CaseFoldingHash::hash): Tweaked to make this a bit more consistent with the StringImpl::computeHash function, using the same technique for avoiding 0. (WebCore::AlreadyHashed::hash): Added. Was formerly in PageGroup.h. (WebCore::AlreadyHashed::avoidDeletedValue): Added. Was formerly in PageGroup.cpp.
- rendering/RenderStyle.cpp: (WebCore::RenderStyle::isStyleAvailable): Changed to use an inline function instead of getting directly at a data member so the data member could be made private.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::scrollToAnchor): Added call to updateHistoryForAnchorScroll. (WebCore::FrameLoader::updateHistoryForAnchorScroll): Added.
- loader/FrameLoader.h: Added updateHistoryForAnchorScroll.
- 5:36 PM Changeset in webkit [30948] by
-
- 2 edits in trunk/WebKit/win
No review, build fix only.
Speculative fix for Windows build, use ::UChar instead of KJS::UChar
- WebScriptCallFrame.cpp: (WebScriptCallFrame::valueForVariable): (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
- 5:14 PM Changeset in webkit [30947] by
-
- 4 edits in trunk/WebCore
Part of Bug 17224: DOM nodes/attributes should be editable
<http://bugs.webkit.org/show_bug.cgi?id=17224>
<rdar://problem/5732825>
This patch makes DOM attributes editable via double-click.
Reviewed by Tim.
- page/inspector/DocumentPanel.js: (WebInspector.DOMNodeTreeElement.onmousedown): Don't do anything if we're being edited, since we want default editing behaviors to work. (WebInspector.DOMNodeTreeElement.ondblclick): Try to start editing before doing anything else. (WebInspector.DOMNodeTreeElement._startEditing): Added. Currently only lets you edit attributes. (WebInspector.DOMNodeTreeElement._attributeEditingCommitted): Added. Uses a scratch element to get the new attribute(s) parsed, then sets the attribute(s) on the node in the inspected document. (WebInspector.DOMNodeTreeElement._attributeEditingCancelled): Added. (WebInspector.DOMNodeTreeElement._updateTitle): Added. Refreshes the representation of the node in the Inspector's DOM tree to reflect the node's current state.
- page/inspector/inspector.css: Made the .editing class apply everywhere.
- page/inspector/utilities.js: (nodeTitleInfo): Changed to surround attribute name/value pairs in a webkit-html-attribute span so that we can easily edit the pair as a whole.
- 4:39 PM Changeset in webkit [30946] by
-
- 2 edits in trunk/JavaScriptCore
2008-03-10 Brent Fulgham <bfulgham@gmail.com>
Windows build fix
Reviewed by Adam.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Set the PATH to include Cygwin before running touch.
- 4:02 PM Changeset in webkit [30945] by
-
- 2 edits in trunk/WebCore
Fix 64-bit builds.
Reviewed by Stephanie.
WebCore.exp only gets generated once for both 32-bit and 64-bit builds,
so we must exclude the _NPN symbols when creating WebCore.LP64.exp.
- WebCore.xcodeproj/project.pbxproj: Reverted build phase shell code to r30826 to remove _NPN symbols from 64-bit builds in WebCore.LP64.exp.
- 3:57 PM Changeset in webkit [30944] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by NOBODY.
Build fix for JSC on windows.
- API/JSStringRefCF.cpp: (JSStringCreateWithCFString):
- kjs/function.cpp: (KJS::decode):
- kjs/nodes2string.cpp: (KJS::escapeStringForPrettyPrinting):
- 3:44 PM Changeset in webkit [30943] by
-
- 2 edits in trunk/JavaScriptCore
No review, build fix only.
Attempt to fix the windows build?
- kjs/ustring.h: change unsigned short to UChar
- 3:06 PM Changeset in webkit [30942] by
-
- 28 edits in trunk
Reviewed by Darin.
Remove KJS::UChar, use ::UChar instead
http://bugs.webkit.org/show_bug.cgi?id=17017
To functional changes, thus no tests.
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::hasCSSPropertyNamePrefix): (WebCore::cssPropertyName):
- bindings/js/JSDOMWindowBase.cpp: (WebCore::windowProtoFuncAToB): (WebCore::windowProtoFuncBToA):
- bindings/js/JSSVGPODTypeWrapper.h:
- bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
- bridge/objc/objc_utility.mm: (KJS::Bindings::throwError):
- dom/Document.cpp: (WebCore::Document::parseQualifiedName):
- platform/text/AtomicString.cpp: (WebCore::AtomicString::add):
- platform/text/String.cpp: (WebCore::String::String): (WebCore::String::operator Identifier): (WebCore::String::operator UString):
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::decode):
- svg/SVGAnimatedTemplate.h:
- 11:58 AM Changeset in webkit [30941] by
-
- 3 edits in trunk/WebKit/win
Fix build break caused by r30920.
Serialize remaining dependent builds by adding dependencies.
Visual Studio per-vcproj parallelization doesn't add a lot of value
since so many of our builds are dependent - this just enforces that.
We do our parallelization via pdevenv, which works much better.
- WebKit.vcproj/WebKit.sln:
- WebKit.vcproj/WebKit.submit.sln:
- 11:25 AM Changeset in webkit [30940] by
-
- 2 edits in trunk/WebKit/gtk
2008-03-10 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
Fix "missing braces" compiler warning.
- webkit/webkitwebview.cpp:
- 10:37 AM Changeset in webkit [30939] by
-
- 12 edits in trunk
WebCore:
Reviewed by Sam.
- eliminate keyboard UI mode method from WebCoreFrameBridge
- page/ChromeClient.h: Added keyboardUIMode function. (WebCore::ChromeClient::keyboardUIMode): Ditto.
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToAllControls): Call chrome client function instead of bridge function.
- page/mac/WebCoreFrameBridge.h: Removed keyboardUIMode method, and other unused ones.
- WebCore.xcodeproj/project.pbxproj: Allowed Xcode to change the project. Do not try to fight the Xcode.
WebKit/mac:
Reviewed by Sam.
- eliminate keyboard UI mode method from WebCoreFrameBridge
- WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function.
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::keyboardUIMode): Ditto. Calls WebView.
- WebCoreSupport/WebFrameBridge.h: Removed unused things, including the fields for keyboard UI mode.
- WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini method. (-[WebFrameBridge finalize]): Ditto.
- WebView/WebView.mm: Moved the keyboard mode code in here. (-[WebView _close]): Remove observer from the distributed notification center as well as the normal one. (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved here from the bridge. (-[WebView _keyboardUIMode]): Ditto.
- WebView/WebViewInternal.h: Added _keyboardUIMode method.
- 10:36 AM Changeset in webkit [30938] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Beth Dakin.
Add Tiger specific results for toDataURL-supportedTypes.html as the image
encoders have slightly changed between releases.
- platform/mac-tiger/fast/canvas: Added.
- platform/mac-tiger/fast/canvas/toDataURL-supportedTypes-expected.txt: Added.
- 10:29 AM Changeset in webkit [30937] by
-
- 2 edits in trunk/WebCore
- oops, forgot to save last couple changes from the editor
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::markDOMObjectWrapper): Tweaked a tiny bit. (WebCore::JSDOMWindow::mark): Sorted alphabetically.
- 10:26 AM Changeset in webkit [30936] by
-
- 4 edits in trunk/WebCore
Reviewed by Geoff.
- fix failing regression test (window.navigator is getting garbage collected and thus losing its custom properties)
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::markDOMObject): Added helper function. (WebCore::JSDOMWindow::mark): Added. Marks the wrappers for all the objects that hang off the window object.
- page/DOMWindow.h: (WebCore::DOMWindow::optionalScreen): Added so we can get the Screen object without creating it if it's already there. (WebCore::DOMWindow::optionalSelection): Ditto. (WebCore::DOMWindow::optionalHistory): Ditto. (WebCore::DOMWindow::optionalLocationbar): Ditto. (WebCore::DOMWindow::optionalMenubar): Ditto. (WebCore::DOMWindow::optionalPersonalbar): Ditto. (WebCore::DOMWindow::optionalScrollbars): Ditto. (WebCore::DOMWindow::optionalStatusbar): Ditto. (WebCore::DOMWindow::optionalToolbar): Ditto. (WebCore::DOMWindow::optionalConsole): Ditto. (WebCore::DOMWindow::optionalNavigator): Ditto.
- page/DOMWindow.idl: Added the CustomMarkFunction flag. Sorted the flags in alphabetical order since there are a lot of them.
- 10:01 AM Changeset in webkit [30935] by
-
- 9 edits in trunk
WebCore:
Reviewed by Sam.
- eliminate Java applet methods from WebCoreFrameBridge
- loader/FrameLoaderClient.h: Added a javaApplet function.
- page/mac/FrameMac.mm: (WebCore::Frame::createScriptInstanceForWidget): Streamlined the code. Use the loader client instead of the bridge to get the applet.
- page/mac/WebCoreFrameBridge.h: Removed the getAppletInView and pollForAppletInView methods. Also removed other unused things.
WebKit/mac:
Reviewed by Sam.
- eliminate Java applet methods from WebCoreFrameBridge
- WebCoreSupport/WebChromeClient.mm: Removed unneeded headers and declarations.
- WebCoreSupport/WebFrameBridge.mm: Ditto. Also removed unneeded methods, including the ones that load Java applets.
- WebCoreSupport/WebFrameLoaderClient.h: Added javaApplet function.
- WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
- 9:33 AM Changeset in webkit [30934] by
-
- 2 edits in trunk/WebKitTools
Reviewed and landed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=17581
Bug 17581: Use of uninitialized value in string ne at WebKitTools/Scripts/run-webkit-tests line 1576.
Remove the previous warning which occurs when the --random option is used.
- Scripts/run-webkit-tests: verify that $component[0] is defined before checking for its inequality
- 9:28 AM Changeset in webkit [30933] by
-
- 4 edits1 add in trunk/WebCore
Reviewed by Eric, landed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16095
Move GraphicsContextPrivate to its own header file.
Moves GraphicsContextState and GraphicsContextPrivate to its
own header
- WebCore.vcproj/WebCore.vcproj:
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/GraphicsContextPrivate.h: Added. (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
- 9:25 AM Changeset in webkit [30932] by
-
- 8 edits in trunk
WebCore:
Reviewed and landed by Darin.
bug 12182 : XMLHttpRequest should raise SECURITY_ERR for same-origin policy violations
Removed reference to PERMISSION_DENIED (previous non standard exception) and replaced it
by DOM exception SECURITY_ERR. Updated XMLHttpRequest::open to raise SECURITY_ERR.
- bindings/js/kjs_binding.cpp: (WebCore::setDOMException): Removed PERMISSION_DENIED code.
- dom/ExceptionCode.cpp: Added SECURITY_ERR exception.
- dom/ExceptionCode.h: Ditto.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open): Returns SECURITY_ERR now.
- xml/XMLHttpRequestException.h: Removed PERMISSION_DENIED.
LayoutTests:
Reviewed and landed by Darin.
bug 12182 : XMLHttpRequest should raise SECURITY_ERR for same-origin policy violations
- http/tests/xmlhttprequest/exceptions-expected.txt: Updated results
- 9:17 AM Changeset in webkit [30931] by
-
- 3 edits in trunk/WebCore
Refactor CSS editing code so we can share it with DOM editing
Add WebInspector.startEditing, which takes the element to be edited, a
committedCallback, a cancelledCallback, and a context parameter. This
function takes care of setting up the element for editing, and calls
either the cancelledCallback or committedCallback when editing ends.
Reviewed by Tim.
- page/inspector/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.startEditing):
- Call WebInspector.isBeingEdited and WebInspector.startEditing
- Removed code now handled by WebInspector.startEditing
(WebInspector.StylePropertyTreeElement.editingEnded):
- Renamed from endEditing
- Removed code now handled by WebInspector.startEditing
(WebInspector.StylePropertyTreeElement.editingCancelled):
- Renamed from cancelEditing
- Changed parameters to match WebInspector.startEditing's cancelledCallback
(WebInspector.StylePropertyTreeElement.editingCommitted):
- Renamed from commitEditing
- Changed parameters to match WebInspector.startEditing's committedCallback
- page/inspector/inspector.js: (WebInspector.changeFocus): Changed a call to firstParentWithClassName to firstParentOrSelfWithClassName so that if the focusable element itself is the target it will be recognized. I don't know why this change wasn't needed before this. (WebInspector.isBeingEdited): Added. (WebInspector.startEditing): Added.
- 9:17 AM Changeset in webkit [30930] by
-
- 2 edits in trunk/WebCore
Windows build fix
- WebCore.vcproj/WebCore.vcproj: Pick up generated source files out of $(WebKitOutputDir) instead of hard-coding WebKitBuild.
- 9:15 AM Changeset in webkit [30929] by
-
- 2 edits in trunk/WebCore
- DerivedSources.make: Merge plug-in-related changes with the new way of handling autogenerated DOM classes.
- 8:38 AM Changeset in webkit [30928] by
-
- 5 edits3 adds in trunk
Reviewed, tweaked and landed by Alexey.
We didn't have a fallback to frame encoding in the case of loading a script via
changing its src attribute.
Test: fast/dom/HTMLScriptElement/script-decoding-error-after-setting-src.html
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute): Use a helper function to get proper charset for correct decoding of script content. (WebCore::HTMLScriptElement::insertedIntoDocument): (WebCore::HTMLScriptElement::scriptCharset): A helper function for getting proper charset for the script (as much as can be determined prior to loading it).
- html/HTMLScriptElement.h:
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Use a helper function to get proper charset for correct decoding of script content.
- 6:59 AM Changeset in webkit [30927] by
-
- 7 edits in trunk/WebCore
2008-03-10 Simon Hausmann <Simon Hausmann>
Reviewed by Lars.
Fix reference counting of returned MimeType and Plugin objects
created in the array wrappers.
- 5:29 AM Changeset in webkit [30926] by
-
- 2 edits in trunk/WebCore
Wx linking fix.
Added missing stubs for PluginData.
- 5:20 AM Changeset in webkit [30925] by
-
- 2 edits in trunk/WebCore
Windows build fix that I forgot to merge earlier ;(
Forward declare Page as class, not struct.
- 5:09 AM Changeset in webkit [30924] by
-
- 2 edits in trunk/WebCore
Attempt to fix the Wx build.
- 4:52 AM Changeset in webkit [30923] by
-
- 45 edits30 adds9 deletes in trunk
2008-03-07 Simon Hausmann <Simon Hausmann>
Reviewed by Darin.
Done with Lars.
WebCore:
Ported the manually written JS bindings of window.navigator,
window.navigator.plugins and window.navigator.mimeTypes to
auto-generated bindings.
Moved the globally cached plugin and mimetype information to a
per WebCore::Page shared PluginData structure.
Implemented window.navigator.plugins.refresh() in a
platform-independent way.
LayoutTests:
Added a testcase for http://bugs.webkit.org/show_bug.cgi?id=16815
WebKit/qt:
Replaced the QWebObjectPlugin interfaces with QWebPluginFactory.
WebKit/mac:
Simplified WebViewFactory's refreshPlugins method to only refresh the
plugins and not reload the frames anymore since that's now done in a
platform independent manner by WebCore::Page.
Also removed the now unused pluginNameForMIMEType and
pluginSupportsMIMEType methods.
WebKitTools/DumpRenderTree/qt:
Ported the netscape test plugin to QWebPluginFactory.
- 4:29 AM Changeset in webkit [30922] by
-
- 2 edits in trunk/WebCore
2008-03-10 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Replace two printfs() in the Qt port with notImplemented().
- 4:23 AM Changeset in webkit [30921] by
-
- 3 edits in trunk/WebCore
2008-03-10 Simon Hausmann <Simon Hausmann>
Reviewed by Alp.
Compilation fix with gcc 4.3: Include stdio.h for printf.
Mar 8, 2008:
- 10:35 PM Changeset in webkit [30920] by
-
- 18 edits in trunk
Stop Windows build if an error occurs in a prior project.
Rubber stamped by Darin.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
WebCore:
Stop Windows build if an error occurs in a prior project.
Rubber stamped by Darin.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/WebCoreGenerated.vcproj:
WebKit/win:
Stop Windows build if an error occurs in a prior project.
Rubber stamped by Darin.
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/InterfacesGenerated.vcproj:
- WebKit.vcproj/WebKit.vcproj:
- WebKit.vcproj/WebKitGUID.vcproj:
WebKitTools:
Stop Windows build if an error occurs in a prior project.
Rubber stamped by Darin.
- Drosera/win/Drosera.vcproj/Drosera.vcproj:
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/ImageDiff.vcproj:
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
- 8:10 PM Changeset in webkit [30919] by
-
- 3 edits in trunk/WebCore
- DerivedSources.make: Third try at fixing the build.
- bindings/js/JSRGBColor.cpp: And touching this file.
- 8:03 PM Changeset in webkit [30918] by
-
- 2 edits in trunk/WebCore
- DerivedSources.make: One *more* try at fixing the build.
- 7:58 PM Changeset in webkit [30917] by
-
- 2 edits in trunk/WebCore
- DerivedSources.make: One more try at fixing the build.
- 7:53 PM Changeset in webkit [30916] by
-
- 2 edits in trunk/WebCore
- DerivedSources.make: Re-land the change, fixed, and with an attempt to fix the bots by removing the incorrect file.
- 7:44 PM Changeset in webkit [30915] by
-
- 2 edits in trunk
2008-03-09 Alp Toker <alp@atoker.com>
GTK+ build fix for r30913.
Use UNICODE_CFLAGS for C++ sources as well as C sources.
- GNUmakefile.am:
- 5:49 PM Changeset in webkit [30914] by
-
- 2 edits in trunk/WebCore
Roll out r30909 -- it breaks the build and is a non-trivial fix (according to weinig)
RS=Mark Rowe
- 5:49 PM Changeset in webkit [30913] by
-
- 5 edits in trunk
2008-03-09 J?rg Billeter <j@bitron.ch>
Reviewed by Alp Toker.
Conditionalise ICU for Unicode in the GTK+ port.
- 4:01 PM Changeset in webkit [30912] by
-
- 3 edits in trunk/WebKit/win
Make WebInspectorClient use WindowMessageBroadcaster instead of manual subclassing
Reviewed by Darin.
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::WebInspectorClient): Removed m_orignalWebViewWndProc member. (WebInspectorClient::attachWindow): Register as a listener with WindowMessageBroadcaster instead of subclassing. (WebInspectorClient::detachWindow): Deregister as a listener with WindowMessageBroadcaster instead of unsubclassing. (WebInspectorClient::windowReceivedMessage): Renamed from SubclassedWebViewWndProc. Also added a missing break statement after the call to onWebViewWindowPosChanging.
- WebCoreSupport/WebInspectorClient.h:
- 4:01 PM Changeset in webkit [30911] by
-
- 3 edits in trunk/WebKit/win
Make the node highlight not obscure the tab bar when it first appears
Reviewed by Darin.
- WebNodeHighlight.cpp: (WebNodeHighlight::onWebViewWindowPosChanged): Added. Listens for changes to the WebView's size and resizes the highlight window to match. (WebNodeHighlight::onRootWindowPosChanged): Added. Listens for changes to the WebView's root window's position and moves the highlight window to match. (WebNodeHighlight::windowReceivedMessage): Call onWebViewWindowPosChanged/onRootWindowPosChanged as appropriate.
- WebNodeHighlight.h:
- 4:00 PM Changeset in webkit [30910] by
-
- 3 edits in trunk/WebKit/win
Fix Bug 14254: Inspector node highlight applied to all tabs
<http://bugs.webkit.org/show_bug.cgi?id=14254>
<rdar://problem/5322306>
WebNodeHighlight now listens for the WM_SHOWWINDOW message being sent
to the inspected WebView so that it can hide/show itself as the
WebView is hidden/shown.
Reviewed by Anders.
- WebNodeHighlight.cpp: (WebNodeHighlight::~WebNodeHighlight): Remove ourselves as a listener for our inspected WebView's window's messages. (WebNodeHighlight::show): Add ourselves as a listener for our inspected WebView's window's messages. (WebNodeHighlight::onWebViewShowWindow): Added. Hide ourselves when the WebView hides, show ourselves when the WebView is shown. (WebNodeHighlight::windowReceivedMessage): Added a separate switch statement to handle the inspected WebView's window's messages.
- WebNodeHighlight.h:
- 1:36 PM Changeset in webkit [30909] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam.
- DerivedSources.make: Put the list of DOM classes into its own variable, and generate the JavaScript bindings and Objective-C bindings dependencies from that. Added some separators to make it a little easier to see the sections of the file. Moved all the Mac-specific rules (except for the SVG conditional part) down to the bottom of the file in a separate section.
- 11:06 AM ProposedWebInspectorUIRefresh edited by
- Added a section about the Scripts view with a new mockup from Tim (diff)
- 10:47 AM Changeset in webkit [30908] by
-
- 2 edits in trunk/WebCore
Windows build fix
- WebCore.vcproj/WebCore.vcproj: Make sure all Cairo files are excluded from all three CG-based configurations: Debug, Release, and Debug_Internal.
Mar 8, 2008:
- 11:59 PM Changeset in webkit [30907] by
-
- 1 edit in trunk/JavaScriptCore/wtf/OwnPtrWin.cpp
Fix stray executable bit.
- 11:00 PM Changeset in webkit [30906] by
-
- 2 edits in trunk/WebCore
Attempt to fix the Qt build.
- 10:48 PM Changeset in webkit [30905] by
-
- 5 edits in trunk
Bug 16516: canvas image patterns stop working with some transformations
Reviewed by Sam W.
Simple fix. We used x/yStep of FLT_MAX to fake a no-repeat-x/y pattern
with CG. However any transforms involving FLT_MAX immediately get
consumed by the introduced floating point error. yStep had already been
clamped to a much smaller arbitrary value, and this patch makes us use
that clamp value for xStep as well.
- 6:39 PM Changeset in webkit [30904] by
-
- 3 edits3 adds in trunk
Bug 17728: Canvas.createPattern with null repeat argument throws an exception
Reviewed by Mitz
Trivial fix, we were calling toString on null which produces the string "null",
we just needed to switch to using valueToStringWithNullCheck rather than
JSValue::toString directly
Test: fast/canvas/canvas-pattern-behaviour.html
- 5:57 PM Changeset in webkit [30903] by
-
- 2 edits in trunk/WebKitTools
2008-03-08 Julien Chaffraix <julien.chaffraix@gmail.com>
Reviewed by Mark Rowe.
DRT build fix for Tiger.
- DumpRenderTree/mac/DumpRenderTreeMac.h: Define BUILDING_ON_TIGER.
- 5:57 PM Changeset in webkit [30902] by
-
- 11 edits in trunk
2008-03-08 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
Fix 64-bit build with GCC 4.2.
- bindings/objc/WebScriptObject.mm: Use NSUInteger in place of unsigned where required.
- platform/mac/SharedBufferMac.mm: Ditto.
2008-03-08 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
Fix 64-bit build with GCC 4.2.
- DefaultDelegates/WebDefaultScriptDebugDelegate.m: Use NSUInteger in place of unsigned where required.
- DefaultDelegates/WebDefaultUIDelegate.m: Ditto.
- History/WebHistoryItem.mm: Ditto.
- Misc/WebElementDictionary.mm: Ditto.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::objectContentType): Move variable declaration outside of if to avoid warning about the variable being unused in 64-bit.
- WebCoreSupport/WebInspectorClient.mm: Use NSUInteger in place of unsigned where required.
- WebView/WebHTMLView.mm: (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Use CGFloat in place of float where required. (-[WebTextCompleteController numberOfRowsInTableView:]): Use NSInteger in place of int where required.
- 3:10 PM Changeset in webkit [30901] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
- fix garbage in transparent areas in canvas.toDataURL results
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::toDataURL): Clear the bitmap context before painting the canvas image onto it.
- 6:09 AM Changeset in webkit [30900] by
-
- 13 edits in trunk
WebCore:
Reviewed by Adele.
- eliminate custom highlight methods from WebCoreFrameBridge
- page/Chrome.cpp: (WebCore::ChromeClient::customHighlightRect): Added. (WebCore::ChromeClient::paintCustomHighlight): Added.
- page/ChromeClient.h: Added custom highlight functions.
- page/Frame.h: Removed custom highlight functions.
- page/mac/FrameMac.mm: Ditto.
- page/mac/WebCoreFrameBridge.h: Removed custom highlight methods.
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintCustomHighlight): Changed code to use the ChromeClient instead of WebCoreFrameBridge to do the custom highlight.
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight): Ditto.
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow): Ditto. (WebCore::RootInlineBox::paintCustomHighlight): Ditto.
WebKit/mac:
Reviewed by Adele.
- eliminate custom highlight methods from WebCoreFrameBridge
- WebCoreSupport/WebChromeClient.h: Added custom highlight functions.
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::customHighlightRect): Moved code here from bridge. (WebChromeClient::paintCustomHighlight): Ditto.
- WebCoreSupport/WebFrameBridge.mm: Removed code here.
- 6:05 AM Changeset in webkit [30899] by
-
- 2 edits in trunk/LayoutTests
- platform/win/Skipped: Fixed some typos (stray "s" characters).
- 12:09 AM Changeset in webkit [30898] by
-
- 4 edits in trunk
2008-03-07 Stephanie Lewis <Stephanie Lewis>
Reviewed by Oliver.
Fix Windows build.
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::toDataURL):
Mar 7, 2008:
- 11:54 PM Changeset in webkit [30897] by
-
- 55 edits1 add in trunk
Unify concept of enabling Netscape Plug-in API (NPAPI).
Reviewed by Darin.
- wtf/Platform.h: Define ENABLE_NETSCAPE_PLUGIN_API here.
WebCore:
Unify concept of enabling Netscape Plug-in API (NPAPI).
Reviewed by Darin.
No test cases since there is no change in functionality.
- DerivedSources.make: Added check for ENABLE_NETSCAPE_PLUGIN_API macro. If defined as "1", add WebCore.NPAPI.exp to WEBCORE_EXPORT_DEPENDENCIES.
- WebCore.NPAPI.exp: Added.
- WebCore.base.exp: Moved exported NPAPI methods to WebCore.NPAPI.exp.
- WebCore.xcodeproj/project.pbxproj: Removed changes in r30826 (except comments) since we now handle exported NPAPI methods via DerivedSources.make.
- config.h: Removed USE(NPOBJECT) since we now use ENABLE(NETSCAPE_PLUGIN_API) as defined in Platform.h.
- bindings/objc/DOM.mm: Replaced USE(NPOBJECT) with ENABLE(NETSCAPE_PLUGIN_API). (-[DOMElement _NPObject]):
bridge/NP_jsobject.cpp: Replaced !PLATFORM(DARWIN) !defined(LP64) with ENABLE(NETSCAPE_PLUGIN_API).
- bridge/NP_jsobject.h: Ditto.
- bridge/c/c_class.cpp: Ditto.
- bridge/c/c_class.h: Ditto.
- bridge/c/c_instance.cpp: Ditto.
- bridge/c/c_instance.h: Ditto.
- bridge/c/c_runtime.cpp: Ditto.
- bridge/c/c_runtime.h: Ditto.
- bridge/c/c_utility.cpp: Ditto.
- bridge/c/c_utility.h: Ditto.
- bridge/npruntime.cpp: Ditto.
- bridge/npruntime_impl.h: Ditto.
- bridge/npruntime_priv.h: Ditto.
- bridge/runtime.cpp: Ditto. (KJS::Bindings::Instance::createBindingForLanguageInstance):
- html/HTMLPlugInElement.cpp: Replaced USE(NPOBJECT) with ENABLE(NETSCAPE_PLUGIN_API). (WebCore::HTMLPlugInElement::HTMLPlugInElement): (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
- html/HTMLPlugInElement.h: Ditto.
- page/Frame.cpp: Replaced USE(NPOBJECT) with ENABLE(NETSCAPE_PLUGIN_API). (WebCore::Frame::clearScriptObjects): (WebCore::FramePrivate::FramePrivate): Also added #if ENABLE(NETSCAPE_PLUGIN_API) guard around m_windowScriptNPObject.
- page/Frame.h: Replaced USE(NPOBJECT) with ENABLE(NETSCAPE_PLUGIN_API).
- page/FramePrivate.h: Added #if ENABLE(NETSCAPE_PLUGIN_API) guard around m_windowScriptNPObject.
- page/mac/FrameMac.mm: Replaced USE(NPOBJECT) with ENABLE(NETSCAPE_PLUGIN_API). (WebCore::Frame::createScriptInstanceForWidget):
WebKit/mac:
Unify concept of enabling Netscape Plug-in API (NPAPI).
Reviewed by Darin.
- WebKit.exp: Removed unused class export for WebBaseNetscapePluginView.
- WebKitPrefix.h: Removed WTF_USE_NPOBJECT since we now use ENABLE(NETSCAPE_PLUGIN_API) as defined in Platform.h.
- Plugins/WebBaseNetscapePluginStream.h: Replaced #ifndef LP64 with #if ENABLE(NETSCAPE_PLUGIN_API).
- Plugins/WebBaseNetscapePluginStream.mm: Ditto.
- Plugins/WebBaseNetscapePluginView.h: Ditto.
- Plugins/WebBaseNetscapePluginView.mm: Ditto.
- Plugins/WebBaseNetscapePluginViewInternal.h: Ditto.
- Plugins/WebBaseNetscapePluginViewPrivate.h: Ditto.
- Plugins/WebBasePluginPackage.h: Ditto.
- Plugins/WebBasePluginPackage.m: Ditto. (+[WebBasePluginPackage pluginWithPath:]):
- Plugins/WebNetscapeDeprecatedFunctions.c: Ditto.
- Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
- Plugins/WebNetscapePluginEmbeddedView.h: Ditto.
- Plugins/WebNetscapePluginEmbeddedView.mm: Ditto.
- Plugins/WebNetscapePluginPackage.h: Ditto.
- Plugins/WebNetscapePluginPackage.m: Ditto.
- Plugins/WebNetscapePluginStream.h: Ditto.
- Plugins/WebNetscapePluginStream.mm: Ditto.
- Plugins/WebPluginDatabase.m: Ditto. (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
- Plugins/npapi.m: Ditto.
- WebCoreSupport/WebFrameLoaderClient.mm: Ditto. (WebFrameLoaderClient::objectContentType): (WebFrameLoaderClient::createPlugin):
- WebView/WebHTMLView.mm: Ditto. (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
- WebView/WebHTMLViewInternal.h: Ditto.
- WebView/WebFrame.mm: Replaced #ifndef LP64 with #if ENABLE(NETSCAPE_PLUGIN_API). Moved methods below from (WebPrivate) category to (WebInternal) category so we don't expose the ENABLE() macro from the private header. (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
- WebView/WebFrameInternal.h: Ditto.
- WebView/WebFramePrivate.h: Ditto.
- 11:46 PM Changeset in webkit [30896] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin.
<rdar://problem/5579292> REGRESSION: (safari 2-3): "Default default" encoding for Korean
changed from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites
- WebView/WebPreferences.m: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Make encoding name match the one used in Safari.
- 11:25 PM Changeset in webkit [30895] by
-
- 6 edits in trunk
2008-03-07 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Fix WebKit build with GCC 4.2.
- Plugins/WebBaseNetscapePluginView.mm: Use the correct return type in method signature.
2008-03-07 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Fix WebKit build with GCC 4.2.
- WebKit.xcodeproj/project.pbxproj: Mark WebTypesInternal.h as a private header so that DumpRenderTree can use it.
2008-03-07 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Fix WebKit build with GCC 4.2.
- DumpRenderTree/mac/ResourceLoadDelegate.mm: Use correct argument type in method signature.
- 11:11 PM Changeset in webkit [30894] by
-
- 5 edits in trunk
Reviewed by Darin.
REGRESSION: Korean decoding doesn't support extended EUC-KR.
Test: fast/encoding/char-decoding.html
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Untangle the system of duplicate ICU encoding names by manually registering windows-939-2000, and mapping all other related encodings to it.
- 10:19 PM Changeset in webkit [30893] by
-
- 2 edits in trunk/WebCore
2008-03-07 Dan Bernstein <mitz@apple.com>
Reviewed by Stephanie.
- try to fix leaks seen on Tiger after r30840
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::~CSSStyleSelector): Use the default operator delete, rather than arena delete, to deallocate the root default style.
- 10:07 PM Changeset in webkit [30892] by
-
- 2 edits in trunk/WebCore
2008-03-07 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=17681
GtkLauncher fails to render an element with position: fixed
Implement the required parts of PlatformScreenGtk.
- ChangeLog:
- platform/gtk/PlatformScreenGtk.cpp: (WebCore::screenDepth): (WebCore::screenIsMonochrome): (WebCore::screenRect):
- 9:58 PM Changeset in webkit [30891] by
-
- 4 edits3 adds in trunk
Bug 16610: <canvas> restore() removes path segments created before it
Reviewed by Darin Adler (code) and Mark Rowe (tests)
The problem here is that WebKit stored the Path as part of the state, so
restore would incorrectly lose changes made to the canvas path. To match
Firefox and HTML5 we make two real changes:
- Move the context path from the state object directly onto the context. This is responsible for all the changes to the path manipulation functions
- Add transform tracking to each state -- this is needed to correctly transform the current path when restore()-ing to a prior state.
Test: fast/canvas/canvas-save-restore-with-path.html
- 7:43 PM Changeset in webkit [30890] by
-
- 2 edits in trunk/WebCore
Fix for crash caused by FrameLoader incorrectly assuming it has
a RenderWidget
Reviewed by Ada
In some circumstances an application embedding a WebView may
choose to prevent a webview from loading a resource. If that
resource was requested by an <object> element then we may
fallback to different content which may not produce a RenderWidget.
Unfortunately FrameLoader::loadSubframe was assuming that if a
renderer was produced it would always be a RenderWidget, and arbitrarily
performed what could be an incorrect cast. This could then lead to
a crash.
We currently don't have anyway of making a test for this.
- 7:25 PM Changeset in webkit [30889] by
-
- 3 edits in trunk/WebKitTools
2008-03-07 Stephanie Lewis <Stephanie Lewis>
Reviewed by Oliver.
Add Windows part of <rdar://problem/5693690>
- DumpRenderTree/win/DumpRenderTree.cpp: (dump): (main):
- 7:08 PM Changeset in webkit [30888] by
-
- 13 edits4 adds in trunk
WebCore:
Reviewed by Oliver Hunt.
Fix for http://bugs.webkit.org/show_bug.cgi?id=16673
<canvas> lacks toDataURL()
Tests: fast/canvas/toDataURL-noData.html
fast/canvas/toDataURL-supportedTypes.html
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::printSecurityExceptionMessage): Make message non-global.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::printSecurityExceptionMessage): Log error message indicating that toDataURL has been called on a tainted canvas. (WebCore::HTMLCanvasElement::toDataURL): This does the tainted canvas check, ensures that the canvas has pixel data, checks to see if the MIME type is supported. Unsupported MIME types and the null string (which is made by passing no argument/null/undefined in JavaScript) are treated as being PNG, as per the spec. The actual toDataURL logic is actually done in the ImageBuffer class.
- html/HTMLCanvasElement.h: Add function declarations.
- html/HTMLCanvasElement.idl: Add function declaration.
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedImageMIMETypesForEncoding): (WebCore::initializeSupportedJavaScriptMIMETypes): (WebCore::initializeSupportedNonImageMimeTypes): (WebCore::initializeSupportedMediaMIMETypes): (WebCore::initializeMIMETypeRegistry): (WebCore::MIMETypeRegistry::getMIMETypeForPath): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType): (WebCore::MIMETypeRegistry::isJavaAppletMIMEType): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding): (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
- platform/MIMETypeRegistry.h: Clean up and add new supportedImageMIMETypesForEncoding set which contains the set of MIME types the platform knows how to encode. Currently only implemented for CG and Qt.
- platform/graphics/ImageBuffer.h: Add toDataURL method.
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::toDataURL): Add stub.
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::create): (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData): (WebCore::ImageBuffer::toDataURL): Converts the current context to a data: url of the specified MIME type. This method unfortunately has to flip the context, resulting in less than optimal code.
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::toDataURL): Add stub.
- platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::toDataURL): Add stub.
LayoutTests:
Reviewed by Oliver Hunt.
Tests for http://bugs.webkit.org/show_bug.cgi?id=16673
<canvas> lacks toDataURL()
- fast/canvas/toDataURL-noData-expected.txt: Added.
- fast/canvas/toDataURL-noData.html: Added.
- fast/canvas/toDataURL-supportedTypes-expected.txt: Added.
- fast/canvas/toDataURL-supportedTypes.html: Added.
- 5:30 PM Changeset in webkit [30887] by
-
- 2 edits in trunk/WebKitTools
2008-03-07 Alp Toker <alp@atoker.com>
Back out the r30818, r30819 build fix attempts now the GTK+ build
server has been upgraded.
- Scripts/webkitdirs.pm:
- 5:28 PM Changeset in webkit [30886] by
-
- 2 edits in trunk/WebCore
Build fix.
- WebCore.vcproj/WebCore.vcproj:
- 4:19 PM Changeset in webkit [30885] by
-
- 1 edit in trunk/LayoutTests/platform/win/Skipped
Removing duplicate entry for hasFocus.html
- 4:09 PM Changeset in webkit [30884] by
-
- 3 edits in trunk
2008-03-07 Stephanie Lewis <Stephanie Lewis>
update Windows Skipped List
- platform/win/Skipped:
- 3:29 PM Changeset in webkit [30883] by
-
- 4 edits in trunk
2008-03-07 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Mark Rowe.
Correct build intermediary output
(http://bugs.webkit.org/show_bug.cgi?id=17713)
- WebKit/win/WebKit.vcproj/WebKit.vcproj: Correct output and intermediary paths
2008-03-07 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Mark Rowe.
Correct build intermediary output
(http://bugs.webkit.org/show_bug.cgi?id=17713)
- WebCore/WebCore.vcproj: Correct intermediary paths
- 2:56 PM Changeset in webkit [30882] by
-
- 2 edits in trunk/LayoutTests
Adding fast/dom/HTMLDocument/hasFocus.html to the skipped list, while I investigate the failure.
- platform/win/Skipped:
- 2:32 PM Changeset in webkit [30881] by
-
- 3 edits in trunk/WebKitTools
2008-03-07 Stephanie <Stephanie Lewis>
Reviewed by Geoff.
<rdar://problem/5693690> run-webkit-tests swallows STDERR output, including WebCore LEAK messages
- DumpRenderTree/mac/DumpRenderTree.mm: (dump): push EOF to stderr after every test
- Scripts/run-webkit-tests: collect stderr output and print it
- 2:23 PM Changeset in webkit [30880] by
-
- 4 edits in tags/Safari-6526.0.1
Versioning.
- 2:21 PM Changeset in webkit [30879] by
-
- 2 edits in tags/Safari-6526.0.1/WebCore
Fix the 64-bit build.
- 2:18 PM Changeset in webkit [30878] by
-
- 1 copy in tags/Safari-6526.0.1
New tag.
- 1:23 PM ProposedWebInspectorUIRefresh edited by
- Added images inline (diff)
- 1:15 PM Changeset in webkit [30877] by
-
- 2 edits in trunk/WebKit/win
2008-03-07 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
Do not link (or attempt to initialize) the SafariTheme.dll
when not building with USE(SAFARI_THEME) enabled.
(http://bugs.webkit.org/show_bug.cgi?id=17707)
- WebKit/win/WebKitClassFactory.cpp: Conditionalize use of SafariTheme.dll
- 1:15 PM ProposedWebInspectorUIRefresh created by
- Initial version copied from Tim's emails
- 1:13 PM Changeset in webkit [30876] by
-
- 5 edits in trunk
2008-03-07 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Steve Falkenburg.
Add Cairo build requirements to WebCore.vcproj under a new
set of targets. Exclude Cairo elements from normal CG build.
Exclude CG elements from Cairo builds.
(http://bugs.webkit.org/show_bug.cgi?id=17300)
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/webcore.vsprops: Added.
2008-03-07 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Steve Falkenburg.
Update solution to understand Cairo build target. Add
library dependencies for Cairo build target.
(http://bugs.webkit.org/show_bug.cgi?id=17300)
- WebKit.vcproj/WebKit.sln:
- WebKit.vcproj/WebKit.vcproj:
- 1:09 PM Web Inspector edited by
- Add a link to a new page about Inspector UI improvements (diff)
- 1:00 PM Changeset in webkit [30875] by
-
- 13 edits in trunk
WebCore:
Reviewed by Adam.
- eliminated WebCoreFrameBridge runOpenPanel
- page/ChromeClient.h: Added runOpenPanel function.
- page/mac/ChromeMac.mm: (WebCore::ChromeClient::runOpenPanel): Added.
- platform/FileChooser.cpp: (WebCore::FileChooser::FileChooser): Moved this here. It's no longer platform-specific. Also start the refcount at 1. (WebCore::FileChooser::create): Added adoptRef since the refcount no starts at one. (WebCore::FileChooser::~FileChooser): Moved here. No longer platform-specific.
- platform/FileChooser.h: Removed m_controller, which was Macintosh-specific.
- platform/gtk/FileChooserGtk.cpp: Removed FileChooser constructor and destructor, since they are no longer platform-specific.
- platform/qt/FileChooserQt.cpp: Ditto.
- platform/win/FileChooserWin.cpp: Ditto.
- platform/wx/TemporaryLinkStubs.cpp: Ditto.
- platform/mac/FileChooserMac.mm: (WebCore::FileChooser::openFileChooser): Call the chrome client instead of the bridge to run the open panel. Allows us to get rid of the WebCoreOpenPanelController class and m_controller data member and move the cosntrutor/destructor to platform- independent code.
WebKit/mac:
Reviewed by Adam.
- eliminated WebCoreFrameBridge runOpenPanel
- WebCoreSupport/WebChromeClient.h: Added runOpenPanel.
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runOpenPanel): Added. (-[WebOpenPanelResultListener initWithChooser:]): Added. Used to wrap the FileChooser so it can get a result from the UI delegate. (-[WebOpenPanelResultListener dealloc]): Added. (-[WebOpenPanelResultListener finalize]): Added. (-[WebOpenPanelResultListener cancel]): Added. (-[WebOpenPanelResultListener chooseFilename:]): Added.
- 12:51 PM Changeset in webkit [30874] by
-
- 11 edits3 adds in trunk
Add WebCore::JavaScriptDebugServer and use it from WebKit/win
WebCore:
Add JavaScriptDebugServer
This class is a singleton which allows one or more
JavaScriptDebugListeners to receive callbacks during JavaScript
execution.
Right now all listeners receive callbacks for all Pages in the
process. Eventually we will want to support listeners registering for
callbacks for specific Pages (e.g., the Inspector will want to listen
for execution in just the Page it's inspecting).
Pages notify the JavaScriptDebugServer when they are created so that
it can install itself as the Page's debugger.
Reviewed by Darin.
- GNUMakefile.am: Added new files to project.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- WebCoreSources.bkl: Ditto.
- page/JavaScriptDebugListener.h: Added.
- page/JavaScriptDebugServer.cpp: Added. (WebCore::toFrame): (WebCore::JavaScriptDebugServer::shared): (WebCore::JavaScriptDebugServer::JavaScriptDebugServer): (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer): (WebCore::JavaScriptDebugServer::addListener): Registers as the debugger for all Pages if we're adding our first listener. (WebCore::JavaScriptDebugServer::removeListener): Deregisters as the debugger for all Pages if we're removing our last listner. (WebCore::JavaScriptDebugServer::pageCreated): Registers as the debugger for the newly created Page if we have any listeners. (WebCore::dispatchDidParseSource): Helper function. (WebCore::dispatchFailedToParseSource): Ditto. (WebCore::JavaScriptDebugServer::sourceParsed): Call dispatchDidParseSource or dispatchFailedToParseSource depending on whether there was an error or not. (WebCore::JavaScriptDebugServer::dispatchFunctionToListeners): Calls the passed-in JavaScriptExecutionCallback on each listener, guarding against re-entry. (WebCore::JavaScriptDebugServer::callEvent): Dispatch didEnterCallFrame. (WebCore::JavaScriptDebugServer::atStatement): Dispatch willExecuteStatement. (WebCore::JavaScriptDebugServer::returnEvent): Dispatch willLeaveCallFrame. (WebCore::JavaScriptDebugServer::exception): Dispatch exceptionWasRaised.
- page/JavaScriptDebugServer.h: Added.
- page/Page.cpp: (WebCore::Page::Page): Tell the shared JavaScriptDebugServer we were created so it can register as our debugger if needed.
WebKit/win:
Change WebScriptDebugServer to use WebCore::JavaScriptDebugServer
WebScriptDebugServer is now a JavaScriptDebugListener.
Reviewed by Darin.
- WebScriptDebugServer.cpp: (WebScriptDebugServer::WebScriptDebugServer): Removed initialization of m_callingListeners member. (WebScriptDebugServer::addListener): Register as a listener with JavaScriptDebugServer if we've just added our first listener. (WebScriptDebugServer::removeListener): Deregister as a listener with JavaScriptDebugServer if we've just removed our last listener. (WebScriptDebugServer::didParseSource): Added. Code came from the old sourceParsed method. Removed m_callingListeners code because JavaScriptDebugServer guards against re-entry for us. (WebScriptDebugServer::failedToParseSource): Ditto. (WebScriptDebugServer::didEnterCallFrame): Ditto for callEvent. (WebScriptDebugServer::willExecuteStatement): Ditto for atStatement. (WebScriptDebugServer::willLeaveCallFrame): Ditto for willLeaveCallFrame. (WebScriptDebugServer::exceptionWasRaised): Ditto for exception.
- WebScriptDebugServer.h: Changed to inherit from WebCore::JavaScriptDebugListener.
- WebView.cpp: (WebView::initWithFrame): Removed call to WebScriptDebugServer::pageCreated. This is now handled by WebCore.
- 12:39 PM Changeset in webkit [30873] by
-
- 3 edits in trunk/WebCore
Reviewed by Brady.
- fix a theoretical problem with the visited-link hash table by avoiding collision with the special "deleted" value
- improve efficiency of with the visited-link hash table by not hashing twice
- page/PageGroup.cpp: (WebCore::avoidDeletedValue): Added. Makes sure we never try to use the "all ones" value, since the hash table uses that for deleted hash table entries. (WebCore::PageGroup::isLinkVisited): Call avoidDeletedValue before using the hash value with the HashSet. (WebCore::PageGroup::addVisitedLink): Ditto.
- page/PageGroup.h: Added a new hash function, AlreadyHashed, for unsigned integer values. This assumes that the value is already a hash value, and doesn't try to hash it again. Used this for m_visitedLinkHashes.
- 12:15 PM Changeset in webkit [30872] by
-
- 2 edits in trunk/WebKitTools
Get pdevenv working with Visual Studio Express.
Reviewed by Adam.
- Scripts/pdevenv:
- 11:46 AM Changeset in webkit [30871] by
-
- 16 edits10 adds4 deletes in trunk
Reviewed by Darin Adler.
Fixed <rdar://problem/5689093> Stricter (ES4) eval semantics
The basic rule is:
- "eval(s)" is treated as an operator that gives the ES3 eval behavior.
... but only if there is no overriding declaration of "eval" in scope.
- All other invocations treat eval as a function that evaluates a script in the context of its "this" object.
... but if its "this" object is not the global object it was
originally associated with, eval throws an exception.
Because only expressions of the form "eval(s)" have access to local
scope, the compiler can now statically determine whether a function
needs local scope to be dynamic.
- kjs/nodes.h: Added FunctionCallEvalNode. It works just like FuncationCallResolveNode, except it statically indicates that the node may execute eval in the ES3 way.
- kjs/nodes.cpp:
- kjs/nodes2string.cpp:
- tests/mozilla/expected.html: This patch happens to fix a Mozilla JS test, but it's a bit of a pyrrhic victory. The test intends to test Mozilla's generic API for calling eval on any object, but, in reality, we only support calling eval on the global object.
LayoutTests:
Reviewed by Darin Adler.
Tests for <rdar://problem/5689093> Stricter (ES4) eval semantics
- fast/js/eval-cross-window-expected.txt: Added.
- fast/js/eval-cross-window.html: Added.
- fast/js/eval-keyword-vs-function-expected.txt: Added.
- fast/js/eval-keyword-vs-function.html: Added.
- fast/js/eval-overriding-expected.txt: Added.
- fast/js/eval-overriding.html: Added.
Tests to make sure not to regress security:
- http/tests/security/resources/xss-eval2.html: Added.
- http/tests/security/resources/xss-eval3.html: Added.
- http/tests/security/xss-eval-expected.txt: Added.
- http/tests/security/xss-eval.html: Added.
I removed these tests because we no longer match the behavior they
expected, and the new tests are more comprehensive:
- fast/js/window-eval-context-expected.txt: Removed.
- fast/js/window-eval-context.html: Removed.
- fast/js/window-eval-tearoff-expected.txt: Removed.
- fast/js/window-eval-tearoff.html: Removed.
- 5:09 AM Changeset in webkit [30870] by
-
- 4 edits in trunk
Fix the Qt build.
Mar 6, 2008:
- 11:45 PM Changeset in webkit [30869] by
-
- 8 edits2 adds in trunk
Implement the HTML5 canvas tainting rules to prevent potential data leakage
Reviewed by Mitz
Added originClean to HTMLCanvasElement and CanvasPattern
to track whether a canvas (or pattern) is tainted by remote
data.
Use originClean flag to determine whether getImageData should
return, well, image data.
Test: http/tests/security/canvas-remote-read-remote-image.html
- 7:24 PM ApplicationsGtk edited by
- Fix app URL (diff)
- 7:22 PM ApplicationsGtk edited by
- Add another doc browser (diff)
- 5:55 PM Changeset in webkit [30868] by
-
- 7 edits in trunk/WebCore
Reviewed by Jon.
Templatize the JNI call code to reduce the amount of code that has
to be duplicated.
- bridge/jni/jni_class.cpp: (JavaClass::JavaClass):
- bridge/jni/jni_instance.cpp: (JavaInstance::stringValue): (JavaInstance::numberValue): (JavaInstance::booleanValue): (JavaInstance::invokeMethod):
- bridge/jni/jni_jsobject.cpp: (JavaJSObject::convertJObjectToValue):
- bridge/jni/jni_runtime.cpp: (JavaField::JavaField): (JavaMethod::JavaMethod):
- bridge/jni/jni_utility.cpp:
- bridge/jni/jni_utility.h: (KJS::Bindings::): (KJS::Bindings::callJNIMethodIDA): (KJS::Bindings::callJNIMethodV): (KJS::Bindings::callJNIMethod): (KJS::Bindings::callJNIStaticMethod):
- 5:51 PM Changeset in webkit [30867] by
-
- 10 edits in trunk
WebCore:
Reviewed by Mitz.
- fix regression test failures from the visited-link change
- WebCore.base.exp: Export PageGroup::setShouldTrackVisitedLinks.
- page/PageGroup.cpp: (WebCore::PageGroup::addVisitedLink): Do nothing and return early if shouldTrackVisitedLinks is false. (WebCore::PageGroup::removeVisitedLinks): Reset m_visitedLinksPopulated so the next time a link is queried this will be populated from history. (WebCore::PageGroup::setShouldTrackVisitedLinks): Added.
- page/PageGroup.h: Added setShouldTrackVisitedLinks. This is global for now, but it would be better if it was per-page-group instead.
WebKit/mac:
Reviewed by Mitz.
- fix regression test failures from the visited-link change
- History/WebHistory.mm: (+[WebHistory setOptionalSharedHistory:]): Call PageGroup::setShouldTrackVisitedLinks to turn off visited links if there is no history object. Also call removeAllVisitedLinks so we can start over from scratch with the new history.
WebKit/win:
Reviewed by Mitz.
- fix regression test failures and crashes from the visited-link change
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::populateVisitedLinks): Check for null before calling addVisitedLinksToPageGroup.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Ditto.
- WebHistory.cpp: (WebHistory::setOptionalSharedHistory): Call PageGroup::setShouldTrackVisitedLinks to turn off visited links if there is no history object. Also call removeAllVisitedLinks so we can start over from scratch with the new history.
- 5:30 PM Changeset in webkit [30866] by
-
- 7 edits5 adds in trunk
WebCore:
Reviewed by Darin.
Fixes for for <rdar://problem/5785892> Implement activeElement attribute for HTMLDocument (HTML5)
and <rdar://problem/5785895> Implement hasFocus() for HTMLDocument (HTML5)
Tests: fast/dom/HTMLDocument/activeElement.html
fast/dom/HTMLDocument/hasFocus.html
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::activeElement): Added. Returns the focused element, or the body element if nothing's focused. (WebCore::HTMLDocument::hasFocus): Added. Returns whether or not the document has focus (inclusive of sub-frames).
- html/HTMLDocument.h: Added methods for activeElement and hasFocus.
- html/HTMLDocument.idl: Added definitions for activeElement and hasFocus.
WebKitTools:
Reviewed by Darin.
Updated for testing <rdar://problem/5785895> Implement hasFocus() for HTMLDocument (HTML5)
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webViewFocus:]): Remove duplicate code that was also in LayoutTestController::setWindowIsKey (-[UIDelegate webViewUnfocus:]): Added. In Safari, the default is to focus another window if there is one. To easily test cases where the window is unfocused, I made this just call setWindowIsKey(false).
LayoutTests:
Reviewed by Darin.
Tests for <rdar://problem/5785892> Implement activeElement attribute for HTMLDocument (HTML5)
and <rdar://problem/5785895> Implement hasFocus() for HTMLDocument (HTML5)
- fast/dom/HTMLDocument/activeElement-expected.txt: Added.
- fast/dom/HTMLDocument/activeElement.html: Added.
- fast/dom/HTMLDocument/hasFocus-expected.txt: Added.
- fast/dom/HTMLDocument/hasFocus.html: Added.
- fast/dom/HTMLDocument/resources/hasFocus-iframe.html: Added.
- 5:09 PM Changeset in webkit [30865] by
-
- 4 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/5741981> 154008 WebKit: Some asian language font glyphs are not shown (in Mail and Entourage)
Test: fast/text/soft-hyphen-3.html
- rendering/bidi.cpp: (WebCore::checkMidpoints): (WebCore::RenderBlock::findNextLineBreak): Made 'pos' unsigned. Made the midpoint after a hyphen always be a valid iterator, not allowing an offset past the end of a text node. Changed the check for consecutive soft hyphens to account for that.
LayoutTests:
Reviewed by Darin Adler.
- test and updated results for <rdar://problem/5741981> 154008 WebKit: Some asian language font glyphs are not shown (in Mail and Entourage)
- fast/text/soft-hyphen-3.html: Added.
- platform/mac/fast/text/basic/014-expected.txt:
- platform/mac/fast/text/soft-hyphen-3-expected.checksum: Added.
- platform/mac/fast/text/soft-hyphen-3-expected.png: Added.
- platform/mac/fast/text/soft-hyphen-3-expected.txt: Added.
- 4:28 PM Changeset in webkit [30864] by
-
- 4 edits in trunk
WebKit/win:
Reviewed by Adam Roben.
Bug 17691: REGRESSION: FindSafari doesn't work
http://bugs.webkit.org/show_bug.cgi?id=17691
Swap my change from r30394 to use the Release libraries instead of Debug
since some machines don't have the Debug version.
- WebKit.vcproj/WebKit.sln:
WebKitTools:
Reviewed by Adam Roben.
Bug 17691: REGRESSION: FindSafari doesn't work
http://bugs.webkit.org/show_bug.cgi?id=17691
Swap my change from r30394 to use the Release libraries instead of Debug
since some machines don't have the Debug version.
- FindSafari/FindSafari.vcproj:
- 4:14 PM Changeset in webkit [30863] by
-
- 1 edit in trunk/WebCore/bindings/scripts/CodeGeneratorCOM.pm
Fix typos.
- 4:14 PM Changeset in webkit [30862] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
- 3:39 PM Changeset in webkit [30861] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- 3:33 PM Changeset in webkit [30860] by
-
- 4 edits in trunk
Versioning.
- 3:30 PM Changeset in webkit [30859] by
-
- 1 copy in tags/Safari-6526
New tag.
- 3:28 PM Changeset in webkit [30858] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Sam and Tim.
<rdar://5631450> Drosera: breakpoint indicators disappear after the
script is finished running.
- If there is a pre-existing breakpoint on a line when the file is updated we need to redraw it.
- Drosera/debugger.js:
- 3:11 PM Changeset in webkit [30857] by
-
- 2 edits in trunk/JavaScriptCore
2008-03-06 Alp Toker <alp@atoker.com>
Fix the build fix in r30845 to support out-of-tree builds.
- GNUmakefile.am:
- 1:45 PM Changeset in webkit [30856] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
- fix a regression from r30741: a crash under WebFrameLoaderClient::createPlugin() when showing a Mail message with an attachment
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
- 1:09 PM Changeset in webkit [30855] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- wtf/ThreadingWin.cpp: (WTF::ThreadCondition::timedWait):
- 12:58 PM Changeset in webkit [30854] by
-
- 2 edits in trunk/WebKitTools
Tiger build fix...?
- DumpRenderTree/mac/WatchdogMac.mm:
- 12:08 PM Changeset in webkit [30853] by
-
- 2 edits in trunk/JavaScriptCore
- another small step towards fixing the Qt build
- JavaScriptCore.pri: Remove more references to the now-obsolete bindings directory.
- 12:02 PM Changeset in webkit [30852] by
-
- 6 edits in trunk
- a small step towards fixing the Qt build
- JavaScriptCore.pri: Remove references to files no longer present in JavaScriptCore/bindings.
WebCore:
- try to fix Wx build
- WebCoreSources.bkl: Added PageGroup.cpp.
WebKit/mac:
- fix Tiger build
- History/WebHistory.mm: Added include of WebTypesInternal.h.
- 11:50 AM Changeset in webkit [30851] by
-
- 2 edits in trunk/JavaScriptCore
Gtk Build fix
- wtf/ThreadingGtk.cpp: (WTF::ThreadCondition::timedWait):
- 11:34 AM Changeset in webkit [30850] by
-
- 2 edits in trunk/JavaScriptCore
Wx build fix.
- wtf/unicode/icu/CollatorICU.cpp: (WTF::Collator::userDefault): Put ICU workaround under both PLATFORM(DARWIN) and PLATFORM(CF) checks, so that each port can decide if it wants to use CF on Mac for it.
- 10:55 AM Changeset in webkit [30849] by
-
- 11 edits6 adds in trunk
Reviewed by Darin
Add a timedWait() method to ThreadCondition
- JavaScriptCore.exp:
- wtf/Threading.h:
- wtf/ThreadingGtk.cpp: (WTF::ThreadCondition::timedWait):
- wtf/ThreadingNone.cpp: (WTF::ThreadCondition::timedWait):
- wtf/ThreadingPthreads.cpp: (WTF::ThreadCondition::timedWait):
- wtf/ThreadingWin.cpp: (WTF::ThreadCondition::timedWait): Needs implementation
WebKitTools:
Reviewed by Darin
Added a cross-platform Watchdog thread to DRT.
The current watchdog in both DRTWin and DRTMac is Timer based. Therefore, deadlocks and long running
main thread hangs still affect DRT.
By placing the watchdog on a thread and having DRT "check in" after each test, long-running hangs
and true deadlocks can be caught.
There is one hook for platform specific code. As I did my development and testing on Mac, and Mac has
sampleavailable, the Mac implementation of this hook samples the process before it is killed.
I arbitrarily chose 30 seconds as the timeout for now - this can be tweaked easily if we find a need.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/mac/Configurations/Base.xcconfig: Added LINKER_DISPLAYS_MANGLED_NAMES
- DumpRenderTree/ForwardingHeaders/wtf/Locker.h: Added.
- DumpRenderTree/ForwardingHeaders/wtf/Threading.h: Added.
- DumpRenderTree/Watchdog.cpp: Added. (Watchdog::Watchdog): (Watchdog::~Watchdog): (Watchdog::start): (Watchdog::stop): (Watchdog::checkIn): (Watchdog::setWatchdogInterval): (Watchdog::handleHang): (Watchdog::watchdogThreadStart): (Watchdog::watchdogThread):
- DumpRenderTree/Watchdog.h: Added.
- DumpRenderTree/mac/WatchdogMac.h: Added.
- DumpRenderTree/mac/WatchdogMac.mm: Added. (WatchdogMac::handleHang): Sample the process and write it out to a file
- DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Setup and start the watchdog before running any tests (runTest): Checkin with the watchdog after each test
- 10:51 AM Changeset in webkit [30848] by
-
- 4 edits in trunk/JavaScriptCore
More build fixes.
- jscore.bkl: Add the wtf/unicode directory.
- wtf/unicode/CollatorDefault.cpp: (WTF::Collator::userDefault): Use a constructor that does exist.
- wtf/unicode/icu/CollatorICU.cpp: Mac build fix for case-sensitive file systems.
- 10:21 AM Changeset in webkit [30847] by
-
- 2 edits in trunk/WebKit/mac
- fix Release build
- History/WebHistory.mm: (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): Removed underscore. (-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): Added #if. (-[WebHistoryPrivate saveToURL:error:]): Ditto.
- 10:19 AM Changeset in webkit [30846] by
-
- 2 edits in trunk/JavaScriptCore
- try to fix the Qt build
- JavaScriptCore.pri: Add the wtf/unicode directory.
- 10:18 AM Changeset in webkit [30845] by
-
- 2 edits in trunk/JavaScriptCore
- try to fix the GTK build
- GNUmakefile.am: Add a -I for the unicode directory.
- 10:14 AM Changeset in webkit [30844] by
-
- 1 edit5 copies in trunk/JavaScriptCore
- try to fix the Mac build
- icu/unicode/parseerr.h: Copied from ../WebCore/icu/unicode/parseerr.h.
- icu/unicode/ucol.h: Copied from ../WebCore/icu/unicode/ucol.h.
- icu/unicode/uloc.h: Copied from ../WebCore/icu/unicode/uloc.h.
- icu/unicode/unorm.h: Copied from ../WebCore/icu/unicode/unorm.h.
- icu/unicode/uset.h: Copied from ../WebCore/icu/unicode/uset.h.
- 9:51 AM Changeset in webkit [30843] by
-
- 4 edits in trunk/WebCore
- fix some builds
- GNUmakefile.am: Added PageGroup.cpp.
- WebCore.base.exp: Removed WebCoreHistory.
- WebCore.pro: Added PageGroup.cpp.
- 9:50 AM Changeset in webkit [30842] by
-
- 17 edits7 adds in trunk
Reviewed by Darin.
<rdar://problem/5687269> Need to create a Collator abstraction for WebCore and JavaScriptCore
- 9:45 AM Changeset in webkit [30841] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Adele.
- add test for r30823 (background-position: inherit)
- fast/css/background-position-inherit-expected.txt: Added.
- fast/css/background-position-inherit.html: Added.
- 9:21 AM Changeset in webkit [30840] by
-
- 33 edits3 adds7 deletes in trunk
WebCore:
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=17526 REGRESSION: iframes are added to Safari's History menu by separating the visited link machinery from global history
This should also make page loading faster due to more efficient visited link coloring.
- WebCore.base.exp: Updated.
- WebCore.vcproj/WebCore.vcproj: Added PageGroup.h/cpp, removed GlobalHistory.h/cpp.
- WebCore.xcodeproj/project.pbxproj: Ditto. Also removed WebCoreHistory.h/m.
- css/CSSStyleSelector.cpp: Updated includes. (WebCore::CSSStyleSelector::initElementAndPseudoState): Eliminated code to set currentEncodedURL. (WebCore::checkPseudoState): Moved most of the code inside a new PageGroup::isLinkVisited function. (WebCore::CSSStyleSelector::canShareStyleWithElement): Tightened code a bit by using references and only getting colors when needed. (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Ditto.
- css/CSSStyleSelector.h: Removed EncodedURL, m_encodedURL, and setEncodedURL.
- dom/Document.cpp: (WebCore::Document::attach): Removed call to setEncodedURL. (WebCore::Document::setURL): Ditto. (WebCore::Document::recalcStyleSelector): Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Changed code to use early exit idiom to be a little more readable. (WebCore::FrameLoader::urlsMatchItem): Change to use a reference for slightly better efficiency. (WebCore::FrameLoader::goToItem): Use early exit idiom to be a little more readable. (WebCore::FrameLoader::updateHistoryForStandardLoad): Moved history code back in here and got rid of the helper function updateGlobalHistory, restoring the logic before r30549. Also added a call to the new addVisitedLink function. (WebCore::FrameLoader::updateHistoryForClientRedirect): Added code to call addVisitedLink here. (WebCore::FrameLoader::updateHistoryForBackForwardNavigation): Removed comment. (WebCore::FrameLoader::updateHistoryForReload): Removed call to updateGlobalHistory; we can just go without updating global history or visited links here, at least for now, since it's not clear that a reload is a "history event". (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Moved history code back where it was, and added the call to addVisitedLink, just as in updateHistoryForStandardLoad above.
- loader/FrameLoader.h: Removed updateGlobalHistory function.
- page/Chrome.cpp: (WebCore::ChromeClient::populateVisitedLinks): Added. Empty placeholder so we don't have to implement this for every port all at once. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Changed to use the new PageGroup class.
- page/ChromeClient.h: Added populateVisitedLinks function, used to fill the visited links set from the global history at application startup time.
- page/FrameTree.cpp: (WebCore::FrameTree::find): Updated to use the new PageGroup class.
- page/GlobalHistory.h: Removed.
- page/win/GlobalHistoryWin.cpp: Removed.
- page/mac/GlobalHistoryMac.mm: Removed.
- platform/mac/WebCoreHistory.h: Removed.
- platform/mac/WebCoreHistory.m: Removed.
- platform/win/WebCoreHistory.cpp: Removed.
- platform/win/WebCoreHistory.h: Removed.
- page/Page.cpp: (WebCore::Page::Page): Set m_group to 0. (WebCore::Page::setGroupName): Set up m_group. If the page is not in any group, set it to 0 for now to postpone the cost of creating a group. (WebCore::Page::initGroup): Added. Sets m_group to point to a single-page group; used when getting a group. (WebCore::Page::removeAllVisitedLinks): Added. Calls removeVisitedLinks on all page groups.
- page/Page.h: Moved enums inside the WebCore namespace. Removed the frameNamespace function and instead added the group and groupPtr functions.
- page/PageGroup.cpp: Added. Contains all the visited code from the CSSStyleSelector in the isVisitedLink function, but more efficient because we don't allocate memory for the buffer.
- page/PageGroup.h: Added.
- platform/gtk/TemporaryLinkStubs.cpp: Removed historyContains.
- platform/qt/TemporaryLinkStubs.cpp: Removed unneeded include.
- platform/wx/TemporaryLinkStubs.cpp: Removed historyContains.
WebKit:
- WebKit.xcodeproj/project.pbxproj: Added WebHistoryInternal.h.
WebKit/mac:
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=17526 REGRESSION: iframes are added to Safari's History menu by separating the visited link machinery from global history
- History/WebHistory.mm: Moved WebHistoryPrivate inside this file. (-[WebHistoryPrivate removeItemFromDateCaches:]): Removed the underscore from this method name, since it's on a private object. (-[WebHistoryPrivate removeItemForURLString:]): Added a call to the PageGroup::removeAllVisitedLinks function if the last URL was removed. (-[WebHistoryPrivate addItemToDateCaches:]): Removed the underscore from this method name, since it's on a private object. (-[WebHistoryPrivate removeAllItems]): Call PageGroup::removeAllVisitedLinks. (-[WebHistoryPrivate ageLimitDate]): Removed the underscore from this method name, since it's on a private object. (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]): Ditto. (-[WebHistoryPrivate saveHistoryGuts:URL:error:]): Ditto. Also changed this to correctly return the error by using the newer version of writeToURL: and removed the FIXME about that. (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Added. Calls addVisitedLink for every link in the history. (-[WebHistory saveToURL:error:]): Removed the FIXME, since we do get the error now. (-[WebHistory addItem:]): Moved into the WebPrivate category. (-[WebHistory addItemForURL:]): Ditto. (-[WebHistory _addItemForURL:title:]): Added. Used for the normal case where we create an item and already know its title. (-[WebHistory ageLimitDate]): Moved into the WebPrivate category. (-[WebHistory containsItemForURLString:]): Ditto. (-[WebHistory removeItem:]): Ditto. (-[WebHistory setLastVisitedTimeInterval:forItem:]): Ditto. (-[WebHistory _itemForURLString:]): Ditto. (-[WebHistory _addVisitedLinksToPageGroup:]): Added. For use only inside WebKit.
- History/WebHistoryInternal.h: Added.
- History/WebHistoryItemInternal.h: Tweaked formatting and includes.
- History/WebHistoryPrivate.h: Moved the WebHistoryPrivate class out of this header. Also reorganized what was left behind.
- WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::populateVisitedLinks): Added a call to the new -[WebHistory _addVisitedLinksToPageGroup:] method.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Changed code to use the new -[WebHistory _addItemForURL:title:] method.
WebKit/win:
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=17526 REGRESSION: iframes are added to Safari's History menu by separating the visited link machinery from global history
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::populateVisitedLinks): Added a call to the new WebHistory::addVisitedLinksToPageGroup function.
- WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks. Also fixed the webView function to be non-virtual.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Changed to use the new WebHistory::addItem function. (WebFrameLoaderClient::webHistory): Changed to return a WebHistory*, there's no reason to AddRef the result from this function.
- WebCoreSupport/WebFrameLoaderClient.h: Ditto.
- WebHistory.cpp: Removed IWebHistoryPrivate and _WebCoreHistoryProvider. (WebHistory::QueryInterface): Removed IWebHistoryPrivate. (sharedHistoryStorage): Added. (WebHistory::sharedHistory): Added. (WebHistory::optionalSharedHistory): Changed to use sharedHistory(). (WebHistory::setOptionalSharedHistory): Changed to require a WebHistory object, not just an IWebHistory. (WebHistory::removeAllItems): Call PageGroup::removeAllVisitedLinks. (WebHistory::addItem): Changed parameter types since this is called with arguments from WebCore -- at some point this could allow better efficiency. (WebHistory::removeItemForURLString): Call PageGroup::removeAllVisitedLinks if the last URL is being removed. (addVisitedLinkToPageGroup): Added. Helper. Adds a single link to a group's visited link set. (WebHistory::addVisitedLinksToPageGroup): Added. Adds all links to a group's visited link.
- WebHistory.h: Removed IWebHistoryPrivate. Removed optionalSharedHistoryInternal and added sharedHistory. Replaced addItemForURL and containsItemForURLString with non-virtual addItem and addVisitedLinksToPageGroup functions.
- 9:03 AM Changeset in webkit [30839] by
-
- 1 edit4 adds in trunk/WebKitSite
Rubber-stamped by Adam Roben.
Add a simple page that has various demo functions for Drosera.
- demos/drosera: Added.
- demos/drosera/demo.js: Added.
- demos/drosera/drosera.png: Added.
- demos/drosera/index.html: Added.
- 8:15 AM Changeset in webkit [30838] by
-
- 5 edits2 moves in trunk/WebKit
Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}
WebKit:
Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}
Reviewed by Kevin M.
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}
Reviewed by Kevin M.
- WebView/WebFrame.mm:
- WebView/WebScriptDebugDelegate.mm:
- WebView/WebScriptDebugger.h: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.h.
- WebView/WebScriptDebugger.mm: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.mm.
- 8:15 AM Changeset in webkit [30837] by
-
- 5 edits in trunk/WebKit/mac
Rename WebCoreScriptDebuggerImp to WebScriptDebugger
Reviewed by Kevin M.
- WebView/WebCoreScriptDebuggerImp.h:
- WebView/WebCoreScriptDebuggerImp.mm:
- WebView/WebFrame.mm: (-[WebFrame _attachScriptDebugger]):
- WebView/WebFrameInternal.h:
- 8:14 AM Changeset in webkit [30836] by
-
- 7 edits1 delete in trunk/WebKit
Remove WebScriptDebugger
WebKit:
Remove WebScriptDebugger
Reviewed by Kevin M.
- WebKit.xcodeproj/project.pbxproj: Remove WebScriptDebugDelegatePrivate.h from the project.
WebKit/mac:
Remove WebScriptDebugger
Uses of WebScriptDebugger have been replaced with
WebCoreScriptDebuggerImp.
Reviewed by Kevin M.
- WebView/WebFrame.mm: (-[WebFramePrivate dealloc]): Use delete instead of release since WebCoreScriptDebuggerImp is a C++ class. (-[WebFrame _attachScriptDebugger]): Updated to use early returns and WebCoreScriptDebuggerImp. (-[WebFrame _detachScriptDebugger]): Ditto.
- WebView/WebFrameInternal.h:
- WebView/WebScriptDebugDelegate.mm: Removed WebScriptDebugger
- WebView/WebScriptDebugDelegatePrivate.h: Removed.
- WebView/WebView.mm:
- 8:14 AM Changeset in webkit [30835] by
-
- 8 edits in trunk
Remove -webFrame and -globalObject from WebScriptDebugger
WebCore:
Export a header/symbol for WebKit
Reviewed by Kevin M.
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
WebKit/mac:
Remove -webFrame and -globalObject from WebScriptDebugger
WebCoreScriptDebuggerImp is now unaware of WebScriptDebugger
Reviewed by Kevin M.
- WebView/WebCoreScriptDebuggerImp.h: Removed WebScriptDebugger* parameter to the constructor.
- WebView/WebCoreScriptDebuggerImp.mm: (toWebFrame): Added. (WebCoreScriptDebuggerImp::sourceParsed): Call toWebFrame. (WebCoreScriptDebuggerImp::callEvent): Ditto, and get the Frame's WindowScriptObject ourselves instead of asking WebScriptDebugger for it. (WebCoreScriptDebuggerImp::atStatement): Call toWebFrame. (WebCoreScriptDebuggerImp::returnEvent): Ditto. (WebCoreScriptDebuggerImp::exception): Ditto.
- WebView/WebScriptDebugDelegate.mm: (-[WebScriptDebugger initWithWebFrame:]): Updated for change to WebScriptDebuggerImp's constructor.
- WebView/WebScriptDebugDelegatePrivate.h: Removed -webFrame/-globalObject.
- 8:13 AM Changeset in webkit [30834] by
-
- 5 edits in trunk/WebKit/mac
Remove -enterFrame: and -leaveFrame from WebScriptDebugger
Reviewed by Kevin M.
- WebView/WebCoreScriptDebuggerImp.h: Changed to store m_topCallFrame in a RetainPtr, now that WebCoreScriptDebuggerImp is in charge of its lifetime.
- WebView/WebCoreScriptDebuggerImp.mm:
- Added declaration of -[WebScriptCallFrame _initWithGlobalObject:caller:state:].
- Changed most uses of m_topCallFrame to m_topCallFrame.get()
(WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Removed
now-unnecessary initialization of m_topCallFrame.
(WebCoreScriptDebuggerImp::callEvent): Replaced call to enterFrame:
with its implementation. The one difference between this
implementation and the old enterFrame: method is that we don't hand
our reference to m_topCallFrame to _initWithGlobalObject: -- that
method must now retain the passed-in WebScriptCallFrame manually.
(WebCoreScriptDebuggerImp::atStatement):
(WebCoreScriptDebuggerImp::returnEvent): Replaced call to leaveFrame
with its implementation.
(WebCoreScriptDebuggerImp::exception):
- WebView/WebScriptDebugDelegate.mm: Removed declaration of -[WebScriptCallFrame _initWithGlobalObject:caller:state:]. (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Changed to retain the passed-in caller.
- WebView/WebScriptDebugDelegatePrivate.h:
- Removed _current ivar
- Removed enterFrame:/leaveFrame declarations.
- 8:13 AM Changeset in webkit [30833] by
-
- 4 edits in trunk/WebKit/mac
Remove -parsedSource: from WebScriptDebugger
Reviewed by Kevin M.
- WebView/WebCoreScriptDebuggerImp.mm: (WebCoreScriptDebuggerImp::sourceParsed): Moved code here from -[WebScriptDebugger parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]
- WebView/WebScriptDebugDelegate.mm: Removed -parsedSource:.
- WebView/WebScriptDebugDelegatePrivate.h: Ditto.
- 8:13 AM Changeset in webkit [30832] by
-
- 4 edits in trunk/WebKit/mac
Remove -enteredFrame:, -leavingFrame:, and -exceptionRaised: from WebScriptDebugger
Reviewed by Kevin M.
- WebView/WebCoreScriptDebuggerImp.mm: (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Changed to call trhough to callEvent instead of duplicating its code here. (WebCoreScriptDebuggerImp::callEvent): Moved code from -[WebScriptDebugger enteredFrame:sourceId:line:] here. (WebCoreScriptDebuggerImp::returnEvent): Moved code from -[WebScriptDebugger leavingFrame:sourceId:line:] here. (WebCoreScriptDebuggerImp::exception): Moved code from -[WebScriptDebugger exceptionRaised:sourceId:line:] here.
- WebView/WebScriptDebugDelegate.mm: Removed -enteredFrame:, -leavingFrame:, and -exceptionRaised:.
- WebView/WebScriptDebugDelegatePrivate.h: Ditto.
- 8:13 AM Changeset in webkit [30831] by
-
- 4 edits in trunk/WebKit/mac
Remove -[WebScriptDebugger hitStatement:sourceId:line:]
Reviewed by Kevin M.
- WebView/WebCoreScriptDebuggerImp.mm: (WebCoreScriptDebuggerImp::atStatement): Moved code here from -[WebScriptDebugger hitStatement:sourceId:line:].
- WebView/WebScriptDebugDelegate.mm: (-[WebScriptDebugger webFrame]): Added.
- WebView/WebScriptDebugDelegatePrivate.h:
- 8:12 AM Changeset in webkit [30830] by
-
- 7 edits2 deletes in trunk/WebKit
Remove WebCoreScriptDebugger
WebKit:
Remove WebCoreScriptDebugger.{h,mm}
Reviewed by Kevin M.
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
Remove WebCoreScriptDebugger
Reviewed by Kevin M.
- WebView/WebCoreScriptDebugger.h: Removed.
- WebView/WebCoreScriptDebugger.mm: Removed.
- WebView/WebCoreScriptDebuggerImp.h: Replaced WebCoreScriptDebugger with WebScriptDebugger.
- WebView/WebCoreScriptDebuggerImp.mm: Ditto, and replaced [m_debugger delegate] with just m_debugger. (toNSString): Moved here from WebCoreScriptDebugger.mm. (toNSURL): Ditto. (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): (WebCoreScriptDebuggerImp::sourceParsed): (WebCoreScriptDebuggerImp::callEvent): (WebCoreScriptDebuggerImp::atStatement): (WebCoreScriptDebuggerImp::returnEvent): (WebCoreScriptDebuggerImp::exception):
- WebView/WebScriptDebugDelegate.mm: (-[WebScriptDebugger initWithWebFrame:]): _debugger now holds a WebCoreScriptDebuggerImp, so initialize it properly.
- WebView/WebScriptDebugDelegatePrivate.h: Changed _debugger to hold a WebCoreScriptDebuggerImp.
- 8:12 AM Changeset in webkit [30829] by
-
- 5 edits2 adds in trunk/WebKit
Move WebCoreScriptDebuggerImp to its own source files
WebKit:
Move WebCoreScriptDebuggerImp to its own source files
Reviewed by Kevin M.
- WebKit.xcodeproj/project.pbxproj: Added new files to the project.
WebKit/mac:
Move WebCoreScriptDebuggerImp to its own source files
Also changed WebCoreScriptDebuggerImp coding style to match our style
guidelines.
Reviewed by Kevin M.
- WebView/WebCoreScriptDebugger.h: Added declaration of toNSURL function.
- WebView/WebCoreScriptDebugger.mm: Removed WebCoreScriptDebuggerImp implementation. (toNSURL): Made no longer static.
- WebView/WebCoreScriptDebuggerImp.h: Added.
- WebView/WebCoreScriptDebuggerImp.mm: Added. Code was moved here from WebCoreScriptDebugger.mm and cleaned up. (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): (WebCoreScriptDebuggerImp::sourceParsed): (WebCoreScriptDebuggerImp::callEvent): (WebCoreScriptDebuggerImp::atStatement): (WebCoreScriptDebuggerImp::returnEvent): (WebCoreScriptDebuggerImp::exception):
- 8:12 AM Changeset in webkit [30828] by
-
- 5 edits in trunk/WebKit/mac
Move -_enterFrame and -_leaveFrame from WebCoreScriptDebugger to WebScriptDebugger
Reviewed by Kevin M.
- WebView/WebCoreScriptDebugger.h:
- Removed newFrameWithGlobalObject:caller:state: from WebScriptDebugger protocol
- Added enterFrame: and leaveFrame: to WebScriptDebugger protocol
- Removed _current ivar from WebCoreScriptDebugger
- WebView/WebCoreScriptDebugger.mm: (WebCoreScriptDebuggerImp::callEvent): Changed to call enterFrame on the delegate. (WebCoreScriptDebuggerImp::returnEvent): Ditto for leaveFrame.
- WebView/WebScriptDebugDelegate.mm: (-[WebScriptDebugger dealloc]): Added code to release _current. (-[WebScriptDebugger enterFrame:]): Added. Code came from WebCoreScriptDebugger. (-[WebScriptDebugger leaveFrame]): Ditto.
- WebView/WebScriptDebugDelegatePrivate.h: Added _current ivar.
- 4:15 AM Changeset in webkit [30827] by
-
- 2 edits in trunk/WebKit
Name the WebKit build phase script that generates WebKit.LP64.exp.
- WebKit.xcodeproj/project.pbxproj: Name the build phase script that generates the 64-bit export file to match the corresponding build phase script in WebCore.
- 1:40 AM Changeset in webkit [30826] by
-
- 2 edits in trunk/WebCore
Fix 64-bit Mac build.
- 1:24 AM Changeset in webkit [30825] by
-
- 2 edits in trunk/WebCore
Leopard build fix.
Mar 5, 2008:
- 10:26 PM Changeset in webkit [30824] by
-
- 7 edits in trunk
Fix the wx build after the bindings move.
- 10:20 PM Changeset in webkit [30823] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele Peterson.
- fix "background-position: inherit"
- css/CSSStyleSelector.cpp: Made HANDLE_MULTILAYER_INHERIT_AND_INITIAL fall through and added a return statement in HANDLE_MULTILAYER_VALUE. Also removed an unused macro.
- 10:18 PM Changeset in webkit [30822] by
-
- 2 edits in trunk/WebCore
2008-03-05 Alp Toker <alp@atoker.com>
Add a missing make dependency for derived sources to improve
autotools build dependency tracking.
Issue spotted by Ori Bernstein.
- GNUmakefile.am:
- 8:44 PM Changeset in webkit [30821] by
-
- 4 edits in trunk
2008-03-05 Alp Toker <alp@atoker.com>
GTK+ build fix for breakage introduced in r30800.
Track moved bridge sources from JavaScriptCore to WebCore.
- GNUmakefile.am:
- 8:07 PM Changeset in webkit [30820] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Darin.
One part of fix for:
<rdar://problem/5780697> Copying content with percentage based rules in a style sheet will cause fidelity issues
- editing/markup.cpp: (WebCore::appendStartMarkup): Styles from matched rules should take precedence over those in inline style declarations, not the other way around.
LayoutTests:
Reviewed by Darin.
<rdar://problem/5780697> Copying content with CSS property values that are percentages can cause fidelity issues
- editing/pasteboard/5780697-1-expected.txt: Added.
- editing/pasteboard/5780697-1.html: Added.
- 8:02 PM Changeset in webkit [30819] by
-
- 1 edit in trunk/WebKitTools/Scripts/webkitdirs.pm
Another buildbot fix attempt, pass SHELL=/bin/bash
- 7:49 PM Changeset in webkit [30818] by
-
- 2 edits in trunk/WebKitTools
2008-03-05 Alp Toker <alp@atoker.com>
Attempt to get the autotools build working again on the bot with
build-webkit.
Force the use of /bin/bash since we seem to have bash-isms in the
configure script right now.
- Scripts/webkitdirs.pm:
- 6:21 PM Changeset in webkit [30817] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix typo in ChangeLog.
- 6:08 PM Changeset in webkit [30816] by
-
- 6 edits in trunk/WebCore
Reviewed by Darin.
Move JNI specific code from runtime_root over to jni_jsobject, where it is used.
- bridge/jni/jni_jsobject.cpp: (completedJavaScriptAccess): (initializeJavaScriptAccessLock): (lockJavaScriptAccess): (unlockJavaScriptAccess): (dispatchToJavaScriptThread): (performJavaScriptAccess): (JavaJSObject::initializeJNIThreading): (isJavaScriptThread): (JavaJSObject::invoke):
- bridge/jni/jni_jsobject.h:
- bridge/runtime_root.cpp:
- bridge/runtime_root.h:
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge init]):
- 6:05 PM Changeset in webkit [30815] by
-
- 4 edits in trunk/WebCore
Reviewed by Sam.
- add functions giving offsets within a KURL, slated to replace the EncodedURL object in CSSStyleSelector (in a future "visited link" change)
- chagned all KURL data members names to use the traditional m_ prefix
- initialize all members to 0 in invalid KURLs rather than having all functions check m_isValid
- platform/KURL.cpp: (WebCore::KURL::invalidate): Added. Initializes all the fields except for m_string to the "invalid" values. For use in the empty constructor and in the init and parse functions. (WebCore::KURL::init): Tweaked comments. Changed all code paths that return early to use the invalidate() function. Updated for member variable name changes. (WebCore::KURL::hasPath): Updated for member variable name changes. Remove now-unneeded check of m_isValid. (WebCore::KURL::lastPathComponent): Ditto. (WebCore::KURL::protocol): Ditto. (WebCore::KURL::host): Ditto. (WebCore::KURL::port): Ditto. (WebCore::KURL::pass): Ditto. (WebCore::KURL::user): Ditto. (WebCore::KURL::ref): Ditto. (WebCore::KURL::hasRef): Ditto. (WebCore::KURL::protocolIs): Ditto. (WebCore::KURL::query): Ditto. (WebCore::KURL::path): Ditto. (WebCore::KURL::setProtocol): Ditto. (WebCore::KURL::setHost): Ditto. (WebCore::KURL::setPort): Ditto. (WebCore::KURL::setHostAndPort): Ditto. (WebCore::KURL::setUser): Ditto. (WebCore::KURL::setPass): Ditto. (WebCore::KURL::setRef): Ditto. (WebCore::KURL::setQuery): Ditto. (WebCore::KURL::setPath): Ditto. (WebCore::KURL::prettyURL): Ditto. (WebCore::copyPathRemovingDots): Removed braces to match our code style. (WebCore::KURL::parse): Changed all code paths that return early to use the invalidate function. Moved code to set m_isValid to true to the very end of the function. Removed braces to match our code style. Removed an extra copy of the path/query/fragment code (there were two identical copies in the two sides of an if statement). Removed some commented-out code. Reversed an if statment. Added code to set the new m_pathAfterLastSlash field. Updated for member variable name changes. (WebCore::equalIgnoringRef): Updated for member variable name changes. (WebCore::KURL::isHierarchical): Ditto.
- platform/KURL.h: Added a FIXME about ref vs. fragment. Made the empty constructor inline and called the new invalidate function. Added new pathStart, pathEnd, and pathAfterLastSlash functions, for use in the new visited link code. Added an invalidate function. Renamed all the data members to use the m_ prefix.
- WebCore.base.exp: Updated.
- 5:39 PM Changeset in webkit [30814] by
-
- 7 edits in trunk/WebCore
Reviewed by Sam.
- WebCore.xcodeproj/project.pbxproj: Change jni_jsobject.cpp to be Obj-C++ for now. The plan is to merge this with jni_objc.mm and create jni_jsobject.mm.
- bridge/jni/jni_jsobject.cpp: (createRootObject): Move createRootObject here from WebCoreFrameBridge.
(JavaJSObject::createNative):
Call the newly added createRootObject function.
- bridge/runtime_root.cpp: (KJS::Bindings::RootObject::initializeJNIThreading):
- bridge/runtime_root.h: setCreateRootObject no longer takes a root object, rename it to initializeJNIThreading.
- page/mac/FrameMac.mm: (WebCore::Frame::createScriptInstanceForWidget): Just call Frame::createRootObject here.
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge init]): Call initializeJNIThreading.
- 3:52 PM Changeset in webkit [30813] by
-
- 3 edits in trunk/WebCore
Reviewed by Sam.
Change some static class variables to be regular static variables,
making it easier to move the chunk of mac-specific code out of runtime_root.[cpp|h]
- bridge/runtime_root.cpp: (KJS::Bindings::completedJavaScriptAccess): (KJS::Bindings::RootObject::dispatchToJavaScriptThread): (KJS::Bindings::performJavaScriptAccess): (KJS::Bindings::RootObject::createRootObject): (KJS::Bindings::RootObject::runLoop): (KJS::Bindings::RootObject::setCreateRootObject):
- bridge/runtime_root.h:
- 2:44 PM Changeset in webkit [30812] by
-
- 7 edits in trunk
2008-03-05 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
Modify source files to use the USE(SAFARI_THEME) macro, rather than
USE_SAFARI_THEME. (http://bugs.webkit.org/show_bug.cgi?id=17683)
- WebCore/platform/win/PlatformScrollBarSafari.cpp
- WebCore/rendering/RenderThemeSafari.cpp
- WebCore/rendering/RenderThemeSafari.h
- config.h: Move definition of WTF_USE_SAFARI_THEME here
2008-03-05 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
Remove definition of WTF_USE_SAFARI_THEME from wtf/Platform.h
because the PLATFORM(CG) flag is not set until config.h has
already included this file.
- wtf/Platform.h: Remove useless definition of WTF_USE_SAFARI_THEME
- 2:26 PM Changeset in webkit [30811] by
-
- 6 edits2 adds in trunk
Reviewed by Alexey and Mark Rowe
Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html
DatabaseThread::unscheduleDatabaseTasks() manually filters through a MessageQueue,
removing particular items for Databases that were shutting down.
This filtering operation is not atomic, and therefore causes a race condition with the
MessageQueue waking up and reading from the message queue.
The end result was an attempt to dereference a null DatabaseTask. Timing-wise, this never
seemed to happen in a debug build, otherwise an assertion would've caught it. Replacing that
assertion with a crash in a release build is what revealed this bug.
- wtf/MessageQueue.h: (WTF::::waitForMessage): Tweak the waiting logic to check the queue's empty state then go back to sleep if the queue was empty - checking m_killed each time it wakes up.
WebCore:
Reviewed by Alexey and Mark Rowe
Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html
DatabaseThread::unscheduleDatabaseTasks() manually filters through a MessageQueue,
removing particular items for Databases that were shutting down.
This filtering operation is not atomic, and therefore causes a race condition with the
database thread waking up and reading from the message queue.
The end result was an attempt to dereference a null DatabaseTask. Timing-wise, this never
seemed to happen in a debug build, otherwise an assertion would've caught it. Replacing that
assertion with a crash in a release build is what revealed this bug.
The fix for the above symptom was entirely in WTF::MessageQueue in JSCore. With this fix in
place, another crash popped up in the layout tests that was related to dereferencing a
deallocated object - simply because SQLTransaction had a raw pointer to it's Database object
when it needed to be a ref pointer.
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::runCurrentStatement):
- storage/SQLTransaction.h: Change m_database to be a RefPtr (WebCore::SQLTransaction::database):
LayoutTests:
Reviewed by Alexey + Mark Rowe
Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html
This test takes its best shot at handling two databases on a single database thread at once,
then having one of those databases go away completely (garbage collection and everything)
- storage/multiple-databases-garbage-collection-expected.txt: Added.
- storage/multiple-databases-garbage-collection.html: Added.
- 2:20 PM Changeset in webkit [30810] by
-
- 2 edits in trunk/JavaScriptCore
Remove unused header includes from interpreter.cpp.
Reviewed by Darin.
- kjs/interpreter.cpp: Remove unused header includes.
- 2:08 PM Changeset in webkit [30809] by
-
- 2 edits in trunk/WebCore
Build fix. Remove symbol that no longer exists from the exports file.
- 1:51 PM Changeset in webkit [30808] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fixed commit date.
- 12:56 PM Changeset in webkit [30807] by
-
- 2 edits in trunk/WebKitTools
2008-03-05 Alp Toker <alp@atoker.com>
Re-attempt to switch to the autotools build system for GTK+.
Change scripts to continue when distclean fails.
- Scripts/webkitdirs.pm:
- 11:35 AM Changeset in webkit [30806] by
-
- 5 edits in trunk/WebKit/mac
Remove WebCoreScriptCallFrame
Reviewed by Tim.
- WebView/WebCoreScriptDebugger.h:
- Replaced WebCoreScriptCallFrame with WebScriptCallFrame
- Replaced -newWrapperForFrame: with -newFrameWithGlobalObject:caller:state:
- Removed WebCoreScriptCallFrame interface.
- WebView/WebCoreScriptDebugger.mm: Replaced WebCoreScriptCallFrame with WebScriptCallFrame. (-[WebCoreScriptDebugger _enterFrame:]): Changed to call -newFrameWithGlobalObject:caller:state. (-[WebCoreScriptDebugger _leaveFrame]):
- WebView/WebScriptDebugDelegate.h: Changed WebScriptCallFrame's _private ivar to be of type WebScriptCallFramePrivate*.
- WebView/WebScriptDebugDelegate.mm:
- Replaced WebCoreScriptCallFrame with WebScriptCallFrame
- Added WebScriptCallFramePrivate
(-[WebScriptDebugger enteredFrame:sourceId:line:]):
(-[WebScriptDebugger hitStatement:sourceId:line:]):
(-[WebScriptDebugger leavingFrame:sourceId:line:]):
(-[WebScriptDebugger exceptionRaised:sourceId:line:]):
(-[WebScriptCallFramePrivate dealloc]): Added.
(-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Added.
Code came from WebCoreScriptCallFrame.
(-[WebScriptCallFrame dealloc]): Added a call to release the _private
ivar.
(-[WebScriptCallFrame _convertValueToObjcValue:]): Replaced calls to
_private with direct access of _private's ivars.
(-[WebScriptCallFrame caller]): Ditto.
(-[WebScriptCallFrame scopeChain]): Ditto.
(-[WebScriptCallFrame evaluateWebScript:]): Ditto.
- 11:35 AM Changeset in webkit [30805] by
-
- 4 edits in trunk/WebKit/mac
Move -_convertValueToObjcValue to WebScriptCallFrame
Reviewed by Darin.
- WebView/WebCoreScriptDebugger.h: Removed declaration of -_convertValueToObjcValue.
- WebView/WebCoreScriptDebugger.mm: Removed -_convertValueToObjcValue.
- WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame _convertValueToObjcValue:]): Added. Code came from -[WebCoreScriptCallFrame _convertValueToObjcValue]. (-[WebScriptCallFrame scopeChain]): Changed to call -_convertValueToObjcValue on self instead of _private. (-[WebScriptCallFrame exception]): Ditto. (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
- 11:34 AM Changeset in webkit [30804] by
-
- 4 edits in trunk/WebKit/mac
Move -exception and -evaluateWebScript: to WebScriptCallFrame
Reviewed by Darin.
- WebView/WebCoreScriptDebugger.h: Removed declarations of -exception and -evaluateWebScript:.
- WebView/WebCoreScriptDebugger.mm: Removed -exception and -evaluateWebScript:.
- WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame exception]): Added. Code came from -[WebCoreScriptCallFrame exception]. (-[WebScriptCallFrame evaluateWebScript:]): Added. Code came from -[WebCoreScriptCallFrame evaluateWebScript:].
- 11:34 AM Changeset in webkit [30803] by
-
- 4 edits in trunk/WebKit/mac
Move -scopeChain to WebScriptCallFrame
Reviewed by Darin.
- WebView/WebCoreScriptDebugger.h:
- Added declarations of -globalObject and -_convertValueToObjcValue: to WebCoreScriptCallFrame
- Removed declaration of -scopeChain.
- WebView/WebCoreScriptDebugger.mm: Moved -_convertValueToObjcValue within the main WebCoreScriptCallFrame implementation. (-[WebCoreScriptCallFrame globalObject]): Added.
- WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): Added. Code came from -[WebCoreScriptCallFrame scopeChain].
- 11:34 AM Changeset in webkit [30802] by
-
- 4 edits in trunk/WebKit/mac
Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame
Reviewed by Darin.
- WebView/WebCoreScriptDebugger.h:
- Removed #else case of #ifdef cplusplus since this file is only ever used by C++ Objective-C files
- Removed 'using KJS::ExecState' statement since we prefer not to have using statements in header files
- Consequently prefixed uses of ExecState with KJS::
- Added declaration of toNSString method that takes a const UString&
- Added declaration of -[WebCoreScriptCallFrame state]
- Removed declaration of -[WebCoreScriptCallFrame functionName]
- WebView/WebCoreScriptDebugger.mm: (toNSString): Made this no longer static. (-[WebCoreScriptCallFrame state]): Added.
- WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame functionName]): Added. Code came from -[WebCoreScriptCallFrame functionName], though I changed some nested ifs into early returns.
- 11:33 AM Changeset in webkit [30801] by
-
- 8 edits2 moves in trunk
Move WebCoreScriptDebugger up to WebKit
WebCore:
Move WebCoreScriptDebugger up to WebKit
Reviewed by Darin.
- WebCore.base.exp: Exported some functions used by WebCoreScriptDebugger, and sorted the list.
- WebCore.xcodeproj/project.pbxproj: Removed WebCoreScriptDebugger.{h,mm} from the project and marked a few headers private so that WebKit can use them.
- page/mac/WebCoreScriptDebugger.h: Removed.
- page/mac/WebCoreScriptDebugger.mm: Removed.
WebKit:
Move WebCoreScriptDebugger to WebKit
Reviewed by Darin.
- WebKit.xcodeproj/project.pbxproj: Added WebCoreScriptDebugger.{h,mm} to the project.
WebKit/mac:
Move WebCoreScriptDebugger to WebKit
Reviewed by Darin.
- WebView/WebCoreScriptDebugger.h: Renamed from WebCore/page/mac/WebCoreScriptDebugger.h.
- WebView/WebCoreScriptDebugger.mm: Renamed from WebCore/page/mac/WebCoreScriptDebugger.mm. (toNSString): (toNSURL): (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): (WebCoreScriptDebuggerImp::sourceParsed): (WebCoreScriptDebuggerImp::callEvent): (WebCoreScriptDebuggerImp::atStatement): (WebCoreScriptDebuggerImp::returnEvent): (WebCoreScriptDebuggerImp::exception): (+[WebCoreScriptDebugger initialize]): (-[WebCoreScriptDebugger initWithDelegate:]): (-[WebCoreScriptDebugger dealloc]): (-[WebCoreScriptDebugger finalize]): (-[WebCoreScriptDebugger delegate]): (-[WebCoreScriptDebugger _enterFrame:]): (-[WebCoreScriptDebugger _leaveFrame]): (-[WebCoreScriptCallFrame _initWithGlobalObject:caller:state:]): (-[WebCoreScriptCallFrame _setWrapper:]): (-[WebCoreScriptCallFrame _convertValueToObjcValue:]): (-[WebCoreScriptCallFrame dealloc]): (-[WebCoreScriptCallFrame wrapper]): (-[WebCoreScriptCallFrame caller]): (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame exception]): (-[WebCoreScriptCallFrame evaluateWebScript:]):
- WebView/WebScriptDebugDelegate.mm: Updated header path.
- WebView/WebScriptDebugDelegatePrivate.h: Ditto.
- 11:14 AM Changeset in webkit [30800] by
-
- 1 edit1 delete in trunk/JavaScriptCore
Reviewed by Sam.
Remove bindings/.
- bindings: Removed.
- 11:13 AM Changeset in webkit [30799] by
-
- 2 edits in trunk/WebKit/win
Build fix.
- WebKit.vcproj/WebKit.vcproj:
- 11:12 AM Changeset in webkit [30798] by
-
- 2 edits in trunk/WebCore
Build bridge/. Copy some headers over to WebKit as part of the post-build step.
- WebCore.vcproj/WebCore.vcproj:
- 11:11 AM Changeset in webkit [30797] by
-
- 2 edits in trunk/JavaScriptCore
Don't build bindings/ anymore.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 11:04 AM Changeset in webkit [30796] by
-
- 25 edits in trunk
Reviewed by Geoff.
Don't build JavaScriptCore/bindings.
- JavaScriptCore.exp: Export a couple of new functions.
- JavaScriptCore.xcodeproj/project.pbxproj: Remove bindings/
- kjs/config.h: No need to define HAVE_JNI anymore.
- kjs/interpreter.cpp: Remove unnecessary include.
WebCore:
Reviewed by Geoff.
- WebCore.base.exp: Add the NPN and KJS methods.
- WebCore.xcodeproj/project.pbxproj: Bring in bridge/
- config.h: Add HAVE_JNI define.
- bindings/js/kjs_html.cpp:
- bindings/objc/DOMInternal.mm:
- bindings/objc/DOMUtility.mm:
- bindings/objc/WebScriptObject.mm:
- html/HTMLAppletElement.cpp:
- html/HTMLEmbedElement.cpp:
- html/HTMLObjectElement.cpp:
- html/HTMLPlugInElement.cpp:
- page/Frame.cpp:
- page/mac/FrameMac.mm:
- page/mac/WebCoreFrameBridge.mm:
- page/mac/WebCoreScriptDebugger.mm:
- plugins/win/PluginViewWin.cpp: Include file changes.
WebKit/mac:
Reviewed by Geoff.
Include file changes.
- Plugins/WebBaseNetscapePluginView.mm:
- Plugins/WebNetscapePluginPackage.m:
- 10:19 AM Changeset in webkit [30795] by
-
- 3 edits in trunk/JavaScriptCore
Allow override of default script file name using command-line argument.
Reviewed by Adele.
- API/minidom.c: (main): Allow first command-line argument to override the default script file name of "minidom.js".
- API/testapi.c: (main): Allow first command-line argument to override the default script file name of "testapi.js".
- 9:02 AM Changeset in webkit [30794] by
-
- 4 edits in trunk/WebCore
Reviewed by Sam.
Rewrite NPRuntime string conversion routines to use WebCore::String
- bridge/NP_jsobject.cpp: (_NPN_Evaluate):
- bridge/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16WithLatin1Fallback): (KJS::Bindings::convertNPVariantToValue): (KJS::Bindings::convertNPStringToUTF16): (KJS::Bindings::identifierFromNPIdentifier):
- bridge/c/c_utility.h:
- 1:13 AM Changeset in webkit [30793] by
-
- 2 edits in trunk/WebCore
Small performance improvement to putImageData (3-5% on assignment in my tests)
Reviewed by Alexey P
- 12:44 AM Changeset in webkit [30792] by
-
- 2 edits in trunk/WebKitTools
2008-03-05 Alp Toker <alp@atoker.com>
Force qmake for the GTK+ build until we get the build bot to succeed
with autotools (currently dies at make distclean)
- Scripts/webkitdirs.pm:
Mar 4, 2008:
- 11:31 PM Changeset in webkit [30791] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
- bindings/js/JSXMLHttpRequest.h: Remove unnecessary override of toBoolean.
- 11:08 PM Changeset in webkit [30790] by
-
- 4 edits4 adds in trunk
WebCore:
Reviewed by Sam and Oliver.
- fixed http://bugs.webkit.org/show_bug.cgi?id=16289
- fixed Acid3 tests 26 and 27 (not exactly the same issue but related)
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::mark): When marking a node that's in-document, mark the owner document if it hasn't been already. This means holding on to a single node from an unreferenced document now keeps the whole document alive.
We are now at 90/100 on Acid3.
LayoutTests:
Reviewed by Sam and Oliver.
- test for http://bugs.webkit.org/show_bug.cgi?id=16289
- test for Acid3 tests 26 and 27 (not exactly the same issue but related)
- fast/dom/gc-11-expected.txt: Added. Test case from bug 16289.
- fast/dom/gc-11.html: Added.
- fast/dom/gc-acid3.html: Added. DOM garbage collection part of Acid3.
- fast/dom/gc-acid3-expected.txt: Added.
- fast/dom/gc-6-expected.txt: Updated results. The old assumptions of this test were in conflict with the requirements of Acid3.
- 10:54 PM Changeset in webkit [30789] by
-
- 5 edits in trunk/WebKitTools
2008-03-04 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Switch the default GTK+ build system from qmake to autotools.
qmake can still be used by defining WEBKIT_BUILD_SYSTEM=qmake
- Scripts/build-webkit:
- Scripts/run-launcher:
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
- 10:42 PM Changeset in webkit [30788] by
-
- 2 edits in trunk/WebCore
Qt build fix.
- page/qt/FrameQt.cpp:
- 10:17 PM Changeset in webkit [30787] by
-
- 42 edits2 moves in trunk
WebCore:
Reviewed by Mark Rowe.
Rename kjs_window to JSDOMWindowBase.
- Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including JSDOMWindow.h
- ChangeLog:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSCustomVoidCallback.cpp:
- bindings/js/JSCustomXPathNSResolver.cpp:
- bindings/js/JSDOMWindowBase.cpp: Copied from bindings/js/kjs_window.cpp.
- bindings/js/JSDOMWindowBase.h: Copied from bindings/js/kjs_window.h.
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDatabaseCustom.cpp:
- bindings/js/JSEventTargetBase.cpp:
- bindings/js/JSEventTargetBase.h:
- bindings/js/JSEventTargetNode.cpp:
- bindings/js/JSHTMLDocumentCustom.cpp:
- bindings/js/JSHTMLFrameSetElementCustom.cpp:
- bindings/js/JSHistoryCustom.cpp:
- bindings/js/JSLocation.cpp:
- bindings/js/JSSQLTransactionCustom.cpp:
- bindings/js/JSXMLHttpRequest.cpp:
- bindings/js/ScheduledAction.cpp:
- bindings/js/kjs_binding.cpp:
- bindings/js/kjs_events.cpp:
- bindings/js/kjs_navigator.cpp:
- bindings/js/kjs_proxy.cpp:
- bindings/js/kjs_window.cpp: Removed.
- bindings/js/kjs_window.h: Removed.
- bindings/scripts/CodeGeneratorJS.pm:
- history/CachedPage.cpp:
- loader/FrameLoader.cpp:
- page/Chrome.cpp:
- page/InspectorController.cpp:
- page/mac/FrameMac.mm:
- page/mac/WebCoreFrameBridge.mm:
- page/qt/FrameQt.cpp:
- page/win/FrameWin.cpp:
- plugins/win/PluginViewWin.cpp:
WebKit/gtk:
Reviewed by Mark Rowe.
- Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including JSDOMWindow.h
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- webkit/webkitwebframe.cpp:
WebKit/qt:
Reviewed by Mark Rowe.
- Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including JSDOMWindow.h
- Api/qwebframe.cpp: (QWebFrame::addToJSWindowObject):
WebKit/win:
Reviewed by Mark Rowe.
- Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including JSDOMWindow.h
- WebFrame.cpp:
- 8:48 PM Changeset in webkit [30786] by
-
- 3 edits in trunk
Fix the Tiger build.
- 8:40 PM Changeset in webkit [30785] by
-
- 2 edits in trunk/WebKit/qt
Another go at fixing the Qt build.
- 8:34 PM Changeset in webkit [30784] by
-
- 2 edits in trunk/WebKitSite
Update link to Windows Platform SDK to its new location.
- 8:22 PM Changeset in webkit [30783] by
-
- 2 edits in trunk/WebCore
Speculative Qt build fix.
- 6:14 PM Changeset in webkit [30782] by
-
- 28 edits in trunk/WebCore
Reviewed by Sam.
Update include paths. This code is not used yet.
- bridge/NP_jsobject.cpp:
- bridge/c/c_class.cpp:
- bridge/c/c_instance.cpp:
- bridge/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16WithLatin1Fallback): #if 0 this out for now.
- bridge/jni/jni_class.cpp:
- bridge/jni/jni_jsobject.cpp:
- bridge/jni/jni_objc.mm:
- bridge/jni/jni_runtime.cpp:
- bridge/jni/jni_utility.cpp:
- bridge/jni/jni_utility.h:
- bridge/npruntime.cpp:
- bridge/objc/WebScriptObject.h:
- bridge/objc/objc_class.h:
- bridge/objc/objc_instance.h:
- bridge/objc/objc_runtime.h:
- bridge/objc/objc_utility.h:
- bridge/objc/objc_utility.mm:
- bridge/runtime.cpp:
- bridge/runtime.h:
- bridge/runtime_array.cpp:
- bridge/runtime_array.h:
- bridge/runtime_method.cpp:
- bridge/runtime_method.h:
- bridge/runtime_object.cpp:
- bridge/runtime_object.h:
- bridge/runtime_root.cpp:
- bridge/runtime_root.h:
- 6:09 PM Changeset in webkit [30781] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=17676 <rdar://problem/5781091> REGRESSION (r30240-r30267): href attribute values with non-ASCII characters in the host part do not work
Test: fast/encoding/url-host-name-non-ascii.html
- platform/KURL.cpp: (WebCore::appendEncodedHostname): Added an early return in the all-ASCII case to avoid copying the host name twice and corrected the error checking after calling uidna_IDNToASCII().
LayoutTests:
- test for http://bugs.webkit.org/show_bug.cgi?id=17676 <rdar://problem/5781091> REGRESSION (r30240-r30267): href attribute values with non-ASCII characters in the host part do not work
- fast/encoding/url-host-name-non-ascii-expected.txt: Added.
- fast/encoding/url-host-name-non-ascii.html: Added.
- 5:21 PM Changeset in webkit [30780] by
-
- 1 edit in trunk/WebCore/platform/network/mac/ResourceHandleMac.mm
Fix the Tiger build.
- 5:02 PM Changeset in webkit [30779] by
-
- 4 edits in trunk/WebCore
Reviewed by Dan Bernstein.
Use JSDOMWindow exclusively instead of JSDOMWindowBase.
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- bindings/js/ScheduledAction.h:
- bindings/js/kjs_window.cpp: (WebCore::JSDOMWindowBase::timerFired):
- 4:57 PM Changeset in webkit [30778] by
-
- 13 edits5 adds in trunk
WebCore:
Reviewed by Darin Adler.
<rdar://problem/5720160> Browser windows "do nothing" while modal
dialog or menu is up due to run loop modes (or while scrolling)
Adds a new SchedulePair object that holds a runloop and the mode to use.
A HashSet of SchedulePairs is tracked by Page so it can be used for resource
loading and, in the future, maybe SharedTimerMac.
- WebCore.base.exp: Add new exports for WebKit.
- WebCore.xcodeproj/project.pbxproj: Add new files.
- loader/mac/DocumentLoaderMac.cpp: Added. (WebCore::scheduleAll): Call schedule all the ResourceLoader handles. (WebCore::unscheduleAll): Call unschedule all the ResourceLoader handles. (WebCore::DocumentLoader::schedule): Schedule all the ResourceLoaders owned by the DocumentLoader. (WebCore::DocumentLoader::unschedule): Unschedule all the ResourceLoaders owned by the DocumentLoader.
- loader/DocumentLoader.h:
- page/Page.h: (WebCore::Page::scheduledRunLoopPairs): Return m_scheduledRunLoopPairs.
- page/mac/PageMac.cpp: (WebCore::Page::addSchedulePair): Add a SchedulePair to m_scheduledRunLoopPairs. (WebCore::Page::removeSchedulePair): Removes a SchedulePair from m_scheduledRunLoopPairs.
- platform/cf/SchedulePair.cpp: Added.
- platform/cf/SchedulePair.h: Added.
- platform/mac/SchedulePairMac.mm: Added.
- platform/network/ResourceHandle.h:
- platform/network/mac/FormDataStreamMac.mm: (WebCore::advanceCurrentStream): Use the new SchedulePair. (WebCore::formCreate): Ditto. (WebCore::formFinalize): Ditto. (WebCore::formSchedule): Ditto. (WebCore::formUnschedule): Ditto.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Schedule the connection with all the SchedulePairs that Page holds. If Page has no SchedulePairs, schedule with the current runloop, and pick the mode based on ResourceHandle::loadsDuringCommonRunLoopModes. (WebCore::ResourceHandle::schedule): (WebCore::ResourceHandle::unschedule):
WebKit/mac:
Reviewed by Darin Adler.
<rdar://problem/5720160> Browser windows "do nothing" while modal
dialog or menu is up due to run loop modes (or while scrolling)
Add new API that lets a WebView be scheduled with multiple runloops and modes.
This lets loading continue when in a nested runloop or in a different mode.
- Misc/WebKitVersionChecks.h: Add a new version define: WEBKIT_FIRST_VERSION_WITH_LOADING_DURING_COMMON_RUNLOOP_MODES.
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Schedule in the main runloop and with the default runloop mode if we are linked on an earlier WebKit version, use common modes otherwise. (-[WebView scheduleInRunLoop:forMode:]): New API, that calls through to Page. (-[WebView unscheduleFromRunLoop:forMode:]): Ditto.
- WebView/WebViewPrivate.h: Add the new pending API methods.
- 4:53 PM Changeset in webkit [30777] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Eric.
Fix svg/dynamic-updates time-dependancy problem. Remove unneeded setTimeout() call.
- 4:28 PM Changeset in webkit [30776] by
-
- 10 edits2 moves in trunk/WebCore
Reviewed by Darin Adler.
Rename kjs_css to JSRGBColor.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSRGBColor.cpp: Copied from bindings/js/kjs_css.cpp.
- bindings/js/JSRGBColor.h: Copied from bindings/js/kjs_css.h.
- bindings/js/kjs_css.cpp: Removed.
- bindings/js/kjs_css.h: Removed.
- bindings/js/kjs_window.cpp:
- bindings/objc/DOMUtility.mm:
- bindings/scripts/CodeGeneratorJS.pm:
- 4:08 PM Changeset in webkit [30775] by
-
- 2 edits in trunk/WebCore
Fix 64-bit build.
- html/HTMLPlugInElement.cpp:
- 4:05 PM Changeset in webkit [30774] by
-
- 3 edits in trunk/WebKit/win
WebScriptDebugServer cleanup
Reviewed by Anders.
- WebScriptDebugServer.cpp: Renamed m_callingServer to m_callingListeners. (WebScriptDebugServer::WebScriptDebugServer): (WebScriptDebugServer::sharedWebScriptDebugServer): Changed to keep the shared instance as a function-level static. (WebScriptDebugServer::didLoadMainResourceForDataSource): Made return void. (WebScriptDebugServer::sourceParsed): (WebScriptDebugServer::callEvent): (WebScriptDebugServer::atStatement): (WebScriptDebugServer::returnEvent): (WebScriptDebugServer::exception): (WebScriptDebugServer::serverDidDie): Made return void.
- WebScriptDebugServer.h:
- Removed unnecessary #includes
- Made inheritance from KJS::Debugger private
- Made some methods private
- 4:04 PM Changeset in webkit [30773] by
-
- 4 edits2 deletes in trunk/WebKit/win
Remove WebScriptDebugger
Reviewed by Anders.
- WebKit.vcproj/WebKit.vcproj: Removed files from project.
- WebScriptDebugServer.cpp: (frame): Moved here from WebScriptDebugger.cpp. (webFrame): Ditto. (webView): Ditto. (WebScriptDebugServer::WebScriptDebugServer): Initialize new member.
- WebScriptDebugServer.h: Changed to inherit directly from KJS::Debugger instead of from WebScriptDebugger, and added m_callingServer member that WebScriptDebugger used to own.
- WebScriptDebugger.cpp: Removed.
- WebScriptDebugger.h: Removed.
- 4:04 PM Changeset in webkit [30772] by
-
- 5 edits in trunk/WebKit/win
Move sourceParsed to WebScriptDebugServer
Reviewed by Anders.
- WebScriptDebugServer.cpp: (WebScriptDebugServer::sourceParsed): Moved here from WebScriptDebugger and merged with didParseSource/failedToParseSource.
- WebScriptDebugServer.h: Removed didParseSource/failedToParseSource.
- WebScriptDebugger.cpp: Removed sourceParsed.
- WebScriptDebugger.h: Ditto.
- 4:04 PM Changeset in webkit [30771] by
-
- 7 edits1 add in trunk
Move callEvent, returnEvent, and exception to WebScriptDebugServer
WebCore:
Add ExecState.h to ForwardingHeaders
Reviewed by Anders.
- ForwardingHeaders/kjs/ExecState.h: Added.
- page/Page.cpp: Touch this to force WebCore to build and the headers to be copied.
WebKit/win:
Move callEvent, returnEvent, and exception to WebScriptDebugServer
Reviewed by Anders.
- WebScriptDebugServer.cpp: (WebScriptDebugServer::callEvent): Moved here from WebScriptDebugger and merged with didEnterCallFrame. (WebScriptDebugServer::returnEvent): Ditto for willLeaveCallFrame. (WebScriptDebugServer::exception): Ditto for exceptionWasRaised.
- WebScriptDebugServer.h: Removed didEnterCallFrame, willLeaveCallFrame, and exceptionWasRaised.
- WebScriptDebugger.cpp: Removed callEvent, returnEvent, and exception.
- WebScriptDebugger.h: Ditto.
- 4:03 PM Changeset in webkit [30770] by
-
- 5 edits in trunk/WebKit/win
Move atStatement to WebScriptDebugServer
Reviewed by Anders.
- WebScriptDebugServer.cpp: (WebScriptDebugServer::atStatement): Moved here and merged with the old willExecuteStatement method.
- WebScriptDebugServer.h: Removed inheritance from IWebScriptDebugListener, which no one was relying on.
- WebScriptDebugger.cpp: (webFrame): Made non-static. (webView): Ditto.
- WebScriptDebugger.h: Added declarations of webFrame and webView methods for WebScriptDebugServer's benefit. Removed unused m_webView and m_frame members.
- 4:02 PM Changeset in webkit [30769] by
-
- 5 edits in trunk/WebKit/win
Start to merge WebScriptDebugger and WebScriptDebugServer
WebScriptDebugServer now inherits from WebScriptDebugger.
Reviewed by Anders.
- WebScriptDebugServer.cpp: (WebScriptDebugServer::pageCreated): Use sharedWebScriptDebugServer instead of WebScriptDebugger::shared. (WebScriptDebugServer::addListener): Ditto. (WebScriptDebugServer::removeListener): Ditto.
- WebScriptDebugServer.h: Changed to inherit from WebScriptDebugger.
- WebScriptDebugger.cpp: Removed shared method.
- WebScriptDebugger.h: Made constructor/destructor protected, and removed shared method.
- 3:43 PM Changeset in webkit [30768] by
-
- 2 edits in trunk/JavaScriptCore
Mac build fix. Add new symbol to exports file.
- 3:21 PM Changeset in webkit [30767] by
-
- 7 edits11 adds in trunk
Reviewed by Eric & David.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=17078
Fix getSubStringLength() handling, verified by Acid3 test 77.
Brings up Acid3 score to 88/100.
Added test: svg/custom/acid3-test-77.html
svg/custom/getSubStringLength.html
- 3:07 PM Changeset in webkit [30766] by
-
- 3 edits in trunk/WebCore
Mac build fix. Neither me, Sam nor Adam know why we need to do this though :(
- bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::attachDebugger):
- page/Page.cpp: (WebCore::Page::setDebuggerForAllPages): (WebCore::Page::setDebugger):
- 2:35 PM Changeset in webkit [30765] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin.
Fix crash that happens when trying to load a page with a Java applet.
- WebCoreSupport/WebFrameLoaderClient.mm: Don't release the names and values array - the kit method returns an autoreleased array.
- 2:26 PM Changeset in webkit [30764] by
-
- 15 edits1 add in trunk
Move debugger-attaching code from WebKit/win to WebCore
WebCore:
Make it possible to set a KJS::Debugger on all Frames in a Page and
all Pages in the process
Reviewed by Kevin M.
- ForwardingHeaders/kjs/debugger.h: Added.
- bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScript): Attach the Page's debugger if there is one. (WebCore::KJSProxy::attachDebugger): Attach the passed-in debugger, or detach any existing debugger if none was passed in.
- bindings/js/kjs_proxy.h:
- page/Page.cpp: (WebCore::Page::Page): Initialize new member. (WebCore::Page::setDebuggerForAllPages): Call setDebugger on each Page in the process. (WebCore::Page::setDebugger): Store the debugger and pass it off to all our Frames.
- page/Page.h:
WebKit/win:
Use WebCore's new debugger-attaching code
Reviewed by Kevin M.
- WebCoreSupport/WebFrameLoaderClient.cpp: Moved a kit() function to WebView.{cpp,h} so that other files can call it.
- WebFrame.cpp: (WebFrame::WebFrame): Removed m_scriptDebugger member. (WebFrame::windowObjectCleared): Removed attach/detach calls. This is no longer needed because WebScriptDebugger no longer stores any per-WebFrame state.
- WebFrame.h:
- WebScriptDebugServer.cpp: (WebScriptDebugServer::pageCreated): Added. Attaches our shared debugger to the Page if we have any listeners. (WebScriptDebugServer::addListener): Sets our shared debugger for all Pages when we get our first listener. (WebScriptDebugServer::removeListener): Removes our shared debugger from all Pages when we lose our last listener.
- WebScriptDebugServer.h:
- WebScriptDebugger.cpp: (WebScriptDebugger::shared): Added. (WebScriptDebugger::WebScriptDebugger): Removed m_frame member. (WebScriptDebugger::~WebScriptDebugger): Added. (frame): Gets a Frame from an ExecState. (webFrame): Gets a WebFrame from an ExecState. (webView): Gets a WebView from an ExecState. (WebScriptDebugger::sourceParsed): Changed to call webFrame() and webView() instead of using m_frame and m_webView members. (WebScriptDebugger::callEvent): Ditto. (WebScriptDebugger::atStatement): Ditto. (WebScriptDebugger::returnEvent): Ditto. (WebScriptDebugger::exception): Ditto.
- WebScriptDebugger.h:
- WebView.cpp: (kit): Moved here from WebFrameLoaderClient.cpp. (WebView::initWithFrame): Tell the WebScriptDebugServer about the new Page so it can attach a debugger if needed.
- WebView.h:
- 2:05 PM Changeset in webkit [30763] by
-
- 19 edits in trunk
WebCore:
Reviewed by Darin Adler.
Add ClassInfo to custom constructors so that they toString properly
- Take this chance to remove the "Imp" from the end of JSXMLHttpRequestConstructorImp, and XSLTProcessorConstructorImp and prefix all the classes with JS.
- bindings/js/JSAudioConstructor.cpp: (WebCore::): Added ClassInfo definition. (WebCore::JSAudioConstructor::JSAudioConstructor): (WebCore::JSAudioConstructor::construct): Cleanup.
- bindings/js/JSAudioConstructor.h: Rename m_doc to m_document. (WebCore::JSAudioConstructor::classInfo): Added.
- bindings/js/JSHTMLInputElementBase.cpp: Rename HTMLInputElementBasePrototype to JSHTMLInputElementBasePrototype as seen if toString'ed. (WebCore::):
- bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::): Added ClassInfo definition.
- bindings/js/JSHTMLOptionElementConstructor.h: (WebCore::JSHTMLOptionElementConstructor::classInfo): Added.
- bindings/js/JSImageConstructor.cpp: (WebCore::): Added ClassInfo definition. (WebCore::JSImageConstructor::implementsConstruct): Moved here from header.
- bindings/js/JSImageConstructor.h: (WebCore::JSImageConstructor::classInfo): Added.
- bindings/js/JSXMLHttpRequest.cpp: (WebCore::): Rename XMLHttpRequestPrototype to JSXMLHttpRequestPrototype as seen if toString'ed. (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): (WebCore::JSXMLHttpRequestConstructor::implementsConstruct): (WebCore::JSXMLHttpRequestConstructor::construct):
- bindings/js/JSXMLHttpRequest.h: Renamed JSXMLHttpRequestConstructorImp to JSXMLHttpRequestConstructor and doc to m_document and (WebCore::JSXMLHttpRequestConstructor::classInfo): Added.
- bindings/js/JSXSLTProcessor.cpp: (WebCore::): Renamed XSLTProcessorPrototype to JSXSLTProcessorPrototype and XSLTProcessorConstructorImp to JSXSLTProcessorConstructor. (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor): (WebCore::JSXSLTProcessorConstructor::implementsConstruct): (WebCore::JSXSLTProcessorConstructor::construct):
- bindings/js/JSXSLTProcessor.h: (WebCore::JSXSLTProcessorConstructor::classInfo): Added.
- bindings/js/kjs_window.cpp: (WebCore::JSDOMWindowBase::getValueProperty): Fixed to work with the new class names.
WebKitTools:
Reviewed by Darin Adler.
- Scripts/do-webcore-rename: Update renaming plan.
LayoutTests:
Reviewed by Darin Adler.
Update results for fixed class names.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/xmlhttprequest-get-expected.txt:
- http/tests/xmlhttprequest/event-target-expected.txt:
- 1:12 PM Changeset in webkit [30762] by
-
- 5 edits in trunk
WebCore:
Reviewed by Oliver Hunt and Geoffrey Garen.
- fix http://bugs.webkit.org/show_bug.cgi?id=17667 <rdar://problem/5779658> REGRESSION (r30587): Document::implicitClose() not called when done loading page (Image does not get scaled to fit)
- loader/loader.cpp: (WebCore::Loader::didFinishLoading): Changed to call setLoadInProgress(false) even for 4xx errors, because that triggers load completion check.
LayoutTests:
Reviewed by Oliver Hunt and Geoffrey Garen.
- extended test to cover http://bugs.webkit.org/show_bug.cgi?id=17667 <rdar://problem/5779658> REGRESSION (r30587): Document::implicitClose() not called when done loading page (Image does not get scaled to fit)
- http/tests/misc/missing-style-sheet-expected.txt:
- http/tests/misc/missing-style-sheet.html:
- 1:09 PM Changeset in webkit [30761] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Beth.
Fix for <rdar://problem/5779718> focus() does not work for anchor elements with no content
If an anchor has zero size, don't exclude it from being focusable from JS, just exclude it
from being keyboard focusable (using the tab key).
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isFocusable): (WebCore::HTMLAnchorElement::isKeyboardFocusable):
LayoutTests:
Reviewed by Beth.
Test for <rdar://problem/5779718> focus() does not work for anchor elements with no content
- fast/events/anchor-empty-focus-expected.txt: Added.
- fast/events/anchor-empty-focus.html: Added.
- 11:36 AM Changeset in webkit [30760] by
-
- 2 edits in trunk/WebCore
<rdar://problem/5119360> ER - Seed: Google results do not have AXHeading information
Make headers appear in AX regardless of whether they have BlockFlow renderers or not
Reviewed by Darin Adler.
- page/mac/WebCoreAXObject.mm:
(headingLevel): no longer ignores BlockFlow rendered headers
(-[WebCoreAXObject accessibilityIsIgnored]): does not ignore headers
- 11:15 AM Changeset in webkit [30759] by
-
- 1 edit1 add in trunk/BugsSite
- PrettyPatch/PrettyPatch.rb: Allow the extent of the previous file to be omitted from the hunk header.
- 9:59 AM Changeset in webkit [30758] by
-
- 2 edits in trunk/WebKit/win
Change WebView's string-finding methods to call through to Page
These methods were added to Page back in r28878 (and the
implementation was copied from WebView!) but we never switched over to
using them.
Reviewed by Sam.
- WebView.cpp: (WebView::searchFor): Call through to Page::findString. (WebView::markAllMatchesForText): Call through to Page. (WebView::unmarkAllTextMatches): Ditto.
- 9:57 AM Changeset in webkit [30757] by
-
- 2 edits in trunk/WebCore
GTK+ build fix.
- GNUmakefile.am:
- 9:46 AM Changeset in webkit [30756] by
-
- 9 edits2 copies in trunk/WebCore
Reviewed by Darin Adler.
Remame ImageConstructorImp to JSImageConstructor and move it into its
own file.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSImageConstructor.cpp: Copied from bindings/js/kjs_html.cpp. (WebCore::JSImageConstructor::JSImageConstructor): (WebCore::JSImageConstructor::construct):
- bindings/js/JSImageConstructor.h: Copied from bindings/js/kjs_html.h.
- bindings/js/kjs_html.cpp: (WebCore::getRuntimeObject): Make this function static since it is only used in this file.
- bindings/js/kjs_html.h:
- bindings/js/kjs_window.cpp: (WebCore::JSDOMWindowBase::getValueProperty):
- 9:24 AM Changeset in webkit [30755] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Adam.
- fix 200+ failing regression tests
- fix http://bugs.webkit.org/show_bug.cgi?id=17668 Vertical scrollbar at slashdot.org is randomly not shown
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Changed the refcounting code here to exactly match the way it was before it was moved from WebCore. I had introduced a storage leak and that was causing problems with scroll bars!
- 9:21 AM Changeset in webkit [30754] by
-
- 2 edits in trunk/WebCore
Fix an uninitialized value warning in CodeGeneratorJS.pm
- bindings/scripts/CodeGeneratorJS.pm: Remove reference to non-existent $maybeOkParam (this was removed in r30753).
- 9:02 AM Changeset in webkit [30753] by
-
- 35 edits2 deletes in trunk/WebCore
Reviewed by Darin Adler.
Remove kjs_dom.{h,cpp}.
- Removed custom toAttr, which took a boolean ok, and teach CodeGeneratorJS.pm to us a null return value as an indication of failure. (This new logic is used for toVoidCallback as well.)
- Move getRuntimeObject to kjs_html where a bunch of other runtime object related functions currently live.
- Move checkNodeSecurity to kjs_binding, where other frame security functions currently live.
- Remove getNodeConstructor. It had no implementation.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSAttrCustom.cpp:
- bindings/js/JSCustomVoidCallback.cpp: (WebCore::toVoidCallback):
- bindings/js/JSCustomVoidCallback.h:
- bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
- bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttributeNode): (WebCore::JSElement::setAttributeNodeNS):
- bindings/js/JSEventTargetBase.cpp: (WebCore::toJS):
- bindings/js/JSEventTargetBase.h:
- bindings/js/JSHTMLAppletElementCustom.cpp:
- bindings/js/JSHTMLElementCustom.cpp:
- bindings/js/JSHTMLEmbedElementCustom.cpp:
- bindings/js/JSHTMLFormElementCustom.cpp:
- bindings/js/JSHTMLFrameElementCustom.cpp:
- bindings/js/JSHTMLIFrameElementCustom.cpp:
- bindings/js/JSHTMLObjectElementCustom.cpp:
- bindings/js/JSNamedNodeMapCustom.cpp:
- bindings/js/JSNamedNodesCollection.cpp:
- bindings/js/JSNodeFilterCustom.cpp:
- bindings/js/JSXSLTProcessor.cpp:
- bindings/js/kjs_binding.cpp: (WebCore::checkNodeSecurity):
- bindings/js/kjs_binding.h:
- bindings/js/kjs_css.cpp:
- bindings/js/kjs_dom.cpp: Removed.
- bindings/js/kjs_dom.h: Removed.
- bindings/js/kjs_events.cpp:
- bindings/js/kjs_html.cpp: (WebCore::getRuntimeObject):
- bindings/js/kjs_html.h:
- bindings/js/kjs_window.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Attr.idl:
- html/HTMLPlugInElement.cpp:
- page/InspectorController.cpp:
- 9:00 AM Changeset in webkit [30752] by
-
- 2 edits in trunk/WebKit/win
Actually pause the process while Drosera is at a breakpoint
WebScriptDebugServer::suspendProcessIfPaused is supposed to pause the
process while Drosera is at a breakpoint. Previously we were just
starting a message pump that would deliver messages to all windows in
the process, allowing mouse events, JS timers, etc. to execute.
Now we only deliver messages to COM's message window, which is all we
need to allow RPC to function.
Reviewed by Anders.
- WebScriptDebugServer.cpp: (comMessageWindow): Added. Finds COM's message window. (WebScriptDebugServer::suspendProcessIfPaused): Only deliver messages to COM's message window so that mouse events, JS timers, etc., won't execute.
- 9:00 AM Changeset in webkit [30751] by
-
- 5 edits in trunk/WebKit/win
Generate WebScriptCallFrame instances dynamically
WebScriptDebugger no longer holds a reference to the topmost call
frame, and WebScriptCallFrame no longer holds a reference to its
caller. We now generate WebScriptCallFrame instances as needed by
walking the callingExecState chain.
By making WebKit no longer responsible for keeping track of the call
stack, we get one step closer to moving most JS debugging code out of
WebKit entirely.
This incidentally fixes a bug in Drosera where we'd never show the
global scope in the call stack.
Reviewed by Sam and Kevin M.
- WebScriptCallFrame.cpp:
(callingFunctionOrGlobalExecState): Finds the nearest calling
ExecState that is a FunctionExecState or GlobalExecState, if any, and
returns it.
(WebScriptCallFrame::WebScriptCallFrame):
- No longer takes a caller parameter.
- Sets m_state to the callingFunctionOrGlobalExecState of the ExecState passed in.
(WebScriptCallFrame::createInstance): Removed the caller parameter.
(WebScriptCallFrame::caller): Generate a new WebScriptCallFrame on the
fly from our ExecState.
- WebScriptCallFrame.h: No longer holds a reference to the caller.
- WebScriptDebugger.cpp: (WebScriptDebugger::WebScriptDebugger): Removed the call to callEvent that was supposed to set up the global scope call frame, but never worked because m_callingServer was set to true, which would cause callEvent to return early without doing anything. Also removed the m_callingServer guards since we're not calling callEvent anymore. (WebScriptDebugger::callEvent): Create a WebScriptCallFrame on the fly from the passed-in ExecState. (WebScriptDebugger::atStatement): Ditto. (WebScriptDebugger::returnEvent): Ditto, but use the callingExecState. This is equivalent to what calling leaveFrame() did before. (WebScriptDebugger::exception): Ditto, using the passed-in ExecState.
- WebScriptDebugger.h: Removed m_topStackFrame member and enterFrame/leaveFrame methods.
- 8:59 AM Changeset in webkit [30750] by
-
- 5 edits in trunk/WebCore
Win/Qt/GTK+/wx build fix after r30740
- editing/Editor.cpp: Added missing #include.
- page/qt/FrameQt.cpp: Removed Frame::dashboardRegionsChanged.
- page/win/FrameWin.cpp: Ditto.
- platform/wx/TemporaryLinkStubs.cpp: Ditto.
- 8:57 AM Changeset in webkit [30749] by
-
- 2 edits in trunk/WebCore
2008-03-04 Alp Toker <alp@atoker.com>
GTK+ build fix for breakage introduced in r30740.
Remove Frame::dashboardRegionsChanged(). There's now a default
implementation at ChromeClient::dashboardRegionsChanged().
- page/gtk/FrameGtk.cpp:
- 8:49 AM Changeset in webkit [30748] by
-
- 2 edits in trunk/WebCore
2008-03-04 Alp Toker <alp@atoker.com>
GTK+ build fix suggested by aroben. Remove an unused Mac-specific
included introduced in r30740.
- page/ChromeClient.h:
- 8:03 AM Changeset in webkit [30747] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix <rdar://problem/5622336> Burmese text does not render on http://www.myanmarbible.com/bible/Judson/html/index.html
Test: platform/win/fast/text/uniscribe-missing-glyph.html
Note that default installations of Windows do not have Myanmar fonts.
What this patch does is ensure that the Myanmar and other complex
scripts are rendered as missing glyphs rather than not rendered at all.
The particular page in the bug measures the relative widths of two
rendered strings and, if they are rendered as missing glyphs, detects
that a Myanmar fonts is not available and substitutes the text with
images. By not rendering (and measuring) missing glyphs, WebKit was
throwing the page's detection code off.
- platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::shape): Removed an early return in case shaping resulted in missing glyphs. This is now expected if font fallback failed to produce a font containing glyphs for the character. Also changed two resize()s to shrink()s.
LayoutTests:
- test for <rdar://problem/5622336> Burmese text does not render on http://www.myanmarbible.com/bible/Judson/html/index.html
- platform/win/fast/text/uniscribe-missing-glyph-expected.txt: Added.
- platform/win/fast/text/uniscribe-missing-glyph.html: Added.
- 7:34 AM Changeset in webkit [30746] by
-
- 6 edits in trunk
WebCore:
Reviewed by Adam.
- remove WebCoreFrameBridge reapplyStyles method
- WebCore.base.exp: Added exports.
- page/mac/WebCoreFrameBridge.h: Removed WebCoreDeviceType and reapplyStylesForDeviceType: method.
- page/mac/WebCoreFrameBridge.mm: Ditto.
WebKit/mac:
Reviewed by Adam.
- remove WebCoreFrameBridge reapplyStyles method
- WebView/WebHTMLView.mm: (-[WebHTMLView reapplyStyles]): Moved code to reapply styles here from the bridge.
- 7:29 AM Changeset in webkit [30745] by
-
- 6 edits in trunk
WebCore:
Reviewed by Adam.
- eliminate WebCoreFrameBridge createFrameViewWithNSView
- WebCore.base.exp: Added some more exports.
- page/mac/WebCoreFrameBridge.h: Deleted createFrameViewWithNSView.
- page/mac/WebCoreFrameBridge.mm: Ditto.
WebKit/mac:
Reviewed by Adam.
- eliminate WebCoreFrameBridge createFrameViewWithNSView
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Moved code here from createFrameViewWithNSView.
- 7:24 AM Changeset in webkit [30744] by
-
- 6 edits in trunk
WebCore:
Reviewed by Adam.
- removed WebCoreFrameBridge scrollOverflowInDirection
- WebCore.base.exp: Export function needed by WebKit.
- page/mac/WebCoreFrameBridge.h: Removed WebScrollDirection, WebScrollGranularity, and scrollOverflowInDirection.
- page/mac/WebCoreFrameBridge.mm: Removed method.
WebKit/mac:
Reviewed by Adam.
- removed WebCoreFrameBridge scrollOverflowInDirection
- WebView/WebFrameView.mm: (-[WebFrameView _scrollOverflowInDirection:granularity:]): Changed to call EventHandler directly instead of using the bridge. (-[WebFrameView scrollToBeginningOfDocument:]): Updated to use WebCore enums instead of the ones from the bridge. (-[WebFrameView scrollToEndOfDocument:]): Ditto. (-[WebFrameView _pageVertically:]): Ditto. (-[WebFrameView _pageHorizontally:]): Ditto. (-[WebFrameView _scrollLineVertically:]): Ditto. (-[WebFrameView _scrollLineHorizontally:]): Ditto.
- 7:21 AM Changeset in webkit [30743] by
-
- 9 edits in trunk
WebCore:
Reviewed by Adam.
- remove WebCoreFrameBridge installInFrame: method
- WebCore.base.exp: Export a few symbols.
- WebCore.xcodeproj/project.pbxproj: Export a few files.
- page/mac/WebCoreFrameBridge.h: Remove installInFrame:.
- page/mac/WebCoreFrameBridge.mm: Ditto.
WebKit/mac:
Reviewed by Adam.
- remove WebCoreFrameBridge installInFrame: method
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Call -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
- WebView/WebFrameView.mm: (-[WebFrameView _install]): Added. Has code from -[WebCoreFrameBridge installInFrame:]. (-[WebFrameView _setCustomScrollViewClass:]): Used early return idiom so the entire method isn't nested inside an if statement. Call -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
- WebView/WebFrameViewInternal.h: Added declaration of _install method so it can be used in WebFrameLoaderClient.mm.
- 7:20 AM Changeset in webkit [30742] by
-
- 5 edits in trunk
WebCore:
Reviewed by Adam.
- remove WebCoreFrameBridge window method
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): Get the window by calling window on the NSView instead of using the bridge. The WebKit side wasn't doing anything special, so a call to -[NSView window] is fine.
- page/mac/WebCoreFrameBridge.h: Removed the window method.
WebKit/mac:
Reviewed by Adam.
- remove WebCoreFrameBridge window method
- WebCoreSupport/WebFrameBridge.mm: Removed window method.
- 7:17 AM Changeset in webkit [30741] by
-
- 4 edits in trunk/WebKit/mac
Reviewed by Adam.
- move code from WebFrameBridge into WebFrameLoaderClient
- WebCoreSupport/WebFrameBridge.h: Removed unused fields, changed frame name parameters to use WebCore::String instead of NSString, add initSubframeWithOwnerElement declaration, removed viewForPluginWithFrame, viewForJavaAppletWithFrame, createChildFrameNamed, redirectDataToPlugin, determineObjectFromMIMEType, and windowObjectCleared methods.
- WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]): Changed to use WebCore::String. (-[WebFrameBridge initMainFrameWithPage:frameName:WebCore::frameView:]): Ditto. (-[WebFrameBridge initSubframeWithOwnerElement:frameName:WebCore::frameView:]): Ditto.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setOriginalURLForDownload): Removed some dead code I found here and added a FIXME. (WebFrameLoaderClient::createFrame): Moved the code from WebFrameBridge here. (WebFrameLoaderClient::objectContentType): Ditto. (parameterValue): Added. Helper function, based on code originally in WebFrameBridge. (pluginView): Ditto. (WebFrameLoaderClient::createPlugin): Moved the code from WebFrameBridge here.
- 7:10 AM Changeset in webkit [30740] by
-
- 13 edits in trunk
WebCore:
Reviewed by Adam.
- remove -[WebCoreFrameBridge dashboardRegionsChanged:]
- WebCore.base.exp: Updated.
- page/Chrome.cpp: (WebCore::ChromeClient::dashboardRegionsChanged): Added.
- page/ChromeClient.h: Added virtual function for dashboardRegionsChanged.
- page/Frame.h: Removed dashboardRegionsChanged function.
- page/FrameView.cpp: (WebCore::FrameView::updateDashboardRegions): Changed to call dashboardRegionsChanged on ChromeClient and to only call it when the regions actually changed.
- page/mac/FrameMac.mm: Removed dashboardRegionsChanged function.
- page/mac/WebCoreFrameBridge.h: Removed dashboardRegionsChanged: method.
WebKit/mac:
Reviewed by Adam.
- remove -[WebCoreFrameBridge dashboardRegionsChanged:]
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::dashboardRegionsChanged): Moved code here from the bridge. The WebCore side now calls this only when there's an actual change.
- WebCoreSupport/WebFrameBridge.h: Removed lastDashboardRegions.
- WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge dealloc]): Removed code to release lastDashboardRegions. Removed _compareDashboardRegions: and dashboardRegionsChanged: methods.
- 7:07 AM Changeset in webkit [30739] by
-
- 9 edits in trunk
WebCore:
Reviewed by Adam.
- remove WebCoreFrameBridge issuePasteComand method
- editing/Editor.cpp: (WebCore::Editor::paste): Moved the Mac-specific part of this to EditorMac.
- editing/mac/EditorMac.mm: (WebCore::Editor::paste): Added. Calls paste: on the document view (normally a WebHTMLView). We should get rid of this eventually.
- page/Frame.h: Removed issuePasteCommand.
- page/mac/FrameMac.mm: Ditto.
- page/mac/WebCoreFrameBridge.h: Ditto.
WebKit/mac:
Reviewed by Adam.
- remove WebCoreFrameBridge issuePasteComand method
- WebCoreSupport/WebFrameBridge.mm: Removed issuePasteCommand method.
- WebView/WebHTMLViewInternal.h: Removed declaration of paste: method.
- 1:11 AM Changeset in webkit [30738] by
-
- 3 edits3 deletes in trunk
Suggested by Darin, rubber-stamped by Mark.
http://bugs.webkit.org/show_bug.cgi?id=17569
REGRESSION (r30571): Buzzword.com doesn't load
Rolling out r30571, as determining what is wrong with it proved tricky.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::tokenizerProcessedData): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
- 12:25 AM Changeset in webkit [30737] by
-
- 2 edits in trunk/WebKitSite
2008-03-04 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
Add a note about preferring if over else if when the previous if is terminated by a return statement.
- coding/coding-style.html:
- 12:11 AM Changeset in webkit [30736] by
-
- 2 edits in trunk/WebCore
Build fix.
- bindings/js/kjs_events.cpp:
Mar 3, 2008:
- 11:48 PM Changeset in webkit [30735] by
-
- 20 edits2 adds in trunk
WebCore:
Reviewed by Mark Rowe.
Move JSClipboard into its own file.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSAttrCustom.cpp:
- bindings/js/JSClipboardCustom.cpp: Added. (WebCore::JSClipboard::types): (WebCore::JSClipboard::clearData): (WebCore::JSClipboard::getData): (WebCore::JSClipboard::setData): (WebCore::JSClipboard::setDragImage):
- bindings/js/JSElementCustom.cpp:
- bindings/js/JSEventCustom.cpp:
- bindings/js/JSHTMLFrameElementCustom.cpp:
- bindings/js/JSHTMLIFrameElementCustom.cpp:
- bindings/js/kjs_events.cpp:
- bindings/js/kjs_events.h:
- bindings/js/kjs_window.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Clipboard.cpp: (WebCore::Clipboard::setDropEffect): (WebCore::Clipboard::setEffectAllowed):
- dom/Clipboard.idl: Added.
LayoutTests:
Reviewed by Mark Rowe.
Update test results.
- fast/dom/Window/window-properties-expected.txt:
- 11:01 PM BuildingGtk edited by
- adding mac osx section (diff)
- 10:25 PM WebDevelopers edited by
- (diff)
- 10:20 PM WebDevelopers edited by
- update wikipedia link (diff)
- 10:20 PM Changeset in webkit [30734] by
-
- 2 edits in trunk/WebKit/gtk
GTK+ build fix.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::windowObjectCleared):
- 9:33 PM Changeset in webkit [30733] by
-
- 2 edits in trunk/WebKit/win
Windows build fix.
- WebFrame.cpp: (WebFrame::windowObjectCleared):
- 9:05 PM Changeset in webkit [30732] by
-
- 3 edits in trunk/WebCore
Windows build-fix.
- page/Chrome.cpp:
- plugins/win/PluginViewWin.cpp:
- 8:12 PM WebKitFeatures edited by
- Make the plugin section less confusing (diff)
- 8:10 PM ApolloWebKit edited by
- adding info about air (diff)
- 8:07 PM WikiStart edited by
- renaming adobe's 'apollo' to newer 'air' (diff)
- 8:06 PM WikiStart edited by
- referencing new page (diff)
- 8:05 PM WebKitFeatures edited by
- linking plugins (diff)
- 8:04 PM WebKitFeatures created by
- initial page
- 7:48 PM New features in WebKit since Safari 2.0 edited by
- adding header (diff)
- 7:08 PM Changeset in webkit [30731] by
-
- 35 edits in trunk/WebCore
Reviewed by Darin Adler.
Cleanup and plumbing in preparation for the great Window split.
- Rename KJS::Window to WebCore::JSDOMWindowBase.
- Remove KJS::Window::retrieve() and KJS::Window::retrieveWindow() and replace with the new toJSDOMWindow().
- Remove KJS::Window::retrieveActive() and replace with explicit call to exec->dynamicGlobalObject() and toJSDOMWindow().
- bindings/js/JSCustomVoidCallback.cpp: (WebCore::toVoidCallback):.
- bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create):
- bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::toJS):
- bindings/js/JSEventTargetBase.cpp: (WebCore::jsEventTargetAddEventListener): (WebCore::jsEventTargetRemoveEventListener):
- bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNode::setListener):
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::nameGetter): (WebCore::JSHTMLDocument::open):
- bindings/js/JSHTMLFrameSetElementCustom.cpp: (WebCore::JSHTMLFrameSetElement::nameGetter):
- bindings/js/JSLocation.cpp: (WebCore::JSLocation::put): (WebCore::jsLocationProtoFuncReplace): (WebCore::jsLocationProtoFuncReload): (WebCore::jsLocationProtoFuncAssign):
- bindings/js/JSLocation.h:
- bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
- bindings/js/JSSVGLazyEventListener.cpp: (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener): (WebCore::JSSVGLazyEventListener::eventParameterName):
- bindings/js/JSSVGLazyEventListener.h:
- bindings/js/JSXMLHttpRequest.cpp: (WebCore::JSXMLHttpRequest::putValueProperty): (WebCore::jsXMLHttpRequestPrototypeFunctionOpen): (WebCore::jsXMLHttpRequestPrototypeFunctionAddEventListener): (WebCore::jsXMLHttpRequestPrototypeFunctionRemoveEventListener):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- bindings/js/ScheduledAction.h:
- bindings/js/kjs_binding.cpp: (WebCore::allowsAccessFromFrame): (WebCore::printErrorMessageForFrame):
- bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::windowObj): (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener): (WebCore::JSEventListener::windowObj): (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::parseCode):
- bindings/js/kjs_events.h:
- bindings/js/kjs_navigator.cpp: (WebCore::MimeType::getValueProperty):
- bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate): (WebCore::KJSProxy::createHTMLEventHandler): (WebCore::KJSProxy::createSVGEventHandler):
- bindings/js/kjs_window.cpp: (WebCore::JSDOMWindowBasePrivate::JSDOMWindowBasePrivate): (WebCore::DOMWindowTimer::DOMWindowTimer): (WebCore::DOMWindowTimer::action): (WebCore::DOMWindowTimer::takeAction): (WebCore::): (WebCore::JSDOMWindowBase::JSDOMWindowBase): (WebCore::JSDOMWindowBase::~JSDOMWindowBase): (WebCore::JSDOMWindowBase::location): (WebCore::JSDOMWindowBase::mark): (WebCore::allowPopUp): (WebCore::createWindow): (WebCore::showModalDialog): (WebCore::JSDOMWindowBase::getValueProperty): (WebCore::JSDOMWindowBase::childFrameGetter): (WebCore::JSDOMWindowBase::indexGetter): (WebCore::JSDOMWindowBase::namedItemGetter): (WebCore::JSDOMWindowBase::getOwnPropertySlot): (WebCore::JSDOMWindowBase::put): (WebCore::JSDOMWindowBase::allowsAccessFrom): (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage): (WebCore::JSDOMWindowBase::allowsAccessFromPrivate): (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): (WebCore::JSDOMWindowBase::printErrorMessage): (WebCore::JSDOMWindowBase::globalExec): (WebCore::JSDOMWindowBase::shouldInterruptScript): (WebCore::JSDOMWindowBase::setListener): (WebCore::JSDOMWindowBase::getListener): (WebCore::JSDOMWindowBase::findJSEventListener): (WebCore::JSDOMWindowBase::findOrCreateJSEventListener): (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener): (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener): (WebCore::JSDOMWindowBase::clearHelperObjectProperties): (WebCore::JSDOMWindowBase::clear): (WebCore::JSDOMWindowBase::setCurrentEvent): (WebCore::JSDOMWindowBase::currentEvent): (WebCore::windowProtoFuncAToB): (WebCore::windowProtoFuncBToA): (WebCore::windowProtoFuncOpen): (WebCore::windowProtoFuncSetTimeout): (WebCore::windowProtoFuncClearTimeout): (WebCore::windowProtoFuncSetInterval): (WebCore::windowProtoFuncAddEventListener): (WebCore::windowProtoFuncRemoveEventListener): (WebCore::windowProtoFuncShowModalDialog): (WebCore::windowProtoFuncNotImplemented): (WebCore::JSDOMWindowBase::setReturnValueSlot): (WebCore::JSDOMWindowBase::clearAllTimeouts): (WebCore::JSDOMWindowBase::installTimeout): (WebCore::JSDOMWindowBase::pauseTimeouts): (WebCore::JSDOMWindowBase::resumeTimeouts): (WebCore::JSDOMWindowBase::clearTimeout): (WebCore::JSDOMWindowBase::timerFired): (WebCore::JSDOMWindowBase::disconnectFrame): (WebCore::JSDOMWindowBase::jsEventListeners): (WebCore::JSDOMWindowBase::jsHTMLEventListeners): (WebCore::JSDOMWindowBase::jsUnprotectedEventListeners): (WebCore::JSDOMWindowBase::jsUnprotectedHTMLEventListeners): (WebCore::toJS): (WebCore::toJSDOMWindow): (WebCore::toJSDOMWindow):
- bindings/js/kjs_window.h: (WebCore::JSDOMWindowBase::impl): (WebCore::JSDOMWindowBase::classInfo): (WebCore::JSDOMWindowBase::):
- bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
- bindings/scripts/CodeGeneratorJS.pm:
- history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore):
- page/Chrome.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
- page/DOMWindow.idl:
- page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::windowScriptNPObject): (WebCore::Frame::pageDestroyed):
- page/InspectorController.cpp: (WebCore::inspectedWindow):
- page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject):
- page/mac/WebCoreFrameBridge.mm: (updateRenderingForBindings):
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess):
- 5:16 PM Changeset in webkit [30730] by
-
- 2 edits in tags/Safari-5525.11.1/JavaScriptGlue
Merge r30677.
- 5:03 PM Changeset in webkit [30729] by
-
- 4 edits in branches/Safari-3-1-branch
Versioning.
- 5:02 PM Changeset in webkit [30728] by
-
- 1 copy in tags/Safari-5525.13
New tag.
- 4:43 PM Changeset in webkit [30727] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30716.
- 4:24 PM Changeset in webkit [30726] by
-
- 2 edits in trunk/JavaScriptCore
Make ForInNode check for the timeout interrupt
Reviewed by Anders
- 3:08 PM Changeset in webkit [30725] by
-
- 5 edits in trunk
wx build fixes after recent Frame-related changes.
- 2:59 PM Changeset in webkit [30724] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- make :first-letter apply to the first letter in normal flow, skipping floats and positioned objects
Test: fast/css/first-letter-skip-out-of-flow.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
LayoutTests:
Reviewed by Darin Adler.
- test that :first-letter applies to the first letter in normal flow, skipping floats and positioned objects
- fast/css/first-letter-skip-out-of-flow.html: Added.
- platform/mac-leopard/fast/css/first-letter-skip-out-of-flow-expected.checksum: Added.
- platform/mac-leopard/fast/css/first-letter-skip-out-of-flow-expected.png: Added.
- platform/mac/fast/css/first-letter-skip-out-of-flow-expected.txt: Added.
- 2:58 PM Changeset in webkit [30723] by
-
- 2 edits in trunk/WebCore
Fix build.
- plugins/win/PluginViewWin.cpp:
- 2:51 PM Google Summer of Code 2008 edited by
- (diff)
- 2:43 PM Changeset in webkit [30722] by
-
- 4 edits2 adds in trunk
2008-03-03 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Fix http://bugs.webkit.org/show_bug.cgi?id=17313
Bug 17313: querySelectorAll() causing crashes when called via dojo.query() wrapper
Node::querySelector and SelectorNodeList were not sufficiently initializing the CSSStyleSelector
before using it to resolve styles, which lead to it having a stale m_style member in some situations.
This stale m_style member resulted in a wild store that would write over whatever object now resided
at the location m_style pointed to.
Test: fast/dom/SelectorAPI/bug-17313.html
- dom/Node.cpp: (WebCore::Node::querySelector): Call initForStyleResolve to further initialize the CSSStyleSelector.
- dom/SelectorNodeList.cpp: (WebCore::SelectorNodeList::SelectorNodeList): Ditto.
2008-03-03 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Test for http://bugs.webkit.org/show_bug.cgi?id=17313
Bug 17313: querySelectorAll() causing crashes when called via dojo.query() wrapper
- fast/dom/SelectorAPI/bug-17313-expected.txt: Added.
- fast/dom/SelectorAPI/bug-17313.html: Added.
- 2:06 PM Changeset in webkit [30721] by
-
- 2 edits in trunk
2008-03-03 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=17644
Build GTK on Mac OS X using native ICU library
Use Apple native ICU libraries when building GTK
webkit on Mac OS.
- configure.ac:
- 1:53 PM Changeset in webkit [30720] by
-
- 18 edits in trunk/WebCore
Reviewed by Darin and Sam.
Include fixes, in preparation of using the headers in WebCore/bridge.
- bindings/js/kjs_binding.h:
- bindings/js/kjs_dom.cpp:
- bindings/objc/DOMInternal.mm:
- bindings/objc/DOMUtility.mm:
- bindings/objc/WebScriptObject.mm:
- bindings/objc/WebScriptObjectPrivate.h:
- bridge/objc/objc_class.h:
- bridge/objc/objc_instance.h:
- bridge/objc/objc_runtime.h:
- bridge/objc/objc_utility.h:
- bridge/runtime.h:
- bridge/runtime_object.h:
- bridge/runtime_root.h:
- html/HTMLAppletElement.cpp:
- html/HTMLAppletElement.h:
- html/HTMLEmbedElement.cpp:
- html/HTMLEmbedElement.h:
- html/HTMLObjectElement.cpp:
- html/HTMLPlugInElement.cpp:
- html/HTMLPlugInElement.h:
- page/mac/FrameMac.mm:
- page/mac/WebCoreFrameBridge.h:
- page/mac/WebCoreFrameBridge.mm:
- page/mac/WebCoreScriptDebugger.mm:
- 1:18 PM Changeset in webkit [30719] by
-
- 8 edits in trunk
WebCore:
Full page zoom plumbing. Add a notion of whether or not a zoom is text only or a full zoom to the
Frame. setTextSizeMultiplier does a text only zoom.
Reviewed by Tim H.
- page/Frame.cpp: (WebCore::Frame::zoomFactor): (WebCore::Frame::isZoomFactorTextOnly): (WebCore::Frame::setZoomFactor): (WebCore::FramePrivate::FramePrivate):
- page/Frame.h:
- page/FramePrivate.h:
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setTextSizeMultiplier:]):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentScale):
WebKit/win:
Full page zoom work. Make setting of a zoom factor take a boolean saying whether it is a text only
or full page zoom.
Reviewed by Tim H.
- WebFrame.cpp: (WebFrame::setTextSizeMultiplier):
- 12:03 PM Changeset in webkit [30718] by
-
- 2 edits in trunk/WebKit/gtk
2008-03-03 Alp Toker <alp@atoker.com>
Fix the GTK+ build following breakage introduced in r30712.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted):
- 11:58 AM Changeset in webkit [30717] by
-
- 5 edits in branches/Safari-3-1-branch/WebCore
2008-03-03 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Darin, Anders.
Merge 30698 to Safari-3-1-branch.
- plugins/PluginDatabase.h: Added isPreferredPluginPath(), preferredPluginCompare() qsort comparator.
- plugins/PluginPackage.h: Added bool m_allowsMultipleInstances. (WebCore::PluginPackage::allowsMultipleInstances): Added; returns true if plug-in can have multiple instances, false otherwise.
- plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabase::preferredPluginCompare): qsort comparator function, calls PluginPackage::compare(). (WebCore::PluginDatabase::pluginForMIMEType): Builds a list of plug-ins for a MIME type, sorts them, and returns the first item. (WebCore::PluginDatabase::MIMETypeForExtension): Builds a list of plug-ins that handle this extension, sorts them, and returns the MIME type the first plug-in in the list associates with this extension. (WebCore::PluginDatabase::isPreferredPluginPath): Returns true if the passed path is the "preferred" plug-in path.
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::PluginPackage): Set m_allowsMultipleInstances to true. (WebCore::PluginPackage::fetchInfo): If this is the VLC plug-in, set m_allowsMultipleInstances to false. (WebCore::PluginPackage::compare): Compare two plug-ins, first checking whether a plug-in has an issue that should push it to the back, then whether it's in a preferred directory that should move it to the front, then by filename, version, and parent directory. (WebCore::PluginPackage::load): If this plug-in doesn't allow multiple instances, and the package has been loaded, return false.
- 11:51 AM Changeset in webkit [30716] by
-
- 2 edits in trunk/WebCore
Fix for <rdar://problem/5776161> REGRESSION: Google Docs Spreadsheet crash
This is also http://bugs.webkit.org/show_bug.cgi?id=17543, fixed table layout corrupts heap.
Make sure not to access position -1 of the size 0 vectors.
Reviewed by ggaren
- rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::layout):
- 11:45 AM Changeset in webkit [30715] by
-
- 3 edits6 adds in trunk
WebCore:
Dynamically inserting CSS rule with @media query fails with DOM Exception 12
<http://bugs.webkit.org/show_bug.cgi?id=15986>
Reviewed by Darin.
Allow any valid rule (@font-face, @import, @media, @page or style) to be
parsed when using CSSStyleSheet.insertRule(). Previously only import and
style rules were allowed. Note that @page rules always throw an exception
because they're not implemented yet, so no test case was added for them.
Tests: fast/css/insertRule-font-face.html
fast/css/insertRule-media.html
- css/CSSGrammar.y: Extracted 'valid_rule' out of 'rule'. Renamed 'ruleset_or_import' to 'valid_rule_or_import' and changed its definition.
LayoutTests:
Dynamically inserting CSS rule with @media query fails with DOM Exception 12
<http://bugs.webkit.org/show_bug.cgi?id=15986>
Reviewed by Darin.
- fast/css/insertRule-font-face.html: Added.
- fast/css/insertRule-media.html: Added.
- fast/css/resources/insertRule-font-face.js: Added.
- fast/css/resources/insertRule-media.js: Added.
- 11:43 AM Changeset in webkit [30714] by
-
- 1 edit31 copies in trunk/WebCore
Reviewed by Sam.
Copy JSC bindings directory over to WebCore/bridge.
- bridge: Copied from ../JavaScriptCore/bindings.
- 10:56 AM Changeset in webkit [30713] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
- remove CSSMutableStyleDeclaration::setChanged()'s change type parameter
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setChanged): Removed the change type parameter and made this function determine the correct change type based on whether this is an inline style declaration. (WebCore::CSSMutableStyleDeclaration::setProperty):
- css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::clear): Removed this unused method. (WebCore::CSSMutableStyleDeclaration::setChanged): Made private.
- 10:44 AM Changeset in webkit [30712] by
-
- 26 edits in trunk
WebCore:
Reviewed by Adam.
- some "cleanup" on the path to removing WebCoreFrameBridge
- WebCore.base.exp: Exported some stuff we either already use or I am about to use in an upcoming patch.
- WebCore.xcodeproj/project.pbxproj: Made FileChooser.h private rather than project, for future use in WebKit.
- bindings/objc/WebScriptObject.mm: Removed some dead code.
- dom/ContainerNode.cpp: Added a now-needed or soon-to-be-needed include.
- editing/Editor.cpp: Ditto.
- editing/Editor.h: Removed many unneeded declarations and includes. Removed the unused userVisibleString function.
- editing/EditorCommand.cpp: (WebCore::executeYank): Added parameter for triggeringEvent, which no longer has a default value. (WebCore::executeYankAndSelect): Ditto.
- editing/mac/EditorMac.mm: Removed userVisibleString.
- page/mac/EventHandlerMac.mm: (WebCore::isKeyboardOptionTab): Tweaked formattin.
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragSourceMovedTo:]): Get window from -[NSView window] rather than from the bridge. There's no special value in the bridge's window method and we can use NSView directly. (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): Ditto.
- platform/graphics/mac/ImageMac.mm: (WebCore::Image::loadPlatformResource): Use a new WebCoreBundleFinder class to find the bundle rather than using WebCoreFrameBridge.
- platform/mac/ClipboardMac.mm: Added a now-needed or soon-to-be-needed include.
- platform/mac/PasteboardMac.mm: Ditto.
- rendering/RenderObject.h: (WebCore::DashboardRegionValue::operator==): Fixed mistake where this wasn't comparing the clip rectangle. (WebCore::DashboardRegionValue::operator!=): Added. Needed by my future work.
WebKit/mac:
Reviewed by Adam.
- some "cleanup" on the path to removing WebCoreFrameBridge
- Storage/WebDatabaseManager.mm: Tweak includes.
- Storage/WebDatabaseTrackerClient.mm: Ditto.
- Storage/WebSecurityOrigin.mm: Ditto.
- Storage/WebSecurityOriginInternal.h: Ditto.
- WebView/WebFrame.mm: (core): Changed to get rid of the requirement that WebKitEditableLinkBehavior exactly match WebCore::EditableLinkBehavior.
- WebView/WebFrameInternal.h: Removed unused kit function.
- WebView/WebHTMLView.mm: Moved WebHTMLViewPrivate class in here.
- WebView/WebHTMLViewInternal.h: Moved WebHTMLVewPrivate class out of here.
- WebView/WebHTMLViewPrivate.h: Tweaked formatting and removed some unneeded declarations.
- WebView/WebPreferencesPrivate.h: Removed a no-longer-needed comment.
- 1:34 AM Changeset in webkit [30711] by
-
- 5 edits in trunk
Bug 17620: getImageData lies
http://bugs.webkit.org/show_bug.cgi?id=17620
Reviewed by Mark Rowe
Correct logic to actually iterate over the source row
- 12:17 AM Changeset in webkit [30710] by
-
- 4 edits in trunk
Correct incorrect assertion
Reviewed by Mark Rowe
Mar 2, 2008:
- 9:34 PM Changeset in webkit [30709] by
-
- 2 edits in trunk/WebCore
2008-03-02 Alp Toker <alp@atoker.com>
Another fix for non-database builds after changes in r30331.
Conditionalize a stopDatabases() call.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
- 9:29 PM Changeset in webkit [30708] by
-
- 3 edits in trunk/WebCore
Reviewed by Alp Toker.
Scrolling fixes. Implement page scrolling, initialize mouse wheel event variables, and remove duplicate event binding for TOP scrolling event.
- 9:10 PM Changeset in webkit [30707] by
-
- 6 edits in trunk
2008-03-02 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=17415
GTK Build (using autotools) on Mac OS (DarwinPorts) Fails
Add -lstdc++ to link flags for minidom program. This corrects
a build error for the GTK+ on Mac OS.
Add ICU_CPPFLAGS earlier in include path for WebCore
so that we find $(icu_cppflags)/unicode/utf8.h, rather than
the wtf/unicode/UTF8.h on case-insensitive file systems.
Remove some needless LIBS.
- 9:02 PM Changeset in webkit [30706] by
-
- 2 edits in trunk/WebCore
2008-03-02 Alp Toker <alp@atoker.com>
Fix building without database support after changes in r30331.
- dom/Document.cpp:
- 7:16 PM Changeset in webkit [30705] by
-
- 2 edits in trunk/WebCore
wx build fix for Windows after PageWin.cpp move.
- 6:23 PM ApplicationsGtk edited by
- Add perl Bindings to the list (diff)
- 6:02 PM Changeset in webkit [30704] by
-
- 3 edits2 adds in trunk
Reviewed by Dave Hyatt.
Gracefully handle a CSS rule containing an invalid value.
(Fixes http://bugs.webkit.org/show_bug.cgi?id=16898)
- 2:58 PM Changeset in webkit [30703] by
-
- 2 edits in trunk/WebCore
2008-03-02 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Improve the Cairo Path::isEmpty() function
Use cairo_has_current_point() where available.
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::isEmpty):
- 11:51 AM Changeset in webkit [30702] by
-
- 6 edits in trunk
2008-03-02 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Split the WebKit GTK+ build out of the WebCore build and change the
shared object name to match the package name.
- GNUmakefile.am:
Mar 1, 2008:
- 11:08 PM Changeset in webkit [30701] by
-
- 12 edits in trunk
Update Xcode configuration to support building debug and release from the mysterious future.
Reviewed by Tim Hatcher.
- 10:55 PM Changeset in webkit [30700] by
-
- 11 edits3 adds in trunk
Bug 16954: Support putImageData
Reviewed by Sam Weinig.
Implement support for HTML5's putImageData for the CG port. All other ports
are currently just using stubs for the final blit.
- 6:13 PM Changeset in webkit [30699] by
-
- 1 edit in trunk/WebCore/css/CSSPropertyNames.in
Typo fix.
- 6:02 PM Changeset in webkit [30698] by
-
- 10 edits in trunk/WebCore
2008-03-01 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Darin.
<rdar://problem/5772987> Crashing viewing page with two VLC plug-in
instances
The VLC Netscape plug-in crashes if more than one instance is created.
Added a quirk that disallows a plug-in from having more than one
instance and set this for the VLC plug-in.
In addition, we now sort plug-ins that handle the same MIME
type to choose the most appropriate one. This sorting first sorts by
whether a plug-in has an issue that should put it at the end of the
list, then whether it appears in a "preferred" plug-in directory.
- plugins/PluginQuirkSet.h: Added PluginQuirkDontAllowMultipleInstances.
- plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::preferredPluginCompare): Comparator for sorting plug-ins; calls PluginPackage::compare(). (WebCore::PluginDatabase::pluginForMIMEType): Add all of the plug-ins that handle this MIME type to a list, sort the list, and return the first item. (WebCore::PluginDatabase::MIMETypeForExtension): Add all of the plug-ins that handle this extension to a list, sort the list, and return the MIME type used by the plug-in at the beginning of the list.
- plugins/PluginDatabase.h:
- plugins/PluginPackage.h: (WebCore::PluginPackage::version): Added; returns the module version.
- plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabase::isPreferredPluginPath): Made static; removed const.
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::compare): Sorts plug-ins with known issues to the end, then plug-ins in preferred directories to the beginning, then alphabetically by file name, numerically by version, and alphabetically by parent directory. (WebCore::PluginPackage::determineQuirks): Set the "don't allow multiple instances" quirk for VLC. (WebCore::PluginPackage::load): Return false if the plug-in library has already been loaded and the "don't allow multiple instances" quirk is set.
- platform/gtk/TemporaryLinkStubs.cpp: (PluginPackage::compare): Added stub. (PluginDatabase::IsPreferredPluginPath): Update the GTK stub.
- platform/qt/TemporaryLinkStubs.cpp: (PluginPackage::compare): Added stub. (PluginDatabase::IsPreferredPluginPath): Update the Qt stub.
- platform/wx/TemporaryLinkStubs.cpp: (PluginPackage::compare): Added stub. (PluginDatabase::IsPreferredPluginPath): Update the wx stub.
- 1:55 PM Changeset in webkit [30697] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Mark Rowe.
Remove reference to the now non-existent bridge directory.
- WebCore.xcodeproj/project.pbxproj:
- 12:19 PM Changeset in webkit [30696] by
-
- 4 edits in trunk
WebCore:
Reviewed by Darin Adler.
Search the entire prototype chain when doing early prototype lookup in
the Window's getOwnPropertySlot method.
Makes fast/dom/Window/window-function-name-getter-precedence.html pass all tests.
- bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot):
LayoutTests:
Reviewed by Darin Adler.
Update test result.
- fast/dom/Window/window-function-name-getter-precedence-expected.txt:
- 5:46 AM Changeset in webkit [30695] by
-
- 5 edits40 adds in trunk
Reviewed by Oliver.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=17568 (SVGForeignObjectElement can't react to width/height SVG DOM changes)
As the bug title says, fix all dynamic update problems that occour with SVGForeignObjectElement.
Tests: svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr.html
svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr.html
svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr.html
svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr.html
svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop.html
svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop.html
svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop.html
svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop.html
Feb 29, 2008:
- 7:57 PM Google Summer of Code 2008 edited by
- (diff)
- 6:20 PM Changeset in webkit [30694] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30692.
- 6:20 PM Changeset in webkit [30693] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30689.
- 6:15 PM Changeset in webkit [30692] by
-
- 2 edits in trunk/WebCore
Reviewed by build-fix karma
Bonehead mistake. Revert function to previous version for all non-Windows+CFNetwork platforms
- platform/network/ProtectionSpace.cpp: (WebCore::ProtectionSpace::receivesCredentialSecurely): Make my previous change conditionally
- 6:01 PM Changeset in webkit [30691] by
-
- 2 edits in trunk/WebKitLibraries
Update Tiger version of WebKitSystemInterface to match r30690.
- 5:56 PM Changeset in webkit [30690] by
-
- 2 edits in trunk/WebKitLibraries
Reviewed by Mark.
Auto-generate image arrays.
- libWebKitSystemInterfaceLeopard.a:
- 5:50 PM Changeset in webkit [30689] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin
<rdar://problem/5771227> - Incorrect password handling text in credential sheet
- platform/network/ProtectionSpace.cpp: (WebCore::ProtectionSpace::receivesCredentialSecurely): Call functional CFNetwork method to get "secureness" of the auth challenge instead of figuring it out ourselves
- 5:35 PM Changeset in webkit [30688] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Sam Weinig.
- update test results following r30649
- svg/css/getComputedStyle-basic-expected.txt:
- 4:29 PM Changeset in webkit [30687] by
-
- 3 edits1 copy in trunk
2008-02-29 Brent Fulgham <bfulgham@gmail.com>
JavaScriptCore:
http://bugs.webkit.org/show_bug.cgi?id=17483
Implement scrollbars on Windows (Cairo)
Reviewed by Adam Roben.
- wtf/Platform.h:
WebCore:
http://bugs.webkit.org/show_bug.cgi?id=17483
Implement scrollbars on Windows (Cairo)
Reviewed by Adam Roben.
- platform/win/PlatfromScrollBarWin.cpp: Duplicate implementation from PlatformScrollBarWinSafari.cpp, then modify to use the native Windows theme engine. Use SOFT_LINK. Use platform 'GetSystemMetrics' call to decide size of scrollbars and buttons.
- 4:19 PM Changeset in webkit [30686] by
-
- 2 edits in branches/Safari-3-1-branch/JavaScriptGlue
Merge r30677.
- 4:14 PM Changeset in webkit [30685] by
-
- 1 edit1 delete in trunk/WebKit/win
Delete an unused file
Rubberstamped by Brady.
- Interfaces/IWebScriptScope.idl: Removed.
- 4:14 PM Changeset in webkit [30684] by
-
- 4 edits in trunk/WebKit/win
Change WebPreferences to be backed by CFPreferences
Reviewed by Ada, Geoff, Steve, and Darin.
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::sharedStandardPreferences): Changed to call setAutoSaves(TRUE) before calling load(). This ensures that the preferences being migrated to CFPreferences are saved to disk. (WebPreferences::valueForKey): Changed to return a RetainPtr to ensure that the refcount is managed properly. Now attempts to retrieve a value from CFPreferences before falling back to the default settings. (WebPreferences::setValueForKey): Now saves the value in CFPreferences if m_autoSaves is true. (WebPreferences::stringValueForKey): Updated for valueForKey changes. (WebPreferences::integerValueForKey): DItto. (WebPreferences::boolValueForKey): Ditto. (WebPreferences::floatValueForKey): Ditto. (WebPreferences::save): Now simply calls CFPreferencesAppSynchronize. (WebPreferences::load): Always initializes m_privatePrefs to an empty CFMutableDictionary. (WebPreferences::migrateWebKitPreferencesToCFPreferences): Migrates preferences from our old custom plist to CFPreferences and then deletes our custom plist, if the migration has never occurred before. (WebPreferences::copyWebKitPreferencesToCFPreferences): Copies preferences to CFPreferences. If we've never migrated the default settings from Safari 3 Beta before, we omit them from this copying procedure.
- WebPreferences.h:
- 4:13 PM Changeset in webkit [30683] by
-
- 2 edits in trunk/WebKit/win
Refactor value <-> CFNumber conversions into some helper functions
Reviewed by Jon.
- WebPreferences.cpp: (preferencesPath): Changed to return a const String&. (numberValueForPreferencesValue): Converts a value from preferences to a native numeric type. (cfNumber): Converts a native numeric value to a CFNumberRef. (booleanValueForPreferencesValue): Converts a value from preferences to a native boolean. (WebPreferences::integerValueForKey): Changed to call numberValueForPreferencesValue. (WebPreferences::floatValueForKey): Ditto. (WebPreferences::boolValueForKey): Changed to call booleanValueForPreferencesValue. (WebPreferences::setIntegerValue): Changed to call cfNumber. (WebPreferences::setLongLongValue): Ditto.
- 4:13 PM Changeset in webkit [30682] by
-
- 3 edits in trunk/WebKit/win
Add WebPreferences::setValueForKey
This is just a small refactoring of some duplicated logic into a
shared method.
Reviewed by Sam.
- WebPreferences.cpp: (WebPreferences::setValueForKey): Added. (WebPreferences::setStringValue): Call setValueForKey. (WebPreferences::setIntegerValue): Ditto. (WebPreferences::setBoolValue): Ditto. (WebPreferences::setLongLongValue): Ditto.
- WebPreferences.h:
- 4:13 PM Changeset in webkit [30681] by
-
- 3 edits in trunk/WebKit/win
Remove WebPreferences' static members
s_defaultSettings is now a file-level static, and
s_standardPreferences has been removed completely (it wasn't being
used).
Reviewed by Sam.
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::valueForKey): (WebPreferences::migrateDefaultSettingsFromSafari3Beta): (WebPreferences::removeValuesMatchingDefaultSettings):
- WebPreferences.h:
- 4:09 PM Changeset in webkit [30680] by
-
- 2 edits2 copies in trunk/WebCore
Windows build fix
- WebCore.vcproj/WebCore.vcproj: Remove bridge/* from the include path and the post-build event, and add page/win to each. Also let VS have its way with the order of the files.
- page/win/PageWin.cpp: Copied from bridge/win/PageWin.cpp in r30673
- page/win/GlobalHistoryWin.cpp: Copied from bridge/win/GlobalHistoryWin.cpp in r30673
- 3:48 PM Changeset in webkit [30679] by
-
- 4 edits in trunk/JavaScriptCore
Remove unused DebuggerImp::abort and DebuggerImp::aborted
Reviewed by Tim and Sam.
- kjs/function_object.cpp: (KJS::FunctionObjectImp::construct):
- kjs/internal.h: (KJS::DebuggerImp::DebuggerImp):
- kjs/nodes.cpp: (KJS::Node::handleException): (KJS::FunctionBodyNodeWithDebuggerHooks::execute):
- 3:45 PM Changeset in webkit [30678] by
-
- 2 edits in trunk/WebCore
Build fix.
- WebCore.xcodeproj/project.pbxproj:
- 3:08 PM Changeset in webkit [30677] by
-
- 2 edits in trunk/JavaScriptGlue
Reviewed by David Harrison.
Fixed <rdar://problem/5765063> TOT REGRESSION: Software Update crash in
KJS::Collector::collect() (missing JSLock)
- JSValueWrapper.cpp: (unprotectGlobalObject): Added missing JSLock.
- 2:47 PM Changeset in webkit [30676] by
-
- 2 edits in trunk/WebCore
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Tim Hatcher.
64-bit build fix.
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::pathFromFont): Provide stub implementation of pathFromFont for 64-bit as FMGetATSFontRefFromFont is not available.
- 2:27 PM Changeset in webkit [30675] by
-
- 2 edits in trunk/WebCore
Build fix. Only declare pathFromFont in debug builds as it is unused in release builds.
- 2:19 PM Changeset in webkit [30674] by
-
- 3 edits7 copies1 delete in trunk/WebCore
Reviewed by Adam.
Copy the remaining files in bridge/ over to page/
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bridge: Removed.
- bridge/AXObjectCache.h: Removed.
- bridge/EditorClient.h: Removed.
- bridge/GlobalHistory.h: Removed.
- bridge/win: Removed.
- bridge/win/FrameCGWin.cpp: Removed.
- bridge/win/FrameCairoWin.cpp: Removed.
- bridge/win/FrameWin.cpp: Removed.
- bridge/win/FrameWin.h: Removed.
- bridge/win/GlobalHistoryWin.cpp: Removed.
- bridge/win/PageWin.cpp: Removed.
- page/AXObjectCache.h: Copied from bridge/AXObjectCache.h.
- page/EditorClient.h: Copied from bridge/EditorClient.h.
- page/GlobalHistory.h: Copied from bridge/GlobalHistory.h.
- page/win/FrameCGWin.cpp: Copied from bridge/win/FrameCGWin.cpp.
- page/win/FrameCairoWin.cpp: Copied from bridge/win/FrameCairoWin.cpp.
- page/win/FrameWin.cpp: Copied from bridge/win/FrameWin.cpp.
- page/win/FrameWin.h: Copied from bridge/win/FrameWin.h.
- 2:10 PM Changeset in webkit [30673] by
-
- 5 edits2 adds in trunk
2008-02-29 Robert Blaut <webkit@blaut.biz>
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=17532 Webkit imports styles from <link> element which doesn't have rel=stylesheet defined
Test: fast/html/link-rel-stylesheet.html
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
2008-02-29 Robert Blaut <webkit@blaut.biz>
Reviewed by Darin Adler.
- Tests for http://bugs.webkit.org/show_bug.cgi?id=17532 Webkit imports styles from <link> element which doesn't have rel=stylesheet defined
- fast/html/link-rel-stylesheet.html: Added.
- fast/media/mq-simple-query-02.html:
- fast/media/mq-width-absolute-02.html:
- platform/mac/fast/html/link-rel-stylesheet-expected.txt: Added.
- 2:06 PM Changeset in webkit [30672] by
-
- 11 edits in trunk
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Anders Carlsson.
Replace use of WKPathFromFont with implementation in terms of public API.
- WebCore.base.exp: Remove unused symbol.
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::initFontData): (WebCore::pathFromFont): Implement pathFromFont in terms of public API. (WebCore::SimpleFontData::platformInit):
- platform/mac/WebCoreSystemInterface.h: Remove unused symbol.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Anders Carlsson.
Replace use of WKPathFromFont with implementation in terms of public API.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Remove unused symbol.
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Anders Carlsson.
Replace use of WKPathFromFont with implementation in terms of public API.
- WebKitSystemInterface.h: Remove unused symbol.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 1:56 PM Changeset in webkit [30671] by
-
- 2 edits6 copies1 delete in trunk/WebCore
Reviewed by Adam.
Move a bunch of files from bridge/mac to page/mac.
- WebCore.xcodeproj/project.pbxproj:
- bridge/mac: Removed.
- bridge/mac/AXObjectCacheMac.mm: Removed.
- bridge/mac/GlobalHistoryMac.mm: Removed.
- bridge/mac/WebCoreAXObject.h: Removed.
- bridge/mac/WebCoreAXObject.mm: Removed.
- bridge/mac/WebCoreScriptDebugger.h: Removed.
- bridge/mac/WebCoreScriptDebugger.mm: Removed.
- page/mac/AXObjectCacheMac.mm: Copied from bridge/mac/AXObjectCacheMac.mm.
- page/mac/GlobalHistoryMac.mm: Copied from bridge/mac/GlobalHistoryMac.mm.
- page/mac/WebCoreAXObject.h: Copied from bridge/mac/WebCoreAXObject.h.
- page/mac/WebCoreAXObject.mm: Copied from bridge/mac/WebCoreAXObject.mm.
- page/mac/WebCoreScriptDebugger.h: Copied from bridge/mac/WebCoreScriptDebugger.h.
- page/mac/WebCoreScriptDebugger.mm: Copied from bridge/mac/WebCoreScriptDebugger.mm.
- 1:14 PM Changeset in webkit [30670] by
-
- 4 edits in trunk/WebCore
Fix for http://bugs.webkit.org/show_bug.cgi?id=17559, media query tests crashing under
guard malloc. Pass along the style selector so it can be accessed, since it has not yet
been assigned into the document's member variable.
Reviewed by aroben
- css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::addRulesFromSheet):
- css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::eval):
- css/MediaQueryEvaluator.h:
- 12:55 PM Changeset in webkit [30669] by
-
- 3 edits in trunk/WebKit/win
Don't free the VARIANT passed into Write, since it is an input parameter owned by the caller.
Found via code inspection.
Reviewed by Adam.
- WebActionPropertyBag.cpp: (WebActionPropertyBag::Write):
- WebElementPropertyBag.cpp: (WebElementPropertyBag::Write):
- 11:11 AM Changeset in webkit [30668] by
-
- 2 edits in trunk/WebKitTools
Pass the correct configuration switch (--DebugRelease) to build-testkjs. Reviewed by Dan.
Originally broken in r26838.
- Scripts/run-javascriptcore-tests: Push configuration switch onto @xcodeArgs not local, unused @args variable.
- 10:58 AM Changeset in webkit [30667] by
-
- 5 edits in trunk/WebCore
<rdar://problem/5755916> REGRESSION: Loading HTML5 spec is 5x slower on TOT than in 3.0.4
Improve the performance of dynamic sibling and CSS3 selectors so that there is no slowdown any more.
Be more precise in terms of what nodes we mark dirty.
Reviewed by Beth
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector):
- dom/Element.cpp: (WebCore::Element::recalcStyle): (WebCore::checkForSiblingStyleChanges): (WebCore::Element::childrenChanged): (WebCore::Element::finishParsingChildren):
- rendering/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle):
- rendering/RenderStyle.h: (WebCore::RenderStyle::childrenAffectedByPositionalRules): (WebCore::RenderStyle::childrenAffectedByDirectAdjacentRules): (WebCore::RenderStyle::setChildrenAffectedByDirectAdjacentRules):
- 10:22 AM Changeset in webkit [30666] by
-
- 2 edits in trunk/WebKitTools
Bug 15754: webarchive layout tests fail when WebKit directory path contains symlinks
Reviewed by Geoff and Darin.
We were using -[NSFileManager currentDirectoryPath] to get the current working directory,
then removing that path from all file:/// URLs in the WebArchive output so these tests
would pass no matter where they were run.
The problem was that -[NSFileManager currentDirectoryPath] resolves symlinks in the
current working directory, but the WebArchive does not. This left the current working
directory in all file:/// URLs in the test output, and thus all tests failed, for any
developer that used symlinks to get to their WebKit source directory.
The fix is to look backwards for "/LayoutTests/" in the URL we're passed, and simply
remove the current working directory path (no matter what it is) after "file://" but
before "/LayoutTests/".
- DumpRenderTree/mac/DumpRenderTree.mm: (normalizeWebResourceURL): Removed unused oldURLBase argument. We now replace the current working directory as described above. (convertWebResourceResponseToDictionary): Remove unused oldURLBase argument. Update calls to normalizeWebResourceURL(). (serializeWebArchiveToXML): Removed now unused cwdURL variable. Update calls to normalizeWebResourceURL() and convertWebResourceResponseToDictionary().
- 9:58 AM Changeset in webkit [30665] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
<rdar://problem/5766352> REGRESSION (r27151): XMLHttpRequest.abort() resets response status
Test: http/tests/xmlhttprequest/status-after-abort.html
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getStatus): (WebCore::XMLHttpRequest::getStatusText): Changed to match Firefox more closely (IE just raises an exception in most of those cases).
- 9:28 AM Changeset in webkit [30664] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix a bug where explicit embedding past the end of a line could affect text that line
Test: fast/text/embed-at-end-of-pre-wrap-line.html
- rendering/bidi.cpp: (WebCore::RenderBlock::skipWhitespace): Removed calls to setAdjustEmbedding(). (WebCore::RenderBlock::findNextLineBreak): Added calls to setAdjustEmbedding() around skipWhitespace() only where needed.
LayoutTests:
Reviewed by Darin Adler.
- test for a bug where explicit embedding past the end of a line could affect text that line
- fast/text/embed-at-end-of-pre-wrap-line.html: Added.
- platform/mac-leopard/fast/text/embed-at-end-of-pre-wrap-line-expected.checksum: Added.
- platform/mac-leopard/fast/text/embed-at-end-of-pre-wrap-line-expected.png: Added.
- platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt: Added.
- 3:32 AM Changeset in webkit [30663] by
-
- 5 edits in branches/Safari-3-1-branch
Merge r30475.
- 3:26 AM Changeset in webkit [30662] by
-
- 7 edits in trunk
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.
- Misc/WebNSURLExtras.mm: (-[NSURL _webkit_canonicalize]):
- WebKit.order:
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 3:25 AM Changeset in webkit [30661] by
-
- 11 edits in trunk
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.
- platform/mac/WebCoreSystemInterface.h: Don't declare WKSupportsMultipartXMixedReplace on Leopard.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
- platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't call WKSupportsMultipartXMixedReplace on Leopard.
- WebCore.Tiger.exp: Move Tiger-only symbol here.
- WebCore.base.exp:
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
- 3:25 AM Changeset in webkit [30660] by
-
- 10 edits in trunk/WebKit/mac
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Remove obsolete code that had been left intact to support users running WebKit with older versions of Safari.
- Misc/WebNSViewExtras.m: Remove _web_superviewOfClass:stoppingAtClass:.
- Misc/WebNSWindowExtras.m: Remove _webkit_displayThrottledWindows.
- Misc/WebSearchableTextView.m: Remove selectionImageForcingWhiteText:.
- WebCoreSupport/WebImageRendererFactory.m: Update comment to mention the last version of Safari that requires this class.
- WebInspector/WebInspector.mm: Remove sharedWebInspector and update comments to mention the last version of Safari that calls other obsolete methods.
- WebView/WebDocumentPrivate.h: Remove selectionImageForcingWhiteText:.
- WebView/WebHTMLView.mm: Ditto.
- WebView/WebPDFView.mm: Ditto.
- WebView/WebView.mm: Update comment to mentoin the last version of Safari that requires the obsolete method.
- 1:23 AM Changeset in webkit [30659] by
-
- 13 edits in trunk
2008-02-29 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Eric Seidel.
Remove unneeded includes of WebCoreSystemInterface.h.
- loader/mac/LoaderNSURLExtras.m:
- page/mac/FrameMac.mm:
- page/mac/WebCoreFrameBridge.mm:
- platform/MIMETypeRegistry.cpp:
- platform/graphics/mac/ImageMac.mm:
- platform/mac/PasteboardMac.mm:
2008-02-29 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Eric Seidel.
Remove unneeded includes of WebKitSystemInterface.h.
- History/WebHistoryItem.mm:
- Misc/WebNSViewExtras.m:
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebDataSource.mm:
- WebView/WebPDFView.mm:
- 1:05 AM Changeset in webkit [30658] by
-
- 12 edits in trunk
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt and Oliver Hunt.
<rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.
- platform/mac/SystemTimeMac.cpp: Replace use of WKSecondsSinceLastInputEvent with CGEventSourceSecondsSinceLastEventType.
- platform/mac/WebCoreSystemInterface.h: Remove unused symbol.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
- WebCore.base.exp: Ditto.
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt and Oliver Hunt.
<rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Remove unused symbol.
- WebKit.order: Ditto.
2008-02-29 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt and Oliver Hunt.
<rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.
- WebKitSystemInterface.h: Remove unused symbol.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
Feb 28, 2008:
- 11:54 PM Changeset in webkit [30657] by
-
- 4 edits in trunk/WebKitLibraries
2008-02-28 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Remove two unused functions from WebKitSystemInterface.
- WebKitSystemInterface.h: Remove WKPreferRGB32Key and WKGetDefaultGlyphForChar as they are unused. Also remove a duplicate declaration of WKSecondsSinceLastInputEvent.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 10:19 PM Changeset in webkit [30656] by
-
- 11 edits1 add in trunk
2008-02-28 Mark Rowe <mrowe@apple.com>
Reviewed by Dave Hyatt.
Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.
- DerivedSources.make: Add Tiger-only symbols to the export file when running on Tiger.
- WebCore.Tiger.exp: Added. Move Tiger-only symbol here from WebCore.base.exp.
- WebCore.base.exp:
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit): Use Leopard APIs when building on Leopard.
- platform/mac/WebCoreSystemInterface.h: Don't declare wkGetFontMetrics on Leopard as it is unused.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
2008-02-28 Mark Rowe <mrowe@apple.com>
Reviewed by Dave Hyatt.
Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.
- WebKitSystemInterface.h: Only declare WKGetFontMetrics on Tiger.
- libWebKitSystemInterfaceLeopard.a: Update for removal of WKGetFontMetrics.
2008-02-28 Mark Rowe <mrowe@apple.com>
Reviewed by Dave Hyatt.
Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Only initialize wkGetFontMetrics on Tiger.
- 4:50 PM Changeset in webkit [30655] by
-
- 3 edits in branches/Safari-3-1-branch/LayoutTests
Disable http/tests/security/cross-frame-access-location-put.html as postMessage support is disabled on the branch.
- 3:20 PM Google Summer of Code 2008 edited by
- (diff)
- 3:11 PM Changeset in webkit [30654] by
-
- 2 edits in trunk/WebCore
Reviewed by Tim Hatcher.
Bug 16535: Stylesheets loaded with @import are not editable
http://bugs.webkit.org/show_bug.cgi?id=16535
<rdar://problem/5712899>
Sheets loaded using @import were incorrectly being flagged as non-editable
user agent sheets because their parent sheet doesn't have an ownerNode. We now
check to make sure sheets also don't have a href before restricting their editability.
- page/inspector/StylesSidebarPane.js:
- 2:52 PM Changeset in webkit [30653] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
2008-02-28 Dave Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
Fix <rdar://problem/5771994> REGRESSION: Loading HTML5 spec is 5x slower on TOT than in 3.0.4.
Disable dynamic updating of the + selector when the DOM changes, since it hurt performance on the HTML5 spec.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector):
- 2:24 PM Changeset in webkit [30652] by
-
- 3 edits4 deletes in branches/Safari-3-1-branch
- 2:16 PM Changeset in webkit [30651] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Geoffrey Garen.
TOTAL : 1.005x as fast 2867.6ms +/- 0.4% 2853.2ms +/- 0.3% significant
- kjs/nodes.cpp: Tell the compiler that exceptions are unexpected (for the sake of branch prediction and code organization).
- 12:46 PM Changeset in webkit [30650] by
-
- 9 edits1 copy in trunk/WebCore
2008-02-28 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Adam Roben.
Copy PluginPackageWin.cpp to shared PluginPackage.cpp.
Add PluginPackage.cpp to build configurations.
Remove PluginPackage destructor from TemporaryLinkStubs.cpp.
Use cross-platform pathGetFilename method.
Remove platform-specific code from shared PluginPackage implementation.
Remove shared code from PluginPackageWin.cpp.
- GNUmakefile.am:
- WebCore.pro:
- WebCoreSources.bkl:
- WebCore.vcproj/WebCore.vcproj:
- platform/gtk/TemporaryLinkStubs.cpp:
- platform/qt/TemporaryLinkStubs.cpp:
- platform/wx/TemporaryLinkStubs.cpp:
- plugins/PluginPackage.cpp:
- plugins/win/PluginPackageWin.cpp:
- 12:42 PM Changeset in webkit [30649] by
-
- 32 edits8 adds6 deletes in trunk
WebCore:
Reviewed by Darin Adler.
<rdar://problem/4930986> REGRESSION: Paste As Quotation pastes black text instead of blue
Add a second style span at copy time to hold document default styles. This helps us
differentiate between those and user applied styles at paste time, where we'll want
to let Mail's Paste As Quotation blockquote override document default styles, but
not others.
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed the unit type used for -webkit-text-stroke-width from CSS_NUMBER to CSS_PX, to match other properties that are thick | medium | thin | <length>. Before, there was a mismatch between the unit type of -webkit-text-stroke-width property values in a CSSComputedStyleDeclaration for an element and that element's inlineStyleDecl(), causing identical values to always appear different to diff().
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::handlePasteAsQuotationNode): Fixed. Don't just change the class to an empty string, completely remove it, it's no longer needed. (WebCore::handleStyleSpansBeforeInsertion): Moved the optimization from doApply here. (WebCore::ReplaceSelectionCommand::handleStyleSpans): Added, replaces removeRedundantStyles. We aren't (yet) removing all redundant styles, just those on style spans, so I removed the unused code and renamed the function. There won't be more than two style spans that we need to consider, the one with the source document's default styles and styles on the commonAncestor of the copied Range, so don't look for more than two. Let elements that wrap the incoming fragment override the source document's styles. (WebCore::ReplaceSelectionCommand::doApply): Moved code to handleStyleSpansBeforeInsertion and call the renamed handleStyleSpans.
- editing/ReplaceSelectionCommand.h:
- editing/markup.cpp: (WebCore::removeDefaultStyles): Added. Don't add document defaults to the style span that holds user applied styles, since they'll be added to their own style span. (WebCore::createMarkup): Add a second style span that holds just the document defaults. This lets us differentiate between those and user applied styles at paste time. Mail blockquotes are just another type of special element, moved their handling there. This also lets paste code make assumptions about the position of the two style spans (they are *always* parent-child).
LayoutTests:
Reviewed by Darin Adler.
<rdar://problem/4930986> REGRESSION: Paste As Quotation pastes black text instead of blue
Demonstrates the bug:
- editing/pasteboard/4930986-1-expected.txt: Added.
- editing/pasteboard/4930986-1.html: Added.
- editing/pasteboard/4930986-2-expected.txt: Added.
- editing/pasteboard/4930986-2.html: Added.
Demonstrates a problem with the first version of the patch:
- editing/pasteboard/4930986-3-expected.txt: Added.
- editing/pasteboard/4930986-3.html: Added.
Visual problem fixed. An anonymous renderer changed position, DOM remains unchanged:
- editing/execCommand/5144139-1.html:
- platform/mac/editing/execCommand/5144139-1-expected.checksum:
- platform/mac/editing/execCommand/5144139-1-expected.png:
- platform/mac/editing/execCommand/5144139-1-expected.txt:
Removed unnecessary style spans, visual result unchanged:
- platform/mac/editing/pasteboard/merge-end-blockquote-expected.checksum:
- platform/mac/editing/pasteboard/merge-end-blockquote-expected.png:
- platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
- platform/mac/editing/style/font-family-with-space-expected.checksum:
- platform/mac/editing/style/font-family-with-space-expected.png:
- platform/mac/editing/style/font-family-with-space-expected.txt:
A style span isn't removed because at paste time because we don't anticipate
encountering styles on style spans that are non-inheritable, because we don't
create style spans like that at copy time. Turned this into a text only
test. Test remains visually unchanged:
- editing/pasteboard/5245519-expected.txt: Added.
- editing/pasteboard/5245519.html:
- platform/mac/editing/pasteboard/5245519-expected.checksum: Removed.
- platform/mac/editing/pasteboard/5245519-expected.png: Removed.
- platform/mac/editing/pasteboard/5245519-expected.txt: Removed.
Added an extra empty anonymous renderer, DOM and visual result remain unchanged:
- platform/mac/editing/execCommand/create-list-with-hr-expected.checksum:
- platform/mac/editing/execCommand/create-list-with-hr-expected.png:
- platform/mac/editing/execCommand/create-list-with-hr-expected.txt:
- platform/mac/editing/pasteboard/paste-list-001-expected.checksum:
- platform/mac/editing/pasteboard/paste-list-001-expected.png:
- platform/mac/editing/pasteboard/paste-list-001-expected.txt:
- platform/mac/editing/pasteboard/paste-table-001-expected.checksum:
- platform/mac/editing/pasteboard/paste-table-001-expected.png:
- platform/mac/editing/pasteboard/paste-table-001-expected.txt:
- platform/mac/editing/pasteboard/paste-text-003-expected.checksum:
- platform/mac/editing/pasteboard/paste-text-003-expected.png:
- platform/mac/editing/pasteboard/paste-text-003-expected.txt:
Reflects changes to CSSComputedStyleDeclaration::getPropertyCSSValue:
- fast/css/computed-style-expected.txt:
- fast/css/computed-style-without-renderer-expected.txt:
We don't remove styles from style spans that are overridden by all of their
children, even though they are unnecessary. We've never done this, but now
that there can be two style spans at paste time we are more likely to have
a style span left over because of this problem. Mentioned this in the test
case and turned this into a text only test:
- editing/pasteboard/4840662.html:
- editing/pasteboard/4840662-expected.txt: Added.
- platform/mac/editing/pasteboard/4840662-expected.checksum: Removed.
- platform/mac/editing/pasteboard/4840662-expected.png: Removed.
- platform/mac/editing/pasteboard/4840662-expected.txt: Removed.
- 12:24 PM Changeset in webkit [30648] by
-
- 3 edits in trunk/WebCore
2008-02-28 Brent Fulgham <bfulgham@gmail.com>
http://bugs.webkit.org/show_bug.cgi?id=17576
Modify RenderThemeWin to use SOFT_LINK
Reviewed by Adam Roben.
- rendering/RenderThemeWin.h: Remove unneeded library handle
- rendering/RenderThemeWin.cpp: Change to use SOFT_LINK rather than hand-coded load library calls.
- 10:19 AM Changeset in webkit [30647] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=17590 ASSERTION FAILED: subject in jsRegExpExecute()
- page/mac/FrameMac.mm: (WebCore::Frame::matchLabelsAgainstElement): Added an early return in case the element name is empty.
- 1:26 AM Changeset in webkit [30646] by
-
- 2 edits in trunk/WebCore
Reviewed by Dan Bernstein
Small editing speed up.
- dom/Position.cpp: (WebCore::Position::upstream): Don't check for a change in editability if the current node hasn't changed. (WebCore::Position::downstream): Ditto.
- 12:21 AM Changeset in webkit [30645] by
-
- 2 edits in trunk
2008-02-28 Alp Toker <alp@atoker.com>
Fix a configure script typo spotted by Kalle Vahlman.
- configure.ac:
Feb 27, 2008:
- 9:38 PM Changeset in webkit [30644] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by John Sullivan.
- fix <rdar://problem/5607547> Single letter surrounded by soft hyphens can disappear
Test: fast/text/soft-hyphen-2.html
- rendering/bidi.cpp: (WebCore::chopMidpointsAt): Changed to iterate midpoints backwards, so that if there are two midpoints at the given position, only the last one will be chopped off.
LayoutTests:
Reviewed by John Sullivan.
- test for <rdar://problem/5607547> Single letter surrounded by soft hyphens can disappear
- fast/text/soft-hyphen-2.html: Added.
- platform/mac/fast/text/soft-hyphen-2-expected.checksum: Added.
- platform/mac/fast/text/soft-hyphen-2-expected.png: Added.
- platform/mac/fast/text/soft-hyphen-2-expected.txt: Added.
- 6:52 PM Changeset in webkit [30643] by
-
- 2 edits in trunk/LayoutTests
Updated resource used in the layout test I landed yesterday.
Due to a difference between Foundation on Tiger vs Leopard, the resource generated on
Leopard caused different results on Leopard and Tiger.
Regenerating the resource on Tiger, however, agrees with Leopard.
- webarchive/loading/resources/cache-expired-subresource.webarchive:
- 6:23 PM Changeset in webkit [30642] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- make centered text in right-to-left blocks spill over to the left
Test: fast/text/align-center-rtl-spill.html
- rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine):
LayoutTests:
Reviewed by Darin Adler.
- test that centered text in right-to-left blocks spills over to the left
- fast/text/align-center-rtl-spill.html: Added.
- platform/mac/fast/text/align-center-rtl-spill-expected.checksum: Added.
- platform/mac/fast/text/align-center-rtl-spill-expected.png: Added.
- platform/mac/fast/text/align-center-rtl-spill-expected.txt: Added.
- 5:40 PM Changeset in webkit [30641] by
-
- 2 edits in trunk/WebKitLibraries
Tiger build fix
- libWebKitSystemInterfaceTiger.a:
- 5:06 PM Changeset in webkit [30640] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin Adler.
- more bidi.cpp cleanup
- platform/text/BidiResolver.h: (WebCore::BidiCharacterRun::destroy): Added. Overridden by BidiRun . (WebCore::BidiResolver<Iterator, Run>::addRun): Moved BidiState::addRun() here. (WebCore::BidiResolver<Iterator, Run>::appendRun): Changed to use addRun(). (WebCore::BidiResolver<Iterator, Run>::deleteRuns): Changed to use destroy(), avoiding the need to specialize this method in BidiState.
- rendering/bidi.cpp: (WebCore::BidiRun::destroy): Removed the RenderArena parameter. (WebCore::BidiState::deleteRuns): Removed now-unnecessary specialization. (WebCore::BidiState::addRun): Removed now-unnecessary specialization. (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added a FIXME. (WebCore::RenderBlock::computeVerticalPositionsForLine): (WebCore::buildCompactRuns): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::determineEndPosition): (WebCore::RenderBlock::matchedEndLine): (WebCore::skipNonBreakingSpace): (WebCore::RenderBlock::skipWhitespace): (WebCore::shouldSkipWhitespaceAfterStartObject):
- rendering/bidi.h: (WebCore::BidiRun): Added m_ prefixes to several member variables.
- 4:52 PM Changeset in webkit [30639] by
-
- 4 edits in branches/Safari-3-1-branch
Versioning.
- 4:51 PM Changeset in webkit [30638] by
-
- 1 copy in tags/Safari-5525.12
New tag.
- 4:42 PM Changeset in webkit [30637] by
-
- 4 edits in trunk/WebKitLibraries
Reviewed by Mark Rowe
Removed some unused methods:
WKGetNSURLResponseCalculatedExpiration
WKGetNSURLResponseMustRevalidate
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 4:32 PM Changeset in webkit [30636] by
-
- 8 edits in branches/Safari-3-1-branch
Merge r30634.
- 4:20 PM Changeset in webkit [30635] by
-
- 6891 edits in trunk/LayoutTests
Rubber-stamped by Adam.
Fix svn:eol-style on all LayoutTest results
I simply ran:
cd LayoutTests
find . -name "*-expected.txt" | xargs svn ps svn:eol-style native
- 3:59 PM Changeset in webkit [30634] by
-
- 8 edits in trunk
WebCore:
Reviewed by Darin.
Fix for <rdar://problem/5768769>
- Don't allow cross-origin calls using window.functionName.call(otherFrame) syntax.
- bindings/js/JSLocation.cpp: (WebCore::jsLocationProtoFuncToString): Do same-origin check.
- bindings/js/kjs_window.cpp: (KJS::windowProtoFuncAToB): Ditto. (KJS::windowProtoFuncBToA): Ditto. (KJS::windowProtoFuncOpen): Ditto. (KJS::windowProtoFuncClearTimeout): Ditto.
- bindings/scripts/CodeGeneratorJS.pm: Ditto.
LayoutTests:
Reviewed by Darin.
Updates tests for <rdar://problem/5768769>
- http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
- http/tests/security/cross-frame-access-call-expected.txt:
- http/tests/security/cross-frame-access-call.html:
- 3:13 PM Changeset in webkit [30633] by
-
- 56 edits in trunk/WebCore
More cleanup in preparation for fixing the HTML5 spec performance regression.
Reviewed by Sam Weinig
- dom/Attr.cpp: (WebCore::Attr::childrenChanged):
- dom/Attr.h:
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::removeChildren): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::addChild): (WebCore::ContainerNode::childrenChanged):
- dom/ContainerNode.h:
- dom/Document.cpp: (WebCore::Document::childrenChanged):
- dom/Document.h:
- dom/Element.cpp: (WebCore::Element::childrenChanged):
- dom/Element.h:
- dom/Node.h: (WebCore::Node::childrenChanged):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::childrenChanged):
- html/HTMLObjectElement.h:
- html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::childrenChanged):
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::childrenChanged):
- html/HTMLOptionElement.h:
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::childrenChanged):
- html/HTMLScriptElement.h:
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::childrenChanged):
- html/HTMLSelectElement.h:
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::childrenChanged):
- html/HTMLStyleElement.h:
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::childrenChanged):
- html/HTMLTextAreaElement.h:
- html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::childrenChanged):
- html/HTMLTitleElement.h:
- svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::childrenChanged):
- svg/SVGClipPathElement.h:
- svg/SVGDefinitionSrcElement.cpp: (WebCore::SVGDefinitionSrcElement::childrenChanged):
- svg/SVGDefinitionSrcElement.h:
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::childrenChanged):
- svg/SVGFontFaceElement.h:
- svg/SVGFontFaceFormatElement.cpp: (WebCore::SVGFontFaceFormatElement::childrenChanged):
- svg/SVGFontFaceFormatElement.h:
- svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::childrenChanged):
- svg/SVGFontFaceSrcElement.h:
- svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::childrenChanged):
- svg/SVGFontFaceUriElement.h:
- svg/SVGGElement.cpp: (WebCore::SVGGElement::childrenChanged):
- svg/SVGGElement.h:
- svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::childrenChanged):
- svg/SVGGradientElement.h:
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::childrenChanged):
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::childrenChanged):
- svg/SVGMaskElement.h:
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::childrenChanged):
- svg/SVGPatternElement.h:
- svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::childrenChanged):
- svg/SVGStyleElement.h:
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::childrenChanged):
- svg/SVGStyledElement.h:
- svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::childrenChanged):
- svg/SVGTitleElement.h:
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::childrenChanged):
- svg/SVGUseElement.h:
- 3:09 PM Changeset in webkit [30632] by
-
- 5 edits3 adds in trunk
WebKit/mac:
Reviewed by Mark Rowe (code) and Darin (concept)
Much better fix for <rdar://problem/4930688> (see r19549)
Original fix for <rdar://problem/3947312> (and 14 dupes)
Let me tell you a story:
A long time ago, in a cvs repository far, far away, loader code was almost all up in WebKit.
WebArchive code was intertwined with that code in bizarre and complex ways.
During the months long loader re-factoring where we pushed much loader code down into WebCore,
many portions of the WebKit loader were thinned out until they ceased to exist. Others remained
with a sole purpose.
One such section of code whose lineage traces back from WebFrameLoaderClient to WebFrameLoader
to WebLoader was originally rooted in the method [WebLoader loadRequest:]. This method was the
single entry point for almost all loading (network or web archives)
This method would check various headers and other fields on the NSURLRequest and NSURLResponse
to make decisions about the load. If the cache control fields were expired or other conditions
in the headers were met, the load would be forced to go out to the network.
As the loader was moved and tweaked repeatedly, most of this code was pruned or re-factored.
At some point, all that remained was the special cases for loading WebArchives.
Somewhere in the r16,000s, this remaining responsibility was noticed and related methods we renamed
to be WebArchive specific, further cementing the assumed design.
Problem is, the design was bad. A WebArchive is meant to be a static snapshot of a WebPage at a
specific point in time. Referring to the request to see if the resource should be reloaded seems
nonsensical, as does referring to the response headers to see if the resource is "expired". In the
context of loading a WebArchive, available data should *always* be loaded from the WebArchive, at least
during the initial load!
After discovering the secret to reproducing all of these bugs is both emptying our your Foundation
cache and disconnecting your network, it was easy to reproduce the 16 individually reported cases
that were all symptoms of this bug, and easy to verify that they are fixed with this patch.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::willUseArchive): Do not call either form of "canUseArchivedResource()" that inspect the request or response objects - We are loading from a WebArchive, and we should never make the decision to go out to the network when we actually have the resource available.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Remove two methods that are no longer used anywhere in WebKit
LayoutTests:
Reviewed by Mark Rowe
Test for better fix for <rdar://problem/4930688> (see r19549) and
original fix for <rdar://problem/3947312> (and 14 dupes)
Crafting custom WebArchives for layout tests is a pain and something that should
be resolved if we decide to pursue a new format.
Using a custom php script to act as a stand in for an image resource, I set its
cache-control header to expire immediately. Without the fix for the above bugs,
the resource will be "expired" and an attempt to fetch it from the network will
go out and fail. This failure will manifest with different ResourceLoadDelegate
information, as well as different dimensions in the render tree - the missing
image icon versus the archived image.
With the fix in place, the response will be ignored and the image will be pulled
from the WebArchive.
- webarchive/loading/cache-expired-subresource-expected.txt: Added.
- webarchive/loading/cache-expired-subresource.html: Added.
- webarchive/loading/resources/cache-expired-subresource.webarchive: Added.
- 3:07 PM Changeset in webkit [30631] by
-
- 5 edits2 adds in trunk/WebKit
WebKit/mac:
Reviewed by Adam Roben.
Bug 14348: Messing up the inspector by dragging an URL into it
http://bugs.webkit.org/show_bug.cgi?id=14348
<rdar://problem/5283620> and <rdar://problem/5712808>
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Remove duplicate preference setting. (-[WebInspectorWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
WebKit/win:
Reviewed by Adam Roben.
Bug 14348: Messing up the inspector by dragging an URL into it
http://bugs.webkit.org/show_bug.cgi?id=14348
<rdar://problem/5283620> and <rdar://problem/5712808>
Add a new class to handle the Inspector's delegate calls.
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::createPage):
- WebCoreSupport/WebInspectorDelegate.cpp: Added. (:m_refCount): (WebInspectorDelegate::createInstance): (WebInspectorDelegate::AddRef): (WebInspectorDelegate::Release): (WebInspectorDelegate::dragDestinationActionMaskForDraggingInfo):
- WebCoreSupport/WebInspectorDelegate.h: Added. (WebInspectorDelegate::QueryInterface): (WebInspectorDelegate::createWebViewWithRequest): (WebInspectorDelegate::webViewShow): (WebInspectorDelegate::webViewClose): (WebInspectorDelegate::webViewFocus): (WebInspectorDelegate::webViewUnfocus): (WebInspectorDelegate::webViewFirstResponder): (WebInspectorDelegate::makeFirstResponder): (WebInspectorDelegate::setStatusText): (WebInspectorDelegate::webViewStatusText): (WebInspectorDelegate::webViewAreToolbarsVisible): (WebInspectorDelegate::setToolbarsVisible): (WebInspectorDelegate::webViewIsStatusBarVisible): (WebInspectorDelegate::setStatusBarVisible): (WebInspectorDelegate::webViewIsResizable): (WebInspectorDelegate::setResizable): (WebInspectorDelegate::setFrame): (WebInspectorDelegate::webViewFrame): (WebInspectorDelegate::setContentRect): (WebInspectorDelegate::webViewContentRect): (WebInspectorDelegate::runJavaScriptAlertPanelWithMessage): (WebInspectorDelegate::runJavaScriptConfirmPanelWithMessage): (WebInspectorDelegate::runJavaScriptTextInputPanelWithPrompt): (WebInspectorDelegate::runBeforeUnloadConfirmPanelWithMessage): (WebInspectorDelegate::runOpenPanelForFileButtonWithResultListener): (WebInspectorDelegate::mouseDidMoveOverElement): (WebInspectorDelegate::contextMenuItemsForElement): (WebInspectorDelegate::validateUserInterfaceItem): (WebInspectorDelegate::shouldPerformAction): (WebInspectorDelegate::willPerformDragDestinationAction): (WebInspectorDelegate::dragSourceActionMaskForPoint): (WebInspectorDelegate::willPerformDragSourceAction): (WebInspectorDelegate::contextMenuItemSelected): (WebInspectorDelegate::hasCustomMenuImplementation): (WebInspectorDelegate::trackCustomPopupMenu): (WebInspectorDelegate::measureCustomMenuItem): (WebInspectorDelegate::drawCustomMenuItem): (WebInspectorDelegate::addCustomMenuDrawingData): (WebInspectorDelegate::cleanUpCustomMenuDrawingData): (WebInspectorDelegate::canTakeFocus): (WebInspectorDelegate::takeFocus): (WebInspectorDelegate::registerUndoWithTarget): (WebInspectorDelegate::removeAllActionsWithTarget): (WebInspectorDelegate::setActionTitle): (WebInspectorDelegate::undo): (WebInspectorDelegate::redo): (WebInspectorDelegate::canUndo): (WebInspectorDelegate::canRedo):
- WebKit.vcproj/WebKit.vcproj:
- 2:33 PM Changeset in webkit [30630] by
-
- 4 copies1 add in releases/Apple/Leopard/Mac OS X Update 10.5.2
Release tags for Mac OS X 10.5.2.
- 2:30 PM Changeset in webkit [30629] by
-
- 4 copies1 add in releases/Apple/Leopard/Mac OS X Update 10.5.1
Release tags for Mac OS X 10.5.1 (unchanged from Mac OS X 10.5).
- 2:20 PM Google Summer of Code 2008 edited by
- (diff)
- 2:19 PM Google Summer of Code 2008 edited by
- (diff)
- 10:06 AM Changeset in webkit [30628] by
-
- 1 edit3 adds in trunk/LayoutTests
Landing test that was forgotten in the original patch (r30087).
Test for: http://bugs.webkit.org/show_bug.cgi?id=17191
HTML5: Client-side database queries should return values of type number
- storage/sql-data-types-expected.txt: Added.
- storage/sql-data-types.html: Added.
- storage/sql-data-types.js: Added.
- 9:52 AM Changeset in webkit [30627] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Add bug number to ChangeLog.
- 9:46 AM Changeset in webkit [30626] by
-
- 3 edits2 adds in trunk
2008-02-27 Julien Chaffraix <julien.chaffraix@gmail.com>
Reviewed by Alexey.
http://bugs.webkit.org/show_bug.cgi?id=17481
Several consecutive calls to XMLHttpRequest::open should dispatch only one readyState event
Test: http/tests/xmlhttprequest/xmlhttprequest-multiple-open.html
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open):
- 9:13 AM Changeset in webkit [30625] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Sam Weinig.
http://bugs.webkit.org/show_bug.cgi?id=17030
Small buffer overflow within initialization
- kjs/date_object.cpp: (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate): Remove unnecessary and incorrect memset() calls - GregorianDateTime can initialize itself.
- 8:50 AM Changeset in webkit [30624] by
-
- 2 edits in trunk/WebCore
2008-02-27 Sriram Neelakandan <sriram.neelakandan@gmail.com>
Reviewed, tweaked and landed by ap.
http://bugs.webkit.org/show_bug.cgi?id=17487
HTMLInput mysteriously fails to work if ICU dat file is missing
- platform/text/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Assert that the iterator has been opened.
- 8:38 AM Changeset in webkit [30623] by
-
- 2 edits in trunk/WebKit/gtk
Attempt to fix the GTK+ build
- webkit/webkitwebframe.cpp:
- 8:34 AM Changeset in webkit [30622] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix revision number in ChangeLog
- 8:16 AM Changeset in webkit [30621] by
-
- 2 edits in trunk/WebCore
Windows build fix after r30613
- platform/win/ClipboardWin.cpp:
- 7:12 AM Changeset in webkit [30620] by
-
- 2 edits in trunk/WebCore
Reviewed by Simon.
Small style cleanup, and obvious fix: SVGGElement reacted on
'clipPathUnits' changes, which is a funny copy&paste error.
- 4:38 AM Changeset in webkit [30619] by
-
- 4 edits in trunk/WebCore
Reviewed by Simon.
Cleanup coding style. Still on my way to fix dynamic updates of all SVG elements.
Currently at SVGF*. SVGDefs/DescElement don't need any dyn update fixes but cleanups.
Feb 26, 2008:
- 11:49 PM Changeset in webkit [30618] by
-
- 4 edits in branches/Safari-3-1-branch/WebCore
Merge r30617.
- 10:14 PM Changeset in webkit [30617] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin.
Fix <rdar://problem/5761326>
REGRESSION: 1.5% -2% Sunspider regression from r30009 (ebay photo upload hang)
Generate better code with VS:
- Use ALWAYS_INLINE macro to guarantee versions of allowsAccessFrom() are reduced to single functions
- Refactor error reporting so that there is no need to construct/destruct Strings in common cases
- Add a separate version of the function for cases where error messages are not wanted
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
- bindings/js/kjs_window.cpp: (KJS::Window::allowsAccessFrom): (KJS::Window::allowsAccessFromNoErrorMessage): (KJS::Window::allowsAccessFromPrivate): (KJS::Window::crossDomainAccessErrorMessage):
- bindings/js/kjs_window.h:
- 10:03 PM Google Summer of Code 2008 edited by
- Add cairo SVG and ATK accessibility tasks (diff)
- 8:14 PM Changeset in webkit [30616] by
-
- 8 edits5 deletes in trunk/WebCore
Reviewed by Dave Hyatt.
- remove DeprecatedCString, DeprecatedArray, and ArrayImpl.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- platform/ArrayImpl.cpp: Removed.
- platform/ArrayImpl.h: Removed.
- platform/DeprecatedArray.h: Removed.
- platform/DeprecatedCString.cpp: Removed.
- platform/DeprecatedCString.h: Removed.
- platform/text/CString.cpp: (WebCore::CString::length):
- platform/text/CString.h:
- 7:12 PM Changeset in webkit [30615] by
-
- 7 edits in trunk/WebCore
Cleanup of childrenChanged in preparation for fixing the HTML5 spec slowdown.
Reviewed by Sam Weinig
- dom/Attr.cpp: (WebCore::Attr::childrenChanged):
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::removeChildren): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::addChild): (WebCore::ContainerNode::childrenChanged):
- dom/ContainerNode.h:
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
- dom/EventTargetNode.h:
- dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::addAttribute): (WebCore::NamedAttrMap::removeAttribute):
- 5:56 PM Changeset in webkit [30614] by
-
- 2 edits in trunk/WebKitTools
Improvements to the wx build script.
- 5:43 PM Changeset in webkit [30613] by
-
- 5 edits in trunk/WebCore
Reviewed by Sam.
- remove use of DeprecatedCString from Windows pasteboard code
- platform/win/ClipboardUtilitiesWin.cpp: (WebCore::createGlobalData): Added an overload for Vector<char>. Streamlined the logic a bit. (WebCore::append): Added. Helper functions for appending to a Vector<char>. (WebCore::markupToCF_HTML): Rewrote to use Vector<char> instead of DeprecatedCString. Also simplified the logic a bit and used macros to handle the integer width. (WebCore::urlToMarkup): Use Vector<UChar> instead of String. (WebCore::replaceNewlinesWithWindowsStyleNewlines): Tweaked.
- platform/win/ClipboardUtilitiesWin.h: Update type of return value from markupToCF_HTML. Did a bit of streamlining too.
- platform/win/ClipboardWin.cpp: (WebCore::writeURL): Update for above changes. (WebCore::ClipboardWin::declareAndWriteDragImage): Ditto. (WebCore::ClipboardWin::writeRange): Ditto.
- platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): Ditto. (WebCore::Pasteboard::writeURL): Ditto.
- 4:51 PM Changeset in webkit [30612] by
-
- 5 edits in trunk/WebKit/win
Move ResourceLoadDelegate methods to WebFrameLoaderClient
Changed all methods to use early returns where possible and COMPtr's
AdoptCOM/Query constructors.
Reviewed by Anders.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebFrame.cpp:
- WebFrame.h:
- 4:50 PM Changeset in webkit [30611] by
-
- 5 edits in trunk/WebKit/win
Move two more methods to WebFrameLoaderClient
Reviewed by Anders.
- WebCoreSupport/WebFrameLoaderClient.cpp: (kit): (WebFrameLoaderClient::dispatchCreatePage): Changed nested ifs to early returns, and changed to use the COMPtr Query constructor. (WebFrameLoaderClient::dispatchDidLoadMainResource): Added an early return, and changed to use getWebDataSource.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebFrame.cpp:
- WebFrame.h:
- 4:50 PM Changeset in webkit [30610] by
-
- 3 edits in trunk/WebKit/win
Get rid of IID_WebFrame
Reviewed by Anders.
- WebFrame.cpp: Removed IID_WebFrame definition. (WebFrame::QueryInterface): Use uuidof(WebFrame) instead of IID_WebFrame. (WebFrame::isDescendantOfFrame): Use COMPtr's Query constructor instead of a manual QueryInterface.
- WebFrame.h: Removed IID_WebFrame declaration, gave WebFrame a DECLSPEC_UUID.
- 4:49 PM Changeset in webkit [30609] by
-
- 5 edits in trunk/WebKit/win
Move WebHistory-related methods to WebFrameLoaderClient
Reviewed by Anders.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::shouldGoToHistoryItem): (WebFrameLoaderClient::setTitle): Changed some nested ifs into early returns. (WebFrameLoaderClient::webHistory): Changed to return a COMPtr to make the reference management foolproof.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebFrame.cpp:
- WebFrame.h:
- 4:48 PM Changeset in webkit [30608] by
-
- 5 edits in trunk/WebKit/win
Move cache-related methods to WebFrameLoaderClient
Reviewed by Anders.
- WebCoreSupport/WebFrameLoaderClient.cpp: (getWebDataSource): Moved to the top of the file. (WebFrameLoaderClient::savePlatformDataToCachedPage): (WebFrameLoaderClient::transitionToCommittedForNewPage): (WebFrameLoaderClient::canCachePage):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebFrame.cpp:
- WebFrame.h:
- 4:46 PM Changeset in webkit [30607] by
-
- 6 edits in trunk/WebCore
Reviewed by Adam Roben.
<rdar://problem/5712777> REGRESSION: Arrow up/down in inspector
source list does not scroll when item at edge is reached (16572)
Use scrollIntoViewIfNeeded() instead of the hand-rolled scrollToElement
we were using in utilities.js.
- page/inspector/DocumentPanel.js: Use scrollIntoViewIfNeeded instead of scrollToElement.
- page/inspector/Resource.js: Ditto.
- page/inspector/inspector.js: Ditto.
- page/inspector/SourcePanel.js: Use scrollIntoViewIfNeeded instead of scrollIntoView, so the source line is centered in the view if needed.
- page/inspector/utilities.js: Removed scrollToElement().
- 3:47 PM Changeset in webkit [30606] by
-
- 2 edits in trunk/LayoutTests
Add a skipped storage test for now
- platform/win/Skipped: Added storage/multiple-transactions.html
- 3:17 PM Changeset in webkit [30605] by
-
- 6 adds in trunk/LayoutTests/platform/mac/fast/inline
- 3:17 PM Changeset in webkit [30604] by
-
- 2 adds in trunk/LayoutTests/fast/inline
- 3:17 PM Changeset in webkit [30603] by
-
- 6 edits in trunk/WebCore
Reviewed by Dan
Refine our behavior for empty inlines so that they work more correctly with margins/borders/padding.
Fixes a regression on huffingtonpost.com.
New tests added to fast/inline
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::calcMargins):
- rendering/RenderFlow.h:
- rendering/RenderObject.h: (WebCore::RenderObject::hasHorizontalBordersPaddingOrMargin): (WebCore::RenderObject::hasHorizontalBordersOrPadding):
- rendering/bidi.cpp: (WebCore::getBorderPaddingMargin): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::inlineFlowRequiresLineBox):
- 2:00 PM Changeset in webkit [30602] by
-
- 29 edits in branches/Safari-3-1-branch/LayoutTests
r29650 updated some test results which changed after r29649 landed.
Now that r29649 has been rolled out of this branch, we need to roll
r29650 out as well to keep the tests passing.
Reviewed by Anders and Mark.
- platform/mac/fast/inline/001-expected.checksum:
- platform/mac/fast/inline/001-expected.png:
- platform/mac/fast/inline/002-expected.checksum:
- platform/mac/fast/inline/002-expected.png:
- platform/mac/fast/inline/br-text-decoration-expected.checksum:
- platform/mac/fast/inline/br-text-decoration-expected.png:
- platform/mac/fast/inline/continuation-outlines-expected.checksum:
- platform/mac/fast/inline/continuation-outlines-expected.png:
- platform/mac/fast/inline/continuation-outlines-with-layers-expected.checksum:
- platform/mac/fast/inline/continuation-outlines-with-layers-expected.png:
- platform/mac/fast/inline/dirtyLinesForInline-expected.checksum:
- platform/mac/fast/inline/dirtyLinesForInline-expected.png:
- platform/mac/fast/inline/drawStyledEmptyInlines-expected.checksum:
- platform/mac/fast/inline/drawStyledEmptyInlines-expected.png:
- platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
- platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.checksum:
- platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/mac/fast/inline/emptyInlinesWithinLists-expected.checksum:
- platform/mac/fast/inline/emptyInlinesWithinLists-expected.png:
- platform/mac/fast/inline/emptyInlinesWithinLists-expected.txt:
- platform/mac/fast/inline/inline-borders-with-bidi-override-expected.checksum:
- platform/mac/fast/inline/inline-borders-with-bidi-override-expected.png:
- platform/mac/fast/inline/outline-continuations-expected.checksum:
- platform/mac/fast/inline/outline-continuations-expected.png:
- platform/mac/fast/inline/positionedLifetime-expected.checksum:
- platform/mac/fast/inline/positionedLifetime-expected.png:
- platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.checksum:
- platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.png:
- 1:59 PM Changeset in webkit [30601] by
-
- 1 edit1 add in branches/Safari-3-1-branch/LayoutTests
Merge r30320.
- 1:59 PM Changeset in webkit [30600] by
-
- 21 edits in branches/Safari-3-1-branch/LayoutTests
Merge r30212.
- 1:59 PM Changeset in webkit [30599] by
-
- 2 edits in branches/Safari-3-1-branch/LayoutTests
Update results for a test that is sensitive to ENABLE_CROSS_DOCUMENT_MESSAGING
Reviewed by Anders.
- fast/dom/Window/window-function-name-getter-precedence-expected.txt:
- 1:58 PM Changeset in webkit [30598] by
-
- 2 edits in branches/Safari-3-1-branch/LayoutTests
Enable two fixed tests
Reviewed by Anders.
- platform/win/Skipped:
- 1:54 PM Changeset in webkit [30597] by
-
- 6 edits in trunk
.:
Reviewed by Darin Adler.
Add "64" and "64u" make rules to allow easy building of 64-bit versions.
make 64: will build Intel-only 64-bit.
make 64u: will build 4-way universal for PPC and Intel.
- Makefile:
- Makefile.shared:
WebKitTools:
Reviewed by Darin Adler.
- Scripts/build-webkit: Add --universal and --64-bit flags to make building 64-bit architectures easy. Combine the two flags to build 4-way universal.
- Makefile: Add "64" and "64u" make rules. Fix the universal rule to return non-zero when the build failes.
- 1:22 PM Changeset in webkit [30596] by
-
- 2 edits in trunk/WebCore
Fix Windows build.
- platform/text/PlatformString.h: (WebCore::reverseFind):
- 12:57 PM Google Summer of Code 2008 edited by
- (diff)
- 12:43 PM Google Summer of Code 2008 edited by
- (diff)
- 11:01 AM Changeset in webkit [30595] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=17555 <rdar://problem/5766016> REGRESSION (r27351): Thumbnails positioned wrong on Getty Images results page
Test: fast/dynamic/subtree-table-cell-height.html
- rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): Exclude table cells, since their height depends on their contents even if the CSS height property is fixed.
LayoutTests:
Reviewed by Darin Adler.
- test for http://bugs.webkit.org/show_bug.cgi?id=17555 <rdar://problem/5766016> REGRESSION (r27351): Thumbnails positioned wrong on Getty Images results page
- fast/dynamic/subtree-table-cell-height.html: Added.
- platform/mac/fast/dynamic/subtree-table-cell-height-expected.checksum: Added.
- platform/mac/fast/dynamic/subtree-table-cell-height-expected.png: Added.
- platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Added.
- 10:26 AM Changeset in webkit [30594] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin.
- Scripts/gdb-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in gdb's environment, so that Safari inherits it when launched. Preexisting code in WebKit checks this environment variable, and if set, unsets DYLD_FRAMEWORK_PATH, so that applications launched by Safari continue to use the standard system WebKit.
- 9:06 AM Changeset in webkit [30593] by
-
- 6 edits in trunk
Reviewed by Dan Bernstein.
- Add a variant of remove that takes a position and a length.
- wtf/Vector.h: (WTF::Vector::remove):
WebCore:
Reviewed by Dan Bernstein.
Make the cleanPath function in CSSStyleSelector more efficient by using
a Vector<UChar>.
- css/CSSStyleSelector.cpp: (WebCore::cleanPath): Make this function work on a Vector<UChar> instead of a String. Also remove unnecessary reverseFind call that could be acomplished with two compares. (WebCore::checkPseudoState): Remove reserveCapacity calls now that we are using a stack buffer.
- platform/text/PlatformString.h: (WebCore::find): Make this find generic enough that it can be used for String::find. (WebCore::reverseFind): Implement reverseFind so that it can be used for with a UChar* and length.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::find): Use implementation in PlatformString.cpp (WebCore::StringImpl::reverseFind): Ditto,
- 7:24 AM Google Summer of Code 2008 edited by
- Added ideas from the SummerOfCodeIdeas page (diff)
- 2:15 AM Changeset in webkit [30592] by
-
- 4 edits2 adds in trunk
Reviewed by Darin. Tweaked and landed by Alexey.
http://bugs.webkit.org/show_bug.cgi?id=17411
Ideographic comma and full stop should be treated as line-breakable characters
Test: fast/text/line-breaks-after-ideographic-comma-or-full-stop.html
- platform/text/CharacterNames.h: Added ideographicComma and ideographicFullStop.
- rendering/break_lines.cpp: (WebCore::shouldBreakAfter): Added a workaround for an issue in Unicode 5.0 that is causing this.
- 12:56 AM Changeset in webkit [30591] by
-
- 3 edits in trunk/WebCore
Reviewed by eseidel. Landed by eseidel
Fix improperly initialized m_isUpToDate member variable.
Fixs 50+ layout tests when run on Tiger.
http://bugs.webkit.org/show_bug.cgi?id=17549
- platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
- platform/network/mac/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
Feb 25, 2008:
- 11:30 PM Google Summer of Code 2008 edited by
- (diff)
- 11:05 PM Google Summer of Code 2008 created by
- 10:47 PM Changeset in webkit [30590] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix http://bugs.webkit.org/show_bug.cgi?id=17152 Paragraphs indented with :first-letter and text-align CSS render incorrectly
Test: fast/text/apply-start-width-after-skipped-text.html
- rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Improved the logic for when to figure in the padding, border and margin before a text node when the line begins inside a text node.
LayoutTests:
Reviewed by Sam Weinig.
- test for http://bugs.webkit.org/show_bug.cgi?id=17152 Paragraphs indented with :first-letter and text-align CSS render incorrectly
- fast/text/apply-start-width-after-skipped-text.html: Added.
- platform/mac/fast/text/apply-start-width-after-skipped-text-expected.checksum: Added.
- platform/mac/fast/text/apply-start-width-after-skipped-text-expected.png: Added.
- platform/mac/fast/text/apply-start-width-after-skipped-text-expected.txt: Added.
- 10:47 PM WikiStart edited by
- (diff)
- 10:20 PM Changeset in webkit [30589] by
-
- 2 edits in trunk/WebCore
Windows build fix for wx port.
- 9:00 PM Changeset in webkit [30588] by
-
- 2 edits in trunk/WebCore
2008-02-25 Mark Rowe <mrowe@apple.com>
Windows build fix.
- platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformCompare): Implement platformCompare for ResourceResponseCFNet.cpp.
- 8:25 PM Changeset in webkit [30587] by
-
- 4 edits2 adds in trunk
WebCore:
Reviewed by Geoff.
Fixed for <rdar://problem/5760530> REGRESSION: Assertion failure in
Document::removePendingSheet() from r30438
r30438 added a call to CachedResource::error() from inside
Loader::didReceiveData() if a CSS file 4xxs. There was an
assumption in the loader, though, that either error() would be
called, or didFinishLoading() would be called, so some work is
duplicated in each. Now that we are calling an error() on files
that will also make it to didFinishLoading() (since they succeeded
in the network layer), we need to make sure we do not duplicate the
work. CachedCSSStyleSheet::error() calls checkNotify, which ends up
decrementing the document's pending style sheet counter.
checkNotify() was still getting called, though, through the normal
didFinishLoading code path, and the counter was being decremented
twice. Bad!
- loader/loader.cpp: (WebCore::Loader::didFinishLoading): (WebCore::Loader::didReceiveData):
LayoutTests:
Reviewed by Geoff.
Test for <rdar://problem/5760530> REGRESSION: Assertion failure in
Document::removePendingSheet() from r30438
- http/tests/misc/missing-style-sheet-expected.txt: Added.
- http/tests/misc/missing-style-sheet.html: Added.
- 8:01 PM Changeset in webkit [30586] by
-
- 5 edits in trunk/WebCore
Fix the Gtk, wx and Qt builds.
- 6:22 PM Changeset in webkit [30585] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix bug number in ChangeLog.
- 6:21 PM Changeset in webkit [30584] by
-
- 20 edits4 moves8 adds in trunk/WebCore
2008-02-25 MorganL <morganl.webkit@yahoo.com>
Reviewed by Darin Adler.
Eliminate some #ifdefs from headers in platform/network.
http://bugs.webkit.org/show_bug.cgi?id=11786
- WebCore.base.exp:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/XMLTokenizer.cpp:
- loader/ResourceLoader.h:
- platform/network/AuthenticationChallenge.cpp: Removed.
- platform/network/AuthenticationChallenge.h: Removed.
- platform/network/AuthenticationChallengeBase.cpp: Copied from platform/network/AuthenticationChallenge.cpp. (WebCore::AuthenticationChallengeBase::AuthenticationChallengeBase): (WebCore::AuthenticationChallengeBase::previousFailureCount): (WebCore::AuthenticationChallengeBase::proposedCredential): (WebCore::AuthenticationChallengeBase::protectionSpace): (WebCore::AuthenticationChallengeBase::failureResponse): (WebCore::AuthenticationChallengeBase::error): (WebCore::AuthenticationChallengeBase::isNull): (WebCore::AuthenticationChallengeBase::nullify): (WebCore::AuthenticationChallengeBase::compare):
- platform/network/AuthenticationChallengeBase.h: Copied from platform/network/AuthenticationChallenge.h. (WebCore::AuthenticationChallengeBase::platformCompare): (WebCore::operator==): (WebCore::operator!=):
- platform/network/ResourceError.cpp: Removed.
- platform/network/ResourceError.h: Removed.
- platform/network/ResourceErrorBase.cpp: Copied from platform/network/ResourceError.cpp. (WebCore::ResourceErrorBase::lazyInit): (WebCore::ResourceErrorBase::compare):
- platform/network/ResourceErrorBase.h: Copied from platform/network/ResourceError.h. (WebCore::ResourceErrorBase::isNull): (WebCore::ResourceErrorBase::domain): (WebCore::ResourceErrorBase::errorCode): (WebCore::ResourceErrorBase::failingURL): (WebCore::ResourceErrorBase::localizedDescription): (WebCore::ResourceErrorBase::ResourceErrorBase): (WebCore::ResourceErrorBase::platformLazyInit): (WebCore::ResourceErrorBase::platformCompare): (WebCore::operator==):
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::isHTTP): (WebCore::ResourceResponseBase::url): (WebCore::ResourceResponseBase::setUrl): (WebCore::ResourceResponseBase::mimeType): (WebCore::ResourceResponseBase::setMimeType): (WebCore::ResourceResponseBase::expectedContentLength): (WebCore::ResourceResponseBase::setExpectedContentLength): (WebCore::ResourceResponseBase::textEncodingName): (WebCore::ResourceResponseBase::setTextEncodingName): (WebCore::ResourceResponseBase::suggestedFilename): (WebCore::ResourceResponseBase::setSuggestedFilename): (WebCore::ResourceResponseBase::httpStatusCode): (WebCore::ResourceResponseBase::setHTTPStatusCode): (WebCore::ResourceResponseBase::httpStatusText): (WebCore::ResourceResponseBase::setHTTPStatusText): (WebCore::ResourceResponseBase::httpHeaderField): (WebCore::ResourceResponseBase::setHTTPHeaderField): (WebCore::ResourceResponseBase::httpHeaderFields): (WebCore::ResourceResponseBase::isAttachment): (WebCore::ResourceResponseBase::setExpirationDate): (WebCore::ResourceResponseBase::expirationDate): (WebCore::ResourceResponseBase::setLastModifiedDate): (WebCore::ResourceResponseBase::lastModifiedDate): (WebCore::ResourceResponseBase::lazyInit): (WebCore::ResourceResponseBase::compare):
- platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::ResourceResponseBase::platformLazyInit): (WebCore::ResourceResponseBase::platformCompare): (WebCore::operator==):
- platform/network/cf/AuthenticationCF.cpp: (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::platformCompare):
- platform/network/cf/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::sourceHandle): (WebCore::AuthenticationChallenge::cfURLAuthChallengeRef):
- platform/network/cf/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
- platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::platformLazyInit): (WebCore::ResourceError::platformCompare): (WebCore::ResourceError::operator CFStreamError):
- platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
- platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
- platform/network/curl/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge):
- platform/network/curl/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
- platform/network/curl/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
- platform/network/mac/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::sender): (WebCore::AuthenticationChallenge::nsURLAuthenticationChallenge):
- platform/network/mac/AuthenticationMac.mm: (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::platformCompare):
- platform/network/mac/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
- platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::platformLazyInit): (WebCore::ResourceError::platformCompare):
- platform/network/mac/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
- platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): (WebCore::ResourceResponse::platformCompare):
- platform/network/qt/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge):
- platform/network/qt/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
- platform/network/qt/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
- xml/XSLTProcessor.cpp:
- 5:06 PM Changeset in webkit [30583] by
-
- 2 edits in trunk/WebKitTools
Fix run-webkit-tests after r30394
- Scripts/webkitdirs.pm: Never append _debug to FindSafari's executable name.
- 5:05 PM Changeset in webkit [30582] by
-
- 5 edits in trunk/WebKit/win
Move plugin-related methods to WebFrameLoaderClient
Reviewed by Anders.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::committedLoad): Added some early returns. (WebFrameLoaderClient::receivedData): (WebFrameLoaderClient::finishedLoading): Ditto. (getWebDataSource): (WebFrameLoaderClient::createPlugin):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebFrame.cpp: (WebFrame::WebFramePrivate::WebFramePrivate):
- WebFrame.h:
- 5:05 PM Changeset in webkit [30581] by
-
- 5 edits in trunk/WebKit/win
Move createFrame to WebFrameLoaderClient
Reviewed by Anders.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createFrame): (WebFrameLoaderClient::loadURLIntoChild):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebFrame.cpp:
- WebFrame.h:
- 5:04 PM Changeset in webkit [30580] by
-
- 5 edits in trunk/WebKit/win
Move progress-related methods to WebFrameLoaderClient
Reviewed by Anders.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::postProgressStartedNotification): (WebFrameLoaderClient::postProgressEstimateChangedNotification): (WebFrameLoaderClient::postProgressFinishedNotification):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebFrame.cpp:
- WebFrame.h:
- 5:01 PM Changeset in webkit [30579] by
-
- 3 edits in trunk/WebKit/win
Remove WebFrame::detachedFromParent1
This method was removed from FrameLoaderClient in r19042, but was
never removed from WebFrame.
Reviewed by Anders.
- WebFrame.cpp:
- WebFrame.h:
- 4:52 PM BuildingCairoOnWindows edited by
- (diff)
- 4:28 PM Changeset in webkit [30578] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by T3h Mitz Pettel (Dan Bernstein)
Layout test for already fixed bug <rdar://problem/5729445>
- storage/multiple-transactions-expected.txt: Added.
- storage/multiple-transactions.html: Added.
- 2:57 PM Changeset in webkit [30577] by
-
- 7 edits in trunk/WebCore
Reviewed by Darin.
Move remaining render style objects over to start with a refcount of 1 and get
rid of DeprecatedDataRef.
- rendering/DataRef.h: (WebCore::DataRef::operator*): (WebCore::DataRef::operator->):
- rendering/RenderStyle.h:
- rendering/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::SVGRenderStyle):
- rendering/SVGRenderStyle.h: (WebCore::SVGRenderStyle::create): (WebCore::SVGRenderStyle::copy):
- rendering/SVGRenderStyleDefs.cpp: (StyleFillData::StyleFillData): (StyleStrokeData::StyleStrokeData): (StyleStopData::StyleStopData): (StyleTextData::StyleTextData): (StyleClipData::StyleClipData): (StyleMaskData::StyleMaskData): (StyleMarkerData::StyleMarkerData): (StyleMiscData::StyleMiscData):
- rendering/SVGRenderStyleDefs.h: (WebCore::StyleFillData::create): (WebCore::StyleFillData::copy): (WebCore::StyleStrokeData::create): (WebCore::StyleStrokeData::copy): (WebCore::StyleStopData::create): (WebCore::StyleStopData::copy): (WebCore::StyleTextData::create): (WebCore::StyleTextData::copy): (WebCore::StyleClipData::create): (WebCore::StyleClipData::copy): (WebCore::StyleMaskData::create): (WebCore::StyleMaskData::copy): (WebCore::StyleMarkerData::create): (WebCore::StyleMarkerData::copy): (WebCore::StyleMiscData::create): (WebCore::StyleMiscData::copy):
- 2:44 PM Changeset in webkit [30576] by
-
- 4 edits in trunk/JavaScriptCore
2008-02-25 Mark Mentovai <mark@moxienet.com>
Reviewed by Mark Rowe.
Enable CollectorHeapIntrospector to build by itself, as well as in an AllInOneFile build.
http://bugs.webkit.org/show_bug.cgi?id=17538
- kjs/CollectorHeapIntrospector.cpp: Provide "using" declaration for WTF::RemoteMemoryReader.
- kjs/collector.h: Move CollectorHeap declaration here...
- kjs/collector.cpp: ... from here.
- 2:03 PM Changeset in webkit [30575] by
-
- 4 edits in trunk/WebCore
Reviewed by Dave Hyatt.
- remove file-static BidiRun variables from bidi.cpp
- platform/text/BidiResolver.h: (WebCore::BidiResolver::): Initialize m_logicallyLastRun. (WebCore::BidiResolver::logicallyLastRun): Added. (WebCore::BidiResolver::runCount): Made unsigned. (WebCore::::reverseRuns): Changed ints to unsigned. (WebCore::::createBidiRunsForLine): Made this function set m_logicallyLastRun.
- rendering/RenderBlock.h:
- rendering/bidi.cpp: (WebCore::BidiState::addRun): Removed setting of sLogicallyLastBidiRun. (WebCore::RenderBlock::constructLine): Removed unused start parameter and added run count and first and last run parameters. Replaced end parameter with lastLine boolean and endObject pointer. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added first and logically last run parameters. (WebCore::RenderBlock::computeVerticalPositionsForLine): Added firstRun parameter. (WebCore::RenderBlock::bidiReorderLine): Removed setting of static variables. (WebCore::RenderBlock::layoutInlineChildren): Changed to use BidiState accessors instead of file statics.
- 1:58 PM Changeset in webkit [30574] by
-
- 16 edits1 copy1 delete in trunk/WebCore
2008-02-25 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Jon Honeycutt.
http://bugs.webkit.org/show_bug.cgi?id=16924
Bug 16924: Shared PluginDatabase, PluginPackage, and PlugInInfoStore implementations
Add PluginInfoStore.cpp and new PluginDatabase.cpp to GTK+ and Qt ports.
Remove old PlugInInfoStoreQt.cpp as it is obsoleted by shared code.
Add PluginInfoStore, PluginDatabase, and PluginStream files to Wx build.
Add new PluginDatabase.cpp to Windows build.
Add temporary stubs for new PluginDatabase and PluginPackage.
shared classes to GTK+, Qt, and Wx ports.
Copy PluginDatabaseWin.cpp to PluginDatabase.cpp to preserve history.
Remove shared code from PluginDatabaseWin.cpp.
Remove Windows-specific code from PluginDatabase.cpp.
Use PlatformModule and PlatformFileTime instead of HMODULE and FILETIME.
- Remove extraneous PluginPackage
- from hash() class method prototype. Subsume storeFileVersion into PluginPackage::fetchInfo. Add cross-platform PlatformModuleVersion type definition. Use PlatformModuleVersion to store the module version. Rename m_fileVersion[ML]S to m_moduleVersion. Change compareFileVersion to use PlatformModuleVersion as the argument. Move PluginView::determineQuirks and m_quirks to PluginPackage. Updated determineQuirks for the PlatformModuleVersion.
- GNUmakefile.am:
- WebCore.pro:
- WebCoreSources.bkl:
- webcore-base.bkl:
- WebCore.vcproj/WebCore.vcproj:
- Platform/FileSystem.h:
- platform/qt/PlugInInfoStoreQt.cpp:
- platform/gtk/TemporaryLinkStubs.cpp:
- platform/qt/TemporaryLinkStubs.cpp:
- platform/wx/TemporaryLinkStubs.cpp:
- plugins/PluginDatabase.cpp:
- plugins/PluginDatabase.h:
- plugins/win/PluginDatabaseWin.cpp:
- plugins/PluginPackage.h:
- plugins/win/PluginPackageWin.cpp:
- plugins/PluginView.h:
- plugins/win/PluginViewWin.cpp:
- 1:51 PM Changeset in webkit [30573] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin.
Make more style objects start out with a refcount of 1.
- rendering/RenderStyle.cpp: (WebCore::StyleSurroundData::StyleSurroundData): (WebCore::StyleBoxData::StyleBoxData): (WebCore::StyleVisualData::StyleVisualData): (WebCore::StyleBackgroundData::StyleBackgroundData): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleInheritedData::StyleInheritedData):
- rendering/RenderStyle.h: (WebCore::StyleSurroundData::create): (WebCore::StyleSurroundData::copy): (WebCore::StyleBoxData::create): (WebCore::StyleBoxData::copy): (WebCore::StyleVisualData::create): (WebCore::StyleVisualData::copy): (WebCore::StyleBackgroundData::create): (WebCore::StyleBackgroundData::copy): (WebCore::StyleBackgroundData::~StyleBackgroundData): (WebCore::StyleRareNonInheritedData::create): (WebCore::StyleRareNonInheritedData::copy): (WebCore::StyleRareInheritedData::create): (WebCore::StyleRareInheritedData::copy): (WebCore::StyleInheritedData::create): (WebCore::StyleInheritedData::copy):
- 12:00 PM Changeset in webkit [30572] by
-
- 5 edits in trunk/WebCore
Reviewed by Darin.
Make some of the refcounted style objects start out with a refcount of 1.
- rendering/DataRef.h: Make a DeprecatedDataRef class which is just a copy of the old DataRef class. Change DataRef to use ::create() and ::copy() instead of the constructors. Change DataRef's pointer to be a RefPtr instead.
- rendering/RenderStyle.cpp: (WebCore::StyleMarqueeData::StyleMarqueeData): (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData): (WebCore::StyleMultiColData::StyleMultiColData): (WebCore::StyleTransformData::StyleTransformData): Start with a RefCount of 1.
- rendering/RenderStyle.h:
- rendering/SVGRenderStyle.h: Add ::create() and ::copy() methods. Make not yet converted classes use DeprecatedDataRef.
- 9:33 AM Changeset in webkit [30571] by
-
- 3 edits3 adds in trunk
WebCore:
Reviewed by Anders.
Based on a patch by Tim Steele <timsteele41@gmail.com>.
- fix http://bugs.webkit.org/show_bug.cgi?id=17186 Fragment navigation within a page permanently cancels meta refresh
Test: fast/loader/meta-refresh-anchor-click.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::load): When load type is FrameLoadTypeRedirectWithLockedHistory, always do a real load. This makes sure that meta refresh loads are treated as real loads rather than anchor scrolls. Also tweaked formatting a bit. (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): This function is an alternate way to complete a load, so it needs to start the redirection timer if redirection has already been scheduled.
LayoutTests:
Reviewed by Anders.
- test for http://bugs.webkit.org/show_bug.cgi?id=17186 Fragment navigation within a page permanently cancels meta refresh
- fast/loader/meta-refresh-anchor-click-expected.txt: Added.
- fast/loader/meta-refresh-anchor-click.html: Added.
- fast/loader/resources/meta-refresh-subframe.html: Added.
- 9:11 AM Changeset in webkit [30570] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- avoid counting spaces in non-justified text
- rendering/bidi.cpp: Removed file-static numSpaces. (WebCore::BidiState::addRun): Removed space counting. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added space counting, conditional on the block having the text-align: justify property value. (WebCore::RenderBlock::bidiReorderLine): Removed initialization of numSpaces.
- 9:10 AM Changeset in webkit [30569] by
-
- 2 edits in trunk/WebCore
Requested by Steve.
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::createFrameAtIndex): Put the string into a global variable (because CFSTR is inefficient on Windows).
- 9:06 AM Changeset in webkit [30568] by
-
- 6 edits in trunk
Reviewed by Adam.
- JavaScriptCore.exp: Sort the contents of this file.
WebCore:
Reviewed by Adam.
- WebCore.base.exp: Export blankURL, and sort the file.
WebKit/mac:
Reviewed by Adam.
- WebView/WebArchiver.mm: (+[WebArchiver archiveSelectionInFrame:]): Use blankURL.
- WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Avoid the variable name URL to avoid clashing with the renamed KURL in the future. Also use blankURL. (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Ditto. (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Ditto. (-[WebFrame loadHTMLString:baseURL:]): Ditto. (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
- 8:53 AM Changeset in webkit [30567] by
-
- 2 edits in trunk/JavaScriptCore
MSVC build fix
- kjs/testkjs.cpp: (functionQuit): Don't add a return statement after exit(0) for MSVC.
- 8:52 AM Changeset in webkit [30566] by
-
- 5 edits in trunk/WebKit/win
Move many dispatch methods to WebFrameLoaderClient
Reviewed by Sam.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFinishDocumentLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchShow):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebFrame.cpp:
- WebFrame.h:
- 8:52 AM Changeset in webkit [30565] by
-
- 5 edits in trunk/WebKit/win
Move two more methods to WebFrameLoaderClient
Reviewed by Sam.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::hasFrameView): (WebFrame::forceLayout):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebFrame.cpp:
- WebFrame.h:
- 5:16 AM Changeset in webkit [30564] by
-
- 16 edits in trunk/WebCore
Fix compilation with gcc 4.3, added stdio.h and unistd.h inclusions.
- 5:14 AM Changeset in webkit [30563] by
-
- 3 edits4 adds in trunk
2008-02-25 Johnny Ding <johnnyding.webkit@gmail.com>
Reviewed by Darin Adler.
In HTMLTokenizer::write, the code checks 'pendingScripts.isEmpty()' to decide
whether to save prependingSrc or not. However, in HTMLTokenizer::scriptHandler
and HTMLTokenizer::scriptExecution, the code checks testBit:LoadingExtScript
to decide whether to save prependingSrc or not. The later behavior is not right
because, in scriptHandler and scriptExecution, even the pendingScripts queue is
empty, the testBit:LoadingExtScript might be TRUE.
Test: fast/tokenizer/nested-multiple-scripts.html
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): check pendingScripts.isEmpty() instead of checking state.loadingExtScript(). (WebCore::HTMLTokenizer::scriptExecution): check pendingScripts.isEmpty() instead of checking state.loadingExtScript().
2008-02-25 Johnny Ding <johnnyding.webkit@gmail.com>
Reviewed by Darin Adler.
- bug http://bugs.webkit.org/show_bug.cgi?id=17444 Test for multiple nested scripts which are in a external script.
- fast/tokenizer/nested-multiple-scripts-expected.txt: Added.
- fast/tokenizer/nested-multiple-scripts.html: Added.
- fast/tokenizer/resources/external-script-1.js: Added.
- fast/tokenizer/resources/external-script-2.js: Added.
Feb 24, 2008:
- 11:44 PM Changeset in webkit [30562] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: Make some updates based on a trial run of the renaming script.
- 11:17 PM Changeset in webkit [30561] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: More renaming plans.
- 11:11 PM Changeset in webkit [30560] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=17529
Add support for reading from stdin from testkjs
- kjs/testkjs.cpp: (GlobalObject::GlobalObject): Add readline function to global object. (functionReadline): Added. Reads characters from stdin until a '\n' or EOF is encountered. The input is returned as a String to the caller.
- 11:09 PM Changeset in webkit [30559] by
-
- 2 edits in trunk/WebCore
- dom/Document.h: Removed stray duplicate declaration of RegisteredEventListenerList.
- 10:52 PM Changeset in webkit [30558] by
-
- 2 edits in trunk/WebCore
- dom/Range.cpp: (WebCore::Range::surroundContents): Removed incorrect comment. I added it a while ago, and I was just mixed up.
- 10:48 PM Changeset in webkit [30557] by
-
- 2 edits in trunk/WebCore
- quick follow-up to that last check-in
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::createFrameAtIndex): Use CFEqual instead of WebCore::String's == for speed.
- 10:36 PM Changeset in webkit [30556] by
-
- 3 edits6 adds in trunk
WebCore:
Reviewed by Darin.
Bug 8749: XBM rendered incorrectly as black on white
xbm images are now created and rendered using black on a
transparent background (same behavior as in Firefox)
Test: platform/mac/fast/canvas/canvas-draw-xbm-image.html
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::createFrameAtIndex):
LayoutTests:
Reviewed by Darin.
- platform/mac/fast/canvas/canvas-draw-xbm-image-expected.checksum: Added.
- platform/mac/fast/canvas/canvas-draw-xbm-image-expected.png: Added.
- platform/mac/fast/canvas/canvas-draw-xbm-image-expected.txt: Added.
- platform/mac/fast/canvas/canvas-draw-xbm-image.html: Added.
- platform/mac/fast/canvas/resources: Added.
- platform/mac/fast/canvas/resources/smile.xbm: Added.
- 9:29 PM Changeset in webkit [30555] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=17528
Give testkjs a bath
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj: Make the testkjs.cpp use 4 space indentation.
- kjs/testkjs.cpp: (StopWatch::getElapsedMS): (GlobalObject::className): (GlobalObject::GlobalObject): Rename GlobalImp to GlobalObject and setup the global functions in the GlobalObject's constructor. Also, use static functions for the implementation so we can use the standard PrototypeFunction class and remove TestFunctionImp. (functionPrint): Move print() functionality here. (functionDebug): Move debug() functionality here. (functionGC): Move gc() functionality here. (functionVersion): Move version() functionality here. (functionRun): Move run() functionality here. (functionLoad): Move load() functionality here. (functionQuit): Move quit() functionality here. (prettyPrintScript): Fix indentation. (runWithScripts): Since all the functionality of createGlobalObject is now in the GlobalObject constructor, just call new here. (parseArguments): Fix indentation. (kjsmain): Ditto (fillBufferWithContentsOfFile): Ditto.
- 7:08 PM Changeset in webkit [30554] by
-
- 3 edits3 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=17471 REGRESSION (r30438): Crash in deleteLineBoxes in cursor-adjusting code browsing Acid3
Test: http/tests/misc/object-image-error.html
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::attach): Added an early return in case updateFromElement() has changed the object to use fallback content.
LayoutTests:
Reviewed by Darin Adler.
- test for http://bugs.webkit.org/show_bug.cgi?id=17471 REGRESSION (r30438): Crash in deleteLineBoxes in cursor-adjusting code browsing Acid3
- http/tests/misc/object-image-error-expected.txt: Added.
- http/tests/misc/object-image-error.html: Added.
- http/tests/misc/resources/404image.php: Added.
- 5:34 PM Changeset in webkit [30553] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Oliver Hunt and Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=17505
Add support for getting command line arguments in testkjs
- This slightly changes the behavior of parsing arguments by requiring a '-f' before all files.
- kjs/testkjs.cpp: (createGlobalObject): Add a global property called 'arguments' which contains an array with the parsed arguments as strings. (runWithScripts): Pass in the arguments vector so that it can be passed to the global object. (parseArguments): Change parsing rules to require a '-f' before any script file. After all '-f' and '-p' arguments have been parsed, the remaining are added to the arguments vector and exposed to the script. If there is a chance of ambiguity (the user wants to pass the string '-f' to the script), the string '--' can be used separate the options from the pass through arguments. (kjsmain):
- 2:50 PM Changeset in webkit [30552] by
-
- 1 edit651 moves651 deletes in trunk/LayoutTests
Rubber-stamped by Oliver Hunt.
- replace expected results in platform/mac-tiger and platform/mac-leopard which were identical with a single copy in platform/mac
- 10:48 AM Changeset in webkit [30551] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix float positioning when a float that does not fit on the line is followed by a float that does
Test: fast/block/float/narrow-after-wide.html
- rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Changed to not position any more floats on the line once a float that does not fit is encountered. That float should be pushed to the next line, and so should all floats that follow, regardless of whether they can fit on the current line.
LayoutTests:
Reviewed by Darin Adler.
- test float positioning when a float that does not fit on the line is followed by a float that does
- fast/block/float/narrow-after-wide.html: Added.
- platform/mac/fast/block/float/narrow-after-wide-expected.checksum: Added.
- platform/mac/fast/block/float/narrow-after-wide-expected.png: Added.
- platform/mac/fast/block/float/narrow-after-wide-expected.txt: Added.
- 10:44 AM Changeset in webkit [30550] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=17511 REGRESSION: Reproducible crash in SegmentedSubstring::SegmentedSubstring(SegmentedSubstring const&)
- wtf/Deque.h: (WTF::::expandCapacityIfNeeded): Fixed the case where m_start and m_end are both zero but the buffer capacity is non-zero. (WTF::::prepend): Added validity checks.
- 12:30 AM Changeset in webkit [30549] by
-
- 21 edits3 adds in trunk
WebCore:
Reviewed by Sam.
- fix http://bugs.webkit.org/show_bug.cgi?id=16770 Acid3 expects :visited styled links to restyle on iframe load
Disentangle global history updating from the back/forward history.
There are many cases where we don't want to create a new back/forward
item, but we do still want to add to the global history (used for visited
link coloring) in those cases.
Test: fast/history/subframe-is-visited.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::updateGlobalHistory): Renamed from addHistoryForCurrentLocation and removed the back/forward handling. (WebCore::FrameLoader::updateHistoryForStandardLoad): Streamlined logic a bit. Replaced call to addHistoryForCurrentLocation with a call to addBackForwardItemClippedAtTarget. Added an unconditional call to updateGlobalHistory. (WebCore::FrameLoader::updateHistoryForClientRedirect): Added a FIXME; why doesn't this function update global history? (WebCore::FrameLoader::updateHistoryForBackForwardNavigation): Ditto. (WebCore::FrameLoader::updateHistoryForReload): Replaced the direct call the client with a call to the new updateGlobalHistory function. (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Did the same changes as for updateHistoryForStandardLoad.
- loader/FrameLoader.h: More of the same.
- loader/FrameLoaderClient.h: Removed updateGlobalHistoryForReload and renamed updateGlobalHistoryForStandardLoad to updateGlobalHistory.
- svg/graphics/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistory): Updated to match the above.
WebKit/gtk:
Reviewed by Sam.
- remove separate client calls for "standard" and "reload' history
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::updateGlobalHistory):
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/mac:
Reviewed by Sam.
- remove separate client calls for "standard" and "reload' history
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory):
WebKit/qt:
Reviewed by Sam.
- remove separate client calls for "standard" and "reload' history
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistory):
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
Reviewed by Sam.
- remove separate client calls for "standard" and "reload' history
- WebFrame.cpp: (WebFrame::updateGlobalHistory):
- WebFrame.h:
WebKit/wx:
Reviewed by Sam.
- remove separate client calls for "standard" and "reload' history
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::updateGlobalHistory):
- WebKitSupport/FrameLoaderClientWx.h:
LayoutTests:
Reviewed by Sam.
- test for http://bugs.webkit.org/show_bug.cgi?id=16770 Acid3 expects :visited styled links to restyle on iframe load
- fast/history/resources/subframe.html: Added.
- fast/history/subframe-is-visited-expected.txt: Added.
- fast/history/subframe-is-visited.html: Added.
- 12:09 AM Changeset in webkit [30548] by
-
- 2 edits in trunk/WebKit/qt
- another try at fixing the build
- Api/qwebframe.cpp: (QWebFrame::load): Replace new FormData with FormData::create.
Feb 23, 2008:
- 11:55 PM Changeset in webkit [30547] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- fix http://bugs.webkit.org/show_bug.cgi?id=17508 REGRESSION (r30535): mailto regression tests failing
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Restore the old logic, with its unpleasant trip through String do to the replace operation. It's inefficient, but there's no real reason to worry about the efficiency of mailto forms, since that feature is nearly obsolete.
- 11:36 PM Changeset in webkit [30546] by
-
- 3 edits in trunk/WebCore
Reviewed by Sam.
- replace SegmentedString's use of DeprecatedValueList with Deque
Testing indicates this is a slight speed-up for page loading.
- platform/text/SegmentedString.cpp: (WebCore::SegmentedString::length): Update to use Deque. (WebCore::SegmentedString::setExcludeLineNumbers): Ditto. (WebCore::SegmentedString::append): Ditto. (WebCore::SegmentedString::prepend): Ditto. (WebCore::SegmentedString::advanceSubstring): Ditto. (WebCore::SegmentedString::toString): Ditto.
- platform/text/SegmentedString.h: Tweak formatting. Don't bother making an entire class private with a single friend. Change m_sbstrings from a DeprecatedValueList to a Deque.
- 11:26 PM Changeset in webkit [30545] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders.
- fix http://bugs.webkit.org/show_bug.cgi?id=17506 REGRESSION (r30535): ASSERTION FAILED: i < size()
- loader/TextResourceDecoder.cpp: (WebCore::findTextEncoding): Fix off-by-one in code that null-terminates the C string here.
- 11:10 PM Changeset in webkit [30544] by
-
- 3 edits in trunk/WebCore
Not reviewed, build fix.
- platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::httpBodyFromRequest):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::handlePost):
- 11:07 PM Changeset in webkit [30543] by
-
- 3 edits in trunk/WebCore
- fix a typo
- platform/graphics/win/GlyphPageTreeNodeCGWin.cpp: (WebCore::GlyphPage::fill):
- platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp: (WebCore::GlyphPage::fill):
- 11:07 PM Changeset in webkit [30542] by
-
- 6 edits in trunk
2008-02-23 Jan Michael Alonzo <jmalonzo@unpluggable.com>
.:
Rubber stamped by Darin.
Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
whitespaces introduced in the previous commit.
- GNUmakefile.am:
Rubber stamped by Darin.
Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
whitespaces introduced in the previous commit.
- GNUmakefile.am:
WebKitTools:
Rubber stamped by Darin.
Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
whitespaces introduced in the previous commit.
- GNUmakefile.am:
- 10:59 PM Changeset in webkit [30541] by
-
- 3 edits in trunk/WebCore
Reviewed by Anders Carlsson.
- fix GlyphPage::fill() logic for partial page fills
- platform/graphics/win/GlyphPageTreeNodeCGWin.cpp: (WebCore::GlyphPage::fill): Changed the test for non-BMP characters to work correctly when the length parameter is less than a full page size. Also updated the comment.
- platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp: (WebCore::GlyphPage::fill): Ditto.
- 9:42 PM Changeset in webkit [30540] by
-
- 7 edits in trunk
.:
Rubber-stamped by Darin.
- GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
- configure.ac: Break dependent modules into GLOBALDEPS and WEBKITDEPS.
- GNUmakefile.am: Add GLOBALDEPS for testkjs and minidom.
WebKitTools:
Rubber-stamped by Darin.
- GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
- 9:38 PM Changeset in webkit [30539] by
-
- 5 edits4 adds in trunk
Move text drawing into wxcode, as we need platform-dependent APIs for drawing non-kerned text, which wx doesn't yet have.
- 9:19 PM Changeset in webkit [30538] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Anders.
- http://bugs.webkit.org/show_bug.cgi?id=17496 make Deque use a circular array; add iterators
- wtf/Deque.h: Wrote an all-new version of this class that uses a circular buffer. Growth policy is identical to vector. Added iterators.
- wtf/Vector.h: Made two small refinements while using this to implement Deque: Made VectorBufferBase derive from Noncopyable, which would have saved me some debugging time if it had been there. Renamed Impl and m_impl to Buffer and m_buffer.
- 9:13 PM Changeset in webkit [30537] by
-
- 2 edits in trunk/WebCore
Pointed out by Mitz.
- loader/TextResourceDecoder.cpp: (WebCore::find): Fix a "==" that was supposed to be ">". (WebCore::findIgnoringCase): Ditto.
- 9:12 PM Changeset in webkit [30536] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- html/HTMLFormElement.cpp: (WebCore::appendEncodedString): Fix buffer overrun in the code I just landed.
- 9:04 PM Changeset in webkit [30535] by
-
- 7 edits in trunk/WebCore
Reviewed by Sam.
- remove all but 1 remaining use of DeprecatedCString
- change FormData to start refcount at 1
- html/HTMLFormElement.cpp: (WebCore::appendString): Added. Helpers for Vector<char>. (WebCore::appendEncodedString): Renamed from encodeCString and changed to append to an existing Vector<char> to cut down a bit on memory allocation. (WebCore::HTMLFormElement::formData): Replace the DeprecatedCString called enc_string with a Vector<char> called encodedData. Change to use the new FormData::create function. (WebCore::HTMLFormElement::submit): Same thing, for the mailto form code.
- loader/TextResourceDecoder.cpp: (WebCore::find): Added. Helper for searching in char* with length. (WebCore::findIgnoringCase): Ditto. (WebCore::findTextEncoding): Added. Helper for looking up a text encoding when we have a char* with length rather than a null-terminated char*. (WebCore::findXMLEncoding): Changed to use char* and length rather than DeprecatedCString. Also fixed some things that would be one-character buffer overruns in a string that's not null-terminated. (WebCore::TextResourceDecoder::checkForCSSCharset): Change to use findTextEncoding rather than constructing a CString to pass to the TextEncodingconstructor. (WebCore::TextResourceDecoder::checkForHeadCharset): Ditto.
- platform/network/FormData.cpp: (WebCore::FormData::FormData): Changed to start refcount at 1. (WebCore::FormData::create): Added. (WebCore::FormData::copy): Call adoptRef since refcount starts at 1.
- platform/network/FormData.h: Made constructor private. Added create functions.
- platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest): Call FormData::create.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Ditto.
- 9:01 PM Changeset in webkit [30534] by
-
- 57 edits in trunk
Reviewed by Anders.
- http://bugs.webkit.org/show_bug.cgi?id=17067 eliminate attributes parameter from JSObject::put for speed/clarity
- API/JSCallbackObject.h: Removed attribute arguments.
- API/JSCallbackObjectFunctions.h: (KJS::JSCallbackObject<Base>::put): Ditto.
- API/JSObjectRef.cpp: (JSObjectSetProperty): Use initializeVariable or putDirect when necessary to set attribute values.
- JavaScriptCore.exp: Updated.
- bindings/objc/objc_runtime.h: Removed attribute arguments.
- bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::put): Ditto.
- bindings/runtime_array.cpp: (RuntimeArray::put): Ditto.
- bindings/runtime_array.h: Ditto.
- bindings/runtime_object.cpp: (RuntimeObjectImp::put): Ditto.
- bindings/runtime_object.h: Ditto. Also removed canPut which was only called from one place in WebCore that can use hasProperty instead.
- kjs/Activation.h: Removed attribute argument from put and added the new initializeVariable function that's used to put variables in variable objects. Also made isActivationObject a const member.
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::put): Removed attribute argument. (KJS::JSGlobalObject::initializeVariable): Added. Used to give variables their initial values, which can include the read-only property. (KJS::JSGlobalObject::reset): Removed obsolete comments about flags. Removed Internal flag, which is no longer needed.
- kjs/JSGlobalObject.h: More of the same.
- kjs/JSVariableObject.h: Added pure virtual initializeVariable function. (KJS::JSVariableObject::symbolTablePut): Removed checkReadOnly flag; we always check read-only. (KJS::JSVariableObject::symbolTableInitializeVariable): Added.
- kjs/array_instance.cpp: (KJS::ArrayInstance::put): Removed attribute argument.
- kjs/array_instance.h: Ditto.
- kjs/function.cpp: (KJS::FunctionImp::put): Ditto. (KJS::Arguments::put): Ditto. (KJS::ActivationImp::put): Ditto. (KJS::ActivationImp::initializeVariable): Added.
- kjs/function.h: Removed attribute arguments.
- kjs/function_object.cpp: (KJS::FunctionObjectImp::construct): Removed Internal flag.
- kjs/lookup.h: (KJS::lookupPut): Removed attributes argument. Also changed to use putDirect instead of calling JSObject::put. (KJS::cacheGlobalObject): Ditto.
- kjs/nodes.cpp: (KJS::ConstDeclNode::handleSlowCase): Call initializeVariable to initialize the constant. (KJS::ConstDeclNode::evaluateSingle): Ditto. (KJS::TryNode::execute): Use putDirect to set up the new object. (KJS::FunctionBodyNode::processDeclarations): Removed Internal. (KJS::ProgramNode::processDeclarations): Ditto. (KJS::EvalNode::processDeclarations): Call initializeVariable to initialize the variables and functions. (KJS::FuncDeclNode::makeFunction): Removed Internal. (KJS::FuncExprNode::evaluate): Ditto.
- kjs/object.cpp: Removed canPut, which was only being used in one code path, not the normal high speed one. (KJS::JSObject::put): Removed attribute argument. Moved the logic from canPut here, in the one code ath that was still using it.
- kjs/object.h: Removed Internal attribute, ad canPut function. Removed the attributes argument to the put function. Made isActivationObject const.
- kjs/regexp_object.cpp: (KJS::RegExpImp::put): Removed attributes argument. (KJS::RegExpImp::putValueProperty): Ditto. (KJS::RegExpObjectImp::put): Ditto. (KJS::RegExpObjectImp::putValueProperty): Ditto.
- kjs/regexp_object.h: Ditto.
- kjs/string_object.cpp: (KJS::StringInstance::put): Removed attributes argument.
- kjs/string_object.h: Ditto.
WebCore:
Reviewed by Anders.
- http://bugs.webkit.org/show_bug.cgi?id=17067 eliminate attributes parameter from JSObject::put for speed/clarity
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::customPut): Remove attributes argument.
- bindings/js/JSCanvasPixelArrayCustom.cpp: (WebCore::JSCanvasPixelArray::indexGetter): Use early exit idiom. (WebCore::JSCanvasPixelArray::indexSetter): Moved length check into the CanvasPixelArray object, for consistency with the getter. Removed attributes argument.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customPut): Removed special case for variable initialization, which is not needed since that does use put any more. Removed attributes argument.
- bindings/js/JSEventTargetBase.h: (WebCore::JSEventTargetBase::putValueProperty): Removed attributes argument. (WebCore::JSEventTargetBase::put): Ditto. (WebCore::JSEventTargetPrototype::self): Removed Internal flag.
- bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNode::put): Removed attributes argument. (WebCore::JSEventTargetNode::putValueProperty): Ditto.
- bindings/js/JSEventTargetNode.h: Ditto.
- bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::customPut): Ditto.
- bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::customPut): Ditto.
- bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBase::put): Ditto. (WebCore::JSHTMLInputElementBase::putValueProperty): Ditto.
- bindings/js/JSHTMLInputElementBase.h: Ditto.
- bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::customPut): Ditto.
- bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::indexSetter): Ditto.
- bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::indexSetter): Ditto.
- bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::customPut): Ditto.
- bindings/js/JSLocation.cpp: (WebCore::JSLocation::put): Ditto.
- bindings/js/JSLocation.h: Ditto.
- bindings/js/JSXMLHttpRequest.cpp: (WebCore::JSXMLHttpRequest::put): Ditto. (WebCore::JSXMLHttpRequest::putValueProperty): Ditto.
- bindings/js/JSXMLHttpRequest.h: Ditto.
- bindings/js/kjs_dom.cpp: (WebCore::getRuntimeObject): Changed return type to JSObject*.
- bindings/js/kjs_dom.h: Ditto.
- bindings/js/kjs_events.cpp: (WebCore::JSClipboard::put): Removed attributes argument. (WebCore::JSClipboard::putValueProperty): Ditto.
- bindings/js/kjs_events.h: Ditto.
- bindings/js/kjs_html.cpp: (WebCore::runtimeObjectGetter): Updated for change to getRuntimeObject to return a JSObject. Used early exit idiom. (WebCore::runtimeObjectPropertyGetter): Ditto. (WebCore::runtimeObjectCustomGetOwnPropertySlot): Ditto. (WebCore::runtimeObjectCustomPut): Use hasProperty to check for properties that we should put with the property syntax instead of canPut. (WebCore::runtimeObjectImplementsCall): Ditto. (WebCore::runtimeObjectCallAsFunction): Ditto.
- bindings/js/kjs_html.h: Removed attributes argument to runtimeObjectCustomPut.
- bindings/js/kjs_window.cpp: (KJS::Window::put): Removed attributes argument.
- bindings/js/kjs_window.h: Ditto.
- bindings/scripts/CodeGeneratorJS.pm: Removed attributes argument from put, putValueProperty, customPut, and indexSetter.
- html/CanvasPixelArray.h: (WebCore::CanvasPixelArray::set): Added index checking here, as in the get function. Before, the checking was done in the JavaScript bindings for set.
- 8:15 PM Changeset in webkit [30533] by
-
- 7 edits in trunk/WebCore
2008-02-23 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam and Darin.
http://bugs.webkit.org/show_bug.cgi?id=17442
Correct the Windows Cairo implementation of GraphicsContext so
that Windows 'WorldTransform' is kept in sync with the Cairo
transormations.
Also corrects an uninitialized variable in the Cairo Windows
image drag handler.
WARNING: NO TEST CASES ADDED OR CHANGED
- platform/graphics/cairo/GraphicsContextCairo.cpp: Modify methods to call GraphicsContextPlatformPrivate calls, just as is done for the CoreGraphics version. These calls are nop's for everything but Windows. (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::concatCTM): Re-enable for Windows (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale):
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
- platform/graphics/win/GraphicsContextCGWin.cpp: Move common code for handling WorldTransform calls to parent class.
- platform/graphics/win/GraphicsContextCairoWin.cpp: Add common code for handling WorldTransform calls. (WebCore::GraphicsContextPlatformPrivate::concatCTM): Change implementation so that it only handles WorldTransform. The Cairo update is done in GraphicsContextCairo.cpp
- platform/graphics/win/GraphicsContextWin.cpp: Call platform-private methods to keep WorldTransform in sync. (WebCore::GraphicsContextPlatformPrivate::save): (WebCore::GraphicsContextPlatformPrivate::restore): (WebCore::GraphicsContextPlatformPrivate::clip): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate):
- platform/win/DragImageCairoWin.cpp: (WebCore::createDragImageFromImage): Correct uninitialized value
- 8:10 PM Changeset in webkit [30532] by
-
- 3 edits in trunk/WebKit/win
2008-02-23 Brent Fulgham <bfulgham@gmail.com>
Not reviewed, build fix.
- WebIconDatabase.cpp:
- WebIconDatabase.h:
- 8:05 PM Changeset in webkit [30531] by
-
- 2 edits in trunk/JavaScriptCore
2008-02-23 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Not reviewed, Gtk build fix.
- kjs/testkjs.pro:
- 8:00 PM Changeset in webkit [30530] by
-
- 5 edits5 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- make non-autowrapping text clear floats
Test: fast/text/whitespace/nowrap-clear-float.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::nextFloatBottomBelow): Renamed nearestFloat() to this and changed to avoid comparing bottom to 0 in each iteration. (WebCore::RenderBlock::getClearDelta): Updated comment for the rename.
- rendering/RenderBlock.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::fitBelowFloats): Added. Factored out of findNextLineBreak() and simplified. (WebCore::RenderBlock::findNextLineBreak): Changed to call fitBelowFloats(). Fixed the bug by trying to fit below floats in the case of non-wrapping text. Removed some redundancy.
LayoutTests:
Reviewed by Dave Hyatt.
- test that non-autowrapping text clear floats
- fast/text/whitespace/nowrap-clear-float.html: Added.
- platform/mac-leopard/fast/text/whitespace: Added.
- platform/mac-leopard/fast/text/whitespace/nowrap-clear-float-expected.checksum: Added.
- platform/mac-leopard/fast/text/whitespace/nowrap-clear-float-expected.png: Added.
- platform/mac/fast/text/whitespace/nowrap-clear-float-expected.txt: Added.
- 5:35 PM Changeset in webkit [30529] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
Fix for http://bugs.webkit.org/show_bug.cgi?id=17504
Speed up DOM lists array subscription syntax by using the fast
getOwnPropertySlot and set paths
- 6x speed improvement on Oliver's ImageData put test.
- bindings/scripts/CodeGeneratorJS.pm: Add fast path for getOwnPropertySlot and put when an indexGetter or indexSetter is used. We can not use the fast path if an overridingNameGetter is used as there would be no way to override.
- 5:33 PM Changeset in webkit [30528] by
-
- 2 edits in trunk/WebCore
wx build fix after JSImageData.cpp was added.
- 1:52 PM Changeset in webkit [30527] by
-
- 4 edits1 delete in trunk
Windows build fix - move ThreadCondition implementation from WebCore to WTF.
- 1:04 PM BuildingGtk edited by
- (diff)
- 12:49 PM Changeset in webkit [30526] by
-
- 6 edits in trunk
Build fix.
Touch some files, hoping that Windows build bot will create JSC headers.
- kjs/AllInOneFile.cpp:
- kjs/array_instance.cpp:
- wtf/HashTable.cpp:
WebKit/gtk:
- webkit/webkitprivate.cpp: (webkit_init): Renamed initializeThreading to initializeThreadingAndMainThread.
- 12:29 PM Changeset in webkit [30525] by
-
- 2 edits in trunk/JavaScriptCore
Qt/Wx build fix - this file was still in a wrong namespace, too.
- wtf/ThreadingNone.cpp:
- 12:21 PM Changeset in webkit [30524] by
-
- 2 edits in trunk/JavaScriptCore
More build fixing - fix mismatched braces.
- JavaScriptCore.pri:
- 12:10 PM Changeset in webkit [30523] by
-
- 3 edits in trunk/JavaScriptCore
Wx and Gtk build fixes.
- JavaScriptCore.pri: Don't try to compile ThreadingPthreads.
- wtf/ThreadingGtk.cpp: Use a correct namespace.
- 11:50 AM Changeset in webkit [30522] by
-
- 37 edits4 copies9 moves5 adds2 deletes in trunk
2008-02-23 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin.
Move basic threading support from WebCore to WTF.
- 10:54 AM Changeset in webkit [30521] by
-
- 1 edit in trunk/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp
Fix typo in comment.
- 9:08 AM Changeset in webkit [30520] by
-
- 14 edits1 add in trunk
WebCore:
Please clarify licensing for some files
<http://bugs.webkit.org/show_bug.cgi?id=14970>
Reviewed by Darin.
- bindings/objc/WebScriptObject.h: Added Apple BSD-style license.
- bindings/objc/WebScriptObjectPrivate.h: Ditto.
- platform/text/mac/ShapeArabic.c: Added ICU license from WebCore/icu/LICENSE.
WebKit/mac:
Please clarify licensing for some files
<http://bugs.webkit.org/show_bug.cgi?id=14970>
Reviewed by Darin.
- Plugins/WebNetscapeDeprecatedFunctions.c: Updated copyright statement and added Apple BSD-style license.
- Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
WebKitTools:
Please clarify licensing for some files
<http://bugs.webkit.org/show_bug.cgi?id=14970>
Reviewed by Darin.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Added copyright statement. Replaced license with newer Apple BSD-style license.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Ditto.
- DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Ditto.
- DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Ditto.
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Ditto.
- DumpRenderTree/win/TestNetscapePlugin/main.c: Ditto.
- mangleme/LICENSE: Added (LGPL).
- 12:09 AM Changeset in webkit [30519] by
-
- 2 edits in trunk/LayoutTests
- undo an accidental change to a test's expected results from r30431.
- fast/js/date-DST-time-cusps-expected.txt:
- 12:03 AM Changeset in webkit [30518] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Sam Weinig and Anders Carlsson.
- updated results for <rdar://problem/5714333> Add document.getSelection()
- fast/dom/Window/window-properties-expected.txt:
Feb 22, 2008:
- 11:52 PM Changeset in webkit [30517] by
-
- 8 edits in trunk/LayoutTests
Reviewed by Darin.
A few tweaks to PCRE-based regex test suite.
- fast/regex/pcre-test-runner.js: Added support for global regexes. Emulate PCRE test runner more precisely by trimming trailing whitespace from some lines.
- fast/regex/test1-expected.txt:
- fast/regex/test4-expected.txt:
- fast/regex/testinput1:
- fast/regex/testinput4:
- fast/regex/testoutput1:
- fast/regex/testoutput4: Updated to PCRE 7.6.
- 11:46 PM Changeset in webkit [30516] by
-
- 30 edits in trunk/LayoutTests
- update Tiger expected results following r30431
- platform/mac-tiger/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
- platform/mac-tiger/svg/custom/foreignObject-crash-on-hover-expected.txt:
- platform/mac-tiger/svg/custom/text-dom-01-f-expected.txt:
- platform/mac-tiger/svg/custom/text-hit-test-expected.txt:
- platform/mac-tiger/svg/text/text-align-01-b-expected.txt:
- platform/mac-tiger/svg/text/text-align-02-b-expected.txt:
- platform/mac-tiger/svg/text/text-align-03-b-expected.txt:
- platform/mac-tiger/svg/text/text-align-04-b-expected.txt:
- platform/mac-tiger/svg/text/text-align-05-b-expected.txt:
- platform/mac-tiger/svg/text/text-align-06-b-expected.txt:
- platform/mac-tiger/svg/text/text-altglyph-01-b-expected.txt:
- platform/mac-tiger/svg/text/text-deco-01-b-expected.txt:
- platform/mac-tiger/svg/text/text-fonts-01-t-expected.txt:
- platform/mac-tiger/svg/text/text-fonts-02-t-expected.txt:
- platform/mac-tiger/svg/text/text-path-01-b-expected.txt:
- platform/mac-tiger/svg/text/text-spacing-01-b-expected.txt:
- platform/mac-tiger/svg/text/text-text-01-b-expected.txt:
- platform/mac-tiger/svg/text/text-text-03-b-expected.txt:
- platform/mac-tiger/svg/text/text-text-04-t-expected.txt:
- platform/mac-tiger/svg/text/text-text-05-t-expected.txt:
- platform/mac-tiger/svg/text/text-text-06-t-expected.txt:
- platform/mac-tiger/svg/text/text-text-07-t-expected.txt:
- platform/mac-tiger/svg/text/text-text-08-b-expected.txt:
- platform/mac-tiger/svg/text/text-tref-01-b-expected.txt:
- platform/mac-tiger/svg/text/text-tselect-01-b-expected.txt:
- platform/mac-tiger/svg/text/text-tselect-02-f-expected.txt:
- platform/mac-tiger/svg/text/text-tspan-01-b-expected.txt:
- platform/mac-tiger/svg/text/text-ws-01-t-expected.txt:
- platform/mac-tiger/svg/text/text-ws-02-t-expected.txt:
- 9:14 PM Changeset in webkit [30515] by
-
- 5 edits2 adds in trunk
WebCore:
Reviewed by Anders Carlsson.
<rdar://problem/5714333> Add document.getSelection()
Add a synonym for window.getSelection() that FF supports. There were requests in
this bugs dupes to also support the IE only document.selection, but IE's Selection
object is too different than ours currently for that to be safe (specifically, we
don't support enough of IE's TextRange methods on our DOM Range object yet). I
filed <rdar://problem/5761233> to cover that.
- dom/Document.cpp: (WebCore::Document::getSelection): Added.
- dom/Document.h:
- dom/Document.idl: Ditto. JS only since this is about web compatibility.
LayoutTests:
Reviewed by Anders.
<rdar://problem/5714333> Add document.getSelection()
- editing/selection/5714333-expected.txt: Added.
- editing/selection/5714333.html: Added.
- 9:09 PM Changeset in webkit [30514] by
-
- 2 edits in trunk/WebCore
WX build fixes
- 8:18 PM Changeset in webkit [30513] by
-
- 7 edits in trunk/WebCore
Roll out r30500 as it breaks non-Windows use of Cairo.
- 7:31 PM Changeset in webkit [30512] by
-
- 4 edits in trunk/WebCore
Once more with the cairo/qt/wx build fixing
- 7:09 PM Changeset in webkit [30511] by
-
- 2 edits in trunk/WebCore
Windows build fix. Add missing include of DeprecatedCString.h and sort existing includes.
- 7:03 PM Changeset in webkit [30510] by
-
- 3 edits in trunk/WebCore
Speculative Windows build fix. Add missing include of DeprecatedCString.h and sort existing includes.
- 6:15 PM Changeset in webkit [30509] by
-
- 2 edits in trunk/WebCore
Build fix for windows, wx and qt
- 6:04 PM Changeset in webkit [30508] by
-
- 2 edits in trunk/WebCore
Reviewed by NOBODY (build fix).
Unbreak windows vcproj
- WebCore.vcproj/WebCore.vcproj:
- 5:27 PM Changeset in webkit [30507] by
-
- 2 edits in trunk/WebKit/qt
Fix Qt build.
- Api/qwebhistoryinterface.cpp:
- 5:16 PM Changeset in webkit [30506] by
-
- 19 edits12 adds in trunk
Bug 17486: Support HTML5 Canvas.getImageData API
Support Canvas.getImageData and Canvas.createImageData
Reviewed by Sam W.
This patch adds support for all the pixel reading portions
of the HTML5 Canvas spec. There are two new types ImageData
and CanvasPixelArray which are used to provide the HTML5
ImageData object, and the required semantics for assignment
to the ImageData data array.
We only implement the CG version of ImageBuffer::getImageData,
but the logic is null safe, so this will not introduce any
crashes into other platforms, unfortunately it will result in
JS Object detection "lying" on non-CG platforms.
- 5:14 PM Changeset in webkit [30505] by
-
- 4 edits in tags/Safari-5525.11.1
Versioning.
- 5:14 PM Changeset in webkit [30504] by
-
- 2 edits in tags/Safari-5525.11.1/WebCore
Merge r30502.
- 5:07 PM Changeset in webkit [30503] by
-
- 1 copy in tags/Safari-5525.11.1
New tag.
- 5:06 PM Changeset in webkit [30502] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
2008-02-22 Mark Rowe <mrowe@apple.com>
Build fix.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Qualify references to symbols in the KJS namespace.
- 4:55 PM Changeset in webkit [30501] by
-
- 32 edits4 deletes in trunk
WebCore:
Rubber-stamped by Adam Roben.
Rid the project of the Devil known as DeprecatedString!
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- dom/Node.h:
- html/HTMLFormElement.cpp:
- platform/DeprecatedString.cpp: Removed.
- platform/DeprecatedString.h: Removed.
- platform/graphics/qt/IconQt.cpp:
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
- platform/gtk/CookieJarGtk.cpp:
- platform/gtk/CursorGtk.cpp:
- platform/gtk/KeyEventGtk.cpp:
- platform/mac/DeprecatedStringMac.mm: Removed.
- platform/network/qt/ResourceHandleQt.cpp:
- platform/network/win/CookieJarWin.cpp: (WebCore::cookies):
- platform/qt/ClipboardQt.cpp:
- platform/qt/CookieJarQt.cpp:
- platform/qt/CursorQt.cpp:
- platform/symbian/DeprecatedStringSymbian.cpp: Removed.
- platform/text/AtomicString.cpp:
- platform/text/AtomicString.h:
- platform/text/PlatformString.h:
- platform/text/String.cpp:
- platform/text/StringImpl.cpp:
- platform/text/qt/StringQt.cpp: (WebCore::String::String):
- platform/text/wx/StringWx.cpp:
- platform/win/BString.cpp:
- platform/win/BString.h:
- platform/win/PasteboardWin.cpp:
WebKit/qt:
Rubber-stamped by Adam Roben.
Rid the project of the Devil known as DeprecatedString!
- Api/qwebhistory.cpp:
- Api/qwebhistoryinterface.cpp:
- 4:23 PM Changeset in webkit [30500] by
-
- 7 edits in trunk/WebCore
2008-02-22 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=17442
Correct the Windows Cairo implementation of GraphicsContext so
that Windows 'WorldTransform' is kept in sync with the Cairo
transformations.
Also corrects an uninitialized variable in the Cairo Windows
image drag handler.
- platform/graphics/cairo/GraphicsContextCairo.cpp: Modify methods to call GraphicsContextPlatformPrivate calls, just as is done for the CoreGraphics version. These calls are nop's for everything but Windows. (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::concatCTM): Re-enable for Windows (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale):
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
- platform/graphics/win/GraphicsContextCGWin.cpp: Move common code for handling WorldTransform calls to parent class.
- platform/graphics/win/GraphicsContextCairoWin.cpp: Add common code for handling WorldTransform calls. (WebCore::GraphicsContextPlatformPrivate::concatCTM): Change implementation so that it only handles WorldTransform. The Cairo update is done in GraphicsContextCairo.cpp
- platform/graphics/win/GraphicsContextWin.cpp: Call platform-private methods to keep WorldTransform in sync. (WebCore::GraphicsContextPlatformPrivate::save): (WebCore::GraphicsContextPlatformPrivate::restore): (WebCore::GraphicsContextPlatformPrivate::clip): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate):
- platform/win/DragImageCairoWin.cpp: (WebCore::createDragImageFromImage): Correct uninitialized value
- 4:16 PM Changeset in webkit [30499] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff Garen.
- Remove use of DeprecatedString in CSSStyleSelector.
- css/CSSStyleSelector.cpp: (WebCore::findHash): Removed. Use find instead. (WebCore::findSlashDotDotSlash): Changed to take a UChar* and a length. (WebCore::findSlashSlash): Ditto. (WebCore::findSlashDotSlash): Ditto. (WebCore::containsColonSlashSlash): Ditto. (WebCore::cleanPath): Change to operate on a String. (WebCore::checkPseudoState): Changed to use a Vector as a buffer.
- 3:51 PM Changeset in webkit [30498] by
-
- 4 edits in branches/Safari-3-1-branch
Versioning.
- 3:50 PM Changeset in webkit [30497] by
-
- 1 copy in tags/Safari-5525.11
New tag.
- 3:49 PM Changeset in webkit [30496] by
-
- 4 edits in branches/Safari-3-1-branch
Versioning.
- 3:39 PM Changeset in webkit [30495] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30493.
- 3:39 PM Changeset in webkit [30494] by
-
- 5 edits2 deletes in branches/Safari-3-1-branch
Merge r30492.
- 3:16 PM Changeset in webkit [30493] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
Fixed <rdar://problem/5057509> Repro leak of JSXMLHttpRequest and
associated objects @ www.viamichelin.it, which was probably an underlying
cause of <rdar://problem/5744037> Gmail out of memory (17455)
If SubresourceLoader::create returned NULL, we would ref() / gcProtect()
the XMLHttpRequest but think we hadn't, therefore never
calling deref() / gcUnprotect().
This could happen at gmail.com, since gmail.com attempts to send
XMLHttpRequests from unload handlers in order to gather usage statistics.
(According to comments in the code, SubresourceLoader::create returns
NULL when called from an unload handler.)
The solution is to ref() / gcProtect() only if SubresourceLoader::create
doesn't return NULL. This make sense, since we only need to protect the
request as long as it has an outstanding network transaction.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::send):
- 3:16 PM Changeset in webkit [30492] by
-
- 5 edits2 deletes in trunk
Reviewed by Sam Weinig.
Partial fix for <rdar://problem/5744037> Gmail out of memory (17455)
I'm removing KJS_MEM_LIMIT for the following reasons:
- We have a few reports of KJS_MEM_LIMIT breaking important web applications, like GMail and Google Reader. (For example, if you simply open 12 GMail tabs, tab #12 will hit the limit.)
- Firefox has no discernable JS object count limit, so any limit, even a large one, is a potential compatibility problem.
- KJS_MEM_LIMIT does not protect against malicious memory allocation, since there are many ways to maliciously allocate memory without increasing the JS object count.
- KJS_MEM_LIMIT is already mostly broken, since it only aborts the script that breaches the limit, not any subsequent scripts.
- We've never gotten bug reports about websites that would have benefited from an unbroken KJS_MEM_LIMIT. The initial check-in of KJS_MEM_LIMIT (KJS revision 80061) doesn't mention a website that needed it.
- Any website that brings you anywhere close to crashing due to the number of live JS objects will almost certainly put up the "slow script" dialog at least 20 times beforehand.
- kjs/collector.cpp: (KJS::Collector::collect):
- kjs/collector.h:
- kjs/nodes.cpp: (KJS::TryNode::execute):
LayoutTests:
Reviewed by Sam Weinig.
Removing the test for KJS_MEM_LIMIT, since I removed KJS_MEM_LIMIT.
- fast/js/out-of-memory-expected.txt: Removed.
- fast/js/out-of-memory.html: Removed.
- 3:02 PM Changeset in webkit [30491] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30489.
- 3:00 PM BuildingCairoOnWindows edited by
- (diff)
- 2:30 PM Changeset in webkit [30490] by
-
- 7 edits in trunk/WebCore
Reviewed, tweaked and landed by Sam.
- Make RegularExpression operate on Strings instead of DeprecatedStrings.
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::isXMLMIMEType): Use string instead of DeprecatedString to build up the RegularExpression.
- page/Frame.cpp: (WebCore::createRegExpForLabels): Use String instead of DeprecatedString. (WebCore::Frame::searchForLabelsAboveCell): Ditto. (WebCore::Frame::searchForLabelsBeforeElement): Ditto. (WebCore::Frame::matchLabelsAgainstElement): Ditto.
- page/Frame.h:
- page/mac/FrameMac.mm: (WebCore::regExpForLabels): Ditto. (WebCore::Frame::searchForNSLabelsAboveCell): Ditto. (WebCore::Frame::searchForLabelsBeforeElement): Ditto. (WebCore::Frame::matchLabelsAgainstElement): Ditto.
- platform/text/RegularExpression.cpp: (WebCore::RegularExpression::Private::Private): (WebCore::RegularExpression::Private::compile): (WebCore::RegularExpression::RegularExpression): (WebCore::RegularExpression::operator=): (WebCore::RegularExpression::pattern): (WebCore::RegularExpression::match): (WebCore::RegularExpression::search): (WebCore::RegularExpression::searchRev): (WebCore::replace): Added.
- platform/text/RegularExpression.h: Change functions to take Strings as input instead of DeprecatedStrings and reduce the complexity of the class by removing unneeded globbing support.
- 2:15 PM Changeset in webkit [30489] by
-
- 2 edits in trunk/WebCore
2008-02-22 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Anders.
<rdar://problem/5760360> REGRESSION(r30376): Crash loading plugin page
during stress test (after only 5 min) - null dereference
Full-frame plug-ins create PluginStream objects without loaders, as the
PluginView receives the loading callbacks. We were trying to call
setDefersLoading on these null pointers.
- plugins/PluginStream.cpp: (WebCore::PluginStream::startStream): Add null check. (WebCore::PluginStream::destroyStream): Same. (WebCore::PluginStream::deliverData): Same.
- 2:07 PM BuildingCairoOnWindows edited by
- (diff)
- 1:39 PM Changeset in webkit [30488] by
-
- 3 edits in trunk/WebCore
Reviewed and tweaked by Jon Honeycutt. Reviewed and landed by Sam.
- Remove uses of DeprecatedString in Windows plugin code.
- plugins/win/PluginPackageWin.cpp: (WebCore::getVersionInfo): Cleanup formatting. (WebCore::PluginPackage::freeLibraryTimerFired): Remove un-needed variable name. (WebCore::PluginPackage::storeFileVersion): Move casts. (WebCore::PluginPackage::fetchInfo): Use OwnArrayPtr and switch to more efficient use of Vectors. (WebCore::PluginPackage::load): Fix whitespace. (WebCore::PluginPackage::hash): Make the hashCodes const
- plugins/win/PluginViewWin.cpp: (WebCore::makeURL): Use String instead of DeprecatedString. (WebCore::parseRFC822HeaderFields): Ditto. (WebCore::PluginView::handlePost): Ditto. (WebCore::PluginView::status): Ditto.
- 1:29 PM Changeset in webkit [30487] by
-
- 32 edits in branches/Safari-3-1-branch
Merge r30472.
- 1:16 PM Changeset in webkit [30486] by
-
- 3 edits in trunk/WebCore
Reviewed, tweaked and landed by Sam.
- Don't use DeprecatedString in HTMLTokenizer.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::finish):
- platform/text/PlatformString.h: (WebCore::find):
- 12:58 PM Changeset in webkit [30485] by
-
- 5 edits in trunk/WebKit/win
Move hasWebView to WebFrameLoaderClient
I added an m_webFrame member to WebFrameLoaderClient. This is slightly
strange because WebFrame inherits from WebFrameLoaderClient, but this
member will be needed once we remove the inheritance, so we might as
well prepare for that now.
Reviewed by Anders.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::WebFrameLoaderClient): Changed to take a WebFrame* parameter. (WebFrameLoaderClient::hasWebView): Moved here from WebFrame.cpp.
- WebCoreSupport/WebFrameLoaderClient.h: Added an m_webFrame parameter.
- WebFrame.cpp: Removed hasWebView. (WebFrame::WebFrame): Updated for WebFrameLoaderClient constructor change.
- WebFrame.h:
- 12:57 PM BuildingCairoOnWindows edited by
- (diff)
- 12:21 PM Changeset in webkit [30484] by
-
- 2 edits in branches/Safari-3-1-branch/WebKitTools
Merge r30480.
- 12:16 PM Changeset in webkit [30483] by
-
- 5 edits4 deletes in branches/Safari-3-1-branch
Roll out r29649.
- 12:05 PM Changeset in webkit [30482] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Adam.
<rdar://problem/5748781>
https://bugs.webkit.org/show_bug.cgi?id=17413
REGRESSION: Latest Nightly doesn't load Java plugin w/Safari 3.1b
Copy the Java plug-in over to the new location.
- FindSafari/FindSafari.cpp: (_tmain):
- 11:53 AM Changeset in webkit [30481] by
-
- 4 edits2 adds in trunk/WebKit/win
Start to move FrameLoaderClient methods off WebFrame onto a separate class
WebFrame now inherits from a new WebFrameLoaderClient class, which
will gradually assume all FrameLoaderClient responsibilities. Once
that process is complete, WebFrame will no longer inherit from
WebFrameLoaderClient.
In this first patch, I've only moved createDocumentLoader up to the
WebFrameLoaderClient class.
Reviewed by Anders.
- WebCoreSupport/WebFrameLoaderClient.cpp: Added. (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::~WebFrameLoaderClient): (WebFrameLoaderClient::createDocumentLoader): Moved here from WebFrame.cpp.
- WebCoreSupport/WebFrameLoaderClient.h: Added.
- WebFrame.cpp: Removed createDocumentLoader implementation.
- WebFrame.h: Changed to inherit from WebFrameLoaderClient.
- WebKit.vcproj/WebKit.vcproj: Added new files to the project.
- 11:51 AM Changeset in webkit [30480] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Adam.
<rdar://problem/5747325> REGRESSION: HTTP layout tests hang
- DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Init the URL request with the correct timeout.
- 11:07 AM Changeset in webkit [30479] by
-
- 3 edits2 adds in trunk/WebKit/win
Move FormValuesPropertyBag into its own files
Reviewed by Sam.
- WebCoreSupport/FormValuesPropertyBag.cpp: Added. (FormValuesPropertyBag::QueryInterface): (FormValuesPropertyBag::AddRef): (FormValuesPropertyBag::Release): (FormValuesPropertyBag::Read): (FormValuesPropertyBag::Write): (FormValuesPropertyBag::CountProperties): (FormValuesPropertyBag::GetPropertyInfo): (FormValuesPropertyBag::LoadObject):
- WebCoreSupport/FormValuesPropertyBag.h: Added. (FormValuesPropertyBag::FormValuesPropertyBag):
- WebFrame.cpp: Deleted FormValuesPropertyBag code.
- WebKit.vcproj/WebKit.vcproj: Added new files to the project.
- 11:07 AM Changeset in webkit [30478] by
-
- 3 edits in trunk/WebKit/win
Remove some unused WebFrame methods
FrameWinClient was deleted back in r22965, but these methods were
never deleted.
Reviewed by Sam.
- WebFrame.cpp:
- WebFrame.h: Made one createFrame overload protected, since it's only called internally by WebFrame.
- 11:06 AM Changeset in webkit [30477] by
-
- 2 edits10 moves1 add in trunk/WebKit/win
Move Client implementations into a WebCoreSupport directory
Reviewed by Anders.
- WebKit.vcproj/WebKit.vcproj: Updated file paths, and added WebCoreSupport directory to the include path.
- WebCoreSupport/WebChromeClient.cpp: Renamed from WebKit/win/WebChromeClient.cpp.
- WebCoreSupport/WebChromeClient.h: Renamed from WebKit/win/WebChromeClient.h.
- WebCoreSupport/WebContextMenuClient.cpp: Renamed from WebKit/win/WebContextMenuClient.cpp.
- WebCoreSupport/WebContextMenuClient.h: Renamed from WebKit/win/WebContextMenuClient.h.
- WebCoreSupport/WebDragClient.cpp: Renamed from WebKit/win/WebDragClient.cpp.
- WebCoreSupport/WebDragClient.h: Renamed from WebKit/win/WebDragClient.h.
- WebCoreSupport/WebEditorClient.cpp: Renamed from WebKit/win/WebEditorClient.cpp.
- WebCoreSupport/WebEditorClient.h: Renamed from WebKit/win/WebEditorClient.h.
- WebCoreSupport/WebInspectorClient.cpp: Renamed from WebKit/win/WebInspectorClient.cpp.
- WebCoreSupport/WebInspectorClient.h: Renamed from WebKit/win/WebInspectorClient.h.
- 10:32 AM Changeset in webkit [30476] by
-
- 4 edits in trunk/WebKit/mac
Reviewed by Adam Roben
Reverted the changed from yesterday to add pasteAndMatchStyle:, as the existing
pasteAsPlainText: has the same behavior.
- WebView/WebHTMLView.mm: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): (-[WebHTMLView readSelectionFromPasteboard:]): (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView pasteAsRichText:]): (-[WebHTMLView paste:]):
- WebView/WebView.mm:
- WebView/WebViewPrivate.h:
- 2:27 AM Changeset in webkit [30475] by
-
- 5 edits in trunk
<rdar://problem/5759327> REGRESSION: while(NaN) acts like while(true)
Reviewed by Alexey P.
Fix yet another case where we incorrectly relied on implicit double
to bool coercion.
Feb 21, 2008:
- 11:04 PM Changeset in webkit [30474] by
-
- 1 edit in trunk/WebCore/css/MediaQueryEvaluator.cpp
Add null check to fix crash in media query code I checked in.
- 10:10 PM Changeset in webkit [30473] by
-
- 2 edits in trunk
2008-02-21 Alp Toker <alp@atoker.com>
Fix a configure script typo.
- configure.ac:
- 7:35 PM Changeset in webkit [30472] by
-
- 32 edits in trunk
WebCore:
Reviewed by Anders Carlsson.
Fix for <rdar://problem/5757946>
- Parse URLs before checking whether they are javascript: urls (which require security checks).
- bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue):
- bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL):
- bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL):
- bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc):
LayoutTests:
Reviewed by Anders Carlsson.
Update tests and results for <rdar://problem/5757946>
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS.html:
- 6:21 PM Changeset in webkit [30471] by
-
- 3 edits in branches/Safari-3-1-branch/WebCore
Merge r30461.
- 6:21 PM Changeset in webkit [30470] by
-
- 3 edits2 adds in branches/Safari-3-1-branch
Merge r30458.
- 6:21 PM Changeset in webkit [30469] by
-
- 9 edits in branches/Safari-3-1-branch
Merge r30433.
- 5:07 PM Changeset in webkit [30468] by
-
- 3 edits2 adds in trunk
<rdar://problem/5757873> Buffer overrun in DeprecatedCString::find() in WebCore
We could get a buffer overrun in DeprecatedCString::find() if the end of the
string matches a beginning portion of the substring, for example, if string is
"a" but the substring is "ab".
The code as is also will not match things correctly under certain situations
since the inner while loop increments the index. For example, we wouldn't find
a match if the string is "aab..." and the substring is "ab". Changed the
inner while loop to increment a temporary index into str.
Test: fast/loader/charset-parse.html
Reviewed by Dan Berstein.
- platform/DeprecatedCString.cpp: (WebCore::DeprecatedCString::find):
- 4:15 PM Changeset in webkit [30467] by
-
- 5 adds in trunk/LayoutTests
Add test case for viewport media queries.
- 4:14 PM Changeset in webkit [30466] by
-
- 9 edits in trunk/WebCore
Fix for bug 17301. CSS media queries need to use the correct viewport
when contained in documents inside iframes (rather than always using the
top-level document's viewport). CSS media queries based on the viewport
also needed to be dynamic and update as you resize the window (this is
a HOT feature). :)
This patch gets Acid3 up to 86/100 with 3 colored boxes filled in.
Reviewed by olliej
Added fast/media/viewport-media-query.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::addViewportDependentMediaQueryResult): (WebCore::CSSStyleSelector::affectedByViewportChange):
- css/CSSStyleSelector.h: (WebCore::MediaQueryResult::MediaQueryResult):
- css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::MediaQueryEvaluator): (WebCore::MediaQueryEvaluator): (WebCore::MediaQueryEvaluator::eval): (WebCore::colorMediaFeatureEval): (WebCore::monochromeMediaFeatureEval): (WebCore::device_aspect_ratioMediaFeatureEval): (WebCore::device_pixel_ratioMediaFeatureEval): (WebCore::gridMediaFeatureEval): (WebCore::device_heightMediaFeatureEval): (WebCore::device_widthMediaFeatureEval): (WebCore::heightMediaFeatureEval): (WebCore::widthMediaFeatureEval): (WebCore::min_colorMediaFeatureEval): (WebCore::max_colorMediaFeatureEval): (WebCore::min_monochromeMediaFeatureEval): (WebCore::max_monochromeMediaFeatureEval): (WebCore::min_device_aspect_ratioMediaFeatureEval): (WebCore::max_device_aspect_ratioMediaFeatureEval): (WebCore::min_device_pixel_ratioMediaFeatureEval): (WebCore::max_device_pixel_ratioMediaFeatureEval): (WebCore::min_heightMediaFeatureEval): (WebCore::max_heightMediaFeatureEval): (WebCore::min_widthMediaFeatureEval): (WebCore::max_widthMediaFeatureEval): (WebCore::min_device_heightMediaFeatureEval): (WebCore::max_device_heightMediaFeatureEval): (WebCore::min_device_widthMediaFeatureEval): (WebCore::max_device_widthMediaFeatureEval):
- css/MediaQueryEvaluator.h:
- css/MediaQueryExp.cpp: (WebCore::MediaQueryExp::~MediaQueryExp):
- css/MediaQueryExp.h: (WebCore::MediaQueryExp::value): (WebCore::MediaQueryExp::isViewportDependent):
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::pickMedia):
- page/FrameView.cpp: (WebCore::FrameView::layout):
- 1:23 PM Changeset in webkit [30465] by
-
- 10 edits in trunk
WebCore:
Reviewed by Sam.
Make more classes start out with a refcount of 1.
- dom/QualifiedName.cpp: (WebCore::QNameComponentsTranslator::translate): (WebCore::QualifiedName::QualifiedName):
- dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::create): (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
- history/BackForwardList.cpp: (WebCore::BackForwardList::BackForwardList):
- history/BackForwardList.h: (WebCore::BackForwardList::create):
- page/Page.cpp: (WebCore::Page::Page):
- platform/text/CString.cpp: (WebCore::CString::init): (WebCore::CString::newUninitialized): (WebCore::CString::copyBufferIfNeeded):
- platform/text/CString.h: (WebCore::CStringBuffer::create): (WebCore::CStringBuffer::CStringBuffer):
WebKit/mac:
Reviewed by Sam.
Use BackForwardList::create instead.
- History/WebBackForwardList.mm: (-[WebBackForwardList init]):
- 1:21 PM Changeset in webkit [30464] by
-
- 2 edits in trunk/WebCore
wx build fix for the domString() -> string() rename in r30443.
- 12:35 PM Changeset in webkit [30463] by
-
- 4 edits in trunk/WebKit/mac
Reviewed by Jessica Kahn
support for pasteAndMatchStyle: command (see <rdar://problem/5723952>)
- WebView/WebHTMLView.mm: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:matchStyle:]): added matchStyle parameter, passed along to bridge (formerly always passed NO to bridge) (-[WebHTMLView readSelectionFromPasteboard:]): pass NO for new matchStyle parameter to match old behavior (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): validate pasteAndMatchStyle the same way as pasteAsRichText (-[WebHTMLView pasteAndMatchStyle:]): just like pasteAsRichText but passes YES for matchStyle (-[WebHTMLView pasteAsRichText:]): pass NO for new matchStyle parameter to match old behavior (-[WebHTMLView paste:]): ditto
- WebView/WebView.mm: added macro(pasteAndMatchStyle)
- WebView/WebViewPrivate.h: added pasteAndMatchStyle: to WebViewEditingActionsPendingPublic category
- 12:16 PM Changeset in webkit [30462] by
-
- 2 edits in trunk
2008-02-21 Alp Toker <alp@atoker.com>
GTK+/autotools SVG experimental build fix
Don't enable SVG filters in --enable-svg-experimental.
This feature isn't supported at all yet. Developers can enable it
explicitly by passing --enable-svg-filters if needed.
- configure.ac:
- 12:10 PM Changeset in webkit [30461] by
-
- 3 edits in trunk/WebCore
Reviewed by Sam Weinig.
<rdar://problem/5753789>
REGRESSION: 1.5% -2% Sunspider regression from r30009 (ebay photo upload hang)
Ensure all versions of allowsAccessFrom are inlined to single functions.
This is a 2% win in browser hosted Sunspider.
- bindings/js/kjs_window.cpp: (KJS::Window::allowsAccessFrom): (KJS::Window::allowsAccessFromPrivate):
- bindings/js/kjs_window.h:
- 11:59 AM Changeset in webkit [30460] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
- minor cleanup
- rendering/bidi.cpp: (WebCore::bidiNext): Removed redundant isBR() check -- isText() returns true for RenderLineBreak. (WebCore::bidiFirst): Ditto. (WebCore::shouldSkipWhitespaceAfterStartObject): (WebCore::RenderBlock::findNextLineBreak):
- 11:43 AM Changeset in webkit [30459] by
-
- 4 edits in trunk
2008-02-21 Mike Auty <mike.auty@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=17445
[GTK] WebKit doesn't compile with LDFLAGS="-Wl,--as-needed"
The GNUmakefile.am files make use of the LDFLAGS variable to include library
additions such as -ljpeg etc. Unfortunately, if these inclusions aren't made
in LIBADD/LDADD variables, then they are mis-ordered during the linking.
The as-needed flag discards libraries whose functions have not been needed by
earlier libraries, which therefore makes the ordering important.
This moves all -l library inclusion statements from LDFLAGS variables to
LIBADD/LDADD variables.
- GNUmakefile.am:
- 10:09 AM Changeset in webkit [30458] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by David Harrison.
Fixed <rdar://problem/5756125> REGRESSION: A crash occurs at
WebCore::Frame::scriptProxy() when completing a search with Package Tracker widget
Test: fast/dom/script-element-without-frame-crash.html
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Added back a NULL check that was accidentally removed in r30325.
LayoutTests:
Reviewed by David Harrison.
Test for <rdar://problem/5756125> REGRESSION: A crash occurs at
WebCore::Frame::scriptProxy() when completing a search with Package Tracker widget
- fast/dom/script-element-without-frame-crash-expected.txt: Added.
- fast/dom/script-element-without-frame-crash.html: Added.
- 9:30 AM Changeset in webkit [30457] by
-
- 2 edits in trunk/WebCore
2008-02-21 Rodney Dawes <dobey@wayofthemonkey.com>
GTK+ build fix. s/domString()/string()/
- platform/graphics/gtk/FontPlatformDataGtk.cpp: (FontPlatformData::FontPlatformData):
Feb 20, 2008:
- 11:54 PM Changeset in webkit [30456] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Dan Bernstein.
Gratuitous change to this test to use the instanceof operator
instead of the isPrototypeOf method.
- fast/tokenizer/doctype-search-reset.html:
- 11:38 PM Changeset in webkit [30455] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=17465 REGRESSION: <DIV> tokenized into Div if still searching for DOCTYPE
Test: fast/tokenizer/doctype-search-reset.html
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
LayoutTests:
Reviewed by Dave Hyatt.
- test for http://bugs.webkit.org/show_bug.cgi?id=17465 REGRESSION: <DIV> tokenized into Div if still searching for DOCTYPE
- fast/tokenizer/doctype-search-reset-expected.txt: Added.
- fast/tokenizer/doctype-search-reset.html: Added.
- 9:00 PM Changeset in webkit [30454] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=17464 REGRESSION: Crash in RenderBlock::findNextLineBreak reading r30444 commit email in GMail
Test: fast/text/wbr-in-pre-crash.html
- rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):
LayoutTests:
Reviewed by Dave Hyatt.
- test for http://bugs.webkit.org/show_bug.cgi?id=17464 REGRESSION: Crash in RenderBlock::findNextLineBreak reading r30444 commit email in GMail
- fast/text/wbr-in-pre-crash.html: Added.
- platform/mac-leopard/fast/text/wbr-in-pre-crash-expected.checksum: Added.
- platform/mac-leopard/fast/text/wbr-in-pre-crash-expected.png: Added.
- platform/mac/fast/text/wbr-in-pre-crash-expected.txt: Added.
- 8:50 PM Changeset in webkit [30453] by
-
- 3 edits3 adds in trunk
Reviewed by Darin.
Fix for Bug 16753: date set methods with no args should result in NaN (Acid3 bug)
The set values result in NaN now when called with no args, NaN or +/- inf values.
The setYear, setFullYear and setUTCFullYear methods used on NaN dates work as
descripted in the standard.
- kjs/date_object.cpp: (KJS::fillStructuresUsingTimeArgs): (KJS::fillStructuresUsingDateArgs): (KJS::setNewValueFromTimeArgs): (KJS::setNewValueFromDateArgs): (KJS::dateProtoFuncSetYear):
LayoutTests:
Reviewed by Darin.
- test for Bug 16753: date set methods with no args should result in NaN (Acid3 bug)
- fast/js/date-set-to-nan-expected.txt: Added.
- fast/js/date-set-to-nan.html: Added.
- fast/js/resources/date-set-to-nan.js: Added.
- 8:24 PM Changeset in webkit [30452] by
-
- 3 edits2 adds in trunk
Bug 17303: Canvas crash in ImageBuffer
Reviewed by Hyatt.
We handle a null GraphicsContext everywhere, but we weren't checking for
a null ImageBuffer, which is what will result in a null GraphicsContext in
the first place.
- 8:06 PM Changeset in webkit [30451] by
-
- 1 edit in trunk/LayoutTests/platform/mac/fast/media/mq-js-stylesheet-media-03-expected.txt
Land new results for a layout test that now passes now that dynamic media lists work.
- 8:05 PM Changeset in webkit [30450] by
-
- 4 edits in trunk/WebCore
Fix the layout test failure that never should have passed in the first
place by making changes to media lists actually result in the recomputation
of the style selector. Now it passes for the right reasons and not because
of dumb luck.
Reviewed by Sam Weinig
- css/MediaList.cpp: (WebCore::MediaList::deleteMedium): (WebCore::MediaList::setMediaText): (WebCore::MediaList::appendMedium): (WebCore::MediaList::notifyChanged):
- css/MediaList.h:
- dom/Document.cpp: (WebCore::Document::attach):
- 8:00 PM Changeset in webkit [30449] by
-
- 2 edits in trunk/WebCore
Reviewed, tweaked and landed by Sam.
- make markup functions not use DeprecatedString.
- editing/markup.cpp: (WebCore::append): Added. (WebCore::escapeContentText): Build up string using a Vector. (WebCore::appendStartMarkup): Use String instead of DeprecatedString.
- 7:57 PM Changeset in webkit [30448] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix changelog
- 7:54 PM Changeset in webkit [30447] by
-
- 3 edits in trunk/WebCore
Reviewed, tweaked and landed by Sam.
- make HTMLInterchange return a String instead of a DeprecatedString
- editing/TextIterator.cpp: (WebCore::CharacterIterator::string): Build up the String using a Vector. (WebCore::WordAwareIterator::advance): Switch to using Vector functions. (WebCore::WordAwareIterator::length): Ditto. (WebCore::WordAwareIterator::characters): Ditto.
- editing/TextIterator.h: Use a Vector<UChar> for the buffer instead of DeprecatedString.
- 7:42 PM Changeset in webkit [30446] by
-
- 3 edits in trunk/WebCore
Reviewed, tweaked and landed by Sam.
- make HTMLInterchange return a String instead of a DeprecatedString
- editing/HTMLInterchange.cpp: (WebCore::): Return a String from convertedSpaceString. (WebCore::convertHTMLTextToInterchangeFormat): Use a Vector instead of a DeprecatedString to build up the return String.
- editing/HTMLInterchange.h:
- 7:38 PM Changeset in webkit [30445] by
-
- 3 edits in trunk/WebCore
Reviewed by Oliver.
Remove m_drawingContext and change m_data to m_imageBuffer
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): (WebCore::HTMLCanvasElement::reset): (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::createImageBuffer): (WebCore::HTMLCanvasElement::buffer): (WebCore::HTMLCanvasElement::createPlatformImage):
- html/HTMLCanvasElement.h:
- 6:26 PM Changeset in webkit [30444] by
-
- 1 edit10 adds in trunk/WebKitTools
2008-02-20 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Alp.
- http://bugs.webkit.org/show_bug.cgi?id=17428 Reenable a Windows-based launcher
This patch reenables the venerable Spinneret application,
changing its name to match the other lanch applications.
- WinLauncher: Added.
- WinLauncher/WinLauncher.cpp: Added. (WinLauncherWebHost::updateAddressBar): (WinLauncherWebHost::QueryInterface): (WinLauncherWebHost::AddRef): (WinLauncherWebHost::Release): (resizeSubViews): (_tWinMain): (MyRegisterClass): (InitInstance): (WndProc): (MyEditProc): (About): (loadURL):
- WinLauncher/WinLauncher.h: Added. (WinLauncherWebHost::WinLauncherWebHost): (WinLauncherWebHost::didStartProvisionalLoadForFrame): (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame): (WinLauncherWebHost::didFailProvisionalLoadWithError): (WinLauncherWebHost::didCommitLoadForFrame): (WinLauncherWebHost::didReceiveTitle): (WinLauncherWebHost::didReceiveIcon): (WinLauncherWebHost::didFinishLoadForFrame): (WinLauncherWebHost::didFailLoadWithError): (WinLauncherWebHost::didChangeLocationWithinPageForFrame): (WinLauncherWebHost::willPerformClientRedirectToURL): (WinLauncherWebHost::didCancelClientRedirectForFrame): (WinLauncherWebHost::willCloseFrame): (WinLauncherWebHost::windowScriptObjectAvailable):
- WinLauncher/WinLauncher.ico: Added.
- WinLauncher/WinLauncher.rc: Added.
- WinLauncher/WinLauncher.vcproj: Added.
- WinLauncher/resource.h: Added.
- WinLauncher/small.ico: Added.
- WinLauncher/stdafx.cpp: Added.
- WinLauncher/stdafx.h: Added.
- 6:17 PM Changeset in webkit [30443] by
-
- 28 edits in trunk/WebCore
Reviewed by Sam.
Rename AtomicString::domString() to AtomicString::string().
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::getFontData):
- dom/Attr.cpp: (WebCore::Attr::createTextChild):
- dom/Comment.cpp: (WebCore::Comment::nodeName):
- dom/Document.cpp: (WebCore::Document::recalcStyleSelector): (WebCore::Document::setHTMLWindowEventListener): (WebCore::Document::formElementsState):
- dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute):
- dom/Text.cpp: (WebCore::Text::nodeName):
- editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
- html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch):
- html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName): (WebCore::HTMLElement::setHTMLEventListener):
- html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::getNamedFormItem):
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): (WebCore::HTMLImageElement::isURLAttribute):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute): (WebCore::HTMLLinkElement::tokenizeRelAttribute):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isURLAttribute): (WebCore::HTMLObjectElement::containsJavaApplet):
- html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::isURLAttribute):
- html/HTMLParser.cpp: (WebCore::HTMLParser::handleIsindex):
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::insertedIntoDocument): (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::parseMappedAttribute):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::saveDocumentState):
- page/FrameTree.cpp: (WebCore::FrameTree::uniqueChildName):
- platform/text/AtomicString.h: (WebCore::AtomicString::string): (WebCore::AtomicString::contains): (WebCore::AtomicString::find): (WebCore::AtomicString::startsWith): (WebCore::AtomicString::endsWith):
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
- svg/SVGElement.cpp: (WebCore::SVGElement::addSVGEventListener):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::addSVGWindowEventListener):
- xml/XPathFunctions.cpp: (WebCore::XPath::FunLocalName::evaluate): (WebCore::XPath::FunNamespaceURI::evaluate): (WebCore::XPath::FunName::evaluate):
- 6:12 PM Changeset in webkit [30442] by
-
- 1 edit in trunk/WebCore/ChangeLog
Remove stray conflict marker
- 6:10 PM Changeset in webkit [30441] by
-
- 10 edits2 copies1 move3 adds1 delete in trunk/WebCore
2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Dan.
http://bugs.webkit.org/show_bug.cgi?id=17336
Provide implementations for Windows (Cairo) build of WebKit that
handles font formatting.
- Split font implementation files to allow maximal code sharing between CG and Cairo back-ends.
- WebCore.vcproj/WebCore.vcproj:
- platform/graphics/SimpleFontData.h: Add signatures for private win initialization functions.
- platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::platformInit): (WebCore::FontCache::createFontPlatformData):
- platform/graphics/win/FontCairoWin.cpp: Removed. Universal version is now part of platform/graphics/cairo.
- platform/graphics/win/FontCustomPlatformDataCairo.cpp: Added. (WebCore::FontCustomPlatformDataCairo::~FontCustomPlatformDataCairo): (WebCore::FontCustomPlatformDataCairo::fontPlatformData): (WebCore::releaseData): (WebCore::createFontCustomPlatformData):
- platform/graphics/win/FontCustomPlatformDataCairo.h: Added. (WebCore::FontCustomPlatformDataCairo::FontCustomPlatformDataCairo):
- platform/graphics/win/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::fontFace): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::operator==):
- platform/graphics/win/FontPlatformDataCGWin.cpp: Copied from WebCore/platform/graphics/win/FontPlatformDataWin.cpp. (WebCore::FontPlatformData::platformDataInit):
- platform/graphics/win/FontPlatformDataCairoWin.cpp: Added. (WebCore::FontPlatformData::platformDataInit): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::setFont):
- platform/graphics/win/FontPlatformDataWin.cpp: Moved CG-specific code to FontPlatformDataCG.cpp. (WebCore::FontPlatformData::FontPlatformData):
- platform/graphics/win/GlyphPageTreeNodeCGWin.cpp: Copied from WebCore/platform/graphics/win/GlyphPageTreeNodeWin.cpp.
- platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp: Copied from WebCore/platform/graphics/win/GlyphPageTreeNodeWin.cpp. (WebCore::GlyphPage::fill):
- platform/graphics/win/GlyphPageTreeNodeWin.cpp: Removed. Replaced with CG- and Cairo-specific versions.
- platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::platformWidthForGlyph): (WebCore::SimpleFontData::setFont):
- platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont): (WebCore::SimpleFontData::platformCommonDestroy): (WebCore::SimpleFontData::widthForGDIGlyph):
- 6:03 PM Changeset in webkit [30440] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- dom/Node.h: Took out unneeded forward declaration of TextStream.
- 6:01 PM Changeset in webkit [30439] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- rendering/RenderObject.h: Took out unneeded forward declaration of TextStream.
- 5:59 PM Changeset in webkit [30438] by
-
- 4 edits in trunk/WebCore
Fix for bug 16760, incorrect <object> MIME type handling and fallback
handling.
Reviewed by darin
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::notifyFinished): If the image had an error, make sure to do <object> fallback.
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent): Before doing fallback check if there is a MIME type mismatch between an image type and a non-image type. If so, detach and re-attach after storing the correct MIME type.
- loader/loader.cpp: (WebCore::Loader::didReceiveData): Consider it an error when a 404 is encountered on a CachedResource load.
- 5:41 PM Changeset in webkit [30437] by
-
- 4 edits in trunk/WebCore
Reviewed by Sam.
StringImpl constructors used by AtomicString should start with a refcount of 1.
- platform/text/AtomicString.cpp: (WebCore::AtomicString::add):
- platform/text/AtomicString.h:
- platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl):
- 5:06 PM Changeset in webkit [30436] by
-
- 2 edits in trunk/WebCore
- bindings/js/kjs_navigator.cpp: (WebCore::needsYouTubeQuirk): Tweak comments.
- 4:55 PM Changeset in webkit [30435] by
-
- 1 copy in tags/Safari-5525.10
New tag.
- 3:54 PM Changeset in webkit [30434] by
-
- 16 edits in trunk/WebCore
Reviewed by Darin.
Change all refcounted classes in page/ to start with a refcount of 1.
- page/BarInfo.cpp: (WebCore::BarInfo::BarInfo):
- page/BarInfo.h: (WebCore::BarInfo::create):
- page/Console.cpp: (WebCore::Console::Console):
- page/Console.h: (WebCore::Console::create):
- page/DOMSelection.cpp: (WebCore::DOMSelection::DOMSelection):
- page/DOMSelection.h: (WebCore::DOMSelection::create):
- page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::screen): (WebCore::DOMWindow::history): (WebCore::DOMWindow::locationbar): (WebCore::DOMWindow::menubar): (WebCore::DOMWindow::personalbar): (WebCore::DOMWindow::scrollbars): (WebCore::DOMWindow::statusbar): (WebCore::DOMWindow::toolbar): (WebCore::DOMWindow::console): (WebCore::DOMWindow::getSelection):
- page/DOMWindow.h: (WebCore::DOMWindow::create):
- page/Frame.cpp: (WebCore::Frame::domWindow):
- page/History.cpp: (WebCore::History::History):
- page/History.h: (WebCore::History::create):
- page/InspectorController.cpp: (WebCore::InspectorResource::create): (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorDatabaseResource::create): (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::didOpenDatabase):
- page/Plugin.h: (WebCore::Plugin::create): (WebCore::Plugin::Plugin):
- page/Screen.cpp: (WebCore::Screen::Screen):
- page/Screen.h: (WebCore::Screen::create):
- 3:04 PM Changeset in webkit [30433] by
-
- 9 edits in trunk
WebCore:
Reviewed by Darin and Geoff.
- <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
- WebCore.base.exp: Updated.
- bindings/js/kjs_navigator.cpp: (WebCore::needsYouTubeQuirk): Added. Return true on Windows only when the quirk is needed. (WebCore::Navigator::getValueProperty): For the appVersion property, if needsYouTubeQuirk return true, then return the empty string.
- page/Settings.cpp: (WebCore::Settings::Settings): Set m_needsSiteSpecificQuirks to false. (WebCore::Settings::setNeedsSiteSpecificQuirks): Added.
- page/Settings.h: Added m_needsSiteSpecificQuirks. (WebCore::Settings::needsSiteSpecificQuirks): Added.
WebKit/mac:
Reviewed by Darin and Geoff.
- WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Added a call to Settings::setNeedsSiteSpecificQuirks. There are currently no site-specific quirks on Mac, but we will propagate the state to WebCore to avoid possible mistakes later.
WebKit/win:
Reviewed by Darin and Geoff.
- WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
- WebView.cpp: (WebView::notifyPreferencesChanged): Added a call to Settings::setNeedsSiteSpecificQuirks. (WebView::setAllowSiteSpecificHacks): Added a comment about the problem Darin noticed, where after you disable the site-specific hacks they persist until you open a new window or tweak some other preference.
- 2:57 PM Changeset in webkit [30432] by
-
- 1 edit in trunk/WebCore/dom/DocumentType.cpp
Land additional doctype piece. toString fix of doctype.
- 2:47 PM Changeset in webkit [30431] by
-
- 113 edits15 adds in trunk
Fix for bug 12751, doctype nodes aren't part of the Document (Acid3).
Reviewed by Sam Weinig
Many tests added in fast/doctypes.
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setDocType): (WebCore::Document::attach): (WebCore::Document::getImageMap):
- dom/Document.h: (WebCore::Document::doctype): (WebCore::Document::): (WebCore::Document::determineParseMode): (WebCore::Document::setParseMode): (WebCore::Document::parseMode): (WebCore::Document::inCompatMode): (WebCore::Document::inAlmostStrictMode): (WebCore::Document::inStrictMode):
- dom/DocumentType.cpp: (WebCore::DocumentType::cloneNode): (WebCore::DocumentType::insertedIntoDocument): (WebCore::DocumentType::removedFromDocument):
- dom/DocumentType.h:
- dom/Node.cpp: (WebCore::Node::childAllowed):
- dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged):
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::internalSubset): (WebCore::):
- editing/markup.cpp: (WebCore::appendStartMarkup):
- html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer):
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): (WebCore::HTMLDocument::childAllowed): (WebCore::HTMLDocument::determineParseMode):
- html/HTMLDocument.h:
- html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseMappedAttribute):
- html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::parseMappedAttribute):
- html/HTMLParser.cpp: (WebCore::HTMLParser::parseDoctypeToken):
- html/HTMLParser.h:
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::parseDoctype): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::finish): (WebCore::HTMLTokenizer::processDoctypeToken):
- html/HTMLTokenizer.h: (WebCore::): (WebCore::DoctypeToken::DoctypeToken): (WebCore::DoctypeToken::reset): (WebCore::DoctypeToken::state): (WebCore::DoctypeToken::setState): (WebCore::HTMLTokenizer::State::inDoctype): (WebCore::HTMLTokenizer::State::setInDoctype): (WebCore::HTMLTokenizer::State::needsSpecialWriteHandling): (WebCore::HTMLTokenizer::State::):
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addViewSourceDoctypeToken):
- html/HTMLViewSourceDocument.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::write): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
- page/Frame.cpp: (WebCore::Frame::documentTypeString):
- page/inspector/utilities.js:
- xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):
- 2:28 PM Changeset in webkit [30430] by
-
- 60 edits in trunk/WebCore
Reviewed by Darin.
Change most SVG related classes to start out with a ref count of 1.
- bindings/js/JSSVGPointListCustom.cpp: (WebCore::JSSVGPointList::initialize): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::appendItem):
- bindings/js/JSSVGTransformListCustom.cpp: (WebCore::JSSVGTransformList::initialize): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::appendItem):
- rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGCharOnPath::create): (WebCore::SVGCharOnPath::SVGCharOnPath):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseBeginOrEndValue):
- svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::canvasResource):
- svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::childNodes):
- svg/SVGElementInstanceList.cpp: (WebCore::SVGElementInstanceList::SVGElementInstanceList):
- svg/SVGElementInstanceList.h: (WebCore::SVGElementInstanceList::create):
- svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::SVGFitToViewBox):
- svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::canvasResource):
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::SVGImageElement):
- svg/SVGLengthList.h: (WebCore::SVGLengthList::create):
- svg/SVGList.h: (WebCore::SVGList::SVGList): (WebCore::SVGPODListItem::create): (WebCore::SVGPODListItem::copy): (WebCore::SVGPODListItem::SVGPODListItem): (WebCore::SVGPODList::initialize): (WebCore::SVGPODList::insertItemBefore): (WebCore::SVGPODList::replaceItem): (WebCore::SVGPODList::appendItem): (WebCore::SVGPODList::SVGPODList):
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::canvasResource):
- svg/SVGNumberList.h: (WebCore::SVGNumberList::create):
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::createSVGPathSegClosePath): (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): (WebCore::SVGPathElement::createSVGPathSegMovetoRel): (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): (WebCore::SVGPathElement::createSVGPathSegArcAbs): (WebCore::SVGPathElement::createSVGPathSegArcRel): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel): (WebCore::SVGPathElement::pathSegList):
- svg/SVGPathElement.h:
- svg/SVGPathSeg.h: (WebCore::SVGPathSeg::SVGPathSeg):
- svg/SVGPathSegArc.h: (WebCore::SVGPathSegArcAbs::create): (WebCore::SVGPathSegArcRel::create):
- svg/SVGPathSegClosePath.h: (WebCore::SVGPathSegClosePath::create):
- svg/SVGPathSegCurvetoCubic.h: (WebCore::SVGPathSegCurvetoCubicAbs::create): (WebCore::SVGPathSegCurvetoCubicRel::create):
- svg/SVGPathSegCurvetoCubicSmooth.h: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::create): (WebCore::SVGPathSegCurvetoCubicSmoothRel::create):
- svg/SVGPathSegCurvetoQuadratic.h: (WebCore::SVGPathSegCurvetoQuadraticAbs::create): (WebCore::SVGPathSegCurvetoQuadraticRel::create):
- svg/SVGPathSegCurvetoQuadraticSmooth.h: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::create): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::create):
- svg/SVGPathSegLineto.h: (WebCore::SVGPathSegLinetoAbs::create): (WebCore::SVGPathSegLinetoRel::create):
- svg/SVGPathSegLinetoHorizontal.h: (WebCore::SVGPathSegLinetoHorizontalAbs::create): (WebCore::SVGPathSegLinetoHorizontalRel::create):
- svg/SVGPathSegLinetoVertical.h: (WebCore::SVGPathSegLinetoVerticalAbs::create): (WebCore::SVGPathSegLinetoVerticalRel::create):
- svg/SVGPathSegList.h: (WebCore::SVGPathSegList::create):
- svg/SVGPathSegMoveto.h: (WebCore::SVGPathSegMovetoAbs::create): (WebCore::SVGPathSegMovetoRel::create):
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::canvasResource):
- svg/SVGPointList.h: (WebCore::SVGPointList::create):
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::points):
- svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
- svg/SVGPreserveAspectRatio.h: (WebCore::SVGPreserveAspectRatio::create):
- svg/SVGRenderingIntent.h: (WebCore::SVGRenderingIntent::SVGRenderingIntent):
- svg/SVGStringList.h: (WebCore::SVGStringList::create):
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):
- svg/SVGTests.cpp: (WebCore::SVGTests::requiredFeatures): (WebCore::SVGTests::requiredExtensions): (WebCore::SVGTests::systemLanguage):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement):
- svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
- svg/SVGTransformList.h: (WebCore::SVGTransformList::create):
- svg/SVGUnitTypes.h: (WebCore::SVGUnitTypes::SVGUnitTypes):
- svg/SVGViewElement.cpp: (WebCore::SVGViewElement::viewTarget):
- svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::SVGViewSpec):
- svg/graphics/SVGPaintServer.cpp: (WebCore::SVGPaintServer::sharedSolidPaintServer):
- svg/graphics/SVGPaintServer.h:
- svg/graphics/SVGPaintServerGradient.h: (WebCore::SVGPaintServerGradient::SharedStopCache::create): (WebCore::SVGPaintServerGradient::SharedStopCache::SharedStopCache):
- svg/graphics/SVGPaintServerLinearGradient.h: (WebCore::SVGPaintServerLinearGradient::create):
- svg/graphics/SVGPaintServerPattern.h: (WebCore::SVGPaintServerPattern::create):
- svg/graphics/SVGPaintServerRadialGradient.h: (WebCore::SVGPaintServerRadialGradient::create):
- svg/graphics/SVGPaintServerSolid.h: (WebCore::SVGPaintServerSolid::create):
- svg/graphics/SVGResource.cpp: (WebCore::SVGResource::SVGResource):
- svg/graphics/SVGResource.h:
- svg/graphics/SVGResourceClipper.h: (WebCore::SVGResourceClipper::create):
- svg/graphics/SVGResourceMarker.h: (WebCore::SVGResourceMarker::create):
- svg/graphics/SVGResourceMasker.h: (WebCore::SVGResourceMasker::create):
- svg/graphics/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
- 1:36 PM Changeset in webkit [30429] by
-
- 7 edits in trunk/WebCore
Reviewed by Sam.
- make conversion from CSS ParseString to String and AtomicString automatic and remove all the explicit calls to do the conversion
- fix CSS parsing to do fewer allocations, mostly by using the equalIgnoringCase function in CSSParser
- css/CSSGrammar.y: Take out all the explicit atomicString and domString calls now that ParseString knows how to convert itself.
- css/CSSParser.cpp: (WebCore::equal): Added. (WebCore::equalIgnoringCase): Allow non-lettters. (WebCore::ParseString::lower): Used charactersAreAllASCII. (WebCore::unitFromString): Use equal. (WebCore::CSSParser::parseValue): Removed unneeded call to domString. (WebCore::CSSParser::parseContent): Use equalIgnoringCase. (WebCore::CSSParser::parseBackgroundImage): Removed unneeded call to domString. (WebCore::CSSParser::parseTransitionTimingFunction): Use equalIgnoringCase. (WebCore::CSSParser::parseDashboardRegions): More of the same. (WebCore::CSSParser::parseCounterContent): Ditto. (WebCore::CSSParser::parseShape): Use equalIgnoringCase. (WebCore::CSSParser::parseFontFamily): Removed unneeded calls to domString. (WebCore::CSSParser::parseFontFaceSrc): More. (WebCore::CSSParser::parseFontFaceUnicodeRange): More. (WebCore::CSSParser::parseColor): Don't lowercase here -- setNamedColor now handles the case folding. (WebCore::CSSParser::parseColorFromValue): More. (WebCore::CSSParser::parseBorderImage): More. (WebCore::CSSParser::parseCounter): More. (WebCore::TransformOperationInfo::TransformOperationInfo): More. (WebCore::CSSParser::parseTransform): More. (WebCore::CSSParser::createCharsetRule): More. (WebCore::CSSParser::createImportRule): More.
- css/CSSParser.h: Removed domString and atomicString functions. (WebCore::ParseString::operator String): Added. Allows conversion to String without an explicit function call. (WebCore::ParseString::operator AtomicString): Ditto.
- css/MediaQueryExp.cpp: (WebCore::MediaQueryExp::MediaQueryExp): Removed a call to domString.
- css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): Removed calls to domString.
- platform/graphics/Color.cpp: (WebCore::findNamedColor): Call toASCIILower on each character as we copy it into the 8-bit character buffer to make the operation fold case.
- 1:05 PM Changeset in webkit [30428] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
- 1:03 PM Changeset in webkit [30427] by
-
- 1 edit in trunk/LayoutTests/svg/dynamic-updates/resources/SVGTestCase.js
Fix a bug in this SVG test harness. Make sure it uses document.documentElement instead of document.firstChild.
- 12:59 PM Changeset in webkit [30426] by
-
- 2 edits in branches/Safari-3-1-branch/WebKit/win
Merge r30400.
- 9:48 AM Changeset in webkit [30425] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore changes
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): The common case here is where there are no special elements. Avoid creating VisiblePositions in that case. Additionally, this change postpones the more expensive creation of an upstream VisiblePosition until the last possible moment. (WebCore::DeleteSelectionCommand::saveTypingStyleState): (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Add an early return for a common case: deleting characters that are all inside the same text node. In that case the style at the start of the selection will not change during the delete, so there is no need to save/recompute it. (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Early return before VisiblePosition creation if the ends of the selection aren't enclosed by an anchor.
- editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping): Early return if spell checking isn't enabled.
- 4:35 AM Changeset in webkit [30424] by
-
- 3 edits2 adds in trunk
Incorporates some improvements made by Dan Bernstein.
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=17106
<rdar://problem/5750722> Debug build ASSERTs on page load
Test: fast/encoding/GBK/close-gbk-converter.html
- platform/text/TextCodecICU.cpp: (WebCore::getGbkEscape): Changed to use a switch instead of a HashMap, as there are only four values. (WebCore::gbkCallbackEscape): Check the reason why the function is called, and do not attempt getting an escape character if it's not UCNV_UNASSIGNED. (WebCore::gbkCallbackSubstitute): Ditto.
- 3:39 AM Changeset in webkit [30423] by
-
- 2 edits in trunk/WebCore
Build fix.
- xml/XMLHttpRequest.cpp: (WebCore::isSafeRequestHeader): (WebCore::XMLHttpRequest::setRequestHeader):
- 3:10 AM Changeset in webkit [30422] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/5749455> Unable to set the Referer header in Dashboard using XMLHttpRequest
Cannot be tested in DRT.
- xml/XMLHttpRequest.cpp: (WebCore::canSetRequestHeader): Assume that a request that can load local files can also set any headers.
- 12:08 AM BuildingCairoOnWindows edited by
- (diff)
Feb 19, 2008:
- 6:17 PM Changeset in webkit [30421] by
-
- 6 edits in trunk/WebCore
Reviewed by Sam.
- removed use of DeprecatedString for font family names
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Update for name change.
- css/CSSParser.cpp: (WebCore::CSSParser::parseFontFamily): Update to use new appendSpaceSeparated function and String rather than DeprecatedString.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Updated for name change.
- css/FontFamilyValue.cpp: (WebCore::FontFamilyValue::FontFamilyValue): Replaced code using a regular expression with code that does the same thing more efficiently. (WebCore::FontFamilyValue::appendSpaceSeparated): Added. (WebCore::FontFamilyValue::cssText): Updated for name change.
- css/FontFamilyValue.h: Changed DeprecatedString to String. Renamed fontName to familyName and parsedFontName to m_familyName. Removed unused genericFamilyType and m_genericFamilyType. Added appendSpaceSeparated so that m_familyName can be private instead of public.
- 6:07 PM Changeset in webkit [30420] by
-
- 2 edits in trunk/WebCore
- fix build when SVG is not enabled
- rendering/RenderTreeAsText.cpp: Added include of "TextStream.h".
- 5:55 PM Changeset in webkit [30419] by
-
- 23 edits in trunk/WebCore
Reviewed by Darin.
Change all classes in xml/ to start out with a ref count of 1.
- bindings/js/JSCustomXPathNSResolver.h:
- bindings/js/JSXMLHttpRequest.cpp: (WebCore::JSXMLHttpRequest::JSXMLHttpRequest):
- bindings/js/JSXSLTProcessor.cpp: (WebCore::JSXSLTProcessor::JSXSLTProcessor):
- bindings/objc/DOMCustomXPathNSResolver.h: (WebCore::DOMCustomXPathNSResolver::create):
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- dom/Document.cpp: (WebCore::Document::applyXSLTransform): (WebCore::Document::createExpression): (WebCore::Document::createNSResolver): (WebCore::Document::evaluate):
- xml/DOMParser.h: (WebCore::DOMParser::create): (WebCore::DOMParser::DOMParser):
- xml/NativeXPathNSResolver.h: (WebCore::NativeXPathNSResolver::create):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest):
- xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::create):
- xml/XMLSerializer.h: (WebCore::XMLSerializer::create): (WebCore::XMLSerializer::XMLSerializer):
- xml/XPathEvaluator.cpp: (WebCore::XPathEvaluator::createNSResolver):
- xml/XPathEvaluator.h: (WebCore::XPathEvaluator::create): (WebCore::XPathEvaluator::XPathEvaluator):
- xml/XPathExpression.cpp: (WebCore::XPathExpression::createExpression): (WebCore::XPathExpression::evaluate):
- xml/XPathExpression.h: (WebCore::XPathExpression::create): (WebCore::XPathExpression::XPathExpression):
- xml/XPathNSResolver.h:
- xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult):
- xml/XPathResult.h: (WebCore::XPathResult::create):
- xml/XPathValue.cpp: (WebCore::XPath::Value::modifiableNodeSet):
- xml/XPathValue.h: (WebCore::XPath::ValueData::create): (WebCore::XPath::ValueData::ValueData): (WebCore::XPath::Value::Value):
- xml/XSLTProcessor.h: (WebCore::XSLTProcessor::create): (WebCore::XSLTProcessor::XSLTProcessor):
- 5:51 PM Changeset in webkit [30418] by
-
- 9 edits in trunk
WebCore:
Reviewed by Sam.
- Trimmed down TextStream and weaned it from DeprecatedString.
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge renderTreeAsExternalRepresentation]): Removed now-unneeded call to getNSString.
- platform/text/TextStream.cpp: Removed unused functions. Use snprintf instead of sprintf, for better security. (WebCore::TextStream::release): Added.
- platform/text/TextStream.h: Removed lots of unneeded stuff.
- rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): Changed to use String instead of DeprecatedString.
- rendering/RenderTreeAsText.h: Ditto.
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGInlineTextBox): Use "\n" instead of endl. (WebCore::write): Ditto. (WebCore::writeRenderResources): Ditto.
WebKit/win:
Reviewed by Sam.
- WebFrame.cpp: (WebFrame::renderTreeAsExternalRepresentation): Changed to use String instead of DeprecatedString.
- 5:43 PM Changeset in webkit [30417] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore changes
This brings performance on the phone back to old levels. Andre and I are doing
some formal testing to see exactly where we stand.
- dom/Position.cpp: (WebCore::enclosingBlockIgnoringEditability): Added. This is enclosingBlock without the expensive editability checks. upstream and downstream can avoid those because they do their own editability checking. (WebCore::Position::upstream): (WebCore::Position::downstream):
- 4:41 PM Changeset in webkit [30416] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/3663560> AXLink for a "name" (anchor) on same page should include an AXLinkedUIElementAttribute
- bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject linkedUIElement]): Returns the linked-to AX object (if the specified one is ignored by accessibility, returns the next un-ignored one by traversing the DOM).
(-[WebCoreAXObject accessibilityAttributeNames]):
(-[WebCoreAXObject accessibilityAttributeValue:]):
Support NSAccessibilityLinkedUIElementsAttribute.
- 4:00 PM Changeset in webkit [30415] by
-
- 39 edits in trunk/WebCore
Reviewed by Sam.
- Removed old debugging aids, Node::dump, RenderObject::dump, and RenderObject::information, that used DeprecatedString.
- dom/CharacterData.cpp: Removed override of Node::dump.
- dom/CharacterData.h: Ditto.
- dom/Element.cpp: Ditto.
- dom/Element.h: Ditto.
- dom/EventTargetNode.cpp: Ditto.
- dom/EventTargetNode.h: Ditto.
- dom/Node.cpp: Removed Node::dump.
- dom/Node.h: Ditto.
- rendering/RenderBlock.cpp: Removed override of RenderObject::dump.
- rendering/RenderBlock.h: Ditto.
- rendering/RenderFrameSet.cpp: Ditto.
- rendering/RenderFrameSet.h: Ditto.
- rendering/RenderObject.cpp: Removed RenderObject::dump and RenderObject::information.
- rendering/RenderObject.h: Ditto.
- rendering/RenderTable.cpp: Removed override of RenderObject::dump.
- rendering/RenderTable.h: Ditto.
- rendering/RenderTableCell.cpp: Ditto.
- rendering/RenderTableCell.h: Ditto.
- rendering/RenderTableCol.cpp: Ditto.
- rendering/RenderTableCol.h: Ditto.
- rendering/RenderTableSection.cpp: Ditto.
- rendering/RenderTableSection.h: Ditto.
- rendering/RenderTreeAsText.h: Removed unneeded include of TextStream.h and added forward declarations as appropriate.
- svg/SVGSVGElement.cpp: Removed unneeded include of TextStream.h.
- svg/graphics/SVGResourceClipper.cpp: And here.
- svg/graphics/SVGResourceFilter.cpp: Ditto.
- svg/graphics/filters/SVGFEBlend.cpp: Ditto.
- svg/graphics/filters/SVGFEComponentTransfer.cpp: Ditto.
- svg/graphics/filters/SVGFEComposite.cpp: Ditto.
- svg/graphics/filters/SVGFEDiffuseLighting.cpp: Ditto.
- svg/graphics/filters/SVGFEGaussianBlur.cpp: Ditto.
- svg/graphics/filters/SVGFEImage.cpp: Ditto.
- svg/graphics/filters/SVGFEMerge.cpp: Ditto.
- svg/graphics/filters/SVGFEMorphology.cpp: Ditto.
- svg/graphics/filters/SVGFEOffset.cpp: Ditto.
- svg/graphics/filters/SVGFESpecularLighting.cpp: Ditto.
- svg/graphics/filters/SVGFETurbulence.cpp: Ditto.
- svg/graphics/filters/SVGFilterEffect.cpp: Ditto.
- 3:26 PM Changeset in webkit [30414] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Sam.
Fix for <rdar://problem/5729674> Seed: Crash in
RenderButton::setStyle at http://www.dinorpg.com
Inputs should not honor first-letter.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
LayoutTests:
Reviewed by Sam.
Test for <rdar://problem/5729674> Seed: Crash in
RenderButton::setStyle at http://www.dinorpg.com
- fast/forms/input-first-letter.html: Added.
- platform/mac/fast/forms/input-first-letter-expected.checksum: Added.
- platform/mac/fast/forms/input-first-letter-expected.png: Added.
- platform/mac/fast/forms/input-first-letter-expected.txt: Added.
- 3:23 PM BuildingCairoOnWindows edited by
- (diff)
- 2:09 PM Changeset in webkit [30413] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Darin.
Change OpaqueJSClass and RootObject to start with a ref count of 1.
- API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): (OpaqueJSClass::createNoAutomaticPrototype): (OpaqueJSClass::create):
- API/JSClassRef.h:
- API/JSObjectRef.cpp: (JSClassCreate):
- bindings/runtime_root.cpp: (KJS::Bindings::RootObject::create): (KJS::Bindings::RootObject::RootObject):
- 1:13 PM Changeset in webkit [30412] by
-
- 11 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/5637569> CrashTracer: [REGRESSION] 620 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::setStaticY + 15
Test: fast/text/wbr-styled.html
Changed RenderWordBreak to inherit from RenderText instead of
RenderInline.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
- rendering/RenderFlow.h:
- rendering/RenderText.cpp: (WebCore::RenderText::renderName): (WebCore::RenderText::isTextFragment): (WebCore::RenderText::isWordBreak):
- rendering/RenderText.h:
- rendering/RenderWordBreak.cpp: (WebCore::RenderWordBreak::RenderWordBreak):
- rendering/RenderWordBreak.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/5637569> CrashTracer: [REGRESSION] 620 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::setStaticY + 15
- fast/text/wbr-styled.html: Added.
- platform/mac-leopard/fast/text/wbr-styled-expected.checksum: Added.
- platform/mac-leopard/fast/text/wbr-styled-expected.png: Added.
- platform/mac/fast/css-generated-content/wbr-with-before-content-expected.txt:
- platform/mac/fast/text/wbr-pre-expected.txt:
- platform/mac/fast/text/wbr-styled-expected.txt: Added.
- 11:42 AM Changeset in webkit [30411] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog
- 11:42 AM Changeset in webkit [30410] by
-
- 10 edits in trunk
WebCore:
Reviewed by Darin.
WARNING: NO TEST CASES ADDED OR CHANGED
- ChangeLog:
- WebCore.base.exp:
- loader/mac/LoaderNSURLExtras.h:
- loader/mac/LoaderNSURLExtras.m: Move unused functions to WebKit (where they are used)
(vectorContainsString):
Use const references.
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm: Remove wkNSURLProtocolClassForReqest.
WebKit/mac:
Reviewed by Darin.
Move back WebKit methods that were unused in WebCore.
- Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:]): (+[NSURL _web_URLWithData:relativeToURL:]): (-[NSURL _web_originalData]): (-[NSURL _web_originalDataAsString]): (-[NSURL _web_isEmpty]): (-[NSURL _webkit_canonicalize]): (-[NSURL _webkit_URLByRemovingComponent:]): (-[NSURL _webkit_URLByRemovingFragment]): (-[NSURL _webkit_URLByRemovingResourceSpecifier]): (-[NSURL _webkit_isFileURL]): (-[NSString _webkit_isFileURL]):
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setTitle):
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
- 11:28 AM Changeset in webkit [30409] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore
These changes bring deleting performance back to old levels on the phone
except for deleting the first space to the right of a word, which we are
still working on.
- dom/Position.cpp: (WebCore::Position::upstream): Avoid the use of enclosingBlock when determining if we have left the original enclosing block or entered a new one, and avoid rootEditableElement for determining if we have changed editability. These operations are expensive. (WebCore::Position::downstream): Ditto.
- 11:16 AM Changeset in webkit [30408] by
-
- 6 edits in trunk
Rubber stamped by Anders.
- removed explicit initialization to 1 for RefCounted; that's now the default
- kjs/regexp.cpp: (KJS::RegExp::RegExp): Removed RefCounted initializer.
WebCore:
Rubber stamped by Anders.
- removed explicit initialization to 1 for RefCounted; that's now the default
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): Removed RefCounted initializer.
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): Ditto.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Ditto.
- 11:08 AM Changeset in webkit [30407] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Geoff
Fixed a bug in DRT --threaded mode
- DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: (startJavaScriptThreads): Don't detach the newly created thread. The later call to stopJavaScriptThreads() tries to pthread_join() each thread that had been created, but you can't join a detached thread!
- 11:06 AM Changeset in webkit [30406] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Anders.
- next step for http://bugs.webkit.org/show_bug.cgi?id=17257 start ref counts at 1 instead of 0 for speed
- wtf/RefCounted.h: (WTF::RefCounted::RefCounted): Have refcounts default to 1. This allows us to start removing the explicit initialization of RefCounted from classes and eventually we can remove the ability to have the initial count of 0 entirely.
- 10:25 AM Changeset in webkit [30405] by
-
- 6 edits in trunk/WebCore
Reviewed by Darin.
Make ResourceLoader and ResourceHandle start out with a refcount of 1.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::create):
- loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::create):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader):
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
- 5:05 AM Changeset in webkit [30404] by
-
- 4 edits in trunk/WebCore
2008-02-19 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=16863
[GTK] tab focusing doesn't work
GDK_MOD2_MASK doesn't always mean meta so we can't use it to identify
the meta key state.
Use GDK_META_MASK where available, otherwise do not support the meta
key. This matches the behaviour of other applications.
Also add a comment noting that the platform event constructors need to
be kept in sync (it's not obvious that there are multiple places that
check the key state).
- platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- platform/gtk/MouseEventGtk.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
Feb 18, 2008:
- 11:17 PM Changeset in webkit [30403] by
-
- 1 edit in trunk/WebCore/ChangeLog
Reviewed by Sam Weinig's white rhino tusk stamp
SQLiteTransaction::stop() should also reset the transaction-in-progress flag in its parent SQLiteDatabase
- platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::stop):
- 11:15 PM Changeset in webkit [30402] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig's rubberstamp
SQLiteTransaction::stop() should also reset the transaction-in-progress flag in its parent SQLiteDatabase
- platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::stop):
- 11:04 PM Changeset in webkit [30401] by
-
- 3 edits in branches/Safari-3-1-branch/LayoutTests
Merge r30399.
- 11:03 PM Changeset in webkit [30400] by
-
- 2 edits in trunk/WebKit/win
Make Drosera work on Vista.
Runtime type library registration on Vista requires use of two new call:
RegisterTypeLibraryForUser and UnRegisterTypeLibraryForUser, which write to
HKCU. LoadTypeLib[Ex] registers under HKLM, which fails under vista due to UAC.
Reviewed by Adam.
- WebKitDLL.cpp: (DllUnregisterServer): Call UnRegisterTypeLibraryForUser if available. Fix version number. (DllRegisterServer): Call RegisterTypeLibraryForUser if available.
- 10:24 PM Changeset in webkit [30399] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Adam Roben in California.
- remove unnecessary and erroneous layoutTestController calls from a test
- fast/css/font-face-multiple-remote-sources.html:
- platform/mac/fast/css/font-face-multiple-remote-sources-expected.txt:
- 9:42 PM Changeset in webkit [30398] by
-
- 5 edits2 adds in branches/Safari-3-1-branch
Merge r30395.
- 9:41 PM Changeset in webkit [30397] by
-
- 4 edits4 adds in branches/Safari-3-1-branch
Merge r30392.
- 9:40 PM Changeset in webkit [30396] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30389.
- 9:19 PM Changeset in webkit [30395] by
-
- 6 edits2 adds in trunk
WebCore:
Reviewed by Darin
Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
Test: platform/mac/plugins/webScriptObject-exception-deadlock.html
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject valueForKey:]): The line
resultObj = [super valueForKey:key]; // defaults to throwing an exceptionsays it all - it throws an exception. This method also happens to hold the JSLock. Problematically, when the exeception is thrown and the method exited, the JSLock is never released. Fix that without otherwise changing behavior by holding the JSLock in two individual scopes - Right before the exception and right after.
WebKitTools:
Changes by Geoff Garen, Reviewed by Darin
Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
DRT changes for test: platform/mac/plugins/webScriptObject-exception-deadlock.html
[WebScriptObject valueForKey:] might throw an exception, and previously might have "leaked" the global JSLock
This test calls valueForKey, then runs some arbitrary Javascript on a 2ndary thread. If the lock has leaked,
this series of method calls will deadlock. If things are good, it will complete successfully.
- DumpRenderTree/mac/ObjCController.m: (runJavaScriptThread): (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController testValueForKey]):
LayoutTests:
Reviewed by Darin
Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
- platform/mac-tiger/Skipped: Removed 2 hanging tests that now don't hang
- platform/mac/plugins/webScriptObject-exception-deadlock-expected.txt: Added.
- platform/mac/plugins/webScriptObject-exception-deadlock.html: Added.
- 8:07 PM Changeset in webkit [30394] by
-
- 4 edits in trunk
Remove FindSafari's Release configuration.
- 6:21 PM Changeset in webkit [30393] by
-
- 20 edits in trunk
WebCore:
Reviewed by Sam.
- reduce use of DeprecatedString and memory allocations in processing of CSS
- remove unnecessary double -> float -> double trip in the CSS parser
- cleaned up names and structure in CSS grammar
- css/CSSGrammar.y: Remove getPropertyID and getValueID. Both are now in CSSParser.cpp instead, and they now work on ParseString and String objects and don't require the caller to put the string into a char*. Gave members of the %union more sensible names, removed duplicates, and sorted into a logical order. Put the %expect back in, rather than leaving it commented out.
- css/CSSParser.cpp: (WebCore::equalIgnoringCase): Added. (WebCore::hasPrefix): Added. (WebCore::CSSParser::parseTransitionProperty): Changed to call the new cssPropertyID, which obviates the need to call lower() and utf8() or to allocate memory at all. Also used equalIgnoringCase rather than putting the value into a String just to compare it. (WebCore::CSSParser::lex): Replaced convertASCIIToFloat with charactersToDouble. This change along with the CSSGrammar.y change, removes the double -> float -> double round trip, and affects the result of one layout test. (WebCore::cssPropertyID): Added. Gets the property ID from the gperf hash table, but without allocating any memory. (WebCore::cssValueKeywordID): Ditto.
- css/CSSParser.h: Removed declaration for deprecatedString function (now used only in CSSParser.cpp; soon to be deleted). Added cssPropertyID and cssValueKeywordID functions.
- css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::getPropertyCSSValue): Call cssPropertyID instead of propertyID. (WebCore::CSSStyleDeclaration::getPropertyValue): Ditto. (WebCore::CSSStyleDeclaration::getPropertyPriority): Ditto. (WebCore::CSSStyleDeclaration::getPropertyShorthand): Ditto. (WebCore::CSSStyleDeclaration::isPropertyImplicit): Ditto. (WebCore::CSSStyleDeclaration::setProperty): Ditto. (WebCore::CSSStyleDeclaration::removeProperty): Ditto. (WebCore::CSSStyleDeclaration::isPropertyName): Ditto.
- css/CSSStyleDeclaration.h: Removed unnecessary includes, unnecessary Noncopyable boilerplate, and the getPropertyID function declaration along with its associated apology comment.
- css/makevalues.pl: Generate constants instead of macros for CSS value numbers (but not an enumeration, like properties, since you rarely have any reason to handle all values, but often have a reason to handle all properties). Renamed the constant for the number of CSS value keywords from CSS_VAL_TOTAL to numCSSValueKeywords, and added maxCSSValueKeywordLength.
- platform/text/String.cpp: (WebCore::charactersToDouble): Made this function more efficient by using a stack buffer rather than a CString.
LayoutTests:
Reviewed by Sam.
- generate new results for the one test that was altered by the double -> float -> double trip taken by numeric values in the CSS parser
This test appears under three different names in three different
parts of our test suite.
- platform/mac/css1/box_properties/acid_test-expected.checksum: Updated.
- platform/mac/css1/box_properties/acid_test-expected.png: Ditto.
- platform/mac/css1/box_properties/acid_test-expected.txt: Ditto.
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.checksum: Ditto.
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.png: Ditto.
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt: Ditto.
- platform/mac/fast/block/basic/011-expected.checksum: Ditto.
- platform/mac/fast/block/basic/011-expected.png: Ditto.
- platform/mac/fast/block/basic/011-expected.txt: Ditto.
- 6:13 PM Changeset in webkit [30392] by
-
- 4 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/5736225> crash in svgFontAndFaceElementForFontData on digitalstrom.org/cms
Test: fast/css/font-face-multiple-remote-sources.html
- css/CSSFontFace.cpp: (WebCore::CSSFontFace::fontLoaded):
- css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::fontLoaded):
LayoutTests:
- test for <rdar://problem/5736225> crash in svgFontAndFaceElementForFontData on digitalstrom.org/cms
- fast/css/font-face-multiple-remote-sources.html: Added.
- platform/mac/fast/css/font-face-multiple-remote-sources-expected.checksum: Added.
- platform/mac/fast/css/font-face-multiple-remote-sources-expected.png: Added.
- platform/mac/fast/css/font-face-multiple-remote-sources-expected.txt: Added.
- 5:12 PM Changeset in webkit [30391] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::hasCSSPropertyNamePrefix): Added. (WebCore::cssPropertyName): Reimplement to not use DeprecatedString. Also made faster by using a Vector<UChar> and eliminating all the string operations.
- 4:54 PM Changeset in webkit [30390] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Sam.
- Misc/WebNSAttributedStringExtras.mm: (+[NSAttributedString _web_attributedStringFromRange:]): Eliminate use of DeprecatedString.
- 4:48 PM Changeset in webkit [30389] by
-
- 2 edits in trunk/WebCore
2008-02-18 Stephanie Lewis <Stephanie Lewis>
Reviewed by Adam.
Remove workaround for <rdar://problem/5695848>.
- platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):
- 4:48 PM Changeset in webkit [30388] by
-
- 2 edits in trunk/WebKit/qt
Reviewed by Sam.
- Api/qwebnetworkinterface.cpp: (QWebNetworkRequestPrivate::init): Removed use of DeprecatedString.
- 4:25 PM Changeset in webkit [30387] by
-
- 6 edits in trunk
Reviewed by Geoff Garen.
Fix for http://bugs.webkit.org/show_bug.cgi?id=17419
Remove CompatMode from JavaScriptCore as it is never set to anything other than NativeMode
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init):
- kjs/JSGlobalObject.h: (KJS::JSGlobalObject::setDebugger):
- kjs/date_object.cpp: (KJS::dateProtoFuncGetYear):
WebCore:
Reviewed by Geoff Garen.
Fix for http://bugs.webkit.org/show_bug.cgi?id=17419
Remove CompatMode from JavaScriptCore as it is never set to anything other than NativeMode
- bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScript):
- 3:04 PM Changeset in webkit [30386] by
-
- 2 edits in trunk/WebCore
2008-02-18 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=17381
[CURL] Regression: data URL parsing broken after DeprecatedString removal (Acid2)
This patch resolves the regression for the GTK+ port.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl):
- 3:03 PM Changeset in webkit [30385] by
-
- 4 edits in trunk/WebKit/gtk
2008-02-18 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=17312
[GTK] Webview Transparent Background
Add support for WebView background transparency.
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp:
- webkit/webkitwebview.h:
- 3:03 PM Changeset in webkit [30384] by
-
- 3 edits in trunk/WebKit/gtk
2008-02-18 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Implement webkit_web_view_get_focused_frame()
Equivalent to selectedFrame in the Mac API.
- webkit/webkitwebview.cpp:
- webkit/webkitwebview.h:
- 1:43 PM Changeset in webkit [30383] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): Use String instead of DeprecatedString. (WebCore::ResourceHandle::start): Ditto.
- 1:42 PM Changeset in webkit [30382] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): Use String instead of DeprecatedString. (WebCore::cookies): Ditto.
- 1:40 PM Changeset in webkit [30381] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- removed use of DeprecatedString in the Color class
- platform/graphics/Color.cpp: (WebCore::Color::parseHexColor): Streamlined logic a bit with early returns. Used toASCIIHexValue a character at a time rather than using toIntStrict in base 16 mode. (WebCore::findNamedColor): Added. Uses a fixed-size char buffer to look up a color using the gperf-generated findColor function. Saves a memory allocation vs. the old version that called DeprecatedString::latin1(). (WebCore::Color::setNamedColor): Changed to use findNamedColor.
- 1:28 PM Changeset in webkit [30380] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Sam.
- wtf/ASCIICType.h: (WTF::toASCIIHexValue): Added.
- 1:20 PM Changeset in webkit [30379] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Changed to use String instead of DeprecatedString.
- 1:16 PM Changeset in webkit [30378] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer): Changed to use String instead of DeprecatedString.
- 12:13 PM Changeset in webkit [30377] by
-
- 7 edits3 deletes in trunk/WebCore
Reviewed and landed by Sam.
Remove DeprecatedStringList.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- editing/markup.cpp:
- platform/DeprecatedStringList.cpp: Removed.
- platform/DeprecatedStringList.h: Removed.
- platform/mac/DeprecatedStringListMac.mm: Removed.
- 11:55 AM Changeset in webkit [30376] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30370.
- 11:49 AM Changeset in webkit [30375] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- css/CSSPrimitiveValueMappings.h: Add default cases to all the switch statements. This will ease the way some day if we decide to use an enum instead of int; otherwise we'll have a ton of "unhandled enum value" warnings here.
- 11:21 AM Changeset in webkit [30374] by
-
- 2 edits in trunk/WebCore
2008-02-18 Alp Toker <alp@atoker.com>
Build fix for GTK+ < 2.10. Fall back to simple text clipboard copy
with older GTK+ versions for now.
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection):
- 10:59 AM Changeset in webkit [30373] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- WebCore.base.exp: Export a couple of WebCore::String functions we plan to use in the future in WebKit.
- 10:58 AM Changeset in webkit [30372] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- DerivedSources.make: Added the scripts to the ENABLE_SVG versions of the rules for CSSPropertyNames.h and CSSValueKeywords.h. Somehow that got left out, so the files would not be regenerated if the scripts were changed (but would if SVG was disabled).
- 10:41 AM Changeset in webkit [30371] by
-
- 2 edits in trunk/WebCore
Suggested by Darin.
- platform/KURL.h: (WebCore::KURL::operator const String&): Added, to avoid unexpected conversion via UString (as in bug 17418).
- 10:23 AM Changeset in webkit [30370] by
-
- 2 edits in trunk/WebCore
2008-02-18 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Darin.
<rdar://problem/5744899> Crash in Flash when clicking "Yes" to abort
slow script Flash 9 dialog at http://www.kidzui.com
When navigating to a new page, we stop all outstanding PluginStreams.
Flash hangs in the call to NPP_URLNotify. It eventually displays the
"slow script" dialog, which relinquishes control to the system. While
this dialog is running, the request we are in the process of cancelling
completes, and we re-enter Flash to deliver the data. When the dialog
is dismissed, the internal state of Flash has changed, and Flash
crashes with a null dereference.
To work around this, we can defer loading before entering plug-in code,
so that even if a plug-in yields to the system, we won't get callbacks
while we're handling a callback.
- plugins/PluginStream.cpp: (WebCore::PluginStream::startStream): Defers loads while calling into plug-in. (WebCore::PluginStream::destroyStream): Same. (WebCore::PluginStream::deliverData): Same. (WebCore::PluginStream::didFail): Protect 'this' from deletion by destroyStream. Null out m_loader only after destroyStream returns. (WebCore::PluginStream::didFinishLoading): Same.
- 10:14 AM Changeset in webkit [30369] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=17418
REGRESSION: Assertion failure dragging image (JSLock::lockCount() > 0)
- platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::declareAndWriteDragImage): Explicitly convert from KURL to String, as an implicit conversion uses UString and thus needs a JSLock.
- 7:14 AM QtWebKitTodo edited by
- (diff)
- 6:33 AM QtWebKitTodo edited by
- (diff)
- 4:15 AM QtWebKitTodo edited by
- (diff)
- 1:10 AM QtWebKitTodo edited by
- (diff)
Feb 17, 2008:
- 10:45 PM Changeset in webkit [30368] by
-
- 2 edits in trunk/WebCore
Roll out r30360.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation):
- 10:31 PM Changeset in webkit [30367] by
-
- 4 edits in branches/Safari-3-1-branch
Make JavaScriptCore and WebKit's FEATURE_DEFINES match WebCore.
- 10:25 PM Changeset in webkit [30366] by
-
- 2 edits in trunk/WebCore
Mac build fix.
- WebCore.xcodeproj/project.pbxproj:
- 9:47 PM Changeset in webkit [30365] by
-
- 1 edit in branches/Safari-3-1-branch/WebCore/ChangeLog
ChangeLog fix.
- 9:43 PM Changeset in webkit [30364] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Build fix.
- WebCore.vcproj/build-generated-files.sh:
- 6:32 PM Changeset in webkit [30363] by
-
- 3 edits in trunk/WebCore
2008-02-17 Alp Toker <alp@atoker.com>
Attempt to fix the Wx build (has been broken all weekend).
Stub out some graphics functions.
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath):
- platform/graphics/wx/PathWx.cpp: (WebCore::Path::isEmpty):
- 6:02 PM Changeset in webkit [30362] by
-
- 4 edits2 copies2 moves2 adds in trunk
2008-02-17 Julien Chaffraix <julien.chaffraix@gmail.com>
Reviewed by Alexey Proskuryakov.
http://bugs.webkit.org/show_bug.cgi?id=16989
bug 16989 : Add send() flag checks in XmlHttpRequest
- Splitted xmlhttprequest-abort-readystate in 2 test cases (xmlhttprequest-abort-readystate-shouldDispatchEvent and xmlhttprequest-abort-readystate-shouldNotDispatchEvent)
- Added test case for the 2 send() flag checks in XmlHttpRequest::send and XmlHttpRequest::setRequestHeader
- 4:22 PM Changeset in webkit [30361] by
-
- 11 edits in trunk
WebCore:
Reviewed by Dan Bernstein.
Fix for http://bugs.webkit.org/show_bug.cgi?id=17365
document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR
- Updated fast/events/event-instanceof.html to test document.createEvent("MessageEvent").
- DerivedSources.make: Generate Objective-C binding for DOMProgressEvent which was missing.
- WebCore.xcodeproj/project.pbxproj: Add missing DOMProgressEvent files to the project.
- bindings/js/JSEventCustom.cpp: (WebCore::toJS): Clean up and add case for SVGZoomEvent that was missing.
- bindings/objc/DOMEvents.mm: (+[DOMEvent _wrapEvent:WebCore::]): Clean up and add cases for ProgressEvent and MessageEvent that were missing.
- dom/Document.cpp: (WebCore::Document::createEvent): Add case for MessageEvent.
WebKit/mac:
Reviewed by Dan Bernstein.
Fix for http://bugs.webkit.org/show_bug.cgi?id=17365
document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR
- MigrateHeaders.make: Migrate DOMProgressEvent.h and DOMTextPrivate.h which were mistakenly not migrated.
LayoutTests:
Reviewed by Dan Bernstein.
Update test for http://bugs.webkit.org/show_bug.cgi?id=17365
document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR
- fast/events/event-instanceof-expected.txt:
- fast/events/resources/event-instanceof.js: Test MessageEvent as well.
- 4:14 PM Changeset in webkit [30360] by
-
- 2 edits in trunk/WebCore
2008-02-17 Adam Treat <treat@kde.org>
Reviewed by Eric Seidel.
http://bugs.webkit.org/show_bug.cgi?id=17008
Meta refresh does not work with cache turned off
Fix for issue noticed on http://adserver.vivox.com/2
- loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation):
- 3:53 PM Changeset in webkit [30359] by
-
- 2 edits in trunk/WebCore
2008-02-17 Alp Toker <alp@atoker.com>
Reviewed by Sam Weinig.
Fix for change made in r30355. Issue noticed by İsmail Dönmez.
Verify SSL certs by default, but allow checks to be disabled with an
environment variable (WEBKIT_IGNORE_SSL_ERRORS) for now.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):
- 12:21 PM Changeset in webkit [30358] by
-
- 2 edits in trunk/WebKit/win
http://bugs.webkit.org/show_bug.cgi?id=17397
<rdar://problem/5748245> REGRESSION (r30236-30336): Cannot backspace/enter in forms on Windows
- WebKit.vcproj/WebKit.vcproj: Add ENABLE_CROSS_DOCUMENT_MESSAGING definitions.
- 11:28 AM Changeset in webkit [30357] by
-
- 5 edits in trunk/LayoutTests
Reviewed by Mark Rowe.
- disable the non-ASCII parts of a test case for the ASCII code path because it is failing on the (Tiger) buildbots for an unrelated reason.
- fast/text/fixed-pitch-control-characters.html:
- platform/mac/fast/text/fixed-pitch-control-characters-expected.checksum:
- platform/mac/fast/text/fixed-pitch-control-characters-expected.png:
- platform/mac/fast/text/fixed-pitch-control-characters-expected.txt:
- 9:59 AM Changeset in webkit [30356] by
-
- 2 edits in trunk/JavaScriptCore
- wtf/ListHashSet.h: (WTF::swap): Removed stray return statement.
- 7:36 AM Changeset in webkit [30355] by
-
- 2 edits in trunk/WebCore
2008-02-17 Bin Chen <binary.chen@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=17404
Bug 17404: curl certification problem
Disable SSL cert verification until we have a way of distributing
certs and/or reporting SSL errors to the user.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):
- 7:09 AM Changeset in webkit [30354] by
-
- 2 edits in trunk/WebCore
2008-02-17 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
DevHelp fails to load local files; URL truncated by one character.
Fix a file:// URL regression introduced in KURL.cpp r30243.
- platform/KURL.cpp: (WebCore::KURL::KURL):
- 4:12 AM Changeset in webkit [30353] by
-
- 2 edits in trunk/WebKit/gtk
2008-02-17 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Mark Rowe.
Fix a crash introduced in changeset #29985 by moving the dereference to after
the null check.
- webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):
- 2:46 AM Changeset in webkit [30352] by
-
- 15 edits in branches/Safari-3-1-branch
Merge r30331.
- 2:45 AM Changeset in webkit [30351] by
-
- 5 edits in branches/Safari-3-1-branch
Merge r30330.
- 2:44 AM Changeset in webkit [30350] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30329.
- 2:43 AM Changeset in webkit [30349] by
-
- 7 edits in branches/Safari-3-1-branch
Merge r30328.
- 2:42 AM Changeset in webkit [30348] by
-
- 23 edits1 move2 adds in branches/Safari-3-1-branch
Merge r30326.
- 2:40 AM Changeset in webkit [30347] by
-
- 23 edits1 add in branches/Safari-3-1-branch/WebCore
Merge r30325.
- 2:39 AM Changeset in webkit [30346] by
-
- 8 edits1 copy5 adds in branches/Safari-3-1-branch
Merge r30323.
- 1:03 AM WebKit Team edited by
- Edited my entry to humor Sam (diff)
- 12:50 AM Changeset in webkit [30345] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=17033 <rdar://problem/5709315> REGRESSION: Really long <option> causes unnecessary page scroll bars to accommodate content
Test: fast/forms/control-clip-overflow.html
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): Account for control clipping. (WebCore::RenderFlow::rightmostPosition): Ditto. (WebCore::RenderFlow::leftmostPosition): Ditto.
LayoutTests:
Reviewed by Darin Adler.
- test for http://bugs.webkit.org/show_bug.cgi?id=17033 <rdar://problem/5709315> REGRESSION: Really long <option> causes unnecessary page scroll bars to accommodate content
- fast/forms/control-clip-overflow.html: Added.
- platform/mac/fast/forms/control-clip-overflow-expected.checksum: Added.
- platform/mac/fast/forms/control-clip-overflow-expected.png: Added.
- platform/mac/fast/forms/control-clip-overflow-expected.txt: Added.
Feb 16, 2008:
- 9:48 PM Changeset in webkit [30344] by
-
- 2 edits in trunk/WebCore
Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
Reviewed by Eric S
Use cross-platform code to determine the dirty rects for
fill and stroke operations
- 7:43 PM Changeset in webkit [30343] by
-
- 8 edits in trunk/WebCore
Reviewed by Darin Adler.
Take another step in the direction of getting rid of DeprecatedString
by moving all the to{NumericType} off of it.
- Create free functions that take a UChar* buffer and length to do the string-to-number conversions. This allows us to avoid two allocations if we don't already have a String and is consistent with the design we would like going forward.
- Since the toInt (and family) functions on DeprecatedString were slightly different than the ones on String (they didn't allow trailing garbage), an extra set of 'Strict' toInt functions were added that have this behavior.
- platform/graphics/Color.cpp: (WebCore::Color::parseHexColor):
- platform/text/PlatformString.h:
- platform/text/String.cpp: (WebCore::String::percentage): (WebCore::String::toIntStrict): (WebCore::String::toUIntStrict): (WebCore::String::toInt64Strict): (WebCore::String::toUInt64Strict): (WebCore::String::toUInt): (WebCore::String::toDouble): (WebCore::isCharacterAllowedInBase): (WebCore::toIntegralType): (WebCore::lengthOfCharactersAsInteger): (WebCore::charactersToIntStrict): (WebCore::charactersToUIntStrict): (WebCore::charactersToInt64Strict): (WebCore::charactersToUInt64Strict): (WebCore::charactersToInt): (WebCore::charactersToUInt): (WebCore::charactersToInt64): (WebCore::charactersToUInt64): (WebCore::charactersToDouble): (WebCore::charactersToFloat):
- platform/text/StringImpl.cpp: (WebCore::parseLength): (WebCore::StringImpl::toIntStrict): (WebCore::StringImpl::toUIntStrict): (WebCore::StringImpl::toInt64Strict): (WebCore::StringImpl::toUInt64Strict): (WebCore::StringImpl::toInt): (WebCore::StringImpl::toUInt): (WebCore::StringImpl::toInt64): (WebCore::StringImpl::toUInt64): (WebCore::StringImpl::toDouble): (WebCore::StringImpl::toFloat):
- platform/text/StringImpl.h:
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseClockValue):
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
- 7:08 PM Changeset in webkit [30342] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix fixed-pitch font measurement of control characters that render as zero-width space
Test: fast/text/fixed-pitch-control-characters.html
- rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache):
LayoutTests:
Reviewed by Sam Weinig.
- test fixed-pitch font measurement of control characters that render as zero-width space
- fast/text/fixed-pitch-control-characters.html: Added.
- platform/mac/fast/text/fixed-pitch-control-characters-expected.checksum: Added.
- platform/mac/fast/text/fixed-pitch-control-characters-expected.png: Added.
- platform/mac/fast/text/fixed-pitch-control-characters-expected.txt: Added.
- 2:04 PM Changeset in webkit [30341] by
-
- 2 edits in trunk/WebCore
wx build fix.
- 1:06 PM WebKit Team edited by
- Add areas of knowledge for Sam Weinig (diff)
- 1:02 PM WebKit Team edited by
- Remove Tristan as he is no longer at Apple (diff)
- 9:41 AM Changeset in webkit [30340] by
-
- 1 edit3 moves in trunk/LayoutTests
- disable some failing tests; someone can re-enable after fixing the problems causing them to fail or generating new expected results
- fast/frames/iframe-scroll-page-up-down.html: Removed.
- fast/frames/iframe-scroll-page-up-down.html-disabled: Copied from fast/frames/iframe-scroll-page-up-down.html.
- svg/batik/text/textBiDi.svg: Removed.
- svg/batik/text/textBiDi.svg-disabled: Copied from svg/batik/text/textBiDi.svg.
- svg/custom/use-on-symbol-inside-pattern.svg: Removed.
- svg/custom/use-on-symbol-inside-pattern.svg-disabled: Copied from svg/custom/use-on-symbol-inside-pattern.svg.
- 9:35 AM Changeset in webkit [30339] by
-
- 1 edit in trunk/WebCore/ChangeLog
Clean up some old log entries.
- 3:09 AM Changeset in webkit [30338] by
-
- 2 edits in trunk/WebCore
2008-02-16 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp Toker.
Cross document messaging GTK+/autotools build fix.
- GNUmakefile.am:
Feb 15, 2008:
- 10:44 PM Changeset in webkit [30337] by
-
- 3 edits in trunk/WebCore
Build fix for Qt and Cairo builds
- 10:00 PM Changeset in webkit [30336] by
-
- 8 edits in trunk/WebCore
Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
Refactor CanvasRenderingContext2D::drawImage(HTMLCanvasElement) to remove evil ifdefs
Reviewed by Dan B.
Add logic draw(ImageBuffer*) method to GraphicsContext to handle
painting the source canvas content.
- 9:57 PM Changeset in webkit [30335] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Oliver Hunt.
- skip a test for a Leopard-only NSHTTPURLResponse bug workaround
- platform/mac-tiger/Skipped:
- 7:23 PM Changeset in webkit [30334] by
-
- 2 edits in trunk/WebCore
Using GetNativeFontInfoDesc() to generate the hash value was leading to duplicate entries in the HashMap. Use the font object's pointer instead.
- 6:51 PM Changeset in webkit [30333] by
-
- 2 edits in trunk/WebCore
When parsing url we get from a CFURLRef, we need to null terminate
the string for the case when url ends with a '/'.
Reviewed by Darin.
- platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL):
- 6:02 PM Changeset in webkit [30332] by
-
- 2 edits in trunk/LayoutTests
Added 2 skipped tests
- platform/mac-tiger/Skipped:
- 4:51 PM Changeset in webkit [30331] by
-
- 15 edits in trunk
WebCore:
Reviewed by Darin
Fix for <rdar://problem/5727175> and <rdar://problem/5740495> - Database threads and callback scripts can run after
a page has closed or loaded a new document
Deciding to make the Database I/O semantic the same as loaders/XHR when a document is shut down, this patch implements
a policy of shutting down the databases in a document at the same time. This includes removing all pending transactions
in a database, cutting off an queued statements in the current transaction, and preventing further callbacks from being
made.
No new layout tests with this patch as the current layout tests were catching this issue in a plethora of ways already
(crashing, unexpected exceptions and output, etc)
- dom/Document.cpp: (WebCore::Document::~Document): Don't actually stop the database thread here - it better have been stopped already. Add an assertion to that effect. (WebCore::Document::addOpenDatabase): Add a new database handle to this Document's open database set (WebCore::Document::removeOpenDatabase): Remove such a handle (WebCore::Document:: stopDatabases): Call "close" on all open Database handles for this document
- dom/Document.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): In addition to canceling all resource loads and XHRs, stop all database I/O
- platform/MessageQueue.h: (WebCore::MessageQueue::killed):
- platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::stop): Added. Explicit stop to cut off a transaction so it won't try anymore SQL activity
- platform/sql/SQLiteTransaction.h:
- storage/Database.cpp: (WebCore::Database::Database): (WebCore::Database::~Database): (WebCore::Database::markAsDeletedAndClose): Check if the thread has terminated before committing to waiting on the thread. (WebCore::Database::stop): Stop this database, including all queued transactions and callbacks
- storage/Database.h: (WebCore::Database::stopped):
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::terminationRequested):
- storage/DatabaseThread.h:
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL): Throw an exception if a new executeSQL comes in after a database is closed (WebCore::SQLTransaction::checkAndHandleClosedDatabase): Added. Clears queued statements and clear the next step when the database has been closed since the last step/callback was run. Also stops the current SQLite transaction, if any (WebCore::SQLTransaction::performNextStep): (WebCore::SQLTransaction::performPendingCallback):
- storage/SQLTransaction.h:
LayoutTests:
Reviewed by Darin
Fix for <rdar://problem/5727175> and <rdar://problem/5740495> - Database threads and callback scripts can run after
a page has closed or loaded a new document
- storage/close-during-stress-test-expected.txt: Update results - this test contained output from a javascript callback that never should have taken place
- 4:44 PM Changeset in webkit [30330] by
-
- 5 edits in trunk
WebCore:
Reviewed by Darin.
Fix for <rdar://problem/5745072> REGRESSION (r29348): Shift + Tab does not change indent level on Google Docs
The immediate cause of this bug was that we stopped sending keypress events for the tab key when it is used to advance focus.
We had a special case for forward-tab in designMode, where the default behavior was to insert a tab key (or respect the keypress handler behavior).
This change makes the shift-tab behavior match the forward-tab behavior.
If the site had put their event handler (which does the indenting) on the keydown event, then this problem would have been avoided.
This is something we should look into and maybe advise the site on in the future. However, it's a low-risk change to just make tab and shift-tab uniform
in this respect, so I think this is the way to go for right now.
- page/EventHandler.cpp: (WebCore::EventHandler::defaultTabEventHandler):
LayoutTests:
Reviewed by Darin.
Updated test for <rdar://problem/5745072> REGRESSION (r29348): Shift + Tab does not change indent level on Google Docs
- editing/inserting/typing-tab-designmode-expected.txt:
- editing/inserting/typing-tab-designmode.html:
- 3:47 PM Changeset in webkit [30329] by
-
- 2 edits in trunk/WebCore
Reviewed by Alice.
<rdar://problem/5738678>
REGRESSION: "Loading" status remains when uploading file to .Mac iDisk via Safari
Use the new CFNetwork functions for setting body parts.
- platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody): (WebCore::httpBodyFromRequest):
- 3:39 PM Changeset in webkit [30328] by
-
- 7 edits in trunk
WebCore:
Reviewed by Anders Carlsson.
Fixed <rdar://problem/5725429> REGRESSION (r27898): Greenfield online
surveys no longer work due to XMLHttpRequest exceptions
Reverted some exception throwing code from r12194.
To comply with the W3C draft spec, we used to throw an exception when
trying to access responseText and responseXML at the wrong time, but
that turned out to be a compatibility problem.
Now, matching Firefox and previous versions of WebKit, we never throw
an exception when accessing responseText or responseXML.
See http://www.mail-archive.com/public-webapi@w3.org/msg02756.html.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): (WebCore::XMLHttpRequest::getResponseXML):
LayoutTests:
Reviewed by Anders Carlsson.
Fixed <rdar://problem/5725429> REGRESSION (r27898): Greenfield online
surveys no longer work due to XMLHttpRequest exceptions
Updated layout tests to expect an exception not to be thrown.
- http/tests/xmlhttprequest/xmlhttprequest-responseText-exception.html:
- http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception.html:
- http/tests/xmlhttprequest/zero-length-response-expected.txt:
- http/tests/xmlhttprequest/zero-length-response-sync-expected.txt:
- 3:27 PM Changeset in webkit [30327] by
-
- 1 edit in trunk/WebCore/ChangeLog
minor correction to my last Changlog entry.
- 3:25 PM Changeset in webkit [30326] by
-
- 23 edits3 adds1 delete in trunk
WebCore:
Reviewed by Dan Bernstein.
<rdar://problem/5738768> REGRESSION (r30062): Crash in InlineTextBox::isLineBreak() when Undoing a replace
Rolled out <http://trac.webkit.org/projects/webkit/changeset/29667>
- editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved):
LayoutTests:
Reviewed by Dan Bernstein.
<rdar://problem/5738768> REGRESSION (r30062): Crash in InlineTextBox::isLineBreak() when Undoing a replace
Disabled:
- editing/selection/inconsistent-in-removeChildNode.html: Removed.
- editing/selection/inconsistent-in-removeChildNode.html-disabled: Added.
Demonstrates fix:
- editing/undo/5738768-expected.txt: Added.
- editing/undo/5738768.html: Added.
During a shouldChangeSelection call, the old selection is no longer null because
nodeWillBeRemoved doesn't blow it away:
- platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
- platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
- platform/mac/editing/style/remove-underline-in-bold-expected.txt:
During a shouldChangeSelection call, the old selection is now null because
nodeWillBeRemoved blows it away:
- platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
More instances of <rdar://problem/5729315>, where, during a shouldChangeSelection
call content that held the old selection is still around but it wouldn't make sense
to leave the selection there, so we shouldn't call shouldChangeSelection at all:
- platform/mac/editing/style/remove-underline-expected.txt:
- platform/mac/editing/style/unbold-in-bold-expected.txt:
Similar changes, but ones where I've also updated pixel results for old, unrelated fixes:
- platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt:
- platform/mac/editing/deleting/delete-leading-ws-001-expected.checksum:
- platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
- platform/mac/editing/deleting/delete-line-011-expected.checksum:
- platform/mac/editing/deleting/delete-line-011-expected.txt:
- platform/mac/editing/execCommand/paste-1-expected.checksum:
- platform/mac/editing/execCommand/paste-1-expected.txt:
- platform/mac/editing/execCommand/paste-2-expected.checksum:
- platform/mac/editing/execCommand/paste-2-expected.txt:
- platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.checksum:
- platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
- platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
- platform/mac/editing/pasteboard/paste-text-012-expected.checksum:
- platform/mac/editing/selection/4960116-expected.checksum:
- 3:18 PM Changeset in webkit [30325] by
-
- 23 edits1 add in trunk/WebCore
Reviewed by Darin.
Fixed <rdar://problem/5741440> REGRESSION (r28496): After deactivating JavaScript, scripts embedded in the HTML page continue to run
Before this patch, Frame::scriptProxy() would only return null in the case that javascript was
disabled and if the script proxy field wasn't set (which would only be the case if the window
hasn't loaded anything yet). Not all callers of scriptProxy() always check for a non-null return
value. Those that did check would effectively be checking if javascript was enabled before proceeding.
This fix consists of 2 elements: first, make sure that scriptProxy() will never return null, regardless
of whether javascript is disabled. This will mean that callers who don't check for null won't crash.
Second, callers who did check for null now instead check for javascript being disabled. This means that
code paths intended for preventing javascript from being run will be making the correct check. Another
minor addition to this patch is that I added a function on Frame to be a shortcut for checking if javascript
is enabled.
- bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
- bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent):
- bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSLazyEventListener::parseCode):
- bindings/js/kjs_html.cpp: (WebCore::runtimeObjectImplementsCall):
- bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::isEnabled):
- bindings/js/kjs_proxy.h:
- bindings/js/kjs_window.cpp: (KJS::Window::retrieveWindow): (KJS::Window::retrieve):
- dom/Document.cpp: (WebCore::Document::createHTMLEventListener):
- dom/EventTarget.cpp: (WebCore::EventTarget::dispatchGenericEvent):
- html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::createNPObject):
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::evaluateScript):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::processToken):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::executeScript): (WebCore::FrameLoader::userGestureHint): (WebCore::FrameLoader::open): (WebCore::FrameLoader::dispatchWindowObjectAvailable): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
- manual-tests/disable-javascript-reload.html: Added.
- page/Frame.cpp: (WebCore::Frame::scriptProxy): (WebCore::Frame::bindingRootObject): (WebCore::Frame::windowScriptNPObject):
- page/Frame.h:
- page/InspectorController.cpp: (WebCore::canPassNodeToJavaScript):
- page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject):
- svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::createSVGEventListener):
- 2:30 PM Changeset in webkit [30324] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30285.
- 1:30 PM Changeset in webkit [30323] by
-
- 8 edits6 adds in trunk
WebCore:
Reviewed by Alexey Proskuryakov.
- WebCore part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360 <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html
Test: http/tests/loading/text-content-type-with-binary-extension.html
Refined the workaround for <rdar://problem/5321972> to exclude files
with extensions that are known to be associated with binary MIME types.
- WebCore.xcodeproj/project.pbxproj: Added WebCoreURLResponse.{h,mm}.
- platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Moved the workaround logic into WebCoreURLResponse.
- platform/network/mac/WebCoreURLResponse.h: Added.
- platform/network/mac/WebCoreURLResponse.mm: Added. (createBinaryExtensionsSet): Returns a set of extensions known to belong to MIME types of binary data. (-[NSURLResponse _webcore_MIMEType]): (-[NSHTTPURLResponse _webcore_MIMEType]): Forces the MIME type from application/octet-stream to text/plain if that is the specified Content-Type, unless the extension is in the binary extensions set.
WebKit/mac:
Reviewed by Alexey Proskuryakov.
- WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360 <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html
- WebView/WebDataSource.mm: (+[WebDataSource _representationClassForMIMEType:]): (-[WebDataSource _responseMIMEType]): (-[WebDataSource subresources]): (-[WebDataSource subresourceForURL:]):
- WebView/WebResource.mm: (-[WebResource _initWithData:URL:response:]):
- WebView/WebResourcePrivate.h:
LayoutTests:
Reviewed by Alexey Proskuryakov.
- test for http://bugs.webkit.org/show_bug.cgi?id=17360 <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html
- http/tests/loading/resources/.htaccess: Added.
- http/tests/loading/resources/binaryData.m4a: Added.
- http/tests/loading/text-content-type-with-binary-extension-expected.txt: Added.
- http/tests/loading/text-content-type-with-binary-extension.html: Added.
- 1:28 PM Changeset in webkit [30322] by
-
- 6 edits in branches/Safari-3-1-branch
Merge r30276.
- 1:27 PM Changeset in webkit [30321] by
-
- 17 edits in branches/Safari-3-1-branch
Merge r30269.
- 1:26 PM Changeset in webkit [30320] by
-
- 1 edit1 add in trunk/LayoutTests
Reviewed and rubber-stamped by Oliver Hunt.
Add leopard specific results for stroke-width-click.svg to work around
a CG regression.
- platform/mac-leopard/svg/custom/stroke-width-click-expected.txt: Added.
- 1:08 PM Changeset in webkit [30319] by
-
- 3 edits1 add in trunk/WebCore
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=17306 <rdar://problem/5737923> Transitions between styles that have different transition-* properties behave inconsistently
- manual-tests/transitions.html: Added.
- page/AnimationController.cpp: (WebCore::CompositeImplicitAnimation::animate): Changed to use the transition properties of the current style rather than the target style. (WebCore::AnimationControllerPrivate::get): Changed to not create an animation if the style does not have transitions. (WebCore::AnimationController::updateImplicitAnimations): Added code to return the target style if the current style is not animating.
- rendering/RenderObject.cpp: (WebCore::RenderObject::setAnimatableStyle): Changed to call updateImplicitAnimations() even if the current style does not have transitions, because we may be animating out of a style that had them.
- 12:44 PM Changeset in webkit [30318] by
-
- 2 edits in branches/Safari-3-1-branch/WebKitTools
Merge r30242.
- 12:44 PM Changeset in webkit [30317] by
-
- 3 edits in branches/Safari-3-1-branch/LayoutTests
Merge r30241.
- 12:43 PM Changeset in webkit [30316] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30240.
- 12:43 PM Changeset in webkit [30315] by
-
- 6 edits in branches/Safari-3-1-branch
Merge r30239.
- 12:42 PM Changeset in webkit [30314] by
-
- 14 edits2 adds in branches/Safari-3-1-branch
Merge r30238.
- 12:41 PM Changeset in webkit [30313] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30237.
- 12:41 PM Changeset in webkit [30312] by
-
- 3 edits3 adds in branches/Safari-3-1-branch
Merge r30235.
- 12:40 PM Changeset in webkit [30311] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30233.
- 12:40 PM Changeset in webkit [30310] by
-
- 10 edits in branches/Safari-3-1-branch
Merge r30222.
- 12:39 PM Changeset in webkit [30309] by
-
- 3 edits in branches/Safari-3-1-branch/WebCore
Merge r30218.
- 12:38 PM Changeset in webkit [30308] by
-
- 3 edits2 adds in branches/Safari-3-1-branch
Merge r30213.
- 12:37 PM Changeset in webkit [30307] by
-
- 2 edits in branches/Safari-3-1-branch/WebKit/win
Merge r30206.
- 12:06 PM Changeset in webkit [30306] by
-
- 1 edit1 delete in trunk/WebCore
Rubber-stamped by Darin.
Remove an obsolete WebCore readme file.
- README: Removed.
- 11:46 AM Changeset in webkit [30305] by
-
- 7 edits4 adds in branches/Safari-3-1-branch
Merge r30195.
- 11:45 AM Changeset in webkit [30304] by
-
- 3 edits3 adds in branches/Safari-3-1-branch
Merge r30191.
- 11:45 AM Changeset in webkit [30303] by
-
- 1 edit in branches/Safari-3-1-branch/WebCore/platform/sql/SQLiteDatabase.cpp
Merge r30190.
- 11:44 AM Changeset in webkit [30302] by
-
- 7 edits in branches/Safari-3-1-branch/WebCore
Merge r30189.
- 11:44 AM Changeset in webkit [30301] by
-
- 5 edits in branches/Safari-3-1-branch/WebCore
Merge r30184.
- 11:43 AM Changeset in webkit [30300] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30179.
- 11:43 AM Changeset in webkit [30299] by
-
- 2 edits in branches/Safari-3-1-branch/JavaScriptCore
Merge r30177.
- 11:42 AM Changeset in webkit [30298] by
-
- 2 edits2 adds in branches/Safari-3-1-branch/LayoutTests
Merge r30176.
- 11:42 AM Changeset in webkit [30297] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30174.
- 11:41 AM Changeset in webkit [30296] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30173.
- 11:41 AM Changeset in webkit [30295] by
-
- 13 edits3 adds in branches/Safari-3-1-branch/WebCore
Merge r30172.
- 11:40 AM Changeset in webkit [30294] by
-
- 3 edits3 adds in branches/Safari-3-1-branch
Merge r30171.
- 10:29 AM Changeset in webkit [30293] by
-
- 13 edits in trunk/WebCore
Reviewed by Darin Adler.
Remove more uses of DeprecatedString in preparation of getting rid of it.
- bridge/mac/WebCoreScriptDebugger.mm:
- css/CSSCursorImageValue.cpp: (WebCore::isSVGCursorIdentifier): (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
- css/CSSStyleSelector.h:
- dom/Element.cpp: (WebCore::Element::dump): (WebCore::Element::formatForDebugger):
- dom/Position.cpp: (WebCore::Position::debugPosition): (WebCore::Position::formatForDebugger):
- dom/Range.cpp: (WebCore::Range::formatForDebugger):
- dom/Text.cpp: (WebCore::Text::formatForDebugger):
- editing/Selection.cpp: (WebCore::Selection::debugPosition): (WebCore::Selection::formatForDebugger):
- editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::debugPosition):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::notifyFinished):
- svg/SVGFontFaceElement.cpp: (WebCore::mapAttributeToCSSProperty):
- 10:25 AM Changeset in webkit [30292] by
-
- 3 edits4 adds in branches/Safari-3-1-branch
Merge r30162.
- 10:25 AM Changeset in webkit [30291] by
-
- 2 edits in trunk
2008-02-15 Alp Toker <alp@atoker.com>
Reviewed by Holger.
GTK+ configure script cleanups
Categorize the configuration summary printout.
Bump GTK+ requirement to 2.8.
Rename 'webkit_target' to just 'target'.
Don't check for pthread on Win32.
- configure.ac:
- 10:24 AM Changeset in webkit [30290] by
-
- 4 edits in branches/Safari-3-1-branch/JavaScriptCore
Merge r30158.
- 10:24 AM Changeset in webkit [30289] by
-
- 21 edits2 copies15 adds2 deletes in branches/Safari-3-1-branch
Merge r30157.
- 10:22 AM Changeset in webkit [30288] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30154.
- 10:22 AM Changeset in webkit [30287] by
-
- 2 edits4 adds in branches/Safari-3-1-branch
Merge r30153.
- 10:18 AM Changeset in webkit [30286] by
-
- 3 edits in branches/Safari-3-1-branch/WebCore
Merge r30146.
- 10:04 AM Changeset in webkit [30285] by
-
- 2 edits in trunk/WebCore
- bindings/scripts/CodeGenerator.pm: Touch this to force bindings to regenerate.
- 9:58 AM Changeset in webkit [30284] by
-
- 2 edits in branches/Safari-3-1-branch/LayoutTests
Remove MessageEvent output from window-properties.html since that interface will be disabled as well
Reviewed by Sam.
- fast/dom/Window/window-properties-expected.txt:
- 9:56 AM Changeset in webkit [30283] by
-
- 2 edits in branches/Safari-3-1-branch/WebKit/mac
Merge r30120.
- 9:56 AM Changeset in webkit [30282] by
-
- 2 edits in branches/Safari-3-1-branch/WebKit/mac
Merge r30119.
- 9:55 AM Changeset in webkit [30281] by
-
- 3 edits4 adds in branches/Safari-3-1-branch
Merge r30116.
- 9:55 AM Changeset in webkit [30280] by
-
- 1 edit in branches/Safari-3-1-branch/WebCore/css/CSSStyleSelector.cpp
Merge r30115.
- 9:54 AM Changeset in webkit [30279] by
-
- 4 edits in branches/Safari-3-1-branch/WebCore/rendering
Merge r30114.
- 9:54 AM Changeset in webkit [30278] by
-
- 1 edit in branches/Safari-3-1-branch/WebCore/css/CSSStyleSelector.cpp
Merge r30113.
- 9:54 AM Changeset in webkit [30277] by
-
- 70 edits in branches/Safari-3-1-branch/WebCore
Merge r30112.
- 9:49 AM Changeset in webkit [30276] by
-
- 6 edits in trunk
Mac build fix
Make JavaScriptCore's FEATURE_DEFINES match WebCore's
Reviewed by Mark.
- Configurations/JavaScriptCore.xcconfig:
WebKit/mac:
Make WebKit's FEATURE_DEFINES match WebCore's
Reviewed by Mark.
- Configurations/WebKit.xcconfig:
WebKitTools:
Fix a typo that broke the Mac build
Reviewed by Mark.
- Scripts/build-webkit:
- 9:13 AM Changeset in webkit [30275] by
-
- 6 edits in branches/Safari-3-1-branch
Merge r30105.
- 9:12 AM Changeset in webkit [30274] by
-
- 8 edits in branches/Safari-3-1-branch/WebCore
Merge r30104.
- 9:12 AM Changeset in webkit [30273] by
-
- 3 edits2 adds in branches/Safari-3-1-branch
Merge r30101.
- 9:04 AM Changeset in webkit [30272] by
-
- 2 edits in trunk/WebCore
Try to fix Qt/GTK+ builds
- WebCore.pro: Remove MessageEvent.{idl,cpp} from the unconditional parts of this file.
- 8:51 AM Changeset in webkit [30271] by
-
- 4 edits in branches/Safari-3-1-branch/LayoutTests
Disable postMessage tests since postMessage is disabled
Reviewed by Mitz.
- fast/dom/Window/window-properties-expected.txt: Updated result.
- platform/mac/Skipped: Skip tests that depend on postMessage
- platform/win/Skipped: Ditto.
- 8:36 AM Changeset in webkit [30270] by
-
- 8 edits in trunk
Turn on cross-document messaging support by default
top level:
Turn on cross-document messaging support by default
Reviewed by Darin.
- configure.ac:
WebCore:
Turn on cross-document messaging support by default
Reviewed by Darin.
- Configurations/WebCore.xcconfig:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
WebKitTools:
Turn on cross-document messaging support by default
Reviewed by Darin.
- Scripts/build-webkit:
- 8:36 AM Changeset in webkit [30269] by
-
- 17 edits in trunk
Conditionalize cross-document messaging support
top level:
Conditionalize cross-document messaging support
The cross-document messaging parts of HTML 5 are in flux and we want
ports to be able to turn off the support as needed.
Note that the support is turned off by default right now. A subsequent
commit will turn it on by default.
Reviewed by Darin.
- configure.ac:
WebCore:
Conditionalize cross-document messaging support
The cross-document messaging parts of HTML 5 are in flux and we want
ports to be able to turn off the support as needed.
Note that the support is turned off by default right now. A subsequent
commit will turn it on by default.
Reviewed by Darin.
- GNUmakefile.am:
- WebCore.vcproj/build-generated-files.sh:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- dom/Event.cpp: (WebCore::Event::isMessageEvent):
- dom/Event.h:
- dom/MessageEvent.cpp:
- dom/MessageEvent.h:
- dom/MessageEvent.idl:
- page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage):
- page/DOMWindow.h:
- page/DOMWindow.idl:
WebKitTools:
Conditionalize cross-document messaging support
The cross-document messaging parts of HTML 5 are in flux and we want
ports to be able to turn off the support as needed.
Note that the support is turned off by default right now. A subsequent
commit will turn it on by default.
Reviewed by Darin.
- Scripts/build-webkit:
- 7:18 AM Changeset in webkit [30268] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Adam.
- quick fix for a problem causing an assertion on launch
- WebFrame.cpp: (WebFrame::loadData): Make an empty KURL even if the BSTR is null. Later we might want to rethink this.
- 3:41 AM Changeset in webkit [30267] by
-
- 3 edits in trunk/WebKit/gtk
2008-02-15 Alp Toker <alp@atoker.com>
Fix the GTK+ build following breakage introduced in r30243.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::objectContentType):
- 2:53 AM Changeset in webkit [30266] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30098.
- 2:52 AM Changeset in webkit [30265] by
-
- 5 edits in branches/Safari-3-1-branch/WebCore
Merge r30097.
- 2:52 AM Changeset in webkit [30264] by
-
- 4 edits5 adds in branches/Safari-3-1-branch
Merge r30096.
- 1:53 AM Changeset in webkit [30263] by
-
- 5 edits in branches/Safari-3-1-branch
Merge r30087.
- 1:52 AM Changeset in webkit [30262] by
-
- 7 edits1 add in branches/Safari-3-1-branch/WebKit/win
Merge r30086.
- 1:51 AM Changeset in webkit [30261] by
-
- 3 edits in branches/Safari-3-1-branch/WebCore
Merge r30085.
- 1:51 AM Changeset in webkit [30260] by
-
- 4 edits in branches/Safari-3-1-branch/WebKitLibraries
Merge r30084.
- 1:33 AM Changeset in webkit [30259] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30081.
- 1:33 AM Changeset in webkit [30258] by
-
- 3 edits in branches/Safari-3-1-branch/WebCore
Merge r30080.
- 1:32 AM Changeset in webkit [30257] by
-
- 4 edits2 adds in branches/Safari-3-1-branch/WebCore
Merge r30079.
- 1:31 AM Changeset in webkit [30256] by
-
- 23 edits in branches/Safari-3-1-branch/WebCore
Merge r30078.
- 1:30 AM Changeset in webkit [30255] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30077.
- 1:30 AM Changeset in webkit [30254] by
-
- 12 edits in branches/Safari-3-1-branch/WebCore
Merge r30076.
- 1:29 AM Changeset in webkit [30253] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30075.
- 12:21 AM Changeset in webkit [30252] by
-
- 2 edits in trunk/WebCore
- another Qt build fix
- platform/qt/KURLQt.cpp: (WebCore::KURL::operator QUrl): Use the characters directly, not ascii(). Eliminate references to urlString.
- 12:12 AM Changeset in webkit [30251] by
-
- 4 edits in trunk
WebCore:
- another Qt build fix
- platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage): Use KURL instead of String.
WebKit/gtk:
- another try at fixing the build
- webkit/webkitwebview.cpp: Added some explicit conversions to KURL.
Feb 14, 2008:
- 11:23 PM Changeset in webkit [30250] by
-
- 3 edits in trunk/WebCore
- another round of build fixes
- platform/KURL.cpp: (WebCore::appendEncodedHostname): Fix spelling (strLen, not strlen).
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): Fix a ".." typo and call data instead of characters.
- 10:45 PM Changeset in webkit [30249] by
-
- 1 edit3 copies in trunk/WebCore
- added back accidentally-removed files
- platform/DeprecatedStringList.cpp: Copied from platform/DeprecatedStringList.cpp.
- platform/DeprecatedStringList.h: Copied from platform/DeprecatedStringList.h.
- platform/mac/DeprecatedStringListMac.mm: Copied from platform/mac/DeprecatedStringListMac.mm.
- 10:38 PM Changeset in webkit [30248] by
-
- 4 edits3 deletes in trunk/WebCore
- more build fixes
- platform/KURL.cpp: (WebCore::appendEncodedHostname): Use String to make a QString.
- platform/network/cf/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Removed a stray deprecatedString() call.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): Updated to String rather than DeprecatedString functions.
- 10:03 PM Changeset in webkit [30247] by
-
- 3 edits in trunk/LayoutTests
Make assign-to-window-status testcase to be more thorough
Reviewed by Jon H
- 9:36 PM Changeset in webkit [30246] by
-
- 2 edits in trunk/WebCore
- next Qt build fix
- platform/network/qt/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Removed a stray deprecatedString() call.
- 9:29 PM Changeset in webkit [30245] by
-
- 2 edits in trunk/WebCore
- another build fix
- platform/network/curl/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Removed a stray deprecatedString() call.
- 9:14 PM Changeset in webkit [30244] by
-
- 2 edits in trunk/WebCore
- first Qt build fix
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): Added a missing string() call.
- 9:03 PM Changeset in webkit [30243] by
-
- 177 edits in trunk
WebCore:
Reviewed by Eric Seidel.
Based on work by Marvin Decker <marv.decker@gmail.com>
- fix http://bugs.webkit.org/show_bug.cgi?id=16538 KURL should use String instead of DeprecatedString
- fix http://bugs.webkit.org/show_bug.cgi?id=16485 DocLoader::checkForReload will crash if the URL isNull and a similar problem in IconDatabase
- fix http://bugs.webkit.org/show_bug.cgi?id=16487 KURL doesn't preserve isNull when constructed with a DeprecatedString
- changed completeURL and various DOM getters to return KURL, to avoid conversion back and forth from KURL to String
- changed the conversion of KURL to NSURL or NSString to be automatic, to ease the use of KURL in Objective C DOM bindings, and eliminated the getNSURL function
- because I had to visit the DOM bindings anyway, eliminated almost all the use of the KJS namespace for things in WebCore
- fixed HTMLOptionElement constructor to check for undefined rather than size of the arguments array
- eliminated some other unnecessary uses of DeprecatedString
- changed String::split to take a Vector parameter instead of returning a Vector, for better performance
- added a couple of missing calls to do layout in SVG image handling; I was able to reproduce these only because I had broken URLs for a while -- not sure how to reproduce them now but the changes are clearly needed
Performance testing shows this to be at least a 1% speedup.
Added a new function protocolIs to efficiently compare protocols
without case errors and a blankURL function so we don't have to
code "about:blank" in multiple places in the code and don't have to
construct a frash KURL each time. Moved decode_string and encode_string
out of KURL and gave them clearer names.
Made KURL constructors explicit to highlight potentially-expensive
operations and the poor semantics of KURL's constructor that takes
a String.
- WebCore.base.exp: Updated.
- bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue): Use protocolIs.
- bindings/js/JSAudioConstructor.h: KJS namespace change.
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS): Ditto.
- bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): Ditto.
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): Ditto. (WebCore::JSDocument::setLocation): Updated for KURL change. (WebCore::toJS): KJS namespace change.
- bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL): Use protocolIs. (WebCore::JSElement::setAttribute): KJS namespace change. (WebCore::JSElement::setAttributeNode): Ditto. (WebCore::JSElement::setAttributeNS): Ditto. (WebCore::JSElement::setAttributeNodeNS): Ditto.
- bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL): Use protocolIs. (WebCore::JSHTMLFrameElement::setSrc): KJS namespace change. (WebCore::JSHTMLFrameElement::setLocation): Ditto.
- bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc): Use protocolIs.
- bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor): (WebCore::JSHTMLOptionElementConstructor::construct): Cleaned up the structure a bit and changed checking to check for undefined rather than number of arguments.
- bindings/js/JSHTMLOptionElementConstructor.h: KJS namespace change.
- bindings/js/JSLocation.cpp: (WebCore::JSLocation::put): Eliminated some DeprecatedString use, and use protocolIs. (WebCore::jsLocationProtoFuncReplace): Ditto. (WebCore::jsLocationProtoFuncReload): Ditto. (WebCore::jsLocationProtoFuncAssign): Ditto.
- bindings/js/JSLocation.h: KJS namespace change.
- bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::canGetItemsForName): Ditto. (WebCore::JSNamedNodeMap::nameGetter): Ditto.
- bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Ditto.
- bindings/js/JSNamedNodesCollection.h: Ditto.
- bindings/js/JSXMLHttpRequest.cpp: (WebCore::jsXMLHttpRequestPrototypeFunctionOpen): Removed DeprecatedString use. (WebCore::jsXMLHttpRequestPrototypeFunctionSend): Ditto.
- bindings/js/JSXMLHttpRequest.h: Moved this class into the WebCore namespace.
- bindings/js/JSXSLTProcessor.cpp: Namespace change.
- bindings/js/JSXSLTProcessor.h: Ditto.
- bindings/js/kjs_binding.cpp: Updated for namespace change. (WebCore::jsStringOrNull): Added an overload for KURL to allow DOM classes to return KURL even if the DOM expects a string. (WebCore::jsStringOrUndefined): Ditto. (WebCore::jsStringOrFalse): Ditto.
- bindings/js/kjs_binding.h: Moved everything into the WebCore namespace.
- bindings/js/kjs_css.h: Namespace change.
- bindings/js/kjs_events.cpp: Removed an include.
- bindings/js/kjs_events.h: Namespace change.
- bindings/js/kjs_html.h: Namespace change.
- bindings/js/kjs_navigator.cpp: Moved everything into the WebCore namespace.
- bindings/js/kjs_navigator.h: Ditto.
- bindings/js/kjs_window.cpp: (KJS::parseModalDialogFeatures): Updated for String::split change. (KJS::createWindow): Use protocolIs and removed some DeprecatedString. (KJS::Window::put): Ditto. (KJS::Window::allowsAccessFrom): Ditto. (KJS::windowProtoFuncOpen): Ditto.
- bindings/objc/DOM.mm: (-[DOMElement _getURLAttribute:]): Removed getNSURL call.
- bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): Ditto.
- bindings/scripts/CodeGeneratorCOM.pm: Updated includes so conversions from KURL will work.
- bindings/scripts/CodeGeneratorJS.pm: Updated for namespace changes, and also updated includes so conversions from KURL will work.
- bindings/scripts/CodeGeneratorObjC.pm: Updated includes so conversions from KURL will work.
- bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]): Removed getNSURL call. Also streamlined the logic. (AXAttributedStringAppendText): Ditto.
- bridge/mac/WebCoreScriptDebugger.mm: (toNSString): Tweaked. (toNSURL): Removed getNSURL call.
- css/CSSImageValue.cpp: (WebCore::CSSImageValue::image): Removed DeprecatedString use.
- css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent): Ditto.
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Ditto. (WebCore::CSSParser::parseContent): Ditto. (WebCore::CSSParser::parseBackgroundImage): Ditto. (WebCore::CSSParser::parseFontFaceSrc): Ditto. (WebCore::CSSParser::parseBorderImage): Ditto.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::setEncodedURL): Ditto. (WebCore::checkPseudoState): Ditto.
- css/CSSStyleSelector.h: Ditto.
- css/MediaList.cpp: (WebCore::MediaList::setMediaText): Updated for String::split change.
- css/StyleBase.cpp: (WebCore::StyleBase::baseURL): Return KURL.
- css/StyleBase.h: DItto.
- dom/Document.cpp: (WebCore::Document::~Document): Updated for namespace change. (WebCore::Document::documentURI): Return KURL. (WebCore::Document::setDocumentURI): Removed DeprecatedString use. (WebCore::Document::baseURI): Return KURL. (WebCore::Document::open): Updated to use blankURL. (WebCore::Document::setURL): Take KURL. (WebCore::Document::shouldBeAllowedToLoadLocalResources): Updated for change to use KURL (WebCore::Document::setBaseURL): Take KURL. (WebCore::Document::elementSheet): Updated for KURL change. (WebCore::Document::mappedElementSheet): Ditto. (WebCore::Document::processHttpEquiv): Ditto. (WebCore::Document::recalcStyleSelector): Removed use of DeprecatedString -- also noticed some dead code here! (WebCore::Document::setCookie): Ditto. (WebCore::Document::completeURL): Return KURL.
- dom/Document.h: Use KURL instead of String in a few places.
- dom/DocumentType.cpp: (WebCore::DocumentType::baseURI): Return KURL.
- dom/DocumentType.h: Ditto.
- dom/Element.cpp: (WebCore::Element::baseURI): Return KURL.
- dom/Element.h: Ditto.
- dom/Node.cpp: (WebCore::Node::setDocument): Namespace change. (WebCore::Node::baseURI): Return KURL.
- dom/Node.h: Ditto.
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): Updated for KURL change.
- dom/StyleElement.cpp: (WebCore::StyleElement::process): Changed to use Vector<UChar> instead of String for better performance. (WebCore::StyleElement::createSheet): Removed use of DeprecateString.
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): Updated for KURL change. (WebCore::XMLTokenizer::end): Ditto. (WebCore::xmlDocPtrForString): Removed use of DeprecateString.
- dom/XMLTokenizer.h: Ditto.
- editing/markup.cpp: Moved appendString to PlatformString.h. (WebCore::appendQuotedURLAttributeValue): Use protocolIs. (WebCore::completeURLs): Removed DeprecatedString use. (WebCore::createFragmentFromMarkup): Use blankURL. (WebCore::fillContainerFromString): Removed DeprecatedString use. (WebCore::createFragmentFromText): Ditto.
- history/HistoryItem.cpp: (WebCore::HistoryItem::url): Removed DeprecatedString use. (WebCore::HistoryItem::originalURL): Ditto.
- history/HistoryItem.h: Removed include.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Removed use of DeprecatedString. (WebCore::HTMLAnchorElement::href): Return KURL. (WebCore::HTMLAnchorElement::hash): Removed DeprecatedString use. (WebCore::HTMLAnchorElement::host): Ditto. (WebCore::HTMLAnchorElement::hostname): Ditto. (WebCore::HTMLAnchorElement::pathname): Ditto. (WebCore::HTMLAnchorElement::port): Ditto. (WebCore::HTMLAnchorElement::protocol): Ditto. (WebCore::HTMLAnchorElement::search): Ditto. (WebCore::HTMLAnchorElement::toString): Ditto.
- html/HTMLAnchorElement.h: Ditto.
- html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer): Updated for KURL change.
- html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::href): Return KURL.
- html/HTMLAreaElement.h: Ditto.
- html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::removedFromDocument): Updated for KURL change. (WebCore::HTMLBaseElement::process): Removed DeprecatedString use.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Updated for KURL change.
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute): Removed use of DeprecatedString.
- html/HTMLEmbedElement.h: Removed DeprecatedString use.
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formWouldHaveSecureSubmission): Use protocolIs. (WebCore::encodeCString): Updated for change to String::split. (WebCore::HTMLFormElement::dataEncoding): Ditto. (WebCore::HTMLFormElement::formData): Removed DeprecatedString use. (WebCore::HTMLFormElement::isMailtoForm): Use protocolIs. (WebCore::HTMLFormElement::submit): Updated for KURL change. (WebCore::HTMLFormElement::reset): Ditto.
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed): Updated for KURL change and use equalIgnoringRef instead of doing a setRef to get the same effect. (WebCore::HTMLFrameElementBase::openURL): Use blankURL. (WebCore::HTMLFrameElementBase::location): Return KURL. (WebCore::HTMLFrameElementBase::src): Return KURL.
- html/HTMLFrameElementBase.h: Ditto.
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Updated for KURL change. (WebCore::HTMLImageElement::longDesc): Return KURL. (WebCore::HTMLImageElement::lowsrc): Return KURL. (WebCore::HTMLImageElement::src): Return KURL.
- html/HTMLImageElement.h: Ditto. Also removed imageMap() function.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::src): Return KURL.
- html/HTMLInputElement.h: Ditto.
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute): Updated for KURL change. (WebCore::HTMLLinkElement::tokenizeRelAttribute): Updated for String::split change. (WebCore::HTMLLinkElement::href): Return KURL.
- html/HTMLLinkElement.h: Ditto.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::src): Return KURL. (WebCore::HTMLMediaElement::pickMedia): Updated for KURL change.
- html/HTMLMediaElement.h: Ditto.
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isImageType): Use protocolIs. (WebCore::HTMLObjectElement::data): Return KURL.
- html/HTMLObjectElement.h: Ditto.
- html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::groupLabelText): Removed DeprecatedString use.
- html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole): Updated for KURL change.
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::insertedIntoDocument): Ditto. (WebCore::HTMLScriptElement::text): Changed to use Vector<UChar> instead of String for better performance. (WebCore::HTMLScriptElement::src): Return KURL.
- html/HTMLScriptElement.h: Ditto.
- html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::src): Return KURL.
- html/HTMLSourceElement.h: Ditto.
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute): Updated for KURL change.
- html/HTMLTablePartElement.cpp: (WebCore::HTMLTablePartElement::parseMappedAttribute): Updated for KURL change.
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): Removed DeprecatedString use.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution): Ditto. (WebCore::HTMLTokenizer::notifyFinished): Use protocolIs.
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::poster): Return KURL.
- html/HTMLVideoElement.h: Ditto.
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addText): Updated for String::split change.
- loader/DocLoader.cpp: (WebCore::DocLoader::checkForReload): Add an explicit check for an empty URL here to avoid problems using its string as a hash table key later. (WebCore::DocLoader::requestResource): Removed DeprecatedString use.
- loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::createTDForFilename): Updated for KURL change. (WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine): Removed use of DeprecatedString.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Use protocolIs. (WebCore::FrameLoader::loadSubframe): Use blankURL. (WebCore::FrameLoader::submitForm): Use protocolIs and removed use of DeprecatedString. (WebCore::FrameLoader::iconURL): Return KURL. Use protcolIs. (WebCore::FrameLoader::didOpenURL): Use protocolIs. (WebCore::FrameLoader::didExplicitOpen): Use blankURL. (WebCore::FrameLoader::executeIfJavaScriptURL): Use protocolIs. Update for name change to decodeURLEscapeSequences. (WebCore::FrameLoader::receivedFirstData): Updated for KURL changes. (WebCore::FrameLoader::begin): Removed DeprecatedString use. Renamed baseurl to baseURL. Updated to use KURL more. (WebCore::FrameLoader::gotoAnchor): Removed use of encodedHtmlRef function, which is no different from ref. (WebCore::FrameLoader::completeURL): Updated for KURL change. (WebCore::FrameLoader::scheduleLocationChange): Ditto. (WebCore::FrameLoader::canCachePage): Use protocolIs. (WebCore::FrameLoader::updatePolicyBaseURL): Update for KURL change. (WebCore::FrameLoader::setPolicyBaseURL): Take KURL. (WebCore::FrameLoader::startRedirectionTimer): Removed use of DeprecatedString. (WebCore::FrameLoader::load): Use protocolIs. (WebCore::FrameLoader::shouldHideReferrer): Use protocolIs. (WebCore::FrameLoader::shouldAllowNavigation): Updated for KURL change. (WebCore::FrameLoader::commitProvisionalLoad): Use blankURL. (WebCore::FrameLoader::open): Use protcolIs. (WebCore::FrameLoader::createHistoryItem): Use blankURL. (WebCore::FrameLoader::createJavaAppletWidget): Updated for KURL change. (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady): Removed DeprecatedString use.
- loader/FrameLoader.h: Ditto.
- loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure): Updated for KURL change.
- loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): Ditto.
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::iconForPageURL): Added a check for an empty URL before trying to use it as a hash table key.
- loader/icon/IconLoader.h: Tweaked includes.
- loader/loader.cpp: (WebCore::Loader::servePendingRequests): Use protcolIs. Also removed some code to set up a local variable that is never used (and a DeprecatedString on to boot!).
- loader/mac/LoaderNSURLExtras.m: (suggestedFilenameWithMIMEType): Removed unnecessary typecast.
- page/ContextMenuController.cpp: Removed include.
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks): Use protocolIs.
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge URLWithAttributeString:]): Removed getNSURL call. (-[WebCoreFrameBridge baseURL]): Ditto.
- platform/KURL.cpp: (WebCore::isSchemeFirstChar): Fixed bug in handling of values >= 0x80. (WebCore::isSchemeChar): Ditto. (WebCore::isPathSegmentEndChar): Ditto. (WebCore::hexDigitValue): Changed parameter type to UChar. (WebCore::copyASCII): Added. (WebCore::findFirstOf): Added. (WebCore::KURL::protocolIs): Added. (WebCore::KURL::KURL): Tightened logic up quite a bit. Changed parameter types from DeprecatedString to String. (WebCore::KURL::init): Changed parameter type to String. Preserved the passed-in string even if the base is invalid. Cleaned up logic to determine if the originalString should be pased in to the parse function. Simplified by calling the new parse overload that takes String in many cases. (WebCore::KURL::lastPathComponent): Return String. (WebCore::KURL::protocol): Ditto. (WebCore::KURL::host): Ditto. (WebCore::KURL::port): Changed logic to use early return for clarity. (WebCore::KURL::pass): Return String. (WebCore::KURL::user): Ditto. (WebCore::KURL::ref): Ditto. (WebCore::assertProtocolIsGood): Added. (WebCore::KURL::protocolIs): Added. (WebCore::KURL::query): Return String. (WebCore::KURL::path): Ditto. (WebCore::KURL::setProtocol): Take String. (WebCore::KURL::setHost): Ditto. (WebCore::KURL::setPort): Use String. (WebCore::KURL::setHostAndPort): Take String. (WebCore::KURL::setUser): Ditto. (WebCore::KURL::setPass): Ditto. (WebCore::KURL::setRef): Ditto. (WebCore::KURL::setQuery): Ditto. (WebCore::KURL::setPath): Ditto. (WebCore::KURL::prettyURL): Return String. Use Vector<UChar> to build it. (WebCore::decodeURLEscapeSequences): Renamed from KURL::decode_string. Return String. Use Vector<UChar> to build it. (WebCore::KURL::isLocalFile): Use protocolIs. (WebCore::KURL::parse): Added an overload that takes a String to replace the use of DeprecatedString::ascii at various call sites. Updated for name change (urlString -> m_string). (WebCore::equalIgnoringRef): Wrote a new implementation that doesn't do any allocation. (WebCore::encodeWithURLEscapeSequences): Renamed from KURL::encode_string. Return String. (WebCore::appendEncodedHostname): Added. Replaces encodeHostname and avoids the need to allocate a string. (WebCore::findHostnamesInMailToURL): Update to use findFirstOf instead of regular expressions. (WebCore::findHostnameInHierarchicalURL): Ditto. (WebCore::encodeHostnames): Use protocolIs and the other helpers above. (WebCore::encodeRelativeString): Changed to put result into a CharBuffer. (WebCore::substituteBackslashes): Updated to use String. (WebCore::KURL::copyToBuffer): Added. (WebCore::protocolIs): Added. (WebCore::blankURL): Added. (WebCore::KURL::print): Updated.
- platform/KURL.h: Added a number of comments. Reorganized the header a bit. Made the string constructors explicit. Changed to use String instead of DeprecatedString. Removed encodedHTMLRef. Renamed and added a few functions.
- platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL): Streamlined the logic a bit. (WebCore::KURL::createCFURL): Changed to use copyToBuffer.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): Removed getNSURL call. Use protocolIs.
- platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::declareAndWriteDragImage): Removed getNSURL call.
- platform/mac/CookieJar.mm: (WebCore::cookies): Removed getNSURL call. (WebCore::setCookies): Removed getNSURL call.
- platform/mac/KURLMac.mm: (WebCore::KURL::KURL): Streamlined the logic a bit.
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeURL): Removed getNSURL call. (WebCore::Pasteboard::writeImage): Ditto.
- platform/mac/SSLKeyGeneratorMac.mm: (WebCore::signedPublicKeyAndChallengeString): Ditto.
- platform/network/HTTPParsers.cpp: (WebCore::filenameFromHTTPContentDisposition): Updated for String::split.
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::portAllowed): Use protocolIs.
- platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::operator CFErrorRef): Removed deprecatedString call.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::headerCallback): Ditto. (WebCore::parseDataUrl): Use String instead of DeprecatedString. (WebCore::ResourceHandleManager::startJob): Updated for KURL changes.
- platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::operator NSError*): Removed getNSURL call.
- platform/network/mac/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Removed DeprecatedString use.
- platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Removed getNSURL call.
- platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::nsURLResponse): Removed getNSURL call.
- platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writeURL): Removed deprecatedString call.
- platform/text/CString.h: (WebCore::CStringBuffer::length): Fixed size_t/unsigned mismatch to make it possible to compile this on Windows with higher warning level
- platform/text/PlatformString.h: Updated split to modify a result parameter rather than returning a Vector. Added charactersAreAllASCII and an append function that appends a String to a Vector<UChar>.
- platform/text/String.cpp: (WebCore::String::split): Updated.
- platform/win/BString.cpp: (WebCore::BString::BString): Added conversion from KURL.
- platform/win/BString.h: Ditto.
- platform/win/ClipboardUtilitiesWin.cpp: (WebCore::markupToCF_HTML): Removed use of deprecatedString.
- platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle): Ditto. (WebCore::createGlobalHDropContent): Ditto. (WebCore::ClipboardWin::setData): Ditto. (WebCore::ClipboardWin::writeRange): Ditto.
- platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): Ditto.
- plugins/PluginStream.cpp: (WebCore::PluginStream::startStream): Ditto. (WebCore::PluginStream::destroyStream): Ditto.
- plugins/win/PluginViewWin.cpp: (WebCore::scriptStringIfJavaScriptURL): Ditto. (WebCore::PluginView::performRequest): Ditto. (WebCore::PluginView::PluginView): Ditto.
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): Removed DeprecatedString use. (WebCore::HitTestResult::absoluteLinkURL): Ditto.
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layOutAxis): Fixed comment wording.
- rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): Removed use of DeperecatedString, (WebCore::RenderImage::imageMap): Changed to call useMap instead of imageMap; both do the same thing, and the first is standard DOM.
- rendering/RenderObject.cpp: (WebCore::RenderObject::addPDFURLRect): Rewrote and streamlined to remove DeprecatedString use.
- rendering/RenderObject.h: Changed addPDFURLRect to take const IntRect&.
- rendering/RenderPartObject.cpp: (WebCore::isURLAllowed): Updated for KURL change and use equalIgnoringRef instead of doing a setRef to get the same effect. (WebCore::RenderPartObject::updateWidget): Updated for KURL change.
- rendering/RenderText.cpp: (WebCore::charactersAreAllASCII): Moved the guts to PlatformString.h.
- rendering/SVGRenderSupport.cpp: (WebCore::renderSubtreeToImage): Added missing call to do layout. I ran into this while doing some layout tests while URL processing was broken.
- rendering/SVGRenderTreeAsText.h: Removed include.
- svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::updateFromElement): Removed DeprecatedString use.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw): Added missing call to do layout. I ran into this while doing some layout tests while URL processing was broken. (WebCore::SVGImage::dataChanged): Use a null URL rather than an arbitrary string for the document.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Removed DeprecatedString use. (WebCore::XMLHttpRequest::urlMatchesDocumentDomain): Ditto. (WebCore::XMLHttpRequest::open): Ditto. (WebCore::XMLHttpRequest::send): Namespace change. (WebCore::XMLHttpRequest::dropProtection): Ditto.
- xml/XMLHttpRequest.h: Removed DeprecatedString use.
- xml/XSLImportRule.cpp: (WebCore::XSLImportRule::loadSheet): Removed DeprecatedString use.
- xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::loadChildSheets): Ditto. (WebCore::XSLStyleSheet::loadChildSheet): Ditto.
- xml/XSLStyleSheet.h: Ditto.
- xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc): Ditto. (WebCore::xsltStylesheetPointer): Ditto. (WebCore::xmlDocPtrFromNode): Ditto.
WebKit/gtk:
- webkit/webkitwebframe.cpp: Removed DeprecatedString use to try to keep it building.
- webkit/webkitwebview.cpp: Ditto.
WebKit/mac:
Reviewed by Eric Seidel.
- updated for WebCore KURL changes
- History/WebHistoryItem.mm: (-[WebHistoryItem URL]): Removed getNSURL call.
- Misc/WebElementDictionary.mm: (-[WebElementDictionary _absoluteImageURL]): Ditto. (-[WebElementDictionary _absoluteLinkURL]): Ditto.
- Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement): Ditto. (+[NSAttributedString _web_attributedStringFromRange:]): Ditto.
- Misc/WebNSURLExtras.mm: (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Updated for function name change.
- WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::downloadURL): Removed getNSURL call.
- WebCoreSupport/WebDragClient.mm: (WebDragClient::createDragImageForLink): Ditto.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Ditto. (WebFrameLoaderClient::startDownload): Ditto. (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): Ditto. (WebFrameLoaderClient::updateGlobalHistoryForReload): Ditto. (WebFrameLoaderClient::cancelledError): Ditto. (WebFrameLoaderClient::blockedError): Ditto. (WebFrameLoaderClient::cannotShowURLError): Ditto. (WebFrameLoaderClient::interruptForPolicyChangeError): Ditto. (WebFrameLoaderClient::cannotShowMIMETypeError): Ditto. (WebFrameLoaderClient::fileDoesNotExistError): Ditto. (WebFrameLoaderClient::willUseArchive): Ditto. (WebFrameLoaderClient::setTitle): Ditto. (WebFrameLoaderClient::actionDictionary): Ditto. (WebFrameLoaderClient::createFrame): Ditto. (WebFrameLoaderClient::objectContentType): Ditto. (WebFrameLoaderClient::createPlugin): Ditto. (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
- WebView/WebDataSource.mm: (-[WebDataSource _URL]): Ditto. (-[WebDataSource _initWithDocumentLoader:]): Ditto. (-[WebDataSource unreachableURL]): Ditto.
- WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
WebKit/win:
- updated for WebCore KURL changes
- MarshallingHelpers.cpp: (MarshallingHelpers::BSTRToKURL): Removed deprecatedString call. (MarshallingHelpers::KURLToBSTR): Tweaked for efficiency.
- WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): Updated for KURL changes.
- WebDataSource.cpp: (WebDataSource::unreachableURL): Ditto.
- WebDownload.cpp: (WebDownload::init): Ditto. (WebDownload::initWithRequest): Ditto.
- WebFrame.cpp: (WebFrame::loadData): Ditto. (WebFrame::loadURLIntoChild): Ditto. (WebFrame::objectContentType): Ditto.
- WebResource.cpp: (WebResource::initWithData): Ditto.
- WebURLResponse.cpp: (WebURLResponse::createInstance): Ditto. (WebURLResponse::initWithURL): Ditto.
- WebView.cpp: (WebView::userAgentForURL): Ditto. (WebView::copyURL): Ditto. (WebView::notifyPreferencesChanged): Ditto.
WebKit/wx:
- WebView.cpp: Removed use of DeprecatedString to keep this compiling.
- 8:32 PM Changeset in webkit [30242] by
-
- 2 edits in trunk/WebKitTools
- fix Windows build
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::setStatusText): Update parameter types to match declaration.
- 8:30 PM Changeset in webkit [30241] by
-
- 3 edits in trunk/LayoutTests
- update this test further, so that it succeeds
- fast/dom/assign-to-window-status-expected.txt: Updated.
- fast/dom/assign-to-window-status.html: Updated.
- 6:17 PM Changeset in webkit [30240] by
-
- 2 edits in trunk/WebCore
<rdar://problem/5744728> Fix leaks of RegularExpression objects in Frame.cpp.
Reviewed by Jon and Darin.
- page/Frame.cpp: (WebCore::createRegExpForLabels): (WebCore::Frame::searchForLabelsBeforeElement): (WebCore::Frame::matchLabelsAgainstElement):
- 6:03 PM Changeset in webkit [30239] by
-
- 6 edits in trunk
2008-02-14 Stephanie Lewis <Stephanie Lewis>
Reviewed by Geoff.
Update order files.
- WebKit.order:
- WebCore.order:
- JavaScriptCore.order:
- 6:00 PM Changeset in webkit [30238] by
-
- 14 edits2 adds in trunk
<rdar://problem/5726608> REGRESSION (r29428): Assigning to window.status does not update status bar
Reviewed by Geoff G and Weinig.
Revert the portions of r29428 responsible for breaking the ability to
set window.status
- 5:35 PM Changeset in webkit [30237] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/5721790>
Crash in WebCore::DeprecatedString::operator= + 31 at news.google.com
Use pointers in the cache map tables. Otherwise when we rehash,
we will end up destroying Cache objects that node lists might point to.
- dom/Node.cpp: (WebCore::NodeListsNodeData::~NodeListsNodeData): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):
- 4:30 PM Changeset in webkit [30236] by
-
- 2 edits in trunk/WebCore
2008-02-14 Alp Toker <alp@atoker.com>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=17353
XMLTokenizer installs global libxml2 callbacks that can break client applications
Patch by Mark Rowe (with a few changes).
The xmlRegisterInputCallbacks/xmlRegisterOutputCallbacks done at
init are global so we need to make sure these callbacks only get used
by XMLTokenizer and never by libxml2 calls in user applications.
This patch modifies the match and open functions to only apply when we
are certain the caller is XMLTokenizer by checking globalDocLoader and
ensuring we're on the correct thread.
Some possible issues remain. See the bug report for details.
- dom/XMLTokenizer.cpp: (WebCore::matchFunc): (WebCore::openFunc): (WebCore::createStringParser):
- 3:29 PM Changeset in webkit [30235] by
-
- 3 edits3 adds in trunk
Reviewed by Sam Weinig.
Fixed <rdar://problem/5737835> nee http://bugs.webkit.org/show_bug.cgi?id=17329
Crash in JSGlobalObject::popActivation when inserting hyperlink in Wordpress (17329)
Don't reset the "activations" stack in JSGlobalObject::reset, since we
might be executing a script during the call to reset, and the script
needs to safely run to completion.
Instead, initialize the "activations" stack when the global object is
created, and subsequently rely on pushing and popping during normal
execution to maintain the stack's state.
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init): (KJS::JSGlobalObject::reset):
LayoutTests:
Reviewed by Sam Weinig.
Layout test for <rdar://problem/5737835> nee http://bugs.webkit.org/show_bug.cgi?id=17329
Crash in JSGlobalObject::popActivation when inserting hyperlink in Wordpress (17329)
- fast/dom/javascript-url-crash-function.html: Added.
- fast/dom/javascript-url-crash-function-expected.txt: Added.
- fast/dom/resources/javascript-url-crash-function-iframe.html: Added.
- 2:27 PM Changeset in webkit [30234] by
-
- 8 edits in branches/Safari-3-1-branch
WebCore:
Reviewed by Adele Peterson.
- roll out changes to CSS2 system colors from r28775
- css/CSSStyleSelector.cpp: (WebCore::): (WebCore::colorForCSSValue):
- rendering/RenderTheme.cpp:
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
LayoutTests:
Reviewed by Adele Peterson.
- updated results after reverting CSS2 system colors changes from r28775
- platform/mac/tables/mozilla/bugs/bug103533-expected.txt:
- 1:00 PM Changeset in webkit [30233] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/5743768> A deadlock during storage layout tests
Make sure not to hold the m_openDatabaseMapGuard mutex when calling
Database::markAsDeletedAndClose(), since that can cause a deadlock
during the synchronous DatabaseThread call it triggers.
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::deleteDatabaseFile):
- 11:45 AM Changeset in webkit [30232] by
-
- 1 edit40 adds in trunk/LayoutTests
Reviewed by Oliver.
Add dynamic update tests for SVGEllipseElement.
- 8:34 AM Changeset in webkit [30231] by
-
- 2 edits in trunk/WebCore
Improve the efficiency of SecurityOriginHash
Reviewed by Alexey.
- platform/SecurityOriginHash.h: (WebCore::SecurityOriginHash::hash): Now takes a const RefPtr<SecurityOrigin>& to reduce ref-count churn. (WebCore::SecurityOriginHash::equal): Ditto.
- 7:41 AM Changeset in webkit [30230] by
-
- 2 edits in trunk/WebKit/win
- WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Forgot to re-apply review comments to the previous check-in, fixing.
- 7:36 AM Changeset in webkit [30229] by
-
- 4 edits in trunk/WebKit
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=17207
Database example doesn't work (requires not-yet-released Safari)
- mac/WebCoreSupport/WebChromeClient.mm: (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage if it's too old.
- win/WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage if it's too old.
- 4:37 AM Changeset in webkit [30228] by
-
- 1 edit in trunk/WebKit/gtk/ChangeLog
Correct the e-mail address in the ChangeLog.
- 4:27 AM Changeset in webkit [30227] by
-
- 2 edits in trunk/WebKit/gtk
- Make the handling of the coreFrame consistent. We construct the coreFrame at the beginning and it will live until the end. Change the g_return_(val_)if to ASSERTs as having a 0 coreFrame can never happen.
- 4:26 AM Changeset in webkit [30226] by
-
- 6 edits in trunk/WebKit/gtk
- Make sure that the WebCore::Frame is living as long as the WebKitWebFrame wrapped around it. All current calls to WebCore::Frame from within the WebKitWebFrame are safe, even in the case where the WebCore::Frame is already detached from the WebCore::Page.
- For the mainFrame the WebKitWebView is holding the initial reference and will unref on destruction.
- For sub-frames the FramerLoaderClientGtk.cpp will do the unrefing when the frame gets detached from the parent.
- Make sure FrameLoader::detachFromParent gets called by calling FrameLoader::detachChildren
- 4:25 AM Changeset in webkit [30225] by
-
- 2 edits in trunk/WebKit/gtk
WebCore::Frame is RefCounted, do not manually delete it!
- 4:25 AM Changeset in webkit [30224] by
-
- 2 edits in trunk/WebKit/gtk
- Plug a leak
- 4:24 AM Changeset in webkit [30223] by
-
- 4 edits in trunk/WebKit/gtk
- Update the Copyright Information
Feb 13, 2008:
- 9:14 PM Changeset in webkit [30222] by
-
- 10 edits in trunk
WebCore:
Reviewed by Oliver Hunt.
Fixes the editing/deleting/5729680.html failure. It succeeds when run by itself
but fails when run with other tests because FramePrivate's m_selectionGranularity
isn't reset when a Frame receives a new document. It was also uninitialized in
the constructor.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Initialize m_selectionGranularity.
- page/Frame.cpp: (WebCore::FramePrivate::FramePrivate): Ditto.
LayoutTests:
Reviewed by Oliver Hunt.
- platform/mac/editing/deleting/table-cells-expected.checksum: Fixed. Before, a space was incorrectly removed by a delete (this isn't a smart delete).
- platform/mac/editing/deleting/table-cells-expected.png:
- platform/mac/editing/deleting/table-cells-expected.txt:
- platform/mac/editing/pasteboard/input-field-1-expected.checksum: Fixed. Before a space was incorrectly added by paste (this isn't a smart paste).
- platform/mac/editing/pasteboard/input-field-1-expected.png:
- platform/mac/editing/pasteboard/input-field-1-expected.txt:
- 8:46 PM Changeset in webkit [30221] by
-
- 4 edits in branches/Safari-3-1-branch
Versioning.
- 8:45 PM Changeset in webkit [30220] by
-
- 4 edits in tags/Safari-5525.9
Versioning.
- 8:22 PM Changeset in webkit [30219] by
-
- 1 copy in tags/Safari-5525.9
New tag.
- 6:13 PM Changeset in webkit [30218] by
-
- 3 edits in trunk/WebCore
2008-02-13 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Anders.
<rdar://problem/5739282> Hangs after closing video trailer popup with
VLC plugin
VLC hangs on NPP_Destroy if we call NPP_SetWindow with a null window
handle.
- plugins/PluginQuirkSet.h: Added new quirk PluginQuirkDontSetNullWindowHandleOnDestroy. (WebCore::):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::stop): Selectively call NPP_SetWindow. (WebCore::PluginView::determineQuirks): Set new quirk for VLC plug-in.
- 4:15 PM Changeset in webkit [30217] by
-
- 1 edit in trunk/WebKit/win/ProgIDMacros.h
Versioning.
- 4:07 PM Changeset in webkit [30216] by
-
- 1 edit in trunk/WebKitLibraries/win/tools/scripts/VERSION
Versioning
- 3:51 PM Changeset in webkit [30215] by
-
- 2 edits in trunk/WebCore
2008-02-13 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Alp Toker.
Fix non-SVG builds.
- css/CSSCursorImageValue.cpp:
- 2:58 PM Changeset in webkit [30214] by
-
- 4 edits in trunk
Versioning.
- 2:00 PM Changeset in webkit [30213] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Adam Roben.
<rdar://problem/5729680> REGRESSION (r27873): Removing the last character of a word in Mail or Safari also removes the following space
- editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): Fixed a typo.
LayoutTests:
Reviewed by Adam Roben.
<rdar://problem/5729680> REGRESSION (r27873): Removing the last character of a word in Mail or Safari also removes the following space
- editing/deleting/5729680-expected.txt: Added.
- editing/deleting/5729680.html: Added.
- 1:56 PM Changeset in webkit [30212] by
-
- 37 edits in trunk/LayoutTests
Reviewed by Adam.
Make svg/dynamic-updates/* tests deterministic. s/setTimeout('executTest()', 0)/executeTest/ -- as discussed with Adam.
- 1:49 PM Changeset in webkit [30211] by
-
- 3 edits in trunk/WebCore
Reviewed by Oliver.
Actually fix the manual-tests/svg-cursor-changes.svg testcase.
I only reran layout tests when fixing the last issues with the patch,
instead of trying the manual-test :( Fixed.
- 1:31 PM Changeset in webkit [30210] by
-
- 1 edit1 add in trunk/WebKitTools
Windows build fix
- DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.
- 1:19 PM Changeset in webkit [30209] by
-
- 4 edits in trunk
Windows/GTK+ build fixes
WebCore:
Windows build fix
- css/CSSCursorImageValue.cpp: #include MathExtras.h to get roundf.
WebKitTools:
Windows/GTK+ build fix
- DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to get isnan.
- 12:41 PM Changeset in webkit [30208] by
-
- 12 edits1 add in trunk/WebCore
Reviewed by Darin & Eric.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=17258 (SVG uses erroneous cursor implementation)
SVG cursors are not well-integrated within the CSS(3) cursor support in WebCore.
SVGCursorElement duplicates CSSCursorImageValue functionality and inherits from
CachedResourceClient itself, handling remote-image acquisation on its own.
RenderStyle's CursorData class holds "IntPoint hotSpot", "CachedImage* image"
and just for SVG a 'String cursorFragmentId' (a reference to a SVG <cursor> element, by id).
SVG stores a reference to a SVGCursorElement, which holds a CachedImage pointer itself -
instead of storing the CachedImage in the CursorData class, as it's supposed to be.
Because of that several places in WebCore contain special SVG cursor handling - which
is unneeded.
Fix all issues by integrating within CSSCursorImageValue, remove 'String cursorFragmentId'
from RenderStyle, kill any special SVG cursor handling in WebCore and fix dynamic attribute
changes through DOM / SVG DOM (scripting of 'x' / 'y' / 'xlink:href' attribute).
- 12:14 PM Changeset in webkit [30207] by
-
- 4 edits1 add in trunk/WebCore
2008-02-13 Alp Toker <alp@atoker.com>
Reviewed by Adam Roben.
Split out pure-cairo Font code to FontCairo.cpp.
Part of the ongoing work to share code with the Win port.
- GNUmakefile.am:
- WebCore.pro:
- platform/graphics/cairo/FontCairo.cpp: Added. (WebCore::Font::drawGlyphs):
- platform/graphics/gtk/FontGtk.cpp:
- 11:34 AM Changeset in webkit [30206] by
-
- 2 edits in trunk/WebKit/win
<rdar://problem/5740656> Leak in postDidAddIconNotification in WebIconDatabase
Reviewed by Darin.
- WebIconDatabase.cpp: (postDidAddIconNotification): Need to adopt the newly created instance of CFDictionaryPropertyBag, which already has a ref count of 1.
- 10:47 AM Changeset in webkit [30205] by
-
- 11 edits4 adds in trunk
WebKitTools:
Reviewed by Darin Adler
Add some much needed Database support to DRT
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to databases are called (clearAllDatabasesCallback): Allow a test to delete all databases (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpDatabaseCallbacks): (LayoutTestController::setDumpDatabaseCallbacks):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::clearAllDatabases): (LayoutTestController::setDatabaseQuota):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::clearAllDatabases): Stubbed out (LayoutTestController::setDatabaseQuota): Ditto
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::clearAllDatabases): Stubbed out with error message (LayoutTestController::setDatabaseQuota): Ditto
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a message with details about the event then return a 5mb quota like before
LayoutTests:
Reviewed by Darin Adler
Added layout tests to cover
http://trac.webkit.org/projects/webkit/changeset/29983
and
http://trac.webkit.org/projects/webkit/changeset/30184
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- storage/quota-tracking-expected.txt: Added.
- storage/quota-tracking.html: Added.
- storage/success-callback-expected.txt: Added.
- storage/success-callback.html: Added.
- 9:49 AM Changeset in webkit [30204] by
-
- 6 edits in trunk
Fix issues with the paint origin when using wxGCDC, with computing the font platform data hash, and Win and wxPython bindings compilation.
http://bugs.webkit.org/show_bug.cgi?id=17321
- 9:48 AM Maintenance and architecture list edited by
- Mention the clean-header-guards script (diff)
- 9:34 AM Maintenance and architecture list edited by
- (diff)
- 9:33 AM Maintenance and architecture list edited by
- Take out Apple-specific items. (diff)
- 9:29 AM Maintenance and architecture list created by
- 9:28 AM Changeset in webkit [30203] by
-
- 7 edits in trunk
2008-02-13 Rodney Dawes <dobey@wayofthemonkey.com>
Fix Bug 17220: Illogical dependency between PluginView and PluginDatabase
WebCore:
Fix Bug 17220: Illogical dependency between PluginView and
PluginDatabase
Reviewed by Adam and Darin.
Rename PluginDatabase::createPluginView to PluginView::create, to make
the illogical dependency between the two, logical
Make PluginDatabase::findPlugin a public method
Update the includes in PluginView and PluginDatabase for the change
- plugins/PluginDatabase.h:
- plugins/PluginView.h:
- plugins/win/PluginDatabaseWin.cpp:
- plugins/win/PluginViewWin.cpp:
WebKit/win:
Fix Bug 17220: Illogical dependency between PluginView and
PluginDatabase
Reviewed by Adam and Darin.
Update for the rename of PluginDatabase::createPluginView
to PluginView::create
- WebFrame.cpp:
- 9:20 AM Changeset in webkit [30202] by
-
- 6 edits in trunk
Windows build fixes
WebCore:
Build fix
- platform/graphics/cg/GraphicsContextCG.cpp: Added missing #include.
WebKit/win:
Windows build fix
- Interfaces/WebKit.idl: Create the typelib version symbol ourselves.
WebKitLibraries:
- win/tools/scripts/auto-version.sh: Removed a redundant symbol.
- 9:20 AM WikiStart edited by
- Adding a new page with to do items for maintenance. (diff)
- 8:29 AM Changeset in webkit [30201] by
-
- 2 edits in trunk/WebKit/gtk
2008-02-13 Alp Toker <alp@atoker.com>
Reviewed by Adam Roben.
Fix very small, upside down, inside out text on GTK+/DirectFB.
Based on an initial patch by Sriram Neelakandan <sriram.neelakandan@gmail.com>
Test the result of gdk_screen_get_resolution() and use a default
fallback in case of failure.
Also remove an unhelpful runtime warning.
- webkit/webkitwebview.cpp:
- 7:56 AM Changeset in webkit [30200] by
-
- 1 edit2 deletes in trunk/LayoutTests
- platform/mac/svg/hixie/perf/001-expected.txt: Removed.
- platform/mac/svg/hixie/perf/002-expected.txt: Removed.
- 7:29 AM Changeset in webkit [30199] by
-
- 2 edits in trunk/WebCore
Not reviewed, build fix.
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::paintBuffer):
- 6:25 AM Changeset in webkit [30198] by
-
- 5 edits in trunk/WebCore
- try to fix Wx build
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::paintBuffer): Added.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::paintBuffer): Added missing paintingDisabled() check.
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::paintBuffer): Ditto.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::paintBuffer): Ditto.
- 5:33 AM Changeset in webkit [30197] by
-
- 2 edits in trunk/WebCore
- try to fix Wx build
- platform/wx/LocalizedStringsWx.cpp: Add missing include.
- 5:26 AM Changeset in webkit [30196] by
-
- 8 edits in trunk
WebCore:
- roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders incorrectly due to visibility fix
Removed the Xcode-specific quirk at the request of some folks on the Xcode team.
- WebCore.base.exp: Rolled out change.
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): Ditto.
- page/Settings.cpp: (WebCore::Settings::Settings): Ditto. But keep the initialization of m_fontRenderingMode. (WebCore::Settings::setNeedsXcodeVisibilityQuirk): Removed.
- page/Settings.h: (WebCore::Settings::needsXcodeVisibilityQuirk): Removed.
WebKit/mac:
- roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders incorrectly due to visibility fix
Removed the Xcode-specific quirk at the request of some folks on the Xcode team.
- Misc/WebKitVersionChecks.h: Removed the constant.
- WebView/WebView.mm: (-[WebView _needsXcodeVisibilityQuirk]): Removed. (-[WebView _preferencesChangedNotification:]): Removed call to setNeedsXcodeVisibilityQuirk.
- 4:51 AM Changeset in webkit [30195] by
-
- 7 edits4 adds in trunk
Reviewed by Darin.
<rdar://problem/5740042> Database termination issues
Test: storage/close-during-stress-test.html
- dom/Document.cpp: (WebCore::Document::databaseThread):
- dom/Document.h: Don't re-create the database thread if it has been already terminated.
- storage/Database.h: (WebCore::Database::document): Changed m_database to a RefPtr to avoid having a hanging reference.
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::requestTermination):
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::~SQLTransaction): Removed logging. Transactions are deleted during GC, so it's usually not importatnt to know when it happens.
- 4:33 AM Changeset in webkit [30194] by
-
- 1 edit2 adds in trunk/LayoutTests
- check in results for these tests
No idea if these are right or not; just what was generated on my computer.
If someone has a better version, feel free to replace these results with correct ones.
- platform/mac/svg/hixie/perf/001-expected.txt: Added.
- platform/mac/svg/hixie/perf/002-expected.txt: Added.
- 4:27 AM Changeset in webkit [30193] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=17340 WebCore/platform/Timer.cpp fails to build with gcc 4.3
- platform/Timer.cpp: Add include of <limits.h> since this file uses UINT_MAX.
- 4:10 AM Changeset in webkit [30192] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=17339 JavaScriptCore does not build with gcc 4.3
- kjs/interpreter.cpp: Add include of <unistd.h>, since that's where getpid() comes from.
- 1:51 AM Changeset in webkit [30191] by
-
- 3 edits3 adds in trunk
<rdar://problem/5737003> REGRESSION (r27747): can't browse pictures on fastcupid.com
Reviewed by Alexey P.
When converting numeric values to booleans we need to account for NaN
