Timeline
Feb 18, 2009:
- 7:36 PM Changeset in webkit [41075] by
-
- 4 edits in branches/Safari-6528
Versioning.
- 7:35 PM Changeset in webkit [41074] by
-
- 1 copy in tags/Safari-6528.15.2
New tag.
- 7:34 PM Changeset in webkit [41073] by
-
- 4 edits in branches/Safari-6528
Versioning.
- 7:34 PM Changeset in webkit [41072] by
-
- 7 edits in branches/Safari-6528
Merge r41071.
- 6:04 PM Changeset in webkit [41071] by
-
- 7 edits in trunk
WebCore:
Reviewed by Brady Eidson.
- WebCore part of fixing <rdar://problem/6507512> Crash in iChat at CSSStyleSelector::adjustRenderStyle
The crash results from re-entry into
CSSMutableStyleDeclaration::setCssText, which in turn is caused by
the first style change causing a cached image to load from the memory
cache, causing load delegate dispatch, and iChat's delegate method
calling back into WebKit.
The workaround is to use defer delegate callbacks for memory cache. In
this case, deferring callbacks during image load event dispatch was
found to be sufficient.
The crash is a regression. See also the discussion in
<https://bugs.webkit.org/show_bug.cgi?id=22521>.
- WebCore.base.exp: Added Settings::setNeedsIChatMemoryCacheCallsQuirk().
- dom/Document.cpp: (WebCore::Document::dispatchImageLoadEventsNow): If the quirk is enabled, defer memory cache callbacks during image load event dispatch.
- page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_needsIChatMemoryCacheCallsQuirk. (WebCore::Settings::setNeedsIChatMemoryCacheCallsQuirk): Added this setter.
- page/Settings.h: (WebCore::Settings::needsIChatMemoryCacheCallsQuirk): Added this getter.
WebKit/mac:
Reviewed by Brady Eidson.
- WebKit part of fixing <rdar://problem/6507512> Crash in iChat at CSSStyleSelector::adjustRenderStyle
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Activate the WebCore workaround for this crash in iChat.
- 5:46 PM Changeset in webkit [41070] by
-
- 2 edits in trunk/WebKit/mac
2009-02-18 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Fix for <rdar://problem/6542390>
There's no need to call setDefersLoading here - we already defer anything a plug-in can do that
would cause a load to begin.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]):
- 4:13 PM Changeset in webkit [41069] by
-
- 2 edits1 add3 deletes in trunk/LayoutTests
2009-02-18 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24012
Convert inline-ignored-on-legend to text-only test.
- fast/forms/inline-ignored-on-legend-expected.txt: Added.
- fast/forms/inline-ignored-on-legend.html: Changed to text-only.
- platform/mac/fast/forms/inline-ignored-on-legend-expected.checksum: Removed.
- platform/mac/fast/forms/inline-ignored-on-legend-expected.png: Removed.
- platform/mac/fast/forms/inline-ignored-on-legend-expected.txt: Removed.
- 3:26 PM Changeset in webkit [41068] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-18 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 23974: Deque::Remove would be a useful method.
<https://bugs.webkit.org/show_bug.cgi?id=23974>
Add Deque::remove and DequeIteratorBase<T>::operator=.
Why was operator= added? Every concrete iterator (DequeIterator..DequeConstReverseIterator)
was calling DequeIteratorBase::assign(), which called Base::operator=(). Base::operator=()
was not implemented. This went unnoticed because the iterator copy code has been unused.
- wtf/Deque.h: (WTF::Deque<T>::remove): (WTF::DequeIteratorBase<T>::removeFromIteratorsList): (WTF::DequeIteratorBase<T>::operator=): (WTF::DequeIteratorBase<T>::~DequeIteratorBase):
- 2:59 PM Changeset in webkit [41067] by
-
- 6 edits in trunk
Add SPI to get WebKit's custom pointing-hand cursor
WebCore:
Export WebCore::handCursor and Cursor.h
Reviewed by John Sullivan.
- WebCore.base.exp: Added WebCore::handCursor.
- WebCore.xcodeproj/project.pbxproj: Made Cursor.h private.
WebKit/mac:
Add SPI to get WebKit's custom pointing-hand cursor
Reviewed by John Sullivan.
- WebView/WebView.mm: (+[WebView _pointingHandCursor]): Added. Returns the custom pointing-hand cursor that WebKit uses.
- WebView/WebViewPrivate.h: Added +_pointingHandCursor.
- 2:12 PM Changeset in webkit [41066] by
-
- 2 edits in trunk/WebCore
2009-02-18 Ojan Vafai <ojan@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=23992
REGRESSION: crash on windows loading http://www.stickam.com/liveStreams.do
Unable to reduce to a layout test.
- page/Frame.cpp: (WebCore::Frame::contentRenderer):
- 2:07 PM Changeset in webkit [41065] by
-
- 2 edits in trunk/WebCore
2009-02-18 Evan Stade <estade@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23861
Stroke font outlines on chromium linux
TEST=LayoutTests/svg/custom/pointer-events-text.svg
- platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawGlyphs):
- 2:05 PM Changeset in webkit [41064] by
-
- 4 edits in trunk/WebCore
2009-02-18 Evan Stade <estade@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23860
Resync some graphics/skia files with their chromium counterparts
This comes from chromium patches <http://codereview.chromium.org/17633>
and <http://codereview.chromium.org/17454>
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::fillPath):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::addPath): (PlatformContextSkia::currentPath):
- platform/graphics/skia/PlatformContextSkia.h:
- 1:56 PM Changeset in webkit [41063] by
-
- 2 edits in trunk/WebCore
2009-02-18 Gustavo Noronha Silva <Gustavo Noronha Silva>
Unreviewed.
Build fix after r41060.
- GNUmakefile.am:
- 12:19 PM Changeset in webkit [41062] by
-
- 2 edits in trunk/WebKitTools
Rubber-stamped by Alexey Proskuryakov.
Add a few ignores to make-js-test-wrappers.
- Scripts/make-js-test-wrappers:
- 11:20 AM Changeset in webkit [41061] by
-
- 2 edits in trunk/WebCore
2009-02-18 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24005
Add an include to fix Chromium build.
- page/animation/AnimationController.cpp: Add UnusedParam.h include.
- 11:18 AM Changeset in webkit [41060] by
-
- 6 edits in trunk
2009-02-18 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
Fix symbols.filter location, and add other missing files to the
autotools build, so that make dist works.
- GNUmakefile.am:
- 8:45 AM Changeset in webkit [41059] by
-
- 2 edits in trunk/WebCore
2009-02-18 Zan Dobersek <zandobersek@gmail.com>
Rubber-stamped by Holger Hans Peter Freyther.
Allow POST method for local requests.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startGio):
- 8:36 AM Changeset in webkit [41058] by
-
- 3 edits in trunk/WebCore
2009-02-18 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Hans Peter Freyther.
Use KURL in startGio instead of passing a string with the URL, so
that we can handle removing refs and queries more elegantly. This
is fixing more regressions that came from the curl->soup switch.
Original work by Zan Dobersek.
- platform/network/ResourceHandle.h:
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::startGio):
- 7:02 AM Changeset in webkit [41057] by
-
- 2 edits in trunk/WebCore
Implement ResourceHandle::loadResourceSynchronously in ResourceHandleSoup.cpp
The implementation is needed to have synchronous loading, e.g. for
JavaScript interaction. This is fixing various regressions that
came from the curl->soup switch.
- 6:58 AM Changeset in webkit [41056] by
-
- 2 edits in trunk/WebKitTools
2009-02-17 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Alexey Proskuryakov.
Prepend file:// to the test result filename to make
GtkLauncher display the result page.
- Scripts/run-webkit-tests:
- 4:17 AM Changeset in webkit [41055] by
-
- 3 edits in trunk/WebCore
2009-02-18 Xan Lopez <xan@gnome.org>
Reviewed by Mark Rowe.
Based on a patch by Bo Yang <techrazy.yang@gmail.com>
Make the cursor cache global, that's all we really need and
otherwise we can miss cursor transitions in some situations (see
the bug for one testcase). Also remove some now useless code.
- platform/Widget.h:
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::setCursor):
Feb 17, 2009:
- 9:48 PM Changeset in webkit [41054] by
-
- 2 edits in trunk/WebCore
Windows build fix
- loader/FrameLoader.cpp: (WebCore::toPlugInElement): Don't rely on #if being processed before ASSERT.
- 8:17 PM Changeset in webkit [41053] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed failure in js1_5/Regress/regress-168347.js, as seen on the Oliver
bot.
Technically, both behaviors are OK, but we might as well keep this test
passing.
- runtime/FunctionPrototype.cpp: (JSC::insertSemicolonIfNeeded): No need to add a trailing semicolon after a trailing '}', since '}' ends a block, indicating the end of a statement.
- 8:03 PM Changeset in webkit [41052] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-17 Geoffrey Garen <ggaren@apple.com>
Build fix.
- runtime/FunctionPrototype.cpp:
- 7:36 PM Changeset in webkit [41051] by
-
- 2 edits in trunk/JavaScriptCore
Add assertion to guard against oversized pc relative calls.
Reviewed by Geoff Garen
- 6:15 PM Changeset in webkit [41050] by
-
- 4 edits in tags/Safari-6530.0.1
Versioning.
- 6:14 PM Changeset in webkit [41049] by
-
- 2 edits in tags/Safari-6530.0.1/JavaScriptCore
Disable the JIT for x86_64 until <rdar://problem/6594577> is resolved.
Rubber-stamped by Oliver Hunt.
- wtf/Platform.h:
- 5:20 PM Changeset in webkit [41048] by
-
- 1 copy in tags/Safari-6530.0.1
New tag.
- 4:50 PM Changeset in webkit [41047] by
-
- 4 edits in trunk/WebCore
2009-02-17 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 23977: Unnecessary timer related headers in files.
<https://bugs.webkit.org/show_bug.cgi?id=23977>
No observable change in behavior, so no test.
- dom/Document.cpp:
- dom/WorkerRunLoop.cpp:
- dom/WorkerRunLoop.h:
- 4:21 PM Changeset in webkit [41046] by
-
- 14 edits in trunk
WebCore:
2009-02-17 Peter Abrahamsen <rainhead@gmail.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=23958
<rdar://problem/6587815>
Updated XMLHttpRequest with new header names from the latest Access
Control draft: http://www.w3.org/TR/access-control/
- Access-Control-Origin becomes Access-Control-Allow-Origin
- Access-Control-Credentials becomes Access-Control-Allow-Credentials
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::accessControlCheck):
LayoutTests:
2009-02-17 Peter Abrahamsen <rainhead@gmail.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=23958
<rdar://problem/6587815>
Updated XMLHttpRequests tests to match the newest Access Control draft.
- http/tests/security/originHeader/resources/print-origin.cgi:
- http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
- http/tests/xmlhttprequest/resources/access-control-basic-allow-print-headers.cgi:
- http/tests/xmlhttprequest/resources/access-control-basic-allow-star.cgi:
- http/tests/xmlhttprequest/resources/access-control-basic-allow.cgi:
- http/tests/xmlhttprequest/resources/access-control-basic-get-fail-non-simple.cgi:
- http/tests/xmlhttprequest/resources/access-control-basic-non-get-allow.cgi:
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php:
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php:
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php:
- http/tests/xmlhttprequest/resources/access-control-basic-whitelist-response-headers.cgi:
- 4:14 PM Changeset in webkit [41045] by
-
- 5 edits3 adds in trunk
2009-02-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed <rdar://problem/6595040> REGRESSION: http://www.amnestyusa.org/
fails to load.
amnestyusa.org uses the Optimist JavaScript library, which adds event
listeners by concatenating string-ified functions. This is only sure to
be syntactically valid if the string-ified functions end in semicolons.
- parser/Lexer.cpp: (JSC::Lexer::isWhiteSpace):
- parser/Lexer.h: (JSC::Lexer::isWhiteSpace): (JSC::Lexer::isLineTerminator): Added some helper functions for examining whitespace.
- runtime/FunctionPrototype.cpp: (JSC::appendSemicolonIfNeeded): (JSC::functionProtoFuncToString): When string-ifying a function, insert a semicolon in the last non-whitespace position, if one doesn't already exist.
LayoutTests:
2009-02-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Test for <rdar://problem/6595040> REGRESSION: http://www.amnestyusa.org/
fails to load.
- fast/js/function-toString-semicolon-insertion-expected.txt: Added.
- fast/js/function-toString-semicolon-insertion.html: Added.
- fast/js/resources/function-toString-semicolon-insertion.js: Added. (compileAndSerialize):
- 2:59 PM Changeset in webkit [41044] by
-
- 2 edits in trunk/WebCore
wx build fix. Add missing constructor used for empty values.
- 2:16 PM Changeset in webkit [41043] by
-
- 3 edits in trunk/WebCore
2009-02-17 Antti Koivisto <Antti Koivisto>
Reviewed by Dave Kilzer.
<rdar://problem/6592446> dynamically updating page doesn't seem to draw when updated
Need update after callback.
- bindings/js/JSCustomPositionCallback.cpp: (WebCore::JSCustomPositionCallback::handleEvent):
- bindings/js/JSCustomPositionErrorCallback.cpp: (WebCore::JSCustomPositionErrorCallback::handleEvent):
- 12:43 PM Changeset in webkit [41042] by
-
- 19 edits2 adds in trunk
2009-02-17 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=23917
Allow a WebKit plug-in to act as a proxy for the <audio> and <video>
element.
- DerivedSources.make: add media element proxy exports to .exp file when feature is defined.
- WebCore.VideoProxy.exp: New, define the informal protocol exported by a media element proxy.
- WebCore.xcodeproj/project.pbxproj: Add MediaPlayerProxy.h.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_needWidgetUpdate. (WebCore::HTMLMediaElement::attributeChanged): Don't detach+attach when PLUGIN_PROXY_FOR_VIDEO, the proxy plug-in handles the poster frame. (WebCore::HTMLMediaElement::rendererIsNeeded): New logic for PLUGIN_PROXY_FOR_VIDEO. (WebCore::HTMLMediaElement::createRenderer): Create RenderPartObject when PLUGIN_PROXY_FOR_VIDEO. (WebCore::HTMLMediaElement::attach): Set m_needWidgetUpdate when PLUGIN_PROXY_FOR_VIDEO (WebCore::HTMLMediaElement::load): Don't reallocate MediaPlayer when PLUGIN_PROXY_FOR_VIDEO, we keep the same plug-in for the life of the element. (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): update m_networkState when media player network state changes to EMPTY, otherwise we can get out of sync with engine. (WebCore::HTMLMediaElement::defaultEventHandler): pass event to widget when PLUGIN_PROXY_FOR_VIDEO (WebCore::HTMLMediaElement::deliverNotification): New, deliver notification from proxy plug-in to media player. (WebCore::HTMLMediaElement::setMediaPlayerProxy): New, pass proxy object to media player. (WebCore::HTMLMediaElement::initialURL): New, return the url from the "src" attr or the appropriate <source> element to be used as the initial url for the proxy. (WebCore::HTMLMediaElement::finishParsingChildren): New, allocate MediaPlayer and update widget.
- html/HTMLMediaElement.h: Declare new methods for proxy, add m_needWidgetUpdate. (WebCore::HTMLMediaElement::setNeedWidgetUpdate):
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::attach): Poster image is handled by proxy when PLUGIN_PROXY_FOR_VIDEO. (WebCore::HTMLVideoElement::parseMappedAttribute): Ditto.
- html/HTMLVideoElement.h:
- loader/FrameLoader.cpp: (WebCore::toPlugInElement): Allow cast if element is <video> or <audio>
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): Remove white space. (WebCore::MediaPlayer::setPoster): New, forward call to private player. (WebCore::MediaPlayer::deliverNotification): Ditto. (WebCore::MediaPlayer::setMediaPlayerProxy): Ditto.
- platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::mediaPlayerClient):
- platform/graphics/mac/MediaPlayerProxy.h: New, defines media player proxy interface.
- rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): Change constructor to take Element* instead of Node* as a non-element node doesn't need a renderer
- rendering/RenderPart.h: Ditto.
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::RenderPartObject): Ditto. (WebCore::RenderPartObject::updateWidget): Package params for proxy plug-in when element is <video> or <audio>.
- rendering/RenderPartObject.h:
2009-02-17 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=23917
Allow a WebKit plug-in to act as a proxy for the <audio> and <video>
element.
- Plugins/WebPluginContainerPrivate.h:
- Plugins/WebPluginController.mm: (mediaProxyClient): New, cast to HTMLMediaElement if it is a video or audio element (-[WebPluginController _setMediaPlayerProxy:forElement:]): New, pass proxy to HTMLMediaElement (-[WebPluginController _postMediaPlayerNotification:forElement:]): New, deliver event to HTMLMediaElement
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Don't allow a media player proxy plug-in to be chosen by file extension, only want a match for the new MIME type proxy plug-ins should have.
- 11:33 AM Changeset in webkit [41041] by
-
- 20 edits4 adds2 deletes in trunk
WebCore:
2009-02-17 David Hyatt <hyatt@apple.com>
Reviewed by Eric Seidel
Don't allow legends to be anything but display:block.
Added fast/forms/inline-ignored-on-legend.html
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- css/html4.css:
- html/HTMLLegendElement.cpp:
- html/HTMLLegendElement.h:
- rendering/RenderLegend.cpp: Removed.
- rendering/RenderLegend.h: Removed.
- wml/WMLInsertedLegendElement.cpp:
- wml/WMLInsertedLegendElement.h:
LayoutTests:
2009-02-17 David Hyatt <hyatt@apple.com>
Reviewed by Eric Seidel
Don't allow legends to be anything but display:block.
- fast/forms/inline-ignored-on-legend.html: Added.
- platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
- platform/mac/fast/borders/fieldsetBorderRadius-expected.txt:
- platform/mac/fast/forms/006-expected.txt:
- platform/mac/fast/forms/007-expected.txt:
- platform/mac/fast/forms/fieldset-align-expected.txt:
- platform/mac/fast/forms/float-before-fieldset-expected.txt:
- platform/mac/fast/forms/inline-ignored-on-legend-expected.checksum: Added.
- platform/mac/fast/forms/inline-ignored-on-legend-expected.png: Added.
- platform/mac/fast/forms/inline-ignored-on-legend-expected.txt: Added.
- platform/mac/fast/invalid/residual-style-expected.txt:
- platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
- 10:14 AM Changeset in webkit [41040] by
-
- 3 edits in trunk/WebCore
Reviewed by Simon Fraser.
https://bugs.webkit.org/attachment.cgi?id=27666
Fix Chromium build build: forgotten include in RenderObject, sync
RenderTheme to the recent changes in RenderObject.
- rendering/RenderObject.cpp:
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::updatePressedState):
- 8:52 AM Changeset in webkit [41039] by
-
- 2 edits in trunk/WebKit/gtk
2009-02-17 Xan Lopez <xan@gnome.org>
Rubber-stamped by Alexey Proskuryakov.
Restoring change landed in r40715, which was accidentally undone
by r40918.
- webkit/webkitwebframe.cpp:
- 4:43 AM Changeset in webkit [41038] by
-
- 2 edits in trunk
2009-02-17 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=23939
Release build being built with debugging symbols
- configure.ac: Revert change done in revision 40790, since we already have a AC_PROG_CXX macro call as part of WEBKIT_INIT
- 4:32 AM Changeset in webkit [41037] by
-
- 2 edits in trunk/WebCore
2009-02-17 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22966
crash when destroying a webview that opened a page containing <script>
tags
Fix m_group being set to 0 instead of to m_singlePageGroup when
GroupName is set to empty
- page/Page.cpp: (WebCore::Page::setGroupName):
Feb 16, 2009:
- 7:38 PM Changeset in webkit [41036] by
-
- 2 edits in trunk/JavaScriptCore
Roll out r41022 as it breaks qt and gtk builds
- 7:38 PM Changeset in webkit [41035] by
-
- 3 edits in trunk/WebCore
2009-02-16 Beth Dakin <Beth Dakin>
Reviewed by Sam Weinig.
Fix for <rdar://problem/6386623>
I made m_numParsedProperties and m_maxParsedProperties unsigned
instead of int, and then added an early return from addPropery() if
m_maxParsedProperties exceeds the max value.
- css/CSSParser.cpp: (WebCore::CSSParser::addProperty): (WebCore::CSSParser::rollbackLastProperties): (WebCore::CSSParser::clearProperties): (WebCore::CSSParser::createFontFaceRule): (WebCore::CSSParser::deleteFontFaceOnlyValues):
- css/CSSParser.h:
- 7:36 PM Changeset in webkit [41034] by
-
- 7 edits1 add3 deletes in trunk
WebCore:
2009-02-16 Justin Garcia <justin.garcia@apple.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=16309
HTML5: The third execCommand argument for insert{un}orderedlist should be ignored
When we originally implemented this command, MSDN documentation said that IE set the
id attribute of inserted lists to the third argument to execCommand, but IE doesn't
do this nor do any other browsers.
- editing/EditorCommand.cpp: (WebCore::executeInsertOrderedList): (WebCore::executeInsertUnorderedList):
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
- editing/InsertListCommand.cpp: (WebCore::InsertListCommand::insertList): (WebCore::InsertListCommand::InsertListCommand): (WebCore::InsertListCommand::doApply):
- editing/InsertListCommand.h: (WebCore::InsertListCommand::create):
LayoutTests:
2009-02-16 Justin Garcia <justin.garcia@apple.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=16309
HTML5: The third execCommand argument for insert{un}orderedlist should be ignored
- editing/execCommand/insert-list-with-id-expected.txt: Added.
- editing/execCommand/insert-list-with-id.html:
- platform/mac/editing/execCommand/insert-list-with-id-expected.checksum: Removed.
- platform/mac/editing/execCommand/insert-list-with-id-expected.png: Removed.
- platform/mac/editing/execCommand/insert-list-with-id-expected.txt: Removed.
- 6:59 PM Changeset in webkit [41033] by
-
- 2 edits in trunk/WebKitTools
2009-02-16 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Adam Roben
Actually use the installation prefix defined in WebKitInstallationPrefix,
in autotools builds.
- Scripts/webkitdirs.pm:
- 6:00 PM Changeset in webkit [41032] by
-
- 4 edits in branches/Safari-6528
Versioning.
- 5:59 PM Changeset in webkit [41031] by
-
- 1 copy in tags/Safari-6528.15.1
New tag.
- 5:56 PM Changeset in webkit [41030] by
-
- 4 edits in branches/Safari-6528
Versioning.
- 5:56 PM Changeset in webkit [41029] by
-
- 3 edits4 adds in branches/Safari-6528
Merge r41027.
- 4:40 PM Changeset in webkit [41028] by
-
- 5 edits in trunk
2009-02-16 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Fix for <rdar://problem/6468156>
REGRESSION (r36779): Adding link, images, flash in TinyMCE blocks entire page (21382)
No performance regression.
- runtime/Arguments.cpp: (JSC::Arguments::fillArgList): Add codepath for when the "length" property has been overridden.
LayoutTests:
2009-02-16 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add tests for <rdar://problem/6468156>
REGRESSION (r36779): Adding link, images, flash in TinyMCE blocks entire page (21382)
- fast/js/function-apply-expected.txt:
- fast/js/resources/function-apply.js: Add cases covering setting arugments.length and Array.length explicitly or implicitly using Array.prototype.unshift.
- 3:56 PM Changeset in webkit [41027] by
-
- 3 edits1 copy3 adds in trunk
WebCore:
Reviewed by Geoffrey Garen.
- fix <rdar://problem/6561077> REGRESSION (r39634): Unable to select an item in stocks widget with the mouse
Test: platform/mac/fast/events/pointer-events-dashboard.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Do not apply the pointer-events property in Dashboard backwards compatibility mode, in order to work around misuse of that property by the Stocks widget.
LayoutTests:
Reviewed by Geoffrey Garen.
- test for <rdar://problem/6561077> REGRESSION (r39634): Unable to select an item in stocks widget with the mouse
- platform/mac/fast/events/pointer-events-dashboard-expected.checksum: Added.
- platform/mac/fast/events/pointer-events-dashboard-expected.png: Added.
- platform/mac/fast/events/pointer-events-dashboard-expected.txt: Added.
- platform/mac/fast/events/pointer-events-dashboard.html: Copied from LayoutTests/fast/events/pointer-events.html.
- 3:33 PM Changeset in webkit [41026] by
-
- 4 edits3 adds3 deletes in trunk
WebCore:
2009-02-16 Justin Garcia <justin.garcia@apple.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=15381
execCommand justify modifies the contentEditable node
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Avoid modifying not just the body element, but any root editable element.
LayoutTests:
2009-02-16 Justin Garcia <justin.garcia@apple.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=15381
execCommand justify modifies the contentEditable node
- editing/execCommand/15381-expected.txt: Added.
- editing/execCommand/15381.html: Added.
Made this test cross platform and changed it to reflect the fix:
- editing/execCommand/5062376-expected.txt: Added.
- editing/execCommand/5062376.html:
- platform/mac/editing/execCommand/5062376-expected.checksum: Removed.
- platform/mac/editing/execCommand/5062376-expected.png: Removed.
- platform/mac/editing/execCommand/5062376-expected.txt: Removed.
- 3:19 PM Changeset in webkit [41025] by
-
- 3 edits2 adds in trunk
Bug 23979: AX: alt tag not returned for <input type="image">
https://bugs.webkit.org/show_bug.cgi?id=23979
- 2:36 PM Changeset in webkit [41024] by
-
- 2 edits in tags/Safari-6530/JavaScriptCore
Merge r41023.
- 2:23 PM Changeset in webkit [41023] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- 2:15 PM Changeset in webkit [41022] by
-
- 2 edits in trunk/JavaScriptCore
Bug 23787: Allow JIT to generate SSE2 code if using GCC
<https://bugs.webkit.org/show_bug.cgi?id=23787>
Provided by Csaba Osztrogonac
Reviewed by Oliver Hunt
GCC version of the cpuid check.
- 2:06 PM Changeset in webkit [41021] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
The ref data is not properly set unless we use the CreateMatrix function.
https://bugs.webkit.org/show_bug.cgi?id=23978
- 1:57 PM Changeset in webkit [41020] by
-
- 4 edits in trunk/WebCore
Reviewed by John Sullivan.
- fix <rdar://problem/6516829> FontPlatformData constructor passes NULL to CTFontCopyGraphicsFont and CTFontGetPlatformFont
- platform/graphics/FontCache.cpp: (WebCore::FontDataCacheKeyTraits::emptyValue): Changed to use the FontPlatformData(float, bool, bool) constructor.
- platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::createFontPlatformData): Changed to pass a valid NSFont to the FontPlatformData constructor, instead of implicitly passing 0 and then calling setFont().
- platform/graphics/mac/FontPlatformData.h: Made the NSFont parameter of the constructor mandatory.
- 2:57 AM Changeset in webkit [41019] by
-
- 2 edits in trunk/WebKit/qt
2009-02-16 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Avoid loading plugins when they're disabled in the settings.
Feb 15, 2009:
- 1:39 PM Changeset in webkit [41018] by
-
- 5 edits in trunk/WebCore
Move duplicate caretWidth constants to RenderObject.h
Reviewed by Dan Bernstein.
No test since no change in behavior.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::localCaretRect): Removed caretWidth.
- rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect): Ditto.
- rendering/RenderObject.h: Added caretWidth definition.
- rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect): Removed caretWidth.
Feb 14, 2009:
- 8:39 AM Changeset in webkit [41017] by
-
- 2 edits in trunk/WebCore
2009-02-14 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23955
V8HTMLPlugInCustom returns undefined, which fools interceptors.
- bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): Use deferToInterceptor() return value. (WebCore::NAMED_PROPERTY_SETTER): Ditto. (WebCore::INDEXED_PROPERTY_GETTER): Ditto. (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
Feb 13, 2009:
- 6:17 PM Changeset in webkit [41016] by
-
- 1 edit1 add in trunk/WebCore
2009-02-13 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23954
Add V8 custom bindings for CanvasRenderingContext2D.
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Added. (WebCore::toV8): (WebCore::toCanvasStyle): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
- 6:05 PM Changeset in webkit [41015] by
-
- 4 edits in branches/Safari-6528
Versioning.
- 6:05 PM Changeset in webkit [41014] by
-
- 1 copy in tags/Safari-6528.15
New tag.
- 5:48 PM Changeset in webkit [41013] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-13 Adam Treat <adam.treat@torchmobile.com>
Reviewed by George Staikos.
Don't depend on 'initializeThreading()' to come before a call to 'isMainThread()'
as QtWebKit only calls 'initializeThreading()' during QWebPage construction.
A client app may well make a call to QWebSettings::iconForUrl() for instance
before creating a QWebPage and that call to QWebSettings triggers an
ASSERT(isMainThread()) deep within WebCore.
- wtf/ThreadingQt.cpp: (WTF::isMainThread):
- 5:19 PM Changeset in webkit [41012] by
-
- 3 edits in branches/Safari-6528/JavaScriptCore
Merge r40975.
- 5:19 PM Changeset in webkit [41011] by
-
- 2 edits in branches/Safari-6528/JavaScriptCore
Merge r40945.
- 5:08 PM Changeset in webkit [41010] by
-
- 3 edits in branches/Safari-6528/JavaScriptCore
Merge r41000.
- 5:08 PM Changeset in webkit [41009] by
-
- 2 edits in branches/Safari-6528/JavaScriptCore
Merge r40995.
- 5:08 PM Changeset in webkit [41008] by
-
- 13 edits3 adds in branches/Safari-6528
Merge r40993.
- 5:08 PM Changeset in webkit [41007] by
-
- 5 edits in branches/Safari-6528/JavaScriptCore
Merge r40968.
- 5:08 PM Changeset in webkit [41006] by
-
- 2 edits in branches/Safari-6528/JavaScriptCore
Merge r40967.
- 5:08 PM Changeset in webkit [41005] by
-
- 2 edits in branches/Safari-6528/JavaScriptCore
Merge r40937.
- 5:08 PM Changeset in webkit [41004] by
-
- 2 edits in branches/Safari-6528/JavaScriptCore
Merge r40935.
- 5:08 PM Changeset in webkit [41003] by
-
- 2 edits in branches/Safari-6528/JavaScriptCore
Merge r40932.
- 5:08 PM Changeset in webkit [41002] by
-
- 3 edits in branches/Safari-6528/WebKit/mac
Merge r40940.
- 5:08 PM Changeset in webkit [41001] by
-
- 2 edits in branches/Safari-6528/WebKit/mac
Merge r40920.
- 5:00 PM Changeset in webkit [41000] by
-
- 3 edits in trunk/JavaScriptCore
2009-02-13 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
Some data in the instruction stream is potentially uninitialized - fix this.
Change the OperandTypes constructor so that uninitialized memory in the int
is zeroed, and modify the Instruction constructor taking an Opcode so that
if !HAVE(COMPUTED_GOTO) (i.e. when Opcode is an enum, and is potentially only
a byte) it zeros the Instruction first before writing the opcode.
- bytecode/Instruction.h: (JSC::Instruction::Instruction):
- parser/ResultType.h: (JSC::OperandTypes::OperandTypes):
- 4:46 PM Changeset in webkit [40999] by
-
- 2 edits in trunk/LayoutTests/platform/mac/editing/deleting
Fix failing layout pixel test so bdash doesn't come to my house in the middle of the night and beat me up.
- 4:41 PM Changeset in webkit [40998] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog.
- 4:35 PM Changeset in webkit [40997] by
-
- 2 edits in trunk/WebCore
2009-02-13 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6583187>
- page/NavigatorBase.cpp: Handle PPC64 and X86_64 as well.
- 4:04 PM Changeset in webkit [40996] by
-
- 5 edits in trunk/WebKit/mac
2009-02-13 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
<rdar://problem/6584834> ESPN radio live stream link hangs Safari
When a plug-in invokes JavaScript code that will destroy the plug-in, we need to
defer destruction until we're done executing the script.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::PluginDestroyDeferrer::PluginDestroyDeferrer): (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer): Add a simple RAII object for deferring destruction of the plug-in instance.
(WKPCEvaluate):
(WKPCInvoke):
(WKPCInvokeDefault):
(WKPCConstruct):
(WKPCGetProperty):
(WKPCSetProperty):
(WKPCRemoveProperty):
(WKPCHasProperty):
(WKPCHasMethod):
Use the PluginDestroyDeferrer.
- Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::pluginID): Assert that the plug-in ID is not 0 here.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Initialize the call depth.
(WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy):
Set the plug-in ID to 0 to aid debugging.
(WebKit::NetscapePluginInstanceProxy::willCallPluginFunction):
Increment the call depth.
(WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):
Decrement the call depth, if it's 0 and we should stop the plug-in, do so.
(WebKit::NetscapePluginInstanceProxy::shouldStop):
If we're called this with a non-zero call depth, set shouldStopSoon to true.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView shouldStop]): Call the proxy.
- 4:01 PM Changeset in webkit [40995] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-13 Geoffrey Garen <ggaren@apple.com>
Build fix for non_JIT platforms.
- bytecode/CodeBlock.h: (JSC::CodeBlock::setIsNumericCompareFunction): (JSC::CodeBlock::isNumericCompareFunction):
- 3:56 PM Changeset in webkit [40994] by
-
- 2 edits in trunk/WebCore
2009-02-13 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
Fix broken tokenizer regression test that reflected a lifetime bug
in the document.write optimization. The test failure was trivial to
reproduce in COLLECT_ON_EVERY_ALLOCATION mode.
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::documentWrite): Convert strings to String rather than passing the pointer and length to SegmentedString. The optimization is thus mostly gone. However, there are two ways to bring it back: 1) Apply the patch that makes UString and String share the same buffers. 2) Add a UString feature to SegmentedString; simple to do but might risk slowing down normal document parsing.
- 3:28 PM Changeset in webkit [40993] by
-
- 13 edits3 adds in trunk
2009-02-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Fixed <rdar://problem/6584057> Optimize sort by JS numeric comparison
function not to run the comparison function
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h: (JSC::CodeBlock::setIsNumericCompareFunction): (JSC::CodeBlock::isNumericCompareFunction): Added the ability to track whether a CodeBlock performs a sort-like numeric comparison.
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): Set the isNumericCompareFunction bit after compiling.
- parser/Nodes.cpp: (JSC::FunctionBodyNode::emitBytecode): Fixed a bug that caused us to codegen an extra return at the end of all functions (eek!), since this made it harder / weirder to detect the numeric comparison pattern in bytecode.
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSort): Use the isNumericCompareFunction bit to do a faster sort if we can.
- runtime/FunctionConstructor.cpp: (JSC::extractFunctionBody): (JSC::constructFunction):
- runtime/FunctionConstructor.h: Renamed and exported extractFunctionBody for use in initializing lazyNumericCompareFunction.
- runtime/JSArray.cpp: (JSC::compareNumbersForQSort): (JSC::compareByStringPairForQSort): (JSC::JSArray::sortNumeric): (JSC::JSArray::sort):
- runtime/JSArray.h: Added a fast numeric sort. Renamed ArrayQSortPair to be more specific since we do different kinds of qsort now.
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::numericCompareFunction): (JSC::JSGlobalData::ClientData::~ClientData):
- runtime/JSGlobalData.h: Added helper data for computing the isNumericCompareFunction bit.
LayoutTests:
2009-02-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added a test for an edge case in <rdar://problem/6584057>.
- fast/js/resources/sort-non-numbers.js: Added.
- fast/js/sort-non-numbers.html: Added.
- fast/js/sort-non-numbers-expected.txt: Added.
- 2:49 PM Changeset in webkit [40992] by
-
- 2 edits in trunk/WebCore
2009-02-13 Adam Treat <adam.treat@torchmobile.com>
Caught by Darin Adler.
No reason to check m_tokenizer twice for 0 in a row.
- dom/Document.cpp: (WebCore::Document::write):
- 1:49 PM Changeset in webkit [40991] by
-
- 2 edits in trunk/WebCore
2009-02-13 Lyon Chen <lyon.chen@torchmobile.com>
Reviewed by Dave Hyatt.
Take into account y() + height() when calculating getLowerRightCorner.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::getLowerRightCorner):
- 1:17 PM Changeset in webkit [40990] by
-
- 3 edits in trunk/WebCore
2009-02-13 Antti Koivisto <Antti Koivisto>
Reviewed by Dave Hyatt.
Most of this code was in RenderBox, restore the copyright lines.
- rendering/RenderBoxModelObject.cpp:
- rendering/RenderBoxModelObject.h:
- 1:07 PM Changeset in webkit [40989] by
-
- 2 edits in trunk/WebCore
2009-02-13 David Hyatt <hyatt@apple.com>
Get rid of printBoxDecorations, since it is dead code.
Reviewed by Dan Bernstein
- rendering/RenderObject.h:
- 1:01 PM Changeset in webkit [40988] by
-
- 4 edits in trunk/WebCore
2009-02-13 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23952
Add Document::write overload which takes a SegmentedString since this
is what the tokenizer expects anyway. Modified JSHTMLDocument so it once
again calls Document::write instead of injecting the string directly into
the tokenizer. This ensures that all document.write's are funneled through
one method again, but should still be just as fast for JSHTMLDocumentCustom.
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::documentWrite):
- dom/Document.cpp: (WebCore::Document::write):
- dom/Document.h:
- 12:38 PM Changeset in webkit [40987] by
-
- 9 edits in trunk/WebCore
2009-02-13 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser
Remove updateWidgetPosition on RenderObject. Change RenderView's set of widgets
to have a tighter type: RenderWidget instead of RenderObject. Devirtualize
updateWidgetPosition, since all RenderWidgets (except for applets) are now
RenderParts also.
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderPart.cpp:
- rendering/RenderPart.h:
- rendering/RenderView.cpp: (WebCore::RenderView::updateWidgetPositions): (WebCore::RenderView::addWidget): (WebCore::RenderView::removeWidget):
- rendering/RenderView.h:
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::updateWidgetPosition):
- rendering/RenderWidget.h:
- 12:11 PM Changeset in webkit [40986] by
-
- 2 edits in trunk/WebKit
2009-02-13 Darin Adler <Darin Adler>
- StringsNotToBeLocalized.txt: Updated for recent changes.
- 12:04 PM Changeset in webkit [40985] by
-
- 3 edits in trunk/WebCore
2009-02-13 David Hyatt <hyatt@apple.com>
Reviewed by Eric Seidel
Remove isEditable() on RenderObject. It is dead code.
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- 11:49 AM Changeset in webkit [40984] by
-
- 13 edits in trunk/WebCore
2009-02-13 David Hyatt <hyatt@apple.com>
Reviewed by Eric Seidel
Add isTextControl() to RenderObject. Patch call sites thats asked isTextField() isTextArea() to just use isTextControl() instead.
Add a toRenderTextControl converter for doing checked casting to RenderTextControls.
- dom/Document.cpp: (WebCore::Document::setFocusedNode):
- dom/InputElement.cpp: (WebCore::InputElement::updateSelectionRange):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):
- editing/TextIterator.cpp: (WebCore::TextIterator::handleReplacedElement):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selectionStart): (WebCore::HTMLInputElement::selectionEnd): (WebCore::HTMLInputElement::setSelectionStart): (WebCore::HTMLInputElement::setSelectionEnd): (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::selection):
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selectionStart): (WebCore::HTMLTextAreaElement::selectionEnd): (WebCore::HTMLTextAreaElement::setSelectionStart): (WebCore::HTMLTextAreaElement::setSelectionEnd): (WebCore::HTMLTextAreaElement::select): (WebCore::HTMLTextAreaElement::setSelectionRange): (WebCore::HTMLTextAreaElement::appendFormData): (WebCore::HTMLTextAreaElement::updateValue): (WebCore::HTMLTextAreaElement::selection):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isNativeTextControl): (WebCore::AccessibilityRenderObject::text): (WebCore::AccessibilityRenderObject::selectedText): (WebCore::AccessibilityRenderObject::selectedTextRange): (WebCore::AccessibilityRenderObject::setSelectedTextRange): (WebCore::AccessibilityRenderObject::visiblePositionForIndex): (WebCore::AccessibilityRenderObject::indexForVisiblePosition): (WebCore::AccessibilityRenderObject::observableObject):
- page/Frame.cpp: (WebCore::Frame::notifyRendererOfSelectionChange):
- rendering/RenderObject.h: (WebCore::RenderObject::isTextControl): (WebCore::objectIsRelayoutBoundary):
- rendering/RenderTextControl.h: (WebCore::RenderTextControl::isTextControl): (WebCore::toRenderTextControl):
- rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerTextElement::defaultEventHandler):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::select): (WebCore::WMLInputElement::defaultEventHandler): (WebCore::WMLInputElement::isConformedToInputMask):
- 11:18 AM Changeset in webkit [40983] by
-
- 5 edits in trunk/WebCore
2009-02-13 David Hyatt <hyatt@apple.com>
Get rid of isEdited/setEdited on RenderObject. Devirtualize isEdited/setEdited on RenderTextControl.
Callers were already asking if the renderer was a text field (or a text area), so it was especially
pointless to waste a second virtual function call after making one just to determine the object type.
Reviewed by Simon Fraser
- dom/Document.cpp: (WebCore::Document::setFocusedNode):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
- rendering/RenderObject.h:
- rendering/RenderTextControl.h: (WebCore::RenderTextControl::isEdited): (WebCore::RenderTextControl::setEdited):
- 11:04 AM Changeset in webkit [40982] by
-
- 5 edits in trunk/WebCore
2009-02-13 Scott Violet <sky@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23934
Skia platform doesn't render text decoration shadows.
Makes Skia render text decoration shadows correctly. We weren't
preparing the SkPaint correctly and didn't have a couple of checks
CG has. Additionally makes the fillColor/strokeColor methods
consistent.
This behavior is covered by existing layout tests (see bug for list).
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLineForText):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::effectiveFillColor): (PlatformContextSkia::effectiveStrokeColor):
- platform/graphics/skia/PlatformContextSkia.h:
- 11:01 AM Changeset in webkit [40981] by
-
- 4 edits in trunk/WebCore
2009-02-12 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23944
KURLGoogle's pre-parsed canonicalSpec constructor should take a CString
- platform/KURL.h:
- platform/KURLGoogle.cpp: (WebCore::KURLGooglePrivate::setUtf8): (WebCore::KURLGooglePrivate::setAscii): (WebCore::KURLGooglePrivate::init): (WebCore::KURLGooglePrivate::replaceComponents): (WebCore::KURL::KURL):
- platform/KURLGooglePrivate.h:
- 10:17 AM Changeset in webkit [40980] by
-
- 6 edits in trunk/WebCore
2009-02-13 David Hyatt <hyatt@apple.com>
Remove leftmost/rightmost/lowestPosition from RenderObject. They only need to be called on boxes.
Reviewed by Dan Bernstein
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::computeScrollDimensions):
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::lowestPosition): (WebCore::RenderMedia::rightmostPosition): (WebCore::RenderMedia::leftmostPosition):
- rendering/RenderObject.h:
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition):
- 9:49 AM Changeset in webkit [40979] by
-
- 2 edits in trunk/WebCore
2009-02-12 Simon Fraser <Simon Fraser>
Fix build with ACCELERATED_COMPOSITING turned on.
toRenderBox()->x() asserts for a layer on an inline; use
m_owningLayer->renderBoxX() instead.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
- 8:24 AM Changeset in webkit [40978] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-13 Darin Adler <Darin Adler>
- Configurations/JavaScriptCore.xcconfig: Undo accidental commit of this file.
- 8:21 AM Changeset in webkit [40977] by
-
- 4 edits in trunk/LayoutTests
Reviewed by Adam Roben.
Fixed 3 more test cases
- platform/win/fast/css/computed-style-expected.txt:
- platform/win/fast/css/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 8:20 AM Changeset in webkit [40976] by
-
- 4 edits in trunk/WebCore
2009-02-12 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Speed up document.write a bit.
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::documentWrite): Added. Uses SegmentedString to avoid conversion from UString to String and to avoid appending strings. Also added code to handle newlines efficiently. (WebCore::JSHTMLDocument::write): Changed to use documentWrite. (WebCore::JSHTMLDocument::writeln): Ditto.
- dom/Document.cpp: (WebCore::Document::prepareToWrite): Added. Refactored the initialization part of write into a separate function for use in the JavaScript binding. (WebCore::Document::write): Changed to call prepareToWrite.
- dom/Document.h: Added declaration for prepareToWrite.
- 8:16 AM Changeset in webkit [40975] by
-
- 4 edits in trunk/JavaScriptCore
2009-02-12 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt and Alexey Proskuryakov.
Speed up a couple string functions.
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncIndexOf): Added a fast path for cases where the second argument is either missing or an integer. (JSC::stringProtoFuncBig): Use jsNontrivialString since the string is guaranteed to be 2 or more characters long. (JSC::stringProtoFuncSmall): Ditto. (JSC::stringProtoFuncBlink): Ditto. (JSC::stringProtoFuncBold): Ditto. (JSC::stringProtoFuncItalics): Ditto. (JSC::stringProtoFuncStrike): Ditto. (JSC::stringProtoFuncSub): Ditto. (JSC::stringProtoFuncSup): Ditto. (JSC::stringProtoFuncFontcolor): Ditto. (JSC::stringProtoFuncFontsize): Make the fast path Sam recently added even faster by avoiding all but the minimum memory allocation. (JSC::stringProtoFuncAnchor): Use jsNontrivialString. (JSC::stringProtoFuncLink): Added a fast path.
- runtime/UString.cpp: (JSC::UString::find): Added a fast path for single-character search strings.
- 7:53 AM Changeset in webkit [40974] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Simon Fraser.
Fixed 2 more test cases (mac specific)
- 6:45 AM Changeset in webkit [40973] by
-
- 5 edits in trunk/WebKit/qt
2009-02-13 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Nikolas Zimmermann.
https://bugs.webkit.org/show_bug.cgi?id=23738
Expose the url elements target frame string. This is the sister function
to the existing linkTargetFrame which returns the QWebFrame*. When the
linkTargetFrame is 0 it is useful to know what the target was to be.
- Api/qwebframe.cpp: (QWebHitTestResultPrivate::QWebHitTestResultPrivate): (QWebHitTestResult::linkTarget):
- Api/qwebframe.h:
- Api/qwebframe_p.h:
- tests/qwebframe/tst_qwebframe.cpp:
- 5:19 AM ApplicationsGtk edited by
- Update the correct URL for "Evolution RSS Reader Plugin" (diff)
- 4:02 AM Changeset in webkit [40972] by
-
- 2 edits in trunk/WebKit/qt
2009-02-13 David Boddie <dboddie@trolltech.com>
Reviewed by Simon Hausmann.
Removed documentation for internal functions.
- 4:02 AM Changeset in webkit [40971] by
-
- 2 edits in trunk/WebKit/qt
2009-02-13 Martin Smith <msmith@trolltech.com>
Reviewed by Simon Hausmann.
Corrected some minor qdoc errors.
- 4:01 AM Changeset in webkit [40970] by
-
- 2 edits in trunk/WebCore
2009-02-13 Prasanth Ullattil <pullatti@trolltech.com>
Reviewed by Simon Hausmann.
Fixes crash in the Qt port on Windows with comboboxes
The focusWidget in the input context is not reset properly.
The QApplication::setFocusWidget() wont reset the IC if the reason is
PopupFocusReason, this is not ideal. For the time being we are going
to do this from webkit itself.
- 1:29 AM Changeset in webkit [40969] by
-
- 3 edits in trunk/JavaScriptCore
2009-02-13 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Bug 23926: Race condition in callOnMainThreadAndWait
<https://bugs.webkit.org/show_bug.cgi?id=23926>
- wtf/MainThread.cpp: Removed callOnMainThreadAndWait since it isn't used.
- 1:18 AM Changeset in webkit [40968] by
-
- 5 edits in trunk/JavaScriptCore
Math.random is really slow on windows.
Reviewed by Jon Honeycutt.
Math.random calls WTF::randomNumber which is implemented as
the secure rand_s on windows. Unfortunately rand_s is an order
of magnitude slower than arc4random. For this reason I've
added "weakRandomNumber" for use by JavaScript's Math Object.
In the long term we should look at using our own secure PRNG
in place of the system, but this will do for now.
30% win on SunSpider on Windows, resolving most of the remaining
disparity vs. Mac.
Feb 12, 2009:
- 11:30 PM Changeset in webkit [40967] by
-
- 2 edits in trunk/JavaScriptCore
Fix the build for other platforms.
- 11:17 PM Changeset in webkit [40966] by
-
- 2 edits in trunk/WebCore
wx build fix, typo while tweaking last patch for commit.
- 9:42 PM Changeset in webkit [40965] by
-
- 7 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Use Cairo/PANGO to fix text measurements and implement proper non-kerned text drawing on wxGTK.
- 9:10 PM Changeset in webkit [40964] by
-
- 15 edits in trunk/WebCore
2009-02-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser
Hook up 3D CSS transforms to the accelerated compositor backend.
Not enabled by default.
- 8:22 PM Changeset in webkit [40963] by
-
- 8 edits in trunk/JavaScriptCore
2009-02-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Remove (/reduce) use of hard-wired register names from the JIT.
Currently there is no abstraction of registers used in the JIT,
which has a number of negative consequences. Hard-wiring x86
register names makes the JIT less portable to other platforms,
and prevents us from performing dynamic register allocation to
attempt to maintain more temporary values in machine registers.
(The latter will be more important on x86-64, where we have more
registers to make use of).
Also, remove MacroAssembler::mod32. This was not providing a
useful abstraction, and was not in keeping with the rest of the
MacroAssembler interface, in having specific register requirements.
- assembler/MacroAssemblerX86Common.h:
- jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::emitSlowScriptCheck): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_lshift): (JSC::JIT::compileFastArithSlow_op_lshift): (JSC::JIT::compileFastArith_op_rshift): (JSC::JIT::compileFastArithSlow_op_rshift): (JSC::JIT::compileFastArith_op_bitand): (JSC::JIT::compileFastArithSlow_op_bitand): (JSC::JIT::compileFastArith_op_mod): (JSC::JIT::compileFastArithSlow_op_mod): (JSC::JIT::compileFastArith_op_post_inc): (JSC::JIT::compileFastArithSlow_op_post_inc): (JSC::JIT::compileFastArith_op_post_dec): (JSC::JIT::compileFastArithSlow_op_post_dec): (JSC::JIT::compileFastArith_op_pre_inc): (JSC::JIT::compileFastArithSlow_op_pre_inc): (JSC::JIT::compileFastArith_op_pre_dec): (JSC::JIT::compileFastArithSlow_op_pre_dec): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArith_op_mul): (JSC::JIT::compileFastArith_op_sub): (JSC::JIT::compileBinaryArithOp):
- jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallSetupArgs): (JSC::JIT::compileOpCallEvalSetupArgs): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
- jit/JITInlineMethods.h: (JSC::JIT::emitGetVirtualRegister): (JSC::JIT::emitPutVirtualRegister): (JSC::JIT::emitNakedCall): (JSC::JIT::restoreArgumentReference): (JSC::JIT::restoreArgumentReferenceForTrampoline):
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdSlowCase): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
- 8:10 PM Changeset in webkit [40962] by
-
- 3 edits3 adds in trunk
2009-02-12 Horia Olaru <olaru@adobe.com>
Reviewed by Oliver Hunt.
When throwing an exception within an eval argument string, the dst parameter was
modified in the functions below and the return value for eval was altered. Changed
the emitNode call in JSC::ThrowNode::emitBytecode to use a temporary register
to store its results instead of dst. The JSC::FunctionCallResolveNode::emitBytecode
would load the function within the dst registry, also altering the result returned
by eval. Replaced it with another temporary.
- parser/Nodes.cpp: (JSC::FunctionCallResolveNode::emitBytecode): (JSC::ThrowNode::emitBytecode):
LayoutTests:
2009-02-12 Horia Olaru <olaru@adobe.com>
Reviewed by Oliver Hunt.
Added a modified version of the test Chris Brichford attached to the bug.
Will test return values of various eval function calls, including some which
throw and catch errors in the string to evaluate.
- fast/js/eval-throw-return-expected.txt: Added.
- fast/js/eval-throw-return.html: Added.
- fast/js/resources/eval-throw-return.js: Added. (throwFunc): (throwOnReturn): (twoFunc):
- 7:26 PM Changeset in webkit [40961] by
-
- 2 edits in tags/Safari-6530/WebKit/win
Merge r40886.
- 7:26 PM Changeset in webkit [40960] by
-
- 2 edits in tags/Safari-6530/WebKit/mac
Merge r40884.
- 7:26 PM Changeset in webkit [40959] by
-
- 6 edits in tags/Safari-6530/WebKit
Merge r40882.
- 7:26 PM Changeset in webkit [40958] by
-
- 2 edits in tags/Safari-6530/WebKit/mac
Merge r40851.
- 6:10 PM Changeset in webkit [40957] by
-
- 10 edits in trunk/WebCore
2009-02-12 David Hyatt <hyatt@apple.com>
Reviewed by Eric Seidel
Get rid of containingBlockHeight(), since it had only one implementation (despite being virtual) and just returned
containingBlock()->availableHeight(). The latter reads better anyway. Rename containingBlockWidth() to
containingBlockWidthForContent() and move it to RenderBoxModelObject.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::localCaretRect):
- rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidthForContent): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcReplacedWidthUsing):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffsetX): (WebCore::RenderBoxModelObject::relativePositionOffsetY): (WebCore::RenderBoxModelObject::containingBlockWidthForContent):
- rendering/RenderBoxModelObject.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::marginLeft): (WebCore::RenderInline::marginRight):
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::calcReplacedWidth):
- 5:42 PM Changeset in webkit [40956] by
-
- 4 edits in trunk
Versioning.
- 5:38 PM Changeset in webkit [40955] by
-
- 1 copy in tags/Safari-6530
New tag.
- 5:27 PM Changeset in webkit [40954] by
-
- 5 edits in trunk/WebCore
2009-02-12 Simon Fraser <Simon Fraser>
Fix non-Mac builds by adding Matrix3DTransformOperation.* and
PerspectiveTransformOperation.*. Cleaned out some cruft in
the WebCore.vcproj fle.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- 5:19 PM Changeset in webkit [40953] by
-
- 5 edits in trunk
WebCore:
2009-02-12 David Smith <catfish.man@gmail.com>
Reviewed by Dave Hyatt.
Fix https://bugs.webkit.org/show_bug.cgi?id=23935
Nested :not() and non-simple selectors in :not() should be invalid
- css/CSSGrammar.y: Reject nested :not()
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ASSERT() rather than checking, since the parser enforces it now
LayoutTests:
2009-02-12 David Smith <catfish.man@gmail.com>
Reviewed by David Hyatt.
- fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt: Updated results now that we pass a few more
- 5:09 PM Changeset in webkit [40952] by
-
- 4 edits in trunk/WebKit
WebKit/mac:
2009-02-12 Brady Eidson <beidson@apple.com>
Reviewed by Kevin Decker
<rdar://problem/6582180> - Wrong HTTP method applied to history item.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Check the original request, not any redirected request.
WebKit/win:
2009-02-12 Brady Eidson <beidson@apple.com>
Reviewed by Kevin Decker
<rdar://problem/6582180> - Wrong HTTP method applied to history item.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Check the original request, not any redirected request.
- 4:48 PM Changeset in webkit [40951] by
-
- 2 edits in trunk/WebCore
wx build fixes.
- 4:35 PM Changeset in webkit [40950] by
-
- 2 edits in trunk/WebCore
2009-02-12 Simon Fraser <Simon Fraser>
Fix build with ACCELERATED_COMPOSITING turned on.
Need to cast toRenderBox() in order to call overflowClipRect().
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- 4:22 PM Changeset in webkit [40949] by
-
- 6 edits in trunk/LayoutTests
Reviewed by Simon Fraser.
Fixed test results
- 4:19 PM Changeset in webkit [40948] by
-
- 2 edits in trunk/WebCore
Fix windows build.
Reviewed by NOBODY(OOPS!)
- 3:53 PM Changeset in webkit [40947] by
-
- 10 edits in trunk/WebCore
2009-02-12 David Hyatt <hyatt@apple.com>
Rename getOverflowClipRect and getClipRect to overflowClipRect and clipRect. Move them to RenderBox, since these methods
only apply to boxes. Devirtualize clipRect, since it was not subclassed. Move controlClip stuff to RenderBox also.
Reviewed by Simon Fraser
- editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
- rendering/RenderBox.cpp: (WebCore::RenderBox::overflowClipRect): (WebCore::RenderBox::clipRect):
- rendering/RenderBox.h: (WebCore::RenderBox::hasControlClip): (WebCore::RenderBox::controlClipRect):
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderObject.h: (WebCore::RenderObject::hasClip): (WebCore::RenderObject::hasOverflowClip):
- rendering/RenderTable.cpp: (WebCore::RenderTable::overflowClipRect):
- rendering/RenderTable.h:
- 3:46 PM Changeset in webkit [40946] by
-
- 2 edits in trunk/WebCore
2009-02-12 Simon Fraser <Simon Fraser>
Fix build with ACCELERATED_COMPOSITING turned on (simple copy/paste error)
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setBasicAnimation):
- 3:28 PM Changeset in webkit [40945] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Speed up String.prototype.fontsize.
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncFontsize): Specialize for defined/commonly used values.
- 3:18 PM Changeset in webkit [40944] by
-
- 2 edits in trunk/WebCore
2009-02-12 Julien Chaffraix <jchaffraix@webkit.org>
Not reviewed.
Release build fix when VIDEO is disabled (it should also
help those with WORKERS or XSLT disabled).
- bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseAudio): Added an UNUSED_PARAM for exec and slot when VIDEO is disabled. (jsDOMWindowBaseWorker): Ditto for WORKERS. (jsDOMWindowBaseXSLTProcessor): Ditto for XSLT.
- 3:14 PM Changeset in webkit [40943] by
-
- 3 edits in trunk/WebCore
2009-02-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=23923
Implement mediaPlayerVolumeChanged so a media engine can report autonomous volume changes.
Supporting this requires that we know when we are processing a media engine callback so
we don't turn around and tell the media player to change the volume when it is reporting
a volume change.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): initialize m_processingMediaPlayerCallback (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): call begin/endProcessingMediaPlayerCallback (WebCore::HTMLMediaElement::setNetworkState): logic split out of mediaPlayerNetworkStateChanged to make it easier to maintain m_processingMediaPlayerCallback. (WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged): call begin/endProcessingMediaPlayerCallback (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Ditto. (WebCore::HTMLMediaElement::mediaPlayerRepaint): Ditto. (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): New (WebCore::HTMLMediaElement::updateVolume): Don't change media engine volume if we are processing a callback from the engine.
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::processingMediaPlayerCallback): New, return true if (m_processingMediaPlayerCallback>0) (WebCore::HTMLMediaElement::beginProcessingMediaPlayerCallback): New, increment m_processingMediaPlayerCallback (WebCore::HTMLMediaElement::endProcessingMediaPlayerCallback): New, decrement m_processingMediaPlayerCallback
- 2:55 PM Changeset in webkit [40942] by
-
- 5 edits3 adds in trunk
2009-02-12 Eric Carlson <eric.carlson@apple.com>
Simon Fraser
Support MPEG content on Mac and Windows.
<rdar://problem/5917509>
https://bugs.webkit.org/show_bug.cgi?id=23495
Test: media/audio-mpeg-supported.html
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::disableUnsupportedTracks):
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: fix typo added in r40925
2009-02-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Support MPEG content on Mac and Windows.
<rdar://problem/5917509>
https://bugs.webkit.org/show_bug.cgi?id=23495
- media/audio-mpeg-supported-expected.txt: Added.
- media/audio-mpeg-supported.html: Added.
- media/content/silence.mpg: Added.
- 2:54 PM Changeset in webkit [40941] by
-
- 8 edits in trunk/WebCore
2009-02-12 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig
Move containsFloats, hasOverhangingFloats, shrinkToAvoidFloats and avoidsFloats down to
RenderBox, since these methods only apply to boxes.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::clearFloats): (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout): (WebCore::RenderBlock::calcBlockPrefWidths):
- rendering/RenderBlock.h: (WebCore::RenderBlock::containsFloats): (WebCore::RenderBlock::hasOverhangingFloats):
- rendering/RenderBox.cpp: (WebCore::RenderBox::shrinkToAvoidFloats): (WebCore::RenderBox::avoidsFloats):
- rendering/RenderBox.h:
- rendering/RenderObject.cpp:
- rendering/RenderObject.h: (WebCore::RenderObject::isFloatingOrPositioned):
- rendering/RenderView.h:
- 2:43 PM Changeset in webkit [40940] by
-
- 3 edits in trunk/WebKit/mac
2009-02-12 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
<rdar://problem/6579412>
REGRESSION (3.2.1-ToT): Crash in Silverlight viewing streaming lecture
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView userAgent]): Apply workaround for Silverlight workaround.
(-[WebNetscapePluginView _createPlugin]):
Check if the plug-in that we're creating is the silverlight plug-in.
- 2:33 PM Changeset in webkit [40939] by
-
- 23 edits in trunk
2009-02-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt
Added parsing of 3d transform functions and properties
(perspective, perspective-origin, transform-style-3d,
and backface-visibility).
Test: transforms/3d/cssmatrix-3d-interface.xhtml
- 2:28 PM Changeset in webkit [40938] by
-
- 4 edits in branches/Safari-6528
Versioning.
- 2:28 PM Changeset in webkit [40937] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Correctness fix.
- wtf/RandomNumber.cpp: (WTF::randomNumber): Divide by the maximum representable value, which is different on each platform now, to get values between 0 and 1.
- 2:25 PM Changeset in webkit [40936] by
-
- 1 copy in tags/Safari-6528.14
New tag.
- 2:22 PM Changeset in webkit [40935] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-12 Geoffrey Garen <ggaren@apple.com>
Build fix.
- wtf/RandomNumber.cpp: (WTF::randomNumber):
- 2:15 PM Changeset in webkit [40934] by
-
- 2 edits in trunk/WebCore
wx build fix.
- 1:59 PM Changeset in webkit [40933] by
-
- 8 edits in trunk
WebCore:
2009-02-12 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
Fix potential ref-count or null-deref problems with C++ objects as Obj-C members.
- platform/mac/SharedBufferMac.mm: Change to use RefPtr<> instead of ref()/deref(). (-[WebCoreSharedBufferData dealloc]): (-[WebCoreSharedBufferData finalize]): (-[WebCoreSharedBufferData initWithSharedBuffer:]):
WebKit/mac:
2009-02-12 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
Fix potential ref-count or null-deref problems with C++ objects as Obj-C members.
- History/WebBackForwardList.mm: (-[WebBackForwardList dealloc]): Null check before deref()'ing. (-[WebBackForwardList finalize]): Ditto.
- Misc/WebIconFetcher.mm: (-[WebIconFetcher dealloc]): Null check before deref()'ing. (-[WebIconFetcher finalize]): Ditto.
- WebCoreSupport/WebEditorClient.mm: Change to use RefPtr<> instead of ref()/deref(). (-[WebEditCommand initWithEditCommand:]): (-[WebEditCommand dealloc]): (-[WebEditCommand finalize]): (-[WebEditCommand command]):
- WebView/WebArchive.mm: Change to use RefPtr<> instead of ref()/deref(). (-[WebArchivePrivate init]): (-[WebArchivePrivate initWithCoreArchive:]): (-[WebArchivePrivate coreArchive]): (-[WebArchivePrivate setCoreArchive:]): (-[WebArchivePrivate dealloc]): (-[WebArchivePrivate finalize]):
- WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]): Null check before deref()'ing. (-[WebDataSourcePrivate finalize]): Ditto.
- 1:56 PM Changeset in webkit [40932] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed <rdar://problem/6582048>.
- wtf/RandomNumber.cpp: (WTF::randomNumber): Make only one call to the random number generator on platforms where the generator is cryptographically secure. The value of randomness over and above cryptographically secure randomness is not clear, and it caused some performance problems.
- 1:52 PM Changeset in webkit [40931] by
-
- 2 edits in trunk/WebCore
2009-02-12 David Hyatt <hyatt@apple.com>
Remove calcWidth from RenderObject. Nobody ever called it on RenderObjects.
Reviewed by Sam Weinig
- rendering/RenderObject.h:
- 1:38 PM Changeset in webkit [40930] by
-
- 2 edits in trunk/WebCore
2009-02-12 David Hyatt <hyatt@apple.com>
Reviewed by Mark Rowe
Fix for regression where form controls would paint yellow highlights. The containsComposition check needs to
null check node() now.
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
- 1:34 PM Changeset in webkit [40929] by
-
- 4 edits in trunk/WebCore
2009-02-12 Simon Fraser <Simon Fraser>
Build fix
Change Animation::setDirection() to take the new enum value, and fix
the single caller.
Fix build error in MediaPlayerPrivateQTKit.h.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapAnimationDirection):
- platform/animation/Animation.h: (WebCore::Animation::setDirection):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- 1:33 PM Changeset in webkit [40928] by
-
- 2 edits in trunk/WebKitTools
2009-02-12 Simon Fraser <Simon Fraser>
No review.
Remove debugging code which was committed by mistake.
- Scripts/run-webkit-tests:
- 1:26 PM Changeset in webkit [40927] by
-
- 3 edits in trunk/WebKitTools
2009-02-12 Simon Fraser <Simon Fraser>
Reviewed by Adam Roben
Add detection of accelerated compositing and 3d transforms,
and add various directories to $ignoredDirectories when these
features are off.
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
- 1:18 PM Changeset in webkit [40926] by
-
- 3 edits in trunk/WebCore
2009-02-12 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser
Remove the overrideSize methods from RenderObject. Devirtualize all of the accessors on RenderBox.
- rendering/RenderBox.h:
- rendering/RenderObject.h:
- 1:08 PM Changeset in webkit [40925] by
-
- 17 edits1 add in trunk/WebCore
2009-02-12 Eric Carlson <eric.carlson@apple.com>
Darin Adler, Antti Koivisto, Holger Hans Peter Freyther
Bug 23797: A platform should be able to use more than one media engine for <video> and <audio>
https://bugs.webkit.org/show_bug.cgi?id=23797
- WebCore.xcodeproj/project.pbxproj: add MediaPlayerPrivate.h
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::load): selectMediaURL now also returns a MIME type, pass it to MediaPlayer::load so it can choose the right media engine (WebCore::HTMLMediaElement::selectMediaURL): renamed from pickMedia. use MIMETypeRegistry functions to strip params from the url and extract the codecs parameter. call MediaPlayer::supportsType to see if we can open the file since only a media engine can answer questions about supported type+codecs.
- html/HTMLMediaElement.h:
- platform/MIMETypeRegistry.cpp: (WebCore::MIMETypeRegistry::getParameterFromMIMEType): New, find and return a MIME type parameter (WebCore::MIMETypeRegistry::stripParametersFromMIMEType): New, strip all parameters from a MIME type
- platform/MIMETypeRegistry.h:
- platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::NullMediaPlayerPrivate): (WebCore::NullMediaPlayerPrivate::load): (WebCore::NullMediaPlayerPrivate::cancelLoad): (WebCore::NullMediaPlayerPrivate::play): (WebCore::NullMediaPlayerPrivate::pause): (WebCore::NullMediaPlayerPrivate::naturalSize): (WebCore::NullMediaPlayerPrivate::hasVideo): (WebCore::NullMediaPlayerPrivate::setVisible): (WebCore::NullMediaPlayerPrivate::duration): (WebCore::NullMediaPlayerPrivate::currentTime): (WebCore::NullMediaPlayerPrivate::seek): (WebCore::NullMediaPlayerPrivate::seeking): (WebCore::NullMediaPlayerPrivate::setEndTime): (WebCore::NullMediaPlayerPrivate::setRate): (WebCore::NullMediaPlayerPrivate::paused): (WebCore::NullMediaPlayerPrivate::setVolume): (WebCore::NullMediaPlayerPrivate::networkState): (WebCore::NullMediaPlayerPrivate::readyState): (WebCore::NullMediaPlayerPrivate::maxTimeSeekable): (WebCore::NullMediaPlayerPrivate::maxTimeBuffered): (WebCore::NullMediaPlayerPrivate::dataRate): (WebCore::NullMediaPlayerPrivate::totalBytesKnown): (WebCore::NullMediaPlayerPrivate::totalBytes): (WebCore::NullMediaPlayerPrivate::bytesLoaded): (WebCore::NullMediaPlayerPrivate::setRect): (WebCore::NullMediaPlayerPrivate::paint): (WebCore::createNullMediaPlayer): Do nothing media player so MediaPlayer doesn't have to NULL check before calling current engine.
(WebCore::MediaPlayerFactory::MediaPlayerFactory): New, factory constructor.
(WebCore::installedMediaEngines): New, returns vector of all installed engines.
(WebCore::addMediaEngine): New, add a media engine to the cache.
(WebCore::chooseBestEngineForTypeAndCodecs): New, return an engine that might support a MIME type.
(WebCore::MediaPlayer::MediaPlayer): create NULL media player so we have a default. Initialize m_currentMediaEngine.
(WebCore::MediaPlayer::~MediaPlayer): don't need to delete m_private, it is now an OwnPtr.
(WebCore::MediaPlayer::load): Take MIME type as well as url, since we need it to find the right
media engine. If no MIME type is provided, try to devine one from the url. Choose a media engine
based on the MIME type and codecs parameter.
(WebCore::MediaPlayer::currentTime): Remove excess white space.
(WebCore::MediaPlayer::supportsType): Take codecs param as well as MIME type. Return enum so we can
indicate "maybe" condition.
(WebCore::MediaPlayer::getSupportedTypes): Build up list of MIME types by consulting all engines.
(WebCore::MediaPlayer::isAvailable): return true if any media engine is installed.
- platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::): (WebCore::MediaPlayer::frameView): accessor function.
- platform/graphics/MediaPlayerPrivate.h: New, declares abstract interface for media engines. (WebCore::MediaPlayerPrivateInterface::~MediaPlayerPrivateInterface): (WebCore::MediaPlayerPrivateInterface::totalBytesKnown):
- platform/graphics/chromium/MediaPlayerPrivateChromium.h: Add support for engine factory
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::create): New, media engine factory function (WebCore::MediaPlayerPrivate::registerMediaEngine): Register engine with MediaPlayer factory (WebCore::MediaPlayerPrivate::load): URL is a const String. (WebCore::MediaPlayerPrivate::duration): Declare const. (WebCore::MediaPlayerPrivate::naturalSize): Ditto. (WebCore::MediaPlayerPrivate::hasVideo): Ditto. (WebCore::MediaPlayerPrivate::networkState): Ditto. (WebCore::MediaPlayerPrivate::readyState): Ditto. (WebCore::MediaPlayerPrivate::maxTimeBuffered): Ditto. (WebCore::MediaPlayerPrivate::maxTimeSeekable): Ditto. (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto. (WebCore::MediaPlayerPrivate::bytesLoaded): Ditto. (WebCore::MediaPlayerPrivate::totalBytesKnown): Ditto. (WebCore::MediaPlayerPrivate::totalBytes): Ditto. (WebCore::MediaPlayerPrivate::supportsType): Return MediaPlayer::SupportsType enum instead of bool.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: (WebCore::MediaPlayerPrivate::isAvailable):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::create): New, media engine factory function (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Register engine with MediaPlayer factory (WebCore::MediaPlayerPrivate::createQTMovieView): don't access MediaPlayer->m_frameView directly, use accessor function. (WebCore::MediaPlayerPrivate::setUpVideoRendering): Ditto. (WebCore::MediaPlayerPrivate::paint): Ditto. (WebCore::mimeTypeCache): New. (WebCore::MediaPlayerPrivate::getSupportedTypes): New, media engine factory function. (WebCore::MediaPlayerPrivate::supportsType): return MediaPlayer::SupportsType enum instead of bool (-[WebCoreMovieObserver initWithCallback:]): fix formatting
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::create): (WebCore::MediaPlayerPrivate::registerMediaEngine): (WebCore::MediaPlayerPrivate::supportsType): (WebCore::MediaPlayerPrivate::load): URL is a const String.
- platform/graphics/qt/MediaPlayerPrivatePhonon.h: (WebCore::MediaPlayerPrivate::isAvailable):
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::create): New, media engine factory function (WebCore::MediaPlayerPrivate::registerMediaEngine): New, register engine with MediaPlayer factory (WebCore::MediaPlayerPrivate::load): URL is a const String. (WebCore::MediaPlayerPrivate::paint): don't access MediaPlayer->m_frameView directly, use accessor function. (WebCore::mimeTypeCache): New. (WebCore::MediaPlayerPrivateQTWin::getSupportedTypes): New, media engine factory function. (WebCore::MediaPlayerPrivateQTWin::supportsType): return MediaPlayer::SupportsType enum instead of bool
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
- 12:52 PM Changeset in webkit [40924] by
-
- 7 edits2 adds in trunk
WebCore:
2009-02-12 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Test: fast/dom/prefixed-image-tag.xhtml
Bug 23915: Remove setPrefix work-around in Document::createElement(QualifiedName, bool)
Instead we now directly propage the QualifiedName inside the generated Factory.
Test: fast/dom/prefixed-image-tag.xhtml
- dom/Document.cpp: (WebCore::Document::createElement): Removed the setPrefix work-around and replaced it with an ASSERT to catch mistakes inside the Factory code. Remove the unneeded ExceptionCode argument.
(WebCore::Document::createElementNS): Removed ExceptionCode argument.
- dom/Document.h: Updated the signature.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::startElementNs): Removed ExceptionCode argument.
- dom/XMLTokenizerQt.cpp: Ditto. (WebCore::XMLTokenizer::parseStartElement): Ditto.
- dom/make_names.pl: Implemented the QualifiedName propogation logic in the Factory.
LayoutTests:
2009-02-12 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Bug 23915: Remove setPrefix work-around in Document::createElement(QualifiedName, bool)
The test validates the <image> special treatment (using <img> tag) and see whether
it validates the previous behaviour and we do not ASSERT.
- fast/dom/prefixed-image-tag-expected.txt: Added.
- fast/dom/prefixed-image-tag.xhtml: Added.
- 12:47 PM Changeset in webkit [40923] by
-
- 5 edits in trunk/WebCore
2009-02-12 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Define enum values for Animation::direction(), and one for
IterationCountInfinite to make the code more self-documenting.
Order the member vars of Animation to optimize packing.
- 12:42 PM Changeset in webkit [40922] by
-
- 2 edits in trunk/WebCore
Reviewed by Holger Freyther.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp): Don't use O_CLOEXEC for now.
- 12:31 PM Changeset in webkit [40921] by
-
- 4 edits2 adds in trunk
WebCore:
2009-02-12 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Bug 23826: Potential bug with before/after rule while moving element from one document to another
Moved the document before/after toggle from the constructor to insertedIntoDocument.
Test: fast/css-generated-content/beforeAfter-interdocument.html
- html/HTMLQuoteElement.cpp: (WebCore::HTMLQuoteElement::HTMLQuoteElement): (WebCore::HTMLQuoteElement::insertedIntoDocument):
- html/HTMLQuoteElement.h:
LayoutTests:
2009-02-12 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Bug 23826: Potential bug with before/after rule while moving element from one document to another
- fast/css-generated-content/beforeAfter-interdocument.html: Added.
- platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.txt: Added.
- 12:30 PM Changeset in webkit [40920] by
-
- 2 edits in trunk/WebKit/mac
2009-02-12 Brady Eidson <beidson@apple.com>
Reviewed by Kevin Decker
<rdar://problem/6579750> - Crash in WebArchivePrivate in Tiger TextEdit
NSHTMLReader tries to create a WebArchive from a random chunk of data. Previously, WebArchive creation would
fail and return nil and NSHTMLReader would try something else. When we changed the behavior to return an invalid
WebArchive object, things started getting weird.
- WebView/WebArchive.mm: (-[WebArchivePrivate setCoreArchive:]): Null check the pointer before calling ->deref() (-[WebArchivePrivate dealloc]): Remove the ASSERT which is now invalid, and null check the pointer before ->deref(). (-[WebArchivePrivate finalize]): Ditto (-[WebArchive initWithData:]): If the LegacyWebArchive cannot be created, return nil instead of an invalid object.
- 12:18 PM Changeset in webkit [40919] by
-
- 2 edits in trunk/WebCore
2009-02-12 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser
I have no idea why this broke. As far as I can tell the old code never should have worked in
the first place. Add code to handleWheelEvent that will find an enclosing renderer for a node
in order to attempt a wheel scroll.
- page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):
- 11:44 AM Changeset in webkit [40918] by
-
- 5 edits in trunk/WebKit/gtk
[GTK] API: hovering-over-link and webkit_web_view_open /_load_foo
http://bugs.webkit.org/show_bug.cgi?id=17176
Reviewed by Holger Freyther.
- webkit/webkitwebframe.cpp:
- webkit/webkitwebframe.h:
- webkit/webkitwebview.cpp:
- webkit/webkitwebview.h: Introduce webkit_web_frame_load_uri,
webkit_web_frame_load_string, webkit_web_view_load_uri and
webkit_web_view_load_request and unify implementations.
- 11:41 AM Changeset in webkit [40917] by
-
- 2 edits in trunk/LayoutTests
Try to fix dashboard-region-parser
- platform/mac/fast/css/dashboard-region-parser.html: Fixed relative paths now that this test has moved.
- 11:28 AM Changeset in webkit [40916] by
-
- 10 edits in trunk/WebCore
2009-02-12 David Hyatt <hyatt@apple.com>
Move the functions that paint borders, box shadows and border images into RenderBoxModelObject. drawBorder and drawBorderArc, because they are used
for outlines as well as borders, need to stay in RenderObject. Rename them to drawLineForBoxSide and drawArcForBoxSide in order to reflect their
more generic use. Rename the BorderSide struct to BoxSide, since the concept of "side" is just a rectangle concept and not a border concept.
Reviewed by Simon Fraser
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxShadow): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumns):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::paintBoxShadow):
- rendering/RenderBoxModelObject.h:
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBorderMinusLegend):
- rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutlineForLine):
- rendering/RenderObject.cpp: (WebCore::RenderObject::drawLineForBoxSide): (WebCore::RenderObject::drawArcForBoxSide): (WebCore::RenderObject::paintOutline):
- rendering/RenderObject.h: (WebCore::): (WebCore::RenderObject::hasBoxDecorations):
- rendering/RenderTableCell.cpp: (WebCore::CollapsedBorders::addBorder): (WebCore::RenderTableCell::paintCollapsedBorder):
- 11:25 AM Changeset in webkit [40915] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Simon Fraser.
Skip 16 SVG tests that fail on PPC, until problem is resolved
- platform/mac/Skipped:
- 11:21 AM Changeset in webkit [40914] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Simon Fraser.
This fixes one testcase on PPC Mac
- svg/custom/getTransformToElement.svg:
- 10:43 AM Changeset in webkit [40913] by
-
- 2 edits1 add in trunk/WebCore
2009-02-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser
Bug 18322: video element should have ui when scripting is disabled
https://bugs.webkit.org/show_bug.cgi?id=18322
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::controls): always return 'true' when JavaScript is disabled.
- manual-tests/media-controls-when-javascript-disabled.html: Added.
- 10:32 AM Changeset in webkit [40912] by
-
- 2 edits in trunk
- configure.ac: Make soup the default HTTP backend for the Gtk port.
- 10:18 AM Changeset in webkit [40911] by
-
- 1 edit1 add in trunk/WebCore
2009-02-12 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23906
Add custom V8 bindings for HTMLPlugInElement.
- bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: Added. (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_SETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
- 10:11 AM Changeset in webkit [40910] by
-
- 2 edits in trunk/WebCore
[GTK] Soup backend must handle upload of multiple files
https://bugs.webkit.org/show_bug.cgi?id=18343
Reviewed by Mark Rowe.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::): (WebCore::freeFileMapping): (WebCore::ResourceHandle::startHttp): Support multipart request bodies mmap'ing files to be uploaded.
- 9:27 AM Changeset in webkit [40909] by
-
- 2 edits in trunk/LayoutTests
Add some tests that fail due to using the wrong font for Hebrew to the Windows Skipped list
- platform/win/Skipped:
- 9:10 AM Changeset in webkit [40908] by
-
- 2 edits in trunk/JavaScriptCore
Fix lots of Perl warnings when building JavaScriptCoreGenerated on Windows
Reviewed by John Sullivan.
- JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Create the docs/ directory so that we can write bytecode.html into it. This matches what JavaScriptCore.xcodeproj does.
- 8:48 AM Changeset in webkit [40907] by
-
- 2 edits in trunk/LayoutTests
Remove some passing tests from the Windows Skipped list
- platform/win/Skipped: Removed two tests in http/tests/incremental (one of which had been renamed and so was running anyway).
- 8:48 AM Changeset in webkit [40906] by
-
- 2 edits in trunk/WebKitTools
Fix Bug 23922: Warning message from run-webkit-tests when Skipped file contains non-existent tests is confusing and is given for disabled tests
We now no longer warn about disabled tests. The warning now reads:
Skipped list contained '$item', but no file of that name could be
found
Reviewed by John Sullivan.
- Scripts/run-webkit-tests: (top level): Pass the list name to processIgnoreTests so it can print out a reasonable warning message. (processIgnoreTests): Take a list name as a second parameter and use it to display a better warning message. Also check for a "-disabled" version of the test before warning about it not existing.
- 8:48 AM Changeset in webkit [40905] by
-
- 2 edits in trunk/LayoutTests
Add a failing loader test to the Windows Skipped list
- platform/win/Skipped: Added fast/loader/frame-creation-removal.html.
- 8:48 AM Changeset in webkit [40904] by
-
- 2 edits in trunk/LayoutTests
Add another failing drag-n-drop test to the Windows Skipped list
- platform/win/Skipped: Added editing/selection/drag-in-iframe.html.
- 8:48 AM Changeset in webkit [40903] by
-
- 1 edit2 moves in trunk/LayoutTests
Fix Bug 23919: Mac-specific test fast/css/dashboard-region-parser is in cross-platform location
Moved the test and its results to platform/mac.
Reviewed by Dan Bernstein.
- platform/mac/fast/css/dashboard-region-parser-expected.txt: Renamed from LayoutTests/fast/css/dashboard-region-parser-expected.txt.
- platform/mac/fast/css/dashboard-region-parser.html: Renamed from LayoutTests/fast/css/dashboard-region-parser.html.
- 8:47 AM Changeset in webkit [40902] by
-
- 3 edits4 copies1 add in trunk/LayoutTests
Fix Bug 23918: Mac-specific results for fast/css/computed-style[-without-renderer] are sitting in cross-platform location
Move Mac-specific results for
fast/css/computed-style[-without-renderer] to platform/mac
Reviewed by John Sullivan.
- fast/css/computed-style-expected.txt:
- fast/css/computed-style-without-renderer-expected.txt: Made these results correct for non-Mac platforms by removing the -webkit-dashboard-region references.
- platform/mac/fast/css/computed-style-expected.txt: Copied from LayoutTests/fast/css/computed-style-expected.txt.
- platform/mac/fast/css/computed-style-without-renderer-expected.txt: Copied from LayoutTests/fast/css/computed-style-without-renderer-expected.txt.
- platform/win/fast/css/computed-style-expected.txt:
- platform/win/fast/css/computed-style-without-renderer-expected.txt: Copied the non-Mac results here, too, since on Windows we first check for Mac-specific results before checking for cross-platform results.
- 7:01 AM Changeset in webkit [40901] by
-
- 2 edits in trunk/WebCore
2009-02-12 Adam Treat <adam.treat@torchmobile.com>
Fix the Qt build following r40871 which changed RenderObject::element()
into RenderObject::node().
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::getMediaElementFromRenderObject): (WebCore::RenderThemeQt::getMediaControlForegroundColor):
- 2:51 AM Changeset in webkit [40900] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-12 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Lars.
Re-enable the JIT in the Qt build with -fno-stack-protector on Linux.
- 2:45 AM Changeset in webkit [40899] by
-
- 2 edits in trunk/WebCore
Build fix.
- platform/graphics/transforms/RotateTransformOperation.cpp: Include <algorithm>.
- 1:14 AM Changeset in webkit [40898] by
-
- 2 edits in branches/Safari-6528/WebKit/win
Merge r40886.
- 1:14 AM Changeset in webkit [40897] by
-
- 2 edits in branches/Safari-6528/WebKit/mac
Merge r40884.
- 1:14 AM Changeset in webkit [40896] by
-
- 6 edits in branches/Safari-6528/WebKit
Merge r40882.
- 1:14 AM Changeset in webkit [40895] by
-
- 2 edits in branches/Safari-6528/WebKit/mac
Merge r40851.
- 1:14 AM Changeset in webkit [40894] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40847.
- 1:14 AM Changeset in webkit [40893] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40808.
- 1:13 AM Changeset in webkit [40892] by
-
- 2 edits4 adds in branches/Safari-6528
Merge r40778.
- 1:10 AM Changeset in webkit [40891] by
-
- 7 edits in branches/Safari-6528/WebCore
Merge r40729.
- 1:08 AM Changeset in webkit [40890] by
-
- 13 edits in trunk/WebCore
2009-02-12 Jian Li <jianli@chromium.org>
Reviewed by Alexey Proskuryakov.
Change worker code to use different proxy class pointers.
https://bugs.webkit.org/show_bug.cgi?id=23859
This is a step towards using separate proxies in multi-process implementation.
- bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
- dom/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::~Worker): (WebCore::Worker::postMessage): (WebCore::Worker::terminate): (WebCore::Worker::hasPendingActivity): (WebCore::Worker::notifyFinished): (WebCore::Worker::dispatchMessage):
- dom/Worker.h:
- dom/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): (WebCore::WorkerContext::reportException): (WebCore::WorkerContext::addMessage): (WebCore::WorkerContext::postMessage): (WebCore::WorkerContext::dispatchMessage):
- dom/WorkerContext.h:
- dom/WorkerContextProxy.h:
- dom/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): (WebCore::MessageWorkerTask::performTask): (WebCore::WorkerContextProxy::create): (WebCore::WorkerMessagingProxy::WorkerMessagingProxy): (WebCore::WorkerMessagingProxy::~WorkerMessagingProxy): (WebCore::WorkerMessagingProxy::startWorkerContext): (WebCore::postConsoleMessageTask): (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject): (WebCore::WorkerMessagingProxy::workerThreadCreated):
- dom/WorkerMessagingProxy.h:
- dom/WorkerObjectProxy.h:
- dom/WorkerThread.cpp: (WebCore::WorkerThread::create): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::workerThread):
- dom/WorkerThread.h: (WebCore::WorkerThread::workerObjectProxy):
- loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
- 12:32 AM Changeset in webkit [40889] by
-
- 8 edits in trunk/WebCore
2009-02-12 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 23688: ThreadableLoader needs a sync implementation for Workers.
<https://bugs.webkit.org/show_bug.cgi?id=23688>
Add ResourceError to ThreadableLoaderClient.
No observable change in behavior, so no test.
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::create): (WebCore::DocumentThreadableLoader::willSendRequest): (WebCore::DocumentThreadableLoader::didFail):
- loader/ThreadableLoaderClient.h: (WebCore::ThreadableLoaderClient::didFail): (WebCore::ThreadableLoaderClient::didFailWillSendRequestCheck):
- loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::didFail):
- loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader): (WebCore::workerContextDidFail): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
- loader/WorkerThreadableLoader.h:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFail): (WebCore::XMLHttpRequest::didFailWillSendRequestCheck):
- xml/XMLHttpRequest.h:
Feb 11, 2009:
- 11:58 PM Changeset in webkit [40888] by
-
- 9 edits in trunk/JavaScriptCore
2009-02-11 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=23705
Fix the UI freeze caused by Worker generating a flood of messages.
Measure time we spend in executing posted work items. If too much time is spent
without returning to the run loop, exit and reschedule.
- wtf/MainThread.h: Added initializeMainThreadPlatform() to initialize low-level mechanism for posting work items from thread to thread. This removes #ifdefs for WIN and CHROMIUM from platform-independent code.
- wtf/MainThread.cpp: (WTF::initializeMainThread): (WTF::dispatchFunctionsFromMainThread): Instead of dispatching all work items in the queue, dispatch them one by one and measure elapsed time. After a threshold, reschedule and quit.
(WTF::callOnMainThread):
(WTF::callOnMainThreadAndWait):
Only schedule dispatch if the queue was empty - to avoid many posted messages in the run loop queue.
- wtf/mac/MainThreadMac.mm: (WTF::scheduleDispatchFunctionsOnMainThread): Use static instance of the mainThreadCaller instead of allocating and releasing it each time. (WTF::initializeMainThreadPlatform):
- wtf/gtk/MainThreadChromium.cpp: (WTF::initializeMainThreadPlatform):
- wtf/gtk/MainThreadGtk.cpp: (WTF::initializeMainThreadPlatform):
- wtf/qt/MainThreadQt.cpp: (WTF::initializeMainThreadPlatform):
- wtf/win/MainThreadWin.cpp: (WTF::initializeMainThreadPlatform):
- wtf/wx/MainThreadWx.cpp: (WTF::initializeMainThreadPlatform):
- 9:53 PM Changeset in webkit [40887] by
-
- 4 edits in trunk/WebCore
2009-02-11 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Fix the build on Leopard with ACCELERATED_COMPOSITING turned on.
- WebCore.xcodeproj/project.pbxproj: FloatPoint3D needs to be a private header, since it's included by GraphicsLayer.h
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::getTransformFunctionValue): (WebCore::caValueFunctionSupported): (WebCore::GraphicsLayerCA::setAnchorPoint): (WebCore::GraphicsLayerCA::setPreserves3D): (WebCore::GraphicsLayerCA::setContentsToImage): (WebCore::GraphicsLayerCA::setBasicAnimation): (WebCore::GraphicsLayerCA::setKeyframeAnimation):
- rendering/RenderLayer.h: (WebCore::RenderLayer::isRootLayer): Fix isRootLayer to return true for the renderView's layer, not the root renderer's layer.
- 9:48 PM Changeset in webkit [40886] by
-
- 2 edits in trunk/WebKit/win
2009-02-11 Brady Eidson <beidson@apple.com>
Fix my last checkin for more effect.
- WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation):
- 9:06 PM Changeset in webkit [40885] by
-
- 2 edits in trunk/WebCore
2009-02-11 Adele Peterson <adele@apple.com>
Reviewed by Oliver Hunt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=23910
<rdar://problem/6160546> REGRESSION: In Full page mode, movie controller hides when I drag the knob if movie is playing
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::forwardEvent): When we get a mouseOut event, consider the mouse as still within the RenderMedia if the relatedTarget is a descendant.
- 8:15 PM Changeset in webkit [40884] by
-
- 2 edits in trunk/WebKit/mac
Fix the build.
- History/WebHistory.mm:
(-[WebHistoryPrivate visitedURL:withTitle:]): Use ASSERT_UNUSED in a manner that makes sense.
- 8:07 PM Changeset in webkit [40883] by
-
- 8 edits in trunk
Windows fix for Bug 22239: Implement missing animation & transition APIs on LayoutTestController for non-mac platforms
WebKit/win:
Windows fix for Bug 22239: Implement missing animation & transition
APIs on LayoutTestController for non-mac platforms
Reviewed by Simon Fraser.
- Interfaces/IWebFramePrivate.idl: Added pauseAnimation, pauseTransition, and numberOfActiveAnimations.
- WebFrame.cpp: (WebFrame::pauseAnimation): (WebFrame::pauseTransition): (WebFrame::numberOfActiveAnimation): Added. These all call through to AnimationController.
- WebFrame.h: Added pauseAnimation, pauseTransition, and numberOfActiveAnimations.
WebKitTools:
Windows fix for Bug 22239: Implement missing animation & transition
APIs on LayoutTestController for non-mac platforms
Reviewed by Simon Fraser.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::numberOfActiveAnimations): Implemented these by calling through to IWebFramePrivate.
LayoutTests:
Windows fix for Bug 22239: Implement missing animation & transition
APIs on LayoutTestController for non-mac platforms
Reviewed by Simon Fraser.
- platform/win/Skipped: Enable the previously-skipped tests.
- 6:30 PM Changeset in webkit [40882] by
-
- 6 edits in trunk/WebKit
WebKit/mac:
2009-02-11 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe
<rdar://problem/6570573> Some visit counts in History.plist have insanely high values, can roll over to negative
Remove the item from the date caches before registering the visit. Otherwise it might not be successfully removed
and when we add it back later it will exist in the list twice. This will cause the entry to be written out twice,
which would lead to doubling (or more!) the visit count on next launch when these multiple items are merged.
- History/WebHistory.mm: (-[WebHistoryPrivate visitedURL:withTitle:]): Swap the removeItemFromDateCaches and visitedWithTitle calls. (-[WebHistoryPrivate addItem:discardDuplicate:]): Add a mode that allows the entry being added to be discarded if an entry for the URL already exists. Use that mode when reading the History.plist so only the most recent entry for a given URL will be used. (-[WebHistoryPrivate addItems:]): (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
WebKit/win:
2009-02-11 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe
<rdar://problem/6570573> Some visit counts in History.plist have insanely high values, can roll over to negative
Remove the item from the date caches before registering the visit. Otherwise it might not be successfully removed
and when we add it back later it will exist in the list twice. This will cause the entry to be written out twice,
which would lead to doubling (or more!) the visit count on next launch when these multiple items are merged.
- WebHistory.cpp: (WebHistory::loadHistoryGutsFromURL): (WebHistory::addItems): (WebHistory::addItem): Add a mode that allows the entry being added to be discarded if an entry for the URL already exists. Use that mode when reading the History.plist so only the most recent entry for a given URL will be used. (WebHistory::visitedURL): Swap the removeItemFromDateCaches and visitedWithTitle calls.
- WebHistory.h:
- WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation): Add the negative-visit-count-correction-logic as implemented for Mac in http://trac.webkit.org/changeset/40851.
- 5:59 PM Changeset in webkit [40881] by
-
- 9 edits in trunk/WebCore
2009-02-11 David Hyatt <hyatt@apple.com>
Remove all of the inline box wrapper functions from RenderObject, since they only apply to RenderBox. Devirtualize the functions.
Patch all of the call sites to convert to a RenderBox.
Reviewed by Simon Fraser
- dom/Position.cpp: (WebCore::nextRenderedEditable): (WebCore::previousRenderedEditable): (WebCore::Position::getInlineBoxAndOffset):
- rendering/InlineBox.cpp: (WebCore::InlineBox::deleteLine): (WebCore::InlineBox::extractLine): (WebCore::InlineBox::attachLine):
- rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::textWithHardLineBreaks):
- 5:35 PM Changeset in webkit [40880] by
-
- 22 edits in trunk/WebCore
2009-02-11 David Hyatt <hyatt@apple.com>
Eliminate createInlineBox and dirtyLineBoxes from RenderObject. These functions have been devirtualized.
The single call site now calls a helper function that just bit checks and casts before calling the correct
type. RenderBlock's dirtyLineBoxes function was dead code (caused by the RenderFlow deletion), so it has
just been removed.
Reviewed by Eric Seidel
- rendering/RenderBR.cpp:
- rendering/RenderBR.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::createRootInlineBox):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::createInlineBox):
- rendering/RenderBox.h:
- rendering/RenderCounter.cpp:
- rendering/RenderCounter.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::createInlineFlowBox):
- rendering/RenderInline.h:
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::createTextBox):
- rendering/RenderSVGInlineText.h: (WebCore::RenderSVGInlineText::isSVGText):
- rendering/RenderText.cpp: (WebCore::RenderText::createTextBox): (WebCore::RenderText::createInlineTextBox):
- rendering/RenderText.h:
- rendering/bidi.cpp: (WebCore::createInlineBoxForRenderer): (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::layoutInlineChildren):
- 4:37 PM Changeset in webkit [40879] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-11 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Style cleanup.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::CodeLocationCommon::CodeLocationCommon): (JSC::AbstractMacroAssembler::CodeLocationCommon::operator bool): (JSC::AbstractMacroAssembler::CodeLocationCommon::reset): (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForSwitch): (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForExceptionHandler): (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForJSR): (JSC::AbstractMacroAssembler::CodeLocationLabel::getJumpDestination): (JSC::AbstractMacroAssembler::CodeLocationJump::relink): (JSC::AbstractMacroAssembler::CodeLocationJump::CodeLocationJump): (JSC::AbstractMacroAssembler::CodeLocationCall::relink): (JSC::AbstractMacroAssembler::CodeLocationCall::calleeReturnAddressValue): (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall): (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::repatch): (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::CodeLocationDataLabel32): (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::repatch): (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::ProcessorReturnAddress): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::operator void*): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::::CodeLocationCommon::labelAtOffset): (JSC::::CodeLocationCommon::jumpAtOffset): (JSC::::CodeLocationCommon::callAtOffset): (JSC::::CodeLocationCommon::dataLabelPtrAtOffset): (JSC::::CodeLocationCommon::dataLabel32AtOffset):
- 4:35 PM Changeset in webkit [40878] by
-
- 3 edits in trunk/WebCore
2009-02-11 Simon Fraser <Simon Fraser>
No review.
Fix ACCELERATED_COMPOSITING build.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateLayerCompositingState):
- 4:09 PM Changeset in webkit [40877] by
-
- 9 edits in trunk/WebCore
Reviewed by Dave Hyatt.
Adds support for 3D CSS properties (transform-style-3d, perspective,
perspective-origin, and backface-visibility) to RenderStyle and friends
- 3:18 PM Changeset in webkit [40876] by
-
- 5 edits in trunk/WebCore
2009-02-11 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Add a bit on RenderStyle that gets set when running accelerated
transitions of transform or opacity. These ensure that styles
compare as different during the transition, so that interruption
can be detected reliably.
- 2:43 PM Changeset in webkit [40875] by
-
- 11 edits in trunk/WebCore
2009-02-11 David Hyatt <hyatt@apple.com>
Eliminate the virtual position() function from RenderObject. Rename the position() overrides
in RenderText and RenderBox to positionLineBox and devirtualize them.
Patch the one call site to just check for isText() and isBox() and call the methods directly.
Remove some unnecessary overrides of position() on table sections and rows.
Reviewed by Simon Fraser
- rendering/RenderBox.cpp: (WebCore::RenderBox::positionLineBox):
- rendering/RenderBox.h:
- rendering/RenderObject.h:
- rendering/RenderSVGRoot.cpp:
- rendering/RenderSVGRoot.h:
- rendering/RenderTableRow.h: (WebCore::RenderTableRow::lineHeight):
- rendering/RenderTableSection.h: (WebCore::RenderTableSection::lineHeight):
- rendering/RenderText.cpp: (WebCore::RenderText::positionLineBox):
- rendering/RenderText.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::computeVerticalPositionsForLine):
- 2:41 PM Changeset in webkit [40874] by
-
- 2 edits in trunk/LayoutTests
2009-02-11 Scott Violet <sky@google.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=23805
The test transitions/transition-end-event-multiple-03.html occasionally fails.
- transitions/transition-end-event-multiple-03.html: Upped the timeout.
- 2:35 PM Changeset in webkit [40873] by
-
- 3 edits3 copies3 adds in trunk/WebCore
2009-02-11 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23901
Add HTML options/collections V8 custom bindings.
- bindings/v8/custom/V8HTMLCollectionCustom.cpp: Added. (WebCore::getNamedItems): (WebCore::getItem): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLFormElementCustom.cpp: Added. (WebCore::NAMED_PROPERTY_GETTER):
- bindings/v8/custom/V8HTMLInputElementCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_SETTER):
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::removeElement):
- bindings/v8/custom/V8HTMLSelectElementCustom.h: Added.
- bindings/v8/custom/V8NamedNodesCollection.cpp: Added. (WebCore::V8NamedNodesCollection::item): (WebCore::V8NamedNodesCollection::itemWithName):
- bindings/v8/custom/V8NamedNodesCollection.h: Added. (WebCore::V8NamedNodesCollection::V8NamedNodesCollection): (WebCore::V8NamedNodesCollection::length):
- 2:20 PM Changeset in webkit [40872] by
-
- 21 edits in trunk
Added a preference to disable some Inspector's panels.
WebCore:
2009-02-11 Dimitri Dupuis-latour <dupuislatour@apple.com>
Added a preference to disable some Inspector's panels (rdar://6419624, rdar://6419645).
This is controlled via the 'WebKitInspectorHiddenPanels' key; if nothing is specified, all panels are shown.
Reviewed by Timothy Hatcher.
- inspector/InspectorClient.h:
- inspector/InspectorController.cpp: (WebCore::hiddenPanels): (WebCore::InspectorController::hiddenPanels): (WebCore::InspectorController::windowScriptObjectAvailable):
- inspector/InspectorController.h:
- inspector/front-end/inspector.js: (WebInspector.loaded):
- loader/EmptyClients.h: (WebCore::EmptyInspectorClient::hiddenPanels):
WebKit/gtk:
2009-02-11 Dimitri Dupuis-latour <dupuislatour@apple.com>
Stub out InspectorClient::hiddenPanels.
Reviewed by Timothy Hatcher.
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::hiddenPanels):
- WebCoreSupport/InspectorClientGtk.h:
WebKit/mac:
2009-02-11 Dimitri Dupuis-latour <dupuislatour@apple.com>
Added a preference to disable some Inspector's panels (rdar://6419624, rdar://6419645).
This is controlled via the 'WebKitInspectorHiddenPanels' key; if nothing is specified, all panels are shown.
Reviewed by Timothy Hatcher.
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::hiddenPanels):
WebKit/qt:
2009-02-11 Dimitri Dupuis-latour <dupuislatour@apple.com>
Stub out InspectorClientQt::hiddenPanels.
Reviewed by Timothy Hatcher.
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::hiddenPanels):
- WebCoreSupport/InspectorClientQt.h:
WebKit/win:
2009-02-11 Dimitri Dupuis-latour <dupuislatour@apple.com>
Stub out WebInspectorClient::hiddenPanels.
Reviewed by Timothy Hatcher.
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::hiddenPanels):
- WebCoreSupport/WebInspectorClient.h:
WebKit/wx:
2009-02-11 Dimitri Dupuis-latour <dupuislatour@apple.com>
Stub out InspectorClientWx::hiddenPanels.
Reviewed by Timothy Hatcher.
- WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::hiddenPanels):
- WebKitSupport/InspectorClientWx.h:
- 2:06 PM Changeset in webkit [40871] by
-
- 78 edits in trunk/WebCore
2009-02-11 David Hyatt <hyatt@apple.com>
Combine RenderObject::element() and RenderObject::node() into a single function.
node() now has the "anonymous bit" checking behavior of element() and will
return 0 for anonymous content. This patch switches all callers of element()
to node() and patches old callers of node() to deal with situations where they
did not expect node() to be 0. A bunch of node() calls were calling stuff on
Document that they clearly didn't intend, so overall this is a nice improvement.
Reviewed by Sam Weinig
- dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner):
- dom/Element.cpp: (WebCore::Element::offsetParent):
- dom/Position.cpp: (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
- editing/ModifySelectionListLevel.cpp: (WebCore::getStartEndListChildren): (WebCore::IncreaseSelectionListLevelCommand::doApply): (WebCore::DecreaseSelectionListLevelCommand::doApply):
- editing/TextIterator.cpp: (WebCore::TextIterator::advance):
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
- editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::endPositionForLine):
- page/AXObjectCache.cpp: (WebCore::AXObjectCache::get):
- page/AccessibilityList.cpp: (WebCore::AccessibilityList::isUnorderedList): (WebCore::AccessibilityList::isOrderedList): (WebCore::AccessibilityList::isDefinitionList):
- page/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::doAccessibilityHitTest):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isPasswordField): (WebCore::AccessibilityRenderObject::isFileUploadButton): (WebCore::AccessibilityRenderObject::isInputImage): (WebCore::AccessibilityRenderObject::isMultiSelect): (WebCore::AccessibilityRenderObject::isControl): (WebCore::AccessibilityRenderObject::getAttribute): (WebCore::AccessibilityRenderObject::anchorElement): (WebCore::AccessibilityRenderObject::actionElement): (WebCore::AccessibilityRenderObject::mouseButtonListener): (WebCore::AccessibilityRenderObject::helpText): (WebCore::AccessibilityRenderObject::textUnderElement): (WebCore::AccessibilityRenderObject::hasIntValue): (WebCore::AccessibilityRenderObject::intValue): (WebCore::AccessibilityRenderObject::labelElementContainer): (WebCore::AccessibilityRenderObject::title): (WebCore::AccessibilityRenderObject::accessibilityDescription): (WebCore::AccessibilityRenderObject::boundingBoxRect): (WebCore::AccessibilityRenderObject::checkboxOrRadioRect): (WebCore::AccessibilityRenderObject::titleUIElement): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): (WebCore::AccessibilityRenderObject::text): (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange): (WebCore::AccessibilityRenderObject::accessKey): (WebCore::AccessibilityRenderObject::setSelectedTextRange): (WebCore::AccessibilityRenderObject::url): (WebCore::AccessibilityRenderObject::isFocused): (WebCore::AccessibilityRenderObject::setFocused): (WebCore::AccessibilityRenderObject::setValue): (WebCore::AccessibilityRenderObject::isEnabled): (WebCore::AccessibilityRenderObject::visiblePositionRange): (WebCore::AccessibilityRenderObject::index): (WebCore::AccessibilityRenderObject::activeDescendant): (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged): (WebCore::AccessibilityRenderObject::observableObject): (WebCore::AccessibilityRenderObject::roleValue): (WebCore::AccessibilityRenderObject::canSetFocusAttribute): (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
- page/AccessibilityTable.cpp: (WebCore::AccessibilityTable::isTableExposableThroughAccessibility): (WebCore::AccessibilityTable::title):
- page/AccessibilityTableCell.cpp: (WebCore::AccessibilityTableCell::titleUIElement):
- page/AccessibilityTableColumn.cpp: (WebCore::AccessibilityTableColumn::headerObjectForSection):
- page/AccessibilityTableRow.cpp: (WebCore::AccessibilityTableRow::headerObject):
- page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): (WebCore::EventHandler::canMouseDownStartSelect): (WebCore::EventHandler::canMouseDragExtendSelect): (WebCore::EventHandler::shouldDragAutoNode):
- page/Frame.cpp: (WebCore::Frame::searchForLabelsAboveCell): (WebCore::Frame::setFocusedNodeIfNeeded):
- page/FrameView.cpp: (WebCore::FrameView::updateOverflowStatus):
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateAnimationTimer): (WebCore::AnimationController::cancelAnimations): (WebCore::AnimationController::updateAnimations):
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::KeyframeAnimation): (WebCore::KeyframeAnimation::endAnimation):
- page/mac/AccessibilityObjectWrapper.mm: (blockquoteLevel): (AXAttributeStringSetHeadingLevel):
- page/mac/FrameMac.mm: (WebCore::Frame::searchForNSLabelsAboveCell):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::verticallyAlignBoxes): (WebCore::InlineFlowBox::paint): (WebCore::shouldDrawTextDecoration):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDocumentMarkers):
- rendering/RenderBR.cpp: (WebCore::RenderBR::positionForCoordinates):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::handleRunInChild): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::isSelectionRoot): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::positionForBox): (WebCore::RenderBlock::positionForRenderer): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::hasLineIfEmpty): (WebCore::RenderBlock::updateFirstLetter): (WebCore::RenderBlock::updateHitTestResult): (WebCore::RenderBlock::addFocusRingRects):
- rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange): (WebCore::RenderBox::updateBoxModelInfoFromStyle): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::positionForCoordinates):
- rendering/RenderButton.cpp: (WebCore::RenderButton::updateFromElement): (WebCore::RenderButton::canHaveChildren):
- rendering/RenderCounter.cpp: (WebCore::planCounter):
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::findLegend):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::translationForAttributes): (WebCore::RenderForeignObject::calculateLocalTransform):
- rendering/RenderFrame.h: (WebCore::RenderFrame::element):
- rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::imageMap): (WebCore::RenderImage::nodeAtPoint): (WebCore::RenderImage::updateAltText):
- rendering/RenderInline.cpp: (WebCore::RenderInline::cloneInline): (WebCore::RenderInline::updateHitTestResult):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::isTransparent): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::resize): (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::updateOverflowStatus): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::RenderLayer::enclosingElement): (WebCore::RenderLayer::updateHoverActiveState): (WebCore::RenderLayer::updateScrollCornerStyle): (WebCore::RenderLayer::updateResizerStyle):
- rendering/RenderLayer.h: (WebCore::RenderLayer::isRootLayer):
- rendering/RenderListItem.cpp: (WebCore::getParentOfFirstLineBox):
- rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::marqueeSpeed):
- rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::isBody): (WebCore::RenderObject::isHR): (WebCore::RenderObject::isHTMLMarquee): (WebCore::RenderObject::isEditable): (WebCore::RenderObject::addPDFURLRect): (WebCore::RenderObject::showTreeForThis): (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::hasOutlineAnnotation): (WebCore::RenderObject::positionForCoordinates): (WebCore::RenderObject::updateDragState): (WebCore::RenderObject::updateHitTestResult): (WebCore::RenderObject::getUncachedPseudoStyle): (WebCore::RenderObject::getTextDecorationColors): (WebCore::RenderObject::caretMaxOffset): (WebCore::RenderObject::offsetParent):
- rendering/RenderObject.h: (WebCore::RenderObject::isRoot): (WebCore::RenderObject::isInlineContinuation): (WebCore::RenderObject::node): (WebCore::RenderObject::setNode):
- rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::destroyLeftoverChildren):
- rendering/RenderPart.cpp: (WebCore::RenderPart::updateWidgetPosition):
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): (WebCore::RenderPartObject::viewCleared):
- rendering/RenderPath.cpp: (WebCore::RenderPath::calculateLocalTransform): (WebCore::RenderPath::layout): (WebCore::RenderPath::paint): (WebCore::RenderPath::drawMarkersIfNeeded):
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForCoordinates): (WebCore::RenderReplaced::isSelected):
- rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::gradientElement):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::calculateLocalTransform):
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForCoordinates):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::applyContentTransforms): (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::calcViewport): (WebCore::RenderSVGRoot::absoluteTransform):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::calculateLocalTransform): (WebCore::RenderSVGText::layout):
- rendering/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::layoutPath): (WebCore::RenderSVGTextPath::startOffset): (WebCore::RenderSVGTextPath::exactAlignment): (WebCore::RenderSVGTextPath::stretchMethod):
- rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport): (WebCore::RenderSVGViewportContainer::viewportTransform): (WebCore::RenderSVGViewportContainer::nodeAtPoint):
- rendering/RenderTable.cpp: (WebCore::RenderTable::addChild):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::updateFromElement): (WebCore::RenderTableCell::calcPrefWidths):
- rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::updateFromElement):
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild):
- rendering/RenderText.cpp: (WebCore::RenderText::originalText): (WebCore::RenderText::positionForCoordinates):
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
- rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::originalText): (WebCore::RenderTextFragment::previousCharacter):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::isActive): (WebCore::RenderTheme::isChecked): (WebCore::RenderTheme::isIndeterminate): (WebCore::RenderTheme::isEnabled): (WebCore::RenderTheme::isFocused): (WebCore::RenderTheme::isPressed): (WebCore::RenderTheme::isReadOnlyControl): (WebCore::RenderTheme::isHovered):
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::updatePressedState): (WebCore::RenderThemeMac::paintMediaFullscreenButton): (WebCore::RenderThemeMac::paintMediaMuteButton): (WebCore::RenderThemeMac::paintMediaPlayButton): (WebCore::RenderThemeMac::paintMediaSeekBackButton): (WebCore::RenderThemeMac::paintMediaSeekForwardButton): (WebCore::RenderThemeMac::paintMediaSliderTrack): (WebCore::RenderThemeMac::paintMediaSliderThumb): (WebCore::RenderThemeMac::paintMediaTimelineContainer): (WebCore::RenderThemeMac::paintMediaCurrentTime): (WebCore::RenderThemeMac::paintMediaTimeRemaining):
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMediaMuteButton): (WebCore::RenderThemeSafari::paintMediaPlayButton): (WebCore::RenderThemeSafari::paintMediaSliderTrack):
- rendering/RenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeSelection):
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidgetGeometry): (WebCore::RenderWidget::updateWidgetPosition): (WebCore::RenderWidget::nodeAtPoint):
- rendering/RootInlineBox.cpp: (WebCore::isEditableLeaf):
- rendering/SVGRenderSupport.cpp: (WebCore::prepareToRenderSVGContent):
- rendering/SVGRenderTreeAsText.cpp: (WebCore::write):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildLayoutInformation): (WebCore::SVGRootInlineBox::layoutInlineBoxes): (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox): (WebCore::SVGRootInlineBox::buildTextChunks):
- rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::cssPrimitiveToLength):
- svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk): (WebCore::floatWidthOfSubStringUsingSVGFont): (WebCore::Font::drawTextUsingSVGFont):
- svg/SVGTextContentElement.cpp: (WebCore::findInlineTextBoxInTextChunks):
- svg/graphics/SVGPaintServer.cpp: (WebCore::SVGPaintServer::fillPaintServer): (WebCore::SVGPaintServer::strokePaintServer):
- 2:01 PM Changeset in webkit [40870] by
-
- 6 edits in trunk/WebCore
2009-02-11 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
<rdar://problem/3541409> - Further FrameLoader and page cache cleanup
- history/CachedFrame.cpp: (WebCore::CachedFrame::restore): Moved updatePlatformScriptObjects() here.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): Rolled opened() into this method. This method was the only caller and - in the future - will benefit from doing parts of opened()'s work differently. (WebCore::FrameLoader::open): Split off per-frame logic into open(CachedFrame&) method. (WebCore::FrameLoader::closeAndRemoveChild): Added. Do the non-tree related cleanup that FrameTree::removeChild() used to do. (WebCore::FrameLoader::detachFromParent): Call ::closeAndRemoveChild() instead. (WebCore::FrameLoader::cachePageForHistoryItem): Perform the "can cache page" check here.
- loader/FrameLoader.h:
- page/FrameTree.cpp: (WebCore::FrameTree::removeChild): Just remove the Frame from the tree. Closing it and other cleanup is the responsibility of the FrameLoader.
- page/FrameTree.h: (WebCore::FrameTree::detachFromParent): Added to just clear a Frame's parent pointer
- 2:00 PM Changeset in webkit [40869] by
-
- 2 edits in trunk/WebCore
2009-02-11 Scott Violet <sky@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23882
GraphicsContextSkia draws round rects as solid rects
Fixes two bugs in Skia's GraphicsContext::fillRoundedRect:
. fillRoundedRect had an extra call to fillRect, resulting in always
drawing a solid rectangle.
. if the total radius along a given axis is greater than the size of
the axis to draw, a solid rect should be drawn.
The layout tests LayoutTests/fast/css/shadow-multiple.html and
LayoutTests/fast/box-shadow/basic-shadows.html cover this.
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::fillRoundedRect):
- 1:45 PM Changeset in webkit [40868] by
-
- 2 edits in trunk/WebCore
2009-02-11 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Add function to RenderStyle to ask whether a background image has been specified.
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::hasBackgroundImage):
- 1:45 PM Changeset in webkit [40867] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-11 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
- assembler/AbstractMacroAssembler.h: Fix comments.
- 1:13 PM Changeset in webkit [40866] by
-
- 1 edit2 deletes in trunk/WebCore
2009-02-11 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric Seidel.
Bug 23536: Auto-generate HTMLElementFactory
Remove the HTMLElementFactory files. Farewell.
- html/HTMLElementFactory.cpp: Removed.
- html/HTMLElementFactory.h: Removed.
- 1:08 PM Changeset in webkit [40865] by
-
- 9 edits in trunk/WebCore
2009-02-11 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric Seidel.
Bug 23536: Auto-generate HTMLElementFactory
Make the platform auto-generate the HTMLElementFactory.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- webcore-base.bkl:
- 12:52 PM Changeset in webkit [40864] by
-
- 2 edits in trunk/WebCore
2009-02-11 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Remove unneeded ASSERTS.
- rendering/RenderBox.h: (WebCore::RenderBox::width): (WebCore::RenderBox::height): (WebCore::RenderBox::size): (WebCore::RenderBox::frameRect):
- 12:48 PM Changeset in webkit [40863] by
-
- 6 edits in trunk/WebCore
2009-02-11 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
When opacity or transform change on an object which has a compositing layer,
avoid repainting the layer.
Added a new StyleDifference value, StyleDifferenceRecompositeLayer, which indicates
that the only thing styleChanged() has to do is to update composited properties of
the layer. RenderStyle::diff() now has an out param for a bitmask of "context sensitive"
properties, currently for opacity and transform. When one of these changes, we need
to see if we have a compositing layer before we decide whether to layout/repaint,
or just update the composited layer, via adjustStyleDifference().
- 12:18 PM Changeset in webkit [40862] by
-
- 6 edits in trunk
Reviewed by Darin Adler.
<rdar://problem/6562920> Pasted text should be normalized to NFC
Testing requires putting non-HTML content in pasteboard, so it cannot be done with WebKit alone.
WebCore:
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::plainText): Route the text through -[NSString precomposedStringWithCanonicalMapping].
WebKit/mac:
- Misc/WebNSURLExtras.mm: (-[NSURL _web_userVisibleString]): Route the URL string through -[NSString precomposedStringWithCanonicalMapping].
- WebCoreSupport/WebPasteboardHelper.mm: (WebPasteboardHelper::plainTextFromPasteboard): Ditto.
- WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto. The affected cases are all plain text ones - RTF, RTFD and HTML are assumed to be precomposed already, and the conversion is performed outside WebKit for those anyway.
- 12:13 PM Changeset in webkit [40861] by
-
- 14 edits4 adds in trunk
Reviewed by Simon Fraser.
Added new TransformOperation subclasses and methods to existing ones
to support 3D.
- 11:43 AM Changeset in webkit [40860] by
-
- 6 edits in trunk/WebCore
2009-02-11 David Hyatt <hyatt@apple.com>
Move createAnonymousBlock() to RenderBlock. Since anonymous blocks are always parented to some other block,
we can move this function to RenderBlock. Fix a couple of call sites as a result of this restriction.
Reviewed by Simon Fraser
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::createAnonymousBlock):
- rendering/RenderBlock.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::childBecameNonInline):
- rendering/RenderObject.cpp: (WebCore::RenderObject::handleDynamicFloatPositionChange):
- rendering/RenderObject.h:
- 11:10 AM Changeset in webkit [40859] by
-
- 2 edits in trunk/WebCore
2009-02-11 David Hyatt <hyatt@apple.com>
Remove two complete nonsense lines that I accidentally added from a cut and paste error. This
restores the original logic.
Reviewed by Simon Fraser
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
- 11:02 AM Changeset in webkit [40858] by
-
- 11 edits in trunk/WebCore
2009-02-11 David Hyatt <hyatt@apple.com>
Rename getBaselineOfFirstLineBox to firstLineBoxBaseline. Rename getBaselineOfLastLineBox to
lastLineBoxBaseline. Remove the functions from RenderObject and add them to RenderBox instead.
Reviewed by Eric Seidel
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::baselinePosition): (WebCore::RenderBlock::firstLineBoxBaseline): (WebCore::RenderBlock::lastLineBoxBaseline):
- rendering/RenderBlock.h:
- rendering/RenderBox.h: (WebCore::RenderBox::firstLineBoxBaseline): (WebCore::RenderBox::lastLineBoxBaseline):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox):
- rendering/RenderObject.h:
- rendering/RenderTable.cpp: (WebCore::RenderTable::firstLineBoxBaseline):
- rendering/RenderTable.h:
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::baselinePosition):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::firstLineBoxBaseline):
- rendering/RenderTableSection.h:
- 10:14 AM Changeset in webkit [40857] by
-
- 3 edits in trunk/WebCore
2009-02-11 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser
https://bugs.webkit.org/show_bug.cgi?id=23877
Allow port to disable progress events from <video> and <audio> elements
- html/HTMLMediaElement.cpp: Initialize m_sendProgressEvents. (WebCore::HTMLMediaElement::HTMLMediaElement): Don't post progress events if m_sendProgressEvents is false. (WebCore::HTMLMediaElement::initAndDispatchProgressEvent): Ditto. (WebCore::HTMLMediaElement::load): Ditto.
- html/HTMLMediaElement.h: Add m_sendProgressEvents
- 9:20 AM Changeset in webkit [40856] by
-
- 4 edits in trunk
Fix crashes in http/tests/history/redirect-301.pl and friends on Windows
WebKit/win:
Don't release the shared WebHistory instance on quit
This matches Mac, and prevents a race condition when the process exits
that depends on the order in which global destructors are invoked.
Reviewed by Alexey Proskuryakov.
- WebHistory.cpp: (sharedHistoryStorage): Changed to use DEFINE_STATIC_LOCAL so the destructor is never called.
WebKitTools:
Fix crashes in http/tests/history/redirect-301.pl and friends on
Windows
Reviewed by Alexey Proskuryakov.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::webHistoryItemCount): Null-check the shared WebHistory instance before dereferencing it.
- 7:00 AM Changeset in webkit [40855] by
-
- 3 edits in trunk/WebCore
Windows build fix
- DerivedSources.cpp: Removed SVGElementFactory.cpp, since including it leads to ambiguities for symbols like "aTag", which exist in both the HTMLNames and SVGNames namespaces.
- WebCore.vcproj/WebCore.vcproj: Added SVGElementFactory.cpp to the project directly. VS also decided to reformat this file a little bit.
- 4:04 AM Changeset in webkit [40854] by
-
- 3 edits in trunk/JavaScriptCore
Trying to fix wx build.
- bytecode/JumpTable.h: Include "MacroAssembler.h", not <MacroAssembler.h>.
- jscore.bkl: Added assembler directory to search paths.
- 12:21 AM Changeset in webkit [40853] by
-
- 4 edits in trunk/WebCore
2009-02-10 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric Seidel.
Bug 23536: Auto-generate HTMLElementFactory
Those are the last auto-generation bits needed to have a working generated HTMLElementFactory:
- Added a new option mapToTagName that enables a tag to use another's options and tagName (<image> uses imgTag for example) and wired the code generation to be consistent with the current factory.
- Disabled dashboard compatibility check for HTMLElementFactory as it would make at least one test case fail.
- Pass the QualifiedName down to the Element constructor for shared constructors to make the generated code as close as possible to the current one. We will pass the QualifiedName for all Element in a forthcoming patch.
- dom/make_names.pl: Did all the above points and tweaked the code generation to match the current HTMLElementFactory as closely as possible.
- html/HTMLElementFactory.cpp: (WebCore::quoteConstructor):
- html/HTMLQuoteElement.cpp: (WebCore::HTMLQuoteElement::HTMLQuoteElement): Moved setUsesBeforeAfterRules to HTMLQuoteElement' constructor because some part of the code creates elements without using the HTMLElementFactory. Also added a FIXME as it is not the right place.
- html/HTMLTagNames.in: Corrected <image> parameters.
Feb 10, 2009:
- 10:48 PM Changeset in webkit [40852] by
-
- 2 edits in trunk/WebCore
2009-02-10 Jon Honeycutt <jhoneycutt@apple.com>
Windows build fix after r40837.
Not reviewed.
- DerivedSources.cpp:
- 10:38 PM Changeset in webkit [40851] by
-
- 2 edits in trunk/WebKit/mac
2009-02-10 John Sullivan <sullivan@apple.com>
Reviewed by Dan Bernstein
<https://bugs.webkit.org/show_bug.cgi?id=23889>, <rdar://problem/6572300>
Negative visit counts stored in History.plist aren't corrected.
It's not clear how a huge negative visit count ended up in History.plist, but we can't
trust data read from disk so we can at least reset this to something sane. WebCore has
no guard against a visit count overflowing an int, but that seems very unlikely to have
caused this.
- History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): If a negative visit count is in the dictionary, replace it with 1. If a negative daily or weekly visit count is in the dictionary, replace it with 0.
- 10:28 PM Changeset in webkit [40850] by
-
- 3 edits in trunk/WebKit/mac
2009-02-10 John Sullivan <sullivan@apple.com>
Reviewed by Dan Bernstein
<https://bugs.webkit.org/show_bug.cgi?id=23891>
[WebHistoryItem _setVisitCount:] is unused and should be removed
- History/WebHistoryItem.mm: (-[WebHistoryItem _setVisitCount:]): removed this unused method, which is a synonym for setVisitCount: that was introduced recently and abandoned even more recently
- History/WebHistoryItemInternal.h: removed declaration of _setVisitCount:
- 10:06 PM Changeset in webkit [40849] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-10 Gavin Barraclough <barraclough@apple.com>
Build
fix.
(Narrow
changelog
for
dhyatt).
- bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set): (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
- 10:03 PM Changeset in webkit [40848] by
-
- 3 edits in trunk/WebCore
2009-02-10 David Hyatt <hyatt@apple.com>
Fix for pixel test regression in fast/text. Make sure not to add in
the borderTop and paddingTop of the block to the baseline when painting
strict mode text decorations.
Reviewed by Mark Rowe
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintTextDecorations):
- rendering/InlineFlowBox.h:
- 9:46 PM Changeset in webkit [40847] by
-
- 2 edits in trunk/WebCore
2009-02-10 Jon Honeycutt <jhoneycutt@apple.com>
<rdar://6349412> REGRESSION(r37204): Page is not repainted during and
after pan scrolling
Reviewed by Steve Falkenburg.
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): Don't repaint the pan scroll icon rect immediately; we will paint after the view has been scrolled.
- 8:57 PM Changeset in webkit [40846] by
-
- 15 edits in trunk/JavaScriptCore
2009-02-10 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Reduce use of void* / reinterpret_cast in JIT repatching code,
add strong types for Calls and for the various types of pointers
we retain into the JIT generated instruction stream.
No performance impact.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::ImmPtr::ImmPtr): (JSC::AbstractMacroAssembler::ImmPtr::asIntptr): (JSC::AbstractMacroAssembler::Imm32::Imm32): (JSC::AbstractMacroAssembler::Label::Label): (JSC::AbstractMacroAssembler::DataLabelPtr::DataLabelPtr): (JSC::AbstractMacroAssembler::Call::Call): (JSC::AbstractMacroAssembler::Call::link): (JSC::AbstractMacroAssembler::Call::linkTo): (JSC::AbstractMacroAssembler::Jump::Jump): (JSC::AbstractMacroAssembler::Jump::linkTo): (JSC::AbstractMacroAssembler::CodeLocationCommon::CodeLocationCommon): (JSC::AbstractMacroAssembler::CodeLocationCommon::operator bool): (JSC::AbstractMacroAssembler::CodeLocationCommon::reset): (JSC::AbstractMacroAssembler::CodeLocationLabel::CodeLocationLabel): (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForSwitch): (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForExceptionHandler): (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForJSR): (JSC::AbstractMacroAssembler::CodeLocationLabel::getJumpDestination): (JSC::AbstractMacroAssembler::CodeLocationJump::CodeLocationJump): (JSC::AbstractMacroAssembler::CodeLocationJump::relink): (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall): (JSC::AbstractMacroAssembler::CodeLocationCall::relink): (JSC::AbstractMacroAssembler::CodeLocationCall::calleeReturnAddressValue): (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::CodeLocationDataLabel32): (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::repatch): (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr): (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::repatch): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::ProcessorReturnAddress): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::operator void*): (JSC::AbstractMacroAssembler::PatchBuffer::entry): (JSC::AbstractMacroAssembler::PatchBuffer::trampolineAt): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive): (JSC::AbstractMacroAssembler::PatchBuffer::patch): (JSC::AbstractMacroAssembler::PatchBuffer::locationOf): (JSC::AbstractMacroAssembler::PatchBuffer::returnAddressOffset): (JSC::AbstractMacroAssembler::differenceBetween): (JSC::::CodeLocationCommon::labelAtOffset): (JSC::::CodeLocationCommon::jumpAtOffset): (JSC::::CodeLocationCommon::callAtOffset): (JSC::::CodeLocationCommon::dataLabelPtrAtOffset): (JSC::::CodeLocationCommon::dataLabel32AtOffset):
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::call):
- assembler/X86Assembler.h: (JSC::X86Assembler::getCallReturnOffset):
- bytecode/CodeBlock.h: (JSC::CallLinkInfo::CallLinkInfo): (JSC::getStructureStubInfoReturnLocation): (JSC::getCallLinkInfoReturnLocation):
- bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set): (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
- bytecode/JumpTable.h: (JSC::StringJumpTable::ctiForValue): (JSC::SimpleJumpTable::ctiForValue):
- bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::StructureStubInfo):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitCatch): (JSC::prepareJumpTableForStringSwitch):
- interpreter/Interpreter.cpp: (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::getPolymorphicAccessStructureListSlot): (JSC::Interpreter::cti_op_throw): (JSC::Interpreter::cti_op_switch_imm): (JSC::Interpreter::cti_op_switch_char): (JSC::Interpreter::cti_op_switch_string): (JSC::Interpreter::cti_vm_throw):
- jit/JIT.cpp: (JSC::ctiSetReturnAddress): (JSC::ctiPatchCallByReturnAddress): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h: (JSC::CallRecord::CallRecord): (JSC::JIT::compileGetByIdSelf): (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdReplace): (JSC::JIT::compilePutByIdTransition): (JSC::JIT::compilePatchGetArrayLength): (JSC::JIT::emitCTICall):
- jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::linkCall):
- jit/JITInlineMethods.h: (JSC::JIT::emitNakedCall): (JSC::JIT::emitCTICall_internal):
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdSlowCase): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
- 8:42 PM Changeset in webkit [40845] by
-
- 4 edits3 adds in trunk
<rdar://problem/6156755> onMouseOver events do not fire properly for cross frame drag and drop
Reviewed by Adele Peterson.
This problem was caused by incorrectly ignoring whether or not the
default behaviour of the mousedown event was suppressed. If a
mousedown handler in a frame prevents default handling then the
subsequent mousemove events fired for the drag should not be
captured by that frame, should the mouse move out of its bounds.
Test: fast/events/mouse-drag-from-frame.html
- 6:00 PM Changeset in webkit [40844] by
-
- 6 edits in trunk
wx build fixes for recent changes to TransformationMatrix and DOMElement.
- 5:44 PM Changeset in webkit [40843] by
-
- 7 edits in trunk/WebCore
2009-02-10 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Clean up "fallbackAnimating" logic in AnimationBase. This flag indicates
that animation of an accelerated property must run in software for some reason.
Also remove use of private headers in GraphicsLayerCA related to a case
where we may have to fall back on software animation of transform.
- 5:36 PM Changeset in webkit [40842] by
-
- 30 edits in trunk/WebCore
2009-02-10 David Hyatt <hyatt@apple.com>
Some renames on line boxes. xPos()/yPos() -> x()/y(). setXPos()/setYPos() -> setX()/setY(). m_object/object() -> m_renderer/renderer(). textObject() -> textRenderer().
Reviewed by Sam Weinig
- dom/Position.cpp: (WebCore::Position::upstream): (WebCore::Position::downstream):
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): (WebCore::VisiblePosition::localCaretRect):
- editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::endPositionForLine): (WebCore::previousLinePosition): (WebCore::nextLinePosition):
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::nodeAtPoint):
- rendering/InlineBox.cpp: (WebCore::InlineBox::showTreeForThis): (WebCore::InlineBox::height): (WebCore::InlineBox::caretMinOffset): (WebCore::InlineBox::caretMaxOffset): (WebCore::InlineBox::deleteLine): (WebCore::InlineBox::extractLine): (WebCore::InlineBox::attachLine): (WebCore::InlineBox::adjustPosition): (WebCore::InlineBox::paint): (WebCore::InlineBox::nodeAtPoint): (WebCore::InlineBox::selectionState): (WebCore::InlineBox::canAccommodateEllipsis):
- rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::renderer): (WebCore::InlineBox::setX): (WebCore::InlineBox::x): (WebCore::InlineBox::setY): (WebCore::InlineBox::y): (WebCore::InlineBox::topOverflow): (WebCore::InlineBox::bottomOverflow): (WebCore::InlineBox::leftOverflow): (WebCore::InlineBox::rightOverflow): (WebCore::InlineBox::visibleToHitTesting): (WebCore::InlineBox::boxModelObject):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::height): (WebCore::InlineFlowBox::addToLine): (WebCore::InlineFlowBox::removeLineBoxFromRenderObject): (WebCore::InlineFlowBox::extractLineBoxFromRenderObject): (WebCore::InlineFlowBox::attachLineBoxToRenderObject): (WebCore::InlineFlowBox::rendererLineBoxes): (WebCore::InlineFlowBox::onEndChain): (WebCore::InlineFlowBox::determineSpacingForFlowBoxes): (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::verticallyAlignBoxes): (WebCore::InlineFlowBox::adjustMaxAscentAndDescent): (WebCore::verticalPositionForBox): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::nodeAtPoint): (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxShadow): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask): (WebCore::InlineFlowBox::paintTextDecorations):
- rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::borderLeft): (WebCore::InlineFlowBox::borderRight): (WebCore::InlineFlowBox::borderTop): (WebCore::InlineFlowBox::borderBottom): (WebCore::InlineFlowBox::baseline):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::height): (WebCore::InlineTextBox::selectionState): (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::deleteLine): (WebCore::InlineTextBox::extractLine): (WebCore::InlineTextBox::attachLine): (WebCore::InlineTextBox::placeEllipsisBox): (WebCore::InlineTextBox::isLineBreak): (WebCore::InlineTextBox::nodeAtPoint): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::selectionStartEnd): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintCustomHighlight): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::paintDocumentMarkers): (WebCore::InlineTextBox::paintCompositionUnderline): (WebCore::InlineTextBox::textPos): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
- rendering/InlineTextBox.h: (WebCore::InlineTextBox::textRenderer):
- rendering/ListMarkerBox.cpp: (WebCore::ListMarkerBox::isText):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintEllipsisBoxes): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::positionForBox): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::getBaselineOfFirstLineBox): (WebCore::RenderBlock::getBaselineOfLastLineBox): (WebCore::RenderBlock::adjustForBorderFit): (WebCore::RenderBlock::addFocusRingRects):
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight): (WebCore::RenderBox::position): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::absoluteQuads): (WebCore::RenderInline::offsetLeft): (WebCore::RenderInline::offsetTop): (WebCore::RenderInline::linesBoundingBox): (WebCore::RenderInline::relativePositionedInlineOffset): (WebCore::RenderInline::addFocusRingRects): (WebCore::RenderInline::paintOutline):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::localBoundingBox):
- rendering/RenderSVGTSpan.cpp: (WebCore::RenderSVGTSpan::absoluteRects): (WebCore::RenderSVGTSpan::absoluteQuads):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::absoluteQuads): (WebCore::RenderSVGText::relativeBBox):
- rendering/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::absoluteRects): (WebCore::RenderSVGTextPath::absoluteQuads):
- rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects): (WebCore::RenderText::absoluteRectsForRange): (WebCore::RenderText::absoluteQuads): (WebCore::RenderText::absoluteQuadsForRange): (WebCore::RenderText::localCaretRect): (WebCore::RenderText::linesBoundingBox):
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::height): (WebCore::RootInlineBox::clearTruncation): (WebCore::RootInlineBox::placeEllipsis): (WebCore::RootInlineBox::paintEllipsisBox): (WebCore::RootInlineBox::addHighlightOverflow): (WebCore::RootInlineBox::paintCustomHighlight): (WebCore::RootInlineBox::paint): (WebCore::RootInlineBox::nodeAtPoint): (WebCore::RootInlineBox::childRemoved): (WebCore::RootInlineBox::fillLineSelectionGap): (WebCore::RootInlineBox::block): (WebCore::isEditableLeaf): (WebCore::RootInlineBox::closestLeafChildForXPos): (WebCore::RootInlineBox::setVerticalOverflowPositions):
- rendering/RootInlineBox.h: (WebCore::RootInlineBox::bottomOverflow): (WebCore::RootInlineBox::floats): (WebCore::RootInlineBox::setHorizontalOverflowPositions): (WebCore::RootInlineBox::setVerticalSelectionPositions):
- rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGCharacterLayoutInfo::addLayoutInformation):
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphWidth): (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback): (WebCore::SVGInlineTextBoxSelectionRectWalker::chunkPortionCallback): (WebCore::SVGInlineTextBox::svgCharacterHitsPosition): (WebCore::SVGInlineTextBox::nodeAtPoint): (WebCore::SVGInlineTextBox::paintCharacters): (WebCore::SVGInlineTextBox::paintSelection): (WebCore::SVGInlineTextBox::paintDecoration):
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGInlineTextBox):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkEndCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): (WebCore::SVGRootInlineBox::paint): (WebCore::cummulatedWidthOfInlineBoxCharacterRange): (WebCore::cummulatedHeightOfInlineBoxCharacterRange): (WebCore::svgTextRunForInlineTextBox): (WebCore::cummulatedWidthOrHeightOfTextChunk): (WebCore::applyTextAnchorToTextChunk): (WebCore::SVGRootInlineBox::buildLayoutInformation): (WebCore::SVGRootInlineBox::layoutInlineBoxes): (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox): (WebCore::SVGRootInlineBox::buildTextChunks):
- rendering/bidi.cpp: (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeVerticalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::checkLinesForTextOverflow):
- svg/SVGTextContentElement.cpp: (WebCore::cumulativeCharacterRangeLength): (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback): (WebCore::findInlineTextBoxInTextChunks):
- 5:12 PM Changeset in webkit [40841] by
-
- 8 edits in trunk/WebCore
2009-02-10 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Move enclosingCompositingLayer() from RenderObject to RenderLayer, since it
relates to the RenderLayer z-order/overflow structure, rather than the render tree
parent chain. Add a convenience method, ancestorCompositingLayer(), which finds
the enclosing layer excluding self.
Fix enclosingCompositingLayer() to correctly look at stacking context and overflow
lists.
Check for documentBeingDestroyed() in a few places to avoid work on document
teardown.
- 5:05 PM Changeset in webkit [40840] by
-
- 5 edits in trunk/WebCore
2009-02-10 David Hyatt <hyatt@apple.com>
Rename xPos() and yPos() on RenderLayer to x() and y() to match RenderBox. Rename setPos to setLocation.
Reviewed by Simon Fraser
- dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::convertToLayerCoords):
- rendering/RenderLayer.h: (WebCore::RenderLayer::x): (WebCore::RenderLayer::y): (WebCore::RenderLayer::setLocation):
- rendering/RenderTreeAsText.cpp: (WebCore::write): (WebCore::externalRepresentation):
- 4:56 PM Changeset in webkit [40839] by
-
- 4 edits in trunk/WebKit/mac
2009-02-10 Anders Carlsson <andersca@apple.com>
Reviewed by Mark Rowe.
<rdar://problem/6573916>
CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit • WebKit::NetscapePluginInstanceProxy::pluginHostDied + 25.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): If we failed to instantiate the plug-in, invalidate the instance proxy.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invalidate): Remove the instance from the plug-in host's set.
(WebKit::NetscapePluginInstanceProxy::destroy):
Call invalidate().
- 4:17 PM Changeset in webkit [40838] by
-
- 2 edits in trunk/WebCore
2009-02-10 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23879
Add missing PLATFORM(SKIA) changes to TransformationMatrix.h
- platform/graphics/transforms/TransformationMatrix.h:
- 3:42 PM Changeset in webkit [40837] by
-
- 17 edits10 adds in trunk
WebCore:
2009-02-10 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=15897
Please implement getBoundingClientRect and getClientRects
<rdar://problem/6139669>
Cursory implementation of Element.getBoundingClientRect and
Element.getClientRects. Adds necessary infrastructure classes
ClientRect and ClientRectList.
Tests: fast/dom/getBoundingClientRect.html
fast/dom/getClientRects.html
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- dom/ClientRect.cpp: Added. (WebCore::ClientRect::ClientRect):
- dom/ClientRect.h: Added. (WebCore::ClientRect::create): (WebCore::ClientRect::top): (WebCore::ClientRect::right): (WebCore::ClientRect::bottom): (WebCore::ClientRect::left): (WebCore::ClientRect::width): (WebCore::ClientRect::height):
- dom/ClientRect.idl: Added.
- dom/ClientRectList.cpp: Added. (WebCore::ClientRectList::ClientRectList): (WebCore::ClientRectList::~ClientRectList): (WebCore::ClientRectList::length): (WebCore::ClientRectList::item):
- dom/ClientRectList.h: Added. (WebCore::ClientRectList::create):
- dom/ClientRectList.idl: Added.
- dom/Element.cpp: (WebCore::Element::getClientRects): (WebCore::Element::getBoundingClientRect):
- dom/Element.h:
- dom/Element.idl:
- page/DOMWindow.idl:
- rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::absoluteQuads):
LayoutTests:
2009-02-08 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Tests for https://bugs.webkit.org/show_bug.cgi?id=15897
Please implement getBoundingClientRect and getClientRects
<rdar://problem/6139669>
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/domListEnumeration-expected.txt:
- fast/dom/getBoundingClientRect-expected.txt: Added.
- fast/dom/getBoundingClientRect.html: Added.
- fast/dom/getClientRects-expected.txt: Added.
- fast/dom/getClientRects.html: Added.
- fast/dom/resources/domListEnumeration.js:
- fast/js/global-constructors-expected.txt:
- 3:20 PM Changeset in webkit [40836] by
-
- 4 edits in trunk/WebCore
2009-02-10 David Hyatt <hyatt@apple.com>
Get rid of capsLockStateMayHaveChanged on RenderObject. It is only implemented by one class (text fields),
so devirtualize and just query at the single call site.
Reviewed by Eric Seidel
- page/EventHandler.cpp: (WebCore::EventHandler::capsLockStateMayHaveChanged):
- rendering/RenderObject.h:
- rendering/RenderTextControlSingleLine.h:
- 3:00 PM Changeset in webkit [40835] by
-
- 11 edits in trunk/WebCore
2009-02-10 David Hyatt <hyatt@apple.com>
Shrink the size of all RenderObjects (except for RenderInlines) by 4 bytes. This patch moves the cached vertical position member to RenderInlines,
since they were the only objects being queried across multiple lines.
Reviewed by Sam Weinig
- rendering/InlineFlowBox.cpp: (WebCore::verticalPositionForBox): (WebCore::InlineFlowBox::computeLogicalBoxHeights):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::verticalPosition):
- rendering/RenderBoxModelObject.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::verticalPositionFromCache):
- rendering/RenderInline.h: (WebCore::RenderInline::invalidateVerticalPosition):
- rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject):
- rendering/RenderObject.h:
- rendering/RenderText.cpp:
- rendering/RenderText.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 2:29 PM QtWebKitJournal edited by
- (diff)
- 2:26 PM Changeset in webkit [40834] by
-
- 3 edits in trunk/WebCore
2009-02-10 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=23868
Fix code style issues: removed 80-col wrapping, incorrect include style, if statement body on same line.
- bindings/v8/custom/V8HTMLInputElementCustom.cpp:
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
- 1:47 PM Changeset in webkit [40833] by
-
- 1 edit2 adds in trunk/WebCore
2009-02-10 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23868
Add HTMLInputElement and HTMLOptionsCollection V8 custom bindings.
- bindings/v8/custom/V8HTMLInputElementCustom.cpp: Added. (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: Added. (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
- 1:12 PM Changeset in webkit [40832] by
-
- 2 edits in trunk/PlanetWebKit
2009-02-09 Gustavo Noronha Silva <Gustavo Noronha Silva>
Fix Bug 23851: Add my blog's webkit category to Planet
Reviewed by Mark Rowe.
- config.ini: Add Gustavo Noronha's blog webkit category.
- 1:12 PM Changeset in webkit [40831] by
-
- 2 edits in trunk/WebCore
Fix Bug 23871: Assertion failure beneath WebCore::openFunc when running http/tests/security/xss-DENIED-xsl-document-redirect.xml
Reviewed by Alexey Proskuryakov.
Covered by existing tests.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::openFunc): Use the two-parameter KURL constructor so that the string will be parsed. libxml2 gives us a UTF-8-encoded string that needs to be parsed.
- 1:10 PM Changeset in webkit [40830] by
-
- 2 edits in trunk/PlanetWebKit
Add Michael(tm) Smith's blog to Planet WebKit
Rubberstamped by Alexey Proskuryakov.
- config.ini:
- 11:50 AM Changeset in webkit [40829] by
-
- 5 edits in trunk/WebCore
2009-02-10 David Hyatt <hyatt@apple.com>
Shrink the size of all replaced elements (images, form controls, plugins) by 4 bytes by packing the
overflow boolean into the RenderObject base class.
Reviewed by Sam Weinig
- rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject):
- rendering/RenderObject.h: (WebCore::RenderObject::replacedHasOverflow): (WebCore::RenderObject::setReplacedHasOverflow):
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::RenderReplaced): (WebCore::RenderReplaced::~RenderReplaced): (WebCore::RenderReplaced::adjustOverflowForBoxShadow): (WebCore::RenderReplaced::overflowHeight): (WebCore::RenderReplaced::overflowWidth): (WebCore::RenderReplaced::overflowLeft): (WebCore::RenderReplaced::overflowTop): (WebCore::RenderReplaced::overflowRect):
- rendering/RenderReplaced.h:
- 11:32 AM Changeset in webkit [40828] by
-
- 3 edits in trunk/WebCore
2009-02-10 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=23870
Make it possible for a port to require a user gesture for an <audio> or <video> element
to load a url.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_loadRestrictions. (WebCore::HTMLMediaElement::attributeChanged): Only one attribute can change so put an "else" between tests. (WebCore::HTMLMediaElement::load): Return INVALID_STATE_ERR if RequireUserGestureLoadRestriction is set and we are not preocessing a user gesture. (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): Remove unnecessary white space. (WebCore::HTMLMediaElement::play): Ditto. (WebCore::HTMLMediaElement::endScrubbing): Remove unnecessary braces added in r40789. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Cache currentTime() in a local instead of calling it multiple times. (WebCore::HTMLMediaElement::processingUserGesture): New.
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::): Define LoadRestrictions, add m_loadRestrictions.
- 11:12 AM Changeset in webkit [40827] by
-
- 3 edits in trunk/WebCore
2009-02-10 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Sam Weinig.
Remove the SVG checks from FloatPoint3D as it is used
by TransformationMatrix.
- platform/graphics/FloatPoint3D.cpp:
- platform/graphics/FloatPoint3D.h:
- 11:06 AM Changeset in webkit [40826] by
-
- 12 edits in trunk/WebCore
2009-02-10 David Hyatt <hyatt@apple.com>
Remove the m_baseline member variable from all line boxes, since it can easily be computed when needed and did not need to be cached.
Reviewed by Sam Weinig
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::nodeAtPoint):
- rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox):
- rendering/InlineBox.h: (WebCore::InlineBox::InlineBox):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::verticallyAlignBoxes): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::paintTextDecorations):
- rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::marginBorderPaddingLeft): (WebCore::InlineFlowBox::marginBorderPaddingRight): (WebCore::InlineFlowBox::marginLeft): (WebCore::InlineFlowBox::marginRight): (WebCore::InlineFlowBox::borderLeft): (WebCore::InlineFlowBox::borderRight): (WebCore::InlineFlowBox::borderTop): (WebCore::InlineFlowBox::borderBottom): (WebCore::InlineFlowBox::paddingLeft): (WebCore::InlineFlowBox::paddingRight): (WebCore::InlineFlowBox::paddingTop): (WebCore::InlineFlowBox::paddingBottom): (WebCore::InlineFlowBox::includeLeftEdge): (WebCore::InlineFlowBox::includeRightEdge): (WebCore::InlineFlowBox::baseline):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintCompositionUnderline):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::getBaselineOfFirstLineBox): (WebCore::RenderBlock::getBaselineOfLastLineBox):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::baselinePosition):
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::placeEllipsis):
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintDecoration):
- rendering/SVGRootInlineBox.cpp: (WebCore::applyTextAnchorToTextChunk): (WebCore::SVGRootInlineBox::layoutInlineBoxes):
- 9:56 AM Changeset in webkit [40825] by
-
- 5 edits in trunk/WebKitTools
Fix Bug 23869: Pixel tests can't be run on Windows
This patch gets the pixel tests limping along on Windows again.
Reviewed by Dan Bernstein.
- DumpRenderTree/DumpRenderTree.sln: Changed to use the new Debug_Internal configuration of ImageDiff in the Debug_Internal configuration of this solution.
- DumpRenderTree/cg/PixelDumpSupportCG.cpp: (printPNG): Changed to call fwrite in a loop, since this call was failing due to the buffer being too large on Windows. (dumpWebViewAsPixelsAndCompareWithExpected): Removed an unnecessary #if PLATFORM(MAC)/#endif.
- DumpRenderTree/win/ImageDiff.vcproj: Added a Debug_Internal configuration that matches the Debug configuration but also references debug_internal.vsprops.
- DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView): Renamed from getBitmapContextFromWebView to match the name used in the cross-platform code.
- 9:33 AM Changeset in webkit [40824] by
-
- 32 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23867
Eliminate obsolete frame->document() checks
- page/FrameView.cpp: (WebCore::FrameView::paintContents): Apparently due to a typo (document vs. !document), fillWithRed was always set to false, and other branches were never taken. Removing the check for document restores debug-only red color filling.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Only call dispatchWindowObjectAvailable() after a document is created. A client can do anything in its delegate method, so we'd need to have frame->document() checks otherwise. DumpRenderTree uses this delegate to add its custom property, and it was crashing due to null document in JSDOMWindowBase::getOwnPropertySlot().
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getOwnPropertySlot):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener):
- bindings/js/JSNavigatorCustom.cpp: (WebCore::needsYouTubeQuirk):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- bindings/js/ScriptControllerMac.mm: (WebCore::updateRenderingForBindings):
- dom/Document.cpp: (WebCore::Document::initSecurityContext):
- editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): (WebCore::Editor::dispatchCPPEvent): (WebCore::Editor::applyStyle): (WebCore::Editor::applyParagraphStyle):
- editing/EditorCommand.cpp: (WebCore::Editor::Command::execute): (WebCore::Editor::Command::isEnabled): (WebCore::Editor::Command::state): (WebCore::Editor::Command::value):
- editing/SelectionController.cpp: (WebCore::SelectionController::recomputeCaretRect): (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::selectAll): (WebCore::SelectionController::setFocused):
- inspector/InspectorController.cpp: (WebCore::getResourceDocumentNode):
- inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
- loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::subresource): (WebCore::DocumentLoader::getSubresources):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::stop): (WebCore::FrameLoader::iconURL): (WebCore::FrameLoader::executeIfJavaScriptURL): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::endIfNotLoadingMainResource): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::gotoAnchor): (WebCore::FrameLoader::loadDone): (WebCore::FrameLoader::checkCompleted): (WebCore::FrameLoader::checkCallImplicitClose): (WebCore::FrameLoader::scheduleRefresh): (WebCore::FrameLoader::outgoingOrigin): (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::logCanCacheFrameDecision): (WebCore::FrameLoader::updatePolicyBaseURL): (WebCore::FrameLoader::setPolicyBaseURL): (WebCore::FrameLoader::frameDetached): (WebCore::FrameLoader::shouldScrollToAnchor): (WebCore::FrameLoader::saveDocumentState):
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create):
- loader/icon/IconFetcher.cpp: (WebCore::IconFetcher::create):
- loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
- page/Chrome.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
- page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::alert): (WebCore::DOMWindow::confirm): (WebCore::DOMWindow::prompt): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::getMatchedCSSRules): (WebCore::DOMWindow::openDatabase): (WebCore::DOMWindow::scrollBy): (WebCore::DOMWindow::scrollTo):
- page/EventHandler.cpp: (WebCore::EventHandler::allowDHTMLDrag): (WebCore::EventHandler::scrollOverflow): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::capsLockStateMayHaveChanged): (WebCore::EventHandler::sendResizeEvent): (WebCore::EventHandler::sendScrollEvent):
- page/FocusController.cpp: (WebCore::deepFocusableNode): (WebCore::FocusController::advanceFocus):
- page/Frame.cpp: (WebCore::Frame::setFocusedNodeIfNeeded): (WebCore::Frame::shouldApplyTextZoom): (WebCore::Frame::shouldApplyPageZoom): (WebCore::Frame::setZoomFactor): (WebCore::Frame::setPrinting): (WebCore::Frame::reapplyStyles): (WebCore::Frame::isContentEditable): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::applyEditingStyleToBodyElement): (WebCore::Frame::removeEditingStyleFromBodyElement): (WebCore::Frame::contentRenderer): (WebCore::Frame::styleForSelectionStart): (WebCore::Frame::setSelectionFromNone): (WebCore::Frame::findString): (WebCore::Frame::markAllMatchesForText): (WebCore::Frame::setMarkedTextMatchesAreHighlighted): (WebCore::Frame::documentTypeString): (WebCore::Frame::shouldClose): (WebCore::Frame::respondToChangedSelection):
- page/FrameView.cpp: (WebCore::FrameView::~FrameView): (WebCore::FrameView::createScrollbar): (WebCore::FrameView::layout): (WebCore::FrameView::layoutTimerFired): (WebCore::FrameView::scheduleRelayout): (WebCore::FrameView::needsLayout): (WebCore::FrameView::unscheduleRelayout): (WebCore::FrameView::windowClipRect):
- page/Geolocation.cpp: (WebCore::Geolocation::disconnectFrame):
- page/Page.cpp: (WebCore::networkStateChanged): (WebCore::Page::~Page): (WebCore::Page::unmarkAllTextMatches): (WebCore::Page::setMediaVolume):
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateRenderingDispatcherFired):
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::currentKeyboardEvent): (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
- page/mac/FrameMac.mm: (WebCore::Frame::dashboardRegionsDictionary): (WebCore::Frame::setUserStyleSheetLocation): (WebCore::Frame::setUserStyleSheet):
- storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::dispatchStorageEvent):
- storage/SessionStorageArea.cpp: (WebCore::SessionStorageArea::dispatchStorageEvent):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::setContainerSize): (WebCore::SVGImage::usesContainerSize): (WebCore::SVGImage::size): (WebCore::SVGImage::hasRelativeWidth): (WebCore::SVGImage::hasRelativeHeight): Removed frame->document() checks.
- 9:00 AM Changeset in webkit [40823] by
-
- 2 edits in trunk/WebCore
2009-02-10 Adam Treat <adam.treat@torchmobile.com>
Reviewed by George Staikos.
Attempt to fix the Qt build after r40791.
- rendering/RenderSVGRoot.cpp:
- 8:55 AM Changeset in webkit [40822] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fixing ChangeLog entry to include a bug link and description. Thanks to Darin
Adler for noticing the omission.
- 7:52 AM Changeset in webkit [40821] by
-
- 3 edits in trunk/WebKitTools
Robustify DumpRenderTree/win a little
DumpRenderTree was previously not holding a ref to the WebViews it
created via window.open. It was getting away with this because
WebViews get reffed by being preference notification observers and by
registering for drag-n-drop messages. Now DRT does hold a ref, in case
this situation changes in the future.
Reviewed by Alexey Proskuryakov.
- DumpRenderTree/win/DumpRenderTree.cpp: (dumpBackForwardListForAllWindows): Added a .get(). (windowToWebViewMap): Changed to use the WindowToWebViewMap typedef.
- DumpRenderTree/win/DumpRenderTreeWin.h: Changed the windowToWebViewMap() to hold a ref to the WebViews it contains.
- 7:51 AM Changeset in webkit [40820] by
-
- 2 edits in trunk/WebKit/win
Fix recursive WebView destruction when running DumpRenderTree
DumpRenderTree would call DestroyWindow on a WebView's host window,
which would send a WM_DESTROY message to the WebView's window. Inside
the WebView's WndProc, we would hold a ref to the WebView, then call
close() and revokeDragDrop(), which would release all remaining
references to the WebView other than the ref we held in the WndProc.
When the WndProc exited, the final ref to the WebView would be
released, invoking WebView's destructor. At this point,
IsWindow(m_viewWindow) would return true, since we were still in the
process of handling WM_DESTROY, so we would call DestroyWindow on the
WebView's window again, re-entering the WndProc and re-reffing the
WebView, leading to recursive destruction.
Reviewed by Alexey Proskuryakov.
- WebView.cpp: (WebView::~WebView): Don't call DestroyWindow if our window is already being destroyed. (WebViewWndProc): Only hold an extra ref to the WebView when we're not being destroyed.
- 7:28 AM Changeset in webkit [40819] by
-
- 2 edits in trunk/WebKit/qt
2009-02-10 Karsten Heimrich <kheimric@trolltech.com>
Reviewed by Simon Hausmann.
Fixes missing navigation/url update while clicking on anchor inside
webpage.
- 7:16 AM Changeset in webkit [40818] by
-
- 2 edits in trunk/WebKit/qt
2009-02-10 Adam Treat <adam.treat@torchmobile.com>
Fix the Qt build as class Selection is now VisibleSelection.
- Api/qwebpage.cpp: (QWebPage::inputMethodQuery):
- 6:34 AM Changeset in webkit [40817] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix after r40813
- JavaScriptCore.vcproj/jsc/jsc.vcproj: Added profiler/ to the include path so that Profiler.h can be found.
- 6:28 AM Changeset in webkit [40816] by
-
- 2 edits in trunk/WebCore
2009-02-10 Adam Treat <adam.treat@torchmobile.com>
Reviewed by George Staikos.
Minor code cleanup.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::replaceChild):
- 6:27 AM Changeset in webkit [40815] by
-
- 2 edits in trunk/WebCore
2009-02-10 Adam Treat <adam.treat@torchmobile.com>
Fix Qt build following r40793.
- editing/qt/EditorQt.cpp:
- 1:20 AM Changeset in webkit [40814] by
-
- 3 edits2 adds in trunk
2009-02-10 Feng Qian <feng@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix crashes when accessing navigator object of a deleted frame.
https://bugs.webkit.org/show_bug.cgi?id=23626
A layout test is added: fast/dom/navigator-detached-no-crash.html
- page/Navigator.cpp: (WebCore::Navigator::cookieEnabled): (WebCore::Navigator::javaEnabled):
- 12:43 AM Changeset in webkit [40813] by
-
- 9 edits1 add in trunk/JavaScriptCore
2009-02-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Provide a class type for a generated block of JIT code.
Also changes the return address -> bytecode index map to
track the return addess as an unsigned offset into the code
instead of a ptrdiff_t in terms of voids - the latter is
equal to the actual offset / sizeof(void*), making it a
potentially lossy representation.
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::PatchBuffer::returnAddressOffset):
- assembler/X86Assembler.h: (JSC::X86Assembler::getCallReturnOffset):
- bytecode/CodeBlock.h: (JSC::CallReturnOffsetToBytecodeIndex::CallReturnOffsetToBytecodeIndex): (JSC::getCallReturnOffset): (JSC::CodeBlock::getBytecodeIndex): (JSC::CodeBlock::jitCode): (JSC::CodeBlock::callReturnIndexVector):
- interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::cti_vm_dontLazyLinkCall): (JSC::Interpreter::cti_vm_lazyLinkCall):
- jit/JIT.cpp: (JSC::JIT::privateCompile):
- jit/JIT.h: (JSC::):
- jit/JITCall.cpp: (JSC::JIT::linkCall):
- jit/JITCode.h: Added. (JSC::): (JSC::JITCode::JITCode): (JSC::JITCode::operator bool): (JSC::JITCode::addressForCall): (JSC::JITCode::offsetOf): (JSC::JITCode::execute):
- 12:34 AM Changeset in webkit [40812] by
-
- 6 edits in trunk/WebCore
2009-02-10 Sverrir Berg <sverrir@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23630
Add complex font rendering using Skia instead of Windows ScriptTextOut.
This adds support for enhanced webkit styles when drawing complex
glyphs.
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):
- platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::containsMissingGlyphs): (WebCore::UniscribeHelper::draw): (WebCore::UniscribeHelper::shape):
- platform/graphics/chromium/UniscribeHelper.h:
- platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleTextDrawing): (WebCore::skiaDrawText): (WebCore::paintSkiaText):
- platform/graphics/skia/SkiaFontWin.h:
- 12:26 AM Changeset in webkit [40811] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-09 John Grabowski <jrg@chromium.org>
Reviewed by Darin Adler.
- wtf/ThreadingPthreads.cpp: (WTF::initializeThreading): (WTF::isMainThread):
- 12:16 AM Changeset in webkit [40810] by
-
- 4 edits in trunk/WebCore
2009-02-10 Darin Fisher <darin@chromium.org>
Revert r40797 as requested by Sam Weinig.
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.idl:
- html/HTMLCanvasElement.idl:
- 12:12 AM Changeset in webkit [40809] by
-
- 3 edits in trunk/WebCore
2009-02-09 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23855
Fix TransformationMatrixSkia.cpp and GraphicsContextSkia.cpp bustage
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::getCTM):
- platform/graphics/skia/TransformationMatrixSkia.cpp: (WebCore::TransformationMatrix::operator SkMatrix):
Feb 9, 2009:
- 9:41 PM Changeset in webkit [40808] by
-
- 3 edits in trunk/WebCore
Reviewed by Dave Hyatt.
- fix <rdar://problem/6568942> REGRESSION: Font rendering in Wikipedia input field is incorrect (default GDI text mode)
- platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::widthForGDIGlyph): Make sure that the DC is in the advanced graphics mode before calling GetCharWidthI(), because otherwise that function returns incorrect results for the default UI font at a certain size.
- 9:22 PM Changeset in webkit [40807] by
-
- 7 edits in trunk
2009-02-09 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser
Added 3D functions to WebKitCSSMatrix. This depends on the 3D functions
added to TransformationMatrix in https://bugs.webkit.org/show_bug.cgi?id=6868
Test: transforms/3d/cssmatrix-3d-interface.xhtml
- 9:20 PM Changeset in webkit [40806] by
-
- 2 edits in trunk/WebKit/mac
Fix <https://bugs.webkit.org/show_bug.cgi?id=23863> / <rdar://problem/6571390>.
Bug 23863: Reproducible crash in Mail with TOT WebKit when creating a new message
Reviewed by Dan Bernstein.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Nil-check _private as it may have not
yet been initialized if this WebHTMLView was loaded from a nib.
(-[WebHTMLView _removeSuperviewObservers]): Ditto.
- 7:13 PM Changeset in webkit [40805] by
-
- 3 edits in trunk/LayoutTests/platform/mac/fast/inline
Land updated layout tests after recent changes.
- 7:13 PM Changeset in webkit [40804] by
-
- 3 edits2 adds in trunk
Fix <https://bugs.webkit.org/show_bug.cgi?id=23858>
Bug 23858: Crash when removing a HTMLSelectElement from the document from inside its focus event handler
Reviewed by Darin Adler.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Don't store the renderer in a local variable
as it can be invalidated by any of the calls to focus() within the function. Instead, retrieve it and
null-check it when it is needed.
Test for <https://bugs.webkit.org/show_bug.cgi?id=23858>
Bug 23858: Crash when removing a HTMLSelectElement from the document from inside its focus event handler
Reviewed by Sam Weinig.
- fast/dom/HTMLSelectElement/remove-element-from-within-focus-handler-crash-expected.txt: Added.
- fast/dom/HTMLSelectElement/remove-element-from-within-focus-handler-crash.html: Added.
- 7:00 PM Changeset in webkit [40803] by
-
- 2 edits in trunk/LayoutTests/platform/mac/svg/custom
Land updated svg layout tests after recent changes.
- 6:47 PM Changeset in webkit [40802] by
-
- 16 edits in trunk/WebCore
2009-02-09 David Hyatt <hyatt@apple.com>
Remove the m_height member from InlineBox. This shaves 4 bytes off of all inline boxes. Unfortunately SVG
sets heights that are independent of the renderer or of the font, and so all SVG boxes have to retain m_height
member variables.
height() on InlineBox is now a virtual function that does a dynamic computation (including shrinking boxes
with no text children). For SVG boxes there is also a non-virtual setHeight function for updating the
m_height member variable like before.
Reviewed by Darin Adler
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
- rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox):
- rendering/InlineBox.cpp: (WebCore::InlineBox::height): (WebCore::InlineBox::root):
- rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::isInlineFlowBox): (WebCore::InlineBox::isRootInlineBox): (WebCore::InlineBox::topOverflow): (WebCore::InlineBox::bottomOverflow): (WebCore::InlineBox::leftOverflow): (WebCore::InlineBox::rightOverflow):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::height): (WebCore::InlineFlowBox::adjustMaxAscentAndDescent): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren): (WebCore::InlineFlowBox::nodeAtPoint):
- rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::isInlineFlowBox):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::height): (WebCore::InlineTextBox::nodeAtPoint): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintCompositionUnderline):
- rendering/InlineTextBox.h:
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::height): (WebCore::RootInlineBox::placeEllipsis): (WebCore::RootInlineBox::setVerticalOverflowPositions):
- rendering/RootInlineBox.h: (WebCore::RootInlineBox::isRootInlineBox): (WebCore::RootInlineBox::topOverflow): (WebCore::RootInlineBox::bottomOverflow): (WebCore::RootInlineBox::leftOverflow): (WebCore::RootInlineBox::rightOverflow): (WebCore::RootInlineBox::selectionBottom): (WebCore::RootInlineBox::Overflow::Overflow): (WebCore::RootInlineBox::setVerticalSelectionPositions):
- rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::SVGInlineFlowBox): (WebCore::SVGInlineFlowBox::height): (WebCore::SVGInlineFlowBox::setHeight):
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::SVGInlineTextBox):
- rendering/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::height): (WebCore::SVGInlineTextBox::setHeight):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::layoutInlineBoxes):
- rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::SVGRootInlineBox): (WebCore::SVGRootInlineBox::height): (WebCore::SVGRootInlineBox::setHeight):
- 5:32 PM Changeset in webkit [40801] by
-
- 4 edits in trunk/WebCore
Reviewed by Sam Weinig.
Document our Selection DOM extensions
(in preparation for re-writing Selection to work with ranges)
- page/DOMSelection.cpp: (WebCore::DOMSelection::type):
- page/DOMSelection.h:
- page/DOMSelection.idl:
- 5:31 PM Changeset in webkit [40800] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Minor bugfix, incorrect check meant that subtraction causing integer overflow
would be missed on x86-64 JIT.
- jit/JITArithmetic.cpp: (JSC::JIT::compileBinaryArithOp):
- 5:28 PM Changeset in webkit [40799] by
-
- 3 edits in trunk/JavaScriptCore
2009-02-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
A more sensible register allocation for x86-64.
When WREC was ported to x86-64 it stuck with the same register allocation as x86.
This requires registers to be reordered on entry into WREC generated code, since
argument passing is different on x86-64 and x86 (regparm(3)). This patch switches
x86-64 to use a native register allocation, that does not require argument registers
to be reordered.
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateReturnSuccess): (JSC::WREC::Generator::generateReturnFailure):
- wrec/WRECGenerator.h:
- 5:10 PM Changeset in webkit [40798] by
-
- 2 edits in trunk/WebCore
Attempt to fix wx build
- WebCoreSources.bkl: change Selection to VisibleSelection
- 2:32 PM Changeset in webkit [40797] by
-
- 4 edits in trunk/WebCore
2009-02-06 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23809
Return CanvasRenderingContext2D instead of DOMObject in IDL to avoid V8 #ifdefs
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.idl:
- html/HTMLCanvasElement.idl:
- 2:17 PM Changeset in webkit [40796] by
-
- 2 edits in trunk/WebCore
Fix the gtk build by adding VisibleSelection and removing Selection.
- GNUmakefile.am:
- 2:09 PM Changeset in webkit [40795] by
-
- 7 edits in trunk/WebCore
2009-02-09 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
Transform the gradient instead of the context for most platforms and
transform the context after CGContextReplacePathWithStrokedPath for CG.
REGRESSION: SVG gradient transformation/BoundingBox can cause ugly stroke thickness
https://bugs.webkit.org/show_bug.cgi?id=23547
- platform/graphics/Gradient.h: (WebCore::Gradient::setGradientSpaceTransform): (WebCore::Gradient::gradientSpaceTransform):
- platform/graphics/cairo/GradientCairo.cpp: (WebCore::Gradient::platformGradient):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect):
- platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::platformGradient):
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::SVGPaintServerGradient): (WebCore::clipToTextMask): (WebCore::SVGPaintServerGradient::setup): (WebCore::SVGPaintServerGradient::teardown):
- 2:05 PM Changeset in webkit [40794] by
-
- 2 edits in trunk/WebCore
2009-02-09 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Fix the highlight when inspecting inline elements.
- inspector/InspectorController.cpp: (WebCore::drawHighlightForBox): (WebCore::drawHighlightForLineBoxes): (WebCore::InspectorController::drawNodeHighlight):
- 1:43 PM Changeset in webkit [40793] by
-
- 66 edits2 moves in trunk
First pass at s/Selection/VisibleSelection
- 1:07 PM Changeset in webkit [40792] by
-
- 3 edits2 adds in trunk
WebCore:
2009-02-09 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23806
Fix a regression crash where an empty src value and a "text/html" type
on an EMBED element did not finish ResourceRequest initialization due to
an early return.
Test: fast/loader/empty-embed-src-attribute.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
LayoutTests:
2009-02-09 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23806
New test for the crash with an embed element with an empty src and
"text/html" type.
- fast/loader/empty-embed-src-attribute-expected.txt: Added.
- fast/loader/empty-embed-src-attribute.html: Added.
- 12:55 PM Changeset in webkit [40791] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23816
Clean up RenderSVGRoot.cpp
Clean up RenderSVGRoot.cpp.
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::calcViewport):
- 12:41 PM Changeset in webkit [40790] by
-
- 2 edits in trunk
2009-02-09 Calvin Walton <calvin.walton@gmail.com>
Reviewed by Holger Freyther.
[Gtk] Fix build with recent autotools
Current versions of automake/libtool don't assume you want C++ enabled
by default any more, so explicitly check for a C++ compiler.
- configure.ac: Add AC_PROG_CXX macro
- 11:48 AM Changeset in webkit [40789] by
-
- 6 edits in trunk/WebCore
2009-02-09 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti Koivisto
https://bugs.webkit.org/show_bug.cgi?id=23737
Make it possible to control media element playback without knowing so many
internal implementation details.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::togglePlayState): New, toggle between playing and paused state. (WebCore::HTMLMediaElement::beginScrubbing): New, pause as necessary for scrubbing mode. (WebCore::HTMLMediaElement::endScrubbing): New, resume playback if paused for scrubbing mode.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::hasVideo): New, added so clients don't need to access MediaPlayer directly.
- html/HTMLVideoElement.h:
(WebCore::HTMLVideoElement::hasVideo): New.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Use new media element togglePlayState method. (WebCore::MediaControlTimelineElement::defaultEventHandler): Tell media element when scrubbing begins and ends so it can deal with pausing logic. Don't call setCurrentTime unless the time will change.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls): Ask media element if it is able to play instead of including internal logic here. (WebCore::RenderMedia::updateControlVisibility): Ditto.
- 11:37 AM Changeset in webkit [40788] by
-
- 5 edits in trunk/WebCore
2009-02-09 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti Koivisto
Change RenderPart and RenderPartObject constructors to take a Node*
instead of a HTMLFrameOwnerElement* since that is all then need.
- rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): take Node* instead of HTMLFrameOwnerElement*
- rendering/RenderPart.h:
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::RenderPartObject): take Node* instead of HTMLFrameOwnerElement*
- rendering/RenderPartObject.h:
- 11:28 AM Changeset in webkit [40787] by
-
- 5 edits in trunk/WebCore
- fix -Wmissing-prototypes builds
- editing/ReplaceSelectionCommand.cpp: (WebCore::isHeaderElement): Marked this function static. (WebCore::haveSameTagName): Ditto.
- editing/markup.cpp: (WebCore::isSpecialAncestorBlock): Ditto.
- platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::makeMapBetweenRects): Removed unused function.
- platform/graphics/transforms/TransformationMatrix.h: Removed unused declaration of private member makeMapBetweenRects().
- 11:21 AM Changeset in webkit [40786] by
-
- 2 edits in trunk/WebKit/mac
2009-02-06 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Fix crash when plug-in host dies.
- Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::didFail):
- 11:03 AM Changeset in webkit [40785] by
-
- 3 edits in trunk/WebCore
2009-02-09 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=23850
Code cleanup of HTMLParser class which was using a mix of m_* and bare
class member variable names which helps to obfuscate the code. Also
changed a few of the static helper functions to take a const pointer type
as they should not be modifying the node.
- html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::~HTMLParser): (WebCore::HTMLParser::reset): (WebCore::HTMLParser::setCurrent): (WebCore::HTMLParser::parseToken): (WebCore::HTMLParser::parseDoctypeToken): (WebCore::isTableSection): (WebCore::isTablePart): (WebCore::isTableRelated): (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::textCreateErrorCheck): (WebCore::HTMLParser::commentCreateErrorCheck): (WebCore::HTMLParser::headCreateErrorCheck): (WebCore::HTMLParser::bodyCreateErrorCheck): (WebCore::HTMLParser::framesetCreateErrorCheck): (WebCore::HTMLParser::formCreateErrorCheck): (WebCore::HTMLParser::isindexCreateErrorCheck): (WebCore::HTMLParser::noscriptCreateErrorCheck): (WebCore::HTMLParser::pCloserStrictCreateErrorCheck): (WebCore::HTMLParser::mapCreateErrorCheck): (WebCore::HTMLParser::getNode): (WebCore::HTMLParser::allowNestedRedundantTag): (WebCore::HTMLParser::processCloseTag): (WebCore::HTMLParser::isInline): (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::reopenResidualStyleTags): (WebCore::HTMLParser::pushBlock): (WebCore::HTMLParser::popBlock): (WebCore::HTMLParser::popOneBlockCommon): (WebCore::HTMLParser::popOneBlock): (WebCore::HTMLParser::moveOneBlockToStack): (WebCore::HTMLParser::checkIfHasPElementInScope): (WebCore::HTMLParser::popInlineBlocks): (WebCore::HTMLParser::freeBlock): (WebCore::HTMLParser::createHead): (WebCore::HTMLParser::handleIsindex): (WebCore::HTMLParser::startBody): (WebCore::HTMLParser::finished): (WebCore::HTMLParser::reportErrorToConsole):
- html/HTMLParser.h:
- 10:38 AM Changeset in webkit [40784] by
-
- 2 edits in trunk/WebCore
Applying review comment on a second location.
- rendering/RenderText.cpp: (WebCore::RenderText::nextOffset): Use "ifdef BUILDING_ON_TIGER".
- 10:35 AM Changeset in webkit [40783] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23845
editing/deleting/backward-deletion.html fails on Tiger
- rendering/RenderText.cpp: (WebCore::RenderText::previousOffset): (WebCore::RenderText::nextOffset): Work around a bug in older ICU versions by hardcoding narrow voiced marks.
- 7:49 AM Changeset in webkit [40782] by
-
- 2 edits in trunk/WebCore
Windows build fix
- WebCore.vcproj/WebCore.vcproj: Fix the XML syntax.
- 2:13 AM Changeset in webkit [40781] by
-
- 6 edits in trunk/WebCore
2009-02-09 Jian Li <jianli@chromium.org>
Reviewed by Alexey Proskuryakov.
Make WorkerMessagingProxy derive from two base proxy classes.
https://bugs.webkit.org/show_bug.cgi?id=23777
- bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
- dom/Worker.cpp: (WebCore::Worker::terminate): (WebCore::Worker::hasPendingActivity):
- dom/WorkerContext.cpp: (WebCore::WorkerContext::reportException):
- dom/WorkerMessagingProxy.cpp: (WebCore::WorkerThreadActivityReportTask::performTask): (WebCore::WorkerMessagingProxy::postExceptionToWorkerObject): (WebCore::WorkerMessagingProxy::workerObjectDestroyed): (WebCore::WorkerMessagingProxy::terminateWorkerContext): (WebCore::WorkerMessagingProxy::confirmWorkerThreadMessage): (WebCore::WorkerMessagingProxy::reportPendingActivity): (WebCore::WorkerMessagingProxy::reportPendingActivityInternal): (WebCore::WorkerMessagingProxy::hasPendingActivity):
- dom/WorkerMessagingProxy.h:
- 2:00 AM Changeset in webkit [40780] by
-
- 4 edits2 adds in trunk/WebCore
2009-02-09 Jian Li <jianli@chromium.org>
Reviewed by Alexey Proskuryakov.
Introduce 2 base classes to split WorkerMessagingProxy.
https://bugs.webkit.org/show_bug.cgi?id=23776
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/WorkerContextProxy.h: Added. (WebCore::WorkerContextProxy::~WorkerContextProxy):
- dom/WorkerObjectProxy.h: Added. (WebCore::WorkerObjectProxy::~WorkerObjectProxy):
- 1:32 AM Changeset in webkit [40779] by
-
- 1 edit1 add in trunk/LayoutTests
Land results for a recently added test (https://bugs.webkit.org/show_bug.cgi?id=23601).
- fast/dom/Selection/getRangeAt-expected.txt: Added.
Feb 8, 2009:
- 11:15 PM Changeset in webkit [40778] by
-
- 2 edits4 adds in trunk
2009-02-08 David Hyatt <hyatt@apple.com>
Make sure that generated content is properly handled when content is moved from a block run-in
to an inline run-in.
Reviewed by Sam Weinig
Added fast/runin/002.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):
- 10:03 PM Changeset in webkit [40777] by
-
- 2 edits in trunk/WebCore
2009-02-08 David Hyatt <hyatt@apple.com>
Fix for https://bugs.webkit.org/show_bug.cgi?id=23832, crash when inspecting an image using the
Web inspector.
Reviewed by Mark Rowe
- rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRectsForRange): (WebCore::RenderObject::absoluteQuadsForRange):
- 12:44 PM Changeset in webkit [40776] by
-
- 2 edits in trunk/WebCore
2009-02-08 Dirk Schulze <krit@webkit.org>
Unreviewed Qt build fix.
TransformationMatrix changes in r40761 broke QT build.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::scale):
- 12:03 PM Changeset in webkit [40775] by
-
- 2 edits in trunk/WebCore
2009-02-08 Dirk Schulze <krit@webkit.org>
Reviewed by Holger Freyther.
This is a follow up of the last commit. It cleans up TransformationMatrix.h
and convert to a series of #elif.
- platform/graphics/transforms/TransformationMatrix.h:
- 11:49 AM Changeset in webkit [40774] by
-
- 4 edits in trunk/WebCore
2009-02-08 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Simon Fraser.
[CAIRO] build broken by TransformationMatrix rework
https://bugs.webkit.org/show_bug.cgi?id=23831
Fixed cairo build after the TransformationMatrix rework done in
revision 40761.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::concatCTM):
- platform/graphics/cairo/TransformationMatrixCairo.cpp: (WebCore::TransformationMatrix::operator cairo_matrix_t):
- platform/graphics/transforms/TransformationMatrix.h:
- 1:49 AM QtWebKitFeatures45 edited by
- (diff)
- 1:00 AM Changeset in webkit [40773] by
-
- 4 edits in branches/Safari-6528
Versioning.
- 12:59 AM Changeset in webkit [40772] by
-
- 1 copy in tags/Safari-6528.13
New tag.
Feb 7, 2009:
- 11:03 PM Changeset in webkit [40771] by
-
- 4 edits in trunk/WebCore
2009-02-07 David Hyatt <hyatt@apple.com>
Shrink the size of all InlineTextBoxes and all InlineBoxes (for images and replaced elements) by four bytes.
Change the overflow variable on InlineFlowBoxes into a short and move the bits for InlineFlowBoxes out of the
base InlineBox class. Since the number of bits in the base class was 35, shoving the 3 bits for InlineFlowBoxes
back down into that class (into the 16 bits exposed by making the overflow variable into a short), all text
boxes and image boxes shrink by 4 bytes.
Reviewed by Anders
- rendering/InlineBox.h: (WebCore::InlineBox::InlineBox):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically):
- rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox): (WebCore::InlineFlowBox::maxHorizontalVisualOverflow): (WebCore::InlineFlowBox::hasTextChildren):
- 10:17 PM Changeset in webkit [40770] by
-
- 3 edits in trunk/WebCore
2009-02-07 Dean Jackson <dino@apple.com>
Attempted build fix for Qt. Not reviewed.
TransformationMatrix changes in r40761 broke non-Apple builds.
- platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::TransformationMatrix::operator QMatrix):
- platform/graphics/transforms/TransformationMatrix.h:
- 9:39 PM Changeset in webkit [40769] by
-
- 26 edits in trunk/WebCore
2009-02-07 David Hyatt <hyatt@apple.com>
This patch changes the base class of RenderInline from RenderBox to RenderBoxModelObject. This shift
in base class knocks 32 bytes off the size of every RenderInline. All of the necessary functions
for both RenderInline and RenderBox have either been pulled up into RenderBoxModelObject for sharing
or split into two functions (one in each derived class).
Reviewed by Anders and Antti
- dom/Element.cpp: (WebCore::Element::offsetLeft): (WebCore::Element::offsetTop): (WebCore::Element::offsetWidth): (WebCore::Element::offsetHeight): (WebCore::Element::offsetParent): (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
- dom/Node.cpp: (WebCore::Node::renderBox): (WebCore::Node::renderBoxModelObject):
- dom/Node.h:
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- rendering/InlineBox.h: (WebCore::InlineBox::boxModelObject):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::marginLeft): (WebCore::InlineFlowBox::marginRight): (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
- rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::borderLeft): (WebCore::InlineFlowBox::borderRight): (WebCore::InlineFlowBox::paddingLeft): (WebCore::InlineFlowBox::paddingRight):
- rendering/RenderBlock.cpp: (WebCore::getBorderPaddingMargin): (WebCore::RenderBlock::calcInlinePrefWidths):
- rendering/RenderBox.cpp: (WebCore::RenderBox::imageChanged): (WebCore::RenderBox::calcReplacedWidthUsing): (WebCore::RenderBox::calcReplacedHeightUsing): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced): (WebCore::RenderBox::positionForCoordinates):
- rendering/RenderBox.h: (WebCore::RenderBox::borderBoundingBox): (WebCore::RenderBox::offsetHeight): (WebCore::RenderBox::marginTop): (WebCore::RenderBox::marginBottom): (WebCore::RenderBox::marginLeft): (WebCore::RenderBox::marginRight):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::offsetLeft): (WebCore::RenderBoxModelObject::offsetTop): (WebCore::RenderBoxModelObject::paddingTop): (WebCore::RenderBoxModelObject::paddingBottom): (WebCore::RenderBoxModelObject::paddingLeft): (WebCore::RenderBoxModelObject::paddingRight): (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::calculateBackgroundSize): (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
- rendering/RenderBoxModelObject.h: (WebCore::RenderBoxModelObject::borderTop): (WebCore::RenderBoxModelObject::borderBottom): (WebCore::RenderBoxModelObject::borderLeft): (WebCore::RenderBoxModelObject::borderRight): (WebCore::RenderBoxModelObject::hasHorizontalBordersPaddingOrMargin): (WebCore::RenderBoxModelObject::hasHorizontalBordersOrPadding): (WebCore::RenderBoxModelObject::childBecameNonInline): (WebCore::RenderBoxModelObject::isBoxModelObject):
- rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::destroy): (WebCore::RenderInline::styleDidChange): (WebCore::nextContinuation): (WebCore::RenderInline::continuationBefore): (WebCore::RenderInline::addChildIgnoringContinuation): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::addChildToContinuation): (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::offsetLeft): (WebCore::RenderInline::offsetTop): (WebCore::RenderInline::marginLeft): (WebCore::RenderInline::marginRight): (WebCore::RenderInline::positionForCoordinates): (WebCore::RenderInline::clippedOverflowRectForRepaint): (WebCore::RenderInline::rectWithOutlineForRepaint): (WebCore::RenderInline::computeRectForRepaint): (WebCore::RenderInline::updateDragState): (WebCore::RenderInline::childBecameNonInline): (WebCore::RenderInline::updateHitTestResult): (WebCore::RenderInline::imageChanged): (WebCore::RenderInline::addFocusRingRects):
- rendering/RenderInline.h: (WebCore::RenderInline::marginTop): (WebCore::RenderInline::marginBottom): (WebCore::RenderInline::continuation): (WebCore::RenderInline::setContinuation):
- rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint): (WebCore::RenderLineBoxList::hitTest):
- rendering/RenderLineBoxList.h:
- rendering/RenderObject.cpp: (WebCore::addLayers): (WebCore::RenderObject::removeLayers): (WebCore::RenderObject::moveLayers): (WebCore::RenderObject::findNextLayer): (WebCore::RenderObject::enclosingLayer): (WebCore::RenderObject::enclosingCompositingLayer): (WebCore::RenderObject::setLayerNeedsFullRepaint): (WebCore::RenderObject::handleDynamicFloatPositionChange): (WebCore::RenderObject::destroy): (WebCore::RenderObject::offsetParent):
- rendering/RenderObject.h: (WebCore::RenderObject::isInlineContinuation):
- rendering/RenderSVGTSpan.cpp: (WebCore::RenderSVGTSpan::absoluteRects): (WebCore::RenderSVGTSpan::absoluteQuads):
- rendering/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::absoluteRects): (WebCore::RenderSVGTextPath::absoluteQuads):
- rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
- rendering/RenderView.cpp: (WebCore::RenderView::setBestTruncatedAt):
- rendering/RenderView.h:
- rendering/bidi.cpp: (WebCore::getBorderPaddingMargin): (WebCore::inlineWidth): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::inlineFlowRequiresLineBox): (WebCore::requiresLineBox): (WebCore::RenderBlock::findNextLineBreak):
- wml/WMLAElement.cpp: (WebCore::WMLAElement::isKeyboardFocusable):
- 9:20 PM Changeset in webkit [40768] by
-
- 12 edits3 adds in trunk/WebCore
2009-02-07 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Timothy Hatcher <timothy@hatcher.name>
Partial fix for <https://bugs.webkit.org/show_bug.cgi?id=21051>
Include localStorage and sessionStorage in DatabasesPanel.
- WebCore.vcproj/WebCore.vcproj:
- inspector/InspectorController.cpp: (WebCore::InspectorDOMStorageResource::create): (WebCore::InspectorDOMStorageResource::setScriptObject): (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::addDOMStorageScriptResource): (WebCore::InspectorController::removeDOMStorageScriptResource): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didUseDOMStorage):
- inspector/InspectorController.h:
- inspector/front-end/DOMStorage.js: Added. (WebInspector.DOMStorage): (WebInspector.DOMStorage.prototype.get domStorage): (WebInspector.DOMStorage.prototype.set domStorage): (WebInspector.DOMStorage.prototype.get domain): (WebInspector.DOMStorage.prototype.set domain): (WebInspector.DOMStorage.prototype.get isLocalStorage): (WebInspector.DOMStorage.prototype.set isLocalStorage):
- inspector/front-end/DOMStorageItemsView.js: Added. (WebInspector.DOMStorageItemsView): (WebInspector.DOMStorageItemsView.prototype.show): (WebInspector.DOMStorageItemsView.prototype.update):
- inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView):
- inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView): (WebInspector.DatabaseTableView.prototype._queryFinished): (WebInspector.DatabaseTableView.prototype._queryError):
- inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel): (WebInspector.DatabasesPanel.prototype.reset): (WebInspector.DatabasesPanel.prototype.addDatabase): (WebInspector.DatabasesPanel.prototype.addDOMStorage): (WebInspector.DatabasesPanel.prototype.showDatabase): (WebInspector.DatabasesPanel.prototype.showDOMStorage): (WebInspector.DatabasesPanel.prototype.closeVisibleView): (WebInspector.DatabasesPanel.prototype.updateDatabaseTables): (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage): (WebInspector.DatabasesPanel.prototype._updateSidebarWidth): (WebInspector.DOMStorageSidebarTreeElement): (WebInspector.DOMStorageSidebarTreeElement.prototype.onselect): (WebInspector.DOMStorageSidebarTreeElement.prototype.get mainTitle): (WebInspector.DOMStorageSidebarTreeElement.prototype.set mainTitle): (WebInspector.DOMStorageSidebarTreeElement.prototype.get subtitle): (WebInspector.DOMStorageSidebarTreeElement.prototype.set subtitle):
- inspector/front-end/Images/domStorage.png: Added.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.addDOMStorage):
- page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::localStorage):
- 6:47 PM Changeset in webkit [40767] by
-
- 3 edits in trunk/WebCore
2009-02-07 Feng Qian <feng@chromium.org>
Reviewed by Eric Seidel <eric@webkit.org>
Put #if ENABLE(PAN_SCROLLING) around EventHandler::setPanScrollCursor.
https://bugs.webkit.org/show_bug.cgi?id=23574
- page/EventHandler.cpp:
- page/EventHandler.h:
- 6:10 PM Changeset in webkit [40766] by
-
- 2 edits in trunk/WebCore
2009-02-07 Zalan Bujtas <zbujtas@gmail.com>
Reviewed by Rob Buis <rwlbuis@gmail.com>
https://bugs.webkit.org/show_bug.cgi?id=23788
call style()->isOriginalDisplayInlineType() on RenderBox instead of RenderObject.
- rendering/bidi.cpp: (WebCore::RenderBlock::skipLeadingWhitespace):
- 2:06 PM Moving to Git edited by
- (diff)
- 1:18 PM Changeset in webkit [40765] by
-
- 2 edits in trunk/WebKit
2009-02-07 Darin Adler <Darin Adler>
- StringsNotToBeLocalized.txt: Updated for recent changes.
- 1:13 PM Changeset in webkit [40764] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fix date.
- 1:10 PM Changeset in webkit [40763] by
-
- 5 edits2 adds in trunk
Reviewed by Darin.
https://bugs.webkit.org/show_bug.cgi?id=3248
Bug 3248: Mouse events on OPTION element seem to be ignored
Support mouse events on options in a select when it forms a list box.
Test: fast/forms/option-mouseevents.html
- 12:46 PM Changeset in webkit [40762] by
-
- 2 edits in trunk/WebCore
2009-02-07 Adam Treat <adam.treat@torchmobile.com>
Prospective build fix for all non-Apple platforms.
- platform/graphics/transforms/TransformationMatrix.h:
- 10:40 AM Changeset in webkit [40761] by
-
- 81 edits in trunk
Reviewed by Simon Fraser.
I have not only made TransformationMatrix platform independent
but I've also added 3D methods, which will be used when I update
WebKitCSSMatrix to include 3D (see https://bugs.webkit.org/show_bug.cgi?id=23689).
I am now keeping a full 4x4 matrix in TransformationMatrix. I'm also doing all
the math as doubles rather than floats. This makes a TransformationMatrix
go from 24 bytes to 128 bytes, but I don't think this class is used enough to
make this overhead will be significant.
The change from floats to doubles has caused some differences in rounding and
display (sometimes things that displayed as -0.0 now display as 0.0 or vice versa),
so I've had to change some LayoutTest results in the SVG tests.
- 9:53 AM Changeset in webkit [40760] by
-
- 2 edits in trunk/WebKit/gtk
2009-02-07 Holger Hans Peter Freyther <zecke@selfish.org>
Unreviewed build fix Use toNormalizedRange().
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::clipboard_get_contents_cb):
- 7:33 AM Changeset in webkit [40759] by
-
- 4 edits in trunk/WebCore
2009-02-07 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
For the Qt port implement Image::drawPattern via
BitmapImage::drawPatterns' implementation and implement
Gradient::fill.
This partially fixes rendering of generated gradient content.
Feb 6, 2009:
- 8:19 PM Changeset in webkit [40758] by
-
- 2 edits in branches/Safari-6528/WebKit/mac
Merge r40727.
- 8:19 PM Changeset in webkit [40757] by
-
- 2 edits in branches/Safari-6528/WebKit/win
Merge r40726.
- 8:19 PM Changeset in webkit [40756] by
-
- 2 edits in branches/Safari-6528/WebKit/win
Merge r40713.
- 8:19 PM Changeset in webkit [40755] by
-
- 9 edits in branches/Safari-6528
Merge r40712.
- 8:19 PM Changeset in webkit [40754] by
-
- 7 edits in branches/Safari-6528/WebKit/mac
Merge r40711.
- 8:19 PM Changeset in webkit [40753] by
-
- 2 edits in branches/Safari-6528/WebKit/mac
Merge r40680.
- 8:19 PM Changeset in webkit [40752] by
-
- 6 edits in branches/Safari-6528/WebCore
Merge r40629.
- 8:19 PM Changeset in webkit [40751] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40623.
- 8:19 PM Changeset in webkit [40750] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40537.
- 8:18 PM Changeset in webkit [40749] by
-
- 3 edits in branches/Safari-6528/WebCore
Merge r40606.
- 8:18 PM Changeset in webkit [40748] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40502.
- 6:44 PM Changeset in webkit [40747] by
-
- 5 edits in trunk/WebKit/win
Build fix
Reviewed by Sam Weinig.
- WebCoreSupport/WebFrameLoaderClient.cpp: Added missing #include. (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Removed incorrect .get(), and changed to use the new overload of WebHistory::itemForURLString.
- WebHistory.cpp: (WebHistory::itemForURLString): Made this const. (WebHistory::itemForURLString): Added an overload that takes a WebCore::String and returns the IWebHistoryItem instead of using an out parameter.
- WebHistory.h: Added public overload of itemForURLString.
- WebView.cpp: (WebView::prepareCandidateWindow): (WebView::onIMERequestCharPosition): (WebView::onIMERequestReconvertString): Updated for toRange -> toNormalizedRange rename.
- 5:28 PM Changeset in webkit [40746] by
-
- 27 edits5 adds in trunk
Reviewed by Justin Garcia.
DOMSelection.getRangeAt() returns a different range than the selection
https://bugs.webkit.org/show_bug.cgi?id=23601
Rename toRange to toNormalizedRange and add new firstRange which returns an unmodified range
Test: fast/dom/Selection/getRangeAt.html
- WebCore.base.exp:
- dom/InputElement.cpp: (WebCore::InputElement::handleBeforeTextInsertedEvent):
- editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement):
- editing/Editor.cpp: (WebCore::Editor::selectedRange): (WebCore::Editor::fontForSelection): (WebCore::Editor::applyStyleToSelection): (WebCore::Editor::applyParagraphStyleToSelection): (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::insertLineBreak): (WebCore::Editor::insertParagraphSeparator): (WebCore::Editor::ignoreSpelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::markMisspellingsOrBadGrammar): (WebCore::Editor::rangeForPoint):
- editing/EditorCommand.cpp: (WebCore::expandSelectionToGranularity): (WebCore::executeDeleteToMark): (WebCore::executeSelectToMark):
- editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):
- editing/Selection.cpp: (WebCore::Selection::firstRange): (WebCore::Selection::toNormalizedRange):
- editing/Selection.h:
- editing/SelectionController.h: (WebCore::SelectionController::toNormalizedRange):
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
- editing/markup.cpp: (WebCore::createMarkup):
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::createFromSelection):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
- page/DOMSelection.cpp: (WebCore::DOMSelection::getRangeAt): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::deleteFromDocument): (WebCore::DOMSelection::containsNode): (WebCore::DOMSelection::toString):
- page/DragController.cpp: (WebCore::setSelectionToDragCaret): (WebCore::DragController::concludeEditDrag): (WebCore::DragController::startDrag):
- page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent):
- page/Frame.cpp: (WebCore::Frame::selectedText): (WebCore::Frame::shouldChangeSelection): (WebCore::Frame::shouldDeleteSelection): (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::selectionTextRects): (WebCore::Frame::findString): (WebCore::Frame::respondToChangedSelection):
- platform/ContextMenu.cpp: (WebCore::selectionContainsPossibleWord):
- 5:26 PM Changeset in webkit [40745] by
-
- 2 edits in trunk/WebCore
2009-02-06 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein
<rdar://problem/6563402> - Workaround a case where ::didReceiveData() might be called on a ResourceHandleClient
before ::didReceiveResponse().
No layout test, as we don't have a concrete way to reproduce these conditions. To that effect, I've added an ASSERT
to catch the conditions before the workaround takes effect in case any WebKit Debug-build developer runs across
this case and can come up with something more reproducible.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveData): If the response is null create a dummy response. This is much like the FrameLoader::init() response that is used for initial document creation.
- 5:16 PM Changeset in webkit [40744] by
-
- 2 edits in trunk/WebCore
2009-02-06 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebCore.base.exp:
- 5:10 PM Changeset in webkit [40743] by
-
- 9 edits in trunk/WebKit
WebKit/gtk:
2009-02-06 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::updateGlobalHistoryRedirectLinks):
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/qt:
2009-02-06 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/wx:
2009-02-06 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::updateGlobalHistoryRedirectLinks):
- WebKitSupport/FrameLoaderClientWx.h:
- 5:05 PM Changeset in webkit [40742] by
-
- 2 edits in trunk/WebCore
2009-02-06 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
Do not use m_scrollOffset to check if we are setting the same
value than we already have.
m_scrollOffset starts at 0 for ScrollView, so when opening a new
page and scrolling to 0 (the usual case) the check will fail and
we won't update the adjustment value, resulting in a possibly
mispositioned scrollbar. Use the adjustment value directly
instead, which is what we are updating anyway.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformHandleHorizontalAdjustment): (WebCore::ScrollView::platformHandleVerticalAdjustment):
- 4:42 PM Changeset in webkit [40741] by
-
- 4 edits4 adds4 deletes in trunk
WebCore:
2009-02-06 Justin Garcia <justin.garcia@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=23800
Header elements are not always preserved during paste
At paste time, don't merge out of header elements. At copy time, be sure to include
headers in the list of special common ancestor blocks, so that copying a paragraph or less
of content inside a header will include the header element in the copied markup.
- editing/ReplaceSelectionCommand.cpp: (WebCore::areSameHeaderElements): (WebCore::ReplaceSelectionCommand::shouldMerge):
- editing/markup.cpp: (WebCore::isSpecialAncestorBlock): (WebCore::createMarkup):
LayoutTests:
2009-02-06 Justin Garcia <justin.garcia@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=23800
Header elements are not always preserved during paste
- editing/execCommand/4128080-1-expected.txt: Added.
- editing/execCommand/4128080-1.html: Added.
- editing/execCommand/4128080-2-expected.txt: Added.
- editing/execCommand/4128080-2.html: Added.
- 4:28 PM Changeset in webkit [40740] by
-
- 17 edits in trunk
WebCore:
2009-02-06 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Part III of <rdar://problem/6552272>.
Make redirect data available to WebKit. (I tried having WebKit track this
data for itself, but that went wrong -- it's just too hard to figure
out the weird corners of the WebCore loader from within another framework.)
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader):
- loader/DocumentLoader.h: Store a flag indicating whether we created a global history entry. If we didn't, then we know that the next redirect should not link to us, since we're not in history.
(WebCore::DocumentLoader::clientRedirectSourceForHistory):
(WebCore::DocumentLoader::clientRedirectDestinationForHistory):
(WebCore::DocumentLoader::setClientRedirectSourceForHistory):
(WebCore::DocumentLoader::serverRedirectSourceForHistory):
(WebCore::DocumentLoader::serverRedirectDestinationForHistory):
(WebCore::DocumentLoader::didCreateGlobalHistoryEntry):
(WebCore::DocumentLoader::setDidCreateGlobalHistoryEntry): Added accessors
to help WebKit wade through the muck of WebCore history.
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryRedirectLinks): Renamed this client function to say what it does, instead of when it's called.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::loadWithNavigationAction): In the case of a redirect, store a link to the previous history URL in the new DocumentLoader, so it can update WebKit with that link when the load commits.
(WebCore::FrameLoader::updateHistory*): Use our new flags and names,
described above.
- loader/FrameLoader.h: (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::policyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::state): Inlined a few trivial functions because performance mistakes give me the itches.
- loader/FrameLoaderClient.h: Renamed this client function to say what it does, instead of when it's called.
WebKit/mac:
2009-02-06 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Part III of <rdar://problem/6552272>.
Refactored to use the redirect data WebCore makes available, instead of
tracking loading state in WebKit.
- History/WebHistory.mm: (-[WebHistoryPrivate dealloc]): (-[WebHistory _visitedURL:withTitle:method:wasFailure:]): (-[WebHistory _visitedURLForRedirectWithoutHistoryItem:]):
- History/WebHistoryInternal.h:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
WebKit/win:
2009-02-06 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Part III of <rdar://problem/6552272>.
Refactored to use the redirect data WebCore makes available, instead of
tracking loading state in WebKit.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebHistory.cpp: (WebHistory::visitedURL):
- WebHistory.h:
- 4:10 PM Changeset in webkit [40739] by
-
- 2 edits in trunk/WebKit/gtk
2009-02-06 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
Reported by Daniel Macks.
Use positive numbers for the target info IDs, gtk_target_list_add
casts them to 'guint'. Also just start them from 0, since the
values are not relevant or magic in any way, they are just used as
tokens for the user of the API.
- webkit/webkitwebview.h:
- 4:04 PM Changeset in webkit [40738] by
-
- 7 edits in trunk/WebCore
Reviewed by Justin Garcia.
Minor refactoring and cleanup to Selection code
https://bugs.webkit.org/show_bug.cgi?id=23774
No functional changes, thus no tests.
- editing/Editor.cpp: (WebCore::Editor::applyStyle): (WebCore::Editor::applyParagraphStyle):
- editing/Selection.cpp: (WebCore::Selection::Selection): (WebCore::Selection::setBaseAndExtentToDeepEquivalents): (WebCore::Selection::setStartAndEndFromBaseAndExtentRespectingGranularity): (WebCore::Selection::updateSelectionType): (WebCore::Selection::validate): (WebCore::Selection::setWithoutValidation): (WebCore::Selection::adjustSelectionToAvoidCrossingEditingBoundaries):
- editing/Selection.h: (WebCore::Selection::): (WebCore::Selection::selectionType): (WebCore::Selection::extent): (WebCore::Selection::isNone): (WebCore::Selection::isCaret): (WebCore::Selection::isRange): (WebCore::Selection::isCaretOrRange):
- editing/SelectionController.h: (WebCore::SelectionController::selectionType):
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
- page/Frame.cpp: (WebCore::Frame::revealSelection):
- 3:39 PM Changeset in webkit [40737] by
-
- 1 edit3 adds in trunk/WebCore
2009-02-06 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23801
Add custom V8 bindings for SVG.
- bindings/v8/custom/V8SVGElementInstanceCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8SVGLengthCustom.cpp: Added. (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8SVGMatrixCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
- 3:29 PM Changeset in webkit [40736] by
-
- 2 edits in trunk/WebCore
2009-02-06 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
Bug 23792: unused param is used in RenderLayer.cp but not #include'd
<https://bugs.webkit.org/show_bug.cgi?id=23792>
Add include file for UnusedParam which is used in this file.
- rendering/RenderLayer.cpp:
- 3:25 PM Changeset in webkit [40735] by
-
- 4 edits in trunk/WebCore
2009-02-06 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
Bug 23798: KURLGoogle needs support for protocolInHTTPFamily
<https://bugs.webkit.org/show_bug.cgi?id=23798>
Add protocolInHTTPFamily() to the KURLGoogle implementation.
This is another chromium build fix to mirror r40553.
While in this file, I did some style fixes and consistency fixes:
+ fixed many_occurences_of_underscoring_naming
+ usages of NULL
+ comparisons to 0
+ changed the copyright remove an extraneous , and capitalize the (C)
which was suggested for other files that I've submitted.
No observable change in behavior, so no test.
- platform/KURL.h: (WebCore::KURL::protocolInHTTPFamily):
- platform/KURLGoogle.cpp: (WebCore::KURLCharsetConverter::ConvertFromUTF16): (WebCore::lowerCaseEqualsASCII): (WebCore::KURLGooglePrivate::KURLGooglePrivate): (WebCore::KURLGooglePrivate::setUtf8): (WebCore::KURLGooglePrivate::setAscii): (WebCore::KURLGooglePrivate::init): (WebCore::KURLGooglePrivate::initProtocolInHTTPFamily): (WebCore::KURLGooglePrivate::copyTo): (WebCore::KURLGooglePrivate::replaceComponents): (WebCore::KURL::KURL): (WebCore::KURL::createCFURL): (WebCore::KURL::isEmpty): (WebCore::KURL::protocolInHTTPFamily): (WebCore::KURL::query): (WebCore::decodeURLEscapeSequences): (WebCore::KURL::protocolIs): (WebCore::encodeWithURLEscapeSequences): (WebCore::KURL::invalidate): (WebCore::equalIgnoringRef):
- platform/KURLGooglePrivate.h:
- 2:48 PM Changeset in webkit [40734] by
-
- 5 edits in trunk/WebCore
Bug 23741: StyleRareNonInheritedData::operator==() should not compare ContentData objects by pointer
Reviewed by Darin Adler.
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::contentDataEquivalent): Moved method to WebCore::StyleRareNonInheritedData class.
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::contentDataEquivalent): Replaced declaration with inline method that calls contentDataEquivalent() on WebCore::StyleRareNonInheritedData instead.
- rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::operator==): This is the bug fix! Replaced pointer comparison of ContentData objects with call to StyleRareNonInheritedData::contentDataEquivalent(). (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Added.
- rendering/style/StyleRareNonInheritedData.h: (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Added declaration.
- 2:42 PM Changeset in webkit [40733] by
-
- 6 edits in trunk/WebKit/mac
2009-02-06 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/6562220>
CrashTracer: [USER] 21 crashes in Safari at com.apple.WebKit • WebKit::NetscapePluginHostProxy::port
Make the handling of crashes in the plug-in host more robust.
- Plugins/Hosted/NetscapePluginHostProxy.h: Add m_portSet.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Initialize m_portSet.
(WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy):
Free m_portSet.
(WebKit::NetscapePluginHostProxy::processRequests):
Listen for messages on the port set. If we get a message to the port death notification port,
then call pluginHostDied. Otherwise, process the message.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::cleanup): Factor code that should be shared between destroy() and pluginHostDied() into cleanup.
(WebKit::NetscapePluginInstanceProxy::destroy):
Call cleanup().
(WebKit::NetscapePluginInstanceProxy::pluginHostDied):
Call cleanup().
(WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
Call NetscapePluginHostProxy::processRequests.
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invalidate): Add a null check for the host proxy.
- 2:17 PM Changeset in webkit [40732] by
-
- 3 edits in trunk/WebCore
2009-02-06 Simon Fraser <Simon Fraser>
Reviewed by Eric Seidel
Factor code that checks whether the object is rooted in
repaint() and repaintRectangle() into a common isRooted()
method.
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::isRooted):
- rendering/RenderObject.h:
- 2:16 PM Changeset in webkit [40731] by
-
- 4 edits in trunk/WebCore
2009-02-06 Simon Fraser <Simon Fraser>
Reviewed by Eric Seidel
Expose an isRootLayer() method on RenderLayer that works whether the
layer is rooted or not, and use that in a few places in the
accelerated compositing code.
- rendering/RenderLayer.h: (WebCore::RenderLayer::isRootLayer):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintingGoesToWindow):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::requiresCompositingLayer):
- 2:13 PM Changeset in webkit [40730] by
-
- 3 edits in trunk/WebCore
2009-02-06 Simon Fraser <Simon Fraser>
Reviewed by Eric Seidel
Make RenderStyle::transitionForProperty() const.
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::transitionForProperty):
- rendering/style/RenderStyle.h:
- 1:44 PM Changeset in webkit [40729] by
-
- 7 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix <rdar://problem/6552338> FontCache::releaseFontData() called on a small caps font that is not in the cache
Most platforms do not retrieve the small caps font from the FontCache,
but cross-platform code in ~SimpleFontData() assumes the the small caps
font data did come from the cache and therefore calls releaseFontData()
on it.
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::~SimpleFontData): Reordered to call platformDestroy() before releasing the small caps font and pruning the glyph page tree. This allows platformDestroy() to reset m_smallCapsFontData to 0 if it was not obtained from the cache.
- platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformDestroy): Set m_smallCapsFontData to 0 after deleting it.
- platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformDestroy): Ditto.
- platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformDestroy): Ditto.
- platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::platformCommonDestroy): Ditto.
- platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::platformDestroy): Ditto.
- 1:30 PM Changeset in webkit [40728] by
-
- 2 edits in trunk/WebCore
2009-02-06 Simon Fraser <Simon Fraser>
Fix build when ACCELERATED_COMPOSITING is turned on.
Remove font smoothing changes that will be committed
separately.
- platform/graphics/mac/WebLayer.mm: (WebCore::if):
- 1:09 PM Changeset in webkit [40727] by
-
- 2 edits in trunk/WebKit/mac
- try to fix the Tiger build
- Misc/WebNSArrayExtras.h:
- 12:49 PM Changeset in webkit [40726] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Anders Carlsson.
- fix an assertion failure in Vector::at() beneath WebHistoryItem::dictionaryRepresentation.
- WebHistoryItem.cpp: (WebHistoryItem::dictionaryRepresentation): Give the numbers vector initial size. Also reduced the inline capacity of the vector used for weekly visit counts to 5, which is the expected maximum size.
- 12:33 PM Changeset in webkit [40725] by
-
- 2 edits in trunk/WebCore
2009-02-06 Anders Carlsson <andersca@apple.com>
Build fix.
- bridge/npapi.h:
- 12:16 PM Changeset in webkit [40724] by
-
- 2 edits in trunk/WebCore
2009-02-06 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23790
Custom -> JSCCustom in SVGPointList.idl
- svg/SVGPointList.idl:
- 11:22 AM Changeset in webkit [40723] by
-
- 2 edits in trunk/WebKit/mac
2009-02-06 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6563650>
Add Netscape plug-in API to tell the browser not to load streams (some plug-ins handle network loading manually)
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView loadStream]): (-[WebNetscapePluginView pluginView:receivedData:]): (-[WebNetscapePluginView _shouldCancelSrcStream]):
- 10:08 AM Changeset in webkit [40722] by
-
- 5 edits in trunk/WebCore
2009-02-06 Anantanarayanan Iyengar <ananta@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23309
Fix whitespace indent errors. The rest of the original patch has already
landed.
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::clear):
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::clear):
- platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::clear):
- platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::clear):
- 9:37 AM Changeset in webkit [40721] by
-
- 2 edits in trunk/WebCore
2009-02-06 Dirk Schulze <krit@webkit.org>
Reviewed by Simon Hausmann.
Fix bug in clearRect(). Use fillRect() instead of eraseRect() to get
the context transparent.
[QT] clearRect fill's a given rect with white
https://bugs.webkit.org/show_bug.cgi?id=23728
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clearRect):
- 9:32 AM Changeset in webkit [40720] by
-
- 2 edits in trunk/WebKit/win
Build fix. Re-enable missing file in Release_Cairo target.
- 9:05 AM Changeset in webkit [40719] by
-
- 2 edits in trunk/WebCore
2009-02-06 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
When the document is attached and detached, and when it becomes active/inactive
(e.g. coming out or going into the page cache) we need to call
RenderView::didMoveOnscreen()/willMoveOffscreen() to hook and unhook the composited
layers.
Also, if Document::recalcStyle() does not do a layout, it needs to
update the compositing layers.
- dom/Document.cpp: (WebCore::Document::updateRendering): (WebCore::Document::updateLayout): (WebCore::Document::attach): (WebCore::Document::detach): (WebCore::Document::documentWillBecomeInactive): (WebCore::Document::documentDidBecomeActive):
- 5:50 AM Changeset in webkit [40718] by
-
- 2 edits in trunk/WebKit/qt
2009-02-06 Kavindra Palaraja <kavindra.palaraja@nokia.com>
Reviewed by Simon Hausmann.
Doc - made 2 functions internal as they are not part of the API anymore (and this fixes 2 qdoc warnings)
- 4:35 AM Changeset in webkit [40717] by
-
- 10 edits in trunk
WebCore:
2009-02-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Added support for different ownership models for wrapped QObjects in
the JavaScript environment.
WebKit/qt:
2009-02-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Added an overload of QWebFrame::addToJavaScriptWindowObject that takes a QScriptEngine::ValueOwnership parameter.
- 2:10 AM Changeset in webkit [40716] by
-
- 2 edits in trunk/WebKit/gtk
2009-02-06 Xan Lopez <xan@gnome.org>
Reviewed by Alexey Proskuryakov.
Do not use empty ResourceError errors.
Rather create bogus but non-null errors, since some codepaths
expect these. For example, see DocumentLoader::mainReceivedError.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::cancelledError): (WebKit::FrameLoaderClient::blockedError): (WebKit::FrameLoaderClient::cannotShowURLError): (WebKit::FrameLoaderClient::interruptForPolicyChangeError): (WebKit::FrameLoaderClient::cannotShowMIMETypeError): (WebKit::FrameLoaderClient::fileDoesNotExistError): (WebKit::FrameLoaderClient::pluginWillHandleLoadError):
- 1:21 AM Changeset in webkit [40715] by
-
- 3 edits in trunk/WebKit/gtk
2009-02-06 Xan Lopez <xan@gnome.org>
Reviewed by Alexey Proskuryakov.
Use two-arg KURL ctor.
We are using the one-arg ctor currently, but:
- It assumes the strings are already encoded, which is not necesarily the case for us.
- The single-argument KURL ctors expect their input to already be the output of a previous KURL::parse call, so for the general case (ie, random user input) we need to use the two-arg ctor anyway.
- webkit/webkitwebframe.cpp:
- webkit/webkitwebview.cpp:
- 12:56 AM Changeset in webkit [40714] by
-
- 2 edits in trunk/WebKit/qt
2009-02-06 Aaron Boodman <aa@chromium.org>
Reviewed by Holger Freyther.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::documentElementAvailable):) Fix compile error in Qt build introduced by the below change (r40694).
- 12:16 AM Changeset in webkit [40713] by
-
- 2 edits in trunk/WebKit/win
2009-02-06 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Dan Bernstein.
fix obvious problem in previous commit ( used instead of &&) - WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation):
- 12:11 AM Changeset in webkit [40712] by
-
- 9 edits in trunk
WebCore:
2009-02-05 Maciej Stachowiak <mjs@apple.com> and Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein and Geoff Garen.
- WebCore code to track per-day and per-week visit counts in history
The basic idea is as follows: we track daily visits for up to 13
days, and weekly visits for up to 5 weeks past the end of the
current daily visits. As soon as the number of daily counts goes
over 13, we squish them down into weeks, and then prune the excess weeks.
- history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): Remove bogus whitespace. (WebCore::timeToDay): Helper function: convert time to days from the epoch. (WebCore::HistoryItem::padDailyCountsForNewVisit): Insert 0 counts if a site is visited after a span of days. (WebCore::HistoryItem::collapseDailyVisitsToWeekly): Core day/week upgrade algorithm as described above. (WebCore::HistoryItem::recordVisitAtTime): Use above helpers to record all info about a visit to this history item. (WebCore::HistoryItem::setLastVisitedTime): Updated. (WebCore::HistoryItem::visited): Updated. (WebCore::HistoryItem::recordInitialVisit): New function to handle recording data about the very first visit, replacing the prior practice of explicitly setting visit count to 1. (WebCore::HistoryItem::adoptVisitCounts): Take ownership of daily and weekly visit count vectors. (WebCore::HistoryItem::mergeAutoCompleteHints): Added a comment noting that this function doesn't work properly now (though this shouldn't matter much in practice.)
- history/HistoryItem.h: (WebCore::HistoryItem::dailyVisitCounts): Accessor for daily counts. (WebCore::HistoryItem::weeklyVisitCounts): Ditto for weekly counts.
- WebCore.base.exp: Add new symbols and sort.
WebKit/win:
2009-02-05 Maciej Stachowiak <mjs@apple.com> and Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein and Geoff Garen..
- WebKit code to track per-day and per-week visit counts in history
For now this data is only exposed via SPI for performance reasons.
- Interfaces/IWebHistoryItemPrivate.idl: Added new interface.
- WebHistory.cpp: (WebHistory::visitedURL): Use new recordInitialVisit method.
- WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation): Add parsing support for new data. (WebHistoryItem::dictionaryRepresentation): Add saving support for new data. (WebHistoryItem::getDailyVisitCounts): SPI accessor. (WebHistoryItem::getWeeklyVisitCounts): SPI accessor. (WebHistoryItem::recordInitialVisit): Tell WebCore to record an initial visit.
- WebHistoryItem.h:
- 12:04 AM Changeset in webkit [40711] by
-
- 7 edits in trunk/WebKit/mac
2009-02-05 Maciej Stachowiak <mjs@apple.com> and Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein and Geoff Garen.
- WebKit code to track per-day and per-week visit counts in history
For now this data is only exposed via SPI for performance reasons.
- History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): Add parsing support for new data. (-[WebHistoryItem _recordInitialVisit]): Tell WebCore to record an initial visit. (-[WebHistoryItem dictionaryRepresentation]): Add saving support for new data. (-[WebHistoryItem _getDailyVisitCounts:]): SPI accessor. (-[WebHistoryItem _getWeeklyVisitCounts:]): SPI accessor.
- History/WebHistoryItemInternal.h: Declare new methods.
- History/WebHistoryItemPrivate.h: Ditto.
- History/WebHistory.mm: (-[WebHistoryPrivate visitedURL:withTitle:]): For the initial visit, use the new _recordInitialVisit method instead of setting visit count to 1.
- Misc/WebNSArrayExtras.h:
- Misc/WebNSArrayExtras.m: (-[NSArray _webkit_numberAtIndex:]): Helper to retrieve an NSNumber or nil from an NSArray (-[NSArray _webkit_stringAtIndex:]): Helper to retrieve an NSString of nil from an NSArray
Feb 5, 2009:
- 11:53 PM Changeset in webkit [40710] by
-
- 10 edits2 adds in trunk
Reviewed by Darin Adler.
<rdar://problem/6438271> Improve backspace handling of accented characters
Test: platform/mac/editing/deleting/backward-delete.html
This change makes WebKit behave like AppKit on the Mac. Other platforms are not affected,
because the current behavior matches their standards (tested on Windows, assumed elsewhere).
- dom/Position.cpp: (WebCore::Position::previous): (WebCore::Position::next): (WebCore::Position::uncheckedPreviousOffsetForBackwardDeletion):
- dom/Position.h: Added a new option for previous(), used to move to a next position for backward deletion. Renamed EUsingComposedCharacters to PositionMoveType.
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Use previous(BackwardDeletion) to find a proper range to delete. Also, simplified a check surrounding this code a little.
- editing/htmlediting.cpp: (WebCore::nextVisuallyDistinctCandidate): (WebCore::previousVisuallyDistinctCandidate): Adjusted for renamed enum values.
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderText.h: Added previousOffsetForBackwardDeletion().
- rendering/RenderText.cpp: (WebCore::RenderText::previousOffsetForBackwardDeletion): On PLATFORM(MAC), use an algorithm that matches the one AppKit has for backward deletion.
- 10:06 PM Changeset in webkit [40709] by
-
- 2 edits in trunk/WebCore
Fix a crash in RenderWidget::destroy when navigating away from a page with an <iframe>
This was a regression caused by r40679
Reviewed by Dave Hyatt.
Tested by many many tests.
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): Only deref the RenderWidget after we finish accessing its members.
- 9:40 PM Changeset in webkit [40708] by
-
- 2 edits in trunk/WebKitTools
2009-02-05 Simon Fraser <Simon Fraser>
Fix the #include file order, per review comments.
- DumpRenderTree/mac/PixelDumpSupportMac.mm:
- 9:37 PM Changeset in webkit [40707] by
-
- 2 edits in trunk/WebKitTools
2009-02-05 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
If the WebHTMLView uses accelerated compositing, we need for force
the on-screen capture path and also force animations to start with -display
since the DRT window has autodisplay disabled.
- DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):
- 9:09 PM Changeset in webkit [40706] by
-
- 2 edits in trunk/WebCore
2009-02-05 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
getAnimatedStyleForRenderer() should not create a new
CompositeAnimation if the object isn't already animating, and
it should just fall back to returning renderer->style().
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
- 9:03 PM Changeset in webkit [40705] by
-
- 2 edits in trunk/JavaScriptCore
Build fix
Rubberstamped by Sam Weinig.
- wtf/TypeTraits.h: Include Platform.h, since this header uses macros defined there.
- 8:30 PM Changeset in webkit [40704] by
-
- 3 edits in trunk/WebCore
2009-02-05 Simon Fraser <Simon Fraser>
Fix build when ACCELERATED_COMPOSITING is turned on.
Give RenderLayerBacking some love after the great
RenderBoxModelObject split.
- 8:22 PM Changeset in webkit [40703] by
-
- 3 edits in trunk/WebCore
2009-02-05 Simon Fraser <Simon Fraser>
Fix build when ACCELERATED_COMPOSITING is turned on.
writeIndent() needs to be static to avoid warnings on some OSes,
and remove unused CAToTransform3D() method.
- platform/graphics/GraphicsLayer.cpp: (WebCore::writeIndent):
- platform/graphics/mac/GraphicsLayerCA.mm:
- 8:18 PM Changeset in webkit [40702] by
-
- 4 edits in trunk/WebCore
2009-02-05 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
Add some methods to the TransformOperation classes that are required
by GraphicsLayer when ACCELERATED_COMPOSITING is turned on.
- 8:12 PM Changeset in webkit [40701] by
-
- 3 edits in trunk/WebCore
2009-02-05 Simon Fraser <Simon Fraser>
Minor clenaup: fix brace style in CompositeAnimationPrivate::updateTransitions(),
and correct a usage of UNUSED_PARAM().
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimationPrivate::updateTransitions):
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::startAnimation):
- 8:09 PM Changeset in webkit [40700] by
-
- 2 edits in trunk/WebCore
2009-02-05 Simon Fraser <Simon Fraser>
Fix build when ACCELERATED_COMPOSITING is turned on.
animationOfPropertyIsAccelerated() needs to be public because
it is called from AnimationController.
- page/animation/AnimationBase.h:
- 8:07 PM Changeset in webkit [40699] by
-
- 2 edits in trunk/WebCore
2009-02-05 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
Fix mis-typed enum value which is hidden inside #ifdefs so didn't break
the build.
- page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers):
- 4:26 PM Changeset in webkit [40698] by
-
- 2 edits in trunk/WebKit/win
2009-02-05 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Sam Weinig.
Build fix.
- 4:17 PM Changeset in webkit [40697] by
-
- 4 edits in trunk/LayoutTests
- 4:15 PM Changeset in webkit [40696] by
-
- 3 edits in trunk/WebCore
2009-02-05 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Fix missing checked toRenderBlock casts.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloats):
- rendering/RenderBox.cpp: (WebCore::RenderBox::availableHeightUsing):
- 4:11 PM Changeset in webkit [40695] by
-
- 2 edits in trunk/WebCore
2009-02-05 Sam Weinig <sam@webkit.org>
Patch from Darin Adler.
Reviewed by Sam Weinig.
Fix case where we were casting to RenderView.
No test case possible.
- editing/mac/SelectionControllerMac.mm: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- 3:59 PM Changeset in webkit [40694] by
-
- 23 edits in trunk
WebCore:
2009-02-05 Aaron Boodman <aa@chromium.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23708
Adds documentElementAvailable() callback to FrameLoaderClient.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::startElementNs): Add call to dispatchDocumentElementAvailable()
- dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseStartElement): Ditto.
- html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): Ditto.
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::documentElementAvailable): Stub out documentElementAvailable().
- loader/FrameLoader.cpp: documentElementAvailable() callback plumbing.
- loader/FrameLoader.h: Ditto.
- loader/FrameLoaderClient.h: Add new documentElementAvailable() callback.
WebKit/gtk:
2009-02-05 Aaron Boodman <aa@chromium.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23708
Adds documentElementAvailable() callback to FrameLoaderClient.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::documentElementAvailable): Stub out documentElementAvailable()
- WebCoreSupport/FrameLoaderClientGtk.h: Ditto.
WebKit/mac:
2009-02-05 Aaron Boodman <aa@chromium.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23708
Adds documentElementAvailable() callback to FrameLoaderClient.
- WebCoreSupport/WebFrameLoaderClient.h: Stub out documentElementAvailable().
- WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
WebKit/qt:
2009-02-05 Aaron Boodman <aa@chromium.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23708
Adds documentElementAvailable() callback to FrameLoaderClient.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClient::documentElementAvailable): Stub out documentElementAvailable().
- WebCoreSupport/FrameLoaderClientQt.h: Ditto.
WebKit/win:
2009-02-05 Aaron Boodman <aa@chromium.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23708
Adds documentElementAvailable() callback to FrameLoaderClient.
- WebFrame.cpp: (WebFrame::documentElementAvailable): Stub out documentElementAvailable()
- WebFrame.h: Ditto.
WebKit/wx:
2009-02-05 Aaron Boodman <aa@chromium.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23708
Adds documentElementAvailable() callback to FrameLoaderClient.
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::documentElementAvailable): Stub out documentElementAvailable().
- WebKitSupport/FrameLoaderClientWx.h: Ditto.
- 3:40 PM Changeset in webkit [40693] by
-
- 2 edits in trunk/WebCore
2009-02-05 Scott Violet <sky@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23766
CanvasRenderingContext2D::setShadow needs else for other platforms.
Implements the CMYK variant of CanvasRenderingContext2D::setShadow for
other platforms using the CMYK color constructor.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow):
- 3:36 PM Changeset in webkit [40692] by
-
- 2 edits4 adds in trunk/WebCore
2009-02-05 Scott Violet <sky@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23687
Wires up Skia'a ImageBuffer::toDataURL to support pngs.
This helps Chromium pass a couple of layout tests.
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::toDataURL):
- platform/image-encoders: Added.
- platform/image-encoders/skia: Added.
- platform/image-encoders/skia/PNGImageEncoder.cpp: Added. (WebCore::): (WebCore::PngEncoderState::EncoderWriteCallback): (WebCore::PngEncoderState::ConvertBGRAtoRGB): (WebCore::PngEncoderState::PngWriteStructDestroyer::PngWriteStructDestroyer): (WebCore::PngEncoderState::PngWriteStructDestroyer::~PngWriteStructDestroyer): (WebCore::PNGImageEncoder::encode):
- platform/image-encoders/skia/PNGImageEncoder.h: Added.
- 3:34 PM Changeset in webkit [40691] by
-
- 2 edits in trunk/WebCore
2009-02-05 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Fix missing checked cast.
- rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock):
- 3:31 PM Changeset in webkit [40690] by
-
- 2 edits in trunk/WebCore
Not reviewed. Fix WML enabled builds.
FrameLoader::load() got an additional 'lockHistory' parameter, pass 'false'.
- 3:28 PM Changeset in webkit [40689] by
-
- 2 edits in trunk/WebCore
2009-02-05 Scott Violet <sky@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23625
Additional fix: Skia platform doesn't render text to a canvas or support clipping to an image buffer
Fixes three bugs in PlatformContextSkia:
- When a new layer was started clipped to an image we used the assignment operator to copy the SkBitmap. If the SkBitmap owns it's pixels, this is not the right thing to do. Instead we need to create a copy of the image.
- State holds an SkBitmap by value. State's copy constructor does a memcpy. This is confusing and subtle, I've converted to use a member initializer list which I think is clearer and less error prone.
- When creating a new layer there is no need to copy the clip image.
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): (PlatformContextSkia::save): (PlatformContextSkia::beginLayerClippedToImage):
- 3:24 PM Changeset in webkit [40688] by
-
- 2 edits in trunk/WebCore
2009-02-05 Scott Violet <sky@google.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=23462
Changes call from setFillColor to setStrokeColor.
- html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor):
- 3:12 PM Changeset in webkit [40687] by
-
- 1 edit15 adds in trunk/WebCore
2009-02-05 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23767
Add custom V8 bindings for HTML5 database.
- bindings/v8/custom/V8CustomSQLStatementCallback.cpp: Added. (WebCore::V8CustomSQLStatementCallback::V8CustomSQLStatementCallback): (WebCore::V8CustomSQLStatementCallback::~V8CustomSQLStatementCallback): (WebCore::V8CustomSQLStatementCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLStatementCallback.h: Added. (WebCore::V8CustomSQLStatementCallback::create):
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: Added. (WebCore::V8CustomSQLStatementErrorCallback::V8CustomSQLStatementErrorCallback): (WebCore::V8CustomSQLStatementErrorCallback::~V8CustomSQLStatementErrorCallback): (WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.h: Added. (WebCore::V8CustomSQLStatementErrorCallback::create):
- bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: Added. (WebCore::V8CustomSQLTransactionCallback::V8CustomSQLTransactionCallback): (WebCore::V8CustomSQLTransactionCallback::~V8CustomSQLTransactionCallback): (WebCore::V8CustomSQLTransactionCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLTransactionCallback.h: Added. (WebCore::V8CustomSQLTransactionCallback::create):
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: Added. (WebCore::V8CustomSQLTransactionErrorCallback::V8CustomSQLTransactionErrorCallback): (WebCore::V8CustomSQLTransactionErrorCallback::~V8CustomSQLTransactionErrorCallback): (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Added. (WebCore::V8CustomSQLTransactionErrorCallback::create):
- bindings/v8/custom/V8CustomVoidCallback.cpp: Added. (WebCore::V8CustomVoidCallback::V8CustomVoidCallback): (WebCore::V8CustomVoidCallback::~V8CustomVoidCallback): (WebCore::V8CustomVoidCallback::handleEvent): (WebCore::invokeCallback):
- bindings/v8/custom/V8CustomVoidCallback.h: Added. (WebCore::V8CustomVoidCallback::create):
- bindings/v8/custom/V8DatabaseCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8SQLTransactionCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
- 3:10 PM Changeset in webkit [40686] by
-
- 3 edits in trunk/WebCore
2009-02-05 David Hyatt <hyatt@apple.com>
Fix crash on svg custom stop test. A virtual function didn't get patched properly.
Reviewed by Sam Weinig
- rendering/RenderObject.cpp: (WebCore::RenderObject::clippedOverflowRectForRepaint):
- rendering/RenderSVGGradientStop.h: (WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):
- 3:08 PM Changeset in webkit [40685] by
-
- 12 edits in trunk/WebCore
2009-02-05 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Add toRenderBoxModelObject() so that we can cast objects that
can have layers.
Fix getComputedStyle to return the current value of style
properties that are undergoing accelerated animations, by
asking the AnimationController if the property has accelerated
animations, and, if so, asking it to generate an appropriate
style.
Tightened up some type safety (CSSPropertyID), and code clarity
(replace bool with enum).
- 3:03 PM Changeset in webkit [40684] by
-
- 4 edits3 adds in trunk
2009-02-05 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23747
Add Chromium threading-related files.
- wtf/MainThread.cpp: Added platform guard to initializeMainThread.
- wtf/chromium/ChromiumThreading.h: Added.
- wtf/chromium/MainThreadChromium.cpp: Added. (WTF::initializeMainThread): (WTF::scheduleDispatchFunctionsOnMainThread):
WebCore:
2009-02-05 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23747
Add Chromium threading-related files.
- platform/chromium/TemporaryLinkStubs.cpp: Removed theading-related stubs.
- 3:01 PM Changeset in webkit [40683] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix whitespace in the ChangeLog
- 2:45 PM Changeset in webkit [40682] by
-
- 2 edits in trunk/WebKit/mac
- build fix
- WebView/WebScriptDebugger.mm: (WebScriptDebugger::initGlobalCallFrame):
- 2:43 PM Changeset in webkit [40681] by
-
- 4 edits in trunk/WebCore
2009-02-05 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Add toRenderButton methods for casting RenderObjects to RenderButtons. The methods will assert if the object
is not a RenderButton. Also add a toRenderButton method that takes a RenderButton but returns void and that
is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderButton.
- rendering/RenderButton.h: (WebCore::RenderButton::isRenderButton): (WebCore::toRenderButton):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
- rendering/RenderObject.h: (WebCore::RenderObject::isRenderButton):
- 2:37 PM Changeset in webkit [40680] by
-
- 2 edits in trunk/WebKit/mac
2009-02-05 Beth Dakin <Beth Dakin>
Reviewed by John Sullivan and Brady Eidson.
Fix for <rdar://problem/6557595> REGRESSION: In Mail, selecting a
mail note message doesn't display it in Mail's preview pane
This was failing because revision 36962 removed a version of
setVerticalScrollingMode that mail calls. This patch simply adds
that method back.
- WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView setVerticalScrollingMode:]):
- 2:26 PM Changeset in webkit [40679] by
-
- 17 edits in trunk/WebCore
2009-02-05 David Hyatt <hyatt@apple.com>
Move the m_layer member variable of RenderBox up into RenderBoxModelObject. Refactor styleDidChange'
of RenderObject, RenderBoxModelObject and RenderBox to get more of the code in the correct subclass.
In order to set the various RenderObject bits properly prior to the test for whether a layer is
required, I added an additional method, updateBoxModelInfoAfterStyleChange, that is responsible
for setting all of the bits.
Eliminate hasStaticX/Y, staticX/Y, and setStaticX/Y from the render tree. Move hasStaticX/Y to
RenderStyle, and just use the corresponding layer() methods for the
staticX/Y getters/setters.
Reviewed by Sam Weinig
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::adjustPositionedBlock): (WebCore::RenderBlock::layoutOnlyPositionedObjects): (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::offsetForContents): (WebCore::RenderBlock::calcPrefWidths): (WebCore::RenderBlock::baselinePosition):
- rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::destroy): (WebCore::RenderBox::styleWillChange): (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::updateBoxModelInfoFromStyle): (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight): (WebCore::RenderBox::scrollLeft): (WebCore::RenderBox::scrollTop): (WebCore::RenderBox::setScrollLeft): (WebCore::RenderBox::setScrollTop): (WebCore::RenderBox::getOverflowClipRect): (WebCore::RenderBox::localToAbsolute): (WebCore::RenderBox::absoluteToLocal): (WebCore::RenderBox::localToContainerQuad): (WebCore::RenderBox::position): (WebCore::RenderBox::computeRectForRepaint): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::RenderBoxModelObject): (WebCore::RenderBoxModelObject::destroy): (WebCore::RenderBoxModelObject::styleWillChange): (WebCore::RenderBoxModelObject::styleDidChange): (WebCore::RenderBoxModelObject::updateBoxModelInfoFromStyle):
- rendering/RenderBoxModelObject.h: (WebCore::RenderBoxModelObject::layer): (WebCore::RenderBoxModelObject::requiresLayer):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderInline.cpp: (WebCore::RenderInline::updateBoxModelInfoFromStyle): (WebCore::RenderInline::styleDidChange): (WebCore::RenderInline::relativePositionedInlineOffset):
- rendering/RenderInline.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::setStaticY): (WebCore::RenderLayer::updateLayerPosition):
- rendering/RenderLayer.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): (WebCore::RenderObject::styleDidChange):
- rendering/RenderObject.h: (WebCore::RenderObject::markContainingBlocksForLayout):
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
- rendering/bidi.cpp: (WebCore::appendRunsForObject): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::RenderBlock::findNextLineBreak):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::hasStaticX): (WebCore::InheritedFlags::hasStaticY):
- 2:07 PM Changeset in webkit [40678] by
-
- 9 edits1 add in trunk/JavaScriptCore
2009-02-05 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Bug 23713: COMPILE_ASSERTS should be moved out of TypeTraits.h and into .cpp file
<https://bugs.webkit.org/show_bug.cgi?id=23713>
- GNUmakefile.am:
- JavaScriptCore.pri:
- JavaScriptCore.scons:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- JavaScriptCoreSources.bkl:
- wtf/HashTraits.h: Remove unnecessary header file that I missed when moving out the type traits form this file.
- wtf/TypeTraits.cpp: Added. (WTF::):
- wtf/TypeTraits.h: Moved the compile asserts into TypeTraits.cpp file.
- 1:18 PM Changeset in webkit [40677] by
-
- 3 edits in trunk/WebCore
2009-02-05 Sam Weinig <sam@webkit.org>
Fix the windows build.
- bindings/scripts/CodeGeneratorCOM.pm:
- dom/Node.idl:
- 12:58 PM Changeset in webkit [40676] by
-
- 3 edits in trunk/WebCore
2009-02-05 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Update to match Gecko.
- bridge/npapi.h:
- plugins/npfunctions.h:
- 12:35 PM Changeset in webkit [40675] by
-
- 33 edits3 deletes in trunk/WebCore
2009-02-05 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Finish merging EventTargetNode up into Node.
This also fixes a small recently introduced issue where EventListeners
would not be removed from the document if they were attached to comment
nodes outside of the documentElement.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSEventTargetNodeCustom.cpp: Removed.
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener): (WebCore::JSNode::pushEventHandlerScope):
- bindings/scripts/CodeGenerator.pm:
- dom/CharacterData.cpp: (WebCore::CharacterData::CharacterData): (WebCore::CharacterData::rendererIsNeeded):
- dom/CharacterData.h:
- dom/ContainerNode.cpp: (WebCore::ContainerNode::willRemove): (WebCore::ContainerNode::attach): (WebCore::ContainerNode::detach): (WebCore::ContainerNode::insertedIntoDocument): (WebCore::ContainerNode::removedFromDocument): (WebCore::ContainerNode::setFocus): (WebCore::ContainerNode::setActive): (WebCore::ContainerNode::setHovered): (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
- dom/ContainerNode.h: (WebCore::ContainerNode::ContainerNode):
- dom/Document.cpp: (WebCore::Document::removeAllEventListenersFromAllNodes): (WebCore::Document::removeAllDisconnectedNodeEventListeners): (WebCore::Document::setFocusedNode):
- dom/EventTargetNode.cpp: Removed.
- dom/EventTargetNode.h: Removed.
- dom/Node.cpp: (WebCore::Node::scriptExecutionContext): (WebCore::Node::eventListeners): (WebCore::Node::insertedIntoDocument): (WebCore::Node::removedFromDocument): (WebCore::Node::willMoveToNewOwnerDocument): (WebCore::Node::didMoveToNewOwnerDocument): (WebCore::updateSVGElementInstancesAfterEventListenerChange): (WebCore::Node::addEventListener): (WebCore::Node::removeEventListener): (WebCore::Node::removeAllEventListenersSlowCase): (WebCore::Node::handleLocalEvents): (WebCore::eventTargetAsSVGElementInstance): (WebCore::eventTargetRespectingSVGTargetRules): (WebCore::Node::dispatchEvent): (WebCore::Node::dispatchGenericEvent): (WebCore::Node::dispatchSubtreeModifiedEvent): (WebCore::Node::dispatchWindowEvent): (WebCore::Node::dispatchUIEvent): (WebCore::Node::dispatchKeyEvent): (WebCore::Node::dispatchMouseEvent): (WebCore::Node::dispatchSimulatedMouseEvent): (WebCore::Node::dispatchSimulatedClick): (WebCore::Node::dispatchWheelEvent): (WebCore::Node::dispatchWebKitAnimationEvent): (WebCore::Node::dispatchWebKitTransitionEvent): (WebCore::Node::dispatchFocusEvent): (WebCore::Node::dispatchBlurEvent): (WebCore::Node::dispatchEventForType): (WebCore::Node::dispatchProgressEvent): (WebCore::Node::dispatchStorageEvent): (WebCore::Node::removeInlineEventListenerForType): (WebCore::Node::setInlineEventListenerForType): (WebCore::Node::setInlineEventListenerForTypeAndAttribute): (WebCore::Node::inlineEventListenerForType): (WebCore::Node::disabled): (WebCore::Node::defaultEventHandler): (WebCore::Node::onabort): (WebCore::Node::setOnabort): (WebCore::Node::onblur): (WebCore::Node::setOnblur): (WebCore::Node::onchange): (WebCore::Node::setOnchange): (WebCore::Node::onclick): (WebCore::Node::setOnclick): (WebCore::Node::oncontextmenu): (WebCore::Node::setOncontextmenu): (WebCore::Node::ondblclick): (WebCore::Node::setOndblclick): (WebCore::Node::onerror): (WebCore::Node::setOnerror): (WebCore::Node::onfocus): (WebCore::Node::setOnfocus): (WebCore::Node::oninput): (WebCore::Node::setOninput): (WebCore::Node::onkeydown): (WebCore::Node::setOnkeydown): (WebCore::Node::onkeypress): (WebCore::Node::setOnkeypress): (WebCore::Node::onkeyup): (WebCore::Node::setOnkeyup): (WebCore::Node::onload): (WebCore::Node::setOnload): (WebCore::Node::onmousedown): (WebCore::Node::setOnmousedown): (WebCore::Node::onmousemove): (WebCore::Node::setOnmousemove): (WebCore::Node::onmouseout): (WebCore::Node::setOnmouseout): (WebCore::Node::onmouseover): (WebCore::Node::setOnmouseover): (WebCore::Node::onmouseup): (WebCore::Node::setOnmouseup): (WebCore::Node::onmousewheel): (WebCore::Node::setOnmousewheel): (WebCore::Node::onbeforecut): (WebCore::Node::setOnbeforecut): (WebCore::Node::oncut): (WebCore::Node::setOncut): (WebCore::Node::onbeforecopy): (WebCore::Node::setOnbeforecopy): (WebCore::Node::oncopy): (WebCore::Node::setOncopy): (WebCore::Node::onbeforepaste): (WebCore::Node::setOnbeforepaste): (WebCore::Node::onpaste): (WebCore::Node::setOnpaste): (WebCore::Node::ondragenter): (WebCore::Node::setOndragenter): (WebCore::Node::ondragover): (WebCore::Node::setOndragover): (WebCore::Node::ondragleave): (WebCore::Node::setOndragleave): (WebCore::Node::ondrop): (WebCore::Node::setOndrop): (WebCore::Node::ondragstart): (WebCore::Node::setOndragstart): (WebCore::Node::ondrag): (WebCore::Node::setOndrag): (WebCore::Node::ondragend): (WebCore::Node::setOndragend): (WebCore::Node::onreset): (WebCore::Node::setOnreset): (WebCore::Node::onresize): (WebCore::Node::setOnresize): (WebCore::Node::onscroll): (WebCore::Node::setOnscroll): (WebCore::Node::onsearch): (WebCore::Node::setOnsearch): (WebCore::Node::onselect): (WebCore::Node::setOnselect): (WebCore::Node::onselectstart): (WebCore::Node::setOnselectstart): (WebCore::Node::onsubmit): (WebCore::Node::setOnsubmit): (WebCore::Node::onunload): (WebCore::Node::setOnunload):
- dom/Node.h:
- editing/Editor.cpp: (WebCore::Editor::dispatchCPPEvent):
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::handleLocalEvents):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::notifyFinished):
- loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::mouseButtonListener):
- page/EventHandler.cpp: (WebCore::EventHandler::dispatchDragEvent): (WebCore::EventHandler::updateMouseEventTargetNode): (WebCore::EventHandler::dispatchMouseEvent): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::canMouseDownStartSelect): (WebCore::EventHandler::canMouseDragExtendSelect): (WebCore::eventTargetNodeForDocument): (WebCore::EventHandler::keyEvent):
- page/FrameView.cpp: (WebCore::FrameView::scheduleEvent): (WebCore::FrameView::updateOverflowStatus):
- page/FrameView.h:
- page/Page.cpp: (WebCore::networkStateChanged):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::updateOverflowStatus):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::valueChanged):
- rendering/RenderMedia.h:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selectionChanged):
- svg/SVGElementInstance.h: (WebCore::SVGElementInstance::toNode):
- xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate):
- xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult):
- 12:25 PM Changeset in webkit [40674] by
-
- 2 edits in trunk/WebCore
2009-02-05 Adam Treat <adam.treat@torchmobile.com>
Fix the Qt build now that EventTargetNode.idl was removed in r40672.
- WebCore.pro:
- 12:14 PM Changeset in webkit [40673] by
-
- 4 edits in trunk/WebCore
2009-02-05 Scott Violet <sky@google.com>
Reviewed by Sam Weinig.
Bug 23462: Add RGB -> CMYK conversion algorithm
<https://bugs.webkit.org/show_bug.cgi?id=23462>
Adds an RGB -> CMYK converter. This isn't perfect, but better than
nothing.
- html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor): (WebCore::CanvasStyle::cmykToRGB):
- html/CanvasStyle.h:
- 10:38 AM Changeset in webkit [40672] by
-
- 37 edits1 delete in trunk
WebCore:
2009-02-04 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
First stage of merging EventTargetNode up into Node. The intent of this change
is to both simplify the inheritance hierarchy (at the same time making it more
closely match the spec which states that all Nodes are EventTargets) and save
4 bytes per Node that the polymorphic multiple-inheritance was costing us.
This does the bare minimum to get things compiling, the next patch will clean
- DerivedSources.make:
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark):
- bindings/js/JSEventListener.cpp: (WebCore::JSLazyEventListener::parseCode):
- bindings/js/JSEventTarget.cpp: (WebCore::toEventTarget):
- bindings/js/JSEventTarget.h:
- bindings/js/JSEventTargetNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener): (WebCore::JSNode::pushEventHandlerScope):
- bindings/js/JSStyleSheetCustom.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- dom/Attr.idl:
- dom/CharacterData.h:
- dom/CharacterData.idl:
- dom/Document.idl:
- dom/DocumentFragment.idl:
- dom/Element.idl:
- dom/EventTarget.cpp: (WebCore::EventTarget::toNode):
- dom/EventTarget.h:
- dom/EventTarget.idl:
- dom/EventTargetNode.cpp: (WebCore::Node::scriptExecutionContext): (WebCore::Node::eventListeners): (WebCore::Node::insertedIntoDocument): (WebCore::Node::removedFromDocument): (WebCore::Node::willMoveToNewOwnerDocument): (WebCore::Node::didMoveToNewOwnerDocument): (WebCore::Node::addEventListener): (WebCore::Node::removeEventListener): (WebCore::Node::removeAllEventListenersSlowCase): (WebCore::Node::handleLocalEvents): (WebCore::Node::dispatchEvent): (WebCore::Node::dispatchGenericEvent): (WebCore::Node::dispatchSubtreeModifiedEvent): (WebCore::Node::dispatchWindowEvent): (WebCore::Node::dispatchUIEvent): (WebCore::Node::dispatchKeyEvent): (WebCore::Node::dispatchMouseEvent): (WebCore::Node::dispatchSimulatedMouseEvent): (WebCore::Node::dispatchSimulatedClick): (WebCore::Node::dispatchWheelEvent): (WebCore::Node::dispatchWebKitAnimationEvent): (WebCore::Node::dispatchWebKitTransitionEvent): (WebCore::Node::dispatchFocusEvent): (WebCore::Node::dispatchBlurEvent): (WebCore::Node::dispatchEventForType): (WebCore::Node::dispatchProgressEvent): (WebCore::Node::dispatchStorageEvent): (WebCore::Node::removeInlineEventListenerForType): (WebCore::Node::setInlineEventListenerForType): (WebCore::Node::setInlineEventListenerForTypeAndAttribute): (WebCore::Node::inlineEventListenerForType): (WebCore::Node::disabled): (WebCore::Node::defaultEventHandler): (WebCore::Node::onabort): (WebCore::Node::setOnabort): (WebCore::Node::onblur): (WebCore::Node::setOnblur): (WebCore::Node::onchange): (WebCore::Node::setOnchange): (WebCore::Node::onclick): (WebCore::Node::setOnclick): (WebCore::Node::oncontextmenu): (WebCore::Node::setOncontextmenu): (WebCore::Node::ondblclick): (WebCore::Node::setOndblclick): (WebCore::Node::onerror): (WebCore::Node::setOnerror): (WebCore::Node::onfocus): (WebCore::Node::setOnfocus): (WebCore::Node::oninput): (WebCore::Node::setOninput): (WebCore::Node::onkeydown): (WebCore::Node::setOnkeydown): (WebCore::Node::onkeypress): (WebCore::Node::setOnkeypress): (WebCore::Node::onkeyup): (WebCore::Node::setOnkeyup): (WebCore::Node::onload): (WebCore::Node::setOnload): (WebCore::Node::onmousedown): (WebCore::Node::setOnmousedown): (WebCore::Node::onmousemove): (WebCore::Node::setOnmousemove): (WebCore::Node::onmouseout): (WebCore::Node::setOnmouseout): (WebCore::Node::onmouseover): (WebCore::Node::setOnmouseover): (WebCore::Node::onmouseup): (WebCore::Node::setOnmouseup): (WebCore::Node::onmousewheel): (WebCore::Node::setOnmousewheel): (WebCore::Node::onbeforecut): (WebCore::Node::setOnbeforecut): (WebCore::Node::oncut): (WebCore::Node::setOncut): (WebCore::Node::onbeforecopy): (WebCore::Node::setOnbeforecopy): (WebCore::Node::oncopy): (WebCore::Node::setOncopy): (WebCore::Node::onbeforepaste): (WebCore::Node::setOnbeforepaste): (WebCore::Node::onpaste): (WebCore::Node::setOnpaste): (WebCore::Node::ondragenter): (WebCore::Node::setOndragenter): (WebCore::Node::ondragover): (WebCore::Node::setOndragover): (WebCore::Node::ondragleave): (WebCore::Node::setOndragleave): (WebCore::Node::ondrop): (WebCore::Node::setOndrop): (WebCore::Node::ondragstart): (WebCore::Node::setOndragstart): (WebCore::Node::ondrag): (WebCore::Node::setOndrag): (WebCore::Node::ondragend): (WebCore::Node::setOndragend): (WebCore::Node::onreset): (WebCore::Node::setOnreset): (WebCore::Node::onresize): (WebCore::Node::setOnresize): (WebCore::Node::onscroll): (WebCore::Node::setOnscroll): (WebCore::Node::onsearch): (WebCore::Node::setOnsearch): (WebCore::Node::onselect): (WebCore::Node::setOnselect): (WebCore::Node::onselectstart): (WebCore::Node::setOnselectstart): (WebCore::Node::onsubmit): (WebCore::Node::setOnsubmit): (WebCore::Node::onunload): (WebCore::Node::setOnunload):
- dom/EventTargetNode.h: (WebCore::toEventTargetNode): (WebCore::EventTargetNodeCast):
- dom/EventTargetNode.idl: Removed.
- dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent): (WebCore::MouseEvent::initMouseEvent): (WebCore::MouseEvent::toElement): (WebCore::MouseEvent::fromElement):
- dom/MouseEvent.h: (WebCore::MouseEvent::create): (WebCore::MouseEvent::relatedTarget):
- dom/Node.cpp: (WebCore::Node::~Node):
- dom/Node.h: (WebCore::Node::isEventTargetNode): (WebCore::Node::toNode): (WebCore::Node::removeAllEventListeners): (WebCore::Node::refEventTarget): (WebCore::Node::derefEventTarget):
- dom/Node.idl:
- page/EventHandler.h:
- page/FrameView.h:
- xml/XPathResult.h: (WebCore::XPathResult::create):
LayoutTests:
2009-02-05 Sam Weinig <sam@webkit.org>
Reviewed by Darin Layer.
Fix after merging EventTargetNode up into Node.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-chain-expected.txt:
- 9:24 AM Changeset in webkit [40671] by
-
- 48 edits in trunk/WebCore
2009-02-04 David Hyatt <hyatt@apple.com>
Convert RenderLayer from having a RenderBox* m_renderer to having a RenderBoxModelObject*. The
container-relative repaint methods all had to be changed as a result to use RenderBoxModelObject* also.
All of RenderLayer.cpp now uses what will be the new style for dealing with an object that can be a block
or an inline flow. x()/y()/width()/height() can't be queried on an inline flow, nor can many other
properties (like scrollWidth() / scrollHeight()), so the code has to be tightened up to convert to RenderBox
under the right conditions.
There was a bogus subtraction of renderer()->y() in localBounding box for RenderInlines. Since y was always
0, this subtraction wasn't necessary. It has been removed.
Reviewed by Adam Roben
- page/animation/AnimationBase.cpp:
- rendering/RenderBR.h: (WebCore::RenderBR::selectionRectForRepaint):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::selectionGapRectsForRepaint): (WebCore::RenderBlock::rectWithOutlineForRepaint):
- rendering/RenderBlock.h: (WebCore::RenderBlock::selectionRectForRepaint):
- rendering/RenderBox.cpp: (WebCore::RenderBox::outlineBoundsForRepaint): (WebCore::RenderBox::localToContainerQuad): (WebCore::RenderBox::clippedOverflowRectForRepaint): (WebCore::RenderBox::computeRectForRepaint):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffsetX): (WebCore::RenderBoxModelObject::relativePositionOffsetY):
- rendering/RenderBoxModelObject.h: (WebCore::RenderBoxModelObject::relativePositionOffset):
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::computeRectForRepaint):
- rendering/RenderForeignObject.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::clippedOverflowRectForRepaint): (WebCore::RenderInline::rectWithOutlineForRepaint):
- rendering/RenderInline.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateTransform): (WebCore::RenderLayer::setHasVisibleContent): (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::scrollRectToVisible): (WebCore::resizerCornerRect): (WebCore::RenderLayer::scrollbarCornerPresent): (WebCore::RenderLayer::invalidateScrollbarRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::computeScrollDimensions): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::hitTestOverflowControls): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::localBoundingBox):
- rendering/RenderLayer.h: (WebCore::RenderLayer::renderer): (WebCore::RenderLayer::renderBox): (WebCore::RenderLayer::renderBoxX): (WebCore::RenderLayer::renderBoxY):
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::selectionRectForRepaint):
- rendering/RenderListMarker.h:
- rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::computePosition): (WebCore::RenderMarquee::timerFired):
- rendering/RenderObject.cpp: (WebCore::RenderObject::containerForRepaint): (WebCore::RenderObject::repaintUsingContainer): (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::rectWithOutlineForRepaint): (WebCore::RenderObject::clippedOverflowRectForRepaint): (WebCore::RenderObject::computeRectForRepaint): (WebCore::RenderObject::localToContainerQuad):
- rendering/RenderObject.h: (WebCore::RenderObject::selectionRectForRepaint): (WebCore::RenderObject::outlineBoundsForRepaint):
- rendering/RenderPath.cpp: (WebCore::RenderPath::clippedOverflowRectForRepaint): (WebCore::RenderPath::outlineBoundsForRepaint):
- rendering/RenderPath.h:
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRectForRepaint): (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
- rendering/RenderReplaced.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::clippedOverflowRectForRepaint): (WebCore::RenderSVGContainer::outlineBoundsForRepaint):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
- rendering/RenderSVGHiddenContainer.h:
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
- rendering/RenderSVGImage.h:
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::selectionRectForRepaint): (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
- rendering/RenderSVGInlineText.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
- rendering/RenderSVGText.h:
- rendering/RenderSelectionInfo.h: (WebCore::RenderSelectionInfoBase::repaintContainer):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::clippedOverflowRectForRepaint): (WebCore::RenderTableCell::computeRectForRepaint): (WebCore::RenderTableCell::localToContainerQuad):
- rendering/RenderTableCell.h:
- rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::clippedOverflowRectForRepaint):
- rendering/RenderTableCol.h:
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
- rendering/RenderTableRow.h:
- rendering/RenderText.cpp: (WebCore::RenderText::clippedOverflowRectForRepaint): (WebCore::RenderText::selectionRectForRepaint):
- rendering/RenderText.h:
- rendering/RenderTreeAsText.cpp: (WebCore::write):
- rendering/RenderView.cpp: (WebCore::RenderView::localToContainerQuad): (WebCore::RenderView::computeRectForRepaint):
- rendering/RenderView.h:
- 6:38 AM Changeset in webkit [40670] by
-
- 2 edits in trunk/WebCore
Build fix.
- page/animation/KeyframeAnimation.h: A function prototype had two "fromStyle" arguments.
- 6:34 AM Changeset in webkit [40669] by
-
- 2 edits in trunk/WebCore
2009-02-05 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Alexey Proskuryakov.
Landed by Simon Hausmann.
Use a 2 arguments constructor for KURL to avoid ASSERT failure.
- 6:06 AM Moving to Git edited by
- Flesh out why Git makes code review easier/better (diff)
- 12:44 AM Moving to Git edited by
- (diff)
Feb 4, 2009:
- 11:27 PM Changeset in webkit [40668] by
-
- 1 edit2 adds in trunk/WebCore
2009-02-04 Feng Qian <feng@chromium.org>
Reviewed by Darin Adler.
Add Android-specific files to WebCore/editing directory.
https://bugs.webkit.org/show_bug.cgi?id=23294
- editing/android: Added.
- editing/android/EditorAndroid.cpp: Added. (WebCore::Editor::newGeneralClipboard):
- 11:23 PM Changeset in webkit [40667] by
-
- 15 edits in trunk
WebCore:
2009-02-04 Dean Jackson <dino@apple.com>
Reviewed by Darin Adler.
Remove -webkit-animation-play-state
The AnimationController still has the code to execute the property, but
it is no longer parsed or recorded.
https://bugs.webkit.org/show_bug.cgi?id=22907
- css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationProperty):
- css/CSSParser.h:
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/CSSStyleSelector.h:
- platform/animation/Animation.h:
- rendering/style/RenderStyleConstants.h:
LayoutTests:
2009-02-04 Dean Jackson <dino@apple.com>
Reviewed by Darin Adler.
Remove animation-play-state from expected properties.
https://bugs.webkit.org/show_bug.cgi?id=22907
- animations/computed-style-expected.txt:
- animations/computed-style.html:
- fast/css/computed-style-display-none-expected.txt:
- fast/css/computed-style-expected.txt:
- fast/css/computed-style-without-renderer-expected.txt:
- fast/css/computed-style-without-renderer.html:
- svg/css/getComputedStyle-basic-expected.txt:
- 10:41 PM Changeset in webkit [40666] by
-
- 3 edits2 adds in trunk
WebCore:
2009-02-04 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Darin Adler.
Make sure we don't load on removing the media element from the document
https://bugs.webkit.org/show_bug.cgi?id=22105
Test: media/remove-from-document-no-load.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::removedFromDocument):
LayoutTests:
2009-02-04 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Darin Adler.
Make sure we don't load on removing the media element from the document
https://bugs.webkit.org/show_bug.cgi?id=22105.
- media/remove-from-document-no-load-expected.txt: Added.
- media/remove-from-document-no-load.html: Added.
- 10:15 PM Changeset in webkit [40665] by
-
- 9 edits2 adds in trunk/WebCore
2009-02-04 David Hyatt <hyatt@apple.com>
Add a new RenderBoxModelObject class that will eventually act as the direct base class for RenderInlines. For
now just adding the class and putting it in between RenderObject and RenderBox in the hierarchy. RenderInline remains
derived from RenderBox for now.
Reviewed by Sam Weinig
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::destroy): (WebCore::RenderBox::styleWillChange): (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::computeRectForRepaint):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp: Added. (WebCore::RenderBoxModelObject::RenderBoxModelObject): (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
- rendering/RenderBoxModelObject.h: Added.
- rendering/RenderObject.h:
- 10:07 PM Changeset in webkit [40664] by
-
- 17 edits1 add in trunk/WebCore
2009-02-04 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt
Added accelerated animation support to AnimationController and friends. The primary
changes are:
- accelerated animations get their start time from the compositing engine, so we wait for a callback (notifyAnimationStarted()) in order to get the start time.
- if software and accelerated animations start in the same cycle, they all need to use the same start time, which is that of the accelerated animations.
Added AnimationControllerPrivate to preserve the encapsulation under
AnimationController.
- 9:31 PM Changeset in webkit [40663] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-04 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver 'the nun' Hunt.
Add -e switch to jsc to enable evaluation of scripts passed on the command line.
- jsc.cpp: (Script::Script): (runWithScripts): (printUsageStatement): (parseArguments): (jscmain):
- 9:11 PM Moving to Git edited by
- (diff)
- 8:18 PM Changeset in webkit [40662] by
-
- 2 edits in trunk/WebCore
2009-02-04 Dimitri Glazkov <Dimitri Glazkov>
Not reviewed, build fix.
Remove duplicate definition of msSans in FontCache::alternateFamilyName.
- platform/graphics/FontCache.cpp: (WebCore::alternateFamilyName):
- 8:07 PM Changeset in webkit [40661] by
-
- 1 edit4 deletes in trunk/LayoutTests
2009-02-04 Dmitry Titov <dimich@chromium.org>
Not reviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=22806
Reverting the test that should not yet be landed since it depends on
changes in DRT which were not yet landed.
- fast/dom/Window/cached-timeout-stopped-on-close-expected.txt: Removed.
- fast/dom/Window/cached-timeout-stopped-on-close.html: Removed.
- fast/dom/Window/resources/cached-timeout-page-1.html: Removed.
- fast/dom/Window/resources/cached-timeout-page-2.html: Removed.
- 7:40 PM Changeset in webkit [40660] by
-
- 3 edits4 copies in trunk/JavaScriptCore
2009-02-04 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Sam 'Big Mac' Weinig.
- assembler/AbstractMacroAssembler.h: Copied from assembler/MacroAssembler.h.
- assembler/MacroAssemblerX86.h: Copied from assembler/MacroAssembler.h.
- assembler/MacroAssemblerX86Common.h: Copied from assembler/MacroAssembler.h.
- assembler/MacroAssemblerX86_64.h: Copied from assembler/MacroAssembler.h.
- 7:34 PM Changeset in webkit [40659] by
-
- 4 edits in branches/Safari-6528
Versioning.
- 7:33 PM Changeset in webkit [40658] by
-
- 1 copy in tags/Safari-6528.12
New tag.
- 7:32 PM Changeset in webkit [40657] by
-
- 4 edits in branches/Safari-6528
Versioning.
- 6:40 PM WebCoreRendering edited by
- (diff)
- 6:01 PM Changeset in webkit [40656] by
-
- 3 edits in trunk/JavaScriptCore
2009-02-04 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
This patch tidies up the MacroAssembler, cleaning up the code and refactoring out the
platform-specific parts. The MacroAssembler gets split up like a beef burger, with the
platform-agnostic data types being the lower bun (in the form of the class AbstractMacroAssembler),
the plaform-specific code generation forming a big meaty patty of methods like 'add32',
'branch32', etc (MacroAssemblerX86), and finally topped off with the bun-lid of the
MacroAssembler class itself, providing covenience methods such as the stack peek & poke,
and backwards branch methods, all of which can be described in a platform independent
way using methods from the base class. The AbstractMacroAssembler is templated on the
type of the assembler class that will be used for code generation, and the three layers
are held together with the cocktail stick of inheritance.
The above description is a slight simplification since the MacroAssemblerX86 is actually
formed from two layers (in effect giving us a kind on bacon double cheeseburger) - with the
bulk of methods that are common between x86 & x86-64 implemented in MacroAssemblerX86Common,
which forms a base class for MacroAssemblerX86 and MacroAssemblerX86_64 (which add the methods
specific to the given platform).
I'm landing these changes first without splitting the classes across multiple files,
I will follow up with a second patch to split up the file MacroAssembler.h.
- assembler/MacroAssembler.h: (JSC::AbstractMacroAssembler::): (JSC::AbstractMacroAssembler::DataLabelPtr::DataLabelPtr): (JSC::AbstractMacroAssembler::DataLabelPtr::patch): (JSC::AbstractMacroAssembler::DataLabel32::DataLabel32): (JSC::AbstractMacroAssembler::DataLabel32::patch): (JSC::AbstractMacroAssembler::Label::Label): (JSC::AbstractMacroAssembler::Jump::Jump): (JSC::AbstractMacroAssembler::Jump::link): (JSC::AbstractMacroAssembler::Jump::linkTo): (JSC::AbstractMacroAssembler::Jump::patch): (JSC::AbstractMacroAssembler::JumpList::link): (JSC::AbstractMacroAssembler::JumpList::linkTo): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::AbstractMacroAssembler::PatchBuffer::addressOf): (JSC::AbstractMacroAssembler::PatchBuffer::setPtr): (JSC::AbstractMacroAssembler::size): (JSC::AbstractMacroAssembler::copyCode): (JSC::AbstractMacroAssembler::label): (JSC::AbstractMacroAssembler::align): (JSC::AbstractMacroAssembler::differenceBetween): (JSC::MacroAssemblerX86Common::xor32): (JSC::MacroAssemblerX86Common::load32WithAddressOffsetPatch): (JSC::MacroAssemblerX86Common::store32WithAddressOffsetPatch): (JSC::MacroAssemblerX86Common::move): (JSC::MacroAssemblerX86Common::swap): (JSC::MacroAssemblerX86Common::signExtend32ToPtr): (JSC::MacroAssemblerX86Common::zeroExtend32ToPtr): (JSC::MacroAssemblerX86Common::branch32): (JSC::MacroAssemblerX86Common::jump): (JSC::MacroAssemblerX86_64::add32): (JSC::MacroAssemblerX86_64::sub32): (JSC::MacroAssemblerX86_64::load32): (JSC::MacroAssemblerX86_64::store32): (JSC::MacroAssemblerX86_64::addPtr): (JSC::MacroAssemblerX86_64::andPtr): (JSC::MacroAssemblerX86_64::orPtr): (JSC::MacroAssemblerX86_64::rshiftPtr): (JSC::MacroAssemblerX86_64::subPtr): (JSC::MacroAssemblerX86_64::xorPtr): (JSC::MacroAssemblerX86_64::loadPtr): (JSC::MacroAssemblerX86_64::loadPtrWithAddressOffsetPatch): (JSC::MacroAssemblerX86_64::storePtr): (JSC::MacroAssemblerX86_64::storePtrWithAddressOffsetPatch): (JSC::MacroAssemblerX86_64::branchPtr): (JSC::MacroAssemblerX86_64::branchTestPtr): (JSC::MacroAssemblerX86_64::branchAddPtr): (JSC::MacroAssemblerX86_64::branchSubPtr): (JSC::MacroAssemblerX86_64::branchPtrWithPatch): (JSC::MacroAssemblerX86_64::storePtrWithPatch): (JSC::MacroAssemblerX86::add32): (JSC::MacroAssemblerX86::sub32): (JSC::MacroAssemblerX86::load32): (JSC::MacroAssemblerX86::store32): (JSC::MacroAssemblerX86::branch32): (JSC::MacroAssemblerX86::branchPtrWithPatch): (JSC::MacroAssemblerX86::storePtrWithPatch): (JSC::MacroAssembler::pop): (JSC::MacroAssembler::peek): (JSC::MacroAssembler::poke): (JSC::MacroAssembler::branchPtr): (JSC::MacroAssembler::branch32): (JSC::MacroAssembler::branch16): (JSC::MacroAssembler::branchTestPtr): (JSC::MacroAssembler::addPtr): (JSC::MacroAssembler::andPtr): (JSC::MacroAssembler::orPtr): (JSC::MacroAssembler::rshiftPtr): (JSC::MacroAssembler::subPtr): (JSC::MacroAssembler::xorPtr): (JSC::MacroAssembler::loadPtr): (JSC::MacroAssembler::loadPtrWithAddressOffsetPatch): (JSC::MacroAssembler::storePtr): (JSC::MacroAssembler::storePtrWithAddressOffsetPatch): (JSC::MacroAssembler::branchAddPtr): (JSC::MacroAssembler::branchSubPtr):
- jit/JITArithmetic.cpp: (JSC::JIT::compileBinaryArithOp):
- 5:49 PM Changeset in webkit [40655] by
-
- 2 edits in trunk/WebKit/mac
2009-02-04 Anders Carlsson <andersca@apple.com>
Build fix fix.
- WebView/WebScriptDebugger.mm: (WebScriptDebugger::initGlobalCallFrame):
- 5:26 PM Changeset in webkit [40654] by
-
- 2 edits in trunk/WebCore
Reviewed by George Staikos.
Reverse the meaning of the if check so that Android
(dpad devices) do not scroll on focus and normal platforms do
http://trac.webkit.org/changeset/40647
This was caught by George Staikos, and I wrote the patch.
- dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
- 5:18 PM Changeset in webkit [40653] by
-
- 4 edits in trunk/WebKit/mac
2009-02-04 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Change PCHasProperty, PCHasMethod and PCGetProperty into simpleroutines.
Rename PHEvaluateReply to PHBooleanAndDataReply and add PHBooleanReply.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCInvoke): (WKPCGetProperty): (WKPCHasProperty): (WKPCHasMethod):
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs:
- 5:02 PM Changeset in webkit [40652] by
-
- 2 edits in trunk/WebKit/win
2009-02-04 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebHistory.cpp: (WebHistory::visitedURL):
- 4:53 PM Changeset in webkit [40651] by
-
- 26 edits2 deletes in trunk/WebCore
2009-02-04 David Hyatt <hyatt@apple.com>
Eliminate RenderContainer.
Reviewed by Sam and Anders
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::styleWillChange): (WebCore::RenderBlock::styleDidChange): (WebCore::RenderBlock::addChild): (WebCore::RenderBlock::dirtyLineBoxes): (WebCore::RenderBlock::createInlineBox): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::setSelectionState): (WebCore::RenderBlock::avoidsFloats): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::calcInlinePrefWidths): (WebCore::RenderBlock::baselinePosition): (WebCore::RenderBlock::getBaselineOfFirstLineBox): (WebCore::RenderBlock::getBaselineOfLastLineBox): (WebCore::RenderBlock::rectWithOutlineForRepaint): (WebCore::RenderBlock::hoverAncestor): (WebCore::RenderBlock::updateDragState): (WebCore::RenderBlock::localCaretRect):
- rendering/RenderBlock.h: (WebCore::RenderBlock::virtualChildren): (WebCore::RenderBlock::children):
- rendering/RenderContainer.cpp: Removed.
- rendering/RenderContainer.h: Removed.
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::RenderFrameSet): (WebCore::RenderFrameSet::nodeAtPoint): (WebCore::RenderFrameSet::layout):
- rendering/RenderFrameSet.h: (WebCore::RenderFrameSet::virtualChildren): (WebCore::RenderFrameSet::children):
- rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::destroy): (WebCore::RenderInline::styleDidChange): (WebCore::nextContinuation): (WebCore::RenderInline::continuationBefore): (WebCore::RenderInline::addChildIgnoringContinuation): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::addChildToContinuation): (WebCore::RenderInline::offsetLeft): (WebCore::RenderInline::offsetTop): (WebCore::RenderInline::positionForCoordinates): (WebCore::RenderInline::clippedOverflowRectForRepaint): (WebCore::RenderInline::rectWithOutlineForRepaint): (WebCore::RenderInline::updateDragState): (WebCore::RenderInline::childBecameNonInline):
- rendering/RenderInline.h: (WebCore::RenderInline::virtualChildren): (WebCore::RenderInline::children): (WebCore::RenderInline::continuation): (WebCore::RenderInline::setContinuation):
- rendering/RenderLineBoxList.h:
- rendering/RenderObject.h:
- rendering/RenderObjectChildList.h:
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::applyContentTransforms): (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::absoluteTransform): (WebCore::RenderSVGRoot::nodeAtPoint): (WebCore::RenderSVGRoot::position):
- rendering/RenderSVGRoot.h: (WebCore::RenderSVGRoot::virtualChildren): (WebCore::RenderSVGRoot::children):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::absoluteQuads):
- rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): (WebCore::RenderTable::removeChild):
- rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::RenderTableCol):
- rendering/RenderTableCol.h: (WebCore::RenderTableCol::virtualChildren): (WebCore::RenderTableCol::children):
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::RenderTableRow): (WebCore::RenderTableRow::destroy): (WebCore::RenderTableRow::styleWillChange): (WebCore::RenderTableRow::addChild):
- rendering/RenderTableRow.h: (WebCore::RenderTableRow::virtualChildren): (WebCore::RenderTableRow::children):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::destroy): (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::removeChild): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition):
- rendering/RenderTableSection.h: (WebCore::RenderTableSection::virtualChildren): (WebCore::RenderTableSection::children):
- 4:49 PM Changeset in webkit [40650] by
-
- 1 edit1 move in trunk/LayoutTests
2009-02-04 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Rename layout test result to the correct name.
- storage/transaction-callback-exception-crash-expected.txt: Renamed from LayoutTests/storage/transaction-callback-exception-crash.txt.
- 4:40 PM Changeset in webkit [40649] by
-
- 2 edits in trunk/WebKit/mac
2009-02-04 Anders Carlsson <andersca@apple.com>
Reviewed by Mark Rowe.
Fix 64-bit build.
- WebView/WebScriptDebugger.mm: (WebScriptDebugger::initGlobalCallFrame):
- 4:40 PM Changeset in webkit [40648] by
-
- 2 edits in trunk/WebCore
2009-02-04 Mads Adger <mad@chromium.org>
Reviewed by Antti Koivisto.
Bug 23180 Reading freed memory at DocumentLoader::checkForPendingPreloads
https://bugs.webkit.org/show_bug.cgi?id=23180
Added a protector for the document potentially holding on the last reference to the loader we are interating with.
- loader/loader.cpp: (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail):
- 4:35 PM Changeset in webkit [40647] by
-
- 2 edits in trunk/WebCore
2009-02-04 Cary Clark <caryclark@google.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23163
Don't scroll to show current focus on devices that use
directional pads for navigation.
- dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
- 4:31 PM Changeset in webkit [40646] by
-
- 2 edits in trunk/WebCore
2009-02-04 Cary Clark <caryclark@google.com>
Reviewed by Darin Adler.
Change RenderBlock::columnGap() access permissions from protected to
public. ANDROID creates an array of focus rectangles for navigation
with a trackball or directional pad, and needs access to the column gap
to implement this logic.
Android has no testing harness @ webkit.org, thus no tests.
- rendering/RenderBlock.h:
- 4:27 PM Changeset in webkit [40645] by
-
- 3 edits in trunk
2009-02-04 Cary Clark <caryclark@google.com>
Reviewed by Eric Seidel.
Add ENABLE_ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL to permit the ANDROID
platform to select all when focusing on a textarea. This matches
the user interface guidelines other applications on the platform.
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateFocusAppearance):
- 4:19 PM Changeset in webkit [40644] by
-
- 4 edits in trunk/WebCore
2009-02-04 Beth Dakin <Beth Dakin>
Reviewed by Dave Hyatt.
Fix for <rdar://problem/6386112> Some inline-elements are not
becoming proper dashboard-regions
RenderInline needs its own implementation of addDashboardRegions
because otherwise all of the coordinate calculations are
inaccurate.
- rendering/RenderInline.cpp: (WebCore::RenderInline::addDashboardRegions):
- rendering/RenderInline.h:
- rendering/RenderObject.h:
- 4:12 PM Changeset in webkit [40643] by
-
- 7 edits in trunk/WebCore
2009-02-04 David Hyatt <hyatt@apple.com>
Move addChild/removeChild from RenderContainer to RenderObject.
Reviewed by Sam Weinig
- rendering/RenderContainer.cpp:
- rendering/RenderContainer.h:
- rendering/RenderObject.cpp: (WebCore::updateListMarkerNumbers): (WebCore::RenderObject::addChild): (WebCore::RenderObject::removeChild):
- rendering/RenderObject.h: (WebCore::RenderObject::addChildIgnoringContinuation):
- rendering/RenderSVGContainer.cpp:
- rendering/RenderSVGContainer.h:
- 4:05 PM Changeset in webkit [40642] by
-
- 8 edits in trunk/WebCore
2009-02-04 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
<rdar://problem/3541409> - Further HistoryItem / BF cache cleanup
- history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): (WebCore::CachedFrame::restore):
- history/CachedFrame.h:
- history/CachedPage.cpp: (WebCore::CachedPage::restore):
- history/CachedPage.h: (WebCore::CachedPage::mainFrameView):
- history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem):
- history/HistoryItem.h: (WebCore::HistoryItem::isInPageCache):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::open):
- 4:00 PM Changeset in webkit [40641] by
-
- 5 edits in trunk/WebCore
2009-02-04 Peter Kasting <pkasting@google.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23743
Fix memory corruption with open-source GIF decoders.
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::clear):
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::clearFrameBufferCache):
- platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::clearFrameBufferCache): (WebCore::GIFImageDecoder::initFrameBuffer):
- platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::clear):
- 3:56 PM Changeset in webkit [40640] by
-
- 13 edits in trunk/WebCore
2009-02-04 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
When using accelerated compositing, make repaints use the correct
repaint container. Hook up the RenderLayerCompositor in RenderView,
and add to RenderView a method that repaints both the view
contents, and any intersecting composited layers.
Make enclosingCompositingLayer() a method on RenderObject, and update
the compositor to use that. Add a helper method on the compositor to
get the non-self compositing ancestor: ancestorCompositingLayer().
Call repaintRectangleInViewAndCompositedLayers() in places that don't do
container-relative repainting: selection redraw on focus change, caret,
and widget updates.
Fix a bug in RenderLayerCompositor where the m_compositingLayersNeedUpdate flag
would get cleared for partial updates, thus preventing subsequent full updates.
Fix a bug in RenderLayer::ensureBacking() that made new backing every time.
- 3:55 PM Changeset in webkit [40639] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-02-04 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
Regression test for https://bugs.webkit.org/show_bug.cgi?id=22753
- fast/dom/Window/cached-timeout-stopped-on-close-expected.txt: Added.
- fast/dom/Window/cached-timeout-stopped-on-close.html: Added.
- fast/dom/Window/resources/cached-timeout-page-1.html: Added.
- fast/dom/Window/resources/cached-timeout-page-2.html: Added.
- 3:44 PM Changeset in webkit [40638] by
-
- 13 edits in trunk/WebCore
2009-02-04 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Add toRenderImage methods for casting RenderObjects to RenderImages. The methods will assert if the object
is not a RenderImage. Also add a toRenderImage method that takes a RenderImage but returns void and that
is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderImage.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::attach):
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): (WebCore::HTMLImageElement::attach):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::attach):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::attach):
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::attach):
- loader/ImageLoader.cpp: (WebCore::ImageLoader::setImage): (WebCore::ImageLoader::updateFromElement): (WebCore::ImageLoader::notifyFinished):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): (WebCore::AccessibilityRenderObject::addChildren):
- page/DragController.cpp: (WebCore::getCachedImage): (WebCore::getImage):
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage):
- rendering/RenderImage.h: (WebCore::toRenderImage):
- wml/WMLImageElement.cpp: (WebCore::WMLImageElement::parseMappedAttribute): (WebCore::WMLImageElement::attach):
- 3:28 PM Changeset in webkit [40637] by
-
- 4 edits in trunk/WebKit
WebKit/mac:
2009-02-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
Part I of <rdar://problem/6552272>.
Clear the redirectURLs entry when first visiting a site, so sites that
only redirect you the first time you visit them can later learn that
they don't redirect.
- History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:serverRedirectURL:isClientRedirect:]):
WebKit/win:
2009-02-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
Part I of <rdar://problem/6552272>.
Clear the redirectURLs entry when first visiting a site, so sites that
only redirect you the first time you visit them can later learn that
they don't redirect.
- WebHistory.cpp: (WebHistory::visitedURL):
- 3:25 PM Changeset in webkit [40636] by
-
- 2 edits in trunk/WebCore
2009-02-04 Jungshik Shin <jshin@chromium.org>
Reviewed by Eric Seidel and Dave Hyatt.
Make alternateFamilyName customized for Windows and Chromium.
- platform/graphics/FontCache.cpp: (WebCore::alternateFamilyName):
- 3:22 PM Changeset in webkit [40635] by
-
- 4 edits in trunk/WebCore
2009-02-04 Jungshik Shin <jshin@chromium.org>
Reviewed by Eric Seidel.
This comes from Chromium patch (http://codereview.chromium.org/17624).
Add m_disableFontFallback to UniscriberHelper class and set it
to true when filling up glyph pages for non-BMP code points.
When it's set true, UniscriberHelper does not do its own font
fallback. Neither does it do glyph placement. Font fallback
will be taken care of in the simple script font path and glyph
placement is not necessary for simple scripts.
Layout test is missing at the moment due to the lack of freely
distributable font covering a non-BMP code page. A test page
is available at http://i18nl10n.com/webkit/nonbmp2.html
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillNonBMPGlyphs):
- platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::UniscribeHelper): (WebCore::UniscribeHelper::shape): (WebCore::UniscribeHelper::fillShapes):
- platform/graphics/chromium/UniscribeHelper.h: (WebCore::UniscribeHelper::setDisableFontFallback):
- 3:20 PM Changeset in webkit [40634] by
-
- 8 edits in trunk/WebCore
2009-02-04 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Remove some unnecessary #includes of RenderStyle.h
- css/CSSPrimitiveValueMappings.h:
- css/SVGCSSComputedStyleDeclaration.cpp:
- dom/Node.h:
- rendering/PointerEventsHitRules.h:
- rendering/RenderImageGeneratedContent.h:
- rendering/RenderMarquee.h:
- rendering/RenderScrollbar.h:
- 2:59 PM Changeset in webkit [40633] by
-
- 3 edits4 deletes in trunk/WebCore
2009-02-04 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=23657
Clean up WebCore/storage IDLs.
- storage/SQLError.idl: Changed to match spec.
- storage/SQLResultSet.idl: Changed to match spec.
- storage/SQLStatementCallback.idl: Removed.
- storage/SQLStatementErrorCallback.idl: Removed.
- storage/SQLTransactionCallback.idl: Removed.
- storage/SQLTransactionErrorCallback.idl: Removed.
- 2:52 PM Changeset in webkit [40632] by
-
- 6 edits2 moves in trunk/LayoutTests
2009-02-04 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=23655
Clean up storage layout tests a bit.
- storage/close-during-stress-test.html: Moved brace to new line.
- storage/empty-statement.html: Moved brace to new line.
- storage/execute-sql-args.html: Moved brace to new line.
- storage/quota-tracking.html: Moved brace to new line.
- storage/success-callback.html: Moved brace to new line, removed erroneous callback argument.
- storage/transaction-callback-exception-crash.html: Added.
- storage/transaction-callback-exception-crash.txt: Renamed from LayoutTests/storage/transaction_callback_exception_crash-expected.txt.
- storage/transaction_callback_exception_crash.html: Removed.
- 2:34 PM Changeset in webkit [40631] by
-
- 2 edits in trunk/WebKit/mac
Change the WebSourceId typedef from int to intptr_t now that <rdar://problem/6263297> is fixed.
<rdar://problem/6263293> WebScriptDebugDelegate should use intptr_t for sourceId, not int
Reviewed by Oliver Hunt.
- WebView/WebScriptDebugDelegate.h:
- 2:34 PM Changeset in webkit [40630] by
-
- 6 edits2 deletes in trunk/WebKit
Switched over from using the WebSafeForwarder for the Script Debug delegate and added high performance CallScriptDebugDelegate functions.
WebKit:
2009-02-04 Timothy Hatcher <timothy@apple.com>
Removed the WebDefaultScriptDebugDelegate now that we have CallScriptDebugDelegate.
<rdar://problem/6508457> Launching widget in Dashcode debugger is
super-slow due forwardInvocation: calling debug delegate
Reviewed by Oliver Hunt.
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2009-02-04 Timothy Hatcher <timothy@apple.com>
Switched over from using the WebSafeForwarder for the Script Debug
delegate and added high performance CallScriptDebugDelegate functions.
<rdar://problem/6508457> Launching widget in Dashcode debugger is
super-slow due forwardInvocation: calling debug delegate
Reviewed by Oliver Hunt.
- DefaultDelegates/WebDefaultScriptDebugDelegate.h: Removed.
- DefaultDelegates/WebDefaultScriptDebugDelegate.m: Removed.
- WebView/WebScriptDebugger.mm: (WebScriptDebugger::initGlobalCallFrame): Use CallScriptDebugDelegate. (WebScriptDebugger::sourceParsed): Ditto. (WebScriptDebugger::callEvent): Ditto. (WebScriptDebugger::atStatement): Ditto. (WebScriptDebugger::returnEvent): Ditto. (WebScriptDebugger::exception): Ditto.
- WebView/WebView.mm: (-[WebViewPrivate dealloc]): Removed scriptDebugDelegateForwarder. (-[WebView _cacheScriptDebugDelegateImplementations]): Added. Gets the method implementations for the script debug delegate. Also caches what didParseSource method to use. (WebViewGetScriptDebugDelegateImplementations): Added. Returns the WebScriptDebugDelegateImplementations structure. (-[WebView setScriptDebugDelegate:]): Call _cacheScriptDebugDelegateImplementations. (CallDelegate): Added more overloaded versions that take different arguments. (CallScriptDebugDelegate): Added overloaded versions that take different arguments.
- WebView/WebViewInternal.h:
- 2:29 PM Changeset in webkit [40629] by
-
- 6 edits in trunk/WebCore
2009-02-04 David Hyatt <hyatt@apple.com>
Fix for https://bugs.webkit.org/show_bug.cgi?id=23734, blank content on blogs.msdn.com.
Add debugging code that will catch the incorrect dirtying of a table section immediately if it happens
during calcRowHeight or layoutRows. This should make it possible to discover future bugs where table sections don't
paint.
The bug in blogs.msdn.com, which was caused by a bad setNeedsLayout in RenderLayer::updateScrollInfoAtferLayout. Make
sure to do only a local setNeedsLayout inside that function.
Reviewed by Beth Dakin
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout):
- rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject):
- rendering/RenderObject.h: (WebCore::RenderObject::isSetNeedsLayoutForbidden): (WebCore::RenderObject::setNeedsLayoutIsForbidden): (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setChildNeedsLayout): (WebCore::RenderObject::markContainingBlocksForLayout):
- rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows):
- 2:27 PM Changeset in webkit [40628] by
-
- 56 edits in trunk/WebCore
2009-02-04 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Rename RenderStyle::Diff to StyleDifference and move it to
RenderStyleConstants.h.
- rendering/RenderBR.cpp: (WebCore::RenderBR::styleDidChange):
- rendering/RenderBR.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange): (WebCore::RenderBlock::styleDidChange):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange): (WebCore::RenderBox::styleDidChange):
- rendering/RenderBox.h:
- rendering/RenderButton.cpp: (WebCore::RenderButton::styleWillChange): (WebCore::RenderButton::styleDidChange):
- rendering/RenderButton.h:
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::styleDidChange):
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::styleDidChange):
- rendering/RenderFileUploadControl.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::styleDidChange):
- rendering/RenderInline.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::styleChanged):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateLayerCompositingState): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
- rendering/RenderLayerCompositor.h:
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::styleDidChange):
- rendering/RenderListBox.h:
- rendering/RenderListItem.cpp: (WebCore::RenderListItem::styleDidChange):
- rendering/RenderListItem.h:
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::styleWillChange): (WebCore::RenderListMarker::styleDidChange):
- rendering/RenderListMarker.h:
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::styleDidChange):
- rendering/RenderMenuList.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): (WebCore::RenderObject::styleWillChange): (WebCore::RenderObject::styleDidChange):
- rendering/RenderObject.h:
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::styleDidChange):
- rendering/RenderReplaced.h:
- rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::styleDidChange):
- rendering/RenderSVGGradientStop.h:
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::styleDidChange):
- rendering/RenderSVGInlineText.h:
- rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::styleWillChange): (WebCore::RenderScrollbarPart::styleDidChange):
- rendering/RenderScrollbarPart.h:
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::styleDidChange):
- rendering/RenderSlider.h:
- rendering/RenderTable.cpp: (WebCore::RenderTable::styleDidChange):
- rendering/RenderTable.h:
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::styleWillChange): (WebCore::RenderTableCell::styleDidChange):
- rendering/RenderTableCell.h:
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::styleWillChange):
- rendering/RenderTableRow.h:
- rendering/RenderText.cpp: (WebCore::RenderText::styleDidChange):
- rendering/RenderText.h: (WebCore::RenderText::styleWillChange):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::styleDidChange):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::styleDidChange):
- rendering/RenderTextControlSingleLine.h:
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::styleDidChange):
- rendering/RenderWidget.h:
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): (WebCore::RenderStyle::setClip):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h: (WebCore::):
- 1:12 PM Changeset in webkit [40627] by
-
- 4 edits in branches/Safari-6528/WebKit/win
Merge r40365.
- 1:08 PM WikiStart edited by
- (diff)
- 1:08 PM UsingGitWithWebKit edited by
- (diff)
- 1:07 PM UsingGitWithWebKit edited by
- (diff)
- 1:04 PM Changeset in webkit [40626] by
-
- 3 edits in branches/Safari-6528/WebKit/win
Merge r40511.
- 1:04 PM Moving to Git edited by
- My initial brainstorming… (diff)
- 1:02 PM Changeset in webkit [40625] by
-
- 30 edits in trunk/WebCore
2009-02-03 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Move PseudoId enum out of RenderStyle and into RenderStyleConstants.h
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker): (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass): (WebCore::CSSStyleSelector::applyProperty):
- css/CSSStyleSelector.h:
- dom/Node.cpp: (WebCore::Node::diff):
- page/FrameView.cpp: (WebCore::FrameView::createScrollbar):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
- rendering/MediaControlElements.cpp: (WebCore::MediaTextDisplayElement::MediaTextDisplayElement): (WebCore::MediaTimeDisplayElement::MediaTimeDisplayElement): (WebCore::MediaControlInputElement::MediaControlInputElement): (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
- rendering/MediaControlElements.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleDidChange): (WebCore::RenderBlock::updateBeforeAfterContent): (WebCore::RenderBlock::firstLineBlock): (WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::isAfterContent):
- rendering/RenderButton.cpp: (WebCore::RenderButton::updateBeforeAfterContent):
- rendering/RenderButton.h:
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::createButtonStyle):
- rendering/RenderInline.cpp: (WebCore::RenderInline::styleDidChange): (WebCore::isAfterContent): (WebCore::RenderInline::addChildIgnoringContinuation): (WebCore::RenderInline::splitInlines):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::updateScrollCornerStyle): (WebCore::RenderLayer::updateResizerStyle):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::createScrollbar):
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::createPanel): (WebCore::RenderMedia::createTimelineContainer):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::createScrollbar):
- rendering/RenderObject.cpp: (WebCore::RenderObject::selectionBackgroundColor): (WebCore::RenderObject::selectionForegroundColor): (WebCore::RenderObject::firstLineStyleSlowCase): (WebCore::RenderObject::getCachedPseudoStyle): (WebCore::RenderObject::getUncachedPseudoStyle):
- rendering/RenderObject.h: (WebCore::RenderObject::isAnonymousBlock):
- rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::destroyLeftoverChildren): (WebCore::beforeAfterContainer): (WebCore::RenderObjectChildList::invalidateCounters): (WebCore::RenderObjectChildList::updateBeforeAfterContent):
- rendering/RenderObjectChildList.h:
- rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::getScrollbarPseudoStyle): (WebCore::pseudoForScrollbarPart):
- rendering/RenderScrollbar.h:
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createInnerTextStyle): (WebCore::RenderTextControlSingleLine::createResultsButtonStyle): (WebCore::RenderTextControlSingleLine::createCancelButtonStyle): (WebCore::RenderTextControlSingleLine::createScrollbar):
- rendering/style/RenderStyle.cpp: (WebCore::pseudoBit):
- rendering/style/RenderStyle.h: (WebCore::):
- rendering/style/RenderStyleConstants.h: (WebCore::):
- 12:58 PM Changeset in webkit [40624] by
-
- 3 edits in branches/Safari-6528/WebKit/win
2009-02-04 Steve Falkenburg <sfalken@apple.com>
Merge part of r40470.
2009-01-31 Matt Lilek <webkit@mattlilek.com>
Not reviewed, build fixes.
- WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
- 12:48 PM Moving to Git created by
- 12:47 PM WikiStart edited by
- Create a new page to coordinate discussion around possibly moving to Git (diff)
- 11:56 AM Changeset in webkit [40623] by
-
- 2 edits in trunk/WebCore
CrashTracer: [REGRESSION] 53 crashes in Safari at com.apple.WebCore: WebCore::LegacyWebArchive::create + 2706
<rdar://problem/6509514>
Reviewed by Mark Rowe.
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Fix it correctly this time. Check for the value returned from WebCore::IconDatabase::iconForPageURL(), not WebCore::Image::data().
- 11:44 AM Changeset in webkit [40622] by
-
- 7 edits in trunk/WebCore
2009-02-04 David Hyatt <hyatt@apple.com>
Rename removeFromObjectLists and move it into RenderBox, since it only applies to boxes.
Reviewed by Adam Roben
- rendering/RenderBox.cpp: (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists): (WebCore::RenderBox::styleWillChange):
- rendering/RenderBox.h:
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChild):
- rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
- rendering/RenderObject.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::removeChild):
- 11:43 AM Changeset in webkit [40621] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix WebCore/ChangeLog date discrepancy.
- 11:41 AM Changeset in webkit [40620] by
-
- 5 edits4 adds in trunk
WebCore:
2009-02-04 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23471
Fix text-overflow:ellipsis; for RTL case.
Test: fast/css/text-overflow-ellipses.html
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::placeEllipsisBox): Add support for rtl placement. (WebCore::InlineTextBox::paintDecoration): Correctly draw decorations for rtl truncation.
LayoutTests:
2009-02-04 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23471
Fix text-overflow:ellipsis; for RTL case.
Rebaseline LayoutTests/editing/spelling/inline_spelling_markers.html to reflect correct behavior.
- fast/css/text-overflow-ellipses.html: Added.
- platform/mac/editing/spelling/inline_spelling_markers-expected.checksum:
- platform/mac/editing/spelling/inline_spelling_markers-expected.png:
- platform/mac/fast/css/text-overflow-ellipses-expected.checksum: Added.
- platform/mac/fast/css/text-overflow-ellipses-expected.png: Added.
- platform/mac/fast/css/text-overflow-ellipses-expected.txt: Added.
- 11:06 AM Changeset in webkit [40619] by
-
- 2 edits in trunk/WebCore
2009-02-02 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23700
Upstream local changes to due to unforking of SimpleFontData
(corresponds to Chromium check-in http://src.chromium.org/viewvc/chrome?view=rev&revision=8646).
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs): Removed extra checks for ZWS chars.
- 10:25 AM Changeset in webkit [40618] by
-
- 2 edits in trunk/WebCore
2009-02-04 David Hyatt <hyatt@apple.com>
<rdar://problem/6554115> REGRESSION (r40475): World leak (JS global object) after viewing a photo on Facebook
Fix a ginormous leak. (GINORMOUS!) Make sure to disconnect the event listeners attached to the Document,
because, like, they point to a lot of stuff... like ... everything...
Reviewed by Darin Adler
- dom/Document.cpp: (WebCore::Document::removeAllEventListenersFromAllNodes):
- 10:11 AM Changeset in webkit [40617] by
-
- 7 edits in trunk/WebCore
2009-02-04 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23731
Add JSCCustom and V8Custom as extended IDL attributes
This helps avoid having to add #ifdefs to the IDL files to support V8 bindings.
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.idl:
- dom/Node.idl:
- svg/SVGPathSegList.idl:
- svg/SVGPointList.idl:
- svg/SVGTransformList.idl:
- 10:03 AM Changeset in webkit [40616] by
-
- 2 edits in trunk/WebCore
- build fix
- rendering/RenderImageGeneratedContent.h:
- 10:01 AM Changeset in webkit [40615] by
-
- 8 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Switch to using a ref-counted wxFont pointer for FontPlatformData to fix a crash
with assigning to uninitialized HashTable buckets.
https://bugs.webkit.org/show_bug.cgi?id=23669
- 9:39 AM Changeset in webkit [40614] by
-
- 2 edits in trunk/WebCore
2009-02-04 David Hyatt <hyatt@apple.com>
Fix a crash in generated content when a generated image with an already-cached background image gets
created. It's not completely clear how to reproduce this crash.
Reviewed by Adam Roben
- rendering/RenderImageGeneratedContent.h: (WebCore::RenderImageGeneratedContent::imagePtr):
- 7:06 AM QtWebKitTodo edited by
- (diff)
- 6:56 AM Changeset in webkit [40613] by
-
- 2 edits in trunk/WebCore
2009-02-04 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed Qt build fix.
Changed ASSERT(image) to ASSERT(!image.isNull()).
- 6:23 AM Changeset in webkit [40612] by
-
- 2 edits in trunk/WebCore
2009-02-04 Trenton Schulz <trenton.schulz@nokia.com>
Reviewed by Simon Hausmann.
Fix implementation of PluginViewMac::invalidateRect to update only the
specified rect, not the entire browser window.
- 6:04 AM Changeset in webkit [40611] by
-
- 2 edits in trunk/WebCore
2009-02-04 Holger Hans Peter Freyther <zecke@selfish.org>
Rubber stamped by Mark Rowe.
FramePrivate was removed in r40024 remove the forward
declaration as well.
- page/Frame.h:
- 5:37 AM Changeset in webkit [40610] by
-
- 5 edits in trunk/WebCore
Make isFrameSet virtual and by default return false, reimplement it in HTMLDocument.
- 1:34 AM Changeset in webkit [40609] by
-
- 2 edits in trunk/WebKit/qt
2009-02-04 David Boddie <dboddie@trolltech.com>
Reviewed by Simon Hausmann.
Doc: Documented the return value of the evaluateJavaScript() function.
- 12:55 AM Changeset in webkit [40608] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=23681
Worker tests crash in debug builds if run --singly
The crash happened because worker threads continued running while debug-only static objects
were already being destroyed on main thread.
- runtime/Structure.cpp: Create static debug-only sets in heap, so that they don't get destroyed.
- wtf/ThreadingPthreads.cpp: Changed assertions to conventional form.
Feb 3, 2009:
- 10:58 PM WebCoreRendering created by
- 10:55 PM WikiStart edited by
- (diff)
- 9:24 PM Changeset in webkit [40607] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6554092> Slow script dialog starts coming up over and over again
Reviewed by John Sullivan.
Work around <rdar://problem/6554067> by consuming any exceptions that are
thrown by _web_localizedDescription
- 9:06 PM Changeset in webkit [40606] by
-
- 3 edits in trunk/WebCore
2009-02-03 David Hyatt <hyatt@apple.com>
Move the isRenderInline checks for clientWidth/Height and scrollWidth/Height to the DOM element
versions of the functions. Since internal render tree usage doesn't ever (incorrectly) call these
functions on RenderInlines, this manages to get virtual function calls out of contentWidth/Height and
availableWidth/Height.
Reviewed by Mark Rowe
- dom/Element.cpp: (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
- rendering/RenderBox.cpp: (WebCore::RenderBox::clientWidth): (WebCore::RenderBox::clientHeight): (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):
- 8:59 PM Changeset in webkit [40605] by
-
- 4 edits3 adds in trunk
2009-02-03 Brad Garcia <bgarcia@google.com>
Remove call to canResize when trying to determine if pointer
is within a frame.
- 8:26 PM Changeset in webkit [40604] by
-
- 2 edits in trunk/WebCore
2009-02-03 David Hyatt <hyatt@apple.com>
Reduce the number of calls to virtualChildren (indirectly made via RenderObject::firstChild()).
This is a small gain on the PLT.
Reviewed by Mark Rowe
- rendering/bidi.cpp: (WebCore::inlineWidth): (WebCore::bidiNext):
- 8:24 PM Changeset in webkit [40603] by
-
- 1 edit in branches/Safari-6528/WebKit/win/WebHistoryItem.cpp
Merge r40394.
- 8:24 PM Changeset in webkit [40602] by
-
- 2 edits in branches/Safari-6528/WebKit/win
Merge r40392.
- 8:23 PM Changeset in webkit [40601] by
-
- 2 edits in branches/Safari-6528/WebKit/win
Merge r40529.
- 8:23 PM Changeset in webkit [40600] by
-
- 2 edits in branches/Safari-6528/WebKit/win
Merge r40528.
- 8:23 PM Changeset in webkit [40599] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40516.
- 8:23 PM Changeset in webkit [40598] by
-
- 4 edits in branches/Safari-6528
Merge r40514.
- 8:23 PM Changeset in webkit [40597] by
-
- 2 edits in branches/Safari-6528/WebKit/win
Merge r40511.
- 8:23 PM Changeset in webkit [40596] by
-
- 37 edits in branches/Safari-6528
Merge r40508.
- 8:23 PM Changeset in webkit [40595] by
-
- 7 edits in branches/Safari-6528/WebKit/win
Merge r40503.
- 8:23 PM Changeset in webkit [40594] by
-
- 7 edits in branches/Safari-6528/WebKit
Merge r40382.
- 8:23 PM Changeset in webkit [40593] by
-
- 10 edits in branches/Safari-6528
Merge r40380.
- 8:23 PM Changeset in webkit [40592] by
-
- 9 edits in branches/Safari-6528/WebKit
Merge r40436.
- 8:23 PM Changeset in webkit [40591] by
-
- 16 edits in branches/Safari-6528
Merge r40432.
- 8:23 PM Changeset in webkit [40590] by
-
- 10 edits55 adds in branches/Safari-6528
Merge r40424.
- 8:22 PM Changeset in webkit [40589] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40376.
- 8:22 PM Changeset in webkit [40588] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40373.
- 8:22 PM Changeset in webkit [40587] by
-
- 9 edits in branches/Safari-6528
Merge r40353.
- 8:22 PM Changeset in webkit [40586] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40558.
- 8:22 PM Changeset in webkit [40585] by
-
- 3 edits3 adds in branches/Safari-6528
Merge r40541.
- 8:22 PM Changeset in webkit [40584] by
-
- 3 edits3 adds in branches/Safari-6528
Merge r40522.
- 8:22 PM Changeset in webkit [40583] by
-
- 5 edits in branches/Safari-6528/WebCore
Merge r40472.
- 8:22 PM Changeset in webkit [40582] by
-
- 2 edits in branches/Safari-6528/WebKitLibraries
Merge r40448.
- 8:22 PM Changeset in webkit [40581] by
-
- 6 edits in branches/Safari-6528
Merge r40397.
- 8:22 PM Changeset in webkit [40580] by
-
- 2 edits in branches/Safari-6528/JavaScriptCore
Merge r40396.
- 8:22 PM Changeset in webkit [40579] by
-
- 5 edits2 copies5 adds in branches/Safari-6528
Merge r40368.
- 8:22 PM Changeset in webkit [40578] by
-
- 11 edits in branches/Safari-6528
Merge r40366.
- 8:21 PM Changeset in webkit [40577] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40358.
- 8:21 PM Changeset in webkit [40576] by
-
- 3 edits7 adds in branches/Safari-6528
Merge r40356.
- 8:21 PM Changeset in webkit [40575] by
-
- 6 edits1 copy2 adds in branches/Safari-6528
Merge r40355.
- 8:21 PM Changeset in webkit [40574] by
-
- 24 edits in branches/Safari-6528
Merge r40354.
- 8:21 PM Changeset in webkit [40573] by
-
- 4 edits in branches/Safari-6528
Merge r40345.
- 8:21 PM Changeset in webkit [40572] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40343.
- 8:21 PM Changeset in webkit [40571] by
-
- 2 edits in branches/Safari-6528/JavaScriptCore
Merge r40339.
- 8:21 PM Changeset in webkit [40570] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40335.
- 8:21 PM Changeset in webkit [40569] by
-
- 13 edits3 adds in branches/Safari-6528
Merge r40332.
- 8:21 PM Changeset in webkit [40568] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40313.
- 8:21 PM Changeset in webkit [40567] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40305.
- 8:20 PM Changeset in webkit [40566] by
-
- 2 edits in branches/Safari-6528/WebCore
Merge r40304.
- 6:45 PM Changeset in webkit [40565] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix typo in Changelog
- 6:41 PM Changeset in webkit [40564] by
-
- 19 edits1 add in trunk/WebCore
2009-02-03 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Fix selection repainting to do container-relative repaints. RenderView now
repaints the seleciton using the containerForRepaint() for each RenderSelectionInfo.
selectionRect() is now a wrapper for selectionRectForRepaint() with no container.
Pull SelectionInfo out of RenderObject.h, and BlockSelectionInfo out
of RenderBlock.h and move them into RenderSelectionInfo.h, with some
sharing and refactoring.
RenderBlock::selectionGapRectsForRepaint() is not yet container-aware.
- 6:06 PM Changeset in webkit [40563] by
-
- 3 edits in trunk/WebCore
2009-02-03 David Hyatt <hyatt@apple.com>
Add inline capacity back to CSSMutableStyleDeclaration now that the bug in Vector has been fixed.
Reviewed by Darin Adler & Sam Weinig
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- css/CSSMutableStyleDeclaration.h:
- 6:02 PM Changeset in webkit [40562] by
-
- 10 edits in trunk/JavaScriptCore
2009-02-03 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Simplify MacroAssembler interface, by combining comparison methods.
Seprate operations are combined as follows:
jz32/jnz32/jzPtr/jnzPtr -> branchTest32/branchTestPtr,
j*(Add|Mul|Sub)32/j*(Add|Mul|Sub)Ptr -> branch(Add|Mul|Sub)32/branch(Add|Mul|Sub)Ptr
j*32/j*Ptr (all other two op combparisons) -> branch32/brnachPtr
set*32 -> set32
Also, represent the Scale of BaseIndex addresses as a plain enum (0,1,2,3),
instead of as multiplicands (1,2,4,8).
This patch singificantly reduces replication of code, and increases functionality supported
by the MacroAssembler. No performance impact.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::): (JSC::MacroAssembler::branchPtr): (JSC::MacroAssembler::branchPtrWithPatch): (JSC::MacroAssembler::branch32): (JSC::MacroAssembler::branch16): (JSC::MacroAssembler::branchTestPtr): (JSC::MacroAssembler::branchTest32): (JSC::MacroAssembler::branchAddPtr): (JSC::MacroAssembler::branchAdd32): (JSC::MacroAssembler::branchMul32): (JSC::MacroAssembler::branchSubPtr): (JSC::MacroAssembler::branchSub32): (JSC::MacroAssembler::set32): (JSC::MacroAssembler::setTest32):
- assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::jccRel32): (JSC::X86Assembler::setccOpcode): (JSC::X86Assembler::cmpq_mr): (JSC::X86Assembler::setcc_r): (JSC::X86Assembler::sete_r): (JSC::X86Assembler::setne_r): (JSC::X86Assembler::jne): (JSC::X86Assembler::je): (JSC::X86Assembler::jl): (JSC::X86Assembler::jb): (JSC::X86Assembler::jle): (JSC::X86Assembler::jbe): (JSC::X86Assembler::jge): (JSC::X86Assembler::jg): (JSC::X86Assembler::ja): (JSC::X86Assembler::jae): (JSC::X86Assembler::jo): (JSC::X86Assembler::jp): (JSC::X86Assembler::js): (JSC::X86Assembler::jcc): (JSC::X86Assembler::X86InstructionFormatter::putModRmSib):
- jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::emitSlowScriptCheck): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_lshift): (JSC::JIT::compileFastArith_op_mod): (JSC::JIT::compileFastArith_op_post_inc): (JSC::JIT::compileFastArith_op_post_dec): (JSC::JIT::compileFastArith_op_pre_inc): (JSC::JIT::compileFastArith_op_pre_dec): (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArith_op_mul):
- jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
- jit/JITInlineMethods.h: (JSC::JIT::checkStructure): (JSC::JIT::emitJumpIfJSCell): (JSC::JIT::emitJumpIfNotJSCell): (JSC::JIT::emitJumpIfImmediateNumber): (JSC::JIT::emitJumpIfNotImmediateNumber): (JSC::JIT::emitJumpIfImmediateInteger): (JSC::JIT::emitJumpIfNotImmediateInteger): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- runtime/RegExp.cpp: (JSC::RegExp::match):
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateIncrementIndex): (JSC::WREC::Generator::generateLoadCharacter): (JSC::WREC::Generator::generateJumpIfNotEndOfInput): (JSC::WREC::Generator::generateBackreferenceQuantifier): (JSC::WREC::Generator::generateNonGreedyQuantifier): (JSC::WREC::Generator::generateGreedyQuantifier): (JSC::WREC::Generator::generatePatternCharacterPair): (JSC::WREC::Generator::generatePatternCharacter): (JSC::WREC::Generator::generateCharacterClassInvertedRange): (JSC::WREC::Generator::generateCharacterClassInverted): (JSC::WREC::Generator::generateAssertionBOL): (JSC::WREC::Generator::generateAssertionEOL): (JSC::WREC::Generator::generateAssertionWordBoundary): (JSC::WREC::Generator::generateBackreference):
- 5:52 PM Changeset in webkit [40561] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-03 David Hyatt <hyatt@apple.com>
Fix a bug in Vector's shrinkCapacity method. It did not properly copy elements into the inline buffer
when shrinking down from a size that was greater than the inline capacity.
Reviewed by Maciej
- wtf/Vector.h: (WTF::VectorBuffer::VectorBuffer): (WTF::VectorBuffer::allocateBuffer):
- 5:18 PM Changeset in webkit [40560] by
-
- 6 edits2 adds in trunk
WebCore:
2009-02-03 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=13490
Implement execCommand("styleWithCSS", ...)
Determine whether or not to use HTML formatting tags for styling on the new
boolean on Editor instead of whether or not the document is quirks mode.
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::StyleChange): (WebCore::StyleChange::init): (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::applyTextDecorationStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- editing/Editor.cpp: (WebCore::Editor::Editor): (WebCore::Editor::clear):
- editing/Editor.h: (WebCore::Editor::setShouldStyleWithCSS): (WebCore::Editor::shouldStyleWithCSS):
- editing/EditorCommand.cpp: (WebCore::executeStyleWithCSS): (WebCore::stateStyleWithCSS): (WebCore::CommandEntry::):
LayoutTests:
2009-02-03 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=13490
Implement execCommand("styleWithCSS", ...)
- editing/execCommand/5685604-1-expected.txt: Added.
- editing/execCommand/5685604-1.html: Added.
- 5:05 PM Changeset in webkit [40559] by
-
- 2 edits in trunk/WebCore
2009-02-03 Dirk Schulze <krit@webkit.org>
Reviewed by Sam Weinig.
This is a follow up of r40546. Call toImage() once speeds up ImageBuffer::getImageData()
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::getImageData):
- 4:55 PM Changeset in webkit [40558] by
-
- 2 edits in trunk/WebCore
2009-02-03 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
- Fix for <rdar://problem/6549743>
On Tiger, create an autorelease pool before creating the NSGraphicsContext and drain it immediately
after the call to -[NSView displayRectIgnoringOpacity:inContext:].
- platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
- 4:46 PM Changeset in webkit [40557] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
ChangeLog date fix.
- 4:39 PM Changeset in webkit [40556] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Darin Adler.
Change the way wxWidgets build gets arguments.
Change "checkForArgumentAndRemoveFromARGV" in build-webkit to check if the
argument passed matches one in ARGV exactly (allows, ie, --wx-args not to be
removed when --wx is checked for).
- 4:31 PM Changeset in webkit [40555] by
-
- 3 edits in trunk/WebCore
2009-02-03 David Hyatt <hyatt@apple.com>
Back this change out since it is causing layout tests to crash. There is something subtle going on
here.
Reviewed by Darin Adler
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- css/CSSMutableStyleDeclaration.h:
- 3:57 PM Changeset in webkit [40554] by
-
- 3 edits in trunk/WebCore
2009-02-03 David Hyatt <hyatt@apple.com>
Give the properties vector of mutable style declarations an initial inline capacity to reduce malloc churn.
Reviewed by Sam Weinig
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- css/CSSMutableStyleDeclaration.h:
- 3:56 PM Changeset in webkit [40553] by
-
- 5 edits in trunk/WebCore
2009-02-03 David Hyatt <hyatt@apple.com>
Avoid creating extra copies of NSURLRequests for non-HTTP URLs. Only mark platform requests
as needing updating when HTTP fields change if the scheme of the URL is actually HTTP or HTTPS.
Thus cuts down significantly on the number of copied NSURLRequests and is about a 1% gain on the PLT.
Reviewed by Darin Adler
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
- platform/KURL.cpp: (WebCore::KURL::invalidate): (WebCore::KURL::KURL):
- platform/KURL.h: (WebCore::KURL::isHTTPOrHTTPS):
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setCachePolicy): (WebCore::ResourceRequestBase::setTimeoutInterval): (WebCore::ResourceRequestBase::setMainDocumentURL): (WebCore::ResourceRequestBase::setHTTPMethod): (WebCore::ResourceRequestBase::setHTTPHeaderField): (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray): (WebCore::ResourceRequestBase::setHTTPBody): (WebCore::ResourceRequestBase::setAllowHTTPCookies):
- 3:53 PM Changeset in webkit [40552] by
-
- 3 edits in trunk/LayoutTests
Commit test cases for https://bugs.webkit.org/show_bug.cgi?id=23178.
- 3:25 PM Changeset in webkit [40551] by
-
- 1 edit2 adds in trunk/WebCore
2009-02-03 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
Add manual test for floating divs with scrollbars.
- manual-tests/gtk/floatingdiv.html: Added.
- 3:25 PM Changeset in webkit [40550] by
-
- 3 edits in trunk/WebCore
2009-02-03 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
There's no need to hold an extra ref to the scrollbar, calling
setPlatformWidget takes ownership of it.
Also do not disconnect the signals when destroying the widget,
it's superfluous.
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::ScrollbarGtk):
- 3:25 PM Changeset in webkit [40549] by
-
- 2 edits in trunk/WebCore
2009-02-03 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
Declare scrollBar as GtkWidget* to avoid needless
casting.
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::ScrollbarGtk): (ScrollbarGtk::~ScrollbarGtk):
- 3:25 PM Changeset in webkit [40548] by
-
- 2 edits in trunk/WebCore
2009-02-03 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
Properly calculate the scrollbar location for their
usage in RenderLayout.
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::frameRectsChanged):
- 2:14 PM Changeset in webkit [40547] by
-
- 10 edits in trunk/WebCore
2009-02-03 David Hyatt <hyatt@apple.com>
Rename addLineBoxRects to absoluteRectsForRange, and do the same thing for the corresponding quads methods. Move the RenderContainer implementations
of these methods up to RenderObject.
Reviewed by Beth Dakin
- bindings/objc/DOM.mm: (-[DOMNode lineBoxRects]):
- dom/Range.cpp: (WebCore::Range::addLineBoxRects):
- inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight):
- rendering/RenderContainer.cpp:
- rendering/RenderContainer.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRectsForRange): (WebCore::RenderObject::absoluteQuadsForRange):
- rendering/RenderObject.h:
- rendering/RenderText.cpp: (WebCore::RenderText::absoluteRectsForRange): (WebCore::RenderText::absoluteQuadsForRange):
- rendering/RenderText.h:
- 1:26 PM Changeset in webkit [40546] by
-
- 2 edits in trunk/WebCore
2009-02-03 Dirk Schulze <krit@webkit.org>
Reviewed by Sam Weinig and Oliver Hunt.
Added getImageData() support for QtWebKit.
[QT] lacks getImageData / putImageData support in Canvas
https://bugs.webkit.org/show_bug.cgi?id=22186
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::getImageData):
- 1:00 PM Changeset in webkit [40545] by
-
- 2 edits in trunk/WebCore
2009-02-03 Eric Roman <eroman@chromium.org>
Reviewed by Holger Freyther.
Fix FrameChromium.cpp following r40473 which moved Frame::adjustPageHeight to FrameView::adjustPageHeight.
- page/chromium/FrameChromium.cpp: (WebCore::computePageRectsForFrame):
- 12:43 PM Changeset in webkit [40544] by
-
- 3 edits in trunk/WebCore
2009-02-02 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Hook accelerated compositing into RenderLayer.
- 12:14 PM Changeset in webkit [40543] by
-
- 19 edits in trunk
2009-02-03 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Hook up accelerated compositing layers the native
view system on Mac.
- 11:51 AM Changeset in webkit [40542] by
-
- 2 edits in trunk/WebCore
2009-02-03 Dirk Schulze <krit@webkit.org>
Reviewed by Holger Hans Peter Freyther.
Fixed getImageData and putImageData and respect pre-
multiplied colors.
Cairo's ImageBuffer::getImageData() does not handle alpha=0 case correctly
https://bugs.webkit.org/show_bug.cgi?id=21575
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData):
- 11:49 AM Changeset in webkit [40541] by
-
- 3 edits3 adds in trunk
WebCore:
Reviewed by Brady Eidson.
- fix <rdar://problem/6550530> REGRESSION (r40508): Window opened with window.open has no initial history item (global and back/forward)
Test: fast/history/window-open.html
- bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): Pass the missing lockBackForwardList parameter to FrameLoader::changeLocation().
LayoutTests:
Reviewed by Brady Eidson.
- test for <rdar://problem/6550530> REGRESSION (r40508): Window opened with window.open has no initial history item (global and back/forward)
- fast/history/window-open-expected.txt: Added.
- fast/history/window-open.html: Added.
- 11:40 AM Changeset in webkit [40540] by
-
- 4 edits in trunk/WebKit/gtk
2009-02-03 Hiroyuki Ikezoe <poincare@ikezoe.net>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=22988
[GTK] Need a public method to add a WebKitWebHistoryItem to
WebKitWebBackForwardList.
Wrap WebCore::BackForwardList::addItem.
- tests/main.c: (test_webkit_web_back_forward_list_add_item): (main):
- webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_add_item):
- webkit/webkitwebbackforwardlist.h:
- 9:46 AM Changeset in webkit [40539] by
-
- 2 edits in trunk/WebCore
2009-02-03 Adam Treat <adam.treat@torchmobile.com>
Fix the Qt build after r40536.
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue):
- 9:41 AM Changeset in webkit [40538] by
-
- 2 edits in trunk/WebCore
- fix -Wmissing-prototypes builds
- loader/WorkerThreadableLoader.cpp: (WebCore::workerContextDidSendData): Marked this function static. (WebCore::workerContextDidReceiveResponse): Ditto. (WebCore::workerContextDidReceiveData): Ditto. (WebCore::workerContextDidFinishLoading): Ditto. (WebCore::workerContextDidFail): Ditto. (WebCore::workerContextDidGetCancelled): Ditto. (WebCore::workerContextDidReceiveAuthenticationCancellation): Ditto.
- 9:29 AM Changeset in webkit [40537] by
-
- 2 edits in trunk/WebCore
CrashTracer: [REGRESSION] 53 crashes in Safari at com.apple.WebCore: WebCore::LegacyWebArchive::create + 2706
<rdar://problem/6509514>
Reviewed by Adam Roben.
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Null check the value returned from WebCore::IconDatabase::iconForPageURL().
- 8:10 AM Changeset in webkit [40536] by
-
- 6 edits in trunk
2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Added accessor for JSByteArray storage.
WebCore:
2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Fix conversion of QByteArray to JavaScript and back. Instead of
converting it to a String (data loss!) we now map it to JSByteArray.
WebKit/qt:
2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Added a unit test to verify the succesful conversion from QByteArray to
JSByteArray and back to QByteArray.
- 7:44 AM Changeset in webkit [40535] by
-
- 2 edits in trunk/WebCore
Build fix.
- GNUmakefile.am: Removed WorkerTask.{h,cpp}.
- 2:32 AM Changeset in webkit [40534] by
-
- 11 edits3 adds in trunk
2009-02-03 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22718
Implement WindowTimers interface in Workers.
This patch moves timeoutID from Document to ScriptExecutionContext
and exposes JS methods setTimeout/setInterval/clearTimeout/clearInterval inside of a Worker.
Also added a test for those methods.
Test: fast/workers/worker-timeout.html
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::setTimeoutOrInterval): Creates ScheduledAction and calls WorkerContext::installTimeout to actually add a timer.
(WebCore::JSWorkerContext::setTimeout):
(WebCore::JSWorkerContext::clearTimeout):
(WebCore::JSWorkerContext::setInterval):
(WebCore::JSWorkerContext::clearInterval):
Added methods exposed to JS.
- dom/Document.cpp:
- dom/Document.h:
- dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::addTimeout): (WebCore::ScriptExecutionContext::removeTimeout): (WebCore::ScriptExecutionContext::findTimeout):
- dom/ScriptExecutionContext.h: The timerID map moves from Document to ScriptExecutionContext, to be available to Document and to WorkerContext.
- dom/WorkerContext.cpp: (WebCore::WorkerContext::installTimeout): Adds a DOMTimeout. (WebCore::WorkerContext::removeTimeout): Removes a DOMTimeout.
- dom/WorkerContext.h:
- page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::~DOMTimer): (WebCore::DOMTimer::removeById): Code change here reflects move of timeoutID map to the ScriptExecutionContext. Some checks and casts are no longer needed.
- 1:18 AM Changeset in webkit [40533] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-03 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=23560
Implement SharedTimer on WorkerRunLoop
- JavaScriptCore.exp: Forgot to expose ThreadCondition::timedWait() in one of previous patches.
- 1:11 AM Changeset in webkit [40532] by
-
- 3 edits in trunk/WebCore
2009-02-03 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=23560
Implement SharedTimer for Workers.
- dom/WorkerRunLoop.cpp: Added private class WorkerSharedTimer that implements SharedTimer interface for worker threads. (WebCore::WorkerSharedTimer::WorkerSharedTimer): (WebCore::WorkerSharedTimer::setFiredFunction): (WebCore::WorkerSharedTimer::setFireTime): (WebCore::WorkerSharedTimer::stop): (WebCore::WorkerSharedTimer::isActive): (WebCore::WorkerSharedTimer::fireTime): (WebCore::WorkerSharedTimer::fire): (WebCore::WorkerRunLoop::WorkerRunLoop): Initializes a WorkerSharedTimer instance. (WebCore::WorkerRunLoop::~WorkerRunLoop): The destructor is here so compiler is ok with having OwnPtr<WorkerSharedTimer> in .h file w/o defining WorkerSharedTimer. (WebCore::WorkerRunLoop::run): Set/reset shared timer interface on ThreadTimers, use MessageQueue::waitForMessageTimed() if timer is active.
- dom/WorkerRunLoop.h: Add member of type OwnPtr<WorkerSharedTimer>
- 12:57 AM Changeset in webkit [40531] by
-
- 2 edits in trunk/WebCore
2009-02-03 Steve Falkenburg <sfalken@apple.com>
Build fix.
- WebCore.vcproj/WebCore.vcproj:
- 12:24 AM Changeset in webkit [40530] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- dom/CrossThreadCopier.h: Changed forward declarations to use struct instead of class where appropriate.
- 12:05 AM Changeset in webkit [40529] by
-
- 2 edits in trunk/WebKit/win
2009-02-03 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebHistory.cpp: (WebHistory::visitedURL):
Feb 2, 2009:
- 11:57 PM Changeset in webkit [40528] by
-
- 2 edits in trunk/WebKit/win
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebHistory.cpp: (WebHistory::visitedURL):
- 11:41 PM Changeset in webkit [40527] by
-
- 15 edits3 adds in trunk/WebCore
Reviewed by Alexey Proskuryakov.
Part 2 of
Bug 23636: Make the async api of ThreadableLoader functional for the worker context.
<https://bugs.webkit.org/show_bug.cgi?id=23636>
Enable the async portion of ThreadableLoader for workers.
No observable change in behavior, so no test.
- 11:38 PM Changeset in webkit [40526] by
-
- 12 edits2 deletes in trunk/WebCore
2009-02-02 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 23636: Make the async api of ThreadableLoader functional for the worker context.
<https://bugs.webkit.org/show_bug.cgi?id=23636>
No observable change in behavior, so no test.
- WebCore.xcodeproj/project.pbxproj:
- dom/Worker.cpp:
- dom/Worker.h:
- dom/WorkerContext.cpp: (WebCore::WorkerContext::addMessage): (WebCore::WorkerContext::postTask): (WebCore::WorkerContext::postTaskToWorkerObject):
- dom/WorkerContext.h:
- dom/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): (WebCore::WorkerMessagingProxy::postTaskToWorkerContext): Expose postTaskToWorkerContext for use by the worker object thread.
(WebCore::WorkerMessagingProxy::postTaskToWorkerObject):
Change the name of postTaskToParentContext to postTaskToWorkerObject for consistency
with postMessageToWorkerObject.
- dom/WorkerMessagingProxy.h:
- dom/WorkerRunLoop.cpp: (WebCore::WorkerRunLoop::run): (WebCore::WorkerRunLoop::postTask):
- dom/WorkerRunLoop.h:
- dom/WorkerTask.cpp: Removed.
- dom/WorkerTask.h: Removed. Removed WorkerTask and replaced with the existing ScriptExecutionContext::Task.
The resulted in the class going away along with an adapter that made
a ScriptExecutionContext::Task look like a WorkerTask.
- dom/WorkerThread.cpp:
- dom/WorkerThread.h:
- 11:36 PM Changeset in webkit [40525] by
-
- 10 edits2 adds in trunk/WebCore
2009-02-02 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 23618: Templated worker tasks should be more error proof to use.
<https://bugs.webkit.org/show_bug.cgi?id=23618>
Add the generic worker tasks templates needed for the WorkerThreadableLoader.
No observable change in behavior, so no test.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- dom/CrossThreadCopier.cpp: Added.
- dom/CrossThreadCopier.h: Added. (WebCore::CrossThreadCopierPassThrough::copy):
- dom/GenericWorkerTask.h: Stop doing the WorkerMessagingProxy::askedToTerminate call automatically in performTask because was not obvious that it would be done and not always needed.
(WebCore::GenericWorkerTask1::create):
(WebCore::GenericWorkerTask1::GenericWorkerTask1):
(WebCore::GenericWorkerTask1::performTask):
(WebCore::GenericWorkerTask2::create):
(WebCore::GenericWorkerTask2::GenericWorkerTask2):
(WebCore::GenericWorkerTask2::performTask):
(WebCore::GenericWorkerTask3::create):
(WebCore::GenericWorkerTask3::GenericWorkerTask3):
(WebCore::GenericWorkerTask3::performTask):
(WebCore::GenericWorkerTask4::create):
(WebCore::GenericWorkerTask4::GenericWorkerTask4):
(WebCore::GenericWorkerTask4::performTask):
(WebCore::GenericWorkerTask5::create):
(WebCore::GenericWorkerTask5::GenericWorkerTask5):
(WebCore::GenericWorkerTask5::performTask):
(WebCore::GenericWorkerTask6::create):
(WebCore::GenericWorkerTask6::GenericWorkerTask6):
(WebCore::GenericWorkerTask6::performTask):
(WebCore::GenericWorkerTask7::create):
(WebCore::GenericWorkerTask7::GenericWorkerTask7):
(WebCore::GenericWorkerTask7::performTask):
(WebCore::createCallbackTask):
- dom/WorkerContext.cpp: (WebCore::addMessageTask): (WebCore::WorkerContext::addMessage):
- dom/WorkerMessagingProxy.h: (WebCore::WorkerMessagingProxy::askedToTerminate):
- 10:45 PM Changeset in webkit [40524] by
-
- 15 edits in trunk/WebCore
2009-02-02 Sam Weinig <sam@webkit.org>
Reviewed by David "The Barnabas Jones" Hyatt.
Move removeChildNode, appendChildNode and insertChildNode from
RenderContainer into RenderObjectChildList. Make moveChildNode
static in RenderBlock, as that was the only user.
- rendering/RenderBlock.cpp: (WebCore::moveChild): (WebCore::RenderBlock::makeChildrenNonInline): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::handleRunInChild):
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): (WebCore::RenderContainer::removeChild):
- rendering/RenderContainer.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::childBecameNonInline):
- rendering/RenderObject.cpp: (WebCore::RenderObject::handleDynamicFloatPositionChange):
- rendering/RenderObject.h: (WebCore::RenderObject::createsAnonymousWrapper):
- rendering/RenderObjectChildList.cpp: (WebCore::updateListMarkerNumbers): (WebCore::RenderObjectChildList::removeChildNode): (WebCore::RenderObjectChildList::appendChildNode): (WebCore::RenderObjectChildList::insertChildNode):
- rendering/RenderObjectChildList.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::addChild): (WebCore::RenderSVGContainer::removeChild):
- rendering/RenderSVGContainer.h:
- rendering/RenderTable.cpp: (WebCore::RenderTable::removeChild):
- rendering/RenderTable.h:
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::removeChild):
- rendering/RenderTableSection.h:
- 10:39 PM Changeset in webkit [40523] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Alder.
https://bugs.webkit.org/show_bug.cgi?id=23697
Leaks seen on Worker tests
- dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): Zero out m_workerThread, so that the proxy could be deleted once workerObjectDestroyed() is called.
- 10:08 PM Changeset in webkit [40522] by
-
- 3 edits3 adds in trunk
<https://bugs.webkit.org/show_bug.cgi?id=21414> REGRESSION: Regular Expressions and character classes, shorthands and ranges
<rdar://problem/6543487>
Reviewed by Gavin Barraclough.
In certain circumstances when WREC::Generator::generateCharacterClassInvertedRange invokes
itself recursively, it will incorrectly emit (and thus consume) the next single character
match in the current character class. As WREC uses a binary search this out of sequence
codegen could result in a character match being missed and so cause the regex to produce
incorrect results.
- 9:26 PM Changeset in webkit [40521] by
-
- 5 edits in trunk/WebCore
2009-02-02 David Hyatt <hyatt@apple.com>
Move positionForCoordinates up from RenderContainer into RenderBox.
Reviewed by Sam Weinig
- rendering/RenderBox.cpp: (WebCore::RenderBox::positionForCoordinates):
- rendering/RenderBox.h:
- rendering/RenderContainer.cpp:
- rendering/RenderContainer.h:
- 8:47 PM Changeset in webkit [40520] by
-
- 4 edits in trunk
Incorrect handling of findstr results in *.vcproj.
Fixes https://bugs.webkit.org/show_bug.cgi?id=15813
- 8:46 PM Changeset in webkit [40519] by
-
- 3 edits in trunk/WebKit/wx
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::updateGlobalHistoryForRedirectWithoutHistoryItem): (WebCore::FrameLoaderClientWx::createPlugin): (WebCore::FrameLoaderClientWx::createJavaAppletWidget):
- WebKitSupport/FrameLoaderClientWx.h:
- 8:33 PM Changeset in webkit [40518] by
-
- 13 edits in trunk/WebCore
2009-02-02 David Hyatt <hyatt@apple.com>
Refactor the handling of before/after content and generated content. Move most of the functions from
RenderContainer into RenderObjectChildList.
Reviewed by Sam Weinig
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateBeforeAfterContent):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::isAfterContent):
- rendering/RenderBox.h:
- rendering/RenderButton.cpp: (WebCore::RenderButton::updateBeforeAfterContent):
- rendering/RenderContainer.cpp:
- rendering/RenderContainer.h:
- rendering/RenderCounter.cpp: (WebCore::destroyCounterNodeChildren):
- rendering/RenderInline.cpp: (WebCore::RenderInline::styleDidChange): (WebCore::RenderInline::addChildIgnoringContinuation): (WebCore::RenderInline::splitInlines):
- rendering/RenderObject.h:
- rendering/RenderObjectChildList.cpp: (WebCore::beforeAfterContainer): (WebCore::findBeforeAfterParent): (WebCore::invalidateCountersInContainer): (WebCore::RenderObjectChildList::invalidateCounters): (WebCore::RenderObjectChildList::updateBeforeAfterContent):
- rendering/RenderObjectChildList.h:
- 8:23 PM Changeset in webkit [40517] by
-
- 3 edits in trunk/WebCore
2009-02-02 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23661
Fix Chromium build.
- history/HistoryItem.h: need to include <wtf/OwnPtr.h>
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::adjustMenuListStyle): isEnabled() is now on FormControlElement.
- 7:08 PM Changeset in webkit [40516] by
-
- 2 edits in trunk/WebCore
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- plugins/PluginView.cpp: (WebCore::PluginView::performRequest):
- 7:06 PM Changeset in webkit [40515] by
-
- 4 edits in trunk/WebKit
WebKit/qt:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- Api/qwebframe.cpp: (QWebFrame::QWebFrame): (QWebFrame::load): (QWebFrame::setHtml): (QWebFrame::setContent):
WebKit/wx:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebFrame.cpp: (wxWebFrame::LoadURL):
- 7:03 PM Changeset in webkit [40514] by
-
- 4 edits in trunk
WebCore:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebCore.base.exp:
WebKit/mac:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
- 6:56 PM Changeset in webkit [40513] by
-
- 2 edits in trunk/WebKit/gtk
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- webkit/webkitwebview.cpp:
- 6:54 PM Changeset in webkit [40512] by
-
- 2 edits in trunk/WebKit/gtk
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- webkit/webkitwebframe.cpp:
- 6:52 PM Changeset in webkit [40511] by
-
- 2 edits in trunk/WebKit/win
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::loadURLIntoChild):
- 6:52 PM Changeset in webkit [40510] by
-
- 2 edits in trunk/WebKit/qt
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):
- 6:49 PM Changeset in webkit [40509] by
-
- 2 edits in trunk/WebKit/gtk
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):
- 6:31 PM Changeset in webkit [40508] by
-
- 37 edits in trunk
WebCore:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Track redirects in global history.
- WebCore.base.exp: Renamed some exports.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): (windowProtoFuncOpen):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
- bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::submit):
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::assign): Treat any navigation that is not initiated by the user as a redirect from the perspective of global history.
- history/HistoryItem.cpp: (WebCore::HistoryItem::addRedirectURL): Store the last URL in the redirect chain.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader):
- loader/DocumentLoader.h: (WebCore::DocumentLoader::urlForHistoryReflectsServerRedirect): (WebCore::DocumentLoader::urlForHistoryReflectsClientRedirect): (WebCore::DocumentLoader::setURLForHistoryReflectsClientRedirect): Sadly, added yet another way to track redirect state during loading, since none of the others did what I wanted, and I didn't want to cause behavior changes in existing code.
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Stubbed out a client function to keep things building.
- loader/FrameLoader.cpp: (WebCore::isBackForwardLoadType): (WebCore::FrameLoader::restoreDocumentState): Renamed FrameLoadTypeRedirect => FrameLoadTypeRedirectWithLockedBackForwardList, to distinguish from all the other meanings of "redirect" in the loading code.
(WebCore::FrameLoader::scheduleHTTPRedirection): Treat any HTTP refresh
redirect as a redirect from the perspective of global history.
(WebCore::FrameLoader::loadURLIntoChildFrame): Updated for rename and extra
parameter.
(WebCore::FrameLoader::startRedirectionTimer): Removed unused parameter.
(WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load): Updated for rename and extra parameter.
(WebCore::FrameLoader::loadWithNavigationAction): Track redirect status
in the DocumentLoader, so it's accessible to WebKit's global history code.
(WebCore::FrameLoader::clientRedirected): Ignore lockHistory, since it
only has meaning to global history, and m_quickRedirectComing pertains
to other kinds of history.
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::loadEmptyDocumentSynchronously):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::loadItem): Updated for extra parameter and rename.
(WebCore::FrameLoader::updateHistory*): Notify WebKit about redirect
navigations even if they don't create new history items, so we can track
the redirect in the existing history item.
- loader/FrameLoader.h: See above.
- loader/FrameLoaderClient.h: New client interface used by FrameLoader::updateHistory* to record a redirect even if it doesn't create a new history item of its own.
- loader/FrameLoaderTypes.h: See above. (WebCore::):
- page/DragController.cpp: (WebCore::DragController::performDrag):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Updated for extra parameter.
WebKit/gtk:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Track redirects in global history.
Keep GTK building.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame): (WebKit::FrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/mac:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Track redirects in global history.
- History/WebHistory.mm: (-[WebHistoryPrivate dealloc]): (-[WebHistoryPrivate lastVisitedEntry]): (-[WebHistoryPrivate setLastVisitedEntry:]): Remember the last global history entry in case we're asked to add redirect information to it later.
(-[WebHistory _visitedURL:withTitle:method:wasFailure:serverRedirectURL:isClientRedirect:]):
(-[WebHistory _visitedURLForRedirectWithoutHistoryItem:]): Record redirect
information in global history.
- History/WebHistoryInternal.h:
- WebCoreSupport/WebFrameLoaderClient.h: See above and below.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Record redirect information in global history.
- WebView/WebFrame.mm: (-[WebFrame loadRequest:]): (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
- WebView/WebFramePrivate.h: Updated for rename and extra parameter.
WebKit/qt:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Track redirects in global history.
Keep Qt building.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistoryForRedirectWithoutHistoryItem): (WebCore::FrameLoaderClientQt::createFrame):
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
2009-02-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Track redirects in global history.
- Interfaces/IWebFramePrivate.idl: Updated for WebCore rename.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Store redirect information in global history.
(WebFrameLoaderClient::loadURLIntoChild): Updated for extra parameter.
- WebCoreSupport/WebFrameLoaderClient.h: See above.
- WebFrame.cpp: (WebFrame::loadRequest): (WebFrame::loadData): Updated for extra parameter.
- WebHistory.cpp: (WebHistory::visitedURL): (WebHistory::visitedURLForRedirectWithoutHistoryItem): Store redirect information in global history.
- WebHistory.h: See above.
- 5:35 PM Changeset in webkit [40507] by
-
- 5 edits in trunk/WebKit/mac
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Work around a limitation in MIG where two functions can't have the same name even if they're
not in the same subsystem.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs:
- 5:21 PM Changeset in webkit [40506] by
-
- 4 edits in trunk/WebCore
2009-02-02 David Hyatt <hyatt@apple.com>
Make calcPrefWidths non-abstract on RenderBox and just give it RenderContainer's implementation.
Remove RenderSVGContainer's implementation, since it was never called.
Reviewed by Beth Dakin
- rendering/RenderBox.cpp: (WebCore::RenderBox::minPrefWidth):
- rendering/RenderBox.h: (WebCore::RenderBox::calcPrefWidths):
- rendering/RenderContainer.h: (WebCore::RenderContainer::moveChildNode):
- rendering/RenderSVGContainer.h:
- 4:59 PM Changeset in webkit [40505] by
-
- 11 edits in trunk
WebCore:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add jsObjectForPluginElement to ScriptController, and have createScriptObjectForPluginElement call it.
- WebCore.LP64.exp:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::createScriptObjectForPluginElement): (WebCore::ScriptController::jsObjectForPluginElement):
- bindings/js/ScriptController.h:
WebKit/mac:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Implement WKPCGetPluginElementObject.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetPluginElementNPObject):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView WebCore::]):
- 4:45 PM Changeset in webkit [40504] by
-
- 2 edits in trunk/WebCore
2009-02-02 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel (and Ojan Vafai).
https://bugs.webkit.org/show_bug.cgi?id=23696
Select element doesn't show new value when focus is switched in
onchange event.
Fix PopupMenuChromium to hide itself before calling valueChanged. This
better matches the behavior of the other ports.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::hidePopup): (WebCore::PopupListBox::abandon): (WebCore::PopupListBox::acceptIndex): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide):
- 4:28 PM Changeset in webkit [40503] by
-
- 7 edits in trunk/WebKit/win
2009-02-02 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein
Transition Windows WebHistory to using the same "update already existing History Items" technique that Mac does.
- Interfaces/IWebHistoryItemPrivate.idl:
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory):
- WebHistory.cpp: (WebHistory::visitedURL):
- WebHistory.h:
- WebHistoryItem.cpp: (WebHistoryItem::visitedWithTitle):
- WebHistoryItem.h:
- 4:27 PM Changeset in webkit [40502] by
-
- 2 edits in trunk/WebCore
2009-02-02 David Hyatt <hyatt@apple.com>
Make sure scrollWidth/Height just return 0 for inline flows.
Reviewed by Beth Dakin
- rendering/RenderBox.cpp: (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):
- 4:27 PM Changeset in webkit [40501] by
-
- 25 edits in trunk
2009-02-02 Darin Adler <Darin Adler>
Reviewed by Dave Hyatt.
Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
https://bugs.webkit.org/show_bug.cgi?id=23676
- API/JSObjectRef.cpp: (JSObjectCopyPropertyNames): Use reserveInitialCapacity.
- parser/Lexer.cpp: (JSC::Lexer::Lexer): Ditto. (JSC::Lexer::clear): Ditto.
- wtf/Vector.h: Added reserveInitialCapacity, a more efficient version of reserveCapacity for use when the vector is brand new (still size 0 with no capacity other than the inline capacity).
WebCore:
2009-02-02 Darin Adler <Darin Adler>
Reviewed by Dave Hyatt.
Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
https://bugs.webkit.org/show_bug.cgi?id=23676
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::cssPropertyName):
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
- css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::sortMatchedRules):
- dom/Document.cpp: (WebCore::Document::formElementsState):
- dom/NamedAttrMap.h: (WebCore::NamedAttrMap::reserveInitialCapacity):
- editing/TextIterator.cpp: (WebCore::CharacterIterator::string): (WebCore::SearchBuffer::SearchBuffer): (WebCore::plainTextToMallocAllocatedBuffer):
- editing/markup.cpp: (WebCore::joinMarkups):
- history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
- html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute):
- loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::items):
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::toString):
- page/mac/AccessibilityObjectWrapper.mm: (convertToVector):
- platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): (WebCore::FontCache::invalidate):
- platform/network/FormData.cpp: (WebCore::FormData::deepCopy):
- platform/network/HTTPHeaderMap.cpp: (WebCore::HTTPHeaderMap::copyData):
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::copyData):
- platform/network/mac/FormDataStreamMac.mm: (WebCore::formCreate):
- xml/XPathNodeSet.cpp: (WebCore::XPath::NodeSet::sort): Use reserveInitialCapacity instead of of reserveCapacity in all these call sites, which are working on new vectors that are guaranteed not to be empty.
- 4:22 PM Changeset in webkit [40500] by
-
- 7 edits in trunk/WebCore
2009-02-26 Jon Honeycutt <jhoneycutt@apple.com>
Build fix after r40486.
Rubber-stamped by Ada Chan.
- dom/Document.h:
- page/EventHandler.h:
- rendering/EllipsisBox.h:
- rendering/InlineBox.h:
- rendering/InlineFlowBox.h:
- rendering/RenderLayer.h:
- 4:07 PM Changeset in webkit [40499] by
-
- 4 edits in trunk/WebCore
2009-02-02 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
Bug 23694: REGRESSION: Running svg/custom tests crashes, randomly, depending on the order of tests
https://bugs.webkit.org/show_bug.cgi?id=23694
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertedIntoDocument): Added back the call through to EventTargetNode. (WebCore::ContainerNode::removedFromDocument): Ditto.
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::insertedIntoDocument): Changed this to not call through to Node. (WebCore::EventTargetNode::removedFromDocument): Ditto.
- dom/Node.cpp: (WebCore::Node::insertedIntoDocument): Updated comment. (WebCore::Node::removedFromDocument): Ditto.
- 3:57 PM Changeset in webkit [40498] by
-
- 2 edits in trunk/WebKit/mac
2009-02-02 Anders Carlsson <andersca@apple.com>
Build fix.
- WebView/WebHTMLView.mm:
- 3:48 PM Changeset in webkit [40497] by
-
- 14 edits2 deletes in trunk
WebCore:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
More plug-in cleanup.
- WebCore.NPAPI.exp: Add new symbols.
- bindings/objc/DOM.mm:
- bindings/objc/DOMPrivate.h: Remove methods that WebKit doesn't use anymore.
WebKit:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Remove WebKitPluginContainerView.{h|mm}, they aren't used anywhere.
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Make WebBaseNetscapePluginView hold a reference to a HTMLPlugInElement instead of a DOMElement.
- Plugins/Hosted/WebHostedNetscapePluginView.h:
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebBaseNetscapePluginView _windowClipRect]): (-[WebBaseNetscapePluginView visibleRect]): (-[WebBaseNetscapePluginView dataSource]):
- Plugins/WebKitPluginContainerView.h: Removed.
- Plugins/WebKitPluginContainerView.mm: Removed.
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebNetscapePluginView getVariable:value:]):
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
- 3:44 PM Changeset in webkit [40496] by
-
- 2 edits in trunk/WebKit/gtk
2009-02-02 Anders Carlsson <andersca@apple.com>
Build fix.
- WebCoreSupport/FrameLoaderClientGtk.h:
- 3:30 PM Changeset in webkit [40495] by
-
- 3 edits in trunk/WebKit/win
2009-02-02 Anders Carlsson <andersca@apple.com>
Fix build.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin):
- WebCoreSupport/WebFrameLoaderClient.h:
- 3:07 PM Changeset in webkit [40494] by
-
- 3 edits in trunk/WebCore
2009-02-02 Jay Campan <jcampan@chromium.org>
Reviewed by Eric Seidel.
Clean up PopupMenuChromium a little.
https://bugs.webkit.org/show_bug.cgi?id=23653
No functional changes, only code cleanup, thus no tests.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupListBox::PopupListBox): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::isSelectableItem): (WebCore::PopupListBox::selectNextRow): (WebCore::PopupListBox::selectPreviousRow): (WebCore::PopupMenu::show):
- platform/chromium/PopupMenuChromium.h:
- 2:36 PM Changeset in webkit [40493] by
-
- 18 edits in trunk
WebCore:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Change createPlugin to take a HTMLPlugInElement, and createJavaAppletWidget to take a HTMLAppletElement.
- WebCore.xcodeproj/project.pbxproj:
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::createPlugin): (WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
- loader/FrameLoader.cpp: (WebCore::toPlugInElement): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::loadItem):
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
WebKit/gtk:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Update for changes to WebCore.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin): (WebKit::FrameLoaderClient::createJavaAppletWidget):
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/mac:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Update for changes to WebCore.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
WebKit/qt:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Update for changes to WebCore.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin): (WebCore::FrameLoaderClientQt::createJavaAppletWidget):
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Update for changes to WebCore.
- WebFrame.cpp: (WebFrame::createJavaAppletWidget):
- WebFrame.h:
- 2:10 PM Changeset in webkit [40492] by
-
- 1 edit in trunk/WebCore/ChangeLog
Adding bug URL for a recent check-in.
- 1:48 PM Changeset in webkit [40491] by
-
- 2 edits in trunk/WebCore
Fix shouldLoadAsEmptyDocument() to return a blank page for an empty
url or about:blank
Applies to Torch Mobile platform only right now, as per request.
- 1:35 PM Changeset in webkit [40490] by
-
- 5 edits in trunk/WebCore
- 1:15 PM Changeset in webkit [40489] by
-
- 2 edits in trunk
2009-02-02 Christian Dywan <christian@twotoasts.de>
Rubber-stamped by Holger Freyther.
Don't require Geolocation by default.
- configure.ac:
- 12:59 PM Changeset in webkit [40488] by
-
- 3 edits in trunk/WebCore
2009-02-02 Darin Adler <Darin Adler>
Try to fix Wx build, and maybe Chromium build too.
- WebCore.scons: Added IdentifierRep.cpp.
- WebCoreSources.bkl: Ditto.
- 12:55 PM Changeset in webkit [40487] by
-
- 2 edits in trunk/WebCore
2009-02-02 Darin Adler <Darin Adler>
Try to fix Wx build.
- html/HTMLAreaElement.cpp: Added missing include of "Path.h".
- 12:46 PM Changeset in webkit [40486] by
-
- 11 edits in trunk
2009-02-02 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Nikolas Zimmermann.
https://bugs.webkit.org/show_bug.cgi?id=23587
Refactor HitTestRequest to eliminate all the ugly boolean arguments and
use an enum bitflag instead. Cleanup all the code that constructs the
various HitTestRequests to make the code more readable.
- dom/Document.cpp: (WebCore::Document::elementFromPoint): (WebCore::Document::prepareMouseEvent):
- editing/SelectionController.cpp: (WebCore::SelectionController::contains):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForPoint): (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
- page/EventHandler.cpp: (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::hoverTimerFired): (WebCore::EventHandler::handleDrag):
- page/EventHandler.h:
- rendering/HitTestRequest.h: (WebCore::HitTestRequest::): (WebCore::HitTestRequest::HitTestRequest): (WebCore::HitTestRequest::readOnly): (WebCore::HitTestRequest::active): (WebCore::HitTestRequest::mouseMove): (WebCore::HitTestRequest::mouseUp): (WebCore::HitTestRequest::ignoreClipping):
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::updateHoverActiveState):
- 12:41 PM Changeset in webkit [40485] by
-
- 3 edits in trunk/WebCore
Fix the WML build by including the inlined renderStyle().
- 12:11 PM Changeset in webkit [40484] by
-
- 3 edits in trunk/WebCore
2009-02-02 Darin Adler <Darin Adler>
Reviewed by Niko Zimmermann.
Bug 23686: REGRESSION (r40475): Failure in fast/xpath/4XPath/Core/test_core_functions.html
https://bugs.webkit.org/show_bug.cgi?id=23686
rdar://problem/6547971
Also fix other XPath tests that are crashing.
- xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::evaluate): Fix order of arguments when creating QualifiedName.
- xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Use createAttrIfNeeded() rather than attr() since we need to make Attr nodes here. Yuck!
- 11:53 AM Changeset in webkit [40483] by
-
- 3 edits in trunk/WebKit/mac
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver Hunt.
When a new Web View was not created, report back to the plug-in host.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::performRequest):
- Plugins/Hosted/WebKitPluginHost.defs:
- 11:29 AM Changeset in webkit [40482] by
-
- 4 edits3 adds in trunk
Implement WML specific attributes of WMLInputElement.
- 11:14 AM Changeset in webkit [40481] by
-
- 2 edits in trunk/WebKit/mac
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Draw the regular missing plug-in icon instead of a red rect when a plug-in has crashed.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]):
- 11:12 AM Changeset in webkit [40480] by
-
- 3 edits in trunk/LayoutTests
2009-01-29 Scott Violet <sky@google.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23633
The test transitions/transition-end-event-nested.html occasionally fails
Ups the timeout of the test transitions/transition-end-event-nested.html
and makes the test exit as soon as all events received.
- transitions/transition-end-event-helpers.js: (recordTransitionEndEvent): (runTransitionTest.startTest._endFunction): (runTransitionTest.startTest): (runTransitionTest):
- transitions/transition-end-event-nested.html:
- 11:10 AM Changeset in webkit [40479] by
-
- 1 edit in trunk/WebCore/ChangeLog
Forgot to update ChangeLog in my last commit.
- 11:03 AM Changeset in webkit [40478] by
-
- 2 edits in trunk/WebCore
Correct build regression.
- 10:45 AM Changeset in webkit [40477] by
-
- 1 edit in trunk/WebCore/wml/WMLAElement.cpp
Not reviewed. Fix WML enabled builds.
FrameLoader::urlSelected() got a new parameter: lockBackForwardList. Pass 'false', as HTMLAnchorElement does.
- 10:12 AM Changeset in webkit [40476] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/6451610> Reloading a AppCache page doesn't ever hit the server
Not easily testable.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::createResourceHandle): A new method that creates a resource handle in a manner that is closer to what CachedResource does. We now make conditional requests for better performance, and set max-age to ensure that stale responses are not used. (WebCore::ApplicationCacheGroup::update): Use the new createResourceHandle() method. (WebCore::ApplicationCacheGroup::didReceiveResponse): If the response code for the resource is 304, take it from the newest cache. (WebCore::ApplicationCacheGroup::didFail): Pre-compute request URL. (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Don't create a resource for the manifest if the response code was 304 - it won't be needed. (WebCore::ApplicationCacheGroup::didReceiveManifestData): Replaced an assertion that m_manifestResource is not null with a check. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Treat null m_manifestResource as an indication that the response was 304. (WebCore::ApplicationCacheGroup::startLoadingEntry): Use createResourceHandle().
- loader/appcache/ApplicationCacheGroup.h: Added createResourceHandle().
- 9:29 AM Changeset in webkit [40475] by
-
- 31 edits in trunk/WebCore
2009-02-01 Darin Adler <Darin Adler>
Reviewed by Dave Hyatt.
Bug 23674: Speed up some things based on profiling the page load test
https://bugs.webkit.org/show_bug.cgi?id=23674
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Use the newly named cssTarget instead of the old name, getCSSTarget. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertedIntoDocument): Moved code from Node in here rather than calling through to EventTargetNode::insertedIntoDocument. (WebCore::ContainerNode::removedFromDocument): Ditto. (WebCore::ContainerNode::insertedIntoTree): Tweaked a bit. (WebCore::ContainerNode::removedFromTree): Ditto.
- dom/ContainerNode.h: Moved the constructor definition here and made it inline.
- dom/Document.cpp: (WebCore::Document::removeAllEventListenersFromAllNodes): Iterate the document element and its contents only to avoid the document type node. This allows us to remove the virtual function call to isEventTargetNode from the loop. (WebCore::Document::setCSSTarget): Changed argument to be an Element rather than Node.
- dom/Document.h: Changed CSS target to be an Element rather than a Node. Renamed getCSSTarget to cssTarget.
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::removeAllEventListenersSlowCase): Renamed and turned the rare data check into an assertion.
- dom/EventTargetNode.h: Made the fast case of removeAllEventListeners be inline. Also moved the constructor definition here and made it inline. And added toEventTargetNode, matching the design of the render tree checked casts. Later we can migrate all callers from EventTargetNodeCast to toEventTargetNode.
- dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::detachAttributesFromElement): Added. Factored out from clearAttributes, so we could use this loop in cases where we're not clearing the attributes. (WebCore::NamedAttrMap::~NamedAttrMap): Call detachAttributesFromElement instead of clearAttributes here. (WebCore::NamedAttrMap::clearAttributes): Call detachAttributesFromElement here. (WebCore::NamedAttrMap::detachFromElement): Call detachAttributesFromElement instead of clearAttributes. We don't need to clear the attributes array just because the element is going away, so don't. (WebCore::NamedAttrMap::virtualLength): Added.
- dom/NamedAttrMap.h: Made all the virtual functions inherited from NamedNodeMap be private. These are all unnecessarily inefficient for use outside the DOM. Changed length to be a non-virtual function. This was a fairly hot function.
- dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::setClass): Changed to use element() function now that the m_element data member is private.
- dom/NamedMappedAttrMap.h: Made a few functions private. Made the hasMappedAttributes function non-virtual.
- dom/NamedNodeMap.h: Made length a non-virtual inline function that calls a virtual function, name virtualLength. This lets NamedAttrMap::length be a non-virtual function.
- dom/Node.cpp: (WebCore::Node::insertedIntoDocument): Removed call to insertedIntoTree, since it's only non-empty in subclasses of ContainerNode. (WebCore::Node::removedFromDocument): Ditto. Also removed setCSSTarget. Since a CSS target has to be an Element, this can be moved down to ContainerNode (or it could be moved down to Element for that matter).
- dom/QualifiedName.cpp: (WebCore::QualifiedName::QualifiedName): Removed double initialization of m_impl.
- dom/QualifiedName.h: Moved the destructor, copy constructor, assignment operator, and setPrefix function definitions into the header and made them inline.
- html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::mapMouseEvent): Updated since the stored region is now an OwnPtr. (WebCore::HTMLAreaElement::accessKey): Use AtomicString. (WebCore::HTMLAreaElement::setAccessKey): Ditto. (WebCore::HTMLAreaElement::alt): Ditto. (WebCore::HTMLAreaElement::setAlt): Ditto. (WebCore::HTMLAreaElement::coords): Ditto. (WebCore::HTMLAreaElement::setCoords): Ditto. (WebCore::HTMLAreaElement::setHref): Ditto. (WebCore::HTMLAreaElement::shape): Ditto. (WebCore::HTMLAreaElement::setShape): Ditto. (WebCore::HTMLAreaElement::setTarget): Ditto.
- html/HTMLAreaElement.h: Use AtomicString in the getter and setter DOM operations. Change the region data member to be an OwnPtr<Path> instead of a Path to optimize the common case where an area element is parsed but never hit-tested. This could also have been done by changing the Path class's null case to be more efficient, but this seems fine.
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): Use addAttribute instead of insertAttribute. (WebCore::HTMLViewSourceDocument::addSpanWithClassName): Ditto. (WebCore::HTMLViewSourceDocument::addLine): Ditto. (WebCore::HTMLViewSourceDocument::addLink): Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Use cssTarget under its new name instead of its old name getCSSTarget.
- platform/graphics/GlyphWidthMap.cpp: (WebCore::GlyphWidthMap::locatePageSlowCase): Refactored from locatePage.
- platform/graphics/GlyphWidthMap.h: Made most of this class inline. Changed m_pages to use OwnPtr.
- platform/text/PlatformString.h: Remove include no longer needed since StringImpl.h includes it.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::createStrippingNullCharactersSlowCase): Refactored from createStrippingNullCharacters.
- platform/text/StringImpl.h: Moved the definition of createStrippingNullCharacters here and made it inline.
- rendering/RenderObject.cpp: (WebCore::RenderObject::firstLineStyleSlowCase): Refactored from firstLineStyle.
- rendering/RenderObject.h: Moved the definition of the firstLineStyle function here and made it inline. Moved the definition of the documentBeingDestroyed function here and made it inline.
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getCTM): Use getAttributeItem instead of getNamedItem here since it accomplishes the same thing but is more efficient. (WebCore::SVGSVGElement::getScreenCTM): Ditto.
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute): Ditto.
- xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::evaluate): Use getAttributeItem instead of getNamedItemNS.
- xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Use attributeItem instead of item here.
- 7:29 AM Changeset in webkit [40474] by
-
- 2 edits in trunk/WebKit/qt
2009-02-02 Adam Treat <adam.treat@torchmobile.com>
Fix the Qt build to call forceLayout on the view instead.
- Api/qwebpage.cpp: (QWebPage::setFixedLayoutSize): (QWebPage::setUseFixedLayout):
- 5:16 AM Changeset in webkit [40473] by
-
- 18 edits in trunk
Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView
https://bugs.webkit.org/show_bug.cgi?id=23428
FrameView::forceLayout could be killed but the comment might
contain a value over the the plain FrameView::layout...
Adjust the WebCore/WebKit consumers of these methods.
Feb 1, 2009:
- 12:30 PM Changeset in webkit [40472] by
-
- 5 edits in trunk/WebCore
Reviewed by John Sullivan.
- fix <rdar://problem/6546625> REGRESSION (r40432): iframes added to global history at haaretz.co.il
Fixes http/tests/navigation/multiple-back-forward-entries.html
r40432 added a parameter to FrameLoader::scheduleLocationChange() and
failed to update all call sites.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): Pass the lockBackForwardHistory parameter, giving it the same value as the lockHistory parameter. (windowProtoFuncOpen): Ditto.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Ditto.
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation): Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Ditto.
Jan 31, 2009:
- 10:23 PM Changeset in webkit [40471] by
-
- 3 edits in trunk/WebCore
Reviewed by Oliver Hunt.
- fix <rdar://problem/6546549> Eliminate some RenderText::width() overhead from findNextLineBreak()
On the PLT, this results in 0.36x the number of virtual function calls
to RenderText::width() and 0.69x the number of calls to
Font::isFixedPitch(), but makes 1.0004x the number of calls to
Font::width().
- rendering/RenderText.cpp: (WebCore::RenderText::width): Replaced bounds checks on 'from' and 'len' with an assertion.
- rendering/bidi.cpp: (WebCore::textWidth): Added this inlined helper function which calls Font::width() directly in the non-fixed-pitch, non-full-range case, and otherwise calls RenderText::width(). (WebCore::RenderBlock::findNextLineBreak): Cache whether the font has fixed pitch (in which case RenderText::width() will be called in order to take advantage of the widthFromCache() optimization for fixed-pitch fonts). Replaced all calls to RenderText::width() with calls to the textWidth() helper function.
- 9:07 PM Changeset in webkit [40470] by
-
- 4 edits in trunk/WebKit/win
2009-01-31 Matt Lilek <webkit@mattlilek.com>
Not reviewed, build fixes.
- WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
- WebFrame.cpp: (WebFrame::setInPrintingMode): (WebFrame::isFrameSet):
- WebView.cpp: (WebView::notifyPreferencesChanged):
- 5:30 PM Changeset in webkit [40469] by
-
- 3 edits in trunk/WebCore
2009-01-31 David Hyatt <hyatt@apple.com>
Inline all of the setNeedsLayout method and its associated functions. Also inline setChildNeedsLayout
and setNeedsPositionedMovementLayout.
Reviewed by Dan Bernstein
- rendering/RenderObject.cpp: (WebCore::RenderObject::setLayerNeedsFullRepaint):
- rendering/RenderObject.h: (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setChildNeedsLayout): (WebCore::RenderObject::setNeedsPositionedMovementLayout): (WebCore::objectIsRelayoutBoundary): (WebCore::RenderObject::markContainingBlocksForLayout):
- 4:59 PM Changeset in webkit [40468] by
-
- 2 edits in trunk/WebKit/mac
2009-01-31 John Sullivan <sullivan@apple.com>
Cleaned up code to add/remove NSNotification observers, to avoid performance hit
of calling removeObserver with unspecified notifications, or calling removeObserver
multiple times for the same notification.
Reviewed by Darin Adler
- WebView/WebHTMLView.mm: added observingMouseMovedNotifications, observingSuperviewNotifications, and observingWindowNotifications as BOOL ivars of _private object (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): moved to file-internal section of file, added leading underscore, now bails out if we aren't observing the relevant notifications, now records that we are no longer observing the relevant notifications (-[WebHTMLView _removeSuperviewObservers]): ditto, also stores [NSNoticationCenter defaultCenter] in local var to avoid objc dispatch (-[WebHTMLView _removeWindowObservers]): ditto (-[WebHTMLView close]): replace general removeObserver: call with three specific calls for all the notifications that this class actually observes (-[WebHTMLView addMouseMovedObserver]): bail out if already observing relevant notifications, now records that we are observing the relevant notifications (-[WebHTMLView removeMouseMovedObserver]): updated for name change (-[WebHTMLView addSuperviewObservers]): bail out if already observing relevant notifications, now records that we are observing the relevant notifications; also stores [NSNoticationCenter defaultCenter] in local var to avoid objc dispatch (-[WebHTMLView addWindowObservers]): ditto (-[WebHTMLView viewWillMoveToSuperview:]): updated for name change (-[WebHTMLView viewWillMoveToWindow:]): updated for name changes
- 4:55 PM Changeset in webkit [40467] by
-
- 3 edits in trunk/WebCore
2009-01-31 Darin Adler <Darin Adler>
Fix Mac build.
- loader/FrameLoader.cpp: Moved FrameLoaderClient::hasHTMLView in here. We need it to not be an inline. Sadly, FrameLoaderClient.cpp was prematurely deleted and I don't want to bring it back just to fix the build.
- loader/FrameLoaderClient.h: Rearrange virtual functions and corrected a possibly-confusing comment.
- 4:52 PM Changeset in webkit [40466] by
-
- 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj
Fix WIndows bustage.
- 4:14 PM Changeset in webkit [40465] by
-
- 2 edits in trunk/WebKit/mac
2009-01-31 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
Fix code that assumes all command selectors end in colons.
rdar://problem/6545874
- WebView/WebHTMLView.mm: (commandNameForSelector): Don't assert, just return a null string, when the selector doesn't end in a colon.
- 3:55 PM Changeset in webkit [40464] by
-
- 3 edits in trunk/WebCore
2009-01-31 Adam Treat <adam.treat@torchmobile.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23664
Remove unused dead code from RenderTable class. The dead code includes
two enums and the associated member variables as well as one getter function.
- rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable):
- rendering/RenderTable.h:
- 2:03 PM Changeset in webkit [40463] by
-
- 1 edit in trunk/LayoutTests/platform/mac/fast/invalid/table-residual-style-crash-expected.txt
Update layout test results for 11363.
- 1:40 PM Changeset in webkit [40462] by
-
- 4 edits in trunk/WebCore
Add RenderObjectChildList.cpp to all projects.
- 1:38 PM Changeset in webkit [40461] by
-
- 18 edits1 add in trunk/WebCore
2009-01-31 David Hyatt <hyatt@apple.com>
More removal of code from RenderContainer. Move removeLeftoverAnonymousBlock down into RenderBlock.
Move destroyLeftoverChildren into the RenderObjectChildList. Convert all containers to use the
RenderObjectChildList.
Reviewed by Sam Weinig
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::addChild): (WebCore::RenderBlock::removeLeftoverAnonymousBlock): (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::childBecameNonInline):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::layout):
- rendering/RenderBox.h: (WebCore::RenderBox::firstChildBox): (WebCore::RenderBox::lastChildBox):
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::updateBeforeAfterContentForContainer): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode): (WebCore::RenderContainer::positionForCoordinates): (WebCore::RenderContainer::addLineBoxRects): (WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
- rendering/RenderContainer.h: (WebCore::RenderContainer::virtualChildren): (WebCore::RenderContainer::children):
- rendering/RenderInline.cpp: (WebCore::RenderInline::destroy):
- rendering/RenderInline.h: (WebCore::RenderInline::layout):
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::destroy): (WebCore::RenderMedia::children):
- rendering/RenderMedia.h: (WebCore::RenderMedia::virtualChildren):
- rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): (WebCore::RenderObject::layout):
- rendering/RenderObject.h: (WebCore::RenderObject::firstChild): (WebCore::RenderObject::lastChild): (WebCore::RenderObject::virtualChildren): (WebCore::RenderObject::canHaveChildren):
- rendering/RenderObjectChildList.cpp: Added. (WebCore::RenderObjectChildList::destroyLeftoverChildren):
- rendering/RenderObjectChildList.h:
- rendering/RenderReplaced.h: (WebCore::RenderReplaced::canHaveChildren):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::destroy): (WebCore::RenderSVGContainer::removeChildNode): (WebCore::RenderSVGContainer::appendChildNode): (WebCore::RenderSVGContainer::insertChildNode):
- rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::virtualChildren): (WebCore::RenderSVGContainer::children):
- 1:34 PM Changeset in webkit [40460] by
-
- 1 edit in trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt
Update layout test results for 11363.
- 1:34 PM Changeset in webkit [40459] by
-
- 1 edit in trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt
Update layout test results for 11363.
- 1:30 PM Changeset in webkit [40458] by
-
- 2 edits in trunk/LayoutTests/platform/mac/tables/mozilla/bugs
Update layout test results for 11363.
- 1:28 PM Changeset in webkit [40457] by
-
- 2 edits in trunk/LayoutTests/platform/mac/fast/table
Update layout test results for 11363.
- 1:28 PM Changeset in webkit [40456] by
-
- 2 edits in trunk/LayoutTests/platform/mac/fast/table
Update layout test results for 11363.
- 1:26 PM Changeset in webkit [40455] by
-
- 1 edit in trunk/LayoutTests/editing/deleting/5408255.html
Update layout test results for 11363.
- 1:23 PM Changeset in webkit [40454] by
-
- 1 edit in trunk/LayoutTests/platform/mac/editing/deleting/deletionUI-single-instance-expected.txt
Update layout test results for 11363.
- 1:20 PM Changeset in webkit [40453] by
-
- 5 edits in trunk/WebCore
2009-01-31 David Hyatt <hyatt@apple.com>
Remove the hacks in table code around the DeleteButtonController and fix tables so that positioned children don't get wrapped in anonymous objects.
With the removal of a non-positioned DeleteButtonController renderer, table layout can be tightened up to only lay out table sections. Table section
layout is tightened up to ignore non-table rows. When a table has multiple captions, only the real one will do a layout now. The other ones will
be properly ignored.
Reviewed by Oliver Hunt
- editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
- rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): (WebCore::RenderTable::layout):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layout):
- rendering/RenderTableSection.h:
- 10:07 AM Changeset in webkit [40452] by
-
- 6 edits in trunk/WebCore
2009-01-31 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23663
Add a void toRenderBox() method which catches unnecessary casts at compile
time and also fix the four cases where this was happening.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::determineHorizontalPosition):
- rendering/RenderBox.h:
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox):
- rendering/RenderInline.cpp: (WebCore::RenderInline::updateHitTestResult):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
- 8:02 AM Changeset in webkit [40451] by
-
- 2 edits in trunk/WebKit/wx
2009-01-31 Darin Adler <Darin Adler>
Build fix.
- WebView.cpp: (wxWebView::OnSize): call sendResizeEvent on EventHandler.
- 1:36 AM Changeset in webkit [40450] by
-
- 4 edits1 move4 adds1 delete in trunk
2009-01-30 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Nikolas Zimmermann.
[Gtk] Refactor autoconf/configure.ac in preparation for jsc and webkit build splits
https://bugs.webkit.org/show_bug.cgi?id=22136
- GNUmakefile.am:
- acinclude.m4: Removed.
- autogen.sh:
- autotools/acinclude.m4: Added.
- autotools/dolt.m4: Added.
- autotools/symbols.filter: Renamed from symbols.filter.
- autotools/webkit.m4: Added.
- configure.ac:
- 12:42 AM Changeset in webkit [40449] by
-
- 18 edits in trunk
WebCore:
2009-01-30 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Add a pref to disable web security.
- WebCore.base.exp:
- dom/Document.cpp: (WebCore::Document::initSecurityContext):
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::grantUniversalAccess):
- page/SecurityOrigin.h:
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setWebSecurityEnabled):
- page/Settings.h: (WebCore::Settings::isWebSecurityEnabled):
WebKit/win:
2009-01-30 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Add a pref to disable web security.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isWebSecurityEnabled): (WebPreferences::setWebSecurityEnabled):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
WebKit/mac:
2009-01-30 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Add a pref to disable web security.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferencesPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isWebSecurityEnabled]): (-[WebPreferences setWebSecurityEnabled:]):
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
Jan 30, 2009:
- 10:24 PM Changeset in webkit [40448] by
-
- 2 edits in trunk/WebKitLibraries
Reviewed by Timothy Hatcher.
- <rdar://problem/6545912> expose the build number in autoversion.h
- win/tools/scripts/auto-version.sh: Added a #define BUILD_NUMBER with the full build number.
- 9:12 PM Changeset in webkit [40447] by
-
- 2 edits in trunk/WebCore
2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
Build fix.
Move the inline virtual destructor after a non-inline virtual
function so that the symbol for the vtable is not marked as a
weakly exported symbol.
This trick was previously used at revision 36122 in JSObject.h
- loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::~FrameLoaderClient):
- 8:43 PM Changeset in webkit [40446] by
-
- 3 edits in trunk/WebCore
Inline SimpleFontData::widthForGlyph for a minor page load improvement.
Reviewed by Stephanie Lewis
- 8:40 PM Changeset in webkit [40445] by
-
- 3 edits in trunk/WebCore
Build fix for WX and maybe even Windows.
- 8:12 PM Changeset in webkit [40444] by
-
- 9 edits in trunk
Move Frame::sendResizeEvent and Frame::sendScrollEvent to EventHandler
Carry out the move and catch up in two call sites.
- 7:51 PM Changeset in webkit [40443] by
-
- 11 edits in trunk
Move Frame::isFrameSet to Document::isFrameSet
Changed the FrameLoader callsite. I assume that as this
point m_frame.document() might return a null pointer. Change
the condition to either not having a document or not having a
frame set. This should be semantically equivalent to the
old code.
Make Document::body() const to be able to call it from within
Document::isFrameSet. Leave the isHTMLDocument() check as this
is a stronger condition than simply having a HTMLElement in the
DOM.
- 7:51 PM Changeset in webkit [40442] by
-
- 2 edits in trunk/WebCore
[GTK] Logic fixes and build fixes
https://bugs.webkit.org/show_bug.cgi?id=22022
Catch up with the internal GeoLocation API and fix the logic of
the previous version.
- 7:51 PM Changeset in webkit [40441] by
-
- 6 edits in trunk
[GTK] Implement GeolocationService using the Geoclue library
https://bugs.webkit.org/show_bug.cgi?id=22022
Untested implementation of the GeolocationService using the geoclue
library. Velocity handling is completely missing and the accuracy
handling might be wrong.
- 7:48 PM Changeset in webkit [40440] by
-
- 2 edits in trunk/WebCore
Build fix. Declare preferredSize as static.
- platform/text/cf/StringImplCF.cpp:
(WebCore::StringWrapperCFAllocator::preferredSize):
- 7:11 PM Changeset in webkit [40439] by
-
- 2 edits in trunk/JavaScriptCore
<rdar://problem/6391501> Enable the JIT on Mac OS X x86_64 as it passes all tests.
Rubber-stamped by Oliver Hunt.
- wtf/Platform.h:
- 6:31 PM Changeset in webkit [40438] by
-
- 3 edits in trunk/WebCore
2009-01-30 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
Bug 23622: create CFString and NSString objects from WebCore::String without copying the characters
https://bugs.webkit.org/show_bug.cgi?id=23622
- platform/text/cf/StringImplCF.cpp: (WebCore::StringWrapperCFAllocator::allocator): Added. Returns the allocator. (WebCore::StringWrapperCFAllocator::retain): Added. Callback for allocator. (WebCore::StringWrapperCFAllocator::release): Ditto. (WebCore::StringWrapperCFAllocator::copyDescription): Ditto. (WebCore::StringWrapperCFAllocator::allocate): Ditto. (WebCore::StringWrapperCFAllocator::reallocate): Ditto. (WebCore::StringWrapperCFAllocator::deallocate): Ditto. (WebCore::StringWrapperCFAllocator::preferredSize): Ditto. (WebCore::StringWrapperCFAllocator::create): Added. Creates the allocator, but returns 0 if garbage collection is enabled. (WebCore::StringImpl::createCFString): Use StringWrapperCFAllocator if possible.
- platform/text/mac/StringImplMac.mm: (WebCore::StringImpl::operator NSString *): Use CFString and toll-free bridging, rather than using NSString directly. This lets NSString benefit from the above.
- 6:31 PM Changeset in webkit [40437] by
-
- 2 edits in trunk/WebCore
2009-01-30 Darin Adler <Darin Adler>
- page/Frame.cpp: (WebCore::Frame::createView): Fix debug build by removing get() from assert.
- 6:13 PM Changeset in webkit [40436] by
-
- 9 edits in trunk/WebKit
WebKit/gtk:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):
WebKit/mac:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebView/WebFramePrivate.h:
WebKit/qt:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):
WebKit/win:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Build fix.
- Interfaces/IWebFramePrivate.idl:
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::loadURLIntoChild):
- 5:57 PM Changeset in webkit [40435] by
-
- 14 edits1 delete in trunk
Kill FrameLoaderClient.cpp, move the code over to Frame::createView
FrameLoaderClient is supposed to be an interface, move the
to be shared code to Frame which is a controller and is
allowed to create a FrameView.
- 5:47 PM Changeset in webkit [40434] by
-
- 2 edits4 adds in trunk/WebCore
2009-01-30 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
New files to support accelerated compositing at the RenderLayer
level.
- WebCore.xcodeproj/project.pbxproj: New files added to project, and run through the sort script.
- rendering/RenderLayerBacking.cpp: Added.
- rendering/RenderLayerBacking.h: Added. New object to store compositing-related data for a single RenderLayer.
- rendering/RenderLayerCompositor.cpp: Added.
- rendering/RenderLayerCompositor.h: Added. Per-RenderView controller object for compositing hierarchy maintenance.
- 5:42 PM Changeset in webkit [40433] by
-
- 2 edits9 adds in trunk/WebCore
2009-01-30 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Add new files related to accelerated compositing.
- 5:28 PM Changeset in webkit [40432] by
-
- 16 edits in trunk
WebCore:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Split "lockHistory" into "lockHistory" and "lockBackForwardList" in
preparation for setting them differently during a redirect.
- WebCore.base.exp:
- bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::submit):
- bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::replace): (WebCore::JSLocation::assign):
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
- html/HTMLFormElement.h:
- loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::isBackForwardLoadType): (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitFormAgain): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::scheduleHTTPRedirection): (WebCore::FrameLoader::scheduleLocationChange): (WebCore::FrameLoader::scheduleRefresh): (WebCore::FrameLoader::redirectionTimerFired): (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::startRedirectionTimer): (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::loadItem):
- loader/FrameLoader.h:
- loader/FrameLoaderTypes.h: (WebCore::):
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
- svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
WebKit/mac:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Split "lockHistory" into "lockHistory" and "lockBackForwardList" in
preparation for setting them differently during a redirect.
- WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
WebKit/qt:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Split "lockHistory" into "lockHistory" and "lockBackForwardList" in
preparation for setting them differently during a redirect.
- Api/qwebpage.cpp: (QWebPage::triggerAction):
- 4:42 PM Changeset in webkit [40431] by
-
- 3 edits2 adds in trunk
WebCore:
2009-01-30 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/6545095>
ASSERTION FAILED: RenderBlock.h:519: !o o->isRenderBlock() Test: fast/block/float/crash-replaced-display-block.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Move RenderBlock only code into isRenderBlock if-statement.
LayoutTests:
2009-01-30 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Test for <rdar://problem/6545095>
ASSERTION FAILED: RenderBlock.h:519: !o o->isRenderBlock() - fast/block/float/crash-replaced-display-block-expected.txt: Added.
- fast/block/float/crash-replaced-display-block.html: Added.
- 3:46 PM Changeset in webkit [40430] by
-
- 6 edits in trunk
Bug 23656: AX hierarchy for iFrames is incorrect
https://bugs.webkit.org/show_bug.cgi?id=23656
The AX hierarchy when an iFrame was present was incorrect. A different scroll area was returned when going down compared to when going up.
- 3:43 PM Changeset in webkit [40429] by
-
- 2 edits in trunk/WebCore
2009-01-30 Adam Treat <adam.treat@torchmobile.com>
Fix Qt build to include new class IdentifierRep introduced in revision 40412.
- WebCore.pro:
- 3:32 PM Changeset in webkit [40428] by
-
- 5 edits in trunk/WebKit/mac
2009-01-30 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Fix <rdar://problem/6544048>
Have NetscapePluginInstanceProxy keep track of all the ProxyInstance objects associated.
When the plug-in instance is destroyed, invalidate all proxy instances.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::destroy): (WebKit::NetscapePluginInstanceProxy::addInstance): (WebKit::NetscapePluginInstanceProxy::removeInstance):
- Plugins/Hosted/ProxyInstance.h:
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::ProxyInstance): (WebKit::ProxyInstance::~ProxyInstance): (WebKit::ProxyInstance::invalidate):
- 3:16 PM Changeset in webkit [40427] by
-
- 3 edits in trunk/WebCore
2009-01-30 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Make IdentifierRep.h a private header, and add symbols needed by WebKit to WebCore.LP64.exp.
- WebCore.LP64.exp:
- WebCore.xcodeproj/project.pbxproj:
- 3:13 PM Changeset in webkit [40426] by
-
- 2 edits in trunk/WebCore
[Gtk+] Use AccessibilityObject::stringValue for the AtkObject name
https://bugs.webkit.org/show_bug.cgi?id=21546
The API documentation at http://library.gnome.org/devel/atk/stable/AtkText.html
states that: "AtkObjects whose text content is simple, unattributed, and very
brief may expose that content via atk_object_get_name instead"
As we are currently not able to always provide a AtkTextInterface
implementation this will make the whole content available to accerciser,
and other tools.
- 3:11 PM Changeset in webkit [40425] by
-
- 8 edits in trunk/WebCore
2009-01-30 Sam Weinig <sam@webkit.org>
Commit files I forgot to in the previous commit.
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::layoutCount):
- page/Frame.cpp: (WebCore::Frame::contentRenderer): (WebCore::Frame::forceLayoutWithPageWidthRange):
- page/FrameView.cpp: (WebCore::FrameView::layout):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer): (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::view): (WebCore::RenderObject::scheduleRelayout): (WebCore::RenderObject::maximalOutlineSize):
- rendering/SVGRenderSupport.cpp: (WebCore::clampImageBufferSizeToViewport):
- svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
- 3:09 PM Changeset in webkit [40424] by
-
- 57 edits6 adds in trunk
WebCore:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
More scaffolding for redirect tracking. No behavior change yet.
- bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::submit): Added scaffolding necessary for redirect checking in a form submission through JS. (Currently, we just specify "no redirect.")
- bindings/js/ScriptController.h:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::ScriptController::processingUserGestureEvent): (WebCore::ScriptController::isJavaScriptAnchorNavigation): Refactored user gesture check to make it more clear.
(WebCore::ScriptController::pageIsProcessingUserGesture): Added a helper
for checking if there's a user gesture in any frame on the page (a more
relaxed rule than our popup blocking rule, which requires the user
gesture to occur in the frame that's executing JavaScript.)
- html/HTMLFormElement.h:
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Added scaffolding necessary for redirect checking in a form submission through the DOM. (Currently, we just specify "no redirect.")
- html/HTMLFormElement.idl: Made submit custom so it can participate in redirect checking.
- loader/FrameLoader.h:
- loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): Clarified some names, and added a "lockHistory" parameter to form submissions, to match other navigations.
(WebCore::FrameLoader::submitFormAgain):
(WebCore::FrameLoader::submitForm): Use the lockHistory parameter.
(WebCore::FrameLoader::userGestureHint): Refactored this function for
clarity, and added a FIXME for a change I was too scared to make myself.
(Really, we should just get rid of this function.)
(WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Refactored
to pass a FrameLoadType to form posts, too, so they can participate in
redirect tracking.
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::loadItem): Use the lockHistory parameter.
LayoutTests:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
More redirect layout test work.
Added tests (expected to fail) for form submission via JavaScript:
- http/tests/history/redirect-js-form-submit-0-seconds-expected.txt: Added.
- http/tests/history/redirect-js-form-submit-0-seconds.html: Added.
- http/tests/history/redirect-js-form-submit-2-seconds-expected.txt: Added.
- http/tests/history/redirect-js-form-submit-2-seconds.html: Added.
- http/tests/history/redirect-js-form-submit-before-load-expected.txt: Added.
- http/tests/history/redirect-js-form-submit-before-load.html: Added.
Updated these tests to dump their back/forward lists, to check for
back/forward regressions, and to use # instead of ? to communicate between
URLs, since, to my surprise, form submissions can't use query strings.
- http/tests/history/redirect-200-refresh-0-seconds-expected.txt:
- http/tests/history/redirect-200-refresh-0-seconds.pl:
- http/tests/history/redirect-200-refresh-2-seconds-expected.txt:
- http/tests/history/redirect-200-refresh-2-seconds.pl:
- http/tests/history/redirect-301-expected.txt:
- http/tests/history/redirect-301.pl:
- http/tests/history/redirect-302-expected.txt:
- http/tests/history/redirect-302.pl:
- http/tests/history/redirect-303-expected.txt:
- http/tests/history/redirect-303.pl:
- http/tests/history/redirect-307-expected.txt:
- http/tests/history/redirect-307.pl:
- http/tests/history/redirect-js-document-location-0-seconds-expected.txt:
- http/tests/history/redirect-js-document-location-0-seconds.html:
- http/tests/history/redirect-js-document-location-2-seconds-expected.txt:
- http/tests/history/redirect-js-document-location-2-seconds.html:
- http/tests/history/redirect-js-document-location-before-load-expected.txt:
- http/tests/history/redirect-js-document-location-before-load.html:
- http/tests/history/redirect-js-location-0-seconds-expected.txt:
- http/tests/history/redirect-js-location-0-seconds.html:
- http/tests/history/redirect-js-location-2-seconds-expected.txt:
- http/tests/history/redirect-js-location-2-seconds.html:
- http/tests/history/redirect-js-location-assign-0-seconds-expected.txt:
- http/tests/history/redirect-js-location-assign-0-seconds.html:
- http/tests/history/redirect-js-location-assign-2-seconds-expected.txt:
- http/tests/history/redirect-js-location-assign-2-seconds.html:
- http/tests/history/redirect-js-location-assign-before-load-expected.txt:
- http/tests/history/redirect-js-location-assign-before-load.html:
- http/tests/history/redirect-js-location-before-load-expected.txt:
- http/tests/history/redirect-js-location-before-load.html:
- http/tests/history/redirect-js-location-href-0-seconds-expected.txt:
- http/tests/history/redirect-js-location-href-0-seconds.html:
- http/tests/history/redirect-js-location-href-2-seconds-expected.txt:
- http/tests/history/redirect-js-location-href-2-seconds.html:
- http/tests/history/redirect-js-location-href-before-load-expected.txt:
- http/tests/history/redirect-js-location-href-before-load.html:
- http/tests/history/redirect-js-location-replace-0-seconds-expected.txt:
- http/tests/history/redirect-js-location-replace-0-seconds.html:
- http/tests/history/redirect-js-location-replace-2-seconds-expected.txt:
- http/tests/history/redirect-js-location-replace-2-seconds.html:
- http/tests/history/redirect-js-location-replace-before-load-expected.txt:
- http/tests/history/redirect-js-location-replace-before-load.html:
- http/tests/history/redirect-meta-refresh-0-seconds-expected.txt:
- http/tests/history/redirect-meta-refresh-0-seconds.html:
- http/tests/history/redirect-meta-refresh-2-seconds-expected.txt:
- http/tests/history/redirect-meta-refresh-2-seconds.html:
- http/tests/history/resources/redirect-target.html:
- 3:00 PM Changeset in webkit [40423] by
-
- 1 edit13 adds in trunk/LayoutTests
2009-01-30 Pierre-Olivier Latour <pol@apple.com>
Updated the references images for the media layout tests on Tiger since they now differ from Leopard after installing QuickTime 7.6.
- platform/mac-tiger/media: Added.
- platform/mac-tiger/media/video-aspect-ratio-expected.checksum: Added.
- platform/mac-tiger/media/video-aspect-ratio-expected.png: Added.
- platform/mac-tiger/media/video-controls-rendering-expected.checksum: Added.
- platform/mac-tiger/media/video-controls-rendering-expected.png: Added.
- platform/mac-tiger/media/video-display-toggle-expected.checksum: Added.
- platform/mac-tiger/media/video-display-toggle-expected.png: Added.
- platform/mac-tiger/media/video-layer-crash-expected.checksum: Added.
- platform/mac-tiger/media/video-layer-crash-expected.png: Added.
- platform/mac-tiger/media/video-transformed-expected.checksum: Added.
- platform/mac-tiger/media/video-transformed-expected.png: Added.
- platform/mac-tiger/media/video-zoom-expected.checksum: Added.
- platform/mac-tiger/media/video-zoom-expected.png: Added.
- 2:57 PM Changeset in webkit [40422] by
-
- 2 edits in trunk/WebKit/mac
2009-01-30 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Fix <rdar://problem/6490778>.
Change the NPRuntime related functions to use IdentifierRep directly, and make sure to always
validate IdentifierReps before dereferencing them.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCGetStringIdentifier): (WKPCGetIntIdentifier): (identifierFromIdentifierRep): (WKPCInvoke): (WKPCGetProperty): (WKPCSetProperty): (WKPCRemoveProperty): (WKPCHasProperty): (WKPCHasMethod): (WKPCIdentifierInfo):
- 2:42 PM Changeset in webkit [40421] by
-
- 1 edit1 delete in trunk/LayoutTests
2009-01-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Correct mis-applied http://trac.webkit.org/changeset/40413 by actually
removing the test file.
- fast/dom/Window/timeout-released-on-close.html: Removed.
- 2:19 PM Changeset in webkit [40420] by
-
- 2 edits in trunk/WebCore
Build fix for Gtk+
- 2:16 PM Changeset in webkit [40419] by
-
- 2 edits in trunk/JavaScriptCore
Finally fix load() to propagate exceptions correctly.
Reviewed by Mark Rowe and Sam Weinig.
- 2:02 PM Changeset in webkit [40418] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-30 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23618
Templated worker tasks should be more error proof to use.
Fix Chromium build.
- wtf/TypeTraits.h: (WTF::IsConvertibleToInteger::IsConvertibleToDouble): Avoid "possible loss of data" warning when using Microsoft's C++ compiler by avoiding an implicit conversion of int types to doubles.
- 1:57 PM Changeset in webkit [40417] by
-
- 6 edits in trunk/WebCore
2009-01-30 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Add toRenderView methods for casting RenderObjects to RenderViews. The methods will assert if the object
is not a RenderView.
- dom/Document.cpp: (WebCore::Document::renderView):
- editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): (WebCore::SelectionController::recomputeCaretRect): (WebCore::SelectionController::invalidateCaretRect): (WebCore::SelectionController::focusedOrActiveStateChanged):
- editing/mac/SelectionControllerMac.mm: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::repaintLayerRectsForImage): (WebCore::RenderBox::availableHeightUsing):
- rendering/RenderView.h: (WebCore::toRenderView):
- 1:48 PM Changeset in webkit [40416] by
-
- 2 edits in trunk/WebCore
2009-01-30 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Really use the container-relative repaint rect methods
for repaint during layout
- rendering/RenderObject.h: (WebCore::RenderObject::LayoutRepainter::LayoutRepainter):
- 1:47 PM Changeset in webkit [40415] by
-
- 6 edits in trunk/WebCore
2009-01-30 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Get rid of PrivateIdentifier and use IdentifierRep instead.
- bridge/NP_jsobject.cpp: (_NPN_Invoke): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod):
- bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::getPropertyNames):
- bridge/c/c_utility.cpp: (JSC::Bindings::convertNPStringToUTF16):
- bridge/c/c_utility.h:
- bridge/npruntime.cpp: (_NPN_GetStringIdentifier): (_NPN_GetStringIdentifiers): (_NPN_GetIntIdentifier): (_NPN_IdentifierIsString): (_NPN_UTF8FromIdentifier): (_NPN_IntFromIdentifier):
- 1:25 PM Changeset in webkit [40414] by
-
- 3 edits in trunk/WebCore
2009-01-30 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig and Darin Adler.
Make IdentifierRep a real class, add necessary class methods.
- bridge/IdentifierRep.cpp: (WebCore::identifierSet): Returns a set of all identifiers.
(WebCore::IdentifierRep::isValid):
Return whether an identifier is valid, meaning that it's present in the
set of identifiers.
- bridge/IdentifierRep.h: (WebCore::IdentifierRep::isString): (WebCore::IdentifierRep::number): (WebCore::IdentifierRep::string): (WebCore::IdentifierRep::IdentifierRep): (WebCore::IdentifierRep::):
- 12:17 PM Changeset in webkit [40413] by
-
- 2 edits1 copy in trunk/LayoutTests
2009-01-30 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23650
LayoutTests/fast/dom/Window/timeout-released-on-close.html fails intermittently.
Disable this test to keep buildbots green. Need more time to investigate the cause.
- fast/dom/Window/timeout-released-on-close.html: Removed.
- fast/dom/Window/timeout-released-on-close.html-disabled: Copied from LayoutTests/fast/dom/Window/timeout-released-on-close.html.
- 11:57 AM Changeset in webkit [40412] by
-
- 7 edits2 adds in trunk/WebCore
2009-01-30 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add IdentifierRep which will be used by both plug-in implementations.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bridge/IdentifierRep.cpp: Added. (WebCore::IdentifierRep::IdentifierRep): (WebCore::IdentifierRep::): (WebCore::intIdentifierMap): (WebCore::identifierRep): (WebCore::stringIdentifierMap):
- bridge/IdentifierRep.h: Added.
- bridge/c/c_utility.h:
- platform/text/PlatformString.h:
- platform/text/String.cpp: (WebCore::String::fromUTF8WithLatin1Fallback):
- 11:55 AM Changeset in webkit [40411] by
-
- 13 edits in trunk/WebCore
2009-01-30 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Add toRenderInline methods for casting RenderObjects to RenderInlines. The methods will assert if the object
is not a RenderInline.
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::removeLineBoxFromRenderObject): (WebCore::InlineFlowBox::extractLineBoxFromRenderObject): (WebCore::InlineFlowBox::attachLineBoxToRenderObject): (WebCore::InlineFlowBox::rendererLineBoxes): (WebCore::InlineFlowBox::determineSpacingForFlowBoxes): (WebCore::InlineFlowBox::paint):
- rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::addFocusRingRects):
- rendering/RenderBox.cpp: (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeRectForRepaint): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
- rendering/RenderInline.cpp: (WebCore::RenderInline::inlineContinuation): (WebCore::nextContinuation): (WebCore::RenderInline::splitInlines):
- rendering/RenderInline.h: (WebCore::toRenderInline):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::boundingBox):
- rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
- rendering/RenderText.h:
- rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
- rendering/bidi.cpp: (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::layoutInlineChildren):
- 10:20 AM Changeset in webkit [40410] by
-
- 2 edits in trunk/WebCore
2009-01-30 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23647
Fix PLATFORM(SKIA)'s ImageSource::clear method to match other ports
- platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::clear):
- 10:16 AM Changeset in webkit [40409] by
-
- 18 edits in trunk/WebCore
2009-01-30 David Hyatt <hyatt@apple.com>
Add toRenderBlock methods for casting RenderObjects to RenderBlocks. The methods will assert if the object
is not a RenderBlock. Also add a toRenderBlock method that takes a RenderBlock but returns void and that
is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderBlock.
Making this change caught a bad cast in RenderBlock::layoutBlockChildren, so that is also fixed by this
patch with a containsFloats() check.
Reviewed by Darin Adler
- dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
- editing/Editor.cpp: (WebCore::Editor::hasBidiSelection):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::anchorElement): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::fillBlockSelectionGaps): (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout): (WebCore::RenderBlock::firstLineBlock): (WebCore::getLineAtIndex): (WebCore::getHeightForLineCount): (WebCore::RenderBlock::lineCount): (WebCore::RenderBlock::adjustForBorderFit): (WebCore::RenderBlock::clearTruncation):
- rendering/RenderBlock.h: (WebCore::toRenderBlock):
- rendering/RenderBox.cpp: (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeRectForRepaint): (WebCore::RenderBox::calcReplacedHeightUsing):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderInline.cpp: (WebCore::RenderInline::inlineContinuation): (WebCore::nextContinuation): (WebCore::RenderInline::positionForCoordinates):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout):
- rendering/RenderListItem.cpp: (WebCore::getParentOfFirstLineBox): (WebCore::RenderListItem::positionListMarker):
- rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::computeRectForRepaint): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::getTextDecorationColors):
- rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): (WebCore::RenderTable::recalcSections):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::styleDidChange):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::block):
- rendering/bidi.cpp: (WebCore::RenderBlock::createLineBoxes):
- 9:30 AM Changeset in webkit [40408] by
-
- 10 edits in trunk
WebCore:
2009-01-30 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
- Let CachedFrame handle the suspending/resuming of active DOM objects itself instead of relying on some outside force.
- Clear the previous history item inside FrameLoader instead of relying on multiple FrameLoaderClients to do it.
- history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Suspend active DOM objects here. (WebCore::CachedFrame::restore): Resume those DOM objects here.
- history/CachedFrame.h: (WebCore::CachedFrame::domWindow):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): Let CachedFrame creation handle the suspending of active DOM objects. (WebCore::FrameLoader::open): Let CachedFrame::restore() handle resuming those DOM objects. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Call frameLoadCompleted() instead of performing a client call by itself. (WebCore::FrameLoader::frameLoadCompleted):
WebKit/mac:
2009-01-30 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Remove FrameLoaderClient code that is now handled by FrameLoader itself
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoadCompleted):
WebKit/qt:
2009-01-30 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Remove FrameLoaderClient code that is now handled by FrameLoader itself
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::frameLoadCompleted):
WebKit/win:
2009-01-30 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Remove FrameLoaderClient code that is now handled by FrameLoader itself
- WebFrame.cpp: (WebFrame::frameLoadCompleted):
- 9:13 AM Changeset in webkit [40407] by
-
- 1 edit3 adds in trunk/LayoutTests
Reviewed by Darin Adler.
Test that documents loaded from application cache cannot load local resources.
- http/tests/appcache/local-content-expected.txt: Added.
- http/tests/appcache/local-content.html: Added.
- http/tests/appcache/resources/local-content.manifest: Added.
- 9:11 AM Changeset in webkit [40406] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/6448823> Application Cache is kept after a private browsing session
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::update): Cache update will not be started if private browsing is enabled. Existing cache version from disk database will be used.
- loader/appcache/ApplicationCacheGroup.h: Made postListenerTask() static, in order to call it when refusing to update from selectCache().
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addDynamicEntry): (WebCore::ApplicationCache::removeDynamicEntry): Added reminders about private browsing to unimplemented methods.
- 9:06 AM Changeset in webkit [40405] by
-
- 3 edits in trunk/LayoutTests
2009-01-30 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=23615
Try to make this test reliable on buildbots.
- fast/dom/Window/resources/long_timeout.html: Allocate more objects to make detection more reliable.
- fast/dom/Window/timeout-released-on-close.html: Use threshold to account for objects allocated by the running scripts. Add debug output in case of failure to help understand possible failures.
- 7:17 AM Changeset in webkit [40404] by
-
- 6 edits in trunk
2009-01-30 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
Bug 23580: GNU mode RVCT compilation support
<https://bugs.webkit.org/show_bug.cgi?id=23580>
- 7:17 AM Changeset in webkit [40403] by
-
- 3 edits in trunk/WebKit/qt
2009-01-30 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Hide the Offline Web Application Cache path API from the public API
for now.
- 5:15 AM Changeset in webkit [40402] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=23639
Test that appcache ignores Cache-Control: no-store
- http/tests/resources/network-simulator.php: Send no-store with all responses.
- 5:13 AM Changeset in webkit [40401] by
-
- 2 edits4 adds in trunk/LayoutTests
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=23640
Test that non-HTML main resources work with application cache correctly
- http/tests/appcache/non-html-expected.txt: Added.
- http/tests/appcache/non-html.xhtml: Added.
- http/tests/appcache/resources/abe.png: Added.
- http/tests/appcache/resources/non-html.manifest: Added.
- http/tests/resources/network-simulator.php: Support more file extensions.
- 3:12 AM QtWebKitFeatures45 created by
- 2:48 AM QtWebKit edited by
- (diff)
- 12:38 AM Changeset in webkit [40400] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-30 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 23618: Templated worker tasks should be more error proof to use
<https://bugs.webkit.org/show_bug.cgi?id=23618>
Add the type traits needed for the generic worker tasks
and compile asserts for them.
Add a summary header to the TypeTraits.h file to explain what is in there.
Add a note to explain IsPod's deficiencies.
- wtf/TypeTraits.h:
- 12:34 AM Changeset in webkit [40399] by
-
- 9 edits2 adds in trunk
2009-01-30 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 23616: Various "template helpers" should be consolidated from isolated files in JavaScriptCore.
<https://bugs.webkit.org/show_bug.cgi?id=23616>
- wtf/TypeTraits.h: Moved RemovePointer, IsPod, IsInteger to this file.
- wtf/OwnPtr.h: Use RemovePointer from TypeTraits.h.
- wtf/RetainPtr.h: Ditto.
- wtf/HashTraits.h: Use IsInteger from TypeTraits.h.
- wtf/VectorTraits.h: Use IsPod from TypeTraits.h.
- GNUmakefile.am:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj: Added TypeTraits.h.
- 12:18 AM Changeset in webkit [40398] by
-
- 3 edits in trunk/WebCore
2009-01-30 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 23599: ResourceError needs to be copyable for use in another thread.
<https://bugs.webkit.org/show_bug.cgi?id=23599>
Add ResourceErrorBase::copy method. (Not yet used.)
- platform/network/ResourceErrorBase.cpp: (WebCore::ResourceErrorBase::copy):
- platform/network/ResourceErrorBase.h:
Jan 29, 2009:
- 10:40 PM Changeset in webkit [40397] by
-
- 6 edits in trunk
2009-01-29 Stephanie Lewis <Stephanie Lewis>
RS by Oliver Hunt.
Update the order files.
- JavaScriptCore.order:
- WebCore.order:
- WebKit.order:
- 7:09 PM Changeset in webkit [40396] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver Hunt.
Bug 23551: Crash on page load with profiler enabled and running
<https://bugs.webkit.org/show_bug.cgi?id=23551>
<rdar://problem/6529521>
Interpreter::execute(FunctionBodyNode*, ...) calls Profiler::didExecute()
with a stale CallFrame. If some part of the scope chain has already been
freed, Profiler::didExecute() will crash when attempting to get the lexical
global object. The fix is to make the didExecute() call use the caller's
CallFrame, not the one made for the function call. In this case, the
willExecute() call should also be changed to match.
Since this occurs in the actual inspector JS, it is difficult to reduce.
I couldn't make a layout test.
- interpreter/Interpreter.cpp: (JSC::Interpreter::execute):
- 6:54 PM Changeset in webkit [40395] by
-
- 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj
Fix mac bustage.
- 6:35 PM Changeset in webkit [40394] by
-
- 1 edit in trunk/WebKit/win/WebHistoryItem.cpp
Windows build fix
- 6:01 PM Changeset in webkit [40393] by
-
- 12 edits1 copy1 add in trunk/WebCore
2009-01-29 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
Make TimerBase thread-aware (for Workers).
Added new class ThreadTimers - it keeps a heap of all timers for a thread (previously kept in a static global).
Pointer to instance of ThreadTimers is stored in GlobalThreadData.
Most static methods of TimerBase went to ThreadTimers.
The TimerBase functionality did not change (it maintains the timer heap which computes the nearest firing).
Added new abstract class SharedTimer, so worker threads can provide their own implementation (will be implemented on WorkerRunLoop).
- GNUmakefile.am:
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl: Added new ThreadTimers.cpp to build files.
- platform/SharedTimer.h: (WebCore::SharedTimer::~SharedTimer): (WebCore::MainThreadSharedTimer::setFiredFunction): (WebCore::MainThreadSharedTimer::setFireTime): (WebCore::MainThreadSharedTimer::stop): Added abstract SharedTimer and MainThreadSharedTimer which redirects to the existing port-supplied functions.
- platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData): (WebCore::ThreadGlobalData::~ThreadGlobalData):
- platform/ThreadGlobalData.h: (WebCore::ThreadGlobalData::threadTimers): Added ThreadTimers to ThreadGlobalData.
- platform/ThreadTimers.cpp: Added. (WebCore::mainThreadSharedTimer): Static getter for a MainThreadSharedTimer singleton.
(WebCore::ThreadTimers::ThreadTimers):
(WebCore::ThreadTimers::setSharedTimer):
(WebCore::ThreadTimers::updateSharedTimer):
(WebCore::ThreadTimers::collectFiringTimers):
(WebCore::ThreadTimers::fireTimers):
(WebCore::ThreadTimers::sharedTimerFired):
(WebCore::ThreadTimers::sharedTimerFiredInternal):
(WebCore::ThreadTimers::fireTimersInNestedEventLoop):
ThreadTimers implementation. Most of the code is moved from previous static functions on TimerBase.
Need a new class so each thread may get ts own copy of the timer heap.
- platform/ThreadTimers.h: Added. (WebCore::ThreadTimers::timerHeap): (WebCore::ThreadTimers::timersReadyToFire):
- platform/Timer.cpp: (WebCore::timerHeap): (WebCore::timersReadyToFire): (WebCore::TimerHeapElement::TimerHeapElement): (WebCore::TimerHeapElement::checkConsistency): (WebCore::TimerHeapElement::operator=): (WebCore::TimerHeapIterator::checkConsistency): (WebCore::TimerBase::TimerBase): (WebCore::TimerBase::~TimerBase): (WebCore::TimerBase::isActive): (WebCore::TimerBase::checkHeapIndex): (WebCore::TimerBase::heapDelete): (WebCore::TimerBase::heapDeleteMin): (WebCore::TimerBase::heapInsert): (WebCore::TimerBase::heapPopMin): (WebCore::TimerBase::setNextFireTime): (WebCore::TimerBase::fireTimersInNestedEventLoop): Now instead of static timer heap these use accessor functions that pull thread-specific heap instance.
- platform/Timer.h: static methods moved to ThreadTimers.
- 5:56 PM Changeset in webkit [40392] by
-
- 2 edits in trunk/WebKit/win
2009-01-29 Sam Weinig <sam@webkit.org>
Fix Windows build
- WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation):
- 5:42 PM Changeset in webkit [40391] by
-
- 4 edits1 add in trunk/WebCore
2009-01-29 David Hyatt <hyatt@apple.com>
Beginning of work to eliminate RenderContainer and make containership "pluggable" into any spot in the render tree. The first step is to create
the new object that will handle children: RenderObjectChildList and move RenderContainer's member variables into it. Subsequent patches will begin
moving RenderContainer's functionality into RenderObjectChildList.
Reviewed by Eric Seidel
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::RenderContainer): (WebCore::RenderContainer::destroyLeftoverChildren): (WebCore::RenderContainer::addChild): (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::updateBeforeAfterContentForContainer): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode): (WebCore::RenderContainer::layout): (WebCore::RenderContainer::removeLeftoverAnonymousBlock): (WebCore::RenderContainer::positionForCoordinates): (WebCore::RenderContainer::addLineBoxRects): (WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
- rendering/RenderContainer.h: (WebCore::RenderContainer::firstChild): (WebCore::RenderContainer::lastChild): (WebCore::RenderContainer::firstChildBox): (WebCore::RenderContainer::lastChildBox):
- rendering/RenderObjectChildList.h: Added. (WebCore::RenderObjectChildList::RenderObjectChildList): (WebCore::RenderObjectChildList::firstChild): (WebCore::RenderObjectChildList::lastChild): (WebCore::RenderObjectChildList::setFirstChild): (WebCore::RenderObjectChildList::setLastChild):
- 5:37 PM Changeset in webkit [40390] by
-
- 1 edit in trunk/WebCore/rendering/RenderThemeSafari.cpp
Fix windows build bustage.
- 5:14 PM Changeset in webkit [40389] by
-
- 1 edit in trunk/WebCore/rendering/RenderThemeSafari.cpp
Fix windows build bustage.
- 4:48 PM Changeset in webkit [40388] by
-
- 4 edits in trunk/LayoutTests
2009-01-29 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22894
Fix typo in fill-stroke-clip-reset-path.html where
layoutTestController.setUseDashboardCompatiblityMode is called instead of
layoutTestController.setUseDashboardCompatibilityMode.
- fast/canvas/fill-stroke-clip-reset-path.html:
- platform/mac/fast/canvas/fill-stroke-clip-reset-path-expected.checksum:
- platform/mac/fast/canvas/fill-stroke-clip-reset-path-expected.png:
- 4:45 PM Changeset in webkit [40387] by
-
- 2 edits in trunk/WebCore
2009-01-29 Jungshik Shin <jshin@chromium.org>
Reviewed by Alexey Proskuryakov.
http://bugs.webkit.org/show_bug.cgi?id=23598
Replace smart-quotes in UTF-8 with ASCII double-quotes to avoid
the compilation error on CJK Windows
- wml/WMLTableElement.cpp: (WebCore::WMLTableElement::parseMappedAttribute):
- 4:42 PM Changeset in webkit [40386] by
-
- 3 edits in trunk/LayoutTests
2009-01-29 Hironori Bono <hbono@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=18835
Rebaseline a layout test that verifies the InsertLineBreakCommand() function
doesn't delete existing markers.
- platform/mac/editing/spelling/spelling-linebreak-expected.checksum:
- platform/mac/editing/spelling/spelling-linebreak-expected.png:
- 4:39 PM Changeset in webkit [40385] by
-
- 2 edits in trunk/WebCore
2009-01-29 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23627
Fix the PLATFORM(SKIA) build.
- svg/graphics/SVGPaintServer.cpp: (WebCore::SVGPaintServer::teardown):
- 4:34 PM Changeset in webkit [40384] by
-
- 4 edits in trunk
Reviewed by Darin Adler.
Remove <strong>/<em> tags when toggling bold/italic since IE inserts them instead of <b>/<i>
https://bugs.webkit.org/show_bug.cgi?id=23486
Test: editing/execCommand/toggle-styles.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::isHTMLStyleNode):
- 4:23 PM Changeset in webkit [40383] by
-
- 6 edits in trunk/WebCore
2009-01-29 Scott Violet <sky@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23625
Skia platform doesn't render text to a canvas or support clipping to an image buffer
Fixes two bugs in Skia rendering to a canvas:
. Text was not rendered at all. This is because we never properly
fixed up the alpha values. The fix is to create a layer when
rendering text to a layer.
. We were not honoring clipping to an image buffer.
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clipToImageBuffer):
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::PlatformContextSkia): (PlatformContextSkia::setDrawingToImageBuffer): (PlatformContextSkia::isDrawingToImageBuffer): (PlatformContextSkia::beginLayerClippedToImage): (PlatformContextSkia::restore): (PlatformContextSkia::applyClipFromImage):
- platform/graphics/skia/PlatformContextSkia.h:
- 4:19 PM Changeset in webkit [40382] by
-
- 7 edits in trunk/WebKit
WebKit/mac:
2009-01-29 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Second step in tracking the urls a HistoryItem was redirected through
Add SPI to access the array of redirect urls associated with a HistoryItem.
- History/WebHistoryItem.mm: (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem _redirectURLs]):
- History/WebHistoryItemPrivate.h:
WebKit/win:
2009-01-29 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Second step in tracking the urls a HistoryItem was redirected through
Add SPI to access the array of redirect urls associated with a HistoryItem.
- Interfaces/IWebHistoryItemPrivate.idl:
- WebHistoryItem.cpp: (WebHistoryItem::dictionaryRepresentation): (WebHistoryItem::redirectURLs):
- WebHistoryItem.h:
- 3:52 PM Changeset in webkit [40381] by
-
- 3 edits in trunk/WebKit/mac
2009-01-29 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Always activate the plug-in host process if we're in "modal mode" and are being told to activate.
- Plugins/Hosted/NetscapePluginHostProxy.h:
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::pluginHostDied): Call endModal here.
(WebKit::NetscapePluginHostProxy::applicationDidBecomeActive):
If we're modal, we should always bring the plug-in host process to the front.
(WebKit::NetscapePluginHostProxy::beginModal):
Add an observer for the NSApplicationWillBecomeActiveNotification callback.
(WebKit::NetscapePluginHostProxy::endModal):
Remove the observer.
- 3:48 PM Changeset in webkit [40380] by
-
- 10 edits in trunk
WebCore:
2009-01-29 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
First step in tracking the urls a HistoryItem was redirected through.
- WebCore.base.exp:
- history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::addRedirectURL): (WebCore::HistoryItem::redirectURLs): (WebCore::HistoryItem::setRedirectURLs):
- history/HistoryItem.h:
WebKit/mac:
2009-01-29 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
First step in tracking the urls a HistoryItem was redirected through.
- History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem dictionaryRepresentation]):
- Misc/WebNSDictionaryExtras.h:
- Misc/WebNSDictionaryExtras.m: (-[NSDictionary _webkit_arrayForKey:]): Add helper.
WebKit/win:
2009-01-29 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
First step in tracking the urls a HistoryItem was redirected through.
- WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation): (WebHistoryItem::dictionaryRepresentation):
- 3:43 PM Changeset in webkit [40379] by
-
- 7 edits4 adds in trunk
2009-01-29 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann, Eric Seidel.
Just transform the pattern directly instead of transforming the context fixes this
problem. Texts or strokes are no longer affected by transformations.
SVG pattern transformation/BoundingBox can cause ugly stroke thickness or text positions
https://bugs.webkit.org/show_bug.cgi?id=23472
Test: svg/custom/pattern-with-transformation.svg
- platform/graphics/Pattern.h: (WebCore::Pattern::setPatternSpaceTransform):
- platform/graphics/cairo/PatternCairo.cpp: (WebCore::Pattern::createPlatformPattern):
- platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
- platform/graphics/qt/PatternQt.cpp: (WebCore::Pattern::createPlatformPattern):
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
LayoutTest
Transformations on SVG patterns caused ugly drawings. The pattern is transformed
directly now. Texts or strokes are no longer affected by transformations.
- platform/mac/svg/custom/pattern-with-transformation-expected.checksum: Added.
- platform/mac/svg/custom/pattern-with-transformation-expected.png: Added.
- platform/mac/svg/custom/pattern-with-transformation-expected.txt: Added.
- svg/custom/pattern-with-transformation.svg: Added.
- 2:49 PM Changeset in webkit [40378] by
-
- 22 edits2 deletes in trunk/WebCore
2009-01-29 David Hyatt <hyatt@apple.com>
Move the line box list member out of RenderFlow and down into RenderBlock and RenderInline. Eliminate RenderFlow from the tree.
Reviewed by Sam Weinig
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/HTMLAnchorElement.cpp:
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::rendererLineBoxes): (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
- rendering/InlineFlowBox.h:
- rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::styleWillChange): (WebCore::RenderBlock::styleDidChange): (WebCore::RenderBlock::dirtyLineBoxes): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::setSelectionState): (WebCore::RenderBlock::avoidsFloats): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::calcInlinePrefWidths): (WebCore::RenderBlock::baselinePosition): (WebCore::RenderBlock::getBaselineOfFirstLineBox): (WebCore::RenderBlock::getBaselineOfLastLineBox): (WebCore::RenderBlock::rectWithOutlineForRepaint): (WebCore::RenderBlock::hoverAncestor): (WebCore::RenderBlock::updateDragState):
- rendering/RenderBlock.h: (WebCore::RenderBlock::lineBoxes): (WebCore::RenderBlock::firstLineBox): (WebCore::RenderBlock::lastLineBox):
- rendering/RenderBox.cpp: (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeRectForRepaint): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
- rendering/RenderBox.h:
- rendering/RenderFlow.cpp: Removed.
- rendering/RenderFlow.h: Removed.
- rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::destroy): (WebCore::RenderInline::styleDidChange): (WebCore::RenderInline::addChildIgnoringContinuation): (WebCore::RenderInline::cloneInline): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::offsetLeft): (WebCore::RenderInline::offsetTop): (WebCore::RenderInline::positionForCoordinates): (WebCore::RenderInline::rectWithOutlineForRepaint): (WebCore::RenderInline::updateDragState): (WebCore::RenderInline::relativePositionedInlineOffset):
- rendering/RenderInline.h: (WebCore::RenderInline::lineBoxes): (WebCore::RenderInline::firstLineBox): (WebCore::RenderInline::lastLineBox):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
- rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::rendererLineBoxes):
- rendering/RootInlineBox.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::createLineBoxes):
- wml/WMLAElement.cpp:
- 2:38 PM Changeset in webkit [40377] by
-
- 6 edits in trunk/WebKit/mac
2009-01-29 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Pass the PSN of the client to the host, and get the PSN of the host back when checking in.
- Plugins/Hosted/NetscapePluginHostManager.h:
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPackage): Get the current PSN and pass it to spawnPluginHost.
(WebKit::NetscapePluginHostManager::spawnPluginHost):
Pass the PSN to the "check in" function.
- Plugins/Hosted/NetscapePluginHostProxy.h:
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::pluginHostDied):
Fix a bug noticed by Julien Chaffraix. Call endModal if necessary.
(WebKit::NetscapePluginHostProxy::beginModal):
(WebKit::NetscapePluginHostProxy::endModal):
(WebKit::NetscapePluginHostProxy::setModal):
Split out the code that does all of the work into beginModal and endModal methods.
- Plugins/Hosted/WebKitPluginHost.defs:
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView loadStream]):
- 2:05 PM Changeset in webkit [40376] by
-
- 2 edits in trunk/WebCore
2009-01-29 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Cleaned up some naming in ScheduledRedirection.
- loader/FrameLoader.cpp: (WebCore::ScheduledRedirection::ScheduledRedirection):
- 2:03 PM Changeset in webkit [40375] by
-
- 2 edits in trunk/WebCore
2009-01-29 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Update to use new API.
- platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::createFontCustomPlatformData):
- 1:53 PM Changeset in webkit [40374] by
-
- 2 edits in trunk/WebCore
Reviewed by Nikolas Zimmermann.
https://bugs.webkit.org/show_bug.cgi?id=23619
ASSERT(!error.isNull()) in DocumentLoader::mainReceivedError() when an SVG image load
is cancelled
Covered by existing tests (as a random crash).
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::cancelledError): (WebCore::EmptyFrameLoaderClient::blockedError): (WebCore::EmptyFrameLoaderClient::cannotShowURLError): (WebCore::EmptyFrameLoaderClient::interruptForPolicyChangeError): (WebCore::EmptyFrameLoaderClient::cannotShowMIMETypeError): (WebCore::EmptyFrameLoaderClient::fileDoesNotExistError): (WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError): Create non-null errors.
- 1:48 PM Changeset in webkit [40373] by
-
- 2 edits in trunk/WebCore
2009-01-29 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed an unused case of "lockHistory" to help make the other cases
clearer.
- page/FrameLoadRequest.h: (WebCore::FrameLoadRequest::FrameLoadRequest):
- 1:39 PM Changeset in webkit [40372] by
-
- 8 edits in trunk/WebCore
2009-01-29 David Hyatt <hyatt@apple.com>
Move all of the contination insertion code from RenderFlow to RenderInline. addChildToFlow is renamed to addChildIgnoringContinuation, and it has been moved to
RenderContainer so that it can still be called on either blocks or inlines. The base class implementation in RenderContainer is what RenderBlock uses. RenderInline
subclasses it to do all the work it used to do in addChildToFlow.
RenderBlock's old addChildToFlow can just become addChild. This simplification is possible because addChild was actually never being called on anonymous
block continuations.
The code dealing with anonymous table parts in the old addChildWithContinuation method can now be removed as a result with no harmful side effects. Falling through to the
base class and ignoring a block continuation makes the right thing happen.
addChildWithContinuation moved to RenderInline and has been renamed to addChildToContinuation.
Reviewed by Eric Seidel
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChild):
- rendering/RenderBlock.h:
- rendering/RenderContainer.h: (WebCore::RenderContainer::addChildIgnoringContinuation):
- rendering/RenderFlow.cpp:
- rendering/RenderFlow.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::styleDidChange): (WebCore::RenderInline::addChild): (WebCore::nextContinuation): (WebCore::RenderInline::continuationBefore): (WebCore::RenderInline::addChildIgnoringContinuation): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::addChildToContinuation): (WebCore::RenderInline::childBecameNonInline):
- rendering/RenderInline.h: (WebCore::RenderInline::continuation): (WebCore::RenderInline::setContinuation):
- 1:37 PM Changeset in webkit [40371] by
-
- 3 edits3 adds in trunk
WebCore:
2009-01-29 Brady Eidson <beidson@apple.com>
Reviewed by Oliver Hunt
<rdar://problem/6337157> hyundaiusa.com closes window or tab during load
Test: fast/loader/subframe-self-close.html
- page/DOMWindow.cpp: (WebCore::DOMWindow::close): Only allow mainframes to close the window.
LayoutTests:
2009-01-29 Brady Eidson <beidson@apple.com>
Reviewed by Oliver Hunt
<rdar://problem/6337157> hyundaiusa.com closes window or tab during load
- fast/loader/resources/subframe-self-close.html: Added.
- fast/loader/subframe-self-close-expected.txt: Added.
- fast/loader/subframe-self-close.html: Added.
- 1:23 PM Changeset in webkit [40370] by
-
- 23 edits in trunk/WebCore
Reviewed by David Hyatt.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=23539
Remove several virtual functions from Node & Element related to form control / input elements,
that shouldn't reside there, but move to approriate locations, in the new form control /
input element abstract base classes.
Remove the isControl() method from Node, as it's redundant - isFormControlElement() provides the same information.
Move isEnabled( / isReadOnlyControl() / isTextControl() from Node to FormControlElement.
Move isAutofilled() / isChecked() / isIndeterminate() from Node to InputElement.
Move isInputTypeHidden() / isPasswordField() from Element to InputElement.
Querying these methods requires using the toInputElement/toFormControlElement casting helper functions
to cast Element pointers to InputElement/FormControlElement pointers.
- 1:19 PM Changeset in webkit [40369] by
-
- 2 edits in trunk/WebCore
Not reviewed. Fix WML build - apply same fix as HTMLAnchorElement received.
- 12:57 PM BuildingQtOnLinux edited by
- (diff)
- 12:40 PM Changeset in webkit [40368] by
-
- 6 edits7 adds in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=23620
Crash in appcache/resource-redirect.html on Tiger
There was a bug in the test case - it didn't send a Location header, and on Tiger, this
resulted in a failure callback being sent. It turned out that proper redirects weren't
caught at all.
Tests: http/tests/appcache/manifest-redirect-2.html
http/tests/appcache/resource-redirect-2.html
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFail): Fixed this function to not crash if didReceiveResponse() wasn't called for this request. (WebCore::ApplicationCacheGroup::didReceiveResponse): Fixed to check for redirects correctly. (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Ditto.
- 11:36 AM Changeset in webkit [40367] by
-
- 7 edits in trunk/WebCore
2009-01-29 David Hyatt <hyatt@apple.com>
Move dirtyLinesFromChangedChild into RenderLineBoxList so that it can be shared by RenderBlock and RenderInline.
Reviewed by Sam Weinig
- rendering/RenderBlock.h: (WebCore::RenderBlock::dirtyLinesFromChangedChild):
- rendering/RenderFlow.cpp:
- rendering/RenderFlow.h:
- rendering/RenderInline.h: (WebCore::RenderInline::dirtyLinesFromChangedChild):
- rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
- rendering/RenderLineBoxList.h:
- 11:21 AM Changeset in webkit [40366] by
-
- 11 edits in trunk
Fix Bug 23623: Windowed Flash instances aren't captured when a WebView receives a WM_PRINTCLIENT message
WebCore:
Fix Bug 23623: Windowed Flash instances aren't captured when a WebView
receives a WM_PRINTCLIENT message
<https://bugs.webkit.org/show_bug.cgi?id=23623>
<rdar://problem/6513921>
<rdar://problem/6536874>
Flash doesn't seem to respond to WM_PRINTCLIENT, so we change
WM_PRINTCLIENT messages into WM_PAINT messages and hook into the
BeginPaint/EndPaint APIs to return the HDC we received from
WM_PRINTCLIENT. This causes the plugin to paint into the
WM_PRINTCLIENT HDC via its normal WM_PAINT handler. This technique
came from <http://www.fengyuan.com/article/wmprint.html>.
No test possible.
Reviewed by Darin Adler.
- platform/graphics/GraphicsContext.h: Added [set]ShouldIncludeChildWindows on Windows.
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: Added m_shouldIncludeChildWindows. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): Initialize the new member.
- platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::setShouldIncludeChildWindows): (WebCore::GraphicsContext::shouldIncludeChildWindows): Added simple setter and getter.
- plugins/PluginView.cpp: (WebCore::PluginView::PluginView): Initialize the new member.
- plugins/PluginView.h: Added m_wmPrintHDC and various functions required for making WM_PRINTCLIENT work.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::hookedBeginPaint): (WebCore::PluginView::hookedEndPaint): (WebCore::hook): (WebCore::setUpOffscreenPaintingHooks): Added. Code was modified from code available on fengyuan.com.
(WebCore::PluginView::wndProc): Turn WM_PRINTCLIENT messages into
WM_PAINT messages and save off the HDC that we're supposed to paint
into.
(WebCore::PluginView::paintWindowedPluginIntoContext): Added. Gets an
HDC from the GraphicsContext, translates it into client coordinates,
gets the plugin to draw into the HDC by sending a WM_PRINTCLIENT
message, and returns the HDC to the GraphicsContext.
(WebCore::PluginView::paint): If we're trying to paint a windowed
plugin into the GraphicsContext, call paintWindowedPluginIntoContext.
(WebCore::PluginView::init): Call setUpOffscreenPaintingHooks to make
our WM_PRINTCLIENT trick work.
WebKit/win:
Fix Bug 23623: Windowed Flash instances aren't captured when a WebView
receives a WM_PRINTCLIENT message
<https://bugs.webkit.org/show_bug.cgi?id=23623>
<rdar://problem/6513921>
<rdar://problem/6536874>
Reviewed by Darin Adler.
- WebFrame.cpp: (WebFrame::paintDocumentRectToContext): (WebFrame::spoolPages): Call GraphicsContext::setShouldIncludeChildWindows so that child windows will be painted into the GraphicsContext rather than painted directly to the screen.
- WebView.cpp: (WebView::updateBackingStore): Added a windowsToPaint parameter, which we pass along to paintIntoBackingStore.
(WebView::paint): Tell updateBackingStore to paint child windows if
we're not painting to the screen.
(WebView::paintIntoBackingStore): Added a windowsToPaint paramter,
which we use to tell our GraphicsContext whether or not to include
child windows.
- WebView.h: Added windowsToPaint parameters to paintIntoBackingStore and updateBackingStore (which I also made private).
- 11:20 AM Changeset in webkit [40365] by
-
- 2 edits in trunk/WebKit/win
Build fix after r40353
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::loadURLIntoChild): Removed the check for FrameLoadTypeReloadAllowingStaleData.
- 10:00 AM Changeset in webkit [40364] by
-
- 5 edits in trunk/WebCore
2009-01-29 David Hyatt <hyatt@apple.com>
Move RenderFlow::destroy down into RenderBlock and RenderInline.
Reviewed by Anders Carlsson
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::destroy):
- rendering/RenderFlow.cpp:
- rendering/RenderFlow.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::destroy):
- 7:46 AM Changeset in webkit [40363] by
-
- 18 edits in trunk
Remove semi-colons from the end of ObjC method implementations
Rubber-stamped by Adam Roben.
WebCore:
$ find WebCore -name \*.m -o -name \*.mm -exec perl -e 'undef $/; $s = <>; while ($s =~ m/[\n\r][-+].*;[\s\r\n]+\{/g) { print "$ARGV: $&\n"; }' {} \;
- bridge/testbindings.mm:
WebKit/mac:
$ find WebKit -name \*.m -o -name \*.mm -exec perl -e 'undef $/; $s = <>; while ($s =~ m/[\n\r][-+].*;[\s\r\n]+\{/g) { print "$ARGV: $&\n"; }' {} \;
- DefaultDelegates/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:setResizable:]): (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]): (-[WebDefaultUIDelegate webView:dragSourceActionMaskForPoint:]): (-[WebDefaultUIDelegate webView:willPerformDragSourceAction:fromPoint:withPasteboard:]):
- History/WebBackForwardList.mm: (-[WebBackForwardList addItem:]): (-[WebBackForwardList backListWithLimit:]): (-[WebBackForwardList forwardListWithLimit:]):
- History/WebHistoryItem.mm: (-[WebHistoryItem alternateTitle]): (-[WebHistoryItem setViewState:]):
- Misc/WebCoreStatistics.mm: (+[WebCoreStatistics garbageCollectJavaScriptObjectsOnAlternateThreadForDebugging:]):
- Misc/WebKitNSStringExtras.m: (-[NSString _web_drawAtPoint:font:textColor:]):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setAttributeKeys:andValues:]):
- WebCoreSupport/WebEditorClient.mm: (-[WebEditCommand command]):
- WebView/WebFrame.mm: (-[WebFrame _getVisibleRect:]):
- WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation _redirectDataToManualLoader:forPluginView:]):
- WebView/WebHTMLView.mm: (-[WebHTMLView elementAtPoint:allowShadowContent:]):
- WebView/WebPreferences.mm: (-[WebPreferences setAllowsAnimatedImages:]): (-[WebPreferences setAutosaves:]): (-[WebPreferences PDFDisplayMode]):
- WebView/WebView.mm: (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): (-[WebView _viewClass:andRepresentationClass:forMIMEType:]): (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]): (+[WebView _registerViewClass:representationClass:forURLScheme:]): (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[WebView _insertNewlineInQuotedContent]):
WebKitTools:
$ find WebKitTools -name \*.m -o -name \*.mm -exec perl -e 'undef $/; $s = <>; while ($s =~ m/[\n\r][-+].*;[\s\r\n]+\{/g) { print "$ARGV: $&\n"; }' {} \;
- DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]): (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webViewFrame:]):
- 6:35 AM Changeset in webkit [40362] by
-
- 2 edits in trunk/WebCore
2009-01-29 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=23609
Use the two-arg constructor for implicit QUrl->KURL conversion as the
single argument ctors assume that KURL::parse has already been called
and assert if the parse results in a different string. This was causing
an assert for QUrl's with no path and without a trailing slash.
- platform/qt/KURLQt.cpp: (WebCore::KURL::KURL):
- 5:09 AM Changeset in webkit [40361] by
-
- 3 edits in trunk/WebKit/wx
Build fix for Wx: Finish de-RefCount-ing FrameLoaderClientWx
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::ref): Removed. (WebCore::FrameLoaderClientWx::deref): Removed.
- WebKitSupport/FrameLoaderClientWx.h: Ditto.
- 4:48 AM Changeset in webkit [40360] by
-
- 5 edits in trunk/WebCore
Rubber-stamped by Darin Adler.
Renamed ApplicationCacheResource::Implicit to Master, because that's the word HTML5 uses,
and it describes the meaning better.
- 1:58 AM Changeset in webkit [40359] by
-
- 3 edits in trunk/LayoutTests
Not reviewed (this was just a merge problem).
https://bugs.webkit.org/show_bug.cgi?id=23476
HTTP redirect should make application cache updating fail
- http/tests/appcache/manifest-redirect.html:
- http/tests/appcache/resource-redirect.html: Updated the tests to work with the new appcache event sending behavior.
- 1:27 AM Changeset in webkit [40358] by
-
- 2 edits in trunk/WebCore
Release build fix.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): Got rid of a variable that wasn't used in release builds.
- 12:50 AM Changeset in webkit [40357] by
-
- 4 edits in trunk/WebCore
2009-01-29 David Hyatt <hyatt@apple.com>
Get rid of createAnonymousFlow. It was only called in one spot, so just inline the code.
Reviewed by Oliver Hunt
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderFlow.cpp:
- rendering/RenderFlow.h:
- 12:35 AM Changeset in webkit [40356] by
-
- 3 edits7 adds in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=23476
HTTP redirect should make application cache updating fail
Tests: http/tests/appcache/manifest-redirect.html
http/tests/appcache/resource-redirect.html
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Fail if response code isn't 2xx.
- 12:32 AM Changeset in webkit [40355] by
-
- 6 edits3 adds in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=23592
Update appcache manifest signature parsing
Test: http/tests/appcache/wrong-signature-2.html
WebCore:
- loader/appcache/ManifestParser.cpp: (WebCore::parseManifest): Allow comments on signature line. Removed code that replaced nulls with 0xFFFD characters, because there is no such requirement in the spec.
LayoutTests:
- http/tests/appcache/manifest-parsing.html: Fixed to point to a correct manifest (oops).
- http/tests/appcache/resources/manifest-parsing.manifest: Added a comment at the end of signature line.
- http/tests/appcache/resources/wrong-signature-2.manifest: Added.
- http/tests/appcache/wrong-signature-2-expected.txt: Added.
- http/tests/appcache/wrong-signature-2.html: Added.
- http/tests/appcache/wrong-signature.html: Test that there must be whitespace before the comment.
- 12:26 AM Changeset in webkit [40354] by
-
- 24 edits in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=23584
Update application cache code for the latest round of spec changes
The changes mostly affect the update process - events are sent at a different
time, and caches are associated with documents earlier.
WebCore:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainReceivedError): Changed an always passing test to an assertion. (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache): Caches are now associated with DocumentLoader before being complete, but they only affect loading after being completed. (WebCore::DocumentLoader::getApplicationCacheFallbackResource): Ditto.
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::setGroup): Allow setting the group to the same one, to simplify ApplicationCacheGroup code. (WebCore::ApplicationCache::isComplete): A new method that tells whether the cache is complete, as defined in HTML5.
- loader/appcache/ApplicationCache.h: Added isComplete().
- loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheUpdateOption): Per HTML5, cache updating should work differently when invoked with or without a browsing context (Frame). A Frame is currently always needed for updating in WebKit, so a new argument to update() tells whether we should pretend that there isn't one. (WebCore::ApplicationCacheGroup::cacheIsBeingUpdated): A helper for ApplicationCache::isComplete(). (WebCore::ApplicationCacheGroup::CompletionType): Cache update algorithm now waits for ne main resources to finish loading in more cases. A member variable of this type is used to distinguish between different cases when waiting. (WebCore::ApplicationCacheGroup::m_cacheCandidates): The new algorithm doesn't track cache candidates. Caches are associated with documents much earlier, but the ones whose main resources have not been loaded from a cache are being tracked in a pending master entry list.
- loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::update): An explicit call to update() invokes the algorithm without a browsing context.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::failedLoadingMainResource): (WebCore::ApplicationCacheGroup::stopLoading): (WebCore::ApplicationCacheGroup::disassociateDocumentLoader): (WebCore::ApplicationCacheGroup::cacheDestroyed): (WebCore::ApplicationCacheGroup::setNewestCache): (WebCore::ApplicationCacheGroup::update): (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didFinishLoading): (WebCore::ApplicationCacheGroup::didFail): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::cacheUpdateFailed): (WebCore::ApplicationCacheGroup::manifestNotFound): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): (WebCore::ApplicationCacheGroup::startLoadingEntry): (WebCore::ApplicationCacheGroup::deliverDelayedMainResources): (WebCore::ApplicationCacheGroup::addEntry): (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): (WebCore::CallCacheListenerTask::create): (WebCore::CallCacheListenerTask::performTask): (WebCore::CallCacheListenerTask::CallCacheListenerTask): (WebCore::ApplicationCacheGroup::postListenerTask): Rewrote the update algorithm.
LayoutTests:
- http/tests/appcache/404-manifest.html:
- http/tests/appcache/404-resource.html: When initial cache attempt fails, the applicationCache singleton now gets an error event.
- http/tests/appcache/foreign-iframe-main-expected.txt: Checking, downloading and progress events are now dispatched during initial cache attempt.
- http/tests/appcache/idempotent-update-expected.txt:
- http/tests/appcache/idempotent-update.html: Events are now posted asynchronously, so we cannot assume any status when handling an event. Rewrote the test to no longer rely on synchronous event dispatch.
- http/tests/appcache/manifest-containing-itself.html: Changed the test to pass on reload, to simplify testing in browser (not related to any behavior changes).
- http/tests/appcache/navigating-away-while-cache-attempt-in-progress.html: Fixed the test to not fail in browser due to missing layoutTestController.
- http/tests/appcache/offline-access-expected.txt:
- http/tests/appcache/offline-access.html: Removed a warning saying that output is timing dependent - I think this is not true now.
- http/tests/appcache/remove-cache-expected.txt:
- http/tests/appcache/remove-cache.html:
- http/tests/appcache/resources/remove-cache-frame-2.html:
- http/tests/appcache/resources/remove-cache-frame.html: An obsolete event is only dispatched if the document's main resource was already in cache, otherwise, an error event is dispatched. Changed the test to add the main resource to cache first. Also, updated it to make use of additional events that are now being posted.
- http/tests/appcache/resources/offline-access-frame.html: Updated to dump frame events more completely.
- http/tests/appcache/wrong-content-type.html:
- http/tests/appcache/wrong-signature.html: Changed to expect and to make use of error event that is now being posted.
Jan 28, 2009:
- 11:38 PM Changeset in webkit [40353] by
-
- 9 edits in trunk
WebCore:
2009-01-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Merged FrameLoadTypeReloadAllowingStaleData with FrameLoadTypeReload.
Technically, selecting View->Text Encoding->[Non-Default Encoding] on
a page with frames may now be slightly slower than it used to be. Oh well.
- loader/FrameLoader.cpp: (WebCore::isBackForwardLoadType): (WebCore::FrameLoader::restoreDocumentState): Subbed in FrameLoadTypeReload.
(WebCore::FrameLoader::loadURLIntoChildFrame): No need to account for
non-back-forward navigations anymore.
(WebCore::FrameLoader::canCachePage):
(WebCore::FrameLoader::logCanCachePageDecision):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::loadItem): Subbed in FrameLoadTypeReload.
- loader/FrameLoader.h: Renamed reloadAllowingStaleData => reloadWithOverrideEncoding, since that's what it actually does.
WebKit/mac:
2009-01-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Updated for WebCore rename.
- WebView/WebView.mm: (-[WebView setCustomTextEncodingName:]):
WebKit/win:
2009-01-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Updated for WebCore rename.
- WebView.cpp: (WebView::setCustomTextEncodingName):
- 10:55 PM Changeset in webkit [40352] by
-
- 7 edits in trunk/WebCore
2009-01-28 David Hyatt <hyatt@apple.com>
Move hit testing and painting of lines from RenderFlow into RenderLineBoxList.
Reviewed by Oliver Hunt
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::hitTestContents):
- rendering/RenderFlow.cpp:
- rendering/RenderFlow.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::paint): (WebCore::RenderInline::nodeAtPoint):
- rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint): (WebCore::RenderLineBoxList::hitTest):
- rendering/RenderLineBoxList.h:
- 10:38 PM Changeset in webkit [40351] by
-
- 4 edits in trunk
Versioning.
- 10:24 PM Changeset in webkit [40350] by
-
- 1 copy in branches/Safari-6528
New branch.
- 9:59 PM Changeset in webkit [40349] by
-
- 4 edits in branches/Safari-3-2-branch
Versioning.
- 9:58 PM Changeset in webkit [40348] by
-
- 1 copy in tags/Safari-5525.28.2
New tag.
- 8:41 PM Changeset in webkit [40347] by
-
- 2 edits in trunk/WebCore
2009-01-28 David Hyatt <hyatt@apple.com>
Fix SVG pixel test regressions. I wish I could say that I understand this fix, but I don't. For
some reason the original code returned 0 for RenderSVGInlineText::yPos() and somehow my literal
replacement of yPos() with the body of that method changed the results. I am completely baffled,
but all SVG pixel tests pass again when I just take the code out.
Reviewed by Oliver Hunt
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
- 7:53 PM Changeset in webkit [40346] by
-
- 2 edits in trunk/WebKit/mac
Add missing declaration for -[NSURL(WebNSURLExtras) _webkit_isFileURL]
Reviewed by Dan Bernstein.
- Misc/WebNSURLExtras.h: (-[NSURL(WebNSURLExtras) _webkit_isFileURL]): Added missing declaration after the implementation was added in r9258.
- 6:24 PM Changeset in webkit [40345] by
-
- 4 edits in trunk
2009-01-28 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Fix for <rdar://problem/6525537>
Hang occurs when closing Installer window (iTunes, Aperture)
- JavaScriptCore.exp: Export JSGlobalData::sharedInstance.
JavaScriptGlue:
2009-01-28 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Fix for <rdar://problem/6525537>
Hang occurs when closing Installer window (iTunes, Aperture)
- JSUtils.cpp: (getThreadGlobalObject): Use the shared JSGlobalData instance.
- 6:11 PM Changeset in webkit [40344] by
-
- 9 edits in trunk/WebCore
2009-01-28 David Hyatt <hyatt@apple.com>
Move dirtyLineBoxes from RenderFlow to RenderInline and RenderBlock.
Reviewed by Oliver Hunt
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::dirtyLineBoxes):
- rendering/RenderBlock.h:
- rendering/RenderFlow.cpp:
- rendering/RenderFlow.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::dirtyLineBoxes):
- rendering/RenderInline.h:
- rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::dirtyLineBoxes):
- rendering/RenderLineBoxList.h:
- 5:50 PM Changeset in webkit [40343] by
-
- 2 edits in trunk/WebCore
2009-01-28 David Hyatt <hyatt@apple.com>
Back out my change to scrollWidth/Height from an earlier checkin since it broke stuff. The current
behavior is not correct, but this will need to be investigated before being changed again.
- rendering/RenderBox.cpp: (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):
- 5:33 PM Changeset in webkit [40342] by
-
- 9 edits in trunk/WebCore
2009-01-28 David Hyatt <hyatt@apple.com>
Move paintOutline and paintOutlineWithLine from RenderFlow to RenderInline, since they only apply to inlines. Tighten up all of the code that
called paintOutline to use RenderInline as the type instead of RenderFlow.
Reviewed by cpst
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::addContinuationWithOutline): (WebCore::RenderBlock::paintContinuationOutlines):
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines):
- rendering/RenderFlow.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline): (WebCore::RenderInline::paintOutlineForLine):
- rendering/RenderInline.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):
- rendering/RenderObject.h: (WebCore::RenderObject::PaintInfo::PaintInfo):
- 4:49 PM Changeset in webkit [40341] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-01-28 Darin Fisher <darin@chromium.org>
Fixing bustage.
https://bugs.webkit.org/show_bug.cgi?id=18835
Add missing layout test results.
- platform/mac/editing/spelling/spelling-linebreak-expected.checksum: Added.
- platform/mac/editing/spelling/spelling-linebreak-expected.png: Added.
- platform/mac/editing/spelling/spelling-linebreak-expected.txt: Added.
- 4:34 PM Changeset in webkit [40340] by
-
- 4 edits in trunk
Versioning.
- 4:26 PM Changeset in webkit [40339] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-28 Sam Weinig <sam@webkit.org>
Reviewed by Geoff Garen.
Initial patch by Mark Rowe.
<rdar://problem/6519356>
REGRESSION (r36006): "out of memory" alert running dromaeo on Windows
Report the cost of the ArrayStorage vector more accurately/often.
- runtime/JSArray.cpp: (JSC::JSArray::JSArray): Report the extra cost even for a filled array because JSString using the single character optimization and immediates wont increase the cost themselves. (JSC::JSArray::putSlowCase): Update the cost when increasing the size of the array. (JSC::JSArray::increaseVectorLength): Ditto.
- 4:11 PM Changeset in webkit [40338] by
-
- 1 copy in tags/Safari-6528.11
New tag.
- 4:01 PM Changeset in webkit [40337] by
-
- 2 edits in trunk/WebCore
2009-01-28 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23596
XMLHttpRequest.cpp no longer compiles without USE(JSC)
- 3:59 PM Changeset in webkit [40336] by
-
- 2 edits in trunk/WebCore
2009-01-28 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23597
Make it possible to compile Database.cpp when USE(JSC) is not defined
- storage/Database.cpp: (WebCore::Database::Database):
- 3:49 PM Changeset in webkit [40335] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix <rdar://problem/6077047> REGRESSION (r34544): Custom icon does not appear in address field on first visit to any site
- loader/icon/IconLoader.cpp: (WebCore::IconLoader::finishLoading): Changed to set the icon data only after establishing a mapping from the page URL(s) to the icon. Doing things the other way around resulted in the data not being cached in the icon-URL to IconRecord map (because there was no interested page at the time) and subsequently having to be fetched asynchronously from the database when the page-to-icon mapping was established.
- 3:44 PM Changeset in webkit [40334] by
-
- 7 edits in trunk/WebCore
2009-01-28 David Hyatt <hyatt@apple.com>
Move addFocusRingRects from RenderFlow down into RenderBlock and RenderInline.
Reviewed by Oliver Hunt
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::addFocusRingRects):
- rendering/RenderBlock.h:
- rendering/RenderFlow.cpp:
- rendering/RenderFlow.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::addFocusRingRects):
- rendering/RenderInline.h:
- 3:18 PM Changeset in webkit [40333] by
-
- 5 edits in trunk/WebCore
2009-01-28 David Hyatt <hyatt@apple.com>
Move localCaretRect from RenderFlow into RenderBlock, since it only applied to blocks anyway and
was misplaced from the start.
Reviewed by anttik
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::localCaretRect):
- rendering/RenderBlock.h:
- rendering/RenderFlow.cpp:
- rendering/RenderFlow.h:
- 2:54 PM Changeset in webkit [40332] by
-
- 13 edits3 adds in trunk
2009-01-28 Sam Weinig <sam@webkit.org>
Reviewed by Geoff Garen.
Fix for <rdar://problem/6129678>
REGRESSION (Safari 3-4): Local variable not accessible from Dashcode console or variables view
Iterating the properties of activation objects accessed through the WebKit debugging
APIs was broken by forced conversion of JSActivation to the global object. To fix this,
we use a proxy activation object that acts more like a normal JSObject.
- debugger/DebuggerActivation.cpp: Added. (JSC::DebuggerActivation::DebuggerActivation): (JSC::DebuggerActivation::mark): (JSC::DebuggerActivation::className): (JSC::DebuggerActivation::getOwnPropertySlot): (JSC::DebuggerActivation::put): (JSC::DebuggerActivation::putWithAttributes): (JSC::DebuggerActivation::deleteProperty): (JSC::DebuggerActivation::getPropertyNames): (JSC::DebuggerActivation::getPropertyAttributes): (JSC::DebuggerActivation::defineGetter): (JSC::DebuggerActivation::defineSetter): (JSC::DebuggerActivation::lookupGetter): (JSC::DebuggerActivation::lookupSetter):
- debugger/DebuggerActivation.h: Added. Proxy JSActivation object for Debugging.
- runtime/JSActivation.h: (JSC::JSActivation::isActivationObject): Added.
- runtime/JSObject.h: (JSC::JSObject::isActivationObject): Added.
WebCore:
2009-01-28 Sam Weinig <sam@webkit.org>
Reviewed by Geoff Garen.
Add forwarding header.
- ForwardingHeaders/debugger/DebuggerActivation.h: Added.
WebKit/mac:
2009-01-28 Sam Weinig <sam@webkit.org>
Reviewed by Geoff Garen.
Fix for <rdar://problem/6129678>
REGRESSION (Safari 3-4): Local variable not accessible from Dashcode console or variables view
- WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): Wrap JSActivations in DebuggerActivations.
- 2:47 PM Changeset in webkit [40331] by
-
- 1 edit49 adds in trunk/LayoutTests
2009-01-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added layout tests for how many history items are created during a
redirect. (Many of these results are expected failures for now.)
- http/tests/history: Added.
- http/tests/history/redirect-200-refresh-0-seconds-expected.txt: Added.
- http/tests/history/redirect-200-refresh-0-seconds.pl: Added.
- http/tests/history/redirect-200-refresh-2-seconds-expected.txt: Added.
- http/tests/history/redirect-200-refresh-2-seconds.pl: Added.
- http/tests/history/redirect-301-expected.txt: Added.
- http/tests/history/redirect-301.pl: Added.
- http/tests/history/redirect-302-expected.txt: Added.
- http/tests/history/redirect-302.pl: Added.
- http/tests/history/redirect-303-expected.txt: Added.
- http/tests/history/redirect-303.pl: Added.
- http/tests/history/redirect-307-expected.txt: Added.
- http/tests/history/redirect-307.pl: Added.
- http/tests/history/redirect-js-document-location-0-seconds-expected.txt: Added.
- http/tests/history/redirect-js-document-location-0-seconds.html: Added.
- http/tests/history/redirect-js-document-location-2-seconds-expected.txt: Added.
- http/tests/history/redirect-js-document-location-2-seconds.html: Added.
- http/tests/history/redirect-js-document-location-before-load-expected.txt: Added.
- http/tests/history/redirect-js-document-location-before-load.html: Added.
- http/tests/history/redirect-js-location-0-seconds-expected.txt: Added.
- http/tests/history/redirect-js-location-0-seconds.html: Added.
- http/tests/history/redirect-js-location-2-seconds-expected.txt: Added.
- http/tests/history/redirect-js-location-2-seconds.html: Added.
- http/tests/history/redirect-js-location-assign-0-seconds-expected.txt: Added.
- http/tests/history/redirect-js-location-assign-0-seconds.html: Added.
- http/tests/history/redirect-js-location-assign-2-seconds-expected.txt: Added.
- http/tests/history/redirect-js-location-assign-2-seconds.html: Added.
- http/tests/history/redirect-js-location-assign-before-load-expected.txt: Added.
- http/tests/history/redirect-js-location-assign-before-load.html: Added.
- http/tests/history/redirect-js-location-before-load-expected.txt: Added.
- http/tests/history/redirect-js-location-before-load.html: Added.
- http/tests/history/redirect-js-location-href-0-seconds-expected.txt: Added.
- http/tests/history/redirect-js-location-href-0-seconds.html: Added.
- http/tests/history/redirect-js-location-href-2-seconds-expected.txt: Added.
- http/tests/history/redirect-js-location-href-2-seconds.html: Added.
- http/tests/history/redirect-js-location-href-before-load-expected.txt: Added.
- http/tests/history/redirect-js-location-href-before-load.html: Added.
- http/tests/history/redirect-js-location-replace-0-seconds-expected.txt: Added.
- http/tests/history/redirect-js-location-replace-0-seconds.html: Added.
- http/tests/history/redirect-js-location-replace-2-seconds-expected.txt: Added.
- http/tests/history/redirect-js-location-replace-2-seconds.html: Added.
- http/tests/history/redirect-js-location-replace-before-load-expected.txt: Added.
- http/tests/history/redirect-js-location-replace-before-load.html: Added.
- http/tests/history/redirect-meta-refresh-0-seconds-expected.txt: Added.
- http/tests/history/redirect-meta-refresh-0-seconds.html: Added.
- http/tests/history/redirect-meta-refresh-2-seconds-expected.txt: Added.
- http/tests/history/redirect-meta-refresh-2-seconds.html: Added.
- http/tests/history/resources: Added.
- http/tests/history/resources/redirect-target.html: Added.
- 2:43 PM Changeset in webkit [40330] by
-
- 2 edits in trunk/WebKitTools
2009-01-28 Geoffrey Garen <ggaren@apple.com>
Build fix for GTK.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::webHistoryItemCount):
- 2:36 PM Changeset in webkit [40329] by
-
- 5 edits in trunk/WebKitTools
2009-01-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added support for querying how many history items were created during a
layout test.
- DumpRenderTree/LayoutTestController.cpp: (getWebHistoryItemCountCallback): (LayoutTestController::staticValues):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::webHistoryItemCount):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::webHistoryItemCount):
- 2:35 PM Changeset in webkit [40328] by
-
- 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj
Fix build bustage.
- 1:58 PM Changeset in webkit [40327] by
-
- 1 edit in trunk/WebCore/rendering/RenderLineBoxList.h
Fix build bustage in release builds.
- 1:48 PM Changeset in webkit [40326] by
-
- 8 edits in trunk/WebCore
2009-01-28 David Hyatt <hyatt@apple.com>
Move createInlineBox out of RenderFlow and down into RenderInline and RenderBlock.
Reviewed by Beth Dakin
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::createInlineBox):
- rendering/RenderBlock.h:
- rendering/RenderFlow.cpp:
- rendering/RenderFlow.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::createInlineBox):
- rendering/RenderInline.h:
- rendering/bidi.cpp:
- 1:18 PM Changeset in webkit [40325] by
-
- 4 edits in branches/Safari-3-2-branch/WebCore
Merge the rest of r33579.
Reviewed by Steve Falkenburg.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest):
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):
- platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
- 12:56 PM Changeset in webkit [40324] by
-
- 5 edits in trunk/WebCore
2009-01-28 David Hyatt <hyatt@apple.com>
Move calcMargins from RenderFlow to RenderInline, since it was only ever called on RenderInlines.
Reviewed by Oliver Hunt
- rendering/RenderFlow.cpp:
- rendering/RenderFlow.h:
- rendering/RenderInline.h: (WebCore::RenderInline::calcMargins):
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 12:48 PM Changeset in webkit [40323] by
-
- 16 edits2 adds in trunk/WebCore
2009-01-28 David Hyatt <hyatt@apple.com>
Refactor the first and last line box member variables from RenderFlow. Encapsulate them into a new class called RenderLineBoxList that manages all modifications to
the list. This change will make it easier to give RenderInline and RenderBlock separate versions of the line box list without having to duplicate very much code.
Reviewed by Oliver Hunt
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::deleteLine): (WebCore::InlineFlowBox::removeLineBoxFromRenderObject): (WebCore::InlineFlowBox::extractLine): (WebCore::InlineFlowBox::extractLineBoxFromRenderObject): (WebCore::InlineFlowBox::attachLine): (WebCore::InlineFlowBox::attachLineBoxToRenderObject):
- rendering/InlineFlowBox.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::deleteLineBoxTree):
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::destroy): (WebCore::RenderFlow::dirtyLineBoxes): (WebCore::RenderFlow::createInlineBox):
- rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow): (WebCore::RenderFlow::lineBoxes): (WebCore::RenderFlow::firstLineBox): (WebCore::RenderFlow::lastLineBox):
- rendering/RenderLineBoxList.cpp: Added. (WebCore::RenderLineBoxList::~RenderLineBoxList): (WebCore::RenderLineBoxList::appendLineBox): (WebCore::RenderLineBoxList::deleteLineBoxTree): (WebCore::RenderLineBoxList::extractLineBox): (WebCore::RenderLineBoxList::attachLineBox): (WebCore::RenderLineBoxList::removeLineBox): (WebCore::RenderLineBoxList::deleteLineBoxes): (WebCore::RenderLineBoxList::checkConsistency):
- rendering/RenderLineBoxList.h: Added. (WebCore::RenderLineBoxList::RenderLineBoxList): (WebCore::RenderLineBoxList::firstLineBox): (WebCore::RenderLineBoxList::lastLineBox): (WebCore::RenderLineBoxList::checkConsistency):
- rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createInlineBox):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::createInlineBox):
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::removeLineBoxFromRenderObject): (WebCore::RootInlineBox::extractLineBoxFromRenderObject): (WebCore::RootInlineBox::attachLineBoxToRenderObject):
- rendering/RootInlineBox.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 12:46 PM Changeset in webkit [40322] by
-
- 3 edits in trunk/WebCore
Clean up FontPlatformData constructor
Reviewed by David Hyatt.
- platform/graphics/mac/FontPlatformData.h: Updated copyright. (WebCore::FontPlatformData::FontPlatformData): Provide readable names for constructor arguments and reformat member variables.
- platform/graphics/mac/FontPlatformDataMac.mm: Updated copyright. (WebCore::FontPlatformData::FontPlatformData): Provide readable names for constructor arguments and reformat member variables.
- 12:37 PM Changeset in webkit [40321] by
-
- 3 edits in trunk/WebCore
2009-01-28 Tony Chang <tony@chromium.org>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23593
Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin.
This is a follow up for hyatt's RenderBox changes.
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::baselinePosition):
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintMenuList):
- 12:26 PM Changeset in webkit [40320] by
-
- 2 edits in trunk
Fixed ChangeLog dates.
- 12:07 PM Changeset in webkit [40319] by
-
- 6 edits in trunk
Bug 23490: Remove initialRefCount argument from RefCounted class
Reviewed by Darin Adler.
RefCountedBase now always starts with a ref count of 1, so there
is no need to pass the initialRefCount into the class anymore.
- wtf/ByteArray.h: (WTF::ByteArray::ByteArray): Removed call to RefCounted(1).
- wtf/RefCounted.h: (WTF::RefCountedBase::RefCountedBase): Changed to start with a ref count of 1. (WTF::RefCounted::RefCounted): Removed initialRefCount argument and removed call to RefCounted(1).
WebKit/wx:
FrameLoaderClientWx is no longer a RefCounted class.
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::FrameLoaderClientWx): Removed call to the RefCounted<FrameLoaderClientWx>(0) super constructor.
- WebKitSupport/FrameLoaderClientWx.h: Don't include RefCounted.h and stop inheriting from RefCounted<FrameLoaderClientWx>.
- 11:40 AM Changeset in webkit [40318] by
-
- 5 edits8 adds in trunk
2009-01-28 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Fix assertions when inline elements have both opacity (or something
else that creates a RenderLayer), and transform by ensuring that
setHasTransform() is only called for non-inline or replaced elements.
We also have to ensure that RenderReplicas will get transforms applied
to them by lying about them being replaced.
Tests: fast/transforms/transform-on-inline.html
fast/transforms/transform-table-row.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange):
- rendering/RenderReplica.cpp: (WebCore::RenderReplica::RenderReplica):
- rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
- 11:38 AM Changeset in webkit [40317] by
-
- 3 edits1 add in trunk
2009-01-28 Hironori Bono <hbono@chromium.org>
Reviewed by Justin Garcia.
https://bugs.webkit.org/show_bug.cgi?id=18835
Spelling underlines disappear when they shouldn't
The WebCore::InsertLineBreakCommand::doApply() function splits a text node
without copying existing markers. To fix this bug, change code which
manually splits a text node into a CompositeEditCommand::splitTextNode() call.
Test: editing/spelling/spelling-linebreak.html
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
- 11:31 AM Changeset in webkit [40316] by
-
- 9 edits in trunk/WebCore
2009-01-28 David Hyatt <hyatt@apple.com>
Move the m_lineHeight member variable out of RenderFlow and down into RenderBlock and RenderInline. Shift the line height computation into RenderStyle so
that it isn't repeated in three places.
Reviewed by Sam Weinig
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::lineHeight):
- rendering/RenderBlock.h:
- rendering/RenderFlow.cpp:
- rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow):
- rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::lineHeight):
- rendering/RenderInline.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::lineHeight):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::computedLineHeight):
- 11:19 AM Changeset in webkit [40315] by
-
- 4 edits in trunk/WebCore
2009-01-28 Zachary Kuznia <zork@chromiuum.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=22070
Add an option to allow scripts to close windows.
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAllowScriptsToCloseWindows):
- page/Settings.h: (WebCore::Settings::allowScriptsToCloseWindows):
- 10:52 AM Changeset in webkit [40314] by
-
- 2 edits in trunk/WebCore
2009-01-28 Adam Langley <agl@google.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=23573
Make PlatformWidget on chromium an intptr_t to match changes made in Chromium
- platform/chromium/PlatformWidget.h:
- 9:39 AM Changeset in webkit [40313] by
-
- 2 edits in trunk/WebCore
2009-01-28 David Hyatt <hyatt@apple.com>
Fix for
<rdar://problem/6531287> REGRESSION: CrashTracer: [USER] 12 crashes in Safari at com.apple.WebCore • WebCore::RenderBlock::removeFloatingObject + 59
My tightening up of markAllDescendantsWithFloatsForLayout exposed a buggy check in that code that could
lead to a bad cast.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
- 9:30 AM Changeset in webkit [40312] by
-
- 29 edits in trunk/WebCore
2009-01-27 David Hyatt <hyatt@apple.com>
Work towards eliminating RenderFlow from the tree.
Move the m_continuation variable down from RenderFlow into RenderInline and RenderBlock. Since a block can only have an inline continuation following it, the type
of the member and methods reflect this (inlineContinuation() and m_inlineContinuation). Since an inline can have either a block or an inline continuation following it,
a base class of RenderBox* is used for the type of object returned (in anticipation of the removal of RenderFlow).
Since moving the continuation variable down into the subclasses increased the size of RenderInline and RenderBlock by 4 bytes, this patch also moves all of the bitfield
members of RenderFlow up to RenderObject. Since they fit within the available bits on RenderObject, this patch actually results in a net savings of 4 bytes on RenderInlines
and RenderBlocks!
One bitfield member was eliminated rather than moved: m_firstLine. This was really more of a state variable used during line layout only, so I removed it as a member
and just passed firstLine down to various methods as needed. Doing so uncovered some potential bugs where the first line state was not being respected when querying for
line offsets.
Continuations have been completely hidden from all files except for RenderFlow, RenderBlock and RenderInline. All of the code that referenced continuations directly
from base classes has been refactored to use virtual methods on RenderBlock and RenderInline instead.
RenderFlow still has a common addChildWithContinuation method that is used by both blocks and inlines. Since refactoring that method will be pretty tricky, I've held
off on that for a later patch.
Reviewed by Oliver Hunt
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::anchorElement): (WebCore::AccessibilityRenderObject::boundingBoxRect):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::determineSpacingForFlowBoxes): (WebCore::InlineFlowBox::paint):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::~RenderBlock): (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::addChildToFlow): (WebCore::RenderBlock::makeChildrenNonInline): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::expandsToEncloseOverhangingFloats): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::setCollapsedBottomMargin): (WebCore::RenderBlock::layoutOnlyPositionedObjects): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::addContinuationWithOutline): (WebCore::RenderBlock::setSelectionState): (WebCore::RenderBlock::shouldPaintSelectionGaps): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::leftSelectionOffset): (WebCore::RenderBlock::rightSelectionOffset): (WebCore::RenderBlock::leftOffset): (WebCore::RenderBlock::leftRelOffset): (WebCore::RenderBlock::rightOffset): (WebCore::RenderBlock::rightRelOffset): (WebCore::RenderBlock::lineWidth): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::getClearDelta): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::offsetForContents): (WebCore::RenderBlock::availableWidth): (WebCore::RenderBlock::setDesiredColumnCountAndWidth): (WebCore::RenderBlock::desiredColumnWidth): (WebCore::RenderBlock::desiredColumnCount): (WebCore::RenderBlock::columnRects): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustPointToColumnContents): (WebCore::RenderBlock::adjustRectForColumns): (WebCore::RenderBlock::absoluteRects): (WebCore::RenderBlock::absoluteQuads): (WebCore::RenderBlock::rectWithOutlineForRepaint): (WebCore::RenderBlock::hoverAncestor): (WebCore::RenderBlock::updateDragState): (WebCore::RenderBlock::outlineStyleForRepaint): (WebCore::RenderBlock::childBecameNonInline): (WebCore::RenderBlock::updateHitTestResult):
- rendering/RenderBlock.h: (WebCore::RenderBlock::rightOffset): (WebCore::RenderBlock::leftOffset): (WebCore::RenderBlock::inlineContinuation): (WebCore::RenderBlock::setInlineContinuation):
- rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects): (WebCore::RenderBox::absoluteQuads): (WebCore::RenderBox::addFocusRingRects): (WebCore::RenderBox::containingBlockWidth):
- rendering/RenderBox.h: (WebCore::RenderBox::collapsedMarginBottom): (WebCore::RenderBox::childBecameNonInline):
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer): (WebCore::RenderContainer::removeLeftoverAnonymousBlock):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderFlow.cpp: (WebCore::nextContinuation): (WebCore::RenderFlow::continuationBefore): (WebCore::RenderFlow::addChildWithContinuation): (WebCore::RenderFlow::addChild): (WebCore::RenderFlow::destroy): (WebCore::RenderFlow::addFocusRingRects):
- rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow):
- rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::destroy): (WebCore::RenderInline::inlineContinuation): (WebCore::RenderInline::styleDidChange): (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::cloneInline): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::positionForCoordinates): (WebCore::RenderInline::rectWithOutlineForRepaint): (WebCore::RenderInline::updateDragState): (WebCore::RenderInline::childBecameNonInline): (WebCore::RenderInline::updateHitTestResult):
- rendering/RenderInline.h: (WebCore::RenderInline::isRenderInline): (WebCore::RenderInline::continuation): (WebCore::RenderInline::setContinuation):
- rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker):
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::RenderListMarker): (WebCore::RenderListMarker::setSelectionState):
- rendering/RenderListMarker.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::rectWithOutlineForRepaint): (WebCore::RenderObject::handleDynamicFloatPositionChange): (WebCore::RenderObject::updateDragState): (WebCore::RenderObject::updateHitTestResult): (WebCore::RenderObject::getTextDecorationColors): (WebCore::RenderObject::adjustRectForOutlineAndShadow):
- rendering/RenderObject.h: (WebCore::RenderObject::isInlineBlockOrInlineTable): (WebCore::RenderObject::childrenInline): (WebCore::RenderObject::setChildrenInline): (WebCore::RenderObject::hasColumns): (WebCore::RenderObject::setHasColumns): (WebCore::RenderObject::cellWidthChanged): (WebCore::RenderObject::setCellWidthChanged): (WebCore::RenderObject::isInlineContinuation): (WebCore::RenderObject::hoverAncestor): (WebCore::RenderObject::outlineStyleForRepaint): (WebCore::RenderObject::setHasMarkupTruncation): (WebCore::RenderObject::hasMarkupTruncation): (WebCore::RenderObject::selectionState): (WebCore::RenderObject::setSelectionState): (WebCore::RenderObject::hasSelectedChildren): (WebCore::RenderObject::isTopMarginQuirk): (WebCore::RenderObject::isBottomMarginQuirk): (WebCore::RenderObject::setTopMarginQuirk): (WebCore::RenderObject::setBottomMarginQuirk):
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::RenderReplaced): (WebCore::RenderReplaced::setSelectionState):
- rendering/RenderReplaced.h: (WebCore::RenderReplaced::canBeSelectionLeaf):
- rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::updateWidth): (WebCore::RenderTableCell::layout):
- rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::localCaretRect): (WebCore::RenderText::setSelectionState):
- rendering/RenderText.h: (WebCore::RenderText::canBeSelectionLeaf):
- rendering/RenderView.cpp: (WebCore::RenderView::updateHitTestResult):
- rendering/RenderView.h:
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::selectionTop):
- rendering/bidi.cpp: (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::RenderBlock::fitBelowFloats): (WebCore::RenderBlock::findNextLineBreak): (WebCore::RenderBlock::checkLinesForTextOverflow):
- 8:39 AM Changeset in webkit [40311] by
-
- 9 edits in trunk
Reviewed by Nikolas Zimmermann and George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=23557
Allow option of hit testing frame content without clipping to the visible
viewport.
- 8:26 AM Changeset in webkit [40310] by
-
- 2 edits in trunk/WebCore
2009-01-28 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Holger Freyther.
Fix the build with Qt on Windows.
Make sure that the QTWEBKIT_EXPORT macro becomes the Q_DECL_EXPORT macro
instead of the import macro when building the dll, by defining
QT_MAKEDLL.
SystemTimeWin.cpp is needed on Windows for userIdleTime(), which for the
other Qt platforms comes from TemporaryLinkStubs.cpp.
- 5:42 AM Changeset in webkit [40309] by
-
- 2 edits in trunk/WebKit/qt
2009-01-28 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Simon Hausmann.
Provide default implementations of JavaScript dialog boxes like in
most web browsers, i.e. indicate that is from JavaScript and show the
frame URL.
- Api/qwebpage.cpp: (QWebPage::javaScriptAlert): (QWebPage::javaScriptConfirm): (QWebPage::javaScriptPrompt):
- 5:19 AM Changeset in webkit [40308] by
-
- 2 edits in trunk/WebCore
2009-01-28 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon Hausmann.
[Qt] Speed-up clipping: avoid calling expensive QPainter::clipRegion().
Beside, the check is not necessary since QPainter::setClipRect() will
work just fine if there is no clip region yet.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clip):
- 12:19 AM Changeset in webkit [40307] by
-
- 2 edits2 adds in trunk/WebCore
2009-01-28 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23546
Upstream GoogleURL implementation of KURL
- platform/KURL.h:
- platform/KURLGoogle.cpp: Added.
- platform/KURLGooglePrivate.h: Added.
Jan 27, 2009:
- 8:08 PM Changeset in webkit [40306] by
-
- 2 edits in trunk/WebKit/mac
2009-01-27 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver Hunt.
Fix two bugs with Core Animation based plug-ins.
- The plug-in view was marked as opaque even though it's not. (This would leave garbage in the plug-in view).
- The plug-in layer needs to have autoresizing turned on.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setLayer:]):
- 5:54 PM Changeset in webkit [40305] by
-
- 2 edits in trunk/WebCore
2009-01-27 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
REGRESSION (r40234): Launching iTunes from a link displays a
"Safari can't find the Internet plug-in" sheet in Safari
rdar://problem/6533678
- rendering/RenderPartObject.cpp: (WebCore::havePlugin): Put the check for empty string in here. (WebCore::serviceTypeForClassId): Only return activeXType() if we have a plug-in that can handle that type. While it might be logical to return an Active X type for any <object> with a classId in it, even if we don't have a plug-in that implements Active X, existing clients, such as Safari, don't expect that.
- 5:10 PM Changeset in webkit [40304] by
-
- 2 edits in trunk/WebCore
Reviewed by Steve Falkenburg.
- fix <rdar://problem/6524351> Text looks bad when font smoothing is forced off
- platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): Changed to use GDI rather than Core Graphics if the client has turned font smoothing off.
- 3:05 PM Changeset in webkit [40303] by
-
- 17 edits in trunk/WebCore
2009-01-27 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Use the new container-relative repaint methods to compute
post-layout repaints, and repaints using RenderLayer's
cached repaintRect() relative to that container, rather than
using absolute coords.
Replaced lots of boilerplate old/new rect code in various
layout methods with a stack-based LayoutRepainter class, and
fixed a bug in RenderTable which set didFullRepaint to
'true' every time.
- 2:40 PM Changeset in webkit [40302] by
-
- 6 edits in trunk/WebCore
2009-01-27 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
<rdar://problem/3541409> - More groundwork and cleanup for CachedFrames
- history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Make the savePlatformDataToCachedFrame() client call here, and add the code for caching subframes. (WebCore::CachedFrame::clear):
- history/CachedFrame.h: Change to be RefCounted (WebCore::CachedFrame::create): (WebCore::CachedFrame::url):
- history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore):
- history/CachedPage.h: (WebCore::CachedPage::document): (WebCore::CachedPage::documentLoader): (WebCore::CachedPage::view): (WebCore::CachedPage::url): (WebCore::CachedPage::domWindow): (WebCore::CachedPage::cachedMainFrame):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePageForHistoryItem): Move the platform data saving into the CachedFrame itself.
- 2:09 PM Changeset in webkit [40301] by
-
- 2 edits in trunk/LayoutTests
2009-01-27 Holger Hans Peter Freyther <zecke@selfish.org>
Rubber stamped by Darin Adler.
Get the build bot green as discussed on the mailinglist. There is
only one crash after unloading a page with plugins. For the remaining
failing tests DumpRenderTree needs to be looked at.
- platform/gtk/Skipped:
- 1:54 PM Changeset in webkit [40300] by
-
- 13 edits in trunk/WebCore
2009-01-27 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Flip the arguments of computeRectForRepaint() from
computeRectForRepaint(IntRect&, RenderBox* repaintContainer, bool)
to
computeRectForRepaint(RenderBox* repaintContainer, IntRect&, bool)
- 1:44 PM Changeset in webkit [40299] by
-
- 2 edits in trunk/WebCore
Add missing header guards to AccessibilityObjectWrapper.h
Reviewed by Anders Carlsson.
- page/mac/AccessibilityObjectWrapper.h: Added missing header guards.
- 1:28 PM Changeset in webkit [40298] by
-
- 5 edits in trunk/WebCore
2009-01-27 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Fix crash of svg/custom/stop-crash.svg testcase because of
infinite recursion, as I missed replacing absoluteClippedOverflowRect()
with clippedOverflowRectForRepaint() in RenderSVGGradientStop.
Also fix a missed conversion in RenderTableCol, and add a couple
of comments.
- 11:24 AM Changeset in webkit [40297] by
-
- 2 edits in trunk/WebCore
2009-01-27 Adele Peterson <adele@apple.com>
RS by Dave Hyatt
Use the textfield appearance for search fields in themeWin.css so the border/background
styling will work correctly on these fields.
- css/themeWin.css:
- 10:45 AM Changeset in webkit [40296] by
-
- 2 edits in trunk/WebCore
- build fix
- bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::JSHTMLInputElement::setSelectionStart): (WebCore::JSHTMLInputElement::setSelectionEnd): (WebCore::JSHTMLInputElement::setSelectionRange):
- 10:26 AM Changeset in webkit [40295] by
-
- 2 edits in trunk/WebCore
- build fix
- platform/graphics/Gradient.cpp: (WebCore::Gradient::setSpreadMethod):
- 9:30 AM Changeset in webkit [40294] by
-
- 4 edits in trunk/WebCore
2009-01-27 Paul Godavari <paul@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23561
Explicitly send the MIME type from an image dragged from a web
page to the desktop, to Chromium so that it can properly generate
a file name.
- platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::clear): (WebCore::ChromiumDataObject::hasData):
- platform/chromium/ChromiumDataObject.h:
- platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject):
- 9:24 AM Changeset in webkit [40293] by
-
- 6 edits in trunk
WebCore:
2009-01-27 Mads Ager <ager@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23300
Follow Firefox in throwing exceptions when using selection
functions on HTMLInputElements that cannot have selection.
This requires custom setSelectionRange, setSelectionStart and
setSelectionEnd implementations, but it gets rid of the custom
getOwnPropertySlot.
- bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::JSHTMLInputElement::selectionStart): (WebCore::JSHTMLInputElement::selectionEnd): (WebCore::JSHTMLInputElement::setSelectionRange):
- html/HTMLInputElement.idl:
LayoutTests:
2009-01-27 Mads Ager <ager@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23300
Update test of selection functions on HTMLInputElements to expect
the selection functions to throw exceptions when used on buttons.
This is consistent with the Firefox behavior.
- fast/forms/selection-functions-expected.txt:
- fast/forms/selection-functions.html:
- 9:13 AM Changeset in webkit [40292] by
-
- 16 edits in trunk/WebCore
2009-01-27 Evan Stade <estade@chromium.org>
Reviewed by Nikolas Zimmermann.
https://bugs.webkit.org/show_bug.cgi?id=23435
Make spreadMethod a member of Gradient rather than GraphicsContext.
Implement spreadMethod for Skia.
- platform/graphics/Gradient.cpp: (WebCore::Gradient::Gradient):
- platform/graphics/Gradient.h: (WebCore::Gradient::setSpreadMethod): (WebCore::Gradient::spreadMethod):
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/GraphicsContext.h:
- platform/graphics/GraphicsContextPrivate.h:
- platform/graphics/GraphicsTypes.h: (WebCore::):
- platform/graphics/cairo/GradientCairo.cpp: (WebCore::Gradient::platformGradient):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
- platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
- platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::platformGradient):
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::SVGPaintServerGradient): (WebCore::SVGPaintServerGradient::setup): (WebCore::SVGPaintServerGradient::externalRepresentation):
- svg/graphics/SVGPaintServerGradient.h:
- 8:03 AM Changeset in webkit [40291] by
-
- 2 edits in trunk/WebCore
2009-01-27 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Simon Hausmann.
http://www.qtsoftware.com/developer/task-tracker/index_html?id=238662&method=entry
[Qt] Map function keys F1 to F24.
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- 7:26 AM Changeset in webkit [40290] by
-
- 2 edits in trunk/WebKit/qt
2009-01-27 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon Hausmann.
http://www.qtsoftware.com/developer/task-tracker/index_html?id=238391&method=entry
[Qt] If QPainter fails to start on a QPrinter instance, do not
continue printing.
- Api/qwebframe.cpp: (QWebFrame::print):
- 12:05 AM Changeset in webkit [40289] by
-
- 26 edits in trunk
WebCore:
2009-01-27 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein
Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage
- WebCore.base.exp:
- history/CachedPage.cpp:
- history/CachedPage.h: (WebCore::CachedPage::cachedMainFrame):
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::savePlatformDataToCachedFrame): (WebCore::EmptyFrameLoaderClient::transitionToCommittedFromCachedFrame):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::cachePageForHistoryItem):
- loader/FrameLoaderClient.h:
WebKit/gtk:
2009-01-27 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein
Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame): (WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame):
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/mac:
2009-01-27 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein
Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage
- History/WebHistoryItem.mm:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::savePlatformDataToCachedFrame): (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
- WebKit.order:
WebKit/qt:
2009-01-27 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein
Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::savePlatformDataToCachedFrame): (WebCore::FrameLoaderClientQt::transitionToCommittedFromCachedFrame):
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
2009-01-27 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein
Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::savePlatformDataToCachedFrame): (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebFrame.cpp:
- WebFrame.h:
WebKit/wx:
2009-01-27 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein
Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::savePlatformDataToCachedFrame): (WebCore::FrameLoaderClientWx::transitionToCommittedFromCachedFrame):
- WebKitSupport/FrameLoaderClientWx.h:
Jan 26, 2009:
- 10:58 PM Changeset in webkit [40288] by
-
- 33 edits in trunk/WebCore
2009-01-26 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Add variants of all the methods that compute dirty rects for repainting
with versions that compute those rects relative to some container
RenderBox that acts as a painting root.
- 8:40 PM Changeset in webkit [40287] by
-
- 7 edits in trunk
2009-01-26 Simon Fraser <Simon Fraser>
Reviewed by David Hyatt
Back out r40285, because it was checked in with no bug number, no
testcase, is rendering change that did not get thorough review,
and broke the Mac build.
- 7:49 PM Changeset in webkit [40286] by
-
- 4 edits in trunk/WebCore
2009-01-26 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
-Make the recently added back/forward cache logging much better by actually
walking the entire frame tree and indenting the resulting output.
-Fix a null-termination bug in HistoryItem tree logging
- history/HistoryItem.cpp: (WebCore::HistoryItem::showTreeWithIndent):
- loader/FrameLoader.cpp: (WebCore::pageCacheLogPrefix): (WebCore::pageCacheLog): (WebCore::FrameLoader::logCanCachePageDecision): (WebCore::FrameLoader::logCanCacheFrameDecision):
- loader/FrameLoader.h:
- 7:06 PM Changeset in webkit [40285] by
-
- 7 edits in trunk
Allow option of hit testing frame content without clipping to the visible
viewport.
- 6:44 PM Changeset in webkit [40284] by
-
- 5 edits in trunk/LayoutTests
Fix misspelling of "lowercase" in font-face-locally-installed.html
Reviewed by Dan Bernstein.
- fast/css/font-face-locally-installed.html: Updated.
- platform/mac/fast/css/font-face-locally-installed-expected.checksum: Updated.
- platform/mac/fast/css/font-face-locally-installed-expected.png: Updated.
- platform/mac/fast/css/font-face-locally-installed-expected.txt: Updated.
- 5:59 PM Changeset in webkit [40283] by
-
- 1 edit in trunk/WebKit/mac/ChangeLog
Sam did _not_ review this
- 5:57 PM Changeset in webkit [40282] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-26 Adele Peterson <adele@apple.com>
Build fix.
- debugger/Debugger.cpp:
- 5:56 PM Changeset in webkit [40281] by
-
- 4 edits in trunk/WebKit/mac
2009-01-26 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add the ability for plug-ins to make WebKit operate in "modal mode"
- Plugins/Hosted/NetscapePluginHostProxy.h:
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): (WebKit::NetscapePluginHostProxy::pluginHostDied): If the plug-in crashes while we're modal, make sure to leave the modal mode.
(WebKit::NetscapePluginHostProxy::setModal):
(WKPCSetModal):
- Plugins/Hosted/WebKitPluginClient.defs:
- 5:33 PM Changeset in webkit [40280] by
-
- 3 edits in trunk/WebKit/mac
2009-01-26 John Sullivan <sullivan@apple.com>
fixed <rdar://problem/6530053> REGRESSION (Leopard): Shift-tab in http authentication window gets
stuck in the Name field rather than cycling around
Reviewed by Dan Bernstein
- Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
- Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: The two static text fields and the last button all had their "next key view" outlets set to the name field, which caused shift-tab from the name field to do the wrong thing. Fixed by making each selectable view have exactly one "next key view" set to it.
- 5:08 PM Changeset in webkit [40279] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-26 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
Fixes for eq null & neq null, on 64-bit JIT.
https://bugs.webkit.org/show_bug.cgi?id=23559
This patch degrades 64-bit JIT performance on some benchmarks,
due to the whole not-being-incorrect thing.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- 4:45 PM Changeset in webkit [40278] by
-
- 6 edits3 adds in trunk
WebCore:
2009-01-26 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for https://bugs.webkit.org/show_bug.cgi?id=18141
Acid3 tests 77 and 78 fail on reload due to SVG font race
<rdar://problem/6504899>
Match Opera's behavior of loading SVGFonts as soon as <font-face-uri>
tag is inserted into the document and not at the first use of the font
as is done for CSS web fonts.
This fixes a race condition noticeable by some in the Acid3 test that
happened because the onload event handler for an iframe containing a
<font-face-uri> with an external reference was not delayed by the pending
load of the font.
Test: http/tests/misc/SVGFont-delayed-load.html
- svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::~SVGFontFaceUriElement): (WebCore::SVGFontFaceUriElement::parseMappedAttribute): Call loadFont if the href attribute changes. (WebCore::SVGFontFaceUriElement::insertedIntoDocument): Call loadFont. (WebCore::SVGFontFaceUriElement::loadFont): Force a load of the font specified in href attribute.
- svg/SVGFontFaceUriElement.h:
LayoutTests:
2009-01-26 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Test for https://bugs.webkit.org/show_bug.cgi?id=18141
Acid3 tests 77 and 78 fail on reload due to SVG font race
<rdar://problem/6504899>
- http/tests/misc/SVGFont-delayed-load-expected.txt: Added.
- http/tests/misc/SVGFont-delayed-load.html: Added.
- http/tests/misc/resources/SVGFont-delayed-loader.svg: Added.
- svg/custom/acid3-test-77.html:
- svg/custom/resources/Acid3Font-loader.svg:
- 4:38 PM Changeset in webkit [40277] by
-
- 4 edits in trunk/WebKit/mac
2009-01-26 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add the ability for a plug-in to show or hide the menu bar.
- Plugins/Hosted/NetscapePluginHostProxy.h:
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): (WebKit::NetscapePluginHostProxy::pluginHostDied): (WebKit::NetscapePluginHostProxy::setMenuBarVisible): (WKPCSetMenuBarVisible):
- Plugins/Hosted/WebKitPluginClient.defs:
- 4:09 PM Changeset in webkit [40276] by
-
- 13 edits in trunk/LayoutTests
2009-01-26 Pierre-Olivier Latour <pol@apple.com>
Updated the reference images for the video tests that rely on the H264 test movie,
as QuickTime 7.6 apparently slightly changed the results from the 7.5.5 version.
- platform/mac/media/video-aspect-ratio-expected.checksum:
- platform/mac/media/video-aspect-ratio-expected.png:
- platform/mac/media/video-controls-rendering-expected.checksum:
- platform/mac/media/video-controls-rendering-expected.png:
- platform/mac/media/video-display-toggle-expected.checksum:
- platform/mac/media/video-display-toggle-expected.png:
- platform/mac/media/video-layer-crash-expected.checksum:
- platform/mac/media/video-layer-crash-expected.png:
- platform/mac/media/video-transformed-expected.checksum:
- platform/mac/media/video-transformed-expected.png:
- platform/mac/media/video-zoom-expected.checksum:
- platform/mac/media/video-zoom-expected.png:
- 4:00 PM Changeset in webkit [40275] by
-
- 2 edits in trunk/WebCore
Change Web Archive serialization back to the binary property list format.
<rdar://problem/6127865> Web archives saved with Safari 4 cannot be read by Safari 3
Reviewed by Brady Eidson.
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::rawDataRepresentation):
- 3:57 PM Changeset in webkit [40274] by
-
- 8 edits1 add in trunk
2009-01-26 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Gavin Barraclough.
Bug 23552: Dashcode evaluator no longer works after making ExecStates actual call frames
<https://bugs.webkit.org/show_bug.cgi?id=23552>
<rdar://problem/6398839>
Dashcode will crash when using the evaluator because it saves a global call
frame, even after global code has finished executing, and then uses this as
a launching pad to execute new JS in the evaluator. The fix is to detect
when Dashcode is attempting to do this and execute code from a global call
frame instead.
- JavaScriptCore.exp:
- debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame): Added so that WebScriptCallFrame can evaluate JS starting from a global call frame.
- debugger/Debugger.h:
WebKit/mac:
- ForwardingHeaders/runtime/Protect.h: Added.
- WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame _initWithGlobalObject:debugger:caller:debuggerCallFrame:]): Added debugger, a WebScriptDebugger* argument. (-[WebScriptCallFrame evaluateWebScript:]): Detect when Dashcode is using a stale WebScriptCallFrame to execute new JS and evaluate it starting from the global object's global call frame instead.
- WebView/WebScriptDebugger.h: (WebScriptDebugger::globalObject): Added. (WebScriptDebugger::globalCallFrame): Added.
- WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger): Initialize m_globalObject. (WebScriptDebugger::initGlobalCallFrame): Created as a clone of callEvent so that the global call frame can be saved immediately after being created. (WebScriptDebugger::callEvent): Pass 'this' as the debugger argument of WebScriptCallFrame's _initWithGlobalObject method.
- 3:27 PM Changeset in webkit [40273] by
-
- 3 edits in trunk/WebKit/mac
2009-01-26 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver Hunt.
Make WKPCInvoke a simpleroutine.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCInvoke):
- Plugins/Hosted/WebKitPluginClient.defs:
- 3:16 PM Changeset in webkit [40272] by
-
- 2 edits in trunk/WebCore
2009-01-26 Anders Carlsson <andersca@apple.com>
Fix 64-bit build.
- WebCore.LP64.exp:
- 3:14 PM Changeset in webkit [40271] by
-
- 7 edits2 moves in trunk/WebCore
2009-01-26 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=23511
Move DOMTimer from bindings/js to page/.
This was prepared by moving all JSC dependencies from DOMTimer
to ScheduledAction earlier, and helps unfork the Chromuim version
of the DOMTimer.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/DOMTimer.cpp: Removed.
- bindings/js/DOMTimer.h: Removed.
- page/DOMTimer.cpp: Copied from WebCore/bindings/js/DOMTimer.cpp.
- page/DOMTimer.h: Copied from WebCore/bindings/js/DOMTimer.h.
- 3:07 PM Changeset in webkit [40270] by
-
- 4 edits in trunk/WebCore
2009-01-26 David Hyatt <hyatt@apple.com>
Eliminate rightmostPosition, lowestPosition and leftmostPosition from RenderFlow. Move the code into
RenderBlock's methods.
Reviewed by Eric Seidel
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition):
- rendering/RenderFlow.cpp:
- rendering/RenderFlow.h:
- 3:06 PM Changeset in webkit [40269] by
-
- 3 edits in trunk/WebCore
2009-01-26 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23553
Upstream changes from jcampan to fix chromium bugs 6692 and 6694.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::setLoopSelectionNavigation): (WebCore::PopupListBox::PopupListBox): (WebCore::PopupContainer::setLoopSelectionNavigation): (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::paintRow): (WebCore::PopupListBox::clearSelection): (WebCore::PopupListBox::selectNextRow): (WebCore::PopupListBox::selectPreviousRow):
- platform/chromium/PopupMenuChromium.h:
- 2:54 PM Changeset in webkit [40268] by
-
- 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj
Remove extraneous WebCore XCode project setting, introduced in previous commit.
- 2:52 PM Changeset in webkit [40267] by
-
- 4 edits in trunk/WebCore
2009-01-26 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Remove some historical CachedPage time stamp fluff.
- history/CachedPage.cpp: (WebCore::CachedPage::CachedPage):
- history/CachedPage.h: (WebCore::CachedPage::timeStamp):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePageForHistoryItem):
- 2:45 PM Changeset in webkit [40266] by
-
- 8 edits in trunk/WebCore
2009-01-26 David Hyatt <hyatt@apple.com>
Move absoluteClippedOverflowRect, linesBoundingBox and borderBoundingBox from RenderFlow to RenderInline.
Reviewed by Eric Seidel
- rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockHeightForPositioned):
- rendering/RenderFlow.cpp:
- rendering/RenderFlow.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::linesBoundingBox): (WebCore::RenderInline::absoluteClippedOverflowRect):
- rendering/RenderInline.h: (WebCore::RenderInline::borderBoundingBox):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
- rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
- 2:40 PM Changeset in webkit [40265] by
-
- 5 edits in trunk/WebCore
2009-01-26 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=22650
Implement support for "Immutable" attribute to CodeGeneratorJS.pm, thus
allowing to explicitly mark methods as immutable (i.e. returning a new
instance rather than a reference to an existing instance).
- bindings/js/JSSVGMatrixCustom.cpp: Removed custom methods.
- bindings/scripts/CodeGeneratorJS.pm: Added check for Immutable
attribute when generating function call.
- svg/SVGMatrix.idl: Replaced Custom attribute with Immutable on
methods.
- 2:29 PM Changeset in webkit [40264] by
-
- 22 edits in trunk/WebCore
2009-01-26 David Hyatt <hyatt@apple.com>
Eliminate isInlineFlow() now that a RenderBlock can never be an inline flow. isInlineFlow() is now
equivalent to isRenderInline(), so all calls to isInlineFlow() have been replaced with isRenderInline().
Reviewed by Eric Seidel
- dom/Text.cpp: (WebCore::Text::rendererIsNeeded):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::shouldDrawTextDecoration):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::hitTestContents): (WebCore::InlineMinMaxIterator::next): (WebCore::RenderBlock::calcInlinePrefWidths):
- rendering/RenderBlock.h: (WebCore::RenderBlock::isBlockFlow):
- rendering/RenderBox.cpp: (WebCore::RenderBox::clientWidth): (WebCore::RenderBox::clientHeight): (WebCore::RenderBox::nodeAtPoint): (WebCore::RenderBox::imageChanged): (WebCore::RenderBox::offsetForPositionedInContainer): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned):
- rendering/RenderBox.h: (WebCore::RenderBox::width): (WebCore::RenderBox::height): (WebCore::RenderBox::size): (WebCore::RenderBox::frameRect):
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::dirtyLinesFromChangedChild): (WebCore::RenderFlow::createInlineBox): (WebCore::RenderFlow::paintLines): (WebCore::RenderFlow::hitTestLines): (WebCore::RenderFlow::absoluteClippedOverflowRect): (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition):
- rendering/RenderFlow.h: (WebCore::RenderFlow::borderBoundingBox):
- rendering/RenderInline.h: (WebCore::RenderInline::isRenderInline):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::intersectsDamageRect): (WebCore::RenderLayer::boundingBox):
- rendering/RenderListItem.cpp: (WebCore::getParentOfFirstLineBox):
- rendering/RenderObject.cpp: (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline): (WebCore::RenderObject::styleWillChange): (WebCore::RenderObject::firstLineStyle):
- rendering/RenderObject.h:
- rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createInlineBox):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::createInlineBox):
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
- rendering/RenderText.cpp: (WebCore::isInlineFlowOrEmptyText):
- rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
- rendering/bidi.cpp: (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::appendRunsForObject): (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::inlineFlowRequiresLineBox): (WebCore::requiresLineBox): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::RenderBlock::findNextLineBreak):
- 2:27 PM Changeset in webkit [40263] by
-
- 9 edits in trunk/WebKit/mac
2009-01-26 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Implement using plug-in objects as constructors, and setting and getting properties from a plug-in object.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCBooleanAndDataReply):
- Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::Reply::): (WebKit::NetscapePluginInstanceProxy::BooleanAndDataReply::BooleanAndDataReply): Rename NPObjectInvokeReply to BooleanAndDataReply.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::addValueToArray): Fix a cut and paste error.
(WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
Handle NPObjects.
- Plugins/Hosted/ProxyInstance.h:
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyField::valueFromInstance): (WebKit::ProxyField::setValueToInstance): Call the ProxyInstance method.
(WebKit::ProxyInstance::~ProxyInstance):
Release the NPObject.
(WebKit::ProxyInstance::supportsConstruct):
Ask the plug-in host if an instance supports construct.
(WebKit::ProxyInstance::fieldValue):
(WebKit::ProxyInstance::setFieldValue):
Call the plug-in host methods.
- Plugins/Hosted/WebKitPluginHostTypes.h: Rename ObjectValueType to JSObjectValueType, and add NPObjectValueType.
- 1:53 PM Changeset in webkit [40262] by
-
- 1 edit in trunk/LayoutTests/platform/mac/fast/table/form-with-table-style-expected.txt
Land new layout tests now that display:compact support has been removed.
- 1:52 PM Changeset in webkit [40261] by
-
- 1 edit in trunk/LayoutTests/fast/leaks/001-expected.txt
Land new layout tests now that display:compact support has been removed.
- 1:51 PM Changeset in webkit [40260] by
-
- 1 edit in trunk/LayoutTests/platform/mac/fast/forms/form-hides-table-expected.txt
Land new layout tests now that display:compact support has been removed.
- 1:51 PM Changeset in webkit [40259] by
-
- 7 edits in trunk/LayoutTests/platform/mac/fast/compact
Land new layout tests now that display:compact support has been removed.
- 1:50 PM Changeset in webkit [40258] by
-
- 10 edits in trunk/WebCore
2009-01-26 David Hyatt <hyatt@apple.com>
Drop support for display:compact.
(1) display:compact is no longer part of CSS2.1.
(2) Shipping Safari has completely broken compact support with severely broken rendering
(all of the compact text just piles on top of the text in the inserted block and on top of itself as well).
(3) This has been broken in WebKit for years (ever since blocks converted to painting lines directly) without
anyone even noticing.
Reviewed by Eric Seidel
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleSpecialChild): (WebCore::RenderBlock::handleRunInChild): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::positionForCoordinates): (WebCore::shouldCheckLines): (WebCore::getHeightForLineCount): (WebCore::RenderBlock::renderName):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::sizesToIntrinsicWidth):
- rendering/RenderBox.h: (WebCore::RenderBox::width): (WebCore::RenderBox::height): (WebCore::RenderBox::size): (WebCore::RenderBox::frameRect):
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): (WebCore::RenderFlow::hitTestLines): (WebCore::RenderFlow::absoluteClippedOverflowRect): (WebCore::RenderFlow::linesBoundingBox):
- rendering/RenderObject.h: (WebCore::RenderObject::isInline):
- rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren):
- rendering/bidi.h: (WebCore::BidiRun::BidiRun):
- 1:44 PM Changeset in webkit [40257] by
-
- 2 edits in trunk/WebKit/mac
Fix the build.
Remove -Wformat=2 from the warning flags as newer versions of GCC emit
warnings about non-literal format strings for uses of our UI_STRING macro.
- Configurations/Base.xcconfig:
- 1:42 PM Changeset in webkit [40256] by
-
- 2 edits in trunk/WebKitTools
2009-01-26 Pierre-Olivier Latour <pol@apple.com>
Tweaked again earlier fix, this time just to print a warning and not abort if
attempting to generate pixel results and Perian is installed.
- Scripts/run-webkit-tests:
- 12:55 PM Changeset in webkit [40255] by
-
- 2 edits in trunk/WebCore
2009-01-26 Adam Langley <agl@google.com>
Reviewed by Nikolas Zimmermann.
gtk2drawing: fix compiler warnings
g_object_set_data expects a gpointer as the last argument. Cast the
TRUE/FALSE values to avoid a warning.
gtk_tree_view_column_new doesn't return a GtkWidget.
- platform/gtk/gtk2drawing.c: (setup_widget_prototype): (moz_gtk_get_combo_box_inner_button): (moz_gtk_get_combo_box_button_inner_widgets): (ensure_combo_box_widgets): (moz_gtk_get_combo_box_entry_inner_widgets): (moz_gtk_get_combo_box_entry_arrow): (ensure_combo_box_entry_widgets): (ensure_toolbar_widget): (ensure_menu_bar_item_widget): (ensure_menu_popup_widget): (ensure_menu_item_widget): (ensure_image_menu_item_widget): (ensure_menu_separator_widget): (ensure_check_menu_item_widget): (ensure_tree_header_cell_widget): (moz_gtk_entry_paint):
- 12:14 PM Changeset in webkit [40254] by
-
- 4 edits in trunk
2009-01-26 David Hyatt <hyatt@apple.com>
Change display:run-in handling so that we no longer reuse RenderBlock as though it is an inline flow.
Instead we create a new RenderInline, move the RenderBlock's children underneath it, and then set the
inline as the new element's renderer.
Reviewed by Dan Bernstein
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):
- rendering/RenderInline.cpp: (WebCore::RenderInline::renderName):
- 11:43 AM Changeset in webkit [40253] by
-
- 5 edits in trunk/WebKit
Clean up after r40240.
Rubber-stamped by Sam Weinig.
- WebKit.xcodeproj/project.pbxproj: Reinstate WebKitPluginHost.defs.
- Configurations/Base.xcconfig: Don't dead code strip in debug builds for now as it leads to link errors.
- Plugins/Hosted/HostedNetscapePluginStream.mm: Revert change that is no longer needed now that WebKitPluginHost.defs
is back in the build.
- 10:48 AM Changeset in webkit [40252] by
-
- 2 edits in trunk/WebKit/win
Fix an assertion failure when Safari loads an error page
Reviewed by Alexey Proskuryakov.
- WebFrame.cpp: (WebFrame::loadData): Use the two-argument version of KURL and MarshallingHelpers::BSTRToKURL, for reasons mentioned in r40248.
- 10:46 AM Changeset in webkit [40251] by
-
- 2 edits in trunk/WebKitTools
2009-01-26 Christian Dywan <christian@twotoasts.de>
Rubber stamped by Holger Freyther.
- GtkLauncher/main.c: (main): Initialize threads, which is required for libSoup.
- 8:46 AM Changeset in webkit [40250] by
-
- 3 edits in trunk/WebKit/qt
2009-01-26 David Boddie <dboddie@trolltech.com>
Reviewed by Simon Hausmann.
Doc: qdoc fix for a link to a property and added a basic description of the offline caching and storage features from HTML 5.
- 8:44 AM Changeset in webkit [40249] by
-
- 2 edits in trunk/WebCore
2009-01-26 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23480
Add missing method stubs to BackForwardListChromium.
- history/BackForwardListChromium.cpp: (WebCore::BackForwardList::backItem): (WebCore::BackForwardList::forwardItem):
- 7:19 AM Changeset in webkit [40248] by
-
- 5 edits in trunk/WebKit/win
Fix an assertion on launch in KURL::KURL
All URL strings passed in to the WebKit API need to be passed to
MarshallingHelpers::BSTRToKURL so that they may be properly parsed.
Reviewed by Alexey Proskuryakov.
- MarshallingHelpers.cpp: (MarshallingHelpers::BSTRToKURL): Changed to use the two-argument constructor for KURL so that the strings will be parsed rather than assumed to be in the correct encoding/form.
- WebResource.cpp: (WebResource::initWithData):
- WebURLResponse.cpp: (WebURLResponse::initWithURL):
- WebView.cpp: (WebView::userAgentForURL): (WebView::copyURL): Changed to use MarshallingHelpers::BSTRToKURL instead of trying to do the work manually.
- 6:03 AM QtWebKitJournal edited by
- (diff)
- 2:16 AM Changeset in webkit [40247] by
-
- 3 edits in trunk/LayoutTests
2009-01-26 Darin Adler <Darin Adler>
Requested by David Hyatt.
- platform/mac/fast/table/form-with-table-style-expected.checksum: Updated to reflect the progression; we now render things we used to fail to render.
- platform/mac/fast/table/form-with-table-style-expected.png: Ditto.
Jan 25, 2009:
- 11:31 PM Changeset in webkit [40246] by
-
- 2 edits in trunk/WebKit/gtk
2009-01-25 Darin Adler <Darin Adler>
Try to fix GTK build.
- webkit/webkitwebview.cpp: Added include of FloatQuad.h.
- 11:29 PM Changeset in webkit [40245] by
-
- 4 edits in trunk/WebKit
WebKit:
2009-01-25 Darin Adler <Darin Adler>
Try to fix full build on Mac Leopard.
- WebKit.xcodeproj/project.pbxproj: Removed WebKitPluginClient.defs from the WebKit target. Maybe this is temporary, but I had to do it to get the full build to succeed.
WebKit/mac:
2009-01-25 Darin Adler <Darin Adler>
- Plugins/Hosted/HostedNetscapePluginStream.mm: Added a missing extern "C".
- 11:26 PM Changeset in webkit [40244] by
-
- 2 edits in trunk/WebKit/win
2009-01-25 Darin Adler <Darin Adler>
Try to fix Windows build.
- WebView.cpp: Added FloatQuad.h.
- 11:14 PM Changeset in webkit [40243] by
-
- 3 edits in trunk/WebCore
2009-01-25 Darin Adler <Darin Adler>
Try to fix Tiger buildbot.
- WebCore.xcodeproj/project.pbxproj: Turn off cast-qual for WebDashboardRegion.m.
- page/mac/WebDashboardRegion.m: (typeName): Added. (-[WebDashboardRegion description]): Use typeName. (-[WebDashboardRegion isEqual:]): Added comment.
- 10:42 PM Changeset in webkit [40242] by
-
- 8 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23535
Strengthen debug checks in KURL
Covered (and prompted) by existing tests.
- platform/KURL.cpp: (WebCore::checkEncodedString): Check that the first character of the URL is an allowed first scheme character, not just that it isn't a slash. (WebCore::KURL::KURL): Assert that parsing didn't affect the string (which must be the case because of parsing being idempotent).
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::create): Added a check for the URL being valid - if it is not, an empty security origin is created. (WebCore::SecurityOrigin::createFromString): Parse the string as URL, do not just convert it - it is not guaranteed to be properly encoded.
- dom/Document.cpp: (WebCore::Document::updateBaseURL): As documentURI is an arbitrary string, it needs to be parsed into an URL, not just converted into one.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern): Create the security origin with createFromString() instead of create(). I do not know where the string comes from and whether it might not be properly encoded, but this change can't hurt, and makes the code slightly more clear.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::accessControlCheck): Create the security origin with createFromString() instead of create(). The string comes from an HTTP response header, so it may not be a properly encoded URL.
- loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): Do not try to request using invalid URLs.
- page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Updated to call SecurityOrigin::createFromString() (no change in behavior).
- 9:13 PM Changeset in webkit [40241] by
-
- 2 edits in trunk/WebKit/mac
2009-01-25 Darin Adler <Darin Adler>
Discussed with Mark Rowe; not sure he reviewed it.
- Configurations/Base.xcconfig: Add all the same warnings as in WebCore except for -Wcast-qual and -Wunused-parameter, which both need to be off at least for now.
- 8:14 PM Changeset in webkit [40240] by
-
- 8 edits in trunk
Improve the consistency of settings in our .xcconfig files.
Rubber-stamped by Dan Bernstein.
- 7:40 PM Changeset in webkit [40239] by
-
- 1 edit in trunk/LayoutTests/platform/mac/fast/table/form-with-table-style-expected.txt
Land table/forms layout test progression.
- 7:38 PM Changeset in webkit [40238] by
-
- 9 edits4 adds in trunk
WebCore:
2009-01-25 David Hyatt <hyatt@apple.com>
Fix for https://bugs.webkit.org/show_bug.cgi?id=23524, lots of missing content in table sections.
The new table code created a bug involving markAllDescendantsWithFloatsForLayout, namely that it could
end up marking ancestors of a block as needing layout when that block was still in the process of
doing a layout.
The fix is to add a parameter to markAllDescendantsWithFloatsForLayout that says whether or not
we are "mid-layout." If this flag is set, then the method will make sure to do only local dirtying
of objects to avoid accidentally marking a clean ancestor as needing layout again.
Ultimately the second parameter to setNeedsLayout and setChildNeedsLayout should just be removed,
with a check of whether or not we are mid-layout being done by those methods instead.
Reviewed by Oliver Hunt
Added fast/repaint/dynamic-table-vertical-alignment-change.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
- rendering/RenderBlock.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::removeFromObjectLists):
- rendering/RenderObject.h:
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows):
LayoutTests:
2009-01-25 David Hyatt <hyatt@apple.com>
Add layout test for https://bugs.webkit.org/show_bug.cgi?id=23524.
Reviewed by Oliver Hunt
- fast/repaint/dynamic-table-vertical-alignment-change.html: Added.
- platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.checksum: Added.
- platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.png: Added.
- platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.txt: Added.
- 7:02 PM Changeset in webkit [40237] by
-
- 4 edits in trunk
2009-01-25 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352
Turn on the following warnings:
-Wcast-qual
-Wextra-tokens
-Wformat=2
-Winit-self
-Wmissing-noreturn
-Wpacked
-Wrendundant-decls
- Configurations/Base.xcconfig: Added the new warnings. Switched to -Wextra instead of -W for clarity since we don't have to support the older versions of gcc that require the old -W syntax. Since we now use -Wformat=2, removed -Wformat-security. Also removed -Wno-format-y2k since we can have that one on now.
WebCore:
2009-01-25 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352
Turn on the following warnings:
-Wcast-qual
-Wextra-tokens
-Wformat=2
-Winit-self
-Wmissing-noreturn
-Wpacked
-Wrendundant-decls
- Configurations/Base.xcconfig: Added the new warnings. Switched to -Wextra instead of -W for clarity since we don't have to support the older versions of gcc that require the old -W syntax. Since we now use -Wformat=2, removed -Wformat-security. Also removed -Wno-format-y2k since we can have that one on now.
- 5:32 PM Changeset in webkit [40236] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Oliver Hunt.
- fix <rdar://problem/6525618> REGRESSION (r39566): NewsFire crashes in string hashing code when opening a Digg RSS article
Test: fast/loader/null-request-after-willSendRequest.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Null-check the request returned from the client's willSendRequest method.
LayoutTests:
Reviewed by Oliver Hunt.
- test for <rdar://problem/6525618> REGRESSION (r39566): NewsFire crashes in string hashing code when opening a Digg RSS article
- fast/loader/null-request-after-willSendRequest-expected.txt: Added.
- fast/loader/null-request-after-willSendRequest.html: Added.
- 4:47 PM Changeset in webkit [40235] by
-
- 4 edits in trunk/WebCore
2009-01-25 David Hyatt <hyatt@apple.com>
Fix for <rdar://problem/6525392> REGRESSION (r40180): Scroll wheel events over text scroll the page
instead of the ancestor overflow (23525)
Make sure that we always call scroll() on the nearest enclosing RenderBox. No test case is possible
here, since wheel scrolling is currently untestable (the offset varies from machine to machine).
Reviewed by Dan Bernstein
- page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent): (WebCore::EventHandler::scrollOverflow):
- rendering/RenderObject.cpp: (WebCore::RenderObject::enclosingBox):
- rendering/RenderObject.h:
- 3:42 PM Changeset in webkit [40234] by
-
- 2 edits in trunk/WebCore
2009-01-25 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23538: REGRESSION (r39969): Garbage text instead of blank content rendered when plug-ins are disabled
https://bugs.webkit.org/show_bug.cgi?id=23538
rdar://problem/6523719
I'm not sure how to make a regression test for this, since it depends on plug-ins being disabled.
The main problem here is that when plug-ins were disabled, the code ignored the classId attribute and
the <embed> element entirely. That resulted in a page treating a Flash document as plain HTML rather
than doing fallback.
- rendering/RenderPartObject.cpp: (WebCore::createClassIdToTypeMap): Added. Broke this out into a separate function so we could get rid of an inelegant if statement. (WebCore::activeXType): Added. To avoid repeating the MIME type for ActiveX and possibly having a typo. (WebCore::havePlugin): Added. Helper function to make sure we don't forget the null check. (WebCore::serviceTypeForClassId): Give this function a return value since that's a more natural way to return a string than an "out" parameter. Fixed the logic to only prefer the ActiveX type over the type guessed from the classId when there actually is an ActiveX plug-in to use. The old function assumed there was one, which I presume right for Chrome on Windows when plug-ins are enabled, but wrong in many other cases, and wrong all the time for all clients on Mac. We don't want to assume either way. Use the new havePlugin function so we handle the case where pluginData is 0. (WebCore::shouldUseEmbedDescendant): Renamed. Simplified the comment. Changed to use serviceTypeForClassId instead of the old version that used an out parameter. Always use the <embed> if there isn't a plug-in that knows how to handle <object> elements. (WebCore::RenderPartObject::updateWidget): Removed null checks of pluginData. The two functions that use this data still need to be called; they still do something even if no plug-ins are present. And they have now been corrected to handle 0 properly.
- 1:19 PM Changeset in webkit [40233] by
-
- 2 edits in trunk/WebCore
2009-01-25 Darin Adler <Darin Adler>
- rendering/RenderMenuList.cpp: Fix build by adding back needed include.
- 1:11 PM Changeset in webkit [40232] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-25 Judit Jasz <jasy@inf.u-szeged.hu>
Reviewed by Darin Adler.
Compilation problem fixing
http://bugs.webkit.org/show_bug.cgi?id=23497
- jit/JITCall.cpp: (JSC::JIT::compileOpCall): Use JSValuePtr::encode.
- 12:27 PM Changeset in webkit [40231] by
-
- 5 edits in trunk
2009-01-25 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352
Fourth patch: Deal with the last few stray warnings.
- parser/Parser.cpp: Only declare jscyyparse if it's not already declared. This makes both separate compilation and all-in-one compilation work with the -Wredundant-decls warning.
WebCore:
2009-01-25 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352
Fourth patch: Deal with the last few stray warnings.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::firstLineBlock): Handle the const_cast a little better. Also make the local variable be a RenderBlock so the cast is closer to the code that guarantees it's correct.
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): Put the enum into a local variable that's a built-in type before using it with TextStream, so we don't get a warning due to -Wsign-promo.
- 12:25 PM Changeset in webkit [40230] by
-
- 4 edits in trunk/JavaScriptCore
2009-01-25 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352
Third patch: Use the noreturn attribute on functions that don't
return to prepare for the use of the -Wmissing-noreturn warning.
- jit/JITCall.cpp: (JSC::unreachable): Added NO_RETURN.
- jsc.cpp: (functionQuit): Ditto. (printUsageStatement): Ditto.
- wtf/AlwaysInline.h: Added definition of NO_RETURN.
- 12:23 PM Changeset in webkit [40229] by
-
- 43 edits in trunk
WebCore:
2009-01-25 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 23522: use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522
Step one: RenderText.
Also change set of RenderFlow* to be a ListHashSet as the comment in the
header indicated.
- dom/CharacterData.cpp: (WebCore::CharacterData::setData): Use toRenderText. (WebCore::CharacterData::appendData): Ditto. (WebCore::CharacterData::insertData): Ditto. (WebCore::CharacterData::deleteData): Ditto. (WebCore::CharacterData::replaceData): Ditto.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): Ditto. (WebCore::ContainerNode::getLowerRightCorner): Ditto.
- dom/Position.cpp: (WebCore::nextRenderedEditable): Ditto. (WebCore::previousRenderedEditable): Ditto. (WebCore::Position::renderedOffset): Ditto. Also use function members instead of data members of InlineTextBox. (WebCore::Position::upstream): Ditto. (WebCore::Position::downstream): Ditto. (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): Ditto. (WebCore::Position::inRenderedText): Ditto. (WebCore::Position::isRenderedCharacter): Ditto. (WebCore::searchAheadForBetterMatch): Ditto. (WebCore::Position::getInlineBoxAndOffset): Ditto.
- dom/Range.cpp: Added include of VisiblePosition.h now that it's no longer included in RenderObject.h.
- dom/Text.cpp: (WebCore::Text::splitText): Use toRenderText. (WebCore::Text::recalcStyle): Ditto.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText): Ditto.
- editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer): Ditto.
- editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): Ditto. (WebCore::TextIterator::handleTextBox): Ditto. (WebCore::TextIterator::emitText): Ditto. (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto.
- editing/VisiblePosition.cpp: Added include of FloatQuad.h now that it's no longer included in RenderObject.h.
- inspector/InspectorController.cpp: Ditto.
- page/Frame.cpp: Ditto.
- rendering/RenderBox.cpp: Ditto.
- rendering/RenderInline.cpp: Ditto.
- rendering/RenderPath.cpp: Ditto.
- rendering/RenderSVGContainer.cpp: Ditto.
- rendering/RenderSVGImage.cpp: Ditto.
- rendering/RenderSVGInlineText.cpp: Ditto.
- rendering/RenderSVGTSpan.cpp: Ditto.
- rendering/RenderSVGText.cpp: Ditto.
- rendering/RenderSVGTextPath.cpp: Ditto.
- rendering/RenderTableCell.cpp: Ditto.
- rendering/RenderView.cpp: Ditto.
- editing/visible_units.cpp: (WebCore::startPositionForLine): Use function members instead of data members of InlineTextBox. (WebCore::endPositionForLine): Ditto. (WebCore::startOfParagraph): Use toRenderText. (WebCore::endOfParagraph): Ditto.
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Use toRenderText.
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Ditto.
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::deleteLine): Ditto. (WebCore::InlineTextBox::extractLine): Ditto. (WebCore::InlineTextBox::attachLine): Ditto. (WebCore::InlineTextBox::placeEllipsisBox): Ditto. (WebCore::InlineTextBox::paintDecoration): Ditto. (WebCore::InlineTextBox::paintCompositionUnderline): Ditto. (WebCore::InlineTextBox::offsetForPosition): Ditto. (WebCore::InlineTextBox::positionForOffset): Ditto.
- rendering/InlineTextBox.h: Made most members private. Use toRenderText.
- rendering/RenderArena.cpp: (WebCore::RenderArena::allocate): Use static_cast instead of C-style cast. (WebCore::RenderArena::free): Ditto.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::addContinuationWithOutline): Use ListHashSet<RenderFlow*> instead of RenderFlowSequencedSet. (WebCore::RenderBlock::paintContinuationOutlines): Ditto. (WebCore::stripTrailingSpace): Ditto. (WebCore::RenderBlock::calcInlinePrefWidths): Ditto. (WebCore::RenderBlock::updateFirstLetter): Ditto.
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): Use toRenderText.
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::dirtyLinesFromChangedChild): Use ListHashSet<RenderFlow*> instead of RenderFlowSequencedSet. (WebCore::RenderFlow::paintLines): Ditto.
- rendering/RenderMenuList.cpp: Removed some unneeded includes.
- rendering/RenderMenuList.h: Added now-needed forward declaration of RenderText. Made more members private.
- rendering/RenderObject.cpp: Updated includes. (WebCore::RenderObject::isEditable): Use toRenderText. (WebCore::RenderObject::positionForPoint): Made non-inline so we wouldn't have to include VisiblePosition.h in the header just for this.
- rendering/RenderObject.h: Removed unneeded includes and forward declarations. Changed special vertical position values to be constants rather than an enum. Eliminated RenderFlowSequencedSet, and changed clients to use ListHashSet<RenderFlow*>.
- rendering/RenderText.cpp: (WebCore::RenderText::findNextInlineTextBox): Use function members instead of data members of InlineTextBox. (WebCore::RenderText::positionForCoordinates): Ditto. (WebCore::isInlineFlowOrEmptyText): Use toRenderText. (WebCore::RenderText::previousCharacter): Use function members instead of data members of InlineTextBox. (WebCore::RenderText::position): Ditto. (WebCore::RenderText::caretMinOffset): Ditto. (WebCore::RenderText::caretMaxOffset): Ditto. (WebCore::RenderText::caretMaxRenderedOffset): Ditto.
- rendering/RenderText.h: Added definition of toRenderText.
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::textWithHardLineBreaks): Use toRenderText.
- rendering/RenderTreeAsText.cpp: (WebCore::operator<<): Use toRenderText and toRenderBox. (WebCore::writeTextRun): Ditto. (WebCore::write): Ditto.
- rendering/bidi.cpp: (WebCore::InlineIterator::increment): Use toRenderText. (WebCore::InlineIterator::current): Ditto. (WebCore::checkMidpoints): Ditto. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto. (WebCore::RenderBlock::layoutInlineChildren): Ditto. (WebCore::RenderBlock::determineStartPosition): Ditto. (WebCore::shouldSkipWhitespaceAfterStartObject): Ditto. (WebCore::RenderBlock::findNextLineBreak): Ditto.
WebKit/mac:
2009-01-25 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 23522: use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522
Step one: RenderText.
- WebView/WebRenderNode.mm: (copyRenderNode): Use toRenderText.
- 9:29 AM Changeset in webkit [40228] by
-
- 3 edits in trunk/WebKit/qt
2009-01-25 Urs Wolfer <uwolfer@kde.org>
Reviewed by Simon Hausmann.
Add QWebPage::SelectAll to WebAction enum to select all content.
- 9:26 AM Changeset in webkit [40227] by
-
- 2 edits in trunk/WebCore
2009-01-25 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Simon Hausmann.
Fix gcc compiler warning (deprecated conversion from constant string to char*)
"" cannot be stored in a char*
- 9:22 AM Changeset in webkit [40226] by
-
- 2 edits in trunk/WebKit/qt
2009-01-25 David Boddie <dboddie@trolltech.com>
Reviewed by Simon Hausmann.
Doc: Fixed the terminology used.
- 9:20 AM Changeset in webkit [40225] by
-
- 2 edits in trunk/WebKit/qt
2009-01-25 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Simon Hausmann.
Rename links from trolltech.com to qtsoftware.com
- 9:04 AM Changeset in webkit [40224] by
-
- 2 edits in trunk/WebKit/qt
2009-01-25 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon Hausmann.
Make QWebPage auto-test more robust by cleaning up generated files
Sometimes the auto-test may segfault, leaving behind files because the
call to cleanupTestCase() never happens, so we also clean up the files
at initTestCase() just to make sure we're running in a clean environment.
- 8:27 AM QtWebKitJournal edited by
- (diff)
- 8:21 AM QtWebKitTodo edited by
- (diff)
- 6:56 AM Changeset in webkit [40223] by
-
- 2 edits in trunk/WebKit/qt
2008-12-20 Urs Wolfer <uwolfer@kde.org>
Reviewed by Simon Hausmann.
Fix: compile qwebhistory.h with pendantic comiler flag.
- 4:03 AM Changeset in webkit [40222] by
-
- 1 edit in trunk/WebCore/ChangeLog
Remove a slightly misleading comment from ChangeLog - the issue is related to bug 23500, but not the same.
- 3:59 AM Changeset in webkit [40221] by
-
- 12 edits2 adds in trunk
Reviewed by Darin Adler.
<rdar://problem/5954398> REGRESSION: 1.1% PLT regression from 33577 and 33578 (encoding fixes)
WebCore:
Changed single argument KURL constructors back to always expect an already encoded string,
eliminating extra conversions.
This is a rather unstable situation, as it is often unclear whether a given string is safe
to convert to KURL without resolving. I think that going forward, the solution is to try to
keep encoded URLs as KURL instances, and not as strings.
- platform/KURL.h: Updated comments.
- platform/KURL.cpp: (WebCore::KURL::KURL): In debug builds, verify that the passed string is ASCII-only. The intention is to verify that it is already parsed and encoded by KURL or equivalent code, but since encoding is scheme-dependent, such a verification would be quite complicated. Don't encode the string as UTF-8, as it supposed to be ASCII-only. Removed a hack that made strings beginning with "/" turn into "file:" URLs. I didn't find any reason for it to exist, but I saw several cases where this code path was taken inadvertently (see examples in LayoutTests/ChangeLog). (WebCore::KURL::setProtocol): Using a user-provided string without validation or encoding is clearly wrong here (e.g., the "protocol" can be set to a full URL, effectively replacing the old one), and an already encoded string is expected by parse(). In debug builds, non-ASCII input will make an assertion in parse() fail. Added a FIXME. (WebCore::KURL::setHost): Ditto. (WebCore::KURL::setPort): Ditto. (WebCore::KURL::setHostAndPort): Ditto. (WebCore::KURL::setUser): Ditto. (WebCore::KURL::setPass): Ditto. (WebCore::KURL::setRef): Ditto. (WebCore::KURL::setQuery): Ditto. (WebCore::KURL::setPath): Ditto. Note that problems described in bug 23500 mask some of the problems in release builds currently, as the incorrectly parsed URL is ignored. (WebCore::KURL::parse): Verify that the passed string is already encoded.
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute): (WebCore::HTMLLinkElement::process):
- html/HTMLLinkElement.h: Changed to avoid using invalid URLs (this was causing problems on DNS prefetch tests, see LayoutTests/ChangeLog).
- loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Create an empty KURL without indirection for a small speedup. (WebCore::FrameLoader::requestFrame): Resolve and encode javascript URLs properly, now that String to KURL conversion requires the string to be already encoded.
- page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Resolve and encode the origin. HTML5 seems a little unclear on how this should work (it talks about "either parsing it as a URL, or resolving it", and then somehow compares unaltered targetOrigin string to a security origin object), so I just made the code as close to what we already had as possible.
LayoutTests:
- http/tests/misc/dns-prefetch-control-expected.txt:
- http/tests/misc/dns-prefetch-control.html: Google documentation for DNS Prefetch makes use of net-path relative URLs (server-name), explaining that scheme is not necessary. This is of course true, but this test uses data: subframes, and data: is a non-hierachical scheme, so resolving such URLs fails, resulting in a KURL object that is not valid. WebKit used to ignore this, and tried to create a URL from this string again, now with a single argument KURL constructor, which resulted in a valid file: URL, which was successfully used! Both issues have been corrected in WebCore, so I had to change the test to no longer use relative net-path URLs.
- http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
- http/tests/security/postMessage/invalid-origin-throws-exception.html: URLs that start with "/" are no longer converted to "file:" ones, so the results now match Firefox.
- http/tests/uri/resolve-encoding-relative-expected.txt: Added.
- http/tests/uri/resolve-encoding-relative.html: Added. Added a test to cover some cases of relative URL resolving that were not covered before. Expected results are taken from Firefox 3, and WebKit doesn't match in how fragments are encoded (we use document encoding, while Firefox uses UTF-8). Since fragments are not sent in HTTP requests, this is not too dangerous, but the Firefox behavior looks more consistent.
Jan 24, 2009:
- 4:34 PM Changeset in webkit [40220] by
-
- 2 edits in trunk/WebKit/qt
Oops, fix the Qt build.
- 2:41 PM Changeset in webkit [40219] by
-
- 3 edits in trunk/LayoutTests
2009-01-24 Eric Carlson <eric.carlson@apple.com>
<video> controls visibility test needs to dump render tree as text because
the test does not always end at the same time, so the timeline slider thumb
is not always at the same position.
- media/video-controls-visible-audio-only.html:
- platform/mac/media/video-controls-visible-audio-only-expected.txt:
- 2:39 PM Changeset in webkit [40218] by
-
- 4 edits in trunk/WebKit/qt
Add QWebFrame::renderContents() method which allows arbitary rendering
of any content region within the QWebFrame. It also does not draw any
scrollbars.
- 12:59 PM Changeset in webkit [40217] by
-
- 3 edits in trunk/LayoutTests
2009-01-24 Darin Adler <Darin Adler>
Try to fix expected results for new video element test.
- platform/mac/media/video-controls-visible-audio-only-expected.png: Landed new result generated on my machine.
- platform/mac/media/video-controls-visible-audio-only-expected.txt: Ditto.
- 12:40 PM Changeset in webkit [40216] by
-
- 2 edits in trunk/WebCore
2009-01-24 Darin Adler <Darin Adler>
Try to fix Qt build.
- WebCore.pro: Added JSTextCustom.cpp.
- 7:10 AM Changeset in webkit [40215] by
-
- 8 edits in trunk/WebCore
Change styleAvailable functionality to be a linked list
rather than scanning every CompositeAnimation for
Animations that are waiting for styleAvailable. This has
potential for large performance improvement in cases where
there are many animations firing at once. But it will also
help in my next fix, which is to synchronize software and
accelerated animations.
I also changed slightly when the beginAnimationUpdate and
endAnimationUpdate calls are made. But this has no real
effect on performance or behavior.
- 1:55 AM Changeset in webkit [40214] by
-
- 2 edits in trunk/JavaScriptCore
Force inlining of Lexer::matchPunctuator
Reviewed by Maciej Stachowiak.
2.2% win when parsing jQuery, Mootools, Prototype, etc
- 1:39 AM Changeset in webkit [40213] by
-
- 5 edits2 adds in trunk
Reviewed by Darin Adler.
<rdar://problem/6368059> REGRESSION: URL encoding problems on http://www.cineman.ch
Test: http/tests/xmlhttprequest/encode-request-url-2.html
- platform/KURL.cpp: (WebCore::appendASCII): Added a helper function. (WebCore::KURL::KURL): Explicitly encode the URL to call two-argument parse() with better specified behavior. (WebCore::KURL::init): Ditto. This avoids trying to round-trip an URL encoded into a byte stream, but not yet transformed to ASCII-only using percent escapes. Since different parts of the byte stream can use different encodings, round-tripping is not possible. (WebCore::KURL::parse): Reverted an earlier change that made the single-argument version of this function convert the string to utf-8. I think that on the remanining code paths, it is correct to assume that the string is all ASCII, but I'm not yet confident enough to drop a FIXME warning.
- 12:05 AM Changeset in webkit [40212] by
-
- 2 edits in trunk/WebCore
2009-01-24 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix after r40170
- GNUmakefile.am: Removed editing/RemoveNodeAttributeCommand.cpp and editing/RemoveNodeAttributeCommand.h
Jan 23, 2009:
- 10:19 PM Changeset in webkit [40211] by
-
- 2 edits in trunk/WebCore
Fix the Qt build after r40205.
- 9:47 PM Changeset in webkit [40210] by
-
- 11 edits2 adds in trunk/WebCore
2009-01-23 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
In CachedPage, break off per-Frame pieces of data into a CachedFrame object.
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- history/CachedFrame.cpp: Added. (WebCore::cachedFrameCounter): (WebCore::CachedFrame::CachedFrame): (WebCore::CachedFrame::~CachedFrame): (WebCore::CachedFrame::restore): (WebCore::CachedFrame::clear): (WebCore::CachedFrame::setCachedFramePlatformData): (WebCore::CachedFrame::cachedFramePlatformData):
- history/CachedFrame.h: Added. (WebCore::CachedFrame::document): (WebCore::CachedFrame::documentLoader): (WebCore::CachedFrame::view): (WebCore::CachedFrame::mousePressNode): (WebCore::CachedFrame::url): (WebCore::CachedFrame::domWindow):
- history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore): (WebCore::CachedPage::clear): (WebCore::CachedPage::setCachedFramePlatformData): (WebCore::CachedPage::cachedFramePlatformData):
- history/CachedPage.h: (WebCore::CachedPage::document): (WebCore::CachedPage::documentLoader): (WebCore::CachedPage::view): (WebCore::CachedPage::mousePressNode): (WebCore::CachedPage::url): (WebCore::CachedPage::domWindow):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePageForHistoryItem): Setting the DocumentLoader independently of creating a CachedPage was a historical relic. Take the opportunity to clean that up.
- 7:59 PM Changeset in webkit [40209] by
-
- 11 edits in trunk/WebCore
2009-01-23 David Hyatt <hyatt@apple.com>
Add ASSERTs to catch anyone trying to obtain the width/height of an inline flow. Fix up all the places
that triggered the ASSERT (since all of these places are effectively regressions from my landing that
devirtualized width()/height()).
Reviewed by Adele
- dom/Position.cpp: (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- rendering/RenderBox.cpp: (WebCore::RenderBox::clientWidth): (WebCore::RenderBox::clientHeight): (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight): (WebCore::RenderBox::absoluteOutlineBounds):
- rendering/RenderBox.h: (WebCore::RenderBox::width): (WebCore::RenderBox::height): (WebCore::RenderBox::size): (WebCore::RenderBox::frameRect): (WebCore::RenderBox::borderBoundingBox):
- rendering/RenderFlow.h: (WebCore::RenderFlow::borderBoundingBox):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
- rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::styleWillChange):
- rendering/RenderScrollbarPart.h:
- wml/WMLAElement.cpp: (WebCore::WMLAElement::isKeyboardFocusable):
- 7:03 PM Changeset in webkit [40208] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Fix for <rdar://problem/6126212>
Ensure that callbacks out from the JSC interface are only allowed
to return in reverse-chronological order to that in which they were
made. If we allow earlier callbacks to return first, then this may
result in setions of the RegisterFile in use by another thread
being trampled.
See uber-comment in JSLock.h for details.
- runtime/JSLock.cpp: (JSC::JSLock::DropAllLocks::DropAllLocks): (JSC::JSLock::DropAllLocks::~DropAllLocks):
- 6:39 PM Changeset in webkit [40207] by
-
- 4 edits in trunk/WebCore
2009-01-23 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352
Second patch: Slightly less simple cases of various warnings.
- bridge/jni/jni_runtime.h: (JSC::Bindings::JavaString::_commonInit): Use reinterpret_cast here and avoid casting away const.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::PendingCallbacks::appendStartElementNSCallback): Use static_cast instead of reinterpret_cast; this is casting the result of malloc, and the idiom is to use static_cast, which works because we're casting from void*. (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): Use const_cast instead C-style casts.
- xml/XSLTUnicodeSort.cpp: (inlineXSLTTransformError): Tweak soft linking of xsltTransformError to use a macro instead of redefining the function.
- 6:23 PM Changeset in webkit [40206] by
-
- 2 edits in trunk/WebCore
2009-01-23 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
Bug 23475: fast/text/find-backwards.html fails with ICU disabled SearchBuffer
https://bugs.webkit.org/show_bug.cgi?id=23475
- editing/TextIterator.cpp: (WebCore::SearchBuffer::search): Set the character start flag to false to ensure we won't ever return the same result twice. There are other ways we could accomplish this, mentioned in the comment, but this one was the smallest and cleanest I could think of.
- 6:22 PM Changeset in webkit [40205] by
-
- 7 edits1 copy in trunk/WebCore
2009-01-23 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
Bug 23510: REGRESSION (r40171): CDATASection objects not getting proper JavaScript wrappers
https://bugs.webkit.org/show_bug.cgi?id=23510
That patch fixed the optimization that's supposed to give a faster path for
allocating the wrappers for DOM Text objects. But CDATASection is the one
subclass of Text objects.
- GNUmakefile.am: Added JSCDATASectionCustom.cpp.
- WebCore.scons: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- WebCoreSources.bkl: Ditto.
- bindings/js/JSCDATASectionCustom.cpp: Copied from bindings/js/JSTextCustom.cpp. (WebCore::toJSNewlyCreated): Changed to do CDATASection, not Text.
- bindings/scripts/CodeGeneratorJS.pm: Added another toJSNewlyCreated function for CDATASection. We don't want to have to check when creating a wrapper for a Text object whether it's a CDATASection object or not, so we need to do this overload at compile time.
- 6:00 PM Changeset in webkit [40204] by
-
- 36 edits4 adds in trunk/WebCore
Reviewed by Eric Seidel.
Add a base class for WML form control elements: WMLFormControlElement (as it's designed in HTML as well).
WMLFormControlElement inherits from WMLElement and FormControlElement (just like the HTMLFormControlElement equivalent).
WMLInputElement / WMLOptionElement / WMLOptGroupElement are supposed to inherit from the new WMLFormControlElement class.
Now WMLInputElement & WMLOptGroupElement only inherit from WMLElement and FormControlElement, but WMLOptionElement inherits
from WMLEventHandlingElement (which in turn inherits from WMLElement) and FormControlElement. In order to introduce a shared
base class, WMLEventHandlingElement is no longer allowed to inherit from WMLElement directly. Instead it should turn into
another base class, just like FormControlElement.
Add a base class for form control elements 'with state': FormControlElementWithState, serving as base class for
HTMLFormControlElementWithState and WMLFormControlElementWithState. -> Make Document operate on FormControlElementWithState
objects instead of HTMLFormControlElementWithState objects, to support save/restore control state for non HTMLFormControlElements.
Rename isGenericFormElement() to isFormControlElement(), and move it to Element.h
Add new virtual function isFormControlElementWithState() to Element.h.
- 5:23 PM Changeset in webkit [40203] by
-
- 3 edits in trunk/WebKit/win
Bug 23492: Separating the WebKitSystemInterface Calls.
- 5:21 PM Changeset in webkit [40202] by
-
- 3 edits in trunk/WebCore
Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]
Move null checking into makeRange
- 4:54 PM Changeset in webkit [40201] by
-
- 2 edits in trunk/WebCore
Fix the Gtk build too after removal of RenderBox::toConstRenderBox
- 4:52 PM Changeset in webkit [40200] by
-
- 2 edits in trunk/WebCore
Fix the Qt build after rename of RenderBox::toConstRenderBox -> toRenderBox
- 4:47 PM Changeset in webkit [40199] by
-
- 2 edits in trunk/WebCore
Fix the Qt build after r40168.
- 4:26 PM Changeset in webkit [40198] by
-
- 15 edits3 moves in trunk
WebCore:
2009-01-23 Brady Eidson <beidson@apple.com>
Rubberstamped by Darin Adler
Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.order:
- WebCore.xcodeproj/project.pbxproj:
- history/CachedFramePlatformData.h: Copied from WebCore/history/CachedPagePlatformData.h. (WebCore::CachedFramePlatformData::~CachedFramePlatformData):
- history/CachedPagePlatformData.h: Removed.
- history/CachedPage.cpp: (WebCore::CachedPage::clear): (WebCore::CachedPage::setCachedFramePlatformData): (WebCore::CachedPage::cachedFramePlatformData):
- history/CachedPage.h:
WebKit:
2009-01-23 Brady Eidson <beidson@apple.com>
Rubberstamped by Darin Adler
Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2009-01-23 Brady Eidson <beidson@apple.com>
Rubberstamped by Darin Adler
Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
- WebCoreSupport/WebCachedFramePlatformData.h: Copied from WebKit/mac/WebCoreSupport/WebCachedPagePlatformData.h. (WebCachedFramePlatformData::WebCachedFramePlatformData):
- WebCoreSupport/WebCachedPagePlatformData.h: Removed.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::savePlatformDataToCachedPage): (WebFrameLoaderClient::transitionToCommittedFromCachedPage):
- WebKit.order:
WebKit/win:
2009-01-23 Brady Eidson <beidson@apple.com>
Rubberstamped by Darin Adler
Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
- WebCachedFramePlatformData.h: Copied from WebKit/win/WebCachedPagePlatformData.h. (WebCachedFramePlatformData::WebCachedFramePlatformData):
- WebCachedPagePlatformData.h: Removed.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::savePlatformDataToCachedPage):
- WebKit.vcproj/WebKit.vcproj:
- 4:23 PM Changeset in webkit [40197] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Fix drawing in situations where sub-portions of the bitmap are to be drawn to the screen.
- 4:19 PM Changeset in webkit [40196] by
-
- 3 edits in trunk/WebCore
Build fixes for recent changes.
- 3:33 PM Changeset in webkit [40195] by
-
- 1 edit in trunk/WebCore/rendering/RenderThemeWin.cpp
Fix Windows bustage.
- 3:33 PM Changeset in webkit [40194] by
-
- 1 edit in trunk/WebCore/page/EventHandler.cpp
Fix Windows bustage.
- 3:33 PM Changeset in webkit [40193] by
-
- 5 edits4 adds in trunk
2009-01-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson
Implement QTMovieWin::hasVideo so the controller on an audio-only <video> element
is never hidden (as with an <audio> element).
Test: media/video-controls-visible-audio-only.html
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::hasVideo):
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::hasVideo):
- platform/graphics/win/QTMovieWin.h:
2009-01-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson
Test for behavior of <video> element controller when a media file has
only audio.
https://bugs.webkit.org/show_bug.cgi?id=23407
- media/video-controls-visible-audio-only.html: Added.
- platform/mac/media/video-controls-visible-audio-only-expected.checksum: Added.
- platform/mac/media/video-controls-visible-audio-only-expected.png: Added.
- platform/mac/media/video-controls-visible-audio-only-expected.txt: Added.
- 3:25 PM Changeset in webkit [40192] by
-
- 33 edits in trunk/WebCore
2009-01-23 David Hyatt <hyatt@apple.com>
Make toRenderBox a non-member function. Rename toConstRenderBox to just also be called toRenderBox.
Reviewed by Oliver Hunt
- css/CSSComputedStyleDeclaration.cpp: (WebCore::sizingBox): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner):
- dom/Element.cpp: (WebCore::Element::scrollByUnits):
- dom/Position.cpp: (WebCore::endsOfNodeAreVisuallyDistinctPositions): (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): (WebCore::Position::isCandidate):
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
- editing/EditorCommand.cpp: (WebCore::verticalScrollDistance):
- editing/TextIterator.cpp: (WebCore::shouldEmitExtraNewlineForNode):
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isFocusable):
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::width): (WebCore::HTMLFrameElementBase::height):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::updateAutoscrollRenderer): (WebCore::EventHandler::stopAutoscrollTimer): (WebCore::EventHandler::scrollOverflow):
- page/FrameView.cpp: (WebCore::FrameView::layout):
- page/animation/AnimationBase.cpp: (WebCore::blendFunc):
- rendering/InlineBox.cpp: (WebCore::InlineBox::adjustPosition):
- rendering/InlineBox.h: (WebCore::InlineBox::renderBox):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloats):
- rendering/RenderBox.cpp: (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeAbsoluteRepaintRect): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
- rendering/RenderBox.h: (WebCore::toRenderBox): (WebCore::RenderBox::previousSiblingBox): (WebCore::RenderBox::nextSiblingBox): (WebCore::RenderBox::parentBox):
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::resize): (WebCore::RenderLayer::boundingBox):
- rendering/RenderObject.cpp: (WebCore::addLayers): (WebCore::RenderObject::removeLayers): (WebCore::RenderObject::moveLayers): (WebCore::RenderObject::findNextLayer): (WebCore::RenderObject::enclosingLayer): (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setNeedsPositionedMovementLayout): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline): (WebCore::RenderObject::computeAbsoluteRepaintRect): (WebCore::RenderObject::localToAbsolute): (WebCore::RenderObject::absoluteToLocal): (WebCore::RenderObject::localToAbsoluteQuad): (WebCore::RenderObject::offsetFromContainer): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::destroy): (WebCore::RenderObject::updateHitTestResult): (WebCore::RenderObject::addDashboardRegions):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::hitTestMediaControlPart): (WebCore::RenderTheme::baselinePosition):
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::hitTestMediaControlPart):
- rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation):
- rendering/bidi.cpp: (WebCore::inlineWidth): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::requiresLineBox): (WebCore::RenderBlock::findNextLineBreak):
- svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
- wml/WMLAElement.cpp: (WebCore::WMLAElement::isKeyboardFocusable):
- wml/WMLInputElement.cpp: (WebCore::isInputFocusable):
- 3:03 PM Changeset in webkit [40191] by
-
- 2 edits in trunk/WebCore
2009-01-23 Chris Fleizach <Chris Fleizach>
Reviewed by Beth Dakin.
Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]
https://bugs.webkit.org/show_bug.cgi?id=23509
Add null checking around next/previous sentence retrieval in AX code
- page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::nextSentenceEndPosition): (WebCore::AccessibilityObject::previousSentenceStartPosition):
- 2:50 PM Changeset in webkit [40190] by
-
- 2 edits in trunk/WebKit/mac
2009-01-23 Adele Peterson <adele@apple.com>
Build fix.
Use new linesBoundingBox method instead of
boundingBoxWidth and boundingBoxHeight for RenderText objects.
- WebView/WebRenderNode.mm: (copyRenderNode):
- 2:41 PM Changeset in webkit [40189] by
-
- 2 edits in trunk/WebKit/wx
wx build fix, add missing include dir.
- 2:39 PM Changeset in webkit [40188] by
-
- 2 edits in trunk/WebKitTools
2009-01-23 David Kilzer <ddkilzer@apple.com>
- Scripts/do-webcore-rename: Removed 10 header guard renames that had already been fixed, and updated 4 renames whose original values had changed.
- 2:38 PM Changeset in webkit [40187] by
-
- 1 edit in trunk/JavaScriptCore/DerivedSources.make
Added missing comma to copyright.
- 2:20 PM Changeset in webkit [40186] by
-
- 3 edits in trunk/LayoutTests/platform/mac/svg/batik/text
Land new results now that text runs at negative positions dump their widths correctly.
- 2:19 PM Changeset in webkit [40185] by
-
- 1 edit in trunk/LayoutTests/platform/mac/editing/style/smoosh-styles-003-expected.txt
Land new results now that text runs at negative positions dump their widths correctly.
- 2:19 PM Changeset in webkit [40184] by
-
- 3 edits in trunk/LayoutTests/platform/mac/fast
Update the test results for compacts and run-ins now that they dump accurate positions.
- 2:18 PM Changeset in webkit [40183] by
-
- 4 adds in trunk/LayoutTests
Add new repaint test for hover regression.
- 2:17 PM Changeset in webkit [40182] by
-
- 14 edits in trunk/WebCore
2009-01-23 David Hyatt <hyatt@apple.com>
Fix for <rdar://problem/6518850> REGRESSION: hover feedback not showing on many sites
Inline flow repainting was broken because it relied on width() and height(). Give RenderFlow a linesBoundingBox
method for obtaining a reasonable bounding box to use for repainting. Eliminate the methods from RenderInline
since compacts/run-ins need them too, so putting them on RenderFlow is necessary.
For consistency, change RenderText's version of these methods into the single linesBoundingBox method as
well.
Reviewed by Oliver Hunt
- WebCore.base.exp:
- dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner):
- dom/Position.cpp: (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
- rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockHeightForPositioned):
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect): (WebCore::RenderFlow::linesBoundingBox):
- rendering/RenderFlow.h:
- rendering/RenderInline.cpp:
- rendering/RenderInline.h: (WebCore::RenderInline::offsetWidth): (WebCore::RenderInline::offsetHeight):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
- rendering/RenderText.cpp: (WebCore::RenderText::linesBoundingBox):
- rendering/RenderText.h:
- rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
- rendering/SVGRenderTreeAsText.cpp: (WebCore::write):
- 1:28 PM Changeset in webkit [40181] by
-
- 1 edit in trunk/WebCore/rendering/RenderFlow.cpp
Fix RenderFlow. Botched the application of my patch.
- 1:25 PM Changeset in webkit [40180] by
-
- 47 edits in trunk/WebCore
2009-01-23 David Hyatt <hyatt@apple.com>
Move layer() into RenderBox and make it non-virtual. Move all of the scrolling functions from RenderObject
to RenderBox and devirtualize as many as possible. Clean up styleWillChange to factor code specific to
RenderBox and RenderBlock into their appropriate subclasses. Stubbed out an empty styleWillChange on
RenderText, since none of the work done in styleWillChange was relevant to text nodes.
Reviewed by Sam Weinig
- dom/Document.cpp: (WebCore::Document::elementFromPoint): (WebCore::Document::renderView): (WebCore::Document::prepareMouseEvent):
- dom/Document.h:
- dom/Element.cpp: (WebCore::Element::scrollByUnits):
- editing/SelectionController.cpp: (WebCore::SelectionController::contains):
- html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::start): (WebCore::HTMLMarqueeElement::stop):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::topRenderer): (WebCore::AccessibilityRenderObject::visiblePositionForPoint): (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
- page/AccessibilityRenderObject.h:
- page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::updateAutoscrollRenderer): (WebCore::EventHandler::stopAutoscrollTimer): (WebCore::EventHandler::scrollOverflow): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::hoverTimerFired):
- page/Frame.cpp: (WebCore::Frame::clearTimers):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange): (WebCore::RenderBox::verticalScrollbarWidth): (WebCore::RenderBox::horizontalScrollbarHeight): (WebCore::RenderBox::scroll): (WebCore::RenderBox::canBeProgramaticallyScrolled): (WebCore::RenderBox::autoscroll): (WebCore::RenderBox::panScroll): (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeAbsoluteRepaintRect):
- rendering/RenderBox.h: (WebCore::RenderBox::layer): (WebCore::RenderBox::requiresLayer): (WebCore::RenderBox::stopAutoscroll): (WebCore::RenderBox::hasAutoVerticalScrollbar): (WebCore::RenderBox::hasAutoHorizontalScrollbar): (WebCore::RenderBox::scrollsOverflow): (WebCore::RenderBox::scrollsOverflowX): (WebCore::RenderBox::scrollsOverflowY): (WebCore::RenderBox::includeVerticalScrollbarSize): (WebCore::RenderBox::includeHorizontalScrollbarSize):
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect): (WebCore::RenderFlow::addFocusRingRects):
- rendering/RenderForeignObject.cpp:
- rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::requiresLayer):
- rendering/RenderInline.cpp:
- rendering/RenderInline.h: (WebCore::RenderInline::requiresLayer):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::childrenClipRect): (WebCore::RenderLayer::selfClipRect):
- rendering/RenderListBox.cpp:
- rendering/RenderListBox.h:
- rendering/RenderObject.cpp: (WebCore::addLayers): (WebCore::RenderObject::removeLayers): (WebCore::RenderObject::moveLayers): (WebCore::RenderObject::findNextLayer): (WebCore::RenderObject::enclosingLayer): (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setNeedsPositionedMovementLayout): (WebCore::RenderObject::computeAbsoluteRepaintRect): (WebCore::RenderObject::styleWillChange): (WebCore::RenderObject::localToAbsolute): (WebCore::RenderObject::absoluteToLocal): (WebCore::RenderObject::localToAbsoluteQuad): (WebCore::RenderObject::offsetFromContainer): (WebCore::RenderObject::destroy):
- rendering/RenderObject.h:
- rendering/RenderPath.cpp:
- rendering/RenderPath.h: (WebCore::RenderPath::requiresLayer):
- rendering/RenderReplica.h: (WebCore::RenderReplica::requiresLayer):
- rendering/RenderSVGContainer.cpp:
- rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::requiresLayer):
- rendering/RenderSVGHiddenContainer.cpp:
- rendering/RenderSVGHiddenContainer.h: (WebCore::RenderSVGHiddenContainer::requiresLayer):
- rendering/RenderSVGImage.cpp:
- rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::requiresLayer):
- rendering/RenderSVGInline.h: (WebCore::RenderSVGInline::requiresLayer):
- rendering/RenderSVGInlineText.h: (WebCore::RenderSVGInlineText::requiresLayer):
- rendering/RenderSVGText.cpp:
- rendering/RenderSVGText.h: (WebCore::RenderSVGText::requiresLayer):
- rendering/RenderScrollbarPart.h: (WebCore::RenderScrollbarPart::requiresLayer):
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::setCurrentPosition):
- rendering/RenderTableCell.cpp:
- rendering/RenderTableCell.h: (WebCore::RenderTableCell::requiresLayer):
- rendering/RenderTableCol.h: (WebCore::RenderTableCol::requiresLayer):
- rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows):
- rendering/RenderText.h: (WebCore::RenderText::styleWillChange):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::autoscroll): (WebCore::RenderTextControl::scroll):
- rendering/RenderTextControl.h:
- rendering/RenderTreeAsText.cpp: (WebCore::write): (WebCore::externalRepresentation):
- 1:18 PM Changeset in webkit [40179] by
-
- 2 edits in trunk/WebKit/mac
2009-01-23 Anders Carlsson <andersca@apple.com>
Fix 64-bit build.
- Plugins/Hosted/ProxyInstance.mm: (WebKit::proxyClass):
- 12:56 PM Changeset in webkit [40178] by
-
- 2 edits in trunk/WebKit/mac
2009-01-23 Anders Carlsson <andersca@apple.com>
Fix GCC 4.0 build.
- Configurations/Base.xcconfig:
- 12:53 PM Changeset in webkit [40177] by
-
- 2 edits in trunk/WebCore
2009-01-23 Anders Carlsson <andersca@apple.com>
Fix tyop.
- editing/markup.cpp: (WebCore::joinMarkups):
- 12:51 PM Changeset in webkit [40176] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-23 Darin Adler <Darin Adler>
Try to fix WX build.
- runtime/JSGlobalObjectFunctions.h: Include <wtf/unicode/Unicode.h> for the definition of UChar.
- 12:50 PM Changeset in webkit [40175] by
-
- 5 edits in trunk/WebCore
2009-01-23 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
- Configurations/Base.xcconfig: Fix GCC 4.0 build.
- editing/markup.cpp: (WebCore::joinMarkups): Pass a const reference to the vector.
- html/HTMLElement.cpp:
- platform/text/String.cpp: Add comments indicating that these functions are for use in the debugger.
- 12:37 PM Changeset in webkit [40174] by
-
- 3 edits in trunk/JavaScriptCore
2009-01-23 Anders Carlsson <andersca@apple.com>
- Configurations/Base.xcconfig: GCC 4.0 build fix.
- runtime/JSNumberCell.h: 64-bit build fix.
- 12:35 PM Changeset in webkit [40173] by
-
- 10 edits8 adds in trunk/WebCore
2009-01-23 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23506
Upstream Chromium's image decoders for use with PLATFORM(SKIA)
- platform/image-decoders/skia/BMPImageDecoder.cpp: Added.
- platform/image-decoders/skia/BMPImageDecoder.h: Added.
- platform/image-decoders/skia/BMPImageReader.cpp: Added.
- platform/image-decoders/skia/BMPImageReader.h: Added.
- platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate): (WebCore::GIFImageDecoderPrivate::decode): (WebCore::GIFImageDecoderPrivate::getColorMap): (WebCore::GIFImageDecoder::GIFImageDecoder): (WebCore::GIFImageDecoder::isSizeAvailable): (WebCore::GIFImageDecoder::frameCount): (WebCore::GIFImageDecoder::frameBufferAtIndex): (WebCore::GIFImageDecoder::clearFrameBufferCache): (WebCore::GIFImageDecoder::decode): (WebCore::GIFImageDecoder::sizeNowAvailable): (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow): (WebCore::GIFImageDecoder::frameComplete):
- platform/image-decoders/skia/GIFImageDecoder.h: (WebCore::GIFImageDecoder::filenameExtension): (WebCore::GIFImageDecoder::frameDurationAtIndex): (WebCore::GIFImageDecoder::):
- platform/image-decoders/skia/GIFImageReader.cpp: (GIFImageReader::do_lzw): (GIFImageReader::read):
- platform/image-decoders/skia/GIFImageReader.h:
- platform/image-decoders/skia/ICOImageDecoder.cpp: Added.
- platform/image-decoders/skia/ICOImageDecoder.h: Added.
- platform/image-decoders/skia/ImageDecoder.h: (WebCore::RefCountedNativeImageSkia::create): (WebCore::RefCountedNativeImageSkia::bitmap): (WebCore::RefCountedNativeImageSkia::RefCountedNativeImageSkia): (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::~RGBA32Buffer): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::bitmap): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::rect): (WebCore::RGBA32Buffer::status): (WebCore::RGBA32Buffer::duration): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setRect): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::setDuration): (WebCore::RGBA32Buffer::setDisposalMethod): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setRGBA): (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::~ImageDecoder): (WebCore::ImageDecoder::setData): (WebCore::ImageDecoder::isSizeAvailable): (WebCore::ImageDecoder::size): (WebCore::ImageDecoder::frameCount): (WebCore::ImageDecoder::repetitionCount): (WebCore::ImageDecoder::supportsAlpha): (WebCore::ImageDecoder::failed): (WebCore::ImageDecoder::setFailed): (WebCore::ImageDecoder::clearFrameBufferCache): (WebCore::ImageDecoder::setSize): (WebCore::ImageDecoder::isOverSize):
- platform/image-decoders/skia/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::JPEGImageReader): (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::isSizeAvailable): (WebCore::JPEGImageDecoder::outputScanlines):
- platform/image-decoders/skia/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::filenameExtension): (WebCore::JPEGImageDecoder::supportsAlpha): (WebCore::JPEGImageDecoder::reader):
- platform/image-decoders/skia/PNGImageDecoder.cpp: (WebCore::PNGImageReader::close): (WebCore::PNGImageDecoder::PNGImageDecoder): (WebCore::PNGImageDecoder::isSizeAvailable): (WebCore::PNGImageDecoder::frameBufferAtIndex): (WebCore::PNGImageDecoder::decode): (WebCore::PNGImageDecoder::decodingFailed): (WebCore::PNGImageDecoder::headerAvailable): (WebCore::rowAvailable): (WebCore::PNGImageDecoder::rowAvailable): (WebCore::PNGImageDecoder::pngComplete):
- platform/image-decoders/skia/PNGImageDecoder.h: (WebCore::PNGImageDecoder::filenameExtension): (WebCore::PNGImageDecoder::reader):
- platform/image-decoders/skia/XBMImageDecoder.cpp: Added.
- platform/image-decoders/skia/XBMImageDecoder.h: Added.
- 11:58 AM Changeset in webkit [40172] by
-
- 7 edits in trunk/WebKit/mac
2009-01-23 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Turn on -Wmissing-prototypes and fix the resulting warnings.
- Configurations/Base.xcconfig:
- History/WebHistory.mm: (timeIntervalForBeginningOfDay):
- History/WebHistoryItem.mm: (historyItemWrappers):
- Misc/WebNSPasteboardExtras.mm: (imageFromElement):
- WebView/WebFrame.mm:
- WebView/WebScriptDebugger.mm: (toNSString):
- 11:52 AM Changeset in webkit [40171] by
-
- 37 edits in trunk/WebCore
2009-01-23 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Turn on -Wmissing-prototypes and fix the resulting warnings.
- Configurations/Base.xcconfig:
- bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter):
- bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter): (WebCore::JSLocation::customGetOwnPropertySlot):
- bindings/objc/DOMRGBColor.mm: (WebCore::getWrapperForRGB): (WebCore::setWrapperForRGB): (WebCore::removeWrapperForRGB):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/c/c_instance.cpp: (JSC::Bindings::globalExceptionString):
- bridge/runtime_object.cpp: (JSC::callRuntimeConstructor):
- css/CSSParser.cpp: (WebCore::parseGradientColorStop):
- css/CSSPrimitiveValue.cpp: (WebCore::scaleFactorForConversion):
- css/CSSStyleSelector.cpp: (WebCore::operator >): (WebCore::operator <=): (WebCore::getTransformOperationType):
- dom/make_names.pl:
- editing/DeleteSelectionCommand.cpp: (WebCore::updatePositionForTextRemoval):
- editing/EditorCommand.cpp: (WebCore::valueBackColor): (WebCore::valueFontName): (WebCore::valueFontSize): (WebCore::valueFontSizeDelta): (WebCore::valueForeColor):
- editing/VisiblePosition.cpp: (WebCore::canonicalizeCandidate):
- editing/htmlediting.cpp:
- editing/markup.cpp: (WebCore::joinMarkups):
- html/HTMLElement.cpp: (WebCore::inlineTagList): (WebCore::blockTagList):
- html/HTMLMediaElement.cpp: (WebCore::serializeTimeOffset): (WebCore::parseTimeOffset):
- page/mac/FrameMac.mm: (WebCore::regExpForLabels):
- platform/Arena.cpp:
- platform/graphics/Color.cpp: (WebCore::colorFloatToRGBAByte):
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::imageSourceOptions):
- platform/graphics/cg/PathCG.cpp: (WebCore::CGPathApplierToPathApplier):
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::initFontData):
- platform/mac/PlatformMouseEventMac.mm:
- platform/text/String.cpp:
- rendering/RenderBlock.cpp: (WebCore::continuationOutlineTable): (WebCore::getHeightForLineCount):
- rendering/RenderView.cpp: (WebCore::rendererAfterPosition):
- rendering/RootInlineBox.cpp: (WebCore::isEditableLeaf):
- rendering/SVGRenderTreeAsText.cpp: (WebCore::hasFractions):
- rendering/style/RenderStyle.cpp: (WebCore::positionedObjectMoved):
- svg/SVGFont.cpp: (WebCore::floatWidthUsingSVGFontCallback): (WebCore::floatWidthMissingGlyphCallback): (WebCore::drawTextUsingSVGFontCallback): (WebCore::drawTextMissingGlyphCallback):
- svg/SVGTransformable.cpp: (WebCore::parseTransformParamList):
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::operator<<):
- xml/XPathGrammar.y:
- xml/XSLTExtensions.cpp:
- 11:42 AM Changeset in webkit [40170] by
-
- 5 edits2 deletes in trunk/WebCore
No review, removing an empty file.
Remove RemoveNodeAttributeCommand since it was empty.
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- editing/RemoveNodeAttributeCommand.cpp: Removed.
- editing/RemoveNodeAttributeCommand.h: Removed.
- 11:40 AM Changeset in webkit [40169] by
-
- 10 edits in trunk/JavaScriptCore
2009-01-23 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Turn on -Wmissing-prototypes and fix the warnings.
- API/JSClassRef.cpp: (clearReferenceToPrototype):
- Configurations/Base.xcconfig:
- runtime/Collector.cpp: (JSC::getPlatformThreadRegisters):
- runtime/ExceptionHelpers.cpp: (JSC::createError):
- runtime/JSGlobalObjectFunctions.h:
- runtime/JSNumberCell.h:
- runtime/UString.cpp: (JSC::initializeStaticBaseString): (JSC::createRep):
- wtf/FastMalloc.cpp:
- wtf/Threading.cpp:
- 11:16 AM Changeset in webkit [40168] by
-
- 7 edits2 moves in trunk/WebCore
2009-01-23 Brady Eidson <beidson@apple.com>
Rubberstamped by Sam Weinig
Rework ScriptCachedPageData to ScriptCachedFrameData to more accurately reflect its true purpose
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/ScriptCachedFrameData.cpp: Copied from bindings/js/ScriptCachedPageData.cpp. (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::domWindow): (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::restore): (WebCore::ScriptCachedFrameData::clear):
- bindings/js/ScriptCachedFrameData.h: Copied from bindings/js/ScriptCachedPageData.h.
- bindings/js/ScriptCachedPageData.cpp: Removed.
- bindings/js/ScriptCachedPageData.h: Removed.
- history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore):
- history/CachedPage.h:
- 11:03 AM Changeset in webkit [40167] by
-
- 2 edits in trunk/WebCore
Fix build.
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::baselinePosition):
- 10:56 AM Changeset in webkit [40166] by
-
- 1 edit1 copy in trunk/WebCore
2009-01-23 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23506
Copy existing ImageDecoder.h in preparation for landing Skia changes on top.
- platform/image-decoders/skia/ImageDecoder.h: Copied from platform/image-decoders/ImageDecoder.h.
- 10:53 AM Changeset in webkit [40165] by
-
- 1 edit8 copies1 add in trunk/WebCore
2009-01-23 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23506
Copy existing image-decoders in preparation for landing Skia changes on top.
- platform/image-decoders/skia: Added.
- platform/image-decoders/skia/GIFImageDecoder.cpp: Copied from platform/image-decoders/gif/GIFImageDecoder.cpp.
- platform/image-decoders/skia/GIFImageDecoder.h: Copied from platform/image-decoders/gif/GIFImageDecoder.h.
- platform/image-decoders/skia/GIFImageReader.cpp: Copied from platform/image-decoders/gif/GIFImageReader.cpp.
- platform/image-decoders/skia/GIFImageReader.h: Copied from platform/image-decoders/gif/GIFImageReader.h.
- platform/image-decoders/skia/JPEGImageDecoder.cpp: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.cpp.
- platform/image-decoders/skia/JPEGImageDecoder.h: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.h.
- platform/image-decoders/skia/PNGImageDecoder.cpp: Copied from platform/image-decoders/png/PNGImageDecoder.cpp.
- platform/image-decoders/skia/PNGImageDecoder.h: Copied from platform/image-decoders/png/PNGImageDecoder.h.
- 9:19 AM BuildingQtOnLinux edited by
- "Installing dependencies on OpenSUSE Linux" (diff)
- 8:57 AM Changeset in webkit [40164] by
-
- 1 edit3 adds in trunk/LayoutTests
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=23478
Add a test for application test resource loading failure
- http/tests/appcache/404-resource-expected.txt: Added.
- http/tests/appcache/404-resource.html: Added.
- http/tests/appcache/resources/404-resource.manifest: Added.
- 8:18 AM Changeset in webkit [40163] by
-
- 2 edits in trunk/WebCore
Build fix in RenderThemeGtk for RenderBox usage.
- 8:07 AM Changeset in webkit [40162] by
-
- 9 edits in trunk/WebCore
2009-01-23 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 22720: Make XMLHttpRequest work in Workers
<https://bugs.webkit.org/show_bug.cgi?id=22720>
Add copy/adopt for ResourceResponse(Base)/ResourceRequest(Base) to allow the
data to be passed across threads.
No observable change in behavior, so no test.
- platform/network/FormData.cpp: (WebCore::FormData::deepCopy):
- platform/network/FormData.h:
- platform/network/HTTPHeaderMap.cpp: (WebCore::HTTPHeaderMap::copyData): (WebCore::HTTPHeaderMap::adopt):
- platform/network/HTTPHeaderMap.h:
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData):
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::copyData):
- platform/network/ResourceResponseBase.h:
- 7:53 AM Changeset in webkit [40161] by
-
- 9 edits2 adds in trunk/WebCore
2009-01-23 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=23374
Add WorkerRunLoop to encapsulate message queue and timer heap.
This is first half (timer heap is added as separate patch).
- GNUmakefile.am: Added WorkerRunLoop.cpp to the build.
- WebCore.vcproj/WebCore.vcproj: Same as above.
- WebCore.xcodeproj/project.pbxproj: Same as above
- dom/WorkerContext.cpp: (WebCore::WorkerContext::postTask):
- dom/WorkerContext.h:
- dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): (WebCore::WorkerMessagingProxy::workerThreadCreated):
- dom/WorkerRunLoop.cpp: Added. (WebCore::WorkerRunLoop::run): Runs the loop until terminate() is called. (WebCore::WorkerRunLoop::terminate): Causes the loop to exit. (WebCore::WorkerRunLoop::postTask): Adds a task to the internal queue.
- dom/WorkerRunLoop.h: Added. (WebCore::WorkerRunLoop::WorkerRunLoop):
- dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): (WebCore::WorkerThread::stop):
- dom/WorkerThread.h: (WebCore::WorkerThread::runLoop):
- 7:02 AM Changeset in webkit [40160] by
-
- 2 edits in trunk/WebCore
Redo previous patch http://trac.webkit.org/changeset/34260 which fixes a
huge memory leak by ensuring that the timer is fired one last time on
application tear down thus triggering the GCController thereby freeing
JavaScript objects as well as triggering other timer based tear down methods.
- 6:50 AM Changeset in webkit [40159] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=23459
Workers are not properly terminated if execution hasn't begun yet
Doesn't affect observable behavior, so test case is not possible.
- dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Call forbidExecution() if it couldn't be called earlier.
- 5:29 AM Changeset in webkit [40158] by
-
- 2 edits in trunk/WebKit/qt
2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon Hausmann.
Make the test more robust by taking into account the platform-specific
cursor flashing time.
- tests/qwebframe/tst_qwebframe.cpp:
- 4:39 AM Changeset in webkit [40157] by
-
- 2 edits in trunk/WebCore
2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
[Qt] Fix the build after RenderBox refactoring in r40153.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::baselinePosition):
- 4:39 AM Changeset in webkit [40156] by
-
- 2 edits in trunk/WebCore
2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Alexey Proskuryakov.
Fix the build after RenderBox refactoring in r40153.
- plugins/PluginView.cpp: (WebCore::PluginView::invalidateWindowlessPluginRect):
- 4:38 AM Changeset in webkit [40155] by
-
- 2 edits in trunk/WebCore
2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon Hausmann.
[Qt] Simplify the assertion.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContext::releaseWindowsContext):
Jan 22, 2009:
- 11:19 PM Changeset in webkit [40154] by
-
- 3 edits in trunk/LayoutTests/platform/mac/fast/forms
Land updated layout tests (progressions) after border/padding move.
- 11:14 PM Changeset in webkit [40153] by
-
- 15 edits in trunk/WebCore
2009-01-22 David Hyatt <hyatt@apple.com>
Move the border and padding methods from RenderObject to RenderBox.
Reviewed by Oliver Hunt
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
- page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesVertically):
- rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::borderLeft): (WebCore::InlineFlowBox::borderRight): (WebCore::InlineFlowBox::paddingLeft): (WebCore::InlineFlowBox::paddingRight):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloats):
- rendering/RenderBox.cpp: (WebCore::RenderBox::paddingTop): (WebCore::RenderBox::paddingBottom): (WebCore::RenderBox::paddingLeft): (WebCore::RenderBox::paddingRight): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
- rendering/RenderBox.h: (WebCore::RenderBox::borderTop): (WebCore::RenderBox::borderBottom): (WebCore::RenderBox::borderLeft): (WebCore::RenderBox::borderRight):
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- rendering/RenderObject.h:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::textBlockWidth): (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::calcPrefWidths):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth):
- rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
- rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle):
- 9:13 PM Changeset in webkit [40152] by
-
- 16 edits in trunk/WebCore
2009-01-22 David Hyatt <hyatt@apple.com>
Devirtualize the marginTop/Right/Left/Bottom functions and move them to RenderBox (along with some of the
other margin functions that have to come along for the ride).
Reviewed by Oliver Hunt
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- editing/TextIterator.cpp: (WebCore::shouldEmitExtraNewlineForNode):
- rendering/InlineBox.cpp:
- rendering/InlineBox.h: (WebCore::InlineBox::renderBox):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::marginLeft): (WebCore::InlineFlowBox::marginRight): (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelfCollapsingBlock): (WebCore::RenderBlock::adjustPositionedBlock): (WebCore::RenderBlock::handleCompactChild): (WebCore::RenderBlock::estimateVerticalPosition): (WebCore::getBorderPaddingMargin): (WebCore::RenderBlock::calcInlinePrefWidths):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight):
- rendering/RenderBox.h: (WebCore::RenderBox::hasHorizontalBordersPaddingOrMargin): (WebCore::RenderBox::hasHorizontalBordersOrPadding): (WebCore::RenderBox::marginTop): (WebCore::RenderBox::marginBottom): (WebCore::RenderBox::marginLeft): (WebCore::RenderBox::marginRight): (WebCore::RenderBox::isSelfCollapsingBlock): (WebCore::RenderBox::collapsedMarginTop): (WebCore::RenderBox::collapsedMarginBottom): (WebCore::RenderBox::isTopMarginQuirk): (WebCore::RenderBox::isBottomMarginQuirk): (WebCore::RenderBox::maxTopMargin): (WebCore::RenderBox::maxBottomMargin):
- rendering/RenderObject.cpp: (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
- rendering/RenderObject.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::lineHeight): (WebCore::RenderSVGContainer::baselinePosition):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcHeight):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::baselinePosition):
- rendering/bidi.cpp: (WebCore::getBorderPaddingMargin): (WebCore::inlineWidth): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::inlineFlowRequiresLineBox): (WebCore::requiresLineBox): (WebCore::RenderBlock::findNextLineBreak):
- 8:57 PM Changeset in webkit [40151] by
-
- 8 edits in trunk
Disable GCC_WARN_ABOUT_MISSING_PROTOTYPES temporarily.
Rubber-stamped by Anders Carlsson.
Current versions of Xcode only respect it for C and Objective-C files,
and our code doesn't currently compile if it is applied to C++ and
Objective-C++ files.
- 8:30 PM Changeset in webkit [40150] by
-
- 1 edit in trunk/WebCore/rendering/RenderTableSection.cpp
Fix build bustage on Gtk.
- 8:07 PM Changeset in webkit [40149] by
-
- 4 edits in trunk/WebCore
2009-01-22 David Hyatt <hyatt@apple.com>
Move the m_widthChanged bit on RenderTableCell into RenderFlow's set of bits. Let intrinsicPaddingTop and
intrinsicPaddingBottom just be normal non-bitfield values.
Reviewed by Oliver Hunt
- rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): (WebCore::RenderTableCell::updateWidth): (WebCore::RenderTableCell::layout):
- rendering/RenderTableCell.h:
- 8:06 PM Changeset in webkit [40148] by
-
- 2 edits in trunk/LayoutTests/platform/mac/tables/mozilla/bugs
Update layout tests for table cell changes.
- 8:05 PM Changeset in webkit [40147] by
-
- 2 edits in trunk/LayoutTests/platform/mac/http/tests/misc
Update layout tests for table cell changes.
- 8:04 PM Changeset in webkit [40146] by
-
- 2 edits in trunk/LayoutTests/platform/mac/fast/table
Update layout tests for table cell changes.
- 8:03 PM Changeset in webkit [40145] by
-
- 1 edit in trunk/LayoutTests/platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt
Update layout tests for table cell changes.
- 8:03 PM Changeset in webkit [40144] by
-
- 2 edits in trunk/LayoutTests/platform/mac/fast/css
Update layout tests for table cell changes.
- 7:55 PM Changeset in webkit [40143] by
-
- 16 edits in trunk/WebCore
2009-01-22 David Hyatt <hyatt@apple.com>
Properly encapsulate m_frameRect.y() behind the RenderBox::y() method now that they are the same thing.
Make m_frameRect private.
Reviewed by Oliver Hunt
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::clearFloats):
- rendering/RenderBox.cpp: (WebCore::RenderBox::offsetTop): (WebCore::RenderBox::nodeAtPoint): (WebCore::RenderBox::paint): (WebCore::RenderBox::paintCustomHighlight): (WebCore::RenderBox::containingBlockWidth): (WebCore::RenderBox::localToAbsolute): (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeAbsoluteRepaintRect): (WebCore::RenderBox::repaintDuringLayoutIfMoved):
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint):
- rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::nodeAtPoint):
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::getRelativeMarkerRect):
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint): (WebCore::RenderReplaced::shouldPaint):
- rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::applyContentTransforms): (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::absoluteTransform): (WebCore::RenderSVGRoot::nodeAtPoint):
- rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint): (WebCore::RenderTableCell::paintBackgroundsBehindCell):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::nodeAtPoint):
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
- 7:42 PM Changeset in webkit [40142] by
-
- 23 edits in trunk/WebCore
2009-01-22 David Hyatt <hyatt@apple.com>
This patch completely reworks vertical alignment of table cells. The current system uses methods called borderTopExtra() and borderBottomExtra() to
add extra space above and below the content of a cell. This system was not confined to the table code and spilled out into all the other RenderObjects.
The y-position of the table cell box was set to the outer edge of the cell, but the y() method of RenderBox lied and added in borderTopExtra(). height()
also excluded the extra space, so did not accurately reflect the true size of the cell.
With the new system, the table cell box is completely accurate. The extra space becomes part of the padding of the cell. Padding has been reworked so that
additional intrinsic padding can be added on to the specified padding from style. Only the table code has to deal with the extra cell padding.
localToAbsoluteForContent has now been removed, since there no longer has to be a special hacked content box.
A number of table layout tests progress with this change, since the new layout system actually fixes existing bugs in baseline alignment of cells.
Reviewed by Oliver Hunt
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Make CSSComputedStyleDeclaration ask for padding values that exclude the built-in intrinsic padding. This ensures that getComputedStyle continues to give the right answer.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::getLowerRightCorner):
- editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition):
- rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowRect): Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
The expandsToEncloseOverhangingFloats logic has been reworked. Table cells and fieldsets did not properly handle floats that spilled into the bottom padding. The
resulting box needed to not only expand to encompass the float, but also needed to place the full bottom padding after the float. The switch to make the extra table cell
space into padding exposed this issue. No extra layout test is required, since an existing table layout test exposes this issue and progresses to match Firefox with
this change.
(WebCore::RenderBlock::selectionGapRects):
(WebCore::RenderBlock::paintSelection):
(WebCore::RenderBlock::fillSelectionGaps):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::positionForCoordinates):
(WebCore::RenderBlock::offsetForContents):
Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
- rendering/RenderBlock.h: Add the new simplified method for expanding to encompass overhanging floats. The method has been devirtualized and made to include all of the cases (and not just a subset).
- rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects): (WebCore::RenderBox::absoluteQuads): (WebCore::RenderBox::absoluteContentBox): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::paintMask): (WebCore::RenderBox::getOverflowClipRect): (WebCore::RenderBox::localToAbsolute): (WebCore::RenderBox::absoluteToLocal): (WebCore::RenderBox::localToAbsoluteQuad): Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
- rendering/RenderBox.h: (WebCore::RenderBox::y): (WebCore::RenderBox::location): (WebCore::RenderBox::borderBoxRect): (WebCore::RenderBox::offsetHeight): Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::addLineBoxRects):
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintMask):
- rendering/RenderFieldset.h: (WebCore::RenderFieldset::avoidsFloats):
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::localCaretRect):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::boundingBox):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInOverflowControl):
- rendering/RenderObject.cpp: (WebCore::RenderObject::localToAbsolute): (WebCore::RenderObject::absoluteToLocal): (WebCore::RenderObject::localToAbsoluteQuad): (WebCore::RenderObject::offsetFromContainer): (WebCore::RenderObject::paddingTop): (WebCore::RenderObject::paddingBottom): (WebCore::RenderObject::paddingLeft): (WebCore::RenderObject::paddingRight):
- rendering/RenderObject.h: (WebCore::RenderObject::hasOverhangingFloats):
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect): (WebCore::RenderReplaced::localSelectionRect): Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls. Also modifed paddingLeft/Top/Right/Bottom to take an argument indicating whether or not the intrinsic padding of an object should be included (by default it is). getComputedStyle needs to exclude it, which is why this argument is necessary.
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): (WebCore::RenderTableCell::paddingTop): (WebCore::RenderTableCell::paddingBottom): The new paddingTop() and paddingBottom() methods on table cells include the extra intrinsic padding.
(WebCore::RenderTableCell::setOverrideSize):
When a table's override size gets altered, the intrinsic padding needs to be cleared.
(WebCore::RenderTableCell::absoluteClippedOverflowRect):
(WebCore::RenderTableCell::computeAbsoluteRepaintRect):
(WebCore::RenderTableCell::baselinePosition):
(WebCore::RenderTableCell::paint):
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::paintMask):
Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
- rendering/RenderTableCell.h: (WebCore::RenderTableCell::setIntrinsicPaddingTop): (WebCore::RenderTableCell::setIntrinsicPaddingBottom): (WebCore::RenderTableCell::setIntrinsicPadding): (WebCore::RenderTableCell::clearIntrinsicPadding): (WebCore::RenderTableCell::intrinsicPaddingTop): (WebCore::RenderTableCell::intrinsicPaddingBottom): Add new helper methods for getting/setting a cell's intrinsic padding.
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcRowHeight): calcRowHeight has been modified to exclude the intrinsic padding when calculating the base height of rows prior to flexing. Because a cell now includes that extra space, it has to be subtracted out in this method.
(WebCore::RenderTableSection::layoutRows):
Modify the code that sets up the intrinsic padding so that it does a relayout if the intrinsic padding changes. There was also an error where the baseline
position mismatched leading to negative intrinsic padding being added in (this error exists in ToT). The code now properly ignores cells that don't establish
a baseline. A number of tests progress with this change.
- rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects): Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
- rendering/RenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeTextRun): Modify the render tree dumping code to continue to produce the same results as before. This is really a hack, since we're now capable of indicating the correct position for the descendants of cells with intrinsic padding (and also indicating what the correct cell box is). A future patch can remove these hacks so that the layout test results can all be regenerated.
- 6:30 PM Changeset in webkit [40141] by
-
- 2 edits in trunk/JavaScriptCore
Return currentTime() in correct units for the two early return cases.
Reviewed by Mark Rowe.
- wtf/CurrentTime.cpp: (WTF::currentTime):
- 5:01 PM Changeset in webkit [40140] by
-
- 9 edits in trunk/WebKit/mac
2009-01-22 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add support for Invoke and InvokeDefault. Clean up code.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCBooleanReply):
- Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::Reply::): (WebKit::NetscapePluginInstanceProxy::BooleanReply::BooleanReply):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
- Plugins/Hosted/ProxyInstance.h:
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): (WebKit::ProxyInstance::invokeMethod): (WebKit::ProxyInstance::supportsInvokeDefaultMethod): (WebKit::ProxyInstance::invokeDefaultMethod): (WebKit::ProxyInstance::methodsNamed): (WebKit::ProxyInstance::fieldNamed):
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs:
- Plugins/Hosted/WebKitPluginHostTypes.h:
- 4:46 PM Changeset in webkit [40139] by
-
- 4 edits3 adds in trunk
Reviewed by Justin Garcia.
Remove <span> turds left by editing commands
https://bugs.webkit.org/show_bug.cgi?id=23466
Tests:
- editing/execCommand/empty-span-removal.html
- editing/execCommand/toggle-styles.html
- editing/ApplyStyleCommand.cpp: (WebCore::styleSpanClassString): (WebCore::isStyleSpan): (WebCore::isUnstyledStyleSpan): (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan): (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): (WebCore::ApplyStyleCommand::removeHTMLBidiEmbeddingStyle): (WebCore::ApplyStyleCommand::removeCSSStyle):
- 3:24 PM Changeset in webkit [40138] by
-
- 2 edits in trunk/WebKitTools
2009-01-22 Anders Carlsson <andersca@apple.com>
Fix Windows build.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
- 2:53 PM Changeset in webkit [40137] by
-
- 13 edits in trunk/WebCore
Reviewed by Eric Seidel.
Rename some of the casting functions in dom/*Element.cpp:
formControlElementForElement -> toFormControlElement
inputElementForElement -> toInputElement
optionElementForElement -> toOptionElement
optionGroupElementForElement -> toOptionGroupElement
Suggested by Alexey, while refactoring the Element*->ScriptElement* code.
The Element*->ScriptElement* helper function is already named 'toScriptElement'.
- 2:48 PM Changeset in webkit [40136] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix for <rdar://problem/6439247>
FastMalloc allocating an extra 4MB of meta-data on 64-bit
Rely on the fact that on all known x86-64 platforms only use 48 bits of
address space to shrink the initial size of the PageMap from ~4MB to 120K.
For 64-bit we still use a 3-level radix tree, but now each level is only 12
bits wide.
No performance change.
- wtf/FastMalloc.cpp: (WTF::MapSelector): Add specialization for 64 bit that takes into account the 16 bits of unused address space on x86-64.
- 2:24 PM Changeset in webkit [40135] by
-
- 3 edits in trunk/WebCore
Rubber-stamped by George Staikos.
Forgot to include in my last commit: Activate code depending on WMLOptionElement/WMLOptGroupElement.
- 2:04 PM Changeset in webkit [40134] by
-
- 6 edits4 adds in trunk/WebCore
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=23454
Add WML <option>/<optgroup> element support.
Currently the implementation is stubbed, all relevant parts can be enabled
once WMLSelectElement/SelectElement has been created.
- 1:51 PM Changeset in webkit [40133] by
-
- 5 edits in trunk
2009-01-22 Beth Dakin <Beth Dakin>
Reviewed by Sam Weinig.
Fix for https://bugs.webkit.org/show_bug.cgi?id=23461 LayoutTests/
fast/js/numeric-conversion.html is broken, and corresponding
<rdar://problem/6514842>
The basic problem here is that parseInt(Infinity) should be NaN,
but we were returning 0. NaN matches Safari 3.2.1 and Firefox.
- runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt):
LayoutTests:
2009-01-22 Beth Dakin <Beth Dakin>
Reviewed by Sam Weinig.
Fix for https://bugs.webkit.org/show_bug.cgi?id=23461 LayoutTests/
fast/js/numeric-conversion.html is broken, and corresponding
<rdar://problem/6514842>
The basic problem here is that parseInt(Infinity) should be NaN,
but we were returning 0. NaN matches Safari 3.2.1 and Firefox.
- fast/js/numeric-conversion-expected.txt:
- fast/js/resources/numeric-conversion.js:
- 1:16 PM Changeset in webkit [40132] by
-
- 11 edits3 adds in trunk
WebCore:
2009-01-22 Eric Roman <eroman@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=20806
Send referrer for history navigations.
Test: http/tests/navigation/back-send-referrer.html
Consolidates HistoryItem::rssFeedReferrer and HistoryItem::formReferrer into a single HistoryItem::referrer property.
- history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::referrer): (WebCore::HistoryItem::setReferrer): (WebCore::HistoryItem::formReferrer): (WebCore::HistoryItem::rssFeedReferrer): (WebCore::HistoryItem::setRSSFeedReferrer): (WebCore::HistoryItem::setFormInfoFromRequest):
- history/HistoryItem.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
WebKit/win:
2009-01-22 Eric Roman <eroman@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=20806
Deprecate RSSFeedReferrer() and setRSSFeedReferrer().
- WebHistoryItem.cpp: (WebHistoryItem::RSSFeedReferrer): (WebHistoryItem::setRSSFeedReferrer):
WebKit/mac:
2009-01-22 Eric Roman <eroman@chromium.og>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=20806
Deprecate RSSFeedReferrer() and setRSSFeedReferrer().
- History/WebHistoryItem.mm: (-[WebHistoryItem RSSFeedReferrer]): (-[WebHistoryItem setRSSFeedReferrer:]):
LayoutTests:
2009-01-22 Eric Roman <eroman@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=20806
"Referer" header not sent for history navigation.
- http/tests/navigation/back-send-referrer-expected.txt: Added.
- http/tests/navigation/back-send-referrer.html: Added.
- http/tests/navigation/resources/back-send-referrer-helper.php: Added.
- 1:07 PM Changeset in webkit [40131] by
-
- 7 edits in trunk
<rdar://problem/6516853> (r39682-r39736) JSFunFuzz: crash on "(function(){({ x2: x }), })()"
<https://bugs.webkit.org/show_bug.cgi?id=23479>
Reviewed by Geoff Garen.
Automatic semicolon insertion was resulting in this being accepted in the initial
nodeless parsing, but subsequent reparsing for code generation would fail, leading
to a crash. The solution is to ensure that reparsing a function performs parsing
in the same state as the initial parse. We do this by modifying the saved source
ranges to include rather than exclude the opening and closing braces.
- 12:40 PM Changeset in webkit [40130] by
-
- 8 edits in trunk/WebCore
Reviewed by Eric Seidel.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=23465
Further enhancments to share code between HTMLOptionElement and the upcoming WMLOptionElement.
Rename optionText() to textIndentedToRespectGroupLabel() in (HTML)OptionElement, as it fits better.
optionText() returns the options text prefixed with some spaces, in case it got an optgroup parent.
Add two more pure-virtual functions to OptionElement: setSelectedState(bool) & value().
These aren't used outside of html/ at the moment (unlike the other pure-virtual functions
used by RenderMenuList/RenderListBox) - but they will be used by SelectElement, once it exists.
- 12:30 PM Changeset in webkit [40129] by
-
- 2 edits in trunk/WebCore
2009-01-22 Chris Fleizach <Chris Fleizach>
Reviewed by Justin Garcia.
Bug 23464: Infinite recursion at SelectionController::setSelection
https://bugs.webkit.org/show_bug.cgi?id=23464
Check for conditions leading to infinite recursion.
- editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
- 12:12 PM Changeset in webkit [40128] by
-
- 3 edits in trunk/WebKitTools
2009-01-22 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Clean up the test plug-in code. We now always use the CG drawing model and the
Cocoa event model. It is however possible to revert to the old Carbon event model by
specifying forcecarbon=true in the embed/object tag.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (handleEventCarbon): (handleEventCocoa): (NPP_HandleEvent):
- 11:06 AM Changeset in webkit [40127] by
-
- 3 edits in trunk/WebKit/mac
2009-01-22 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Don't crash or hang when we fail to instantiate a plug-in.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): Return 0 on failure.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView JSC::Bindings::createPluginBindingsInstance:JSC::Bindings::]): Null check for the proxy member.
- 10:55 AM Changeset in webkit [40126] by
-
- 2 edits in trunk/WebCore
Not reviewed. Fix WML build problem in RenderBox.cpp, WMLNames is undefined.
- 7:29 AM Changeset in webkit [40125] by
-
- 2 edits in trunk/WebCore
Fix the Qt build after RenderBox changes.
- 1:41 AM Changeset in webkit [40124] by
-
- 3 edits in trunk/WebCore
2009-01-22 David Hyatt <hyatt@apple.com>
Fix regressions in list box selection on Mac. The wrong color was being used for the list box
background, and list box colors actually weren't even being properly fetched because of a bug in
the RenderTheme base class. Existing pixel tests cover the bug fix.
Reviewed by Jon Honeycutt
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderTheme::activeListBoxSelectionForegroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
- 12:58 AM Changeset in webkit [40123] by
-
- 8 edits1 add in trunk/WebCore
2009-01-22 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 22720: Make XMLHttpRequest work in Workers
<https://bugs.webkit.org/show_bug.cgi?id=22720>
Add copy/adopt for HTTPHeaderMap to allow the data to be passed across threads.
No observable change in behavior, so no test.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- platform/network/HTTPHeaderMap.cpp: Added. (WebCore::HTTPHeaderMap::copyData): (WebCore::HTTPHeaderMap::adopt):
- platform/network/HTTPHeaderMap.h:
- 12:32 AM Changeset in webkit [40122] by
-
- 3 edits1 add in trunk/JavaScriptCore
2009-01-22 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
Implement ThreadCondition::timedWait().
Since we borrow the code for condition variables from other sources,
I did the same for timedWait(). See comments in ThreadingWin.cpp for
rationale and more info.
- wtf/CONTRIBUTORS.pthreads-win32: Added. A list of Pthreads-win32 contributors mentioned in their license. The license itself is included into wtf/ThreadingWin32.cpp.
- wtf/Threading.h:
- wtf/ThreadingWin.cpp: Additional info and Pthreads-win32 license at the beginning. (WTF::PlatformCondition::timedWait): new method, derived from Pthreads-win32. (WTF::PlatformCondition::signal): same (WTF::ThreadCondition::ThreadCondition): (WTF::ThreadCondition::~ThreadCondition): (WTF::ThreadCondition::wait): this now calls PlatformCondition::timedWait. (WTF::ThreadCondition::timedWait): same (WTF::ThreadCondition::signal): this now calls PlatformCondition::signal. (WTF::ThreadCondition::broadcast): same
- 12:15 AM Changeset in webkit [40121] by
-
- 2 edits in trunk/WebCore/wml
Fix build bustage in WML from RenderBox changes.
- 12:12 AM Changeset in webkit [40120] by
-
- 1 edit in trunk/WebCore/platform/gtk/RenderThemeGtk.cpp
Fix Gtk build bustage.
- 12:11 AM Changeset in webkit [40119] by
-
- 1 edit in trunk/WebCore/platform/qt/RenderThemeQt.cpp
Fix Qt build bustage.
Jan 21, 2009:
- 11:54 PM Changeset in webkit [40118] by
-
- 5 edits in trunk/WebCore
2009-01-21 David Hyatt <hyatt@apple.com>
Back out a portion of my patch that I did not mean to land. Revert paintOutline back to the way it
was before my landing. Fixes failing SVG focus ring tests.
- rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):
- rendering/RenderObject.h:
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
- 11:19 PM Changeset in webkit [40117] by
-
- 2 edits in trunk/WebCore
2009-01-21 David Hyatt <hyatt@apple.com>
Fix Node's renderBox() method on Windows.
- dom/Node.cpp: (WebCore::Node::renderBox):
- 11:05 PM Changeset in webkit [40116] by
-
- 2 edits in trunk/WebCore
2009-01-21 David Hyatt <hyatt@apple.com>
Fix RenderThemeSafari bustage on Win32.
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::baselinePosition):
- 10:58 PM Changeset in webkit [40115] by
-
- 2 edits in trunk/WebCore
2009-01-21 David Hyatt <hyatt@apple.com>
Fix bustage in RenderThemeWin. It's actually terrible that RenderThemeWin is using absoluteContentBox,
but that's a problem for another day.
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintSearchFieldCancelButton): (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
- 9:59 PM Changeset in webkit [40114] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Because bdash hates freedom (tyop fix).
- 9:57 PM Changeset in webkit [40113] by
-
- 1 edit2 copies in trunk/LayoutTests
2009-01-21 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Geoff "Cameron Zwarich" Garen.
Add pre & post standalone driver stcripts to assist running the javascript layout tests
on jsc, rather than a full webkit build.
- fast/js/resources/standalone-post.js: Copied from fast/js/resources/js-test-post.js.
- fast/js/resources/standalone-pre.js: Copied from fast/js/resources/js-test-pre.js. (description): (debug): (escapeString): (testPassed): (testFailed):
- 9:48 PM Changeset in webkit [40112] by
-
- 2 edits in trunk/WebCore
Bug 23470: Crash when page load occurs while processing scroll event with MallocScribble enabled
<https://bugs.webkit.org/show_bug.cgi?id=23470>
Reviewed by Dave Hyatt
Add a RefPtr protector to handleWheelEvent to guard against destruction
while processing the scroll event. Alas the absurd set of circumstances
required to trigger this do not appear to be reproducible in DRT.
- 8:28 PM Changeset in webkit [40111] by
-
- 5 edits in trunk
2009-01-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
We need to check all numbers in integer switches, not just those
represented as integer JSImmediates.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::cti_op_switch_imm):
LayoutTests:
2009-01-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Add layout test for switch (-0).
- fast/js/resources/switch-behaviour.js:
- fast/js/switch-behaviour-expected.txt:
- 7:48 PM Changeset in webkit [40110] by
-
- 4 edits in branches/Safari-3-2-branch
Versioning.
- 7:44 PM Changeset in webkit [40109] by
-
- 4 edits in branches/Safari-3-2-branch
Versioning.
- 7:35 PM Changeset in webkit [40108] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- 6:31 PM Changeset in webkit [40107] by
-
- 101 edits in trunk
WebCore:
2009-01-21 David Hyatt <hyatt@apple.com>
Devirtualize the width/height/x/y methods of the render tree. The methods are now non-virtual on RenderBox.
Many functions that were previously in RenderObject.cpp are now in RenderBox.cpp.
Reviewed by Eric Seidel and Darin Adler
- WebCore.base.exp:
- css/CSSComputedStyleDeclaration.cpp: (WebCore::sizingBox):
- dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner):
- dom/Element.cpp: (WebCore::Element::offsetLeft): (WebCore::Element::offsetTop): (WebCore::Element::offsetWidth): (WebCore::Element::offsetHeight): (WebCore::Element::offsetParent): (WebCore::Element::clientLeft): (WebCore::Element::clientTop): (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): (WebCore::Element::scrollLeft): (WebCore::Element::scrollTop): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
- dom/Node.cpp: (WebCore::Node::renderBox): (WebCore::Node::getRect):
- dom/Node.h:
- dom/Position.cpp: (WebCore::endsOfNodeAreVisuallyDistinctPositions): (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): (WebCore::Position::isCandidate):
- dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode):
- editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
- editing/EditorCommand.cpp: (WebCore::verticalScrollDistance):
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::willDraw):
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isFocusable):
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::width): (WebCore::HTMLFrameElementBase::height):
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::width): (WebCore::HTMLImageElement::height):
- inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- page/FrameView.cpp: (WebCore::FrameView::createScrollbar): (WebCore::FrameView::updateDashboardRegions):
- page/animation/AnimationBase.cpp: (WebCore::blendFunc):
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::imageRect):
- rendering/InlineBox.cpp: (WebCore::InlineBox::renderBox): (WebCore::InlineBox::adjustPosition):
- rendering/InlineBox.h:
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::verticallyAlignBoxes): (WebCore::InlineFlowBox::placeBoxesVertically):
- rendering/InlineFlowBox.h:
- rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): (WebCore::RenderBlock::overflowWidth): (WebCore::RenderBlock::overflowRect): (WebCore::RenderBlock::isSelfCollapsingBlock): (WebCore::RenderBlock::layout): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::adjustPositionedBlock): (WebCore::RenderBlock::adjustFloatingBlock): (WebCore::RenderBlock::handleSpecialChild): (WebCore::RenderBlock::handlePositionedChild): (WebCore::RenderBlock::handleFloatingChild): (WebCore::RenderBlock::handleCompactChild): (WebCore::RenderBlock::insertCompactIfNeeded): (WebCore::RenderBlock::handleRunInChild): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::estimateVerticalPosition): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::handleBottomOfBlock): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::layoutOnlyPositionedObjects): (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::markPositionedObjectsForLayout): (WebCore::RenderBlock::repaintOverhangingFloats): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::paintContinuationOutlines): (WebCore::clipOutPositionedObjects): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::fillBlockSelectionGaps): (WebCore::RenderBlock::leftSelectionOffset): (WebCore::RenderBlock::rightSelectionOffset): (WebCore::RenderBlock::insertPositionedObject): (WebCore::RenderBlock::removePositionedObject): (WebCore::RenderBlock::removePositionedObjects): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::removeFloatingObject): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::newLine): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::clearFloats): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout): (WebCore::RenderBlock::getClearDelta): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::getBaselineOfFirstLineBox): (WebCore::RenderBlock::getBaselineOfLastLineBox): (WebCore::getHeightForLineCount): (WebCore::RenderBlock::adjustForBorderFit):
- rendering/RenderBlock.h: (WebCore::RenderBlock::FloatWithRect::FloatWithRect): (WebCore::RenderBlock::hasOverhangingFloats): (WebCore::RenderBlock::CompactInfo::compact): (WebCore::RenderBlock::CompactInfo::set):
- rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::offsetLeft): (WebCore::RenderBox::offsetTop): (WebCore::RenderBox::offsetParent): (WebCore::RenderBox::clientWidth): (WebCore::RenderBox::clientHeight): (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight): (WebCore::RenderBox::scrollLeft): (WebCore::RenderBox::scrollTop): (WebCore::RenderBox::setScrollLeft): (WebCore::RenderBox::setScrollTop): (WebCore::RenderBox::absoluteRects): (WebCore::RenderBox::absoluteQuads): (WebCore::RenderBox::absoluteContentBox): (WebCore::RenderBox::absoluteContentQuad): (WebCore::RenderBox::absoluteOutlineBounds): (WebCore::RenderBox::addFocusRingRects): (WebCore::RenderBox::reflectionBox): (WebCore::RenderBox::reflectionOffset): (WebCore::RenderBox::reflectedRect): (WebCore::RenderBox::overrideWidth): (WebCore::RenderBox::overrideHeight): (WebCore::RenderBox::nodeAtPoint): (WebCore::RenderBox::paint): (WebCore::RenderBox::maskClipRect): (WebCore::RenderBox::repaintLayerRectsForImage): (WebCore::RenderBox::paintCustomHighlight): (WebCore::RenderBox::getOverflowClipRect): (WebCore::RenderBox::getClipRect): (WebCore::RenderBox::containingBlockWidth): (WebCore::RenderBox::localToAbsolute): (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::position): (WebCore::RenderBox::computeAbsoluteRepaintRect): (WebCore::RenderBox::repaintDuringLayoutIfMoved): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::calcHorizontalMargins): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedHeightUsing): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced): (WebCore::RenderBox::localCaretRect): (WebCore::RenderBox::lowestPosition): (WebCore::RenderBox::rightmostPosition): (WebCore::RenderBox::leftmostPosition): (WebCore::RenderBox::localTransform):
- rendering/RenderBox.h: (WebCore::): (WebCore::RenderBox::x): (WebCore::RenderBox::y): (WebCore::RenderBox::width): (WebCore::RenderBox::height): (WebCore::RenderBox::setX): (WebCore::RenderBox::setY): (WebCore::RenderBox::setWidth): (WebCore::RenderBox::setHeight): (WebCore::RenderBox::location): (WebCore::RenderBox::size): (WebCore::RenderBox::setLocation): (WebCore::RenderBox::setSize): (WebCore::RenderBox::move): (WebCore::RenderBox::frameRect): (WebCore::RenderBox::setFrameRect): (WebCore::RenderBox::borderBoxRect): (WebCore::RenderBox::contentBoxRect): (WebCore::RenderBox::previousSiblingBox): (WebCore::RenderBox::nextSiblingBox): (WebCore::RenderBox::parentBox): (WebCore::RenderBox::overflowHeight): (WebCore::RenderBox::overflowWidth): (WebCore::RenderBox::setOverflowHeight): (WebCore::RenderBox::setOverflowWidth): (WebCore::RenderBox::overflowLeft): (WebCore::RenderBox::overflowTop): (WebCore::RenderBox::overflowRect): (WebCore::RenderBox::contentWidth): (WebCore::RenderBox::contentHeight): (WebCore::RenderBox::offsetWidth): (WebCore::RenderBox::offsetHeight): (WebCore::RenderBox::clientLeft): (WebCore::RenderBox::clientTop): (WebCore::RenderBox::availableWidth): (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
- rendering/RenderButton.cpp: (WebCore::RenderButton::controlClipRect):
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout): (WebCore::RenderContainer::positionForCoordinates):
- rendering/RenderContainer.h: (WebCore::RenderContainer::firstChildBox): (WebCore::RenderContainer::lastChildBox):
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::calcPrefWidths): (WebCore::RenderFieldset::layoutLegend): (WebCore::RenderFieldset::findLegend): (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintMask):
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::maxFilenameWidth): (WebCore::RenderFileUploadControl::paintObject):
- rendering/RenderFlexibleBox.cpp: (WebCore::FlexBoxIterator::FlexBoxIterator): (WebCore::FlexBoxIterator::first): (WebCore::FlexBoxIterator::next): (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderFlexibleBox::calcVerticalPrefWidths): (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox): (WebCore::RenderFlexibleBox::placeChild): (WebCore::RenderFlexibleBox::allowedChildFlex):
- rendering/RenderFlexibleBox.h:
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect): (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition): (WebCore::RenderFlow::localCaretRect): (WebCore::RenderFlow::addFocusRingRects):
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint): (WebCore::RenderFrameSet::layout): (WebCore::RenderFrameSet::positionFrames):
- rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced): (WebCore::RenderHTMLCanvas::canvasSizeChanged):
- rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::nodeAtPoint): (WebCore::RenderImage::calcReplacedWidth):
- rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::boundingBoxWidth): (WebCore::RenderInline::boundingBoxHeight): (WebCore::RenderInline::positionForCoordinates):
- rendering/RenderInline.h: (WebCore::RenderInline::offsetWidth): (WebCore::RenderInline::offsetHeight):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateTransform): (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::scrollbarCornerPresent): (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::boundingBox):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::calcHeight): (WebCore::RenderListBox::controlClipRect):
- rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker): (WebCore::RenderListItem::paint):
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::imageChanged): (WebCore::RenderListMarker::getRelativeMarkerRect): (WebCore::RenderListMarker::selectionRect):
- rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::computePosition):
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout): (WebCore::RenderMedia::lowestPosition): (WebCore::RenderMedia::rightmostPosition): (WebCore::RenderMedia::leftmostPosition):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::controlClipRect):
- rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::markAllDescendantsWithFloatsForLayout): (WebCore::RenderObject::paintOutline): (WebCore::RenderObject::addLineBoxRects): (WebCore::RenderObject::absoluteBoundingBoxRect): (WebCore::RenderObject::addAbsoluteRectForLayer): (WebCore::RenderObject::paintingRootRect): (WebCore::RenderObject::container): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::updateHitTestResult): (WebCore::RenderObject::addDashboardRegions): (WebCore::RenderObject::localTransform):
- rendering/RenderObject.h: (WebCore::RenderObject::isBox): (WebCore::RenderObject::hasMask): (WebCore::RenderObject::setIsText): (WebCore::RenderObject::setIsBox): (WebCore::RenderObject::borderTop): (WebCore::RenderObject::borderBottom): (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::collectAbsoluteLineBoxQuads): (WebCore::RenderObject::absoluteQuads): (WebCore::RenderObject::hasReflection): (WebCore::RenderObject::addFocusRingRects): (WebCore::RenderObject::absoluteOutlineBounds):
- rendering/RenderPart.cpp: (WebCore::RenderPart::updateWidgetPosition):
- rendering/RenderPath.cpp: (WebCore::RenderPath::layout): (WebCore::RenderPath::paint): (WebCore::RenderPath::absoluteOutlineBounds):
- rendering/RenderPath.h:
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::layout): (WebCore::RenderReplaced::paint): (WebCore::RenderReplaced::shouldPaint): (WebCore::RenderReplaced::positionForCoordinates): (WebCore::RenderReplaced::localSelectionRect): (WebCore::RenderReplaced::adjustOverflowForBoxShadow): (WebCore::RenderReplaced::overflowRect):
- rendering/RenderReplica.cpp: (WebCore::RenderReplica::layout): (WebCore::RenderReplica::calcPrefWidths): (WebCore::RenderReplica::paint):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::absoluteOutlineBounds):
- rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::width): (WebCore::RenderSVGContainer::height):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout):
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange): (WebCore::RenderSVGInlineText::positionForCoordinates):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::applyContentTransforms): (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::absoluteTransform): (WebCore::RenderSVGRoot::nodeAtPoint):
- rendering/RenderSVGTSpan.cpp: (WebCore::RenderSVGTSpan::absoluteRects): (WebCore::RenderSVGTSpan::absoluteQuads):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): (WebCore::RenderSVGText::relativeBBox):
- rendering/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::absoluteRects): (WebCore::RenderSVGTextPath::absoluteQuads):
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::nodeAtPoint):
- rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::createCustomScrollbar): (WebCore::RenderScrollbar::RenderScrollbar): (WebCore::RenderScrollbar::setParent):
- rendering/RenderScrollbar.h: (WebCore::RenderScrollbar::owningRenderer):
- rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::layout): (WebCore::RenderScrollbarPart::layoutHorizontalPart): (WebCore::RenderScrollbarPart::layoutVerticalPart): (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight): (WebCore::RenderScrollbarPart::paintIntoRect):
- rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): (WebCore::RenderSlider::layout): (WebCore::RenderSlider::mouseEventIsInThumb): (WebCore::RenderSlider::positionForOffset): (WebCore::RenderSlider::trackSize):
- rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::paint): (WebCore::RenderTable::getBaselineOfFirstLineBox):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::updateWidth): (WebCore::RenderTableCell::computeAbsoluteRepaintRect): (WebCore::RenderTableCell::localToAbsolute): (WebCore::RenderTableCell::absoluteToLocal): (WebCore::RenderTableCell::localToAbsoluteQuad): (WebCore::RenderTableCell::paint): (WebCore::RenderTableCell::paintBackgroundsBehindCell):
- rendering/RenderTableCell.h:
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition): (WebCore::RenderTableSection::getBaselineOfFirstLineBox): (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::recalcCells): (WebCore::RenderTableSection::nodeAtPoint):
- rendering/RenderTableSection.h: (WebCore::RenderTableSection::overflowWidth): (WebCore::RenderTableSection::overflowHeight):
- rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::boundingBoxX): (WebCore::RenderText::boundingBoxY): (WebCore::RenderText::firstRunX): (WebCore::RenderText::firstRunY): (WebCore::RenderText::boundingBoxHeight): (WebCore::RenderText::boundingBoxWidth):
- rendering/RenderText.h:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::textBlockHeight): (WebCore::RenderTextControl::textBlockWidth): (WebCore::RenderTextControl::setSelectionRange): (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::hitInnerTextBlock): (WebCore::RenderTextControl::controlClipRect):
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::layout): (WebCore::RenderTextControlMultiLine::adjustControlHeightBasedOnLineHeight):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paint): (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::forwardEvent): (WebCore::RenderTextControlSingleLine::textBlockWidth): (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): (WebCore::RenderTextControlSingleLine::clientPaddingLeft): (WebCore::RenderTextControlSingleLine::clientPaddingRight):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::hitTestMediaControlPart): (WebCore::RenderTheme::baselinePosition):
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsButton): (WebCore::RenderThemeMac::hitTestMediaControlPart):
- rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::videoBox):
- rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::calcHeight): (WebCore::RenderView::calcWidth): (WebCore::RenderView::layout): (WebCore::RenderView::viewRect): (WebCore::RenderView::docHeight): (WebCore::RenderView::docWidth): (WebCore::RenderView::setBestTruncatedAt):
- rendering/RenderView.h:
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): (WebCore::RenderWidget::updateWidgetPosition): (WebCore::RenderWidget::nodeAtPoint):
- rendering/RootInlineBox.h: (WebCore::RootInlineBox::floats): (WebCore::RootInlineBox::floatsPtr):
- rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
- rendering/SVGInlineFlowBox.h:
- rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::write):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::verticallyAlignBoxes): (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): (WebCore::SVGRootInlineBox::layoutInlineBoxes):
- rendering/SVGRootInlineBox.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::computeVerticalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::matchedEndLine): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::RenderBlock::fitBelowFloats): (WebCore::RenderBlock::findNextLineBreak): (WebCore::RenderBlock::checkLinesForOverflow):
- svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
WebKit/mac:
2009-01-21 David Hyatt <hyatt@apple.com>
Devirtualize width/height/x/y on RenderObject and move the methods to RenderBox.
Reviewed by Eric Seidel and Darin Adler
- WebView/WebRenderNode.mm: (copyRenderNode):
- 5:39 PM Changeset in webkit [40106] by
-
- 8 edits in trunk/WebKit/mac
2009-01-21 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
More browser->plug-in scripting support.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCNPObjectHasPropertyReply): (WKPCNPObjectHasMethodReply): (WKPCNPObjectInvokeReply): MIG reply functions.
(WKPCIdentifierInfo):
Return information about an identifier given its 64-bit value.
- Plugins/Hosted/NetscapePluginInstanceProxy.h: Add new reply structs.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::addValueToArray): Split out code that adds values to the arrays from marshalValue.
(WebKit::NetscapePluginInstanceProxy::marshalValue):
Call addValueToArray.
(WebKit::NetscapePluginInstanceProxy::marshalValues):
Marshal a list of values.
(WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
Actually create a proxy instance.
- Plugins/Hosted/ProxyInstance.h:
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyClass::methodsNamed): (WebKit::ProxyClass::fieldNamed): Add a proxy ProxyClass class that just forwards everything to the ProxyInstance class.
(WebKit::proxyClass):
Shared proxyClass getter.
(WebKit::ProxyField::ProxyField):
(WebKit::ProxyField::valueFromInstance):
(WebKit::ProxyField::setValueToInstance):
Add a proxy ProxyField class that just forwards everything to the ProxyInstance class.
(WebKit::ProxyMethod::ProxyMethod):
(WebKit::ProxyMethod::serverIdentifier):
(WebKit::ProxyMethod::numParameters):
Add a dummy ProxyMethod class.
(WebKit::ProxyInstance::invokeMethod):
Call _WKPHNPObjectInvoke.
(WebKit::ProxyInstance::defaultValue):
(WebKit::ProxyInstance::stringValue):
(WebKit::ProxyInstance::numberValue):
(WebKit::ProxyInstance::booleanValue):
(WebKit::ProxyInstance::valueOf):
Add dummy implementations (taken from CInstance).
(WebKit::ProxyInstance::methodsNamed):
Call _WKPHNPObjectHasMethod to determine whether a method with the given name exists.
(WebKit::ProxyInstance::fieldNamed):
Call _WKPHNPObjectHasProperty to determine whether a property with the given name exists.
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs: Add new MIG definitions.
- 5:39 PM Changeset in webkit [40105] by
-
- 2 edits in trunk/WebKitTools
2009-01-21 Pierre-Olivier Latour <pol@apple.com>
Tweaked earlier fix to only print a warning when Perian is installed,
and fail completely only if attempting to generate new pixel test results.
- Scripts/run-webkit-tests:
- 4:50 PM Changeset in webkit [40104] by
-
- 3 edits in trunk/WebCore
2009-01-21 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
- WebCore.LP64.exp: Add some bridge related symbols.
- WebCore.xcodeproj/project.pbxproj: Make runtime_object.h a private header.
- 4:22 PM Changeset in webkit [40103] by
-
- 10 edits5 adds in trunk/WebCore
Bug 22720: Make XMLHttpRequest work in Workers
<https://bugs.webkit.org/show_bug.cgi?id=22720>
Contributed by David Levin.
Reviewed by Alexey Proskuryakov
More removal of document usage from XMLHttpRequest.
- Abstracted away the sync and async requests behind the ThreadableLoader class, which will get an implementation for Workers. It follows the same model as SubresourceLoader, since it is a thin wrapper around it.
- Consolidated dashboard compatibility checks into usesDashboardBackwardCompatibilityMode which handles workers.
No observable change in behavior, so no test.
- 4:13 PM Changeset in webkit [40102] by
-
- 6 edits2 adds in trunk
The high CPU usage was really from repeatedly firing transitions caused
by a bug in the way we handle background-color animations. If animating
from a valid background color to no background color, we sometimes left
(based on timing) the background color as transparent black, but valid
rather than invalid, which it should be. Fixing that got rid of the
repeated firing.
But we really were doing more expensive iteration of all objects with
animations or transitions on them (running or not). So I added two
optimizations to quickly short circuit when an object had no running
animations or transitions. Things are now as zippy as ever.
- 3:37 PM Changeset in webkit [40101] by
-
- 5 edits in trunk
Reviewed by Justin Garcia.
Remove the style= turds left by some editing commands
https://bugs.webkit.org/show_bug.cgi?id=23463
Test: editing/execCommand/toggle-styles.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeCSSStyle): check if we just removed the last CSS property and remove the style attribute as well
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeNodeAttribute): remove extra ;
- 3:25 PM Changeset in webkit [40100] by
-
- 6 edits in trunk/WebKit/mac
Clean up how we force invocations of API that happened on background threads over to the main thread.
This was previously accomplished in a somewhat ad-hoc manner using a mutable dictionary to pass arguments
and return values back from the function. The new approach is to use a proxy object that forwards an
NSInvocation over to the main thread and applies it to the target object, which leads to a much cleaner
call site.
Reviewed by Tim Hatcher.
- Misc/WebNSObjectExtras.h:
- Misc/WebNSObjectExtras.mm:
(-[WebMainThreadInvoker initWithTarget:]):
(-[WebMainThreadInvoker forwardInvocation:]):
(-[WebMainThreadInvoker methodSignatureForSelector:]):
(-[WebMainThreadInvoker handleException:]):
(-[NSInvocation _webkit_invokeAndHandleException:]): Execute the invocation and forward any exception that was
raised back to the WebMainThreadInvoker.
(-[NSObject _webkit_invokeOnMainThread]):
The following methods are updated to use the proxy object to forward methods to the main thread:
- WebView/WebArchive.mm:
(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
(-[WebArchive mainResource]):
(-[WebArchive subresources]):
(-[WebArchive subframeArchives]):
- WebView/WebResource.mm:
(-[WebResource data]):
(-[WebResource URL]):
(-[WebResource MIMEType]):
(-[WebResource textEncodingName]):
(-[WebResource frameName]):
(-[WebResource _ignoreWhenUnarchiving]):
(-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
(-[WebResource _initWithData:URL:response:]):
(-[WebResource _suggestedFilename]):
(-[WebResource _response]):
(-[WebResource _stringValue]):
- WebView/WebView.mm:
(-[WebView initWithFrame:frameName:groupName:]):
(-[WebView initWithCoder:]):
- 3:20 PM Changeset in webkit [40099] by
-
- 2 edits in trunk/WebCore
No review, build fix.
Fix release-only build failure (and do a tiny code-cleanup).
- editing/ApplyStyleCommand.cpp: (WebCore::createFontElement): (WebCore::createStyleSpanElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- 2:55 PM Changeset in webkit [40098] by
-
- 10 edits2 adds in trunk
Bug 23443: Table accessibility should be re-enabled after fixing crash that occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when attempting to create a link in a rich text message
https://bugs.webkit.org/show_bug.cgi?id=23443
Re-enable Accessibility tables and make sure accessibility code does not interrogate the render tree
during render tree updates
- 2:16 PM Changeset in webkit [40097] by
-
- 8 edits in trunk
Reviewed by Justin Garcia.
Fix execCommand() 'super' and 'sub' commands to add <sup> and <sub> in quirks mode, and to toggle when called twice
https://bugs.webkit.org/show_bug.cgi?id=17733
Test changed: editing/execCommand/toggle-styles-expected.txt
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::applySubscript): (WebCore::StyleChange::applySuperscript): (WebCore::StyleChange::StyleChange): (WebCore::StyleChange::init): (WebCore::StyleChange::checkForLegacyHTMLStyleChange): (WebCore::ApplyStyleCommand::isHTMLStyleNode): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- editing/EditorCommand.cpp: (WebCore::executeSubscript): (WebCore::executeSuperscript):
- editing/htmlediting.cpp: (WebCore::createHTMLElement):
- editing/htmlediting.h:
- 1:52 PM Changeset in webkit [40096] by
-
- 2 edits in trunk/WebCore
2009-01-21 Anders Carlsson <andersca@apple.com>
Fix 64-bit build.
- WebCore.LP64.exp:
- 1:34 PM Changeset in webkit [40095] by
-
- 1 copy in tags/Safari-5525.28
New tag.
- 1:32 PM Changeset in webkit [40094] by
-
- 4 edits in branches/Safari-3-2-branch
Versioning.
- 1:25 PM Changeset in webkit [40093] by
-
- 1 edit in branches/Safari-3-2-branch/WebKitLibraries/win/tools/scripts/PRODUCTVERSION
Bump version number.
- 1:25 PM Changeset in webkit [40092] by
-
- 9 edits5 adds in branches/Safari-3-2-branch
Merge r33579.
- 1:25 PM Changeset in webkit [40091] by
-
- 2 edits in branches/Safari-3-2-branch/WebCore
Merge r33993.
- 1:24 PM Changeset in webkit [40090] by
-
- 2 edits in branches/Safari-3-2-branch/WebCore
Merge r39247.
- 1:05 PM Changeset in webkit [40089] by
-
- 13 edits3 copies in trunk/WebCore
Bug 23458: Reintroduce CanvasPixelArray in ImageData.idl
<https://bugs.webkit.org/show_bug.cgi?id=23458>
Reviewed by Alexey Proskuryakov.
Return CanvasPixelArray, et al -- the only difference between this
and the original CPA implementation is that it now uses a ByteArray
rather than a vector. JSC still uses a custom wrapper, but this allows
ObjC, COM, and V8 bindings to be autogenerated again.
- 12:07 PM Changeset in webkit [40088] by
-
- 13 edits4 deletes in trunk/WebCore
2009-01-21 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Remove last relics of platform dependent PaintServer in SVG.
We draw everything with the help of GraphicsContext.
Remove SVGPaintServerPlatform's
https://bugs.webkit.org/show_bug.cgi?id=23439
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- svg/graphics/SVGPaintServer.cpp: (WebCore::SVGPaintServer::draw): (WebCore::SVGPaintServer::renderPath): (WebCore::SVGPaintServer::teardown):
- svg/graphics/SVGPaintServer.h:
- svg/graphics/SVGPaintServerGradient.cpp:
- svg/graphics/SVGPaintServerGradient.h:
- svg/graphics/SVGPaintServerPattern.cpp:
- svg/graphics/SVGPaintServerPattern.h:
- svg/graphics/SVGPaintServerSolid.cpp:
- svg/graphics/SVGPaintServerSolid.h:
- svg/graphics/cairo/SVGPaintServerCairo.cpp: Removed.
- svg/graphics/cg/SVGPaintServerCg.cpp: Removed.
- svg/graphics/qt/SVGPaintServerQt.cpp: Removed.
- svg/graphics/skia/SVGPaintServerSkia.cpp: Removed.
- 11:49 AM Changeset in webkit [40087] by
-
- 7 edits in trunk/WebCore
Reviewed by Alexey Proskuryakov.
Move "Element -> ScriptElement" casting functionality into ScriptElement.h
to be consistent with FormControlElement/InputElement/OptionElement/OptionGroupElement.
It was living in XMLTokenizer before, which is not an obvious place for this.
TODO: Rename 'formControlElementForElement' to 'toFormControlElement' (analogous changes for InputElement etc.)
as suggested by Alexey, it really reads better this way.
- 10:09 AM Changeset in webkit [40086] by
-
- 2 edits in trunk/JavaScriptCore
Suggested by Oliver Hunt. Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=23456
Function argument names leak
- parser/Nodes.cpp: (JSC::FunctionBodyNode::~FunctionBodyNode): Destruct parameter names.
- 8:44 AM Changeset in webkit [40085] by
-
- 12 edits4 adds in trunk/WebCore
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=23444
Refactor some functionality from HTMLOption/OptGroupElement needed by RenderListBox/RenderMenuList
in two abstract base classes: OptionElement & OptionGroupElement living in dom/ - just like it
has been done before for FormControlElement and RenderTextControl.
This is needed to prepare the addtion of WMLOption/OptGroupElement.
- 7:22 AM QtWebKitJournal edited by
- (diff)
- 7:22 AM QtWebKitJournal edited by
- (diff)
Jan 20, 2009:
- 11:39 PM Changeset in webkit [40084] by
-
- 2 edits in trunk/WebCore
2009-01-20 Darin Adler <Darin Adler>
Reviewed by Alexey Proskuryakov.
Bug 23448: memory leak in Mac version of preferredExtensionForImageSourceType
https://bugs.webkit.org/show_bug.cgi?id=23448
- platform/graphics/cg/ImageSourceCGMac.mm: (WebCore::preferredExtensionForImageSourceType): Use RetainPtr to avoid the leak.
- 11:25 PM Changeset in webkit [40083] by
-
- 2 edits in trunk/WebKitTools
2009-01-20 Darin Adler <Darin Adler>
Reviewed by Alexey Proskuryakov.
Bug 23450: string leaks seen in DumpRenderTree accessibility test code
https://bugs.webkit.org/show_bug.cgi?id=23450
- DumpRenderTree/AccessibilityUIElement.cpp: (isAttributeSettableCallback): Add the missing JSStringRelease call. (attributeValueCallback): Ditto.
- 10:38 PM Changeset in webkit [40082] by
-
- 2 edits in trunk/WebCore
2009-01-20 Darin Adler <Darin Adler>
Try to fix Wx build.
- platform/wx/PasteboardWx.cpp: (WebCore::Pasteboard::writeSelection): Removed code that replaces backslash with backslashAsCurrencySymbol. I'm pretty sure this is not needed when writing to the clipboard. Other platforms don't do it. If it was needed, the new function to use would be displayStringModifiedByEncoding.
- 9:28 PM Changeset in webkit [40081] by
-
- 2 edits in trunk/WebCore
Teach Cairo post-build stage to copy animation headers.
- 8:49 PM Changeset in webkit [40080] by
-
- 3 edits in trunk/WebCore
2009-01-20 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=23413
Remove unused WebCore::setDeferringTimers()
- platform/Timer.cpp: (WebCore::updateSharedTimer):
- platform/Timer.h:
- 7:51 PM Changeset in webkit [40079] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
- 7:19 PM Changeset in webkit [40078] by
-
- 3 edits in trunk/WebCore
2009-01-20 David Hyatt <hyatt@apple.com>
Tighten up the type of RenderObject owned by RenderLayer to be a RenderBox. Rename m_object to
m_renderer to be consistent with the corresponding member function.
Reviewed by Jon Honeycutt
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::stackingContext): (WebCore::RenderLayer::enclosingPositionedAncestor): (WebCore::RenderLayer::enclosingTransformedAncestor): (WebCore::RenderLayer::isTransparent): (WebCore::RenderLayer::convertToLayerCoords): (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::resize): (WebCore::RenderLayer::scrollbarCornerPresent): (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::computeScrollDimensions): (WebCore::RenderLayer::updateOverflowStatus): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::updateClipRects): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::clearClipRects): (WebCore::RenderLayer::repaintIncludingDescendants): (WebCore::RenderLayer::styleChanged): (WebCore::RenderLayer::updateScrollCornerStyle): (WebCore::RenderLayer::updateResizerStyle):
- rendering/RenderLayer.h: (WebCore::RenderLayer::renderer): (WebCore::RenderLayer::hasReflection): (WebCore::RenderLayer::hasTransform):
- 5:59 PM Changeset in webkit [40077] by
-
- 2 edits in trunk/WebCore
2009-01-20 David Hyatt <hyatt@apple.com>
Fix Mac build bustage from my selection changes. I forgot to implement the functions on RenderThemeMac
for returning the appropriate listbox selection colors.
Reviewed by Adele
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
- 5:53 PM Changeset in webkit [40076] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Mark Rowe.
Structure property table deleted offset maps are being leaked.
Probably shouldn't be doing that.
- runtime/Structure.cpp: (JSC::Structure::~Structure):
- 4:30 PM Changeset in webkit [40075] by
-
- 3 edits in trunk/WebKitTools
2009-01-20 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Darin Adler.
Print warning regarding display color profile change in run-webkit-tests instead of DRT.
- DumpRenderTree/mac/PixelDumpSupportMac.mm: (setupMainDisplayColorProfile):
- Scripts/run-webkit-tests:
- 3:31 PM Changeset in webkit [40074] by
-
- 8 edits in trunk/WebCore
Fix selection colors and focus rings on Windows.
- 3:25 PM Changeset in webkit [40073] by
-
- 3 edits in trunk/WebKitTools
2009-01-20 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Darin Adler.
Changed run-webkit-tests to abort on the Mac if pixel tests are enabled and Perian is installed,
in order to avoid result differences in some media tests.
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
- 2:35 PM Changeset in webkit [40072] by
-
- 2 edits in trunk/JavaScriptCore
Attempt to fix gtk build
- 2:29 PM Changeset in webkit [40071] by
-
- 12 edits6 adds in trunk
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=23434
Add WML <input> element support - it required a lot of changes to the RenderText*/HTMLInput* code.
Now any language can provide <input>-style elements, without having to inherit from HTML* classes.
No WML specific features/attributes are handled so far. A follow-up patch will provide those bits.
Added very simple fast/wml/input.wml, just checking that input elements can be rendered properly now.
Detailed testcases will follow in conjunction with the WML specific attribute support.
- 1:54 PM Changeset in webkit [40070] by
-
- 2 edits in trunk/WebCore
2009-01-20 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
Remove a little dead code left over after the fix for
https://bugs.webkit.org/show_bug.cgi?id=11395, which
moved pointer-events from SVG to be shared with HTML.
- css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): Remove SVG's parsing of this property since it's handled in the non-SVG function now so we'll never get here.
- 1:54 PM Changeset in webkit [40069] by
-
- 8 edits in trunk/WebCore
009-01-20 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Bug 23438: Provide a default value to the .in file parser
Added the default value 1 as it simplifies some of
the format by removing some "=1" that were awkward.
This was suggested by Darin Adler as par of a previous
review.
- bindings/scripts/InFilesParser.pm: When no value was entered (the second part of the split is undef), provide the default value.
- html/HTMLAttributeNames.in: Removed unnecessary "=1".
- html/HTMLTagNames.in: Ditto.
- svg/svgattrs.in: Ditto.
- svg/svgtags.in: Ditto.
- svg/xlinkattrs.in: Ditto.
- wml/WMLAttributeNames.in: Ditto.
- 1:41 PM Changeset in webkit [40068] by
-
- 11 edits in trunk/WebCore
2009-01-20 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
- bridge/c/c_class.cpp:
- bridge/c/c_class.h: Get rid of CClass::name().
- bridge/jni/jni_class.h: Get rid of JavaClass::name().
- bridge/objc/objc_class.h:
- bridge/objc/objc_class.mm: Get rid of ObjcClass::name().
- bridge/objc/objc_instance.h: Get rid of supportsSetValueOfUndefinedField.
- bridge/objc/objc_instance.mm: (ObjcInstance::setValueOfUndefinedField): Fold supportsSetValueOfUndefinedField into setValueOfUndefinedField.
- bridge/runtime.cpp: Get rid of getValueOfField and setValueOfField.
- bridge/runtime.h: (JSC::Bindings::Instance::setValueOfUndefinedField): Have this return a bool and get rid of supportsSetValueOfUndefinedField
- bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::fieldGetter): Call Field::valueFromInstance on the field.
(JSC::RuntimeObjectImp::put):
Call Field::setValueToInstance on the field.
- 1:29 PM Changeset in webkit [40067] by
-
- 6 edits in trunk/WebCore
Not reviewed. Forgot to land build changes for non-mac platforms.
Add InputElement.cpp & FormControlElement.cpp to build.
- 1:18 PM Changeset in webkit [40066] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
Fix last-minute regression, introduced by simplifying max length determination - by
clamping using min/max, negative maxLength values got broken.
- 1:02 PM Changeset in webkit [40065] by
-
- 9 edits3 adds in trunk/WebCore
Reviewed by Adam Roben.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=23433
Add InputElement abstraction, similar to the FormControlElement refactorization
done a month ago. The goal is to share as much code as possible between HTML/WMLInputElement.
In a previous patch the RenderTextControl class has been split-up in RenderTextControlSingle/MultiLine,
RenderTextControl itself only depends on FormControlElement, RenderTextControlSingleLine still
depends on HTMLInputElement directly -> change that and make it use the new InputElement abstraction.
A lot of code from HTMLInputElement now lives in InputElement, as static member functions - the
InputElement class itself is an abstract virtual class, just like ScriptElement. HTML/WMLInputElement
derive from InputElement, and hold a InputElementData member variable, that they pass to the
static functions in InputElement. The abstraction is equal to the one chosen for HTML/SVGScriptElement.
- 12:54 PM Changeset in webkit [40064] by
-
- 3 edits in trunk/LayoutTests
2009-01-20 Pierre-Olivier Latour <pol@apple.com>
Previously uploaded reference images were generated with Perian installed, which affected them
as explained in https://bugs.webkit.org/show_bug.cgi?id=22615.
- platform/mac/media/video-zoom-expected.checksum:
- platform/mac/media/video-zoom-expected.png:
- 11:52 AM Changeset in webkit [40063] by
-
- 14 edits4 deletes in trunk
2009-01-20 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Make SVG pattern platform independent and remove platform code.
Make SVGPattern platform independent
https://bugs.webkit.org/show_bug.cgi?id=21205
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/GraphicsContext.h:
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokeRect):
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::SVGPaintServerPattern): (WebCore::SVGPaintServerPattern::~SVGPaintServerPattern): (WebCore::SVGPaintServerPattern::setup): (WebCore::SVGPaintServerPattern::renderPath): (WebCore::SVGPaintServerPattern::teardown):
- svg/graphics/SVGPaintServerPattern.h:
- svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: Removed.
- svg/graphics/cg/SVGPaintServerPatternCg.cpp: Removed.
- svg/graphics/qt/SVGPaintServerPatternQt.cpp: Removed.
- svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Removed.
LayoutTests:
stroke-pattern is wrong and coords-units-01-b match the behavior of
batik and Firefox.
- platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
- platform/mac/svg/custom/stroked-pattern-expected.checksum:
- platform/mac/svg/custom/stroked-pattern-expected.png:
- 11:39 AM Changeset in webkit [40062] by
-
- 1 edit6 adds in trunk/WebCore
2009-01-20 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23436
Upstream rendering/RenderThemeChromium*
- rendering/RenderThemeChromiumGtk.cpp: Added.
- rendering/RenderThemeChromiumGtk.h: Added.
- rendering/RenderThemeChromiumMac.h: Added.
- rendering/RenderThemeChromiumMac.mm: Added.
- rendering/RenderThemeChromiumWin.cpp: Added.
- rendering/RenderThemeChromiumWin.h: Added.
- 11:33 AM Changeset in webkit [40061] by
-
- 9 edits2 adds in trunk/WebKit
WebKit:
2009-01-20 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add ProxyInstance files.
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2009-01-19 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add and implement GetScriptableNPObject.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetScriptableNPObjectReply): Create a new reply struct and set it as the current reply.
(WKPCEvaluate):
Get rid of an unused variable.
- Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::Reply::): (WebKit::NetscapePluginInstanceProxy::GetScriptableNPObjectReply::GetScriptableNPObjectReply):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Call _WKPHGetScriptableNPObject and wait for a reply.
- Plugins/Hosted/ProxyInstance.h: Added.
- Plugins/Hosted/ProxyInstance.mm: Added. Add empty files.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView JSC::Bindings::createPluginBindingsInstance:JSC::Bindings::]): Call NetscapePluginInstanceProxy::createBindingsInstance.
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs: Add new declarations.
- 10:38 AM Changeset in webkit [40060] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-20 Darin Adler <Darin Adler>
- runtime/StringPrototype.cpp: (JSC::substituteBackreferences): Add back the initialization to fix the build.
- 10:25 AM Changeset in webkit [40059] by
-
- 15 edits in trunk
2009-01-20 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352
First patch: Fix some simple cases of various warnings.
- pcre/pcre_compile.cpp: (jsRegExpCompile): Use const_cast to change const-ness.
- runtime/StringPrototype.cpp: (JSC::substituteBackreferences): Remove unneeded initialization and use UChar instead of unsigned short for UTF-16 values.
- wtf/dtoa.cpp: (WTF::strtod): Use const_cast to change const-ness.
WebCore:
2009-01-20 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352
First patch: Fix some simple cases of various warnings.
- platform/DeprecatedPtrListImpl.cpp: (WebCore::DeprecatedPtrListImpl::insert): Use const_cast to change const-ness.
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::containsCharacters): Ditto.
- platform/text/PlatformString.h: Overload for short and unsigned short to avoid ambiguity leading to warnings.
- platform/text/String.cpp: (WebCore::String::number): Implemented overloads.
- platform/text/TextStream.cpp: (WebCore::TextStream::operator<<): Overload for bool to avoid ambiguity leading to warnings.
- platform/text/TextStream.h: Ditto.
- rendering/InlineFlowBox.h: Fix declaration that was specifying the wrong type.
- svg/graphics/filters/cg/WKLinearTransferFilter.m: Fix stray characters after #endif that should be a comment instead.
- svg/graphics/filters/cg/WKSpecularLightingFilter.h: Ditto.
- xml/XPathPath.h: Remove unneeded redundant declaration.
- 9:44 AM Changeset in webkit [40058] by
-
- 2 edits in trunk/WebCore
Build fix for WML enabled builds, not reviewed.
Fix unused variable warning.
- 9:23 AM Changeset in webkit [40057] by
-
- 2 edits in trunk/WebCore
Build fix for WML enabled builds, not reviewed.
Rename 'continuation' to 'virtualContinuation'.
- 9:04 AM Changeset in webkit [40056] by
-
- 4 edits in trunk/JavaScriptCore
Whoops, remove runtime/ByteArray references from .pri and .scons builds, update .bkl
Build fix.
- 8:57 AM Changeset in webkit [40055] by
-
- 14 edits3 moves in trunk
Move runtime/ByteArray to wtf/ByteArray
RS=Dan Bernstein
- 8:06 AM Changeset in webkit [40054] by
-
- 1 edit2 adds in trunk/WebCore
2009-01-20 Darin Fisher <darin@chromium.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=23391
Upstream plugins/chromium/
- plugins/chromium: Added.
- plugins/chromium/PluginDataChromium.cpp: Added.
- 4:26 AM Changeset in webkit [40053] by
-
- 2 edits in trunk/WebKit/qt
2009-01-20 Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed by Simon Hausmann.
Fix spelling error in QWebPage
Jan 19, 2009:
- 11:01 PM Changeset in webkit [40052] by
-
- 2 edits1 add in trunk/WebCore
Fix Windows release build.
Move SVG files into all-in-one file for Windows build.
- WebCore.vcproj/WebCore.vcproj:
- svg/SVGAllInOne.cpp: Added.
- 7:31 PM Changeset in webkit [40051] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-01-19 Simon Fraser <Simon Fraser>
New testcases for transitions of shorthand properties.
- transitions/shorthand-border-transitions-expected.txt: Added.
- transitions/shorthand-border-transitions.html: Added.
- transitions/shorthand-transitions-expected.txt: Added.
- transitions/shorthand-transitions.html: Added.
- 7:14 PM Changeset in webkit [40050] by
-
- 3 edits in trunk/WebCore
Partial build fix.
Move new derived sources into all-in-one DerivedSources.cpp
- DerivedSources.cpp:
- WebCore.vcproj/WebCore.vcproj:
- 6:34 PM Changeset in webkit [40049] by
-
- 2 edits in trunk/WebKitTools
2009-01-19 Sam Weinig <sam@webkit.org>
- Scripts/do-webcore-rename: Add JSValuePtr and ProtectedJSValuePtr.
- 5:29 PM Changeset in webkit [40048] by
-
- 3 edits in trunk/WebCore
2009-01-19 Sam Weinig <sam@webkit.org>
Fix Qt build.
- bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::mark):
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::valueRealType): (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::QtRuntimeConnectionMethod::call): (JSC::Bindings::QtConnectionObject::execute):
- 5:15 PM Changeset in webkit [40047] by
-
- 2 edits in trunk/WebCore
2009-01-19 Sam Weinig <sam@webkit.org>
Fix wx build.
- plugins/PluginView.cpp: (WebCore::getString):
- 4:54 PM Changeset in webkit [40046] by
-
- 150 edits in trunk
2009-01-19 Sam Weinig <sam@webkit.org>
Rubber-stamped by Gavin Barraclough.
Remove temporary operator-> from JSValuePtr.
- API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::call):
- API/JSCallbackObjectFunctions.h: (JSC::::call): (JSC::::toNumber): (JSC::::toString):
- API/JSObjectRef.cpp: (JSObjectSetPrototype):
- API/JSValueRef.cpp: (JSValueGetType): (JSValueIsUndefined): (JSValueIsNull): (JSValueIsBoolean): (JSValueIsNumber): (JSValueIsString): (JSValueIsObject): (JSValueIsObjectOfClass): (JSValueToBoolean): (JSValueToNumber): (JSValueToStringCopy): (JSValueToObject):
- bytecode/CodeBlock.cpp: (JSC::valueToSourceString): (JSC::CodeBlock::mark):
- bytecode/CodeBlock.h: (JSC::CodeBlock::isKnownNotImmediate):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitEqualityOp): (JSC::keyForImmediateSwitch):
- interpreter/Interpreter.cpp: (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAddSlowCase): (JSC::jsAdd): (JSC::jsTypeStringForValue): (JSC::jsIsObjectType): (JSC::jsIsFunctionType): (JSC::isNotObject): (JSC::Interpreter::callEval): (JSC::Interpreter::throwException): (JSC::cachePrototypeChain): (JSC::Interpreter::tryCachePutByID): (JSC::countPrototypeChainEntriesAndCheckForProxies): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute): (JSC::Interpreter::tryCTICachePutByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_convert_this): (JSC::Interpreter::cti_op_add): (JSC::Interpreter::cti_op_pre_inc): (JSC::Interpreter::cti_op_put_by_id_generic): (JSC::Interpreter::cti_op_get_by_id_generic): (JSC::Interpreter::cti_op_put_by_id): (JSC::Interpreter::cti_op_put_by_id_second): (JSC::Interpreter::cti_op_put_by_id_fail): (JSC::Interpreter::cti_op_get_by_id): (JSC::Interpreter::cti_op_get_by_id_second): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::Interpreter::cti_op_get_by_id_proto_list): (JSC::Interpreter::cti_op_get_by_id_proto_list_full): (JSC::Interpreter::cti_op_get_by_id_proto_fail): (JSC::Interpreter::cti_op_get_by_id_array_fail): (JSC::Interpreter::cti_op_get_by_id_string_fail): (JSC::Interpreter::cti_op_instanceof): (JSC::Interpreter::cti_op_del_by_id): (JSC::Interpreter::cti_op_mul): (JSC::Interpreter::cti_op_call_JSFunction): (JSC::Interpreter::cti_op_call_NotJSFunction): (JSC::Interpreter::cti_op_construct_JSConstruct): (JSC::Interpreter::cti_op_construct_NotJSConstruct): (JSC::Interpreter::cti_op_get_by_val): (JSC::Interpreter::cti_op_get_by_val_byte_array): (JSC::Interpreter::cti_op_sub): (JSC::Interpreter::cti_op_put_by_val): (JSC::Interpreter::cti_op_put_by_val_array): (JSC::Interpreter::cti_op_put_by_val_byte_array): (JSC::Interpreter::cti_op_loop_if_true): (JSC::Interpreter::cti_op_negate): (JSC::Interpreter::cti_op_div): (JSC::Interpreter::cti_op_pre_dec): (JSC::Interpreter::cti_op_not): (JSC::Interpreter::cti_op_jtrue): (JSC::Interpreter::cti_op_post_inc): (JSC::Interpreter::cti_op_lshift): (JSC::Interpreter::cti_op_bitand): (JSC::Interpreter::cti_op_rshift): (JSC::Interpreter::cti_op_bitnot): (JSC::Interpreter::cti_op_mod): (JSC::Interpreter::cti_op_post_dec): (JSC::Interpreter::cti_op_urshift): (JSC::Interpreter::cti_op_bitxor): (JSC::Interpreter::cti_op_bitor): (JSC::Interpreter::cti_op_push_scope): (JSC::Interpreter::cti_op_is_undefined): (JSC::Interpreter::cti_op_is_boolean): (JSC::Interpreter::cti_op_is_number): (JSC::Interpreter::cti_op_to_jsnumber): (JSC::Interpreter::cti_op_in): (JSC::Interpreter::cti_op_put_by_index): (JSC::Interpreter::cti_op_switch_imm): (JSC::Interpreter::cti_op_switch_char): (JSC::Interpreter::cti_op_switch_string): (JSC::Interpreter::cti_op_del_by_val): (JSC::Interpreter::cti_op_put_getter): (JSC::Interpreter::cti_op_put_setter): (JSC::Interpreter::cti_op_new_error):
- interpreter/Interpreter.h: (JSC::Interpreter::isJSArray): (JSC::Interpreter::isJSString): (JSC::Interpreter::isJSByteArray):
- interpreter/Register.h: (JSC::Register::marked): (JSC::Register::mark):
- jit/JITInlineMethods.h: (JSC::JIT::getConstantOperandImmediateInt): (JSC::JIT::isOperandConstantImmediateInt):
- jsc.cpp: (functionPrint): (functionDebug): (functionRun): (functionLoad): (runWithScripts): (runInteractive):
- parser/Nodes.cpp: (JSC::processClauseList):
- profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::addParentForConsoleStart):
- profiler/Profiler.cpp: (JSC::Profiler::createCallIdentifier):
- runtime/ArrayConstructor.cpp: (JSC::constructArrayWithSizeQuirk):
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString): (JSC::arrayProtoFuncToLocaleString): (JSC::arrayProtoFuncJoin): (JSC::arrayProtoFuncConcat): (JSC::arrayProtoFuncPop): (JSC::arrayProtoFuncPush): (JSC::arrayProtoFuncReverse): (JSC::arrayProtoFuncShift): (JSC::arrayProtoFuncSlice): (JSC::arrayProtoFuncSort): (JSC::arrayProtoFuncSplice): (JSC::arrayProtoFuncUnShift): (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncMap): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncForEach): (JSC::arrayProtoFuncSome): (JSC::arrayProtoFuncIndexOf): (JSC::arrayProtoFuncLastIndexOf):
- runtime/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::callBooleanConstructor):
- runtime/BooleanPrototype.cpp: (JSC::booleanProtoFuncToString): (JSC::booleanProtoFuncValueOf):
- runtime/Collector.cpp: (JSC::Heap::protect): (JSC::Heap::unprotect): (JSC::Heap::heap): (JSC::Heap::collect): (JSC::typeName):
- runtime/Completion.cpp: (JSC::evaluate):
- runtime/DateConstructor.cpp: (JSC::constructDate): (JSC::dateParse): (JSC::dateUTC):
- runtime/DateInstance.h: (JSC::DateInstance::internalNumber):
- runtime/DatePrototype.cpp: (JSC::formatLocaleDate): (JSC::fillStructuresUsingTimeArgs): (JSC::fillStructuresUsingDateArgs): (JSC::dateProtoFuncToString): (JSC::dateProtoFuncToUTCString): (JSC::dateProtoFuncToDateString): (JSC::dateProtoFuncToTimeString): (JSC::dateProtoFuncToLocaleString): (JSC::dateProtoFuncToLocaleDateString): (JSC::dateProtoFuncToLocaleTimeString): (JSC::dateProtoFuncGetTime): (JSC::dateProtoFuncGetFullYear): (JSC::dateProtoFuncGetUTCFullYear): (JSC::dateProtoFuncToGMTString): (JSC::dateProtoFuncGetMonth): (JSC::dateProtoFuncGetUTCMonth): (JSC::dateProtoFuncGetDate): (JSC::dateProtoFuncGetUTCDate): (JSC::dateProtoFuncGetDay): (JSC::dateProtoFuncGetUTCDay): (JSC::dateProtoFuncGetHours): (JSC::dateProtoFuncGetUTCHours): (JSC::dateProtoFuncGetMinutes): (JSC::dateProtoFuncGetUTCMinutes): (JSC::dateProtoFuncGetSeconds): (JSC::dateProtoFuncGetUTCSeconds): (JSC::dateProtoFuncGetMilliSeconds): (JSC::dateProtoFuncGetUTCMilliseconds): (JSC::dateProtoFuncGetTimezoneOffset): (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetYear): (JSC::dateProtoFuncGetYear):
- runtime/ErrorConstructor.cpp: (JSC::constructError):
- runtime/ErrorPrototype.cpp: (JSC::errorProtoFuncToString):
- runtime/ExceptionHelpers.cpp: (JSC::createError): (JSC::createErrorMessage):
- runtime/FunctionConstructor.cpp: (JSC::constructFunction):
- runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncToString): (JSC::functionProtoFuncApply): (JSC::functionProtoFuncCall):
- runtime/GetterSetter.cpp: (JSC::GetterSetter::toObject):
- runtime/JSActivation.cpp: (JSC::JSActivation::getOwnPropertySlot):
- runtime/JSArray.cpp: (JSC::JSArray::put): (JSC::JSArray::mark): (JSC::JSArray::sort): (JSC::AVLTreeAbstractorForArrayCompare::compare_key_key): (JSC::JSArray::compactForSorting):
- runtime/JSByteArray.h: (JSC::JSByteArray::setIndex):
- runtime/JSCell.h: (JSC::asCell):
- runtime/JSFunction.cpp: (JSC::JSFunction::call): (JSC::JSFunction::construct):
- runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::lastInPrototypeChain):
- runtime/JSGlobalObjectFunctions.cpp: (JSC::encode): (JSC::decode): (JSC::globalFuncEval): (JSC::globalFuncParseInt): (JSC::globalFuncParseFloat): (JSC::globalFuncIsNaN): (JSC::globalFuncIsFinite): (JSC::globalFuncEscape): (JSC::globalFuncUnescape): (JSC::globalFuncJSCPrint):
- runtime/JSImmediate.cpp: (JSC::JSImmediate::toThisObject): (JSC::JSImmediate::toObject): (JSC::JSImmediate::prototype): (JSC::JSImmediate::toString):
- runtime/JSImmediate.h:
- runtime/JSObject.cpp: (JSC::JSObject::mark): (JSC::JSObject::put): (JSC::callDefaultValueFunction): (JSC::JSObject::getPrimitiveNumber): (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::lookupGetter): (JSC::JSObject::lookupSetter): (JSC::JSObject::hasInstance): (JSC::JSObject::toNumber): (JSC::JSObject::toString):
- runtime/JSObject.h: (JSC::JSObject::JSObject): (JSC::JSObject::inlineGetOwnPropertySlot): (JSC::JSObject::getOwnPropertySlotForWrite): (JSC::JSObject::getPropertySlot): (JSC::JSValuePtr::get):
- runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::create):
- runtime/JSString.cpp: (JSC::JSString::getOwnPropertySlot):
- runtime/JSValue.h:
- runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::mark):
- runtime/JSWrapperObject.h: (JSC::JSWrapperObject::setInternalValue):
- runtime/MathObject.cpp: (JSC::mathProtoFuncAbs): (JSC::mathProtoFuncACos): (JSC::mathProtoFuncASin): (JSC::mathProtoFuncATan): (JSC::mathProtoFuncATan2): (JSC::mathProtoFuncCeil): (JSC::mathProtoFuncCos): (JSC::mathProtoFuncExp): (JSC::mathProtoFuncFloor): (JSC::mathProtoFuncLog): (JSC::mathProtoFuncMax): (JSC::mathProtoFuncMin): (JSC::mathProtoFuncPow): (JSC::mathProtoFuncRound): (JSC::mathProtoFuncSin): (JSC::mathProtoFuncSqrt): (JSC::mathProtoFuncTan):
- runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor): (JSC::NativeErrorConstructor::construct):
- runtime/NumberConstructor.cpp: (JSC::constructWithNumberConstructor): (JSC::callNumberConstructor):
- runtime/NumberPrototype.cpp: (JSC::numberProtoFuncToString): (JSC::numberProtoFuncToLocaleString): (JSC::numberProtoFuncValueOf): (JSC::numberProtoFuncToFixed): (JSC::numberProtoFuncToExponential): (JSC::numberProtoFuncToPrecision):
- runtime/ObjectConstructor.cpp: (JSC::constructObject):
- runtime/ObjectPrototype.cpp: (JSC::objectProtoFuncValueOf): (JSC::objectProtoFuncHasOwnProperty): (JSC::objectProtoFuncIsPrototypeOf): (JSC::objectProtoFuncDefineGetter): (JSC::objectProtoFuncDefineSetter): (JSC::objectProtoFuncLookupGetter): (JSC::objectProtoFuncLookupSetter): (JSC::objectProtoFuncPropertyIsEnumerable): (JSC::objectProtoFuncToLocaleString): (JSC::objectProtoFuncToString):
- runtime/Operations.h: (JSC::JSValuePtr::equalSlowCaseInline): (JSC::JSValuePtr::strictEqual): (JSC::JSValuePtr::strictEqualSlowCaseInline):
- runtime/Protect.h: (JSC::gcProtect): (JSC::gcUnprotect):
- runtime/RegExpConstructor.cpp: (JSC::setRegExpConstructorInput): (JSC::setRegExpConstructorMultiline): (JSC::constructRegExp):
- runtime/RegExpObject.cpp: (JSC::setRegExpObjectLastIndex): (JSC::RegExpObject::match):
- runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncTest): (JSC::regExpProtoFuncExec): (JSC::regExpProtoFuncCompile): (JSC::regExpProtoFuncToString):
- runtime/StringConstructor.cpp: (JSC::stringFromCharCodeSlowCase): (JSC::stringFromCharCode): (JSC::constructWithStringConstructor): (JSC::callStringConstructor):
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): (JSC::stringProtoFuncToString): (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt): (JSC::stringProtoFuncConcat): (JSC::stringProtoFuncIndexOf): (JSC::stringProtoFuncLastIndexOf): (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch): (JSC::stringProtoFuncSlice): (JSC::stringProtoFuncSplit): (JSC::stringProtoFuncSubstr): (JSC::stringProtoFuncSubstring): (JSC::stringProtoFuncToLowerCase): (JSC::stringProtoFuncToUpperCase): (JSC::stringProtoFuncLocaleCompare): (JSC::stringProtoFuncBig): (JSC::stringProtoFuncSmall): (JSC::stringProtoFuncBlink): (JSC::stringProtoFuncBold): (JSC::stringProtoFuncFixed): (JSC::stringProtoFuncItalics): (JSC::stringProtoFuncStrike): (JSC::stringProtoFuncSub): (JSC::stringProtoFuncSup): (JSC::stringProtoFuncFontcolor): (JSC::stringProtoFuncFontsize): (JSC::stringProtoFuncAnchor): (JSC::stringProtoFuncLink):
- runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::getEnumerablePropertyNames): (JSC::Structure::createCachedPrototypeChain):
- runtime/Structure.h: (JSC::Structure::mark):
- runtime/StructureChain.cpp: (JSC::StructureChain::StructureChain):
JavaScriptGlue:
2009-01-19 Sam Weinig <sam@webkit.org>
Rubber-stamped by Gavin Barraclough.
Remove temporary operator-> from JSValuePtr.
- JSUtils.cpp: (KJSValueToJSObject): (KJSValueToCFTypeInternal):
- JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction): (JSValueWrapper::JSObjectMark):
- UserObjectImp.cpp: (UserObjectImp::getOwnPropertySlot):
WebCore:
2009-01-19 Sam Weinig <sam@webkit.org>
Rubber-stamped by Gavin Barraclough.
Remove temporary operator-> from JSValuePtr.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):
- bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toHTMLCanvasStyle): (WebCore::JSCanvasRenderingContext2D::setFillColor): (WebCore::JSCanvasRenderingContext2D::setStrokeColor): (WebCore::JSCanvasRenderingContext2D::strokeRect): (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::setShadow): (WebCore::JSCanvasRenderingContext2D::createPattern): (WebCore::JSCanvasRenderingContext2D::putImageData): (WebCore::JSCanvasRenderingContext2D::fillText): (WebCore::JSCanvasRenderingContext2D::strokeText):
- bindings/js/JSClipboardCustom.cpp: (WebCore::JSClipboard::clearData): (WebCore::JSClipboard::getData): (WebCore::JSClipboard::setData): (WebCore::JSClipboard::setDragImage):
- bindings/js/JSCustomPositionCallback.cpp: (WebCore::JSCustomPositionCallback::handleEvent):
- bindings/js/JSCustomPositionErrorCallback.cpp: (WebCore::JSCustomPositionErrorCallback::handleEvent):
- bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
- bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent): (WebCore::toVoidCallback):
- bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create): (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::hasItem): (WebCore::JSDOMApplicationCache::add): (WebCore::JSDOMApplicationCache::remove): (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDOMBinding.cpp: (WebCore::valueToStringWithNullCheck): (WebCore::valueToStringWithUndefinedOrNullCheck): (WebCore::reportException):
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener): (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
- bindings/js/JSDOMStringListCustom.cpp: (WebCore::JSDOMStringList::item):
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getOwnPropertySlot): (windowProtoFuncOpen): (WebCore::toJSDOMWindow):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::JSDOMWindow::postMessage): (WebCore::setTimeoutOrInterval): (WebCore::JSDOMWindow::clearTimeout): (WebCore::JSDOMWindow::clearInterval): (WebCore::JSDOMWindow::atob): (WebCore::JSDOMWindow::btoa): (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener): (WebCore::toDOMWindow):
- bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
- bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttribute): (WebCore::JSElement::setAttributeNS):
- bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSLazyEventListener::parseCode):
- bindings/js/JSEventTargetNodeCustom.cpp: (WebCore::JSEventTargetNode::addEventListener): (WebCore::JSEventTargetNode::removeEventListener):
- bindings/js/JSGeolocationCustom.cpp: (WebCore::createPositionOptions): (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::callHTMLCollection): (WebCore::JSHTMLCollection::canGetItemsForName): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem):
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open): (WebCore::writeHelper):
- bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength): (WebCore::JSHTMLOptionsCollection::add):
- bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove): (WebCore::selectIndexSetter):
- bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
- bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::JSInspectedObjectWrapper::wrap): (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
- bindings/js/JSInspectorCallbackWrapper.cpp: (WebCore::JSInspectorCallbackWrapper::wrap):
- bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate):
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::replace): (WebCore::JSLocation::assign):
- bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::mark):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::startConversation): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::mark): (WebCore::JSNodeFilterCondition::acceptNode):
- bindings/js/JSNodeFilterCondition.h:
- bindings/js/JSNodeFilterCustom.cpp: (WebCore::toNodeFilter):
- bindings/js/JSNodeListCustom.cpp: (WebCore::callNodeList):
- bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
- bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::asWrapper): (WebCore::JSQuarantinedObjectWrapper::construct):
- bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
- bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
- bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::convertToSpecifiedUnits):
- bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::translate): (WebCore::JSSVGMatrix::scale): (WebCore::JSSVGMatrix::scaleNonUniform): (WebCore::JSSVGMatrix::rotate): (WebCore::JSSVGMatrix::rotateFromVector): (WebCore::JSSVGMatrix::skewX): (WebCore::JSSVGMatrix::skewY):
- bindings/js/JSSVGPathSegListCustom.cpp: (WebCore::JSSVGPathSegList::getItem): (WebCore::JSSVGPathSegList::insertItemBefore): (WebCore::JSSVGPathSegList::replaceItem): (WebCore::JSSVGPathSegList::removeItem):
- bindings/js/JSSVGPointListCustom.cpp: (WebCore::JSSVGPointList::getItem): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::removeItem):
- bindings/js/JSSVGTransformListCustom.cpp: (WebCore::JSSVGTransformList::getItem): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::removeItem):
- bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::deleteProperty): (WebCore::JSStorage::customPut):
- bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::constructWebKitCSSMatrix):
- bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
- bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open): (WebCore::JSXMLHttpRequest::setRequestHeader): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::getResponseHeader): (WebCore::JSXMLHttpRequest::overrideMimeType): (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/js/JSXSLTProcessorCustom.cpp: (WebCore::JSXSLTProcessor::importStylesheet): (WebCore::JSXSLTProcessor::transformToFragment): (WebCore::JSXSLTProcessor::transformToDocument): (WebCore::JSXSLTProcessor::setParameter): (WebCore::JSXSLTProcessor::getParameter): (WebCore::JSXSLTProcessor::removeParameter):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext):
- bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::initialize):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::createScriptObjectForPluginElement):
- bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::getString): (WebCore::ScriptValue::isNull): (WebCore::ScriptValue::isUndefined):
- bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_HasMethod): (_NPN_Construct):
- bridge/c/c_utility.cpp: (JSC::Bindings::convertValueToNPVariant):
- bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
- bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::convertValueToJObject):
- bridge/jni/jni_runtime.cpp: (JavaField::dispatchValueFromInstance): (JavaField::valueFromInstance): (JavaField::dispatchSetValueToInstance): (JavaField::setValueToInstance):
- bridge/jni/jni_utility.cpp: (JSC::Bindings::convertArrayInstanceToJavaArray): (JSC::Bindings::convertValueToJValue):
- bridge/objc/objc_runtime.mm: (JSC::Bindings::callObjCFallbackObject):
- bridge/objc/objc_utility.mm: (JSC::Bindings::convertValueToObjcValue):
- bridge/runtime_method.cpp: (JSC::callRuntimeMethod):
- bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::getOwnPropertySlot): (JSC::callRuntimeConstructor):
WebKit/mac:
2009-01-19 Sam Weinig <sam@webkit.org>
Rubber-stamped by Gavin Barraclough.
Remove temporary operator-> from JSValuePtr.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::hasMethod): (WebKit::NetscapePluginInstanceProxy::marshalValue):
- WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
- WebView/WebView.mm: (aeDescFromJSValue):
WebKit/win:
2009-01-19 Sam Weinig <sam@webkit.org>
Rubber-stamped by Gavin Barraclough.
Remove temporary operator-> from JSValuePtr.
- WebScriptCallFrame.cpp: (WebScriptCallFrame::jsValueToString):
- WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):
WebKit/wx:
2009-01-19 Sam Weinig <sam@webkit.org>
Rubber-stamped by Gavin Barraclough.
Remove temporary operator-> from JSValuePtr.
- WebFrame.cpp: (wxWebFrame::RunScript):
- 4:33 PM Changeset in webkit [40045] by
-
- 4 edits in trunk/WebKit/mac
2009-01-19 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Make Evaluate an asynchronous method that has a reply method.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate):
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs:
- 4:27 PM Changeset in webkit [40044] by
-
- 2 edits in trunk/WebCore
2009-01-20 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=23419
removal of FramePrivate.h breaks GTK+'s make dist
- GNUmakefile.am: No longer mention FramePrivate.h in our build, since it was removed.
- 4:16 PM Changeset in webkit [40043] by
-
- 2 edits in trunk/WebCore
2009-01-20 Alexander V. Butenko <alex@digiqube.com>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=23116
[GTK] Fix crash due a callback called from GIO after the
destruction of the ResourceHandle
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::cancel): Only call didFinishLoading if 'client' is set, otherwise cancelling a load could lead to a crash.
- 3:33 PM Changeset in webkit [40042] by
-
- 5 edits in trunk
2009-01-19 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 23409: REGRESSION: RegExp 'replace()' function improperly processes '$$'
<https://bugs.webkit.org/show_bug.cgi?id=23409>
<rdar://problem/6505723>
Test: fast/js/string-replace-3.html
- runtime/StringPrototype.cpp: (JSC::substituteBackreferences): Remove code that adds an extra $ -- not sure how this ever worked.
LayoutTests:
2009-01-19 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 23409: REGRESSION: RegExp 'replace()' function improperly processes '$$'
<https://bugs.webkit.org/show_bug.cgi?id=23409>
<rdar://problem/6505723>
- fast/js/resources/string-replace-3.js:
- fast/js/string-replace-3-expected.txt:
- 3:22 PM Changeset in webkit [40041] by
-
- 1 edit in trunk/WebCore/ChangeLog
ChangeLog typo fix.
- 3:20 PM Changeset in webkit [40040] by
-
- 2 edits in trunk/WebCore
2009-01-19 Simon Fraser <Simon Fraser>
Build fix: remove duplicate entries in the Xcode project, and
sort the project with ort-Xcode-project-file .
- WebCore.xcodeproj/project.pbxproj:
- 2:23 PM Changeset in webkit [40039] by
-
- 16 edits2 adds in trunk
2009-01-19 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Support animations and transitions of shorthand properties by creating
PropertyWrappers that simply wrap a vector of atomci wrappers, and implement
equal() and blend(). Build that collection of shorthand wrappers using the
shorthand map that CSSMutableStyleDeclaration already has. Skip comparing these
shorthand wrappers during 'all' transitions.
- 2:16 PM Changeset in webkit [40038] by
-
- 1 edit1 add in trunk/WebCore
Actually add the new header.
- 2:09 PM Changeset in webkit [40037] by
-
- 15 edits in trunk/WebCore
2009-01-19 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Provide a generic class to handle the pattern of task callbacks across worker/parent threads. It
only works for methods that need 6 parameters but similar classes could be added as needed for
other numbers of parameters.
Add addMessage and resourceRetrievedByXMLHttpRequest to ScriptExecutionContext.
Use these methods and others to remove document() from XMLHttpRequest in a few more places.
No observable change in behavior, so no test.
- 1:43 PM Changeset in webkit [40036] by
-
- 2 edits in trunk/WebKit/mac
2009-01-19 Brady Eidson <beidson@apple.com>
Rubberstamped by Tim Hatcher
Fix long standing typo.
- History/WebBackForwardList.h:
- 12:55 PM Changeset in webkit [40035] by
-
- 2 edits in trunk/WebKitSite
Add links to some recommended Visual Studio hotfixes
Reviewed by Dave Hyatt.
- building/tools.html:
- 12:51 PM Changeset in webkit [40034] by
-
- 2 edits in trunk/LayoutTests
Update test results for https://bugs.webkit.org/show_bug.cgi?id=23417.
- fast/dom/Window/window-properties-expected.txt:
- 12:31 PM Changeset in webkit [40033] by
-
- 7 edits2 adds in trunk
Bug 23422: AX: AXLinks should expose access key information
https://bugs.webkit.org/show_bug.cgi?id=23422
- 11:15 AM Changeset in webkit [40032] by
-
- 14 edits4 adds in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=23417
Implement application cache obsolete state
Test: http/tests/appcache/remove-cache.html
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::mark):
- dom/EventNames.h:
- loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::Status): (WebCore::DOMApplicationCache::setOnobsolete): (WebCore::DOMApplicationCache::onobsolete):
- loader/appcache/DOMApplicationCache.idl: Added "obsolete" event and status.
- loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::savedNewestCachePointer): Removed, there is no longer any need to track what the newest cache was during teardown. (WebCore::ApplicationCacheGroup::updateStatus): Renamed Status to UpdateStatus, reducing confusion with cache group lifecycle status. (WebCore::ApplicationCacheGroup::m_isObsolete): Added an obsolete state flag.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): Initialize m_isObsolete. (WebCore::ApplicationCacheGroup::cacheForMainRequest): Assert that the returned cache does not belong to an obsolete group. (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): Ditto. (WebCore::ApplicationCacheGroup::disassociateDocumentLoader): Disassociation can now happen via a JS swapCache() call, not only when the loader is destroyed. (WebCore::ApplicationCacheGroup::cacheDestroyed): Don't track m_savedNewestCachePointer. (WebCore::ApplicationCacheGroup::setNewestCache): Remove old newest cache from storage is a caller responsibility, because this method is also used when loading caches from disk. (WebCore::ApplicationCacheGroup::makeObsolete): Added. Mark the cache group as obsolete, and inform cache storage, so that it could be removed. (WebCore::ApplicationCacheGroup::didFailToLoadManifest): Removed, as all this method did was call cacheUpdateFailed(). (WebCore::ApplicationCacheGroup::didReceiveResponse): Added a FIXME about correct failure handing. (WebCore::ApplicationCacheGroup::didFail): Ditto. (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Call a new manifestNotFound() method for 404 and 410 responses. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Call cacheUpdateFailed() directly, instead of the removed didFailToLoadManifest(). (WebCore::ApplicationCacheGroup::manifestNotFound): Implement "remove a cache" algorithm. (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Remove superceded cache from storage after update successfully finishes (moved from setNewestCache()). (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the group using an explicitly passed pointer, without the need to save it during teardown.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::~DocumentLoader): Call the general ApplicationCacheGroup::disassociateDocumentLoader() method.
- loader/appcache/ApplicationCacheStorage.h: Added a cacheGroupMadeObsolete() method, updated some comments.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupForURL): Assert that iterated caches are not obsolete. (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto. (WebCore::ApplicationCacheStorage::cacheGroupDestroyed): Don't do anything for obsolete groups, as they cannot be in storage. (WebCore::ApplicationCacheStorage::cacheGroupMadeObsolete): Remove the cache group from storage completely, so that a new one could replace it, if necessary. (WebCore::ApplicationCacheStorage::storeNewestCache): Added assertions. (WebCore::ApplicationCacheStorage::remove): Remove cache group if its newest cache is removed.
- loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::status): Added support for OBSOLETE state. (WebCore::DOMApplicationCache::swapCache): Disassociate document loader from cache if the application was removed server-side. (WebCore::DOMApplicationCache::callObsoleteListener): Added support for obsolete event.
- loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::Status): (WebCore::DOMApplicationCache::setOnobsolete): (WebCore::DOMApplicationCache::onobsolete): Added support for OBSOLETE state and obsolete event.
- loader/appcache/DOMApplicationCache.idl: Ditto.
- 11:05 AM Changeset in webkit [40031] by
-
- 2 edits in trunk/WebCore
2009-01-19 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Allow plug-in views to return an instance directly.
- bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::createScriptInstanceForWidget):
- 10:18 AM Changeset in webkit [40030] by
-
- 3 edits2 adds in trunk
Bug 23399: AX: some buttons don't expose AXPress as an action
https://bugs.webkit.org/show_bug.cgi?id=23399
- 8:28 AM Changeset in webkit [40029] by
-
- 5 edits in trunk
Windows build fix
WebCore:
Windows build fix
- WebCore.vcproj/WebCore.vcproj: Copy headers from page/animation into $WebKitOutputDir so that WebKit can access them.
- html/HTMLBaseFontElement.cpp: Touched this file to cause a rebuild and header copy.
WebKit/win:
Windows build fix
- DOMCoreClasses.cpp: Replaced "using namespace WebCore" with individual using directives for each type we need from that namespace, to avoid conflicts between DOMObject and WebCore::DOMObject. (DOMElement::font): Added a now-needed WebCore::.
- 7:40 AM Changeset in webkit [40028] by
-
- 2 edits in trunk/WebCore
2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon Hausmann.
http://www.qtsoftware.com/developer/task-tracker/index_html?id=211228&method=entry
[Qt] Show focus rect when a button gets the focus for the first time.
This is important at least for Windows style.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::applyTheme):
- 5:39 AM Changeset in webkit [40027] by
-
- 4 edits in trunk/WebKit/qt
2009-01-19 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Fix calling of onkeypress event handlers on input elements when pressing enter
and other text insertion commands in the Qt port.
Similar to the win and mac ports don't execute text inserting editor
commands on RawKeyDown but continue processing the event first in
WebCore, i.e. also get a keypress event sent. If unhandled it will
come back to EditorClientQt::handleKeyboardEvent later and we execute
it then.
This also fixes search by pressing enter on www.trafikanten.no.
- 5:00 AM Changeset in webkit [40026] by
-
- 2 edits in trunk/WebCore
2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com>
[Qt] Build fix after r39971.
- platform/qt/LoggingQt.cpp: (WebCore::InitializeLoggingChannelsIfNecessary):
- 12:45 AM Changeset in webkit [40025] by
-
- 2 edits in trunk/WebKit/mac
Fix the build!
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::demarshalValue):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):
