Timeline
Apr 21, 2009:
- 10:42 PM Changeset in webkit [42744] by
-
- 2 edits in trunk/JavaScriptCore
Build fix
- 10:36 PM Changeset in webkit [42743] by
-
- 2 edits in trunk/JavaScriptCore
Improve String.replace performance slightly
Reviewed by Maciej Stachowiak
Apply our vm reentry caching logic to String.replace with global
regexes.
- 10:22 PM Changeset in webkit [42742] by
-
- 2 edits in trunk/LayoutTests
- updated another result with action element information
- fast/encoding/mailto-always-utf-8-expected.txt:
- 10:05 PM Changeset in webkit [42741] by
-
- 5 edits2 adds in trunk
WebKit/mac:
Reviewed by Jon Honeycutt.
- Mac part of fixing for <rdar://problem/6755137> Action dictionary for policy decision is missing keys when full-page zoom is used
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary): Use absoluteLocation() instead of pageX() and pageY(), which are adjusted for zoom.
WebKit/win:
Reviewed by Jon Honeycutt.
- Windows part of fixing <rdar://problem/6755137> Action dictionary for policy decision is missing keys when full-page zoom is used
- WebActionPropertyBag.cpp: (WebActionPropertyBag::Read): Use absoluteLocation() instead of clientX() and clientY(), which are adjusted for zoom.
LayoutTests:
- test for <rdar://problem/6755137> Action dictionary for policy decision is missing keys when full-page zoom is used
- fast/loader/policy-delegate-action-hit-test-zoomed-expected.txt: Added.
- fast/loader/policy-delegate-action-hit-test-zoomed.html: Added.
- 10:04 PM Changeset in webkit [42740] by
-
- 8 edits in trunk
WebKit/win:
Reviewed by Jon Honeycutt.
- implement DOMNode::nodeName()
- DOMCoreClasses.cpp: (DOMNode::nodeName):
WebKitTools:
Reviewed by Jon Honeycutt.
- dump the node in the element dictionary in the action information passed to the policy delegate
- DumpRenderTree/mac/PolicyDelegate.mm: (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
- DumpRenderTree/win/PolicyDelegate.cpp: (dumpPath): (PolicyDelegate::decidePolicyForNavigationAction):
LayoutTests:
Reviewed by Jon Honeycutt.
- updated result that shows the node in the element dictionary in the action information passed to the policy delegate
- http/tests/security/feed-urls-from-remote-expected.txt:
- 9:20 PM Changeset in webkit [42739] by
-
- 2 edits in trunk/WebCore
2009-04-21 John Abd-El-Malek <jam@google.com>
Reviewed by Dimitri Glazkov.
Add a method to purge the Chromium plugin list cache.
https://bugs.webkit.org/show_bug.cgi?id=25318
- plugins/chromium/PluginDataChromium.cpp: (WebCore::resetChromiumPluginCache):
- 9:03 PM Changeset in webkit [42738] by
-
- 12 edits4 adds in trunk
Fix <https://bugs.webkit.org/show_bug.cgi?id=25164> / <rdar://problem/6786319>.
Reviewed by Darin Adler.
We need to ensure that XMLTokenizer sets the current DocLoader before calling in to
any libxml2 methods that may trigger a load. The presence of a DocLoader indicates
that the load was originated by WebCore's use of libxml2 and that we should enforce
the same-origin policy on it. XMLTokenizer::initializeParserContext,
XMLTokenizer::doWrite and XMLTokenizer::doEnd were three methods that were not setting
the current DocLoader when they should have.
The XMLTokenizerScope class is introduced to simplify the pattern of saving, setting and
restoring the current DocLoader and libxml2 error handlers. The DocLoader and error handlers
are saved and set when the scope is allocated, and restored to their previous values when
the scope is exited.
Test: http/tests/security/xss-DENIED-xml-external-entity.xhtml
- GNUmakefile.am:
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/XMLTokenizer.cpp:
- dom/XMLTokenizer.h:
- dom/XMLTokenizerLibxml2.cpp:
(WebCore::matchFunc):
(WebCore::shouldAllowExternalLoad):
(WebCore::openFunc):
(WebCore::XMLTokenizer::doWrite):
(WebCore::XMLTokenizer::initializeParserContext):
(WebCore::XMLTokenizer::doEnd):
(WebCore::xmlDocPtrForString):
- dom/XMLTokenizerScope.cpp:
(WebCore::XMLTokenizerScope::XMLTokenizerScope):
(WebCore::XMLTokenizerScope::~XMLTokenizerScope):
- dom/XMLTokenizerScope.h:
- xml/XSLStyleSheet.cpp:
(WebCore::XSLStyleSheet::parseString):
- xml/XSLTProcessor.cpp:
- 8:42 PM Changeset in webkit [42737] by
-
- 6 edits in trunk
WebCore:
2009-04-21 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/5874009>
Add port 3659 (apple-sasl / PasswordServer) to the list of blocked ports.
- platform/network/ResourceHandle.cpp: (WebCore::portAllowed):
LayoutTests:
2009-04-21 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Update test and results for <rdar://problem/5874009>
Add port 3659 (apple-sasl / PasswordServer) to the list of blocked ports.
- platform/mac-tiger/security/block-test-expected.txt:
- platform/mac/security/block-test-expected.txt:
- security/block-test.html:
- 7:18 PM Changeset in webkit [42736] by
-
- 3 edits in trunk/LayoutTests
Corrected a mistake in my last ChangeLog entry and updated some expected results.
- 6:53 PM Changeset in webkit [42735] by
-
- 3 edits2 adds in trunk
WebCore:
2009-04-21 Justin Garcia <justin.garcia@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=25320
Crash when changing block styles in a root that contains no visible content (but contains nodes with renderers)
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): If the enclosing block is the root editable element and it contains no visible content, create a new block but don't try and move content into it, since there's nothing for moveParagraphs to move.
LayoutTests:
2009-04-21 Justin Garcia <justin.garcia@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=25320
Crash when changing block styles in a root that contains no visible content (but contains nodes with renderers)
- editing/execCommand/25320-expected.txt: Added.
- editing/execCommand/25320.html: Added.
- platform/mac/fast/forms/caret-rtl-expected.checksum: Replaced.
- platform/mac/fast/forms/caret-rtl-expected.txt: Replaced.
- 5:18 PM Changeset in webkit [42734] by
-
- 4 edits in trunk/JavaScriptCore
2009-04-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich and Oliver Hunt.
Re-Fixed <rdar://problem/6406045> REGRESSION: Stack overflow on PowerPC on
fast/workers/use-machine-stack.html (22531)
SunSpider reports no change.
Use a larger recursion limit on the main thread (because we can, and
there's some evidence that it may improve compatibility), and a smaller
recursion limit on secondary threads (because they tend to have smaller
stacks).
- interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::prepareForRepeatCall):
- interpreter/Interpreter.h: (JSC::): Ditto. I wrote the recursion test slightly funny, so that the common case remains a simple compare to constant.
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString): (JSC::arrayProtoFuncToLocaleString): (JSC::arrayProtoFuncJoin): Conservatively, set the array recursion limits to the lower, secondary thread limit. We can do something fancier if compatibility moves us, but this seems sufficient for now.
- 5:11 PM Changeset in webkit [42733] by
-
- 2 edits in trunk/WebKit/win
2009-04-21 Steve Falkenburg <sfalken@apple.com>
Minor clean-ups to WebKitCreateInstance change.
Reviewed by Jon Honeycutt.
- WebKitCOMAPI.cpp: (classFactory): (WebKitCreateInstance):
- 4:30 PM Changeset in webkit [42732] by
-
- 15 edits7 copies in trunk
WebCore:
2009-04-21 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 25162: REGRESSION (r41176-r41242): Drag-selection above/below the line does not select to beginning/end
https://bugs.webkit.org/show_bug.cgi?id=25162
rdar://problem/6764354
- page/Settings.cpp: (WebCore::Settings::Settings): Initialize editing behavior to Mac-style for PLATFORM(MAC). Later we may want to change this default to encompass other versions running on Mac.
- page/Settings.h: Added EditingBehavior, setEditingBehavior, editingBehavior, and m_editingBehavior. Also moved m_maximumDecodedImageSize out of the middle of all the bit fields.
- platform/graphics/IntPoint.h: Added a constructor to turn an IntSize into an IntPoint. I'm not sure the distinction here is serving us well at the moment. When converting from global to local coordinates you want to do IntPoint - IntPoint and have the result be another IntPoint, not an IntSize. And so on.
- rendering/RenderBlock.cpp: (WebCore::positionForPointRespectingEditingBoundaries): Changed to use pointers more and separate coordinates less. (WebCore::RenderBlock::positionForPointWithInlineChildren): Turned into a member function. Added separate cases to support the Mac and Windows behavior. (WebCore::RenderBlock::positionForPoint): Updated for the change above. Also moved the computation of pointInContents closer to the place it's used.
- rendering/RenderBlock.h: Updated for the new private member function.
LayoutTests:
2009-04-21 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 25162: REGRESSION (r41176-r41242): Drag-selection above/below the line does not select to beginning/end
https://bugs.webkit.org/show_bug.cgi?id=25162
rdar://problem/6764354
- editing/selection/resources/click-in-margins-inside-editable-div.js: Updated to expect different results on the Mac.
- editing/selection/resources/click-in-padding-with-multiple-line-boxes.js: Ditto.
- fast/css-generated-content/positioned-background-hit-test-crash.html: Clear the selection at the end of the test so the result won't include a caret.
- platform/mac/editing/selection/click-in-margins-inside-editable-div-expected.txt:
- platform/mac/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Copied from LayoutTests/editing/selection. Then changed to expect the different Mac results.
- platform/mac/editing/selection/select-from-textfield-outwards-expected.checksum:
- platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
- platform/mac/editing/selection/select-from-textfield-outwards-expected.txt: Changed to expect the different Mac results.
- platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.txt: Changed to expect no caret.
- platform/win/editing/selection/click-in-margins-inside-editable-div-expected.txt:
- platform/win/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Copied from editing/selection.
- platform/win/editing/selection/select-from-textfield-outwards-expected.checksum:
- platform/win/editing/selection/select-from-textfield-outwards-expected.png:
- platform/win/editing/selection/select-from-textfield-outwards-expected.txt: Copied from platform/mac/editing/selection.
- 2:58 PM Changeset in webkit [42731] by
-
- 2 edits in trunk/WebKit
Update StringsNotToBeLocalized.txt for recent changes
Rubber-stamped by John Sullivan.
- StringsNotToBeLocalized.txt:
- 2:35 PM Changeset in webkit [42730] by
-
- 6 edits in trunk/WebKit/mac
2009-04-21 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler and Kevin Decker.
WebKit side of <rdar://problem/6781642>.
When we call resize with an actual changed size, block until the plug-in host is done.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::resize):
- Plugins/Hosted/WebHostedNetscapePluginView.h:
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView updateAndSetWindow]):
- Plugins/Hosted/WebKitPluginHost.defs:
- 2:10 PM Changeset in webkit [42729] by
-
- 3 edits in trunk/WebKitTools
Windows build fix after r42726
- DumpRenderTree/win/DumpRenderTree.cpp: Touched to force a rebuild.
- DumpRenderTree/win/DumpRenderTree.vcproj: Delete any pre-r42726 manifest files during the pre-build event.
- 1:52 PM Changeset in webkit [42728] by
-
- 2 edits in trunk/WebKit
Another attempt to fix the Windows and QT builds.
- 1:48 PM Changeset in webkit [42727] by
-
- 2 edits in trunk/WebKit
Attempt to fix the Windows and QT builds.
- 1:42 PM Changeset in webkit [42726] by
-
- 10 edits2 adds in trunk
WebKit/win:
2009-04-21 Steve Falkenburg <sfalken@apple.com>
Add registry-free CoCreateInstance API for WebKit clients: WebKitCreateInstance.
Manifest-based registry-free COM continues to work for clients that have embedded
manifests with isolated COM information.
Reviewed by Adam Roben.
- WebKit.vcproj/WebKit.def: Added WebKitCreateInstance.
- WebKit.vcproj/WebKit.vcproj: Link against rpcrt4.dll for UUID hashing.
- WebKit.vcproj/WebKit_debug.def: Added WebKitCreateInstance.
- WebKitCOMAPI.cpp: Added. (CLSIDHash::hash): (CLSIDHash::equal): (CLSIDHashTraits::constructDeletedValue): (CLSIDHashTraits::isDeletedValue): (classFactory): (WebKitCreateInstance): New API.
- WebKitCOMAPI.h: Added.
WebKitTools:
2009-04-21 Steve Falkenburg <sfalken@apple.com>
Use new WebKitCreateInstance API instead of CoCreateInstance
or COMPtr's createInstance to instantiate WebKit COM objects.
Reviewed by Adam Roben.
- DumpRenderTree/win/DumpRenderTree.cpp: (initialize): (runTest): (createWebViewAndOffscreenWindow): (main):
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/GCControllerWin.cpp: (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::keepWebHistory): (LayoutTestController::webHistoryItemCount): (LayoutTestController::setIconDatabaseEnabled):
- DumpRenderTree/win/WorkQueueItemWin.cpp: (LoadItem::invoke):
- 1:21 PM Changeset in webkit [42725] by
-
- 24 edits in trunk
Change pending unload and beforeunload counts to store the listeners in a single data structure that can be quickly iterated for dispatch.
WebCore:
2009-04-17 Timothy Hatcher <timothy@apple.com>
Change pending unload and beforeunload counts to store the listeners
in a single data structure that can be quickly iterated for dispatch.
<rdar://problem/6383352&6383379&6383940>
Reviewed by Darin Adler.
- WebCore.base.exp: Change what symbols are exported.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Remove count updating code and move an if inside a block already checking m_frame->document().
- page/Chrome.cpp: Remove disableSuddenTermination/enableSuddenTermination.
- page/Chrome.h: Ditto.
- page/ChromeClient.h: Ditto.
- page/DOMWindow.cpp: (WebCore::pendingUnloadEventListenerMap): Create a static map. (WebCore::pendingBeforeUnloadEventListenerMap): Ditto. (WebCore::addPendingEventListener): Add the event listener to the map. (WebCore::removePendingEventListener): Remove the event listener from the map. (WebCore::removePendingEventListeners): Remove all listeners for the window. (WebCore::dispatchWindowEventToListeners): Dispatch the event to the given listeners. (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents): Send the beforeunload event. (WebCore::DOMWindow::pendingUnloadEventListeners): Return a count of pending listeners. (WebCore::DOMWindow::dispatchAllPendingUnloadEvents): Send the unload event. (WebCore::DOMWindow::~DOMWindow): Remove the window from both event listener maps. (WebCore::DOMWindow::addEventListener): Call addPendingEventListener when needed. (WebCore::DOMWindow::removeEventListener): Call removePendingEventListener when needed. (WebCore::DOMWindow::removeAllEventListeners): Call removePendingEventListeners. (WebCore::DOMWindow::removeInlineEventListenerForType): Call removePendingEventListener when needed.
- page/DOMWindow.h: (WebCore::DOMWindow::frame): Changed to be const.
- page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): Remove count tracking code.
- page/EventHandler.h: Ditto.
- page/Page.cpp: (WebCore::Page::Page): Ditto.
- page/Page.h: Ditto.
WebKit/mac:
2009-04-17 Timothy Hatcher <timothy@apple.com>
Change how sudden termination works with WebView teardown.
<rdar://problem/6383352&6383379&6383940>
Reviewed by Darin Adler.
- WebCoreSupport/WebChromeClient.h: Remove disableSuddenTermination/enableSuddenTermination.
- WebCoreSupport/WebChromeClient.mm: Ditto.
- WebView/WebFrame.mm: (-[WebFrame _pendingFrameUnloadEventCount]): Ask the DOMWindow.
- WebView/WebView.mm: (+[WebView canCloseAllWebViews]): Call DOMWindow::dispatchAllPendingBeforeUnloadEvents. (+[WebView closeAllWebViews]): Call DOMWindow::dispatchAllPendingUnloadEvents and call close on all the WebViews. (-[WebView _closeWithFastTeardown]): Remove code for unload event dispatch. (-[WebView _close]): Correct a comment. (+[WebView _applicationWillTerminate]): Call closeAllWebViews.
- WebView/WebViewPrivate.h: Add canCloseAllWebViews and closeAllWebViews.
- 12:58 PM Changeset in webkit [42724] by
-
- 4 edits in trunk
2009-04-21 Geoffrey Garen <ggaren@apple.com>
Rubber-stamped by Adam Roben.
Disabled one more Mozilla JS test because it fails intermittently on Windows.
(See https://bugs.webkit.org/show_bug.cgi?id=25160.)
- tests/mozilla/expected.html:
WebKitTools:
2009-04-21 Geoffrey Garen <ggaren@apple.com>
Rubber-stamped by Adam Roben.
Disabled one more Mozilla JS test because it fails intermittently on Windows.
(See https://bugs.webkit.org/show_bug.cgi?id=25160.)
- Scripts/run-javascriptcore-tests:
- 12:38 PM Changeset in webkit [42723] by
-
- 14 edits1 move in trunk/LayoutTests
2009-04-21 Darin Adler <Darin Adler>
Reviewed by Adele Peterson.
Fix some tests that are depending on Mac vs. Windows selection quirks accidentally.
Added failing tests to the skipped list for SnowLeopard.
- editing/resources/select-all-iframe-src.html: Moved.
- editing/selection/resources/select-all-iframe-src.html: Moved from editing/resources/select-all-iframe-src.html, since this is used by a test in the selection directory. Changed mouse coordinates to be farther to the right so we don't depend on the rule for what's selected when you click below text on the last line.
- editing/selection/select-all-iframe.html: Updated for new location of file above.
- fast/events/standalone-image-drag-to-editable.html: Changed mouse coordinates to be farther to the right so we don't depend on the rule for what's selected when you click below text on the last line.
- platform/mac-snowleopard/Skipped: Added some tests to the Skipped list.
- svg/custom/pointer-events-path.svg: Clear the selection at the end of the test so it's not in the test results. Also removed unneeded use of the layout test controller.
- platform/mac/editing/selection/select-all-iframe-expected.checksum: Generated new results.
- platform/mac/editing/selection/select-all-iframe-expected.png: Ditto.
- platform/mac/editing/selection/select-all-iframe-expected.txt: Ditto.
- platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum: Ditto.
- platform/mac/fast/events/standalone-image-drag-to-editable-expected.png: Ditto.
- platform/mac/fast/events/standalone-image-drag-to-editable-expected.txt: Ditto.
- platform/mac/svg/custom/pointer-events-path-expected.checksum: Ditto.
- platform/mac/svg/custom/pointer-events-path-expected.png: Ditto.
- platform/mac/svg/custom/pointer-events-path-expected.txt: Ditto.
- 12:20 PM Changeset in webkit [42722] by
-
- 8 edits4 adds in trunk
WebCore:
2009-04-21 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=19644
Text copied with Select All pastes with a indent but shouldn't
<rdar://problem/6102483>
Pasting the content of an HTML message in Mail causes addition nested <div> elements to be added
To improve selectall/copy/paste fidelity of certain pages, we began wrapping copied content with
a div that held properties and attributes from the fully selected body. To fix the above issues,
only do this if if the body has certain properties or attributes. We'll begin adding to this list as
necessary. For now it's just background colors and images. Tested copy/paste of nytimes, wired,
arstechnica, and several others.
Massive nesting can still happen, it will just be much less common.
- editing/markup.cpp: (WebCore::createMarkup):
LayoutTests:
2009-04-21 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=19644
Text copied with Select All pastes with a indent but shouldn't
<rdar://problem/6102483>
Pasting the content of an HTML message in Mail causes addition nested <div> elements to be added
- editing/pasteboard/19644-1-expected.txt: Added.
- editing/pasteboard/19644-1.html: Added.
- editing/pasteboard/19644-2-expected.txt: Added.
- editing/pasteboard/19644-2.html: Added.
- platform/mac/editing/inserting/insert-3907422-fix-expected.txt:
- platform/mac/editing/pasteboard/paste-text-015-expected.checksum:
- platform/mac/editing/pasteboard/paste-text-015-expected.png:
- platform/mac/editing/pasteboard/paste-text-015-expected.txt:
- platform/mac/editing/style/font-family-with-space-expected.txt:
- 11:34 AM Changeset in webkit [42721] by
-
- 9 edits in trunk/WebCore
2009-04-16 Peter Kasting <pkasting@google.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=25250
Allow platforms to snap the scroll thumb back to the drag origin
during a drag. Implement functions for Safari/Win and Chromium/Win
to do this snapping at distances approximating the native ones.
- platform/Scrollbar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::scroll): (WebCore::Scrollbar::moveThumb): (WebCore::Scrollbar::setCurrentPos): (WebCore::Scrollbar::mouseMoved): (WebCore::Scrollbar::mouseDown):
- platform/Scrollbar.h:
- platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::shouldSnapBackToDragOrigin):
- platform/chromium/ScrollbarThemeChromium.h:
- platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromium::shouldSnapBackToDragOrigin):
- platform/chromium/ScrollbarThemeChromiumWin.cpp: (WebCore::ScrollbarThemeChromium::shouldSnapBackToDragOrigin):
- platform/win/ScrollbarThemeWin.cpp: (WebCore::ScrollbarThemeWin::shouldCenterOnThumb): (WebCore::ScrollbarThemeWin::shouldSnapBackToDragOrigin):
- platform/win/ScrollbarThemeWin.h:
- 11:15 AM Changeset in webkit [42720] by
-
- 2 edits in trunk/WebCore
Windows build fix
- bindings/js/JSLazyEventListener.cpp: (WebCore::eventParameterName): Remove unreachable code when SVG is enabled.
- 11:09 AM Changeset in webkit [42719] by
-
- 3 edits in trunk/WebKitTools
Fix running run-safari and run-webkit-tests from the paths recommended on webkit.org
Reviewed by Steve Falkenburg and Sam Weinig.
- Scripts/run-webkit-nightly.cmd: Moved quotes from variable definitions to variable uses. Otherwise cmd.exe can get confused about the quoting.
- Scripts/run-webkit-tests: Changed to use an absolute path to execAppWithEnv so that run-webkit-tests will work when run from outside the source tree.
- 11:09 AM Changeset in webkit [42718] by
-
- 8 edits in trunk
Rename JavaScriptCore_debug.dll to JavaScriptCore.dll in the Debug configuration
Rename JavaScriptCore_debug.dll to JavaScriptCore.dll in the Debug
configuration
This matches the naming scheme for WebKit.dll, and will be necessary
once Safari links against JavaScriptCore.dll. This change also causes
run-safari not to fail (because the launcher printed by FindSafari was
always looking for JavaScriptCore.dll, never
JavaScriptCore_debug.dll).
Part of Bug 25305: can't run safari or drt on windows
<https://bugs.webkit.org/show_bug.cgi?id=25305>
Reviewed by Steve Falkenburg and Sam Weinig.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- JavaScriptCore.vcproj/testapi/testapi.vcproj: Use $(WebKitDLLConfigSuffix) for naming JavaScriptCore.{dll,lib}.
WebKit/win:
Rename JavaScriptCore_debug.dll to JavaScriptCore.dll in the Debug
configuration
This matches the naming scheme for WebKit.dll, and will be necessary
once Safari links against JavaScriptCore.dll. This change also causes
run-safari not to fail (because the launcher printed by FindSafari was
always looking for JavaScriptCore.dll, never
JavaScriptCore_debug.dll).
Part of Bug 25305: can't run safari or drt on windows
<https://bugs.webkit.org/show_bug.cgi?id=25305>
Reviewed by Steve Falkenburg and Sam Weinig.
- WebKit.vcproj/WebKit.vcproj: Use $(WebKitDLLConfigSuffix) for naming JavaScriptCore.{dll,lib}.
WebKitTools:
Rename JavaScriptCore_debug.dll to JavaScriptCore.dll in the Debug
configuration
This matches the naming scheme for WebKit.dll, and will be necessary
once Safari links against JavaScriptCore.dll. This change also causes
run-safari not to fail (because the launcher printed by FindSafari was
always looking for JavaScriptCore.dll, never
JavaScriptCore_debug.dll).
Part of Bug 25305: can't run safari or drt on windows
<https://bugs.webkit.org/show_bug.cgi?id=25305>
Reviewed by Steve Falkenburg and Sam Weinig.
- DumpRenderTree/win/DumpRenderTree.vcproj: Use $(WebKitDLLConfigSuffix) for naming JavaScriptCore.{dll,lib}.
- 11:08 AM Changeset in webkit [42717] by
-
- 2 edits in trunk/JavaScriptCore
Fix JavaScriptCore build on VC++ Express
Reviewed by Steve Falkenburg and Sam Weinig.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Link explicitly against gdi32.lib and oleaut32.lib.
- 11:04 AM BuildingOnWindows edited by
- Removed now-obsolete comments about copying DLLs in order to run the … (diff)
- 10:26 AM Changeset in webkit [42716] by
-
- 1 edit5 adds in trunk/LayoutTests
2009-04-21 Dave Moore <davemoore@google.com> and Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
Add test for (as of yet not implemented) HTML5 named option access.
https://bugs.webkit.org/show_bug.cgi?id=25191
I believe this will require separate implementations
for V8 and JSC the way our current bindings are designed.
- fast/dom/HTMLSelectElement/named-options-expected.txt: Added.
- fast/dom/HTMLSelectElement/named-options.html: Added.
- fast/dom/HTMLSelectElement/resources/TEMPLATE.html: Copied from LayoutTests/fast/dom/CSSStyleDeclaration/resources/TEMPLATE.html.
- fast/dom/HTMLSelectElement/resources/named-options.js: Added.
- 10:20 AM Changeset in webkit [42715] by
-
- 2 edits in trunk/WebCore
!ENABLE(SVG) build fix.
- 10:00 AM Changeset in webkit [42714] by
-
- 5 edits in trunk/WebCore
2009-04-21 Dave Moore <davemoore@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25309
Better use AtomicStrings when calling from the V8
bindings into WebCore code.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLFormElementCustom.cpp:
- bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
- 9:19 AM Changeset in webkit [42713] by
-
- 3 edits2 adds in trunk
Bug 25304: AX: Safari not identifying a secure text field
https://bugs.webkit.org/show_bug.cgi?id=25304
- 9:10 AM Changeset in webkit [42712] by
-
- 2 edits in trunk/WebCore
- fix the Tiger build
- page/mac/EventHandlerMac.mm: (method_setImplementation):
- 8:48 AM Changeset in webkit [42711] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-04-21 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Darin Adler.
Add a test for bug 3235: CSS2: Table cell coalescing in CSS broken
<https://bugs.webkit.org/show_bug.cgi?id=3235>
<rdar://3299883/>
This was fixed long ago, but we should add a test to prevent a regression.
- fast/table/cell-coalescing.html: Added.
- platform/mac/fast/table/cell-coalescing-expected.txt: Added.
- 8:15 AM Changeset in webkit [42710] by
-
- 7 edits in trunk/WebKit/qt
2009-04-21 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Ariya Hidayat.
QWebElementSelection renamed to QWebElementCollection.
- Api/qwebelement.cpp: (QWebElement::findAll): (QWebElementCollectionPrivate::QWebElementCollectionPrivate): (QWebElementCollectionPrivate::create): (QWebElementCollection::QWebElementCollection): (QWebElementCollection::operator=): (QWebElementCollection::~QWebElementCollection): (QWebElementCollection::operator+): (QWebElementCollection::append): (QWebElementCollection::count): (QWebElementCollection::at): (QWebElementCollection::toList):
- Api/qwebelement.h:
- Api/qwebframe.cpp: (QWebFrame::findAllElements):
- Api/qwebframe.h:
- QtLauncher/main.cpp: (MainWindow::selectElements):
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::simpleCollection): (tst_QWebElement::iteration): (tst_QWebElement::emptyCollection): (tst_QWebElement::appendCollection): (tst_QWebElement::nullSelect):
- 6:46 AM QtWebKitTodo edited by
- (diff)
- 6:18 AM Changeset in webkit [42709] by
-
- 3 edits in trunk/WebCore
2009-04-21 Laszlo Gombos <Laszlo Gombos>
Reviewed by Sam Weinig.
Fix the build with disabled DOM storage or disabled database support.
- bindings/js/ScriptObjectQuarantine.cpp:
- bindings/js/ScriptObjectQuarantine.h:
- 3:03 AM QtWebKitTodo edited by
- (diff)
- 2:27 AM Changeset in webkit [42708] by
-
- 2 edits in trunk/WebCore
Compile fix after r42633. const on a static method does not work
- 1:33 AM QtWebKitTodo edited by
- (diff)
- 12:52 AM Changeset in webkit [42707] by
-
- 5 edits in trunk
Reviewed by Darin Adler and John Sullivan.
- fix <rdar://problem/5914146> Crash at -[NSScrollView scrollWheel:]
-[NSScrollView scrollWheel:] runs a nested event-tracking run loop
in a mode that allows WebCore timers to fire and NSURLConnection
callbacks to be dispatched, which can release the NSScrollView and
cause it to be deallocated (one example is a DOM timer callback that
removes a subframe from the document). This leads to a crash in
-scrollView:.
The fix is to replace the implementation of -[NSScrollView scrollWheel:]
with one that optionally retains the receiver for the duration of the
call.
- page/mac/EventHandlerMac.mm: (WebCore::nsScrollViewScrollWheelShouldRetainSelf): Added. (WebCore::setNSScrollViewScrollWheelShouldRetainSelf): Added. Replaces the implementation of -[NSScrollView scrollWheel:] with the self-retaining one, and sets a static boolean that tells it whether to retain the receiver around the call to the original implementation. (WebCore::selfRetainingNSScrollViewScrollWheel): Added. If setNSScrollViewScrollWheelShouldRetainSelf(true) was called and this function is executing on the main thread, it retains the NSScrollView, invokes the original -[NSScrollView scrollWheel:], then releases the view. Otherwise it just calls through to the original implementation. (WebCore::EventHandler::passWheelEventToWidget): Added calls to setNSScrollViewScrollWheelShouldRetainSelf() around the call to -scrollWheel:.
- 12:48 AM Changeset in webkit [42706] by
-
- 2 edits in trunk/WebKitTools
Update FindSafari for JavaScriptCore DLL changes.
Also removed code previously needed to support running nightlies against Safari 3 on Windows.
Reviewed by Mark Rowe.
- FindSafari/FindSafari.cpp: (getStringValue): (getInstalledWebKitDirectory): (_tmain):
- 12:23 AM Changeset in webkit [42705] by
-
- 9 edits3 copies1 add in trunk
2009-04-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
Tiger crash fix: Put VM tags in their own header file, and fixed up the
#ifdefs so they're not used on Tiger.
- JavaScriptCore.xcodeproj/project.pbxproj:
- interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile):
- jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
- jit/ExecutableAllocatorPosix.cpp: (JSC::ExecutablePool::systemAlloc):
- runtime/Collector.cpp: (JSC::allocateBlock):
- wtf/VMTags.h: Added.
JavaScriptGlue:
2009-04-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
Tiger crash fix: Put VM tags in their own header file, and fixed up the
#ifdefs so they're not used on Tiger.
- ForwardingHeaders/wtf/VMTags.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/HashTraits.h.
WebCore:
2009-04-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
Tiger crash fix: Put VM tags in their own header file, and fixed up the
#ifdefs so they're not used on Tiger.
- ForwardingHeaders/wtf/VMTags.h: Copied from WebCore/ForwardingHeaders/wtf/HashTraits.h.
WebKit/mac:
2009-04-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
Tiger crash fix: Put VM tags in their own header file, and fixed up the
#ifdefs so they're not used on Tiger.
- ForwardingHeaders/wtf/VMTags.h: Copied from ForwardingHeaders/wtf/HashTraits.h.
- 12:02 AM Changeset in webkit [42704] by
-
- 2 edits in trunk/WebCore
2009-04-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Based on a patch by Alp Toker.
Implement AtkComponent interface.
- page/gtk/AccessibilityObjectWrapperAtk.cpp: (core):
- 12:01 AM Changeset in webkit [42703] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Implement window<->screen coordinate transformation functions.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::widgetScreenPosition): (WebKit::ChromeClient::windowToScreen): (WebKit::ChromeClient::screenToWindow):
- 12:01 AM Changeset in webkit [42702] by
-
- 2 edits in trunk/WebCore
2009-04-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Only implement AtkAction interface if we actually have an action.
- page/gtk/AccessibilityObjectWrapperAtk.cpp:
Apr 20, 2009:
- 11:41 PM Changeset in webkit [42701] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj
Windows build fix
- 11:34 PM Changeset in webkit [42700] by
-
- 13 edits3 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25290
REGRESSION(r41732): Crash when constructing XMLHttpRequest in a detached document
Test: fast/dom/xmlhttprequest-constructor-in-detached-document.html
- bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
- bindings/js/JSAudioConstructor.h:
- bindings/js/JSDOMGlobalObject.h: (WebCore::getDOMConstructor):
- bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
- bindings/js/JSImageConstructor.h:
- bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
- bindings/js/JSMessageChannelConstructor.h:
- bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
- bindings/js/JSOptionConstructor.h:
- bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
- bindings/js/JSXMLHttpRequestConstructor.h: Avoid accessing JSDOMGlobalObject via ScriptExecutionContext, since it may not work during frame teardown.
- 10:58 PM Changeset in webkit [42699] by
-
- 32 edits in trunk/WebCore
2009-04-20 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Darin Adler and Sam Weinig.
Renamed "*InlineEventListener*" => "*AttributeEventListener*", and
"isInline" => "isAttribute".
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener): (WebCore::JSEventListener::handleEvent): (WebCore::JSEventListener::virtualisAttribute):
- bindings/js/JSEventListener.h: (WebCore::JSEventListener::create): (WebCore::JSEventListener::isAttribute):
- bindings/js/JSLazyEventListener.cpp: (WebCore::createAttributeEventListener):
- bindings/js/JSLazyEventListener.h:
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Element.cpp: (WebCore::Element::setWindowAttributeEventListener):
- dom/Element.h:
- dom/EventListener.h: (WebCore::EventListener::isAttribute): (WebCore::EventListener::virtualisAttribute):
- dom/Node.cpp: (WebCore::Node::clearAttributeEventListener): (WebCore::Node::setAttributeEventListener): (WebCore::Node::getAttributeEventListener): (WebCore::Node::onabort): (WebCore::Node::setOnabort): (WebCore::Node::onblur): (WebCore::Node::setOnblur): (WebCore::Node::onchange): (WebCore::Node::setOnchange): (WebCore::Node::onclick): (WebCore::Node::setOnclick): (WebCore::Node::oncontextmenu): (WebCore::Node::setOncontextmenu): (WebCore::Node::ondblclick): (WebCore::Node::setOndblclick): (WebCore::Node::onerror): (WebCore::Node::setOnerror): (WebCore::Node::onfocus): (WebCore::Node::setOnfocus): (WebCore::Node::oninput): (WebCore::Node::setOninput): (WebCore::Node::onkeydown): (WebCore::Node::setOnkeydown): (WebCore::Node::onkeypress): (WebCore::Node::setOnkeypress): (WebCore::Node::onkeyup): (WebCore::Node::setOnkeyup): (WebCore::Node::onload): (WebCore::Node::setOnload): (WebCore::Node::onmousedown): (WebCore::Node::setOnmousedown): (WebCore::Node::onmousemove): (WebCore::Node::setOnmousemove): (WebCore::Node::onmouseout): (WebCore::Node::setOnmouseout): (WebCore::Node::onmouseover): (WebCore::Node::setOnmouseover): (WebCore::Node::onmouseup): (WebCore::Node::setOnmouseup): (WebCore::Node::onmousewheel): (WebCore::Node::setOnmousewheel): (WebCore::Node::onbeforecut): (WebCore::Node::setOnbeforecut): (WebCore::Node::oncut): (WebCore::Node::setOncut): (WebCore::Node::onbeforecopy): (WebCore::Node::setOnbeforecopy): (WebCore::Node::oncopy): (WebCore::Node::setOncopy): (WebCore::Node::onbeforepaste): (WebCore::Node::setOnbeforepaste): (WebCore::Node::onpaste): (WebCore::Node::setOnpaste): (WebCore::Node::ondragenter): (WebCore::Node::setOndragenter): (WebCore::Node::ondragover): (WebCore::Node::setOndragover): (WebCore::Node::ondragleave): (WebCore::Node::setOndragleave): (WebCore::Node::ondrop): (WebCore::Node::setOndrop): (WebCore::Node::ondragstart): (WebCore::Node::setOndragstart): (WebCore::Node::ondrag): (WebCore::Node::setOndrag): (WebCore::Node::ondragend): (WebCore::Node::setOndragend): (WebCore::Node::onreset): (WebCore::Node::setOnreset): (WebCore::Node::onresize): (WebCore::Node::setOnresize): (WebCore::Node::onscroll): (WebCore::Node::setOnscroll): (WebCore::Node::onsearch): (WebCore::Node::setOnsearch): (WebCore::Node::onselect): (WebCore::Node::setOnselect): (WebCore::Node::onselectstart): (WebCore::Node::setOnselectstart): (WebCore::Node::onsubmit): (WebCore::Node::setOnsubmit): (WebCore::Node::onunload): (WebCore::Node::setOnunload):
- dom/Node.h:
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
- html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::parseMappedAttribute):
- html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::parseMappedAttribute):
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute):
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute):
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute):
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::mouseButtonListener):
- page/DOMWindow.cpp: (WebCore::DOMWindow::setAttributeEventListener): (WebCore::DOMWindow::clearAttributeEventListener): (WebCore::DOMWindow::getAttributeEventListener): (WebCore::DOMWindow::onabort): (WebCore::DOMWindow::setOnabort): (WebCore::DOMWindow::onblur): (WebCore::DOMWindow::setOnblur): (WebCore::DOMWindow::onchange): (WebCore::DOMWindow::setOnchange): (WebCore::DOMWindow::onclick): (WebCore::DOMWindow::setOnclick): (WebCore::DOMWindow::ondblclick): (WebCore::DOMWindow::setOndblclick): (WebCore::DOMWindow::onerror): (WebCore::DOMWindow::setOnerror): (WebCore::DOMWindow::onfocus): (WebCore::DOMWindow::setOnfocus): (WebCore::DOMWindow::onkeydown): (WebCore::DOMWindow::setOnkeydown): (WebCore::DOMWindow::onkeypress): (WebCore::DOMWindow::setOnkeypress): (WebCore::DOMWindow::onkeyup): (WebCore::DOMWindow::setOnkeyup): (WebCore::DOMWindow::onload): (WebCore::DOMWindow::setOnload): (WebCore::DOMWindow::onmousedown): (WebCore::DOMWindow::setOnmousedown): (WebCore::DOMWindow::onmousemove): (WebCore::DOMWindow::setOnmousemove): (WebCore::DOMWindow::onmouseout): (WebCore::DOMWindow::setOnmouseout): (WebCore::DOMWindow::onmouseover): (WebCore::DOMWindow::setOnmouseover): (WebCore::DOMWindow::onmouseup): (WebCore::DOMWindow::setOnmouseup): (WebCore::DOMWindow::onmousewheel): (WebCore::DOMWindow::setOnmousewheel): (WebCore::DOMWindow::onreset): (WebCore::DOMWindow::setOnreset): (WebCore::DOMWindow::onresize): (WebCore::DOMWindow::setOnresize): (WebCore::DOMWindow::onscroll): (WebCore::DOMWindow::setOnscroll): (WebCore::DOMWindow::onsearch): (WebCore::DOMWindow::setOnsearch): (WebCore::DOMWindow::onselect): (WebCore::DOMWindow::setOnselect): (WebCore::DOMWindow::onsubmit): (WebCore::DOMWindow::setOnsubmit): (WebCore::DOMWindow::onunload): (WebCore::DOMWindow::setOnunload): (WebCore::DOMWindow::onbeforeunload): (WebCore::DOMWindow::setOnbeforeunload): (WebCore::DOMWindow::onwebkitanimationstart): (WebCore::DOMWindow::setOnwebkitanimationstart): (WebCore::DOMWindow::onwebkitanimationiteration): (WebCore::DOMWindow::setOnwebkitanimationiteration): (WebCore::DOMWindow::onwebkitanimationend): (WebCore::DOMWindow::setOnwebkitanimationend): (WebCore::DOMWindow::onwebkittransitionend): (WebCore::DOMWindow::setOnwebkittransitionend):
- page/DOMWindow.h:
- svg/SVGElement.cpp: (WebCore::SVGElement::parseMappedAttribute):
- svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::onabort): (WebCore::SVGElementInstance::setOnabort): (WebCore::SVGElementInstance::onblur): (WebCore::SVGElementInstance::setOnblur): (WebCore::SVGElementInstance::onchange): (WebCore::SVGElementInstance::setOnchange): (WebCore::SVGElementInstance::onclick): (WebCore::SVGElementInstance::setOnclick): (WebCore::SVGElementInstance::oncontextmenu): (WebCore::SVGElementInstance::setOncontextmenu): (WebCore::SVGElementInstance::ondblclick): (WebCore::SVGElementInstance::setOndblclick): (WebCore::SVGElementInstance::onerror): (WebCore::SVGElementInstance::setOnerror): (WebCore::SVGElementInstance::onfocus): (WebCore::SVGElementInstance::setOnfocus): (WebCore::SVGElementInstance::oninput): (WebCore::SVGElementInstance::setOninput): (WebCore::SVGElementInstance::onkeydown): (WebCore::SVGElementInstance::setOnkeydown): (WebCore::SVGElementInstance::onkeypress): (WebCore::SVGElementInstance::setOnkeypress): (WebCore::SVGElementInstance::onkeyup): (WebCore::SVGElementInstance::setOnkeyup): (WebCore::SVGElementInstance::onload): (WebCore::SVGElementInstance::setOnload): (WebCore::SVGElementInstance::onmousedown): (WebCore::SVGElementInstance::setOnmousedown): (WebCore::SVGElementInstance::onmousemove): (WebCore::SVGElementInstance::setOnmousemove): (WebCore::SVGElementInstance::onmouseout): (WebCore::SVGElementInstance::setOnmouseout): (WebCore::SVGElementInstance::onmouseover): (WebCore::SVGElementInstance::setOnmouseover): (WebCore::SVGElementInstance::onmouseup): (WebCore::SVGElementInstance::setOnmouseup): (WebCore::SVGElementInstance::onmousewheel): (WebCore::SVGElementInstance::setOnmousewheel): (WebCore::SVGElementInstance::onbeforecut): (WebCore::SVGElementInstance::setOnbeforecut): (WebCore::SVGElementInstance::oncut): (WebCore::SVGElementInstance::setOncut): (WebCore::SVGElementInstance::onbeforecopy): (WebCore::SVGElementInstance::setOnbeforecopy): (WebCore::SVGElementInstance::oncopy): (WebCore::SVGElementInstance::setOncopy): (WebCore::SVGElementInstance::onbeforepaste): (WebCore::SVGElementInstance::setOnbeforepaste): (WebCore::SVGElementInstance::onpaste): (WebCore::SVGElementInstance::setOnpaste): (WebCore::SVGElementInstance::ondragenter): (WebCore::SVGElementInstance::setOndragenter): (WebCore::SVGElementInstance::ondragover): (WebCore::SVGElementInstance::setOndragover): (WebCore::SVGElementInstance::ondragleave): (WebCore::SVGElementInstance::setOndragleave): (WebCore::SVGElementInstance::ondrop): (WebCore::SVGElementInstance::setOndrop): (WebCore::SVGElementInstance::ondragstart): (WebCore::SVGElementInstance::setOndragstart): (WebCore::SVGElementInstance::ondrag): (WebCore::SVGElementInstance::setOndrag): (WebCore::SVGElementInstance::ondragend): (WebCore::SVGElementInstance::setOndragend): (WebCore::SVGElementInstance::onreset): (WebCore::SVGElementInstance::setOnreset): (WebCore::SVGElementInstance::onresize): (WebCore::SVGElementInstance::setOnresize): (WebCore::SVGElementInstance::onscroll): (WebCore::SVGElementInstance::setOnscroll): (WebCore::SVGElementInstance::onsearch): (WebCore::SVGElementInstance::setOnsearch): (WebCore::SVGElementInstance::onselect): (WebCore::SVGElementInstance::setOnselect): (WebCore::SVGElementInstance::onselectstart): (WebCore::SVGElementInstance::setOnselectstart): (WebCore::SVGElementInstance::onsubmit): (WebCore::SVGElementInstance::setOnsubmit): (WebCore::SVGElementInstance::onunload): (WebCore::SVGElementInstance::setOnunload):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute):
- 10:17 PM Changeset in webkit [42698] by
-
- 549 edits8 deletes in trunk
WebCore:
2009-04-20 Geoffrey Garen <ggaren@apple.com>
Approved by Mark Rowe, Cameron Zwarich, Oliver Hunt, and Ojan Vafai.
Used svn merge to roll out revisions 42678, 42690, 42694, 42697 because
they broke the Tiger and Windows buildbots.
- css/html4.css:
- css/themeWin.css:
- platform/graphics/SimpleFontData.cpp:
- platform/graphics/SimpleFontData.h:
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
- platform/graphics/chromium/SimpleFontDataLinux.cpp:
- platform/graphics/gtk/SimpleFontDataGtk.cpp:
- platform/graphics/gtk/SimpleFontDataPango.cpp:
- platform/graphics/mac/SimpleFontDataMac.mm:
- platform/graphics/qt/SimpleFontDataQt.cpp:
- platform/graphics/win/SimpleFontDataCGWin.cpp:
- platform/graphics/win/SimpleFontDataCairoWin.cpp:
- platform/graphics/win/SimpleFontDataWin.cpp:
- platform/graphics/wx/SimpleFontDataWx.cpp:
- rendering/RenderTextControl.cpp:
- rendering/RenderTextControlMultiLine.cpp:
- rendering/RenderTextControlSingleLine.cpp:
LayoutTests:
2009-04-20 Geoffrey Garen <ggaren@apple.com>
Approved by Mark Rowe, Cameron Zwarich, Oliver Hunt, and Ojan Vafai.
Used svn merge to roll out revisions 42678, 42690, 42694, 42697 because
they broke the Tiger and Windows buildbots.
- fast/forms/drag-out-of-textarea.html:
- fast/forms/resources/TEMPLATE.html: Removed.
- fast/forms/resources/text-control-intrinsic-widths.js: Removed.
- fast/forms/resources/textarea-metrics.js: Removed.
- fast/forms/search-abs-pos-cancel-button.html:
- fast/forms/text-control-intrinsic-widths-expected.txt: Removed.
- fast/forms/text-control-intrinsic-widths.html: Removed.
- fast/forms/textarea-metrics-expected.txt: Removed.
- fast/forms/textarea-metrics.html: Removed.
- fast/forms/textarea-width.html:
- fast/replaced/table-percent-height-expected.txt:
- fast/replaced/table-percent-height.html:
- platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum:
- platform/mac-leopard/fast/forms/input-text-maxlength-expected.png:
- platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt:
- platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum:
- platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png:
- platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt:
- platform/mac/editing/deleting/5168598-expected.checksum:
- platform/mac/editing/deleting/5168598-expected.png:
- platform/mac/editing/deleting/5168598-expected.txt:
- platform/mac/editing/inserting/4960120-1-expected.checksum:
- platform/mac/editing/inserting/4960120-1-expected.png:
- platform/mac/editing/inserting/4960120-1-expected.txt:
- platform/mac/editing/inserting/5607069-2-expected.checksum:
- platform/mac/editing/inserting/5607069-2-expected.png:
- platform/mac/editing/inserting/5607069-2-expected.txt:
- platform/mac/editing/inserting/5607069-3-expected.checksum:
- platform/mac/editing/inserting/5607069-3-expected.png:
- platform/mac/editing/inserting/5607069-3-expected.txt:
- platform/mac/editing/inserting/before-after-input-element-expected.checksum:
- platform/mac/editing/inserting/before-after-input-element-expected.png:
- platform/mac/editing/inserting/before-after-input-element-expected.txt:
- platform/mac/editing/inserting/typing-tab-designmode-forms-expected.checksum:
- platform/mac/editing/inserting/typing-tab-designmode-forms-expected.png:
- platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt:
- platform/mac/editing/pasteboard/4806874-expected.checksum:
- platform/mac/editing/pasteboard/4806874-expected.png:
- platform/mac/editing/pasteboard/4806874-expected.txt:
- platform/mac/editing/pasteboard/drop-text-without-selection-expected.checksum:
- platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
- platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/mac/editing/pasteboard/input-field-1-expected.checksum:
- platform/mac/editing/pasteboard/input-field-1-expected.png:
- platform/mac/editing/pasteboard/input-field-1-expected.txt:
- platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
- platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png:
- platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
- platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
- platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png:
- platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt:
- platform/mac/editing/pasteboard/pasting-tabs-expected.checksum:
- platform/mac/editing/pasteboard/pasting-tabs-expected.png:
- platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
- platform/mac/editing/selection/3690703-2-expected.checksum:
- platform/mac/editing/selection/3690703-2-expected.png:
- platform/mac/editing/selection/3690703-2-expected.txt:
- platform/mac/editing/selection/3690703-expected.checksum:
- platform/mac/editing/selection/3690703-expected.png:
- platform/mac/editing/selection/3690703-expected.txt:
- platform/mac/editing/selection/3690719-expected.checksum:
- platform/mac/editing/selection/3690719-expected.png:
- platform/mac/editing/selection/3690719-expected.txt:
- platform/mac/editing/selection/4895428-3-expected.checksum:
- platform/mac/editing/selection/4895428-3-expected.png:
- platform/mac/editing/selection/4895428-3-expected.txt:
- platform/mac/editing/selection/4975120-expected.checksum:
- platform/mac/editing/selection/4975120-expected.png:
- platform/mac/editing/selection/4975120-expected.txt:
- platform/mac/editing/selection/5136696-expected.checksum:
- platform/mac/editing/selection/5136696-expected.png:
- platform/mac/editing/selection/5136696-expected.txt:
- platform/mac/editing/selection/5213963-expected.checksum:
- platform/mac/editing/selection/5213963-expected.png:
- platform/mac/editing/selection/5213963-expected.txt:
- platform/mac/editing/selection/drag-select-1-expected.checksum:
- platform/mac/editing/selection/drag-select-1-expected.png:
- platform/mac/editing/selection/drag-select-1-expected.txt:
- platform/mac/editing/selection/drag-text-delay-expected.checksum:
- platform/mac/editing/selection/drag-text-delay-expected.png:
- platform/mac/editing/selection/drag-text-delay-expected.txt:
- platform/mac/editing/selection/select-from-textfield-outwards-expected.checksum:
- platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
- platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/mac/fast/block/margin-collapse/103-expected.txt:
- platform/mac/fast/css/line-height-expected.checksum:
- platform/mac/fast/css/line-height-expected.png:
- platform/mac/fast/css/line-height-expected.txt:
- platform/mac/fast/css/resize-corner-tracking-expected.checksum:
- platform/mac/fast/css/resize-corner-tracking-expected.png:
- platform/mac/fast/css/resize-corner-tracking-expected.txt:
- platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum:
- platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
- platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
- platform/mac/fast/dom/isindex-002-expected.checksum:
- platform/mac/fast/dom/isindex-002-expected.png:
- platform/mac/fast/dom/isindex-002-expected.txt:
- platform/mac/fast/dynamic/008-expected.checksum:
- platform/mac/fast/dynamic/008-expected.png:
- platform/mac/fast/dynamic/008-expected.txt:
- platform/mac/fast/events/autoscroll-expected.checksum:
- platform/mac/fast/events/autoscroll-expected.png:
- platform/mac/fast/events/autoscroll-expected.txt:
- platform/mac/fast/events/context-no-deselect-expected.checksum:
- platform/mac/fast/events/context-no-deselect-expected.png:
- platform/mac/fast/events/context-no-deselect-expected.txt:
- platform/mac/fast/events/label-focus-expected.checksum:
- platform/mac/fast/events/label-focus-expected.png:
- platform/mac/fast/events/label-focus-expected.txt:
- platform/mac/fast/forms/basic-textareas-expected.checksum:
- platform/mac/fast/forms/basic-textareas-expected.png:
- platform/mac/fast/forms/basic-textareas-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.checksum:
- platform/mac/fast/forms/box-shadow-override-expected.png:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/control-restrict-line-height-expected.checksum:
- platform/mac/fast/forms/control-restrict-line-height-expected.png:
- platform/mac/fast/forms/control-restrict-line-height-expected.txt:
- platform/mac/fast/forms/encoding-test-expected.checksum:
- platform/mac/fast/forms/encoding-test-expected.png:
- platform/mac/fast/forms/encoding-test-expected.txt:
- platform/mac/fast/forms/fieldset-align-expected.checksum:
- platform/mac/fast/forms/fieldset-align-expected.png:
- platform/mac/fast/forms/fieldset-align-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.checksum:
- platform/mac/fast/forms/form-element-geometry-expected.png:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/input-align-expected.checksum:
- platform/mac/fast/forms/input-align-expected.png:
- platform/mac/fast/forms/input-align-expected.txt:
- platform/mac/fast/forms/input-appearance-bkcolor-expected.checksum:
- platform/mac/fast/forms/input-appearance-bkcolor-expected.png:
- platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
- platform/mac/fast/forms/input-appearance-default-bkcolor-expected.checksum:
- platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
- platform/mac/fast/forms/input-appearance-disabled-expected.checksum:
- platform/mac/fast/forms/input-appearance-disabled-expected.png:
- platform/mac/fast/forms/input-appearance-disabled-expected.txt:
- platform/mac/fast/forms/input-appearance-focus-expected.checksum:
- platform/mac/fast/forms/input-appearance-focus-expected.png:
- platform/mac/fast/forms/input-appearance-focus-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.checksum:
- platform/mac/fast/forms/input-appearance-height-expected.png:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.checksum:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/mac/fast/forms/input-appearance-readonly-expected.checksum:
- platform/mac/fast/forms/input-appearance-readonly-expected.png:
- platform/mac/fast/forms/input-appearance-readonly-expected.txt:
- platform/mac/fast/forms/input-appearance-selection-expected.checksum:
- platform/mac/fast/forms/input-appearance-selection-expected.png:
- platform/mac/fast/forms/input-appearance-selection-expected.txt:
- platform/mac/fast/forms/input-appearance-visibility-expected.checksum:
- platform/mac/fast/forms/input-appearance-visibility-expected.png:
- platform/mac/fast/forms/input-appearance-visibility-expected.txt:
- platform/mac/fast/forms/input-appearance-width-expected.checksum:
- platform/mac/fast/forms/input-appearance-width-expected.png:
- platform/mac/fast/forms/input-appearance-width-expected.txt:
- platform/mac/fast/forms/input-baseline-expected.checksum:
- platform/mac/fast/forms/input-baseline-expected.png:
- platform/mac/fast/forms/input-baseline-expected.txt:
- platform/mac/fast/forms/input-disabled-color-expected.checksum:
- platform/mac/fast/forms/input-disabled-color-expected.png:
- platform/mac/fast/forms/input-disabled-color-expected.txt:
- platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.checksum:
- platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/mac/fast/forms/input-paste-undo-expected.checksum:
- platform/mac/fast/forms/input-paste-undo-expected.png:
- platform/mac/fast/forms/input-paste-undo-expected.txt:
- platform/mac/fast/forms/input-readonly-autoscroll-expected.checksum:
- platform/mac/fast/forms/input-readonly-autoscroll-expected.png:
- platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/mac/fast/forms/input-readonly-dimmed-expected.checksum:
- platform/mac/fast/forms/input-readonly-dimmed-expected.png:
- platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
- platform/mac/fast/forms/input-readonly-empty-expected.checksum:
- platform/mac/fast/forms/input-readonly-empty-expected.png:
- platform/mac/fast/forms/input-readonly-empty-expected.txt:
- platform/mac/fast/forms/input-spaces-expected.checksum:
- platform/mac/fast/forms/input-spaces-expected.png:
- platform/mac/fast/forms/input-spaces-expected.txt:
- platform/mac/fast/forms/input-table-expected.txt:
- platform/mac/fast/forms/input-text-click-inside-expected.checksum:
- platform/mac/fast/forms/input-text-click-inside-expected.png:
- platform/mac/fast/forms/input-text-click-inside-expected.txt:
- platform/mac/fast/forms/input-text-click-outside-expected.checksum:
- platform/mac/fast/forms/input-text-click-outside-expected.png:
- platform/mac/fast/forms/input-text-click-outside-expected.txt:
- platform/mac/fast/forms/input-text-double-click-expected.checksum:
- platform/mac/fast/forms/input-text-double-click-expected.png:
- platform/mac/fast/forms/input-text-double-click-expected.txt:
- platform/mac/fast/forms/input-text-drag-down-expected.checksum:
- platform/mac/fast/forms/input-text-drag-down-expected.png:
- platform/mac/fast/forms/input-text-drag-down-expected.txt:
- platform/mac/fast/forms/input-text-option-delete-expected.checksum:
- platform/mac/fast/forms/input-text-option-delete-expected.png:
- platform/mac/fast/forms/input-text-option-delete-expected.txt:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.checksum:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/mac/fast/forms/input-text-self-emptying-click-expected.checksum:
- platform/mac/fast/forms/input-text-self-emptying-click-expected.png:
- platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/mac/fast/forms/input-text-word-wrap-expected.checksum:
- platform/mac/fast/forms/input-text-word-wrap-expected.png:
- platform/mac/fast/forms/input-text-word-wrap-expected.txt:
- platform/mac/fast/forms/input-type-change2-expected.checksum:
- platform/mac/fast/forms/input-type-change2-expected.png:
- platform/mac/fast/forms/input-type-change2-expected.txt:
- platform/mac/fast/forms/input-type-text-min-width-expected.checksum:
- platform/mac/fast/forms/input-type-text-min-width-expected.png:
- platform/mac/fast/forms/input-type-text-min-width-expected.txt:
- platform/mac/fast/forms/input-value-expected.checksum:
- platform/mac/fast/forms/input-value-expected.png:
- platform/mac/fast/forms/input-value-expected.txt:
- platform/mac/fast/forms/input-width-expected.checksum:
- platform/mac/fast/forms/input-width-expected.png:
- platform/mac/fast/forms/input-width-expected.txt:
- platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
- platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
- platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
- platform/mac/fast/forms/negativeLineHeight-expected.checksum:
- platform/mac/fast/forms/negativeLineHeight-expected.png:
- platform/mac/fast/forms/negativeLineHeight-expected.txt:
- platform/mac/fast/forms/password-placeholder-expected.checksum:
- platform/mac/fast/forms/password-placeholder-expected.png:
- platform/mac/fast/forms/password-placeholder-expected.txt:
- platform/mac/fast/forms/password-placeholder-text-security-expected.checksum:
- platform/mac/fast/forms/password-placeholder-text-security-expected.png:
- platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
- platform/mac/fast/forms/placeholder-pseudo-style-expected.checksum:
- platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
- platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/mac/fast/forms/placeholder-set-attribute-expected.checksum:
- platform/mac/fast/forms/placeholder-set-attribute-expected.png:
- platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
- platform/mac/fast/forms/placeholder-set-value-expected.checksum:
- platform/mac/fast/forms/placeholder-set-value-expected.png:
- platform/mac/fast/forms/placeholder-set-value-expected.txt:
- platform/mac/fast/forms/search-cancel-button-style-sharing-expected.checksum:
- platform/mac/fast/forms/search-cancel-button-style-sharing-expected.png:
- platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/mac/fast/forms/search-display-none-cancel-button-expected.checksum:
- platform/mac/fast/forms/search-display-none-cancel-button-expected.png:
- platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/mac/fast/forms/search-placeholder-value-changed-expected.checksum:
- platform/mac/fast/forms/search-placeholder-value-changed-expected.png:
- platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
- platform/mac/fast/forms/search-rtl-expected.checksum:
- platform/mac/fast/forms/search-rtl-expected.png:
- platform/mac/fast/forms/search-rtl-expected.txt:
- platform/mac/fast/forms/search-transformed-expected.checksum:
- platform/mac/fast/forms/search-transformed-expected.png:
- platform/mac/fast/forms/search-transformed-expected.txt:
- platform/mac/fast/forms/search-zoomed-expected.checksum:
- platform/mac/fast/forms/search-zoomed-expected.png:
- platform/mac/fast/forms/search-zoomed-expected.txt:
- platform/mac/fast/forms/searchfield-heights-expected.checksum:
- platform/mac/fast/forms/searchfield-heights-expected.png:
- platform/mac/fast/forms/searchfield-heights-expected.txt:
- platform/mac/fast/forms/tabbing-input-iframe-expected.checksum:
- platform/mac/fast/forms/tabbing-input-iframe-expected.png:
- platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
- platform/mac/fast/forms/textAreaLineHeight-expected.checksum:
- platform/mac/fast/forms/textAreaLineHeight-expected.png:
- platform/mac/fast/forms/textAreaLineHeight-expected.txt:
- platform/mac/fast/forms/textarea-align-expected.checksum:
- platform/mac/fast/forms/textarea-align-expected.png:
- platform/mac/fast/forms/textarea-align-expected.txt:
- platform/mac/fast/forms/textarea-rows-cols-expected.checksum:
- platform/mac/fast/forms/textarea-rows-cols-expected.png:
- platform/mac/fast/forms/textarea-rows-cols-expected.txt:
- platform/mac/fast/forms/textarea-scroll-height-expected.checksum:
- platform/mac/fast/forms/textarea-scroll-height-expected.png:
- platform/mac/fast/forms/textarea-scroll-height-expected.txt:
- platform/mac/fast/forms/textarea-scrollbar-expected.checksum:
- platform/mac/fast/forms/textarea-scrollbar-expected.png:
- platform/mac/fast/forms/textarea-scrollbar-expected.txt:
- platform/mac/fast/forms/textarea-scrolled-type-expected.checksum:
- platform/mac/fast/forms/textarea-scrolled-type-expected.png:
- platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
- platform/mac/fast/forms/textarea-setinnerhtml-expected.checksum:
- platform/mac/fast/forms/textarea-setinnerhtml-expected.png:
- platform/mac/fast/forms/textarea-setinnerhtml-expected.txt:
- platform/mac/fast/forms/textarea-width-expected.checksum:
- platform/mac/fast/forms/textarea-width-expected.png:
- platform/mac/fast/forms/textarea-width-expected.txt:
- platform/mac/fast/forms/textfield-drag-into-disabled-expected.checksum:
- platform/mac/fast/forms/textfield-drag-into-disabled-expected.png:
- platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt:
- platform/mac/fast/forms/textfield-outline-expected.checksum:
- platform/mac/fast/forms/textfield-outline-expected.png:
- platform/mac/fast/forms/textfield-outline-expected.txt:
- platform/mac/fast/forms/textfield-overflow-expected.checksum:
- platform/mac/fast/forms/textfield-overflow-expected.png:
- platform/mac/fast/forms/textfield-overflow-expected.txt:
- platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
- platform/mac/fast/invalid/residual-style-expected.txt:
- platform/mac/fast/lists/dynamic-marker-crash-expected.checksum:
- platform/mac/fast/lists/dynamic-marker-crash-expected.png:
- platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
- platform/mac/fast/overflow/overflow-x-y-expected.checksum:
- platform/mac/fast/overflow/overflow-x-y-expected.png:
- platform/mac/fast/overflow/overflow-x-y-expected.txt:
- platform/mac/fast/parser/comment-in-textarea-expected.checksum:
- platform/mac/fast/parser/comment-in-textarea-expected.png:
- platform/mac/fast/parser/comment-in-textarea-expected.txt:
- platform/mac/fast/parser/entity-comment-in-textarea-expected.checksum:
- platform/mac/fast/parser/entity-comment-in-textarea-expected.png:
- platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
- platform/mac/fast/parser/open-comment-in-textarea-expected.checksum:
- platform/mac/fast/parser/open-comment-in-textarea-expected.png:
- platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/mac/fast/repaint/search-field-cancel-expected.checksum:
- platform/mac/fast/repaint/search-field-cancel-expected.png:
- platform/mac/fast/repaint/search-field-cancel-expected.txt:
- platform/mac/fast/repaint/subtree-root-skipped-expected.checksum:
- platform/mac/fast/repaint/subtree-root-skipped-expected.png:
- platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-expected.checksum:
- platform/mac/fast/replaced/replaced-breaking-expected.png:
- platform/mac/fast/replaced/replaced-breaking-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-mixture-expected.checksum:
- platform/mac/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
- platform/mac/fast/replaced/width100percent-searchfield-expected.checksum:
- platform/mac/fast/replaced/width100percent-searchfield-expected.png:
- platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
- platform/mac/fast/replaced/width100percent-textarea-expected.checksum:
- platform/mac/fast/replaced/width100percent-textarea-expected.png:
- platform/mac/fast/replaced/width100percent-textarea-expected.txt:
- platform/mac/fast/replaced/width100percent-textfield-expected.checksum:
- platform/mac/fast/replaced/width100percent-textfield-expected.png:
- platform/mac/fast/replaced/width100percent-textfield-expected.txt:
- platform/mac/fast/table/003-expected.checksum:
- platform/mac/fast/table/003-expected.png:
- platform/mac/fast/table/003-expected.txt:
- platform/mac/fast/table/colspanMinWidth-expected.checksum:
- platform/mac/fast/table/colspanMinWidth-expected.png:
- platform/mac/fast/table/colspanMinWidth-expected.txt:
- platform/mac/fast/table/spanOverlapRepaint-expected.checksum:
- platform/mac/fast/table/spanOverlapRepaint-expected.png:
- platform/mac/fast/table/spanOverlapRepaint-expected.txt:
- platform/mac/fast/table/text-field-baseline-expected.checksum:
- platform/mac/fast/table/text-field-baseline-expected.png:
- platform/mac/fast/table/text-field-baseline-expected.txt:
- platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.checksum:
- platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.png:
- platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
- platform/mac/fast/text/textIteratorNilRenderer-expected.checksum:
- platform/mac/fast/text/textIteratorNilRenderer-expected.png:
- platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
- platform/mac/fast/transforms/transformed-focused-text-input-expected.checksum:
- platform/mac/fast/transforms/transformed-focused-text-input-expected.png:
- platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/mac/http/tests/navigation/anchor-basic-expected.checksum:
- platform/mac/http/tests/navigation/anchor-basic-expected.png:
- platform/mac/http/tests/navigation/anchor-basic-expected.txt:
- platform/mac/http/tests/navigation/anchor-frames-expected.txt:
- platform/mac/http/tests/navigation/anchor-goback-expected.checksum:
- platform/mac/http/tests/navigation/anchor-goback-expected.png:
- platform/mac/http/tests/navigation/anchor-goback-expected.txt:
- platform/mac/http/tests/navigation/anchor-subframeload-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-basic-expected.checksum:
- platform/mac/http/tests/navigation/javascriptlink-basic-expected.png:
- platform/mac/http/tests/navigation/javascriptlink-basic-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.checksum:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-goback-expected.checksum:
- platform/mac/http/tests/navigation/javascriptlink-goback-expected.png:
- platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.checksum:
- platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.png:
- platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.txt:
- platform/mac/http/tests/navigation/metaredirect-basic-expected.checksum:
- platform/mac/http/tests/navigation/metaredirect-basic-expected.png:
- platform/mac/http/tests/navigation/metaredirect-basic-expected.txt:
- platform/mac/http/tests/navigation/metaredirect-frames-expected.checksum:
- platform/mac/http/tests/navigation/metaredirect-frames-expected.png:
- platform/mac/http/tests/navigation/metaredirect-frames-expected.txt:
- platform/mac/http/tests/navigation/metaredirect-goback-expected.checksum:
- platform/mac/http/tests/navigation/metaredirect-goback-expected.png:
- platform/mac/http/tests/navigation/metaredirect-goback-expected.txt:
- platform/mac/http/tests/navigation/metaredirect-subframeload-expected.checksum:
- platform/mac/http/tests/navigation/metaredirect-subframeload-expected.png:
- platform/mac/http/tests/navigation/metaredirect-subframeload-expected.txt:
- platform/mac/http/tests/navigation/post-goback2-expected.checksum:
- platform/mac/http/tests/navigation/post-goback2-expected.png:
- platform/mac/http/tests/navigation/post-goback2-expected.txt:
- platform/mac/http/tests/navigation/postredirect-goback2-expected.checksum:
- platform/mac/http/tests/navigation/postredirect-goback2-expected.png:
- platform/mac/http/tests/navigation/postredirect-goback2-expected.txt:
- platform/mac/http/tests/navigation/redirect302-basic-expected.checksum:
- platform/mac/http/tests/navigation/redirect302-basic-expected.png:
- platform/mac/http/tests/navigation/redirect302-basic-expected.txt:
- platform/mac/http/tests/navigation/redirect302-frames-expected.checksum:
- platform/mac/http/tests/navigation/redirect302-frames-expected.png:
- platform/mac/http/tests/navigation/redirect302-frames-expected.txt:
- platform/mac/http/tests/navigation/redirect302-goback-expected.checksum:
- platform/mac/http/tests/navigation/redirect302-goback-expected.png:
- platform/mac/http/tests/navigation/redirect302-goback-expected.txt:
- platform/mac/http/tests/navigation/redirect302-subframeload-expected.checksum:
- platform/mac/http/tests/navigation/redirect302-subframeload-expected.png:
- platform/mac/http/tests/navigation/redirect302-subframeload-expected.txt:
- platform/mac/http/tests/navigation/relativeanchor-basic-expected.checksum:
- platform/mac/http/tests/navigation/relativeanchor-basic-expected.png:
- platform/mac/http/tests/navigation/relativeanchor-basic-expected.txt:
- platform/mac/http/tests/navigation/relativeanchor-frames-expected.txt:
- platform/mac/http/tests/navigation/relativeanchor-goback-expected.checksum:
- platform/mac/http/tests/navigation/relativeanchor-goback-expected.png:
- platform/mac/http/tests/navigation/relativeanchor-goback-expected.txt:
- platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.checksum:
- platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.png:
- platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.txt:
- platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.checksum:
- platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.png:
- platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.txt:
- platform/mac/http/tests/navigation/success200-basic-expected.checksum:
- platform/mac/http/tests/navigation/success200-basic-expected.png:
- platform/mac/http/tests/navigation/success200-basic-expected.txt:
- platform/mac/http/tests/navigation/success200-frames-expected.checksum:
- platform/mac/http/tests/navigation/success200-frames-expected.png:
- platform/mac/http/tests/navigation/success200-frames-expected.txt:
- platform/mac/http/tests/navigation/success200-frames-loadsame-expected.checksum:
- platform/mac/http/tests/navigation/success200-frames-loadsame-expected.png:
- platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt:
- platform/mac/http/tests/navigation/success200-goback-expected.checksum:
- platform/mac/http/tests/navigation/success200-goback-expected.png:
- platform/mac/http/tests/navigation/success200-goback-expected.txt:
- platform/mac/http/tests/navigation/success200-loadsame-expected.checksum:
- platform/mac/http/tests/navigation/success200-loadsame-expected.png:
- platform/mac/http/tests/navigation/success200-loadsame-expected.txt:
- platform/mac/http/tests/navigation/success200-reload-expected.checksum:
- platform/mac/http/tests/navigation/success200-reload-expected.png:
- platform/mac/http/tests/navigation/success200-reload-expected.txt:
- platform/mac/http/tests/navigation/success200-subframeload-expected.checksum:
- platform/mac/http/tests/navigation/success200-subframeload-expected.png:
- platform/mac/http/tests/navigation/success200-subframeload-expected.txt:
- platform/mac/http/tests/navigation/timerredirect-basic-expected.checksum:
- platform/mac/http/tests/navigation/timerredirect-basic-expected.png:
- platform/mac/http/tests/navigation/timerredirect-basic-expected.txt:
- platform/mac/http/tests/navigation/timerredirect-frames-expected.checksum:
- platform/mac/http/tests/navigation/timerredirect-frames-expected.png:
- platform/mac/http/tests/navigation/timerredirect-frames-expected.txt:
- platform/mac/http/tests/navigation/timerredirect-goback-expected.checksum:
- platform/mac/http/tests/navigation/timerredirect-goback-expected.png:
- platform/mac/http/tests/navigation/timerredirect-goback-expected.txt:
- platform/mac/http/tests/navigation/timerredirect-subframeload-expected.checksum:
- platform/mac/http/tests/navigation/timerredirect-subframeload-expected.png:
- platform/mac/http/tests/navigation/timerredirect-subframeload-expected.txt:
- platform/mac/svg/custom/inline-svg-in-xhtml-expected.checksum:
- platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
- platform/mac/svg/hixie/mixed/003-expected.checksum:
- platform/mac/svg/hixie/mixed/003-expected.png:
- platform/mac/svg/hixie/mixed/003-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug1188-expected.png:
- platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12384-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug12384-expected.png:
- platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
- platform/mac/tables/mozilla/bugs/bug18359-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug18359-expected.png:
- platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
- platform/mac/tables/mozilla/bugs/bug194024-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug194024-expected.png:
- platform/mac/tables/mozilla/bugs/bug194024-expected.txt:
- platform/mac/tables/mozilla/bugs/bug24200-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug24200-expected.png:
- platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-3-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/mac/tables/mozilla/bugs/bug28928-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug28928-expected.png:
- platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30559-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug30559-expected.png:
- platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30692-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug30692-expected.png:
- platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4382-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug4382-expected.png:
- platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug4527-expected.png:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-1-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-2-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51037-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug51037-expected.png:
- platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
- platform/mac/tables/mozilla/bugs/bug55545-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug55545-expected.png:
- platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
- platform/mac/tables/mozilla/bugs/bug59354-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug59354-expected.png:
- platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
- platform/mac/tables/mozilla/bugs/bug7342-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug7342-expected.png:
- platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
- platform/mac/tables/mozilla/bugs/bug96334-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug96334-expected.png:
- platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
- platform/mac/tables/mozilla/bugs/bug99948-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug99948-expected.png:
- platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
- platform/mac/tables/mozilla/dom/tableDom-expected.checksum:
- platform/mac/tables/mozilla/dom/tableDom-expected.png:
- platform/mac/tables/mozilla/dom/tableDom-expected.txt:
- platform/mac/tables/mozilla/other/move_row-expected.checksum:
- platform/mac/tables/mozilla/other/move_row-expected.png:
- platform/mac/tables/mozilla/other/move_row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.checksum:
- platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
- platform/win/Skipped:
- svg/custom/resources/svg-fonts-in-text-controls.js:
- svg/custom/svg-fonts-in-text-controls-expected.txt:
- svg/custom/svg-fonts-in-text-controls.html: Removed.
- 9:26 PM Changeset in webkit [42697] by
-
- 2 edits in trunk/LayoutTests
2009-04-20 Dimitri Glazkov <Dimitri Glazkov>
Not reviewed, typo fix.
Rename erroneous lines in Skipped to actual test URLs.
- platform/win/Skipped:
- 8:50 PM Changeset in webkit [42696] by
-
- 2 edits in trunk/WebKit/win
Build fix
- MemoryStream.cpp: (MemoryStream::Clone): Fix typo introduced when implementing suggestions from patch review.
- 8:48 PM Changeset in webkit [42695] by
-
- 2 edits in trunk/WebCore
2009-04-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Adam Roben.
One last loose end, discovered using COLLECT_ON_EVERY_ALLOCATION, for
https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::mark): Don't ASSERT that an ElementInstance's correspondingElement has a JS wrapper. If a GC falls exactly between the allocation of the ElementInstance wrapper and the correspondingElement wrapper, the correspondingElement won't have a wrapper at the time we mark the ElementInstance's wrapper.
- 8:45 PM Changeset in webkit [42694] by
-
- 2 edits in trunk/LayoutTests
2009-04-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Roben.
Add Windows failures temporarily to the Skipped list after r42678.
See https://bugs.webkit.org/show_bug.cgi?id=25306 for more
information. This is just to get the tree green while the tests
are fixed.
- platform/win/Skipped:
- 8:42 PM Changeset in webkit [42693] by
-
- 3 edits in trunk/WebKit/win
First part of <rdar://6395825> It takes over 20 sec to launch Safari with 500KB history file
This ports the changes that were made to WebKit/mac's WebHistory
implementation in r25275 to WebKit/win. WebHistory now stores a
HashMap from CFAbsoluteTime (stored as int64_t) to CFArray of
IWebHistoryItem*. The HashMap lets us look up the CFArray for a
particular day's history in constant time rather than linear time. The
precise reasons why we store the CFAbsoluteTime as an int64_t are lost
to the mists of time, but it is likely because these CFAbsoluteTimes
never have a decimal part, and integer comparisons are faster than
floating-point comparisons, so storing them as int64_t should improve
performance without losing precision. We also now use a binary search
instead of a linear search when determining the index at which to
insert a WebHistoryItem into its day's CFArray.
This patch reduces the time needed to load a 100,000-item
History.plist from ~15 seconds to ~7.5 seconds. Further improvements
could likely be made by reducing the number of string conversions,
reducing calls to CFTimeZone functions, and removing all the
WebHistoryItemsAdded notifications that are sent (Mac doesn't send any
while loading history).
Reviewed by Darin Adler.
- WebHistory.cpp: (WebHistoryWriter::WebHistoryWriter): Changed to take a DateToEntriesMap instead of a CFArrayRef. Initialize m_dateKeys to contain the keys from m_entriesByDate in ascending order. (WebHistoryWriter::writeHistoryItems): Now loops through m_dateKeys in reverse order and gets the entries array from the DateToEntriesMap. (WebHistory::WebHistory): Removed code to initialize m_datesWithEntries (which has been removed) and m_entriesByDate (which has been converted to a HashMap). (WebHistory::removeAllItems): Clear out m_entriesByDate and m_orderedLastVisitedDays. (WebHistory::orderedLastVisitedDays): If we don't already have a cached m_orderedLastVisitedDays array, create one by converting the keys from m_entriesByDate to DATEs and sorting them in descending order. Then copy m_orderedLastVisitedDays to the output buffer. (WebHistory::orderedItemsLastVisitedOnDay): Updated to use findKey instead of findIndex and to treat m_entriesByDate as a HashMap. Now that the items in each day's CFArray are stored in descending order (newest to oldest), we don't have to reverse them when filling in the output buffer. (The old comment about putting the items in oldest-to-newest order was incorrect -- it was putting them in newest-to-oldest order.)
(WebHistory::addItemToDateCaches):
(WebHistory::removeItemFromDateCaches):
Changed to use findKey instead of findIndex and to treat
m_entriesByDate as a HashMap. If we're adding a key to or removing a
key from m_entriesByDate, also clear m_orderedLastVisitedDays so that
we will regenerate it for the current set of keys the next time it is
needed.
(timeIntervalForBeginningOfDay): Added. Returns the CFAbsoluteTime
that corresponds to the beginning of the day in which the passed-in
DATE occurs.
(WebHistory::findKey): Returns the key used in m_entriesByDate to
store the CFArray that should contain the IWebHistoryItem that
corresponds to the passed-in DATE. Replaces findIndex.
(WebHistory::insertItem): Changed to treat m_entriesByDate as a
HashMap rather than a CFArray. We now optimize for inserting at the
beginning and end of the array, and use a binary rather than linear
search when inserting into the middle of the array.
(WebHistory::data): Changed to treat m_entriesByDate as a HashMap.
- WebHistory.h: Changed m_entriesByDate to a DateToEntriesMap, removed m_datesWithEntries, added m_orderedLastVisitedDays.
- 8:42 PM Changeset in webkit [42692] by
-
- 9 edits in trunk/WebKit/win
Change MemoryStream::createInstance to return a COMPtr
Part of Bug 25294: All WebKit/win classes should return COMPtrs from
their static constructor members
<https://bugs.webkit.org/show_bug.cgi?id=25294>
Reviewed by Darin Adler.
- MemoryStream.cpp: (MemoryStream::createInstance): Changed to return a COMPtr. (MemoryStream::Clone): Updated for createInstance change.
- MemoryStream.h: Changed createInstance to return a COMPtr.
- WebArchive.cpp: (WebArchive::data):
- WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::didReceiveData):
- WebDataSource.cpp: (WebDataSource::data):
- WebHistory.cpp: (WebHistory::data):
- WebIconFetcher.cpp: (WebIconFetcherClient::finishedFetchingIcon):
- WebResource.cpp: (WebResource::createInstance): Updated for changes to MemoryStream::createInstance.
- 8:42 PM Changeset in webkit [42691] by
-
- 8 edits7 deletes in trunk/WebKit/win
Fix Bug 25295: Remove WebKit/win code that was used for Drosera support
Reviewed by Sam Weinig.
- ForEachCoClass.h: Removed WebScriptDebugServer.
- Interfaces/WebKit.idl: Removed WebScriptDebugServer and references to removed IDL files.
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/WebKit.vcproj: Removed IDL and source files for IWebScriptCallFrame, IWebScriptDebugListener, IWebScriptDebugServer, WebScriptCallFrame, and WebScriptDebugServer.
- WebCoreSupport/WebFrameLoaderClient.cpp:
- WebKitClassFactory.cpp:
- WebKitDLL.cpp: Removed #includes of WebScriptDebugServer.h.
- Interfaces/IWebScriptCallFrame.idl: Removed.
- Interfaces/IWebScriptDebugListener.idl: Removed.
- Interfaces/IWebScriptDebugServer.idl: Removed.
- WebScriptCallFrame.cpp: Removed.
- WebScriptCallFrame.h: Removed.
- WebScriptDebugServer.cpp: Removed.
- WebScriptDebugServer.h: Removed.
- 5:57 PM Changeset in webkit [42690] by
-
- 3 edits in trunk/LayoutTests
2009-04-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel
Fix svg-fonts-in-text-controls.js to measure the
widths after the SVG font has loaded.
For now the expected results have the success line
printed before the metrics being measured. I'll fix
this in a following commit. See
https://bugs.webkit.org/show_bug.cgi?id=25302
for more details.
- svg/custom/resources/svg-fonts-in-text-controls.js:
- svg/custom/svg-fonts-in-text-controls-expected.txt:
- 4:36 PM Changeset in webkit [42689] by
-
- 3 edits3 adds in trunk/JavaScriptCore
More Windows build fixes.
- JavaScriptCore.vcproj/JavaScriptCore.make: Copy DLLs, PDBs.
- JavaScriptCore.vcproj/JavaScriptCore.resources: Added.
- JavaScriptCore.vcproj/JavaScriptCore.resources/Info.plist: Added.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc: Added.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add version stamping, resource copying.
- 3:32 PM Changeset in webkit [42688] by
-
- 2 edits in trunk/WebCore
2009-04-20 Brady Eidson <beidson@apple.com>
Rubberstamped by Mark Rowe
Clean builds are broken on case-sensitive filesystems. Let's fix, shall we?
- platform/graphics/SimpleFontData.cpp: Remove "String.h" include. Ojan probably intended to include "PlatformString.h" which was unnecessary because it is pulled in through other headers. This wasn't a build failure on case-insensitive file systems because those systems would find the system <string.h>, averting the warning.
- 3:32 PM Changeset in webkit [42687] by
-
- 6 edits in trunk/WebCore
2009-04-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Last patch for https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions
Converted "lazy" event listeners to be unprotected, just like all the others.
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener): (WebCore::JSEventListener::jsFunction): (WebCore::JSEventListener::markJSFunction): (WebCore::JSEventListener::handleEvent): (WebCore::JSEventListener::virtualIsInline):
- bindings/js/JSEventListener.h: (WebCore::JSEventListener::isInline): Merged JSAbstractEventListener into JSEventListener. Now that the only difference between JSEventListener and JSLazyEventListener is that JSLazyEventListener compiles lazily, there's no need for an abstract base class.
- bindings/js/JSLazyEventListener.cpp: Converted JSLazyEventListener to inherit from JSEventListener and match its un-GC-protected behavior. (WebCore::JSLazyEventListener::JSLazyEventListener): ditto (WebCore::JSLazyEventListener::parseCode): ditto (WebCore::createInlineEventListener): When creating a lazy event listener, ensure that the related node has a JS wrapper to mark the listener. Since the parser makes these listeners, it's possible that no JS reference has been made to the node yet.
- bindings/js/JSLazyEventListener.h: ditto
- dom/EventListener.h: (WebCore::EventListener::clearJSFunction): Removed an usused function.
- 3:30 PM Changeset in webkit [42686] by
-
- 1 edit in trunk/WebCore/rendering/RenderText.cpp
Fixed typo.
- 3:28 PM Changeset in webkit [42685] by
-
- 2 edits in trunk/WebCore
2009-04-20 Justin Garcia <justin.garcia@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=25299
Don't bound caret to root line box if it is still inside its containing block
Can't yet write tests for behavior of non-standard caret widths.
- rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):
- 2:47 PM Changeset in webkit [42684] by
-
- 1 edit in trunk/WebKit/mac/WebKitPrefix.h
Build fix
- 2:47 PM Changeset in webkit [42683] by
-
- 1 edit in trunk/WebCore/config.h
Build fix
- 2:46 PM Changeset in webkit [42682] by
-
- 1 edit in trunk/JavaScriptGlue/config.h
Build fix
- 2:36 PM Changeset in webkit [42681] by
-
- 5 edits2 adds in trunk
WebKitTools:
2009-04-20 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added PlainTextController.h and PlainTextController.mm.
- DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]): Added PlainTextController as "window.plainText".
- DumpRenderTree/mac/PlainTextController.h: Added.
- DumpRenderTree/mac/PlainTextController.mm: Added.
LayoutTests:
2009-04-20 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
- fast/dom/Window/window-properties.html: Added a new DumpRenderTree window object property, plainText.
- 2:25 PM Changeset in webkit [42680] by
-
- 23 edits2 adds in trunk
2009-04-20 Steve Falkenburg <sfalken@apple.com>
Separate JavaScriptCore.dll from WebKit.dll.
Slight performance improvement or no change on benchmarks.
Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
and simplifies standalone JavaScriptCore builds.
Reviewed by Oliver Hunt.
- API/JSBase.h: Export symbols with JS_EXPORT when using MSVC.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Build JavaScriptCore as a DLL instead of a static library.
- config.h: Specify declspec(dllexport/dllimport) appropriately when exporting data.
- runtime/InternalFunction.h: Specify JS_EXPORTDATA on exported data.
- runtime/JSArray.h: Specify JS_EXPORTDATA on exported data.
- runtime/JSFunction.h: Specify JS_EXPORTDATA on exported data.
- runtime/StringObject.h: Specify JS_EXPORTDATA on exported data.
- runtime/UString.h: Specify JS_EXPORTDATA on exported data.
WebCore:
2009-04-20 Steve Falkenburg <sfalken@apple.com>
Separate JavaScriptCore.dll from WebKit.dll.
Slight performance improvement or no change on benchmarks.
Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
and simplifies standalone JavaScriptCore builds.
Reviewed by Oliver Hunt.
- config.h: Specify declspec(dllexport/dllimport) appropriately when exporting data.
WebKit/cf:
2009-04-20 Steve Falkenburg <sfalken@apple.com>
Separate JavaScriptCore.dll from WebKit.dll.
Slight performance improvement or no change on benchmarks.
Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
and simplifies standalone JavaScriptCore builds.
Reviewed by Oliver Hunt.
- WebCoreSupport/WebInspectorClientCF.cpp: Workaround for lack of config.h in shared WebKit file (WebKit/win uses config.h from WebCore).
WebKit/win:
2009-04-20 Steve Falkenburg <sfalken@apple.com>
Separate JavaScriptCore.dll from WebKit.dll.
Slight performance improvement or no change on benchmarks.
Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
and simplifies standalone JavaScriptCore builds.
Reviewed by Oliver Hunt.
- WebKit.vcproj/WebKit.def: Mark JavaScriptCore re-exports as deprecated.
- WebKit.vcproj/WebKit.vcproj: Link against JavaScriptCore.dll
- WebKit.vcproj/WebKit_debug.def: Mark JavaScriptCore re-exports as deprecated.
WebKitLibraries:
2009-04-20 Steve Falkenburg <sfalken@apple.com>
Separate JavaScriptCore.dll from WebKit.dll.
Slight performance improvement or no change on benchmarks.
Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
and simplifies standalone JavaScriptCore builds.
Reviewed by Oliver Hunt.
- win/tools/vsprops/common.vsprops: Add BUILDING_{project} preprocessor define.
WebKitTools:
2009-04-20 Steve Falkenburg <sfalken@apple.com>
Separate JavaScriptCore.dll from WebKit.dll.
Slight performance improvement or no change on benchmarks.
Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
and simplifies standalone JavaScriptCore builds.
Reviewed by Oliver Hunt.
- DumpRenderTree/config.h: Specify JS, WebKit exported data as declspec(dllimport)
- DumpRenderTree/win/DumpRenderTree.vcproj: Link against JavaScriptCore.dll
- 1:41 PM Changeset in webkit [42679] by
-
- 18 edits in trunk
WebCore:
2009-04-20 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/6722845> In the Cocoa event model, NPWindow's window field should be null
- bridge/npapi.h: (_NPCocoaEvent::): Add a CGContextRef member to the draw struct. Add an NPCoordinateSpace enum.
- plugins/npfunctions.h: Add a prototype for NPN_ConvertPoint.
WebKit/mac:
2009-04-17 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/6722845>
In the Cocoa event model, NPWindow's window field should be null
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCConvertPoint): Get the instance proxy and call it's convertPoint function.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::convertPoint): Call convertPoint on the plug-in view.
- Plugins/Hosted/WebKitPluginClient.defs: Add PCConvertPoint.
- Plugins/WebBaseNetscapePluginView.h: Add a declaration for convertFromX:andY:space:toX:andY:space:.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]): Convert a point from one coordinate system to another.
- Plugins/WebNetscapePluginEventHandler.h:
- Plugins/WebNetscapePluginEventHandlerCarbon.h:
- Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::drawRect):
- Plugins/WebNetscapePluginEventHandlerCocoa.h: Add CGContextRef to drawRect.
- Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::drawRect): Set the passed in context.
- Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _tryLoad]): Add NPN_ConvertPoint to the browserFuncs vtable.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): Only set the window for the Carbon event model.
(-[WebNetscapePluginView restorePortState:]):
It's OK for the window context to be null.
(-[WebNetscapePluginView sendDrawRectEvent:]):
Pass the CGContextRef to drawRect.
- Plugins/npapi.mm: (NPN_ConvertPoint): Call the plug-in view method.
- 12:52 PM QtWebKitTodo edited by
- (diff)
- 12:49 PM Changeset in webkit [42678] by
-
- 546 edits10 adds in trunk
Reviewed by Dan Bernstein.
Make textarea and text input metrics more closely match IEs.
https://bugs.webkit.org/show_bug.cgi?id=15312
This involves:
-set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
-set textarea width to cols*avgCharWidth
-Make default CSS match IEs
-Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.
Those values for textarea and inputs were derived by doing a ton of manual
testing of IE's width values for various textareas and fonts.
To get the average and max character width of a font, we do the following
for each platform:
-Win: TextMetrics expose avgCharWidth and maxCharWidth
-SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
-Linux: avgCharWidth = width of an '0', fallback on m_xHeight
maxCharWidth = max of avgCharWidth and m_ascent
-Mac: look in the OS/2 table for avgCharWidth and grab the maxCharWidth off the font.
If either one is not there, then calculate the value using the Linux approach.
Linux ports could probably dig into the OS/2 table as well, but I'll leave
that up to them to implement.
Tests: fast/forms/text-control-intrinsic-widths.html
fast/forms/textarea-metrics.html
svg/custom/svg-fonts-in-text-controls.html
- css/html4.css:
- css/themeWin.css:
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::initCharWidths):
- platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::maxCharWidth): (WebCore::SimpleFontData::avgCharWidth):
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont):
- platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth):
- 12:13 PM QtWebKitContrib edited by
- (diff)
- 12:10 PM Changeset in webkit [42677] by
-
- 10 edits in trunk/WebCore
Reviewed by Simon Fraser.
Remove m_absoluteBounds hack from SVG renderers and move outlineBoundsForRepaint into RenderSVGModelObject
https://bugs.webkit.org/show_bug.cgi?id=25276
This also exposed a buggy paint check in RenderSVGContainer::layout()
we should repaint if we are self painting OR if our kids changed, not AND.
Writing real outlineBoundsForRepaint required writing a mapLocalToContainer() function
No functional changes, thus no tests.
- rendering/RenderPath.cpp: (WebCore::RenderPath::localToParentTransform): (WebCore::RenderPath::layout):
- rendering/RenderPath.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::mapLocalToContainer): (WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
- rendering/RenderSVGModelObject.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::localToParentTransformWithoutCSSParentOffset): (WebCore::RenderSVGRoot::localToParentTransform): (WebCore::RenderSVGRoot::computeRectForRepaint):
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::layout):
- 11:12 AM Changeset in webkit [42676] by
-
- 5 edits in trunk/JavaScriptCore
2009-04-20 Sam Weinig <sam@webkit.org>
Reviewed by Kevin McCullough.
Always tag mmaped memory on darwin and clean up #defines
now that they are a little bigger.
- interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile):
- jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
- jit/ExecutableAllocatorPosix.cpp: (JSC::ExecutablePool::systemAlloc):
- runtime/Collector.cpp: (JSC::allocateBlock):
- 11:11 AM Changeset in webkit [42675] by
-
- 3 edits10 adds in trunk
2009-04-20 Simon Fraser <Simon Fraser>
Reviewed by Eric Seidel
outlineBoundsForRepaint() should compute a quad relative to the
repaintContainer. This fixes the repaint issues originally fixed in
https://bugs.webkit.org/show_bug.cgi?id=12885 for elements in compositing layers.
Failure was only apparent when building with ACCELERATED_COMPOSITING enabled.
Tests: compositing/repaint/content-into-overflow.html
compositing/repaint/overflow-into-content.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::outlineBoundsForRepaint):
- 11:06 AM Changeset in webkit [42674] by
-
- 29 edits in trunk
2009-04-20 Sam Weinig <sam@webkit.org>
Rubber-stamped by Tim Hatcher.
Add licenses for xcconfig files.
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/JavaScriptCore.xcconfig:
- Configurations/Version.xcconfig:
JavaScriptGlue:
2009-04-20 Sam Weinig <sam@webkit.org>
Rubber-stamped by Tim Hatcher.
Add licenses for xcconfig files.
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/JavaScriptGlue.xcconfig:
- Configurations/Version.xcconfig:
WebCore:
2009-04-20 Sam Weinig <sam@webkit.org>
Rubber-stamped by Tim Hatcher.
Add licenses for xcconfig files.
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebCore.xcconfig:
WebKit/mac:
2009-04-20 Sam Weinig <sam@webkit.org>
Rubber-stamped by Tim Hatcher.
Add licenses for xcconfig files.
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebKit.xcconfig:
WebKitTools:
2009-04-20 Sam Weinig <sam@webkit.org>
Rubber-stamped by Tim Hatcher.
Add licenses for xcconfig files.
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
- DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
- DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
- 10:31 AM Changeset in webkit [42673] by
-
- 5 edits in trunk/WebKit/mac
2009-04-20 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
WebKit side of <rdar://problem/6781302>
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::keyEvent): Pass the event keyChar.
(WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
Ditto.
(WebKit::NetscapePluginInstanceProxy::flagsChanged):
Pass a 0 keyChar.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView flagsChanged:]): Call NetscapePluginInstanceProxy::flagsChanged.
- Plugins/Hosted/WebKitPluginHost.defs: Add a keyChar argument.
- 10:16 AM Changeset in webkit [42672] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=24786
WebKitDownload sometimes suggests peculiar filenames
Remove query and ref from the URI that is to be downloaded when
using it to provide a file name suggestion.
- webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_set_property):
- 8:27 AM Changeset in webkit [42671] by
-
- 3 edits in trunk/WebCore
2009-04-20 Eric Roman <eroman@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25261
Implement the V8 binding for DOMWindow.event similarly to JSC, by using
the custom getter boilerplate from the IDL file.
Also, stub out DOMWindow.crypto which is defined by the idl.
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_GETTER):
- 8:23 AM Changeset in webkit [42670] by
-
- 4 edits in trunk
WebCore
2009-04-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25243
Crash when data:// loads are cancelled
Properly handle cancellation of the load for data:// loads. This
fixes crashing in the followin test:
plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
WebKit/gtk
2009-04-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Handle the case when the plugin view is destroyed during
didReceiveResponse, to avoid crashing.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad):
- 7:30 AM QtWebKitTodo edited by
- (diff)
- 7:11 AM QtWebKitTodo edited by
- (diff)
- 6:24 AM QtWebKitJournal edited by
- (diff)
- 6:17 AM QtWebKitTodo edited by
- (diff)
- 2:27 AM Changeset in webkit [42669] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-20 Ariya Hidayat <ariya.hidayat@nokia.com>
Build fix for Qt port (after r42646). Not reviewed.
- wtf/unicode/qt4/UnicodeQt4.h: Added U16_PREV.
Apr 19, 2009:
- 11:25 PM Changeset in webkit [42668] by
-
- 2 edits in trunk/WebKit/mac
2009-04-19 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/6804809> REGRESSION: In Mail, Home and End do not scroll message
If no scrolling occurs, call tryToPerform on the next responder. Then our WebResponderChainSink
will correctly detect if no responders handle the selector.
- WebView/WebFrameView.mm: (-[WebFrameView _scrollToBeginningOfDocument]): (-[WebFrameView _scrollToEndOfDocument]): (-[WebFrameView scrollToBeginningOfDocument:]): (-[WebFrameView scrollToEndOfDocument:]): (-[WebFrameView scrollLineUp:]): (-[WebFrameView scrollLineDown:]):
- 10:47 PM Changeset in webkit [42667] by
-
- 2 edits in trunk/WebCore
- maybe fix release builds
- dom/ScriptElement.cpp: (WebCore::ScriptElementData::notifyFinished):
- 10:27 PM Changeset in webkit [42666] by
-
- 2 edits in trunk/WebCore
- fix release builds
- dom/Document.cpp: (WebCore::Document::executeScriptSoonTimerFired):
- 9:20 PM Changeset in webkit [42665] by
-
- 12 edits3 adds in trunk
WebCore:
Reviewed by Mark Rowe.
- fix <rdar://problem/6734365> REGRESSION eBay "Save this search" link does nothing the second time search results are opened
Test: fast/dom/HTMLScriptElement/nested-execution.html
Instead of executing scripts as soon as they finish loading, which may
happen synchronously during execution of another script, defer their
execution until the next run loop iteration, using a queue that is
similar to the HTML5 notion of the "list of scripts that will execute as
soon as possible", and in my testing was consistent with how Firefox
behaved.
- dom/Document.cpp: (WebCore::Document::Document): Initialize m_executeScriptSoonTimer. (WebCore::Document::~Document): deref() script elements in m_scriptsToExecuteSoon. (WebCore::Document::executeScriptSoonTimerFired): Added. Executes the scripts in m_scriptsToExecuteSoon and deref()s them. (WebCore::Document::executeScriptSoon): Added. Appends to m_scriptsToExecuteSoon and ref()s the script element, which keeps the ScriptElementData alive as well.
- dom/Document.h:
- dom/ScriptElement.cpp: (WebCore::ScriptElementData::ScriptElementData): Initialize m_requested. (WebCore::ScriptElementData::requestScript): Set m_requested to true, to prevent further load requests. (WebCore::ScriptElementData::execute): Added. Moved the code from notifyFinished() which should not execute synchronously here, to be called by the Document on a 0-interval timer. (WebCore::ScriptElementData::notifyFinished): Moved the code to dispatch events and evaluate the script, which should not execute synchronously, out of here. (WebCore::ScriptElementData::ignoresLoadRequest): Changed to test for m_requested instead of m_cachedScript, because the latter is cleared before the script is evaluated.
- dom/ScriptElement.h:
LayoutTests:
Reviewed by Mark Rowe.
- test and updated tests for <rdar://problem/6734365> eBay "Save this search" link does nothing the second time search results are opened
- fast/dom/HTMLScriptElement/nested-execution-expected.txt: Added.
- fast/dom/HTMLScriptElement/nested-execution.html: Added.
- fast/dom/HTMLScriptElement/resources/nested-execution.js: Added.
- fast/dom/HTMLScriptElement/script-reexecution.html:
- fast/dom/HTMLScriptElement/script-set-src.html:
- fast/dom/script-element-gc.html:
- fast/loader/local-JavaScript-from-local.html:
- svg/dom/SVGScriptElement/script-reexecution.svg:
- svg/dom/SVGScriptElement/script-set-href.svg:
- 6:31 PM Changeset in webkit [42664] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6127705> Excessive memory consumption on image load failure
Reviewed by Antti Koivisto and Darin Adler
When we fail to decode an image we clear most of the image data, but not the
input data itself, which can be backed by a CFData object that itself holds onto
a few hundred Kbs of memory. This patch merely ensures that this buffer gets
cleared.
- 4:38 PM Changeset in webkit [42663] by
-
- 2 edits in trunk/WebKit
2009-04-19 Darin Adler <Darin Adler>
- StringsNotToBeLocalized.txt: Updated for recent changes.
- 3:54 PM Changeset in webkit [42662] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-19 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Better fix for JSStringCreateWithCFString hardening.
- API/JSStringRefCF.cpp: (JSStringCreateWithCFString):
- 3:48 PM Changeset in webkit [42661] by
-
- 1 edit in trunk/WebCore/ChangeLog
ooo
- 3:47 PM Changeset in webkit [42660] by
-
- 5 edits in trunk/WebCore
2009-04-19 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Add hoooks so sudden termination will not cause loss of icons or local storage.
rdar://problem/5951701
- loader/icon/IconDatabase.cpp: Marked various constants static to give them internal linkage. (WebCore::IconDatabase::IconDatabase): Added initial value for m_syncTimer. Removed unneeded initial value for m_defaultIconRecord. Changed assertion to work cross-platform. (WebCore::IconDatabase::wakeSyncThread): Added disableSuddenTermination, so we won't terminate until the sync thread has done its thing. (WebCore::IconDatabase::scheduleOrDeferSyncTimer): Added disableSuddenTermination, so we won't terminate if we have an outstanding sync timer. (WebCore::IconDatabase::syncTimerFired): Added enableSuddenTermination, to balance the one in scheduleOrDeferSyncTimer. (WebCore::IconDatabase::syncThreadMainLoop): Added enableSuddenTermination, to balance the one in wakeSyncThread. (WebCore::IconDatabase::deleteAllPreparedStatements): Use clear() instead of set(0).
- loader/icon/IconDatabase.h: Use a Timer instead of an OwnPtr<Timer>.
- storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::scheduleFinalSync): Added disableSuddenTermination. (WebCore::LocalStorageArea::scheduleItemForSync): Ditto. (WebCore::LocalStorageArea::scheduleClear): Ditto. (WebCore::LocalStorageArea::syncTimerFired): Added a disableSuddenTermination if we schedule a performSync callback for later and an unconditional enableSuddenTermination to balance the ones in the schedule calls above. (WebCore::LocalStorageArea::sync): Factored out the work of the sync function so it can continue to use early return idiom. (WebCore::LocalStorageArea::performSync): Added a call to enableSuddenTermination.
- storage/LocalStorageArea.h: Added declaration of the sync function.
- 3:26 PM Changeset in webkit [42659] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-19 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/5860954>
Harden JSStringCreateWithCFString against malformed CFStringRefs.
- API/JSStringRefCF.cpp: (JSStringCreateWithCFString):
- 10:05 AM Changeset in webkit [42658] by
-
- 8 edits in trunk
Make FEATURE_DEFINES completely dynamic
Reviewed by Darin Adler.
Make FEATURE_DEFINES depend on individual ENABLE_FEATURE_NAME
variables for each feature, making it possible to remove all
knowledge of FEATURE_DEFINES from build-webkit.
- Configurations/FeatureDefines.xcconfig: Extract a variable from FEATURE_DEFINES for each feature setting.
WebCore:
- Configurations/FeatureDefines.xcconfig: Extract a variable from FEATURE_DEFINES for each feature setting.
WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Extract a variable from FEATURE_DEFINES for each feature setting.
WebKitTools:
- Scripts/build-webkit: Define individual ENABLE_FEATURE_NAME variables instead of the whole FEATURE_DEFINES string when building with Xcode. Miscellaneous clean up:
- Reordered/sorted command-line switch variables.
- Reordered/sorted command-line switches in $usage.
- Reordered/sorted command-line switches in GetOptions().
- Defined $svgSupport to true if any --svg-feature switch is set in order to match "Implies SVG Support" claim.
- Build JavaScriptGlue after JavaScriptCore again!
- Fixed --[no-]geolocation for GTK+ port and sorted GTK+ command-line switches.
- Added "exit 0" statement at the end of the script.
- 12:38 AM Changeset in webkit [42657] by
-
- 6 edits in trunk/WebCore
2009-04-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Alexey Proskuryakov.
More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions
Removed a little more complexity from event handler creation and destruction.
Removed the jsProtectedEventListeners, jsProtectedInlineEventListeners,
and jsInlineEventListeners maps, and all the code for managing them.
ProtectedEventListeners don't exist anymore, so they're easy to nix.
Inline EventListeners do still exist, but there's no reason to track
them in a map. The map exists to enable 'removeEventListener' to associate
a unique JSEventListener with a given JavaScript function. But the
'removeEventListener' API only works with non-inline event listeners!
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener): (WebCore::JSDOMGlobalObject::createJSInlineEventListener):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::clearJSFunctionInline):
- bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::~JSLazyEventListener): (WebCore::JSLazyEventListener::parseCode):
- bindings/scripts/CodeGeneratorJS.pm:
Apr 18, 2009:
- 11:42 PM Changeset in webkit [42656] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-18 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix typo. s/VM_MEMORY_JAVASCRIPT_JIT_REGISTER_FILE/VM_MEMORY_JAVASCRIPT_CORE/
- runtime/Collector.cpp: (JSC::allocateBlock): Fix bozo typo.
- 11:39 PM Changeset in webkit [42655] by
-
- 2 edits in trunk/WebCore
- try to fix the Windows build
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter):
- 11:29 PM Changeset in webkit [42654] by
-
- 2 edits in trunk/WebCore
- revert the previous change, which was to a file that the Windows port does not even use
- icu/unicode/utf16.h:
- 11:17 PM Changeset in webkit [42653] by
-
- 2 edits in trunk
Fix the dates in my Changelog entries
- 10:28 PM Changeset in webkit [42652] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoffrey Garen.
- try to fix the Windows build
- icu/unicode/utf16.h:
- 10:00 PM Changeset in webkit [42651] by
-
- 6 edits4 adds in trunk
2009-04-17 Simon Fraser <Simon Fraser>
Reviewed by Antti Koivisto.
When a <video> element gained a RenderLayer via opacity, reflection etc., the
layer hierarchy was not correctly updated because RenderMedia skipped a level
when asked for its children; it skipped m_controlsShadowRoot's renderer, which
actually has a layer.
Test: fast/layers/video-layer.html
- rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): Don't manually call setParent() on the renderer. It will happen later as a result of addChild().
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::createControlsShadowRoot): Add m_controlsShadowRoot's renderer as a child.
- rendering/RenderMedia.h: (WebCore::RenderMedia::children): Now maintain a RenderObjectChildList, m_children, and remove the unneeded removeChild() method. Make the two children() methods inline.
- rendering/RenderObject.cpp: (WebCore::RenderObject::moveLayers): Assert if moveLayers() is called with an oldParent that is not the layer's actual parent (which would have revealed this bug).
- 9:58 PM Changeset in webkit [42650] by
-
- 3 edits in trunk/WebCore
2009-04-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Fixed a layout test failure, caused by my last check-in
(fast/dom/script-element-gc.html).
- bindings/js/JSDOMBinding.cpp: (WebCore::isObservableThroughDOM):
- html/HTMLScriptElement.h: (WebCore::HTMLScriptElement::haveFiredLoadEvent): Treat script elements just like image elements: if a script element is loading, mark its JS wrapper, even if the element is not in the document.
- 7:14 PM Changeset in webkit [42649] by
-
- 5 edits in trunk/JavaScriptCore
2009-04-18 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix for <rdar://problem/6801555> Tag JavaScript memory on SnowLeopard
- interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile):
- jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
- jit/ExecutableAllocatorPosix.cpp: (JSC::ExecutablePool::systemAlloc):
- runtime/Collector.cpp: (JSC::allocateBlock):
- 6:40 PM Changeset in webkit [42648] by
-
- 3 edits2 adds in trunk/WebCore
2009-04-18 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25170
Upstream V8WorkerCustom.cpp and V8WorkerContextCustom.cpp for V8 bindings.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
- bindings/v8/WorkerContextExecutionProxy.h:
- bindings/v8/custom/V8WorkerContextCustom.cpp: Added.
- bindings/v8/custom/V8WorkerCustom.cpp: Added.
- 6:40 PM Changeset in webkit [42647] by
-
- 3 edits2 moves in trunk/WebCore
2009-04-18 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/post_bug.cg://bugs.webkit.org/show_bug.cgi?id=25167
Change createHiddenXHRDependency and removeHiddenXHRDependency so that they can be used by other custom code in V8 bindings.
- bindings/v8/V8Utilities.cpp: Renamed from WebCore/bindings/v8/V8XMLHttpRequestUtilities.cpp. (WebCore::createHiddenDependency): (WebCore::removeHiddenDependency):
- bindings/v8/V8Utilities.h: Renamed from WebCore/bindings/v8/V8XMLHttpRequestUtilities.h.
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- 6:19 PM Changeset in webkit [42646] by
-
- 8 edits in trunk
2009-04-18 Drew Wilson <amw@apple.com>
<rdar://problem/6781407> VisiblePosition.characterAfter should return UChar32
Reviewed by Dan Bernstein.
- wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::hasLineBreakingPropertyComplexContextOrIdeographic): Added.
WebCore:
No test case since there is no change in behavior.
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter): Now handles surrogate pairs correctly and returns a UChar32.
- editing/VisiblePosition.h: (WebCore::VisiblePosition::characterBefore): Now returns a UChar32.
- editing/visible_units.cpp: (WebCore::endOfFirstWordBoundaryContext): Renamed firstNonComplexContextLineBreak() to this. Changed it to use the generic requiresContextForWordBoundary() instead of hasLineBreakingPropertyComplexContext(). (WebCore::startOfLastWordBoundaryContext): Replaces lastNonComplexContextLineBreak(), but returns the offset of the character after the last character that does not require context for word breaking. Also changed to use requiresContextForWordBoundary(). (WebCore::previousBoundary): Updated for the above changes in names and semantics, and changed to use requiresContextForWordBoundary(). (WebCore::nextBoundary): Ditto. (WebCore::startWordBoundary): Ditto. (WebCore::endWordBoundary): Ditto. (WebCore::previousWordPositionBoundary): Ditto. (WebCore::nextWordPositionBoundary): Ditto.
- platform/text/TextBoundaries.h: (WebCore::requiresContextForWordBoundary): Added.
- platform/text/mac/TextBoundaries.mm:
- 6:00 PM Changeset in webkit [42645] by
-
- 3 edits3 adds in trunk
WebCore:
2009-04-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Fixed <rdar://problem/6797442> | https://bugs.webkit.org/show_bug.cgi?id=25285
REGRESSION (r42569): Profiles cannot be selected in inspector profiler
EventListeners are shared; RegisteredEventListeners are not. Therefore,
when a node wrapper needs to invalidate the node's JS event listeners,
it should invalidate its RegisteredEventListeners, not its EventListeners.
Otherwise, it might invalidate an EventListener shared by another node.
- dom/RegisteredEventListener.h: (WebCore::invalidateEventListeners): ditto
LayoutTests:
2009-04-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Test for <rdar://problem/6797442> | https://bugs.webkit.org/show_bug.cgi?id=25285
REGRESSION (r42569): Profiles cannot be selected in inspector profiler
- fast/events/event-listener-sharing-expected.txt: Added.
- fast/events/event-listener-sharing.html: Added.
- fast/events/resources/event-listener-sharing.js: Added. (gc): (clickHandler):
- 4:50 PM Changeset in webkit [42644] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-18 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix for <rdar://problem/5861045>
A little bit of hardening for UString.
- runtime/UString.cpp: (JSC::concatenate): (JSC::UString::append):
- 3:50 PM Changeset in webkit [42643] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-18 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe and Dan Bernstein.
Fix for <rdar://problem/5861188>
A little bit of hardening for Vector.
- wtf/Vector.h: (WTF::Vector<T, inlineCapacity>::append): (WTF::Vector<T, inlineCapacity>::insert):
- 1:29 PM Changeset in webkit [42642] by
-
- 11 edits in trunk
2009-04-18 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Mark Rowe.
<rdar://problem/6781295> video.buffered and video.seekable are not
the same.
- WebCore.base.exp: Added wkQTMovieMaxTimeSeekable.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::maxTimeSeekable): Return wkQTMovieMaxTimeSeekable.
- platform/mac/WebCoreSystemInterface.h: Add wkQTMovieMaxTimeSeekable.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
2009-04-18 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Mark Rowe.
<rdar://problem/6781295> video.buffered and video.seekable are not
the same.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Add wkQTMovieMaxTimeSeekable.
2009-04-18 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Mark Rowe.
<rdar://problem/6781295> video.buffered and video.seekable are not
the same.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 12:11 PM Changeset in webkit [42641] by
-
- 11 edits in trunk
2009-04-18 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Mark Rowe.
<rdar://problem/6747241> work around QTKit no longer reaching
QTMovieLoadStateComplete
- WebCore.base.exp: Export wkQTMovieMaxTimeLoadedChangeNotification.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): observe QTMovieMaxTimeLoadedChangeNotification. (WebCore::MediaPlayerPrivate::updateStates): compare duuration() with maxTimeLoaded() instead of using QTMovieLoadStateComplete to determine if a movie are fully loaded.
- platform/mac/WebCoreSystemInterface.h: Add wkQTMovieMaxTimeLoadedChangeNotification.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
2009-04-18 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Mark Rowe.
<rdar://problem/6747241> work around QTKit no longer reaching
QTMovieLoadStateComplete
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Init the new WKSI exported symbol.
- 11:49 AM Changeset in webkit [42640] by
-
- 4 edits in trunk/LayoutTests
2009-04-18 Justin Garcia <justin.garcia@apple.com>
Updated test results for https://bugs.webkit.org/show_bug.cgi?id=25277
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.checksum:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- 4:49 AM Changeset in webkit [42639] by
-
- 6 edits in trunk
2009-04-18 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
Make WML work again, most regressions test were failing.
Apr 17, 2009:
- 9:44 PM Changeset in webkit [42638] by
-
- 4 edits1 add in trunk/JavaScriptCore
2009-04-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
On x86_64, make all JIT-code allocations from a new heap, managed
by FixedVMPoolAllocator. This class allocates a single large (2Gb)
pool of virtual memory from which all further allocations take place.
Since all JIT code is allocated from this pool, we can continue to
safely assume (as is already asserted) that it will always be possible
to link any JIT-code to JIT-code jumps and calls.
- JavaScriptCore.xcodeproj/project.pbxproj:
Add new file.
- jit/ExecutableAllocatorFixedVMPool.cpp: Added. (JSC::FreeListEntry::FreeListEntry): (JSC::AVLTreeAbstractorForFreeList::get_less): (JSC::AVLTreeAbstractorForFreeList::set_less): (JSC::AVLTreeAbstractorForFreeList::get_greater): (JSC::AVLTreeAbstractorForFreeList::set_greater): (JSC::AVLTreeAbstractorForFreeList::get_balance_factor): (JSC::AVLTreeAbstractorForFreeList::set_balance_factor): (JSC::AVLTreeAbstractorForFreeList::null): (JSC::AVLTreeAbstractorForFreeList::compare_key_key): (JSC::AVLTreeAbstractorForFreeList::compare_key_node): (JSC::AVLTreeAbstractorForFreeList::compare_node_node): (JSC::sortFreeListEntriesByPointer): (JSC::sortCommonSizedAllocations): (JSC::FixedVMPoolAllocator::release): (JSC::FixedVMPoolAllocator::reuse): (JSC::FixedVMPoolAllocator::addToFreeList): (JSC::FixedVMPoolAllocator::coalesceFreeSpace): (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator): (JSC::FixedVMPoolAllocator::alloc): (JSC::FixedVMPoolAllocator::free): (JSC::ExecutableAllocator::intializePageSize): (JSC::ExecutablePool::systemAlloc): (JSC::ExecutablePool::systemRelease):
The new 2Gb heap class!
- jit/ExecutableAllocatorPosix.cpp:
Disable use of this implementation on x86_64.
- wtf/AVLTree.h:
Add missing variable initialization.
(WTF::::remove):
- 7:23 PM Changeset in webkit [42637] by
-
- 4 edits in trunk/LayoutTests/platform/mac/fast/inline
Accidently checked in outdated pixel results.
- 7:04 PM Changeset in webkit [42636] by
-
- 3 edits3 adds in trunk
Fix bug where the VM reentry cache would not correctly unroll the cached callframe
Reviewed by Darin Adler
Fix a check that was intended to mark a cached call as invalid when the callframe could
not be constructed. Instead it was just checking that there was a place to put the
exception. This eventually results in a non-recoverable RegisterFile starvation.
- 6:59 PM Changeset in webkit [42635] by
-
- 1 edit in trunk/WebCore/rendering/RenderText.cpp
Forgot to uncomment some code before checking in.
- 6:53 PM Changeset in webkit [42634] by
-
- 3 edits8 adds in trunk
WebCore:
2009-04-17 Justin Garcia <justin.garcia@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=25277
If there is no line wrapping, a caret can leave its containing block but it shouldn't leave its root line box
Also added code to handle a caret wider than one pixel.
Added fast/inline/25277.html and fast/inline/25277-2.html
- rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect): Distribute a caret's width to either side of the offset, so that a caret between two characters doesn't hang over one character more than the other. If there is no wrapping, the caret can leave its containing block, but not its root line box.
LayoutTests:
2009-04-17 Justin Garcia <justin.garcia@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=25277
If there is no line wrapping, a caret can leave its containing block but it shouldn't leave its root line box
- fast/inline/25277-2.html: Added.
- fast/inline/25277.html: Added.
- platform/mac/fast/inline/25277-2-expected.checksum: Added.
- platform/mac/fast/inline/25277-2-expected.png: Added.
- platform/mac/fast/inline/25277-2-expected.txt: Added.
- platform/mac/fast/inline/25277-expected.checksum: Added.
- platform/mac/fast/inline/25277-expected.png: Added.
- platform/mac/fast/inline/25277-expected.txt: Added.
- 6:31 PM Changeset in webkit [42633] by
-
- 40 edits in trunk/WebCore
2009-04-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions
Some refactoring of "inline" event listeners.
Renames:
dispatchEventForType => dispatchEvent
setWindowInlineEventListenerForTypeAndAttribute => setWindowInlineEventListener
removeInlineEventListenerForType => clearInlineEventListener
setInlineEventListenerForType => setInlineEventListener
inlineEventListenerForType => getInlineEventListener
- bindings/js/JSLazyEventListener.cpp: (WebCore::eventParameterName): (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::createInlineEventListener):
- bindings/js/JSLazyEventListener.h: Added two helper functions for creating "inline" event listeners. These replace Document::createEventListener, and abstract the creation of JS event listeners for DOM attributes out of the DOM. Removed legacy JSProtectedEventListener constructor code for adding the event listener's function to a map, since lazy event listeners don't have functions at construction time.
- dom/Document.cpp: (WebCore::Document::setFocusedNode):
- dom/Document.h: (WebCore::Document::isSVGDocument):
- dom/Element.cpp: (WebCore::Element::setWindowInlineEventListener):
- dom/Element.h: Updated for renames. Nixed Document::createEventListener, mentioned above. Moved setWindowInlineEventListenerForTypeAndAttribute to Element, for simplicity.
- dom/InputElement.cpp: (WebCore::InputElement::setValueFromRenderer):
- dom/Node.cpp: (WebCore::Node::dispatchFocusEvent): (WebCore::Node::dispatchBlurEvent): (WebCore::Node::dispatchEvent): (WebCore::Node::clearInlineEventListener): (WebCore::Node::setInlineEventListener): (WebCore::Node::getInlineEventListener): (WebCore::Node::onabort): (WebCore::Node::setOnabort): (WebCore::Node::etc.):
- dom/Node.h: Updated for renames.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Updated for renames.
Updated these files for renames, and to use the new createInlineEventListener
helper function:
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
- html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::parseMappedAttribute):
- html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::onChange):
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareSubmit): (WebCore::HTMLFormElement::reset): (WebCore::HTMLFormElement::parseMappedAttribute):
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute):
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute):
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute):
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::onSearch):
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadInternal):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute):
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute): (WebCore::HTMLScriptElement::dispatchLoadEvent): (WebCore::HTMLScriptElement::dispatchErrorEvent):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::notifyFinished):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::mouseButtonListener):
- page/DOMWindow.cpp:
- page/DOMWindow.h: (WebCore::DOMWindow::eventListeners):
- page/EventHandler.cpp: (WebCore::EventHandler::canMouseDownStartSelect): (WebCore::EventHandler::canMouseDragExtendSelect): (WebCore::EventHandler::sendScrollEvent):
- page/Page.cpp: (WebCore::networkStateChanged):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::valueChanged):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selectionChanged):
- svg/SVGElement.cpp: (WebCore::SVGElement::parseMappedAttribute):
- svg/SVGElementInstance.cpp:
- svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::dispatchLoadEvent):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute):
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::dispatchErrorEvent):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
- 4:52 PM Changeset in webkit [42632] by
-
- 11 edits in trunk/WebKit/mac
2009-04-17 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6714488>
REGRESSION (Safari 3-4): Edit menu commands (cut/copy/paste/select all) do not work on Flash content
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier): Send a keyDown event to the plug-in host.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView sendModifierEventWithKeyCode:character:]): Call the plug-in instance proxy.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendModifierEventWithKeyCode:character:]): Add this. Subclasses are required to override it.
(-[WebBaseNetscapePluginView cut:]):
(-[WebBaseNetscapePluginView copy:]):
(-[WebBaseNetscapePluginView paste:]):
(-[WebBaseNetscapePluginView selectAll:]):
Call sendModifierEventWithKeyCode.
- Plugins/WebNetscapePluginEventHandler.h: Add syntheticKeyDownWithCommandModifier.
- Plugins/WebNetscapePluginEventHandlerCarbon.h:
- Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::syntheticKeyDownWithCommandModifier): Send the synthetic event.
- Plugins/WebNetscapePluginEventHandlerCocoa.h:
- Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier): Send the synthetic event.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendModifierEventWithKeyCode:character:]): Call the event handler.
- 4:11 PM Changeset in webkit [42631] by
-
- 13 edits3 adds in trunk
Simplify FEATURE_DEFINES definition
Reviewed by Darin Adler.
This moves FEATURE_DEFINES and its related ENABLE_FEATURE_NAME
variables to their own FeatureDefines.xcconfig file. It also
extracts a new ENABLE_GEOLOCATION variable so that
FEATURE_DEFINES only needs to be defined once.
- Configurations/FeatureDefines.xcconfig: Added.
- Configurations/JavaScriptCore.xcconfig: Removed definition of ENABLE_SVG_DOM_OBJC_BINDINGS and FEATURE_DEFINES. Added include of FeatureDefines.xcconfig.
- JavaScriptCore.xcodeproj/project.pbxproj: Added FeatureDefines.xcconfig file.
WebCore:
- Configurations/FeatureDefines.xcconfig: Added.
- Configurations/WebCore.xcconfig: Removed definition of ENABLE_SVG_DOM_OBJC_BINDINGS and FEATURE_DEFINES. Added include of FeatureDefines.xcconfig.
- WebCore.xcodeproj/project.pbxproj: Added FeatureDefines.xcconfig file.
- bindings/scripts/CodeGeneratorObjC.pm: When creating a list of command-line macro definitions, split on one-or-more spaces instead of a single space since the FEATURE_DEFINES macro may now contain more than one space between macros if some macros aren't defined.
WebKit:
- WebKit.xcodeproj/project.pbxproj: Added FeatureDefines.xcconfig file.
WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Added.
- Configurations/WebKit.xcconfig: Removed definition of ENABLE_SVG_DOM_OBJC_BINDINGS and FEATURE_DEFINES. Added include of FeatureDefines.xcconfig.
WebKitTools:
- Scripts/build-webkit: Realphabetized code related to enabling Geolation features for WebKit. Also set ENABLE_GEOLOCATION variable for xcodebuild.
- 3:54 PM Changeset in webkit [42630] by
-
- 2 edits in trunk/WebKit/win
<rdar://problem/6803905> Lots of ASSERTs firing when trying to clear history
Reviewed by Steve Falkenburg.
- WebHistory.cpp: (WebHistory::data): Return null if there are no history items.
- 3:29 PM Changeset in webkit [42629] by
-
- 2 edits in trunk/WebKitSite
2009-04-17 Simon Fraser <Simon Fraser>
Reviewed by Steve Falkenburg
Fix the link for setting the Platform SDK paths in the Windows instructions.
- building/build.html:
- 3:28 PM QtWebKitTodo edited by
- (diff)
- 3:27 PM QtWebKitJournal edited by
- (diff)
- 2:49 PM Changeset in webkit [42628] by
-
- 3 edits1 move in trunk
WebCore:
2009-04-17 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe
<rdar://problem/6786999> Tiger WebKit shouldn't try to POST on back/forward without nagging.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willLoadFromCache):
LayoutTests:
2009-04-17 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe
<rdar://problem/6778137> - Disable post-goback-repost-policy.html until the networking layer allows it to be useful.
- http/tests/navigation/post-goback-repost-policy.html: Removed.
- http/tests/navigation/post-goback-repost-policy.html-disabled: Copied from http/tests/navigation/post-goback-repost-policy.html.
- 1:50 PM Changeset in webkit [42627] by
-
- 4 edits2 adds in trunk/WebCore
2009-04-17 Darin Adler <Darin Adler>
Reviewed by Timothy Hatcher.
Added sudden termination functions that can be called without involving
the page or client.
- GNUmakefile.am: Added SuddenTermination.h.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto. Also added SuddenTermination.mm.
- platform/SuddenTermination.h: Added.
- platform/mac/SuddenTermination.mm: Added.
- 1:45 PM Changeset in webkit [42626] by
-
- 7 edits in trunk/WebCore
Reviewed by Simon Fraser.
Move more code into RenderSVGModelObject
needsLayer() already returns false from RenderSVGModelObject
lineHeight and baselinePosition are from days of RenderPath having RenderBox parents.
I also added comments to explain how focus rings work (now that I understand)
I got rid of two more uses of m_absoluteBounds (nearly dead!)
- rendering/RenderPath.cpp:
- rendering/RenderPath.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::addFocusRingRects):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::absoluteRects): (WebCore::RenderSVGModelObject::absoluteQuads):
- rendering/RenderSVGModelObject.h:
- 1:44 PM Changeset in webkit [42625] by
-
- 2 edits in trunk/WebKit/win
- Fix a leak in WebHistoryItem::children() by adopting the created instance of WebHistoryItem.
- Remove the unnecessary call to QueryInterface() which is not related to the leak.
Reviewed by Adam Roben.
- WebHistoryItem.cpp: (WebHistoryItem::children):
- 1:42 PM Changeset in webkit [42624] by
-
- 2 edits in trunk/WebCore
2009-04-16 Peter Kasting <pkasting@google.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=25238
Invalidate the hovered scrollbar part when resetting the pressed part,
since once there is no pressed part we can draw a hovered state.
- platform/Scrollbar.cpp: (WebCore::Scrollbar::setHoveredPart): (WebCore::Scrollbar::setPressedPart):
- 1:31 PM Changeset in webkit [42623] by
-
- 6 edits3 adds in trunk
2009-04-16 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25223
REGRESSION: Back button after form submission to the same URL fails to navigate.
Test: http/tests/navigation/post-goback-same-url.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Check if the page we are leaving has FormData.
- 1:09 PM Changeset in webkit [42622] by
-
- 3 edits in trunk/WebCore
Not reviewed. Fix WML enabled builds.
- 12:53 PM Changeset in webkit [42621] by
-
- 2 edits in trunk/WebKit/gtk/po
2009-04-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed build fix to generate all .mo files at the correct
location.
- GNUmakefile.am:
- 12:53 PM Changeset in webkit [42620] by
-
- 2 edits in trunk/WebKit/mac
2009-04-17 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Fix crashes seen in regression tests with hosted plug-ins.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::cancelStreamLoad): Check the stream for 0, not the stream ID.
- 12:35 PM Changeset in webkit [42619] by
-
- 7 edits in trunk
2009-04-17 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Add support for the media element 'played' attribute.
This involves support of "normalized TimeRanges" as described by
the spec.
Test: media/video-played.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Renamed m_currentTimeDuringSeek->m_lastSeekTime. Added m_playing and m_playedTimeRanges. (WebCore::HTMLMediaElement::loadInternal): Reset m_playing, m_lastSeekTime, and m_playedTimeRanges (WebCore::HTMLMediaElement::seek): Set current time to m_playedTimeRanges (WebCore::HTMLMediaElement::currentTime): m_currentTimeDuringSeek -> m_lastSeekTime (WebCore::HTMLMediaElement::played): Returns m_playedTimeRanges. (WebCore::HTMLMediaElement::updatePlayState): Add the new played time ranges when pausing. Set the m_playing flag.
- html/HTMLMediaElement.h:
- html/TimeRanges.cpp: (TimeRanges::add): Merge range(s) if overlap.
- html/TimeRanges.h: Add various helpers (below). (WebCore::TimeRanges::Range::isPointInRange): Added. (WebCore::TimeRanges::Range::isOverlappingRange): Ditto. (WebCore::TimeRanges::Range::unionWithOverlappingRange): Ditto. (WebCore::TimeRanges::Range::isBeforeRange): Ditto.
2009-04-17 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Add test for media element 'played' attribute.
- media/video-played-expected.txt: Added.
- media/video-played.html: Added.
- media/video-test.js: (disableFullTestDetailsPrinting): New, include less information in 'reportExpected' output to accomodate tests with values that are expected to change from run to run. (reportExpected): Don't log expected and observed values when printFullTestDetails is false. (runSilently): New, same as run() but without logging. (run): Call runSilently to run command.
- 12:16 PM Changeset in webkit [42618] by
-
- 49 edits in trunk
WebCore:
2009-04-17 Darin Adler <Darin Adler>
Reviewed by Antti Koivisto.
Bug 25210: don't use ObjC methods to wrap/unwrap DOM objects with ObjC
https://bugs.webkit.org/show_bug.cgi?id=25210
- WebCore.base.exp: Export the core and kit function overloads that are used in WebKit. Also resorted this file.
- WebCore.xcodeproj/project.pbxproj: Re-added DOMHTMLCanvasElement.h to fix a strange problem with the file type.
- bindings/objc/DOM.mm: Removed the many extraneous includes. Added new includes so we can use and implement the new core and kit functions. Import DOMInternal.h first so it can do its public/private magic. (-[DOMNode _rootObject]): Changed to use early-return style. (kitClass): Added. Tells the wrapper generator what kind of node class to create to wrap DOM nodes. This has the code that used to be in the _wrapNode method. (kit): Added. Takes an EventTarget and makes the appropriate type of wrapper, dpending on whether it's a Node or an SVGElementInstance. This replace methods that used to be on both of those classes. (-[DOMNode boundingBox]): Changed to use early return, and the core function. (-[DOMNode lineBoxRects]): Ditto. (-[DOMNode renderedImage]): Ditto. (-[DOMRange boundingBox]): Ditto. (-[DOMRange lineBoxRects]): Ditto. (-[DOMElement image]): Ditto. (-[DOMElement _font]): Ditto. (-[DOMElement _imageTIFFRepresentation]): Ditto. (-[DOMElement _getURLAttribute:]): Ditto. (-[DOMElement isFocused]): Ditto. (kit): Hand-wrote the version of this for NodeFilter, since it's a protocol, not a class in the binding. (core): Ditto. (-[DOMNodeFilter acceptNode:]): Use core.
- bindings/objc/DOMAbstractView.mm: (-[DOMAbstractView document]): Use kit. (-[DOMAbstractView _disconnectFrame]): Call removeDOMWrapper, which is no longer in the WebCore namespace, since it's headed for WebKit in the future. (core): Hand-wrote the version of this for DOMAbstractView.mm, since we store a pointer to the Frame, not the DMWindow. (kit): Ditto.
- bindings/objc/DOMCSS.mm: (kitClass): Added. Tells the wrapper generator what kind of node class to create to wrap CSS objects. This has the code that used to be in the _wrapStyleSheet, _wrapCSSRule, and _wrapCSSValue methods.
- bindings/objc/DOMEvents.mm: (kitClass): Added. Tells the wrapper generator what kind of node class to create to wrap event objects. This has the code that used to be in the _wrapEvent methods.
- bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]): Use kit and core. (-[DOMHTMLDocument createDocumentFragmentWithText:]): Ditto. (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): Ditto. (-[DOMHTMLInputElement _rectOnScreen]): Ditto. (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): Ditto. (-[DOMHTMLInputElement _selectedRange]): Ditto. (-[DOMHTMLInputElement _setAutofilled:]): Ditto. (-[DOMHTMLSelectElement _activateItemAtIndex:]): Ditto. (-[DOMHTMLInputElement _isEdited]): Ditto. (-[DOMHTMLTextAreaElement _isEdited]): Ditto. (kitClass): Added. Gives HTMLOptionCollection objects an appropriate wrapper.
- bindings/objc/DOMInternal.h: Removed most of the imports. There's no reason to have this header include all the other internal DOM headers. Removed unneeded interfaces, including the redeclaration of _init in DOMObject, since it's already inherited from WebScriptObject. Moved all the functions out of the WebCore namespace since this code is destined for WebKit, which doesn't use a namespace. Added kit and core functions for the two classes that live in this header.
- bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]): Use core.
- bindings/objc/DOMObject.h: Made the _internal field be private instead of protected. This also allows the "#define private public" trick to be used to make the field accessible inside the bindings code.
- bindings/objc/DOMObject.mm: (-[DOMObject dealloc]): Updated for namespace change. (-[DOMObject sheet]): Use core and kit functions.
- bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]): Updated for namespace change. (-[DOMRGBColor red]): Use kit function. (-[DOMRGBColor green]): Ditto. (-[DOMRGBColor blue]): Ditto. (-[DOMRGBColor alpha]): Ditto. (core): Added. Replaces the _RGBColor method. (kit): Added. Replaces the _wrapRGBColor method.
- bindings/objc/DOMSVGPathSegInternal.mm: (kitClass): Added. Replaces the _wrapSVGPathSeg method.
- bindings/objc/DOMUtility.mm: (JSC::createDOMWrapper): Use kit function. (createDOMWrapper): Ditto.
- bindings/objc/DOMXPath.mm: (core): Added. Replaces the _xpathNSResolver method. (kit): Added. Replaces the _wrapXPathNSResolver method.
- bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::find): Changed to use early return. (WebCore::ObjCEventListener::handleEvent): Use kit function.
- bindings/objc/ObjCNodeFilterCondition.mm: (WebCore::ObjCNodeFilterCondition::acceptNode): Use kit function.
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject scriptObjectForJSObject:originRootObject:rootObject:]): Updated for namespace change.
- bindings/scripts/CodeGeneratorObjC.pm: Changed spelling of "license" to U.S. spelling. Removed GetObjCTypeMaker, GetObjCTypeGetterName, GetInternalTypeGetterSignature, and GetInternalTypeMakerSignature. Changed includes to conform to new scheme. Generate core and kit functions instead of methods and calls to those functions. Added a new attribute, Polymorphic, to indicate classes that have derived subclasses. Removed the old ObjCCustomInternalImpl attribute.
- css/CSSRule.idl: Use Polymorphic attribute, so core and kit functions will be generated, with kit calling kitClass. This requires less hand- written code than the old ObjCCustomInternalImpl.
- css/CSSValue.idl: Ditto.
- css/StyleSheet.idl: Ditto.
- dom/Event.idl: Ditto.
- dom/Node.idl: Ditto.
- html/HTMLCollection.idl: Ditto.
- svg/SVGPathSeg.idl: Ditto.
- editing/TextAffinity.h: Moved kit and core functions out of the WebCore namespace since this code is destined for WebKit, which doesn't use a namespace
- platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::declareAndWriteDragImage): Use kit function.
- platform/mac/DragDataMac.mm: (WebCore::DragData::asFragment): Use core function.
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): Use kit function.
- svg/SVGElementInstance.idl: Removed now-unneeded ObjCCustomInternalImpl function. This can be generated in a standard way now.
- svg/SVGViewSpec.idl: Ditto.
WebKit/mac:
2009-04-17 Darin Adler <Darin Adler>
Reviewed by Antti Koivisto.
Bug 25210: don't use ObjC methods to wrap/unwrap DOM objects with ObjC
https://bugs.webkit.org/show_bug.cgi?id=25210
- DOM/WebDOMOperations.mm: (-[DOMNode markupString]): Use the core function instead of an Objective-C method. (-[DOMNode _subresourceURLs]): Ditto. (-[DOMDocument _focusableNodes]): Ditto. (-[DOMRange webArchive]): Ditto. (-[DOMRange markupString]): Ditto.
- Misc/WebElementDictionary.mm: Added now-needed include since the core and kit functions now come from the internal headers from DOM bindings.
- Misc/WebNSPasteboardExtras.mm: Ditto.
- Plugins/WebNullPluginView.mm: Ditto.
- Plugins/WebPluginController.mm: Ditto.
- WebCoreSupport/WebChromeClient.mm: Ditto.
- WebCoreSupport/WebInspectorClient.mm: Ditto.
- WebCoreSupport/WebPasteboardHelper.mm: Ditto.
- WebView/WebHTMLView.mm: Ditto.
- WebCoreSupport/WebEditorClient.mm: Made kit function have internal linkage since it's only used in this file. Someone had instead added a declaration to suppress the warning you would otherwise get. Removed the core function. (WebEditorClient::textFieldDidBeginEditing): Added correct type checking. Previously the function would check only that something was an HTMLElement, but then cast it to HTMLInputElement. Also call kit instead of old wrap method. (WebEditorClient::textFieldDidEndEditing): Ditto. (WebEditorClient::textDidChangeInTextField): Ditto. (WebEditorClient::doTextFieldCommandFromEvent): Ditto. (WebEditorClient::textWillBeDeletedInTextField): Ditto. (WebEditorClient::textDidChangeInTextArea): Ditto, but for HTMLTextAreaElement.
- WebView/WebFrame.mm: Removed the core and kit functions here which are no longer needed since they're automatically generated now. (-[WebFrame _nodesFromList:]): Use kit. (-[WebFrame _markupStringFromRange:nodes:]): Use core. (-[WebFrame _stringForRange:]): More of the same. (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto. (-[WebFrame _firstRectForDOMRange:]): Ditto. (-[WebFrame _scrollDOMRangeToVisible:]): Ditto. (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]): Ditto. (-[WebFrame _convertNSRangeToDOMRange:]): Ditto. (-[WebFrame _convertDOMRangeToNSRange:]): Ditto. (-[WebFrame _markDOMRange]): Ditto. (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto. (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto. (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto. (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto. (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto. (-[WebFrame _characterRangeAtPoint:]): Ditto. (-[WebFrame _typingStyle]): Ditto. (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto. (-[WebFrame _pauseAnimation:onNode:atTime:]): Ditto. (-[WebFrame _pauseTransitionOfProperty:onNode:atTime:]): Ditto. (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
- WebView/WebFrameInternal.h: Removed the core and kit functions here which are no longer needed since they're automatically generated now.
- WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]): Use core. (formElementFromDOMElement): Ditto. (inputElementFromDOMElement): Ditto.
- WebView/WebTextIterator.mm: (-[WebTextIterator initWithRange:]): Ditto. (-[WebTextIterator currentRange]): Ditto. (-[WebTextIterator currentNode]): Ditto.
- WebView/WebView.mm: (-[WebView textIteratorForRect:]): Ditto. (-[WebView setSelectedDOMRange:affinity:]): Ditto.
- 11:46 AM Changeset in webkit [42617] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=25251
Crash when frame creation removes it from the parent
This brings us up-to-date with the expectations of sub-frame
creation, following what Mac has done. It fixes crashes when
calling init on the child frame removes it from the page.
This makes the following test pass instead of crash:
fast/loader/frame-creation-removal.html
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):
- 11:03 AM Changeset in webkit [42616] by
-
- 9 edits2 adds in trunk
WebCore:
2009-04-17 Brady Eidson <beidson@apple.com>
Reviewed by Maciej Stachowiak
<rdar://problem/5753299> "Private Browsing" doesn't affect HTML 5 Database storage
If the Page is in private browsing mode when a statement is queued up, flag that
statement as read-only.
It would be better to set the read-only flag on the database thread when it actually
executes, but that would either require making Settings access a lock-protected operation
or involve a synchronous callback to the WebCore thread, neither of which seem worth it.
If it becomes an issue in practice, we can revisit this later.
Test: storage/private-browsing-readonly.html
- storage/Database.cpp: (WebCore::Database::setAuthorizerReadOnly):
- storage/Database.h:
- storage/DatabaseAuthorizer.cpp: For all action types that would alter the database, deny when in read-only mode. (WebCore::DatabaseAuthorizer::reset): (WebCore::DatabaseAuthorizer::createTable): (WebCore::DatabaseAuthorizer::dropTable): (WebCore::DatabaseAuthorizer::allowAlterTable): (WebCore::DatabaseAuthorizer::createIndex): (WebCore::DatabaseAuthorizer::dropIndex): (WebCore::DatabaseAuthorizer::createTrigger): (WebCore::DatabaseAuthorizer::dropTrigger): (WebCore::DatabaseAuthorizer::createVTable): (WebCore::DatabaseAuthorizer::dropVTable): (WebCore::DatabaseAuthorizer::allowDelete): (WebCore::DatabaseAuthorizer::allowInsert): (WebCore::DatabaseAuthorizer::allowUpdate): (WebCore::DatabaseAuthorizer::setReadOnly):
- storage/DatabaseAuthorizer.h:
- storage/SQLStatement.cpp: (WebCore::SQLStatement::create): Add a m_readOnly flag. (WebCore::SQLStatement::SQLStatement): Ditto. (WebCore::SQLStatement::execute): If m_readOnly is set, tell the authorizer to change to read-only mode.
- storage/SQLStatement.h:
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL): Flag the statement as read-only if the Page is currently in private browsing mode.
LayoutTests:
2009-04-17 Brady Eidson <beidson@apple.com>
Reviewed by Maciej Stachowiak
<rdar://problem/5753299> "Private Browsing" doesn't affect HTML 5 Database storage
- storage/private-browsing-readonly-expected.txt: Added.
- storage/private-browsing-readonly.html: Added.
- 10:59 AM QtWebKitTodo edited by
- (diff)
- 10:46 AM Changeset in webkit [42615] by
-
- 11 edits in trunk/WebKit/mac
2009-04-17 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
WebKit side of <rdar://problem/6449642>.
- Plugins/Hosted/HostedNetscapePluginStream.h: (WebKit::HostedNetscapePluginStream::create): New function that creates a stream from a frame loader.
- Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream): Add the constructor that takes a frame loader.
- Plugins/Hosted/NetscapePluginHostManager.h:
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): Pass "fullFrame" to the plug-in host.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCCancelLoadURL): Call NetscapePluginInstanceProxy::cancelStreamLoad.
- Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::create): Pass "fullFrame" to the constructor.
(WebKit::NetscapePluginInstanceProxy::manualStream):
New getter for the manual stream.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Take the implicit request into account if we have a full frame plug-in.
(WebKit::NetscapePluginInstanceProxy::setManualStream):
Setter for the manual stream.
(WebKit::NetscapePluginInstanceProxy::cancelStreamLoad):
Cancel the manual stream if necessary.
- Plugins/Hosted/WebHostedNetscapePluginView.h: WebHostedNetscapePluginView now conforms to the WebPluginManualLoader protocol.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPlugin]): Pass "fullFrame" to instantiatePlugin.
(-[WebHostedNetscapePluginView pluginView:receivedResponse:]):
(-[WebHostedNetscapePluginView pluginView:receivedData:]):
(-[WebHostedNetscapePluginView pluginView:receivedError:]):
(-[WebHostedNetscapePluginView pluginViewFinishedLoading:]):
Call the equivalent manual stream functions.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Use a macro for getting the plug-in view type.
- 10:44 AM Changeset in webkit [42614] by
-
- 2 edits in trunk/WebKit/win
Fix a leak in WebHistory::data().
Reviewed by Adam Roben.
- WebHistory.cpp: (WebHistory::data):
- 10:42 AM Changeset in webkit [42613] by
-
- 15 edits in trunk
Reviewed by Antti Koivisto.
Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint
https://bugs.webkit.org/show_bug.cgi?id=25268
Lots of minus lines. Now we're sharing more sane code
(which will respect -webkit-transforms! and scroll offsets correctly)
Which means this fixes:
https://bugs.webkit.org/show_bug.cgi?id=20769 too!
We're no longer expanding the paint rect "for anti-aliasing", since
I can't find a case where that's required. If it is, repaintRectInLocalCoordinates()
should be fixed to handle those cases instead of here.
This fixes svg/custom/scroll-hit-test (now that we respect scroll offsets when repainting)
as well as improves our focus ring drawing seen in svg/custom/focus-ring
focus rings are now closer to transformed content by a couple pixels (they were needlessly outset by the antialiasing hack)
Also, it fixes the dumped rects for markers, causing a progression in svg/custom/marker-overflow-clip
- rendering/RenderPath.cpp: (WebCore::RenderPath::repaintRectInLocalCoordinates): (WebCore::RenderPath::setPath):
- rendering/RenderPath.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint): (WebCore::RenderSVGModelObject::computeRectForRepaint):
- rendering/RenderSVGModelObject.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::computeRectForRepaint):
- rendering/RenderSVGRoot.h:
- 9:53 AM Changeset in webkit [42612] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Anders Carlsson.
- remove tests affected by <rdar://problem/6661401> from the skip list, now that it is fixed.
- platform/mac-snowleopard/Skipped:
- 9:00 AM Changeset in webkit [42611] by
-
- 3 edits2 adds in trunk
Bug 25259: AX: VoiceOver cmd-cntl-space does not follow the google.com->more link
https://bugs.webkit.org/show_bug.cgi?id=25259
When a node becomes visible or hidden, accessibility needs to be told to update.
- 8:52 AM Changeset in webkit [42610] by
-
- 2 edits in trunk/WebCore
wx build fix, added missing header.
- 2:20 AM Changeset in webkit [42609] by
-
- 2 edits in trunk/WebCore
2009-04-17 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed build fix.
Fix the build with enabled SVG filters
- 1:49 AM Changeset in webkit [42608] by
-
- 2 edits in trunk/WebKit/qt
2009-04-17 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
Remove QtCore 4.5 dependency from QWebElement test
- 12:34 AM Changeset in webkit [42607] by
-
- 5 edits in trunk
Bug 25027: JavaScript parseInt wrong on negative numbers
<https://bugs.webkit.org/show_bug.cgi?id=25027>
Contributed by Mihnea Ovidenie
Reviewed by Oliver Hunt
When dealing with negative numbers, parseInt should use ceil instead of floor.
Apr 16, 2009:
- 11:20 PM Changeset in webkit [42606] by
-
- 5 edits in trunk/JavaScriptCore
2009-04-16 Stephanie Lewis <Stephanie Lewis>
Reviewed by Oliver Hunt.
<rdar://problem/6744652> 32-bit to 64-bit: Javascript hash tables double in size
Remove perfect hash optimization which removes 1 MB of overhead on 32-bit and almost 2 MB on 64-bit. Removing the optimization was not a regression on SunSpider and the acid 3 test still passes.
- create_hash_table:
- runtime/Lookup.cpp: (JSC::HashTable::createTable): (JSC::HashTable::deleteTable):
- runtime/Lookup.h: (JSC::HashEntry::initialize): (JSC::HashEntry::next): (JSC::HashTable::entry):
- runtime/Structure.cpp: (JSC::Structure::getEnumerableNamesFromClassInfoTable):
- 9:41 PM Changeset in webkit [42605] by
-
- 3 edits in trunk/JavaScriptCore
Fix subtle error in optimised VM reentry in Array.sort
Reviewed by Gavin Barraclough
Basically to ensure we don't accidentally invalidate the cached callframe
we should be using the cached callframe rather than our own exec state.
While the old behaviour was wrong i have been unable to actually create a
test case where anything actually ends up going wrong.
- 9:23 PM Changeset in webkit [42604] by
-
- 2 edits in trunk/WebCore
2009-04-16 Eric Roman <eroman@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25196
Add a missing V8DOMMap include.
- bindings/v8/WorkerScriptController.cpp: Included V8DOMMap.h.
- 9:19 PM Changeset in webkit [42603] by
-
- 2 edits in trunk/WebCore
2009-04-16 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=25260
Finish V8 custom bindings for InspectorController.
- bindings/v8/custom/V8InspectorControllerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Added.
- 8:10 PM Changeset in webkit [42602] by
-
- 2 edits in trunk/WebKit/win
2009-04-16 Alice Liu <alice.liu@apple.com>
Reviewed by Mark Rowe.
Fix for heavy leakage of WebURLResponses seen during the stress test
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldCacheResponse):
- 6:36 PM Changeset in webkit [42601] by
-
- 4 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Switch to wxGraphicsBitmap when using wxGraphicsContext so that we're not doing unnecessary conversions internally when drawing bitmaps.
https://bugs.webkit.org/show_bug.cgi?id=25248
- 6:23 PM Changeset in webkit [42600] by
-
- 3 edits2 adds in trunk
WebCore:
2009-04-16 Justin Garcia <justin.garcia@apple.com>
Reviewed by Dan Bernstein.
Performing a block style change in an editable root that contains only a br adds a newline
https://bugs.webkit.org/show_bug.cgi?id=25256
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Fix a bad check for an root block that didn't handle a root that contained a placeholder.
LayoutTests:
2009-04-16 Justin Garcia <justin.garcia@apple.com>
Reviewed by Dan Bernstein.
Performing a block style change in an editable root that contains only a br adds a newline
https://bugs.webkit.org/show_bug.cgi?id=25256
- editing/execCommand/25256-expected.txt: Added.
- editing/execCommand/25256.html: Added.
- 5:34 PM Changeset in webkit [42599] by
-
- 18 edits in trunk
Reviewed by Simon Fraser.
Fix computeContainerBoundingBox to respect viewport translations
https://bugs.webkit.org/show_bug.cgi?id=25254
Previously computeContainerBoundingBox was just adding the viewportTranslation.
Which, although it has a confusing name, only contains the scale and translation
for the viewBox/preserveAspectRatio adjustment. It does not contain the
translation for the x/y offset of the viewport.
localToParentTransform() does contain this offset, so we use that instead
of the previous hacky code.
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGViewportContainer.h:
- rendering/SVGRenderSupport.cpp: (WebCore::computeContainerBoundingBox):
- 4:27 PM Changeset in webkit [42598] by
-
- 14 edits in trunk/WebCore
Reviewed by Simon Fraser.
Add a localToParentTransform() method which includes the
full transform between local and parent local coordinates.
https://bugs.webkit.org/show_bug.cgi?id=25226
Moved m_localTransform up into RenderSVGTransformableContainer
and added a comment to RenderSVGViewportContainer to make it more
clear that it does not have a localTransform().
This patch reveals two more failed design decisions:
- Use of RenderBox::absoluteTransform() to mean "absoluteTransform()
including only my localTransform()" callers are probably using it
incorrectly anyway and are just masking bugs in the confused code.
- computeContainerBoundingBox does not include viewport translations in
its computed bounding box, so bounding boxes will be off for parents of
inner <svg> elements. I'll fix this an updated the results in a separate change.
No functional changes, thus no tests.
- rendering/RenderObject.cpp: (WebCore::RenderObject::localToParentTransform): (WebCore::RenderObject::absoluteTransform):
- rendering/RenderObject.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
- rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::viewportTransform):
- rendering/RenderSVGHiddenContainer.cpp:
- rendering/RenderSVGHiddenContainer.h: (WebCore::RenderSVGHiddenContainer::absoluteTransform):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::localToParentTransform): (WebCore::RenderSVGRoot::absoluteTransform):
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::localToParentTransform): (WebCore::RenderSVGTransformableContainer::localTransform):
- rendering/RenderSVGTransformableContainer.h:
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::localToParentTransform): (WebCore::RenderSVGViewportContainer::absoluteTransform):
- rendering/RenderSVGViewportContainer.h:
- rendering/SVGRenderSupport.cpp: (WebCore::computeContainerBoundingBox):
- 3:29 PM Changeset in webkit [42597] by
-
- 3 edits in trunk/WebCore
2009-04-16 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
Fix Chromium's rendering of <option> elements inside of <optgroups>.
Test (will included as a manual test by https://bugs.webkit.org/show_bug.cgi?id=24900):
<select>
<optgroup label="Should be bold">
<option>Should not be bold</option>
</optgroup>
</select>
- css/themeWin.css: adding comments
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::getRowFont): use menuStyle() rather than the item's style
- 3:25 PM Changeset in webkit [42596] by
-
- 3 edits in trunk/WebKit/qt
2009-04-16 Holger Hans Peter Freyther <zecke@selfish.org>
Rubber-stamped by Simon Hausmann.
Make the operator== and operator!= non inline to
allow looking at the d-pointer in the future.
- Api/qwebelement.cpp: (QWebElement::operator==): (QWebElement::operator!=):
- Api/qwebelement.h:
- 3:17 PM Changeset in webkit [42595] by
-
- 2 edits in trunk/WebKit/win
2009-04-16 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
- WebView.cpp:
- 3:13 PM Changeset in webkit [42594] by
-
- 2 edits in trunk/WebKitTools
2009-04-16 Geoffrey Garen <ggaren@apple.com>
Build fix: updated check-for-global-initializers to account for code motion.
- Scripts/check-for-global-initializers:
- 3:12 PM Changeset in webkit [42593] by
-
- 2 edits in trunk/WebCore
2009-04-16 Eric Roman <eroman@chromium.org>
Reviewed by Alexey Proskuryakov.
Make DOMWindow::inlineEventListenerForType not have the "inline"
keyword. As this method gets used outside of DOMWindow.
- page/DOMWindow.cpp: (WebCore::DOMWindow::inlineEventListenerForType):
- 3:02 PM Changeset in webkit [42592] by
-
- 2 edits in trunk/WebCore
2009-04-16 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Antti Koivisto.
Fix <rdar://problem/6766969>
When deferred repaints are enabled and being reset and there is a active
timer, stop the timer and do the deferred repaints immediately.
- page/FrameView.cpp: (WebCore::FrameView::resetDeferredRepaintDelay):
- 3:01 PM Changeset in webkit [42591] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-16 Christian Dywan <christian@twotoasts.de>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=25042
destroying webview widget directly causes crash.
- tests/testwebframe.c: (test_webkit_web_frame_create_destroy): Add a test case for destroying a web view shortly after packing it in a window.
- 2:53 PM Changeset in webkit [42590] by
-
- 50 edits in trunk
WebCore:
2009-04-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=25241
Remove superfluous NotImplemented.h includes.
- html/CanvasRenderingContext2D.cpp:
- html/CanvasStyle.cpp:
- page/AccessibilityRenderObject.cpp:
- platform/chromium/ScrollbarThemeChromiumLinux.cpp:
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/cairo/ImageBufferCairo.cpp:
- platform/graphics/cairo/PathCairo.cpp:
- platform/graphics/chromium/SimpleFontDataLinux.cpp:
- platform/graphics/gtk/FontGtk.cpp:
- platform/graphics/gtk/IconGtk.cpp:
- platform/graphics/qt/IconQt.cpp:
- platform/graphics/qt/ImageQt.cpp:
- platform/graphics/qt/ImageSourceQt.cpp:
- platform/graphics/skia/ImageBufferSkia.cpp:
- platform/graphics/skia/ImageSkia.cpp:
- platform/graphics/win/ColorSafari.cpp:
- platform/graphics/win/FontWin.cpp:
- platform/graphics/win/GraphicsContextCGWin.cpp:
- platform/graphics/win/GraphicsContextCairoWin.cpp:
- platform/graphics/win/SimpleFontDataCairoWin.cpp:
- platform/graphics/wx/ImageWx.cpp:
- platform/graphics/wx/TransformationMatrixWx.cpp:
- platform/gtk/PlatformScreenGtk.cpp:
- platform/gtk/PopupMenuGtk.cpp:
- platform/gtk/ScrollViewGtk.cpp:
- platform/gtk/ScrollbarGtk.cpp:
- platform/network/cf/ResourceHandleCFNet.cpp:
- platform/posix/FileSystemPOSIX.cpp:
- platform/qt/DragDataQt.cpp:
- platform/qt/FileSystemQt.cpp:
- platform/qt/Localizations.cpp:
- platform/qt/PopupMenuQt.cpp:
- platform/win/EditorWin.cpp:
- platform/win/PasteboardWin.cpp:
- platform/wx/KeyboardEventWx.cpp:
- platform/wx/PopupMenuWx.cpp:
- platform/wx/SharedTimerWx.cpp:
- plugins/gtk/PluginViewGtk.cpp:
- plugins/mac/PluginPackageMac.cpp:
- plugins/qt/PluginPackageQt.cpp:
- plugins/win/PluginViewWin.cpp:
- rendering/RenderThemeChromiumLinux.cpp:
- svg/graphics/SVGImage.cpp:
WebKit/gtk:
2009-04-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=25241
Remove superfluous NotImplemented.h includes.
- webkit/webkitprivate.cpp:
WebKit/win:
2009-04-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=25241
Remove superfluous NotImplemented.h includes
- WebDownloadCFNet.cpp:
- WebURLAuthenticationChallengeSender.cpp:
- WebView.cpp:
- 2:19 PM Changeset in webkit [42589] by
-
- 12 edits in trunk/WebCore
2009-04-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions
Some cleanup in event handling code.
- bindings/js/JSDOMGlobalObject.cpp:
- bindings/js/JSDOMGlobalObject.h: Removed findJSProtectedEventListener and findJSProtectedEventListener because they are now unused.
- bindings/js/JSEventListener.cpp:
- bindings/js/JSEventListener.h: (WebCore::JSEventListener::clearGlobalObject):
- bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::~JSLazyEventListener): (WebCore::JSLazyEventListener::globalObject):
- bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::clearGlobalObject): Nixed JSProtectedEventListener, and merged it with JSLazyEventListener, the only remaining event listener that still GC-protects its function and global object.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController):
- bindings/js/ScriptController.h: (WebCore::ScriptController::setEventHandlerLineNumber): (WebCore::ScriptController::eventHandlerLineNumber): Renamed handlerLineno => handlerLineNumber, because anything less would be uncivilized. Removed createInlineEventListener because it mostly did irrelevent work, so it just got in the way of understanding how event handler creation works.
- dom/Document.cpp: (WebCore::Document::createEventListener):
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::startElementNs):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processToken): Ditto.
- 2:19 PM Changeset in webkit [42588] by
-
- 1 add in trunk/LayoutTests/platform/mac/fast/forms/caret-rtl-expected.png
Checking in pixel results for a recently added test.
- 1:58 PM Changeset in webkit [42587] by
-
- 1 edit in trunk/WebCore/ChangeLog
2009-04-16 Beth Dakin <Beth Dakin>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20765 Website
crashes on load due to messy HTML in search form
-and corresponding-
<rdar://problem/6210633>
Before this patch, <form>s were allowed to sit inside tables
without being wrapped by anonymous table parts. There was also a
concept that such a form could be "demoted" and would not be
allowed to have any children. This patch has the HTML parser mark
form elements that have been demoted as such, and then the demoted
forms are not given renderers. I also removed the code that allowed
forms to sit in tables without anonymous table sections. So now any
forms that do manage to get a renderer inside a table will also be
wrapped with appropriate table parts.
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): (WebCore::HTMLFormElement::rendererIsNeeded):
- html/HTMLFormElement.h: (WebCore::HTMLFormElement::setDemoted): (WebCore::HTMLFormElement::isDemoted):
- html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode):
- rendering/RenderTable.cpp: (WebCore::RenderTable::addChild):
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild):
- 1:48 PM Changeset in webkit [42586] by
-
- 25 edits8 adds in trunk
WebCore:
2009-04-16 Beth Dakin <Beth Dakin>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20765 Website
crashes on load due to messy HTML in search form
-and corresponding-
<rdar://problem/6210633>
Before this patch, <form>s were allowed to sit inside tables
without being wrapped by anonymous table parts. There was also a
concept that such a from could be "demoted" and would not be
allowed to have any children. This patch has the HTML parser mark
form elements that have been demoted as such, and then the demoted
forms are not given renderers. I also removed the code that allowed
forms to sit in tables without anonymous table sections. So now any
forms that do manage to get a renderer inside a table will also be
wrapped with appropriate table parts.
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): (WebCore::HTMLFormElement::rendererIsNeeded):
- html/HTMLFormElement.h: (WebCore::HTMLFormElement::setDemoted): (WebCore::HTMLFormElement::isDemoted):
- html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode):
- rendering/RenderTable.cpp: (WebCore::RenderTable::addChild):
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild):
LayoutTests:
2009-04-16 Beth Dakin <Beth Dakin>
Reviewed by Dave Hyatt.
Tests for https://bugs.webkit.org/show_bug.cgi?id=20765 Website
crashes on load due to messy HTML in search form
-and corresponding-
<rdar://problem/6210633>
New tests:
- fast/forms/form-added-to-table.html: Added.
- fast/forms/form-in-malformed-markup.html: Added.
- platform/mac/fast/forms/form-added-to-table-expected.checksum: Added.
- platform/mac/fast/forms/form-added-to-table-expected.png: Added.
- platform/mac/fast/forms/form-added-to-table-expected.txt: Added.
- platform/mac/fast/forms/form-in-malformed-markup-expected.checksum: Added.
- platform/mac/fast/forms/form-in-malformed-markup-expected.png: Added.
- platform/mac/fast/forms/form-in-malformed-markup-expected.txt: Added.
Tests with new results:
- platform/mac/fast/forms/formmove3-expected.txt:
- platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/mac/fast/invalid/table-residual-style-crash-expected.txt:
- platform/mac/fast/table/fixed-table-non-cell-in-row-expected.txt:
- platform/mac/fast/table/inline-form-assert-expected.txt:
- platform/mac/fast/table/insert-cell-before-form-expected.txt:
- platform/mac/fast/table/insert-row-before-form-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2516-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
- platform/mac/tables/mozilla/bugs/bug32447-expected.txt:
- platform/mac/tables/mozilla/bugs/bug34538-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla/bugs/bug78162-expected.txt:
- platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
- platform/mac/tables/mozilla/bugs/bug96343-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- 1:02 PM Changeset in webkit [42585] by
-
- 3 edits3 adds in trunk
2009-04-16 Xiaomei Ji <xji@chromium.org>
Reviewed by Simon Fraser.
Fix https://bugs.webkit.org/show_bug.cgi?id=24527
caret does not paint the first time you focus on a 0px right padding RTL div
Test: fast/forms/caret-rtl.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::localCaretRect): When calculating x-axis if alignment is alignRight, we need to subtract the caretWidth so that the caret at IntRect(x, y, caretWidth, height) is inside the block.
- 11:41 AM Changeset in webkit [42584] by
-
- 1 add1 delete in trunk/LayoutTests
Moving this test to platform/mac, it's mac only.
- 11:11 AM Changeset in webkit [42583] by
-
- 4 edits4 adds in trunk
WebCore:
2009-04-16 Justin Garcia <justin.garcia@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=25228
SelectionController::absoluteCaretBounds returns an inflated caret (the caret repaint rect)
Return the bounds of the transformed caret, not the transformed repaint rect for the caret (which is inflated).
- editing/SelectionController.cpp: (WebCore::SelectionController::localCaretRect): (WebCore::SelectionController::absoluteBoundsForLocalRect): (WebCore::SelectionController::caretRepaintRect): (WebCore::SelectionController::recomputeCaretRect):
- editing/SelectionController.h:
LayoutTests:
2009-04-16 Justin Garcia <justin.garcia@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=25228
SelectionController::absoluteCaretBounds returns an inflated caret (the caret repaint rect)
- editing/selection/25228.html: Added.
- platform/mac/editing/selection/25228-expected.checksum: Added.
- platform/mac/editing/selection/25228-expected.png: Added.
- platform/mac/editing/selection/25228-expected.txt: Added.
- 11:11 AM Changeset in webkit [42582] by
-
- 2 edits in trunk/WebKitTools
2009-04-16 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Adam Roben.
Compare test's response mime type and dump test as text properly.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (dump):
- 11:00 AM Changeset in webkit [42581] by
-
- 2 edits in trunk/WebCore
2009-04-16 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=25187
Bug 25187: <video> may not be rendered upon certain racy conditions
Always create the video renderer when the load state reaches QTMovieLoadStateLoaded
and the element is visible, not only when the movie has just been opened.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): Make sure we do not make false assumption on the state changes order. Create the renderer if none is present, when movie is loaded instead.
- 10:24 AM Changeset in webkit [42580] by
-
- 5 edits in trunk/WebCore
Reviewed by Geoffrey Garen.
Add filterBoundingBox() to RenderSVGModelObject to share a tiny bit of code
RenderSVGModelObject has much more interesting code it can share,
but I'm just trying to get the commits out of my local branch and into
the repository in any order I can. :) This one was small.
This will be used by the unified RenderSVGModelObject
clippedOverflowRectForRepaint patch coming soon.
- rendering/RenderPath.cpp: (WebCore::RenderPath::clippedOverflowRectForRepaint):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::clippedOverflowRectForRepaint):
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::filterBoundingBox):
- rendering/RenderSVGModelObject.h:
- 10:11 AM Changeset in webkit [42579] by
-
- 7 edits in trunk/WebCore
2009-04-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Eric Seidel and Adam Roben.
More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions
Simplified some EventHandler creation code.
Removed a pile of code whose sole purpose was to allow SVG event handlers
to supply a parameter named "evt" instead of the normal "event", and
replaced it with a single parameter to JSLazyEventListener's constructor
specifying the parameter name to use.
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::parseCode):
- bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::create):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::createInlineEventListener):
- bindings/js/ScriptController.h:
- dom/Document.cpp: (WebCore::Document::createEventListener):
- 10:09 AM Changeset in webkit [42578] by
-
- 28 edits in trunk/WebCore
Reviewed by David Hyatt.
Split out objectBoundingBox and repaintRectInLocalCoordinates from relativeBBox
in preparation for simplifying (and fixing) repaint logic in the SVG rendering tree.
https://bugs.webkit.org/show_bug.cgi?id=25224
objectBoundingBox() matches the SVG 1.1 concept of a "bounding box"
repaintRectInLocalCoordinates() should return the a rect covering all painted content.
However, repaintRectInLocalCoordinates() still only returns the "stroke bounding box"
in this patch. In a future patch, repaintRectInLocalCoordinates will be fixed to return
a rect covering all painted content. In order to avoid changing several hundred layout test results, I've left
the behavior as-is for now. The returned rect is used by various repaintRectInLocalCoordinates
implementations and sometimes adjusted to include all painted content, but not always, and
the places where the adjustments are made are sometimes wrong. Again, will be fixed in
an upcoming patch.
This patch discovered a bug in Font::drawTextUsingSVGFont, which is probably causing
bounding-box relative gradients on SVGFont glyphs to not paint correctly.
I chose not to try and fix the bug in this patch and instead left a FIXME.
This patch also discovered that at least tspan.getBBox() is broken. This
along with the foreignObject.getBBox() change will be tested (and fixed) in a
later patch. https://bugs.webkit.org/show_bug.cgi?id=25225
No change in behavior (besides the above mentioned foreignObject.getBBox()), thus no tests.
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::objectBoundingBox): this is a behavior improvement for getBBox() test case coming in a later patch (WebCore::RenderForeignObject::repaintRectInLocalCoordinates): only really used for layout test results, might some day be used for repaint.
- rendering/RenderForeignObject.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::objectBoundingBox): new methods, ASSERT if used but not implemented. (WebCore::RenderObject::repaintRectInLocalCoordinates):
- rendering/RenderObject.h:
- rendering/RenderPath.cpp: (WebCore::RenderPath::objectBoundingBox): (WebCore::RenderPath::repaintRectInLocalCoordinates): (WebCore::RenderPath::clippedOverflowRectForRepaint): (WebCore::RenderPath::lineHeight): (WebCore::RenderPath::baselinePosition): (WebCore::RenderPath::paint): (WebCore::RenderPath::addFocusRingRects):
- rendering/RenderPath.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::objectBoundingBox): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGGradientStop.h: (WebCore::RenderSVGGradientStop::objectBoundingBox): (WebCore::RenderSVGGradientStop::repaintRectInLocalCoordinates):
- rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::objectBoundingBox): (WebCore::RenderSVGHiddenContainer::repaintRectInLocalCoordinates):
- rendering/RenderSVGHiddenContainer.h:
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::objectBoundingBox): (WebCore::RenderSVGImage::repaintRectInLocalCoordinates): (WebCore::RenderSVGImage::calculateAbsoluteBounds): (WebCore::RenderSVGImage::addFocusRingRects):
- rendering/RenderSVGImage.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::objectBoundingBox): (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGTSpan.h: (WebCore::RenderSVGTSpan::objectBoundingBox): (WebCore::RenderSVGTSpan::repaintRectInLocalCoordinates):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::clippedOverflowRectForRepaint): (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::absoluteQuads): (WebCore::RenderSVGText::objectBoundingBox): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
- rendering/RenderSVGText.h:
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::viewportTransform):
- rendering/SVGRenderSupport.cpp: (WebCore::computeContainerBoundingBox):
- rendering/SVGRenderSupport.h:
- rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<):
- svg/SVGFont.cpp: (WebCore::Font::drawTextUsingSVGFont):
- svg/SVGLocatable.cpp: (WebCore::SVGLocatable::getBBox):
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): (WebCore::SVGPaintServerGradient::setup):
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
- 8:42 AM Changeset in webkit [42577] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/6032139> Table cell widths calculated incorrectly on table that uses table-layout:fixed, colspans, and a mix of percentage and pixel widths
Test: fast/table/fixed-granular-cols.html
The incorrect widths resulted from incorrect handling of the case where
the <col> elements are more granular than the table cells.
- rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): When processing <col> elements, append effective columns or split existing effective columns as needed.
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/6032139> Table cell widths calculated incorrectly on table that uses table-layout:fixed, colspans, and a mix of percentage and pixel widths
- fast/table/fixed-granular-cols.html: Added.
- platform/mac/fast/table/fixed-granular-cols-expected.checksum: Added.
- platform/mac/fast/table/fixed-granular-cols-expected.png: Added.
- platform/mac/fast/table/fixed-granular-cols-expected.txt: Added.
- 8:40 AM Changeset in webkit [42576] by
-
- 2 edits in trunk/WebKitTools
Skip yet another JavaScriptCore test that sometimes fails on Windows
See Bug 25160: Various ecma/Date tests sometimes fail on Windows (but
not Mac)
<https://bugs.webkit.org/show_bug.cgi?id=25160>
- Scripts/run-javascriptcore-tests: Skip ecma/Date/15.9.2.2-6.js.
- 5:01 AM Changeset in webkit [42575] by
-
- 2 edits in trunk/JavaScriptCore
Optimise op_resolve_base
Reviewed by Gavin Barraclough.
If we can statically find a property we are trying to resolve
the base of, the base is guaranteed to be the global object.
- 4:36 AM Changeset in webkit [42574] by
-
- 3 edits in trunk/JavaScriptCore
Improve performance of read-write-modify operators
Reviewed by Gavin Barraclough
Implement cross scope optimisation for read-write-modify
operators, to avoid unnecessary calls to property resolve
helper functions.
- 3:10 AM Changeset in webkit [42573] by
-
- 2 edits in trunk/JavaScriptCore
Improve performance of remaining array enumeration functions
Reviewed by Gavin Barraclough
Make use of function entry cache for remaining Array enumeration functions.
- 12:54 AM Changeset in webkit [42572] by
-
- 5 edits in trunk/WebCore
<rdar://problem/6795285> Infinite recursion in ResourceHandle::receivedRequestToContinueWithoutCredential
Rolled out <http://trac.webkit.org/projects/webkit/changeset/42536> - the two instances of
authentication challenge are different, after all. Added a FIXME comment about a possible
future improvement.
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::clearAuthentication):
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandle::receivedCancellation):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::didCancelAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandle::receivedCancellation):
- 12:24 AM Changeset in webkit [42571] by
-
- 2 edits in trunk/JavaScriptCore
Improve performance of Array.sort
Reviewed by Gavin Barraclough.
Cache the VM entry for Array.sort when using a JS comparison function.
Apr 15, 2009:
- 9:07 PM Changeset in webkit [42570] by
-
- 5 edits3 adds in trunk
Bug 25229: Need support for Array.prototype.reduceRight
<https://bugs.webkit.org/show_bug.cgi?id=25229>
Reviewed by Gavin Barraclough.
Implement Array.reduceRight
- 8:51 PM Changeset in webkit [42569] by
-
- 5 edits in trunk/WebCore
2009-04-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions
Also fixed <rdar://problem/6792909> WebInspector crashes when reloading
a page with breakpoints set
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::clearJSFunctionInline): (WebCore::JSEventListener::markJSFunction):
- bindings/js/JSEventListener.h: Actually clear our function and global object pointers when our client instructs us to. (Oops!) Also, mark our global object while we still intend to use it.
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::mark): (WebCore::toJS):
- bindings/scripts/CodeGeneratorJS.pm:
- svg/SVGElementInstance.idl: For every SVGElementInstance wrapper, ensure that the corresponding element also has a wrapper, to keep its event listeners alive.
- 8:33 PM Changeset in webkit [42568] by
-
- 4 edits6 copies3 adds in trunk/WebCore
2009-04-15 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=25201
Add ScriptFunctionCall/ScriptObject for V8.
- bindings/v8/ScriptFunctionCall.cpp: Added.
- bindings/v8/ScriptFunctionCall.h: Added.
- bindings/v8/ScriptObject.cpp: Added.
- bindings/v8/ScriptObject.h: Added.
- bindings/v8/ScriptObjectQuarantine.cpp: Added.
- bindings/v8/ScriptObjectQuarantine.h: Added.
- bindings/v8/ScriptScope.cpp: Added.
- bindings/v8/ScriptScope.h: Added.
- bindings/v8/ScriptState.h: (WebCore::ScriptState::ScriptState): Added new constructors. (WebCore::ScriptState::frame): Added Frame ptr accessor.
- bindings/v8/ScriptString.h: (WebCore::ScriptString::ScriptString): Added default constructor.
- bindings/v8/ScriptValue.h: (WebCore::ScriptValue::isEqual): Added.
- 7:12 PM Changeset in webkit [42567] by
-
- 3 edits3 adds in trunk
Bug 25227: Array.filter triggers an assertion when the target array shrinks while being filtered
<https://bugs.webkit.org/show_bug.cgi?id=25227>
Reviewed by Gavin Barraclough.
We correct this simply by making the fast array path fall back on the slow path if
we ever discover the fast access is unsafe.
- 5:49 PM Changeset in webkit [42566] by
-
- 2 edits in trunk/WebCore
2009-04-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed build fix. Add RenderSVGModelObject.* to GTK+'s build.
- GNUmakefile.am:
- 5:02 PM Changeset in webkit [42565] by
-
- 2 edits in trunk/WebKitTools
Redo last build fix in a more straightforward way.
- DumpRenderTree/win/DumpRenderTree.cpp: (sharedCFURLCache):
- 4:46 PM Changeset in webkit [42564] by
-
- 2 edits in trunk/WebKitTools
Fix Windows build of DumpRenderTree.
- DumpRenderTree/win/DumpRenderTree.cpp: (sharedCFURLCache): (main):
- 4:35 PM Changeset in webkit [42563] by
-
- 3 edits3 adds in trunk
Bug 25159: Support Array.prototype.reduce
<https://bugs.webkit.org/show_bug.cgi?id=25159>
Reviewed by Gavin Barraclough
Implement Array.prototype.reduce
- 3:46 PM Changeset in webkit [42562] by
-
- 2 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Implement support for wxWebViewNewWindowEvent.
https://bugs.webkit.org/show_bug.cgi?id=19043
- 3:32 PM Changeset in webkit [42561] by
-
- 11 edits2 adds in trunk/WebCore
Reviewed by Simon Fraser.
Add minimal RenderSVGModelObject and make RenderPath and RenderSVGContainer use it.
https://bugs.webkit.org/show_bug.cgi?id=25221
RenderSVGModelObject is the base rendering class for things which live
in the SVG rendering tree. Not all SVG renders are RenderSVGModelObjects yet.
More patches coming. This is just adding the class, future patches
will pull more logic out of RenderPath and RenderSVGContainer into RenderSVGModelObject.
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderPath.cpp: (WebCore::RenderPath::RenderPath):
- rendering/RenderPath.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGModelObject.cpp: Added. (WebCore::RenderSVGModelObject::RenderSVGModelObject):
- rendering/RenderSVGModelObject.h: Added. (WebCore::RenderSVGModelObject::requiresLayer):
- rendering/RenderTreeAsText.cpp:
- rendering/SVGRenderTreeAsText.cpp:
- 3:22 PM Changeset in webkit [42560] by
-
- 2 edits in trunk/LayoutTests/platform/win
Fixed an expected result and added a test to the Skipped list while I investigate why its expected results didn't change.
- 2:32 PM Changeset in webkit [42559] by
-
- 3 edits in trunk/WebCore
<rdar://problem/6785760> WebCore should use a maximum of 6 connections per host, not 4
Reviewed by Adam Roben.
- platform/network/ResourceRequestBase.cpp:
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::initializeMaximumHTTPConnectionCountPerHost):
- 2:30 PM Changeset in webkit [42558] by
-
- 4 edits in trunk/WebKitLibraries
Updated WebKitSystemInterface for Windows.
Changes needed for <rdar://problem/6785760>
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 1:28 PM Changeset in webkit [42557] by
-
- 3 edits in trunk/WebCore
2009-04-15 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Add special casing to bindings generator so that custom functions
starting with xml or xslt conform to WebKit style guidelines.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::xmlHttpRequest): (WebCore::JSDOMWindow::xsltProcessor):
- bindings/scripts/CodeGenerator.pm:
- 1:25 PM Changeset in webkit [42556] by
-
- 2 edits in trunk/WebKitTools
Skip yet another JavaScriptCore test that sometimes fails on Windows
See Bug 25160: Various ecma/Date tests sometimes fail on Windows (but
not Mac)
<https://bugs.webkit.org/show_bug.cgi?id=25160>
- Scripts/run-javascriptcore-tests: Skip ecma/Date/15.9.2.2-2.js (who didn't see it coming?).
- 1:24 PM Changeset in webkit [42555] by
-
- 3 edits in trunk/WebCore
Reviewed by Simon Fraser.
Remove more dead code from RenderSVGHiddenContainer.
lineHeight and baselinePosition used to be on RenderSVGContainer
(of which this is a subclass) because RenderSVGContainer used
to be a RenderBox and always the renderer for <svg>
Now <svg> uses RenderSVGRoot when needing a RenderBox (inside HTML)
and RenderSVGViewportContainer (when inside SVG content)
so there is no need for RenderSVGHiddenContainer to have these HTML-specific methods.
- rendering/RenderSVGHiddenContainer.cpp:
- rendering/RenderSVGHiddenContainer.h:
- 1:01 PM Changeset in webkit [42554] by
-
- 6 edits in trunk/WebCore
Reviewed by Simon Fraser.
Remove unneeded (broken) code from SVG renderers
https://bugs.webkit.org/show_bug.cgi?id=25214
Mostly due to my historical confusions about the render tree
and some methods not being removed after classes were split.
RenderSVGRoot is an RenderBox and should just use all the
standard RenderBox methods for inspector and repaint rects.
RenderSVGContainer is *not* a RenderBox (any more) and thus
doesn't need lineHeight or width/height or calcBounds.
RenderSVGViewportContainer had some broken code which tried
to see if the click was inside the container at all, but it
was using width/height metrics based off of the containing
block (from calcWidth) which is wrong (since its real
width/height are from its containing viewport not containing block).
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::layout):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGRoot.cpp:
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::layout): (WebCore::RenderSVGViewportContainer::nodeAtPoint):
- 12:42 PM Changeset in webkit [42553] by
-
- 2 edits in trunk/LayoutTests
Updated expected result for a text dragging test that pastes text on Windows but not on Mac (which is expected).
- 12:33 PM Changeset in webkit [42552] by
-
- 2 edits in trunk/WebCore
Reviewed by Simon Fraser and Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=25217
Simplify nearestViewportElement and farthestViewportElement using isViewportElement and a for loop
Add ASSERT(element) to all these functions since they should never be passed a null element.
- svg/SVGLocatable.cpp: (WebCore::isViewportElement): (WebCore::SVGLocatable::nearestViewportElement): (WebCore::SVGLocatable::farthestViewportElement): (WebCore::SVGLocatable::getBBox): (WebCore::SVGLocatable::getCTM): (WebCore::SVGLocatable::getScreenCTM):
- 11:41 AM Changeset in webkit [42551] by
-
- 2 edits in trunk/WebCore
2009-04-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove support for the ObjCIvar extended attribute from the Objective-C
bindings generator. It is not used anymore.
- bindings/scripts/CodeGeneratorObjC.pm:
- 11:30 AM Changeset in webkit [42550] by
-
- 2 edits in trunk/LayoutTests
2009-04-15 Eric Carlson <eric.carlson@apple.com>
Fix incorrect expected result.
- http/tests/security/local-video-source-from-remote-expected.txt:
- 11:22 AM Changeset in webkit [42549] by
-
- 15 edits in trunk
WebCore:
2009-04-15 Justin Garcia <justin.garcia@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=25204
Create a fast path for ReplaceSelectionCommand that merges text nodes
During simple pastes, where we're just pasting a text node into a run of text, we would split the current
text and insert the new node in between. This is slow and we hit this bug:
in the layout and rendering code where adjacent text nodes don't shape correctly in Arabic.
This change creates a fast path for ReplaceSelectionCommand that inserts text directly into the
text node that holds the selection (very similar to the fast path we wrote for InsertTextCommand).
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::performTrivialReplace):
- editing/ReplaceSelectionCommand.h:
- editing/TextIterator.cpp:
LayoutTests:
2009-04-15 Justin Garcia <justin.garcia@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=25204
Create a fast path for ReplaceSelectionCommand that merges text nodes
Simplified DOM/Render trees:
- editing/pasteboard/4840662-expected.txt:
- platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
- platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
- platform/mac/editing/pasteboard/paste-text-019-expected.txt:
- platform/mac/editing/pasteboard/paste-xml-expected.txt:
Removed redundant styles that were generated during nesting prevention that is no longer needed:
- platform/mac/editing/pasteboard/4076267-2-expected.txt:
- platform/mac/editing/pasteboard/5156401-1-expected.txt:
No longer incorrectly uncollapsing unrendered whitespace:
- editing/pasteboard/paste-into-anchor-text-expected.txt:
- platform/mac/editing/pasteboard/5387578-expected.txt:
No longer invalidating the old selected DOM range during a paste:
- editing/pasteboard/copy-in-password-field-expected.txt:
- 11:18 AM Changeset in webkit [42548] by
-
- 4 edits2 adds in trunk/WebCore
2009-04-15 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
Move VDMX parsing into the Chromium Linux port.
VDMX tables are optional tables in TrueType fonts which contain the
exact pixel height of a given font at a given pel size. In order to
match Windows font metrics we have to use these numbers.
Previously, the parsing was performed in Skia. As part of the merge
with upstream Skia, an interface for getting table data from a font
has been added to Skia and we're moving the parsing into WebKit.
This does not change any layout tests.
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::uniqueID):
- platform/graphics/chromium/FontPlatformDataLinux.h:
- platform/graphics/chromium/FontTrueTypeLinux.cpp: Added.
- platform/graphics/chromium/FontTrueTypeLinux.h: Added.
- platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformWidthForGlyph):
- 11:15 AM Changeset in webkit [42547] by
-
- 2 edits in trunk/WebCore
2009-04-15 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov.
Restore stroked outlines to PlatformContextSkia::drawRect().
These were removed inadvertently in r41805, aka
https://bugs.webkit.org/show_bug.cgi?id=24662.
SkRect is { left, top, right, bottom }, not { left, top, width, height }.
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::drawRect):
- 11:14 AM Changeset in webkit [42546] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/6777374> Generated content with display: run-in causes a crash
Test: fast/runin/generated.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild): Check if the run-in block is generated, and if so, make the RenderInline anonymous instead of passing a 0 node to the RenderInline constructor. If the run-in itself is generated, do move :before and :after children from the block into the inline, as they will not be regenerated. Changed nested ifs into early returns.
LayoutTests:
Reviewed by Dave Hyatt.
- test for <rdar://problem/6777374> Generated content with display: run-in causes a crash
- fast/runin/generated.html: Added.
- platform/mac/fast/runin/generated-expected.checksum: Added.
- platform/mac/fast/runin/generated-expected.png: Added.
- platform/mac/fast/runin/generated-expected.txt: Added.
- 11:13 AM Changeset in webkit [42545] by
-
- 2 edits in trunk/WebCore
2009-04-15 Eric Roman <eroman@chromium.org>
Reviewed by Geoffrey Garen.
Expose DOMWindow::removeInlineEventListenerForType and
DOMWindow::inlineEventListenerForType as public.
- page/DOMWindow.h:
- 11:06 AM Changeset in webkit [42544] by
-
- 2 edits in trunk/WebCore
2009-04-14 Eric Roman <eroman@chromium.org>
Reviewed by Darin Adler.
Wrap RegisteredEventListener's markEventListeners and invalidateEventListeners
in a USE(JSC), since it doesn't compile with V8 bindings.
- dom/RegisteredEventListener.h:
- 10:26 AM Changeset in webkit [42543] by
-
- 3 edits1 add1 delete in trunk/LayoutTests
2009-04-15 Eric Carlson <eric.carlson@apple.com>
Reviewed by Alexey Proskuryakov.
Use a media file inside of LayoutTests/http/ so a cgi isn't necessary to load
it. Fixes a test failure introduced in r42533.
- http/tests/resources/silence.mpg: Added.
- http/tests/security/local-video-source-from-remote-expected.txt:
- http/tests/security/local-video-source-from-remote.html: change the remote url, update a comment.
- http/tests/security/resources/load-media.cgi: Removed.
- 10:20 AM Changeset in webkit [42542] by
-
- 2 edits in trunk/WebCore
2009-04-15 Eric Roman <eroman@chromium.org>
Reviewed by Darin Adler.
Fix a caller of Settings::javaScriptCanOpenWindowsAutomatically() to
use the new name.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- 8:25 AM Changeset in webkit [42541] by
-
- 2 edits in trunk/WebKitSite
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25186
There is no XSLT component in bugzilla
- projects/xslt/index.html: Changed to search by bug title.
- 8:09 AM Changeset in webkit [42540] by
-
- 4 edits in trunk/WebKit/qt
2009-04-15 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Ariya Hidayat.
Rename extend() method in QWebElementSelection to append().
- Api/qwebelement.cpp: (QWebElementSelection::append):
- Api/qwebelement.h:
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::appendSelection):
- 6:42 AM Changeset in webkit [42539] by
-
- 2 edits in trunk/WebKit/qt
2009-04-15 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Simon Hausmann.
Fixed nit/typo in QWebElement documentation.
- 6:24 AM WebKitFeatures edited by
- Fixed broken links to www.css3.info (diff)
- 4:56 AM QtWebKitTodo edited by
- (diff)
- 4:50 AM QtWebKitTodo edited by
- (diff)
- 4:48 AM QtWebKitTodo edited by
- (diff)
- 12:31 AM Changeset in webkit [42538] by
-
- 6 edits1 copy in trunk/JavaScriptCore
Move CallFrameClosure from inside the Interpreter class to its own file.
Reviewed by NOBODY(Build fix)
- 12:13 AM Changeset in webkit [42537] by
-
- 10 edits2 adds in trunk
Bug 25202: Improve performance of repeated callbacks into the VM
Reviewed by Cameron Zwarich
Add the concept of a CachedCall to native code for use in Array
prototype and similar functions where a single callback function
is called repeatedly with the same number of arguments.
Used Array.prototype.filter as the test function and got a 50% win
over a naive non-caching specialised version. This makes the native
implementation of Array.prototype.filter faster than the JS one once
more.
Apr 14, 2009:
- 11:43 PM Changeset in webkit [42536] by
-
- 5 edits in trunk/WebCore
Rubber-stamped by Darin Adler.
Don't keep platform objects for authentication challenge in ResourceHandleInternal.
We already have a copy in AuthenticationChallenge object.
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::clearAuthentication):
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandle::receivedCancellation):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::didCancelAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandle::receivedCancellation):
- 10:06 PM Changeset in webkit [42535] by
-
- 2 edits in trunk/WebKit/mac
2009-04-14 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Move the run loop observer cleanup from -close
to -_close.
- WebView/WebView.mm: (-[WebView _close]): (-[WebView close]):
- 9:19 PM Changeset in webkit [42534] by
-
- 2 edits in trunk/WebCore
2009-04-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Nixed some now-defunct autogeneration code.
- bindings/scripts/CodeGeneratorJS.pm:
- 6:42 PM Changeset in webkit [42533] by
-
- 3 edits7 adds in trunk
2009-04-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by NOBODY (OOPS!).
Fix <rdar://problem/6755724> <audio> and <video> elements can reference local
file:/// URLs from remote in Safari
Tests: http/tests/security/local-video-poster-from-remote.html
http/tests/security/local-video-source-from-remote.html
http/tests/security/local-video-src-from-remote.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): Don't pass url to media engine if loader->canLoad() says it should not be loaded.
2009-04-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by NOBODY (OOPS!).
Fix <rdar://problem/6755724> <audio> and <video> elements can reference local
file:/// URLs from remote in Safari
Test cases to ensure that local 'src', 'poster', and <source> are not loaded.
- http/tests/security/local-video-poster-from-remote-expected.txt: Added.
- http/tests/security/local-video-poster-from-remote.html: Added.
- http/tests/security/local-video-source-from-remote-expected.txt: Added.
- http/tests/security/local-video-source-from-remote.html: Added.
- http/tests/security/local-video-src-from-remote-expected.txt: Added.
- http/tests/security/local-video-src-from-remote.html: Added.
- http/tests/security/resources/load-media.cgi: Added.
- 6:15 PM Changeset in webkit [42532] by
-
- 4 edits2 adds in trunk
WebCore:
2009-04-14 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Part of <rdar://problem/6150868>
Fix incorrect handling of content that needs to go into the head element
once the head element has been removed.
Test: fast/parser/head-content-after-head-removal.html
- html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): Remove unneeded initializer of m_head. (WebCore::HTMLParser::handleError): Update since m_head is now a RefPtr. (WebCore::HTMLParser::createHead): Ditto.
- html/HTMLParser.h: Make m_head a RefPtr.
LayoutTests:
2009-04-14 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Part of <rdar://problem/6150868>
Test for incorrect handling of content that needs to go into the head element
once the head element has been removed.
- fast/parser/head-content-after-head-removal-expected.txt: Added.
- fast/parser/head-content-after-head-removal.html: Added.
- 4:11 PM Changeset in webkit [42531] by
-
- 3 edits in trunk/WebCore
2009-04-14 Geoffrey Garen <ggaren@apple.com>
Used svn merge -r42529:42528 to roll out my last patch because it broke
the build.
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): (WebCore::JSDOMGlobalObject::findJSProtectedEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener): (WebCore::JSDOMGlobalObject::jsProtectedEventListeners): (WebCore::JSDOMGlobalObject::jsProtectedInlineEventListeners):
- bindings/js/JSDOMGlobalObject.h:
- 3:58 PM Changeset in webkit [42530] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.5
Tagging 1.1.5.
- 3:54 PM Changeset in webkit [42529] by
-
- 3 edits in trunk/WebCore
2009-04-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Nixed some now-dead code related to protected event listeners.
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
- bindings/js/JSDOMGlobalObject.h:
- 3:48 PM Changeset in webkit [42528] by
-
- 5 edits in trunk/WebCore
2009-04-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions
Stop using protected event listeners on SVGElementInstance.
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::mark): Mark our event listeners, since they're not protected anymore.
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener): Make unprotected
event listeners, since we mark them now.
- bindings/scripts/CodeGeneratorJS.pm: Autogenerate event listener invalidation for SVGElementInstance.
- svg/SVGElementInstance.h: (WebCore::SVGElementInstance::eventListeners): Added an accessor, for the sake of autogenerated code.
- svg/SVGElementInstance.idl: Removed the ProtectedEventListener attribute from event listener properties. Added a CustomMarkFunction attribute, since we need to mark our event listeners.
- 3:47 PM Changeset in webkit [42527] by
-
- 2 edits in trunk/WebKit/mac
2009-04-14 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
- Speculative fix for <rdar://problem/6781422>
Protect the plug-in instance proxy in case it's deleted while waiting for a reply.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::wheelEvent):
- 3:30 PM Changeset in webkit [42526] by
-
- 2 edits in trunk/WebCore
Windows build fix
- 3:26 PM Changeset in webkit [42525] by
-
- 4 edits in trunk
Versioning.
- 3:25 PM Changeset in webkit [42524] by
-
- 1 copy in tags/Safari-6530.6
New tag.
- 3:04 PM Changeset in webkit [42523] by
-
- 2 edits in trunk/LayoutTests
Skip another test that sometimes times out on Windows
- platform/win/Skipped: Added dom/html/level2/html/table29.html.
- 2:33 PM Changeset in webkit [42522] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-14 Xan Lopez <xlopez@igalia.com>
Fix the build.
Add the yarr headers (and only the headers) to the build, so that
RegExp.cpp can compile. The headers are ifdefed out with yarr
disabled, so we don't need anything else for now.
- GNUmakefile.am:
- 2:23 PM Changeset in webkit [42521] by
-
- 100 edits in trunk/WebCore
Add header guards to WebCore forwarding headers.
Speeds up WebCore debug build on Windows by 12% on my system,
since Visual Studio appears to not optimize for standard header
guards in included files.
Rubber stamped by Ada Chan.
- 1:56 PM Changeset in webkit [42520] by
-
- 2 edits in trunk/LayoutTests
Skip a test that sometimes times out on Windows
- platform/win/Skipped: Added http/tests/incremental/slow-utf8-text.pl.
- 1:53 PM Changeset in webkit [42519] by
-
- 3 edits in trunk/WebCore
2009-04-14 Sam Weinig <sam@webkit.org>
Reviewed by Adele Peterson.
Use a template function to generalize the way we create non-caching
JS function getters.
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDOMWindowCustom.h: (WebCore::nonCachingStaticFunctionGetter): (WebCore::JSDOMWindow::customGetOwnPropertySlot):
- 1:53 PM Changeset in webkit [42518] by
-
- 2 edits in trunk/WebKitTools
Skip another JavaScriptCore test that sometimes fails on Windows
See Bug 25160: Various ecma/Date tests sometimes fail on Windows (but
not Mac)
<https://bugs.webkit.org/show_bug.cgi?id=25160>
Rubber-stamped by Geoff Garen.
- Scripts/run-javascriptcore-tests: Skip ecma/Date/15.9.2.2-3.js.
- 1:46 PM Changeset in webkit [42517] by
-
- 2 edits in trunk/LayoutTests
Skip a sometimes-failing test on Windows
Rubber-stamped by Simon Fraser.
- platform/win/Skipped: Added transitions/zero-duration-with-non-zero-delay-end.html.
- 1:46 PM Changeset in webkit [42516] by
-
- 3 edits in trunk
2009-04-14 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by George Staikos.
When creating a QNetworkRequest make sure to populate the
CacheLoadControlAttribute with the value set by the ResourceRequest::cachePolicy() so that the cache will be used as WebKit expects.
- 1:14 PM Changeset in webkit [42515] by
-
- 2 edits in trunk/WebKit/qt
2009-04-14 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
Fix linking against QtWebKit for Symbian and other platforms
where the OS ABI distinguishes between an import or an export situation.
- 12:53 PM Changeset in webkit [42514] by
-
- 3 edits in trunk/WebKit/mac
2009-04-14 Adele Peterson <adele@apple.com>
Reviewed by Darin.
Initialize WebKitSystemInterface in class methods that could get called before a WebView/WebFrame is set up. This was causing Mail to crash on launch.
- Misc/WebCache.mm: (+[WebCache initialize]):
- WebView/WebView.mm: (+[WebView initialize]):
- 12:25 PM Changeset in webkit [42513] by
-
- 2 edits in trunk/WebKitTools
Build fix. Move the DerivedSources.make calls into build-wxwebkit so that the FEATURE_DEFINES are parsed properly.
- 12:06 PM Changeset in webkit [42512] by
-
- 4 edits in trunk/WebCore
Fix a world leak caused by opening the Web Inspector. This was
a regression caused by the InspectorController becoming refcounted.
<rdar://problem/6782944>
Reviewed by Darin Adler.
- bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::get): Renamed to better match the other functions. (WebCore::ScriptGlobalObject::remove): Added. Deletes the property.
- bindings/js/ScriptObject.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): Do less work at destruction time since the object lifetime is tied to JS GC. Assert that inspectedPageDestroyed cleared everything needed. (WebCore::InspectorController::inspectedPageDestroyed): Do most of the work that ~InspectorController was doing. (WebCore::InspectorController::scriptObjectReady): Renamed getObject.
- 11:59 AM Changeset in webkit [42511] by
-
- 1 edit in trunk/WebCore/ChangeLog
2009-04-14 Dmitry Titov <dimich@chromium.org>
Fixing ChangeLog.
- 11:55 AM Changeset in webkit [42510] by
-
- 3 edits in trunk/WebCore
2009-04-14 Antony Sargent <asargent@chromium.org>
Reviewed by Dimitri Glazkov.
This is some cleanup motivated by the crash in http://crbug.com/9775 , which
happens because of calling window.open inside a window.onload handler.
These changes are just part of the fix, along with some asserts to help prevent
breakage on future changes.
- bindings/v8/V8EventListenerList.cpp: (WebCore::V8EventListenerList::add): (WebCore::V8EventListenerList::remove): (WebCore::V8EventListenerList::clear):
- bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::size):
- 11:55 AM Changeset in webkit [42509] by
-
- 2 edits in trunk/WebCore
2009-04-14 Evan Martin <evan@chromium.org>
Reviewed by Darin Adler.
Fix a race that can occur between flex and the perl script that parses
its output.
- css/maketokenizer: Consume all input.
- 11:55 AM Changeset in webkit [42508] by
-
- 2 edits in trunk/WebCore
2009-04-14 Rohit Rao <rohitrao@google.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=25184
Do not change the text color for selected text in Mac Chromium.
- rendering/RenderThemeChromiumMac.h: (WebCore::RenderThemeChromiumMac::supportsSelectionForegroundColors): Now returns false, matching the behavior of Safari on Mac.
- 11:48 AM Changeset in webkit [42507] by
-
- 11 edits in trunk/WebCore
2009-04-13 Justin Garcia <justin.garcia@apple.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25172
Extra partial layout during the first keypress in an empty block
Determining if a placeholder needs to be removed requires the creation of a VisiblePosition
which was triggering layout before we were finished modifying the DOM for the insert operation.
Find out if we need to remove a placeholder near the start of the operation, and if we do remember
where it's located. Then, later, remove it along with all of the other DOM operations we perform.
Renamed lineBreakExistsAtPosition to lineBreakExistsAtVisiblePosition and added a lineBreakExistsAtPosition
that takes in a Position. In InsertTextCommand, we can use the latter, since we normalize manually.
removePlaceholderAt now takes in a Position that it assumes has already been checked for a placeholder.
No test added as this only effects performance.
- editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removePlaceholderAt): (WebCore::CompositeEditCommand::moveParagraphs): (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
- editing/CompositeEditCommand.h:
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): (WebCore::DeleteSelectionCommand::doApply):
- editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply):
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
- editing/htmlediting.cpp: (WebCore::lineBreakExistsAtVisiblePosition): (WebCore::lineBreakExistsAtPosition):
- editing/htmlediting.h:
- 11:35 AM Changeset in webkit [42506] by
-
- 6 edits in trunk
Remove support for profile-guided optimization on Windows
Remove support for profile-guided optimization on Windows
Rubber-stamped by Steve Falkenburg.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed the Release_PGO configuration. Also let VS re-order the source files list.
WebCore:
Remove support for profile-guided optimization on Windows
Rubber-stamped by Steve Falkenburg.
- WebCore.vcproj/WebCore.vcproj: Removed the Release_PGO configuration.
WebKit/win:
Remove support for profile-guided optimization on Windows
Rubber-stamped by Steve Falkenburg.
- WebKit.vcproj/WebKit.vcproj: Removed the Release_PGOInstrument and Release_PGOOptimize configurations.
- 11:32 AM Changeset in webkit [42505] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-14 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
- GNUmakefile.am:
- 11:15 AM Changeset in webkit [42504] by
-
- 5 edits in trunk/WebCore
2009-04-14 Dmitry Titov <dimich@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25163
Upstream fix for releasing v8 objects on worker thread termination in Chromium.
- bindings/v8/V8DOMMap.cpp: (WebCore::domDataList): Now uses Vector instead of HashMap. (WebCore::domDataListMutex): (WebCore::ThreadSpecificDOMData::ThreadSpecificDOMData): remove usage of currentThread(); (WebCore::ThreadSpecificDOMData::~ThreadSpecificDOMData): ditto. (WebCore::NonMainThreadSpecificDOMData::~NonMainThreadSpecificDOMData): moved call to removeAllDOMObjectsInCurrentThread() to ~WorkerScriptController. (WebCore::handleWeakObjectInOwningThread): (WebCore::derefDelayedObjects): (WebCore::removeAllDOMObjectsInCurrentThread): not static anymore.
- bindings/v8/V8DOMMap.h:
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::dispose): removed code that avoided dual-dereference of WorkerContext. (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): this ref() is countered in removeAllDOMObjectsInCurrentThread(), when the WorkerContext is removed from the v8 map.
- bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):
- 11:08 AM Changeset in webkit [42503] by
-
- 2 edits7 adds in trunk/WebCore
Fix Bug 25183: Split up WebCore.vcproj's settings into vsprops files
WebCore.vcproj now uses a set of .vsprops files to store most of its
settings.
Reviewed by Darin Adler.
- WebCore.vcproj/WebCore.vcproj: Moved settings from here into the new .vsprops files.
- WebCore.vcproj/WebCoreCFNetwork.vsprops: Added. Contains settings for ports that build against CFNetwork.
- WebCore.vcproj/WebCoreCG.vsprops: Added. Contains settings for ports that build against CoreGraphics.
- WebCore.vcproj/WebCoreCURL.vsprops: Added. Contains settings for ports that build against libcurl.
- WebCore.vcproj/WebCoreCairo.vsprops: Added. Contains settings for ports that build against Cairo.
- WebCore.vcproj/WebCoreCommon.vsprops: Added. Contains settings shared by all ports.
- WebCore.vcproj/WebCoreMediaQT.vsprops: Added. Contains settings for ports that use QTMovieWin to implement the MediaPlayerPrivate interface.
- WebCore.vcproj/WebCorePthreads.vsprops: Added. Contains settings for ports that build against pthreads.
- 10:56 AM Changeset in webkit [42502] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
http/tests/xmlhttprequest/basic-auth.html fails on Tiger.
Turns out that NSURLCredentialPersistenceNone doesn't work on Tiger, so we have to use
session persistence.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Route the credential through receivedCredential(), ensuring that the Tiger-specific need to use session credentials is honored. (WebCore::ResourceHandle::receivedCredential): On Tiger, change PersistenceNone to PersistenceForSession, because the former doesn't work.
- 10:40 AM Changeset in webkit [42501] by
-
- 2 edits4 adds in trunk
2009-04-13 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/6703873> Triple-click quoted line and type Return creates an extra quoted blank line
Test: editing/inserting/6703873.html
- editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): If the startNode's original parent is now empty, we can remove it. Its already been cloned and copied with the startNode, so we only need to keep it around if it actually holds some original content, otherwise it will look like an extra empty container in the document.
- 9:52 AM Changeset in webkit [42500] by
-
- 3 edits in trunk/WebKit/gtk
2009-04-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Update gtk-doc control and base sgml files for 1.1.5.
- docs/webkitgtk-docs.sgml:
- docs/webkitgtk-sections.txt:
- 9:44 AM Changeset in webkit [42499] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-14 Xan Lopez <xlopez@igalia.com>
- NEWS: updated for 1.1.5 release.
- 9:14 AM Changeset in webkit [42498] by
-
- 2 edits in trunk
2009-04-14 Xan Lopez <xlopez@igalia.com>
Unreviewed version bump in preparation for 1.1.5 release.
- configure.ac:
- 8:56 AM Changeset in webkit [42497] by
-
- 2 edits in trunk/WebCore
2009-04-14 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Add a proper implementation of AtkText::get_text and
AtkText::get_character_count, which takes into account non
TextControl text. With this the 'Text' field in Accerciser's
Interface Viewer is filled correctly.
- page/gtk/AccessibilityObjectWrapperAtk.cpp:
- 8:56 AM Changeset in webkit [42496] by
-
- 2 edits in trunk/WebCore
2009-04-14 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Remove some dead code and g_return_if_fail from static functions.
- page/gtk/AccessibilityObjectWrapperAtk.cpp:
- 8:56 AM Changeset in webkit [42495] by
-
- 2 edits in trunk/WebCore
2009-04-14 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Also implement text interface for StaticTextRole, which covers
most of the text in web pages.
- page/gtk/AccessibilityObjectWrapperAtk.cpp:
- 8:07 AM Changeset in webkit [42494] by
-
- 4 edits in trunk/WebKit/qt
2009-04-14 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Tor Arne Vestbø.
Rename QWebElement::setHtml and html to setXml and toXml respectivily.
Also add a mean to define the scope (inner or other).
- 7:53 AM Changeset in webkit [42493] by
-
- 1 edit2 copies2 adds in trunk/LayoutTests
Land updated Windows results for two tests changed by r42471
Rubber-stamped by Anders Carlsson.
- platform/win/css1/text_properties/text_transform-expected.txt: Copied from LayoutTests/platform/mac-leopard/css1/text_properties/text_transform-expected.txt.
- platform/win/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt: Copied from LayoutTests/platform/mac-leopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt.
- 7:53 AM Changeset in webkit [42492] by
-
- 2 edits in trunk/WebKitTools
Small run-javascriptcore-tests cleanup
Reviewed by Cameron Zwarich.
- Scripts/run-javascriptcore-tests: Move the list of tests to skip into its own variable, annotated with the bugs that are filed about the various failures.
- 7:52 AM Changeset in webkit [42491] by
-
- 2 edits in trunk/WebKitTools
Skip another sometimes-failing ecma/Date test on Windows
These failing tests are covered by Bug 25160: Various ecma/Date tests
sometimes fail on Windows (but not Mac)
<https://bugs.webkit.org/show_bug.cgi?id=25160>
Reviewed by Cameron Zwarich.
- Scripts/run-javascriptcore-tests: Added ecma/Date/15.9.2.1.js to the list of tests to skip.
- 7:37 AM QtWebKitTodo edited by
- (diff)
- 7:30 AM QtWebKitJournal edited by
- (diff)
- 7:08 AM Changeset in webkit [42490] by
-
- 4 edits in trunk/WebKit/qt
2009-04-14 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Tor Arne Vestbø.
Rename QWebElement::setText() and text() to ::setPlainText and
::toPlainText, respectively.
- 6:31 AM QtWebKitTodo edited by
- (diff)
- 6:17 AM QtWebKitTodo edited by
- (diff)
- 6:12 AM QtWebKitTodo edited by
- (diff)
- 5:15 AM QtWebKitTodo edited by
- (diff)
- 5:14 AM QtWebKitTodo edited by
- (diff)
- 4:55 AM QtWebKitGitInstructions edited by
- (diff)
- 4:54 AM QtWebKitGitInstructions edited by
- (diff)
- 4:43 AM QtWebKitTodo edited by
- (diff)
- 4:30 AM QtWebKitJournal edited by
- (diff)
- 4:30 AM Changeset in webkit [42489] by
-
- 5 edits in trunk
2009-04-14 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] disable soup auth dialog when running DRT
https://bugs.webkit.org/show_bug.cgi?id=24598
Disable soup's auth dialog when running the tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (setDefaultsToConsistentStateValuesForTesting):
- GNUmakefile.am:
2009-04-14 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] disable soup auth dialog when running DRT
https://bugs.webkit.org/show_bug.cgi?id=24598
Enable http/tests/xmlhttprequest/failed-auth.html test. We should
be able to run this test in non-interactive mode
- platform/gtk/Skipped:
- 4:16 AM Changeset in webkit [42488] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-14 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix when building minidom. Not reviewed.
Use C-style comment instead of C++ style since autotools builds
minidom using gcc and not g++.
- wtf/Platform.h:
- 3:19 AM Changeset in webkit [42487] by
-
- 3 edits in trunk/WebKitLibraries
Update WebKitSystemInterface so that the Tiger portion supports PowerPC.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 1:41 AM Changeset in webkit [42486] by
-
- 2 edits in trunk/WebCore
Another Windows build fix.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::WebCoreSynchronousLoader::load):
- 1:24 AM Changeset in webkit [42485] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::WebCoreSynchronousLoader::willSendRequest): (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
- 1:16 AM Changeset in webkit [42484] by
-
- 1 edit in trunk/WebCore/ChangeLog
Removed mentions of tests from ChangeLog - I'll land those once OS-level support for this feature is in.
- 1:11 AM Changeset in webkit [42483] by
-
- 26 edits in trunk/WebCore
Reviewed by Sam Weinig.
<rdar://problem/6698851> Implement XMLHttpRequest withCredentials attribute
Tests: http/tests/xmlhttprequest/cross-origin-authorization.html
http/tests/xmlhttprequest/cross-origin-no-authorization.html
- WebCore.xcodeproj/project.pbxproj: Made ThreadableLoader.h private, as enum definitions from it are now used in otehr private headers.
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequest.idl: Added withCredentials attribute. When it is false (default), neither credentials nor cookies are sent with cross origin requests, When it is true, those are sent, but the server needs to allow handling results via Access-Control-Allow-Credentials header. It was always possible to send a cross-site request with credentials via IFRAME or IMG, so this just adds a way to read results, as long as the server reports that it's allowed. Having the default set to false ensures that requests won't fail unexpectedly because of stored credentials and cookies for other resources in the target protection space.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestSynchronously): Allow stored credentials for same origin requests, and for cross origin ones that have withCredentials attribute set. Such code already existed for cookies (but it's simpler, because we could just set a ResourceRequest flag). (WebCore::XMLHttpRequest::loadRequestAsynchronously): Ditto.
- platform/network/ResourceHandle.h: Added willSendRequest() - just like for other callbacks, is is easier to have code in the class. Also, loadResourceSynchronously() now takes a StoredCredentials option, matching async case.
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::receivedCredential): Removed. This method could never be called, and no client used it. (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential): Ditto.
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Split username and password out of request URL. We want to always get a callback for credentials to manage them in WebCore, so network back-end shouldn't see them too early.
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::removeCredentials):
- platform/network/ResourceRequestBase.h: Added a removeCredentials() method that removes login and password parts from request URL.
- platform/network/mac/ResourceHandleMac.mm: (WebCoreCredentialStorage): Added a simple storage class for per-session credentials. (WebCore::ResourceHandle::loadResourceSynchronously): Pass allowStoredCredentials through. (WebCore::ResourceHandle::willSendRequest): On a redirect, credentials should be replaced. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Try credentials from the URL and per-session credentials. Code was partially moved from Obj-C callback. (WebCore::ResourceHandle::receivedCredential): Intercept per-session credentials and store them in WebCore storage. (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Don't store the redirected URL - we only needed credentials, which are now stored separately. (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Removed code that was setting credentials from URL. First, the code is now in ResourceHandle, and also, it wasn't actually needed in Leopard release before this patch, see <rdar://problem/5298142>. (-[WebCoreSynchronousLoader dealloc]): Release credentials. Note that unlike ResourceHandle, this class still needs to track URL for checking whether a redirect is allowed. This is not a great solution, and we should unify client code to use the same checks in sync and async cases. (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Just like in async case, put credentials aside to ensure that network back-end asks for them. (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use credentials from URL, or from WebCore storage. (-[WebCoreSynchronousLoader connectionShouldUseCredentialStorage:]): Don't use stored credentials when not allowed to. (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Put credentials aside to ensure that network back-end asks for them.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::WebCoreCredentialStorage::set): (WebCore::WebCoreCredentialStorage::get): (WebCore::willSendRequest): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::willSendRequest): (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::WebCoreSynchronousLoader::willSendRequest): (WebCore::WebCoreSynchronousLoader::didReceiveChallenge): (WebCore::WebCoreSynchronousLoader::shouldUseCredentialStorage): (WebCore::WebCoreSynchronousLoader::load): Same changes as in Mac case.
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::loadResourceSynchronously):
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::loadResourceSynchronously):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Trying not to break the build.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::openFunc):
- xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc): Unconditionally allow stored credentials for these, as they only support same origin loads.
- workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts): WorkerContext.importScripts() can be cross-origin, but sending credentials with it is no worse than sending them with <script src=...>, so this is also unconditionally allowed.
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadResourceSynchronously): Pass through storedCredentials. (WebCore::DocumentThreadableLoader::create): Ditto. (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Save storedCredentials and sameOrigin flags foruse in callbacks. (WebCore::DocumentThreadableLoader::willSendRequest): Assert that loaders aren't all confused. (WebCore::DocumentThreadableLoader::didSendData): Ditto. (WebCore::DocumentThreadableLoader::didReceiveResponse): Ditto. (WebCore::DocumentThreadableLoader::didReceiveData): Ditto. (WebCore::DocumentThreadableLoader::didFinishLoading): Ditto. (WebCore::DocumentThreadableLoader::didFail): Ditto. (WebCore::DocumentThreadableLoader::getShouldUseCredentialStorage): Don't use credential storage if that's not allowed by the code that invoked DocumentThreadableLoader. (WebCore::DocumentThreadableLoader::didReceiveAuthenticationChallenge): Simulate a failure and cancel the request if we are about to ask the user for credentials for a cross-origin request, which is forbidden by CORS (and would have been very confusing if allowed). (WebCore::DocumentThreadableLoader::receivedCancellation): Assert that loaders aren't all confused.
- loader/DocumentThreadableLoader.h: Updated for the new flags (storedCredentials and sameOrigin) that affect the loader. Eventually, we need to move all CORS logic from XHR here.
- loader/ThreadableLoader.h: (StoredCredentials): Added another flag that affects loader behavior. We should combine all of these into a structure, and use it for sync requests, too.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously):
- loader/FrameLoader.h:
- loader/ThreadableLoader.cpp: (WebCore::ThreadableLoader::create): (WebCore::ThreadableLoader::loadResourceSynchronously):
- loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): (WebCore::WorkerThreadableLoader::loadResourceSynchronously): (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
- loader/WorkerThreadableLoader.h: (WebCore::WorkerThreadableLoader::create): Pass through storedCredentials.
- 12:19 AM Changeset in webkit [42482] by
-
- 2 edits in trunk/JavaScriptCore
speculative 'doze build fix
- 12:06 AM Changeset in webkit [42481] by
-
- 7 edits9 adds in trunk/JavaScriptCore
2009-04-13 Gavin Barraclough <barraclough@apple.com>
Reviewed by Cap'n Geoff Garen.
Yarr!
(Yet another regex runtime).
Currently disabled by default since the interpreter, whilst awesomely
functional, has not been optimized and is likely slower than PCRE, and
the JIT, whilst faster than WREC, is presently incomplete and does not
fallback to using an interpreter for the cases it cannot handle.
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::move): (JSC::MacroAssemblerX86Common::swap): (JSC::MacroAssemblerX86Common::signExtend32ToPtr): (JSC::MacroAssemblerX86Common::zeroExtend32ToPtr): (JSC::MacroAssemblerX86Common::branch32): (JSC::MacroAssemblerX86Common::branch16):
- assembler/X86Assembler.h: (JSC::X86Assembler::cmpw_im): (JSC::X86Assembler::testw_rr): (JSC::X86Assembler::X86InstructionFormatter::immediate16):
- runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::~RegExp): (JSC::RegExp::create): (JSC::RegExp::compile): (JSC::RegExp::match):
- runtime/RegExp.h:
- wtf/Platform.h:
- yarr: Added.
- yarr/RegexCompiler.cpp: Added. (JSC::Yarr::CharacterClassConstructor::CharacterClassConstructor): (JSC::Yarr::CharacterClassConstructor::reset): (JSC::Yarr::CharacterClassConstructor::append): (JSC::Yarr::CharacterClassConstructor::putChar): (JSC::Yarr::CharacterClassConstructor::isUnicodeUpper): (JSC::Yarr::CharacterClassConstructor::isUnicodeLower): (JSC::Yarr::CharacterClassConstructor::putRange): (JSC::Yarr::CharacterClassConstructor::charClass): (JSC::Yarr::CharacterClassConstructor::addSorted): (JSC::Yarr::CharacterClassConstructor::addSortedRange): (JSC::Yarr::newlineCreate): (JSC::Yarr::digitsCreate): (JSC::Yarr::spacesCreate): (JSC::Yarr::wordcharCreate): (JSC::Yarr::nondigitsCreate): (JSC::Yarr::nonspacesCreate): (JSC::Yarr::nonwordcharCreate): (JSC::Yarr::RegexPatternConstructor::RegexPatternConstructor): (JSC::Yarr::RegexPatternConstructor::~RegexPatternConstructor): (JSC::Yarr::RegexPatternConstructor::reset): (JSC::Yarr::RegexPatternConstructor::assertionBOL): (JSC::Yarr::RegexPatternConstructor::assertionEOL): (JSC::Yarr::RegexPatternConstructor::assertionWordBoundary): (JSC::Yarr::RegexPatternConstructor::atomPatternCharacter): (JSC::Yarr::RegexPatternConstructor::atomBuiltInCharacterClass): (JSC::Yarr::RegexPatternConstructor::atomCharacterClassBegin): (JSC::Yarr::RegexPatternConstructor::atomCharacterClassAtom): (JSC::Yarr::RegexPatternConstructor::atomCharacterClassRange): (JSC::Yarr::RegexPatternConstructor::atomCharacterClassBuiltIn): (JSC::Yarr::RegexPatternConstructor::atomCharacterClassEnd): (JSC::Yarr::RegexPatternConstructor::atomParenthesesSubpatternBegin): (JSC::Yarr::RegexPatternConstructor::atomParentheticalAssertionBegin): (JSC::Yarr::RegexPatternConstructor::atomParenthesesEnd): (JSC::Yarr::RegexPatternConstructor::atomBackReference): (JSC::Yarr::RegexPatternConstructor::copyDisjunction): (JSC::Yarr::RegexPatternConstructor::copyTerm): (JSC::Yarr::RegexPatternConstructor::quantifyAtom): (JSC::Yarr::RegexPatternConstructor::disjunction): (JSC::Yarr::RegexPatternConstructor::regexBegin): (JSC::Yarr::RegexPatternConstructor::regexEnd): (JSC::Yarr::RegexPatternConstructor::regexError): (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets): (JSC::Yarr::RegexPatternConstructor::setupDisjunctionOffsets): (JSC::Yarr::RegexPatternConstructor::setupOffsets): (JSC::Yarr::compileRegex):
- yarr/RegexCompiler.h: Added.
- yarr/RegexInterpreter.cpp: Added. (JSC::Yarr::Interpreter::appendParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::popParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::DisjunctionContext::DisjunctionContext): (JSC::Yarr::Interpreter::DisjunctionContext::operator new): (JSC::Yarr::Interpreter::allocDisjunctionContext): (JSC::Yarr::Interpreter::freeDisjunctionContext): (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::operator new): (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::restoreOutput): (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::getDisjunctionContext): (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::InputStream::InputStream): (JSC::Yarr::Interpreter::InputStream::next): (JSC::Yarr::Interpreter::InputStream::rewind): (JSC::Yarr::Interpreter::InputStream::read): (JSC::Yarr::Interpreter::InputStream::readChecked): (JSC::Yarr::Interpreter::InputStream::reread): (JSC::Yarr::Interpreter::InputStream::prev): (JSC::Yarr::Interpreter::InputStream::getPos): (JSC::Yarr::Interpreter::InputStream::setPos): (JSC::Yarr::Interpreter::InputStream::atStart): (JSC::Yarr::Interpreter::InputStream::atEnd): (JSC::Yarr::Interpreter::InputStream::checkInput): (JSC::Yarr::Interpreter::InputStream::uncheckInput): (JSC::Yarr::Interpreter::testCharacterClass): (JSC::Yarr::Interpreter::tryConsumeCharacter): (JSC::Yarr::Interpreter::checkCharacter): (JSC::Yarr::Interpreter::tryConsumeCharacterClass): (JSC::Yarr::Interpreter::checkCharacterClass): (JSC::Yarr::Interpreter::tryConsumeBackReference): (JSC::Yarr::Interpreter::matchAssertionBOL): (JSC::Yarr::Interpreter::matchAssertionEOL): (JSC::Yarr::Interpreter::matchAssertionWordBoundary): (JSC::Yarr::Interpreter::matchPatternCharacter): (JSC::Yarr::Interpreter::backtrackPatternCharacter): (JSC::Yarr::Interpreter::matchCharacterClass): (JSC::Yarr::Interpreter::backtrackCharacterClass): (JSC::Yarr::Interpreter::matchBackReference): (JSC::Yarr::Interpreter::backtrackBackReference): (JSC::Yarr::Interpreter::recordParenthesesMatch): (JSC::Yarr::Interpreter::resetMatches): (JSC::Yarr::Interpreter::resetAssertionMatches): (JSC::Yarr::Interpreter::parenthesesDoBacktrack): (JSC::Yarr::Interpreter::matchParenthesesOnceBegin): (JSC::Yarr::Interpreter::matchParenthesesOnceEnd): (JSC::Yarr::Interpreter::backtrackParenthesesOnceBegin): (JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd): (JSC::Yarr::Interpreter::matchParentheticalAssertionOnceBegin): (JSC::Yarr::Interpreter::matchParentheticalAssertionOnceEnd): (JSC::Yarr::Interpreter::backtrackParentheticalAssertionOnceBegin): (JSC::Yarr::Interpreter::backtrackParentheticalAssertionOnceEnd): (JSC::Yarr::Interpreter::matchParentheses): (JSC::Yarr::Interpreter::backtrackParentheses): (JSC::Yarr::Interpreter::matchTerm): (JSC::Yarr::Interpreter::backtrackTerm): (JSC::Yarr::Interpreter::matchAlternative): (JSC::Yarr::Interpreter::matchDisjunction): (JSC::Yarr::Interpreter::matchNonZeroDisjunction): (JSC::Yarr::Interpreter::interpret): (JSC::Yarr::Interpreter::Interpreter): (JSC::Yarr::ByteCompiler::ParenthesesStackEntry::ParenthesesStackEntry): (JSC::Yarr::ByteCompiler::ByteCompiler): (JSC::Yarr::ByteCompiler::compile): (JSC::Yarr::ByteCompiler::checkInput): (JSC::Yarr::ByteCompiler::assertionBOL): (JSC::Yarr::ByteCompiler::assertionEOL): (JSC::Yarr::ByteCompiler::assertionWordBoundary): (JSC::Yarr::ByteCompiler::atomPatternCharacter): (JSC::Yarr::ByteCompiler::atomCharacterClass): (JSC::Yarr::ByteCompiler::atomBackReference): (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin): (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin): (JSC::Yarr::ByteCompiler::popParenthesesStack): (JSC::Yarr::ByteCompiler::dumpDisjunction): (JSC::Yarr::ByteCompiler::closeAlternative): (JSC::Yarr::ByteCompiler::atomParenthesesEnd): (JSC::Yarr::ByteCompiler::regexBegin): (JSC::Yarr::ByteCompiler::regexEnd): (JSC::Yarr::ByteCompiler::alterantiveDisjunction): (JSC::Yarr::ByteCompiler::emitDisjunction): (JSC::Yarr::byteCompileRegex): (JSC::Yarr::interpretRegex):
- yarr/RegexInterpreter.h: Added. (JSC::Yarr::ByteTerm::): (JSC::Yarr::ByteTerm::ByteTerm): (JSC::Yarr::ByteTerm::BOL): (JSC::Yarr::ByteTerm::CheckInput): (JSC::Yarr::ByteTerm::EOL): (JSC::Yarr::ByteTerm::WordBoundary): (JSC::Yarr::ByteTerm::BackReference): (JSC::Yarr::ByteTerm::AlternativeBegin): (JSC::Yarr::ByteTerm::AlternativeDisjunction): (JSC::Yarr::ByteTerm::AlternativeEnd): (JSC::Yarr::ByteTerm::PatternEnd): (JSC::Yarr::ByteTerm::invert): (JSC::Yarr::ByteTerm::capture): (JSC::Yarr::ByteDisjunction::ByteDisjunction): (JSC::Yarr::BytecodePattern::BytecodePattern): (JSC::Yarr::BytecodePattern::~BytecodePattern):
- yarr/RegexJIT.cpp: Added. (JSC::Yarr::RegexGenerator::optimizeAlternative): (JSC::Yarr::RegexGenerator::matchCharacterClassRange): (JSC::Yarr::RegexGenerator::matchCharacterClass): (JSC::Yarr::RegexGenerator::jumpIfNoAvailableInput): (JSC::Yarr::RegexGenerator::jumpIfAvailableInput): (JSC::Yarr::RegexGenerator::checkInput): (JSC::Yarr::RegexGenerator::atEndOfInput): (JSC::Yarr::RegexGenerator::notAtEndOfInput): (JSC::Yarr::RegexGenerator::jumpIfCharEquals): (JSC::Yarr::RegexGenerator::jumpIfCharNotEquals): (JSC::Yarr::RegexGenerator::readCharacter): (JSC::Yarr::RegexGenerator::storeToFrame): (JSC::Yarr::RegexGenerator::loadFromFrame): (JSC::Yarr::RegexGenerator::TermGenerationState::TermGenerationState): (JSC::Yarr::RegexGenerator::TermGenerationState::resetAlternative): (JSC::Yarr::RegexGenerator::TermGenerationState::alternativeValid): (JSC::Yarr::RegexGenerator::TermGenerationState::nextAlternative): (JSC::Yarr::RegexGenerator::TermGenerationState::alternative): (JSC::Yarr::RegexGenerator::TermGenerationState::resetTerm): (JSC::Yarr::RegexGenerator::TermGenerationState::termValid): (JSC::Yarr::RegexGenerator::TermGenerationState::nextTerm): (JSC::Yarr::RegexGenerator::TermGenerationState::term): (JSC::Yarr::RegexGenerator::TermGenerationState::lookaheadTerm): (JSC::Yarr::RegexGenerator::TermGenerationState::isSinglePatternCharacterLookaheadTerm): (JSC::Yarr::RegexGenerator::TermGenerationState::inputOffset): (JSC::Yarr::RegexGenerator::TermGenerationState::jumpToBacktrack): (JSC::Yarr::RegexGenerator::TermGenerationState::setBacktrackGenerated): (JSC::Yarr::RegexGenerator::jumpToBacktrackCheckEmitPending): (JSC::Yarr::RegexGenerator::genertateAssertionBOL): (JSC::Yarr::RegexGenerator::genertateAssertionEOL): (JSC::Yarr::RegexGenerator::matchAssertionWordchar): (JSC::Yarr::RegexGenerator::genertateAssertionWordBoundary): (JSC::Yarr::RegexGenerator::genertatePatternCharacterSingle): (JSC::Yarr::RegexGenerator::genertatePatternCharacterPair): (JSC::Yarr::RegexGenerator::genertatePatternCharacterFixed): (JSC::Yarr::RegexGenerator::genertatePatternCharacterGreedy): (JSC::Yarr::RegexGenerator::genertatePatternCharacterNonGreedy): (JSC::Yarr::RegexGenerator::genertateCharacterClassSingle): (JSC::Yarr::RegexGenerator::genertateCharacterClassFixed): (JSC::Yarr::RegexGenerator::genertateCharacterClassGreedy): (JSC::Yarr::RegexGenerator::genertateCharacterClassNonGreedy): (JSC::Yarr::RegexGenerator::generateParenthesesSingleDisjunctionOneAlternative): (JSC::Yarr::RegexGenerator::generateParenthesesSingle): (JSC::Yarr::RegexGenerator::generateTerm): (JSC::Yarr::RegexGenerator::generateDisjunction): (JSC::Yarr::RegexGenerator::RegexGenerator): (JSC::Yarr::RegexGenerator::generate): (JSC::Yarr::jitCompileRegex): (JSC::Yarr::executeRegex):
- yarr/RegexJIT.h: Added. (JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
- yarr/RegexParser.h: Added. (JSC::Yarr::): (JSC::Yarr::Parser::): (JSC::Yarr::Parser::CharacterClassParserDelegate::CharacterClassParserDelegate): (JSC::Yarr::Parser::CharacterClassParserDelegate::begin): (JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacterUnescaped): (JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacter): (JSC::Yarr::Parser::CharacterClassParserDelegate::atomBuiltInCharacterClass): (JSC::Yarr::Parser::CharacterClassParserDelegate::end): (JSC::Yarr::Parser::CharacterClassParserDelegate::assertionWordBoundary): (JSC::Yarr::Parser::CharacterClassParserDelegate::atomBackReference): (JSC::Yarr::Parser::CharacterClassParserDelegate::flush): (JSC::Yarr::Parser::CharacterClassParserDelegate::): (JSC::Yarr::Parser::Parser): (JSC::Yarr::Parser::parseEscape): (JSC::Yarr::Parser::parseAtomEscape): (JSC::Yarr::Parser::parseCharacterClassEscape): (JSC::Yarr::Parser::parseCharacterClass): (JSC::Yarr::Parser::parseParenthesesBegin): (JSC::Yarr::Parser::parseParenthesesEnd): (JSC::Yarr::Parser::parseQuantifier): (JSC::Yarr::Parser::parseTokens): (JSC::Yarr::Parser::parse): (JSC::Yarr::Parser::saveState): (JSC::Yarr::Parser::restoreState): (JSC::Yarr::Parser::atEndOfPattern): (JSC::Yarr::Parser::peek): (JSC::Yarr::Parser::peekIsDigit): (JSC::Yarr::Parser::peekDigit): (JSC::Yarr::Parser::consume): (JSC::Yarr::Parser::consumeDigit): (JSC::Yarr::Parser::consumeNumber): (JSC::Yarr::Parser::consumeOctal): (JSC::Yarr::Parser::tryConsume): (JSC::Yarr::Parser::tryConsumeHex): (JSC::Yarr::parse):
- yarr/RegexPattern.h: Added. (JSC::Yarr::CharacterRange::CharacterRange): (JSC::Yarr::): (JSC::Yarr::PatternTerm::): (JSC::Yarr::PatternTerm::PatternTerm): (JSC::Yarr::PatternTerm::BOL): (JSC::Yarr::PatternTerm::EOL): (JSC::Yarr::PatternTerm::WordBoundary): (JSC::Yarr::PatternTerm::invert): (JSC::Yarr::PatternTerm::capture): (JSC::Yarr::PatternTerm::quantify): (JSC::Yarr::PatternAlternative::PatternAlternative): (JSC::Yarr::PatternAlternative::lastTerm): (JSC::Yarr::PatternAlternative::removeLastTerm): (JSC::Yarr::PatternDisjunction::PatternDisjunction): (JSC::Yarr::PatternDisjunction::~PatternDisjunction): (JSC::Yarr::PatternDisjunction::addNewAlternative): (JSC::Yarr::RegexPattern::RegexPattern): (JSC::Yarr::RegexPattern::~RegexPattern): (JSC::Yarr::RegexPattern::reset): (JSC::Yarr::RegexPattern::containsIllegalBackReference): (JSC::Yarr::RegexPattern::newlineCharacterClass): (JSC::Yarr::RegexPattern::digitsCharacterClass): (JSC::Yarr::RegexPattern::spacesCharacterClass): (JSC::Yarr::RegexPattern::wordcharCharacterClass): (JSC::Yarr::RegexPattern::nondigitsCharacterClass): (JSC::Yarr::RegexPattern::nonspacesCharacterClass): (JSC::Yarr::RegexPattern::nonwordcharCharacterClass):
Apr 13, 2009:
- 11:39 PM Changeset in webkit [42480] by
-
- 3 edits in trunk/JavaScriptCore
Missed code from last patch
- 11:33 PM Changeset in webkit [42479] by
-
- 2 edits in trunk/WebCore
2009-04-13 David Hyatt <hyatt@apple.com>
Reviewed by Cameron Zwarich.
Remove an outdated comment in ScrollView.h
- platform/ScrollView.h:
- 11:24 PM Changeset in webkit [42478] by
-
- 6 edits4 adds in trunk
BUG 25171: It should be possible to manually set the name of an anonymous function
<https://bugs.webkit.org/show_bug.cgi?id=25171>
Submitted by Francisco Tolmasky <francisco@280north.com>
Reviewed by Oliver Hunt.
This change adds the displayName property to functions, which when set overrides the
normal name when appearing in the console.
- 10:30 PM Moving to Git edited by
- trivial fix incorrect 'there' replaced with correct 'their' (diff)
- 10:03 PM Changeset in webkit [42477] by
-
- 2 edits in trunk/WebCore
2009-04-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Mark Rowe.
QTTrack's -media method always return NULL in 64-bit QTKit, so
MediaPlayerPrivate::disableUnsupportedTracks should use
QTTrackMediaTypeAttribute to get a track's type.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
- 9:52 PM Changeset in webkit [42476] by
-
- 8 edits in trunk/WebCore
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions
Stop using protected event listeners on the window object.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::mark): Mark our event listeners, since they're no longer protected.
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener): Create unprotected event
listeners, since we mark them now.
- bindings/js/JSEventListener.h: Made some functions public so DOMWindow could call them.
- bindings/js/JSNodeCustom.cpp: Moved markEventListeners to a header, so it could be shared.
- bindings/scripts/CodeGeneratorJS.pm: Generate event listener marking and invalidating code for the DOMWindow.
- dom/RegisteredEventListener.h: (WebCore::markEventListeners): (WebCore::invalidateEventListeners): Added helper functions.
- page/DOMWindow.idl: Make the window's event listener attributes not protected.
- 9:13 PM Changeset in webkit [42475] by
-
- 2 edits in trunk/WebCore
2009-04-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Mark Rowe.
OS X standalone media documents should not switch from <video> to <embed> when
QTKit load state is QTMovieLoadStateLoading as that happens frequently when a loading
with a slow network connection or when a movie is not saved fast-start.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): Don't open movie with plug-in when QTKit's loadstate is QTMovieLoadStateLoading, wait until it drops below QTMovieLoadStateError.
- 6:03 PM Changeset in webkit [42474] by
-
- 3 edits in trunk/WebCore
2009-04-13 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=24453
REGRESSION: If setTimeout is called on a iframe's window, the DOM changes to
the main document that timer callback makes are not flushed.
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): Use Document::updateStyleForAllDocuments() instead of document->updateStyleIfNeeded() since timers may affect documents other then their own.
- 5:21 PM Changeset in webkit [42473] by
-
- 2 edits in trunk/WebCore
2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by David Hyatt.
Check document for nullity to avoid crashing on GTK+, when
creating the WebView.
- page/FrameView.cpp: (WebCore::FrameView::needsLayout):
- 5:19 PM Changeset in webkit [42472] by
-
- 2 edits in trunk/WebCore
Forgot to capitalize the "US".
- platform/text/win/TextBreakIteratorInternalICUWin.cpp: (WebCore::currentTextBreakLocaleID):
- 5:10 PM Changeset in webkit [42471] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6564956> URL field double-click selects entire domain, rather than single word or entire URL
Revert back to the old word breaking behavior by using en_US_POSIX locale.
Reviewed by Steve Falkenburg.
- platform/text/win/TextBreakIteratorInternalICUWin.cpp: (WebCore::currentTextBreakLocaleID):
- 4:42 PM Changeset in webkit [42470] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Darin.
<rdar://problem/6784955> REGRESSION: closing a tab containing a PDF causes world leaks
Simplify the _trackFirstResponder method by just caching the value instead of retaining
a Cocoa object.
- WebView/WebPDFView.h: Eliminated trackedFirstResponder object and replaced it with a firstResponderIsPDFDocumentView boolean.
- WebView/WebPDFView.mm: (-[WebPDFView dealloc]): Removed no longer necessary ASSERT. (-[WebPDFView viewWillMoveToWindow:]): Removed call to release and nil-out trackedFirstResponder, which no longer exists. In the new code all we do now is set firstResponderIsPDFDocumentView to NO. (-[WebPDFView _trackFirstResponder]): Rewrote this method to just cache the value instead of retaining an object.
- 3:36 PM Changeset in webkit [42469] by
-
- 4 edits in trunk/WebKitTools
2009-04-13 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
- Scripts/check-for-exit-time-destructors: Add ERROR: and WARNING: prefixes to make these scripts work better with the build window in new versions of Xcode.
- Scripts/check-for-global-initializers: Ditto.
- Scripts/check-for-weak-vtables: Ditto.
- 3:18 PM Changeset in webkit [42468] by
-
- 3 edits in trunk/WebCore
2009-04-13 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
- platform/cf/BinaryPropertyList.cpp: Added comment.
- platform/cf/BinaryPropertyList.h: Fixed mistakes in comments.
- 3:16 PM Changeset in webkit [42467] by
-
- 8 edits2 adds in trunk
WebCore:
2009-04-13 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 25158: hit testing doesn't work right in some cases involving anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=25158
rdar://problem/6769693
Test: editing/selection/click-after-nested-block.html
- rendering/RenderBlock.cpp: (WebCore::isChildHitTestCandidate): Added. Helper so the two loops in positionForPoint can share code. (WebCore::RenderBlock::positionForPoint): Removed unneeded special case for first child box. Changed special case for last child box to propertly handle the various types of child box that are not hit test candidates (the same ones already handled by the hit test loop below), adding in a loop so we find the last candidate.
LayoutTests:
2009-04-13 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 25158: hit testing doesn't work right in some cases involving anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=25158
rdar://problem/6769693
- editing/selection/click-after-nested-block-expected.txt: Added.
- editing/selection/click-after-nested-block.html: Added.
- fast/events/pointer-events-expected.txt: Updated since this is now a plain-text test.
- fast/events/pointer-events.html: Changed this to a plain-text test, because the old results reflected a difference in hit testing behavior that this test was not intended to exercise and it's better to have the test be more cross-platform. Also removed unneeded use of waitUntilDone.
- fast/js/finally-codegen-failure.html: Replaced with standard wrapper created by running the make-js-test-wrappers script. If we want to include type and charset attributes in the script elements, we can change make-js-test-wrappers to do that for all tests at some point.
- fast/js/function-apply-aliased.html: Ditto.
- fast/js/function-call-aliased.html: Ditto.
- 2:44 PM Changeset in webkit [42466] by
-
- 4 edits in trunk
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Disabled another JavaScriptCore test because it fails on Windows but
not Mac, so it makes the bots red.
- tests/mozilla/expected.html:
WebKitTools:
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Disabled another JavaScriptCore test because it fails on Windows but
not Mac, so it makes the bots red.
- Scripts/run-javascriptcore-tests:
- 2:39 PM Changeset in webkit [42465] by
-
- 1 edit in trunk/LayoutTests/platform/mac/accessibility/frame-with-title-expected.txt
Update accessibility layout test from last checkin.
- 2:34 PM Changeset in webkit [42464] by
-
- 9 edits in trunk
Webcore:
2009-04-13 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Fix for https://bugs.webkit.org/show_bug.cgi?id=25125. Rework scrolling so that a layout happens first when
it's already needed so that the code doesn't end up making bad decisions based off invalid document sizes.
- WebCore.base.exp:
- page/FrameView.h: (WebCore::FrameView::visibleContentsResized):
- platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::updateScrollbars):
- platform/ScrollView.h:
WebKit/mac:
2009-04-13 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Fix for https://bugs.webkit.org/show_bug.cgi?id=25125. Rework scrolling so that a layout happens first when
it's already needed so that the code doesn't end up making bad decisions based off invalid document sizes.
This patch also eliminates WebHTMLView's separate notion of needing a layout and just consolidates it with
WebCore's notion of needing layout.
- WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
- WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): (-[WebHTMLView initWithFrame:]): (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebHTMLView setNeedsLayout:]): (-[WebHTMLView _layoutIfNeeded]): (-[WebHTMLView _needsLayout]):
- WebView/WebHTMLViewInternal.h:
- 2:31 PM Changeset in webkit [42463] by
-
- 7 edits in trunk
Windows part 2 of <rdar://5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing
WebCore:
Add SharedBuffer::wrapCFData
This is the CF-equivalent of wrapNSData.
Reviewed by Brady Eidson.
- platform/SharedBuffer.h:
- platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::wrapCFData):
WebKit/win:
Windows part 2 of <rdar://5438063> Saving history containing 100,000
entries causes pauses of 2s while browsing
Reviewed by Brady Eidson.
- Interfaces/IWebHistoryPrivate.idl: Added data, analagous to WebKit/mac's -[WebHistory _data] method.
- WebHistory.cpp: (WebHistory::saveHistoryGuts): Changed to call data() to get the data for saving. (WebHistory::data): Added. Returns the data for saving as an IStream. (WebHistory::data): Added. Returns the data for saving as a CFDataRef.
- WebHistory.h: Added data.
- 2:27 PM Changeset in webkit [42462] by
-
- 2 edits in trunk/LayoutTests
2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Holger Freyther.
Further massage tests to disable tests that are failingto make the
results more useful.
- platform/gtk/Skipped:
- 2:09 PM Changeset in webkit [42461] by
-
- 4 edits in trunk
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Disabled two JavaScriptCore tests because they fail on Window or Mac but
not both, so they make the bots red.
- tests/mozilla/expected.html: Updated expected results.
WebKitTools:
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Disabled two JavaScriptCore tests because they fail on Window or Mac but
not both, so they make the bots red.
- Scripts/run-javascriptcore-tests:
- 1:57 PM Changeset in webkit [42460] by
-
- 1 edit in trunk/WebCore/page/EventHandler.cpp
Adding a comment to my previous code change.
- 1:55 PM Changeset in webkit [42459] by
-
- 2 edits in trunk/WebKit/mac
2009-04-13 Darin Adler <Darin Adler>
- WebView/WebViewPrivate.h: Updated comments.
- 1:48 PM Changeset in webkit [42458] by
-
- 2 edits in trunk/WebCore
- build fix
- page/EventHandler.cpp: (WebCore::documentPointForWindowPoint):
- 1:46 PM Changeset in webkit [42457] by
-
- 14 edits in trunk
WebCore:
2009-04-13 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
<rdar://problem/6740294> Increase the connection count per host
Try to use six connections per host if possible.
- WebCore.base.exp:
- loader/loader.cpp: (WebCore::Loader::Loader):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/network/ResourceRequestBase.cpp: (WebCore::initMaximumHTTPConnectionCountPerHost):
- platform/network/ResourceRequestBase.h:
- platform/network/mac/ResourceRequestMac.mm: (WebCore::initMaximumHTTPConnectionCountPerHost):
WebKit/mac:
2009-04-13 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
<rdar://problem/6740294> Increase the connection count per host
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
WebKitLibraries:
2009-04-13 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
<rdar://problem/6740294> Increase the connection count per host
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 1:38 PM Changeset in webkit [42456] by
-
- 3 edits2 adds in trunk
WebCore:
2009-04-13 Justin Garcia <justin.garcia@apple.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=25153
Can't place the caret into text field that scrolls the window on focus
We refetch the target node in the shadow node case, and when we do so the window coordinate for the mouse event may
be invalid because of scrolling that the focus handler did. Cache the document point (that we derived from the window
coordinate) and use that any time we refetch.
- page/EventHandler.cpp: (WebCore::documentPointForWindowPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::prepareMouseEvent):
LayoutTests:
2009-04-13 Justin Garcia <justin.garcia@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/6748324> REGRESSION (Kirkwood): Can't type in Netflix search field
- fast/forms/25153-expected.txt: Added.
- fast/forms/25153.html: Added.
- 1:29 PM Changeset in webkit [42455] by
-
- 2 edits in trunk/LayoutTests
2009-04-13 Sam Weinig <sam@webkit.org>
Fix bad expected result.
- fast/frames/frame-unload-crash-expected.txt:
- 1:26 PM Changeset in webkit [42454] by
-
- 3 edits in trunk/WebCore
2009-04-13 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Rename JavaScriptCanOpenWindowsAutomatically to javaScriptCanOpenWindowsAutomatically
to conform to our style guidelines.
- page/DOMWindow.cpp: (WebCore::DOMWindow::allowPopUp):
- page/Settings.h: (WebCore::Settings::javaScriptCanOpenWindowsAutomatically):
- 1:24 PM Changeset in webkit [42453] by
-
- 2 edits in trunk/WebCore
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Mac build fix: Made another header private.
- WebCore.xcodeproj/project.pbxproj:
- 1:20 PM Changeset in webkit [42452] by
-
- 3 edits in trunk/WebCore
2009-04-13 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=25121
Upstream changes to handle error messages from V8 when running worker script.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::reportFatalErrorInV8): (WebCore::handleConsoleMessage): (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::initV8IfNeeded): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::evaluate):
- bindings/v8/WorkerContextExecutionProxy.h:
- 1:18 PM Changeset in webkit [42451] by
-
- 2 edits in trunk/WebKit/mac
2009-04-13 Brady Eidson <beidson@apple.com>
Reviewed by Tim Hatcher
Tweak my last check-in, moving the thread violation check up to the API-level calls so the logging is more
useful to developers/users.
- WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): If not on the main thread, only perform the "call on main thead" workaround, as the log/exception raising is now up at the API level. (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Perform a thread violation check here so logging is more meaningful. (-[WebFrame loadHTMLString:baseURL:]): Ditto. (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
- 1:16 PM Changeset in webkit [42450] by
-
- 3 edits in trunk/WebCore
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Build fix: Made setInlineEventListenerForType not inline, since Document
calls it now. Made RegisteredEventListener.h a private header on Mac,
so WebKit can use it.
- page/DOMWindow.cpp: (WebCore::DOMWindow::setInlineEventListenerForType):
- 1:14 PM Changeset in webkit [42449] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
- fix <rdar://problem/6404439> REGRESSION: Overlapping text and other layout issues in View Sample feature of MYOB FIrstEdge v3
- page/Navigator.cpp: (WebCore::shouldHideFourDot): Added "tdqm_loader.js" to the list of JavaScript files this quirk applies to.
- 1:03 PM Changeset in webkit [42448] by
-
- 2 edits in trunk/WebKit/mac
2009-04-13 Brady Eidson <beidson@apple.com>
Reviewed by Kevin Decker
<rdar://problem/6712063> Garmin WebUpdater crashes
- WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): If not called on the main thread, add a ThreadViolationCheckRoundTwo() call to either log or raise an exception. In the case where it's only a log, reschedule the _loadData call to occur on the main thread.
- 12:50 PM Changeset in webkit [42447] by
-
- 13 edits in trunk
WebCore:
2009-04-13 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Move open and showModalDialog functions out of JSDOMWindowBase
and into JSDOMWindow by partially generating them.
This slightly changes the behavior of getting window.showModalDialog
when the embedding app does not support it to return undefined regardless
of shadowing. This should not be an issue in a practice, but will be addressed
when we add a generic way to handle runtime specialization of property
access.
- DerivedSources.make: Remove JSDOMWindowBase.lut.h
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::): (WebCore::JSDOMWindowBase::getOwnPropertySlot): Move canShowModalDialog check from here to JSDOMWindow::customGetOwnPropertySlot. (WebCore::JSDOMWindowBase::put): Remove dead code.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
- bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
- page/DOMWindow.cpp: (WebCore::DOMWindow::parseModalDialogFeatures): Move from JSDOMWindowBase. (WebCore::DOMWindow::allowPopUp): Ditto. (WebCore::DOMWindow::canShowModalDialog): Ditto. (WebCore::DOMWindow::canShowModalDialogNow): Ditto.
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
2009-04-13 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Update tests after moving showModalDialog from JSDOMWindowBase to
JSDOMWindow and slightly changing the behavior when showModalDialog
is not available, as is the case for DumpRenderTree.
- fast/dom/Window/window-function-frame-getter-precedence-expected.txt:
- fast/dom/Window/window-properties-expected.txt:
- platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
- 12:43 PM Changeset in webkit [42446] by
-
- 13 edits in trunk/WebCore
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Moved storage for window event listeners into the window object.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener): Add / remove window event listeners to / from the window object.
- dom/Document.cpp: (WebCore::Document::removeAllEventListeners): (WebCore::Document::clear): (WebCore::Document::setWindowInlineEventListenerForTypeAndAttribute): Moved a bunch of code to the DOMWindow class, and left behind a few calls through to DOMWindow, to support legacy clients. (Eventually, these will go away, too.)
- dom/Document.h: ditto.
- dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): (WebCore::Node::dispatchWindowEvent): Dipatch window events on the window object, not the document.
- dom/Node.h:
- dom/RegisteredEventListener.h: Moved RegisteredEventListenerVector declaration, since it's required in more places now.
- history/CachedFrame.cpp: (WebCore::CachedFrame::clear): Updated for rename. Also, remove event listeners before detaching and clearing the document's window pointer, since the the document needs its window pointer in order to tell the window to clear its event listeners.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::logCanCacheFrameDecision): Updated for rename, and movement of window event listeners into the window.
- loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure): Updated for movement of window event listeners into the window.
- page/DOMWindow.cpp: (WebCore::DOMWindow::handleEvent): (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): (WebCore::DOMWindow::removeAllEventListeners): (WebCore::DOMWindow::hasEventListener): (WebCore::DOMWindow::setInlineEventListenerForType): (WebCore::DOMWindow::removeInlineEventListenerForType): (WebCore::DOMWindow::inlineEventListenerForType): (WebCore::DOMWindow::addPendingFrameUnloadEventCount): (WebCore::DOMWindow::removePendingFrameUnloadEventCount): (WebCore::DOMWindow::addPendingFrameBeforeUnloadEventCount): (WebCore::DOMWindow::removePendingFrameBeforeUnloadEventCount):
- page/DOMWindow.h: Moved a bunch of code to the DOMWindow class, from the Document.
- page/Frame.cpp: (WebCore::Frame::shouldClose): Updated for movement of window event listeners into the window.
- 12:05 PM Changeset in webkit [42445] by
-
- 4 edits in trunk/WebCore
2009-04-13 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Sam Weinig.
The Geolocation timer needs to start after the UA has granted permission.
- bindings/js/JSGeolocationCustom.cpp: Use PassRefPtr<PositionOptions> (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
- page/Geolocation.cpp: Add a RefPtr<PositionOptions> so it can be used later when the timer is started. Change PositionOptions* to PassRefPtr<PositionOptions> where needed. (WebCore::Geolocation::GeoNotifier::GeoNotifier): (WebCore::Geolocation::GeoNotifier::startTimer): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition): (WebCore::Geolocation::setIsAllowed): Start the timer is the UA allows (WebCore::Geolocation::startTimer): (WebCore::Geolocation::startTimersForOneShots): (WebCore::Geolocation::startTimersForWatchers): (WebCore::Geolocation::startTimers):
- page/Geolocation.h: (WebCore::Geolocation::GeoNotifier::create):
- 11:01 AM Changeset in webkit [42444] by
-
- 3 edits in trunk/WebCore
2009-04-13 Pamela Greene <pam@chromium.org>
Reviewed by Darin Fisher.
Fix Chromium (V8) build by renaming methods to match changes
in http://trac.webkit.org/changeset/42377.
- bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute): updateRendering() -> updateStyleIfNeeded()
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent): updateDocumentsRendering() -> updateStyleForAllDocuments()
- 10:52 AM Changeset in webkit [42443] by
-
- 2 edits in trunk/WebKitTools
2009-04-13 Darin Adler <Darin Adler>
- Scripts/make-js-test-wrappers: Added another exception.
- 10:47 AM Changeset in webkit [42442] by
-
- 3 edits5 adds in trunk
2009-04-13 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25136
CRASH in DocumentLoader::removeSubresourceLoader due to null m_frame
Test: fast/frames/frame-unload-crash.html
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::updateLoading): Added null check of m_frame.
- 10:38 AM Changeset in webkit [42441] by
-
- 6 edits in trunk
WebCore:
2009-04-13 Sam Weinig <sam@webkit.org>
Reviewed by Tim Hatcher.
Put the MessagePort constructor back in ENABLE_CHANNEL_MESSAGING.
- page/DOMWindow.idl:
LayoutTests:
2009-04-13 Sam Weinig <sam@webkit.org>
Reviewed by Tim Hatcher.
Update test results after putting the MessagePort constructor
back in ENABLE_CHANNEL_MESSAGING.
- fast/dom/Window/window-properties-expected.txt:
- fast/js/global-constructors-expected.txt:
- platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
- 10:24 AM Changeset in webkit [42440] by
-
- 2 edits in trunk/WebCore
2009-04-13 Greg Bolsinga <bolsinga@apple.com>
Fix GTK build break.
- platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::updatePosition):
- 10:14 AM Changeset in webkit [42439] by
-
- 2 edits in trunk/WebCore
2009-04-13 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler and Dan Bernstein.
Assertion in updateStyleForAllDocuments. Make sure to unscheduleStyleRecalc when an object goes into
the page cache. Disallow scheduling of style recalcs on a document that is already in the page cache.
Schedule a style recalc if needed when an object comes out of the page cache.
- dom/Document.cpp: (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::setInPageCache):
- 10:11 AM Changeset in webkit [42438] by
-
- 3 edits in trunk/WebCore
Correctly sort (program) scripts in the Scripts panel popup menu.
Reviewed by Ada Chan.
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): Refactor the code and sort "(program)" options by the sourceID to maintain some order.
- inspector/front-end/utilities.js: (indexOfObjectInListSortedByFunction): Fix a bug where identical objects would cause an incorrect return value that confuses insertionIndexForObjectInListSortedByFunction. Just set 'first' and break so the correct result will be returned.
- 10:07 AM Changeset in webkit [42437] by
-
- 10 edits1 add in trunk/WebCore
2009-04-13 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add custom code for Coordinates that returns null when required by the
Geolocation spec.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCoordinatesCustom.cpp: Added. (WebCore::JSCoordinates::altitude): returns null if the value cannot be provided. (WebCore::JSCoordinates::altitudeAccuracy): Ditto (WebCore::JSCoordinates::heading): Ditto (WebCore::JSCoordinates::speed): Ditto
- page/Coordinates.h: (WebCore::Coordinates::create): Add 'canProvide' parameters and values (WebCore::Coordinates::canProvideAltitude): (WebCore::Coordinates::canProvideAltitudeAccuracy): (WebCore::Coordinates::canProvideHeading): (WebCore::Coordinates::canProvideSpeed): (WebCore::Coordinates::Coordinates):
- page/Coordinates.idl: specify custom getters
- platform/mac/GeolocationServiceMac.mm: Set the values correctly if they cannot be provided. (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
- 9:27 AM Changeset in webkit [42436] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=22898
[GTK] need proper API for printing
Added simple printing unit tests.
- tests/testwebframe.c: (print_requested_cb): (print_timeout): (test_webkit_web_frame_printing): (main):
- 9:26 AM Changeset in webkit [42435] by
-
- 6 edits in trunk/WebKit/gtk
2009-04-13 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=22898
[GTK] need proper API for printing
Implement proper printing API, using the GTK+ printing API.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::print):
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp:
- webkit/webkitwebframe.h:
- webkit/webkitwebview.cpp:
- 9:15 AM Changeset in webkit [42434] by
-
- 2 edits in trunk/LayoutTests
2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Holger Freyther.
Reworked the skipped tests listing so that it is easier to find
tests that are skipped but pass using diff. Enable all tests that
are passing, and disable failing tests except for a few crashers
and known regressions. This is an effort to make the build slave
output more useful when it is back.
- platform/gtk/Skipped:
- 8:12 AM Changeset in webkit [42433] by
-
- 3 edits4 adds in trunk
WebCore:
2009-04-13 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/5510537> Typing return at start of block quote yields empty quoted line
Test: editing/inserting/5510537.html
- editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): If the break insertion position is at the beginning of the topmost quote, then just insert the <br> before the blockquote. Otherwise, if the break insertion position is at the beginning of any quote, adjust the position so the break comes before the current quote level so we don't end up with an empty line in that quote in addition to the new line we're adding with the <br>.
LayoutTests:
2009-04-13 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Test for <rdar://problem/5510537> Typing return at start of block quote yields empty quoted line
- editing/inserting/5510537.html: Added.
- platform/mac/editing/inserting/5510537-expected.checksum: Added.
- platform/mac/editing/inserting/5510537-expected.png: Added.
- platform/mac/editing/inserting/5510537-expected.txt: Added.
- 7:46 AM Changeset in webkit [42432] by
-
- 2 edits in trunk/WebCore
2009-04-11 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Fix problem when encoding history files with duplicate integer arrays near the end of the file.
This results in an assertion failure, and if assertions are turned off, corrupted output.
When writing an integer array it's important not to add an object reference to the
aggregate buffer. The writing of the array does not depend on the aggregate buffer. But,
more importantly, it's possible this instance integer array is a duplicate and won't be
written out. If so, there's no guarantee there's enough space in the aggregate buffer to
store the object references (the references will be ignored). In some cases the aggregate
buffer can then overrun the data being written; normally this is prevented by the fact that
the data being written will include a copy of the aggregate buffer.
Also removed a bit of unneeded dead code to handle the integer -1.
- platform/cf/BinaryPropertyList.cpp: (WebCore::BinaryPropertyListPlan::BinaryPropertyListPlan): Removed unneeded m_integerNegativeOneObjectReference, since property lists support only non-negative integers. (WebCore::BinaryPropertyListPlan::writeInteger): Removed support for m_integerNegativeOneObjectReference. (WebCore::BinaryPropertyListPlan::integerObjectReference): Ditto. (WebCore::BinaryPropertyListSerializer::writeIntegerWithoutAddingAggregateObjectReference): Added. Factored out most of writeInteger, for use in writeIntegerArray, without calling addAggregateObjectReference. (WebCore::BinaryPropertyListSerializer::writeInteger): Changed to call the new writeIntegerWithoutAddingAggregateObjectReference function. (WebCore::BinaryPropertyListSerializer::writeIntegerArray): Call the new writeIntegerWithoutAddingAggregateObjectReference function and therefore remove the code to save and restore m_currentAggregateBufferByte, which is no longer needed.
- 4:31 AM Changeset in webkit [42431] by
-
- 2 edits in trunk/WebCore
Unreviewed Qt build fix
Apr 12, 2009:
- 5:41 PM Changeset in webkit [42430] by
-
- 8 edits in trunk
WebCore:
2009-04-12 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Move the event and crypto attributes and the captureEvents and releaseEvents
functions out of JSDOMWindowBase by partially generating them.
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::currentEvent): Make const.
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::crypto): Not implemented. (WebCore::JSDOMWindow::event): (WebCore::JSDOMWindow::captureEvents): Not implemented. (WebCore::JSDOMWindow::releaseEvents): Ditto.
- page/DOMWindow.idl:
LayoutTests:
2009-04-12 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Update test result for new nop window.crypto behavior.
- http/tests/security/cross-frame-access-get-expected.txt:
- 4:42 PM Changeset in webkit [42429] by
-
- 4 edits in trunk/LayoutTests
2009-04-12 Sam Weinig <sam@webkit.org>
Update results.
- fast/dom/Window/window-properties-expected.txt:
- fast/js/global-constructors-expected.txt:
- platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
- 4:10 PM Changeset in webkit [42428] by
-
- 10 edits in trunk
WebCore:
2009-04-12 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Move more attributes out of JSDOMWindowBase by
partially generating them.
- Expose the MessagePort constructor.
- bindings/js/JSDOMGlobalObject.h: (WebCore::getDOMConstructor):
- bindings/js/JSDOMWindowBase.cpp: (setJSDOMWindowBaseEvent):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::image): (WebCore::JSDOMWindow::option): (WebCore::JSDOMWindow::audio): (WebCore::JSDOMWindow::webKitPoint): (WebCore::JSDOMWindow::webKitCSSMatrix): (WebCore::JSDOMWindow::xMLHttpRequest): (WebCore::JSDOMWindow::xSLTProcessor): (WebCore::JSDOMWindow::messageChannel): (WebCore::JSDOMWindow::worker):
- page/DOMWindow.idl:
LayoutTests:
2009-04-12 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Update tests after making MessageChannel completely missing when not
compiling with support for it (and removing it from the tests because
we never compile with support for it right now) and exposing the MessagePort
constructor.
- fast/dom/constructors-cached-expected.txt:
- fast/dom/dom-constructors-expected.txt:
- fast/dom/dom-constructors.html:
- fast/dom/resources/constructors-cached.js:
- platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
- 10:57 AM Changeset in webkit [42427] by
-
- 2 edits in trunk/WebCore
A resource's filename is not correct after a redirect in the Inspector.
Reviewed by Dan Bernstein.
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): Fix a typo in the lastPathComponent property name.
- 9:24 AM Changeset in webkit [42426] by
-
- 3 edits2 adds in trunk
WebCore:
2009-04-12 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Test: editing/inserting/6609479-1.html
Follow-up to <rdar://problem/6609479>.
Before my last change, a Mail blockquote would've been broken up earlier, and you would've been guaranteed that the inserted content
was at the start of a paragraph. Now we need to check for that explicitly, and only merge the start of the inserted content if it is
at the start of a paragraph.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart):
LayoutTests:
2009-04-12 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Another test for <rdar://problem/6609479>. This covers inserting HTML in a quoted table.
- editing/inserting/6609479-1-expected.txt: Added.
- editing/inserting/6609479-1.html: Added.
Apr 11, 2009:
- 10:49 PM Changeset in webkit [42425] by
-
- 8 edits2 adds in trunk
WebCore:
2009-04-11 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/6609479> Pressing return inside a table cell that's inside quoted content will split the table
Test: editing/inserting/6609479.html
Don't break a blockquote if pasting or inserting into a table.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
- editing/TypingCommand.cpp: (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
LayoutTests:
2009-04-11 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
Tests for <rdar://problem/6609479> Pressing return inside a table cell that's inside quoted content will split the table
- editing/inserting/5418891.html: Changed test so it doesn't involve tables.
- editing/inserting/6609479-expected.txt: Added.
- editing/inserting/6609479.html: Added.
- platform/mac/editing/inserting/5418891-expected.checksum:
- platform/mac/editing/inserting/5418891-expected.png:
- platform/mac/editing/inserting/5418891-expected.txt:
- 6:11 PM Changeset in webkit [42424] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/6643103> Unscaled values from body.scrollHeight
Test: fast/css/zoom-body-scroll.html
Adjust scroll{Left,Top,Width,Height} values for zoom in getters and
setters.
- html/HTMLBodyElement.cpp: (WebCore::adjustForZoom): (WebCore::HTMLBodyElement::scrollLeft): (WebCore::HTMLBodyElement::setScrollLeft): (WebCore::HTMLBodyElement::scrollTop): (WebCore::HTMLBodyElement::setScrollTop): (WebCore::HTMLBodyElement::scrollHeight): (WebCore::HTMLBodyElement::scrollWidth):
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/6643103> Unscaled values from body.scrollHeight
- fast/css/zoom-body-scroll-expected.txt: Added.
- fast/css/zoom-body-scroll.html: Added.
Apr 10, 2009:
- 10:40 PM Changeset in webkit [42423] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Jon Honeycutt.
- fix <rdar://problem/6752340> Light blue-green background in content area in Mail
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Use device white, rather than calibrated white, as the default background color.
- 10:31 PM Changeset in webkit [42422] by
-
- 8 edits in trunk/WebCore
Allow page navigation and reload while stopped at a breakpoint.
<rdar://problem/6781108> Having a breakpoint active prevents page reload
Reviewed by Darin Adler.
- inspector/InspectorController.cpp: (WebCore::InspectorController::didContinue): Call the resumedScript function.
- inspector/InspectorController.h: Added didContinue.
- inspector/JavaScriptDebugListener.h: Ditto.
- inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::pauseIfNeeded): Call didContinue on the listeners.
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.debuggerResumed): Update the interface and state.
- inspector/front-end/inspector.js: (WebInspector.resumedScript): Call ScriptsPanel.debuggerResumed.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Call resumeDebugger.
- 7:18 PM Changeset in webkit [42421] by
-
- 2 edits in trunk/LayoutTests
Land corrected results for complex-character-based-fallback.html
- platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
- 5:56 PM Changeset in webkit [42420] by
-
- 1 edit1 move in trunk/LayoutTests
2009-04-10 Darin Adler <Darin Adler>
Rubber stamped by Adam Roben.
Disabled fast/dom/gc-8.html, which was using Timer in an unsafe way that now
triggers an assertion.
We'll reenable the test after fixing the problem. But this is a test-only problem.
- fast/dom/gc-8.html: Removed.
- fast/dom/gc-8.html-disabled: Copied from fast/dom/gc-8.html.
- 5:47 PM Changeset in webkit [42419] by
-
- 2 edits in trunk/WebKit/win
<rdar://problem/6676024> REGRESSION (PB-40B1): Safari crashes on launch on tablet PC
r21436 changed the semantics of AXObjectCache::get() to not create
objects on demand. Changing this get() call into a getOrCreate() call
fixes the crash.
Rubber stamped by Jon Honeycutt.
- AccessibleDocument.cpp: (AccessibleDocument::AccessibleDocument):
- 5:43 PM Changeset in webkit [42418] by
-
- 2 edits in trunk/WebCore
2009-04-10 Sam Weinig <sam@webkit.org>
Reviewed by Adele Peterson.
Remove unused include for JSLock.
- page/mac/FrameMac.mm:
- 5:41 PM Changeset in webkit [42417] by
-
- 2 edits in trunk/WebCore
2009-04-10 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Add back the keepAlive timer for after the script execution to
protect the callers of evaluate, as was part of the original intent
of timer.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
- page/mac/FrameMac.mm:
- 5:39 PM Changeset in webkit [42416] by
-
- 7 edits3 adds in trunk/LayoutTests
Reviewed by Anders Carlsson.
- test and expected result updates following r42379
- fast/text/offsetForPosition-cluster-at-zero-expected.txt: Updated results.
- fast/text/offsetForPosition-cluster-at-zero.html: Removed font-dependent alert that was accidently left in this test.
- platform/mac-tiger/fast/text/international/thai-line-breaks-expected.checksum:
- platform/mac-tiger/fast/text/international/thai-line-breaks-expected.png:
- platform/mac-tiger/fast/text/international/thai-line-breaks-expected.txt:
- platform/mac-tiger/fast/text/monospace-width-cache-expected.checksum: Added.
- platform/mac-tiger/fast/text/monospace-width-cache-expected.png: Added.
- platform/mac-tiger/fast/text/monospace-width-cache-expected.txt: Added.
- platform/win/Skipped:
- 5:26 PM Changeset in webkit [42415] by
-
- 2 edits in trunk/WebCore
If we reload, the animation controller sticks around and has
a stale animation time. So the needed delay is computed wrong.
I added a reset of the animation timer on load.
I did not do a test case because this only happens on reload so I
couldn't make an automated test. I tried using an iframe and using
reload() but that doesn't tickle the bug.
- 5:13 PM Changeset in webkit [42414] by
-
- 2 edits in trunk/WebKitTools
Add our new test font to the list that DRT knows about
Reviewed by Dan Bernstein.
- DumpRenderTree/win/DumpRenderTree.cpp: (initialize): Added WebKit Layout Tests 2.ttf.
- 5:10 PM Changeset in webkit [42413] by
-
- 4 edits in trunk/WebCore
2009-04-10 Grace Kloba <klobag@gmail.com>
Reviewed by Darin Adler.
Move WORKERS header files inside ENABLE(WORKERS).
So if WORKERS is not enabled and the generated files are not generated, the build is still working.
- bindings/js/JSDOMGlobalObject.cpp:
- bindings/js/JSMessageChannelConstructor.cpp:
- bindings/js/ScheduledAction.cpp:
- 4:59 PM Changeset in webkit [42412] by
-
- 7 edits in trunk
WebCore:
2009-04-10 Darin Adler <Darin Adler>
Reviewed by Brady Eidson.
<rdar://problem/6773515> crash in push_heap inside WebCore when printing
The crash was due to manipulating a timer on a different thread than the one it was created on.
This adds some diagnostics so we'll catch that kind of mistake immediately.
- platform/Timer.cpp: (WebCore::TimerBase::TimerBase): Store the thread identifier in debug versions. (WebCore::TimerBase::start): Assert it's the same thread the timer was created on. (WebCore::TimerBase::stop): Ditto. (WebCore::TimerBase::isActive): Ditto. (WebCore::TimerBase::setNextFireTime): Ditto.
- platform/Timer.h: Added the thread identifier data member.
WebKit/mac:
2009-04-10 Darin Adler <Darin Adler>
Reviewed by Brady Eidson.
<rdar://problem/6773515> crash in push_heap inside WebCore when printing
The crash was due to manipulating a timer on a different thread than the one it was created on.
- History/WebHistoryItem.mm: (-[WebWindowWatcher windowWillClose:]): Call later on main thread, if called on non-main thread.
- WebView/WebHTMLView.mm: (-[WebHTMLView windowDidBecomeKey:]): Ditto. (-[WebHTMLView windowDidResignKey:]): Ditto. (-[WebHTMLView windowWillClose:]): Ditto. (-[WebHTMLView _updateControlTints]): Added. Factored out the non-thread-safe part of our override of _windowChangedKeyState. (-[WebHTMLView _windowChangedKeyState]): Call _updateControlTints later on main thread, if called on non-main thread.
- WebView/WebPreferences.mm: (-[WebPreferences _postPreferencesChangesNotification]): Call later on main thread, if called on non-main thread
- 4:39 PM Changeset in webkit [42411] by
-
- 2 edits in trunk/WebKit/win
Add our invidual IDL files back to Interfaces.vcproj, but disable them
This allows the IDL files to be found in Solution Explorer.
Rubber-stamped in advance by Steve Falkenburg.
- WebKit.vcproj/Interfaces.vcproj:
- 4:19 PM Changeset in webkit [42410] by
-
- 5 edits2 adds in trunk
2009-04-10 Chris Marrin <cmarrin@apple.com>
Reviewed by Dan Bernstein
If you remove a class with a transition while that transition is running
the animation timer will continue to fire after the transition is finished.
This has no visual indication, but it does drain the processor. And in some
cases it might even cause a glitch in future animations. Unfortunately there
is no way to test this without putting in printfs.
This happens because the animation logic is never traversed after a transition
is removed, so we never get a chance to cleanup. So I added cleanup in the logic
that fires the dispatch of the last style change when the animation finishes.
Test: transitions/remove-transition-style.html
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::animate): (WebCore::CompositeAnimation::cleanupFinishedAnimations):
- page/animation/CompositeAnimation.h:
- 3:52 PM Changeset in webkit [42409] by
-
- 2 edits in trunk/WebCore
2009-04-10 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Fix for <rdar://problem/6648858>
CrashTracer: [REGRESSION(Safari 4)] 60 crashes in Safari at com.apple.WebCore • WebCore::ScriptController::evaluate + 241
The Frame (and therefore ScriptController) were being destroyed
during JavaScript execution causing the JSDOMWindowShell to become
null.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): Use a RefPtr to protect the Frame instead of the keep-alive timer, since a nested event loop used from with-in JavaScript execution could cause the timer to fire before returning.
- 3:30 PM ApplicationsGtk edited by
- Correct claws-mail webkit plugin URL (diff)
- 3:27 PM Changeset in webkit [42408] by
-
- 7 edits in trunk/WebCore
2009-04-10 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=25133
Fix an error in InspectorController's bindings, clean up a few header
includes, make empty object construction in ScriptObject less ambiguous.
- bindings/js/JSInspectorControllerCustom.cpp: (WebCore::JSInspectorController::setSetting): Send correct argument from
the bindings.
- bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::createNew): Added.
- bindings/js/ScriptObject.h: Removed constructor, added decl for createNew.
- inspector/ConsoleMessage.cpp: Remove unused header.
- inspector/ConsoleMessage.h: Ditto.
- inspector/InspectorResource.cpp: (WebCore::createHeadersObject): Changed to use ScriptObject::createNew.
- 2:50 PM Changeset in webkit [42407] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Adam Roben.
- re-enable css2.1 tests that were disabled following r42379 and make them use a different fallback font for certain characters, to get the vertical metrics to match Mac
- platform/win/Skipped:
- platform/win/css2.1/resources/Mac-compatible-font-fallback.css:
- 2:44 PM Changeset in webkit [42406] by
-
- 3 edits in trunk/WebCore
This both fixes a bug where I was not sending in the right time
to continue the animation and was not recomputing current time
when coming out of suspend.
- 1:48 PM Changeset in webkit [42405] by
-
- 3 edits in trunk/WebKitLibraries
2009-04-10 Eric Carlson <eric.carlson@apple.com>
WebKitSystemInterface changes for <rdar://problem/6646998>
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 1:41 PM Changeset in webkit [42404] by
-
- 1 edit in trunk/WebCore/bindings/js/ScriptCachedFrameData.cpp
Revert an unintentional logic change in r42400.
- 1:17 PM Changeset in webkit [42403] by
-
- 3 edits in trunk/WebKitLibraries
2009-04-10 Simon Fraser <Simon Fraser>
Fix the leopard build by updating WebKitSystemInterface.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- 1:07 PM Changeset in webkit [42402] by
-
- 3 edits1 delete in trunk/WebKit
Remove DOMDocumentPrivate.h now that <rdar://problem/6730996> is fixed.
WebKit:
2009-04-10 Timothy Hatcher <timothy@apple.com>
Remove DOMDocumentPrivate.h now that <rdar://problem/6730996> is fixed.
Rubber-stamped by Mark Rowe.
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2009-04-10 Timothy Hatcher <timothy@apple.com>
Remove DOMDocumentPrivate.h now that <rdar://problem/6730996> is fixed.
Rubber-stamped by Mark Rowe.
- Misc/DOMDocumentPrivate.h: Removed.
- 1:05 PM Changeset in webkit [42401] by
-
- 2 edits in trunk/WebCore
Give Windows's <select> popup menus drop shadows
Rubber-stamped by Steve Falkenburg.
No test possible.
- platform/win/PopupMenuWin.cpp: (WebCore::registerPopup): Use the CS_DROPSHADOW window class style.
- 1:00 PM Changeset in webkit [42400] by
-
- 4 edits in trunk/WebCore
Fix a bug in the Web Inspector where it would show scripts
from previous pages when toggling the debugger off and back on.
https://bugs.webkit.org/show_bug.cgi?id=25095
rdar://problem/6769970
Reviewed by John Sullivan.
- bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): Null out the debugger for the scriptController. This balances the attachDebugger that was already in ScriptCachedFrameData::restore. (WebCore::ScriptCachedFrameData::restore): Clean up an if statement.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell): Clear the debugger from the current window before setting the new window.
- inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctions): Only accumulate source providers for code associated this as the debugger.
- 12:17 PM Changeset in webkit [42399] by
-
- 7 edits in trunk
2009-04-10 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/6646998> Avoid starting QTKitServer if possible
When possible avoid asking QTKit for the MIME types that require QTKitServer
when running 64-bit.
- WebCore.base.exp: Added new entry point.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::addFileTypesToCache): Add an NSArray of types to the cache. (WebCore::mimeCommonTypesCache): Add all "common" QTKit types to the cache. (WebCore::mimeModernTypesCache): Add only "modern" QTKit types to the cache (this list does not start QTKitServer if it is not already running). (WebCore::MediaPlayerPrivate::getSupportedTypes): Refactored. (WebCore::MediaPlayerPrivate::supportsType): Look in list of "modern" types first to avoid starting QTKitServer if possible.
- platform/mac/WebCoreSystemInterface.h: Add wkQTIncludeOnlyModernMediaFileTypes.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
2009-04-10 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/6646998> Avoid starting QTKitServer if possible
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Init QTIncludeOnlyModernMediaFileTypes.
- 11:55 AM Changeset in webkit [42398] by
-
- 2 edits in trunk/WebCore
Turn on window animations for <select> popup menus
We turned these off back when <select> popup menus were partially
transparent. Now that they're opaque, there's no reason not to
animate them.
Reviewed by Steve Falkenburg.
No test possible.
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Remove the #ifdef that was disabling the window animation.
- 11:39 AM Changeset in webkit [42397] by
-
- 2 edits in trunk/LayoutTests
- skip failures following r42379 until they are addressed by code changes or test changes
- platform/win/Skipped:
- 11:32 AM Changeset in webkit [42396] by
-
- 6 edits in trunk
WebCore:
Reviewed by Sam Weinig.
- fix a regression from r42379 which made zero-width characters affect line height
Test: fixes fast/text/wide-zero-width-space.html
- platform/graphics/mac/FontMacATSUI.mm: (WebCore::overrideLayoutOperation): Add to the fallback font list set here, and only if the glyph is not zero-width... (WebCore::ATSULayoutParameters::initialize): ...instead of doing it here. This matches WidthIterator's behavior.
LayoutTests:
Reviewed by Sam Weinig.
- revert broken test results that were checked in with r42379, now that the regression is fixed
- platform/mac/fast/text/wide-zero-width-space-expected.checksum:
- platform/mac/fast/text/wide-zero-width-space-expected.png:
- platform/mac/fast/text/wide-zero-width-space-expected.txt:
- 11:31 AM Changeset in webkit [42395] by
-
- 4 edits in trunk/LayoutTests
Update Windows results for complex-character-based-fallback.html
Rubber-stamped by Dan Bernstein.
- platform/win/fast/text/international/complex-character-based-fallback-expected.checksum:
- platform/win/fast/text/international/complex-character-based-fallback-expected.png:
- platform/win/fast/text/international/complex-character-based-fallback-expected.txt: Updated.
- 10:39 AM Changeset in webkit [42394] by
-
- 2 edits in trunk/WebCore
2009-04-10 Darin Fisher <darin@chromium.org>
Fixing build bustage caused by warnings being treated as errors.
1- A local variable was only be used inside a debug assertion, which
caused grief for the release build.
2- Missing initializer for member 'DocumentMarker::activeMatch'
- dom/Document.cpp: (WebCore::Document::addMarker): (WebCore::Document::setMarkersActive):
- 10:24 AM Changeset in webkit [42393] by
-
- 9 edits in trunk/WebCore
2009-04-10 Finnur Thorarinsson <finnur.webkit@gmail.com>
Reviewed by John Sullivan.
Fixing: https://bugs.webkit.org/show_bug.cgi?id=25117
(TextMatches don't have a concept of active match)
For the ports that use the DocumentMarker as highlighting for FindInPage it is
useful to have a flag that specifies which marker is active, so it can be drawn
in a different color.
This allows me to remove the hack to use the SelectionController to highlight
the active match (in the ChromiumWin port).
- dom/Document.cpp: (WebCore::Document::setMarkersActive):
- dom/Document.h:
- dom/DocumentMarker.h:
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintTextMatchMarker):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::platformActiveTextSearchHighlightColor): (WebCore::RenderTheme::platformInactiveTextSearchHighlightColor):
- rendering/RenderTheme.h:
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveTextSearchHighlightColor): (WebCore::RenderThemeChromiumWin::platformInactiveTextSearchHighlightColor):
- rendering/RenderThemeChromiumWin.h:
- 10:13 AM Changeset in webkit [42392] by
-
- 2 edits in trunk/WebCore
2009-04-10 Pamela Greene <pam@chromium.org>
Reviewed by Dimitri Glazkov.
Build fix for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=12440
- page/chromium/FrameChromium.cpp: (WebCore::computePageRectsForFrame): change docWidth() to overflowWidth()
- 5:03 AM Changeset in webkit [42391] by
-
- 13 edits in trunk/WebKit/gtk
WebKit/gtk/
2009-04-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25124
[GTK] many strings still missing translation calls
Mark the missing strings for translation.
- webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_cancel):
- webkit/webkitsoupauthdialog.c: (show_auth_dialog):
- webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_class_init):
- webkit/webkitwebinspector.cpp: (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
- webkit/webkitwebnavigationaction.cpp: (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init):
- webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
- webkit/webkitwebview.cpp:
WebKit/gtk/po/
2009-04-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25124
[GTK] many strings still missing translation calls
Extracting translation for the files that got translation calls.
- POTFILES:
- de.po:
- pt_BR.po:
- webkit.pot:
Apr 9, 2009:
- 10:42 PM Changeset in webkit [42390] by
-
- 1 edit2 deletes in trunk/LayoutTests
- remove two files I just checked in by accident
- platform/mac/fast/events/pointer-events-expected.txt: Removed.
- platform/mac/fast/events/pointer-events.html: Removed.
- 10:36 PM Changeset in webkit [42389] by
-
- 7 edits9 copies17 adds in trunk/LayoutTests
Reviewed by Mark Rowe.
- moved some Leopard-and-earlier results into platform/mac-leopard and added new results under platform/mac
- platform/mac-leopard/fast/text/complex-text-opacity-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.checksum.
- platform/mac-leopard/fast/text/complex-text-opacity-expected.png: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.png.
- platform/mac-leopard/fast/text/complex-text-opacity-expected.txt: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.txt.
- platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum.
- platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.png.
- platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.txt.
- platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum.
- platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png.
- platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt.
- platform/mac/fast/events/pointer-events-expected.txt: Added.
- platform/mac/fast/events/pointer-events.html: Added.
- platform/mac/fast/text/atsui-multiple-renderers-expected.checksum:
- platform/mac/fast/text/atsui-multiple-renderers-expected.png:
- platform/mac/fast/text/atsui-multiple-renderers-expected.txt:
- platform/mac/fast/text/complex-text-opacity-expected.checksum: Replaced.
- platform/mac/fast/text/complex-text-opacity-expected.png: Replaced.
- platform/mac/fast/text/complex-text-opacity-expected.txt: Replaced.
- platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum: Replaced.
- platform/mac/fast/text/international/bidi-AN-after-L-expected.png: Replaced.
- platform/mac/fast/text/international/bidi-AN-after-L-expected.txt: Replaced.
- platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Added.
- platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
- platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
- platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum: Added.
- platform/mac/fast/text/international/bidi-CS-after-AN-expected.png: Added.
- platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
- platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum: Replaced.
- platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Replaced.
- platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Replaced.
- platform/mac/fast/text/international/bidi-neutral-run-expected.checksum: Added.
- platform/mac/fast/text/international/bidi-neutral-run-expected.png: Added.
- platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
- 8:58 PM Changeset in webkit [42388] by
-
- 2 edits in trunk/WebKitTools
2009-04-09 Jan Michael Alonzo <jmalonzo@webkit.org>
Unreviewed Gtk build fix for undefined reference: g_thread_init.
Add GLIB_LIBS to DRT and GtkLauncher build config.
- GNUmakefile.am:
- 8:38 PM Changeset in webkit [42387] by
-
- 2 edits in trunk/LayoutTests
Remove two tests from the skipped list now that <rdar://problem/6718460> has been addressed.
- platform/mac-snowleopard/Skipped:
- 8:38 PM Changeset in webkit [42386] by
-
- 2 edits in trunk/LayoutTests
Skip a few tests that are currently failing.
Rubber-stamped by Oliver Hunt.
- platform/mac-snowleopard/Skipped:
- 8:23 PM Changeset in webkit [42385] by
-
- 4 edits in trunk/LayoutTests
Rubber-stamped by Mark Rowe.
- update Tiger-only test results after r42379
- platform/mac-tiger/fast/lists/w3-list-styles-expected.txt:
- platform/mac-tiger/fast/text/cg-fallback-bolding-expected.txt:
- platform/mac-tiger/fast/text/international/thai-line-breaks-expected.txt:
- 8:15 PM Changeset in webkit [42384] by
-
- 5 edits in trunk/WebCore
2009-04-09 David Hyatt <hyatt@apple.com>
Reviewed by Oliver Hunt
Add a timer for style recalc (similar to the one used for scheduling layouts). For now in order
to reduce the risk of regressions, I have left in all the synchronous machinery for updating style
following DOM events and JavaScript timeouts. Eventually these calls will be removed.
Where the timer will really kick in and be useful is for clients that do style changes from
Objective-C DOM bindings or that execute JavaScript to manipulate style from the JavaScriptCore C API.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::appendChild):
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::unscheduleStyleRecalc): (WebCore::Document::styleRecalcTimerFired): (WebCore::Document::updateStyleForAllDocuments): (WebCore::Document::detach):
- dom/Document.h:
- dom/Node.cpp: (WebCore::Node::setNeedsStyleRecalc): (WebCore::Node::lazyAttach):
- 7:24 PM Changeset in webkit [42383] by
-
- 1 edit3 copies1 add in trunk/LayoutTests
Land Windows-specific results for three forms tests since the Windows results match the Leopard results.
Rubber-stamped by Adam Roben.
- platform/win/fast/forms/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/file-input-disabled-expected.txt.
- platform/win/fast/forms/input-text-maxlength-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt.
- platform/win/fast/forms/input-text-paste-maxlength-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt.
- 6:49 PM Changeset in webkit [42382] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6586787> JS debugger does not work in 64-bit
Reviewed by Gavin Barraclough
Don't truncate the source id in JSCallFrame
- 6:17 PM Changeset in webkit [42381] by
-
- 6 edits in trunk
Windows part 1 of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing
WebCore:
Start compiling HistoryPropertyList on Windows
Reviewed by Darin Adler.
- WebCore.vcproj/WebCore.vcproj: Added HistoryPropertyList and its dependencies to the project. Copy headers from history/cf to $WebKitOutputDir.
- history/cf/HistoryPropertyList.cpp: Added StringExtras.h so that this file will compile on Windows.
WebKit/win:
Windows part 1 of <rdar://problem/5438063> Saving history containing
100,000 entries causes pauses of 2s while browsing
Use HistoryPropertyListWriter to implement IWebHistory::saveToURL.
Reviewed by Darin Adler.
- WebHistory.cpp: (WebHistoryWriter::WebHistoryWriter): Added. (WebHistoryWriter::writeHistoryItems): Added. Loop backwards through the entries for each date, and pass the corresponding WebCore::HistoryItem to writeHistoryItem. (WebHistory::saveHistoryGuts): Use WebHistoryWriter to serialize m_entriesByDate, then write the serialized data to disk using CFWriteStream.
- WebHistory.h: Removed datesArray.
- 6:13 PM Changeset in webkit [42380] by
-
- 5 edits4 copies8 moves1 add in trunk/LayoutTests
Update test results to account for a slight change in +[NSColor disabledControlTextColor].
Rubber-stamped by Dan Bernstein.
- platform/mac-leopard/fast/forms/disabled-select-change-index-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.checksum.
- platform/mac-leopard/fast/forms/disabled-select-change-index-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.png.
- platform/mac-leopard/fast/forms/disabled-select-change-index-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.txt.
- platform/mac-leopard/fast/forms/file-input-disabled-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.checksum.
- platform/mac-leopard/fast/forms/file-input-disabled-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.png.
- platform/mac-leopard/fast/forms/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.txt.
- platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/input-text-maxlength-expected.checksum.
- platform/mac-leopard/fast/forms/input-text-maxlength-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/input-text-maxlength-expected.png.
- platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-maxlength-expected.txt.
- platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/input-text-paste-maxlength-expected.checksum.
- platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/input-text-paste-maxlength-expected.png.
- platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-paste-maxlength-expected.txt.
- platform/mac/fast/forms/disabled-select-change-index-expected.txt:
- platform/mac/fast/forms/file-input-disabled-expected.txt:
- platform/mac/fast/forms/input-text-maxlength-expected.txt:
- platform/mac/fast/forms/input-text-paste-maxlength-expected.txt:
- 6:00 PM Changeset in webkit [42379] by
-
- 260 edits in trunk
WebCore:
2009-04-09 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- fix <rdar://problem/6166612> Text boxes' metrics should be based on the actual fonts used in them, not just the primary font
Covered by many existing layout tests
- platform/graphics/Font.cpp: (WebCore::Font::floatWidth): Added a fallbackFonts parameter. If the platform supports collecting fallback fonts in its complex font path and fallbackFonts is not null, all fallback fonts used for the text run will be added to it.
- platform/graphics/Font.h: (WebCore::Font::width): Ditto.
- platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter): Removed an unnecessary namespace qualifier. (WebCore::Font::floatWidthForSimpleText): Added a fallbackFonts parameter, which is passed down to WidthIterator.
- platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::WidthIterator): Added a fallbackFonts parameter and used it to initialize the m_fallbackFonts member. (WebCore::WidthIterator::advance): Track the fonts being used and add any fallback fonts to the m_fallbackFonts set. Make sure to only add non-small-caps fonts.
- platform/graphics/WidthIterator.h:
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::canReturnFallbackFontsForComplexText): Added an implementation that returns false, meaning this platform's implementation of floatWidthForComplexText() does not populate the fallbackFonts set. (WebCore::Font::floatWidthForComplexText): Updated for the new prototype.
- platform/graphics/chromium/FontLinux.cpp: Ditto.
- platform/graphics/gtk/FontGtk.cpp: Ditto.
- platform/graphics/mac/CoreTextController.cpp: (WebCore::CoreTextController::CoreTextController): Added a fallbackFonts parameter and used it to initialize the m_fallbackFonts member. (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Add fallback fonts to m_fallbackFonts.
- platform/graphics/mac/CoreTextController.h:
- platform/graphics/mac/FontMac.mm: (WebCore::Font::canReturnFallbackFontsForComplexText): Added an implementation that returns true, indicating that the Mac implementations of floatWidthForComplexText() populate the fallbackFonts set.
- platform/graphics/mac/FontMacATSUI.mm: (WebCore::ATSULayoutParameters::ATSULayoutParameters): Added a fallbackFonts parameter and used it to initialize the m_fallbackFonts member. (WebCore::ATSULayoutParameters::initialize): Add fallback fonts to m_fallbackFonts. (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts parameter, which is passed down to ATSULayoutParameters.
- platform/graphics/mac/FontMacCoreText.cpp: (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts parameter, which is passed down to CoreTextController.
- platform/graphics/win/FontWin.cpp: (WebCore::Font::canReturnFallbackFontsForComplexText): Added an implementation that returns true, indicating that the UniscribeController-based implementations of floatWidthForComplexText() populate the fallbackFonts set. (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts parameter, which is passed down to UniscribeController.
- platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::UniscribeController): Added a fallbackfonts parameter and used it to initialize m_fallbackFonts. (WebCore::UniscribeController::advance): Add fallback fonts to m_fallbackFonts.
- platform/graphics/win/UniscribeController.h:
- platform/graphics/wx/FontWx.cpp: (WebCore::Font::canReturnFallbackFontsForComplexText): Added an implementation that returns false, meaning this platform's implementation of floatWidthForComplexText() does not populate the fallbackFonts set. (WebCore::Font::floatWidthForComplexText): Updated for the new prototype.
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::computeLogicalBoxHeights): For an InlineTextBox with multiple fonts, compute a common baseline and line height by considering all fonts' ascents and descents (and line spacing, if applicable).
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::setFallbackFonts): Added. Temporarily stores the set of fallback fonts in a vector. (WebCore::InlineTextBox::takeFallbackFonts): Added. Returns the fallback fonts previously stored and removes them from storage.
- rendering/InlineTextBox.h:
- rendering/RenderText.cpp: (WebCore::RenderText::RenderText): Initialized the m_knownNotToUseFallbackFonts to false. (WebCore::RenderText::styleDidChange): Reset m_knownNotToUseFallbackFonts to false if the style difference is such that affects layout. (WebCore::RenderText::widthFromCache): Added a fallbackFonts parameter, which is passed down to Font::width(). (WebCore::RenderText::trimmedPrefWidths): Updated for the change to widthFromCache(). (WebCore::RenderText::calcPrefWidths): Made this call a private version of calcPrefWidths() that takes a fallbackFonts parameter and set the m_knownNotToUseFallbackFonts to true if the set comes back empty. The private version passes the fallbackFonts set to widthFromCache(). (WebCore::RenderText::setText): Reset m_knownNotToUseFallbackFonts to false. (WebCore::RenderText::createFallbackFontMetricsBox): Added. (WebCore::RenderText::width): Added a fallbackFonts parameter, which is passed down to calcPrefWidths(), widthFromCache() and Font::width(). Set m_knownNotToUseFallbackFonts to true when appropriate.
- rendering/RenderText.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::constructLine): Added an assertion and a continue statement to remove one level of indentation. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Temporarily store the set of fallback fonts in the InlineTextBox. (WebCore::RenderBlock::computeVerticalPositionsForLine): Added an assertion.
LayoutTests:
2009-04-09 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- updated results for <rdar://problem/6166612> Text boxes' metrics should be based on the actual fonts used in them, not just the primary font
- editing/selection/extend-selection-bidi-expected.txt:
- fast/text/offsetForPosition-cluster-at-zero-expected.txt:
- platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.checksum:
- platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.png:
- platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.txt:
- platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
- platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.png:
- platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt:
- platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.checksum:
- platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.png:
- platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt:
- platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum:
- platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.png:
- platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
- platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
- platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
- platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
- platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum:
- platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
- platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
- platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
- platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
- platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
- platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum:
- platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
- platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
- platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum:
- platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
- platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
- platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum:
- platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
- platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
- platform/mac/css2.1/t0905-c414-flt-02-c-expected.checksum:
- platform/mac/css2.1/t0905-c414-flt-02-c-expected.png:
- platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
- platform/mac/css2.1/t0905-c414-flt-03-c-expected.checksum:
- platform/mac/css2.1/t0905-c414-flt-03-c-expected.png:
- platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
- platform/mac/css2.1/t0905-c414-flt-04-c-expected.checksum:
- platform/mac/css2.1/t0905-c414-flt-04-c-expected.png:
- platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
- platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum:
- platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png:
- platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt:
- platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum:
- platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.png:
- platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.txt:
- platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
- platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
- platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
- platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
- platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
- platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
- platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.checksum:
- platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
- platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
- platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum:
- platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
- platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
- platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.checksum:
- platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.png:
- platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
- platform/mac/css2.1/t090501-c414-flt-01-b-expected.checksum:
- platform/mac/css2.1/t090501-c414-flt-01-b-expected.png:
- platform/mac/css2.1/t090501-c414-flt-01-b-expected.txt:
- platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
- platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
- platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
- platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
- platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt:
- platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
- platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt:
- platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
- platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
- platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt:
- platform/mac/css2.1/t1202-counter-03-b-expected.checksum:
- platform/mac/css2.1/t1202-counter-03-b-expected.png:
- platform/mac/css2.1/t1202-counter-03-b-expected.txt:
- platform/mac/css2.1/t1202-counter-04-b-expected.checksum:
- platform/mac/css2.1/t1202-counter-04-b-expected.png:
- platform/mac/css2.1/t1202-counter-04-b-expected.txt:
- platform/mac/css2.1/t1202-counter-09-b-expected.checksum:
- platform/mac/css2.1/t1202-counter-09-b-expected.png:
- platform/mac/css2.1/t1202-counter-09-b-expected.txt:
- platform/mac/css2.1/t1202-counters-03-b-expected.checksum:
- platform/mac/css2.1/t1202-counters-03-b-expected.png:
- platform/mac/css2.1/t1202-counters-03-b-expected.txt:
- platform/mac/css2.1/t1202-counters-04-b-expected.checksum:
- platform/mac/css2.1/t1202-counters-04-b-expected.png:
- platform/mac/css2.1/t1202-counters-04-b-expected.txt:
- platform/mac/css2.1/t1202-counters-09-b-expected.checksum:
- platform/mac/css2.1/t1202-counters-09-b-expected.png:
- platform/mac/css2.1/t1202-counters-09-b-expected.txt:
- platform/mac/editing/deleting/5144139-2-expected.checksum:
- platform/mac/editing/deleting/5144139-2-expected.png:
- platform/mac/editing/deleting/5144139-2-expected.txt:
- platform/mac/editing/input/devanagari-ligature-expected.checksum:
- platform/mac/editing/input/devanagari-ligature-expected.png:
- platform/mac/editing/input/devanagari-ligature-expected.txt:
- platform/mac/editing/pasteboard/copy-paste-bidi-expected.checksum:
- platform/mac/editing/pasteboard/copy-paste-bidi-expected.png:
- platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt:
- platform/mac/editing/selection/caret-rtl-2-expected.checksum:
- platform/mac/editing/selection/caret-rtl-2-expected.png:
- platform/mac/editing/selection/caret-rtl-2-expected.txt:
- platform/mac/editing/selection/caret-rtl-expected.checksum:
- platform/mac/editing/selection/caret-rtl-expected.png:
- platform/mac/editing/selection/caret-rtl-expected.txt:
- platform/mac/editing/selection/extend-selection-bidi-expected.checksum:
- platform/mac/editing/selection/extend-selection-bidi-expected.png:
- platform/mac/fast/css/beforeSelectorOnCodeElement-expected.checksum:
- platform/mac/fast/css/beforeSelectorOnCodeElement-expected.png:
- platform/mac/fast/css/beforeSelectorOnCodeElement-expected.txt:
- platform/mac/fast/css/rtl-ordering-expected.checksum:
- platform/mac/fast/css/rtl-ordering-expected.png:
- platform/mac/fast/css/rtl-ordering-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
- platform/mac/fast/css/text-overflow-ellipsis-expected.png:
- platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
- platform/mac/fast/css/text-security-expected.checksum:
- platform/mac/fast/css/text-security-expected.png:
- platform/mac/fast/css/text-security-expected.txt:
- platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum:
- platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
- platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
- platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
- platform/mac/fast/encoding/invalid-UTF-8-expected.png:
- platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
- platform/mac/fast/events/updateLayoutForHitTest-expected.checksum:
- platform/mac/fast/events/updateLayoutForHitTest-expected.png:
- platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
- platform/mac/fast/forms/select-visual-hebrew-expected.checksum:
- platform/mac/fast/forms/select-visual-hebrew-expected.png:
- platform/mac/fast/forms/select-visual-hebrew-expected.txt:
- platform/mac/fast/forms/select-writing-direction-natural-expected.checksum:
- platform/mac/fast/forms/select-writing-direction-natural-expected.png:
- platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
- platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
- platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
- platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
- platform/mac/fast/lists/w3-list-styles-expected.checksum:
- platform/mac/fast/lists/w3-list-styles-expected.png:
- platform/mac/fast/lists/w3-list-styles-expected.txt:
- platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
- platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png:
- platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
- platform/mac/fast/text/capitalize-boundaries-expected.checksum:
- platform/mac/fast/text/capitalize-boundaries-expected.png:
- platform/mac/fast/text/capitalize-boundaries-expected.txt:
- platform/mac/fast/text/cg-fallback-bolding-expected.checksum:
- platform/mac/fast/text/cg-fallback-bolding-expected.png:
- platform/mac/fast/text/cg-fallback-bolding-expected.txt:
- platform/mac/fast/text/complex-text-opacity-expected.checksum:
- platform/mac/fast/text/complex-text-opacity-expected.png:
- platform/mac/fast/text/complex-text-opacity-expected.txt:
- platform/mac/fast/text/in-rendered-text-rtl-expected.checksum:
- platform/mac/fast/text/in-rendered-text-rtl-expected.png:
- platform/mac/fast/text/in-rendered-text-rtl-expected.txt:
- platform/mac/fast/text/international/001-expected.checksum:
- platform/mac/fast/text/international/001-expected.png:
- platform/mac/fast/text/international/001-expected.txt:
- platform/mac/fast/text/international/002-expected.checksum:
- platform/mac/fast/text/international/002-expected.png:
- platform/mac/fast/text/international/002-expected.txt:
- platform/mac/fast/text/international/003-expected.checksum:
- platform/mac/fast/text/international/003-expected.png:
- platform/mac/fast/text/international/003-expected.txt:
- platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
- platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
- platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
- platform/mac/fast/text/international/bidi-L2-run-reordering-expected.checksum:
- platform/mac/fast/text/international/bidi-L2-run-reordering-expected.png:
- platform/mac/fast/text/international/bidi-L2-run-reordering-expected.txt:
- platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
- platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
- platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
- platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
- platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
- platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
- platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
- platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
- platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/mac/fast/text/international/bidi-european-terminators-expected.checksum:
- platform/mac/fast/text/international/bidi-european-terminators-expected.png:
- platform/mac/fast/text/international/bidi-european-terminators-expected.txt:
- platform/mac/fast/text/international/bidi-fallback-font-weight-expected.checksum:
- platform/mac/fast/text/international/bidi-fallback-font-weight-expected.png:
- platform/mac/fast/text/international/bidi-fallback-font-weight-expected.txt:
- platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
- platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
- platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
- platform/mac/fast/text/international/bidi-innertext-expected.checksum:
- platform/mac/fast/text/international/bidi-innertext-expected.png:
- platform/mac/fast/text/international/bidi-innertext-expected.txt:
- platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
- platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
- platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
- platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
- platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
- platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
- platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
- platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
- platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
- platform/mac/fast/text/international/bidi-listbox-atsui-expected.checksum:
- platform/mac/fast/text/international/bidi-listbox-atsui-expected.png:
- platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt:
- platform/mac/fast/text/international/bidi-listbox-expected.checksum:
- platform/mac/fast/text/international/bidi-listbox-expected.png:
- platform/mac/fast/text/international/bidi-listbox-expected.txt:
- platform/mac/fast/text/international/bidi-menulist-expected.checksum:
- platform/mac/fast/text/international/bidi-menulist-expected.png:
- platform/mac/fast/text/international/bidi-menulist-expected.txt:
- platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum:
- platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
- platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
- platform/mac/fast/text/international/bidi-override-expected.checksum:
- platform/mac/fast/text/international/bidi-override-expected.png:
- platform/mac/fast/text/international/bidi-override-expected.txt:
- platform/mac/fast/text/international/hindi-spacing-expected.checksum:
- platform/mac/fast/text/international/hindi-spacing-expected.png:
- platform/mac/fast/text/international/hindi-spacing-expected.txt:
- platform/mac/fast/text/international/rtl-caret-expected.checksum:
- platform/mac/fast/text/international/rtl-caret-expected.png:
- platform/mac/fast/text/international/rtl-caret-expected.txt:
- platform/mac/fast/text/international/thai-line-breaks-expected.checksum:
- platform/mac/fast/text/international/thai-line-breaks-expected.png:
- platform/mac/fast/text/international/thai-line-breaks-expected.txt:
- platform/mac/fast/text/international/wrap-CJK-001-expected.checksum:
- platform/mac/fast/text/international/wrap-CJK-001-expected.png:
- platform/mac/fast/text/international/wrap-CJK-001-expected.txt:
- platform/mac/fast/text/wide-zero-width-space-expected.checksum:
- platform/mac/fast/text/wide-zero-width-space-expected.png:
- platform/mac/fast/text/wide-zero-width-space-expected.txt:
- 5:24 PM Changeset in webkit [42378] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Hyatt.
<rdar://problem/4680397> tearing seen because deferred updates are disabled
- WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): Don't call WKDisableCGDeferredUpdates on post-Leopard if NSAppKitVersionNumberWithDeferredWindowDisplaySupport is defined.
- 5:05 PM Changeset in webkit [42377] by
-
- 68 edits in trunk/WebCore
2009-04-09 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben
Rename all of the changed()/setChanged()/setDocumentChanged() methods to mention style recalc
explicitly instead.
- bindings/js/JSCustomPositionCallback.cpp: (WebCore::JSCustomPositionCallback::handleEvent):
- bindings/js/JSCustomPositionErrorCallback.cpp: (WebCore::JSCustomPositionErrorCallback::handleEvent):
- bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
- bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent):
- bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- bindings/js/ScriptControllerMac.mm: (WebCore::updateStyleIfNeededForBindings): (WebCore::ScriptController::initJavaJSBindings):
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removeProperty): (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc): (WebCore::CSSMutableStyleDeclaration::setProperty): (WebCore::CSSMutableStyleDeclaration::setStringProperty): (WebCore::CSSMutableStyleDeclaration::setImageProperty): (WebCore::CSSMutableStyleDeclaration::parseDeclaration): (WebCore::CSSMutableStyleDeclaration::addParsedProperties): (WebCore::CSSMutableStyleDeclaration::setCssText): (WebCore::CSSMutableStyleDeclaration::merge): (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- css/CSSMutableStyleDeclaration.h:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::allVisitedStateChanged): (WebCore::CSSStyleSelector::SelectorChecker::visitedStateChanged):
- css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::removeVariable): (WebCore::CSSVariablesDeclaration::setVariable): (WebCore::CSSVariablesDeclaration::setNeedsStyleRecalc):
- css/CSSVariablesDeclaration.h:
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::detach): (WebCore::ContainerNode::setFocus): (WebCore::ContainerNode::setActive): (WebCore::ContainerNode::setHovered):
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::unscheduleStyleRecalc): (WebCore::Document::recalcStyle): (WebCore::Document::updateStyleIfNeeded): (WebCore::Document::updateStyleForAllDocuments): (WebCore::Document::updateLayout): (WebCore::Document::implicitClose): (WebCore::Document::prepareMouseEvent): (WebCore::Document::setFocusedNode): (WebCore::Document::setCSSTarget):
- dom/Document.h:
- dom/Element.cpp: (WebCore::Element::recalcStyle): (WebCore::checkForSiblingStyleChanges):
- dom/InputElement.cpp: (WebCore::InputElement::parseMaxLengthAttribute):
- dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
- dom/Node.cpp: (WebCore::Node::Node): (WebCore::Node::setNeedsStyleRecalc): (WebCore::Node::lazyAttach): (WebCore::Node::dispatchGenericEvent):
- dom/Node.h: (WebCore::Node::needsStyleRecalc): (WebCore::Node::childNeedsStyleRecalc): (WebCore::Node::setChildNeedsStyleRecalc):
- dom/OptionElement.cpp: (WebCore::OptionElement::setSelectedState):
- dom/ScriptElement.cpp: (WebCore::ScriptElementData::evaluateScript):
- dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged): (WebCore::StyledElement::classAttributeChanged): (WebCore::StyledElement::parseMappedAttribute):
- dom/Text.cpp: (WebCore::Text::recalcStyle):
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::insertErrorMessageBlock):
- editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::enable):
- editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection):
- editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): (WebCore::SelectionController::layout): (WebCore::SelectionController::focusedOrActiveStateChanged):
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parseMappedAttribute):
- html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerText): (WebCore::HTMLElement::isContentEditable): (WebCore::HTMLElement::isContentRichlyEditable): (WebCore::HTMLElement::contentEditable):
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::parseMappedAttribute):
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::recalcStyle):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::setIndeterminate): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setAutofilled):
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::finishParsingChildren):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget): (WebCore::HTMLObjectElement::finishParsingChildren): (WebCore::HTMLObjectElement::childrenChanged):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::restoreState): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::typeAheadFind):
- html/HTMLTableElement.cpp: (WebCore::setTableCellsChanged): (WebCore::HTMLTableElement::parseMappedAttribute):
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::executeScript): (WebCore::FrameLoader::gotoAnchor):
- page/DOMWindow.cpp: (WebCore::DOMWindow::alert): (WebCore::DOMWindow::confirm): (WebCore::DOMWindow::prompt):
- page/EventHandler.cpp: (WebCore::EventHandler::hoverTimerFired):
- page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::needsLayout):
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::setNeedsStyleRecalc): (WebCore::AnimationBase::updateStateMachine):
- page/animation/AnimationBase.h:
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::clear): (WebCore::AnimationControllerPrivate::updateAnimationTimer): (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired): (WebCore::AnimationControllerPrivate::startupdateStyleIfNeededDispatcher): (WebCore::AnimationControllerPrivate::addEventToDispatch): (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch): (WebCore::AnimationControllerPrivate::animationTimerFired): (WebCore::AnimationControllerPrivate::pauseAnimationAtTime): (WebCore::AnimationControllerPrivate::pauseTransitionAtTime): (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList): (WebCore::AnimationController::cancelAnimations):
- page/animation/AnimationControllerPrivate.h:
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::sendTransitionEvent):
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::endAnimation): (WebCore::KeyframeAnimation::sendAnimationEvent):
- rendering/RenderObject.cpp: (WebCore::RenderObject::updateDragState):
- rendering/RenderView.cpp: (WebCore::RenderView::selectionBounds):
- svg/SVGAElement.cpp: (WebCore::SVGAElement::svgAttributeChanged):
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
- svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::svgAttributeChanged):
- svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::setNeedsUpdate):
- svg/SVGForeignObjectElement.cpp: (WebCore::addCSSPropertyAndNotifyAttributeMap):
- svg/SVGStopElement.cpp: (WebCore::SVGStopElement::parseMappedAttribute):
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::parseMappedAttribute):
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged): (WebCore::SVGUseElement::childrenChanged): (WebCore::SVGUseElement::recalcStyle):
- svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::updateAnimations):
- wml/WMLAElement.cpp: (WebCore::WMLAElement::parseMappedAttribute):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::parseMappedAttribute):
- wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::insertedIntoDocument):
- 4:53 PM Changeset in webkit [42376] by
-
- 2 edits in trunk/WebKit/mac
2009-04-09 John Sullivan <sullivan@apple.com>
<rdar://problem/6775682> WebKit's support for SnowLeopard sudden termination for
downloads is broken and should be removed
Reviewed by Darin Adler
- Misc/WebDownload.m: (-[WebDownloadInternal downloadDidBegin:]): remove disableSuddenTermination call (-[WebDownloadInternal downloadDidFinish:]): remove enableSuddenTermination call (-[WebDownloadInternal download:didFailWithError:]): remove enableSuddenTermination call
- 4:52 PM Changeset in webkit [42375] by
-
- 2 edits in trunk/WebCore
2009-04-09 Brett Wilson <brettw@chromium.org>
Reviewed by NOBODY (OOPS!).
When there is a shadow set but it specifies "no shadow", clear the
shadow shader. This will prevent Chromium from thinking there's a
shadow and using the Skia codepath rather than Windows.
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
- 4:01 PM Changeset in webkit [42374] by
-
- 3 edits2 adds in trunk
Reviewed by Simon Fraser.
Crash when accessing svg.viewport on a detached SVGSVGElement
https://bugs.webkit.org/show_bug.cgi?id=25105
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::isOutermostSVG): return "true" that we are the "outermost" SVG element if we have no parent. (The spec is unclear as t
o what behavior we should have in this case, and I doubt anyone cares for now).
- 3:42 PM Changeset in webkit [42373] by
-
- 5 edits in trunk/WebCore
2009-04-09 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25084
Upstream changes to V8 bindings for XHR so that it can work under either DOMWindow or WorkerContext.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::retrieve): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper): (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener): (WebCore::WorkerContextExecutionProxy::findOrCreateObjectEventListener):
- bindings/v8/WorkerContextExecutionProxy.h:
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- 3:40 PM Changeset in webkit [42372] by
-
- 6 edits5 adds in trunk
WebCore:
2009-04-09 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson and Sam Weinig.
Part of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing
Longer term solution is to change the design so Safari doesn't read and write all of history.
This patch is step one: Do the serializing, which is done on the main thread, much faster.
- WebCore.base.exp: Added new entry points.
- WebCore.xcodeproj/project.pbxproj: Added new source files.
- history/cf: Added.
- history/cf/HistoryPropertyList.cpp: Added.
- history/cf/HistoryPropertyList.h: Added. Code to write history files. In the future we'll also have code for reading here too.
- platform/cf/BinaryPropertyList.cpp: Added.
- platform/cf/BinaryPropertyList.h: Added. Code to write binary property list files.
WebKit/mac:
2009-04-09 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson and Sam Weinig.
Part of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing
Longer term solution is to change the design so Safari doesn't read and write all of history.
This patch is step one: Do the serializing, which is done on the main thread, much faster.
- History/WebHistory.mm: (-[WebHistoryPrivate data]): Added. Returns the NSData object containing serialized history. For creating new SPI so you can get the data in memory instead of on disk. Uses WebHistoryWriter. (-[WebHistoryPrivate saveToURL:error:]): Changed to call [self data (-[WebHistory _data]): Added. (WebHistoryWriter::WebHistoryWriter): Added. (WebHistoryWriter::writeHistoryItems): Added.
- History/WebHistoryPrivate.h: Added a new _data method.
- 3:25 PM Changeset in webkit [42371] by
-
- 2 edits in trunk/WebCore
2009-04-09 Simon Fraser <Simon Fraser>
Reviewed by Antti Koivisto
If deferred repainting is active, we need to ensure that there are no repaints
pending at the end of layoutIfNeededRecursive, which is called just before
painting via -viewWillDraw.
- page/FrameView.cpp: (WebCore::FrameView::layoutIfNeededRecursive):
- 3:08 PM Changeset in webkit [42370] by
-
- 1 edit in trunk/WebCore/dom/Document.cpp
Removed duplicate header include.
- 2:35 PM Changeset in webkit [42369] by
-
- 2 edits in trunk/WebKit/mac
2009-04-09 Mike Thole <mthole@apple.com>
Rubber-stamped by Mark Rowe.
Fix 64-bit build
- Panels/WebAuthenticationPanel.h:
Declare the 'separateRealmLabel' IBOutlet as an NSTextField instead of 'id'.
This fixes a duplicate method warning (setAutoresizingMask: on NSView and CALayer)
- 1:45 PM Changeset in webkit [42368] by
-
- 2 edits in trunk/WebCore
2009-04-09 John Grabowski <jrg@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=25117
Fix Mac Chromium form controls.
- rendering/RenderThemeChromiumMac.mm: When rendering native controls in Mac Chromium, use a clean NSGraphicsContext. Properly save and restore native graphics context. (WebCore::RenderThemeChromiumMac::paintCheckbox): (WebCore::RenderThemeChromiumMac::paintRadio): (WebCore::RenderThemeChromiumMac::paintMenuList): (WebCore::RenderThemeChromiumMac::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton):
- 1:45 PM Changeset in webkit [42367] by
-
- 7 edits1 add in trunk/WebCore
2009-04-09 Drew Wilson <atwilson@google.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=25030
Refactor MessagePort code to enable Chrome to use a MessagePortProxy object
instead of a real MessagePort for the entangledPort, since it could
theoretically live in a separate process.
The goal of this refactoring is to remove all assumptions that the object
representing the entangled port is actually of type MessagePort. All
operations that were previously directly modifying private MessagePort member
variables in the entangled port (i.e. entangle(), postMessage()) have been changed
to invoke functions in the MessagePortProxy interface instead which will allow
the Chrome bindings to proxy these calls to another process.
No new layout tests, as this is just a refactoring with no bug fixes
or new functionality.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):
- dom/MessagePort.cpp: (WebCore::MessagePort::clone): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::deliverMessage): (WebCore::MessagePort::startConversation): (WebCore::MessagePort::close): (WebCore::MessagePort::entangle): (WebCore::MessagePort::unentangle):
- dom/MessagePort.h: (WebCore::MessagePort::entangledPort):
- dom/MessagePortProxy.h: Added. (WebCore::MessagePortProxy::~MessagePortProxy):
- 1:45 PM Changeset in webkit [42366] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-09 Ben Murdoch <benm@google.com>
Reviewed by Alexey Proskuryakov.
The Android platform requires threads to be registered with the VM.
This patch implements this behaviour inside ThreadingPthreads.cpp.
- wtf/ThreadingPthreads.cpp: Add a level above threadEntryPoint that takes care of (un)registering threads with the VM. (WTF::runThreadWithRegistration): register the thread and run entryPoint. Unregister the thread afterwards. (WTF::createThreadInternal): call runThreadWithRegistration instead of entryPoint directly.
- 11:30 AM Changeset in webkit [42365] by
-
- 4 edits7 adds in trunk
WebCore:
2009-04-08 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey "Big Boy" Garen.
Fix for <rdar://problem/5745677> Possible to stop load during an unload event
Also fixes https://bugs.webkit.org/show_bug.cgi?id=20605
Tests: fast/events/stop-load-in-unload-handler-using-document-write.html
fast/events/stop-load-in-unload-handler-using-window-stop.html
Don't allow calling methods that would stop the new load inside the unload
event.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stopAllLoaders):
- loader/FrameLoader.h:
LayoutTests:
2009-04-08 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey "Big Boy" Garen.
Tests for <rdar://problem/5745677> Possible to stop load during an unload event
- fast/events/resources/pass.html: Added.
- fast/events/resources/subframe-stop-load-in-unload-handler-using-document-write.html: Added.
- fast/events/resources/subframe-stop-load-in-unload-handler-using-window-stop.html: Added.
- fast/events/stop-load-in-unload-handler-using-document-write-expected.txt: Added.
- fast/events/stop-load-in-unload-handler-using-document-write.html: Added.
- fast/events/stop-load-in-unload-handler-using-window-stop-expected.txt: Added.
- fast/events/stop-load-in-unload-handler-using-window-stop.html: Added.
- 10:32 AM Changeset in webkit [42364] by
-
- 2 edits in trunk/WebKit
2009-04-09 Mike Thole <mthole@apple.com>
Reviewed by Adam Roben.
- WebKit.xcodeproj/project.pbxproj:
Set the Localizable.strings encoding to UTF-16.
- 10:06 AM Changeset in webkit [42363] by
-
- 6 edits in trunk/WebKit
2009-04-09 Mike Thole <mthole@apple.com>
Reviewed by Ada Chan.
<rdar://problem/5697111> Basic authentication dialog spoofing vulnerability
- Panels/WebAuthenticationPanel.h:
Added IBOutlet for separateRealmLabel
- Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]):
In the realm case, decide if it is a simple or complex realm name. A realm name
is considered complex if it has any whitespace or newline characters. Present
alternative text and layout for the complex case, where the realm name isn't inline
with the rest of the sheet's text.
- Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
- Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
Updated the nib with a new 'separateRealmLabel' outlet.
Updated the File's Owner to correctly be WebAuthenticationPanel.
Fixed springs on the sheet's icon to keep it from moving during a resize.
- 9:43 AM Changeset in webkit [42362] by
-
- 2 edits in trunk/LayoutTests
Update results for createDocument-namespace-err.html
It looks like the test was changed without updating the results before
it was committed.
Rubber-stamped by Adele Peterson.
- fast/dom/DOMImplementation/createDocument-namespace-err-expected.txt: Updated.
- 9:33 AM Changeset in webkit [42361] by
-
- 20 edits in trunk
Reinstating <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings
Rolled r42345 back in. The build failure was caused by an
internal script which had not been updated the same way that
build-webkit was updated.
- Configurations/JavaScriptCore.xcconfig:
WebCore:
- Configurations/WebCore.xcconfig:
- DerivedSources.make:
- bindings/objc/DOM.mm: (WebCore::createElementClassMap): (+[DOMNode _wrapNode:WebCore::]):
- bindings/objc/DOMCSS.mm: (+[DOMCSSValue _wrapCSSValue:WebCore::]):
- bindings/objc/DOMEvents.mm: (+[DOMEvent _wrapEvent:WebCore::]):
- bindings/objc/DOMInternal.h:
- bindings/objc/ExceptionHandlers.mm: (WebCore::raiseDOMException):
- html/HTMLEmbedElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLObjectElement.idl:
WebKit/mac:
- Configurations/WebKit.xcconfig:
- DOM/WebDOMOperations.mm:
- MigrateHeaders.make:
WebKitTools:
- Scripts/build-webkit:
- 9:30 AM Changeset in webkit [42360] by
-
- 10 edits in trunk/WebCore
2009-04-09 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Eliminate CompositeAnimationPrivate, which was a needless level
of abstraction. Remove the methods like addToStyleAvailableWaitList()
that simply turn around and call the animation controller.
Rename animationControllerPriv() to animationController().
Rename willNeedService() to timeToNextService().
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::~AnimationBase): (WebCore::AnimationBase::updateStateMachine): (WebCore::AnimationBase::timeToNextService): (WebCore::AnimationBase::beginAnimationUpdateTime):
- page/animation/AnimationBase.h:
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateAnimationTimer):
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::~CompositeAnimation): (WebCore::CompositeAnimation::clearRenderer): (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate): (WebCore::CompositeAnimation::getAnimatedStyle): (WebCore::CompositeAnimation::setAnimating): (WebCore::CompositeAnimation::timeToNextService): (WebCore::CompositeAnimation::getAnimationForProperty): (WebCore::CompositeAnimation::cleanupFinishedAnimations): (WebCore::CompositeAnimation::suspendAnimations): (WebCore::CompositeAnimation::resumeAnimations): (WebCore::CompositeAnimation::overrideImplicitAnimations): (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations): (WebCore::CompositeAnimation::isAnimatingProperty): (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::pauseTransitionAtTime): (WebCore::CompositeAnimation::numberOfActiveAnimations):
- page/animation/CompositeAnimation.h: (WebCore::CompositeAnimation::animationController): (WebCore::CompositeAnimation::isSuspended): (WebCore::CompositeAnimation::hasAnimations): (WebCore::CompositeAnimation::CompositeAnimation):
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::sendTransitionEvent): (WebCore::ImplicitAnimation::timeToNextService):
- page/animation/ImplicitAnimation.h:
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::sendAnimationEvent): (WebCore::KeyframeAnimation::timeToNextService):
- page/animation/KeyframeAnimation.h:
- 9:13 AM Changeset in webkit [42359] by
-
- 2 edits1 add in trunk/WebKitTools
2009-04-09 David Levin <levin@chromium.org>
Reviewed by David Kilzer.
Launch DumpRenderTree and the image diff tool in a way that will work from perl threads.
This is a workaround due to a perl limitation. When perl does open* calls on a thread, it ignores
the environment of the current thread and simply uses the environment of the main thread instead.
- Scripts/execAppWithEnv: Added.
- Scripts/run-webkit-tests:
- 6:49 AM Changeset in webkit [42358] by
-
- 20 edits in trunk
Reverting <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings.
It broke Mac build, and I don't know how to fix it.
- 6:17 AM Changeset in webkit [42357] by
-
- 2 edits in trunk/WebCore
2009-04-09 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
RenderView::docWidth() was made private by r42334. That commit
changes its usage for overflowWidth(), so do that here too.
- page/PrintContext.cpp: (WebCore::PrintContext::computePageRects):
- 5:29 AM Changeset in webkit [42356] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-09 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
Checking for GLIBCXX being bigger than some date is not enough
to get std::tr1, C++0x has to be in use too. Add another check for
GXX_EXPERIMENTAL_CXX0X.
- wtf/TypeTraits.h:
- 4:20 AM Changeset in webkit [42355] by
-
- 2 edits in trunk/WebCore
2009-04-09 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Based on a patch by Alp Toker.
Implement AtkObject::ref_state_set. Still quite a few states not
implemented.
- page/gtk/AccessibilityObjectWrapperAtk.cpp:
- 4:17 AM Changeset in webkit [42354] by
-
- 2 edits in trunk/WebCore
2009-04-09 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Based on a patch by Alp Toker.
Move fallback object creation to its own function, as it will be
used in several places.
- page/gtk/AccessibilityObjectWrapperAtk.cpp: (fallbackObject):
- 4:15 AM Changeset in webkit [42353] by
-
- 3 edits in trunk/WebCore
2009-04-09 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Based on a patch by Alp Toker.
Move AccessibilityObject methods to their file.
- page/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::wrapper): (WebCore::AccessibilityObject::setWrapper):
- page/gtk/AccessibilityObjectWrapperAtk.cpp:
- 4:08 AM Changeset in webkit [42352] by
-
- 2 edits in trunk/WebCore
2009-04-08 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Rework accessibility type generation code, based on Mozilla a11y
implementation.
Have one base a11y type, and generate derived types that implement
only the necessary interfaces at runtime, based on the specific
object we are wrapping. This allows to save a lot of code while
covering all possible cases.
- page/gtk/AccessibilityObjectWrapperAtk.cpp:
- 3:40 AM Changeset in webkit [42351] by
-
- 4 edits3 adds in trunk
Reviewed by Oliver Hunt.
Fix document.implementation.createDocument(null, "a:b") not to crash!
https://bugs.webkit.org/show_bug.cgi?id=25096
Test: fast/dom/DOMImplementation/createDocument-namespace-err.html
- dom/ContainerNode.cpp: (WebCore::ContainerNode::addChild): add ASSERT() to give a better crash next time
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): check the exception code before using the result
- 12:21 AM Changeset in webkit [42350] by
-
- 2 edits in trunk/WebCore
Make <select>s in application chrome documents match the Vista system dialog look
Reviewed by Dave Hyatt.
- rendering/RenderThemeWin.cpp: (WebCore::documentIsInApplicationChromeMode): Added this simple helper function. (WebCore::RenderThemeWin::getThemeData): In application chrome mode, the drop down button never uses any look but the "normal" look. (WebCore::RenderThemeWin::paintMenuList): In application chrome mode, use the "readonly" style to match system dialogs.
- 12:20 AM Changeset in webkit [42349] by
-
- 2 edits in trunk/WebCore
Fix <rdar://6592515> Crash closing tab with Top Sites or Cover Flow showing after clicking "Go Back" in phishing alert
RenderButton's m_timer is not stopped when its Document enters the
page cache. When the WebView was torn down, the timer would fire after
the Frame's Page had been destroyed, leading to a crash. This patch
just makes the timer do nothing when it fires. Making the timer not
fire when in the page cache is covered by bug 25110.
Reviewed by Dave Hyatt.
No test possible.
- rendering/RenderButton.cpp: (WebCore::RenderButton::timerFired): Do nothing when we're in the page cache.
- 12:11 AM Changeset in webkit [42348] by
-
- 2 edits in trunk/WebCore
2009-04-09 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben
Fix bugs where we would mistakenly turn off blitting for iframes if an external paint
caused the checks to be triggered too early in the loading process of the frame.
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
Apr 8, 2009:
- 9:17 PM Changeset in webkit [42347] by
-
- 5 edits in trunk
Fix assertion failure in function.apply
Reviewed by Adam Roben.
The result of excess arguments to function.apply is irrelevant
so we don't need to provide a result register. We were providing
temporary result register but not ref'ing it resulting in an
assertion failure.
- 6:33 PM Changeset in webkit [42346] by
-
- 2 edits in trunk/WebCore
2009-04-08 Simon Fraser <Simon Fraser>
Reviewed by Cameron Zwarich
Fix signature of virtual function on AnimationBase so that it matches
those in the derived classes, by removing unused parameter.
- page/animation/AnimationBase.h: (WebCore::AnimationBase::endAnimation):
- 6:27 PM Changeset in webkit [42345] by
-
- 20 edits in trunk
<rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings
Reviewed by Darin Adler and Maciej Stachowiak.
Introduce the ENABLE_SVG_DOM_OBJC_BINDINGS feature define so
that SVG DOM Objective-C bindings may be optionally disabled.
- Configurations/JavaScriptCore.xcconfig: Added ENABLE_SVG_DOM_OBJC_BINDINGS variable and use it in FEATURE_DEFINES.
WebCore:
- Configurations/WebCore.xcconfig: Added ENABLE_SVG_DOM_OBJC_BINDINGS variable and use it in FEATURE_DEFINES and EXCLUDED_SOURCE_FILE_NAMES. When SVG DOM Objective-C bindings are disabled, two generated header files no longer exist and none of the generated DOMSVG*.mm files should be compiled.
- DerivedSources.make: All of the WebCore.SVG*.exp files contain SVG DOM Objective-C bindings classes, so exclude them unless ENABLE_SVG_DOM_OBJC_BINDINGS is set.
- bindings/objc/DOM.mm: Switched from using ENABLE(SVG) to using ENABLE(SVG_DOM_OBJC_BINDINGS). (WebCore::createElementClassMap): (+[DOMNode _wrapNode:WebCore::]):
- bindings/objc/DOMCSS.mm: Ditto. (+[DOMCSSValue _wrapCSSValue:WebCore::]):
- bindings/objc/DOMEvents.mm: Ditto. (+[DOMEvent _wrapEvent:WebCore::]):
- bindings/objc/DOMInternal.h: Ditto.
- bindings/objc/ExceptionHandlers.mm: Added use of ENABLE(SVG_DOM_OBJC_BINDINGS). (WebCore::raiseDOMException):
- html/HTMLEmbedElement.idl: Excluded -getSVGDocument method in generated Objective-C DOM classes if SVG DOM Objective-C bindings are disabled.
- html/HTMLFrameElement.idl: Ditto.
- html/HTMLIFrameElement.idl: Ditto.
- html/HTMLObjectElement.idl: Ditto.
WebKit/mac:
- Configurations/WebKit.xcconfig: Added ENABLE_SVG_DOM_OBJC_BINDINGS variable and use it in FEATURE_DEFINES.
- DOM/WebDOMOperations.mm: Removed unused header.
- MigrateHeaders.make: Switched from using ENABLE_SVG to using ENABLE_SVG_DOM_OBJC_BINDINGS.
WebKitTools:
- Scripts/build-webkit: Added --[no-]svg-dom-objc-bindings command-line argument. Set special ENABLE_SVG_DOM_OBJC_BINDINGS Xcode variable required by WebCore.xcconfig.
- 6:14 PM Changeset in webkit [42344] by
-
- 8 edits1 add in trunk/JavaScriptCore
2009-04-08 Paul Pedriana <ppedriana@ea.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=20422
Allow custom memory allocation control.
- wtf/FastAllocBase.h: New added file. Implements allocation base class.
- wtf/TypeTraits.h: Augments existing type traits support as needed by FastAllocBase.
- wtf/FastMalloc.h: Changed to support FastMalloc match validation.
- wtf/FastMalloc.cpp: Changed to support FastMalloc match validation.
- wtf/Platform.h: Added ENABLE_FAST_MALLOC_MATCH_VALIDATION; defaults to 0.
- GNUmakefile.am: Updated to include added FastAllocBase.h.
- JavaScriptCore.xcodeproj/project.pbxproj: Updated to include added FastAllocBase.h.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Updated to include added FastAllocBase.h.
- 5:07 PM Changeset in webkit [42343] by
-
- 2 edits in trunk/LayoutTests
Skip fast/js/toString-stack-overflow.html on Windows
This test sometimes crashes in Debug builds.
Rubber-stamped by Geoff Garen.
- platform/win/Skipped: Skip toString-stack-overflow.html.
- 4:43 PM Changeset in webkit [42342] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
- limit the workaround for <rdar://problem/5781372> to Mac OS X versions that need it
- platform/mac/WebFontCache.mm: (fixUpWeight): Changed this function to be a no-op post-Leopard.
- 4:37 PM Changeset in webkit [42341] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/6771547> Appending to a RenderText causes all its lines to be dirtied
Test: fast/repaint/text-append-dirty-lines.html
- rendering/RenderText.cpp: (WebCore::RenderText::setTextWithOffset): If no text boxes intersected with or came after the new text, dirty the last root box, since the new text may begin there. Having at least one dirty line prevents the incorrect dirtying of all lines later during layoutInlineChildren().
LayoutTests:
Reviewed by Dave Hyatt.
- test for <rdar://problem/6771547> Appending to a RenderText causes all its lines to be dirtied
- fast/repaint/text-append-dirty-lines.html: Added.
- platform/mac/fast/repaint/text-append-dirty-lines-expected.checksum: Added.
- platform/mac/fast/repaint/text-append-dirty-lines-expected.png: Added.
- platform/mac/fast/repaint/text-append-dirty-lines-expected.txt: Added.
- 4:24 PM Changeset in webkit [42340] by
-
- 7 edits in trunk
2009-04-08 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
Fixes a Chromium-specific crash in WebCore::ImageBuffer::context that
occurs when rendering semi-transparent RTL text.
Test: fast/text/complex-text-opacity.html
- platform/graphics/chromium/FontChromiumWin.cpp: Handle RTL when computing text bounds. (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds):
- 4:17 PM Changeset in webkit [42339] by
-
- 1 edit7 adds in trunk/LayoutTests
2009-04-08 Sam Weinig <sam@webkit.org>
Add Windows specific results.
- platform/win/http/tests/security: Added.
- platform/win/http/tests/security/XFrameOptions: Added.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Added.
- 4:14 PM Changeset in webkit [42338] by
-
- 1 edit6 adds in trunk/LayoutTests
2009-04-08 Sam Weinig <sam@webkit.org>
Add Tiger specific results.
- platform/mac-tiger/http/tests/security: Added.
- platform/mac-tiger/http/tests/security/XFrameOptions: Added.
- platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
- platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
- platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
- platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
- 4:08 PM Changeset in webkit [42337] by
-
- 24 edits3 adds in trunk
Improve function.apply performance
Reviewed by Geoff Garen.
Jump through a few hoops to improve performance of function.apply in the general case.
In the case of zero or one arguments, or if there are only two arguments and the
second is an array literal we treat function.apply as function.call.
Otherwise we use the new opcodes op_load_varargs and op_call_varargs to do the .apply call
without re-entering the virtual machine.
- 4:06 PM Changeset in webkit [42336] by
-
- 2 edits in trunk/WebCore
2009-04-08 David Hyatt <hyatt@apple.com>
Reviewed by Beth Dakin
Fix a porting error in my previous patch. A != was supposed to be an ==.
- platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):
- 4:02 PM Changeset in webkit [42335] by
-
- 2 edits in trunk/LayoutTests
Skip fast/cookies/local-file-can-set-cookies.html on Windows
Reviewed by John Sullivan.
- platform/win/Skipped: Skip local-file-can-set-cookies.html, which is failing due to a bug in one of our dependencies.
- 3:33 PM Changeset in webkit [42334] by
-
- 22 edits4 adds in trunk
WebCore:
2009-04-08 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben and Darin Adler
Fix for https://bugs.webkit.org/show_bug.cgi?id=12440, repaints inconsistent for
fixed positioned elements.
Rewrite the updateScrollers method to be more correct in its results.
Test: fast/block/positioning/fixed-positioning-scrollbar-bug.html
- dom/Document.cpp: (WebCore::Document::recalcStyle): (WebCore::Document::implicitClose):
- page/FrameView.cpp: (WebCore::FrameView::createScrollbar): (WebCore::FrameView::layout): (WebCore::FrameView::adjustPageHeight):
- page/FrameView.h:
- page/win/FrameWin.cpp: (WebCore::computePageRectsForFrame):
- platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::updateScrollbars):
- platform/ScrollView.h:
- rendering/RenderView.cpp: (WebCore::RenderView::layout): (WebCore::RenderView::docHeight): (WebCore::RenderView::docWidth):
- rendering/RenderView.h:
WebKit/mac:
2009-04-08 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben and Darin Adler
Fix for https://bugs.webkit.org/show_bug.cgi?id=12440, fixed positioned elements end up in
inconsistent positions. Rewrite updateScrollers to improve the correctness.
- WebView/WebDynamicScrollBarsView.h:
- WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
LayoutTests:
2009-04-08 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben and Darin Adler
Updated results and new tests for https://bugs.webkit.org/show_bug.cgi?id=12440.
- fast/block/positioning/fixed-positioning-scrollbar-bug.html: Added.
- platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.checksum: Added.
- platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png: Added.
- platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt: Added.
- platform/mac/fast/flexbox/016-expected.checksum:
- platform/mac/fast/flexbox/016-expected.png:
- platform/mac/fast/flexbox/016-expected.txt:
- platform/mac/fast/flexbox/flex-hang-expected.checksum:
- platform/mac/fast/flexbox/flex-hang-expected.png:
- platform/mac/fast/flexbox/flex-hang-expected.txt:
- platform/mac/fast/lists/001-expected.checksum:
- platform/mac/fast/lists/001-expected.png:
- platform/mac/fast/lists/001-expected.txt:
- 3:16 PM Changeset in webkit [42333] by
-
- 6 edits23 adds in trunk
WebCore:
2009-04-08 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix for <rdar://problem/6226200> Implement Microsoft's X-FRAME-OPTIONS anti-framing defense
Tests: http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html
http/tests/security/XFrameOptions/x-frame-options-deny.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
- dom/Document.cpp: (WebCore::Document::processHttpEquiv): Stop the current load and redirect to about:blank if an X-FRAME-OPTIONS <meta> tag http-equiq dictates we should.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions): Add logic to parse the X-FRAME-OPTIONS parameter.
- loader/FrameLoader.h:
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse): Stop the current load if framed and a X-FRAME-OPTIONS header and its parameter dictate that we should.
LayoutTests:
2009-04-08 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Tests for <rdar://problem/6226200> Implement Microsoft's X-FRAME-OPTIONS anti-framing defense
- http/tests/security/XFrameOptions: Added.
- http/tests/security/XFrameOptions/resources: Added.
- http/tests/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe-in-body.html: Added.
- http/tests/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe-parent-same-origin-allow.html: Added.
- http/tests/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe-parent-same-origin-deny.html: Added.
- http/tests/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe.html: Added.
- http/tests/security/XFrameOptions/resources/x-frame-options-deny.cgi: Added.
- http/tests/security/XFrameOptions/resources/x-frame-options-parent-same-origin-allow.cgi: Added.
- http/tests/security/XFrameOptions/resources/x-frame-options-parent-same-origin-deny.cgi: Added.
- http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html: Added.
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html: Added.
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html: Added.
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html: Added.
- http/tests/security/XFrameOptions/x-frame-options-deny.html: Added.
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Added.
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html: Added.
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html: Added.
- 1:57 PM Changeset in webkit [42332] by
-
- 2 edits in trunk/WebKit/win
Fix security/block-test-no-port.html on Windows
Reviewed by Beth Dakin.
- WebMutableURLRequest.cpp: (WebMutableURLRequest::mainDocumentURL): Return the ResourceRequest's mainDocumentURL, not its URL.
- 1:31 PM Changeset in webkit [42331] by
-
- 2 edits in trunk/WebCore
Fix http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html on Windows
Reviewed by Sam Weinig.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Mimic the ResourceHandleMac code by propagating the CFError's error code for kCFErrorDomainCFNetwork errors to the ResourceResponse.
- 11:56 AM Changeset in webkit [42330] by
-
- 1 edit6 copies3 moves4 adds in trunk/LayoutTests
2009-04-08 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
More tests for our handling of MIME types and style sheets.
- http/tests/mime/resources/style-with-charset.php: Added.
- http/tests/mime/resources/style-with-empty-content-type.cgi: Renamed from LayoutTests/http/tests/mime/resources/style.cgi.
- http/tests/mime/resources/style-with-text-plain.php: Added.
- http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension-expected.txt: Added.
- http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension.html: Added.
- http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-expected.txt: Added.
- http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain.html: Added.
- http/tests/mime/standard-mode-loads-stylesheet-with-charset-and-css-extension-expected.txt: Copied from LayoutTests/http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header-expected.txt.
- http/tests/mime/standard-mode-loads-stylesheet-with-charset-and-css-extension.html: Added.
- http/tests/mime/standard-mode-loads-stylesheet-with-charset-expected.txt: Copied from LayoutTests/http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header-expected.txt.
- http/tests/mime/standard-mode-loads-stylesheet-with-charset.html: Added.
- http/tests/mime/standard-mode-loads-stylesheet-with-empty-content-type-expected.txt: Renamed from LayoutTests/http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header-expected.txt.
- http/tests/mime/standard-mode-loads-stylesheet-with-empty-content-type.html: Added.
- http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header.html: Removed.
- 11:54 AM Changeset in webkit [42329] by
-
- 2 edits in trunk/WebCore
2009-04-08 Anders Carlsson <andersca@apple.com>
Try to fix the PPC build.
- plugins/npfunctions.h:
- 11:36 AM Changeset in webkit [42328] by
-
- 2 edits in trunk/WebCore
2009-04-08 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
<rdar://problem/5908616> tokenizer resizer should handle edge cases consistently
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::enlargeBuffer): Handle edge cases the same way as a failed fastMalloc. (WebCore::HTMLTokenizer::enlargeScriptBuffer): Ditto.
- 11:28 AM Changeset in webkit [42327] by
-
- 2 edits in trunk/WebCore
2009-04-08 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler
Make sure that cloneNode works with SVG attributes that require synchronization. This fixes
issues with <use> element shadow tree cloning where the clones can end up not obtaining the
correct attribute values.
A subsequent patch of mine will expose this problem and cause it to be covered by existing
layout tests, so no test is required at this time for this problem.
- dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren):
- 10:58 AM Changeset in webkit [42326] by
-
- 1 edit1 add in trunk/LayoutTests
Check in Windows-specific results for an SVG test that was failing due to rounding issues
Rubber-stamped by Dave Hyatt.
- platform/win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Added.
- 10:52 AM Changeset in webkit [42325] by
-
- 2 edits in trunk/WebCore
2009-04-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=25093
REGRESSION: some scripts are showing in the Inspector with only "true"
as the source.
- inspector/InspectorController.cpp: (WebCore::InspectorController::didParseSource): Fixed conversion issue. (WebCore::InspectorController::failedToParseSource): Ditto.
- 10:07 AM Changeset in webkit [42324] by
-
- 15 edits2 deletes in trunk
Reverting r42321 because it broke some layout tests.
- 9:39 AM Changeset in webkit [42323] by
-
- 2 edits in trunk/LayoutTests
Add a failing test to the Windows Skipped file
- platform/win/Skipped: Added media/video-size-intrinsic-scale.html.
- 9:25 AM Changeset in webkit [42322] by
-
- 3 edits5 adds in trunk
WebCore:
2009-04-08 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Verify the MIME type of stylesheets (in standards mode) by looking
at the Content-Type header directly. This bypasses any content
sniffing that might be confusing the issue.
Test: http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header.html
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::canUseSheet):
LayoutTests:
2009-04-08 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Test that we apply style sheets in standards mode even if
those style sheets have an empty Content-Type header.
- http/tests/mime/resources/style.cgi: Added.
- http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header-expected.txt: Added.
- http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header.html: Added.
- 9:04 AM Changeset in webkit [42321] by
-
- 15 edits2 adds in trunk
2009-04-07 Anantanarayanan Iyengar <ananta@chromium.org>
Reviewed by Darin Fisher.
Added support for returning plugins which support the wildcard mime type (*).
This is on the same lines as Firefox, which uses a wildcard plugin (npnul32.dll) for
plugin installation. The changes to support wildcard mime type matching are in
PluginDatabase.cpp which is used by Webkit's plugin implementation, and
PluginData.cpp/.h which is used by Chromium.
Test: plugins/netscape-plugin-wildcard-plugin.html
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
- plugins/PluginData.cpp: (WebCore::PluginData::supportsMimeType): (WebCore::PluginData::supportsMimeTypeIgnoringWildCards):
- plugins/PluginData.h:
- plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::pluginForMIMEType):
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::isPluginBlacklisted):
- 7:42 AM Changeset in webkit [42320] by
-
- 2 edits in trunk/WebCore
2009-04-08 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=25041
<rdar://problem/6697754>
Bug 25041: HTMLMediaElement: OSX autoplay broken by r41907
OSX media player should set readyState to HAVE_ENOUGH_DATA when the movie's load state
reaches QTMovieLoadStatePlaythroughOK, not when the entire file has been downloaded,
so autoplay can begin when it should.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): Set readState to HAVE_ENOUGH_DATA when QTMovie load state reaches QTMovieLoadStatePlaythroughOK. (WebCore::MediaPlayerPrivate::paint): Add braces missed in r42203.
- 7:35 AM Changeset in webkit [42319] by
-
- 3 edits in trunk/WebCore
Reviewed by David Kilzer. Based on a patch by Grace Kloba.
https://bugs.webkit.org/show_bug.cgi?id=24656
cacheControlContainsNoCache() in ResourceResponseBase.h is wrong
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::parseCacheControlDirectives): Removed misused code for parsing directive values, fixing parsing of directives that we care about.
- platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::cacheControlContainsNoCache): Fixed a copy/paste mistake, m_cacheControlContainsMustRevalidate was returned instead of m_cacheControlContainsNoCache.
- 6:21 AM Changeset in webkit [42318] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-08 Alejandro Piñeiro <apinheiro@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Use getOrCreate instead of just get, as we need to actually create
the wrapper object the first time this function is called.
- webkit/webkitwebview.cpp:
- 12:48 AM Changeset in webkit [42317] by
-
- 2 edits in trunk/WebCore
Make text fields match the system look on Vista
Reviewed by Dave Hyatt.
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::getThemeData): Use the new-to-Vista EP_EDITBORDER_NOSCROLL part for text fields.
- 12:47 AM Changeset in webkit [42316] by
-
- 2 edits in trunk/WebKitTools
Print the number of files being compiled when using pdevenv
- Scripts/parallelcl:
- 12:06 AM Changeset in webkit [42315] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25073
JavaScriptCore tests don't run if time zone is not PST
- API/tests/testapi.c: (timeZoneIsPST): Added a function that checks whether the time zone is PST, using the same method as functions in DateMath.cpp do for formatting the result. (main): Skip date string format test if the time zone is not PST.
- 12:02 AM Changeset in webkit [42314] by
-
- 4 edits2 adds in trunk
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=24957
REGRESSION: Google calendar widget no longer shows upcoming events
Test: http/tests/xmlhttprequest/authorization-header.html
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Removed Authorization from the list of forbidden headers.
Apr 7, 2009:
- 10:33 PM Changeset in webkit [42313] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config
Ignore passwords.json to prevent it from accidentally being checked in.
- 10:29 PM Changeset in webkit [42312] by
-
- 4 edits1 move5 adds1 delete in trunk/WebKitTools
Land the current build.webkit.org configuration for safekeeping.
- BuildSlaveSupport/build.webkit.org-config/README: Added.
- BuildSlaveSupport/build.webkit.org-config/Makefile:
- BuildSlaveSupport/build.webkit.org-config/buildbot.tac:
- BuildSlaveSupport/build.webkit.org-config/config.json: Added.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css: Renamed from BuildSlaveSupport/build.webkit.org-config/buildbot.css.
- BuildSlaveSupport/build.webkit.org-config/public_html/index.html: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt: Added.
- BuildSlaveSupport/build.webkit.org-config/webkit/init.py: Removed.
- BuildSlaveSupport/build.webkit.org-config/webkit/auth.py: Removed.
- BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py: Removed.
- BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Removed.
- BuildSlaveSupport/build.webkit.org-config/webkit/factories.py: Removed.
- BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py: Removed.
- BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Removed.
- BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Removed.
- 10:08 PM Changeset in webkit [42311] by
-
- 2 edits in trunk/WebKitTools
Ignore the mysterious exception that Cygwin's Python is throwing when attempting
to remove the layout-test-results directory.
- BuildSlaveSupport/test-result-archive:
- 9:54 PM Changeset in webkit [42310] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Remove no longer needed debug warning and Windows-specific codepaths
(as we now use the Safari/Win port's timer there)
- 9:34 PM Changeset in webkit [42309] by
-
- 2 edits in trunk/WebKitTools
Change the working directory before removing the test result directory
in the hopes of making the Windows build slaves happier.
- BuildSlaveSupport/test-result-archive:
- 9:30 PM Changeset in webkit [42308] by
-
- 3 edits in trunk/WebKitTools
Make the links to tests in the uploaded results.html files on build.webkit.org point to the test files.
Reviewed by Adam Roben.
- Scripts/VCSUtils.pm: Add a function that will return the location of a file relative to the root of the working copy.
- Scripts/run-webkit-tests: Convert the path in to a remote URL if the path is below the layout tests directory.
- 8:36 PM Changeset in webkit [42307] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Adam Roben.
- make this test insensitive to platform differences in Thai word breaking dictionaries
- editing/selection/thai-word-at-document-end.html:
- 8:21 PM Changeset in webkit [42306] by
-
- 2 edits in trunk/WebCore
Fix many <video> regression tests on Windows
Reviewed by Dave Hyatt.
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::getNaturalSize): Call GetMovieNaturalBoundsRect, which returns the movie's natural bounds (duh), rather than GetMovieBox, which returns the movie's current displayed size/position.
- 8:05 PM Changeset in webkit [42305] by
-
- 2 edits in trunk/WebKitTools
Remove the layout-test-results directory after we have archived it so that
log files and results are reset between runs of the tests.
- BuildSlaveSupport/test-result-archive:
- 7:09 PM Changeset in webkit [42304] by
-
- 1 edit6 adds in trunk/LayoutTests
Check in files that were forgotten in r42293
- platform/win/http/tests/xmlhttprequest/web-apps/012-expected.txt:
- platform/win/http/tests/xmlhttprequest/web-apps/013-expected.txt:
- 6:00 PM Changeset in webkit [42303] by
-
- 3 edits in trunk/LayoutTests
2009-04-07 Brady Eidson <beidson@apple.com>
Update layout test results for new exceptions.
- fast/dom/Window/window-properties-expected.txt:
- platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
- 5:26 PM Changeset in webkit [42302] by
-
- 6 edits4 adds in trunk
WebCore:
2009-04-07 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler and Sam Weinig
<rdar://problem/5968249> "Private Browsing" doesn't affect HTML 5 LocalStorage
The expected behavior for persistent storage when private browsing mode is undefined by the spec.
For now we're going with a "read-only when in private browsing" policy until we can get feedback
and/or get the behavior specified in the spec.
Note that I purposefully made the change to restrict SessionStorage to read-only, also, with the
understanding that the spec allows for SessionStorage to persist across relaunches, even though
our implementation currently doesn't do this.
- dom/DOMCoreException.idl: Add some new ExceptionCodes defined in HTML5, one of which is needed for LocalStorage changes (QUOTA_EXCEEDED_ERR)
- dom/ExceptionCode.cpp:
- dom/ExceptionCode.h:
- storage/StorageArea.cpp: (WebCore::StorageArea::internalSetItem): If private browsing is enabled, throw the QUOTA_EXCEEDED_ERR exception as the spec allows. (WebCore::StorageArea::internalRemoveItem): If private browsing is enabled, silently fail to remove the item. (WebCore::StorageArea::internalClear): If private browsing is enabled, silently fail to clear the area.
LayoutTests:
2009-04-07 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
Tests for <rdar://problem/5968249> "Private Browsing" doesn't affect HTML 5 LocalStorage
- storage/domstorage/localstorage/private-browsing-affects-storage-expected.txt: Added.
- storage/domstorage/localstorage/private-browsing-affects-storage.html: Added.
- storage/domstorage/sessionstorage/private-browsing-affects-storage-expected.txt: Added.
- storage/domstorage/sessionstorage/private-browsing-affects-storage.html: Added.
- 5:18 PM Changeset in webkit [42301] by
-
- 8 edits in trunk/WebCore
2009-04-07 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/6148255>
Standalone media documents can not always handle everything
using a <video> element. In these cases switch to an <embed>
element that uses the QuickTime plugin, in the hope that it
will have more luck. Typical media types that trigger this
are streamed media and QTVR.
Equivalent Windows fix to come once reviewed. Note also that
this area of code needs a cleanup:
https://bugs.webkit.org/show_bug.cgi?id=25085
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks):
- html/HTMLMediaElement.h:
- loader/MediaDocument.cpp: (WebCore::MediaDocument::mediaElementSawUnsupportedTracks): (WebCore::MediaDocument::replaceVideoWithEmbed):
- loader/MediaDocument.h:
- removes the <video> element and puts in an <embed>
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerSawUnsupportedTracks):
- new internal method for flagging a problem
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::updateStates):
- looks for the types of content we don't handle
(WebCore::MediaPlayerPrivate::rateChanged):
(WebCore::MediaPlayerPrivate::sizeChanged):
(WebCore::MediaPlayerPrivate::timeChanged):
(WebCore::MediaPlayerPrivate::didEnd):
(WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
(WebCore::MediaPlayerPrivate::sawUnsupportedTracks):
- inform the MediaClient that we have a potential problem
- 5:00 PM Changeset in webkit [42300] by
-
- 4 edits in trunk/WebKit/mac
2009-04-07 Anders Carlsson <andersca@apple.com>
Fix Tiger build for real this time.
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView getVariable:forURL:value:length:]): (-[WebNetscapePluginView setVariable:forURL:value:length:]): (-[WebNetscapePluginView getAuthenticationInfoWithProtocol:host:port:scheme:realm:username:usernameLength:password:passwordLength:]):
- Plugins/npapi.mm: (NPN_GetValueForURL): (NPN_SetValueForURL):
- 4:59 PM Changeset in webkit [42299] by
-
- 1 edit1 copy in trunk/WebKitTools
Helper script for uploading layout test results for display on build.webkit.org.
- BuildSlaveSupport/test-result-archive: Copied from WebKitTools/BuildSlaveSupport/built-product-archive.
- 4:38 PM Changeset in webkit [42298] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix <rdar://problem/6767428> Resurrect +[WebFontCache fontWithFamily:traits:size:] for clients that call it directly
WebFontCache is a class in the WebCore framework and is not WebKit API,
but apparently (perhaps mistakenly) some clients call this private
interface.
This change resurrects the interface and gives it reasonable behavior
(however, note that WebCore will not call the old interface, so hacks that
override it will have no effect on WebKit clients).
- platform/mac/WebFontCache.h:
- platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]): Added. Call through to +fontWithFamily:traits:weight:size:.
- 4:09 PM Changeset in webkit [42297] by
-
- 20 edits in trunk
WebCore:
2009-04-07 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben
Fix ScrollView's algorithm that determines whether or not to show scrollbars. There was a bug
with the method mainly because RenderView will size itself to the viewport's size, making it
impossible to really know the document's "true" size.
In order to solve this problem ScrollView now has a minimumContentsSize method. This method
returns the document size excluding the RenderView from the calculation. This width/height
is now cached on RenderView in m_docWidth/m_docHeight member variables.
- WebCore.base.exp:
- page/FrameView.cpp: (WebCore::FrameView::adjustPageHeight): (WebCore::FrameView::minimumContentsSize):
- page/FrameView.h:
- platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):
- platform/ScrollView.h: (WebCore::ScrollView::minimumContentsSize):
- rendering/RenderView.cpp: (WebCore::RenderView::layout): (WebCore::RenderView::calcDocHeight): (WebCore::RenderView::calcDocWidth):
- rendering/RenderView.h: (WebCore::RenderView::docWidth): (WebCore::RenderView::docHeight):
WebKit/mac:
2009-04-07 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben
Mac portion of fix to make DumpRenderTree always produce accurate scrollbar results. Change
updateScrollers to call minimumContentsSize when a WebHTMLView is inside the WebDynamicScrollbarsView.
- WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
LayoutTests:
2009-04-07 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben
Land updated layout test results now that DRT is doing the right thing
with scrollbar results.
- platform/mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum:
- platform/mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
- platform/mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.txt:
- platform/mac/css2.1/t0803-c5505-mrgn-02-c-expected.checksum:
- platform/mac/css2.1/t0803-c5505-mrgn-02-c-expected.png:
- platform/mac/css2.1/t0803-c5505-mrgn-02-c-expected.txt:
- platform/mac/fast/block/float/013-expected.checksum:
- platform/mac/fast/block/float/013-expected.png:
- platform/mac/fast/block/float/013-expected.txt:
- 3:56 PM Changeset in webkit [42296] by
-
- 2 edits in trunk/WebCore
2009-04-07 Dimitri Glazkov <Dimitri Glazkov>
Build fix, not reviewed.
- WebCore.xcodeproj/project.pbxproj: Made ScriptObject.h private.
- 3:37 PM Changeset in webkit [42295] by
-
- 15 edits1 copy in trunk/WebCore
2009-04-07 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=25063
Refactor InspectorController to use ScriptObject/State.
- GNUmakefile.am: Added ScriptState.cpp.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- WebCoreSources.bkl: Ditto.
- bindings/js/JSInspectorControllerCustom.cpp: (WebCore::JSInspectorController::addSourceToFrame): Fixed argument index typo.
- bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call): Added reportExceptions parameter. (WebCore::ScriptFunctionCall::construct): Ditto.
- bindings/js/ScriptFunctionCall.h: Ditto.
- bindings/js/ScriptObject.cpp: (WebCore::handleException): Added exception-reporting heloper. (WebCore::ScriptObject::set): Changed to use handleException. (WebCore::ScriptGlobalObject::set): Ditto,
- bindings/js/ScriptObject.cpp: Added ScriptGlobalObject. (WebCore::ScriptGlobalObject::set): Added. (WebCore::ScriptGlobalObject::getObject): Added.
- bindings/js/ScriptObject.h: Added ScriptGlobalObject decls. (WebCore::ScriptGlobalObject::ScriptGlobalObject): Added.
- bindings/js/ScriptState.cpp: Added.
- bindings/js/ScriptState.h: Added scriptStateFromPage decl.
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole): Changed to not report exceptions
to avoid re-entrancy.
- inspector/InspectorController.cpp: Refactored to use ScriptState/Object.
- inspector/InspectorController.h: Ditto.
- 3:30 PM Changeset in webkit [42294] by
-
- 2 edits in trunk/WebCore
2009-04-07 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
Skia was previously calculating the leading value incorrectly, leading
us to add fHeight to get the height of a line of text. Now that Skia
is calculating fLeading correctly, we can remove fHeight.
This doesn't affect any layout tests.
- platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit):
- 3:27 PM Changeset in webkit [42293] by
-
- 4 edits in trunk
WebCore:
2009-04-07 Brian Weinstein <bweinstein@gmail.com>
Reviewed by Darin Adler.
This fix removes the status code from the status message in a ResourceResponse, which allows a few more tests in http to pass.
- platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
LayoutTests:
2009-04-07 Brian Weinstein <bweinstein@gmail.com>
Reviewed by Darin Adler.
Tests in http/tests/xmlhttprequest/web-apps were taking results from
platform/mac instead of LayoutTests, so added the values from LayoutTests
into platform/win, and removed a few tests from the skip list that are fixed
by the fix to platform/network/cf/ResourceResponseCFNet.cpp
- platform/win/Skipped:
- platform/win/http: Added.
- platform/win/http/tests: Added.
- platform/win/http/tests/xmlhttprequest: Added.
- platform/win/http/tests/xmlhttprequest/web-apps: Added.
- platform/win/http/tests/xmlhttprequest/web-apps/012-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/web-apps/012-expected.txt.
- platform/win/http/tests/xmlhttprequest/web-apps/013-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/web-apps/013-expected.txt.
- 3:23 PM Changeset in webkit [42292] by
-
- 2 edits in trunk/WebKitTools
2009-04-11 Brian Weinstein <bweinstein@gmail.com>
Reviewed by Darin Adler.
Allows timeout to be set in run-webkit-tests as a command line argument.
- Scripts/run-webkit-tests:
- 3:06 PM Changeset in webkit [42291] by
-
- 5 edits in trunk/WebCore
2009-04-07 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Clean up repaint logic when RenderLayers become and stop being composited.
- rendering/RenderLayer.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::rendererContentChanged): (WebCore::RenderLayer::repaintIncludingNonCompositingDescendants): New compositing-only method that repaints a layer and all its non-composited descendants. Takes a repaintContainer for performance; all the repaints necessarily share the same repaintContainer.
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateLayerCompositingState): Rather than use calculateCompositedBounds() to compute the repaint rect (which gave the wrong answer when the composited layer tree was in flux), use the new repaintOnCompositingChange() method.
(WebCore::RenderLayerCompositor::repaintOnCompositingChange):
Call repaintIncludingNonCompositingDescendants(), and if necessary make sure
that the view/layer drawing synchronization happens.
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
Do a repaintOnCompositingChange() when a layer is going to be composited. This is
a good place because we haven't started to change the compositing tree.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
After we've finished updating all the descendant layers, we can do a repaint for
layers that ceased compositing.
- 3:04 PM Changeset in webkit [42290] by
-
- 2 edits in trunk/WebCore
2009-04-07 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
Skia is changing from reporting the XRange to reporting the XMin and
XMax. Obviously these are equivalent, but other users of the metrics
need the two numbers to be separate.
This doesn't affect any layout tests.
- platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit):
- 2:53 PM Changeset in webkit [42289] by
-
- 2 edits in trunk/WebCore
Make the look of <select>s match the system look on Vista
Reviewed by Dave Hyatt.
- rendering/RenderThemeWin.cpp: Added new constants. (WebCore::RenderThemeWin::getThemeData): On Vista, use the CP_DROPDOWNBUTTONRIGHT part for drop down buttons. (WebCore::RenderThemeWin::paintMenuList): On Vista, use the CP_BORDER part to draw the border of <select>s. (WebCore::RenderThemeWin::paintMenuListButton): On Vista, outset the drop down button to make its border coincide with the <select>'s border.
- 2:53 PM Changeset in webkit [42288] by
-
- 3 edits2 adds in trunk/WebCore
Move isRunningOnVistaOrLater to a shared location
Rubber-stamped in advance by Dave Hyatt.
- WebCore.vcproj/WebCore.vcproj: Added SystemInfo.{cpp,h}, and let VS have its way with the rest of the file.
- platform/win/ScrollbarThemeWin.cpp: Moved isRunningOnVistaOrLater from here...
- platform/win/SystemInfo.cpp: Added. (WebCore::isRunningOnVistaOrLater): ...to here.
- platform/win/SystemInfo.h: Added.
- 2:42 PM Changeset in webkit [42287] by
-
- 4 edits in trunk/WebCore
2009-04-07 Paul Godavari <paul@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=24692
Enable PopupMenuChromium to handle HTML select popups using native
cocoa controls on the Mac, all other platforms are unchanged.
We also split out the storage container for the popup menu items
so that ChromeClientChromium can access them for forwarding to
the embedding host (Chromium.app or test_shell).
- page/chromium/ChromeClientChromium.h:
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::items): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::~PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::showExternal): (WebCore::PopupContainer::menuItemHeight): (WebCore::popupData): (WebCore::PopupListBox::pointToRowIndex): (WebCore::PopupListBox::getRowBounds): (WebCore::PopupListBox::isSelectableItem): (WebCore::PopupListBox::updateFromElement): (WebCore::PopupListBox::layout): (WebCore::PopupListBox::clear): (WebCore::PopupMenu::show):
- platform/chromium/PopupMenuChromium.h: (WebCore::PopupItem::): (WebCore::PopupItem::PopupItem):
- 2:28 PM Changeset in webkit [42286] by
-
- 13 edits in trunk/WebCore
2009-04-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Added some double-checking to event handler marking. Now, when the
wrapper that's responsible for marking an event handler's JavaScript
function gets collected, it clears the event handler's JavaScript function
so we won't dereference it after it's collected.
In theory, we would never dereference a JavaScript event handler after
its node's wrapper was collected anyway, but it's nice to be safe.
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::mark):
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::jsFunction): (WebCore::JSEventListener::invalidateJSFunction): (WebCore::JSEventListener::markJSFunction):
- bindings/js/JSEventListener.h:
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):
- bindings/js/JSNodeCustom.cpp: (WebCore::markEventListeners):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark):
- bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::mark):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::mark):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::mark):
- bindings/scripts/CodeGeneratorJS.pm:
- dom/EventListener.h: (WebCore::EventListener::invalidateJSFunction): (WebCore::EventListener::markJSFunction): (WebCore::markIfNotNull):
- 2:27 PM Changeset in webkit [42285] by
-
- 3 edits in trunk/WebKit/mac
2009-04-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Anders Carlsson.
Trying to fix Tiger build.
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView getAuthenticationInfoWithProtocol:host:port:scheme:realm:username:usernameLength:password:passwordLength:]):
- 2:19 PM Changeset in webkit [42284] by
-
- 6 edits in trunk/WebKit
WebKit:
2009-04-07 Anders Carlsson <andersca@apple.com>
Try to fix the Leopard build once more.
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2009-04-07 Anders Carlsson <andersca@apple.com>
Try to fix the Leopard build once more.
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm:
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView getVariable:forURL:value:length:]):
- 2:15 PM Changeset in webkit [42283] by
-
- 2 edits in trunk/WebCore
2009-04-07 David Levin <levin@chromium.org>
Build fix.
r44280 undid the change in r42268 that made CookieJar.h private.
This redoes the change.
- WebCore.xcodeproj/project.pbxproj:
- 2:15 PM Changeset in webkit [42282] by
-
- 4 edits in trunk/JavaScriptCore
2009-04-07 David Levin <levin@chromium.org>
Reviewed by Sam Weinig and Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=25039
UString refactoring to support UChar* sharing.
No change in sunspider perf.
- runtime/SmallStrings.cpp: (JSC::SmallStringsStorage::SmallStringsStorage):
- runtime/UString.cpp: (JSC::initializeStaticBaseString): (JSC::initializeUString): (JSC::UString::BaseString::isShared): Encapsulate the meaning behind the refcount == 1 checks because this needs to do slightly more when sharing is added. (JSC::concatenate): (JSC::UString::append): (JSC::UString::operator=):
- runtime/UString.h: Make m_baseString part of a union to get rid of casts, but make it protected because it is tricky to use it correctly since it is only valid when the Rep is not a BaseString. The void* will be filled in when sharing is added.
Add constructors due to the making members protected and it make ensuring proper
initialization work better (like in SmallStringsStorage).
(JSC::UString::Rep::create):
(JSC::UString::Rep::Rep):
(JSC::UString::Rep::):
(JSC::UString::BaseString::BaseString):
(JSC::UString::Rep::setBaseString):
(JSC::UString::Rep::baseString):
- 2:15 PM Changeset in webkit [42281] by
-
- 2 edits in trunk/WebCore
2009-04-07 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
Upstream changes to WorkerContextExecutionProxy for enabling V8 preemption.
https://bugs.webkit.org/show_bug.cgi?id=25034
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::evaluate):
- 1:03 PM Changeset in webkit [42280] by
-
- 4 edits2 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/6764359> Thai word selection misbehaves for the last sentence in the document
Test: editing/selection/thai-word-at-document-end.html
- editing/visible_units.cpp:
- Added a BoundarySearchContextAvailability enum used to indicate whether the caller to a boundary search function may be able to provide additional text in the search direction and call again.
- Added a named type for the boundary search function signature. Changed the signature to take a context availability parameter and a boolean out parameter indicating whether more context is needed to perform the search.
(WebCore::previousBoundary): If the beginning of the range was reached
but the last search wanted more context, perform the search again, this
time indicating that there is no earlier text.
(WebCore::nextBoundary): Similarly, in the other direction.
(WebCore::startWordBoundary): Check whether more context may be available
and ask for more context if needed.
(WebCore::endWordBoundary): Ditto.
(WebCore::previousWordPositionBoundary): Ditto.
(WebCore::nextWordPositionBoundary): Ditto.
(WebCore::startSentenceBoundary): Updated signature.
(WebCore::endSentenceBoundary): Ditto.
(WebCore::previousSentencePositionBoundary): Ditto.
(WebCore::nextSentencePositionBoundary): Ditto.
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/6764359> Thai word selection misbehaves for the last sentence in the document
- editing/selection/thai-word-at-document-end-expected.txt: Added.
- editing/selection/thai-word-at-document-end.html: Added.
- 12:51 PM Changeset in webkit [42279] by
-
- 7 edits in trunk/WebCore
2009-04-07 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Sam Weinig.
A little renaming:
function => jsFunction
listener => jsFunction
- bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener): (WebCore::JSEventListener::jsFunction): (WebCore::JSEventListener::mark): (WebCore::JSProtectedEventListener::JSProtectedEventListener): (WebCore::JSProtectedEventListener::~JSProtectedEventListener): (WebCore::JSProtectedEventListener::jsFunction):
- bindings/js/JSEventListener.h: (WebCore::JSProtectedEventListener::create):
- bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::jsFunction): (WebCore::JSLazyEventListener::parseCode):
- dom/EventListener.h: (WebCore::EventListener::jsFunction):
- 12:49 PM Changeset in webkit [42278] by
-
- 2 edits in trunk/WebKit/mac
2009-04-07 Anders Carlsson <andersca@apple.com>
...and try to fix the Leopard build.
- Plugins/npapi.mm: (NPN_GetAuthenticationInfo):
- 12:47 PM Changeset in webkit [42277] by
-
- 3 edits in trunk/WebCore
2009-04-07 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
While working on <rdar://problem/5968249>, noticed some glaring problems with LocalStorage.
- page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage): Return the cached m_localStorage object if it exists to avoid creating multiple representations for the same underlying StorageArea.
- page/DOMWindow.h: (WebCore::DOMWindow::optionalLocalStorage): Return m_localStorage, not m_sessionStorage.
- 12:38 PM Changeset in webkit [42276] by
-
- 2 edits in trunk/WebCore
2009-04-07 Darin Adler <Darin Adler>
Roll out incorrect build fix.
- WebCore.NPAPI.exp: Reverted.
- 12:33 PM Changeset in webkit [42275] by
-
- 2 edits in trunk/WebCore
2009-04-07 Darin Adler <Darin Adler>
Another build fix.
- WebCore.NPAPI.exp: Added new functions.
- 12:14 PM Changeset in webkit [42274] by
-
- 2 edits in trunk/WebCore
2009-04-07 Anders Carlsson <andersca@apple.com>
Another build fix.
- plugins/npfunctions.h:
- 11:28 AM Changeset in webkit [42273] by
-
- 2 edits in trunk/WebCore
2009-04-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed build fix. Fix non-Mac builds.
- bridge/npapi.h:
- 10:57 AM Changeset in webkit [42272] by
-
- 2 edits in trunk/WebKit/mac
2009-04-07 Anders Carlsson <andersca@apple.com>
Try to fix the Tiger build.
- Plugins/WebBaseNetscapePluginView.mm:
- 10:45 AM Changeset in webkit [42271] by
-
- 8 edits in trunk/WebCore
2009-04-07 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Clean up the accelerated compositing code that determines the format of
the GraphicsLayer hierarchy, being more explicit about which parts have
to happen before and after descendant layers have been updated. Also remove
some unhelpful caching of state.
- dom/Document.cpp: (WebCore::Document::recalcStyle): Only call updateCompositingLayers() if we know we're not going to be doing a layout soon.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setDrawsContent): Toggling drawsContent from false to true should do a setNeedsDisplay().
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::styleChanged): updateLayerCompositingState() no longer updates the layer geometry, so do that here if we're not going to rebuild layers anyway. Also, updateLayerCompositingState() no longer does a setContentsNeedDisplay, so do that if the style change indicates that a repaint is required.
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::updateAfterLayout): The 'drawing optimizations' logic has been rolled into updateGraphicsLayerConfiguration() and updateGraphicsLayerGeometry().
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
Group that code that decides what GraphicsLayers are needed into this method,
which deals with clipping layers and 'direct compositing': images that can be
rendered via the compositor.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
Call setDrawsContent() if updateGraphicsLayerConfiguration() didn't already
figure it out for image layers.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
Remove the m_simpleCompositingLayerStatusDirty cache indicator, since we just
computed it every time anyway.
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateLayerCompositingState): updateGraphicsLayers() was renamed to updateGraphicsLayerConfiguration(), which calls clippedByAncestor() etc. itself rather than having everything passed in. Repaints are taken care of by styleChanged() and setDrawsContent().
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
!layer->isComposited() && layer->transform() is a synonym for paintsWithTransform().
(WebCore::RenderLayerCompositor::setCompositingParent):
No need to call updateGraphicsLayerGeometry() here, because we're going to
rebuild layers anyway.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
Add comments, and test layerBacking instead of layer->isComposited().
- 10:41 AM Changeset in webkit [42270] by
-
- 2 edits in trunk/WebKit
2009-04-07 Anders Carlsson <andersca@apple.com>
Another attempt at fixing the build.
- WebKit.xcodeproj/project.pbxproj:
- 10:33 AM Changeset in webkit [42269] by
-
- 2 edits in trunk/WebCore
2009-04-07 Anders Carlsson <andersca@apple.com>
Fix build.
- WebCore.base.exp:
- 10:22 AM Changeset in webkit [42268] by
-
- 16 edits in trunk
WebCore:
2009-04-07 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/6667001> NPAPI: need NPN_Get/SetValueForURL() and NPN_GetAuthenticationInfo()
- WebCore.base.exp: Add symbols needed by WebKit.
- WebCore.xcodeproj/project.pbxproj: Make CookieJar a private header.
- bridge/npapi.h: Add function definitions.
- plugins/npfunctions.h: Fix the NPN_SetValueForURLProcPtr signature.
WebKit/mac:
2009-04-07 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/6667001>
NPAPI: need NPN_Get/SetValueForURL() and NPN_GetAuthenticationInfo()
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetCookies): (WKPCGetProxy): (WKPCSetCookies): (WKPCGetAuthenticationInfo): New MIG functions to be used by the plug-in host.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::getCookies): (WebKit::NetscapePluginInstanceProxy::setCookies): (WebKit::NetscapePluginInstanceProxy::getProxy): (WebKit::NetscapePluginInstanceProxy::getAuthenticationInfo): Implement these.
- Plugins/Hosted/WebKitPluginClient.defs: Add callbacks.
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView URLWithCString:]): Factor this out of URLWithCString.
(-[WebBaseNetscapePluginView requestWithURLCString:]):
Call URLWithCString.
(WebKit::proxiesForURL):
Return a string representation of proxies for a given URL.
(WebKit::getAuthenticationInfo):
Get the authentication info for a given host/protocol/scheme/realm/port combination.
- Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _tryLoad]): Initialize the new vtable functions.
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView getVariable:forURL:value:length:]): (-[WebNetscapePluginView setVariable:forURL:value:length:]): (-[WebNetscapePluginView getAuthenticationInfoWithProtocol:host:port:scheme:realm:username:usernameLength:password:passwordLength:]): Implement these.
- Plugins/npapi.mm: (NPN_GetValueForURL): (NPN_SetValueForURL): (NPN_GetAuthenticationInfo): Call the plug-in view functions.
- 10:13 AM Changeset in webkit [42267] by
-
- 2 edits in trunk/WebCore
Fix <rdar://6520933> REGRESSION (3.2.1-ToT): Scroll bar disappears in WebView and Bookmarks view after switching theme or turning on High Contrast mode
Reviewed by Dave Hyatt.
- platform/win/ScrollbarThemeWin.cpp: (WebCore::ScrollbarThemeWin::themeChanged): Null out scrollbarTheme after closing it so that we'll re-open the theme next time we paint.
- 10:12 AM Changeset in webkit [42266] by
-
- 2 edits in trunk/WebCore
Small cleanup/correctness fix in ScrollbarThemeWin
Reviewed by Dave Hyatt.
- platform/win/ScrollbarThemeWin.cpp: Removed the now-unused haveTheme boolean. (WebCore::checkAndInitScrollbarTheme): Check IsThemeActive() before calling OpenThemeData. This seems to be what MSDN recommends. (WebCore::ScrollbarThemeWin::themeChanged): Null-check scrollbarTheme before closing it, rather than indirectly null-checking it via checking haveTheme.
- 10:08 AM Changeset in webkit [42265] by
-
- 6 edits2 adds in trunk
WebCore:
Reviewed by John Sullivan.
- when -webkit-line-break: after-white-space is specified but the text does not auto-wrap, do not shrink the trailing space to fit in the available width
Test: fast/text/whitespace/nowrap-line-break-after-white-space.html
- when shrinking such trailing space, do not shrink below zero
Covered by existing tests
- rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren):
LayoutTests:
Reviewed by John Sullivan.
- test that when -webkit-line-break: after-white-space is combined with white-space: nowrap, the trailing space is not shrunk to fit the in the available width
- updates results for that and for not shrinking trailing space to less than zero
- fast/text/whitespace/nowrap-line-break-after-white-space-expected.txt: Added.
- fast/text/whitespace/nowrap-line-break-after-white-space.html: Added.
- platform/mac/fast/block/float/editable-text-overlapping-float-expected.txt:
- platform/mac/fast/inline/long-wrapped-line-expected.txt:
- platform/mac/fast/text/whitespace/tab-character-basics-expected.txt:
- 7:25 AM Changeset in webkit [42264] by
-
- 5 edits in trunk/WebCore
Reviewed by Darin Adler.
Move RangeBoundaryPoint off of Position, per Darin's suggestion
https://bugs.webkit.org/show_bug.cgi?id=24966
Rename setToChild to setToBeforeChild (since that's what the method does)
- dom/Position.h: (WebCore::Position::offsetInContainerNode):
- dom/Range.cpp: (WebCore::Range::insertNode): (WebCore::Range::selectNodeContents): (WebCore::boundaryNodeWillBeRemoved):
- dom/Range.h: (WebCore::Range::startPosition): (WebCore::Range::endPosition):
- dom/RangeBoundaryPoint.h: (WebCore::RangeBoundaryPoint::RangeBoundaryPoint): (WebCore::RangeBoundaryPoint::container): (WebCore::RangeBoundaryPoint::childBefore): (WebCore::RangeBoundaryPoint::position): (WebCore::RangeBoundaryPoint::offset): (WebCore::RangeBoundaryPoint::clear): (WebCore::RangeBoundaryPoint::set): (WebCore::RangeBoundaryPoint::setOffset): (WebCore::RangeBoundaryPoint::setToBeforeChild): (WebCore::RangeBoundaryPoint::setToStartOfNode): (WebCore::RangeBoundaryPoint::setToEndOfNode): (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved): (WebCore::RangeBoundaryPoint::invalidateOffset):
- 7:25 AM Changeset in webkit [42263] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
Add containerNode(), computeOffsetInContainerNode(),
computeNodeBeforePosition() and computeNodeAfterPosition().
https://bugs.webkit.org/show_bug.cgi?id=24763
These functions will replace uses of rangeCompliantPosition()
in future patches.
No changes in behavior, thus no tests.
- dom/Position.cpp: (WebCore::Position::containerNode): (WebCore::Position::computeOffsetInContainerNode): (WebCore::Position::computeNodeBeforePosition): (WebCore::Position::computeNodeAfterPosition): (WebCore::Position::anchorType):
- dom/Position.h: (WebCore::Position::):
- 4:48 AM Changeset in webkit [42262] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-04 Xan Lopez <xlopez@igalia.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=25033
dtoa.cpp segfaults with g++ 4.4.0
g++ 4.4.0 seems to be more strict about aliasing rules, so it
produces incorrect code if dtoa.cpp is compiled with
-fstrict-aliasing (it also emits a ton of warnings, so fair enough
I guess). The problem was that we were only casting variables to
union types in order to do type punning, but GCC and the C
standard require that we actually use a union to store the value.
This patch does just that, the code is mostly copied from the dtoa
version in GCC:
http://gcc.gnu.org/viewcvs/trunk/libjava/classpath/native/fdlibm/dtoa.c?view=markup.
- wtf/dtoa.cpp: (WTF::ulp): (WTF::b2d): (WTF::ratio): (WTF::hexnan): (WTF::strtod): (WTF::dtoa):
Apr 6, 2009:
- 4:43 PM Changeset in webkit [42261] by
-
- 5 edits in trunk/WebCore
2009-04-06 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Bottleneck dispatching mutation events in a new dispatchMutationEvent
function.
- dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
- dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
- dom/Node.cpp: (WebCore::Node::dispatchSubtreeModifiedEvent): (WebCore::Node::dispatchMutationEvent):
- dom/Node.h:
- 4:11 PM Changeset in webkit [42260] by
-
- 9 edits in trunk/WebCore
2009-04-06 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=25059
Remove references to dominantScript, getGenericFontForScript.
- platform/graphics/chromium/FontCacheChromiumWin.cpp: Removed references
to getGenericFontForScript.
(WebCore::FontCache::getLastResortFallbackFont): Removed calls to dominantScript.
- platform/graphics/chromium/FontCacheLinux.cpp: Ditto.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::defaultGUIFont): Removed Document* arg. (WebCore::RenderThemeChromiumLinux::systemFont): Ditto.
- rendering/RenderThemeChromiumLinux.h: Ditto.
- rendering/RenderThemeChromiumMac.h: Ditto.
- rendering/RenderThemeChromiumMac.mm: Ditto. (WebCore::RenderThemeChromiumMac::systemFont): Ditto.
- rendering/RenderThemeChromiumWin.cpp: (WebCore::defaultGUIFont): Ditto. (WebCore::RenderThemeChromiumWin::systemFont): Ditto.
- rendering/RenderThemeChromiumWin.h: Ditto.
- 4:04 PM Changeset in webkit [42259] by
-
- 4 edits in trunk
Versioning.
- 4:02 PM Changeset in webkit [42258] by
-
- 1 copy in tags/Safari-6530.5
New tag.
- 3:42 PM Changeset in webkit [42257] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2009-04-06 Christian Dywan <christian@twotoasts.de>
Rubber-stamped by Oliver Hunt.
- de.po: Added German translation for WebKitGTK+.
- 2:56 PM Changeset in webkit [42256] by
-
- 4 edits in trunk/WebCore
2009-04-06 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Fixed https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions
The problem was that a protected event listener's scope chain would end
up with a reference to the Node protecting it, causing a cycle. The
solution is to stop protecting event listeners and rely on marking instead.
This patch converts most Node event listeners to use marking instead of
GC protection.
- bindings/js/JSDOMBinding.cpp: (WebCore::isObservableThroughDOM): (WebCore::markDOMNodesForDocument): Refactored the test for whether a Node needs marking, and added a case for marking the node in order to mark its event listeners.
- bindings/js/JSNodeCustom.cpp: (WebCore::markEventListeners): (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener): (WebCore::JSNode::mark): Added code to mark a Node's event listeners when marking the Node. Changed code using protected event listeners to use event listeners.
- dom/Node.idl: Changed code using protected event listeners to use event listeners.
- 1:58 PM Changeset in webkit [42255] by
-
- 3 edits in trunk/WebCore
2009-04-06 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Remove unchecked bool return values for some dispatch event functions.
- dom/Node.cpp: (WebCore::Node::dispatchSubtreeModifiedEvent): (WebCore::Node::dispatchUIEvent): (WebCore::Node::dispatchWebKitAnimationEvent): (WebCore::Node::dispatchWebKitTransitionEvent): (WebCore::Node::dispatchProgressEvent):
- dom/Node.h:
- 1:48 PM Changeset in webkit [42254] by
-
- 3 edits in trunk/WebCore
2009-04-06 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25058
Fix chromium build bustage caused by r42216
- bindings/scripts/CodeGeneratorJS.pm:
- page/DOMWindow.idl:
- 12:48 PM Changeset in webkit [42253] by
-
- 2 edits in trunk/LayoutTests
2009-04-06 Dimitri Glazkov <Dimitri Glazkov>
Not reviewed because it's stupidly obvious.
Correct the expected result by adding an extra line break.
- fast/dom/HTMLSelectElement/length-not-overridden-expected.txt: Added
an extra line.
- 12:39 PM Changeset in webkit [42252] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Sam Weinig.
- pt_BR.po: Added Brazilian Portuguese translation for WebKitGTK+.
- 12:39 PM Changeset in webkit [42251] by
-
- 12 edits6 adds in trunk
2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Sam Weinig.
Added rules to maintain the localization support. We cannot simply
use whatever gettextize gives us because our build system is
non-recursive.
- GNUmakefile.am:
- configure.ac:
WebCore/
2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=20575
No localization in WebKitGtk
- platform/gtk/FileChooserGtk.cpp: Remove usage of glib/gi18n.h, since there are not translatable strings.
- platform/gtk/LocalizedStringsGtk.cpp: Use the glib i18n header that is specific for libraries.
WebKit/gtk/
2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=20575
No localization in WebKitGtk
Implemented localization support for WebKitGTK+.
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/ContextMenuClientGtk.cpp:
- po/POTFILES: Added.
- po/README: Added.
- po/webkit.pot: Added.
- webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_class_init):
- webkit/webkitprivate.cpp: (webkit_init):
- webkit/webkitwebframe.cpp:
WebKit/gtk/po/
2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Sam Weinig.
- GNUmakefile.am, POTFILES, webkit.pot: Initial setup of the localization infra-structure.
- 11:41 AM Changeset in webkit [42250] by
-
- 2 edits in trunk/WebCore
Revert r42249 to fix the build.
- 11:23 AM Changeset in webkit [42249] by
-
- 2 edits in trunk/WebCore
2009-04-06 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25058
Fix chromium build bustage caused by r42216
- page/DOMWindow.idl:
- 11:08 AM Changeset in webkit [42248] by
-
- 3 edits in trunk/WebCore
2009-04-06 Mike Belshe <mike@belshe.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=24978
Use custom implementations of a few Node methods so that
we don't over-aggressively create JS wrappers here.
- bindings/v8/custom/V8NodeCustom.cpp: Added custom implementations.
- dom/Node.idl: Removed JSC-specifier, making impl custom for V8 as well.
- 11:01 AM Changeset in webkit [42247] by
-
- 3 edits2 adds in trunk
WebCore:
2009-04-06 Dave Moore <davemoore@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25031
Make the V8 element collections check for named properties *before*
checking if there are any elements with the same name. Otherwise
it is both incorrect and slow.
Test: fast/dom/HTMLSelectElement/length-not-overridden.html
Both of these interceptors were attempting to find an element in the
collection that had a name or id of the property name before checking
for a JS property with that name.
- bindings/v8/V8Collection.h: (WebCore::collectionNamedPropertyGetter): (WebCore::nodeCollectionNamedPropertyGetter):
LayoutTests:
2009-04-06 Dave Moore <davemoore@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25031
Test for ensuring that named elements don't override properties on collections
- fast/dom/HTMLSelectElement/length-not-overridden-expected.txt: Added.
- fast/dom/HTMLSelectElement/length-not-overridden.html: Added.
- 10:51 AM Changeset in webkit [42246] by
-
- 5 edits4 adds in trunk
2009-04-06 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Pull the call to updateGraphicsLayerGeometry() out of updateGraphicsLayers(),
because we need to call it at the end of rebuildCompositingLayerTree() once
we've determined which descendant layers are composited, otherwise
calculateCompositedBounds() can give the wrong answer.
Now that updateLayerCompositingState() doesn't end up calling updateGraphicsLayerGeometry(),
call that explicitly from styleChanged(), if we know a layer update is not pending,
and similarly from updateAfterLayout().
Test: compositing/overflow/overflow-positioning.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::styleChanged):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout): (WebCore::RenderLayerBacking::updateGraphicsLayers): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
- 9:01 AM Changeset in webkit [42245] by
-
- 2 edits in trunk/WebCore
2009-04-06 Mike Belshe <mike@belshe.com>
Reviewed by Alexey Proskuryakov.
Add accessors to AtomicString which take String/const char* arguments
so that we don't accidentally thrash the AtomicString table.
- platform/text/AtomicString.h:
- 8:47 AM Changeset in webkit [42244] by
-
- 7 edits in trunk/WebKit/qt
2009-04-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Rename DOM API select function to findFirst, findAll, etc.
- 8:37 AM Changeset in webkit [42243] by
-
- 2 edits in trunk/WebKitTools
2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Tor Arne Vestbø.
Add /Programs to the productDir for GTK+, instead of adding
/JavaScriptCore, when running jsc.
- Scripts/run-sunspider:
- 7:17 AM Changeset in webkit [42242] by
-
- 2 edits in trunk/WebCore
[GTK+] Correct the column and row cursor
Make col and row work in WebCore/manual-tests/cursor.html. The issue
was spotted in the WebKit inspector.
- 5:59 AM Changeset in webkit [42241] by
-
- 2 edits in trunk/WebCore
2009-04-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Don't show and hide the platformPluginWidget, as it's our QWebView
- 5:50 AM QtWebKitContrib edited by
- (diff)
- 5:50 AM QtWebKitContrib edited by
- (diff)
- 5:49 AM QtWebKitContrib edited by
- (diff)
- 4:58 AM Changeset in webkit [42240] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-05 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25042
destroying webview widget directly causes crash.
Do not connect the WebView to its own screen-changed signal, set a
default handler instead.
- webkit/webkitwebview.cpp:
- 4:57 AM Changeset in webkit [42239] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-05 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25042
destroying webview widget directly causes crash.
GtkWidget::screen-changed can be emitted when a widget is being
destroyed, protect against it.
- webkit/webkitwebview.cpp:
- 4:25 AM Changeset in webkit [42238] by
-
- 9 edits5 adds in trunk
WebCore:
2009-04-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Add new files to the Qt build.
Export helper function from the Qt JSC binding, needed in WebKit/qt.
WebKit/qt:
2009-04-06 Simon Hausmann <simon.hausmann@nokia.com>
Ariya Hidayat <ariya.hidayat@nokia.com>
Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Genevieve Mak <gen@staikos.net>
Reviewed by Tor Arne Vestbø, Simon Hausmann
First revision of new API in the Qt port to access the DOM.
- 4:13 AM Changeset in webkit [42237] by
-
- 3 edits in trunk/WebCore
2009-04-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Changed ScriptFunctionCall's last argument from a const char* as the function name to a String.
Internally the function name is stored as a WebCore::String and the Qt port wants to use this
constructor programmatically where the function name is also a WebCore::String.
- 2:51 AM Changeset in webkit [42236] by
-
- 2 edits in trunk/WebCore
2009-04-06 Mike Belshe <mike@belshe.com>
Reviewed by Eric Seidel.
HTMLCanvasElement crash when ImageBuffer creation fails.
https://bugs.webkit.org/show_bug.cgi?id=23212
Check for NULL before using the ImageBuffer as we might
be low on memory and creation may have failed.
Test case creation blocked by:
https://bugs.webkit.org/show_bug.cgi?id=25055
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
Apr 5, 2009:
- 3:48 PM Changeset in webkit [42235] by
-
- 13 edits in trunk/WebCore
2009-04-05 Geoffrey Garen <ggaren@apple.com>
[Originally] Reviewed by Sam Weinig.
Rolled back in r42214 with crashes fixed.
[Removed irrelevant ExecState* parameter from event handler registration code.]
[No change in behavior.]
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener): (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener):
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
- bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/scripts/CodeGeneratorJS.pm:
- 10:26 AM Changeset in webkit [42234] by
-
- 2 edits in trunk/WebCore
2009-04-05 Erik L. Bunce <elbunce@xendom.com>
Reviewed by Simon Hausmann.
Fix an assert failure when dropping an 'empty' text/uri-list on a QWebView.
- 7:56 AM Changeset in webkit [42233] by
-
- 2 edits in trunk/WebCore
Fix the Qt build
- 1:21 AM Changeset in webkit [42232] by
-
- 2 edits in trunk
2009-04-05 Mike Hommey <glandium@debian.org>
Reviewed by Holger Freyther.
Filter out all C++ symbols
https://bugs.webkit.org/show_bug.cgi?id=24960
Considering the public API is all C, we can just filter out all
C++ mangled symbols, which will avoid exporting symbols in some
corner cases such as gcc bugs on specific architectures, etc.
- autotools/symbols.filter:
- 1:16 AM Changeset in webkit [42231] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-05 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=24487
Updated documentation and put more information about the
private-browsing setting for WebKitGtk.
- webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
Apr 4, 2009:
- 8:56 PM Changeset in webkit [42230] by
-
- 9 edits in trunk
Build fixes for wxMac/Tiger.
- 5:06 PM Changeset in webkit [42229] by
-
- 8 edits in trunk
wx build fixes for the Windows port.
- 1:25 PM Changeset in webkit [42228] by
-
- 2 edits in trunk/WebCore
2009-04-04 Simon Fraser <Simon Fraser>
Reviewed by Cameron Zwarich
Ensure that mapPoint(const IntPoint&) calls the FloatPoint
version to avoid infinite recursion.
No test because mapPoint(const IntPoint&) isn't ever called
on Mac, so I can't reproduce.
- platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::mapPoint):
- 12:33 AM Changeset in webkit [42227] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Mark Rowe.
- fix <rdar://problem/6757862> REGRESSION: Cannot use the mouse to place the insertion point inside a Thai character
Test: fast/text/international/thai-offsetForPosition-inside-character.html
- platform/graphics/mac/CoreTextController.cpp: (WebCore::CoreTextController::offsetForPosition): Changed to use cursorMovementIterator instead of characterBreakIterator, allowing this function to return a valid cursor position even if it is not at a character boundary.
LayoutTests:
Reviewed by Mark Rowe.
- test for <rdar://problem/6757862> REGRESSION: Cannot use the mouse to place the insertion point inside a Thai character
- fast/text/international/thai-offsetForPosition-inside-character-expected.txt: Added.
- fast/text/international/thai-offsetForPosition-inside-character.html: Added.
- 12:27 AM Changeset in webkit [42226] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Mark Rowe.
- fix an assertion failure when clicking at the beginning of a glyph cluster at the beginning of a text run
Test: fast/text/offsetForPosition-cluster-at-zero.html
- platform/graphics/mac/CoreTextController.cpp: (WebCore::CoreTextController::offsetForPosition): Corrected the bound check on firstGlyphBeforeCluster, letting it be 0 or -1, but not less than -1.
LayoutTests:
Reviewed by Mark Rowe.
- test for a bug where computing the text offset for a position at the beginning of a glyph cluster at the beginning of a Core Text run resulted in an attempt to read past the end of a vector
- fast/text/offsetForPosition-cluster-at-zero-expected.txt: Added.
- fast/text/offsetForPosition-cluster-at-zero.html: Added.
- 12:20 AM Changeset in webkit [42225] by
-
- 2 edits in trunk/LayoutTests
2009-04-04 Sam Weinig <sam@webkit.org>
Update test result.
- dom/xhtml/level2/html/HTMLFormElement10-expected.txt:
Apr 3, 2009:
- 6:06 PM Changeset in webkit [42224] by
-
- 2 edits in trunk/WebCore
Allows 16 HTML/CSS standard colors to be shown as swatch backgrounds
when the names are given.
Reviewed by Timothy Hatcher.
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
- 5:56 PM Changeset in webkit [42223] by
-
- 8 edits4 adds in trunk
WebCore:
2009-04-03 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
<rdar://problem/6330929>
https://bugs.webkit.org/show_bug.cgi?id=21456
Don't update the document pointer for all inactive windows on navigations.
This change causes us to differ slightly from Firefox when accessing the
document from within a closure tied to a navigated context, but as all
browsers differ on this edge case, I don't foresee compatibility issues.
Test: http/tests/security/cross-frame-access-document-direct.html
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::initScript): (WebCore::ScriptController::updateDocument):
- bindings/js/ScriptController.h:
LayoutTests:
2009-04-03 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Update tests for <rdar://problem/6330929>
https://bugs.webkit.org/show_bug.cgi?id=21456
- dom/xhtml/level2/html/HTMLFormElement10-expected.txt:
- fast/dom/Window/dom-access-from-closure-iframe-expected.txt:
- fast/dom/Window/dom-access-from-closure-window-expected.txt:
- http/tests/security/cross-frame-access-document-direct-expected.txt: Added.
- http/tests/security/cross-frame-access-document-direct.html: Added.
- http/tests/security/resources/cross-frame-iframe-for-document-direct-test-victim.html: Added.
- http/tests/security/resources/cross-frame-iframe-for-document-direct-test.html: Added.
- 5:49 PM Changeset in webkit [42222] by
-
- 4 edits2 adds in trunk
We were starting transitions with 0 duration and delay, which is
useless. With accelerated compositing on, this went through a code
path that tried to use m_toStyle, which never got set because the
transitions was short circuited before it had a chance to. So I
both protect against using that null pointer and avoid starting
the transition in the first place.
- 5:41 PM Changeset in webkit [42221] by
-
- 2 edits in trunk/WebCore
Fixes a bug where you could not type any more in the Web Inspector's
search field after the first match is selected in the Resources panel.
https://bugs.webkit.org/show_bug.cgi?id=23982
rdar://problem/6592367
Reviewed by Darin Adler.
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._jumpToSearchResult): Use the window object of the frame to set the selection, not the main window.
- 5:37 PM Changeset in webkit [42220] by
-
- 2 edits in trunk/WebKit/mac
2009-04-03 Kevin Decker <kdecker@apple.com>
Reviewed by Anders Carlsson.
<rdar://problem/6756512>
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost): Tweaked the visibleName property.
- 5:34 PM Changeset in webkit [42219] by
-
- 2 edits in trunk/WebKitTools
2009-04-03 Stephanie Lewis <Stephanie Lewis>
Reviewed by Mark Rowe.
Fix running DumpRenderTree with a root.
- Scripts/run-webkit-tests:
- 4:49 PM Changeset in webkit [42218] by
-
- 7 edits40 adds in trunk
WebCore:
2009-04-03 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix for https://bugs.webkit.org/show_bug.cgi?id=22081
<rdar://problem/6346030>
Don't allow overriding the return value of window.location.
Tests: fast/dom/Window/Location/location-override-toString-on-proto-using-defineGetter.html
fast/dom/Window/Location/location-override-toString-on-proto-using-with.html
fast/dom/Window/Location/location-override-toString-on-proto.html
fast/dom/Window/Location/location-override-toString-using-defineGetter.html
fast/dom/Window/Location/location-override-toString-using-with.html
fast/dom/Window/Location/location-override-toString.html
fast/dom/Window/Location/location-override-valueOf-on-proto-using-defineGetter.html
fast/dom/Window/Location/location-override-valueOf-on-proto-using-with.html
fast/dom/Window/Location/location-override-valueOf-on-proto.html
fast/dom/Window/Location/location-override-valueOf-using-defineGetter.html
fast/dom/Window/Location/location-override-valueOf-using-with.html
fast/dom/Window/Location/location-override-valueOf.html
fast/dom/Window/Location/window-override-location-using-defineGetter.html
fast/dom/Window/Location/window-override-window-using-defineGetter.html
fast/dom/Window/Location/window-shadow-location-using-js-object-with-toString.html
fast/dom/Window/Location/window-shadow-location-using-string.html
fast/dom/Window/Location/window-shadow-window-using-js-object-with-location-field.html
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::defineGetter):
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::customPut): (WebCore::JSLocation::defineGetter): (WebCore::JSLocationPrototype::customPut): (WebCore::JSLocationPrototype::defineGetter):
- bindings/scripts/CodeGeneratorJS.pm:
- page/Location.idl:
LayoutTests:
2009-04-03 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Tests for https://bugs.webkit.org/show_bug.cgi?id=22081
<rdar://problem/6346030>
Don't allow overriding the return value of window.location.
- fast/dom/Window/Location: Added.
- fast/dom/Window/Location/location-override-toString-expected.txt: Added.
- fast/dom/Window/Location/location-override-toString-on-proto-expected.txt: Added.
- fast/dom/Window/Location/location-override-toString-on-proto-using-defineGetter-expected.txt: Added.
- fast/dom/Window/Location/location-override-toString-on-proto-using-defineGetter.html: Added.
- fast/dom/Window/Location/location-override-toString-on-proto-using-with-expected.txt: Added.
- fast/dom/Window/Location/location-override-toString-on-proto-using-with.html: Added.
- fast/dom/Window/Location/location-override-toString-on-proto.html: Added.
- fast/dom/Window/Location/location-override-toString-using-defineGetter-expected.txt: Added.
- fast/dom/Window/Location/location-override-toString-using-defineGetter.html: Added.
- fast/dom/Window/Location/location-override-toString-using-with-expected.txt: Added.
- fast/dom/Window/Location/location-override-toString-using-with.html: Added.
- fast/dom/Window/Location/location-override-toString.html: Added.
- fast/dom/Window/Location/location-override-valueOf-expected.txt: Added.
- fast/dom/Window/Location/location-override-valueOf-on-proto-expected.txt: Added.
- fast/dom/Window/Location/location-override-valueOf-on-proto-using-defineGetter-expected.txt: Added.
- fast/dom/Window/Location/location-override-valueOf-on-proto-using-defineGetter.html: Added.
- fast/dom/Window/Location/location-override-valueOf-on-proto-using-with-expected.txt: Added.
- fast/dom/Window/Location/location-override-valueOf-on-proto-using-with.html: Added.
- fast/dom/Window/Location/location-override-valueOf-on-proto.html: Added.
- fast/dom/Window/Location/location-override-valueOf-using-defineGetter-expected.txt: Added.
- fast/dom/Window/Location/location-override-valueOf-using-defineGetter.html: Added.
- fast/dom/Window/Location/location-override-valueOf-using-with-expected.txt: Added.
- fast/dom/Window/Location/location-override-valueOf-using-with.html: Added.
- fast/dom/Window/Location/location-override-valueOf.html: Added.
- fast/dom/Window/Location/resources: Added.
- fast/dom/Window/Location/resources/location-tests-functions.js: Added. (normalizeURL):
- fast/dom/Window/Location/resources/pass.html: Added.
- fast/dom/Window/Location/resources/window-shadow-location-using-js-object-with-toString-iframe.html: Added.
- fast/dom/Window/Location/resources/window-shadow-location-using-string-iframe.html: Added.
- fast/dom/Window/Location/window-override-location-using-defineGetter-expected.txt: Added.
- fast/dom/Window/Location/window-override-location-using-defineGetter.html: Added.
- fast/dom/Window/Location/window-override-window-using-defineGetter-expected.txt: Added.
- fast/dom/Window/Location/window-override-window-using-defineGetter.html: Added.
- fast/dom/Window/Location/window-shadow-location-using-js-object-with-toString-expected.txt: Added.
- fast/dom/Window/Location/window-shadow-location-using-js-object-with-toString.html: Added.
- fast/dom/Window/Location/window-shadow-location-using-string-expected.txt: Added.
- fast/dom/Window/Location/window-shadow-location-using-string.html: Added.
- fast/dom/Window/Location/window-shadow-window-using-js-object-with-location-field-expected.txt: Added.
- fast/dom/Window/Location/window-shadow-window-using-js-object-with-location-field.html: Added.
- http/tests/security/cross-frame-access-location-put-expected.txt:
- 4:19 PM Changeset in webkit [42217] by
-
- 13 edits in trunk/WebCore
2009-04-03 Geoffrey Garen <ggaren@apple.com>
Rolled out r42214 since it seems to have caused crashes on the buildbot.
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener): (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
- bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/scripts/CodeGeneratorJS.pm:
- 4:13 PM Changeset in webkit [42216] by
-
- 23 edits6 adds in trunk
WebCore:
2009-04-03 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix for <rdar://problem/6476356>
https://bugs.webkit.org/show_bug.cgi?id=23148
- Use the window object the Location and History objects are directly associated with instead of the lexical global object to pick the object prototype to serve as the base of the their respective prototype chains.
- Re-factor as necessary to allow passing the correct global object to the createPrototype functions.
Tests: http/tests/security/cross-frame-access-history-prototype.html
http/tests/security/cross-frame-access-location-prototype.html
- bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
- bindings/js/JSDOMBinding.cpp: (WebCore::getCachedDOMStructure): (WebCore::cacheDOMStructure):
- bindings/js/JSDOMBinding.h: (WebCore::getDOMStructure): (WebCore::getDOMPrototype):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::history): (WebCore::JSDOMWindow::location):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location):
- bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
- bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
- bindings/js/JSNamedNodesCollection.h: (WebCore::JSNamedNodesCollection::createPrototype):
- bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
- bindings/js/JSRGBColor.h: (WebCore::JSRGBColor::createPrototype):
- bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
- bindings/js/JSWebKitPointConstructor.cpp: (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
- bindings/js/JSWorkerConstructor.cpp: (WebCore::JSWorkerConstructor::JSWorkerConstructor):
- bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
- bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createPrototype):
- bridge/runtime_array.h: (JSC::RuntimeArray::createPrototype):
- bridge/runtime_method.h: (JSC::RuntimeMethod::createPrototype):
- bridge/runtime_object.h: (JSC::RuntimeObjectImp::createPrototype):
- page/DOMWindow.idl:
LayoutTests:
2009-04-03 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Tests for <rdar://problem/6476356>
https://bugs.webkit.org/show_bug.cgi?id=23148
Test for using the correct global object for location and history object
prototype chain creation.
- http/tests/security/cross-frame-access-history-prototype-expected.txt: Added.
- http/tests/security/cross-frame-access-history-prototype.html: Added.
- http/tests/security/cross-frame-access-location-prototype-expected.txt: Added.
- http/tests/security/cross-frame-access-location-prototype.html: Added.
- http/tests/security/resources/cross-frame-history-prototype-iframe.html: Added.
- http/tests/security/resources/cross-frame-location-prototype-iframe.html: Added.
- 3:24 PM Changeset in webkit [42215] by
-
- 3 edits in trunk/WebCore
2009-04-03 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=25009
Upstream changes to WorkerContextExecutionProxy for V8 bindings in order to use V8EventListenerList as container.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener): (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
- bindings/v8/WorkerContextExecutionProxy.h:
- 3:09 PM Changeset in webkit [42214] by
-
- 13 edits in trunk/WebCore
2009-04-03 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed irrelevant ExecState* parameter from event handler registration code.
No change in behavior.
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener): (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
- bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/scripts/CodeGeneratorJS.pm:
- 3:00 PM Changeset in webkit [42213] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Anders Carlsson.
<rdar://problem/6756512>
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost): Tweaked the visibleName property.
- 2:21 PM Changeset in webkit [42212] by
-
- 4 edits in trunk/LayoutTests
Skip tests that rely on layoutTestController.waitForPolicyDelegate on platforms that don't implement that functionality
Implementing is covered by the following bugs:
<https://bugs.webkit.org/show_bug.cgi?id=25036>
<https://bugs.webkit.org/show_bug.cgi?id=25037>
<https://bugs.webkit.org/show_bug.cgi?id=25038>
Rubber-stamped by Mark Rowe.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped: Skip tests that use layoutTestController.waitForPolicyDelegate.
- 2:09 PM Changeset in webkit [42211] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Simon Fraser.
- fix <rdar://problem/6634771> Under full-page zoom, cannot scroll MobileMe contact list
Test: fast/css/zoom-in-length-round-trip.html
- dom/Element.cpp: (WebCore::adjustForLocalZoom): For zoom factors greater than 1, ensure that the returned value is equal to the original unscaled value. (WebCore::adjustForAbsoluteZoom): Ditto.
LayoutTests:
Reviewed by Simon Fraser.
- test for <rdar://problem/6634771> Under full-page zoom, cannot scroll MobileMe contact list
- fast/css/zoom-in-length-round-trip-expected.txt: Added.
- fast/css/zoom-in-length-round-trip.html: Added.
- 1:44 PM Changeset in webkit [42210] by
-
- 2 edits in trunk/WebKit/mac
2009-04-03 John Sullivan <sullivan@apple.com>
fixed <rdar://problem/6355573> [WebView _setCacheModel:] leaks the result of _CFURLCacheCopyCacheDirectory
Reviewed by Adam Roben
- WebView/WebView.mm: (+[WebView _setCacheModel:]): use WebCFAutorelease rather than autorelease on result of method that returns CFStringRef
- 1:35 PM Changeset in webkit [42209] by
-
- 2 edits in trunk/LayoutTests
2009-04-03 Simon Fraser <Simon Fraser>
Update expected result due to rounding difference after r42207.
- platform/mac/svg/hixie/perf/007-expected.txt:
- 12:29 PM Changeset in webkit [42208] by
-
- 9 edits in trunk
This fix essentially does a -viewWillDraw call for layout. It adds
a CFRunLoopObserver which performs layout just before drawing on the
Mac platform. This makes sure layout is complete before rendering and
avoids a flash.
- 11:57 AM Changeset in webkit [42207] by
-
- 3 edits in trunk/WebCore
2009-04-02 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Optimize mapPoint(), mapRect() and mapQuad() for identity matrix and translations.
- platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::mapPoint): (WebCore::TransformationMatrix::mapRect): (WebCore::TransformationMatrix::mapQuad):
- platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::mapPoint):
- 11:39 AM Changeset in webkit [42206] by
-
- 3 edits in trunk/WebCore
2009-04-02 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Add containsPoint() and containsQuad() methods to FloatQuad.
- platform/graphics/FloatQuad.cpp: (WebCore::dot): (WebCore::isPointInTriangle): (WebCore::FloatQuad::containsPoint): (WebCore::FloatQuad::containsQuad):
- platform/graphics/FloatQuad.h:
- 11:28 AM Changeset in webkit [42205] by
-
- 3 edits in trunk/WebKit/mac
2009-04-03 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
WebKit side of <rdar://problem/6752953>.
Pass the clip rect to the plug-in host.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::resize):
- Plugins/Hosted/WebKitPluginHost.defs:
- 11:16 AM Changeset in webkit [42204] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
- loader/ProgressTracker.cpp: Included DocumentLoader.h (WebCore::ProgressTracker::incrementProgress): Limit the 50%-clamp rule to documents that use WebCore's layout system.
- 11:06 AM Changeset in webkit [42203] by
-
- 5 edits3 adds in trunk
2009-04-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/6336092> REGRESSION: movie does not resize correctly
Test: media/video-size-intrinsic-scale.html
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::naturalSize): Use QTMovieCurrentSizeAttribute instead of QTMovieNaturalSizeAttribute so we return the correct size for movies saved with a non-default matrix. (WebCore::MediaPlayerPrivate::setSize): Don't resize the QTMovieView because [QTMovieView setFrame] also resizes the movie itself, and as the renderer calls setSize immediately when a movie reports a size change (QTMovieSizeDidChangeNotification) we can get into a feedback loop observing the size change and resetting the size, and this can cause QuickTime to miss correctly setting a movie's size when the media size changes after opening (as happens with an rtsp movie once the server sends the track sizes). Instead, remember the size passed to paint() and resize the view when it changes. (WebCore::MediaPlayerPrivate::paint): Resize the view when passed a new size.
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::getNaturalSize): Use GetMovieBox instead of GetMovieNaturalBoundsRect so we return the correct size for movies saved with non-default matrix.
2009-04-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/6336092> REGRESSION: movie does not resize correctly
- media/content/scaled-matrix.mov: Added. QuickTime movie saved with 2x scale.
- media/video-size-intrinsic-scale-expected.txt: Added.
- media/video-size-intrinsic-scale.html: Added, test that element with a scaled movie is sized correctly.
- media/video-test.js: Modify so it can be included in <head> element. (logConsole): New, wraps creating console <div>, doesn't assume document.body exists. (consoleWrite): Call logConsole().
- 10:52 AM Changeset in webkit [42202] by
-
- 2 edits in trunk/WebCore
2009-04-03 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
Restore FrameLoader::policyDocumentLoader to fix the Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=25028
- loader/FrameLoader.h: (WebCore::FrameLoader::policyDocumentLoader):
- 9:58 AM Changeset in webkit [42201] by
-
- 2 edits in trunk/WebCore
Fixed a backwards comment in ChangeLog.
- 9:28 AM Changeset in webkit [42200] by
-
- 2 edits in trunk/WebCore
2009-04-02 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
Use long long, not int64, when working in webcore (sorry).
https://bugs.webkit.org/show_bug.cgi?id=25011
No change in functionality, so no tests.
- platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::getAppCacheID): (WebCore::ResourceResponse::setAppCacheID):
- 8:33 AM QtWebKitTodo edited by
- (diff)
- 6:00 AM Changeset in webkit [42199] by
-
- 14 edits in trunk
2009-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
Require GTK+ >= 2.10; 2.8 is already very old, and some very
useful APIs are only available since 2.10.
- configure.ac:
WebCore/
2009-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
Remove pre-processor checks for GTK+ >= 2.10, since we now require
at least that version.
- platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
- platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::contextMenuItemTagSelectAll):
- platform/gtk/MouseEventGtk.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::documentFragment):
- platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
WebKit/gtk
2009-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
Remove pre-processor checks for GTK+ >= 2.10, since we now require
at least that version.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::clipboard_clear_contents_cb): (WebKit::EditorClient::respondToChangedSelection):
- webkit/webkitwebframe.cpp:
- webkit/webkitwebview.cpp:
Apr 2, 2009:
- 11:49 PM Changeset in webkit [42198] by
-
- 3 edits4 adds in trunk
2009-04-02 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Fix repainting an element with a reflection and transform after layout.
Telling the reflection to repaint directly is wrong, because, with
LayoutState enabled, it only takes the reflection's transform into account,
not that of the element. We can fix this, and keep the benefits of LayoutState,
by computing the reflected repaint rect, and repainting that using the original
renderer.
Test: fast/repaint/reflection-repaint-test.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
- 10:39 PM Changeset in webkit [42197] by
-
- 3 edits4 adds in trunk
2009-04-02 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
When repainting during layout (when LayoutState is enabled), we need
to apply the transform to the dirty rect, before applying x(), y() and
the offset storted in the LayoutState.
Also bypass LayoutState in mapLocalToContainer() if we have a repaintContainer,
since LayoutState is always root-relative.
Test: fast/repaint/transform-layout-repaint.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::computeRectForRepaint):
- 8:10 PM Changeset in webkit [42196] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/6684745> Crash in -[WebView removeSizeObservers] when loading NIB file
Reviewed by Dan Bernstein and Timothy Hatcher.
The implementation of -[NSView initWithCoder:] can result in -viewWillMoveToSuperview:/-viewDidMoveToSuperview: being sent to
our view before we've had a chance to initialize _private, so we need to ensure it is non-nil before dereferencing it in those
methods.
- WebView/WebView.mm:
(-[WebView removeSizeObservers]): Nil-check _private before dereferencing it.
(-[WebView addSizeObservers]): Ditto.
- 6:07 PM Changeset in webkit [42195] by
-
- 2 edits in trunk/WebCore
Fix the Mac build after r42191.
- WebCore.base.exp:
- 6:01 PM Changeset in webkit [42194] by
-
- 2 edits in trunk/WebCore
Fix Windows build after r42190.
- page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent): Update to use the new name of the constant.
- 5:42 PM Changeset in webkit [42193] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixed ChangeLog.
2009-04-02 Darin Adler <Darin Adler>
Reviewed by Brady Eidson.
<rdar://problem/6625840> Previous Page isn't loaded after hitting back button at http://www.breakingnews.ie/
Test: http/tests/navigation/onload-navigation-iframe-2.html
- html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::HTMLFrameElement): Removed unneeded createdByParser flag.
- html/HTMLFrameElement.h: Ditto.
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Ditto.
- html/HTMLFrameElementBase.h: Ditto.
- html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): Ditto.
- html/HTMLFrameOwnerElement.h: Ditto.
- html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::HTMLIFrameElement): Ditto.
- html/HTMLIFrameElement.h: Ditto.
- html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Removed unneeded check of the createdByParser flag. The original change that introduced this, http://trac.webkit.org/changeset/25410, does not make it clear why this check was needed. And it seems it is needed.
- 5:41 PM Changeset in webkit [42192] by
-
- 13 edits2 copies in trunk
WebCore:
2009-04-02 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Add a way to get a list of focusable nodes.
- dom/Document.cpp: (WebCore::Document::setFocusedNode): (WebCore::Document::getFocusableNodes):
- dom/Document.h:
LayoutTests:
2009-04-02 Darin Adler <Darin Adler>
Reviewed by Brady Eidson.
<rdar://problem/6625840> Previous Page isn't loaded after hitting back button at http://www.breakingnews.ie/
- http/tests/navigation/onload-navigation-iframe-2-expected.txt: Copied from LayoutTests/http/tests/navigation/onload-navigation-iframe-expected.txt. Updated for slight difference in the new test.
- http/tests/navigation/onload-navigation-iframe-2.html: Copied from LayoutTests/http/tests/navigation/onload-navigation-iframe.html. Changed test to use an iframe element already in the HTML.
- 5:39 PM Changeset in webkit [42191] by
-
- 9 edits1 add in trunk
WebCore:
2009-04-02 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Add a way to get a list of focusable nodes.
- dom/Document.cpp: (WebCore::Document::setFocusedNode): (WebCore::Document::getFocusableNodes):
- dom/Document.h:
WebKit:
2009-04-02 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
- WebKit.xcodeproj/project.pbxproj: Add WebDOMOperationsInternal.h and make WebDOMOperationsPrivate.h private.
WebKit/mac:
2009-04-02 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Add a way to get a list of focusable nodes.
- DOM/WebDOMOperations.mm: (-[DOMDocument _focusableNodes]):
- DOM/WebDOMOperationsInternal.h: Added.
- DOM/WebDOMOperationsPrivate.h: Make this a private header. Move old methods to WebDOMOperationsInternal.h
- WebView/WebHTMLView.mm: Use methods from WebDOMOperationsInternal.h
- 5:19 PM Changeset in webkit [42190] by
-
- 2 edits in trunk/WebCore
2009-04-02 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
<rdar://problem/6654255> crash due to null FrameView in EventHandler
Lots of code was added to EventHandler that used view() and page() without
null checking, but both of those can become null due to the frame lifetime.
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::handleAutoscroll): (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::setPanScrollCursor): (WebCore::EventHandler::allowDHTMLDrag): (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::stopAutoscrollTimer): (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::dispatchDragEvent): (WebCore::EventHandler::prepareMouseEvent): (WebCore::EventHandler::dispatchMouseEvent): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::hoverTimerFired): (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::dragHysteresisExceeded): (WebCore::EventHandler::shouldDragAutoNode): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleTextInputEvent): (WebCore::EventHandler::addPendingFrameUnloadEventCount): (WebCore::EventHandler::removePendingFrameUnloadEventCount): (WebCore::EventHandler::clearPendingFrameUnloadEventCount): (WebCore::EventHandler::addPendingFrameBeforeUnloadEventCount): (WebCore::EventHandler::removePendingFrameBeforeUnloadEventCount): (WebCore::EventHandler::clearPendingFrameBeforeUnloadEventCount): Added null checks for view() and page(). Made minor code cleanups.
- 2:58 PM Changeset in webkit [42189] by
-
- 2 edits in trunk/WebCore
2009-04-02 David Hyatt <hyatt@apple.com>
Reviewed by Oliver Hunt.
Fix regression in <object> layout test. Make sure that even though a 404 image loads, that <object>
still considers it an error for the purposes of firing onerror.
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent):
- 2:58 PM Changeset in webkit [42188] by
-
- 4 edits3 adds in trunk/LayoutTests
2009-04-02 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
Split no-port test case into separate file, since its result may
depend on the behavior of a DNS proxy on some systems.
https://bugs.webkit.org/show_bug.cgi?id=21530
- platform/mac-tiger/security/block-test-expected.txt: updated
- platform/mac-tiger/security/block-test-no-port-expected.txt: Added.
- platform/mac/security/block-test-expected.txt: updated
- platform/mac/security/block-test-no-port-expected.txt: Added.
- security/block-test-no-port.html: Added.
- security/block-test.html: removed no-port test case
- 2:48 PM Changeset in webkit [42187] by
-
- 7 edits in trunk/WebCore
2009-04-02 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=25010
Refactor InspectorController to replace all JS function invocations with
ScriptFunctionCall.
- bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument): Added int, UString,
and JSValuePtr methods.
(WebCore::ScriptFunctionCall::call): Added simplified, exception-eating
method.
- bindings/js/ScriptFunctionCall.h: Decls for above.
- bindings/js/ScriptObjectQuarantine.cpp: Added helper for Node and DOMWindow. (WebCore::getQuarantinedScriptObject):
- bindings/js/ScriptObjectQuarantine.h: Decls for above.
- inspector/InspectorController.cpp: (WebCore::callSimpleFunction): Made into a static. (WebCore::InspectorController::focusNode): Refactored to use ScriptFunctionCall. (WebCore::InspectorController::toggleRecordButton): Ditto. (WebCore::InspectorController::startGroup): Ditto. (WebCore::InspectorController::setAttachedWindow): Ditto. (WebCore::InspectorController::inspectedWindowScriptObjectCleared): Ditto. (WebCore::InspectorController::addScriptProfile): Ditto. (WebCore::InspectorController::didParseSource): Ditto. (WebCore::InspectorController::failedToParseSource): Ditto. (WebCore::InspectorController::didPause): Ditto.
- inspector/InspectorController.h: Removed callFunction and callSimpleFunction
decls.
- 2:30 PM Changeset in webkit [42186] by
-
- 4 edits in trunk/WebCore
2009-04-02 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
Upstream changes to V8WorkerContextEventListener for V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=25007
- bindings/v8/V8ObjectEventListener.h:
- bindings/v8/V8WorkerContextEventListener.h:
- bindings/v8/V8WorkerContextEventListener.cpp:
- 2:29 PM Changeset in webkit [42185] by
-
- 1 edit2 adds in trunk/WebCore
2009-04-02 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
Upstream V8WorkerContextObjectEventListener for V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=25005
- bindings/v8/V8WorkerContextObjectEventListener.cpp: Added.
- bindings/v8/V8WorkerContextObjectEventListener.h: Added.
- 2:29 PM Changeset in webkit [42184] by
-
- 1 edit2 adds in trunk/WebCore
2009-04-02 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
Upstream V8EventListenerList for V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=25004
- bindings/v8/V8EventListenerList.cpp: Added.
- bindings/v8/V8EventListenerList.h: Added.
- 1:59 PM BadContent created by
- 1:45 PM Changeset in webkit [42183] by
-
- 2 edits in trunk/WebKitTools
Build fix for Windows machines that don't have WebKitTools/Scipts in their PATH
- Scripts/pdevenv: Add WebKitTools/Scripts to PATH when launching Visual Studio/VC++ Express.
- 1:31 PM Changeset in webkit [42182] by
-
- 2 edits in trunk/WebKitTools
Use pdevenv when building .vcproj files via our scripts
Reviewed by Mark Rowe.
- Scripts/webkitdirs.pm: (sub buildVisualStudioProject): Use pdevenv instead of invoking Visual Studio/VC++ Express directly.
- 1:22 PM Changeset in webkit [42181] by
-
- 1 edit in trunk/WebCore/html/HTMLImageLoader.cpp
Fix release build bustage.
- 1:00 PM Changeset in webkit [42180] by
-
- 3 edits in trunk/WebCore
2009-04-02 Michael Nordman <Michael Nordman>
Reviewed by Darin Fisher.
Chromium's ResourceRequest and ResourceResponse structs need some new data members.
https://bugs.webkit.org/show_bug.cgi?id=24897
These fields are needed to facilitate Chromium's implementation of the HTML5
ApplicationCache feature. We need to know what frame (or context) is doing the
requesting, and from what cache the resulting resource was retrieved.
No change in functionality, so no tests.
- platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::appCacheContextID): (WebCore::ResourceRequest::setAppCacheContextID):
- platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::getAppCacheID): (WebCore::ResourceResponse::setAppCacheID):
- 12:57 PM Changeset in webkit [42179] by
-
- 7 edits2 adds in trunk
WebCore:
2009-04-02 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler
Make sure images just ignore HTTP error codes and keep loading anyway. Only <object> checks http error codes and falls back. Everyone
else just ignores it and displays the image anyway.
Added http/tests/misc/image-error.html
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::notifyFinished):
- loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage):
- loader/CachedImage.h: (WebCore::CachedImage::httpStatusCodeError): (WebCore::CachedImage::httpStatusCodeErrorOccurred):
- loader/CachedResource.h: (WebCore::CachedResource::httpStatusCodeError):
- loader/loader.cpp: (WebCore::Loader::Host::didReceiveData):
LayoutTests:
2009-04-02 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler
Add test for https://bugs.webkit.org/show_bug.cgi?id=24643
- http/tests/misc/image-error-expected.txt: Added.
- http/tests/misc/image-error.html: Added.
- 11:42 AM Changeset in webkit [42178] by
-
- 2 edits in trunk/WebCore
2009-04-02 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
Add XHR constructor in WorkerContext.idl for V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=24962
- workers/WorkerContext.idl:
- 11:22 AM Changeset in webkit [42177] by
-
- 3 edits3 adds in trunk/LayoutTests
2009-04-02 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
Split long-running regexp out of the main regexp-overflow test file
so VMs (such as V8) that don't limit execution time can still run
the rest of the test cases.
https://bugs.webkit.org/show_bug.cgi?id=18327
- fast/js/regexp-overflow-expected.txt: updated
- fast/js/regexp-overflow-too-big-expected.txt: Added.
- fast/js/regexp-overflow-too-big.html: Added.
- fast/js/resources/regexp-overflow-too-big.js: Added.
- fast/js/resources/regexp-overflow.js: removed one test case
- 11:18 AM Changeset in webkit [42176] by
-
- 2 edits in trunk/LayoutTests
2009-04-02 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
Minor cleanup: remove unneeded "toLower" on typeof.
- fast/dom/Window/window-lookup-precedence.html:
- 10:30 AM Changeset in webkit [42175] by
-
- 2 edits1 add in trunk/WebCore
2009-04-01 Ben Murdoch <benm@google.com>
Fix Bug 19743: Release build fails on 32-bit Windows
Combines all the HTML element cpp files into one to help reduce the
size of WebCore.lib so we can build in release mode on 32bit Windows.
Reviewed by Adam Roben.
- WebCore.vcproj/WebCore.vcproj: Excluded all the separate HTML*Element.cpp files from the build. Added HTMLElementsAllInOne.cpp to the build.
- html/HTMLElementsAllInOne.cpp: Added.
- 9:47 AM Changeset in webkit [42174] by
-
- 7 edits in trunk/WebCore
2009-04-02 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Optimize hit testing with transforms.
- rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::mapAbsoluteToLocalPoint): getTransformFromContainer() change to return the matrix by reference.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::update3DTransformedDescendantStatus): The method failed to set m_3DTransformedDescendantStatusDirty to false, so did the work every time.
(WebCore::RenderLayer::createLocalTransformState):
Only call the expensive getTransformFromContainer() if there is a transform,
otherwise we just have a translation.
- rendering/RenderObject.cpp: (WebCore::RenderObject::getTransformFromContainer):
- rendering/RenderObject.h: Change transformFromContainer() to getTransformFromContainer(), and return the matrix by reference to reduce copying. New enum values for arguments for readability.
- rendering/TransformState.cpp: (WebCore::TransformState::move): (WebCore::TransformState::applyTransform): (WebCore::HitTestingTransformState::translate): New method that adds a translation to the accumulated matrix, optionally without flattening. Cheaper than applyTransform().
(WebCore::HitTestingTransformState::applyTransform):
(WebCore::HitTestingTransformState::flatten):
(WebCore::HitTestingTransformState::flattenWithTransform):
Add flattenWithTransform(), which is a helper that allows us to
avoid doing the inverse() twice.
- rendering/TransformState.h: (WebCore::TransformState::): (WebCore::TransformState::move): (WebCore::HitTestingTransformState::): New method on HitTestingTransformState that adds a translation to the accumulated matrix, optionally without flattening. Cheaper than applyTransform(). New enum values for arguments for readability.
- 9:35 AM Changeset in webkit [42173] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-02 Darin Adler <Darin Adler>
Reviewed by Kevin Decker.
<rdar://problem/6744471> crash in GC due to uninitialized callFunction pointer
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Initialize callFunction as we do the other data members that are used in the mark function.
- 9:25 AM Changeset in webkit [42172] by
-
- 3 edits in trunk/WebCore
2009-04-02 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Optimize common code paths in TransformationMatrix.
- platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::translate): (WebCore::TransformationMatrix::translate3d): Optimize to avoid matrix copy.
(WebCore::TransformationMatrix::isInvertible):
Test for identity and translation matrices before computing
the determinant.
(WebCore::TransformationMatrix::inverse):
Optimize for identity matrix and translations.
- platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::isIdentityOrTranslation): Utility method.
- 9:23 AM QtWebKitTodo edited by
- (diff)
- 9:01 AM Changeset in webkit [42171] by
-
- 2 edits in trunk/WebCore
2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=24930
[Gtk] ISO files content is displayed inside the webview instead of being downloaded
Also sniff content of types declared as text/plain. This is
justified by the fact that it is common to have Apache HTTP
servers configured to send text/plain as Content-Type by default.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback):
- 9:00 AM Changeset in webkit [42170] by
-
- 2 edits in trunk/WebCore
2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Alexey Proskuryakov.
Protect the handle when notifying the client that the response was
received also in gotChunkCallback, or we crash in didReceiveData
when the load is cancelled in didReceiveResponse.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotChunkCallback):
- 8:50 AM Changeset in webkit [42169] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=24844
Unit test WebKitDownload
Extra checks to avoid crashing and a critical message when
property accessor functions are called before the download is
started.
- webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_get_progress): (_WebKitDownloadPrivate::webkit_download_get_elapsed_time):
- 8:42 AM Changeset in webkit [42168] by
-
- 2 edits in trunk/WebCore
2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=25001
Crash when content type parameters have no value
Handle the case where a Content-Type header parameter has no
value (i.e. no = character), to work-around a bug in libsoup.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
- 3:29 AM Changeset in webkit [42167] by
-
- 4 edits in trunk
2009-04-02 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon Hausmann
Implement WTF::ThreadSpecific in the Qt build using
QThreadStorage.
WebCore:
2009-04-02 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon Hausmann.
Enable web workers in Qt.
- 12:54 AM Changeset in webkit [42166] by
-
- 2 edits in trunk/WebKit/qt
Fix the Qt build
- 12:54 AM Changeset in webkit [42165] by
-
- 2 edits in trunk/WebKit/qt
2009-04-02 Takumi Asaki <takumi.asaki@nokia.com>
Reviewed by Simon Hausmann.
Fix pre-edit handling of text fields with input methods.
The input method sends an empty preeditString() if all characters of
the preedit should be deleted. So inputMethodEvent() has to use
preeditString() if it's empty.
- 12:12 AM Changeset in webkit [42164] by
-
- 8 edits17 moves6 adds in trunk
Reviewed by Darin Adler. Based on work of Julien Chaffraix.
https://bugs.webkit.org/show_bug.cgi?id=22475
REGRESSION: Async XMLHttpRequest never finishes on nonexistent files anymore
https://bugs.webkit.org/show_bug.cgi?id=24886
XHR requests opened when offline never return
WebCore:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): Only dispatch load event if this wasn't an error. (WebCore::XMLHttpRequest::abort): Fixed formatting. (WebCore::XMLHttpRequest::genericError): Change state to DONE and dispatch readystatechange. The comment saying that this doesn't match Firefox was added in r33559 without explanation or tests, and I don't think that it's accurate. Also, Firefox and Safari 3 both change state to HEADERS_RECEIVED before DONE on error - this doesn't match the spec, and I doubt that any code depends on this, so I went with the spec here.
LayoutTests:
- fast/loader/xmlhttprequest-missing-file-exception-expected.txt: Removed.
- fast/loader/xmlhttprequest-missing-file-exception.html: Removed.
- http/tests/xmlhttprequest/state-after-network-error-expected.txt: Added.
- http/tests/xmlhttprequest/state-after-network-error.html: Added. Added tests for these issues.
- http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt: As with other errors, the request now reaches DONE state now. This makes the results closer to Firefox again (they changed multiple times recently).
- http/tests/xmlhttprequest/resources/frame-load-to-cancel.html: Firefox dispatches cancellation events at a later point, when window.parent is already undefined. Changed the test to log all events, making the difference with Firefox less confusing.
- http/tests/xmlhttprequest/simple-cross-origin-progress-events.html: Fixed a mistake in the test, which could call a non-existent function in some code paths.
- http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt: State now reaches DONE on cross-origin check failure, as it should per the spec. This matches Firefox in async case (and in sync case, it simply doesn't dispatch any onreadystatechange events, not sure why).
- fast/dom/null-document-xmlhttprequest-open-expected.txt: Removed.
- fast/dom/null-document-xmlhttprequest-open.html: Removed.
- fast/dom/resources/1251.html: Removed.
- fast/dom/resources/xmlhttprequest-get-data.xml: Removed.
- fast/dom/xmlhttprequest-gc-expected.txt: Removed.
- fast/dom/xmlhttprequest-gc.html: Removed.
- fast/dom/xmlhttprequest-get-expected.txt: Removed.
- fast/dom/xmlhttprequest-get.xhtml: Removed.
- fast/dom/xmlhttprequest-html-response-encoding-expected.txt: Removed.
- fast/dom/xmlhttprequest-html-response-encoding.html: Removed.
- fast/dom/xmlhttprequest-invalid-values-expected.txt: Removed.
- fast/dom/xmlhttprequest-invalid-values.html: Removed.
- fast/loader/resources/plist.app: Removed.
- fast/loader/xmlhttprequest-bad-mimetype-expected.txt: Removed.
- fast/loader/xmlhttprequest-bad-mimetype.html: Removed.
- fast/xmlhttprequest: Added.
- fast/xmlhttprequest/null-document-xmlhttprequest-open-expected.txt: Copied from LayoutTests/fast/dom/null-document-xmlhttprequest-open-expected.txt.
- fast/xmlhttprequest/null-document-xmlhttprequest-open.html: Copied from LayoutTests/fast/dom/null-document-xmlhttprequest-open.html.
- fast/xmlhttprequest/resources: Added.
- fast/xmlhttprequest/resources/1251.html: Copied from LayoutTests/fast/dom/resources/1251.html.
- fast/xmlhttprequest/resources/plist.app: Copied from LayoutTests/fast/loader/resources/plist.app.
- fast/xmlhttprequest/resources/xmlhttprequest-get-data.xml: Copied from LayoutTests/fast/dom/resources/xmlhttprequest-get-data.xml.
- fast/xmlhttprequest/xmlhttprequest-bad-mimetype-expected.txt: Copied from LayoutTests/fast/loader/xmlhttprequest-bad-mimetype-expected.txt.
- fast/xmlhttprequest/xmlhttprequest-bad-mimetype.html: Copied from LayoutTests/fast/loader/xmlhttprequest-bad-mimetype.html.
- fast/xmlhttprequest/xmlhttprequest-gc-expected.txt: Copied from LayoutTests/fast/dom/xmlhttprequest-gc-expected.txt.
- fast/xmlhttprequest/xmlhttprequest-gc.html: Copied from LayoutTests/fast/dom/xmlhttprequest-gc.html.
- fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Copied from LayoutTests/fast/dom/xmlhttprequest-get-expected.txt.
- fast/xmlhttprequest/xmlhttprequest-get.xhtml: Copied from LayoutTests/fast/dom/xmlhttprequest-get.xhtml.
- fast/xmlhttprequest/xmlhttprequest-html-response-encoding-expected.txt: Copied from LayoutTests/fast/dom/xmlhttprequest-html-response-encoding-expected.txt.
- fast/xmlhttprequest/xmlhttprequest-html-response-encoding.html: Copied from LayoutTests/fast/dom/xmlhttprequest-html-response-encoding.html.
- fast/xmlhttprequest/xmlhttprequest-invalid-values-expected.txt: Copied from LayoutTests/fast/dom/xmlhttprequest-invalid-values-expected.txt.
- fast/xmlhttprequest/xmlhttprequest-invalid-values.html: Copied from LayoutTests/fast/dom/xmlhttprequest-invalid-values.html.
- fast/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Copied from LayoutTests/fast/loader/xmlhttprequest-missing-file-exception-expected.txt.
- fast/xmlhttprequest/xmlhttprequest-missing-file-exception.html: Copied from LayoutTests/fast/loader/xmlhttprequest-missing-file-exception.html.
- fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: Added.
- fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html: Added.
- platform/gtk/Skipped: Moved non-HTTP XMLHttpRequest tests to fast/xmlhttprequest.
Apr 1, 2009:
- 11:49 PM QtWebKitTodo edited by
- (diff)
- 9:51 PM Changeset in webkit [42163] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=24997
Race conditions in icon database threading code
m_syncThreadRunning set was mistakenly eliminated in r27717.
This reintroduces it.
Reviewed by Oliver Hunt.
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): Set m_syncThreadRunning.
- 7:58 PM Changeset in webkit [42162] by
-
- 2 edits in trunk/WebKitTools
Windows support for built-product-archive.
- BuildSlaveSupport/built-product-archive:
- 6:20 PM Changeset in webkit [42161] by
-
- 6 edits in trunk/WebCore
2009-04-01 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
<rdar://problem/6748609> Use ActiveDOMObject to suspend marquees
Make marquees ActiveDOMObjects, get rid of the special suspension code.
- html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::HTMLMarqueeElement): (WebCore::HTMLMarqueeElement::canSuspend): (WebCore::HTMLMarqueeElement::suspend): (WebCore::HTMLMarqueeElement::resume):
- html/HTMLMarqueeElement.h:
- page/Frame.cpp: (WebCore::Frame::clearTimers):
- rendering/RenderLayer.cpp:
- rendering/RenderLayer.h: (WebCore::RenderLayer::marquee):
- 6:10 PM Changeset in webkit [42160] by
-
- 2 edits in trunk/WebCore
2009-04-01 Dean Jackson <dino@apple.com>
Reviewed by Darin Adler
Make constant values static in previous commit, as suggested
by Darin.
- rendering/RenderVideo.cpp:
- 5:57 PM Changeset in webkit [42159] by
-
- 2 edits in trunk/WebCore
2009-04-01 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser
Standalone media should have a smaller instrinsic
height.
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo):
- 5:30 PM Changeset in webkit [42158] by
-
- 23 edits1 copy1 move6 adds in trunk
WebCore:
2009-04-01 Darin Adler <Darin Adler>
Reviewed by Geoff Garen.
Bug 22378: Crash submitting a form when parsing an XHTML document
https://bugs.webkit.org/show_bug.cgi?id=22378
rdar://problem/6388377
Tests: fast/loader/submit-form-while-parsing-1.xhtml
fast/loader/submit-form-while-parsing-2.html
- WebCore.base.exp: Updated.
- history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): Renamed m_subItems to m_children. Used uncheckedAppend because we reserveInitialCapacity. (WebCore::HistoryItem::addChildItem): Renamed m_subItems to m_children. Added an assertion that this is only used to add items that don't have duplicate frame names. (WebCore::HistoryItem::setChildItem): Added. Replaces an existing item if any, preserving the isTargetItem flag. (WebCore::HistoryItem::childItemWithTarget): Renamed from childItemWithName for consistency with the other functions here that all call the frame name the "target". Also updated for rename of m_subItems to m_children. (WebCore::HistoryItem::findTargetItem): Renamed from recurseToFindTargetItem. Removed unneeded size check. (WebCore::HistoryItem::targetItem): Changed to always return the top item if no item has the isTargetItem flag set. The old version would instead return 0 in some cases, but return the top item if it had no children. (WebCore::HistoryItem::children): Renamed m_subItems to m_children. (WebCore::HistoryItem::hasChildren): Ditto. (WebCore::HistoryItem::showTreeWithIndent): Ditto.
- history/HistoryItem.h: Name changes.
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Create and pass a FormState instead of attaching "recorded form values" and "form about to be submitted" to the frame loader. Parameter work fine for this; there's no need to store state on the FrameLoader.
- loader/FormState.cpp: (WebCore::FormState::FormState): Adopt a vector instead of copying a hash map. (WebCore::FormState::create): Ditto.
- loader/FormState.h: Update to use a vector that we adopt instead of hash map that we copy for auto-fill text field values.
- loader/FrameLoader.cpp: (WebCore::ScheduledRedirection::ScheduledRedirection): Added a new case for form submissions and turned the "wasDuringLoad" state into a separate boolean instead of using a special redirection type to track it. (WebCore::FrameLoader::createWindow): Updated for name and argument change of loadFrameRequest. (WebCore::FrameLoader::urlSelected): Ditto. (WebCore::FrameLoader::submitForm): Removed the "deferred form submission" machinery, replacing it with the "scheduled redirection" mechanism, shared with other kinds of redirection and navigation. Moved frame targeting here so we can schedule the redirection on the right frame. Moved the multiple form submission protection here. Moved the code to implement the rule that m_navigationDuringLoad was used for here too. (WebCore::FrameLoader::didOpenURL): Use the new wasDuringLoad flag instead of the locationChangeDuringLoad type to detect location change during a load. (WebCore::FrameLoader::executeScript): Removed call to now-obsolete function, submitFormAgain. (WebCore::FrameLoader::scheduleLocationChange): Moved the code to stop loading out of this function into scheduleRedirection, so it can be shared with the new scheduleFormSubmission function. (WebCore::FrameLoader::scheduleFormSubmission): Added. Almost the same as scheduleLocationChange, but with the arguments for a form submission. (WebCore::FrameLoader::scheduleRefresh): Updated for the change to the duringLoad flag. (WebCore::FrameLoader::isLocationChange): Added case for formSubmission and removed case for locationChangeDuringLoad. (WebCore::FrameLoader::redirectionTimerFired): Ditto. Also removed unneeded completeURL call and just use KURL constructor to match the other cases. (WebCore::FrameLoader::provisionalLoadStarted): Removed the code to set up the m_navigationDuringLoad, which is no longer needed. The new version of this is in the submitForm function and sets the lockHistory boolean. (WebCore::FrameLoader::scheduleRedirection): Moved the code to stop a load in here that used to be in scheduleLocationChange. (WebCore::FrameLoader::startRedirectionTimer): Added case for formSubmission and removed case for locationChangeDuringLoad. (WebCore::FrameLoader::stopRedirectionTimer): Ditto. (WebCore::FrameLoader::completed): Removed call to now-obsolete function, submitFormAgain. (WebCore::FrameLoader::loadFrameRequest): Renamed from loadFrameRequestWithFormAndValues. Replaced form element and form values argument with a single FormState argument. Changed frame targeting code to use the source frame in the case of a form submission to better match the actual target frame. (WebCore::FrameLoader::loadURL): Don't search for existing frames in the form submission case since we already did that in the submitForm function. (WebCore::FrameLoader::clientRedirected): Changed to work with the m_isExecutingJavaScriptFormAction data member directly instead of taking it as a function parameter. (WebCore::FrameLoader::loadPostRequest): Don't search for existing frames in the form submission case since we already did that in the submitForm function. (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Moved comment in here that was misplaced elsewhere in the file. (WebCore::FrameLoader::findFrameForNavigation): Changed to use the early return idiom. (WebCore::FrameLoader::recursiveGoToItem): Updated for HistoryItem changes. (WebCore::FrameLoader::childFramesMatchItem): Ditto. (WebCore::FrameLoader::updateHistoryForStandardLoad): Removed the m_navigationDuringLoad logic; that's now handled by setting lockHistory to true in the submitForm function. (WebCore::FrameLoader::updateHistoryForRedirectWithLockedBackForwardList): Use the new setChildItem function so we don't get multiple items for the same frame name in the history item tree in the back/forward list.
- loader/FrameLoader.h: Renamed loadFrameRequestWithFormAndValues to loadFrameRequest and made it take a form state object instead of the form element and form values. Removed the unused functions loadEmptyDocumentSynchronously, provisionalDocumentLoader, notifyIconChnaged, and updateBaseURLForEmptyDocument. Changed the submitForm function to take a form state argument. Eliminated the clearRecordedFormValues, setFormAboutToBeSubmitted, and recordFormValue functions, which are replaced by the form state arguments to submitForm and loadFrameRequest. Removed the isJavaScriptFormAction argument from the clientRedirected function; instead it looks at a data member directly. Eliminated the submitFormAgain and overload of the submitForm function; these are now subsumed into the remaining submitForm function and the scheduleFormSubmission function. Removed unused and obsolete data members m_navigationDuringLoad, m_deferredFormSubmission, m_formAboutToBeSubmitted and m_formValuesAboutToBeSubmitted.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Updated for name and argument change of loadFrameRequest.
- page/Frame.cpp: (WebCore::Frame::~Frame): Removed call to the now-unneeded clearRecordedFormValues function.
WebKit/mac:
2009-04-01 Darin Adler <Darin Adler>
Reviewed by Geoff Garen.
Bug 22378: Crash submitting a form when parsing an XHTML document
https://bugs.webkit.org/show_bug.cgi?id=22378
rdar://problem/6388377
- History/WebHistoryItem.mm: (-[WebHistoryItem targetItem]): Call targetItem directly instead of callling isTargetItem, hasChildren, and recurseToFindTargetItem.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSubmitForm): Updated for the new textFieldValues function in FormState.
- WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for name and argument change of loadFrameRequest.
WebKit/win:
2009-04-01 Darin Adler <Darin Adler>
Reviewed by Geoff Garen.
Bug 22378: Crash submitting a form when parsing an XHTML document
https://bugs.webkit.org/show_bug.cgi?id=22378
rdar://problem/6388377
- WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): Updated for the new textFieldValues function in FormState.
LayoutTests:
2009-04-01 Darin Adler <Darin Adler>
Reviewed by Geoff Garen.
Bug 22378: Crash submitting a form when parsing an XHTML document
https://bugs.webkit.org/show_bug.cgi?id=22378
rdar://problem/6388377
- fast/loader/onunload-form-submit-crash-2-expected.txt: Updated for change to the test.
- fast/loader/onunload-form-submit-crash-2.html: Updated test to expect the form submission during the onunload handler to be ineffective.
- fast/loader/onunload-form-submit-crash-expected.txt: Updated for change to the test.
- fast/loader/onunload-form-submit-crash.html: Updated test to expect the form submission during the onunload handler to be ineffective.
- fast/loader/resources/onunload-form-submit-crash2.html: Removed.
- fast/loader/resources/onunload-form-submit-failure.html: Copied from LayoutTests/fast/loader/resources/onunload-form-submit-crash2.html.
- fast/loader/resources/onunload-form-submit-success.html: Copied from LayoutTests/fast/loader/resources/onunload-form-submit-crash2.html.
- fast/loader/resources/submit-form-while-parsing-subframe.html: Added.
- fast/loader/resources/submit-form-while-parsing-success.html: Added.
- fast/loader/submit-form-while-parsing-1-expected.txt: Added.
- fast/loader/submit-form-while-parsing-1.xhtml: Added.
- fast/loader/submit-form-while-parsing-2-expected.txt: Added.
- fast/loader/submit-form-while-parsing-2.html: Added.
- platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt: Updated to expect proper results, without the duplicate history items for the same frame name that were present before.
- 4:49 PM Changeset in webkit [42157] by
-
- 2 edits in trunk/WebCore
2009-04-01 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, fixing previous commit.
https://bugs.webkit.org/show_bug.cgi?id=24994
Revert V8DOMMap.cpp change which accidentally snuck into the previous
commit.
- bindings/v8/V8DOMMap.cpp: Revert change in previous commit.
- 4:43 PM Changeset in webkit [42156] by
-
- 5 edits in trunk/WebCore
2009-04-01 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=24994
Fix miscellaneous merge/upstreaming divergencies in Chromium port.
- bindings/v8/V8Collection.h: Added an include.
- platform/KURLGoogle.cpp: (WebCore::KURL::baseAsString): Added to match KURL.cpp.
- platform/chromium/ClipboardChromium.cpp: Added an include.
- 3:47 PM Changeset in webkit [42155] by
-
- 11 edits in trunk/WebCore
2009-04-01 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=24989
Refactor InspectorResource to use ScriptObject/FunctionCall.
- bindings/js/JSInspectorControllerCustom.cpp: (WebCore::JSInspectorController::addResourceSourceToFrame): Tweaked to use
a more appropriate type conversion.
(WebCore::JSInspectorController::getResourceDocumentNode): Tweaked to
accommodate for InspectorResource refactoring.
- bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument): Added long long type to match
existing jsNumber call signature.
- bindings/js/ScriptFunctionCall.h: Declaration for above.
- bindings/js/ScriptObject.cpp: (WebCore::createEmptyObject): Added. (WebCore::ScriptObject::ScriptObject): (WebCore::ScriptObject::set): Added a bunch of property setters.
- bindings/js/ScriptObject.h: Declarations for above.
- inspector/InspectorController.cpp: Moved all InspectorResource-managing code
to InspectorResource.cpp
(WebCore::InspectorController::populateScriptObjects): Changed to use
refactored InspectorResource.
(WebCore::InspectorController::resetScriptObjects): Ditto.
(WebCore::InspectorController::pruneResources): Ditto.
(WebCore::InspectorController::didCommitLoad): Ditto.
(WebCore::InspectorController::addResource): Ditto.
(WebCore::InspectorController::removeResource): Ditto.
(WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
(WebCore::InspectorController::identifierForInitialRequest): Ditto.
(WebCore::InspectorController::willSendRequest): Ditto.
(WebCore::InspectorController::didReceiveResponse): Ditto.
(WebCore::InspectorController::didReceiveContentLength): Ditto.
(WebCore::InspectorController::didFinishLoading): Ditto.
(WebCore::InspectorController::didFailLoading): Ditto,
(WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): Ditto.
(WebCore::InspectorController::scriptImported): Ditto.
- inspector/InspectorController.h: Removed InspectorResource-managing code decls
and tweaked some signatures to use ScriptString and long long for identifier.
- inspector/InspectorController.idl: Changed to use long long for identifier.
- inspector/InspectorResource.cpp: Refactored to use ScriptObject/FunctionCall. (WebCore::InspectorResource::InspectorResource): Ditto. (WebCore::InspectorResource::~InspectorResource): Ditto. (WebCore::InspectorResource::createCached): Added. (WebCore::InspectorResource::updateRequest): Added. (WebCore::InspectorResource::updateResponse): Added. (WebCore::createHeadersObject): Added. (WebCore::InspectorResource::createScriptObject): Added. (WebCore::InspectorResource::updateScriptObject): Added. (WebCore::InspectorResource::releaseScriptObject): Added. (WebCore::InspectorResource::type): Tweaked to use ScriptString. (WebCore::InspectorResource::setXMLHttpResponseText): Added. (WebCore::InspectorResource::sourceString): Tweaked to use ScriptString. (WebCore::InspectorResource::startTiming): Added. (WebCore::InspectorResource::markResponseReceivedTime): Added. (WebCore::InspectorResource::endTiming): Added. (WebCore::InspectorResource::markFailed): Added. (WebCore::InspectorResource::addLength): Added.
- inspector/InspectorResource.h: Added decls for newly refactored-in methods. (WebCore::InspectorResource::create): Added. (WebCore::InspectorResource::isSameLoader): Added. (WebCore::InspectorResource::markMainResource): Added. (WebCore::InspectorResource::identifier): Added. (WebCore::InspectorResource::requestURL): Added. (WebCore::InspectorResource::frame): Added. (WebCore::InspectorResource::mimeType): Added. (WebCore::InspectorResource::Changes::Changes): Added new class to track
resource changes.
(WebCore::InspectorResource::Changes::hasChange): Added.
(WebCore::InspectorResource::Changes::set): Added.
(WebCore::InspectorResource::Changes::clear): Added.
(WebCore::InspectorResource::Changes::setAll): Added.
(WebCore::InspectorResource::Changes::clearAll): Added.
- 2:17 PM Changeset in webkit [42154] by
-
- 3 edits4 adds in trunk
2009-04-01 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
Ensure the right click doesn't deselect text under it. This was
happening in the Chromium and GTK+ ports because they don't select
the text under the cursor on right click.
This was regressed in r41715, https://bugs.webkit.org/show_bug.cgi?id=19737
Test: fast/events/context-no-deselect.html
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent):
- 12:48 PM Changeset in webkit [42153] by
-
- 3 edits1 add in trunk
2009-04-01 Christian Dywan <christian@twotoasts.de>
Reviewed by Holger Freyther.
Unit test WebKitDownload
http://bugs.webkit.org/show_bug.cgi?id=24844
- GNUmakefile.am: Add a unit test for downloading.
2009-04-01 Christian Dywan <christian@twotoasts.de>
Reviewed by Holger Freyther.
- tests/testdownload.c: Added. (test_webkit_download_create): (main): Add an initial unit test for downloading.
- 12:32 PM Changeset in webkit [42152] by
-
- 9 edits in trunk
2009-04-01 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=24990
Put SECTORDER_FLAGS into xcconfig files.
- 12:26 PM Changeset in webkit [42151] by
-
- 2 edits in trunk/WebCore
2009-04-01 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Need to use toRenderBoxModelObject(), not toRenderBox(), to test for layer()
when getting the transform.
- rendering/RenderObject.cpp: (WebCore::RenderObject::transformFromContainer):
- 9:55 AM Changeset in webkit [42150] by
-
- 3 edits in trunk/WebKit/gtk
2009-04-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed typo fixes, and naming normalization in the
documentation.
- docs/webkitenvironment.xml:
- webkit/webkitwebview.cpp:
- 9:37 AM Changeset in webkit [42149] by
-
- 2 edits in trunk
2009-04-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed build fix. Fix make distcheck, after the gtk-doc
integration.
- GNUmakefile.am:
- 8:58 AM QtWebKitTodo edited by
- (diff)
- 4:41 AM QtWebKitTodo edited by
- (diff)
Mar 31, 2009:
- 11:43 PM Changeset in webkit [42148] by
-
- 3 edits in trunk/WebCore
2009-03-31 Darin Adler <Darin Adler>
Rolled out that last change until I can investigate the regression test failures it seems
to have caused.
- dom/PositionIterator.cpp: (WebCore::PositionIterator::decrement):
- dom/PositionIterator.h: (WebCore::PositionIterator::PositionIterator):
- 9:41 PM Changeset in webkit [42147] by
-
- 3 edits in trunk/WebCore
2009-03-31 Darin Adler <Darin Adler>
Reviewed by Eric Seidel.
Bug 24621: PositionIterator doesn't iterate "after last child" positions when going backwards
https://bugs.webkit.org/show_bug.cgi?id=24621
- dom/PositionIterator.cpp: (WebCore::PositionIterator::decrement): Make sure that when the parent has no children, we don't ever use Position::uncheckedPreviousOffset. This is consistent with the forward iterator, but also should never arise because of the fix below.
- dom/PositionIterator.h: (WebCore::PositionIterator::PositionIterator): Fixed so m_offset will always be 0 when the passed-in node has no children. Like the change above, this is consistent with the rest of the class, although in the long run I think it's a bit strange to treat a <p> element with no children differently than a <p> element with children.
- 5:13 PM Changeset in webkit [42146] by
-
- 2 edits in trunk/WebKitTools
Make resolve-ChangeLogs -f work when the working tree has spaces in its path
Reviewed by Mark Rowe and David Kilzer.
- Scripts/resolve-ChangeLogs: (sub fixMergedChangeLogs): Quote the path to resolve-ChangeLogs in case it contains spaces.
- 3:57 PM Changeset in webkit [42145] by
-
- 5 edits in trunk/WebKit/mac
2009-03-31 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
WebKit side of <rdar://problem/6500266>.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::wheelEvent): Send the event.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView scrollWheel:]): Call NetscapePluginInstanceProxy::wheelEvent. If the plug-in processed the event, don't call super.
- Plugins/Hosted/WebKitPluginHost.defs: Add definition.
- 3:13 PM Changeset in webkit [42144] by
-
- 2 edits in trunk/WebCore
2009-03-31 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=24965
Bug 24965: HTMLMediaElement: network state changes can be missed
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): Always update m_networkState when the state changes, even when no event needs to be fired.
- 2:55 PM Changeset in webkit [42143] by
-
- 5 edits in trunk
2009-03-31 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=24964
Bug 24964: HTMLMediaElement: 'waiting' event may fire twice
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Only fire 'waiting' event once when ready state drops below HAVE_FUTURE_DATA.
2009-03-31 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=24964
Bug 24964: HTMLMediaElement: 'waiting' event may fire twice
- http/tests/media/video-play-stall.html: Fail if 'waiting' fires more than once.
- media/video-test.js: Fix a typo. (failTest):
- 2:39 PM Changeset in webkit [42142] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=24777
WebKit tools are broken on Tiger
- Scripts/webkitdirs.pm: Don't use arch command with options on Tiger.
- 2:26 PM Changeset in webkit [42141] by
-
- 9 edits2 adds in trunk
2009-03-31 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=24846
Bug 24846: HTMLMediaElement should implement 'autobuffer' attribute
Add 'autobuffer' attrubute to media element. 'autobuffer' is a hint that
the author recommends downloading the entire resource optimistically, so the
attribute is made available to the media engine to use if it is able.
Test: media/video-dom-autobuffer.html
- html/HTMLAttributeNames.in: Add autobuffer.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseMappedAttribute): New. (WebCore::HTMLMediaElement::autobuffer): Ditto. (WebCore::HTMLMediaElement::setAutobuffer): Ditto.
- html/HTMLMediaElement.h: Declare autobuffer and setAutobuffer.
- html/HTMLMediaElement.idl: Add autobuffer.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): Initialize m_autobuffer. (WebCore::MediaPlayer::autobuffer): New. (WebCore::MediaPlayer::setAutobuffer): Ditto.
- platform/graphics/MediaPlayer.h: Declare m_autobuffer, autobuffer and setAutobuffer
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setAutobuffer): Declare setAutobuffer.
2009-03-31 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=24846
Bug 24846: HTMLMediaElement should implement 'autobuffer' attribute
- media/video-dom-autobuffer-expected.txt: Added.
- media/video-dom-autobuffer.html: Added.
- 1:24 PM Changeset in webkit [42140] by
-
- 2 edits in trunk/WebKit/mac
2009-03-31 Darin Adler <Darin Adler>
Reviewed by Adele Peterson.
<rdar://problem/6740581> REGRESSION (r41793): Page Down and Page Up don’t work in Leopard Mail
- WebView/WebHTMLView.mm: (-[WebResponderChainSink tryToPerform:with:]): Added. Without this we would think we had handled an event when we actually hadn't. Specifically, when -[WebFrameView scrollPageDown:] calls tryToPerform on the next responder.
- 1:23 PM Changeset in webkit [42139] by
-
- 2 edits in trunk/WebCore
2009-03-31 Craig Schlenter <craig.schlenter@gmail.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=24550
Check return value of vasprintf. This should keep gcc 4.3.3
happy rather than have it complain about attribute warn_unused_result.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::error):
- 1:11 PM Changeset in webkit [42138] by
-
- 2 edits in trunk/WebCore
2009-03-31 Dean Jackson <dino@apple.com>
Style guide violation!
- loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):
- 1:05 PM Changeset in webkit [42137] by
-
- 2 edits in trunk/WebCore
2009-03-31 Dean Jackson <dino@apple.com>
Fix Tiger build.
- loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):
- 12:56 PM Changeset in webkit [42136] by
-
- 2 adds in trunk/WebCore/bindings/v8
Fixing previous commit - forgot to 'git add' new files.
- 12:55 PM Changeset in webkit [42135] by
-
- 1 edit in trunk/WebCore/ChangeLog
2009-03-31 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
Upstream V8DOMMap for v8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=24951
- bindings/v8/V8DOMMap.cpp: Added.
- bindings/v8/V8DOMMap.h: Added.
- 12:50 PM Changeset in webkit [42134] by
-
- 2 edits in trunk/WebCore
2009-03-31 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
Spacebar didn't play/pause in standalone MediaDocument
- loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):
- 12:10 PM Changeset in webkit [42133] by
-
- 2 edits in trunk/WebCore
2009-03-31 Alpha Lam <hclam@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24901
Added the following methods to MediaPlayerPrivate for Chromium port.
void sizeChanged();
void rateChanged();
void durationChanged();
The above changes are to reflect changes in MediaPlayer.cpp.
More details can be found in the original changeset.
http://trac.webkit.org/changeset/41907
- platform/graphics/chromium/MediaPlayerPrivateChromium.h:
- 9:54 AM Changeset in webkit [42132] by
-
- 1 edit1 add in trunk/WebKitTools
2009-03-31 Darin Adler <Darin Adler>
- Scripts/add-include: Added.
- 9:46 AM Changeset in webkit [42131] by
-
- 4 edits in trunk/WebCore
2009-03-31 Rafael Weinstein <rafaelw@chromium.org>
Reviewed by Eric Seidel.
Special-case drawing text-shadow on win32, to let GDI draw in cases
when both fill & shadow color are opaque and the shadow has no blur.
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawComplexText):
- platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleDrawTextShadow): (WebCore::windowsCanHandleTextDrawing):
- platform/graphics/skia/SkiaFontWin.h:
- 9:21 AM Changeset in webkit [42130] by
-
- 4 edits in trunk/WebCore
2009-03-31 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Darin Fisher.
r42055 removed some functions in FrameLoader used by Chrome,
this CL backs out some of those changes to unbreak the Chrome build.
- WebCore.base.exp:
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- 9:13 AM Changeset in webkit [42129] by
-
- 3 edits in trunk/WebCore
2009-03-31 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Darin Adler.
Build fixes for Chromium.
- dom/Document.h:
- platform/chromium/ClipboardChromium.cpp: (WebCore::imageToMarkup):
- 5:42 AM QtWebKitTodo edited by
- (diff)
- 3:26 AM Changeset in webkit [42128] by
-
- 2 edits in trunk/WebCore
2009-03-31 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Qt build.
- 1:11 AM QtWebKitTodo edited by
- (diff)
- 12:55 AM QtWebKitTodo edited by
- (diff)
- 12:02 AM Changeset in webkit [42127] by
-
- 2 edits in trunk/WebKitTools
Fix use of incorrect constant.
- BuildSlaveSupport/built-product-archive:
Mar 30, 2009:
- 11:29 PM Changeset in webkit [42126] by
-
- 1 edit1 add in trunk/WebKitTools
Add a script in support of the new build.webkit.org configuration.
Rubber-stamped by Stephanie Lewis.
- BuildSlaveSupport/built-product-archive: Added.
- 8:21 PM Changeset in webkit [42125] by
-
- 3 edits in trunk/WebKit/gtk
2009-03-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
Updated gtk-doc configuration files for the 1.1.1, 1.1.2, 1.1.3,
and 1.1.4 versions of WebKitGTK+.
- docs/webkitgtk-docs.sgml:
- docs/webkitgtk-sections.txt:
- 8:16 PM Changeset in webkit [42124] by
-
- 7 edits1 add in trunk/WebKit/gtk
2009-03-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=17045
[GTK] Documentation
Added header documentation for WebKitWebNavigationAction and
WebKitWebPolicyDecision.
Added missing documentation pieces for WebKitSoupAuthDialog,
WebKitDownload and WebKitWebPolicyDecision.
Wrote a section about using the WEBKIT_DEBUG environment variable.
- docs/GNUmakefile.am:
- docs/webkitenvironment.xml: Added.
- docs/webkitgtk-docs.sgml:
- webkit/webkitdownload.cpp:
- webkit/webkitsoupauthdialog.c:
- webkit/webkitwebnavigationaction.cpp:
- webkit/webkitwebpolicydecision.cpp:
- 7:41 PM Changeset in webkit [42123] by
-
- 5 edits2 adds in trunk
2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
Integrate gtk-doc into the Gtk+ buildsystem.
Based on original work by Holger Freyther.
Integrate gtk-doc into our buildsystem. We are forced to
use recursive make for gtk-doc itself as the to be installed
gtk-doc.make (done by gtkdocize) is not working in a non
recursive environment.
The documentation can only be generated when srcdir == builddir.
In all other cases the generated files will not be found. This
limitation can be found in pango and gtk+ as well. There is no
easy way around. The resulting html documentation will be saved
in the srcdir as well.
- docs/GNUmakefile.am: Added.
- docs/version.xml.in: Added.
- docs/webkitgtk-docs.sgml:
- 7:37 PM Changeset in webkit [42122] by
-
- 7 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Add events to allow apps to override handling for JS prompts and
window object cleared events.
https://bugs.webkit.org/show_bug.cgi?id=24948
- 7:29 PM Changeset in webkit [42121] by
-
- 2 edits in trunk/WebCore
Don't create CFDataRef with a fixed size.
Fixes synchronous XMLHTTPRequests on Windows.
Reviewed by Ada Chan.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::WebCoreSynchronousLoader::didReceiveData):
- 5:19 PM Changeset in webkit [42120] by
-
- 4 edits2 adds in trunk
WebCore:
2009-03-30 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 24594: PolicyDelegate NavigationAction is WebNavigationTypeOther instead of WebNavigationTypeReload
https://bugs.webkit.org/show_bug.cgi?id=24594
rdar://problem/6682110
Test: fast/loader/reload-policy-delegate.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadWithDocumentLoader): Set the triggering action here where we know it's the policy loader and can use m_policyLoadType rather than letting it get set inside checkNavigationPolicy.
LayoutTests:
2009-03-30 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 24594: PolicyDelegate NavigationAction is WebNavigationTypeOther instead of WebNavigationTypeReload
https://bugs.webkit.org/show_bug.cgi?id=24594
rdar://problem/6682110
- fast/frames/resources/iframe-focus.html: Removed bogus but harmless "layoutTestController.loadCount" code.
- fast/loader/reload-policy-delegate-expected.txt: Added.
- fast/loader/reload-policy-delegate.html: Added.
- 5:17 PM Changeset in webkit [42119] by
-
- 3 edits in trunk/WebKitTools
2009-03-30 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Make policy-delegate logging work even for local files by processing the URLs as we
do for other delegates.
- DumpRenderTree/mac/PolicyDelegate.mm: (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Use _drt_descriptionSuitableForTestResult on the URL.
- DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::decidePolicyForNavigationAction): Use urlSuitableForTestResult on the URL.
- 3:49 PM Changeset in webkit [42118] by
-
- 2 edits in trunk/WebCore
<rdar://problem/5838871> CrashTracer: 1483 crashes Quicklooking
in Finder (painting without up to date layout)
Reviewed by Dan Bernstein.
- page/FrameView.cpp: (WebCore::FrameView::paintContents): Add an early return when painting is attempted when layout is needed.
- 1:14 PM Changeset in webkit [42117] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.4
Tagging WebKitGTK+ 1.1.4.
- 12:59 PM Changeset in webkit [42116] by
-
- 2 edits in trunk/WebCore
2009-03-30 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Simon Fraser.
Sort alphabetically.
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- 11:33 AM Changeset in webkit [42115] by
-
- 2 edits in trunk/WebCore
2009-03-30 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Simon Fraser.
Build fixes for building --3d-rendering and --no-svg
- rendering/RenderLayerBacking.cpp:
- 11:27 AM Changeset in webkit [42114] by
-
- 2 edits in trunk/WebKitLibraries
2009-03-30 Steve Falkenburg <sfalken@apple.com>
Bump version to 530.
- win/tools/scripts/VERSION:
- 11:21 AM Changeset in webkit [42113] by
-
- 2 edits in trunk/WebKit/gtk
2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Documenting what changed since the 1.1.3 release, in
the GTK+ port.
- NEWS:
- 11:04 AM Changeset in webkit [42112] by
-
- 10 edits in trunk
2009-03-30 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Simon Fraser.
Build fixes when building --no-svg
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add missing CSS properties
- css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Handle unused param
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Add missing CSS properties
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Add missing CSS properties
- dom/Node.cpp: (WebCore::updateSVGElementInstancesAfterEventListenerChange): Handle unused param
- platform/graphics/Font.cpp: (WebCore::Font::floatWidth): Handle unused param
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): Handle unused param
2009-03-30 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Simon Fraser.
Build fixes when building --no-svg
DOMHTMLFrameElementPrivate.h and DOMHTMLIFrameElementPrivate.h are only available with ENABLE_SVG.
- MigrateHeaders.make:
- 10:46 AM Changeset in webkit [42111] by
-
- 2 edits in trunk
2009-03-30 Xan Lopez <xlopez@igalia.com>
Unreviewed: bump version to 1.1.4 for release.
- configure.ac:
- 10:41 AM Changeset in webkit [42110] by
-
- 2 edits in trunk/WebKit/gtk
2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Add information on the bug-fix-only 1.1.3 release.
- NEWS:
- 10:37 AM Changeset in webkit [42109] by
-
- 3 edits in trunk/WebKitTools
Windows build fix
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::waitForPolicyDelegate): Added this empty stub.
- DumpRenderTree/win/WorkQueueItemWin.cpp: (LoadItem::invoke): (ScriptItem::invoke): Changed to use data members instead of removed member functions.
- 10:26 AM Changeset in webkit [42108] by
-
- 2 edits in trunk/WebCore
2009-03-30 Darin Adler <Darin Adler>
Reviewed by Adam Roben.
Bug 24916: REGRESSION: NavigationAction policy dispatch broken
https://bugs.webkit.org/show_bug.cgi?id=24916
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL): Rearrange the code so that the "event" PassRefPtr is not used twice. This also optimizes the case where a frame name is specified, but it's the name of the frame being loaded. Also called release in all the final uses of FormState.
- 10:22 AM Changeset in webkit [42107] by
-
- 24 edits in trunk/WebCore
2009-03-30 Darin Adler <Darin Adler>
Reviewed by Adam Roben.
Bug 24937: NamedNodeMap and NamedAttrMap should not be separate classes
https://bugs.webkit.org/show_bug.cgi?id=24937
Also should fix the Windows COM bindings build.
- bindings/scripts/CodeGeneratorJS.pm: Removed special case for NamedNodeMap.
- bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- dom/NamedAttrMap.h: Renamed class from NamedAttrMap to NamedNodeMap and removed NamedNodeMap base class. Made the NamedNodeMap functions all public and non-virtual. Removed virtualLength.
- dom/NamedNodeMap.h: Replaced file with just an include of NamedAttrMap.h. As a follow up we will rename the NamedAttrMap files and remove this file.
- bindings/js/JSNamedNodesCollection.cpp: Renamed from NamedAttrMap to NamedNodeMap.
- dom/Attr.h: Ditto.
- dom/Attribute.h: Ditto.
- dom/Document.cpp: (WebCore::Document::importNode): Ditto.
- dom/Element.cpp: (WebCore::Element::attributes): Ditto. (WebCore::Element::setAttributeMap): Ditto. (WebCore::Element::createAttributeMap): Ditto. (WebCore::Element::insertedIntoDocument): Ditto. (WebCore::Element::removedFromDocument): Ditto. (WebCore::Element::openTagStartToString): Ditto. (WebCore::Element::removeAttributeNode): Ditto. (WebCore::Element::getAttributeNode): Ditto. (WebCore::Element::getAttributeNodeNS): Ditto. (WebCore::Element::hasAttribute): Ditto. (WebCore::Element::hasAttributeNS): Ditto. (WebCore::Element::normalizeAttributes): Ditto.
- dom/Element.h: Ditto.
- dom/NamedAttrMap.cpp: (WebCore::NamedNodeMap::detachAttributesFromElement): Ditto. (WebCore::NamedNodeMap::~NamedNodeMap): Ditto. (WebCore::NamedNodeMap::isMappedAttributeMap): Ditto. (WebCore::NamedNodeMap::getNamedItem): Ditto. (WebCore::NamedNodeMap::getNamedItemNS): Ditto. (WebCore::NamedNodeMap::removeNamedItem): Ditto. (WebCore::NamedNodeMap::removeNamedItemNS): Ditto. (WebCore::NamedNodeMap::setNamedItem): Ditto. (WebCore::NamedNodeMap::item): Ditto. (WebCore::NamedNodeMap::getAttributeItem): Ditto. (WebCore::NamedNodeMap::clearAttributes): Ditto. (WebCore::NamedNodeMap::detachFromElement): Ditto. (WebCore::NamedNodeMap::setAttributes): Ditto. (WebCore::NamedNodeMap::addAttribute): Ditto. (WebCore::NamedNodeMap::removeAttribute): Ditto. (WebCore::NamedNodeMap::mapsEquivalent): Ditto.
- dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::clearAttributes): Ditto.
- dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::NamedMappedAttrMap): Ditto.
- dom/Node.cpp: (WebCore::Node::dumpStatistics): Ditto. (WebCore::Node::isEqualNode): Ditto. (WebCore::Node::isDefaultNamespace): Ditto. (WebCore::Node::lookupNamespaceURI): Ditto. (WebCore::Node::lookupNamespacePrefix): Ditto. (WebCore::Node::compareDocumentPosition): Ditto.
- dom/Node.h: Ditto.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::XMLTokenizer): Ditto.
- editing/ApplyStyleCommand.cpp: (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan): Ditto. (WebCore::isEmptyFontTag): Ditto. (WebCore::areIdenticalElements): Ditto.
- editing/markup.cpp: (WebCore::appendStartMarkup): Ditto. (WebCore::completeURLs): Ditto.
- html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Ditto.
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Ditto.
- svg/SVGAnimatedProperty.h: (WebCore::synchronizeProperty): Ditto.
- xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::evaluate): Ditto.
- xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Ditto.
- 9:35 AM Changeset in webkit [42106] by
-
- 2 edits in trunk/WebCore
2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=24750
[GTK] requests download instead of displaying page
Use soup facilities to append parameters to the content type, to
make that more robust;
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
- 9:24 AM Changeset in webkit [42105] by
-
- 4 edits in trunk/WebCore
<rdar://problem/6735683> Move SECTORDER_FLAGS from Xcode project to WebCore.xcconfig
Reviewed by Timothy Hatcher, Mark Rowe and Darin Adler.
- Configurations/Base.xcconfig: Moved Production definition of SECTORDER_FLAGS to here from Xcode project file.
- Configurations/DebugRelease.xcconfig: Override SECTORDER_FLAGS in Base.xcconfig to the empty string since it is not used for Debug and Release configurations.
- WebCore.xcodeproj/project.pbxproj: Removed SECTORDER_FLAGS.
- 8:58 AM Changeset in webkit [42104] by
-
- 4 edits in trunk/WebKit/win
Build fixes after recent FrameLoader changes
- WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): Updated to match urlSelected's current signature. We pass true for the userGesture parameter, since the user must have selected this item from the context menu.
- WebCoreSupport/WebFrameLoaderClient.cpp: Removed loadURLIntoChildFrame. (WebFrameLoaderClient::createFrame): Changed to call FrameLoader::loadURLIntoChildFrame. This probably should have been done way back around r31281 when that function was added.
- WebCoreSupport/WebFrameLoaderClient.h: Removed loadURLIntoChildFrame.
- 8:58 AM Changeset in webkit [42103] by
-
- 2 edits in trunk/WebCore
Windows build fix after recent Node.idl changes
- bindings/scripts/CodeGeneratorCOM.pm: Touched this to force sources of classes that derive from Node to rebuild.
- 8:48 AM Changeset in webkit [42102] by
-
- 4 edits in trunk/WebKit/gtk
2009-03-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=24878
[GTK] Use GtkBinding system to handle key events in WebView
Use GtkBinding system for key events in WebKitWebView. Allows the
user to reconfigure the bindings and fixes a bunch of bugs along
the way (we were not checking modifier keys in most actions).
- webkit/webkitwebview.cpp: (webkit_web_view_move_cursor):
- webkit/webkitwebview.h:
- webkitmarshal.list:
- 8:22 AM Changeset in webkit [42101] by
-
- 2 edits in trunk/WebCore
Windows build fix
- svg/graphics/SVGImage.cpp: Added a missing #include.
- 7:49 AM Changeset in webkit [42100] by
-
- 7 edits in trunk/WebCore
2009-03-30 Mads Ager <ager@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=24879
Add frame accessor to Screen, Console, and BarInfo objects. Add type
accessor to BarInfo objects.
In the V8 JavaScript bindings, we need access to the frame and
type for already created Screen, Console, and BarInfo objects in
order to keep their wrappers alive across GCs.
- page/BarInfo.cpp: (WebCore::BarInfo::frame): Added. (WebCore::BarInfo::type): Added.
- page/BarInfo.h:
- page/Console.cpp: (WebCore::Console::frame): Added.
- page/Console.h:
- page/Screen.cpp: (WebCore::Screen::frame): Added.
- page/Screen.h:
- 5:21 AM QtWebKitJournal edited by
- (diff)
- 2:25 AM Changeset in webkit [42099] by
-
- 3 edits in trunk/WebKit/qt
Document that setHtml/setContent loads only the html/data immediately, not external objects.
2009-03-30 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Document that setHtml/setContent loads only the html/data immediately, not external objects.
- 2:13 AM Changeset in webkit [42098] by
-
- 2 edits in trunk/WebKitTools
2009-03-30 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk DRT build fix per changeset
http://trac.webkit.org/changeset/42082. Not reviewed.
- DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (LoadItem::invoke): (ScriptItem::invoke):
Mar 29, 2009:
- 7:49 PM Changeset in webkit [42097] by
-
- 2 edits in trunk/WebCore
2009-03-29 Darin Adler <Darin Adler>
Requested by Antti Koivisto.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Tweaked code to be a little clearer and added a better comment.
- 7:21 PM Changeset in webkit [42096] by
-
- 3 edits2 adds in trunk
WebCore:
2009-03-29 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23445: Copying certain hidden text causes a crash
https://bugs.webkit.org/show_bug.cgi?id=23445
rdar://problem/6512520
Test: editing/pasteboard/copy-display-none.html
- editing/markup.cpp: (WebCore::createMarkup): Added a check for the case where adjusting the start node moves the start of the selection past the end of the range entirely. If we try to iterate we'll never hit the end of the range and will probably crash iterating the rest of the document.
LayoutTests:
2009-03-29 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23445: Copying certain hidden text causes a crash
https://bugs.webkit.org/show_bug.cgi?id=23445
rdar://problem/6512520
- editing/pasteboard/copy-display-none-expected.txt: Added.
- editing/pasteboard/copy-display-none.html: Added.
- 6:59 PM Changeset in webkit [42095] by
-
- 3 edits in trunk/WebCore
2009-03-29 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 24672: ASSERTION FAILURE: !m_purgeableData in WebCore::CachedResource::data() saving a WebArchive
https://bugs.webkit.org/show_bug.cgi?id=24672
rdar://problem/6574263
I couldn't create a test case for this. In fact, the case in the bug doesn't exist any more,
but there is an Apple-internal website I was able to use to reproduce and fix.
- loader/CachedResource.h: Made makePurgeable public.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Call makePurgeable to make the resource non-purgeable so we can get its data if it hasn't yet been purged.
- 5:06 PM Changeset in webkit [42094] by
-
- 2 edits in trunk/WebCore
2009-03-29 Darin Adler <Darin Adler>
Fix build again.
- loader/EmptyClients.h: Fix typo in name of FormState.h.
- 4:53 PM Changeset in webkit [42093] by
-
- 2 edits in trunk/WebCore
2009-03-29 Darin Adler <Darin Adler>
Try to fix the release build.
- history/CachedPage.cpp: Make include unconditional, not debug-only.
- 4:51 PM Changeset in webkit [42092] by
-
- 2 edits in trunk/WebCore
Undo the previous build fix.
- 4:44 PM Changeset in webkit [42091] by
-
- 2 edits in trunk/WebCore
Fix build break.
- 4:29 PM Changeset in webkit [42090] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog.
- 4:29 PM Changeset in webkit [42089] by
-
- 3 edits in trunk/WebCore
2009-03-29 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=24926
Fix Chromium build break.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.
- 4:26 PM Changeset in webkit [42088] by
-
- 2 edits in trunk/WebCore
2009-03-29 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=24926
Fix Chromium build break.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.
- 11:09 AM Changeset in webkit [42087] by
-
- 2 edits in trunk/WebCore
2009-03-29 Darin Adler <Darin Adler>
Another attempt to fix the Qt build.
- WebCore.pro: Added CheckedRadioButtons.cpp.
- 11:00 AM Changeset in webkit [42086] by
-
- 3 edits in trunk/WebKit/qt
2009-03-29 Darin Adler <Darin Adler>
Try to fix Qt build.
- WebCoreSupport/EditorClientQt.cpp: Added include of HTMLElement.h.
- WebCoreSupport/FrameLoaderClientQt.cpp: Added include of FormState.h. (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement): Removed unneeded call to detachChildren, which is called by FrameLoader right after this. (WebCore::FrameLoaderClientQt::createFrame): Use loadURLIntoChildFrame as other platforms do in the corresponding functions.
- 10:31 AM Changeset in webkit [42085] by
-
- 2 edits in trunk/WebKitTools
2009-03-29 Darin Adler <Darin Adler>
- DumpRenderTree/qt/jsobjects.cpp: Rolled out changes to this file. Maybe this will fix Qt building of DumpRenderTree.
- 10:15 AM Changeset in webkit [42084] by
-
- 34 edits2 copies in trunk
WebCore:
2009-03-29 Darin Adler <Darin Adler>
Reviewed by Cameron Zwarich.
Bug 24921: remove include of HTMLFormElement.h from Document.h
https://bugs.webkit.org/show_bug.cgi?id=24921
- GNUmakefile.am: Added CheckedRadioButtons source files.
- WebCore.scons: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- WebCoreSources.bkl: Ditto.
- bindings/objc/PublicDOMInterfaces.h: Changed type of parentElement to Element.
- dom/CheckedRadioButtons.cpp: Copied from WebCore/html/HTMLFormElement.cpp. Removed all the code except for CheckedRadioButtons, and moved that out to be a namespace-level class instead of a member of HTMLFormElement.
- dom/CheckedRadioButtons.h: Copied from WebCore/html/HTMLFormElement.h. Removed all the code except for CheckedRadioButtons, and moved that out to be a namespace-level class instead of a member of HTMLFormElement.
- dom/Document.h: Removed unneeded includes, including HTMLFormElement.h. Added include of CheckedRadioButtons.h. Changed uses of CheckedRadioButtons class to use a namespace-level class instead of a member of HTMLFormElement.
- dom/Node.idl: Changed the type of parentElement from Node to Element for two reasons. 1) Node was incorrect, since parentElement returns an Element. 2) The bindings won't compile any more unless they know parentElement's return value is an Element due to include changes.
- html/HTMLFormElement.cpp: Moved definitions of the functions in the CheckedRadioButtons class to the new CheckedRadioButtons.cpp.
- html/HTMLFormElement.h: Moved definition of the CheckedRadioButtons class to the new CheckedRadioButtons.h.
- html/HTMLInputElement.cpp: (WebCore::checkedRadioButtons): Changed use of CheckedRadioButtons class to use a namespace-level class instead of a member of HTMLFormElement.
- page/Chrome.cpp: (WebCore::Chrome::createWindow): Tweaked formatting.
- css/CSSGrammar.y: Added newly-needed include.
- dom/Range.cpp: Ditto.
- editing/BreakBlockquoteCommand.cpp: Ditto.
- editing/CompositeEditCommand.cpp: Ditto.
- editing/InsertLineBreakCommand.cpp: Ditto.
- editing/ModifySelectionListLevel.cpp: Ditto.
- editing/RemoveFormatCommand.cpp: Ditto.
- editing/TextIterator.cpp: Ditto.
- editing/VisiblePosition.cpp: Ditto.
- loader/DocLoader.cpp: Ditto.
- page/AccessibilityRenderObject.cpp: Ditto.
- page/Page.cpp: Ditto.
- rendering/RenderBlock.cpp: Ditto.
- rendering/RenderLayer.cpp: Ditto.
- rendering/RenderObject.h: Ditto.
- storage/LocalStorageArea.cpp: Ditto.
- storage/SessionStorageArea.cpp: Ditto.
WebKit/mac:
2009-03-29 Darin Adler <Darin Adler>
Reviewed by Cameron Zwarich.
- Plugins/WebNullPluginView.mm: Added now-needed includes.
- WebView/WebHTMLRepresentation.mm: Ditto.
- WebView/WebHTMLView.mm: Ditto.
- 10:14 AM Changeset in webkit [42083] by
-
- 2 edits in trunk/LayoutTests
2009-03-29 Darin Adler <Darin Adler>
Reviewed by Cameron Zwarich.
- fast/forms/targeted-frame-submission.html: Fixes from review comments.
- 10:11 AM Changeset in webkit [42082] by
-
- 22 edits in trunk
WebKitTools:
2009-03-29 Darin Adler <Darin Adler>
Reviewed by Cameron Zwarich.
Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission
https://bugs.webkit.org/show_bug.cgi?id=24922
Don't rely on delegate methods to guess whether a queued step starts a load or not, because
script-triggered loads can't be detected that way. Instead have the steps themselves indicate
whether or not a load was triggered.
- DumpRenderTree/LayoutTestController.cpp: (queueLoadingScriptCallback): Added. Version for scripts that perform loads. (queueNonLoadingScriptCallback): Added. Version for scripts that do not perform loads. (LayoutTestController::staticFunctions): Replaced queueScript with queueLoadingScript and queueNonLoadingScript. (LayoutTestController::queueBackNavigation): Moved here since it's platform-independent now. (LayoutTestController::queueForwardNavigation): Ditto. (LayoutTestController::queueLoadingScript): Replacement for queueScript. Here since it's platform-independent. (LayoutTestController::queueNonLoadingScript): Ditto. (LayoutTestController::queueReload): Moved here since it's platform-independent now.
- DumpRenderTree/LayoutTestController.h: Ditto.
- DumpRenderTree/WorkQueue.cpp: (WorkQueue::processWork): Added. Shared by the different platform's work queue implementations.
- DumpRenderTree/WorkQueue.h: Ditto.
- DumpRenderTree/WorkQueueItem.h: Changed the invoke function to return true if the item started a load. Removed unused getter functions. Made invoke functions private. Added LoadingScriptItem and NonLoadingScriptItem, making ScriptItem an abstract base.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (processWork): Use the new WorkQueue::processWork function to implement the new rule.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
- DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (LoadItem::invoke): Return true. (ReloadItem::invoke): Ditto. (ScriptItem::invoke): Ditto. (BackForwardItem::invoke): Ditto.
- DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate processWork:]): Use the new WorkQueue::processWork function to implement the new rule.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
- DumpRenderTree/mac/WorkQueueItemMac.mm: (LoadItem::invoke): Return true. (ReloadItem::invoke): Ditto. (ScriptItem::invoke): Ditto. (BackForwardItem::invoke): Ditto.
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::processWork): Use the new WorkQueue::processWork function to implement the new rule. Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
- DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::processWork): Use the new WorkQueue::processWork function to implement the new rule.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
- DumpRenderTree/win/WorkQueueItemWin.cpp: (LoadItem::invoke): Return false when we fail, true when we succeed. (ReloadItem::invoke): Ditto. (ScriptItem::invoke): Ditto. (BackForwardItem::invoke): Ditto.
LayoutTests:
2009-03-29 Darin Adler <Darin Adler>
Reviewed by Cameron Zwarich.
Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission
https://bugs.webkit.org/show_bug.cgi?id=24922
- fast/forms/targeted-frame-submission.html: Changed test to wait until the subframe loads before moving on to the next test, using an onload attribute.
- http/tests/navigation/fallback-anchor-reload.html: Removed use of queueScript here for a script that can instead just be run immedidately.
- http/tests/navigation/onload-navigation-iframe-timeout.html: Changed test to wait until the subframe loads before moving on to the next test, using an onload attribute.
- http/tests/navigation/onload-navigation-iframe.html: Ditto.
- http/tests/navigation/resources/testcode.js: Use queueNonLoadingScript instead of queueScript for scripts that don't involve submitting a form. Use queueLoadingScript for scripts that do involve submitting a form.
- 8:37 AM Changeset in webkit [42081] by
-
- 4 edits2 adds in trunk
WebCore:
2009-03-29 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
<rdar://problem/6015407> attr parsing should allow only identifiers
Test: fast/css/attr-parsing.html
- css/CSSParser.cpp: (WebCore::CSSParser::parseContent): Allow only CSS_IDENT, and filter out identifiers that start with "-".
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): Added a case for CSS_ATTR so the test case works. This has the pleasant side effect of fixing a bug too.
LayoutTests:
2009-03-29 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
<rdar://problem/6015407> attr parsing should allow only identifiers
- fast/css/attr-parsing-expected.txt: Added.
- fast/css/attr-parsing.html: Added.
- 8:17 AM Changeset in webkit [42080] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-03-29 Darin Adler <Darin Adler>
Bug 12104: Native Slider: When the thumb's height is specified as a percentage, it is not centered properly
https://bugs.webkit.org/show_bug.cgi?id=12104
Landed the test case from this bug. The bug was fixed by the fix for bug 24740 below.
- fast/forms/range-thumb-height-percentage.html: Added.
- platform/mac/fast/forms/range-thumb-height-percentage-expected.checksum: Added.
- platform/mac/fast/forms/range-thumb-height-percentage-expected.png: Added.
- platform/mac/fast/forms/range-thumb-height-percentage-expected.txt: Added.
- 2:45 AM Changeset in webkit [42079] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6492712> Cross-origin redirects are not handled correctly.
Forgot to save the file after applying changes for review comments.
- 2:16 AM Changeset in webkit [42078] by
-
- 5 edits4 adds in trunk
Reviewed by Darin Adler.
<rdar://problem/6492712> Cross-origin redirects are not handled correctly.
Test: http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::WebCoreSynchronousLoader::willSendRequest): (WebCore::WebCoreSynchronousLoader::didReceiveResponse): (WebCore::WebCoreSynchronousLoader::didReceiveData): (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::WebCoreSynchronousLoader::didReceiveChallenge): (WebCore::WebCoreSynchronousLoader::load): Match Mac behavior more closely - we shouldn't rely on underlying library handling of synchronous requests.
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::willSendRequest): -[NSURLConnection cancel] doesn't fully cancel the connection if called from willSendRequest delegate method for a redirect.
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Match async behavior more closely.
Mar 28, 2009:
- 10:27 PM Changeset in webkit [42077] by
-
- 2 edits in trunk/WebKitTools
Always use wxGraphicsContext on Mac to ensure path, matrix, etc. support.
- 5:16 PM Changeset in webkit [42076] by
-
- 2 edits in trunk/WebCore
2009-03-28 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
Bug 24914: empty-string assertion crash when running storage tests
https://bugs.webkit.org/show_bug.cgi?id=24914
- storage/Database.cpp: (WebCore::Database::performOpenAndVerify): Don't store empty version strings in the map, since empty strings are per-thread.
- 2:16 PM Changeset in webkit [42075] by
-
- 2 edits in trunk/WebKit/gtk
2009-03-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=24790
[GTK] webkitsoupauthdialog.h lacks WEBKIT_API before function
Set the right visibility to the WebKitSoupAuthDialog get_type
function.
- webkit/webkitsoupauthdialog.h:
- 1:17 PM Changeset in webkit [42074] by
-
- 2 edits in trunk/WebKit/wx
wx build fix. Remove call to now private method.
- 11:43 AM Changeset in webkit [42073] by
-
- 4 edits in trunk/WebCore
2009-03-28 Dmitry Titov <dimich@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=24910
Fixes for Chromium build.
- bindings/v8/V8LazyEventListener.h: renamed IsInline() into virtualIsInline()
- bindings/v8/custom/V8CustomEventListener.h: ditto.
- dom/EventListener.h: used #if USE(JSC) to fix the build on non-JSC platform.
- 9:59 AM Changeset in webkit [42072] by
-
- 2 edits1 delete in trunk/WebCore
2009-03-28 Dimitri Glazkov <Dimitri Glazkov>
Not reviewed, correcting landing error.
https://bugs.webkit.org/show_bug.cgi?id=24812
Custom bindings should be in v8/custom, not v8.
- bindings/v8/V8HTMLDocumentCustom.cpp: Removed.
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: Moved from parent dir.
- 9:48 AM Changeset in webkit [42071] by
-
- 1 edit1 add in trunk/WebCore
2009-03-28 Mike Belshe <mike@belshe.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=24616
Add V8 custom bindings for DOMWindow.
- bindings/v8/custom/V8DOMWindowCustom.cpp: Added.
- 9:24 AM Changeset in webkit [42070] by
-
- 1 edit1 add in trunk/WebCore
2009-03-28 Mike Belshe <mike@belshe.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=24812
Add V8 custom bindings for HTMLDocument.
- bindings/v8/V8HTMLDocumentCustom.cpp: Added.
- 1:55 AM Changeset in webkit [42069] by
-
- 3 edits in trunk/WebKit/gtk
2009-03-28 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix. Not reviewed.
FrameLoader::loadURL and FrameLoader::detachChildren went private
per changes in http://trac.webkit.org/changeset/42055. Follow
Mac's behaviour and use FrameLoader::loadURLIntoChildFrame for
loadURL and FrameLoader::detachParent for detachChildrem.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):
- webkit/webkitwebview.cpp:
Mar 27, 2009:
- 10:11 PM Changeset in webkit [42068] by
-
- 2 edits in trunk/JavaScriptCore
Fix non-AllInOneFile builds.
- 9:04 PM Changeset in webkit [42067] by
-
- 3 edits1 add1 delete in trunk/LayoutTests
Update text-content-type-with-binary-extension.html to use a .sitx file of random data rather
than a .m4a to ensure that WebKit doesn't handle the resource as a full-frame media element if the network
layer sniffs it as audio/mp4 rather than application/octet-stream.
Rubber-stamped by Dan Bernstein.
- http/tests/loading/resources/.htaccess:
- http/tests/loading/resources/binaryData.m4a: Removed.
- http/tests/loading/resources/binaryData.sitx: Added.
- http/tests/loading/text-content-type-with-binary-extension.html:
- 9:04 PM Changeset in webkit [42066] by
-
- 1 edit in trunk/LayoutTests/platform/mac-snowleopard/Skipped
Fix syntax of Skipped file.
- 8:50 PM Changeset in webkit [42065] by
-
- 16 edits3 adds in trunk
Improve performance of Function.prototype.call
<https://bugs.webkit.org/show_bug.cgi?id=24907>
Reviewed by Gavin Barraclough
Optimistically assume that expression.call(..) is going to be a call to
Function.prototype.call, and handle it specially to attempt to reduce the
degree of VM reentrancy.
When everything goes right this removes the vm reentry improving .call()
by around a factor of 10.
- 7:54 PM Changeset in webkit [42064] by
-
- 2 edits in trunk/LayoutTests
Skip two plug-in tests that are failing due to <rdar://problem/6733642>.
Rubber-stamped by Oliver Hunt.
- platform/mac-snowleopard/Skipped:
- 7:46 PM Changeset in webkit [42063] by
-
- 3 edits2 copies4 moves1 add in trunk/LayoutTests
Land updated results for two SVG tests involving Geeza Pro.
Rubber-stamped by Dan Bernstein.
- platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum.
- platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png.
- platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt.
- platform/mac-leopard/svg/text/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.checksum.
- platform/mac-leopard/svg/text/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.png.
- platform/mac-leopard/svg/text/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.txt.
- platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
- platform/mac/svg/text/text-intro-05-t-expected.txt:
- 7:40 PM Changeset in webkit [42062] by
-
- 4 edits in trunk/WebCore
Fix two SVG test failures in 64-bit.
Reviewed by Sam Weinig.
getSubStringLength's arguments were declared as unsigned in the IDL and as signed long in the implementation.
This led to a value of -1 in JavaScript being converted to MAX_UINT in the bindings. In 32-bit this was
identical to -1 when interpeted as signed long, but in 64-bit it was still equal to MAX_UINT.
The solution for this is to use the IsIndex attribute on arguments that the SVG spec declares as "unsigned long"
but requires an exception be thrown when a negative value is passed. This results in the JS bindings handling the
check for a negative value and lets the implementation treat the arguments purely as unsigned values.
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::getNumberOfChars):
(WebCore::SVGTextContentElement::getSubStringLength):
(WebCore::SVGTextContentElement::getStartPositionOfChar):
(WebCore::SVGTextContentElement::getEndPositionOfChar):
(WebCore::SVGTextContentElement::getExtentOfChar):
(WebCore::SVGTextContentElement::getRotationOfChar):
(WebCore::SVGTextContentElement::getCharNumAtPosition):
(WebCore::SVGTextContentElement::selectSubString):
- svg/SVGTextContentElement.h:
- svg/SVGTextContentElement.idl:
- 5:49 PM Changeset in webkit [42061] by
-
- 3 edits in trunk/WebCore
2009-03-27 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Get mailto code out of FrameLoader.
- html/HTMLFormElement.cpp: (WebCore::transferMailtoPostFormDataToURL): Added. Factored out the mailto logic so HTMLFormElement::submit isn't full of ugly bits. This includes the part of the logic that involves transformeing the URL that was previously inside FrameLoader. (WebCore::HTMLFormElement::submit): Call transferMailtoPostFormDataToURL and also release the data for slightly less refcount churn.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Removed all the special casing for mailto, since HTMLFormElement now properly prepares both the URL and the form data.
- 5:41 PM Changeset in webkit [42060] by
-
- 5 edits in trunk/WebCore
Reviewed by Mark Rowe.
- fix <rdar://problem/6724514> A bit of OpenTypeUtilities cleanup
- platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): Changed to use EOTHeader. (WebCore::createFontCustomPlatformData): Ditto.
- platform/graphics/opentype/OpenTypeUtilities.cpp: (WebCore::EOTHeader::EOTHeader): Added. Initializes the buffer size to the size of an EOTPrefix. (WebCore::EOTHeader::updateEOTSize): Added. Updates the size field in the prefix. (WebCore::EOTHeader::appendBigEndianString): Changed the static appendBigEndianStringToEOTHeader() into this member function. (WebCore::EOTHeader::appendPaddingShort): Added. (WebCore::getEOTHeader): Changed to use EOTHeader.
- platform/graphics/opentype/OpenTypeUtilities.h: (WebCore::EOTHeader::size): (WebCore::EOTHeader::data): (WebCore::EOTHeader::prefix):
- platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): Changed to use EOTHeader. (WebCore::createFontCustomPlatformData): Ditto.
- 5:06 PM Changeset in webkit [42059] by
-
- 2 edits in trunk/WebKit
2009-03-27 Darin Adler <Darin Adler>
- StringsNotToBeLocalized.txt: Updated for recent changes.
- 5:06 PM Changeset in webkit [42058] by
-
- 2 edits in trunk/WebKitTools
2009-03-27 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
- Scripts/extract-localizable-strings: Fixed version check for perl 5.10 compatibility.
- 4:55 PM Changeset in webkit [42057] by
-
- 19 edits in trunk/LayoutTests
2009-03-27 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Made our mailto form submission tests work more reliably by using the new
layoutTestController.waitForPolicyDelegate function.
- fast/encoding/mailto-always-utf-8.html: Updated test to use waitForPolicyDelegate rather than relying on the form submission happening immediately.
- fast/forms/mailto/advanced-get.html: Ditto.
- fast/forms/mailto/advanced-put.html: Ditto.
- fast/forms/mailto/get-multiple-items-text-plain.html: Ditto.
- fast/forms/mailto/get-multiple-items-x-www-form-urlencoded.html: Ditto.
- fast/forms/mailto/get-multiple-items.html: Ditto.
- fast/forms/mailto/get-non-ascii-always-utf-8.html: Ditto.
- fast/forms/mailto/get-non-ascii-text-plain-latin-1.html: Ditto.
- fast/forms/mailto/get-non-ascii-text-plain.html: Ditto.
- fast/forms/mailto/get-non-ascii.html: Ditto.
- fast/forms/mailto/get-overwrite-query.html: Ditto.
- fast/forms/mailto/post-append-query.html: Ditto.
- fast/forms/mailto/post-multiple-items-multipart-form-data.html: Ditto.
- fast/forms/mailto/post-multiple-items-text-plain.html: Ditto.
- fast/forms/mailto/post-multiple-items-x-www-form-urlencoded.html: Ditto.
- fast/forms/mailto/post-multiple-items.html: Ditto.
- fast/forms/mailto/post-text-plain-with-accept-charset.html: Ditto.
- fast/forms/mailto/post-text-plain.html: Ditto.
- 4:55 PM Changeset in webkit [42056] by
-
- 15 edits in trunk/WebKitTools
2009-03-27 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Added waitForPolicyDelegate, a more-reliable way to make our mailto form submission
tests work.
- DumpRenderTree/AccessibilityController.cpp: (getFocusedElementCallback): Use static_cast instead of reinterpret_cast because there's no reason to use reinterpret_cast just to get from void* to a specific type. (getRootElementCallback): Ditto.
- DumpRenderTree/AccessibilityUIElement.cpp: (toAXElement): Ditto.
- DumpRenderTree/GCController.cpp: (collectCallback): Ditto. (collectOnAlternateThreadCallback): Ditto. (getJSObjectCountCallback): Ditto.
- DumpRenderTree/LayoutTestController.cpp: (many functions): Ditto. (waitForPolicyDelegateCallback): Added. (LayoutTestController::staticFunctions): Sorted functions by name. Added waitForPolicyDelegate.
- DumpRenderTree/LayoutTestController.h: Sorted functions by name. Added waitForPolicyDelegate.
- DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): Added code to reset the state of the policy delegate. (runTest): Added an additional call to resetWebViewToConsistentStateBeforeTesting just before loading an empty page. This prevents extra policy delegate calls from being logged.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::waitForPolicyDelegate): Added. Puts us into wait mode, and then tells the policy delegate to notify when done, then points the web view at the policy delegate.
- DumpRenderTree/mac/PolicyDelegate.h: Added setControllerToNotifyDone: method.
- DumpRenderTree/mac/PolicyDelegate.mm: (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Added code to do notifyDone if controllerToNotifyDone is set. (-[PolicyDelegate setControllerToNotifyDone:]): Added.
- DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): Added code to reset the state of the policy delegate. Also moved the call to resetUndoManager in here. (runTest): Removed the call to resetUndoManager (see above). Added an additional call to resetWebViewToConsistentStateBeforeTesting to match the Mac code.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setCustomPolicyDelegate): 0, not NULL.
- DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::PolicyDelegate): Initialize m_controllerToNotifyDone to 0. (PolicyDelegate::decidePolicyForNavigationAction): Added code to do notifyDone if m_controllerToNotifyDone is set.
- DumpRenderTree/win/PolicyDelegate.h: Added setControllerToNotifyDone and m_controllerToNotifyDone.
- 4:37 PM Changeset in webkit [42055] by
-
- 6 edits in trunk/WebCore
2009-03-27 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
To prepare for work on a form loading fix, remove some unused functions,
consolidate some functions, and make many more functions private in
FrameLoader.
- WebCore.base.exp: Remove some unused entry points, update another.
- dom/Document.cpp: (WebCore::Document::detach): Clear m_frame directly instead of using clearFramePointer.
- dom/Document.h: Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): Consolidate the two functions of this name into a single function. Also changed the event argument to be PassRefPtr<Event>. (WebCore::FrameLoader::submitForm): Changed the event argument to be PassRefPtr<Event>. (WebCore::FrameLoader::scheduleLocationChange): Call completeURL explicitly so we can remove the version of changeLocation that does completeURL for us. (WebCore::FrameLoader::redirectionTimerFired): Ditto. (WebCore::FrameLoader::loadURLIntoChildFrame): Set m_provisionalHistoryItem directly so we don't need a setProvisionalHistoryItem function. (WebCore::FrameLoader::canCachePageContainingThisFrame): Get at m_quickRedirectComing directly so we don't need a isQuickRedirectComing function. (WebCore::FrameLoader::logCanCacheFrameDecision): Ditto. (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Changed the event argument to be PassRefPtr<Event>. (WebCore::FrameLoader::loadURL): Move the logic of the continueLoadWithData function here because this is the only caller. If we want to make the resulting function smaller we should refactor some other way. Also streamlined the user-chosen encoding logic, but did not change what it does. (WebCore::FrameLoader::finishedLoadingDocument): Changed the event argument to be PassRefPtr<Event>. (WebCore::FrameLoader::loadPostRequest): Ditto. (WebCore::FrameLoader::receivedMainResourceError): Moved the logic from the didNotOpenURL function here, since this was the only caller.
- loader/FrameLoader.h: Removed include of FormState.h and used a forward declaration instead. Removed unneeded forward declation of Element. Moved many functions into the private section, and removed some other unused or uneeded functions.
- 4:23 PM Changeset in webkit [42054] by
-
- 4 edits2 adds in trunk
2009-03-27 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix https://bugs.webkit.org/show_bug.cgi?id=24303
Using keyboard select RTL text, Highlights goes to opposite direction from Firefox and IE.
Test: editing/selection/extend-selection.html
- editing/SelectionController.cpp: (WebCore::SelectionController::directionOfEnclosingBlock): Added (WebCore::SelectionController::modifyExtendingRight): Added. Currenctly implemented for character and word granularity, all other granularities are treated as "forward". (WebCore::SelectionController::modifyExtendingForward): Renamed modifyExtendingRightForward() to this. (WebCore::SelectionController::modifyExtendingLeft): Added. Currenctly implemented for character and word granularity, all other granularities are treated as "backward". (WebCore::SelectionController::modifyExtendingBackward): Renamed modifyExtendingLeftBackward() to this. (WebCore::SelectionController::modify): Change to call either the left/right or backward/forward methods depending on the 'dir' argument for extends.
- editing/SelectionController.h:
- 4:15 PM Changeset in webkit [42053] by
-
- 3 edits in trunk/WebKitTools
2009-03-27 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Fix for https://bugs.webkit.org/show_bug.cgi?id=24765
prepare-ChangeLog and svn-create-patch doesn't work with svn 1.6
- Scripts/prepare-ChangeLog:
- Scripts/svn-create-patch:
- 3:34 PM Changeset in webkit [42052] by
-
- 2 edits in trunk/WebCore
2009-03-27 John Abd-El-Malek <jam@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24836
Fix navigator.plugins.refresh(false) in Chromium.
- plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginData::refresh):
- 3:31 PM Changeset in webkit [42051] by
-
- 4 edits in trunk/WebCore
Make scrollLeft, scrollTop, scrollWidth, and scrollHeight
virtual to fix the broken layout tests from my last commit.
Reviewed by Mark Rowe.
- dom/Element.cpp: (WebCore::Element::scrollLeft): (WebCore::Element::scrollTop): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
- dom/Element.h:
- html/HTMLBodyElement.h:
- 2:34 PM Changeset in webkit [42050] by
-
- 2 edits in trunk/WebCore
Fix <https://bugs.webkit.org/show_bug.cgi?id=24876>.
Bug 24876: fast/forms/select-max-length.html times out in debug builds due to HTMLSelectElement::setLength being O(N2)
Reviewed by Sam Weinig.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setLength): Repeatedly calling remove to remove elements causes us to recalculate the list
items after each node is removed, leading to O(N2) behaviour. By inlining the batch removal in to setLength we can avoid
this gratuitous recalcuation.
- 1:45 PM Changeset in webkit [42049] by
-
- 2 edits in trunk/WebCore
2009-03-27 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
We don't support images for GtkCursors yet. We need a placeholder to avoid crashes.
I took crosshair to have a common behavior with firefox.
[GTK] SVG - Crash on setting the cursor icon
https://bugs.webkit.org/show_bug.cgi?id=24565
- platform/gtk/CursorGtk.cpp: (WebCore::Cursor::Cursor):
- 1:36 PM Changeset in webkit [42048] by
-
- 7 edits in trunk
Remove redundant attributes and functions from IDL files that have the
same attributes and functions defined in the super class.
Reviewed by Simon Fraser.
- WebCore.xcodeproj/project.pbxproj: Remove DOMHTMLBodyElementPrivate.h.
- bindings/objc/PublicDOMInterfaces.h: Remove focus and blur from DOMHTMLElement.
- html/HTMLBodyElement.idl: Remove scrollLeft, scrollTop, scrollWidth and scrollHeight.
- html/HTMLElement.idl: Remove blur and focus.
- 11:44 AM Changeset in webkit [42047] by
-
- 2 edits in trunk/WebKitTools/DumpRenderTree/mac
Fix the Mac DumpRenderTree build.
- 11:37 AM Changeset in webkit [42046] by
-
- 6 edits in trunk
Don't include substitute data URLs in global history redirect chains
WebCore:
Don't include substitute data URLs in global history redirect chains
<rdar://6690169>
Reviewed by Darin Adler.
This might be testable if:
- support were added to DRT for providing substitute data on failed loads
- support were added to DRT for dumping redirect chains
I tried doing the above and was still unable to make a test.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForStandardLoad): (WebCore::FrameLoader::updateHistoryForRedirectWithLockedBackForwardList): Call updateGlobalHistoryRedirectLinks only if the load succeeded (i.e., there is no unreachableURL). Previous the FrameLoaderClient implementations were unconditionally calling updateGlobalHistoryRedirectLinks from within updateGlobalHistory.
WebKit/mac:
Don't include substitute data URLs in global history redirect chains
<rdar://6690169>
Reviewed by Darin Adler.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Don't call updateGlobalHistoryRedirectLinks. FrameLoader calls this for us now. (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Added an assertion to help catch cases where we might be adding a substitute data URL into a redirect chain.
WebKit/win:
Don't include substitute data URLs in global history redirect chains
<rdar://6690169>
Reviewed by Darin Adler.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Don't call updateGlobalHistoryRedirectLinks. FrameLoader calls this for us now. (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Added an assertion to help catch cases where we might be adding a substitute data URL into a redirect chain.
- 11:27 AM Changeset in webkit [42045] by
-
- 2 edits in trunk/WebKit/mac
2009-03-27 Darin Adler <Darin Adler>
Reviewed by Adam Roben.
<rdar://problem/6541923> REGRESSION (r38629): Tab cycle in empty tab is broken
- WebView/WebHTMLView.mm: (-[WebHTMLView _wantsKeyDownForEvent:]): Only return YES when we have a Frame.
- 11:07 AM Changeset in webkit [42044] by
-
- 5 edits1 delete in trunk/WebCore
2009-03-27 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24861
Chromium port did not render decorations for <input type="search">.
This copies RenderThemeWin.*.
- css/themeChromiumWin.css: Removed.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumLinux::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumLinux::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumLinux::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumLinux::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumLinux::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumLinux::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumLinux::paintSearchFieldResultsButton):
- rendering/RenderThemeChromiumLinux.h: (WebCore::RenderThemeChromiumLinux::paintSearchField):
- rendering/RenderThemeChromiumWin.cpp: (WebCore::): (WebCore::RenderThemeChromiumWin::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumWin::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumWin::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumWin::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumWin::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumWin::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumWin::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumWin::paintSearchFieldResultsButton):
- rendering/RenderThemeChromiumWin.h: (WebCore::RenderThemeChromiumWin::paintSearchField):
- 11:02 AM Changeset in webkit [42043] by
-
- 7 edits4 adds in trunk
WebCore:
2009-03-27 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser
If an object has a self-painting layer, don't count it as part of a block's visual overflow.
This fix has only been made for block-level children. The inline-level case is still broken
(and covered by an existing bug).
Added fast/block/positioning/negative-rel-position.html
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesVertically):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition):
LayoutTests:
2009-03-27 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser
Test case for relative positioning bug.
- fast/block/positioning/negative-rel-position.html: Added.
- platform/mac/fast/block/positioning/negative-rel-position-expected.checksum: Added.
- platform/mac/fast/block/positioning/negative-rel-position-expected.png: Added.
- platform/mac/fast/block/positioning/negative-rel-position-expected.txt: Added.
- 11:00 AM Changeset in webkit [42042] by
-
- 2 edits in trunk/WebCore
2009-03-27 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6642221>
REGRESSION: With the Movie widget, movie trailer fails to load if movie had been previously viewed
Add a dashboard specific workaround so that we always create renderers for object elements, even if display:none is set.
I've filed <rdar://problem/6731022> against the Movies widget.
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):
- 10:53 AM Changeset in webkit [42041] by
-
- 5 edits in trunk/WebKit/mac
2009-03-27 Darin Adler <Darin Adler>
Reviewed by John Sullivan and Anders Carlsson.
<rdar://problem/5987442> Pasteboard not exposed to WebEditingDelegate for WebViewInsertActionPasted (needed for system services)
Added SPI to tell which pasteboard is currently being inserted.
I chose to put it on WebView to be forward-looking since we're migrating things
from WebHTMLView to WebView in the future.
- WebView/WebHTMLView.mm: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Add calls to _setInsertionPasteboard. (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
- WebView/WebView.mm: (-[WebViewPrivate dealloc]): Assert the pasteboard is nil. (-[WebViewPrivate finalize]): Ditto. (-[WebView _insertionPasteboard]): Return the pastebaord. (-[WebView _setInsertionPasteboard:]): Set the pasteboard.
- WebView/WebViewInternal.h: Added _setInsertionPasteboard.
- WebView/WebViewPrivate.h: Added _insertionPasteboard.
- 10:50 AM Changeset in webkit [42040] by
-
- 8 edits1 add in trunk
Expose new DOM methods as public Objective-C API.
WebCore:
2009-03-25 Timothy Hatcher <timothy@apple.com>
Expose new DOM methods as public Objective-C API.
<rdar://problem/5837350> Expose new DOM classes and methods
as public API (match the additions to the JavaScript DOM)
Reviewed by NOBODY (OOPS!).
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMHTML.h:
- bindings/objc/DOMPrivate.h:
- bindings/objc/PublicDOMInterfaces.h:
WebKit/mac:
2009-03-25 Timothy Hatcher <timothy@apple.com>
Expose new DOM methods as public Objective-C API.
<rdar://problem/5837350> Expose new DOM classes and methods
as public API (match the additions to the JavaScript DOM)
Reviewed by NOBODY (OOPS!).
- MigrateHeaders.make:
- 10:45 AM Changeset in webkit [42039] by
-
- 2 edits in trunk/WebCore
2009-03-27 Zack Rusin <zack@kde.org>
Reviewed by Simon Hausmann.
Fix propagation of fill rules when rendering paths in the Qt build.
- 10:40 AM Changeset in webkit [42038] by
-
- 3 edits in trunk/WebCore
2009-03-27 Zack Rusin <zack@kde.org>
Reviewed by Tor Arne Vestbø.
Fix text field theming in the Qt build with the KDE 4 Oxygen
style by adjusting the size vertically and horizontally to
set padding on the element equal to the width of the style painted border.
- 9:23 AM Changeset in webkit [42037] by
-
- 3 edits in trunk/JavaScriptCore
2009-03-27 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Bug 24884: Include strings.h for strcasecmp()
https://bugs.webkit.org/show_bug.cgi?id=24884
- 6:05 AM Changeset in webkit [42036] by
-
- 2 edits in trunk/WebCore
2009-03-27 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=24852
Build fix for GNU mode RVCT compilation
- 5:59 AM Changeset in webkit [42035] by
-
- 2 edits in trunk/WebKit/qt
2009-03-27 Erik L. Bunce <elbunce@xendom.com>
Reviewed by Simon Hausmann.
Fixes an incorrect case in tst_qwebpage.
- 5:50 AM Changeset in webkit [42034] by
-
- 2 edits in trunk/WebCore
2009-03-27 Erik L. Bunce <elbunce@xendom.com>
Reviewed by Simon Hausmann.
Make text of the writing direction items more user friendly.
- 5:47 AM Changeset in webkit [42033] by
-
- 2 edits in trunk/WebCore
2009-03-27 Erik L. Bunce <elbunce@xendom.com>
Reviewed by Simon Hausmann.
Fixed the Qt 4.4 Mac build with netscape plugins enabled.
- 4:54 AM Changeset in webkit [42032] by
-
- 4 edits in trunk/WebKit/qt
2009-03-27 Erik L. Bunce <elbunce@xendom.com>
Reviewed by Simon Hausmann.
Add new editing related QWebPage::WebActions
- Clipboard: PasteAndMatchStyle
- Formatting: RemoveFormat, ToggleStrikethrough, ToggleSubscript, and ToggleSuperscript
- List Editing: InsertUnorderedList, InsertOrderedList, Indent, Outdent
- Paragraph Justification: AlignCenter, AlignJustified, AlignLeft, AlignRight
Improved selection and editing tests.
Mar 26, 2009:
- 11:16 PM Changeset in webkit [42031] by
-
- 3 edits in trunk/LayoutTests
Reviewed by David Hyatt.
Update fast/repaint/lines-with-layout-delta.html pixel results.
Hyatt says it's a progression, blame him if it ain't.
- platform/mac/fast/repaint/lines-with-layout-delta-expected.checksum:
- platform/mac/fast/repaint/lines-with-layout-delta-expected.png:
- 10:19 PM Changeset in webkit [42030] by
-
- 2 edits in trunk/WebCore
Try and fix the Qt build.
- platform/text/TextEncodingDetectorNone.cpp:
(WebCore::detectTextEncoding):
- 9:56 PM Changeset in webkit [42029] by
-
- 2 edits in trunk/WebCore
2009-03-26 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=24874
24874: HTMLMediaElement: 'duration' defaults to NaN, deal with it
The 'duration' attribute is NaN when no media is available, so the
media element should take care when comparing with duration().
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Don't compare with duration when it is NaN. (WebCore::HTMLMediaElement::endedPlayback): Ditto.
- 9:30 PM Changeset in webkit [42028] by
-
- 6 edits2 moves1 delete in trunk/LayoutTests
Update layout test results for changes to Geeza Pro.
- platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Removed.
- platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
- platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum: Renamed from LayoutTests/platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum.
- platform/mac/fast/text/international/bidi-AN-after-L-expected.png: Renamed from LayoutTests/platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.png.
- platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
- platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
- platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
- platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
- 8:21 PM Changeset in webkit [42027] by
-
- 3 edits in trunk/WebCore
Fix the build.
- 7:51 PM Changeset in webkit [42026] by
-
- 4 edits in trunk/WebCore
2009-03-26 Jungshik Shin <jshin@chromium.org>
Reviewed by Cameron Zwarich.
- Fix the crash in setHintEncoding
- Fix build failures on Tiger and Qt. UnusedParam.h was not included by TextEncodingDetector{None,ICU}.cpp in the patch landed in r42023 for http://bugs.webkit.org/show_bug.cgi?id=16482
- loader/TextResourceDecoder.h: (WebCore::TextResourceDecoder::setHintEncoding):
- platform/text/TextEncodingDetectorICU.cpp:
- platform/text/TextEncodingDetectorNone.cpp:
- 6:27 PM Changeset in webkit [42025] by
-
- 2 edits in trunk/WebCore
2009-03-26 Simon Fraser <Simon Fraser>
Build fix when ACCELERATED_COMPOSITING is turned on.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::canUseDirectCompositing):
- 6:12 PM Changeset in webkit [42024] by
-
- 3 edits in trunk/WebCore
2009-03-26 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Change the terminology from "inner content layer" to "direct compositing"
for cases where we can push an image directly over to the compositing system,
without having to draw it.
Clean up much of the code which looks at style to determine if this is possible,
and fix some bugs when backgrounds change dynamically.
- rendering/RenderLayerBacking.cpp: (WebCore::hasBorderOutlineOrShadow): (WebCore::hasBoxDecorations): (WebCore::hasBoxDecorationsWithBackgroundImage): (WebCore::RenderLayerBacking::canBeSimpleContainerCompositingLayer): (WebCore::RenderLayerBacking::canUseDirectCompositing): (WebCore::RenderLayerBacking::detectDrawingOptimizations): (WebCore::RenderLayerBacking::rendererContentChanged): (WebCore::RenderLayerBacking::updateImageContents):
- rendering/RenderLayerBacking.h:
- 5:28 PM Changeset in webkit [42023] by
-
- 1 edit4 adds in trunk/WebCore
No additional review, committing previously reviewed files for build fix only.
Add files I missed when commiting Jungshik's patch in r42022.
https://bugs.webkit.org/show_bug.cgi?id=16482
- icu/unicode/ucsdet.h: Added.
- platform/text/TextEncodingDetector.h: Added.
- platform/text/TextEncodingDetectorICU.cpp: Added. (WebCore::detectTextEncoding):
- platform/text/TextEncodingDetectorNone.cpp: Added. (WebCore::detectTextEncoding):
- 5:01 PM Changeset in webkit [42022] by
-
- 18 edits in trunk
2009-03-26 Jungshik Shin <jshin@chromium.org>
Reviewed by Alexey Proskuryakov.
Add an encoding detector 'hook' to TextResourceDecoder.
- add |usesEncodingDetector| to Settings. It's off by default.
- add a new encoding source type |EncodingFromParent| to distinguish cases when the encoding is inherited from the parent frame from cases when it's actually auto-detected.
- add TextEncodingDetector* to platform/text. Currently, the only implementation uses ICU. Stub is added for ports that do not use ICU and a build on Tiger. Mac OS Tiger comes with ICU 3.2 that does not support encoding detector.
- add ucsdet.h to icu/unicode for ports using ICU.
Layout tests will be added once bug 20534 is fixed and a WebPreference
can be controlled in test_shell. With UsesEncodingDetector off, there
is no change to test.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCore/GNUmakefile.am
- WebCore/WebCore.pro
- WebCore/WebCore.scons
- WebCore/WebCoreSources.bkl
- WebCore.base.exp
- icu/unicode/ucsdet.h
- loader/FrameLoader.cpp: (WebCore::FrameLoader::write): turn on/off encoding detector depending on Settings and set hintEncoding of TextResourceDecoder to the parent frame encoding if necessary and the security policy allows refering to the parent frame encoding.
- loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::TextResourceDecoder): (WebCore::TextResourceDecoder::checkForCSSCharset): add check for EncodingFromParentFrame (WebCore::TextResourceDecoder::checkForHeadCharset): ditto (WebCore::TextResourceDecoder::shouldAutoDetect): (WebCore::TextResourceDecoder::decode): call encoding detector if shouldAutoDetect returns true. (WebCore::TextResourceDecoder::flush): if encoding is not determined by now, call encoding detector if shouldAutoDetect returns true.
- loader/TextResourceDecoder.h: (WebCore::TextResourceDecoder::): (WebCore::TextResourceDecoder::create): (WebCore::TextResourceDecoder::setHintEncoding): (WebCore::TextResourceDecoder::source):
- page/Settings.cpp: add m_usesEncodingDetector (WebCore::Settings::Settings): (WebCore::Settings::setUsesEncodingDetector):
- page/Settings.h: (WebCore::Settings::usesEncodingDetector):
- platform/text/TextEncodingDetector.h: Added.
- platform/text/TextEncodingDetectorICU.cpp: Added. (WebCore::detectTextEncoding):
- platform/text/TextEncodingDetectorNone.cpp: Added. (WebCore::detectTextEncoding):
- 4:50 PM Changeset in webkit [42021] by
-
- 13 edits in trunk/WebCore
2009-03-26 Darin Adler <Darin Adler>
Reviewed by Geoff Garen.
Removed code that casts EventListener down to derived classes
without type checking. A crash could happen if you added event
listeners with Objective-C and then manipulated the class with
JavaScript.
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::mark): Removed all the casts and used the markIfNotNull function and mark functions on EventListener instead.
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark): Ditto.
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark): Ditto.
- bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::mark): Ditto.
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::mark): Ditto.
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::mark): Ditto.
- bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): Used function, the new name for what used to be called listenerObj. (WebCore::JSAbstractEventListener::virtualIsInline): Renamed since this doesn't need to be virtual for callers who have a pointer to this class, not the base class. (WebCore::JSEventListener::function): Renamed from listenerObj. (WebCore::JSProtectedEventListener::function): Ditto.
- bindings/js/JSEventListener.h: Removed unneeded forward class declarations. Made all virtual functions private since there's no need to call any of them on a particular derived class, only on EventListener. Explicitly declare JSEventListener::mark as virtual since it's now overriding a function in the EventListener base class. Made JSProtectedEventListener::m_globalObject protected so the JSLazyEventListener derived class can use it directly instead of using a virtual function to get the pointer.
- bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Use m_globalObject instead of globalObject since the latter is a virtual function and there's no need to pay virtual function overhead. (WebCore::JSLazyEventListener::function): Renamed from listenerObj.
- bindings/js/JSLazyEventListener.h: Moved forward declaration of the Node class here from JSEventListener.h.
- bindings/scripts/CodeGeneratorJS.pm: Removed now-unneeded cast to JSEventListener when getting the script object from a listener.
- dom/EventListener.h: Added virtual function and mark functions so we can extract the JavaScript function object or mark a JavaScript event listener in a type safe manner.
- 4:25 PM Changeset in webkit [42020] by
-
- 4 edits in trunk/WebCore
2009-03-26 Peter Kasting <pkasting@google.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=24859
Use CSS file instead of code to adjust search field styling.
- css/themeWin.css:
- rendering/RenderThemeWin.cpp:
- rendering/RenderThemeWin.h:
- 3:53 PM Changeset in webkit [42019] by
-
- 10 edits2 copies in trunk/WebCore
2009-03-26 Darin Adler <Darin Adler>
Reviewed by Geoff Garen.
Split JSLazyEventListener out into its own separate source file.
We'll be removing JSAbstractEventListener and JSProtectedEventListener soon,
so leave those in the same file with JSEventListener.
- GNUmakefile.am: Added JSLazyEventListener.
- WebCore.pro: Ditto.
- WebCore.scons: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- WebCoreSources.bkl: Ditto.
- bindings/js/JSEventListener.cpp: Removed the JSLazyEventListener part. Removed unneeded includes. Removed incorrect ASSERT_CLASS_FITS_IN_CELL, since JSAbstractEventListener is not derived from JSCell.
- bindings/js/JSEventListener.h: Removed the JSLazyEventListener part and the now-unneeded include of PlatformString.h.
- bindings/js/JSLazyEventListener.cpp: Copied from bindings/js/JSEventListener.cpp. Kept only the JSLazyEventListener part. (WebCore::eventParameterName): Made this have internal linkage by adding "static". Also moved the default case out of the switch statement so we will get a warning if we omit any cases in the future.
- bindings/js/JSLazyEventListener.h: Copied from bindings/js/JSEventListener.h. Kept only the JSLazyEventListener part.
- bindings/js/ScriptController.cpp: Removed unneeded includes and sorted the remanining ones. Include JSLazyEventListener.h instead of JSEventListener.h.
- 3:31 PM Changeset in webkit [42018] by
-
- 15 edits in trunk
WebCore:
2009-03-26 Darin Adler <Darin Adler>
Reviewed by Geoff Garen.
Renamed JSUnprotectedEventListener to JSEventListener.
And related renames.
Soon Geoff will make all JavaScript event listeners use mark instead
of protect, so there's no need to emphasize "unprotected".
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::mark): (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener): (WebCore::JSDOMGlobalObject::jsEventListeners): (WebCore::JSDOMGlobalObject::jsInlineEventListeners):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener): (WebCore::JSEventListener::listenerObj): (WebCore::JSEventListener::globalObject): (WebCore::JSEventListener::clearGlobalObject): (WebCore::JSEventListener::mark):
- bindings/js/JSEventListener.h: (WebCore::JSEventListener::create):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark): (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
- bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::mark): (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::mark): (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::mark): (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/scripts/CodeGeneratorJS.pm: All just renaming.
WebKitTools:
2009-03-26 Darin Adler <Darin Adler>
Reviewed by Geoff Garen.
- Scripts/do-webcore-rename:Update for rename of JSUnprotectedEventListener to JSEventListener.
- 3:21 PM Changeset in webkit [42017] by
-
- 12 edits in trunk
WebCore:
2009-03-26 Darin Adler <Darin Adler>
Reviewed by Geoff Garen.
Renamed JSEventListener to JSProtectedEventListener.
And related renames.
Soon Geoff will make all JavaScript event listeners use mark instead
of protect, and so this class will be be obsolete. We will rename
JSUnrpotectedEventListener to JSEventListener in the next check-in,
since that one will remain.
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): (WebCore::JSDOMGlobalObject::findJSProtectedEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener): (WebCore::JSDOMGlobalObject::jsProtectedEventListeners): (WebCore::JSDOMGlobalObject::jsProtectedInlineEventListeners):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener):
- bindings/js/JSEventListener.cpp: (WebCore::JSProtectedEventListener::JSProtectedEventListener): (WebCore::JSProtectedEventListener::~JSProtectedEventListener): (WebCore::JSProtectedEventListener::listenerObj): (WebCore::JSProtectedEventListener::globalObject): (WebCore::JSProtectedEventListener::clearGlobalObject): (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::parseCode):
- bindings/js/JSEventListener.h: (WebCore::JSProtectedEventListener::create):
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener): All just renaming.
WebKitTools:
2009-03-26 Darin Adler <Darin Adler>
Reviewed by Geoff Garen.
- Scripts/do-webcore-rename: Update for rename of JSEventListener to JSProtectedEventListener. This includes all the related renames, but not that one because that one renames the file.
- 2:28 PM Changeset in webkit [42016] by
-
- 2 edits in trunk/JavaScriptCore
Copy testapi.js to $WebKitOutputDir on Windows
Part of Bug 24856: run-javascriptcore-tests should run testapi on
Windows
<https://bugs.webkit.org/show_bug.cgi?id=24856>
This matches what Mac does, which will help once we enable running
testapi from run-javascriptcore-tests on Windows.
Reviewed by Steve Falkenburg.
- JavaScriptCore.vcproj/testapi/testapi.vcproj: Copy testapi.js next to testapi.exe.
- 1:39 PM Changeset in webkit [42015] by
-
- 4 edits in trunk
Versioning.
- 1:38 PM Changeset in webkit [42014] by
-
- 1 copy in tags/Safari-6530.4
New tag.
- 1:35 PM Changeset in webkit [42013] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders Carlsson.
- fix <rdar://problem/6725042> BidiResolver::createBidiRunsForLine can create runs extending beyond the end
No test because Safari does not use this version of
createBidiRunsForLine() with the end iterator not pointing to the end
of the text run.
- platform/text/BidiResolver.h: (WebCore::BidiResolver::appendRun): Cap the end of the run at the end of the line and set the reachedEndOfLine flag. This mirrors the logic in the specialized version of appendRun() in bidi.cpp, which is why the problem did not show up in HTML. Also avoid creating empty runs.
- 1:18 PM Changeset in webkit [42012] by
-
- 2 edits in trunk/WebKitTools
Reduce run-webkit-tests's time out limit to 15 seconds (or 2.5 minutes under GuardMalloc)
The previous limit was 60 seconds (or 10 minutes under GuardMalloc).
There's no evidence that we need the limit to be this long, and having
it be so long just makes timed-out tests take forever to complete.
DRT's watchdog timer is 10 seconds, so still has time to fire before
run-webkit-tests will cut it off.
Reviewed by Simon Fraser.
- Scripts/run-webkit-tests: (sub readFromDumpToolWithTimer): Reduced the limit to 15 seconds (or 2.5 mintues under GuardMalloc).
- 1:10 PM Changeset in webkit [42011] by
-
- 6 edits in trunk/WebKitTools
Make DRT's watchdog timer actually work on Windows
We were previously trying to use a CFRunLoopTimer for the watchdog
timer on Windows. This doesn't work because we don't use a CFRunLoop
on the main thread on Windows.
This patch changes the watchdog timer on Windows be a normal Windows
timer.
Reviewed by Simon Fraser.
- DumpRenderTree/DumpRenderTree.h: Moved declaration of waitToDumpWatchdog from here...
- DumpRenderTree/mac/DumpRenderTreeMac.h: ...to here.
- DumpRenderTree/win/DumpRenderTree.cpp: (invalidateAnyPreviousWaitToDumpWatchdog): Added. This function cancels an existing watchdog timer. (dump): Call invalidateAnyPreviousWaitToDumpWatchdog. This will prevent watchdogs from previous tests firing during subsequent ones. This matches Mac's behavior.
- DumpRenderTree/win/DumpRenderTreeWin.h: Added a declaration of waitToDumpWatchdog.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (waitUntilDoneWatchdogFired): Converted this to be a Windows TIMERPROC. (LayoutTestController::setWaitToDump): Changed to use SetTimer instead of CFRunLoopAddTimer.
- 11:48 AM Changeset in webkit [42010] by
-
- 4 edits in trunk/WebKit/mac
2009-03-26 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
- Fix <rdar://problem/6687055> and <rdar://problem/6713639>.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCInvalidateRect): Call NetscapePluginInstanceProxy::invalidateRect.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::cleanup): Stop the request timer, set m_pluginView to nil.
(WebKit::NetscapePluginInstanceProxy::pluginHostDied):
No need to set m_pluginView to nil here anymore, it's now done in cleanup().
(WebKit::NetscapePluginInstanceProxy::performRequest):
(WebKit::NetscapePluginInstanceProxy::requestTimerFired):
Assert that the plug-in view is not nil.
(WebKit::NetscapePluginInstanceProxy::invalidateRect):
Call setNeedsDisplayInRect here.
- 11:34 AM Changeset in webkit [42009] by
-
- 6 edits10 adds in trunk
2009-03-26 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Tests: compositing/overflow/ancestor-overflow.html
compositing/overflow/parent-overflow.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h: (WebCore::ClipRects::infiniteRect): New static method that returns a large rect that is used by the clipping logic.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Use parentClipRects(), rather than calculateRects(), to compute the overflow rect that we'll use to create a masking layer for composited clipping.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::clippedByAncestor): Use parentClipRects() to see whether there's a layer between us and our compositing ancestor which applies clipping.
(WebCore::RenderLayerCompositor::clipsCompositingDescendants):
A layer which imposes clipping to its children doesn't have to be a stacking
context; it might be a normal flow layer; in either case, we can rely on the
hasCompositingDescendant() bit.
- 11:18 AM Changeset in webkit [42008] by
-
- 1 edit1 delete in trunk/WebKitLibraries
Remove SafariThemeConstants.h, which is now provided by WebKitSupportLibrary
- win/include/SafariTheme: Removed.
- win/include/SafariTheme/SafariThemeConstants.h: Removed.
- 10:05 AM Changeset in webkit [42007] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=24837
Escape key should dismiss select menu
Reviewed by Adam Roben.
- platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc):
- 9:12 AM Changeset in webkit [42006] by
-
- 2 edits in trunk/WebCore
Reviewed by Alexey Proskuryakov.
Make sure the script uses LF line endings even on Windows.
https://bugs.webkit.org/show_bug.cgi?id=24805
- 8:21 AM Changeset in webkit [42005] by
-
- 2 edits in trunk/WebKit/qt
2009-03-26 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Fix the documentation of the QLocale usage in userAgentForUrl.
- 8:06 AM Changeset in webkit [42004] by
-
- 2 edits in trunk/LayoutTests
2009-03-25 Brian Weinstein <bweinstein@gmail.com>
Update Windows skipped list based on failures in r41995, to try and make Windows build-bot green.
Reviewed by Adam Roben
- platform/win/Skipped:
- 7:26 AM Changeset in webkit [42003] by
-
- 4 edits in trunk/WebKit/win
Reviewed by Adam Roben.
- add close() to the WebView API.
- Interfaces/IWebView.idl:
- WebView.cpp: (WebView::close):
- WebView.h:
- 7:24 AM Changeset in webkit [42002] by
-
- 37 edits in trunk/WebCore
2009-03-26 Eli Fidler <eli.fidler@torchmobile.com>
Reviewed by George Staikos.
Remove warnings all over the place by making operator precedence
explicit in cases like x && y z. No functional change. - 4:43 AM Changeset in webkit [42001] by
-
- 2 edits in trunk/WebCore
2009-03-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=24804
[GTK] 401 responses cause rogue content to be loaded
Our soup code handles 401 responses itself, so we should not feed
the headers and data of those responses to the loader.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::gotChunkCallback):
- 2:31 AM Changeset in webkit [42000] by
-
- 3 edits in trunk/WebKit/qt
2009-03-20 Erik L. Bunce <elbunce@xendom.com>
Reviewed by Simon Hausmann.
Fix for InsertParagraphSeparator and InsertLineSeparator so that
QWebPage::action() creates QActions for them. Also make sure they get
updated appropriately.
- Api/qwebpage.cpp: (QWebPagePrivate::updateEditorActions): (QWebPage::action):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::textEditing):
Mar 25, 2009:
- 7:39 PM Changeset in webkit [41999] by
-
- 2 edits in trunk/JavaScriptCore
Fix exception handling for instanceof in the interpreter.
Reviewed by Geoff Garen
- 7:34 PM Changeset in webkit [41998] by
-
- 2 edits in trunk/JavaScriptCore
2009-03-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Fixed <rdar://problem/6724011> Write to freed memory in JSC::Label::deref
when reloading http://helpme.att.net/speedtest/
- bytecompiler/BytecodeGenerator.h: Reversed the declaration order for m_labelScopes and m_labels to reverse their destruction order. m_labelScopes has references to memory within m_labels, so its destructor needs to run first.
- 7:12 PM Changeset in webkit [41997] by
-
- 3 edits in trunk/WebCore
2009-03-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt and Darin Adler.
Fixed <rdar://problem/6603167> Crash in WebKit!JSC::JSGlobalObject::resetPrototype
during Stress test (#3 & #7 WER crashes for Safari 4 Beta)
The problem was that allocation of the global object would, for just a
moment, leave the global object's prototype unprotected from GC. This
bug doesn't apply to non-global DOM objects because their prototypes are
cached and marked by the global object.
No test case because the crashing condition is hard to deterministically
produce in a normal build, and in a Windows Release build with
COLLECT_ON_EVERY_ALLOCATION set to 1, existing tests crash/hang.
- bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow):
- bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript): Protect the global object's prototype from GC during construction, since the global object does not yet point to it, and therefore won't mark it.
- 6:38 PM Changeset in webkit [41996] by
-
- 9 edits10 adds in trunk
2009-03-25 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser
When using hardware compositing, some images can be directly
rendered by the hardware - no need to draw them into a separate
context, therefore saving memory.
Only images with certain style properties can be directly
composited - basically anything that is not a simple image requires
the usual rendering path (eg. if the image has borders).
Test: compositing/direct-image-compositing.html
- manual-tests/resources/simple_image.png: Added.
- manual-tests/simple-image-compositing.html: Added.
- platform/graphics/Image.h:
(WebCore::Image::startAnimation):
- move this to public
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
- poke compositing layer if image has changed
(WebCore::RenderImage::notifyFinished):
- let the compositing layer know that it can render the image
- rendering/RenderImage.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::rendererContentChanged):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::canUseInnerContentLayer): (WebCore::RenderLayerBacking::detectDrawingOptimizations): (WebCore::RenderLayerBacking::rendererContentChanged):
- rendering/RenderLayerBacking.h:
- code to hook up direct compositing of images where possible
- 4:41 PM Changeset in webkit [41995] by
-
- 2 edits in trunk/WebKitTools
Update test result search path for Windows now that it has updated versions of ICU, libxml2, and friends.
Rubber-stamped by Steve Falkenburg.
- Scripts/run-webkit-tests:
- 4:06 PM Changeset in webkit [41994] by
-
- 2 edits in trunk/WebKit/mac
2009-03-25 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6714964>
CrashTracer: [REGRESSION] 51 crashes in Safari at com.apple.WebKit ⢠WebNetscapePluginStream::deliverData + 775
Don't release m_deliveryData since it's a RetainPtr. Also, use adoptNS instead of releasing newDeliveryData manually.
- Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::deliverData):
- 3:37 PM Changeset in webkit [41993] by
-
- 8 edits in trunk/LayoutTests
2009-03-25 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Update layout test results for
https://bugs.webkit.org/show_bug.cgi?id=24809
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 3:24 PM Changeset in webkit [41992] by
-
- 2 edits in trunk/WebCore
2009-03-25 David Levin <levin@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium build fix. Fix #include in V8NodeFilterCondition.cpp due to the
rename of V8NodeFilter to V8NodeFilterCondition.
- bindings/v8/V8NodeFilterCondition.cpp:
- 3:15 PM Changeset in webkit [41991] by
-
- 5 edits in trunk/WebCore
Reviewed by Darin Adler.
Remove dead code and style cleanup
https://bugs.webkit.org/show_bug.cgi?id=24684
- html/CanvasStyle.cpp: (WebCore::CanvasStyle::CanvasStyle): Coverty was annoyed that we didn't initialize all of our members. I agree, but I didn't want to paste all 8 members each time, so I just cleaned up the existing constructors and left them.
- page/FocusController.cpp: (WebCore::FocusController::setFocusedNode): "node" was checked just above and is already known to be non-null
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::insertOnlyThisLayer): We were already using parentLayer w/o a NULL check above, so just add an explicit ASSERT and use it w/o NULL check (WebCore::RenderLayer::resize): element is already ASSERTed above, no need to null check it here
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addCell): currentCell.cell was just assigned to the value "cell" which is known to be non-null, no need to null check again.
- 3:14 PM Changeset in webkit [41990] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
Move ASSERT(foo) to before where foo-> is used
https://bugs.webkit.org/show_bug.cgi?id=24684
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage): Move ASSERTs to the top of the function, code was using "node" before ASSERT(node), once I moved ASSERT(node) to the top of the function it made sense to move the rest of them there too.
- rendering/SVGRenderSupport.cpp: (WebCore::prepareToRenderSVGContent): move ASSERT(object) to *before* we use "object" :)
- 3:14 PM Changeset in webkit [41989] by
-
- 2 edits in trunk/WebCore
Reviewed by Simon Fraser.
Make TextTokenizer ASSERT that the buffer was freed
https://bugs.webkit.org/show_bug.cgi?id=24684
- loader/TextDocument.cpp: (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextTokenizer::~TextTokenizer): (WebCore::TextTokenizer::finish): Make it clear by adding a ~TextTokenizer that finish() will always be called and the memory never leaked.
- 3:14 PM Changeset in webkit [41988] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
Fix case where lBreak.obj->isBR() when lBreak.obj was NULL
https://bugs.webkit.org/show_bug.cgi?id=24684
I don't have a test case where we were taking the wrong path here
However, adding an ASSERT(lBreak.obj) before this usage caused
multiple bidi tests to fail, so lBreak.obj can be null here.
- rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): lBreak.obj can be null, so we can't call ->isBR() on it unconditionally.
- 3:11 PM Changeset in webkit [41987] by
-
- 3 edits4 adds in trunk
2009-03-25 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
When the slider range is zero, avoid a divide by zero, which caused the
thumb to be positioned off in the weeds, which broke painting.
Test: media/video-empty-source.html
- rendering/RenderSlider.cpp: (WebCore::SliderRange::proportionFromValue): (WebCore::SliderRange::valueFromProportion): (WebCore::sliderPosition): (WebCore::RenderSlider::setValueForPosition):
- 3:04 PM Changeset in webkit [41986] by
-
- 6 edits in trunk/WebCore
Reviewed by Simon Fraser.
Style cleanup and dead code removal in dom, editing
https://bugs.webkit.org/show_bug.cgi?id=24684
- dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner): (WebCore::ContainerNode::getRect): Coverty was (rightly) confused as to what the hell "o" was being used for and whether or not it would ever be NULL. I added some ASSERTS so that people (and machines) would be less confused about the logic in getUpperLeftCorner/getLowerRightCorner
- dom/Document.cpp: (WebCore::Document::recalcStyle): Remove dead code, this block already checked that change == Force
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyle): Coverty correctly identified that traversePreviousNodePostOrder can return NULL, thus prev will be null, and we don't really explicitly handle it (like we probably should) It's OK though, because we end up creating a null position object, which may not have been what we intended, but we certainly don't crash.
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Remove dead code, insertionPosition.node() is already checked to be non-null above.
- editing/markup.cpp: (WebCore::appendStartMarkup): removed dead code, annotate is already known to be true at this point in the file !annotate was checked above, and break; was called.
- 3:04 PM Changeset in webkit [41985] by
-
- 4 edits in trunk/WebCore
Reviewed by Simon Fraser.
CSS dead code removal and cleanup from Coverty errors
https://bugs.webkit.org/show_bug.cgi?id=24684
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Every other place in the code we check settings() for NULL, so I made these places check too, even though we should never be resolving style against a document which has no frame (which I believe is the only time settings() can be null)
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::styleSheetChanged): Removing dead code, "root" can never be null here.
- css/SVGCSSStyleSelector.cpp: (WebCore::colorFromSVGColorCSSValue): (WebCore::CSSStyleSelector::applySVGProperty): Extra returns in the old macros caused dead code. Removing the old macros and use modern ones instead. :) Extra null checks to value were not needed. Added an ASSERT at the top of the function to make it clear that value will never be NULL. Added colorFromSVGColorCSSValue to clean up the code a little.
- 3:04 PM Changeset in webkit [41984] by
-
- 3 edits in trunk/WebCore
Reviewed by Simon Fraser.
Font fallback cleanup and added ASSERT for GlyphPageTreeNode
https://bugs.webkit.org/show_bug.cgi?id=24684
- css/CSSFontSelector.cpp: (WebCore::compareFontFaces): Coverty was concerned that it was possible to index off the end of weightFallbackRuleSets I can't read the code well enough to tell, so I tried to make the code clearer and added an ASSERT.
- platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): Coverty believes we can crash here due to j being larger than GlyphPage::size. I think to is already known to be < GlyphPage::size due to the min() statement above, but not being sure I added an ASSERT.
- 3:04 PM Changeset in webkit [41983] by
-
- 9 edits in trunk/WebCore
Reviewed by Simon Fraser.
Coverty inspired fixes in Animations/Transforms
https://bugs.webkit.org/show_bug.cgi?id=24684
- page/animation/AnimationBase.h: Fix animate() signatures to match so that the virtual methods actually override one another. :)
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList): Attempt to fix this method, prevAnimation was never set to anything but NULL, as far as I can tell the author originally intended to update it at the end of the loop, which is what I changed this code to do.
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::animate): Make method signature match AnimationBase::animate
- page/animation/ImplicitAnimation.h:
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate): Make method signature match AnimationBase::animate
- page/animation/KeyframeAnimation.h:
- platform/graphics/transforms/PerspectiveTransformOperation.cpp: (WebCore::PerspectiveTransformOperation::blend): if (blendToIdentity) already returned above.
- platform/graphics/transforms/RotateTransformOperation.cpp: (WebCore::RotateTransformOperation::blend): if (blendToIdentity) already returned above.
- 2:31 PM Changeset in webkit [41982] by
-
- 3 edits in trunk/WebCore
2009-03-25 Eli Fidler <eli.fidler@torchmobile.com>
Reviewed by George Staikos.
Fix compiler warnings regarding assignments in if statements.
- 2:25 PM Changeset in webkit [41981] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/6472150> repro crash in RenderBlock::rightmostPosition(bool, bool) const at mercotte.fr using menus
Test: fast/inline/continuation-positioned-reparenting.html
- rendering/RenderInline.cpp: (WebCore::RenderInline::splitFlow): When repurposing the existing container as the "pre" block, clear its positioned objects list, because positioned descendants may end up in a different block after the split.
LayoutTests:
Reviewed by Dave Hyatt.
- test for <rdar://problem/6472150> repro crash in RenderBlock::rightmostPosition(bool, bool) const at mercotte.fr using menus
- fast/inline/continuation-positioned-reparenting-expected.txt: Added.
- fast/inline/continuation-positioned-reparenting.html: Added.
- 12:52 PM Changeset in webkit [41980] by
-
- 3 edits4 adds in trunk
2009-03-24 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Length values in transform operations need to take zoom into account.
Test: fast/transforms/transforms-with-zoom.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::createTransformOperations):
- 12:36 PM Applications using WebKit edited by
- (diff)
- 12:23 PM Changeset in webkit [41979] by
-
- 9 edits in trunk
WebCore:
2009-03-25 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=24809, background-clip/origin don't use the correct
values. Add support for the new values (while preserving the old values for backwards
compatibility).
Changed some existing test cases to use the new values.
- css/CSSParser.cpp: (WebCore::CSSParser::parseFillProperty):
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EFillBox):
- css/CSSValueKeywords.in:
LayoutTests:
2009-03-25 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Change a few test cases to use the new values just to verify that they work.
- fast/backgrounds/size/backgroundSize17.html:
- fast/backgrounds/size/backgroundSize18.html:
- fast/backgrounds/size/backgroundSize19.html:
- fast/gradients/simple-gradients.html:
- 11:18 AM Changeset in webkit [41978] by
-
- 3 edits4 adds in trunk
WebCore:
2009-03-25 Brett Wilson <brettw@dhcp-172-22-71-191.mtv.corp.google.com>
Reviewed by Dimitri Glazkov.
Fix complex text opacity on the Chromium Windows port.
https://bugs.webkit.org/show_bug.cgi?id=24757
Test: fast/text/complex-text-opacity.html
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds): (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):
LayoutTests:
2009-03-25 Brett Wilson <brettw@dhcp-172-22-71-191.mtv.corp.google.com>
Reviewed by Dimitri Glazkov.
Fix complex text opacity on the Chromium Windows port.
https://bugs.webkit.org/show_bug.cgi?id=24757
- fast/text/complex-text-opacity.html: Added.
- platform/mac/fast/text/complex-text-opacity-expected.checksum: Added.
- platform/mac/fast/text/complex-text-opacity-expected.png: Added.
- platform/mac/fast/text/complex-text-opacity-expected.txt: Added.
- 10:30 AM Changeset in webkit [41977] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Kevin Decker.
<rdar://problem/6453738> call SetWindow when user creates a new tab
CoreGraphics plug-ins now receive an NPP_SetWindow call when moving to a background tab.
Flash is excluded from this change in behavior, as it has historical WebKit-specific code
that isn't compatible with this change.
- Plugins/WebNetscapePluginView.h:
Added an _isFlash ivar.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView _createPlugin]):
Set the new _isFlash ivar based on the bundle identifier.
(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
When using the CG drawing model and in a non-drawable state, set the portState
to NULL and return early.
(-[WebNetscapePluginView updateAndSetWindow]):
When using the CG drawing model, call -setWindowIfNecessary even if the portState is NULL.
Flash is an exception to this, due to its historical behavior.
(-[WebNetscapePluginView setWindowIfNecessary]):
Removed an assertion that was no longer true. The [NSView focus] view
is no longer guaranteed to be 'self' at this point.
Also modified the debug logging for CG plug-ins to include the size of the
window's clipRect, which was useful in verifying the correct behavior of this patch.
- 10:07 AM Changeset in webkit [41976] by
-
- 3 edits4 adds in trunk
WebCore:
2009-03-25 David Hyatt <hyatt@apple.com>
Reviewed by Eric Seidel
Fix for bug 23198, border images should not clip to border radii. The border-image should just ignore
the border-radius, since the assumption is that any desired rounding will be built into the border-image
itself.
Note that I do not agree with this change, but I am matching the spec.
Added fast/borders/border-image-border-radius.html
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage):
LayoutTests:
2009-03-25 David Hyatt <hyatt@apple.com>
Reviewed by Eric Seidel
Test case for bug 23198.
- fast/borders/border-image-border-radius.html: Added.
- platform/mac/fast/borders/border-image-border-radius-expected.checksum: Added.
- platform/mac/fast/borders/border-image-border-radius-expected.png: Added.
- platform/mac/fast/borders/border-image-border-radius-expected.txt: Added.
- 8:09 AM Changeset in webkit [41975] by
-
- 2 edits in trunk/WebCore
2009-03-25 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=24750
[GTK] requests download instead of displaying page
Fix the Content-Type headers we get from soup, so that we set a
proper media type on the ResourceResponse.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
- 7:49 AM Changeset in webkit [41974] by
-
- 2 edits in trunk/WebCore
2009-03-25 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=24600
[GTK] responses with status code >= 400 should not be given special treatment
Do not special case requests that have HTTP responses >=
- Redirects are handled automatically by libsoup, but the rest of the responses should be treated like any other.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::): (WebCore::gotHeadersCallback): (WebCore::gotChunkCallback): (WebCore::finishedCallback):
- 7:36 AM Changeset in webkit [41973] by
-
- 5 edits in trunk/WebCore
2009-03-25 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
Tidy up LegacyWebArchive a bit. And don't include favicons in web archives when
they are being used only for selections, not an entire document.
- WebCore.base.exp: Remove exported function that's not used in WebKit.
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::createPropertyListRepresentation): Made a static member function so it can share private things with other member functions. Added some FIXME comments to a branch of code I think is dead. Changed boolean argument into a named one. Renamed to match other similar functions. (WebCore::LegacyWebArchive::createResourceResponseFromPropertyListData): Ditto. (WebCore::LegacyWebArchive::createResource): Ditto. (WebCore::LegacyWebArchive::create): Merged the create and init functions. (WebCore::LegacyWebArchive::rawDataRepresentation): Added some assertions because we should never fail to write (we can fail to read). (WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Made a static member function as above. (WebCore::LegacyWebArchive::createFromSelection): Ditto. (WebCore::LegacyWebArchive::create): Iterate the vector with indices rather than iterators. Only include the favicon if the first node is the document since we don't want to include the favicon when copying and pasting.
- loader/archive/cf/LegacyWebArchive.h: Made one of the create functions private. Made the Mac-specific functions be static member functions. Made other helpers be static member functions. Removed the nit function.
- loader/archive/cf/LegacyWebArchiveMac.mm: (WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Updated comment and made this a static member function. (WebCore::LegacyWebArchive::createPropertyListRepresentation): Ditto. Also made it so we only type cast in one place.
- 7:34 AM Changeset in webkit [41972] by
-
- 12 edits2 adds in trunk
WebCore:
2009-03-25 Darin Adler <Darin Adler>
Reviewed by David Hyatt.
Bug 24740: crash in RenderSlider::setPositionFromValue when calling pause() after setting <video> to display: none
https://bugs.webkit.org/show_bug.cgi?id=24740
rdar://problem/6679873
Bug 12104: Native Slider: When the thumb's height is specified as a percentage, it is not centered properly
https://bugs.webkit.org/show_bug.cgi?id=12104
Test: media/video-display-none-crash.html
The problem here was that RenderSlider was trying to position its thumb in a way that
requires it to call updateLayout inside rendering code. The right way to position a
child renderer is to do layout, so I had to write a layout function. And then fix a few
other small problems shown by the same test case.
- rendering/RenderSlider.cpp: Made defaultTrackLength have internal linkage. Renamed HTMLSliderThumbElement to SliderThumbElement because we only use the HTML prefix for public DOM classes, not elements used as implementation details. Made SliderThumbElement function members private and got rid of unneeded default argument value for shadowParent. (WebCore::SliderRange::SliderRange): Added. Parses precision, max, and min attributes. (WebCore::SliderRange::clampValue): Added. Does standard clamping based on the above. (WebCore::SliderRange::valueFromElement): Added. Reads the value from the element in a way that clamps to the range. (WebCore::sliderPosition): Added. Computes the slider position: a double. (WebCore::SliderThumbElement::SliderThumbElement): Removed unneeded explicit initialization of m_initialClickPoint. (WebCore::SliderThumbElement::defaultEventHandler): Call setValueForPosition instead of calling setCurrentPosition and valueChanged. (WebCore::RenderSlider::RenderSlider): Remove unneeded explicit initialization of m_thumb. (WebCore::RenderSlider::styleDidChange): Remove unneeded second argument to createThumbStyle. (WebCore::RenderSlider::createThumbStyle): Remove unneeded second argument. Get rid of code setting the position to relative and setting the left and top. We now handle positioning in a custom layout function. (WebCore::RenderSlider::layout): Rewrote to handle positioning of the thumb as layout. (WebCore::RenderSlider::updateFromElement): Added code to immediately update the value in the element if it's out of range. This clamping used to be done as a side effect of setPositionFromValue. Also, this has nothing to do with the renderer, so at some point it could be moved into HTMLInputElement. Removed call to setPositionFromValue and instead just rely on the call to setNeedsLayout. Fix the setNeedsLayout call to be a normal setNeedsLayout(true), not a setNeedsLayout(true, false), because we do want this to be propagated to the parent -- it's not called during layout. (WebCore::RenderSlider::setValueForPosition): Refactor to use the new SliderRange class. Also don't call setCurrentPosition; instead just call setNeedsLayout. (WebCore::RenderSlider::currentPosition): Use the actual position of the renderer rather than the style to find the position; that means this needs to be done after layout is done. Also removed unneeded runtime checks and replaced them with assertions, after checking all callers to see they already guarantee this. (WebCore::RenderSlider::trackSize): Removed unneeded runtime checks and replaced them with assertions, after checking all callers to see they already guarantee this. (WebCore::RenderSlider::inDragMode): Added a null check for m_thumb so this won't crash if called early on a brand new RenderSlider.
- rendering/RenderSlider.h: Made all functions private except for forwardEvent and inDragMode. Renamed HTMLSliderThumbElement to SliderThumbElement because we only use the HTML prefix for public DOM classes, not elements used as implementation details. Made the mouseEventIsInThumb function non-virtual. Removed the return value and argument from setPositionFromValue. Removed valueChanged and setCurrentPosition. Removed the oldStyle argument to createThumbStyle (see above). Made SliderThumbElement a friend so it can use some private member functions.
LayoutTests:
2009-03-25 Darin Adler <Darin Adler>
Reviewed by David Hyatt.
Bug 24740: crash in RenderSlider::setPositionFromValue when calling pause() after setting <video> to display: none
https://bugs.webkit.org/show_bug.cgi?id=24740
rdar://problem/6679873
Bug 12104: Native Slider: When the thumb's height is specified as a percentage, it is not centered properly
https://bugs.webkit.org/show_bug.cgi?id=12104
- media/video-display-none-crash-expected.txt: Added.
- media/video-display-none-crash.html: Added.
- platform/mac/fast/forms/box-shadow-override-expected.txt: Updated since a slider's thumb is no longer relative-positioned and hence no longer gets its own layer.
- platform/mac/fast/forms/input-appearance-height-expected.txt: Ditto.
- platform/mac/fast/forms/slider-padding-expected.txt: Ditto.
- platform/mac/fast/forms/slider-thumb-shared-style-expected.txt: Ditto.
- platform/mac/fast/forms/slider-thumb-stylability-expected.txt: Ditto.
- platform/mac/media/audio-controls-rendering-expected.txt: Ditto.
- platform/mac/media/video-controls-rendering-expected.txt: Ditto.
- platform/mac/media/video-display-toggle-expected.txt: Ditto.
- 7:31 AM Changeset in webkit [41971] by
-
- 2 edits in trunk/WebKit/gtk
2009-03-25 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=15793
[GTK] tooltip position doesn't update when hovering consecutive links
Work-around tooltips not updating their location when the elements
are consecutive, by clearing the tooltip when handling
mouseDidMoveOverElement.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
- 6:01 AM Changeset in webkit [41970] by
-
- 5 edits in trunk/WebCore
2009-03-25 Eli Fidler <eli.fidler@torchmobile.com>
Reviewed by George Staikos.
Fix ambiguous else cases by adding braces to nested if()s with elses.
- 5:00 AM Changeset in webkit [41969] by
-
- 3 edits in trunk/WebKit/gtk
2009-03-23 Alejandro Garcia Castro <alex@igalia.com>
Reviewed by Holger Freyther.
[Gtk] Current API does not allow us to open target="_blank" links
in new tabs instead of windows
https://bugs.webkit.org/show_bug.cgi?id=23932
Added a signal to the API (new-window-policy-decision-requested)
that allows the browser to decide the policy for the new window
request, if the signal is not handled we open the new window as
usual.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::getNavigationAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- webkit/webkitwebview.cpp:
Mar 24, 2009:
- 9:18 PM Changeset in webkit [41968] by
-
- 2 edits in trunk/WebKitTools
Fix the Tiger build some more.
- 9:06 PM Changeset in webkit [41967] by
-
- 2 edits in trunk/WebKitTools
Fix the Tiger build.
- 8:29 PM Changeset in webkit [41966] by
-
- 4 edits in trunk
Explicitly map NSNotFound to -1 so that the result of-characterIndexForPointX:Y: does not differ between 32- and 64-bit.
Reviewed by Jon "The Most Boring Man in the World" Honeycutt.
- DumpRenderTree/mac/TextInputController.m:
(-[TextInputController characterIndexForPointX:Y:]):
Update test result for change to explicitly map NSNotFound to -1 in textInputController.characterIndexForPoint.
- platform/mac/fast/dom/character-index-for-point-expected.txt:
- 8:13 PM Changeset in webkit [41965] by
-
- 2 edits in trunk/LayoutTests
Skip some more tests that are failing.
Rubber-stamped by Oliver Hunt.
- platform/mac-snowleopard/Skipped:
- 7:47 PM Changeset in webkit [41964] by
-
- 2 edits in trunk/WebCore
2009-03-24 Eli Fidler <eli.fidler@torchmobile.com>
Reviewed by George Staikos.
Move variable into proper platform block to quiet warning.
- 7:14 PM Changeset in webkit [41963] by
-
- 3 edits in trunk/WebCore
2009-03-24 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti Koivisto.
Fix for <rdar://problem/6719375> Deal with QTKit loadstate changes when playing streaming movies
- WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): Deal with media engine reviving after having network state of NETWORK_NO_SOURCE.
- WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): Reset m_readyState at each state change since some types of movies currently cause QTKit's load state to bounce around. QTMovieLoadStatePlaythroughOK corresponds to HaveFutureData, not HaveEnoughData.
- 5:57 PM Changeset in webkit [41962] by
-
- 7 edits in trunk
WebCore:
2009-03-24 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=24707
<rdar://problem/6593021> Deleting with a caret in a blank, quoted line decreases the quoting, but does not delete the line
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): After breaking out of an empty mail blockquote, we still want continue with the deletion so actual content will get deleted, and not just the quote style.
LayoutTests:
2009-03-24 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Updated tests for https://bugs.webkit.org/show_bug.cgi?id=24707
<rdar://problem/6593021> Deleting with a caret in a blank, quoted line decreases the quoting, but does not delete the line
- editing/deleting/2610675-1-expected.txt:
- editing/deleting/2610675-1.html:
- editing/deleting/2610675-2-expected.txt:
- editing/deleting/2610675-2.html:
- 5:30 PM Changeset in webkit [41961] by
-
- 2 edits in trunk/WebCore
2009-03-24 Darin Adler <Darin Adler>
Reviewed by Brady Eidson.
<rdar://problem/6624662> REGRESSION (r39904): can't save certain web pages as web archive (ones without favicons!)
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Added a null check.
- 5:02 PM Changeset in webkit [41960] by
-
- 2 edits in trunk/WebCore
2009-03-24 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
The Skia drawLine function takes subpixel values and attempts to draw
a line with subpixel precision. This is complex and slow for drawing
scrollbars which use only vertical and horizontal lines.
This changes the Chromium Linux scrollbar code to use drawIRect.
- platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit): (WebCore::drawVertLine): (WebCore::drawHorizLine): (WebCore::drawBox): (WebCore::ScrollbarThemeChromium::paintTrackPiece): (WebCore::ScrollbarThemeChromium::paintThumb):
- 4:36 PM Changeset in webkit [41959] by
-
- 2 edits in trunk/LayoutTests
Skip fast/forms/search-zoomed.html as it currently fails due to <rdar://problem/6718460>.
Rubber-stamped by Sam Weinig.
- platform/mac-snowleopard/Skipped:
- 4:25 PM Changeset in webkit [41958] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix the list of files touched in r41951 in the Changelog.
- 4:18 PM Changeset in webkit [41957] by
-
- 2 edits in trunk/LayoutTests
Skip some more media tests for now.
- platform/mac-snowleopard/Skipped:
- 4:18 PM Changeset in webkit [41956] by
-
- 2 edits in trunk/WebKitTools
Use a different platform search path for tests and skip lists, so that Tiger doesn't end up
using the Leopard skip list. Tests and skip lists are now looked for in the directory for
the current OS and the generic "mac" directory. Tests and skip lists for newer OS versions are
ignored.
Reviewed by Sam Weinig.
- Scripts/run-webkit-tests:
- 3:30 PM Changeset in webkit [41955] by
-
- 1 edit26 adds in trunk/LayoutTests
2009-03-24 Pamela Greene <pam@chromium.org>
Reviewed by Sam Weinig.
Add tests of font choices and metrics, to isolate those dependencies.
- fonts: Added.
- fonts/cursive.html: Added.
- fonts/default.html: Added.
- fonts/fantasy.html: Added.
- fonts/monospace.html: Added.
- fonts/sans-serif.html: Added.
- fonts/serif.html: Added.
- platform/mac/fonts: Added.
- platform/mac/fonts/cursive-expected.checksum: Added.
- platform/mac/fonts/cursive-expected.png: Added.
- platform/mac/fonts/cursive-expected.txt: Added.
- platform/mac/fonts/default-expected.checksum: Added.
- platform/mac/fonts/default-expected.png: Added.
- platform/mac/fonts/default-expected.txt: Added.
- platform/mac/fonts/fantasy-expected.checksum: Added.
- platform/mac/fonts/fantasy-expected.png: Added.
- platform/mac/fonts/fantasy-expected.txt: Added.
- platform/mac/fonts/monospace-expected.checksum: Added.
- platform/mac/fonts/monospace-expected.png: Added.
- platform/mac/fonts/monospace-expected.txt: Added.
- platform/mac/fonts/sans-serif-expected.checksum: Added.
- platform/mac/fonts/sans-serif-expected.png: Added.
- platform/mac/fonts/sans-serif-expected.txt: Added.
- platform/mac/fonts/serif-expected.checksum: Added.
- platform/mac/fonts/serif-expected.png: Added.
- platform/mac/fonts/serif-expected.txt: Added.
- 3:22 PM Changeset in webkit [41954] by
-
- 2 edits in trunk/JavaScriptCore
2009-03-24 Eli Fidler <eli.fidler@torchmobile.com>
Reviewed by George Staikos.
Correct warnings which in some environments are treated as errors.
- 2:40 PM Changeset in webkit [41953] by
-
- 3 edits3 adds in trunk
Bug 23310: Setting an absolute path (/abs) on an <iframe> with no src doesn't resolve the URL properly
Reviewed by Darin Adler.
WebCore:
Test: fast/frames/iframe-no-src-set-location.html
- dom/Document.cpp: (WebCore::Document::completeURL): If m_baseURL is empty or is about:blank and we have a parent document, use the parent document's URL for the base when completing a new URL.
LayoutTests:
- fast/frames/iframe-no-src-set-location-expected.txt: Added.
- fast/frames/iframe-no-src-set-location.html: Added.
- fast/frames/resources/iframe-no-src-set-location-pass.html: Copied from LayoutTests/fast/dom/Document/early-document-access-expected.txt.
- 2:07 PM Changeset in webkit [41952] by
-
- 3 edits2 adds in trunk
2009-03-24 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
When hit-testing 3d-transformed layers, it doesn't make sense to project the hitTestRect
into the coordinate space of the layer, and doing so can result in pathalogical quads
that break hit testing. In that case, simply use the same bounds as used for painting,
which are the composited bounds for this layer.
Test: transforms/3d/hit-testing/rotated-hit-test.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
- 2:03 PM Changeset in webkit [41951] by
-
- 3 edits in trunk/WebCore
2009-03-24 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
When compositing is enabled, painting and hit testing end up using different
clipping roots, because, for painting, every composited layer is a clipping root,
but for hit testing only layers with transforms are. To fix this, we use
temporary clip rects for hit testing, if the page is in compositing mode.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
- 1:46 PM Changeset in webkit [41950] by
-
- 2 edits in trunk/WebCore
2009-03-24 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Fix regression with CSS clip rects with non-length values, by reverting to
the original code, but passing the zoom multiplier through convertToLength().
Also make stylistic change in createTransformOperations(), renaming 'inStyle'
to 'style.
Tested by existing tests.
- css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createTransformOperations):
- 1:29 PM Changeset in webkit [41949] by
-
- 2 edits in trunk/WebKit/win
2009-03-24 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=24779
Conditionalize CFNetwork-specific code in WebView to permit
support for other network backends.
- WebView.cpp: (WebView::setCacheModel): Add CFNETWORK check around CFNetwork specific cache implementation. (updateSharedSettingsFromPreferencesIfNeeded): Add CFNETWORK check around use of CFHTTPCookie code.
- 1:23 PM Changeset in webkit [41948] by
-
- 3 edits4 adds in trunk
WebCore:
2009-03-24 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser
https://bugs.webkit.org/show_bug.cgi?id=21789, overflow:hidden elements should clip their foreground contents
to a border-radius.
This patch makes non-self-painting overflow layers and control clips work with border-radius. RenderLayers
that should be clipped by overflow ancestors with border-radius are still broken.
Added fast/clip/overflow-border-radius-clip.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
LayoutTests:
2009-03-24 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser
- fast/clip/overflow-border-radius-clip.html: Added.
- platform/mac/fast/clip/overflow-border-radius-clip-expected.checksum: Added.
- platform/mac/fast/clip/overflow-border-radius-clip-expected.png: Added.
- platform/mac/fast/clip/overflow-border-radius-clip-expected.txt: Added.
- 1:05 PM Changeset in webkit [41947] by
-
- 1 edit in trunk/WebCore/rendering/RenderReplaced.cpp
Fix stray ; that snuck in right before landing.
- 12:52 PM Changeset in webkit [41946] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
Explicitly define HAVE_LANGINFO_H on Darwin. Fixes the wx build bot jscore
test failure.
https://bugs.webkit.org/show_bug.cgi?id=24780
- 12:35 PM Changeset in webkit [41945] by
-
- 5 edits4 adds in trunk
WebCore:
2009-03-24 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser
https://bugs.webkit.org/show_bug.cgi?id=21789, overflow:hidden elements should clip their foreground contents.
This first patch makes overflow:hidden properly clip the foreground contents of overflow:hidden replaced elements. Common
replaced elements now default to overflow:hidden in the UA stylesheet (this is what the spec specifically recommends be
done).
Added fast/replaced/border-radius-clip.html
- css/html4.css:
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
LayoutTests:
2009-03-24 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser
- fast/replaced/border-radius-clip.html: Added.
- platform/mac/fast/replaced/border-radius-clip-expected.checksum: Added.
- platform/mac/fast/replaced/border-radius-clip-expected.png: Added.
- platform/mac/fast/replaced/border-radius-clip-expected.txt: Added.
- 11:25 AM Changeset in webkit [41944] by
-
- 3 edits in trunk/WebCore
2009-03-24 Adele Peterson <adele@apple.com>
RS by Mark Rowe.
Only build these Mail quirks checks in on the Mac.
- dom/Document.cpp: (WebCore::disableRangeMutation):
- html/HTMLElement.cpp: (WebCore::HTMLElement::inEitherTagList):
- 10:55 AM Changeset in webkit [41943] by
-
- 2 edits in trunk/WebCore
2009-03-24 Brent Fulgham <bfulgham@webkit.org>
Build fix, no review.
Remove ResourceLoaderCFNet.cpp from build list for Cairo Releas
and Debug targets.
- WebCore.vcproj/WebCore.vcproj:
- 10:36 AM Changeset in webkit [41942] by
-
- 9 edits in trunk
2009-03-24 Eric Carlson <eric.carlson@apple.com>
Update media tests broken by r41907.
- fast/dom/Window/window-properties-expected.txt:
- http/tests/media/video-play-stall-seek.html:
- http/tests/media/video-play-stall.html:
2009-03-24 Eric Carlson <eric.carlson@apple.com>
Fix layout tests broken by r41907.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Don't set "was playing" based on the new ready state
- 10:18 AM Changeset in webkit [41941] by
-
- 2 edits in trunk/WebCore
2009-03-24 Dmitry Titov <dimich@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=24689
Fix Chromium compilation errors.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener): (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
- 10:08 AM Changeset in webkit [41940] by
-
- 2 edits in trunk/WebCore
2009-03-24 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=24759
Add missing methods Element.prototype.removeMatchingStyleClasses and
Node.prototype.enclosingNodeOrSelfWithNodeNameInArray to SourceFrame content
iframe. These methods are called by Element.prototype.removeStyleClass and
Node.prototype.enclosingNodeOrSelfWithNodeName.
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
- 10:03 AM Changeset in webkit [41939] by
-
- 24 edits in trunk/WebCore
2009-03-24 Mark Mentovai <mark@chromium.org>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=24653
WebKit should be buildable without prefix header injection.
Adds missing #includes and forward declarations as needed.
- editing/SmartReplaceCF.cpp:
- platform/graphics/mac/ColorMac.mm:
- platform/graphics/mac/FontCacheMac.mm:
- platform/graphics/mac/FontCustomPlatformData.h:
- platform/graphics/mac/FontMac.mm:
- platform/graphics/mac/FontMacATSUI.mm:
- platform/graphics/mac/FontPlatformData.h:
- platform/graphics/mac/FontPlatformDataMac.mm:
- platform/graphics/mac/GraphicsContextMac.mm:
- platform/graphics/mac/SimpleFontDataMac.mm:
- platform/mac/FoundationExtras.h:
- platform/mac/LocalCurrentGraphicsContext.h:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/mac/WebCoreTextRenderer.h:
- platform/mac/WebCoreTextRenderer.mm:
- platform/mac/WebFontCache.h:
- platform/mac/WebFontCache.mm:
- platform/text/PlatformString.h:
- platform/text/mac/ShapeArabic.c:
- platform/text/mac/StringMac.mm:
- rendering/RenderThemeChromiumMac.h:
- 9:24 AM Changeset in webkit [41938] by
-
- 4 edits3 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/6107874> by capping the nesting depth of "block-level" elements generated by the parser
Test: fast/parser/block-nesting-cap.html
- html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::pushBlock): (WebCore::HTMLParser::popOneBlockCommon): (WebCore::HTMLParser::freeBlock):
- html/HTMLParser.h:
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/6107874>
Test that the nesting depth of "block-level" elements generated by
the parser is capped
- fast/parser/block-nesting-cap-expected.txt: Added.
- fast/parser/block-nesting-cap.html: Added.
- fast/parser/resources/block-nesting-cap.js: Added.
- 12:50 AM Changeset in webkit [41937] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Oliver Hunt.
- speculative fix for <rdar://problem/6630134> Crash at Editor::compositionRange()
- WebView/WebHTMLView.mm: (-[WebHTMLView markedRange]): Null-check the Frame like most other methods in this class.
Mar 23, 2009:
- 9:16 PM Changeset in webkit [41936] by
-
- 2 edits in trunk/WebCore
2009-03-23 Greg Bolsinga <bolsinga@apple.com>
Reviewed by David Kilzer.
DOMTimeStamps are based upon 1970.
- platform/mac/GeolocationServiceMac.mm: (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
- 8:45 PM Changeset in webkit [41935] by
-
- 2 edits in trunk/WebCore
Build fix, no review.
- rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition): change .container to .isNotNull()
- 8:19 PM Changeset in webkit [41934] by
-
- 2 edits in trunk/WebKitTools
2009-03-23 Stephanie <Stephanie Lewis>
Fix root build.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- 7:25 PM Changeset in webkit [41933] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin Adler.
Rename Position::container to m_anchorNode and make it private
https://bugs.webkit.org/show_bug.cgi?id=24760
More code cleanup for Position.
Change all uses of m_container to node()
Eventually most uses of node() should change to anchorNode() to designate
that it's the node the Position is anchored to, but not necessarily the
container of the position (it could be the before/after neighbor).
Remove any code which sets m_container, and change it to use a new
Position::moveToPosition function which takes a node and offset.
It never makes sense to change the node and leave the offset.
- dom/Position.h: (WebCore::Position::Position): (WebCore::Position::clear): (WebCore::Position::anchorNode): (WebCore::Position::node): (WebCore::Position::moveToPosition): (WebCore::Position::moveToOffset): (WebCore::Position::isNull): (WebCore::Position::isNotNull): (WebCore::operator==):
- dom/Range.cpp: (WebCore::Range::create): (WebCore::Range::compareBoundaryPoints):
- dom/RangeBoundaryPoint.h: (WebCore::RangeBoundaryPoint::container): (WebCore::RangeBoundaryPoint::set): (WebCore::RangeBoundaryPoint::setOffset): (WebCore::RangeBoundaryPoint::setToChild): (WebCore::RangeBoundaryPoint::setToStart): (WebCore::RangeBoundaryPoint::setToEnd):
- 7:06 PM Changeset in webkit [41932] by
-
- 3 edits3 adds in trunk
Reviewed by David Hyatt.
document.write() should be able to make a document strict mode
https://bugs.webkit.org/show_bug.cgi?id=24336
Remove an implicit write of "<html>" on the first document.write call
this was added as part of a KDE import http://trac.webkit.org/changeset/798
with no layout test or explanation. I can't think of any reason why
an implicit <html> write is necessary (or correct), so I'm removing it and
adding a test for the correct behavior. The parser will add any necessary
HTMLHTMLElements during the write() anyway.
Our behavior is now tested by fast/dom/Document/document-write-doctype
and matches IE, FF fails this new test. Mozilla bug filed:
https://bugzilla.mozilla.org/show_bug.cgi?id=483908
- dom/Document.cpp: (WebCore::Document::write):
- 6:59 PM Changeset in webkit [41931] by
-
- 4 edits in trunk/JavaScriptCore
Fix className() for API defined class
Reviewed by Cameron Zwarich
- 6:31 PM Changeset in webkit [41930] by
-
- 9 edits in trunk
WebCore:
2009-03-23 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/6140966>
Empty Caches does not clear the Cross-site XMLHttpRequest preflight cache
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
- loader/CrossOriginPreflightResultCache.cpp: (WebCore::CrossOriginPreflightResultCache::empty):
- loader/CrossOriginPreflightResultCache.h:
WebKit/mac:
2009-03-23 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/6140966>
Empty Caches does not clear the Cross-site XMLHttpRequest preflight cache
- Misc/WebCache.mm: (+[WebCache empty]):
WebKit/win:
2009-03-23 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/6140966>
Empty Caches does not clear the Cross-site XMLHttpRequest preflight cache
- WebCache.cpp: (WebCache::empty): Also add application cache emptying to match the mac.
- 5:53 PM Changeset in webkit [41929] by
-
- 1 edit in trunk/WebCore/rendering/RenderObject.cpp
Tweak comment.
- 5:50 PM Changeset in webkit [41928] by
-
- 10 edits2 adds in trunk
WebCore:
2009-03-23 Darin Adler <Darin Adler>
Reviewed by Adele Peterson.
Bug 24726: hit testing doesn't work right when the click is on anonymous content
https://bugs.webkit.org/show_bug.cgi?id=24726
rdar://problem/6696992
Test: editing/selection/hit-test-anonymous.html
- rendering/RenderBR.cpp: (WebCore::RenderBR::positionForPoint): Call createVisiblePosition instead of creating a VisiblePosition directly. It will handle finding non-anonymous content nearby if node() is 0.
- rendering/RenderBlock.cpp: (WebCore::positionForPointRespectingEditingBoundaries): Ditto. (WebCore::positionForPointWithInlineChildren): Ditto. (WebCore::RenderBlock::positionForPoint): Ditto.
- rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint): Ditto.
- rendering/RenderObject.cpp: (WebCore::RenderObject::positionForPoint): Ditto. (WebCore::RenderObject::createVisiblePosition): Added.
- rendering/RenderObject.h: Added createVisiblePosition.
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForPoint): Call createVisiblePosition.
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForPoint): Ditto.
- rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint): Ditto.
LayoutTests:
2009-03-23 Darin Adler <Darin Adler>
Reviewed by Adele Peterson.
Bug 24726: hit testing doesn't work right when the click is on anonymous content
https://bugs.webkit.org/show_bug.cgi?id=24726
rdar://problem/6696992
- editing/selection/hit-test-anonymous-expected.txt: Added.
- editing/selection/hit-test-anonymous.html: Added.
- 5:41 PM Changeset in webkit [41927] by
-
- 2 edits in trunk/WebKitTools
2009-03-23 Stephanie Lewis <Stephanie Lewis>
Reviewed by Mark Rowe.
Add production configuration for creating roots of WebKitTools.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- 5:34 PM Changeset in webkit [41926] by
-
- 2 edits in trunk/WebCore
2009-03-23 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler & Dave Hyatt.
Fix for <rdar://problem/6621310> REGRESSION(35185): Apple Travel HTML emails missing some style after Safari 4 upgrade
Leopard Mail doesn't expect <style> to be in the body. This change reverts back to the old behavior of
moving <style> to <head> for that version of Mail.
- html/HTMLElement.cpp: (WebCore::HTMLElement::inEitherTagList):
- 5:33 PM Changeset in webkit [41925] by
-
- 7 edits in trunk
WebCore:
2009-03-23 Adele Peterson <adele@apple.com>
Reviewed by Mark Rowe & Dave Hyatt.
Merge some of the individual Mail quirks into two settings that we can check for future quirks.
- WebCore.base.exp:
- dom/Document.cpp: (WebCore::disableRangeMutation): (WebCore::Document::nodeChildrenChanged): (WebCore::Document::nodeWillBeRemoved): (WebCore::Document::textInserted): (WebCore::Document::textRemoved): (WebCore::Document::textNodesMerged): (WebCore::Document::textNodeSplit):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setNeedsLeopardMailQuirks): (WebCore::Settings::setNeedsTigerMailQuirks):
- page/Settings.h: (WebCore::Settings::needsLeopardMailQuirks): (WebCore::Settings::needsTigerMailQuirks):
WebKit/mac:
2009-03-23 Adele Peterson <adele@apple.com>
Reviewed by Mark Rowe & Dave Hyatt.
Merge some of the individual Mail quirks into two settings that we can check for future quirks.
- WebView/WebView.mm: (runningLeopardMail): (runningTigerMail): (-[WebView _preferencesChangedNotification:]):
- 5:18 PM Changeset in webkit [41924] by
-
- 4 edits in trunk
Make testapi run as part of the standard JavaScriptCore tests.
Reviewed by Geoff Garen.
We only run testapi on the mac as currently windows webkit doesn't
place all the necessary files for testapi, and we also test the
JSC/CF APIs as well.
- 4:46 PM Changeset in webkit [41923] by
-
- 8 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=24762
Support text-indent in <option> elements on windows platform.
Reviewed by Adele Peterson.
- css/themeWin.css:
- platform/PopupMenuStyle.h: We don't honor font specified on <option> elements right now. Make this explicit via windows themed default stylesheet. (WebCore::PopupMenuStyle::PopupMenuStyle): Also store text-indent and text-direction. (WebCore::PopupMenuStyle::textIndent): (WebCore::PopupMenuStyle::textDirection):
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Adjust the text's x-coordinate if text-indent is supported for options and text-indent is specified with LTR direction.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth): Take text-indent into account if theme supports text-indent for options. (WebCore::RenderMenuList::itemStyle): Use new PopupMenuStyle constructor on windows. (WebCore::RenderMenuList::menuStyle): Ditto.
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::menuStyle): Ditto.
- rendering/RenderTheme.h: (WebCore::RenderTheme::popupOptionSupportsTextIndent): Added. Default is false since we are only supporting it in windows for now.
- rendering/RenderThemeWin.h: (WebCore::RenderThemeWin::popupOptionSupportsTextIndent): Returns true for windows.
- 4:14 PM Changeset in webkit [41922] by
-
- 4 edits in trunk/WebCore
2009-03-23 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix for https://bugs.webkit.org/show_bug.cgi?id=24699
REGRESSION: Java Applets broken
<rdar://problem/6707494>
Fix loading Java applets without a codeBase. Only pass the base (up to the
the last path component) of the baseURL to the plug-in.
- html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer):
- platform/KURL.cpp: (WebCore::KURL::baseAsString):
- platform/KURL.h:
- 3:15 PM Changeset in webkit [41921] by
-
- 2 edits in trunk/WebCore
2009-03-23 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
- platform/KURL.h: Removed now-incorrect comments. None of the parts include the separator characters any more, now that query doesn't include the "?", so the comments explaining which do and do not are no-longer helpful.
- 2:25 PM Changeset in webkit [41920] by
-
- 6 edits2 moves in trunk/WebCore
2009-03-23 David Levin <levin@chromium.org>
Reviewed by Dimitri Glazkov.
Renamed files V8NodeFilter -> V8NodeFilterCondition to reflect
class names. Also fixed some headers that got mangled in search/replace
operations.
No change in behavior, so no test.
- bindings/v8/V8NodeFilter.h: Removed.
- bindings/v8/V8NodeFilterCondition.cpp: Renamed from WebCore/bindings/v8/V8NodeFilter.cpp.
- bindings/v8/V8NodeFilterCondition.h: Added.
- bindings/v8/custom/V8ClipboardCustom.cpp:
- bindings/v8/custom/V8DocumentCustom.cpp:
- bindings/v8/custom/V8ElementCustom.cpp:
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
- bindings/v8/custom/V8NavigatorCustom.cpp:
- 1:48 PM Changeset in webkit [41919] by
-
- 4 edits in trunk/WebCore
2009-03-23 Darin Fisher <darin@chromium.org>
Reviewed by Antti Koivisto.
Adds a unique across-browser-sessions identifier to FormData, which may
be used by ResourceHandle as a secondary cache key to enable cached
form submissions.
At issue: two otherwise identical form submissions may result in
completely independent responses, which may each be appropriate to
store and reuse from cache.
- html/HTMLFormElement.cpp: Added call to FormData::setIdentifier so that we only enable cached form submissions for those generated by HTML. This way we do not bother with POSTs generated by XMLHttpRequest. (WebCore::generateFormDataIdentifier): (WebCore::HTMLFormElement::createFormData):
- platform/network/FormData.cpp: Initialize m_identifier to 0, which means the unspecified identifier. So by default there is no identifier and nothing changes. (WebCore::FormData::FormData):
- platform/network/FormData.h: Added m_identifier with setter and getter. (WebCore::FormData::setIdentifier): (WebCore::FormData::identifier):
- 1:39 PM Changeset in webkit [41918] by
-
- 7 edits2 adds in trunk
2009-03-23 Simon Fraser <Simon Fraser>
Reviewed by Antti Koivisto
Fix media controller with full-page zoom. Previously, the media controller
shadow nodes never saw style changes on the RenderMedia, so did not respond
to zooming at all. Now, we update the style on the shadow renderers
whenever RenderMedia gets a style change. Also fix the video thumb in
the theme to be scaled properly.
Test: media/video-controls-zoomed.html
- rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::updateStyle): (WebCore::MediaTextDisplayElement::MediaTextDisplayElement): (WebCore::MediaTextDisplayElement::updateStyle): (WebCore::MediaControlInputElement::MediaControlInputElement): (WebCore::MediaControlInputElement::updateStyle):
- rendering/MediaControlElements.h:
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::styleDidChange):
- rendering/RenderMedia.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbSize):
- 1:27 PM Changeset in webkit [41917] by
-
- 4 edits in trunk/WebCore
2009-03-23 Mike Belshe <mike@belshe.com>
Reviewed by Darin Adler.
Rework StringImpl::create methods to try to allocate a single buffer
rather than allocating both the StringImpl class and a separate data
buffer.
- platform/text/StringImpl.cpp:
- platform/text/StringImpl.h:
- 12:05 PM Changeset in webkit [41916] by
-
- 3 edits in trunk/WebCore
2009-03-23 Darin Adler <Darin Adler>
Reviewed by Antti Koivisto.
Based on a patch by Nico Weber <nicolasweber@gmx.de>
Bug 24755: LayoutTests/http/tests/misc/url-in-utf16le.html regression
https://bugs.webkit.org/show_bug.cgi?id=24755
- platform/text/TextEncoding.cpp: (WebCore::TextEncoding::isUTF7Encoding): Added. Checks if the current encoding is UTF7 without loading extended codecs. (WebCore::TextEncoding::encodingForFormSubmission): Use isUTF7Encoding() instead of comparing with UTF7Encoding(). Eliminate the explicit check of noExtendedTextEncodingNameUsed() because that's now handled by the functions that this function calls instead.
- platform/text/TextEncoding.h: Added isUTF7Encoding function. Also tweaked formatting a bit.
- 12:02 PM Changeset in webkit [41915] by
-
- 4 edits in trunk/WebCore
2009-03-20 Peter Kasting <pkasting@google.com>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=24720
RenderThemeChromium should draw something for Slider parts instead of
dropping them on the floor.
- platform/chromium/ChromiumBridge.h:
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::adjustSliderThumbSize): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::RenderThemeChromiumWin::determineSliderThumbState): (WebCore::RenderThemeChromiumWin::getThemeData):
- rendering/RenderThemeChromiumWin.h: (WebCore::RenderThemeChromiumWin::paintSliderThumb):
- 11:56 AM Changeset in webkit [41914] by
-
- 5 edits10 adds in trunk
2009-03-23 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Fix three mostly-unrelated problems with full-page zoom:
- dom/Document.cpp: (WebCore::Document::elementFromPoint): Document::elementFromPoint() needs to take full-page zoom into account.
- dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget): Take full-page zoom into account when computing offsetX/offsetY.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Don't use offsetX/offsetY when hit testing list boxes; offsets were broken with full-page zoom, and using pageX/pageY is easier because we don't have to worry about the event target, and we already have a point in absolute coordinates.
Tests: fast/forms/listbox-hit-test-zoomed.html
fast/forms/search-zoomed.html
fast/forms/slider-zoomed.html
- 11:54 AM Changeset in webkit [41913] by
-
- 2 edits in trunk/WebCore
2009-03-23 Glen Murphy <glen@chromium.org>
Reviewed by Darin Fisher.
Fix Skia drawing of highly scaled bitmaps; the conversion to
IntRect produced visible layout test failures in highly scaled
coordinate systems.
Test: svg/custom/image-small-width-height.svg
- WebCore\platform\graphics\skia\ImageSkia.cpp:
- 11:27 AM Changeset in webkit [41912] by
-
- 5 edits in trunk
Provide JavaScript exception information after slow script timeout
Reviewed by Oliver Hunt.
- runtime/Completion.cpp: (JSC::evaluate): Set the exception object as the Completion object's value for slow script timeouts. This is used in WebCore when reporting the exception.
- runtime/ExceptionHelpers.cpp: (JSC::InterruptedExecutionError::toString): Added. Provides a description message for the exception when it is reported.
WebCore:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): Changed to report exceptions for the Interrupted completion type as well.
- 10:55 AM Changeset in webkit [41911] by
-
- 3 edits4 adds in trunk
2009-03-23 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
The rect for CSS 'clip' needs to have zooming applied to it.
Test: fast/css/clip-zooming.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- 9:47 AM Changeset in webkit [41910] by
-
- 2 edits in trunk/WebKit/mac
2009-03-23 Darin Adler <Darin Adler>
- WebView/WebTextIterator.h: Fixed a spelling error in a comment.
- 8:13 AM Changeset in webkit [41909] by
-
- 3 edits in trunk/JavaScriptCore
2009-03-23 Gustavo Noronha Silva <Gustavo Noronha Silva> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=24674
Crashes in !PLATFORM(MAC)'s formatLocaleDate, in very specific situations
Make sure strftime never returns 2-digits years to avoid ambiguity
and a crash. We wrap this new code option in HAVE_LANGINFO_H,
since it is apparently not available in all platforms.
- runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
- wtf/Platform.h:
- 8:07 AM Changeset in webkit [41908] by
-
- 2 edits in trunk/WebCore
2009-03-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
<rdar://problem/6704282>
https://bugs.webkit.org/show_bug.cgi?id=24719
QTMovieWinTimer logic inversion
Fix logic inversion in the Win32 timer used by QTMovieWin that caused it to always
use SetTimer, even when the intervals was below USER_TIMER_MINIMUM. A side effect of
this was that a movie timer would sometimes be blocked for significant amounts of time
because WM_TIMER messages are not processed when the thread's message queue has any
higher priority messages, and WebCore/Win's timer uses PostMessage for low interval
timers. Also change SetTimer call to use HWND and custom message instead of
timer function since the timer already has an HWND for processing PostMessage.
Not possible to make a test for this because it is so timing dependant.
- platform/graphics/win/QTMovieWinTimer.cpp: (TimerWindowWndProc): (setSharedTimerFireDelay):
- 8:02 AM Changeset in webkit [41907] by
-
- 55 edits12 adds in trunk
2009-03-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Update media element implementation to current HTML5 spec
New tests:
media/media-constants.html
media/video-seek-no-src-exception.html
media/video-source-add-src.html
media/video-src-invalid-remove.html
media/video-src-plus-source.html
media/video-timeupdate-during-playback.html
- dom/EventNames.h: Remove obsolute events, add new ones.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize new member vars. (WebCore::HTMLMediaElement::attributeChanged): Trigger load() only when we don't have a source. (WebCore::HTMLMediaElement::removedFromDocument): Deal with state name changes. (WebCore::HTMLMediaElement::scheduleProgressEvent): New, create a progress event and add it to the event queue to be dispatch when the timer fires. (WebCore::HTMLMediaElement::scheduleEvent): New, create a generic event and add it to the event queue to be dispatch when the timer fires. (WebCore::HTMLMediaElement::enqueueEvent): Add an event to the queue and ticke the asynch event timer. (WebCore::HTMLMediaElement::asyncEventTimerFired): Dispatch all pending events. (WebCore::HTMLMediaElement::loadTimerFired): Either trigger the initial load or try to load the next <source> url. (WebCore::HTMLMediaElement::load): Minor style change. (WebCore::HTMLMediaElement::loadInternal): The first part of the spec load algorithm, cleanup the current load (if any) and set up state for a new load. (WebCore::HTMLMediaElement::selectMediaResource): Deal with no 'src' or <source>, post 'loadstart' event, and initiate load from 'src' if present. (WebCore::HTMLMediaElement::loadNextSourceChild): Initiate load from next <source> url, or trigger noneSupported() if no more to consider. (WebCore::HTMLMediaElement::loadResource): Instantiate a new MediaPlayer and ask it to load a url. (WebCore::HTMLMediaElement::startProgressEventTimer): Start the repeating progress event timer. (WebCore::HTMLMediaElement::noneSupported): Post error event and set up state when no valid media url was found. (WebCore::HTMLMediaElement::mediaEngineError): Post error event and set up state when no valid media engine failed with a decode error or a network error. (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): (WebCore::HTMLMediaElement::setNetworkState): Updated for new spec network states. (WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged): (WebCore::HTMLMediaElement::setReadyState): Updated for new spec ready state. (WebCore::HTMLMediaElement::progressEventTimerFired): Bail if the network is not active. (WebCore::HTMLMediaElement::seek): Return INVALID_STATE_ERR exception if state is too low or if player hasn't been set up yet. This is necessary becase load() is async. Clear the flag we use to guard against sending 'ended' more than once. (WebCore::HTMLMediaElement::duration): Don't bother calling media engine before it has metadata. (WebCore::HTMLMediaElement::setDefaultPlaybackRate): Remove exception param, 0 is no longer an invalid rate. (WebCore::HTMLMediaElement::setPlaybackRate): Remove exception param, 0 is no longer an invalid rate. Cache rate being set so we can use it later if media engine isn't ready now. (WebCore::HTMLMediaElement::play): Remove exception param, play() before load() now just starts loading asynchronously. (WebCore::HTMLMediaElement::playInternal): Remove exception param. Fire 'waiting' or 'playing' event depending on current state. (WebCore::HTMLMediaElement::pause): Remove exception param, pause() before load() now just starts loading asynchronously. (WebCore::HTMLMediaElement::pauseInternal): Remove exception param. (WebCore::HTMLMediaElement::setVolume): dispatchEventAsync -> scheduleEvent (WebCore::HTMLMediaElement::setMuted): dispatchEventAsync -> scheduleEvent (WebCore::HTMLMediaElement::togglePlayState): Remove exception param. (WebCore::HTMLMediaElement::beginScrubbing): pause() doesn't take an exception param. (WebCore::HTMLMediaElement::startPlaybackProgressTimer): New, starts timer that fires 4 times per second when the movie is playing to timeupdate so we can post 'timeupdate' events. (WebCore::HTMLMediaElement::playbackProgressTimerFired): Timer proc. (WebCore::HTMLMediaElement::scheduleTimeupdateEvent): Bottleneck around scheduling a 'timeupdate' event because we both fire them them when the spec says we should and when the media engine says that time has jumped, but we don't want to fire more than one at a given movie time. We also use this bottleneck to keep track of the last time one was posted so we won't fire too often during playback. (WebCore::HTMLMediaElement::canPlay): readyState now tracks whether or not we have metadata. (WebCore::HTMLMediaElement::havePotentialSourceChild): New, checks to see if there are a <source> element with a 'src' attribute that we have not tried to load yet. (WebCore::HTMLMediaElement::nextSourceChild): New, returns the url and content type of the next <source> element that we haven't tried to load. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Schedule 'seeked' event when seeking completes. Set a flag when we post the 'ended' event, clear it when time changed and we aren't at the end since some media engines call this proc more than once when playback reaches the end and stops, but we don't want to post 'ended' more than once. (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): New, added so media engine can inform when the movie duration changes and we can post 'durationchanged' event. (WebCore::HTMLMediaElement::mediaPlayerRateChanged): New, added so media engine can inform when the rate changed and we can updated our cached rate. This is useful because we only want to know post periodic 'timeupdate' events when the movie is actually playing, and because we want to know the actual playback rate when it differs from what we tried to set. (WebCore::HTMLMediaElement::mediaPlayerSizeChanged): New, added so media engine can inform when a movie's intrinsic size changes and we can inform the renderer. (WebCore::HTMLMediaElement::potentiallyPlaying): Renamed from activelyPlaying since the spec now uses "actively playing" for this concept. Update logic for new state names and un-comment calls to stoppedDueToErrors() and pausedForUserInteraction() since the spec says those condiditons are part of the answer. (WebCore::HTMLMediaElement::endedPlayback): Update logic for new state names. (WebCore::HTMLMediaElement::stoppedDueToErrors): New, spec says this logic should be part of the determination of "potentially playing". (WebCore::HTMLMediaElement::pausedForUserInteraction): New, placeholder for when (if) user agent supports this spec concept. (WebCore::HTMLMediaElement::updatePlayState): Stop timer used to fire periodic 'timeupdate' events when we pauses the movie. Set the media engine rate before calling play() in case it wasn't set up when the rate was changed. (WebCore::HTMLMediaElement::stopPeriodicTimers): New, stop the progress event and 'timeupate' event timers. (WebCore::HTMLMediaElement::userCancelledLoad): New, logic pulled out of documentWillBecomeInactive and updated for the current spec. (WebCore::HTMLMediaElement::documentWillBecomeInactive): Moved some logic to userCancelledLoad. (WebCore::HTMLMediaElement::documentDidBecomeActive): Update comments. (WebCore::HTMLMediaElement::initialURL): Update for refactoring of code that determines the initial url.
- html/HTMLMediaElement.h: Change ReadyState and NetworkState enums to match names in the spec, update for changes in .cpp. (WebCore::HTMLMediaElement::):
- html/HTMLMediaElement.idl: Update ready state and network state constants for spec changes. defaultPlaybackRate, playbackRate, play(), and pause() no longer raise exceptions.
- html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::insertedIntoDocument): Update for network state name changes.
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::updatePosterImage): Update for ready state name changes.
- html/MediaError.h: (WebCore::MediaError::): add MEDIA_ERR_NONE_SUPPORTED.
- html/MediaError.idl: add MEDIA_ERR_NONE_SUPPORTED.
- loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler): play() and pause() don't take an exception.
- platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::readyState): Update for newtork state name changes. (WebCore::MediaPlayer::sizeChanged): New, so engine can report intrinsic size changes. (WebCore::MediaPlayer::rateChanged): New, so engine can report rate changes. (WebCore::MediaPlayer::durationChanged): New, so engine can report duration changes.
- platform/graphics/MediaPlayer.h: Update NetworkState and ReadyState enum names to match spec states. (WebCore::MediaPlayerClient::mediaPlayerDurationChanged): New. (WebCore::MediaPlayerClient::mediaPlayerRateChanged): New. (WebCore::MediaPlayerClient::mediaPlayerSizeChanged): New. (WebCore::MediaPlayer::):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Update for network/ready state name changes. (WebCore::MediaPlayerPrivate::load): Ditto. (WebCore::MediaPlayerPrivate::updateStates): Ditto. (WebCore::MediaPlayerPrivate::loadingFailed): Ditto.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h: Update for network/ready state name changes. Remove endPointTimer, it is no longer necessary. Add m_enabledTrackCount and m_duration. (WebCore::MediaPlayerPrivate::metaDataAvailable):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): No more m_endPointTimer or m_endTime. Initialize m_enabledTrackCount and m_duration. Update for network/ready state name changes. (WebCore::MediaPlayerPrivate::load): Update for network/ready state name changes. (WebCore::MediaPlayerPrivate::play): No more m_endPointTimer. (WebCore::MediaPlayerPrivate::pause): Ditto. (WebCore::MediaPlayerPrivate::currentTime): No more m_endTime. (WebCore::MediaPlayerPrivate::seek): Ditto. (WebCore::MediaPlayerPrivate::doSeek): Ditto, plus don't call setRate(0) when the rate is already zero. (WebCore::MediaPlayerPrivate::setEndTime): No more m_endTime. (WebCore::MediaPlayerPrivate::updateStates): Update for network/ready state name changes. Return different errors depending on what causes a failure. Watch for and report duration changes. (WebCore::MediaPlayerPrivate::rateChanged): Report rate changes. (WebCore::MediaPlayerPrivate::sizeChanged): Report size changes. (WebCore::MediaPlayerPrivate::didEnd): No more endpoint timer. (WebCore::MediaPlayerPrivate::setVisible): Update for network/ready state name changes. (WebCore::MediaPlayerPrivate::disableUnsupportedTracks): Don't return number of unsupported tracks, store in m_enabledTrackCount so we can use it to help determine causes of failure.
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Update for network/ready state name changes. (WebCore::MediaPlayerPrivate::load): Ditto. (WebCore::MediaPlayerPrivate::duration): Ditto. (WebCore::MediaPlayerPrivate::updateStates): Ditto. (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): No more m_endPointTimer. Update for network/ready state name changes. (WebCore::MediaPlayerPrivate::load): Update for network/ready state name changes. No more m_endPointTimer. (WebCore::MediaPlayerPrivate::play): No more m_endPointTimer. (WebCore::MediaPlayerPrivate::pause): Ditto. (WebCore::MediaPlayerPrivate::setEndTime): Ditto. (WebCore::MediaPlayerPrivate::updateStates): Update for network/ready state name changes. (WebCore::MediaPlayerPrivate::didEnd): No more m_endPointTimer.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
- rendering/MediaControlElements.cpp: (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Update for network/ready state name changes. (WebCore::MediaControlSeekButtonElement::defaultEventHandler): Ditto.
2009-03-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=24588
Bug 24588: Update media element implementation to current spec
- media/media-constants-expected.txt: Test all media constants.
- media/media-constants.html: Ditto.
- media/remove-from-document-expected.txt: Updated for spec changes.
- media/remove-from-document-no-load.html: Ditto.
- media/remove-from-document.html: Ditto.
- media/unsupported-rtsp-expected.txt: Ditto.
- media/unsupported-rtsp.html: Ditto.
- media/video-currentTime-set-expected.txt: Ditto.
- media/video-currentTime-set.html: Ditto.
- media/video-error-does-not-exist-expected.txt: Ditto.
- media/video-error-does-not-exist.html: Ditto.
- media/video-load-networkState-expected.txt: Ditto.
- media/video-load-networkState.html: Ditto.
- media/video-load-readyState-expected.txt: Ditto.
- media/video-load-readyState.html: Ditto.
- media/video-loop-expected.txt: Ditto.
- media/video-loop.html: Ditto.
- media/video-pause-empty-events-expected.txt: Ditto.
- media/video-pause-empty-events.html: Ditto.
- media/video-play-empty-events-expected.txt: Ditto.
- media/video-play-empty-events.html: Ditto.
- media/video-play-pause-events-expected.txt: Ditto.
- media/video-play-pause-events.html: Ditto.
- media/video-play-pause-exception-expected.txt: Ditto.
- media/video-play-pause-exception.html: Ditto.
- media/video-seek-no-src-exception-expected.txt: Test that seeking whene there is no 'src' attribute throws an INVALID_STATE_ERR exception.
- media/video-seek-no-src-exception.html:
- media/video-seek-past-end-playing-expected.txt: Ditto.
- media/video-seek-past-end-playing.html: Ditto.
- media/video-seeking-expected.txt: Ditto.
- media/video-seeking.html: Ditto.
- media/video-source-add-src-expected.txt: Test that adding a 'src' attribute does nothing when a <source> element has already been chosen.
- media/video-source-add-src.html:
- media/video-src-change-expected.txt: Ditto.
- media/video-src-change.html: Ditto.
- media/video-src-invalid-remove-expected.txt: Test that removing invalid 'src' attribute triggers <source> elements loading.
- media/video-src-invalid-remove.html:
- media/video-src-plus-source-expected.txt: Test that a <source> element is not used when a bogus 'src' attribute is present.
- media/video-src-plus-source.html:
- media/video-src-remove-expected.txt: Ditto.
- media/video-src-remove.html: Ditto.
- media/video-test.js: (findMediaElement): (testExpected): (waitForEvent): (failTest):
- media/video-timeupdate-during-playback-expected.txt: Test that 'timeupdate' events are posted while an element is playing but not while paused.
- media/video-timeupdate-during-playback.html:
- platform/mac/Skipped: Skip media/video-error-abort.html for now, need to figure out how to test now that the 'loadstart' event is now fired asynchronously.
- platform/win/Skipped
- 5:43 AM Changeset in webkit [41906] by
-
- 2 edits in trunk
2009-03-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
Require gnome-keyring 2.26.0, since we were depending on an
unreleased trunk revision between 2.25.91 and 2.26.0.
- configure.ac:
Mar 22, 2009:
- 11:01 PM Changeset in webkit [41905] by
-
- 4 edits in trunk/JavaScriptCore
Fix exception handling in API
Reviewed by Cameron Zwarich.
We can't just use the ExecState exception slot for returning exceptions
from class introspection functions provided through the API as many JSC
functions will explicitly clear the ExecState exception when returning.
- 9:31 PM Changeset in webkit [41904] by
-
- 1 edit in trunk/JavaScriptCore/jit/JITStubs.cpp
Fix instanceof implementation to handle API object overriding hasInstance
Reviewed by Cameron Zwarich.
We can only take the fast paths for instanceof if the object doesn't override
hasInstance, so we have to check for that.
- 8:46 PM Changeset in webkit [41903] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by John Sullivan.
- fix <rdar://problem/6640741> Messages not displaying after the Safari 4 beta was installed
Mail assumes that if -[WebArchive subresources] is not nil, then it
contains at least one object.
- WebView/WebArchive.mm: (-[WebArchive subresources]): Preserve the behavior of returning nil if there are no subresources.
- 2:12 PM Companies and Organizations that have contributed to WebKit edited by
- Add Nuanti (diff)
- 12:50 PM Changeset in webkit [41902] by
-
- 2 edits in trunk/WebCore
2009-03-22 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Image-map code in RenderImage could result in RenderImage::nodeAtPoint()
setting HitTestResult::innerNode(), but returning false, which violates
hit testing rules. Use a temporary HitTestResult so that we only fill in
result when we know we've hit.
- rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint):
- 12:45 PM Changeset in webkit [41901] by
-
- 2 edits in trunk/WebCore
wxGTK build fix. Add missing header.
- 11:43 AM Changeset in webkit [41900] by
-
- 3 edits2 adds in trunk
2009-03-22 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Fix hit testing regression from r41840. We need to pass the temporary
HitTestResult when testing sublayers, then only copy to 'result' when
the layer is known to have been hit.
Test: fast/layers/zindex-hit-test.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
- 10:35 AM Changeset in webkit [41899] by
-
- 11 edits in trunk/WebCore
2009-03-20 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Fix hit testing on video controls after full page zoom by fixing wider issue
with event->pageX(), pageY() with zooming. pageX and pageY are "fixed" to be
invariant under zooming (for JavaScript), so we keep an actual page point around
in MouseEvent::absoluteLocation() to avoid the need to factor in zooming everywhere.
- dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::initCoordinates): (WebCore::MouseRelatedEvent::computePageLocation):
- dom/MouseRelatedEvent.h: (WebCore::MouseRelatedEvent::absoluteLocation): (WebCore::MouseRelatedEvent::setAbsoluteLocation): Member var, and getter and setter for absoluteLocation. New method, computePageLocation(), to compute the actual page point, and call it when creating and initting mouse-related events.
- dom/Node.cpp: (WebCore::Node::dispatchMouseEvent): (WebCore::Node::dispatchWheelEvent): Keep non-adjusted pageX and pageY around, and call setAbsoluteLocation() on the event to replace a potentially rounded point.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Clean up slider handling code.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Add FIXME comment for use of offsetX/offsetY.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): Use absoluteLocation() when hit testing for context menus.
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize): Use absoluteLocation() when resizing frames.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::forwardEvent): Use absoluteLocation() when hit testing media controls.
- rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): (WebCore::RenderSlider::mouseEventIsInThumb): Use absoluteLocation() when handling slider events.
(WebCore::RenderSlider::forwardEvent):
Factor some code out of HTMLInputElement::defaultEventHandler().
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::forwardEvent): Use absoluteLocation() when hit testing search field buttons, which fixees bugs in the search field with zooming.
- 12:34 AM Changeset in webkit [41898] by
-
- 1 edit5 adds in trunk/WebCore
2009-03-21 David Levin <levin@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=24727
Add V8XMLHttpRequest*.
- bindings/v8/V8XMLHttpRequestUtilities.cpp: Added.
- bindings/v8/V8XMLHttpRequestUtilities.h: Added.
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: Added.
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: Added.
- bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: Added.
- 12:34 AM Changeset in webkit [41897] by
-
- 1 edit2 adds in trunk/WebCore
2009-03-21 David Levin <levin@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=24725
Add V8NodeFilter.
- bindings/v8/V8NodeFilter.cpp: Added.
- bindings/v8/V8NodeFilter.h: Added.
