Context Navigation

← Previous Period
Next Period →

Timeline

Sep 23, 2009:

11:49 PM Changeset in webkit [48704] by ggaren@apple.com

2 edits in trunk/WebCore

32-bit build fix: restore previous cast that I thought was unnecessary.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-23

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didSendData):
(WebCore::XMLHttpRequest::didReceiveData):

11:39 PM Changeset in webkit [48703] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

A piece of my last patch that I forgot.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-23

wtf/HashCountedSet.h:

(WTF::::clear): Added HashCountedSet::clear.

11:10 PM Changeset in webkit [48702] by zoltan@webkit.org

2 edits in trunk/JavaScriptCore

2009-09-24 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Avoid clear_cache built-in function if DISABLE_BUILTIN_CLEAR_CACHE define is set
https://bugs.webkit.org/show_bug.cgi?id=28886

There are some GCC packages (for example GCC-2006q3 from CodeSourcery)
which contain clear_cache built-in function only for C while the C++
version of clear_cache is missing on ARM architectures.

Fixed a small bug in the inline assembly of cacheFlush function on
ARM_TRADITIONAL.

jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):

10:53 PM Changeset in webkit [48701] by ggaren@apple.com

131 edits
6 adds
1 delete in trunk

JavaScriptCore: Added the ability to swap vectors with inline capacities, so you can
store a vector with inline capacity in a hash table.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-23
Reviewed by Sam Weinig.

wtf/Vector.h:

(WTF::swap):
(WTF::VectorBuffer::swap):

WebCore: Bring a little sanity to this crazy EventTarget world of ours
https://bugs.webkit.org/show_bug.cgi?id=29701

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-23
Reviewed by Sam Weinig.

Lots of EventTarget refactoring to achieve a single shared implementation
that fixes some of the performance and correctness bugs of the many individual
implementations, and makes reasoning about EventTargets and EventListeners
much easier.

The basic design is this:

EventTarget manages a set of EventListeners.
onXXX EventListener attributes forward to standard EventTarget APIs.
Since the onXXX code is repetitive, it is usually done with macros of the form DEFINE_ATTRIBUTE_EVENT_LISTENER(attributeName).
EventTarget provides a shared implementation of dispatchEvent, which subclasses with special event dispatch rules, like Node, override.
To support Node, which lazily instantiates its EventTarget data, EventTarget has no data members, and instead makes a virtual call to get its data from wherever its subclass chose to store it.

Code that used to call dispatchEvent, passing an ExceptionCode paratmeter,
even though no exception could be thrown, has been changed not to do so,
to improve clarity and performance.

Code that used to call a special dispatchXXXEvent function, which just
turned around and called dispatchEvent, has been changed to call
dispatchEvent, to improve clarity and performance.

WebCore.base.exp:
WebCore.xcodeproj/project.pbxproj: Another day in the life of a WebKit

engineer.

bindings/js/JSDOMBinding.cpp:

(WebCore::isObservableThroughDOM): Updated for Node API change. Added
"is not in the document but is firing event listeners" as a condition
that makes a Node observable in the DOM, so that event listeners firing
on removed nodes are not destroyed midstream. (This was a long-standing
bug that was somewhat hidden by the old implementation's habit of
copying the RegisteredEventListener vector before firing events, which
would keep almost all the relevant objects from being destroyed.)

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent): Removed the isWindowEvent flag
because it was one of the most elaborately planned no-ops in the history
of software crime, and one of the reasons clients thought they needed more
than one dispatchEvent function even though they didn't.

bindings/js/JSEventListener.h:

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::markChildren):
(WebCore::JSMessagePort::markChildren):

bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::markChildren):

bindings/js/JSAbstractWorkerCustom.cpp:
bindings/js/JSDOMApplicationCacheCustom.cpp:
bindings/js/JSDedicatedWorkerContextCustom.cpp:
bindings/js/JSEventSourceCustom.cpp:
bindings/js/JSMessagePortCustom.cpp:
bindings/js/JSSharedWorkerContextCustom.cpp: Removed.
bindings/js/JSWebSocketCustom.cpp:
bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::markChildren):

bindings/js/JSWorkerCustom.cpp:
bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::markChildren):

bindings/js/JSXMLHttpRequestUploadCustom.cpp:

(WebCore::JSXMLHttpRequestUpload::markChildren): EventListener marking is
now autogenerated. Classes that still have custom mark functions for other
reasons now call a shared EventTarget API to mark their EventListeners.

bindings/objc/ObjCEventListener.h:
bindings/objc/ObjCEventListener.mm:

(WebCore::ObjCEventListener::handleEvent): Bye bye isWindowEvent.

bindings/scripts/CodeGeneratorJS.pm: Autogeneration support for

marking and invalidating event listeners.

dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

dom/ContainerNode.cpp:

(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::willRemoveChild):
(WebCore::ContainerNode::appendChild):
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):

dom/Document.cpp:

(WebCore::Document::removeAllEventListeners):
(WebCore::Document::implicitClose):
(WebCore::Document::setFocusedNode):
(WebCore::Document::dispatchWindowEvent):
(WebCore::Document::dispatchWindowLoadEvent):
(WebCore::Document::finishedParsing):

dom/Document.h: Use dispatchEvent directly.

dom/Element.h: Moved a few event listener attributes down from Node,

since they don't apply to all Nodes, only Elements.

dom/EventListener.h: Removed isWindowEvent parameter.

dom/EventNames.h: Added the "display" event name, so it works correctly

with attribute macros, and for performance.

dom/EventTarget.cpp:

(WebCore::forbidEventDispatch):
(WebCore::allowEventDispatch):
(WebCore::eventDispatchForbidden): Made this code (embarrasingly) thread
safe, since it's now called on multiple threads. (Currently, we only forbid
event dispatch on the main thread. If we ever want to forbid event dispatch
on secondary threads, we can improve it then.)

(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::setAttributeEventListener):
(WebCore::EventTarget::getAttributeEventListener):
(WebCore::EventTarget::clearAttributeEventListener):
(WebCore::EventTarget::dispatchEvent):
(WebCore::EventTarget::fireEventListeners):
(WebCore::EventTarget::getEventListeners):
(WebCore::EventTarget::removeAllEventListeners):

dom/EventTarget.h:

(WebCore::FiringEventEndIterator::FiringEventEndIterator):
(WebCore::EventTarget::ref):
(WebCore::EventTarget::deref):
(WebCore::EventTarget::markEventListeners):
(WebCore::EventTarget::invalidateEventListeners):
(WebCore::EventTarget::isFiringEventListeners):
(WebCore::EventTarget::hasEventListeners): The ONE TRUE IMPLEMENTATION of
EventTarget APIs, crafted from an amalgam of all the different versions
we used to have. The most significant change here is that we no longer
make a copy of an EventListener vector before firing the events in the
vector -- instead, we use a reference to the original vector, along with
a notification mechanism for the unlikely case when an EventListener is
removed from the vector. This substantially reduces malloc, copying, and
refcount overhead, and complexity.

dom/InputElement.cpp:

(WebCore::InputElement::setValueFromRenderer):

dom/MessageEvent.h:

(WebCore::MessageEvent::create): Use dispatchEvent directly.

dom/MessagePort.cpp:

(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::eventTargetData):
(WebCore::MessagePort::ensureEventTargetData):

dom/MessagePort.h:

(WebCore::MessagePort::setOnmessage):
(WebCore::MessagePort::onmessage):

dom/MessagePort.idl: Removed custom EventTarget implementation.

dom/MutationEvent.h:

(WebCore::MutationEvent::create): Added some default values so callers
can construct MutationEvents more easily, without calling a custom dispatch
function.

dom/Node.cpp:

(WebCore::Node::addEventListener):
(WebCore::Node::removeEventListener):
(WebCore::Node::eventTargetData):
(WebCore::Node::ensureEventTargetData):
(WebCore::Node::handleLocalEvents):
(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchGenericEvent):
(WebCore::Node::dispatchSubtreeModifiedEvent):
(WebCore::Node::dispatchUIEvent):
(WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchWheelEvent):
(WebCore::Node::dispatchFocusEvent):
(WebCore::Node::dispatchBlurEvent):

dom/Node.h:

(WebCore::Node::preDispatchEventHandler):
(WebCore::Node::postDispatchEventHandler):

dom/Node.idl:
dom/NodeRareData.h:

(WebCore::NodeRareData::eventTargetData):
(WebCore::NodeRareData::ensureEventTargetData): Use the shared EventTarget
interface, and call dispatchEvent directly instead of custom dispatchXXXEvent
functions that just forwarded to dispatchEvent.

dom/RegisteredEventListener.cpp:
dom/RegisteredEventListener.h:

(WebCore::RegisteredEventListener::RegisteredEventListener):
(WebCore::operator==): This is just a simple struct now, since we no longer
do a complicated copy / refCount / isRemoved dance just to honor the rule
that an EventListener can be removed during event dispatch.

history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): Removed another custom dispatchEvent.

html/HTMLBodyElement.cpp:
html/HTMLBodyElement.h: Use the shared EventTarget API.

html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
(WebCore::HTMLFormControlElement::checkValidity):

html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::handleLocalEvents):
(WebCore::HTMLFormElement::prepareSubmit):
(WebCore::HTMLFormElement::reset):

html/HTMLFormElement.h: Use the standard dispatchEvent API.

html/HTMLFrameSetElement.cpp:
html/HTMLFrameSetElement.h: Use the shared EventTarget API.

html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::dispatchLoadEvent):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::onSearch):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadInternal):

html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::dispatchLoadEvent):
(WebCore::HTMLScriptElement::dispatchErrorEvent):

html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::errorEventTimerFired):

html/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::notifyFinished): Use the standard dispatchEvent API.

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::handleEvent):

inspector/InspectorDOMAgent.h:
inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::handleEvent):

inspector/InspectorDOMStorageResource.h:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):
(WebCore::HashChangeEventTask::performTask):
(WebCore::FrameLoader::pageHidden): No more isWindowEvent.

loader/ImageDocument.cpp:

(WebCore::ImageEventListener::handleEvent):

loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::CallCacheListenerTask::performTask):

loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::notifyDOMApplicationCache):

loader/appcache/ApplicationCacheHost.h:
loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::eventTargetData):
(WebCore::DOMApplicationCache::ensureEventTargetData):

loader/appcache/DOMApplicationCache.h:
loader/appcache/DOMApplicationCache.idl: Switched to the standard

EventTarget API. As a part of this, I switched this class from using a
custom internal event name enumeration to using the standard EventNames.

notifications/Notification.cpp:

(WebCore::Notification::eventTargetData):
(WebCore::Notification::ensureEventTargetData):

notifications/Notification.h:

(WebCore::Notification::scriptExecutionContext):

notifications/Notification.idl: Switched to the standard EventTarget API.

page/DOMWindow.cpp:

(WebCore::PostMessageTimer::event):
(WebCore::windowsWithUnloadEventListeners):
(WebCore::windowsWithBeforeUnloadEventListeners):
(WebCore::allowsBeforeUnloadListeners):
(WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
(WebCore::DOMWindow::pendingUnloadEventListeners):
(WebCore::DOMWindow::dispatchAllPendingUnloadEvents): Changed the "pending"
unload / beforeunload listener tracker just to track which windows had
such listeners, instead of actually keeping a copy of the listeners. Now,
this code can use the standard EventTarget API.

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::postMessageTimerFired):
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::dispatchLoadEvent):
(WebCore::DOMWindow::dispatchEvent):
(WebCore::DOMWindow::removeAllEventListeners):
(WebCore::DOMWindow::captureEvents):
(WebCore::DOMWindow::releaseEvents):
(WebCore::DOMWindow::eventTargetData):
(WebCore::DOMWindow::ensureEventTargetData):

page/DOMWindow.h:
page/DOMWindow.idl: Use the standard EventTarget APIs.

page/EventHandler.cpp:

(WebCore::EventHandler::canMouseDownStartSelect):
(WebCore::EventHandler::canMouseDragExtendSelect):
(WebCore::EventHandler::sendResizeEvent):
(WebCore::EventHandler::sendScrollEvent): Use dispatchEvent directly.

page/EventSource.cpp:

(WebCore::EventSource::endRequest):
(WebCore::EventSource::didReceiveResponse):
(WebCore::EventSource::parseEventStreamLine):
(WebCore::EventSource::stop):
(WebCore::EventSource::createMessageEvent):
(WebCore::EventSource::eventTargetData):
(WebCore::EventSource::ensureEventTargetData):

page/EventSource.h:
page/EventSource.idl: Use the standard EventTarget APIs.

page/FocusController.cpp:

(WebCore::dispatchEventsOnWindowAndFocusedNode):
(WebCore::FocusController::setFocusedFrame):

page/Frame.cpp:

(WebCore::Frame::shouldClose):

page/Frame.h:
page/Page.cpp:

(WebCore::networkStateChanged):

page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::valueChanged):

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::selectionChanged):

rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::subtreeHasChanged): Use dispatchEvent.

svg/SVGElement.cpp:

(WebCore::hasLoadListener): Rewritten for new EventTarget API.

svg/SVGElementInstance.cpp:

(WebCore::dummyEventTargetData):
(WebCore::SVGElementInstance::addEventListener):
(WebCore::SVGElementInstance::removeEventListener):
(WebCore::SVGElementInstance::removeAllEventListeners):
(WebCore::SVGElementInstance::dispatchEvent):
(WebCore::SVGElementInstance::eventTargetData):
(WebCore::SVGElementInstance::ensureEventTargetData): Use the EventTarget API.

svg/SVGElementInstance.h:
svg/SVGImageLoader.cpp:

(WebCore::SVGImageLoader::dispatchLoadEvent):

svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::dispatchErrorEvent): Use dispatchEvent directly.

svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::transferEventListenersToShadowTree): Updated for
new EventTarget API.

svg/animation/SVGSMILElement.cpp:

(WebCore::ConditionEventListener::handleEvent): No more isWindowEvent.

websockets/WebSocket.cpp:

(WebCore::ProcessWebSocketEventTask::create):
(WebCore::ProcessWebSocketEventTask::performTask):
(WebCore::ProcessWebSocketEventTask::ProcessWebSocketEventTask):
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didReceiveMessage):
(WebCore::WebSocket::didClose):
(WebCore::WebSocket::eventTargetData):
(WebCore::WebSocket::ensureEventTargetData):

websockets/WebSocket.h:
websockets/WebSocket.idl:
workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::eventTargetData):
(WebCore::AbstractWorker::ensureEventTargetData):

workers/AbstractWorker.h:
workers/AbstractWorker.idl:
workers/DedicatedWorkerContext.cpp:
workers/DedicatedWorkerContext.h:
workers/DedicatedWorkerContext.idl:
workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerConnectTask::performTask):
(WebCore::SharedWorkerScriptLoader::load):
(WebCore::SharedWorkerScriptLoader::notifyFinished):

workers/SharedWorker.idl:
workers/SharedWorkerContext.cpp:

(WebCore::createConnectEvent):

workers/SharedWorkerContext.h:
workers/SharedWorkerContext.idl:
workers/Worker.cpp:

(WebCore::Worker::notifyFinished):

workers/Worker.h:
workers/Worker.idl:
workers/WorkerContext.cpp:

(WebCore::WorkerContext::eventTargetData):
(WebCore::WorkerContext::ensureEventTargetData):

workers/WorkerContext.h:
workers/WorkerContext.idl:
workers/WorkerMessagingProxy.cpp:

(WebCore::MessageWorkerContextTask::performTask):
(WebCore::MessageWorkerTask::performTask):
(WebCore::WorkerExceptionTask::performTask):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::callReadyStateChangeListener):
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::abort):
(WebCore::XMLHttpRequest::networkError):
(WebCore::XMLHttpRequest::abortError):
(WebCore::XMLHttpRequest::didSendData):
(WebCore::XMLHttpRequest::didReceiveData):
(WebCore::XMLHttpRequest::eventTargetData):
(WebCore::XMLHttpRequest::ensureEventTargetData):

xml/XMLHttpRequest.h:
xml/XMLHttpRequest.idl:
xml/XMLHttpRequestProgressEvent.h:

(WebCore::XMLHttpRequestProgressEvent::create):

xml/XMLHttpRequestUpload.cpp:

(WebCore::XMLHttpRequestUpload::eventTargetData):
(WebCore::XMLHttpRequestUpload::ensureEventTargetData):

xml/XMLHttpRequestUpload.h:
xml/XMLHttpRequestUpload.idl: Use new EventTarget API.

WebKit/mac: Updated for a WebCore rename.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-23
Reviewed by Sam Weinig.

WebView/WebFrame.mm:

(-[WebFrame _cacheabilityDictionary]):

LayoutTests: Layout tests for event target sanitization.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-23
Reviewed by Sam Weinig.

New tests for event dispatch:

fast/events/event-attributes-after-exception-expected.txt: Added.
fast/events/event-attributes-after-exception.html: Added.
fast/events/event-fire-order-expected.txt: Added.
fast/events/event-fire-order.html: Added.
fast/events/event-fired-after-removal-expected.txt: Added.
fast/events/event-fired-after-removal.html: Added.

Fixed these tests:

fast/xmlhttprequest/xmlhttprequest-get-expected.txt: eventPhase should

be AT_TARGET (2) when firing an event on an XHR, not INVALID (0).

http/tests/xmlhttprequest/infoOnProgressEvent-expected.txt: ditto

http/tests/xmlhttprequest/event-target-expected.txt:
http/tests/xmlhttprequest/event-target.html: Removing an event listener

during event dispatch should prevent it from firing. (This test was backwards.)

svg/custom/loadevents-capturing.svg: Enhanced this test to tell you

why it fails when it fails. Changed it to register runTest() (now named
reportResults()) using addEventListener() instead of the 'onload' attribute.
The test relies on reportResults() running after handler(), so it needs
to register reportResults() after handler().

10:00 PM Changeset in webkit [48700] by ddkilzer@apple.com

3 edits
2 adds in trunk/WebKitTools

<http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool

Reviewed by Darin Adler.

Also fixed a bug where specifying a revision on the command-line
as 'r12345' would fail. See <http://webkit.org/b/29699>.

Scripts/bugzilla-tool: Updated module import statements. (parse_bug_id): Removed. Moved to bugzilla.py. (bug_comment_from_svn_revision): Removed. Moved to comments.py. (bug_comment_from_commit_text): Removed. Moved to comments.py. (MarkBugFixed): Removed. Code moved to mark-bug-fixed. (BugzillaTool.init): Removed mark-fixed subcommand.
Scripts/mark-bug-fixed: Added.
Scripts/modules/bugzilla.py: (parse_bug_id): Added. Moved from bugzilla-tool.
Scripts/modules/comments.py: Added. (bug_comment_from_svn_revision): Added. Moved from bugzilla-tool. (bug_comment_from_commit_text): Added. Moved from bugzilla-tool.

8:02 PM Changeset in webkit [48699] by eric@webkit.org

1 edit
4 adds in trunk/LayoutTests

2009-09-23 Karen Grünberg <karen+webkit@chromium.org>

Reviewed by Eric Seidel.

This tests all types of inputs text and password,
both enabled and disabled, the existing tests
weren't thorough enough for chromium.

https://bugs.webkit.org/show_bug.cgi?id=29502

fast/forms/basic-inputs.html: Added.
platform/mac/fast/forms/basic-inputs-expected.checksum: Added.
platform/mac/fast/forms/basic-inputs-expected.png: Added.
platform/mac/fast/forms/basic-inputs-expected.txt: Added.

7:55 PM Changeset in webkit [48698] by eric@webkit.org

8 edits
3 adds in trunk

2009-09-23 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Tests for maxLength of <textarea>
https://bugs.webkit.org/show_bug.cgi?id=29292

fast/forms/script-tests/textarea-maxlength.js: Added.
fast/forms/textarea-maxlength-expected.txt: Added.
fast/forms/textarea-maxlength.html: Added.

2009-09-23 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Support for maxLength of <textarea>
Move numGraphemeClusters() and numCharactersInGraphemeClusters() from InputElement to String. https://bugs.webkit.org/show_bug.cgi?id=29292

Test: fast/forms/textarea-maxlength.html

dom/InputElement.cpp: (WebCore::InputElement::sanitizeUserInputValue): (WebCore::InputElement::handleBeforeTextInsertedEvent):
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::defaultEventHandler): (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent): (WebCore::HTMLTextAreaElement::sanitizeUserInputValue): (WebCore::HTMLTextAreaElement::maxLength): (WebCore::HTMLTextAreaElement::setMaxLength):
html/HTMLTextAreaElement.h:
html/HTMLTextAreaElement.idl:
platform/text/PlatformString.h:
platform/text/String.cpp: (WebCore::String::numGraphemeClusters): (WebCore::String::numCharactersInGraphemeClusters):

7:44 PM Changeset in webkit [48697] by eric@webkit.org

6 edits in trunk

2009-09-23 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images
https://bugs.webkit.org/show_bug.cgi?id=29654

Enable tests which are now passing because of key event fixes.

platform/gtk/Skipped:

2009-09-23 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images
https://bugs.webkit.org/show_bug.cgi?id=29654

Give GDK_Backspace key events the proper text properties.

Instead of adding new tests, this change removes existing tests
from Gtk's skipped list.

platform/gtk/KeyEventGtk.cpp: (WebCore::keyIdentifierForGdkKeyCode): (WebCore::singleCharacterString):

2009-09-23 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images
https://bugs.webkit.org/show_bug.cgi?id=29654

Ensure that even when GTKSimpleIMContext filters non-IME keystrokes,
keyboard events are fired properly.

WebCoreSupport/EditorClientGtk.cpp: (WebKit::clearPendingIMData): (WebKit::imContextCommitted): (WebKit::imContextPreeditChanged): (WebKit::EditorClient::shouldBeginEditing): (WebKit::EditorClient::shouldEndEditing): (WebKit::interpretEditorCommandKeyEvent): (WebKit::handleCaretBrowsingKeyboardEvent): (WebKit::EditorClient::handleKeyboardEvent): (WebKit::EditorClient::handleInputMethodKeydown):

7:17 PM Changeset in webkit [48696] by eric@webkit.org

1 edit
33 adds in trunk/LayoutTests

2009-09-23 Eric Seidel <eric@webkit.org>

No review, just adding missing pixel test results from recent test additions.

platform/mac/compositing/generated-content-expected.checksum: Added.
platform/mac/compositing/generated-content-expected.png: Added.
platform/mac/compositing/masks/masked-ancestor-expected.png: Added.
platform/mac/compositing/masks/multiple-masks-expected.png: Added.
platform/mac/compositing/masks/simple-composited-mask-expected.png: Added.
platform/mac/compositing/reflections/reflection-on-composited-expected.checksum: Added.
platform/mac/compositing/reflections/reflection-on-composited-expected.png: Added.
platform/mac/compositing/self-painting-layers-expected.checksum: Added.
platform/mac/compositing/self-painting-layers-expected.png: Added.
platform/mac/compositing/sibling-positioning-expected.checksum: Added.
platform/mac/compositing/sibling-positioning-expected.png: Added.
platform/mac/fast/forms/button-style-color-expected.checksum: Added.
platform/mac/fast/forms/button-style-color-expected.png: Added.
platform/mac/fast/forms/text-style-color-expected.checksum: Added.
platform/mac/fast/forms/text-style-color-expected.png: Added.
platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.checksum: Added.
platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.png: Added.
platform/mac/fast/forms/textarea-placeholder-set-attribute-expected.checksum: Added.
platform/mac/fast/forms/textarea-placeholder-set-attribute-expected.png: Added.
platform/mac/fast/forms/textarea-placeholder-set-value-expected.checksum: Added.
platform/mac/fast/forms/textarea-placeholder-set-value-expected.png: Added.
platform/mac/fast/frames/viewsource-on-image-file-expected.checksum: Added.
platform/mac/fast/frames/viewsource-on-image-file-expected.png: Added.
platform/mac/fast/text/international/khmer-selection-expected.checksum: Added.
platform/mac/fast/text/international/khmer-selection-expected.png: Added.
platform/mac/media/audio-no-installed-engines-expected.checksum: Added.
platform/mac/media/audio-no-installed-engines-expected.png: Added.
platform/mac/media/controls-strict-expected.checksum: Added.
platform/mac/media/controls-strict-expected.png: Added.
platform/mac/media/controls-styling-expected.checksum: Added.
platform/mac/media/controls-styling-expected.png: Added.
platform/mac/media/video-no-audio-expected.checksum: Added.
platform/mac/media/video-no-audio-expected.png: Added.

6:56 PM Changeset in webkit [48695] by weinig@apple.com

3 edits
4 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=26989
Should allow navigation of top-level openers
<rdar://problem/7034025>

Reviewed by Adam Barth.

Allow navigation of cross-origin window.opener if it is top-level frame.

Test: http/tests/security/frameNavigation/cross-origin-opener.html

loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldAllowNavigation):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=26989
Should allow navigation of top-level openers
<rdar://problem/7034025>

Reviewed by Adam Barth.

http/tests/security/frameNavigation/cross-origin-opener-expected.txt: Added.
http/tests/security/frameNavigation/cross-origin-opener.html: Added.
http/tests/security/frameNavigation/resources/cross-origin-opener-opener.html: Added.
http/tests/security/frameNavigation/resources/navigate-opener.html: Added.

6:20 PM Changeset in webkit [48694] by eric@webkit.org

19 edits in trunk/LayoutTests

2009-09-23 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Updating 17 media layout tests to provide different media files based on supported codecs.

https://bugs.webkit.org/show_bug.cgi?id=29625

media/audio-constructor-autobuffer.html: Switched to findMediaFile().
media/audio-constructor-src.html: Ditto.
media/audio-constructor.html: Ditto.
media/audio-controls-rendering.html: Ditto.
media/audio-delete-while-slider-thumb-clicked.html: Ditto.
media/audio-delete-while-step-button-clicked.html: Ditto.
media/broken-video.html: Ditto.
media/controls-after-reload.html: Ditto, and also changed initial video to counting.mp4 since scaled-matrix.mov is QuickTime specific.
media/controls-right-click-on-timebar.html: Ditto.
media/event-attributes.html: Ditto.
media/media-load-event.html: Ditto.
media/media-startTime.html: Ditto.
media/progress-event-total-expected.txt: Added new total value.
media/progress-event-total.html: Switched to for loop and findMediaFile(), added new total value.
media/progress-event.html: Switched to findMediaFile().
media/remove-from-document-no-load.html: Ditto.
media/remove-from-document.html: Ditto.
media/unsupported-tracks.html: Ditto.

6:02 PM Changeset in webkit [48693] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-09-23 J-P Nurmi <jpnurmi@gmail.com>

Reviewed by Simon Hausmann.

Prevent QWebPage::setView() from changing the viewport size on the fly
in case the view doesn't actually change. QWebPage::setView() is
called upon every QWebGraphicsItem::hoverMoveEvent(), which forced
the viewport size to be equal to the size of the whole graphics view.

https://bugs.webkit.org/show_bug.cgi?id=29676

Api/qwebpage.cpp: (QWebPage::setView):

5:54 PM Changeset in webkit [48692] by eric@webkit.org

7 edits in trunk

2009-09-23 Marshall Culpepper <mculpepper@appcelerator.com>

Reviewed by Eric Seidel.

Added $(WebKitLibrariesDir)/include/cairo so cairo.h is found by
default when the necessary dependencies are extracted into the
WebKitLibrariesDir.
https://bugs.webkit.org/show_bug.cgi?id=29661

WebCore.vcproj/WebCoreCairo.vsprops:

2009-09-23 Marshall Culpepper <mculpepper@appcelerator.com>

Reviewed by Eric Seidel.

Added $(WebKitLibrariesDir)/include/cairo so cairo.h is found by
default when the necessary dependencies are extracted into the
WebKitLibrariesDir.
https://bugs.webkit.org/show_bug.cgi?id=29661

win/tools/vsprops/WinCairo.vsprops:

2009-09-23 Marshall Culpepper <mculpepper@appcelerator.com>

Reviewed by Eric Seidel.

jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
"false" in non-implemented stub for setAlwaysAcceptCookies.
https://bugs.webkit.org/show_bug.cgi?id=29661

DumpRenderTree/win/DumpRenderTree.vcproj:
DumpRenderTree/win/DumpRenderTree.cpp:

5:47 PM Changeset in webkit [48691] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-09-23 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Crash fix in QWebHistory back and forward methods.

QWebHistory::back() and QWebHistory::forward() were crashing on
ASSERT in WebCore::BackForwardList. The methods should check
canGoBack() and canGoForward() at the beginning.

https://bugs.webkit.org/show_bug.cgi?id=29675

Api/qwebhistory.cpp: (QWebHistory::back): (QWebHistory::forward):

5:40 PM Changeset in webkit [48690] by eric@webkit.org

1 edit
4 adds in trunk/LayoutTests

2009-09-23 Karen Grünberg <karen+webkit@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=29493

Added layout test to test buttons extensively
with different paddings. Testing both buttons
with images and text. Existing tests were not
comprehensive enough.

fast/forms/basic-buttons.html: Added.
platform/mac/fast/forms/basic-buttons-expected.checksum: Added.
platform/mac/fast/forms/basic-buttons-expected.png: Added.
platform/mac/fast/forms/basic-buttons-expected.txt: Added.

5:33 PM Changeset in webkit [48689] by Darin Adler

2 edits in trunk/WebKit/mac

Speed up access to history items by caching date computation.

Patch by Darin Adler <Darin Adler> on 2009-09-23
Reviewed by Dan Bernstein.

History/WebHistory.mm:

(getDayBoundaries): Refactored from timeIntervalForBeginningOfDay.
Returns the beginning of the day that the passed time is within and
the beginning of the next day.
(beginningOfDay): Added. Uses getDayBoundaries so it can be fast for
multiple dates within the same day, which is the common case.
(dateKey): Added. Calls beginningOfDay and converts to an integer.
(-[WebHistoryPrivate findKey:forDay:]): Changed to call dateKey
insetad of timeIntervalForBeginningOfDay.

5:33 PM Changeset in webkit [48688] by eric@webkit.org

4 edits in trunk/WebKit/qt

2009-09-23 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Bug fix. QWebHistory should call QWebPage::updateNavigationActions

In QWebHistory's methods that change item count or current item call
to QWebPage::updateNavigationActions should be executed.
QWebHistory::clear() and QWebHistory::restorState() were changed.
New helper method, QWebPagePrivate accesor, were created in
QWebHistoryPrivate class.
Two autotest were developed.

https://bugs.webkit.org/show_bug.cgi?id=29246

Api/qwebhistory.cpp: (QWebHistory::clear): (QWebHistory::restoreState): (QWebHistoryPrivate::page):
Api/qwebhistory_p.h:
tests/qwebhistory/tst_qwebhistory.cpp: (tst_QWebHistory::saveAndRestore_1): (tst_QWebHistory::clear):

4:27 PM Changeset in webkit [48687] by Darin Adler

4 edits
2 adds in trunk/WebCore

Crash when website does a history.back() followed by an alert()
https://bugs.webkit.org/show_bug.cgi?id=29686
rdar://problem/6984996

Patch by Darin Adler <Darin Adler> on 2009-09-23
Reviewed by Sam Weinig.

When loading is deferred, we need to defer timer-based loads
too, not just networking-driven loads. Otherwise we can get
syncronouse navigation while running a script, which leads to
crashes and other badness.

This patch includes a manual test; an automated test may be
possible some time in the future.

dom/Document.cpp:

(WebCore::Document::processHttpEquiv): Use scheduleLocationChange
instead of scheduleHTTPRedirection to implement the navigation
needed for x-frame-options.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader): Updated for data members with
new names and new data members.
(WebCore::FrameLoader::setDefersLoading): When turning deferral
off, call startRedirectionTimer and startCheckCompleteTimer, since
either of them might have been fired and ignored while defersLoading
was true.
(WebCore::FrameLoader::clear): Updated for replacement of the
m_checkCompletedTimer and m_checkLoadCompleteTimer timers.
(WebCore::FrameLoader::allAncestorsAreComplete): Added.
(WebCore::FrameLoader::checkCompleted): Added code to set
m_shouldCallCheckCompleted to false. Changed code that calls
startRedirectionTimer to call it unconditionally, since that
function now knows when to do work and doesn't expect callers
to handle that any more.
(WebCore::FrameLoader::checkTimerFired): Added. Replaces the old
timer fired callbacks. Calls checkCompleted and checkLoadComplete
as appropriate, but not when defersLoading is true.
(WebCore::FrameLoader::startCheckCompleteTimer): Added. Replaces
the two different calls to start timers before. Only starts the
timers if they are needed.
(WebCore::FrameLoader::scheduleCheckCompleted): Changed to call
startCheckCompleteTimer after setting boolean.
(WebCore::FrameLoader::scheduleCheckLoadComplete): Ditto.
(WebCore::FrameLoader::scheduleHistoryNavigation): Removed
canGoBackOrForward check. The logic works more naturally when
we don't do anything until the timer fires.
(WebCore::FrameLoader::redirectionTimerFired): Do nothing if
defersLoading is true. Also moved canGoBackOrForward check here.
(WebCore::FrameLoader::scheduleRedirection): Changed code that
calls startRedirectionTimer to do so unconditionally. That
function now handles the rules about when to start the timer
rather than expecting the caller to do so.
(WebCore::FrameLoader::startRedirectionTimer): Added code to
handle the case where there is no redirection scheduled,
where the timer is already active, or where this is a classic
redirection and there is an ancestor that has not yet completed
loading.
(WebCore::FrameLoader::completed): Call startRedirectionTimer
here directly instead of calling a cover named parentCompleted.
Hooray! One less function in the giant FrameLoader class!
(WebCore::FrameLoader::checkLoadComplete): Added code to set
m_shouldCallCheckLoadComplete to false.

loader/FrameLoader.h: Replaced the two functions

checkCompletedTimerFired and checkLoadCompleteTimerFired with
one function, checkTimerFired. Removed the parentCompleted
function. Added the startCheckCompleteTimer and
allAncestorsAreComplete functions. Replaced the
m_checkCompletedTimer and m_checkLoadCompleteTimer data
members with m_checkTimer, m_shouldCallCheckCompleted, and
m_shouldCallCheckLoadComplete.

manual-tests/go-back-after-alert.html: Added.
manual-tests/resources/alert-and-go-back.html: Added.

3:03 PM Changeset in webkit [48686] by ddkilzer@apple.com

3 edits
1 move in trunk/WebCore

<http://webkit.org/b/29660> Move "Generate 64-bit Export File" build phase script into DerivedSources.make

Reviewed by Mark Rowe.

The "Generate 64-bit Export File" build phase script generated
the WebCore.LP64.exp export file used to link 64-bit WebCore.
Instead of having a separate build phase script, move its
generation into DerivedSources.make where WebCore.exp is
generated.

DerivedSources.make: Added a rule to make WebCore.LP64.exp. Added code to append WebCore.PluginHostProcess.exp to $(WEBCORE_EXPORT_DEPENDENCIES) when WTF_USE_PLUGIN_HOST_PROCESS is set to 1.
WebCore.PluginHostProcess.exp: Renamed from WebCore/WebCore.LP64.exp.
WebCore.xcodeproj/project.pbxproj: Removed the "Generate 64-bit Export File" build phase script. Renamed WebCore.LP64.exp to WebCore.PluginHostProcess.exp.

3:03 PM Changeset in webkit [48685] by ddkilzer@apple.com

4 edits in trunk

Move definition of USE(PLUGIN_HOST_PROCESS) from WebKitPrefix.h to Platform.h

Reviewed by Mark Rowe.

JavaScriptCore:

wtf/Platform.h: Define WTF_USE_PLUGIN_HOST_PROCESS to 1 when building on 64-bit SnowLeopard. Define to 0 elsewhere.

WebKit/mac:

WebKitPrefix.h: Removed definition of WTF_USE_PLUGIN_HOST_PROCESS.

2:18 PM Changeset in webkit [48684] by pkasting@chromium.org

2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=29694
[Chromium] Eliminate dependency on gfx::Rect from ImageSkia.

Reviewed by Dimitri Glazkov.

platform/graphics/skia/ImageSkia.cpp:

(WebCore::drawResampledBitmap):

12:43 PM Changeset in webkit [48683] by timothy@apple.com

8 edits in trunk

WebCore: Prevent scrolling multiple elements during latched wheel events.

Reviewed by Anders Carlsson.

page/EventHandler.cpp:

(WebCore::scrollAndAcceptEvent):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleWheelEvent):

page/EventHandler.h:
rendering/RenderBox.cpp:

(WebCore::RenderBox::scroll):

rendering/RenderBox.h:

WebKit/mac: Prevent scrolling multiple frames during latched wheel events.

Reviewed by Anders Carlsson.

WebView/WebDynamicScrollBarsView.h:
WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView scrollWheel:]):

12:18 PM Changeset in webkit [48682] by kov@webkit.org

5 edits in trunk

WebKit/gtk

2009-09-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] need to dump number of pending unload handlers
https://bugs.webkit.org/show_bug.cgi?id=29685

webkit/webkitprivate.h:
webkit/webkitwebframe.cpp: (webkit_web_frame_get_pending_unload_event_count): New function to satisfy DRT needs.

WebKitTools

2009-09-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] need to dump number of pending unload handlers
https://bugs.webkit.org/show_bug.cgi?id=29685

Implement dumping of the number of pending unload handlers.

The following tests will pass:

fast/loader/unload-form-about-blank.html
fast/loader/unload-form-post-about-blank.html
fast/loader/unload-form-post.html
fast/loader/unload-form.html
fast/loader/unload-hyperlink.html
fast/loader/unload-javascript-url.html
fast/loader/unload-reload.html
fast/loader/unload-window-location.html

DumpRenderTree/gtk/DumpRenderTree.cpp: (getFrameNameSuitableForTestResult): (webViewLoadFinished):

11:52 AM Changeset in webkit [48681] by andersca@apple.com

2 edits in trunk/WebKit/win

<rdar://problem/7243354>
REGRESSION(48580-48636): Crash clicking embedded QT preview button on apple.com/trailers

Reviewed by Adam Roben.

Check for a null IWebPolicyDelegatePrivate.

WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::shouldLoadMediaElementURL):

11:19 AM Changeset in webkit [48680] by dbates@webkit.org

5 edits
4 adds in trunk

2009-09-23 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=29523

Fixes an issue where a JavaScript URL that was URL-encoded twice can bypass the
XSSAuditor.

The method FrameLoader::executeIfJavaScriptURL decodes the URL escape
sequences in a JavaScript URL before it is eventually passed to the XSSAuditor.
Because the XSSAuditor also decodes the URL escape sequences as part of its
canonicalization, the double decoding of a JavaScript URL would
not match the canonicalization of the input parameters.

Tests: http/tests/security/xssAuditor/iframe-javascript-url-url-encoded.html

http/tests/security/xssAuditor/javascript-link-url-encoded.html

bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): Moved call to XSSAuditor::canEvaluateJavaScriptURL into FrameLoader::executeIfJavaScriptURL.
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): Ditto.
loader/FrameLoader.cpp: (WebCore::FrameLoader::executeIfJavaScriptURL): Modified to call XSSAuditor::canEvaluateJavaScriptURL on the JavaScript URL before it is decoded.

2009-09-23 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=29523

Tests that JavaScript URLs that were URL-encoded twice do not bypass the XSSAuditor.

http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt: Added.
http/tests/security/xssAuditor/iframe-javascript-url-url-encoded.html: Added.
http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt: Added.
http/tests/security/xssAuditor/javascript-link-url-encoded.html: Added.

9:53 AM Changeset in webkit [48679] by hyatt@apple.com

4 edits
4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=29657
Columns don't break properly in positioned elements with a fixed height. Make sure that
a block is still considered to have columns even when the column count is 1 if the column
width is non-auto.

Reviewed by John Sullivan.

Added fast/multicol/positioned-with-constrained-height.html

WebCore:

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::setDesiredColumnCountAndWidth):

LayoutTests:

fast/multicol/positioned-with-constrained-height.html: Added.
platform/mac/fast/multicol/float-multicol-expected.txt:
platform/mac/fast/multicol/positioned-with-constrained-height-expected.checksum: Added.
platform/mac/fast/multicol/positioned-with-constrained-height-expected.png: Added.
platform/mac/fast/multicol/positioned-with-constrained-height-expected.txt: Added.

9:38 AM Changeset in webkit [48678] by zecke@webkit.org

2 edits in trunk/WebCore

2009-09-23 Holger Hans Peter Freyther <zecke@selfish.org>

Rubber-stamped by Simon Hausmann.

Add a null check for the Document*. In the mirror benchmarking
application a crash from a call from JavaScript was observed.

I was not able to come up with a test case for this issue.

platform/qt/CookieJarQt.cpp: (WebCore::cookieJar):

9:28 AM Changeset in webkit [48677] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-09-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Skipping new tests, and
plugins/destroy-during-npp-new.html, after reporting
https://bugs.webkit.org/show_bug.cgi?id=29683.

platform/gtk/Skipped:

9:23 AM Changeset in webkit [48676] by eric@webkit.org

3 edits in trunk/WebKit/qt

2009-09-23 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Tor Arne Vestbø.

Need to guard QX11Info include with Q_WS_X11.
That class may not be available (in QT 4.5 for Symbian, for instance).
Completes fixes in r48627 and r48604.

Api/qwebgraphicsitem.cpp:
Api/qwebview.cpp:

8:16 AM Changeset in webkit [48675] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-09-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Updated to match the changes done in r48566.

platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

6:59 AM Changeset in webkit [48674] by Simon Hausmann

2 edits in trunk/WebCore

Fix the Qt/Windows build, after the introduction of
the page client.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-23
Reviewed by Tor Arne Vestbø.

plugins/win/PluginViewWin.cpp:

(windowHandleForPageClient):
(WebCore::PluginView::getValue):
(WebCore::PluginView::forceRedraw):
(WebCore::PluginView::platformStart):

6:25 AM Changeset in webkit [48673] by xan@webkit.org

2 edits in trunk

2009-09-23 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Do not add unneeded include paths for gir files, and add the
include paths for headers manually instead of relying on our own
pc file and installed headers, since that adds a circular
dependency.

GNUmakefile.am:

6:08 AM Changeset in webkit [48672] by jmalonzo@webkit.org

4 edits
1 move in trunk

2009-09-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

Minor reorganization to the patch landed in
http://trac.webkit.org/changeset/48670. Also move JSCore-1.0.gir
in the gtk directory as that's only useful to the Gtk port at the
moment.

JSCore-1.0.gir: Renamed from JSCore-1.0.gir.

GNUmakefile.am:
configure.ac:

5:49 AM Changeset in webkit [48671] by kov@webkit.org

2 edits in trunk/WebCore

2009-09-23 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

[GTK] media tests failing after their rework
https://bugs.webkit.org/show_bug.cgi?id=29532

Correctly advertise the mime types used by the common formats used
in the tests.

Tests that regressed, and will pass again:

media/video-canvas-source.html
media/video-controls.html
media/video-currentTime-set2.html
media/video-dom-autoplay.html
media/video-dom-src.html
media/video-error-abort.html
media/video-load-networkState.html
media/video-load-readyState.html
media/video-muted.html
media/video-no-autoplay.html
media/video-pause-empty-events.html
media/video-play-empty-events.html
media/video-seekable.html
media/video-seeking.html
media/video-size.html
media/video-source-type-params.html
media/video-source-type.html
media/video-source.html
media/video-src-change.html
media/video-src-invalid-remove.html
media/video-src-remove.html
media/video-src-set.html
media/video-src-source.html
media/video-src.html
media/video-timeupdate-during-playback.html
media/video-volume.html

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):

5:03 AM Changeset in webkit [48670] by xan@webkit.org

3 edits
1 add in trunk

2009-09-23 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] We should generate our own gir file for introspection
https://bugs.webkit.org/show_bug.cgi?id=29603

Generate gir and typelib files for WebKit and JSCore. The JSCore
gir file is handwritten (since it's only useful, for now, as a
dependency of the WebKit gir file), the WebKit one is
autogenerated from the headers.

GNUmakefile.am:
JSCore-1.0.gir: Added.
configure.ac:

1:59 AM Changeset in webkit [48669] by zoltan@webkit.org

2 edits in trunk/LayoutTests

2009-09-23 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Tor Arne Vestbø.

[Qt] Skipping test added in r48644 due to missing layoutTestController features.

Sep 22, 2009:

11:39 PM Changeset in webkit [48668] by eric@webkit.org

5 edits
2 adds in trunk

2009-09-22 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by Eric Seidel.

Fix the crash problem with absolte positioned children in foreignobject
htts://bugs.webkit.org/show_bug.cgi?id=26342

svg/custom/foreignobject-crash-with-absolute-positioned-children-expected.txt: Added.
svg/custom/foreignobject-crash-with-absolute-positioned-children.svg: Added.

2009-09-22 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by Eric Seidel.

Fix the crash problem with absolte positioned children in foreignobject
htts://bugs.webkit.org/show_bug.cgi?id=26342

Test: svg/custom/foreignobject-crash-with-absolute-positioned-children.svg

rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::isSVGForeignObject):
rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock):
rendering/RenderObject.h: (WebCore::RenderObject::isSVGForeignObject):

9:53 PM Changeset in webkit [48667] by eric.carlson@apple.com

1 edit
6 adds in trunk/LayoutTests

2009-09-22 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Carlson.

Media test files in Ogg and Theora formats
https://bugs.webkit.org/show_bug.cgi?id=29623

Adding test files for media layout tests in Ogg and Theora. They are transcoded
from their originals in H264/AAC using ffmpeg2theora.

media/content/counting.ogv: Added.
media/content/empty.oga: Added.
media/content/garbage.ogv: Added.
media/content/silence.oga: Added.
media/content/test.oga: Added.
media/content/test.ogv: Added.

9:16 PM Changeset in webkit [48666] by atwilson@chromium.org

8 edits
3 adds in trunk

WebCore: SharedWorkers "name" attribute is now optional.
https://bugs.webkit.org/show_bug.cgi?id=28897

Reviewed by David Levin.

Test: fast/workers/shared-worker-name.html

bindings/js/JSSharedWorkerConstructor.cpp:

(WebCore::constructSharedWorker):
Default 'name' attribute to empty string if it is not provided.

bindings/v8/custom/V8SharedWorkerCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):
Default 'name' attribute to empty string if it is not provided.

workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::matches):
Now matches URLs if names are empty strings.
(WebCore::DefaultSharedWorkerRepository::getProxy):
Pass URL in to SharedWorkerProxy::matches().

LayoutTests: SharedWorkers "name" attribute is now optional
https://bugs.webkit.org/show_bug.cgi?id=28897

Reviewed by David Levin.

fast/workers/resources/worker-name.js:

New tests for optional name parameter.

fast/workers/resources/worker-util.js:

(done):
Now invokes done via a timer to ensure any pending console errors are written out.

fast/workers/shared-worker-constructor-expected.txt:
fast/workers/shared-worker-constructor.html:

Updated test/expectations now that constructor's "name" param is optional.

fast/workers/shared-worker-name-expected.txt:
fast/workers/shared-worker-name.html:

New tests for optional name parameter.

7:54 PM Changeset in webkit [48665] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-09-22 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, another build fix.

[Chromium] Add another missing include.
https://bugs.webkit.org/show_bug.cgi?id=29536

inspector/InspectorController.cpp: Added DOMWindow.h include.

6:50 PM Changeset in webkit [48664] by kevino@webkit.org

2 edits in trunk/WebKit/wx

Build fix to ensure the import library gets properly installed on Windows.

6:35 PM Changeset in webkit [48663] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-09-22 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Add missing include.
https://bugs.webkit.org/show_bug.cgi?id=29536

inspector/InspectorDOMStorageResource.cpp: Added DOMWindow.h include.

5:40 PM Changeset in webkit [48662] by oliver@apple.com

13 edits in trunk/JavaScriptCore

Code sampling builds are broken.
https://bugs.webkit.org/show_bug.cgi?id=29662

Reviewed by Geoff Garen

Fix build.

5:38 PM Changeset in webkit [48661] by Darin Adler

5 edits in trunk

Tighten up the ScheduledRedirection machinery to prepare for a bug fix
https://bugs.webkit.org/show_bug.cgi?id=29663

Patch by Darin Adler <Darin Adler> on 2009-09-22
Reviewed by Sam Weinig.

WebCore:

loader/FrameLoader.cpp:

(WebCore::ScheduledRedirection::ScheduledRedirection): Added a boolean,
initialized to false, to keep track if the redirection has been
communicated to the client.
(WebCore::FrameLoader::stopLoading): Tweaked a comment.
(WebCore::FrameLoader::cancelRedirection): Removed code to clear
m_scheduledRedirection.clear since stopRedirectionTimer does that now.
(WebCore::FrameLoader::allChildrenAreComplete): Added.
(WebCore::FrameLoader::checkCompleted): Use allChildrenAreComplete
function for clarity.
(WebCore::FrameLoader::checkCallImplicitClose): Ditto.
(WebCore::FrameLoader::scheduleRedirection): Changed to take a PassOwnPtr.
(WebCore::FrameLoader::startRedirectionTimer): Added code to set the
toldClient flag and not call clientRedirected a second time if it is set.
(WebCore::FrameLoader::stopRedirectionTimer): Changed so this can be safely
called multiple times and it will call clientRedirectCancelledOrFinished
only once.

loader/FrameLoader.h: Changed scheduleRedirection to be a PassOwnPtr.

Added allChildrenAreComplete function.

LayoutTests:

http/tests/loading/deleted-host-in-resource-load-delegate-callback-expected.txt:

Updated test to reflect progression. The willPerformClientRedirectToURL
call was called an extra time before.

5:16 PM Changeset in webkit [48660] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-09-22 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

js tests should move into jstests subdirectory instead of resources/
https://bugs.webkit.org/show_bug.cgi?id=25880

Remove support of resources directory.

Scripts/make-script-test-wrappers:

5:09 PM Changeset in webkit [48659] by eric@webkit.org

16 edits in trunk/WebCore

2009-09-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Migrate Databases tab to InjectedScript /
serialized interaction.

DOMStorage interaction is now serialized into JSON messages
and doesn't require quarantined objects.

https://bugs.webkit.org/show_bug.cgi?id=28873

dom/EventListener.h: (WebCore::EventListener::):
inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::selectDOMStorage): (WebCore::InspectorBackend::getDOMStorageEntries): (WebCore::InspectorBackend::setDOMStorageItem): (WebCore::InspectorBackend::removeDOMStorageItem):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::selectDOMStorage): (WebCore::InspectorController::getDOMStorageEntries): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::removeDOMStorageItem): (WebCore::InspectorController::getDOMStorageResourceForId):
inspector/InspectorController.h:
inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource): (WebCore::InspectorDOMStorageResource::bind): (WebCore::InspectorDOMStorageResource::unbind): (WebCore::InspectorDOMStorageResource::startReportingChangesToFrontend): (WebCore::InspectorDOMStorageResource::handleEvent): (WebCore::InspectorDOMStorageResource::operator==):
inspector/InspectorDOMStorageResource.h: (WebCore::InspectorDOMStorageResource::cast): (WebCore::InspectorDOMStorageResource::id): (WebCore::InspectorDOMStorageResource::domStorage):
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::selectDOMStorage): (WebCore::InspectorFrontend::didGetDOMStorageEntries): (WebCore::InspectorFrontend::didSetDOMStorageItem): (WebCore::InspectorFrontend::didRemoveDOMStorageItem): (WebCore::InspectorFrontend::updateDOMStorage):
inspector/InspectorFrontend.h:
inspector/front-end/DOMStorage.js: (WebInspector.DOMStorage): (WebInspector.DOMStorage.prototype.get id): (WebInspector.DOMStorage.prototype.get domStorage): (WebInspector.DOMStorage.prototype.get isLocalStorage): (WebInspector.DOMStorage.prototype.getEntriesAsync): (WebInspector.DOMStorage.prototype.setItemAsync): (WebInspector.DOMStorage.prototype.removeItemAsync):
inspector/front-end/DOMStorageDataGrid.js: (WebInspector.DOMStorageDataGrid): (WebInspector.DOMStorageDataGrid.prototype._startEditingColumnOfDataGridNode): (WebInspector.DOMStorageDataGrid.prototype._startEditing): (WebInspector.DOMStorageDataGrid.prototype._editingCommitted): (WebInspector.DOMStorageDataGrid.prototype._editingCancelled): (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype.update): (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries): (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.show): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.selectDOMStorage): (WebInspector.StoragePanel.prototype.updateDOMStorage): (WebInspector.StoragePanel.prototype._domStorageForId):
inspector/front-end/inspector.js: (WebInspector.addDOMStorage): (WebInspector.updateDOMStorage):

4:49 PM Changeset in webkit [48658] by weinig@apple.com

3 edits
2 adds in trunk

WebCore: Fix for XMLHttpRequest.abort() should destroy the response text.
https://bugs.webkit.org/show_bug.cgi?id=29658
<rdar://problem/5301430>

Reviewed by Alexey Proskuryakov.

Clearing the response text after calling XMLHttpRequest.abort() is necessary
per spec and matches Firefox. It is also a potential memory win.

Test: http/tests/xmlhttprequest/abort-should-destroy-responseText.html

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::abort): Clear the response text making sure to
keep the actual ResourceReponse around so that the response status and response
status text are kept around.

LayoutTests: Test for XMLHttpRequest.abort() should destroy the response text.
https://bugs.webkit.org/show_bug.cgi?id=29658
<rdar://problem/5301430>

Reviewed by Alexey Proskuryakov.

http/tests/xmlhttprequest/abort-should-destroy-responseText-expected.txt: Added.
http/tests/xmlhttprequest/abort-should-destroy-responseText.html: Added.

4:48 PM Changeset in webkit [48657] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-09-22 Dimitri Glazkov <Dimitri Glazkov>

No review, rolling out r48639.
http://trac.webkit.org/changeset/48639

bindings/v8/V8GCController.cpp: (WebCore::ObjectGrouperVisitor::visitDOMWrapper):

4:41 PM Changeset in webkit [48656] by hamaji@chromium.org

2 edits
2 moves
1 add in trunk/LayoutTests

2009-09-22 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

fast/backgrounds/repeat tests are different from their TEMPLATE
https://bugs.webkit.org/show_bug.cgi?id=29659

fast/backgrounds/repeat/parsing-background-repeat.html:
fast/backgrounds/repeat/resources/TEMPLATE.html: Removed.
fast/backgrounds/repeat/resources/parsing-background-repeat.js: Removed.
fast/backgrounds/repeat/script-tests: Added.
fast/backgrounds/repeat/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/backgrounds/repeat/resources/TEMPLATE.html.
fast/backgrounds/repeat/script-tests/parsing-background-repeat.js: Copied from LayoutTests/fast/backgrounds/repeat/resources/parsing-background-repeat.js.

3:39 PM Changeset in webkit [48655] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-09-22 Eric Seidel <eric@webkit.org>

No review, only fixing typo (missing space character).

Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220

Scripts/run-webkit-tests:

3:33 PM Changeset in webkit [48654] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-09-22 Eric Seidel <eric@webkit.org>

Reviewed by Simon Fraser.

media/controls-after-reload.html crashes occasionally
https://bugs.webkit.org/show_bug.cgi?id=29037

Skip media/controls-after-reload.html for the same CVDisplayLink
issue as seen with media/video-size-intrinsic-scale.html.

platform/mac-leopard/Skipped:

3:24 PM Changeset in webkit [48653] by eric@webkit.org

9 edits
4 adds in trunk

2009-09-22 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Adding two tests for the transaction coordinator.
Fixing an incorrect <head> tag in some tests.

https://bugs.webkit.org/show_bug.cgi?id=29115

storage/multiple-transactions-on-different-handles.html: Fixed a <head> tag (should've been </head>).
storage/open-database-while-transaction-in-progress.html: Fixed a <head> tag (should've been </head>).
storage/read-and-write-transactions-dont-run-together-expected.txt: Added.
storage/read-and-write-transactions-dont-run-together.html: Added.
storage/read-transactions-running-concurrently-expected.txt: Added.
storage/read-transactions-running-concurrently.html: Added.
storage/test-authorizer.html: Fixed a <head> tag (should've been </head>).

2009-09-22 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Changing the transaction coordinator to (re-)allow multiple read
transactions on the same database to run concurrently (without
risking a deadlock this time).

https://bugs.webkit.org/show_bug.cgi?id=29115

Tests: storage/read-and-write-transactions-dont-run-together.html

storage/read-transactions-running-concurrently.html

storage/SQLTransaction.h: (WebCore::SQLTransaction::isReadOnly): Returns the type of the transaction.
storage/SQLTransactionCoordinator.cpp: (WebCore::SQLTransactionCoordinator::acquireLock): Changed to allow multiple read transactions on the same DB to run concurrently. (WebCore::SQLTransactionCoordinator::releaseLock): Changed to allow multiple read transactions on the same DB to run concurrently. (WebCore::SQLTransactionCoordinator::shutdown): Renamed the map.
storage/SQLTransactionCoordinator.h:

3:05 PM Changeset in webkit [48652] by pkasting@chromium.org

3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=29652
Support true system colors for CSS system colors in Chromium/Win.

Reviewed by David Levin.

rendering/RenderThemeChromiumWin.cpp:

(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeChromiumWin::systemColor):

rendering/RenderThemeChromiumWin.h:

2:22 PM Changeset in webkit [48651] by hamaji@chromium.org

281 edits
283 moves
2 adds in trunk/LayoutTests

2009-09-22 Shinichiro Hamaji <hamaji@chromium.org>

Rubber-stamped by Eric Seidel.

js tests should move into jstests subdirectory instead of resources/
https://bugs.webkit.org/show_bug.cgi?id=25880

Migration for js directory.

fast/js/Array-isArray.html:
fast/js/JSON-parse-reviver.html:
fast/js/JSON-stringify-replacer.html:
fast/js/Object-create.html:
fast/js/Object-defineProperties.html:
fast/js/Object-defineProperty.html:
fast/js/Object-keys.html:
fast/js/activation-proto.html:
fast/js/arguments-bad-index.html:
fast/js/arguments.html:
fast/js/array-enumerators-functions.html:
fast/js/array-every.html:
fast/js/array-filter.html:
fast/js/array-float-delete.html:
fast/js/array-functions-non-arrays.html:
fast/js/array-holes.html:
fast/js/array-index-immediate-types.html:
fast/js/array-indexing.html:
fast/js/array-iterate-backwards.html:
fast/js/array-join-bug-11524.html:
fast/js/array-lastIndexOf.html:
fast/js/array-reduce.html:
fast/js/array-reduceRight.html:
fast/js/array-reset-large-index.html:
fast/js/array-sort-reentrance.html:
fast/js/array-splice.html:
fast/js/array-tostring-and-join.html:
fast/js/array-tostring-ignore-separator.html:
fast/js/assign.html:
fast/js/avl-crash.html:
fast/js/cached-eval-gc.html:
fast/js/caller-property.html:
fast/js/char-at.html:
fast/js/closure-inside-extra-arg-call.html:
fast/js/code-serialize-paren.html:
fast/js/codegen-loops-logical-nodes.html:
fast/js/codegen-peephole-locals.html:
fast/js/codegen-temporaries.html:
fast/js/comparefn-sort-stability.html:
fast/js/const-without-initializer.html:
fast/js/constant-count.html:
fast/js/constant-folding.html:
fast/js/constructor-attributes.html:
fast/js/constructor.html:
fast/js/continue-break-multiple-labels.html:
fast/js/convert-nan-to-bool.html:
fast/js/cyclic-proto.html:
fast/js/cyclic-prototypes.html:
fast/js/cyclic-ref-toString.html:
fast/js/date-DST-pre-1970.html:
fast/js/date-DST-time-cusps.html:
fast/js/date-big-constructor.html:
fast/js/date-big-setdate.html:
fast/js/date-big-setmonth.html:
fast/js/date-constructor.html:
fast/js/date-negative-setmonth.html:
fast/js/date-parse-comments-test.html:
fast/js/date-parse-test.html:
fast/js/date-preserve-milliseconds.html:
fast/js/date-proto-generic-invocation.html:
fast/js/date-set-to-nan.html:
fast/js/date-toisostring.html:
fast/js/debugger.html:
fast/js/declaration-in-block.html:
fast/js/delete-getters-setters.html:
fast/js/delete-syntax.html:
fast/js/delete-then-put.html:
fast/js/dictionary-no-cache.html:
fast/js/do-while-semicolon.html:
fast/js/dot-node-base-exception.html:
fast/js/duplicate-param-crash.html:
fast/js/duplicate-param-gc-crash.html:
fast/js/equality.html:
fast/js/eval-cache-crash.html:
fast/js/eval-throw-return.html:
fast/js/eval-var-decl.html:
fast/js/exception-expression-offset.html:
fast/js/exception-for-nonobject.html:
fast/js/exception-linenums.html:
fast/js/exception-try-finally-scope-error.html:
fast/js/exception-with-handler-inside-eval-with-dynamic-scope.html:
fast/js/excessive-comma-usage.html:
fast/js/finally-codegen-failure.html:
fast/js/for-in-avoid-duplicates.html:
fast/js/for-in-cached.html:
fast/js/for-in-exeception.html:
fast/js/for-in-to-text.html:
fast/js/for-in-var-scope.html:
fast/js/function-apply-aliased.html:
fast/js/function-apply.html:
fast/js/function-call-aliased.html:
fast/js/function-call-register-allocation.html:
fast/js/function-constructor-newline-after-brace.html:
fast/js/function-constructor-single-line-comment.html:
fast/js/function-declaration-statement.html:
fast/js/function-declaration.html:
fast/js/function-declarations-in-switch-statement.html:
fast/js/function-dot-arguments.html:
fast/js/function-name.html:
fast/js/function-names.html:
fast/js/function-toString-object-literals.html:
fast/js/function-toString-parentheses.html:
fast/js/function-toString-semicolon-insertion.html:
fast/js/getter-setter-gc.html:
fast/js/global-constructors.html:
fast/js/global-function-resolve.html:
fast/js/gmail-re-re.html:
fast/js/has-own-property.html:
fast/js/ignored-result-null-comparison-crash.html:
fast/js/ignored-result-ref-crash.html:
fast/js/implicit-call-with-global-reentry.html:
fast/js/instance-of-immediates.html:
fast/js/instanceof-operator.html:
fast/js/integer-extremes.html:
fast/js/isPrototypeOf.html:
fast/js/kde/Array.html:
fast/js/kde/Boolean.html:
fast/js/kde/Date-setYear.html:
fast/js/kde/Error.html:
fast/js/kde/GlobalObject.html:
fast/js/kde/Number.html:
fast/js/kde/Object.html:
fast/js/kde/Prototype.html:
fast/js/kde/RegExp.html:
fast/js/kde/StringObject.html:
fast/js/kde/arguments-scope.html:
fast/js/kde/assignments.html:
fast/js/kde/cast.html:
fast/js/kde/comment-1.html:
fast/js/kde/comment-2.html:
fast/js/kde/completion.html:
fast/js/kde/conditional.html:
fast/js/kde/constructor_length.html:
fast/js/kde/crash-1.html:
fast/js/kde/crash-2.html:
fast/js/kde/delete.html:
fast/js/kde/empty.html:
fast/js/kde/encode_decode_uri.html:
fast/js/kde/eval.html:
fast/js/kde/evil-n.html:
fast/js/kde/exception_propagation.html:
fast/js/kde/exceptions.html:
fast/js/kde/func-decl.html:
fast/js/kde/function.html:
fast/js/kde/function_arguments.html:
fast/js/kde/function_constructor.html:
fast/js/kde/function_length.html:
fast/js/kde/garbage-n.html:
fast/js/kde/inbuilt_function_proto.html:
fast/js/kde/inbuilt_function_tostring.html:
fast/js/kde/iteration.html:
fast/js/kde/j-comment-3.html:
fast/js/kde/j-comment-4.html:
fast/js/kde/literals.html:
fast/js/kde/lval-exceptions.html:
fast/js/kde/math.html:
fast/js/kde/md5-1.html:
fast/js/kde/md5-2.html:
fast/js/kde/object_prototype.html:
fast/js/kde/object_prototype_tostring.html:
fast/js/kde/operators.html:
fast/js/kde/parse.html:
fast/js/kde/prototype_length.html:
fast/js/kde/prototype_proto.html:
fast/js/kde/resources/Array.js: Removed.
fast/js/kde/resources/Boolean.js: Removed.
fast/js/kde/resources/Date-setYear.js: Removed.
fast/js/kde/resources/Error.js: Removed.
fast/js/kde/resources/GlobalObject.js: Removed.
fast/js/kde/resources/Number.js: Removed.
fast/js/kde/resources/Object.js: Removed.
fast/js/kde/resources/Prototype.js: Removed.
fast/js/kde/resources/RegExp.js: Removed.
fast/js/kde/resources/StringObject.js: Removed.
fast/js/kde/resources/TEMPLATE-n.html: Removed.
fast/js/kde/resources/TEMPLATE.html: Removed.
fast/js/kde/resources/arguments-scope.js: Removed.
fast/js/kde/resources/assignments.js: Removed.
fast/js/kde/resources/cast.js: Removed.
fast/js/kde/resources/comment-1.js: Removed.
fast/js/kde/resources/comment-2.js: Removed.
fast/js/kde/resources/completion.js: Removed.
fast/js/kde/resources/conditional.js: Removed.
fast/js/kde/resources/constructor_length.js: Removed.
fast/js/kde/resources/crash-1.js: Removed.
fast/js/kde/resources/crash-2.js: Removed.
fast/js/kde/resources/delete.js: Removed.
fast/js/kde/resources/empty.js: Removed.
fast/js/kde/resources/encode_decode_uri.js: Removed.
fast/js/kde/resources/eval.js: Removed.
fast/js/kde/resources/evil-n.js: Removed.
fast/js/kde/resources/exception_propagation.js: Removed.
fast/js/kde/resources/exceptions.js: Removed.
fast/js/kde/resources/func-decl.js: Removed.
fast/js/kde/resources/function.js: Removed.
fast/js/kde/resources/function_arguments.js: Removed.
fast/js/kde/resources/function_constructor.js: Removed.
fast/js/kde/resources/function_length.js: Removed.
fast/js/kde/resources/garbage-n.js: Removed.
fast/js/kde/resources/inbuilt_function_proto.js: Removed.
fast/js/kde/resources/inbuilt_function_tostring.js: Removed.
fast/js/kde/resources/iteration.js: Removed.
fast/js/kde/resources/j-comment-3.js: Removed.
fast/js/kde/resources/j-comment-4.js: Removed.
fast/js/kde/resources/literals.js: Removed.
fast/js/kde/resources/lval-exceptions.js: Removed.
fast/js/kde/resources/math.js: Removed.
fast/js/kde/resources/md5-1.js: Removed.
fast/js/kde/resources/md5-2.js: Removed.
fast/js/kde/resources/object_prototype.js: Removed.
fast/js/kde/resources/object_prototype_tostring.js: Removed.
fast/js/kde/resources/operators.js: Removed.
fast/js/kde/resources/parse.js: Removed.
fast/js/kde/resources/prototype_length.js: Removed.
fast/js/kde/resources/prototype_proto.js: Removed.
fast/js/kde/resources/scope.js: Removed.
fast/js/kde/resources/statements.js: Removed.
fast/js/kde/resources/string-1-n.js: Removed.
fast/js/kde/resources/string-2-n.js: Removed.
fast/js/kde/resources/var_decl_init.js: Removed.
fast/js/kde/scope.html:
fast/js/kde/script-tests: Added.
fast/js/kde/script-tests/Array.js: Copied from LayoutTests/fast/js/kde/resources/Array.js.
fast/js/kde/script-tests/Boolean.js: Copied from LayoutTests/fast/js/kde/resources/Boolean.js.
fast/js/kde/script-tests/Date-setYear.js: Copied from LayoutTests/fast/js/kde/resources/Date-setYear.js.
fast/js/kde/script-tests/Error.js: Copied from LayoutTests/fast/js/kde/resources/Error.js.
fast/js/kde/script-tests/GlobalObject.js: Copied from LayoutTests/fast/js/kde/resources/GlobalObject.js.
fast/js/kde/script-tests/Number.js: Copied from LayoutTests/fast/js/kde/resources/Number.js.
fast/js/kde/script-tests/Object.js: Copied from LayoutTests/fast/js/kde/resources/Object.js.
fast/js/kde/script-tests/Prototype.js: Copied from LayoutTests/fast/js/kde/resources/Prototype.js.
fast/js/kde/script-tests/RegExp.js: Copied from LayoutTests/fast/js/kde/resources/RegExp.js.
fast/js/kde/script-tests/StringObject.js: Copied from LayoutTests/fast/js/kde/resources/StringObject.js.
fast/js/kde/script-tests/TEMPLATE-n.html: Copied from LayoutTests/fast/js/kde/resources/TEMPLATE-n.html.
fast/js/kde/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/js/kde/resources/TEMPLATE.html.
fast/js/kde/script-tests/arguments-scope.js: Copied from LayoutTests/fast/js/kde/resources/arguments-scope.js.
fast/js/kde/script-tests/assignments.js: Copied from LayoutTests/fast/js/kde/resources/assignments.js.
fast/js/kde/script-tests/cast.js: Copied from LayoutTests/fast/js/kde/resources/cast.js.
fast/js/kde/script-tests/comment-1.js: Copied from LayoutTests/fast/js/kde/resources/comment-1.js.
fast/js/kde/script-tests/comment-2.js: Copied from LayoutTests/fast/js/kde/resources/comment-2.js.
fast/js/kde/script-tests/completion.js: Copied from LayoutTests/fast/js/kde/resources/completion.js.
fast/js/kde/script-tests/conditional.js: Copied from LayoutTests/fast/js/kde/resources/conditional.js.
fast/js/kde/script-tests/constructor_length.js: Copied from LayoutTests/fast/js/kde/resources/constructor_length.js.
fast/js/kde/script-tests/crash-1.js: Copied from LayoutTests/fast/js/kde/resources/crash-1.js.
fast/js/kde/script-tests/crash-2.js: Copied from LayoutTests/fast/js/kde/resources/crash-2.js.
fast/js/kde/script-tests/delete.js: Copied from LayoutTests/fast/js/kde/resources/delete.js.
fast/js/kde/script-tests/empty.js: Copied from LayoutTests/fast/js/kde/resources/empty.js.
fast/js/kde/script-tests/encode_decode_uri.js: Copied from LayoutTests/fast/js/kde/resources/encode_decode_uri.js.
fast/js/kde/script-tests/eval.js: Copied from LayoutTests/fast/js/kde/resources/eval.js.
fast/js/kde/script-tests/evil-n.js: Copied from LayoutTests/fast/js/kde/resources/evil-n.js.
fast/js/kde/script-tests/exception_propagation.js: Copied from LayoutTests/fast/js/kde/resources/exception_propagation.js.
fast/js/kde/script-tests/exceptions.js: Copied from LayoutTests/fast/js/kde/resources/exceptions.js.
fast/js/kde/script-tests/func-decl.js: Copied from LayoutTests/fast/js/kde/resources/func-decl.js.
fast/js/kde/script-tests/function.js: Copied from LayoutTests/fast/js/kde/resources/function.js.
fast/js/kde/script-tests/function_arguments.js: Copied from LayoutTests/fast/js/kde/resources/function_arguments.js.
fast/js/kde/script-tests/function_constructor.js: Copied from LayoutTests/fast/js/kde/resources/function_constructor.js.
fast/js/kde/script-tests/function_length.js: Copied from LayoutTests/fast/js/kde/resources/function_length.js.
fast/js/kde/script-tests/garbage-n.js: Copied from LayoutTests/fast/js/kde/resources/garbage-n.js.
fast/js/kde/script-tests/inbuilt_function_proto.js: Copied from LayoutTests/fast/js/kde/resources/inbuilt_function_proto.js.
fast/js/kde/script-tests/inbuilt_function_tostring.js: Copied from LayoutTests/fast/js/kde/resources/inbuilt_function_tostring.js.
fast/js/kde/script-tests/iteration.js: Copied from LayoutTests/fast/js/kde/resources/iteration.js.
fast/js/kde/script-tests/j-comment-3.js: Copied from LayoutTests/fast/js/kde/resources/j-comment-3.js.
fast/js/kde/script-tests/j-comment-4.js: Copied from LayoutTests/fast/js/kde/resources/j-comment-4.js.
fast/js/kde/script-tests/literals.js: Copied from LayoutTests/fast/js/kde/resources/literals.js.
fast/js/kde/script-tests/lval-exceptions.js: Copied from LayoutTests/fast/js/kde/resources/lval-exceptions.js.
fast/js/kde/script-tests/math.js: Copied from LayoutTests/fast/js/kde/resources/math.js.
fast/js/kde/script-tests/md5-1.js: Copied from LayoutTests/fast/js/kde/resources/md5-1.js.
fast/js/kde/script-tests/md5-2.js: Copied from LayoutTests/fast/js/kde/resources/md5-2.js.
fast/js/kde/script-tests/object_prototype.js: Copied from LayoutTests/fast/js/kde/resources/object_prototype.js.
fast/js/kde/script-tests/object_prototype_tostring.js: Copied from LayoutTests/fast/js/kde/resources/object_prototype_tostring.js.
fast/js/kde/script-tests/operators.js: Copied from LayoutTests/fast/js/kde/resources/operators.js.
fast/js/kde/script-tests/parse.js: Copied from LayoutTests/fast/js/kde/resources/parse.js.
fast/js/kde/script-tests/prototype_length.js: Copied from LayoutTests/fast/js/kde/resources/prototype_length.js.
fast/js/kde/script-tests/prototype_proto.js: Copied from LayoutTests/fast/js/kde/resources/prototype_proto.js.
fast/js/kde/script-tests/scope.js: Copied from LayoutTests/fast/js/kde/resources/scope.js.
fast/js/kde/script-tests/statements.js: Copied from LayoutTests/fast/js/kde/resources/statements.js.
fast/js/kde/script-tests/string-1-n.js: Copied from LayoutTests/fast/js/kde/resources/string-1-n.js.
fast/js/kde/script-tests/string-2-n.js: Copied from LayoutTests/fast/js/kde/resources/string-2-n.js.
fast/js/kde/script-tests/var_decl_init.js: Copied from LayoutTests/fast/js/kde/resources/var_decl_init.js.
fast/js/kde/statements.html:
fast/js/kde/string-1-n.html:
fast/js/kde/string-2-n.html:
fast/js/kde/var_decl_init.html:
fast/js/large-expressions.html:
fast/js/lastModified.html:
fast/js/logical-or-jless.html:
fast/js/math-transforms.html:
fast/js/math.html:
fast/js/method-check.html:
fast/js/mod-crash.html:
fast/js/modify-non-references.html:
fast/js/named-function-expression.html:
fast/js/navigator-mimeTypes-length.html:
fast/js/nested-object-gc.html:
fast/js/non-object-proto.html:
fast/js/null-char-in-string.html:
fast/js/number-cell-reuse.html:
fast/js/number-parsing-crash.html:
fast/js/number-toExponential.html:
fast/js/number-toString.html:
fast/js/number-tofixed.html:
fast/js/number-toprecision.html:
fast/js/numeric-conversion.html:
fast/js/object-extra-comma.html:
fast/js/object-prototype-constructor.html:
fast/js/object-prototype-toLocaleString.html:
fast/js/order-of-operations.html:
fast/js/parse-backslash-before-newline.html:
fast/js/postfix-syntax.html:
fast/js/prefix-syntax.html:
fast/js/pretty-print.html:
fast/js/primitive-method-this.html:
fast/js/primitive-property-access-edge-cases.html:
fast/js/property-getters-and-setters.html:
fast/js/propertyIsEnumerable.html:
fast/js/prototypes.html:
fast/js/read-modify-eval.html:
fast/js/recursion-limit-equal.html:
fast/js/reentrant-call-unwind.html:
fast/js/regexp-backreferences.html:
fast/js/regexp-char-insensitive.html:
fast/js/regexp-character-match-out-of-order.html:
fast/js/regexp-compile-crash.html:
fast/js/regexp-compile.html:
fast/js/regexp-divequal.html:
fast/js/regexp-extended-characters-crash.html:
fast/js/regexp-extended-characters-match.html:
fast/js/regexp-extended-characters-more.html:
fast/js/regexp-find-first-asserted.html:
fast/js/regexp-lastindex.html:
fast/js/regexp-many-brackets.html:
fast/js/regexp-negative-special-characters.html:
fast/js/regexp-no-extensions.html:
fast/js/regexp-non-bmp.html:
fast/js/regexp-non-capturing-groups.html:
fast/js/regexp-non-character.html:
fast/js/regexp-overflow-too-big.html:
fast/js/regexp-overflow.html:
fast/js/regexp-range-bound-ffff.html:
fast/js/regexp-range-out-of-order.html:
fast/js/regexp-ranges-and-escaped-hyphens.html:
fast/js/regexp-stack-overflow.html:
fast/js/regexp-unicode-handling.html:
fast/js/regexp-unicode-overflow.html:
fast/js/registerCachingAcrossBranchTargets.html:
fast/js/rehash-assign.html:
fast/js/removing-Cf-characters.html:
fast/js/reparsing-semicolon-insertion.html:
fast/js/repeat-cached-vm-reentry.html:
fast/js/reserved-words.html:
fast/js/resize-array-assign.html:
fast/js/resources/Array-isArray.js: Removed.
fast/js/resources/JSON-parse-reviver.js: Removed.
fast/js/resources/JSON-stringify-replacer.js: Removed.
fast/js/resources/Object-create.js: Removed.
fast/js/resources/Object-defineProperties.js: Removed.
fast/js/resources/Object-defineProperty.js: Removed.
fast/js/resources/Object-keys.js: Removed.
fast/js/resources/TEMPLATE.html: Removed.
fast/js/resources/activation-proto.js: Removed.
fast/js/resources/arguments-bad-index.js: Removed.
fast/js/resources/arguments.js: Removed.
fast/js/resources/array-enumerators-functions.js: Removed.
fast/js/resources/array-every.js: Removed.
fast/js/resources/array-filter.js: Removed.
fast/js/resources/array-float-delete.js: Removed.
fast/js/resources/array-functions-non-arrays.js: Removed.
fast/js/resources/array-holes.js: Removed.
fast/js/resources/array-index-immediate-types.js: Removed.
fast/js/resources/array-indexing.js: Removed.
fast/js/resources/array-iterate-backwards.js: Removed.
fast/js/resources/array-join-bug-11524.js: Removed.
fast/js/resources/array-lastIndexOf.js: Removed.
fast/js/resources/array-reduce.js: Removed.
fast/js/resources/array-reduceRight.js: Removed.
fast/js/resources/array-reset-large-index.js: Removed.
fast/js/resources/array-sort-reentrance.js: Removed.
fast/js/resources/array-splice.js: Removed.
fast/js/resources/array-tostring-and-join.js: Removed.
fast/js/resources/array-tostring-ignore-separator.js: Removed.
fast/js/resources/assign.js: Removed.
fast/js/resources/avl-crash.js: Removed.
fast/js/resources/cached-eval-gc.js: Removed.
fast/js/resources/caller-property.js: Removed.
fast/js/resources/char-at.js: Removed.
fast/js/resources/closure-inside-extra-arg-call.js: Removed.
fast/js/resources/code-serialize-paren.js: Removed.
fast/js/resources/codegen-loops-logical-nodes.js: Removed.
fast/js/resources/codegen-peephole-locals.js: Removed.
fast/js/resources/codegen-temporaries.js: Removed.
fast/js/resources/comparefn-sort-stability.js: Removed.
fast/js/resources/const-without-initializer.js: Removed.
fast/js/resources/constant-count.js: Removed.
fast/js/resources/constant-folding.js: Removed.
fast/js/resources/constructor-attributes.js: Removed.
fast/js/resources/constructor.js: Removed.
fast/js/resources/continue-break-multiple-labels.js: Removed.
fast/js/resources/convert-nan-to-bool.js: Removed.
fast/js/resources/cyclic-proto.js: Removed.
fast/js/resources/cyclic-prototypes.js: Removed.
fast/js/resources/cyclic-ref-toString.js: Removed.
fast/js/resources/date-DST-pre-1970.js: Removed.
fast/js/resources/date-DST-time-cusps.js: Removed.
fast/js/resources/date-big-constructor.js: Removed.
fast/js/resources/date-big-setdate.js: Removed.
fast/js/resources/date-big-setmonth.js: Removed.
fast/js/resources/date-constructor.js: Removed.
fast/js/resources/date-negative-setmonth.js: Removed.
fast/js/resources/date-parse-comments-test.js: Removed.
fast/js/resources/date-parse-test.js: Removed.
fast/js/resources/date-preserve-milliseconds.js: Removed.
fast/js/resources/date-proto-generic-invocation.js: Removed.
fast/js/resources/date-set-to-nan.js: Removed.
fast/js/resources/date-toisostring.js: Removed.
fast/js/resources/debugger.js: Removed.
fast/js/resources/declaration-in-block.js: Removed.
fast/js/resources/delete-getters-setters.js: Removed.
fast/js/resources/delete-syntax.js: Removed.
fast/js/resources/delete-then-put.js: Removed.
fast/js/resources/dictionary-no-cache.js: Removed.
fast/js/resources/do-while-semicolon.js: Removed.
fast/js/resources/dot-node-base-exception.js: Removed.
fast/js/resources/duplicate-param-crash.js: Removed.
fast/js/resources/duplicate-param-gc-crash.js: Removed.
fast/js/resources/equality.js: Removed.
fast/js/resources/eval-cache-crash.js: Removed.
fast/js/resources/eval-throw-return.js: Removed.
fast/js/resources/eval-var-decl.js: Removed.
fast/js/resources/exception-expression-offset.js: Removed.
fast/js/resources/exception-for-nonobject.js: Removed.
fast/js/resources/exception-linenums.js: Removed.
fast/js/resources/exception-try-finally-scope-error.js: Removed.
fast/js/resources/exception-with-handler-inside-eval-with-dynamic-scope.js: Removed.
fast/js/resources/excessive-comma-usage.js: Removed.
fast/js/resources/finally-codegen-failure.js: Removed.
fast/js/resources/for-in-avoid-duplicates.js: Removed.
fast/js/resources/for-in-cached.js: Removed.
fast/js/resources/for-in-exeception.js: Removed.
fast/js/resources/for-in-to-text.js: Removed.
fast/js/resources/for-in-var-scope.js: Removed.
fast/js/resources/function-apply-aliased.js: Removed.
fast/js/resources/function-apply.js: Removed.
fast/js/resources/function-call-aliased.js: Removed.
fast/js/resources/function-call-register-allocation.js: Removed.
fast/js/resources/function-constructor-newline-after-brace.js: Removed.
fast/js/resources/function-constructor-single-line-comment.js: Removed.
fast/js/resources/function-declaration-statement.js: Removed.
fast/js/resources/function-declaration.js: Removed.
fast/js/resources/function-declarations-in-switch-statement.js: Removed.
fast/js/resources/function-dot-arguments.js: Removed.
fast/js/resources/function-name.js: Removed.
fast/js/resources/function-names.js: Removed.
fast/js/resources/function-toString-object-literals.js: Removed.
fast/js/resources/function-toString-parentheses.js: Removed.
fast/js/resources/function-toString-semicolon-insertion.js: Removed.
fast/js/resources/getter-setter-gc.js: Removed.
fast/js/resources/global-constructors.js: Removed.
fast/js/resources/global-function-resolve.js: Removed.
fast/js/resources/gmail-re-re.js: Removed.
fast/js/resources/has-own-property.js: Removed.
fast/js/resources/ignored-result-null-comparison-crash.js: Removed.
fast/js/resources/ignored-result-ref-crash.js: Removed.
fast/js/resources/implicit-call-with-global-reentry.js: Removed.
fast/js/resources/instance-of-immediates.js: Removed.
fast/js/resources/instanceof-operator.js: Removed.
fast/js/resources/integer-extremes.js: Removed.
fast/js/resources/isPrototypeOf.js: Removed.
fast/js/resources/large-expressions.js: Removed.
fast/js/resources/lastModified.js: Removed.
fast/js/resources/logical-or-jless.js: Removed.
fast/js/resources/math-transforms.js: Removed.
fast/js/resources/math.js: Removed.
fast/js/resources/method-check.js: Removed.
fast/js/resources/mod-crash.js: Removed.
fast/js/resources/modify-non-references.js: Removed.
fast/js/resources/named-function-expression.js: Removed.
fast/js/resources/navigator-mimeTypes-length.js: Removed.
fast/js/resources/nested-object-gc.js: Removed.
fast/js/resources/non-object-proto.js: Removed.
fast/js/resources/null-char-in-string.js: Removed.
fast/js/resources/number-cell-reuse.js: Removed.
fast/js/resources/number-parsing-crash.js: Removed.
fast/js/resources/number-toExponential.js: Removed.
fast/js/resources/number-toString.js: Removed.
fast/js/resources/number-tofixed.js: Removed.
fast/js/resources/number-toprecision.js: Removed.
fast/js/resources/numeric-conversion.js: Removed.
fast/js/resources/object-extra-comma.js: Removed.
fast/js/resources/object-prototype-constructor.js: Removed.
fast/js/resources/object-prototype-toLocaleString.js: Removed.
fast/js/resources/order-of-operations.js: Removed.
fast/js/resources/parse-backslash-before-newline.js: Removed.
fast/js/resources/postfix-syntax.js: Removed.
fast/js/resources/prefix-syntax.js: Removed.
fast/js/resources/pretty-print.js: Removed.
fast/js/resources/primitive-method-this.js: Removed.
fast/js/resources/primitive-property-access-edge-cases.js: Removed.
fast/js/resources/property-getters-and-setters.js: Removed.
fast/js/resources/propertyIsEnumerable.js: Removed.
fast/js/resources/prototypes.js: Removed.
fast/js/resources/read-modify-eval.js: Removed.
fast/js/resources/recursion-limit-equal.js: Removed.
fast/js/resources/reentrant-call-unwind.js: Removed.
fast/js/resources/regexp-backreferences.js: Removed.
fast/js/resources/regexp-char-insensitive.js: Removed.
fast/js/resources/regexp-character-match-out-of-order.js: Removed.
fast/js/resources/regexp-compile-crash.js: Removed.
fast/js/resources/regexp-compile.js: Removed.
fast/js/resources/regexp-divequal.js: Removed.
fast/js/resources/regexp-extended-characters-crash.js: Removed.
fast/js/resources/regexp-extended-characters-match.js: Removed.
fast/js/resources/regexp-extended-characters-more.js: Removed.
fast/js/resources/regexp-find-first-asserted.js: Removed.
fast/js/resources/regexp-lastindex.js: Removed.
fast/js/resources/regexp-many-brackets.js: Removed.
fast/js/resources/regexp-negative-special-characters.js: Removed.
fast/js/resources/regexp-no-extensions.js: Removed.
fast/js/resources/regexp-non-bmp.js: Removed.
fast/js/resources/regexp-non-capturing-groups.js: Removed.
fast/js/resources/regexp-non-character.js: Removed.
fast/js/resources/regexp-overflow-too-big.js: Removed.
fast/js/resources/regexp-overflow.js: Removed.
fast/js/resources/regexp-range-bound-ffff.js: Removed.
fast/js/resources/regexp-range-out-of-order.js: Removed.
fast/js/resources/regexp-ranges-and-escaped-hyphens.js: Removed.
fast/js/resources/regexp-stack-overflow.js: Removed.
fast/js/resources/regexp-unicode-handling.js: Removed.
fast/js/resources/regexp-unicode-overflow.js: Removed.
fast/js/resources/registerCachingAcrossBranchTargets.js: Removed.
fast/js/resources/rehash-assign.js: Removed.
fast/js/resources/removing-Cf-characters.js: Removed.
fast/js/resources/reparsing-semicolon-insertion.js: Removed.
fast/js/resources/repeat-cached-vm-reentry.js: Removed.
fast/js/resources/reserved-words.js: Removed.
fast/js/resources/resize-array-assign.js: Removed.
fast/js/resources/select-options-add.js: Removed.
fast/js/resources/slash-lineterminator-parse.js: Removed.
fast/js/resources/sort-large-array.js: Removed.
fast/js/resources/sort-no-jit-code-crash.js: Removed.
fast/js/resources/sort-non-numbers.js: Removed.
fast/js/resources/sort-randomly.js: Removed.
fast/js/resources/sort-stability.js: Removed.
fast/js/resources/sparse-array.js: Removed.
fast/js/resources/stack-unwinding.js: Removed.
fast/js/resources/statement-list-register-crash.js: Removed.
fast/js/resources/static-scope-object.js: Removed.
fast/js/resources/string-capitalization.js: Removed.
fast/js/resources/string-from-char-code.js: Removed.
fast/js/resources/string-index-overflow.js: Removed.
fast/js/resources/string-property-iteration.js: Removed.
fast/js/resources/string-replace-2.js: Removed.
fast/js/resources/string-replace-3.js: Removed.
fast/js/resources/string-slice-abnormal-values.js: Removed.
fast/js/resources/string-sort.js: Removed.
fast/js/resources/string-split-ignore-case.js: Removed.
fast/js/resources/string-substr.js: Removed.
fast/js/resources/string_replace.js: Removed.
fast/js/resources/switch-behaviour.js: Removed.
fast/js/resources/this-non-object-proto.js: Removed.
fast/js/resources/toString-elision-trailing-comma.js: Removed.
fast/js/resources/toString-exception.js: Removed.
fast/js/resources/toString-for-var-decl.js: Removed.
fast/js/resources/toString-number-dot-expr.js: Removed.
fast/js/resources/toString-overrides.js: Removed.
fast/js/resources/toString-prefix-postfix-preserve-parens.js: Removed.
fast/js/resources/toString-stack-overflow.js: Removed.
fast/js/resources/tostring-exception-in-property-access.js: Removed.
fast/js/resources/transition-cache-dictionary-crash.js: Removed.
fast/js/resources/typeof-codegen-crash.js: Removed.
fast/js/resources/typeof-constant-string.js: Removed.
fast/js/resources/typeof-syntax.js: Removed.
fast/js/resources/unexpected-constant-crash.js: Removed.
fast/js/resources/unmatching-argument-count.js: Removed.
fast/js/resources/var-shadows-arg-crash.js: Removed.
fast/js/resources/var-shadows-arg-gc-crash.js: Removed.
fast/js/resources/vardecl-blocks-init.js: Removed.
fast/js/resources/vardecl-preserve-arguments.js: Removed.
fast/js/resources/with-scope-gc.js: Removed.
fast/js/script-tests: Added.
fast/js/script-tests/Array-isArray.js: Copied from LayoutTests/fast/js/resources/Array-isArray.js.
fast/js/script-tests/JSON-parse-reviver.js: Copied from LayoutTests/fast/js/resources/JSON-parse-reviver.js.
fast/js/script-tests/JSON-stringify-replacer.js: Copied from LayoutTests/fast/js/resources/JSON-stringify-replacer.js.
fast/js/script-tests/Object-create.js: Copied from LayoutTests/fast/js/resources/Object-create.js.
fast/js/script-tests/Object-defineProperties.js: Copied from LayoutTests/fast/js/resources/Object-defineProperties.js.
fast/js/script-tests/Object-defineProperty.js: Copied from LayoutTests/fast/js/resources/Object-defineProperty.js.
fast/js/script-tests/Object-keys.js: Copied from LayoutTests/fast/js/resources/Object-keys.js.
fast/js/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/js/resources/TEMPLATE.html.
fast/js/script-tests/activation-proto.js: Copied from LayoutTests/fast/js/resources/activation-proto.js.
fast/js/script-tests/arguments-bad-index.js: Copied from LayoutTests/fast/js/resources/arguments-bad-index.js.
fast/js/script-tests/arguments.js: Copied from LayoutTests/fast/js/resources/arguments.js.
fast/js/script-tests/array-enumerators-functions.js: Copied from LayoutTests/fast/js/resources/array-enumerators-functions.js.
fast/js/script-tests/array-every.js: Copied from LayoutTests/fast/js/resources/array-every.js.
fast/js/script-tests/array-filter.js: Copied from LayoutTests/fast/js/resources/array-filter.js.
fast/js/script-tests/array-float-delete.js: Copied from LayoutTests/fast/js/resources/array-float-delete.js.
fast/js/script-tests/array-functions-non-arrays.js: Copied from LayoutTests/fast/js/resources/array-functions-non-arrays.js.
fast/js/script-tests/array-holes.js: Copied from LayoutTests/fast/js/resources/array-holes.js.
fast/js/script-tests/array-index-immediate-types.js: Copied from LayoutTests/fast/js/resources/array-index-immediate-types.js.
fast/js/script-tests/array-indexing.js: Copied from LayoutTests/fast/js/resources/array-indexing.js.
fast/js/script-tests/array-iterate-backwards.js: Copied from LayoutTests/fast/js/resources/array-iterate-backwards.js.
fast/js/script-tests/array-join-bug-11524.js: Copied from LayoutTests/fast/js/resources/array-join-bug-11524.js.
fast/js/script-tests/array-lastIndexOf.js: Copied from LayoutTests/fast/js/resources/array-lastIndexOf.js.
fast/js/script-tests/array-reduce.js: Copied from LayoutTests/fast/js/resources/array-reduce.js.
fast/js/script-tests/array-reduceRight.js: Copied from LayoutTests/fast/js/resources/array-reduceRight.js.
fast/js/script-tests/array-reset-large-index.js: Copied from LayoutTests/fast/js/resources/array-reset-large-index.js.
fast/js/script-tests/array-sort-reentrance.js: Copied from LayoutTests/fast/js/resources/array-sort-reentrance.js.
fast/js/script-tests/array-splice.js: Copied from LayoutTests/fast/js/resources/array-splice.js.
fast/js/script-tests/array-tostring-and-join.js: Copied from LayoutTests/fast/js/resources/array-tostring-and-join.js.
fast/js/script-tests/array-tostring-ignore-separator.js: Copied from LayoutTests/fast/js/resources/array-tostring-ignore-separator.js.
fast/js/script-tests/assign.js: Copied from LayoutTests/fast/js/resources/assign.js.
fast/js/script-tests/avl-crash.js: Copied from LayoutTests/fast/js/resources/avl-crash.js.
fast/js/script-tests/cached-eval-gc.js: Copied from LayoutTests/fast/js/resources/cached-eval-gc.js.
fast/js/script-tests/caller-property.js: Copied from LayoutTests/fast/js/resources/caller-property.js.
fast/js/script-tests/char-at.js: Copied from LayoutTests/fast/js/resources/char-at.js.
fast/js/script-tests/closure-inside-extra-arg-call.js: Copied from LayoutTests/fast/js/resources/closure-inside-extra-arg-call.js.
fast/js/script-tests/code-serialize-paren.js: Copied from LayoutTests/fast/js/resources/code-serialize-paren.js.
fast/js/script-tests/codegen-loops-logical-nodes.js: Copied from LayoutTests/fast/js/resources/codegen-loops-logical-nodes.js.
fast/js/script-tests/codegen-peephole-locals.js: Copied from LayoutTests/fast/js/resources/codegen-peephole-locals.js.
fast/js/script-tests/codegen-temporaries.js: Copied from LayoutTests/fast/js/resources/codegen-temporaries.js.
fast/js/script-tests/comparefn-sort-stability.js: Copied from LayoutTests/fast/js/resources/comparefn-sort-stability.js.
fast/js/script-tests/const-without-initializer.js: Copied from LayoutTests/fast/js/resources/const-without-initializer.js.
fast/js/script-tests/constant-count.js: Copied from LayoutTests/fast/js/resources/constant-count.js.
fast/js/script-tests/constant-folding.js: Copied from LayoutTests/fast/js/resources/constant-folding.js.
fast/js/script-tests/constructor-attributes.js: Copied from LayoutTests/fast/js/resources/constructor-attributes.js.
fast/js/script-tests/constructor.js: Copied from LayoutTests/fast/js/resources/constructor.js.
fast/js/script-tests/continue-break-multiple-labels.js: Copied from LayoutTests/fast/js/resources/continue-break-multiple-labels.js.
fast/js/script-tests/convert-nan-to-bool.js: Copied from LayoutTests/fast/js/resources/convert-nan-to-bool.js.
fast/js/script-tests/cyclic-proto.js: Copied from LayoutTests/fast/js/resources/cyclic-proto.js.
fast/js/script-tests/cyclic-prototypes.js: Copied from LayoutTests/fast/js/resources/cyclic-prototypes.js.
fast/js/script-tests/cyclic-ref-toString.js: Copied from LayoutTests/fast/js/resources/cyclic-ref-toString.js.
fast/js/script-tests/date-DST-pre-1970.js: Copied from LayoutTests/fast/js/resources/date-DST-pre-1970.js.
fast/js/script-tests/date-DST-time-cusps.js: Copied from LayoutTests/fast/js/resources/date-DST-time-cusps.js.
fast/js/script-tests/date-big-constructor.js: Copied from LayoutTests/fast/js/resources/date-big-constructor.js.
fast/js/script-tests/date-big-setdate.js: Copied from LayoutTests/fast/js/resources/date-big-setdate.js.
fast/js/script-tests/date-big-setmonth.js: Copied from LayoutTests/fast/js/resources/date-big-setmonth.js.
fast/js/script-tests/date-constructor.js: Copied from LayoutTests/fast/js/resources/date-constructor.js.
fast/js/script-tests/date-negative-setmonth.js: Copied from LayoutTests/fast/js/resources/date-negative-setmonth.js.
fast/js/script-tests/date-parse-comments-test.js: Copied from LayoutTests/fast/js/resources/date-parse-comments-test.js.
fast/js/script-tests/date-parse-test.js: Copied from LayoutTests/fast/js/resources/date-parse-test.js.
fast/js/script-tests/date-preserve-milliseconds.js: Copied from LayoutTests/fast/js/resources/date-preserve-milliseconds.js.
fast/js/script-tests/date-proto-generic-invocation.js: Copied from LayoutTests/fast/js/resources/date-proto-generic-invocation.js.
fast/js/script-tests/date-set-to-nan.js: Copied from LayoutTests/fast/js/resources/date-set-to-nan.js.
fast/js/script-tests/date-toisostring.js: Copied from LayoutTests/fast/js/resources/date-toisostring.js.
fast/js/script-tests/debugger.js: Copied from LayoutTests/fast/js/resources/debugger.js.
fast/js/script-tests/declaration-in-block.js: Copied from LayoutTests/fast/js/resources/declaration-in-block.js.
fast/js/script-tests/delete-getters-setters.js: Copied from LayoutTests/fast/js/resources/delete-getters-setters.js.
fast/js/script-tests/delete-syntax.js: Copied from LayoutTests/fast/js/resources/delete-syntax.js.
fast/js/script-tests/delete-then-put.js: Copied from LayoutTests/fast/js/resources/delete-then-put.js.
fast/js/script-tests/dictionary-no-cache.js: Copied from LayoutTests/fast/js/resources/dictionary-no-cache.js.
fast/js/script-tests/do-while-semicolon.js: Copied from LayoutTests/fast/js/resources/do-while-semicolon.js.
fast/js/script-tests/dot-node-base-exception.js: Copied from LayoutTests/fast/js/resources/dot-node-base-exception.js.
fast/js/script-tests/duplicate-param-crash.js: Copied from LayoutTests/fast/js/resources/duplicate-param-crash.js.
fast/js/script-tests/duplicate-param-gc-crash.js: Copied from LayoutTests/fast/js/resources/duplicate-param-gc-crash.js.
fast/js/script-tests/equality.js: Copied from LayoutTests/fast/js/resources/equality.js.
fast/js/script-tests/eval-cache-crash.js: Copied from LayoutTests/fast/js/resources/eval-cache-crash.js.
fast/js/script-tests/eval-throw-return.js: Copied from LayoutTests/fast/js/resources/eval-throw-return.js.
fast/js/script-tests/eval-var-decl.js: Copied from LayoutTests/fast/js/resources/eval-var-decl.js.
fast/js/script-tests/exception-expression-offset.js: Copied from LayoutTests/fast/js/resources/exception-expression-offset.js.
fast/js/script-tests/exception-for-nonobject.js: Copied from LayoutTests/fast/js/resources/exception-for-nonobject.js.
fast/js/script-tests/exception-linenums.js: Copied from LayoutTests/fast/js/resources/exception-linenums.js.
fast/js/script-tests/exception-try-finally-scope-error.js: Copied from LayoutTests/fast/js/resources/exception-try-finally-scope-error.js.
fast/js/script-tests/exception-with-handler-inside-eval-with-dynamic-scope.js: Copied from LayoutTests/fast/js/resources/exception-with-handler-inside-eval-with-dynamic-scope.js.
fast/js/script-tests/excessive-comma-usage.js: Copied from LayoutTests/fast/js/resources/excessive-comma-usage.js.
fast/js/script-tests/finally-codegen-failure.js: Copied from LayoutTests/fast/js/resources/finally-codegen-failure.js.
fast/js/script-tests/for-in-avoid-duplicates.js: Copied from LayoutTests/fast/js/resources/for-in-avoid-duplicates.js.
fast/js/script-tests/for-in-cached.js: Copied from LayoutTests/fast/js/resources/for-in-cached.js.
fast/js/script-tests/for-in-exeception.js: Copied from LayoutTests/fast/js/resources/for-in-exeception.js.
fast/js/script-tests/for-in-to-text.js: Copied from LayoutTests/fast/js/resources/for-in-to-text.js.
fast/js/script-tests/for-in-var-scope.js: Copied from LayoutTests/fast/js/resources/for-in-var-scope.js.
fast/js/script-tests/function-apply-aliased.js: Copied from LayoutTests/fast/js/resources/function-apply-aliased.js.
fast/js/script-tests/function-apply.js: Copied from LayoutTests/fast/js/resources/function-apply.js.
fast/js/script-tests/function-call-aliased.js: Copied from LayoutTests/fast/js/resources/function-call-aliased.js.
fast/js/script-tests/function-call-register-allocation.js: Copied from LayoutTests/fast/js/resources/function-call-register-allocation.js.
fast/js/script-tests/function-constructor-newline-after-brace.js: Copied from LayoutTests/fast/js/resources/function-constructor-newline-after-brace.js.
fast/js/script-tests/function-constructor-single-line-comment.js: Copied from LayoutTests/fast/js/resources/function-constructor-single-line-comment.js.
fast/js/script-tests/function-declaration-statement.js: Copied from LayoutTests/fast/js/resources/function-declaration-statement.js.
fast/js/script-tests/function-declaration.js: Copied from LayoutTests/fast/js/resources/function-declaration.js.
fast/js/script-tests/function-declarations-in-switch-statement.js: Copied from LayoutTests/fast/js/resources/function-declarations-in-switch-statement.js.
fast/js/script-tests/function-dot-arguments.js: Copied from LayoutTests/fast/js/resources/function-dot-arguments.js.
fast/js/script-tests/function-name.js: Copied from LayoutTests/fast/js/resources/function-name.js.
fast/js/script-tests/function-names.js: Copied from LayoutTests/fast/js/resources/function-names.js.
fast/js/script-tests/function-toString-object-literals.js: Copied from LayoutTests/fast/js/resources/function-toString-object-literals.js.
fast/js/script-tests/function-toString-parentheses.js: Copied from LayoutTests/fast/js/resources/function-toString-parentheses.js.
fast/js/script-tests/function-toString-semicolon-insertion.js: Copied from LayoutTests/fast/js/resources/function-toString-semicolon-insertion.js.
fast/js/script-tests/getter-setter-gc.js: Copied from LayoutTests/fast/js/resources/getter-setter-gc.js.
fast/js/script-tests/global-constructors.js: Copied from LayoutTests/fast/js/resources/global-constructors.js.
fast/js/script-tests/global-function-resolve.js: Copied from LayoutTests/fast/js/resources/global-function-resolve.js.
fast/js/script-tests/gmail-re-re.js: Copied from LayoutTests/fast/js/resources/gmail-re-re.js.
fast/js/script-tests/has-own-property.js: Copied from LayoutTests/fast/js/resources/has-own-property.js.
fast/js/script-tests/ignored-result-null-comparison-crash.js: Copied from LayoutTests/fast/js/resources/ignored-result-null-comparison-crash.js.
fast/js/script-tests/ignored-result-ref-crash.js: Copied from LayoutTests/fast/js/resources/ignored-result-ref-crash.js.
fast/js/script-tests/implicit-call-with-global-reentry.js: Copied from LayoutTests/fast/js/resources/implicit-call-with-global-reentry.js.
fast/js/script-tests/instance-of-immediates.js: Copied from LayoutTests/fast/js/resources/instance-of-immediates.js.
fast/js/script-tests/instanceof-operator.js: Copied from LayoutTests/fast/js/resources/instanceof-operator.js.
fast/js/script-tests/integer-extremes.js: Copied from LayoutTests/fast/js/resources/integer-extremes.js.
fast/js/script-tests/isPrototypeOf.js: Copied from LayoutTests/fast/js/resources/isPrototypeOf.js.
fast/js/script-tests/large-expressions.js: Copied from LayoutTests/fast/js/resources/large-expressions.js.
fast/js/script-tests/lastModified.js: Copied from LayoutTests/fast/js/resources/lastModified.js.
fast/js/script-tests/logical-or-jless.js: Copied from LayoutTests/fast/js/resources/logical-or-jless.js.
fast/js/script-tests/math-transforms.js: Copied from LayoutTests/fast/js/resources/math-transforms.js.
fast/js/script-tests/math.js: Copied from LayoutTests/fast/js/resources/math.js.
fast/js/script-tests/method-check.js: Copied from LayoutTests/fast/js/resources/method-check.js.
fast/js/script-tests/mod-crash.js: Copied from LayoutTests/fast/js/resources/mod-crash.js.
fast/js/script-tests/modify-non-references.js: Copied from LayoutTests/fast/js/resources/modify-non-references.js.
fast/js/script-tests/named-function-expression.js: Copied from LayoutTests/fast/js/resources/named-function-expression.js.
fast/js/script-tests/navigator-mimeTypes-length.js: Copied from LayoutTests/fast/js/resources/navigator-mimeTypes-length.js.
fast/js/script-tests/nested-object-gc.js: Copied from LayoutTests/fast/js/resources/nested-object-gc.js.
fast/js/script-tests/non-object-proto.js: Copied from LayoutTests/fast/js/resources/non-object-proto.js.
fast/js/script-tests/null-char-in-string.js: Copied from LayoutTests/fast/js/resources/null-char-in-string.js.
fast/js/script-tests/number-cell-reuse.js: Copied from LayoutTests/fast/js/resources/number-cell-reuse.js.
fast/js/script-tests/number-parsing-crash.js: Copied from LayoutTests/fast/js/resources/number-parsing-crash.js.
fast/js/script-tests/number-toExponential.js: Copied from LayoutTests/fast/js/resources/number-toExponential.js.
fast/js/script-tests/number-toString.js: Copied from LayoutTests/fast/js/resources/number-toString.js.
fast/js/script-tests/number-tofixed.js: Copied from LayoutTests/fast/js/resources/number-tofixed.js.
fast/js/script-tests/number-toprecision.js: Copied from LayoutTests/fast/js/resources/number-toprecision.js.
fast/js/script-tests/numeric-conversion.js: Copied from LayoutTests/fast/js/resources/numeric-conversion.js.
fast/js/script-tests/object-extra-comma.js: Copied from LayoutTests/fast/js/resources/object-extra-comma.js.
fast/js/script-tests/object-prototype-constructor.js: Copied from LayoutTests/fast/js/resources/object-prototype-constructor.js.
fast/js/script-tests/object-prototype-toLocaleString.js: Copied from LayoutTests/fast/js/resources/object-prototype-toLocaleString.js.
fast/js/script-tests/order-of-operations.js: Copied from LayoutTests/fast/js/resources/order-of-operations.js.
fast/js/script-tests/parse-backslash-before-newline.js: Copied from LayoutTests/fast/js/resources/parse-backslash-before-newline.js.
fast/js/script-tests/postfix-syntax.js: Copied from LayoutTests/fast/js/resources/postfix-syntax.js.
fast/js/script-tests/prefix-syntax.js: Copied from LayoutTests/fast/js/resources/prefix-syntax.js.
fast/js/script-tests/pretty-print.js: Copied from LayoutTests/fast/js/resources/pretty-print.js.
fast/js/script-tests/primitive-method-this.js: Copied from LayoutTests/fast/js/resources/primitive-method-this.js.
fast/js/script-tests/primitive-property-access-edge-cases.js: Copied from LayoutTests/fast/js/resources/primitive-property-access-edge-cases.js.
fast/js/script-tests/property-getters-and-setters.js: Copied from LayoutTests/fast/js/resources/property-getters-and-setters.js.
fast/js/script-tests/propertyIsEnumerable.js: Copied from LayoutTests/fast/js/resources/propertyIsEnumerable.js.
fast/js/script-tests/prototypes.js: Copied from LayoutTests/fast/js/resources/prototypes.js.
fast/js/script-tests/read-modify-eval.js: Copied from LayoutTests/fast/js/resources/read-modify-eval.js.
fast/js/script-tests/recursion-limit-equal.js: Copied from LayoutTests/fast/js/resources/recursion-limit-equal.js.
fast/js/script-tests/reentrant-call-unwind.js: Copied from LayoutTests/fast/js/resources/reentrant-call-unwind.js.
fast/js/script-tests/regexp-backreferences.js: Copied from LayoutTests/fast/js/resources/regexp-backreferences.js.
fast/js/script-tests/regexp-char-insensitive.js: Copied from LayoutTests/fast/js/resources/regexp-char-insensitive.js.
fast/js/script-tests/regexp-character-match-out-of-order.js: Copied from LayoutTests/fast/js/resources/regexp-character-match-out-of-order.js.
fast/js/script-tests/regexp-compile-crash.js: Copied from LayoutTests/fast/js/resources/regexp-compile-crash.js.
fast/js/script-tests/regexp-compile.js: Copied from LayoutTests/fast/js/resources/regexp-compile.js.
fast/js/script-tests/regexp-divequal.js: Copied from LayoutTests/fast/js/resources/regexp-divequal.js.
fast/js/script-tests/regexp-extended-characters-crash.js: Copied from LayoutTests/fast/js/resources/regexp-extended-characters-crash.js.
fast/js/script-tests/regexp-extended-characters-match.js: Copied from LayoutTests/fast/js/resources/regexp-extended-characters-match.js.
fast/js/script-tests/regexp-extended-characters-more.js: Copied from LayoutTests/fast/js/resources/regexp-extended-characters-more.js.
fast/js/script-tests/regexp-find-first-asserted.js: Copied from LayoutTests/fast/js/resources/regexp-find-first-asserted.js.
fast/js/script-tests/regexp-lastindex.js: Copied from LayoutTests/fast/js/resources/regexp-lastindex.js.
fast/js/script-tests/regexp-many-brackets.js: Copied from LayoutTests/fast/js/resources/regexp-many-brackets.js.
fast/js/script-tests/regexp-negative-special-characters.js: Copied from LayoutTests/fast/js/resources/regexp-negative-special-characters.js.
fast/js/script-tests/regexp-no-extensions.js: Copied from LayoutTests/fast/js/resources/regexp-no-extensions.js.
fast/js/script-tests/regexp-non-bmp.js: Copied from LayoutTests/fast/js/resources/regexp-non-bmp.js.
fast/js/script-tests/regexp-non-capturing-groups.js: Copied from LayoutTests/fast/js/resources/regexp-non-capturing-groups.js.
fast/js/script-tests/regexp-non-character.js: Copied from LayoutTests/fast/js/resources/regexp-non-character.js.
fast/js/script-tests/regexp-overflow-too-big.js: Copied from LayoutTests/fast/js/resources/regexp-overflow-too-big.js.
fast/js/script-tests/regexp-overflow.js: Copied from LayoutTests/fast/js/resources/regexp-overflow.js.
fast/js/script-tests/regexp-range-bound-ffff.js: Copied from LayoutTests/fast/js/resources/regexp-range-bound-ffff.js.
fast/js/script-tests/regexp-range-out-of-order.js: Copied from LayoutTests/fast/js/resources/regexp-range-out-of-order.js.
fast/js/script-tests/regexp-ranges-and-escaped-hyphens.js: Copied from LayoutTests/fast/js/resources/regexp-ranges-and-escaped-hyphens.js.
fast/js/script-tests/regexp-stack-overflow.js: Copied from LayoutTests/fast/js/resources/regexp-stack-overflow.js.
fast/js/script-tests/regexp-unicode-handling.js: Copied from LayoutTests/fast/js/resources/regexp-unicode-handling.js.
fast/js/script-tests/regexp-unicode-overflow.js: Copied from LayoutTests/fast/js/resources/regexp-unicode-overflow.js.
fast/js/script-tests/registerCachingAcrossBranchTargets.js: Copied from LayoutTests/fast/js/resources/registerCachingAcrossBranchTargets.js.
fast/js/script-tests/rehash-assign.js: Copied from LayoutTests/fast/js/resources/rehash-assign.js.
fast/js/script-tests/removing-Cf-characters.js: Copied from LayoutTests/fast/js/resources/removing-Cf-characters.js.
fast/js/script-tests/reparsing-semicolon-insertion.js: Copied from LayoutTests/fast/js/resources/reparsing-semicolon-insertion.js.
fast/js/script-tests/repeat-cached-vm-reentry.js: Copied from LayoutTests/fast/js/resources/repeat-cached-vm-reentry.js.
fast/js/script-tests/reserved-words.js: Copied from LayoutTests/fast/js/resources/reserved-words.js.
fast/js/script-tests/resize-array-assign.js: Copied from LayoutTests/fast/js/resources/resize-array-assign.js.
fast/js/script-tests/select-options-add.js: Copied from LayoutTests/fast/js/resources/select-options-add.js.
fast/js/script-tests/slash-lineterminator-parse.js: Copied from LayoutTests/fast/js/resources/slash-lineterminator-parse.js.
fast/js/script-tests/sort-large-array.js: Copied from LayoutTests/fast/js/resources/sort-large-array.js.
fast/js/script-tests/sort-no-jit-code-crash.js: Copied from LayoutTests/fast/js/resources/sort-no-jit-code-crash.js.
fast/js/script-tests/sort-non-numbers.js: Copied from LayoutTests/fast/js/resources/sort-non-numbers.js.
fast/js/script-tests/sort-randomly.js: Copied from LayoutTests/fast/js/resources/sort-randomly.js.
fast/js/script-tests/sort-stability.js: Copied from LayoutTests/fast/js/resources/sort-stability.js.
fast/js/script-tests/sparse-array.js: Copied from LayoutTests/fast/js/resources/sparse-array.js.
fast/js/script-tests/stack-unwinding.js: Copied from LayoutTests/fast/js/resources/stack-unwinding.js.
fast/js/script-tests/statement-list-register-crash.js: Copied from LayoutTests/fast/js/resources/statement-list-register-crash.js.
fast/js/script-tests/static-scope-object.js: Copied from LayoutTests/fast/js/resources/static-scope-object.js.
fast/js/script-tests/string-capitalization.js: Copied from LayoutTests/fast/js/resources/string-capitalization.js.
fast/js/script-tests/string-from-char-code.js: Copied from LayoutTests/fast/js/resources/string-from-char-code.js.
fast/js/script-tests/string-index-overflow.js: Copied from LayoutTests/fast/js/resources/string-index-overflow.js.
fast/js/script-tests/string-property-iteration.js: Copied from LayoutTests/fast/js/resources/string-property-iteration.js.
fast/js/script-tests/string-replace-2.js: Copied from LayoutTests/fast/js/resources/string-replace-2.js.
fast/js/script-tests/string-replace-3.js: Copied from LayoutTests/fast/js/resources/string-replace-3.js.
fast/js/script-tests/string-slice-abnormal-values.js: Copied from LayoutTests/fast/js/resources/string-slice-abnormal-values.js.
fast/js/script-tests/string-sort.js: Copied from LayoutTests/fast/js/resources/string-sort.js.
fast/js/script-tests/string-split-ignore-case.js: Copied from LayoutTests/fast/js/resources/string-split-ignore-case.js.
fast/js/script-tests/string-substr.js: Copied from LayoutTests/fast/js/resources/string-substr.js.
fast/js/script-tests/string_replace.js: Copied from LayoutTests/fast/js/resources/string_replace.js.
fast/js/script-tests/switch-behaviour.js: Copied from LayoutTests/fast/js/resources/switch-behaviour.js.
fast/js/script-tests/this-non-object-proto.js: Copied from LayoutTests/fast/js/resources/this-non-object-proto.js.
fast/js/script-tests/toString-elision-trailing-comma.js: Copied from LayoutTests/fast/js/resources/toString-elision-trailing-comma.js.
fast/js/script-tests/toString-exception.js: Copied from LayoutTests/fast/js/resources/toString-exception.js.
fast/js/script-tests/toString-for-var-decl.js: Copied from LayoutTests/fast/js/resources/toString-for-var-decl.js.
fast/js/script-tests/toString-number-dot-expr.js: Copied from LayoutTests/fast/js/resources/toString-number-dot-expr.js.
fast/js/script-tests/toString-overrides.js: Copied from LayoutTests/fast/js/resources/toString-overrides.js.
fast/js/script-tests/toString-prefix-postfix-preserve-parens.js: Copied from LayoutTests/fast/js/resources/toString-prefix-postfix-preserve-parens.js.
fast/js/script-tests/toString-stack-overflow.js: Copied from LayoutTests/fast/js/resources/toString-stack-overflow.js.
fast/js/script-tests/tostring-exception-in-property-access.js: Copied from LayoutTests/fast/js/resources/tostring-exception-in-property-access.js.
fast/js/script-tests/transition-cache-dictionary-crash.js: Copied from LayoutTests/fast/js/resources/transition-cache-dictionary-crash.js.
fast/js/script-tests/typeof-codegen-crash.js: Copied from LayoutTests/fast/js/resources/typeof-codegen-crash.js.
fast/js/script-tests/typeof-constant-string.js: Copied from LayoutTests/fast/js/resources/typeof-constant-string.js.
fast/js/script-tests/typeof-syntax.js: Copied from LayoutTests/fast/js/resources/typeof-syntax.js.
fast/js/script-tests/unexpected-constant-crash.js: Copied from LayoutTests/fast/js/resources/unexpected-constant-crash.js.
fast/js/script-tests/unmatching-argument-count.js: Copied from LayoutTests/fast/js/resources/unmatching-argument-count.js.
fast/js/script-tests/var-shadows-arg-crash.js: Copied from LayoutTests/fast/js/resources/var-shadows-arg-crash.js.
fast/js/script-tests/var-shadows-arg-gc-crash.js: Copied from LayoutTests/fast/js/resources/var-shadows-arg-gc-crash.js.
fast/js/script-tests/vardecl-blocks-init.js: Copied from LayoutTests/fast/js/resources/vardecl-blocks-init.js.
fast/js/script-tests/vardecl-preserve-arguments.js: Copied from LayoutTests/fast/js/resources/vardecl-preserve-arguments.js.
fast/js/script-tests/with-scope-gc.js: Copied from LayoutTests/fast/js/resources/with-scope-gc.js.
fast/js/select-options-add.html:
fast/js/slash-lineterminator-parse.html:
fast/js/sort-large-array.html:
fast/js/sort-no-jit-code-crash.html:
fast/js/sort-non-numbers.html:
fast/js/sort-randomly.html:
fast/js/sort-stability.html:
fast/js/sparse-array.html:
fast/js/stack-unwinding.html:
fast/js/statement-list-register-crash.html:
fast/js/static-scope-object.html:
fast/js/string-capitalization.html:
fast/js/string-from-char-code.html:
fast/js/string-index-overflow.html:
fast/js/string-property-iteration.html:
fast/js/string-replace-2.html:
fast/js/string-replace-3.html:
fast/js/string-slice-abnormal-values.html:
fast/js/string-sort.html:
fast/js/string-split-ignore-case.html:
fast/js/string-substr.html:
fast/js/string_replace.html:
fast/js/switch-behaviour.html:
fast/js/this-non-object-proto.html:
fast/js/toString-elision-trailing-comma.html:
fast/js/toString-exception.html:
fast/js/toString-for-var-decl.html:
fast/js/toString-number-dot-expr.html:
fast/js/toString-overrides.html:
fast/js/toString-prefix-postfix-preserve-parens.html:
fast/js/toString-stack-overflow.html:
fast/js/tostring-exception-in-property-access.html:
fast/js/transition-cache-dictionary-crash.html:
fast/js/typeof-codegen-crash.html:
fast/js/typeof-constant-string.html:
fast/js/typeof-syntax.html:
fast/js/unexpected-constant-crash.html:
fast/js/unmatching-argument-count.html:
fast/js/var-shadows-arg-crash.html:
fast/js/var-shadows-arg-gc-crash.html:
fast/js/vardecl-blocks-init.html:
fast/js/vardecl-preserve-arguments.html:
fast/js/with-scope-gc.html:

2:15 PM Changeset in webkit [48650] by Darin Adler

2 edits in trunk/JavaScriptCore

wtf/Forward.h: Added PassOwnPtr.

Reviewed by Sam Weinig.

2:11 PM Changeset in webkit [48649] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-09-22 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
https://bugs.webkit.org/show_bug.cgi?id=29220

Scripts/run-webkit-tests:

1:38 PM Changeset in webkit [48648] by weinig@apple.com

2 edits in trunk/WebKit/win

Rubber-stamped by Adam Roben.

Remove accidentally left in declaration of reloadFromOrigin in IWebFramePrivate.idl

Interfaces/IWebFramePrivate.idl:

1:19 PM Changeset in webkit [48647] by Beth Dakin

6 edits
24 adds in trunk

WebCore: Fix for <rdar://problem/6925121> SAP: Wrong width calculation in
table with fixed layout
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29501

Reviewed by Dave Hyatt.

New Tests:

fast/table/fixed-table-with-percent-inside-percent-table.html: Added.
fast/table/fixed-table-with-percent-width-inside-auto-table.html: Added.
fast/table/fixed-table-with-percent-width-inside-div.html: Added.
fast/table/fixed-table-with-percent-width-inside-extra-large-div.html: Added.
fast/table/fixed-table-with-percent-width-inside-fixed-width-table.html: Added.
fast/table/fixed-table-with-small-percent-width.html: Added.

This new quirk is very similar to an existing one that was
implemented in revision 4316.

rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcPrefWidths):

LayoutTests: Tests for <rdar://problem/6925121> SAP: Wrong width calculation in
table with fixed layout
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29501

Reviewed by Dave Hyatt.

fast/table/fixed-table-with-percent-inside-percent-table.html: Added.
fast/table/fixed-table-with-percent-width-inside-auto-table.html: Added.
fast/table/fixed-table-with-percent-width-inside-div.html: Added.
fast/table/fixed-table-with-percent-width-inside-extra-large-div.html: Added.
fast/table/fixed-table-with-percent-width-inside-fixed-width-table.html: Added.
fast/table/fixed-table-with-small-percent-width.html: Added.
platform/mac/fast/table/fixed-table-with-percent-inside-percent-table-expected.checksum: Added.
platform/mac/fast/table/fixed-table-with-percent-inside-percent-table-expected.png: Added.
platform/mac/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt: Added.
platform/mac/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.checksum: Added.
platform/mac/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png: Added.
platform/mac/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt: Added.
platform/mac/fast/table/fixed-table-with-percent-width-inside-div-expected.checksum: Added.
platform/mac/fast/table/fixed-table-with-percent-width-inside-div-expected.png: Added.
platform/mac/fast/table/fixed-table-with-percent-width-inside-div-expected.txt: Added.
platform/mac/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.checksum: Added.
platform/mac/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.png: Added.
platform/mac/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Added.
platform/mac/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.checksum: Added.
platform/mac/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.png: Added.
platform/mac/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt: Added.
platform/mac/fast/table/fixed-table-with-small-percent-width-expected.checksum: Added.
platform/mac/fast/table/fixed-table-with-small-percent-width-expected.png: Added.
platform/mac/fast/table/fixed-table-with-small-percent-width-expected.txt: Added.

New and improved results for this test.

platform/mac/tables/mozilla/bugs/bug34176-expected.checksum:
platform/mac/tables/mozilla/bugs/bug34176-expected.png:
platform/mac/tables/mozilla/bugs/bug34176-expected.txt:

1:11 PM Changeset in webkit [48646] by bweinstein@apple.com

6 edits
3 adds in trunk/WebCore

2009-09-22 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.

List HTTP status code with response headers in resources tab of Web Inspector.
http://webkit.org/b/19945

This patch adds a new top level list in the resources tab, HTTP Information, that
for now, contains the Request Method (GET, POST, etc.) and the Status Code (200, 404, etc.).
Additionally, it adds a colored dot next to the requested URL to show the status
(green for success, orange for redirect, red for error).

English.lproj/localizedStrings.js:
inspector/front-end/ImageView.js: (WebInspector.ImageView):
inspector/front-end/Images/errorRedDot.png: Added.
inspector/front-end/Images/successGreenDot.png: Added.
inspector/front-end/Images/warningOrangeDot.png: Added.
inspector/front-end/Resource.js: (WebInspector.Resource.StatusTextForCode):
inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._refreshURL): (WebInspector.ResourceView.prototype._refreshHTTPInformation):
inspector/front-end/inspector.css:

1:06 PM Changeset in webkit [48645] by weinig@apple.com

8 edits in trunk/WebKit/win

Fix for <rdar://problem/6451745>
Windows WebKit needs to implement reloadFromOrigin()

Reviewed by Steve Falkenburg.

Interfaces/IWebFrame.idl:
Interfaces/IWebFramePrivate.idl:
Interfaces/IWebView.idl:
WebFrame.cpp:

(WebFrame::reloadFromOrigin):

WebFrame.h:
WebView.cpp:

(WebView::reloadFromOrigin):

WebView.h:

1:04 PM Changeset in webkit [48644] by beidson@apple.com

4 edits
3 adds in trunk

Back list isn't properly updated for fragment changes after a redirect.
<rdar://problem/6142803> and https://bugs.webkit.org/show_bug.cgi?id=20355

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/fragment-after-redirect-gets-back-entry.html

loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL): Properly reset the policy FrameLoadType before

consulting the policy delegate for fragment scrolling.

LayoutTests:

fast/loader/fragment-after-redirect-gets-back-entry-expected.txt: Added.
fast/loader/fragment-after-redirect-gets-back-entry.html: Added.
fast/loader/resources/click-fragment-link.html: Added.

http/tests/navigation/relativeanchor-frames-expected.txt: Updated results (a progression!)

12:29 PM Changeset in webkit [48643] by Adam Roben

2 edits in trunk/WebKit/win

Manage refcounts correctly in DefaultDownloadDelegate::willSendRequest

Fixes <http://webkit.org/b/29650> Crash in
WebDownload::willSendRequest when using DefaultDownloadDelegate

Reviewed by Brady Eidson.

DefaultDownloadDelegate.cpp:

(DefaultDownloadDelegate::willSendRequest): Call AddRef() on the
object we're returning via the finalRequest out-parameter.

11:02 AM Changeset in webkit [48642] by darin@chromium.org

3 edits in trunk/WebCore

2009-09-22 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

Drop down selects get stuck in the non-visible state and cannot be opened.
https://bugs.webkit.org/show_bug.cgi?id=29645

All paths that lead to hiding the popup menu must call popupDidHide on
the PopupMenuClient. This change makes it so by moving all of the
hiding logic to PopupListBox::hidePopup.

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::hidePopup): (WebCore::PopupListBox::hidePopup):
platform/chromium/PopupMenuChromium.h:

10:41 AM Changeset in webkit [48641] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-22 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

WebInspector.log() function not protected if console not yet created
https://bugs.webkit.org/show_bug.cgi?id=29336

No new tests. Only affects Web Inspector developers adding logging
to their code during development.

inspector/front-end/inspector.js: (WebInspector.log.isLogAvailable): (WebInspector.log.flushQueue): (WebInspector.log.flushQueueIfAvailable): (WebInspector.log.logMessage): (WebInspector.log):

10:34 AM Changeset in webkit [48640] by eric@webkit.org

3 edits
6 adds in trunk

2009-09-22 Yaar Schnitman <yaar@chromium.org>

Reviewed by David Levin.

Ported chromium.org's javascriptcore.gyp for the webkit chromium port.

https://bugs.webkit.org/show_bug.cgi?id=29617

JavaScriptCore.gyp/JavaScriptCore.gyp: Added.

2009-09-22 Yaar Schnitman <yaar@chromium.org>

Reviewed by David Levin.

Ported chromium.org's webcore.gyp for the webkit chromium port.

https://bugs.webkit.org/show_bug.cgi?id=29617

WebCore.gyp/WebCore.gyp: Added.

2009-09-22 Yaar Schnitman <yaar@chromium.org>

Reviewed by David Levin.

Create chromium directory and ported chromium.org's features.gypi for
the webkit chromium port.

https://bugs.webkit.org/show_bug.cgi?id=29617

chromium/features.gypi: Added.

10:26 AM Changeset in webkit [48639] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-22 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>

Reviewed by Adam Barth.

[v8] Don't keep clean wrappers artificially alive
We currently keep all DOM node wrappers alive, even when there are
no more references to them from JS, in case they have properties
that we need to keep around if new JS references are created.
This changes the policy to only keep wrappers artificially alive
if they have changed since they were created. Empty wrappers are
discarded and recreated as needed.
https://bugs.webkit.org/show_bug.cgi?id=29330

bindings/v8/V8GCController.cpp: (WebCore::ObjectGrouperVisitor::visitDOMWrapper):

10:19 AM Changeset in webkit [48638] by eric@webkit.org

1 edit
3 adds in trunk/LayoutTests

2009-09-22 Victor Wang <victorw@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=28914

Add layout test to test iframe shim can be used
to overlay html above a windowed plugin. It checks
premutations of iframe shims in relationship to
plugin.

plugins/iframe-shims-expected.txt: Added with property svn:eol-style.
plugins/iframe-shims.html: Added with property svn:eol-style.
plugins/resources/simple_blank.swf: Added with property svn:mime-type.

9:59 AM Changeset in webkit [48637] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-09-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: console.count and console.timeEnd
crash when inspector is opened.

https://bugs.webkit.org/show_bug.cgi?id=29632

inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addMessageToConsole):

9:24 AM Changeset in webkit [48636] by xan@webkit.org

2 edits in trunk

2009-09-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

link errors due to wrong UNICODE_LIBS on Ubuntu Jaunty
https://bugs.webkit.org/show_bug.cgi?id=29638

Call icu-cconfig with ldflags-libsonly to prevent having a -L
statement that could override libs installed in another prefix.

autotools/webkit.m4:

7:42 AM Changeset in webkit [48635] by abarth@webkit.org

2 edits in trunk/WebCore

2009-09-22 Adam Barth <abarth@webkit.org>

Unreviewed.

Fix bogus build fix I did last night.

bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl):

7:26 AM Changeset in webkit [48634] by mitz@apple.com

2 edits in trunk/WebKit/mac

<rdar://problem/7240911> REGRESSION (r48586): Crash occurs when loading
a PDF

Reviewed by John Sullivan.

WebView/WebPDFDocumentExtras.mm:

(addWebPDFDocumentExtras): Made methodList static, because
class_addMethods() doesn't copy it.

6:16 AM Changeset in webkit [48633] by Simon Hausmann

2 edits in trunk/LayoutTests

Rubber-stamped by Tor Arne Vestbø.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-22
[Qt] Skip fluctuating animations/change-one-anim.html test.

platform/qt/Skipped:

6:05 AM Changeset in webkit [48632] by Simon Hausmann

2 edits in trunk/WebKit/qt

[Qt] Add default timeout while waiting for signals in QWebPage auto
tests.
https://bugs.webkit.org/show_bug.cgi?id=29637

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-22
Reviewed by Simon Hausmann.

tests/qwebpage/tst_qwebpage.cpp:

(waitForSignal):

6:00 AM Changeset in webkit [48631] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

Hardcode element positions at 0,0 so that we know where to
generate events to test WebKitHitTestResult.

tests/testhittestresult.c: (load_status_cb): (test_webkit_hit_test_result): (main):

5:59 AM Changeset in webkit [48630] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Fix compilation with WINSCW: no varargs macros

Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2009-09-22
Reviewed by Simon Hausmann.

Disable variadic arguments for WINSCW just like we do
for MSVC7.

wtf/Assertions.h:

5:57 AM Changeset in webkit [48629] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Disable variadic macros on MSVC7.

Patch by Kent Hansen <khansen@trolltech.com> on 2009-09-22
Reviewed by Simon Hausmann.

This was originally added in r26589 but not extended
when LOG_DISABLED/ASSERT_DISABLED was introduced.

wtf/Assertions.h:

5:20 AM Changeset in webkit [48628] by vestbo@webkit.org

2 edits in trunk/WebCore

NPAPI/Mac: Don't paint plugins if we don't have a CGContextRef

Reviewed by Simon Hausmann.

plugins/mac/PluginViewMac.cpp:

5:20 AM Changeset in webkit [48627] by vestbo@webkit.org

5 edits in trunk

Fix the Qt/Mac build after r48604 (Implement new QWebPageClient class)

Reivewed by Simon Hausmann.

5:11 AM Changeset in webkit [48626] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

[GTK] WebKitHitTestResult is completely broken in gmail
https://bugs.webkit.org/show_bug.cgi?id=29527

We need to use the main or focused frame when doing the coordinate
transformation instead of always using the main frame.

webkit/webkitwebview.cpp: (webkit_web_view_get_hit_test_result):

5:06 AM Changeset in webkit [48625] by zoltan@webkit.org

2 edits in trunk/LayoutTests

2009-09-22 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Tor Arne VestbÃ¸.

[Qt] Skip fast/events/drag-file-crash because DRT doesn't support eventSender.beginDragWithFiles yet.

platform/qt/Skipped:

3:50 AM Changeset in webkit [48624] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Unreviewed build fix for Windows CE < 5

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-22
Define WINCEBASIC to disable the IsDebuggerPresent() code in
wtf/Assertions.cpp.

JavaScriptCore.pri:

3:30 AM Changeset in webkit [48623] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Fix major memory leak in JavaScriptCore RegisterFile on Windows CE

Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-22
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29367

On Widows CE we must decommit all committed pages before we release
them. See VirtualFree documentation.
Desktop Windows behaves much smoother in this situation.

interpreter/RegisterFile.cpp:

(JSC::RegisterFile::~RegisterFile):

2:48 AM Changeset in webkit [48622] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-09-22 Eric Seidel <eric@webkit.org>

Reviewed by David Kilzer.

svn-apply can't handle single-line binary file additions
https://bugs.webkit.org/show_bug.cgi?id=29100

Fixed the regexp and added a unit test.

Scripts/modules/scm_unittest.py:
Scripts/svn-apply:

Sep 21, 2009:

10:35 PM Changeset in webkit [48621] by abarth@webkit.org

1 edit in trunk/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

Added missing brace.

10:25 PM Changeset in webkit [48620] by abarth@webkit.org

2 edits in trunk/WebCore

2009-09-21 Adam Barth <abarth@webkit.org>

Attempted fix for the V8 build.

bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl):

10:08 PM Changeset in webkit [48619] by abarth@webkit.org

5 edits in trunk/WebCore

2009-09-21 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Don't re-enter JavaScript after performing access checks
https://bugs.webkit.org/show_bug.cgi?id=29531

Moved the access check slightly later in this functions to avoid
re-entering the JavaScript interpreter (typically via toString)
after performing the access check.

I can't really think of a meaningful test for this change. It's more
security hygiene.

bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHref): (WebCore::JSLocation::replace): (WebCore::JSLocation::assign):
bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): (WebCore::if): (CALLBACK_FUNC_DECL): (V8Custom::WindowSetLocation): (V8Custom::ClearTimeoutImpl):
bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):

9:57 PM Changeset in webkit [48618] by abarth@webkit.org

1 edit
2 adds in trunk/LayoutTests

2009-09-21 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

add a layout test for mishandling of an invalid sequence in multibyte
encodings
https://bugs.webkit.org/show_bug.cgi?id=27395

fast/encoding/invalid-multi-byte-over-consumption-expected.txt: Added.
fast/encoding/invalid-multi-byte-over-consumption.html: Added.

7:34 PM Changeset in webkit [48617] by eric@webkit.org

4 edits in trunk/WebCore

2009-09-21 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Eric Seidel.

Make all write transaction start with a BEGIN IMMEDIATE command
instead of BEGIN.

We cannot test this change in a layout test, because in order to
test it we need to spawn two database threads and execute
transaction steps on these two threads in a very specific order,
which seems impossible to do when they share the same main thread
(as they would in a layout test). The SQLite docs and the case
described in the bug though should be enough proof that we do have
a problem here and that this patch will fix it.

Relevant SQLite documentation:
http://www.sqlite.org/lang_transaction.html
http://www.sqlite.org/lockingv3.html#locking

https://bugs.webkit.org/show_bug.cgi?id=29218

platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::SQLiteTransaction): Added a readOnly parameter. (WebCore::SQLiteTransaction::begin): Changed to BEGIN IMMEDIATE for write transactions.
platform/sql/SQLiteTransaction.h:
storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight): Passing the read-only flag to the SQLiteTransaction instance.

7:15 PM Changeset in webkit [48616] by beidson@apple.com

2 edits in trunk/WebKitSite

Add coding style guidelines for 'using namespace.'
https://bugs.webkit.org/show_bug.cgi?id=29499

Reviewed by Darin Adler.

coding/coding-style.html:

6:35 PM Changeset in webkit [48615] by beidson@apple.com

2 edits in trunk/WebCore

Rubberstamped by Mark Rowe.

DerivedSources.make: Fix the Xcode build on SnowLeopard.

5:58 PM Changeset in webkit [48614] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-09-11 Eric Seidel <eric@webkit.org>

Reviewed by David Kilzer.

post-diff and post-commits should be able to find bug urls in ChangeLogs.
https://bugs.webkit.org/show_bug.cgi?id=29206

Scripts/bugzilla-tool:
- Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
- Rename --no-comment to --add-log-as-comment and reverse behavior. Comments tend to just be noise. I'll eventually remove this argument if no one uses it.
- Split out code into helper functions to try and make execute() more legible.
- Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
- Fallback to bug urls in commit diffs, instead of just in commit messages, meaning post-commits will now find bug urls in ChangeLogs.

5:28 PM Changeset in webkit [48613] by bweinstein@apple.com

2 edits in trunk/LayoutTests

2009-09-21 Brian Weinstein <bweinstein@apple.com>

Reviewed by Sam Weinig.

Add fast/events/drag-file-crash.html to Windows Skipped List because
DRT doesn't support eventSender.beginDragWithFiles on Windows yet.

platform/win/Skipped:

5:19 PM Changeset in webkit [48612] by jam@chromium.org

10 edits
5 adds in trunk

WebCore:
2009-09-15 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

Prevent sleeps in unload handlers.
https://bugs.webkit.org/show_bug.cgi?id=29193

Test: fast/dom/Window/slow_unload_handler.html

WebCore.gypi:
bindings/v8/DateExtension.cpp: Added. (WebCore::DateExtension::DateExtension): (WebCore::DateExtension::get): (WebCore::DateExtension::setAllowSleep): (WebCore::DateExtension::GetNativeFunction): (WebCore::DateExtension::weakCallback): (WebCore::DateExtension::GiveEnableSleepDetectionFunction): (WebCore::DateExtension::OnSleepDetected):
bindings/v8/DateExtension.h: Added.
bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createNewContext): (WebCore::V8Proxy::registerExtensionWithV8): (WebCore::V8Proxy::registeredExtensionWithV8):
bindings/v8/V8Proxy.h:

LayoutTests:
2009-09-15 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

Prevent sleeps in unload handlers.
https://bugs.webkit.org/show_bug.cgi?id=29193

fast/dom/Window/resources/slow_unload_handler1.html: Added.
fast/dom/Window/slow_unload_handler-expected.txt: Added.
fast/dom/Window/slow_unload_handler.html: Added.
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

5:09 PM Changeset in webkit [48611] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-09-21 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Maciej Stachowiak.

--parse-only parameter wasn't passed to SunSpider/sunspider script.
https://bugs.webkit.org/show_bug.cgi?id=29611

Scripts/run-sunspider: Missing parameter passing added.

5:07 PM Changeset in webkit [48610] by jianli@chromium.org

3 edits in trunk/WebCore

[V8] Run-time exception in onmessage handler is not forwarded to the
worker object.
https://bugs.webkit.org/show_bug.cgi?id=28980

Reviewed by David Levin.

The previous fix was partially reverted due to a reliability build break
in chromium. The break happens when an exception is thrown without
setting a message. We need to check for this scenario and handle it.

Tested by worker-close.html.

bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::invokeEventHandler):

bindings/v8/V8Utilities.cpp:

(WebCore::reportException):

4:10 PM Changeset in webkit [48609] by bolsinga@apple.com

18 edits
1 add in trunk

JavaScriptCore: Add ENABLE(ORIENTATION_EVENTS)
https://bugs.webkit.org/show_bug.cgi?id=29508

Reviewed by Simon Fraser & Sam Weinig.

wtf/Platform.h: Also sort PLATFORM(IPHONE) #defines.

WebCore: Add ENABLE(ORIENTATION_EVENTS)
https://bugs.webkit.org/show_bug.cgi?id=29508

Reviewed by Simon Fraser & Sam Weinig.

See documentation here:
http://developer.apple.com/safari/library/documentation/AppleApplications/Reference/SafariWebContent/HandlingEvents/HandlingEvents.html#//apple_ref/doc/uid/TP40006511-SW16

DerivedSources.make: Use new WebCore.OrientationEvents.exp file if ENABLE_ORIENTATION_EVENTS.

Add ENABLE_ORIENTATION_EVENTS to the new ADDITIONAL_IDL_DEFINES variable that is passed to the IDL
code generator. This is because ENABLE_ORIENTATION_EVENTS is not in FEATURE_DEFINES.

WebCore.OrientationEvents.exp: Added.
WebCore.xcodeproj/project.pbxproj: Add WebCore.OrientationEvents.exp.
dom/EventNames.h: Add onorientationchange.
html/HTMLAttributeNames.in: Ditto.
html/HTMLBodyElement.cpp: Handle onorientationchange properly.

(WebCore::HTMLBodyElement::parseMappedAttribute):
(WebCore::HTMLBodyElement::onorientationchange):
(WebCore::HTMLBodyElement::setOnorientationchange):

html/HTMLBodyElement.h: Ditto.
html/HTMLBodyElement.idl: Ditto.
html/HTMLFrameSetElement.cpp: Ditto.

(WebCore::HTMLFrameSetElement::parseMappedAttribute):
(WebCore::HTMLFrameSetElement::onorientationchange):
(WebCore::HTMLFrameSetElement::setOnorientationchange):

html/HTMLFrameSetElement.h: Ditto.
html/HTMLFrameSetElement.idl: Ditto.
page/DOMWindow.cpp: Ditto.

(WebCore::DOMWindow::orientation): Calls up the to the Frame for the orientation value.
(WebCore::DOMWindow::onorientationchange):
(WebCore::DOMWindow::setOnorientationchange):

page/DOMWindow.h: Handle onorientationchange properly.
page/DOMWindow.idl: Ditto.
page/Frame.cpp: Ditto.

(WebCore::Frame::Frame):
(WebCore::Frame::sendOrientationChangeEvent):

page/Frame.h: Ditto.

(WebCore::Frame::orientation):

3:59 PM Changeset in webkit [48608] by pfeldman@chromium.org

4 edits in trunk/WebCore

2009-09-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: completions are always evaluated against
window (discarding call frames).

https://bugs.webkit.org/show_bug.cgi?id=29616

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions):
inspector/front-end/InjectedScript.js: (InjectedScript.getCompletions):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.selectedCallFrameId):

3:40 PM Changeset in webkit [48607] by bfulgham@webkit.org

2 edits
3 adds in trunk/WebCore

Unreviewed build fix for Windows (Cairo) target.

Add stubs for SocketStream classes added in @r47788, which
broke the WinCairo build.

No new tests. (Build failure).

WebCore.vcproj/WebCore.vcproj: Add references to new files to Cairo build, exclude from standard Apple build.
platform/network/curl/SocketStreamError.h: Added.
platform/network/curl/SocketStreamHandle.h: Added.
platform/network/curl/SocketStreamHandleCurl.cpp: Added.

3:15 PM Changeset in webkit [48606] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-09-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Expose InspectorResource fields.

https://bugs.webkit.org/show_bug.cgi?id=29537

inspector/InspectorResource.cpp: (WebCore::InspectorResource::sourceString): (WebCore::InspectorResource::resourceData):
inspector/InspectorResource.h: (WebCore::InspectorResource::requestHeaderFields): (WebCore::InspectorResource::responseHeaderFields): (WebCore::InspectorResource::responseStatusCode): (WebCore::InspectorResource::requestMethod): (WebCore::InspectorResource::requestFormData):

2:50 PM Changeset in webkit [48605] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-09-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: JS error drilling down childless node.
No need to dispatch double click twice - it is already handled
in TreeElement.treeElementDoubleClicked.

https://bugs.webkit.org/show_bug.cgi?id=22144

inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline):

2:39 PM Changeset in webkit [48604] by kenneth@webkit.org

14 edits
1 add in trunk

WebCore: Implement new QWebPageClient class and let our classes
QWebViewPrivate and QWebGraphicsItemPrivate inherit from it.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-21
Reviewed by Simon Hausmann.

For Qt, platformPageClient() will now return a class derived from
the QWebPageClient, so the patch adapts our Qt hooks to go though
this class and not depend on the QWebView.

WebCore.pro:
platform/Widget.h:
platform/qt/PlatformScreenQt.cpp:

(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

platform/qt/PopupMenuQt.cpp:

(WebCore::PopupMenu::show):

platform/qt/QWebPageClient.h: Added.
platform/qt/WidgetQt.cpp:

(WebCore::Widget::setCursor):

plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::getValue):
(WebCore::PluginView::platformStart):

WebKit/qt: For Qt, platformPageClient() will now return a class derived from
the QWebPageClient, so the patch adapts our Qt hooks to go though
this class and not depend on the QWebView.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-21
Reviewed by Simon Hausmann.

Api/qwebgraphicsitem.cpp:

(QWebGraphicsItemPrivate::scroll):
(QWebGraphicsItemPrivate::update):
(QWebGraphicsItemPrivate::cursor):
(QWebGraphicsItemPrivate::updateCursor):
(QWebGraphicsItemPrivate::screenNumber):
(QWebGraphicsItemPrivate::winId):
(QWebGraphicsItem::event):
(QWebGraphicsItem::setPage):

Api/qwebgraphicsitem.h:
Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

Api/qwebpage_p.h:
Api/qwebview.cpp:

(QWebViewPrivate::scroll):
(QWebViewPrivate::update):
(QWebViewPrivate::cursor):
(QWebViewPrivate::updateCursor):
(QWebViewPrivate::screenNumber):
(QWebViewPrivate::winId):
(QWebView::setPage):
(QWebView::event):

WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::repaint):
(WebCore::ChromeClientQt::scroll):
(WebCore::ChromeClientQt::platformPageClient):

2:37 PM Changeset in webkit [48603] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-09-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Evaluating on call frame always returns "undefined".

https://bugs.webkit.org/show_bug.cgi?id=29613

inspector/front-end/InjectedScript.js: (InjectedScript.evaluate): (InjectedScript._evaluateAndWrap): (InjectedScript._evaluateOn): (InjectedScript.evaluateInCallFrame):

2:34 PM Changeset in webkit [48602] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-09-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Exception formatting is broken in console.

https://bugs.webkit.org/show_bug.cgi?id=29608

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleCommandResult):
inspector/front-end/InjectedScript.js: (InjectedScript.evaluate): (InjectedScript.createProxyObject):

2:32 PM Changeset in webkit [48601] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-09-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Console object formatting is broken.

https://bugs.webkit.org/show_bug.cgi?id=29607

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._format):
inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy.wrapPrimitiveValue):

2:29 PM Changeset in webkit [48600] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-09-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Crash When Logging an Element Before Opening Inspector

https://bugs.webkit.org/show_bug.cgi?id=29514

inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):

2:27 PM Changeset in webkit [48599] by Simon Fraser

6 edits
4 adds in trunk

2009-09-21 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Incorrect clipping with accelerated compositing content, and position:fixed
https://bugs.webkit.org/show_bug.cgi?id=29347

Fix the compositing clipping logic to behave correctly when position:fixed
elements clip, by using the new backgroundClipRect() method to determine
when we need to clip, and to compute the clipping layer position.

Test: compositing/overflow/fixed-position-ancestor-clip.html

rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::clippedByAncestor):

2:03 PM Changeset in webkit [48598] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-21 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Add back in a special case for window.top in the V8 bindings.

https://bugs.webkit.org/show_bug.cgi?id=29605

Fixes LayoutTests/fast/dom/Window/window-property-shadowing.html in the Chromium port.

bindings/scripts/CodeGeneratorV8.pm: Ensure window.top is not marked as read only, as this breaks the shadowing disabling.

1:54 PM Changeset in webkit [48597] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-09-21 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29609
Build fix for windows when using Qt 4.5.0.

Api/qwebpage.cpp: (QWebPage::userAgentForUrl):

1:53 PM Changeset in webkit [48596] by eric.carlson@apple.com

3 edits
2 adds in trunk

2009-09-21 Eric Carlson <eric.carlson@apple.com>

Reviewed by Brady Eidson.

HTMLMediaElement: media file should not reload when page comes out of page cache
https://bugs.webkit.org/show_bug.cgi?id=29604

Test: media/restore-from-page-cache.html

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::userCancelledLoad): Do nothing unless the element is still loading. Only fire an 'emptied' event if the readyState is HAVE_NOTHING, otherwise set the network state to NETWORK_IDLE.

2009-09-21 Eric Carlson <eric.carlson@apple.com>

Reviewed by Brady Eidson.

HTMLMediaElement: media file should not reload when page comes out of page cache
https://bugs.webkit.org/show_bug.cgi?id=29604

media/restore-from-page-cache-expected.txt: Added.
media/restore-from-page-cache.html: Added.

1:49 PM Changeset in webkit [48595] by weinig@apple.com

3 edits in trunk/WebCore

Clarify two FIXMEs.

Reviewed by Geoffrey "Sean/Shawn/Shaun" Garen.

bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):

bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::nameGetter):

1:47 PM Changeset in webkit [48594] by andersca@apple.com

5 edits
1 add in trunk/WebKit/win

<rdar://problem/7135588> HTMLMediaElement should ask WebPolicyLoadDelegate before loading resource

Reviewed by Adam Roben.

Implement WebFrameLoaderClient::shouldLoadMediaElementURL and have it call the new private policy
delegate method.

Interfaces/IWebPolicyDelegatePrivate.idl: Added.
Interfaces/WebKit.idl:
WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::shouldLoadMediaElementURL):

WebCoreSupport/WebFrameLoaderClient.h:
WebKit.vcproj/Interfaces.vcproj:

1:37 PM Changeset in webkit [48593] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-09-21 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Eric Seidel.

[Fix] SourceCode's uninitialized member

Potential source of crashes and bugs was fixed. Default constructor
didn't initialized m_provider member.

https://bugs.webkit.org/show_bug.cgi?id=29364

parser/SourceCode.h: (JSC::SourceCode::SourceCode):

12:07 PM Changeset in webkit [48592] by mitz@apple.com

2 edits in trunk/WebKit/mac

Attempt to fix the Tiger build

WebView/WebPDFDocumentExtras.mm:

(addWebPDFDocumentExtras):

12:01 PM Changeset in webkit [48591] by mitz@apple.com

2 edits in trunk/WebKit/mac

Attempt to fix the Tiger build

WebView/WebPDFDocumentExtras.mm:

(web_PDFDocumentAllScripts):
(addWebPDFDocumentExtras):

11:59 AM Changeset in webkit [48590] by oliver@apple.com

4 edits
3 adds in trunk

REGRESSION (r48582): Crash in StructureStubInfo::initPutByIdTransition when reloading trac.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=29599

Reviewed by Geoff Garen

It is unsafe to attempt to cache new property transitions on
dictionaries of any type.

11:54 AM Changeset in webkit [48589] by mitz@apple.com

3 edits in trunk/WebKit/mac

Attempt to fix the Tiger build

WebView/WebPDFDocumentExtras.mm:
WebView/WebPDFRepresentation.mm:

11:52 AM Changeset in webkit [48588] by beidson@apple.com

1 edit
2 adds in trunk/WebKitSite

Rubberstamped by Sam Weinig.

Add some example files for an upcoming blog post.

blog-files/load-unload-example.html: Added.
blog-files/pageshow-pagehide-example.html: Added.

11:47 AM Changeset in webkit [48587] by mitz@apple.com

2 edits in trunk/WebKit/mac

Attempt to fix the Leopard and Tiger builds

WebView/WebPDFDocumentExtras.mm:

11:01 AM Changeset in webkit [48586] by mitz@apple.com

4 edits
1 move
4 adds in trunk/WebKit

<rdar://problem/4137135> iFrame with PDF not being handled correctly on
usps.com
https://bugs.webkit.org/show_bug.cgi?id=4151

Reviewed by Anders Carlsson.

WebKit:

WebKit.xcodeproj/project.pbxproj: Added WebPDFDocumentExtras.{h,mm}

and WebJSPDFDoc.{h,mm} and changed WebPDFRepresentation to
Objective-C++.

WebKit/mac:

WebView/WebJSPDFDoc.h: Added.
WebView/WebJSPDFDoc.mm: Added.

(jsPDFDocInitialize): Retains the WebDataSource.
(jsPDFDocFinalize): Releases the WebDataSource.
(jsPDFDocPrint): Call the WebUIDelegate method -webView:printFrameView:
with the PDF document's view.
(makeJSPDFDoc): Makes and returns a JavaScript Doc instance that wraps
the WebDataSource.

WebView/WebPDFDocumentExtras.h: Added.
WebView/WebPDFDocumentExtras.mm: Added.

(appendValuesInPDFNameSubtreeToArray): Traverses a subtree of a PDF name
tree and adds all values in the subtree to an array.
(allValuesInPDFNameTree): Returns an array with all of the values in a
PDF name tree.
(web_PDFDocumentAllScripts): This is the implementation of -[PDFDocument
_web_allScripts]. It gets all values in the document-level "JavaScript"
name tree, which are action dictionaries, and returns an array of the
actions' scripts.
(addWebPDFDocumentExtras): Adds the -_web_allScripts method to
PDFDocument.

WebView/WebPDFRepresentation.h:
WebView/WebPDFRepresentation.m: Removed.
WebView/WebPDFRepresentation.mm: Copied from WebKit/mac/WebView/WebPDFRepresentation.m.

(+[WebPDFRepresentation initialize]): Added. Calls
addWebPDFDocumentExtras().
(-[WebPDFRepresentation finishedLoadingWithDataSource:]): Get the
scripts from the PDF document, create a JavaScript Doc object for the
document, and a JavaScript execution context, then execute every script
in the context, with the Doc object as "this".

9:06 AM Changeset in webkit [48585] by darin@chromium.org

2 edits in trunk/WebCore

2009-09-21 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

Drop down selects fail to close when a value is selected
https://bugs.webkit.org/show_bug.cgi?id=29582

Implement PopupListBox::hidePopup, which was previously
declared but unimplemented. Removes the declaration of
showPopup since that method is not implemented.

PopupListBox::hidePopup takes care of hiding the popup,
by invoking hidePopup on its parent PopupContainer, and
then informs the PopupMenuClient that popupDidHide.
This mimics the old behavior prior to r48370.

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::abandon): (WebCore::PopupListBox::acceptIndex): (WebCore::PopupListBox::hidePopup):

8:55 AM Changeset in webkit [48584] by zoltan@webkit.org

2 edits in trunk/SunSpider

2009-09-21 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Maciej Stachowiak.

[Qt] Make sunspider script work on Windows platform.
https://bugs.webkit.org/show_bug.cgi?id=29544

sunspider: Using platform specific null device instead of /dev/null.

8:49 AM Changeset in webkit [48583] by zoltan@webkit.org

2 edits in trunk/WebCore

2009-09-21 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Rubber-stamped by Simon Hausmann.

[Qt] Windows build fix.
https://bugs.webkit.org/show_bug.cgi?id=29535

platform/network/qt/DnsPrefetchHelper.cpp: Missing #include "config.h" added.

8:45 AM Changeset in webkit [48582] by oliver@apple.com

8 edits in trunk/JavaScriptCore

Re-land SNES fix, with correct assertion

RS=Maciej Stachowiak

8:38 AM Changeset in webkit [48581] by Adam Roben

1 edit in trunk/JavaScriptCore/ChangeLog

Fix JavaScriptCore/ChangeLog to match our preferred rollout procedure

7:45 AM Changeset in webkit [48580] by Adam Roben

8 edits in trunk/JavaScriptCore

Revert r48573, as it caused many assertion failures

6:08 AM Changeset in webkit [48579] by kov@webkit.org

1 copy in releases/WebKitGTK/webkit-1.1.15

Tagging 1.1.15.

5:57 AM Changeset in webkit [48578] by kov@webkit.org

4 edits in trunk

Unreviewed make dist build fix. Adding missing files.

5:17 AM Changeset in webkit [48577] by kov@webkit.org

3 edits in trunk/WebKit/gtk

2009-09-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Update documentation control files to 1.1.15.

docs/webkitgtk-docs.sgml:
docs/webkitgtk-sections.txt:

5:16 AM Changeset in webkit [48576] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed docs build fix. Current CFLAGS and LIBS variables no
longer bring gthread in.

docs/GNUmakefile.am:

4:56 AM Changeset in webkit [48575] by xan@webkit.org

4 edits in trunk

2009-09-21 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump version for 1.1.15 release.

configure.ac:

WebKit/gtk:

2009-09-21 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for release.

NEWS:

12:37 AM Changeset in webkit [48574] by barraclough@apple.com

3 edits in trunk/JavaScriptCore

Fix stack alignment with ARM THUMB2 JIT.
https://bugs.webkit.org/show_bug.cgi?id=29526

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-09-19
Reviewed by Sam 'Cabin Boy' Weinig.

Stack is currently being decremented by 0x3c, bump this to 0x40 to make this a
multiple of 16 bytes.

jit/JITStubs.cpp:

(JSC::JITThunks::JITThunks):

jit/JITStubs.h:

Sep 20, 2009:

10:42 PM Changeset in webkit [48573] by oliver@apple.com

8 edits in trunk/JavaScriptCore

SNES is too slow
https://bugs.webkit.org/show_bug.cgi?id=29534

Reviewed by Maciej Stachowiak.

The problem was that the emulator used multiple classes with
more properties than our dictionary cutoff allowed, this resulted
in more or less all critical logic inside the emulator requiring
uncached property access.

Rather than simply bumping the dictionary cutoff, this patch
recognises that there are two ways to create a "dictionary"
structure. Either by adding a large number of properties, or
by removing a property. In the case of adding properties we
know all the existing properties will maintain their existing
offsets, so we could cache access to those properties, if we
know they won't be removed.

To make this possible, this patch adds the logic required to
distinguish a dictionary created by addition from one created
by removal. With this logic in place we can now cache access
to objects with large numbers of properties.

SNES performance improved by more than 6x.

7:30 PM Changeset in webkit [48572] by abarth@webkit.org

3 edits
18 adds in trunk

2009-09-20 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Crash when clicking link in unload handler
https://bugs.webkit.org/show_bug.cgi?id=29525

Test that the first navigation always wins when the page tries to start
a new navigation in an unload handler.

fast/loader/resources/fail-and-notify-done.html: Added.
fast/loader/resources/pass-and-notify-done.html: Added.
fast/loader/unload-form-about-blank-expected.txt: Added.
fast/loader/unload-form-about-blank.html: Added.
fast/loader/unload-form-expected.txt: Added.
fast/loader/unload-form-post-about-blank-expected.txt: Added.
fast/loader/unload-form-post-about-blank.html: Added.
fast/loader/unload-form-post-expected.txt: Added.
fast/loader/unload-form-post.html: Added.
fast/loader/unload-form.html: Added.
fast/loader/unload-hyperlink-expected.txt: Added.
fast/loader/unload-hyperlink.html: Added.
fast/loader/unload-javascript-url-expected.txt: Added.
fast/loader/unload-javascript-url.html: Added.
fast/loader/unload-reload-expected.txt: Added.
fast/loader/unload-reload.html: Added.
fast/loader/unload-window-location-expected.txt: Added.
fast/loader/unload-window-location.html: Added.

2009-09-20 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Crash when clicking link in unload handler
https://bugs.webkit.org/show_bug.cgi?id=29525

Test that the first navigation always wins when the page tries to start
a new navigation in an unload handler.

Tests: fast/loader/unload-form-about-blank.html

fast/loader/unload-form-post-about-blank.html
fast/loader/unload-form-post.html
fast/loader/unload-form.html
fast/loader/unload-hyperlink.html
fast/loader/unload-javascript-url.html
fast/loader/unload-reload.html
fast/loader/unload-window-location.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithDocumentLoader):

6:23 PM Changeset in webkit [48571] by kov@webkit.org

2 edits in trunk/WebCore

2009-09-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Sometimes crashes when a page is destroyed/loads another URL while playing video
https://bugs.webkit.org/show_bug.cgi?id=29496

Protect the video sink object, and destroy it in an idle callback
to hopefully avoid a race condition that leads to a crash.

This is already tested by media/video-seekable.html

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::idleUnref): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createGSTPlayBin):

10:45 AM Changeset in webkit [48570] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Small documentation fix.

webkit/webkithittestresult.cpp:

8:34 AM Changeset in webkit [48569] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module

Reviewed by Mark Rowe.

The require statement is like the use statement, except that it
is run during script execution instead of during the 'BEGIN'
phase. This makes it possible to change @INC before the require
statement is run. See 'require' and 'use' in the perlfunc(1)
manpage and 'BEGIN' in perlmod(1) manpage.

Scripts/run-webkit-tests: Replace eval statement with require

statement.

Sep 19, 2009:

6:13 PM Changeset in webkit [48568] by oliver@apple.com

4 edits
3 adds in trunk

Implement ES5 Object.create function
https://bugs.webkit.org/show_bug.cgi?id=29524

Reviewed by Maciej Stachowiak

Implement Object.create. Very simple patch, effectively Object.defineProperties
only creating the target object itself.

5:36 PM Changeset in webkit [48567] by kov@webkit.org

3 edits in trunk/WebCore

GTK+ build fix, Qt blind build fix

3:37 PM Changeset in webkit [48566] by weinig@apple.com

10 edits
2 deletes in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29519
Remove JSNameNodeCollection and just use StaticNodeList

Reviewed by Oliver Hunt.

WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):

bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::nameGetter):

bindings/js/JSNamedNodesCollection.cpp: Removed.
bindings/js/JSNamedNodesCollection.h: Removed.

LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=29519
Remove JSNameNodeCollection and just use StaticNodeList

Reviewed by Oliver Hunt.

fast/dom/HTMLSelectElement/named-options-expected.txt:
fast/dom/HTMLSelectElement/script-tests/named-options.js:
fast/dom/prototype-inheritance-2-expected.txt:

3:14 PM Changeset in webkit [48565] by oliver@apple.com

4 edits
3 adds in trunk

Implement ES5 Object.defineProperties function
https://bugs.webkit.org/show_bug.cgi?id=29522

Reviewed by Sam Weinig

Implement Object.defineProperties. Fairly simple patch, simply makes use of
existing functionality used for defineProperty.

1:29 PM Changeset in webkit [48564] by dbates@webkit.org

3 edits
8 adds in trunk

2009-09-19 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=29511

Fixes an issue where script code that contains non-ASCII characters may bypass the
XSSAuditor.

Before performing a comparison between the script source code and input parameters, we
remove all non-ASCII characters, including non-printable ASCII characters from the
script source code and input parameters.

Tests: http/tests/security/xssAuditor/img-onerror-non-ASCII-char.html

http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding.html
http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding.html
http/tests/security/xssAuditor/img-onerror-non-ASCII-char2.html

page/XSSAuditor.cpp: (WebCore::isNonCanonicalCharacter): Modified to remove all non-ASCII characters, including non-printable ASCII characters.

2009-09-19 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=29511

Tests that scripts that contain non-ASCII characters do not bypass the XSSAuditor.

http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt: Added.
http/tests/security/xssAuditor/img-onerror-non-ASCII-char.html: Added.
http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected: Added.
http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding.html: Added.
http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt: Added.
http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding.html: Added.
http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt: Added.
http/tests/security/xssAuditor/img-onerror-non-ASCII-char2.html: Added.

12:51 PM Changeset in webkit [48563] by mitz@apple.com

2 edits in trunk/JavaScriptCore

Fix clean debug builds.

11:46 AM Changeset in webkit [48562] by Simon Fraser

3 edits
5 adds in trunk

2009-09-19 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Incorrect animation with scale(0) transform (singular matrix)
https://bugs.webkit.org/show_bug.cgi?id=29465

Make accelerated scale() and translate() animations go through the component animation
path (rather than just matrix animation) to avoid problems with singular scale matrices,
and be slightly more efficient.

Test: compositing/transitions/singular-scale-transition.html

platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::getTransformFunctionValue): (WebCore::getValueFunctionNameForTransformOperation):

11:22 AM Changeset in webkit [48561] by eric@webkit.org

2 edits
1 add in trunk/WebKit/qt

2009-09-19 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29345
The tests of QWebFrame did not use QTRY_VERIFY for
tests involving the event loop.

tests/qwebframe/tst_qwebframe.cpp:
tests/util.h: Added. Copy of tests/shared/util.h of Qt

11:15 AM Changeset in webkit [48560] by eric@webkit.org

2 edits
3 adds in trunk/WebKit/qt

2009-09-19 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Add an autotest stub for QWebGraphicsItem.

It just calls all the functions and makes sure they don't crash.

tests/qwebgraphicsitem/qwebgraphicsitem.pro: Added.
tests/qwebgraphicsitem/tst_qwebgraphicsitem.cpp: Added. (tst_QWebGraphicsItem::qwebgraphicsitem):
tests/tests.pro:

11:02 AM Changeset in webkit [48559] by eric@webkit.org

9 edits
19 adds in trunk

2009-09-19 Alex Milowski <alex@milowski.com>

Reviewed by Maciej Stachowiak.

Basic tests for msub, msup, and mtable/mtr/mtd

mathml: Added.
mathml/presentation: Added.
mathml/presentation/sub.xhtml: Added.
mathml/presentation/sup.xhtml: Added.
mathml/presentation/tables.xhtml: Added.
platform/mac/mathml: Added.
platform/mac/mathml/presentation: Added.
platform/mac/mathml/presentation/sub-expected.txt: Added.
platform/mac/mathml/presentation/sup-expected.txt: Added.
platform/mac/mathml/presentation/tables-expected.txt: Added.

2009-09-19 Alex Milowski <alex@milowski.com>

Reviewed by Maciej Stachowiak.

Adds CSS styling and basic DOM element support for MathML

DerivedSources.make: Added user stylesheet and tag factory generation

WebCore.xcodeproj/project.pbxproj: Added new DOM element code

css/CSSParser.cpp: (WebCore::CSSParser::parseAttr): Added check for document since stylesheet can be added before there is a document

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement): Added check to add MathML user agent stylesheet

css/mathml.css: Added. MathML user agent stylesheet

dom/Document.cpp: (WebCore::Document::createElement): Added support for creation of MathML DOM objects

dom/Node.h: (WebCore::Node::isMathMLElement): Added check method for whether the node is a MathML node

mathml: Added.
mathml/MathMLElement.cpp: Added. (WebCore::MathMLElement::MathMLElement): (WebCore::MathMLElement::create): (WebCore::MathMLElement::createRenderer):
mathml/MathMLElement.h: Added. (WebCore::MathMLElement::isMathMLElement): MathML DOM base class

mathml/MathMLInlineContainerElement.cpp: Added. (WebCore::MathMLInlineContainerElement::MathMLInlineContainerElement): (WebCore::MathMLInlineContainerElement::create): (WebCore::MathMLInlineContainerElement::createRenderer):
mathml/MathMLInlineContainerElement.h: Added. Base class for non-text containers

mathml/MathMLMathElement.cpp: Added. (WebCore::MathMLMathElement::MathMLMathElement): (WebCore::MathMLMathElement::create):
mathml/MathMLMathElement.h: Added. Root Math element

mathml/mathtags.in: Added. Element list mappings

page/Frame.cpp: (WebCore::Frame::Frame):

10:41 AM Changeset in webkit [48558] by Simon Hausmann

3 edits in trunk/JavaScriptCore

QtWebKit Windows CE compile fix

Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-19
Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=29379

There is no _aligned_alloc or _aligned_free on Windows CE.
We just use the Windows code that was there before and use VirtualAlloc.
But that also means that the BLOCK_SIZE must be 64K as this function
allocates on 64K boundaries.

runtime/Collector.cpp:

(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):

runtime/Collector.h:

10:28 AM Changeset in webkit [48557] by oliver@apple.com

3 edits in trunk/JavaScriptCore

Windows build fix part2

10:17 AM Changeset in webkit [48556] by abarth@webkit.org

5 edits
6 adds in trunk

2009-09-19 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

Canvas drawn with data URL image raises SECURITY_ERR when toDataUrl() called.
https://bugs.webkit.org/show_bug.cgi?id=29305

Test that drawing a data URL image onto a canvas behaves as expected.
Note the tricky case involving a data URL SVG image with an embedded
remote image.

Also, test that document.domain state doesn't affect canvas taint
state.

http/tests/security/canvas-remote-read-data-url-image-expected.txt: Added.
http/tests/security/canvas-remote-read-data-url-image.html: Added.
http/tests/security/canvas-remote-read-data-url-svg-image-expected.txt: Added.
http/tests/security/canvas-remote-read-data-url-svg-image.html: Added.
http/tests/security/canvas-remote-read-remote-image-document-domain-expected.txt: Added.
http/tests/security/canvas-remote-read-remote-image-document-domain.html: Added.

2009-09-19 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

Canvas drawn with data URL image raises SECURITY_ERR when toDataUrl() called.
https://bugs.webkit.org/show_bug.cgi?id=29305

We need to special-case data URLs when tainting a canvas because we
treat data URLs has having no security origin, unlike other
browsers. The reason we do this is to help sites avoid XSS via data
URLs, but that consideration doesn't apply to canvas taint.

Also, we were previously incorrectly taking document.domain state
into account when tainting canvas.

Tests: http/tests/security/canvas-remote-read-data-url-image.html

http/tests/security/canvas-remote-read-data-url-svg-image.html
http/tests/security/canvas-remote-read-remote-image-document-domain.html

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::checkOrigin): (WebCore::CanvasRenderingContext2D::createPattern):
page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::taintsCanvas):
page/SecurityOrigin.h:

10:09 AM Changeset in webkit [48555] by oliver@apple.com

3 edits in trunk/JavaScriptCore

Windows build fix part 1

2:46 AM Changeset in webkit [48554] by hamaji@chromium.org

139 edits
142 moves
4 adds in trunk/LayoutTests

2009-09-19 Shinichiro Hamaji <hamaji@chromium.org>

Rubber-stamped by Eric Seidel.

js tests should move into jstests subdirectory instead of resources/
https://bugs.webkit.org/show_bug.cgi?id=25880

Migration for svg directory.

svg/custom/SVGException.html:
svg/custom/getSubStringLength.html:
svg/custom/immutable-properties.html:
svg/custom/resources/SVGException.js: Removed.
svg/custom/resources/TEMPLATE.html: Removed.
svg/custom/resources/getSubStringLength.js: Removed.
svg/custom/resources/immutable-properties.js: Removed.
svg/custom/resources/selectSubString.js: Removed.
svg/custom/resources/svg-fonts-in-text-controls.js: Removed.
svg/custom/resources/svg-modify-currentTranslate.js: Removed.
svg/custom/resources/svg-xml-dom-sync.js: Removed.
svg/custom/resources/tearoffs-with-tearoffs.js: Removed.
svg/custom/script-tests: Added.
svg/custom/script-tests/SVGException.js: Copied from LayoutTests/svg/custom/resources/SVGException.js.
svg/custom/script-tests/TEMPLATE.html: Copied from LayoutTests/svg/custom/resources/TEMPLATE.html.
svg/custom/script-tests/getSubStringLength.js: Copied from LayoutTests/svg/custom/resources/getSubStringLength.js.
svg/custom/script-tests/immutable-properties.js: Copied from LayoutTests/svg/custom/resources/immutable-properties.js.
svg/custom/script-tests/selectSubString.js: Copied from LayoutTests/svg/custom/resources/selectSubString.js.
svg/custom/script-tests/svg-fonts-in-text-controls.js: Copied from LayoutTests/svg/custom/resources/svg-fonts-in-text-controls.js.
svg/custom/script-tests/svg-modify-currentTranslate.js: Copied from LayoutTests/svg/custom/resources/svg-modify-currentTranslate.js.
svg/custom/script-tests/svg-xml-dom-sync.js: Copied from LayoutTests/svg/custom/resources/svg-xml-dom-sync.js.
svg/custom/script-tests/tearoffs-with-tearoffs.js: Copied from LayoutTests/svg/custom/resources/tearoffs-with-tearoffs.js.
svg/custom/selectSubString.html:
svg/custom/svg-fonts-in-text-controls.html:
svg/custom/svg-modify-currentTranslate.html:
svg/custom/svg-xml-dom-sync.html:
svg/custom/tearoffs-with-tearoffs.html:
svg/dom/SVGStyleElement/resources/TEMPLATE.html: Removed.
svg/dom/SVGStyleElement/resources/style-langspace.js: Removed.
svg/dom/SVGStyleElement/script-tests: Added.
svg/dom/SVGStyleElement/script-tests/TEMPLATE.html: Copied from LayoutTests/svg/dom/SVGStyleElement/resources/TEMPLATE.html.
svg/dom/SVGStyleElement/script-tests/style-langspace.js: Copied from LayoutTests/svg/dom/SVGStyleElement/resources/style-langspace.js.
svg/dom/SVGStyleElement/style-langspace.html:
svg/dom/path-parser.html:
svg/dom/path-segments.html:
svg/dom/resources/TEMPLATE.html: Removed.
svg/dom/resources/path-parser.js: Removed.
svg/dom/resources/path-segments.js: Removed.
svg/dom/resources/style-reflect.js: Removed.
svg/dom/resources/text-rotate-live.js: Removed.
svg/dom/script-tests: Added.
svg/dom/script-tests/TEMPLATE.html: Copied from LayoutTests/svg/dom/resources/TEMPLATE.html.
svg/dom/script-tests/path-parser.js: Copied from LayoutTests/svg/dom/resources/path-parser.js.
svg/dom/script-tests/path-segments.js: Copied from LayoutTests/svg/dom/resources/path-segments.js.
svg/dom/script-tests/style-reflect.js: Copied from LayoutTests/svg/dom/resources/style-reflect.js.
svg/dom/script-tests/text-rotate-live.js: Copied from LayoutTests/svg/dom/resources/text-rotate-live.js.
svg/dom/style-reflect.html:
svg/dom/text-rotate-live.html:
svg/dynamic-updates/SVGAElement-dom-href-attr.html:
svg/dynamic-updates/SVGAElement-dom-target-attr.html:
svg/dynamic-updates/SVGAElement-svgdom-href-prop.html:
svg/dynamic-updates/SVGAElement-svgdom-target-prop.html:
svg/dynamic-updates/SVGCircleElement-dom-cx-attr.html:
svg/dynamic-updates/SVGCircleElement-dom-cy-attr.html:
svg/dynamic-updates/SVGCircleElement-dom-r-attr.html:
svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop.html:
svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop.html:
svg/dynamic-updates/SVGCircleElement-svgdom-r-prop.html:
svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html:
svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop.html:
svg/dynamic-updates/SVGCursorElement-dom-x-attr.html:
svg/dynamic-updates/SVGCursorElement-dom-y-attr.html:
svg/dynamic-updates/SVGCursorElement-svgdom-x-prop.html:
svg/dynamic-updates/SVGCursorElement-svgdom-y-prop.html:
svg/dynamic-updates/SVGEllipseElement-dom-cx-attr.html:
svg/dynamic-updates/SVGEllipseElement-dom-cy-attr.html:
svg/dynamic-updates/SVGEllipseElement-dom-rx-attr.html:
svg/dynamic-updates/SVGEllipseElement-dom-ry-attr.html:
svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop.html:
svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop.html:
svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop.html:
svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop.html:
svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr.html:
svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr.html:
svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr.html:
svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr.html:
svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop.html:
svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop.html:
svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop.html:
svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop.html:
svg/dynamic-updates/SVGImageElement-dom-height-attr.html:
svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr.html:
svg/dynamic-updates/SVGImageElement-dom-width-attr.html:
svg/dynamic-updates/SVGImageElement-dom-x-attr.html:
svg/dynamic-updates/SVGImageElement-dom-y-attr.html:
svg/dynamic-updates/SVGImageElement-svgdom-height-prop.html:
svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop.html:
svg/dynamic-updates/SVGImageElement-svgdom-width-prop.html:
svg/dynamic-updates/SVGImageElement-svgdom-x-prop.html:
svg/dynamic-updates/SVGImageElement-svgdom-y-prop.html:
svg/dynamic-updates/SVGLineElement-dom-x1-attr.html:
svg/dynamic-updates/SVGLineElement-dom-x2-attr.html:
svg/dynamic-updates/SVGLineElement-dom-y1-attr.html:
svg/dynamic-updates/SVGLineElement-dom-y2-attr.html:
svg/dynamic-updates/SVGLineElement-svgdom-x1-prop.html:
svg/dynamic-updates/SVGLineElement-svgdom-x2-prop.html:
svg/dynamic-updates/SVGLineElement-svgdom-y1-prop.html:
svg/dynamic-updates/SVGLineElement-svgdom-y2-prop.html:
svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr.html:
svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr.html:
svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr.html:
svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr.html:
svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr.html:
svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr.html:
svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop.html:
svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop.html:
svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop.html:
svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop.html:
svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop.html:
svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop.html:
svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html:
svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr.html:
svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr.html:
svg/dynamic-updates/SVGMarkerElement-dom-orient-attr.html:
svg/dynamic-updates/SVGMarkerElement-dom-refX-attr.html:
svg/dynamic-updates/SVGMarkerElement-dom-refY-attr.html:
svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop.html:
svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop.html:
svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop.html:
svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop.html:
svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop.html:
svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop.html:
svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop.html:
svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call.html:
svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call.html:
svg/dynamic-updates/SVGMaskElement-dom-height-attr.html:
svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr.html:
svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr.html:
svg/dynamic-updates/SVGMaskElement-dom-width-attr.html:
svg/dynamic-updates/SVGMaskElement-dom-x-attr.html:
svg/dynamic-updates/SVGMaskElement-dom-y-attr.html:
svg/dynamic-updates/SVGMaskElement-svgdom-height-prop.html:
svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop.html:
svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop.html:
svg/dynamic-updates/SVGMaskElement-svgdom-width-prop.html:
svg/dynamic-updates/SVGMaskElement-svgdom-x-prop.html:
svg/dynamic-updates/SVGMaskElement-svgdom-y-prop.html:
svg/dynamic-updates/SVGPatternElement-dom-height-attr.html:
svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr.html:
svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr.html:
svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr.html:
svg/dynamic-updates/SVGPatternElement-dom-width-attr.html:
svg/dynamic-updates/SVGPatternElement-dom-x-attr.html:
svg/dynamic-updates/SVGPatternElement-dom-y-attr.html:
svg/dynamic-updates/SVGPatternElement-svgdom-height-prop.html:
svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop.html:
svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop.html:
svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop.html:
svg/dynamic-updates/SVGPatternElement-svgdom-width-prop.html:
svg/dynamic-updates/SVGPatternElement-svgdom-x-prop.html:
svg/dynamic-updates/SVGPatternElement-svgdom-y-prop.html:
svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr.html:
svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr.html:
svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr.html:
svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr.html:
svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr.html:
svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr.html:
svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr.html:
svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop.html:
svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop.html:
svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop.html:
svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop.html:
svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop.html:
svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop.html:
svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop.html:
svg/dynamic-updates/SVGRectElement-dom-height-attr.html:
svg/dynamic-updates/SVGRectElement-dom-width-attr.html:
svg/dynamic-updates/SVGRectElement-dom-x-attr.html:
svg/dynamic-updates/SVGRectElement-dom-y-attr.html:
svg/dynamic-updates/SVGRectElement-svgdom-height-prop.html:
svg/dynamic-updates/SVGRectElement-svgdom-width-prop.html:
svg/dynamic-updates/SVGRectElement-svgdom-x-prop.html:
svg/dynamic-updates/SVGRectElement-svgdom-y-prop.html:
svg/dynamic-updates/resources/SVGAElement-dom-href-attr.js: Removed.
svg/dynamic-updates/resources/SVGAElement-dom-target-attr.js: Removed.
svg/dynamic-updates/resources/SVGAElement-svgdom-href-prop.js: Removed.
svg/dynamic-updates/resources/SVGAElement-svgdom-target-prop.js: Removed.
svg/dynamic-updates/resources/SVGCircleElement-dom-cx-attr.js: Removed.
svg/dynamic-updates/resources/SVGCircleElement-dom-cy-attr.js: Removed.
svg/dynamic-updates/resources/SVGCircleElement-dom-r-attr.js: Removed.
svg/dynamic-updates/resources/SVGCircleElement-svgdom-cx-prop.js: Removed.
svg/dynamic-updates/resources/SVGCircleElement-svgdom-cy-prop.js: Removed.
svg/dynamic-updates/resources/SVGCircleElement-svgdom-r-prop.js: Removed.
svg/dynamic-updates/resources/SVGClipPathElement-dom-clipPathUnits-attr.js: Removed.
svg/dynamic-updates/resources/SVGClipPathElement-svgdom-clipPathUnits-prop.js: Removed.
svg/dynamic-updates/resources/SVGCursorElement-dom-x-attr.js: Removed.
svg/dynamic-updates/resources/SVGCursorElement-dom-y-attr.js: Removed.
svg/dynamic-updates/resources/SVGCursorElement-svgdom-x-prop.js: Removed.
svg/dynamic-updates/resources/SVGCursorElement-svgdom-y-prop.js: Removed.
svg/dynamic-updates/resources/SVGEllipseElement-dom-cx-attr.js: Removed.
svg/dynamic-updates/resources/SVGEllipseElement-dom-cy-attr.js: Removed.
svg/dynamic-updates/resources/SVGEllipseElement-dom-rx-attr.js: Removed.
svg/dynamic-updates/resources/SVGEllipseElement-dom-ry-attr.js: Removed.
svg/dynamic-updates/resources/SVGEllipseElement-svgdom-cx-prop.js: Removed.
svg/dynamic-updates/resources/SVGEllipseElement-svgdom-cy-prop.js: Removed.
svg/dynamic-updates/resources/SVGEllipseElement-svgdom-rx-prop.js: Removed.
svg/dynamic-updates/resources/SVGEllipseElement-svgdom-ry-prop.js: Removed.
svg/dynamic-updates/resources/SVGForeignObjectElement-dom-height-attr.js: Removed.
svg/dynamic-updates/resources/SVGForeignObjectElement-dom-width-attr.js: Removed.
svg/dynamic-updates/resources/SVGForeignObjectElement-dom-x-attr.js: Removed.
svg/dynamic-updates/resources/SVGForeignObjectElement-dom-y-attr.js: Removed.
svg/dynamic-updates/resources/SVGForeignObjectElement-svgdom-height-prop.js: Removed.
svg/dynamic-updates/resources/SVGForeignObjectElement-svgdom-width-prop.js: Removed.
svg/dynamic-updates/resources/SVGForeignObjectElement-svgdom-x-prop.js: Removed.
svg/dynamic-updates/resources/SVGForeignObjectElement-svgdom-y-prop.js: Removed.
svg/dynamic-updates/resources/SVGImageElement-dom-height-attr.js: Removed.
svg/dynamic-updates/resources/SVGImageElement-dom-preserveAspectRatio-attr.js: Removed.
svg/dynamic-updates/resources/SVGImageElement-dom-width-attr.js: Removed.
svg/dynamic-updates/resources/SVGImageElement-dom-x-attr.js: Removed.
svg/dynamic-updates/resources/SVGImageElement-dom-y-attr.js: Removed.
svg/dynamic-updates/resources/SVGImageElement-svgdom-height-prop.js: Removed.
svg/dynamic-updates/resources/SVGImageElement-svgdom-preserveAspectRatio-prop.js: Removed.
svg/dynamic-updates/resources/SVGImageElement-svgdom-width-prop.js: Removed.
svg/dynamic-updates/resources/SVGImageElement-svgdom-x-prop.js: Removed.
svg/dynamic-updates/resources/SVGImageElement-svgdom-y-prop.js: Removed.
svg/dynamic-updates/resources/SVGLineElement-dom-x1-attr.js: Removed.
svg/dynamic-updates/resources/SVGLineElement-dom-x2-attr.js: Removed.
svg/dynamic-updates/resources/SVGLineElement-dom-y1-attr.js: Removed.
svg/dynamic-updates/resources/SVGLineElement-dom-y2-attr.js: Removed.
svg/dynamic-updates/resources/SVGLineElement-svgdom-x1-prop.js: Removed.
svg/dynamic-updates/resources/SVGLineElement-svgdom-x2-prop.js: Removed.
svg/dynamic-updates/resources/SVGLineElement-svgdom-y1-prop.js: Removed.
svg/dynamic-updates/resources/SVGLineElement-svgdom-y2-prop.js: Removed.
svg/dynamic-updates/resources/SVGLinearGradientElement-dom-gradientTransform-attr.js: Removed.
svg/dynamic-updates/resources/SVGLinearGradientElement-dom-gradientUnits-attr.js: Removed.
svg/dynamic-updates/resources/SVGLinearGradientElement-dom-x1-attr.js: Removed.
svg/dynamic-updates/resources/SVGLinearGradientElement-dom-x2-attr.js: Removed.
svg/dynamic-updates/resources/SVGLinearGradientElement-dom-y1-attr.js: Removed.
svg/dynamic-updates/resources/SVGLinearGradientElement-dom-y2-attr.js: Removed.
svg/dynamic-updates/resources/SVGLinearGradientElement-svgdom-gradientTransform-prop.js: Removed.
svg/dynamic-updates/resources/SVGLinearGradientElement-svgdom-gradientUnits-prop.js: Removed.
svg/dynamic-updates/resources/SVGLinearGradientElement-svgdom-x1-prop.js: Removed.
svg/dynamic-updates/resources/SVGLinearGradientElement-svgdom-x2-prop.js: Removed.
svg/dynamic-updates/resources/SVGLinearGradientElement-svgdom-y1-prop.js: Removed.
svg/dynamic-updates/resources/SVGLinearGradientElement-svgdom-y2-prop.js: Removed.
svg/dynamic-updates/resources/SVGMarkerElement-dom-markerHeight-attr.js: Removed.
svg/dynamic-updates/resources/SVGMarkerElement-dom-markerUnits-attr.js: Removed.
svg/dynamic-updates/resources/SVGMarkerElement-dom-markerWidth-attr.js: Removed.
svg/dynamic-updates/resources/SVGMarkerElement-dom-orient-attr.js: Removed.
svg/dynamic-updates/resources/SVGMarkerElement-dom-refX-attr.js: Removed.
svg/dynamic-updates/resources/SVGMarkerElement-dom-refY-attr.js: Removed.
svg/dynamic-updates/resources/SVGMarkerElement-svgdom-markerHeight-prop.js: Removed.
svg/dynamic-updates/resources/SVGMarkerElement-svgdom-markerUnits-prop.js: Removed.
svg/dynamic-updates/resources/SVGMarkerElement-svgdom-markerWidth-prop.js: Removed.
svg/dynamic-updates/resources/SVGMarkerElement-svgdom-orientAngle-prop.js: Removed.
svg/dynamic-updates/resources/SVGMarkerElement-svgdom-orientType-prop.js: Removed.
svg/dynamic-updates/resources/SVGMarkerElement-svgdom-refX-prop.js: Removed.
svg/dynamic-updates/resources/SVGMarkerElement-svgdom-refY-prop.js: Removed.
svg/dynamic-updates/resources/SVGMarkerElement-svgdom-setOrientToAngle-call.js: Removed.
svg/dynamic-updates/resources/SVGMarkerElement-svgdom-setOrientToAuto-call.js: Removed.
svg/dynamic-updates/resources/SVGMaskElement-dom-height-attr.js: Removed.
svg/dynamic-updates/resources/SVGMaskElement-dom-maskContentUnits-attr.js: Removed.
svg/dynamic-updates/resources/SVGMaskElement-dom-maskUnits-attr.js: Removed.
svg/dynamic-updates/resources/SVGMaskElement-dom-width-attr.js: Removed.
svg/dynamic-updates/resources/SVGMaskElement-dom-x-attr.js: Removed.
svg/dynamic-updates/resources/SVGMaskElement-dom-y-attr.js: Removed.
svg/dynamic-updates/resources/SVGMaskElement-svgdom-height-prop.js: Removed.
svg/dynamic-updates/resources/SVGMaskElement-svgdom-maskContentUnits-prop.js: Removed.
svg/dynamic-updates/resources/SVGMaskElement-svgdom-maskUnits-prop.js: Removed.
svg/dynamic-updates/resources/SVGMaskElement-svgdom-width-prop.js: Removed.
svg/dynamic-updates/resources/SVGMaskElement-svgdom-x-prop.js: Removed.
svg/dynamic-updates/resources/SVGMaskElement-svgdom-y-prop.js: Removed.
svg/dynamic-updates/resources/SVGPatternElement-dom-height-attr.js: Removed.
svg/dynamic-updates/resources/SVGPatternElement-dom-patternContentUnits-attr.js: Removed.
svg/dynamic-updates/resources/SVGPatternElement-dom-patternTransform-attr.js: Removed.
svg/dynamic-updates/resources/SVGPatternElement-dom-patternUnits-attr.js: Removed.
svg/dynamic-updates/resources/SVGPatternElement-dom-width-attr.js: Removed.
svg/dynamic-updates/resources/SVGPatternElement-dom-x-attr.js: Removed.
svg/dynamic-updates/resources/SVGPatternElement-dom-y-attr.js: Removed.
svg/dynamic-updates/resources/SVGPatternElement-svgdom-height-prop.js: Removed.
svg/dynamic-updates/resources/SVGPatternElement-svgdom-patternContentUnits-prop.js: Removed.
svg/dynamic-updates/resources/SVGPatternElement-svgdom-patternTransform-prop.js: Removed.
svg/dynamic-updates/resources/SVGPatternElement-svgdom-patternUnits-prop.js: Removed.
svg/dynamic-updates/resources/SVGPatternElement-svgdom-width-prop.js: Removed.
svg/dynamic-updates/resources/SVGPatternElement-svgdom-x-prop.js: Removed.
svg/dynamic-updates/resources/SVGPatternElement-svgdom-y-prop.js: Removed.
svg/dynamic-updates/resources/SVGRadialGradientElement-dom-cx-attr.js: Removed.
svg/dynamic-updates/resources/SVGRadialGradientElement-dom-cy-attr.js: Removed.
svg/dynamic-updates/resources/SVGRadialGradientElement-dom-fx-attr.js: Removed.
svg/dynamic-updates/resources/SVGRadialGradientElement-dom-fy-attr.js: Removed.
svg/dynamic-updates/resources/SVGRadialGradientElement-dom-gradientTransform-attr.js: Removed.
svg/dynamic-updates/resources/SVGRadialGradientElement-dom-gradientUnits-attr.js: Removed.
svg/dynamic-updates/resources/SVGRadialGradientElement-dom-r-attr.js: Removed.
svg/dynamic-updates/resources/SVGRadialGradientElement-svgdom-cx-prop.js: Removed.
svg/dynamic-updates/resources/SVGRadialGradientElement-svgdom-cy-prop.js: Removed.
svg/dynamic-updates/resources/SVGRadialGradientElement-svgdom-fx-prop.js: Removed.
svg/dynamic-updates/resources/SVGRadialGradientElement-svgdom-fy-prop.js: Removed.
svg/dynamic-updates/resources/SVGRadialGradientElement-svgdom-gradientTransform-prop.js: Removed.
svg/dynamic-updates/resources/SVGRadialGradientElement-svgdom-gradientUnits-prop.js: Removed.
svg/dynamic-updates/resources/SVGRadialGradientElement-svgdom-r-prop.js: Removed.
svg/dynamic-updates/resources/SVGRectElement-dom-height-attr.js: Removed.
svg/dynamic-updates/resources/SVGRectElement-dom-width-attr.js: Removed.
svg/dynamic-updates/resources/SVGRectElement-dom-x-attr.js: Removed.
svg/dynamic-updates/resources/SVGRectElement-dom-y-attr.js: Removed.
svg/dynamic-updates/resources/SVGRectElement-svgdom-height-prop.js: Removed.
svg/dynamic-updates/resources/SVGRectElement-svgdom-width-prop.js: Removed.
svg/dynamic-updates/resources/SVGRectElement-svgdom-x-prop.js: Removed.
svg/dynamic-updates/resources/SVGRectElement-svgdom-y-prop.js: Removed.
svg/dynamic-updates/resources/TEMPLATE.html: Removed.
svg/dynamic-updates/script-tests: Added.
svg/dynamic-updates/script-tests/SVGAElement-dom-href-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGAElement-dom-href-attr.js.
svg/dynamic-updates/script-tests/SVGAElement-dom-target-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGAElement-dom-target-attr.js.
svg/dynamic-updates/script-tests/SVGAElement-svgdom-href-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGAElement-svgdom-href-prop.js.
svg/dynamic-updates/script-tests/SVGAElement-svgdom-target-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGAElement-svgdom-target-prop.js.
svg/dynamic-updates/script-tests/SVGCircleElement-dom-cx-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGCircleElement-dom-cx-attr.js.
svg/dynamic-updates/script-tests/SVGCircleElement-dom-cy-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGCircleElement-dom-cy-attr.js.
svg/dynamic-updates/script-tests/SVGCircleElement-dom-r-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGCircleElement-dom-r-attr.js.
svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-cx-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGCircleElement-svgdom-cx-prop.js.
svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-cy-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGCircleElement-svgdom-cy-prop.js.
svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-r-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGCircleElement-svgdom-r-prop.js.
svg/dynamic-updates/script-tests/SVGClipPathElement-dom-clipPathUnits-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGClipPathElement-dom-clipPathUnits-attr.js.
svg/dynamic-updates/script-tests/SVGClipPathElement-svgdom-clipPathUnits-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGClipPathElement-svgdom-clipPathUnits-prop.js.
svg/dynamic-updates/script-tests/SVGCursorElement-dom-x-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGCursorElement-dom-x-attr.js.
svg/dynamic-updates/script-tests/SVGCursorElement-dom-y-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGCursorElement-dom-y-attr.js.
svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-x-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGCursorElement-svgdom-x-prop.js.
svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-y-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGCursorElement-svgdom-y-prop.js.
svg/dynamic-updates/script-tests/SVGEllipseElement-dom-cx-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGEllipseElement-dom-cx-attr.js.
svg/dynamic-updates/script-tests/SVGEllipseElement-dom-cy-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGEllipseElement-dom-cy-attr.js.
svg/dynamic-updates/script-tests/SVGEllipseElement-dom-rx-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGEllipseElement-dom-rx-attr.js.
svg/dynamic-updates/script-tests/SVGEllipseElement-dom-ry-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGEllipseElement-dom-ry-attr.js.
svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-cx-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGEllipseElement-svgdom-cx-prop.js.
svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-cy-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGEllipseElement-svgdom-cy-prop.js.
svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-rx-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGEllipseElement-svgdom-rx-prop.js.
svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-ry-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGEllipseElement-svgdom-ry-prop.js.
svg/dynamic-updates/script-tests/SVGForeignObjectElement-dom-height-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGForeignObjectElement-dom-height-attr.js.
svg/dynamic-updates/script-tests/SVGForeignObjectElement-dom-width-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGForeignObjectElement-dom-width-attr.js.
svg/dynamic-updates/script-tests/SVGForeignObjectElement-dom-x-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGForeignObjectElement-dom-x-attr.js.
svg/dynamic-updates/script-tests/SVGForeignObjectElement-dom-y-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGForeignObjectElement-dom-y-attr.js.
svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-height-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGForeignObjectElement-svgdom-height-prop.js.
svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-width-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGForeignObjectElement-svgdom-width-prop.js.
svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-x-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGForeignObjectElement-svgdom-x-prop.js.
svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-y-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGForeignObjectElement-svgdom-y-prop.js.
svg/dynamic-updates/script-tests/SVGImageElement-dom-height-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGImageElement-dom-height-attr.js.
svg/dynamic-updates/script-tests/SVGImageElement-dom-preserveAspectRatio-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGImageElement-dom-preserveAspectRatio-attr.js.
svg/dynamic-updates/script-tests/SVGImageElement-dom-width-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGImageElement-dom-width-attr.js.
svg/dynamic-updates/script-tests/SVGImageElement-dom-x-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGImageElement-dom-x-attr.js.
svg/dynamic-updates/script-tests/SVGImageElement-dom-y-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGImageElement-dom-y-attr.js.
svg/dynamic-updates/script-tests/SVGImageElement-svgdom-height-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGImageElement-svgdom-height-prop.js.
svg/dynamic-updates/script-tests/SVGImageElement-svgdom-preserveAspectRatio-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGImageElement-svgdom-preserveAspectRatio-prop.js.
svg/dynamic-updates/script-tests/SVGImageElement-svgdom-width-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGImageElement-svgdom-width-prop.js.
svg/dynamic-updates/script-tests/SVGImageElement-svgdom-x-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGImageElement-svgdom-x-prop.js.
svg/dynamic-updates/script-tests/SVGImageElement-svgdom-y-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGImageElement-svgdom-y-prop.js.
svg/dynamic-updates/script-tests/SVGLineElement-dom-x1-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLineElement-dom-x1-attr.js.
svg/dynamic-updates/script-tests/SVGLineElement-dom-x2-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLineElement-dom-x2-attr.js.
svg/dynamic-updates/script-tests/SVGLineElement-dom-y1-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLineElement-dom-y1-attr.js.
svg/dynamic-updates/script-tests/SVGLineElement-dom-y2-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLineElement-dom-y2-attr.js.
svg/dynamic-updates/script-tests/SVGLineElement-svgdom-x1-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLineElement-svgdom-x1-prop.js.
svg/dynamic-updates/script-tests/SVGLineElement-svgdom-x2-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLineElement-svgdom-x2-prop.js.
svg/dynamic-updates/script-tests/SVGLineElement-svgdom-y1-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLineElement-svgdom-y1-prop.js.
svg/dynamic-updates/script-tests/SVGLineElement-svgdom-y2-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLineElement-svgdom-y2-prop.js.
svg/dynamic-updates/script-tests/SVGLinearGradientElement-dom-gradientTransform-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLinearGradientElement-dom-gradientTransform-attr.js.
svg/dynamic-updates/script-tests/SVGLinearGradientElement-dom-gradientUnits-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLinearGradientElement-dom-gradientUnits-attr.js.
svg/dynamic-updates/script-tests/SVGLinearGradientElement-dom-x1-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLinearGradientElement-dom-x1-attr.js.
svg/dynamic-updates/script-tests/SVGLinearGradientElement-dom-x2-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLinearGradientElement-dom-x2-attr.js.
svg/dynamic-updates/script-tests/SVGLinearGradientElement-dom-y1-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLinearGradientElement-dom-y1-attr.js.
svg/dynamic-updates/script-tests/SVGLinearGradientElement-dom-y2-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLinearGradientElement-dom-y2-attr.js.
svg/dynamic-updates/script-tests/SVGLinearGradientElement-svgdom-gradientTransform-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLinearGradientElement-svgdom-gradientTransform-prop.js.
svg/dynamic-updates/script-tests/SVGLinearGradientElement-svgdom-gradientUnits-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLinearGradientElement-svgdom-gradientUnits-prop.js.
svg/dynamic-updates/script-tests/SVGLinearGradientElement-svgdom-x1-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLinearGradientElement-svgdom-x1-prop.js.
svg/dynamic-updates/script-tests/SVGLinearGradientElement-svgdom-x2-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLinearGradientElement-svgdom-x2-prop.js.
svg/dynamic-updates/script-tests/SVGLinearGradientElement-svgdom-y1-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLinearGradientElement-svgdom-y1-prop.js.
svg/dynamic-updates/script-tests/SVGLinearGradientElement-svgdom-y2-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGLinearGradientElement-svgdom-y2-prop.js.
svg/dynamic-updates/script-tests/SVGMarkerElement-dom-markerHeight-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMarkerElement-dom-markerHeight-attr.js.
svg/dynamic-updates/script-tests/SVGMarkerElement-dom-markerUnits-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMarkerElement-dom-markerUnits-attr.js.
svg/dynamic-updates/script-tests/SVGMarkerElement-dom-markerWidth-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMarkerElement-dom-markerWidth-attr.js.
svg/dynamic-updates/script-tests/SVGMarkerElement-dom-orient-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMarkerElement-dom-orient-attr.js.
svg/dynamic-updates/script-tests/SVGMarkerElement-dom-refX-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMarkerElement-dom-refX-attr.js.
svg/dynamic-updates/script-tests/SVGMarkerElement-dom-refY-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMarkerElement-dom-refY-attr.js.
svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-markerHeight-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMarkerElement-svgdom-markerHeight-prop.js.
svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-markerUnits-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMarkerElement-svgdom-markerUnits-prop.js.
svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-markerWidth-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMarkerElement-svgdom-markerWidth-prop.js.
svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-orientAngle-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMarkerElement-svgdom-orientAngle-prop.js.
svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-orientType-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMarkerElement-svgdom-orientType-prop.js.
svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-refX-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMarkerElement-svgdom-refX-prop.js.
svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-refY-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMarkerElement-svgdom-refY-prop.js.
svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-setOrientToAngle-call.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMarkerElement-svgdom-setOrientToAngle-call.js.
svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-setOrientToAuto-call.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMarkerElement-svgdom-setOrientToAuto-call.js.
svg/dynamic-updates/script-tests/SVGMaskElement-dom-height-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMaskElement-dom-height-attr.js.
svg/dynamic-updates/script-tests/SVGMaskElement-dom-maskContentUnits-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMaskElement-dom-maskContentUnits-attr.js.
svg/dynamic-updates/script-tests/SVGMaskElement-dom-maskUnits-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMaskElement-dom-maskUnits-attr.js.
svg/dynamic-updates/script-tests/SVGMaskElement-dom-width-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMaskElement-dom-width-attr.js.
svg/dynamic-updates/script-tests/SVGMaskElement-dom-x-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMaskElement-dom-x-attr.js.
svg/dynamic-updates/script-tests/SVGMaskElement-dom-y-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMaskElement-dom-y-attr.js.
svg/dynamic-updates/script-tests/SVGMaskElement-svgdom-height-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMaskElement-svgdom-height-prop.js.
svg/dynamic-updates/script-tests/SVGMaskElement-svgdom-maskContentUnits-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMaskElement-svgdom-maskContentUnits-prop.js.
svg/dynamic-updates/script-tests/SVGMaskElement-svgdom-maskUnits-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMaskElement-svgdom-maskUnits-prop.js.
svg/dynamic-updates/script-tests/SVGMaskElement-svgdom-width-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMaskElement-svgdom-width-prop.js.
svg/dynamic-updates/script-tests/SVGMaskElement-svgdom-x-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMaskElement-svgdom-x-prop.js.
svg/dynamic-updates/script-tests/SVGMaskElement-svgdom-y-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGMaskElement-svgdom-y-prop.js.
svg/dynamic-updates/script-tests/SVGPatternElement-dom-height-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGPatternElement-dom-height-attr.js.
svg/dynamic-updates/script-tests/SVGPatternElement-dom-patternContentUnits-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGPatternElement-dom-patternContentUnits-attr.js.
svg/dynamic-updates/script-tests/SVGPatternElement-dom-patternTransform-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGPatternElement-dom-patternTransform-attr.js.
svg/dynamic-updates/script-tests/SVGPatternElement-dom-patternUnits-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGPatternElement-dom-patternUnits-attr.js.
svg/dynamic-updates/script-tests/SVGPatternElement-dom-width-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGPatternElement-dom-width-attr.js.
svg/dynamic-updates/script-tests/SVGPatternElement-dom-x-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGPatternElement-dom-x-attr.js.
svg/dynamic-updates/script-tests/SVGPatternElement-dom-y-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGPatternElement-dom-y-attr.js.
svg/dynamic-updates/script-tests/SVGPatternElement-svgdom-height-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGPatternElement-svgdom-height-prop.js.
svg/dynamic-updates/script-tests/SVGPatternElement-svgdom-patternContentUnits-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGPatternElement-svgdom-patternContentUnits-prop.js.
svg/dynamic-updates/script-tests/SVGPatternElement-svgdom-patternTransform-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGPatternElement-svgdom-patternTransform-prop.js.
svg/dynamic-updates/script-tests/SVGPatternElement-svgdom-patternUnits-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGPatternElement-svgdom-patternUnits-prop.js.
svg/dynamic-updates/script-tests/SVGPatternElement-svgdom-width-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGPatternElement-svgdom-width-prop.js.
svg/dynamic-updates/script-tests/SVGPatternElement-svgdom-x-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGPatternElement-svgdom-x-prop.js.
svg/dynamic-updates/script-tests/SVGPatternElement-svgdom-y-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGPatternElement-svgdom-y-prop.js.
svg/dynamic-updates/script-tests/SVGRadialGradientElement-dom-cx-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRadialGradientElement-dom-cx-attr.js.
svg/dynamic-updates/script-tests/SVGRadialGradientElement-dom-cy-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRadialGradientElement-dom-cy-attr.js.
svg/dynamic-updates/script-tests/SVGRadialGradientElement-dom-fx-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRadialGradientElement-dom-fx-attr.js.
svg/dynamic-updates/script-tests/SVGRadialGradientElement-dom-fy-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRadialGradientElement-dom-fy-attr.js.
svg/dynamic-updates/script-tests/SVGRadialGradientElement-dom-gradientTransform-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRadialGradientElement-dom-gradientTransform-attr.js.
svg/dynamic-updates/script-tests/SVGRadialGradientElement-dom-gradientUnits-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRadialGradientElement-dom-gradientUnits-attr.js.
svg/dynamic-updates/script-tests/SVGRadialGradientElement-dom-r-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRadialGradientElement-dom-r-attr.js.
svg/dynamic-updates/script-tests/SVGRadialGradientElement-svgdom-cx-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRadialGradientElement-svgdom-cx-prop.js.
svg/dynamic-updates/script-tests/SVGRadialGradientElement-svgdom-cy-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRadialGradientElement-svgdom-cy-prop.js.
svg/dynamic-updates/script-tests/SVGRadialGradientElement-svgdom-fx-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRadialGradientElement-svgdom-fx-prop.js.
svg/dynamic-updates/script-tests/SVGRadialGradientElement-svgdom-fy-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRadialGradientElement-svgdom-fy-prop.js.
svg/dynamic-updates/script-tests/SVGRadialGradientElement-svgdom-gradientTransform-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRadialGradientElement-svgdom-gradientTransform-prop.js.
svg/dynamic-updates/script-tests/SVGRadialGradientElement-svgdom-gradientUnits-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRadialGradientElement-svgdom-gradientUnits-prop.js.
svg/dynamic-updates/script-tests/SVGRadialGradientElement-svgdom-r-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRadialGradientElement-svgdom-r-prop.js.
svg/dynamic-updates/script-tests/SVGRectElement-dom-height-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRectElement-dom-height-attr.js.
svg/dynamic-updates/script-tests/SVGRectElement-dom-width-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRectElement-dom-width-attr.js.
svg/dynamic-updates/script-tests/SVGRectElement-dom-x-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRectElement-dom-x-attr.js.
svg/dynamic-updates/script-tests/SVGRectElement-dom-y-attr.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRectElement-dom-y-attr.js.
svg/dynamic-updates/script-tests/SVGRectElement-svgdom-height-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRectElement-svgdom-height-prop.js.
svg/dynamic-updates/script-tests/SVGRectElement-svgdom-width-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRectElement-svgdom-width-prop.js.
svg/dynamic-updates/script-tests/SVGRectElement-svgdom-x-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRectElement-svgdom-x-prop.js.
svg/dynamic-updates/script-tests/SVGRectElement-svgdom-y-prop.js: Copied from LayoutTests/svg/dynamic-updates/resources/SVGRectElement-svgdom-y-prop.js.
svg/dynamic-updates/script-tests/TEMPLATE.html: Copied from LayoutTests/svg/dynamic-updates/resources/TEMPLATE.html.

2:35 AM Changeset in webkit [48553] by hamaji@chromium.org

36 edits
44 moves
8 adds in trunk/LayoutTests

2009-09-19 Shinichiro Hamaji <hamaji@chromium.org>

Rubber-stamped by Eric Seidel.

js tests should move into jstests subdirectory instead of resources/
https://bugs.webkit.org/show_bug.cgi?id=25880

Migration for http, platform, plugins, traversal, and wml directories.

http/tests/cookies/double-quoted-value-with-semi-colon.html:
http/tests/cookies/multiple-cookies.html:
http/tests/cookies/resources/TEMPLATE.html: Removed.
http/tests/cookies/resources/double-quoted-value-with-semi-colon.js: Removed.
http/tests/cookies/resources/multiple-cookies.js: Removed.
http/tests/cookies/resources/simple-cookies-expired.js: Removed.
http/tests/cookies/resources/simple-cookies-max-age.js: Removed.
http/tests/cookies/script-tests: Added.
http/tests/cookies/script-tests/TEMPLATE.html: Copied from LayoutTests/http/tests/cookies/resources/TEMPLATE.html.
http/tests/cookies/script-tests/double-quoted-value-with-semi-colon.js: Copied from LayoutTests/http/tests/cookies/resources/double-quoted-value-with-semi-colon.js.
http/tests/cookies/script-tests/multiple-cookies.js: Copied from LayoutTests/http/tests/cookies/resources/multiple-cookies.js.
http/tests/cookies/script-tests/simple-cookies-expired.js: Copied from LayoutTests/http/tests/cookies/resources/simple-cookies-expired.js.
http/tests/cookies/script-tests/simple-cookies-max-age.js: Copied from LayoutTests/http/tests/cookies/resources/simple-cookies-max-age.js.
http/tests/cookies/simple-cookies-expired.html:
http/tests/cookies/simple-cookies-max-age.html:
http/tests/security/clipboard/clipboard-file-access.html:
http/tests/security/clipboard/resources/TEMPLATE.html: Removed.
http/tests/security/clipboard/resources/clipboard-file-access.js: Removed.
http/tests/security/clipboard/script-tests: Added.
http/tests/security/clipboard/script-tests/TEMPLATE.html: Copied from LayoutTests/http/tests/security/clipboard/resources/TEMPLATE.html.
http/tests/security/clipboard/script-tests/clipboard-file-access.js: Copied from LayoutTests/http/tests/security/clipboard/resources/clipboard-file-access.js.
http/tests/wml/access-target-domain-deny.html:
http/tests/wml/access-target-path-deny.html:
http/tests/wml/access-target.html:
http/tests/wml/go-task-get-method-accept-charset.html:
http/tests/wml/go-task-get-method.html:
http/tests/wml/go-task-post-method-accept-charset.html:
http/tests/wml/go-task-post-method.html:
http/tests/wml/post-data-to-server.html:
http/tests/wml/resources/TEMPLATE.html: Removed.
http/tests/wml/resources/access-target-domain-deny.js: Removed.
http/tests/wml/resources/access-target-path-deny.js: Removed.
http/tests/wml/resources/access-target.js: Removed.
http/tests/wml/resources/go-task-get-method-accept-charset.js: Removed.
http/tests/wml/resources/go-task-get-method.js: Removed.
http/tests/wml/resources/go-task-post-method-accept-charset.js: Removed.
http/tests/wml/resources/go-task-post-method.js: Removed.
http/tests/wml/resources/post-data-to-server.js: Removed.
http/tests/wml/script-tests: Added.
http/tests/wml/script-tests/TEMPLATE.html: Copied from LayoutTests/http/tests/wml/resources/TEMPLATE.html.
http/tests/wml/script-tests/access-target-domain-deny.js: Copied from LayoutTests/http/tests/wml/resources/access-target-domain-deny.js.
http/tests/wml/script-tests/access-target-path-deny.js: Copied from LayoutTests/http/tests/wml/resources/access-target-path-deny.js.
http/tests/wml/script-tests/access-target.js: Copied from LayoutTests/http/tests/wml/resources/access-target.js.
http/tests/wml/script-tests/go-task-get-method-accept-charset.js: Copied from LayoutTests/http/tests/wml/resources/go-task-get-method-accept-charset.js.
http/tests/wml/script-tests/go-task-get-method.js: Copied from LayoutTests/http/tests/wml/resources/go-task-get-method.js.
http/tests/wml/script-tests/go-task-post-method-accept-charset.js: Copied from LayoutTests/http/tests/wml/resources/go-task-post-method-accept-charset.js.
http/tests/wml/script-tests/go-task-post-method.js: Copied from LayoutTests/http/tests/wml/resources/go-task-post-method.js.
http/tests/wml/script-tests/post-data-to-server.js: Copied from LayoutTests/http/tests/wml/resources/post-data-to-server.js.
platform/gtk/editing/pasteboard/resources/TEMPLATE.html: Removed.
platform/gtk/editing/pasteboard/resources/middle-click-onpaste.js: Removed.
platform/gtk/editing/pasteboard/script-tests: Added.
platform/gtk/editing/pasteboard/script-tests/TEMPLATE.html: Copied from LayoutTests/platform/gtk/editing/pasteboard/resources/TEMPLATE.html.
platform/gtk/editing/pasteboard/script-tests/middle-click-onpaste.js: Copied from LayoutTests/platform/gtk/editing/pasteboard/resources/middle-click-onpaste.js.
platform/win/fast/events/context-click-events.html:
platform/win/fast/events/resources/TEMPLATE.html: Removed.
platform/win/fast/events/resources/context-click-events.js: Removed.
platform/win/fast/events/script-tests: Added.
platform/win/fast/events/script-tests/TEMPLATE.html: Copied from LayoutTests/platform/win/fast/events/resources/TEMPLATE.html.
platform/win/fast/events/script-tests/context-click-events.js: Copied from LayoutTests/platform/win/fast/events/resources/context-click-events.js.
plugins/netscape-identifier-conversion.html:
plugins/resources/TEMPLATE.html: Removed.
plugins/resources/netscape-identifier-conversion.js: Removed.
plugins/script-tests: Added.
plugins/script-tests/TEMPLATE.html: Copied from LayoutTests/plugins/resources/TEMPLATE.html.
plugins/script-tests/netscape-identifier-conversion.js: Copied from LayoutTests/plugins/resources/netscape-identifier-conversion.js.
traversal/acid3-test-2.html:
traversal/exception-forwarding.html:
traversal/resources/TEMPLATE.html: Removed.
traversal/resources/acid3-test-2.js: Removed.
traversal/resources/exception-forwarding.js: Removed.
traversal/script-tests: Added.
traversal/script-tests/TEMPLATE.html: Copied from LayoutTests/traversal/resources/TEMPLATE.html.
traversal/script-tests/acid3-test-2.js: Copied from LayoutTests/traversal/resources/acid3-test-2.js.
traversal/script-tests/exception-forwarding.js: Copied from LayoutTests/traversal/resources/exception-forwarding.js.
wml/access-target-deny.html:
wml/access-target.html:
wml/enter-card-with-events.html:
wml/enter-first-card-with-events.html:
wml/go-task-get-method-external-deck-with-href.html:
wml/go-task-get-method-external-deck.html:
wml/go-task-get-method-same-deck.html:
wml/input-format.html:
wml/newcontext-same-deck.html:
wml/onenterforward-event.html:
wml/onenterforward-inline-event.html:
wml/ontimer-event.html:
wml/ontimer-inline-event.html:
wml/option-element-onpick-recursion.html:
wml/option-element-onpick.html:
wml/resources/TEMPLATE.html: Removed.
wml/resources/access-target-deny.js: Removed.
wml/resources/access-target.js: Removed.
wml/resources/enter-card-with-events.js: Removed.
wml/resources/enter-first-card-with-events.js: Removed.
wml/resources/go-task-get-method-external-deck-with-href.js: Removed.
wml/resources/go-task-get-method-external-deck.js: Removed.
wml/resources/go-task-get-method-same-deck.js: Removed.
wml/resources/input-format.js: Removed.
wml/resources/newcontext-same-deck.js: Removed.
wml/resources/onenterforward-event.js: Removed.
wml/resources/onenterforward-inline-event.js: Removed.
wml/resources/ontimer-event.js: Removed.
wml/resources/ontimer-inline-event.js: Removed.
wml/resources/option-element-onpick-recursion.js: Removed.
wml/resources/option-element-onpick.js: Removed.
wml/resources/select-element-variables.js: Removed.
wml/resources/variable-reference-invalid-character.js: Removed.
wml/resources/variable-reference-valid.js: Removed.
wml/script-tests: Added.
wml/script-tests/TEMPLATE.html: Copied from LayoutTests/wml/resources/TEMPLATE.html.
wml/script-tests/access-target-deny.js: Copied from LayoutTests/wml/resources/access-target-deny.js.
wml/script-tests/access-target.js: Copied from LayoutTests/wml/resources/access-target.js.
wml/script-tests/enter-card-with-events.js: Copied from LayoutTests/wml/resources/enter-card-with-events.js.
wml/script-tests/enter-first-card-with-events.js: Copied from LayoutTests/wml/resources/enter-first-card-with-events.js.
wml/script-tests/go-task-get-method-external-deck-with-href.js: Copied from LayoutTests/wml/resources/go-task-get-method-external-deck-with-href.js.
wml/script-tests/go-task-get-method-external-deck.js: Copied from LayoutTests/wml/resources/go-task-get-method-external-deck.js.
wml/script-tests/go-task-get-method-same-deck.js: Copied from LayoutTests/wml/resources/go-task-get-method-same-deck.js.
wml/script-tests/input-format.js: Copied from LayoutTests/wml/resources/input-format.js.
wml/script-tests/newcontext-same-deck.js: Copied from LayoutTests/wml/resources/newcontext-same-deck.js.
wml/script-tests/onenterforward-event.js: Copied from LayoutTests/wml/resources/onenterforward-event.js.
wml/script-tests/onenterforward-inline-event.js: Copied from LayoutTests/wml/resources/onenterforward-inline-event.js.
wml/script-tests/ontimer-event.js: Copied from LayoutTests/wml/resources/ontimer-event.js.
wml/script-tests/ontimer-inline-event.js: Copied from LayoutTests/wml/resources/ontimer-inline-event.js.
wml/script-tests/option-element-onpick-recursion.js: Copied from LayoutTests/wml/resources/option-element-onpick-recursion.js.
wml/script-tests/option-element-onpick.js: Copied from LayoutTests/wml/resources/option-element-onpick.js.
wml/script-tests/select-element-variables.js: Copied from LayoutTests/wml/resources/select-element-variables.js.
wml/script-tests/variable-reference-invalid-character.js: Copied from LayoutTests/wml/resources/variable-reference-invalid-character.js.
wml/script-tests/variable-reference-valid.js: Copied from LayoutTests/wml/resources/variable-reference-valid.js.
wml/select-element-variables.html:
wml/variable-reference-invalid-character.html:
wml/variable-reference-valid.html:

1:49 AM Changeset in webkit [48552] by hamaji@chromium.org

36 edits
42 moves
7 adds in trunk/LayoutTests

2009-09-19 Shinichiro Hamaji <hamaji@chromium.org>

Rubber-stamped by Eric Seidel.

js tests should move into jstests subdirectory instead of resources/
https://bugs.webkit.org/show_bug.cgi?id=25880

Migration for fast/* directories except fast js directory.

fast/events/blur-focus-window-should-blur-focus-element.html:
fast/events/create-document-crash-on-attach-event.html:
fast/events/event-function-toString.html:
fast/events/event-instanceof.html:
fast/events/event-listener-sharing.html:
fast/events/init-events.html:
fast/events/mouse-click-events.html:
fast/events/resources/TEMPLATE.html: Removed.
fast/events/resources/blur-focus-window-should-blur-focus-element.js: Removed.
fast/events/resources/create-document-crash-on-attach-event.js: Removed.
fast/events/resources/event-function-toString.js: Removed.
fast/events/resources/event-instanceof.js: Removed.
fast/events/resources/event-listener-sharing.js: Removed.
fast/events/resources/init-events.js: Removed.
fast/events/resources/mouse-click-events.js: Removed.
fast/events/resources/tab-is-focusable-assert.js: Removed.
fast/events/script-tests: Added.
fast/events/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/events/resources/TEMPLATE.html.
fast/events/script-tests/blur-focus-window-should-blur-focus-element.js: Copied from LayoutTests/fast/events/resources/blur-focus-window-should-blur-focus-element.js.
fast/events/script-tests/create-document-crash-on-attach-event.js: Copied from LayoutTests/fast/events/resources/create-document-crash-on-attach-event.js.
fast/events/script-tests/event-function-toString.js: Copied from LayoutTests/fast/events/resources/event-function-toString.js.
fast/events/script-tests/event-instanceof.js: Copied from LayoutTests/fast/events/resources/event-instanceof.js.
fast/events/script-tests/event-listener-sharing.js: Copied from LayoutTests/fast/events/resources/event-listener-sharing.js.
fast/events/script-tests/init-events.js: Copied from LayoutTests/fast/events/resources/init-events.js.
fast/events/script-tests/mouse-click-events.js: Copied from LayoutTests/fast/events/resources/mouse-click-events.js.
fast/events/script-tests/tab-is-focusable-assert.js: Copied from LayoutTests/fast/events/resources/tab-is-focusable-assert.js.
fast/events/tab-is-focusable-assert.html:
fast/forms/ValidityState-patternMismatch-unsupported.html:
fast/forms/ValidityState-typeMismatch-color.html:
fast/forms/ValidityState-typeMismatch-number.html:
fast/forms/ValidityState-typeMismatch-url.html:
fast/forms/formnovalidate-attribute.html:
fast/forms/input-maxlength-ime-completed.html:
fast/forms/input-maxlength-ime-preedit.html:
fast/forms/novalidate-attribute.html:
fast/forms/placeholder-dom-property.html:
fast/forms/resources/TEMPLATE.html: Removed.
fast/forms/resources/ValidityState-patternMismatch-unsupported.js: Removed.
fast/forms/resources/ValidityState-typeMismatch-color.js: Removed.
fast/forms/resources/ValidityState-typeMismatch-number.js: Removed.
fast/forms/resources/ValidityState-typeMismatch-url.js: Removed.
fast/forms/resources/formnovalidate-attribute.js: Removed.
fast/forms/resources/input-maxlength-ime-completed.js: Removed.
fast/forms/resources/input-maxlength-ime-preedit.js: Removed.
fast/forms/resources/novalidate-attribute.js: Removed.
fast/forms/resources/placeholder-dom-property.js: Removed.
fast/forms/resources/shadow-tree-exposure.js: Removed.
fast/forms/resources/text-control-intrinsic-widths.js: Removed.
fast/forms/resources/textarea-metrics.js: Removed.
fast/forms/resources/textarea-placeholder-dom-property.js: Removed.
fast/forms/resources/textarea-textlength.js: Removed.
fast/forms/script-tests: Added.
fast/forms/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/forms/resources/TEMPLATE.html.
fast/forms/script-tests/ValidityState-patternMismatch-unsupported.js: Copied from LayoutTests/fast/forms/resources/ValidityState-patternMismatch-unsupported.js.
fast/forms/script-tests/ValidityState-typeMismatch-color.js: Copied from LayoutTests/fast/forms/resources/ValidityState-typeMismatch-color.js.
fast/forms/script-tests/ValidityState-typeMismatch-number.js: Copied from LayoutTests/fast/forms/resources/ValidityState-typeMismatch-number.js.
fast/forms/script-tests/ValidityState-typeMismatch-url.js: Copied from LayoutTests/fast/forms/resources/ValidityState-typeMismatch-url.js.
fast/forms/script-tests/formnovalidate-attribute.js: Copied from LayoutTests/fast/forms/resources/formnovalidate-attribute.js.
fast/forms/script-tests/input-maxlength-ime-completed.js: Copied from LayoutTests/fast/forms/resources/input-maxlength-ime-completed.js.
fast/forms/script-tests/input-maxlength-ime-preedit.js: Copied from LayoutTests/fast/forms/resources/input-maxlength-ime-preedit.js.
fast/forms/script-tests/novalidate-attribute.js: Copied from LayoutTests/fast/forms/resources/novalidate-attribute.js.
fast/forms/script-tests/placeholder-dom-property.js: Copied from LayoutTests/fast/forms/resources/placeholder-dom-property.js.
fast/forms/script-tests/shadow-tree-exposure.js: Copied from LayoutTests/fast/forms/resources/shadow-tree-exposure.js.
fast/forms/script-tests/text-control-intrinsic-widths.js: Copied from LayoutTests/fast/forms/resources/text-control-intrinsic-widths.js.
fast/forms/script-tests/textarea-metrics.js: Copied from LayoutTests/fast/forms/resources/textarea-metrics.js.
fast/forms/script-tests/textarea-placeholder-dom-property.js: Copied from LayoutTests/fast/forms/resources/textarea-placeholder-dom-property.js.
fast/forms/script-tests/textarea-textlength.js: Copied from LayoutTests/fast/forms/resources/textarea-textlength.js.
fast/forms/shadow-tree-exposure.html:
fast/forms/text-control-intrinsic-widths.html:
fast/forms/textarea-metrics.html:
fast/forms/textarea-placeholder-dom-property.html:
fast/forms/textarea-textlength.html:
fast/images/border.html:
fast/images/resources/TEMPLATE.html: Removed.
fast/images/resources/border.js: Removed.
fast/images/script-tests: Added.
fast/images/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/images/resources/TEMPLATE.html.
fast/images/script-tests/border.js: Copied from LayoutTests/fast/images/resources/border.js.
fast/parser/block-nesting-cap.html:
fast/parser/pre-first-line-break.html:
fast/parser/resources/TEMPLATE.html: Removed.
fast/parser/resources/block-nesting-cap.js: Removed.
fast/parser/resources/pre-first-line-break.js: Removed.
fast/parser/script-tests: Added.
fast/parser/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/parser/resources/TEMPLATE.html.
fast/parser/script-tests/block-nesting-cap.js: Copied from LayoutTests/fast/parser/resources/block-nesting-cap.js.
fast/parser/script-tests/pre-first-line-break.js: Copied from LayoutTests/fast/parser/resources/pre-first-line-break.js.
fast/regex/alternative-length-miscalculation.html:
fast/regex/cross-frame-callable.html:
fast/regex/early-acid3-86.html:
fast/regex/malformed-escapes.html:
fast/regex/non-capturing-backtracking.html:
fast/regex/non-pattern-characters.html:
fast/regex/quantified-assertions.html:
fast/regex/resources/TEMPLATE.html: Removed.
fast/regex/resources/alternative-length-miscalculation.js: Removed.
fast/regex/resources/cross-frame-callable.js: Removed.
fast/regex/resources/early-acid3-86.js: Removed.
fast/regex/resources/malformed-escapes.js: Removed.
fast/regex/resources/non-capturing-backtracking.js: Removed.
fast/regex/resources/non-pattern-characters.js: Removed.
fast/regex/resources/quantified-assertions.js: Removed.
fast/regex/resources/slow.js: Removed.
fast/regex/script-tests: Added.
fast/regex/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/regex/resources/TEMPLATE.html.
fast/regex/script-tests/alternative-length-miscalculation.js: Copied from LayoutTests/fast/regex/resources/alternative-length-miscalculation.js.
fast/regex/script-tests/cross-frame-callable.js: Copied from LayoutTests/fast/regex/resources/cross-frame-callable.js.
fast/regex/script-tests/early-acid3-86.js: Copied from LayoutTests/fast/regex/resources/early-acid3-86.js.
fast/regex/script-tests/malformed-escapes.js: Copied from LayoutTests/fast/regex/resources/malformed-escapes.js.
fast/regex/script-tests/non-capturing-backtracking.js: Copied from LayoutTests/fast/regex/resources/non-capturing-backtracking.js.
fast/regex/script-tests/non-pattern-characters.js: Copied from LayoutTests/fast/regex/resources/non-pattern-characters.js.
fast/regex/script-tests/quantified-assertions.js: Copied from LayoutTests/fast/regex/resources/quantified-assertions.js.
fast/regex/script-tests/slow.js: Copied from LayoutTests/fast/regex/resources/slow.js.
fast/regex/slow.html:
fast/table/border-changes.html:
fast/table/resources/TEMPLATE.html: Removed.
fast/table/resources/border-changes.js: Removed.
fast/table/script-tests: Added.
fast/table/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/table/resources/TEMPLATE.html.
fast/table/script-tests/border-changes.js: Copied from LayoutTests/fast/table/resources/border-changes.js.
fast/text/find-backwards.html:
fast/text/resources/TEMPLATE.html: Removed.
fast/text/resources/find-backwards.js: Removed.
fast/text/script-tests: Added.
fast/text/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/text/resources/TEMPLATE.html.
fast/text/script-tests/find-backwards.js: Copied from LayoutTests/fast/text/resources/find-backwards.js.

1:41 AM Changeset in webkit [48551] by hamaji@chromium.org

56 edits
74 moves
19 adds in trunk/LayoutTests

2009-09-19 Shinichiro Hamaji <hamaji@chromium.org>

Rubber-stamped by Eric Seidel.

js tests should move into jstests subdirectory instead of resources/
https://bugs.webkit.org/show_bug.cgi?id=25880

Migration for fast/dom directories.

fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html:
fast/dom/CSSStyleDeclaration/resources/TEMPLATE.html: Removed.
fast/dom/CSSStyleDeclaration/resources/css-properties-case-sensitive.js: Removed.
fast/dom/CSSStyleDeclaration/resources/transition-property-names.js: Removed.
fast/dom/CSSStyleDeclaration/script-tests: Added.
fast/dom/CSSStyleDeclaration/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/CSSStyleDeclaration/resources/TEMPLATE.html.
fast/dom/CSSStyleDeclaration/script-tests/css-properties-case-sensitive.js: Copied from LayoutTests/fast/dom/CSSStyleDeclaration/resources/css-properties-case-sensitive.js.
fast/dom/CSSStyleDeclaration/script-tests/transition-property-names.js: Copied from LayoutTests/fast/dom/CSSStyleDeclaration/resources/transition-property-names.js.
fast/dom/CSSStyleDeclaration/transition-property-names.html:
fast/dom/DOMImplementation/createDocument-namespace-err.html:
fast/dom/DOMImplementation/createDocumentType-err.html:
fast/dom/DOMImplementation/resources/TEMPLATE.html: Removed.
fast/dom/DOMImplementation/resources/createDocument-namespace-err.js: Removed.
fast/dom/DOMImplementation/resources/createDocumentType-err.js: Removed.
fast/dom/DOMImplementation/script-tests: Added.
fast/dom/DOMImplementation/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/DOMImplementation/resources/TEMPLATE.html.
fast/dom/DOMImplementation/script-tests/createDocument-namespace-err.js: Copied from LayoutTests/fast/dom/DOMImplementation/resources/createDocument-namespace-err.js.
fast/dom/DOMImplementation/script-tests/createDocumentType-err.js: Copied from LayoutTests/fast/dom/DOMImplementation/resources/createDocumentType-err.js.
fast/dom/Document/createAttributeNS-namespace-err.html:
fast/dom/Document/createElementNS-namespace-err.html:
fast/dom/Document/document-write-doctype.html:
fast/dom/Document/replaceChild-null-oldChild.html:
fast/dom/Document/resources/TEMPLATE.html: Removed.
fast/dom/Document/resources/createAttributeNS-namespace-err.js: Removed.
fast/dom/Document/resources/createElementNS-namespace-err.js: Removed.
fast/dom/Document/resources/document-write-doctype.js: Removed.
fast/dom/Document/resources/replaceChild-null-oldChild.js: Removed.
fast/dom/Document/script-tests: Added.
fast/dom/Document/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Document/resources/TEMPLATE.html.
fast/dom/Document/script-tests/createAttributeNS-namespace-err.js: Copied from LayoutTests/fast/dom/Document/resources/createAttributeNS-namespace-err.js.
fast/dom/Document/script-tests/createElementNS-namespace-err.js: Copied from LayoutTests/fast/dom/Document/resources/createElementNS-namespace-err.js.
fast/dom/Document/script-tests/document-write-doctype.js: Copied from LayoutTests/fast/dom/Document/resources/document-write-doctype.js.
fast/dom/Document/script-tests/replaceChild-null-oldChild.js: Copied from LayoutTests/fast/dom/Document/resources/replaceChild-null-oldChild.js.
fast/dom/Element/attr-param-typechecking.html:
fast/dom/Element/contains-method.html:
fast/dom/Element/dimension-properties-unrendered.html:
fast/dom/Element/element-traversal.html:
fast/dom/Element/getAttribute-check-case-sensitivity.html:
fast/dom/Element/resources/TEMPLATE.html: Removed.
fast/dom/Element/resources/attr-param-typechecking.js: Removed.
fast/dom/Element/resources/contains-method.js: Removed.
fast/dom/Element/resources/dimension-properties-unrendered.js: Removed.
fast/dom/Element/resources/element-traversal.js: Removed.
fast/dom/Element/resources/getAttribute-check-case-sensitivity.js: Removed.
fast/dom/Element/script-tests: Added.
fast/dom/Element/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Element/resources/TEMPLATE.html.
fast/dom/Element/script-tests/attr-param-typechecking.js: Copied from LayoutTests/fast/dom/Element/resources/attr-param-typechecking.js.
fast/dom/Element/script-tests/contains-method.js: Copied from LayoutTests/fast/dom/Element/resources/contains-method.js.
fast/dom/Element/script-tests/dimension-properties-unrendered.js: Copied from LayoutTests/fast/dom/Element/resources/dimension-properties-unrendered.js.
fast/dom/Element/script-tests/element-traversal.js: Copied from LayoutTests/fast/dom/Element/resources/element-traversal.js.
fast/dom/Element/script-tests/getAttribute-check-case-sensitivity.js: Copied from LayoutTests/fast/dom/Element/resources/getAttribute-check-case-sensitivity.js.
fast/dom/EntityReference/readonly-exceptions.html:
fast/dom/EntityReference/resources/TEMPLATE.html: Removed.
fast/dom/EntityReference/resources/readonly-exceptions.js: Removed.
fast/dom/EntityReference/script-tests: Added.
fast/dom/EntityReference/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/EntityReference/resources/TEMPLATE.html.
fast/dom/EntityReference/script-tests/readonly-exceptions.js: Copied from LayoutTests/fast/dom/EntityReference/resources/readonly-exceptions.js.
fast/dom/HTMLFontElement/resources/TEMPLATE.html: Removed.
fast/dom/HTMLFontElement/resources/size-attribute.js: Removed.
fast/dom/HTMLFontElement/script-tests: Added.
fast/dom/HTMLFontElement/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/HTMLFontElement/resources/TEMPLATE.html.
fast/dom/HTMLFontElement/script-tests/size-attribute.js: Copied from LayoutTests/fast/dom/HTMLFontElement/resources/size-attribute.js.
fast/dom/HTMLFontElement/size-attribute.html:
fast/dom/HTMLFormElement/elements-not-in-document.html:
fast/dom/HTMLFormElement/resources/TEMPLATE.html: Removed.
fast/dom/HTMLFormElement/resources/elements-not-in-document.js: Removed.
fast/dom/HTMLFormElement/script-tests: Added.
fast/dom/HTMLFormElement/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/HTMLFormElement/resources/TEMPLATE.html.
fast/dom/HTMLFormElement/script-tests/elements-not-in-document.js: Copied from LayoutTests/fast/dom/HTMLFormElement/resources/elements-not-in-document.js.
fast/dom/HTMLInputElement/checked-pseudo-selector.html:
fast/dom/HTMLInputElement/resources/TEMPLATE.html: Removed.
fast/dom/HTMLInputElement/resources/checked-pseudo-selector.js: Removed.
fast/dom/HTMLInputElement/resources/size-attribute.js: Removed.
fast/dom/HTMLInputElement/script-tests: Added.
fast/dom/HTMLInputElement/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/HTMLInputElement/resources/TEMPLATE.html.
fast/dom/HTMLInputElement/script-tests/checked-pseudo-selector.js: Copied from LayoutTests/fast/dom/HTMLInputElement/resources/checked-pseudo-selector.js.
fast/dom/HTMLInputElement/script-tests/size-attribute.js: Copied from LayoutTests/fast/dom/HTMLInputElement/resources/size-attribute.js.
fast/dom/HTMLInputElement/size-attribute.html:
fast/dom/HTMLSelectElement/named-options.html:
fast/dom/HTMLSelectElement/resources/TEMPLATE.html: Removed.
fast/dom/HTMLSelectElement/resources/named-options.js: Removed.
fast/dom/HTMLSelectElement/script-tests: Added.
fast/dom/HTMLSelectElement/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/HTMLSelectElement/resources/TEMPLATE.html.
fast/dom/HTMLSelectElement/script-tests/named-options.js: Copied from LayoutTests/fast/dom/HTMLSelectElement/resources/named-options.js.
fast/dom/HTMLTableElement/cellpadding-attribute.html:
fast/dom/HTMLTableElement/early-acid3-65-excerpt.html:
fast/dom/HTMLTableElement/early-acid3-66-excerpt.html:
fast/dom/HTMLTableElement/resources/TEMPLATE.html: Removed.
fast/dom/HTMLTableElement/resources/cellpadding-attribute.js: Removed.
fast/dom/HTMLTableElement/resources/early-acid3-65-excerpt.js: Removed.
fast/dom/HTMLTableElement/resources/early-acid3-66-excerpt.js: Removed.
fast/dom/HTMLTableElement/resources/rows.js: Removed.
fast/dom/HTMLTableElement/resources/tBodies.js: Removed.
fast/dom/HTMLTableElement/rows.html:
fast/dom/HTMLTableElement/script-tests: Added.
fast/dom/HTMLTableElement/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/HTMLTableElement/resources/TEMPLATE.html.
fast/dom/HTMLTableElement/script-tests/cellpadding-attribute.js: Copied from LayoutTests/fast/dom/HTMLTableElement/resources/cellpadding-attribute.js.
fast/dom/HTMLTableElement/script-tests/early-acid3-65-excerpt.js: Copied from LayoutTests/fast/dom/HTMLTableElement/resources/early-acid3-65-excerpt.js.
fast/dom/HTMLTableElement/script-tests/early-acid3-66-excerpt.js: Copied from LayoutTests/fast/dom/HTMLTableElement/resources/early-acid3-66-excerpt.js.
fast/dom/HTMLTableElement/script-tests/rows.js: Copied from LayoutTests/fast/dom/HTMLTableElement/resources/rows.js.
fast/dom/HTMLTableElement/script-tests/tBodies.js: Copied from LayoutTests/fast/dom/HTMLTableElement/resources/tBodies.js.
fast/dom/HTMLTableElement/tBodies.html:
fast/dom/HTMLTableRowElement/cells.html:
fast/dom/HTMLTableRowElement/resources/TEMPLATE.html: Removed.
fast/dom/HTMLTableRowElement/resources/cells.js: Removed.
fast/dom/HTMLTableRowElement/script-tests: Added.
fast/dom/HTMLTableRowElement/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/HTMLTableRowElement/resources/TEMPLATE.html.
fast/dom/HTMLTableRowElement/script-tests/cells.js: Copied from LayoutTests/fast/dom/HTMLTableRowElement/resources/cells.js.
fast/dom/HTMLTableSectionElement/resources/TEMPLATE.html: Removed.
fast/dom/HTMLTableSectionElement/resources/rows.js: Removed.
fast/dom/HTMLTableSectionElement/rows.html:
fast/dom/HTMLTableSectionElement/script-tests: Added.
fast/dom/HTMLTableSectionElement/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/HTMLTableSectionElement/resources/TEMPLATE.html.
fast/dom/HTMLTableSectionElement/script-tests/rows.js: Copied from LayoutTests/fast/dom/HTMLTableSectionElement/resources/rows.js.
fast/dom/Node/DOMNodeRemovedEvent.html:
fast/dom/Node/initial-values.html:
fast/dom/Node/resources/DOMNodeRemovedEvent.js: Removed.
fast/dom/Node/resources/TEMPLATE.html: Removed.
fast/dom/Node/resources/initial-values.js: Removed.
fast/dom/Node/script-tests: Added.
fast/dom/Node/script-tests/DOMNodeRemovedEvent.js: Copied from LayoutTests/fast/dom/Node/resources/DOMNodeRemovedEvent.js.
fast/dom/Node/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Node/resources/TEMPLATE.html.
fast/dom/Node/script-tests/initial-values.js: Copied from LayoutTests/fast/dom/Node/resources/initial-values.js.
fast/dom/Range/mutation.html:
fast/dom/Range/range-clone-empty.html:
fast/dom/Range/range-exceptions.html:
fast/dom/Range/range-insertNode-separate-endContainer.html:
fast/dom/Range/range-insertNode-splittext.html:
fast/dom/Range/range-modifycontents.html:
fast/dom/Range/resources/TEMPLATE.html: Removed.
fast/dom/Range/resources/mutation.js: Removed.
fast/dom/Range/resources/range-clone-empty.js: Removed.
fast/dom/Range/resources/range-exceptions.js: Removed.
fast/dom/Range/resources/range-insertNode-separate-endContainer.js: Removed.
fast/dom/Range/resources/range-insertNode-splittext.js: Removed.
fast/dom/Range/resources/range-modifycontents.js: Removed.
fast/dom/Range/script-tests: Added.
fast/dom/Range/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Range/resources/TEMPLATE.html.
fast/dom/Range/script-tests/mutation.js: Copied from LayoutTests/fast/dom/Range/resources/mutation.js.
fast/dom/Range/script-tests/range-clone-empty.js: Copied from LayoutTests/fast/dom/Range/resources/range-clone-empty.js.
fast/dom/Range/script-tests/range-exceptions.js: Copied from LayoutTests/fast/dom/Range/resources/range-exceptions.js.
fast/dom/Range/script-tests/range-insertNode-separate-endContainer.js: Copied from LayoutTests/fast/dom/Range/resources/range-insertNode-separate-endContainer.js.
fast/dom/Range/script-tests/range-insertNode-splittext.js: Copied from LayoutTests/fast/dom/Range/resources/range-insertNode-splittext.js.
fast/dom/Range/script-tests/range-modifycontents.js: Copied from LayoutTests/fast/dom/Range/resources/range-modifycontents.js.
fast/dom/Selection/getRangeAt.html:
fast/dom/Selection/resources/TEMPLATE.html: Removed.
fast/dom/Selection/resources/getRangeAt.js: Removed.
fast/dom/Selection/script-tests: Added.
fast/dom/Selection/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Selection/resources/TEMPLATE.html.
fast/dom/Selection/script-tests/getRangeAt.js: Copied from LayoutTests/fast/dom/Selection/resources/getRangeAt.js.
fast/dom/SelectorAPI/detached-element.html:
fast/dom/SelectorAPI/elementRoot.html:
fast/dom/SelectorAPI/id-fastpath.html:
fast/dom/SelectorAPI/resources/TEMPLATE.html: Removed.
fast/dom/SelectorAPI/resources/detached-element.js: Removed.
fast/dom/SelectorAPI/resources/elementRoot.js: Removed.
fast/dom/SelectorAPI/resources/id-fastpath.js: Removed.
fast/dom/SelectorAPI/resources/undefined-null-stringify.js: Removed.
fast/dom/SelectorAPI/resources/viewless-document.js: Removed.
fast/dom/SelectorAPI/script-tests: Added.
fast/dom/SelectorAPI/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/SelectorAPI/resources/TEMPLATE.html.
fast/dom/SelectorAPI/script-tests/detached-element.js: Copied from LayoutTests/fast/dom/SelectorAPI/resources/detached-element.js.
fast/dom/SelectorAPI/script-tests/elementRoot.js: Copied from LayoutTests/fast/dom/SelectorAPI/resources/elementRoot.js.
fast/dom/SelectorAPI/script-tests/id-fastpath.js: Copied from LayoutTests/fast/dom/SelectorAPI/resources/id-fastpath.js.
fast/dom/SelectorAPI/script-tests/undefined-null-stringify.js: Copied from LayoutTests/fast/dom/SelectorAPI/resources/undefined-null-stringify.js.
fast/dom/SelectorAPI/script-tests/viewless-document.js: Copied from LayoutTests/fast/dom/SelectorAPI/resources/viewless-document.js.
fast/dom/SelectorAPI/undefined-null-stringify.html:
fast/dom/SelectorAPI/viewless-document.html:
fast/dom/Text/replaceWholeText.html:
fast/dom/Text/resources/TEMPLATE.html: Removed.
fast/dom/Text/resources/replaceWholeText.js: Removed.
fast/dom/Text/script-tests: Added.
fast/dom/Text/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Text/resources/TEMPLATE.html.
fast/dom/Text/script-tests/replaceWholeText.js: Copied from LayoutTests/fast/dom/Text/resources/replaceWholeText.js.
fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html:
fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html:
fast/dom/Window/dispatchEvent.html:
fast/dom/Window/resources/HTMLBodyElement-window-eventListener-attributes.js: Removed.
fast/dom/Window/resources/HTMLFrameSetElement-window-eventListener-attributes.js: Removed.
fast/dom/Window/resources/TEMPLATE.html: Removed.
fast/dom/Window/resources/dispatchEvent.js: Removed.
fast/dom/Window/resources/window-custom-prototype.js: Removed.
fast/dom/Window/script-tests: Added.
fast/dom/Window/script-tests/HTMLBodyElement-window-eventListener-attributes.js: Copied from LayoutTests/fast/dom/Window/resources/HTMLBodyElement-window-eventListener-attributes.js.
fast/dom/Window/script-tests/HTMLFrameSetElement-window-eventListener-attributes.js: Copied from LayoutTests/fast/dom/Window/resources/HTMLFrameSetElement-window-eventListener-attributes.js.
fast/dom/Window/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Window/resources/TEMPLATE.html.
fast/dom/Window/script-tests/dispatchEvent.js: Copied from LayoutTests/fast/dom/Window/resources/dispatchEvent.js.
fast/dom/Window/script-tests/window-custom-prototype.js: Copied from LayoutTests/fast/dom/Window/resources/window-custom-prototype.js.
fast/dom/Window/window-custom-prototype.html:
fast/dom/constructed-objects-prototypes.html:
fast/dom/constructors-cached.html:
fast/dom/css-RGBValue.html:
fast/dom/domListEnumeration.html:
fast/dom/event-attribute-availability.html:
fast/dom/javascript-url-exception-isolation.html:
fast/dom/location-new-window-no-crash.html:
fast/dom/non-numeric-values-numeric-parameters.html:
fast/dom/prototype-inheritance-2.html:
fast/dom/prototype-inheritance.html:
fast/dom/resources/TEMPLATE.html: Removed.
fast/dom/resources/constructed-objects-prototypes.js: Removed.
fast/dom/resources/constructors-cached.js: Removed.
fast/dom/resources/css-RGBValue.js: Removed.
fast/dom/resources/domListEnumeration.js: Removed.
fast/dom/resources/event-attribute-availability.js: Removed.
fast/dom/resources/javascript-url-exception-isolation.js: Removed.
fast/dom/resources/location-new-window-no-crash.js: Removed.
fast/dom/resources/non-numeric-values-numeric-parameters.js: Removed.
fast/dom/resources/prototype-inheritance-2.js: Removed.
fast/dom/resources/prototype-inheritance.js: Removed.
fast/dom/script-tests: Added.
fast/dom/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/resources/TEMPLATE.html.
fast/dom/script-tests/constructed-objects-prototypes.js: Copied from LayoutTests/fast/dom/resources/constructed-objects-prototypes.js.
fast/dom/script-tests/constructors-cached.js: Copied from LayoutTests/fast/dom/resources/constructors-cached.js.
fast/dom/script-tests/css-RGBValue.js: Copied from LayoutTests/fast/dom/resources/css-RGBValue.js.
fast/dom/script-tests/domListEnumeration.js: Copied from LayoutTests/fast/dom/resources/domListEnumeration.js.
fast/dom/script-tests/event-attribute-availability.js: Copied from LayoutTests/fast/dom/resources/event-attribute-availability.js.
fast/dom/script-tests/javascript-url-exception-isolation.js: Copied from LayoutTests/fast/dom/resources/javascript-url-exception-isolation.js.
fast/dom/script-tests/location-new-window-no-crash.js: Copied from LayoutTests/fast/dom/resources/location-new-window-no-crash.js.
fast/dom/script-tests/non-numeric-values-numeric-parameters.js: Copied from LayoutTests/fast/dom/resources/non-numeric-values-numeric-parameters.js.
fast/dom/script-tests/prototype-inheritance-2.js: Copied from LayoutTests/fast/dom/resources/prototype-inheritance-2.js.
fast/dom/script-tests/prototype-inheritance.js: Copied from LayoutTests/fast/dom/resources/prototype-inheritance.js.

1:35 AM Changeset in webkit [48550] by hamaji@chromium.org

19 edits
20 moves
2 adds in trunk/LayoutTests

2009-09-19 Shinichiro Hamaji <hamaji@chromium.org>

Rubber-stamped by Eric Seidel.

js tests should move into jstests subdirectory instead of resources/
https://bugs.webkit.org/show_bug.cgi?id=25880

Migration for fast/canvas and fast/css directories.

fast/canvas/canvas-copyPixels.html:
fast/canvas/canvas-gradient-addStop-error.html:
fast/canvas/canvas-gradient-without-path.html:
fast/canvas/canvas-modify-emptyPath.html:
fast/canvas/canvas-set-properties-with-non-invertible-ctm.html:
fast/canvas/canvas-setTransform.html:
fast/canvas/canvas-strokeRect.html:
fast/canvas/canvas-transparency-and-composite.html:
fast/canvas/gradient-addColorStop-with-invalid-color.html:
fast/canvas/gradient-with-clip.html:
fast/canvas/linearGradient-infinite-values.html:
fast/canvas/pattern-with-transform.html:
fast/canvas/radialGradient-infinite-values.html:
fast/canvas/resources/TEMPLATE.html: Removed.
fast/canvas/resources/canvas-copyPixels.js: Removed.
fast/canvas/resources/canvas-gradient-addStop-error.js: Removed.
fast/canvas/resources/canvas-gradient-without-path.js: Removed.
fast/canvas/resources/canvas-modify-emptyPath.js: Removed.
fast/canvas/resources/canvas-set-properties-with-non-invertible-ctm.js: Removed.
fast/canvas/resources/canvas-setTransform.js: Removed.
fast/canvas/resources/canvas-strokeRect.js: Removed.
fast/canvas/resources/canvas-transparency-and-composite.js: Removed.
fast/canvas/resources/gradient-addColorStop-with-invalid-color.js: Removed.
fast/canvas/resources/gradient-with-clip.js: Removed.
fast/canvas/resources/linearGradient-infinite-values.js: Removed.
fast/canvas/resources/pattern-with-transform.js: Removed.
fast/canvas/resources/radialGradient-infinite-values.js: Removed.
fast/canvas/resources/set-colors.js: Removed.
fast/canvas/resources/translate-text.js: Removed.
fast/canvas/script-tests: Added.
fast/canvas/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/canvas/resources/TEMPLATE.html.
fast/canvas/script-tests/canvas-copyPixels.js: Copied from LayoutTests/fast/canvas/resources/canvas-copyPixels.js.
fast/canvas/script-tests/canvas-gradient-addStop-error.js: Copied from LayoutTests/fast/canvas/resources/canvas-gradient-addStop-error.js.
fast/canvas/script-tests/canvas-gradient-without-path.js: Copied from LayoutTests/fast/canvas/resources/canvas-gradient-without-path.js.
fast/canvas/script-tests/canvas-modify-emptyPath.js: Copied from LayoutTests/fast/canvas/resources/canvas-modify-emptyPath.js.
fast/canvas/script-tests/canvas-set-properties-with-non-invertible-ctm.js: Copied from LayoutTests/fast/canvas/resources/canvas-set-properties-with-non-invertible-ctm.js.
fast/canvas/script-tests/canvas-setTransform.js: Copied from LayoutTests/fast/canvas/resources/canvas-setTransform.js.
fast/canvas/script-tests/canvas-strokeRect.js: Copied from LayoutTests/fast/canvas/resources/canvas-strokeRect.js.
fast/canvas/script-tests/canvas-transparency-and-composite.js: Copied from LayoutTests/fast/canvas/resources/canvas-transparency-and-composite.js.
fast/canvas/script-tests/gradient-addColorStop-with-invalid-color.js: Copied from LayoutTests/fast/canvas/resources/gradient-addColorStop-with-invalid-color.js.
fast/canvas/script-tests/gradient-with-clip.js: Copied from LayoutTests/fast/canvas/resources/gradient-with-clip.js.
fast/canvas/script-tests/linearGradient-infinite-values.js: Copied from LayoutTests/fast/canvas/resources/linearGradient-infinite-values.js.
fast/canvas/script-tests/pattern-with-transform.js: Copied from LayoutTests/fast/canvas/resources/pattern-with-transform.js.
fast/canvas/script-tests/radialGradient-infinite-values.js: Copied from LayoutTests/fast/canvas/resources/radialGradient-infinite-values.js.
fast/canvas/script-tests/set-colors.js: Copied from LayoutTests/fast/canvas/resources/set-colors.js.
fast/canvas/script-tests/translate-text.js: Copied from LayoutTests/fast/canvas/resources/translate-text.js.
fast/canvas/set-colors.html:
fast/canvas/translate-text.html:
fast/css/getComputedStyle/computed-style-font-family-monospace.html:
fast/css/getComputedStyle/font-family-fallback-reset.html:
fast/css/getComputedStyle/getComputedStyle-text-decoration.html:
fast/css/getComputedStyle/resources/TEMPLATE.html: Removed.
fast/css/getComputedStyle/resources/computed-style-font-family-monospace.js: Removed.
fast/css/getComputedStyle/resources/font-family-fallback-reset.js: Removed.
fast/css/getComputedStyle/resources/getComputedStyle-text-decoration.js: Removed.
fast/css/getComputedStyle/script-tests: Added.
fast/css/getComputedStyle/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/css/getComputedStyle/resources/TEMPLATE.html.
fast/css/getComputedStyle/script-tests/computed-style-font-family-monospace.js: Copied from LayoutTests/fast/css/getComputedStyle/resources/computed-style-font-family-monospace.js.
fast/css/getComputedStyle/script-tests/font-family-fallback-reset.js: Copied from LayoutTests/fast/css/getComputedStyle/resources/font-family-fallback-reset.js.
fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js: Copied from LayoutTests/fast/css/getComputedStyle/resources/getComputedStyle-text-decoration.js.

12:30 AM Changeset in webkit [48549] by hamaji@chromium.org

10 edits
14 moves
5 adds in trunk/LayoutTests

2009-09-19 Shinichiro Hamaji <hamaji@chromium.org>

Rubber-stamped by Eric Seidel.

js tests should move into jstests subdirectory instead of resources/
https://bugs.webkit.org/show_bug.cgi?id=25880

Migration for editing directory.

editing/inserting/font-size-clears-from-typing-style.html:
editing/inserting/resources/TEMPLATE.html: Removed.
editing/inserting/resources/font-size-clears-from-typing-style.js: Removed.
editing/inserting/script-tests: Added.
editing/inserting/script-tests/TEMPLATE.html: Copied from LayoutTests/editing/inserting/resources/TEMPLATE.html.
editing/inserting/script-tests/font-size-clears-from-typing-style.js: Copied from LayoutTests/editing/inserting/resources/font-size-clears-from-typing-style.js.
editing/pasteboard/file-input-files-access.html:
editing/pasteboard/files-during-page-drags.html:
editing/pasteboard/get-data-text-plain-paste.html:
editing/pasteboard/resources/TEMPLATE.html: Removed.
editing/pasteboard/resources/file-input-files-access.js: Removed.
editing/pasteboard/resources/files-during-page-drags.js: Removed.
editing/pasteboard/resources/get-data-text-plain-paste.js: Removed.
editing/pasteboard/script-tests: Added.
editing/pasteboard/script-tests/TEMPLATE.html: Copied from LayoutTests/editing/pasteboard/resources/TEMPLATE.html.
editing/pasteboard/script-tests/file-input-files-access.js: Copied from LayoutTests/editing/pasteboard/resources/file-input-files-access.js.
editing/pasteboard/script-tests/files-during-page-drags.js: Copied from LayoutTests/editing/pasteboard/resources/files-during-page-drags.js.
editing/pasteboard/script-tests/get-data-text-plain-paste.js: Copied from LayoutTests/editing/pasteboard/resources/get-data-text-plain-paste.js.
editing/selection/click-in-margins-inside-editable-div.html:
editing/selection/click-in-padding-with-multiple-line-boxes.html:
editing/selection/click-outside-editable-div.html:
editing/selection/resources/TEMPLATE.html: Removed.
editing/selection/resources/click-in-margins-inside-editable-div.js: Removed.
editing/selection/resources/click-in-padding-with-multiple-line-boxes.js: Removed.
editing/selection/resources/click-outside-editable-div.js: Removed.
editing/selection/script-tests: Added.
editing/selection/script-tests/TEMPLATE.html: Copied from LayoutTests/editing/selection/resources/TEMPLATE.html.
editing/selection/script-tests/click-in-margins-inside-editable-div.js: Copied from LayoutTests/editing/selection/resources/click-in-margins-inside-editable-div.js.
editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js: Copied from LayoutTests/editing/selection/resources/click-in-padding-with-multiple-line-boxes.js.
editing/selection/script-tests/click-outside-editable-div.js: Copied from LayoutTests/editing/selection/resources/click-outside-editable-div.js.
editing/style/resources/TEMPLATE.html: Removed.
editing/style/resources/text-decoration-state.js: Removed.
editing/style/script-tests: Added.
editing/style/script-tests/TEMPLATE.html: Copied from LayoutTests/editing/style/resources/TEMPLATE.html.
editing/style/script-tests/text-decoration-state.js: Copied from LayoutTests/editing/style/resources/text-decoration-state.js.
editing/style/text-decoration-state.html:
editing/text-iterator/basic-iteration.html:
editing/text-iterator/resources/TEMPLATE.html: Removed.
editing/text-iterator/resources/basic-iteration.js: Removed.
editing/text-iterator/script-tests: Added.
editing/text-iterator/script-tests/TEMPLATE.html: Copied from LayoutTests/editing/text-iterator/resources/TEMPLATE.html.
editing/text-iterator/script-tests/basic-iteration.js: Copied from LayoutTests/editing/text-iterator/resources/basic-iteration.js.

12:22 AM Changeset in webkit [48548] by hamaji@chromium.org

11 edits
11 moves
1 add in trunk/LayoutTests

2009-09-19 Shinichiro Hamaji <hamaji@chromium.org>

Rubber-stamped by Eric Seidel.

js tests should move into jstests subdirectory instead of resources/
https://bugs.webkit.org/show_bug.cgi?id=25880

Attempt to split the huge patch as I failed to commit it...

editing/execCommand/break-out-of-empty-list-item.html:
editing/execCommand/convert-style-elements-to-spans.html:
editing/execCommand/empty-span-removal.html:
editing/execCommand/enabling-and-selection-2.html:
editing/execCommand/enabling-and-selection.html:
editing/execCommand/inline-style-after-indentoutdent.html:
editing/execCommand/resources/TEMPLATE.html: Removed.
editing/execCommand/resources/break-out-of-empty-list-item.js: Removed.
editing/execCommand/resources/convert-style-elements-to-spans.js: Removed.
editing/execCommand/resources/empty-span-removal.js: Removed.
editing/execCommand/resources/enabling-and-selection-2.js: Removed.
editing/execCommand/resources/enabling-and-selection.js: Removed.
editing/execCommand/resources/inline-style-after-indentoutdent.js: Removed.
editing/execCommand/resources/toggle-compound-styles.js: Removed.
editing/execCommand/resources/toggle-style-2.js: Removed.
editing/execCommand/resources/toggle-styles.js: Removed.
editing/execCommand/resources/toggle-text-decorations.js: Removed.
editing/execCommand/script-tests: Added.
editing/execCommand/script-tests/TEMPLATE.html: Copied from LayoutTests/editing/execCommand/resources/TEMPLATE.html.
editing/execCommand/script-tests/break-out-of-empty-list-item.js: Copied from LayoutTests/editing/execCommand/resources/break-out-of-empty-list-item.js.
editing/execCommand/script-tests/convert-style-elements-to-spans.js: Copied from LayoutTests/editing/execCommand/resources/convert-style-elements-to-spans.js.
editing/execCommand/script-tests/empty-span-removal.js: Copied from LayoutTests/editing/execCommand/resources/empty-span-removal.js.
editing/execCommand/script-tests/enabling-and-selection-2.js: Copied from LayoutTests/editing/execCommand/resources/enabling-and-selection-2.js.
editing/execCommand/script-tests/enabling-and-selection.js: Copied from LayoutTests/editing/execCommand/resources/enabling-and-selection.js.
editing/execCommand/script-tests/inline-style-after-indentoutdent.js: Copied from LayoutTests/editing/execCommand/resources/inline-style-after-indentoutdent.js.
editing/execCommand/script-tests/toggle-compound-styles.js: Copied from LayoutTests/editing/execCommand/resources/toggle-compound-styles.js.
editing/execCommand/script-tests/toggle-style-2.js: Copied from LayoutTests/editing/execCommand/resources/toggle-style-2.js.
editing/execCommand/script-tests/toggle-styles.js: Copied from LayoutTests/editing/execCommand/resources/toggle-styles.js.
editing/execCommand/script-tests/toggle-text-decorations.js: Copied from LayoutTests/editing/execCommand/resources/toggle-text-decorations.js.
editing/execCommand/toggle-compound-styles.html:
editing/execCommand/toggle-style-2.html:
editing/execCommand/toggle-styles.html:
editing/execCommand/toggle-text-decorations.html:

Sep 18, 2009:

8:46 PM Changeset in webkit [48547] by Simon Fraser

2 edits in trunk/WebCore

2009-09-18 Simon Fraser <Simon Fraser>

Fix stylistic issue raised in code review for previous commit.

rendering/RenderLayerBacking.cpp: (WebCore::hasNonZeroTransformOrigin):

8:44 PM Changeset in webkit [48546] by Simon Fraser

5 edits
4 adds in trunk

2009-09-18 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Element is misplaced during opacity transition with certain configuration of transform-origin and clipping
https://bugs.webkit.org/show_bug.cgi?id=29495

If an element has zero size, but has a transform origin with absolute values,
then the transform origin would not be applied because it is implemented via
anchorPoint, which is expressed as a fraction of the layer size.

Work around this by artificially inflating the size of the backing store when we need to.

Test: compositing/geometry/transfrom-origin-on-zero-size-layer.html

rendering/RenderLayerBacking.h:
rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): Init m_artificiallyInflatedBounds to false.

(WebCore::hasNonZeroTransformOrigin):
Utility function that describes whether the transform-origin contains non-percentage
x or y offsets.

(WebCore::RenderLayerBacking::updateCompositedBounds):
New wrapper method around setCompositedBounds() that applies the size inflation
when necessary, setting the m_artificiallyInflatedBounds as appropriate.

(WebCore::RenderLayerBacking::updateAfterLayout): Call updateCompositedBounds().
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Ditto

rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Ditto (WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry): Ditto

6:19 PM Changeset in webkit [48545] by Antti Koivisto

2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=29512
Don't recalculate style when restoring from the page cache

Patch by Antti Koivisto <Antti Koivisto> on 2009-09-18
Reviewed by Maciej Stachowiak.

FrameLoaderClient::forceLayout() also forces style recalc. Instead call FrameView::forceLayout()
directly to update the scrollbars while keeping the existing style.

Makes back/forward really fast on complex pages (in cases where page cache works).

loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

5:21 PM Changeset in webkit [48544] by kevino@webkit.org

3 edits in trunk/WebKitTools

wx build fixes. Fix the config name under git and allow users to specify
their own waf install for experimenting with new versions.

5:18 PM Changeset in webkit [48543] by atwilson@chromium.org

3 edits in trunk/LayoutTests

REGRESSION: fast/workers/worker-cloneport.html failing intermttently on leopard bot
https://bugs.webkit.org/show_bug.cgi?id=29341

Reviewed by Eric Seidel.

fast/workers/worker-cloneport-expected.txt:

Updated to reflect new output (lower clone count threshold).

fast/workers/worker-cloneport.html:

Updated test to have a more lenient performance requirement and timeout, to address flakiness on Leopard and Chromium.

4:12 PM Changeset in webkit [48542] by oliver@apple.com

25 edits
6 adds in trunk

Implement ES5 Object.defineProperty function
https://bugs.webkit.org/show_bug.cgi?id=29503

Reviewed by Geoff Garen

Implement Object.defineProperty. This requires adding the API to
ObjectConstructor, along with a helper function that implements the
ES5 internal ToPropertyDescriptor function. It then adds
JSObject::defineOwnProperty that implements the appropriate ES5 semantics.
Currently defineOwnProperty uses a delete followed by a put to redefine
attributes of a property, clearly this is less efficient than it could be
but we can improve this if it needs to be possible in future.

3:25 PM Changeset in webkit [48541] by beidson@apple.com

8 edits in trunk/LayoutTests

Speculative fix for:
https://bugs.webkit.org/show_bug.cgi?id=29322
and
https://bugs.webkit.org/show_bug.cgi?id=29505

Reviewed by Alexey Proskuryakov.

Adding a "Connection: close" header might make the tests work more reliably,
and doesn't seem to make anything worse: They all continue to pass on my machine!

http/tests/loading/resources/basic-auth-testing.php:
http/tests/loading/resources/othersubresources/protected-resource.php:
http/tests/loading/resources/protected-resource.php:
http/tests/loading/resources/subresources/protected-resource.php:
http/tests/xmlhttprequest/resources/cross-origin-authorization.php:
http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php:
http/tests/xmlhttprequest/resources/cross-origin-no-authorization.php:

3:24 PM Changeset in webkit [48540] by ap@apple.com

2 edits
1 add in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=29510
Active DOM objects should be suspended while a modal dialog is displayed

manual-tests/js-timers-beneath-modal-dialog.html: Added a test for JS timers.

page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer): Match other platforms, and make Mac also suspend active DOM objects. Since a page that currently displays a modal dialog cannot go into page cache, there is no danger of suspending an object twice.

3:20 PM Changeset in webkit [48539] by eric@webkit.org

28 edits in trunk/LayoutTests

2009-09-18 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Carlson.

Media layout tests should have a way to provide test files in different formats
https://bugs.webkit.org/show_bug.cgi?id=28327

Updating 25 media layout tests to use media files based on supported codecs.

media/progress-event-at-least-one.html: Use findMediaFile() to locate a supported media file.
media/video-pause-empty-events.html: ditto.
media/video-play-empty-events.html: ditto.
media/video-play-pause-events.html: ditto.
media/video-played-collapse.html: ditto.
media/video-played-ranges-1.html: ditto.
media/video-played-reset.html: ditto.
media/video-played.js: ditto. (videoPlayedMain):
media/video-seek-past-end-paused.html: ditto.
media/video-seek-past-end-playing.html: ditto.
media/video-seekable.html: ditto.
media/video-seeking.html: ditto.
media/video-size.html: ditto.
media/video-source-error.html: ditto.
media/video-source-type-params.html: ditto.
media/video-source-type.html: ditto.
media/video-source.html: ditto.
media/video-src-change.html: ditto.
media/video-src-invalid-remove.html: ditto.
media/video-src-remove.html: ditto. Use counting.mp4 instead of silence.mpg.
media/video-src-remove-expected.txt: Updated results.
media/video-src-set.html: ditto.
media/video-src-source.html: ditto.
media/video-src.html: ditto.
media/video-timeupdate-during-playback.html: ditto.
media/video-volume.html: ditto.
media/video-zoom.html: ditto.

3:12 PM Changeset in webkit [48538] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-18 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Eric Seidel.

[Qt] Buildfix caused by http://trac.webkit.org/changeset/48513
https://bugs.webkit.org/show_bug.cgi?id=29351

bridge/qt/qt_instance.h: createRuntimeObject method renamed to newRuntimeObject.
bridge/runtime.h: Visibility of newRuntimeObject method modified to protected.

3:04 PM Changeset in webkit [48537] by andersca@apple.com

2 edits in trunk/LayoutTests

Add failing tests to the skipped list.

platform/mac-snowleopard/Skipped:

2:58 PM Changeset in webkit [48536] by eric@webkit.org

4 edits in trunk/WebCore

2009-09-18 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Fix parameter substitutions in console.log().

https://bugs.webkit.org/show_bug.cgi?id=29366

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._format):
inspector/front-end/InjectedScript.js: (InjectedScript.getPrototypes): (InjectedScript.CallFrameProxy.prototype._wrapScopeChain):
inspector/front-end/utilities.js: ():

2:39 PM Changeset in webkit [48535] by mrowe@apple.com

4 edits in trunk

Versioning.

2:36 PM Changeset in webkit [48534] by mrowe@apple.com

1 copy in tags/Safari-532.0

New tag.

2:34 PM Changeset in webkit [48533] by weinig@apple.com

2 edits in trunk/WebCore

Temporarily remove an assertion that was getting hit when going
back to a page in the page cache while a banner in Safari was visible.
We should re-enable this once that is fixed. See <rdar://problem/7218118>

Reviewed by Geoffrey Garen and Brady Eidson.

page/FrameView.cpp:

(WebCore::FrameView::scheduleRelayout):

2:28 PM Changeset in webkit [48532] by andersca@apple.com

2 edits in trunk/WebCore

Try fixing the build again.

platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::wndProc):

2:23 PM Changeset in webkit [48531] by andersca@apple.com

2 edits in trunk/WebCore

Fix windows build.

platform/win/PopupMenuWin.cpp:

1:56 PM Changeset in webkit [48530] by weinig@apple.com

3 edits in trunk/WebCore

Convert another callback type object to store the global object
instead of the frame.

Reviewed by Gavin 'BearClaw' Barraclough.

bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::create):
(WebCore::JSCustomXPathNSResolver::JSCustomXPathNSResolver):
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

bindings/js/JSCustomXPathNSResolver.h:

1:52 PM Changeset in webkit [48529] by andersca@apple.com

2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=29332
<rdar://problem/7231652>
REGRESSION (r48446): While a <select> popup menu is open, the
rest of the WebView doesn't respond to mouse move events.

Reviewed by Sam Weinig.

platform/win/PopupMenuWin.cpp:

(WebCore::translatePoint):
New helper function that translates a point between HWND coordinates.

(WebCore::PopupMenu::show):
Protect the PopupMenu if someone removes the <select> in response to a mouse
event. Handle WM_HOST_WINDOW_MOUSEMOVE events.

(WebCore::PopupMenu::wndProc):
in the WM_MOUSEMOVE handler, if the mouse is not over the popup, post a
WM_HOST_WINDOW_MOUSEMOVE event so that the host window (the WebView) gets the
mouse move event.

1:49 PM Changeset in webkit [48528] by eric@webkit.org

12 edits in trunk/WebKit/qt

2009-09-18 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Eric Seidel.

Corrected the Symbian specific UID3 values to be assigned
from the "unprotected" pool that permits self-signing of
those test and demo executables. (Added new UID3 values
where they were missing for new components.)

QGVLauncher/QGVLauncher.pro:
QtLauncher/QtLauncher.pro:
tests/benchmarks/loading/tst_loading.pro:
tests/benchmarks/painting/tst_painting.pro:
tests/qwebelement/qwebelement.pro:
tests/qwebframe/qwebframe.pro:
tests/qwebhistory/qwebhistory.pro:
tests/qwebhistoryinterface/qwebhistoryinterface.pro:
tests/qwebpage/qwebpage.pro:
tests/qwebplugindatabase/qwebplugindatabase.pro:
tests/qwebview/qwebview.pro:

1:35 PM Changeset in webkit [48527] by barraclough@apple.com

4 edits in trunk/JavaScriptCore

2009-09-18 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Build fix to enable ARM_THUMB2 on Linux
https://bugs.webkit.org/show_bug.cgi?id=

jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
jit/JITStubs.cpp:
wtf/Platform.h:

1:30 PM Changeset in webkit [48526] by Simon Fraser

7 edits
4 adds in trunk

2009-09-18 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Compositing layers are incorrectly positioned after scrolling with position:fixed
https://bugs.webkit.org/show_bug.cgi?id=29262

When scrolling a page with compositing layers inside a position:fixed element,
we need to update the compositing layer positions when the scroll position changes.

Test: compositing/geometry/fixed-position.html

WebCore.base.exp: Export FrameView::scrollPositionChanged()

page/FrameView.h:
page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged): New method that sends the scroll event, and updates compositing layers positions if necessary.

1:18 PM Changeset in webkit [48525] by barraclough@apple.com

16 edits in trunk/JavaScriptCore

2009-09-18 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Defines two pseudo-platforms for ARM and Thumb-2 instruction set.
https://bugs.webkit.org/show_bug.cgi?id=29122

Introduces WTF_PLATFORM_ARM_TRADITIONAL and WTF_PLATFORM_ARM_THUMB2
macros on ARM platforms. The PLATFORM(ARM_THUMB2) should be used
when Thumb-2 instruction set is the required target. The
PLATFORM(ARM_TRADITIONAL) is for generic ARM instruction set. In
case where the code is common the PLATFORM(ARM) have to be used.

assembler/ARMAssembler.cpp:
assembler/ARMAssembler.h:
assembler/ARMv7Assembler.h:
assembler/MacroAssembler.h:
assembler/MacroAssemblerARM.cpp:
assembler/MacroAssemblerARM.h:
assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
jit/ExecutableAllocator.h:
jit/JIT.h:
jit/JITInlineMethods.h: (JSC::JIT::beginUninterruptedSequence): (JSC::JIT::preserveReturnAddressAfterCall): (JSC::JIT::restoreReturnAddressBeforeReturn): (JSC::JIT::restoreArgumentReference): (JSC::JIT::restoreArgumentReferenceForTrampoline):
jit/JITOpcodes.cpp:
jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
jit/JITStubs.h:
wtf/Platform.h:
yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter):

1:15 PM Changeset in webkit [48524] by Simon Fraser

4 edits
4 adds in trunk

2009-09-18 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Transformed elements inside position:fixed container are clipped incorrectly
https://bugs.webkit.org/show_bug.cgi?id=29346

Fix clipping and hit testing on transformed elements inside a position:fixed element.
Previously, the code used the overflowClipRect of the parent clip rects, but
this is not correct for fixed postion elements. Instead, share code that is
already present in calculateRects() to get the correct rect.

Test: fast/overflow/position-fixed-transform-clipping.html

rendering/RenderLayer.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): Call the new backgroundClipRect() to get the correct clipRect.

(WebCore::RenderLayer::backgroundClipRect):
New method, factored out of calculateRects(), that computes the clip rect,
doing the right thing for fixed position elements.

(WebCore::RenderLayer::calculateRects):
Call the new backgroundClipRect() method.

12:41 PM Changeset in webkit [48523] by mitz@apple.com

2 edits in trunk/LayoutTests

Updated test result for <rdar://problem/7050773>

platform/mac/accessibility/document-attributes-expected.txt:

12:06 PM Changeset in webkit [48522] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-09-18 Alex Milowski <alex@milowski.com>

Reviewed by Maciej Stachowiak.

Added checkWebCoreMathMLSupport and hasMathMLSupport to support
checking for whether MathML tests should be run

Scripts/run-webkit-tests:
Scripts/webkitdirs.pm:

12:00 PM Changeset in webkit [48521] by mitz@apple.com

4 edits
2 adds in trunk

WebCore: Fix <rdar://problem/7050773> REGRESSION (r40098) Crash at
WebCore::RenderBlock::layoutBlock()
https://bugs.webkit.org/show_bug.cgi?id=29498

Reviewed by Darin Adler.

Test: accessibility/nested-layout-crash.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::updateBackingStore): Changed to

call Document::updateLayoutIgnorePendingStylesheets() instead of
calling RenderObject::layoutIfNeeded(). The latter requires that
there be no pending style recalc, which allows methods that call
Document::updateLayout() to be called during layout without risking
re-entry into layout.

accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityActionNames]): Null-check

m_object after calling updateBackingStore(), since style recalc may
destroy the renderer, which destroys the accessibility object and
detaches it from the wrapper.

(-[AccessibilityObjectWrapper accessibilityAttributeNames]): Ditto.
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]): Ditto.
(-[AccessibilityObjectWrapper accessibilityFocusedUIElement]): Ditto.
(-[AccessibilityObjectWrapper accessibilityHitTest:]): Ditto.
(-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):

Ditto.

(-[AccessibilityObjectWrapper accessibilityIsIgnored]): Ditto.
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):

Ditto.

(-[AccessibilityObjectWrapper accessibilityPerformPressAction]): Ditto.
(-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):

Ditto.

(-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):

Ditto.

(-[AccessibilityObjectWrapper accessibilityPerformAction:]): Ditto.
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):

Ditto.

(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Ditto.

(-[AccessibilityObjectWrapper accessibilityIndexOfChild:]): Ditto.
(-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):

Ditto.

(-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

Ditto.

LayoutTests: Test for <rdar://problem/7050773> REGRESSION (r40098) Crash at
WebCore::RenderBlock::layoutBlock()
https://bugs.webkit.org/show_bug.cgi?id=29498

Reviewed by Darin Adler.

accessibility/nested-layout-crash-expected.txt: Added.
accessibility/nested-layout-crash.html: Added.

11:57 AM Changeset in webkit [48520] by eric@webkit.org

2 edits
3 adds in trunk/WebCore

2009-09-18 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Simon Hausmann.

Update Qt build system for Web Socket.
https://bugs.webkit.org/show_bug.cgi?id=29270

WebCore.pro:
platform/network/qt/SocketStreamError.h: Added.
platform/network/qt/SocketStreamHandle.h: Added.
platform/network/qt/SocketStreamHandleSoup.cpp: Added.

11:45 AM Changeset in webkit [48519] by eric.carlson@apple.com

3 edits in trunk/WebCore

2009-09-18 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

NULL check HTMLMediaElement::m_playedTimeRanges.
Fix for https://bugs.webkit.org/show_bug.cgi?id=29494

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::addPlayedRange): New. Create m_playedTimeRanges if necessary, add range specified. (WebCore::HTMLMediaElement::seek): Use addPlayedRange. (WebCore::HTMLMediaElement::played): Use addPlayedRange. Change time comparison to be more readable. (WebCore::HTMLMediaElement::updatePlayState): Ditto.
html/HTMLMediaElement.h:

11:30 AM Changeset in webkit [48518] by xan@webkit.org

1 edit
1 add in trunk/WebKit/gtk

2009-09-18 Xan Lopez <xlopez@igalia.com>

Build fix.

Add missing file to the repository.

tests/testhittestresult.c: Added. (test_info_new): (test_info_destroy): (hit_test_result_fixture_setup): (hit_test_result_fixture_teardown): (load_status_cb): (test_webkit_hit_test_result): (main):

11:17 AM Changeset in webkit [48517] by Darin Adler

1 edit in trunk/WebKitTools/ChangeLog

Added bug number.

11:16 AM Changeset in webkit [48516] by Darin Adler

2 edits in trunk/WebKitTools

Some small steps toward improving run-webkit-tests. My goal is to
refactor much more of the script into functions. Later we can add
parallel test running to the tool. But better structure may help
even if someone decides to translate this into another scripting
language instead.

Patch by Darin Adler <Darin Adler> on 2009-08-28
Reviewed by Mark Rowe.

Scripts/run-webkit-tests: Break more pieces of the script into

seprate functions. Added readSkippedFiles, findTestsToRun, and
printResults functions. Removed custom code to skip results.html
and instead just put it into the ignoredFiles hash. Fixed some
indentation. Sorted function declarations, global variables,
and options at the top of the file alphabetically so they're not
in a semi-random order.

11:01 AM Changeset in webkit [48515] by weinig@apple.com

3 edits
2 adds in trunk

WebCore: Follow up fix for https://bugs.webkit.org/show_bug.cgi?id=29276
REGRESSION(r48334): WebKit crashes on file select by drag

Reviewed by Adele Peterson.

Don't use Document.elementFromPoint since it returns null if the point
is outside the viewport. Instead, just hit test ourselves.

Test: fast/events/drag-file-crash.html

page/DragController.cpp:

(WebCore::elementUnderMouse):
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=29276
REGRESSION(r48334): WebKit crashes on file select by drag

Reviewed by Adele Peterson.

fast/events/drag-file-crash-expected.txt: Added.
fast/events/drag-file-crash.html: Added.

10:48 AM Changeset in webkit [48514] by Darin Adler

1 edit in trunk/WebCore/ChangeLog

Fix date on a change log entry.

10:48 AM Changeset in webkit [48513] by Darin Adler

11 edits in trunk/WebCore

Each wrapped Objective-C object should use a single RuntimeObjectImp
https://bugs.webkit.org/show_bug.cgi?id=29351
rdar://problem/7142294

Patch by Darin Adler <Darin Adler> on 2009-09-18
Reviewed by Sam Weinig.

WebCore.base.exp: Added a newly-needed exported symbol.

bindings/objc/DOMInternal.h: Eliminated unused

createWrapperCacheWithIntegerKeys; it has not been needed since the
RGBColor wrappers were reworked.

bindings/objc/DOMInternal.mm: Ditto.

bridge/objc/objc_instance.h: Made the create function non-inline.
bridge/objc/objc_instance.mm:

(createInstanceWrapperCache): Added. Creates an appropriate map table.
(ObjcInstance::create): Moved here from header. Uses NSMapGet and
NSMapInsert to cache the instance in a map table.
(ObjcInstance::~ObjcInstance): Added a call to NSMapRemove to remove
the instance from the map table.

bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::~QtInstance): Remove unneeded code to remove
the instance from cachedObjects, which no longer exists.
(JSC::Bindings::QtInstance::newRuntimeObject): Renamed to overload new
bottleneck. Caching is now handled by the base class.

bridge/runtime.cpp:

(JSC::Bindings::Instance::Instance): Initialize m_runtimeObject to 0.
(JSC::Bindings::Instance::~Instance): Assert m_runtimeObject is 0.
(JSC::Bindings::Instance::createRuntimeObject): Use m_runtimeObject
if it's already set. Set m_runtimeObject and call addRuntimeObject
if it's not.
(JSC::Bindings::Instance::newRuntimeObject): Added. Virtual function,
used only by createRuntimeObject.
(JSC::Bindings::Instance::willDestroyRuntimeObject): Added.
Calls removeRuntimeObject and then clears m_runtimeObject.
(JSC::Bindings::Instance::willInvalidateRuntimeObject): Added.
Clears m_runtimeObject.

bridge/runtime.h: Made createRuntimeObject non-virtual. Added

willDestroyRuntimeObject, willInvalidateRuntimeObject,
newRuntimeObject, and m_runtimeObject.

bridge/runtime_object.cpp:

(JSC::RuntimeObjectImp::RuntimeObjectImp): Removed addRuntimeObject
call, now handled by caller.
(JSC::RuntimeObjectImp::~RuntimeObjectImp): Replaced removeRuntimeObject
call with willDestroyRuntimeObject call; the latter nows calls
removeRuntimeObject.
(JSC::RuntimeObjectImp::invalidate): Added willInvalidateRuntimeObject
call.

bridge/runtime_object.h: Made invalidate non-virtual.

10:46 AM Changeset in webkit [48512] by kenneth@webkit.org

2 edits in trunk/WebKit/gtk

[Gtk] Unreviewed build fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-18

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::platformPageClient):

10:34 AM Changeset in webkit [48511] by kenneth@webkit.org

47 edits in trunk

Make PlatformWindow return something else than PlatformWidget
https://bugs.webkit.org/show_bug.cgi?id=29085

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-17
Reviewed by Simon Hausmann.

WebCore:

Make platformWindow return a PlatformPageClient
(for now typedef'ed to PlatformWidget)

Also, change the name of platformWindow to platformPageClient()

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(getPangoLayoutForAtk):

accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):

loader/EmptyClients.h:

(WebCore::EmptyChromeClient::platformPageClient):

page/Chrome.cpp:

(WebCore::Chrome::platformPageClient):

page/Chrome.h:
page/ChromeClient.h:
page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::wheelEvent):
(WebCore::EventHandler::currentPlatformMouseEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::eventMayStartDrag):

platform/HostWindow.h:
platform/Widget.h:
platform/gtk/PlatformScreenGtk.cpp:

(WebCore::getVisual):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenu::show):

platform/gtk/ScrollViewGtk.cpp:

(WebCore::ScrollView::platformAddChild):
(WebCore::ScrollView::platformRemoveChild):
(WebCore::ScrollView::visibleContentRect):

platform/gtk/WidgetGtk.cpp:

(WebCore::Widget::setFocus):
(WebCore::Widget::setCursor):

platform/qt/PlatformScreenQt.cpp:

(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

platform/qt/PopupMenuQt.cpp:

(WebCore::PopupMenu::show):

platform/qt/WidgetQt.cpp:

(WebCore::Widget::setCursor):

platform/win/PlatformScreenWin.cpp:

(WebCore::monitorInfoForWidget):

platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::show):
(WebCore::PopupMenu::calculatePositionAndSize):
(WebCore::PopupMenu::wndProc):

platform/wx/RenderThemeWx.cpp:

(WebCore::nativeWindowForRenderObject):

platform/wx/ScrollbarThemeWx.cpp:

(WebCore::ScrollbarThemeWx::paint):

plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::getValue):
(WebCore::PluginView::forceRedraw):
(WebCore::PluginView::platformStart):

plugins/mac/PluginViewMac.cpp:

(WebCore::PluginView::platformStart):

plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::getValue):
(WebCore::PluginView::platformStart):

plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::getValue):
(WebCore::PluginView::forceRedraw):
(WebCore::PluginView::platformStart):

WebKit/gtk:

Reflect the rename of platformWindow and it's return type.

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::platformPageClient):
(WebKit::ChromeClient::runOpenPanel):

WebCoreSupport/ChromeClientGtk.h:
webkit/webkitprivate.cpp:

(currentToplevelCallback):

webkit/webkitwebview.cpp:

(webkit_web_view_popup_menu_handler):

WebKit/haiku:

Reflect the rename of platformWindow and it's return type.

WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientHaiku::platformPageClient):

WebCoreSupport/ChromeClientHaiku.h:

WebKit/mac:

Reflect the rename of platformWindow and it's return type.

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::platformPageClient):

WebKit/qt:

Reflect the rename of platformWindow and it's return type.

WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::platformPageClient):

WebCoreSupport/ChromeClientQt.h:

WebKit/win:

Reflect the rename of platformWindow and it's return type.

AccessibleBase.cpp:

(AccessibleBase::get_accParent):

WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::platformPageClient):

WebCoreSupport/WebChromeClient.h:

WebKit/wx:

Reflect the rename of platformWindow and it's return type.

WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::platformPageClient):

WebKitSupport/ChromeClientWx.h:
WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::isEditable):
(WebCore::EditorClientWx::registerCommandForUndo):
(WebCore::EditorClientWx::registerCommandForRedo):
(WebCore::EditorClientWx::clearUndoRedoOperations):
(WebCore::EditorClientWx::canUndo):
(WebCore::EditorClientWx::canRedo):
(WebCore::EditorClientWx::undo):
(WebCore::EditorClientWx::redo):

8:47 AM Changeset in webkit [48510] by Simon Hausmann

3 edits in trunk/WebCore

[Qt] Web inspector UI adjustments specific to the Qt platform:

Hide the close button
Hide the dock button
Disable the draggable toolbar

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-18
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29384

inspector/front-end/inspector.css:
inspector/front-end/inspector.js:

(WebInspector.toolbarDragStart):

8:34 AM Changeset in webkit [48509] by Simon Hausmann

3 edits in trunk/JavaScriptCore

Fix the Qt/Windows CE build.

Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-18
Reviewed by Simon Hausmann.

JavaScriptCore.pri: Build the ce_time.cpp functions from

within Qt externally.

wtf/DateMath.cpp: Removed unnecessary Qt #ifdef, for the

Qt build these functions are no external, too.

7:28 AM Changeset in webkit [48508] by Simon Hausmann

6 edits in trunk/WebCore

QtWebKit Windows CE compile fixes

Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-18
Reviewed by Simon Hausmann.

Exclude certain pure-WINCE specific code paths from the Qt build.

platform/graphics/BitmapImage.h:
platform/graphics/FontCache.h:
platform/graphics/MediaPlayer.cpp:
platform/text/TextEncodingRegistry.cpp:

(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):

plugins/PluginView.cpp:

(WebCore::PluginView::stop): Guard this code block with NETSCAPE_PLUGIN_API as
the corresponding PluginViewWndProc has the same guard in the header file.

7:08 AM Changeset in webkit [48507] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

Document webkit_web_view_stop_loading.

webkit/webkitwebview.cpp:

6:53 AM Changeset in webkit [48506] by xan@webkit.org

5 edits in trunk

2009-09-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha and Jan Alonzo.

[GTK] context menu overriding API is very limited
https://bugs.webkit.org/show_bug.cgi?id=27546

Add new tests to the build.

GNUmakefile.am:

WebKit/gtk:

2009-09-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha and Jan Alonzo.

[GTK] context menu overriding API is very limited
https://bugs.webkit.org/show_bug.cgi?id=27546

Add webkit_web_view_get_hit_test_result, a function to get a hit
test result from a GdkEventButton. Useful to let applications
decide between several actions on button press depending on what
is being pressed.

webkit/webkitwebview.cpp: (webkit_web_view_stop_loading): (documentPointForWindowPoint): (webkit_web_view_get_hit_test_result):
webkit/webkitwebview.h:

6:53 AM Changeset in webkit [48505] by xan@webkit.org

7 edits
2 adds in trunk

2009-09-14 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha and Jan Alonzo.

[GTK] context menu overriding API is very limited
https://bugs.webkit.org/show_bug.cgi?id=27546

Add WebKitHitTestResult to the build.

GNUmakefile.am:

WebKit/gtk:

2009-09-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha and Jan Alonzo.

[GTK] context menu overriding API is very limited
https://bugs.webkit.org/show_bug.cgi?id=27546

Add WebKitHitTestResult, a wrapper over HitTestResult. It contains
context information about a point in the web page.

webkit/webkit.h:
webkit/webkitdefines.h:
webkit/webkithittestresult.cpp: Added. (webkit_hit_test_result_finalize): (webkit_hit_test_result_get_property): (webkit_hit_test_result_set_property): (webkit_hit_test_result_class_init): (webkit_hit_test_result_init):
webkit/webkithittestresult.h: Added.
webkit/webkitprivate.cpp: (WebKit::kit):
webkit/webkitprivate.h:

6:01 AM Changeset in webkit [48504] by Simon Hausmann

4 edits in trunk/WebKit/qt

[Qt] Add persistence support for configuration options in the
inspector.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-18
Reviewed by Simon Hausmann.

Api/qwebinspector.cpp:
QtLauncher/main.cpp:

(main):

WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::populateSetting):
(WebCore::InspectorClientQt::storeSetting):
(WebCore::variantToSetting):
(WebCore::settingToVariant):

2:35 AM Changeset in webkit [48503] by eric@webkit.org

6 edits in trunk

2009-09-18 Steve Block <steveblock@google.com>

Reviewed by Dimitri Glazkov.

Geolocation does not correctly handle Infinity for PositionOptions properties.
https://bugs.webkit.org/show_bug.cgi?id=29099

fast/dom/Geolocation/resources/argument-types.js: Modified. Test passing positive and negative Infinity to Geolocation methods.
fast/dom/Geolocation/argument-types-expected.txt: Modified. Expected result for above test.

2009-09-18 Steve Block <steveblock@google.com>

Reviewed by Dimitri Glazkov.

Geolocation does not correctly handle Infinity for PositionOptions properties.
https://bugs.webkit.org/show_bug.cgi?id=29099

bindings/js/JSGeolocationCustom.cpp: Modified. (WebCore::createPositionOptions): Modified. If timeout or maximumAge is positive infinity, applies these values as a special case.
page/PositionOptions.h: Modified. (WebCore::PositionOptions::hasMaximumAge): Added. Determines whether the object has a maximum age. (WebCore::PositionOptions::maximumAge): Modified. Asserts that the object has a maximum age. (WebCore::PositionOptions::clearMaximumAge): Added. Clears the maximum age. (WebCore::PositionOptions::setMaximumAge): Modified. Registers that the maximum age has been set. (WebCore::PositionOptions::PositionOptions): Modified. Registers that the maximum age has been set.

2:18 AM Changeset in webkit [48502] by Simon Hausmann

5 edits in trunk/WebKit/qt

Fixed a bunch of documentation warnings.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-18
Reviewed by Ariya Hidayat.

Api/qwebgraphicsitem.cpp:
Api/qwebplugindatabase.cpp:
Api/qwebpluginfactory.cpp:
Api/qwebsecurityorigin.cpp:

1:45 AM Changeset in webkit [48501] by Simon Hausmann

2 edits in trunk/WebKit/qt

Added a test that console output works.

Patch by Warwick Allison <warwick.allison@nokia.com> on 2009-09-18
Reviewed by Simon Hausmann.

tests/qwebpage/tst_qwebpage.cpp:

(ConsolePage::ConsolePage):
(ConsolePage::javaScriptConsoleMessage):
(tst_QWebPage::consoleOutput):

Sep 17, 2009:

10:21 PM Changeset in webkit [48500] by weinig@apple.com

2 edits in trunk/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=29276
REGRESSION(r48334): WebKit crashes on file select by drag

Reviewed by Adele Peterson.

Document.elementFromPoint now takes point in client space, not page space.

page/DragController.cpp:

(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):

6:32 PM Changeset in webkit [48499] by ajwong@chromium.org

5 edits in trunk/WebCore

2009-09-17 Albert J. Wong <ajwong@chromium.org>

Reviewed by David Levin.

Reimplement default media UI for Mac Chromium to match the style
of the Windows and Linux versions. Also breaks the dependency
on the internal wk* functions that were previously used to
render the media controller widgets.
https://bugs.webkit.org/show_bug.cgi?id=29161

No media layout tests are currently enabled in Mac Chromium, so
nothing needs rebaselineing, etc.

This is a recommit of r48438 with a compile fix and merges of
recent changes to the file.

css/mediaControlsChromium.css:
rendering/RenderThemeChromiumMac.h:
rendering/RenderThemeChromiumMac.mm: (WebCore::mediaElementParent): (WebCore::RenderThemeChromiumMac::extraMediaControlsStyleSheet): (WebCore::mediaSliderThumbImage): (WebCore::mediaVolumeSliderThumbImage): (WebCore::RenderThemeChromiumMac::paintSliderTrack): (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): (WebCore::RenderThemeChromiumMac::paintMediaButtonInternal): (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground):
rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):

5:06 PM Changeset in webkit [48498] by bweinstein@apple.com

2 edits in trunk/LayoutTests

2009-09-17 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Steve Falkenburg.

Add failing test on both Windows Debug and Release to the
Windows Skipped List.

http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html is
being tracked by <https://bugs.webkit.org/show_bug.cgi?id=29353>.

platform/win/Skipped:

4:59 PM Changeset in webkit [48497] by bweinstein@apple.com

3 edits in trunk/WebCore

2009-09-17 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.

The Console scope bar should have a divider between All and the other possible
values (Errors, Warnings, Logs). It will look something like:

All | Errors Warnings Logs.

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.createDividerElement): (WebInspector.ConsoleView):
inspector/front-end/inspector.css:

4:03 PM Changeset in webkit [48496] by bweinstein@apple.com

2 edits in trunk/WebKit/win

2009-09-17 Brian Weinstein <bweinstein@apple.com>

Reviewed by Adam Roben.

Remove assertions that were being hit by calls to
m_verticalScrollbar->invalidate(). These assertions were valid,
but they were causing tests to fail, so replacing with a FIXME
until we can find out the real cause/solution that is being tracked
by http://webkit.org/b/29350.

WebView.cpp: (WebView::addToDirtyRegion): (WebView::paintIntoBackingStore):

3:54 PM Changeset in webkit [48495] by weinig@apple.com

3 edits in trunk/WebCore

Remove additional references to JSVoidCallback which no longer exists.

Reviewed by Mark Rowe.

DerivedSources.cpp:
WebCore.vcproj/WebCore.vcproj:

3:48 PM Changeset in webkit [48494] by eric@webkit.org

21 edits in trunk/LayoutTests

2009-09-17 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Carlson.

Media layout tests should have a way to provide test files in different formats
https://bugs.webkit.org/show_bug.cgi?id=28327

Updating 19 media layout tests to use media files based on supported codecs.

media/media-file.js: Prefer .wav over other formats as this is used the most in tests for mac port. Most of audio tests use media/content/test.wav as test file for mac, so this change would make sure findMediaFile() will return test.wav but not test.mp3 or other formats. (setSrcById): Fixing bug in code.
media/video-canvas-source.html: Use findMediaFile() to locate a media file based on supported types.
media/video-click-dblckick-standalone.html: ditto.
media/video-controls-transformed.html: ditto.
media/video-controls-visible-audio-only.html: ditto.
media/video-controls-zoomed.html: ditto.
media/video-controls.html: ditto.
media/video-currentTime-set.html: ditto.
media/video-currentTime-set2.html: ditto.
media/video-currentTime.html: ditto.
media/video-display-none-crash.html: ditto.
media/video-display-toggle.html: ditto.
media/video-dom-autoplay.html: ditto.
media/video-dom-src.html: ditto.
media/video-error-abort.html: ditto.
media/video-load-networkState.html: ditto.
media/video-load-readyState.html: ditto.
media/video-loop.html: ditto.
media/video-muted.html: ditto.
media/video-no-autoplay.html: ditto.

3:48 PM Changeset in webkit [48493] by weinig@apple.com

2 edits in trunk/WebCore

Remove commented out onhashchange attribute now that it is implemented.

Reviewed by Brady Eidson.

page/DOMWindow.idl:

3:23 PM Changeset in webkit [48492] by andersca@apple.com

5 edits in trunk

WebCore: <rdar://problem/7007541>
CrashTracer: 4800+ crashes in Safari at com.apple.WebKit • WTF::HashTableIterator...

Reviewed by Oliver Hunt.

Make RuntimeObjectImp more robust against m_instance being a null (which can happen if an OOP plug-in
crashes while we're calling into it).

bridge/runtime_object.cpp:

(JSC::RuntimeObjectImp::RuntimeObjectImp):
(JSC::RuntimeObjectImp::~RuntimeObjectImp):
(JSC::RuntimeObjectImp::invalidate):
(JSC::RuntimeObjectImp::fallbackObjectGetter):
(JSC::RuntimeObjectImp::fieldGetter):
(JSC::RuntimeObjectImp::methodGetter):
(JSC::RuntimeObjectImp::getOwnPropertySlot):
(JSC::RuntimeObjectImp::getOwnPropertyDescriptor):
(JSC::RuntimeObjectImp::put):
(JSC::RuntimeObjectImp::defaultValue):
(JSC::RuntimeObjectImp::getCallData):
(JSC::RuntimeObjectImp::getConstructData):
(JSC::RuntimeObjectImp::getPropertyNames):

bridge/runtime_object.h:

(JSC::RuntimeObjectImp::getInternalInstance):

WebKit/mac: <rdar://problem/7007541>
CrashTracer: 4800+ crashes in Safari at com.apple.WebKit • WTF::HashTableIterator...

Reviewed by Oliver Hunt.

Add null checks for m_instanceProxy (It will be null when a plug-in has crashed).

Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::invoke):
(WebKit::ProxyInstance::supportsInvokeDefaultMethod):
(WebKit::ProxyInstance::supportsConstruct):
(WebKit::ProxyInstance::getPropertyNames):
(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):
(WebKit::ProxyInstance::fieldValue):
(WebKit::ProxyInstance::setFieldValue):
(WebKit::ProxyInstance::invalidate):

1:54 PM Changeset in webkit [48491] by eric@webkit.org

5 edits in trunk/WebCore

2009-09-17 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Wrap primitive values (as objects) in InspectorController::wrap.

https://bugs.webkit.org/show_bug.cgi?id=28983

inspector/InspectorController.cpp: (WebCore::InspectorController::wrapObject): objects of any type will be wrapped into proxies, only object proxies will have objectId.
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): there is InjectedScript.getCompletionsi that accepts an expression and returns possible completions. This way we don't need to wrap and unwrap the completions result into a proxy object.
inspector/front-end/InjectedScript.js: (InjectedScript.getCompletions): (InjectedScript.evaluate): (InjectedScript._evaluateOn): (InjectedScript.createProxyObject):
inspector/front-end/InjectedScriptAccess.js:

1:45 PM Changeset in webkit [48490] by Nate Chapin

2 edits in trunk/WebCore

2009-09-17 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Wrap PageTransitionEvents properly for V8's use.

https://bugs.webkit.org/show_bug.cgi?id=29340

Fixes Chromium's failures for LayoutTests/fast/events/pageshow-pagehide.html.

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object): Wrap PageTransitionEvents properly.

1:12 PM Changeset in webkit [48489] by Simon Fraser

3 edits
3 adds in trunk

2009-09-17 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Hardware-accelerated opacity transition on inline asserts
https://bugs.webkit.org/show_bug.cgi?id=29342

Remove an erroneous toRenderBox() that could be called on a RenderInline; we can just
pass an empty size, because the box size is only required for transform animations.

Test: compositing/transitions/opacity-on-inline.html

rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startTransition):

1:07 PM Changeset in webkit [48488] by eric@webkit.org

2 edits in trunk/WebKitSite

2009-09-17 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Update contributing.html to mention recently added tools.
https://bugs.webkit.org/show_bug.cgi?id=29318

Update our contributing instructions to mention
the new tools (check-webkit-style and commit-queue)
recently added to make contributions easier.

coding/contributing.html:
- Mention check-webkit-style as an optional helper tool.
- Mention checking the 'patch' checkbox.
- Mention the commit-queue as an optional helper tool.
- Remove "or in email" since patch reviews are all done via bugzilla.
- Encourage contributers to be responsible for getting their patch landed. Provide a list of committers.
- Mention commit-queue as an optional help in getting your patch landed.
- Give an overview of the commit-queue process and link to the Commit Queue docs.

1:03 PM Changeset in webkit [48487] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-09-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Brady Eidson.

Tiger fails test http/tests/loading/redirect-with-no-location-crash.html added in r48413
https://bugs.webkit.org/show_bug.cgi?id=29329

Skip test that fails on Tiger because of a bug in its version of
CFNetwork.

platform/mac-tiger/Skipped:

12:59 PM Changeset in webkit [48486] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[V8] OwnHandle might get a weak callback after destruction
https://bugs.webkit.org/show_bug.cgi?id=29172

Be sure to clear out weak reference so we don't get a weak callback
after we've destructed ourselves. Also, removed some tricky methods
that had no clients.

bindings/v8/OwnHandle.h: (WebCore::OwnHandle::clear):

12:52 PM Changeset in webkit [48485] by eric@webkit.org

2 edits
1 move in trunk/LayoutTests

2009-09-17 Eric Seidel <eric@webkit.org>

Reviewed by Simon Fraser.

REGRESSION: media/video-size-intrinsic-scale.html (and other media tests?) crashing/timing-out intermittently
https://bugs.webkit.org/show_bug.cgi?id=28845

Skip media/video-size-intrinsic-scale.html in hopes of stopping the crashers.
I ran the media tests with --iterations 30 w/o seeing a crash.
I also re-enabled media/video-source-add-src.html now that we know it is not at fault.

media/video-source-add-src.html: Renamed from LayoutTests/media/video-source-add-src.html-disabled.
platform/mac-leopard/Skipped:

12:43 PM Changeset in webkit [48484] by eric@webkit.org

1 edit
9 adds in trunk/LayoutTests

2009-09-17 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Add layout tests to verify there is no security leaks if someone sets a prototype of top
window to its child window.
https://bugs.webkit.org/show_bug.cgi?id=29334

http/tests/security/resources/iframe-with-element.html: Added.
http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto-expected.txt: Added.
http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto.html: Added.
http/tests/security/xss-DENIED-method-with-iframe-proto-expected.txt: Added.
http/tests/security/xss-DENIED-method-with-iframe-proto.html: Added.
http/tests/security/xss-DENIED-non-shadowable-propterty-with-iframe-proto-expected.txt: Added.
http/tests/security/xss-DENIED-non-shadowable-propterty-with-iframe-proto.html: Added.
http/tests/security/xss-DENIED-regular-propterty-with-iframe-proto-expected.txt: Added.
http/tests/security/xss-DENIED-regular-propterty-with-iframe-proto.html: Added.

12:13 PM Changeset in webkit [48483] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-09-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[V8] Partial roll out of http://trac.webkit.org/changeset/48455 to
fix crashes that started happening in V8Proxy::getEnteredContext().

bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):

12:10 PM Changeset in webkit [48482] by Chris Fleizach

7 edits
2 adds in trunk

AX: labels of checkboxes should, when hit-tested, return the checkbox
https://bugs.webkit.org/show_bug.cgi?id=29335

Reviewed by Beth Dakin.

WebCore:

When an accessibility hit test is done and it hits the label of a control element,
the control element should be returned instead of nothing, since the label
itself is usually ignored.

Test: accessibility/label-for-control-hittest.html

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::correspondingControlForLabelElement):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):

accessibility/AccessibilityRenderObject.h:

LayoutTests:

accessibility/label-for-control-hittest-expected.txt: Added.
accessibility/label-for-control-hittest.html: Added.
platform/gtk/Skipped:
platform/win/Skipped:

12:08 PM Changeset in webkit [48481] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-09-17 Avi Drissman <avi@chromium.org>

Reviewed by Dimitri Glazkov, build fix.

Change to make RenderThemeChromiumMac compile inside of non PLATFORM(MAC).
https://bugs.webkit.org/show_bug.cgi?id=29243

Covered by existing tests.

rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):

12:06 PM Changeset in webkit [48480] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-09-17 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

[V8] Accessing properties/methods of an object, created with document.implementation.createDocumentType
creates nodes that have no document (ScriptExecutionContext), which in turn produces NULL-ref crashes.
https://bugs.webkit.org/show_bug.cgi?id=26402

Test: fast/dom/DOMImplementation/detached-doctype.html

fast/dom/doctype-event-listener-crash.html

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getEventListener): Added an extra NULL-check.

11:39 AM Changeset in webkit [48479] by bweinstein@apple.com

2 edits in trunk/LayoutTests

2009-09-17 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Adam Roben.

Add a newline to the end of the expected file, should fix results.

platform/win/transforms/2d/hindi-rotated-expected.txt:

11:32 AM Changeset in webkit [48478] by adachan@apple.com

3 edits in trunk/WebKit/win

Post WebViewDidChangeSelectionNotification when the text selection changes.

Fixes <http://webkit.org/b/29321>

Reviewed by Adam Roben.

Interfaces/IWebView.idl:
WebCoreSupport/WebEditorClient.cpp: (WebEditorClient::respondToChangedSelection):

11:09 AM Changeset in webkit [48477] by kevino@webkit.org

2 edits in trunk/WebKitTools

wx build fix, add missing dependency.

11:05 AM Changeset in webkit [48476] by bweinstein@apple.com

4 edits in trunk/LayoutTests

2009-09-17 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Adam Roben.

Updated Windows results on three failing tests, adding font-smoothing to computed-style,
and udpated the hindi-rotated-expected to what it has been getting on the bots.

platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/win/transforms/2d/hindi-rotated-expected.txt:

10:44 AM Changeset in webkit [48475] by mitz@apple.com

1 add in trunk/WebCore/platform/graphics/FontSmoothingMode.h

Add file that was missing from the last change

10:33 AM Changeset in webkit [48474] by mitz@apple.com

11 edits in trunk/WebCore

FontDescription.h includes RenderStyleConstants.h, which violates layering
https://bugs.webkit.org/show_bug.cgi?id=29327

Reviewed by Simon Fraser.

GNUmakefile.am: Added FontSmoothingMode.h.
WebCore.gypi: Added FontSmoothingMode.h.
WebCore.vcproj/WebCore.vcproj: Added FontSmoothingMode.h.
WebCore.xcodeproj/project.pbxproj: Added FontSmoothingMode.h and made

it a private header.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Get the

font smoothing mode via the font description.

css/CSSPrimitiveValueMappings.h: Include FontSmoothingMode.h

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Updated for the rename

of FontSmoothing to FontSmoothingMode.

(WebCore::CSSPrimitiveValue::operator FontSmoothingMode): Ditto.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Get the font smoothing mode

via the font description.

platform/graphics/FontDescription.h: Do not include

RenderStyleConstants.h.

(WebCore::FontDescription::fontSmoothing): Updated for the rename of

FontSmoothing to FontSmoothingMode.

(WebCore::FontDescription::setFontSmoothing): Ditto.

platform/graphics/FontSmoothingMode.h: Added.

(WebCore::FontSmoothingMode): Moved the FontSmoothing enum from

RenderStyleConstants here and renamed it to this.

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::fontSmoothing): Removed this getter, since

this can be accessed via the font description.

rendering/style/RenderStyleConstants.h: Moved the FontSmoothing enum

from here to FontSmoothingMode.h.

10:32 AM Changeset in webkit [48473] by Adam Roben

2 edits in trunk/WebKit/win

Fix a crash when a WebView's HWND is destroyed before IWebView::close is called

WebView's HWND was being sent a WM_TIMER message after the WebView was
destroyed. This normally isn't possible (we call DestroyWindow inside
WebView's destructor to ensure the HWND doesn't outlive the WebView),
but r48060 changed WebView to call SetParent(m_viewWindow,
HWND_MESSAGE) while handling WM_DESTROY, and apparently this puts the
HWND into some weird half-destroyed state where it can still receive
WM_TIMER messages.

Fixes <http://webkit.org/b/29337> <rdar://problem/7209897> REGRESSION
(r48060): unrepro but frequent crash in WebViewWndProc

Reviewed by Steve Falkenburg.

WebView.cpp:

(WebViewWndProc): When handling WM_DESTROY, call setIsBeingDestroyed()
before calling close(). This allows setHostWindow to detect that we're
handling WM_DESTROY. No other code in close() cared whether
isBeingDestroyed() was true or not.
(WebView::setHostWindow): If our host window is being set to 0 and
we're being destroyed, don't become a message-only window. Doing this
while handling WM_DESTROY seems to lead to crashes.

10:10 AM Changeset in webkit [48472] by kevino@webkit.org

2 edits in trunk/WebCore

wx 2.9 build fix.

9:56 AM Changeset in webkit [48471] by Simon Fraser

2 edits in trunk/WebKit/mac

2009-09-16 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Work around a bug in AppKit on Leopard which causes compositing layers to jitter, and
become misplaced when the WebHTMLView is resized or scrolled sometimes.
<rdar://problem/7071636>

The previous fix didn't fix the case where the layers jiggle when resizing the docked
inspector when the view size is over 2048px tall, on Leopard.

WebView/WebHTMLView.mm: (-[WebHTMLView _updateLayerHostingViewPosition]):

9:41 AM Changeset in webkit [48470] by Simon Fraser

3 edits
4 adds in trunk

2009-09-16 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Elements appear behind <video> when they should be in front sometimes
https://bugs.webkit.org/show_bug.cgi?id=29314

r45598 added logic that tests for overlap with <video> to determine when to throw
a layer into compositing mode. That logic was incorrect in some cases, and this patch
fixes it. When testing overlap, the layer needs to be composited iff some previous layer
is composited (which adds a rect to the overlay map), and there is overlap.

Test: compositing/geometry/video-opacity-overlay.html

rendering/RenderLayerCompositor.cpp: (WebCore::CompositingState::CompositingState): (WebCore::RenderLayerCompositor::computeCompositingRequirements):

8:52 AM Changeset in webkit [48469] by Dimitri Glazkov

8 edits
2 adds in trunk/WebCore

2009-09-17 Avi Drissman <avi@google.com>

Reviewed by Darin Fisher.

Update the Chromium Mac theming files (RenderTheme and Theme) to be
up-to-date.

https://bugs.webkit.org/show_bug.cgi?id=29243
http://crbug.com/19604

Covered by existing tests.

WebCore.gypi:
platform/chromium/ThemeChromiumMac.h: Added. (WebCore::ThemeChromiumMac::ThemeChromiumMac): (WebCore::ThemeChromiumMac::~ThemeChromiumMac): (WebCore::ThemeChromiumMac::controlRequiresPreWhiteSpace):
platform/chromium/ThemeChromiumMac.mm: Added. (WebCore::): (WebCore::platformTheme): (WebCore::controlSizeForFont): (WebCore::sizeFromFont): (WebCore::setControlSize): (WebCore::updateStates): (WebCore::inflateRect): (WebCore::checkboxSizes): (WebCore::checkboxMargins): (WebCore::checkboxSize): (WebCore::checkbox): (WebCore::paintCheckbox): (WebCore::radioSizes): (WebCore::radioMargins): (WebCore::radioSize): (WebCore::radio): (WebCore::paintRadio): (WebCore::buttonSizes): (WebCore::buttonMargins): (WebCore::button): (WebCore::paintButton): (WebCore::ThemeChromiumMac::baselinePositionAdjustment): (WebCore::ThemeChromiumMac::controlFont): (WebCore::ThemeChromiumMac::controlSize): (WebCore::ThemeChromiumMac::minimumControlSize): (WebCore::ThemeChromiumMac::controlBorder): (WebCore::ThemeChromiumMac::controlPadding): (WebCore::ThemeChromiumMac::inflateControlPaintRect): (WebCore::ThemeChromiumMac::paint):
platform/graphics/FloatPoint.h:
platform/graphics/FloatRect.h:
platform/graphics/FloatSize.h:
platform/graphics/IntRect.h:
rendering/RenderThemeChromiumMac.h: (WebCore::RenderThemeChromiumMac::supportsControlTints): (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart): (WebCore::RenderThemeChromiumMac::supportsSelectionForegroundColors):
rendering/RenderThemeChromiumMac.mm: (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): (-[RTCMFlippedView isFlipped]): (-[RTCMFlippedView currentEditor]): (WebCore::): (WebCore::FlippedView): (WebCore::RenderTheme::themeForPage): (WebCore::RenderThemeChromiumMac::platformActiveListBoxSelectionForegroundColor): (WebCore::RenderThemeChromiumMac::platformInactiveListBoxSelectionForegroundColor): (WebCore::RenderThemeChromiumMac::platformInactiveListBoxSelectionBackgroundColor): (WebCore::RenderThemeChromiumMac::systemFont): (WebCore::convertNSColorToColor): (WebCore::menuBackgroundColor): (WebCore::RenderThemeChromiumMac::systemColor): (WebCore::RenderThemeChromiumMac::isControlStyled): (WebCore::RenderThemeChromiumMac::adjustRepaintRect): (WebCore::RenderThemeChromiumMac::inflateRect): (WebCore::RenderThemeChromiumMac::convertToPaintingRect): (WebCore::RenderThemeChromiumMac::setFontFromControlSize): (WebCore::RenderThemeChromiumMac::paintTextField): (WebCore::RenderThemeChromiumMac::paintCapsLockIndicator): (WebCore::RenderThemeChromiumMac::paintTextArea): (WebCore::RenderThemeChromiumMac::paintMenuList): (WebCore::TopGradientInterpolate): (WebCore::BottomGradientInterpolate): (WebCore::MainGradientInterpolate): (WebCore::TrackGradientInterpolate): (WebCore::RenderThemeChromiumMac::paintMenuListButtonGradients): (WebCore::RenderThemeChromiumMac::paintMenuListButton): (WebCore::RenderThemeChromiumMac::popupInternalPaddingLeft): (WebCore::RenderThemeChromiumMac::popupInternalPaddingRight): (WebCore::RenderThemeChromiumMac::popupInternalPaddingTop): (WebCore::RenderThemeChromiumMac::popupInternalPaddingBottom): (WebCore::RenderThemeChromiumMac::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumMac::adjustSliderTrackStyle): (WebCore::RenderThemeChromiumMac::adjustSliderThumbStyle): (WebCore::RenderThemeChromiumMac::paintSliderThumb): (WebCore::RenderThemeChromiumMac::paintSearchField): (WebCore::RenderThemeChromiumMac::setSearchCellState): (WebCore::RenderThemeChromiumMac::adjustSearchFieldStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumMac::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumMac::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldDecoration): (WebCore::RenderThemeChromiumMac::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumMac::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton): (WebCore::mediaControllerTheme): (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): (WebCore::getMediaUIPartStateFlags): (WebCore::getUnzoomedRectAndAdjustCurrentContext): (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton): (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): (WebCore::RenderThemeChromiumMac::paintMediaSeekBackButton): (WebCore::RenderThemeChromiumMac::paintMediaSeekForwardButton): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaRewindButton): (WebCore::RenderThemeChromiumMac::paintMediaReturnToRealtimeButton): (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground): (WebCore::RenderThemeChromiumMac::paintMediaCurrentTime): (WebCore::RenderThemeChromiumMac::paintMediaTimeRemaining): (WebCore::RenderThemeChromiumMac::extraMediaControlsStyleSheet):

7:03 AM Changeset in webkit [48468] by kenneth@webkit.org

2 edits in trunk/WebKit/qt

Improve documentation for Page Cache.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-17
Reviewed by Simon Hausmann.

Api/qwebsettings.cpp:

6:03 AM Changeset in webkit [48467] by zoltan@webkit.org

1 add in trunk/LayoutTests/platform/qt/fast/css/font-smoothing-expected.txt

2009-09-17 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Add expected file for passing font-smoothing test and update computed style tests since font smoothing is auto by default.

platform/qt/fast/css/font-smoothing-expected.txt: Added.

6:01 AM Changeset in webkit [48466] by zoltan@webkit.org

3 edits in trunk/LayoutTests

2009-09-17 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Add expected file for passing font-smoothing test and update computed style tests since font smoothing is auto by default.

platform/qt/fast/css/font-smoothing-expected.txt: Added.
platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

5:46 AM Changeset in webkit [48465] by vestbo@webkit.org

3 edits in trunk/WebKit/qt

[Qt] Update QWebSettings::setUserStyleSheetUrl() docs and test

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29081

The documentation now specifies that the URL has to be a local file
or a a data-URL (with utf-8 and base64-encoded data), as these are the
only two schemes that the current code path accepts.

The auto-test has been updated to reflect this limitation.

At a later point we should concider adding API for the new way of
doing both user defined stylesheets and scripts.

Api/qwebsettings.cpp:
tests/qwebpage/tst_qwebpage.cpp:

4:51 AM Changeset in webkit [48464] by Simon Hausmann

2 edits in trunk/LayoutTests

[Qt] Skip failing tests for now to prepare default font size reconciliation.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-17
Reviewed by Simon Hausmann.

platform/qt/Skipped:

3:54 AM Changeset in webkit [48463] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Symbian/WINSCW build fox.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-17
Reviewed by Simon Hausmann.

Repeat Q_OS_WIN wchar_t hack for WINSCW, similar to
revision 24774.

WINSCW defines wchar_t, thus UChar has to be wchar_t

wtf/unicode/qt4/UnicodeQt4.h:

3:47 AM Changeset in webkit [48462] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Symbian/WINSCW build fix.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-17
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29186

WINSCW Template specialisation name in declaration must the be the same as in implementation.

runtime/LiteralParser.h:

3:44 AM Changeset in webkit [48461] by Simon Hausmann

2 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=27060

Patch by Norbert Leser <norbert.leser@nokia.com> on 2009-09-15
Reviewed by Darin Adler.

Symbian compiler for emulator target (WINSCW) fails with
"illegal operand" for m_attributesInPrevious in structure.ccp
(when calling make_pair functions).
This error is apparently due to the compiler not properly
resolving the unsigned type of the declared bitfield.

Initial patch explicitly casted m_attributesInPrevious
to unsigned, but since bitfield optimization is not critical for
the emulator target, this conditional change in header file
appears to be least intrusive.

runtime/Structure.h:

3:31 AM Changeset in webkit [48460] by Simon Hausmann

4 edits in trunk/WebKit/qt

Symbian build fix.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-17
Reviewed by Simon Hausmann.

Moved the #ifdefs around _q_cleanupLeakMessages() into the function
definition.

QMake is not being able to distinguish between release and debug builds
in Symbian build. This is a Symbian toolchain issue.

Api/qwebpage.cpp:

(QWebPagePrivate::_q_cleanupLeakMessages):

Api/qwebpage.h:
Api/qwebpage_p.h:

3:20 AM Changeset in webkit [48459] by Simon Hausmann

2 edits in trunk/WebKit/qt

Small cosmetic documentation fixlet in the QWebInspector.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-17
Reviewed by Simon Hausmann.

Api/qwebinspector.cpp:

Sep 16, 2009:

11:45 PM Changeset in webkit [48458] by abarth@webkit.org

3 edits
2 adds in trunk

2009-09-16 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=29306

Tests that scripts with accented characters do not bypass the XSSAuditor.

http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt: Added.
http/tests/security/xssAuditor/img-onerror-accented-char.html: Added.

2009-09-16 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=29306

Fixes an issue where an attack that contains accented characters can
bypass the XSSAuditor.

XSSAuditor::decodeURL used the wrong length for the input string.
When the input string was decoded, the decoded result was truncated.
Hence, XSSAuditor was comparing the source code of the script to the
truncated input parameters.

Test: http/tests/security/xssAuditor/img-onerror-accented-char.html

page/XSSAuditor.cpp: (WebCore::XSSAuditor::decodeURL):

11:42 PM Changeset in webkit [48457] by abarth@webkit.org

5 edits in trunk/LayoutTests

2009-09-16 Adam Barth <abarth@webkit.org>

Unreviewed. Added new isolated world test to the skipped list.

platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

11:36 PM Changeset in webkit [48456] by beidson@apple.com

2 edits in trunk/WebCore

Explore allowing pages with unload handlers into the Page Cache
https://bugs.webkit.org/show_bug.cgi?id=29021

Reviewed by Sam Weinig.

No new tests. (All previous tests continue to pass)

loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading): If the document is in the page cache, don't fire the unload event.

11:25 PM Changeset in webkit [48455] by abarth@webkit.org

6 edits
4 adds in trunk

2009-09-16 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703

We now save a handle to the original context. We use that handle to
call the timeout in the right context / world.

Tests: http/tests/security/isolatedWorld/window-setTimeout-function.html

http/tests/security/isolatedWorld/window-setTimeout-string.html

bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
bindings/v8/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction):
bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl):
bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::SetTimeoutOrInterval):

2009-09-16 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703

Add test coverage for the interaction between setTimeout and isolated
worlds.

http/tests/security/isolatedWorld/window-setTimeout-function-expected.txt: Added.
http/tests/security/isolatedWorld/window-setTimeout-function.html: Added.
http/tests/security/isolatedWorld/window-setTimeout-string-expected.txt: Added.
http/tests/security/isolatedWorld/window-setTimeout-string.html: Added.

9:39 PM Changeset in webkit [48454] by weinig@apple.com

2 edits in trunk/WebCore

Add some groups to the xcode project to make the bindings/js/ group
a little nicer.

Reviewed by Anders Carlsson.

WebCore.xcodeproj/project.pbxproj:

8:42 PM Changeset in webkit [48453] by weinig@apple.com

20 edits in trunk/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=29320
JS callback objects should store the global object

Reviewed by Anders Carlsson.

This just changes the callback objects to store the global object instead
of the frame. A follow up patch will change them to store the 'current'
global object instead of the lexical or dynamic.

DerivedSources.make: Remove unused VoidCallback.
WebCore.xcodeproj/project.pbxproj: Ditto.
bindings/js/JSCustomPositionCallback.cpp:

(WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
(WebCore::JSCustomPositionCallback::handleEvent):

bindings/js/JSCustomPositionCallback.h:

(WebCore::JSCustomPositionCallback::create):

bindings/js/JSCustomPositionErrorCallback.cpp:

(WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
(WebCore::JSCustomPositionErrorCallback::handleEvent):

bindings/js/JSCustomPositionErrorCallback.h:

(WebCore::JSCustomPositionErrorCallback::create):

bindings/js/JSCustomSQLStatementCallback.cpp:

(WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::handleEvent):

bindings/js/JSCustomSQLStatementCallback.h:

(WebCore::JSCustomSQLStatementCallback::create):

bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):

bindings/js/JSCustomSQLStatementErrorCallback.h:

(WebCore::JSCustomSQLStatementErrorCallback::create):

bindings/js/JSCustomSQLTransactionCallback.cpp:

(WebCore::JSCustomSQLTransactionCallback::Data::Data):
(WebCore::JSCustomSQLTransactionCallback::Data::globalObject):
(WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::handleEvent):

bindings/js/JSCustomSQLTransactionCallback.h:

(WebCore::JSCustomSQLTransactionCallback::create):

bindings/js/JSCustomSQLTransactionErrorCallback.cpp:

(WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):

bindings/js/JSCustomSQLTransactionErrorCallback.h:

(WebCore::JSCustomSQLTransactionErrorCallback::create):

bindings/js/JSCustomVoidCallback.cpp:

(WebCore::JSCustomVoidCallback::JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::handleEvent):

bindings/js/JSCustomVoidCallback.h:

(WebCore::JSCustomVoidCallback::create):

bindings/js/JSDatabaseCustom.cpp:

(WebCore::JSDatabase::changeVersion):
(WebCore::createTransaction):
(WebCore::JSDatabase::transaction):
(WebCore::JSDatabase::readTransaction):

bindings/js/JSGeolocationCustom.cpp:

(WebCore::createPositionCallback):
(WebCore::createPositionErrorCallback):
(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):

bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

8:40 PM Changeset in webkit [48452] by mrowe@apple.com

2 edits in trunk/WebKitTools

Split the SnowLeopard build across a few machines.

BuildSlaveSupport/build.webkit.org-config/config.json:

7:57 PM Changeset in webkit [48451] by kevino@webkit.org

3 edits in trunk/WebKit/wx

wxPython bindings build fixes after recent changes.

7:33 PM Changeset in webkit [48450] by brettw@chromium.org

5 edits in trunk/WebCore

Revert "2009-09-16 Albert J. Wong <ajwong@chromium.org>"
This change did not compile.

7:13 PM Changeset in webkit [48449] by eric@webkit.org

15 edits
2 adds
12 deletes in trunk

2009-09-15 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

<input maxlength=> should restrict only values specified by users.
https://bugs.webkit.org/show_bug.cgi?id=21271

fast/forms/input-appearance-maxlength-expected.txt:
fast/forms/input-appearance-maxlength.html:
fast/forms/input-maxlength-expected.txt:
fast/forms/input-maxlength.html:
fast/forms/input-text-maxlength-expected.txt: Added.
fast/forms/input-text-maxlength.html:
fast/forms/input-text-paste-maxlength-expected.txt: Added.
fast/forms/input-text-paste-maxlength.html:
platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum: Removed.
platform/mac-leopard/fast/forms/input-text-maxlength-expected.png: Removed.
platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt: Removed.
platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum: Removed.
platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png: Removed.
platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt: Removed.
platform/mac/fast/forms/input-text-maxlength-expected.txt: Removed.
platform/mac/fast/forms/input-text-paste-maxlength-expected.txt: Removed.
platform/qt/fast/forms/input-text-maxlength-expected.txt: Removed.
platform/qt/fast/forms/input-text-paste-maxlength-expected.txt: Removed.
platform/win/fast/forms/input-text-maxlength-expected.txt: Removed.
platform/win/fast/forms/input-text-paste-maxlength-expected.txt: Removed.

2009-09-15 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

<input maxlength=> should restrict only values specified by users.
https://bugs.webkit.org/show_bug.cgi?id=21271

dom/InputElement.cpp: (WebCore::InputElement::setValueFromRenderer): (WebCore::InputElement::sanitizeValue): (WebCore::InputElement::sanitizeUserInputValue): Rename from constrainValue(). (WebCore::InputElement::handleBeforeTextInsertedEvent): (WebCore::InputElement::updateValueIfNeeded):
dom/InputElement.h:
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::value): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::sanitizeValue):
html/HTMLInputElement.h:
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
wml/WMLInputElement.cpp: (WebCore::WMLInputElement::constrainValue):
wml/WMLInputElement.h: (WebCore::WMLInputElement::sanitizeValue):

6:58 PM Changeset in webkit [48448] by eric@webkit.org

5 edits in trunk/WebCore

2009-09-16 Enrica Casucci <enrica@apple.com>

Reviewed by Eric Seidel.

Reorganizing helper functions in htmlediting.h to group them by type of object they return/operate upon.
https://bugs.webkit.org/show_bug.cgi?id=29319

editing/IndentOutdentCommand.cpp: Removed implementation of isAtUnsplittableElement.

editing/IndentOutdentCommand.h: Removed member function isAtUnsplittableElement, because it was not class specific and belonged logically among the helper functions.

editing/htmlediting.cpp: (WebCore::isAtUnsplittableElement): added. The code was taken from IndentOutdentCommand.

editing/htmlediting.h: Reordered functions to group them by type of object returned or operate upon. Added comments. Added isAtUnsplittableElement declaration.

5:00 PM CommitQueue edited by eric@webkit.org

(diff)

4:27 PM Changeset in webkit [48447] by ggaren@apple.com

3 edits
2 adds in trunk

WebCore: Removed some vestigial and potentially crashy code that makes consolidating
event listeners hard.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-16
Reviewed by Sam Weinig and Anders Carlsson.

dom/Node.cpp:

(WebCore::Node::addEventListener): No need to limit when event listeners
can be added. Other EventTargets don't do this.

Also, check for null when accessing document(). Technically, the JS bindings
do this check for us, but let's not rely on that.

LayoutTests: Added a test for a potential crash when adding an event listener to a
doctype node.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-16
Reviewed by Sam Weinig.

fast/dom/doctype-event-listener-crash-expected.txt: Added.
fast/dom/doctype-event-listener-crash.html: Added.

4:25 PM Changeset in webkit [48446] by andersca@apple.com

3 edits in trunk/WebCore

<rdar://problem/7155710>
HTML selects on windows cause containing window to become inactive when opened

Reviewed by Adam Roben.

Redo the way we handle events when a popup menu is shown, based on
http://blogs.msdn.com/oldnewthing/archive/2004/08/20/217684.aspx

Since a non-active window can't capture the mouse, we use the owning window
(the WebView) as the capture window. We then run a recursive message pump that
forwards all mouse and keyboard events to the popup menu.

platform/PopupMenu.h:
platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::PopupMenu):
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::hide):
(WebCore::PopupMenu::wndProc):

4:23 PM Changeset in webkit [48445] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2009-09-16 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Darin Adler.

Fix GCC warnings on ARM_THUMB2 platform

assembler/ARMv7Assembler.h: (JSC::ARMThumbImmediate::countLeadingZerosPartial):
assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::branchTruncateDoubleToInt32): (JSC::MacroAssemblerARMv7::moveFixedWidthEncoding):

4:14 PM Changeset in webkit [48444] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-09-16 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Reviewed by Eric Seidel.

Detect and add Windows7 properly to the user agent.

Api/qwebpage.cpp: (QWebPage::userAgentForUrl):

4:06 PM Changeset in webkit [48443] by mitz@apple.com

2 edits in trunk/WebCore

Speculative fix for
<rdar://problem/6937089> Crashes at RenderWidget::destroy()

Reviewed by Ada Chan.

rendering/RenderWidget.cpp:

(WebCore::RenderWidget::destroy): Avoid calling renderArena() if node()
is null. Add two assertions that can help determine how this crash
happens (in particular, whether node() becomes null during destroy() or
it is null before destroy() is called).

3:17 PM Changeset in webkit [48442] by Beth Dakin

2 edits in trunk/WebCore

Speculative build fix.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

3:08 PM Changeset in webkit [48441] by Beth Dakin

16 edits
7 adds in trunk

WebCore: Fix for <rdar://problem/7083741> Implement a CSS extension to
adjust sub-pixel anti-aliasing for text
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29291

Reviewed by Darin Adler.

Added tests:

fast/css/font-smoothing.html: Added.
fast/css/parsing-webkit-font-smoothing.html: Added.

This patch adds a new CSS property called -webkit-font-smoothing
that accepts the following as valid input: auto | none |
antialiased | subpixel-antialiased

Return appropriate computed style for -webkit-font-smoothing

css/CSSComputedStyleDeclaration.cpp:

(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

Add a case for CSSPropertyWebkitFontSmoothing, and accept valid
input.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

Add mappings for FontSmoothing to the right CSS values.

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator FontSmoothing):

Add -webkit-font-smoothing

css/CSSPropertyNames.in:

Set fontSmoothing on the FontDescription.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

Add antialiased and subpixel-antialiased as possible new CSS
values.

css/CSSValueKeywords.in:

Store the font smoothing CSS value in the FontDescription.

platform/graphics/FontDescription.h:

(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::fontSmoothing):
(WebCore::FontDescription::setFontSmoothing):
(WebCore::FontDescription::operator==):

Call setShouldAntialias() and setShouldUseSmoothing() appropriately
based on the CSS fontSmoothing() value.

platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs):

platform/graphics/win/FontCGWin.cpp:

(WebCore::Font::drawGlyphs):

New function fontSmoothing()

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::fontSmoothing):

New enum FontSmoothing.

rendering/style/RenderStyleConstants.h:

(WebCore::):

LayoutTests: Tests for <rdar://problem/7083741> Implement a CSS extension to
adjust sub-pixel anti-aliasing for text

Reviewed by Darin Adler.

New tests:

fast/css/font-smoothing.html: Added.
fast/css/parsing-webkit-font-smoothing-expected.txt: Added.
fast/css/parsing-webkit-font-smoothing.html: Added.
fast/css/resources/parsing-webkit-font-smoothing.js: Added.

(test):

platform/mac/fast/css/font-smoothing-expected.checksum: Added.
platform/mac/fast/css/font-smoothing-expected.png: Added.
platform/mac/fast/css/font-smoothing-expected.txt: Added.

These tests have updated results now that -webkit-font-smoothing is
reported with computed style.

platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

2:52 PM Changeset in webkit [48440] by Adam Roben

3 edits in trunk/WebKit/win

Add a UI delegate callback to let the delegate draw a WebView's background

Fixes <http://webkit.org/b/29315>.

Reviewed by Dave Hyatt.

Interfaces/IWebUIDelegatePrivate.idl: Added

IWebUIDelegatePrivate2::drawBackground.

WebView.cpp:

(WebView::paintIntoBackingStore): After clearing or filling with
white, let the delegate draw whatever background it wants. Also added
an assertion that the dirty rect is within our bounds.

2:47 PM Changeset in webkit [48439] by Adam Roben

2 edits in trunk/WebKit/win

Prevent WebView from painting over sibling windows

Fixes <http://webkit.org/b/29300> <rdar://problem/7227960> WebView can
paint over sibling windows

Reviewed by Darin Adler.

WebView.cpp:

(WebView::initWithFrame): Create the WebView's HWND with the
WS_CLIPSIBLINGS style.

2:46 PM Changeset in webkit [48438] by ajwong@chromium.org

5 edits in trunk/WebCore

2009-09-16 Albert J. Wong <ajwong@chromium.org>

Reviewed by David Levin.

Reimplement default media UI for Mac Chromium to match the style
of the Windows and Linux versions. Also breaks the dependency
on the internal wk* functions that were previously used to
render the media controller widgets.
https://bugs.webkit.org/show_bug.cgi?id=29161

No media layout tests are currently enabled in Mac Chromium, so
nothing needs rebaselineing, etc.

css/mediaControlsChromium.css:
rendering/RenderThemeChromiumMac.h:
rendering/RenderThemeChromiumMac.mm: (WebCore::mediaElementParent): (WebCore::RenderThemeChromiumMac::extraMediaControlsStyleSheet): (WebCore::mediaSliderThumbImage): (WebCore::mediaVolumeSliderThumbImage): (WebCore::RenderThemeChromiumMac::paintSliderTrack): (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): (WebCore::RenderThemeChromiumMac::paintMediaButtonInternal): (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground):
rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):

2:38 PM Changeset in webkit [48437] by eric@webkit.org

4 edits in trunk/WebCore

2009-09-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Remove style property if empty string is entered.

https://bugs.webkit.org/show_bug.cgi?id=29163

inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._onmouseout): fixed null pointer exception
inspector/front-end/InjectedScript.js: (InjectedScript.applyStyleText): if styletext to apply is empty it will return an array to confirm the property removal
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):

2:31 PM Changeset in webkit [48436] by eric@webkit.org

3 edits
5 adds in trunk

2009-09-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Added a test that checks that margin property shorthand has correct value
when there is background-repeat property in the style declaration.

https://bugs.webkit.org/show_bug.cgi?id=28973

fast/backgrounds/repeat/margin-shorthand-expected.txt: Added.
fast/backgrounds/repeat/margin-shorthand.html: Added.
fast/backgrounds/repeat/resources/TEMPLATE.html: Added.
fast/backgrounds/repeat/resources/margin-shorthand.css: Added.
fast/backgrounds/repeat/resources/margin-shorthand.js: Added. (iconMarginValue):

2009-09-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Always reset m_implicitShorthand to false after parsing
background-repeat style property otherwise properties
following after it may be erroneously marked as implicit.

https://bugs.webkit.org/show_bug.cgi?id=28972
https://bugs.webkit.org/show_bug.cgi?id=28973

Test: fast/backgrounds/repeat/margin-shorthand.html

css/CSSParser.cpp: (WebCore::CSSParser::parseValue):

2:05 PM Changeset in webkit [48435] by Simon Fraser

2 edits in trunk/WebKit/mac

2009-09-16 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt.

Work around a bug in AppKit on Leopard which causes compositing layers to jitter, and
become misplaced when the WebHTMLView is resized or scrolled sometimes.
<rdar://problem/7071636>

We call an internal AppKit method to make sure the layer geometry is updated correctly.

WebView/WebHTMLView.mm: (-[WebHTMLView _updateLayerHostingViewPosition]):

1:40 PM Changeset in webkit [48434] by kevino@webkit.org

2 edits in trunk/WebKitTools

wx build fix to support monolithic builds on Windows.

1:36 PM Changeset in webkit [48433] by eric@webkit.org

3 edits
4 adds
4 deletes in trunk

2009-09-16 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Alexey Proskuryakov.

Incorrect behavior of XMLHttpRequest::getAllResponseHeaders and XMLHttpRequest::getResponseHeader in the
HEADERS_RECEIVED readyState.
https://bugs.webkit.org/show_bug.cgi?id=29121

http/tests/xmlhttprequest/getAllResponseHeaders-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt.
http/tests/xmlhttprequest/getAllResponseHeaders.html: Copied from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html.
http/tests/xmlhttprequest/getResponseHeader-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt.
http/tests/xmlhttprequest/getResponseHeader.html: Copied from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html.
http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt: Removed.
http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html: Removed.
http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt: Removed.
http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html: Removed. Modified xmlhttprequest-InvalidStateException-getAllRequestHeaders and xmlhttprequest-InvalidStateException-getRequestHeader to match the current spec and code behavior. Extended the first test to cover other aspects of the getAllResponseHeaders method and planning the same extension for the second test. The extension for the second test is to be submitted with the patch for bug 29140. Renamed the 2 tests to a shorter more accurate name, given their new intended scope.

2009-09-16 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Alexey Proskuryakov.

Incorrect behavior of XMLHttpRequest::getAllResponseHeaders and
XMLHttpRequest::getResponseHeader in the
HEADERS_RECEIVED readyState.
https://bugs.webkit.org/show_bug.cgi?id=29121

Tests: http/tests/xmlhttprequest/getAllResponseHeaders.html

http/tests/xmlhttprequest/getResponseHeader.html

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): Changed the minimum valid state from LOADING to HEADERS_RECEIVED.

1:23 PM Changeset in webkit [48432] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-16 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix style violation in V8AbstractEventListener.
https://bugs.webkit.org/show_bug.cgi?id=29303

bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::operator==):

1:16 PM Changeset in webkit [48431] by eric@webkit.org

10 edits
2 adds in trunk/WebCore

2009-09-16 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Add Watch Expression support to inspector
https://bugs.webkit.org/show_bug.cgi?id=27514

Manual test added.

English.lproj/localizedStrings.js:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype.evalInInspectedWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed):
inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update.callback): (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertiesSection.prototype.updateProperties): (WebInspector.ObjectPropertiesSection.CompareProperties): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.update):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._callFrameSelected):
inspector/front-end/WatchExpressionsSidebarPane.js: Added. (WebInspector.WatchExpressionsSidebarPane): (WebInspector.WatchExpressionsSidebarPane.prototype.refreshExpressions): (WebInspector.WatchExpressionsSection): (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionsSection.prototype.addExpression): (WebInspector.WatchExpressionsSection.prototype.updateExpression): (WebInspector.WatchExpressionsSection.prototype.findAddedTreeElement): (WebInspector.WatchExpressionsSection.prototype.loadSavedExpressions): (WebInspector.WatchExpressionsSection.prototype.saveExpressions): (WebInspector.WatchExpressionsSection.CompareProperties): (WebInspector.WatchExpressionTreeElement): (WebInspector.WatchExpressionTreeElement.prototype.update): (WebInspector.WatchExpressionTreeElement.prototype._deleteButtonClicked): (WebInspector.WatchExpressionTreeElement.prototype.startEditing): (WebInspector.WatchExpressionTreeElement.prototype.editingCancelled): (WebInspector.WatchExpressionTreeElement.prototype.applyExpression):
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.css:
inspector/front-end/inspector.html:
manual-tests/inspector/debugger-watch-expressions.html: Added.

12:50 PM Changeset in webkit [48430] by bolsinga@apple.com

46 edits
1 add in trunk

Add ENABLE(INSPECTOR)
https://bugs.webkit.org/show_bug.cgi?id=29260

Reviewed by David Kilzer.

JavaScriptCore:

wtf/Platform.h:

WebCore:

No new tests. (No change in default behavior.)

DerivedSources.make: Use new WebCore.Inspector.exp file if ENABLE_DRAG_SUPPORT.
WebCore.base.exp: Move Inspector only exports to WebCore.Inspector.exp.
WebCore.xcodeproj/project.pbxproj: Add WebCore.Inspector.exp.
bindings/js/JSDOMWindowBase.cpp: Use ENABLE(INSPECTOR) where applicable.

(WebCore::JSDOMWindowBase::supportsProfiling):

bindings/js/JSInspectedObjectWrapper.cpp: Wrap entire file in ENABLE(INSPECTOR).
bindings/js/JSInspectorBackendCustom.cpp: Ditto.
bindings/js/JSInspectorCallbackWrapper.cpp: Ditto.
bindings/js/ScriptObject.cpp: Use ENABLE(INSPECTOR) where applicable.
bindings/js/ScriptObject.h: Ditto.
bindings/js/ScriptObjectQuarantine.cpp: Wrap entire file in ENABLE(INSPECTOR).
dom/Document.cpp: Use ENABLE(INSPECTOR) where applicable.

(WebCore::Document::recalcStyle):
(WebCore::Document::addMessage):
(WebCore::Document::resourceRetrievedByXMLHttpRequest):
(WebCore::Document::scriptImported):

dom/Document.h: Ditto.
dom/Node.cpp: Ditto.

(WebCore::Node::dispatchGenericEvent):

dom/ScriptExecutionContext.h: Ditto.

(WebCore::):

html/HTMLDocument.cpp: Ditto.

(WebCore::HTMLDocument::createTokenizer):

html/HTMLTokenizer.cpp: Ditto.

(WebCore::HTMLTokenizer::write):

inspector/ConsoleMessage.cpp: Ditto.

(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::isEqual):

inspector/ConsoleMessage.h: Ditto.
inspector/DOMDispatchTimelineItem.cpp: Wrap entire file in ENABLE(INSPECTOR).
inspector/InspectorBackend.cpp: Ditto.
inspector/InspectorController.cpp: Ditto.
inspector/InspectorDOMAgent.cpp: Ditto.
inspector/InspectorDOMStorageResource.cpp: Ditto.
inspector/InspectorDatabaseResource.cpp: Ditto.
inspector/InspectorFrontend.cpp: Ditto.
inspector/InspectorResource.cpp: Ditto.
inspector/InspectorTimelineAgent.cpp: Ditto.
inspector/TimelineItem.cpp: Ditto.
loader/FrameLoader.cpp: Use ENABLE(INSPECTOR) where applicable.

(WebCore::FrameLoader::detachFromParent):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::loadedResourceFromMemoryCache):
(WebCore::FrameLoader::dispatchWindowObjectAvailable):
(WebCore::FrameLoader::dispatchDidCommitLoad):
(WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
(WebCore::FrameLoader::dispatchWillSendRequest):
(WebCore::FrameLoader::dispatchDidReceiveResponse):
(WebCore::FrameLoader::dispatchDidReceiveContentLength):
(WebCore::FrameLoader::dispatchDidFinishLoading):

page/Chrome.cpp: Ditto.

(WebCore::Chrome::mouseDidMoveOverElement):

page/Console.cpp: Ditto.

(WebCore::Console::addMessage):
(WebCore::Console::count):
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
(WebCore::Console::time):
(WebCore::Console::timeEnd):
(WebCore::Console::group):
(WebCore::Console::groupEnd):

page/ContextMenuController.cpp: Ditto.

(WebCore::ContextMenuController::handleContextMenuEvent):
(WebCore::ContextMenuController::contextMenuItemSelected):

page/DOMWindow.cpp: Ditto.

(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

page/EventHandler.cpp: Ditto.

(WebCore::EventHandler::handleMousePressEvent):

page/FrameView.cpp: Ditto.

(WebCore::FrameView::layout):
(WebCore::FrameView::paintContents):

page/FrameView.h: Ditto.
page/Page.cpp: Ditto.

(WebCore::Page::Page):
(WebCore::Page::~Page):

page/Page.h: Ditto.
platform/ContextMenu.cpp: Ditto.

(WebCore::ContextMenu::checkOrEnableIfNeeded):

platform/ContextMenuItem.h: Ditto.

(WebCore::):

storage/Database.cpp: Ditto.

(WebCore::Database::openDatabase):

workers/WorkerContext.cpp: Ditto.

(WebCore::WorkerContext::importScripts):

xml/XMLHttpRequest.cpp: Ditto.

(WebCore::XMLHttpRequest::didFinishLoading):

12:40 PM Changeset in webkit [48429] by bolsinga@apple.com

21 edits
1 add in trunk

Add ENABLE(CONTEXT_MENUS)
https://bugs.webkit.org/show_bug.cgi?id=29225

Reviewed by David Kilzer.

JavaScriptCore:

wtf/Platform.h:

WebCore:

No new tests. (No change in default behavior.)

DerivedSources.make: Use new WebCore.ContextMenus.exp file if ENABLE_CONTEXT_MENUS.
WebCore.base.exp: Move ContextMenu only exports to WebCore.ContextMenus.exp.
WebCore.xcodeproj/project.pbxproj: Add WebCore.ContextMenus.exp.
dom/Node.cpp: Use ENABLE(CONTEXT_MENUS) where applicable.

(WebCore::Node::defaultEventHandler):

loader/EmptyClients.h: Ditto.
page/ContextMenuController.cpp: Wrap entire file in ENABLE(CONTEXT_MENUS).
page/EventHandler.cpp: Use ENABLE(CONTEXT_MENUS) where applicable.
page/EventHandler.h: Ditto.
page/Page.cpp: Ditto.

(WebCore::Page::Page):

page/Page.h: Ditto.
page/mac/EventHandlerMac.mm: Ditto.
page/mac/WebCoreViewFactory.h: Ditto.
platform/ContextMenu.cpp: Wrap entire file in ENABLE(CONTEXT_MENUS).
platform/LocalizedStrings.h: Use ENABLE(CONTEXT_MENUS) where applicable.
platform/mac/ContextMenuItemMac.mm: Wrap entire file in ENABLE(CONTEXT_MENUS).
platform/mac/ContextMenuMac.mm: Ditto.
platform/mac/LocalizedStringsMac.mm: Use ENABLE(CONTEXT_MENUS) where applicable.
svg/graphics/SVGImage.cpp: Ditto.

(WebCore::SVGImage::dataChanged):

12:37 PM Changeset in webkit [48428] by hyatt@apple.com

4 edits in trunk/WebCore

Clean up invalidation for repainting. Hoist the dirty rect intersection test in ScrollViewMac up
into ScrollView so that all platforms do it.

Reviewed by Adam Roben.

Patch deferred repaints in FrameView::repaintContentRectangle to only add the visible portion of
the rectangle for repainting.

page/FrameView.cpp:

(WebCore::FrameView::repaintContentRectangle):

platform/ScrollView.cpp:

(WebCore::ScrollView::repaintContentRectangle):

platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformRepaintContentRectangle):

12:29 PM Changeset in webkit [48427] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2009-09-16 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Reviewed by Eric Seidel.

The webkit stdint and stdbool headers exists because
the compiler MSVC doesn't include them. The check
should not check for PLATFORM(WIN_OS) but for MSVC.

os-win32/stdbool.h:
os-win32/stdint.h:

12:10 PM Changeset in webkit [48426] by bolsinga@apple.com

25 edits
1 add in trunk

Add ENABLE(DRAG_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=29233

Reviewed by David Kilzer.

JavaScriptCore:

wtf/Platform.h:

WebCore:

No new tests. (No change in default behavior.)

DerivedSources.make: Use new WebCore.DragSupport.exp file if ENABLE_DRAG_SUPPORT.
WebCore.base.exp: Move Drag Support only exports to WebCore.DragSupport.exp.
WebCore.xcodeproj/project.pbxproj: Add WebCore.DragSupport.exp.
dom/Clipboard.h: Use ENABLE(DRAG_SUPPORT) where applicable.
loader/EmptyClients.h: Ditto.
page/DragController.cpp: Wrap entire file in ENABLE(DRAG_SUPPORT).
page/EventHandler.cpp: Use ENABLE(DRAG_SUPPORT) where applicable.

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handleMouseMoveEvent):

page/EventHandler.h: Ditto.
page/Page.cpp: Ditto.

(WebCore::Page::Page):

page/Page.h: Ditto.
page/mac/DragControllerMac.mm: Wrap entire file in ENABLE(DRAG_SUPPORT).
page/mac/EventHandlerMac.mm: Use ENABLE(DRAG_SUPPORT) where applicable.

(WebCore::EventHandler::passSubframeEventToSubframe):

platform/DragData.cpp: Wrap entire file in ENABLE(DRAG_SUPPORT).
platform/DragImage.cpp: Wrap entire file in ENABLE(DRAG_SUPPORT).
platform/mac/ClipboardMac.h: Use ENABLE(DRAG_SUPPORT) where applicable.
platform/mac/ClipboardMac.mm: Ditto.
platform/mac/DragDataMac.mm: Wrap entire file in ENABLE(DRAG_SUPPORT).
platform/mac/DragImageMac.mm: Wrap entire file in ENABLE(DRAG_SUPPORT).
rendering/RenderLayer.cpp: Use ENABLE(DRAG_SUPPORT) where applicable.

(WebCore::RenderLayer::autoscroll):

rendering/RenderObject.cpp: Ditto.
rendering/RenderObject.h: Ditto.
svg/graphics/SVGImage.cpp: Ditto.

(WebCore::SVGImage::dataChanged):

12:02 PM Changeset in webkit [48425] by kevino@webkit.org

3 edits in trunk/WebCore

wxMSW build fix after adding support for high resolution times in Win.

10:55 AM Changeset in webkit [48424] by kevino@webkit.org

2 edits in trunk/JavaScriptCore

waf build fix after flag was moved to correct place.

10:25 AM Changeset in webkit [48423] by kenneth@webkit.org

2 edits in trunk/WebKit/qt

Rubberstamped by Kenneth Christiansen.

Patch by Andras Becsi <andrewbecsi@yahoo.co.uk> on 2009-09-16
[Qt] Build fix for previous changes.

QGVLauncher/main.cpp:

(MainView::flip):

9:59 AM Changeset in webkit [48422] by kevino@webkit.org

3 edits in trunk/WebKitTools

wx build fix, improve debug support and 2.9 support on MSW.

9:11 AM Changeset in webkit [48421] by kenneth@webkit.org

2 edits in trunk/WebKit/qt

Unreviewed potential Qt < 4.6 build fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-16

QGVLauncher/main.cpp:

(MainView::flip):

8:55 AM Changeset in webkit [48420] by kov@webkit.org

2 edits in trunk/WebKitTools

2009-09-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Blind try at fixing new test failure on Windows.

DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didReceiveTitle):

8:20 AM Changeset in webkit [48419] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-09-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

One more try at rebaselining the tests for those who dump frame
loader delegates.

http/tests/loading/redirect-with-no-location-crash-expected.txt:

7:29 AM Changeset in webkit [48418] by Dimitri Glazkov

3 edits in trunk/WebCore

2009-09-16 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Added operator==() to event listeners. This fixes V8 bindings
build broken in http://trac.webkit.org/changeset/48402.
https://bugs.webkit.org/show_bug.cgi?id=29298

bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): Now uses JSEventListenerType.
bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::operator==): Only compares pointers since we create at most one wrapper for a JS object.

7:29 AM Changeset in webkit [48417] by kov@webkit.org

2 edits
1 copy
3 adds in trunk/LayoutTests

2009-09-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Rebaseline for those who support dumping of frame
loader delegates, add specific expected result to GTK+

http/tests/loading/redirect-with-no-location-crash-expected.txt:
platform/gtk/http/tests/loading/redirect-with-no-location-crash-expected.txt: Copied from LayoutTests/http/tests/loading/redirect-with-no-location-crash-expected.txt.

6:49 AM Changeset in webkit [48416] by kenneth@webkit.org

2 edits in trunk/WebKit/qt

Add a "Flip effect" to our GraphicsView based launcher.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-16
Reviewed by Simon Hausmann.

QGVLauncher/main.cpp:

(MainView::resizeEvent):
(MainView::flip):
(MainWindow::flip):
(MainWindow::buildUI):

6:46 AM Changeset in webkit [48415] by vestbo@webkit.org

2 edits in trunk/JavaScriptCore

[Qt] Build fix for 64-bit Qt on Mac OS X

Reviewed by Simon Hausmann.

wtf/Platform.h: Use JSVALUE64 on DARWIN, not only on MAC

6:40 AM Changeset in webkit [48414] by zoltan@webkit.org

2 edits in trunk/WebKit/qt

2009-09-16 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Rubber-stamped by Simon Hausmann.

[Qt] Typo fix. Pass the window object to the Format
menu. In this way Qt can free its internal graphical
objects during exit.

QtLauncher/main.cpp: (MainWindow::setupUI):

6:37 AM Changeset in webkit [48413] by kov@webkit.org

3 edits
3 adds in trunk

WebCore:

2009-09-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Crash when visiting http://flipper.googlelabs.com/
https://bugs.webkit.org/show_bug.cgi?id=29293

Check type for being null or empty before looking it up in the
hash of supported types.

Tested by http/tests/loading/redirect-with-no-location-crash.html

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::supportsType):

LayoutTests:

2009-09-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Crash when visiting http://flipper.googlelabs.com/
https://bugs.webkit.org/show_bug.cgi?id=29293

http/tests/loading/redirect-with-no-location-crash.html: Added.
http/tests/loading/redirect-with-no-location-crash-expected.html: Added.
http/tests/loading/resources/redirect-with-no-location-crash.php: Added.

6:18 AM Changeset in webkit [48412] by zoltan@webkit.org

2 edits in trunk/JavaScriptCore

2009-09-16 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Fix wtf/ThreadSpecific.h under Qt to free thread local objects.
https://bugs.webkit.org/show_bug.cgi?id=29295

This is an important fix when JavaScript workers are in use, since
unfreed ThreadGlobalDatas leak a big amount of memory (50-100k each).
QThreadStorage calls the destructor of a given object, which is the
ThreadSpecific::Data. Unlike pthread, Qt is object oriented, and does
not support the calling of a static utility function when the thread
is about to close. In this patch we call the ThreadSpecific::destroy()
utility function from the destructor of ThreadSpecific::Data. Moreover,
since Qt resets all thread local values to 0 before the calling of the
appropriate destructors, we set back the pointer to its original value.
This is necessary because the get() method of the ThreadSpecific
object may be called during the exuction of the destructor.

wtf/ThreadSpecific.h: (WTF::ThreadSpecific::Data::~Data): (WTF::::~ThreadSpecific): (WTF::::set): (WTF::::destroy):

4:50 AM Changeset in webkit [48411] by vestbo@webkit.org

2 edits in trunk/WebKit/qt

[Qt] Build break fix on gcc ARM.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-16
Reviewed by Tor Arne Vestbø.

Api/qwebgraphicsitem.cpp:

(QWebGraphicsItemPrivate::_q_doLoadProgress):

1:58 AM Changeset in webkit [48410] by Simon Hausmann

2 edits in trunk/WebKit/qt

Fix a crash in QWebFrame::hasFocus() with a simple null pointer check
when the focused frame is null. We do the same check in other places
where we call kit().

Patch by Warwick Allison <warwick.allison@nokia.com> on 2009-09-16
Reviewed by Simon Hausmann.

Api/qwebframe.cpp:

(QWebFrame::hasFocus):

1:56 AM Changeset in webkit [48409] by Simon Hausmann

2 edits in trunk/WebKit/qt

Fixed a typo found during translation.

Patch by Jure Repinc <jlp@holodeck1.com> on 2009-09-16
Reviewed by Simon Hausmann.

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::interruptForPolicyChangeError):

Sep 15, 2009:

10:20 PM Changeset in webkit [48408] by Chris Fleizach

2 edits in trunk/LayoutTests

WAI-ARIA: add support for ranges, including the progressbar, slider, and spinbutton roles
https://bugs.webkit.org/show_bug.cgi?id=28841

Layout test fix redux.
The paths to the fast/js resources needed to be updated.

platform/mac/accessibility/aria-slider-value-change.html:

8:39 PM Changeset in webkit [48407] by Chris Fleizach

1 edit
2 moves in trunk/LayoutTests

Layout test fix.
This test should only be for Mac, since the other platforms don't support the necessary features.

WAI-ARIA: add support for ranges, including the progressbar, slider, and spinbutton roles
https://bugs.webkit.org/show_bug.cgi?id=28841

accessibility/aria-slider-value-change-expected.txt: Removed.
accessibility/aria-slider-value-change.html: Removed.
platform/mac/accessibility/aria-slider-value-change-expected.txt: Copied from LayoutTests/accessibility/aria-slider-value-change-expected.txt.
platform/mac/accessibility/aria-slider-value-change.html: Copied from LayoutTests/accessibility/aria-slider-value-change.html.

6:30 PM Changeset in webkit [48406] by ggaren@apple.com

4 edits in trunk/WebCore

Removed the notion of "disconnected nodes with event listeners" because
it was vestigial. The reference cycle it tried to solve was solved another
way in https://bugs.webkit.org/show_bug.cgi?id=21260.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-15
Reviewed by Sam Weinig.

dom/Document.cpp:

(WebCore::Document::removeAllEventListeners):

dom/Document.h:
dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::insertedIntoDocument):
(WebCore::Node::removedFromDocument):
(WebCore::Node::willMoveToNewOwnerDocument):
(WebCore::Node::didMoveToNewOwnerDocument):
(WebCore::Node::addEventListener):
(WebCore::Node::removeEventListener):
(WebCore::Node::clearAttributeEventListener):

5:40 PM Changeset in webkit [48405] by Chris Fleizach

7 edits
2 adds in trunk

WAI-ARIA: add support for ranges, including the progressbar, slider, and spinbutton roles
https://bugs.webkit.org/show_bug.cgi?id=28841

Reviewed by Beth Dakin.

WebCore:

Allow certain ARIA roles to change value with AXIncrement and AXDecrement.
Consolidate increment/decrement/changeValue methods.

Test: accessibility/aria-slider-value-change.html

accessibility/AccessibilityObject.cpp:
accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::increment):
(WebCore::AccessibilityRenderObject::decrement):
(WebCore::AccessibilityRenderObject::changeValueByPercent):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):

accessibility/AccessibilityRenderObject.h:
accessibility/AccessibilitySlider.cpp:
accessibility/AccessibilitySlider.h:
dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

LayoutTests:

accessibility/aria-slider-value-change-expected.txt: Added.
accessibility/aria-slider-value-change.html: Added.

4:52 PM Changeset in webkit [48404] by bweinstein@apple.com

2 edits in trunk/LayoutTests

2009-09-15 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Steve Falkenburg.

Add four currently failing tests to the Skipped list so we can figure out what's wrong
with them and try to get the bot closer to green. Bugs have been filed for each test.

platform/win/Skipped:

4:17 PM Changeset in webkit [48403] by oliver@apple.com

8 edits in trunk/JavaScriptCore

Allow anonymous storage inside JSObject
https://bugs.webkit.org/show_bug.cgi?id=29168

Reviewed by Geoff Garen

Add the concept of anonymous slots to Structures so that it is
possible to store references to values that need marking in the
standard JSObject storage buffer. This allows us to reduce the
malloc overhead of some objects (by allowing them to store JS
values in the inline storage of the object) and reduce the
dependence of custom mark functions (if all an objects children
are in the standard object property storage there's no need to
mark them manually).

2:47 PM Changeset in webkit [48402] by ggaren@apple.com

33 edits in trunk/WebCore

Removed the jsEventListeners set from JSDOMGlobalObject, to simplify
creation and destruction of JSDOMGlobalObject and event listeners.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-15
Reviewed by Sam Weinig.

Added an abstract operator==() to EventListener, to replace the
jsEventListeners set's role in determining if two event listeners are
equal from the DOM's perspective.

Added a type field to EventListener, and casting operations, to support
operator==() and other abstract operations.

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSAbstractWorkerCustom.cpp:

(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):

bindings/js/JSDOMApplicationCacheCustom.cpp:

(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):

bindings/js/JSDOMGlobalObject.cpp:
bindings/js/JSDOMGlobalObject.h:
bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

bindings/js/JSDesktopNotificationsCustom.cpp:

(WebCore::JSNotification::addEventListener):
(WebCore::):

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):
(WebCore::JSEventListener::markJSFunction):
(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):
(WebCore::JSEventListener::operator==):

bindings/js/JSEventListener.h:

(WebCore::JSEventListener::cast):

bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):

bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):

bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):

bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):

bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):

bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):

bindings/js/JSXMLHttpRequestUploadCustom.cpp:

(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):

bindings/objc/ObjCEventListener.h:

(WebCore::ObjCEventListener::cast):

bindings/objc/ObjCEventListener.mm:

(WebCore::ObjCEventListener::ObjCEventListener):
(WebCore::ObjCEventListener::operator==):

dom/EventListener.h:

(WebCore::EventListener::):
(WebCore::EventListener::type):
(WebCore::EventListener::EventListener):

dom/MessagePort.cpp:

(WebCore::MessagePort::addEventListener):
(WebCore::MessagePort::removeEventListener):

dom/Node.cpp:

(WebCore::Node::removeEventListener):

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::mainFrameDocument):
(WebCore::InspectorDOMAgent::operator==):

inspector/InspectorDOMAgent.h:

(WebCore::InspectorDOMAgent::cast):

loader/ImageDocument.cpp:

(WebCore::ImageEventListener::cast):
(WebCore::ImageEventListener::ImageEventListener):
(WebCore::ImageEventListener::operator==):

loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::addEventListener):
(WebCore::DOMApplicationCache::removeEventListener):

notifications/Notification.cpp:

(WebCore::Notification::removeEventListener):

page/DOMWindow.cpp:

(WebCore::DOMWindow::removeEventListener):

page/EventSource.cpp:

(WebCore::EventSource::addEventListener):
(WebCore::EventSource::removeEventListener):

svg/animation/SVGSMILElement.cpp:

(WebCore::ConditionEventListener::cast):
(WebCore::ConditionEventListener::ConditionEventListener):
(WebCore::ConditionEventListener::operator==):
(WebCore::ConditionEventListener::handleEvent):

workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::addEventListener):
(WebCore::AbstractWorker::removeEventListener):

workers/WorkerContext.cpp:

(WebCore::WorkerContext::addEventListener):
(WebCore::WorkerContext::removeEventListener):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::addEventListener):
(WebCore::XMLHttpRequest::removeEventListener):

xml/XMLHttpRequestUpload.cpp:

(WebCore::XMLHttpRequestUpload::addEventListener):
(WebCore::XMLHttpRequestUpload::removeEventListener):

2:26 PM Changeset in webkit [48401] by Simon Fraser

2 edits in trunk/WebKit/mac

2009-09-15 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Fixed position elements flash when CSS transforms are applied on page > 2048px tall
https://bugs.webkit.org/show_bug.cgi?id=27272

Update the previous workaround for misplaced compositing layers, which used a 4096px
threshold, to 2048px since that's the GPU max texture size on some older hardware.

WebView/WebHTMLView.mm: (-[WebHTMLView _updateLayerHostingViewPosition]):

1:46 PM WebKit Team edited by vestbo@webkit.org

(diff)

1:33 PM Changeset in webkit [48400] by vestbo@webkit.org

8 edits in trunk

Added ENABLE_MATHML feature define and build-webkit toggle

Patch by Alex Milowski <alex@milowski.com> on 2009-09-15
Reviewed by Tor Arne Vestbø.

JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

WebCore:

Configurations/FeatureDefines.xcconfig:

WebKit/mac:

Configurations/FeatureDefines.xcconfig:

WebKitTools:

Scripts/build-webkit:

1:25 PM CommitQueue edited by eric@webkit.org

(diff)

12:25 PM Changeset in webkit [48399] by kevino@webkit.org

2 edits in trunk/WebKitTools

wx build fix. Allow waf build to support Python < 2.6.

11:40 AM Changeset in webkit [48398] by mrowe@apple.com

7 edits in trunk

WebCore: Document.elementFromPoint() and Document.caretRangeFromPoint() erroneously returning null at points visible only after scrolling.
https://bugs.webkit.org/show_bug.cgi?id=29245

Patch by Andrew Richards <randrew@gmail.com> on 2009-09-14
Reviewed by Sam Weinig.

Use visibleContentRect() instead of boundsRect() when checking hit point bounds on viewport.

dom/Document.cpp:

(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):

LayoutTests: Document.elementFromPoint() and Document.caretRangeFromPoint() returning null at points visible only after scrolling.
https://bugs.webkit.org/show_bug.cgi?id=29245

Patch by Andrew Richards <randrew@gmail.com> on 2009-09-14
Reviewed by Sam Weinig.

Extend tests to include hits in areas that are not in the initial containing block of the page.

fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
fast/dom/elementFromPoint-relative-to-viewport.html:

11:36 AM Changeset in webkit [48397] by jshin@chromium.org

3 edits
9 adds in trunk

2009-09-15 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel

http://bugs.webkit.org/show_bug.cgi?id=26660

Chromium Windows: When rotated, the baseline for a span of complex
script is completely misaligned with that of the adjacent
simple script text. It's fixed by not applying the baseline offset for
the Skia code path.

Test: transforms/2d/hindi-rotated.html

platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::draw):

2009-09-15 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel

http://bugs.webkit.org/show_bug.cgi?id=26660

Chromium Windows: When rotated, the baseline for a span of complex
script is completely misaligned with that of the adjacent simple
script text.

transforms/2d/hindi-rotated.html: Added.
platform/mac/transforms/2d/hindi-rotated-expected.checksum: Added.
platform/mac/transforms/2d/hindi-rotated-expected.png: Added.
platform/mac/transforms/2d/hindi-rotated-expected.txt: Added.
platform/win/transforms: Added.
platform/win/transforms/2d: Added.
platform/win/transforms/2d/hindi-rotated-expected.checksum: Added.
platform/win/transforms/2d/hindi-rotated-expected.png: Added.
platform/win/transforms/2d/hindi-rotated-expected.txt: Added.

11:30 AM Changeset in webkit [48396] by andersca@apple.com

2 edits in trunk/WebCore

Pass the PopupMenu pointer to CreateWindowEx and then get it from the LPCREATESTRUCT in
the WM_CREATE handler. This way we don't have to first create an zero size window and then size it.

Reviewed by Adam Roben.

platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::show):
(WebCore::PopupMenu::PopupMenuWndProc):

11:27 AM Changeset in webkit [48395] by atwilson@chromium.org

5 edits in trunk

MessageEvent should not be cancelable by default
https://bugs.webkit.org/show_bug.cgi?id=27846

Reviewed by Darin Adler.

WebCore:

dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):
Changed constructor to set cancelable=false by default, per the HTML5 spec.

LayoutTests:

fast/events/message-port-expected.txt:
fast/events/message-port.html:

Added test case to check state of MessageEvent.cancelable attribute.

11:20 AM Changeset in webkit [48394] by mrowe@apple.com

2 edits in trunk/WebKit/mac

<rdar://problem/7224378> REGRESSION(r48360): Dragging a tab with a plug-in out of a window, the plug-in gets slow and confused

Reviewed by Anders Carlsson.

In r48360, the fix for <rdar://problem/7090444>, I neglected to consider the case where the plug-in had already been started and
-start would do an early-return rather than calling -restartTimers and -addWindowObservers itself.

Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView viewDidMoveToWindow]): Reinstate the call to -restartTimers and -addWindowObservers, but guard them
with a check that the view is still in the window.

10:52 AM Changeset in webkit [48393] by eric@webkit.org

5 edits in trunk

2009-09-15 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Add a new test case for SVG Path parsing with a default command and starts with dot '.'
https://bugs.webkit.org/show_bug.cgi?id=29123

svg/dom/path-parser-expected.txt:
svg/dom/resources/path-parser.js:

2009-09-15 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Fix SVG path parsing error if a command starts with dot '.'
https://bugs.webkit.org/show_bug.cgi?id=29123

svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG):

6:14 AM Changeset in webkit [48392] by rik@webkit.org

10 edits
1 add in trunk/WebCore

Implement conditional breakpoints in the Web Inspector frontend.
https://bugs.webkit.org/show_bug.cgi?id=28908

Patch by Alexander Pavlov <apavlov@chromium.org> on 2009-09-15
Reviewed by Timothy Hatcher.

English.lproj/localizedStrings.js:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/Breakpoint.js:

(WebInspector.Breakpoint.prototype.set condition):

inspector/front-end/Popup.js: Added.

(WebInspector.Popup):
(WebInspector.Popup.prototype.show):
(WebInspector.Popup.prototype.hide):
(WebInspector.Popup.prototype.get visible):
(WebInspector.Popup.prototype.set element):
(WebInspector.Popup.prototype.get element):
(WebInspector.Popup.prototype.positionElement):
(WebInspector.Popup.prototype.set anchor):
(WebInspector.Popup.prototype.get anchor):
(WebInspector.Popup.prototype.set autoHide):
(WebInspector.Popup.prototype._checkNotVisible):
(WebInspector.Popup.prototype._keyEventHandler):
(WebInspector.Popup.prototype._mouseDownEventHandler):

inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.revealLine):
(WebInspector.SourceFrame.prototype._loaded):
(WebInspector.SourceFrame.prototype._documentContextMenu):
(WebInspector.SourceFrame.prototype._documentMouseDown):
(WebInspector.SourceFrame.prototype._editBreakpointCondition.committed):
(WebInspector.SourceFrame.prototype._editBreakpointCondition.dismissed):
(WebInspector.SourceFrame.prototype._editBreakpointCondition):
(WebInspector.SourceFrame.prototype._showBreakpointConditionPopup):
(WebInspector.SourceFrame.prototype._createPopupElement):
(WebInspector.SourceFrame.prototype._addBreakpointToSource):
(WebInspector.SourceFrame.prototype._removeBreakpointFromSource):
(WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded.drawBreakpoint):
(WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded):

inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:
inspector/front-end/inspector.js:

(WebInspector.set currentFocusElement):
(WebInspector.set currentPanel):
(WebInspector.loaded):
(WebInspector.contextMenu):
(WebInspector.elementDragStart):
(WebInspector.updateResource):
(WebInspector.drawLoadingPieChart):
(WebInspector.linkifyURLAsNode):
(WebInspector.startEditing.getContent):
(WebInspector.startEditing.editingCancelled):
(WebInspector.startEditing.editingCommitted):

inspector/front-end/utilities.js:

(Element.prototype.positionAt):
(Element.prototype.offsetRelativeToWindow):

6:03 AM Changeset in webkit [48391] by vestbo@webkit.org

2 edits in trunk/JavaScriptCore

[Qt] Build fix for windows.

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-15
Reviewed by Tor Arne Vestbø.

After http://trac.webkit.org/changeset/47795 the MinGW build broke,
because MinGW has mingw_aligned_malloc instead of _aligned_malloc.

runtime/Collector.cpp:

(JSC::Heap::allocateBlock): MinGW case added.
(JSC::Heap::freeBlock): MinGW case added.

5:51 AM Changeset in webkit [48390] by vestbo@webkit.org

2 edits in trunk/JavaScriptCore

[Qt] Build fix for Windows/MinGW

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-15
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=29268

wtf/Platform.h: JSVALUE32_64 temporarily disabled on PLATFORM(WIN_OS) with COMPILER(MINGW)

4:29 AM Changeset in webkit [48389] by zoltan@webkit.org

3 edits
1 add in trunk/JavaScriptCore

2009-09-14 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Detect VFP at runtime in generic ARM port on Linux platform.
https://bugs.webkit.org/show_bug.cgi?id=29076

JavaScriptCore.pri:
assembler/MacroAssemblerARM.cpp: Added. (JSC::isVFPPresent):
assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::supportsFloatingPoint):

Sep 14, 2009:

9:25 PM Changeset in webkit [48388] by beidson@apple.com

5 edits in trunk

Page cache should support pages with unload handlers as an experiment.
<rdar://problem/7196485> and https://bugs.webkit.org/show_bug.cgi?id=29021

Reviewed by Darin Adler.

WebCore:

For the experiment, only allow pages with unload handlers into the Page Cache on
Mac and Windows.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):

LayoutTests:

Disable fast/loader/frames-with-unload-handlers-in-page-cache.html as it doesn't
make sense in the context of this experiment.

platform/mac/Skipped:
platform/win/Skipped:

8:22 PM Changeset in webkit [48387] by mrowe@apple.com

4 edits in branches/safari-4-branch

Versioning.

8:21 PM Changeset in webkit [48386] by mrowe@apple.com

1 copy in tags/Safari-6531.18

New tag.

8:07 PM Changeset in webkit [48385] by mrowe@apple.com

6 edits
2 adds in branches/safari-4-branch

Merge r48368.

8:05 PM Changeset in webkit [48384] by mrowe@apple.com

10 edits in branches/safari-4-branch/WebCore

Merge r48367.

7:11 PM Changeset in webkit [48383] by kov@webkit.org

5 edits in trunk

Undoing mess: committing test code

7:11 PM Changeset in webkit [48382] by kov@webkit.org

8 edits in trunk/WebKit/gtk

2009-09-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez and Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=29134
[GTK] Add API to access sub resources

Implement getting subresources, and improve testing of
main, and sub resources loading.

7:08 PM Changeset in webkit [48381] by kov@webkit.org

5 edits in trunk

Java

6:28 PM Changeset in webkit [48380] by cmarrin@apple.com

4 edits
3 adds in trunk

Add LayoutTests infrastructure to enable and disable webgl tests.
Also added a webgl test.
https://bugs.webkit.org/show_bug.cgi?id=29254

6:07 PM Changeset in webkit [48379] by Simon Fraser

2 edits in trunk/WebCore

2009-09-14 Simon Fraser <Simon Fraser>

Fix the change in r48376 to do a null-check to fix a crashing test.

dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):

5:54 PM Changeset in webkit [48378] by Simon Fraser

2 edits in trunk/WebKitTools

2009-09-14 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Add --iterations option to run-webkit-tests to repeat the tests N times
https://bugs.webkit.org/show_bug.cgi?id=29263

When run with --iterations N, run-webkit-tests will repeat the tests N times.

Scripts/run-webkit-tests:

5:28 PM Changeset in webkit [48377] by beidson@apple.com

2 edits in trunk/LayoutTests

5:19 PM Changeset in webkit [48376] by Simon Fraser

3 edits
2 adds in trunk

2009-09-14 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/7047282> Safari crashes at WebCore::RenderMenuList::adjustInnerStyle() + 436

Avoid a crash when a mouse event handler on a <select> changes the select from a popup
to a list (by setting the 'size' property) inside the event handler.

Test: fast/forms/select-change-popup-to-listbox-in-event-handler.html

dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):

4:52 PM Changeset in webkit [48375] by andersca@apple.com

3 edits in trunk/WebCore

More PopupMenu cleanup.

Reviewed by Jon Honeycutt.

platform/PopupMenu.h:
platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::show):
Call registerClass.

(WebCore::PopupMenu::registerClass):
Make this a private static member function so it can refer to PopupMenuWndProc.

(WebCore::PopupMenu::PopupMenuWndProc):
Try to get the PopupMenu and call its wndProc member function.

(WebCore::PopupMenu::wndProc):
Make this a member function.

4:08 PM Changeset in webkit [48374] by beidson@apple.com

4 edits in trunk

Fix more fallout I wrought on myself by not testing the final authentication patch on Windows.

3:46 PM Changeset in webkit [48373] by jhoneycutt@apple.com

2 edits in trunk/WebKitTools

GTK build fix.

Unreviewed.

DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::setLogScrollingStartEvents):

3:45 PM Changeset in webkit [48372] by andersca@apple.com

2 edits in trunk/WebCore

Speculative Qt build fix.

platform/qt/QWebPopup.cpp:

(WebCore::QWebPopup::hidePopup):

3:38 PM Changeset in webkit [48371] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Fisher.

Fix RenderThemeChromiumWin::determineClassicState so that classic_state
matches the state values (and you get a single classic_state value
for a given {part,state} value. This change will be tested by a
chromium patch that will land after this.

This will be tested by code landing downstream on Chromium.org; the
code does not execute on webkit.org.

rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineClassicState): (WebCore::RenderThemeChromiumWin::getThemeData):

3:14 PM Changeset in webkit [48370] by andersca@apple.com

11 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=29138
Simplify popup menu handling.

Reviewed by Adam Roben.

platform/PopupMenuClient.h:

Rename hidePopup to popupDidHide.

platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::acceptIndex):
Call popupDidHide instead of hidePopup.

platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenu::menuUnmapped):
Ditto.

platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenu::show):
Ditto.

platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::hide):
Call popupDidHide.

(WebCore::PopupWndProc):
Call PopupMenu::hide.

platform/wx/PopupMenuWx.cpp:

(WebCore::PopupMenu::OnMenuItemSelected):
Call popupDidHide.

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::hidePopup):
(WebCore::RenderMenuList::popupDidHide):

rendering/RenderMenuList.h:

Set the "popup is visible" flag in popupDidHide.

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::popupDidHide):

rendering/RenderTextControlSingleLine.h:

Ditto.

2:27 PM Changeset in webkit [48369] by andersca@apple.com

2 edits in trunk/WebCore

Fix <rdar://problem/7182275>.

Reviewed by David Hyatt.

Make sure that the newly created scrollbar's style is up to date.

platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::~PopupMenu):
Call setParent so that the scrollbar's parts are torn down correctly.

(WebCore::PopupMenu::show):
Call styleChanged.

2:25 PM Changeset in webkit [48368] by jhoneycutt@apple.com

6 edits
2 adds in trunk

DRT/test part of
<rdar://problem/7197644> WebKit should broadcast an MSAA event when
jumping to a named anchor

https://bugs.webkit.org/show_bug.cgi?id=28899

Reviewed by Adam Roben.

WebKitTools:

DumpRenderTree/AccessibilityController.cpp:

(logScrollingStartEventsCallback):
Turn on logging of scrolling start events.
(AccessibilityController::getJSClass):
Add a "logScrollingStartEvents" to the AccessibilityController's JS
class definition.
(AccessibilityController::resetToConsistentState):
Turn off logging of scrolling start events.

DumpRenderTree/AccessibilityController.h:

Declare setLogScrollingStartEvents(). Add a member for the scrolling
start event hook.

DumpRenderTree/mac/AccessibilityControllerMac.cpp:

(AccessibilityController::setLogScrollingStartEvents):
Stubbed.

DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
Initialize the handle to 0.
(logEventProc):
Renamed from logFocusEventProc; now logs scrolling start events, too.
Removed the assertion that the event is a focus event. Added a switch
to print a message for focus, scrolling start, and other, unknown
events.
(AccessibilityController::setLogFocusEvents):
Changed to use logEventProc.
(AccessibilityController::setLogScrollingStartEvents):
If turning logging off, unhook the scrolling start event hook, and clear
the member holding the handle. If turning on, query for the root
accessible, so that accessibility is enabled for the WebView, and call
SetWinEventHook to setup an event hook using logEventProc as the
callback function.

LayoutTests:

platform/win/accessibility/scroll-to-anchor-expected.txt: Added.
platform/win/accessibility/scroll-to-anchor.html:

Added. Turns on scrolling start event logging, then jumps to an
anchor at the bottom of the page.

2:25 PM Changeset in webkit [48367] by jhoneycutt@apple.com

10 edits in trunk/WebCore

<rdar://problem/7197644> WebKit should broadcast an MSAA event when
jumping to a named anchor

https://bugs.webkit.org/show_bug.cgi?id=28899

Reviewed by Adam Roben.

accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::):
Added declaration for handleScrolledToAnchor(). Added a new entry to
the enum of accessibility notifications.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::firstAccessibleObjectFromNode):
Code moved from AccessibilityRenderObject::internalLinkElement() and
refactored slightly; walks the tree until it finds a Node (with a
renderer) whose accessibility is not ignored.

accessibility/AccessibilityObject.h:

Added a declaration for firstAccessibleObjectFromNode().

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::internalLinkElement):
Code moved to AccessibilityObject::firstAccessibleObjectFromNode().

accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.

accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.

accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):
Add a default case that returns early for notifications that Mac
doesn't handle.
(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.

accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::handleScrolledToAnchor):
Post an AXScrolledToAnchor notification for the first accessible from
the anchor Node.
(WebCore::AXObjectCache::postPlatformNotification):
If the notification is AXFocusedUIElementChanged, fire an
EVENT_OBJECT_FOCUS. If the notification is AXScrolledToAnchor, fire
EVENT_SYSTEM_SCROLLINGSTART, matching Firefox.
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
Code moved to postPlatformNotification().

page/FrameView.cpp:

(WebCore::FrameView::scrollToAnchor):
Call AXObjectCache::handleScrolledToAnchor().

2:09 PM Changeset in webkit [48366] by rik@webkit.org

2 edits in trunk/WebCore

Cookies are not inspectable after reloading a page
https://bugs.webkit.org/show_bug.cgi?id=29222

Patch by Anthony Ricaud <rik@webkit.org> on 2009-09-14
Reviewed by Timothy Hatcher.

Create the cookieTreeElement on initialization instead of when the view is shown.
Reset the selected element of the sidebar on reset.

inspector/front-end/StoragePanel.js:

(WebInspector.StoragePanel):
(WebInspector.StoragePanel.prototype.show):
(WebInspector.StoragePanel.prototype.reset):

2:07 PM CommitQueue edited by eric@webkit.org

(diff)

1:32 PM Changeset in webkit [48365] by beidson@apple.com

3 edits in trunk/WebKitTools

Windows DRT build fix.

1:12 PM Changeset in webkit [48364] by beidson@apple.com

2 edits in trunk/WebCore

Windows build fix.

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
(WebCore::WebCoreSynchronousLoader::load):

1:05 PM Changeset in webkit [48363] by beidson@apple.com

32 edits
16 adds in trunk

Safari 4 cannot be used to update firmware on Linksys routers.
<rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160

Reviewed by Alexey Proskuryakov.

WebCore:

In http://trac.webkit.org/changeset/42483, we disabled CFNetwork's session credential storage and
implemented our own in WebCore.

One feature we lost is that CFNetwork would automatically send previously authenticated credentials
with new connections when the paths match, as allowed by RFC 2617 for HTTP Basic and Digest Authentication.

Even though it's optional for User Agents to do this, (some?) Linksys routers rely on this behavior for
HTTP Basic Authentication. So now WebCore's CredentialStorage will track URL paths for Basic credentials.

We're not making this enhancement for Digest at this time, since we don't know of anything that broke
due to the change in Digest behavior.

Test: http/tests/loading/basic-credentials-sent-automatically.html

http/tests/loading/basic-auth-resend-wrong-credentials.html

WebCore.base.exp:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

platform/network/Credential.cpp:

(WebCore::Credential::isEmpty):

platform/network/Credential.h:

Add a slightly more full featured CredentialStore that will track URL paths a credential belongs to:

platform/network/CredentialStorage.cpp: Added.

(WebCore::protectionSpaceToCredentialMap):
(WebCore::originToDefaultCredentialMap):
(WebCore::originStringFromURL):
(WebCore::CredentialStorage::set):
(WebCore::CredentialStorage::get):
(WebCore::CredentialStorage::getDefaultAuthenticationCredential):

platform/network/CredentialStorage.h: Added.

Allow ProtectionSpace to be a hash key:

platform/network/ProtectionSpace.cpp:

(WebCore::ProtectionSpace::ProtectionSpace):

platform/network/ProtectionSpace.h:

(WebCore::ProtectionSpace::ProtectionSpace):
(WebCore::ProtectionSpace::isHashTableDeletedValue):

platform/network/ProtectionSpaceHash.h: Added.

(WebCore::ProtectionSpaceHash::hash):
(WebCore::ProtectionSpaceHash::equal):

Allow ResourceHandles to remember the initial credential they used:

platform/network/ResourceHandleInternal.h:

Allow mutable ResourceRequests to update their platform object if HTTP header fields change:

platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::addHTTPHeaderField):

Remove WebCoreCredentialStorage:

platform/network/cf/AuthenticationCF.cpp:
platform/network/cf/AuthenticationCF.h:
platform/network/mac/AuthenticationMac.h:
platform/network/mac/AuthenticationMac.mm:

Change ResourceHandleCFNet to try to use stored credentials on new connections, if appropriate:

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Only try the ProtectionSpace key'ed

Credential if it does not match the initially used Credential.

(WebCore::ResourceHandle::receivedCredential):
(WebCore::WebCoreSynchronousLoader::didReceiveChallenge): Only try the ProtectionSpace key'ed

Credential if it does not match the initially used Credential.

(WebCore::WebCoreSynchronousLoader::load):

Change ResourceHandleMac to try to use stored credentials on new connections, if appropriate:

platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Only try the ProtectionSpace key'ed

Credential if it does not match the initially used Credential.

(WebCore::ResourceHandle::receivedCredential):
(-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Only try the

ProtectionSpace key'ed Credential if it does not match the initially used Credential.

(+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):

Add base64-ability to CString:

platform/text/CString.cpp:

(WebCore::CStringBuffer::base64Encode):
(WebCore::CString::base64Encode):

platform/text/CString.h:

(WebCore::CStringBuffer::create):
(WebCore::CStringBuffer::CStringBuffer):

WebKit/mac:

Adopt the new WebCore::CredentialStorage in WebKit/Mac.

Misc/WebDownload.mm:

(-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):

Plugins/WebBaseNetscapePluginView.mm:

(WebKit::getAuthenticationInfo):

WebKit/win:

Adopt the new WebCore::CredentialStorage in WebKit/Win.

WebDownloadCFNet.cpp:

(WebDownload::didReceiveAuthenticationChallenge):

WebKitTools:

Add the ability for DRT to handle authentication challenges.

DumpRenderTree/LayoutTestController.cpp:

(setAuthenticationPasswordCallback):
(setAuthenticationUsernameCallback):
(setHandlesAuthenticationChallengesCallback):
(LayoutTestController::staticFunctions):

DumpRenderTree/LayoutTestController.h:

(LayoutTestController::handlesAuthenticationChallenges):
(LayoutTestController::setHandlesAuthenticationChallenges):
(LayoutTestController::authenticationUsername):
(LayoutTestController::setAuthenticationUsername):
(LayoutTestController::authenticationPassword):
(LayoutTestController::setAuthenticationPassword):

DumpRenderTree/mac/ResourceLoadDelegate.mm:

(-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):

DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::didReceiveAuthenticationChallenge):

DumpRenderTree/win/ResourceLoadDelegate.h:

LayoutTests:

http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Added.
http/tests/loading/basic-auth-resend-wrong-credentials.html: Added.
http/tests/loading/basic-credentials-sent-automatically-expected.txt: Added.
http/tests/loading/basic-credentials-sent-automatically.html: Added.
http/tests/loading/resources/basic-auth-testing.php: Added.
http/tests/loading/resources/othersubresources: Added.
http/tests/loading/resources/othersubresources/protected-resource.php: Added.
http/tests/loading/resources/protected-resource.php: Added.
http/tests/loading/resources/subresources: Added.
http/tests/loading/resources/subresources/protected-resource.php: Added.
http/tests/loading/resources/test2: Added.
http/tests/loading/resources/test2/basic-auth-testing.php: Added.
http/tests/loading/resources/test2/protected-resource.php: Added.
platform/gtk/Skipped:
platform/qt/Skipped:

12:01 PM Changeset in webkit [48362] by kov@webkit.org

4 edits in trunk/LayoutTests

2009-09-14 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

Add some tests that fail to the skipped list and rebaseline two tests
to pass them.

platform/gtk/Skipped: Populate with more failing tests.
platform/gtk/fast/dom/Window/window-properties-expected.txt: Rebaseline.
platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Ditto.

11:10 AM Changeset in webkit [48361] by mrowe@apple.com

3 edits
2 adds in trunk

Test for <rdar://problem/6954546> and <rdar://problem/7090444>.

Reviewed by Dan Bernstein.

WebKitTools:

Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.

DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:

(NPP_New):

LayoutTests:

plugins/destroy-during-npp-new-expected.txt: Added.
plugins/destroy-during-npp-new.html: Added.

11:10 AM Changeset in webkit [48360] by mrowe@apple.com

2 edits in trunk/WebKit/mac

Fix <rdar://problem/7090444> Crashes in-[WebBaseNetscapePluginView stop] handling NSWindowWillCloseNotification.

Reviewed by Anders Carlsson.

It's not valid to call -addWindowObservers when the view is not in a window, but this can happen when -start
initializes a plug-in and the plug-in removes itself from the document during initialization. -viewDidMoveToWindow
calls -start and then calls -addWindowObservers without ensuring that the view is still in a window.

If -[WebBaseNetscapePluginView addWindowObservers] is incorrectly called when the view is not in a window, it will
observe NSWindowWillCloseNotification on all windows. This unexpected observer registration is not balanced by an
unregistration so the notification can be delivered after the view is deallocated, causing the crash seen in
<rdar://problem/7090444>.

Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView start]): Only call -updateAndSetWindow if we still have a current window.
(-[WebBaseNetscapePluginView viewDidMoveToWindow]): Remove unnecessary calls to -restartTimers and -addWindowObservers
from -[WebBaseNetscapePluginView viewDidMoveToWindow]. They are already called from within -start with the extra benefit
of ensuring that the view is still in a window when they are called.

11:10 AM Changeset in webkit [48359] by mrowe@apple.com

2 edits in trunk/WebCore

Fix <rdar://problem/6954546> Crashes in WebCore::RenderPart::setWidget below FrameLoader::loadPlugin.

Reviewed by Dan Bernstein.

The calls to FrameLoader::requestObject within RenderPartObject::updateWidget can result in a plug-in
being initialized. This can run cause arbitrary JavaScript to run and may result in the RenderPartObject
being detached from the render tree and destroyed, causing a crash like <rdar://problem/6954546>.

No test is possible until <rdar://problem/7090444> is fixed

rendering/RenderPartObject.cpp:

(WebCore::RenderPartObject::updateWidget): Ensure that we stay alive for the duration of plug-in initialization.

11:10 AM Changeset in webkit [48358] by mrowe@apple.com

3 edits
1 add in trunk/WebCore

Add RenderWidgetProtector to simplify protecting a RenderWidget from destruction for the duration of a function. Deploy it within RenderWidget.

Reviewed by Dan Bernstein.

rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::updateWidgetPosition): Use a RefPtr rather than explicitly
ref'ing and deref'ing the node.

rendering/RenderWidget.h:
rendering/RenderWidgetProtector.h:

(WebCore::RenderWidgetProtector::RenderWidgetProtector):
(WebCore::RenderWidgetProtector::~RenderWidgetProtector):

10:26 AM Changeset in webkit [48357] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-09-14 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] QWebGraphicsItem should check for null QWebPage.
https://bugs.webkit.org/show_bug.cgi?id=29185

Don't crash in QWebGraphicsItem when the page is still null, by
either checking if it's the case or constructing the default one.

Api/qwebgraphicsitem.cpp: (QWebGraphicsItem::icon): (QWebGraphicsItem::setZoomFactor): (QWebGraphicsItem::zoomFactor): (QWebGraphicsItem::setGeometry): (QWebGraphicsItem::load): (QWebGraphicsItem::setHtml): (QWebGraphicsItem::toHtml): (QWebGraphicsItem::setContent): (QWebGraphicsItem::history): (QWebGraphicsItem::settings):

10:19 AM Changeset in webkit [48356] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-14 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

CodeGenerator.pm needs some cleaning up
https://bugs.webkit.org/show_bug.cgi?id=29238

bindings/scripts/CodeGenerator.pm: (FindParentsRecursively): Removed; its functionality is now handled in AddMethodsConstantsAndAttributesFromParentClasses. (ForAllParents): New function that visits an interface's ancestors and invokes a callback for each one. (AddMethodsConstantsAndAttributesFromParentClasses): Simplified by using ForAllParents. (GetMethodsAndAttributesFromParentClasses): Ditto. (IDLFileForInterface): Factored out previous calls to ScanDirectory into this new function, which returns the filename containing a given IDL interface definition. (ParseInterface): Simplified by using IDLFileForInterface. (ScanDirectory): Removed in lieu of IDLFileForInterface.
bindings/scripts/CodeGeneratorV8.pm: Drop call to FindParentsRecursively and get the list of parents from the AddMethodsConstantsAndAttributesFromParentClasses call instead.

10:06 AM Changeset in webkit [48355] by kevino@webkit.org

3 edits in trunk/WebKitTools

wx build fix for non-wxPython builds and a fix for errors when updating swig.py.

7:46 AM Changeset in webkit [48354] by yael.aharon@nokia.com

2 edits in trunk/WebCore

[Qt] Assert hit when dropping a file in QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=29242

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-14
Reviewed by Tor Arne Vestbø.

Qt's implementation of DropData::asURL does not return a URL encoded string
as expected.

platform/qt/DragDataQt.cpp:

5:45 AM Changeset in webkit [48353] by vestbo@webkit.org

5 edits in trunk

[Qt] Build fix for windows build.

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-14
Reviewed by Tor Arne Vestbø.

JavaScriptCore

JavaScriptCore.pri: Correct a logic error.
pcre/dftables: Add missing paranthesis for tmpdir function.

WebKitTools:

Scripts/bisect-builds: Add missing paranthesis for tmpdir function.

Sep 13, 2009:

10:47 PM Changeset in webkit [48352] by kevino@webkit.org

1 edit
1 add in trunk/WebCore

wx build fix, file was missed during TLS.cpp removal.

7:29 PM Changeset in webkit [48351] by rik@webkit.org

2 edits in trunk/WebCore

Web Inspector: Add "New Style Rule" to the localizedStrings
https://bugs.webkit.org/show_bug.cgi?id=29237

Patch by Anthony Ricaud <rik@webkit.org> on 2009-09-13
Reviewed by Oliver Hunt.

English.lproj/localizedStrings.js:

7:03 PM Changeset in webkit [48350] by kevino@webkit.org

2 edits in trunk/WebKitTools

Fix typo accidently landed in last commit.

6:52 PM Changeset in webkit [48349] by kevino@webkit.org

2 edits in trunk/WebKitTools

wx build fix, error out if using the wrong Python.

6:32 PM Changeset in webkit [48348] by kevino@webkit.org

3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Allow a way to set the cache policy via wx API.

https://bugs.webkit.org/show_bug.cgi?id=29200

6:20 PM Changeset in webkit [48347] by kevino@webkit.org

5 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Allow the user to query Frame::shouldClose via wx API.

https://bugs.webkit.org/show_bug.cgi?id=29199

6:12 PM Changeset in webkit [48346] by kevino@webkit.org

2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Fix mouse handling when the mouse leaves the window during mouse down.

https://bugs.webkit.org/show_bug.cgi?id=29198

6:04 PM Changeset in webkit [48345] by kevino@webkit.org

3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Add support for console MessageLevel at wx API level.

https://bugs.webkit.org/show_bug.cgi?id=29197

5:34 PM Changeset in webkit [48344] by kevino@webkit.org

2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx] Implement filesystem functions.

https://bugs.webkit.org/show_bug.cgi?id=29196

3:45 AM Changeset in webkit [48343] by xan@webkit.org

2 edits in trunk/WebKitTools

2009-09-13 Xan Lopez <xlopez@igalia.com>

Build fix for GTK+ < 2.14.

Do not use gtk_widget_get_window, access the window directly
through the struct.

DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (keyDownCallback):

3:23 AM Changeset in webkit [48342] by jmalonzo@webkit.org

2 edits in trunk/WebKitTools

2009-09-13 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez and Jan Alonzo.

[GTK] EventSender does not set 'window' property on synthesized GDK events
https://bugs.webkit.org/show_bug.cgi?id=29169

Set the window property on synthesized GDK events in the GTK+ EventSender.

DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (keyDownCallback):

12:14 AM Changeset in webkit [48341] by kevino@webkit.org

3 edits in trunk/WebCore

wx build fixes for wx 2.9.

Sep 12, 2009:

8:24 PM Changeset in webkit [48340] by oliver@apple.com

3 edits in trunk/JavaScriptCore

Build fix for windows exports (again).

8:10 PM Changeset in webkit [48339] by oliver@apple.com

3 edits in trunk/JavaScriptCore

Build fix for windows exports

8:03 PM Changeset in webkit [48338] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Correct fix for non-allinonefile builds

8:00 PM Changeset in webkit [48337] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Fix non-allinonefile builds

7:44 PM Changeset in webkit [48336] by oliver@apple.com

41 edits
3 adds in trunk

[ES5] Implement Object.keys
https://bugs.webkit.org/show_bug.cgi?id=29170

Reviewed by Maciej Stachowiak.

This patch basically requires two separate steps, the first is to split getPropertyNames
into two functions -- getOwnPropertyNames and getPropertyNames, basically making them behave
in the same way as getOwnPropertySlot and getPropertySlot. In essence getOwnPropertyNames
produces the list of properties on an object excluding its prototype chain and getPropertyNames
just iterates the the object and its prototype chain calling getOwnPropertyNames at each level.

6:17 PM Changeset in webkit [48335] by atwilson@chromium.org

2 edits in trunk/WebKitTools

run-webkit-tests has a timeout value that is too low
https://bugs.webkit.org/show_bug.cgi?id=29223

Reviewed by Mark Rowe.

Scripts/run-webkit-tests:

Changed timeout value to 20 seconds to avoid timing out too early.

12:11 PM Changeset in webkit [48334] by weinig@apple.com

6 edits
2 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29219
Document.elementFromPoint() should take page scroll into consideration

Reviewed by Anders Carlsson.

Test: fast/dom/elementFromPoint-relative-to-viewport.html

dom/Document.cpp:

(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=29219
Document.elementFromPoint() should take page scroll into consideration

Reviewed by Anders Carlsson.

fast/dom/elementFromPoint-relative-to-viewport-expected.txt: Added.
fast/dom/elementFromPoint-relative-to-viewport.html: Added.
fast/events/offsetX-offsetY.html: Change to use clientX/Y instead of pageX/Y.
fast/forms/slider-transformed.html: Ditto.
fast/forms/slider-zoomed.html: Ditto.

1:14 AM Changeset in webkit [48333] by weinig@apple.com

3 edits
2 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29217
Document.caretRangeFromPoint should take the scroll offset into account before hit testing

Reviewed by Maciej Stachowiak.

In accordance with the CSSOM View Module spec, Document.caretRangeFromPoint should interpret
the point passed to it as relative to the viewport, not the document.

Test: fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html

dom/Document.cpp:

(WebCore::Document::caretRangeFromPoint):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=29217
Document.caretRangeFromPoint should take the scroll offset into account before hit testing

Reviewed by Maciej Stachowiak.

fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Added.
fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html: Added.

Sep 11, 2009:

11:55 PM Changeset in webkit [48332] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-11 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Use gtk_style_set_background instead of gdk_window_set_background
https://bugs.webkit.org/show_bug.cgi?id=29173

Use gtk_style_set_background instead of gdk_window_set_background,
as suggested by the documentation. Also, use GTK_STATE_NORMAL
directly, since that's the default state of a GtkWidget.

webkit/webkitwebview.cpp: (webkit_web_view_realize):

9:52 PM Changeset in webkit [48331] by oliver@apple.com

20 edits in trunk

getPropertyNames caching is invalid when the prototype chain contains objects with custom getPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=29214

Reviewed by Sam Weinig.

Add a flag to TypeInfo to indicate whether a type overrides getPropertyNames.
This flag is used to make sure that caching of the property name data is safe.

8:40 PM Changeset in webkit [48330] by cmarrin@apple.com

1 edit
12 adds in trunk/WebCore

Added some manual tests to show WebGL in action
https://bugs.webkit.org/show_bug.cgi?id=29215

8:33 PM Changeset in webkit [48329] by kevino@webkit.org

2 edits in trunk/WebKitTools

wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
architectures are supported for building wxWebKit.

8:31 PM Changeset in webkit [48328] by Chris Fleizach

5 edits in trunk

aria definition role spelled wrong "defintion"
https://bugs.webkit.org/show_bug.cgi?id=28840

Reviewed by Darin Adler.

WebCore:

Test: accessibility/aria-slider-value-change.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::RoleEntry::):

LayoutTests:

platform/mac/accessibility/aria-grouping-roles-expected.txt:
platform/mac/accessibility/aria-grouping-roles.html:

7:17 PM Changeset in webkit [48327] by eric@webkit.org

3 edits
3 adds in trunk

2009-09-11 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Fixes an assert in Node::isFocusable which was causing crashes in certain cases.
https://bugs.webkit.org/show_bug.cgi?id=29210

fast/events/resources/tab-is-focusable-assert.js:
fast/events/tab-is-focusable-assert-expected.txt: Added.

2009-09-11 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Fixes an assert in Node::isFocusable which was causing crashes in certain cases.
https://bugs.webkit.org/show_bug.cgi?id=29210

dom/Node.cpp: (WebCore::Node::isFocusable):

6:48 PM Changeset in webkit [48326] by mrowe@apple.com

2 edits in trunk/WebKit/mac

Fix <rdar://problem/7145242> Crashes inside WTF::HashTable below NetscapePluginInstanceProxy::disconnectStream

Reviewed by Jon Honeycutt.

Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::cancelLoad): Canceling the load can result in calling through to disconnectStream.
If the plug-in instance holds the last reference to the plug-in stream this will result in the stream being deallocated.
This leads to HostedNetscapePluginStream::cancelLoad's call to disconnectStream being passed a deallocated stream object.
Since the stream was already disconnected by the call to cancel there's no need to call disconnectStream a second time.

5:13 PM Changeset in webkit [48325] by cmarrin@apple.com

14 edits in trunk/WebCore

Added variants to uniform* and vertexAttrib* calls which take sequence<> in place of CanvasArray
https://bugs.webkit.org/show_bug.cgi?id=29139

I also added a data() call to each of the CanvasArray subclasses to give back a types pointer
to the baseAddress().

5:00 PM Changeset in webkit [48324] by sfalken@apple.com

2 edits in trunk/WebKit/win

2009-09-11 Steve Falkenburg <sfalken@apple.com>

Reviewed by Dan Bernstein.

Properly propagate preference from WebPreferences to WebCore::Settings.
https://bugs.webkit.org/show_bug.cgi?id=29192

WebView.cpp: (WebView::initWithFrame): Apply setting when creating a new WebView. (WebView::notifyPreferencesChanged): Apply setting when preferences change.

4:59 PM Changeset in webkit [48323] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-11 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

Add ENABLE(WEB_SOCKETS) guards.
https://bugs.webkit.org/show_bug.cgi?id=29174

bindings/v8/custom/V8WebSocketCustom.cpp:

4:57 PM Changeset in webkit [48322] by bweinstein@apple.com

2 edits in trunk/LayoutTests

2009-09-11 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Mark Rowe.

Add the http/tests/security/mixedContent to the Skipped list while
test failures are being investigated.

platform/win/Skipped:

4:34 PM Changeset in webkit [48321] by eric@webkit.org

10 edits
2 deletes in trunk

2009-09-11 Eric Seidel <eric@webkit.org>

No review, rolling out r48229.
http://trac.webkit.org/changeset/48229

fast/events/drag-dropeffect-expected.txt: Removed.
fast/events/drag-dropeffect.html: Removed.

2009-09-11 Eric Seidel <eric@webkit.org>

No review, rolling out r48229.
http://trac.webkit.org/changeset/48229

WebCore.base.exp:
dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard): (WebCore::Clipboard::sourceOperation):
page/DragController.cpp: (WebCore::DragController::DragController): (WebCore::DragController::dragExited): (WebCore::DragController::performDrag): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDHTMLDrag): (WebCore::DragController::startDrag):
page/DragController.h:
page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::dragSourceMovedTo): (WebCore::EventHandler::handleDrag):
page/EventHandler.h:

2009-09-11 Eric Seidel <eric@webkit.org>

No review, rolling out r48229.
http://trac.webkit.org/changeset/48229

WebView/WebFrame.mm: (-[WebFrame _dragSourceMovedTo:]):

4:28 PM Changeset in webkit [48320] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-09-11 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

bugzilla-tool rollout threw exception under svn
https://bugs.webkit.org/show_bug.cgi?id=29211

Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
Scripts/modules/scm_unittest.py: add testing for this fix.

3:18 PM Changeset in webkit [48319] by mrowe@apple.com

2 edits in trunk/WebCore

Fix the build.

2009-09-11 Michelangelo De Simone <micdesim@gmail.com>

Fix the build.

html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):

3:01 PM Changeset in webkit [48318] by eric@webkit.org

3 edits
3 adds in trunk

2009-09-11 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=27456
Test case for url validation in ValidityState.

fast/forms/ValidityState-typeMismatch-url-expected.txt: Added.
fast/forms/ValidityState-typeMismatch-url.html: Added.
fast/forms/resources/ValidityState-typeMismatch-url.js: Added. (check):

2009-09-11 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=27456
Added support for static validation of url in
ValidityState, for url state inputs.
From HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#url-state

Test: fast/forms/ValidityState-typeMismatch-url.html

html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):

2:52 PM Changeset in webkit [48317] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-11 Evan Stade <estade@chromium.org>

Reviewed by Darin Adler.

Revert r47992: Expose functions to change the focus ring color for
Linux Chromium.

As Darin Fisher has pointed out, there is a better way to do this.

rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux):
rendering/RenderThemeChromiumLinux.h:

2:51 PM CommitQueue edited by levin@chromium.org

(diff)

2:47 PM Changeset in webkit [48316] by bweinstein@apple.com

2 edits in trunk/WebKitTools

2009-09-11 Brian Weinstein <bweinstein@apple.com>

Add myself to the committers list.

Scripts/modules/committers.py:

2:34 PM Changeset in webkit [48315] by ap@apple.com

6 edits in trunk

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=29207
Add checks for using WebCore JS context on secondary threads

1:21 PM Changeset in webkit [48314] by bweinstein@apple.com

4 edits in trunk/WebCore

2009-09-11 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.

The inspector should have scope bars.
https://bugs.webkit.org/show_bug.cgi?id=14353

Add scope bars to the console, so the user can choose which category
of messages they want to see (All, Errors, Warnings, Logs), and they
can choose from one or more of {Errors, Warnings, Logs}.

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.createFilterElement): (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype._updateFilter): (WebInspector.ConsoleView.prototype.filter): (WebInspector.ConsoleView.prototype.attach):
inspector/front-end/inspector.css:
inspector/front-end/inspector.html:

1:09 PM Changeset in webkit [48313] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-11 Yusuke Sato <yusukes@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Complex text doesn't show up with text stroking
https://bugs.webkit.org/show_bug.cgi?id=28707

Added extra NULL checks for HDC. This is the second fix for issue 28707,
and the fix is similar to http://trac.webkit.org/changeset/45482.

platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawComplexText):
platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::draw):

12:05 PM Changeset in webkit [48312] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-09-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool land-patches should only fail-fast in --commit-queue mode
https://bugs.webkit.org/show_bug.cgi?id=29201

Scripts/bugzilla-tool:

11:47 AM Changeset in webkit [48311] by eric@webkit.org

6 edits
2 adds in trunk

2009-09-11 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Make ElementTimeControl methods return void and not throw.
https://bugs.webkit.org/show_bug.cgi?id=28831

SVG 1.1 erratum:
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#elementtimecontrol-interface

svg/dom/smil-methods-expected.txt: Added.
svg/dom/smil-methods.svg: Added.

2009-09-11 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Make ElementTimeControl methods return void and not throw.
https://bugs.webkit.org/show_bug.cgi?id=28831

SVG 1.1 erratum:
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#elementtimecontrol-interface

Test: svg/dom/smil-methods.svg

svg/ElementTimeControl.h: Change return type from bool to void and remove exception argument.
svg/ElementTimeControl.idl: Change return type from bool to void and remove raises claus.
svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::beginElement): Change return type from bool to void and remove exception argument. (WebCore::SVGAnimationElement::beginElementAt): Ditto. (WebCore::SVGAnimationElement::endElement): Ditto. (WebCore::SVGAnimationElement::endElementAt): Ditto.
svg/SVGAnimationElement.h: Ditto.

11:31 AM Changeset in webkit [48310] by cmarrin@apple.com

3 edits in trunk/WebCore

Added support for texImage2D which takes CanvasArray
https://bugs.webkit.org/show_bug.cgi?id=29191

bindings/js/JSCanvasRenderingContext3DCustom.cpp: (WebCore::JSCanvasRenderingContext3D::texImage2D):
platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::texImage2D):

11:15 AM Changeset in webkit [48309] by wsiegrist@apple.com

3 edits in trunk/BugsSite

2009-09-11 David Kilzer <ddkilzer@apple.com>

Apply fix for http://www.bugzilla.org/security/3.0.8/

11:04 AM Changeset in webkit [48308] by sfalken@apple.com

10 edits in trunk

WebCore: Allow WebKit clients to opt out of high resolution timers on Windows.
https://bugs.webkit.org/show_bug.cgi?id=29192

Reviewed by Darin Adler.

page/Settings.cpp:

(WebCore::Settings::setShouldUseHighResolutionTimers): Added.

page/Settings.h: Added getter/setter for shouldUseHighResolutionTimers.

(WebCore::Settings::shouldUseHighResolutionTimers): Added.

platform/win/SharedTimerWin.cpp:

(WebCore::setSharedTimerFireTime): Don't run high resolution timer code if it is disabled.

WebKit/win: Allow WebKit clients to opt out of high resolution timers on Windows.
https://bugs.webkit.org/show_bug.cgi?id=29192

Reviewed by Darin Adler.

Interfaces/IWebPreferencesPrivate.idl: Added getter/setter.

Put this just after last 4.0.3 method for future merging.

Interfaces/WebKit.idl: Touched to force a rebuild.
WebPreferenceKeysPrivate.h: Added prefs key for high res timers.
WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Initialize high res timers to enabled.
(WebPreferences::setShouldUseHighResolutionTimers): Added.
(WebPreferences::shouldUseHighResolutionTimers): Added.

WebPreferences.h: Added getter/setter.

11:03 AM Changeset in webkit [48307] by Adam Roben

2 edits in trunk/WebKitTools

Make commit-log-editor move common prefixes to the top of the log

Fies <http://webkit.org/b/29190> commit-log-editor should move common
prefixes to the top of the commit log

Reviewed by Darin Adler.

Scripts/commit-log-editor: Find and remove the longest common prefix

ending in a double newline from each ChangeLog entry, then put that
common prefix at the top of the commit log.
(removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
removes, and returns the longest common prefix ending in a double
newline from a hash of strings

10:59 AM Changeset in webkit [48306] by eric@webkit.org

8 edits
1 add in trunk/WebCore

2009-09-11 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>

Reviewed by Adam Barth.

[v8] Share persistent context handles between events
Change events to use a single ref-counted shared persistent handle
to the context in which to run, rather than create a new
persistent handle for each new event which puts pressure on the
gc.

https://bugs.webkit.org/show_bug.cgi?id=29077

bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
bindings/v8/SharedPersistent.h: Added. (WebCore::SharedPersistent::set): (WebCore::SharedPersistent::get): (WebCore::SharedPersistent::disposeHandle): (WebCore::SharedPersistent::create): (WebCore::SharedPersistent::SharedPersistent):
bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): (WebCore::V8AbstractEventListener::handleEvent):
bindings/v8/V8AbstractEventListener.h:
bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld): (WebCore::V8IsolatedWorld::~V8IsolatedWorld):
bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::context): (WebCore::V8IsolatedWorld::shared_context):
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::createWrapperFromCacheSlowCase): (WebCore::V8Proxy::isContextInitialized): (WebCore::V8Proxy::updateDocumentWrapperCache): (WebCore::V8Proxy::clearDocumentWrapperCache): (WebCore::V8Proxy::disposeContextHandles): (WebCore::V8Proxy::clearForClose): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::setSecurityToken): (WebCore::V8Proxy::updateDocument): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::shared_context): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::setContextDebugId):
bindings/v8/V8Proxy.h: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::context): (WebCore::V8Proxy::shared_context):

10:20 AM Changeset in webkit [48305] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-11 Anton Muhin <antonm@chromium.org>

Reviewed by David Levin.

Create a real handle (one which would save an object from GC).
https://bugs.webkit.org/show_bug.cgi?id=29150

bindings/v8/V8Binding.cpp: (WebCore::v8ExternalString):

10:12 AM Changeset in webkit [48304] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-09-11 Eric Seidel <eric@webkit.org>

Fix obvious typo in previous commit, no review.

bugzilla-tool should automate rollouts
https://bugs.webkit.org/show_bug.cgi?id=26715

Scripts/bugzilla-tool: add back missing "scm" argument.

9:54 AM Changeset in webkit [48303] by eric@webkit.org

5 edits in trunk/WebKitTools

2009-09-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool should automate rollouts
https://bugs.webkit.org/show_bug.cgi?id=26715

bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
The --complete-rollout option will automatically land and update the bug.
Eventually --complete-rollout will be default, but that will require more testing.

This first pass is good enough for others to try and file bugs about.

Scripts/bugzilla-tool:
- Move modified_changelogs into scm.py.
- Move svn_revision_from_commit_text logic into scm.py.
- Add RolloutCommit command.
Scripts/modules/bugzilla.py:
- Add reopen_bug command used by RolloutCommit.
Scripts/modules/scm.py:
- Add functions to support RolloutCommit.
- Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
- Add a str() call so that svn_commit_log can take a numeric argument.
- Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
- Made dry_run commits return something that svn_revision_from_commit_text can parse.
Scripts/modules/scm_unittest.py:
- Add read_from_path for easy file reading.
- Put test4 on a new line to make reverts work w/o conflict.
- Add an "svn update" call so that the checkout revision matches the server revision.
- Add tests for svn_revision_from_commit_text.
- Add a simple test for apply_reverse_diff.
- Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
- Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.

9:35 AM Changeset in webkit [48302] by Adam Roben

9 edits in trunk

Get user script/stylesheet tests running on Windows

Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
skipped on Windows

Reviewed by John Sullivan.

WebKit/win:

Interfaces/IWebViewPrivate.idl: Added addUserScriptToGroup,

addUserStyleSheetToGroup, removeUserContentFromGroup,
removeAllUserContentFromGropu to match the Mac SPI.

WebView.cpp:

(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserContentFromGroup):
(WebView::removeAllUserContentFromGroup):

WebView.h:

Added. Implementation was based on similar methods in WebView.mm.

WebKitTools:

DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations

against comsuppw.lib so we can use _bstr_t.

DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include

order, added #include of comutil.h for _bstr_t.

(bstrT): Helper function to convert a JSStringRef to a _bstr_t.
(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):
Implemented. Implementations were based on those in
LayoutTestControllerMac.mm.

LayoutTests:

platform/win/Skipped: Removed the userscripts directory.

7:47 AM Changeset in webkit [48301] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-11 Anton Muhin <antonm@chromium.org>

Reviewed by David Levin.

Inline WebCore::v8String as it only invokes WebCore::v8ExternalString.
https://bugs.webkit.org/show_bug.cgi?id=29152

bindings/v8/V8Binding.cpp:
bindings/v8/V8Binding.h: (WebCore::v8String):

6:29 AM Changeset in webkit [48300] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2009-09-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Simon Hausmann.

Compiling JavaScriptCore on sparc 64 with gcc fails.

ThreadSafeShared uses the atomic gnu_cxx::exchange_and_add with an int,
however on sparc 64 the _Atomic_word argument is typedefed to long (8 bytes).

The patch disables WTF_USE_LOCKFREE_THREADSAFESHARED in ThreadSafeShared to use
a mutex instead when compiling for sparc 64 with gcc.

https://bugs.webkit.org/show_bug.cgi?id=29175

wtf/Platform.h: sparc64 is not defined on all OS.

Uses instead: sparc && arch64

sparcv9

wtf/Threading.h:

5:58 AM Changeset in webkit [48299] by Simon Hausmann

2 edits in trunk/WebKit/qt

Doc: Note that Netscape plugins are only available on desktop platforms.

Patch by David Boddie <dboddie@trolltech.com> on 2009-09-11
Reviewed by Simon Hausmann.

docs/qtwebkit.qdoc:

5:58 AM Changeset in webkit [48298] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Fix compile error on Windows7(64Bit) with latest SDK.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.

Added the missing include file.

runtime/UString.cpp:

5:58 AM Changeset in webkit [48297] by Simon Hausmann

2 edits in trunk/WebKit/qt

Adjust the name of the contentspage for the documentation
to the new name used in Qt 4.6.

Patch by Martin Smith <msmith@trolltech.com> on 2009-09-11
Reviewed by Simon Hausmann.

docs/qtwebkit.qdoc:

5:58 AM Changeset in webkit [48296] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Qt/Windows CE compile fix, include the executable allocator and
markstack implementation in the windows build.

Patch by Joerg Bornemann <joerg.bornemann@trolltech.com> on 2009-09-11
Reviewed by Simon Hausmann.

JavaScriptCore.pri:

5:58 AM Changeset in webkit [48295] by Simon Hausmann

6 edits in trunk

WebCore: Changed URLs from qtsoftware.com to qt.nokia.com, as part of a general
renaming.

Patch by Ariya Hidayat <ariya.hidayat@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.

ChangeLog-2009-06-16:

WebKit/qt: Changed URLs from qtsoftware.com to qt.nokia.com, as part of a general
renaming.

Patch by Ariya Hidayat <ariya.hidayat@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.

Api/qwebpluginfactory.cpp:
docs/webkitsnippets/simple/main.cpp:

(main):

docs/webkitsnippets/webpage/main.cpp:

(main):

5:57 AM Changeset in webkit [48294] by Simon Hausmann

12 edits in trunk/WebKit/qt

Restructure the documentation, both on a file and on a content level.

Patch by Volker Hilsheimer <volker.hilsheimer@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.

Api/qwebdatabase.cpp:
Api/qwebelement.cpp:
Api/qwebframe.cpp:
Api/qwebhistory.cpp:
Api/qwebhistoryinterface.cpp:
Api/qwebpage.cpp:
Api/qwebpluginfactory.cpp:
Api/qwebsecurityorigin.cpp:
Api/qwebsettings.cpp:
Api/qwebview.cpp:
docs/qtwebkit.qdoc:

5:57 AM Changeset in webkit [48293] by Simon Hausmann

2 edits in trunk/WebCore

Use LIBS_PRIVATE on Qt/Mac.

Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.

On the Mac, it means "-framework ApplicationServices -framework Carbon
-framework AppKit" are no longer part of the default LIBS in Qt
applications. This required a lot of fixes where we used Mac-specific
code in Qt.

WebCore.pro:

2:02 AM Changeset in webkit [48292] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-11 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Remove duplicated WK_{u,l}cfirst subs from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=29165

bindings/scripts/CodeGeneratorV8.pm: Remove WK_ucfirst and WK_lcfirst, and call the ones in CodeGenerator.pm instead.

1:55 AM Changeset in webkit [48291] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-09-11 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29136
[Qt] emit microFocusChanged() signal when no QWidget-based view is present.

emit microFocusChange() signal regardless of view.

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):

1:43 AM Changeset in webkit [48290] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-11 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=29132
Symbian winscw compiler fails compiling WebCore/text/RegularExpression.cpp.

Add RegularExpression class qualifier before Private.

platform/text/RegularExpression.cpp:

1:35 AM Changeset in webkit [48289] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-11 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=29131
Use a different variadic macro format for Symbian compiler.

Use arg... instead of ellipsis in variadic macro.

platform/StaticConstructors.h:

1:27 AM Changeset in webkit [48288] by Simon Hausmann

13 edits
4 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=28806

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.

[Qt] Make the WebInspector available as a QWidget.

WebCore.pro:

WebKit/qt: https://bugs.webkit.org/show_bug.cgi?id=28806

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-11
Reviewed by Simon Hausmann.

[Qt] Make the WebInspector available as a QWidget.

Api/headers.pri:
Api/qwebelement.cpp:

(QWebElement::enclosingElement):

Api/qwebelement.h:
Api/qwebinspector.cpp: Added.
Api/qwebinspector.h: Added.
Api/qwebinspector_p.h: Added.
Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::setInspector):
(QWebPagePrivate::getOrCreateInspector):
(QWebPagePrivate::inspectorController):
(QWebPage::~QWebPage):
(QWebPage::triggerAction):

Api/qwebpage.h:
Api/qwebpage_p.h:
Api/qwebsettings.cpp:
QtLauncher/main.cpp:

(MainWindow::MainWindow):

WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientWebPage::InspectorClientWebPage):
(WebCore::InspectorClientWebPage::createWindow):
(WebCore::InspectorClientQt::createPage):
(WebCore::InspectorClientQt::showWindow):
(WebCore::InspectorClientQt::closeWindow):
(WebCore::InspectorClientQt::attachWindow):
(WebCore::InspectorClientQt::detachWindow):
(WebCore::InspectorClientQt::updateWindowTitle):

WebCoreSupport/InspectorClientQt.h:
docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp: Added.

1:18 AM Changeset in webkit [48287] by Simon Hausmann

2 edits in trunk/WebCore

Unreviewed fix for the Web Inspector with the Qt build.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-11
Re-generate the Qt resource file by running
WebKitTools/Scripts/generate-qt-inspector-resource

inspector/front-end/WebKit.qrc:

1:12 AM Changeset in webkit [48286] by Simon Hausmann

2 edits in trunk/WebCore

Fix the Qt build, remove stray semicolon from function definition.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-11

platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:

(WebCore::MediaPlayerPrivate::buffered):

12:43 AM Changeset in webkit [48285] by jhoneycutt@apple.com

2 edits in trunk/WebKit/win

Fix crash on launch on Windows.

Rubber-stamped by Mark Rowe.

WebKit.vcproj/WebKit.vcproj:

Define ENABLE_WEB_SOCKETS for all configurations.

Sep 10, 2009:

10:48 PM Changeset in webkit [48284] by abarth@webkit.org

6 edits
44 adds in trunk

2009-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Detect mixed content
https://bugs.webkit.org/show_bug.cgi?id=29003

Add some tests for mixed content. All but one of these tests pass
currently. The one that fails is pretty tricky, but I wanted to get it
into the tree with a FIXME so we won't forget it. I'll file a followup
bug about fixing it.

http/tests/security/mixedContent/about-blank-iframe-in-main-frame-expected.txt: Added.
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html: Added.
http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt: Added.
http/tests/security/mixedContent/data-url-iframe-in-main-frame.html: Added.
http/tests/security/mixedContent/data-url-script-in-iframe-expected.txt: Added.
http/tests/security/mixedContent/data-url-script-in-iframe.html: Added.
http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt: Added.
http/tests/security/mixedContent/insecure-css-in-iframe.html: Added.
http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt: Added.
http/tests/security/mixedContent/insecure-css-in-main-frame.html: Added.
http/tests/security/mixedContent/insecure-iframe-in-iframe-expected.txt: Added.
http/tests/security/mixedContent/insecure-iframe-in-iframe.html: Added.
http/tests/security/mixedContent/insecure-iframe-in-main-frame-expected.txt: Added.
http/tests/security/mixedContent/insecure-iframe-in-main-frame.html: Added.
http/tests/security/mixedContent/insecure-image-in-iframe-expected.txt: Added.
http/tests/security/mixedContent/insecure-image-in-iframe.html: Added.
http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt: Added.
http/tests/security/mixedContent/insecure-image-in-main-frame.html: Added.
http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt: Added.
http/tests/security/mixedContent/insecure-script-in-iframe.html: Added.
http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt: Added.
http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html: Added.
http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt: Added.
http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html: Added.
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt: Added.
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html: Added.
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe-expected.txt: Added.
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html: Added.
http/tests/security/mixedContent/resources/boring.html: Added.
http/tests/security/mixedContent/resources/frame-with-about-blank-frame.html: Added.
http/tests/security/mixedContent/resources/frame-with-data-url-frame.html: Added.
http/tests/security/mixedContent/resources/frame-with-data-url-script.html: Added.
http/tests/security/mixedContent/resources/frame-with-insecure-css.html: Added.
http/tests/security/mixedContent/resources/frame-with-insecure-frame.html: Added.
http/tests/security/mixedContent/resources/frame-with-insecure-image.html: Added.
http/tests/security/mixedContent/resources/frame-with-insecure-script.html: Added.
http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-frame.html: Added.
http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-script.html: Added.
http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-frame.html: Added.
http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-script.html: Added.
http/tests/security/mixedContent/resources/script.js: Added.
http/tests/security/mixedContent/resources/style.css: Added.

2009-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Detect mixed content
https://bugs.webkit.org/show_bug.cgi?id=29003

Detect some basic kinds of mixed content (HTTP content loaded into an
HTTPS context). This new detection logic isn't perfect, but it's a
place to start.

Tests: http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html

http/tests/security/mixedContent/data-url-iframe-in-main-frame.html
http/tests/security/mixedContent/data-url-script-in-iframe.html
http/tests/security/mixedContent/insecure-css-in-iframe.html
http/tests/security/mixedContent/insecure-css-in-main-frame.html
http/tests/security/mixedContent/insecure-iframe-in-iframe.html
http/tests/security/mixedContent/insecure-iframe-in-main-frame.html
http/tests/security/mixedContent/insecure-image-in-iframe.html
http/tests/security/mixedContent/insecure-image-in-main-frame.html
http/tests/security/mixedContent/insecure-script-in-iframe.html
http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html
http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html

loader/DocLoader.cpp: (WebCore::DocLoader::canRequest): (WebCore::DocLoader::requestResource): (WebCore::DocLoader::checkCacheObjectStatus):
loader/FrameLoader.cpp: (WebCore::FrameLoader::isMixedContent): (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent):
loader/FrameLoader.h:
loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest):

9:03 PM Changeset in webkit [48283] by bweinstein@apple.com

1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj

Revert http://trac.webkit.org/changeset/48277, as it wasn't the right way to fix the build.

8:34 PM Changeset in webkit [48282] by mrowe@apple.com

2 edits in trunk/WebCore

Fix the Windows build.

Restore platform/mock to the header search path after it was removed in r48270.

WebCore.vcproj/WebCoreCommon.vsprops:

8:17 PM Changeset in webkit [48281] by timothy@apple.com

3 edits in trunk/WebCore

Web Inspector: Move the option to create a new style rule under the Styles' gear menu.

https://bugs.webkit.org/show_bug.cgi?id=29039

Reviewed by Sam Weinig.

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane): Add "New Style Rule" option to the gear menu.
(WebInspector.StylesSidebarPane.prototype._update): Check instanceof BlankStylePropertiesSection instead.
(WebInspector.StylesSidebarPane.prototype._changeSetting): Added. Keeps the color format setting selected
while calling the correct action.
(WebInspector.StylesSidebarPane.prototype._createNewRule): Creates a new section and edits the selector.
(WebInspector.StylesSidebarPane.prototype.addBlankSection): Insert the section in a cleaner way.
(WebInspector.StylesSidebarPane.prototype.removeSection): Added. Removes the passed in section.
(WebInspector.StylesSidebarPane.prototype.appropriateSelectorForNode): Return an empty string if there is no node.
(WebInspector.StylePropertiesSection.prototype.expand): Removed the check for _blank.
(WebInspector.StylePropertiesSection.prototype.startEditingSelector): No need for the context, the original selector
is remembered by the editing code.
(WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled): Do nothing. The original text is already
restored by the editing code.
(WebInspector.BlankStylePropertiesSection): Call the StylePropertiesSection constructor with appropriate data.
Remove event listener code.
(WebInspector.BlankStylePropertiesSection.prototype.expand): Added. Does nothing to prevent expanding.
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.callback): Correctly construct the
WebInspector.CSSStyleDeclaration. Call editingSelectorCancelled instead of editingCancelled.
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted): Renamed from editingCommitted to
override the base class.
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCancelled): Remove the section.
(WebInspector.BlankStylePropertiesSection.prototype.makeNormal): Removed event listener code. Removed the delete lines
since they were doing nothing (deleting nonexistent properties that exist only on the prototype.) Change prototypes at
the end to correctly swtich to a real StylePropertiesSection.

inspector/front-end/inspector.js:

(WebInspector.startEditing.editingCancelled): Ceck for null/undefined callbacks.
(WebInspector.startEditing.editingCommitted): Ditto.

8:10 PM Changeset in webkit [48280] by Laszlo Gombos

12 edits in trunk

2009-09-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Fix comparison between signed and unsigned integer warnings
https://bugs.webkit.org/show_bug.cgi?id=29162

No functional change.

Api/qwebelement.cpp: (QWebElement::findAll):
Api/qwebhistory.cpp: (QWebHistory::items): (QWebHistory::backItems): (QWebHistory::forwardItems): (QWebHistory::saveState):
Api/qwebplugindatabase.cpp: (QWebPluginDatabase::setSearchPaths):
WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runOpenPanel):
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):

2009-09-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Fix comparison between signed and unsigned integer warnings
https://bugs.webkit.org/show_bug.cgi?id=29162

No functional change.

bridge/qt/qt_runtime.cpp: (JSC::Bindings::findMethodIndex):
platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedImageMIMETypesForEncoding):
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawFocusRing):
platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::duration): (WebCore::ImageDecoderQt::imageAtIndex):
plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::fetchInfo):

7:45 PM Changeset in webkit [48279] by kov@webkit.org

2 edits in trunk/WebCore

2009-09-10 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha.

Build fix for GTK+ after r48267.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::buffered):

7:14 PM Changeset in webkit [48278] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/29147> run-webkit-tests: make -h show help

Reviewed by Mark Rowe.

Scripts/run-webkit-tests: Updated to make -h switch show help.

7:13 PM Changeset in webkit [48277] by bweinstein@apple.com

1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj

Attemped Windows build fix by adding platform/mock headers to be copied.

6:22 PM MathML edited by alex@milowski.com

(diff)

6:16 PM WikiStart edited by alex@milowski.com

(diff)

4:59 PM Changeset in webkit [48276] by jam@chromium.org

1 edit in trunk/WebCore/rendering/RenderPartObject.cpp

Sorry, one more unused paramater breaking Mac build. Will test on my Mac first next time.

4:57 PM Changeset in webkit [48275] by jam@chromium.org

1 edit in trunk/WebCore/rendering/RenderPartObject.cpp

Fix build break on Mac

4:38 PM Changeset in webkit [48274] by jam@chromium.org

4 edits in trunk

JavaScriptCore:

2009-09-08 John Abd-El-Malek <jam@chromium.org>

Reviewed by Dimitri Glazkov.

Remove unneeded define for ActiveX.
https://bugs.webkit.org/show_bug.cgi?id=29054

wtf/Platform.h:

WebCore:

2009-09-08 John Abd-El-Malek <jam@chromium.org>

Reviewed by Dimitri Glazkov.

Remove unneeded define for ActiveX.
https://bugs.webkit.org/show_bug.cgi?id=29054

rendering/RenderPartObject.cpp: (WebCore::createClassIdToTypeMap): (WebCore::serviceTypeForClassId): (WebCore::RenderPartObject::updateWidget):

4:16 PM Changeset in webkit [48273] by mrowe@apple.com

4 edits in trunk

Update JavaScriptCore and WebKit's FeatureDefines.xcconfig so that they are in sync with WebCore as they need to be.

Rubber-stamped by Sam Weinig.

4:06 PM Changeset in webkit [48272] by mrowe@apple.com

2 edits in trunk/WebCore

Don't copy IDL files in to the built framework.

Rubber-stamped by Sam Weinig.

WebCore.xcodeproj/project.pbxproj:

4:00 PM Changeset in webkit [48271] by eric@webkit.org

6 edits
2 adds in trunk

2009-09-10 Xiaomei Ji <xji@chromium.org>

Reviewed by Eric Seidel.

Implement Range.expand().
https://bugs.webkit.org/show_bug.cgi?id=27632

fast/dom/Range/range-expand-expected.txt: Added.
fast/dom/Range/range-expand.html: Added.
fast/dom/Window/window-properties-expected.txt:

2009-09-10 Xiaomei Ji <xji@chromium.org>

Reviewed by Eric Seidel.

Implment Range.expand().
https://bugs.webkit.org/show_bug.cgi?id=27632

Test: fast/dom/Range/range-expand.html

dom/Range.cpp: (WebCore::Range::expand):
dom/Range.h:
dom/Range.idl:

3:45 PM Changeset in webkit [48270] by ap@apple.com

25 edits
5 adds in trunk

Reviewed by Alexey Proskuryakov.

WebSocket API implementation.
https://bugs.webkit.org/show_bug.cgi?id=28038

Add build systems for GNUmakefile.am, WebCore.xcodeproj and
WebCore.vcproj.
Add websockets directory and WebSocket.idl in qt build system.
Tests will be landed once the code is completed and functional.

3:28 PM Changeset in webkit [48269] by ajwong@chromium.org

2 edits in trunk/WebCore

2009-09-10 Albert J. Wong <ajwong@chromium.org>

No review, windows build fix only.

Spurious semicolon causing parse error in chromium build on windows.

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::buffered): Removed semicolon.

3:15 PM Changeset in webkit [48268] by ajwong@chromium.org

2 edits in trunk/WebCore

2009-09-10 Albert J. Wong <ajwong@chromium.org>

No review, build fix only.

Adding in a missed include from the last patch that is breaking the
chromium build.

rendering/RenderThemeChromiumMac.mm: include TimeRanges.h

2:46 PM Changeset in webkit [48267] by ajwong@chromium.org

17 edits in trunk/WebCore

HTMLMediaElement buffered attribute should report a list of time ranges
https://bugs.webkit.org/show_bug.cgi?id=29041

Patch by Alpha Lam <hclam@chromium.org> on 2009-09-10
Reviewed by Eric Carlson.

Changed MediaPlayerPrivateInterface and MediaPlayer's definition to
report a list of buffered time ranges as WebCore::TimeRanges. This
change also got rid of the maxTimeBuffered() method.

No new tests since this is a API change.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::percentLoaded):
Use MediaPlaier::buffered() instead of maxTimeBuffered().
(WebCore::HTMLMediaElement::buffered):
ditto.

platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::buffered):
Use MediaPlayerPrivateInterface::buffered() instead of maxTimeBuffered().
(WebCore::MediaPlayer::buffered):
ditto.

platform/graphics/MediaPlayer.h:

Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().

platform/graphics/MediaPlayerPrivate.h:

ditto.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:

Implements PassRefPtr<TimeRanges> buffered();

platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().

platform/graphics/mac/MediaPlayerPrivateQTKit.h:

Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().

platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivate::buffered):
Implementation of buffered().

platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:

Implements PassRefPtr<TimeRanegs> buffered().

platform/graphics/qt/MediaPlayerPrivatePhonon.h:

Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:

Implements PassRefPtr<TimeRanges> buffered().

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:

Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().

platform/graphics/wince/MediaPlayerPrivateWince.h:

ditto.

rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
Use buffered() instead of maxTimeBuffered().

rendering/RenderThemeChromiumSkia.cpp:

ditto.

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaSliderTrack):
ditto.

2:34 PM Changeset in webkit [48266] by eric@webkit.org

6 edits in trunk/WebCore

2009-09-10 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Make bindings generators more aware of IDL dependencies
https://bugs.webkit.org/show_bug.cgi?id=29114

Make the JS and ObjC bindings generators able to output dependency
rules for DerivedSources.make to consume. These rules make a given
generated binding class file header, JSWhatever.h, depend on Whatever's
ancestor interfaces.

DerivedSources.make: Pass --write-dependencies to generate-bindings.pl when generating JS and ObjC bindings. Include dependency fies that are generated due to that.
bindings/scripts/CodeGenerator.pm: Make AddMethodsConstantsAndAttributesFromParentClasses accumulate a list of the ancestor interfaces that were visited.
bindings/scripts/CodeGeneratorJS.pm: Optionally write out a dependency file.
bindings/scripts/CodeGeneratorObjC.pm: Ditto.
bindings/scripts/generate-bindings.pl: Add a --write-dependencies option.

1:49 PM Changeset in webkit [48265] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Windows build fix.

Make StructureTransitionTable use an enum for the PtrAndFlags member
used for the single transition slot optimisation.

1:01 PM Changeset in webkit [48264] by oliver@apple.com

5 edits in trunk/JavaScriptCore

Refactor StructureTransitionTable and Structure to unify handling of the single slot optimization
https://bugs.webkit.org/show_bug.cgi?id=29141

Reviewed by Geoff Garen

Make StructureTransitionTable encapsulate the single transition slot optimization.

12:52 PM Changeset in webkit [48263] by Simon Hausmann

4 edits in trunk/WebKit/qt

Rubber-stamped by Ariya Hidayat.

Patch by Simon Hausmann <Simon Hausmann> on 2009-09-10
Fix a bunch of qdoc warnings: Invalid references, non-standard
wording, etc.

Api/qwebelement.cpp:
Api/qwebgraphicsitem.cpp:
Api/qwebsecurityorigin.cpp:

12:42 PM Changeset in webkit [48262] by Simon Hausmann

5 edits in trunk/WebKit/qt

Fix context menu event delivery with QWebGraphicsItem.

Patch by Simon Hausmann <Simon Hausmann> on 2009-09-10
Reviewed by Ariya Hidayat.

Re-implement the correct context menu virtual function using
a QGraphicsSceneContextMenuEvent and forward & handle it in
QWebPage.

Api/qwebgraphicsitem.cpp:

(QWebGraphicsItem::contextMenuEvent):

Api/qwebgraphicsitem.h:
Api/qwebpage.cpp:

(QWebPagePrivate::contextMenuEvent):
(QWebPage::event):

Api/qwebpage_p.h:

11:24 AM MathML edited by alex@milowski.com

(diff)

11:24 AM MathML edited by alex@milowski.com

(diff)

11:19 AM MathML edited by alex@milowski.com

(diff)

11:18 AM MathML created by alex@milowski.com

10:58 AM Changeset in webkit [48261] by kov@webkit.org

3 edits in trunk/WebCore

2009-09-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez and Dan Winship.

Give all requests to libsoup, to let it queue, and schedule them
itself, instead of throttling the number of requests in WebCore.

platform/network/ResourceRequestBase.cpp:
platform/network/soup/ResourceRequestSoup.cpp: (WebCore::initializeMaximumHTTPConnectionCountPerHost):

10:39 AM Changeset in webkit [48260] by jianli@chromium.org

3 edits
5 adds in trunk

WebCore: [V8] Make XMLHttpRequest.send handle File object.
https://bugs.webkit.org/show_bug.cgi?id=28924

Reviewed by Eric Seidel.

Test: http/tests/local/send-dragged-file.html

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

LayoutTests: [V8] Make XMLHttpRequest.send handle File object.
https://bugs.webkit.org/show_bug.cgi?id=28924

Reviewed by Eric Seidel.

Add a new layout test.

http/tests/local/resources/file-for-drag-to-send.txt: Added.
http/tests/local/resources/send-dragged-file.js: Added.
http/tests/local/send-dragged-file-expected.txt: Added.
http/tests/local/send-dragged-file.html: Added.

10:33 AM Changeset in webkit [48259] by zoltan@webkit.org

6 edits in trunk

2009-09-10 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Implement fastDeleteSkippingDestructor for FastAllocBase and fastDeleteAllValues for HashSet
https://bugs.webkit.org/show_bug.cgi?id=25930

FastAllocBase has been extended with fastDeleteSkippingDestructor function which
releases memory without destructor call. fastDeleteAllValues has been implemented
similar as deleteAllValues but it uses fastDelete function to release memory.

wtf/FastAllocBase.h: (WTF::fastDeleteSkippingDestructor):
wtf/HashSet.h: (WTF::fastDeleteAllValues):

2009-09-10 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Use fastNew and fastDelete instead of operator new and delete for CSSSelector class.
https://bugs.webkit.org/show_bug.cgi?id=25930

Change using of operator new to fastNew and operator delete to
fastDeleteSkippingDestructor for CSSSelector class to avoid mismatched function call.

This change fixes valgrind's 'mismatched free' notification.

css/CSSParser.cpp: (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::createFloatingSelector):
css/CSSSelectorList.cpp: (WebCore::CSSSelectorList::adoptSelectorVector):

10:16 AM Changeset in webkit [48258] by benm@google.com

5 edits
6 adds in trunk

WebCore: Geolocation does not correctly handle reentrant calls from callbacks.
https://bugs.webkit.org/show_bug.cgi?id=29040

Patch by Steve Block <steveblock@google.com> on 2009-09-10
Reviewed by Darin Adler.

Tests: fast/dom/Geolocation/reentrant-error.html

fast/dom/Geolocation/reentrant-success.html

page/Geolocation.cpp: Modified.

(WebCore::Geolocation::handleError): Modified. Call sendError directly, clearing notifier lists before making callback.
(WebCore::Geolocation::makeSuccessCallbacks): Modified. Call sendPosition directly, clearing notifier lists before making callback.

page/Geolocation.h: Modified. Deleted sendErrorToXX and sendPositionToXXX methods.

LayoutTests: Geolocation does not correctly handle reentrant calls from callbacks.
https://bugs.webkit.org/show_bug.cgi?id=29040

Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Darin Adler.

fast/dom/Geolocation/resources/reentrant-error.js: Added. Tests that reentrant calls from the error callback are OK.
fast/dom/Geolocation/reentrant-error.html: Added. Wrapper for above test.
fast/dom/Geolocation/reentrant-error-expected.txt: Added. Expected result for above test.
fast/dom/Geolocation/resources/reentrant-success.js: Added. Tests that reentrant calls from the success callback are OK.
fast/dom/Geolocation/reentrant-success.html: Added. Wrapper for above test.
fast/dom/Geolocation/reentrant-success-expected.txt: Added. Expected result for above test.
platform/gtk/Skipped: Modified. Skips above tests.

10:03 AM Changeset in webkit [48257] by eric@webkit.org

5 edits
3 adds in trunk

2009-09-10 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Fixes issue where focused elements did not get blur and focus events when the window was blurred and focused.
https://bugs.webkit.org/show_bug.cgi?id=27105

fast/events/blur-focus-window-should-blur-focus-element-expected.txt: Added.
fast/events/blur-focus-window-should-blur-focus-element.html: Added.
fast/events/resources/blur-focus-window-should-blur-focus-element.js: Added. (divElement.onfocus.divElement.onblur.window.onfocus.window.onblur.innerDiv.onfocus.innerDiv.onblur.iframe.onfocus.iframe.onblur): (testNextEvent):
fast/events/resources/tabindex-focus-blur-all.js: (test):
fast/events/tabindex-focus-blur-all-expected.txt:

2009-09-10 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Fixes issue where focused elements did not get blur and focus events when the window was blurred and focused.
https://bugs.webkit.org/show_bug.cgi?id=27105

Test: fast/events/blur-focus-window-should-blur-focus-element.html

page/FocusController.cpp: (WebCore::dispatchEventsOnWindowAndFocusedNode): (WebCore::FocusController::setFocused): (WebCore::FocusController::setActive):

9:41 AM Changeset in webkit [48256] by abarth@webkit.org

1 edit
2 adds in trunk/LayoutTests

2009-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24205

Added a test case for inserting a new line character into the
request-uri.

http/tests/xmlhttprequest/newline-in-request-uri-expected.txt: Added.
http/tests/xmlhttprequest/newline-in-request-uri.html: Added.

8:56 AM Changeset in webkit [48255] by Adam Roben

2 edits in trunk/WebCore

Make the play/pause button in <video> controls indicate the button's action, not the movie state

This matches the Mac behavior, iTunes, and many other media players.

No test possible.

Fixes <http://webkit.org/b/29126> Play/pause button in <video>
controls shows the wrong image

Reviewed by Eric Carlson.

rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaControls::paintMediaControlsPart): Reversed when
we show the play vs. pause artwork, so that the button reflects what
will happen when you click it, rather than the current state of the
movie.

8:34 AM Changeset in webkit [48254] by Laszlo Gombos

3 edits in trunk/WebKit/qt

2009-09-10 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

Build fix for QtWebKit for Mac after r48219.

qevent and qstyleoption are QtGui interfaces.

Api/qwebgraphicsitem.cpp:
Api/qwebgraphicsitem.h:

7:04 AM Changeset in webkit [48253] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-09-10 Martin Robinson <martin.james.robinson@gmail.com>

[GTK] EventSender does not properly convert some keyDown strings
https://bugs.webkit.org/show_bug.cgi?id=29119

Add more keyDown string to character code conversions for GTK+ EventSender.

DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):

6:26 AM Changeset in webkit [48252] by benm@google.com

15 edits
3 adds
2 deletes in trunk

WebCore: Geolocation Coordinates::toString() prints bogus values for unspecified properties.
https://bugs.webkit.org/show_bug.cgi?id=29080

Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Maciej Stachowiak.

Test: fast/dom/Geolocation/position-string.html

GNUmakefile.am: Modified. Removes Geoposition.cpp and Coordinates.cpp.
WebCore.gypi: Modified. Removes Geoposition.cpp and Coordinates.cpp.
WebCore.pro: Modified. Removes Geoposition.cpp and Coordinates.cpp.
WebCore.vcproj/WebCore.vcproj: Modified. Removes Geoposition.cpp and Coordinates.cpp.
WebCore.xcodeproj/project.pbxproj: Modified. Removes Geoposition.cpp and Coordinates.cpp.
WebCoreSources.bkl: Modified. Removes Geoposition.cpp and Coordinates.cpp.
page/Coordinates.cpp: Removed.
page/Coordinates.h: Modified. Removes toString method.
page/Coordinates.idl: Modified. Removes toString method.
page/Geoposition.cpp: Removed.
page/Geoposition.h: Modified. Removes toString method.
page/Geoposition.idl: Modified. Removes toString method.

WebKitTools: Geolocation Coordinates::toString() prints bogus values for unspecified properties.
https://bugs.webkit.org/show_bug.cgi?id=29080

Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Maciej Stachowiak.

Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.

LayoutTests: Geolocation Coordinates::toString() prints bogus values for unspecified properties.
https://bugs.webkit.org/show_bug.cgi?id=29080

Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Maciej Stachowiak.

fast/dom/Geolocation/resources/position-string.js: Added. Tests output of position.toString().
fast/dom/Geolocation/position-string.html: Added. Wrapper for above test.
fast/dom/Geolocation/position-string-expected.txt: Added. Expected result for above test.
platform/gtk/Skipped: Modified. Skips above test.

5:45 AM Changeset in webkit [48251] by Laszlo Gombos

2 edits in trunk/JavaScriptCore

2009-09-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

ARM compiler does not understand GCC visibility attribute
https://bugs.webkit.org/show_bug.cgi?id=29079

API/JSBase.h: Make the test more specific to hit only the GCC compiler

4:59 AM Changeset in webkit [48250] by Laszlo Gombos

2 edits in trunk

2009-09-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Ariya Hidayat.

Disable some ARM compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=29083

The following ARM compiler warnings are disabled

#68-D: integer conversion resulted in a change of sign
#111-D: statement is unreachable
#177-D: variable XXX was declared but never referenced
#368-D: class XXX defines no constructor to initialize the following: YYY
#830-D: function XXX "XXX::operator new" has no corresponding operator delete
#1293-D: assignment in condition

WebKit.pri:

4:32 AM Changeset in webkit [48249] by benm@google.com

5 edits
6 adds in trunk

WebCore: Correctly applies the Geolocation timeout property.
https://bugs.webkit.org/show_bug.cgi?id=27256

Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Adam Barth.

If a timeout is specified, the timer is started as soon as the location acquistion process starts.
If a position fix is not obtained within the timeout interval, the position request is cancelled
and the error callback (if specified) is invoked. If a position fix is obtained within the timeout
interval, the timer is stopped. Permissions are then requested from the user if required. See
http://www.w3.org/TR/geolocation-API/#position-options.

Note that this logic means that the time required to obtain permissions from the user is not
included in the timeout interval.

Tests: fast/dom/Geolocation/timeout.html

fast/dom/Geolocation/timeout-zero.html

page/Geolocation.cpp: Modified.

(WebCore::Geolocation::GeoNotifier::GeoNotifier): Modified. Takes Geolocation object as parameter.
(WebCore::Geolocation::GeoNotifier::hasZeroTimeout): Added. Determines whether this request has a zero timeout.
(WebCore::Geolocation::GeoNotifier::startTimerIfNeeded): Renamed from startTimer. Starts the timer if a timeout was specified.
(WebCore::Geolocation::GeoNotifier::timerFired): Modified. Calls the error callback if specified, and reports the timeout to the Geolocation object.
(WebCore::Geolocation::getCurrentPosition): Modified. Calls maybeStartTimer when starting the location acquisition process.
(WebCore::Geolocation::watchPosition): Modified. Calls maybeStartTimer when starting the location acquisition process.
(WebCore::Geolocation::requestTimedOut): Added. Cancels a request when it times out.
(WebCore::Geolocation::setIsAllowed): Modified. No longer starts timers.
(WebCore::Geolocation::sendPosition): Modified. No longer stops timers.
(WebCore::Geolocation::stopTimer): Added. Stops the timers for a vector of notifiers.
(WebCore::Geolocation::stopTimersForOneShots): Added. Stops the timers for all one-shots.
(WebCore::Geolocation::stopTimersForWatchers): Added. Stops the timers for all watchers.
(WebCore::Geolocation::stopTimers): Added. Stops the timers for all requests.
(WebCore::Geolocation::geolocationServicePositionChanged): Modfified. Stops the timers for all requests.

page/Geolocation.h: Modified.

(WebCore::Geolocation::GeoNotifier::create): Modified. Takes Geolocation object as parameter.

LayoutTests: Correctly applies the Geolocation timeout property.
https://bugs.webkit.org/show_bug.cgi?id=27256

Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Adam Barth.

fast/dom/Geolocation/resources/timeout.js: Added. Tests that when a non-zero timeout is used, the success callback is invoked as expected.
fast/dom/Geolocation/timeout.html: Added. Wrapper for above test.
fast/dom/Geolocation/timeout-expected.txt: Added. Expected result for above test.
fast/dom/Geolocation/resources/timeout-zero.js: Added. Tests that when a zero timeout is used, the error callback is invoked with code TIMEOUT.
fast/dom/Geolocation/timeout-zero.html: Added. Wrapper for above test.
fast/dom/Geolocation/timeout-zero-expected.txt: Added. Expected result for above test.
platform/gtk/Skipped: Modified. Skips the above tests.

2:08 AM Changeset in webkit [48248] by abarth@webkit.org

2 edits in trunk/JavaScriptCore

2009-09-10 Adam Barth <abarth@webkit.org>

Unreviewed revert of the previous change. It broke the tests.

wtf/dtoa.cpp: (WTF::dtoa):

1:51 AM Changeset in webkit [48247] by abarth@webkit.org

2 edits in trunk/JavaScriptCore

2009-09-10 Ben Laurie <benl@google.com>

Reviewed by Adam Barth.

<https://bugs.webkit.org/show_bug.cgi?id=26836>

If dtoa was given a small buffer and the number was either infinite or
NaN, then the buffer would be overflowed.

wtf/dtoa.cpp:

Sep 9, 2009:

11:58 PM Changeset in webkit [48246] by Simon Hausmann

2 edits in trunk/WebKit/qt

Call the right base class function QGraphicsWidget::event() instead
of skipping it and using QObject::event() instead.

Patch by Simon Hausmann <Simon Hausmann> on 2009-09-09
Reviewed by Tor Arne Vestbø.

Api/qwebgraphicsitem.cpp:

(QWebGraphicsItem::event):

11:47 PM Changeset in webkit [48245] by Chris Fleizach

2 edits in trunk/WebCore

AX notifications should be an ENUM type instead of strings
https://bugs.webkit.org/show_bug.cgi?id=28963

Build fix for Qt.

accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::postPlatformNotification):

11:38 PM Changeset in webkit [48244] by Chris Fleizach

15 edits in trunk/WebCore

AX notifications should be an ENUM type instead of strings
https://bugs.webkit.org/show_bug.cgi?id=28963

Reviewed by Darin Adler.

Moves AX notifications over to an ENUM type instead of
using the actual string values that are used on OS X.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::selectedChildrenChanged):

accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):

accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

dom/Document.cpp:

(WebCore::Document::implicitClose):

dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

editing/Editor.cpp:

(WebCore::Editor::respondToChangedContents):

editing/mac/SelectionControllerMac.mm:

(WebCore::SelectionController::notifyAccessibilityForSelectionChange):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setChecked):

page/FrameView.cpp:

(WebCore::FrameView::layout):

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::setInnerTextValue):

10:25 PM Changeset in webkit [48243] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-09-09 Eric Seidel <eric@webkit.org>

Reviewed by Eric Carlson.

reviewer/committer lookups are backwards
https://bugs.webkit.org/show_bug.cgi?id=29113

I also moved Eric Carlson from the committer list to the reviewer list now that he is one.

Scripts/modules/bugzilla.py:
Scripts/modules/committers.py:

10:17 PM Changeset in webkit [48242] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-09-09 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

svn-unapply doesn't revert directories correctly
https://bugs.webkit.org/show_bug.cgi?id=29065

Scripts/svn-unapply: Make svnStatus consistently return status lines including a newline.
Scripts/svn-apply: Keep svnStatus in sync with the one in svn-unapply, in lieu of moving it to a common file.

9:52 PM Changeset in webkit [48241] by ddkilzer@apple.com

2 edits in trunk/BugsSite

Update data/params parameters

data/params: Updated 'attachment_base' parameter for secure attachments. Updated 'mybugstemplate' parameter to search for bugs in UNCONFIRMED, ASSIGNED and REOPENED status in addition to NEW status.

7:54 PM Changeset in webkit [48240] by abarth@webkit.org

3 edits
5 adds in trunk

2009-09-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Missing checkout for getSVGDocument()
https://bugs.webkit.org/show_bug.cgi?id=29064

The V8 code generator didn't understand SVGCheckSecurityDocument.

Tests: http/tests/security/xss-DENIED-getSVGDocument-iframe.html

http/tests/security/xss-DENIED-getSVGDocument-object.html

bindings/scripts/CodeGeneratorV8.pm:

2009-09-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Missing checkout for getSVGDocument()
https://bugs.webkit.org/show_bug.cgi?id=29064

Add tests that getSVGDocument() has the proper checks.

http/tests/security/resources/flag.php: Added.
http/tests/security/xss-DENIED-getSVGDocument-iframe-expected.txt: Added.
http/tests/security/xss-DENIED-getSVGDocument-iframe.html: Added.
http/tests/security/xss-DENIED-getSVGDocument-object-expected.txt: Added.
http/tests/security/xss-DENIED-getSVGDocument-object.html: Added.

5:55 PM Changeset in webkit [48239] by eric@webkit.org

5 edits
6 adds in trunk

2009-09-09 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Make SVGStyleElement inherit from SVGLangSpace
https://bugs.webkit.org/show_bug.cgi?id=29058

Required by SVG 1.1 Second Edition:
http://dev.w3.org/SVG/profiles/1.1F2/publish/styling.html#InterfaceSVGStyleElement

svg/dom/SVGStyleElement: Added.
svg/dom/SVGStyleElement/resources: Added.
svg/dom/SVGStyleElement/resources/TEMPLATE.html: Copied from LayoutTests/svg/dom/resources/TEMPLATE.html with some "../"s added.
svg/dom/SVGStyleElement/resources/style-langspace.js: Added.
svg/dom/SVGStyleElement/style-langspace-expected.txt: Added.
svg/dom/SVGStyleElement/style-langspace.html: Added.

2009-09-09 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Make SVGStyleElement inherit from SVGLangSpace
https://bugs.webkit.org/show_bug.cgi?id=29058

Required by SVG 1.1 Second Edition:
http://dev.w3.org/SVG/profiles/1.1F2/publish/styling.html#InterfaceSVGStyleElement

Test: svg/dom/SVGStyleElement/style-langspace.html

svg/SVGStyleElement.cpp: Drop methods xmlspace and setXmlspace. (WebCore::SVGStyleElement::SVGStyleElement): Add SVGLangSpace() initializer. (WebCore::SVGStyleElement::parseMappedAttribute): Call parseMappedAttribute on SVGLangSpace.
svg/SVGStyleElement.h: Drop xmlspace and setXmlspace declarations.
svg/SVGStyleElement.idl: Drop xmlspace attribute and add SVGLangSpace as a superinterface.

5:39 PM Changeset in webkit [48238] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-09 Nate Chapin <Nate Chapin>

Reviewed by David Levin.

Remove unnecessary includes and forward declarations in V8Proxy.h

https://bugs.webkit.org/show_bug.cgi?id=29111

bindings/v8/V8Proxy.h:

4:55 PM Changeset in webkit [48237] by eric@webkit.org

11 edits
1 add in trunk/LayoutTests

2009-09-09 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Carlson.

Media layout tests should have a way to provide test files in different formats
https://bugs.webkit.org/show_bug.cgi?id=28327

Added media-file.js which has a findMediaFile(type, name) method
to find a proper media file to load according to supported codecs.

Also changed 10 layout tests to use above method to locate the test file.

media/controls-strict.html: Use findMediaFile(type, name).
media/controls-styling.html: ditto.
media/media-file.js: Added. Provide findMediaFile(type, name).
media/video-append-source.html: Use findMediaFile(type, name).
media/video-aspect-ratio.html: ditto.
media/video-autoplay.html: ditto.
media/video-buffered.html: ditto.
media/video-controls-rendering.html: ditto.
media/video-layer-crash.html: ditto.
media/video-transformed.html: Use findMediaFile(type, name).
media/video-zoom-controls.html: ditto.

4:41 PM Changeset in webkit [48236] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-09-09 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

svn-apply doesn't handle changes to files copied to new directories properly
https://bugs.webkit.org/show_bug.cgi?id=29059

Scripts/svn-apply: Don't treat "--- revision 0" patches as being additions if we know that we've just copied a file to this name.

4:25 PM Changeset in webkit [48235] by eric@webkit.org

6 edits in trunk/WebCore

2009-07-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add more position constructors
positionBeforeNode, positionAfterNode
firstPositionInNode, lastPositionInNode
https://bugs.webkit.org/show_bug.cgi?id=25494

I also added a lastOffsetInNode and deployed it to a couple places.

There are no callers to these new constructors yet, but those
will be coming in future patches.

dom/Position.cpp: (WebCore::Position::computeOffsetInContainerNode):
dom/Position.h: (WebCore::positionBeforeNode): (WebCore::positionAfterNode): (WebCore::lastOffsetInNode): (WebCore::firstPositionInNode): (WebCore::lastPositionInNode):
editing/ApplyStyleCommand.cpp:
editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
editing/htmlediting.cpp: (WebCore::lastOffsetForEditing):

4:25 PM Changeset in webkit [48234] by eric@webkit.org

16 edits
1 add in trunk/WebCore

2009-07-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename positionBeforeNode to positionInParentBeforeNode
and positionAfterNode to positionInParentAfterNode
in preparation for adding a positionBeforeNode
which returns a neighbor-anchored position.
https://bugs.webkit.org/show_bug.cgi?id=25494

No functional changes, thus no tests.

dom/PositionConstructors.h: (WebCore::positionInParentBeforeNode): (WebCore::positionInParentAfterNode):
dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position):
editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle):
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionOutsideTabSpan): (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply):
editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::deleteTarget):
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): (WebCore::updatePositionForNodeRemoval):
editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): (WebCore::ReplaceSelectionCommand::doApply):
editing/VisibleSelection.cpp: (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::lastEditablePositionBeforePositionInRoot): (WebCore::rangeCompliantEquivalent): (WebCore::positionBeforeContainingSpecialElement): (WebCore::positionAfterContainingSpecialElement): (WebCore::positionBeforeTabSpan):

4:25 PM Changeset in webkit [48233] by eric@webkit.org

7 edits in trunk/WebCore

2009-07-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Re-organize position creation functions in preparation for adding more
https://bugs.webkit.org/show_bug.cgi?id=25494

Make position functions inline to avoid ref-churn.
Remove startPosition/endPosition as they were only used in one place.

No functional changes, thus no tests.

dom/Position.cpp:
dom/Position.h: (WebCore::positionBeforeNode): (WebCore::positionAfterNode):
editing/SelectionController.cpp: (WebCore::SelectionController::moveTo):
editing/TypingCommand.cpp:
editing/htmlediting.cpp:
editing/htmlediting.h: (WebCore::firstDeepEditingPositionForNode): (WebCore::lastDeepEditingPositionForNode):
rendering/RenderObject.cpp:

3:50 PM Changeset in webkit [48232] by kevino@webkit.org

2 edits
1 add in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx] Add wxSize conversions for IntSize.
https://bugs.webkit.org/show_bug.cgi?id=29104

3:35 PM Changeset in webkit [48231] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by David Levin.

Chromium uses its own config.h file that was forked from webkit's config.h.
By merging in Chromium's defines, Chromium would again be able to use webkit's
config.h.

https://bugs.webkit.org/show_bug.cgi?id=28882

config.h: Added chromium-specific defines.

3:21 PM Changeset in webkit [48230] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-09-09 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

commit-queue hangs if a builder has never built
https://bugs.webkit.org/show_bug.cgi?id=29091

Scripts/modules/buildbot.py:
Scripts/modules/buildbot_unittest.py:

3:19 PM Changeset in webkit [48229] by eric@webkit.org

10 edits
2 adds in trunk

2009-09-09 Jens Alfke <snej@chromium.org>

Reviewed by Eric Seidel.

Initialize DataTransfer's effectAllowed and dropEffect properties correctly
according to HTML5 spec (sec. 7.9.2-7.9.3).
https://bugs.webkit.org/show_bug.cgi?id=26700

fast/events/drag-dropeffect-expected.txt: Added.
fast/events/drag-dropeffect.html: Added.

2009-09-09 Jens Alfke <snej@chromium.org>

Reviewed by Eric Seidel.

Initialize DataTransfer's effectAllowed and dropEffect properties correctly
according to HTML5 spec (sec. 7.9.2-7.9.3).
https://bugs.webkit.org/show_bug.cgi?id=26700

At the start of a drag operation, the value of effectAllowed should be the string "uninitialized".
At end of dragstart handler, if effectAllowed hasn't been set yet, it should be set to "copy".
on dragenter and dragover event, dropEffect should be initialized to a default value based on the value of effectAllowed.
at end of dragenter and dragover the dropEffect should be set to "none" if the value set by the handler doesn't match the effectAllowed.
on dragleave event, dropEffect should be "none".
on drop event, dropEffect should be the previously negotiated value.

Test: fast/events/drag-dropeffect.html

WebCore.base.exp:

Added a parameter to EventHandler::dragSourceMovedTo.

dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard):

Initialize m_effectAllowed to "uninitialized".

(WebCore::Clipboard::sourceOperation):

Treat "uninitialized" as meaning no value has been set.

page/DragController.cpp: (WebCore::DragController::DragController):

Initialize new member m_destinationDragOperation.

(WebCore::DragController::dragExited):

Set m_destinationDragOperation to none on dragExit.

(WebCore::DragController::performDrag):

Set m_destinationDragOperation to current dropEffect.

(WebCore::DragController::dragEnteredOrUpdated):

Make sure to clear the operation if drag source doesn't allow it.

(WebCore::DragController::tryDHTMLDrag):

Set a default value for the dst drag op before sending dragEnter/Over.

(WebCore::DragController::startDrag):

Clear m_destinationDragOperation at start of drag.

page/DragController.h: (WebCore::DragController::destinationDragOperation):

Added new member m_destinationDragOperation, and its public getter.

page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop):

dropEffect should be 'none' during dropleave handler, per spec.

(WebCore::EventHandler::dragSourceMovedTo):

Added DragOperation parameter, so the handler sees the current dropEffect.

(WebCore::EventHandler::handleDrag):

Assume DragOperationEvery for non-DHTML drags.

page/EventHandler.h:

Added DragOperation parameter to dragSourceMovedTo().

2009-09-09 Jens Alfke <snej@chromium.org>

Reviewed by Eric Seidel.

Initialize DataTransfer's effectAllowed and dropEffect properties correctly
according to HTML5 spec (sec. 7.9.2-7.9.3).
https://bugs.webkit.org/show_bug.cgi?id=26700

WebView/WebFrame.mm: (-[WebFrame _dragSourceMovedTo:]):

Pass current drag operation (if known) to EventHandler::dragSourceMovedTo().

3:10 PM Changeset in webkit [48228] by eric@webkit.org

8 edits
2 adds in trunk

2009-09-09 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] DumpRenderTree needs eventSender object and implementation
https://bugs.webkit.org/show_bug.cgi?id=25990

Enable plenty of tests that now pass thanks to (only) partial
EventSender implementation.

platform/gtk/Skipped:

2009-09-09 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] DumpRenderTree needs eventSender object and implementation
https://bugs.webkit.org/show_bug.cgi?id=25990

Creates a function that is accessible from the DumpRenderTree tool
and calls the layout method on the frame view.

webkit/webkitprivate.h:
webkit/webkitwebframe.cpp: (webkit_web_frame_layout):

2009-09-09 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] DumpRenderTree needs eventSender object and implementation
https://bugs.webkit.org/show_bug.cgi?id=25990

Implements most of the EventSender object's functionality for
the DumpRenderTree tool. Implementation still lacks support
for drag and drop tests and forward leaps.

Based on work by Holger Hans Peter Freyther.

DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): Focus on the view before loading a new test. (webViewWindowObjectCleared):
DumpRenderTree/gtk/EventSender.cpp: Added. (getDragModeCallback): (setDragModeCallback): (leapForwardCallback): (contextClickCallback): (updateClickCount): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (beginDragWithFilesCallback): (replaySavedEvents): (keyDownCallback): (textZoomInCallback): (textZoomOutCallback): (zoomPageInCallback): (zoomPageOutCallback): (getClass): (makeEventSender):
DumpRenderTree/gtk/EventSender.h: Added.
GNUmakefile.am: Add build rules for EventSender.

2:35 PM Changeset in webkit [48227] by eric@webkit.org

14 edits
2 adds in trunk

2009-09-09 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Adding a test for the database authorizer.

https://bugs.webkit.org/show_bug.cgi?id=28918

storage/test-authorizer-expected.txt: Added.
storage/test-authorizer.html: Added.

2009-09-09 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Adding support/bindings for read-only transactions.
Disallowing the SQLITE_*_VIEW and REINDEX operations in the private browsing mode.
Adding an authorizer test.

https://bugs.webkit.org/show_bug.cgi?id=28918

Test: storage/test-authorizer.html

bindings/js/JSDatabaseCustom.cpp: (WebCore::createTransaction): Parses all arguments and executes a transaction. (WebCore::JSDatabase::transaction): Refactored to use createTransaction(). (WebCore::JSDatabase::readTransaction): Added to execute read-only transactions using createTransaction().
bindings/v8/custom/V8CustomBinding.h: Added the binding for Database::readTransaction().
bindings/v8/custom/V8DatabaseCustom.cpp: (WebCore::createTransaction): Parses all arguments and executes a transaction. (WebCore::transaction): Refactored to use createTransaction(). (WebCore::readTransaction): Added to execute read-only transactions using createTransaction().
storage/Database.cpp: (WebCore::Database::transaction): Added support for read-only transactions.
storage/Database.h: Added support for read-only transactions.
storage/Database.idl: Added support for read-only transactions.
storage/DatabaseAuthorizer.cpp: (WebCore::DatabaseAuthorizer::createTempTable): Make it obvious that the statement will be denied in private browsing mode and read-only transactions. (WebCore::DatabaseAuthorizer::dropTempTable): Same. (WebCore::DatabaseAuthorizer::createTempIndex): Same. (WebCore::DatabaseAuthorizer::dropTempIndex): Same. (WebCore::DatabaseAuthorizer::createTempTrigger): Same. (WebCore::DatabaseAuthorizer::dropTempTrigger): Same. (WebCore::DatabaseAuthorizer::createView): Deny in private browsing mode and read-only transactions. (WebCore::DatabaseAuthorizer::createTempView): Same. (WebCore::DatabaseAuthorizer::dropView): Same. (WebCore::DatabaseAuthorizer::dropTempView): Same. (WebCore::DatabaseAuthorizer::allowReindex): Same.
storage/DatabaseAuthorizer.h:
storage/SQLTransaction.cpp: Added support for read-only transactions. (WebCore::SQLTransaction::create): (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::executeSQL): (WebCore::SQLTransaction::acquireLock):
storage/SQLTransaction.h:
storage/SQLTransactionCoordinator.cpp: (WebCore::SQLTransactionCoordinator::acquireLock): Added a new parameter in preparation for a change that will allow multiple read-only transactions on the same DB to run concurrently.
storage/SQLTransactionCoordinator.h:

2:30 PM QtWebKitContrib edited by vestbo@webkit.org

(diff)

2:28 PM Changeset in webkit [48226] by vestbo@webkit.org

2 edits in trunk/WebKitSite

Add instructions to bug reporting guidlines on how and when
to apply port-specific keywords.

Reviewed by Mark Rowe.

quality/bugwriting.html:

2:21 PM Changeset in webkit [48225] by hyatt@apple.com

4 edits in trunk/WebCore/page

Fix namespace typos.

2:21 PM Changeset in webkit [48224] by hyatt@apple.com

1 edit in trunk/WebCore/page/FrameTree.cpp

Fix namespace typos.

2:18 PM Changeset in webkit [48223] by kenneth@webkit.org

2 edits in trunk/WebKit/qt

Fix comment at Tor Arne Vestbø's request.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-09

Api/qwebgraphicsitem.cpp:

(QWebGraphicsItem::sceneEvent):
(QWebGraphicsItem::event):

2:12 PM Changeset in webkit [48222] by hyatt@apple.com

23 edits
4 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection. This is similar
to user script injection but allows for user stylesheets to be added. The stylesheets are applied immediately
to all Frames in the PageGroup.

Reviewed by Adam Roben.

Added userscripts/simple-stylesheet.html test case.

WebCore.base.exp:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):

css/CSSStyleSelector.h:
dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::attach):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::clearPageGroupUserSheets):
(WebCore::Document::recalcStyleSelector):

dom/Document.h:
loader/PlaceholderDocument.cpp:

(WebCore::PlaceholderDocument::attach):

page/PageGroup.cpp:

(WebCore::PageGroup::addUserStyleSheet):
(WebCore::PageGroup::removeUserContentForWorld):
(WebCore::PageGroup::removeAllUserContent):

page/PageGroup.h:

(WebCore::PageGroup::userStyleSheets):

page/UserStyleSheet.h: Added.

(WebCore::UserStyleSheet::UserStyleSheet):
(WebCore::UserStyleSheet::source):
(WebCore::UserStyleSheet::url):
(WebCore::UserStyleSheet::patterns):
(WebCore::UserStyleSheet::worldID):

page/UserStyleSheetTypes.h: Added.

WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection. This is similar
to user script injection but allows for user stylesheets to be added. The stylesheets are applied immediately
to all Frames in the PageGroup.

Reviewed by Adam Roben.

Added userscripts/simple-stylesheet.html test case.

WebView/WebView.mm:

(+[WebView _addUserStyleSheetToGroup:source:url:worldID:patterns:]):

WebView/WebViewPrivate.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection. This is similar
to user script injection but allows for user stylesheets to be added. The stylesheets are applied immediately
to all Frames in the PageGroup.

Reviewed by Adam Roben.

Added userscripts/simple-stylesheet.html test case.

platform/mac/userscripts/simple-stylesheet-expected.checksum: Added.
platform/mac/userscripts/simple-stylesheet-expected.png: Added.
platform/mac/userscripts/simple-stylesheet-expected.txt: Added.
userscripts/simple-stylesheet.html: Added.

2:11 PM Changeset in webkit [48221] by kenneth@webkit.org

3 edits in trunk/WebKit/qt

Implement some virtual event methods so that we can fix
event-related bugs in Qt patch releases.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-09
Reviewed by Tor Arne Vestbø.

Api/qwebgraphicsitem.cpp:

(QWebGraphicsItem::sceneEvent):
(QWebGraphicsItem::event):

Api/qwebgraphicsitem.h:

1:40 PM Changeset in webkit [48220] by Laszlo Gombos

5 edits
6 adds in trunk

2009-09-09 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] CSS Style -webkit-box-shadow is not rendered correctly on
Qt platform
https://bugs.webkit.org/show_bug.cgi?id=23291

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): Added the ability to draw shadows for all these curves.

2009-09-09 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] -webkit-box-shadow CSS Style is not rendered correctly on
Qt platform
https://bugs.webkit.org/show_bug.cgi?id=23291

platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
platform/qt/fast/box-shadow/basic-shadows-expected.png:
platform/qt/fast/box-shadow/inset-expected.checksum:
platform/qt/fast/box-shadow/inset-expected.png:
platform/qt/fast/box-shadow/spread-expected.checksum:
platform/qt/fast/box-shadow/spread-expected.png: Updated to show the new shadows.

1:15 PM Changeset in webkit [48219] by kenneth@webkit.org

8 edits
5 adds in trunk

.: [Qt] Add the alternative QtLauncher (based on QGraphicsView) to the build.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-09
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=28862

WebKit.pro:

WebCore: Add the qwebgraphicsitem.cpp to the build system.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-09
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=28862

WebCore.pro:

WebKit/qt: Add a new QGraphicsWidget based version of the "QWebView"
under the name "QWebGraphicsItem".

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org>, Antonio Gomes <antonio.gomes@openbossa.org> on 2009-09-09
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=28862

Includes an alternative Qt launcher using the QGraphicsView.

Api/headers.pri:
Api/qwebgraphicsitem.cpp: Added.
Api/qwebgraphicsitem.h: Added.
Api/qwebpage.h:
QGVLauncher/QGVLauncher.pro: Copied from WebKit/qt/QtLauncher/QtLauncher.pro.
QGVLauncher/main.cpp: Added.
WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::repaint):
(WebCore::ChromeClientQt::scroll):

11:41 AM Changeset in webkit [48218] by dbates@webkit.org

2 edits in trunk/WebKitTools

2009-09-09 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=28953

Added pre- and post- build events so that on build failure, the file
buildfailed is written to the directory $(WebKitOutputDir).

WinLauncher/WinLauncher.vcproj:

11:09 AM Changeset in webkit [48217] by Laszlo Gombos

2 edits in trunk/JavaScriptCore

2009-09-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Change reinterpret_cast to static_cast in r48212.

jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):

10:56 AM Changeset in webkit [48216] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-09-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Remove WTF_PLATFORM_FORCE_PACK as it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=29066

wtf/Platform.h:

10:42 AM Changeset in webkit [48215] by kenneth@webkit.org

2 edits in trunk/WebKitTools

Unreviewed.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-09
Add myself to list of committers.

Scripts/modules/committers.py:

10:36 AM Changeset in webkit [48214] by eric@webkit.org

6 edits in trunk/WebKitTools

2009-09-08 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

commit-queue gets stuck if a non-committer sets commit-queue+ or review+
https://bugs.webkit.org/show_bug.cgi?id=28605
https://bugs.webkit.org/show_bug.cgi?id=28916

Scripts/bugzilla-tool:
- Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit" comment now that it's used for rejecting patches for invalid committers too.
- Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
- Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
Scripts/modules/bugzilla.py:
- Make _parse_attachment_element not validate reviewer/committer.
- Share flag parsing code in _parse_attachment_flag.
- Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
- Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
- Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
Scripts/modules/bugzilla_unittest.py:
- Update this test to no longer expect committer/reviewer validation.
Scripts/modules/committers.py:
- Return None on failed lookups instead of raising Exceptions.
Scripts/modules/committers_unittest.py:
- Update tests to expect None returns instead of exceptions.

10:35 AM Changeset in webkit [48213] by kevino@webkit.org

7 edits
8 adds in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx port] Move functions in TemporaryLinkStubs.cpp out to files where
they belong.

https://bugs.webkit.org/show_bug.cgi?id=29088

9:46 AM Changeset in webkit [48212] by Laszlo Gombos

2 edits in trunk/JavaScriptCore

2009-09-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Ariya Hidayat.

Implement flushing the instruction cache for Symbian
https://bugs.webkit.org/show_bug.cgi?id=29075

jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush): Call IMB_Range to flush the instruction cache on Symbian

9:44 AM Changeset in webkit [48211] by eric@webkit.org

3 edits in trunk/LayoutTests

2009-09-09 Erik Arvidsson <arv@chromium.org>

Reviewed by David Levin.

Fix preference name in layout test.
https://bugs.webkit.org/show_bug.cgi?id=29038

fast/events/click-focus-anchor.html:
fast/events/tab-focus-anchor.html:

9:27 AM Changeset in webkit [48210] by eric@webkit.org

8 edits
3 adds in trunk

2009-09-09 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Geolocation incorrectly calls error callback in case of exception in success callback.
https://bugs.webkit.org/show_bug.cgi?id=27255

fast/dom/Geolocation/resources/callback-exception.js: Added. Tests that when an exception is thrown from the success callback, the error callback is not invoked.
fast/dom/Geolocation/callback-exception.html: Added. Wrapper for above test.
fast/dom/Geolocation/callback-exception-expected.txt: Added. Expected result for above test.
platform/gtk/Skipped: Modified. Adds the above tests to the skipped list.

2009-09-09 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Geolocation incorrectly calls error callback in case of exception in success callback.
https://bugs.webkit.org/show_bug.cgi?id=27255

Test: fast/dom/Geolocation/callback-exception.html

bindings/js/JSCustomPositionCallback.cpp: Modified. (WebCore::JSCustomPositionCallback::handleEvent): Modified. Removed raisedException out param.
bindings/js/JSCustomPositionCallback.h: Modified. Removed raisedException out param from handleEvent method and made handleEvent private.
bindings/js/JSCustomPositionErrorCallback.h: Modified. Made handleEvent private.
page/Geolocation.cpp: Modified. (WebCore::Geolocation::sendPosition): Modified. No longer call error callback in case of exception in success callback.
page/PositionCallback.h: Modified. Removed raisedException out param from handleEvent method.

8:59 AM Changeset in webkit [48209] by benm@google.com

5 edits
6 adds in trunk

WebCore: When Geolocation permission is denied, stops watches as well as one-shots.
https://bugs.webkit.org/show_bug.cgi?id=28305.

Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Darin Adler.

Tests: fast/dom/Geolocation/watch.html

fast/dom/Geolocation/permission-denied-stops-watches.html

page/Geolocation.cpp: Modified.

(WebCore::Geolocation::setIsAllowed): Modified. Marks the permission error as fatal.
(WebCore::Geolocation::handleError): Modified. If the error is fatal, stops watchers as well as one-shots.

page/PositionError.h: Modified.

(WebCore::PositionError::setIsFatal): Added. Marks an error as fatal.
(WebCore::PositionError::isFatal): Added. Determines whether an error is fatal.

LayoutTests: When Geolocation permission is denied, stops watches as well as one-shots.
https://bugs.webkit.org/show_bug.cgi?id=28305.

Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Darin Adler.

fast/dom/Geolocation/resources/watch.js: Added. Tests that a watch correctly reports updates from the Geolocation service.
fast/dom/Geolocation/watch.html: Added. Wrapper for above test.
fast/dom/Geolocation/watch-expected.txt: Added. Expected result for above test.
fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Added. Tests that when Geolocation permission is denied, watches are stopped, as well as one-shots.
fast/dom/Geolocation/permission-denied-stops-watches.html: Added. Wrapper for above test.
fast/dom/Geolocation/permission-denied-stops-watches-expected.txt: Added. Expected result for above test.

8:15 AM Changeset in webkit [48208] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-09 Roland Steiner <rolandsteiner@google.com>

Reviewed by Eric Seidel.

Bug 28964 - [Chromium] ChromiumDataObject should have getter/setter interface

Added getter/setter methods and trivial inline implementations for each.
(Note that they are not yet actually used.)
Once the Chromium code is changed to use them instead of directly accessing the
member variables, the member variables should be made private and cleaned up.

No new tests (no functional behavior changed).

platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::mainURL): (WebCore::ChromiumDataObject::setMainURL): (WebCore::ChromiumDataObject::mainURLTitle): (WebCore::ChromiumDataObject::setMainURLTitle): (WebCore::ChromiumDataObject::textPlain): (WebCore::ChromiumDataObject::setTextPlain): (WebCore::ChromiumDataObject::textHTML): (WebCore::ChromiumDataObject::setTextHTML): (WebCore::ChromiumDataObject::htmlBaseURL): (WebCore::ChromiumDataObject::setHTMLBaseURL): (WebCore::ChromiumDataObject::content): (WebCore::ChromiumDataObject::releaseContent): (WebCore::ChromiumDataObject::setContent): (WebCore::ChromiumDataObject::contentFileExtension): (WebCore::ChromiumDataObject::setContentFileExtension): (WebCore::ChromiumDataObject::contentFileName): (WebCore::ChromiumDataObject::setContentFileName): (WebCore::ChromiumDataObject::fileNames): (WebCore::ChromiumDataObject::setFileNames): (WebCore::ChromiumDataObject::takeFileNames):

7:56 AM Changeset in webkit [48207] by Simon Hausmann

4 edits
1 move in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=29024
Make JavaScriptCore compile on platforms with case-insensitive file systems and typeinfo.h in STL

Patch by Kent Hansen <khansen@trolltech.com> on 2009-09-09
Reviewed by Darin Adler.

These platforms include Microsoft Visual Studio 2003, and Symbian with Metrowerks compiler.

JavaScriptCore.gypi:
JavaScriptCore.xcodeproj/project.pbxproj:
runtime/JSTypeInfo.h: Copied from JavaScriptCore/runtime/TypeInfo.h.
runtime/Structure.h:
runtime/TypeInfo.h: Removed.

7:49 AM Changeset in webkit [48206] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()

Reviewed by Mark Rowe.

No change to layout test results.

DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::clickPointY): Changed to return y value instead of x value.

6:26 AM Changeset in webkit [48205] by yael.aharon@nokia.com

2 edits in trunk

[Qt] locale date displays incorrect date format in symbian.
https://bugs.webkit.org/show_bug.cgi?id=29032

Patch by Pat Bradley <vincent.bradley@nokia.com> on 2009-09-08
Reviewed by Ariya Hidayat.

strftime() in Symbian does not support #
Layout tests cannot be run on Symbian yet, so they are not updated.

runtime/DatePrototype.cpp:

2:53 AM Changeset in webkit [48204] by Simon Hausmann

2 edits in trunk/WebCore

NPAPI Plugin NPP_AsFile not working on Qt Webkit
https://bugs.webkit.org/show_bug.cgi?id=29068

Patch by Rohini Ananth <rohini.ananth@nokia.com> on 2009-09-09
Reviewed by Simon Hausmann.

platform/qt/FileSystemQt.cpp:

(WebCore::openTemporaryFile)
Autoremove property of QTemporaryFile has been set to false. Hence closeFile() just closes and does not delete the file.
This solves the deletion of created temp file in PluginStream::destroyStream() before passing to plugin in NPP_AsFile.

12:13 AM Changeset in webkit [48203] by bfulgham@webkit.org

2 edits in trunk/WebKitLibraries

Adjust WinCairo-specific property sheet to use static versions of
libjpeg.lib and libpng.lib. Change to libpng.lib required addition
of zlib.lib to link.

Reviewed by Dave Levin.

win/tools/vsprops/WinCairo.vsprops:

12:02 AM Changeset in webkit [48202] by oliver@apple.com

5 edits in trunk

JSON.stringify(Date) loses the milliseconds information
https://bugs.webkit.org/show_bug.cgi?id=29063

Reviewed by Maciej Stachowiak.

Make sure we include milliseconds in the output of toISOString.

Sep 8, 2009:

10:55 PM Changeset in webkit [48201] by oliver@apple.com

2 edits in trunk/WebCore

Reviewed by NOBODY (Build fix).

Remove a few incorrect changes I left in.

9:32 PM Changeset in webkit [48200] by oliver@apple.com

24 edits in trunk/WebCore

Support numeric index getters in bindings
https://bugs.webkit.org/show_bug.cgi?id=29067

Reviewed by Sam Weinig.

Add HasNumericIndexGetter to indicate a non-custom getter that
returns a number. The numeric index getter also uses PropertySlot's
setValue rather than setCustomIndex to avoid an additional indirect
call.

8:03 PM Changeset in webkit [48199] by Dimitri Glazkov

2 edits in trunk/WebKitTools

2009-09-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Mark Rowe.

Reduce dglazkov's boboiness by properly concatenating revision value.

BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution

rather than "+".

7:25 PM Changeset in webkit [48198] by kevino@webkit.org

2 edits in trunk/WebKitTools

wxWebKit Python extension build fix - get swig.py if it doesn't exist.

7:20 PM Changeset in webkit [48197] by kevino@webkit.org

2 edits in trunk/WebCore

wx build fix for 2.8.

6:45 PM Changeset in webkit [48196] by atwilson@chromium.org

2 edits in trunk/LayoutTests

shared-worker-exception.html needs to pause to let console messages get written out
https://bugs.webkit.org/show_bug.cgi?id=29043

Reviewed by Maciej Stachowiak.

fast/workers/resources/shared-worker-exception.js:

(worker.onmessage):
Now invokes layoutTestController.notifyDone() via a timer so any pending ReportException tasks get a chance to fire.

5:29 PM Changeset in webkit [48195] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-08 Jens Alfke <snej@chromium.org>

Reviewed by Eric Seidel.

In Mac Chromium, clicking below the last line of an editable area (textarea or
contenteditable) should put the caret at the end of the last line, as in Mac Safari.

Tests: LayoutTests/editing/selection/click-in-margins-inside-editable-div.html

LayoutTests/editing/selection/click-in-padding-with-multiple-line-boxes.html

page/Settings.cpp: (WebCore::Settings::Settings): Change #if PLATFORM_MAC to be Mac-Chrome-inclusive.

5:01 PM Changeset in webkit [48194] by mrowe@apple.com

2 edits in trunk/WebKitTools

Fix an incorrect variable name in UpdateChromiumSource.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

3:51 PM Changeset in webkit [48193] by mrowe@apple.com

2 edits in trunk/WebKitTools

Don't check for leaks on the release SnowLeopard builder.

BuildSlaveSupport/build.webkit.org-config/config.json:

3:39 PM Changeset in webkit [48192] by mrowe@apple.com

2 edits in trunk/WebKitTools

Add a SnowLeopard release builder.

BuildSlaveSupport/build.webkit.org-config/config.json:

3:17 PM Changeset in webkit [48191] by hyatt@apple.com

2 edits in trunk/WebCore

Make sure not to do an early return when a data URL stylesheet successfully loads. We need to still
clear the old cached sheet out of all existing Frames. Fixes the data URL stylesheet layout test failure.

Reviewed by Mark Rowe.

page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):

3:14 PM Changeset in webkit [48190] by weinig@apple.com

2 edits in trunk/WebCore

Fix windows build.

dom/Document.idl:

3:11 PM Changeset in webkit [48189] by kevino@webkit.org

2 edits in trunk/WebCore

More robust wx build fix for 2.9.

3:02 PM Changeset in webkit [48188] by weinig@apple.com

6 edits
5 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=27046
Implement CSSOM DocumentView.caretRangeFromPoint

Reviewed by Timothy Hatcher.

Tests: fast/dom/Document/CaretRangeFromPoint/basic.html

fast/dom/Document/CaretRangeFromPoint/replace-element.html

dom/Document.cpp:

(WebCore::Document::caretRangeFromPoint):

dom/Document.h:
dom/Document.idl:

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=27046
Implement CSSOM DocumentView.caretRangeFromPoint

Reviewed by Timothy Hatcher.

fast/dom/Document/CaretRangeFromPoint: Added.
fast/dom/Document/CaretRangeFromPoint/basic-expected.txt: Added.
fast/dom/Document/CaretRangeFromPoint/basic.html: Added.
fast/dom/Document/CaretRangeFromPoint/replace-element-expected.txt: Added.
fast/dom/Document/CaretRangeFromPoint/replace-element.html: Added.
fast/dom/Window/window-properties-expected.txt:

2:46 PM Changeset in webkit [48187] by levin@chromium.org

2 edits in trunk/WebKitTools

Remove end of line whitespace check from check-webkit-style.
https://bugs.webkit.org/show_bug.cgi?id=29053

Patch by David Levin <levin@chromium.org> on 2009-09-08
Reviewed by Darin Adler.

Scripts/modules/cpp_style.py:

2:32 PM Changeset in webkit [48186] by kevino@webkit.org

4 edits in trunk

wx build fix, generate derived sources earlier in order to make sure
they're found by the build system when generating the list of sources to build.

2:11 PM Changeset in webkit [48185] by Nate Chapin

2 edits in trunk/WebCore

2009-09-08 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

<iterator> include in V8Proxy.h is spurious and causing ObjC compile issues for Chromium.

Test: Chromium mac canary build is fixed.

2:05 PM Changeset in webkit [48184] by bweinstein@apple.com

3 edits in trunk/LayoutTests

2009-09-08 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Adam Roben.

Updated results for media/audio-controls-rendering.html, and added 3 failing
tests to the Skipped list to investigate further <http://webkit.org/b/29047>.

platform/win/Skipped:
platform/win/media/audio-controls-rendering-expected.txt:

2:01 PM Changeset in webkit [48183] by kov@webkit.org

3 edits in trunk/WebKit/gtk

2009-09-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=29044
[GTK] Should update suggested-filename when the response is received

Set suggested filename also when the response only comes after the
download has started.

webkit/webkitdownload.cpp: (webkit_download_set_response): (webkit_download_set_suggested_filename):
webkit/webkitwebview.cpp: (webkit_web_view_request_download):

1:34 PM Changeset in webkit [48182] by xan@webkit.org

2 edits in trunk/WebCore

2009-09-08 Xan Lopez <xlopez@igalia.com>

Unreviewed attempt to fix the GTK+ build.

GNUmakefile.am:

1:26 PM Changeset in webkit [48181] by hyatt@apple.com

9 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28987, make the Document cache the page's user stylesheet in
parsed form. Allows the sheet to survive across destruction/re-creation of the CSSStyleSelector.

Reviewed by Eric Seidel.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):

css/CSSStyleSelector.h:
dom/Document.cpp:

(WebCore::Document::attach):
(WebCore::Document::pageUserSheet):
(WebCore::Document::clearPageUserSheet):
(WebCore::Document::recalcStyleSelector):

dom/Document.h:
loader/PlaceholderDocument.cpp:

(WebCore::PlaceholderDocument::attach):

page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):

page/Settings.cpp:

(WebCore::Settings::setUserStyleSheetLocation):

1:23 PM Changeset in webkit [48180] by kenneth@webkit.org

2 edits in trunk/WebCore

Unreviewed buildfix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Fix Qt build after 48167, by adding the new cpp/h files
added to WebCore.gypi to WebCore.pro as well.

WebCore.pro:

1:11 PM Changeset in webkit [48179] by kenneth@webkit.org

2 edits in trunk/WebKit/qt

Unreviewed build fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Potential build fix for Qt 4.5

Api/qwebpage.cpp:

(QWebPagePrivate::mousePressEvent):

1:06 PM Changeset in webkit [48178] by xan@webkit.org

2 edits in trunk/WebCore

2009-09-08 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

should not pass URI fragments to libsoup
https://bugs.webkit.org/show_bug.cgi?id=28687

Strip the fragment from the URI before passing it to soup, since
it forwards it to servers in some cases (like when using a proxy)
which confuses them and makes them return 403/404.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp): (WebCore::):

12:40 PM Changeset in webkit [48177] by kenneth@webkit.org

8 edits in trunk

WebCore: Add QGraphicsScene events support to the Qt platform events.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.

platform/PlatformMouseEvent.h:
platform/PlatformWheelEvent.h:
platform/qt/PlatformMouseEventQt.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

platform/qt/WheelEventQt.cpp:

(WebCore::PlatformWheelEvent::applyDelta):
(WebCore::PlatformWheelEvent::PlatformWheelEvent):

WebKit/qt: Add support for handling QGraphicsScene events.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.

Api/qwebpage.cpp:

(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseTripleClickEvent):
(QWebPagePrivate::handleClipboard):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::wheelEvent):
(QWebPagePrivate::dragEnterEvent):
(QWebPagePrivate::dragLeaveEvent):
(QWebPagePrivate::dragMoveEvent):
(QWebPagePrivate::dropEvent):
(QWebPage::event):

Api/qwebpage_p.h:

12:40 PM Changeset in webkit [48176] by weinig@apple.com

2 edits in trunk/WebKitSite

Update Security Group Members list.

Reviewed by Adele Peterson.

security/security-group-members.html:

12:28 PM Changeset in webkit [48175] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-08 Michael Nordman <Michael Nordman>

Reviewed by Eric Seidel.

[Chromium] Cleanup: remove a few deprecated methods.
https://bugs.webkit.org/show_bug.cgi?id=28960

No new tests, just syntactic sugar.

platform/network/chromium/ResourceRequest.h:
platform/network/chromium/ResourceResponse.h:

12:21 PM Changeset in webkit [48174] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-08 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Ariya Hidayat.

https://bugs.webkit.org/show_bug.cgi?id=28981

[Qt] make npapi.h compile in winscw compiler.

Add XP_SYMBIAN macro to identify Symbian OS; this macro should be used for Symbian
specific changes in npapi.h.
Undefine XP_WIN when building for Symbian to avoid including Windows specific code.

bridge/npapi.h:

12:06 PM Changeset in webkit [48173] by kov@webkit.org

6 edits in trunk/WebKit/gtk

2009-09-08 Priit Laes <plaes@plaes.org>

Reviewed by Gustavo Noronha.

Fix up erroneus 'Since: @version@' tags in documentation.

webkit/webkitwebdatasource.cpp:
webkit/webkitwebresource.cpp: (webkit_web_resource_class_init):
webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
webkit/webkitwebview.cpp: (webkit_web_view_class_init):
webkit/webkitwebwindowfeatures.cpp:

12:02 PM Changeset in webkit [48172] by oliver@apple.com

2 edits in trunk/WebCore

Web Inspector assertion failure related to marking
https://bugs.webkit.org/show_bug.cgi?id=28997

Reviewed by Geoff Garen.

When wrapping the callback the JSInspectorCallbackWrapper creator was using
inheritorID for the prototype structure which is unsafe for anything other
than a pure JS object. Instead we now create a new structure, which while
inefficient is not problematic as this code is not hit frequently.

11:34 AM Changeset in webkit [48171] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-09-08 Kelly Norton <knorton@google.com>

Reviewed by Dimitri Glazkov.

Add missing extension to the file entry in WebCore.vcproj.

WebCore.vcproj/WebCore.vcproj: Added "cpp".

11:02 AM Changeset in webkit [48170] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-09-08 Cameron McCormack <cam@mcc.id.au>

Reviewed by Darin Adler.

Fix DumpRenderTree build from clean tree on Tiger
https://bugs.webkit.org/show_bug.cgi?id=28927

DumpRenderTree/mac/PerlSupport/Makefile: Ensure the DerivedSources/DumpRenderTree directory exists when building on Tiger.

11:02 AM Changeset in webkit [48169] by jianli@chromium.org

5 edits in trunk

WebCore: dataTransfer.types() should not return Files if file list is empty in the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=28891

Reviewed by David Levin.

We change the behavior to handle the empty file list in order to match the spec.

Tested by clipboard-file-access.html.

platform/mac/ClipboardMac.mm:

(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):

LayoutTests: dataTransfer.types() should not return Files if file list is empty in the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=28891

Reviewed by David Levin.

Update the test script and expected result to reflect the behavior change.

http/tests/security/clipboard/clipboard-file-access-expected.txt:
http/tests/security/clipboard/resources/clipboard-file-access.js:

10:58 AM Changeset in webkit [48168] by Nate Chapin

7 edits
3 adds in trunk

2009-09-08 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by Eric Seidel.

Handle middle click in Chromium like QT
https://bugs.webkit.org/show_bug.cgi?id=28696

Tested by middle-click-onpaste.html.

10:55 AM Changeset in webkit [48167] by eric@webkit.org

20 edits
7 adds in trunk/WebCore

2009-09-08 Kelly Norton <knorton@google.com>

Reviewed by Eric Seidel.

WebInspector: Adds a timeline agent to InspectorController that collects
high-level timing data about event dispatch, layout, painting and HTML
parsing and makes it available to Inspector.
https://bugs.webkit.org/show_bug.cgi?id=25503

WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp: (WebCore::Document::recalcStyle):
dom/Document.h: (WebCore::Document::inspectorTimelineAgent):
dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
inspector/DOMDispatchTimelineItem.cpp: Added. (WebCore::DOMDispatchTimelineItem::DOMDispatchTimelineItem): (WebCore::DOMDispatchTimelineItem::convertToScriptObject):
inspector/DOMDispatchTimelineItem.h: Added. (WebCore::DOMDispatchTimelineItem::~DOMDispatchTimelineItem):
inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::enableTimeline): (WebCore::InspectorBackend::disableTimeline): (WebCore::InspectorBackend::timelineEnabled):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::enableTimeline): (WebCore::InspectorController::disableTimeline): (WebCore::InspectorController::timelineEnabled):
inspector/InspectorController.h: (WebCore::InspectorController::timelineAgent):
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::timelineWasEnabled): (WebCore::InspectorFrontend::timelineWasDisabled): (WebCore::InspectorFrontend::addItemToTimeline):
inspector/InspectorFrontend.h:
inspector/InspectorTimelineAgent.cpp: Added. (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::currentTimeInMilliseconds): (WebCore::InspectorTimelineAgent::sessionTimeInMilliseconds):
inspector/InspectorTimelineAgent.h: Added.
inspector/TimelineItem.cpp: Added. (WebCore::TimelineItem::TimelineItem): (WebCore::TimelineItem::addToTimeline): (WebCore::TimelineItem::convertToScriptObject): (WebCore::TimelineItem::convertChildrenToScriptArray): (WebCore::TimelineItem::addChildItem):
inspector/TimelineItem.h: Added. (WebCore::): (WebCore::TimelineItem::~TimelineItem): (WebCore::TimelineItem::previous): (WebCore::TimelineItem::releasePrevious): (WebCore::TimelineItem::setEndTime): (WebCore::TimelineItem::type):
inspector/front-end/TimelineAgent.js: Added. (WebInspector.TimelineAgent): (WebInspector.addItemToTimeline): (WebInspector.timelineWasEnabled): (WebInspector.timelineWasDisabled):
inspector/front-end/inspector.html:
page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::paintContents):
page/FrameView.h: (WebCore::FrameView::inspectorTimelineAgent):
page/Page.cpp: (WebCore::Page::inspectorTimelineAgent):
page/Page.h:

10:44 AM Changeset in webkit [48166] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-09-08 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29007
Add a test for the signal QWebFrame::javaScriptWindowObjectCleared()

tests/qwebframe/tst_qwebframe.cpp:

10:37 AM Changeset in webkit [48165] by eric@webkit.org

7 edits in trunk

2009-09-08 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Fix unused variable warnings
https://bugs.webkit.org/show_bug.cgi?id=29018

No functional change, no tests.

history/qt/HistoryItemQt.cpp: (WebCore::HistoryItem::restoreState):
platform/graphics/qt/ImageBufferQt.cpp: (WebCore::putImageData):
platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintMenuList):

2009-09-08 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Fix unused variable warnings
https://bugs.webkit.org/show_bug.cgi?id=29018

Api/qwebpage.cpp: (QWebPagePrivate::keyPressEvent):
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::startDownload): (WebCore::FrameLoaderClientQt::createFrame):

10:30 AM Changeset in webkit [48164] by eric@webkit.org

5 edits in trunk

2009-09-08 Laszlo Gombos <Laszlo Gombos>

Reviewed by Ariya Hidayat.

[Qt] Use the declaration order in initializer lists
https://bugs.webkit.org/show_bug.cgi?id=29017

No functional change, no new tests.

platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):

2009-09-08 Laszlo Gombos <Laszlo Gombos>

Reviewed by Ariya Hidayat.

[Qt] Use the declaration order in initializer lists
https://bugs.webkit.org/show_bug.cgi?id=29017

Api/qwebframe_p.h:

10:23 AM Changeset in webkit [48163] by eric@webkit.org

5 edits
3 adds in trunk

2009-09-08 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Tests for ValidityState::typeMismatch() for <input type=number>.
https://bugs.webkit.org/show_bug.cgi?id=28934

fast/forms/ValidityState-typeMismatch-number-expected.txt: Added.
fast/forms/ValidityState-typeMismatch-number.html: Added.
fast/forms/resources/ValidityState-typeMismatch-number.js: Added.

2009-09-08 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Implement ValidityState::typeMismatch() for <input type=number>.
https://bugs.webkit.org/show_bug.cgi?id=28934

Test: fast/forms/ValidityState-typeMismatch-number.html

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::formStringToDouble):
html/HTMLInputElement.h:
html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
html/ValidityState.h:

10:19 AM Changeset in webkit [48162] by kevino@webkit.org

2 edits in trunk/WebKitTools

wx build fix after introduction of platform/mock directory.

10:15 AM Changeset in webkit [48161] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-09-08 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

Build fix when USE(LOCKFREE_THREADSAFESHARED) is not defined
https://bugs.webkit.org/show_bug.cgi?id=29011

wtf/Threading.h: Use LOCKFREE_THREADSAFESHARED guard for atomicIncrement and atomicDecrement

9:39 AM Changeset in webkit [48160] by yael.aharon@nokia.com

2 edits in trunk/WebKitTools

Unreviewed.

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-08
Add myself to list of committers.

Scripts/modules/committers.py:

9:08 AM Changeset in webkit [48159] by Laszlo Gombos

2 edits in trunk/WebKitTools

2009-09-08 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

Add myself to list of committers.

Scripts/modules/committers.py:

8:51 AM Changeset in webkit [48158] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-09-08 Cameron McCormack <cam@mcc.id.au>

Reviewed by Darin Adler.

prepare-ChangeLog too chatty on file additions
https://bugs.webkit.org/show_bug.cgi?id=29019

Scripts/prepare-ChangeLog: Omit description of added properties on newly added files.

8:49 AM Changeset in webkit [48157] by kov@webkit.org

2 edits in trunk/WebCore

2009-09-08 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Gustavo Noronha.

[Gtk] Another attempt of a buildfix.

GNUmakefile.am: Modified. Remove some extra IDL files added in r48153.

8:43 AM Changeset in webkit [48156] by eric@webkit.org

6 edits
6 adds in trunk

2009-09-08 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Adds a LayoutTestController method to set the permission state for Geolocation.
This is required to use the mock Geolocation service for testing.
https://bugs.webkit.org/show_bug.cgi?id=29027

fast/dom/Geolocation/resources/permission-denied.js: Added. Tests that the error callback is invoked with a permission error code when Geolocation permission is denied and the Geolocation service provides a good position fix.
fast/dom/Geolocation/permission-denied-expected.txt: Added. Expected result for above test.
fast/dom/Geolocation/permission-denied.html: Added. Wrapper for above test.
fast/dom/Geolocation/resources/success.js: Added. Tests that the success callback is invoked when the Geolocation service provides a good position fix.
fast/dom/Geolocation/success-expected.txt: Added. Expected result for above test.
fast/dom/Geolocation/success.html: Added. Wrapper for above test.
platform/gtk/Skipped:

2009-09-08 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Adds a LayoutTestController method to set the permission state for Geolocation.
This is required to use the mock Geolocation service for testing.
https://bugs.webkit.org/show_bug.cgi?id=29027

DumpRenderTree/LayoutTestController.cpp: Modified. (setDatabaseQuotaCallback): Modified. Style fix. (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state. (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
DumpRenderTree/LayoutTestController.h: Modified. (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state. (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set. (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
DumpRenderTree/mac/UIDelegate.mm: Modified. (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.

8:17 AM WebKit Team edited by oszi@inf.u-szeged.hu

(diff)

8:00 AM Changeset in webkit [48155] by zoltan@webkit.org

2 edits in trunk/JavaScriptCore

2009-09-07 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control in Yarr's RegexInterpreter
https://bugs.webkit.org/show_bug.cgi?id=29025

Inherits RegexInterpreter classes from FastAllocBase (bug #20422), which has
been instantiated by 'new':

class ByteDisjunction
-> instantiated in JavaScriptCore/yarr/RegexInterpreter.cpp:1462

struct BytecodePattern
-> instantiated in JavaScriptCore/yarr/RegexInterpreter.cpp:1279

yarr/RegexInterpreter.h:

7:58 AM WebKit Team edited by oszi@inf.u-szeged.hu

(diff)

7:43 AM Changeset in webkit [48154] by Simon Hausmann

6 edits in trunk

WebCore: [Qt] Make cursor set cleaner in QtWebKit Api: eliminate SetCursorEvent hack.
https://bugs.webkit.org/show_bug.cgi?id=28865

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.

Save the QCursor as a property in WidgetQt::setCursor
and actually change the cursor in QWebView::event() by making use
of the QEvent::DynamicPropertyChange event type.
When unsetCursor() is called on the QWidget we can fallback to
the cursor set by WebCore.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> and

Antonio Gomes <antonio.gomes@openbossa.org> on 2009-09-07

platform/qt/WidgetQt.cpp:

(WebCore::Widget::setCursor):

WebKit/qt: [Qt] Make cursor set cleaner in QtWebKit Api: eliminate SetCursorEvent hack.
https://bugs.webkit.org/show_bug.cgi?id=28865

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.

Clean up the unserCursor hack to use the QCursor set
as a property of the QWidget by WebCore::WidgetQt.

Remove all code that are no longer necessary for getting
cursor change events.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> and

Antonio Gomes <antonio.gomes@openbossa.org> on 2009-09-07

Api/qwebpage.cpp:
Api/qwebpage_p.h:
Api/qwebview.cpp:

(QWebViewPrivate::QWebViewPrivate):
(QWebView::event):

7:34 AM Changeset in webkit [48153] by kov@webkit.org

2 edits in trunk/WebCore

2009-09-08 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Gustavo Noronha.

[Gtk] Buildfix for build error introduced in r48150.

GNUmakefile.am: Modified. Added missing IDL files.

7:05 AM Changeset in webkit [48152] by vestbo@webkit.org

2 edits in trunk/WebCore

[Qt] Buildfix. Build error caused by r48150.

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-08
Reviewed by Tor Arne Vestbø.

WebCore.pro: missing IDL files added

6:44 AM QtWebKitContrib edited by vestbo@webkit.org

(diff)

6:31 AM QtWebKitContrib edited by vestbo@webkit.org

(diff)

6:27 AM Changeset in webkit [48151] by Laszlo Gombos

8 edits in trunk

2009-09-08 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] QtWebKit single API to enable persistency
https://bugs.webkit.org/show_bug.cgi?id=28682

Disable LocalStorage, ApplicationCache, HTML5 offline storage by
default.

If persistency is enabled the default directory for LocalStorage and
ApplicationCache is now based on QDesktopServices::DataLocation and not
QDesktopServices::CacheLocation (as it is expected to keep this data
around after a reboot).

If persistency is enabled initialize HTML5 offline storage as well - this
fixed offline Storage for QtLauncher.

6:01 AM Changeset in webkit [48150] by cmarrin@apple.com

17 edits
48 adds in trunk/WebCore

Update Canvas 3D implementation to match spec
https://bugs.webkit.org/show_bug.cgi?id=29010

This adds several new CanvasXXXArray classes each of which has a custom constructor
and custom getters and setters. Also changed CanvasRenderingContext3D and GraphicsContext3D
to match the new and changed API.

5:35 AM Changeset in webkit [48149] by vestbo@webkit.org

1 edit
2 adds in trunk/LayoutTests

[Qt] Add expected files for new tests since we pass them.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-08
Reviewed by Tor Arne Vestbø.

platform/qt/fast/reflections/abs-position-in-reflection-expected.txt: Added.
platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.txt: Added.

5:27 AM Changeset in webkit [48148] by vestbo@webkit.org

2 edits in trunk/WebKitTools

Refactor --strict switch to --ignore-metrics and correct the
implementation to make the feature usable on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=28907

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-07
Reviewed by Tor Arne Vestbø.

run-webkit-tests --ignore-metrics strips the font related metrics from
the actual and expected data before comparing them.
In this way the render trees can be checked for obvious differences but
a successful test implies by no means that the layout is actually correct.

Scripts/run-webkit-tests:

2:51 AM Changeset in webkit [48147] by hamaji@chromium.org

1 edit in trunk/WebKitTools/Scripts/modules/committers.py

Unreviewed.

Change my mail address on the list of committers.

12:45 AM Changeset in webkit [48146] by Simon Hausmann

2 edits in trunk/WebCore

Make m_windowVisible more consistent with the actual visibility of the inspector.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-08
Reviewed by Timothy Hatcher.

inspector/InspectorController.cpp:

(WebCore::InspectorController::setWindowVisible):

Sep 7, 2009:

11:22 PM Changeset in webkit [48145] by abarth@webkit.org

2 edits in trunk/WebCore

2009-09-07 Adam Barth <abarth@webkit.org>

Unreviewed speculative build fix for Snow Leopard.

platform/GeolocationService.cpp: (WebCore::createGeolocationServiceNull):

11:13 PM Changeset in webkit [48144] by abarth@webkit.org

30 edits
2 copies
6 adds in trunk

2009-09-07 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264

fast/dom/Geolocation/resources/error.js: Added. Tests that the error callback is called when the service reports an error.
fast/dom/Geolocation/error-expected.txt: Added. Expected result for above test.
fast/dom/Geolocation/error.html: Added. Wrapper for above test.

2009-09-07 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264

The mock Geolocation service returns a fixed position or error. This position or error can be
set through static methods on the GeolocationService class. The position or error is shared
between all instances of the mock Geolocation service.

Implementation details.
The GeolocationService object maintains a pointer to a factory function which it uses to create
Geolocation service instances. Each platform implementing Geolocation sets this pointer
to the factory function for their platform's implementation. When the mock Geolocation service
is activated, the factory function pointer is reset to the factory function for the mock service.

Test: fast/dom/Geolocation/error.html

WebCore.base.exp: Modified. Exports GeolocationServiceMock methods.
GNUMakefile.am: Modified. Added GeolocationServiceMock files.
WebCore.gypi: Modified. Added GeolocationServiceMock files.
WebCore.pro: Modified. Added GeolocationServiceMock files.
WebCore.vcproj/WebCore.vcproj: Modified. Added GeolocationServiceMock files.
WebCore.vcproj/WebCoreCommon.vsprops: Modified. Added mock directory to includes.
WebCore.xcodeproj/project.pbxproj: Modified. Added GeolocationServiceMock files and exports some headers.
WebCoreSources.bkl: Modified. Added GeolocationServiceMock files.
page/ChromeClient.h: Modified. Fixed comment.
page/Geolocation.cpp: Modified. (WebCore::Geolocation::setIsAllowed): Modified. Fixed error string.
platform/GeolocationService.cpp: Modified. (WebCore::createGeolocationServiceNull): Added. Returns null in place of a Geolocation service. Used to avoid link errors on platforms where Geolocation is not implemented. (WebCore::GeolocationService::create): Added. Uses the factory function pointer to create a Geolocation service implementation. (WebCore::GeolocationService::useMock): Added. Configures the GeolocationServie to use the mock implementation.
platform/GeolocationService.h: Modified.
platform/mock: Added.
platform/mock/GeolocationServiceMock.cpp: Added. (WebCore::GeolocationServiceMock::create): Added. Creates a GeolocationServiceMock object. (WebCore::GeolocationServiceMock::GeolocationServiceMock): Added. Constructor. (WebCore::GeolocationServiceMock::~GeolocationServiceMock): Added. Destructor. (WebCore::GeolocationServiceMock::setPosition): Added. Sets the position that will be returned by the object. (WebCore::GeolocationServiceMock::setError): Added. Sets the error that will be returned by the object. (WebCore::GeolocationServiceMock::startUpdating): Added. GeolocationService implementation. Starts the service. (WebCore::GeolocationServiceMock::stopUpdating): Added. GeolocationService implementation. Stops the service. (WebCore::GeolocationServiceMock::timerFired): Added. Used to provide an asynchronous callback when the service is started. (WebCore::GeolocationServiceMock::makeGeolocationCallbackFromAllInstances): Added. Used to call back when the position or error is updated. (WebCore::GeolocationServiceMock::makeGeolocationCallback): Added. Used to call back when the service starts. (WebCore::GeolocationServiceMock::initStatics): Added. Initializes statics members with constructors. (WebCore::GeolocationServiceMock::cleanUpStatics): Added. Cleans up static members with constructors.
platform/mock/GeolocationServiceMock.h: Added. (WebCore::GeolocationServiceMock::lastPosition): Added. Returns the fixed position. (WebCore::GeolocationServiceMock::lastError): Added. Returns the fixed error.
platform/gtk/GeolocationServiceGtk.cpp: Modified. (WebCore::GeolocationServiceGtk::create): Added. Creates an instance of GeolocationServiceGtk.
platform/gtk/GeolocationServiceGtk.h: Modified.
platform/mac/GeolocationServiceMac.h: Modified.
platform/mac/GeolocationServiceMac.mm: Modified. (WebCore::GeolocationServiceMac::create): Added. Creates an instance of GeolocationServiceMac.

2009-09-07 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264

WebKit.xcodeproj/project.pbxproj: Modified. Adds WebGeolocationMock.

2009-09-07 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264

WebCoreSupport/WebGeolocationMockPrivate.h: Added.
WebCoreSupport/WebGeolocationMock.mm: Added. (+[WebGeolocationMock setError:code:]): Added. Used by DumpRender tree to configure the mock Geolocation service. (+[WebGeolocationMock setPosition:latitude:longitude:accuracy:]): Added. Used by DumpRender tree to configure the mock Geolocation service.
WebKit.exp: Modified. Exports WebGeolocationMock.

2009-09-07 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264

DumpRenderTree/LayoutTestController.cpp: Modified. (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service. (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service. (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
DumpRenderTree/LayoutTestController.h: Modified.
DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified. (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service. (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.

10:19 PM Changeset in webkit [48143] by jorlow@chromium.org

6 edits
2 adds in trunk/LayoutTests

2009-09-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Eric Seidel.

Clean up localStorage.clear() layout test.
https://bugs.webkit.org/show_bug.cgi?id=28939

This is the first step of https://bugs.webkit.org/show_bug.cgi?id=27897 which
is a pretty major cleanup of all the dom storage layout tests. I'm just
changing this one to begin with to get buy-in on the approach.

This also adds a new method to the fast/js/js-test-pre.js that runs a command
and prints it to the screen. This should really help with making the output of
the tests readable without looking at the source code.

fast/js/resources/js-test-pre.js: (tryAndLog): Runs a command and logs it to the screen.
storage/domstorage/localstorage/clear-expected.txt:
storage/domstorage/localstorage/clear.html:
storage/domstorage/resources: Added.
storage/domstorage/resources/clear.js: Added.

The meat of the test is now in this file.

storage/domstorage/sessionstorage/clear-expected.txt:
storage/domstorage/sessionstorage/clear.html:

6:25 PM Changeset in webkit [48142] by abarth@webkit.org

2 edits in trunk/WebCore

2009-09-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=28985

We need to be slightly more careful about how we pick up a script
execution context. In particular, we were getting the wrong document
for frames that had been navigated somewhere else.

In the long term, we should think about a better algorithm for
computing the script context.

Fixes LayoutTests/http/tests/xmlhttprequest/detaching-frame-2.html

bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::retrieveFrame):

5:32 PM Changeset in webkit [48141] by atwilson@chromium.org

4 edits in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

Rebaseline tests for GTK platform, and skipping shared worker XHR tests (worker XHR tests are already skipped).
Tracked as https://bugs.webkit.org/show_bug.cgi?id=29020.

platform/gtk/Skipped:
platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

5:08 PM Changeset in webkit [48140] by atwilson@chromium.org

2 edits in trunk/LayoutTests

Unreviewed test fixup.

Added shared worker lifecycle tests to Skipped test list due to missing DRT functionality on Qt platform.

platform/qt/Skipped:

4:55 PM Changeset in webkit [48139] by atwilson@chromium.org

1 edit
21 moves in trunk/LayoutTests

Enable shared worker tests.
https://bugs.webkit.org/show_bug.cgi?id=28977

Reviewed by David Levin.

Just moved tests from shared-worker-xxxx.html-disabled to shared-worker-xxxx.html. No other changes.

fast/workers/shared-worker-constructor.html: Renamed from LayoutTests/fast/workers/shared-worker-constructor.html-disabled.
fast/workers/shared-worker-context-gc.html: Renamed from LayoutTests/fast/workers/shared-worker-context-gc.html-disabled.
fast/workers/shared-worker-event-listener.html: Renamed from LayoutTests/fast/workers/shared-worker-event-listener.html-disabled.
fast/workers/shared-worker-exception.html: Renamed from LayoutTests/fast/workers/shared-worker-exception.html-disabled.
fast/workers/shared-worker-frame-lifecycle.html: Renamed from LayoutTests/fast/workers/shared-worker-frame-lifecycle.html-disabled.
fast/workers/shared-worker-gc.html: Renamed from LayoutTests/fast/workers/shared-worker-gc.html-disabled.
fast/workers/shared-worker-lifecycle.html: Renamed from LayoutTests/fast/workers/shared-worker-lifecycle.html-disabled.
fast/workers/shared-worker-load-error.html: Renamed from LayoutTests/fast/workers/shared-worker-load-error.html-disabled.
fast/workers/shared-worker-location.html: Renamed from LayoutTests/fast/workers/shared-worker-location.html-disabled.
fast/workers/shared-worker-navigator.html: Renamed from LayoutTests/fast/workers/shared-worker-navigator.html-disabled.
fast/workers/shared-worker-replace-global-constructor.html: Renamed from LayoutTests/fast/workers/shared-worker-replace-global-constructor.html-disabled.
fast/workers/shared-worker-replace-self.html: Renamed from LayoutTests/fast/workers/shared-worker-replace-self.html-disabled.
fast/workers/shared-worker-script-error.html: Renamed from LayoutTests/fast/workers/shared-worker-script-error.html-disabled.
fast/workers/shared-worker-shared.html: Renamed from LayoutTests/fast/workers/shared-worker-shared.html-disabled.
fast/workers/shared-worker-simple.html: Renamed from LayoutTests/fast/workers/shared-worker-simple.html-disabled.
http/tests/workers/shared-worker-importScripts.html: Renamed from LayoutTests/http/tests/workers/shared-worker-importScripts.html-disabled.
http/tests/workers/shared-worker-redirect.html: Renamed from LayoutTests/http/tests/workers/shared-worker-redirect.html-disabled.
http/tests/xmlhttprequest/workers/shared-worker-close.html: Renamed from LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-close.html-disabled.
http/tests/xmlhttprequest/workers/shared-worker-methods-async.html: Renamed from LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-methods-async.html-disabled.
http/tests/xmlhttprequest/workers/shared-worker-methods.html: Renamed from LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-methods.html-disabled.
http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html: Renamed from LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html-disabled.

4:05 PM Changeset in webkit [48138] by kevino@webkit.org

2 edits in trunk/WebCore

wx build fix for 2.8 compilation.

3:23 PM Changeset in webkit [48137] by atwilson@chromium.org

18 edits
5 deletes in trunk

JavaScriptCore: Reverting r48121 to fix Windows build errors.

JavaScriptCore.exp:

WebCore: Unreviewed build fix.

Reverting r48121 to fix Windows build errors.

DerivedSources.cpp:
GNUmakefile.am:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMWindowCustom.cpp:
bindings/js/JSEventTarget.cpp:

(WebCore::toJS):
(WebCore::toEventTarget):

dom/EventTarget.cpp:
dom/EventTarget.h:
page/DOMWindow.idl:
websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::bufferedAmount):
(WebCore::WebSocket::addEventListener):
(WebCore::WebSocket::removeEventListener):
(WebCore::WebSocket::dispatchEvent):
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didReceiveMessage):
(WebCore::WebSocket::didClose):
(WebCore::WebSocket::dispatchOpenEvent):
(WebCore::WebSocket::dispatchMessageEvent):
(WebCore::WebSocket::dispatchCloseEvent):

websockets/WebSocket.h:

(WebCore::WebSocket::create):
(WebCore::WebSocket::):
(WebCore::WebSocket::setOnopen):
(WebCore::WebSocket::onopen):
(WebCore::WebSocket::setOnmessage):
(WebCore::WebSocket::onmessage):
(WebCore::WebSocket::setOnclose):
(WebCore::WebSocket::onclose):
(WebCore::WebSocket::toWebSocket):
(WebCore::WebSocket::refEventTarget):
(WebCore::WebSocket::derefEventTarget):

websockets/WebSocketChannel.cpp: Removed.
websockets/WebSocketChannel.h: Removed.
websockets/WebSocketChannelClient.h: Removed.
websockets/WebSocketHandshake.cpp: Removed.
websockets/WebSocketHandshake.h: Removed.

LayoutTests: Unreviewed build fix.

Reverting r48121 to fix Windows build errors.

fast/dom/Window/window-properties-expected.txt:
fast/dom/prototype-inheritance-2-expected.txt:
fast/dom/prototype-inheritance-expected.txt:
fast/js/global-constructors-expected.txt:

2:29 PM Changeset in webkit [48136] by atwilson@chromium.org

2 edits in trunk/WebCore

Unreviewed speculative build fix.

Reverted previous build fix as it didn't fix the problem.

bindings/js/JSEventTarget.cpp:

(WebCore::toEventTarget):

2:20 PM Changeset in webkit [48135] by Laszlo Gombos

2 edits in trunk/WebCore

2009-09-07 Laszlo Gombos <Laszlo Gombos>

Unreviewed, build fix.

[Qt] Fix build after SHARED_WORKERS are enabled by default (r48131)

WebCore.pro:

1:50 PM Changeset in webkit [48134] by atwilson@chromium.org

2 edits in trunk/WebCore

Unreviewed build fix.

Temporarily removed depenency between JSEventTarget.cpp and WebSocket.h in an attempt to fix a windows build break.

bindings/js/JSEventTarget.cpp:

(WebCore::toEventTarget):

1:10 PM Changeset in webkit [48133] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Link new objects documents in the main document.

docs/webkitgtk-docs.sgml:

1:04 PM Changeset in webkit [48132] by kov@webkit.org

3 edits in trunk/WebKit/gtk

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Documentation control files updated for 1.1.14.

docs/webkitgtk-docs.sgml:
docs/webkitgtk-sections.txt:

12:53 PM Changeset in webkit [48131] by atwilson@chromium.org

27 edits in trunk

JavaScriptCore: Enable SHARED_WORKERS by default
https://bugs.webkit.org/show_bug.cgi?id=28959

Reviewed by David Levin.

Configurations/FeatureDefines.xcconfig:

WebCore: Enable SHARED_WORKERS by default.
https://bugs.webkit.org/show_bug.cgi?id=28959

Reviewed by David Levin.

Tests (enabled in a separate patch):

fast/workers/shared-worker-constructor.html
fast/workers/shared-worker-context-gc.html
fast/workers/shared-worker-event-listener.html
fast/workers/shared-worker-exception.html
fast/workers/shared-worker-frame-lifecycle.html
fast/workers/shared-worker-gc.html
fast/workers/shared-worker-lifecycle.html
fast/workers/shared-worker-load-error.html
fast/workers/shared-worker-location.html
fast/workers/shared-worker-navigator.html
fast/workers/shared-worker-replace-global-constructor.html
fast/workers/shared-worker-replace-self.html
fast/workers/shared-worker-shared.html
fast/workers/shared-worker-simple.html
http/tests/workers/shared-worker-importScripts.html
http/tests/workers/shared-worker-redirect.html
http/tests/xmlhttprequest/workers/shared-worker-close.html
http/tests/xmlhttprequest/workers/shared-worker-methods-async.html
http/tests/xmlhttprequest/workers/shared-worker-methods.html
http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html

config.h: Removed some whitespace/touched the file to force a full rebuild on the build-bots.
Configurations/FeatureDefines.xcconfig:
WebCore.pro:
WebCore.vcproj/WebCoreCommon.vsprops:
WebCore.vcproj/build-generated-files.sh:
dom/DOMWindow.idl: Removed unnecessary whitespace to force a rebuild on the build-bots to pickup the flag change.
workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::load):
Clean up bitrot in SharedWorker code - DenyCrossOriginRedirect is now DenyCrossOriginRequests.

workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::dispatchConnect):
Clean up bitrot - updated SharedWorker code to reflect new MessageEvent API.

WebKit/mac: Enable SHARED_WORKERS by default.
https://bugs.webkit.org/show_bug.cgi?id=28959

Reviewed by David Levin.

Configurations/FeatureDefines.xcconfig:

WebKit/win: Enable SHARED_WORKERS by default.
https://bugs.webkit.org/show_bug.cgi?id=28959

Reviewed by David Levin.

WebKit.vcproj/WebKit.vcproj:

WebKitTools: Enable SHARED_WORKERS by default
https://bugs.webkit.org/show_bug.cgi?id=28959

Reviewed by David Levin.

Scripts/build-webkit:

LayoutTests: Enable SHARED_WORKERS by default
https://bugs.webkit.org/show_bug.cgi?id=28959

Reviewed by David Levin.

Update test expectations to reflect the availability of the SharedWorker constructor.
Fixup bitrot in disabled tests - now reflects new MessagePort API.

fast/dom/Window/window-properties-expected.txt:

Updated expectations now that window.SharedWorkers is defined.

fast/dom/prototype-inheritance-2-expected.txt:

Updated expectations now that window.SharedWorkers is defined.

fast/dom/prototype-inheritance-expected.txt:

Updated expectations now that window.SharedWorkers is defined.

fast/workers/shared-worker-script-error-expected.txt

Updated expectations to reflect current (correct) behavior (unhandled exceptions are logged to console).

fast/workers/shared-worker-script-error.html

Pauses before exiting the test to allow pending console errors to get emitted (makes test less flaky).

fast/workers/resources/shared-worker-script-error.js

(onerror):
Now properly handles the exception (onerror function has to return false to swallow the exception).

fast/js/global-constructors-expected.txt:

Updated expectations now that window.SharedWorkers is defined.

http/tests/workers/resources/worker-importScripts.js:

Clean up bitrot in tests - MessageEvent.messagePort => MessageEvent.ports.
(handleConnect.self.postMessage):
(handleConnect):

http/tests/workers/resources/worker-redirect-target.js:

Clean up bitrot in tests - MessageEvent.messagePort => MessageEvent.ports.
(self.onconnect):

http/tests/xmlhttprequest/workers/resources/worker-pre.js:

Clean up bitrot in tests - MessageEvent.messagePort => MessageEvent.ports.

12:47 PM Changeset in webkit [48130] by kov@webkit.org

1 copy in releases/WebKitGTK/webkit-1.1.14

Tagging 1.1.14.

12:27 PM Changeset in webkit [48129] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Skipping one more test affected by the libsoup issue, a new test,
and tests that require eventSender.

platform/gtk/Skipped:

11:57 AM Changeset in webkit [48128] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Skipping tests that are failing because of a libsoup
problem. Bug reported.

platform/gtk/Skipped:

11:52 AM Changeset in webkit [48127] by ben@webkit.org

2 edits in trunk/WebKit/qt

[PATCH 2/6] Speed up the QWebPluginInfo::supportsMimeType() function.
https://bugs.webkit.org/show_bug.cgi?id=27651

Instead of going through the MIME types list constructed with
mimeTypes() function, look up the internal mimeToDescriptions map.

11:16 AM Changeset in webkit [48126] by xan@webkit.org

2 edits in trunk/WebCore

2009-09-07 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

Add new file to sources list.

GNUmakefile.am:

10:53 AM Changeset in webkit [48125] by kevino@webkit.org

7 edits in trunk

wx build fixes for wx SVN trunk.

10:21 AM Changeset in webkit [48124] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

What's new for 1.1.14.

NEWS:

10:16 AM Changeset in webkit [48123] by xan@webkit.org

2 edits in trunk

2009-09-07 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

Bump versions in preparation for 1.1.14 release.

configure.ac:

10:07 AM Changeset in webkit [48122] by vestbo@webkit.org

2 edits in trunk/WebCore

[Qt] Use direct includes for Phonon, not the pretty ones

Patch by Chris Hills <chaz@chaz6.com> on 2009-09-07
Reviewed by Tor Arne Vestbø.

platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:

10:02 AM Changeset in webkit [48121] by eric@webkit.org

18 edits
5 adds in trunk

2009-09-07 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Export WTF::tryFastMalloc used in WebSocketChannel.
https://bugs.webkit.org/show_bug.cgi?id=28038

JavaScriptCore.exp:

2009-09-07 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Add WebSocket API.
https://bugs.webkit.org/show_bug.cgi?id=28038

WebSocket constructor is available in window object.

fast/dom/Window/window-properties-expected.txt:
fast/dom/prototype-inheritance-2-expected.txt:
fast/dom/prototype-inheritance-expected.txt:
fast/js/global-constructors-expected.txt:

2009-09-07 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket API implementation.
https://bugs.webkit.org/show_bug.cgi?id=28038

Add build systems only for GNUmakefile.am and WebCore.xcodeproj now.
Other build systems will be updated once the code is functional.
Tests will be landed once the code is completed and functional.

DerivedSources.cpp:
GNUmakefile.am:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webSocket):
bindings/js/JSEventTarget.cpp: (WebCore::toJS): (WebCore::toEventTarget):
dom/EventTarget.cpp: (WebCore::EventTarget::toWebSocket):
dom/EventTarget.h:
page/DOMWindow.idl:
websockets/WebSocket.cpp: (WebCore::ProcessWebSocketEventTask::create): (WebCore::ProcessWebSocketEventTask::performTask): (WebCore::ProcessWebSocketEventTask::ProcessWebSocketEventTask): (WebCore::isValidProtocolString): (WebCore::WebSocket::connect): (WebCore::WebSocket::send): (WebCore::WebSocket::close): (WebCore::WebSocket::bufferedAmount): (WebCore::WebSocket::addEventListener): (WebCore::WebSocket::removeEventListener): (WebCore::WebSocket::dispatchEvent): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): (WebCore::WebSocket::didClose): (WebCore::WebSocket::dispatchOpenEvent): (WebCore::WebSocket::dispatchMessageEvent): (WebCore::WebSocket::dispatchCloseEvent):
websockets/WebSocket.h: (WebCore::WebSocket::create): (WebCore::WebSocket::): (WebCore::WebSocket::setOnopen): (WebCore::WebSocket::onopen): (WebCore::WebSocket::setOnmessage): (WebCore::WebSocket::onmessage): (WebCore::WebSocket::setOnclose): (WebCore::WebSocket::onclose): (WebCore::WebSocket::toWebSocket): (WebCore::WebSocket::eventListeners): (WebCore::WebSocket::refEventTarget): (WebCore::WebSocket::derefEventTarget):
websockets/WebSocketChannel.cpp: Added.
websockets/WebSocketChannel.h: Added.
websockets/WebSocketChannelClient.h: Added.
websockets/WebSocketHandshake.cpp: Added.
websockets/WebSocketHandshake.h: Added.

9:31 AM Changeset in webkit [48120] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Use g_return_if_fail to check for the SoupURI creation, instead of
printing a custom warning.

webkit/webkitnetworkrequest.cpp: (webkit_network_request_set_uri):

9:29 AM Changeset in webkit [48119] by kov@webkit.org

1 edit in trunk/WebKit/gtk/ChangeLog

Fixing name of reviewer in some older commits. Xan suggested the fix,
but Jan reviewed.

9:27 AM Changeset in webkit [48118] by kov@webkit.org

17 edits
4 adds in trunk

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=26854
[GTK] Needs API to allow more control over outgoing requests

GNUmakefile.am: new files added to the build for new class WebKitNetworkResponse

WebCore:

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=26854
[GTK] Needs API to allow more control over outgoing requests

Add infrastructure required to provide the new
WebKitNetworkResponse object in our API.

GNUmakefile.am: Add new files to the build.
platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromSoupMessage):
platform/network/soup/ResourceResponse.h:
platform/network/soup/ResourceResponseSoup.cpp: Added. (WebCore::ResourceResponse::toSoupMessage):

WebKit/gtk

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=26854
[GTK] Needs API to allow more control over outgoing requests

Map the willSendRequest delegate to the 'resource-request-starting'
signal, allowing more control of the resources that are fetched.

Mapping willSendRequest properly requires an appropriate Response
object, so we are introducing WebKitNetworkResponse, which works in a
way similar to WebKitNetworkRequest.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSendRequest): (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest): (WebKit::FrameLoaderClient::dispatchDidFinishLoading): (WebKit::FrameLoaderClient::dispatchDidFailLoading):
tests/testnetworkresponse.c: Added. (test_network_response_create_destroy): (test_network_response_properties): (main):
tests/testwebresource.c: (resource_request_starting_cb): (load_finished_cb): (test_web_resource_loading): (main):
webkit/webkit.h:
webkit/webkitdefines.h:
webkit/webkitnetworkrequest.cpp:
webkit/webkitnetworkresponse.cpp: Added. (webkit_network_response_dispose): (webkit_network_response_finalize): (webkit_network_response_get_property): (webkit_network_response_set_property): (webkit_network_response_class_init): (webkit_network_response_init): (webkit_network_response_new_with_core_response): (webkit_network_response_new): (webkit_network_response_set_uri): (webkit_network_response_get_uri): (webkit_network_response_get_message):
webkit/webkitnetworkresponse.h: Added.
webkit/webkitprivate.cpp: (WTF::SoupMessage): (WTF::WebKitNetworkRequest): (WTF::WebKitNetworkResponse): (WTF::WebKitWebResource):
webkit/webkitprivate.h:
webkit/webkitwebresource.cpp: (webkit_web_resource_cleanup): (webkit_web_resource_finalize): (webkit_web_resource_class_init): (webkit_web_resource_set_property): (webkit_web_resource_get_uri):
webkit/webkitwebview.cpp: (webkit_web_view_class_init):
webkitmarshal.list:

8:28 AM Changeset in webkit [48117] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=28979
[GTK] Misc improvments to NetworkRequest

Unref message in dispose, as it should be, not in finalize.

webkit/webkitnetworkrequest.cpp: (webkit_network_request_dispose): (webkit_network_request_finalize): (webkit_network_request_class_init):

8:28 AM Changeset in webkit [48116] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=28979
[GTK] Misc improvments to NetworkRequest

Bring documentation up-to-date with reality regarding NetworkRequest.

webkit/webkitnetworkrequest.cpp:

8:11 AM Changeset in webkit [48115] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-07 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Make the auth dialog usable when libsoup does not have a
SoupPasswordManager, since it might go away in the next
development cycle.

webkit/webkitsoupauthdialog.c: (response_callback): (session_can_save_passwords): (session_authenticate):

7:49 AM Changeset in webkit [48114] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-07 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

[V8] Cleanup document/frame null-checking in V8DOMWindowCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=29009

Be consistent in document and frame null checks.

bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::V8Custom::ClearTimeoutImpl):

7:21 AM Changeset in webkit [48113] by eric@webkit.org

4 edits in trunk/WebKit/qt

2009-09-07 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

Speed up the QWebPluginInfo::mimeTypes() function.
https://bugs.webkit.org/show_bug.cgi?id=27651

Instead of constructing a list of MIME types every time it is called,
do this only once.

Api/qwebplugindatabase.cpp: (QWebPluginInfo::mimeTypes): (QWebPluginInfo::operator=):
Api/qwebplugindatabase.h:
tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: (tst_QWebPluginDatabase::operatorassign_data): (tst_QWebPluginDatabase::operatorassign):

7:15 AM Changeset in webkit [48112] by eric@webkit.org

3 edits
1 delete in trunk/WebKit/qt

2009-09-07 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

Remove the private classes from QWebPluginDatabase.
https://bugs.webkit.org/show_bug.cgi?id=27651

Instead, hold the PluginDatabase and PluginPackage objects as class
members and take care of refcounting on our own instead of using RefPtr.

This way we not only made the code cleaner but also got rid of
redundant allocations when constructing null QWebPluginInfo objects.

The private classes have been forward-declared and the d-pointers left
to be on the safe side.

Api/qwebplugindatabase.cpp: (QWebPluginInfo::QWebPluginInfo): (QWebPluginInfo::~QWebPluginInfo): (QWebPluginInfo::name): (QWebPluginInfo::description): (QWebPluginInfo::mimeTypes): (QWebPluginInfo::path): (QWebPluginInfo::isNull): (QWebPluginInfo::setEnabled): (QWebPluginInfo::isEnabled): (QWebPluginInfo::operator==): (QWebPluginInfo::operator!=): (QWebPluginInfo::operator=): (QWebPluginDatabase::QWebPluginDatabase): (QWebPluginDatabase::~QWebPluginDatabase): (QWebPluginDatabase::plugins): (QWebPluginDatabase::searchPaths): (QWebPluginDatabase::setSearchPaths): (QWebPluginDatabase::addSearchPath): (QWebPluginDatabase::refresh): (QWebPluginDatabase::pluginForMimeType): (QWebPluginDatabase::setPreferredPluginForMimeType):
Api/qwebplugindatabase.h:
Api/qwebplugindatabase_p.h: Removed.

6:38 AM Changeset in webkit [48111] by xan@webkit.org

2 edits in trunk/WebCore

2009-09-07 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[Soup] Limit the number of connections
https://bugs.webkit.org/show_bug.cgi?id=18431

Increase the maximum number of per host and total connections to
similar values than those used by the other modern browsers. Seems
to significantly improve page loading time in many cases.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized):

3:09 AM Changeset in webkit [48110] by vestbo@webkit.org

2 edits in trunk/LayoutTests

[Qt] Disable a few tests that require missing controller features

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-07
Reviewed by Tor Arne Vestbø

platform/qt/Skipped:

12:35 AM Changeset in webkit [48109] by eric@webkit.org

4 edits in trunk/WebCore

2009-09-07 Michael Nordman <Michael Nordman>

Reviewed by Darin Fisher.

Various minor chromium appcache modifications.
https://bugs.webkit.org/show_bug.cgi?id=28960

No new tests.

bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: Fix a null pointer exception. (WebCore::ACCESSOR_GETTER):
platform/network/chromium/ResourceRequest.h: Switch from appCache 'context' to 'host' terminology. Note: leaving the old deprecated accessors in place until the matching change in chrome is landed to use the new accessors. (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::appCacheHostID): (WebCore::ResourceRequest::setAppCacheHostID): (WebCore::ResourceRequest::appCacheContextID): (WebCore::ResourceRequest::setAppCacheContextID):
platform/network/chromium/ResourceResponse.h: Add an appCacheManifestURL getter/setter. Drop the 'get' prefix from the appCacheID getter. Note: leaving the old deprecated 'get' prefixed accessor in place until the matching change in chrome is landed to use the new accessor. (WebCore::ResourceResponse::appCacheID): (WebCore::ResourceResponse::appCacheManifestURL): (WebCore::ResourceResponse::setAppCacheManifestURL): (WebCore::ResourceResponse::getAppCacheID):

12:28 AM Changeset in webkit [48108] by eric@webkit.org

5 edits
2 adds in trunk

2009-09-07 Michael Nordman <Michael Nordman>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=28359
Test to ensure the the window.applicationCache attribute is defined but non-functional
with the feature disabled.

http/tests/appcache/disabled-expected.txt: Added.
http/tests/appcache/disabled.html: Added.

2009-09-07 Michael Nordman <Michael Nordman>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=28359
Cleanup: Undo some accidental changes around DOMApplicationCache.

Restore support for constructing a DOMApplicationCache object with a null frame ptr.
Return a non-null object for window.applicationCache when the feature is disabled.
Simplify the swapCache method.

Test: http/tests/appcache/disabled.html

loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::DOMApplicationCache): (WebCore::DOMApplicationCache::swapCache): (WebCore::DOMApplicationCache::scriptExecutionContext):
loader/appcache/DOMApplicationCache.h:
page/DOMWindow.cpp: (WebCore::DOMWindow::applicationCache):

Sep 6, 2009:

10:25 PM Changeset in webkit [48107] by eric@webkit.org

5 edits in trunk

2009-09-06 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

hostname and host are mixed up when manipulating anchor elements.
https://bugs.webkit.org/show_bug.cgi?id=28954

Added test case for when port is 0.

fast/dom/Element/hostname-host-expected.txt:
fast/dom/Element/hostname-host.html:

2009-09-06 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

hostname and host are mixed up when manipulating anchor elements.
https://bugs.webkit.org/show_bug.cgi?id=28954

handle the case of port 0.

html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::host):

10:10 PM Changeset in webkit [48106] by abarth@webkit.org

31 edits
6 adds in trunk

2009-09-06 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Tests for https://bugs.webkit.org/show_bug.cgi?id=27099
Make hidden elements not focusable. This is important becaue we should
not allow tabbing to a hidden element.

The patch also makes a element without href behave like generic elements
when it comes to focus. Added tests that asserts that this works as
expected.

fast/events/click-focus-anchor-expected.txt: Added.
fast/events/click-focus-anchor.html: Added.
fast/events/resources/tabindex-focus-blur-all.js: (test): (testProgrammaticFocus):
fast/events/tab-focus-anchor-expected.txt: Added.
fast/events/tab-focus-anchor.html: Added.
fast/events/tab-focus-hidden-expected.txt: Added.
fast/events/tab-focus-hidden.html: Added.
fast/events/tabindex-focus-blur-all-expected.txt:

2009-09-06 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Make hidden elements not focusable.

Clean up supportsFocus and isFocusable.
supportsFocus now strictly means that the node can be focused by default.
This is true for links, form controls and content editable elements for example.
isFocusable means that the user can actually focus it.
All (2) calls to supportsFocus have been updated to take this into account.

Make a elements without href work correctly as well.

https://bugs.webkit.org/show_bug.cgi?id=27099

Tests: fast/events/click-focus-anchor.html

fast/events/tab-focus-anchor.html
fast/events/tab-focus-hidden.html

dom/Element.cpp: (WebCore::Element::focus):
dom/Node.cpp: (WebCore::Node::supportsFocus): (WebCore::Node::isFocusable):
dom/Node.h:
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::supportsFocus): (WebCore::HTMLAnchorElement::isMouseFocusable): (WebCore::HTMLAnchorElement::isKeyboardFocusable):
html/HTMLAnchorElement.h:
html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::supportsFocus):
html/HTMLAreaElement.h:
html/HTMLElement.cpp: (WebCore::HTMLElement::supportsFocus):
html/HTMLElement.h:
html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::supportsFocus):
html/HTMLFieldSetElement.h:
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::supportsFocus): (WebCore::HTMLFormControlElement::isFocusable):
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::supportsFocus):
html/HTMLFrameElementBase.h:
html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::supportsFocus):
html/HTMLLegendElement.h:
html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::supportsFocus): (WebCore::HTMLOptGroupElement::isFocusable):
html/HTMLOptGroupElement.h:
html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::supportsFocus): (WebCore::HTMLOptionElement::isFocusable):
html/HTMLOptionElement.h:
page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent):
page/FocusController.cpp: (WebCore::FocusController::advanceFocus):
svg/SVGAElement.cpp: (WebCore::SVGAElement::supportsFocus): (WebCore::SVGAElement::isFocusable):
wml/WMLAElement.cpp: (WebCore::WMLAElement::supportsFocus):
wml/WMLAElement.h:
wml/WMLFormControlElement.cpp: (WebCore::WMLFormControlElement::supportsFocus): (WebCore::WMLFormControlElement::isFocusable):
wml/WMLFormControlElement.h:

9:15 PM Changeset in webkit [48105] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-06 Joel Stanley <joel@jms.id.au>

Reviewed by Dimitri Glazkov.

Expose functions to set the caret blink interval for Linux Chromium.
Default value is set to that of RenderTheme::caretBlankInterval().
Uses caretBlinkIntervalInternal to avoid overriding
RenderThemeChromiumSkia::caretBlankInterval to preserve the disabling
of blinking caret required for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=28931

rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::setCaretBlinkInterval): (WebCore::RenderThemeChromiumLinux::caretBlinkIntervalInternal):
rendering/RenderThemeChromiumLinux.h:

7:27 PM Changeset in webkit [48104] by adachan@apple.com

2 edits in trunk/WebCore

Remove an extra </File> in WebCore.vcproj.

WebCore.vcproj/WebCore.vcproj:

3:44 PM Changeset in webkit [48103] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update the unitests to latest changes wrt scrollbar policy.

tests/testwindow.c: (test_webkit_window_scrollbar_policy):

1:43 PM Changeset in webkit [48102] by timothy@apple.com

6 edits
1 add in trunk/WebCore

Adds a persistent setting for color format in the Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=28889

Reviewed by Dan Bernstein.

English.lproj/localizedStrings.js: New strings.
inspector/front-end/Color.js: Minor style fixes.

(WebInspector.Color.prototype.toString): Added. Replaces the individual
"toFoo" functions. Takes a optional arguments for the color format to return.

inspector/front-end/Images/paneSettingsButtons.png: Added.
inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._changeColorFormat): Update the sections to show
the new color format.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay):
Use the new toString function on Color.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor): Use the persistent setting
to format colors by default. Add a tooltip for the color swatch.

inspector/front-end/inspector.css: New styles for the settings menu.
inspector/front-end/inspector.js:

(WebInspector.loaded): Initilize the colorFormat preference.

7:31 AM Changeset in webkit [48101] by xan@webkit.org

15 edits
4 adds in trunk

2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.

[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899

Expose an HTML5 database API for GTK+.

GNUmakefile.am:

LayoutTests:

2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.

[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899

Expose an HTML5 database API for GTK+.

platform/gtk/Skipped:

WebKit/gtk:

2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.

[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899

Expose an HTML5 database API for GTK+.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::print):
webkit/webkit.h:
webkit/webkitdefines.h:
webkit/webkitprivate.cpp: (webkit_init):
webkit/webkitprivate.h:
webkit/webkitsecurityorigin.cpp: Added. (webkit_security_origin_finalize): (webkit_security_origin_dispose): (webkit_security_origin_set_property): (webkit_security_origin_get_property): (webkit_security_origins): (webkit_security_origin_class_init): (webkit_security_origin_init): (webkit_security_origin_get_protocol): (webkit_security_origin_get_host): (webkit_security_origin_get_port): (webkit_security_origin_get_web_database_usage): (webkit_security_origin_get_web_database_quota): (webkit_security_origin_set_web_database_quota): (webkit_security_origin_get_all_web_databases): (WebKit::kit): (WebKit::core): (webkit_security_origin_get_web_database):
webkit/webkitsecurityorigin.h: Added.
webkit/webkitwebdatabase.cpp: Added. (webkit_web_database_finalize): (webkit_web_database_dispose): (webkit_web_database_set_property): (webkit_web_database_get_property): (webkit_web_database_class_init): (webkit_web_database_init): (webkit_web_database_set_security_origin): (webkit_web_database_set_name): (webkit_web_database_get_security_origin): (webkit_web_database_get_name): (webkit_web_database_get_display_name): (webkit_web_database_get_expected_size): (webkit_web_database_get_size): (webkit_web_database_get_filename): (webkit_web_database_remove): (webkit_remove_all_web_databases): (webkit_get_web_database_directory_path): (webkit_set_web_database_directory_path): (webkit_get_default_web_database_quota):
webkit/webkitwebdatabase.h: Added.
webkit/webkitwebframe.cpp: (webkit_web_frame_new): (webkit_web_frame_get_focused_accessible_element): (webkit_web_frame_get_horizontal_scrollbar_policy):
webkit/webkitwebframe.h:
webkit/webkitwebview.cpp: (webkit_web_view_class_init):

5:38 AM Changeset in webkit [48100] by Laszlo Gombos

3 edits in trunk/WebCore

2009-09-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Remove Qt v4.6 check from the prefetchDNS implementation
https://bugs.webkit.org/show_bug.cgi?id=28993

platform/network/qt/DnsPrefetchHelper.cpp:
platform/network/qt/DnsPrefetchHelper.h:

12:24 AM Changeset in webkit [48099] by eric@webkit.org

24 edits
3 deletes in trunk

2009-09-06 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991

Update test not to expect a <definition-src> element to be of type
SVGDefinitionSrcElement.

svg/dom/font-face-elements-expected.txt:
svg/dom/font-face-elements.html:

2009-09-06 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991

http://dev.w3.org/SVG/profiles/1.1F2/publish/changes.html#FontsChapter

DerivedSources.cpp: Remove references to definition-src.
DerivedSources.make: Ditto.
GNUmakefile.am: Ditto.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
bindings/objc/DOM.mm: (WebCore::createElementClassMap): Ditto.
bindings/objc/DOMSVG.h: Ditto.
bindings/v8/DerivedSourcesAllInOne.cpp: Ditto.
bindings/v8/V8DOMWrapper.cpp: Ditto.
bindings/v8/V8Index.cpp: Ditto.
bindings/v8/V8Index.h: Ditto.
svg/SVGAllInOne.cpp: Ditto.
svg/SVGDefinitionSrcElement.cpp: Removed.
svg/SVGDefinitionSrcElement.h: Removed.
svg/SVGDefinitionSrcElement.idl: Removed.
svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace): Don't search for definition-src child.
svg/svgtags.in: Remove definition-src.

2009-09-06 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991

MigrateHeaders.make: Remove reference to ObjC definition-src binding class.

2009-09-06 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991

When SVG 1.1 Second Edition is a Recommendation we can remove the
entry altogether.

projects/svg/status.xml: Update page to state that <definition-src> is not supported.

Sep 5, 2009:

9:09 PM Changeset in webkit [48098] by Dimitri Glazkov

3 edits in trunk/WebCore

2009-09-05 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Roll out http://trac.webkit.org/changeset/48094, because the
logic of retrieving default caret blink interval was incorrect (non-existent)
and caused layout test flakiness.

rendering/RenderThemeChromiumLinux.cpp:
rendering/RenderThemeChromiumLinux.h:

8:57 PM MathML Goals edited by alex@milowski.com

(diff)

4:47 PM Changeset in webkit [48097] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-09-05 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] r47424 broke binary compatibility
https://bugs.webkit.org/show_bug.cgi?id=28996

Append the new DnsPrefetchEnabled attribute at the end of the enum.

Api/qwebsettings.h:

10:42 AM Changeset in webkit [48096] by jianli@chromium.org

2 edits in trunk/WebCore

Back up partial change in r48072 in order to fix chromium reliability build break.

Reviewed by NOBODY (Chromium reliability build break).

bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::invokeEventHandler):

2:13 AM Changeset in webkit [48095] by eric@webkit.org

6 edits in trunk/WebCore

2009-09-05 Nicolas Weber <thakis@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=28975
Fix file upload on chrome/mac. Images that have "Hide Extension" set,
such as screenshots by default, can now be uploaded to sites such as
imgur.com.

platform/FileSystem.h: Add pathGetDisplayFileName().
platform/chromium/FileChooserChromium.cpp: (WebCore::FileChooser::basenameForWidth): Call pathGetDisplayFileName() instead of pathGetFileName().
platform/chromium/FileSystemChromiumLinux.cpp: (WebCore::pathGetDisplayFileName): Implement pathGetDisplayFileName() by delegating to pathGetFileName().
platform/chromium/FileSystemChromiumMac.mm: (WebCore::pathGetFileName): Now returns a real filename instead of a presentational one, which fixes the problem addressed by this change. (WebCore::pathGetDisplayFileName): New function that returns a presentational filename; does what pathGetDisplayFileName() did prior to this patch.
platform/chromium/FileSystemChromiumWin.cpp: (WebCore::pathGetDisplayFileName): Implement pathGetDisplayFileName() by delegating to pathGetFileName().

2:05 AM Changeset in webkit [48094] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-05 Joel Stanley <joel@jms.id.au>

Reviewed by David Levin.

Expose functions to set the caret blink interval for Linux Chromium.
https://bugs.webkit.org/show_bug.cgi?id=28931

rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::setCaretBlinkInterval): (WebCore::RenderThemeChromiumLinux::caretBlinkInterval):
rendering/RenderThemeChromiumLinux.h:

1:43 AM Changeset in webkit [48093] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-09-05 Eric Seidel <eric@webkit.org>

No review, results update only.

Update results after r48043.

fast/js/JSON-stringify-expected.txt:

Sep 4, 2009:

9:10 PM Changeset in webkit [48092] by mrowe@apple.com

4 edits in branches/safari-4-branch

Versioning.

9:09 PM Changeset in webkit [48091] by mrowe@apple.com

1 copy in tags/Safari-6531.17

New tag.

9:08 PM Changeset in webkit [48090] by mrowe@apple.com

2 edits in branches/safari-4-branch/WebCore

Merge r48085.

9:08 PM Changeset in webkit [48089] by mrowe@apple.com

4 edits in branches/safari-4-branch/WebCore

Merge r48070.

9:07 PM Changeset in webkit [48088] by mrowe@apple.com

2 edits in branches/safari-4-branch/WebCore

2009-09-04 Anders Carlsson <andersca@apple.com>

Reviewed by Adele Petersen.

Fix <rdar://problem/7192902>

Never throw away the first frame in an animation.

platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):

9:07 PM Changeset in webkit [48087] by mrowe@apple.com

4 edits in branches/safari-4-branch/WebCore

Merge r48062.

8:54 PM Changeset in webkit [48086] by dimich@chromium.org

4 edits
1 add in trunk/WebCore

Prevent UI freeze in case when too many timers are in the timer queue.
https://bugs.webkit.org/show_bug.cgi?id=23865

Reviewed by David Levin.

The fix measures the elapsed time while executing timers. If we have too many
timers and it takes significant time to fire, quit the loop and reschedule.
This lets the run loop process user input (close the window for example).

platform/ThreadTimers.h:
platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::sharedTimerFiredInternal):
(WebCore::ThreadTimers::fireTimersInNestedEventLoop):
Removed functions and members used before to grab a list of all expired timers.
Now we fetch one by one, measuring time and quitting the loop if it takes too long.

platform/Timer.cpp:

(WebCore::TimerBase::isActive):
(WebCore::TimerBase::setNextFireTime):
Since timers are now fired one by one, there is no need to keep track of updated timers.

manual-tests/input-starved-by-timers.html: Manual test that attempts to freeze browser by

creating of enough timers. It then keeps UI frozen and after 10 seconds starts to drain the timers
so the browser un-freezes. This is instead of a regular layout test because we don't have a way
to inject an input events via regular run loop in DRT - instead they are directly dispatched by
eventSender, which does not reproduce the UI freeze that happens with real input.

8:47 PM Changeset in webkit [48085] by andersca@apple.com

2 edits in trunk/WebCore

<rdar://problem/7201063>

Reviewed by Adele Peterson.

Detach any custom scrollbars before detaching the document.

page/Frame.cpp:

(WebCore::Frame::setView):

7:19 PM Changeset in webkit [48084] by oliver@apple.com

3 edits in trunk/JavaScriptCore

Windows build fix

7:07 PM Changeset in webkit [48083] by oliver@apple.com

6 edits in trunk

ToString conversion should use the actual toString function for String objects.

Reviewed by Gavin Barraclough.

Remove incorrect specialisations of toString conversions on StringObject.

6:13 PM Changeset in webkit [48082] by Laszlo Gombos

5 edits in trunk/WebCore

Unreviewed, build fix.

Remove remaining references to UserStyleSheetLoader after r48075.

WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
page/qt/FrameQt.cpp:
page/wince/FrameWince.cpp:

5:35 PM Changeset in webkit [48081] by eric@webkit.org

7 edits in trunk

2009-09-04 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=28988
Minor fix: "novalidate" attribute renamed in "noValidate", according to
HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#dom-fs-novalidate

fast/forms/novalidate-attribute-expected.txt:
fast/forms/resources/novalidate-attribute.js:

2009-09-04 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=28988
Minor fix: "novalidate" attribute renamed in "noValidate", according to
HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#dom-fs-novalidate

html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::noValidate): (WebCore::HTMLFormElement::setNoValidate):
html/HTMLFormElement.h:
html/HTMLFormElement.idl:

5:18 PM Changeset in webkit [48080] by dimich@chromium.org

2 edits in trunk/WebCore

Remove unused line of code from WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=28990

Reviewed by David Levin.

workers/WorkerContext.cpp:

(WebCore::WorkerContext::importScripts):

5:03 PM Changeset in webkit [48079] by Darin Adler

2 edits in trunk/WebCore

Fix assertion seen when running buildbot.

Patch by Darin Adler <Darin Adler> on 2009-09-04
Reviewed by Oliver Hunt.

bindings/js/JSDOMBinding.h:

(WebCore::DOMObjectWithGlobalPointer::createStructure): Create the structure without
the HasDefaultMark bit since this has a custom mark function.

3:27 PM Changeset in webkit [48078] by ap@apple.com

2 edits in trunk/LayoutTests

Fix expected test output.

fast/dom/DOMImplementation/detached-doctype-expected.txt:

2:54 PM Changeset in webkit [48077] by sfalken@apple.com

3 edits in trunk/JavaScriptCore

Windows build fix.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Add new export.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Add new export.

2:45 PM Changeset in webkit [48076] by sfalken@apple.com

3 edits in trunk/JavaScriptCore

Windows build fix.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove unneeded export.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Remove unneeded export.

2:33 PM Changeset in webkit [48075] by hyatt@apple.com

11 edits
2 deletes in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28984, remove the remote stylesheet loader on Mac/Qt.
Make sure the other code path (now used by everybody) can handle data URLs.

Reviewed by Adam Roben.

As per the post on webkit-dev, the ability to work remotely isn't working properly anyway (it doesn't
hold up the pending sheet count, so you'd just FOUC on every Web page), and it's extremely unlikely
that anybody is relying on this support.

Tor Arne agreed it was ok to disable (he enabled it on the Qt side), and only Mac/Qt were using this
code.

WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:

(WebCore::Document::userStyleSheet):

dom/Document.h:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::begin):

loader/UserStyleSheetLoader.cpp: Removed.
loader/UserStyleSheetLoader.h: Removed.
page/Frame.cpp:

(WebCore::Frame::reapplyStyles):

page/Frame.h:
page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):
(WebCore::Page::userStyleSheet):

page/mac/FrameMac.mm:
page/qt/FrameQt.cpp:

2:11 PM Changeset in webkit [48074] by pfeldman@chromium.org

4 edits in trunk/WebCore

2009-09-04 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Add "sampling profiler" preference, simplify data display when it's set.

https://bugs.webkit.org/show_bug.cgi?id=28969

inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds): (WebInspector.ProfileDataGridNode.prototype.get data):
inspector/front-end/ProfileView.js: (WebInspector.ProfileView):
inspector/front-end/inspector.js:

1:55 PM Changeset in webkit [48073] by hyatt@apple.com

1 edit in trunk/WebCore/page/Frame.cpp

Remove bogus assert that is affecting layout tests.

1:40 PM Changeset in webkit [48072] by jianli@chromium.org

10 edits in trunk/WebCore

[V8] Run-time exception in onmessage handler is not forwarded to the worker object.
https://bugs.webkit.org/show_bug.cgi?id=28980

Reviewed by Adam Barth.

Tested by worker-close.html.

bindings/v8/ScriptFunctionCall.cpp:
bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::invokeEventHandler):

bindings/v8/V8Utilities.cpp:

(WebCore::getScriptExecutionContext):
(WebCore::reportException):

bindings/v8/V8Utilities.h:

(WebCore::getScriptExecutionContext):

bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::CALLBACK_FUNC_DECL):

bindings/v8/custom/V8SharedWorkerCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::CALLBACK_FUNC_DECL):

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

12:53 PM Changeset in webkit [48071] by hyatt@apple.com

3 edits in trunk/WebCore

Remove unused m_sheet variable and setCSSStyleSheet methods.

Reviewed by Anders Carlsson.

dom/Document.cpp:
dom/Document.h:

12:39 PM MathML Goals edited by alex@milowski.com

(diff)

12:31 PM Changeset in webkit [48070] by andersca@apple.com

4 edits in trunk/WebCore

(Based on a patch from Adele).

Reviewed by David Hyatt and Adele Peterson.

Fix <rdar://problem/7185875>.

page/Frame.cpp:

(WebCore::Frame::setView):
Detach any custom scroll bars from the old view.

page/FrameView.cpp:

(WebCore::FrameView::detachCustomScrollbars):
Simplify the check (and make it work when body is null) by just checking that the scroll bar owner is
not a RenderPart object.

rendering/RenderObject.cpp:

(WebCore::RenderObject::destroy):
ASSERT that frame() is not null here and also add a null check so that release builds won't crash.

12:09 PM Changeset in webkit [48069] by hyatt@apple.com

4 edits in trunk/WebCore

Make m_userStyleSheetLoader in Frame an OwnPtr.

Reviewed by Adam Roben.

page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::~Frame):

page/Frame.h:
page/mac/FrameMac.mm:

(WebCore::Frame::setUserStyleSheetLocation):
(WebCore::Frame::setUserStyleSheet):

12:05 PM MathML Goals created by alex@milowski.com

12:03 PM Changeset in webkit [48068] by Darin Adler

10 edits in trunk/JavaScriptCore

DateInstance object collected on ARM JIT (JSValue: WTF_USE_JSVALUE32)
https://bugs.webkit.org/show_bug.cgi?id=28909

Patch by Darin Adler <Darin Adler> on 2009-09-04
Reviewed by Geoff Garen.

Part two.

Make some improvements to garbage collection code:

1) Create a runtime assertion that catches any classes that

override markChildren but have the HasDefaultMark bit set.

2) Remove checks of the mark bit outside the MarkStack::append

function; they are redundant.

3) Improve the efficiency of the asObject and asArray functions

when called on JSCell* to avoid a round trip to JSValue.

4) Make more callers use the checked asCell and asObject

casting functions rather than unchecked casts.

5) Removed the JSCell::marked function and other GC-related

functions because these operations are no longer things that
code other than the core GC code needs to do directly. Fixed
callers that were calling them.

runtime/Collector.cpp:

(JSC::Heap::markConservatively): Removed unneeded call to MarkStack::drain.
(JSC::Heap::markProtectedObjects): Removed unneeded check of the mark
bit and call to MarkStack::drain.
(JSC::Heap::collect): Removed unneeded checks of the mark bit and also
changed call to SmallStrings::mark to call markChildren instead to match
the rest of the objects.
(JSC::typeName): Removed unneeded cast to JSObject*.

runtime/JSArray.h:

(JSC::asArray): Added an overload for JSCell* and changed the JSValue
version to call it. Removed some unneeded casts.
(JSC::JSArray::markChildrenDirect): Marked this function inline. It's in
a header, and if not marked inline this could lead to linking problems.
(JSC::MarkStack::markChildren): Added. This helper function is used by
the drain function to avoid repating code. Also added the code here to
check fro default mark violations in debug code. If a markChildren
function adds something to the mark stack, but the type info claimed
hasDefaultMark was true, then we will get an assertion now. Also fixed
the assertion about the mark bit to use the Heap function directly
because we don't have a JSCell::marked function any more.
(JSC::MarkStack::drain): Changed a local variable from "v" to "value",
and from "currentCell" to "cell". Changed to call markChildren in two
places instead of repeating a chain of if statements twice. Changed
code that reads and writes the mark bit to use Heap::isCellMarked and
Heap::markCell so we can eliminate the JSCell::marked and
JSCell::markCellDirect functions.

runtime/JSCell.h: Removed JSCell's markCellDirect and marked member

functions. Added a comment explaining that asCell should be deprecated
in favor of the JSValue asCell member function.
(JSC::MarkStack::append): Added the assertion that catches callers
that have set the HasDefaultMark bit incorrectly. Changed
code that reads and writes the mark bit to use Heap::isCellMarked and
Heap::markCell so we can eliminate the JSCell::marked and
JSCell::markCellDirect functions. Moved the overload of
MarkStack::append for JSValue here so it can call through to the cell
version. The old version had a copy of all the code instead, but that
repeated the conversion from JSValue to JSCell* and the check for
whether a value is a cell multiple times.
(JSC::Structure::markAggregate): Moved this function here to avoid
dependencies for Structure.h, since this calls MarkStack::append.

runtime/JSObject.cpp:

(JSC::JSObject::markChildren): Added code to clear
m_isCheckingForDefaultMarkViolation so the marking done by JSObject
doesn't trigger the assertion.

runtime/JSValue.h: Moved some stray includes that were outside the

header guard inside it. Not sure how that happened! Removed the
GC-related member functions markChildren, hasChildren, marked, and
markDirect.

runtime/JSWrapperObject.h: Made markChildren private.

(JSC::JSWrapperObject::createStructure): Added. Fixes a bug where the
HasDefaultMark bit was set.

runtime/MarkStack.h: Added m_isCheckingForDefaultMarkViolation and

initialized it to false. Moved the append function body from here to
JSCell.h. Added a declaration of a private markChildren function used
inside the drain function.

runtime/SmallStrings.cpp:

(JSC::SmallStrings::markChildren): Changed the name and style of this
function to match other functions. This allows us to share the normal
mark stack code path.

runtime/SmallStrings.h: Changed the name and interface of mark to

the more-normal markChildren style.

runtime/Structure.h: Moved the body of markAggregate into the

JSCell.h to avoid a circular dependency with JSCell.h.

11:53 AM Changeset in webkit [48067] by Darin Adler

13 edits in trunk

JavaScriptCore: DateInstance object collected on ARM JIT (JSValue: WTF_USE_JSVALUE32)
https://bugs.webkit.org/show_bug.cgi?id=28909

Patch by Darin Adler <Darin Adler> on 2009-09-04
Reviewed by Geoff Garen.

Part one.

Make some improvements to garbage collection code:

1) Fix the two classes that had the default mark bit set but

should not.

2) Remove checks of the mark bit outside the MarkStack::append

function; they are redundant.

3) Make more callers use the checked asCell and asObject

casting functions rather than unchecked casts.

4) Removed some GC-related functions because these operations are

no longer things that code other than the core GC code needs
to do directly. Fixed callers that were calling them.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::markAggregate): Removed unneeded check of the mark
bit before calling MarkStack::append.

interpreter/Register.h: Removed unneeded marked and markChildren

functions.

jit/JITStubs.cpp:

(op_eq): Removed unneeded assertions, instead using checked casting
functions such as asObject.

runtime/ArgList.h: Added now-needed forward declaration of MarkStack.

runtime/GetterSetter.cpp:

(JSC::GetterSetter::markChildren): Remmoved unneeded check of the mark bit.

runtime/GlobalEvalFunction.h:

(JSC::GlobalEvalFunction::createStructure): Added. Fixes a bug where the
HasDefaultMark bit was set.

runtime/JSCell.cpp:

(JSC::JSCell::getObject): Use asObject to avoid a direct static_cast.

runtime/JSObject.h:

(JSC::asObject): Added an overload for JSCell* and changed the JSValue
version to call it.
(JSC::JSValue::get): Use asObject to avoid a direct static_cast.

runtime/JSValue.h: Moved some stray includes that were outside the

header guard inside it. Not sure how that happened! Removed the
GC-related member functions markChildren, hasChildren, marked, and
markDirect.

runtime/JSWrapperObject.h: Made markChildren private.

(JSC::JSWrapperObject::createStructure): Added. Fixes a bug where the
HasDefaultMark bit was set. Later we may want to optimize this for
wrapper types that never have cells in their internal values, but there
is no measured performance regression in SunSpider or V8 doing this
all the time.

runtime/MarkStack.cpp: Tweaked formatting.

JavaScriptGlue: * JSValueWrapper.cpp:
(JSValueWrapper::JSObjectMark): Removed a check of the mark
bit. It's OK to do more work in this case, and there is no
longer a public function to access the mark bit.

Reviewed by Geoff Garen.

11:35 AM WikiStart edited by alex@milowski.com

(diff)

11:34 AM WikiStart edited by alex@milowski.com

added MathML section (diff)

11:22 AM Changeset in webkit [48066] by kevino@webkit.org

4 edits in trunk

wx build fix. Switch USE_ defines over to the compiler so that they can be
checked by files not including config.h (like WebCorePrefix.h).

11:07 AM Changeset in webkit [48065] by timothy@apple.com

3 edits in trunk/WebCore

Show color swatches in the Web Inspector before the color text so clicking them will not
shift the swatch. Also makes multiple swatches in the single property toggle the color format.

https://bugs.webkit.org/show_bug.cgi?id=28978

Reviewed by Darin Adler.

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.updateTitle): Some refactoring to consolidate
the processing we do on the property value. This eliminated the old nickname code, since the new
WebInspector.Color class handles this. We could also simplify the color regex since more
is handled by the Color class. Also no longer uses innerHTML for the linkify code.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processValue): Helper function to
process a value given a regex and processor functions.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): Make an anchor for the
URL with "url()" syntax surrounding it.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor): Makes a color, if
there was an exception just return a text node.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay.changeTo):
Moved from later in the file.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay): Ditto.

inspector/front-end/inspector.css:

10:59 AM Changeset in webkit [48064] by Dimitri Glazkov

13 edits in trunk

WebCore:

2009-09-04 Mark Mentovai <mark@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=28614

Account for scrollbar state changes that occur during layout.

platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):

Perform a layout prior to checking whether the scrollbar modes are
off, on, or automatic. The modes may change during layout.

WebCore.base.exp:
WebCore.order:
page/Frame.cpp: (WebCore::Frame::createView):
page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::layout):
page/FrameView.h:
platform/ScrollView.h:

Eliminate duplicated (and incorrect) scrollbar mode tracking between
FrameView and ScrollView.

WebKit/mac:

2009-09-04 Mark Mentovai <mark@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=28614

Account for scrollbar state changes that occur during layout.

WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView updateScrollers]):

Perform a layout prior to checking whether the scrollbar modes are
off, on, or automatic. The modes may change during layout.

WebView/WebFrameView.mm: (-[WebFrameView _install]):

Eliminate duplicated (and incorrect) scrollbar mode tracking between
FrameView and ScrollView.

WebKit/qt:

2009-09-04 Mark Mentovai <mark@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=28614

Account for scrollbar state changes that occur during layout.

Api/qwebframe.cpp: (QWebFrame::setScrollBarPolicy):

Eliminate duplicated (and incorrect) scrollbar mode tracking between
FrameView and ScrollView.

10:53 AM Changeset in webkit [48063] by yael.aharon@nokia.com

5 edits
2 adds in trunk

WebCore: hostname and host are mixed up when manipulating anchor elements.
https://bugs.webkit.org/show_bug.cgi?id=28954

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-04
Reviewed by Darin Adler.

Swapped the implementation of host and hostname, and made sure not to return
the port number if it is default for the given protocol.
FireFox also avoids returning the protocol number if it is default.

Test: fast/dom/Element/hostname-host.html

10:19 AM Changeset in webkit [48062] by andersca@apple.com

4 edits in trunk/WebCore

Fix <rdar://problem/7192902>.

Reviewed by Darin Adler and Steve Falkenburg.

Add the necessary plumbing for having QTMovieWin use WebCore timers.

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:

(WebCore::TaskTimer::initialize):
Create the timer and call QTMovieWin::setTaskTimerFuncs.

(WebCore::TaskTimer::setTaskTimerDelay):
Start the timer.

(WebCore::TaskTimer::stopTaskTimer):
Stop the timer.

(WebCore::TaskTimer::fired):
Call QTMovieWin::taskTimerFired().

(WebCore::MediaPlayerPrivate::load):
Initialize the Task timer.

platform/graphics/win/QTMovieWin.cpp:

(updateTaskTimer):
Call the global stopTaskTimer function and setTaskTimerDelay.

(QTMovieWin::taskTimerFired):
Make this a member function.

(QTMovieWin::setTaskTimerFuncs):
Set the global function pointers.

(QTMovieWin::initializeQuickTime):
(DllMain):
No need to use the QT shared timer.

platform/graphics/win/QTMovieWin.h:

10:08 AM Changeset in webkit [48061] by levin@chromium.org

2 edits in trunk/WebCore

Fix Chromium Win compile. Missing return statement in
WebCore::RenderThemeChromiumSkia::paintSliderThumb.
https://bugs.webkit.org/show_bug.cgi?id=28974

Patch by Tony Chang <tony@chromium.org> on 2009-09-04
Reviewed by David Levin.

No new tests, build fix.

rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::paintSliderThumb):

10:07 AM Changeset in webkit [48060] by Adam Roben

2 edits in trunk/WebKit/win

Make WebView function without a parent window

When WebView has no parent window, it becomes a message-only window,
which hides it from the screen and prevents it from appearing on the
taskbar.

Fixes <http://webkit.org/b/28971> <rdar://problem/4976998>
WebView::initWithFrame fails if there's no host window

Reviewed by Dave Hyatt.

WebView.cpp:

(WebView::initWithFrame): m_hostWindow is null, use HWND_MESSAGE as
our parent window, which will make us a message-only window.
(WebView::setHostWindow): If he new host window is null, use
HWND_MESSAGE as our parent window, which will make us a message-only
window.

10:06 AM Changeset in webkit [48059] by Dimitri Glazkov

7 edits
3 deletes in trunk

2009-09-04 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Rolling out http://trac.webkit.org/changeset/48035, because it broke
the build.
https://bugs.webkit.org/show_bug.cgi?id=28696

10:02 AM Changeset in webkit [48058] by andersca@apple.com

2 edits in trunk/WebCore

Fix vcproj file.

WebCore.vcproj/WebCore.vcproj:

10:01 AM Changeset in webkit [48057] by hyatt@apple.com

29 edits
6 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work.

Reviewed by Adam Roben.

This patch adds new API for adding and removing user scripts from page groups. User scripts
are bundled together in isolated worlds (you can have multiple scripts together in the same
world).

Added userscripts/ directory for holding new tests (along with a simple test of script injection).

WebCore.base.exp:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInIsolatedWorld):

bindings/js/ScriptController.h:
bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::evaluateInIsolatedWorld):

bindings/v8/ScriptController.h:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::dispatchDocumentElementAvailable):

page/Frame.cpp:

(WebCore::Frame::injectUserScripts):
(WebCore::Frame::injectUserScriptsForWorld):

page/Frame.h:
page/PageGroup.cpp:

(WebCore::PageGroup::~PageGroup):
(WebCore::PageGroup::addUserScript):
(WebCore::PageGroup::removeUserContentForWorld):
(WebCore::PageGroup::removeAllUserContent):

page/PageGroup.h:

(WebCore::PageGroup::userScripts):

page/UserScript.h: Added.

(WebCore::UserScript::UserScript):
(WebCore::UserScript::source):
(WebCore::UserScript::url):
(WebCore::UserScript::patterns):
(WebCore::UserScript::worldID):
(WebCore::UserScript::injectionTime):

page/UserScriptTypes.h: Added.

(WebCore::):

WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work.

Reviewed by Adam Roben.

This patch adds new API for adding and removing user scripts from page groups. User scripts
are bundled together in isolated worlds (you can have multiple scripts together in the same
world).

Added userscripts/ directory for holding new tests (along with a simple test of script injection).

WebView/WebView.mm:

(+[WebView _addUserScriptToGroup:source:url:worldID:patterns:injectionTime:]):
(+[WebView _removeUserContentFromGroup:worldID:]):
(+[WebView _removeAllUserContentFromGroup:]):

WebView/WebViewPrivate.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work.

Reviewed by Adam Roben.

This patch adds new API for adding and removing user scripts from page groups. User scripts
are bundled together in isolated worlds (you can have multiple scripts together in the same
world).

Added userscripts/ directory for holding new tests (along with a simple test of script injection).

platform/mac/userscripts: Added.
platform/mac/userscripts/script-run-at-end-expected.txt: Added.
userscripts: Added.
userscripts/script-run-at-end.html: Added.

9:42 AM Changeset in webkit [48056] by abarth@webkit.org

1 edit in trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp

Added missing ;

9:34 AM Changeset in webkit [48055] by ap@apple.com

4 edits
2 adds in trunk

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26402
Crashes when using a detached DocumentType node

Test: fast/dom/DOMImplementation/detached-doctype.html

DocumentType nodes are the only one that can have null document(), and they can never have
children, so they are a degenerate case for NodeLists.

dom/Node.cpp: (WebCore::Node::childNodes): Don't try register node list with document if there's no document. Since there are no changes possible for a DocumentType's node list, this is not necessary. (WebCore::Node::registerDynamicNodeList): Ditto. (WebCore::Node::unregisterDynamicNodeList): Ditto. I couldn't find a scenario where this was invoked for a DocumentType node, but I also couldn't prove that it can't be (the de-registration code path that I saw taken was via Node destructor, and that already has a null check for document).

bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): Bail out if there is no document (just as we already do if there is no window). (WebCore::JSNode::removeEventListener): Ditto.

9:34 AM Changeset in webkit [48054] by abarth@webkit.org

2 edits in trunk/WebKit/win

2009-09-04 Adam Barth <abarth@webkit.org>

Unreviewed attempt at a build fix.

Added missing include.

WebCoreSupport/WebFrameLoaderClient.cpp:

9:23 AM Changeset in webkit [48053] by abarth@webkit.org

5 edits in trunk

2009-09-04 Adam Barth <abarth@webkit.org>

Unreviewed attempt at a build fix.

Fix typo of IWebFrameLoadDelegatePrivate2 and make
IWebFrameLoadDelegatePrivate inherit from IWebFrameLoadDelegatePrivate
as requestd by Adam Roben.

Interfaces/IWebFrameLoadDelegatePrivate2.idl:
WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):

2009-09-04 Adam Barth <abarth@webkit.org>

Unreviewed build fix.

Update declaration of FrameLoadDelegate to reflect that
IWebFrameLoadDelegatePrivate2 inherits from
IWebFrameLoadDelegatePrivate.

DumpRenderTree/win/FrameLoadDelegate.h:

8:53 AM Changeset in webkit [48052] by vestbo@webkit.org

2 edits in trunk/LayoutTests

[Qt] Fix brainfart in r48050, tests should have paths

Rubber-stamped by Simon Hausmann.

platform/qt/Skipped:

8:49 AM Changeset in webkit [48051] by abarth@webkit.org

13 edits
2 adds in trunk

2009-09-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24696

Plumb mixed content notifications to WebFrameLoadDelegatePrivate.

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
WebView/WebDelegateImplementationCaching.h:
WebView/WebFrameLoadDelegatePrivate.h: Added.

2009-09-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24696

Plumb mixed content notifications to IWebFrameLoadDelegatePrivate.

Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added.
Interfaces/WebKit.idl:
WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
WebKit.vcproj/Interfaces.vcproj:

2009-09-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24696

Add testing instrumentation for mixed content.

DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:]): (-[FrameLoadDelegate webView:didRunInsecureContent:]):
DumpRenderTree/win/FrameLoadDelegate.cpp: (descriptionSuitableForTestResult): (FrameLoadDelegate::QueryInterface): (FrameLoadDelegate::didDisplayInsecureContent): (FrameLoadDelegate::didRunInsecureContent):
DumpRenderTree/win/FrameLoadDelegate.h:

8:34 AM Changeset in webkit [48050] by vestbo@webkit.org

2 edits in trunk/LayoutTests

[Qt] Skip tests failing due to missing DRT features

Rubber-stamped by Simon Hausmann.

platform/qt/Skipped:

7:04 AM Changeset in webkit [48049] by xan@webkit.org

2 edits in trunk/WebCore

2009-09-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] loadFinished never emitted
https://bugs.webkit.org/show_bug.cgi?id=28935

Do not report errors right away from
ResourceHandle::start. Instead return true and schedule an error
to be reported in the handle later. Otherwise WebCore gets
confused and thinks the resource never finished loading, making it
not emit the finished status.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp): (WebCore::):

7:00 AM Changeset in webkit [48048] by yong.li@torchmobile.com

2 edits in trunk/JavaScriptCore

2009-09-03 Yong Li <yong.li@torchmobile.com>

Reviewed by David Levin.

Remove unnecessary dependency on unistd.h
https://bugs.webkit.org/show_bug.cgi?id=28962

runtime/Completion.cpp:

3:28 AM Changeset in webkit [48047] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-04 Ben Murdoch <benm@google.com>

Reviewed by Eric Seidel.

[V8] DOM Storage bindings: Event Handler should create StorageEvents
https://bugs.webkit.org/show_bug.cgi?id=28942

Tests:
Causes the following tests that were failing with V8 to pass:

storage/domstorage/localstorage/onstorage-attribute-setwindow.html
storage/domstorage/localstorage/complex-keys.html
storage/domstorage/localstorage/onstorage-attribute-markup.html
storage/domstorage/localstorage/simple-events.html
storage/domstorage/localstorage/onstorage-attribute-set-attribute.html
storage/domstorage/localstorage/index-get-and-set.html
storage/domstorage/sessionstorage/onstorage-attribute-setwindow.html
storage/domstorage/sessionstorage/onstorage-attribute-markup.html
storage/domstorage/sessionstorage/simple-events.html
storage/domstorage/sessionstorage/onstorage-attribute-set-attribute.html
storage/domstorage/sessionstorage/index-get-and-set.html

Code changes:

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object): Create StorageEvents.
bindings/v8/custom/V8StorageCustom.cpp: (WebCore::storageGetter): Check if we are retrieving the length property and return the number of items in the object rather than a property named length when invoking the getItem() member of local/sessionStorage.

2:04 AM Changeset in webkit [48046] by pfeldman@chromium.org

19 edits
1 add in trunk/WebCore

2009-09-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=28911

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._formatarray): (WebInspector.ConsoleView.prototype._formatnode):
inspector/front-end/DOMAgent.js:
inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch):
inspector/front-end/InjectedScript.js: (InjectedScript.dispatch):
inspector/front-end/InjectedScriptAccess.js: Added. (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName): (InjectedScriptAccess._installHandler):
inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update): (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update):
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted): (WebInspector.StylePropertyTreeElement.prototype):
inspector/front-end/inspector.html:

1:47 AM Changeset in webkit [48045] by eric@webkit.org

5 edits in trunk/WebCore

2009-09-04 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Implement <input type="range"> for Chromium Linux by painting
the slider and the thumb using skia.
https://bugs.webkit.org/show_bug.cgi?id=28928

Covered by existing tests (we're currently hitting an assert for them).

rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
rendering/RenderThemeChromiumLinux.h:
rendering/RenderThemeChromiumSkia.cpp: (WebCore::drawVertLine): (WebCore::drawHorizLine): (WebCore::drawBox): (WebCore::RenderThemeChromiumSkia::paintSliderTrack): (WebCore::RenderThemeChromiumSkia::paintSliderThumb):
rendering/RenderThemeChromiumSkia.h:

1:40 AM Changeset in webkit [48044] by eric@webkit.org

3 edits in trunk

2009-09-04 Albert Bachand <albertb@google.com>

Reviewed by Eric Seidel.

Modify the condition regarding the key modifier for opening combo
boxes under GTK from just PLATFORM(GTK) to also look for
(PLATFORM(CHROMIUM) && PLATFORM(LINUX)).

WebCore/dom/SelectElement.cpp:
WebCore/manual-tests/select-popup-on-spacebar.html:

1:32 AM Changeset in webkit [48043] by eric@webkit.org

6 edits
6 adds in trunk

2009-09-04 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Tests for <input type=color> validation.
https://bugs.webkit.org/show_bug.cgi?id=28966

fast/forms/ValidityState-patternMismatch-unsupported-expected.txt: Added.
fast/forms/ValidityState-patternMismatch-unsupported.html: Added.
fast/forms/ValidityState-typeMismatch-color-expected.txt: Added.
fast/forms/ValidityState-typeMismatch-color.html: Added.
fast/forms/resources/ValidityState-patternMismatch-unsupported.js: Added.
fast/forms/resources/ValidityState-typeMismatch-color.js: Added.

2009-09-04 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Implement <input type=color> as a text field.
ValidityState::typeMismatch supports for type=color. https://bugs.webkit.org/show_bug.cgi?id=28966

Tests: fast/forms/ValidityState-patternMismatch-unsupported.html

fast/forms/ValidityState-typeMismatch-color.html

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueMissing): (WebCore::HTMLInputElement::patternMismatch): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::formControlType): (WebCore::HTMLInputElement::saveFormControlState): (WebCore::HTMLInputElement::restoreFormControlState): (WebCore::HTMLInputElement::accessKeyAction): (WebCore::HTMLInputElement::rendererIsNeeded): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::appendFormData): (WebCore::HTMLInputElement::valueWithDefault): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::isRequiredFormControl): (WebCore::HTMLInputElement::dataList):
html/HTMLInputElement.h: (WebCore::HTMLInputElement::): (WebCore::HTMLInputElement::isTextField):
html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch): (WebCore::ValidityState::isValidColorString):
html/ValidityState.h:

1:07 AM Changeset in webkit [48042] by levin@chromium.org

2 edits in trunk/WebCore

[V8] Crash when updating document cache
https://bugs.webkit.org/show_bug.cgi?id=28965

Patch by Mads Ager <ager@chromium.org> on 2009-09-04
Reviewed by David Levin.

Initialization of a V8 JavaScript context can fail. When that
happens, do not attempt to update the document wrapper cache.

This code path is exercised by http/tests/security/javascriptURL/javascriptURL-in-new-iframe.html.

bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::updateDocument):

12:50 AM Changeset in webkit [48041] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-09-04 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Fix tst_QWebPage::database autotest failure
https://bugs.webkit.org/show_bug.cgi?id=28961

Make sure that the test case enables the feature before
the feature gets tested

tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::database):

12:15 AM Changeset in webkit [48040] by eric@webkit.org

5 edits in trunk

2009-09-04 Yaar Schnitman <yaar@chromium.org>

Reviewed by Eric Seidel.

Two bugs:

https://bugs.webkit.org/show_bug.cgi?id=25489
CSS property background-position is now serialized in shorthand string as
background-position-x background-position-y, as the specification requires
(See http://www.w3.org/TR/2008/WD-css3-background-20080910/#the-background-position).

https://bugs.webkit.org/show_bug.cgi?id=26541
CSS background-color is now be serialized before other background properties,
as CSS specification requires (See http://dev.w3.org/csswg/cssom/#css-value).

An existing layout test that accepted wrong order and skipped position test
had to be modified.

fast/dom/background-shorthand-csstext-expected.txt:
fast/dom/background-shorthand-csstext.html:

2009-09-04 Yaar Schnitman <yaar@chromium.org>

Reviewed by Eric Seidel.

Two bugs:

https://bugs.webkit.org/show_bug.cgi?id=25489
CSS property background-position is now serialized in shorthand string as
background-position-x background-position-y, as the specification requires
(See http://www.w3.org/TR/2008/WD-css3-background-20080910/#the-background-position).

https://bugs.webkit.org/show_bug.cgi?id=26541
CSS background-color is now be serialized before other background properties,
as CSS specification requires (See http://dev.w3.org/csswg/cssom/#css-value).

An existing layout test that accepted wrong order and skipped position test
had to be modified.

css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):

12:07 AM Changeset in webkit [48039] by eric@webkit.org

4 edits in trunk/WebKit/qt

2009-09-04 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Reviewed by Eric Seidel.

Any QtWebKit application crashes on exit if the inspector is
used during the session rather then exiting.

If a QWebView has a QWebPage that is destroyed the QWebView
does not update its pointer and will crash the next time
it access the page pointers (such as in its destructor).

InspectorClientView should not call deleteLater when the page
is destroyed because it does not have a parent and is a top
level widget. close() needs to be called so that QApplication
can exit the application if quitOnLastWindowClosed is set
and a InspectorClientView is the last window, otherwise
the application will never exit.

Api/qwebview.cpp: (QWebViewPrivate::_q_pageDestroyed): (QWebView::setPage):
Api/qwebview.h:
WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientView::InspectorClientView):

Sep 3, 2009:

10:24 PM Changeset in webkit [48038] by eric@webkit.org

4 edits
3 adds in trunk

2009-09-03 Kent Tamura <tkent@chromium.org>

Reviewed by David Levin.

Test for HTMLTextAreaElement.textLength
https://bugs.webkit.org/show_bug.cgi?id=28929

fast/forms/resources/textarea-textlength.js: Added.
fast/forms/textarea-textlength-expected.txt: Added.
fast/forms/textarea-textlength.html: Added.

2009-09-03 Kent Tamura <tkent@chromium.org>

Reviewed by David Levin.

Add support for HTMLTextAreaElement.textLength
https://bugs.webkit.org/show_bug.cgi?id=28929

Test: fast/forms/textarea-textlength.html

html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::textLength):
html/HTMLTextAreaElement.idl:

5:27 PM Changeset in webkit [48037] by ap@apple.com

3 edits
3 adds in trunk

Reviewed by Darin Adler.

<rdar://problem/7180197>, https://bugs.webkit.org/show_bug.cgi?id=28822
REGRESSION(r31231): Creating document with current document's DOCTYPE causes crashes

Test: fast/dom/DOMImplementation/createDocument-with-used-doctype.html

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Even though we cannot raise an exception immediately out of fear of breaking Acid3, we shouldn't use a DocumentType node in two documents.

4:57 PM Changeset in webkit [48036] by beidson@apple.com

3 edits
9 adds in trunk

WebCore: Page Cache should support pages with Frames.
https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Sam Weinig.

Tests: fast/events/pageshow-pagehide-on-back-cached-with-frames.html

fast/loader/frames-with-unload-handlers-in-page-cache.html

loader/FrameLoader.cpp:

(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):

LayoutTests: Page Cache should support pages with Frames.
https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Sam Weinig.

fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt: Added.
fast/events/pageshow-pagehide-on-back-cached-with-frames.html: Added.
fast/events/resources/pageshow-pagehide-subframe-cachable.html: Added.
fast/events/resources/pageshow-pagehide-subsubframe-cachable.html: Added.
fast/loader/frames-with-unload-handlers-in-page-cache-expected.txt: Added.
fast/loader/frames-with-unload-handlers-in-page-cache.html: Added.
fast/loader/resources/notify-done.html: Added.
fast/loader/resources/subframe-with-subsubframe-with-unload-handler.html: Added.
fast/loader/resources/subframe-with-unload-handler.html: Added.

4:23 PM Changeset in webkit [48035] by eric@webkit.org

7 edits
5 adds in trunk

2009-09-03 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by Eric Seidel.

Check that middle click triggers an onpaste event in Linux.
https://bugs.webkit.org/show_bug.cgi?id=28696

platform/gtk/editing/pasteboard: Added.
platform/gtk/editing/pasteboard/middle-click-onpaste-expected.txt: Added.
platform/gtk/editing/pasteboard/resources: Added.
platform/gtk/editing/pasteboard/resources/TEMPLATE.html: Added.
platform/gtk/editing/pasteboard/resources/middle-click-onpaste.js: Added. (handlePaste):

2009-09-03 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by Eric Seidel.

Handle middle click in Chromium like QT
https://bugs.webkit.org/show_bug.cgi?id=28696

Tested by middle-click-onpaste.html.

platform/Pasteboard.h:
platform/chromium/ChromiumBridge.h:
platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::getData):
platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::isSelectionMode): (WebCore::Pasteboard::setSelectionMode): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
platform/chromium/PasteboardPrivate.h: (WebCore::PasteboardPrivate::):

4:10 PM Changeset in webkit [48034] by beidson@apple.com

2 edits in trunk/WebCore

More partial work towards "Page Cache should support pages with Frames"
https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Sam Weinig.

Fix a bug where subframes weren't asked if they were cacheable.

No new tests, especially since page caching for frames isn't turned on yet.
A layout test will come in my next patch, which enables frames in the page cache.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::canCachePageContainingThisFrame):

4:08 PM Changeset in webkit [48033] by abarth@webkit.org

2 edits in trunk/WebKit/mac

2009-09-03 Adam Barth <abarth@webkit.org>

Unreviewed build fix.

Change notImplemented() to a FIXME.

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):

3:59 PM Changeset in webkit [48032] by abarth@webkit.org

18 edits in trunk

2009-09-03 Adam Barth <abarth@webkit.org>

Reviewed by eric@webkit.org.

https://bugs.webkit.org/show_bug.cgi?id=24696

Added mixed content methods to FrameLoaderClient.

loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didDisplayInsecureContent): (WebCore::EmptyFrameLoaderClient::didRunInsecureContent):
loader/FrameLoaderClient.h:

2009-09-03 Adam Barth <abarth@webkit.org>

Reviewed by eric@webkit.org.

https://bugs.webkit.org/show_bug.cgi?id=24696

Stub implementations of mixed content methods of FrameLoaderClient.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didDisplayInsecureContent): (WebKit::FrameLoaderClient::didRunInsecureContent):
WebCoreSupport/FrameLoaderClientGtk.h:

2009-09-03 Adam Barth <abarth@webkit.org>

Reviewed by eric@webkit.org.

https://bugs.webkit.org/show_bug.cgi?id=24696

Stub implementations of mixed content methods of FrameLoaderClient.

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):

2009-09-03 Adam Barth <abarth@webkit.org>

Reviewed by eric@webkit.org.

https://bugs.webkit.org/show_bug.cgi?id=24696

Stub implementations of mixed content methods of FrameLoaderClient.

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didDisplayInsecureContent): (WebCore::FrameLoaderClientQt::didRunInsecureContent):
WebCoreSupport/FrameLoaderClientQt.h:

2009-09-03 Adam Barth <abarth@webkit.org>

Reviewed by eric@webkit.org.

https://bugs.webkit.org/show_bug.cgi?id=24696

Stub implementations of mixed content methods of FrameLoaderClient.

WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didDisplayInsecureContent): (WebFrameLoaderClient::didRunInsecureContent):
WebCoreSupport/WebFrameLoaderClient.h:

2009-09-03 Adam Barth <abarth@webkit.org>

Reviewed by eric@webkit.org.

https://bugs.webkit.org/show_bug.cgi?id=24696

Stub implementations of mixed content methods of FrameLoaderClient.

WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::didDisplayInsecureContent): (WebCore::FrameLoaderClientWx::didRunInsecureContent):
WebKitSupport/FrameLoaderClientWx.h:

2:37 PM Changeset in webkit [48031] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-03 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Access private member variables directly instead of using the
accessor.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame): (WebKit::FrameLoaderClient::windowObjectCleared):

1:25 PM Changeset in webkit [48030] by atwilson@chromium.org

2 edits in trunk/LayoutTests

Exception.toString() on Qt seems to print out a different value than other platforms.
https://bugs.webkit.org/show_bug.cgi?id=28952

Reviewed by Dave Levin.

platform/qt/Skipped:

Disabled new worker tests that rely on the string format of DOM exceptions until bug #28952 is resolved.

12:38 PM Changeset in webkit [48029] by kevino@webkit.org

19 edits
6 adds in trunk

Reviewed by Kevin Ollivier.

[wx] Frames support
https://bugs.webkit.org/show_bug.cgi?id=19041

12:35 PM Changeset in webkit [48028] by yael.aharon@nokia.com

3 edits in trunk/WebCore

[Qt] Page content is not displayed in case of HTTP status error
https://bugs.webkit.org/show_bug.cgi?id=28949

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-03
Reviewed by Simon Hausmann.

If the server sent content, show it to the user instead of an error,
even if the HTTP status code is not success.

platform/network/qt/QNetworkReplyHandler.cpp:
platform/network/qt/QNetworkReplyHandler.h:

12:07 PM Changeset in webkit [48027] by ddkilzer@apple.com

4 edits in trunk/WebKitTools

<http://webkit.org/b/28880> svn-apply --force doesn't actually work

Reviewed by Eric Seidel.

This fixes "svn-apply --force" and adds unit tests for the
scm.apply_patch() method which uses this script.

Scripts/svn-apply: Created $globalExitCode variable that defaults to 0. Exit with a value of $globalExitCode when the script is finished. (applyPatch): Ignore a non-zero $exitCode if $force is true, but set $globalExitCode to $exitCode so that svn-apply exits with a non-zero status if any patches did not apply cleanly. Also print out the actual patch command if $force was not true.

Scripts/modules/scm.py: (scripts_directory): Added. Extracted from script_path(). (script_path): Extracted scripts_directory().
Scripts/modules/scm_unittest.py: Import urllib. (SVNTestRepository.setup): Save the original working directory in test_object since this represents the WebKit repository from where the unit tests are run. (SCMTest): Created new super class to hold utility methods. (SCMTest._create_patch): Creates a patch file on disk and a dictionary for use with scm.svn_apply(). (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink back to WebKitTools/Scripts in the test repository so that scm.apply_patch() is able to find the svn-apply script. (SVNTest): Inherit from SCMTest instead of unittest.TestCase. (SVNTest.tearDown): Make sure to change directories back to the original_path before the next test. (SVNTest.test_apply_svn_patch): New test case for applying an svn patch with scm.apply_patch(). (SVNTest.test_apply_svn_patch_force): New test case for applying an svn patch with scm.apply_patch() that conflicts. (GitTest): Inherit from SCMTest instead of unittest.TestCase. (GitTest.tearDown): Make sure to change directories back to the original_path before the next test. (GitTest.test_apply_git_patch): New test case for applying a git patch with scm.apply_patch(). (GitTest.test_apply_git_patch_force): New test case for applying a git patch with scm.apply_patch() that conflicts.

11:36 AM Changeset in webkit [48026] by atwilson@chromium.org

7 edits
2 adds in trunk/WebCore

Need to update v8 bindings to support passing multiple ports to postMessage()
https://bugs.webkit.org/show_bug.cgi?id=28839

Reviewed by Dimitri Glazkov.

Added support for passing MessagePortArray to v8 bindings.

New tests that now pass with V8:

fast/events/message-port-multi.html
fast/workers/worker-context-multi-port.html
fast/workers/worker-multi-port.html

WebCore.gypi:

Added V8MessageEventCustom.cpp and V8MessagePortCustom.h

bindings/v8/custom/V8CustomBinding.h:

Added custom postMessage() handlers for various classes.

bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::DOMWindowPostMessage):
Added custom handler that supports MessagePortArray.

bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::DedicatedWorkerContextPostMessage):
Added custom handler that supports MessagePortArray.

bindings/v8/custom/V8MessageEventCustom.cpp: Added.

(WebCore::MessageEventPorts):
Added getter for ports attribute.
(WebCore::MessageEventInitMessageEvent):
Added custom handler that supports MessagePortArray.

bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::MessagePortPostMessage):
Added custom handler that supports MessagePortArray.
(WebCore::getMessagePortArray):
Added helper function that supports converting from a sequence-like object to a MessagePortArray.

bindings/v8/custom/V8MessagePortCustom.h: Added.

Added declaration for getMessagePortArray().

bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::WorkerPostMessage):
Added custom handler that supports MessagePortArray.

11:36 AM Changeset in webkit [48025] by atwilson@chromium.org

47 edits
1 copy
12 adds in trunk

WebCore: Need to update JS bindings and IDL files to support multiple message ports in postMessage()
https://bugs.webkit.org/show_bug.cgi?id=28460

Reviewed by Sam Weinig.

Added new toJSSequence() API which validates that a JSValue meets the WebIDL criteria for a sequence.

Tests: fast/events/message-port-multi.html

fast/workers/worker-context-multi-port.html
fast/workers/worker-multi-port.html

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:

Added JSMessagePortCustom.h and JSMessageEventCustom.cpp.

bindings/js/JSDOMBinding.cpp:

(WebCore::toJSSequence):
Added toJSSequence() API to do validation on sequence-like objects per WebIDL.

bindings/js/JSDOMBinding.h:
bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::postMessage):
Added custom handler for postMessage() that handles being passed MessagePortArrays.

bindings/js/JSDedicatedWorkerContextCustom.cpp:

(WebCore::JSDedicatedWorkerContext::postMessage):
Added custom handler for postMessage() that handles being passed MessagePortArrays.

bindings/js/JSMessageEventCustom.cpp: Added.

(WebCore::JSMessageEvent::ports):
Added custom ports() getter that converts from MessagePortArray to JSArray.
(WebCore::JSMessageEvent::initMessageEvent):
Added support for passing a MessagePortArray.

bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::postMessage):
Added custom handler for postMessage() that handles being passed MessagePortArray.
(WebCore::fillMessagePortArray):
New helper routine that validates/converts from a JS sequence o a WebCore::MessagePortArray.

bindings/js/JSMessagePortCustom.h: Added.
bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorker::postMessage):
Added custom handler for postMessage() that handles being passed MessagePortArray.

dom/MessageEvent.cpp:
dom/MessageEvent.h:

(WebCore::MessageEvent::ports):
Changed ports() to return a MessagePortArray* since this value can be null.

dom/MessageEvent.idl:

Updated IDL to match HTML5 spec (now accepts MessagePortArrays instead of a solitary MessagePort).

dom/MessagePort.cpp:
dom/MessagePort.h:
dom/MessagePort.idl:

Updated IDL to match HTML5 spec (postMessage() now accepts MessagePortArrays instead of a solitary MessagePort).

page/DOMWindow.h:
page/DOMWindow.idl:

Updated IDL to match HTML5 spec (postMessage() now accepts MessagePortArrays instead of a solitary MessagePort).

workers/DedicatedWorkerContext.cpp:
workers/DedicatedWorkerContext.h:
workers/DedicatedWorkerContext.idl:

Updated IDL to match HTML5 spec (postMessage() now accepts MessagePortArrays instead of a solitary MessagePort).

workers/Worker.cpp:
workers/Worker.h:
workers/Worker.idl:

Updated IDL to match HTML5 spec (postMessage() now accepts MessagePortArrays instead of a solitary MessagePort).

LayoutTests: Need to update JS bindings and IDL files to support multiple message ports in postMessage()
https://bugs.webkit.org/show_bug.cgi?id=28460

Reviewed by Sam Weinig.

Updated layout tests to match new postMessage() and MessageEvent APIs.

Added new layout tests to test sending/receiving multiple ports.

fast/dom/Window/window-postmessage-args-expected.txt:
fast/dom/Window/window-postmessage-args.html:

Updated to match new postMessage API.

fast/events/init-events-expected.txt:
fast/events/message-channel-gc-4.html:

Updated to match new postMessage API.

fast/events/message-port-clone.html:

Updated to match new postMessage API.

fast/events/message-port-deleted-document.html:

Updated to match new postMessage API.

fast/events/message-port-deleted-frame.html:

Updated to match new postMessage API.

fast/events/message-port-inactive-document.html:

Updated to match new postMessage API.

fast/events/message-port-multi-expected.txt: Added.
fast/events/message-port-multi.html: Added.

Added tests for various cases of sending multiple ports.

fast/events/message-port.html:

Updated to match new postMessage API.

fast/events/resources/init-events.js:

Added tests for sending ports to initMessageEvent()

fast/events/resources/message-port-iframe.html:
fast/events/resources/message-port-multi.js: Added.

Added tests for various cases of sending multiple ports.

fast/workers/resources/shared-worker-common.js:

(onconnect):
Updated to reflect new MessageEvent API.

fast/workers/resources/shared-worker-script-error.js:

(onconnect):
Updated to reflect new MessageEvent API.

fast/workers/resources/worker-cloneport.js:

(onmessage):
Updated to reflect new MessageEvent API.

fast/workers/resources/worker-context-multi-port.js: Added.

(worker.onmessage):
Added tests for various cases of sending multiple ports.

fast/workers/resources/worker-context-thread-multi-port.js: Added.

Added tests for various cases of sending multiple ports.

fast/workers/resources/worker-messageport.js:

(onmessage):
Updated to reflect new MessageEvent API.

fast/workers/resources/worker-multi-port.js: Added.

(worker.onmessage):
Added tests for various cases of sending multiple ports.

fast/workers/resources/worker-thread-multi-port.js: Added.

(onmessage):
Worker-thread side of multiple port layout test.
(testPassed):
(testFailed):

fast/workers/worker-cloneport.html:
fast/workers/worker-context-multi-port-expected.txt: Added.
fast/workers/worker-context-multi-port.html: Added.

Added tests for sending multiple ports from the worker thread.

fast/workers/worker-messageport-expected.txt:
fast/workers/worker-messageport-gc.html:
fast/workers/worker-messageport.html:
fast/workers/worker-multi-port-expected.txt: Added.
fast/workers/worker-multi-port.html: Added.

9:54 AM Changeset in webkit [48024] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-09-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Do not query non-function call frames for function name.

https://bugs.webkit.org/show_bug.cgi?id=28799

inspector/front-end/InjectedScript.js: (InjectedScript.CallFrameProxy): (InjectedScript.CallFrameProxy.prototype._wrapScopeChain):

9:52 AM Changeset in webkit [48023] by sullivan@apple.com

2 edits in trunk/WebKit

StringsNotToBeLocalized.txt:

Brought this file up to date.

Reviewed by Adam Roben

9:51 AM Changeset in webkit [48022] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-09-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Crash after typing "clear" and pressing return in inspector console.

https://bugs.webkit.org/show_bug.cgi?id=28684

inspector/front-end/InjectedScript.js: (InjectedScript._clearConsoleMessages): (InjectedScript._inspectObject): (InjectedScript._ensureCommandLineAPIInstalled):

9:09 AM Changeset in webkit [48021] by vestbo@webkit.org

2 edits in trunk/LayoutTests

[Qt] Skip a couple of failing layout-tests

Rubber-stamped by Ariya Hidayat.

We skip most of the D&D tests already, and the animation test
seems to be flakey on our platform since the commit that triggered
it only touched V8 bindings.

platform/qt/Skipped:

6:56 AM Changeset in webkit [48020] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-03 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Squeezed out some performance from string conversion.
https://bugs.webkit.org/show_bug.cgi?id=28945

bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource): (WebCore::WebCoreStringResource::data): (WebCore::WebCoreStringResource::length): (WebCore::WebCoreStringResource::atomicString): (WebCore::WebCoreStringResource::string): Avoid calling virtual length method. Be more explicit with external memory computation. Avoid function calls in data and length. (WebCore::): (WebCore::v8StringToWebCoreString): (WebCore::v8StringToAtomicWebCoreString): (WebCore::v8NonStringValueToWebCoreString): (WebCore::v8NonStringValueToAtomicWebCoreString): Avoid extra calls of WebCoreStringResource::toString. When AtomicString is computed pass it immediately when constructing WebCoreStringResource. Use inline buffer for small strings.
bindings/v8/V8Binding.h: (WebCore::v8ValueToWebCoreString): (WebCore::v8ValueToAtomicWebCoreString): (WebCore::toString): Inline dispatch of string vs. non-string values.

6:49 AM Changeset in webkit [48019] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-03 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Inlined common case of V8IsolatedWorld::getEntered to speed
up V8Proxy lookup.
https://bugs.webkit.org/show_bug.cgi?id=28946

bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::getEnteredImpl):
bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::getEntered):

6:40 AM Changeset in webkit [48018] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Remove bogus asserts that break Debug builds at runtime.

WebCoreSupport/DocumentLoaderGtk.cpp: (WebKit::DocumentLoader::detachFromFrame): (WebKit::DocumentLoader::decreaseLoadCount):

5:57 AM Changeset in webkit [48017] by zoltan@webkit.org

52 edits in trunk/LayoutTests

2009-09-03 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated metrics in css2.1/t170602-bdr-conflct-w-* (50 files).
Remove these files from Skipped.

platform/qt/Skipped:
platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:

4:53 AM Changeset in webkit [48016] by zoltan@webkit.org

19 edits in trunk/LayoutTests

2009-09-03 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated metrics in css2.1/t1202-counters-* (17 files).
Remove these files from Skipped.

platform/qt/Skipped:
platform/qt/css2.1/t1202-counters-00-b-expected.txt:
platform/qt/css2.1/t1202-counters-01-b-expected.txt:
platform/qt/css2.1/t1202-counters-02-b-expected.txt:
platform/qt/css2.1/t1202-counters-03-b-expected.txt:
platform/qt/css2.1/t1202-counters-05-b-expected.txt:
platform/qt/css2.1/t1202-counters-06-b-expected.txt:
platform/qt/css2.1/t1202-counters-07-b-expected.txt:
platform/qt/css2.1/t1202-counters-08-b-expected.txt:
platform/qt/css2.1/t1202-counters-09-b-expected.txt:
platform/qt/css2.1/t1202-counters-11-b-expected.txt:
platform/qt/css2.1/t1202-counters-12-b-expected.txt:
platform/qt/css2.1/t1202-counters-13-b-expected.txt:
platform/qt/css2.1/t1202-counters-14-b-expected.txt:
platform/qt/css2.1/t1202-counters-15-b-expected.txt:
platform/qt/css2.1/t1202-counters-16-c-expected.txt:
platform/qt/css2.1/t1202-counters-17-d-expected.txt:
platform/qt/css2.1/t1202-counters-18-f-expected.txt:

3:50 AM Changeset in webkit [48015] by vestbo@webkit.org

2 edits in trunk/LayoutTests

[Qt] Disable a few tests that require new controller features

Reviewed by Ariya Hidayat.

platform/qt/Skipped:

3:44 AM Changeset in webkit [48014] by vestbo@webkit.org

1 edit
3 adds in trunk/LayoutTests

[Qt/Linux] Add platform-spesific result for plugin-javascript-access

Rubber-stamped by Simon Hausmann..

platform/qt-linux/plugins/plugin-javascript-access-expected.txt: Added.

2:47 AM Changeset in webkit [48013] by zoltan@webkit.org

18 edits in trunk/LayoutTests

2009-09-03 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated metrics in css2.1/t140201* (16 files).
Remove these files from Skipped.

platform/qt/Skipped:
platform/qt/css2.1/t140201-c532-bgcolor-00-a-expected.txt:
platform/qt/css2.1/t140201-c532-bgcolor-01-b-expected.txt:
platform/qt/css2.1/t140201-c533-bgimage-00-a-expected.txt:
platform/qt/css2.1/t140201-c533-bgimage-01-b-g-expected.txt:
platform/qt/css2.1/t140201-c534-bgre-00-b-ag-expected.txt:
platform/qt/css2.1/t140201-c534-bgre-01-b-ag-expected.txt:
platform/qt/css2.1/t140201-c534-bgreps-00-c-ag-expected.txt:
platform/qt/css2.1/t140201-c534-bgreps-01-c-ag-expected.txt:
platform/qt/css2.1/t140201-c534-bgreps-02-c-ag-expected.txt:
platform/qt/css2.1/t140201-c534-bgreps-03-c-ag-expected.txt:
platform/qt/css2.1/t140201-c534-bgreps-04-c-ag-expected.txt:
platform/qt/css2.1/t140201-c534-bgreps-05-c-ag-expected.txt:
platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
platform/qt/css2.1/t140201-c536-bgpos-00-b-ag-expected.txt:
platform/qt/css2.1/t140201-c536-bgpos-01-b-ag-expected.txt:
platform/qt/css2.1/t140201-c537-bgfxps-00-c-ag-expected.txt:

2:38 AM Changeset in webkit [48012] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-09-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

Add strnstr for Linux and Windows in StringExtras.h
https://bugs.webkit.org/show_bug.cgi?id=28901

wtf/StringExtras.h: (strnstr):

2:29 AM Changeset in webkit [48011] by eric@webkit.org

8 edits
6 adds in trunk

2009-09-03 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Tests for maxLength and IME input.
https://bugs.webkit.org/show_bug.cgi?id=25253

fast/forms/input-maxlength-ime-completed-expected.txt: Added.
fast/forms/input-maxlength-ime-completed.html: Added.
fast/forms/input-maxlength-ime-preedit-expected.txt: Added.
fast/forms/input-maxlength-ime-preedit.html: Added.
fast/forms/resources/input-maxlength-ime-completed.js: Added.
fast/forms/resources/input-maxlength-ime-preedit.js: Added.
platform/gtk/Skipped:
platform/win/Skipped:

2009-09-03 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Fix a regression bug that maxLength doesn't work for IME input.
https://bugs.webkit.org/show_bug.cgi?id=25253

Tests: fast/forms/input-maxlength-ime-completed.html

fast/forms/input-maxlength-ime-preedit.html

dom/InputElement.cpp: (WebCore::InputElement::handleBeforeTextInsertedEvent):
dom/InputElement.h:
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):

2:12 AM Changeset in webkit [48010] by eric@webkit.org

3 edits
3 adds in trunk

2009-09-03 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Make SVGStyleElement title/media/type setters do something
https://bugs.webkit.org/show_bug.cgi?id=28828

svg/dom/resources/style-reflect.js: Added.
svg/dom/style-reflect-expected.txt: Added.
svg/dom/style-reflect.html: Added.

2009-09-03 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

Make SVGStyleElement title/media/type setters do something
https://bugs.webkit.org/show_bug.cgi?id=28828

Test: svg/dom/style-reflect.html

svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::setXmlspace): Actually change the attribute. (WebCore::SVGStyleElement::setType): Ditto. (WebCore::SVGStyleElement::setMedia): Ditto. (WebCore::SVGStyleElement::setTitle): Ditto.

2:08 AM Changeset in webkit [48009] by vestbo@webkit.org

3 edits in trunk/WebKitTools

[Qt] Add support for platform-spesific layout-test results

Reviewed by Mark Rowe.

For the Qt port we use the qt-[mac|linux|win] directories and then fall
back to the generic qt directory for both test results and skipped list.

Scripts/run-webkit-tests:
Scripts/webkitdirs.pm:

2:04 AM Changeset in webkit [48008] by eric@webkit.org

3 edits
2 adds in trunk

2009-09-03 Ben Murdoch <benm@google.com>

https://bugs.webkit.org/show_bug.cgi?id=28872
Test to verify statement error callbacks behave as expected when they return true or throw an exception.

storage/statement-error-callback-expected.txt: Added with properties svn:eol-style.
storage/statement-error-callback.html: Added with properties svn:eol-style.

2009-09-03 Ben Murdoch <benm@google.com>

https://bugs.webkit.org/show_bug.cgi?id=28872

Fixes a bug where handleEvent() in the V8 Custom SQL Statement Error binding would not return the correct result to WebCore after invoking the callback.

Test: storage/statement-error-callback.html

bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8CustomSQLStatementErrorCallback::handleEvent): Return true from handleEvent() if the callback raised an exception or the callback itself returned true.

1:57 AM Changeset in webkit [48007] by eric@webkit.org

4 edits in trunk/WebKit/qt

2009-09-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Add a setting to turn SessionStorage on/off
https://bugs.webkit.org/show_bug.cgi?id=28836

Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
Api/qwebsettings.h:
tests/qwebpage/tst_qwebpage.cpp: (testFlag): (tst_QWebPage::testOptionalJSObjects):

1:50 AM Changeset in webkit [48006] by eric@webkit.org

1 edit
3 adds in trunk/WebCore

2009-09-03 Maxime Simon <Maxime Simon>

Reviewed by Eric Seidel.

[Haiku] Adding three font-specific files to WebCore:
FontCustomPlatformData.cpp, FontCustomPlatformData.h,
and FontPlatformData.h
https://bugs.webkit.org/show_bug.cgi?id=28131

platform/graphics/haiku/FontCustomPlatformData.cpp: Added. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
platform/graphics/haiku/FontCustomPlatformData.h: Added. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
platform/graphics/haiku/FontPlatformData.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::bold): (WebCore::FontPlatformData::oblique): (WebCore::FontPlatformData::hashTableDeletedFontValue):

12:14 AM Changeset in webkit [48005] by zoltan@webkit.org

2 edits in trunk/JavaScriptCore

2009-09-03 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's HashEntry class
https://bugs.webkit.org/show_bug.cgi?id=27830

Inherits HashEntry class from FastAllocBase because it has been
instantiated by 'new' JavaScriptCore/runtime/Lookup.cpp:32.

runtime/Lookup.h:

Sep 2, 2009:

7:31 PM Changeset in webkit [48004] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-09-02 Laurent Cerveau <lcerveau@me.com>

Reviewed by David Kilzer.

<http://webkit.org/b/25517> build-webkit script should print build time at end

Scripts/build-webkit: Added startTime and endTime variable so that the build time is computed and printed as part of the build message; display formatting has been separated in a dedicated subroutine.

6:44 PM Changeset in webkit [48003] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root

Reviewed by Eric Seidel.

Scripts/VCSUtils.pm: (determineSvnRoot): Added back check for repository root that was removed in r46134 when this code lived in svn-create-patch. It's necessary to check both the repository root and the repository UUID in case two different working directories are checked out from the same repository.

6:10 PM Changeset in webkit [48002] by timothy@apple.com

2 edits in trunk/WebKitTools

Use new 512x512 icons for nightly builds.

Rubber-stamped by Mark Rowe.

WebKitLauncher/webkit.icns:

5:55 PM Changeset in webkit [48001] by beidson@apple.com

5 edits in trunk/WebCore

More partial work towards "Page Cache should support pages with Frames"
https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Darin Adler.

No new tests. (No change in behavior, current tests pass).

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopLoading): Adopt the new enum form for FrameLoader::stopLoading().

loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading): Take an enum to decide whether to dispatch no unload events,

only unload, or unload and pagehide.

(WebCore::FrameLoader::closeURL):
(WebCore::FrameLoader::scheduleRedirection):
(WebCore::FrameLoader::cachePageForHistoryItem): Call pageHidden().
(WebCore::FrameLoader::pageHidden): Add to dispatch the pagehide event to all frames in the case

where a page is added to the PageCache.

loader/FrameLoader.h:

loader/FrameLoaderTypes.h: Add an UnloadEventPolicy enum.

5:18 PM Changeset in webkit [48000] by barraclough@apple.com

3 edits in trunk/JavaScriptCore

Should crash if JIT code buffer allocation fails.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-09-02
https://bugs.webkit.org/show_bug.cgi?id=28926
<rdar://problem/7031922>

jit/ExecutableAllocatorPosix.cpp:

(JSC::ExecutablePool::systemAlloc):

jit/ExecutableAllocatorWin.cpp:

(JSC::ExecutablePool::systemAlloc):

5:07 PM Changeset in webkit [47999] by beidson@apple.com

8 edits in trunk

WebCore: More partial work towards "Page Cache should support pages with Frames"
https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Darin Adler.

More CachedFrame destruction work.
Including related Frame and FrameLoader changes and cleanup.

No new tests. (No change in behavior, current tests pass).

history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): Rebuild up the whole FrameTree when restoring.
(WebCore::CachedFrame::CachedFrame): Tear down the entire FrameTree when caching.
(WebCore::CachedFrame::destroy): For child frames that are being destroyed while in

the PageCache, do lightweight cleanup to:
A - Prevent referring to a stale Page object.
B - Prevent World Leaks of WebKit objects.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopAllLoaders): stopAllLoaders() should never be called on Frames that are

in the PageCache. ASSERT that fact.

(WebCore::FrameLoader::open): Remove a bogus release-build workaround, as the comment right above it

explains it is not effective, and it'd be better to see the crash locally instead of downstream.

(WebCore::FrameLoader::closeAndRemoveChild): Make sure the owner element has a page pointer before

referencing it.

(WebCore::FrameLoader::detachFromParent): Use the new detachViewsAndDocumentLoader() call
(WebCore::FrameLoader::detachViewsAndDocumentLoader): Does lightweight cleanup of client (WebKit) objects.

loader/FrameLoader.h:

page/Frame.cpp:

(WebCore::Frame::detachFromPage): Simply clear the Page pointer without doing any other work.
(WebCore::Frame::pageDestroyed): Use the new detachFromPage().

page/Frame.h:

WebKit/mac: More partial work towards "Page Cache should support pages with Frames"
https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Darin Adler.

WebView/WebHTMLView.mm:

(-[WebHTMLView _topHTMLView]): Rework the ASSERT in this method to reflect the

reality of calling this method for pages currently in the PageCache.

4:41 PM Changeset in webkit [47998] by jshin@chromium.org

2 edits in trunk/WebCore

2009-09-02 Jungshik Shin <jshin@chromium.org>

Reviewed by Dimitri Glazkov

[Chromium] Add 'icu::' qualifier in preparation for ICU upgrade to 4.2
in Chromium. This is to fix a new file added in r28742 since the
last patch for this issue.

https://bugs.webkit.org/show_bug.cgi?id=28410

No change in the test result.

platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::getNormalizedTextRun):

4:01 PM Changeset in webkit [47997] by kevino@webkit.org

2 edits in trunk/WebKitTools

waf build fix. Remove local variable shadowing global.

3:21 PM Changeset in webkit [47996] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-09-02 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Correct a typo to fix bustage, caused by r47991.
https://bugs.webkit.org/show_bug.cgi?id=27933

platform/graphics/skia/ImageBufferSkia.cpp: Changed "Unpremultipled" to "Unmultiplied".

2:31 PM Changeset in webkit [47995] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-09-02 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Add a missing include to fix bustage, caused by r47991.
https://bugs.webkit.org/show_bug.cgi?id=27933

platform/graphics/skia/ImageBufferSkia.cpp: Added SkColorPriv include.

2:30 PM Changeset in webkit [47994] by jianli@chromium.org

2 edits in trunk/WebCore

[Chromium] Implement file support for DragData.
https://bugs.webkit.org/show_bug.cgi?id=28896

Reviewed by Dimitri Glazkov.

platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::containsCompatibleContent):

2:07 PM Changeset in webkit [47993] by kevino@webkit.org

2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Protect libcurl shared data with Mutex objects via curl_set_share_opt.
https://bugs.webkit.org/show_bug.cgi?id=28920

1:45 PM Changeset in webkit [47992] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-02 Evan Stade <estade@chromium.org>

Reviewed by Eric Seidel.

Expose functions to change the focus ring color for Linux Chromium

https://bugs.webkit.org/show_bug.cgi?id=28887

rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::setFocusRingColor): (WebCore::RenderThemeChromiumLinux::platformFocusRingColor):
rendering/RenderThemeChromiumLinux.h:

1:38 PM Changeset in webkit [47991] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-02 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

SVG Filter premultiplied color support for getImageDate/putImageData
https://bugs.webkit.org/show_bug.cgi?id=27933

Patch to get premultiplied color support for Skia on getImageDate/putImageData.

platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::putImageData):

1:23 PM Changeset in webkit [47990] by beidson@apple.com

4 edits in trunk/WebCore

Forget to rename openInFrameloader() to open(), which was requested in Darin's review of my last patch.

history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore):
(WebCore::CachedFrame::open):

history/CachedFrame.h:
history/CachedPage.cpp:

(WebCore::CachedPage::restore):

1:16 PM Changeset in webkit [47989] by beidson@apple.com

7 edits in trunk/WebCore

In http://trac.webkit.org/changeset/47943 I added new header dependencies to FrameLoader.h.
Removing them is a little trouble, but worth it going forward.
The pattern of creating a "CachedFrameBase" as the interface CachedFrame provides to FrameLoader
was suggested by Darin Adler.

Reviewed by Darin Adler.

No new tests. (No change in behavior)

Make CachedFrame inherit privately from CachedFrameBase, which becomes the interface FrameLoader uses:

history/CachedFrame.cpp:

(WebCore::CachedFrameBase::CachedFrameBase):
(WebCore::CachedFrameBase::~CachedFrameBase):
(WebCore::CachedFrameBase::restore):
(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::openInFrameLoader):

history/CachedFrame.h:

(WebCore::CachedFrameBase::document):
(WebCore::CachedFrameBase::view):
(WebCore::CachedFrameBase::domWindow):
(WebCore::CachedFrame::create):
(WebCore::CachedFrame::documentLoader):
(WebCore::CachedFrame::mousePressNode):

Call the new ::openInFrameLoader() method on the CachedFrame, as CachedFrameBase is now the only
thing capable of interacting with FrameLoader::open(CachedFrameBase):

history/CachedPage.cpp:

(WebCore::CachedPage::restore):

history/CachedPage.h:

(WebCore::CachedPage::documentLoader):

Make ::open(CachedFrame) public, and change it to ::open(CachedFrameBase):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::open):

loader/FrameLoader.h:

1:13 PM Changeset in webkit [47988] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

2009-09-02 Zan Dobersek <zandobersek@gmail.com>

Reviewed by David Kilzer.

Calls exitStatus function from the main package where it is also defined.

Scripts/VCSUtils.pm:

1:13 PM Changeset in webkit [47987] by rniwa@webkit.org

3 edits
3 adds in trunk

WebCore: Cannot pres Enter to escape from bulleted list when <ul> is a child of <li>.
https://bugs.webkit.org/show_bug.cgi?id=24866

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-09-02
Reviewed by Eric Seidel.

This patch modifies breakOutOfEmptyListItem to break out of a properly nested list
(a list to break out of is inside another list item).

When the empty list item appears at the end of another list item, WebKit breaks out of
the outer list item, and adds new item below the outer list item.
Otherwise, WebKit breaks out of the the inner list item and inserts new paragraph.

Test: editing/execCommand/break-out-of-empty-list-item.html

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):

LayoutTests: Cannot press Enter to escape from bulleted list when <ul> is a child of <li>.
https://bugs.webkit.org/show_bug.cgi?id=24866

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-09-02
Reviewed by Eric Seidel.

This patch adds a test to make sure WebKit break out of an empty list item.

editing/execCommand/break-out-of-empty-list-item-expected.txt: Added.
editing/execCommand/break-out-of-empty-list-item.html: Added.
editing/execCommand/resources/break-out-of-empty-list-item.js: Added.

(pressKey):
(enterAtTarget):
(testBreakOutOfEmptyListItem):

12:55 PM Changeset in webkit [47986] by ap@apple.com

3 edits in trunk/LayoutTests

Reviewed by Brady Eidson.

Fix the test to pass on Tiger.

Tiger's ICU decodes the invalid text differently. Moved it inside the comment - this also
matches the original from the Web better.

fast/encoding/japanese-encoding-mix-expected.txt:
fast/encoding/japanese-encoding-mix.html:

12:32 PM Changeset in webkit [47985] by beidson@apple.com

5 edits in trunk/WebCore

More partial work towards "Page Cache should support pages with Frames"
https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Sam Weinig.

This patch is primarily about the "CachedFrame tree" and making slightly different decisions
based on whether a CachedFrame is the main frame or a subframe.

Store whether a CachedFrame represents the main frame or a subframe.
"Chop off the frame tree" for the main frame when creating its CachedFrame, as main frames are reused and need to start new page loads with an empty frame tree.
Reattach the frame tree to the main frame when restoring it.
open() the cached subframes in their respective loaders when restoring.
Properly clear() and destroy() cached subframes.
When committing to a new page load, and after caching the previous page, only clear the FrameView for the main frame.

Note that all of above will eventually be necessary as I continue to land this work in pieces,
but doesn't actually change any behavior right now because we still refuse to even *try* to
cache pages with frames.

No new tests. No change in behavior, and current tests continue to pass.

history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::restore):
(WebCore::CachedFrame::clear):
(WebCore::CachedFrame::destroy):

history/CachedFrame.h:

(WebCore::CachedFrame::isMainFrame):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::open):

loader/FrameLoader.h:

11:32 AM Changeset in webkit [47984] by beidson@apple.com

2 edits in trunk/WebCore

No review, build fix.

http://trac.webkit.org/changeset/47976 broke the build.
Let's try compiling before we land things, shall we?

platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::SimpleFontData): Order the initialization list correctly.

11:28 AM Changeset in webkit [47983] by kevino@webkit.org

11 edits in trunk

waf build fixes for Windows/MSVC and Mac/Snow Leopard.

11:14 AM Changeset in webkit [47982] by benm@google.com

2 edits in trunk/WebCore

Unreviewed build fix for Chromium.

Missed #including V8Proxy.h in WebCore/bindings/v8/V8Binding.cpp.

bindings/v8/V8Binding.cpp: add V8Proxy.h as an include

11:03 AM Changeset in webkit [47981] by kevino@webkit.org

2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

wx port: Call WTF::initializeThreading().
https://bugs.webkit.org/show_bug.cgi?id=28912

10:41 AM Changeset in webkit [47980] by kevino@webkit.org

2 edits in trunk/WebCore

waf build fix, don't define symbols we now grab from other sources.

10:39 AM Changeset in webkit [47979] by kevino@webkit.org

2 edits in trunk/JavaScriptCore

Build fix for building on Windows.

10:34 AM Changeset in webkit [47978] by kevino@webkit.org

3 edits in trunk/WebCore

Build fixes for PluginViewNone.cpp and a wx build fix for PluginView.cpp.

10:32 AM Changeset in webkit [47977] by kevino@webkit.org

2 edits in trunk/WebKit/wx

wx build fix. Use the 2 param KURL constructor.

10:10 AM Changeset in webkit [47976] by yong.li@torchmobile.com

3 edits in trunk/WebCore

2009-09-02 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by Eric Seidel.

Fix the build failure of WebKit for Linux/Qt when WML is enabled

No test cases needed since this just fixes the build problem.

wml/WMLElement.cpp: (WebCore::WMLElement::create):
wml/WMLTableElement.cpp: (WebCore::WMLTableElement::joinSuperflousColumns): (WebCore::WMLTableElement::padWithEmptyColumns):

9:37 AM Changeset in webkit [47975] by yong.li@torchmobile.com

5 edits in trunk/WebCore

2009-09-02 Yong Li <yong.li@torchmobile.com>

Reviewed by Adam Barth.

WINCE PORT: use shared buffer for custom font data
https://bugs.webkit.org/show_bug.cgi?id=27734

Refactored by Joe Mason <joe.mason@torchmobile.com>

loader/CachedFont.cpp: add WINCE to platforms using cached custom data
platform/graphics/opentype/OpenTypeUtilities.cpp: (WebCore::renameFont): implement for WinCE
platform/graphics/opentype/OpenTypeUtilities.h: build fixes
platform/graphics/wince/FontCustomPlatformData.cpp: (WebCore::setCustomFontCache): add accessor (WebCore::createFontCustomPlatformData): change param to SharedBuffer
platform/graphics/wince/FontCustomPlatformData.h: update function signatures

9:32 AM Changeset in webkit [47974] by yong.li@torchmobile.com

5 edits in trunk/WebCore

2009-09-02 Yong Li <yong.li@torchmobile.com>

Reviewed by Adam Barth.

WINCE PORT: font-related build fixes and minor bugfixes
https://bugs.webkit.org/show_bug.cgi?id=27734

platform/graphics/FontCache.h: declare functions added in https://bugs.webkit.org/show_bug.cgi?id=27509
platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): fix ambiguous overload error in min/max on Windows
platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): initialize member vars
platform/graphics/SimpleFontData.h: disable unused members on Wince to save space

8:54 AM Changeset in webkit [47973] by abarth@webkit.org

6 edits in trunk/WebCore

2009-09-02 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

Another pass at releasing the storage mutex.
https://bugs.webkit.org/show_bug.cgi?id=28904

Another pass at releasing the storage mutex (when applicable) when we finish
executing JavaScript. http://dev.w3.org/html5/spec/Overview.html#storage-mutex
describes the required behavior.

As it turns out, https://bugs.webkit.org/show_bug.cgi?id=28789 didn't solve
the problem correctly. First of all, I missed that events and timeouts go
through a different call path. Second of all, I didn't consider recursion
correctly. Third of all, my check to see if LocalStorage is alive actually
instantiates it if it isn't yet. Fourth, I forgot DOM_STORAGE guards around
it. So I'm reverting that change completely and doing it more cleanly.
Unfortunately, the solution isn't as portable (and thus I've left out the JSC
implementation for now).

NOTE: This change now tracks recursion on function callbacks in V8. I ran this
by Mads Ager and Mike Belshe and they seemed to think adding the checks were
fine. Most callbacks are asynchronous and thus wouldn't be nested. The few
scenareos where you can have nested callbacks probably should have always been
protected by a recursion guard.

Unfortunately, this can't be tested without a hook added to the layout test
controllers since the lock is (by design) not supposed to be observable by
JavaScript. https://bugs.webkit.org/show_bug.cgi?id=28906

bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): revert
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): revert
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::runScript):

Add releaseStorageMutex call. A small amount of clean up.

(WebCore::V8Proxy::callFunction):

Add releaseStorageMutex call. A small amount of clean up.

(WebCore::V8Proxy::releaseStorageMutex):

Check to see if localStorage has been instantiated. If so, tell it to
unlock all storage areas.

bindings/v8/V8Proxy.h:
page/PageGroup.h: (WebCore::PageGroup::hasLocalStorage): Make hasLocalStorage public.

8:48 AM Changeset in webkit [47972] by kevino@webkit.org

4 edits in trunk/WebKitTools

Reviewed by Eric Seidel.

Changes needed for build-webkit to support the waf build system for the wx port.

https://bugs.webkit.org/show_bug.cgi?id=27619

8:24 AM Changeset in webkit [47971] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts

Reviewed by Eric Seidel.

Scripts/update-webkit: Added "--accept postpone" to @svnOptions when running with svn-1.6 or newer.

8:24 AM Changeset in webkit [47970] by ddkilzer@apple.com

5 edits in trunk/WebKitTools

Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()

Reviewed by Eric Seidel.

Scripts/VCSUtils.pm: (@EXPORT): Added &isSVNVersion16OrNewer. (svnVersion): Added. Internal method that gets the SVN version and caches it. (isSVNVersion16OrNewer): Added. Method that does the SVN 1.6 version check.
Scripts/prepare-ChangeLog: Switched to use new isSVNVersion16OrNewer() method.
Scripts/resolve-ChangeLogs: Ditto.
Scripts/svn-create-patch: Ditto.

8:24 AM Changeset in webkit [47969] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

Clean up VCSUtils.pm

Reviewed by Eric Seidel.

Scripts/VCSUtils.pm: Added proper package statement. Fixed indentation of BEGIN block. Listed each exported method on a line by itself. Added methods to the export list after adding the package statement. Sorted module variables. Moved definiton of $gitRoot next to other module variables.

8:19 AM Changeset in webkit [47968] by abarth@webkit.org

1 edit
2 adds in trunk/WebCore

2009-09-02 Yong Li <yong.li@torchmobile.com>

Reviewed by Adam Barth.

WINCE PORT: Implement ImageBuffer for WINCE
Implement Image interface with a light class BufferedImage
for rendering ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=28167

platform/graphics/wince/ImageBufferData.h: Added.
platform/graphics/wince/ImageBufferWince.cpp: Added.

7:24 AM Changeset in webkit [47967] by vestbo@webkit.org

8 edits in trunk/WebCore

Join the various PluginView destructors into one shared implementation

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27706

The Qt port used to delete the platform plugin widget as the last step.
Now this is done before cleaning up the script objects and unloading the
plugin package, similar to how the Win port does it.

plugins/PluginView.cpp:
plugins/PluginViewNone.cpp:
plugins/gtk/PluginViewGtk.cpp:
plugins/mac/PluginViewMac.cpp:
plugins/qt/PluginViewQt.cpp:
plugins/win/PluginViewWin.cpp:

6:50 AM Changeset in webkit [47966] by vestbo@webkit.org

8 edits in trunk/WebCore

Share PluginView::init() between ports

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27706

The port-spesific bits are moved to platformStart(), which now returns
a bool based on the success of the platformStart.

m_hasPendingGeometryChange is now initialized in the initializer list
instead of in PluginViewQt's init()

PluginViewMac (currently used only by the Qt port) used to manually call
stop() in the case where an unsupported drawing or event model was detected.
This was wrong, as the m_status and m_isStarted fields should be used to
guard against doing operations on a plugin in this intermediate state.

plugins/PluginView.cpp:
plugins/PluginView.h:
plugins/PluginViewNone.cpp:
plugins/gtk/PluginViewGtk.cpp:
plugins/mac/PluginViewMac.cpp:
plugins/qt/PluginViewQt.cpp:
plugins/win/PluginViewWin.cpp:

6:06 AM Changeset in webkit [47965] by jmalonzo@webkit.org

5 edits
1 add in trunk

2009-09-02 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez and Gustavo Noronha.

[Gtk] Implement a WebDataSource for the gtk port
https://bugs.webkit.org/show_bug.cgi?id=24758

Add data source API getters to WebKitWebFrame.
Also add WebKitWebDataSource unit test.

tests/testwebdatasource.c: Added.
webkit/webkitwebframe.cpp:
webkit/webkitwebframe.h:

Add WebKitWebDataSource unit test to the build script

GNUmakefile.am:

5:58 AM Changeset in webkit [47964] by jmalonzo@webkit.org

8 edits
4 adds in trunk

2009-09-02 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez and Gustavo Noronha.

[Gtk] Implement a WebDataSource for the gtk port
https://bugs.webkit.org/show_bug.cgi?id=24758

Subclass DocumentLoader for Gtk and implement it under the WebKit
namespace. Add WebKitWebDataSource implementation that closely
follows the mac implementation of the API.

WebCoreSupport/DocumentLoaderGtk.cpp: Added.
WebCoreSupport/DocumentLoaderGtk.h: Added.
webkit/webkitwebdatasource.cpp: Added.
webkit/webkitwebdatasource.h: Added.

Add WebKitWebDataSource and DocumentLoaderGtk to the build script.

GNUmakefile.am:

5:40 AM Changeset in webkit [47963] by vestbo@webkit.org

3 edits in trunk/WebKit/qt

[Qt] Make sure we relayout the page after evaluating JS

Patch by Richard Moore <rich@kde.org> on 2009-09-02
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=28235

QtWebKit does not always seem to reflow the page when evaluating
javascript. This patch changes the way evaluateJavaScript works to
use the frameloader which ensures that this is done properly.

Api/qwebframe.cpp:

(QWebFrame::evaluateJavaScript):

tests/qwebframe/tst_qwebframe.cpp:

4:38 AM Changeset in webkit [47962] by benm@google.com

7 edits in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=28737

Patch by Ben Murdoch <benm@google.com> on 2009-09-02
Update JavaScript bindings in JSC and V8 for SQLTransaction to throw exceptions in the right places.

bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql): Throw an exception if no parameters are passed to executeSql().

bindings/v8/V8Binding.cpp:

(WebCore::v8ValueToWebCoreString): Catch an exception if thrown from toString().

bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL): Allow "arrayish objects" to be passed to executeSql.

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=28737

Patch by Ben Murdoch <benm@google.com> on 2009-09-02
Update the execute-sql-args.html to be agnostic to exception message formatting between JSC and V8 and throw an exception when no parameters are passed to the executeSql() function.

storage/execute-sql-args-expected.txt:
storage/execute-sql-args.html:

3:16 AM Changeset in webkit [47961] by vestbo@webkit.org

4 edits in trunk

[Qt] Fix layout-test plugins/plugin-javascript-access.html

Rubber-stamped by Simon Hausmann.

DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
platform/qt/Skipped:

2:59 AM Changeset in webkit [47960] by pfeldman@chromium.org

6 edits in trunk/WebCore

2009-09-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Migrate Databases tab to InjectedScript /
serialized interaction.

https://bugs.webkit.org/show_bug.cgi?id=28873

inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::handleEvent):
inspector/front-end/Database.js: (WebInspector.Database.prototype.isDB): (WebInspector.Database.prototype.runWithTableNames.sortingCallback): (WebInspector.Database.prototype.runWithTableNames): (WebInspector.Database.prototype.executeSql): (WebInspector.Database.prototype.executeSql.errorCallback): (WebInspector.Database.prototype.executeSql.queryTransaction):
inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._enterKeyPressed): (WebInspector.DatabaseQueryView.prototype._queryFinished):
inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView):
inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.selectDatabase): (WebInspector.StoragePanel.prototype.updateDatabaseTables.withTableNames): (WebInspector.StoragePanel.prototype.updateDatabaseTables): (WebInspector.DatabaseSidebarTreeElement.prototype.onpopulate.withTableNames): (WebInspector.DatabaseSidebarTreeElement.prototype.onpopulate):

2:49 AM Changeset in webkit [47959] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2009-09-02 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Eric Seidel.

Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled

RegisterFile constructor currently throws #error when both
MMAP and VIRTUALALLOC conditions fail.
On any platform that does not provide these features
(for instance, Symbian),
the fallback should be regular malloc (or fastMalloc).
It is functionally equivalent in this case, even though it may
have certain drawbacks such as lack of dynamic pre-allocation.

interpreter/RegisterFile.cpp: (JSC::RegisterFile::~RegisterFile):
interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile):

2:46 AM Changeset in webkit [47958] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-09-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed (trivial followup fix).

Web Inspector: Trivial follow up fix to r47944.

https://bugs.webkit.org/show_bug.cgi?id=28800

inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::nodeForId):

2:44 AM Changeset in webkit [47957] by zoltan@webkit.org

24 edits in trunk/LayoutTests

2009-09-02 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update css2.1/t1202-counter-* and css2.1/t1205* tests after new metrics.
Remove these files from Skipped (and fixed Skipped according to Changeset 47815).

platform/qt/Skipped:
platform/qt/css2.1/t1202-counter-00-b-expected.txt:
platform/qt/css2.1/t1202-counter-01-b-expected.txt:
platform/qt/css2.1/t1202-counter-02-b-expected.txt:
platform/qt/css2.1/t1202-counter-03-b-expected.txt:
platform/qt/css2.1/t1202-counter-04-b-expected.txt:
platform/qt/css2.1/t1202-counter-05-b-expected.txt:
platform/qt/css2.1/t1202-counter-06-b-expected.txt:
platform/qt/css2.1/t1202-counter-07-b-expected.txt:
platform/qt/css2.1/t1202-counter-08-b-expected.txt:
platform/qt/css2.1/t1202-counter-09-b-expected.txt:
platform/qt/css2.1/t1202-counter-11-b-expected.txt:
platform/qt/css2.1/t1202-counter-12-b-expected.txt:
platform/qt/css2.1/t1202-counter-13-b-expected.txt:
platform/qt/css2.1/t1202-counter-14-b-expected.txt:
platform/qt/css2.1/t1202-counter-15-b-expected.txt:
platform/qt/css2.1/t1202-counter-16-f-expected.txt:
platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.txt:
platform/qt/css2.1/t1205-c563-list-type-00-b-expected.txt:
platform/qt/css2.1/t1205-c563-list-type-01-b-expected.txt:
platform/qt/css2.1/t1205-c564-list-img-00-b-g-expected.txt:
platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.txt:
platform/qt/css2.1/t1205-c566-list-stl-01-c-g-expected.txt:

1:08 AM Changeset in webkit [47956] by eric@webkit.org

5 edits
2 moves
1 add in trunk

2009-09-02 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

js tests should move into jstests subdirectory instead of resources/
https://bugs.webkit.org/show_bug.cgi?id=25880

make-script-wrappers supports both resources and script-tests directories.
run-webkit-tests ignores files in script-tests.
Move script tests of animations to check the new script is working.

animations/animation-css-rule-types.html:
animations/resources/TEMPLATE.html: Removed.
animations/resources/animation-css-rule-types.js: Removed.
animations/script-tests: Added.
animations/script-tests/TEMPLATE.html: Copied from LayoutTests/animations/resources/TEMPLATE.html.
animations/script-tests/animation-css-rule-types.js: Copied from LayoutTests/animations/resources/animation-css-rule-types.js.

2009-09-02 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

js tests should move into jstests subdirectory instead of resources/
https://bugs.webkit.org/show_bug.cgi?id=25880

make-script-wrappers supports both resources and script-tests directories.
run-webkit-tests ignores files in script-tests.
Move script tests of animations to check the new script is working.

Scripts/make-script-test-wrappers:
Scripts/run-webkit-tests:

1:01 AM Changeset in webkit [47955] by eric@webkit.org

5 edits in trunk/WebKitTools

2009-09-02 Szabo Carol <carol.szabo@nokia.com>

Reviewed by David Levin.

check-webkit-style uses python from /usr/bin instead of the PATH
https://bugs.webkit.org/show_bug.cgi?id=28225

Scripts/bugzilla-tool:
Scripts/check-webkit-style:
Scripts/run-webkit-unittests:
Scripts/update-sources-list.py: Changed the first line from #!/usr/bin/python to #!/usr/bin/env python which causes python to be invoked from the path location returned by "which python" when any of these scripts are launched. these are currently all the python scripts in WebKitTools/Scripts.

Sep 1, 2009:

10:03 PM Changeset in webkit [47954] by bweinstein@apple.com

5 edits in trunk

2009-09-01 Brian Weinstein <bweinstein@apple.com>

Reviewed by John Sullivan.

Added a new case to aria-readonly.html to account for textareas instead of just input fields.

accessibility/aria-readonly-expected.txt:
accessibility/aria-readonly.html:

2009-09-01 Brian Weinstein <bweinstein@apple.com>

Reviewed by John Sullivan.

Fixed a bug in handling of isReadOnly, where textareas were casted to HTMLInputElements.

accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isReadOnly):

7:26 PM Changeset in webkit [47953] by ddkilzer@apple.com

3 edits in trunk/WebKitTools

<http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards

Reviewed by Adam Barth.

Scripts/modules/scm.py: (Git.commit_ids_from_commitish_arguments): Reverse the list of commits returned from git-rev-list since we always want to post the oldest patches first to bugs.webkit.org.
Scripts/modules/scm_unittest.py: (run): Added return statement to return the output now that we want it sometimes. (SVNTestRepository._setup_test_commits): Added a fourth commit so the GitTest.test_commitish_order() test has more commits to work with. (GitTest.test_commitish_order): Added unit test for change to Git.commit_ids_from_commitish_arguments() in scm.py.

5:38 PM Changeset in webkit [47952] by eric@webkit.org

6 edits
1 add in trunk/WebCore

2009-09-01 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=28047
add utility method to enable logging messages for inspector development

manual test case added (see below)

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype.toString):
inspector/front-end/inspector.css:
inspector/front-end/inspector.js: (WebInspector.log):
manual-tests/inspector/webinspector-log.html: Added.
page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix):
page/Console.h: (WebCore::):

5:15 PM Changeset in webkit [47951] by eric@webkit.org

1 edit
1 move in trunk/LayoutTests

2009-09-01 Eric Seidel <eric@webkit.org>

Rubber stamped by Simon Fraser.

REGRESSION: media/video-source-add-src.html (and other media tests?) crashing/timing-out intermittently
https://bugs.webkit.org/show_bug.cgi?id=28845

Disabling this test on all platforms until
a media expert can have a chance to look at it.
See bug 28845 for further discussion.

media/video-source-add-src.html-disabled: Renamed from LayoutTests/media/video-source-add-src.html.

5:06 PM Changeset in webkit [47950] by ap@apple.com

3 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21990
When a rare EUC-JP character is present, explicitly (and correctly) labelled EUC-JP document
is mistreated as Shift_JIS

<rdar://problem/5828506> Safari should not try auto-detecting if charset information exists

WebKit used to unconditionally auto-detect document encoding if it was one of Japanese ones.
This didn't really match any browser, and did cause problems on some sites.

Our detector is very quick to label an EUC-JP page as Shift_JIS if it notices a byte that
cannot be part of EUC-JP source. However, such bytes do appear in Web pages sometimes,
especially in comments. Also, some valid EUC-JP sequences are not known to it.

Some pages that are fixed by this change:

<rdar://problem/5934750> Encoding in incorrect at http://cocodeparis.blog45.fc2.com/. This
page has incorrect encoding in title, so no browser displays it 100% fine. We now match
Firefox and IE.

<rdar://problem/6007713> The web page http://www.sf.us.emb-japan.go.jp/top.htm is garbled
in Safari. There is a stray byte in comments that was makes charset detector think it can't
be EUC-JP.

<rdar://problem/6965711> A Japanese web page www.nippontv.studiolegend.tv is garbled in
Safari. Many comments on this page are encoded as Shift_JIS - IE magically displays that
fine in View Source mode (it doesn't seem to have an ability to switch between EUC-JP and
Shift_JIS in normal HTML view though).

Test: fast/encoding/japanese-encoding-mix.html

loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::decode): Only invoke auto- detection if there is no solid charset information yet.

4:07 PM Changeset in webkit [47949] by ddkilzer@apple.com

4 edits in trunk/WebKitTools

<http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed

Reviewed by David Levin.

The mark-fixed subcommand is for those times when you don't use
bugzilla-tool to commit a patch, but you want to use it to close
the bug with a committed-revision message.

Scripts/bugzilla-tool: (bug_comment_from_svn_revision): Added. Extracted from bug_comment_from_commit_text(). (bug_comment_from_commit_text): Extracted bug_comment_from_svn_revision() from this method. (MarkBugFixed.init): Added. (MarkBugFixed._fetch_commit_log): Added. Retrieves the commit log from the last commit if no svn revision is specified, else the commit log for the specified svn revision. (MarkBugFixed._determine_bug_id_and_svn_revision): Added. Attempts to determine the bug id and svn revision if one or both were not defined on the command line. (MarkBugFixed.execute): Added. Adds a comment about the revision that fixed the bug and closes the bug. (BugzillaTool.init): Added mark-fixed subcommand.
Scripts/modules/bugzilla.py: (Bugzilla.fetch_title_from_bug): Added. Returns the title of a bug given a bug id.
Scripts/modules/scm.py: (SCM.strip_r_from_svn_revision): Added. Utility method to strip the leading 'r' from an svn revision. (SCM.svn_commit_log): Added. Subclasses must override. (SCM.last_svn_commit_log): Added. Subclasses must override. (SVN.svn_commit_log): Added. Returns svn log for a given revision. (SVN.last_svn_commit_log): Added. Uses svnversion to find the last commit in an svn working directory and then runs svn log. (Git.svn_commit_log): Added. Returns svn log for a given revision. (Git.last_svn_commit_log): Added. Runs git-svn-log with a limit of one log message.

1:18 PM Changeset in webkit [47948] by Dimitri Glazkov

3 edits in trunk/LayoutTests

2009-09-01 Victor Wang <victorw@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=28879

Fix fast/dom/StyleSheet/ownerNode-lifetime-2.html
The problem is WebKit <link> nodes will only have a
style sheet created if they have href attribute.
The src attribute to non-existant css doesn't work.
Change src to href to make this test works in WebKit.

Also update the expectation result.

fast/dom/StyleSheet/ownerNode-lifetime-2-expected.txt:
fast/dom/StyleSheet/ownerNode-lifetime-2.html:

1:16 PM Changeset in webkit [47947] by jianli@chromium.org

4 edits
1 add in trunk/WebCore

[V8] FileList cannot be accessed via index in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=28883

Reviewed by Dimitri Glazkov.

Tested by clipboard-file-access.html.

WebCore.gypi:
bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getTemplate):

bindings/v8/custom/V8CustomBinding.h:
bindings/v8/custom/V8FileListCustom.cpp: Added.

12:52 PM Changeset in webkit [47946] by jhoneycutt@apple.com

9 edits in trunk/WebCore

Remove the workaround added in r47316.

Reviewed by Sam Weinig.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::AXObjectCache):

accessibility/AXObjectCache.h:

Remove the Document argument to the AXObjectCache constructor and the
m_document member variable, and replace the no-parameter
handleFocusedUIElementChanged() with the two-parameter GTK function.
(WebCore::AXObjectCache::handleFocusedUIElementChanged):

accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::handleFocusedUIElementChanged):

accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::handleFocusedUIElementChanged):

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(fallbackObject):
Don't pass a null Document when constructing the AXObjectCache.

accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::handleFocusedUIElementChanged):

accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::handleFocusedUIElementChanged):
Get the document from the RenderObject; m_document was removed.

dom/Document.cpp:

(WebCore::Document::axObjectCache):
Don't pass the Document when constructing the AXObjectCache.
(WebCore::Document::setFocusedNode):
Pass the old and new focused RenderObjects when calling
handleFocusedUIElementChanged().

11:42 AM Changeset in webkit [47945] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/28880> svn-apply --force doesn't actually work

Reviewed by Brady Eidson.

Scripts/svn-apply: (applyPatch): Add "--force" to $options arrayref if $force is set.

11:17 AM Changeset in webkit [47944] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-09-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Check that InspectorDOMAgent and InspectorFrontend are not null
before accessing them in InspectorBackend. They may be null if
InspectorController is closed before an asynchronous operation is
started.

https://bugs.webkit.org/show_bug.cgi?id=28800

inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getCookies): (WebCore::InspectorBackend::getChildNodes): (WebCore::InspectorBackend::setAttribute): (WebCore::InspectorBackend::removeAttribute): (WebCore::InspectorBackend::setTextNodeValue): (WebCore::InspectorBackend::highlight): (WebCore::InspectorBackend::nodeForId): (WebCore::InspectorBackend::pushNodePathToFrontend): (WebCore::InspectorBackend::addNodesToSearchResult): (WebCore::InspectorBackend::selectDatabase): (WebCore::InspectorBackend::selectDOMStorage): (WebCore::InspectorBackend::inspectorDOMAgent): (WebCore::InspectorBackend::inspectorFrontend):
inspector/InspectorBackend.h:

11:13 AM Changeset in webkit [47943] by beidson@apple.com

8 edits in trunk/WebCore

Page Cache should support pages with frames
https://bugs.webkit.org/show_bug.cgi?id=13631

Reviewed by Sam Weinig.

Things learned in the full task that this patch addresses:

The notions of clearing a CachedFrame and destroying a CachedFrame were two concepts that needed to be managed separately.
Once we start restoring pages with multiple CachedFrames, we'll have to be calling FrameLoader::open(CachedFrame&) multiple times with different CachedFrames, and this process will be guided by the CachedFrames themselves.

No new tests. (No change in behavior, current layout tests pass)

history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::~CachedFrame):
(WebCore::CachedFrame::clear): Only clear pointers out.
(WebCore::CachedFrame::destroy): Perform the destructive cleanup work here - Things that shouldn't

occur simply by navigating back to a page with a CachedFrame.

history/CachedFrame.h:

history/CachedPage.cpp:

(WebCore::CachedPage::~CachedPage):
(WebCore::CachedPage::restore): Call clear() after restoring.
(WebCore::CachedPage::clear):
(WebCore::CachedPage::destroy):

history/CachedPage.h:

history/PageCache.cpp:

(WebCore::PageCache::releaseAutoreleasedPagesNow): destroy() CachedPages that are being pruned,

instead of clearing them.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad): Let the CachedPage clear() itself after restoring.
(WebCore::FrameLoader::open): Don't ::open() the CachedFrame, as the CachedPage does that now.

loader/FrameLoader.h: Add the friending so CachedPage and CachedFrame can better guide the process. Even though CachedFrame::restore() isn't used for now, it will be soon.

11:06 AM Coding Style Guidelines edited by berkeley@ptc.com

(diff)

11:00 AM Changeset in webkit [47942] by benm@google.com

3 edits in trunk/WebCore

Add a "lowMemoryNotification" method to the V8 ScriptController class.
This is needed in order to allow the host application (Android Web browser in this case)
to call the v8::V8::LowMemoryNotification() method added to V8 in
http://code.google.com/p/v8/source/detail?spec=svn2777&r=2725

Patch by Andrei Popescu <andreip@google.com> on 2009-09-01
Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=28776

bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::lowMemoryNotification):

bindings/v8/ScriptController.h:

9:39 AM Changeset in webkit [47941] by abarth@webkit.org

9 edits
1 add in trunk/WebCore

2009-09-01 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Adam Barth.

V8 Bindings for WebSocket API.
https://bugs.webkit.org/show_bug.cgi?id=28844

bindings/v8/DOMObjectsInclude.h:
bindings/v8/DerivedSourcesAllInOne.cpp:
bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
bindings/v8/V8DOMWrapper.h:
bindings/v8/V8Index.cpp:
bindings/v8/V8Index.h:
bindings/v8/WorkerContextExecutionProxy.cpp:
bindings/v8/custom/V8CustomBinding.h:
bindings/v8/custom/V8WebSocketCustom.cpp: Added.

9:35 AM Changeset in webkit [47940] by Adam Roben

4 edits in trunk/WebKit/win

Post a notification when a WebView is closing

This is useful for situations where some code wants to react to the
WebView closing but isn't in charge of the WebView and can't otherwise
be notified. This notification could replace
IWebUIDelegatePrivate::webViewClosing if we decide that the
notification system isn't too burdensome.

<http://webkit.org/b/28875>

Reviewed by John Sullivan.

Interfaces/IWebViewPrivate.idl: Added the

WebViewWillCloseNotification string constant.

WebKit.vcproj/WebKit.vcproj: Link against comsuppw.lib in all

configurations so that we can use _bstr_t.

WebView.cpp:

(WebView::close): Post the WebViewWillCloseNotification.

9:17 AM Changeset in webkit [47939] by pkasting@chromium.org

2 edits in trunk/WebCore

Unreviewed (build fix).

Missed a "." -> "->" conversion.

platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::ReadContext::ReadContext):

9:12 AM Changeset in webkit [47938] by pkasting@chromium.org

3 edits in trunk/WebCore

Unreviewed (build fix).

Try to fix Qt build, take 2. The Qt code had what looks like a
broken virtual function override.

platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::ReadContext::ReadContext):
(WebCore::ImageDecoderQt::setData):

platform/graphics/qt/ImageDecoderQt.h:

9:09 AM Changeset in webkit [47937] by abarth@webkit.org

2 edits in trunk/WebCore

2009-09-01 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Uninitialized variable in XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=28874

One ought to initialize variables before use even when it doesn't
matter. No behavior change.

page/XSSAuditor.h: (WebCore::XSSAuditor::CachingURLCanonicalizer::CachingURLCanonicalizer):

8:57 AM Changeset in webkit [47936] by pkasting@chromium.org

2 edits in trunk/WebCore

Unreviewed (build fix).

Try to fix Qt build.

platform/graphics/ImageSource.cpp:

8:50 AM Changeset in webkit [47935] by pkasting@chromium.org

4 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=27965
Eliminate most of ImageSourceQt.cpp in favor of ImageSource.cpp.

Reviewed by Eric Seidel.

WebCore.pro:
platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::frameHasAlphaAtIndex):

platform/graphics/qt/ImageSourceQt.cpp:

(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameHasAlphaAtIndex):
(WebCore::ImageSource::frameIsCompleteAtIndex):

7:58 AM Changeset in webkit [47934] by pfeldman@chromium.org

4 edits in trunk/WebCore

2009-09-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Make InjectedScript self-contained (move necessary
methods from utilities.js into InjectedScript).

https://bugs.webkit.org/show_bug.cgi?id=28871

inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.generateStylesheet):
inspector/front-end/InjectedScript.js: (InjectedScript._ensureCommandLineAPIInstalled.inspectObject): (InjectedScript._ensureCommandLineAPIInstalled): (InjectedScript.pushNodeToFrontend): (InjectedScript.createProxyObject): (Object.type): (Object.hasProperties): (Object.className): (String.prototype.escapeCharacters):
inspector/front-end/utilities.js:

7:41 AM Changeset in webkit [47933] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-09-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: console log message repeat count double.

https://bugs.webkit.org/show_bug.cgi?id=28856

inspector/front-end/InjectedScript.js: (InjectedScript._evaluateOn):

7:11 AM Changeset in webkit [47932] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch

Reviewed by Adam Roben.

When git-filter-branch has been invoked to rewrite ChangeLog
files on series of git commits, it changes directories into
.git-rewrite/t before re-running resolve-ChangeLogs. This
causes determineVCSRoot() in VCSUtils.pm to return
".git-rewrite/t", which causes that path to be prepended to all
ChangeLog paths, which results in an error like this:

error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git.
Died at WebKitTools/Scripts/resolve-ChangeLogs line 376.

The correct way to fix this is not to try to find the repository
root when invoked by git-filter-branch.

Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true, set $relativePath to '.' instead of calling chdirReturningRelativePath(determineVCSRoot()). (isInGitFilterBranch): Added. Checks for the existence of the MAPPED_PREVIOUS_COMMIT environment variable.

6:06 AM Changeset in webkit [47931] by kov@webkit.org

4 edits in trunk/WebKit/gtk

2009-09-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Avoid causing unexpected issues with window sizing when sites
disable scrollbars completely.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::scrollbarsModeDidChange):
tests/testwindow.c: (test_webkit_window_scrollbar_policy):
webkit/webkitwebframe.cpp: (webkit_web_frame_class_init):

5:50 AM Changeset in webkit [47930] by xan@webkit.org

5 edits
1 add in trunk

LayoutTests:

2009-09-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Add support for Fedora distros in the http tests
https://bugs.webkit.org/show_bug.cgi?id=28263

Add httpd conf file for Fedora.

http/conf/fedora-httpd.conf: Added.

WebKitTools:

2009-09-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Add support for Fedora distros in the http tests
https://bugs.webkit.org/show_bug.cgi?id=28263

Add detection code for Fedora distribution, and use the proper
httpd conf file when needed.

Scripts/run-webkit-httpd:
Scripts/run-webkit-tests:
Scripts/webkitdirs.pm:

5:19 AM Changeset in webkit [47929] by jmalonzo@webkit.org

6 edits
3 adds in trunk

2009-09-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez and Gustavo Noronha.

[Gtk] Implement a WebDataSource for the gtk port
https://bugs.webkit.org/show_bug.cgi?id=24758

Implement WebKitWebResource for the resource-related API for
WebKitWebDataSource.

GNUmakefile.am:

Add WebKitWebResource to the build script.

GNUmakefile.am:

5:05 AM Changeset in webkit [47928] by jmalonzo@webkit.org

5 edits in trunk

2009-09-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Eric Seidel.

[Gtk] DRT needs implementation of overridePreference
https://bugs.webkit.org/show_bug.cgi?id=28830

Unskip tests that are now working.

platform/gtk/Skipped:

Implement overridePreference.

DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): (setDefaultsToConsistentStateValuesForTesting): (runTest):
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (toWebSettingKey): (LayoutTestController::overridePreference):

4:55 AM Changeset in webkit [47927] by jmalonzo@webkit.org

4 edits in trunk

2009-09-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Mark Rowe.

[Gtk] Fix DATALIST build
https://bugs.webkit.org/show_bug.cgi?id=28826

Unskip now working fast/forms/input-list.html.

platform/gtk/Skipped:

Add ENABLE_DATALIST to FEATURE_DEFINES.

GNUmakefile.am:

4:11 AM Changeset in webkit [47926] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-01 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

SVGSVGElement suspend methods argument/return types incorrect
https://bugs.webkit.org/show_bug.cgi?id=28860

Also fix the style of the argument names.

svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::suspendRedraw): (WebCore::SVGSVGElement::unsuspendRedraw):
svg/SVGSVGElement.h:

4:01 AM Changeset in webkit [47925] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-01 Roland Steiner <rolandsteiner@google.com>

Reviewed by Eric Seidel.

Fix bug 28808: [Skia] Fix flaky layout test svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html [DEBUG]
(https://bugs.webkit.org/show_bug.cgi?id=28808)

The bug fix adds an explicit check for the validity of the path when it is
transformed into local coordinates.
This was the most suitable place I could find that didn't cause an inordinate
amount of refactoring. Also, it seems pertinent and may also catch other cases
that are not limited to clipping paths.

TEST: existing svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html

platform/graphics/skia/GraphicsContextSkia.cpp: make isPathSkiaSafe accessible (WebCore::):
platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::currentPathInLocalCoordinates): check Skia safety of path

3:54 AM Changeset in webkit [47924] by xan@webkit.org

4 edits in trunk/WebKit/gtk

2009-09-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=28842
[GTK] Do not emit extra FINISHED load-status signals

Do not emit FINISHED load-status signals on our own, just rely on
WebCore for that. Avoids emitting FINISHED several times when we
fail to load a URI.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::FrameLoaderClient::dispatchDidFailLoad):
tests/testloading.c: (web_loading_fixture_setup): (web_loading_fixture_teardown): (load_finished_cb): (status_changed_cb): (test_loading_status): (load_error_status_changed_cb): (load_error_cb): (test_loading_error): (main):
webkit/webkitwebframe.h:

3:24 AM Changeset in webkit [47923] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-09-01 Joseph Pecoraro <Joseph Pecoraro>

<http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying

Reviewed by Eric Seidel.

Jump back and forth between the repository root directory (to apply) and the
directory the script was run from (to find the patch).

Scripts/svn-apply:
Scripts/svn-unapply:

3:14 AM Changeset in webkit [47922] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-01 Yusuke Sato <yusukes@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Combining Diacritical Marks (U+0300..) are not handled correctly.
https://bugs.webkit.org/show_bug.cgi?id=28742

Normalize (NFC) a TextRun when the run contains combining diacritical marks
so that Skia can pick a correct glyph without relying on GSUB table in a font.
This change is for Chromium Linux.

platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::getTextRun): Added. (WebCore::TextRunWalker::getNormalizedTextRun): Added.

This function is called when the run contains U+0300..U+036F and converts characters in
the run to the combined form (NFC) using ICU.

3:05 AM Changeset in webkit [47921] by eric@webkit.org

5 edits in trunk/WebCore

2009-09-01 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Inlined fast paths of V8DOMWrapper::convertNodeToV8Object and
V8Proxy::createWrapperFromCache.
https://bugs.webkit.org/show_bug.cgi?id=28848

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertDocumentToV8Object): Special function for document wrapping. (WebCore::V8DOMWrapper::convertNewNodeToV8Object): Slow case of wrapping a new node.
bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertNodeToV8Object): Extracted fast path from V8DOMWrapper.cpp.
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createWrapperFromCacheSlowCase):
bindings/v8/V8Proxy.h: (WebCore::V8Proxy::createWrapperFromCache): Extracted fast path from V8Proxy.cpp.

2:34 AM Changeset in webkit [47920] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-01 Eric Seidel <eric@webkit.org>

No review, windows build fix only. Clearly I should have read the patch closer. :(

Allow excluding certain plugins from loading
https://bugs.webkit.org/show_bug.cgi?id=28677

plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::refresh):

2:31 AM Changeset in webkit [47919] by pfeldman@chromium.org

9 edits in trunk/WebCore

2009-09-01 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Implement conditional breakpoints in the Web Inspector backend
and add frontend JavaScript stubs.
https://bugs.webkit.org/show_bug.cgi?id=28846

inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::profiles): (WebCore::InspectorBackend::addBreakpoint): (WebCore::InspectorBackend::updateBreakpoint):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::BreakpointInfo::condition): (WebCore::JavaScriptDebugServer::BreakpointInfo::setCondition): (WebCore::JavaScriptDebugServer::addBreakpoint): (WebCore::JavaScriptDebugServer::breakpointInfo): (WebCore::JavaScriptDebugServer::updateBreakpoint): (WebCore::JavaScriptDebugServer::updateBreakpointInfo): (WebCore::JavaScriptDebugServer::removeBreakpoint): (WebCore::JavaScriptDebugServer::hasBreakpoint): (WebCore::JavaScriptDebugServer::clearBreakpoints):
inspector/JavaScriptDebugServer.h: (WebCore::JavaScriptDebugServer::BreakpointInfo::BreakpointInfo):
inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.get id): (WebInspector.Breakpoint.prototype.get condition): (WebInspector.Breakpoint.prototype.set condition):
inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.addScript):

2:13 AM Changeset in webkit [47918] by eric@webkit.org

3 edits
1 add in trunk/WebCore

2009-09-01 Marius Renn <damarvy@gmail.com>

Reviewed by Eric Seidel.

Added delegate to PluginDatabase to disable loading certain plugins.
This is useful when you want to load from the standard plugin
directory, but want to exclude certain plugins. Plugins may be
excluded early on by name, so that no plugin code is executed (which
may have caused a crash).

plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::PluginDatabase): (WebCore::PluginDatabase::refresh):
plugins/PluginDatabase.h: (WebCore::PluginDatabase::setClient):
plugins/PluginDatabaseClient.h: Added. (WebCore::PluginDatabaseClient::~PluginDatabaseClient):

Aug 31, 2009:

8:45 PM Changeset in webkit [47917] by beidson@apple.com

2 edits in trunk/WebCore

Rubberstamped by Sam Weinig

WebCore.base.exp: Removed an unneeded symbol export.

6:34 PM Changeset in webkit [47916] by kov@webkit.org

7 edits in trunk

WebCore

2009-08-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=28466
When downloading a file, two GET requests are sent to the HTTP server

Can't think of a way to test this.

loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources): only nullify the handle's client when it is the ResourceLoader, to support the case in which a download API uses a different client

WebKit/gtk

2009-08-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=28466
When downloading a file, two GET requests are sent to the HTTP server

Support reusing a connection that is already ongoing, instead of
cancelling the connection and creating another.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::download):
webkit/webkitdownload.cpp: (webkit_download_new_with_handle): (webkit_download_start):
webkit/webkitprivate.h:
webkit/webkitwebview.cpp: (webkit_web_view_request_download):

4:44 PM Changeset in webkit [47915] by bweinstein@apple.com

5 edits in trunk

2009-08-31 Brian Weinstein <bweinstein@apple.com>

Reviewed by Darin Adler.

Text Fields and Text Areas are reported as read-only by inspect32.exe.
https://bugs.webkit.org/show_bug.cgi?id=28854

Added another case in AcccessibiltyRenderObject::isReadOnly to test if text fields
and texts areas are read-only.

accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isReadOnly): (WebCore::AccessibilityRenderObject::canSetValueAttribute):

2009-08-31 Brian Weinstein <bweinstein@apple.com>

Reviewed by Darin Adler.

Added a case to check for readonly and non-readonly set through the readonly attribute
instead of through aria-readonly. This tests our new case in AccessibilityRenderObject::isReadOnly.

accessibility/aria-readonly-expected.txt:
accessibility/aria-readonly.html:

4:40 PM Changeset in webkit [47914] by atwilson@chromium.org

12 edits in trunk

WebCore: fast/workers/worker-lifecycle.html crashes intermittently on snowleopard
https://bugs.webkit.org/show_bug.cgi?id=28795

Reviewed by Alexey Proskuryakov.

Changed WorkerContext::close() to no longer stop the worker thread.
It is now the parent's responsibility to shut down the worker thread when it is notified that the context is closed.

workers/AbstractWorker.cpp:

Updated dispatchScriptErrorEvent to pass-through the "handled" value from dispatchEvent(), to allow event handlers added with addEventListener() to mark events as handled.

workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::workerContextClosed):
Now shuts down the worker thread when notified that the context is closed.
(WebCore::SharedWorkerProxy::close):
Now handles being invoked when the context is already in the process of shutting down.

workers/WorkerContext.cpp:

(WebCore::WorkerContext::close):
No longer calls WorkerThread::stop() to avoid race conditions with shutting down the thread while the parent is still interacting with it.

workers/WorkerContext.h:

(WebCore::WorkerContext::isClosing):
isClosing() is now public so WorkerRunLoop can call it to determine whether to process tasks.

workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerExceptionTask::performTask):
Error events should still be delivered even if the worker thread is closing.
Also fixed problem where error events were not dispatched if error handlers were added via addEventListener().
(WebCore::WorkerTerminateTask::create):
New task that invokes terminateWorkerContext() on the parent thread when the context is closed.
(WebCore::WorkerTerminateTask::WorkerTerminateTask):
(WebCore::WorkerTerminateTask::performTask):
(WebCore::WorkerMessagingProxy::workerContextClosed):
Now fires off a WorkerTerminateTask to shut down the thread when the context is closed.

workers/WorkerMessagingProxy.h:

WorkerMessagingProxy now overrides workerContextClosed().

workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::runInMode):
Now drops tasks on the floor if the WorkerContext is closing.

LayoutTests: fast/workers/worker-lifecycle.html crashes intermittently on snowleopard
https://bugs.webkit.org/show_bug.cgi?id=28795

Reviewed by Alexey Proskuryakov.

Removed worker-lifecycle.html from the list of Skipped tests since it no longer crashes.
Added test for case where we capture script errors via an event listener added via addEventListener().

fast/workers/worker-script-error.html
fast/workers/worker-script-error-expected.txt

Added testScriptErrorAddEventListener to test catching script errors via addEventListener().

platform/mac-snowleopard/Skipped:

4:36 PM Changeset in webkit [47913] by Beth Dakin

2 edits in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

Meant to update these results with my earlier check-in, but I
forgot!

platform/mac/fast/inspector/style-expected.txt:

4:30 PM Changeset in webkit [47912] by ojan@chromium.org

4 edits in trunk/WebCore

Not reviewed (build fix)

Build fix for Chromium to match r49707.

bindings/v8/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::ScriptCallFrame):

bindings/v8/ScriptSourceCode.h:

(WebCore::ScriptSourceCode::ScriptSourceCode):

platform/KURLGoogle.cpp:

(WebCore::KURL::KURL):
(WebCore::blankURL):

4:01 PM Changeset in webkit [47911] by ap@apple.com

2 edits in trunk/WebKit/gtk

Gtk build fix.

This is also a behavior fix, at least on debug builds - a caller of
webkit_web_history_item_new_with_data() could pass an URL that could cause an assertion
failure in KURL.

webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_new_with_data): Pass a null KURL as base to parse properly.

3:49 PM Changeset in webkit [47910] by ap@apple.com

3 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=28858
Element.baseURI parses xml:base attribute incorrectly

Test: fast/dom/base-attribute-parsing.xhtml

dom/Element.cpp: (WebCore::Element::baseURI): Avoid assertion failure (no change in release mode).

3:27 PM Changeset in webkit [47909] by Dimitri Glazkov

4 edits in trunk

WebCore:

2009-08-31 Dimitri Glazkov <Dimitri Glazkov>

Reverting http://trac.webkit.org/changeset/47904, because it caused
layout test failure.

Test: fast/dom/Window/new-window-opener.html

WebKit/mac:

2009-08-31 Dimitri Glazkov <Dimitri Glazkov>

Reverting http://trac.webkit.org/changeset/47904, because it caused
layout test failure.

3:09 PM Changeset in webkit [47908] by mrowe@apple.com

2 edits
2 deletes in trunk/WebKit

Remove WebViewEditingContextMenu.nib and WebViewEditingContextMenuOld.nib.

Rubber-stamped by Beth Dakin.

We stopped using these back in r18592 when we switched over to context menus
driven by WebCore.

English.lproj/WebViewEditingContextMenu.nib/classes.nib: Removed.
English.lproj/WebViewEditingContextMenu.nib/info.nib: Removed.
English.lproj/WebViewEditingContextMenu.nib/objects.nib: Removed.
English.lproj/WebViewEditingContextMenuOld.nib/classes.nib: Removed.
English.lproj/WebViewEditingContextMenuOld.nib/info.nib: Removed.
English.lproj/WebViewEditingContextMenuOld.nib/objects.nib: Removed.
WebKit.xcodeproj/project.pbxproj:

3:07 PM Changeset in webkit [47907] by ap@apple.com

50 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=28852
Rename KURL single argument constructor to avoid confusion

platform/KURL.h: The constructor that used to be single argument should now be invoked as KURL(ParsedURLString, myString).

3:05 PM Changeset in webkit [47906] by Beth Dakin

22 edits
2 deletes in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=28635 [CSS3
Backgrounds and Borders] Add support for 2-keyword values for
background-repeat

Reviewed by Darin Adler.

This patch allows background-repeat to take two values by making
background-repeat just like background-position internally. There
is a little extra legwork for background-repeat because the spec
indicates that its computed value should be equivalent to how it
was specified. I keep track of the specified thing by setting the
implicit flag whenever background-repeat is defined with only one
value (since internally, we now store this as 2 values.)

Here we can't access the implicit flag, so for backwards-
compatibility's sake, we always return one value when that makes
sense.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::fillRepeatToCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

Here we check for the implicit flag and return one value when it is
set.

css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::getPropertyValue):
(WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
(WebCore::CSSMutableStyleDeclaration::cssText):

Add support for CSSPropertyBackgroundRepeatX and
CSSPropertyBackgroundRepeatY

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseFillProperty):

css/CSSParser.h:

Get rid of mappings to RepeatXFill and RepeatYFill since we don't
need those parts of the EFillRepeat enum anymore.

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFillRepeat):

Add CSSPropertyBackgroundRepeatX and CSSPropertyBackgroundRepeatY

css/CSSPropertyLonghand.cpp:

(WebCore::initShorthandMap):

Add background-repeat-x and -y.

css/CSSPropertyNames.in:

Break repeat into x and y.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapFillRepeatX):
(WebCore::CSSStyleSelector::mapFillRepeatY):

css/CSSStyleSelector.h:

There is no more RepeatXFill. Instead, look for
fillLayer->repeatX() == RepeatFill

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

Break m_repeat into m_repeatX and m_repeatY

rendering/style/FillLayer.cpp:

(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::operator=):
(WebCore::FillLayer::operator==):
(WebCore::FillLayer::fillUnsetProperties):
(WebCore::FillLayer::cullEmptyLayers):

rendering/style/FillLayer.h:

(WebCore::FillLayer::repeatX):
(WebCore::FillLayer::repeatY):
(WebCore::FillLayer::isRepeatXSet):
(WebCore::FillLayer::isRepeatYSet):
(WebCore::FillLayer::setRepeatX):
(WebCore::FillLayer::setRepeatY):
(WebCore::FillLayer::clearRepeatX):
(WebCore::FillLayer::clearRepeatY):
(WebCore::FillLayer::initialFillRepeatX):
(WebCore::FillLayer::initialFillRepeatY):

Again, break backgroundRepeat into backgroundRepeatX and
backgroundRepeatY

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::backgroundRepeatX):
(WebCore::InheritedFlags::backgroundRepeatY):
(WebCore::InheritedFlags::maskRepeatX):
(WebCore::InheritedFlags::maskRepeatY):

We don't need RepeatXFill or RepeatYFill. Now that we store two
values, they are represented by Repeat-NoRepeat and NoRepeat-
Repeat, respectively.

rendering/style/RenderStyleConstants.h:

(WebCore::):

LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=28635 [CSS3
Backgrounds and Borders] Add support for 2-keyword values for
background-repeat

Reviewed by Darin Adler.

This test is updated to test for two values.

fast/backgrounds/repeat/parsing-background-repeat-expected.txt:
fast/backgrounds/repeat/resources/parsing-background-repeat.js:

These tests are updated to reflect new order.

fast/css/background-position-serialize-expected.txt:
fast/css/remove-shorthand-expected.txt:

Reflect new order in results, and make the test dump as text.

fast/inspector/style.html:
platform/mac/fast/inspector/style-expected.checksum: Removed.
platform/mac/fast/inspector/style-expected.png: Removed.
platform/mac/fast/inspector/style-expected.txt:

2:00 PM Changeset in webkit [47905] by Simon Fraser

3 edits
4 adds in trunk

2009-08-31 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Compositing layer size needs to take into account software reflections on children.
https://bugs.webkit.org/show_bug.cgi?id=28837

When computing the bounds of a composited layer, take software-rendered
reflections into account.

Test: compositing/reflections/reflection-in-composited.html

rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds):

1:37 PM Changeset in webkit [47904] by Dimitri Glazkov

4 edits in trunk

WebCore:

2009-08-31 Mark Mentovai <mark@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=28614

Perform a layout prior to checking whether the scrollbar modes are
off, on, or automatic. The modes may change during layout.

platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):

WebKit/mac:

2009-08-31 Mark Mentovai <mark@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=28614

Perform a layout prior to checking whether the scrollbar modes are
off, on, or automatic. The modes may change during layout.

WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView updateScrollers]):

1:15 PM Changeset in webkit [47903] by eric@webkit.org

8 edits
1 add in trunk/WebCore

2009-08-31 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Inspector Request Headers Should Show Data Sent With Request
https://bugs.webkit.org/show_bug.cgi?id=22920

Manual test added - see below.

English.lproj/localizedStrings.js:
inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateRequest): (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject):
inspector/InspectorResource.h:
inspector/front-end/Resource.js: (WebInspector.Resource):
inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._refreshURL): (WebInspector.ResourceView.prototype._refreshQueryString): (WebInspector.ResourceView.prototype._refreshFormData): (WebInspector.ResourceView.prototype._refreshRequestPayload): (WebInspector.ResourceView.prototype._refreshParms): (WebInspector.ResourceView.prototype._toggleURLdecoding): (WebInspector.ResourceView.prototype._getHeaderValue): (WebInspector.ResourceView.prototype._refreshRequestHeaders):
inspector/front-end/inspector.css:
inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.updateResource):
manual-tests/inspector/display-form-data.html: Added.

12:31 PM Changeset in webkit [47902] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

Fixed typo.
https://bugs.webkit.org/show_bug.cgi?id=28691

Patch by Robert Agoston <Agoston.Robert@stud.u-szeged.hu> on 2009-08-31
Reviewed by Gavin Barraclough.

parser/Parser.h:

(JSC::Parser::parse):

12:01 PM Changeset in webkit [47901] by Simon Fraser

3 edits in trunk/LayoutTests

2009-08-31 Simon Fraser <Simon Fraser>

Followup from r47877; add test for the Obj-C wrapper class for WebkitCSSTransformValue
https://bugs.webkit.org/show_bug.cgi?id=27727

platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
platform/mac/fast/dom/wrapper-classes-objc.html:

11:37 AM Changeset in webkit [47900] by Simon Fraser

3 edits
8 adds in trunk

2009-08-28 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Fix positioning error when a compositing, absolutely-positioned element has an ancestor with opacity.
https://bugs.webkit.org/show_bug.cgi?id=28754

For absolutely-positioned layers, convertToLayerCoords() jumps to the positioned
ancestor, since the layer x and y are relative to that ancestor. However, this could
skip over the ancestorLayer, thus giving the wrong result.

Fix by duplicating the enclosingPositionedAncestor() logic in convertToLayerCoords(),
and checking for ancestorLayer along the way. If found, compute offset of both to
the enclosingPositionedAncestor() and subtract.

This also fixes a positioning bug with abs. positioned elements in reflections,
so there is a new reflection test with a pixel result.

Tests: compositing/geometry/abs-position-inside-opacity.html

fast/reflections/abs-position-in-reflection.html

rendering/RenderLayer.cpp: (WebCore::isPositionedContainer): (WebCore::RenderLayer::enclosingPositionedAncestor): (WebCore::RenderLayer::enclosingTransformedAncestor): (WebCore::RenderLayer::convertToLayerCoords):

11:12 AM Changeset in webkit [47899] by Adam Roben

2 edits in trunk/WebKitTools

Fall back to a Release version of Safari if a Debug one doesn't exist

<http://webkit.org/b/28849>

Reviewed by Sam Weinig.

Scripts/webkitdirs.pm:

(safariPath): If the user is working with a Debug build, but there's
no Debug version of Safari present, fall back to using a Release
version of Safari.

10:54 AM Changeset in webkit [47898] by Adam Roben

2 edits in trunk/WebKitTools

Make safariPath() work for Debug builds of Safari on Windows

<http://webkit.org/b/28849>

Reviewed by Sam Weinig.

Scripts/webkitdirs.pm:

(safariPath): If the user is working with a Debug build, add the
_debug suffix to Safari.exe.

10:20 AM Changeset in webkit [47897] by pfeldman@chromium.org

7 edits in trunk/WebCore

2009-08-31 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: pass call frames into the frontend as a part of
pausedScript event.

https://bugs.webkit.org/show_bug.cgi?id=28847

inspector/InspectorController.cpp: (WebCore::InspectorController::didPause):
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::pausedScript):
inspector/InspectorFrontend.h:
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.debuggerPaused):
inspector/front-end/inspector.js: (WebInspector.pausedScript):

8:06 AM Changeset in webkit [47896] by Adam Roben

4 edits in trunk/WebKit/win

Give WebKit clients access to the window features specified in window.open

Reviewed by Steve Falkenburg.

COMVariantSetter.h: Added COMVariantSetters for bool and float.

Interfaces/IWebUIDelegatePrivate.idl: Added IWebUIDelegatePrivate2,

which contains a new version of createWebViewWithRequest that also
passes the window features as an IPropertyBag. This is analagous to
the -createWebViewWithRequest:windowFeatures: method added to
WebUIDelegate on Mac in r27452. Also added key strings for use with
the window features property bag.

WebCoreSupport/WebChromeClient.cpp:

(createWindowFeaturesPropertyBag): Added this helper function to turn
a WebCore::WindowFeatures into an IPropertyBag for passing to WebKit
clients.
(WebChromeClient::createWindow): If the UI delegate implements
IWebUIDelegatePrivate2, call the new createWebViewWithRequest function
that takes a window features property bag. If the delegate doesn't
implement the new function, fall back to the old functions.

8:05 AM Changeset in webkit [47895] by Adam Roben

2 edits in trunk/WebKit/win

A little clean-up in WebChromeClient::createWindow

Reviewed by Steve Falkenburg.

WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::createWindow): Refactored to share more code between
the dialog and non-dialog cases.

5:50 AM Changeset in webkit [47894] by zoltan@webkit.org

14 edits in trunk/LayoutTests

2009-08-31 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated font metrics in the remaining css1 tests. All tests pass.

platform/qt/Skipped:
platform/qt/css1/text_properties/letter_spacing-expected.txt:
platform/qt/css1/text_properties/line_height-expected.txt:
platform/qt/css1/text_properties/text_align-expected.txt:
platform/qt/css1/text_properties/text_decoration-expected.txt:
platform/qt/css1/text_properties/text_indent-expected.txt:
platform/qt/css1/text_properties/text_transform-expected.txt:
platform/qt/css1/text_properties/vertical_align-expected.txt:
platform/qt/css1/text_properties/word_spacing-expected.txt:
platform/qt/css1/units/color_units-expected.txt:
platform/qt/css1/units/length_units-expected.txt:
platform/qt/css1/units/percentage_units-expected.txt:
platform/qt/css1/units/urls-expected.txt:

5:15 AM Changeset in webkit [47893] by zoltan@webkit.org

14 edits in trunk/LayoutTests

2009-08-31 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update font metrics for these css1 tests.

platform/qt/Skipped:
platform/qt/css1/formatting_model/canvas-expected.txt:
platform/qt/css1/formatting_model/floating_elements-expected.txt:
platform/qt/css1/formatting_model/height_of_lines-expected.txt:
platform/qt/css1/formatting_model/horizontal_formatting-expected.txt:
platform/qt/css1/formatting_model/inline_elements-expected.txt:
platform/qt/css1/formatting_model/replaced_elements-expected.txt:
platform/qt/css1/formatting_model/vertical_formatting-expected.txt:
platform/qt/css1/pseudo/anchor-expected.txt:
platform/qt/css1/pseudo/firstletter-expected.txt:
platform/qt/css1/pseudo/firstline-expected.txt:
platform/qt/css1/pseudo/multiple_pseudo_elements-expected.txt:
platform/qt/css1/pseudo/pseudo_elements_in_selectors-expected.txt:

5:09 AM Changeset in webkit [47892] by vestbo@webkit.org

2 edits in trunk/WebCore

[Qt] Un-blacklist Silverlight on Mac

Reviewed by Ariya Hidayat.

Does not seem to crash anymore, probably due to how we now handle
drawing and event model handshake better.

plugins/mac/PluginPackageMac.cpp:

(WebCore::PluginPackage::isPluginBlacklisted):

4:17 AM Changeset in webkit [47891] by zoltan@webkit.org

10 edits in trunk/LayoutTests

2009-08-31 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated font metrics for these css1 tests.

platform/qt/Skipped:
platform/qt/css1/color_and_background/background-expected.txt:
platform/qt/css1/color_and_background/background_attachment-expected.txt:
platform/qt/css1/color_and_background/background_color-expected.txt:
platform/qt/css1/color_and_background/background_image-expected.txt:
platform/qt/css1/color_and_background/background_position-expected.txt:
platform/qt/css1/color_and_background/background_repeat-expected.txt:
platform/qt/css1/color_and_background/color-expected.txt:
platform/qt/css1/conformance/forward_compatible_parsing-expected.txt:

4:06 AM Changeset in webkit [47890] by eric@webkit.org

4 edits in trunk/WebCore

2009-08-31 Cameron McCormack <cam@mcc.id.au>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=28827
SVGSVGElement.unsuspendRedraw() shouldn't throw

svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::unsuspendRedraw):
svg/SVGSVGElement.h:
svg/SVGSVGElement.idl:

3:55 AM Changeset in webkit [47889] by eric@webkit.org

4 edits in trunk/WebCore

2009-08-31 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Change the reutrn type of HTMLInputElement::list so that it conforms to the standard.
Add HTMLInputElement::dataList() https://bugs.webkit.org/show_bug.cgi?id=28769

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::list): (WebCore::HTMLInputElement::dataList): (WebCore::HTMLInputElement::selectedOption):
html/HTMLInputElement.h:
html/HTMLInputElement.idl:

3:45 AM Changeset in webkit [47888] by eric@webkit.org

2 edits in trunk/WebCore

2009-08-31 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

Remove ASSERT(frame) in ResourceHandle::start (ResourceHandleCurl.cpp)
https://bugs.webkit.org/show_bug.cgi?id=28802

Remove ASSERT because the frame could be null if the
ResourceHandle is not associated with any frame, e.g. if we are
downloading a file.
If the frame is not null but the page is null this must be an
attempted load from an onUnload handler, so let's just block it.

platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::start):

3:18 AM Changeset in webkit [47887] by eric@webkit.org

3 edits in trunk/WebCore

2009-08-31 Maxime Simon <Maxime Simon>

Reviewed by Eric Seidel.

Build fix for platforms which don't enable DOM_STORAGE.
https://bugs.webkit.org/show_bug.cgi?id=28834

bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):

2:59 AM Changeset in webkit [47886] by vestbo@webkit.org

1 edit in trunk/WebKitTools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro

Fix the Qt/Mac build of TestNetscapePlugin after Qt change 3940f25

2:53 AM Changeset in webkit [47885] by vestbo@webkit.org

1 edit in trunk/WebCore/WebCore.pro

Fix the Qt/Mac build after Qt change 3940f25 (LIBS_PRIVATE)

We no longer pick up the libraries/frameworks that Qt was built
against, so we have to add them manually for our targets.

12:49 AM Changeset in webkit [47884] by zoltan@webkit.org

23 edits in trunk/LayoutTests

2009-08-31 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated metrics in css2.1/t040*. (19 files)
Fix relative path in .css files.

css2.1/support/css1test64a.css:
css2.1/support/css1test64b.css:
platform/qt/Skipped:
platform/qt/css2.1/t0402-c71-fwd-parsing-00-f-expected.txt:
platform/qt/css2.1/t0402-c71-fwd-parsing-01-f-expected.txt:
platform/qt/css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
platform/qt/css2.1/t0402-c71-fwd-parsing-03-f-expected.txt:
platform/qt/css2.1/t0402-c71-fwd-parsing-04-f-expected.txt:
platform/qt/css2.1/t0402-syntax-01-f-expected.txt:
platform/qt/css2.1/t0402-syntax-02-f-expected.txt:
platform/qt/css2.1/t0402-syntax-03-f-expected.txt:
platform/qt/css2.1/t0402-syntax-04-f-expected.txt:
platform/qt/css2.1/t0402-syntax-05-f-expected.txt:
platform/qt/css2.1/t0402-syntax-06-f-expected.txt:
platform/qt/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
platform/qt/css2.1/t040302-c61-phys-len-00-b-expected.txt:
platform/qt/css2.1/t040302-c61-rel-len-00-b-ag-expected.txt:
platform/qt/css2.1/t040303-c62-percent-00-b-ag-expected.txt:
platform/qt/css2.1/t040304-c64-uri-00-a-g-expected.txt:
platform/qt/css2.1/t040306-c63-color-00-b-ag-expected.txt:
platform/qt/css2.1/t040306-syntax-01-f-expected.txt:
platform/qt/css2.1/t040307-syntax-01-b-expected.txt:

Aug 29, 2009:

4:59 PM Changeset in webkit [47883] by adele@apple.com

3 edits
2 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=28829
Crash in AccessibilityRenderObject::activeDescendant when trying to set aria-activedescendant to something without a renderer

Reviewed by Dan Bernstein.

Test: accessibility/aria-activedescendant-crash.html

accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::activeDescendant): Nil check.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=28829
Crash in AccessibilityRenderObject::activeDescendant when trying to set aria-activedescendant to something without a renderer

Reviewed by Dan Bernstein.

accessibility/aria-activedescendant-crash-expected.txt: Added.
accessibility/aria-activedescendant-crash.html: Added.

Aug 28, 2009:

11:56 PM Changeset in webkit [47882] by jmalonzo@webkit.org

6 edits in trunk

2009-08-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Oliver Hunt.

Gtk Build broken for OSX Quartz
https://bugs.webkit.org/show_bug.cgi?id=28727

Define XP_UNIX for non-Win OS builds.

GNUmakefile.am:

Check for XP_UNIX instead of GTK or X11 to ease building of the Gtk
port in Mac and Unix/Linux.

plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
plugins/PluginView.h:
plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded): (WebCore::PluginView::getValueStatic): (WebCore::PluginView::getValue): (WebCore::PluginView::init):

6:51 PM Changeset in webkit [47881] by eric@webkit.org

4 edits in trunk/WebKitTools

2009-08-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue needs a master process
https://bugs.webkit.org/show_bug.cgi?id=28040

Add a bugzilla-tool commit-queue command
Keeps per-bug logs, but doesn't yet upload them anywhere.

Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
Scripts/modules/buildbot.py: remove noisy log message
Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python

4:37 PM Changeset in webkit [47880] by sfalken@apple.com

2 edits in trunk/WebKitLibraries

Define _CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1
to automatically use secure versions of C runtime lib calls on Windows.
https://bugs.webkit.org/show_bug.cgi?id=28824

Reviewed by Adam Roben.

win/tools/vsprops/common.vsprops:

4:31 PM Changeset in webkit [47879] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-08-28 Gustavo Noronha Silva <Gustavo Noronha Silva>

Re-skipping tests that still fail on the bot.

platform/gtk/Skipped:

4:13 PM Changeset in webkit [47878] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-08-28 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unskip some passing tests, skip new tests that are failing.

platform/gtk/Skipped:

4:08 PM Changeset in webkit [47877] by Simon Fraser

2 edits in trunk/WebCore

2009-08-28 Simon Fraser <Simon Fraser>

Reviewed by Mark Rowe

Wrap WebkitCSSTransformValues in the correct class of DOM wrapper.
https://bugs.webkit.org/show_bug.cgi?id=27727

When fetching the DOM wrapper for a WebkitCSSTransformValue (which is a kind of
CSSValueList), we need to ask the value list whether it's a WebkitCSSTransformValue,
because there is not a unique enum value for WebkitCSSTransformValue.

bindings/objc/DOMCSS.mm: (kitClass):

3:09 PM Changeset in webkit [47876] by pkasting@chromium.org

2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28308
Fix some warnings introduced by r47381.

Reviewed by Jan Michael Alonzo.

platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::convertCMYKToRGBA):
(WebCore::convertRGBToRGBA):

3:03 PM Changeset in webkit [47875] by adachan@apple.com

2 edits in trunk/WebCore

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=21442
Make sure filesystemPathFromUrlOrTitle() returns a string with length
<= MAX_PATH - 1.

platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle):

2:44 PM Changeset in webkit [47874] by ojan@chromium.org

5 edits
1 copy
2 deletes in trunk/WebCore

2009-08-28 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Adding Chromium's VFS for Linux and Mac.

https://bugs.webkit.org/show_bug.cgi?id=28750

WebCore.gypi:
platform/chromium/ChromiumBridge.h:
platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::openDatabase): (WebCore::SQLiteFileSystem::deleteDatabaseFile):
platform/sql/chromium/SQLiteFileSystemChromiumLinux.cpp: Removed.
platform/sql/chromium/SQLiteFileSystemChromiumMac.cpp: Removed.
platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: Added.
platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:

2:16 PM Changeset in webkit [47873] by jparent@chromium.org

2 edits in trunk/LayoutTests

set-dangerous-headers.html shouldn't set allowed header to same value
as forbidden headers. AUTHORIZATION is an allowed header, and the
value is being set to "foobar" like the forbidden headers, which causes
the test to fail when run using http server that doesn't strip the
AUTHORIZATION header.
https://bugs.webkit.org/show_bug.cgi?id=28818

Patch by Julie Parent <jparent@chromium.org> on 2009-08-28
Reviewed by Alexey Proskuryakov.

http/tests/xmlhttprequest/set-dangerous-headers.html:

11:59 AM Changeset in webkit [47872] by Dimitri Glazkov

8 edits in trunk/WebCore

2009-08-28 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Made bindings use Node::setOnEvent functions for Node descendants
instead of Node::setAttributeEventListener.

Node::setAttributeEventListener is an internal function and
doesn't do the forwarding to DOM window that is required for some
HTML elements.
https://bugs.webkit.org/show_bug.cgi?id=28709

Tests added in http://trac.webkit.org/changeset/47326 now pass with V8.

bindings/scripts/CodeGeneratorV8.pm: Now generates EventListener accessors for Node descendants instead of using custom callbacks.
bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getEventListener): Moved from V8NodeCustom.cpp.
bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertEventListenerToV8Object): Fixed a bug in signature.
bindings/v8/V8Utilities.cpp: (WebCore::createHiddenDependency): (WebCore::removeHiddenDependency): Changed signature to accept Handle instead of Local.
bindings/v8/V8Utilities.h:
bindings/v8/custom/V8CustomBinding.h:
bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Removed custom callbacks for EventListener accessors.

11:40 AM Changeset in webkit [47871] by eric@webkit.org

2 edits in trunk/WebCore

2009-08-28 Ben Murdoch <benm@google.com>

https://bugs.webkit.org/show_bug.cgi?id=28803

Implements V8CustomVoidCallback reporting any exceptions that were thrown from the callback function.

bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback): Checks if the callback raised an exception and reports it to WebCore if so.

11:34 AM Changeset in webkit [47870] by Chris Fleizach

4 edits in trunk/WebKit

WebKit: update-webkit-localizable-strings script can no longer complete
https://bugs.webkit.org/show_bug.cgi?id=28792

Reviewed by John Sullivan.

English.lproj/Localizable.strings:

WebKit/mac: update-webkit-localizable-strings script can no longer complete
https://bugs.webkit.org/show_bug.cgi?id=28792

Reviewed by John Sullivan.

WebCoreSupport/WebViewFactory.mm:

(-[WebViewFactory AXARIAContentGroupText:]):

11:29 AM Changeset in webkit [47869] by pkasting@chromium.org

3 edits in trunk/WebCore

Not reviewed (build fix).

platform/graphics/qt/ImageDecoderQt.cpp: Accidentally added some spaces.

(WebCore::ImageDecoder::create):
(WebCore::ImageDecoderQt::ImageDecoderQt):

platform/graphics/qt/ImageDecoderQt.h: Make constructor public so factory function can access it (this seemed better than making ImageDecoder a friend).

11:08 AM Changeset in webkit [47868] by pkasting@chromium.org

7 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=27965
Move ImageDecoder creation function to a factory function on
ImageDecoder. This is arguably where it makes the most sense anyway,
and it will (soon) allow ImageSourceQt.cpp to have one less dedicated
function.

Reviewed by Eric Seidel.

platform/graphics/ImageSource.cpp:
platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoder::create):

platform/graphics/qt/ImageDecoderQt.h:
platform/graphics/qt/ImageSourceQt.cpp:

(WebCore::ImageSource::setData):

platform/image-decoders/ImageDecoder.cpp:
platform/image-decoders/ImageDecoder.h:

11:00 AM Changeset in webkit [47867] by pkasting@chromium.org

5 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28785
Combine duplicated code from ImageDecoder*.cpp into the main
ImageDecoder.cpp.

Reviewed by Eric Seidel.

platform/image-decoders/ImageDecoder.cpp:

(WebCore::RGBA32Buffer::RGBA32Buffer):
(WebCore::RGBA32Buffer::clear):
(WebCore::RGBA32Buffer::zeroFill):
(WebCore::RGBA32Buffer::copyBitmapData):
(WebCore::RGBA32Buffer::setSize):
(WebCore::RGBA32Buffer::hasAlpha):
(WebCore::RGBA32Buffer::setHasAlpha):
(WebCore::RGBA32Buffer::setStatus):
(WebCore::RGBA32Buffer::operator=):
(WebCore::RGBA32Buffer::width):
(WebCore::RGBA32Buffer::height):

platform/image-decoders/cairo/ImageDecoderCairo.cpp:
platform/image-decoders/haiku/ImageDecoderHaiku.cpp:
platform/image-decoders/wx/ImageDecoderWx.cpp:

8:24 AM Changeset in webkit [47866] by kov@webkit.org

25 edits
1 add in trunk

2009-08-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25889
[GTK] scrollbar policy for main frame is not implementable

Adding files for the new test for window-related issues (starting
with scrollbar policy).

GNUmakefile.am:

WebCore

2009-08-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25889
[GTK] scrollbar policy for main frame is not implementable

Override setScrollbarModes to correctly forward scrollbar modes
policy changes to client code, via a new platform-specific method,
scrollbarsPolicyDidChange.

page/ChromeClient.h: (WebCore::ChromeClient::scrollbarsPolicyDidChange):
platform/ScrollView.cpp: (WebCore::ScrollView::createScrollbar):
platform/ScrollView.h:
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setScrollbarModes):

WebKit/gtk

2009-08-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25889
[GTK] scrollbar policy for main frame is not implementable

Add properties and a signal to report scrollbar policy changes to
client code, and a default handler that does the right thing when
using GtkScrolledWindow.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::scrollbarsModeDidChange):
WebCoreSupport/ChromeClientGtk.h:
webkit/webkitwebframe.cpp: (webkit_web_frame_get_property): (webkit_web_frame_class_init): (webkit_web_frame_get_horizontal_scrollbar_policy): (webkit_web_frame_get_vertical_scrollbar_policy):
webkit/webkitwebframe.h:
tests/testwindow.c: Added. (load_finished_cb): (test_webkit_window_scrollbar_policy): (main):

WebKit/*

Added empty implementation of new ChromeClient method.

8:12 AM Changeset in webkit [47865] by jmalonzo@webkit.org

3 edits in trunk/WebKit/gtk

2009-08-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha and Xan Lopez.

[Gtk] Add view source mode API
https://bugs.webkit.org/show_bug.cgi?id=28805

Implement setter and getter for "view source" mode.

webkit/webkitwebview.cpp: (webkit_web_view_set_view_source_mode): (webkit_web_frame_get_view_source_mode):
webkit/webkitwebview.h:

7:27 AM Changeset in webkit [47864] by jmalonzo@webkit.org

4 edits
5 adds in trunk

2009-08-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[GTK] Geolocation needs permission API before being enabled by default

Unskip the Geolocation tests and rebaseline three DOM tests.

platform/gtk/Skipped:
platform/gtk/fast/dom/Window/window-properties-expected.txt: Added.
platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: Added.
platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Added.

Build the Gtk port with geolocation enabled. This option is only
enabled for the buildbot. The autotools option will be enabled by
default once the permissions API is implemented.

Scripts/build-webkit:

6:58 AM Changeset in webkit [47863] by vestbo@webkit.org

3 edits in trunk/WebCore

[Qt/Mac] Un-blacklist the QuickTime plugin

Patch by Cédric Luthi <cedric.luthi@gmail.com> on 2009-08-28
Reviewed by Tor Arne Vestbø

https://bugs.webkit.org/show_bug.cgi?id=28768

Now that the drawing model is properly negotiated, there is no need the
blacklist the QuickTime plugin anymore.

This revealed a bug in PluginView::performRequest: it should not initiate a
request if the plugin has been stopped, which is what happens when a plugin
only supports the QuickDraw drawing model.

plugins/PluginView.cpp:
plugins/mac/PluginPackageMac.cpp:

6:42 AM Changeset in webkit [47862] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-08-28 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Set DOM agent document to 0 in InspectorController::close to
make DOM agent remove DOM listeners from the inspected document.

Replace windowVisible checks with m_frontend checks to as inspector
window lives in a different process in Chromium while frontend proxy
is in the inspected page process.

https://bugs.webkit.org/show_bug.cgi?id=28800

inspector/InspectorController.cpp: (WebCore::InspectorController::inspect): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::close): (WebCore::InspectorController::pruneResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::addProfile):
inspector/InspectorController.h:

6:23 AM Changeset in webkit [47861] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-08-28 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Remove dependency of SummaryBar on WebInspector.resourceCategories.

https://bugs.webkit.org/show_bug.cgi?id=28801

inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.toolbarItemClass.get categories):
inspector/front-end/SummaryBar.js: (WebInspector.SummaryBar): (WebInspector.SummaryBar.prototype.update):

5:28 AM Changeset in webkit [47860] by ariya@webkit.org

41 edits in trunk/LayoutTests

2009-08-28 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Adapt expecteds of css2.1/t0401* to new metrics. Remove these files from Skipped. (39 files)

platform/qt/Skipped:
platform/qt/css2.1/t040102-keywords-00-b-expected.txt:
platform/qt/css2.1/t040102-keywords-01-b-expected.txt:
platform/qt/css2.1/t040103-case-00-b-expected.txt:
platform/qt/css2.1/t040103-case-01-c-expected.txt:
platform/qt/css2.1/t040103-escapes-00-b-expected.txt:
platform/qt/css2.1/t040103-escapes-01-b-expected.txt:
platform/qt/css2.1/t040103-escapes-02-d-expected.txt:
platform/qt/css2.1/t040103-escapes-03-b-expected.txt:
platform/qt/css2.1/t040103-escapes-04-b-expected.txt:
platform/qt/css2.1/t040103-escapes-05-c-expected.txt:
platform/qt/css2.1/t040103-escapes-06-b-expected.txt:
platform/qt/css2.1/t040103-escapes-07-b-expected.txt:
platform/qt/css2.1/t040103-escapes-08-b-expected.txt:
platform/qt/css2.1/t040103-ident-00-c-expected.txt:
platform/qt/css2.1/t040103-ident-01-c-expected.txt:
platform/qt/css2.1/t040103-ident-02-c-expected.txt:
platform/qt/css2.1/t040103-ident-03-c-expected.txt:
platform/qt/css2.1/t040103-ident-04-c-expected.txt:
platform/qt/css2.1/t040103-ident-05-c-expected.txt:
platform/qt/css2.1/t040103-ident-06-c-expected.txt:
platform/qt/css2.1/t040103-ident-07-c-expected.txt:
platform/qt/css2.1/t040103-ident-08-c-expected.txt:
platform/qt/css2.1/t040103-ident-09-c-expected.txt:
platform/qt/css2.1/t040103-ident-10-c-expected.txt:
platform/qt/css2.1/t040103-ident-11-c-expected.txt:
platform/qt/css2.1/t040103-ident-12-c-expected.txt:
platform/qt/css2.1/t040103-ident-13-c-expected.txt:
platform/qt/css2.1/t040105-atkeyw-00-b-expected.txt:
platform/qt/css2.1/t040105-atkeyw-01-b-expected.txt:
platform/qt/css2.1/t040105-atkeyw-02-b-expected.txt:
platform/qt/css2.1/t040105-atrule-00-b-expected.txt:
platform/qt/css2.1/t040105-atrule-01-b-expected.txt:
platform/qt/css2.1/t040105-atrule-02-b-expected.txt:
platform/qt/css2.1/t040105-atrule-03-b-expected.txt:
platform/qt/css2.1/t040105-atrule-04-b-expected.txt:
platform/qt/css2.1/t040105-import-00-b-expected.txt:
platform/qt/css2.1/t040105-import-01-b-expected.txt:
platform/qt/css2.1/t040109-c17-comments-00-b-expected.txt:
platform/qt/css2.1/t040109-c17-comments-01-b-expected.txt:

2:00 AM Changeset in webkit [47859] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-08-28 Pavel Feldman <pfeldman@chromium.org>

Not reviewed (patching in l18n change that was missing due to
the git binary diff format).

https://bugs.webkit.org/show_bug.cgi?id=28429

English.lproj/localizedStrings.js:

1:08 AM Changeset in webkit [47858] by abarth@webkit.org

3 edits in trunk/WebCore

2009-08-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make XSSAuditor go fast
https://bugs.webkit.org/show_bug.cgi?id=28667

Make the XSSAuditor go faster by implementing two optimizations:

1) We avoid canonicalizing scripts that are larger than the page's URL.

This saves a bunch of time for large inline scripts.

2) We memoize canonicalizing the page's URL because it's silly to

canonicalize repeated for each inline event listener.

These optimizations have a measurable affect on the intl1 page cycler.

No behavior change.

page/XSSAuditor.cpp: (WebCore::XSSAuditor::MemoizingURLCanonicalizer::canonicalizeURL): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::canSetBaseElementURL): (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::findInRequest):
page/XSSAuditor.h:

Aug 27, 2009:

11:17 PM Changeset in webkit [47857] by oliver@apple.com

5 edits in trunk

JSON Stringifier does not follow ES5 spec for handling of Number, String and Boolean objects
https://bugs.webkit.org/show_bug.cgi?id=28797

Reviewed by Maciej Stachowiak

Fixed unwrapBoxedPrimitive to do the right thing, which necessitated a couple of new exception
checks, and corrected the logic in gap to correctly convert Number and String objects.

9:54 PM Changeset in webkit [47856] by atwilson@chromium.org

2 edits in trunk/LayoutTests

Unreviewed.

Skipping worker-lifecycle.html test since it generates a deadlock on snowleopard.
Tracked as https://bugs.webkit.org/show_bug.cgi?id=28795.

platform/mac-snowleopard/Skipped:

8:09 PM Changeset in webkit [47855] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-08-27 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

Removed ASSERT_NOT_REACHED, because indeed this ASSERT is reached in
fast/canvas/change-context.html. And it's alright to reach it.

bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Removed assertion.

7:03 PM Changeset in webkit [47854] by jorlow@chromium.org

2 edits in trunk/WebCore

2009-08-27 Jeremy Orlow <jorlow@chromium.org>

Not reviewed. Build fix for http://trac.webkit.org/changeset/47840

Peter's change forgot one m_decoder->

platform/graphics/ImageSource.cpp: (WebCore::ImageSource::frameSizeAtIndex):

6:58 PM Changeset in webkit [47853] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-08-27 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[V8] Add NULL-check, since the context ain't changeable no more, and
thus getContext could return 0.

bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Added NULL-check.

6:38 PM Changeset in webkit [47852] by eric@webkit.org

6 edits in trunk

2009-08-27 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Eric Seidel.

dataTransfer.types() should include type "Files" when files are present in the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=28780

Add dataTransfer type "Files" to the chromium port. Add eseidel's
patch for same for the mac port.

platform/chromium/ClipboardChromium.cpp:

2009-08-27 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Eric Seidel.

dataTransfer.types() should include type "Files" when files are present in the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=28780

Test dataTransfer.types "Files" access for all ports.

http/tests/security/clipboard/clipboard-file-access-expected.txt:
http/tests/security/clipboard/resources/clipboard-file-access.js:

6:20 PM Changeset in webkit [47851] by cmarrin@apple.com

7 edits in trunk/WebCore

Removed GL_ from all constants, and gl prefix from all calls
https://bugs.webkit.org/show_bug.cgi?id=28773

This was done for the external API in CanvasRenderingContext3D and
the internal API in GraphicsContext3D.

6:08 PM Changeset in webkit [47850] by atwilson@chromium.org

2 edits in trunk/LayoutTests

Tweak to force worker object to get GC'd.

Reviewed by Oliver Hunt.

fast/workers/resources/dedicated-worker-lifecycle.js:

6:00 PM Changeset in webkit [47849] by jmalonzo@webkit.org

3 edits in trunk/WebCore

2009-08-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Qt and Gtk build fixes. Not reviewed.

Add CanvasRenderingContext3D.idl to the build scripts.

GNUmakefile.am:
WebCore.pro:

5:31 PM Changeset in webkit [47848] by sullivan@apple.com

2 edits in trunk/WebKit

StringsNotToBeLocalized.txt:

Brought up to date, other than the problem mentioned in https://bugs.webkit.org/show_bug.cgi?id=28792

5:27 PM Changeset in webkit [47847] by oliver@apple.com

6 edits in trunk

JSON.stringify replacer array does not accept values that are not string primitives.
https://bugs.webkit.org/show_bug.cgi?id=28788

Reviewed by Adam Roben

Update the JSON stringifier to initialise its replacer array according to the most
recent version of the spec.

5:13 PM Changeset in webkit [47846] by jorlow@chromium.org

3 edits in trunk/WebCore

2009-08-27 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Release the storage mutex whenever leaving JavaScript execution.
https://bugs.webkit.org/show_bug.cgi?id=28789

http://dev.w3.org/html5/spec/Overview.html#storage-mutex describes the
required behavior. After we leave JavaScript, we must be sure the storage
mutex has been released. At the end of evaluate(), if localStorage has been
instantiated, tell it to release any locks that may be applicable.

bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):

5:11 PM Changeset in webkit [47845] by ap@apple.com

4 edits in trunk

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=28753
<rdar://problem/7173448> Excessive number of threads (and a crash)

Coalesce DNS prefetch requests to reduce strain on CFHost. Currently, the algorithm is as follows:

when resolver is idle, the first few requests are sent immediately (they may or may not hit the wire);
if there are a few requests in flight already, coalesce all requests for one second;
to avoid pathological cases with lots of links to different sites on a page, only ask CFHost about a handful of names (dropping the rest).

Coalescing reduces the number of requests dramatically, as prefetchDNS is called for each
link, and these tend to have identical host name.

platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::DNSResolveQueue): (WebCore::DNSResolveQueue::shared): (WebCore::DNSResolveQueue::add): (WebCore::DNSResolveQueue::decrementRequestCount): (WebCore::DNSResolveQueue::fired): (WebCore::clientCallback): (WebCore::DNSResolveQueue::resolve): (WebCore::prefetchDNS):

5:08 PM Changeset in webkit [47844] by bfulgham@webkit.org

5 edits in trunk

JavaScriptCore: Link the testapi against CFLite when building the WinCairo port.

Reviewed by Adam Roben.

JavaScriptCore.vcproj/testapi/testapi.vcproj: Add new Release_CFLite target. Update all targets to inherit from either the JavaScriptCF.vsprops (Apple target) or the JavaScriptCFLite.vsprops file (WinCairo target).
JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Remove input file CoreFoundation.lib. This is provided by either the JavaScriptCF.vsprops or JavaScriptCFLite.vsprops file.

WebKit/win: Modify Release_Cairo target to build testapi using the
Release_CFLite target so that the correct CoreFoundation
(in this case, CFLite.dll) is linked.

Reviewed by Adam Roben.

WebKit.vcproj/WebKit.sln:

4:55 PM Changeset in webkit [47843] by cmarrin@apple.com

43 edits
2 adds in trunk

Final patch for Canvas 3D support
https://bugs.webkit.org/show_bug.cgi?id=28018

This hooks everything up and provides a working implementation of
Canvas 3D. I plumb the creation of the 3D canvas down to GraphicsLayer,
passing the opaque context and texture pointers so a Canvas3DLayer can be
created (more on that later). It also plumbs changes to the 3D canvas so
that Canvas3DLayer can recomposite the results.

A 3D Canvas element needs a RenderLayer and compositing layer to render.
This is because it renders to an off-screen texture in the GPU and then
hands it to a Canvas3DLayer, which is a subclass of CAOpenGLLayer, to
render that texture as a 3D quad. This keeps everything in GPU memory to
maximize performance. When a CanvasRenderingContext3D is created it
forces a style recalc which creates the RenderLayer and compositing
layer if needed.

I repurposed an existing flag which was put in place for animation to accomplish
this. This flag is passed to setNeedsStyleRecalc(), and I renamed it from
AnimationStyleChange to SyntheticStyleChange. It essentially says that you need
to do a complete style recalc, even though the style itself has not really
changed.

This patch also fixes a couple of bugs discovered when testing with 3d-canvas
turned on. I also added a constructor DOMWindow.idl for CanvasRenderingContext3D.
This is needed when making a JS wrapper for the object so the prototype
property can be set.

4:35 PM Changeset in webkit [47842] by sfalken@apple.com

2 edits in trunk/JavaScriptCore

Fix Windows-specific crash due to missing memory clearing call.

Reviewed by Geoff Garen.

runtime/Collector.cpp:

(JSC::Heap::allocateBlock):

4:16 PM Changeset in webkit [47841] by pkasting@chromium.org

5 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28751
Clean up ImageDecoder*.cpp a bit.

Reviewed by Eric Seidel.

platform/image-decoders/ImageDecoder.cpp: Put functions in the same order as in the header file. Also, since there's already an anonymous namespace in this file, use it to enclose the local helper functions.

(WebCore::):
(WebCore::ImageDecoder::upperBoundScaledX):
(WebCore::ImageDecoder::lowerBoundScaledX):
(WebCore::ImageDecoder::scaledY):

platform/image-decoders/cairo/ImageDecoderCairo.cpp:

(WebCore::RGBA32Buffer::width): Style fix.
(WebCore::RGBA32Buffer::height): Style fix.

platform/image-decoders/haiku/ImageDecoderHaiku.cpp:

(WebCore::RGBA32Buffer::copyBitmapData): Ensure m_size is set correctly.
(WebCore::RGBA32Buffer::asNewNativeImage): Remove unneeded temp.
(WebCore::RGBA32Buffer::operator=): Simplify.

platform/image-decoders/wx/ImageDecoderWx.cpp:

(WebCore::RGBA32Buffer::asNewNativeImage): Try and collect spaced-out temps under loop comment to show they're all related. Use size_t for iterating over elements of a Vector.
(WebCore::RGBA32Buffer::width): Style fix.
(WebCore::RGBA32Buffer::height): Style fix.

4:14 PM Changeset in webkit [47840] by pkasting@chromium.org

3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28751
Clean up ImageSource.* in preparation for more fixes on bug 27965.

Reviewed by Eric Seidel.

platform/graphics/ImageSource.cpp: Put functions in the same order as in header file.

(WebCore::ImageSource::isSizeAvailable): Shorten.
(WebCore::ImageSource::size): Shorten.
(WebCore::ImageSource::frameSizeAtIndex): Shorten.
(WebCore::ImageSource::repetitionCount): Shorten.
(WebCore::ImageSource::frameIsCompleteAtIndex):

platform/graphics/ImageSource.h: Shorten #ifdef section a bit by sharing common typedefs.

3:58 PM Changeset in webkit [47839] by atwilson@chromium.org

2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Skip HTML5 worker lifecycle test added in r47837 as it depends on unimplemented functionality in DRT.

platform/qt/Skipped:

3:05 PM Changeset in webkit [47838] by bfulgham@webkit.org

2 edits in trunk/JavaScriptCore

Build fix: JavaScriptCore_debug.def missing some exports. Apple
Windows build does not use this file, so it was not noticed previously.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

2:57 PM Changeset in webkit [47837] by atwilson@chromium.org

4 edits
8 adds in trunk/LayoutTests

Need to write tests for worker lifecycle mechanisms.
https://bugs.webkit.org/show_bug.cgi?id=28714

Reviewed by David Levin.

fast/workers/dedicated-worker-lifecycle-expected.txt: Added.
fast/workers/dedicated-worker-lifecycle.html: Added.
fast/workers/resources/create-shared-worker-frame.html: Added.
fast/workers/resources/dedicated-worker-lifecycle.js: Added.

Broke out "orphaned worker" lifecycle tests because they only apply to dedicated workers.
(runTests.worker.onmessage):
(runTests):
(orphanedWorkerExited.worker.onmessage):
(orphanedWorkerExited):
(orphanedTimeoutWorkerExited):

fast/workers/resources/shared-worker-lifecycle.js: Added.

Added tests for the various shared worker lifecycle cases (makes sure that refcounts are properly updated when documents close).
(runTests):
(createWorkerFrame):
(closeFrame):
(closeFrame1):
(closeFrame2):
(closeFrame3):
(closeFrame4):
(complete):

fast/workers/resources/worker-lifecycle.js:

Updated test so it can run in a browser (with incorrect output) to aid in debugging.
(runTests.worker.onmessage):
(runTests):
(workerExited):

fast/workers/resources/worker-util.js: Added.

Moved some common utilities out of worker-lifecycle.js and into this file so they can be shared with other tests.
(log):
(gc):
(waitUntilWorkerThreadsExit):
(waitUntilThreadCountMatches.return):
(waitUntilThreadCountMatches):
(ensureThreadCountMatches):
(done):

fast/workers/shared-worker-frame-lifecycle-expected.txt: Added.
fast/workers/shared-worker-frame-lifecycle.html-disabled: Added.
fast/workers/shared-worker-lifecycle.html-disabled:
fast/workers/worker-lifecycle.html:

2:38 PM Changeset in webkit [47836] by pkasting@chromium.org

7 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28785
Add ImageDecoder.cpp to various build files so platforms will be able to
use it. Move an ENABLE to not cover the whole file, in preparation for
adding a bunch of code. Simplify #ifdefs in ImageDecoder.h to be "Skia
vs. everyone else", which also gives new platforms a reasonable default
behavior.

Reviewed by Eric Seidel.

GNUmakefile.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCoreSources.bkl:
platform/image-decoders/ImageDecoder.cpp:

(WebCore::):

platform/image-decoders/ImageDecoder.h:

(WebCore::RGBA32Buffer::getAddr):

1:55 PM Changeset in webkit [47835] by Antti Koivisto

4 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28784

Reviewed by Dave Kilzer.

Add an exported method to flush pending repaints.

WebCore.base.exp:
page/FrameView.cpp:

(WebCore::FrameView::layoutIfNeededRecursive):
(WebCore::FrameView::flushDeferredRepaints):

page/FrameView.h:

1:45 PM Changeset in webkit [47834] by barraclough@apple.com

3 edits in trunk/JavaScriptCore

x86-64 GTK broken due to code offsets changing, pointers sometimes packed into immediates.
https://bugs.webkit.org/show_bug.cgi?id=28317

Reviewed by Oliver Hunt.

Missed one, fix part II.

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::move):

assembler/X86Assembler.h:

(JSC::CAN_SIGN_EXTEND_8_32):

1:39 PM Changeset in webkit [47833] by eric@webkit.org

2 edits in trunk/WebCore

2009-08-27 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Eric Seidel.

[V8] Expose files from the pasteboard in drop events.
https://bugs.webkit.org/show_bug.cgi?id=28782

Update chromium port to expose dataTransfer.files() as per
HTML5 drag drop (Aug 2009 edition).

platform/chromium/ClipboardChromium.cpp:

1:29 PM Changeset in webkit [47832] by eric@webkit.org

3 edits in trunk/LayoutTests

2009-08-27 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Eric Seidel.

clipboard file access tests use "dragentered" instead of "dragenter"
https://bugs.webkit.org/show_bug.cgi?id=28761

Use dragenter and log these events. Add a dragleave test to check
that drag files are not visible in dragleave events.

http/tests/security/clipboard/clipboard-file-access-expected.txt:
http/tests/security/clipboard/resources/clipboard-file-access.js:

12:40 PM Changeset in webkit [47831] by pfeldman@chromium.org

9 edits in trunk/WebCore

2009-08-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Dmitry Glazkov.

ScriptState now keeps explicit Handle of devtools front-end
utility context instead of trying to retrieve it from inspected
Frame.

https://bugs.webkit.org/show_bug.cgi?id=28772

bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController):
bindings/v8/ScriptController.h:
bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope):
bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::~ScriptState): (WebCore::scriptStateFromPage):
bindings/v8/ScriptState.h: (WebCore::ScriptState::context):
bindings/v8/ScriptValue.h: (WebCore::ScriptValue::~ScriptValue):
inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):

12:37 PM Changeset in webkit [47830] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-08-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Console won't close.

https://bugs.webkit.org/show_bug.cgi?id=28778

inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._updateModifiedNodes):
inspector/front-end/utilities.js: (Node.prototype.isAncestor):

12:16 PM Changeset in webkit [47829] by eric@webkit.org

3 edits
3 adds in trunk

2009-08-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add a test to make sure that image/link drags don't contain junk file arrays.
https://bugs.webkit.org/show_bug.cgi?id=28755

editing/pasteboard/files-during-page-drags-expected.txt: Added.
editing/pasteboard/files-during-page-drags.html: Added.
editing/pasteboard/resources/files-during-page-drags.js: Added.

2009-08-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix a typo in files() causing image drags to have junk file arrays.
https://bugs.webkit.org/show_bug.cgi?id=28755

Test: editing/pasteboard/files-during-page-drags.html

platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::files):

12:15 PM Changeset in webkit [47828] by oliver@apple.com

5 edits in trunk

JSON parser accepts trailing comma in array literals
https://bugs.webkit.org/show_bug.cgi?id=28779

Reviewed by Alexey Proskuryakov.

Update parser to correctly fail if there's a trailing comma.

11:46 AM Changeset in webkit [47827] by jorlow@chromium.org

5 edits in trunk/WebCore

Not reviewed. Build fix for Chromium.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-08-27

bindings/v8/DOMObjectsInclude.h:
bindings/v8/DerivedSourcesAllInOne.cpp:
bindings/v8/V8Index.cpp:
bindings/v8/V8Index.h:

11:07 AM Changeset in webkit [47826] by ap@apple.com

2 edits in trunk/WebCore

Windows build fix.

DerivedSources.cpp: Added JSPageTransitionEvent.cpp to DerivedSources.cpp.

10:52 AM Changeset in webkit [47825] by ap@apple.com

1 edit in trunk/WebCore/ChangeLog

Zap gremlins from a recent ChangeLog entry.

10:46 AM Changeset in webkit [47824] by ap@apple.com

25 edits
13 adds in trunk

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=28758
<rdar://problem/6440869> Implement pageshow and pagehide events for b/f cache (28758)

Tests: fast/events/pageshow-pagehide-on-back-cached.html

fast/events/pageshow-pagehide-on-back-uncached.html
fast/events/pageshow-pagehide.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Dispatch pagehide event (this function is called both when a document goes away, and when it goes to b/f cache).

page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchAllPendingUnloadEvents): Dispatch pagehide right before unload. (WebCore::DOMWindow::dispatchPageTransitionEvent): Do what it takes to add a new event handler that can be installed on Window object. (WebCore::DOMWindow::onpagehide): Ditto. (WebCore::DOMWindow::setOnpagehide): Ditto. (WebCore::DOMWindow::onpageshow): Ditto. (WebCore::DOMWindow::setOnpageshow): Ditto.

history/CachedFrame.cpp: (WebCore::CachedFrame::restore): Dispatch pageshow for a page that isn't being restored from cache.

dom/PageTransitionEvent.cpp: Added. (WebCore::PageTransitionEvent::PageTransitionEvent): (WebCore::PageTransitionEvent::~PageTransitionEvent): (WebCore::PageTransitionEvent::initPageTransitionEvent):
dom/PageTransitionEvent.h: Added. (WebCore::PageTransitionEvent::create): (WebCore::PageTransitionEvent::isPageTransitionEvent): (WebCore::PageTransitionEvent::persisted):
dom/PageTransitionEvent.idl: Added. Add event class implementation.

html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Support inline listener definition (note that adding listeners to document.body programmatically is not supported, matching Firefox).

dom/Document.cpp: (WebCore::Document::implicitClose): Dispatch pageshow event right before load event. (WebCore::Document::dispatchPageTransitionEvent): Do what it takes to add a new event for Docuemnt. (WebCore::Document::createEvent): Ditto.

dom/Document.h: Added dispatchPageTransitionEvent.

DerivedSources.make:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
bindings/js/JSEventCustom.cpp: (WebCore::toJS):
dom/Event.cpp: (WebCore::Event::isPageTransitionEvent):
dom/Event.h:
dom/EventNames.h:
html/HTMLAttributeNames.in:
page/DOMWindow.h:
page/DOMWindow.idl: Do what it takes to add a new event type.

9:35 AM Changeset in webkit [47823] by pfeldman@chromium.org

1 edit
1 add in trunk/WebCore

2009-08-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by NOBODY (build fix).

Adding missing file from previous commit.

https://bugs.webkit.org/show_bug.cgi?id=28740

inspector/front-end/SummaryBar.js: Added. (WebInspector.SummaryBar): (WebInspector.SummaryBar.prototype.get calculator): (WebInspector.SummaryBar.prototype.set calculator): (WebInspector.SummaryBar.prototype.reset): (WebInspector.SummaryBar.prototype.update): (WebInspector.SummaryBar.prototype._drawSwatch.drawSwatchSquare): (WebInspector.SummaryBar.prototype._drawSwatch): (WebInspector.SummaryBar.prototype._drawSummaryGraph.var): (WebInspector.SummaryBar.prototype._drawSummaryGraph): (WebInspector.SummaryBar.prototype._drawSummaryGraph.drawPill): (WebInspector.SummaryBar.prototype._fadeOutRect): (WebInspector.SummaryBar.prototype._makeLegendElement):

9:09 AM Changeset in webkit [47822] by pfeldman@chromium.org

7 edits in trunk/WebCore

2009-08-27 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Factor out Factor out summary bar from Resources panel.

https://bugs.webkit.org/show_bug.cgi?id=28740

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._updateSummaryGraph): (WebInspector.ResourcesPanel.prototype._updateDividersLabelBarPosition): (WebInspector.ResourcesPanel.prototype._changeSortingFunction):
inspector/front-end/SummaryBar.js: Added. (WebInspector.SummaryBar): (WebInspector.SummaryBar.prototype.get calculator): (WebInspector.SummaryBar.prototype.set calculator): (WebInspector.SummaryBar.prototype.reset): (WebInspector.SummaryBar.prototype.update): (WebInspector.SummaryBar.prototype._drawSwatch.drawSwatchSquare): (WebInspector.SummaryBar.prototype._drawSwatch): (WebInspector.SummaryBar.prototype._drawSummaryGraph.var): (WebInspector.SummaryBar.prototype._drawSummaryGraph): (WebInspector.SummaryBar.prototype._drawSummaryGraph.drawPill): (WebInspector.SummaryBar.prototype._fadeOutRect): (WebInspector.SummaryBar.prototype._makeLegendElement):
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.css:
inspector/front-end/inspector.html:

8:38 AM Changeset in webkit [47821] by pfeldman@chromium.org

4 edits in trunk/WebCore

2009-08-26 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Start adding heap profiler to Inspector (hidden behind a flag.)

https://bugs.webkit.org/show_bug.cgi?id=28429

English.lproj/localizedStrings.js:
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.get statusBarItems): (WebInspector.ProfilesPanel.prototype.reset): (WebInspector.ProfilesPanel.prototype.addProfile): (WebInspector.ProfilesPanel.prototype._updateInterface): (WebInspector.ProfilesPanel.prototype._snapshotClicked):
inspector/front-end/inspector.css:
inspector/front-end/inspector.js: added Preferences.heapProfilerPresent flag.

8:24 AM Changeset in webkit [47820] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-08-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Metrics sidebar editing is broken.

https://bugs.webkit.org/show_bug.cgi?id=28434

inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update):

7:54 AM Changeset in webkit [47819] by eric@webkit.org

2 edits in trunk/WebCore

2009-08-27 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=28767

Make KURLGoogle.cpp's decodeURLEscapeSequences decode %00 to match
KURL.cpp. This makes the XSSAuditor tests pass when using KURLGoogle.

platform/KURLGoogle.cpp: (WebCore::decodeURLEscapeSequences):

7:43 AM BuildingQtOnOSX edited by ironstorm@gmail.com

(diff)

7:38 AM BuildingQtOnOSX edited by ironstorm@gmail.com

(diff)

5:27 AM Changeset in webkit [47818] by ariya@webkit.org

3 edits in trunk/WebKit/qt

2009-08-27 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Ariya Hidayat.

QWebHistory::clear() modifications.

Clear() method was changed. If QWebHistory is empty (there is no
elements even current) clear() do nothing. If there at least one
element clear() will delete everything apart of current.

New autotests in QWebHistory

New autotests were added to QWebHistory. They should check some crashes
in save and restore state process and clear() method and general
behavior on where QWebHistory::count() == 0 or QWebHistory::count() == 1

Bugzilla: https://bugs.webkit.org/show_bug.cgi?id=28711

Api/qwebhistory.cpp: (QWebHistory::clear):
tests/qwebhistory/tst_qwebhistory.cpp: (tst_QWebHistory::back): (tst_QWebHistory::forward): (tst_QWebHistory::saveAndRestore_crash_1): (tst_QWebHistory::saveAndRestore_crash_2): (tst_QWebHistory::saveAndRestore_crash_3): (tst_QWebHistory::clear):

4:40 AM Changeset in webkit [47817] by ariya@webkit.org

2 edits in trunk/WebKit/qt

2009-08-27 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Cleanup, old and commented part of source code was removed.
Fix some formatting problems.

https://bugs.webkit.org/show_bug.cgi?id=28712

Api/qwebhistory_p.h: (QWebHistoryPrivate::QWebHistoryPrivate):

4:18 AM Changeset in webkit [47816] by ariya@webkit.org

2 edits in trunk/WebCore

2009-08-27 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Build fix, missing functions after r47763.

platform/qt/Localizations.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):

2:44 AM Changeset in webkit [47815] by ariya@webkit.org

21 edits in trunk/LayoutTests

2009-08-27 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt]Update expecteds (t150*) in css2.1 and remove from Skipped. This affects 20 files.

platform/qt/css2.1/t1503-c522-font-family-00-b-expected.txt:
platform/qt/css2.1/t1504-c523-font-style-00-b-expected.txt:
platform/qt/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt:
platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt:
platform/qt/css2.1/t1506-c525-font-wt-00-b-expected.txt:
platform/qt/css2.1/t1507-c526-font-sz-00-b-expected.txt:
platform/qt/css2.1/t1507-c526-font-sz-01-b-a-expected.txt:
platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.txt:
platform/qt/css2.1/t1508-c527-font-00-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-01-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-02-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-03-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-04-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-05-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-08-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-09-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-10-c-expected.txt:

2:42 AM Changeset in webkit [47814] by ariya@webkit.org

18 edits in trunk/LayoutTests

2009-08-27 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update outdated font metrics in these css1 tests since we pass them.

platform/qt/Skipped:
platform/qt/css1/box_properties/clear-expected.txt:
platform/qt/css1/box_properties/clear_float-expected.txt:
platform/qt/css1/box_properties/float-expected.txt:
platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
platform/qt/css1/box_properties/float_margin-expected.txt:
platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
platform/qt/css1/box_properties/height-expected.txt:
platform/qt/css1/box_properties/width-expected.txt:
platform/qt/css1/cascade/cascade_order-expected.txt:
platform/qt/css1/cascade/important-expected.txt:
platform/qt/css1/classification/display-expected.txt:
platform/qt/css1/classification/list_style-expected.txt:
platform/qt/css1/classification/list_style_image-expected.txt:
platform/qt/css1/classification/list_style_position-expected.txt:
platform/qt/css1/classification/list_style_type-expected.txt:
platform/qt/css1/classification/white_space-expected.txt:

2:07 AM Changeset in webkit [47813] by ariya@webkit.org

2 edits in trunk/LayoutTests

2009-08-26 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Skip HTML5 input-list tests added in r47767.

platform/qt/Skipped:

1:39 AM Changeset in webkit [47812] by oliver@apple.com

4 edits
3 adds in trunk

'this' in JSON.parse reviver is the global object
https://bugs.webkit.org/show_bug.cgi?id=28752

Reviewed by Gavin Barraclough.

This is a technically simple change, we merely update the code for calling
the reviver function to pass the correct this object. Doing so however
exposes the holder to arbitrary mutation by the reviver function so it is
necessary for us to now guard all property accesses against the possibility
of failure.

12:26 AM Changeset in webkit [47811] by xan@webkit.org

3 edits in trunk

2009-08-27 Priit Laes <plaes@plaes.org>

Reviewed by Xan Lopez.

[GTK] Out-of-srcdir build problem
https://bugs.webkit.org/show_bug.cgi?id=28741

GNUmakefile.am, autotools/webkit.m4: Fix problem with out-of-srcdir builds. Also bump required glib version.

Aug 26, 2009:

11:38 PM Changeset in webkit [47810] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-08-26 Cameron McCormack <cam@mcc.id.au>

Reviewed by David Kilzer.

Make prepare-ChangeLog notice property changes
https://bugs.webkit.org/show_bug.cgi?id=28675

Make the generated ChangeLog entry include a short description of
property changes if there were such changes. Also make
prepare-ChangeLog not bail if the only changes are property changes.

Scripts/prepare-ChangeLog:

11:33 PM Changeset in webkit [47809] by abarth@webkit.org

6 edits
4 adds in trunk/LayoutTests

2009-08-26 Yaar Schnitman <yaar@chromium.org>

Reviewed by Adam Barth.

Re-baselined and created new isolatedWorld tests to play nice with localStorage & sessionStorage.
https://bugs.webkit.org/show_bug.cgi?id=27992

http/tests/security/isolatedWorld/all-window-properties.html: Re-baselined.
http/tests/security/isolatedWorld/storage-properties-expected.txt: Added.
http/tests/security/isolatedWorld/storage-properties.html: Added.
http/tests/security/isolatedWorld/storage-prototype-expected.txt: Added.
http/tests/security/isolatedWorld/storage-prototype.html: Added.
platform/qtk/Skipped: Added new tests.
platform/mac/Skipped: Added new tests.
platform/qt/Skipped: Added new tests.
platform/win/Skipped: Added new tests.

10:22 PM Changeset in webkit [47808] by abarth@webkit.org

39 edits in trunk/WebCore

2009-08-26 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Adam Barth.

Removing trailing whitespaces from all storage classes.

https://bugs.webkit.org/show_bug.cgi?id=28075

storage/ChangeVersionWrapper.cpp:
storage/Database.cpp:
storage/Database.h:
storage/DatabaseDetails.h:
storage/DatabaseThread.cpp:
storage/DatabaseTracker.cpp:
storage/DatabaseTracker.h:
storage/LocalStorageTask.cpp:
storage/LocalStorageTask.h:
storage/LocalStorageThread.cpp:
storage/LocalStorageThread.h:
storage/OriginQuotaManager.cpp:
storage/OriginUsageRecord.cpp:
storage/OriginUsageRecord.h:
storage/SQLError.h:
storage/SQLResultSetRowList.h:
storage/SQLStatement.cpp:
storage/SQLStatement.h:
storage/SQLStatementCallback.h:
storage/SQLStatementErrorCallback.h:
storage/SQLTransaction.cpp:
storage/SQLTransaction.h:
storage/SQLTransactionCallback.h:
storage/SQLTransactionErrorCallback.h:
storage/Storage.cpp:
storage/Storage.h:
storage/StorageArea.h:
storage/StorageAreaImpl.cpp:
storage/StorageAreaImpl.h:
storage/StorageAreaSync.cpp:
storage/StorageAreaSync.h:
storage/StorageEvent.cpp:
storage/StorageEvent.h:
storage/StorageMap.cpp:
storage/StorageMap.h:
storage/StorageNamespaceImpl.cpp:
storage/StorageSyncManager.cpp:
storage/StorageSyncManager.h:

10:21 PM Changeset in webkit [47807] by abarth@webkit.org

8 edits in trunk

2009-08-26 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480

Api/qwebsettings.cpp: (QWebSettings::QWebSettings):

2009-08-26 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480

WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):

2009-08-26 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480

A bunch of our LayoutTests rely on our old behavior, so we explicitly
grant local files universal access during testing. Mainly, these tests
involve making XMLHttpRequests for data URLs.

DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage):
DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):

8:49 PM EFLWebKit edited by tonikitoo@gmail.com

(diff)

7:45 PM Changeset in webkit [47806] by alice.liu@apple.com

3 edits in trunk/JavaScriptCore

Windows build fix: added some exported symbols

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

7:26 PM Changeset in webkit [47805] by hyatt@apple.com

2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28763, flickering when opacity changes.

Reviewed by Anders Carlsson.

Make opacity changes from < 1 to 1 and from 1 to < 1 cause a relayout to happen. We need
to do this in order for overflow information to be properly recomputed.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

7:07 PM Changeset in webkit [47804] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Windows build fix: Removed some exported symbols that no longer exist.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-26

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

7:02 PM Changeset in webkit [47803] by eric.carlson@apple.com

2 edits in trunk/LayoutTests

2009-08-26 Eric Carlson <eric.carlson@apple.com>

Reviewed by NOBODY (Build fix).

Fixup test after r47801: skip the first 'waiting' event because it is fired
when we call play() and there isn't enough media to begin playback immediately,
but we are interested in the 'waiting' event fired when the movie runs
out of loaded media.

http/tests/media/video-play-stall-seek.html:

6:16 PM Changeset in webkit [47802] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

x86-64 GTK broken due to code offsets changing, pointers sometimes packed into immediates.
https://bugs.webkit.org/show_bug.cgi?id=28317

Reviewed by Olliejver Hunt.

We rely on a slightly OS X specific behaviour, that x86-64 applications have a 4Gb zero page,
so pointers are never representable as a 32-bit integer, and always have to be represented by
a separate immediate load instruction, rather than within the immediate field of an arithmetic
or memory operation.

We explicitly check for a couple of cases where a value might be representable in 32-bit, but
these probably never kick in on Mac OS, and only kick in to hose GTK. Deleting these does not
show a performance degradation on SunSpider. Remove.

assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::storePtr):
(JSC::MacroAssemblerX86_64::branchPtr):

5:47 PM Changeset in webkit [47801] by eric.carlson@apple.com

7 edits
2 adds in trunk

2009-08-26 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

HTMLMediaElement sometimes loses events
https://bugs.webkit.org/show_bug.cgi?id=28762
<rdar://problem/7172437>

A media element triggers the resource selection algorithm if

play() is called when the networkState attribute is NETWORK_EMPTY, but

it also immediately queues 'play' and either 'waiting' or 'playing' events.

One of the steps in preparing to load is to flush pending events, so those

events were lost if the load timer fired quickly enough. Fixed by deleting

pending events before scheduling the load timer.

Test: media/audio-play-event.html

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::scheduleLoad):

Do nothing if the load timer is already scheduled. Call prepareForLoad so queue of
pending events is flushed immediately.

(WebCore::HTMLMediaElement::scheduleNextSourceChild):

New, start the load timer without flushing pending events.

(WebCore::HTMLMediaElement::load):

Call prepareForLoad();

(WebCore::HTMLMediaElement::prepareForLoad):

New, load setup code moved from loadInternal.

(WebCore::HTMLMediaElement::loadInternal):

Moved some setup code to prepareForLoad so it can be invoked immediately before
arming the load timer.

(WebCore::HTMLMediaElement::setNetworkState):

Call scheduleNextSourceChild instead of scheduleLoad as the later now clears
pending events.

html/HTMLMediaElement.h:

Declare scheduleNextSourceChild.

2009-08-26 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

HTMLMediaElement sometimes loses events
https://bugs.webkit.org/show_bug.cgi?id=28762
<rdar://problem/7172437>

media/audio-play-event.html:
media/audio-play-event-expected.txt:

Added.

media/video-play-empty-events-expected.txt:

Updated results for previously missed events.

media/video-src-remove.html:
media/video-timeupdate-during-playback-expected.txt:

Restructured to make results less timing dependent.

5:35 PM QtWebKit edited by ironstorm@gmail.com

add OSX building instructions link (diff)

5:33 PM BuildingQtOnOSX edited by ironstorm@gmail.com

(diff)

5:32 PM BuildingQtOnOSX edited by ironstorm@gmail.com

(diff)

5:29 PM BuildingQtOnOSX edited by ironstorm@gmail.com

(diff)

4:40 PM BuildingOnWindows edited by dbates@webkit.org

Added notice about proper ordering of Cygwin\bin in the list of VC++ … (diff)

4:40 PM Changeset in webkit [47800] by pkasting@chromium.org

3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28751
Switch ICO decoder from a Vector of raw pointers to a Vector of
OwnPtrs now that that is possible. Makes code slightly simpler.

Reviewed by Eric Seidel.

platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::processDirectory):

platform/image-decoders/ico/ICOImageDecoder.h:

4:00 PM Changeset in webkit [47799] by ggaren@apple.com

12 edits in trunk/JavaScriptCore

A bit of Collector refatoring.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-26
Reviewed by Oliver Hunt.

SunSpider says no change. v8 says 1.003x faster (1.02x faster on splay).

JavaScriptCore.exp:

runtime/JSCell.cpp:

(JSC::JSCell::toPrimitive):
(JSC::JSCell::getPrimitiveNumber):
(JSC::JSCell::toBoolean):
(JSC::JSCell::toNumber):
(JSC::JSCell::toString):
(JSC::JSCell::toObject): Removed pure virtual functions from
JSCell, so the collector can construct one. This allowed
me to remove a bunch of ASSERT_NOT_REACHED throughout the
code, too.

runtime/JSCell.h:

(JSC::JSCell::JSCell): ditto
(JSC::Heap::heap): Inlined this function because it's trivial.

JavaScriptCore.exp:

runtime/Collector.cpp:

(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlocks): Renamed freeHeap to freeBlocks, since
it doesn't actually free the Heap object.
(JSC::Heap::heapAllocate):
(JSC::Heap::sweep):

runtime/Collector.h: Refactored block allocation and destruction

into helper functions.

runtime/GetterSetter.cpp:
runtime/JSAPIValueWrapper.cpp:
runtime/JSPropertyNameIterator.cpp: Removed dummy implementations

of pure virtual functions. (See above.)

3:30 PM Changeset in webkit [47798] by hyatt@apple.com

3 edits
4 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=28718, image inside relpositioned inline doesn't paint.
Make sure vertical overflow is still computed across self-painting layers, even though it isn't
propagated to parents.

Reviewed by Dan Bernstein.

Added fast/repaint/rel-positioned-inline-with-overflow.html

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeVerticalOverflow):

LayoutTests: Add layout test for relpositioned inline regression.

Reviewed by Dan Bernstein.

fast/repaint/rel-positioned-inline-with-overflow.html: Added.
platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.checksum: Added.
platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.txt: Added.

2:57 PM Changeset in webkit [47797] by levin@chromium.org

10 edits in trunk

WebCore: ResourceRequestBase::*[Aa]llowHTTPCookies shouldn't mention http.
https://bugs.webkit.org/show_bug.cgi?id=28735

Patch by David Levin <levin@chromium.org> on 2009-08-26
Reviewed by Darin Fisher.

Renaming the method to imply its wider implications of affecting cookies
over any protocol that supports them.

No change in functionality so no new tests.

WebCore.order:
loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):

platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):
(WebCore::ResourceRequestBase::allowCookies):
(WebCore::ResourceRequestBase::setAllowCookies):
(WebCore::equalIgnoringHeaderFields):

platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::ResourceRequestBase):

platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):

platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):

platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateFromSoupMessage):

WebKit/win: ResourceRequestBase::*[Aa]llowHTTPCookies shouldn't mention http.
https://bugs.webkit.org/show_bug.cgi?id=28735

Patch by David Levin <levin@chromium.org> on 2009-08-26
Reviewed by Darin Fisher.

WebMutableURLRequest.cpp:

(WebMutableURLRequest::setHTTPShouldHandleCookies):

2:54 PM Changeset in webkit [47796] by mitz@apple.com

4 edits
4 adds in trunk

WebCore:
Made RenderInline::clippedOverflowRectForRepaint() actually include
overflow.

Reviewed by Dave Hyatt.

Test: fast/repaint/inline-overflow.html

rendering/RenderInline.cpp:

(WebCore::RenderInline::linesVisibleOverflowBoundingBox): Added. Returns

the bounding box of all lines’ visible overflow boxes (under the
assumption that the first and last lines determine the top and
bottom, respectively).

(WebCore::RenderInline::clippedOverflowRectForRepaint): Changed to use

linesVisibleOverflowBoundingBox() instead of linesBoundingBox().

rendering/RenderInline.h:

LayoutTests:
Test that RenderInline::clippedOverflowRectForRepaint() actually
includes overflow.

Reviewed by Dave Hyatt.

fast/repaint/inline-overflow-expected.checksum: Added.
fast/repaint/inline-overflow-expected.png: Added.
fast/repaint/inline-overflow-expected.txt: Added.
fast/repaint/inline-overflow.html: Added.

2:33 PM Changeset in webkit [47795] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

End re-roll-in of r47738:47740 with Windows crash fixed

2009-08-26 Geoffrey Garen <ggaren@apple.com>

Build fix: start out with a 32-bit value to avoid a shortening warning.

runtime/Collector.cpp: (JSC::Heap::sweep):

2009-08-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Substantially reduced VM thrash in the GC heap.

1.08x faster on v8 (1.60x faster on v8-splay).

1.40x faster on bench-alloc-nonretained.

1.90x faster on bench-alloc-retained.

SunSpider says no change.

runtime/Collector.cpp: (JSC::Heap::heapAllocate): Fixed a long-standing bug: update a few local variables unconditionally after calling collect(), since they may be used even if we don't "goto scan". (In the bug I saw, usedBlocks got out of sync with heap.usedBlocks). (JSC::Heap::sweep): Keep enough free heap space to accomodate the number of objects we'll allocate before the next GC, plus 25%, for good measure.
runtime/Collector.h: Bumped the block size to 256k. This seems to give the best cache performance, and it prevents us from initiating lots of VM traffic to recover very small chunks of memory.

Begin re-roll-in of r47738:47740 with Windows crash fixed

2:26 PM Changeset in webkit [47794] by jparent@chromium.org

1 edit
1 add in trunk/LayoutTests

Follow-up to http://trac.webkit.org/changeset/47790. Add windows
specific results that are the same as the results next to the test,
since windows falls back on platform/mac.

Patch by Julie Parent <jparent@chromium.org> on 2009-08-26
Reviewed by Maciej Stachowiak.

platform/win/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Added.

2:25 PM BuildingQtOnOSX created by ironstorm@gmail.com

Initial Page for OSX build instructions

1:47 PM Changeset in webkit [47793] by levin@chromium.org

6 edits in trunk

WebCore: minor style correction and include fix for notifications
https://bugs.webkit.org/show_bug.cgi?id=28745

Patch by John Gregg <johnnyg@google.com> on 2009-08-26
Reviewed by David Levin.

No change in behavior, so no tests.

bindings/js/JSDesktopNotificationsCustom.cpp: add include of Error.h
notifications/Notification.cpp: change enum style to InterCaps

(WebCore::Notification::Notification):

notifications/NotificationPresenter.h:

(WebCore::NotificationPresenter::):

WebKitTools: Minor style correction and include fix for notifications
https://bugs.webkit.org/show_bug.cgi?id=28745

Patch by John Gregg <johnnyg@google.com> on 2009-08-26
Reviewed by David Levin.

DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: change to correct EnumStyle

(DRTDesktopNotificationPresenter::checkNotificationPermission):

1:45 PM Changeset in webkit [47792] by levin@chromium.org

14 edits
1 copy
2 adds in trunk

WebKitTools: XMLHttpRequest.withCredentials=false shouldn't save cookies.
https://bugs.webkit.org/show_bug.cgi?id=28743

Patch by David Levin <levin@chromium.org> on 2009-08-26
Reviewed by Alexey Proskuryakov.

Added the support to the layout test controller on OSX and
Windows (for CFNETWORK) to allow for changing the accept cookie
policy.

DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Added a bool
to track the state of accepting cookies.
(setAlwaysAcceptCookiesCallback): Standard wrapper method
to go from js to a C++ method.
(LayoutTestController::staticFunctions): Added the
setAlwaysAcceptCookies method to the js layoutTestController.

DumpRenderTree/LayoutTestController.h:

(LayoutTestController::alwaysAcceptCookies): Returns the value.

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setAlwaysAcceptCookies): Stub out method.

DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues): Reset the accept cookie to
its default.

DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setAlwaysAcceptCookies): Does the work for
OSX to change the cookie accept policy.

DumpRenderTree/win/DumpRenderTree.cpp:

(setAlwaysAcceptCookies): Method to handle all the calls necessary
to change the accept cookie policy on Windows.
(resetDefaultsToConsistentValues): Reset the accept cookie to
its default.

DumpRenderTree/win/DumpRenderTreeWin.h:
DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setAlwaysAcceptCookies): Stub out method.

DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setAlwaysAcceptCookies): Stub out method.

LayoutTests: XMLHttpRequest.withCredentials=false shouldn't save cookies.
https://bugs.webkit.org/show_bug.cgi?id=28743

Patch by David Levin <levin@chromium.org> on 2009-08-26
Reviewed by Alexey Proskuryakov.

Added a test to verify that XMLHttpRequest.withCredentials=false doesn't
save cookies.

http/tests/xmlhttprequest/cross-origin-cookie-storage-expected.txt: Added.
http/tests/xmlhttprequest/cross-origin-cookie-storage.html: Added.
http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php: Added.
http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php: Added the ability

to check for a cookie by name.

platform/gtk/Skipped: Skip the new test.
platform/qt/Skipped: Ditto.

1:45 PM Changeset in webkit [47791] by atwilson@chromium.org

20 edits in trunk

JavaScriptCore: postMessage() spec now supports sending arrays of ports
https://bugs.webkit.org/show_bug.cgi?id=26902

Reviewed by David Levin.

Added OwnPtr to VectorTraits so we can store OwnPtrs in Vectors.

wtf/VectorTraits.h:

WebCore: postMessage() spec now supports sending arrays of ports
https://bugs.webkit.org/show_bug.cgi?id=26902

Reviewed by David Levin.

Added support for sending multiple ports at once via postMessage(). JS bindings will be updated in an upcoming patch.

No new tests, since the new functionality is not exposed via new JS bindings yet, so the old tests suffice.

WebCore.xcodeproj/project.pbxproj:

Mark MessagePort.h and MessagePortChannel.h as private since they are used by WebKit now.

dom/MessageEvent.cpp:

Updated APIs to support passing MessagePortArrays.
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):
(WebCore::MessageEvent::messagePort):

dom/MessageEvent.h:

(WebCore::MessageEvent::create):
Now accepts a MessagePortArray parameter instead of a single MessagePort.
(WebCore::MessageEvent::ports):

dom/MessagePort.cpp:

(WebCore::MessagePort::postMessage):
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):
Added new static function to extract a MessagePortChannelArray from a MessagePortArray.
(WebCore::MessagePort::entanglePorts):
Added new static function to generate a MessagePortArray (entangled ports) from a MessagePortChannelArray.

dom/MessagePort.h:
dom/MessagePortChannel.cpp:

EventData now contains a MessagePortChannelArray field instead of a single MessagePortChannel.
(WebCore::MessagePortChannel::EventData::create):
(WebCore::MessagePortChannel::EventData::EventData):

dom/MessagePortChannel.h:

(WebCore::MessagePortChannel::EventData::channels):

page/DOMWindow.cpp:

(WebCore::PostMessageTimer::PostMessageTimer):
(WebCore::PostMessageTimer::event):
(WebCore::DOMWindow::postMessage):
Now accepts a MessagePortArray parameter instead of a single MessagePort.

page/DOMWindow.h:
workers/DedicatedWorkerContext.cpp:

(WebCore::DedicatedWorkerContext::postMessage):
Now accepts a MessagePortArray parameter instead of a single MessagePort.
(WebCore::DedicatedWorkerContext::dispatchMessage):

workers/DedicatedWorkerContext.h:
workers/Worker.cpp:

(WebCore::Worker::postMessage):
Now accepts a MessagePortArray parameter instead of a single MessagePort.
(WebCore::Worker::dispatchMessage):

workers/Worker.h:
workers/WorkerContextProxy.h:
workers/WorkerMessagingProxy.cpp:

Updated WorkerObjectProxy and WorkerContextProxy API implementations to support sending multiple MessagePorts.
(WebCore::MessageWorkerContextTask::create):
(WebCore::MessageWorkerContextTask::MessageWorkerContextTask):
(WebCore::MessageWorkerContextTask::performTask):
(WebCore::MessageWorkerTask::create):
(WebCore::MessageWorkerTask::MessageWorkerTask):
(WebCore::MessageWorkerTask::performTask):
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerContext):

workers/WorkerMessagingProxy.h:
workers/WorkerObjectProxy.h:

Updated WorkerObjectProxy and WorkerContextProxy APIs to support sending multiple MessagePorts.

1:26 PM Changeset in webkit [47790] by jparent@chromium.org

3 edits
1 add in trunk/LayoutTests

Add Mac specific results for xhr-missing-file-expection test since it
incorrectly always has statusText of "OK" due to
https://bugs.webkit.org/show_bug.cgi?id=24572 and update the results
that are next to the file to use "Not Found" since that is more correct
and matches IE, FF, Chrome.

Patch by Julie Parent <jparent@chromium.org> on 2009-08-26
Reviewed by Alex Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=28723

http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt:
platform/mac/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Added.
platform/win/Skipped: Stop skipping the test.

1:25 PM Changeset in webkit [47789] by Dimitri Glazkov

2 edits in trunk/WebKitTools

2009-08-26 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed.

Remove accidentally left in clobber option.
https://bugs.webkit.org/show_bug.cgi?id=28400

BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.

1:05 PM Changeset in webkit [47788] by eric@webkit.org

3 edits
11 adds in trunk/WebCore

2009-08-26 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

SocketStreamHandle interface for WebSocket API
https://bugs.webkit.org/show_bug.cgi?id=28037

Add build systems only for GNUmakefile.am and WebCore.xcodeproj.now.
Other build systems will be updated once the code is functional.
Tests will be landed once this code is complete and functional.

GNUmakefile.am:
WebCore.xcodeproj/project.pbxproj:
platform/network/SocketStreamErrorBase.cpp: Added.
platform/network/SocketStreamErrorBase.h: Added.
platform/network/SocketStreamHandleBase.cpp: Added.
platform/network/SocketStreamHandleBase.h: Added.
platform/network/SocketStreamHandleClient.h: Added.
platform/network/cf/SocketStreamError.h: Added.
platform/network/cf/SocketStreamHandle.h: Added.
platform/network/cf/SocketStreamHandleCFNet.cpp: Added.
platform/network/soup/SocketStreamError.h: Added.
platform/network/soup/SocketStreamHandle.h: Added.
platform/network/soup/SocketStreamHandleSoup.cpp: Added.

1:04 PM Changeset in webkit [47787] by Dimitri Glazkov

3 edits in trunk/WebKitTools

2009-08-17 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Mark Rowe.

Add canary-style Chromium WebKit build slave to the waterfall.
https://bugs.webkit.org/show_bug.cgi?id=28400

BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.

12:55 PM Changeset in webkit [47786] by eric@webkit.org

2 edits in trunk/WebCore

2009-08-26 Mads Ager <ager@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] setTimeout does not convert non-string argument to string
https://bugs.webkit.org/show_bug.cgi?id=28739

Convert non-string argument to setTimeout to string in the V8
bindings.

bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl):

11:48 AM Changeset in webkit [47785] by mrowe@apple.com

3 edits in trunk/WebKitSite

Upgrade WordPress to the latest version.

blog/wp-includes/version.php:
blog/wp-login.php:

11:08 AM Changeset in webkit [47784] by xan@webkit.org

2 edits in trunk/JavaScriptCore

2009-08-26 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

Remove duplicated files from file list.

GNUmakefile.am:

10:40 AM Changeset in webkit [47783] by oliver@apple.com

3 edits in trunk/JavaScriptCore

More export fixes.

10:33 AM Changeset in webkit [47782] by oliver@apple.com

3 edits in trunk/JavaScriptCore

Hopefully fix all the exports from JSC on windows

10:12 AM Changeset in webkit [47781] by oliver@apple.com

6 edits in trunk/JavaScriptCore

Build fix

9:52 AM Changeset in webkit [47780] by oliver@apple.com

69 edits
1 copy
4 adds in trunk

[ES5] Implement getOwnPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=28724

Reviewed by Gavin Barraclough.

JavaScriptCore:
Implement the core runtime support for getOwnPropertyDescriptor.
This adds a virtual getOwnPropertyDescriptor method to every class
that implements getOwnPropertySlot that shadows the behaviour of
getOwnPropertySlot. The alternative would be to make getOwnPropertySlot
(or PropertySlots in general) provide property attribute information,
but quick testing showed this to be a regression.

WebCore:
Implement the WebCore side of getOwnPropertyDescriptor. This
requires a custom implementation of getOwnPropertyDescriptor
for every class with a custom implementation of getOwnPropertySlot.

The bindings generator has been updated to generate appropriate
versions of getOwnPropertyDescriptor for the general case where
a custom getOwnPropertyDescriptor is not needed. ES5 is vague
about how getOwnPropertyDescriptor should work in the context of
"host" functions with polymorphic GetOwnProperty, so it seems
okay that occasionally we "guess" what attributes -- eg. determining
whether a property is writable.

Test: fast/js/getOwnPropertyDescriptor.html

7:08 AM Changeset in webkit [47779] by xan@webkit.org

2 edits in trunk/WebCore

2009-08-26 Vincent Untz <vuntz@gnome.org>

Reviewed by Xan Lopez.

GObject checks for NULL (and not 0) in g_object_get, so use that
as we were already doing elsewhere to make the compiler happy.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::hasAudio):

7:06 AM Changeset in webkit [47778] by eric@webkit.org

2 edits in trunk/WebCore

2009-08-26 Alpha Lam <hclam@chromium.org>

Reviewed by David Levin.

RenderThemeMac.mm has incorrect casting for media control element.
https://bugs.webkit.org/show_bug.cgi?id=28730

MediaControlMuteButtonElement was incorrectly casted to
MediaControlPlayButtonElement. This is corrected in this patch.

No new tests because this is code cleanup and is already covered by existing
media layout tests.

rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaMuteButton):

6:56 AM Changeset in webkit [47777] by eric@webkit.org

2 edits in trunk/WebCore

2009-08-26 Robert Sesek <rsesek@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Multi-value select boxes cannot do non-contiguous selection on Mac
https://bugs.webkit.org/show_bug.cgi?id=28670

Change the condition regarding the key modifier check for non-contiguous
selection on a multi-value list from just PLATFORM(MAC) to

PLATFORM(MAC)

(PLATFORM(CHROMIUM) && PLATFORM(DARWIN)).

No new tests. This patch only changes the condition on which a certain mouse
event modifier key is used.

dom/SelectElement.cpp: (WebCore::SelectElement::listBoxDefaultEventHandler):

6:31 AM Changeset in webkit [47776] by xan@webkit.org

4 edits in trunk/WebKit/gtk

2009-08-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=28738
Expose undo/redo functionality in WebKitWebView

Expose undo/redo functionality in WebKitWebView, keeping the
default bindings as they were.

WebCoreSupport/EditorClientGtk.cpp: (WebKit::):
webkit/webkitwebview.cpp: (webkit_web_view_real_undo): (webkit_web_view_real_redo): (webkit_web_view_class_init): (webkit_web_view_can_undo): (webkit_web_view_undo): (webkit_web_view_can_redo): (webkit_web_view_redo):
webkit/webkitwebview.h:

12:46 AM Changeset in webkit [47775] by barraclough@apple.com

7 edits in trunk/JavaScriptCore

How many copies of the parameters do you need?
https://bugs.webkit.org/show_bug.cgi?id=28701

Reviewed by Darin Adler.

The function parameters in JSC get copied a lot - and unnecessarily so.

Originally this happened due to duplicating FunctionBodyNodes on recompilation,
though the problem has been exacerbated by copying the parameters from the
original function body onto the executable, then back onto the real body that
will be generated (this happens on every function). And this is all made worse
since the data structures in question are a little ugly - C style arrays of C++
objects containing ref counts, so they need a full copy-construct (rather than
a simple memcpy).

This can all be greatly simplified by just punting the parameters off into
their own ref-counted object, and forgoing all the copying.

~no performance change, possible slight progression.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::makeFunction):

parser/Nodes.cpp:

(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::finishParsing):

parser/Nodes.h:

(JSC::FunctionBodyNode::parameters):
(JSC::FunctionBodyNode::parameterCount):

runtime/Executable.cpp:

(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::FunctionExecutable::compile):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::fromGlobalCode):
(JSC::FunctionExecutable::paramString):

runtime/Executable.h:

(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::parameterCount):

Aug 25, 2009:

10:49 PM Changeset in webkit [47774] by eric.carlson@apple.com

3 edits in trunk/WebCore

2009-08-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein

r47744 causes media/video-controls-with-mutation-event-handler.html to crash
https://bugs.webkit.org/show_bug.cgi?id=28732

rendering/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement):

Don't call setAttribute from the construtor, any registered mutation event
listener will cause a crash.

rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider):

Set the maxAttr here instead of in the constructor.

10:46 PM Changeset in webkit [47773] by dimich@chromium.org

3 edits in trunk/LayoutTests

Unreviewed. Skip the new test fast/dom/Window/timer-resume-on-navigation-back.html
on gtk and qt - their DRT does not yet implement overridePreference.

platform/gtk/Skipped:
platform/qt/Skipped:

10:17 PM Changeset in webkit [47772] by dimich@chromium.org

5 edits
2 adds in trunk

WebCore: Timers from cached pages fire instantly rather than the after the specified timeout delay
https://bugs.webkit.org/show_bug.cgi?id=28683

Reviewed by Brady Eidson.

Test: fast/dom/Window/timer-resume-on-navigation-back.html

history/CachedPage.cpp:

(WebCore::CachedPage::restore): Remove duplicated Frame::restore() call, since

it should be done only once in FrameLoader::open(cachedFrame)

page/DOMTimer.cpp: Added a debug-only flag and ASSERT to catch out-of-order suspense/restore.

(WebCore::DOMTimer::DOMTimer): Ditto.
(WebCore::DOMTimer::suspend): Ditto.
(WebCore::DOMTimer::resume): Ditto.

page/DOMTimer.h: Ditto.

LayoutTests: Timers from cached pages fire instantly rather than the specified timeout delay
https://bugs.webkit.org/show_bug.cgi?id=28683

Reviewed by Brady Eidson.

Added test to verify the fix - it uses page cache and measures the timer callback fire time.

fast/dom/Window/timer-resume-on-navigation-back-expected.txt: Added.
fast/dom/Window/timer-resume-on-navigation-back.html: Added.

10:10 PM Changeset in webkit [47771] by eric.carlson@apple.com

2 edits
1 add in trunk/WebCore

2009-08-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Setting the volume of a media element has no effect if called too early
https://bugs.webkit.org/show_bug.cgi?id=28731

manual-tests/audio-volume.html:

Added.

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setRate):

Don't bail if metadata hasn't been loaded, it is fine to set rate and/or
volume as soon as the movie has been created.

8:02 PM Changeset in webkit [47770] by levin@chromium.org

2 edits in trunk/WebCore

DocumentThreadableLoader::getShouldUseCredentialStorage should allow for synchronous callbacks from SubresourceLoader::create.
https://bugs.webkit.org/show_bug.cgi?id=28728

Patch by David Levin <levin@chromium.org> on 2009-08-25
Reviewed by Maciej Stachowiak.

Test: This code path is exercised while running xhr layout tests in chromium.

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::getShouldUseCredentialStorage): When called
back synchronously, the loader is 0, so the assert is changed to allow for that.
(WebCore::DocumentThreadableLoader::loadRequest): Synchronous callbacks may be
done before SubresourceLoader::create finishes, so ensure that any previous loader
-- from a preflight request -- is cleared before calling SubresourceLoader::create.

6:06 PM Changeset in webkit [47769] by bfulgham@webkit.org

2 edits in trunk/WebKitLibraries

Rubber stamped by Steve Falkenburg.

debug_wincairo.vsprops was linking against wrong C runtime.

win/tools/vsprops/debug_wincairo.vsprops: Link to correct C runtime (as in the standard 'debug.vsprops' file.)

5:57 PM Changeset in webkit [47768] by mrowe@apple.com

2 edits in trunk/WebCore

Stop installing IDL files in to the framework.

WebCore.xcodeproj/project.pbxproj:

5:51 PM Changeset in webkit [47767] by eric@webkit.org

6 edits
4 adds in trunk

2009-08-25 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Support for HTMLInputElement::list and HTMLInputElement::selectedOption.
https://bugs.webkit.org/show_bug.cgi?id=27756

Tests: fast/forms/input-list.html

fast/forms/input-selectedoption.html

html/HTMLAttributeNames.in:
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::list): (WebCore::HTMLInputElement::selectedOption):
html/HTMLInputElement.h:
html/HTMLInputElement.idl:

2009-08-25 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Support for HTMLInputElement::list and HTMLInputElement::selectedOption.
https://bugs.webkit.org/show_bug.cgi?id=27756

fast/forms/input-list-expected.txt: Added.
fast/forms/input-list.html: Added.
fast/forms/input-selectedoption-expected.txt: Added.
fast/forms/input-selectedoption.html: Added.

5:42 PM Changeset in webkit [47766] by Darin Adler

11 edits
1 add in branches/one-view

WebCore: Some work on one-view WebKit.

Patch by Darin Adler <Darin Adler> on 2009-08-25
Reviewed by David Hyatt.

page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMousePressEventToSubframe): Send the event to the
frame -- don't involve the NSView objects.
(WebCore::EventHandler::passMouseMoveEventToSubframe): Ditto.
(WebCore::EventHandler::passMouseReleaseEventToSubframe): Ditto.

WebKit: Some work on one-view WebKit.

Patch by Darin Adler <Darin Adler> on 2009-08-25
Reviewed by David Hyatt.

WebKit.xcodeproj/project.pbxproj: Added WebView/WebViewEventHandling.mm.

WebKit/mac: Some work on one-view WebKit.

Patch by Darin Adler <Darin Adler> on 2009-08-25
Reviewed by David Hyatt.

WebCoreSupport/WebDragClient.mm:

(WebDragClient::startDrag): Change code to use WebView instead of
WebHTMLView.

WebView/WebHTMLView.mm:

(-[WebHTMLView rightMouseUp:]): ASSERT_NOT_REACHED.
(-[WebHTMLView menuForEvent:]): Ditto.
(-[WebHTMLView mouseDown:]): Ditto.
(-[WebHTMLView mouseDragged:]): Ditto.
(-[WebHTMLView mouseUp:]): Ditto.
(-[WebHTMLView otherMouseDown:]): Ditto.
(-[WebHTMLView otherMouseDragged:]): Ditto.
(-[WebHTMLView otherMouseUp:]): Ditto.
(-[WebHTMLView _mouseDownEvent]): Ditto.

WebView/WebView.mm:

(-[WebView _close]): Call _closingEventHandling.
(-[WebView viewWillMoveToWindow:]): Added calls to
_removeMouseMovedObserverUnconditionally and _addMouseMovedObserver.
(-[WebView _windowDidBecomeKey:]): Added non-main-thread handling,
and _addMouseMovedObserver
(-[WebView _windowDidResignKey:]): Added non-main-thread handling,
completion controller code, and _removeMouseMovedObserver.
(-[WebView _windowWillOrderOnScreen:]): Added non-main-thread handling.
(-[WebView _windowWillClose:]): Ditto.

WebView/WebViewData.h: Added toolTip, lastToolTipTag, trackingRectOwner,

trakcingRectUserData, observingMouseMovedNotifications, and exposeInputContext.

WebView/WebViewData.mm:

(-[WebViewPrivate dealloc]): Release a few more things. Sorted the list
of things to release with the sort tool.

WebView/WebViewEventHandling.mm: Added. Moved a lot of code in here.

WebView/WebViewInternal.h: Moved items to the WebViewEventHandling

category.

5:33 PM Changeset in webkit [47765] by Darin Adler

1 copy in branches/one-view

Create a branch for some one-view WebKit work.

4:24 PM Changeset in webkit [47764] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-08-25 Cameron McCormack <cam@mcc.id.au>

Reviewed by Darin Adler.

make-script-test-wrappers should be executable
https://bugs.webkit.org/show_bug.cgi?id=28669

Make make-script-test-wrappers and update-sources-list.py both be
executable.

Scripts/update-sources-list.py:
Scripts/make-script-test-wrappers:

4:07 PM Changeset in webkit [47763] by eric.carlson@apple.com

44 edits
12 adds in trunk

2009-08-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible (edit)
https://bugs.webkit.org/show_bug.cgi?id=28081

Test: accessibility/media-element.html

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:

Add AccessibilityMediaControls.cpp/.h

accessibility/AXObjectCache.cpp:
accessibility/AXObjectCache.h: (WebCore::AXObjectCache::getOrCreate):

Create AccessibilityMediaControl. Update Copyright

accessibility/AccessibilityMediaControls.cpp:
accessibility/AccessibilityMediaControls.h:

Added.

accessibility/AccessibilityObject.cpp:
accessibility/AccessibilityObject.h:

Add isMediaTimeline. Update Copyright.

accessibility/AccessibilitySlider.h:

Make constructor protected instead of private so AccessibilityMediaTimeline can
call it.

accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeNames]):

Add NSAccessibilityValueDescriptionAttribute to range attributes.

(-[AccessibilityObjectWrapper subrole]):

Return NSAccessibilityTimelineSubrole for AccessibilityMediaTimeline.

dom/Node.h:

add isMediaControlElement.

page/mac/WebCoreViewFactory.h:
platform/LocalizedStrings.h:
platform/mac/LocalizedStringsMac.mm: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):

New, return localized media controller strings.

platform/gtk/LocalizedStringsGtk.cpp: (WebCore::mediaElementLoadingStateText): (WebCore::mediaElementLiveBroadcastStateText):

Move inside of "#if ENABLE(VIDEO)"

(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
(WebCore::localizedMediaTimeDescription):

rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::MediaControlElement):

Initialize m_displayType.

(WebCore::MediaControlElement::MediaControlElement):
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):

Fix style.

(WebCore::MediaControlInputElement::MediaControlInputElement):

Set m_displayType based on pseudo style ID.

(WebCore::MediaControlInputElement::MediaControlInputElement):

rename local "o" to "object".

(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):

Update for MediaControlInputElement constructor change.

(WebCore::MediaControlTimeDisplayElement::formatTime):

New, moved here from RenderMedia so AccessibilityMediaTimeDisplay can use it.

(WebCore::MediaControlTimeDisplayElement::setCurrentValue):

New, set text to current time.

rendering/MediaControlElements.h:

rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):

Create controls in tab order.

(WebCore::RenderMedia::formatTime):

Moved to MediaControlTimeDisplayElement::formatTime.

(WebCore::RenderMedia::updateTimeDisplay):

Call MediaControlTimeDisplayElement::setCurrentValue.

rendering/RenderMedia.h:

2009-08-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

Add localized strings for media controller accessiblility.

English.lproj/Localizable.strings:

2009-08-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory localizedMediaControlElementString:]): (-[WebViewFactory localizedMediaControlElementHelpText:]): (-[WebViewFactory localizedMediaTimeDescription:]):

New.

2009-08-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):

New.

2009-08-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

accessibility/media-element.html: Added.
platform/mac/accessibility/media-element-expected.txt: Added.
media/video-controls-visible-audio-only.html:
platform/mac-leopard/accessibility/media-element-expected.txt: Added.
platform/mac-leopard/media/controls-drag-timebar-expected.txt: Added.
platform/mac-leopard/media/controls-strict-expected.txt: Added.
platform/mac-leopard/media/video-controls-rendering-expected.txt: Added.
platform/mac-leopard/media/video-display-toggle-expected.txt: Added.
platform/win/media/controls-strict-expected.txt: Added.
platform/win/media/video-controls-rendering-expected.txt: Added.
platform/win/media/video-display-toggle-expected.txt: Added.

Added.

platform/mac-leopard/media/audio-controls-rendering-expected.txt:
platform/mac-leopard/media/controls-after-reload-expected.txt:
platform/mac-leopard/media/controls-styling-expected.txt:
platform/mac-leopard/media/video-zoom-controls-expected.txt:
platform/mac/media/audio-controls-rendering-expected.txt:
platform/mac/media/controls-after-reload-expected.txt:
platform/mac/media/controls-styling-expected.txt:
platform/mac/media/video-zoom-controls-expected.txt:
platform/win/media/audio-controls-rendering-expected.txt:
platform/win/media/controls-after-reload-expected.txt:
platform/win/media/controls-drag-timebar-expected.txt:
platform/win/media/controls-styling-expected.txt:

Update for controller element tab order change.

platform/gtk/Skipped:
platform/win/Skipped:

Skip new test.

4:03 PM Changeset in webkit [47762] by bfulgham@webkit.org

6 edits in trunk

WebKit/win: Build fix for Windows.

Revise Debug_Cairo build target to build testapi, jsc, WinLauncher,
DumpRenderTree, and TestNetscapeAPI using WinCairo debug build
settings so they link against the proper libraries.

WebKit.vcproj/WebKit.sln:

WebKitTools: Build fix

Revise Debug_Cairo targets to point inherit from the
debug_wincairo.vsprops property sheet so that they link
against the proper libraries in Debug build.

DumpRenderTree/win/DumpRenderTree.vcproj:
DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
WinLauncher/WinLauncher.vcproj:

3:59 PM Changeset in webkit [47761] by mrowe@apple.com

1 edit in trunk/WebKitLibraries/win/tools/scripts/PRODUCTVERSION

Versioning.

3:54 PM Changeset in webkit [47760] by bfulgham@webkit.org

3 edits in trunk/JavaScriptCore

JavaScriptCore.vcproj/jsc/jsc.vcproj: Add Debug_CFLite target that inherits from the debug_wincairo property sheet and therefore links to the proper debug library.
JavaScriptCore.vcproj/testapi/testapi.vcproj: Add Debug_CFLite target that inherits from the debug_wincairo property sheet and therefore links to the proper debug library.

Reviewed by NOBODY (Buildfix).

3:43 PM Changeset in webkit [47759] by sfalken@apple.com

3 edits in trunk/JavaScriptCore

Rolled out r44739. Causes crash on Windows.

3:38 PM Changeset in webkit [47758] by jianli@chromium.org

3 edits in trunk/WebCore

[V8] Fix Canvas layout test failures in Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=28720

Reviewed by David Levin.

The previous fix r47757 does not handle the V8 object conversion correctly.

bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

2:04 PM Changeset in webkit [47757] by jianli@chromium.org

7 edits in trunk/WebCore

[V8] Fix compiling errors in Chromium build caused by Canvas3D changes from r47752.
https://bugs.webkit.org/show_bug.cgi?id=28717

Reviewed by David Levin.

bindings/v8/DOMObjectsInclude.h:
bindings/v8/DerivedSourcesAllInOne.cpp:
bindings/v8/V8Index.cpp:
bindings/v8/V8Index.h:
bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):

1:40 PM Changeset in webkit [47756] by eric@webkit.org

4 edits in trunk/WebCore

2009-08-25 Alpha Lam <hclam@chromium.org>

Reviewed by David Levin.

[chromium] Implement media volume slider for chromium
https://bugs.webkit.org/show_bug.cgi?id=28715

Provided the implementation of the volume slider and its container for
chromium port. With this change there will be a usable volume control
slider for chromium theme.

No new tests since this is covered by existing media layout tests.

css/mediaControlsChromium.css: CSS style for the volume slider.
rendering/RenderThemeChromiumSkia.cpp: (WebCore::mediaSliderThumbImage): Returns the image for slider thumb. (WebCore::mediaVolumeSliderThumbImage): Returns the image for volume slider thumb. (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderTrack): Paints the track with one vertical white line. (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize): Adjusts thumb sizes according to the images. (WebCore::RenderThemeChromiumSkia::paintMediaSliderThumb): Paints slider thumb image. (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderThumb): Paints volume slider thumb image.

12:56 PM Changeset in webkit [47755] by cmarrin@apple.com

1 edit in trunk/WebCore/html/HTMLCanvasElement.cpp

Fixed a build problem on Tiger

12:45 PM Changeset in webkit [47754] by cmarrin@apple.com

1 edit
2 adds in trunk/WebCore

Missed checking in 2 Canvas3D files
https://bugs.webkit.org/show_bug.cgi?id=28018

12:31 PM Changeset in webkit [47753] by abarth@webkit.org

3 edits
3 adds in trunk

2009-08-25 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

[V8] Exception from JavaScript propagates to main script
https://bugs.webkit.org/show_bug.cgi?id=26433

Test that both compile time and runtime exceptions thrown in
javascript URLs are isolated from the main script.

fast/dom/javascript-url-exception-isolation-expected.txt: Added.
fast/dom/javascript-url-exception-isolation.html: Added.
fast/dom/resources/javascript-url-exception-isolation.js: Added.

2009-08-25 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

[V8] Exception from JavaScript propagates to main script
https://bugs.webkit.org/show_bug.cgi?id=26433

Make sure that exceptions thrown both at compile time and at
runtime in javascript URLs are isolated from the main script.

Test: fast/dom/javascript-url-exception-isolation.html

bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate):

11:45 AM Changeset in webkit [47752] by cmarrin@apple.com

27 edits in trunk

Added all new Canvas3D files to the build
https://bugs.webkit.org/show_bug.cgi?id=28018

This also hooks up CanvasRenderingContext as the common base class for
CanvasRenderingContext2D and CanvasRenderingContext3D. And it adds a bit
of logic throughout to support the new CanvasRenderingContext3D object.
But nothing is hooked up yet.

11:30 AM Changeset in webkit [47751] by levin@chromium.org

6 edits in trunk

PLATFORM(CFNETWORK) should be USE(CFNETWORK).
https://bugs.webkit.org/show_bug.cgi?id=28713

Patch by David Levin <levin@chromium.org> on 2009-08-25
Reviewed by Adam Roben.

JavaScriptCore:

wtf/Platform.h: Added a #define to catch this issue in the

future. The define would generate an error on gcc without the
space in the expansion, but Visual C++ needs the space to cause an error.

WebKit/win:

Also, moved the #if header section after the other #includes.

WebError.cpp:

(WebError::localizedDescription):

WebKitTools:

DumpRenderTree/win/DumpRenderTree.cpp:

(main):

10:14 AM Changeset in webkit [47750] by bfulgham@webkit.org

6 edits
1 add in trunk

JavaScriptCore: Revise CFLite Debug build to emit DLL's with _debug label.
https://bugs.webkit.org/show_bug.cgi?id=28695.

Reviewed by Steve Falkenburg.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Modify Cairo debug build to inherit from new debug_cairo property sheet.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCFLite.vsprops: Modify to look for debug CFLite when in debug build.

WebKit/win: Revise CFLite Debug build to emit DLL's with _debug label.
https://bugs.webkit.org/show_bug.cgi?id=28695.

Reviewed by Steve Falkenburg.

WebKit.vcproj/WebKit.vcproj: Modify Debug_Cairo target to inherit from new debug_wincairo property sheet, instead of the current debug sheet.

WebKitLibraries: Revise CFLite Debug build to emit DLL's with _debug label.
https://bugs.webkit.org/show_bug.cgi?id=28695.

Reviewed by Steve Falkenburg.

win/tools/vsprops/debug_wincairo.vsprops: Added.

10:09 AM Changeset in webkit [47749] by mitz@apple.com

4 edits in trunk/WebCore

REGRESSION (r47630): fast/repaint/background-generated.html is failing
https://bugs.webkit.org/show_bug.cgi?id=28704

Reviewed by Anders Carlsson.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize): Handle SizeNone.

rendering/style/FillLayer.cpp:

(WebCore::FillLayer::FillLayer): Initialize the size type to SizeNone.

rendering/style/FillLayer.h:

(WebCore::FillSize::FillSize): Changed assignment to initialization and

removed redundant assignment to size.

9:28 AM Changeset in webkit [47748] by eric@webkit.org

2 edits in trunk/WebCore

2009-08-25 Yusuke Sato <yusukes@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Complex text doesn't show up with text stroking
https://bugs.webkit.org/show_bug.cgi?id=28707

Skip the NULL check of m_hdc if Windows GDI is not in use.

platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawComplexText):

6:14 AM Changeset in webkit [47747] by kenneth@webkit.org

8 edits in trunk/LayoutTests

[Qt] Update outdated metrics in css1/font_properties. All tests pass.

Patch by Renata Hodovan <hodovan.renata@stud.u-szeged.hu> on 2009-08-25
Reviewed by Ariya Hidayat.

platform/qt/Skipped:
platform/qt/css1/font_properties/font-expected.txt:
platform/qt/css1/font_properties/font_family-expected.txt:
platform/qt/css1/font_properties/font_size-expected.txt:
platform/qt/css1/font_properties/font_style-expected.txt:
platform/qt/css1/font_properties/font_variant-expected.txt:
platform/qt/css1/font_properties/font_weight-expected.txt:

6:12 AM Changeset in webkit [47746] by kenneth@webkit.org

4 edits in trunk/WebKit/qt

2009-08-25 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Ariya Hidayat.

Bug 28708 - Make possible to better use ResourceError in FrameLoaderClientQt class.

Api/qwebframe.cpp: (QWebFrame::requestedUrl):
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): (WebCore::FrameLoaderClientQt::postProgressFinishedNotification): (WebCore::FrameLoaderClientQt::dispatchDidFailProvisionalLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoad):
WebCoreSupport/FrameLoaderClientQt.h:

6:08 AM Changeset in webkit [47745] by kenneth@webkit.org

8 edits
12 adds in trunk/LayoutTests

[Qt] Update outdated font metrics and add expected files for new tests.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-08-25
Reviewed by Ariya Hidayat.

platform/qt/Skipped:
platform/qt/fast/backgrounds/001-expected.txt:
platform/qt/fast/backgrounds/animated-gif-as-background-expected.txt: Added.
platform/qt/fast/backgrounds/animated-svg-as-background-expected.txt: Added.
platform/qt/fast/backgrounds/animated-svg-as-mask-expected.txt: Added.
platform/qt/fast/backgrounds/background-clip-text-expected.txt: Added.
platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
platform/qt/fast/backgrounds/background-origin-root-element-expected.txt: Added.
platform/qt/fast/backgrounds/background-position-1-expected.txt: Added.
platform/qt/fast/backgrounds/background-position-rounding-expected.txt: Added.
platform/qt/fast/backgrounds/mask-composite-expected.txt: Added.
platform/qt/fast/backgrounds/opacity-on-document-element-expected.txt: Added.
platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt: Added.
platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
platform/qt/fast/backgrounds/size/backgroundSize15-expected.txt:
platform/qt/fast/backgrounds/size/zero-expected.txt: Added.
platform/qt/fast/backgrounds/solid-color-context-restore-expected.txt:
platform/qt/fast/backgrounds/svg-as-mask-expected.txt: Added.

5:04 AM Changeset in webkit [47744] by eric@webkit.org

18 edits in trunk/WebCore

2009-08-25 Alpha Lam <hclam@chromium.org>

Reviewed by David Levin.

Media controls panel does not have a volume control slider
https://bugs.webkit.org/show_bug.cgi?id=28241

Introduced "-webkit-media-controls-volume-slider",
"-webkit-media-controls-volume-slider-container" and the supporting
implementation. Also added appearances of "media-volume-slider" and
"media-volume-slider-container".

The implementation of the controls are in WebCore::MediaControlElements.
Logic to trigger the display of the volume controls are in WebCore::RenderMedia.

No new tests since this change doesn't have theme implementation and the
volume slider is disabled by default.

accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation): Marks that volume slider is vertical.
css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added corresponding CSS values.
css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): ditto.
css/CSSSelector.h: (WebCore::CSSSelector::): ditto.
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto.
css/CSSValueKeywords.in: ditto.
css/mediaControls.css: Makes the volume slider disabled by default.
platform/ThemeTypes.h: Defines theme parts for volume slider and its container. (WebCore::):
rendering/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement): (WebCore::MediaControlVolumeSliderContainerElement::styleForElement): Adjust the CSS values for "display", "postion", "left" and "top" according to member variables. (WebCore::MediaControlVolumeSliderContainerElement::setVisible): Affects the "display" CSS value. (WebCore::MediaControlVolumeSliderContainerElement::setPosition): Affects the "left" and "top" CSS values. (WebCore::MediaControlVolumeSliderContainerElement::hitTest): Hit testing this element. (WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): (WebCore::MediaControlVolumeSliderElement::defaultEventHandler): Modifies the volume using the slider value, allows dragging.
rendering/MediaControlElements.h: (WebCore::): Added definition for MediaControlVolumeSliderElement and MediaControlVolumeSliderContainerElement. (WebCore::MediaControlVolumeSliderContainerElement::isVisible): Inline getter.
rendering/RenderMedia.cpp: (WebCore::RenderMedia::styleDidChange): Updates styles for volume container and volume slider. (WebCore::RenderMedia::createVolumeSliderContainer): Creates volume slider container and attach to panel. (WebCore::RenderMedia::createVolumeSlider): Creates volume slider and attach to volume slider container. (WebCore::RenderMedia::updateControls): Updates volume container and volume slider. (WebCore::RenderMedia::updateVolumeSliderContainer): Sets the visibility and position of volume slider container and its child. (WebCore::RenderMedia::forwardEvent): Hit testing the volume slider container and volume slider to toggle the visibility and forward events to slider.
rendering/RenderMedia.h: Added definition for RenderMedia::updateVolumeSliderContainer().
rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart): Not implemented.
rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Makes volume slider vertical. (WebCore::RenderSlider::thumbRect): ditto. (WebCore::RenderSlider::mouseEventIsInThumb): ditto. (WebCore::RenderSlider::setValueForPosition): ditto. (WebCore::RenderSlider::positionForOffset): ditto. (WebCore::RenderSlider::currentPosition): ditto. (WebCore::RenderSlider::trackSize): ditto.
rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): Adjust style for volume slider thumb. (WebCore::RenderTheme::paint): Paints volume control parts using theme.
rendering/RenderTheme.h: (WebCore::RenderTheme::paintMediaVolumeSliderContainer): Naive implementation to be overridden. (WebCore::RenderTheme::paintMediaVolumeSliderTrack): ditto. (WebCore::RenderTheme::paintMediaVolumeSliderThumb): ditto.
rendering/style/RenderStyleConstants.h: (WebCore::): Constants for volume control parts.

4:36 AM Changeset in webkit [47743] by vestbo@webkit.org

5 edits in trunk

[Qt/Mac] Use CONFIG+=build_all only when building libraries

Reviewed by Ariya Hidayat.

If no configuration is specified when building WebKit we pass the
debug_and_release option to QMake which results in Makefiles for
both configurations being generated.

Previously we built both of these configurations by default, for
all targets (both the QtWebKit framework/dyldlib and the various
executables such as QtLauncher and tests). This makes sense for
the libraries, which get the _debug suffix and can be loaded on
demand by setting the DYLD_IMAGE_SUFFIX, but for executables we
ended up building the same executable twice.

We now only build one instance of each executable, and since this
is a developer build we build the debug-version. Passing either
--debug or --release to build-webkit will override this, and
even in the default case the release version can still be built
by running 'make release' in the the build directory of each
target.

WebCore.pro:
DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
Scripts/webkitdirs.pm:

12:18 AM Changeset in webkit [47742] by xan@webkit.org

2 edits in trunk/WebCore

2009-08-25 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=28690
Build failure in webkitgtk+-1.1.3

Do not use deprecated function to unref a pixbuf.

platform/gtk/CursorGtk.cpp: (WebCore::Cursor::Cursor):

Aug 24, 2009:

11:53 PM Changeset in webkit [47741] by abarth@webkit.org

8 edits
2 adds in trunk

2009-08-24 Hironori Bono <hbono@chromium.org>

Reviewed by Adam Barth.

Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
<https://bugs.webkit.org/show_bug.cgi?id=27827>.

Because of the lack of mappings from GDK key-codes to WebKit key-codes,
Chromium cannot send valid key-codes to JavaScript when a user types
function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.

To write layout tests for this issue, added mappings from function-key
names to platform-specific key-codes to EventSendingController objects
so that eventSender.keyDown() can send function-key events without using
platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
is only for Mac. So this change adds this new test to Skipped tests for other
platforms to prevent this change from crashing the build trees.)

fast/events/keydown-function-keys-expected.txt: Added.
fast/events/keydown-function-keys.html: Added.
platform/gtk/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

2009-08-24 Hironori Bono <hbono@chromium.org>

Reviewed by Adam Barth.

Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
<https://bugs.webkit.org/show_bug.cgi?id=27827>.

Because of the lack of mappings from GDK key-codes to WebKit key-codes,
Chromium cannot send valid key-codes to JavaScript when a user types
function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.

To write layout tests for this issue, added mappings from function-key
names to platform-specific key-codes to EventSendingController objects
so that eventSender.keyDown() can send function-key events without using
platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
is only for Mac. So this change adds this new test to Skipped tests for other
platforms to prevent this change from crashing the build trees.)

Test: fast/events/keydown-function-keys.html

platform/chromium/KeyCodeConversionGtk.cpp: Add mappings from GDK key-codes to WebKit key-code for function keys. (WebCore::windowsKeyCodeForKeyEvent):

2009-08-24 Hironori Bono <hbono@chromium.org>

Reviewed by Adam Barth.

Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
<https://bugs.webkit.org/show_bug.cgi?id=27827>.

Because of the lack of mappings from GDK key-codes to WebKit key-codes,
Chromium cannot send valid key-codes to JavaScript when a user types
function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.

To write layout tests for this issue, added mappings from function-key
names to platform-specific key-codes to EventSendingController objects
so that eventSender.keyDown() can send function-key events without using
platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
is only for Mac. So this change adds this new test to Skipped tests for other
platforms to prevent this change from crashing the build trees.)

DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:]):

9:23 PM Changeset in webkit [47740] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: start out with a 32-bit value to avoid a shortening warning.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-24

runtime/Collector.cpp:

(JSC::Heap::sweep):

9:09 PM Changeset in webkit [47739] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Substantially reduced VM thrash in the GC heap.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-24
Reviewed by Oliver Hunt.

1.08x faster on v8 (1.60x faster on v8-splay).

1.40x faster on bench-alloc-nonretained.

1.90x faster on bench-alloc-retained.

SunSpider says no change.

runtime/Collector.cpp:

(JSC::Heap::heapAllocate): Fixed a long-standing bug: update a few local
variables unconditionally after calling collect(), since they may be used
even if we don't "goto scan". (In the bug I saw, usedBlocks got out of
sync with heap.usedBlocks).
(JSC::Heap::sweep): Keep enough free heap space to accomodate
the number of objects we'll allocate before the next GC, plus 25%, for
good measure.

runtime/Collector.h: Bumped the block size to 256k. This seems to give

the best cache performance, and it prevents us from initiating lots of
VM traffic to recover very small chunks of memory.

7:53 PM Changeset in webkit [47738] by barraclough@apple.com

19 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=28691
Do not retain ScopeNodes outside of parsing

Reviewed by Oliver Adler & Darin Hunt.

There is now no need for these to exist outside of parsing - their use in the runtime is replaced by Executable types.

bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::get):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::makeFunction):

debugger/Debugger.cpp:

(JSC::Debugger::recompileAllJSFunctions):
(JSC::evaluateInGlobalCallFrame):

debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluate):

interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::privateExecute):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

parser/Nodes.cpp:

(JSC::ScopeNodeData::ScopeNodeData):
(JSC::ProgramNode::create):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::create):

parser/Nodes.h:

(JSC::ScopeNode::adoptData):
(JSC::FunctionBodyNode::parameterCount):

parser/Parser.cpp:
parser/Parser.h:

(JSC::Parser::arena):
(JSC::Parser::Parser):
(JSC::Parser::parse):

runtime/ArrayPrototype.cpp:

(JSC::isNumericCompareFunction):
(JSC::arrayProtoFuncSort):

runtime/Completion.cpp:

(JSC::checkSyntax):
(JSC::evaluate):

runtime/Executable.cpp:

(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::EvalExecutable::compile):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compile):
(JSC::FunctionExecutable::compile):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCode):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):
(JSC::FunctionExecutable::fromGlobalCode):
(JSC::FunctionExecutable::copyParameters):
(JSC::FunctionExecutable::paramString):

runtime/Executable.h:

(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::sourceID):
(JSC::ScriptExecutable::sourceURL):
(JSC::ScriptExecutable::lineNo):
(JSC::ScriptExecutable::lastLine):
(JSC::ScriptExecutable::usesEval):
(JSC::ScriptExecutable::usesArguments):
(JSC::ScriptExecutable::needsActivation):
(JSC::ScriptExecutable::recordParse):
(JSC::EvalExecutable::bytecode):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::bytecode):
(JSC::ProgramExecutable::reparseExceptionInfo):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::make):
(JSC::FunctionExecutable::bytecode):
(JSC::FunctionExecutable::isGenerated):
(JSC::FunctionExecutable::name):
(JSC::FunctionExecutable::parameterCount):
(JSC::FunctionExecutable::jitCode):

runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::numericCompareFunction):

runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

5:50 PM Changeset in webkit [47737] by Antti Koivisto

2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28698
Avoid unnecessary transformations for the window resizer rect.

Reviewed by Simon Fraser.

platform/Scrollbar.cpp:

(WebCore::Scrollbar::setFrameRect):

5:42 PM Changeset in webkit [47736] by ap@apple.com

2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

<rdar://problem/7161900> REGRESSION: 100 MB membuster leak on windows due to 47391
(DNS prefetching support)

platform/network/cf/DNSCFNet.cpp: (WebCore::prefetchDNS): Use a run loop from secondary thread on Windows, because there isn't one on main one.

5:09 PM Changeset in webkit [47735] by ap@apple.com

3 edits
3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=28374
Cross-scheme requests should not be blocked by appcache rules

Test: http/tests/appcache/different-scheme.html

loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache): Resources with different schemes can never be loaded from appcache.

5:03 PM Changeset in webkit [47734] by ap@apple.com

6 edits
2 adds in trunk

Reviewed by Darin Adler and Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=28688
REGRESSION(r24994): Cannot create a frame with a javascript URL

Test: http/tests/security/javascriptURL/javascriptURL-in-new-iframe.html

bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue):
bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL):
bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL):
bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc): Omit the checks if there is no document in frame yet.

3:58 PM Changeset in webkit [47733] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Skip the correct test (media/video-currentTime-set.html, not
media/video-currentTime-set2.html).

platform/gtk/Skipped:

3:47 PM Changeset in webkit [47732] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Skip 3 new tests, and reenable some of the media tests, now that
the bot it fixed to handle the fact that it doesn't have a sound
card.

platform/gtk/Skipped:

2:56 PM Changeset in webkit [47731] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Skip again tests that we enabled, since they are
failing on the bot. The tests do pass, but there is an environment
configuration problem with GStreamer on the bot (possibly related
to the fact that it has no sound card).

platform/gtk/Skipped:

2:37 PM Changeset in webkit [47730] by Darin Adler

2 edits in trunk/JavaScriptCore

runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::put): Landed revised version I had tested but forgot
to land. Leave out the branch, since we don't need one.

2:21 PM Changeset in webkit [47729] by Nate Chapin

2 edits in trunk/WebCore

2009-08-24 Nate Chapin <Nate Chapin>

Reviewed by Eric Seidel.

Fix crash in fast/css/rem-dynamic-scaling.html due to a freed
RenderStyle being accessed.

https://bugs.webkit.org/show_bug.cgi?id=28681

dom/Element.cpp: (WebCore::Element::recalcStyle): Make currentStyle a RefPtr.

2:08 PM Changeset in webkit [47728] by adachan@apple.com

3 edits in trunk/LayoutTests

Reviewed by Mark Rowe.

Skip loader/go-back-to-different-window-size.html for qt and gtk.

platform/gtk/Skipped:
platform/qt/Skipped:

2:05 PM Changeset in webkit [47727] by Darin Adler

3 edits in trunk/JavaScriptCore

Array index miss case creates a string every time
https://bugs.webkit.org/show_bug.cgi?id=28664

Patch by Darin Adler <Darin Adler> on 2009-08-24
Reviewed by Geoff Garen.

SunSpider test results I saw:

0.5% faster overall
1% faster on crypto-aes
20% faster on crypto-md5
13% faster on crypto-sha1

runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::ObjectPrototype): Initialize m_hasNoPropertiesWithUInt32Names
to true.
(JSC::ObjectPrototype::put): Clearly m_hasNoPropertiesWithUInt32Names if the new
property has a name that is the string form of a UInt32.
(JSC::ObjectPrototype::getOwnPropertySlot): Don't call JSObject::getOwnPropertySlot
if m_hasNoPropertiesWithUInt32Names is true, and it is highly likely to be true.

runtime/ObjectPrototype.h: Added declarations for the above.

1:45 PM Changeset in webkit [47726] by mitz@apple.com

2 edits in trunk/WebCore

<rdar://problem/5743105> Long freezing during loading and selecting text
of a large table
https://bugs.webkit.org/show_bug.cgi?id=14918

Reviewed by Simon Fraser.

rendering/RenderView.cpp:

(WebCore::RenderView::setSelection): Added calls to

beginDeferredRepaints() and endDeferredRepaints() around the
invalidation of the selection, in order to better coalesce multiple
invalid rectangles.

1:26 PM Changeset in webkit [47725] by pfeldman@chromium.org

5 edits in trunk/WebCore

2009-08-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Simplify findTreeElement code, get rid of potential infinite loop.

https://bugs.webkit.org/show_bug.cgi?id=28680

inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.findTreeElement):
inspector/front-end/treeoutline.js: (TreeOutline.prototype.getCachedTreeElement): (TreeOutline.prototype.findTreeElement):
inspector/front-end/utilities.js: (isAncestorNode): ():

1:20 PM Changeset in webkit [47724] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-08-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Do expand local scope when hitting the break

https://bugs.webkit.org/show_bug.cgi?id=28678

inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):

1:16 PM Changeset in webkit [47723] by adachan@apple.com

1 edit
3 adds in trunk/LayoutTests

Reviewed by Brady Eidson.

Add test for https://bugs.webkit.org/show_bug.cgi?id=28659.
Cached page should be formatted according to the current window size, not the cached frame's size.

loader: Added.
loader/go-back-to-different-window-size-expected.txt: Added.
loader/go-back-to-different-window-size.html: Added.

12:55 PM Changeset in webkit [47722] by adachan@apple.com

2 edits in trunk/WebCore

Reviewed by Steve Falkenburg.

Make sure we use the current FrameView's frame rect when
going back to a cached page.

https://bugs.webkit.org/show_bug.cgi?id=28659

loader/FrameLoader.cpp: (WebCore::FrameLoader::open):

12:10 PM Changeset in webkit [47721] by eric@webkit.org

2 edits
3 adds in trunk/LayoutTests

2009-08-24 Eric Seidel <eric@webkit.org>

No review, just updating results.

Support placeholder on textarea
https://bugs.webkit.org/show_bug.cgi?id=21248

Update expected test results form windows bot.

platform/win/fast/forms/basic-textareas-expected.txt:
platform/win/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
platform/win/fast/forms/textarea-placeholder-set-attribute-expected.txt: Added.
platform/win/fast/forms/textarea-placeholder-set-value-expected.txt: Added.

11:35 AM Changeset in webkit [47720] by eric@webkit.org

3 edits
3 adds in trunk

2009-08-24 Cameron McCormack <cam@mcc.id.au>

Reviewed by Darin Adler.

Modifying <text rotate=""> doesn't clear the corresponding SVGAnimatedNumberList
https://bugs.webkit.org/show_bug.cgi?id=28673

svg/dom/resources/text-rotate-live.js: Added. (getRotate): (getAndSetRotate):
svg/dom/text-rotate-live-expected.txt: Added.
svg/dom/text-rotate-live.html: Added.

2009-08-24 Cameron McCormack <cam@mcc.id.au>

Reviewed by Darin Adler.

Modifying <text rotate=""> doesn't clear the corresponding SVGAnimatedNumberList
https://bugs.webkit.org/show_bug.cgi?id=28673

Test: svg/dom/text-rotate-live.html

svg/SVGNumberList.cpp: (WebCore::SVGNumberList::parse): Clear the list before adding the parsed numbers.

11:07 AM Changeset in webkit [47719] by Simon Fraser

4 edits in trunk

2009-08-24 Simon Fraser <Simon Fraser>

Reviewed by NOBODY (build fix)

Turn off ENABLE_3D_CANVAS in the xconfig files.

Configurations/FeatureDefines.xcconfig:

11:02 AM Changeset in webkit [47718] by kov@webkit.org

1 copy in releases/WebKitGTK/webkit-1.1.13

Tagging WebKitGTK+ 1.1.13

9:40 AM Changeset in webkit [47717] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-08-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Only expand local scope when hitting the break

https://bugs.webkit.org/show_bug.cgi?id=28678

inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):

9:26 AM Changeset in webkit [47716] by mitz@apple.com

6 edits in trunk

WebCore:
background-size fails to parse if a single length/percentage/auto is followed by a comma
https://bugs.webkit.org/show_bug.cgi?id=28674

Reviewed by Simon Fraser.

css/CSSParser.cpp:

(WebCore::CSSParser::parseFillSize): Added an allowComma parameter,

which is set to false when this method consumes a comma. Moved
handling of 'contain' and 'cover' from parseFillProperty into this
method.

(WebCore::CSSParser::parseFillProperty): Set allowComma to true before

processing the next value, and pass allowComma to parseFillSize.

css/CSSParser.h:

LayoutTests:
background-size fails to parse if a single length/percentage/auto is followed by a comma
https://bugs.webkit.org/show_bug.cgi?id=28674

Reviewed by Simon Fraser.

fast/backgrounds/size/parsing-background-size-values-expected.txt:
fast/backgrounds/size/resources/parsing-background-size-values.js:

9:02 AM Changeset in webkit [47715] by kov@webkit.org

2 edits in trunk/JavaScriptCore

2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Fix a typo in my distcheck build fix.

GNUmakefile.am:

8:41 AM Changeset in webkit [47714] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

News about the 1.1.13 release.

NEWS:

8:28 AM Changeset in webkit [47713] by kov@webkit.org

5 edits in trunk

2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Bump package and so versions for 1.1.13 release.

configure.ac:

WebKit/gtk

2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Add new symbols, and an index of new symbols for the 1.1.13
release.

docs/webkitgtk-docs.sgml:
docs/webkitgtk-sections.txt:

7:55 AM Changeset in webkit [47712] by kov@webkit.org

2 edits
3 adds in trunk/WebCore

2009-08-17 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] Support for cursors that are images
https://bugs.webkit.org/show_bug.cgi?id=28346

Added support for cursors which are images for CursorGtk. Added
a manual test for this.

manual-tests/gtk/cursor-image.html: Added.
manual-tests/gtk/resources/redcursor.cur: Added.
platform/gtk/CursorGtk.cpp: (WebCore::Cursor::Cursor):

7:48 AM Changeset in webkit [47711] by kenneth@webkit.org

1 edit
6 adds in trunk/LayoutTests

Unreviewed. Add missing files from former commit 47709.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-08-24

platform/qt/fast/backgrounds/svg-as-background-1-expected.txt: Added.
platform/qt/fast/backgrounds/svg-as-background-2-expected.txt: Added.
platform/qt/fast/backgrounds/svg-as-background-3-expected.txt: Added.
platform/qt/fast/backgrounds/svg-as-background-4-expected.txt: Added.
platform/qt/fast/backgrounds/svg-as-background-5-expected.txt: Added.
platform/qt/fast/backgrounds/svg-as-background-6-expected.txt: Added.

7:30 AM Changeset in webkit [47710] by kov@webkit.org

6 edits in trunk

WebCore:

2009-08-24 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] Integrate GStreamer video with the graphics backend
https://bugs.webkit.org/show_bug.cgi?id=16356

Improves GStreamer backend implementation of MediaPlayerPrivate class.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateErrorCallback): Send proper MediaPlayer error for different GStreamer errors to MediaPlayerPrivate. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Move static initialization boolean to a better place. (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::duration): Return if error occured, do not consider the source as stream if duration query failed. (WebCore::MediaPlayerPrivate::currentTime): Return if error occured, use an early return. (WebCore::MediaPlayerPrivate::seek): Return if error occured. (WebCore::MediaPlayerPrivate::setEndTime): Remove implementation since this function doesn't seem to be used anywhere in WebCore. (WebCore::MediaPlayerPrivate::paused): (WebCore::MediaPlayerPrivate::seeking): (WebCore::MediaPlayerPrivate::setRate): Seek to current time when rate is set. (WebCore::MediaPlayerPrivate::maxTimeBuffered): Return if error occured. (WebCore::MediaPlayerPrivate::maxTimeSeekable): Ditto. (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto. (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::totalBytesKnown): (WebCore::MediaPlayerPrivate::totalBytes): Ditto. (WebCore::MediaPlayerPrivate::updateStates): Return if error occured, update after seek ended with a successful change (WebCore::MediaPlayerPrivate::didEnd): Do not pause the playbin when end is reached. (WebCore::MediaPlayerPrivate::loadingFailed): Update network state with the given error. (WebCore::mimeTypeCache): Gather supported mime types from GStreamer. (WebCore::MediaPlayerPrivate::getSupportedTypes): (WebCore::MediaPlayerPrivate::supportsType): (WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin): (WebCore::MediaPlayerPrivate::supportsFullscreen): First step towards fullscreen support. (WebCore::MediaPlayerPrivate::createGSTPlayBin): Use playbin2 instead of playbin, do not set playbin's audio sink.
platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_idle_func): Use C++ casts, decrease reference count of async queue at the end of the idle function. (webkit_video_sink_render): Increase reference count of async queue. (webkit_video_sink_stop): Remove any idle functions with the sink as data.

LayoutTests:

2009-08-24 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] Integrate GStreamer video with the graphics backend
https://bugs.webkit.org/show_bug.cgi?id=16356

Enable media tests that now pass.

platform/gtk/Skipped:

7:26 AM Changeset in webkit [47709] by kenneth@webkit.org

2 edits in trunk/LayoutTests

[Qt] Add results with updated font metrics for passing tests added in
r28637 and remove them from Skipped.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-08-24
Reviewed by Ariya Hidayat.

platform/qt/Skipped:
platform/qt/fast/backgrounds/svg-as-background-1-expected.txt: Added.
platform/qt/fast/backgrounds/svg-as-background-2-expected.txt: Added.
platform/qt/fast/backgrounds/svg-as-background-3-expected.txt: Added.
platform/qt/fast/backgrounds/svg-as-background-4-expected.txt: Added.
platform/qt/fast/backgrounds/svg-as-background-5-expected.txt: Added.
platform/qt/fast/backgrounds/svg-as-background-6-expected.txt: Added.

6:38 AM Changeset in webkit [47708] by cmarrin@apple.com

2 edits
6 adds in trunk/WebCore

Remaining new files for Canvas3D
https://bugs.webkit.org/show_bug.cgi?id=28018

4:58 AM Changeset in webkit [47707] by ariya@webkit.org

1 edit
4 adds in trunk/LayoutTests

2009-08-24 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Add results for new tests added in r47590 and r47702.

platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt: Added.
platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt: Added.
platform/qt/fast/repaint/inline-block-resize-expected.txt: Added.

4:05 AM Changeset in webkit [47706] by ariya@webkit.org

2 edits in trunk/LayoutTests

2009-08-24 Ariya Hidayat <ariya.hidayat@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] Skip new test added in r47630

platform/qt/Skipped: Skip fast/backgrounds/size/parsing-inherit.html.

3:18 AM Changeset in webkit [47705] by ariya@webkit.org

5 edits in trunk/LayoutTests

2009-08-24 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Update the outdated metrics for doctype tests. All tests pass.

platform/qt/Skipped:
platform/qt/fast/doctypes/001-expected.txt:
platform/qt/fast/doctypes/002-expected.txt:
platform/qt/fast/doctypes/004-expected.txt:

3:09 AM Changeset in webkit [47704] by ariya@webkit.org

1 edit
19 adds in trunk/LayoutTests

2009-08-24 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

[Qt] Add results for new tests added in r47678.

platform/qt/fast/block/margin-collapse/block-inside-inline: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/001-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/002-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/003-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/006-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/017-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/018-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/019-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/021-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/022-expected.txt: Added.
platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.txt: Added.

3:09 AM Changeset in webkit [47703] by pfeldman@chromium.org

11 edits in trunk/WebCore

2009-08-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Migrate call frames interaction to the InjectedScript-based schema.

https://bugs.webkit.org/show_bug.cgi?id=28408

inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update):
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleTextMessage):
inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.get domWindow): (InspectorController.openInInspectedWindow): (InspectorController.getCallFrames): (InspectorController.evaluateInCallFrame):
inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.generateStylesheet):
inspector/front-end/InjectedScript.js: (InjectedScript.evaluate): (InjectedScript._evaluateOn): (InjectedScript.openInInspectedWindow): (InjectedScript.getCallFrames): (InjectedScript.evaluateInCallFrame): (InjectedScript._callFrameForId): (InjectedScript._objectForId): (InjectedScript.CallFrameProxy): (InjectedScript.CallFrameProxy.prototype._wrapScopeChain):
inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype._update):
inspector/front-end/ObjectProxy.js: (WebInspector.ObjectPropertyProxy):
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane): (WebInspector.ScopeChainSidebarPane.prototype.update): (WebInspector.ScopeVariableTreeElement.prototype.onattach): (WebInspector.ScopeVariableTreeElement.prototype.onexpand): (WebInspector.ScopeVariableTreeElement.prototype.oncollapse):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame): (WebInspector.ScriptsPanel.prototype.variablesInSelectedCallFrame): (WebInspector.ScriptsPanel.prototype.debuggerPaused.callback): (WebInspector.ScriptsPanel.prototype.debuggerPaused):

1:28 AM Changeset in webkit [47702] by eric@webkit.org

21 edits
9 adds in trunk

2009-08-24 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Add tests for the placeholder attribute and DOM property of the textarea element.
Correct the results for input-text-maxlength.html https://bugs.webkit.org/show_bug.cgi?id=21248

fast/forms/resources/textarea-placeholder-dom-property.js: Added.
fast/forms/textarea-placeholder-dom-property-expected.txt: Added.
fast/forms/textarea-placeholder-dom-property.html: Added.
fast/forms/textarea-placeholder-pseudo-style.html: Added.
fast/forms/textarea-placeholder-set-attribute.html: Added.
fast/forms/textarea-placeholder-set-value.html: Added.
platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt:
platform/mac/fast/forms/input-text-maxlength-expected.txt:
platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
platform/mac/fast/forms/textarea-placeholder-set-attribute-expected.txt: Added.
platform/mac/fast/forms/textarea-placeholder-set-value-expected.txt: Added.
platform/qt/fast/forms/input-text-maxlength-expected.txt:
platform/win/fast/forms/input-text-maxlength-expected.txt:

2009-08-24 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Add support for the placeholder attribute and DOM property of the textarea element.
https://bugs.webkit.org/show_bug.cgi?id=21248

A DOM node for an INPUT element doesn't have a flag for placeholder
visibility anymore. This patch also fixes a bug that a renderer
doesn't reflect a corresponding DOM value change.

Tests: fast/forms/textarea-placeholder-dom-property.html

fast/forms/textarea-placeholder-pseudo-style.html
fast/forms/textarea-placeholder-set-attribute.html
fast/forms/textarea-placeholder-set-value.html

css/html.css: Add the default style for placeholder of textarea.
dom/InputElement.cpp: Cleanup for m_placeholderShouldBeVisible removal (WebCore::InputElement::dispatchFocusEvent): (WebCore::InputElement::dispatchBlurEvent): (WebCore::InputElement::placeholderShouldBeVisible): (WebCore::InputElement::updatePlaceholderVisibility): (WebCore::InputElement::setValueFromRenderer): (WebCore::InputElementData::InputElementData):
dom/InputElement.h:
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dispatchFocusEvent): (WebCore::HTMLInputElement::dispatchBlurEvent): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::placeholderShouldBeVisible):
html/HTMLInputElement.h: (WebCore::HTMLInputElement::updatePlaceholderVisibility):
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute): (WebCore::HTMLTextAreaElement::setValue): (WebCore::HTMLTextAreaElement::placeholderShouldBeVisible): (WebCore::HTMLTextAreaElement::updatePlaceholderVisibility): (WebCore::HTMLTextAreaElement::dispatchFocusEvent): (WebCore::HTMLTextAreaElement::dispatchBlurEvent):
html/HTMLTextAreaElement.h:
html/HTMLTextAreaElement.idl:
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::styleDidChange): (WebCore::RenderTextControl::setInnerTextStyle): (WebCore::RenderTextControl::updatePlaceholderVisibility):
rendering/RenderTextControl.h:
rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine): (WebCore::RenderTextControlMultiLine::nodeAtPoint): (WebCore::RenderTextControlMultiLine::updateFromElement): (WebCore::RenderTextControlMultiLine::createInnerTextStyle): (WebCore::RenderTextControlMultiLine::textBaseStyle):
rendering/RenderTextControlMultiLine.h:
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::textBaseStyle): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
rendering/RenderTextControlSingleLine.h:
wml/WMLInputElement.cpp: (WebCore::WMLInputElement::dispatchFocusEvent): (WebCore::WMLInputElement::dispatchBlurEvent): (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::placeholderShouldBeVisible):

12:14 AM Changeset in webkit [47701] by zoltan@webkit.org